gdb/ChangeLog

   1 2019-09-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
   4         Update.
   5         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
   6         prefix.
   7         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
   8         (tui_data_window::line_from_reg_element_no)
   9         (tui_data_window::first_reg_element_no_inline)
  10         (tui_data_window::show_registers)
  11         (tui_data_window::show_register_group)
  12         (tui_data_window::display_registers_from)
  13         (tui_data_window::display_registers_from_line)
  14         (tui_data_window::first_data_item_displayed)
  15         (tui_data_window::delete_data_content_windows)
  16         (tui_data_window::erase_data_content)
  17         (tui_data_window::do_scroll_vertical)
  18         (tui_data_window::refresh_window)
  19         (tui_data_window::check_register_values): Update.
  20
  21 2019-09-20  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
  24         (struct tui_locator_window) <full_name, proc_name>: Now
  25         std::string.
  26         * tui/tui-stack.c (tui_locator_window::make_status_line)
  27         (tui_locator_window::set_locator_fullname)
  28         (tui_locator_window::set_locator_info): Update.
  29         * tui/tui-source.c (tui_source_window::set_contents)
  30         (tui_source_window::showing_source_p): Update.
  31
  32 2019-09-20  Tom Tromey  <tom@tromey.com>
  33
  34         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
  35         Don't call tui_locator_win_info_ptr.
  36
  37 2019-09-20  Tom Tromey  <tom@tromey.com>
  38
  39         * tui/tui-win.c (tui_resize_all): Don't call refresh.
  40
  41 2019-09-20  Tom Tromey  <tom@tromey.com>
  42
  43         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
  44         height for locator.
  45         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
  46         * tui/tui-layout.c (show_source_disasm_command, show_data)
  47         (show_source_or_disasm_and_command): Use 1 as height for locator.
  48
  49 2019-09-20  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui.c (tui_enable): Update.
  52         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
  53         Update.
  54         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
  55         Update.
  56         * tui/tui-data.c (win_resized): Now bool.
  57         (tui_win_resized): Return bool.
  58         (tui_set_win_resized_to): Accept a bool.
  59
  60 2019-09-20  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
  63         Change type of "refresh_values_only".
  64         * tui/tui-regs.c (tui_data_window::show_register_group): Change
  65         type of "refresh_values_only".
  66
  67 2019-09-20  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
  70         std::string.
  71         (tui_disassemble): Add "pos" parameter.
  72         (tui_disasm_window::set_contents): Simplify.
  73
  74 2019-09-20  Tom Tromey  <tom@tromey.com>
  75
  76         * tui/tui-winsource.h (struct tui_source_window_base)
  77         <show_source_content>: Now private.
  78         * tui/tui-winsource.c
  79         (tui_source_window_base::show_source_content): Don't handle empty
  80         content case.
  81
  82 2019-09-20  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-layout.c (show_source_disasm_command)
  85         (show_source_or_disasm_and_command): Don't call
  86         show_source_content.
  87
  88 2019-09-20  Tom Tromey  <tom@tromey.com>
  89
  90         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
  91         Declare.
  92         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
  93         from tui_make_status_line.
  94         (tui_locator_window::rerender): Update.
  95
  96 2019-09-20  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-stack.c (tui_make_status_line): Return std::string.
  99         (tui_locator_window::rerender): Update.
 100
 101 2019-09-20  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-winsource.h (struct tui_source_window_base)
 104         <~tui_source_window_base>: Don't declare.
 105         <fullname>: Remove.
 106         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 107         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 108         member.
 109         * tui/tui-source.c (tui_source_window::set_contents): Update.
 110         (tui_source_window::location_matches_p)
 111         (tui_source_window::maybe_update): Update.
 112
 113 2019-09-20  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-winsource.h (~tui_source_element): Remove.
 116         (tui_source_element): Update.
 117         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 118         * tui/tui-winsource.c (tui_show_source_line): Update.
 119         * tui/tui-source.c (tui_source_window::set_contents): Update.
 120         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 121
 122 2019-09-20  Tom Tromey  <tom@tromey.com>
 123
 124         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 125         declare.
 126         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 127         tui_clear_source_windows_detail.
 128         * tui/tui-winsource.h (struct tui_source_window_base)
 129         <clear_detail>: Don't declare.
 130         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 131         Remove.
 132         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 133
 134 2019-09-20  Tom Tromey  <tromey@adacore.com>
 135
 136         PR ada/24919:
 137         * block.c (contained_in): Fix final return value.
 138
 139 2019-09-20  Alan Modra  <amodra@gmail.com>
 140
 141         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 142         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 143         (read_indirect_string_from_dwz): Use bfd accessor.
 144         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 145         * machoread.c (macho_symfile_read_all_oso): Likewise.
 146         * solib.c (solib_bfd_open): Likewise.
 147
 148 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 149
 150         * eval.c: Move declaration of overload_resolution to...
 151         * value.h: ...here.
 152
 153 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 154
 155         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 156         * arm-linux-tdep.c: Likewise.
 157         * arm-nbsd-nat.c: Likewise.
 158         * arm-tdep.h: Declare arm_apcs_32.
 159         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 160
 161 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 162
 163         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 164         * dwarf2read.h: Declare dwarf_always_disassemble.
 165
 166 2019-09-19  Tom de Vries  <tdevries@suse.de>
 167
 168         PR gdb/25009
 169         * source-cache.c (source_cache::ensure): Catch exception thrown during
 170         construction of the highlighter.
 171
 172 2019-09-18  Alan Modra  <amodra@gmail.com>
 173
 174         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 175         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 176         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 177         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 178         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 179         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 180         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 181         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 182         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 183         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 184         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 185         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 186         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 187         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 188         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 189         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 190         * mi/mi-interp.c: Update throughout for bfd section macro and
 191         function changes.
 192         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 193         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 194
 195 2019-09-18  Tom Tromey  <tom@tromey.com>
 196
 197         * NEWS: Add entry.
 198         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 199         call rl_initialize.
 200         (tui_enable): Do not call rl_initialize.
 201
 202 2019-09-18  Christian Groessler  <chris@groessler.org>
 203
 204         * alpha-linux-nat.c: Include gdbarch.h.
 205
 206 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 207
 208         * ui-file.c: Include cli/cli-style.h.
 209         (term_cli_styling): Remove cli_styling declaration.
 210
 211 2019-09-18  Alan Modra  <amodra@gmail.com>
 212
 213         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 214         to bfd_asymbol_section.
 215
 216 2019-09-18  Alan Modra  <amodra@gmail.com>
 217
 218         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 219         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 220         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 221
 222 2019-09-18  Alan Modra  <amodra@gmail.com>
 223
 224         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 225         * spu-linux-nat.c (spu_bfd_open): Likewise.
 226
 227 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 228
 229         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 230         to bool to match definition in dwarf2read.c.
 231
 232 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 233
 234         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 235         (print_signatures): Likewise.
 236         (trust_pad_over_xvs): Likewise.
 237         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 238         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 239         * arm-linux-nat.c (arm_apcs_32): Likewise.
 240         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 241         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 242         * arm-tdep.c (arm_debug): Likewise.
 243         (arm_apcs_32): Likewise.
 244         * auto-load.c (debug_auto_load): Likewise.
 245         (auto_load_gdb_scripts): Likewise.
 246         (global_auto_load): Likewise.
 247         (auto_load_local_gdbinit): Likewise.
 248         (auto_load_local_gdbinit_loaded): Likewise.
 249         * auto-load.h (global_auto_load): Likewise.
 250         (auto_load_local_gdbinit): Likewise.
 251         (auto_load_local_gdbinit_loaded): Likewise.
 252         * breakpoint.c (disconnected_dprintf): Likewise.
 253         (breakpoint_proceeded): Likewise.
 254         (automatic_hardware_breakpoints): Likewise.
 255         (always_inserted_mode): Likewise.
 256         (target_exact_watchpoints): Likewise.
 257         (_initialize_breakpoint): Update.
 258         * breakpoint.h (target_exact_watchpoints): Change to bool.
 259         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 260         * cli/cli-cmds.c (trace_commands): Likewise.
 261         * cli/cli-cmds.h (trace_commands): Likewise.
 262         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 263         to bool*.
 264         * cli/cli-logging.c (logging_overwrite): Change to bool.
 265         (logging_redirect): Likewise.
 266         (debug_redirect): Likewise.
 267         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 268         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 269         to bool.
 270         <boolean_option_def>: Update.
 271         (struct flag_option_def): Change default type of Context to bool
 272         from int.
 273         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 274         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 275         (get_setshow_command_value_string): Likewise.
 276         * cli/cli-style.c (cli_styling): Change to bool.
 277         (source_styling): Likewise.
 278         * cli/cli-style.h (source_styling): Likewise.
 279         (cli_styling): Likewise.
 280         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 281         to bool.
 282         * command.h (var_types): Update comment.
 283         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 284         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 285         bool.
 286         (debug_compile_cplus_scopes): Likewise.
 287         * compile/compile-internal.h (compile_debug): Likewise.
 288         * compile/compile.c (compile_debug): Likewise.
 289         (struct compile_options) <raw>: Likewise.
 290         * cp-support.c (catch_demangler_crashes): Likewise.
 291         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 292         (usr_cmd_cris_dwarf2_cfi): Likewise.
 293         * csky-tdep.c (csky_debug): Likewise.
 294         * darwin-nat.c (enable_mach_exceptions): Likewise.
 295         * dcache.c (dcache_enabled_p): Likewise.
 296         * defs.h (info_verbose): Likewise.
 297         * demangle.c (demangle): Likewise.
 298         (asm_demangle): Likewise.
 299         * dwarf-index-cache.c (debug_index_cache): Likewise.
 300         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 301         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 302         * dwarf2read.c (check_physname): Likewise.
 303         (use_deprecated_index_sections): Likewise.
 304         (dwarf_always_disassemble): Likewise.
 305         * eval.c (overload_resolution): Likewise.
 306         * event-top.c (set_editing_cmd_var): Likewise.
 307         (exec_done_display_p): Likewise.
 308         * event-top.h (set_editing_cmd_var): Likewise.
 309         (exec_done_display_p): Likewise.
 310         * exec.c (write_files): Likewise.
 311         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 312         (debug_fbsd_nat): Likewise.
 313         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 314         Likewise.
 315         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 316         <backtrace_past_entry> Likewise.
 317         * gdb-demangle.h (demangle): Likewise.
 318         (asm_demangle): Likewise.
 319         * gdb_bfd.c (bfd_sharing): Likewise.
 320         * gdbcore.h (write_files): Likewise.
 321         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 322         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 323         * gdbthread.h (print_thread_events): Likewise.
 324         * gdbtypes.c (opaque_type_resolution): Likewise.
 325         (strict_type_checking): Likewise.
 326         * gnu-nat.c (gnu_debug_flag): Likewise.
 327         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 328         * guile/scm-param.c (pascm_variable): Add boolval.
 329         (add_setshow_generic): Update.
 330         (pascm_param_value): Update.
 331         (pascm_set_param_value_x): Update.
 332         * hppa-tdep.c (hppa_debug): Change to bool..
 333         * infcall.c (may_call_functions_p): Likewise.
 334         (coerce_float_to_double_p): Likewise.
 335         (unwind_on_signal_p): Likewise.
 336         (unwind_on_terminating_exception_p): Likewise.
 337         * infcmd.c (startup_with_shell): Likewise.
 338         * inferior.c (print_inferior_events): Likewise.
 339         * inferior.h (startup_with_shell): Likewise.
 340         (print_inferior_events): Likewise.
 341         * infrun.c (step_stop_if_no_debug): Likewise.
 342         (detach_fork): Likewise.
 343         (debug_displaced): Likewise.
 344         (disable_randomization): Likewise.
 345         (non_stop): Likewise.
 346         (non_stop_1): Likewise.
 347         (observer_mode): Likewise.
 348         (observer_mode_1): Likewise.
 349         (set_observer_mode): Update.
 350         (sched_multi): Change to bool.
 351         * infrun.h (debug_displaced): Likewise.
 352         (sched_multi): Likewise.
 353         (step_stop_if_no_debug): Likewise.
 354         (non_stop): Likewise.
 355         (disable_randomization): Likewise.
 356         * linux-tdep.c (use_coredump_filter): Likewise.
 357         (dump_excluded_mappings): Likewise.
 358         * linux-thread-db.c (auto_load_thread_db): Likewise.
 359         (check_thread_db_on_load): Likewise.
 360         * main.c (captured_main_1): Update.
 361         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 362         xx2_opt, boolean_opt>: Change to bool.
 363         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 364         * maint.c (maintenance_profile_p): Likewise.
 365         (per_command_time): Likewise.
 366         (per_command_space): Likewise.
 367         (per_command_symtab): Likewise.
 368         * memattr.c (inaccessible_by_default): Likewise.
 369         * mi/mi-main.c (mi_async): Likewise.
 370         (mi_async_1): Likewise.
 371         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 372         * nat/fork-inferior.h (startup_with_shell): Likewise.
 373         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 374         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 375         * nios2-tdep.c (nios2_debug): Likewise.
 376         * or1k-tdep.c (or1k_debug): Likewise.
 377         * parse.c (parser_debug): Likewise.
 378         * parser-defs.h (parser_debug): Likewise.
 379         * printcmd.c (print_symbol_filename): Likewise.
 380         * proc-api.c (procfs_trace): Likewise.
 381         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 382         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 383         (set_parameter_value): Update.
 384         (add_setshow_generic): Update.
 385         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 386         to bool*.
 387         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 388         int*.
 389         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 390         * record-btrace.c (record_btrace_target::store_registers): Update.
 391         * record-full.c (record_full_memory_query): Change to bool.
 392         (record_full_stop_at_limit): Likewise.
 393         * record-full.h (record_full_memory_query): Likewise.
 394         * remote-notif.c (notif_debug): Likewise.
 395         * remote-notif.h (notif_debug): Likewise.
 396         * remote.c (use_range_stepping): Likewise.
 397         (interrupt_on_connect): Likewise.
 398         (remote_break): Likewise.
 399         * ser-tcp.c (tcp_auto_retry): Likewise.
 400         * ser-unix.c (serial_hwflow): Likewise.
 401         * skip.c (debug_skip): Likewise.
 402         * solib-aix.c (solib_aix_debug): Likewise.
 403         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 404         (spu_auto_flush_cache_p): Likewise.
 405         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 406         Likewise.
 407         (struct info_print_options) <quiet>: Likewise.
 408         * symfile-debug.c (debug_symfile): Likewise.
 409         * symfile.c (auto_solib_add): Likewise.
 410         (separate_debug_file_debug): Likewise.
 411         * symfile.h (auto_solib_add): Likewise.
 412         (separate_debug_file_debug): Likewise.
 413         * symtab.c (basenames_may_differ): Likewise.
 414         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 415         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 416         (struct info_types_options) <quiet>: Likewise.
 417         * symtab.h (demangle): Likewise.
 418         (basenames_may_differ): Likewise.
 419         * target-dcache.c (stack_cache_enabled_1): Likewise.
 420         (code_cache_enabled_1): Likewise.
 421         * target.c (trust_readonly): Likewise.
 422         (may_write_registers): Likewise.
 423         (may_write_memory): Likewise.
 424         (may_insert_breakpoints): Likewise.
 425         (may_insert_tracepoints): Likewise.
 426         (may_insert_fast_tracepoints): Likewise.
 427         (may_stop): Likewise.
 428         (auto_connect_native_target): Likewise.
 429         (target_stop_and_wait): Update.
 430         (target_async_permitted): Change to bool.
 431         (target_async_permitted_1): Likewise.
 432         (may_write_registers_1): Likewise.
 433         (may_write_memory_1): Likewise.
 434         (may_insert_breakpoints_1): Likewise.
 435         (may_insert_tracepoints_1): Likewise.
 436         (may_insert_fast_tracepoints_1): Likewise.
 437         (may_stop_1): Likewise.
 438         * target.h (target_async_permitted): Likewise.
 439         (may_write_registers): Likewise.
 440         (may_write_memory): Likewise.
 441         (may_insert_breakpoints): Likewise.
 442         (may_insert_tracepoints): Likewise.
 443         (may_insert_fast_tracepoints): Likewise.
 444         (may_stop): Likewise.
 445         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 446         (make_thread_apply_all_options_def_group): Change argument from int*
 447         to bool*.
 448         (thread_apply_all_command): Update.
 449         (print_thread_events): Change to bool.
 450         * top.c (confirm): Likewise.
 451         (command_editing_p): Likewise.
 452         (history_expansion_p): Likewise.
 453         (write_history_p): Likewise.
 454         (info_verbose): Likewise.
 455         * top.h (confirm): Likewise.
 456         (history_expansion_p): Likewise.
 457         * tracepoint.c (disconnected_tracing): Likewise.
 458         (circular_trace_buffer): Likewise.
 459         * typeprint.c (print_methods): Likewise.
 460         (print_typedefs): Likewise.
 461         * utils.c (debug_timestamp): Likewise.
 462         (sevenbit_strings): Likewise.
 463         (pagination_enabled): Likewise.
 464         * utils.h (sevenbit_strings): Likewise.
 465         (pagination_enabled): Likewise.
 466         * valops.c (overload_resolution): Likewise.
 467         * valprint.h (struct value_print_options) <prettyformat_arrays,
 468         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 469         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 470         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 471         Likewise.
 472         * windows-nat.c (new_console): Likewise.
 473         (cygwin_exceptions): Likewise.
 474         (new_group): Likewise.
 475         (debug_exec): Likewise.
 476         (debug_events): Likewise.
 477         (debug_memory): Likewise.
 478         (debug_exceptions): Likewise.
 479         (useshell): Likewise.
 480         * windows-tdep.c (maint_display_all_tib): Likewise.
 481         * xml-support.c (debug_xml): Likewise.
 482
 483 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 484
 485         * source.c (prepare_path_for_appending): New function.
 486         (openp): Make use of new function.
 487         (find_and_open_source): Search for the compilation directory and
 488         source file as a relative path beneath the directory search path.
 489
 490 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 491
 492         * source-cache.c (source_cache::get_line_charpos): Catch
 493         exceptions and return false, this matches the behaviour documented
 494         in the header file.
 495
 496 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 497
 498         * ada-tasks.c (info_task): Remove quoting of the task's name.
 499
 500 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 501
 502         * symfile.c (auto_solib_add): Replace comment with a reference
 503         to the header file.
 504
 505 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 506
 507         * NEWS: Mention that gdb can now be compiled with Python 3
 508         on Windows.
 509
 510 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 511
 512         * maint.c (maint_print_section_data::maint_print_section_data):
 513         Force use of 'float log10 (float)' by casting the argument to
 514         float.
 515
 516 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 517
 518         * maint.c: Add 'cmath' include.
 519         (struct maint_print_section_data): New structure.
 520         (print_section_index): New function.
 521         (print_bfd_section_info): Add header comment, small whitespace
 522         cleanup, and update to call new print_section_index function.
 523         (print_objfile_section_info): Likewise.
 524         (maint_obj_section_from_bfd_section): New function.
 525         (print_bfd_section_info_maybe_relocated): New function.
 526         (maintenance_info_sections): Add header comment, always use
 527         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 528
 529 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 530
 531         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 532         inner scope, add check that the objfile has psymtabs before
 533         checking psymtabs_addrmap.
 534         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 535
 536 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 537
 538         * NEWS: Announce that Ada task names are now shown at more places,
 539         and between quotes (except in info task output).
 540         * gdb/ada-tasks.c (task_to_str): New function.
 541         (display_current_task_id): Call task_to_str.
 542         (task_command_1): Likewise.
 543         (print_ada_task_info): In non-mi mode, Properly align headers and data
 544         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 545
 546 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 547
 548         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 549         prstatus.pr_lwp.pr_info instead of making it up.
 550
 551 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 552
 553         * auto-load.c (auto_load_expand_dir_vars): Update.
 554         * defs.h (gdb_datadir): Change to std::string.
 555         (python_libdir): Likewise.
 556         (relocate_gdb_directory): Change return type to std::string.
 557         * guile/guile.c (gdbscm_data_directory): Update.
 558         (initialize_scheme_side): Update.
 559         * jit.c (jit_reader_dir): Change to std::string.
 560         (jit_reader_load_command): Update.
 561         * main.c (gdb_datadir): Change to std::string.
 562         (python_libdir): Likewise.
 563         (set_gdb_data_directory): Update.
 564         (relocate_path): Change to return std::string.
 565         (relocate_gdb_directory): Change to return std::string.
 566         (relocate_gdbinit_path_maybe_in_datadir): Update.
 567         (captured_main_1): Update.
 568         * python/python.c (do_start_initialization): Update.
 569         * top.c (show_gdb_datadir): Update.
 570         * xml-syscall.c (xml_init_syscalls_info): Update.
 571         (init_syscalls_info): Update.
 572
 573 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 574
 575         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 576         out of get_init_files.
 577         (get_init_files): Update.
 578
 579 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 580
 581         * main.c (get_init_files): Change to use std::string.
 582         (captured_main_1): Update.
 583         (print_gdb_help): Update.
 584
 585 2019-09-11  Ali Tamur  <tamur@google.com>
 586
 587         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 588         implementation.
 589
 590 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 591
 592         * dbxread.c (read_dbx_symtab): Update.
 593         * dwarf2read.c (load_partial_dies): Update.
 594         * mdebugread.c (parse_partial_symbols): Update.
 595         (handle_psymbol_enumerators): Update.
 596         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 597         * psymtab.c (add_psymbol_to_bcache): Likewise.
 598         (add_psymbol_to_list): Likewise.
 599         * symtab.c (symbol_set_names): Likewise.
 600         * symtab.h (symbol_set_names): Likewise.
 601         * xcoffread.c (scan_xcoff_symtab): Update.
 602
 603 2019-09-11  Tom Tromey  <tom@tromey.com>
 604
 605         * symfile-mem.c (symbol_file_add_from_memory): Use
 606         bfd_set_filename.
 607         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 608         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 609
 610 2019-09-10  Tom Tromey  <tromey@adacore.com>
 611
 612         * dwarf-index-write.c (write_psymbols): Extend error message.
 613         (debug_names::insert): Add Ada code.
 614         (debug_names::write_psymbols): Remove Ada check.
 615         (debug_names) <m_string_obstack>: New member.
 616         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 617         (gdb_index_symbol_name_matcher::matches): Remove.
 618         (mapped_index_base::find_name_components_bounds): Add "lang"
 619         parameter.
 620         (mapped_index_base::build_name_components): Also split names
 621         according to Ada syntax.
 622         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 623         type of "match_callback".
 624         (check_match, check_find_bounds_finds)
 625         (dw2_expand_symtabs_matching): Update.
 626         (dw2_debug_names_iterator): Add new constructor.
 627         (dw2_debug_names_map_matching_symbols): New function.
 628         (dw2_debug_names_expand_symtabs_matching): Update.
 629         (dwarf2_debug_names_functions): Use
 630         dw2_debug_names_map_matching_symbols.
 631
 632 2019-09-10  Tom Tromey  <tromey@adacore.com>
 633
 634         * dwarf2read.c (dw2_get_file_names_reader): Add the
 635         CU's file name to the results.
 636
 637 2019-09-10  Tom Tromey  <tromey@adacore.com>
 638
 639         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 640         map_matching_symbols.  Update.
 641         * dwarf2read.c (dw2_map_matching_symbols): Update.
 642         * psymtab.c (match_partial_symbol): Change type; update.
 643         (psym_map_matching_symbols): Likewise.
 644         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 645         type; update.
 646         * symfile.h (struct quick_symbol_functions)
 647         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 648         Remove "match".
 649
 650 2019-09-10  Tom Tromey  <tromey@adacore.com>
 651
 652         * psymtab.c (map_block): Remove.
 653         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 654         * symtab.c (iterate_over_symbols_terminated): New function.
 655         * symtab.c (iterate_over_symbols_terminated): Declare.
 656
 657 2019-09-10  Tom Tromey  <tromey@adacore.com>
 658
 659         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 660         * language.h (struct language_defn) <la_iterate_over_symbols>:
 661         Return bool.
 662         * symtab.c (iterate_over_symbols): Return bool.
 663         * symtab.h (iterate_over_symbols): Return bool.
 664
 665 2019-09-10  Tom Tromey  <tromey@adacore.com>
 666
 667         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 668         (add_nonlocal_symbols): Update.
 669         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 670         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 671         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 672         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 673         Change type of "callback".  Remove "data".
 674
 675
 676 2019-09-09  Ali Tamur  <tamur@google.com>
 677
 678         * dwarf2read.c (comp_unit_head): Update comment.
 679         (dwarf2_dwo_name): New function declaration.
 680         (dwarf_unit_type_name): New function declaration.
 681         (read_comp_unit_head): Add support for new compilation units,
 682         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 683         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 684         (currently named as "signature") in their header. Also clarify error
 685         messages.
 686         (lookup_dwo_id): New function. Returns the dwo id of the given
 687         compile unit.
 688         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 689         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 690         functions.
 691         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 692         (dwarf2_dwo_name): Get the dwo name if present.
 693         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 694         purposes.
 695
 696 2019-09-09  Tom Tromey  <tom@tromey.com>
 697
 698         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 699
 700 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 701
 702         * python/python.c (do_start_initialization): Make progname_copy static,
 703         to avoid a leak report.
 704
 705 2019-09-08  Tom Tromey  <tom@tromey.com>
 706
 707         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 708
 709 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 710
 711         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 712         Change type to gdb::optional<block_enum>.
 713         (dw2_symtab_iter_init): Change block_index parameter type
 714         to gdb::optional<block_enum>.
 715         (dw2_lookup_symbol): Change block_index parameter
 716         type to block_enum.c
 717         (dw2_debug_names_lookup_symbol): Likewise.
 718         * psymtab.c (psym_lookup_symbol): Likewise.
 719         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 720         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 721         Likewise.
 722
 723 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 724
 725         * defs.h (relocate_gdb_directory): Change int to bool in
 726         signature and rename flag to relocatable.
 727         * main.c (relocate_path): Likewise.
 728         (relocate_gdb_directory): Likewise.
 729
 730 2019-09-06  Alan Modra  <amodra@gmail.com>
 731
 732         * coffread.c (coff_symfile_read): Constify filename variable.
 733         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 734         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 735         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 736         * solib.c (reload_shared_libraries_1): Likewise.
 737         * symfile.c (reread_symbols): Likewise.
 738         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 739         * solib-darwin.c (darwin_bfd_open): Likewise.
 740         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 741
 742 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 743
 744         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 745         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 746
 747 2019-09-03  Tom Tromey  <tromey@adacore.com>
 748
 749         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 750         types.
 751         (has_negatives): Unbias a range type bound.
 752         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 753         * gdbtypes.c (operator==): Handle new field.
 754         (create_range_type): Add "bias" parameter.
 755         (create_static_range_type, resolve_dynamic_range): Update.
 756         * gdbtypes.h (struct range_bounds) <bias>: New member.
 757         (create_range_type): Add bias parameter.
 758         * printcmd.c (print_scalar_formatted): Unbias range types.
 759         * value.c (unpack_long): Unbias range types.
 760         (pack_long): Bias range types.
 761
 762 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 763
 764         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 765         probe arguments.
 766
 767 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 768
 769         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 770         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 771         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 772         (compile_probe_arg): Likewise.
 773         * probe.h (get_argument_count): Likewise.
 774         * solib-svr4.c (solib_event_probe_action): Likewise.
 775         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 776
 777 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 778
 779         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 780         code to here...
 781         (svr4_create_solib_event_breakpoints): ...from here.
 782
 783 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 784
 785         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 786         suffix from warning message.
 787
 788 2019-08-30  Tom Tromey  <tom@tromey.com>
 789
 790         * tui/tui-winsource.h (struct tui_source_window_base)
 791         <refresh_all>: Don't declare.
 792         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 793         Remove.
 794         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 795         tui_show_locator_content.
 796         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 797         declare.
 798         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 799         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 800         declare.
 801
 802 2019-08-30  Tom Tromey  <tom@tromey.com>
 803
 804         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 805
 806 2019-08-30  Tom Tromey  <tom@tromey.com>
 807
 808         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 809         Remove unnecessary forward declarations.
 810
 811 2019-08-30  Tom Tromey  <tom@tromey.com>
 812
 813         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 814         rerender.
 815         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 816         tui_show_locator_content.
 817
 818 2019-08-30  Tom Tromey  <tom@tromey.com>
 819
 820         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 821         (tui_locator_window::rerender): Rewrite using body of previous
 822         tui_show_locator_content.
 823
 824 2019-08-30  Tom Tromey  <tom@tromey.com>
 825
 826         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 827         set_locator_fullname>: New methods.
 828         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 829         Rename from tui_set_locator_fullname.
 830         (tui_locator_window::set_locator_info): Rename from
 831         tui_set_locator_info.  Return bool.
 832         (tui_update_locator_fullname, tui_show_frame_info): Update.
 833
 834 2019-08-30  Tom Tromey  <tom@tromey.com>
 835
 836         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 837
 838 2019-08-30  Tom Tromey  <tom@tromey.com>
 839
 840         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 841         call touchwin.
 842
 843 2019-08-30  Tom Tromey  <tom@tromey.com>
 844
 845         * tui/tui-wingeneral.c (box_win): Assume win_info and
 846         win_info->handle cannot be NULL.
 847
 848 2019-08-30  Tom Tromey  <tom@tromey.com>
 849
 850         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 851         refresh_window>: Declare.
 852         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 853         resize.
 854         (tui_data_item_window::rerender): Rename from
 855         tui_display_register.
 856         (tui_data_item_window::refresh_window): New method.
 857         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 858         no-op.
 859
 860 2019-08-30  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 863         regs_column_count, current_group>: Move later.  Now private.
 864         <get_current_group>: New method.
 865         * tui/tui-regs.c (tui_reg_command): Update.
 866         * tui/tui-layout.c (tui_set_layout): Update.
 867
 868 2019-08-30  Tom Tromey  <tom@tromey.com>
 869
 870         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 871         (tui_data_window::rerender): Don't call
 872         check_and_display_highlight_if_needed.
 873         (tui_data_window::refresh_all): Remove call to
 874         erase_data_content.
 875
 876 2019-08-30  Tom Tromey  <tom@tromey.com>
 877
 878         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 879         (tui_data_window::display_registers_from)
 880         (tui_data_window::display_reg_element_at_line)
 881         (tui_data_window::display_registers_from_line): Remove checks of
 882         "empty".
 883
 884 2019-08-30  Tom Tromey  <tom@tromey.com>
 885
 886         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 887         Don't declare.
 888         * tui/tui-regs.c (tui_data_window::show_registers): Call
 889         rerender.
 890         (tui_data_window::rerender): Rename from display_all_data.
 891         (tui_data_window::rerender): Remove old implementation.
 892
 893 2019-08-30  Tom Tromey  <tom@tromey.com>
 894
 895         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 896         text.
 897         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 898
 899 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 900             Sergio Durigan Junior  <sergiodj@redhat.com>
 901
 902         PR win32/24284
 903         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 904
 905 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 906
 907         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 908         when searching for types.
 909
 910 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 911
 912         * f-lang.c (f_language_defn): Use f_print_typedef.
 913         * f-lang.h (f_print_typedef): Declare.
 914         * f-typeprint.c (f_print_typedef): Define.
 915
 916 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 917
 918         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 919
 920 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 921
 922         * cli/cli-utils.c (info_print_options_defs): Delete.
 923         (make_info_print_options_def_group): Delete.
 924         (extract_info_print_options): Delete.
 925         (info_print_command_completer): Delete.
 926         (info_print_args_help): Add extra parameter, and optionally
 927         include text about -n flag.
 928         * cli/cli-utils.h (struct info_print_options): Delete.
 929         (extract_info_print_options): Delete declaration.
 930         (info_print_command_completer): Delete declaration.
 931         (info_print_args_help): Add extra parameter, extend header
 932         comment.
 933         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 934         search_symbols.
 935         * stack.c (struct info_print_options): New type.
 936         (info_print_options_defs): New file scoped variable.
 937         (make_info_print_options_def_group): New static function.
 938         (info_print_command_completer): New static function.
 939         (info_locals_command): Update to use new local functions.
 940         (info_args_command): Likewise.
 941         (_initialize_stack): Add extra parameter to calls to
 942         info_print_args_help.
 943         * symtab.c (search_symbols): Add extra parameter, use this to
 944         possibly excluse non-debug symbols.
 945         (symtab_symbol_info): Add extra parameter, which is passed on to
 946         search_symbols.
 947         (struct info_print_options): New type.
 948         (info_print_options_defs): New file scoped variable.
 949         (make_info_print_options_def_group): New static function.
 950         (info_print_command_completer): New static function.
 951         (info_variables_command): Update to use local functions, and pass
 952         extra parameter through to symtab_symbol_info.
 953         (info_functions_command): Likewise.
 954         (info_types_command): Pass additional argument through to
 955         symtab_symbol_info.
 956         (rbreak_command): Pass extra argument to search_symbols.
 957         (_initialize_symtab): Add extra arguments for calls to
 958         info_print_args_help, and update help text for 'info variables',
 959         'whereis', and 'info functions' commands.
 960         * symtab.h (search_symbols): Add extra argument to declaration.
 961         * NEWS: Mention new flags.
 962
 963 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 964
 965         * symtab.c (lookup_static_symbol): Call the new function (and move
 966         it down to be next to lookup_global_symbol).
 967         (struct global_sym_lookup_data): Add block_enum member and rename to...
 968         (struct global_or_static_sym_lookup_data): ...this.
 969         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 970         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 971         (lookup_symbol_global_or_static_iterator_cb): ...this.
 972         (lookup_global_or_static_symbol): New function.
 973         (lookup_global_symbol): Call new function.
 974
 975 2019-08-26  Tom de Vries  <tdevries@suse.de>
 976
 977         PR c++/24852
 978         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 979         when pc_probe.prob == NULL.
 980
 981 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 982
 983         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 984         variable symbol_linkage to symbol_linkage_.
 985
 986 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 987
 988         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 989         represent whether the symbol is static, dynamic, or we don't
 990         know.
 991
 992 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 993
 994         * gdb/rx-tdep.c (rx_register_names): New.
 995         (rx_register_name): Delete.
 996         (rx_psw_type): Delete.
 997         (rx_fpsw_type): Delete.
 998         (rx_register_type): Delete.
 999         (rx_gdbarch_init): Convert target-descriptions.
1000         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1001         * gdb/features/Makefile: Add rx.xml.
1002         * gdb/features/rx.xml: New.
1003         * gdb/features/rx.c: Generated.
1004         * gdb/NEWS: Mention target description support.
1005
1006 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1007
1008         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1009         *slot_ptr.
1010
1011 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1012
1013         * configure.ac: Don't check for 'dlfcn.h' (moved to
1014         gdbsupport/common.m4).
1015         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1016         'gdbsupport/'.
1017         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1018         * compile/compile-c-support.c: Include
1019         'gdbsupport/gdb-dlfcn.h'.
1020         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1021         * gdb-dlfcn.c: Move to...
1022         * gdbsupport/gdb-dlfcn.c: ... here.
1023         * gdb-dlfcn.h: Move to...
1024         * gdbsupport/gdb-dlfcn.h: ... here.
1025
1026 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1027
1028         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1029         the offset field signed.
1030
1031 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1032
1033         * python/lib/gdb/__init__.py (_execute_file): New function.
1034         * python/python.c (python_run_simple_file): Call gdb._execute_file
1035         on Windows.
1036
1037 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1038
1039         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1040         all uses as this was never set to anything but a zero value.
1041
1042 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1043
1044         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1045
1046 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1047
1048         * tui/tui-data.h (tui_gen_win_info): Add an =default
1049         move constructor, required by some GCC versions.
1050
1051 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1052
1053         * go32-nat.c (go32_sysinfo): Add hygon_p.
1054
1055 2019-08-20  Tom Tromey  <tom@tromey.com>
1056
1057         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1058         line_from_reg_element_no, first_reg_element_no_inline,
1059         display_all_data, delete_data_content_windows,
1060         erase_data_content>: Now private.
1061
1062 2019-08-20  Tom Tromey  <tom@tromey.com>
1063
1064         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1065         (tui_unhighlight_win, tui_highlight_win)
1066         (tui_win_info::make_window): Update.
1067         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1068
1069 2019-08-20  Tom Tromey  <tom@tromey.com>
1070
1071         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1072         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1073         (MAX_PID_WIDTH): Move to tui-stack.c.
1074         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1075         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1076         (MAX_PID_WIDTH): Move from tui-data.h.
1077
1078 2019-08-20  Tom Tromey  <tom@tromey.com>
1079
1080         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1081         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1082         (box_win): Update.
1083         (tui_gen_win_info::make_window): Rename from tui_make_window.
1084         (tui_win_info::make_window): New method.
1085         (tui_gen_win_info::make_visible): Update.
1086         * tui/tui-source.c (tui_source_window::set_contents): Update.
1087         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1088         (tui_data_window::display_registers_from): Update.
1089         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1090         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1091         Declare.
1092         <can_box>: Remove.
1093         <title>: Remove.
1094         (struct tui_win_info) <make_window>: Declare.
1095         <can_box>: Now virtual.
1096         <title>: New member.
1097         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1098         * tui/tui-command.c (tui_cmd_window::resize): Update.
1099
1100 2019-08-20  Tom Tromey  <tom@tromey.com>
1101
1102         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1103         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1104         (tui_data_window::check_register_values): Update.
1105
1106 2019-08-20  Tom Tromey  <tom@tromey.com>
1107
1108         * tui/tui-regs.h (struct tui_data_window): Use
1109         DISABLE_COPY_AND_ASSIGN.
1110         <regs_content>: Change type, removing unique_ptr.
1111         <tui_data_window>: Add move constructor.
1112         * tui/tui-regs.c (tui_data_window::show_registers)
1113         (tui_data_window::show_register_group)
1114         (tui_data_window::display_registers_from)
1115         (tui_data_window::display_registers_from)
1116         (tui_data_window::first_data_item_displayed)
1117         (tui_data_window::delete_data_content_windows)
1118         (tui_data_window::rerender, tui_data_window::refresh_window)
1119         (tui_data_window::check_register_values): Update.
1120
1121 2019-08-20  Tom Tromey  <tom@tromey.com>
1122
1123         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1124         show_register_group>: Declare.
1125         (tui_show_register_group): Don't declare.
1126         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1127         tui_show_registers.
1128         (tui_data_window::show_register_group): Rename from
1129         tui_show_register_group.
1130         (tui_data_window::check_register_values, tui_reg_command):
1131         Update.
1132         * tui/tui-layout.c (tui_set_layout): Update.
1133
1134 2019-08-20  Tom Tromey  <tom@tromey.com>
1135
1136         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1137         Declare.
1138         (tui_check_register_values): Don't declare.
1139         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1140         from tui_check_register_values.
1141         * tui/tui-hooks.c (tui_register_changed): Update.
1142
1143 2019-08-20  Tom Tromey  <tom@tromey.com>
1144
1145         * tui/tui-regs.c (tui_reg_layout): Move later.
1146         (tui_show_registers): Don't enable TUI mode or change layout.
1147
1148 2019-08-20  Tom Tromey  <tom@tromey.com>
1149
1150         * tui/tui-regs.h (struct tui_data_item_window)
1151         <~tui_data_item_window>: Remove.
1152         <content>: Now a unique_xmalloc_ptr.
1153         * tui/tui-regs.c (tui_register_format): Return a
1154         unique_xmalloc_ptr.
1155         (tui_get_register): Update.
1156         (~tui_data_item_window): Remove.
1157         (tui_data_window::display_registers_from, tui_display_register):
1158         Update.
1159         * tui/tui-io.h (tui_expand_tabs): Update.
1160         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1161         Remove "col" parameter.
1162
1163 2019-08-20  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1166         field.
1167         * tui/tui-regs.c (~tui_data_item_window): Update.
1168
1169 2019-08-20  Tom Tromey  <tom@tromey.com>
1170
1171         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1172         earlier.
1173
1174 2019-08-20  Tom Tromey  <tom@tromey.com>
1175
1176         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1177
1178 2019-08-20  Tom Tromey  <tom@tromey.com>
1179
1180         * tui/tui-source.h (struct tui_source_window): Update.
1181         * tui/tui-regs.c (tui_show_registers): Update.
1182         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1183         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1184         (NO_REGS_STRING): Remove defines.
1185
1186 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1187
1188         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1189         unnecessary thread walk if remote doesn't support the packet.
1190
1191 2019-08-19  Tom Tromey  <tromey@adacore.com>
1192
1193         * python/py-value.c (value_has_field): Fix indentation.
1194
1195 2019-08-19  Tom Tromey  <tromey@adacore.com>
1196
1197         * printcmd.c (do_one_display, info_display_command): Update.
1198         * block.h (contained_in): Return bool.  Add allow_nested
1199         parameter.
1200         * block.c (contained_in): Return bool.  Add allow_nested
1201         parameter.
1202
1203 2019-08-19  Tom Tromey  <tom@tromey.com>
1204
1205         * configure: Rebuild.
1206         * configure.ac: Disallow the combination of -static-libstdc++ and
1207         source highlight.
1208         * source-cache.c (get_language_name): Handle rust.
1209         (source_cache::get_source_lines): Ignore highlighting exceptions.
1210
1211 2019-08-16  Tom Tromey  <tom@tromey.com>
1212
1213         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1214         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1215         (struct tui_source_window_base) <make_visible, refresh_window,
1216         resize>: Remove methods.
1217         <execution_info>: Remove field.
1218         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1219         (tui_show_source_line, tui_source_window_base)
1220         (~tui_source_window_base): Update.
1221         (tui_source_window_base::resize)
1222         (tui_source_window_base::make_visible)
1223         (tui_source_window_base::refresh_window): Remove.
1224         (tui_source_window_base::update_exec_info): Update.
1225         * tui/tui-source.c (tui_source_window::set_contents): Update.
1226         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1227
1228 2019-08-16  Tom Tromey  <tom@tromey.com>
1229
1230         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1231         deprecated_query_hook.
1232
1233 2019-08-16  Tom Tromey  <tom@tromey.com>
1234
1235         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1236         (tui_update_source_windows_with_line): Update.
1237         * tui/tui-source.h (struct tui_source_window)
1238         <show_symtab_source>: Declare.
1239         (tui_show_symtab_source): Don't declare.
1240         * tui/tui-source.c (tui_show_symtab_source): Rename from
1241         tui_show_symtab_source.
1242
1243 2019-08-16  Tom Tromey  <tom@tromey.com>
1244
1245         * tui/tui-winsource.h (struct tui_source_window_base)
1246         <set_contents>: Declare.
1247         * tui/tui-winsource.c
1248         (tui_source_window_base::update_source_window_as_is): Update.
1249         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1250         Declare.
1251         (tui_set_source_content): Don't declare.
1252         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1253         tui_set_source_content.
1254         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1255         Declare.
1256         (tui_set_disassem_content): Don't declare.
1257         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1258         tui_set_disassem_content.
1259
1260 2019-08-16  Tom Tromey  <tom@tromey.com>
1261
1262         * tui/tui-winsource.h (struct tui_source_window_base)
1263         <update_breakpoint_info>: Declare.
1264         (tui_update_breakpoint_info): Don't declare.
1265         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1266         (tui_update_all_breakpoint_info): Update.
1267         (tui_source_window_base::update_breakpoint_info): Rename from
1268         tui_update_breakpoint_info.
1269         (tui_source_window_base::update_exec_info): Update.
1270
1271 2019-08-16  Tom Tromey  <tom@tromey.com>
1272
1273         * tui/tui-winsource.h (struct tui_source_window_base)
1274         <update_source_window>: Declare.
1275         (tui_update_source_window): Don't declare.
1276         * tui/tui-winsource.c
1277         (tui_source_window_base::update_source_window): Rename from
1278         tui_update_source_window.
1279         (tui_source_window_base::rerender): Update.
1280         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1281         * tui/tui-disasm.c (tui_show_disassem)
1282         (tui_show_disassem_and_update_source)
1283         (tui_disasm_window::maybe_update): Update.
1284
1285 2019-08-16  Tom Tromey  <tom@tromey.com>
1286
1287         * tui/tui-winsource.h (struct tui_source_window_base)
1288         <update_source_window_as_is>: Declare.
1289         (tui_update_source_window_as_is): Don't declare.
1290         * tui/tui-winsource.c (tui_update_source_window): Update
1291         (tui_source_window_base::update_source_window_as_is): Rename from
1292         tui_update_source_window_as_is.
1293         (tui_source_window_base::refill): Update.
1294         * tui/tui-source.c (tui_show_symtab_source): Update.
1295         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1296         Update.
1297
1298 2019-08-16  Tom Tromey  <tom@tromey.com>
1299
1300         * tui/tui-winsource.h (tui_update_source_window)
1301         (tui_update_source_window_as_is): Remove "noerror" parameter.
1302         * tui/tui-winsource.c (tui_update_source_window)
1303         (tui_update_source_window_as_is): Remove "noerror" parameter.
1304         (tui_update_source_windows_with_addr)
1305         (tui_update_source_windows_with_line)
1306         (tui_source_window_base::rerender)
1307         (tui_source_window_base::refill): Update.
1308         * tui/tui-source.h (tui_set_source_content)
1309         (tui_show_symtab_source): Remove "noerror" parameter.
1310         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1311         parameter.
1312         (tui_show_symtab_source): Likewise.
1313         (tui_source_window::maybe_update): Update.
1314         * tui/tui-disasm.c (tui_show_disassem)
1315         (tui_show_disassem_and_update_source)
1316         (tui_disasm_window::do_scroll_vertical)
1317         (tui_disasm_window::maybe_update): Update.
1318
1319 2019-08-16  Tom Tromey  <tom@tromey.com>
1320
1321         * tui/tui.c (tui_is_window_visible): Update.
1322         * tui/tui-wingeneral.c (tui_make_window)
1323         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1324         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1325         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1326         (tui_set_win_height_command, parse_scrolling_args): Update.
1327         * tui/tui-source.c (tui_source_window::style_changed): Update.
1328         * tui/tui-regs.c (tui_show_registers)
1329         (tui_data_window::first_data_item_displayed)
1330         (tui_data_window::delete_data_content_windows)
1331         (tui_check_register_values, tui_reg_command): Update.
1332         * tui/tui-disasm.c (tui_show_disassem): Update.
1333         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1334         method.
1335         <is_visible>: Remove field.
1336         * tui/tui-data.c (tui_next_win, tui_prev_win)
1337         (tui_delete_invisible_windows): Update.
1338
1339 2019-08-16  Tom Tromey  <tom@tromey.com>
1340
1341         * tui/tui-winsource.h (struct tui_source_window_base)
1342         <m_has_locator>: Remove.
1343         * tui/tui-layout.c (show_source_disasm_command, show_data)
1344         (show_source_or_disasm_and_command): Update.
1345
1346 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1347
1348         * NEWS (Other MI changes): New subsection.
1349         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1350         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1351         * arch-utils.c (default_get_pc_address_flags): New function.
1352         * arch-utils.h (default_get_pc_address_flags): New declaration.
1353         * gdbarch.sh: Add get_pc_address_flags.
1354         * gdbarch.c: Regenerate.
1355         * gdbarch.h: Likewise.
1356         * stack.c (print_pc): New function.
1357         (print_frame_info) (print_frame): Call print_pc.
1358
1359 2019-08-16  Tom de Vries  <tdevries@suse.de>
1360
1361         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1362         print_objfile_section_info.
1363
1364 2019-08-15  Tom Tromey  <tom@tromey.com>
1365
1366         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1367         calling update_cmdwin_start_line.
1368         * tui/tui-winsource.h (struct tui_source_window_base)
1369         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1370         <rerender>: Declare.
1371         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1372         Call rerender.
1373         (tui_source_window_base::set_new_height): Remove.
1374         (tui_source_window_base::rerender): Rename from
1375         do_make_visible_with_new_height.
1376         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1377         resize method.
1378         (tui_win_info::make_invisible_and_set_new_height)
1379         (tui_win_info::make_visible_with_new_height): Remove.
1380         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1381         Declare.
1382         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1383         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1384         do_make_visible_with_new_height>: Don't declare.
1385         <rerender>: Declare.
1386         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1387         set_new_height.
1388         (tui_data_window::do_make_visible_with_new_height): Remove.
1389         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1390         call tui_show_locator_content.
1391         (tui_gen_win_info::resize): Call rerender.
1392         (show_source_or_disasm_and_command): Don't call
1393         tui_show_locator_content.
1394         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1395         method.
1396         (struct tui_win_info) <rerender>: Declare.
1397         <set_new_height, make_invisible_and_set_new_height,
1398         make_visible_with_new_height>: Don't declare.
1399         * tui/tui-data.c (tui_win_list::rerender): New method.
1400         * tui/tui-command.h (struct tui_cmd_window)
1401         <do_make_visible_with_new_height>: Don't declare.
1402         * tui/tui-command.c
1403         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1404
1405 2019-08-15  Tom Tromey  <tromey@adacore.com>
1406
1407         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1408         * ada-lang.c (ada_enum_name): Likewise.
1409
1410 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1411
1412         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1413         leading underscore.
1414         (GdbOutputErrorFile): Likewise.
1415         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1416         accordingly.
1417         (execute_unwinders): Rename to have a leading underscore.
1418         (auto_load_packages): Likewise.
1419         (global scope): Adjust call to auto_load_packages accordingly.
1420         (GdbSetPythonDirectory): Likewise.
1421         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1422         instead of execute_unwinders.
1423
1424 2019-08-15  Tom Tromey  <tom@tromey.com>
1425
1426         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1427         (show_data): Don't change window visibility.
1428         (tui_gen_win_info::resize): Remove special case for command
1429         window.  Use wresize, when available.
1430         (show_source_or_disasm_and_command): Don't change window
1431         visibility.
1432         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1433         <make_visible>: New method.
1434         * tui/tui-command.c (tui_cmd_window::resize): New method.
1435
1436 2019-08-15  Tom Tromey  <tom@tromey.com>
1437
1438         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1439         (struct tui_source_windows): New.
1440         * tui/tui-winsource.c (tui_display_main): Update.
1441         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1442         (new_height_ok, parse_scrolling_args): Update.
1443         * tui/tui-layout.c (show_layout, show_data): Update.
1444         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1445         (tui_add_to_source_windows): Don't declare.
1446         * tui/tui-data.c (source_windows, tui_source_windows)
1447         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1448
1449 2019-08-15  Tom Tromey  <tom@tromey.com>
1450
1451         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1452         Rename from reset.
1453         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1454         * tui/tui-layout.c (show_source_disasm_command, show_data):
1455         Update.
1456         (tui_gen_win_info::resize): Rename.
1457         (show_source_or_disasm_and_command): Update.
1458         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1459         reset.
1460
1461 2019-08-15  Tom Tromey  <tom@tromey.com>
1462
1463         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1464         * tui/tui-interp.c (tui_interp::init): Don't call
1465         tui_initialize_static_data.
1466         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1467
1468 2019-08-15  Tom Tromey  <tom@tromey.com>
1469
1470         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1471         examine tui_win_list.
1472
1473 2019-08-15  Tom Tromey  <tom@tromey.com>
1474
1475         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1476         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1477         tui_clear_source_content.
1478         (tui_clear_source_content): Remove.
1479         (tui_source_window_base::do_erase_source_content): Hoist call to
1480         content.clear().
1481         * tui/tui-stack.c (tui_show_frame_info): Don't call
1482         tui_clear_source_content.
1483
1484 2019-08-15  Tom Tromey  <tom@tromey.com>
1485
1486         * tui/tui-winsource.h (struct tui_source_window_base)
1487         <do_erase_source_content>: New method.
1488         <erase_source_content>: New method.
1489         (tui_erase_source_content): Don't declare.
1490         * tui/tui-winsource.c (tui_clear_source_content): Update.
1491         (tui_source_window_base::do_erase_source_content): Rename from
1492         tui_erase_source_content.
1493         (tui_source_window_base::show_source_content): Update.
1494         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1495         * tui/tui-source.h (struct tui_source_window)
1496         <erase_source_content>: New method.
1497         * tui/tui-disasm.h (struct tui_disasm_window)
1498         <erase_source_content>: New method.
1499
1500 2019-08-15  Tom Tromey  <tom@tromey.com>
1501
1502         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1503         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1504         constructor.
1505         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1506         * tui/tui-source.c (tui_set_source_content): Update.
1507         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1508
1509 2019-08-15  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1512         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1513         tui-source.c.
1514         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1515         Declare.
1516         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1517         method.
1518         (tui_source_window::maybe_update): Update.
1519
1520 2019-08-15  Tom Tromey  <tom@tromey.com>
1521
1522         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1523         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1524         tui-disasm.c.
1525         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1526         Declare.
1527         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1528         method.
1529         (tui_disasm_window::maybe_update): Update.
1530
1531 2019-08-15  Tom Tromey  <tom@tromey.com>
1532
1533         * tui/tui-winsource.h (struct tui_source_window_base)
1534         <maybe_update>: Declare.
1535         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1536         method.
1537         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1538         Declare.
1539         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1540         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1541         Declare.
1542         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1543
1544 2019-08-15  Tom Tromey  <tom@tromey.com>
1545
1546         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1547
1548 2019-08-15  Tom Tromey  <tom@tromey.com>
1549
1550         * tui/tui-wingeneral.c: Include tui-stack.h.
1551         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1552         (struct tui_locator_window): Move from tui-data.h.
1553         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1554         (tui_initialize_static_data): Move from tui-data.c.
1555         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1556         (struct tui_locator_window): Move to tui-stack.c.
1557         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1558         (tui_initialize_static_data): Move to tui-stack.c.
1559
1560 2019-08-15  Tom Tromey  <tom@tromey.com>
1561
1562         * tui/tui-layout.c (show_source_disasm_command)
1563         (show_source_or_disasm_and_command): Use make_visible method, not
1564         tui_make_window.
1565         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1566         Remove.
1567
1568 2019-08-15  Tom Tromey  <tom@tromey.com>
1569
1570         * tui/tui-wingeneral.h (tui_make_window): Update.
1571         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1572         parameter.
1573         (tui_gen_win_info::make_visible): Update.
1574         * tui/tui-regs.c (tui_data_window::display_registers_from):
1575         Update.
1576         * tui/tui-layout.c (show_source_disasm_command)
1577         (show_source_or_disasm_and_command): Update.
1578         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1579         (enum tui_box): Remove.
1580         (struct tui_win_info) <can_box>: New method.
1581         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1582         method.
1583
1584 2019-08-15  Tom de Vries  <tdevries@suse.de>
1585
1586         * linux-nat-trad.c: Include gdbarch.h.
1587
1588 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1589
1590         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1591         register sizes.
1592
1593 2019-08-14  Tom Tromey  <tromey@adacore.com>
1594
1595         * darwin-nat.c: Include gdbarch.h.
1596         * darwin-nat-info.c: Include gdbarch.h.
1597
1598 2019-08-13  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1601         Remove.
1602         * tui/tui-data.c (tui_initialize_static_data): Update.
1603
1604 2019-08-13  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui-winsource.h (struct tui_exec_info_window)
1607         <~tui_exec_info_window, maybe_allocate_content, get_content,
1608         m_content>: Remove.
1609         (struct tui_source_window_base) <set_exec_info_content,
1610         show_exec_info_content>: Don't declare.
1611         * tui/tui-winsource.c
1612         (tui_exec_info_window::maybe_allocate_content): Remove.
1613         (tui_source_window_base::update_exec_info): Rename from
1614         set_exec_info_content.
1615         (tui_source_window_base::show_exec_info_content)
1616         (tui_source_window_base::update_exec_info): Remove.
1617
1618 2019-08-13  Tom Tromey  <tom@tromey.com>
1619
1620         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1621         declare.
1622         * tui/tui-winsource.c (tui_update_source_window_as_is)
1623         (tui_update_source_windows_with_addr, tui_erase_source_content):
1624         Update.
1625         (tui_clear_exec_info_content): Remove.
1626
1627 2019-08-13  Tom Tromey  <tom@tromey.com>
1628
1629         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1630         declare.
1631         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1632         call tui_erase_exec_info_content.
1633         (tui_clear_exec_info_content): Rename from
1634         tui_erase_exec_info_content.
1635         (tui_clear_exec_info_content): Delete.
1636
1637 2019-08-13  Tom Tromey  <tom@tromey.com>
1638
1639         * tui/tui-winsource.h (struct tui_source_window_base)
1640         <show_exec_info_content>: Declare.
1641         (tui_show_exec_info_content): Don't declare.
1642         * tui/tui-winsource.c
1643         (tui_source_window_base::show_exec_info_content): Rename from
1644         tui_show_exec_info_content.
1645         (tui_source_window_base::update_exec_info): Update.
1646
1647 2019-08-13  Tom Tromey  <tom@tromey.com>
1648
1649         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1650         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1651         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1652         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1653         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1654         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1655         ... here.
1656
1657 2019-08-13  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-winsource.h (struct tui_source_window_base)
1660         <update_exec_info>: Declare.
1661         (tui_update_exec_info): Don't declare.
1662         * tui/tui-winsource.c (tui_update_source_window_as_is)
1663         (tui_source_window_base::refresh_all)
1664         (tui_update_all_breakpoint_info): Update.
1665         (tui_source_window_base::update_exec_info): Rename from
1666         tui_update_exec_info.
1667         * tui/tui-stack.c (tui_show_frame_info): Update.
1668
1669 2019-08-13  Tom Tromey  <tom@tromey.com>
1670
1671         * tui/tui-winsource.h (struct tui_source_window_base)
1672         <set_exec_info_content>: Declare.
1673         (tui_set_exec_info_content): Don't declare.
1674         * tui/tui-winsource.c
1675         (tui_source_window_base::set_exec_info_content): Rename from
1676         tui_set_exec_info_content.
1677         (tui_update_exec_info): Update.
1678
1679 2019-08-13  Tom Tromey  <tom@tromey.com>
1680
1681         * tui/tui-winsource.h (struct tui_source_window_base)
1682         <show_source_content>: Declare.
1683         (tui_show_source_content): Don't declare.
1684         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1685         (tui_source_window_base::show_source_content): Rename from
1686         tui_show_source_content.
1687         (tui_source_window_base::refresh_all): Update.
1688         * tui/tui-layout.c (show_source_disasm_command)
1689         (show_source_or_disasm_and_command): Update.
1690
1691 2019-08-13  Tom Tromey  <tom@tromey.com>
1692
1693         * tui/tui-winsource.c (tui_erase_source_content)
1694         (tui_show_source_content, tui_source_window_base::refresh_all):
1695         Update.
1696         * tui/tui-wingeneral.h
1697         (tui_check_and_display_highlight_if_needed): Don't declare.
1698         * tui/tui-wingeneral.c
1699         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1700         check_and_display_highlight_if_needed.
1701         * tui/tui-win.c (tui_rehighlight_all)
1702         (tui_win_info::make_visible_with_new_height): Update.
1703         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1704         (tui_data_window::erase_data_content)
1705         (tui_data_window::display_all_data): Update.
1706         * tui/tui-data.h (struct tui_win_info)
1707         <check_and_display_highlight_if_needed>: Declare.
1708
1709 2019-08-13  Tom Tromey  <tom@tromey.com>
1710
1711         * tui/tui-win.c (tui_resize_all): Call
1712         tui_delete_invisible_windows.
1713         * tui/tui-layout.c (show_layout): Call
1714         tui_delete_invisible_windows.
1715         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1716         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1717
1718 2019-08-13  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1721         tui_add_win_to_layout.
1722
1723 2019-08-13  Tom Tromey  <tom@tromey.com>
1724
1725         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1726         * tui/tui-layout.c (tui_default_win_height): Now static.
1727
1728 2019-08-13  Tom Tromey  <tom@tromey.com>
1729
1730         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1731         single switch.
1732         (show_source_disasm_command, show_source_or_disasm_and_command):
1733         Don't check current layout.
1734
1735 2019-08-13  Tom Tromey  <tom@tromey.com>
1736
1737         * tui/tui-wingeneral.c (make_all_visible): Remove.
1738         (tui_make_all_invisible): Simplify.
1739         * tui/tui-layout.c (tui_make_all_invisible): Move from
1740         tui-wingeneral.c; simplify.
1741         (show_layout): Hoist call to tui_make_all_invisible.
1742         (show_data): Don't call tui_make_all_invisible.
1743
1744 2019-08-13  Tom Tromey  <tom@tromey.com>
1745
1746         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1747         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1748
1749 2019-08-13  Tom Tromey  <tom@tromey.com>
1750
1751         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1752         tui-data.c.
1753         (show_source_disasm_command, show_data)
1754         (show_source_or_disasm_and_command): Don't use
1755         tui_set_current_layout_to.
1756         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1757         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1758         tui-layout.c.
1759         (tui_set_current_layout_to): Remove.
1760
1761 2019-08-13  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-layout.c (tui_set_layout): Update.
1764         * tui/tui-data.h (struct tui_layout_def): Remove.
1765         (tui_layout_def): Don't declare.
1766         * tui/tui-data.c (layout_def): Remove.
1767         (tui_layout_def): Remove.
1768
1769 2019-08-13  Tom Tromey  <tom@tromey.com>
1770
1771         * tui/tui-winsource.h (struct tui_source_window_base)
1772         <clear_detail>: No longer "override".
1773         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1774         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1775         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1776         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1777         Remove.
1778         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1779
1780 2019-08-13  Tom Tromey  <tromey@adacore.com>
1781
1782         * tracepoint.c: Don't include readline.h or history.h.
1783
1784 2019-08-12  Tom Tromey  <tom@tromey.com>
1785
1786         * configure: Rebuild.
1787         * configure.ac: Check for readline 7.
1788         * NEWS: Mention readline 7 requirement.
1789         * README: Update.
1790
1791 2019-08-12  Tom Tromey  <tom@tromey.com>
1792
1793         * mingw-hdep.c (gdb_select): Remove readline hack.
1794
1795 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1796
1797         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1798         when the function fails.
1799
1800 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1801
1802         * s390-tdep.c (s390_type_align): New function.
1803         (s390_gdbarch_init): Set it as type_align gdbarch method.
1804
1805 2019-08-09  Tom de Vries  <tdevries@suse.de>
1806
1807         PR gdb/24591
1808         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1809         pc_low with relocation offset.
1810
1811 2019-08-07  Tom Tromey  <tromey@adacore.com>
1812
1813         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1814         (print_frame_args): Update.
1815         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1816         Update.
1817         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1818         * frame.h (struct frame_arg): Add initializers.
1819         <error>: Now a unique_xmalloc_ptr.
1820
1821 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1822
1823         * NEWS: Expand the Pointer Authentication entry.
1824         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1825         (aarch64_frame_unmask_lr): ... to this.
1826         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1827         Call aarch64_frame_unmask_lr.
1828         * frame.c (struct frame_info): Add "masked" variable.
1829         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1830         (fprint_frame): Check for masked pc.
1831         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1832         declarations.
1833         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1834         * stack.c (print_frame): Check for masked pc.
1835
1836 2019-08-06  Tom Tromey  <tom@tromey.com>
1837
1838         * stabsread.c (patch_block_stabs, read_one_struct_field)
1839         (read_enum_type): Use obstack_strndup.
1840         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1841         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1842         * dwarf2read.c (guess_full_die_structure_name)
1843         (anonymous_struct_prefix): Use obstack_strndup.
1844         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1845         * c-exp.y (yylex): Use obstack_strndup.
1846         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1847         (write_var_or_type): Use obstack_strndup.
1848
1849 2019-08-06  Tom Tromey  <tom@tromey.com>
1850
1851         * symfile.c (reread_symbols): Use obstack_strdup.
1852         * stabsread.c (read_type): Use obstack_strdup.
1853         * gdb_obstack.h (obstack_strdup): New overload.
1854         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1855         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1856         (dwarf2_canonicalize_name): Use obstack_strdup.
1857         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1858         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1859         Use obstack_strdup.
1860
1861 2019-08-06  Tom Tromey  <tom@tromey.com>
1862
1863         * gdb_obstack.h (obstack_strdup): Define.
1864         * gdb_obstack.c (obstack_strdup): Don't define.
1865
1866 2019-08-06  Tom Tromey  <tom@tromey.com>
1867
1868         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1869         obstack_strdup.
1870         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1871         obstack_strdup.
1872         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1873         * stabsread.c (common_block_start): Use obstack_strdup.
1874         * objfiles.c (set_objfile_main_name, objfile): Use
1875         obstack_strdup.
1876         * namespace.c (add_using_directive): Use obstack_strdup.
1877         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1878         * jit.c (finalize_symtab): Use obstack_strdup.
1879         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1880         (guess_partial_die_structure_name, partial_die_info::fixup)
1881         (dwarf2_name): Use obstack_strdup.
1882         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1883         obstack_strdup.
1884         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1885         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1886         obstack_strdup.
1887         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1888
1889 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1890
1891         * unittests/help-doc-selftests.c: New file.
1892         * Makefile.in: Add the new file.
1893
1894 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1895
1896         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1897         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1898         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1899         the trailing '.' is not output, and the first character is uppercased.
1900         (print_help_for_command): Update call to print_doc_line.
1901         (print_doc_of_command): Likewise.
1902         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1903         * cli/cli-option.c (append_indented_doc): Do not append newline.
1904         (build_help_option): Append newline after first appended_indented_doc
1905         only if a second call is done.
1906         (build_help): Append 2 new lines before each option, except the first
1907         one.
1908         * compile/compile.c (_initialize_compile): Add new lines after
1909         %OPTIONS%, when not at the end of the help.
1910         Change help doc or code
1911         producing the help doc to respect the invariants.
1912         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1913         Also removed the new line after 'Options:', as all other commands
1914         do not put an empty line between 'Options:' and the first option.
1915         * printcmd.c (_initialize_printcmd): Likewise.
1916         * stack.c (_initialize_stack): Likewise.
1917         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1918         incorrectly telling COMMAND is optional.
1919         * ada-lang.c (_initialize_ada_language): Change help doc or code
1920         producing the help doc to respect the invariants.
1921         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1922         * breakpoint.c (_initialize_breakpoint): Likewise.
1923         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1924         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1925         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1926         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1927         _initialize_cli_style): Likewise.
1928         * corelow.c (core_target_info): Likewise.
1929         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1930         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1931         * filesystem.c (_initialize_filesystem): Likewise.
1932         * frame.c (_initialize_frame): Likewise.
1933         * gnu-nat.c (add_task_commands): Likewise.
1934         * infcall.c (_initialize_infcall): Likewise.
1935         * infcmd.c (_initialize_infcmd): Likewise.
1936         * interps.c (_initialize_interpreter): Likewise.
1937         * language.c (_initialize_language): Likewise.
1938         * linux-fork.c (_initialize_linux_fork): Likewise.
1939         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1940         * maint.c (_initialize_maint_cmds): Likewise.
1941         * memattr.c (_initialize_mem): Likewise.
1942         * printcmd.c (_initialize_printcmd): Likewise.
1943         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1944         _RegEx): Likewise.
1945         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1946         * record-btrace.c (_initialize_record_btrace): Likewise.
1947         * record-full.c (_initialize_record_full): Likewise.
1948         * record.c (_initialize_record): Likewise.
1949         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1950         * regcache.c (_initialize_regcache): Likewise.
1951         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1952         _initialize_remote): Likewise.
1953         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1954         * serial.c (_initialize_serial): Likewise.
1955         * skip.c (_initialize_step_skip): Likewise.
1956         * source.c (_initialize_source): Likewise.
1957         * stack.c (_initialize_stack): Likewise.
1958         * symfile.c (_initialize_symfile): Likewise.
1959         * symtab.c (_initialize_symtab): Likewise.
1960         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1961         * top.c (init_main): Likewise.
1962         * tracefile-tfile.c (tfile_target_info): Likewise.
1963         * tracepoint.c (_initialize_tracepoint): Likewise.
1964         * tui/tui-win.c (_initialize_tui_win): Likewise.
1965         * utils.c (add_internal_problem_command): Likewise.
1966         * valprint.c (value_print_option_defs): Likewise.
1967
1968 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1969
1970         PR build/24886
1971         * configure.ac: Drop enable-libmcheck support.
1972         * configure, config.in: Rebuild.
1973         * libmcheck.m4: Remove.
1974         * acinclude.m4: Don't include it.
1975         * Makefile.in: Don't distribute it.
1976         * top.c (print_gdb_configuration): Don't mention it.
1977
1978 2019-08-06  Tom Tromey  <tom@tromey.com>
1979
1980         * utils.c (set_output_style): Sometimes pass stream to
1981         emit_style_escape.
1982         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1983         * record-btrace.c (btrace_insn_history): Update.
1984         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1985         method.
1986         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1987         Update initializers.
1988         <m_uiout>: New field.
1989         <m_di>: Move lower.
1990         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1991         Remove "uiout" parameter.
1992         (dump_insns): Update.
1993         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1994         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1995
1996 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1997
1998         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1999         (error_in_psymtab_expansion): Likewise.
2000         (lookup_symbol_via_quick_fns): Likewise.
2001         (basic_lookup_transparent_type_quick): Likewise.
2002         (basic_lookup_transparent_type_1): Likewise.
2003
2004 2019-08-06  Tom Tromey  <tromey@adacore.com>
2005
2006         * source.c (last_source_error): Now bool.
2007         (print_source_lines_base): Make "noprint" bool.  Only open
2008         source file when last_source_visited changes.
2009
2010 2019-08-06  Tom Tromey  <tromey@adacore.com>
2011
2012         * annotate.c (annotate_source_line): Use g_source_cache.
2013         * source-cache.c (source_cache::get_plain_source_lines): Change
2014         parameters.  Populate m_offset_cache.
2015         (source_cache::ensure): New method.
2016         (source_cache::get_line_charpos): New method.
2017         (extract_lines): Move lower.  Change parameters.
2018         (source_cache::get_source_lines): Move lower.
2019         * source-cache.h (class source_cache): Update comment.
2020         <get_line_charpos>: New method.
2021         <get_source_lines>: Update comment.
2022         <clear>: Clear m_offset_cache.
2023         <get_plain_source_lines>: Change parameters.
2024         <ensure>: New method
2025         <m_offset_cache>: New member.
2026         * source.c (forget_cached_source_info_for_objfile): Update.
2027         (info_source_command): Use g_source_cache.
2028         (find_source_lines, open_source_file_with_line_charpos): Remove.
2029         (print_source_lines_base, search_command_helper): Use g_source_cache.
2030         * source.h (open_source_file_with_line_charpos): Don't declare.
2031         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2032         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2033         Use g_source_cache.
2034
2035 2019-08-06  Tom Tromey  <tromey@adacore.com>
2036
2037         * source-cache.c (source_cache::get_plain_source_lines):
2038         Remove "first_line" and "last_line" parameters.
2039         (source_cache::get_source_lines): Cache plain text.
2040         * source-cache.h (class source_cache)
2041         <get_plain_source_lines>: Update.
2042
2043 2019-08-06  Tom Tromey  <tromey@adacore.com>
2044
2045         * source-cache.c (extract_lines): No longer a method.
2046         Changed type of parameter.  Include final newline.
2047         (selftests::extract_lines_test): New function.
2048         (_initialize_source_cache): Likewise.
2049         * source-cache.h (class source_cache)
2050         <extract_lines>: Don't declare.
2051
2052 2019-08-06  Tom Tromey  <tromey@adacore.com>
2053
2054         * breakpoint.c (init_breakpoint_sal): Update.
2055         (breakpoint): Update.
2056         * breakpoint.h (struct breakpoint) <filter>: Now a
2057         unique_xmalloc_ptr.
2058
2059 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2060
2061         * NEWS: Mention dictionary access on blocks.
2062         * python/py-block.c (blpy_getitem): New function.
2063         (block_object_as_mapping): New struct.
2064         (block_object_type): Use new struct for tp_as_mapping field.
2065
2066 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2067
2068         * objfiles.h (objfile): Add a comment describing partial symbols.
2069
2070 2019-08-05  Tom Tromey  <tromey@adacore.com>
2071
2072         * compile/compile.c (_initialize_compile): Use _(), not N_().
2073         * thread.c (_initialize_thread): Use _(), not N_().
2074         * stack.c (_initialize_stack): Use _(), not N_().
2075         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2076
2077 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2078
2079         * dwarf2read.c (struct dw2_symtab_iterator):
2080         <want_specific_block>: Remove.
2081         <block_index>: Change type to gdb::optional.
2082         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2083         change type of BLOCK_INDEX parameter to gdb::optional.
2084         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2085         (dw2_lookup_symbol): Don't pass argument for
2086         WANT_SPECIFIC_BLOCK.
2087         (dw2_expand_symtabs_for_function): Don't pass argument for
2088         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2089         (class dw2_debug_names_iterator)
2090         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2091         parameter, change BLOCK_INDEX type to gdb::optional.
2092         <m_want_specific_block>: Remove.
2093         <m_block_index>: Change type to gdb::optional.
2094         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2095         gdb::optional.  Re-write in function of gdb::optional.
2096         (dw2_debug_names_lookup_symbol): Don't pass argument for
2097         WANT_SPECIFIC_BLOCK.
2098         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2099         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2100         BLOCK_INDEX.
2101
2102 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2103
2104         * NEWS: Mention changes to "info sources" command.
2105
2106 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2107
2108         * symtab.c (filename_partial_match_opts): New struct type.
2109         (struct output_source_filename_data): New members
2110         regexp, c_regexp, partial_match.
2111         (output_source_filename): Use new members to decide to print file.
2112         (info_sources_option_defs): New variable.
2113         (make_info_sources_options_def_group, print_info_sources_header,
2114         info_sources_command_completer):
2115         New functions.
2116         (info_sources_command): Read new optional arguments.
2117         (_initialize_symtab): Update info sources help.
2118
2119 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2120
2121         * ada-lang.c (exception_support_info_v0): Renamed from...
2122         (default_exception_support_info): ... this.  Create new
2123         definition for v1.
2124         (ada_has_this_exception_support): Look up catch_handlers_sym.
2125         (ada_exception_support_info_sniffer): Try v0 after default.
2126
2127 2019-08-01  Tom Tromey  <tromey@adacore.com>
2128
2129         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2130         gdbarch.h.
2131
2132 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2133
2134         * s12z-tdep.c: Fix include path for s12z-opc.h.
2135
2136 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2137
2138         * NEWS: Require GNU make 3.82.
2139
2140 2019-07-16  Tom Tromey  <tom@tromey.com>
2141
2142         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2143         declare.
2144
2145 2019-07-30  Tom Tromey  <tromey@adacore.com>
2146
2147         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2148
2149 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2150
2151         * printcmd.c (print_address_symbolic): Print negative offsets.
2152         (build_address_symbolic): Force signed arithmetic when computing
2153         offset.
2154
2155 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2156
2157         PR/24474: Add a function to lookup static variables.
2158         * NEWS: Mention this new function.
2159         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2160         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2161         * python/python.c (python_GdbMethods): Add new function.
2162
2163 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2164
2165         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2166         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2167         (objfpy_lookup_static_symbol): New function.
2168         (objfile_object_methods): Add new functions.
2169
2170 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2171
2172         * NEWS: Mention 'set|show print frame-info'.  Mention new
2173         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2174         backtrace argument.  Mention that python frame filtering code
2175         is now consistent with what 'backtrace' command prints.
2176
2177 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2178
2179         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2180         comments.
2181         (print_frame_info_auto, print_frame_info_source_line,
2182         print_frame_info_location, print_frame_info_source_and_location,
2183         print_frame_info_location_and_address, print_frame_info_short_location):
2184         New declarations.
2185         (struct frame_print_options): New member print_frame_info.
2186         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2187         * stack.h (get_user_print_what_frame_info): New declaration.
2188         (frame_show_address): New declaration.
2189         * stack.c (print_frame_arguments_choices): New value 'presence'.
2190         (print_frame_info_auto, print_frame_info_source_line,
2191         print_frame_info_location, print_frame_info_source_and_location,
2192         print_frame_info_location_and_address, print_frame_info_short_location,
2193         print_frame_info_choices, print_frame_info_print_what): New definitions.
2194         (print_frame_args): Only print dots for args if print frame-arguments
2195         is 'presence'.
2196         (frame_print_option_defs): New element for "frame-info".
2197         (get_user_print_what_frame_info): New function.
2198         (frame_show_address): Make non static.  Move comment to stack.h.
2199         (print_frame_info_to_print_what): New function.
2200         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2201         to decide what to print.
2202         (backtrace_command_1): Handle the new print_frame_arguments_presence
2203         value.
2204         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2205         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2206         (py_print_frame): In non-mi mode, use LOCATION as default for
2207         print_what, similarly to frame information printed directly by
2208         backtrace command. Handle frame-info user option in non MI mode.
2209
2210 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2211
2212         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2213         Add case for debugging 32-bit target on 64-bit host.  Revise
2214         comment.
2215
2216 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2217
2218         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2219         instead of find_function_entry_range_from_pc.
2220
2221 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2222
2223         * stack.c (find_frame_funname): Remove code which preferred
2224         minsym over symtab sym in "certain pathological cases".
2225
2226         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2227         parameter.  Change type of "do_demangle" to bool.
2228         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2229         Pass suitable "prefer_sym_over_minsym" flag to
2230         build_address_symbolic().  Don't output "+" for negative offsets.
2231         * printcmd.c (print_address_symbolic): Update invocation of
2232         build_address_symbolic to include a "prefer_sym_over_minsym"
2233         flag.
2234         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2235         Restrict cases in which use of minimal symbol is preferred to that
2236         of a found symbol.  Update comments.
2237
2238         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2239         for entry pc when entry pc is out of range for that FDE.
2240
2241 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2242
2243         PR gdb/24839:
2244         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2245         type.
2246
2247 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2248
2249         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2250         this function's Python signature.
2251
2252
2253 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2254
2255         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2256         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2257         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2258         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2259         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2260
2261
2262 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2263
2264         * h8300-tdep.c (h8300_register_name_common): New.
2265         h8300_register_name): Use h8300_register_name_common.
2266         (h8300s_register_name): Likewise.
2267         (h8300sx_register_name): Likewise.
2268         (h8300h_register_nam): New.
2269         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2270
2271
2272 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2273
2274         * arm-tdep.c (arm_skip_cmse_entry): New function.
2275         (arm_is_sgstubs_section): New function.
2276         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2277
2278 2019-07-22  Tom Tromey  <tom@tromey.com>
2279
2280         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2281         Don't self-assign.
2282
2283 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2284
2285         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2286         type_print.
2287
2288 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2289
2290         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2291         so that GDB doesn't match any msymbols when searching in the
2292         TYPES_DOMAIN.
2293         (print_symbol_info): Print using typedef_print or type_print based
2294         on the type of the symbol.  Add updated FIXME comment moved from...
2295         (_initialize_symtab): ... move and update FIXME comment to above.
2296
2297 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2298
2299         * NEWS: Mention adding -q option to "info types".
2300         * symtab.c (struct info_types_options): New struct.
2301         (info_types_options_defs): New variable.
2302         (make_info_types_options_def_group): New function.
2303         (info_types_command): Use gdb::option framework to parse options.
2304         (info_types_command_completer): New function.
2305         (_initialize_symtab): Extend the help text on "info types" and
2306         register command completer.
2307
2308 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2309
2310         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2311         (lookup_symbol_in_objfile): Change int to block_enum and add a
2312         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2313
2314 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2315
2316         * MAINTAINERS (Write After Approval): Add self.
2317
2318 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2319
2320         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2321         instruction to the dummy code region.
2322
2323 2019-07-19  Tom Tromey  <tromey@adacore.com>
2324
2325         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2326         (ARGSUSED, PARAMS, __func__): Remove rules.
2327
2328 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2329
2330         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2331         * features/arm/arm-with-iwmmxt.c: Remove.
2332         * features/arm/arm-with-iwmmxt.xml: Remove.
2333         * features/arm/arm-with-m-fpa-layout.c: Remove.
2334         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2335         * features/arm/arm-with-m-vfp-d16.c: Remove.
2336         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2337         * features/arm/arm-with-m.c: Remove.
2338         * features/arm/arm-with-m.xml: Remove.
2339         * features/arm/arm-with-neon.c: Remove.
2340         * features/arm/arm-with-neon.xml: Remove.
2341         * features/arm/arm-with-vfpv2.c: Remove.
2342         * features/arm/arm-with-vfpv2.xml: Remove.
2343         * features/arm/arm-with-vfpv3.c: Remove.
2344         * features/arm/arm-with-vfpv3.xml: Remove.
2345
2346 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2347
2348         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2349
2350 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2351
2352         * arch/aarch32.c (aarch32_create_target_description): Create
2353         target descriptions using features.
2354         * arch/arm.c (arm_create_target_description)
2355         (arm_create_mprofile_target_description): Likewise.
2356         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2357
2358 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2359
2360         * Makefile.in: Add new files.
2361         * aarch32-tdep.c: New file.
2362         * aarch32-tdep.h: New file.
2363         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2364         Call aarch32_read_description.
2365         * arch/aarch32.c: New file.
2366         * arch/aarch32.h: New file.
2367         * arch/arm.c (arm_create_target_description)
2368         (arm_create_mprofile_target_description): New function.
2369         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2370         (arm_create_target_description)
2371         (arm_create_mprofile_target_description): New declaration.
2372         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2373         read_description functions.
2374         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2375         Likewise.
2376         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2377         * arm-tdep.c (tdesc_arm_list): New variable.
2378         (arm_register_g_packet_guesses): Call create description functions.
2379         (arm_read_description) (arm_read_mprofile_description): New
2380         function.
2381         * arm-tdep.h (arm_read_description)
2382         (arm_read_mprofile_description): Add declaration.
2383         * configure.tgt: Add new files.
2384
2385 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2386
2387         * top.c (new_ui_command): Open specified terminal just once.
2388
2389 2019-07-18  Tom Tromey  <tromey@adacore.com>
2390
2391         * symtab.c (main_name): Constify return type.
2392         * symfile.c (set_initial_language): Update.
2393         * symtab.h (main_name): Constify return type.
2394
2395 2019-07-17  Tom Tromey  <tom@tromey.com>
2396
2397         * tui/tui-winsource.c (tui_update_source_window)
2398         (tui_update_source_window_as_is)
2399         (tui_update_source_windows_with_line): Remove return.
2400         * tui/tui-disasm.c (tui_show_disassem)
2401         (tui_show_disassem_and_update_source): Remove return.
2402         * tui/tui.c (tui_reset): Remove return.
2403         * tui/tui-wingeneral.c
2404         (tui_check_and_display_highlight_if_needed): Remove return.
2405
2406 2019-07-17  Tom Tromey  <tom@tromey.com>
2407
2408         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2409
2410 2019-07-17  Tom Tromey  <tom@tromey.com>
2411
2412         * tui/tui-winsource.h (struct tui_exec_info_window)
2413         (struct tui_source_window_base): Move from tui-data.h.
2414         * tui/tui-winsource.c: Move many method definitions from
2415         elsewhere.  Remove "structuring" comments.
2416         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2417         (tui_source_window_base::refresh_window): Move to
2418         tui-winsource.c.
2419         * tui/tui-win.c (tui_source_window_base::refresh_all)
2420         (tui_source_window_base::update_tab_width)
2421         (tui_source_window_base::set_new_height)
2422         (tui_source_window_base::do_make_visible_with_new_height): Move to
2423         tui-winsource.c.
2424         * tui/tui-source.h: Update.
2425         * tui/tui-source.c (tui_source_window_base::reset): Move to
2426         tui-winsource.c.
2427         * tui/tui-disasm.h: Update.
2428         * tui/tui-data.h (struct tui_exec_info_window): Move to
2429         tui-winsource.h.
2430         (struct tui_source_window_base): Likewise.
2431         * tui/tui-data.c (tui_source_window_base::clear_detail)
2432         (tui_source_window_base, ~tui_source_window_base): Move to
2433         tui-winsource.c.
2434
2435 2019-07-17  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-win.c (tui_resize_all)
2438         (tui_source_window_base::update_tab_width)
2439         (tui_adjust_win_heights): Update.
2440         (tui_win_info::make_invisible_and_set_new_height): Rename from
2441         make_invisible_and_set_new_height.
2442         * tui/tui-data.h (struct tui_win_info)
2443         <make_invisible_and_set_new_height>: New method.
2444
2445 2019-07-17  Tom Tromey  <tom@tromey.com>
2446
2447         * tui/tui.c: Update.
2448         * tui/tui-source.h (struct tui_source_window): Move from
2449         tui-data.h.
2450         * tui/tui-layout.c: Update.
2451         * tui/tui-disasm.c: Update.
2452         * tui/tui-data.h (struct tui_source_window): Move to
2453         tui-source.h.
2454
2455 2019-07-17  Tom Tromey  <tom@tromey.com>
2456
2457         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2458         tui-data.h.
2459         * tui/tui-data.h (struct tui_disasm_window): Move to
2460         tui-disasm.h.
2461
2462 2019-07-17  Tom Tromey  <tom@tromey.com>
2463
2464         * tui/tui-regs.h (struct tui_data_item_window): Move from
2465         tui-data.h.
2466         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2467         * tui/tui-data.h (struct tui_data_item_window): Move to
2468         tui-regs.h.
2469         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2470
2471 2019-07-17  Tom Tromey  <tom@tromey.com>
2472
2473         * tui/tui.c: Update.
2474         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2475         (tui_cmd_window::max_height): Move to tui-command.c.
2476         * tui/tui-layout.c: Update.
2477         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2478         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2479         tui-command.c.
2480         * tui/tui-command.h (struct tui_cmd_window): Move from
2481         tui-data.h.
2482         * tui/tui-command.c: Remove "structuring" comments.
2483         (tui_cmd_window::clear_detail)
2484         (tui_cmd_window::do_make_visible_with_new_height)
2485         (tui_cmd_window::max_height): Move from elsewhere.
2486
2487 2019-07-17  Tom Tromey  <tom@tromey.com>
2488
2489         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2490         Now static.
2491         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2492         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2493
2494 2019-07-17  Tom Tromey  <tom@tromey.com>
2495
2496         * tui/tui.c: Update.
2497         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2498         tui-regs.c.
2499         * tui/tui-windata.h: Remove file.
2500         * tui/tui-windata.c: Remove file.
2501         * tui/tui-win.c (tui_data_window::set_new_height)
2502         (tui_data_window::do_make_visible_with_new_height): Move to
2503         tui-regs.c.
2504         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2505         * tui/tui-regs.c: Remove "structuring" comments.
2506         (tui_data_window::first_data_item_displayed)
2507         (tui_data_window::delete_data_content_windows)
2508         (tui_data_window::erase_data_content)
2509         (tui_data_window::display_all_data)
2510         (tui_data_window::refresh_all)
2511         (tui_data_window::do_scroll_vertical)
2512         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2513         (tui_data_window::do_make_visible_with_new_height)
2514         (tui_data_window::refresh_window): Move from elsewhere.
2515         (_initialize_tui_regs): Move to end of file.
2516         * tui/tui-layout.c: Update.
2517         * tui/tui-hooks.c: Update.
2518         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2519         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2520         tui-regs.c.
2521         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2522
2523 2019-07-17  Tom Tromey  <tom@tromey.com>
2524
2525         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2526         seen.
2527
2528 2019-07-17  Tom Tromey  <tom@tromey.com>
2529
2530         * tui/tui-win.c (tui_source_window_base::set_new_height)
2531         (tui_source_window_base::do_make_visible_with_new_height): Use
2532         m_has_locator field directly.
2533         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2534         method.
2535         (struct tui_source_window_base) <has_locator>: Likewise.
2536
2537 2019-07-17  Tom Tromey  <tom@tromey.com>
2538
2539         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2540         Don't declare.
2541         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2542         Remove.
2543         * tui/tui-win.c (tui_source_window_base::set_new_height)
2544         (tui_source_window_base::set_new_height)
2545         (make_invisible_and_set_new_height)
2546         (tui_source_window_base::do_make_visible_with_new_height)
2547         (tui_source_window_base::do_make_visible_with_new_height):
2548         Update.
2549         * tui/tui-layout.c (show_source_disasm_command, show_data)
2550         (show_source_or_disasm_and_command): Update.
2551         * tui/tui-layout.c (show_layout): Update.
2552
2553 2019-07-17  Tom Tromey  <tom@tromey.com>
2554
2555         * tui/tui-layout.c (make_data_window): Remove.
2556         (show_data): Unify creation and re-initialization cases.
2557
2558 2019-07-17  Tom Tromey  <tom@tromey.com>
2559
2560         * tui/tui-layout.c (make_source_window, make_disasm_window):
2561         Remove.
2562         (show_data): Unify creation and re-initialization cases.
2563
2564 2019-07-17  Tom Tromey  <tom@tromey.com>
2565
2566         * tui/tui-layout.c (make_command_window): Remove.
2567         (show_source_disasm_command, show_source_or_disasm_and_command):
2568         Unify creation and re-initialization cases.
2569
2570 2019-07-17  Tom Tromey  <tom@tromey.com>
2571
2572         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2573         creation and re-initialization cases.
2574
2575 2019-07-17  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui-regs.c (tui_get_register): Return void.
2578
2579 2019-07-17  Tom Tromey  <tom@tromey.com>
2580
2581         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2582         Simplify.
2583
2584 2019-07-17  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2587         resetting.
2588
2589 2019-07-17  Tom Tromey  <tom@tromey.com>
2590
2591         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2592         * tui/tui-regs.c (tui_reg_layout): New function.
2593         (tui_show_registers, tui_reg_command): Use it.
2594         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2595         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2596         parameters.
2597         (tui_layout_command): Remove.
2598
2599 2019-07-17  Tom Tromey  <tom@tromey.com>
2600
2601         * tui/tui-layout.h (tui/tui-layout): Return void.
2602         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2603
2604 2019-07-17  Tom Tromey  <tom@tromey.com>
2605
2606         * tui/tui-layout.c (show_source_disasm_command, show_data):
2607         Update.
2608         (reset_locator): Remove.
2609         (show_source_or_disasm_and_command): Update.
2610
2611 2019-07-17  Tom Tromey  <tom@tromey.com>
2612
2613         * tui/tui-source.c (tui_source_window_base::reset): Remove
2614         win_type parameter.
2615         * tui/tui-layout.c (make_command_window, make_source_window)
2616         (make_disasm_window, make_data_window)
2617         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2618         (reset_locator, show_source_or_disasm_and_command): Update.
2619         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2620         win_type parameter.
2621         (struct tui_source_window_base) <reset>: Likewise.
2622
2623 2019-07-17  Tom Tromey  <tom@tromey.com>
2624
2625         * tui/tui-layout.c (show_source_disasm_command): Use
2626         reset_locator.
2627         (reset_locator): New function.
2628         (init_and_make_win): Remove.
2629         (show_source_or_disasm_and_command): Use reset_locator.
2630
2631 2019-07-17  Tom Tromey  <tom@tromey.com>
2632
2633         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2634         condition.
2635         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2636         Remove condition.
2637         * tui/tui-source.c (tui_source_window_base::reset): New method.
2638         * tui/tui-layout.c (make_command_window): Don't call
2639         init_and_make_win.
2640         (make_source_window, make_disasm_window): Don't call
2641         make_source_or_disasm_window.
2642         (make_data_window): Don't call init_and_make_win.  Change calling
2643         convention.
2644         (show_source_disasm_command, show_data): Simplify.
2645         (make_source_or_disasm_window): Remove.
2646         (show_source_or_disasm_and_command): Simplify.
2647         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2648         (struct tui_source_window_base) <reset>: Likewise.
2649         <execution_info>: Remove initializer.
2650         * tui/tui-data.c (tui_source_window_base): Initialize
2651         execution_info.
2652
2653 2019-07-17  Tom Tromey  <tom@tromey.com>
2654
2655         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2656         variable.
2657
2658 2019-07-17  Tom Tromey  <tom@tromey.com>
2659
2660         * tui/tui.c (tui_rl_other_window): Update.
2661         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2662         superclass method first.  Always iterate over regs_content.
2663         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2664         method.
2665         * tui/tui-win.c (tui_set_focus_command): Update.
2666
2667 2019-07-17  Tom Tromey  <tom@tromey.com>
2668
2669         * tui/tui-win.c (tui_set_focus_command): Rename from
2670         tui_set_focus.  Call tui_enable.
2671         (tui_set_focus_command): Remove.
2672
2673 2019-07-17  Tom Tromey  <tom@tromey.com>
2674
2675         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2676         refresh_window.
2677         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2678         touchwin.
2679         (tui_data_window::refresh_window): Call refresh_window on data
2680         items.  Always call superclass refresh_window.
2681         (tui_win_info::refresh): Remove.
2682         (tui_source_window_base::refresh_window): Update.
2683         (tui_refresh_all): Update.
2684         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2685         refresh_window.
2686         (show_source_or_disasm_and_command): Likewise.
2687         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2688         (struct tui_source_window_base) <refresh>: Likewise.
2689
2690 2019-07-17  Tom Tromey  <tom@tromey.com>
2691
2692         * tui/tui-winsource.c (tui_clear_source_content)
2693         (tui_show_source_content): Update.
2694         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2695         whether content is empty.
2696         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2697         Remove.
2698
2699 2019-07-17  Tom Tromey  <tom@tromey.com>
2700
2701         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2702         window's contents.
2703         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2704         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2705
2706 2019-07-17  Tom Tromey  <tom@tromey.com>
2707
2708         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2709         (struct tui_data_item_window): Update.
2710
2711 2019-07-17  Tom Tromey  <tom@tromey.com>
2712
2713         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2714         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2715         defines.
2716
2717 2019-07-17  Tom Tromey  <tom@tromey.com>
2718
2719         * tui/tui-winsource.h (tui_erase_source_content)
2720         (tui_clear_source_content): Remove "display_prompt" parameter.
2721         * tui/tui-winsource.c (tui_update_source_window_as_is)
2722         (tui_update_source_windows_with_addr): Update.
2723         (tui_clear_source_content): Remove "display_prompt" parameter.
2724         (tui_erase_source_content): Likewise.  Simplify.
2725         (tui_show_source_content): Update.
2726         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2727         * tui/tui-stack.c (tui_show_frame_info): Update.
2728         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2729         Remove defines.
2730
2731 2019-07-17  Tom Tromey  <tom@tromey.com>
2732
2733         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2734         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2735         parameter.
2736         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2737         parameter.
2738
2739 2019-07-17  Tom Tromey  <tom@tromey.com>
2740
2741         * tui/tui-winsource.c (tui_clear_source_content)
2742         (tui_show_source_content, tui_show_exec_info_content)
2743         (tui_clear_exec_info_content): Update.
2744         * tui/tui-stack.c (tui_show_locator_content): Update.
2745         (tui_show_frame_info): Update.
2746         * tui/tui-source.h (tui_source_window): Don't declare.
2747         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2748         from tui_source_is_displayed.
2749         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2750         Remove field.
2751         (struct tui_source_window_base) <content_in_use>: New field.  Now
2752         bool.
2753         (struct tui_source_window) <showing_source_p>: New method.
2754         (TUI_SRC_WIN): Change cast.
2755         * tui/tui-data.c (tui_initialize_static_data): Update.
2756
2757 2019-07-17  Tom Tromey  <tom@tromey.com>
2758
2759         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2760         location_matches_p.
2761         * tui/tui-source.c (tui_source_window::location_matches_p): New
2762         method.
2763         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2764         method.
2765         * tui/tui-data.h (struct tui_source_window_base)
2766         <location_matches_p>: New method.
2767         (struct tui_source_window, struct tui_disasm_window)
2768         <location_matches_p>: Likewise.
2769
2770 2019-07-17  Tom Tromey  <tom@tromey.com>
2771
2772         * tui/tui-win.c (tui_set_win_height_command): Rename from
2773         tui_set_win_height.
2774         (tui_set_win_height_command): Remove.
2775
2776 2019-07-17  Tom Tromey  <tom@tromey.com>
2777
2778         * tui/tui-source.c (tui_source_window): New constructor.  Add
2779         observer.
2780         (~tui_source_window): New destructor.
2781         (tui_source_window::style_changed): New method.
2782         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2783         (tui_attach_detach_observers): Update.
2784         * tui/tui-data.h (struct tui_source_window): Make constructor not
2785         inline.  Add destructor.
2786         (struct tui_source_window) <style_changed>: New method.
2787         <m_observable>: New member.
2788
2789 2019-07-17  Tom Tromey  <tom@tromey.com>
2790
2791         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2792         * tui/tui-win.c (tui_resize_all): Fix typo.
2793
2794 2019-07-17  Tom Tromey  <tom@tromey.com>
2795
2796         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2797         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2798         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2799         * tui/tui-win.c (window_name_completer): Use foreach.
2800         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2801         (update_tab_width): Likewise.
2802         * tui/tui-layout.c (show_layout): Update.
2803         * tui/tui-data.h (class tui_window_iterator): New.
2804         (struct all_tui_windows): New.
2805         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2806
2807 2019-07-17  Tom Tromey  <tom@tromey.com>
2808
2809         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2810         parameter.  Don't reference globals.
2811         (tui_reg_command): Update.
2812
2813 2019-07-17  Tom Tromey  <tom@tromey.com>
2814
2815         * tui/tui-regs.c (tui_show_registers): Simplify.
2816
2817 2019-07-17  Tom Tromey  <tom@tromey.com>
2818
2819         * tui/tui-regs.c (tui_show_registers): Update.
2820         (tui_show_register_group): Add win_info parameter.
2821
2822 2019-07-17  Tom Tromey  <tom@tromey.com>
2823
2824         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2825         Rename from tui_display_reg_element_at_line.
2826         (tui_data_window::display_registers_from_line): Update.
2827         * tui/tui-data.h (struct tui_data_window)
2828         <display_reg_element_at_line>: New method.
2829
2830 2019-07-17  Tom Tromey  <tom@tromey.com>
2831
2832         * tui/tui-regs.h (tui_display_registers_from)
2833         (tui_display_registers_from_line): Don't declare.
2834         * tui/tui-windata.c (tui_data_window::display_all_data)
2835         (tui_data_window::refresh_all)
2836         (tui_data_window::do_scroll_vertical): Update.
2837         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2838         from tui_display_registers_from.
2839         (tui_display_reg_element_at_line): Update.
2840         (tui_data_window::display_registers_from_line): Rename from
2841         tui_display_registers_from_line.
2842         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2843         display_registers_from_line>: New methods.
2844
2845 2019-07-17  Tom Tromey  <tom@tromey.com>
2846
2847         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2848         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2849         from tui_erase_data_content.
2850         (tui_data_window::display_all_data)
2851         (tui_data_window::refresh_all)
2852         (tui_data_window::do_scroll_vertical): Update.
2853         * tui/tui-regs.c (tui_show_registers): Update.
2854         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2855         New method.
2856
2857 2019-07-17  Tom Tromey  <tom@tromey.com>
2858
2859         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2860         declare.
2861         * tui/tui-windata.c
2862         (tui_data_window::delete_data_content_windows): Rename from
2863         tui_delete_data_content_windows.
2864         (tui_data_window::display_all_data)
2865         (tui_data_window::do_scroll_vertical): Update.
2866         * tui/tui-data.h (struct tui_data_window)
2867         <delete_data_content_windows>: New method.
2868
2869 2019-07-17  Tom Tromey  <tom@tromey.com>
2870
2871         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2872         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2873
2874 2019-07-17  Tom Tromey  <tom@tromey.com>
2875
2876         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2877         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2878         from tui_display_all_data.
2879         * tui/tui-win.c
2880         (tui_data_window::do_make_visible_with_new_height): Update.
2881         * tui/tui-regs.c (tui_show_registers): Update.
2882         * tui/tui-layout.c (tui_set_layout): Update.
2883         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2884         method.
2885
2886 2019-07-17  Tom Tromey  <tom@tromey.com>
2887
2888         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2889         * tui/tui-windata.c (tui_display_data_from): Remove.
2890         (tui_data_window::refresh_all): Update.
2891
2892 2019-07-17  Tom Tromey  <tom@tromey.com>
2893
2894         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2895         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2896         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2897         tui_display_registers_from_line.
2898         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2899         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2900         "force_display" parameter.
2901
2902 2019-07-17  Tom Tromey  <tom@tromey.com>
2903
2904         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2905         declare.
2906         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2907         Rename from tui_first_reg_element_no_inline.
2908         (tui_display_reg_element_at_line)
2909         (tui_display_registers_from_line): Update.
2910         * tui/tui-data.h (struct tui_data_window)
2911         <first_reg_element_no_inline>: New method.
2912
2913 2019-07-17  Tom Tromey  <tom@tromey.com>
2914
2915         * tui/tui-windata.c (tui_display_data_from)
2916         (tui_data_window::do_scroll_vertical): Update.
2917         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2918         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2919         Rename from tui_line_from_reg_element_no.
2920         (tui_display_registers_from_line): Update.
2921         * tui/tui-data.h (struct tui_data_window)
2922         <line_from_reg_element_no>: New method.
2923
2924 2019-07-17  Tom Tromey  <tom@tromey.com>
2925
2926         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2927         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2928         tui_last_regs_line_no.
2929         (tui_display_reg_element_at_line)
2930         (tui_display_registers_from_line): Update.
2931         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2932         method.
2933
2934 2019-07-17  Tom Tromey  <tom@tromey.com>
2935
2936         PR tui/24722:
2937         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2938         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2939         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2940         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2941         (tui_update_breakpoint_info): Likewise.
2942         * tui/tui-hooks.c (tui_event_create_breakpoint)
2943         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2944         Update.
2945
2946 2019-07-17  Tom Tromey  <tom@tromey.com>
2947
2948         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2949
2950 2019-07-17  Tom Tromey  <tom@tromey.com>
2951
2952         * tui/tui-winsource.c (tui_update_source_window_as_is)
2953         (tui_update_source_windows_with_addr): Update.
2954         * tui/tui-source.h (tui_set_source_content)
2955         (tui_show_symtab_source): Add "win_info" parameter.
2956         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2957         parameter.
2958         (tui_show_symtab_source): Likewise.
2959
2960 2019-07-17  Tom Tromey  <tom@tromey.com>
2961
2962         * tui/tui-wingeneral.c
2963         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2964
2965 2019-07-17  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2968         (struct tui_cmd_window) <can_scroll>: New method.
2969         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2970         method.
2971
2972 2019-07-17  Tom Tromey  <tromey@adacore.com>
2973
2974         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2975         do_field_signed>: Rename.  Change type of "value".
2976         * ui-out.c (ui_out::field_signed): Rename from field_int.
2977         Change type of "value".
2978         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2979         type of "value".
2980         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2981         do_field_int.  Change type of "value".
2982         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2983         do_field_int.  Change type of "value".
2984         * tracepoint.c (trace_status_mi, tfind_1)
2985         (print_one_static_tracepoint_marker): Update.
2986         * thread.c (print_thread_info_1, print_selected_thread_frame):
2987         Update.
2988         * stack.c (print_frame, print_frame_info): Update.
2989         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2990         Update.
2991         * source.c (print_source_lines_base): Update.
2992         * skip.c (info_skip_command): Update.
2993         * record-btrace.c (btrace_ui_out_decode_error)
2994         (btrace_call_history_src_line): Update.
2995         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2996         Update.
2997         * progspace.c (print_program_space): Update.
2998         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2999         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3000         do_field_int.  Change type of "value".
3001         * mi/mi-out.c (mi_ui_out::do_table_begin)
3002         (mi_ui_out::do_table_header): Update.
3003         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3004         type of "value".
3005         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3006         (mi_cmd_data_list_changed_registers, output_register)
3007         (mi_cmd_data_read_memory, mi_load_progress)
3008         (mi_cmd_trace_frame_collected): Update.
3009         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3010         Update.
3011         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3012         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3013         (mi_cmd_var_list_children, varobj_update_one): Update.
3014         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3015         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3016         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3017         * inferior.c (print_inferior): Update.
3018         * gdb_bfd.c (print_one_bfd): Update.
3019         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3020         Update.
3021         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3022         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3023         do_field_int.  Change type of "value".
3024         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3025         do_field_int.  Change type of "value".
3026         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3027         (print_one_breakpoint_location, print_it_catch_fork)
3028         (print_one_catch_fork, print_it_catch_vfork)
3029         (print_one_catch_vfork, print_it_catch_solib)
3030         (print_it_catch_exec, print_it_ranged_breakpoint)
3031         (print_mention_watchpoint, print_mention_masked_watchpoint)
3032         (bkpt_print_it, update_static_tracepoint): Update.
3033         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3034         * break-catch-syscall.c (print_it_catch_syscall): Update.
3035         * ada-tasks.c (print_ada_task_info): Update.
3036         * ada-lang.c (print_it_exception, print_mention_exception):
3037         Update.
3038
3039 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3040
3041         PR breakpoints/24541
3042         * gdbarch.c: Regenerate.
3043         * gdbarch.h: Regenerate.
3044         * gdbarch.sh: Adjust return type and parameter types for
3045         'stap_adjust_register'.
3046         (i386_stap_adjust_register): Adjust signature and return new
3047         register name.
3048         * stap-probe.c (stap_parse_register_operand): Adjust use of
3049         'gdbarch_stap_adjust_register'.
3050
3051 2019-07-17  Tom Tromey  <tromey@adacore.com>
3052
3053         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3054         declare VEC.
3055         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3056         std::vector.
3057         (struct s390_process_info): Add initializers.
3058         (s390_add_process): Use new.
3059         (s390_linux_nat_target::low_forget_process): Use delete.
3060         (s390_linux_nat_target::low_new_fork)
3061         (s390_linux_nat_target::stopped_by_watchpoint)
3062         (s390_linux_nat_target::low_prepare_to_resume)
3063         (s390_linux_nat_target::insert_watchpoint)
3064         (s390_linux_nat_target::insert_hw_breakpoint)
3065         (s390_linux_nat_target::remove_watchpoint)
3066         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3067
3068 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3069
3070         * aarch64-fbsd-nat.c: Include regcache.h.
3071         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3072         argument.
3073         (aarch64_fbsd_nat_target::fetch_registers)
3074         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3075         variable.
3076         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3077
3078 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3079
3080         * fbsd-nat.c: Include gdbarch.h.
3081
3082 2019-07-15  Tom Tromey  <tromey@adacore.com>
3083
3084         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3085
3086 2019-07-15  Tom Tromey  <tromey@adacore.com>
3087
3088         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3089         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3090         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3091         * cli-out.c (cli_ui_out::do_field_int): New method.
3092         * ui-out.c (ui_out::field_unsigned): New method.
3093         * symfile.c (generic_load): Use field_unsigned.
3094         (print_transfer_performance): Likewise.
3095         * record-btrace.c (ui_out_field_uint): Remove.
3096         (btrace_call_history_insn_range, btrace_call_history): Use
3097         field_unsigned.
3098         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3099         field_unsigned.
3100         * ui-out.h (class ui_out) <field_unsigned>: New method.
3101         <do_field_unsigned>: Likewise.
3102
3103 2019-07-15  Tom Tromey  <tromey@adacore.com>
3104
3105         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3106         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3107         * target.c (flash_erase_command): Use field_string.
3108         * infrun.c (print_signal_received_reason): Use field_string.
3109         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3110         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3111         field_string.
3112         * ada-tasks.c (print_ada_task_info): Use field_string.
3113
3114 2019-07-15  Tom Tromey  <tromey@adacore.com>
3115
3116         * target.c (flash_erase_command): Use field_core_addr.
3117         * symfile.c (generic_load): Use field_core_addr.
3118         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3119         Use field_core_addr.
3120         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3121         field_core_addr.
3122
3123 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3124
3125         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3126         value if its desired type is smaller than a CORE_ADDR and signed.
3127
3128 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3129
3130         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3131         of changes to field names, and use new is_reference field to
3132         decide if a property is a reference or not.
3133         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3134         field.
3135         (struct dwarf2_property_baton): Update header comment, rename
3136         'referenced_type' to 'property_type' and update comments.
3137         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3138         default property type, store in property baton, update to take
3139         accound of renamed field.
3140         (read_func_scope): Update call to attr_to_dynamic_prop.
3141         (read_array_type): Likewise.
3142         (dwarf2_per_cu_addr_sized_int_type): New function.
3143         (read_subrange_index_type): Move type finding code to
3144         dwarf2_per_cu_addr_sized_int_type.
3145         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3146         (dwarf2_per_cu_addr_type): New function.
3147         (set_die_type): Update calls to attr_to_dynamic_prop.
3148
3149 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3150
3151         * dwarf2read.c (read_subrange_index_type): New function.
3152         (read_subrange_type): Move code into new function and call it.
3153         * gdbtypes.c (create_range_type): Add some asserts.
3154
3155 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3156
3157         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3158         update return statements.
3159         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3160         declaration, and update comment to match.
3161         * gdbtypes.c (resolve_dynamic_array): Update call to
3162         dwarf2_evaluate_property to match new return type.
3163
3164 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3165
3166         * valarith.c (value_subscripted_rvalue): Change lowerbound
3167         parameter type from int to LONGEST.
3168         * value.h (value_subscripted_rvalue): Likewise in declaration.
3169
3170 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3171
3172         * cli/cli-utils.c (info_print_command_completer): New function.
3173         * cli/cli-utils.h: Add 'completer.h' include, and forward
3174         declaration for 'struct cmd_list_element'.
3175         (info_print_command_completer): Declare.
3176         * stack.c (_initialize_stack): Add completer for 'info locals' and
3177         'info args'.
3178         * symtab.c (_initialize_symtab): Add completer for 'info
3179         variables' and 'info functions'.
3180         * NEWS: Mention completion for additional info commands.
3181
3182 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3183
3184         * cli/cli-utils.c (extract_info_print_args): Delete.
3185         (extract_arg_maybe_quoted): Delete.
3186         (info_print_options_defs): New variable.
3187         (make_info_print_options_def_group): New function.
3188         (extract_info_print_options): Define new function.
3189         * cli/cli-utils.h (extract_info_print_args): Delete.
3190         (struct info_print_options): New structure.
3191         (extract_info_print_options): Declare new function.
3192         * stack.c (info_locals_command): Update to use new
3193         extract_info_print_options, also add a header comment.
3194         (info_args_command): Likewise.
3195         * symtab.c (info_variables_command): Likewise.
3196         (info_functions_command): Likewise.
3197
3198 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3199
3200         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3201         to extract string arguments.
3202         * common/common-utils.c (extract_string_maybe_quoted): New function.
3203         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3204
3205 2019-07-11  Tom Tromey  <tromey@adacore.com>
3206
3207         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3208         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3209         * top.h (gdbinit): Don't declare.
3210         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3211         into...
3212         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3213         * top.c (gdb_init): Don't call init_cli_cmds.
3214         (gdbinit): Remove.
3215         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3216
3217 2019-07-11  Tom Tromey  <tromey@adacore.com>
3218
3219         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3220         after it has been moved.
3221
3222 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3223
3224         * valops.c (value_must_coerce_to_target): Change return type to
3225         bool.
3226         * value.h (value_must_coerce_to_target): Likewise.
3227
3228 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3229
3230         * breakpoint.c (is_hardware_watchpoint): Remove
3231         forward-declaration.
3232         (is_masked_watchpoint): Change return type to bool.
3233         (is_tracepoint): Likewise.
3234         (is_breakpoint): Likewise.
3235         (is_hardware_watchpoint): Likewise.
3236         (is_watchpoint): Likewise.
3237         (is_no_memory_software_watchpoint): Likewise.
3238         (is_catchpoint): Likewise.
3239         (breakpoint_1): Make FILTER parameter's return type bool.
3240         is_masked_watchpoint): Change return type to bool.
3241         (save_breakpoints): Make FILTER parameter's return type bool.
3242         * breakpoint.h (is_breakpoint): Change return type to bool.
3243         (is_watchpoint): Likewise.
3244         (is_catchpoint): Likewise.
3245         (is_tracepoint): Likewise.
3246
3247 2019-07-10  Tom Tromey  <tom@tromey.com>
3248
3249         * defs.h: Don't include gdbarch.h.
3250         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3251         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3252         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3253         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3254         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3255         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3256         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3257         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3258         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3259         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3260         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3261         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3262         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3263         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3264         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3265         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3266         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3267         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3268         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3269         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3270         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3271         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3272         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3273         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3274         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3275         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3276         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3277
3278 2019-07-10  Tom Tromey  <tromey@adacore.com>
3279
3280         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3281         * breakpoint.c (init_ada_exception_breakpoint): Register as
3282         bp_catchpoint.
3283         (print_one_breakpoint_location, print_one_breakpoint): Use
3284         is_ada_exception_catchpoint.
3285         * ada-lang.c (class ada_catchpoint_location): Pass
3286         bp_loc_software_breakpoint to bp_location constructor.
3287         (is_ada_exception_catchpoint): New function.
3288
3289 2019-07-10  Tom Tromey  <tromey@adacore.com>
3290
3291         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3292         VEC.
3293         (struct arm_exidx_entry): New method operator<.
3294         (struct arm_exidx_data) <section_maps>: Change type.
3295         (arm_exidx_data_free): Remove.
3296         (arm_exidx_data_key): Change type.  Move lower.
3297         (arm_exidx_new_objfile): Update.
3298         (arm_compare_exidx_entries): Remove.
3299         (arm_find_exidx_entry, _initialize_arm_tdep)
3300
3301 2019-07-10  Tom Tromey  <tromey@adacore.com>
3302
3303         * solib-spu.c (ocl_program_data_key): Change type.
3304         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3305         Update.
3306
3307 2019-07-10  Tom Tromey  <tromey@adacore.com>
3308
3309         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3310         (struct solib_aix_inferior_data) <library_list>: Change type.
3311         (solib_aix_inferior_data_handle): Change type.
3312         (get_solib_aix_inferior_data): Update.
3313         (solib_aix_free_library_list): Remove.
3314         (library_list_start_library): Update.
3315         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3316         return type.
3317         (solib_aix_get_library_list)
3318         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3319         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3320
3321 2019-07-10  Tom Tromey  <tromey@adacore.com>
3322
3323         * solib-dsbt.c (struct dsbt_info): Add initializers.
3324         (solib_dsbt_pspace_data): Change type.
3325         (dsbt_pspace_data_cleanup): Remove.
3326         (get_dsbt_info, _initialize_dsbt_solib): Update.
3327
3328 2019-07-10  Tom Tromey  <tromey@adacore.com>
3329
3330         * spu-tdep.c (spu_overlay_data): Change type.
3331         (spu_get_overlay_table, spu_overlay_new_objfile)
3332         (_initialize_spu_tdep): Update.
3333
3334 2019-07-10  Tom Tromey  <tromey@adacore.com>
3335
3336         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3337         destructor.
3338         (dbx_objfile_data_key): Change type and declare later.
3339         (DBX_SYMFILE_INFO): Rewrite.
3340         * dbxread.c (dbx_objfile_data_key): Change type.
3341         (dbx_symfile_init): Update.
3342         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3343         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3344         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3345
3346 2019-07-10  Tom Tromey  <tromey@adacore.com>
3347
3348         * jit.c (jit_program_space_key): Change type.  Move lower.
3349         (get_jit_program_space_data): Update.
3350         (jit_program_space_data_cleanup): Remove.
3351         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3352         Update.
3353         (struct jit_program_space_data): Add initializers.
3354
3355 2019-07-10  Tom Tromey  <tromey@adacore.com>
3356
3357         * solib-darwin.c (struct darwin_info): Add initializers.
3358         (solib_darwin_pspace_data): Change type.
3359         (darwin_pspace_data_cleanup): Remove.
3360         (get_darwin_info, _initialize_darwin_solib): Update.
3361
3362 2019-07-10  Tom Tromey  <tromey@adacore.com>
3363
3364         * remote-sim.c (struct sim_inferior_data): Add initializers,
3365         constructor, and destructor.
3366         (sim_inferior_data_key): Change type.  Move lower.
3367         (check_for_duplicate_sim_descriptor): Update.
3368         (get_sim_inferior_data): Use new.  Update.
3369         (~sim_inferior_data_cleanup): Rename from
3370         sim_inferior_data_cleanup.  Simplify.
3371         (gdbsim_close_inferior, simulator_command)
3372         (sim_command_completer, _initialize_remote_sim): Update.
3373         (next_pid, INITIAL_PID): Move earlier.
3374
3375 2019-07-10  Tom Tromey  <tromey@adacore.com>
3376
3377         * python/python-internal.h (create_thread_object): Return
3378         gdbpy_ref.
3379         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3380         * python/py-inferior.c (struct threadlist_entry): Add
3381         constructor.
3382         <thread_obj>: Now a gdbpy_ref.
3383         (thread_to_thread_object): Update.
3384         (add_thread_object): Use new.
3385         (delete_thread_object): Use delete.
3386         (infpy_threads): Update.
3387         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3388         GIL.
3389
3390 2019-07-10  Tom Tromey  <tromey@adacore.com>
3391
3392         * valops.c (value_cast): Specialize error message for Ada.
3393
3394 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3395
3396         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3397
3398 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3399
3400         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3401         bpstat_should_step): Return bool, adjust comments.
3402         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3403         bpstat_should_step): Likewise.
3404
3405 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3406
3407         * features/Makefile: Use feature target descriptions for Arm.
3408         * features/arm/arm-core.c: Generate new file.
3409         * features/arm/arm-fpa.c: Likewise.
3410         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3411         * features/arm/arm-m-profile.c: Likewise.
3412         * features/arm/arm-vfpv2.c: Likewise.
3413         * features/arm/arm-vfpv3.c: Likewise.
3414         * features/arm/xscale-iwmmxt.c: Likewise.
3415         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3416
3417 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3418
3419         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3420         ptrace earlier.
3421
3422 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3423
3424         * features/aarch64-pauth.c: Regenerate.
3425
3426 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3427
3428         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3429         bool.
3430         (bpstat_what): Use false instead of 0.
3431
3432 2019-07-09  Pedro Alves  <palves@redhat.com>
3433
3434         * break-catch-throw.c (is_exception_catchpoint): New.
3435         * breakpoint.c (print_one_breakpoint_location): New parameter
3436         'raw_loc'.  Handle it.  Use
3437         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3438         looking at the breakpoint's type.
3439         (print_one_breakpoint): If handling "maint info breakpoints", also
3440         print locations of exception catchpoints.
3441         * breakpoint.h (is_exception_catchpoint): Declare.
3442
3443 2019-07-09  Pedro Alves  <palves@redhat.com>
3444
3445         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3446         "addr" field.
3447         (allocate_location_exception_catchpoint): New.
3448         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3449         (initialize_throw_catchpoint_ops): Install
3450         allocate_location_exception_catchpoint as allocate_location
3451         method.
3452         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3453         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3454         bp_loc_other.
3455         (breakpoint_address_is_meaningful): Delete.
3456         (bl_address_is_meaningful): New.
3457         (breakpoint_locations_match): Adjust comment.
3458         (bp_location_from_bp_type): New, factored out of...
3459         (bp_location::bp_location(breakpoint *)): ... this.
3460         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3461         factored out of...
3462         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3463         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3464         breakpoint_address_is_meaningful.
3465         (bp_locations_compare): Adjust comment.
3466         (update_global_location_list): Use bl_address_is_meaningful
3467         instead of breakpoint_address_is_meaningful.
3468         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3469         explicit.
3470         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3471         * python/py-breakpoint.c (bppy_get_location): No longer check
3472         whether location is null.
3473
3474 2019-07-09  Pedro Alves  <palves@redhat.com>
3475
3476         PR c++/15468
3477         * breakpoint.c (print_one_breakpoint_location): Remove
3478         single-location assert.
3479
3480 2019-07-09  Tom Tromey  <tom@tromey.com>
3481
3482         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3483         * configure: Rebuild.
3484         * configure.ac: Change common to gdbsupport.
3485         * gdbsupport: Rename from common.
3486         * acinclude.m4: Change common to gdbsupport.
3487         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3488         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3489         gdbsupport.
3490         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3491         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3492         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3493         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3494         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3495         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3496         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3497         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3498         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3499         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3500         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3501         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3502         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3503         coff-pe-read.c, command.h, compile/compile-c-support.c,
3504         compile/compile-c.h, compile/compile-cplus-symbols.c,
3505         compile/compile-cplus-types.c, compile/compile-cplus.h,
3506         compile/compile-loc2c.c, compile/compile.c, completer.c,
3507         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3508         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3509         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3510         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3511         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3512         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3513         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3514         features/aarch64-core.c, features/aarch64-fpu.c,
3515         features/aarch64-pauth.c, features/aarch64-sve.c,
3516         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3517         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3518         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3519         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3520         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3521         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3522         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3523         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3524         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3525         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3526         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3527         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3528         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3529         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3530         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3531         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3532         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3533         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3534         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3535         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3536         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3537         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3538         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3539         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3540         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3541         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3542         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3543         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3544         minsyms.c, mips-linux-tdep.c, namespace.h,
3545         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3546         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3547         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3548         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3549         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3550         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3551         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3552         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3553         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3554         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3555         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3556         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3557         procfs.c, producer.c, progspace.h, psymtab.h,
3558         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3559         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3560         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3561         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3562         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3563         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3564         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3565         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3566         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3567         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3568         target-memory.c, target.c, target.h, target/waitstatus.c,
3569         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3570         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3571         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3572         unittests/array-view-selftests.c,
3573         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3574         unittests/common-utils-selftests.c,
3575         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3576         unittests/format_pieces-selftests.c,
3577         unittests/function-view-selftests.c,
3578         unittests/lookup_name_info-selftests.c,
3579         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3580         unittests/mkdir-recursive-selftests.c,
3581         unittests/observable-selftests.c,
3582         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3583         unittests/parse-connection-spec-selftests.c,
3584         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3585         unittests/scoped_fd-selftests.c,
3586         unittests/scoped_mmap-selftests.c,
3587         unittests/scoped_restore-selftests.c,
3588         unittests/string_view-selftests.c, unittests/style-selftests.c,
3589         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3590         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3591         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3592         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3593         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3594         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3595
3596 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3597
3598         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3599         bool value.
3600         (decode_digits_ordinary): Set explicit_line field in sal.
3601         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3602         symtab_and_line that was set on an explicit line number in
3603         assembler code.  Do always update the recorded symtab and line if
3604         we do skip the prologue.
3605
3606 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3607
3608         * breakpoint.c (set_breakpoint_location_function): Remove
3609         explicit_loc parameter.
3610         (momentary_breakpoint_from_master): Update call to
3611         set_breakpoint_location_function.
3612         (add_location_to_breakpoint): Likewise.
3613
3614 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3615
3616         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3617         required features based on default bfd type when no specific bfd
3618         is present.
3619
3620 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3621
3622         * NEWS: Mention that GDB printf and eval commands can now print
3623         C-style and Ada-style convenience var strings without
3624         calling the inferior.
3625         * printcmd.c (printf_c_string): Locally print GDB internal var
3626         instead of transiting via the inferior.
3627         (printf_wide_c_string): Likewise.
3628
3629 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3630
3631         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3632
3633 2019-07-04  Tom Tromey  <tom@tromey.com>
3634
3635         PR tui/24724:
3636         * tui/tui-winsource.c (tui_clear_source_content): Update.
3637         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3638         (tui_update_breakpoint_info): Update.
3639         (tui_set_exec_info_content): Update.
3640         * tui/tui-source.c (tui_set_source_content_nil): Update.
3641         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3642         has_break.
3643         * tui/tui-data.h (enum tui_bp_flag): New.
3644         (tui_bp_flags): New enum flags type.
3645         (struct tui_source_element) <break_mode>: Change type.  Rename
3646         from has_break.
3647         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3648         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3649         constants.
3650         * tui/tui-winsource.h: Fix comment.
3651
3652 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3653
3654         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3655         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3656         (store_fpregs_to_thread)
3657         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3658         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3659         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3660         (IWMMXT_REGS_SIZE): Add define.
3661         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3662         (fetch_vfp_regs, store_vfp_regs)
3663         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3664         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3665
3666 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3667
3668         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3669         defines.
3670         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3671         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3672         (ARM_INT_REGISTER_SIZE): ...to this.
3673         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3674         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3675         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3676         (arm_linux_collect_gregset, supply_nwfpe_register)
3677         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3678         defines.
3679         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3680         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3681         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3682         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3683         (arm_return_in_memory, arm_store_return_value)
3684         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3685         (arm_record_ld_st_multiple): Likewise.
3686         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3687         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3688
3689 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3690
3691         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3692         AARCH64_DISPLACED_MODIFIED_INSNS.
3693         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3694         (aarch64_displaced_step_copy_insn): Likewise.
3695         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3696         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3697         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3698         ARM_DISPLACED_MODIFIED_INSNS.
3699         * arm-tdep.c (arm_gdbarch_init): Likewise.
3700         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3701         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3702         (struct arm_displaced_step_closure): Use
3703         ARM_DISPLACED_MODIFIED_INSNS.
3704
3705 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3706
3707         * features/Makefile: Remove unused xml files.
3708         * features/aarch64.xml: Remove.
3709         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3710         * features/i386/amd64-avx-avx512.xml: Remove.
3711         * features/i386/amd64-avx-linux.xml: Remove.
3712         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3713         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3714         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3715         * features/i386/amd64-avx-mpx.xml: Remove.
3716         * features/i386/amd64-avx.xml: Remove.
3717         * features/i386/amd64-linux.xml: Remove.
3718         * features/i386/amd64-mpx-linux.xml: Remove.
3719         * features/i386/amd64-mpx.xml: Remove.
3720         * features/i386/amd64.xml: Remove.
3721         * features/i386/i386-avx-avx512-linux.xml: Remove.
3722         * features/i386/i386-avx-avx512.xml: Remove.
3723         * features/i386/i386-avx-linux.xml: Remove.
3724         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3725         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3726         * features/i386/i386-avx-mpx-linux.xml: Remove.
3727         * features/i386/i386-avx-mpx.xml: Remove.
3728         * features/i386/i386-avx.xml: Remove.
3729         * features/i386/i386-linux.xml: Remove.
3730         * features/i386/i386-mmx-linux.xml: Remove.
3731         * features/i386/i386-mmx.xml: Remove.
3732         * features/i386/i386-mpx-linux.xml: Remove.
3733         * features/i386/i386-mpx.xml: Remove.
3734         * features/i386/i386.xml: Remove.
3735         * features/i386/x32-avx-avx512-linux.xml: Remove.
3736         * features/i386/x32-avx-linux.xml: Remove.
3737         * features/i386/x32-linux.xml: Remove.
3738
3739 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3740
3741         * regformats/aarch64.dat: Remove.
3742         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3743         * regformats/i386/amd64-avx-linux.dat: Remove.
3744         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3745         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3746         * regformats/i386/amd64-linux.dat: Remove.
3747         * regformats/i386/amd64-mpx-linux.dat: Remove.
3748         * regformats/i386/amd64.dat: Remove.
3749         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3750         * regformats/i386/i386-avx-linux.dat: Remove.
3751         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3752         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3753         * regformats/i386/i386-linux.dat: Remove.
3754         * regformats/i386/i386-mmx-linux.dat: Remove.
3755         * regformats/i386/i386-mpx-linux.dat: Remove.
3756         * regformats/i386/i386.dat: Remove.
3757         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3758         * regformats/i386/x32-avx-linux.dat: Remove.
3759         * regformats/i386/x32-linux.dat: Remove.
3760
3761 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3762
3763         * aarch64-tdep.c: Remove xml self tests.
3764         * amd64-linux-tdep.c: Likewise.
3765         * amd64-tdep.c: Likewise.
3766         * i386-linux-tdep.c: Likewise.
3767         * i386-tdep.c: Likewise.
3768
3769 2019-07-03  Pedro Alves  <palves@redhat.com>
3770
3771         PR cli/24732
3772         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3773         (pipe_cmd_option_defs): New.
3774         (make_pipe_cmd_options_def_group): New.
3775         (pipe_command): Use gdb::option::process_options.
3776         (pipe_command_completer): New function.
3777         (_initialize_cli_cmds): Install completer for "pipe" command.
3778
3779 2019-07-03  Pedro Alves  <palves@redhat.com>
3780
3781         * cli/cli-option.c (union option_value) <string>: New field.
3782         (struct option_def_and_value): Add ctor, move ctor, dtor and
3783         use DISABLE_COPY_AND_ASSIGN.
3784         (option_def_and_value::clear_value): New.
3785         (parse_option, save_option_value_in_ctx, get_val_type_str)
3786         (add_setshow_cmds_for_options): Handle var_string.
3787         * cli-option.h (union option_def::var_address) <string>: New
3788         field.
3789         (struct string_option_def): New.
3790         * maint-test-options.c (struct test_options_opts): Add default
3791         ctor and use DISABLE_COPY_AND_ASSIGN.
3792         <string_opt>: New field.
3793         (test_options_opts::~test_options_opts): New.
3794         (test_options_opts::dump): Also dump "-string".
3795         (test_options_option_defs): Install "string.
3796
3797 2019-07-03  Pedro Alves  <palves@redhat.com>
3798
3799         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3800         option_value with a null enumeration.
3801         (complete_options): Save the option values in the context.
3802         (save_option_value_in_ctx): New, factored out from ...
3803         (process_options): ... here.
3804         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3805         of the function.
3806         * maint-test-options.c (test_options_opts::dump): New, factored
3807         out from ...
3808         (maintenance_test_options_command_mode): ... here.
3809         (maintenance_test_options_command_completion_result): Delete.
3810         (maintenance_test_options_command_completion_text): Update
3811         comment.
3812         (maintenance_show_test_options_completion_result): Change
3813         prototype.  Just print
3814         maintenance_test_options_command_completion_text.
3815         (save_completion_result): New.
3816         (maintenance_test_options_completer_mode): Pass options context to
3817         complete_options, and then save a dump.
3818         (_initialize_maint_test_options): Use add_cmd to install "maint
3819         show test-options-completion-result".
3820
3821 2019-07-03  Pedro Alves  <palves@redhat.com>
3822
3823         * NEWS (New commands): Mention "with" and "maint with".
3824         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3825         (with_command, with_command_completer): New.
3826         (pipe_command): Adjust to new repeat_previous
3827         interface.
3828         (_initialize_cli_cmds): Install the "with" command and its "w"
3829         alias.
3830         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3831         declarations.
3832         * cli/cli-setshow.c (parse_cli_var_uinteger)
3833         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3834         argument strings for all var_types.
3835         (get_setshow_command_value_string): New, factored out from ...
3836         (do_show_command): ... this.
3837         * cli/cli-setshow.h: Include <string>.
3838         (get_setshow_command_value_string): Declare.
3839         * command.h (repeat_previous): Now returns const char *.  Adjust
3840         comment.
3841         * maint.c: Include "cli/cli-cmds.h".
3842         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3843         (_initialize_maint_cmds): Register the "maintenance with" command.
3844         * top.c (repeat_previous): Move bits from pipe_command here:
3845         Return the saved command line, if any; error out if there's no
3846         command to relaunch.
3847
3848 2019-07-03  Pedro Alves  <palves@redhat.com>
3849
3850         * NEWS (New commands): Mention "maint set/show test-settings"
3851         instead of "maint test-settings".
3852         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3853         (maintenance_test_settings_set_list): Rename to ...
3854         (maintenance_set_test_settings_list): ... this.
3855         (maintenance_test_settings_show_list): Rename to  ...
3856         (maintenance_show_test_settings_list): ... this.
3857         (maintenance_test_settings_cmd): Delete.
3858         (maintenance_test_settings_set_cmd): ...
3859         (maintenance_set_test_settings_cmd): ... this.
3860         (maintenance_test_settings_show_cmd): ...
3861         (maintenance_show_test_settings_cmd): ... this.
3862         (maintenance_test_settings_show_value_cmd):
3863         (maintenance_show_test_settings_value_cmd): ... this.
3864         (_initialize_maint_test_settings): No longer install the "maint
3865         test-settings" prefix command.  Rename "maint test-settings set"
3866         to "maint set test-settings", and "maint test-settings show" to
3867         "maint show test-settings".  Adjust all subcommands.
3868
3869 2019-07-03  Pedro Alves  <palves@redhat.com>
3870
3871         * maint-test-settings.c: Fix file's intro comment.  Replace all
3872         references to "test-options" with references to "test-settings",
3873         in comments.
3874
3875 2019-07-03  Pedro Alves  <palves@redhat.com>
3876
3877         * maint-test-settings.c (maintenance_test_settings_xxx)
3878         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3879         New.
3880         (maintenance_test_settings_enums): Use them.
3881         (maintenance_test_settings_enum): Default to
3882         maintenance_test_settings_xxx.
3883         (_initialize_maint_test_settings): Initialize
3884         MAINTENANCE_TEST_SETTINGS_FILENAME.
3885
3886 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3887
3888         * breakpoint.h (remove_breakpoints_inf): Change return type to
3889         void, move function documentation here.
3890         * breakpoint.c (remove_breakpoints_inf): Change return type to
3891         void, move function documentation to header.
3892
3893 2019-07-02  Pedro Alves  <palves@redhat.com>
3894
3895         * NEWS (Completion improvements): Mention "info threads".
3896         * thread.c (struct info_threads_opts, info_threads_option_defs)
3897         (make_info_threads_options_def_group): New.
3898         (info_threads_command): Use gdb::option::process_options.
3899         (info_threads_command_completer): New.
3900         (_initialize_thread): Use gdb::option::build_help to build the
3901         help text for "info threads".
3902
3903 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3904
3905         * defs.h (generic_load): Move from here...
3906         * symfile.h (generic_load): ... to here.  Rename name parameter
3907         to args.
3908         * symfile.c (generic_load): Add comment.
3909
3910 2019-07-01  Tom Tromey  <tromey@adacore.com>
3911
3912         * dwarf2read.c
3913         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3914         declaration of without_params.  Fix formatting.
3915
3916 2019-07-01  Tom Tromey  <tromey@adacore.com>
3917
3918         * ada-exp.y (find_primitive_type): Update.
3919         * ada-lang.h (ada_lookup_symbol): Update.
3920         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3921         parameter.
3922         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3923
3924 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3925
3926         PR breakpoints/24541
3927         * gdbarch.c: Regenerate.
3928         * gdbarch.h: Regenerate.
3929         * gdbarch.sh: Add 'stap_adjust_register'.
3930         * i386-tdep.c: Include '<unordered_set>'.
3931         (i386_stap_adjust_register): New function.
3932         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3933         * stap-probe.c (stap_parse_register_operand): Call
3934         'gdbarch_stap_adjust_register'.
3935
3936 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3937
3938         PR python/24742
3939         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3940         * python/python.c (do_start_initialization): Use 'xmalloc'
3941         instead of 'PyMem_Malloc'.
3942
3943 2019-06-28  Tom Tromey  <tromey@adacore.com>
3944
3945         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3946         for Ada.
3947
3948 2019-06-27  Tom Tromey  <tromey@adacore.com>
3949
3950         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3951         objfile_key.
3952         (arm_find_mapping_symbol, arm_record_special_symbol)
3953         (_initialize_arm_tdep): Update.
3954         (arm_objfile_data_free): Remove.
3955
3956 2019-06-27  Tom Tromey  <tromey@adacore.com>
3957
3958         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3959         to cp_print_static_field.
3960
3961 2019-06-26  Tom Tromey  <tromey@adacore.com>
3962
3963         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3964         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3965         declare.
3966
3967 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3968
3969         * features/aarch64-core.c (create_feature_aarch64_core):
3970         Regenerate.
3971         * features/aarch64-core.xml: Add cpsr flags.
3972
3973 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3974
3975         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3976         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3977
3978 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3979
3980         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3981         field.
3982         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3983         use.
3984         (arm_record_special_symbol): Don't insert new symbol in sorted
3985         position, push it at the end.
3986
3987 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3988
3989         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3990         (arm_mapping_symbol_s): Remove.
3991         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3992         (arm_mapping_symbol_vec): New typedef.
3993         (struct arm_per_objfile): Add constructor.
3994         <section_maps>: Change type to
3995         std::unique_ptr<arm_mapping_symbol_vec[]>.
3996         (arm_compare_mapping_symbols): Remove.
3997         (arm_find_mapping_symbol): Adjust to section_maps type change.
3998         (arm_objfile_data_free): Call delete on arm_per_objfile.
3999         (arm_record_special_symbol): Adjust to section_maps type change.
4000         Allocate arm_per_objfile with new.
4001
4002 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4003
4004         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4005         with the command prefix.
4006
4007 2019-06-25  Tom Tromey  <tom@tromey.com>
4008
4009         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4010         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4011
4012 2019-06-25  Tom Tromey  <tom@tromey.com>
4013
4014         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4015         type.
4016         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4017         protected.
4018
4019 2019-06-25  Tom Tromey  <tom@tromey.com>
4020
4021         * tui/tui-winsource.c
4022         (tui_source_window_base::set_is_exec_point_at): Add check against
4023         LOA_ADDRESS.
4024
4025 2019-06-25  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-source.c (tui_set_source_content): Don't check before
4028         xfree.
4029         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4030
4031 2019-06-25  Tom Tromey  <tom@tromey.com>
4032
4033         * tui/tui-winsource.h (tui_update_source_window_as_is)
4034         (tui_alloc_source_buffer, tui_line_is_displayed)
4035         (tui_addr_is_displayed): Change type of win_info.
4036         * tui/tui-winsource.c (tui_update_source_window_as_is)
4037         (tui_clear_source_content, tui_show_source_line)
4038         (tui_show_source_content, tui_source_window_base::refill)
4039         (tui_source_window_base::set_is_exec_point_at)
4040         (tui_source_window_base::set_is_exec_point_at)
4041         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4042         (tui_alloc_source_buffer, tui_line_is_displayed)
4043         (tui_addr_is_displayed): Change type of win_info.  Update.
4044         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4045         (tui_source_window_base::do_make_visible_with_new_height):
4046         Update.
4047         * tui/tui-source.c (tui_set_source_content)
4048         (tui_set_source_content_nil)
4049         (tui_source_window::do_scroll_vertical): Update.
4050         * tui/tui-layout.c (show_layout): Update.
4051         * tui/tui-disasm.c (tui_set_disassem_content)
4052         (tui_disasm_window::do_scroll_vertical): Update.
4053         * tui/tui-data.h (tui_win_content): Remove.
4054         (struct tui_gen_win_info) <content, content_size>: Remove.
4055         (struct tui_source_element): Add initializers and destructor.
4056         (union tui_which_element, struct tui_win_element): Remove.
4057         (struct tui_source_window_base) <content>: New field.
4058         (struct tui_data_window): Remove destructor.
4059         (tui_alloc_content, tui_free_win_content)
4060         (tui_free_all_source_wins_content): Don't declare.
4061         * tui/tui-data.c (tui_initialize_static_data): Update.
4062         (init_content_element, tui_alloc_content): Remove.
4063         (~tui_gen_win_info): Update.
4064         (~tui_data_window, tui_free_all_source_wins_content)
4065         (tui_free_win_content, free_content, free_content_elements):
4066         Remove.
4067
4068 2019-06-25  Tom Tromey  <tom@tromey.com>
4069
4070         * tui/tui-winsource.h (tui_clear_source_content)
4071         (tui_erase_source_content, tui_show_source_content): Change type
4072         of win_info.
4073         * tui/tui-winsource.c (tui_clear_source_content)
4074         (tui_erase_source_content, tui_show_source_content): Change type
4075         of win_info.
4076         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4077         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4078         win_info.
4079         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4080         win_info.
4081         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4082
4083 2019-06-25  Tom Tromey  <tom@tromey.com>
4084
4085         * tui/tui-winsource.c (tui_clear_source_content)
4086         (tui_source_window_base::set_is_exec_point_at): Update.
4087         * tui/tui-source.c (tui_set_source_content_nil): Update.
4088         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4089         a bool.
4090         * tui/tui-data.c (init_content_element): Update.
4091
4092 2019-06-25  Tom Tromey  <tom@tromey.com>
4093
4094         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4095         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4096         * tui/tui-layout.c (init_and_make_win): Update.
4097         * tui/tui.h (enum tui_win_type): Update.
4098         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4099         tui_win_is_auxillary.
4100         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4101         tui_win_is_auxillary.
4102
4103 2019-06-25  Tom Tromey  <tom@tromey.com>
4104
4105         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4106         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4107         (tui_delete_data_content_windows, tui_display_all_data)
4108         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4109         Update.
4110         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4111         * tui/tui-regs.c (tui_last_regs_line_no)
4112         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4113         (tui_show_registers): Update.
4114         (tui_show_register_group): Return void.  Update.
4115         (tui_display_registers_from, tui_display_reg_element_at_line)
4116         (tui_display_registers_from_line, tui_check_register_values):
4117         Update.
4118         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4119         member.
4120         (struct tui_data_window) <regs_content>: Now a std::vector.
4121         <regs_content_count>: Remove.
4122         (tui_add_content_elements, tui_free_data_content): Don't declare.
4123         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4124         (init_content_element): Remove DATA_WIN case.  Add assert.
4125         (tui_add_content_elements): Remove.
4126         (tui_data_window): Update.
4127         (tui_free_data_content): Remove.
4128         (free_content_elements): Remove DATA_WIN case.
4129
4130 2019-06-25  Tom Tromey  <tom@tromey.com>
4131
4132         * tui/tui-data.c (tui_data_item_window): Update.
4133         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4134         * tui/tui-windata.c (tui_display_all_data)
4135         (tui_display_data_from_line): Update.
4136         (tui_check_data_values): Remove.
4137         * tui/tui-regs.c (tui_show_register_group)
4138         (tui_display_reg_element_at_line): Update.
4139         * tui/tui-hooks.c (tui_register_changed)
4140         (tui_refresh_frame_and_register_information): Call
4141         tui_check_register_values.
4142         * tui/tui-data.h (struct tui_data_window) <data_content,
4143         data_content_count, data_type>: Remove.
4144         (enum tui_data_type): Remove.
4145
4146         * tui/tui-data.c (tui_data_window::clear_detail)
4147         (~tui_data_window): Update.
4148
4149 2019-06-25  Tom Tromey  <tom@tromey.com>
4150
4151         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4152         declare.
4153         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4154         Rename from tui_first_data_item_displayed.  Update.
4155         (tui_data_window::refresh_all)
4156         (tui_data_window::do_scroll_vertical): Update.
4157         * tui/tui-data.h (struct tui_data_window)
4158         <first_data_item_displayed>: Declare new method.
4159
4160 2019-06-25  Tom Tromey  <tom@tromey.com>
4161
4162         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4163         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4164         contents...
4165         (tui_initialize_static_data): ...here.
4166
4167 2019-06-25  Tom Tromey  <tom@tromey.com>
4168
4169         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4170         (tui_display_registers_from, tui_check_register_values): Update.
4171         (tui_display_register): Remove win_info parameter; update.
4172         (tui_get_register): Change type of parameters.
4173         * tui/tui-data.h (struct tui_data_element): Remove.
4174         (union tui_which_element) <data>: Remove.
4175         <data_window>: Change type.
4176         (struct tui_data_item_window): New.
4177         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4178         case.  Add assert.
4179         (~tui_data_item_window): New destructor.
4180         (free_content_elements): Remove DATA_ITEM_WIN case.
4181
4182 2019-06-25  Tom Tromey  <tom@tromey.com>
4183
4184         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4185         Remove.
4186
4187 2019-06-25  Tom Tromey  <tom@tromey.com>
4188
4189         * tui/tui-data.h (struct tui_command_element): Remove.
4190         (union tui_which_element) <command>: Remove.
4191         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4192         assert.
4193         (free_content_elements): Remove CMD_WIN case.
4194
4195 2019-06-25  Tom Tromey  <tom@tromey.com>
4196
4197         * tui/tui-layout.c (tui_set_layout): Update.
4198         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4199         * tui/tui-data.c (layout_def): Update.
4200
4201 2019-06-25  Tom Tromey  <tom@tromey.com>
4202
4203         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4204         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4205         (tui_source_window_base::set_new_height): Update.
4206         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4207         Update.
4208         (tui_set_locator_fullname, tui_set_locator_info)
4209         (tui_show_frame_info): Update.
4210         * tui/tui-source.c (tui_set_source_content)
4211         (tui_source_is_displayed): Update.
4212         * tui/tui-layout.c (show_source_disasm_command, show_data)
4213         (show_source_or_disasm_and_command): Update.
4214         * tui/tui-disasm.c (tui_set_disassem_content)
4215         (tui_get_begin_asm_address): Update.
4216         * tui/tui-data.h (struct tui_locator_element): Remove.
4217         (union tui_which_element) <locator>: Remove.
4218         (struct tui_locator_window): New.
4219         (tui_locator_win_info_ptr): Change return type.
4220         * tui/tui-data.c (_locator): Change type.
4221         (tui_locator_win_info_ptr): Change return type.
4222         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4223         (tui_alloc_content): Add assert.
4224
4225 2019-06-25  Tom Tromey  <tom@tromey.com>
4226
4227         * tui/tui-winsource.c
4228         (tui_exec_info_window::maybe_allocate_content): New method.
4229         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4230         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4231         (make_source_or_disasm_window): Add cast.
4232         * tui/tui-data.h (union tui_which_element) <simple_string>:
4233         Remove.
4234         (struct tui_source_info): New.
4235         (struct tui_source_window_base) <execution_info>: Change type.
4236         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4237         case, and add assert.
4238         (tui_alloc_content): Add assert.
4239
4240 2019-06-25  Tom Tromey  <tom@tromey.com>
4241
4242         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4243         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4244         * tui/tui-data.c (tui_alloc_win_info): Remove.
4245
4246 2019-06-25  Tom Tromey  <tom@tromey.com>
4247
4248         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4249         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4250         can_highlight.
4251
4252 2019-06-25  Tom Tromey  <tom@tromey.com>
4253
4254         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4255         make_visible_with_new_height method.
4256         (tui_win_info::make_visible_with_new_height): New method.
4257         (tui_source_window_base::do_make_visible_with_new_height)
4258         (tui_data_window::do_make_visible_with_new_height)
4259         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4260         (make_visible_with_new_height): Remove.
4261         (tui_resize_all, tui_adjust_win_heights): Use
4262         make_visible_with_new_height method.
4263         * tui/tui-data.h (struct tui_win_info)
4264         <do_make_visible_with_new_height, make_visible_with_new_height>:
4265         New methods.
4266         (struct tui_source_window_base, struct tui_data_window)
4267         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4268         methods.
4269
4270 2019-06-25  Tom Tromey  <tom@tromey.com>
4271
4272         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4273         method.
4274         (update_tab_width): Call update_tab_width method.
4275         * tui/tui-data.h (struct tui_win_info)
4276         (struct tui_source_window_base) <update_tab_width>: New methods.
4277
4278 2019-06-25  Tom Tromey  <tom@tromey.com>
4279
4280         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4281         parameter.
4282         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4283         parameter.
4284         (tui_gen_win_info::make_visible): Update.
4285         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4286         parameter.
4287         * tui/tui-data.h (enum tui_box): New enum.
4288         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4289
4290 2019-06-25  Tom Tromey  <tom@tromey.com>
4291
4292         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4293         init_and_make_win for EXEC_INFO_WIN.
4294         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4295         longer inline.
4296         (struct tui_win_info) <~tui_win_info>: Inline.
4297         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4298         Don't declare.
4299         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4300         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4301         Remove.
4302         (tui_initialize_static_data): Update.
4303         (~tui_gen_win_info): Handle more cleanup here.
4304         (~tui_source_window_base): Delete "execution_info".
4305         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4306
4307 2019-06-25  Tom Tromey  <tom@tromey.com>
4308
4309         * tui/tui-layout.c (make_command_window): Don't set
4310         can_highlight.
4311         (show_source_disasm_command): Call the reset method.
4312         (show_data): Don't set can_highlight.  Call the reset method.
4313         (tui_gen_win_info::reset): Rename from init_gen_win_info
4314         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4315         (show_source_or_disasm_and_command): Call the reset method.
4316         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4317         (struct tui_cmd_window): Set can_highlight.
4318
4319 2019-06-25  Tom Tromey  <tom@tromey.com>
4320
4321         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4322         from make_visible.
4323         (tui_make_visible, tui_make_invisible): Rewrite.
4324         (tui_win_info::make_visible): Remove.
4325         (tui_source_window_base::make_visible): Update.
4326         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4327         method.  Moved from...
4328         (struct tui_win_info) <make_visible>: ...here.
4329
4330 2019-06-25  Tom Tromey  <tom@tromey.com>
4331
4332         * tui/tui-winsource.c
4333         (tui_source_window_base::do_scroll_horizontal): Remove direction
4334         parameter.
4335         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4336         direction parameter.
4337         * tui/tui-win.c (tui_win_info::forward_scroll)
4338         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4339         (tui_win_info::right_scroll): Update.
4340         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4341         direction parameter.
4342         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4343         direction parameter.
4344         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4345         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4346         Remove direction parameter.
4347         (struct tui_source_window_base, struct tui_source_window)
4348         (struct tui_disasm_window, struct tui_data_window)
4349         (struct tui_cmd_window): Update.
4350
4351 2019-06-25  Tom Tromey  <tom@tromey.com>
4352
4353         * tui/tui-winsource.h (tui_set_exec_info_content)
4354         (tui_show_exec_info_content, tui_erase_exec_info_content)
4355         (tui_clear_exec_info_content, tui_update_exec_info): Change
4356         argument to tui_source_window_base.
4357         * tui/tui-winsource.c (tui_set_exec_info_content)
4358         (tui_show_exec_info_content, tui_erase_exec_info_content)
4359         (tui_clear_exec_info_content, tui_update_exec_info): Change
4360         argument to tui_source_window_base.
4361
4362 2019-06-25  Tom Tromey  <tom@tromey.com>
4363
4364         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4365         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4366
4367 2019-06-25  Tom Tromey  <tom@tromey.com>
4368
4369         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4370         check.
4371
4372 2019-06-25  Tom Tromey  <tom@tromey.com>
4373
4374         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4375         type to void.
4376         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4377         type to void.
4378         * tui/tui-source.c (tui_set_source_content): Update.
4379         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4380
4381 2019-06-25  Tom Tromey  <tom@tromey.com>
4382
4383         * tui/tui-win.c (window_name_completer, tui_set_focus)
4384         (tui_all_windows_info): Use name method.
4385         * tui/tui-data.h (struct tui_gen_win_info)
4386         (struct tui_source_window, struct tui_disasm_window)
4387         (struct tui_data_window, struct tui_cmd_window) <name>: New
4388         method.
4389         (tui_win_name): Don't declare.
4390         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4391         (tui_win_name): Remove.
4392
4393 2019-06-25  Tom Tromey  <tom@tromey.com>
4394
4395         * tui/tui-winsource.h (tui_update_source_window)
4396         (tui_update_source_window_as_is): Change parameter type.
4397         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4398         to be a tui_source_window_base.
4399         (tui_update_source_window_as_is): Likewise.
4400         * tui/tui-win.c (make_visible_with_new_height): Update.
4401
4402 2019-06-25  Tom Tromey  <tom@tromey.com>
4403
4404         * tui/tui-winsource.c (tui_erase_source_content)
4405         (tui_show_source_content, tui_show_exec_info_content)
4406         (tui_erase_exec_info_content): Use refresh_window method.
4407         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4408         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4409         from tui_refresh_win.
4410         (tui_data_window::refresh_window): New method.
4411         (tui_win_info::refresh, tui_source_window_base::refresh)
4412         (tui_refresh_all): Use refresh_window method.
4413         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4414         method.
4415         * tui/tui-regs.c (tui_display_register): Call refresh_window
4416         method.
4417         * tui/tui-layout.c (show_source_disasm_command)
4418         (show_source_or_disasm_and_command): Call refresh_window method.
4419         * tui/tui-data.h (struct tui_gen_win_info)
4420         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4421         New method.
4422
4423 2019-06-25  Tom Tromey  <tom@tromey.com>
4424
4425         * tui/tui.c (tui_rl_other_window, tui_enable)
4426         (tui_is_window_visible, tui_get_command_dimension): Update.
4427         * tui/tui-winsource.c (tui_update_source_window_as_is)
4428         (tui_clear_source_content, tui_erase_source_content)
4429         (tui_show_source_line, tui_source_window_base::refill)
4430         (tui_source_window_base::do_scroll_horizontal)
4431         (tui_source_window_base::set_is_exec_point_at)
4432         (tui_update_breakpoint_info, tui_set_exec_info_content)
4433         (tui_alloc_source_buffer, tui_line_is_displayed)
4434         (tui_addr_is_displayed): Update.
4435         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4436         (tui_check_and_display_highlight_if_needed)
4437         (tui_win_info::make_visible, tui_win_info::refresh)
4438         (tui_refresh_all): Update.
4439         * tui/tui-windata.c (tui_first_data_item_displayed)
4440         (tui_delete_data_content_windows, tui_erase_data_content)
4441         (tui_display_all_data, tui_data_window::refresh_all)
4442         (tui_check_data_values): Update.
4443         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4444         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4445         (tui_win_info::backward_scroll, tui_refresh_all_win)
4446         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4447         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4448         (tui_source_window_base::set_new_height)
4449         (tui_data_window::set_new_height)
4450         (make_invisible_and_set_new_height)
4451         (make_visible_with_new_height, new_height_ok)
4452         (parse_scrolling_args): Update.
4453         * tui/tui-stack.c (tui_show_frame_info): Update.
4454         * tui/tui-source.c (tui_set_source_content)
4455         (tui_set_source_content_nil, tui_source_is_displayed)
4456         (tui_source_window::do_scroll_vertical): Update.
4457         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4458         (tui_display_registers_from, tui_display_reg_element_at_line)
4459         (tui_check_register_values, tui_reg_command): Update.
4460         * tui/tui-layout.c (tui_default_win_height)
4461         (show_source_disasm_command, show_data, init_and_make_win)
4462         (show_source_or_disasm_and_command): Update.
4463         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4464         (tui_redisplay_readline, tui_mld_flush)
4465         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4466         (tui_getc): Update.
4467         * tui/tui-disasm.c (tui_set_disassem_content)
4468         (tui_disasm_window::do_scroll_vertical): Update.
4469         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4470         Now virtual.
4471         (struct tui_win_info): Derive from tui_gen_win_info.
4472         <~tui_win_info>: Mark as override.
4473         <generic>: Remove member.
4474         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4475         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4476         (~tui_data_window, ~tui_win_info)
4477         (tui_free_all_source_wins_content): Update.
4478         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4479
4480 2019-06-25  Tom Tromey  <tom@tromey.com>
4481
4482         * tui/tui-layout.c (init_and_make_win): Use new.
4483         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4484         destructor, initializers.
4485         (tui_alloc_generic_win_info): Don't declare.
4486         * tui/tui-data.c (_locator): Add argument to constructor.
4487         (source_win, disasm_win): New globals.
4488         (exec_info): Remove.
4489         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4490         Update.
4491         (tui_alloc_generic_win_info): Remove.
4492         (init_content_element): Use new.
4493         (tui_win_info::tui_win_info): Update.
4494         (free_content_elements) <case DATA_WIN>: Use delete.
4495
4496 2019-06-25  Tom Tromey  <tom@tromey.com>
4497
4498         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4499         * tui/tui-windata.c (tui_first_data_item_displayed)
4500         (tui_delete_data_content_windows): Update.
4501         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4502         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4503         (tui_display_registers_from, tui_check_register_values): Update.
4504         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4505         pointer.
4506         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4507         window.
4508         (tui_free_data_content): Update.
4509         (free_content_elements) <case DATA_WIN>: Free the window.
4510
4511 2019-06-25  Tom Tromey  <tom@tromey.com>
4512
4513         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4514         Update.
4515         * tui/tui-layout.c (make_command_window)
4516         (show_source_disasm_command, show_data, init_and_make_win)
4517         (show_source_or_disasm_and_command): Update.
4518         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4519         method.
4520         <can_highight, is_highlighted>: Now bool.
4521         (tui_set_win_highlight): Don't declare.
4522         * tui/tui-data.c (tui_set_win_highlight): Remove.
4523
4524 2019-06-25  Tom Tromey  <tom@tromey.com>
4525
4526         * tui/tui-wingeneral.c (make_visible): Remove check of window
4527         type.
4528
4529 2019-06-25  Tom Tromey  <tom@tromey.com>
4530
4531         * tui/tui-win.c (tui_win_info::max_height)
4532         (tui_cmd_window::max_height): New methods.
4533         (new_height_ok): Call max_height.
4534         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4535         <max_height>: New method.
4536
4537 2019-06-25  Tom Tromey  <tom@tromey.com>
4538
4539         * tui/tui-win.c (tui_source_window_base::set_new_height)
4540         (tui_data_window::set_new_height): New methods.
4541         (make_invisible_and_set_new_height): Call set_new_height method.
4542         * tui/tui-data.h (struct tui_win_info)
4543         (struct tui_source_window_base, struct tui_data_window)
4544         <set_new_height>: New method.
4545
4546 2019-06-25  Tom Tromey  <tom@tromey.com>
4547
4548         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4549         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4550         tui_refresh_data_win.
4551         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4552         method.
4553         (tui_refresh_all_win): Call the refresh_all method.
4554         (tui_set_focus): Likewise.
4555         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4556         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4557         Likewise.
4558
4559 2019-06-25  Tom Tromey  <tom@tromey.com>
4560
4561         * tui/tui-winsource.h (tui_refill_source_window)
4562         (tui_set_is_exec_point_at): Don't declare.
4563         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4564         (tui_source_window_base::refill): Rename from
4565         tui_refill_source_window.
4566         (tui_source_window_base::do_scroll_horizontal): Update.
4567         (tui_source_window_base::set_is_exec_point_at): Rename from
4568         tui_set_is_exec_point_at.
4569         (tui_update_all_breakpoint_info): Update.
4570         * tui/tui-stack.c (tui_show_frame_info): Update.
4571         * tui/tui-layout.c (show_data): Add cast.
4572         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4573         * tui/tui-data.h (struct tui_source_window_base) <refill,
4574         set_is_exec_point_at>: New methods.
4575         (tui_source_windows, tui_add_to_source_windows): Update types.
4576         (tui_add_to_source_windows): Remove redundant declaration.
4577         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4578         (tui_source_windows): Change return type.
4579         (tui_clear_source_windows_detail): Update.
4580         (tui_add_to_source_windows): Change type of parameter.
4581         (tui_free_all_source_wins_content): Update.
4582
4583 2019-06-25  Tom Tromey  <tom@tromey.com>
4584
4585         * tui/tui-wingeneral.c (tui_win_info::refresh)
4586         (tui_source_window_base::refresh): New methods.
4587         (tui_refresh_all): Call the refresh method.
4588         * tui/tui-data.h (struct tui_win_info)
4589         (struct tui_source_window_base) <refresh>: New method.
4590
4591 2019-06-25  Tom Tromey  <tom@tromey.com>
4592
4593         * tui/tui.h (tui_is_window_visible): Return bool.
4594         * tui/tui.c (tui_is_window_visible): Return bool.
4595         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4596         (tui_make_visible, tui_make_invisible)
4597         (tui_win_info::make_visible)
4598         (tui_source_window_base::make_visible, make_all_visible)
4599         (tui_make_all_visible, tui_make_all_invisible): Update.
4600         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4601         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4602         bool.
4603         (struct tui_win_info, struct tui_source_window_base)
4604         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4605         * tui/tui-data.c (tui_init_generic_part): Update.
4606
4607 2019-06-25  Tom Tromey  <tom@tromey.com>
4608
4609         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4610         (tui_source_window_base::make_visible): New methods.
4611         (make_all_visible): Make method call.
4612         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4613         (struct tui_source_window_base, struct tui_cmd_window): Override
4614         make_visible.
4615         (tui_win_is_source_type): Don't declare.
4616         * tui/tui-data.c (tui_win_is_source_type): Remove.
4617
4618 2019-06-25  Tom Tromey  <tom@tromey.com>
4619
4620         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4621         NULL check.
4622
4623 2019-06-25  Tom Tromey  <tom@tromey.com>
4624
4625         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4626         Inline constructor.  Add initializers for members.
4627         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4628         constructors; now inline in class.
4629
4630 2019-06-25  Tom Tromey  <tom@tromey.com>
4631
4632         * tui/tui-regs.c (tui_show_registers): Update.
4633         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4634         bool.
4635         * tui/tui-data.c (tui_data_window::clear_detail)
4636         (tui_data_window): Update.
4637
4638 2019-06-25  Tom Tromey  <tom@tromey.com>
4639
4640         * tui/tui-windata.c (tui_display_all_data)
4641         (tui_display_data_from_line, tui_display_data_from)
4642         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4643         Update.
4644         * tui/tui-regs.c (tui_last_regs_line_no)
4645         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4646         (tui_show_registers, tui_show_register_group)
4647         (tui_display_registers_from, tui_display_reg_element_at_line)
4648         (tui_display_registers_from_line, tui_check_register_values)
4649         (tui_reg_next, tui_reg_prev): Update.
4650         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4651         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4652         tui_data_window.
4653         (struct tui_win_info) <detail>: Remove.  Add new fields from
4654         tui_data_info.
4655         (TUI_DATA_WIN): Add cast.
4656         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4657         (~tui_data_window): Simplify.
4658
4659 2019-06-25  Tom Tromey  <tom@tromey.com>
4660
4661         * tui/tui-layout.c (show_source_disasm_command)
4662         (show_source_or_disasm_and_command): Update.
4663         * tui/tui-io.c (update_cmdwin_start_line)
4664         (tui_redisplay_readline): Update.
4665         * tui/tui-data.h (struct tui_command_info): Remove.
4666         (struct tui_win_info) <detail>: Remove command_info member.
4667         (struct tui_data_window) <start_line>: New member, from
4668         tui_command_info.
4669         (TUI_CMD_WIN): Add casts.
4670
4671 2019-06-25  Tom Tromey  <tom@tromey.com>
4672
4673         * tui/tui-winsource.c (tui_update_source_window)
4674         (tui_refill_source_window)
4675         (tui_source_window_base::do_scroll_horizontal)
4676         (tui_update_breakpoint_info, tui_set_exec_info_content)
4677         (tui_show_exec_info_content, tui_erase_exec_info_content)
4678         (tui_clear_exec_info_content): Update.
4679         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4680         Update.
4681         * tui/tui-win.c (make_invisible_and_set_new_height)
4682         (make_visible_with_new_height): Update.
4683         * tui/tui-source.c (tui_set_source_content)
4684         (tui_show_symtab_source): Update.
4685         * tui/tui-layout.c (extract_display_start_addr)
4686         (show_source_disasm_command, show_data)
4687         (make_source_or_disasm_window)
4688         (show_source_or_disasm_and_command): Update.
4689         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4690         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4691         "gdbarch".
4692         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4693         to tui_source_window_base.
4694         (struct tui_win_info) <detail>: Remove source_info member.
4695         (struct tui_source_window_base) <has_locator>: Inline.
4696         Move contents from tui_source_info; rename has_locator member to
4697         m_has_locator.
4698         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4699         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4700         header file.
4701         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4702         Simplify.
4703         (tui_free_all_source_wins_content): Cast to
4704         tui_source_window_base.
4705
4706 2019-06-25  Tom Tromey  <tom@tromey.com>
4707
4708         * tui/tui-win.c (make_invisible_and_set_new_height)
4709         (make_visible_with_new_height): Call has_locator method.
4710         * tui/tui-layout.c (show_source_disasm_command, show_data)
4711         (show_source_or_disasm_and_command): Update for bool change.
4712         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4713         (tui_win_info) <has_locator>: New method.
4714         (struct tui_source_window_base) <has_locator>: New method.
4715         (tui_win_has_locator): Don't declare.
4716         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4717         from tui_win_has_locator.
4718         (tui_source_window_base): Use false, not FALSE.
4719
4720 2019-06-25  Tom Tromey  <tom@tromey.com>
4721
4722         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4723         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4724         clear_detail method directly.
4725         (tui_clear_win_detail): Remove.
4726
4727 2019-06-25  Tom Tromey  <tom@tromey.com>
4728
4729         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4730         "this", not TUI_DISASM_WIN.
4731
4732 2019-06-25  Tom Tromey  <tom@tromey.com>
4733
4734         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4735         declare.
4736         * tui/tui-winsource.c
4737         (tui_source_window_base::do_scroll_horizontal): Rename from
4738         tui_horizontal_source_scroll.
4739         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4740         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4741         from tui_vertical_data_scroll.
4742         * tui/tui-win.h (tui_scroll): Don't declare.
4743         * tui/tui-win.c (tui_win_info::forward_scroll)
4744         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4745         (tui_win_info::right_scroll): Rename and update.
4746         (tui_scroll_forward_command, tui_scroll_backward_command)
4747         (tui_scroll_left_command, tui_scroll_right_command): Update.
4748         (tui_scroll): Remove.
4749         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4750         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4751         from tui_vertical_source_scroll.
4752         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4753         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4754         from tui_vertical_disassem_scroll.
4755         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4756         do_scroll_horizontal>: New methods.
4757         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4758         Likewise.
4759         (struct tui_source_window_base): Add do_scroll_horizontal.
4760         (struct tui_source_window, struct tui_disasm_window): Add
4761         do_scroll_vertical.
4762         (struct tui_data_window, struct tui_cmd_window): Add
4763         do_scroll_horizontal and do_scroll_vertical.
4764         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4765
4766 2019-06-25  Tom Tromey  <tom@tromey.com>
4767
4768         * tui/tui-data.h (struct tui_source_window_base): New struct.
4769         (struct tui_source_window): Derive from tui_source_window_base.
4770         (struct tui_disasm_window): New struct.
4771         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4772         from tui_source_window::clear_detail.
4773         (tui_source_window_base): Rename from tui_source_window.
4774         (~tui_source_window_base): Rename from ~tui_source_window.
4775         (tui_alloc_win_info): Create a tui_disasm_window.
4776
4777 2019-06-25  Tom Tromey  <tom@tromey.com>
4778
4779         * tui/tui-data.h (struct tui_source_window)
4780         (struct tui_data_window): Declare destructors.
4781         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4782         destructors.
4783         (tui_win_info): Simplify.
4784
4785 2019-06-25  Tom Tromey  <tom@tromey.com>
4786
4787         * tui/tui-winsource.c (tui_display_main)
4788         (tui_update_source_windows_with_addr)
4789         (tui_update_all_breakpoint_info): Update.
4790         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4791         (new_height_ok, parse_scrolling_args): Update.
4792         * tui/tui-stack.c (tui_show_frame_info): Update.
4793         * tui/tui-data.h (struct tui_list): Remove.
4794         (tui_source_windows): Return a reference to a std::vector.
4795         * tui/tui-data.c (source_windows): Now a std::vector.
4796         (tui_source_windows): Change return type.
4797         (tui_clear_source_windows): Rewrite.
4798         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4799         (tui_free_all_source_wins_content): Rewrite.
4800
4801 2019-06-25  Tom Tromey  <tom@tromey.com>
4802
4803         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4804         (struct tui_data_window, struct tui_cmd_window): Declare
4805         clear_detail method.
4806         * tui/tui-data.c (tui_source_window::clear_detail)
4807         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4808         methods.
4809         (tui_clear_win_detail): Simplify.
4810
4811 2019-06-25  Tom Tromey  <tom@tromey.com>
4812
4813         * tui/tui-layout.c (make_source_window, make_disasm_window)
4814         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4815         Return the new window.
4816         (show_source_disasm_command, show_data)
4817         (show_source_or_disasm_and_command): Update.
4818
4819 2019-06-25  Tom Tromey  <tom@tromey.com>
4820
4821         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4822         parameter.  Return the new window.
4823         (show_source_disasm_command): Update and remove NULL check.
4824         (show_source_or_disasm_and_command): Update.
4825
4826 2019-06-25  Tom Tromey  <tom@tromey.com>
4827
4828         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4829
4830 2019-06-25  Tom Tromey  <tom@tromey.com>
4831
4832         * tui/tui-data.h (struct tui_win_info): Make constructor
4833         protected.  Make destructor virtual.  Add initializers.
4834         (tui_source_window, tui_data_window, tui_cmd_window): New
4835         classes.
4836         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4837         constructor.  Add "type" parameter.
4838         (tui_source_window, tui_data_window, tui_cmd_window): New
4839         constructors.
4840         (tui_alloc_win_info): Instantiate the appropriate subclass.
4841
4842 2019-06-25  Tom Tromey  <tom@tromey.com>
4843
4844         * tui/tui-win.c (tui_resize_all): Use delete.
4845         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4846         destructor.
4847         (tui_free_window): Don't declare.
4848         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4849         Update.
4850
4851 2019-06-25  Tom Tromey  <tom@tromey.com>
4852
4853         * tui/tui-data.h (struct tui_win_info): Add constructor.
4854         * tui/tui-data.c (tui_alloc_win_info): Use new.
4855         (tui_free_window): Use delete.
4856
4857 2019-06-22  Tom Tromey  <tom@tromey.com>
4858
4859         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4860         declare.
4861         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4862
4863 2019-06-22  Tom Tromey  <tom@tromey.com>
4864
4865         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4866         declare.
4867         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4868
4869 2019-06-22  Tom de Vries  <tdevries@suse.de>
4870
4871         * dwarf2read.c (create_addrmap_from_aranges)
4872         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4873         instead of '%zu'.
4874
4875 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4876
4877         * dwarf2read.h (dwarf2_section_info_def): Remove.
4878         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4879         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4880         std::vector<dwarf2_section_info>.
4881         (struct dwo_file) <~dwo_file>: Remove.
4882         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4883         types field.
4884         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4885         (dwarf2_read_debug_names): Likewise.
4886         (create_debug_types_hash_table): Change parameter type to
4887         array_view, adjust code accordingly.
4888         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4889         (partial_die_info::fixup): Likewise.
4890         (determine_prefix): Likewise.
4891         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4892
4893 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4894
4895         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4896         gdb_bfd_ref_ptr.
4897         <~dwo_file>: Remove call to gdb_bfd_unref.
4898         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4899         gdb_bfd_ref_ptr::get.
4900
4901 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4902
4903         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4904         type to htab_up.
4905         * dwarf2read.c (struct dwo_file): Initialize fields.
4906         <~dwo_file>: New.
4907         (free_dwo_file): Remove, move content to ~dwo_file.
4908         (struct dwo_file_deleter): Remove.
4909         (dwo_file_up>: Remove custom deleter.
4910         (free_dwo_files): Remove.
4911         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4912         dwo_files.
4913         (process_skeletonless_type_units): Call unique_ptr::get.
4914         (allocate_dwo_file_hash_table): Add deleter to created hash
4915         table.  Change return type to htab_up.
4916         (lookup_dwo_file_slot): Don't memset dwo_file, call
4917         unique_ptr::get.
4918         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4919         (create_dwo_unit_in_dwp_v2): Likewise.
4920         (open_and_init_dwo_file): Likewise.
4921         (free_dwo_file_from_slot): Remove.
4922
4923 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4924
4925         * dwarf2read.h (struct dwarf2_section_info) <readin,
4926         is_virtual>: Change type to bool.
4927         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4928         true instead of 1.
4929
4930 2019-06-19  Tom Tromey  <tom@tromey.com>
4931
4932         * tui/tui-data.h (tui_init_content_element): Don't declare.
4933
4934 2019-06-19  Tom Tromey  <tom@tromey.com>
4935
4936         * tui/tui-data.h (tui_init_win_info): Don't declare.
4937
4938 2019-06-19  Tom de Vries  <tdevries@suse.de>
4939
4940         * dwarf2read.h (abstract_to_concrete): Change type to
4941         std::unordered_map<sect_offset, std::vector<sect_offset>,
4942         gdb::hash_enum<sect_offset>>.
4943
4944 2019-06-19  Tom Tromey  <tromey@adacore.com>
4945
4946         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4947         EVAL_AVOID_SIDE_EFFECTS specially.
4948
4949 2019-06-19  Tom Tromey  <tromey@adacore.com>
4950
4951         * source-cache.c (highlighter): New global.
4952         (source_cache::get_source_lines): Create a highlighter on demand.
4953
4954 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4955
4956         * defs.h (deprecated_interactive_hook): Delete declaration.
4957         * interps.c (clear_interpreter_hooks): Remove use of
4958         deprecated_interactive_hook.
4959         * top.c (deprecated_interactive_hook): Delete definition.
4960         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4961
4962 2019-06-18  Tom de Vries  <tdevries@suse.de>
4963
4964         PR gdb/24515
4965         * dwarf2read.h (abstract_to_concrete): Change type from
4966         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4967         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4968         * dwarf2read.c (read_variable): Update.
4969         (dwarf2_fetch_die_loc_sect_off): Update.
4970
4971 2019-06-17  Tom de Vries  <tdevries@suse.de>
4972
4973         PR gdb/24617
4974         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4975         accessing parent[parent_len - 1].
4976
4977 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4978
4979         PR gdb/24364
4980         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4981         call dtrace_process_dof with NULL dof.
4982
4983 2019-06-16  Tom de Vries  <tdevries@suse.de>
4984
4985         PR gdb/24445
4986         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4987
4988 2019-06-16  Tom Tromey  <tom@tromey.com>
4989
4990         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4991         (make_all_visible): Use address of member.
4992
4993 2019-06-16  Tom Tromey  <tom@tromey.com>
4994
4995         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4996         (tui_free_window, free_content, free_content_elements): Remove
4997         unnecessary cast.
4998         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4999         cast.
5000         * tui/tui-regs.c (tui_show_register_group)
5001         (tui_display_registers_from, tui_display_reg_element_at_line):
5002         Remove unnecessary cast.
5003
5004 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5005
5006         * linux-nat.c (normal_mask): Delete.
5007         (_initialize_linux_nat): Don't initialise normal_mask.
5008
5009 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5010
5011         PR gdb/24445
5012         * dwarf-index-write.h (write_psymtabs_to_index): Add
5013         dwz_basename parameter.
5014         * dwarf-index-write.c (write_gdbindex): Move file writing to
5015         write_gdbindex_1.  Change return type void.
5016         (assert_file_size): Move up, remove filename parameter.
5017         (write_gdbindex_1): New function.
5018         (write_debug_names): Change return type to void, call
5019         assert_file_size.
5020         (struct index_wip_file): New struct.
5021         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5022         file logic to index_wip_file.  Write index for dwz file if
5023         needed.
5024         (save_gdb_index_command): Pass basename of dwz file, if present.
5025         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5026         build-id of dwz file, if present.
5027         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5028         (dwarf2_get_dwz_file): Likewise.
5029         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5030         (dwarf2_get_dwz_file): Likewise.
5031
5032 2019-06-16  Tom Tromey  <tom@tromey.com>
5033
5034         * coffread.c (process_coff_symbol): Use xstrdup.
5035         * value.c (create_internalvar): Use xstrdup.
5036
5037 2019-06-16  Tom Tromey  <tom@tromey.com>
5038
5039         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5040         * breakpoint.c (stopin_command, stopat_command)
5041         (until_break_command, decode_location_default): Remove unnecessary
5042         cast.
5043         * utils.c (subset_compare): Remove unnecessary cast.
5044         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5045         cast.
5046         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5047         cast.
5048         * infcmd.c (path_command): Remove unnecessary cast.
5049         * coffread.c (decode_type): Remove unnecessary cast.
5050         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5051         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5052         * tui/tui-stack.c (tui_show_locator_content)
5053         (tui_show_frame_info): Remove unnecessary cast.
5054         * tui/tui-win.c (tui_scroll_forward_command)
5055         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5056         (parse_scrolling_args): Remove unnecessary cast.
5057         * tui/tui-data.c (init_win_info, tui_del_window)
5058         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5059         (free_content_elements): Remove unnecessary cast.
5060         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5061         unnecessary cast.
5062         * tui/tui-source.c (tui_set_source_content)
5063         (tui_vertical_source_scroll): Remove unnecessary cast.
5064         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5065         cast.
5066         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5067         * tui/tui-regs.c (tui_display_registers_from)
5068         (tui_display_register): Remove unnecessary cast.
5069         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5070         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5071         (make_visible): Remove unnecessary cast.
5072         * tui/tui-winsource.c (tui_erase_source_content)
5073         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5074         unnecessary cast.
5075         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5076         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5077         * stabsread.c (read_type, read_array_type, read_range_type):
5078         Remove unnecessary cast.
5079         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5080         (parse_symbol, parse_type, upgrade_type, parse_external)
5081         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5082         unnecessary cast.
5083         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5084
5085 2019-06-16  Tom Tromey  <tom@tromey.com>
5086
5087         * tui/tui-data.c (tui_alloc_generic_win_info)
5088         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5089         checks.
5090
5091 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5092             Andrew Burgess  <andrew.burgess@embecosm.com>
5093
5094         * f-typeprint.c (f_print_type): Don't return early for not
5095         associated or not allocated types.
5096         (f_type_print_varspec_suffix): Add print_rank parameter and print
5097         ranks of array types in case they dangling.
5098         (f_type_print_base): Add print_rank parameter.
5099
5100 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5101
5102         * NEWS: Mention new MI commands.
5103         * break-catch-throw.c (enum exception_event_kind): Move to
5104         breakpoint.h.
5105         (print_mention_exception_catchpoint): Output text as a single
5106         message.
5107         (catch_exception_command_1): Rename to...
5108         (catch_exception_event): ...this, make non-static, update header
5109         command, and change some parameter types.
5110         (catch_catch_command): Update for changes to
5111         catch_exception_command_1.
5112         (catch_throw_command): Likewise.
5113         (catch_rethrow_command): Likewise.
5114         * breakpoint.c (enum exception_event_kind): Delete.
5115         * breakpoint.h (enum exception_event_kind): Moved here from
5116         break-catch-throw.c.
5117         (catch_exception_event): Declare.
5118         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5119         (mi_cmd_catch_throw): New function.
5120         (mi_cmd_catch_rethrow): New function.
5121         (mi_cmd_catch_catch): New function.
5122         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5123         'catch-catch' entries.
5124         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5125         (mi_cmd_catch_rethrow): Declare.
5126         (mi_cmd_catch_catch): Declare.
5127
5128 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5129
5130         * annotate.c (annotate_source_line): Change return type to void,
5131         update implementation to match.
5132         * annotate.h (annotate_source_line): Change return type to void,
5133         update header comment.
5134         * stack.c (print_frame_info): Don't change what frame information
5135         is printed based on whether annotations are on or not.
5136
5137 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5138
5139         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5140         (annotate_source): Make static.
5141         (annotate_source_line): Moved from source.c and renamed from
5142         identify_source_line.  Update the return type.
5143         * annotate.h (annotate_source): Delete declaration.
5144         (annotate_source_line): Declaration moved from source.h, and
5145         renamed from identify_source_line.  Return type updated.
5146         * source.c (identify_source_line): Moved to annotate.c and renamed
5147         to annotate_source_line.
5148         (info_line_command): Remove check of annotation_level.
5149         * source.h (identify_source_line): Move declaration to annotate.h
5150         and rename to annotate_source_line.
5151         * stack.c: Add 'annotate.h' include.
5152         (print_frame_info): Remove check of annotation_level before
5153         calling annotate_source_line.
5154
5155 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5156
5157         * source-cache.c (source_cache::get_plain_source_lines): Use
5158         open_source_file_with_line_charpos instead of just
5159         open_source_file, remove call to find_source_lines.
5160         (source_cache::get_source_lines): Likewise.
5161         * source.c (find_source_lines): Make static.
5162         (get_filename_and_charpos): Renamed into...
5163         (open_source_file_with_line_charpos): ..this along with changes to
5164         return a scoped_fd, and some other minor clean ups.
5165         (identify_source_line): Use open_source_file_with_line_charpos.
5166         (search_command_helper): Use open_source_file_with_line_charpos
5167         instead of just open_source_file, remove call to
5168         find_source_lines.
5169         * source.h (open_source_file_with_line_charpos): Declare new
5170         function.
5171         (find_source_lines): Delete declaration.
5172
5173 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5174
5175         * source.c (get_filename_and_charpos): Remove fullname
5176         parameter.
5177         (identify_source_line): Update call to get_filename_and_charpos.
5178
5179 2019-06-14  Tom Tromey  <tromey@adacore.com>
5180
5181         PR gdb/24502:
5182         * ui-style.h (skip_ansi_escape): Update comment.
5183         * ui-file.h (class no_terminal_escape_file): New class.
5184         * ui-file.c (no_terminal_escape_file::write)
5185         (no_terminal_escape_file::puts): New methods.
5186         * cli/cli-logging.c (handle_redirections): Use
5187         no_terminal_escape_file.
5188
5189 2019-06-14  Tom Tromey  <tromey@adacore.com>
5190
5191         * NEWS: Move convenience variable news above Python news.
5192
5193 2019-06-14  Tom Tromey  <tom@tromey.com>
5194
5195         * gnulib: Move directory to top-level.
5196         * configure.ac: Don't configure gnulib.
5197         * configure: Rebuild.
5198         * common/common-defs.h: Use new path to gnulib.
5199         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5200         (GNULIB_H): Remove.
5201         (INCGNU): Look in new gnulib location.
5202         (HFILES_NO_SRCDIR): Remove gnulib files.
5203         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5204         (generated_files): Remove GNULIB_H.
5205         ($(LIBGNU), all-lib): Remove targets.
5206         (distclean): Don't mention GNULIB_BUILDDIR.
5207         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5208
5209 2019-06-14  Tom Tromey  <tromey@adacore.com>
5210
5211         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5212         Warn if symbol file does not provide any symbols.
5213
5214 2019-06-14  Tom Tromey  <tromey@adacore.com>
5215
5216         * source.c (find_and_open_source): Respect basenames_may_differ.
5217
5218 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5219
5220         * annotate.c (annotate_breakpoints_invalid): Make use of
5221         scoped_restore_terminal_state.
5222         (annotate_frames_invalid): Likewise.
5223
5224 2019-06-14  Tom Tromey  <tromey@adacore.com>
5225
5226         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5227         allow assignment to an internalvar.
5228
5229 2019-06-14  Tom Tromey  <tromey@adacore.com>
5230
5231         * ada-lex.l: Allow "_" in attribute names.
5232
5233 2019-06-14  Tom Tromey  <tromey@adacore.com>
5234
5235         PR gdb/24653:
5236         * regcache.c (registers_changed): Don't call alloca.
5237         * top.c (execute_command): Don't call alloca.
5238
5239 2019-06-13  Pedro Alves  <palves@redhat.com>
5240
5241         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5242         'expression'.  When parsing an expression, error out if there's
5243         junk after "unlimited".
5244         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5245         (do_set_command): Adjust calls to is_unlimited_literal.
5246
5247 2019-06-13  Pedro Alves  <palves@redhat.com>
5248
5249         * compile/compile.c (make_compile_options_def_group): Add braces
5250         around array_view initializer.
5251         * thread.c (make_thread_apply_all_options_def_group)
5252         (make_thread_apply_all_options_def_group): Likewise.
5253
5254 2019-06-13  Pedro Alves  <palves@redhat.com>
5255
5256         * NEWS (New commands): Mention "maint test-options
5257         require-delimiter", "maint test-options unknown-is-error", "maint
5258         test-options unknown-is-operand" and "maint show
5259         test-options-completion-result".
5260         (New command options, command completion): New section.
5261         (Completion improvements): New section.
5262         Mention that you can abbreviate "unlimited".
5263
5264 2019-06-13  Pedro Alves  <palves@redhat.com>
5265
5266         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5267         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5268         * unittests/cli-utils-selftests.c (test_parse_flags)
5269         (test_parse_flags_qcs): Delete.
5270         (test_cli_utils): Don't call deleted functions.
5271
5272 2019-06-13  Pedro Alves  <palves@redhat.com>
5273
5274         * thread.c: Include "cli/cli-option.h".
5275         (tp_array_compar_ascending): Global.
5276         (tp_array_compar): Delete function.
5277         (tp_array_compar_ascending, tp_array_compar_descending): New
5278         functions.
5279         (ascending_option_def, qcs_flag_option_def)
5280         (thr_qcs_flags_option_defs)
5281         (make_thread_apply_all_options_def_group)
5282         (make_thread_apply_options_def_group): New.
5283         (thread_apply_all_command): Use gdb::option::process_options.
5284         (thread_apply_command_completer)
5285         (thread_apply_all_command_completer): New.
5286         (thread_apply_command): Use gdb::option::process_options.
5287         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5288         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5289         to generate help text of "thread apply".  Adjust "taas"'s help.
5290         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5291         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5292
5293 2019-06-13  Pedro Alves  <palves@redhat.com>
5294
5295         * thread.c (thread_apply_command): Check for invalid TID with
5296         isdigit instead of !isalpha.
5297
5298 2019-06-13  Pedro Alves  <palves@redhat.com>
5299
5300         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5301         (validate_flags_qcs): New.
5302         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5303         (validate_flags_qcs): Declare.
5304         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5305         (make_frame_apply_options_def_group): New.
5306         (frame_apply_command_count): Process options with
5307         gdb::option::process_options.
5308         (frame_apply_completer): New.
5309         (frame_apply_level_completer, frame_apply_all_completer)
5310         (frame_apply_completer): New.
5311         (_initialize_stack): Update help of "frame apply", "frame apply
5312         level", "frame apply all" and "faas" to mention supported options
5313         and install command completers.
5314         * stack.h (frame_apply_all_completer): Declare.
5315         * thread.c: Include "stack.h".
5316         (tfaas_command): Add "--".
5317         (_initialize_thread): Update help "tfaas" to mention supported
5318         options and install command completer.
5319
5320 2019-06-13  Pedro Alves  <palves@redhat.com>
5321
5322         * completer.c (complete_nested_command_line): New.
5323         (gdb_completion_word_break_characters_throw): Add assertion.
5324         * completer.h (complete_nested_command_line): Declare.
5325
5326 2019-06-13  Pedro Alves  <palves@redhat.com>
5327
5328         * stack.c (parse_backtrace_qualifiers): New.
5329         (backtrace_command): Use it.
5330         (backtrace_command_completer): Complete on qualifiers.
5331
5332 2019-06-13  Pedro Alves  <palves@redhat.com>
5333
5334         * frame.c: Include "cli/cli-option.h.
5335         (user_set_backtrace_options): New.
5336         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5337         Delete.
5338         (get_prev_frame): Adjust.
5339         (boolean_option_def, uinteger_option_def)
5340         (set_backtrace_option_defs): New.
5341         (_initialize_frame): Adjust and use
5342         gdb::option::add_setshow_cmds_for_options to install "set
5343         backtrace past-main" and "set backtrace past-entry".
5344         * frame.h: Include "cli/cli-option.h".
5345         (struct frame_print_options): Forward declare.
5346         (print_frame_arguments_all, print_frame_arguments_scalars)
5347         (print_frame_arguments_none): Declare.
5348         (print_entry_values): Delete declaration.
5349         (struct frame_print_options, user_frame_print_options): New.
5350         (struct set_backtrace_options): New.
5351         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5352         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5353         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5354         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5355         (list_args_or_locals): Add frame_print_options parameter.
5356         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5357         * python/py-framefilter.c (enumerate_args): Pass down
5358         USER_FRAME_PRINT_OPTIONS.
5359         * stack.c: Include "cli/cli-option.h".
5360         (print_frame_arguments_all, print_frame_arguments_scalars)
5361         (print_frame_arguments_none): Declare.
5362         (print_raw_frame_arguments, print_entry_values): Delete.
5363         (user_frame_print_options): New.
5364         (boolean_option_def, enum_option_def, frame_print_option_defs):
5365         New.
5366         (struct backtrace_cmd_options): New.
5367         (bt_flag_option_def): New.
5368         (backtrace_command_option_defs): New.
5369         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5370         (print_frame_arg, read_frame_arg, print_frame_args)
5371         (print_frame_info, print_frame): Add frame_print_options parameter
5372         and use it.
5373         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5374         (backtrace_command_1): Add frame_print_options and
5375         backtrace_cmd_options parameters and use them.
5376         (make_backtrace_options_def_group): New.
5377         (backtrace_command): Process command options with
5378         gdb::option::process_options.
5379         (backtrace_command_completer): New.
5380         (_initialize_stack): Extend "backtrace"'s help to mention
5381         supported options.  Install completer for "backtrace".
5382         Install some settings commands with add_setshow_cmds_for_options.
5383
5384 2019-06-13  Pedro Alves  <palves@redhat.com>
5385
5386         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5387         and that "set/show print raw frame-arguments" are now deprecated.
5388
5389         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5390         command.
5391         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5392         * stack.c (_initialize_stack): Install "set/show print
5393         raw-frame-arguments", and deprecate "set/show print raw
5394         frame-arguments".
5395         * valprint.c (_initialize_valprint): Deprecate "set/show print
5396         raw".
5397
5398 2019-06-13  Pedro Alves  <palves@redhat.com>
5399
5400         * compile/compile.c (struct compile_options): New.
5401         (compile_flag_option_def, compile_command_option_defs)
5402         (make_compile_options_def_group): New.
5403         (compile_file_command): Handle options with
5404         gdb::option::process_options.
5405         (compile_file_command_completer): New function.
5406         (compile_code_command): Handle options with
5407         gdb::option::process_options.
5408         (compile_code_command_completer): New function.
5409         (_initialize_compiler): Install completers for "compile code" and
5410         "compile file".  Mention available options in "compile code" and
5411         "compile code"'s help.
5412         * completer.c (advance_to_completion_word): New, factored out from
5413         ...
5414         (advance_to_expression_complete_word_point): ... this.
5415         (advance_to_filename_complete_word_point): New.
5416         * completer.h (advance_to_filename_complete_word_point): New
5417         declaration.
5418
5419 2019-06-13  Pedro Alves  <palves@redhat.com>
5420
5421         * compile/compile.c: Include "cli/cli-option.h".
5422         (compile_print_value): Scope data pointer is now a
5423         value_print_options pointer; adjust.
5424         (compile_print_command): Process options.  Scope data pointer is
5425         now a value_print_options pointer; adjust.
5426         (_initialize_compile): Update "compile print"'s help to include
5427         supported options.  Install a completer for "compile print".
5428         * cp-valprint.c (show_vtblprint, show_objectprint)
5429         (show_static_field_print): Delete.
5430         (_initialize_cp_valprint): Don't install "set print
5431         static-members", "set print vtbl", "set print object" here.
5432         * printcmd.c: Include "cli/cli-option.h" and
5433         "common/gdb_optional.h".
5434         (print_command_parse_format): Rework to fill in a
5435         value_print_options instead of a format_data.
5436         (print_value): Change parameter type from format_data pointer to
5437         value_print_options reference.  Adjust.
5438         (print_command_1): Process options.  Adjust to pass down a
5439         value_print_options.
5440         (print_command_completer): New.
5441         (_initialize_printcmd): Install print_command_completer as
5442         handle_brkchars completer for the "print" command.  Update
5443         "print"'s help to include supported options.
5444         * valprint.c: Include "cli/cli-option.h".
5445         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5446         here from cp-valprint.c.
5447         (boolean_option_def, uinteger_option_def)
5448         (value_print_option_defs, make_value_print_options_def_group):
5449         New.  Use gdb::option::add_setshow_cmds_for_options to install
5450         "set print elements", "set print null-stop", "set print repeats",
5451         "set print pretty", "set print union", "set print array", "set
5452         print address", "set print symbol", "set print array-indexes".
5453         * valprint.h: Include <string> and "cli/cli-option.h".
5454         (make_value_print_options_def_group): Declare.
5455         (print_value): Change parameter type from format_data pointer to
5456         value_print_options reference.
5457         (print_command_completer): Declare.
5458
5459 2019-06-13  Pedro Alves  <palves@redhat.com>
5460
5461         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5462         (COMMON_SFILES): Add maint-test-settings.c.
5463         * cli/cli-decode.c (boolean_enums): New global, factored out from
5464         ...
5465         (add_setshow_boolean_cmd): ... here.
5466         * cli/cli-decode.h (boolean_enums): Declare.
5467         * cli/cli-option.c: New file.
5468         * cli/cli-option.h: New file.
5469         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5470         factored out from ...
5471         (parse_cli_boolean_value(const char *)): ... this.
5472         (is_unlimited_literal): Change parameter type to pointer to
5473         pointer.  Adjust and advance ARG pointer.
5474         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5475         (parse_cli_var_enum): New, factored out from ...
5476         (do_set_command): ... this.  Adjust.
5477         * cli/cli-setshow.h (parse_cli_boolean_value)
5478         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5479         (parse_cli_var_enum): Declare.
5480         * cli/cli-utils.c: Include "cli/cli-option.h".
5481         (get_ulongest): New.
5482         * cli/cli-utils.h (get_ulongest): Declare.
5483         (check_for_argument): New overloads.
5484         * maint-test-options.c: New file.
5485
5486 2019-06-13  Pedro Alves  <palves@redhat.com>
5487
5488         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5489         parse a range if "-" is at the end of the string.
5490
5491 2019-06-13  Pedro Alves  <palves@redhat.com>
5492
5493         * cli/cli-setshow.c (parse_auto_binary_operation)
5494         (parse_cli_boolean_value): Don't allow "o".
5495
5496 2019-06-13  Pedro Alves  <palves@redhat.com>
5497
5498         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5499         * NEWS: Mention maint test-settings KIND.
5500         * maint-test-settings.c: New file.
5501
5502 2019-06-13  Pedro Alves  <palves@redhat.com>
5503
5504         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5505         completer.
5506         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5507         "set" completers.
5508
5509 2019-06-13  Pedro Alves  <palves@redhat.com>
5510
5511         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5512         after item.
5513
5514 2019-06-13  Pedro Alves  <palves@redhat.com>
5515
5516         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5517
5518 2019-06-13  Pedro Alves <palves@redhat.com>
5519
5520         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5521         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5522         call.
5523         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5524         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5525         calls.
5526         (check_for_argument): Skip spaces after argument.
5527
5528 2019-06-13  Pedro Alves  <palves@redhat.com>
5529
5530         * thread.c (thread_apply_command): Adjust TID parsing.
5531         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5532         detected before end of string.
5533         (tid_is_in_list): Error out if LIST is invalid.
5534
5535 2019-06-13  Pedro Alves  <palves@redhat.com>
5536
5537         * completer.c (complete_line_internal_1): Rewind completion word
5538         point.
5539         (completion_tracker::advance_custom_word_point_by): Change
5540         parameter type to int.
5541         * completer.h (completion_tracker::advance_custom_word_point_by):
5542         Likewise.
5543
5544 2019-06-13  Pedro Alves  <palves@redhat.com>
5545
5546         * completer.c (advance_to_completion_word): Handle delimiters.
5547
5548 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5549
5550         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5551
5552 2019-06-11  Tom Tromey  <tom@tromey.com>
5553
5554         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5555         (xmalloc_failed): Move to alloc.c.
5556         * alloc.c: New file.
5557         * Makefile.in (COMMON_SFILES): Add alloc.c.
5558
5559 2019-06-11  Tom Tromey  <tom@tromey.com>
5560
5561         * nat/linux-waitpid.c: Don't include server.h.
5562         (linux_debug): Remove.
5563         (my_waitpid): Update.
5564
5565 2019-06-11  Tom Tromey  <tromey@adacore.com>
5566
5567         * infcall.c (_initialize_infcall): Remove trailing newline from
5568         help.
5569         * user-regs.c (_initialize_user_regs): Remove trailing newline
5570         from help.
5571         * typeprint.c (_initialize_typeprint): Remove trailing newline
5572         from help.
5573         * reverse.c (_initialize_reverse): Remove trailing newlines from
5574         help.
5575         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5576         from help.
5577         * language.c (add_set_language_command): Remove trailing newline
5578         from help.
5579         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5580         help.
5581         * disasm.c (_initialize_disasm): Remove trailing newline from
5582         help.
5583         * top.c (init_main): Remove trailing newline from help.
5584         * interps.c (_initialize_interpreter): Remove trailing newline
5585         from help.
5586         * btrace.c (_initialize_btrace): Remove trailing newlines from
5587         help.
5588         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5589         from help.
5590         * python/python.c (_initialize_python): Remove trailing newline
5591         from help.
5592         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5593         help.
5594         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5595         from help.  Reformat some text.
5596         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5597         from help.
5598         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5599         newline from help.
5600
5601 2019-06-11  Tom Tromey  <tromey@adacore.com>
5602
5603         * darwin-nat.c (darwin_decode_exception_message)
5604         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5605
5606 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5607
5608         * valops.c (value_slice): Check for not allocated or not
5609         associated values.
5610
5611 2019-06-10  Tom de Vries  <tdevries@suse.de>
5612
5613         PR gdb/24618
5614         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5615         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5616         invalid.
5617
5618 2019-06-10  Tom de Vries  <tdevries@suse.de>
5619
5620         PR gdb/24611
5621         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5622         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5623
5624 2019-06-10  Tom de Vries  <tdevries@suse.de>
5625
5626         PR symtab/24545
5627         * symtab.c (struct demangled_name_entry): Add language field.
5628         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5629         static minimal symbol".  Set and use language field.
5630
5631 2019-06-10  Tom Tromey  <tromey@adacore.com>
5632
5633         * ada-lang.c (_initialize_ada_language): Update help text.
5634
5635 2019-06-10  Tom Tromey  <tromey@adacore.com>
5636
5637         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5638         with a newline.
5639         * guile/guile.c (handle_boot_error): Don't end warning with a
5640         newline.
5641         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5642         warning with a newline.
5643         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5644         newline.
5645         (s12z_frame_cache): Likewise.
5646         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5647         a newline.
5648         * solib-svr4.c (disable_probes_interface): Don't end warning with
5649         a newline.
5650         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5651         newline.
5652         * python/python.c (do_finish_initialization): Don't end warning
5653         with a newline.
5654
5655 2019-06-10  Tom Tromey  <tom@tromey.com>
5656
5657         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5658         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5659         gdbpy_enter.
5660
5661 2019-06-10  Tom Tromey  <tromey@adacore.com>
5662
5663         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5664         data.
5665         (elf_new_init): Don't call stabsread_new_init.
5666         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5667         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5668         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5669
5670 2019-06-10  Tom de Vries  <tdevries@suse.de>
5671
5672         PR symtab/16264
5673         PR symtab/24517
5674         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5675
5676 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5677
5678         * source.c (find_and_open_source): Also rewrite relative file
5679         names.
5680
5681 2019-04-26  Amos Bird  <amosbird@gmail.com>
5682
5683         * annotate.c (annotate_thread_exited): Add "thread-exited"
5684         annotation.
5685
5686 2019-06-06  Tom Tromey  <tromey@adacore.com>
5687
5688         * maint.h (class scoped_command_stats): Use
5689         DISABLE_COPY_AND_ASSIGN.
5690         <print_time>: New method.
5691         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5692         print_time.
5693         (scoped_command_stats::print_time): New method.
5694
5695 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5696
5697         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5698         instructions of lengths 6 or 8 bytes.
5699
5700 2019-06-04  Pedro Alves  <palves@redhat.com>
5701
5702         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5703
5704         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5705         * breakpoint.c (condition_completer): Likewise.
5706         * cli/cli-dump.c (scan_expression): Likewise.
5707         * common/filestuff.c (mkdir_recursive): Likewise.
5708         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5709         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5710         (gdb_abspath): Likewise.
5711         * compile/compile-cplus-types.c
5712         (compile_cplus_instance::decl_name): Likewise.
5713         * completer.c (complete_explicit_location):
5714         (signal_completer, reg_or_group_completer_1): Likewise.
5715         * cp-support.c (cp_remove_params_if_any): Likewise.
5716         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5717         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5718         * infcmd.c (strip_bg_char): Likewise.
5719         * linespec.c (copy_token_string): Likewise.
5720         * mi/mi-main.c (output_cores): Likewise.
5721         * psymtab.c (psymtab_search_name):
5722         * symfile.c (test_set_ext_lang_command): Likewise.
5723         * target.c (target_fileio_read_stralloc): Likewise.
5724         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5725         * value.c (complete_internalvar): Likewise.
5726
5727 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5728
5729         Add objfile property to gdb.Type.
5730         * NEWS: Mention Python API addition.
5731         * python/py-type.c (typy_get_objfile): New method.
5732
5733 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5734
5735         * NEWS: Mention the new set|show style [title|highlight].
5736         Mention changes to "show style", "help" and "apropos".
5737
5738 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5739
5740         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5741         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5742         instead of print_help_for_command.
5743         (print_doc_of_command): New function.
5744         (help_list): Add 'apropos -v word' suggestion.
5745         (print_help_for_command): Style the command name using title style.
5746         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5747         (_initialize_cli_cmds): Describe -v in apropos_command help.
5748
5749 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5750
5751         * cli/cli-style.h (cli_style_option): Add name in constructor,
5752         add m_name class member, add constructor with intensity,
5753         add name class function.
5754         (cli_style_option::add_setshow_commands): Remove name argument.
5755         (highlight_style, title_style): New styles.
5756         * cli/cli-style.c (do_show): New function that shows a style
5757         characteristic styling the style name with itself.
5758         (set_style_name): New function.
5759         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5760         Update all callers according to the changes in cli/cli-style.h.
5761         * utils.h (fputs_highlighted): New function.
5762         * utils.c (fputs_highlighted): Likewise.
5763
5764 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5765
5766         * NEWS: Mention new pipe command and new convenience variables.
5767
5768 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5769
5770         * cli/cli-cmds.c (pipe_command): New function.
5771         (_initialize_cli_cmds): Call add_com for pipe_command.
5772         Define | as an alias for pipe.
5773         (exit_status_set_internal_vars): New function.
5774         (shell_escape): Call exit_status_set_internal_vars.
5775         cli/cli-decode.c (find_command_name_length): Recognize | as
5776         a single character command.
5777
5778 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5779
5780         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5781         top.c (execute_command_to_ui_file): New function, mostly a copy
5782         of execute_command_to_string.
5783         (execute_command_to_string): Implement by calling
5784         execute_command_to_ui_file.
5785
5786 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5787
5788         * top.h (saved_command_line): Remove declaration.
5789         * top.c (previous_saved_command_line, previous_repeat_arguments):
5790         New variables.
5791         (saved_command_line): Make static, define together with other
5792         'repeat variables'.
5793         (dont_repeat): Clear repeat_arguments.
5794         (repeat_previous, get_saved_command_line, save_command_line):
5795         New functions.
5796         (gdb_init): Initialize saved_command_line
5797         and previous_saved_command_line.
5798         * main.c (captured_main_1): Remove saved_command_line initialization.
5799         * event-top.c (handle_line_of_input): Update to use
5800         the new 'repeat' related functions instead of direct access to
5801         saved_command_line.
5802         * command.h (repeat_previous, get_saved_command_line,
5803         save_command_line): New declarations.
5804         (dont_repeat): Add comment.
5805
5806 2019-05-30  Tom Tromey  <tromey@adacore.com>
5807
5808         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5809         Fix comment.
5810         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5811
5812 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5813
5814         PR cli/24587
5815         * completer.c (complete): Initialize variable word.
5816
5817 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5818
5819         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5820         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5821         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5822         'body' is NULL to the outter 'if', protecting the '!is_define'
5823         situation as well.
5824
5825 2019-05-29  Tom Tromey  <tromey@adacore.com>
5826
5827         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5828         (dwarf_unknown): New function.
5829         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5830         (dwarf_type_encoding_name): Use dwarf_unknown.
5831
5832 2019-05-29  Tom Tromey  <tromey@adacore.com>
5833
5834         PR c++/20020:
5835         * cp-valprint.c (cp_print_value_fields): Call
5836         cp_print_static_field inside "try".
5837
5838 2019-05-29  Tom Tromey  <tromey@adacore.com>
5839
5840         * inflow.c (struct terminal_info): Add default operator=.
5841         * configure: Rebuild.
5842         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5843         -Wdeprecated-copy-dtor, -Wredundant-move.
5844
5845 2019-05-29  Tom Tromey  <tromey@adacore.com>
5846
5847         * NEWS: Add entry.
5848         * infcmd.c (print_return_value_1): Handle finish_print
5849         option.
5850         (show_print_finish): New function.
5851         (_initialize_infcmd): Add "set/show print finish" commands.
5852         * valprint.c (user_print_options): Initialize new member.
5853         * valprint.h (struct value_print_options) <finish_print>: New
5854         member.
5855
5856 2019-05-28  Tom Tromey  <tromey@adacore.com>
5857
5858         * ada-lang.c (ada_remove_Xbn_suffix)
5859         (find_old_style_renaming_symbol)
5860         (parse_old_style_renaming): Remove.
5861         (ada_find_renaming_symbol): Don't call
5862         find_old_style_renaming_symbol.
5863         (ada_is_renaming_symbol): Rename from
5864         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5865         bool.  Now static.
5866         (ada_read_var_value): Update and simplify.
5867         * ada-exp.y (write_var_or_type): Remove old code.
5868
5869 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5870
5871         * event-top.c: Remove include comment.
5872         * inflow.c (class scoped_ignore_sigttou): Move from here...
5873         * inflow.h (class scoped_ignore_sigttou): ...to here.
5874         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5875         * top.c:  Remove include comment.
5876
5877 2019-05-27  Tom Tromey  <tom@tromey.com>
5878
5879         * NEWS: Fix typo.
5880
5881 2019-05-22  Tom Tromey  <tromey@adacore.com>
5882
5883         * target.c (target_follow_exec): Constify parameter.
5884         * target-delegates.c: Rebuild.
5885         * remote.c (remote_target::follow_exec): Constify parameter.
5886         * infrun.c (follow_exec): Constify parameter.
5887         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5888         (target_follow_exec): Likewise.
5889
5890 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5891
5892         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5893         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5894
5895 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5896
5897         * NEWS: Add debugredirect and testsuite sections.
5898
5899 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5900
5901         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5902         target descriptions using exclusively floating point register name
5903         aliases.
5904
5905 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5906
5907         PR gdb/18644:
5908         * f-lang.c (build_fortran_types): Handle the case where
5909         gdbarch_floatformat_for_type returns a nullptr.
5910
5911 2019-05-21  Tom de Vries  <tdevries@suse.de>
5912
5913         PR cli/24587
5914         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5915
5916 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5917
5918         PR gdb/18644:
5919         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5920         16-byte floats.
5921         * i386-tdep.c (i386_floatformat_for_type): Use
5922         floatformats_ia64_quad for the 16-byte floating point component
5923         within a fortran 32-byte complex number.
5924
5925 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5926
5927         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5928         delete default constructor.
5929         (find_partial_die): Update to return const struct.
5930         (partial_die_parent_scope): Move variable declaration into scope
5931         of its use and change its type to auto.
5932         (guess_partial_die_structure_name): Likewise.
5933         (partial_die_info::fixup): Likewise.
5934
5935 2019-05-17  Tom Tromey  <tromey@adacore.com>
5936
5937         * source.c (find_and_open_source): Remove cast.
5938
5939 2019-05-17  Tom Tromey  <tromey@adacore.com>
5940
5941         * annotate.c (annotate_source): Make "filename" const.
5942         * annotate.h (annotate_source): Use const.
5943
5944 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5945
5946         * disasm.c (set_disassembler_options): Send errors to stderr.
5947
5948 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5949
5950         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5951         (cli_interp_base::set_logging): Check debug_redirect.
5952         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5953         * cli/cli-logging.c (debug_redirect): Add static variable.
5954         (pop_output_files): Add default param.
5955         (handle_redirections): Print debug setting.
5956         (show_logging_command): Likewise.
5957         (_initialize_cli_logging): Add debugredirect command.
5958         * interps.c (current_interp_set_logging): Add debug_redirect
5959         parameter.
5960         * interps.h (set_logging): Add debug_redirect parameter.
5961         (current_interp_set_logging): Likewise.
5962         * mi/mi-common.h: Likewise.
5963         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5964
5965 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5966             Tom Tromey  <tromey@adacore.com>
5967
5968         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5969         directly.
5970         * cli/cli-interp.h (make_logging_output): Remove declaration.
5971         * cli/cli-logging.c (make_logging_output): Remove function.
5972         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5973         directly.
5974         * ui-file.c (tee_file::tee_file): Remove bools.
5975         (tee_file::~tee_file): Remove deletes.
5976         * ui-file.h (tee_file): Remove bools.
5977
5978 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5979
5980         * mi/mi-cmds.h (mi_cmd_complete): New function.
5981         * mi/mi-main.c (mi_cmd_complete): Likewise.
5982         * mi/mi-cmds.c: Define new MI command -complete.
5983         * NEWS: Mention new -complete command.
5984
5985 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5986
5987         * completer.h (complete): New function.
5988         * completer.c (complete): Likewise.
5989         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5990         function defined in completer.h.
5991
5992 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5993
5994         * MAINTAINERS (Write After Approval): Add myself.
5995
5996 2019-05-17  Tom de Vries  <tdevries@suse.de>
5997
5998         PR gdb/24094
5999         * dwarf2read.c (struct cu_partial_die_info): New struct.
6000         (find_partial_die): Return cu_partial_die_info.
6001         (partial_die_parent_scope, guess_partial_die_structure_name)
6002         (partial_die_info::fixup): Handle new return type of find_partial_die.
6003
6004 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6005
6006         PR breakpoints/24541
6007         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6008         "std::string", simplifying the algorithm.
6009
6010 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6011
6012         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6013         (stap_static_probe_ops::get_probes): Likewise.
6014
6015 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6016
6017         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6018         '-')" and "else if".
6019         (stap_parse_single_operand): Join checks for
6020         "gdbarch_stap_parse_special_token_p" and
6021         "gdbarch_stap_parse_special_token" in the same "if" statement.
6022         Invert check when verifying for operation on register
6023         displacement.
6024
6025 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6026
6027         * stap-probe.c (stap_get_opcode): Update comment.
6028         (stap_get_expected_argument_type): Likewise.
6029         (handle_stap_probe): Likewise.
6030
6031 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6032
6033         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6034         return type to 'bool'.  Adjust comment.  Use 'bool' when
6035         appropriate.
6036         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6037         * stap-probe.c (stap_parse_argument_1): Likewise.
6038         (stap_is_operator): Likewise.
6039         (stap_is_generic_prefix): Likewise.
6040         (stap_is_register_prefix): Likewise.
6041         (stap_is_register_indirection_prefix): Likewise.
6042         (stap_is_integer_prefix): Likewise.
6043         (stap_generic_check_suffix): Likewise.
6044         (stap_check_integer_suffix): Likewise.
6045         (stap_check_register_suffix): Likewise.
6046         (stap_check_register_indirection_suffix): Likewise.
6047         (stap_parse_register_operand): Likewise.
6048         (stap_parse_single_operand): Likewise.
6049         (stap_parse_argument_1): Likewise.
6050         (stap_probe::get_argument_count): Likewise.
6051         (stap_is_operator): Likewise.
6052
6053 2019-05-16  Tom Tromey  <tromey@adacore.com>
6054
6055         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6056         keyword to foreach.
6057
6058 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6059
6060         * linux-thread-db.c (try_thread_db_load_1): Change return type
6061         to bool.
6062         (try_thread_db_load): Likewise.
6063         (try_thread_db_load_from_pdir_1): Likewise.
6064         (try_thread_db_load_from_pdir): Likewise.
6065         (try_thread_db_load_from_sdir): Likewise.
6066         (try_thread_db_load_from_dir): Likewise.
6067         (thread_db_load_search): Likewise.
6068         (has_libpthread): Likewise.
6069         (thread_db_load): Likewise.
6070
6071 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6072
6073         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6074         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6075         NULL, and complain/return if that's the case.
6076
6077 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6078
6079         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6080         (advance, posn, abstract_read_memory): New functions.
6081         [struct mem_read_abstraction]: New struct.
6082         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6083
6084 2019-05-14  Tom Tromey  <tromey@adacore.com>
6085
6086         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6087         value is not lval_memory.
6088
6089 2019-05-14  Tom Tromey  <tromey@adacore.com>
6090
6091         * solib.c (info_sharedlibrary_command): Style the file name.
6092
6093 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6094
6095         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6096         (aarch64_vnv_type): Likewise.
6097         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6098         * common/tdesc.c: Likewise.
6099         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6100         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6101         * features/aarch64-fpu.xml: Add ieee half view.
6102         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6103         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6104         * gdbtypes.h (struct builtin_type): Likewise.
6105         (struct objfile_type): Likewise.
6106
6107 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6108
6109         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6110         typo.
6111         * location.h (string_to_event_location): Likewise.
6112
6113 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6114
6115         GDB 8.3 released.
6116
6117 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6118
6119         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6120         New variable declaration.
6121         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6122         New variable.
6123         (print_one_breakpoint): Use ui_out::test_flags and new global
6124         variable to compute use_fixed_output.
6125         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6126         Remove.
6127         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6128         (mi_multi_location_breakpoint_output_fixed): Remove.
6129         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6130         new variable.
6131         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6132         fix_multi_location_breakpoint_output flag if version >= 3.
6133         * ui-out.h (enum ui_out_flag)
6134         <fix_multi_location_breakpoint_output>: New enumerator.
6135
6136 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6137
6138         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6139
6140 2019-05-10  Tom Tromey  <tromey@adacore.com>
6141
6142         * ada-lang.c (catch_ada_completer): New function.
6143         (_initialize_ada_language): Use it.
6144
6145 2019-05-10  Tom Tromey  <tromey@adacore.com>
6146
6147         * thread.c (print_thread_info): Make "requested_threads" const.
6148         * gdbthread.h (print_thread_info): Make "requested_threads"
6149         const.
6150         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6151         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6152
6153 2019-05-08  Tom Tromey  <tom@tromey.com>
6154
6155         * gdbtypes.c (objfile_type_data): Change type.
6156         (objfile_type, _initialize_gdbtypes): Update.
6157
6158 2019-05-08  Tom Tromey  <tom@tromey.com>
6159
6160         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6161         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6162         (_initialize_dwarf2_frame): Update.
6163
6164 2019-05-08  Tom Tromey  <tom@tromey.com>
6165
6166         * objc-lang.c (objc_objfile_data): Change type.
6167         (find_methods): Update.
6168         (_initialize_objc_lang): Remove.
6169
6170 2019-05-08  Tom Tromey  <tom@tromey.com>
6171
6172         * stabsread.c (rs6000_builtin_type_data): Change type.
6173         (rs6000_builtin_type, _initialize_stabsread): Update.
6174
6175 2019-05-08  Tom Tromey  <tom@tromey.com>
6176
6177         * mips-tdep.c (mips_pdr_data): Remove.
6178         (_initialize_mips_tdep): Update.
6179
6180 2019-05-08  Tom Tromey  <tom@tromey.com>
6181
6182         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6183         (hppa_init_objfile_priv_data, read_unwind_info)
6184         (find_unwind_entry, _initialize_hppa_tdep): Update.
6185
6186 2019-05-08  Tom Tromey  <tom@tromey.com>
6187
6188         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6189         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6190         on obstack.
6191         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6192
6193 2019-05-08  Tom Tromey  <tom@tromey.com>
6194
6195         * mdebugread.c (basic_type_data): Change type.
6196         (basic_type, _initialize_mdebugread): Update.
6197
6198 2019-05-08  Tom Tromey  <tom@tromey.com>
6199
6200         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6201
6202 2019-05-08  Tom Tromey  <tom@tromey.com>
6203
6204         * nto-tdep.c (nto_inferior_data_reg): Change type.
6205         (nto_inferior_data): Update.
6206         (nto_inferior_data_cleanup, nto_new_inferior_data)
6207         (_initialize_nto_tdep): Remove.
6208         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6209
6210 2019-05-08  Tom Tromey  <tom@tromey.com>
6211
6212         * ada-lang.c (struct ada_inferior_data): Add initializers.
6213         (ada_inferior_data): Change type.
6214         (ada_inferior_data_cleanup): Remove.
6215         (get_ada_inferior_data, ada_inferior_exit)
6216         (struct ada_pspace_data): Add initializers, destructor.
6217         (ada_pspace_data_handle): Change type.
6218         (get_ada_pspace_data): Update.
6219         (ada_pspace_data_cleanup): Remove.
6220
6221 2019-05-08  Tom Tromey  <tom@tromey.com>
6222
6223         * coffread.c (struct coff_symfile_info): Add initializers.
6224         (coff_objfile_data_key): Move lower.  Change type.
6225         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6226         Update.
6227         (coff_free_info): Remove.
6228
6229 2019-05-08  Tom Tromey  <tom@tromey.com>
6230
6231         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6232         (fbsd_pspace_data_handle): Move lower.  Change type.
6233         (get_fbsd_pspace_data): Update.
6234         (fbsd_pspace_data_cleanup): Remove.
6235         (_initialize_fbsd_tdep): Update.
6236
6237 2019-05-08  Tom Tromey  <tom@tromey.com>
6238
6239         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6240         (get_ada_tasks_pspace_data): Update.
6241         (ada_tasks_pspace_data_cleanup): Remove.
6242         (_initialize_tasks): Update.
6243         (ada_tasks_inferior_data_handle): Change type.
6244         (get_ada_tasks_inferior_data): Update.
6245         (ada_tasks_inferior_data_cleanup): Remove.
6246         (struct ada_tasks_pspace_data): Add initializers.
6247
6248 2019-05-08  Tom Tromey  <tom@tromey.com>
6249
6250         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6251         * symfile-debug.c (debug_sym_get_probes): Change type.
6252         * stap-probe.c (handle_stap_probe):
6253         (stap_static_probe_ops::get_probes): Change type.
6254         * probe.h (class static_probe_ops) <get_probes>: Change type.
6255         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6256         (parse_probes_in_pspace): Update.
6257         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6258         Update.
6259         (any_static_probe_ops::get_probes): Change type.
6260         * elfread.c (elfread_data): New typedef.
6261         (probe_key): Change type.
6262         (elf_get_probes): Likewise.  Update.
6263         (probe_key_free): Remove.
6264         (_initialize_elfread): Update.
6265         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6266         Change type.
6267         (dtrace_process_dof_probe, dtrace_process_dof)
6268         (dtrace_static_probe_ops::get_probe): Change type.
6269
6270 2019-05-08  Tom Tromey  <tom@tromey.com>
6271
6272         * xcoffread.c (struct xcoff_symfile_info): Rename from
6273         coff_symfile_info.  Add initializers.
6274         (xcoff_objfile_data_key): Move lower.  Change type.
6275         (XCOFF_DATA): Rewrite.
6276         (xcoff_free_info): Remove.
6277         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6278         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6279         (xcoff_initial_scan): Update.
6280
6281 2019-05-08  Tom Tromey  <tom@tromey.com>
6282
6283         * solib-svr4.c (struct svr4_info): Add initializers and
6284         destructor.
6285         <probes_table>: Now an htab_up.
6286         (solib_svr4_pspace_data): Change type.
6287         (free_probes_table): Simplify.
6288         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6289         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6290         (probes_table_remove_objfile_probes, register_solib_event_probe)
6291         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6292         (_initialize_svr4_solib): Update.
6293
6294 2019-05-08  Tom Tromey  <tom@tromey.com>
6295
6296         * remote.c (remote_pspace_data): Change type.
6297         (remote_pspace_data_cleanup): Remove.
6298         (get_remote_exec_file, set_pspace_remote_exec_file)
6299         (_initialize_remote): Update.
6300
6301 2019-05-08  Tom Tromey  <tom@tromey.com>
6302
6303         * breakpoint.c (breakpoint_objfile_key): Change type.
6304         (get_breakpoint_objfile_data): Update.
6305         (free_breakpoint_objfile_data): Remove.
6306         (_initialize_breakpoint): Update.
6307
6308 2019-05-08  Tom Tromey  <tom@tromey.com>
6309
6310         * linux-tdep.c (struct linux_info): Add initializers.
6311         (linux_inferior_data): Move.  Change type.
6312         (invalidate_linux_cache_inf): Update.
6313         (linux_inferior_data_cleanup): Remove.
6314         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6315
6316 2019-05-08  Tom Tromey  <tom@tromey.com>
6317
6318         * auxv.c (auxv_inferior_data): Move.  Change type.
6319         (auxv_inferior_data_cleanup): Remove.
6320         (invalidate_auxv_cache_inf): Rewrite.
6321         (get_auxv_inferior_data, _initialize_auxv): Update.
6322
6323 2019-05-08  Tom Tromey  <tom@tromey.com>
6324
6325         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6326         (symfile_debug_objfile_data_key): Change type.
6327         (symfile_debug_installed, debug_qf_has_symbols)
6328         (debug_qf_find_last_source_symtab)
6329         (debug_qf_forget_cached_source_info)
6330         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6331         (debug_qf_print_stats, debug_qf_dump)
6332         (debug_qf_expand_symtabs_for_function)
6333         (debug_qf_expand_all_symtabs)
6334         (debug_qf_expand_symtabs_with_fullname)
6335         (debug_qf_map_matching_symbols)
6336         (debug_qf_expand_symtabs_matching)
6337         (debug_qf_find_pc_sect_compunit_symtab)
6338         (debug_qf_map_symbol_filenames)
6339         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6340         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6341         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6342         (debug_sym_read_linetable, debug_sym_relocate): Update.
6343         (symfile_debug_free_objfile): Remove.
6344         (install_symfile_debug_logging, _initialize_symfile_debug):
6345         Update.
6346
6347 2019-05-08  Tom Tromey  <tom@tromey.com>
6348
6349         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6350         allocate_on_obstack.
6351         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6352         (get_dwarf2_per_objfile): Update.
6353         (set_dwarf2_per_objfile): Remove.
6354         (dwarf2_has_info, dwarf2_get_section_info): Update.
6355         (dwarf2_free_objfile): Remove.
6356         (_initialize_dwarf2_read): Update.
6357
6358 2019-05-08  Tom Tromey  <tom@tromey.com>
6359
6360         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6361         initializers.
6362         <unsupported_script_warning_printed,
6363         script_not_found_warning_printed>: Now bool.
6364         (auto_load_pspace_data): Change type.
6365         (~auto_load_pspace_info): Rename from
6366         auto_load_pspace_data_cleanup.
6367         (get_auto_load_pspace_data, init_loaded_scripts_info)
6368         (clear_section_scripts, maybe_print_unsupported_script_warning)
6369         (maybe_print_script_not_found_warning, _initialize_auto_load):
6370         Update.
6371
6372 2019-05-08  Tom Tromey  <tom@tromey.com>
6373
6374         * objfiles.c (objfile_pspace_info): Add destructor and
6375         initializers.
6376         (objfiles_pspace_data): Change type.
6377         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6378         (get_objfile_pspace_data): Update.
6379         (objfiles_bfd_data): Change type.
6380         (get_objfile_bfd_data): Update.
6381         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6382
6383 2019-05-08  Tom Tromey  <tom@tromey.com>
6384
6385         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6386         Change type.
6387         (get_catch_syscall_inferior_data): Update.
6388         (catch_syscall_inferior_data_cleanup): Remove.
6389         (_initialize_break_catch_syscall): Update.
6390
6391 2019-05-08  Tom Tromey  <tom@tromey.com>
6392
6393         * inflow.c (struct terminal_info): Add destructor and
6394         initializers.
6395         (inflow_inferior_data): Change type.
6396         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6397         (get_inflow_inferior_data, inflow_inferior_exit)
6398         (swap_terminal_info, _initialize_inflow): Update.
6399
6400 2019-05-08  Tom Tromey  <tom@tromey.com>
6401
6402         * target-dcache.c (target_dcache_cleanup): Remove.
6403         (target_dcache_aspace_key): Change type.
6404         (target_dcache_init_p, target_dcache_invalidate)
6405         (target_dcache_get, target_dcache_get_or_init)
6406         (_initialize_target_dcache): Update.
6407         * dcache.h (struct dcache_deleter): New.
6408
6409 2019-05-08  Tom Tromey  <tom@tromey.com>
6410
6411         * symtab.c (struct symbol_cache): Add destructor and
6412         initializers.
6413         (symbol_cache_key): Move.  Change type.
6414         (make_symbol_cache, free_symbol_cache): Remove.
6415         (get_symbol_cache): Update.
6416         (symbol_cache_cleanup): Remove.
6417         (ALL_PSPACES, symbol_cache_flush)
6418         (maintenance_print_symbol_cache)
6419         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6420         Update.
6421
6422 2019-05-08  Tom Tromey  <tom@tromey.com>
6423
6424         * symtab.c (struct main_info): Add destructor and initializers.
6425         (main_progspace_key): Move.  Change type.
6426         (get_main_info): Update.
6427         (main_info_cleanup): Remove.
6428         (_initialize_symtab): Update.
6429
6430 2019-05-08  Tom Tromey  <tom@tromey.com>
6431
6432         * registry.h (DECLARE_REGISTRY): Define the _key class.
6433
6434 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6435
6436         * NEWS: Merge two 'New commands' sections.
6437
6438 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6439
6440         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6441         parameter and use Ada language definition instead.
6442         (ada_val_print_ptr): Remove unused language parameter.
6443         (ada_val_print_num): Remove language parameter and use Ada language
6444         definition instead.
6445         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6446         parameter.
6447         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6448         parameter and use Ada language definition instead.
6449         (ada_val_print_1): Update all ada_val_print_xxx calls.
6450         Remove language parameter.
6451         (ada_val_print): Update ada_val_print_1 call.
6452
6453 2019-05-08  Tom Tromey  <tromey@adacore.com>
6454
6455         * remote.c (remote_hw_watchpoint_limit)
6456         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6457         Now static.
6458
6459 2019-05-08  Tom Tromey  <tromey@adacore.com>
6460
6461         * maint.c (_initialize_maint_cmds): Move initialization code to
6462         remote.c.
6463         (watchdog, show_watchdog): Move to remote.c.
6464         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6465         "watchdog" static.
6466         (_initialize_remote): Move initialization code from maint.c.
6467         * defs.h (watchdog): Don't declare.
6468
6469 2019-05-08  Tom Tromey  <tromey@adacore.com>
6470
6471         * tui/tui-interp.c: Include main.h.
6472         * interps.c: Include main.h.
6473         * main.h (interpreter_p): Declare.
6474         * defs.h (interpreter_p): Don't declare.
6475
6476 2019-05-08  Tom Tromey  <tromey@adacore.com>
6477
6478         * dwarf2loc.c: Include dwarf2read.h.
6479         * defs.h (read_unsigned_leb128): Don't declare.
6480         * dwarf2read.h (read_unsigned_leb128): Declare.
6481
6482 2019-05-08  Tom Tromey  <tromey@adacore.com>
6483
6484         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6485         method.
6486
6487 2019-05-08  Tom Tromey  <tromey@adacore.com>
6488
6489         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6490         when no wrap column is set.
6491
6492 2019-05-08  Tom Tromey  <tromey@adacore.com>
6493
6494         * c-lang.c (c_get_string): Handle non-C-style arrays.
6495
6496 2019-05-08  Tom Tromey  <tromey@adacore.com>
6497
6498         * typeprint.c (print_offset_data::update): Print the bit offset,
6499         not the number of bits remaining.
6500
6501 2019-05-08  Tom Tromey  <tromey@adacore.com>
6502
6503         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6504         padding at end of comment.
6505
6506 2019-05-08  Tom Tromey  <tromey@adacore.com>
6507
6508         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6509         Compare main types.
6510
6511 2019-05-06  Tom Tromey  <tom@tromey.com>
6512
6513         * common/scoped_mmap.c: Include common-defs.h.
6514         * common/scoped_mmap.h: Don't include config.h.
6515
6516 2019-05-04  Tom Tromey  <tom@tromey.com>
6517
6518         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6519         (struct aarch64_call_info): Add initializers.
6520         <si>: Now a std::vector.
6521         (pass_on_stack, aarch64_push_dummy_call): Update.
6522
6523 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6524             Tom Tromey  <tom@tromey.com>
6525
6526         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6527         (ppc_threads): Now a std::vector.  Now static.
6528         (hwdebug_find_thread_points_by_tid)
6529         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6530         Update.
6531
6532 2019-05-04  Tom Tromey  <tom@tromey.com>
6533
6534         * arc-tdep.c (arc_tdesc_init): Return bool.
6535
6536 2019-05-04  Tom Tromey  <tom@tromey.com>
6537
6538         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6539         Use gdb_assert_not_reached.
6540
6541 2019-05-04  Tom Tromey  <tom@tromey.com>
6542
6543         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6544         "false".
6545
6546 2019-05-04  Tom Tromey  <tom@tromey.com>
6547
6548         * arc-tdep.c (arc_tdesc_init): Use bool.
6549
6550 2019-05-04  Tom Tromey  <tom@tromey.com>
6551
6552         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6553
6554 2019-05-04  Tom Tromey  <tom@tromey.com>
6555
6556         * cli/cli-cmds.c (valid_command_p): Return bool.
6557
6558 2019-05-04  Tom Tromey  <tom@tromey.com>
6559
6560         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6561         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6562
6563 2019-05-04  Raul Tambre  <raul@tambre.ee>
6564
6565         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6566         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6567         operator for comparison.
6568
6569 2019-05-04  Tom Tromey  <tom@tromey.com>
6570
6571         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6572         (lookup_partial_symbol, print_partial_symbols)
6573         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6574         (psymbol_compare): Update.
6575         (add_psymbol_to_bcache): Clear the entire psymbol.
6576         (maintenance_check_psymtabs): Update.
6577         * psympriv.h (struct partial_symbol): Don't derive from
6578         general_symbol_info.
6579         <obj_section, unrelocated_address, address,
6580         set_unrelocated_address>: Update.
6581         <ginfo>: New member.
6582         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6583         (debug_names::write_psymbols): Update.
6584
6585 2019-05-04  Tom de Vries  <tdevries@suse.de>
6586
6587         * contrib/cc-with-tweaks.sh: Support -n arg.
6588
6589 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6590
6591         * corelow.c (core_target::detach): Ensure frame cache and
6592         register caches are cleared.
6593         inferior.c (exit_inferior_1): Likewise.
6594
6595 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6596             Tom Tromey  <tom@tromey.com>
6597
6598         * dictionary.c (collate_pending_symbols_by_language): Remove
6599         "struct" from foreach.
6600         * symtab.c (lookup_global_symbol_from_objfile)
6601         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6602         foreach.
6603         * ser-tcp.c (net_open): Remove "struct" from foreach.
6604         * objfiles.c (objfile_relocate, objfile_rebase)
6605         (objfile_has_symbols): Remove "struct" from foreach.
6606         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6607         from foreach.
6608         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6609         foreach.
6610         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6611         "struct" from foreach.
6612         * ada-lang.c (create_excep_cond_exprs)
6613         (ada_exception_catchpoint_cond_string): Remove "struct" from
6614         foreach.
6615
6616 2019-05-03  Tom Tromey  <tromey@adacore.com>
6617
6618         * ada-exp.y (convert_char_literal): Check suffix of each
6619         enumerator.
6620
6621 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6622
6623         PR ada/21406:
6624         * ada-exp.y (yywrap): Don't define.
6625         * ada-lex.l (%option): Add noyywrap
6626         (yywrap): Remove.
6627
6628 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6629
6630         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6631         _WIN32_WINNT to the XP level, unless already defined to a higher
6632         level.
6633
6634         * unittests/parse-connection-spec-selftests.c:
6635         * ser-tcp.c:
6636         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6637         override.
6638
6639         * symfile.c (find_separate_debug_file): Remove colon from the
6640         drive spec of DOS/Windows file names of the target, so that the
6641         file name produced from DEBUGDIR and the target's directory will
6642         be valid on DOS/Windows systems.
6643
6644 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6645
6646         * rust-lang.c (val_print_struct): Handle printing structures
6647         containing strings.
6648
6649 2019-05-02  Tom Tromey  <tromey@adacore.com>
6650
6651         * valarith.c (_initialize_valarith): Remove.
6652
6653 2019-05-01  Tom Tromey  <tromey@adacore.com>
6654
6655         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6656         bitfields.
6657
6658 2019-05-01  Tom Tromey  <tromey@adacore.com>
6659
6660         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6661         for big-endian copies.
6662
6663 2019-04-30  Ali Tamur  <tamur@google.com>
6664         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6665         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6666         (read_3_bytes): New function.
6667
6668 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6669
6670         * windows-nat.c (main_thread_id): Delete.
6671         (handle_output_debug_string): Replace main_thread_id by
6672         current_event.dwThreadId.
6673         (fake_create_process): Likewise.
6674         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6675         Do not set main_thread_id.
6676         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6677         current_event.dwThreadId.
6678         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6679
6680 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6681
6682         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6683         Use current_event.dwThreadId instead of main_thread_id.
6684
6685 2019-04-30  Tom Tromey  <tromey@adacore.com>
6686
6687         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6688         (create_excep_cond_exprs): Iterate over program spaces.
6689         (ada_exception_catchpoint_cond_string): Examine all minimal
6690         symbols for exception types.
6691
6692 2019-04-30  Tom Tromey  <tromey@adacore.com>
6693
6694         PR c++/24470:
6695         * dwarf2read.c (process_structure_scope): Handle case where type
6696         has template parameters but no symbol was created.
6697
6698 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6699             Chris January  <chris.january@arm.com>
6700
6701         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6702         qualifier.
6703         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6704
6705 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6706
6707         * f-typeprint.c (f_print_type): Update rules for printing
6708         whitespace.
6709         (f_type_print_varspec_suffix): Likewise.
6710
6711 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6712             Chris January  <chris.january@arm.com>
6713
6714         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6715         function arguments.
6716
6717 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6718
6719         * f-lang.c (build_fortran_types): Change name of void type to
6720         lower case.
6721         * f-typeprint.c (f_type_print_base): Print the name of the void
6722         type, rather than a fixed string.
6723         * f-valprint.c (f_decorations): Use lower case void string.
6724
6725 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6726             Chris January  <chris.january@arm.com>
6727
6728         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6729         types for Fortran.
6730
6731 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6732             Chris January  <chris.january@arm.com>
6733             David Lecomber  <david.lecomber@arm.com>
6734
6735         * f-exp.y (BINOP_INTRINSIC): New token.
6736         (exp): New parser rule handling BINOP_INTRINSIC.
6737         (f77_keywords): Add new builtin procedures.
6738         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6739         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6740         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6741         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6742         (print_unop_subexp_f): New function.
6743         (print_binop_subexp_f): New function.
6744         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6745         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6746         (dump_subexp_body_f): Likewise.
6747         (operator_check_f): Likewise.
6748         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6749         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6750
6751 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6752
6753         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6754         UNOP_KIND.
6755         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6756         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6757         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6758         (operator_length_f): New fuction.
6759         (print_subexp_f): New function.
6760         (op_name_f): New function.
6761         (dump_subexp_body_f): New function.
6762         (operator_check_f): New function.
6763         (exp_descriptor_f): Replace standard expression handling functions
6764         with new functions.
6765         * gdb/fortran-operator.def: New file.
6766         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6767         * gdb/std-operator.def: Remove UNOP_KIND.
6768
6769 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6770
6771         * std-operator.def: Remove unbalanced, stray double quote
6772         character.
6773
6774 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6775             Chris January  <chris.january@arm.com>
6776             Daniel Everett  <daniel.everett@arm.com>
6777             Nick Forrington  <nick.forrington@arm.com>
6778             Richard Bunt  <richard.bunt@arm.com>
6779
6780         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6781         of depth when printing anonymous structs or unions.
6782         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6783         Don't print either the top-level value, or the children if the
6784         max-depth is exceeded.
6785         (ppscm_print_children): When printing the key of a map, allow one
6786         extra level of depth.
6787         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6788         print either the top-level value, or the children if the max-depth
6789         is exceeded.
6790         (print_children): When printing the key of a map, allow one extra
6791         level of depth.
6792         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6793         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6794         (user_print_options): Initialise max_depth field.
6795         (val_print_scalar_or_string_type_p): New function.
6796         (val_print): Check to see if the max depth has been reached.
6797         (val_print_check_max_depth): Define new function.
6798         (show_print_max_depth): New function.
6799         (_initialize_valprint): Add 'print max-depth' option.
6800         * valprint.h (struct value_print_options) <max_depth>: New field.
6801         (val_print_check_max_depth): Declare new function.
6802         * NEWS: Document new feature.
6803
6804 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6805
6806         * ada-lang.c (ada_language_defn): Initialise new field.
6807         * c-lang.c (c_is_string_type_p): New function.
6808         (c_language_defn): Initialise new field.
6809         (cplus_language_defn): Initialise new field.
6810         (asm_language_defn): Initialise new field.
6811         (minimal_language_defn): Initialise new field.
6812         * c-lang.h (c_is_string_type_p): Declare new function.
6813         * d-lang.c (d_language_defn): Initialise new field.
6814         * f-lang.c (f_is_string_type_p): New function.
6815         (f_language_defn): Initialise new field.
6816         * go-lang.c (go_is_string_type_p): New function.
6817         (go_language_defn): Initialise new field.
6818         * language.c (default_is_string_type_p): New function.
6819         (unknown_language_defn): Initialise new field.
6820         (auto_language_defn): Initialise new field.
6821         * language.h (struct language_defn) <la_is_string_type_p>: New
6822         member variable.
6823         (default_is_string_type_p): Declare new function.
6824         * m2-lang.c (m2_language_defn): Initialise new field.
6825         * objc-lang.c (objc_language_defn): Initialise new field.
6826         * opencl-lang.c (opencl_language_defn): Initialise new field.
6827         * p-lang.c (pascal_is_string_type_p): New function.
6828         (pascal_language_defn): Initialise new field.
6829         * rust-lang.c (rust_is_string_type_p): New function.
6830         (rust_language_defn): Initialise new field.
6831
6832 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6833
6834         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6835         New field.
6836         * ada-lang.c (ada_language_defn): Initialise new field.
6837         * c-lang.c (c_language_defn): Likewise.
6838         (cplus_language_defn): Likewise.
6839         (asm_language_defn): Likewise.
6840         (minimal_language_defn): Likewise.
6841         * d-lang.c (d_language_defn): Likewise.
6842         * f-lang.c (f_language_defn): Likewise.
6843         * go-lang.c (go_language_defn): Likewise.
6844         * language.c (unknown_language_defn): Likewise.
6845         (auto_language_defn): Likewise.
6846         * m2-lang.c (m2_language_defn): Likewise.
6847         * objc-lang.c (objc_language_defn): Likewise.
6848         * opencl-lang.c (opencl_language_defn): Likewise.
6849         * p-lang.c (pascal_language_defn): Likewise.
6850         * rust-lang.c (rust_language_defn): Likewise.
6851
6852 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6853
6854         * ada-lang.c (ada_is_character_type): Change return type to bool.
6855         (ada_is_string_type): Likewise.
6856         * ada-lang.h (ada_is_character_type): Update declaration
6857         (ada_is_string_type): Likewise.
6858
6859 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6860
6861         Support style in 'frame|thread apply'
6862
6863         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6864         * record.c (record_start, record_stop): Update callers of
6865         execute_command_to_string with false.
6866         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6867         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6868         methods.
6869         (class string_file): New constructor with term_out parameter.
6870         Override methods term_out and can_emit_style_escape.  New member
6871         term_out.
6872         (class stdio_file): Override can_emit_style_escape.
6873         (class tee_file): Override term_out and can_emit_style_escape.
6874         * utils.h (can_emit_style_escape): Remove.
6875         * utils.c (can_emit_style_escape): Likewise.
6876         Update all callers of can_emit_style_escape (SOMESTREAM) to
6877         SOMESTREAM->can_emit_style_escape.
6878         * source-cache.c (source_cache::get_source_lines): Likewise.
6879         * stack.c (frame_apply_command_count): Call execute_command_to_string
6880         passing the term_out characteristic of the current gdb_stdout.
6881         * thread.c (thr_try_catch_cmd): Likewise.
6882         * top.c (execute_command_to_string): pass term_out parameter
6883         to construct the string_file for the command output.
6884         * ui-file.c (term_cli_styling): New function (most code moved
6885         from utils.c can_emit_style_escape).
6886         (string_file::string_file, string_file::can_emit_style_escape,
6887         stdio_file::can_emit_style_escape, tee_file::term_out,
6888         tee_file::can_emit_style_escape): New functions.
6889
6890 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6891
6892         * NEWS: Mention the new set|show may-call-functions.
6893         * infcall.c (may_call_functions_p): New variable.
6894         (show_may_call_functions_p): New function.
6895         (call_function_by_hand_dummy): Throws an error if not
6896         may-call-functions.
6897         (_initialize_infcall): Call add_setshow_boolean_cmd for
6898         may-call-functions.
6899
6900 2019-04-25  Keith Seitz  <keiths@redhat.com>
6901
6902         PR c++/24367
6903         * cp-support.c (inspect_type): Don't attempt substitutions
6904         of symbol with the same name.
6905
6906 2019-04-25  Tom Tromey  <tromey@adacore.com>
6907
6908         PR gdb/24475:
6909         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6910         static.
6911
6912 2019-04-25  Tom Tromey  <tromey@adacore.com>
6913
6914         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6915         rvalue reference.
6916         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6917         (gdb_xml_parser::parse): Use std::move.
6918         * python/python-internal.h (gdbpy_convert_exception): Take a const
6919         reference.
6920         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6921         std::move.
6922         * python/py-utils.c (gdbpy_convert_exception): Take a const
6923         reference.
6924         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6925         Use std::move.
6926         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6927         Use std::move.
6928         * mi/mi-main.c (mi_print_exception): Take a const reference.
6929         * main.c (handle_command_errors): Take a const reference.
6930         * linespec.c (parse_linespec): Use std::move.
6931         * infcall.c (run_inferior_call): Use std::move.
6932         (call_function_by_hand_dummy): Use std::move.
6933         * exec.c (try_open_exec_file): Use std::move.
6934         * exceptions.h (exception_print, exception_fprintf)
6935         (exception_print_same): Update.
6936         * exceptions.c (print_exception, exception_print)
6937         (exception_fprintf, exception_print_same): Change parameters to
6938         const reference.
6939         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6940         * common/new-op.c: Use std::move.
6941         * common/common-exceptions.h (struct gdb_exception): Add move
6942         constructor.
6943         (struct gdb_exception_error, struct gdb_exception_quit, struct
6944         gdb_quit_bad_alloc): Change constructor to move constructor.
6945         (throw_exception): Change parameter to rvalue reference.
6946         * common/common-exceptions.c (throw_exception): Take rvalue
6947         reference.
6948         * cli/cli-interp.c (safe_execute_command): Use std::move.
6949         * breakpoint.c (insert_bp_location, location_to_sals): Use
6950         std::move.
6951
6952 2019-04-25  Tom Tromey  <tromey@adacore.com>
6953
6954         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6955         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6956         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6957         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6958         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6959         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6960         guile/scm-value.c: Use unpack.
6961         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6962         gdbscm_gdb_exception.
6963         (gdbscm_throw_gdb_exception): Likewise.
6964         (struct gdbscm_gdb_exception): New.
6965         (unpack): New function.
6966         (gdbscm_wrap): Use unpack.
6967
6968 2019-04-25  Tom Tromey  <tromey@adacore.com>
6969
6970         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6971         (gdb_rl_callback_handler): Use std::move.
6972         * common/common-exceptions.h (struct gdb_exception): Add move
6973         assignment operator.
6974         (throw_exception_sjlj): Change "exception" to const reference.
6975         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6976         (throw_exception_sjlj): Change "exception" to const reference.
6977
6978 2019-04-25  Tom Tromey  <tromey@adacore.com>
6979
6980         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6981         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6982         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6983         Update.
6984         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6985         Update.
6986         * mi/mi-interp.c (mi_interp::exec): Update.
6987         * linespec.c (parse_linespec): Update.
6988         * infcall.c (run_inferior_call): Update.
6989         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6990         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6991         (gdbscm_lookup_global_symbol): Update.
6992         * guile/scm-param.c (gdbscm_parameter_value): Update.
6993         * guile/scm-frame.c (gdbscm_frame_read_register)
6994         (gdbscm_frame_read_var): Update.
6995         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6996         * exec.c (try_open_exec_file): Update.
6997         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6998         (gdb_rl_callback_handler): Update.
6999         * common/common-exceptions.h (exception_none): Don't declare.
7000         * common/common-exceptions.c (exception_none): Don't define.
7001         (struct catcher) <exception>: Update.
7002         * cli/cli-interp.c (safe_execute_command): Update.
7003         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7004
7005 2019-04-25  Ali Tamur  <tamur@google.com>
7006
7007         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7008         (read_attribute_value): Likewise.
7009         (dwarf2_read_addr_index): Update comment.
7010         (read_str_index): Add DW_FORM_strx.
7011         (dwarf2_string_attr): Likewise.
7012         (dwarf2_const_value_attr): Likewise.
7013         (dump_die_shallow): Likewise.
7014         (dwarf2_fetch_constant_bytes): Likewise.
7015         (skip_form_bytes): Likewise.
7016         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7017
7018 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7019
7020         PR corefiles/11608
7021         PR corefiles/18187
7022         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7023         OFFSET.  Verify if current mapping contains an ELF header.
7024         (linux_find_memory_regions_full): Adjust call to
7025         dump_mapping_p.
7026
7027 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7028             Kang Li <kanglictf@gmail.com>
7029
7030         PR gdb/21600
7031
7032         * dwarf2-frame.c (read_initial_length): Be consistent about using
7033         unsigned representation of length.
7034         (decode_frame_entry_1): Likewise.  Check for wraparound of
7035         end pointer as well as buffer overflow.
7036
7037 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7038
7039         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7040         "vq".
7041
7042 2019-04-24  Tom Tromey  <tromey@adacore.com>
7043
7044         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7045
7046 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7047
7048         * s12z-tdep.c (s12z_unwind_pc): Delete.
7049         (s12z_unwind_sp): Delete.
7050         (s12z_gdbarch_init): Don't register deleted functions with
7051         gdbarch.
7052
7053 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7054
7055         * rl78-tdep.c (rl78_unwind_sp): Delete.
7056         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7057
7058 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7059
7060         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7061         (xstormy16_unwind_pc): Delete.
7062         (xstormy16_dummy_id): Delete.
7063         (xstormy16_gdbarch_init): Don't register deleted functions with
7064         gdbarch.
7065
7066 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7067
7068         * vax-tdep.c (vax_unwind_pc): Delete.
7069         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7070
7071 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7072
7073         * v850-tdep.c (v850_unwind_sp): Delete.
7074         (v850_unwind_pc): Delete.
7075         (v850_dummy_id): Delete.
7076         (v850_gdbarch_init): Don't register deleted functions with
7077         gdbarch.
7078
7079 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7080
7081         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7082         (tilegx_unwind_pc): Delete.
7083         (tilegx_unwind_dummy_id): Delete.
7084         (tilegx_gdbarch_init): Don't register deleted functions with
7085         gdbarch.
7086
7087 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7088
7089         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7090         (tic6x_dummy_id): Delete.
7091         (tic6x_gdbarch_init): Don't register deleted functions with
7092         gdbarch.
7093
7094 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7095
7096         * sparc-tdep.c (sparc_unwind_pc): Delete.
7097         (sparc32_gdbarch_init): Don't register deleted function with
7098         gdbarch.
7099
7100 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7101
7102         * sh-tdep.c (sh_unwind_sp): Delete.
7103         (sh_unwind_pc): Delete.
7104         (sh_dummy_id): Delete.
7105         (sh_gdbarch_init): Don't register deleted functions with
7106         gdbarch.
7107
7108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7109
7110         * score-tdep.c (score_unwind_sp): Delete.
7111         (score_unwind_pc): Delete.
7112         (score_dummy_id): Delete.
7113         (score_gdbarch_init): Don't register deleted functions with
7114         gdbarch.
7115
7116 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7117
7118         * rx-tdep.c (rx_unwind_pc): Delete.
7119         (rx_unwind_sp): Delete.
7120         (rx_dummy_id): Delete.
7121         (rx_gdbarch_init): Don't register deleted functions with
7122         gdbarch.  Update comment.
7123
7124 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7125
7126         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7127         (rs6000_dummy_id): Delete.
7128         (rs6000_gdbarch_init): Don't register deleted functions with
7129         gdbarch.
7130
7131 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7132
7133         * or1k-tdep.c (or1k_dummy_id): Delete.
7134         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7135
7136 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7137
7138         * nios2-tdep.c (nios2_dummy_id): Delete.
7139         (nios2_unwind_sp): Delete.
7140         (nios2_gdbarch_init): Don't register deleted functions with
7141         gdbarch.
7142
7143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7144
7145         * nds32-tdep.c (nds32_dummy_id): Delete.
7146         (nds32_unwind_pc): Delete.
7147         (nds32_unwind_sp): Delete.
7148         (nds32_gdbarch_init): Don't register deleted functions with
7149         gdbarch.
7150
7151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7152
7153         * msp430-tdep.c (msp430_unwind_pc): Delete.
7154         (msp430_unwind_sp): Delete.
7155         (msp430_dummy_id): Delete.
7156         (msp430_gdbarch_init): Don't register deleted functions with
7157         gdbarch.
7158
7159 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7160
7161         * moxie-tdep.c (moxie_unwind_sp): Delete.
7162         (moxie_unwind_pc): Delete.
7163         (moxie_dummy_id): Delete.
7164         (moxie_gdbarch_init): Don't register deleted functions with
7165         gdbarch.
7166
7167 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7168
7169         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7170         (mn10300_unwind_pc): Delete.
7171         (mn10300_unwind_sp): Delete.
7172         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7173         mn10300_unwind_sp.
7174         (mn10300_frame_unwind_init): Don't register deleted functions with
7175         gdbarch.
7176
7177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7178
7179         * mep-tdep.c (mep_unwind_pc): Delete.
7180         (mep_unwind_sp): Delete.
7181         (mep_dummy_id): Delete.
7182         (mep_gdbarch_init): Don't register deleted functions with
7183         gdbarch.
7184
7185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7186
7187         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7188         (m68hc11_unwind_sp): Delete.
7189         (m68hc11_gdbarch_init): Don't register deleted functions with
7190         gdbarch.
7191
7192 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7193
7194         * m32r-tdep.c (m32r_unwind_sp): Delete.
7195         (m32r_unwind_pc): Delete.
7196         (m32r_dummy_id): Delete.
7197         (m32r_gdbarch_init): Don't register deleted functions with
7198         gdbarch.
7199
7200 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7201
7202         * m32c-tdep.c (m32c_unwind_pc): Delete.
7203         (m32c_unwind_sp): Delete.
7204         (m32c_dummy_id): Delete.
7205         (m32c_gdbarch_init): Don't register deleted functions with
7206         gdbarch.
7207
7208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7209
7210         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7211         (lm32_unwind_pc): Delete.
7212         (lm32_dummy_id): Delete.
7213         (lm32_gdbarch_init): Don't register deleted functions with
7214         gdbarch.
7215
7216 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7217
7218         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7219         (iq2000_unwind_pc): Delete.
7220         (iq2000_dummy_id): Delete.
7221         (iq2000_gdbarch_init): Don't register deleted functions with
7222         gdbarch.
7223
7224 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7225
7226         * nds32-tdep.c (nds32_type_align): Delete.
7227         (nds32_push_dummy_call): Use type_align instead.
7228
7229 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7230
7231         * arm-tdep.c (arm_type_align): Only handle vector override case.
7232         (arm_push_dummy_call): Use type_align.
7233         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7234
7235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7236
7237         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7238         case.
7239         (pass_on_stack): Use type_align.
7240         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7241         function.
7242
7243 2019-04-23  Tom Tromey  <tromey@adacore.com>
7244
7245         * dwarf2read.c (line_header::file_name_at): Remove unused
7246         overload.
7247
7248 2019-04-23  Tom de Vries  <tdevries@suse.de>
7249
7250         PR gdb/24438
7251         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7252         invocation.
7253
7254
7255 2019-03-27  Ali Tamur  <tamur@google.com>
7256
7257         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7258         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7259         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7260         (dwarf_expr_context::get_addr_index): Likewise
7261         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7262         (symbol_needs_eval_context::get_addr_index): Likewise
7263         (disassemble_dwarf_expression): Add DW_OP_addrx
7264         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7265         (read_cutu_die_from_dwo): Update comment
7266         (skip_one_die): Add DW_FORM_addrx
7267         (read_attribute_value): Likewise
7268         (var_decode_location): Add DW_OP_addrx
7269         (dwarf2_const_value_attr): Add DW_FORM_addrx
7270         (dump_die_shallow): Likewise
7271         (dwarf2_fetch_constant_bytes): Likewise
7272         (decode_locdesc): Add DW_OP_addrx
7273         (skip_form_bytes): Add DW_FORM_addrx
7274
7275 2019-04-22  Ali Tamur  <tamur@google.com>
7276
7277         * MAINTAINERS (Write After Approval): Add self.
7278
7279 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7280
7281         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7282         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7283         (open_symbol_file_object): Likewise.
7284         (svr4_default_sos): Add info parameter.
7285         (svr4_read_so_list): Likewise.
7286         (svr4_current_sos_direct): Adjust functions calls to pass down
7287         info.
7288         (svr4_current_sos_1): Add info parameter.
7289         (svr4_current_sos): Call get_svr4_info, pass info down to
7290         svr4_current_sos_1.
7291         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7292         get_svr4_info.
7293         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7294         get_svr4_info.
7295         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7296         to get_svr4_info.
7297         (probes_table_remove_objfile_probes): Likewise.
7298         (register_solib_event_probe): Add info parameter.
7299         (solist_update_incremental): Pass info parameter down to
7300         svr4_read_so_list.
7301         (disable_probes_interface): Add info parameter.
7302         (svr4_handle_solib_event): Pass current_program_space to
7303         get_svr4_info.  Adjust disable_probes_interface cleanup.
7304         (svr4_create_probe_breakpoints): Add info parameter, pass it
7305         down to register_solib_event_probe.
7306         (svr4_create_solib_event_breakpoints): Add info parameter,
7307         pass it down to svr4_create_probe_breakpoints.
7308         (enable_break): Pass info down to
7309         svr4_create_solib_event_breakpoints.
7310         (svr4_solib_create_inferior_hook): Pass current_program_space to
7311         get_svr4_info.
7312         (svr4_clear_solib): Likewise.
7313
7314 2019-04-22  Pedro Alves  <palves@redhat.com>
7315
7316         * solib-svr4.c (svr4_free_objfile_observer): New.
7317         (probe_and_action::objfile): New field.
7318         (probes_table_htab_remove_objfile_probes)
7319         (probes_table_remove_objfile_probes): New functions.
7320         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7321         in the new probe_and_action.  Don't store the probe in 'lookup'.
7322         (svr4_create_probe_breakpoints): Pass objfile to
7323         register_solib_event_probe.
7324         (_initialize_svr4_solib): Register a free_objfile observer.
7325
7326 2019-04-19  Tom Tromey  <tom@tromey.com>
7327
7328         * common/queue.h: Remove.
7329
7330 2019-04-19  Tom Tromey  <tom@tromey.com>
7331
7332         * event-loop.c: Don't include "common/queue.h".
7333
7334 2019-04-19  Tom Tromey  <tom@tromey.com>
7335
7336         * remote.c (remote_target): Use delete.
7337         * remote-notif.h: Include <list>, not "common/queue.h".
7338         (notif_client_p): Remove typedef.
7339         (remote_notif_state): Add constructor, destructor, initializer.
7340         <notif_queue>: Now a std::list.
7341         (remote_notif_state_xfree): Don't declare.
7342         * remote-notif.c (remote_notif_process, handle_notification)
7343         (remote_notif_state_allocate): Update.
7344         (~remote_notif_state): Rename from remote_notif_state_xfree.
7345
7346 2019-04-19  Tom Tromey  <tom@tromey.com>
7347
7348         * symfile.c (reread_symbols): Update.
7349         * objfiles.c (objfile_register_static_link)
7350         (objfile_lookup_static_link): Update
7351         (~objfile) Don't delete static_links.
7352         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7353
7354 2019-04-19  Tom Tromey  <tom@tromey.com>
7355
7356         * type-stack.h (struct type_stack) <insert>: Constify string.
7357         * type-stack.c (type_stack::insert): Constify string.
7358         * gdbtypes.h (lookup_template_type): Update.
7359         (address_space_name_to_int): Update.
7360         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7361         const.
7362         (lookup_template_type): Make name const.
7363         * c-exp.y: Update rules.
7364         (lex_one_token, classify_name, classify_inner_name)
7365         (c_print_token): Update.
7366         * p-exp.y: Update rules.
7367         (yylex): Update.
7368         * f-exp.y: Update rules.
7369         (yylex): Update.
7370         * d-exp.y: Update rules.
7371         (lex_one_token, classify_name, classify_inner_name): Update.
7372         * parse.c (write_dollar_variable, copy_name): Return std::string.
7373         * parser-defs.h (copy_name): Change return type.
7374         * m2-exp.y: Update rules.
7375         (yylex): Update.
7376         * go-exp.y (lex_one_token): Update.
7377         Update rules.
7378         (classify_unsafe_function, classify_packaged_name)
7379         (classify_name, yylex): Update.
7380
7381 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7382
7383         * configure.ac: add --enable-source-highlight switch.
7384         * configure: Regenerate.
7385         * top.c (print_gdb_version): plumb --enable-source-highlight
7386         status to "show configuration".
7387
7388 2019-04-19  Tom Tromey  <tromey@adacore.com>
7389
7390         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7391         Check ADA_TYPE_P.
7392         (empty_record, ada_template_to_fixed_record_type_1)
7393         (template_to_static_fixed_type)
7394         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7395         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7396         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7397         macros.
7398
7399 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7400
7401         PR symtab/24423:
7402         * source.c (print_source_lines_base): Advance "iter" when a
7403         control character is seen.
7404
7405 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7406
7407         * inferior.h (struct infcall_suspend_state_deleter):
7408         Catch exception in destructor to avoid crash.
7409
7410 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7411
7412         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7413         close to the add_com "shell".
7414
7415 2019-04-18  Tom Tromey  <tromey@adacore.com>
7416
7417         * process-stratum-target.h (class process_stratum_target)
7418         <stratum>: Add "final".
7419
7420 2019-04-17  Tom Tromey  <tromey@adacore.com>
7421
7422         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7423         against nullptr before use.
7424
7425 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7426
7427         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7428
7429 2019-04-17  Jim Wilson  <jimw@sifive.com>
7430             Andrew Burgess  <andrew.burgess@embecosm.com>
7431
7432         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7433         code read might fail, assume 4-byte breakpoint in that case.
7434
7435 2019-04-15  Leszek Swirski  <leszeks@google.com>
7436
7437         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7438         rather than a hand-rolled POD check when checking for forced MEMORY
7439         classification.
7440
7441 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7442
7443         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7444         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7445         function.
7446         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7447         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7448         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7449         declaration.
7450
7451 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7452
7453         * aarch64-linux-nat.c
7454         (aarch64_linux_nat_target::thread_architecture): Add override.
7455         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7456         each VQ.
7457
7458 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7459
7460         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7461
7462 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7463
7464         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7465         target types of size 96-bits, add some additional comments, and
7466         check that the builtin type we found was the correct size.
7467
7468 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7469
7470         * utils.c (prompt_for_continue): Don't restore the styling at the
7471         end, as applied_style has the wrong value.  This fixes styling in
7472         long lists of file names that are interrupted by the "Continue?"
7473         prompt.
7474
7475 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7476
7477         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7478         * c-lang.c (c_language_defn): Likewise.
7479         (cplus_language_defn): Likewise.
7480         (asm_language_defn): Likewise.
7481         (minimal_language_defn): Likewise.
7482         * d-lang.c (d_language_defn): Likewise.
7483         * f-lang.c (f_language_defn): Likewise.
7484         * go-lang.c (go_language_defn): Likewise.
7485         * language.c (unknown_language_defn): Likewise.
7486         (auto_language_defn): Likewise.
7487         * language.h (struct language_defn): Remove la_magic field.
7488         (LANG_MAGIC): Delete.
7489         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7490         * objc-lang.c (objc_language_defn): Likewise.
7491         * opencl-lang.c (opencl_language_defn): Likewise.
7492         * p-lang.c (pascal_language_defn): Likewise.
7493         * rust-lang.c (rust_language_defn): Likewise.
7494
7495 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7496
7497         * riscv-tdep.c (riscv_type_align): New function.
7498         (riscv_type_alignment): Delete.
7499         (riscv_arg_location): Use 'type_align'.
7500         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7501
7502 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7503
7504         * gdbtypes.c (type_align): A struct with no non-static fields also
7505         has alignment of 1.
7506
7507 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7508
7509         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7510         component to 0.
7511         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7512         member.
7513         (riscv_struct_info::analyse): New implementation using new
7514         analyse_inner member function.
7515         (riscv_struct_info::field_offset): New member function.
7516         (riscv_struct_info::m_offsets): New member variable.
7517         (riscv_struct_info::analyse_inner): New private member function,
7518         takes the old implementation of riscv_struct_info::analyse but
7519         extended to track field offsets.
7520         (riscv_call_arg_struct): Update the struct folding special cases
7521         to handle cases where empty C++ structs, which are non-zero
7522         length, are found.
7523         (riscv_arg_location): Initialise the length of each location, a
7524         non-zero length now indicates the location is in use.
7525         (riscv_push_dummy_call): Allow for the first location having a
7526         non-zero offset when setting up arguments.
7527         (riscv_return_value): Likewise, but for return values.
7528
7529 2019-04-11  Tom Tromey  <tromey@adacore.com>
7530
7531         * utils.c (internal_vproblem): Make "msg" const.
7532
7533 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7534
7535         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7536         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7537         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7538         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7539
7540 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7541
7542         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7543         function.
7544         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7545         of amd64_collect_native_gregset.
7546         (amd64_linux_nat_target::store_registers): Likewise.
7547
7548 2019-04-10  Tom Tromey  <tom@tromey.com>
7549
7550         * symtab.c (lookup_global_symbol_from_objfile)
7551         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7552         * objfiles.h (class separate_debug_iterator): New.
7553         (class separate_debug_range): New.
7554         (struct objfile) <separate_debug_objfiles>: New method.
7555         (objfile_separate_debug_iterate): Don't declare.
7556         * objfiles.c (separate_debug_iterator::operator++): Rename from
7557         objfile_separate_debug_iterate.
7558         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7559         iterator.
7560         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7561         iterator.
7562
7563 2019-04-10  Tom Tromey  <tom@tromey.com>
7564
7565         * symfile.c (reread_symbols): Remove old comment.
7566         * objfiles.c (free_all_objfiles): Fix a typo.
7567
7568 2019-04-10  Tom Tromey  <tom@tromey.com>
7569
7570         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7571         * minsyms.c (lookup_minimal_symbol): Use foreach.
7572         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7573         (lookup_minimal_symbol_solib_trampoline): Likewise.
7574         * symfile.c (reread_symbols): Use foreach.
7575
7576 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7577             Tom Tromey  <tromey@adacore.com>
7578
7579         PR rust/24414:
7580         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7581         (rust_lex_int_test): Change "value" to be LONGEST.
7582         (rust_lex_tests): Add test for long integer literal.
7583
7584 2019-04-09  Tom Tromey  <tromey@adacore.com>
7585
7586         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7587         to bool.
7588         (extended_remote_target::attach): Update.
7589         (remote_target::remote_notice_new_inferior): Update.
7590         (remote_target::add_current_inferior_and_thread): Update.
7591         * inferior.c (exit_inferior_1): Use "false".
7592         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7593
7594 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7595
7596         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7597         the "start" command.
7598
7599 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7600
7601         * python/py-inferior.c (infpy_thread_from_thread_handle):
7602         Adjust comments to reflect renaming of thread_from_thread_handle
7603         to thread_from_handle.  Adjust keywords.  Fix type error message.
7604         (inferior_object_methods): Add thread_from_handle.  Retain
7605         thread_from_thread_handle, but mark it as deprecated.
7606
7607 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7608
7609         * gdbthread.h (find_thread_by_handle): Revise declaration.
7610         * thread.c (find_thread_by_handle): Likewise.  Adjust
7611         implementation too.
7612         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7613         support for buffer objects as handles.
7614
7615 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7616
7617         * python/py-infthread.c (thpy_thread_handle): New function.
7618         (thread_object_methods): Register thpy_thread_handle.
7619
7620 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7621
7622         * gdbthread.h (thread_to_thread_handle): Declare.
7623         * thread.c (gdbtypes.h): Include.
7624         (thread_to_thread_handle): New function.
7625
7626         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7627         (target_thread_info_to_thread_handle): Declare.
7628         * target.c (target_thread_info_to_thread_handle): New function.
7629         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7630         * target-delegates.c: Regenerate.
7631
7632         * linux-thread-db.c (class thread_db_target): Add method
7633         thread_info_to_thread_handle.
7634         (thread_db_target::thread_info_to_thread_handle): Define.
7635         * remote.c (class remote_target): Add new method
7636         thread_info_to_thread_handle.
7637         (remote_target::thread_info_to_thread_handle): Define.
7638
7639 2019-04-08  Pedro Alves  <palves@redhat.com>
7640
7641         * common/common-exceptions.c (throw_exception): Don't create
7642         named object to throw; throw directly.
7643         (throw_it): Likewise.  Don't initialize gdb_exception::message
7644         here, with new; pass FMT and AP to the ctor instead.
7645         * common/common-exceptions.h: Include <string>.
7646         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7647         const char *, va_list)): New ctor.  Use std::make_shared.
7648         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7649         errors)): Delete.
7650         (gdb_exception_error::gdb_exception_error(enum errors, const char
7651         *, va_list)): New.
7652         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7653         Add assertion.
7654         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7655         errors)): Delete.
7656         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7657         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7658         Add assertion.
7659
7660 2019-04-08  Tom Tromey  <tom@tromey.com>
7661
7662         * valops.c (value_rtti_indirect_type): Replace throw_exception
7663         with throw.
7664         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7665         with throw.
7666         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7667         throw.
7668         * target.c (target_translate_tls_address): Replace throw_exception
7669         with throw.
7670         * stack.c (frame_apply_command_count): Replace throw_exception
7671         with throw.
7672         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7673         throw.
7674         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7675         with throw.
7676         * rs6000-tdep.c (rs6000_frame_cache)
7677         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7678         * remote.c: Replace throw_exception with throw.
7679         * record-full.c (record_full_message, record_full_wait_1)
7680         (record_full_restore): Replace throw_exception with throw.
7681         * record-btrace.c:
7682         (get_thread_current_frame_id, record_btrace_start_replaying)
7683         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7684         (cmd_record_btrace_start): Replace throw_exception with throw.
7685         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7686         throw.
7687         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7688         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7689         * linespec.c:
7690         (find_linespec_symbols): Replace throw_exception with throw.
7691         * infrun.c (displaced_step_prepare, resume): Replace
7692         throw_exception with throw.
7693         * infcmd.c (post_create_inferior): Replace throw_exception with
7694         throw.
7695         * inf-loop.c (inferior_event_handler): Replace throw_exception
7696         with throw.
7697         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7698         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7699         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7700         (get_prev_frame_always, get_frame_pc_if_available)
7701         (get_frame_address_in_block_if_available, get_frame_language):
7702         Replace throw_exception with throw.
7703         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7704         throw_exception with throw.
7705         * eval.c (fetch_subexp_value, evaluate_var_value)
7706         (evaluate_funcall, evaluate_subexp_standard): Replace
7707         throw_exception with throw.
7708         * dwarf2loc.c (call_site_find_chain)
7709         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7710         Replace throw_exception with throw.
7711         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7712         with throw.
7713         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7714         throw.
7715         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7716         * completer.c (complete_line_internal): Replace throw_exception
7717         with throw.
7718         * compile/compile-object-run.c (compile_object_run): Replace
7719         throw_exception with throw.
7720         * cli/cli-script.c (process_next_line): Replace throw_exception
7721         with throw.
7722         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7723         (btrace_enable, btrace_maint_update_pt_packets): Replace
7724         throw_exception with throw.
7725         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7726         throw_exception with throw.
7727         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7728         throw_exception with throw.
7729         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7730         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7731         * aarch64-tdep.c (aarch64_make_prologue_cache)
7732         (aarch64_make_stub_cache): Replace throw_exception with throw.
7733
7734 2019-04-08  Tom Tromey  <tom@tromey.com>
7735
7736         * common/common-exceptions.c (throw_exception): Rename from
7737         throw_exception_cxx.  Remove old copy.  Make argument const.
7738         (throw_it): Create and throw exception objects directly.
7739         * common/common-exceptions.h (throw_exception): Make argument
7740         const.
7741         (struct gdb_exception_error): Add constructor.
7742         (struct gdb_exception_quit): Add constructor.
7743
7744 2019-04-08  Tom Tromey  <tom@tromey.com>
7745
7746         * common/common-exceptions.h (exception_rethrow): Don't declare.
7747         (TRY_SJLJ): Update comment.
7748         (TRY, CATCH, END_CATCH): Remove.
7749         * common/common-exceptions.c (exception_rethrow): Remove.
7750
7751 2019-04-08  Tom Tromey  <tom@tromey.com>
7752
7753         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7754         Remove.
7755         (gdb_exception_error): Rename from
7756         gdb_exception_RETURN_MASK_ERROR.
7757         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7758         (gdb_quit_bad_alloc): Update.
7759         * aarch64-tdep.c: Update.
7760         * ada-lang.c: Update.
7761         * ada-typeprint.c: Update.
7762         * ada-valprint.c: Update.
7763         * amd64-tdep.c: Update.
7764         * arch-utils.c: Update.
7765         * break-catch-throw.c: Update.
7766         * breakpoint.c: Update.
7767         * btrace.c: Update.
7768         * c-varobj.c: Update.
7769         * cli/cli-cmds.c: Update.
7770         * cli/cli-interp.c: Update.
7771         * cli/cli-script.c: Update.
7772         * common/common-exceptions.c: Update.
7773         * common/new-op.c: Update.
7774         * common/selftest.c: Update.
7775         * compile/compile-c-symbols.c: Update.
7776         * compile/compile-cplus-symbols.c: Update.
7777         * compile/compile-object-load.c: Update.
7778         * compile/compile-object-run.c: Update.
7779         * completer.c: Update.
7780         * corelow.c: Update.
7781         * cp-abi.c: Update.
7782         * cp-support.c: Update.
7783         * cp-valprint.c: Update.
7784         * darwin-nat.c: Update.
7785         * disasm-selftests.c: Update.
7786         * dtrace-probe.c: Update.
7787         * dwarf-index-cache.c: Update.
7788         * dwarf-index-write.c: Update.
7789         * dwarf2-frame-tailcall.c: Update.
7790         * dwarf2-frame.c: Update.
7791         * dwarf2loc.c: Update.
7792         * dwarf2read.c: Update.
7793         * eval.c: Update.
7794         * event-loop.c: Update.
7795         * event-top.c: Update.
7796         * exec.c: Update.
7797         * f-valprint.c: Update.
7798         * fbsd-tdep.c: Update.
7799         * frame-unwind.c: Update.
7800         * frame.c: Update.
7801         * gdbtypes.c: Update.
7802         * gnu-v3-abi.c: Update.
7803         * guile/guile-internal.h: Update.
7804         * guile/scm-block.c: Update.
7805         * guile/scm-breakpoint.c: Update.
7806         * guile/scm-cmd.c: Update.
7807         * guile/scm-disasm.c: Update.
7808         * guile/scm-frame.c: Update.
7809         * guile/scm-lazy-string.c: Update.
7810         * guile/scm-math.c: Update.
7811         * guile/scm-param.c: Update.
7812         * guile/scm-ports.c: Update.
7813         * guile/scm-pretty-print.c: Update.
7814         * guile/scm-symbol.c: Update.
7815         * guile/scm-symtab.c: Update.
7816         * guile/scm-type.c: Update.
7817         * guile/scm-value.c: Update.
7818         * i386-linux-tdep.c: Update.
7819         * i386-tdep.c: Update.
7820         * inf-loop.c: Update.
7821         * infcall.c: Update.
7822         * infcmd.c: Update.
7823         * infrun.c: Update.
7824         * jit.c: Update.
7825         * language.c: Update.
7826         * linespec.c: Update.
7827         * linux-fork.c: Update.
7828         * linux-nat.c: Update.
7829         * linux-tdep.c: Update.
7830         * linux-thread-db.c: Update.
7831         * main.c: Update.
7832         * mi/mi-cmd-break.c: Update.
7833         * mi/mi-cmd-stack.c: Update.
7834         * mi/mi-interp.c: Update.
7835         * mi/mi-main.c: Update.
7836         * objc-lang.c: Update.
7837         * p-valprint.c: Update.
7838         * parse.c: Update.
7839         * ppc-linux-tdep.c: Update.
7840         * printcmd.c: Update.
7841         * python/py-arch.c: Update.
7842         * python/py-breakpoint.c: Update.
7843         * python/py-cmd.c: Update.
7844         * python/py-finishbreakpoint.c: Update.
7845         * python/py-frame.c: Update.
7846         * python/py-framefilter.c: Update.
7847         * python/py-gdb-readline.c: Update.
7848         * python/py-inferior.c: Update.
7849         * python/py-infthread.c: Update.
7850         * python/py-lazy-string.c: Update.
7851         * python/py-linetable.c: Update.
7852         * python/py-objfile.c: Update.
7853         * python/py-param.c: Update.
7854         * python/py-prettyprint.c: Update.
7855         * python/py-progspace.c: Update.
7856         * python/py-record-btrace.c: Update.
7857         * python/py-record.c: Update.
7858         * python/py-symbol.c: Update.
7859         * python/py-type.c: Update.
7860         * python/py-unwind.c: Update.
7861         * python/py-utils.c: Update.
7862         * python/py-value.c: Update.
7863         * python/python.c: Update.
7864         * record-btrace.c: Update.
7865         * record-full.c: Update.
7866         * remote-fileio.c: Update.
7867         * remote.c: Update.
7868         * riscv-tdep.c: Update.
7869         * rs6000-aix-tdep.c: Update.
7870         * rs6000-tdep.c: Update.
7871         * rust-exp.y: Update.
7872         * rust-lang.c: Update.
7873         * s390-tdep.c: Update.
7874         * selftest-arch.c: Update.
7875         * solib-dsbt.c: Update.
7876         * solib-frv.c: Update.
7877         * solib-spu.c: Update.
7878         * solib-svr4.c: Update.
7879         * solib.c: Update.
7880         * sparc64-linux-tdep.c: Update.
7881         * stack.c: Update.
7882         * symfile-mem.c: Update.
7883         * symmisc.c: Update.
7884         * target.c: Update.
7885         * thread.c: Update.
7886         * top.c: Update.
7887         * tracefile-tfile.c: Update.
7888         * tui/tui.c: Update.
7889         * typeprint.c: Update.
7890         * unittests/cli-utils-selftests.c: Update.
7891         * unittests/parse-connection-spec-selftests.c: Update.
7892         * valops.c: Update.
7893         * valprint.c: Update.
7894         * value.c: Update.
7895         * varobj.c: Update.
7896         * windows-nat.c: Update.
7897         * x86-linux-nat.c: Update.
7898         * xml-support.c: Update.
7899
7900 2019-04-08  Tom Tromey  <tom@tromey.com>
7901
7902         * xml-support.c: Use C++ exception handling.
7903         * x86-linux-nat.c: Use C++ exception handling.
7904         * windows-nat.c: Use C++ exception handling.
7905         * varobj.c: Use C++ exception handling.
7906         * value.c: Use C++ exception handling.
7907         * valprint.c: Use C++ exception handling.
7908         * valops.c: Use C++ exception handling.
7909         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7910         handling.
7911         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7912         * typeprint.c: Use C++ exception handling.
7913         * tui/tui.c: Use C++ exception handling.
7914         * tracefile-tfile.c: Use C++ exception handling.
7915         * top.c: Use C++ exception handling.
7916         * thread.c: Use C++ exception handling.
7917         * target.c: Use C++ exception handling.
7918         * symmisc.c: Use C++ exception handling.
7919         * symfile-mem.c: Use C++ exception handling.
7920         * stack.c: Use C++ exception handling.
7921         * sparc64-linux-tdep.c: Use C++ exception handling.
7922         * solib.c: Use C++ exception handling.
7923         * solib-svr4.c: Use C++ exception handling.
7924         * solib-spu.c: Use C++ exception handling.
7925         * solib-frv.c: Use C++ exception handling.
7926         * solib-dsbt.c: Use C++ exception handling.
7927         * selftest-arch.c: Use C++ exception handling.
7928         * s390-tdep.c: Use C++ exception handling.
7929         * rust-lang.c: Use C++ exception handling.
7930         * rust-exp.y: Use C++ exception handling.
7931         * rs6000-tdep.c: Use C++ exception handling.
7932         * rs6000-aix-tdep.c: Use C++ exception handling.
7933         * riscv-tdep.c: Use C++ exception handling.
7934         * remote.c: Use C++ exception handling.
7935         * remote-fileio.c: Use C++ exception handling.
7936         * record-full.c: Use C++ exception handling.
7937         * record-btrace.c: Use C++ exception handling.
7938         * python/python.c: Use C++ exception handling.
7939         * python/py-value.c: Use C++ exception handling.
7940         * python/py-utils.c: Use C++ exception handling.
7941         * python/py-unwind.c: Use C++ exception handling.
7942         * python/py-type.c: Use C++ exception handling.
7943         * python/py-symbol.c: Use C++ exception handling.
7944         * python/py-record.c: Use C++ exception handling.
7945         * python/py-record-btrace.c: Use C++ exception handling.
7946         * python/py-progspace.c: Use C++ exception handling.
7947         * python/py-prettyprint.c: Use C++ exception handling.
7948         * python/py-param.c: Use C++ exception handling.
7949         * python/py-objfile.c: Use C++ exception handling.
7950         * python/py-linetable.c: Use C++ exception handling.
7951         * python/py-lazy-string.c: Use C++ exception handling.
7952         * python/py-infthread.c: Use C++ exception handling.
7953         * python/py-inferior.c: Use C++ exception handling.
7954         * python/py-gdb-readline.c: Use C++ exception handling.
7955         * python/py-framefilter.c: Use C++ exception handling.
7956         * python/py-frame.c: Use C++ exception handling.
7957         * python/py-finishbreakpoint.c: Use C++ exception handling.
7958         * python/py-cmd.c: Use C++ exception handling.
7959         * python/py-breakpoint.c: Use C++ exception handling.
7960         * python/py-arch.c: Use C++ exception handling.
7961         * printcmd.c: Use C++ exception handling.
7962         * ppc-linux-tdep.c: Use C++ exception handling.
7963         * parse.c: Use C++ exception handling.
7964         * p-valprint.c: Use C++ exception handling.
7965         * objc-lang.c: Use C++ exception handling.
7966         * mi/mi-main.c: Use C++ exception handling.
7967         * mi/mi-interp.c: Use C++ exception handling.
7968         * mi/mi-cmd-stack.c: Use C++ exception handling.
7969         * mi/mi-cmd-break.c: Use C++ exception handling.
7970         * main.c: Use C++ exception handling.
7971         * linux-thread-db.c: Use C++ exception handling.
7972         * linux-tdep.c: Use C++ exception handling.
7973         * linux-nat.c: Use C++ exception handling.
7974         * linux-fork.c: Use C++ exception handling.
7975         * linespec.c: Use C++ exception handling.
7976         * language.c: Use C++ exception handling.
7977         * jit.c: Use C++ exception handling.
7978         * infrun.c: Use C++ exception handling.
7979         * infcmd.c: Use C++ exception handling.
7980         * infcall.c: Use C++ exception handling.
7981         * inf-loop.c: Use C++ exception handling.
7982         * i386-tdep.c: Use C++ exception handling.
7983         * i386-linux-tdep.c: Use C++ exception handling.
7984         * guile/scm-value.c: Use C++ exception handling.
7985         * guile/scm-type.c: Use C++ exception handling.
7986         * guile/scm-symtab.c: Use C++ exception handling.
7987         * guile/scm-symbol.c: Use C++ exception handling.
7988         * guile/scm-pretty-print.c: Use C++ exception handling.
7989         * guile/scm-ports.c: Use C++ exception handling.
7990         * guile/scm-param.c: Use C++ exception handling.
7991         * guile/scm-math.c: Use C++ exception handling.
7992         * guile/scm-lazy-string.c: Use C++ exception handling.
7993         * guile/scm-frame.c: Use C++ exception handling.
7994         * guile/scm-disasm.c: Use C++ exception handling.
7995         * guile/scm-cmd.c: Use C++ exception handling.
7996         * guile/scm-breakpoint.c: Use C++ exception handling.
7997         * guile/scm-block.c: Use C++ exception handling.
7998         * guile/guile-internal.h: Use C++ exception handling.
7999         * gnu-v3-abi.c: Use C++ exception handling.
8000         * gdbtypes.c: Use C++ exception handling.
8001         * frame.c: Use C++ exception handling.
8002         * frame-unwind.c: Use C++ exception handling.
8003         * fbsd-tdep.c: Use C++ exception handling.
8004         * f-valprint.c: Use C++ exception handling.
8005         * exec.c: Use C++ exception handling.
8006         * event-top.c: Use C++ exception handling.
8007         * event-loop.c: Use C++ exception handling.
8008         * eval.c: Use C++ exception handling.
8009         * dwarf2read.c: Use C++ exception handling.
8010         * dwarf2loc.c: Use C++ exception handling.
8011         * dwarf2-frame.c: Use C++ exception handling.
8012         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8013         * dwarf-index-write.c: Use C++ exception handling.
8014         * dwarf-index-cache.c: Use C++ exception handling.
8015         * dtrace-probe.c: Use C++ exception handling.
8016         * disasm-selftests.c: Use C++ exception handling.
8017         * darwin-nat.c: Use C++ exception handling.
8018         * cp-valprint.c: Use C++ exception handling.
8019         * cp-support.c: Use C++ exception handling.
8020         * cp-abi.c: Use C++ exception handling.
8021         * corelow.c: Use C++ exception handling.
8022         * completer.c: Use C++ exception handling.
8023         * compile/compile-object-run.c: Use C++ exception handling.
8024         * compile/compile-object-load.c: Use C++ exception handling.
8025         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8026         * compile/compile-c-symbols.c: Use C++ exception handling.
8027         * common/selftest.c: Use C++ exception handling.
8028         * common/new-op.c: Use C++ exception handling.
8029         * cli/cli-script.c: Use C++ exception handling.
8030         * cli/cli-interp.c: Use C++ exception handling.
8031         * cli/cli-cmds.c: Use C++ exception handling.
8032         * c-varobj.c: Use C++ exception handling.
8033         * btrace.c: Use C++ exception handling.
8034         * breakpoint.c: Use C++ exception handling.
8035         * break-catch-throw.c: Use C++ exception handling.
8036         * arch-utils.c: Use C++ exception handling.
8037         * amd64-tdep.c: Use C++ exception handling.
8038         * ada-valprint.c: Use C++ exception handling.
8039         * ada-typeprint.c: Use C++ exception handling.
8040         * ada-lang.c: Use C++ exception handling.
8041         * aarch64-tdep.c: Use C++ exception handling.
8042
8043 2019-04-08  Tom Tromey  <tom@tromey.com>
8044
8045         * xml-support.c (gdb_xml_parser::parse): Update.
8046         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8047         * value.c (show_convenience): Update.
8048         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8049         (test_parse_flags_qcs): Update.
8050         * thread.c (thr_try_catch_cmd): Update.
8051         * target.c (target_translate_tls_address): Update.
8052         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8053         (info_frame_command_core, frame_apply_command_count): Update.
8054         * rust-exp.y (rust_lex_exception_test): Update.
8055         * riscv-tdep.c (riscv_print_one_register_info): Update.
8056         * remote.c (remote_target::enable_btrace): Update.
8057         * record-btrace.c (record_btrace_enable_warn): Update.
8058         * python/py-utils.c (gdbpy_convert_exception): Update.
8059         * printcmd.c (do_one_display, print_variable_and_value): Update.
8060         * mi/mi-main.c (mi_print_exception): Update.
8061         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8062         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8063         * linux-nat.c (linux_nat_target::attach): Update.
8064         * linux-fork.c (class scoped_switch_fork_info): Update.
8065         * infrun.c (displaced_step_prepare): Update.
8066         * infcall.c (call_function_by_hand_dummy): Update.
8067         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8068         * gnu-v3-abi.c (print_one_vtable): Update.
8069         * frame.c (get_prev_frame_always): Update.
8070         * f-valprint.c (info_common_command_for_block): Update.
8071         * exec.c (try_open_exec_file): Update.
8072         * exceptions.c (print_exception, exception_print)
8073         (exception_fprintf, exception_print_same): Update.
8074         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8075         * dwarf-index-cache.c (index_cache::store)
8076         (index_cache::lookup_gdb_index): Update.
8077         * darwin-nat.c (maybe_cache_shell): Update.
8078         * cp-valprint.c (cp_print_value_fields): Update.
8079         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8080         (gcc_cplus_symbol_address): Update.
8081         * compile/compile-c-symbols.c (gcc_convert_symbol)
8082         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8083         * common/selftest.c: Update.
8084         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8085         a std::string.
8086         (exception_try_scope_entry, exception_try_scope_exit): Don't
8087         declare.
8088         (struct exception_try_scope): Remove.
8089         (TRY): Don't use exception_try_scope.
8090         (struct gdb_exception): Add constructor, operator=.
8091         <what>: New method.
8092         (struct gdb_exception_RETURN_MASK_ALL)
8093         (struct gdb_exception_RETURN_MASK_ERROR)
8094         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8095         (struct gdb_quit_bad_alloc): Update.
8096         * common/common-exceptions.c (exception_none): Change
8097         initializer.
8098         (struct catcher) <state, exception>: Initialize inline.
8099         <prev>: Remove member.
8100         (current_catcher): Remove.
8101         (catchers): New global.
8102         (exceptions_state_mc_init): Simplify.
8103         (catcher_pop): Remove.
8104         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8105         (try_scope_depth, exception_try_scope_entry)
8106         (exception_try_scope_exit): Remove.
8107         (throw_exception_sjlj): Update.
8108         (exception_messages, exception_messages_size): Remove.
8109         (throw_it): Simplify.
8110         (gdb_exception_sliced_copy): Remove.
8111         (throw_exception_cxx): Update.
8112         * cli/cli-script.c (script_from_file): Update.
8113         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8114         Update.
8115         * ada-valprint.c (ada_val_print): Update.
8116         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8117         (create_excep_cond_exprs): Update.
8118
8119 2019-04-08  Tom Tromey  <tom@tromey.com>
8120
8121         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8122         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8123         (TRY, CATCH, END_CATCH): Remove some definitions.
8124         * common/common-exceptions.c: Don't use GDB_XCPT.
8125         (catcher_list_size): Remove.
8126         (throw_exception, throw_it): Simplify.
8127
8128 2019-04-05  Tom Tromey  <tom@tromey.com>
8129
8130         Revert the header-sorting patch.
8131         * ft32-tdep.c: Revert.
8132         * frv-tdep.c: Revert.
8133         * frv-linux-tdep.c: Revert.
8134         * frame.c: Revert.
8135         * frame-unwind.c: Revert.
8136         * frame-base.c: Revert.
8137         * fork-child.c: Revert.
8138         * findvar.c: Revert.
8139         * findcmd.c: Revert.
8140         * filesystem.c: Revert.
8141         * filename-seen-cache.h: Revert.
8142         * filename-seen-cache.c: Revert.
8143         * fbsd-tdep.c: Revert.
8144         * fbsd-nat.h: Revert.
8145         * fbsd-nat.c: Revert.
8146         * f-valprint.c: Revert.
8147         * f-typeprint.c: Revert.
8148         * f-lang.c: Revert.
8149         * extension.h: Revert.
8150         * extension.c: Revert.
8151         * extension-priv.h: Revert.
8152         * expprint.c: Revert.
8153         * exec.h: Revert.
8154         * exec.c: Revert.
8155         * exceptions.c: Revert.
8156         * event-top.c: Revert.
8157         * event-loop.c: Revert.
8158         * eval.c: Revert.
8159         * elfread.c: Revert.
8160         * dwarf2read.h: Revert.
8161         * dwarf2read.c: Revert.
8162         * dwarf2loc.c: Revert.
8163         * dwarf2expr.h: Revert.
8164         * dwarf2expr.c: Revert.
8165         * dwarf2-frame.c: Revert.
8166         * dwarf2-frame-tailcall.c: Revert.
8167         * dwarf-index-write.h: Revert.
8168         * dwarf-index-write.c: Revert.
8169         * dwarf-index-common.c: Revert.
8170         * dwarf-index-cache.h: Revert.
8171         * dwarf-index-cache.c: Revert.
8172         * dummy-frame.c: Revert.
8173         * dtrace-probe.c: Revert.
8174         * disasm.h: Revert.
8175         * disasm.c: Revert.
8176         * disasm-selftests.c: Revert.
8177         * dictionary.c: Revert.
8178         * dicos-tdep.c: Revert.
8179         * demangle.c: Revert.
8180         * dcache.h: Revert.
8181         * dcache.c: Revert.
8182         * darwin-nat.h: Revert.
8183         * darwin-nat.c: Revert.
8184         * darwin-nat-info.c: Revert.
8185         * d-valprint.c: Revert.
8186         * d-namespace.c: Revert.
8187         * d-lang.c: Revert.
8188         * ctf.c: Revert.
8189         * csky-tdep.c: Revert.
8190         * csky-linux-tdep.c: Revert.
8191         * cris-tdep.c: Revert.
8192         * cris-linux-tdep.c: Revert.
8193         * cp-valprint.c: Revert.
8194         * cp-support.c: Revert.
8195         * cp-namespace.c: Revert.
8196         * cp-abi.c: Revert.
8197         * corelow.c: Revert.
8198         * corefile.c: Revert.
8199         * continuations.c: Revert.
8200         * completer.h: Revert.
8201         * completer.c: Revert.
8202         * complaints.c: Revert.
8203         * coffread.c: Revert.
8204         * coff-pe-read.c: Revert.
8205         * cli-out.h: Revert.
8206         * cli-out.c: Revert.
8207         * charset.c: Revert.
8208         * c-varobj.c: Revert.
8209         * c-valprint.c: Revert.
8210         * c-typeprint.c: Revert.
8211         * c-lang.c: Revert.
8212         * buildsym.c: Revert.
8213         * buildsym-legacy.c: Revert.
8214         * build-id.h: Revert.
8215         * build-id.c: Revert.
8216         * btrace.c: Revert.
8217         * bsd-uthread.c: Revert.
8218         * breakpoint.h: Revert.
8219         * breakpoint.c: Revert.
8220         * break-catch-throw.c: Revert.
8221         * break-catch-syscall.c: Revert.
8222         * break-catch-sig.c: Revert.
8223         * blockframe.c: Revert.
8224         * block.c: Revert.
8225         * bfin-tdep.c: Revert.
8226         * bfin-linux-tdep.c: Revert.
8227         * bfd-target.c: Revert.
8228         * bcache.c: Revert.
8229         * ax-general.c: Revert.
8230         * ax-gdb.h: Revert.
8231         * ax-gdb.c: Revert.
8232         * avr-tdep.c: Revert.
8233         * auxv.c: Revert.
8234         * auto-load.c: Revert.
8235         * arm-wince-tdep.c: Revert.
8236         * arm-tdep.c: Revert.
8237         * arm-symbian-tdep.c: Revert.
8238         * arm-pikeos-tdep.c: Revert.
8239         * arm-obsd-tdep.c: Revert.
8240         * arm-nbsd-tdep.c: Revert.
8241         * arm-nbsd-nat.c: Revert.
8242         * arm-linux-tdep.c: Revert.
8243         * arm-linux-nat.c: Revert.
8244         * arm-fbsd-tdep.c: Revert.
8245         * arm-fbsd-nat.c: Revert.
8246         * arm-bsd-tdep.c: Revert.
8247         * arch-utils.c: Revert.
8248         * arc-tdep.c: Revert.
8249         * arc-newlib-tdep.c: Revert.
8250         * annotate.h: Revert.
8251         * annotate.c: Revert.
8252         * amd64-windows-tdep.c: Revert.
8253         * amd64-windows-nat.c: Revert.
8254         * amd64-tdep.c: Revert.
8255         * amd64-sol2-tdep.c: Revert.
8256         * amd64-obsd-tdep.c: Revert.
8257         * amd64-obsd-nat.c: Revert.
8258         * amd64-nbsd-tdep.c: Revert.
8259         * amd64-nbsd-nat.c: Revert.
8260         * amd64-nat.c: Revert.
8261         * amd64-linux-tdep.c: Revert.
8262         * amd64-linux-nat.c: Revert.
8263         * amd64-fbsd-tdep.c: Revert.
8264         * amd64-fbsd-nat.c: Revert.
8265         * amd64-dicos-tdep.c: Revert.
8266         * amd64-darwin-tdep.c: Revert.
8267         * amd64-bsd-nat.c: Revert.
8268         * alpha-tdep.c: Revert.
8269         * alpha-obsd-tdep.c: Revert.
8270         * alpha-nbsd-tdep.c: Revert.
8271         * alpha-mdebug-tdep.c: Revert.
8272         * alpha-linux-tdep.c: Revert.
8273         * alpha-linux-nat.c: Revert.
8274         * alpha-bsd-tdep.c: Revert.
8275         * alpha-bsd-nat.c: Revert.
8276         * aix-thread.c: Revert.
8277         * agent.c: Revert.
8278         * addrmap.c: Revert.
8279         * ada-varobj.c: Revert.
8280         * ada-valprint.c: Revert.
8281         * ada-typeprint.c: Revert.
8282         * ada-tasks.c: Revert.
8283         * ada-lang.c: Revert.
8284         * aarch64-tdep.c: Revert.
8285         * aarch64-ravenscar-thread.c: Revert.
8286         * aarch64-newlib-tdep.c: Revert.
8287         * aarch64-linux-tdep.c: Revert.
8288         * aarch64-linux-nat.c: Revert.
8289         * aarch64-fbsd-tdep.c: Revert.
8290         * aarch64-fbsd-nat.c: Revert.
8291         * aarch32-linux-nat.c: Revert.
8292
8293 2019-04-05  Tom Tromey  <tom@tromey.com>
8294
8295         * ft32-tdep.c: Sort headers.
8296         * frv-tdep.c: Sort headers.
8297         * frv-linux-tdep.c: Sort headers.
8298         * frame.c: Sort headers.
8299         * frame-unwind.c: Sort headers.
8300         * frame-base.c: Sort headers.
8301         * fork-child.c: Sort headers.
8302         * findvar.c: Sort headers.
8303         * findcmd.c: Sort headers.
8304         * filesystem.c: Sort headers.
8305         * filename-seen-cache.h: Sort headers.
8306         * filename-seen-cache.c: Sort headers.
8307         * fbsd-tdep.c: Sort headers.
8308         * fbsd-nat.h: Sort headers.
8309         * fbsd-nat.c: Sort headers.
8310         * f-valprint.c: Sort headers.
8311         * f-typeprint.c: Sort headers.
8312         * f-lang.c: Sort headers.
8313         * extension.h: Sort headers.
8314         * extension.c: Sort headers.
8315         * extension-priv.h: Sort headers.
8316         * expprint.c: Sort headers.
8317         * exec.h: Sort headers.
8318         * exec.c: Sort headers.
8319         * exceptions.c: Sort headers.
8320         * event-top.c: Sort headers.
8321         * event-loop.c: Sort headers.
8322         * eval.c: Sort headers.
8323         * elfread.c: Sort headers.
8324         * dwarf2read.h: Sort headers.
8325         * dwarf2read.c: Sort headers.
8326         * dwarf2loc.c: Sort headers.
8327         * dwarf2expr.h: Sort headers.
8328         * dwarf2expr.c: Sort headers.
8329         * dwarf2-frame.c: Sort headers.
8330         * dwarf2-frame-tailcall.c: Sort headers.
8331         * dwarf-index-write.h: Sort headers.
8332         * dwarf-index-write.c: Sort headers.
8333         * dwarf-index-common.c: Sort headers.
8334         * dwarf-index-cache.h: Sort headers.
8335         * dwarf-index-cache.c: Sort headers.
8336         * dummy-frame.c: Sort headers.
8337         * dtrace-probe.c: Sort headers.
8338         * disasm.h: Sort headers.
8339         * disasm.c: Sort headers.
8340         * disasm-selftests.c: Sort headers.
8341         * dictionary.c: Sort headers.
8342         * dicos-tdep.c: Sort headers.
8343         * demangle.c: Sort headers.
8344         * dcache.h: Sort headers.
8345         * dcache.c: Sort headers.
8346         * darwin-nat.h: Sort headers.
8347         * darwin-nat.c: Sort headers.
8348         * darwin-nat-info.c: Sort headers.
8349         * d-valprint.c: Sort headers.
8350         * d-namespace.c: Sort headers.
8351         * d-lang.c: Sort headers.
8352         * ctf.c: Sort headers.
8353         * csky-tdep.c: Sort headers.
8354         * csky-linux-tdep.c: Sort headers.
8355         * cris-tdep.c: Sort headers.
8356         * cris-linux-tdep.c: Sort headers.
8357         * cp-valprint.c: Sort headers.
8358         * cp-support.c: Sort headers.
8359         * cp-namespace.c: Sort headers.
8360         * cp-abi.c: Sort headers.
8361         * corelow.c: Sort headers.
8362         * corefile.c: Sort headers.
8363         * continuations.c: Sort headers.
8364         * completer.h: Sort headers.
8365         * completer.c: Sort headers.
8366         * complaints.c: Sort headers.
8367         * coffread.c: Sort headers.
8368         * coff-pe-read.c: Sort headers.
8369         * cli-out.h: Sort headers.
8370         * cli-out.c: Sort headers.
8371         * charset.c: Sort headers.
8372         * c-varobj.c: Sort headers.
8373         * c-valprint.c: Sort headers.
8374         * c-typeprint.c: Sort headers.
8375         * c-lang.c: Sort headers.
8376         * buildsym.c: Sort headers.
8377         * buildsym-legacy.c: Sort headers.
8378         * build-id.h: Sort headers.
8379         * build-id.c: Sort headers.
8380         * btrace.c: Sort headers.
8381         * bsd-uthread.c: Sort headers.
8382         * breakpoint.h: Sort headers.
8383         * breakpoint.c: Sort headers.
8384         * break-catch-throw.c: Sort headers.
8385         * break-catch-syscall.c: Sort headers.
8386         * break-catch-sig.c: Sort headers.
8387         * blockframe.c: Sort headers.
8388         * block.c: Sort headers.
8389         * bfin-tdep.c: Sort headers.
8390         * bfin-linux-tdep.c: Sort headers.
8391         * bfd-target.c: Sort headers.
8392         * bcache.c: Sort headers.
8393         * ax-general.c: Sort headers.
8394         * ax-gdb.h: Sort headers.
8395         * ax-gdb.c: Sort headers.
8396         * avr-tdep.c: Sort headers.
8397         * auxv.c: Sort headers.
8398         * auto-load.c: Sort headers.
8399         * arm-wince-tdep.c: Sort headers.
8400         * arm-tdep.c: Sort headers.
8401         * arm-symbian-tdep.c: Sort headers.
8402         * arm-pikeos-tdep.c: Sort headers.
8403         * arm-obsd-tdep.c: Sort headers.
8404         * arm-nbsd-tdep.c: Sort headers.
8405         * arm-nbsd-nat.c: Sort headers.
8406         * arm-linux-tdep.c: Sort headers.
8407         * arm-linux-nat.c: Sort headers.
8408         * arm-fbsd-tdep.c: Sort headers.
8409         * arm-fbsd-nat.c: Sort headers.
8410         * arm-bsd-tdep.c: Sort headers.
8411         * arch-utils.c: Sort headers.
8412         * arc-tdep.c: Sort headers.
8413         * arc-newlib-tdep.c: Sort headers.
8414         * annotate.h: Sort headers.
8415         * annotate.c: Sort headers.
8416         * amd64-windows-tdep.c: Sort headers.
8417         * amd64-windows-nat.c: Sort headers.
8418         * amd64-tdep.c: Sort headers.
8419         * amd64-sol2-tdep.c: Sort headers.
8420         * amd64-obsd-tdep.c: Sort headers.
8421         * amd64-obsd-nat.c: Sort headers.
8422         * amd64-nbsd-tdep.c: Sort headers.
8423         * amd64-nbsd-nat.c: Sort headers.
8424         * amd64-nat.c: Sort headers.
8425         * amd64-linux-tdep.c: Sort headers.
8426         * amd64-linux-nat.c: Sort headers.
8427         * amd64-fbsd-tdep.c: Sort headers.
8428         * amd64-fbsd-nat.c: Sort headers.
8429         * amd64-dicos-tdep.c: Sort headers.
8430         * amd64-darwin-tdep.c: Sort headers.
8431         * amd64-bsd-nat.c: Sort headers.
8432         * alpha-tdep.c: Sort headers.
8433         * alpha-obsd-tdep.c: Sort headers.
8434         * alpha-nbsd-tdep.c: Sort headers.
8435         * alpha-mdebug-tdep.c: Sort headers.
8436         * alpha-linux-tdep.c: Sort headers.
8437         * alpha-linux-nat.c: Sort headers.
8438         * alpha-bsd-tdep.c: Sort headers.
8439         * alpha-bsd-nat.c: Sort headers.
8440         * aix-thread.c: Sort headers.
8441         * agent.c: Sort headers.
8442         * addrmap.c: Sort headers.
8443         * ada-varobj.c: Sort headers.
8444         * ada-valprint.c: Sort headers.
8445         * ada-typeprint.c: Sort headers.
8446         * ada-tasks.c: Sort headers.
8447         * ada-lang.c: Sort headers.
8448         * aarch64-tdep.c: Sort headers.
8449         * aarch64-ravenscar-thread.c: Sort headers.
8450         * aarch64-newlib-tdep.c: Sort headers.
8451         * aarch64-linux-tdep.c: Sort headers.
8452         * aarch64-linux-nat.c: Sort headers.
8453         * aarch64-fbsd-tdep.c: Sort headers.
8454         * aarch64-fbsd-nat.c: Sort headers.
8455         * aarch32-linux-nat.c: Sort headers.
8456
8457 2019-04-04  Tom Tromey  <tom@tromey.com>
8458
8459         * varobj.c (varobj_create): Update.
8460         * rust-exp.y (struct rust_parser) <update_innermost_block,
8461         lookup_symbol>: New methods.
8462         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8463         Rename.
8464         (rust_parser::rust_lookup_type)
8465         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8466         * printcmd.c (display_command, do_one_display): Update.
8467         * parser-defs.h (struct parser_state) <parser_state>: Add
8468         "tracker" parameter.
8469         (block_tracker): New member.
8470         (class innermost_block_tracker) <innermost_block_tracker>: Add
8471         "types" parameter.
8472         <reset>: Remove method.
8473         (innermost_block): Don't declare.
8474         (null_post_parser): Update.
8475         * parse.c (innermost_block): Remove global.
8476         (write_dollar_variable): Update.
8477         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8478         Remove "tracker_types" parameter.
8479         (parse_expression): Add "tracker" parameter.
8480         (parse_expression_for_completion): Update.
8481         (null_post_parser): Add "tracker" parameter.
8482         * p-exp.y: Update rules.
8483         * m2-exp.y: Update rules.
8484         * language.h (struct language_defn) <la_post_parser>: Add
8485         "tracker" parameter.
8486         * go-exp.y: Update rules.
8487         * f-exp.y: Update rules.
8488         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8489         parameter.
8490         * d-exp.y: Update rules.
8491         * c-exp.y: Update rules.
8492         * breakpoint.c (set_breakpoint_condition): Create an
8493         innermost_block_tracker.
8494         (watch_command_1): Likewise.
8495         * ada-lang.c (resolve): Add "tracker" parameter.
8496         (resolve_subexp): Likewise.
8497         * ada-exp.y (write_var_from_sym): Update.
8498
8499 2019-04-04  Tom Tromey  <tom@tromey.com>
8500
8501         * type-stack.h: New file.
8502         * type-stack.c: New file.
8503         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8504         type-stack.h.
8505         (insert_into_type_stack, insert_type, push_type, push_type_int)
8506         (insert_type_address_space, pop_type, pop_type_int)
8507         (pop_typelist, pop_type_stack, append_type_stack)
8508         (push_type_stack, get_type_stack, push_typelist)
8509         (follow_type_instance_flags, follow_types): Don't declare.
8510         * parse.c (type_stack): Remove global.
8511         (parse_exp_in_context): Update.
8512         (insert_into_type_stack, insert_type, push_type, push_type_int)
8513         (insert_type_address_space, pop_type, pop_type_int)
8514         (pop_typelist, pop_type_stack, append_type_stack)
8515         (push_type_stack, get_type_stack, push_typelist)
8516         (follow_type_instance_flags, follow_types): Remove (moved to
8517         type-stack.c).
8518         * f-exp.y (type_stack): New global.
8519         Update rules.
8520         (push_kind_type, f_parse): Update.
8521         * d-exp.y (type_stack): New global.
8522         Update rules.
8523         (d_parse): Update.
8524         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8525         Update rules.
8526         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8527         (HFILES_NO_SRCDIR): Add type-stack.h.
8528
8529 2019-04-04  Tom Tromey  <tom@tromey.com>
8530
8531         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8532         (rust_parser::convert_ast_to_expression, rust_parse)
8533         (rust_lex_test_completion, rust_lex_tests): Update.
8534         * parser-defs.h (struct expr_completion_state): New.
8535         (struct parser_state) <parser_state>: Add completion parameter.
8536         <mark_struct_expression, mark_completion_tag>: New methods.
8537         <parse_completion, m_completion_state>: New members.
8538         (prefixify_expression, null_post_parser): Update.
8539         (mark_struct_expression, mark_completion_tag): Don't declare.
8540         * parse.c (parse_completion, expout_last_struct)
8541         (expout_tag_completion_type, expout_completion_name): Remove
8542         globals.
8543         (parser_state::mark_struct_expression)
8544         (parser_state::mark_completion_tag): Now methods.
8545         (prefixify_expression): Add last_struct parameter.
8546         (prefixify_subexp): Likewise.
8547         (parse_exp_1): Update.
8548         (parse_exp_in_context): Add cstate parameter.  Update.
8549         (parse_expression_for_completion): Create an
8550         expr_completion_state.
8551         (null_post_parser): Add "completion" parameter.
8552         * p-exp.y: Update rules.
8553         (yylex): Update.
8554         * language.h (struct language_defn) <la_post_parser>: Add
8555         "completing" parameter.
8556         * go-exp.y: Update rules.
8557         (lex_one_token): Update.
8558         * expression.h (parse_completion): Don't declare.
8559         * d-exp.y: Update rules.
8560         (lex_one_token): Update rules.
8561         * c-exp.y: Update rules.
8562         (lex_one_token): Update.
8563         * ada-lang.c (resolve): Add "parse_completion" parameter.
8564         (resolve_subexp): Likewise.
8565         (ada_resolve_function): Likewise.
8566
8567 2019-04-04  Tom Tromey  <tom@tromey.com>
8568
8569         * parser-defs.h (struct parser_state) <start_arglist,
8570         end_arglist>: New methods.
8571         <arglist_len, m_funcall_chain>: New members.
8572         (arglist_len, start_arglist, end_arglist): Don't declare.
8573         * parse.c (arglist_len, funcall_chain): Remove global.
8574         (start_arglist, end_arglist): Remove functions.
8575         (parse_exp_in_context): Update.
8576         * p-exp.y: Update rules.
8577         * m2-exp.y: Update rules.
8578         * go-exp.y: Update rules.
8579         * f-exp.y: Update rules.
8580         * d-exp.y: Update rules.
8581         * c-exp.y: Update rules.
8582
8583 2019-04-04  Tom Tromey  <tom@tromey.com>
8584
8585         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8586         lex_operator, push_back>: New methods.
8587         Update all rules.
8588         (rust_parser::lex_hex, lex_escape): Rename and update.
8589         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8590         (rust_parser::lex_operator): Rename and update.
8591         (rust_parser::lex_number, rustyylex, rustyyerror)
8592         (rust_lex_test_init, rust_lex_test_sequence)
8593         (rust_lex_test_push_back, rust_lex_tests): Update.
8594         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8595         parameter.
8596         <lexptr, prev_lexptr>: New members.
8597         (lexptr, prev_lexptr): Don't declare.
8598         * parse.c (lexptr, prev_lexptr): Remove globals.
8599         (parse_exp_in_context): Update.
8600         * p-exp.y (yylex, yyerror): Update.
8601         * m2-exp.y (parse_number, yylex, yyerror): Update.
8602         * go-exp.y (lex_one_token, yyerror): Update.
8603         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8604         * d-exp.y (lex_one_token, yyerror): Update.
8605         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8606         (lex_one_token, yyerror): Update.
8607         * ada-lex.l (YY_INPUT): Update.
8608         (rewind_to_char): Update.
8609         * ada-exp.y (yyerror): Update.
8610
8611 2019-04-04  Tom Tromey  <tom@tromey.com>
8612
8613         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8614         * parser-defs.h (struct parser_state) <parser_state>: Add new
8615         parameter.
8616         <comma_terminates>: New member.
8617         (comma_terminates): Don't declare global.
8618         * parse.c (comma_terminates): Remove global.
8619         (parse_exp_in_context): Update.
8620         * p-exp.y (yylex): Update.
8621         * m2-exp.y (yylex): Update.
8622         * go-exp.y (lex_one_token): Update.
8623         * f-exp.y (yylex): Update.
8624         * d-exp.y (lex_one_token): Update.
8625         * c-exp.y (lex_one_token): Update.
8626         * ada-lex.l: Update.
8627
8628 2019-04-04  Tom Tromey  <tom@tromey.com>
8629
8630         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8631         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8632         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8633         * parser-defs.h (paren_depth): Don't declare.
8634         * parse.c (paren_depth): Remove global.
8635         (parse_exp_in_context): Update.
8636         * p-exp.y (paren_depth): New global.
8637         (pascal_parse): Initialize it.
8638         * m2-exp.y (paren_depth): New global.
8639         (m2_parse): Initialize it.
8640         * go-exp.y (paren_depth): New global.
8641         (go_parse): Initialize it.
8642         * f-exp.y (paren_depth): New global.
8643         (f_parse): Initialize it.
8644         * d-exp.y (paren_depth): New global.
8645         (d_parse): Initialize it.
8646         * c-exp.y (paren_depth): New global.
8647         (c_parse): Initialize it.
8648         * ada-lex.l (paren_depth): New global.
8649         (lexer_init): Initialize it.
8650
8651 2019-04-04  Tom Tromey  <tom@tromey.com>
8652
8653         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8654         (rust_parser::convert_ast_to_type)
8655         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8656         * parser-defs.h (struct parser_state) <parser_state>: Add
8657         parameters.  Initialize new members.
8658         <expression_context_block, expression_context_pc>: New members.
8659         * parse.c (expression_context_block, expression_context_pc):
8660         Remove globals.
8661         (parse_exp_in_context): Update.
8662         * p-exp.y: Update all rules.
8663         (yylex): Update.
8664         * m2-exp.y: Update all rules.
8665         (yylex): Update.
8666         * go-exp.y (yylex): Update.
8667         * f-exp.y (yylex): Update.
8668         * d-exp.y: Update all rules.
8669         (yylex): Update.
8670         * c-exp.y: Update all rules.
8671         (lex_one_token, classify_name, yylex, c_parse): Update.
8672         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8673
8674 2019-04-04  Tom Tromey  <tom@tromey.com>
8675
8676         * gdbarch.h, gdbarch.c: Rebuild.
8677         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8678         * stap-probe.h:
8679         (struct stap_parse_info): Replace "parser_state" with
8680         "expr_builder".
8681         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8682         (parser_state): New class.
8683         * parse.c (expr_builder): Rename.
8684         (expr_builder::release): Rename.
8685         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8686         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8687         (write_exp_elt_longcst, write_exp_elt_floatcst)
8688         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8689         (write_exp_string_vector, write_exp_bitstring)
8690         (write_exp_msymbol, mark_struct_expression)
8691         (write_dollar_variable)
8692         (insert_type_address_space, increase_expout_size): Replace
8693         "parser_state" with "expr_builder".
8694         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8695         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8696         "parser_state" with "expr_builder".
8697
8698 2019-04-04  Tom Tromey  <tom@tromey.com>
8699
8700         * rust-exp.y: Replace "parse_language" with method call.
8701         * p-exp.y:
8702         (yylex): Replace "parse_language" with method call.
8703         * m2-exp.y:
8704         (yylex): Replace "parse_language" with method call.
8705         * go-exp.y (classify_name): Replace "parse_language" with method
8706         call.
8707         * f-exp.y (yylex): Replace "parse_language" with method call.
8708         * d-exp.y (lex_one_token): Replace "parse_language" with method
8709         call.
8710         * c-exp.y:
8711         (lex_one_token, classify_name, yylex): Replace "parse_language"
8712         with method call.
8713         * ada-exp.y (find_primitive_type, type_char)
8714         (type_system_address): Replace "parse_language" with method call.
8715
8716 2019-04-04  Tom Tromey  <tom@tromey.com>
8717
8718         * rust-exp.y: Replace "parse_gdbarch" with method call.
8719         * parse.c (write_dollar_variable, insert_type_address_space):
8720         Replace "parse_gdbarch" with method call.
8721         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8722         call.
8723         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8724         call.
8725         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8726         "parse_gdbarch" with method call.
8727         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8728         with method call.
8729         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8730         "parse_gdbarch" with method call.
8731         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8732         "parse_gdbarch" with method call.
8733         * c-exp.y (parse_type, parse_number, classify_name): Replace
8734         "parse_gdbarch" with method call.
8735         * ada-lex.l: Replace "parse_gdbarch" with method call.
8736         * ada-exp.y (parse_type, find_primitive_type, type_char)
8737         (type_system_address): Replace "parse_gdbarch" with method call.
8738
8739 2019-04-04  Tom Tromey  <tom@tromey.com>
8740
8741         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8742         * stap-probe.c (stap_parse_argument): Update.
8743         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8744         initial_size parameter.
8745         * rust-exp.y (rust_lex_tests): Update.
8746         * parse.c (parser_state): Update.
8747         (parse_exp_in_context): Update.
8748         * parser-defs.h (struct parser_state) <parser_state>: Remove
8749         "initial_size" parameter.
8750
8751 2019-04-04  Tom Tromey  <tom@tromey.com>
8752
8753         * parser-defs.h (increase_expout_size): Don't declare.
8754         * parse.c (increase_expout_size): Now static.
8755
8756 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8757
8758         * gnu-nat.c (gnu_nat_target::wait): Fix
8759         target_waitstatus_to_string call.
8760
8761 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8762
8763         * eval.c (evaluate_subexp_standard): Handle internal functions
8764         during Fortran function call handling.
8765
8766 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8767
8768         * NEWS: Mention new internal functions.
8769         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8770         (read_base_type): Use dwarf2_init_complex_target_type.
8771         * value.c (creal_internal_fn): New function.
8772         (cimag_internal_fn): New function.
8773         (_initialize_values): Register new internal functions.
8774
8775 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8776
8777         * infrun.c (stop_all_threads): If debug_infrun, always
8778         trace the wait status after wait_one, using
8779         target_waitstatus_to_string and target_pid_to_str.
8780         (handle_inferior_event): Replace various trace of
8781         wait status kind by a single trace.
8782         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8783         wait status kind image by target_waitstatus_to_string.
8784         * target/waitstatus.c (target_waitstatus_to_string): Fix
8785         obsolete comment.
8786
8787 2019-04-01  Tom Tromey  <tromey@adacore.com>
8788
8789         PR symtab/23331:
8790         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8791
8792 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8793             Pedro Alves  <palves@redhat.com>
8794
8795         * top.c (quit_force): Call 'finalize_values'.
8796         * value.c (finalize_values): New function.
8797         * value.h (finalize_values): Declare.
8798
8799 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8800
8801         * NEWS: Announce $_gdb_major and $_gdb_minor.
8802
8803         * top.c (init_gdb_version_vars): New function.
8804         (gdb_init): Call init_gdb_version_vars.
8805
8806 2019-03-29  Tom Tromey  <tromey@adacore.com>
8807
8808         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8809         help text.  Remove dead code.
8810
8811 2019-03-29  Keith Seitz  <keiths@redhat.com>
8812
8813         From Siddhesh Poyarekar:
8814         * f-lang.h (f77_get_upperbound): Return LONGEST.
8815         (f77_get_lowerbound): Likewise.
8816         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8817         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8818         print them.
8819         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8820         plongest to format print it.
8821         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8822         (f77_get_upperbound): Likewise.
8823         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8824         LOWER_BOUND to LONGEST.
8825         (f77_create_arrayprint_offset_tbl): Likewise.
8826
8827 2019-03-29  Keith Seitz  <keiths@redhat.com>
8828
8829         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8830         %s/pulongest for TYPE_LENGTH instead of %d in format
8831         strings.
8832         * ada-typerint.c (ada_print_type): Likewise.
8833         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8834         * compile/compile-c-support.c (generate_register_struct): Likewise.
8835         * gdbtypes.c (recursive_dump_type): Likewise.
8836         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8837         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8838         instead of %d in format strings.
8839         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8840         to std::min to ULONGEST.
8841         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8842         instead of %d in format strings.
8843         * tracepoint.c (info_scope_command): Likewise.
8844         * typeprint.c (print_offset_data::update)
8845         (print_offset_data::finish): Likewise.
8846         * xtensa-tdep.c (xtensa_store_return_value)
8847         (xtensa_push_dummy_call): Likewise.
8848
8849 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8850
8851         * windows-nat.c (display_selector): Fixed format specifications
8852         for 64-bit Cygwin.
8853
8854 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8855
8856         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8857
8858 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8859
8860         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8861         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8862         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8863         (nios2_linux_init_abi): Install it.
8864
8865 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8866
8867         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8868
8869 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8870
8871         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8872
8873 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8874             Tom Tromey  <tromey@adacore.com>
8875
8876         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8877
8878 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8879
8880         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8881         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8882         method to compute the bounds of range types. Also print "[evaluated]"
8883         if the bounds' values come from a dynamic evaluation.
8884
8885 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8886
8887         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8888         whitespace when pretty printing is on.
8889
8890 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8891
8892         * ppc-linux-nat.c: Add include.
8893
8894 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8895
8896         * NEWS: Mention AArch64 Pointer Authentication.
8897
8898 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8899
8900         * arm-linux-nat.c: Add include.
8901
8902 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8903
8904         * source-cache.c (source_cache::get_source_lines): Re-read
8905         fullname after calling open_source_file.
8906
8907 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8908
8909         * NEWS: Mention TLS support for FreeBSD.
8910
8911 2019-03-25  Tom Tromey  <tromey@adacore.com>
8912
8913         * minsyms.c (BUNCH_SIZE): Update comment.
8914         (~minimal_symbol_reader): Remove old comment.
8915         (compact_minimal_symbols): Update comment.
8916         (minimal_symbol_reader::install): Remove old comment.  Update
8917         other comments.
8918
8919 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8920
8921         * s390-linux-nat.c: Add include.
8922
8923 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8924
8925         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8926         Call linux_get_hwcap.
8927         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8928         Likewise.
8929         (aarch64_linux_get_hwcap): Remove function.
8930         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8931         declaration.
8932         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8933         linux_get_hwcap.
8934         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8935         * linux-tdep.c (linux_get_hwcap): Add function.
8936         (linux_get_hwcap2): Likewise.
8937         * linux-tdep.h (linux_get_hwcap): Add declaration.
8938         (linux_get_hwcap2): Likewise.
8939         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8940         (ppc_linux_get_hwcap2): Likewise.
8941         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8942         linux_get_hwcap.
8943         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8944         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8945         (ppc_linux_nat_target::read_description): Likewise.
8946         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8947         * s390-linux-nat.c: Likewise.
8948         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8949
8950 2019-03-24  Tom Tromey  <tom@tromey.com>
8951
8952         * ada-lang.c (standard_lookup): Simplify initialization.
8953         (ada_lookup_symbol_nonlocal): Simplify return.
8954         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8955         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8956         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8957         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8958         initialization.
8959         * solib.c (solib_global_lookup): Simplify.
8960         * symtab.c (null_block_symbol): Remove.
8961         (symbol_cache_lookup): Simplify returns.
8962         (lookup_language_this): Simplify returns.
8963         (lookup_symbol_aux): Simplify return.
8964         (lookup_local_symbol): Simplify returns.
8965         (lookup_global_symbol_from_objfile): Simplify return.
8966         (lookup_symbol_in_objfile_symtabs)
8967         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8968         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8969         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8970         * cp-namespace.c (cp_lookup_bare_symbol)
8971         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8972         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8973         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8974         (cp_lookup_symbol_via_imports): Simplify initialization.
8975         (find_symbol_in_baseclass): Likewise.
8976         * symtab.h (null_block_symbol): Remove.
8977         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8978         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8979         (d_lookup_symbol_module): Likewise.
8980         (find_symbol_in_baseclass): Simplify initialization.
8981
8982 2019-03-24  Tom Tromey  <tom@tromey.com>
8983
8984         * expression.h: Don't include symtab.h.
8985         (struct block): Forward declare.
8986
8987 2019-03-24  Tom Tromey  <tom@tromey.com>
8988
8989         * c-exp.y (typebase): Remove casts.
8990         * gdbtypes.c (lookup_unsigned_typename, )
8991         (lookup_signed_typename): Remove cast.
8992         * eval.c (parse_to_comma_and_eval): Remove cast.
8993         * parse.c (write_dollar_variable): Remove cast.
8994         * block.h (struct block) <superblock>: Now const.
8995         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8996         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8997         (map_block): Make "block" const.
8998         * symfile.h (struct quick_symbol_functions)
8999         <map_matching_symbols>: Constify block argument to "callback".
9000         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9001         const.
9002         (find_pc_sect_compunit_symtab): Make "b" const.
9003         (find_symbol_at_address): Likewise.
9004         (search_symbols): Likewise.
9005         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9006         (dw2_debug_names_lookup_symbol): Likewise.
9007         (dw2_map_matching_symbols): Update.
9008         * p-valprint.c (pascal_val_print): Remove "block".
9009         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9010         (aux_add_nonlocal_symbols): Make "block" const.
9011         (resolve_subexp): Remove cast.
9012         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9013         const.
9014         (iterate_over_file_blocks): Likewise.
9015         * f-exp.y (%union) <bval>: Remove.
9016         * coffread.c (patch_opaque_types): Make "b" const.
9017         * spu-tdep.c (spu_catch_start): Make "block" const.
9018         * c-valprint.c (print_unpacked_pointer): Remove "block".
9019         * symmisc.c (dump_symtab_1): Make "b" const.
9020         (block_depth): Make "block" const.
9021         * d-exp.y (%union) <bval>: Remove.
9022         * cp-support.h (cp_lookup_rtti_type): Update.
9023         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9024         * psymtab.c (psym_lookup_symbol): Make "block" const.
9025         (maintenance_check_psymtabs): Make "b" const.
9026         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9027         (enumerate_locals, enumerate_args): Update.
9028         * python/py-symtab.c (stpy_global_block): Make "block" const.
9029         (stpy_static_block): Likewise.
9030         * inline-frame.c (block_starting_point_at): Make "new_block"
9031         const.
9032         * block.c (find_block_in_blockvector): Make return type const.
9033         (blockvector_for_pc_sect): Make "b" const.
9034         (find_block_in_blockvector): Make "b" const.
9035
9036 2019-03-23  Tom Tromey  <tom@tromey.com>
9037
9038         * varobj.c (varobj_create): Update.
9039         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9040         * printcmd.c (display_command, do_one_display): Don't reset
9041         innermost_block.
9042         * parser-defs.h (enum innermost_block_tracker_type): Move to
9043         expression.h.
9044         (innermost_block): Update comment.
9045         * parse.c (parse_exp_1): Add tracker_types parameter.
9046         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9047         tracker_types parameter.  Reset innermost_block.
9048         (parse_exp_in_context): Remove.
9049         (parse_expression_for_completion): Update.
9050         * objfiles.c (~objfile): Don't reset expression_context_block or
9051         innermost_block.
9052         * expression.h (enum innermost_block_tracker_type): Move from
9053         parser-defs.h.
9054         (parse_exp_1): Add tracker_types parameter.
9055         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9056         reset innermost_block.
9057
9058 2019-03-23  Tom Tromey  <tom@tromey.com>
9059
9060         * objfiles.h: Include bcache.h.
9061
9062 2019-03-23  Tom Tromey  <tom@tromey.com>
9063
9064         * linespec.c (get_current_search_block): Use
9065         scoped_restore_current_language.
9066         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9067
9068 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9069             Jiong Wang  <jiong.wang@arm.com>
9070
9071         * aarch64-linux-tdep.c
9072         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9073         section.
9074         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9075
9076 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9077             Jiong Wang  <jiong.wang@arm.com>
9078
9079         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9080         instructions.
9081         (aarch64_analyze_prologue_test): Add PACIASP test.
9082         (aarch64_prologue_prev_register): Unmask PC value.
9083
9084 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9085             Jiong Wang  <jiong.wang@arm.com>
9086
9087         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9088         (aarch64_dwarf2_prev_register): Unmask PC value.
9089         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9090         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9091         DW_CFA_AARCH64_negate_ra_state.
9092         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9093
9094 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9095             Jiong Wang  <jiong.wang@arm.com>
9096
9097         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9098         registers.
9099         (aarch64_pseudo_register_name): Likewise.
9100         (aarch64_pseudo_register_type): Likewise.
9101         (aarch64_pseudo_register_reggroup_p): Likewise.
9102         (aarch64_gdbarch_init): Add pauth registers.
9103         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9104         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9105         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9106         (struct gdbarch_tdep): Add regnum for ra_state.
9107
9108 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9109             Jiong Wang  <jiong.wang@arm.com>
9110
9111         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9112
9113 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9114             Jiong Wang  <jiong.wang@arm.com>
9115
9116         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9117         function.
9118         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9119         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9120         (aarch64_gdbarch_init): Add puth registers.
9121         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9122         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9123         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9124
9125 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9126             Jiong Wang  <jiong.wang@arm.com>
9127
9128         * aarch64-linux-nat.c
9129         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9130         * aarch64-linux-tdep.c
9131         (aarch64_linux_core_read_description): Likewise.
9132         (aarch64_linux_get_hwcap): New function.
9133         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9134         (aarch64_linux_get_hwcap): New declaration.
9135
9136 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9137             Jiong Wang  <jiong.wang@arm.com>
9138
9139         * aarch64-linux-nat.c
9140         (aarch64_linux_nat_target::read_description): Add pauth param.
9141         * aarch64-linux-tdep.c
9142         (aarch64_linux_core_read_description): Likewise.
9143         * aarch64-tdep.c (struct target_desc): Add in pauth.
9144         (aarch64_read_description): Add pauth param.
9145         (aarch64_gdbarch_init): Likewise.
9146         * aarch64-tdep.h (aarch64_read_description): Likewise.
9147         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9148         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9149         * features/Makefile: Add new files.
9150         * features/aarch64-pauth.c: New file.
9151         * features/aarch64-pauth.xml: New file.
9152
9153 2019-03-20  Tom Tromey  <tromey@adacore.com>
9154
9155         * infrun.c (handle_inferior_event): Rename from
9156         handle_inferior_event_1.  Create a scoped_value_mark.
9157         (handle_inferior_event): Remove.
9158
9159 2019-03-19  Tom Tromey  <tromey@adacore.com>
9160
9161         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9162         * infrun.h (print_stop_event): Add "displays" parameter.
9163         * infrun.c (print_stop_event): Add "displays" parameter.
9164
9165 2019-03-19  Pedro Alves  <palves@redhat.com>
9166
9167         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9168         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9169         to -1.  Fix TABs vs spaces.
9170         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9171         * tui/tui-out.h (tui_ui_out) Add intro comments.
9172         <m_line, m_start_of_line>: In-class initialize, and add describing
9173         comment.
9174
9175 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9176
9177         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9178         variable names.
9179         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9180
9181 2019-03-18  Pedro Alves  <palves@redhat.com>
9182             Eli Zaretskii <eliz@gnu.org>
9183
9184         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9185         m_line and m_start_of_line.
9186
9187 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9188
9189         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9190         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9191         it returns a newline.  This fixes a regression in TU mode, whereby
9192         the next line is output on the same screen line as the user input.
9193
9194 2019-03-18  Tom Tromey  <tromey@adacore.com>
9195
9196         * minsyms.c (minimal_symbol_reader::install): Remove call to
9197         obstack_blank.
9198
9199 2019-03-18  Pedro Alves  <palves@redhat.com>
9200
9201         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9202         New globals.
9203         (apply_style): New, factored out from ...
9204         (apply_ansi_escape): ... this.  Handle reverse video mode.
9205         (tui_set_reverse_mode): New function.
9206         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9207         * tui/tui-winsource.c (tui_show_source_line): Use
9208         tui_set_reverse_mode instead of setting A_STANDOUT.
9209         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9210         New setter methods.
9211
9212 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9213
9214         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9215         Handle tabs.
9216
9217 2019-03-18  Tom Tromey  <tromey@adacore.com>
9218
9219         * ada-lang.c (empty_array): Add "high" parameter.
9220         (ada_evaluate_subexp): Update.
9221
9222 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9223
9224         * unittests/string_view-selftests.c: Define
9225         _initialize_string_view_selftests unconditionally.
9226
9227 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9228
9229         PR gdb/24350
9230         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9231
9232 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9233
9234         PR gdb/24351
9235         * windows-nat.c (display_selector): Fix format specifiers.
9236
9237 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9238
9239         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9240         tui_refill_source_window instead of tui_refresh_win, to update the
9241         current execution line.  This fixes redisplay of the current line
9242         when stepping through the code with "next" or "step".
9243
9244 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9245
9246         * source-cache.c (source_cache::get_source_lines): Call
9247         find_source_lines to initialize s->nlines.  This fixes vertical
9248         scrolling of TUI source window when the DOWN arrow is pressed.
9249
9250 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9251
9252         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9253         linux-thread-db.c (_initialize_thread_db): Likewise.
9254
9255 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9256
9257         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9258         wclrtoeol in tui_show_source_line".  This reverts changes made in
9259         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9260
9261 2019-03-15  Tom Tromey  <tom@tromey.com>
9262
9263         * symtab.h (struct minimal_symbol): Derive from
9264         general_symbol_info.
9265         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9266         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9267         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9268         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9269         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9270         (MSYMBOL_SEARCH_NAME): Update.
9271         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9272         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9273         * minsyms.c (minimal_symbol_reader::record_full): Update.
9274
9275 2019-03-15  Tom Tromey  <tom@tromey.com>
9276
9277         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9278
9279 2019-03-15  Tom Tromey  <tom@tromey.com>
9280
9281         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9282         unique_xmalloc_ptr.
9283         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9284         Update.
9285         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9286         (build_minimal_symbol_hash_tables)
9287         (minimal_symbol_reader::install): Update.
9288
9289 2019-03-15  Tom Tromey  <tom@tromey.com>
9290
9291         * symtab.c (create_demangled_names_hash): Update.
9292         (symbol_set_names): Update.
9293         * objfiles.h (struct objfile_per_bfd_storage)
9294         <demangled_names_hash>: Now an htab_up.
9295         * objfiles.c (objfile_per_bfd_storage): Simplify.
9296
9297 2019-03-15  Tom Tromey  <tom@tromey.com>
9298
9299         * objfiles.h (struct objfile_per_bfd_storage): Declare
9300         destructor.
9301         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9302         New.
9303         (get_objfile_bfd_data): Use new.  Don't initialize
9304         language_of_main.
9305         (free_objfile_per_bfd_storage): Remove.
9306         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9307
9308 2019-03-15  Tom Tromey  <tom@tromey.com>
9309
9310         * symfile.c (reread_symbols): Update.
9311         * objfiles.c (objfile::objfile): Update.
9312         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9313         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9314         comment.
9315         (minimal_symbol_reader::install): Update.
9316         (terminate_minimal_symbol_table): Remove.
9317         * jit.c (jit_object_close_impl): Update.
9318
9319 2019-03-15  Tom Tromey  <tom@tromey.com>
9320
9321         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9322         initializations.
9323
9324 2019-03-15  Tom Tromey  <tom@tromey.com>
9325
9326         * objfiles.h (struct objfile_per_bfd_storage)
9327         <demangled_hash_languages>: Now a bitset.
9328         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9329         (lookup_minimal_symbol): Update.
9330
9331 2019-03-15  Tom Tromey  <tom@tromey.com>
9332
9333         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9334         Don't return the symbol.
9335         * coffread.c (record_minimal_symbol): Use record_full.
9336
9337 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9338
9339         The MS-Windows port of ncurses fails to switch to a color pair if
9340         one or both of the colors are the implicit default colors.  This
9341         change records the default colors when TUI is initialized, and
9342         then specifies them explicitly when a color pair uses the default
9343         colors.  This allows color styling in TUI mode on MS-Windows.
9344
9345         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9346         ncurses_norm_attr.
9347         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9348         colors in ncurses_norm_attr.
9349         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9350         "none", replace it with the default color recorded in
9351         ncurses_norm_attr.
9352
9353 2019-03-14  Tom Tromey  <tromey@adacore.com>
9354
9355         * source-cache.h (class source_cache) <get_source_lines>: Return
9356         std::string.
9357         * source-cache.c (source_cache::extract_lines): Handle case where
9358         first_pos==npos.  Return std::string.
9359         (source_cache::get_source_lines): Update.
9360
9361 2019-03-14  Tom Tromey  <tromey@adacore.com>
9362
9363         * NEWS: Add item for "style sources" commands.
9364         * source-cache.c (source_cache::get_source_lines): Check
9365         source_styling.
9366         * cli/cli-style.c (source_styling): New global.
9367         (_initialize_cli_style): Add "style sources" commands.
9368         (show_style_sources): New function.
9369         * cli/cli-style.h (source_styling): Declare.
9370
9371 2019-03-14  Pedro Alves  <palves@redhat.com>
9372             Tom Tromey  <tromey@adacore.com>
9373
9374         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9375         * tui/tui-winsource.c (tui_refill_source_window): New function,
9376         from...
9377         (tui_horizontal_source_scroll): ... here.  Move some logic.
9378         * cli/cli-style.c (set_style_enabled): Notify new observable.
9379         * tui/tui-hooks.c (tui_redisplay_source): New function.
9380         (tui_attach_detach_observers): Attach or detach
9381         tui_redisplay_source.
9382         * observable.h (source_styling_changed): New observable.
9383         * observable.c: Define source_styling_changed observable.
9384
9385 2019-03-13  Tom Tromey  <tromey@adacore.com>
9386
9387         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9388         (i386_gnu_nat_target::store_registers): Update.
9389         * target-debug.h (target_debug_print_std_string): New macro.
9390         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9391         * windows-tdep.c (display_one_tib): Update.
9392         * tui/tui-stack.c (tui_make_status_line): Update.
9393         * top.c (print_inferior_quit_action): Update.
9394         * thread.c (thr_try_catch_cmd): Update.
9395         (add_thread_with_info): Update.
9396         (thread_target_id_str): Update.
9397         (thr_try_catch_cmd): Update.
9398         (thread_command): Update.
9399         (thread_find_command): Update.
9400         * record-btrace.c (record_btrace_target::info_record)
9401         (record_btrace_resume_thread, record_btrace_target::resume)
9402         (record_btrace_cancel_resume, record_btrace_step_thread)
9403         (record_btrace_target::wait, record_btrace_target::wait)
9404         (record_btrace_target::wait, record_btrace_target::stop): Update.
9405         * progspace.c (print_program_space): Update.
9406         * process-stratum-target.c
9407         (process_stratum_target::thread_address_space): Update.
9408         * linux-fork.c (linux_fork_mourn_inferior)
9409         (detach_checkpoint_command, info_checkpoints_command)
9410         (linux_fork_context): Update.
9411         (linux_fork_detach): Update.
9412         (class scoped_switch_fork_info): Update.
9413         (delete_checkpoint_command): Update.
9414         * infrun.c (follow_fork_inferior): Update.
9415         (follow_fork_inferior): Update.
9416         (proceed_after_vfork_done): Update.
9417         (handle_vfork_child_exec_or_exit): Update.
9418         (follow_exec): Update.
9419         (displaced_step_prepare_throw): Update.
9420         (displaced_step_restore): Update.
9421         (start_step_over): Update.
9422         (resume_1): Update.
9423         (clear_proceed_status_thread): Update.
9424         (proceed): Update.
9425         (print_target_wait_results): Update.
9426         (do_target_wait): Update.
9427         (context_switch): Update.
9428         (stop_all_threads): Update.
9429         (restart_threads): Update.
9430         (finish_step_over): Update.
9431         (handle_signal_stop): Update.
9432         (switch_back_to_stepped_thread): Update.
9433         (keep_going_pass_signal): Update.
9434         (print_exited_reason): Update.
9435         (normal_stop): Update.
9436         * inferior.c (inferior_pid_to_str): Change return type.
9437         (print_selected_inferior): Update.
9438         (add_inferior): Update.
9439         (detach_inferior): Update.
9440         * dummy-frame.c (fprint_dummy_frames): Update.
9441         * dcache.c (dcache_info_1): Update.
9442         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9443         (btrace_fetch, btrace_clear): Update.
9444         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9445         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9446         type.
9447         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9448         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9449         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9450         * gdbarch.c, gdbarch.h: Rebuild.
9451         * gdbarch.sh (core_pid_to_str): Change return type.
9452         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9453         return type.
9454         (windows_nat_target::pid_to_str): Change return type.
9455         (windows_delete_thread): Update.
9456         (windows_nat_target::attach): Update.
9457         (windows_nat_target::files_info): Update.
9458         * target-delegates.c: Rebuild.
9459         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9460         return type.
9461         (sol_thread_target::pid_to_str): Change return type.
9462         * remote.c (class remote_target) <pid_to_str>: Change return
9463         type.
9464         (remote_target::pid_to_str): Change return type.
9465         (extended_remote_target::attach, remote_target::remote_stop_ns)
9466         (remote_target::remote_notif_remove_queued_reply)
9467         (remote_target::push_stop_reply, remote_target::disable_btrace):
9468         Update.
9469         (extended_remote_target::attach): Update.
9470         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9471         type.
9472         (gdbsim_target::pid_to_str): Change return type.
9473         * ravenscar-thread.c (struct ravenscar_thread_target)
9474         <pid_to_str>: Change return type.
9475         (ravenscar_thread_target::pid_to_str): Change return type.
9476         * procfs.c (class procfs_target) <pid_to_str>: Change return
9477         type.
9478         (procfs_target::pid_to_str): Change return type.
9479         (procfs_target::attach): Update.
9480         (procfs_target::detach): Update.
9481         (procfs_target::fetch_registers): Update.
9482         (procfs_target::store_registers): Update.
9483         (procfs_target::wait): Update.
9484         (procfs_target::files_info): Update.
9485         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9486         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9487         return type.
9488         (nto_procfs_target::pid_to_str): Change return type.
9489         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9490         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9491         return type.
9492         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9493         (exit_lwp): Update.
9494         (attach_proc_task_lwp_callback, get_detach_signal)
9495         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9496         (linux_nat_target::resume, wait_lwp, stop_callback)
9497         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9498         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9499         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9500         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9501         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9502         type.
9503         (inf_ptrace_target::attach): Update.
9504         (inf_ptrace_target::files_info): Update.
9505         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9506         type.
9507         (go32_nat_target::pid_to_str): Change return type.
9508         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9509         (gnu_nat_target::wait): Update.
9510         (gnu_nat_target::wait): Update.
9511         (gnu_nat_target::resume): Update.
9512         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9513         (fbsd_nat_target::wait): Update.
9514         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9515         type.
9516         (darwin_nat_target::attach): Update.
9517         * corelow.c (class core_target) <pid_to_str>: Change return type.
9518         (core_target::pid_to_str): Change return type.
9519         * target.c (normal_pid_to_str): Change return type.
9520         (default_pid_to_str): Likewise.
9521         (target_pid_to_str): Change return type.
9522         (target_translate_tls_address): Update.
9523         (target_announce_detach): Update.
9524         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9525         return type.
9526         (bsd_uthread_target::pid_to_str): Change return type.
9527         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9528         type.
9529         (bsd_kvm_target::pid_to_str): Change return type.
9530         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9531         return type.
9532         (aix_thread_target::pid_to_str): Change return type.
9533         * target.h (struct target_ops) <pid_to_str>: Change return type.
9534         (target_pid_to_str, normal_pid_to_str): Likewise.
9535         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9536         type.
9537         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9538         type.
9539         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9540         return type.
9541         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9542         type.
9543         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9544         type.
9545         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9546         return type.
9547
9548 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9549
9550         * NEWS: Mention that the new default MI version is 3.  Mention
9551         changes to the output of commands and events that deal with
9552         multi-location breakpoints.
9553         * breakpoint.c: Include "mi/mi-out.h".
9554         (print_one_breakpoint): Change output syntax if using MI version
9555         >= 3.
9556         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9557         New.
9558         (mi_multi_location_breakpoint_output_fixed): New.
9559         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9560         (mi_cmd_fix_multi_location_breakpoint_output): New.
9561         (mi_multi_location_breakpoint_output_fixed): New.
9562         * mi/mi-cmds.c (mi_cmds): Register command
9563         -fix-multi-location-breakpoint-output.
9564         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9565         interpreter "mi".
9566
9567 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9568
9569         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9570         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9571         instantiate mi_ui_out based on interpreter name.
9572         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9573         * mi/mi-main.c (mi_load_progress): Likewise.
9574
9575 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9576
9577         * NEWS: Combine separate "New targets" sections for 8.3.
9578
9579 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9580
9581         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9582         (ppcfbsd_init_abi): Install gdbarch
9583         "fetch_tls_load_module_address" and "get_thread_local_address"
9584         methods.
9585
9586 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9587
9588         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9589         (riscv_fbsd_init_abi): Install gdbarch
9590         "fetch_tls_load_module_address" and "get_thread_local_address"
9591         methods.
9592
9593 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9594
9595         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9596         (i386fbsd_init_abi): Install gdbarch
9597         "fetch_tls_load_module_address" and "get_thread_local_address"
9598         methods.
9599
9600 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9601
9602         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9603         (amd64fbsd_init_abi): Install gdbarch
9604         "fetch_tls_load_module_address" and "get_thread_local_address"
9605         methods.
9606
9607 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9608
9609         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9610         (struct fbsd_pspace_data): New type.
9611         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9612         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9613         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9614         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9615         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9616
9617 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9618
9619         * gdbtypes.c (lookup_struct_elt): New function.
9620         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9621         * gdbtypes.h (struct struct_elt): New type.
9622         (lookup_struct_elt): New prototype.
9623
9624 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9625
9626         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9627         remove disabled code block.
9628
9629 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9630
9631         * gdbarch.sh (get_thread_local_address): New method.
9632         * gdbarch.h, gdbarch.c: Regenerate.
9633         * target.c (target_translate_tls_address): Use
9634         gdbarch_get_thread_local_address if present instead of
9635         target::get_thread_local_address.
9636
9637 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9638
9639         * target.h (target::get_thread_local_address): Update comment.
9640
9641 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9642
9643         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9644         objfile->separate_debug_objfile_backlink if not NULL.
9645
9646 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9647
9648         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9649         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9650         (amd64bsd_store_inferior_registers): Likewise.
9651         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9652         Enable segment base registers.
9653         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9654         PT_GETFSBASE and PT_GETGSBASE.
9655         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9656         PT_SETGSBASE.
9657         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9658         segment base registers.
9659         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9660
9661 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9662
9663         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9664         Update calls to i386_target_description to add 'segments'
9665         parameter.
9666         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9667         add segment base registers.
9668         * arch/i386.c (i386_create_target_description): Add 'segments'
9669         parameter to enable segment base registers.
9670         * arch/i386.h (i386_create_target_description): Likewise.
9671         * features/i386/32bit-segments.xml: New file.
9672         * features/i386/32bit-segments.c: Generate.
9673         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9674         call to i386_target_description to add 'segments' parameter.
9675         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9676         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9677         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9678         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9679         if feature is present.
9680         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9681         Add 'segments' parameter to call to i386_target_description.
9682         (i386_target_description): Add 'segments' parameter to enable
9683         segment base registers.
9684         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9685         to call to i386_target_description.
9686         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9687         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9688         Define I386_NUM_REGS.
9689         (i386_target_description): Add 'segments' parameter to enable
9690         segment base registers.
9691
9692 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9693
9694         PR/24325
9695         * source-cache.c: #undef open and close, to avoid unresolved
9696         externals during linking.
9697
9698 2019-03-12  Tom Tromey  <tromey@adacore.com>
9699
9700         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9701         const.  Add initializers.
9702         (_initialize_remote): Don't initialize ptid globals.
9703
9704 2019-03-12  Pedro Alves  <palves@redhat.com>
9705
9706         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9707
9708 2019-03-12  Pedro Alves  <palves@redhat.com>
9709
9710         * cp-name-parser.y (main): Remove unused 'len' variable.
9711
9712 2019-03-12  Tom Tromey  <tromey@adacore.com>
9713
9714         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9715         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9716
9717 2019-03-12  Tom Tromey  <tromey@adacore.com>
9718
9719         * linux-nat.c (iterate_over_lwps): Update.
9720         (stop_callback): Remove parameter.
9721         (stop_wait_callback, detach_callback, resume_set_callback)
9722         (select_singlestep_lwp_callback, set_ignore_sigint)
9723         (status_callback, resumed_callback, resume_clear_callback)
9724         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9725         data parameter.
9726         (linux_nat_target::detach, linux_nat_target::resume)
9727         (linux_stop_and_wait_all_lwps, select_event_lwp)
9728         (linux_nat_filter_event, linux_nat_wait_1)
9729         (linux_nat_target::kill, linux_nat_target::stop)
9730         (linux_nat_target::stop): Update.
9731         (linux_nat_resume_callback): Change type.
9732         (resume_stopped_resumed_lwps, count_events_callback)
9733         (select_event_lwp_callback): Likewise.
9734         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9735         * arm-linux-nat.c (struct update_registers_data): Remove.
9736         (update_registers_callback): Change type.
9737         (arm_linux_insert_hw_breakpoint1): Update.
9738         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9739         parameter.
9740         (x86_linux_dr_set_addr): Update.
9741         (x86_linux_dr_set_control): Update.
9742         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9743         (iterate_over_lwps): Use gdb::function_view.
9744         * nat/aarch64-linux-hw-point.c (struct
9745         aarch64_dr_update_callback_param): Remove.
9746         (debug_reg_change_callback): Change type.
9747         (aarch64_notify_debug_reg_change): Update.
9748         * s390-linux-nat.c (s390_refresh_per_info): Update.
9749
9750 2019-03-11  Tom Tromey  <tromey@adacore.com>
9751
9752         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9753         redundant assignment to "this_cu".
9754
9755 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9756
9757         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9758
9759 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9760
9761         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9762         from...
9763         (rank_one_type): ... this.
9764
9765 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9766
9767         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9768         from...
9769         (rank_one_type): ... this.
9770
9771 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9772
9773         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9774         from...
9775         (rank_one_type): ... this.
9776
9777 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9778
9779         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9780         from...
9781         (rank_one_type): ... this.
9782
9783 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9784
9785         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9786         from...
9787         (rank_one_type): ... this.
9788
9789 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9790
9791         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9792         from...
9793         (rank_one_type): ... this.
9794
9795 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9796
9797         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9798         from...
9799         (rank_one_type): ... this.
9800
9801 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9802
9803         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9804         from...
9805         (rank_one_type): ... this.
9806
9807 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9808
9809         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9810         from...
9811         (rank_one_type): ... this.
9812
9813 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9814
9815         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9816         from...
9817         (rank_one_type): ... this.
9818
9819 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9820
9821         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9822         from...
9823         (rank_one_type): ... this.
9824
9825 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9826
9827         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9828         from...
9829         (rank_one_type): ... this.
9830
9831 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9832
9833         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9834         inferior-events' shows the example events.
9835
9836 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9837
9838         Support styling on native MS-Windows console
9839
9840         PR/24315
9841         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9842         on MS-Windows if $TERM is not defined.
9843
9844         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9845
9846         * posix-hdep.c (gdb_console_fputs):
9847         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9848         functions.
9849         * ui-file.h (gdb_console_fputs): Add prototype.
9850
9851         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9852         back to fputs only if the former returns zero.
9853
9854 2019-03-07  Tom Tromey  <tom@tromey.com>
9855
9856         * symmisc.c (print_symbol_bcache_statistics): Update.
9857         (print_objfile_statistics): Update.
9858         * symfile.c (allocate_symtab): Update.
9859         * stabsread.c: Don't include bcache.h.
9860         * psymtab.h (struct psymbol_bcache): Don't declare.
9861         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9862         (psymbol_bcache_init, psymbol_bcache_free)
9863         (psymbol_bcache_get_bcache): Don't declare.
9864         * psymtab.c (struct psymbol_bcache): Remove.
9865         (psymtab_storage::psymtab_storage): Update.
9866         (psymtab_storage::~psymtab_storage): Update.
9867         (psymbol_bcache_init, psymbol_bcache_free)
9868         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9869         (add_psymbol_to_bcache): Update.
9870         (allocate_psymtab): Update.
9871         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9872         macro_cache>: No longer pointers.
9873         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9874         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9875         * macrotab.c (macro_bcache): Update.
9876         * macroexp.c: Don't include bcache.h.
9877         * gdbtypes.c (check_types_worklist): Update.
9878         (types_deeply_equal): Remove TRY/CATCH.  Update.
9879         * elfread.c (elf_symtab_read): Update.
9880         * dwarf2read.c: Don't include bcache.h.
9881         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9882         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9883         (print_bcache_statistics, bcache_memory_used): Don't declare.
9884         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9885         methods.  Rename all data members.
9886         * bcache.c (struct bcache): Move to bcache.h.
9887         (bcache::expand_hash_table): Rename from expand_hash_table.
9888         (bcache): Remove.
9889         (bcache::insert): Rename from bcache_full.
9890         (bcache::compare): Rename from bcache_compare.
9891         (bcache_xmalloc): Remove.
9892         (bcache::~bcache): Rename from bcache_xfree.
9893         (bcache::print_statistics): Rename from print_bcache_statistics.
9894         (bcache::memory_used): Rename from bcache_memory_used.
9895
9896 2019-03-07  Pedro Alves  <palves@redhat.com>
9897
9898         * infrun.c (normal_stop): Also check for
9899         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9900
9901 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9902
9903         * f-lang.c (value_from_host_double): Moved to...
9904         * value.c (value_from_host_double): ...here.
9905         * value.h (value_from_host_double): Declare.
9906         * guile/scm-math.c (vlscm_convert_typed_number): Use
9907         value_from_host_double.
9908         (vlscm_convert_number): Likewise.
9909         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9910         * python/py-value.c (convert_value_from_python): Likewise.
9911
9912 2019-03-06  Tom Tromey  <tom@tromey.com>
9913
9914         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9915
9916 2019-03-06  Tom Tromey  <tom@tromey.com>
9917
9918         * utils.h (free_current_contents): Don't declare.
9919         * utils.c (free_current_contents): Remove.
9920
9921 2019-03-06  Tom Tromey  <tom@tromey.com>
9922
9923         * top.c (quit_force): Update.
9924         * main.c (captured_command_loop): Update.
9925         * common/new-op.c (operator new): Update.
9926         * common/common-exceptions.c (struct catcher)
9927         <save_cleanup_chain>: Remove member.
9928         (exceptions_state_mc_init): Update.
9929         (exception_try_scope_entry): Return nullptr.
9930         (exception_try_scope_exit, exception_rethrow)
9931         (throw_exception_sjlj, throw_exception_cxx): Update.
9932         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9933         (all_cleanups, do_cleanups, discard_cleanups)
9934         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9935         (restore_cleanups, restore_final_cleanups): Don't declare.
9936         (do_final_cleanups): Remove parameter.
9937         * common/cleanups.c (cleanup_chain, make_cleanup)
9938         (make_cleanup_dtor, all_cleanups, do_cleanups)
9939         (discard_my_cleanups, discard_cleanups)
9940         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9941         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9942         (null_cleanup): Remove.
9943         (do_final_cleanups): Remove parameter.
9944
9945 2019-03-06  Tom Tromey  <tom@tromey.com>
9946
9947         * remote.c (remote_target::remote_parse_stop_reply): Use
9948         unique_xmalloc_ptr.
9949
9950 2019-03-06  Tom Tromey  <tom@tromey.com>
9951
9952         * stabsread.c (struct stabs_field_info): Rename from field_info.
9953         <list, fnlist>: Add initializers.
9954         <obstack>: New member.
9955         (read_member_functions, read_struct_fields, read_baseclasses):
9956         Allocate on obstack.  Don't use cleanups.
9957         (read_one_struct_field, read_member_functions, read_struct_fields)
9958         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9959         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9960         (read_struct_type): Update.
9961
9962 2019-03-06  Tom Tromey  <tom@tromey.com>
9963
9964         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9965         * common/filestuff.h (make_cleanup_close): Don't declare.
9966         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9967         Remove.
9968
9969 2019-03-06  Tom Tromey  <tom@tromey.com>
9970
9971         * solib-aix.c: Use make_scope_exit.
9972
9973 2019-03-06  Tom Tromey  <tom@tromey.com>
9974
9975         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9976         Use make_scope_exit.
9977
9978 2019-03-06  Tom Tromey  <tom@tromey.com>
9979
9980         * solib-svr4.c (disable_probes_interface): Remove parameter.
9981         (svr4_handle_solib_event): Use make_scope_exit.
9982
9983 2019-03-06  Tom Tromey  <tom@tromey.com>
9984
9985         * remote.c (struct stop_reply_deleter): Remove.
9986         (stop_reply_up): Update.
9987         (struct stop_reply): Derive from notif_event.  Don't typedef.
9988         <regcache>: Now a std::vector.
9989         (stop_reply_xfree): Remove.
9990         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9991         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9992         (remote_target::discard_pending_stop_replies): Use delete.
9993         (remote_target::remote_parse_stop_reply): Update.
9994         (remote_target::process_stop_reply): Update.
9995         * remote-notif.h (struct notif_event): Add virtual destructor.
9996         Remove "dtr" member.
9997         (struct notif_client) <alloc_event>: Return a unique_ptr.
9998         (notif_event_xfree): Don't declare.
9999         (notif_event_up): New typedef.
10000         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10001         (notif_event_xfree, do_notif_event_xfree): Remove.
10002         (remote_notif_state_xfree): Update.
10003
10004 2019-03-06  Tom Tromey  <tom@tromey.com>
10005
10006         * infrun.c (displaced_step_clear_cleanup): Now a
10007         forward_scope_exit type.
10008         (displaced_step_prepare_throw): Update.
10009         (displaced_step_fixup): Update.
10010
10011 2019-03-06  Tom Tromey  <tom@tromey.com>
10012
10013         * inferior.h (class inferior): Update comment.
10014         * gdbthread.h (class thread_info): Update comment.
10015
10016 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10017             Tom Tromey  <tom@tromey.com>
10018
10019         * stabsread.h (struct stab_section_list): Remove.
10020         (coffstab_build_psymtabs): Update.
10021         * dbxread.c (symbuf_sections): Now a std::vector.
10022         (sect_idx): New global.
10023         (fill_symbuf): Update.
10024         (coffstab_build_psymtabs): Change type of stabsects parameter.
10025         Update.
10026         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10027         std::vector.
10028         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10029         (coff_locate_sections): Update.
10030         (coff_symfile_read): Remove cleanups.  Update.
10031         (init_stringtab): Add storage parameter.
10032         (free_stringtab, free_stringtab_cleanup): Remove.
10033         (init_lineno): Add storage parameter.
10034         (free_linetab, free_linetab_cleanup): Remove.
10035
10036 2019-03-06  Pedro Alves  <palves@redhat.com>
10037
10038         * linux-fork.c (fork_info::clobber_regs): Delete.
10039         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10040         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10041         comment.  Adjust.
10042         (scoped_switch_fork_info::scoped_switch_fork_info)
10043         (checkpoint_command, linux_fork_context): Adjust
10044         fork_save_infrun_state calls.
10045
10046 2019-03-06  Pedro Alves  <palves@redhat.com>
10047
10048         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10049         (inf_has_multiple_threads): Return 'bool' and rewrite using
10050         inferior_info::threads().
10051
10052 2019-03-06  Pedro Alves  <palves@redhat.com>
10053
10054         * linux-fork.c: Include <list>.
10055         (fork_list): Now a std::list instance.
10056         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10057         (forks_exist_p, find_last_fork): Adjust.
10058         (new_fork): Delete.
10059         (one_fork_p): New.
10060         (add_fork): Adjust.
10061         (free_fork): Delete, folded into fork_info::~fork_info().
10062         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10063         Adjust.
10064         (init_fork_list): Delete.
10065         (linux_fork_killall, linux_fork_mourn_inferior)
10066         (linux_fork_detach, info_checkpoints_command): Adjust.
10067         (_initialize_linux_fork): No longer call init_fork_list.
10068
10069 2019-03-06  Pedro Alves  <palves@redhat.com>
10070
10071         * linux-fork.c (new_fork): New, split out of ...
10072         (add_fork): ... this.  Return void.  Move "first fork" special
10073         case from here, to ...
10074         (checkpoint_command): ... here.
10075         * linux-linux.h (add_fork): Return void.
10076
10077 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10078
10079         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10080
10081 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10082             Chris January  <chris.january@arm.com>
10083             David Lecomber  <david.lecomber@arm.com>
10084
10085         * f-exp.y: New token, UNOP_INTRINSIC.
10086         (exp): New pattern using UNOP_INTRINSIC token.
10087         (f77_keywords): Add 'abs' keyword.
10088         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10089         (value_from_host_double): New function.
10090         (evaluate_subexp_f): Support UNOP_ABS.
10091
10092 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10093
10094         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10095         types.
10096
10097 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10098
10099         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10100         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10101         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10102
10103 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10104
10105         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10106
10107 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10108             Chris January  <chris.january@arm.com>
10109
10110         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10111         * f-exp.y: Define 'KIND' token.
10112         (exp): New pattern for KIND expressions.
10113         (ptype): Handle types with a kind extension.
10114         (direct_abs_decl): Extend to spot kind extensions.
10115         (f77_keywords): Add 'kind' to the list.
10116         (push_kind_type): New function.
10117         (convert_to_kind_type): New function.
10118         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10119         * parse.c (operator_length_standard): Likewise.
10120         * parser-defs.h (enum type_pieces): Add tp_kind.
10121         * std-operator.def: Add UNOP_KIND.
10122
10123 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10124
10125         * f-exp.y (f_parse): Set yydebug.
10126
10127 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10128
10129         * f-lang.c (evaluate_subexp_f): New function.
10130         (exp_descriptor_f): New global.
10131         (f_language_defn): Use exp_descriptor_f instead of
10132         exp_descriptor_standard.
10133
10134 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10135
10136         * f-exp.y (struct token): Add comments.
10137         (dot_ops): Remove uppercase versions and the end marker.
10138         (f77_keywords): Likewise.
10139         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10140         entries in the dot_ops array are case insensitive, and use
10141         strncasecmp to compare strings.  Also some whitespace cleanup in
10142         this area.  Similar for the f77_keywords array, except entries in
10143         this list might be case sensitive.
10144
10145 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10146
10147         * f-exp.y (struct f77_boolean_val): Add comments.
10148         (boolean_values): Remove uppercase versions, and end marker.
10149         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10150         and use strncasecmp to achieve case insensitivity.  Additionally,
10151         perform whitespace cleanup around this code.
10152
10153 2019-03-06  Tom Tromey  <tromey@adacore.com>
10154
10155         * remote-sim.c (gdbsim_target_open): Use result of
10156         gdb_argv::release.
10157
10158 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10159         Dirk Schubert  <dirk.schubert@arm.com>
10160         Chris January  <chris.january@arm.com>
10161
10162         * eval.c (evaluate_subexp_standard): Call Fortran argument
10163         wrapping logic.
10164         * f-lang.c (struct value): A value which can be passed into a
10165         Fortran function call.
10166         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10167         where appropriate.
10168         (struct type): Value ready for a Fortran function call.
10169         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10170         is needed.
10171         * f-lang.h (fortran_argument_convert): Declaration.
10172         (fortran_preserve_arg_pointer): Declaration.
10173         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10174
10175 2019-03-05  Tom Tromey  <tromey@adacore.com>
10176
10177         * python/py-prettyprint.c (print_string_repr): Remove #if.
10178         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10179
10180 2019-03-05  Tom Tromey  <tromey@adacore.com>
10181
10182         * target.c (the_dummy_target): Move later.  Change type to
10183         "dummy_target".
10184         (initialize_targets): Don't initialize the_dummy_target.
10185
10186 2019-03-05  Tom Tromey  <tromey@adacore.com>
10187
10188         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10189         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10190
10191 2019-03-05  Tom Tromey  <tromey@adacore.com>
10192
10193         * windows-nat.c (windows_nat_target::attach)
10194         (windows_nat_target::detach): Don't call gdb_flush.
10195         * valprint.c (generic_val_print, val_print, val_print_string):
10196         Don't call gdb_flush.
10197         * utils.c (defaulted_query): Don't call gdb_flush.
10198         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10199         * target.c (target_announce_detach): Don't call gdb_flush.
10200         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10201         * remote.c (extended_remote_target::attach): Don't call
10202         gdb_flush.
10203         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10204         * printcmd.c (do_examine): Don't call gdb_flush.
10205         (info_display_command): Don't call gdb_flush.
10206         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10207         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10208         * memattr.c (info_mem_command): Don't call gdb_flush.
10209         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10210         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10211         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10212         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10213         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10214         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10215         (gnu_nat_target::detach): Don't call gdb_flush.
10216         * f-valprint.c (f_val_print): Don't call gdb_flush.
10217         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10218         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10219         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10220         gdb_flush.
10221         * c-valprint.c (c_val_print): Don't call gdb_flush.
10222         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10223
10224 2019-03-05  Tom Tromey  <tromey@adacore.com>
10225
10226         * varobj.c (update_dynamic_varobj_children): Update.
10227         (install_default_visualizer): Use reset, not release.
10228         * value.c (set_internalvar): Update.
10229         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10230         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10231         ATTRIBUTE_UNUSED_RESULT.
10232
10233 2019-03-05  Tom Tromey  <tromey@adacore.com>
10234
10235         * remote.c (class scoped_remote_fd) <release>: Add
10236         ATTRIBUTE_UNUSED_RESULT.
10237
10238 2019-03-05  Tom Tromey  <tromey@adacore.com>
10239
10240         * macroexp.c (struct macro_buffer) <release>: Add
10241         ATTRIBUTE_UNUSED_RESULT.
10242
10243 2019-03-05  Tom Tromey  <tromey@adacore.com>
10244
10245         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10246         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10247         ATTRIBUTE_UNUSED_RESULT.
10248
10249 2019-03-05  Tom Tromey  <tromey@adacore.com>
10250
10251         * common/scoped_fd.h (class scoped_fd) <release>: Add
10252         ATTRIBUTE_UNUSED_RESULT.
10253
10254 2019-03-05  Tom Tromey  <tromey@adacore.com>
10255
10256         * parser-defs.h (struct parser_state) <release>: Add
10257         ATTRIBUTE_UNUSED_RESULT.
10258
10259 2019-03-05  Tom Tromey  <tromey@adacore.com>
10260
10261         * utils.h (class gdb_argv) <release>: Add
10262         ATTRIBUTE_UNUSED_RESULT.
10263         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10264
10265 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10266
10267         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10268         for-loop range, to avoid compiler warnings.
10269
10270         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10271         avoid compiler warnings about unused variables.
10272
10273         * NEWS: Mention end of support for native debugging on MS-Windows
10274         before XP.
10275
10276         PR gdb/24292
10277         * common/netstuff.c:
10278         * gdbserver/gdbreplay.c
10279         * gdbserver/remote-utils.c:
10280         * ser-tcp.c:
10281         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10282         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10283         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10284         'getaddrinfo' and 'freeaddrinfo' were not available before
10285         Windows XP, and mingw.org's MinGW headers by default define
10286         _WIN32_WINNT to 0x500.
10287
10288 2019-03-01  Gary Benson <gbenson@redhat.com>
10289
10290         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10291
10292 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10293             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10294
10295         PR gdb/8527
10296         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10297         set_sigint_trap, clear_sigint_trap.
10298
10299 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10300
10301         * target.c (target_detach): Clear the regcache and the
10302         frame cache.
10303
10304 2019-02-27  Pedro Alves  <palves@redhat.com>
10305
10306         * utils.c (set_screen_size): When we cap the height/width sizes,
10307         tweak the corresponding command variable to show "unlimited":
10308
10309 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10310             Pedro Alves  <palves@redhat.com>
10311
10312         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10313         before calling rl_set_screen_size.
10314
10315 2019-02-27  Tom Tromey  <tromey@adacore.com>
10316
10317         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10318         define.
10319         * python/py-value.c: Remove Python 2.4 workaround.
10320         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10321         workaround.
10322         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10323         Python 2.4 workaround.
10324         * python/python-internal.h: Remove Python 2.4 comment.
10325         (Py_ssize_t): Don't define.
10326         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10327         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10328         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10329         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10330         * python/python.c (do_start_initialization): Remove Python 2.4
10331         workaround.
10332         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10333         (print_children): Remove Python 2.4 workaround.
10334         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10335         workaround.
10336         (CHARBUFFERPROC_NAME): Remove.
10337         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10338         Python 2.4 workaround.
10339
10340 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10341
10342         * NEWS: Note minimum Python version.
10343
10344 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10345
10346         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10347         code from these functions.  Remove corresponding ifdefs.  Use
10348         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10349         Remove gotos and target of gotos.
10350         (infpy_search_memory): Likewise.
10351
10352 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10353
10354         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10355         (hppa_gdbarch_init): Don't register deleted functions with
10356         gdbarch.
10357
10358 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10359
10360         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10361         (h8300_unwind_sp): Delete.
10362         (h8300_dummy_id): Delete.
10363         (h8300_gdbarch_init): Don't register deleted functions with
10364         gdbarch.
10365
10366 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10367
10368         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10369         (ft32_unwind_pc): Delete.
10370         (ft32_unwind_sp): Delete.
10371         (ft32_gdbarch_init): Don't register deleted functions with
10372         gdbarch.
10373
10374 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10375
10376         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10377         (frv_unwind_pc): Delete.
10378         (frv_unwind_sp): Delete.
10379         (frv_gdbarch_init): Don't register deleted functions with
10380         gdbarch.
10381
10382 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10383
10384         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10385         (riscv_unwind_pc): Delete.
10386         (riscv_unwind_sp): Delete.
10387         (riscv_gdbarch_init): Don't register deleted functions with
10388         gdbarch.
10389
10390 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10391
10392         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10393         (csky_unwind_pc): Delete.
10394         (csky_unwind_sp): Delete.
10395         (csky_gdbarch_init): Don't register deleted functions with
10396         gdbarch.
10397
10398 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10399
10400         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10401         (cris_unwind_pc): Delete.
10402         (cris_unwind_sp): Delete.
10403         (cris_gdbarch_init): Don't register deleted functions with
10404         gdbarch.
10405
10406 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10407
10408         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10409         (bfin_unwind_pc): Delete.
10410         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10411
10412 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10413
10414         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10415         (arm_unwind_pc): Delete.
10416         (arm_unwind_sp): Delete.
10417         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10418
10419 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10420
10421         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10422         (arc_unwind_pc): Delete.
10423         (arc_unwind_sp): Delete.
10424         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10425
10426 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10427
10428         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10429         (alpha_unwind_pc): Delete.
10430         (alpha_gdbarch_init): Don't register deleted functions with
10431         gdbarch.
10432
10433 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10434
10435         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10436         (aarch64_unwind_pc): Delete.
10437         (aarch64_unwind_sp): Delete.
10438         (aarch64_gdbarch_init): Don't register deleted functions with
10439         gdbarch.
10440
10441 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10442
10443         * gdbtypes.c (type_align): Don't consider static members when
10444         computing structure alignment.
10445
10446 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10447
10448         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10449         return 0 for other types.
10450         * arch-utils.c (default_type_align): Always return 0.
10451         * gdbarch.h: Regenerate.
10452         * gdbarch.sh (type_align): Extend comment.
10453         * gdbtypes.c (type_align): Add additional comments, always call
10454         gdbarch_type_align before applying the default rules.
10455         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10456         generic code will then apply a suitable default.
10457         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10458         types, return 0 for other types.
10459
10460 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10461
10462         * NEWS: Create a new section for the next release branch.
10463         Rename the section of the current branch, now that it has
10464         been cut.
10465
10466 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10467
10468         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10469         * version.in: Bump version to 8.3.50.DATE-git.
10470
10471 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10472
10473         * aix-thread.c (ptid_cmp): Remove unused variable.
10474         (get_signaled_thread): Likewise.
10475         (store_regs_user_thread): Likewise.
10476         (store_regs_kernel_thread): Likewise.
10477         (fetch_regs_kernel_thread): Remove shadowed variable.
10478
10479 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10480
10481         * features/riscv/32bit-cpu.xml: Add register numbers.
10482         * features/riscv/32bit-fpu.c: Regenerate.
10483         * features/riscv/32bit-fpu.xml: Add register numbers.
10484         * features/riscv/64bit-cpu.xml: Add register numbers.
10485         * features/riscv/64bit-fpu.c: Regenerate.
10486         * features/riscv/64bit-fpu.xml: Add register numbers.
10487
10488 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10489
10490         * NEWS: Mention two argument form of gdb.Value constructor.
10491         * python/py-value.c (convert_buffer_and_type_to_value): New
10492         function.
10493         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10494         Add support for handling an optional second argument.  Call
10495         convert_buffer_and_type_to_value as appropriate.
10496         * python/python-internal.h (Py_buffer_deleter): New struct.
10497         (Py_buffer_up): New typedef.
10498
10499 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10500
10501         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10502         instead of releasing ownership.
10503
10504 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10505
10506         * dwarf2read.c (open_and_init_dwp_file): Call
10507         elf_numsections instead of bfd_count_sections to initialize
10508         dwp_file->num_sections.
10509
10510 2019-02-25  Tom Tromey  <tromey@adacore.com>
10511
10512         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10513
10514 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10515
10516         * gcore.in: Add '--readnever' option when invoking GDB.
10517
10518 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10519
10520         * MAINTAINERS: Update my email address.
10521
10522 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10523
10524         * build-id.c (build_id_to_debug_bfd_1): New function.
10525         (build_id_to_debug_bfd): Look for separate debug file in
10526         sysroot.
10527
10528 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10529
10530         * gdbarch.sh: Update the copyright year range that is placed into
10531         generated files.
10532
10533 2019-02-22  Keith Seitz  <keiths@redhat.com>
10534
10535         PR symtab/23853
10536         * linespec.c (create_sals_line_offset): Search for the default
10537         symtab's filename instead of its fullname.
10538
10539 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10540
10541         * NEWS: Update style defaults.
10542
10543 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10544
10545         * main.c (captured_main_1): Disable styling in batch mode.
10546
10547 2019-02-20  Tom Tromey  <tom@tromey.com>
10548
10549         * symtab.c (symtab_symbol_info): Fix typos.
10550
10551 2019-02-20  Tom Tromey  <tromey@adacore.com>
10552
10553         * findcmd.c (_initialize_mem_search): Use upper case for
10554         metasyntactic variables.
10555
10556 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10557
10558         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10559         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10560
10561 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10562
10563         * top.h (source_file_name): Change to std::string.
10564         * top.c (source_file_name): Likewise.
10565         (command_line_input): Adjust.
10566         * cli/cli-script.c (script_from_file): Adjust.
10567
10568 2019-02-19  Tom Tromey  <tromey@adacore.com>
10569
10570         * ravenscar-thread.c
10571         (ravenscar_thread_target::update_thread_list): Don't call
10572         ada_build_task_list.
10573         * ada-lang.h (ada_build_task_list): Don't declare.
10574         * ada-tasks.c (struct ada_tasks_inferior_data)
10575         <task_list_valid_p>: Now bool.
10576         (read_known_tasks, ada_task_list_changed)
10577         (ada_tasks_invalidate_inferior_data): Update.
10578         (read_known_tasks_array): Return bool.
10579         (read_known_tasks_list): Likewise.
10580         (read_known_tasks): Return void.
10581         (ada_build_task_list): Now static.
10582
10583 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10584
10585         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10586         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10587
10588 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10589
10590         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10591         variant for ada_tasks_pspace_data_handle and
10592         ada_tasks_inferior_data_handle.
10593         (ada_tasks_pspace_data_cleanup): New function.
10594         (ada_tasks_inferior_data_cleanup): New function.
10595
10596 2019-02-17  Tom Tromey  <tom@tromey.com>
10597
10598         * macrotab.h (macro_source_fullname): Return a std::string.
10599         * macrotab.c (macro_include, check_for_redefinition)
10600         (macro_undef, macro_lookup_definition, foreach_macro)
10601         (foreach_macro_in_scope): Update.
10602         (macro_source_fullname): Return a std::string.
10603         * macrocmd.c (show_pp_source_pos): Update.
10604
10605 2019-02-17  Tom Tromey  <tom@tromey.com>
10606
10607         * macrocmd.c (show_pp_source_pos): Style the file names.
10608
10609 2019-02-17  Tom Tromey  <tom@tromey.com>
10610
10611         PR tui/24197:
10612         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10613
10614 2019-02-17  Tom Tromey  <tom@tromey.com>
10615
10616         * ada-lang.c (user_select_syms): Use filtered printing.
10617         * utils.c (wrap_style): New global.
10618         (desired_style): Remove.
10619         (emit_style_escape): Add stream parameter.
10620         (set_output_style, reset_terminal_style, prompt_for_continue):
10621         Update.
10622         (flush_wrap_buffer): Only flush gdb_stdout.
10623         (wrap_here): Set wrap_style.
10624         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10625         treat escape sequences as a character.  Change when wrap buffer is
10626         flushed.
10627         (fputs_styled): Do not set the output style when the default is
10628         requested.
10629         * ui-style.h (struct ui_file_style) <is_default>: New method.
10630         * source.c (print_source_lines_base): Emit escape sequences in one
10631         piece.
10632
10633 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10634
10635         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10636         integers and enumeration types.
10637
10638 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10639
10640         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10641         instead of lookup_symbol_in_language
10642         (do_exact_match): New function.
10643         (ada_get_symbol_name_matcher): Return do_exact_match when
10644         doing a verbatim match.
10645
10646 2019-02-15  Tom Tromey  <tromey@adacore.com>
10647
10648         * ravenscar-thread.c (ravenscar_thread_target::resume)
10649         (ravenscar_thread_target::wait): Special case wildcard requests.
10650
10651 2019-02-15  Tom Tromey  <tromey@adacore.com>
10652
10653         * ravenscar-thread.c (base_ptid): Remove.
10654         (struct ravenscar_thread_target) <close>: New method.
10655         <m_base_ptid>: New member.
10656         <update_inferior_ptid, active_task, task_is_currently_active,
10657         runtime_initialized>: Declare methods.
10658         <ravenscar_thread_target>: Add constructor.
10659         (ravenscar_thread_target::task_is_currently_active)
10660         (ravenscar_thread_target::update_inferior_ptid)
10661         (ravenscar_runtime_initialized): Rename.  Now methods.
10662         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10663         (ravenscar_thread_target::update_thread_list): Update.
10664         (ravenscar_thread_target::active_task): Now method.
10665         (ravenscar_thread_target::store_registers)
10666         (ravenscar_thread_target::prepare_to_store)
10667         (ravenscar_thread_target::prepare_to_store)
10668         (ravenscar_thread_target::mourn_inferior): Update.
10669         (ravenscar_inferior_created): Use "new" to create target.
10670         (ravenscar_thread_target::get_ada_task_ptid): Update.
10671         (_initialize_ravenscar): Don't initialize base_ptid.
10672         (ravenscar_ops): Remove global.
10673
10674 2019-02-15  Tom Tromey  <tromey@adacore.com>
10675
10676         * target.h (push_target): Declare new overload.
10677         * target.c (push_target): New overload, taking an rvalue reference.
10678         * remote.c (remote_target::open_1): Use push_target overload.
10679         * corelow.c (core_target_open): Use push_target overload.
10680
10681 2019-02-15  Tom Tromey  <tromey@adacore.com>
10682
10683         * ravenscar-thread.c (is_ravenscar_task)
10684         (ravenscar_task_is_currently_active): Return bool.
10685         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10686         (_initialize_ravenscar): Remove "(void)".
10687         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10688         Return bool.
10689
10690 2019-02-15  Tom Tromey  <tromey@adacore.com>
10691
10692         * ravenscar-thread.c (ravenscar_runtime_initializer)
10693         (has_ravenscar_runtime, get_running_thread_id)
10694         (ravenscar_thread_target::resume): Fix indentation.
10695
10696 2019-02-15  Tom Tromey  <tromey@adacore.com>
10697
10698         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10699         from ravenscar_arch_ops.
10700         (sparc_ravenscar_ops::fetch_registers)
10701         (sparc_ravenscar_ops::store_registers): Now methods.
10702         (sparc_ravenscar_prepare_to_store): Remove.
10703         (sparc_ravenscar_ops): Redefine.
10704         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10705         methods and destructor.  Remove members.
10706         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10707         (ravenscar_thread_target::store_registers)
10708         (ravenscar_thread_target::prepare_to_store): Update.
10709         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10710         Remove.
10711         (struct ppc_ravenscar_powerpc_ops): Derive from
10712         ravenscar_arch_ops.
10713         (ppc_ravenscar_powerpc_ops::fetch_registers)
10714         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10715         (ppc_ravenscar_powerpc_ops): Redefine.
10716         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10717         (ppc_ravenscar_e500_ops::fetch_registers)
10718         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10719         (ppc_ravenscar_e500_ops): Redefine.
10720         * aarch64-ravenscar-thread.c
10721         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10722         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10723         (aarch64_ravenscar_fetch_registers)
10724         (aarch64_ravenscar_store_registers): Now methods.
10725         (aarch64_ravenscar_ops): Redefine.
10726
10727 2019-02-15  Tom Tromey  <tromey@adacore.com>
10728
10729         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10730         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10731         (ravenscar_thread_target::stopped_by_watchpoint)
10732         (ravenscar_thread_target::stopped_data_address)
10733         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10734
10735 2019-02-15  Tom Tromey  <tromey@adacore.com>
10736
10737         * ravenscar-thread.c: Fix some typos.
10738
10739 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10740             Tom Tromey  <tromey@adacore.com>
10741
10742         * ada-lang.c (ada_exception_sal): Change addr_string to a
10743         std::string.
10744         (create_ada_exception_catchpoint): Update.
10745
10746 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10747             Tom Tromey  <tromey@adacore.com>
10748
10749         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10750         (bp_location_ops): Remove.
10751         (base_breakpoint_allocate_location): Update.
10752         (free_bp_location): Update.
10753         * ada-lang.c (class ada_catchpoint_location)
10754         <ada_catchpoint_location>: Remove ops parameter.
10755         (ada_catchpoint_location_dtor): Remove.
10756         (ada_catchpoint_location_ops): Remove.
10757         (allocate_location_exception): Update.
10758         * breakpoint.h (struct bp_location_ops): Remove.
10759         (class bp_location) <bp_location>: Remove bp_location_ops
10760         parameter.
10761         <~bp_location>: Add destructor.
10762         <ops>: Remove.
10763
10764 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10765             Pedro Alves  <palves@redhat.com>
10766
10767         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10768         'PATH_MAX'.
10769
10770 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10771             Samuel Thibault  <samuel.thibault@gnu.org>
10772             Thomas Schwinge  <thomas@codesourcery.com>
10773
10774         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10775         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10776
10777 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10778
10779         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10780         (check_empty): Use "const char *".
10781
10782         * gnu-nat.c (gnu_nat_target::detach): Instead of
10783         'detach_inferior (pid)' call
10784         'detach_inferior (find_inferior_pid (pid))'.
10785
10786         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10787         'nat/fork-inferior.o'.
10788         * gnu-nat.c: #include "nat/fork-inferior.h".
10789
10790         * gnu-nat.c (gnu_nat_target::detach): Instead of
10791         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10792         * gnu-nat.h: #include "inf-child.h".
10793         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10794         'i386_gnu_nat_target::fetch_registers'.
10795         (gnu_store_registers): Rename/move to
10796         'i386_gnu_nat_target::store_registers'.
10797
10798         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10799         * gnu-nat.h (mach_thread_info): New function.
10800         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10801
10802         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10803
10804 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10805
10806         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10807
10808 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10809
10810         * windows-nat.c (windows_add_thread): Add new parameter
10811         "main_thread_p" with default value set to false.  Update
10812         function documentation as well as all callers.
10813         (windows_delete_thread): Likewise.
10814         (fake_create_process): Update call to windows_add_thread.
10815         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10816         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10817         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10818         call to windows_delete_thread.
10819
10820 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10821
10822         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10823
10824 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10825
10826         * symfile.c (find_separate_debug_file): Use canonical path of
10827         sysroot with child_path instead of gdb_sysroot if it is valid.
10828
10829 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10830
10831         * symfile.c (find_separate_debug_file): Use child_path to
10832         determine if an object file is under a sysroot.
10833
10834 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10835
10836         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10837         unittests/child-path-selftests.c.
10838         * common/pathstuff.c (child_path): New function.
10839         * common/pathstuff.h (child_path): New prototype.
10840         * unittests/child-path-selftests.c: New file.
10841
10842 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10843
10844         * symfile.c (find_separate_debug_file): Look for separate debug
10845         files in debug directories under the sysroot.
10846
10847 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10848
10849         * symtab.h (struct minimal_symbol data_p): New const method.
10850         (struct minimal_symbol text_p): Likewise.
10851         * symtab.c (output_source_filename): Use file name style
10852         to print file name.
10853         (print_symbol_info): Likewise.
10854         (print_msymbol_info): Use address style to print addresses.
10855         Use function name style to print executable text symbols.
10856         (expand_symtab_containing_pc): Use data_p.
10857         (find_pc_sect_compunit_symtab): Likewise.
10858
10859 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10860
10861         * breakpoint.c (describe_other_breakpoints): Use address style
10862         to print addresses.
10863         (say_where): Likewise.
10864
10865 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10866
10867         * ada-typeprint.c (print_func_type): Print function name
10868         style to print function name.
10869         * c-typeprint.c (c_print_type_1): Likewise.
10870
10871 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10872
10873         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10874         for execve.
10875
10876 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10877
10878         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10879         type_stack.
10880
10881 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10882
10883         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10884         TYPE_CODE_REF types.
10885
10886 2019-02-08  Jim Wilson  <jimw@sifive.com>
10887
10888         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10889         (riscv_linux_fregset): New.
10890         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10891
10892 2019-02-07  Tom Tromey  <tom@tromey.com>
10893
10894         * thread.c (thread_cancel_execution_command): Update.
10895         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10896         methods.
10897         (struct thread_fsm_ops): Remove.
10898         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10899         (thread_fsm_should_stop, thread_fsm_return_value)
10900         (thread_fsm_set_finished, thread_fsm_finished_p)
10901         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10902         Don't declare.
10903         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10904         * infrun.c (clear_proceed_status_thread)
10905         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10906         (print_stop_event): Update.
10907         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10908         Add constructor.
10909         (step_command_fsm_ops): Remove.
10910         (new_step_command_fsm): Remove.
10911         (step_1): Update.
10912         (step_command_fsm::should_stop): Rename from
10913         step_command_fsm_should_stop.
10914         (step_command_fsm::clean_up): Rename from
10915         step_command_fsm_clean_up.
10916         (step_command_fsm::do_async_reply_reason): Rename from
10917         step_command_fsm_async_reply_reason.
10918         (struct until_next_fsm): Inherit from thread_fsm.  Add
10919         constructor.
10920         (until_next_fsm_ops): Remove.
10921         (new_until_next_fsm): Remove.
10922         (until_next_fsm::should_stop): Rename from
10923         until_next_fsm_should_stop.
10924         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10925         (until_next_fsm::do_async_reply_reason): Rename from
10926         until_next_fsm_async_reply_reason.
10927         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10928         constructor.  Change type of breakpoint.
10929         (finish_command_fsm_ops): Remove.
10930         (new_finish_command_fsm): Remove.
10931         (finish_command_fsm::should_stop): Rename from
10932         finish_command_fsm_should_stop.
10933         (finish_command_fsm::clean_up): Rename from
10934         finish_command_fsm_clean_up.
10935         (finish_command_fsm::return_value): Rename from
10936         finish_command_fsm_return_value.
10937         (finish_command_fsm::do_async_reply_reason): Rename from
10938         finish_command_fsm_async_reply_reason.
10939         (finish_command): Update.
10940         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10941         Add constructor.
10942         (call_thread_fsm_ops): Remove.
10943         (call_thread_fsm::call_thread_fsm): Rename from
10944         new_call_thread_fsm.
10945         (call_thread_fsm::should_stop): Rename from
10946         call_thread_fsm_should_stop.
10947         (call_thread_fsm::should_notify_stop): Rename from
10948         call_thread_fsm_should_notify_stop.
10949         (run_inferior_call, call_function_by_hand_dummy): Update.
10950         * cli/cli-interp.c (should_print_stop_to_console): Update.
10951         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10952         Add constructor.  Change type of location_breakpoint,
10953         caller_breakpoint.
10954         (until_break_fsm_ops): Remove.
10955         (new_until_break_fsm): Remove.
10956         (until_break_fsm::should_stop): Rename from
10957         until_break_fsm_should_stop.
10958         (until_break_fsm::clean_up): Rename from
10959         until_break_fsm_clean_up.
10960         (until_break_fsm::do_async_reply_reason): Rename from
10961         until_break_fsm_async_reply_reason.
10962         (until_break_command): Update.
10963         * thread-fsm.c: Remove.
10964         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10965
10966 2019-02-07  Tom Tromey  <tom@tromey.com>
10967
10968         * yy-remap.h: Add include guard.
10969         * xtensa-tdep.h: Add include guard.
10970         * xcoffread.h: Rename include guard.
10971         * varobj-iter.h: Add include guard.
10972         * tui/tui.h: Rename include guard.
10973         * tui/tui-winsource.h: Rename include guard.
10974         * tui/tui-wingeneral.h: Rename include guard.
10975         * tui/tui-windata.h: Rename include guard.
10976         * tui/tui-win.h: Rename include guard.
10977         * tui/tui-stack.h: Rename include guard.
10978         * tui/tui-source.h: Rename include guard.
10979         * tui/tui-regs.h: Rename include guard.
10980         * tui/tui-out.h: Rename include guard.
10981         * tui/tui-layout.h: Rename include guard.
10982         * tui/tui-io.h: Rename include guard.
10983         * tui/tui-hooks.h: Rename include guard.
10984         * tui/tui-file.h: Rename include guard.
10985         * tui/tui-disasm.h: Rename include guard.
10986         * tui/tui-data.h: Rename include guard.
10987         * tui/tui-command.h: Rename include guard.
10988         * tic6x-tdep.h: Add include guard.
10989         * target/waitstatus.h: Rename include guard.
10990         * target/wait.h: Rename include guard.
10991         * target/target.h: Rename include guard.
10992         * target/resume.h: Rename include guard.
10993         * target-float.h: Rename include guard.
10994         * stabsread.h: Add include guard.
10995         * rs6000-tdep.h: Add include guard.
10996         * riscv-fbsd-tdep.h: Add include guard.
10997         * regformats/regdef.h: Rename include guard.
10998         * record.h: Rename include guard.
10999         * python/python.h: Rename include guard.
11000         * python/python-internal.h: Rename include guard.
11001         * python/py-stopevent.h: Rename include guard.
11002         * python/py-ref.h: Rename include guard.
11003         * python/py-record.h: Rename include guard.
11004         * python/py-record-full.h: Rename include guard.
11005         * python/py-record-btrace.h: Rename include guard.
11006         * python/py-instruction.h: Rename include guard.
11007         * python/py-events.h: Rename include guard.
11008         * python/py-event.h: Rename include guard.
11009         * procfs.h: Add include guard.
11010         * proc-utils.h: Add include guard.
11011         * p-lang.h: Add include guard.
11012         * or1k-tdep.h: Rename include guard.
11013         * observable.h: Rename include guard.
11014         * nto-tdep.h: Rename include guard.
11015         * nat/x86-linux.h: Rename include guard.
11016         * nat/x86-linux-dregs.h: Rename include guard.
11017         * nat/x86-gcc-cpuid.h: Add include guard.
11018         * nat/x86-dregs.h: Rename include guard.
11019         * nat/x86-cpuid.h: Rename include guard.
11020         * nat/ppc-linux.h: Rename include guard.
11021         * nat/mips-linux-watch.h: Rename include guard.
11022         * nat/linux-waitpid.h: Rename include guard.
11023         * nat/linux-ptrace.h: Rename include guard.
11024         * nat/linux-procfs.h: Rename include guard.
11025         * nat/linux-osdata.h: Rename include guard.
11026         * nat/linux-nat.h: Rename include guard.
11027         * nat/linux-namespaces.h: Rename include guard.
11028         * nat/linux-btrace.h: Rename include guard.
11029         * nat/glibc_thread_db.h: Rename include guard.
11030         * nat/gdb_thread_db.h: Rename include guard.
11031         * nat/gdb_ptrace.h: Rename include guard.
11032         * nat/fork-inferior.h: Rename include guard.
11033         * nat/amd64-linux-siginfo.h: Rename include guard.
11034         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11035         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11036         * nat/aarch64-linux.h: Rename include guard.
11037         * nat/aarch64-linux-hw-point.h: Rename include guard.
11038         * mn10300-tdep.h: Add include guard.
11039         * mips-linux-tdep.h: Add include guard.
11040         * mi/mi-parse.h: Rename include guard.
11041         * mi/mi-out.h: Rename include guard.
11042         * mi/mi-main.h: Rename include guard.
11043         * mi/mi-interp.h: Rename include guard.
11044         * mi/mi-getopt.h: Rename include guard.
11045         * mi/mi-console.h: Rename include guard.
11046         * mi/mi-common.h: Rename include guard.
11047         * mi/mi-cmds.h: Rename include guard.
11048         * mi/mi-cmd-break.h: Rename include guard.
11049         * m2-lang.h: Add include guard.
11050         * location.h: Rename include guard.
11051         * linux-record.h: Rename include guard.
11052         * linux-nat.h: Add include guard.
11053         * linux-fork.h: Add include guard.
11054         * i386-darwin-tdep.h: Rename include guard.
11055         * hppa-linux-offsets.h: Add include guard.
11056         * guile/guile.h: Rename include guard.
11057         * guile/guile-internal.h: Rename include guard.
11058         * gnu-nat.h: Rename include guard.
11059         * gdb-stabs.h: Rename include guard.
11060         * frv-tdep.h: Add include guard.
11061         * f-lang.h: Add include guard.
11062         * event-loop.h: Add include guard.
11063         * darwin-nat.h: Rename include guard.
11064         * cp-abi.h: Rename include guard.
11065         * config/sparc/nm-sol2.h: Rename include guard.
11066         * config/nm-nto.h: Rename include guard.
11067         * config/nm-linux.h: Add include guard.
11068         * config/i386/nm-i386gnu.h: Rename include guard.
11069         * config/djgpp/nl_types.h: Rename include guard.
11070         * config/djgpp/langinfo.h: Rename include guard.
11071         * compile/gcc-cp-plugin.h: Add include guard.
11072         * compile/gcc-c-plugin.h: Add include guard.
11073         * compile/compile.h: Rename include guard.
11074         * compile/compile-object-run.h: Rename include guard.
11075         * compile/compile-object-load.h: Rename include guard.
11076         * compile/compile-internal.h: Rename include guard.
11077         * compile/compile-cplus.h: Rename include guard.
11078         * compile/compile-c.h: Rename include guard.
11079         * common/xml-utils.h: Rename include guard.
11080         * common/x86-xstate.h: Rename include guard.
11081         * common/version.h: Rename include guard.
11082         * common/vec.h: Rename include guard.
11083         * common/tdesc.h: Rename include guard.
11084         * common/selftest.h: Rename include guard.
11085         * common/scoped_restore.h: Rename include guard.
11086         * common/scoped_mmap.h: Rename include guard.
11087         * common/scoped_fd.h: Rename include guard.
11088         * common/safe-iterator.h: Rename include guard.
11089         * common/run-time-clock.h: Rename include guard.
11090         * common/refcounted-object.h: Rename include guard.
11091         * common/queue.h: Rename include guard.
11092         * common/ptid.h: Rename include guard.
11093         * common/print-utils.h: Rename include guard.
11094         * common/preprocessor.h: Rename include guard.
11095         * common/pathstuff.h: Rename include guard.
11096         * common/observable.h: Rename include guard.
11097         * common/netstuff.h: Rename include guard.
11098         * common/job-control.h: Rename include guard.
11099         * common/host-defs.h: Rename include guard.
11100         * common/gdb_wait.h: Rename include guard.
11101         * common/gdb_vecs.h: Rename include guard.
11102         * common/gdb_unlinker.h: Rename include guard.
11103         * common/gdb_unique_ptr.h: Rename include guard.
11104         * common/gdb_tilde_expand.h: Rename include guard.
11105         * common/gdb_sys_time.h: Rename include guard.
11106         * common/gdb_string_view.h: Rename include guard.
11107         * common/gdb_splay_tree.h: Rename include guard.
11108         * common/gdb_setjmp.h: Rename include guard.
11109         * common/gdb_ref_ptr.h: Rename include guard.
11110         * common/gdb_optional.h: Rename include guard.
11111         * common/gdb_locale.h: Rename include guard.
11112         * common/gdb_assert.h: Rename include guard.
11113         * common/filtered-iterator.h: Rename include guard.
11114         * common/filestuff.h: Rename include guard.
11115         * common/fileio.h: Rename include guard.
11116         * common/environ.h: Rename include guard.
11117         * common/common-utils.h: Rename include guard.
11118         * common/common-types.h: Rename include guard.
11119         * common/common-regcache.h: Rename include guard.
11120         * common/common-inferior.h: Rename include guard.
11121         * common/common-gdbthread.h: Rename include guard.
11122         * common/common-exceptions.h: Rename include guard.
11123         * common/common-defs.h: Rename include guard.
11124         * common/common-debug.h: Rename include guard.
11125         * common/cleanups.h: Rename include guard.
11126         * common/buffer.h: Rename include guard.
11127         * common/btrace-common.h: Rename include guard.
11128         * common/break-common.h: Rename include guard.
11129         * cli/cli-utils.h: Rename include guard.
11130         * cli/cli-style.h: Rename include guard.
11131         * cli/cli-setshow.h: Rename include guard.
11132         * cli/cli-script.h: Rename include guard.
11133         * cli/cli-interp.h: Rename include guard.
11134         * cli/cli-decode.h: Rename include guard.
11135         * cli/cli-cmds.h: Rename include guard.
11136         * charset-list.h: Add include guard.
11137         * buildsym-legacy.h: Rename include guard.
11138         * bfin-tdep.h: Add include guard.
11139         * ax.h: Rename include guard.
11140         * arm-linux-tdep.h: Add include guard.
11141         * arm-fbsd-tdep.h: Add include guard.
11142         * arch/xtensa.h: Rename include guard.
11143         * arch/tic6x.h: Add include guard.
11144         * arch/i386.h: Add include guard.
11145         * arch/arm.h: Rename include guard.
11146         * arch/arm-linux.h: Rename include guard.
11147         * arch/arm-get-next-pcs.h: Rename include guard.
11148         * arch/amd64.h: Add include guard.
11149         * arch/aarch64-insn.h: Rename include guard.
11150         * arch-utils.h: Rename include guard.
11151         * annotate.h: Add include guard.
11152         * amd64-darwin-tdep.h: Rename include guard.
11153         * aarch64-linux-tdep.h: Add include guard.
11154         * aarch64-fbsd-tdep.h: Add include guard.
11155         * aarch32-linux-nat.h: Add include guard.
11156
11157 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11158
11159         * macrotab.c (macro_define_internal): New function that
11160         factorizes macro_define_object_internal and macro_define_function
11161         code.
11162         (macro_define_object_internal): Use macro_define_internal.
11163         (macro_define_function): Likewise.
11164
11165 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11166
11167         * macrocmd.c (extract_identifier): Return
11168         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11169         callers.
11170
11171 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11172
11173         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11174
11175 2019-02-05  Tom Tromey  <tom@tromey.com>
11176
11177         * target.c (target_stack::unpush): Move assertion earlier.
11178
11179 2019-01-30  Tom Tromey  <tom@tromey.com>
11180
11181         PR python/23615:
11182         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11183         (gdbpy_parse_and_eval): Likewise.
11184         * python/python-internal.h (gdbpy_allow_threads): New class.
11185
11186 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11187
11188         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11189         (aarch64_fbsd_fpregmap): Move earlier.
11190         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11191         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11192         instead of individual calls to trad_frame_set_reg_addr.
11193         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11194         earlier.
11195         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11196         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11197         instead of individual calls to trad_frame_set_reg_addr.
11198
11199 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11200
11201         * CONTRIBUTE: Replace contribution list with wiki link.
11202
11203 2019-01-25  Tom Tromey  <tom@tromey.com>
11204
11205         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11206
11207 2019-01-25  Tom Tromey  <tom@tromey.com>
11208
11209         * xtensa-linux-nat.c: Fix common/ includes.
11210         * xml-support.h: Fix common/ includes.
11211         * xml-support.c: Fix common/ includes.
11212         * x86-linux-nat.c: Fix common/ includes.
11213         * windows-nat.c: Fix common/ includes.
11214         * varobj.h: Fix common/ includes.
11215         * varobj.c: Fix common/ includes.
11216         * value.c: Fix common/ includes.
11217         * valops.c: Fix common/ includes.
11218         * utils.c: Fix common/ includes.
11219         * unittests/xml-utils-selftests.c: Fix common/ includes.
11220         * unittests/utils-selftests.c: Fix common/ includes.
11221         * unittests/unpack-selftests.c: Fix common/ includes.
11222         * unittests/tracepoint-selftests.c: Fix common/ includes.
11223         * unittests/style-selftests.c: Fix common/ includes.
11224         * unittests/string_view-selftests.c: Fix common/ includes.
11225         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11226         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11227         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11228         * unittests/rsp-low-selftests.c: Fix common/ includes.
11229         * unittests/parse-connection-spec-selftests.c: Fix common/
11230         includes.
11231         * unittests/optional-selftests.c: Fix common/ includes.
11232         * unittests/offset-type-selftests.c: Fix common/ includes.
11233         * unittests/observable-selftests.c: Fix common/ includes.
11234         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11235         * unittests/memrange-selftests.c: Fix common/ includes.
11236         * unittests/memory-map-selftests.c: Fix common/ includes.
11237         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11238         * unittests/function-view-selftests.c: Fix common/ includes.
11239         * unittests/environ-selftests.c: Fix common/ includes.
11240         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11241         * unittests/common-utils-selftests.c: Fix common/ includes.
11242         * unittests/cli-utils-selftests.c: Fix common/ includes.
11243         * unittests/array-view-selftests.c: Fix common/ includes.
11244         * ui-file.c: Fix common/ includes.
11245         * tui/tui-io.c: Fix common/ includes.
11246         * tracepoint.h: Fix common/ includes.
11247         * tracepoint.c: Fix common/ includes.
11248         * tracefile-tfile.c: Fix common/ includes.
11249         * top.h: Fix common/ includes.
11250         * top.c: Fix common/ includes.
11251         * thread.c: Fix common/ includes.
11252         * target/waitstatus.h: Fix common/ includes.
11253         * target/waitstatus.c: Fix common/ includes.
11254         * target.h: Fix common/ includes.
11255         * target.c: Fix common/ includes.
11256         * target-memory.c: Fix common/ includes.
11257         * target-descriptions.c: Fix common/ includes.
11258         * symtab.h: Fix common/ includes.
11259         * symfile.c: Fix common/ includes.
11260         * stap-probe.c: Fix common/ includes.
11261         * spu-linux-nat.c: Fix common/ includes.
11262         * sparc-nat.c: Fix common/ includes.
11263         * source.c: Fix common/ includes.
11264         * solib.c: Fix common/ includes.
11265         * solib-target.c: Fix common/ includes.
11266         * ser-unix.c: Fix common/ includes.
11267         * ser-tcp.c: Fix common/ includes.
11268         * ser-pipe.c: Fix common/ includes.
11269         * ser-base.c: Fix common/ includes.
11270         * selftest-arch.c: Fix common/ includes.
11271         * s12z-tdep.c: Fix common/ includes.
11272         * rust-exp.y: Fix common/ includes.
11273         * rs6000-aix-tdep.c: Fix common/ includes.
11274         * riscv-tdep.c: Fix common/ includes.
11275         * remote.c: Fix common/ includes.
11276         * remote-notif.h: Fix common/ includes.
11277         * remote-fileio.h: Fix common/ includes.
11278         * remote-fileio.c: Fix common/ includes.
11279         * regcache.h: Fix common/ includes.
11280         * regcache.c: Fix common/ includes.
11281         * record-btrace.c: Fix common/ includes.
11282         * python/python.c: Fix common/ includes.
11283         * python/py-type.c: Fix common/ includes.
11284         * python/py-inferior.c: Fix common/ includes.
11285         * progspace.h: Fix common/ includes.
11286         * producer.c: Fix common/ includes.
11287         * procfs.c: Fix common/ includes.
11288         * proc-api.c: Fix common/ includes.
11289         * printcmd.c: Fix common/ includes.
11290         * ppc-linux-nat.c: Fix common/ includes.
11291         * parser-defs.h: Fix common/ includes.
11292         * osdata.c: Fix common/ includes.
11293         * obsd-nat.c: Fix common/ includes.
11294         * nat/x86-linux.c: Fix common/ includes.
11295         * nat/x86-linux-dregs.c: Fix common/ includes.
11296         * nat/x86-dregs.h: Fix common/ includes.
11297         * nat/x86-dregs.c: Fix common/ includes.
11298         * nat/ppc-linux.c: Fix common/ includes.
11299         * nat/mips-linux-watch.h: Fix common/ includes.
11300         * nat/mips-linux-watch.c: Fix common/ includes.
11301         * nat/linux-waitpid.c: Fix common/ includes.
11302         * nat/linux-ptrace.h: Fix common/ includes.
11303         * nat/linux-ptrace.c: Fix common/ includes.
11304         * nat/linux-procfs.c: Fix common/ includes.
11305         * nat/linux-personality.c: Fix common/ includes.
11306         * nat/linux-osdata.c: Fix common/ includes.
11307         * nat/linux-namespaces.c: Fix common/ includes.
11308         * nat/linux-btrace.h: Fix common/ includes.
11309         * nat/linux-btrace.c: Fix common/ includes.
11310         * nat/fork-inferior.c: Fix common/ includes.
11311         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11312         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11313         * nat/aarch64-linux.c: Fix common/ includes.
11314         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11315         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11316         * namespace.h: Fix common/ includes.
11317         * mips-linux-tdep.c: Fix common/ includes.
11318         * minsyms.c: Fix common/ includes.
11319         * mi/mi-parse.h: Fix common/ includes.
11320         * mi/mi-main.c: Fix common/ includes.
11321         * mi/mi-cmd-env.c: Fix common/ includes.
11322         * memrange.h: Fix common/ includes.
11323         * memattr.c: Fix common/ includes.
11324         * maint.h: Fix common/ includes.
11325         * maint.c: Fix common/ includes.
11326         * main.c: Fix common/ includes.
11327         * machoread.c: Fix common/ includes.
11328         * location.c: Fix common/ includes.
11329         * linux-thread-db.c: Fix common/ includes.
11330         * linux-nat.c: Fix common/ includes.
11331         * linux-fork.c: Fix common/ includes.
11332         * inline-frame.c: Fix common/ includes.
11333         * infrun.c: Fix common/ includes.
11334         * inflow.c: Fix common/ includes.
11335         * inferior.h: Fix common/ includes.
11336         * inferior.c: Fix common/ includes.
11337         * infcmd.c: Fix common/ includes.
11338         * inf-ptrace.c: Fix common/ includes.
11339         * inf-child.c: Fix common/ includes.
11340         * ia64-linux-nat.c: Fix common/ includes.
11341         * i387-tdep.c: Fix common/ includes.
11342         * i386-tdep.c: Fix common/ includes.
11343         * i386-linux-tdep.c: Fix common/ includes.
11344         * i386-linux-nat.c: Fix common/ includes.
11345         * i386-go32-tdep.c: Fix common/ includes.
11346         * i386-fbsd-tdep.c: Fix common/ includes.
11347         * i386-fbsd-nat.c: Fix common/ includes.
11348         * guile/scm-type.c: Fix common/ includes.
11349         * guile/guile.c: Fix common/ includes.
11350         * go32-nat.c: Fix common/ includes.
11351         * gnu-nat.c: Fix common/ includes.
11352         * gdbthread.h: Fix common/ includes.
11353         * gdbarch-selftests.c: Fix common/ includes.
11354         * gdb_usleep.c: Fix common/ includes.
11355         * gdb_select.h: Fix common/ includes.
11356         * gdb_bfd.c: Fix common/ includes.
11357         * gcore.c: Fix common/ includes.
11358         * fork-child.c: Fix common/ includes.
11359         * findvar.c: Fix common/ includes.
11360         * fbsd-nat.c: Fix common/ includes.
11361         * event-top.c: Fix common/ includes.
11362         * event-loop.c: Fix common/ includes.
11363         * dwarf2read.c: Fix common/ includes.
11364         * dwarf2loc.c: Fix common/ includes.
11365         * dwarf2-frame.c: Fix common/ includes.
11366         * dwarf-index-cache.c: Fix common/ includes.
11367         * dtrace-probe.c: Fix common/ includes.
11368         * disasm-selftests.c: Fix common/ includes.
11369         * defs.h: Fix common/ includes.
11370         * csky-tdep.c: Fix common/ includes.
11371         * cp-valprint.c: Fix common/ includes.
11372         * cp-support.h: Fix common/ includes.
11373         * cp-support.c: Fix common/ includes.
11374         * corelow.c: Fix common/ includes.
11375         * completer.h: Fix common/ includes.
11376         * completer.c: Fix common/ includes.
11377         * compile/compile.c: Fix common/ includes.
11378         * compile/compile-loc2c.c: Fix common/ includes.
11379         * compile/compile-cplus-types.c: Fix common/ includes.
11380         * compile/compile-cplus-symbols.c: Fix common/ includes.
11381         * command.h: Fix common/ includes.
11382         * cli/cli-dump.c: Fix common/ includes.
11383         * cli/cli-cmds.c: Fix common/ includes.
11384         * charset.c: Fix common/ includes.
11385         * build-id.c: Fix common/ includes.
11386         * btrace.h: Fix common/ includes.
11387         * btrace.c: Fix common/ includes.
11388         * breakpoint.h: Fix common/ includes.
11389         * breakpoint.c: Fix common/ includes.
11390         * ax.h:
11391         (enum agent_op): Fix common/ includes.
11392         * ax-general.c (struct aop_map): Fix common/ includes.
11393         * ax-gdb.c: Fix common/ includes.
11394         * auxv.c: Fix common/ includes.
11395         * auto-load.c: Fix common/ includes.
11396         * arm-tdep.c: Fix common/ includes.
11397         * arch/riscv.c: Fix common/ includes.
11398         * arch/ppc-linux-common.c: Fix common/ includes.
11399         * arch/i386.c: Fix common/ includes.
11400         * arch/arm.c: Fix common/ includes.
11401         * arch/arm-linux.c: Fix common/ includes.
11402         * arch/arm-get-next-pcs.c: Fix common/ includes.
11403         * arch/amd64.c: Fix common/ includes.
11404         * arch/aarch64.c: Fix common/ includes.
11405         * arch/aarch64-insn.c: Fix common/ includes.
11406         * arch-utils.c: Fix common/ includes.
11407         * amd64-windows-tdep.c: Fix common/ includes.
11408         * amd64-tdep.c: Fix common/ includes.
11409         * amd64-sol2-tdep.c: Fix common/ includes.
11410         * amd64-obsd-tdep.c: Fix common/ includes.
11411         * amd64-nbsd-tdep.c: Fix common/ includes.
11412         * amd64-linux-tdep.c: Fix common/ includes.
11413         * amd64-linux-nat.c: Fix common/ includes.
11414         * amd64-fbsd-tdep.c: Fix common/ includes.
11415         * amd64-fbsd-nat.c: Fix common/ includes.
11416         * amd64-dicos-tdep.c: Fix common/ includes.
11417         * amd64-darwin-tdep.c: Fix common/ includes.
11418         * agent.c: Fix common/ includes.
11419         * ada-lang.h: Fix common/ includes.
11420         * ada-lang.c: Fix common/ includes.
11421         * aarch64-tdep.c: Fix common/ includes.
11422
11423 2019-01-25  Tom Tromey  <tom@tromey.com>
11424
11425         * common/create-version.sh: Use common/version.h.
11426
11427 2019-01-24  Pedro Alves  <palves@redhat.com>
11428
11429         * infrun.c (signal_stop, signal_print, signal_program)
11430         (signal_catch, signal_pass): Now arrays instead of pointers.
11431         (update_signals_program_target, do_target_resume)
11432         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11433         * linux-nat.c (linux_nat_target::pass_signals)
11434         (linux_nat_target::create_inferior, linux_nat_target::attach):
11435         Adjust.
11436         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11437         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11438         * procfs.c (procfs_target::pass_signals): Adjust.
11439         * record-full.c (record_full_target::resume): Adjust.
11440         * remote.c (remote_target::pass_signals)
11441         (remote_target::program_signals): Adjust.
11442         * target-debug.h (target_debug_print_signals): Now takes a
11443         gdb::array_view as parameter.  Adjust.
11444         * target.h (target_ops) <pass_signals, program_signals>: Replace
11445         pointer and length parameters with gdb::array_view.
11446         (target_pass_signals, target_program_signals): Likewise.
11447         * target-delegates.c: Regenerate.
11448
11449 2019-01-24  Pedro Alves  <palves@redhat.com>
11450
11451         * common/forward-scope-exit.h
11452         (forward_scope_exit::forward_scope_exit): Pass arguments to
11453         m_bind_function directly, instead of creating a std::bind and
11454         copying that.
11455
11456 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11457
11458         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11459         for static members.
11460         (pass_in_v_vfp_candidate): Likewise.
11461
11462 2019-01-23  Tom Tromey  <tom@tromey.com>
11463             Pedro Alves  <palves@redhat.com>
11464
11465         * regcache.c (class regcache_invalidator): Remove.
11466         (regcache::raw_write): Use make_scope_exit.
11467
11468 2019-01-23  Tom Tromey  <tom@tromey.com>
11469
11470         * ui-out.h (class ui_out_emit_type): Update comment.
11471
11472 2019-01-23  Tom Tromey  <tom@tromey.com>
11473
11474         * infrun.c (fetch_inferior_event): Update comment.
11475
11476 2019-01-23  Tom Tromey  <tom@tromey.com>
11477             Pedro Alves  <palves@redhat.com>
11478
11479         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11480         parameter.
11481         (fetch_inferior_event): Use SCOPE_EXIT.
11482
11483
11484 2019-01-23  Tom Tromey  <tom@tromey.com>
11485             Pedro Alves  <palves@redhat.com>
11486
11487         * infrun.c (disable_thread_events): Delete.
11488         (stop_all_threads): Use SCOPE_EXIT.
11489
11490 2019-01-23  Tom Tromey  <tom@tromey.com>
11491             Pedro Alves  <palves@redhat.com>
11492
11493         * symfile.c: Include forward-scope-exit.h.
11494         (clear_symtab_users_cleanup): Replace forward declaration with
11495         a FORWARD_SCOPE_EXIT.
11496         (syms_from_objfile_1): Use the forward_scope_exit and
11497         gdb::optional instead of cleanup_function.
11498         (reread_symbols): Use the forward_scope_exit instead of
11499         cleanup_function.
11500         (clear_symtab_users_cleanup): Remove function.
11501
11502 2019-01-23  Tom Tromey  <tom@tromey.com>
11503             Pedro Alves  <palves@redhat.com>
11504
11505         * linux-nat.c: Include scope-exit.h.
11506         (cleanup_target_stop): Remove.
11507         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11508         SCOPE_EXIT.
11509
11510 2019-01-23  Tom Tromey  <tom@tromey.com>
11511             Pedro Alves  <palves@redhat.com>
11512
11513         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11514         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11515
11516 2019-01-23  Tom Tromey  <tom@tromey.com>
11517             Andrew Burgess  <andrew.burgess@embecosm.com>
11518             Pedro Alves  <palves@redhat.com>
11519
11520         * infrun.c (fetch_inferior_event): Use scope_exit.
11521         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11522         * top.c (execute_command): Use scope_exit.
11523         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11524         * utils.c (do_bpstat_clear_actions_cleanup)
11525         (make_bpstat_clear_actions_cleanup): Remove.
11526
11527 2019-01-23  Tom Tromey  <tom@tromey.com>
11528             Pedro Alves  <palves@redhat.com>
11529
11530         * infrun.c: Include "common/scope-exit.h"
11531         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11532         (wait_for_inferior): Use SCOPE_EXIT.
11533         (fetch_inferior_event): Use scope_exit.
11534
11535 2019-01-23  Tom Tromey  <tom@tromey.com>
11536             Pedro Alves  <palves@redhat.com>
11537
11538         * breakpoint.c (create_breakpoint): Remove cleanup.
11539
11540 2019-01-23  Tom Tromey  <tom@tromey.com>
11541             Andrew Burgess  <andrew.burgess@embecosm.com>
11542             Pedro Alves  <palves@redhat.com>
11543
11544 2019-01-23  Pedro Alves  <palves@redhat.com>
11545
11546         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11547
11548 2019-01-23  Pedro Alves  <palves@redhat.com>
11549             Andrew Burgess  <andrew.burgess@embecosm.com>
11550
11551         * gdbthread.h: Include "common/forward-scope-exit.h".
11552         (scoped_finish_thread_state): Redefine custom class in terms of
11553         forward_scope_exit.
11554
11555 2019-01-23  Pedro Alves  <palves@redhat.com>
11556             Andrew Burgess  <andrew.burgess@embecosm.com>
11557
11558         * common/forward-scope-exit.h: New file.
11559
11560 2019-01-23  Pedro Alves  <palves@redhat.com>
11561             Andrew Burgess  <andrew.burgess@embecosm.com>
11562             Tom Tromey  <tom@tromey.com>
11563
11564         * common/scope-exit.h: New file.
11565
11566 2019-01-23  Pedro Alves  <palves@redhat.com>
11567
11568         * common/preprocessor.h (ESC): Rename to ...
11569         (ESC_PARENS): ... this.
11570         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11571         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11572
11573 2019-01-23  Tom Tromey  <tom@tromey.com>
11574
11575         * language.h (class scoped_switch_to_sym_language_if_auto):
11576         Initialize m_lang in both cases.
11577
11578 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11579
11580         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11581         with XCNEW.
11582
11583 2019-01-22  Tom Tromey  <tom@tromey.com>
11584
11585         * corelow.c: Do not include sys/file.h.
11586
11587 2019-01-22  Tom Tromey  <tom@tromey.com>
11588
11589         * tui/tui-wingeneral.h: Include gdb_curses.h.
11590
11591 2019-01-22  Tom Tromey  <tom@tromey.com>
11592
11593         * source-cache.h (class source_cache) <get_source_lines,
11594         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11595
11596 2019-01-22  Tom Tromey  <tom@tromey.com>
11597
11598         * remote-fileio.h (struct remote_target): Declare.
11599
11600 2019-01-22  Tom Tromey  <tom@tromey.com>
11601
11602         * python/py-arch.c: Do not include py-ref.h.
11603         * python/py-bpevent.c: Do not include py-ref.h.
11604         * python/py-cmd.c: Do not include py-ref.h.
11605         * python/py-continueevent.c: Do not include py-ref.h.
11606         * python/py-event.h: Do not include py-ref.h.
11607         * python/py-evtregistry.c: Do not include py-ref.h.
11608         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11609         * python/py-frame.c: Do not include py-ref.h.
11610         * python/py-framefilter.c: Do not include py-ref.h.
11611         * python/py-function.c: Do not include py-ref.h.
11612         * python/py-infevents.c: Do not include py-ref.h.
11613         * python/py-linetable.c: Do not include py-ref.h.
11614         * python/py-objfile.c: Do not include py-ref.h.
11615         * python/py-param.c: Do not include py-ref.h.
11616         * python/py-prettyprint.c: Do not include py-ref.h.
11617         * python/py-progspace.c: Do not include py-ref.h.
11618         * python/py-symbol.c: Do not include py-ref.h.
11619         * python/py-symtab.c: Do not include py-ref.h.
11620         * python/py-type.c: Do not include py-ref.h.
11621         * python/py-unwind.c: Do not include py-ref.h.
11622         * python/py-utils.c: Do not include py-ref.h.
11623         * python/py-value.c: Do not include py-ref.h.
11624         * python/py-varobj.c: Do not include py-ref.h.
11625         * python/py-xmethods.c: Do not include py-ref.h.
11626         * python/python.c: Do not include py-ref.h.
11627         * varobj.c: Do not include py-ref.h.
11628
11629 2019-01-22  Tom Tromey  <tom@tromey.com>
11630
11631         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11632         keyword for bcache.
11633
11634 2019-01-22  Tom Tromey  <tom@tromey.com>
11635
11636         * compile/compile-cplus-types.c: Remove a comment by #include.
11637
11638 2019-01-22  Tom Tromey  <tom@tromey.com>
11639
11640         * compile/gcc-c-plugin.h: Include compile-internal.h.
11641
11642 2019-01-22  Tom Tromey  <tom@tromey.com>
11643
11644         * stabsread.c (EXTERN): Do not define.
11645         (symnum, next_symbol_text_func, processing_gcc_compilation)
11646         (within_function, global_sym_chain, global_stabs)
11647         (previous_stab_code, this_object_header_files)
11648         (n_this_object_header_files)
11649         (n_allocated_this_object_header_files): Define.
11650         * stabsread.h (EXTERN): Never define.  Use "extern".
11651
11652 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11653
11654         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11655         history_value.
11656
11657 2019-01-21  Tom Tromey  <tom@tromey.com>
11658
11659         * ui-out.c: Fix includes.
11660         * tui/tui-source.c: Fix includes.
11661         * target.c: Fix includes.
11662         * remote.c: Fix includes.
11663         * regcache.c: Fix includes.
11664         * python/py-block.c: Fix includes.
11665         * printcmd.c: Fix includes.
11666         * or1k-tdep.c: Fix includes.
11667         * mi/mi-main.c: Fix includes.
11668         * m32r-tdep.c: Fix includes.
11669         * csky-tdep.c: Fix includes.
11670         * compile/compile-cplus-types.c: Fix includes.
11671         * cli/cli-interp.c: Fix includes.
11672
11673 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11674
11675         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11676         for padding.
11677
11678 2019-01-16  Tom Tromey  <tom@tromey.com>
11679
11680         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11681         earlier.
11682         (struct objfile) <msymbols_range>: Move from top level.
11683         <msymbols>: New method.
11684         (class objfile_msymbols): Remove.
11685         * symtab.c (default_collect_symbol_completion_matches_break_on):
11686         Update.
11687         * symmisc.c (dump_msymbols): Update.
11688         * stabsread.c (scan_file_globals): Update.
11689         * objc-lang.c (info_selectors_command, info_classes_command)
11690         (find_methods): Update.
11691         * minsyms.c (find_solib_trampoline_target): Update.
11692         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11693         * coffread.c (coff_symfile_read): Update.
11694         * ada-lang.c (ada_lookup_simple_minsym)
11695         (ada_collect_symbol_completion_matches): Update.
11696
11697 2019-01-16  Tom Tromey  <tom@tromey.com>
11698
11699         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11700         type.  Remove no-argument constructor.
11701         <iterator::operator++>: Simplify.
11702         <begin>: Update.
11703         <end>: Use minimal_symbol_count.
11704
11705 2019-01-16  Tom Tromey  <tom@tromey.com>
11706
11707         * objfiles.h (struct objfile) <psymtabs>: New method.
11708         (class objfile_psymtabs): Remove.
11709         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11710         typedef.
11711         <range>: New method.
11712         (require_partial_symbols): Change return type.
11713         * psymtab.c (require_partial_symbols)
11714         (psym_expand_symtabs_matching): Update.
11715         * mdebugread.c (parse_partial_symbols): Update.
11716         * dbxread.c (dbx_end_psymtab): Update.
11717
11718 2019-01-15  Tom Tromey  <tom@tromey.com>
11719
11720         * symtab.c (lookup_objfile_from_block)
11721         (lookup_symbol_in_objfile_symtabs)
11722         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11723         (find_line_symtab, info_sources_command)
11724         (default_collect_symbol_completion_matches_break_on)
11725         (make_source_files_completion_list): Update.
11726         * symmisc.c (print_objfile_statistics, dump_objfile)
11727         (maintenance_print_symbols, maintenance_info_symtabs)
11728         (maintenance_check_symtabs, maintenance_info_line_tables):
11729         Update.
11730         * source.c (select_source_symtab)
11731         (forget_cached_source_info_for_objfile): Update.
11732         * objfiles.h (class objfile_compunits): Remove.
11733         (struct objfile) <compunits_range>: New typedef.
11734         (compunits): New method.
11735         * objfiles.c (objfile_relocate1): Update.
11736         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11737         * maint.c (count_symtabs_and_blocks): Update.
11738         * linespec.c (iterate_over_all_matching_symtabs): Update.
11739         * cp-support.c (add_symbol_overload_list_qualified): Update.
11740         * coffread.c (coff_symtab_read): Update.
11741         * ada-lang.c (add_nonlocal_symbols)
11742         (ada_collect_symbol_completion_matches)
11743         (ada_add_global_exceptions): Update.
11744
11745 2019-01-15  Tom Tromey  <tom@tromey.com>
11746
11747         * progspace.h (program_space) <objfiles_safe_range>: New
11748         typedef.
11749         <objfiles_safe>: New method.
11750         * objfiles.h (class all_objfiles_safe): Remove.
11751         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11752         * jit.c (jit_inferior_exit_hook): Update.
11753
11754 2019-01-17  Tom Tromey  <tom@tromey.com>
11755
11756         * progspace.h (program_space) <objfiles_range>: New typedef.
11757         <objfiles>: New method.
11758         <objfiles_head>: Rename from objfiles.
11759         (object_files): Update.
11760         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11761         * guile/scm-pretty-print.c
11762         (ppscm_find_pretty_printer_from_objfiles): Update.
11763         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11764         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11765         Update.
11766         * python/py-progspace.c (pspy_get_objfiles): Update.
11767         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11768         Update.
11769         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11770         (objfpy_lookup_objfile_by_build_id): Update.
11771         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11772         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11773         Update.
11774         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11775         (expand_symtab_containing_pc, lookup_objfile_from_block)
11776         (lookup_static_symbol, basic_lookup_transparent_type)
11777         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11778         (find_line_symtab, info_sources_command)
11779         (default_collect_symbol_completion_matches_break_on)
11780         (make_source_files_completion_list, find_main_name): Update.
11781         * symmisc.c (print_symbol_bcache_statistics)
11782         (print_objfile_statistics, maintenance_print_symbols)
11783         (maintenance_print_msymbols, maintenance_print_objfiles)
11784         (maintenance_info_symtabs, maintenance_check_symtabs)
11785         (maintenance_expand_symtabs, maintenance_info_line_tables):
11786         Update.
11787         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11788         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11789         (map_overlay_command, unmap_overlay_command)
11790         (simple_overlay_update, expand_symtabs_matching)
11791         (map_symbol_filenames): Update.
11792         * symfile-debug.c (set_debug_symfile): Update.
11793         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11794         Update.
11795         * source.c (select_source_symtab, forget_cached_source_info):
11796         Update.
11797         * solib.c (solib_read_symbols): Update.
11798         * solib-spu.c (append_ocl_sos): Update.
11799         * psymtab.c (maintenance_print_psymbols)
11800         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11801         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11802         * printcmd.c (info_symbol_command): Update.
11803         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11804         Update.
11805         * objfiles.h (class all_objfiles): Remove.
11806         * objfiles.c (have_partial_symbols, have_full_symbols)
11807         (have_minimal_symbols, qsort_cmp, update_section_map)
11808         (shared_objfile_contains_address_p)
11809         (default_iterate_over_objfiles_in_search_order): Update.
11810         * objc-lang.c (info_selectors_command, info_classes_command)
11811         (find_methods): Update.
11812         * minsyms.c (find_solib_trampoline_target): Update.
11813         * maint.c (maintenance_info_sections)
11814         (maintenance_translate_address, count_symtabs_and_blocks):
11815         Update.
11816         * main.c (captured_main_1): Update.
11817         * linux-thread-db.c (try_thread_db_load_from_pdir)
11818         (has_libpthread): Update.
11819         * linespec.c (iterate_over_all_matching_symtabs)
11820         (search_minsyms_for_name): Update.
11821         * jit.c (jit_find_objf_with_entry_addr): Update.
11822         * hppa-tdep.c (find_unwind_entry)
11823         (hppa_lookup_stub_minimal_symbol): Update.
11824         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11825         Update.
11826         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11827         (elf_gnu_ifunc_resolve_by_got): Update.
11828         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11829         * dwarf-index-write.c (save_gdb_index_command): Update.
11830         * cp-support.c (add_symbol_overload_list_qualified): Update.
11831         * breakpoint.c (create_overlay_event_breakpoint)
11832         (create_longjmp_master_breakpoint)
11833         (create_std_terminate_master_breakpoint)
11834         (create_exception_master_breakpoint): Update.
11835         * blockframe.c (find_pc_partial_function): Update.
11836         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11837         (ada_collect_symbol_completion_matches)
11838         (ada_add_global_exceptions): Update.
11839
11840 2019-01-17  Tom Tromey  <tom@tromey.com>
11841
11842         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11843         declare VEC.
11844         (solib_target_parse_libraries): Change return type.
11845         (library_list_start_segment, library_list_start_section)
11846         (library_list_end_library, library_list_start_library); Update.
11847         (solib_target_free_library_list): Remove.
11848         (solib_target_parse_libraries): Remove cleanup.  Change return
11849         type.
11850         (solib_target_current_sos): Update.
11851
11852 2019-01-17  Tom Tromey  <tromey@bapiya>
11853
11854         * valprint.c: Replace "the the" with "the".
11855         * symtab.c: Replace "the the" with "the".
11856         * solib.c: Replace "the the" with "the".
11857         * solib-dsbt.c: Replace "the the" with "the".
11858         * linespec.c: Replace "the the" with "the".
11859         * dwarf2loc.h: Replace "the the" with "the".
11860         * amd64-windows-tdep.c: Replace "the the" with "the".
11861         * aarch64-tdep.c: Replace "the the" with "the".
11862
11863 2019-01-16  Keith Seitz  <keiths@redhat.com>
11864
11865         PR gdb/23773
11866         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11867         <builder>: Rename to ..
11868         <m_builder>: ... this and make private.
11869         (dwarf2_cu::get_builder): New method.  Change all users of
11870         `builder' to use this method.
11871         (dwarf2_start_symtab): Move to ...
11872         (dwarf2_cu::start_symtab): ... here.  Update all callers
11873         (setup_type_unit_groups): Move to ...
11874         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11875         callers.
11876         (dwarf2_cu::reset_builder): New method.
11877         (process_full_compunit, process_full_type_unit): Use
11878         dwarf2_cu::reset_builder.
11879         (follow_die_offset): Record the ancestor CU if it is different
11880         from the followed DIE's CU.
11881         (follow_die_sig_1): Likewise.
11882
11883 2019-01-15  Tom Tromey  <tom@tromey.com>
11884
11885         * remote.c (class remote_state) <buf>: Now a char_vector.
11886         <buf_size>: Remove.
11887         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11888         parameter.
11889         (remote_target::getpkt_or_notif_sane_1)
11890         (remote_target::getpkt_sane)
11891         (remote_target::getpkt_or_notif_sane): Likewise.
11892         (class remote_target) <putpkt>: New overload.
11893         (remote_target::read_frame): Change type of "buf_p".  Remove
11894         sizeof_p parameter.
11895         (packet_ok): New overload.
11896         (packet_check_result): New overload.
11897         Update all uses.
11898
11899 2019-01-14  Tom Tromey  <tom@tromey.com>
11900
11901         * remote-notif.c (handle_notification, remote_notif_ack)
11902         (remote_notif_parse): Make "buf" const.
11903         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11904         const.
11905         (remote_notif_parse, remote_notif_ack, handle_notification):
11906         Likewise.
11907         * remote.c (remote_notif_stop_parse): Make "buf" const.
11908         (remote_target::remote_parse_stop_reply): Make "buf" const.
11909         (remote_notif_stop_ack): Make "buf" const.
11910
11911 2019-01-14  Tom Tromey  <tom@tromey.com>
11912
11913         * remote.c (remote_console_output): Make parameter const.
11914
11915 2019-01-14  Tom Tromey  <tom@tromey.com>
11916
11917         * target-debug.h (target_debug_print_signals): Constify.
11918         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11919         * procfs.c (procfs_target::pass_signals): Update.
11920         * linux-nat.c (linux_nat_target::pass_signals): Update.
11921         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11922         * target-delegates.c: Rebuild.
11923         * remote.c (remote_target::program_signals): Update.
11924         (remote_target::pass_signals): Update.
11925         * target.c (target_pass_signals): Constify argument.
11926         (target_program_signals): Likewise.
11927         * target.h (struct target_ops) <pass_signals, program_signals>:
11928         Constify argument.
11929         (target_pass_signals, target_program_signals): Constify argument.
11930
11931 2019-01-14  Tom Tromey  <tom@tromey.com>
11932
11933         PR tui/28819:
11934         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11935
11936 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11937
11938         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11939         field.
11940         * rs6000-tdep.c: Include reggroups.h.
11941         (IS_V_ALIAS_PSEUDOREG): Define.
11942         (rs6000_register_name): Return names for the "vX" aliases.
11943         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11944         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11945         aliases.  Call default_register_reggroup_p for all other
11946         pseudo-registers.
11947         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11948         New functions.
11949         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11950         Handle "vX" aliases.
11951         (v_alias_pseudo_register_collect): New function.
11952         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11953         (rs6000_gdbarch_init): Initialize "vX" aliases as
11954         pseudo-registers.  Restore registration of
11955         rs6000_pseudo_register_reggroup_p with
11956         set_tdesc_pseudo_register_reggroup_p.
11957
11958 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11959
11960         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11961         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11962         set_gdbarch_num_pseudo_regs.
11963
11964 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11965
11966         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11967         Remove arg prefixname, add do_set and do_show.
11968         Add member functions set_list and show_list.
11969         * cli/cli-style.c (class cli_style_option): Update accordingly.
11970         (style_set_list): Move to file scope.
11971         (style_show_list): Likewise.
11972         (set_style): Call help_list.
11973         (show_style): Call cmd_show_list.
11974         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11975         Update to use the new macro.
11976
11977 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11978
11979         * ada-lang.c (_initialize_ada_language): Expand the help text
11980         for the "catch exception" command.
11981
11982 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11983
11984         * symtab.c (matching_obj_sections): Initialize obj,
11985         declare it closer to its usage.
11986
11987 2019-01-10  Tom Tromey  <tom@tromey.com>
11988
11989         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11990         (basic_inf_threads_range): Remove.
11991         (inf_threads_range, inf_non_exited_threads_range)
11992         (safe_inf_threads_range): Use next_adapter.
11993
11994 2019-01-10  Keith Seitz  <keiths@redhat.com>
11995
11996         PR gdb/23712
11997         PR symtab/23010
11998         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11999         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12000
12001 2019-01-10  Keith Seitz  <keiths@redhat.com>
12002
12003         PR gdb/23712
12004         PR symtab/23010
12005         * dictionary.c (pending_to_vector): Remove.
12006         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12007         Remove _1 suffix, replacing functions of the same name.  Update
12008         all callers.
12009         (dict_create_hashed, dict_create_hashed_expandable)
12010         (dict_create_linear, dict_create_linear_expandable, dict_free)
12011         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12012         Make functions static.
12013
12014 2019-01-10  Keith Seitz  <keiths@redhat.com>
12015
12016         PR gdb/23712
12017         PR symtab/23010
12018         * dictionary.h (struct dictionary): Replace declaration with
12019         multidictionary.
12020         (dict_create_hashed, dict_create_hashed_expandable)
12021         (dict_create_linear, dict_create_linear_expandable)
12022         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12023         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12024         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12025         taking multidictionary argument.
12026         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12027         * block.h (struct block) <dict>: Change to multidictionary
12028         and rename `multidict'.
12029         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12030         symmisc.c: Update all dictionary references to multidictionary.
12031
12032 2019-01-10  Keith Seitz  <keiths@redhat.com>
12033
12034         PR gdb/23712
12035         PR symtab/23010
12036         * dictionary.c: Include unordered_map.
12037         (pending_to_vector): New function.
12038         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12039         Rewrite the non-"_1" functions to take vector instead
12040         of linked list.
12041         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12042         "new" _1 versions of the same name.
12043         (multidictionary): Define.
12044         (std::hash<enum language): New definition.
12045         (collate_pending_symbols_by_language, mdict_create_hashed)
12046         (mdict_create_hashed_expandable, mdict_create_linear)
12047         (mdict_create_linear_expandable, mdict_free)
12048         (find_language_dictionary, create_new_language_dictionary)
12049         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12050         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12051         (mdict_size, mdict_empty): New functions.
12052         * dictionary.h (mdict_iterator): Define.
12053
12054 2019-01-10  Pedro Alves  <palves@redhat.com>
12055
12056         * breakpoint.c (read_uploaded_action)
12057         (create_tracepoint_from_upload): Adjust to use
12058         gdb::unique_xmalloc_ptr.
12059         * ctf.c (ctf_write_uploaded_tp):
12060         (SET_ARRAY_FIELD): Use emplace_back.
12061         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12062         * tracefile-tfile.c (tfile_write_uploaded_tp):
12063         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12064         gdb::unique_xmalloc_ptr.
12065         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12066         at_string, cond_string, cmd_strings>: Replace char pointers
12067         with gdb::unique_xmalloc_ptr.
12068
12069 2019-01-10  Pedro Alves  <palves@redhat.com>
12070
12071         * solib-target.c (library_list_start_library): Don't xstrdup name.
12072
12073 2019-01-10  Pedro Alves  <palves@redhat.com>
12074
12075         * mdebugread.c (parse_partial_symbols): Use
12076         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12077
12078 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12079
12080         * linux-fork.c (scoped_switch_fork_info)
12081         <~scoped_switch_fork_info>: Fix incorrect variable name.
12082
12083 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12084
12085         * linux-fork.c (scoped_switch_fork_info)
12086         <scoped_switch_fork_info>: Make explicit.
12087         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12088
12089 2019-01-10  Tom Tromey  <tom@tromey.com>
12090
12091         * objfiles.h (objfile::reset_psymtabs): Update.
12092         * objfiles.c (objfile::objfile): Update.
12093         * psymtab.h (psymtab_storage::obstack): Update.
12094         (psymtab_storage::m_obstack): Use gdb::optional.
12095         (class psymtab_storage): Update comment.  Remove objfile
12096         parameter.
12097         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12098
12099 2019-01-10  Tom Tromey  <tom@tromey.com>
12100
12101         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12102         <free_psymtabs>: Now private.
12103         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12104         (allocate_psymtab): Use new method.
12105
12106 2019-01-10  Tom Tromey  <tom@tromey.com>
12107
12108         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12109         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12110         * mdebugread.c (parse_partial_symbols): Use
12111         allocate_dependencies.
12112         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12113         allocate_dependencies.
12114         (process_psymtab_comp_unit_reader)
12115         (build_type_psymtab_dependencies): Likewise.
12116         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12117
12118 2019-01-10  Tom Tromey  <tom@tromey.com>
12119
12120         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12121         PSYMBOL_SET_LANGUAGE.
12122         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12123
12124 2019-01-10  Tom Tromey  <tom@tromey.com>
12125
12126         * psymtab.h (psymtab_storage::obstack): New method.
12127         <m_obstack>: Rename from obstack; now private.
12128         * psymtab.c (psymtab_storage): Update.
12129         * dwarf2read.c (create_addrmap_from_index)
12130         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12131         Update.
12132
12133 2019-01-10  Tom Tromey  <tom@tromey.com>
12134
12135         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12136         * objfiles.h (objfile::reset_psymtabs): New method.
12137
12138 2019-01-10  Tom Tromey  <tom@tromey.com>
12139
12140         * symmisc.c (print_symbol_bcache_statistics): Update.
12141         (print_objfile_statistics): Update.
12142         * symfile.c (reread_symbols): Update.
12143         * psymtab.h (class psymtab_storage): New.
12144         * psymtab.c (psymtab_storage): New constructor.
12145         (~psymtab_storage): New destructor.
12146         (require_partial_symbols): Update.
12147         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12148         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12149         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12150         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12151         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12152         (start_psymtab_common, end_psymtab_common)
12153         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12154         (allocate_psymtab): Update.
12155         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12156         Update.
12157         (dump_psymtab_addrmap, maintenance_print_psymbols)
12158         (maintenance_check_psymtabs): Update.
12159         (class objfile_psymtabs): Move to objfiles.h.
12160         * psympriv.h (discard_psymtab): Now inline.
12161         (psymtab_discarder::psymtab_discarder): Update.
12162         (psymtab_discarder::~psymtab_discarder): Update.
12163         (ALL_OBJFILE_PSYMTABS): Rewrite.
12164         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12165         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12166         Remove fields.
12167         <partial_symtabs>: New field.
12168         (class objfile_psymtabs): Move from psymtab.h.  Update.
12169         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12170         psymbol_cache.
12171         (objfile::~objfile): Don't destroy psymbol_cache.
12172         * mdebugread.c (parse_partial_symbols): Update.
12173         * dwarf2read.c (create_addrmap_from_index)
12174         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12175         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12176         (add_partial_subprogram, dwarf2_ranges_read): Update.
12177         * dwarf-index-write.c (write_address_map)
12178         (write_one_signatured_type, recursively_write_psymbols)
12179         (class debug_names, class debug_names, write_psymtabs_to_index):
12180         Update.
12181
12182 2019-01-10  Tom Tromey  <tom@tromey.com>
12183
12184         * symtab.h (SYMBOL_SET_NAMES): Update.
12185         (symbol_set_names): Update.
12186         (MSYMBOL_SET_NAMES): Update.
12187         * symtab.c (symbol_set_names): Change argument to be an
12188         objfile_per_bfd_storage.
12189         * psymtab.c (add_psymbol_to_bcache): Update.
12190         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12191
12192 2019-01-10  Tom Tromey  <tom@tromey.com>
12193
12194         * symtab.c (create_demangled_names_hash): Change argument to be an
12195         objfile_per_bfd_storage.
12196         (symbol_set_names): Update.
12197
12198 2019-01-10  Tom Tromey  <tom@tromey.com>
12199
12200         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12201         init_psymbol_list.
12202         * psymtab.c (init_psymbol_list): Do nothing if already called.
12203         * psympriv.h (init_psymbol_list): Add comment.
12204         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12205         init_psymbol_list.
12206         * dbxread.c (dbx_symfile_read): Unconditionally call
12207         init_psymbol_list.
12208
12209 2019-01-10  Tom Tromey  <tom@tromey.com>
12210
12211         * xcoffread.c (scan_xcoff_symtab): Update.
12212         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12213         "where".
12214         * mdebugread.c (parse_partial_symbols)
12215         (handle_psymbol_enumerators): Update.
12216         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12217         * dbxread.c (read_dbx_symtab): Update.
12218         * psympriv.h (psymbol_placement): New enum.
12219         (add_psymbol_to_list): Update.
12220
12221 2019-01-10  Tom Tromey  <tom@tromey.com>
12222
12223         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12224         static_psymbols parameters.
12225         (scan_xcoff_symtab): Update.
12226         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12227         static_psymbols parameters.
12228         * psympriv.h (start_psymtab_common): Update.
12229         * mdebugread.c (parse_partial_symbols): Update.
12230         * dwarf2read.c (create_partial_symtab): Update.
12231         * dbxread.c (read_dbx_symtab): Update.
12232         (start_psymtab): Remove global_psymbols and static_psymbols
12233         parameters.
12234
12235 2019-01-10  Tom Tromey  <tom@tromey.com>
12236
12237         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12238         * psymtab.c (allocate_psymtab): Add comment.
12239         * psympriv.h (allocate_psymtab): Add comment.
12240         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12241         initializations.
12242         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12243
12244 2019-01-10  Tom Tromey  <tom@tromey.com>
12245
12246         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12247         Don't declare.
12248         * mipsread.c: Include mdebugread.h.
12249         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12250         Declare.
12251         * elfread.c: Include mdebugread.h.
12252
12253 2019-01-09  Tom Tromey  <tom@tromey.com>
12254
12255         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12256         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12257         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12258         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12259         (psym_lookup_symbol, psym_find_last_source_symtab)
12260         (psym_forget_cached_source_info, psym_print_stats)
12261         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12262         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12263         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12264         (psym_find_compunit_symtab_by_address)
12265         (maintenance_print_psymbols, maintenance_info_psymtabs)
12266         (maintenance_check_psymtabs): Use ranged for.
12267         * psymtab.h (class objfile_psymtabs): New.
12268         (require_partial_symbols): Return objfile_psymtabs.
12269         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12270
12271 2019-01-09  Tom Tromey  <tom@tromey.com>
12272
12273         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12274         (find_pc_mapped_section, list_overlays_command)
12275         (map_overlay_command, unmap_overlay_command)
12276         (simple_overlay_update): Use all_objfiles.
12277         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12278         * printcmd.c (info_symbol_command): Use all_objfiles.
12279         * objfiles.h (ALL_OBJSECTIONS): Remove.
12280         * maint.c (maintenance_translate_address): Use all_objfiles.
12281         * gcore.c (gcore_create_callback): Use all_objfiles.
12282         (objfile_find_memory_regions): Likewise.
12283
12284 2019-01-09  Tom Tromey  <tom@tromey.com>
12285
12286         * symtab.c (find_line_symtab, info_sources_command)
12287         (make_source_files_completion_list): Use objfile_compunits.
12288         * source.c (select_source_symtab): Use objfile_compunits.
12289         * objfiles.h (struct objfile): Update comment.
12290         (ALL_OBJFILES): Remove.
12291         (ALL_FILETABS): Remove.
12292         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12293         objfile_compunits.
12294
12295 2019-01-09  Tom Tromey  <tom@tromey.com>
12296
12297         * symmisc.c (print_objfile_statistics, dump_objfile)
12298         (maintenance_print_symbols): Use compunit_filetabs.
12299         * source.c (forget_cached_source_info_for_objfile): Use
12300         compunit_filetabs.
12301         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12302         (ALL_FILETABS): Use compunit_filetabs.
12303         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12304         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12305
12306 2019-01-09  Tom Tromey  <tom@tromey.com>
12307
12308         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12309         (compunit_filetabs): New.
12310         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12311         compunit_filetabs.
12312         (info_sources_command, make_source_files_completion_list): Remove
12313         declaration.
12314         * symmisc.c (print_objfile_statistics, dump_objfile)
12315         (maintenance_print_symbols): Remove declaration.
12316         (maintenance_info_symtabs): Use compunit_filetabs.
12317         (maintenance_info_line_tables): Likewise.
12318         * source.c (select_source_symtab): Change local variable name.
12319         (forget_cached_source_info_for_objfile): Remove declaration.
12320         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12321         * objfiles.c (objfile_relocate1): Remove declaration.
12322         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12323         declaration.
12324         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12325         * coffread.c (coff_symtab_read): Remove declaration.
12326         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12327         compunit_filetabs.
12328
12329 2019-01-09  Tom Tromey  <tom@tromey.com>
12330
12331         * symtab.c (lookup_objfile_from_block)
12332         (find_pc_sect_compunit_symtab, search_symbols)
12333         (default_collect_symbol_completion_matches_break_on): Use
12334         objfile_compunits.
12335         * objfiles.h (ALL_COMPUNITS): Remove.
12336         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12337         * cp-support.c (add_symbol_overload_list_qualified): Use
12338         objfile_compunits.
12339         * ada-lang.c (ada_collect_symbol_completion_matches)
12340         (ada_add_global_exceptions): Use objfile_compunits.
12341
12342 2019-01-09  Tom Tromey  <tom@tromey.com>
12343
12344         * source.c (select_source_symtab)
12345         (forget_cached_source_info_for_objfile): Remove declaration.
12346         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12347         declaration.
12348         * maint.c (count_symtabs_and_blocks): Remove declaration.
12349         * cp-support.c (add_symbol_overload_list_qualified): Remove
12350         declaration.
12351         * coffread.c (coff_symtab_read): Remove declaration.
12352         * symtab.c (lookup_symbol_in_objfile_symtabs)
12353         (basic_lookup_transparent_type_1): Use objfile_compunits.
12354         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12355         (info_sources_command, search_symbols)
12356         (default_collect_symbol_completion_matches_break_on)
12357         (make_source_files_completion_list): Remove declaration.
12358         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12359         (ada_collect_symbol_completion_matches)
12360         (ada_add_global_exceptions): Remove declaration.
12361         * linespec.c (iterate_over_all_matching_symtabs): Use
12362         objfile_compunits.
12363         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12364         (class objfile_compunits): New.
12365         (ALL_COMPUNITS): Use objfile_compunits.
12366         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12367         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12368         objfile_compunits.
12369         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12370
12371 2019-01-09  Tom Tromey  <tom@tromey.com>
12372
12373         * symtab.c (search_symbols)
12374         (default_collect_symbol_completion_matches_break_on): Use
12375         objfile_msymbols.
12376         * ada-lang.c (ada_lookup_simple_minsym)
12377         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12378         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12379         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12380         objfile_msymbols.
12381         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12382         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12383         * objc-lang.c (find_methods): Use objfile_msymbols.
12384         (info_selectors_command, info_classes_command): Likewise.
12385         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12386         * objfiles.h (class objfile_msymbols): New.
12387         (ALL_OBJFILE_MSYMBOLS): Remove.
12388         (ALL_MSYMBOLS): Remove.
12389
12390 2019-01-09  Tom Tromey  <tom@tromey.com>
12391
12392         * common/next-iterator.h (next_adapter): Add Iterator template
12393         parameter.
12394         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12395         (class all_objfiles_safe): New.
12396         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12397         * objfiles.c (put_objfile_before): Update comment.
12398         (add_separate_debug_objfile): Likewise.
12399         (free_all_objfiles): Use all_objfiles_safe.
12400         (objfile_purge_solibs): Likewise.
12401
12402 2019-01-09  Tom Tromey  <tom@tromey.com>
12403
12404         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12405         (expand_symtab_containing_pc, lookup_static_symbol)
12406         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12407         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12408         all_objfiles.
12409         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12410         * breakpoint.c (create_overlay_event_breakpoint)
12411         (create_longjmp_master_breakpoint)
12412         (create_std_terminate_master_breakpoint)
12413         (create_exception_master_breakpoint): Use all_objfiles.
12414         * linux-thread-db.c (try_thread_db_load_from_pdir)
12415         (has_libpthread): Use all_objfiles.
12416         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12417         * linespec.c (iterate_over_all_matching_symtabs)
12418         (search_minsyms_for_name): Use all_objfiles.
12419         * maint.c (maintenance_info_sections): Use all_objfiles.
12420         * main.c (captured_main_1): Use all_objfiles.
12421         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12422         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12423         * guile/scm-pretty-print.c
12424         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12425         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12426         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12427         (maintenance_print_msymbols): Use all_objfiles.
12428         * source.c (select_source_symtab): Use all_objfiles.
12429         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12430         * symfile.c (remove_symbol_file_command)
12431         (expand_symtabs_matching, map_symbol_filenames): Use
12432         all_objfiles.
12433         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12434         all_objfiles.
12435         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12436         * objc-lang.c (find_methods): Use all_objfiles.
12437         * objfiles.c (have_partial_symbols, have_full_symbols)
12438         (have_minimal_symbols, qsort_cmp)
12439         (default_iterate_over_objfiles_in_search_order): Use
12440         all_objfiles.
12441         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12442         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12443         (maintenance_check_psymtabs): Use all_objfiles.
12444         (ALL_PSYMTABS): Remove.
12445         * compile/compile-object-run.c (do_module_cleanup): Use
12446         all_objfiles.
12447         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12448         * cp-support.c (add_symbol_overload_list_qualified): Use
12449         all_objfiles.
12450         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12451         Use all_objfiles.
12452         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12453         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12454         all_objfiles.
12455         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12456         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12457         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12458         Uses all_objfiles.
12459         * solib.c (solib_read_symbols): Use all_objfiles
12460
12461 2019-01-09  Tom Tromey  <tom@tromey.com>
12462
12463         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12464         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12465         all_objfiles.
12466         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12467         * symmisc.c (print_symbol_bcache_statistics)
12468         (print_objfile_statistics, maintenance_print_objfiles)
12469         (maintenance_info_symtabs, maintenance_check_symtabs)
12470         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12471         all_objfiles.
12472         * source.c (forget_cached_source_info): Use all_objfiles.
12473         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12474         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12475         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12476         * objfiles.c (update_section_map): Use all_objfiles.
12477         (shared_objfile_contains_address_p): Likewise.
12478         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12479         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12480
12481 2019-01-09  Tom Tromey  <tom@tromey.com>
12482
12483         * common/next-iterator.h: New file.
12484         * objfiles.h (class all_objfiles): New.
12485         (struct objfile_iterator): New.
12486
12487 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12488
12489         * NEWS: Move the description of the changed "frame", "select-frame",
12490          and "info frame" commands to the Changed commands section.
12491
12492 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12493
12494         * gdbtypes.c (check_stub_method_group): Remove handling of old
12495         mangling schemes.
12496         * linespec.c (find_methods): Likewise.
12497         * stabsread.c (read_member_functions): Likewise.
12498         * valops.c (search_struct_method): Likewise.
12499         (value_struct_elt_for_reference): Likewise.
12500         * NEWS: Mention this change.
12501
12502 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12503
12504         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12505         print_source_lines.
12506         * source.c (print_source_lines_base): Update line number check.
12507         (print_source_lines): New function.
12508         (source_lines_range::source_lines_range): New function.
12509         * source.h (class source_lines_range): New class.
12510         (print_source_lines): New declaration.
12511
12512 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12513
12514         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12515
12516 2019-01-08  Tom Tromey  <tom@tromey.com>
12517             Simon Marchi  <simon.marchi@ericsson.com>
12518
12519         PR gdb/24060
12520         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12521         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12522         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12523         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12524         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12525         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12526
12527 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12528
12529         * source.c (select_source_symtab): Move header comment to
12530         declaration in source.h.
12531         (forget_cached_source_info_for_objfile): Likewise.
12532         (forget_cached_source_info): Likewise.
12533         (identify_source_line): Likewise.
12534         * source.h (identify_source_line): Move declaration from symtab.h
12535         and add comment from source.c
12536         (print_source_lines): Likewise.
12537         (forget_cached_source_info_for_objfile): Likewise.
12538         (forget_cached_source_info): Likewise.
12539         (select_source_symtab): Likewise.
12540         (enum print_source_lines_flag): Move definition from symtab.h.
12541         * symtab.h (identify_source_line): Move declaration to source.h.
12542         (print_source_lines): Likewise.
12543         (forget_cached_source_info_for_objfile): Likewise.
12544         (forget_cached_source_info): Likewise.
12545         (select_source_symtab): Likewise.
12546         (enum print_source_lines_flag): Move definition to source.h.
12547         * tui/tui-hooks.c: Add 'source.h' include.
12548
12549 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12550
12551         * source.c (print_source_lines_base): Handle requests to print
12552         reverse line number sequences, and guard against empty lines
12553         string.
12554
12555 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12556
12557         * source.c (print_source_lines_base): Fix skip of '\r' if next
12558         character is '\n'.
12559
12560 2019-01-06  Tom Tromey  <tom@tromey.com>
12561
12562         * c-exp.y (struct c_parse_state) <macro_original_text,
12563         expansion_obstack>: New member.
12564         (macro_original_text, expansion_obstack): Remove globals.
12565         (scan_macro_expansion, scanning_macro_expansion)
12566         (finished_macro_expansion): Update.
12567         (scan_macro_cleanup): Remove.
12568         (yylex, c_parse): Update.
12569
12570 2019-01-06  Tom Tromey  <tom@tromey.com>
12571
12572         * c-exp.y (struct c_parse_state) <strings>: New member.
12573         (operator_stoken): Update.
12574
12575 2019-01-06  Tom Tromey  <tom@tromey.com>
12576
12577         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12578         (union type_stack_elt) <typelist_val>: Now a pointer to
12579         std::vector.
12580         (type_stack_cleanup): Don't declare.
12581         (push_typelist): Update.
12582         * parse.c (pop_typelist): Return a std::vector.
12583         (push_typelist): Take a std::vector.
12584         (follow_types): Update.  Do not free args.
12585         (type_stack_cleanup): Remove.
12586         * c-exp.y (struct c_parse_state): New.
12587         (cpstate): New global.
12588         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12589         (nonempty_typelist): Update.
12590         (func_mod): Create a new vector.
12591         (c_parse): Create a c_parse_state.
12592         (check_parameter_typelist): Do not delete params.
12593         (function_method): Update.  Do not delete type_list.
12594
12595 2019-01-06  Tom Tromey  <tom@tromey.com>
12596
12597         PR gdb/28155:
12598         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12599         check_typedef.
12600         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12601         (print_return_value): Likewise.
12602
12603 2019-01-05  Tom Tromey  <tom@tromey.com>
12604
12605         * contrib/cleanup_check.py: Remove.
12606         * contrib/gcc-with-excheck: Remove.
12607         * contrib/exsummary.py: Remove.
12608         * contrib/excheck.py: Remove.
12609
12610 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12611
12612         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12613         NULL. Initialize tpprev to NULL instead of assigning it
12614         to NULL on the next statement.
12615         * windows-nat.c (windows_delete_thread): Remove check for
12616         main_thread_id before printing thread exit notifications.
12617         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12618         Remove thread ID check against main_thread_id.
12619         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12620         windows_delete_thread.
12621         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12622
12623 2019-01-04  Tom Tromey  <tom@tromey.com>
12624
12625         * compile/compile.c (_initialize_compile): Use upper case for
12626         metasyntactic variables.
12627         * symmisc.c (_initialize_symmisc): Use upper case for
12628         metasyntactic variables.
12629         * psymtab.c (_initialize_psymtab): Use upper case for
12630         metasyntactic variables.
12631         * demangle.c (demangle_command): Use upper case for metasyntactic
12632         variables.
12633         (_initialize_demangler): Likewise.
12634         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12635         variables.
12636
12637 2019-01-03  Tom Tromey  <tom@tromey.com>
12638
12639         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12640
12641 2019-01-03  Tom Tromey  <tom@tromey.com>
12642
12643         * python/py-symtab.c (salpy_str): Update.
12644         (struct salpy_sal_object) <symtab>: Now a PyObject.
12645         (salpy_dealloc): Update.
12646         (del_objfile_sal): Use gdbpy_ref.
12647
12648 2019-01-03  Tom Tromey  <tom@tromey.com>
12649
12650         * python/py-type.c (convert_field): Use new_reference.  Return
12651         gdbpy_ref.
12652         (make_fielditem): Return gdbpy_ref.
12653         (typy_fields): Update.
12654         (typy_getitem): Update.
12655         (field_name): Return gdbpy_ref.  Use new_reference.
12656         (typy_iterator_iternext): Update.
12657
12658 2019-01-03  Tom Tromey  <tom@tromey.com>
12659
12660         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12661
12662 2019-01-03  Tom Tromey  <tom@tromey.com>
12663
12664         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12665         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12666         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12667         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12668         (pspy_set_type_printers): Likewise.
12669         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12670         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12671         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12672         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12673         (objfpy_set_type_printers): Likewise.
12674
12675 2019-01-03  Tom Tromey  <tom@tromey.com>
12676
12677         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12678         (gdbpy_print_stack): Use gdbpy_err_fetch.
12679         * python/python-internal.h (class gdbpy_err_fetch): New class.
12680         (class gdbpy_enter) <m_error_type, m_error_value,
12681         m_error_traceback>: Remove.
12682         <m_error>: New member.
12683         (gdbpy_exception_to_string): Don't declare.
12684         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12685         * python/py-value.c (convert_value_from_python): Use
12686         gdbpy_err_fetch.
12687         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12688         gdbpy_exception_to_string.
12689         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12690         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12691         gdbpy_err_fetch.
12692
12693 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12694
12695         * linux-nat.c (delete_lwp_cleanup): Delete.
12696         (struct lwp_deleter): New struct.
12697         (lwp_info_up): New typedef.
12698         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12699         lwp_info_up.
12700
12701 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12702
12703         * linux-fork.c (class scoped_switch_fork_info): New class.
12704         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12705
12706 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12707
12708         * valops.c (find_overload_match): Remove use of null_cleanup, and
12709         calls to do_cleanups.
12710
12711 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12712
12713         * compile/compile-cplus-types.c
12714         (compile_cplus_instance::decl_name): Handle changes to
12715         cp_func_name.
12716         * cp-support.c (cp_func_name): Update header comment, update
12717         return type.
12718         * cp-support.h (cp_func_name): Update return type in declaration.
12719         * valops.c (find_overload_match): Move temp_func local to top
12720         level of function and change its type.  Use temp_func to hold and
12721         delete temporary string obtained from cp_func_name.
12722
12723 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12724
12725         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12726         gdb::char_vector, remove cleanup, and update uses of `msg`.
12727
12728 2019-01-03  Jim Wilson  <jimw@sifive.com>
12729
12730         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12731
12732 2019-01-02  Tom Tromey  <tom@tromey.com>
12733
12734         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12735         (tdesc_parse_xml): Remove cleanups.
12736         * target-descriptions.h (make_cleanup_free_target_description):
12737         Don't declare.
12738         (target_desc_deleter): New struct.
12739         (target_desc_up): New typedef.
12740         * target-descriptions.c (target_desc_deleter::operator()): Rename
12741         from free_target_description.
12742         (make_cleanup_free_target_description): Remove.
12743
12744 2019-01-02  Tom Tromey  <tom@tromey.com>
12745
12746         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12747         constructor, destructor.
12748         (linespec_parser): Remove typedef.
12749         (~linespec_parser): Rename from linespec_parser_delete.
12750         (linespec_lex_to_end, linespec_complete_label)
12751         (linespec_complete): Update.
12752         (decode_line_full): Remove cleanups.
12753         (decode_line_1): Update.
12754
12755 2019-01-02  Tom Tromey  <tom@tromey.com>
12756
12757         * python/python-internal.h (inferior_to_inferior_object): Change
12758         return type.
12759         * python/py-exitedevent.c (create_exited_event_object): Update.
12760         * python/py-inferior.c (inferior_to_inferior_object): Return
12761         gdbpy_ref.
12762         (python_new_inferior, python_inferior_deleted)
12763         (thread_to_thread_object, delete_thread_object)
12764         (build_inferior_list, gdbpy_selected_inferior): Update.
12765         * python/py-infthread.c (create_thread_object): Update.  Also fail
12766         if inferior_to_inferior_object fails.
12767
12768 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12769
12770         * inferior.h (class inferior) <displaced_step_state>: New field.
12771         * infrun.h (struct displaced_step_state): Move here from
12772         infrun.c.  Initialize fields, add constructor.
12773         <inf>: Remove field.
12774         <reset>: New method.
12775         * infrun.c (struct displaced_step_inferior_state): Move to
12776         infrun.h.
12777         (displaced_step_inferior_states): Remove.
12778         (get_displaced_stepping_state): Adust.
12779         (displaced_step_in_progress_any_inferior): Adjust.
12780         (displaced_step_in_progress_thread): Adjust.
12781         (displaced_step_in_progress): Adjust.
12782         (add_displaced_stepping_state): Remove.
12783         (get_displaced_step_closure_by_addr): Adjust.
12784         (remove_displaced_stepping_state): Remove.
12785         (infrun_inferior_exit): Call displaced_step_state.reset.
12786         (use_displaced_stepping): Don't check for NULL.
12787         (displaced_step_prepare_throw): Call
12788         get_displaced_stepping_state.
12789         (displaced_step_fixup): Don't check for NULL.
12790         (prepare_for_detach): Don't check for NULL.
12791
12792 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12793
12794         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12795          in case of call that did not complete.
12796
12797 2019-01-02  Andrey Utkin  <autkin@undo.io>
12798
12799         * symfile.c (find_separate_debug_file): Fix search of debug files for
12800         remote debuggee.
12801
12802 2019-01-02  Tom Tromey  <tom@tromey.com>
12803
12804         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12805         indentation.
12806         * python/py-frame.c (frapy_older): Remove cast.
12807         (frapy_newer): Likewise.
12808         * python/py-breakpoint.c (local_setattro): Remove cast.
12809         * python/py-arch.c (archpy_name): Remove local variable.
12810         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12811
12812 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12813
12814         * unittests/basic_string_view/element_access/char/empty.cc:
12815         Fix year range in copyright header.
12816
12817 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12818
12819         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12820         Delete.
12821         <operator==>: Update with for removed field.
12822         <hash>: Likewise.
12823         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12824         <isa_features>: ...this.
12825         <abi_features>: New field.
12826         (riscv_isa_flen): Update comment.
12827         (riscv_abi_xlen): New declaration.
12828         (riscv_abi_flen): New declaration.
12829         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12830         isa_features.
12831         (riscv_abi_xlen): New function.
12832         (riscv_isa_flen): Update to get answer from isa_features.
12833         (riscv_abi_flen): New function.
12834         (riscv_has_fp_abi): Update to get answer from abi_features.
12835         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12836         xlen and flen.
12837         (riscv_call_info) <xlen, flen>: Update comment.
12838         (riscv_call_arg_struct): Remove invalid assertions
12839         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12840         is removed.
12841         (riscv_gdbarch_init): Gather isa features and abi features
12842         separately, ensure both match on the gdbarch when reusing an old
12843         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12844         a target with 64-bit float hardware.
12845
12846 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12847
12848         * source.c (search_command_helper): Stop reverse search
12849         when line 1 has been searched.
12850
12851 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12852
12853         * record-full.c (record_full_base_target::close): Rewrite
12854         record_full_core_buf_list free logic.
12855
12856 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12857
12858         * break-catch-syscall.c (print_one_catch_syscall): xfree
12859         the last text.
12860
12861 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12862
12863         * top.c (print_gdb_version): Update Copyright year in version
12864         message.
12865
12866 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12867
12868         Update copyright year range in all GDB files.
12869
12870 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12871
12872         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12873
12874 For older changes see ChangeLog-2018.
12875 \f
12876 Local Variables:
12877 mode: change-log
12878 left-margin: 8
12879 fill-column: 74
12880 version-control: never
12881 coding: utf-8
12882 End:
12883