gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tromey@adacore.com>
   2
   3         * c-lang.c (c_get_string): Handle non-C-style arrays.
   4
   5 2019-05-08  Tom Tromey  <tromey@adacore.com>
   6
   7         * typeprint.c (print_offset_data::update): Print the bit offset,
   8         not the number of bits remaining.
   9
  10 2019-05-08  Tom Tromey  <tromey@adacore.com>
  11
  12         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
  13         padding at end of comment.
  14
  15 2019-05-08  Tom Tromey  <tromey@adacore.com>
  16
  17         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
  18         Compare main types.
  19
  20 2019-05-06  Tom Tromey  <tom@tromey.com>
  21
  22         * common/scoped_mmap.c: Include common-defs.h.
  23         * common/scoped_mmap.h: Don't include config.h.
  24
  25 2019-05-04  Tom Tromey  <tom@tromey.com>
  26
  27         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
  28         (struct aarch64_call_info): Add initializers.
  29         <si>: Now a std::vector.
  30         (pass_on_stack, aarch64_push_dummy_call): Update.
  31
  32 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
  33             Tom Tromey  <tom@tromey.com>
  34
  35         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
  36         (ppc_threads): Now a std::vector.  Now static.
  37         (hwdebug_find_thread_points_by_tid)
  38         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
  39         Update.
  40
  41 2019-05-04  Tom Tromey  <tom@tromey.com>
  42
  43         * arc-tdep.c (arc_tdesc_init): Return bool.
  44
  45 2019-05-04  Tom Tromey  <tom@tromey.com>
  46
  47         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
  48         Use gdb_assert_not_reached.
  49
  50 2019-05-04  Tom Tromey  <tom@tromey.com>
  51
  52         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
  53         "false".
  54
  55 2019-05-04  Tom Tromey  <tom@tromey.com>
  56
  57         * arc-tdep.c (arc_tdesc_init): Use bool.
  58
  59 2019-05-04  Tom Tromey  <tom@tromey.com>
  60
  61         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
  62
  63 2019-05-04  Tom Tromey  <tom@tromey.com>
  64
  65         * cli/cli-cmds.c (valid_command_p): Return bool.
  66
  67 2019-05-04  Tom Tromey  <tom@tromey.com>
  68
  69         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
  70         * command.h (valid_user_defined_cmd_name_p): Channge return type.
  71
  72 2019-05-04  Raul Tambre  <raul@tambre.ee>
  73
  74         * python/lib/gdb/prompt.py (_ExtendedPrompt)
  75         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
  76         operator for comparison.
  77
  78 2019-05-04  Tom Tromey  <tom@tromey.com>
  79
  80         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  81         (lookup_partial_symbol, print_partial_symbols)
  82         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  83         (psymbol_compare): Update.
  84         (add_psymbol_to_bcache): Clear the entire psymbol.
  85         (maintenance_check_psymtabs): Update.
  86         * psympriv.h (struct partial_symbol): Don't derive from
  87         general_symbol_info.
  88         <obj_section, unrelocated_address, address,
  89         set_unrelocated_address>: Update.
  90         <ginfo>: New member.
  91         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  92         (debug_names::write_psymbols): Update.
  93
  94 2019-05-04  Tom de Vries  <tdevries@suse.de>
  95
  96         * contrib/cc-with-tweaks.sh: Support -n arg.
  97
  98 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  99
 100         * corelow.c (core_target::detach): Ensure frame cache and
 101         register caches are cleared.
 102         inferior.c (exit_inferior_1): Likewise.
 103
 104 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 105             Tom Tromey  <tom@tromey.com>
 106
 107         * dictionary.c (collate_pending_symbols_by_language): Remove
 108         "struct" from foreach.
 109         * symtab.c (lookup_global_symbol_from_objfile)
 110         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 111         foreach.
 112         * ser-tcp.c (net_open): Remove "struct" from foreach.
 113         * objfiles.c (objfile_relocate, objfile_rebase)
 114         (objfile_has_symbols): Remove "struct" from foreach.
 115         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 116         from foreach.
 117         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 118         foreach.
 119         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 120         "struct" from foreach.
 121         * ada-lang.c (create_excep_cond_exprs)
 122         (ada_exception_catchpoint_cond_string): Remove "struct" from
 123         foreach.
 124
 125 2019-05-03  Tom Tromey  <tromey@adacore.com>
 126
 127         * ada-exp.y (convert_char_literal): Check suffix of each
 128         enumerator.
 129
 130 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 131
 132         PR ada/21406:
 133         * ada-exp.y (yywrap): Don't define.
 134         * ada-lex.l (%option): Add noyywrap
 135         (yywrap): Remove.
 136
 137 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 138
 139         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 140         _WIN32_WINNT to the XP level, unless already defined to a higher
 141         level.
 142
 143         * unittests/parse-connection-spec-selftests.c:
 144         * ser-tcp.c:
 145         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 146         override.
 147
 148         * symfile.c (find_separate_debug_file): Remove colon from the
 149         drive spec of DOS/Windows file names of the target, so that the
 150         file name produced from DEBUGDIR and the target's directory will
 151         be valid on DOS/Windows systems.
 152
 153 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 154
 155         * rust-lang.c (val_print_struct): Handle printing structures
 156         containing strings.
 157
 158 2019-05-02  Tom Tromey  <tromey@adacore.com>
 159
 160         * valarith.c (_initialize_valarith): Remove.
 161
 162 2019-05-01  Tom Tromey  <tromey@adacore.com>
 163
 164         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 165         bitfields.
 166
 167 2019-05-01  Tom Tromey  <tromey@adacore.com>
 168
 169         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 170         for big-endian copies.
 171
 172 2019-04-30  Ali Tamur  <tamur@google.com>
 173         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 174         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 175         (read_3_bytes): New function.
 176
 177 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 178
 179         * windows-nat.c (main_thread_id): Delete.
 180         (handle_output_debug_string): Replace main_thread_id by
 181         current_event.dwThreadId.
 182         (fake_create_process): Likewise.
 183         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 184         Do not set main_thread_id.
 185         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 186         current_event.dwThreadId.
 187         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 188
 189 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 190
 191         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 192         Use current_event.dwThreadId instead of main_thread_id.
 193
 194 2019-04-30  Tom Tromey  <tromey@adacore.com>
 195
 196         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 197         (create_excep_cond_exprs): Iterate over program spaces.
 198         (ada_exception_catchpoint_cond_string): Examine all minimal
 199         symbols for exception types.
 200
 201 2019-04-30  Tom Tromey  <tromey@adacore.com>
 202
 203         PR c++/24470:
 204         * dwarf2read.c (process_structure_scope): Handle case where type
 205         has template parameters but no symbol was created.
 206
 207 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 208             Chris January  <chris.january@arm.com>
 209
 210         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 211         qualifier.
 212         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 213
 214 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 215
 216         * f-typeprint.c (f_print_type): Update rules for printing
 217         whitespace.
 218         (f_type_print_varspec_suffix): Likewise.
 219
 220 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 221             Chris January  <chris.january@arm.com>
 222
 223         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 224         function arguments.
 225
 226 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 227
 228         * f-lang.c (build_fortran_types): Change name of void type to
 229         lower case.
 230         * f-typeprint.c (f_type_print_base): Print the name of the void
 231         type, rather than a fixed string.
 232         * f-valprint.c (f_decorations): Use lower case void string.
 233
 234 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 235             Chris January  <chris.january@arm.com>
 236
 237         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 238         types for Fortran.
 239
 240 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 241             Chris January  <chris.january@arm.com>
 242             David Lecomber  <david.lecomber@arm.com>
 243
 244         * f-exp.y (BINOP_INTRINSIC): New token.
 245         (exp): New parser rule handling BINOP_INTRINSIC.
 246         (f77_keywords): Add new builtin procedures.
 247         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 248         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 249         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 250         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 251         (print_unop_subexp_f): New function.
 252         (print_binop_subexp_f): New function.
 253         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 254         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 255         (dump_subexp_body_f): Likewise.
 256         (operator_check_f): Likewise.
 257         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 258         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 259
 260 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 261
 262         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 263         UNOP_KIND.
 264         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 265         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 266         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 267         (operator_length_f): New fuction.
 268         (print_subexp_f): New function.
 269         (op_name_f): New function.
 270         (dump_subexp_body_f): New function.
 271         (operator_check_f): New function.
 272         (exp_descriptor_f): Replace standard expression handling functions
 273         with new functions.
 274         * gdb/fortran-operator.def: New file.
 275         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 276         * gdb/std-operator.def: Remove UNOP_KIND.
 277
 278 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 279
 280         * std-operator.def: Remove unbalanced, stray double quote
 281         character.
 282
 283 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 284             Chris January  <chris.january@arm.com>
 285             Daniel Everett  <daniel.everett@arm.com>
 286             Nick Forrington  <nick.forrington@arm.com>
 287             Richard Bunt  <richard.bunt@arm.com>
 288
 289         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 290         of depth when printing anonymous structs or unions.
 291         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 292         Don't print either the top-level value, or the children if the
 293         max-depth is exceeded.
 294         (ppscm_print_children): When printing the key of a map, allow one
 295         extra level of depth.
 296         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 297         print either the top-level value, or the children if the max-depth
 298         is exceeded.
 299         (print_children): When printing the key of a map, allow one extra
 300         level of depth.
 301         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 302         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 303         (user_print_options): Initialise max_depth field.
 304         (val_print_scalar_or_string_type_p): New function.
 305         (val_print): Check to see if the max depth has been reached.
 306         (val_print_check_max_depth): Define new function.
 307         (show_print_max_depth): New function.
 308         (_initialize_valprint): Add 'print max-depth' option.
 309         * valprint.h (struct value_print_options) <max_depth>: New field.
 310         (val_print_check_max_depth): Declare new function.
 311         * NEWS: Document new feature.
 312
 313 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 314
 315         * ada-lang.c (ada_language_defn): Initialise new field.
 316         * c-lang.c (c_is_string_type_p): New function.
 317         (c_language_defn): Initialise new field.
 318         (cplus_language_defn): Initialise new field.
 319         (asm_language_defn): Initialise new field.
 320         (minimal_language_defn): Initialise new field.
 321         * c-lang.h (c_is_string_type_p): Declare new function.
 322         * d-lang.c (d_language_defn): Initialise new field.
 323         * f-lang.c (f_is_string_type_p): New function.
 324         (f_language_defn): Initialise new field.
 325         * go-lang.c (go_is_string_type_p): New function.
 326         (go_language_defn): Initialise new field.
 327         * language.c (default_is_string_type_p): New function.
 328         (unknown_language_defn): Initialise new field.
 329         (auto_language_defn): Initialise new field.
 330         * language.h (struct language_defn) <la_is_string_type_p>: New
 331         member variable.
 332         (default_is_string_type_p): Declare new function.
 333         * m2-lang.c (m2_language_defn): Initialise new field.
 334         * objc-lang.c (objc_language_defn): Initialise new field.
 335         * opencl-lang.c (opencl_language_defn): Initialise new field.
 336         * p-lang.c (pascal_is_string_type_p): New function.
 337         (pascal_language_defn): Initialise new field.
 338         * rust-lang.c (rust_is_string_type_p): New function.
 339         (rust_language_defn): Initialise new field.
 340
 341 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 342
 343         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 344         New field.
 345         * ada-lang.c (ada_language_defn): Initialise new field.
 346         * c-lang.c (c_language_defn): Likewise.
 347         (cplus_language_defn): Likewise.
 348         (asm_language_defn): Likewise.
 349         (minimal_language_defn): Likewise.
 350         * d-lang.c (d_language_defn): Likewise.
 351         * f-lang.c (f_language_defn): Likewise.
 352         * go-lang.c (go_language_defn): Likewise.
 353         * language.c (unknown_language_defn): Likewise.
 354         (auto_language_defn): Likewise.
 355         * m2-lang.c (m2_language_defn): Likewise.
 356         * objc-lang.c (objc_language_defn): Likewise.
 357         * opencl-lang.c (opencl_language_defn): Likewise.
 358         * p-lang.c (pascal_language_defn): Likewise.
 359         * rust-lang.c (rust_language_defn): Likewise.
 360
 361 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 362
 363         * ada-lang.c (ada_is_character_type): Change return type to bool.
 364         (ada_is_string_type): Likewise.
 365         * ada-lang.h (ada_is_character_type): Update declaration
 366         (ada_is_string_type): Likewise.
 367
 368 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 369
 370         Support style in 'frame|thread apply'
 371
 372         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 373         * record.c (record_start, record_stop): Update callers of
 374         execute_command_to_string with false.
 375         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 376         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 377         methods.
 378         (class string_file): New constructor with term_out parameter.
 379         Override methods term_out and can_emit_style_escape.  New member
 380         term_out.
 381         (class stdio_file): Override can_emit_style_escape.
 382         (class tee_file): Override term_out and can_emit_style_escape.
 383         * utils.h (can_emit_style_escape): Remove.
 384         * utils.c (can_emit_style_escape): Likewise.
 385         Update all callers of can_emit_style_escape (SOMESTREAM) to
 386         SOMESTREAM->can_emit_style_escape.
 387         * source-cache.c (source_cache::get_source_lines): Likewise.
 388         * stack.c (frame_apply_command_count): Call execute_command_to_string
 389         passing the term_out characteristic of the current gdb_stdout.
 390         * thread.c (thr_try_catch_cmd): Likewise.
 391         * top.c (execute_command_to_string): pass term_out parameter
 392         to construct the string_file for the command output.
 393         * ui-file.c (term_cli_styling): New function (most code moved
 394         from utils.c can_emit_style_escape).
 395         (string_file::string_file, string_file::can_emit_style_escape,
 396         stdio_file::can_emit_style_escape, tee_file::term_out,
 397         tee_file::can_emit_style_escape): New functions.
 398
 399 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 400
 401         * NEWS: Mention the new set|show may-call-functions.
 402         * infcall.c (may_call_functions_p): New variable.
 403         (show_may_call_functions_p): New function.
 404         (call_function_by_hand_dummy): Throws an error if not
 405         may-call-functions.
 406         (_initialize_infcall): Call add_setshow_boolean_cmd for
 407         may-call-functions.
 408
 409 2019-04-25  Keith Seitz  <keiths@redhat.com>
 410
 411         PR c++/24367
 412         * cp-support.c (inspect_type): Don't attempt substitutions
 413         of symbol with the same name.
 414
 415 2019-04-25  Tom Tromey  <tromey@adacore.com>
 416
 417         PR gdb/24475:
 418         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 419         static.
 420
 421 2019-04-25  Tom Tromey  <tromey@adacore.com>
 422
 423         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 424         rvalue reference.
 425         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 426         (gdb_xml_parser::parse): Use std::move.
 427         * python/python-internal.h (gdbpy_convert_exception): Take a const
 428         reference.
 429         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 430         std::move.
 431         * python/py-utils.c (gdbpy_convert_exception): Take a const
 432         reference.
 433         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 434         Use std::move.
 435         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 436         Use std::move.
 437         * mi/mi-main.c (mi_print_exception): Take a const reference.
 438         * main.c (handle_command_errors): Take a const reference.
 439         * linespec.c (parse_linespec): Use std::move.
 440         * infcall.c (run_inferior_call): Use std::move.
 441         (call_function_by_hand_dummy): Use std::move.
 442         * exec.c (try_open_exec_file): Use std::move.
 443         * exceptions.h (exception_print, exception_fprintf)
 444         (exception_print_same): Update.
 445         * exceptions.c (print_exception, exception_print)
 446         (exception_fprintf, exception_print_same): Change parameters to
 447         const reference.
 448         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 449         * common/new-op.c: Use std::move.
 450         * common/common-exceptions.h (struct gdb_exception): Add move
 451         constructor.
 452         (struct gdb_exception_error, struct gdb_exception_quit, struct
 453         gdb_quit_bad_alloc): Change constructor to move constructor.
 454         (throw_exception): Change parameter to rvalue reference.
 455         * common/common-exceptions.c (throw_exception): Take rvalue
 456         reference.
 457         * cli/cli-interp.c (safe_execute_command): Use std::move.
 458         * breakpoint.c (insert_bp_location, location_to_sals): Use
 459         std::move.
 460
 461 2019-04-25  Tom Tromey  <tromey@adacore.com>
 462
 463         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 464         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 465         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 466         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 467         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 468         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 469         guile/scm-value.c: Use unpack.
 470         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 471         gdbscm_gdb_exception.
 472         (gdbscm_throw_gdb_exception): Likewise.
 473         (struct gdbscm_gdb_exception): New.
 474         (unpack): New function.
 475         (gdbscm_wrap): Use unpack.
 476
 477 2019-04-25  Tom Tromey  <tromey@adacore.com>
 478
 479         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 480         (gdb_rl_callback_handler): Use std::move.
 481         * common/common-exceptions.h (struct gdb_exception): Add move
 482         assignment operator.
 483         (throw_exception_sjlj): Change "exception" to const reference.
 484         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 485         (throw_exception_sjlj): Change "exception" to const reference.
 486
 487 2019-04-25  Tom Tromey  <tromey@adacore.com>
 488
 489         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 490         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 491         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 492         Update.
 493         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 494         Update.
 495         * mi/mi-interp.c (mi_interp::exec): Update.
 496         * linespec.c (parse_linespec): Update.
 497         * infcall.c (run_inferior_call): Update.
 498         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 499         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 500         (gdbscm_lookup_global_symbol): Update.
 501         * guile/scm-param.c (gdbscm_parameter_value): Update.
 502         * guile/scm-frame.c (gdbscm_frame_read_register)
 503         (gdbscm_frame_read_var): Update.
 504         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 505         * exec.c (try_open_exec_file): Update.
 506         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 507         (gdb_rl_callback_handler): Update.
 508         * common/common-exceptions.h (exception_none): Don't declare.
 509         * common/common-exceptions.c (exception_none): Don't define.
 510         (struct catcher) <exception>: Update.
 511         * cli/cli-interp.c (safe_execute_command): Update.
 512         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 513
 514 2019-04-25  Ali Tamur  <tamur@google.com>
 515
 516         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 517         (read_attribute_value): Likewise.
 518         (dwarf2_read_addr_index): Update comment.
 519         (read_str_index): Add DW_FORM_strx.
 520         (dwarf2_string_attr): Likewise.
 521         (dwarf2_const_value_attr): Likewise.
 522         (dump_die_shallow): Likewise.
 523         (dwarf2_fetch_constant_bytes): Likewise.
 524         (skip_form_bytes): Likewise.
 525         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 526
 527 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 528
 529         PR corefiles/11608
 530         PR corefiles/18187
 531         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 532         OFFSET.  Verify if current mapping contains an ELF header.
 533         (linux_find_memory_regions_full): Adjust call to
 534         dump_mapping_p.
 535
 536 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 537             Kang Li <kanglictf@gmail.com>
 538
 539         PR gdb/21600
 540
 541         * dwarf2-frame.c (read_initial_length): Be consistent about using
 542         unsigned representation of length.
 543         (decode_frame_entry_1): Likewise.  Check for wraparound of
 544         end pointer as well as buffer overflow.
 545
 546 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 547
 548         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 549         "vq".
 550
 551 2019-04-24  Tom Tromey  <tromey@adacore.com>
 552
 553         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 554
 555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 556
 557         * s12z-tdep.c (s12z_unwind_pc): Delete.
 558         (s12z_unwind_sp): Delete.
 559         (s12z_gdbarch_init): Don't register deleted functions with
 560         gdbarch.
 561
 562 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 563
 564         * rl78-tdep.c (rl78_unwind_sp): Delete.
 565         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 566
 567 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 568
 569         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 570         (xstormy16_unwind_pc): Delete.
 571         (xstormy16_dummy_id): Delete.
 572         (xstormy16_gdbarch_init): Don't register deleted functions with
 573         gdbarch.
 574
 575 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 576
 577         * vax-tdep.c (vax_unwind_pc): Delete.
 578         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 579
 580 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 581
 582         * v850-tdep.c (v850_unwind_sp): Delete.
 583         (v850_unwind_pc): Delete.
 584         (v850_dummy_id): Delete.
 585         (v850_gdbarch_init): Don't register deleted functions with
 586         gdbarch.
 587
 588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 589
 590         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 591         (tilegx_unwind_pc): Delete.
 592         (tilegx_unwind_dummy_id): Delete.
 593         (tilegx_gdbarch_init): Don't register deleted functions with
 594         gdbarch.
 595
 596 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 597
 598         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 599         (tic6x_dummy_id): Delete.
 600         (tic6x_gdbarch_init): Don't register deleted functions with
 601         gdbarch.
 602
 603 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 604
 605         * sparc-tdep.c (sparc_unwind_pc): Delete.
 606         (sparc32_gdbarch_init): Don't register deleted function with
 607         gdbarch.
 608
 609 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 610
 611         * sh-tdep.c (sh_unwind_sp): Delete.
 612         (sh_unwind_pc): Delete.
 613         (sh_dummy_id): Delete.
 614         (sh_gdbarch_init): Don't register deleted functions with
 615         gdbarch.
 616
 617 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 618
 619         * score-tdep.c (score_unwind_sp): Delete.
 620         (score_unwind_pc): Delete.
 621         (score_dummy_id): Delete.
 622         (score_gdbarch_init): Don't register deleted functions with
 623         gdbarch.
 624
 625 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 626
 627         * rx-tdep.c (rx_unwind_pc): Delete.
 628         (rx_unwind_sp): Delete.
 629         (rx_dummy_id): Delete.
 630         (rx_gdbarch_init): Don't register deleted functions with
 631         gdbarch.  Update comment.
 632
 633 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 634
 635         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 636         (rs6000_dummy_id): Delete.
 637         (rs6000_gdbarch_init): Don't register deleted functions with
 638         gdbarch.
 639
 640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 641
 642         * or1k-tdep.c (or1k_dummy_id): Delete.
 643         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 644
 645 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 646
 647         * nios2-tdep.c (nios2_dummy_id): Delete.
 648         (nios2_unwind_sp): Delete.
 649         (nios2_gdbarch_init): Don't register deleted functions with
 650         gdbarch.
 651
 652 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 653
 654         * nds32-tdep.c (nds32_dummy_id): Delete.
 655         (nds32_unwind_pc): Delete.
 656         (nds32_unwind_sp): Delete.
 657         (nds32_gdbarch_init): Don't register deleted functions with
 658         gdbarch.
 659
 660 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 661
 662         * msp430-tdep.c (msp430_unwind_pc): Delete.
 663         (msp430_unwind_sp): Delete.
 664         (msp430_dummy_id): Delete.
 665         (msp430_gdbarch_init): Don't register deleted functions with
 666         gdbarch.
 667
 668 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 669
 670         * moxie-tdep.c (moxie_unwind_sp): Delete.
 671         (moxie_unwind_pc): Delete.
 672         (moxie_dummy_id): Delete.
 673         (moxie_gdbarch_init): Don't register deleted functions with
 674         gdbarch.
 675
 676 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 677
 678         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 679         (mn10300_unwind_pc): Delete.
 680         (mn10300_unwind_sp): Delete.
 681         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 682         mn10300_unwind_sp.
 683         (mn10300_frame_unwind_init): Don't register deleted functions with
 684         gdbarch.
 685
 686 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 687
 688         * mep-tdep.c (mep_unwind_pc): Delete.
 689         (mep_unwind_sp): Delete.
 690         (mep_dummy_id): Delete.
 691         (mep_gdbarch_init): Don't register deleted functions with
 692         gdbarch.
 693
 694 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 695
 696         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 697         (m68hc11_unwind_sp): Delete.
 698         (m68hc11_gdbarch_init): Don't register deleted functions with
 699         gdbarch.
 700
 701 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 702
 703         * m32r-tdep.c (m32r_unwind_sp): Delete.
 704         (m32r_unwind_pc): Delete.
 705         (m32r_dummy_id): Delete.
 706         (m32r_gdbarch_init): Don't register deleted functions with
 707         gdbarch.
 708
 709 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 710
 711         * m32c-tdep.c (m32c_unwind_pc): Delete.
 712         (m32c_unwind_sp): Delete.
 713         (m32c_dummy_id): Delete.
 714         (m32c_gdbarch_init): Don't register deleted functions with
 715         gdbarch.
 716
 717 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 718
 719         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 720         (lm32_unwind_pc): Delete.
 721         (lm32_dummy_id): Delete.
 722         (lm32_gdbarch_init): Don't register deleted functions with
 723         gdbarch.
 724
 725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 726
 727         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 728         (iq2000_unwind_pc): Delete.
 729         (iq2000_dummy_id): Delete.
 730         (iq2000_gdbarch_init): Don't register deleted functions with
 731         gdbarch.
 732
 733 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 734
 735         * nds32-tdep.c (nds32_type_align): Delete.
 736         (nds32_push_dummy_call): Use type_align instead.
 737
 738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 739
 740         * arm-tdep.c (arm_type_align): Only handle vector override case.
 741         (arm_push_dummy_call): Use type_align.
 742         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 743
 744 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 745
 746         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 747         case.
 748         (pass_on_stack): Use type_align.
 749         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 750         function.
 751
 752 2019-04-23  Tom Tromey  <tromey@adacore.com>
 753
 754         * dwarf2read.c (line_header::file_name_at): Remove unused
 755         overload.
 756
 757 2019-04-23  Tom de Vries  <tdevries@suse.de>
 758
 759         PR gdb/24438
 760         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 761         invocation.
 762
 763
 764 2019-03-27  Ali Tamur  <tamur@google.com>
 765
 766         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 767         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 768         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 769         (dwarf_expr_context::get_addr_index): Likewise
 770         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 771         (symbol_needs_eval_context::get_addr_index): Likewise
 772         (disassemble_dwarf_expression): Add DW_OP_addrx
 773         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 774         (read_cutu_die_from_dwo): Update comment
 775         (skip_one_die): Add DW_FORM_addrx
 776         (read_attribute_value): Likewise
 777         (var_decode_location): Add DW_OP_addrx
 778         (dwarf2_const_value_attr): Add DW_FORM_addrx
 779         (dump_die_shallow): Likewise
 780         (dwarf2_fetch_constant_bytes): Likewise
 781         (decode_locdesc): Add DW_OP_addrx
 782         (skip_form_bytes): Add DW_FORM_addrx
 783
 784 2019-04-22  Ali Tamur  <tamur@google.com>
 785
 786         * MAINTAINERS (Write After Approval): Add self.
 787
 788 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 789
 790         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 791         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 792         (open_symbol_file_object): Likewise.
 793         (svr4_default_sos): Add info parameter.
 794         (svr4_read_so_list): Likewise.
 795         (svr4_current_sos_direct): Adjust functions calls to pass down
 796         info.
 797         (svr4_current_sos_1): Add info parameter.
 798         (svr4_current_sos): Call get_svr4_info, pass info down to
 799         svr4_current_sos_1.
 800         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 801         get_svr4_info.
 802         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 803         get_svr4_info.
 804         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 805         to get_svr4_info.
 806         (probes_table_remove_objfile_probes): Likewise.
 807         (register_solib_event_probe): Add info parameter.
 808         (solist_update_incremental): Pass info parameter down to
 809         svr4_read_so_list.
 810         (disable_probes_interface): Add info parameter.
 811         (svr4_handle_solib_event): Pass current_program_space to
 812         get_svr4_info.  Adjust disable_probes_interface cleanup.
 813         (svr4_create_probe_breakpoints): Add info parameter, pass it
 814         down to register_solib_event_probe.
 815         (svr4_create_solib_event_breakpoints): Add info parameter,
 816         pass it down to svr4_create_probe_breakpoints.
 817         (enable_break): Pass info down to
 818         svr4_create_solib_event_breakpoints.
 819         (svr4_solib_create_inferior_hook): Pass current_program_space to
 820         get_svr4_info.
 821         (svr4_clear_solib): Likewise.
 822
 823 2019-04-22  Pedro Alves  <palves@redhat.com>
 824
 825         * solib-svr4.c (svr4_free_objfile_observer): New.
 826         (probe_and_action::objfile): New field.
 827         (probes_table_htab_remove_objfile_probes)
 828         (probes_table_remove_objfile_probes): New functions.
 829         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 830         in the new probe_and_action.  Don't store the probe in 'lookup'.
 831         (svr4_create_probe_breakpoints): Pass objfile to
 832         register_solib_event_probe.
 833         (_initialize_svr4_solib): Register a free_objfile observer.
 834
 835 2019-04-19  Tom Tromey  <tom@tromey.com>
 836
 837         * common/queue.h: Remove.
 838
 839 2019-04-19  Tom Tromey  <tom@tromey.com>
 840
 841         * event-loop.c: Don't include "common/queue.h".
 842
 843 2019-04-19  Tom Tromey  <tom@tromey.com>
 844
 845         * remote.c (remote_target): Use delete.
 846         * remote-notif.h: Include <list>, not "common/queue.h".
 847         (notif_client_p): Remove typedef.
 848         (remote_notif_state): Add constructor, destructor, initializer.
 849         <notif_queue>: Now a std::list.
 850         (remote_notif_state_xfree): Don't declare.
 851         * remote-notif.c (remote_notif_process, handle_notification)
 852         (remote_notif_state_allocate): Update.
 853         (~remote_notif_state): Rename from remote_notif_state_xfree.
 854
 855 2019-04-19  Tom Tromey  <tom@tromey.com>
 856
 857         * symfile.c (reread_symbols): Update.
 858         * objfiles.c (objfile_register_static_link)
 859         (objfile_lookup_static_link): Update
 860         (~objfile) Don't delete static_links.
 861         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 862
 863 2019-04-19  Tom Tromey  <tom@tromey.com>
 864
 865         * type-stack.h (struct type_stack) <insert>: Constify string.
 866         * type-stack.c (type_stack::insert): Constify string.
 867         * gdbtypes.h (lookup_template_type): Update.
 868         (address_space_name_to_int): Update.
 869         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 870         const.
 871         (lookup_template_type): Make name const.
 872         * c-exp.y: Update rules.
 873         (lex_one_token, classify_name, classify_inner_name)
 874         (c_print_token): Update.
 875         * p-exp.y: Update rules.
 876         (yylex): Update.
 877         * f-exp.y: Update rules.
 878         (yylex): Update.
 879         * d-exp.y: Update rules.
 880         (lex_one_token, classify_name, classify_inner_name): Update.
 881         * parse.c (write_dollar_variable, copy_name): Return std::string.
 882         * parser-defs.h (copy_name): Change return type.
 883         * m2-exp.y: Update rules.
 884         (yylex): Update.
 885         * go-exp.y (lex_one_token): Update.
 886         Update rules.
 887         (classify_unsafe_function, classify_packaged_name)
 888         (classify_name, yylex): Update.
 889
 890 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 891
 892         * configure.ac: add --enable-source-highlight switch.
 893         * configure: Regenerate.
 894         * top.c (print_gdb_version): plumb --enable-source-highlight
 895         status to "show configuration".
 896
 897 2019-04-19  Tom Tromey  <tromey@adacore.com>
 898
 899         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 900         Check ADA_TYPE_P.
 901         (empty_record, ada_template_to_fixed_record_type_1)
 902         (template_to_static_fixed_type)
 903         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 904         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 905         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 906         macros.
 907
 908 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 909
 910         PR symtab/24423:
 911         * source.c (print_source_lines_base): Advance "iter" when a
 912         control character is seen.
 913
 914 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 915
 916         * inferior.h (struct infcall_suspend_state_deleter):
 917         Catch exception in destructor to avoid crash.
 918
 919 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 920
 921         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 922         close to the add_com "shell".
 923
 924 2019-04-18  Tom Tromey  <tromey@adacore.com>
 925
 926         * process-stratum-target.h (class process_stratum_target)
 927         <stratum>: Add "final".
 928
 929 2019-04-17  Tom Tromey  <tromey@adacore.com>
 930
 931         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 932         against nullptr before use.
 933
 934 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 935
 936         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 937
 938 2019-04-17  Jim Wilson  <jimw@sifive.com>
 939             Andrew Burgess  <andrew.burgess@embecosm.com>
 940
 941         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 942         code read might fail, assume 4-byte breakpoint in that case.
 943
 944 2019-04-15  Leszek Swirski  <leszeks@google.com>
 945
 946         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 947         rather than a hand-rolled POD check when checking for forced MEMORY
 948         classification.
 949
 950 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 951
 952         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 953         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 954         function.
 955         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 956         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 957         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 958         declaration.
 959
 960 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 961
 962         * aarch64-linux-nat.c
 963         (aarch64_linux_nat_target::thread_architecture): Add override.
 964         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 965         each VQ.
 966
 967 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 968
 969         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 970
 971 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 972
 973         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 974         target types of size 96-bits, add some additional comments, and
 975         check that the builtin type we found was the correct size.
 976
 977 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 978
 979         * utils.c (prompt_for_continue): Don't restore the styling at the
 980         end, as applied_style has the wrong value.  This fixes styling in
 981         long lists of file names that are interrupted by the "Continue?"
 982         prompt.
 983
 984 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 985
 986         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 987         * c-lang.c (c_language_defn): Likewise.
 988         (cplus_language_defn): Likewise.
 989         (asm_language_defn): Likewise.
 990         (minimal_language_defn): Likewise.
 991         * d-lang.c (d_language_defn): Likewise.
 992         * f-lang.c (f_language_defn): Likewise.
 993         * go-lang.c (go_language_defn): Likewise.
 994         * language.c (unknown_language_defn): Likewise.
 995         (auto_language_defn): Likewise.
 996         * language.h (struct language_defn): Remove la_magic field.
 997         (LANG_MAGIC): Delete.
 998         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 999         * objc-lang.c (objc_language_defn): Likewise.
1000         * opencl-lang.c (opencl_language_defn): Likewise.
1001         * p-lang.c (pascal_language_defn): Likewise.
1002         * rust-lang.c (rust_language_defn): Likewise.
1003
1004 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1005
1006         * riscv-tdep.c (riscv_type_align): New function.
1007         (riscv_type_alignment): Delete.
1008         (riscv_arg_location): Use 'type_align'.
1009         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1010
1011 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1012
1013         * gdbtypes.c (type_align): A struct with no non-static fields also
1014         has alignment of 1.
1015
1016 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1017
1018         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1019         component to 0.
1020         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1021         member.
1022         (riscv_struct_info::analyse): New implementation using new
1023         analyse_inner member function.
1024         (riscv_struct_info::field_offset): New member function.
1025         (riscv_struct_info::m_offsets): New member variable.
1026         (riscv_struct_info::analyse_inner): New private member function,
1027         takes the old implementation of riscv_struct_info::analyse but
1028         extended to track field offsets.
1029         (riscv_call_arg_struct): Update the struct folding special cases
1030         to handle cases where empty C++ structs, which are non-zero
1031         length, are found.
1032         (riscv_arg_location): Initialise the length of each location, a
1033         non-zero length now indicates the location is in use.
1034         (riscv_push_dummy_call): Allow for the first location having a
1035         non-zero offset when setting up arguments.
1036         (riscv_return_value): Likewise, but for return values.
1037
1038 2019-04-11  Tom Tromey  <tromey@adacore.com>
1039
1040         * utils.c (internal_vproblem): Make "msg" const.
1041
1042 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1043
1044         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1045         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1046         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1047         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1048
1049 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1050
1051         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1052         function.
1053         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1054         of amd64_collect_native_gregset.
1055         (amd64_linux_nat_target::store_registers): Likewise.
1056
1057 2019-04-10  Tom Tromey  <tom@tromey.com>
1058
1059         * symtab.c (lookup_global_symbol_from_objfile)
1060         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1061         * objfiles.h (class separate_debug_iterator): New.
1062         (class separate_debug_range): New.
1063         (struct objfile) <separate_debug_objfiles>: New method.
1064         (objfile_separate_debug_iterate): Don't declare.
1065         * objfiles.c (separate_debug_iterator::operator++): Rename from
1066         objfile_separate_debug_iterate.
1067         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1068         iterator.
1069         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1070         iterator.
1071
1072 2019-04-10  Tom Tromey  <tom@tromey.com>
1073
1074         * symfile.c (reread_symbols): Remove old comment.
1075         * objfiles.c (free_all_objfiles): Fix a typo.
1076
1077 2019-04-10  Tom Tromey  <tom@tromey.com>
1078
1079         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1080         * minsyms.c (lookup_minimal_symbol): Use foreach.
1081         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1082         (lookup_minimal_symbol_solib_trampoline): Likewise.
1083         * symfile.c (reread_symbols): Use foreach.
1084
1085 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1086             Tom Tromey  <tromey@adacore.com>
1087
1088         PR rust/24414:
1089         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1090         (rust_lex_int_test): Change "value" to be LONGEST.
1091         (rust_lex_tests): Add test for long integer literal.
1092
1093 2019-04-09  Tom Tromey  <tromey@adacore.com>
1094
1095         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1096         to bool.
1097         (extended_remote_target::attach): Update.
1098         (remote_target::remote_notice_new_inferior): Update.
1099         (remote_target::add_current_inferior_and_thread): Update.
1100         * inferior.c (exit_inferior_1): Use "false".
1101         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1102
1103 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1104
1105         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1106         the "start" command.
1107
1108 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1109
1110         * python/py-inferior.c (infpy_thread_from_thread_handle):
1111         Adjust comments to reflect renaming of thread_from_thread_handle
1112         to thread_from_handle.  Adjust keywords.  Fix type error message.
1113         (inferior_object_methods): Add thread_from_handle.  Retain
1114         thread_from_thread_handle, but mark it as deprecated.
1115
1116 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1117
1118         * gdbthread.h (find_thread_by_handle): Revise declaration.
1119         * thread.c (find_thread_by_handle): Likewise.  Adjust
1120         implementation too.
1121         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1122         support for buffer objects as handles.
1123
1124 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1125
1126         * python/py-infthread.c (thpy_thread_handle): New function.
1127         (thread_object_methods): Register thpy_thread_handle.
1128
1129 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1130
1131         * gdbthread.h (thread_to_thread_handle): Declare.
1132         * thread.c (gdbtypes.h): Include.
1133         (thread_to_thread_handle): New function.
1134
1135         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1136         (target_thread_info_to_thread_handle): Declare.
1137         * target.c (target_thread_info_to_thread_handle): New function.
1138         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1139         * target-delegates.c: Regenerate.
1140
1141         * linux-thread-db.c (class thread_db_target): Add method
1142         thread_info_to_thread_handle.
1143         (thread_db_target::thread_info_to_thread_handle): Define.
1144         * remote.c (class remote_target): Add new method
1145         thread_info_to_thread_handle.
1146         (remote_target::thread_info_to_thread_handle): Define.
1147
1148 2019-04-08  Pedro Alves  <palves@redhat.com>
1149
1150         * common/common-exceptions.c (throw_exception): Don't create
1151         named object to throw; throw directly.
1152         (throw_it): Likewise.  Don't initialize gdb_exception::message
1153         here, with new; pass FMT and AP to the ctor instead.
1154         * common/common-exceptions.h: Include <string>.
1155         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1156         const char *, va_list)): New ctor.  Use std::make_shared.
1157         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1158         errors)): Delete.
1159         (gdb_exception_error::gdb_exception_error(enum errors, const char
1160         *, va_list)): New.
1161         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1162         Add assertion.
1163         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1164         errors)): Delete.
1165         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1166         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1167         Add assertion.
1168
1169 2019-04-08  Tom Tromey  <tom@tromey.com>
1170
1171         * valops.c (value_rtti_indirect_type): Replace throw_exception
1172         with throw.
1173         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1174         with throw.
1175         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1176         throw.
1177         * target.c (target_translate_tls_address): Replace throw_exception
1178         with throw.
1179         * stack.c (frame_apply_command_count): Replace throw_exception
1180         with throw.
1181         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1182         throw.
1183         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1184         with throw.
1185         * rs6000-tdep.c (rs6000_frame_cache)
1186         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1187         * remote.c: Replace throw_exception with throw.
1188         * record-full.c (record_full_message, record_full_wait_1)
1189         (record_full_restore): Replace throw_exception with throw.
1190         * record-btrace.c:
1191         (get_thread_current_frame_id, record_btrace_start_replaying)
1192         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1193         (cmd_record_btrace_start): Replace throw_exception with throw.
1194         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1195         throw.
1196         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1197         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1198         * linespec.c:
1199         (find_linespec_symbols): Replace throw_exception with throw.
1200         * infrun.c (displaced_step_prepare, resume): Replace
1201         throw_exception with throw.
1202         * infcmd.c (post_create_inferior): Replace throw_exception with
1203         throw.
1204         * inf-loop.c (inferior_event_handler): Replace throw_exception
1205         with throw.
1206         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1207         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1208         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1209         (get_prev_frame_always, get_frame_pc_if_available)
1210         (get_frame_address_in_block_if_available, get_frame_language):
1211         Replace throw_exception with throw.
1212         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1213         throw_exception with throw.
1214         * eval.c (fetch_subexp_value, evaluate_var_value)
1215         (evaluate_funcall, evaluate_subexp_standard): Replace
1216         throw_exception with throw.
1217         * dwarf2loc.c (call_site_find_chain)
1218         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1219         Replace throw_exception with throw.
1220         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1221         with throw.
1222         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1223         throw.
1224         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1225         * completer.c (complete_line_internal): Replace throw_exception
1226         with throw.
1227         * compile/compile-object-run.c (compile_object_run): Replace
1228         throw_exception with throw.
1229         * cli/cli-script.c (process_next_line): Replace throw_exception
1230         with throw.
1231         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1232         (btrace_enable, btrace_maint_update_pt_packets): Replace
1233         throw_exception with throw.
1234         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1235         throw_exception with throw.
1236         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1237         throw_exception with throw.
1238         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1239         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1240         * aarch64-tdep.c (aarch64_make_prologue_cache)
1241         (aarch64_make_stub_cache): Replace throw_exception with throw.
1242
1243 2019-04-08  Tom Tromey  <tom@tromey.com>
1244
1245         * common/common-exceptions.c (throw_exception): Rename from
1246         throw_exception_cxx.  Remove old copy.  Make argument const.
1247         (throw_it): Create and throw exception objects directly.
1248         * common/common-exceptions.h (throw_exception): Make argument
1249         const.
1250         (struct gdb_exception_error): Add constructor.
1251         (struct gdb_exception_quit): Add constructor.
1252
1253 2019-04-08  Tom Tromey  <tom@tromey.com>
1254
1255         * common/common-exceptions.h (exception_rethrow): Don't declare.
1256         (TRY_SJLJ): Update comment.
1257         (TRY, CATCH, END_CATCH): Remove.
1258         * common/common-exceptions.c (exception_rethrow): Remove.
1259
1260 2019-04-08  Tom Tromey  <tom@tromey.com>
1261
1262         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1263         Remove.
1264         (gdb_exception_error): Rename from
1265         gdb_exception_RETURN_MASK_ERROR.
1266         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1267         (gdb_quit_bad_alloc): Update.
1268         * aarch64-tdep.c: Update.
1269         * ada-lang.c: Update.
1270         * ada-typeprint.c: Update.
1271         * ada-valprint.c: Update.
1272         * amd64-tdep.c: Update.
1273         * arch-utils.c: Update.
1274         * break-catch-throw.c: Update.
1275         * breakpoint.c: Update.
1276         * btrace.c: Update.
1277         * c-varobj.c: Update.
1278         * cli/cli-cmds.c: Update.
1279         * cli/cli-interp.c: Update.
1280         * cli/cli-script.c: Update.
1281         * common/common-exceptions.c: Update.
1282         * common/new-op.c: Update.
1283         * common/selftest.c: Update.
1284         * compile/compile-c-symbols.c: Update.
1285         * compile/compile-cplus-symbols.c: Update.
1286         * compile/compile-object-load.c: Update.
1287         * compile/compile-object-run.c: Update.
1288         * completer.c: Update.
1289         * corelow.c: Update.
1290         * cp-abi.c: Update.
1291         * cp-support.c: Update.
1292         * cp-valprint.c: Update.
1293         * darwin-nat.c: Update.
1294         * disasm-selftests.c: Update.
1295         * dtrace-probe.c: Update.
1296         * dwarf-index-cache.c: Update.
1297         * dwarf-index-write.c: Update.
1298         * dwarf2-frame-tailcall.c: Update.
1299         * dwarf2-frame.c: Update.
1300         * dwarf2loc.c: Update.
1301         * dwarf2read.c: Update.
1302         * eval.c: Update.
1303         * event-loop.c: Update.
1304         * event-top.c: Update.
1305         * exec.c: Update.
1306         * f-valprint.c: Update.
1307         * fbsd-tdep.c: Update.
1308         * frame-unwind.c: Update.
1309         * frame.c: Update.
1310         * gdbtypes.c: Update.
1311         * gnu-v3-abi.c: Update.
1312         * guile/guile-internal.h: Update.
1313         * guile/scm-block.c: Update.
1314         * guile/scm-breakpoint.c: Update.
1315         * guile/scm-cmd.c: Update.
1316         * guile/scm-disasm.c: Update.
1317         * guile/scm-frame.c: Update.
1318         * guile/scm-lazy-string.c: Update.
1319         * guile/scm-math.c: Update.
1320         * guile/scm-param.c: Update.
1321         * guile/scm-ports.c: Update.
1322         * guile/scm-pretty-print.c: Update.
1323         * guile/scm-symbol.c: Update.
1324         * guile/scm-symtab.c: Update.
1325         * guile/scm-type.c: Update.
1326         * guile/scm-value.c: Update.
1327         * i386-linux-tdep.c: Update.
1328         * i386-tdep.c: Update.
1329         * inf-loop.c: Update.
1330         * infcall.c: Update.
1331         * infcmd.c: Update.
1332         * infrun.c: Update.
1333         * jit.c: Update.
1334         * language.c: Update.
1335         * linespec.c: Update.
1336         * linux-fork.c: Update.
1337         * linux-nat.c: Update.
1338         * linux-tdep.c: Update.
1339         * linux-thread-db.c: Update.
1340         * main.c: Update.
1341         * mi/mi-cmd-break.c: Update.
1342         * mi/mi-cmd-stack.c: Update.
1343         * mi/mi-interp.c: Update.
1344         * mi/mi-main.c: Update.
1345         * objc-lang.c: Update.
1346         * p-valprint.c: Update.
1347         * parse.c: Update.
1348         * ppc-linux-tdep.c: Update.
1349         * printcmd.c: Update.
1350         * python/py-arch.c: Update.
1351         * python/py-breakpoint.c: Update.
1352         * python/py-cmd.c: Update.
1353         * python/py-finishbreakpoint.c: Update.
1354         * python/py-frame.c: Update.
1355         * python/py-framefilter.c: Update.
1356         * python/py-gdb-readline.c: Update.
1357         * python/py-inferior.c: Update.
1358         * python/py-infthread.c: Update.
1359         * python/py-lazy-string.c: Update.
1360         * python/py-linetable.c: Update.
1361         * python/py-objfile.c: Update.
1362         * python/py-param.c: Update.
1363         * python/py-prettyprint.c: Update.
1364         * python/py-progspace.c: Update.
1365         * python/py-record-btrace.c: Update.
1366         * python/py-record.c: Update.
1367         * python/py-symbol.c: Update.
1368         * python/py-type.c: Update.
1369         * python/py-unwind.c: Update.
1370         * python/py-utils.c: Update.
1371         * python/py-value.c: Update.
1372         * python/python.c: Update.
1373         * record-btrace.c: Update.
1374         * record-full.c: Update.
1375         * remote-fileio.c: Update.
1376         * remote.c: Update.
1377         * riscv-tdep.c: Update.
1378         * rs6000-aix-tdep.c: Update.
1379         * rs6000-tdep.c: Update.
1380         * rust-exp.y: Update.
1381         * rust-lang.c: Update.
1382         * s390-tdep.c: Update.
1383         * selftest-arch.c: Update.
1384         * solib-dsbt.c: Update.
1385         * solib-frv.c: Update.
1386         * solib-spu.c: Update.
1387         * solib-svr4.c: Update.
1388         * solib.c: Update.
1389         * sparc64-linux-tdep.c: Update.
1390         * stack.c: Update.
1391         * symfile-mem.c: Update.
1392         * symmisc.c: Update.
1393         * target.c: Update.
1394         * thread.c: Update.
1395         * top.c: Update.
1396         * tracefile-tfile.c: Update.
1397         * tui/tui.c: Update.
1398         * typeprint.c: Update.
1399         * unittests/cli-utils-selftests.c: Update.
1400         * unittests/parse-connection-spec-selftests.c: Update.
1401         * valops.c: Update.
1402         * valprint.c: Update.
1403         * value.c: Update.
1404         * varobj.c: Update.
1405         * windows-nat.c: Update.
1406         * x86-linux-nat.c: Update.
1407         * xml-support.c: Update.
1408
1409 2019-04-08  Tom Tromey  <tom@tromey.com>
1410
1411         * xml-support.c: Use C++ exception handling.
1412         * x86-linux-nat.c: Use C++ exception handling.
1413         * windows-nat.c: Use C++ exception handling.
1414         * varobj.c: Use C++ exception handling.
1415         * value.c: Use C++ exception handling.
1416         * valprint.c: Use C++ exception handling.
1417         * valops.c: Use C++ exception handling.
1418         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1419         handling.
1420         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1421         * typeprint.c: Use C++ exception handling.
1422         * tui/tui.c: Use C++ exception handling.
1423         * tracefile-tfile.c: Use C++ exception handling.
1424         * top.c: Use C++ exception handling.
1425         * thread.c: Use C++ exception handling.
1426         * target.c: Use C++ exception handling.
1427         * symmisc.c: Use C++ exception handling.
1428         * symfile-mem.c: Use C++ exception handling.
1429         * stack.c: Use C++ exception handling.
1430         * sparc64-linux-tdep.c: Use C++ exception handling.
1431         * solib.c: Use C++ exception handling.
1432         * solib-svr4.c: Use C++ exception handling.
1433         * solib-spu.c: Use C++ exception handling.
1434         * solib-frv.c: Use C++ exception handling.
1435         * solib-dsbt.c: Use C++ exception handling.
1436         * selftest-arch.c: Use C++ exception handling.
1437         * s390-tdep.c: Use C++ exception handling.
1438         * rust-lang.c: Use C++ exception handling.
1439         * rust-exp.y: Use C++ exception handling.
1440         * rs6000-tdep.c: Use C++ exception handling.
1441         * rs6000-aix-tdep.c: Use C++ exception handling.
1442         * riscv-tdep.c: Use C++ exception handling.
1443         * remote.c: Use C++ exception handling.
1444         * remote-fileio.c: Use C++ exception handling.
1445         * record-full.c: Use C++ exception handling.
1446         * record-btrace.c: Use C++ exception handling.
1447         * python/python.c: Use C++ exception handling.
1448         * python/py-value.c: Use C++ exception handling.
1449         * python/py-utils.c: Use C++ exception handling.
1450         * python/py-unwind.c: Use C++ exception handling.
1451         * python/py-type.c: Use C++ exception handling.
1452         * python/py-symbol.c: Use C++ exception handling.
1453         * python/py-record.c: Use C++ exception handling.
1454         * python/py-record-btrace.c: Use C++ exception handling.
1455         * python/py-progspace.c: Use C++ exception handling.
1456         * python/py-prettyprint.c: Use C++ exception handling.
1457         * python/py-param.c: Use C++ exception handling.
1458         * python/py-objfile.c: Use C++ exception handling.
1459         * python/py-linetable.c: Use C++ exception handling.
1460         * python/py-lazy-string.c: Use C++ exception handling.
1461         * python/py-infthread.c: Use C++ exception handling.
1462         * python/py-inferior.c: Use C++ exception handling.
1463         * python/py-gdb-readline.c: Use C++ exception handling.
1464         * python/py-framefilter.c: Use C++ exception handling.
1465         * python/py-frame.c: Use C++ exception handling.
1466         * python/py-finishbreakpoint.c: Use C++ exception handling.
1467         * python/py-cmd.c: Use C++ exception handling.
1468         * python/py-breakpoint.c: Use C++ exception handling.
1469         * python/py-arch.c: Use C++ exception handling.
1470         * printcmd.c: Use C++ exception handling.
1471         * ppc-linux-tdep.c: Use C++ exception handling.
1472         * parse.c: Use C++ exception handling.
1473         * p-valprint.c: Use C++ exception handling.
1474         * objc-lang.c: Use C++ exception handling.
1475         * mi/mi-main.c: Use C++ exception handling.
1476         * mi/mi-interp.c: Use C++ exception handling.
1477         * mi/mi-cmd-stack.c: Use C++ exception handling.
1478         * mi/mi-cmd-break.c: Use C++ exception handling.
1479         * main.c: Use C++ exception handling.
1480         * linux-thread-db.c: Use C++ exception handling.
1481         * linux-tdep.c: Use C++ exception handling.
1482         * linux-nat.c: Use C++ exception handling.
1483         * linux-fork.c: Use C++ exception handling.
1484         * linespec.c: Use C++ exception handling.
1485         * language.c: Use C++ exception handling.
1486         * jit.c: Use C++ exception handling.
1487         * infrun.c: Use C++ exception handling.
1488         * infcmd.c: Use C++ exception handling.
1489         * infcall.c: Use C++ exception handling.
1490         * inf-loop.c: Use C++ exception handling.
1491         * i386-tdep.c: Use C++ exception handling.
1492         * i386-linux-tdep.c: Use C++ exception handling.
1493         * guile/scm-value.c: Use C++ exception handling.
1494         * guile/scm-type.c: Use C++ exception handling.
1495         * guile/scm-symtab.c: Use C++ exception handling.
1496         * guile/scm-symbol.c: Use C++ exception handling.
1497         * guile/scm-pretty-print.c: Use C++ exception handling.
1498         * guile/scm-ports.c: Use C++ exception handling.
1499         * guile/scm-param.c: Use C++ exception handling.
1500         * guile/scm-math.c: Use C++ exception handling.
1501         * guile/scm-lazy-string.c: Use C++ exception handling.
1502         * guile/scm-frame.c: Use C++ exception handling.
1503         * guile/scm-disasm.c: Use C++ exception handling.
1504         * guile/scm-cmd.c: Use C++ exception handling.
1505         * guile/scm-breakpoint.c: Use C++ exception handling.
1506         * guile/scm-block.c: Use C++ exception handling.
1507         * guile/guile-internal.h: Use C++ exception handling.
1508         * gnu-v3-abi.c: Use C++ exception handling.
1509         * gdbtypes.c: Use C++ exception handling.
1510         * frame.c: Use C++ exception handling.
1511         * frame-unwind.c: Use C++ exception handling.
1512         * fbsd-tdep.c: Use C++ exception handling.
1513         * f-valprint.c: Use C++ exception handling.
1514         * exec.c: Use C++ exception handling.
1515         * event-top.c: Use C++ exception handling.
1516         * event-loop.c: Use C++ exception handling.
1517         * eval.c: Use C++ exception handling.
1518         * dwarf2read.c: Use C++ exception handling.
1519         * dwarf2loc.c: Use C++ exception handling.
1520         * dwarf2-frame.c: Use C++ exception handling.
1521         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1522         * dwarf-index-write.c: Use C++ exception handling.
1523         * dwarf-index-cache.c: Use C++ exception handling.
1524         * dtrace-probe.c: Use C++ exception handling.
1525         * disasm-selftests.c: Use C++ exception handling.
1526         * darwin-nat.c: Use C++ exception handling.
1527         * cp-valprint.c: Use C++ exception handling.
1528         * cp-support.c: Use C++ exception handling.
1529         * cp-abi.c: Use C++ exception handling.
1530         * corelow.c: Use C++ exception handling.
1531         * completer.c: Use C++ exception handling.
1532         * compile/compile-object-run.c: Use C++ exception handling.
1533         * compile/compile-object-load.c: Use C++ exception handling.
1534         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1535         * compile/compile-c-symbols.c: Use C++ exception handling.
1536         * common/selftest.c: Use C++ exception handling.
1537         * common/new-op.c: Use C++ exception handling.
1538         * cli/cli-script.c: Use C++ exception handling.
1539         * cli/cli-interp.c: Use C++ exception handling.
1540         * cli/cli-cmds.c: Use C++ exception handling.
1541         * c-varobj.c: Use C++ exception handling.
1542         * btrace.c: Use C++ exception handling.
1543         * breakpoint.c: Use C++ exception handling.
1544         * break-catch-throw.c: Use C++ exception handling.
1545         * arch-utils.c: Use C++ exception handling.
1546         * amd64-tdep.c: Use C++ exception handling.
1547         * ada-valprint.c: Use C++ exception handling.
1548         * ada-typeprint.c: Use C++ exception handling.
1549         * ada-lang.c: Use C++ exception handling.
1550         * aarch64-tdep.c: Use C++ exception handling.
1551
1552 2019-04-08  Tom Tromey  <tom@tromey.com>
1553
1554         * xml-support.c (gdb_xml_parser::parse): Update.
1555         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1556         * value.c (show_convenience): Update.
1557         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1558         (test_parse_flags_qcs): Update.
1559         * thread.c (thr_try_catch_cmd): Update.
1560         * target.c (target_translate_tls_address): Update.
1561         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1562         (info_frame_command_core, frame_apply_command_count): Update.
1563         * rust-exp.y (rust_lex_exception_test): Update.
1564         * riscv-tdep.c (riscv_print_one_register_info): Update.
1565         * remote.c (remote_target::enable_btrace): Update.
1566         * record-btrace.c (record_btrace_enable_warn): Update.
1567         * python/py-utils.c (gdbpy_convert_exception): Update.
1568         * printcmd.c (do_one_display, print_variable_and_value): Update.
1569         * mi/mi-main.c (mi_print_exception): Update.
1570         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1571         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1572         * linux-nat.c (linux_nat_target::attach): Update.
1573         * linux-fork.c (class scoped_switch_fork_info): Update.
1574         * infrun.c (displaced_step_prepare): Update.
1575         * infcall.c (call_function_by_hand_dummy): Update.
1576         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1577         * gnu-v3-abi.c (print_one_vtable): Update.
1578         * frame.c (get_prev_frame_always): Update.
1579         * f-valprint.c (info_common_command_for_block): Update.
1580         * exec.c (try_open_exec_file): Update.
1581         * exceptions.c (print_exception, exception_print)
1582         (exception_fprintf, exception_print_same): Update.
1583         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1584         * dwarf-index-cache.c (index_cache::store)
1585         (index_cache::lookup_gdb_index): Update.
1586         * darwin-nat.c (maybe_cache_shell): Update.
1587         * cp-valprint.c (cp_print_value_fields): Update.
1588         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1589         (gcc_cplus_symbol_address): Update.
1590         * compile/compile-c-symbols.c (gcc_convert_symbol)
1591         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1592         * common/selftest.c: Update.
1593         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1594         a std::string.
1595         (exception_try_scope_entry, exception_try_scope_exit): Don't
1596         declare.
1597         (struct exception_try_scope): Remove.
1598         (TRY): Don't use exception_try_scope.
1599         (struct gdb_exception): Add constructor, operator=.
1600         <what>: New method.
1601         (struct gdb_exception_RETURN_MASK_ALL)
1602         (struct gdb_exception_RETURN_MASK_ERROR)
1603         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1604         (struct gdb_quit_bad_alloc): Update.
1605         * common/common-exceptions.c (exception_none): Change
1606         initializer.
1607         (struct catcher) <state, exception>: Initialize inline.
1608         <prev>: Remove member.
1609         (current_catcher): Remove.
1610         (catchers): New global.
1611         (exceptions_state_mc_init): Simplify.
1612         (catcher_pop): Remove.
1613         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1614         (try_scope_depth, exception_try_scope_entry)
1615         (exception_try_scope_exit): Remove.
1616         (throw_exception_sjlj): Update.
1617         (exception_messages, exception_messages_size): Remove.
1618         (throw_it): Simplify.
1619         (gdb_exception_sliced_copy): Remove.
1620         (throw_exception_cxx): Update.
1621         * cli/cli-script.c (script_from_file): Update.
1622         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1623         Update.
1624         * ada-valprint.c (ada_val_print): Update.
1625         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1626         (create_excep_cond_exprs): Update.
1627
1628 2019-04-08  Tom Tromey  <tom@tromey.com>
1629
1630         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1631         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1632         (TRY, CATCH, END_CATCH): Remove some definitions.
1633         * common/common-exceptions.c: Don't use GDB_XCPT.
1634         (catcher_list_size): Remove.
1635         (throw_exception, throw_it): Simplify.
1636
1637 2019-04-05  Tom Tromey  <tom@tromey.com>
1638
1639         Revert the header-sorting patch.
1640         * ft32-tdep.c: Revert.
1641         * frv-tdep.c: Revert.
1642         * frv-linux-tdep.c: Revert.
1643         * frame.c: Revert.
1644         * frame-unwind.c: Revert.
1645         * frame-base.c: Revert.
1646         * fork-child.c: Revert.
1647         * findvar.c: Revert.
1648         * findcmd.c: Revert.
1649         * filesystem.c: Revert.
1650         * filename-seen-cache.h: Revert.
1651         * filename-seen-cache.c: Revert.
1652         * fbsd-tdep.c: Revert.
1653         * fbsd-nat.h: Revert.
1654         * fbsd-nat.c: Revert.
1655         * f-valprint.c: Revert.
1656         * f-typeprint.c: Revert.
1657         * f-lang.c: Revert.
1658         * extension.h: Revert.
1659         * extension.c: Revert.
1660         * extension-priv.h: Revert.
1661         * expprint.c: Revert.
1662         * exec.h: Revert.
1663         * exec.c: Revert.
1664         * exceptions.c: Revert.
1665         * event-top.c: Revert.
1666         * event-loop.c: Revert.
1667         * eval.c: Revert.
1668         * elfread.c: Revert.
1669         * dwarf2read.h: Revert.
1670         * dwarf2read.c: Revert.
1671         * dwarf2loc.c: Revert.
1672         * dwarf2expr.h: Revert.
1673         * dwarf2expr.c: Revert.
1674         * dwarf2-frame.c: Revert.
1675         * dwarf2-frame-tailcall.c: Revert.
1676         * dwarf-index-write.h: Revert.
1677         * dwarf-index-write.c: Revert.
1678         * dwarf-index-common.c: Revert.
1679         * dwarf-index-cache.h: Revert.
1680         * dwarf-index-cache.c: Revert.
1681         * dummy-frame.c: Revert.
1682         * dtrace-probe.c: Revert.
1683         * disasm.h: Revert.
1684         * disasm.c: Revert.
1685         * disasm-selftests.c: Revert.
1686         * dictionary.c: Revert.
1687         * dicos-tdep.c: Revert.
1688         * demangle.c: Revert.
1689         * dcache.h: Revert.
1690         * dcache.c: Revert.
1691         * darwin-nat.h: Revert.
1692         * darwin-nat.c: Revert.
1693         * darwin-nat-info.c: Revert.
1694         * d-valprint.c: Revert.
1695         * d-namespace.c: Revert.
1696         * d-lang.c: Revert.
1697         * ctf.c: Revert.
1698         * csky-tdep.c: Revert.
1699         * csky-linux-tdep.c: Revert.
1700         * cris-tdep.c: Revert.
1701         * cris-linux-tdep.c: Revert.
1702         * cp-valprint.c: Revert.
1703         * cp-support.c: Revert.
1704         * cp-namespace.c: Revert.
1705         * cp-abi.c: Revert.
1706         * corelow.c: Revert.
1707         * corefile.c: Revert.
1708         * continuations.c: Revert.
1709         * completer.h: Revert.
1710         * completer.c: Revert.
1711         * complaints.c: Revert.
1712         * coffread.c: Revert.
1713         * coff-pe-read.c: Revert.
1714         * cli-out.h: Revert.
1715         * cli-out.c: Revert.
1716         * charset.c: Revert.
1717         * c-varobj.c: Revert.
1718         * c-valprint.c: Revert.
1719         * c-typeprint.c: Revert.
1720         * c-lang.c: Revert.
1721         * buildsym.c: Revert.
1722         * buildsym-legacy.c: Revert.
1723         * build-id.h: Revert.
1724         * build-id.c: Revert.
1725         * btrace.c: Revert.
1726         * bsd-uthread.c: Revert.
1727         * breakpoint.h: Revert.
1728         * breakpoint.c: Revert.
1729         * break-catch-throw.c: Revert.
1730         * break-catch-syscall.c: Revert.
1731         * break-catch-sig.c: Revert.
1732         * blockframe.c: Revert.
1733         * block.c: Revert.
1734         * bfin-tdep.c: Revert.
1735         * bfin-linux-tdep.c: Revert.
1736         * bfd-target.c: Revert.
1737         * bcache.c: Revert.
1738         * ax-general.c: Revert.
1739         * ax-gdb.h: Revert.
1740         * ax-gdb.c: Revert.
1741         * avr-tdep.c: Revert.
1742         * auxv.c: Revert.
1743         * auto-load.c: Revert.
1744         * arm-wince-tdep.c: Revert.
1745         * arm-tdep.c: Revert.
1746         * arm-symbian-tdep.c: Revert.
1747         * arm-pikeos-tdep.c: Revert.
1748         * arm-obsd-tdep.c: Revert.
1749         * arm-nbsd-tdep.c: Revert.
1750         * arm-nbsd-nat.c: Revert.
1751         * arm-linux-tdep.c: Revert.
1752         * arm-linux-nat.c: Revert.
1753         * arm-fbsd-tdep.c: Revert.
1754         * arm-fbsd-nat.c: Revert.
1755         * arm-bsd-tdep.c: Revert.
1756         * arch-utils.c: Revert.
1757         * arc-tdep.c: Revert.
1758         * arc-newlib-tdep.c: Revert.
1759         * annotate.h: Revert.
1760         * annotate.c: Revert.
1761         * amd64-windows-tdep.c: Revert.
1762         * amd64-windows-nat.c: Revert.
1763         * amd64-tdep.c: Revert.
1764         * amd64-sol2-tdep.c: Revert.
1765         * amd64-obsd-tdep.c: Revert.
1766         * amd64-obsd-nat.c: Revert.
1767         * amd64-nbsd-tdep.c: Revert.
1768         * amd64-nbsd-nat.c: Revert.
1769         * amd64-nat.c: Revert.
1770         * amd64-linux-tdep.c: Revert.
1771         * amd64-linux-nat.c: Revert.
1772         * amd64-fbsd-tdep.c: Revert.
1773         * amd64-fbsd-nat.c: Revert.
1774         * amd64-dicos-tdep.c: Revert.
1775         * amd64-darwin-tdep.c: Revert.
1776         * amd64-bsd-nat.c: Revert.
1777         * alpha-tdep.c: Revert.
1778         * alpha-obsd-tdep.c: Revert.
1779         * alpha-nbsd-tdep.c: Revert.
1780         * alpha-mdebug-tdep.c: Revert.
1781         * alpha-linux-tdep.c: Revert.
1782         * alpha-linux-nat.c: Revert.
1783         * alpha-bsd-tdep.c: Revert.
1784         * alpha-bsd-nat.c: Revert.
1785         * aix-thread.c: Revert.
1786         * agent.c: Revert.
1787         * addrmap.c: Revert.
1788         * ada-varobj.c: Revert.
1789         * ada-valprint.c: Revert.
1790         * ada-typeprint.c: Revert.
1791         * ada-tasks.c: Revert.
1792         * ada-lang.c: Revert.
1793         * aarch64-tdep.c: Revert.
1794         * aarch64-ravenscar-thread.c: Revert.
1795         * aarch64-newlib-tdep.c: Revert.
1796         * aarch64-linux-tdep.c: Revert.
1797         * aarch64-linux-nat.c: Revert.
1798         * aarch64-fbsd-tdep.c: Revert.
1799         * aarch64-fbsd-nat.c: Revert.
1800         * aarch32-linux-nat.c: Revert.
1801
1802 2019-04-05  Tom Tromey  <tom@tromey.com>
1803
1804         * ft32-tdep.c: Sort headers.
1805         * frv-tdep.c: Sort headers.
1806         * frv-linux-tdep.c: Sort headers.
1807         * frame.c: Sort headers.
1808         * frame-unwind.c: Sort headers.
1809         * frame-base.c: Sort headers.
1810         * fork-child.c: Sort headers.
1811         * findvar.c: Sort headers.
1812         * findcmd.c: Sort headers.
1813         * filesystem.c: Sort headers.
1814         * filename-seen-cache.h: Sort headers.
1815         * filename-seen-cache.c: Sort headers.
1816         * fbsd-tdep.c: Sort headers.
1817         * fbsd-nat.h: Sort headers.
1818         * fbsd-nat.c: Sort headers.
1819         * f-valprint.c: Sort headers.
1820         * f-typeprint.c: Sort headers.
1821         * f-lang.c: Sort headers.
1822         * extension.h: Sort headers.
1823         * extension.c: Sort headers.
1824         * extension-priv.h: Sort headers.
1825         * expprint.c: Sort headers.
1826         * exec.h: Sort headers.
1827         * exec.c: Sort headers.
1828         * exceptions.c: Sort headers.
1829         * event-top.c: Sort headers.
1830         * event-loop.c: Sort headers.
1831         * eval.c: Sort headers.
1832         * elfread.c: Sort headers.
1833         * dwarf2read.h: Sort headers.
1834         * dwarf2read.c: Sort headers.
1835         * dwarf2loc.c: Sort headers.
1836         * dwarf2expr.h: Sort headers.
1837         * dwarf2expr.c: Sort headers.
1838         * dwarf2-frame.c: Sort headers.
1839         * dwarf2-frame-tailcall.c: Sort headers.
1840         * dwarf-index-write.h: Sort headers.
1841         * dwarf-index-write.c: Sort headers.
1842         * dwarf-index-common.c: Sort headers.
1843         * dwarf-index-cache.h: Sort headers.
1844         * dwarf-index-cache.c: Sort headers.
1845         * dummy-frame.c: Sort headers.
1846         * dtrace-probe.c: Sort headers.
1847         * disasm.h: Sort headers.
1848         * disasm.c: Sort headers.
1849         * disasm-selftests.c: Sort headers.
1850         * dictionary.c: Sort headers.
1851         * dicos-tdep.c: Sort headers.
1852         * demangle.c: Sort headers.
1853         * dcache.h: Sort headers.
1854         * dcache.c: Sort headers.
1855         * darwin-nat.h: Sort headers.
1856         * darwin-nat.c: Sort headers.
1857         * darwin-nat-info.c: Sort headers.
1858         * d-valprint.c: Sort headers.
1859         * d-namespace.c: Sort headers.
1860         * d-lang.c: Sort headers.
1861         * ctf.c: Sort headers.
1862         * csky-tdep.c: Sort headers.
1863         * csky-linux-tdep.c: Sort headers.
1864         * cris-tdep.c: Sort headers.
1865         * cris-linux-tdep.c: Sort headers.
1866         * cp-valprint.c: Sort headers.
1867         * cp-support.c: Sort headers.
1868         * cp-namespace.c: Sort headers.
1869         * cp-abi.c: Sort headers.
1870         * corelow.c: Sort headers.
1871         * corefile.c: Sort headers.
1872         * continuations.c: Sort headers.
1873         * completer.h: Sort headers.
1874         * completer.c: Sort headers.
1875         * complaints.c: Sort headers.
1876         * coffread.c: Sort headers.
1877         * coff-pe-read.c: Sort headers.
1878         * cli-out.h: Sort headers.
1879         * cli-out.c: Sort headers.
1880         * charset.c: Sort headers.
1881         * c-varobj.c: Sort headers.
1882         * c-valprint.c: Sort headers.
1883         * c-typeprint.c: Sort headers.
1884         * c-lang.c: Sort headers.
1885         * buildsym.c: Sort headers.
1886         * buildsym-legacy.c: Sort headers.
1887         * build-id.h: Sort headers.
1888         * build-id.c: Sort headers.
1889         * btrace.c: Sort headers.
1890         * bsd-uthread.c: Sort headers.
1891         * breakpoint.h: Sort headers.
1892         * breakpoint.c: Sort headers.
1893         * break-catch-throw.c: Sort headers.
1894         * break-catch-syscall.c: Sort headers.
1895         * break-catch-sig.c: Sort headers.
1896         * blockframe.c: Sort headers.
1897         * block.c: Sort headers.
1898         * bfin-tdep.c: Sort headers.
1899         * bfin-linux-tdep.c: Sort headers.
1900         * bfd-target.c: Sort headers.
1901         * bcache.c: Sort headers.
1902         * ax-general.c: Sort headers.
1903         * ax-gdb.h: Sort headers.
1904         * ax-gdb.c: Sort headers.
1905         * avr-tdep.c: Sort headers.
1906         * auxv.c: Sort headers.
1907         * auto-load.c: Sort headers.
1908         * arm-wince-tdep.c: Sort headers.
1909         * arm-tdep.c: Sort headers.
1910         * arm-symbian-tdep.c: Sort headers.
1911         * arm-pikeos-tdep.c: Sort headers.
1912         * arm-obsd-tdep.c: Sort headers.
1913         * arm-nbsd-tdep.c: Sort headers.
1914         * arm-nbsd-nat.c: Sort headers.
1915         * arm-linux-tdep.c: Sort headers.
1916         * arm-linux-nat.c: Sort headers.
1917         * arm-fbsd-tdep.c: Sort headers.
1918         * arm-fbsd-nat.c: Sort headers.
1919         * arm-bsd-tdep.c: Sort headers.
1920         * arch-utils.c: Sort headers.
1921         * arc-tdep.c: Sort headers.
1922         * arc-newlib-tdep.c: Sort headers.
1923         * annotate.h: Sort headers.
1924         * annotate.c: Sort headers.
1925         * amd64-windows-tdep.c: Sort headers.
1926         * amd64-windows-nat.c: Sort headers.
1927         * amd64-tdep.c: Sort headers.
1928         * amd64-sol2-tdep.c: Sort headers.
1929         * amd64-obsd-tdep.c: Sort headers.
1930         * amd64-obsd-nat.c: Sort headers.
1931         * amd64-nbsd-tdep.c: Sort headers.
1932         * amd64-nbsd-nat.c: Sort headers.
1933         * amd64-nat.c: Sort headers.
1934         * amd64-linux-tdep.c: Sort headers.
1935         * amd64-linux-nat.c: Sort headers.
1936         * amd64-fbsd-tdep.c: Sort headers.
1937         * amd64-fbsd-nat.c: Sort headers.
1938         * amd64-dicos-tdep.c: Sort headers.
1939         * amd64-darwin-tdep.c: Sort headers.
1940         * amd64-bsd-nat.c: Sort headers.
1941         * alpha-tdep.c: Sort headers.
1942         * alpha-obsd-tdep.c: Sort headers.
1943         * alpha-nbsd-tdep.c: Sort headers.
1944         * alpha-mdebug-tdep.c: Sort headers.
1945         * alpha-linux-tdep.c: Sort headers.
1946         * alpha-linux-nat.c: Sort headers.
1947         * alpha-bsd-tdep.c: Sort headers.
1948         * alpha-bsd-nat.c: Sort headers.
1949         * aix-thread.c: Sort headers.
1950         * agent.c: Sort headers.
1951         * addrmap.c: Sort headers.
1952         * ada-varobj.c: Sort headers.
1953         * ada-valprint.c: Sort headers.
1954         * ada-typeprint.c: Sort headers.
1955         * ada-tasks.c: Sort headers.
1956         * ada-lang.c: Sort headers.
1957         * aarch64-tdep.c: Sort headers.
1958         * aarch64-ravenscar-thread.c: Sort headers.
1959         * aarch64-newlib-tdep.c: Sort headers.
1960         * aarch64-linux-tdep.c: Sort headers.
1961         * aarch64-linux-nat.c: Sort headers.
1962         * aarch64-fbsd-tdep.c: Sort headers.
1963         * aarch64-fbsd-nat.c: Sort headers.
1964         * aarch32-linux-nat.c: Sort headers.
1965
1966 2019-04-04  Tom Tromey  <tom@tromey.com>
1967
1968         * varobj.c (varobj_create): Update.
1969         * rust-exp.y (struct rust_parser) <update_innermost_block,
1970         lookup_symbol>: New methods.
1971         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1972         Rename.
1973         (rust_parser::rust_lookup_type)
1974         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1975         * printcmd.c (display_command, do_one_display): Update.
1976         * parser-defs.h (struct parser_state) <parser_state>: Add
1977         "tracker" parameter.
1978         (block_tracker): New member.
1979         (class innermost_block_tracker) <innermost_block_tracker>: Add
1980         "types" parameter.
1981         <reset>: Remove method.
1982         (innermost_block): Don't declare.
1983         (null_post_parser): Update.
1984         * parse.c (innermost_block): Remove global.
1985         (write_dollar_variable): Update.
1986         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1987         Remove "tracker_types" parameter.
1988         (parse_expression): Add "tracker" parameter.
1989         (parse_expression_for_completion): Update.
1990         (null_post_parser): Add "tracker" parameter.
1991         * p-exp.y: Update rules.
1992         * m2-exp.y: Update rules.
1993         * language.h (struct language_defn) <la_post_parser>: Add
1994         "tracker" parameter.
1995         * go-exp.y: Update rules.
1996         * f-exp.y: Update rules.
1997         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1998         parameter.
1999         * d-exp.y: Update rules.
2000         * c-exp.y: Update rules.
2001         * breakpoint.c (set_breakpoint_condition): Create an
2002         innermost_block_tracker.
2003         (watch_command_1): Likewise.
2004         * ada-lang.c (resolve): Add "tracker" parameter.
2005         (resolve_subexp): Likewise.
2006         * ada-exp.y (write_var_from_sym): Update.
2007
2008 2019-04-04  Tom Tromey  <tom@tromey.com>
2009
2010         * type-stack.h: New file.
2011         * type-stack.c: New file.
2012         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2013         type-stack.h.
2014         (insert_into_type_stack, insert_type, push_type, push_type_int)
2015         (insert_type_address_space, pop_type, pop_type_int)
2016         (pop_typelist, pop_type_stack, append_type_stack)
2017         (push_type_stack, get_type_stack, push_typelist)
2018         (follow_type_instance_flags, follow_types): Don't declare.
2019         * parse.c (type_stack): Remove global.
2020         (parse_exp_in_context): Update.
2021         (insert_into_type_stack, insert_type, push_type, push_type_int)
2022         (insert_type_address_space, pop_type, pop_type_int)
2023         (pop_typelist, pop_type_stack, append_type_stack)
2024         (push_type_stack, get_type_stack, push_typelist)
2025         (follow_type_instance_flags, follow_types): Remove (moved to
2026         type-stack.c).
2027         * f-exp.y (type_stack): New global.
2028         Update rules.
2029         (push_kind_type, f_parse): Update.
2030         * d-exp.y (type_stack): New global.
2031         Update rules.
2032         (d_parse): Update.
2033         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2034         Update rules.
2035         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2036         (HFILES_NO_SRCDIR): Add type-stack.h.
2037
2038 2019-04-04  Tom Tromey  <tom@tromey.com>
2039
2040         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2041         (rust_parser::convert_ast_to_expression, rust_parse)
2042         (rust_lex_test_completion, rust_lex_tests): Update.
2043         * parser-defs.h (struct expr_completion_state): New.
2044         (struct parser_state) <parser_state>: Add completion parameter.
2045         <mark_struct_expression, mark_completion_tag>: New methods.
2046         <parse_completion, m_completion_state>: New members.
2047         (prefixify_expression, null_post_parser): Update.
2048         (mark_struct_expression, mark_completion_tag): Don't declare.
2049         * parse.c (parse_completion, expout_last_struct)
2050         (expout_tag_completion_type, expout_completion_name): Remove
2051         globals.
2052         (parser_state::mark_struct_expression)
2053         (parser_state::mark_completion_tag): Now methods.
2054         (prefixify_expression): Add last_struct parameter.
2055         (prefixify_subexp): Likewise.
2056         (parse_exp_1): Update.
2057         (parse_exp_in_context): Add cstate parameter.  Update.
2058         (parse_expression_for_completion): Create an
2059         expr_completion_state.
2060         (null_post_parser): Add "completion" parameter.
2061         * p-exp.y: Update rules.
2062         (yylex): Update.
2063         * language.h (struct language_defn) <la_post_parser>: Add
2064         "completing" parameter.
2065         * go-exp.y: Update rules.
2066         (lex_one_token): Update.
2067         * expression.h (parse_completion): Don't declare.
2068         * d-exp.y: Update rules.
2069         (lex_one_token): Update rules.
2070         * c-exp.y: Update rules.
2071         (lex_one_token): Update.
2072         * ada-lang.c (resolve): Add "parse_completion" parameter.
2073         (resolve_subexp): Likewise.
2074         (ada_resolve_function): Likewise.
2075
2076 2019-04-04  Tom Tromey  <tom@tromey.com>
2077
2078         * parser-defs.h (struct parser_state) <start_arglist,
2079         end_arglist>: New methods.
2080         <arglist_len, m_funcall_chain>: New members.
2081         (arglist_len, start_arglist, end_arglist): Don't declare.
2082         * parse.c (arglist_len, funcall_chain): Remove global.
2083         (start_arglist, end_arglist): Remove functions.
2084         (parse_exp_in_context): Update.
2085         * p-exp.y: Update rules.
2086         * m2-exp.y: Update rules.
2087         * go-exp.y: Update rules.
2088         * f-exp.y: Update rules.
2089         * d-exp.y: Update rules.
2090         * c-exp.y: Update rules.
2091
2092 2019-04-04  Tom Tromey  <tom@tromey.com>
2093
2094         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2095         lex_operator, push_back>: New methods.
2096         Update all rules.
2097         (rust_parser::lex_hex, lex_escape): Rename and update.
2098         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2099         (rust_parser::lex_operator): Rename and update.
2100         (rust_parser::lex_number, rustyylex, rustyyerror)
2101         (rust_lex_test_init, rust_lex_test_sequence)
2102         (rust_lex_test_push_back, rust_lex_tests): Update.
2103         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2104         parameter.
2105         <lexptr, prev_lexptr>: New members.
2106         (lexptr, prev_lexptr): Don't declare.
2107         * parse.c (lexptr, prev_lexptr): Remove globals.
2108         (parse_exp_in_context): Update.
2109         * p-exp.y (yylex, yyerror): Update.
2110         * m2-exp.y (parse_number, yylex, yyerror): Update.
2111         * go-exp.y (lex_one_token, yyerror): Update.
2112         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2113         * d-exp.y (lex_one_token, yyerror): Update.
2114         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2115         (lex_one_token, yyerror): Update.
2116         * ada-lex.l (YY_INPUT): Update.
2117         (rewind_to_char): Update.
2118         * ada-exp.y (yyerror): Update.
2119
2120 2019-04-04  Tom Tromey  <tom@tromey.com>
2121
2122         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2123         * parser-defs.h (struct parser_state) <parser_state>: Add new
2124         parameter.
2125         <comma_terminates>: New member.
2126         (comma_terminates): Don't declare global.
2127         * parse.c (comma_terminates): Remove global.
2128         (parse_exp_in_context): Update.
2129         * p-exp.y (yylex): Update.
2130         * m2-exp.y (yylex): Update.
2131         * go-exp.y (lex_one_token): Update.
2132         * f-exp.y (yylex): Update.
2133         * d-exp.y (lex_one_token): Update.
2134         * c-exp.y (lex_one_token): Update.
2135         * ada-lex.l: Update.
2136
2137 2019-04-04  Tom Tromey  <tom@tromey.com>
2138
2139         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2140         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2141         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2142         * parser-defs.h (paren_depth): Don't declare.
2143         * parse.c (paren_depth): Remove global.
2144         (parse_exp_in_context): Update.
2145         * p-exp.y (paren_depth): New global.
2146         (pascal_parse): Initialize it.
2147         * m2-exp.y (paren_depth): New global.
2148         (m2_parse): Initialize it.
2149         * go-exp.y (paren_depth): New global.
2150         (go_parse): Initialize it.
2151         * f-exp.y (paren_depth): New global.
2152         (f_parse): Initialize it.
2153         * d-exp.y (paren_depth): New global.
2154         (d_parse): Initialize it.
2155         * c-exp.y (paren_depth): New global.
2156         (c_parse): Initialize it.
2157         * ada-lex.l (paren_depth): New global.
2158         (lexer_init): Initialize it.
2159
2160 2019-04-04  Tom Tromey  <tom@tromey.com>
2161
2162         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2163         (rust_parser::convert_ast_to_type)
2164         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2165         * parser-defs.h (struct parser_state) <parser_state>: Add
2166         parameters.  Initialize new members.
2167         <expression_context_block, expression_context_pc>: New members.
2168         * parse.c (expression_context_block, expression_context_pc):
2169         Remove globals.
2170         (parse_exp_in_context): Update.
2171         * p-exp.y: Update all rules.
2172         (yylex): Update.
2173         * m2-exp.y: Update all rules.
2174         (yylex): Update.
2175         * go-exp.y (yylex): Update.
2176         * f-exp.y (yylex): Update.
2177         * d-exp.y: Update all rules.
2178         (yylex): Update.
2179         * c-exp.y: Update all rules.
2180         (lex_one_token, classify_name, yylex, c_parse): Update.
2181         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2182
2183 2019-04-04  Tom Tromey  <tom@tromey.com>
2184
2185         * gdbarch.h, gdbarch.c: Rebuild.
2186         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2187         * stap-probe.h:
2188         (struct stap_parse_info): Replace "parser_state" with
2189         "expr_builder".
2190         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2191         (parser_state): New class.
2192         * parse.c (expr_builder): Rename.
2193         (expr_builder::release): Rename.
2194         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2195         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2196         (write_exp_elt_longcst, write_exp_elt_floatcst)
2197         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2198         (write_exp_string_vector, write_exp_bitstring)
2199         (write_exp_msymbol, mark_struct_expression)
2200         (write_dollar_variable)
2201         (insert_type_address_space, increase_expout_size): Replace
2202         "parser_state" with "expr_builder".
2203         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2204         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2205         "parser_state" with "expr_builder".
2206
2207 2019-04-04  Tom Tromey  <tom@tromey.com>
2208
2209         * rust-exp.y: Replace "parse_language" with method call.
2210         * p-exp.y:
2211         (yylex): Replace "parse_language" with method call.
2212         * m2-exp.y:
2213         (yylex): Replace "parse_language" with method call.
2214         * go-exp.y (classify_name): Replace "parse_language" with method
2215         call.
2216         * f-exp.y (yylex): Replace "parse_language" with method call.
2217         * d-exp.y (lex_one_token): Replace "parse_language" with method
2218         call.
2219         * c-exp.y:
2220         (lex_one_token, classify_name, yylex): Replace "parse_language"
2221         with method call.
2222         * ada-exp.y (find_primitive_type, type_char)
2223         (type_system_address): Replace "parse_language" with method call.
2224
2225 2019-04-04  Tom Tromey  <tom@tromey.com>
2226
2227         * rust-exp.y: Replace "parse_gdbarch" with method call.
2228         * parse.c (write_dollar_variable, insert_type_address_space):
2229         Replace "parse_gdbarch" with method call.
2230         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2231         call.
2232         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2233         call.
2234         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2235         "parse_gdbarch" with method call.
2236         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2237         with method call.
2238         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2239         "parse_gdbarch" with method call.
2240         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2241         "parse_gdbarch" with method call.
2242         * c-exp.y (parse_type, parse_number, classify_name): Replace
2243         "parse_gdbarch" with method call.
2244         * ada-lex.l: Replace "parse_gdbarch" with method call.
2245         * ada-exp.y (parse_type, find_primitive_type, type_char)
2246         (type_system_address): Replace "parse_gdbarch" with method call.
2247
2248 2019-04-04  Tom Tromey  <tom@tromey.com>
2249
2250         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2251         * stap-probe.c (stap_parse_argument): Update.
2252         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2253         initial_size parameter.
2254         * rust-exp.y (rust_lex_tests): Update.
2255         * parse.c (parser_state): Update.
2256         (parse_exp_in_context): Update.
2257         * parser-defs.h (struct parser_state) <parser_state>: Remove
2258         "initial_size" parameter.
2259
2260 2019-04-04  Tom Tromey  <tom@tromey.com>
2261
2262         * parser-defs.h (increase_expout_size): Don't declare.
2263         * parse.c (increase_expout_size): Now static.
2264
2265 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2266
2267         * gnu-nat.c (gnu_nat_target::wait): Fix
2268         target_waitstatus_to_string call.
2269
2270 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2271
2272         * eval.c (evaluate_subexp_standard): Handle internal functions
2273         during Fortran function call handling.
2274
2275 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2276
2277         * NEWS: Mention new internal functions.
2278         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2279         (read_base_type): Use dwarf2_init_complex_target_type.
2280         * value.c (creal_internal_fn): New function.
2281         (cimag_internal_fn): New function.
2282         (_initialize_values): Register new internal functions.
2283
2284 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2285
2286         * infrun.c (stop_all_threads): If debug_infrun, always
2287         trace the wait status after wait_one, using
2288         target_waitstatus_to_string and target_pid_to_str.
2289         (handle_inferior_event): Replace various trace of
2290         wait status kind by a single trace.
2291         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2292         wait status kind image by target_waitstatus_to_string.
2293         * target/waitstatus.c (target_waitstatus_to_string): Fix
2294         obsolete comment.
2295
2296 2019-04-01  Tom Tromey  <tromey@adacore.com>
2297
2298         PR symtab/23331:
2299         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2300
2301 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2302             Pedro Alves  <palves@redhat.com>
2303
2304         * top.c (quit_force): Call 'finalize_values'.
2305         * value.c (finalize_values): New function.
2306         * value.h (finalize_values): Declare.
2307
2308 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2309
2310         * NEWS: Announce $_gdb_major and $_gdb_minor.
2311
2312         * top.c (init_gdb_version_vars): New function.
2313         (gdb_init): Call init_gdb_version_vars.
2314
2315 2019-03-29  Tom Tromey  <tromey@adacore.com>
2316
2317         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2318         help text.  Remove dead code.
2319
2320 2019-03-29  Keith Seitz  <keiths@redhat.com>
2321
2322         From Siddhesh Poyarekar:
2323         * f-lang.h (f77_get_upperbound): Return LONGEST.
2324         (f77_get_lowerbound): Likewise.
2325         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2326         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2327         print them.
2328         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2329         plongest to format print it.
2330         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2331         (f77_get_upperbound): Likewise.
2332         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2333         LOWER_BOUND to LONGEST.
2334         (f77_create_arrayprint_offset_tbl): Likewise.
2335
2336 2019-03-29  Keith Seitz  <keiths@redhat.com>
2337
2338         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2339         %s/pulongest for TYPE_LENGTH instead of %d in format
2340         strings.
2341         * ada-typerint.c (ada_print_type): Likewise.
2342         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2343         * compile/compile-c-support.c (generate_register_struct): Likewise.
2344         * gdbtypes.c (recursive_dump_type): Likewise.
2345         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2346         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2347         instead of %d in format strings.
2348         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2349         to std::min to ULONGEST.
2350         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2351         instead of %d in format strings.
2352         * tracepoint.c (info_scope_command): Likewise.
2353         * typeprint.c (print_offset_data::update)
2354         (print_offset_data::finish): Likewise.
2355         * xtensa-tdep.c (xtensa_store_return_value)
2356         (xtensa_push_dummy_call): Likewise.
2357
2358 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2359
2360         * windows-nat.c (display_selector): Fixed format specifications
2361         for 64-bit Cygwin.
2362
2363 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2364
2365         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2366
2367 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2368
2369         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2370         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2371         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2372         (nios2_linux_init_abi): Install it.
2373
2374 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2375
2376         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2377
2378 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2379
2380         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2381
2382 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2383             Tom Tromey  <tromey@adacore.com>
2384
2385         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2386
2387 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2388
2389         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2390         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2391         method to compute the bounds of range types. Also print "[evaluated]"
2392         if the bounds' values come from a dynamic evaluation.
2393
2394 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2395
2396         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2397         whitespace when pretty printing is on.
2398
2399 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2400
2401         * ppc-linux-nat.c: Add include.
2402
2403 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2404
2405         * NEWS: Mention AArch64 Pointer Authentication.
2406
2407 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2408
2409         * arm-linux-nat.c: Add include.
2410
2411 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2412
2413         * source-cache.c (source_cache::get_source_lines): Re-read
2414         fullname after calling open_source_file.
2415
2416 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2417
2418         * NEWS: Mention TLS support for FreeBSD.
2419
2420 2019-03-25  Tom Tromey  <tromey@adacore.com>
2421
2422         * minsyms.c (BUNCH_SIZE): Update comment.
2423         (~minimal_symbol_reader): Remove old comment.
2424         (compact_minimal_symbols): Update comment.
2425         (minimal_symbol_reader::install): Remove old comment.  Update
2426         other comments.
2427
2428 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2429
2430         * s390-linux-nat.c: Add include.
2431
2432 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2433
2434         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2435         Call linux_get_hwcap.
2436         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2437         Likewise.
2438         (aarch64_linux_get_hwcap): Remove function.
2439         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2440         declaration.
2441         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2442         linux_get_hwcap.
2443         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2444         * linux-tdep.c (linux_get_hwcap): Add function.
2445         (linux_get_hwcap2): Likewise.
2446         * linux-tdep.h (linux_get_hwcap): Add declaration.
2447         (linux_get_hwcap2): Likewise.
2448         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2449         (ppc_linux_get_hwcap2): Likewise.
2450         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2451         linux_get_hwcap.
2452         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2453         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2454         (ppc_linux_nat_target::read_description): Likewise.
2455         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2456         * s390-linux-nat.c: Likewise.
2457         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2458
2459 2019-03-24  Tom Tromey  <tom@tromey.com>
2460
2461         * ada-lang.c (standard_lookup): Simplify initialization.
2462         (ada_lookup_symbol_nonlocal): Simplify return.
2463         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2464         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2465         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2466         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2467         initialization.
2468         * solib.c (solib_global_lookup): Simplify.
2469         * symtab.c (null_block_symbol): Remove.
2470         (symbol_cache_lookup): Simplify returns.
2471         (lookup_language_this): Simplify returns.
2472         (lookup_symbol_aux): Simplify return.
2473         (lookup_local_symbol): Simplify returns.
2474         (lookup_global_symbol_from_objfile): Simplify return.
2475         (lookup_symbol_in_objfile_symtabs)
2476         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2477         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2478         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2479         * cp-namespace.c (cp_lookup_bare_symbol)
2480         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2481         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2482         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2483         (cp_lookup_symbol_via_imports): Simplify initialization.
2484         (find_symbol_in_baseclass): Likewise.
2485         * symtab.h (null_block_symbol): Remove.
2486         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2487         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2488         (d_lookup_symbol_module): Likewise.
2489         (find_symbol_in_baseclass): Simplify initialization.
2490
2491 2019-03-24  Tom Tromey  <tom@tromey.com>
2492
2493         * expression.h: Don't include symtab.h.
2494         (struct block): Forward declare.
2495
2496 2019-03-24  Tom Tromey  <tom@tromey.com>
2497
2498         * c-exp.y (typebase): Remove casts.
2499         * gdbtypes.c (lookup_unsigned_typename, )
2500         (lookup_signed_typename): Remove cast.
2501         * eval.c (parse_to_comma_and_eval): Remove cast.
2502         * parse.c (write_dollar_variable): Remove cast.
2503         * block.h (struct block) <superblock>: Now const.
2504         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2505         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2506         (map_block): Make "block" const.
2507         * symfile.h (struct quick_symbol_functions)
2508         <map_matching_symbols>: Constify block argument to "callback".
2509         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2510         const.
2511         (find_pc_sect_compunit_symtab): Make "b" const.
2512         (find_symbol_at_address): Likewise.
2513         (search_symbols): Likewise.
2514         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2515         (dw2_debug_names_lookup_symbol): Likewise.
2516         (dw2_map_matching_symbols): Update.
2517         * p-valprint.c (pascal_val_print): Remove "block".
2518         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2519         (aux_add_nonlocal_symbols): Make "block" const.
2520         (resolve_subexp): Remove cast.
2521         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2522         const.
2523         (iterate_over_file_blocks): Likewise.
2524         * f-exp.y (%union) <bval>: Remove.
2525         * coffread.c (patch_opaque_types): Make "b" const.
2526         * spu-tdep.c (spu_catch_start): Make "block" const.
2527         * c-valprint.c (print_unpacked_pointer): Remove "block".
2528         * symmisc.c (dump_symtab_1): Make "b" const.
2529         (block_depth): Make "block" const.
2530         * d-exp.y (%union) <bval>: Remove.
2531         * cp-support.h (cp_lookup_rtti_type): Update.
2532         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2533         * psymtab.c (psym_lookup_symbol): Make "block" const.
2534         (maintenance_check_psymtabs): Make "b" const.
2535         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2536         (enumerate_locals, enumerate_args): Update.
2537         * python/py-symtab.c (stpy_global_block): Make "block" const.
2538         (stpy_static_block): Likewise.
2539         * inline-frame.c (block_starting_point_at): Make "new_block"
2540         const.
2541         * block.c (find_block_in_blockvector): Make return type const.
2542         (blockvector_for_pc_sect): Make "b" const.
2543         (find_block_in_blockvector): Make "b" const.
2544
2545 2019-03-23  Tom Tromey  <tom@tromey.com>
2546
2547         * varobj.c (varobj_create): Update.
2548         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2549         * printcmd.c (display_command, do_one_display): Don't reset
2550         innermost_block.
2551         * parser-defs.h (enum innermost_block_tracker_type): Move to
2552         expression.h.
2553         (innermost_block): Update comment.
2554         * parse.c (parse_exp_1): Add tracker_types parameter.
2555         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2556         tracker_types parameter.  Reset innermost_block.
2557         (parse_exp_in_context): Remove.
2558         (parse_expression_for_completion): Update.
2559         * objfiles.c (~objfile): Don't reset expression_context_block or
2560         innermost_block.
2561         * expression.h (enum innermost_block_tracker_type): Move from
2562         parser-defs.h.
2563         (parse_exp_1): Add tracker_types parameter.
2564         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2565         reset innermost_block.
2566
2567 2019-03-23  Tom Tromey  <tom@tromey.com>
2568
2569         * objfiles.h: Include bcache.h.
2570
2571 2019-03-23  Tom Tromey  <tom@tromey.com>
2572
2573         * linespec.c (get_current_search_block): Use
2574         scoped_restore_current_language.
2575         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2576
2577 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2578             Jiong Wang  <jiong.wang@arm.com>
2579
2580         * aarch64-linux-tdep.c
2581         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2582         section.
2583         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2584
2585 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2586             Jiong Wang  <jiong.wang@arm.com>
2587
2588         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2589         instructions.
2590         (aarch64_analyze_prologue_test): Add PACIASP test.
2591         (aarch64_prologue_prev_register): Unmask PC value.
2592
2593 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2594             Jiong Wang  <jiong.wang@arm.com>
2595
2596         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2597         (aarch64_dwarf2_prev_register): Unmask PC value.
2598         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2599         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2600         DW_CFA_AARCH64_negate_ra_state.
2601         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2602
2603 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2604             Jiong Wang  <jiong.wang@arm.com>
2605
2606         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2607         registers.
2608         (aarch64_pseudo_register_name): Likewise.
2609         (aarch64_pseudo_register_type): Likewise.
2610         (aarch64_pseudo_register_reggroup_p): Likewise.
2611         (aarch64_gdbarch_init): Add pauth registers.
2612         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2613         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2614         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2615         (struct gdbarch_tdep): Add regnum for ra_state.
2616
2617 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2618             Jiong Wang  <jiong.wang@arm.com>
2619
2620         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2621
2622 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2623             Jiong Wang  <jiong.wang@arm.com>
2624
2625         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2626         function.
2627         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2628         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2629         (aarch64_gdbarch_init): Add puth registers.
2630         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2631         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2632         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2633
2634 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2635             Jiong Wang  <jiong.wang@arm.com>
2636
2637         * aarch64-linux-nat.c
2638         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2639         * aarch64-linux-tdep.c
2640         (aarch64_linux_core_read_description): Likewise.
2641         (aarch64_linux_get_hwcap): New function.
2642         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2643         (aarch64_linux_get_hwcap): New declaration.
2644
2645 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2646             Jiong Wang  <jiong.wang@arm.com>
2647
2648         * aarch64-linux-nat.c
2649         (aarch64_linux_nat_target::read_description): Add pauth param.
2650         * aarch64-linux-tdep.c
2651         (aarch64_linux_core_read_description): Likewise.
2652         * aarch64-tdep.c (struct target_desc): Add in pauth.
2653         (aarch64_read_description): Add pauth param.
2654         (aarch64_gdbarch_init): Likewise.
2655         * aarch64-tdep.h (aarch64_read_description): Likewise.
2656         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2657         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2658         * features/Makefile: Add new files.
2659         * features/aarch64-pauth.c: New file.
2660         * features/aarch64-pauth.xml: New file.
2661
2662 2019-03-20  Tom Tromey  <tromey@adacore.com>
2663
2664         * infrun.c (handle_inferior_event): Rename from
2665         handle_inferior_event_1.  Create a scoped_value_mark.
2666         (handle_inferior_event): Remove.
2667
2668 2019-03-19  Tom Tromey  <tromey@adacore.com>
2669
2670         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2671         * infrun.h (print_stop_event): Add "displays" parameter.
2672         * infrun.c (print_stop_event): Add "displays" parameter.
2673
2674 2019-03-19  Pedro Alves  <palves@redhat.com>
2675
2676         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2677         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2678         to -1.  Fix TABs vs spaces.
2679         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2680         * tui/tui-out.h (tui_ui_out) Add intro comments.
2681         <m_line, m_start_of_line>: In-class initialize, and add describing
2682         comment.
2683
2684 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2685
2686         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2687         variable names.
2688         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2689
2690 2019-03-18  Pedro Alves  <palves@redhat.com>
2691             Eli Zaretskii <eliz@gnu.org>
2692
2693         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2694         m_line and m_start_of_line.
2695
2696 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2697
2698         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2699         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2700         it returns a newline.  This fixes a regression in TU mode, whereby
2701         the next line is output on the same screen line as the user input.
2702
2703 2019-03-18  Tom Tromey  <tromey@adacore.com>
2704
2705         * minsyms.c (minimal_symbol_reader::install): Remove call to
2706         obstack_blank.
2707
2708 2019-03-18  Pedro Alves  <palves@redhat.com>
2709
2710         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2711         New globals.
2712         (apply_style): New, factored out from ...
2713         (apply_ansi_escape): ... this.  Handle reverse video mode.
2714         (tui_set_reverse_mode): New function.
2715         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2716         * tui/tui-winsource.c (tui_show_source_line): Use
2717         tui_set_reverse_mode instead of setting A_STANDOUT.
2718         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2719         New setter methods.
2720
2721 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2722
2723         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2724         Handle tabs.
2725
2726 2019-03-18  Tom Tromey  <tromey@adacore.com>
2727
2728         * ada-lang.c (empty_array): Add "high" parameter.
2729         (ada_evaluate_subexp): Update.
2730
2731 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2732
2733         * unittests/string_view-selftests.c: Define
2734         _initialize_string_view_selftests unconditionally.
2735
2736 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2737
2738         PR gdb/24350
2739         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2740
2741 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2742
2743         PR gdb/24351
2744         * windows-nat.c (display_selector): Fix format specifiers.
2745
2746 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2747
2748         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2749         tui_refill_source_window instead of tui_refresh_win, to update the
2750         current execution line.  This fixes redisplay of the current line
2751         when stepping through the code with "next" or "step".
2752
2753 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2754
2755         * source-cache.c (source_cache::get_source_lines): Call
2756         find_source_lines to initialize s->nlines.  This fixes vertical
2757         scrolling of TUI source window when the DOWN arrow is pressed.
2758
2759 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2760
2761         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2762         linux-thread-db.c (_initialize_thread_db): Likewise.
2763
2764 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2765
2766         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2767         wclrtoeol in tui_show_source_line".  This reverts changes made in
2768         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2769
2770 2019-03-15  Tom Tromey  <tom@tromey.com>
2771
2772         * symtab.h (struct minimal_symbol): Derive from
2773         general_symbol_info.
2774         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2775         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2776         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2777         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2778         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2779         (MSYMBOL_SEARCH_NAME): Update.
2780         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2781         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2782         * minsyms.c (minimal_symbol_reader::record_full): Update.
2783
2784 2019-03-15  Tom Tromey  <tom@tromey.com>
2785
2786         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2787
2788 2019-03-15  Tom Tromey  <tom@tromey.com>
2789
2790         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2791         unique_xmalloc_ptr.
2792         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2793         Update.
2794         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2795         (build_minimal_symbol_hash_tables)
2796         (minimal_symbol_reader::install): Update.
2797
2798 2019-03-15  Tom Tromey  <tom@tromey.com>
2799
2800         * symtab.c (create_demangled_names_hash): Update.
2801         (symbol_set_names): Update.
2802         * objfiles.h (struct objfile_per_bfd_storage)
2803         <demangled_names_hash>: Now an htab_up.
2804         * objfiles.c (objfile_per_bfd_storage): Simplify.
2805
2806 2019-03-15  Tom Tromey  <tom@tromey.com>
2807
2808         * objfiles.h (struct objfile_per_bfd_storage): Declare
2809         destructor.
2810         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2811         New.
2812         (get_objfile_bfd_data): Use new.  Don't initialize
2813         language_of_main.
2814         (free_objfile_per_bfd_storage): Remove.
2815         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2816
2817 2019-03-15  Tom Tromey  <tom@tromey.com>
2818
2819         * symfile.c (reread_symbols): Update.
2820         * objfiles.c (objfile::objfile): Update.
2821         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2822         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2823         comment.
2824         (minimal_symbol_reader::install): Update.
2825         (terminate_minimal_symbol_table): Remove.
2826         * jit.c (jit_object_close_impl): Update.
2827
2828 2019-03-15  Tom Tromey  <tom@tromey.com>
2829
2830         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2831         initializations.
2832
2833 2019-03-15  Tom Tromey  <tom@tromey.com>
2834
2835         * objfiles.h (struct objfile_per_bfd_storage)
2836         <demangled_hash_languages>: Now a bitset.
2837         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2838         (lookup_minimal_symbol): Update.
2839
2840 2019-03-15  Tom Tromey  <tom@tromey.com>
2841
2842         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2843         Don't return the symbol.
2844         * coffread.c (record_minimal_symbol): Use record_full.
2845
2846 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2847
2848         The MS-Windows port of ncurses fails to switch to a color pair if
2849         one or both of the colors are the implicit default colors.  This
2850         change records the default colors when TUI is initialized, and
2851         then specifies them explicitly when a color pair uses the default
2852         colors.  This allows color styling in TUI mode on MS-Windows.
2853
2854         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2855         ncurses_norm_attr.
2856         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2857         colors in ncurses_norm_attr.
2858         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2859         "none", replace it with the default color recorded in
2860         ncurses_norm_attr.
2861
2862 2019-03-14  Tom Tromey  <tromey@adacore.com>
2863
2864         * source-cache.h (class source_cache) <get_source_lines>: Return
2865         std::string.
2866         * source-cache.c (source_cache::extract_lines): Handle case where
2867         first_pos==npos.  Return std::string.
2868         (source_cache::get_source_lines): Update.
2869
2870 2019-03-14  Tom Tromey  <tromey@adacore.com>
2871
2872         * NEWS: Add item for "style sources" commands.
2873         * source-cache.c (source_cache::get_source_lines): Check
2874         source_styling.
2875         * cli/cli-style.c (source_styling): New global.
2876         (_initialize_cli_style): Add "style sources" commands.
2877         (show_style_sources): New function.
2878         * cli/cli-style.h (source_styling): Declare.
2879
2880 2019-03-14  Pedro Alves  <palves@redhat.com>
2881             Tom Tromey  <tromey@adacore.com>
2882
2883         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2884         * tui/tui-winsource.c (tui_refill_source_window): New function,
2885         from...
2886         (tui_horizontal_source_scroll): ... here.  Move some logic.
2887         * cli/cli-style.c (set_style_enabled): Notify new observable.
2888         * tui/tui-hooks.c (tui_redisplay_source): New function.
2889         (tui_attach_detach_observers): Attach or detach
2890         tui_redisplay_source.
2891         * observable.h (source_styling_changed): New observable.
2892         * observable.c: Define source_styling_changed observable.
2893
2894 2019-03-13  Tom Tromey  <tromey@adacore.com>
2895
2896         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2897         (i386_gnu_nat_target::store_registers): Update.
2898         * target-debug.h (target_debug_print_std_string): New macro.
2899         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2900         * windows-tdep.c (display_one_tib): Update.
2901         * tui/tui-stack.c (tui_make_status_line): Update.
2902         * top.c (print_inferior_quit_action): Update.
2903         * thread.c (thr_try_catch_cmd): Update.
2904         (add_thread_with_info): Update.
2905         (thread_target_id_str): Update.
2906         (thr_try_catch_cmd): Update.
2907         (thread_command): Update.
2908         (thread_find_command): Update.
2909         * record-btrace.c (record_btrace_target::info_record)
2910         (record_btrace_resume_thread, record_btrace_target::resume)
2911         (record_btrace_cancel_resume, record_btrace_step_thread)
2912         (record_btrace_target::wait, record_btrace_target::wait)
2913         (record_btrace_target::wait, record_btrace_target::stop): Update.
2914         * progspace.c (print_program_space): Update.
2915         * process-stratum-target.c
2916         (process_stratum_target::thread_address_space): Update.
2917         * linux-fork.c (linux_fork_mourn_inferior)
2918         (detach_checkpoint_command, info_checkpoints_command)
2919         (linux_fork_context): Update.
2920         (linux_fork_detach): Update.
2921         (class scoped_switch_fork_info): Update.
2922         (delete_checkpoint_command): Update.
2923         * infrun.c (follow_fork_inferior): Update.
2924         (follow_fork_inferior): Update.
2925         (proceed_after_vfork_done): Update.
2926         (handle_vfork_child_exec_or_exit): Update.
2927         (follow_exec): Update.
2928         (displaced_step_prepare_throw): Update.
2929         (displaced_step_restore): Update.
2930         (start_step_over): Update.
2931         (resume_1): Update.
2932         (clear_proceed_status_thread): Update.
2933         (proceed): Update.
2934         (print_target_wait_results): Update.
2935         (do_target_wait): Update.
2936         (context_switch): Update.
2937         (stop_all_threads): Update.
2938         (restart_threads): Update.
2939         (finish_step_over): Update.
2940         (handle_signal_stop): Update.
2941         (switch_back_to_stepped_thread): Update.
2942         (keep_going_pass_signal): Update.
2943         (print_exited_reason): Update.
2944         (normal_stop): Update.
2945         * inferior.c (inferior_pid_to_str): Change return type.
2946         (print_selected_inferior): Update.
2947         (add_inferior): Update.
2948         (detach_inferior): Update.
2949         * dummy-frame.c (fprint_dummy_frames): Update.
2950         * dcache.c (dcache_info_1): Update.
2951         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2952         (btrace_fetch, btrace_clear): Update.
2953         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2954         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2955         type.
2956         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2957         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2958         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2959         * gdbarch.c, gdbarch.h: Rebuild.
2960         * gdbarch.sh (core_pid_to_str): Change return type.
2961         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2962         return type.
2963         (windows_nat_target::pid_to_str): Change return type.
2964         (windows_delete_thread): Update.
2965         (windows_nat_target::attach): Update.
2966         (windows_nat_target::files_info): Update.
2967         * target-delegates.c: Rebuild.
2968         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2969         return type.
2970         (sol_thread_target::pid_to_str): Change return type.
2971         * remote.c (class remote_target) <pid_to_str>: Change return
2972         type.
2973         (remote_target::pid_to_str): Change return type.
2974         (extended_remote_target::attach, remote_target::remote_stop_ns)
2975         (remote_target::remote_notif_remove_queued_reply)
2976         (remote_target::push_stop_reply, remote_target::disable_btrace):
2977         Update.
2978         (extended_remote_target::attach): Update.
2979         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2980         type.
2981         (gdbsim_target::pid_to_str): Change return type.
2982         * ravenscar-thread.c (struct ravenscar_thread_target)
2983         <pid_to_str>: Change return type.
2984         (ravenscar_thread_target::pid_to_str): Change return type.
2985         * procfs.c (class procfs_target) <pid_to_str>: Change return
2986         type.
2987         (procfs_target::pid_to_str): Change return type.
2988         (procfs_target::attach): Update.
2989         (procfs_target::detach): Update.
2990         (procfs_target::fetch_registers): Update.
2991         (procfs_target::store_registers): Update.
2992         (procfs_target::wait): Update.
2993         (procfs_target::files_info): Update.
2994         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2995         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2996         return type.
2997         (nto_procfs_target::pid_to_str): Change return type.
2998         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2999         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3000         return type.
3001         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3002         (exit_lwp): Update.
3003         (attach_proc_task_lwp_callback, get_detach_signal)
3004         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3005         (linux_nat_target::resume, wait_lwp, stop_callback)
3006         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3007         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3008         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3009         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3010         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3011         type.
3012         (inf_ptrace_target::attach): Update.
3013         (inf_ptrace_target::files_info): Update.
3014         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3015         type.
3016         (go32_nat_target::pid_to_str): Change return type.
3017         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3018         (gnu_nat_target::wait): Update.
3019         (gnu_nat_target::wait): Update.
3020         (gnu_nat_target::resume): Update.
3021         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3022         (fbsd_nat_target::wait): Update.
3023         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3024         type.
3025         (darwin_nat_target::attach): Update.
3026         * corelow.c (class core_target) <pid_to_str>: Change return type.
3027         (core_target::pid_to_str): Change return type.
3028         * target.c (normal_pid_to_str): Change return type.
3029         (default_pid_to_str): Likewise.
3030         (target_pid_to_str): Change return type.
3031         (target_translate_tls_address): Update.
3032         (target_announce_detach): Update.
3033         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3034         return type.
3035         (bsd_uthread_target::pid_to_str): Change return type.
3036         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3037         type.
3038         (bsd_kvm_target::pid_to_str): Change return type.
3039         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3040         return type.
3041         (aix_thread_target::pid_to_str): Change return type.
3042         * target.h (struct target_ops) <pid_to_str>: Change return type.
3043         (target_pid_to_str, normal_pid_to_str): Likewise.
3044         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3045         type.
3046         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3047         type.
3048         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3049         return type.
3050         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3051         type.
3052         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3053         type.
3054         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3055         return type.
3056
3057 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3058
3059         * NEWS: Mention that the new default MI version is 3.  Mention
3060         changes to the output of commands and events that deal with
3061         multi-location breakpoints.
3062         * breakpoint.c: Include "mi/mi-out.h".
3063         (print_one_breakpoint): Change output syntax if using MI version
3064         >= 3.
3065         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3066         New.
3067         (mi_multi_location_breakpoint_output_fixed): New.
3068         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3069         (mi_cmd_fix_multi_location_breakpoint_output): New.
3070         (mi_multi_location_breakpoint_output_fixed): New.
3071         * mi/mi-cmds.c (mi_cmds): Register command
3072         -fix-multi-location-breakpoint-output.
3073         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3074         interpreter "mi".
3075
3076 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3077
3078         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3079         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3080         instantiate mi_ui_out based on interpreter name.
3081         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3082         * mi/mi-main.c (mi_load_progress): Likewise.
3083
3084 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3085
3086         * NEWS: Combine separate "New targets" sections for 8.3.
3087
3088 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3089
3090         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3091         (ppcfbsd_init_abi): Install gdbarch
3092         "fetch_tls_load_module_address" and "get_thread_local_address"
3093         methods.
3094
3095 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3096
3097         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3098         (riscv_fbsd_init_abi): Install gdbarch
3099         "fetch_tls_load_module_address" and "get_thread_local_address"
3100         methods.
3101
3102 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3103
3104         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3105         (i386fbsd_init_abi): Install gdbarch
3106         "fetch_tls_load_module_address" and "get_thread_local_address"
3107         methods.
3108
3109 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3110
3111         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3112         (amd64fbsd_init_abi): Install gdbarch
3113         "fetch_tls_load_module_address" and "get_thread_local_address"
3114         methods.
3115
3116 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3117
3118         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3119         (struct fbsd_pspace_data): New type.
3120         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3121         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3122         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3123         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3124         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3125
3126 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3127
3128         * gdbtypes.c (lookup_struct_elt): New function.
3129         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3130         * gdbtypes.h (struct struct_elt): New type.
3131         (lookup_struct_elt): New prototype.
3132
3133 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3134
3135         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3136         remove disabled code block.
3137
3138 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3139
3140         * gdbarch.sh (get_thread_local_address): New method.
3141         * gdbarch.h, gdbarch.c: Regenerate.
3142         * target.c (target_translate_tls_address): Use
3143         gdbarch_get_thread_local_address if present instead of
3144         target::get_thread_local_address.
3145
3146 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3147
3148         * target.h (target::get_thread_local_address): Update comment.
3149
3150 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3151
3152         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3153         objfile->separate_debug_objfile_backlink if not NULL.
3154
3155 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3156
3157         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3158         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3159         (amd64bsd_store_inferior_registers): Likewise.
3160         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3161         Enable segment base registers.
3162         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3163         PT_GETFSBASE and PT_GETGSBASE.
3164         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3165         PT_SETGSBASE.
3166         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3167         segment base registers.
3168         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3169
3170 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3171
3172         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3173         Update calls to i386_target_description to add 'segments'
3174         parameter.
3175         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3176         add segment base registers.
3177         * arch/i386.c (i386_create_target_description): Add 'segments'
3178         parameter to enable segment base registers.
3179         * arch/i386.h (i386_create_target_description): Likewise.
3180         * features/i386/32bit-segments.xml: New file.
3181         * features/i386/32bit-segments.c: Generate.
3182         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3183         call to i386_target_description to add 'segments' parameter.
3184         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3185         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3186         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3187         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3188         if feature is present.
3189         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3190         Add 'segments' parameter to call to i386_target_description.
3191         (i386_target_description): Add 'segments' parameter to enable
3192         segment base registers.
3193         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3194         to call to i386_target_description.
3195         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3196         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3197         Define I386_NUM_REGS.
3198         (i386_target_description): Add 'segments' parameter to enable
3199         segment base registers.
3200
3201 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3202
3203         PR/24325
3204         * source-cache.c: #undef open and close, to avoid unresolved
3205         externals during linking.
3206
3207 2019-03-12  Tom Tromey  <tromey@adacore.com>
3208
3209         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3210         const.  Add initializers.
3211         (_initialize_remote): Don't initialize ptid globals.
3212
3213 2019-03-12  Pedro Alves  <palves@redhat.com>
3214
3215         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3216
3217 2019-03-12  Pedro Alves  <palves@redhat.com>
3218
3219         * cp-name-parser.y (main): Remove unused 'len' variable.
3220
3221 2019-03-12  Tom Tromey  <tromey@adacore.com>
3222
3223         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3224         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3225
3226 2019-03-12  Tom Tromey  <tromey@adacore.com>
3227
3228         * linux-nat.c (iterate_over_lwps): Update.
3229         (stop_callback): Remove parameter.
3230         (stop_wait_callback, detach_callback, resume_set_callback)
3231         (select_singlestep_lwp_callback, set_ignore_sigint)
3232         (status_callback, resumed_callback, resume_clear_callback)
3233         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3234         data parameter.
3235         (linux_nat_target::detach, linux_nat_target::resume)
3236         (linux_stop_and_wait_all_lwps, select_event_lwp)
3237         (linux_nat_filter_event, linux_nat_wait_1)
3238         (linux_nat_target::kill, linux_nat_target::stop)
3239         (linux_nat_target::stop): Update.
3240         (linux_nat_resume_callback): Change type.
3241         (resume_stopped_resumed_lwps, count_events_callback)
3242         (select_event_lwp_callback): Likewise.
3243         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3244         * arm-linux-nat.c (struct update_registers_data): Remove.
3245         (update_registers_callback): Change type.
3246         (arm_linux_insert_hw_breakpoint1): Update.
3247         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3248         parameter.
3249         (x86_linux_dr_set_addr): Update.
3250         (x86_linux_dr_set_control): Update.
3251         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3252         (iterate_over_lwps): Use gdb::function_view.
3253         * nat/aarch64-linux-hw-point.c (struct
3254         aarch64_dr_update_callback_param): Remove.
3255         (debug_reg_change_callback): Change type.
3256         (aarch64_notify_debug_reg_change): Update.
3257         * s390-linux-nat.c (s390_refresh_per_info): Update.
3258
3259 2019-03-11  Tom Tromey  <tromey@adacore.com>
3260
3261         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3262         redundant assignment to "this_cu".
3263
3264 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3265
3266         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3267
3268 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3269
3270         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3271         from...
3272         (rank_one_type): ... this.
3273
3274 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3275
3276         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3277         from...
3278         (rank_one_type): ... this.
3279
3280 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3281
3282         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3283         from...
3284         (rank_one_type): ... this.
3285
3286 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3287
3288         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3289         from...
3290         (rank_one_type): ... this.
3291
3292 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3293
3294         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3295         from...
3296         (rank_one_type): ... this.
3297
3298 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3299
3300         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3301         from...
3302         (rank_one_type): ... this.
3303
3304 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3305
3306         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3307         from...
3308         (rank_one_type): ... this.
3309
3310 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3311
3312         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3313         from...
3314         (rank_one_type): ... this.
3315
3316 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3317
3318         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3319         from...
3320         (rank_one_type): ... this.
3321
3322 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3323
3324         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3325         from...
3326         (rank_one_type): ... this.
3327
3328 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3329
3330         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3331         from...
3332         (rank_one_type): ... this.
3333
3334 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3335
3336         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3337         from...
3338         (rank_one_type): ... this.
3339
3340 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3341
3342         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3343         inferior-events' shows the example events.
3344
3345 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3346
3347         Support styling on native MS-Windows console
3348
3349         PR/24315
3350         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3351         on MS-Windows if $TERM is not defined.
3352
3353         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3354
3355         * posix-hdep.c (gdb_console_fputs):
3356         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3357         functions.
3358         * ui-file.h (gdb_console_fputs): Add prototype.
3359
3360         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3361         back to fputs only if the former returns zero.
3362
3363 2019-03-07  Tom Tromey  <tom@tromey.com>
3364
3365         * symmisc.c (print_symbol_bcache_statistics): Update.
3366         (print_objfile_statistics): Update.
3367         * symfile.c (allocate_symtab): Update.
3368         * stabsread.c: Don't include bcache.h.
3369         * psymtab.h (struct psymbol_bcache): Don't declare.
3370         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3371         (psymbol_bcache_init, psymbol_bcache_free)
3372         (psymbol_bcache_get_bcache): Don't declare.
3373         * psymtab.c (struct psymbol_bcache): Remove.
3374         (psymtab_storage::psymtab_storage): Update.
3375         (psymtab_storage::~psymtab_storage): Update.
3376         (psymbol_bcache_init, psymbol_bcache_free)
3377         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3378         (add_psymbol_to_bcache): Update.
3379         (allocate_psymtab): Update.
3380         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3381         macro_cache>: No longer pointers.
3382         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3383         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3384         * macrotab.c (macro_bcache): Update.
3385         * macroexp.c: Don't include bcache.h.
3386         * gdbtypes.c (check_types_worklist): Update.
3387         (types_deeply_equal): Remove TRY/CATCH.  Update.
3388         * elfread.c (elf_symtab_read): Update.
3389         * dwarf2read.c: Don't include bcache.h.
3390         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3391         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3392         (print_bcache_statistics, bcache_memory_used): Don't declare.
3393         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3394         methods.  Rename all data members.
3395         * bcache.c (struct bcache): Move to bcache.h.
3396         (bcache::expand_hash_table): Rename from expand_hash_table.
3397         (bcache): Remove.
3398         (bcache::insert): Rename from bcache_full.
3399         (bcache::compare): Rename from bcache_compare.
3400         (bcache_xmalloc): Remove.
3401         (bcache::~bcache): Rename from bcache_xfree.
3402         (bcache::print_statistics): Rename from print_bcache_statistics.
3403         (bcache::memory_used): Rename from bcache_memory_used.
3404
3405 2019-03-07  Pedro Alves  <palves@redhat.com>
3406
3407         * infrun.c (normal_stop): Also check for
3408         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3409
3410 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3411
3412         * f-lang.c (value_from_host_double): Moved to...
3413         * value.c (value_from_host_double): ...here.
3414         * value.h (value_from_host_double): Declare.
3415         * guile/scm-math.c (vlscm_convert_typed_number): Use
3416         value_from_host_double.
3417         (vlscm_convert_number): Likewise.
3418         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3419         * python/py-value.c (convert_value_from_python): Likewise.
3420
3421 2019-03-06  Tom Tromey  <tom@tromey.com>
3422
3423         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3424
3425 2019-03-06  Tom Tromey  <tom@tromey.com>
3426
3427         * utils.h (free_current_contents): Don't declare.
3428         * utils.c (free_current_contents): Remove.
3429
3430 2019-03-06  Tom Tromey  <tom@tromey.com>
3431
3432         * top.c (quit_force): Update.
3433         * main.c (captured_command_loop): Update.
3434         * common/new-op.c (operator new): Update.
3435         * common/common-exceptions.c (struct catcher)
3436         <save_cleanup_chain>: Remove member.
3437         (exceptions_state_mc_init): Update.
3438         (exception_try_scope_entry): Return nullptr.
3439         (exception_try_scope_exit, exception_rethrow)
3440         (throw_exception_sjlj, throw_exception_cxx): Update.
3441         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3442         (all_cleanups, do_cleanups, discard_cleanups)
3443         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3444         (restore_cleanups, restore_final_cleanups): Don't declare.
3445         (do_final_cleanups): Remove parameter.
3446         * common/cleanups.c (cleanup_chain, make_cleanup)
3447         (make_cleanup_dtor, all_cleanups, do_cleanups)
3448         (discard_my_cleanups, discard_cleanups)
3449         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3450         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3451         (null_cleanup): Remove.
3452         (do_final_cleanups): Remove parameter.
3453
3454 2019-03-06  Tom Tromey  <tom@tromey.com>
3455
3456         * remote.c (remote_target::remote_parse_stop_reply): Use
3457         unique_xmalloc_ptr.
3458
3459 2019-03-06  Tom Tromey  <tom@tromey.com>
3460
3461         * stabsread.c (struct stabs_field_info): Rename from field_info.
3462         <list, fnlist>: Add initializers.
3463         <obstack>: New member.
3464         (read_member_functions, read_struct_fields, read_baseclasses):
3465         Allocate on obstack.  Don't use cleanups.
3466         (read_one_struct_field, read_member_functions, read_struct_fields)
3467         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3468         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3469         (read_struct_type): Update.
3470
3471 2019-03-06  Tom Tromey  <tom@tromey.com>
3472
3473         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3474         * common/filestuff.h (make_cleanup_close): Don't declare.
3475         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3476         Remove.
3477
3478 2019-03-06  Tom Tromey  <tom@tromey.com>
3479
3480         * solib-aix.c: Use make_scope_exit.
3481
3482 2019-03-06  Tom Tromey  <tom@tromey.com>
3483
3484         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3485         Use make_scope_exit.
3486
3487 2019-03-06  Tom Tromey  <tom@tromey.com>
3488
3489         * solib-svr4.c (disable_probes_interface): Remove parameter.
3490         (svr4_handle_solib_event): Use make_scope_exit.
3491
3492 2019-03-06  Tom Tromey  <tom@tromey.com>
3493
3494         * remote.c (struct stop_reply_deleter): Remove.
3495         (stop_reply_up): Update.
3496         (struct stop_reply): Derive from notif_event.  Don't typedef.
3497         <regcache>: Now a std::vector.
3498         (stop_reply_xfree): Remove.
3499         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3500         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3501         (remote_target::discard_pending_stop_replies): Use delete.
3502         (remote_target::remote_parse_stop_reply): Update.
3503         (remote_target::process_stop_reply): Update.
3504         * remote-notif.h (struct notif_event): Add virtual destructor.
3505         Remove "dtr" member.
3506         (struct notif_client) <alloc_event>: Return a unique_ptr.
3507         (notif_event_xfree): Don't declare.
3508         (notif_event_up): New typedef.
3509         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3510         (notif_event_xfree, do_notif_event_xfree): Remove.
3511         (remote_notif_state_xfree): Update.
3512
3513 2019-03-06  Tom Tromey  <tom@tromey.com>
3514
3515         * infrun.c (displaced_step_clear_cleanup): Now a
3516         forward_scope_exit type.
3517         (displaced_step_prepare_throw): Update.
3518         (displaced_step_fixup): Update.
3519
3520 2019-03-06  Tom Tromey  <tom@tromey.com>
3521
3522         * inferior.h (class inferior): Update comment.
3523         * gdbthread.h (class thread_info): Update comment.
3524
3525 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3526             Tom Tromey  <tom@tromey.com>
3527
3528         * stabsread.h (struct stab_section_list): Remove.
3529         (coffstab_build_psymtabs): Update.
3530         * dbxread.c (symbuf_sections): Now a std::vector.
3531         (sect_idx): New global.
3532         (fill_symbuf): Update.
3533         (coffstab_build_psymtabs): Change type of stabsects parameter.
3534         Update.
3535         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3536         std::vector.
3537         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3538         (coff_locate_sections): Update.
3539         (coff_symfile_read): Remove cleanups.  Update.
3540         (init_stringtab): Add storage parameter.
3541         (free_stringtab, free_stringtab_cleanup): Remove.
3542         (init_lineno): Add storage parameter.
3543         (free_linetab, free_linetab_cleanup): Remove.
3544
3545 2019-03-06  Pedro Alves  <palves@redhat.com>
3546
3547         * linux-fork.c (fork_info::clobber_regs): Delete.
3548         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3549         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3550         comment.  Adjust.
3551         (scoped_switch_fork_info::scoped_switch_fork_info)
3552         (checkpoint_command, linux_fork_context): Adjust
3553         fork_save_infrun_state calls.
3554
3555 2019-03-06  Pedro Alves  <palves@redhat.com>
3556
3557         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3558         (inf_has_multiple_threads): Return 'bool' and rewrite using
3559         inferior_info::threads().
3560
3561 2019-03-06  Pedro Alves  <palves@redhat.com>
3562
3563         * linux-fork.c: Include <list>.
3564         (fork_list): Now a std::list instance.
3565         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3566         (forks_exist_p, find_last_fork): Adjust.
3567         (new_fork): Delete.
3568         (one_fork_p): New.
3569         (add_fork): Adjust.
3570         (free_fork): Delete, folded into fork_info::~fork_info().
3571         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3572         Adjust.
3573         (init_fork_list): Delete.
3574         (linux_fork_killall, linux_fork_mourn_inferior)
3575         (linux_fork_detach, info_checkpoints_command): Adjust.
3576         (_initialize_linux_fork): No longer call init_fork_list.
3577
3578 2019-03-06  Pedro Alves  <palves@redhat.com>
3579
3580         * linux-fork.c (new_fork): New, split out of ...
3581         (add_fork): ... this.  Return void.  Move "first fork" special
3582         case from here, to ...
3583         (checkpoint_command): ... here.
3584         * linux-linux.h (add_fork): Return void.
3585
3586 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3587
3588         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3589
3590 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3591             Chris January  <chris.january@arm.com>
3592             David Lecomber  <david.lecomber@arm.com>
3593
3594         * f-exp.y: New token, UNOP_INTRINSIC.
3595         (exp): New pattern using UNOP_INTRINSIC token.
3596         (f77_keywords): Add 'abs' keyword.
3597         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3598         (value_from_host_double): New function.
3599         (evaluate_subexp_f): Support UNOP_ABS.
3600
3601 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3602
3603         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3604         types.
3605
3606 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3607
3608         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3609         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3610         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3611
3612 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3613
3614         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3615
3616 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3617             Chris January  <chris.january@arm.com>
3618
3619         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3620         * f-exp.y: Define 'KIND' token.
3621         (exp): New pattern for KIND expressions.
3622         (ptype): Handle types with a kind extension.
3623         (direct_abs_decl): Extend to spot kind extensions.
3624         (f77_keywords): Add 'kind' to the list.
3625         (push_kind_type): New function.
3626         (convert_to_kind_type): New function.
3627         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3628         * parse.c (operator_length_standard): Likewise.
3629         * parser-defs.h (enum type_pieces): Add tp_kind.
3630         * std-operator.def: Add UNOP_KIND.
3631
3632 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3633
3634         * f-exp.y (f_parse): Set yydebug.
3635
3636 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3637
3638         * f-lang.c (evaluate_subexp_f): New function.
3639         (exp_descriptor_f): New global.
3640         (f_language_defn): Use exp_descriptor_f instead of
3641         exp_descriptor_standard.
3642
3643 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3644
3645         * f-exp.y (struct token): Add comments.
3646         (dot_ops): Remove uppercase versions and the end marker.
3647         (f77_keywords): Likewise.
3648         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3649         entries in the dot_ops array are case insensitive, and use
3650         strncasecmp to compare strings.  Also some whitespace cleanup in
3651         this area.  Similar for the f77_keywords array, except entries in
3652         this list might be case sensitive.
3653
3654 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3655
3656         * f-exp.y (struct f77_boolean_val): Add comments.
3657         (boolean_values): Remove uppercase versions, and end marker.
3658         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3659         and use strncasecmp to achieve case insensitivity.  Additionally,
3660         perform whitespace cleanup around this code.
3661
3662 2019-03-06  Tom Tromey  <tromey@adacore.com>
3663
3664         * remote-sim.c (gdbsim_target_open): Use result of
3665         gdb_argv::release.
3666
3667 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3668         Dirk Schubert  <dirk.schubert@arm.com>
3669         Chris January  <chris.january@arm.com>
3670
3671         * eval.c (evaluate_subexp_standard): Call Fortran argument
3672         wrapping logic.
3673         * f-lang.c (struct value): A value which can be passed into a
3674         Fortran function call.
3675         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3676         where appropriate.
3677         (struct type): Value ready for a Fortran function call.
3678         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3679         is needed.
3680         * f-lang.h (fortran_argument_convert): Declaration.
3681         (fortran_preserve_arg_pointer): Declaration.
3682         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3683
3684 2019-03-05  Tom Tromey  <tromey@adacore.com>
3685
3686         * python/py-prettyprint.c (print_string_repr): Remove #if.
3687         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3688
3689 2019-03-05  Tom Tromey  <tromey@adacore.com>
3690
3691         * target.c (the_dummy_target): Move later.  Change type to
3692         "dummy_target".
3693         (initialize_targets): Don't initialize the_dummy_target.
3694
3695 2019-03-05  Tom Tromey  <tromey@adacore.com>
3696
3697         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3698         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3699
3700 2019-03-05  Tom Tromey  <tromey@adacore.com>
3701
3702         * windows-nat.c (windows_nat_target::attach)
3703         (windows_nat_target::detach): Don't call gdb_flush.
3704         * valprint.c (generic_val_print, val_print, val_print_string):
3705         Don't call gdb_flush.
3706         * utils.c (defaulted_query): Don't call gdb_flush.
3707         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3708         * target.c (target_announce_detach): Don't call gdb_flush.
3709         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3710         * remote.c (extended_remote_target::attach): Don't call
3711         gdb_flush.
3712         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3713         * printcmd.c (do_examine): Don't call gdb_flush.
3714         (info_display_command): Don't call gdb_flush.
3715         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3716         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3717         * memattr.c (info_mem_command): Don't call gdb_flush.
3718         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3719         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3720         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3721         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3722         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3723         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3724         (gnu_nat_target::detach): Don't call gdb_flush.
3725         * f-valprint.c (f_val_print): Don't call gdb_flush.
3726         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3727         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3728         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3729         gdb_flush.
3730         * c-valprint.c (c_val_print): Don't call gdb_flush.
3731         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3732
3733 2019-03-05  Tom Tromey  <tromey@adacore.com>
3734
3735         * varobj.c (update_dynamic_varobj_children): Update.
3736         (install_default_visualizer): Use reset, not release.
3737         * value.c (set_internalvar): Update.
3738         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3739         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3740         ATTRIBUTE_UNUSED_RESULT.
3741
3742 2019-03-05  Tom Tromey  <tromey@adacore.com>
3743
3744         * remote.c (class scoped_remote_fd) <release>: Add
3745         ATTRIBUTE_UNUSED_RESULT.
3746
3747 2019-03-05  Tom Tromey  <tromey@adacore.com>
3748
3749         * macroexp.c (struct macro_buffer) <release>: Add
3750         ATTRIBUTE_UNUSED_RESULT.
3751
3752 2019-03-05  Tom Tromey  <tromey@adacore.com>
3753
3754         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3755         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3756         ATTRIBUTE_UNUSED_RESULT.
3757
3758 2019-03-05  Tom Tromey  <tromey@adacore.com>
3759
3760         * common/scoped_fd.h (class scoped_fd) <release>: Add
3761         ATTRIBUTE_UNUSED_RESULT.
3762
3763 2019-03-05  Tom Tromey  <tromey@adacore.com>
3764
3765         * parser-defs.h (struct parser_state) <release>: Add
3766         ATTRIBUTE_UNUSED_RESULT.
3767
3768 2019-03-05  Tom Tromey  <tromey@adacore.com>
3769
3770         * utils.h (class gdb_argv) <release>: Add
3771         ATTRIBUTE_UNUSED_RESULT.
3772         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3773
3774 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3775
3776         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3777         for-loop range, to avoid compiler warnings.
3778
3779         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3780         avoid compiler warnings about unused variables.
3781
3782         * NEWS: Mention end of support for native debugging on MS-Windows
3783         before XP.
3784
3785         PR gdb/24292
3786         * common/netstuff.c:
3787         * gdbserver/gdbreplay.c
3788         * gdbserver/remote-utils.c:
3789         * ser-tcp.c:
3790         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3791         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3792         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3793         'getaddrinfo' and 'freeaddrinfo' were not available before
3794         Windows XP, and mingw.org's MinGW headers by default define
3795         _WIN32_WINNT to 0x500.
3796
3797 2019-03-01  Gary Benson <gbenson@redhat.com>
3798
3799         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3800
3801 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3802             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3803
3804         PR gdb/8527
3805         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3806         set_sigint_trap, clear_sigint_trap.
3807
3808 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3809
3810         * target.c (target_detach): Clear the regcache and the
3811         frame cache.
3812
3813 2019-02-27  Pedro Alves  <palves@redhat.com>
3814
3815         * utils.c (set_screen_size): When we cap the height/width sizes,
3816         tweak the corresponding command variable to show "unlimited":
3817
3818 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3819             Pedro Alves  <palves@redhat.com>
3820
3821         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3822         before calling rl_set_screen_size.
3823
3824 2019-02-27  Tom Tromey  <tromey@adacore.com>
3825
3826         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3827         define.
3828         * python/py-value.c: Remove Python 2.4 workaround.
3829         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3830         workaround.
3831         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3832         Python 2.4 workaround.
3833         * python/python-internal.h: Remove Python 2.4 comment.
3834         (Py_ssize_t): Don't define.
3835         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3836         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3837         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3838         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3839         * python/python.c (do_start_initialization): Remove Python 2.4
3840         workaround.
3841         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3842         (print_children): Remove Python 2.4 workaround.
3843         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3844         workaround.
3845         (CHARBUFFERPROC_NAME): Remove.
3846         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3847         Python 2.4 workaround.
3848
3849 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3850
3851         * NEWS: Note minimum Python version.
3852
3853 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3854
3855         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3856         code from these functions.  Remove corresponding ifdefs.  Use
3857         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3858         Remove gotos and target of gotos.
3859         (infpy_search_memory): Likewise.
3860
3861 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3862
3863         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3864         (hppa_gdbarch_init): Don't register deleted functions with
3865         gdbarch.
3866
3867 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3868
3869         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3870         (h8300_unwind_sp): Delete.
3871         (h8300_dummy_id): Delete.
3872         (h8300_gdbarch_init): Don't register deleted functions with
3873         gdbarch.
3874
3875 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3876
3877         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3878         (ft32_unwind_pc): Delete.
3879         (ft32_unwind_sp): Delete.
3880         (ft32_gdbarch_init): Don't register deleted functions with
3881         gdbarch.
3882
3883 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3884
3885         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3886         (frv_unwind_pc): Delete.
3887         (frv_unwind_sp): Delete.
3888         (frv_gdbarch_init): Don't register deleted functions with
3889         gdbarch.
3890
3891 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3892
3893         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3894         (riscv_unwind_pc): Delete.
3895         (riscv_unwind_sp): Delete.
3896         (riscv_gdbarch_init): Don't register deleted functions with
3897         gdbarch.
3898
3899 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3900
3901         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3902         (csky_unwind_pc): Delete.
3903         (csky_unwind_sp): Delete.
3904         (csky_gdbarch_init): Don't register deleted functions with
3905         gdbarch.
3906
3907 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3908
3909         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3910         (cris_unwind_pc): Delete.
3911         (cris_unwind_sp): Delete.
3912         (cris_gdbarch_init): Don't register deleted functions with
3913         gdbarch.
3914
3915 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3916
3917         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3918         (bfin_unwind_pc): Delete.
3919         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3920
3921 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3922
3923         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3924         (arm_unwind_pc): Delete.
3925         (arm_unwind_sp): Delete.
3926         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3927
3928 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3929
3930         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3931         (arc_unwind_pc): Delete.
3932         (arc_unwind_sp): Delete.
3933         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3934
3935 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3936
3937         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3938         (alpha_unwind_pc): Delete.
3939         (alpha_gdbarch_init): Don't register deleted functions with
3940         gdbarch.
3941
3942 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3943
3944         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3945         (aarch64_unwind_pc): Delete.
3946         (aarch64_unwind_sp): Delete.
3947         (aarch64_gdbarch_init): Don't register deleted functions with
3948         gdbarch.
3949
3950 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3951
3952         * gdbtypes.c (type_align): Don't consider static members when
3953         computing structure alignment.
3954
3955 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3956
3957         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3958         return 0 for other types.
3959         * arch-utils.c (default_type_align): Always return 0.
3960         * gdbarch.h: Regenerate.
3961         * gdbarch.sh (type_align): Extend comment.
3962         * gdbtypes.c (type_align): Add additional comments, always call
3963         gdbarch_type_align before applying the default rules.
3964         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3965         generic code will then apply a suitable default.
3966         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3967         types, return 0 for other types.
3968
3969 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3970
3971         * NEWS: Create a new section for the next release branch.
3972         Rename the section of the current branch, now that it has
3973         been cut.
3974
3975 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3976
3977         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3978         * version.in: Bump version to 8.3.50.DATE-git.
3979
3980 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3981
3982         * aix-thread.c (ptid_cmp): Remove unused variable.
3983         (get_signaled_thread): Likewise.
3984         (store_regs_user_thread): Likewise.
3985         (store_regs_kernel_thread): Likewise.
3986         (fetch_regs_kernel_thread): Remove shadowed variable.
3987
3988 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3989
3990         * features/riscv/32bit-cpu.xml: Add register numbers.
3991         * features/riscv/32bit-fpu.c: Regenerate.
3992         * features/riscv/32bit-fpu.xml: Add register numbers.
3993         * features/riscv/64bit-cpu.xml: Add register numbers.
3994         * features/riscv/64bit-fpu.c: Regenerate.
3995         * features/riscv/64bit-fpu.xml: Add register numbers.
3996
3997 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3998
3999         * NEWS: Mention two argument form of gdb.Value constructor.
4000         * python/py-value.c (convert_buffer_and_type_to_value): New
4001         function.
4002         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4003         Add support for handling an optional second argument.  Call
4004         convert_buffer_and_type_to_value as appropriate.
4005         * python/python-internal.h (Py_buffer_deleter): New struct.
4006         (Py_buffer_up): New typedef.
4007
4008 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4009
4010         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4011         instead of releasing ownership.
4012
4013 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4014
4015         * dwarf2read.c (open_and_init_dwp_file): Call
4016         elf_numsections instead of bfd_count_sections to initialize
4017         dwp_file->num_sections.
4018
4019 2019-02-25  Tom Tromey  <tromey@adacore.com>
4020
4021         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4022
4023 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4024
4025         * gcore.in: Add '--readnever' option when invoking GDB.
4026
4027 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4028
4029         * MAINTAINERS: Update my email address.
4030
4031 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4032
4033         * build-id.c (build_id_to_debug_bfd_1): New function.
4034         (build_id_to_debug_bfd): Look for separate debug file in
4035         sysroot.
4036
4037 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4038
4039         * gdbarch.sh: Update the copyright year range that is placed into
4040         generated files.
4041
4042 2019-02-22  Keith Seitz  <keiths@redhat.com>
4043
4044         PR symtab/23853
4045         * linespec.c (create_sals_line_offset): Search for the default
4046         symtab's filename instead of its fullname.
4047
4048 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4049
4050         * NEWS: Update style defaults.
4051
4052 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4053
4054         * main.c (captured_main_1): Disable styling in batch mode.
4055
4056 2019-02-20  Tom Tromey  <tom@tromey.com>
4057
4058         * symtab.c (symtab_symbol_info): Fix typos.
4059
4060 2019-02-20  Tom Tromey  <tromey@adacore.com>
4061
4062         * findcmd.c (_initialize_mem_search): Use upper case for
4063         metasyntactic variables.
4064
4065 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4066
4067         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4068         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4069
4070 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4071
4072         * top.h (source_file_name): Change to std::string.
4073         * top.c (source_file_name): Likewise.
4074         (command_line_input): Adjust.
4075         * cli/cli-script.c (script_from_file): Adjust.
4076
4077 2019-02-19  Tom Tromey  <tromey@adacore.com>
4078
4079         * ravenscar-thread.c
4080         (ravenscar_thread_target::update_thread_list): Don't call
4081         ada_build_task_list.
4082         * ada-lang.h (ada_build_task_list): Don't declare.
4083         * ada-tasks.c (struct ada_tasks_inferior_data)
4084         <task_list_valid_p>: Now bool.
4085         (read_known_tasks, ada_task_list_changed)
4086         (ada_tasks_invalidate_inferior_data): Update.
4087         (read_known_tasks_array): Return bool.
4088         (read_known_tasks_list): Likewise.
4089         (read_known_tasks): Return void.
4090         (ada_build_task_list): Now static.
4091
4092 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4093
4094         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4095         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4096
4097 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4098
4099         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4100         variant for ada_tasks_pspace_data_handle and
4101         ada_tasks_inferior_data_handle.
4102         (ada_tasks_pspace_data_cleanup): New function.
4103         (ada_tasks_inferior_data_cleanup): New function.
4104
4105 2019-02-17  Tom Tromey  <tom@tromey.com>
4106
4107         * macrotab.h (macro_source_fullname): Return a std::string.
4108         * macrotab.c (macro_include, check_for_redefinition)
4109         (macro_undef, macro_lookup_definition, foreach_macro)
4110         (foreach_macro_in_scope): Update.
4111         (macro_source_fullname): Return a std::string.
4112         * macrocmd.c (show_pp_source_pos): Update.
4113
4114 2019-02-17  Tom Tromey  <tom@tromey.com>
4115
4116         * macrocmd.c (show_pp_source_pos): Style the file names.
4117
4118 2019-02-17  Tom Tromey  <tom@tromey.com>
4119
4120         PR tui/24197:
4121         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4122
4123 2019-02-17  Tom Tromey  <tom@tromey.com>
4124
4125         * ada-lang.c (user_select_syms): Use filtered printing.
4126         * utils.c (wrap_style): New global.
4127         (desired_style): Remove.
4128         (emit_style_escape): Add stream parameter.
4129         (set_output_style, reset_terminal_style, prompt_for_continue):
4130         Update.
4131         (flush_wrap_buffer): Only flush gdb_stdout.
4132         (wrap_here): Set wrap_style.
4133         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4134         treat escape sequences as a character.  Change when wrap buffer is
4135         flushed.
4136         (fputs_styled): Do not set the output style when the default is
4137         requested.
4138         * ui-style.h (struct ui_file_style) <is_default>: New method.
4139         * source.c (print_source_lines_base): Emit escape sequences in one
4140         piece.
4141
4142 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4143
4144         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4145         integers and enumeration types.
4146
4147 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4148
4149         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4150         instead of lookup_symbol_in_language
4151         (do_exact_match): New function.
4152         (ada_get_symbol_name_matcher): Return do_exact_match when
4153         doing a verbatim match.
4154
4155 2019-02-15  Tom Tromey  <tromey@adacore.com>
4156
4157         * ravenscar-thread.c (ravenscar_thread_target::resume)
4158         (ravenscar_thread_target::wait): Special case wildcard requests.
4159
4160 2019-02-15  Tom Tromey  <tromey@adacore.com>
4161
4162         * ravenscar-thread.c (base_ptid): Remove.
4163         (struct ravenscar_thread_target) <close>: New method.
4164         <m_base_ptid>: New member.
4165         <update_inferior_ptid, active_task, task_is_currently_active,
4166         runtime_initialized>: Declare methods.
4167         <ravenscar_thread_target>: Add constructor.
4168         (ravenscar_thread_target::task_is_currently_active)
4169         (ravenscar_thread_target::update_inferior_ptid)
4170         (ravenscar_runtime_initialized): Rename.  Now methods.
4171         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4172         (ravenscar_thread_target::update_thread_list): Update.
4173         (ravenscar_thread_target::active_task): Now method.
4174         (ravenscar_thread_target::store_registers)
4175         (ravenscar_thread_target::prepare_to_store)
4176         (ravenscar_thread_target::prepare_to_store)
4177         (ravenscar_thread_target::mourn_inferior): Update.
4178         (ravenscar_inferior_created): Use "new" to create target.
4179         (ravenscar_thread_target::get_ada_task_ptid): Update.
4180         (_initialize_ravenscar): Don't initialize base_ptid.
4181         (ravenscar_ops): Remove global.
4182
4183 2019-02-15  Tom Tromey  <tromey@adacore.com>
4184
4185         * target.h (push_target): Declare new overload.
4186         * target.c (push_target): New overload, taking an rvalue reference.
4187         * remote.c (remote_target::open_1): Use push_target overload.
4188         * corelow.c (core_target_open): Use push_target overload.
4189
4190 2019-02-15  Tom Tromey  <tromey@adacore.com>
4191
4192         * ravenscar-thread.c (is_ravenscar_task)
4193         (ravenscar_task_is_currently_active): Return bool.
4194         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4195         (_initialize_ravenscar): Remove "(void)".
4196         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4197         Return bool.
4198
4199 2019-02-15  Tom Tromey  <tromey@adacore.com>
4200
4201         * ravenscar-thread.c (ravenscar_runtime_initializer)
4202         (has_ravenscar_runtime, get_running_thread_id)
4203         (ravenscar_thread_target::resume): Fix indentation.
4204
4205 2019-02-15  Tom Tromey  <tromey@adacore.com>
4206
4207         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4208         from ravenscar_arch_ops.
4209         (sparc_ravenscar_ops::fetch_registers)
4210         (sparc_ravenscar_ops::store_registers): Now methods.
4211         (sparc_ravenscar_prepare_to_store): Remove.
4212         (sparc_ravenscar_ops): Redefine.
4213         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4214         methods and destructor.  Remove members.
4215         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4216         (ravenscar_thread_target::store_registers)
4217         (ravenscar_thread_target::prepare_to_store): Update.
4218         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4219         Remove.
4220         (struct ppc_ravenscar_powerpc_ops): Derive from
4221         ravenscar_arch_ops.
4222         (ppc_ravenscar_powerpc_ops::fetch_registers)
4223         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4224         (ppc_ravenscar_powerpc_ops): Redefine.
4225         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4226         (ppc_ravenscar_e500_ops::fetch_registers)
4227         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4228         (ppc_ravenscar_e500_ops): Redefine.
4229         * aarch64-ravenscar-thread.c
4230         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4231         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4232         (aarch64_ravenscar_fetch_registers)
4233         (aarch64_ravenscar_store_registers): Now methods.
4234         (aarch64_ravenscar_ops): Redefine.
4235
4236 2019-02-15  Tom Tromey  <tromey@adacore.com>
4237
4238         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4239         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4240         (ravenscar_thread_target::stopped_by_watchpoint)
4241         (ravenscar_thread_target::stopped_data_address)
4242         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4243
4244 2019-02-15  Tom Tromey  <tromey@adacore.com>
4245
4246         * ravenscar-thread.c: Fix some typos.
4247
4248 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4249             Tom Tromey  <tromey@adacore.com>
4250
4251         * ada-lang.c (ada_exception_sal): Change addr_string to a
4252         std::string.
4253         (create_ada_exception_catchpoint): Update.
4254
4255 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4256             Tom Tromey  <tromey@adacore.com>
4257
4258         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4259         (bp_location_ops): Remove.
4260         (base_breakpoint_allocate_location): Update.
4261         (free_bp_location): Update.
4262         * ada-lang.c (class ada_catchpoint_location)
4263         <ada_catchpoint_location>: Remove ops parameter.
4264         (ada_catchpoint_location_dtor): Remove.
4265         (ada_catchpoint_location_ops): Remove.
4266         (allocate_location_exception): Update.
4267         * breakpoint.h (struct bp_location_ops): Remove.
4268         (class bp_location) <bp_location>: Remove bp_location_ops
4269         parameter.
4270         <~bp_location>: Add destructor.
4271         <ops>: Remove.
4272
4273 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4274             Pedro Alves  <palves@redhat.com>
4275
4276         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4277         'PATH_MAX'.
4278
4279 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4280             Samuel Thibault  <samuel.thibault@gnu.org>
4281             Thomas Schwinge  <thomas@codesourcery.com>
4282
4283         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4284         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4285
4286 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4287
4288         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4289         (check_empty): Use "const char *".
4290
4291         * gnu-nat.c (gnu_nat_target::detach): Instead of
4292         'detach_inferior (pid)' call
4293         'detach_inferior (find_inferior_pid (pid))'.
4294
4295         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4296         'nat/fork-inferior.o'.
4297         * gnu-nat.c: #include "nat/fork-inferior.h".
4298
4299         * gnu-nat.c (gnu_nat_target::detach): Instead of
4300         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4301         * gnu-nat.h: #include "inf-child.h".
4302         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4303         'i386_gnu_nat_target::fetch_registers'.
4304         (gnu_store_registers): Rename/move to
4305         'i386_gnu_nat_target::store_registers'.
4306
4307         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4308         * gnu-nat.h (mach_thread_info): New function.
4309         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4310
4311         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4312
4313 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4314
4315         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4316
4317 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4318
4319         * windows-nat.c (windows_add_thread): Add new parameter
4320         "main_thread_p" with default value set to false.  Update
4321         function documentation as well as all callers.
4322         (windows_delete_thread): Likewise.
4323         (fake_create_process): Update call to windows_add_thread.
4324         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4325         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4326         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4327         call to windows_delete_thread.
4328
4329 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4330
4331         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4332
4333 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4334
4335         * symfile.c (find_separate_debug_file): Use canonical path of
4336         sysroot with child_path instead of gdb_sysroot if it is valid.
4337
4338 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4339
4340         * symfile.c (find_separate_debug_file): Use child_path to
4341         determine if an object file is under a sysroot.
4342
4343 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4344
4345         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4346         unittests/child-path-selftests.c.
4347         * common/pathstuff.c (child_path): New function.
4348         * common/pathstuff.h (child_path): New prototype.
4349         * unittests/child-path-selftests.c: New file.
4350
4351 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4352
4353         * symfile.c (find_separate_debug_file): Look for separate debug
4354         files in debug directories under the sysroot.
4355
4356 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4357
4358         * symtab.h (struct minimal_symbol data_p): New const method.
4359         (struct minimal_symbol text_p): Likewise.
4360         * symtab.c (output_source_filename): Use file name style
4361         to print file name.
4362         (print_symbol_info): Likewise.
4363         (print_msymbol_info): Use address style to print addresses.
4364         Use function name style to print executable text symbols.
4365         (expand_symtab_containing_pc): Use data_p.
4366         (find_pc_sect_compunit_symtab): Likewise.
4367
4368 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4369
4370         * breakpoint.c (describe_other_breakpoints): Use address style
4371         to print addresses.
4372         (say_where): Likewise.
4373
4374 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4375
4376         * ada-typeprint.c (print_func_type): Print function name
4377         style to print function name.
4378         * c-typeprint.c (c_print_type_1): Likewise.
4379
4380 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4381
4382         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4383         for execve.
4384
4385 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4386
4387         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4388         type_stack.
4389
4390 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4391
4392         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4393         TYPE_CODE_REF types.
4394
4395 2019-02-08  Jim Wilson  <jimw@sifive.com>
4396
4397         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4398         (riscv_linux_fregset): New.
4399         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4400
4401 2019-02-07  Tom Tromey  <tom@tromey.com>
4402
4403         * thread.c (thread_cancel_execution_command): Update.
4404         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4405         methods.
4406         (struct thread_fsm_ops): Remove.
4407         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4408         (thread_fsm_should_stop, thread_fsm_return_value)
4409         (thread_fsm_set_finished, thread_fsm_finished_p)
4410         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4411         Don't declare.
4412         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4413         * infrun.c (clear_proceed_status_thread)
4414         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4415         (print_stop_event): Update.
4416         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4417         Add constructor.
4418         (step_command_fsm_ops): Remove.
4419         (new_step_command_fsm): Remove.
4420         (step_1): Update.
4421         (step_command_fsm::should_stop): Rename from
4422         step_command_fsm_should_stop.
4423         (step_command_fsm::clean_up): Rename from
4424         step_command_fsm_clean_up.
4425         (step_command_fsm::do_async_reply_reason): Rename from
4426         step_command_fsm_async_reply_reason.
4427         (struct until_next_fsm): Inherit from thread_fsm.  Add
4428         constructor.
4429         (until_next_fsm_ops): Remove.
4430         (new_until_next_fsm): Remove.
4431         (until_next_fsm::should_stop): Rename from
4432         until_next_fsm_should_stop.
4433         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4434         (until_next_fsm::do_async_reply_reason): Rename from
4435         until_next_fsm_async_reply_reason.
4436         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4437         constructor.  Change type of breakpoint.
4438         (finish_command_fsm_ops): Remove.
4439         (new_finish_command_fsm): Remove.
4440         (finish_command_fsm::should_stop): Rename from
4441         finish_command_fsm_should_stop.
4442         (finish_command_fsm::clean_up): Rename from
4443         finish_command_fsm_clean_up.
4444         (finish_command_fsm::return_value): Rename from
4445         finish_command_fsm_return_value.
4446         (finish_command_fsm::do_async_reply_reason): Rename from
4447         finish_command_fsm_async_reply_reason.
4448         (finish_command): Update.
4449         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4450         Add constructor.
4451         (call_thread_fsm_ops): Remove.
4452         (call_thread_fsm::call_thread_fsm): Rename from
4453         new_call_thread_fsm.
4454         (call_thread_fsm::should_stop): Rename from
4455         call_thread_fsm_should_stop.
4456         (call_thread_fsm::should_notify_stop): Rename from
4457         call_thread_fsm_should_notify_stop.
4458         (run_inferior_call, call_function_by_hand_dummy): Update.
4459         * cli/cli-interp.c (should_print_stop_to_console): Update.
4460         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4461         Add constructor.  Change type of location_breakpoint,
4462         caller_breakpoint.
4463         (until_break_fsm_ops): Remove.
4464         (new_until_break_fsm): Remove.
4465         (until_break_fsm::should_stop): Rename from
4466         until_break_fsm_should_stop.
4467         (until_break_fsm::clean_up): Rename from
4468         until_break_fsm_clean_up.
4469         (until_break_fsm::do_async_reply_reason): Rename from
4470         until_break_fsm_async_reply_reason.
4471         (until_break_command): Update.
4472         * thread-fsm.c: Remove.
4473         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4474
4475 2019-02-07  Tom Tromey  <tom@tromey.com>
4476
4477         * yy-remap.h: Add include guard.
4478         * xtensa-tdep.h: Add include guard.
4479         * xcoffread.h: Rename include guard.
4480         * varobj-iter.h: Add include guard.
4481         * tui/tui.h: Rename include guard.
4482         * tui/tui-winsource.h: Rename include guard.
4483         * tui/tui-wingeneral.h: Rename include guard.
4484         * tui/tui-windata.h: Rename include guard.
4485         * tui/tui-win.h: Rename include guard.
4486         * tui/tui-stack.h: Rename include guard.
4487         * tui/tui-source.h: Rename include guard.
4488         * tui/tui-regs.h: Rename include guard.
4489         * tui/tui-out.h: Rename include guard.
4490         * tui/tui-layout.h: Rename include guard.
4491         * tui/tui-io.h: Rename include guard.
4492         * tui/tui-hooks.h: Rename include guard.
4493         * tui/tui-file.h: Rename include guard.
4494         * tui/tui-disasm.h: Rename include guard.
4495         * tui/tui-data.h: Rename include guard.
4496         * tui/tui-command.h: Rename include guard.
4497         * tic6x-tdep.h: Add include guard.
4498         * target/waitstatus.h: Rename include guard.
4499         * target/wait.h: Rename include guard.
4500         * target/target.h: Rename include guard.
4501         * target/resume.h: Rename include guard.
4502         * target-float.h: Rename include guard.
4503         * stabsread.h: Add include guard.
4504         * rs6000-tdep.h: Add include guard.
4505         * riscv-fbsd-tdep.h: Add include guard.
4506         * regformats/regdef.h: Rename include guard.
4507         * record.h: Rename include guard.
4508         * python/python.h: Rename include guard.
4509         * python/python-internal.h: Rename include guard.
4510         * python/py-stopevent.h: Rename include guard.
4511         * python/py-ref.h: Rename include guard.
4512         * python/py-record.h: Rename include guard.
4513         * python/py-record-full.h: Rename include guard.
4514         * python/py-record-btrace.h: Rename include guard.
4515         * python/py-instruction.h: Rename include guard.
4516         * python/py-events.h: Rename include guard.
4517         * python/py-event.h: Rename include guard.
4518         * procfs.h: Add include guard.
4519         * proc-utils.h: Add include guard.
4520         * p-lang.h: Add include guard.
4521         * or1k-tdep.h: Rename include guard.
4522         * observable.h: Rename include guard.
4523         * nto-tdep.h: Rename include guard.
4524         * nat/x86-linux.h: Rename include guard.
4525         * nat/x86-linux-dregs.h: Rename include guard.
4526         * nat/x86-gcc-cpuid.h: Add include guard.
4527         * nat/x86-dregs.h: Rename include guard.
4528         * nat/x86-cpuid.h: Rename include guard.
4529         * nat/ppc-linux.h: Rename include guard.
4530         * nat/mips-linux-watch.h: Rename include guard.
4531         * nat/linux-waitpid.h: Rename include guard.
4532         * nat/linux-ptrace.h: Rename include guard.
4533         * nat/linux-procfs.h: Rename include guard.
4534         * nat/linux-osdata.h: Rename include guard.
4535         * nat/linux-nat.h: Rename include guard.
4536         * nat/linux-namespaces.h: Rename include guard.
4537         * nat/linux-btrace.h: Rename include guard.
4538         * nat/glibc_thread_db.h: Rename include guard.
4539         * nat/gdb_thread_db.h: Rename include guard.
4540         * nat/gdb_ptrace.h: Rename include guard.
4541         * nat/fork-inferior.h: Rename include guard.
4542         * nat/amd64-linux-siginfo.h: Rename include guard.
4543         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4544         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4545         * nat/aarch64-linux.h: Rename include guard.
4546         * nat/aarch64-linux-hw-point.h: Rename include guard.
4547         * mn10300-tdep.h: Add include guard.
4548         * mips-linux-tdep.h: Add include guard.
4549         * mi/mi-parse.h: Rename include guard.
4550         * mi/mi-out.h: Rename include guard.
4551         * mi/mi-main.h: Rename include guard.
4552         * mi/mi-interp.h: Rename include guard.
4553         * mi/mi-getopt.h: Rename include guard.
4554         * mi/mi-console.h: Rename include guard.
4555         * mi/mi-common.h: Rename include guard.
4556         * mi/mi-cmds.h: Rename include guard.
4557         * mi/mi-cmd-break.h: Rename include guard.
4558         * m2-lang.h: Add include guard.
4559         * location.h: Rename include guard.
4560         * linux-record.h: Rename include guard.
4561         * linux-nat.h: Add include guard.
4562         * linux-fork.h: Add include guard.
4563         * i386-darwin-tdep.h: Rename include guard.
4564         * hppa-linux-offsets.h: Add include guard.
4565         * guile/guile.h: Rename include guard.
4566         * guile/guile-internal.h: Rename include guard.
4567         * gnu-nat.h: Rename include guard.
4568         * gdb-stabs.h: Rename include guard.
4569         * frv-tdep.h: Add include guard.
4570         * f-lang.h: Add include guard.
4571         * event-loop.h: Add include guard.
4572         * darwin-nat.h: Rename include guard.
4573         * cp-abi.h: Rename include guard.
4574         * config/sparc/nm-sol2.h: Rename include guard.
4575         * config/nm-nto.h: Rename include guard.
4576         * config/nm-linux.h: Add include guard.
4577         * config/i386/nm-i386gnu.h: Rename include guard.
4578         * config/djgpp/nl_types.h: Rename include guard.
4579         * config/djgpp/langinfo.h: Rename include guard.
4580         * compile/gcc-cp-plugin.h: Add include guard.
4581         * compile/gcc-c-plugin.h: Add include guard.
4582         * compile/compile.h: Rename include guard.
4583         * compile/compile-object-run.h: Rename include guard.
4584         * compile/compile-object-load.h: Rename include guard.
4585         * compile/compile-internal.h: Rename include guard.
4586         * compile/compile-cplus.h: Rename include guard.
4587         * compile/compile-c.h: Rename include guard.
4588         * common/xml-utils.h: Rename include guard.
4589         * common/x86-xstate.h: Rename include guard.
4590         * common/version.h: Rename include guard.
4591         * common/vec.h: Rename include guard.
4592         * common/tdesc.h: Rename include guard.
4593         * common/selftest.h: Rename include guard.
4594         * common/scoped_restore.h: Rename include guard.
4595         * common/scoped_mmap.h: Rename include guard.
4596         * common/scoped_fd.h: Rename include guard.
4597         * common/safe-iterator.h: Rename include guard.
4598         * common/run-time-clock.h: Rename include guard.
4599         * common/refcounted-object.h: Rename include guard.
4600         * common/queue.h: Rename include guard.
4601         * common/ptid.h: Rename include guard.
4602         * common/print-utils.h: Rename include guard.
4603         * common/preprocessor.h: Rename include guard.
4604         * common/pathstuff.h: Rename include guard.
4605         * common/observable.h: Rename include guard.
4606         * common/netstuff.h: Rename include guard.
4607         * common/job-control.h: Rename include guard.
4608         * common/host-defs.h: Rename include guard.
4609         * common/gdb_wait.h: Rename include guard.
4610         * common/gdb_vecs.h: Rename include guard.
4611         * common/gdb_unlinker.h: Rename include guard.
4612         * common/gdb_unique_ptr.h: Rename include guard.
4613         * common/gdb_tilde_expand.h: Rename include guard.
4614         * common/gdb_sys_time.h: Rename include guard.
4615         * common/gdb_string_view.h: Rename include guard.
4616         * common/gdb_splay_tree.h: Rename include guard.
4617         * common/gdb_setjmp.h: Rename include guard.
4618         * common/gdb_ref_ptr.h: Rename include guard.
4619         * common/gdb_optional.h: Rename include guard.
4620         * common/gdb_locale.h: Rename include guard.
4621         * common/gdb_assert.h: Rename include guard.
4622         * common/filtered-iterator.h: Rename include guard.
4623         * common/filestuff.h: Rename include guard.
4624         * common/fileio.h: Rename include guard.
4625         * common/environ.h: Rename include guard.
4626         * common/common-utils.h: Rename include guard.
4627         * common/common-types.h: Rename include guard.
4628         * common/common-regcache.h: Rename include guard.
4629         * common/common-inferior.h: Rename include guard.
4630         * common/common-gdbthread.h: Rename include guard.
4631         * common/common-exceptions.h: Rename include guard.
4632         * common/common-defs.h: Rename include guard.
4633         * common/common-debug.h: Rename include guard.
4634         * common/cleanups.h: Rename include guard.
4635         * common/buffer.h: Rename include guard.
4636         * common/btrace-common.h: Rename include guard.
4637         * common/break-common.h: Rename include guard.
4638         * cli/cli-utils.h: Rename include guard.
4639         * cli/cli-style.h: Rename include guard.
4640         * cli/cli-setshow.h: Rename include guard.
4641         * cli/cli-script.h: Rename include guard.
4642         * cli/cli-interp.h: Rename include guard.
4643         * cli/cli-decode.h: Rename include guard.
4644         * cli/cli-cmds.h: Rename include guard.
4645         * charset-list.h: Add include guard.
4646         * buildsym-legacy.h: Rename include guard.
4647         * bfin-tdep.h: Add include guard.
4648         * ax.h: Rename include guard.
4649         * arm-linux-tdep.h: Add include guard.
4650         * arm-fbsd-tdep.h: Add include guard.
4651         * arch/xtensa.h: Rename include guard.
4652         * arch/tic6x.h: Add include guard.
4653         * arch/i386.h: Add include guard.
4654         * arch/arm.h: Rename include guard.
4655         * arch/arm-linux.h: Rename include guard.
4656         * arch/arm-get-next-pcs.h: Rename include guard.
4657         * arch/amd64.h: Add include guard.
4658         * arch/aarch64-insn.h: Rename include guard.
4659         * arch-utils.h: Rename include guard.
4660         * annotate.h: Add include guard.
4661         * amd64-darwin-tdep.h: Rename include guard.
4662         * aarch64-linux-tdep.h: Add include guard.
4663         * aarch64-fbsd-tdep.h: Add include guard.
4664         * aarch32-linux-nat.h: Add include guard.
4665
4666 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4667
4668         * macrotab.c (macro_define_internal): New function that
4669         factorizes macro_define_object_internal and macro_define_function
4670         code.
4671         (macro_define_object_internal): Use macro_define_internal.
4672         (macro_define_function): Likewise.
4673
4674 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4675
4676         * macrocmd.c (extract_identifier): Return
4677         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4678         callers.
4679
4680 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4681
4682         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4683
4684 2019-02-05  Tom Tromey  <tom@tromey.com>
4685
4686         * target.c (target_stack::unpush): Move assertion earlier.
4687
4688 2019-01-30  Tom Tromey  <tom@tromey.com>
4689
4690         PR python/23615:
4691         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4692         (gdbpy_parse_and_eval): Likewise.
4693         * python/python-internal.h (gdbpy_allow_threads): New class.
4694
4695 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4696
4697         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4698         (aarch64_fbsd_fpregmap): Move earlier.
4699         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4700         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4701         instead of individual calls to trad_frame_set_reg_addr.
4702         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4703         earlier.
4704         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4705         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4706         instead of individual calls to trad_frame_set_reg_addr.
4707
4708 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4709
4710         * CONTRIBUTE: Replace contribution list with wiki link.
4711
4712 2019-01-25  Tom Tromey  <tom@tromey.com>
4713
4714         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4715
4716 2019-01-25  Tom Tromey  <tom@tromey.com>
4717
4718         * xtensa-linux-nat.c: Fix common/ includes.
4719         * xml-support.h: Fix common/ includes.
4720         * xml-support.c: Fix common/ includes.
4721         * x86-linux-nat.c: Fix common/ includes.
4722         * windows-nat.c: Fix common/ includes.
4723         * varobj.h: Fix common/ includes.
4724         * varobj.c: Fix common/ includes.
4725         * value.c: Fix common/ includes.
4726         * valops.c: Fix common/ includes.
4727         * utils.c: Fix common/ includes.
4728         * unittests/xml-utils-selftests.c: Fix common/ includes.
4729         * unittests/utils-selftests.c: Fix common/ includes.
4730         * unittests/unpack-selftests.c: Fix common/ includes.
4731         * unittests/tracepoint-selftests.c: Fix common/ includes.
4732         * unittests/style-selftests.c: Fix common/ includes.
4733         * unittests/string_view-selftests.c: Fix common/ includes.
4734         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4735         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4736         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4737         * unittests/rsp-low-selftests.c: Fix common/ includes.
4738         * unittests/parse-connection-spec-selftests.c: Fix common/
4739         includes.
4740         * unittests/optional-selftests.c: Fix common/ includes.
4741         * unittests/offset-type-selftests.c: Fix common/ includes.
4742         * unittests/observable-selftests.c: Fix common/ includes.
4743         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4744         * unittests/memrange-selftests.c: Fix common/ includes.
4745         * unittests/memory-map-selftests.c: Fix common/ includes.
4746         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4747         * unittests/function-view-selftests.c: Fix common/ includes.
4748         * unittests/environ-selftests.c: Fix common/ includes.
4749         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4750         * unittests/common-utils-selftests.c: Fix common/ includes.
4751         * unittests/cli-utils-selftests.c: Fix common/ includes.
4752         * unittests/array-view-selftests.c: Fix common/ includes.
4753         * ui-file.c: Fix common/ includes.
4754         * tui/tui-io.c: Fix common/ includes.
4755         * tracepoint.h: Fix common/ includes.
4756         * tracepoint.c: Fix common/ includes.
4757         * tracefile-tfile.c: Fix common/ includes.
4758         * top.h: Fix common/ includes.
4759         * top.c: Fix common/ includes.
4760         * thread.c: Fix common/ includes.
4761         * target/waitstatus.h: Fix common/ includes.
4762         * target/waitstatus.c: Fix common/ includes.
4763         * target.h: Fix common/ includes.
4764         * target.c: Fix common/ includes.
4765         * target-memory.c: Fix common/ includes.
4766         * target-descriptions.c: Fix common/ includes.
4767         * symtab.h: Fix common/ includes.
4768         * symfile.c: Fix common/ includes.
4769         * stap-probe.c: Fix common/ includes.
4770         * spu-linux-nat.c: Fix common/ includes.
4771         * sparc-nat.c: Fix common/ includes.
4772         * source.c: Fix common/ includes.
4773         * solib.c: Fix common/ includes.
4774         * solib-target.c: Fix common/ includes.
4775         * ser-unix.c: Fix common/ includes.
4776         * ser-tcp.c: Fix common/ includes.
4777         * ser-pipe.c: Fix common/ includes.
4778         * ser-base.c: Fix common/ includes.
4779         * selftest-arch.c: Fix common/ includes.
4780         * s12z-tdep.c: Fix common/ includes.
4781         * rust-exp.y: Fix common/ includes.
4782         * rs6000-aix-tdep.c: Fix common/ includes.
4783         * riscv-tdep.c: Fix common/ includes.
4784         * remote.c: Fix common/ includes.
4785         * remote-notif.h: Fix common/ includes.
4786         * remote-fileio.h: Fix common/ includes.
4787         * remote-fileio.c: Fix common/ includes.
4788         * regcache.h: Fix common/ includes.
4789         * regcache.c: Fix common/ includes.
4790         * record-btrace.c: Fix common/ includes.
4791         * python/python.c: Fix common/ includes.
4792         * python/py-type.c: Fix common/ includes.
4793         * python/py-inferior.c: Fix common/ includes.
4794         * progspace.h: Fix common/ includes.
4795         * producer.c: Fix common/ includes.
4796         * procfs.c: Fix common/ includes.
4797         * proc-api.c: Fix common/ includes.
4798         * printcmd.c: Fix common/ includes.
4799         * ppc-linux-nat.c: Fix common/ includes.
4800         * parser-defs.h: Fix common/ includes.
4801         * osdata.c: Fix common/ includes.
4802         * obsd-nat.c: Fix common/ includes.
4803         * nat/x86-linux.c: Fix common/ includes.
4804         * nat/x86-linux-dregs.c: Fix common/ includes.
4805         * nat/x86-dregs.h: Fix common/ includes.
4806         * nat/x86-dregs.c: Fix common/ includes.
4807         * nat/ppc-linux.c: Fix common/ includes.
4808         * nat/mips-linux-watch.h: Fix common/ includes.
4809         * nat/mips-linux-watch.c: Fix common/ includes.
4810         * nat/linux-waitpid.c: Fix common/ includes.
4811         * nat/linux-ptrace.h: Fix common/ includes.
4812         * nat/linux-ptrace.c: Fix common/ includes.
4813         * nat/linux-procfs.c: Fix common/ includes.
4814         * nat/linux-personality.c: Fix common/ includes.
4815         * nat/linux-osdata.c: Fix common/ includes.
4816         * nat/linux-namespaces.c: Fix common/ includes.
4817         * nat/linux-btrace.h: Fix common/ includes.
4818         * nat/linux-btrace.c: Fix common/ includes.
4819         * nat/fork-inferior.c: Fix common/ includes.
4820         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4821         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4822         * nat/aarch64-linux.c: Fix common/ includes.
4823         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4824         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4825         * namespace.h: Fix common/ includes.
4826         * mips-linux-tdep.c: Fix common/ includes.
4827         * minsyms.c: Fix common/ includes.
4828         * mi/mi-parse.h: Fix common/ includes.
4829         * mi/mi-main.c: Fix common/ includes.
4830         * mi/mi-cmd-env.c: Fix common/ includes.
4831         * memrange.h: Fix common/ includes.
4832         * memattr.c: Fix common/ includes.
4833         * maint.h: Fix common/ includes.
4834         * maint.c: Fix common/ includes.
4835         * main.c: Fix common/ includes.
4836         * machoread.c: Fix common/ includes.
4837         * location.c: Fix common/ includes.
4838         * linux-thread-db.c: Fix common/ includes.
4839         * linux-nat.c: Fix common/ includes.
4840         * linux-fork.c: Fix common/ includes.
4841         * inline-frame.c: Fix common/ includes.
4842         * infrun.c: Fix common/ includes.
4843         * inflow.c: Fix common/ includes.
4844         * inferior.h: Fix common/ includes.
4845         * inferior.c: Fix common/ includes.
4846         * infcmd.c: Fix common/ includes.
4847         * inf-ptrace.c: Fix common/ includes.
4848         * inf-child.c: Fix common/ includes.
4849         * ia64-linux-nat.c: Fix common/ includes.
4850         * i387-tdep.c: Fix common/ includes.
4851         * i386-tdep.c: Fix common/ includes.
4852         * i386-linux-tdep.c: Fix common/ includes.
4853         * i386-linux-nat.c: Fix common/ includes.
4854         * i386-go32-tdep.c: Fix common/ includes.
4855         * i386-fbsd-tdep.c: Fix common/ includes.
4856         * i386-fbsd-nat.c: Fix common/ includes.
4857         * guile/scm-type.c: Fix common/ includes.
4858         * guile/guile.c: Fix common/ includes.
4859         * go32-nat.c: Fix common/ includes.
4860         * gnu-nat.c: Fix common/ includes.
4861         * gdbthread.h: Fix common/ includes.
4862         * gdbarch-selftests.c: Fix common/ includes.
4863         * gdb_usleep.c: Fix common/ includes.
4864         * gdb_select.h: Fix common/ includes.
4865         * gdb_bfd.c: Fix common/ includes.
4866         * gcore.c: Fix common/ includes.
4867         * fork-child.c: Fix common/ includes.
4868         * findvar.c: Fix common/ includes.
4869         * fbsd-nat.c: Fix common/ includes.
4870         * event-top.c: Fix common/ includes.
4871         * event-loop.c: Fix common/ includes.
4872         * dwarf2read.c: Fix common/ includes.
4873         * dwarf2loc.c: Fix common/ includes.
4874         * dwarf2-frame.c: Fix common/ includes.
4875         * dwarf-index-cache.c: Fix common/ includes.
4876         * dtrace-probe.c: Fix common/ includes.
4877         * disasm-selftests.c: Fix common/ includes.
4878         * defs.h: Fix common/ includes.
4879         * csky-tdep.c: Fix common/ includes.
4880         * cp-valprint.c: Fix common/ includes.
4881         * cp-support.h: Fix common/ includes.
4882         * cp-support.c: Fix common/ includes.
4883         * corelow.c: Fix common/ includes.
4884         * completer.h: Fix common/ includes.
4885         * completer.c: Fix common/ includes.
4886         * compile/compile.c: Fix common/ includes.
4887         * compile/compile-loc2c.c: Fix common/ includes.
4888         * compile/compile-cplus-types.c: Fix common/ includes.
4889         * compile/compile-cplus-symbols.c: Fix common/ includes.
4890         * command.h: Fix common/ includes.
4891         * cli/cli-dump.c: Fix common/ includes.
4892         * cli/cli-cmds.c: Fix common/ includes.
4893         * charset.c: Fix common/ includes.
4894         * build-id.c: Fix common/ includes.
4895         * btrace.h: Fix common/ includes.
4896         * btrace.c: Fix common/ includes.
4897         * breakpoint.h: Fix common/ includes.
4898         * breakpoint.c: Fix common/ includes.
4899         * ax.h:
4900         (enum agent_op): Fix common/ includes.
4901         * ax-general.c (struct aop_map): Fix common/ includes.
4902         * ax-gdb.c: Fix common/ includes.
4903         * auxv.c: Fix common/ includes.
4904         * auto-load.c: Fix common/ includes.
4905         * arm-tdep.c: Fix common/ includes.
4906         * arch/riscv.c: Fix common/ includes.
4907         * arch/ppc-linux-common.c: Fix common/ includes.
4908         * arch/i386.c: Fix common/ includes.
4909         * arch/arm.c: Fix common/ includes.
4910         * arch/arm-linux.c: Fix common/ includes.
4911         * arch/arm-get-next-pcs.c: Fix common/ includes.
4912         * arch/amd64.c: Fix common/ includes.
4913         * arch/aarch64.c: Fix common/ includes.
4914         * arch/aarch64-insn.c: Fix common/ includes.
4915         * arch-utils.c: Fix common/ includes.
4916         * amd64-windows-tdep.c: Fix common/ includes.
4917         * amd64-tdep.c: Fix common/ includes.
4918         * amd64-sol2-tdep.c: Fix common/ includes.
4919         * amd64-obsd-tdep.c: Fix common/ includes.
4920         * amd64-nbsd-tdep.c: Fix common/ includes.
4921         * amd64-linux-tdep.c: Fix common/ includes.
4922         * amd64-linux-nat.c: Fix common/ includes.
4923         * amd64-fbsd-tdep.c: Fix common/ includes.
4924         * amd64-fbsd-nat.c: Fix common/ includes.
4925         * amd64-dicos-tdep.c: Fix common/ includes.
4926         * amd64-darwin-tdep.c: Fix common/ includes.
4927         * agent.c: Fix common/ includes.
4928         * ada-lang.h: Fix common/ includes.
4929         * ada-lang.c: Fix common/ includes.
4930         * aarch64-tdep.c: Fix common/ includes.
4931
4932 2019-01-25  Tom Tromey  <tom@tromey.com>
4933
4934         * common/create-version.sh: Use common/version.h.
4935
4936 2019-01-24  Pedro Alves  <palves@redhat.com>
4937
4938         * infrun.c (signal_stop, signal_print, signal_program)
4939         (signal_catch, signal_pass): Now arrays instead of pointers.
4940         (update_signals_program_target, do_target_resume)
4941         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4942         * linux-nat.c (linux_nat_target::pass_signals)
4943         (linux_nat_target::create_inferior, linux_nat_target::attach):
4944         Adjust.
4945         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4946         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4947         * procfs.c (procfs_target::pass_signals): Adjust.
4948         * record-full.c (record_full_target::resume): Adjust.
4949         * remote.c (remote_target::pass_signals)
4950         (remote_target::program_signals): Adjust.
4951         * target-debug.h (target_debug_print_signals): Now takes a
4952         gdb::array_view as parameter.  Adjust.
4953         * target.h (target_ops) <pass_signals, program_signals>: Replace
4954         pointer and length parameters with gdb::array_view.
4955         (target_pass_signals, target_program_signals): Likewise.
4956         * target-delegates.c: Regenerate.
4957
4958 2019-01-24  Pedro Alves  <palves@redhat.com>
4959
4960         * common/forward-scope-exit.h
4961         (forward_scope_exit::forward_scope_exit): Pass arguments to
4962         m_bind_function directly, instead of creating a std::bind and
4963         copying that.
4964
4965 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4966
4967         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4968         for static members.
4969         (pass_in_v_vfp_candidate): Likewise.
4970
4971 2019-01-23  Tom Tromey  <tom@tromey.com>
4972             Pedro Alves  <palves@redhat.com>
4973
4974         * regcache.c (class regcache_invalidator): Remove.
4975         (regcache::raw_write): Use make_scope_exit.
4976
4977 2019-01-23  Tom Tromey  <tom@tromey.com>
4978
4979         * ui-out.h (class ui_out_emit_type): Update comment.
4980
4981 2019-01-23  Tom Tromey  <tom@tromey.com>
4982
4983         * infrun.c (fetch_inferior_event): Update comment.
4984
4985 2019-01-23  Tom Tromey  <tom@tromey.com>
4986             Pedro Alves  <palves@redhat.com>
4987
4988         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4989         parameter.
4990         (fetch_inferior_event): Use SCOPE_EXIT.
4991
4992
4993 2019-01-23  Tom Tromey  <tom@tromey.com>
4994             Pedro Alves  <palves@redhat.com>
4995
4996         * infrun.c (disable_thread_events): Delete.
4997         (stop_all_threads): Use SCOPE_EXIT.
4998
4999 2019-01-23  Tom Tromey  <tom@tromey.com>
5000             Pedro Alves  <palves@redhat.com>
5001
5002         * symfile.c: Include forward-scope-exit.h.
5003         (clear_symtab_users_cleanup): Replace forward declaration with
5004         a FORWARD_SCOPE_EXIT.
5005         (syms_from_objfile_1): Use the forward_scope_exit and
5006         gdb::optional instead of cleanup_function.
5007         (reread_symbols): Use the forward_scope_exit instead of
5008         cleanup_function.
5009         (clear_symtab_users_cleanup): Remove function.
5010
5011 2019-01-23  Tom Tromey  <tom@tromey.com>
5012             Pedro Alves  <palves@redhat.com>
5013
5014         * linux-nat.c: Include scope-exit.h.
5015         (cleanup_target_stop): Remove.
5016         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5017         SCOPE_EXIT.
5018
5019 2019-01-23  Tom Tromey  <tom@tromey.com>
5020             Pedro Alves  <palves@redhat.com>
5021
5022         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5023         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5024
5025 2019-01-23  Tom Tromey  <tom@tromey.com>
5026             Andrew Burgess  <andrew.burgess@embecosm.com>
5027             Pedro Alves  <palves@redhat.com>
5028
5029         * infrun.c (fetch_inferior_event): Use scope_exit.
5030         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5031         * top.c (execute_command): Use scope_exit.
5032         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5033         * utils.c (do_bpstat_clear_actions_cleanup)
5034         (make_bpstat_clear_actions_cleanup): Remove.
5035
5036 2019-01-23  Tom Tromey  <tom@tromey.com>
5037             Pedro Alves  <palves@redhat.com>
5038
5039         * infrun.c: Include "common/scope-exit.h"
5040         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5041         (wait_for_inferior): Use SCOPE_EXIT.
5042         (fetch_inferior_event): Use scope_exit.
5043
5044 2019-01-23  Tom Tromey  <tom@tromey.com>
5045             Pedro Alves  <palves@redhat.com>
5046
5047         * breakpoint.c (create_breakpoint): Remove cleanup.
5048
5049 2019-01-23  Tom Tromey  <tom@tromey.com>
5050             Andrew Burgess  <andrew.burgess@embecosm.com>
5051             Pedro Alves  <palves@redhat.com>
5052
5053 2019-01-23  Pedro Alves  <palves@redhat.com>
5054
5055         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5056
5057 2019-01-23  Pedro Alves  <palves@redhat.com>
5058             Andrew Burgess  <andrew.burgess@embecosm.com>
5059
5060         * gdbthread.h: Include "common/forward-scope-exit.h".
5061         (scoped_finish_thread_state): Redefine custom class in terms of
5062         forward_scope_exit.
5063
5064 2019-01-23  Pedro Alves  <palves@redhat.com>
5065             Andrew Burgess  <andrew.burgess@embecosm.com>
5066
5067         * common/forward-scope-exit.h: New file.
5068
5069 2019-01-23  Pedro Alves  <palves@redhat.com>
5070             Andrew Burgess  <andrew.burgess@embecosm.com>
5071             Tom Tromey  <tom@tromey.com>
5072
5073         * common/scope-exit.h: New file.
5074
5075 2019-01-23  Pedro Alves  <palves@redhat.com>
5076
5077         * common/preprocessor.h (ESC): Rename to ...
5078         (ESC_PARENS): ... this.
5079         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5080         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5081
5082 2019-01-23  Tom Tromey  <tom@tromey.com>
5083
5084         * language.h (class scoped_switch_to_sym_language_if_auto):
5085         Initialize m_lang in both cases.
5086
5087 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5088
5089         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5090         with XCNEW.
5091
5092 2019-01-22  Tom Tromey  <tom@tromey.com>
5093
5094         * corelow.c: Do not include sys/file.h.
5095
5096 2019-01-22  Tom Tromey  <tom@tromey.com>
5097
5098         * tui/tui-wingeneral.h: Include gdb_curses.h.
5099
5100 2019-01-22  Tom Tromey  <tom@tromey.com>
5101
5102         * source-cache.h (class source_cache) <get_source_lines,
5103         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5104
5105 2019-01-22  Tom Tromey  <tom@tromey.com>
5106
5107         * remote-fileio.h (struct remote_target): Declare.
5108
5109 2019-01-22  Tom Tromey  <tom@tromey.com>
5110
5111         * python/py-arch.c: Do not include py-ref.h.
5112         * python/py-bpevent.c: Do not include py-ref.h.
5113         * python/py-cmd.c: Do not include py-ref.h.
5114         * python/py-continueevent.c: Do not include py-ref.h.
5115         * python/py-event.h: Do not include py-ref.h.
5116         * python/py-evtregistry.c: Do not include py-ref.h.
5117         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5118         * python/py-frame.c: Do not include py-ref.h.
5119         * python/py-framefilter.c: Do not include py-ref.h.
5120         * python/py-function.c: Do not include py-ref.h.
5121         * python/py-infevents.c: Do not include py-ref.h.
5122         * python/py-linetable.c: Do not include py-ref.h.
5123         * python/py-objfile.c: Do not include py-ref.h.
5124         * python/py-param.c: Do not include py-ref.h.
5125         * python/py-prettyprint.c: Do not include py-ref.h.
5126         * python/py-progspace.c: Do not include py-ref.h.
5127         * python/py-symbol.c: Do not include py-ref.h.
5128         * python/py-symtab.c: Do not include py-ref.h.
5129         * python/py-type.c: Do not include py-ref.h.
5130         * python/py-unwind.c: Do not include py-ref.h.
5131         * python/py-utils.c: Do not include py-ref.h.
5132         * python/py-value.c: Do not include py-ref.h.
5133         * python/py-varobj.c: Do not include py-ref.h.
5134         * python/py-xmethods.c: Do not include py-ref.h.
5135         * python/python.c: Do not include py-ref.h.
5136         * varobj.c: Do not include py-ref.h.
5137
5138 2019-01-22  Tom Tromey  <tom@tromey.com>
5139
5140         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5141         keyword for bcache.
5142
5143 2019-01-22  Tom Tromey  <tom@tromey.com>
5144
5145         * compile/compile-cplus-types.c: Remove a comment by #include.
5146
5147 2019-01-22  Tom Tromey  <tom@tromey.com>
5148
5149         * compile/gcc-c-plugin.h: Include compile-internal.h.
5150
5151 2019-01-22  Tom Tromey  <tom@tromey.com>
5152
5153         * stabsread.c (EXTERN): Do not define.
5154         (symnum, next_symbol_text_func, processing_gcc_compilation)
5155         (within_function, global_sym_chain, global_stabs)
5156         (previous_stab_code, this_object_header_files)
5157         (n_this_object_header_files)
5158         (n_allocated_this_object_header_files): Define.
5159         * stabsread.h (EXTERN): Never define.  Use "extern".
5160
5161 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5162
5163         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5164         history_value.
5165
5166 2019-01-21  Tom Tromey  <tom@tromey.com>
5167
5168         * ui-out.c: Fix includes.
5169         * tui/tui-source.c: Fix includes.
5170         * target.c: Fix includes.
5171         * remote.c: Fix includes.
5172         * regcache.c: Fix includes.
5173         * python/py-block.c: Fix includes.
5174         * printcmd.c: Fix includes.
5175         * or1k-tdep.c: Fix includes.
5176         * mi/mi-main.c: Fix includes.
5177         * m32r-tdep.c: Fix includes.
5178         * csky-tdep.c: Fix includes.
5179         * compile/compile-cplus-types.c: Fix includes.
5180         * cli/cli-interp.c: Fix includes.
5181
5182 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5183
5184         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5185         for padding.
5186
5187 2019-01-16  Tom Tromey  <tom@tromey.com>
5188
5189         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5190         earlier.
5191         (struct objfile) <msymbols_range>: Move from top level.
5192         <msymbols>: New method.
5193         (class objfile_msymbols): Remove.
5194         * symtab.c (default_collect_symbol_completion_matches_break_on):
5195         Update.
5196         * symmisc.c (dump_msymbols): Update.
5197         * stabsread.c (scan_file_globals): Update.
5198         * objc-lang.c (info_selectors_command, info_classes_command)
5199         (find_methods): Update.
5200         * minsyms.c (find_solib_trampoline_target): Update.
5201         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5202         * coffread.c (coff_symfile_read): Update.
5203         * ada-lang.c (ada_lookup_simple_minsym)
5204         (ada_collect_symbol_completion_matches): Update.
5205
5206 2019-01-16  Tom Tromey  <tom@tromey.com>
5207
5208         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5209         type.  Remove no-argument constructor.
5210         <iterator::operator++>: Simplify.
5211         <begin>: Update.
5212         <end>: Use minimal_symbol_count.
5213
5214 2019-01-16  Tom Tromey  <tom@tromey.com>
5215
5216         * objfiles.h (struct objfile) <psymtabs>: New method.
5217         (class objfile_psymtabs): Remove.
5218         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5219         typedef.
5220         <range>: New method.
5221         (require_partial_symbols): Change return type.
5222         * psymtab.c (require_partial_symbols)
5223         (psym_expand_symtabs_matching): Update.
5224         * mdebugread.c (parse_partial_symbols): Update.
5225         * dbxread.c (dbx_end_psymtab): Update.
5226
5227 2019-01-15  Tom Tromey  <tom@tromey.com>
5228
5229         * symtab.c (lookup_objfile_from_block)
5230         (lookup_symbol_in_objfile_symtabs)
5231         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5232         (find_line_symtab, info_sources_command)
5233         (default_collect_symbol_completion_matches_break_on)
5234         (make_source_files_completion_list): Update.
5235         * symmisc.c (print_objfile_statistics, dump_objfile)
5236         (maintenance_print_symbols, maintenance_info_symtabs)
5237         (maintenance_check_symtabs, maintenance_info_line_tables):
5238         Update.
5239         * source.c (select_source_symtab)
5240         (forget_cached_source_info_for_objfile): Update.
5241         * objfiles.h (class objfile_compunits): Remove.
5242         (struct objfile) <compunits_range>: New typedef.
5243         (compunits): New method.
5244         * objfiles.c (objfile_relocate1): Update.
5245         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5246         * maint.c (count_symtabs_and_blocks): Update.
5247         * linespec.c (iterate_over_all_matching_symtabs): Update.
5248         * cp-support.c (add_symbol_overload_list_qualified): Update.
5249         * coffread.c (coff_symtab_read): Update.
5250         * ada-lang.c (add_nonlocal_symbols)
5251         (ada_collect_symbol_completion_matches)
5252         (ada_add_global_exceptions): Update.
5253
5254 2019-01-15  Tom Tromey  <tom@tromey.com>
5255
5256         * progspace.h (program_space) <objfiles_safe_range>: New
5257         typedef.
5258         <objfiles_safe>: New method.
5259         * objfiles.h (class all_objfiles_safe): Remove.
5260         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5261         * jit.c (jit_inferior_exit_hook): Update.
5262
5263 2019-01-17  Tom Tromey  <tom@tromey.com>
5264
5265         * progspace.h (program_space) <objfiles_range>: New typedef.
5266         <objfiles>: New method.
5267         <objfiles_head>: Rename from objfiles.
5268         (object_files): Update.
5269         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5270         * guile/scm-pretty-print.c
5271         (ppscm_find_pretty_printer_from_objfiles): Update.
5272         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5273         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5274         Update.
5275         * python/py-progspace.c (pspy_get_objfiles): Update.
5276         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5277         Update.
5278         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5279         (objfpy_lookup_objfile_by_build_id): Update.
5280         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5281         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5282         Update.
5283         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5284         (expand_symtab_containing_pc, lookup_objfile_from_block)
5285         (lookup_static_symbol, basic_lookup_transparent_type)
5286         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5287         (find_line_symtab, info_sources_command)
5288         (default_collect_symbol_completion_matches_break_on)
5289         (make_source_files_completion_list, find_main_name): Update.
5290         * symmisc.c (print_symbol_bcache_statistics)
5291         (print_objfile_statistics, maintenance_print_symbols)
5292         (maintenance_print_msymbols, maintenance_print_objfiles)
5293         (maintenance_info_symtabs, maintenance_check_symtabs)
5294         (maintenance_expand_symtabs, maintenance_info_line_tables):
5295         Update.
5296         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5297         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5298         (map_overlay_command, unmap_overlay_command)
5299         (simple_overlay_update, expand_symtabs_matching)
5300         (map_symbol_filenames): Update.
5301         * symfile-debug.c (set_debug_symfile): Update.
5302         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5303         Update.
5304         * source.c (select_source_symtab, forget_cached_source_info):
5305         Update.
5306         * solib.c (solib_read_symbols): Update.
5307         * solib-spu.c (append_ocl_sos): Update.
5308         * psymtab.c (maintenance_print_psymbols)
5309         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5310         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5311         * printcmd.c (info_symbol_command): Update.
5312         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5313         Update.
5314         * objfiles.h (class all_objfiles): Remove.
5315         * objfiles.c (have_partial_symbols, have_full_symbols)
5316         (have_minimal_symbols, qsort_cmp, update_section_map)
5317         (shared_objfile_contains_address_p)
5318         (default_iterate_over_objfiles_in_search_order): Update.
5319         * objc-lang.c (info_selectors_command, info_classes_command)
5320         (find_methods): Update.
5321         * minsyms.c (find_solib_trampoline_target): Update.
5322         * maint.c (maintenance_info_sections)
5323         (maintenance_translate_address, count_symtabs_and_blocks):
5324         Update.
5325         * main.c (captured_main_1): Update.
5326         * linux-thread-db.c (try_thread_db_load_from_pdir)
5327         (has_libpthread): Update.
5328         * linespec.c (iterate_over_all_matching_symtabs)
5329         (search_minsyms_for_name): Update.
5330         * jit.c (jit_find_objf_with_entry_addr): Update.
5331         * hppa-tdep.c (find_unwind_entry)
5332         (hppa_lookup_stub_minimal_symbol): Update.
5333         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5334         Update.
5335         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5336         (elf_gnu_ifunc_resolve_by_got): Update.
5337         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5338         * dwarf-index-write.c (save_gdb_index_command): Update.
5339         * cp-support.c (add_symbol_overload_list_qualified): Update.
5340         * breakpoint.c (create_overlay_event_breakpoint)
5341         (create_longjmp_master_breakpoint)
5342         (create_std_terminate_master_breakpoint)
5343         (create_exception_master_breakpoint): Update.
5344         * blockframe.c (find_pc_partial_function): Update.
5345         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5346         (ada_collect_symbol_completion_matches)
5347         (ada_add_global_exceptions): Update.
5348
5349 2019-01-17  Tom Tromey  <tom@tromey.com>
5350
5351         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5352         declare VEC.
5353         (solib_target_parse_libraries): Change return type.
5354         (library_list_start_segment, library_list_start_section)
5355         (library_list_end_library, library_list_start_library); Update.
5356         (solib_target_free_library_list): Remove.
5357         (solib_target_parse_libraries): Remove cleanup.  Change return
5358         type.
5359         (solib_target_current_sos): Update.
5360
5361 2019-01-17  Tom Tromey  <tromey@bapiya>
5362
5363         * valprint.c: Replace "the the" with "the".
5364         * symtab.c: Replace "the the" with "the".
5365         * solib.c: Replace "the the" with "the".
5366         * solib-dsbt.c: Replace "the the" with "the".
5367         * linespec.c: Replace "the the" with "the".
5368         * dwarf2loc.h: Replace "the the" with "the".
5369         * amd64-windows-tdep.c: Replace "the the" with "the".
5370         * aarch64-tdep.c: Replace "the the" with "the".
5371
5372 2019-01-16  Keith Seitz  <keiths@redhat.com>
5373
5374         PR gdb/23773
5375         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5376         <builder>: Rename to ..
5377         <m_builder>: ... this and make private.
5378         (dwarf2_cu::get_builder): New method.  Change all users of
5379         `builder' to use this method.
5380         (dwarf2_start_symtab): Move to ...
5381         (dwarf2_cu::start_symtab): ... here.  Update all callers
5382         (setup_type_unit_groups): Move to ...
5383         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5384         callers.
5385         (dwarf2_cu::reset_builder): New method.
5386         (process_full_compunit, process_full_type_unit): Use
5387         dwarf2_cu::reset_builder.
5388         (follow_die_offset): Record the ancestor CU if it is different
5389         from the followed DIE's CU.
5390         (follow_die_sig_1): Likewise.
5391
5392 2019-01-15  Tom Tromey  <tom@tromey.com>
5393
5394         * remote.c (class remote_state) <buf>: Now a char_vector.
5395         <buf_size>: Remove.
5396         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5397         parameter.
5398         (remote_target::getpkt_or_notif_sane_1)
5399         (remote_target::getpkt_sane)
5400         (remote_target::getpkt_or_notif_sane): Likewise.
5401         (class remote_target) <putpkt>: New overload.
5402         (remote_target::read_frame): Change type of "buf_p".  Remove
5403         sizeof_p parameter.
5404         (packet_ok): New overload.
5405         (packet_check_result): New overload.
5406         Update all uses.
5407
5408 2019-01-14  Tom Tromey  <tom@tromey.com>
5409
5410         * remote-notif.c (handle_notification, remote_notif_ack)
5411         (remote_notif_parse): Make "buf" const.
5412         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5413         const.
5414         (remote_notif_parse, remote_notif_ack, handle_notification):
5415         Likewise.
5416         * remote.c (remote_notif_stop_parse): Make "buf" const.
5417         (remote_target::remote_parse_stop_reply): Make "buf" const.
5418         (remote_notif_stop_ack): Make "buf" const.
5419
5420 2019-01-14  Tom Tromey  <tom@tromey.com>
5421
5422         * remote.c (remote_console_output): Make parameter const.
5423
5424 2019-01-14  Tom Tromey  <tom@tromey.com>
5425
5426         * target-debug.h (target_debug_print_signals): Constify.
5427         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5428         * procfs.c (procfs_target::pass_signals): Update.
5429         * linux-nat.c (linux_nat_target::pass_signals): Update.
5430         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5431         * target-delegates.c: Rebuild.
5432         * remote.c (remote_target::program_signals): Update.
5433         (remote_target::pass_signals): Update.
5434         * target.c (target_pass_signals): Constify argument.
5435         (target_program_signals): Likewise.
5436         * target.h (struct target_ops) <pass_signals, program_signals>:
5437         Constify argument.
5438         (target_pass_signals, target_program_signals): Constify argument.
5439
5440 2019-01-14  Tom Tromey  <tom@tromey.com>
5441
5442         PR tui/28819:
5443         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5444
5445 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5446
5447         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5448         field.
5449         * rs6000-tdep.c: Include reggroups.h.
5450         (IS_V_ALIAS_PSEUDOREG): Define.
5451         (rs6000_register_name): Return names for the "vX" aliases.
5452         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5453         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5454         aliases.  Call default_register_reggroup_p for all other
5455         pseudo-registers.
5456         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5457         New functions.
5458         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5459         Handle "vX" aliases.
5460         (v_alias_pseudo_register_collect): New function.
5461         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5462         (rs6000_gdbarch_init): Initialize "vX" aliases as
5463         pseudo-registers.  Restore registration of
5464         rs6000_pseudo_register_reggroup_p with
5465         set_tdesc_pseudo_register_reggroup_p.
5466
5467 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5468
5469         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5470         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5471         set_gdbarch_num_pseudo_regs.
5472
5473 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5474
5475         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5476         Remove arg prefixname, add do_set and do_show.
5477         Add member functions set_list and show_list.
5478         * cli/cli-style.c (class cli_style_option): Update accordingly.
5479         (style_set_list): Move to file scope.
5480         (style_show_list): Likewise.
5481         (set_style): Call help_list.
5482         (show_style): Call cmd_show_list.
5483         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5484         Update to use the new macro.
5485
5486 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5487
5488         * ada-lang.c (_initialize_ada_language): Expand the help text
5489         for the "catch exception" command.
5490
5491 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5492
5493         * symtab.c (matching_obj_sections): Initialize obj,
5494         declare it closer to its usage.
5495
5496 2019-01-10  Tom Tromey  <tom@tromey.com>
5497
5498         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5499         (basic_inf_threads_range): Remove.
5500         (inf_threads_range, inf_non_exited_threads_range)
5501         (safe_inf_threads_range): Use next_adapter.
5502
5503 2019-01-10  Keith Seitz  <keiths@redhat.com>
5504
5505         PR gdb/23712
5506         PR symtab/23010
5507         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5508         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5509
5510 2019-01-10  Keith Seitz  <keiths@redhat.com>
5511
5512         PR gdb/23712
5513         PR symtab/23010
5514         * dictionary.c (pending_to_vector): Remove.
5515         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5516         Remove _1 suffix, replacing functions of the same name.  Update
5517         all callers.
5518         (dict_create_hashed, dict_create_hashed_expandable)
5519         (dict_create_linear, dict_create_linear_expandable, dict_free)
5520         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5521         Make functions static.
5522
5523 2019-01-10  Keith Seitz  <keiths@redhat.com>
5524
5525         PR gdb/23712
5526         PR symtab/23010
5527         * dictionary.h (struct dictionary): Replace declaration with
5528         multidictionary.
5529         (dict_create_hashed, dict_create_hashed_expandable)
5530         (dict_create_linear, dict_create_linear_expandable)
5531         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5532         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5533         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5534         taking multidictionary argument.
5535         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5536         * block.h (struct block) <dict>: Change to multidictionary
5537         and rename `multidict'.
5538         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5539         symmisc.c: Update all dictionary references to multidictionary.
5540
5541 2019-01-10  Keith Seitz  <keiths@redhat.com>
5542
5543         PR gdb/23712
5544         PR symtab/23010
5545         * dictionary.c: Include unordered_map.
5546         (pending_to_vector): New function.
5547         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5548         Rewrite the non-"_1" functions to take vector instead
5549         of linked list.
5550         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5551         "new" _1 versions of the same name.
5552         (multidictionary): Define.
5553         (std::hash<enum language): New definition.
5554         (collate_pending_symbols_by_language, mdict_create_hashed)
5555         (mdict_create_hashed_expandable, mdict_create_linear)
5556         (mdict_create_linear_expandable, mdict_free)
5557         (find_language_dictionary, create_new_language_dictionary)
5558         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5559         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5560         (mdict_size, mdict_empty): New functions.
5561         * dictionary.h (mdict_iterator): Define.
5562
5563 2019-01-10  Pedro Alves  <palves@redhat.com>
5564
5565         * breakpoint.c (read_uploaded_action)
5566         (create_tracepoint_from_upload): Adjust to use
5567         gdb::unique_xmalloc_ptr.
5568         * ctf.c (ctf_write_uploaded_tp):
5569         (SET_ARRAY_FIELD): Use emplace_back.
5570         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5571         * tracefile-tfile.c (tfile_write_uploaded_tp):
5572         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5573         gdb::unique_xmalloc_ptr.
5574         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5575         at_string, cond_string, cmd_strings>: Replace char pointers
5576         with gdb::unique_xmalloc_ptr.
5577
5578 2019-01-10  Pedro Alves  <palves@redhat.com>
5579
5580         * solib-target.c (library_list_start_library): Don't xstrdup name.
5581
5582 2019-01-10  Pedro Alves  <palves@redhat.com>
5583
5584         * mdebugread.c (parse_partial_symbols): Use
5585         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5586
5587 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5588
5589         * linux-fork.c (scoped_switch_fork_info)
5590         <~scoped_switch_fork_info>: Fix incorrect variable name.
5591
5592 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5593
5594         * linux-fork.c (scoped_switch_fork_info)
5595         <scoped_switch_fork_info>: Make explicit.
5596         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5597
5598 2019-01-10  Tom Tromey  <tom@tromey.com>
5599
5600         * objfiles.h (objfile::reset_psymtabs): Update.
5601         * objfiles.c (objfile::objfile): Update.
5602         * psymtab.h (psymtab_storage::obstack): Update.
5603         (psymtab_storage::m_obstack): Use gdb::optional.
5604         (class psymtab_storage): Update comment.  Remove objfile
5605         parameter.
5606         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5607
5608 2019-01-10  Tom Tromey  <tom@tromey.com>
5609
5610         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5611         <free_psymtabs>: Now private.
5612         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5613         (allocate_psymtab): Use new method.
5614
5615 2019-01-10  Tom Tromey  <tom@tromey.com>
5616
5617         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5618         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5619         * mdebugread.c (parse_partial_symbols): Use
5620         allocate_dependencies.
5621         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5622         allocate_dependencies.
5623         (process_psymtab_comp_unit_reader)
5624         (build_type_psymtab_dependencies): Likewise.
5625         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5626
5627 2019-01-10  Tom Tromey  <tom@tromey.com>
5628
5629         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5630         PSYMBOL_SET_LANGUAGE.
5631         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5632
5633 2019-01-10  Tom Tromey  <tom@tromey.com>
5634
5635         * psymtab.h (psymtab_storage::obstack): New method.
5636         <m_obstack>: Rename from obstack; now private.
5637         * psymtab.c (psymtab_storage): Update.
5638         * dwarf2read.c (create_addrmap_from_index)
5639         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5640         Update.
5641
5642 2019-01-10  Tom Tromey  <tom@tromey.com>
5643
5644         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5645         * objfiles.h (objfile::reset_psymtabs): New method.
5646
5647 2019-01-10  Tom Tromey  <tom@tromey.com>
5648
5649         * symmisc.c (print_symbol_bcache_statistics): Update.
5650         (print_objfile_statistics): Update.
5651         * symfile.c (reread_symbols): Update.
5652         * psymtab.h (class psymtab_storage): New.
5653         * psymtab.c (psymtab_storage): New constructor.
5654         (~psymtab_storage): New destructor.
5655         (require_partial_symbols): Update.
5656         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5657         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5658         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5659         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5660         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5661         (start_psymtab_common, end_psymtab_common)
5662         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5663         (allocate_psymtab): Update.
5664         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5665         Update.
5666         (dump_psymtab_addrmap, maintenance_print_psymbols)
5667         (maintenance_check_psymtabs): Update.
5668         (class objfile_psymtabs): Move to objfiles.h.
5669         * psympriv.h (discard_psymtab): Now inline.
5670         (psymtab_discarder::psymtab_discarder): Update.
5671         (psymtab_discarder::~psymtab_discarder): Update.
5672         (ALL_OBJFILE_PSYMTABS): Rewrite.
5673         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5674         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5675         Remove fields.
5676         <partial_symtabs>: New field.
5677         (class objfile_psymtabs): Move from psymtab.h.  Update.
5678         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5679         psymbol_cache.
5680         (objfile::~objfile): Don't destroy psymbol_cache.
5681         * mdebugread.c (parse_partial_symbols): Update.
5682         * dwarf2read.c (create_addrmap_from_index)
5683         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5684         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5685         (add_partial_subprogram, dwarf2_ranges_read): Update.
5686         * dwarf-index-write.c (write_address_map)
5687         (write_one_signatured_type, recursively_write_psymbols)
5688         (class debug_names, class debug_names, write_psymtabs_to_index):
5689         Update.
5690
5691 2019-01-10  Tom Tromey  <tom@tromey.com>
5692
5693         * symtab.h (SYMBOL_SET_NAMES): Update.
5694         (symbol_set_names): Update.
5695         (MSYMBOL_SET_NAMES): Update.
5696         * symtab.c (symbol_set_names): Change argument to be an
5697         objfile_per_bfd_storage.
5698         * psymtab.c (add_psymbol_to_bcache): Update.
5699         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5700
5701 2019-01-10  Tom Tromey  <tom@tromey.com>
5702
5703         * symtab.c (create_demangled_names_hash): Change argument to be an
5704         objfile_per_bfd_storage.
5705         (symbol_set_names): Update.
5706
5707 2019-01-10  Tom Tromey  <tom@tromey.com>
5708
5709         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5710         init_psymbol_list.
5711         * psymtab.c (init_psymbol_list): Do nothing if already called.
5712         * psympriv.h (init_psymbol_list): Add comment.
5713         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5714         init_psymbol_list.
5715         * dbxread.c (dbx_symfile_read): Unconditionally call
5716         init_psymbol_list.
5717
5718 2019-01-10  Tom Tromey  <tom@tromey.com>
5719
5720         * xcoffread.c (scan_xcoff_symtab): Update.
5721         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5722         "where".
5723         * mdebugread.c (parse_partial_symbols)
5724         (handle_psymbol_enumerators): Update.
5725         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5726         * dbxread.c (read_dbx_symtab): Update.
5727         * psympriv.h (psymbol_placement): New enum.
5728         (add_psymbol_to_list): Update.
5729
5730 2019-01-10  Tom Tromey  <tom@tromey.com>
5731
5732         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5733         static_psymbols parameters.
5734         (scan_xcoff_symtab): Update.
5735         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5736         static_psymbols parameters.
5737         * psympriv.h (start_psymtab_common): Update.
5738         * mdebugread.c (parse_partial_symbols): Update.
5739         * dwarf2read.c (create_partial_symtab): Update.
5740         * dbxread.c (read_dbx_symtab): Update.
5741         (start_psymtab): Remove global_psymbols and static_psymbols
5742         parameters.
5743
5744 2019-01-10  Tom Tromey  <tom@tromey.com>
5745
5746         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5747         * psymtab.c (allocate_psymtab): Add comment.
5748         * psympriv.h (allocate_psymtab): Add comment.
5749         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5750         initializations.
5751         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5752
5753 2019-01-10  Tom Tromey  <tom@tromey.com>
5754
5755         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5756         Don't declare.
5757         * mipsread.c: Include mdebugread.h.
5758         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5759         Declare.
5760         * elfread.c: Include mdebugread.h.
5761
5762 2019-01-09  Tom Tromey  <tom@tromey.com>
5763
5764         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5765         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5766         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5767         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5768         (psym_lookup_symbol, psym_find_last_source_symtab)
5769         (psym_forget_cached_source_info, psym_print_stats)
5770         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5771         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5772         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5773         (psym_find_compunit_symtab_by_address)
5774         (maintenance_print_psymbols, maintenance_info_psymtabs)
5775         (maintenance_check_psymtabs): Use ranged for.
5776         * psymtab.h (class objfile_psymtabs): New.
5777         (require_partial_symbols): Return objfile_psymtabs.
5778         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5779
5780 2019-01-09  Tom Tromey  <tom@tromey.com>
5781
5782         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5783         (find_pc_mapped_section, list_overlays_command)
5784         (map_overlay_command, unmap_overlay_command)
5785         (simple_overlay_update): Use all_objfiles.
5786         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5787         * printcmd.c (info_symbol_command): Use all_objfiles.
5788         * objfiles.h (ALL_OBJSECTIONS): Remove.
5789         * maint.c (maintenance_translate_address): Use all_objfiles.
5790         * gcore.c (gcore_create_callback): Use all_objfiles.
5791         (objfile_find_memory_regions): Likewise.
5792
5793 2019-01-09  Tom Tromey  <tom@tromey.com>
5794
5795         * symtab.c (find_line_symtab, info_sources_command)
5796         (make_source_files_completion_list): Use objfile_compunits.
5797         * source.c (select_source_symtab): Use objfile_compunits.
5798         * objfiles.h (struct objfile): Update comment.
5799         (ALL_OBJFILES): Remove.
5800         (ALL_FILETABS): Remove.
5801         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5802         objfile_compunits.
5803
5804 2019-01-09  Tom Tromey  <tom@tromey.com>
5805
5806         * symmisc.c (print_objfile_statistics, dump_objfile)
5807         (maintenance_print_symbols): Use compunit_filetabs.
5808         * source.c (forget_cached_source_info_for_objfile): Use
5809         compunit_filetabs.
5810         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5811         (ALL_FILETABS): Use compunit_filetabs.
5812         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5813         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5814
5815 2019-01-09  Tom Tromey  <tom@tromey.com>
5816
5817         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5818         (compunit_filetabs): New.
5819         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5820         compunit_filetabs.
5821         (info_sources_command, make_source_files_completion_list): Remove
5822         declaration.
5823         * symmisc.c (print_objfile_statistics, dump_objfile)
5824         (maintenance_print_symbols): Remove declaration.
5825         (maintenance_info_symtabs): Use compunit_filetabs.
5826         (maintenance_info_line_tables): Likewise.
5827         * source.c (select_source_symtab): Change local variable name.
5828         (forget_cached_source_info_for_objfile): Remove declaration.
5829         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5830         * objfiles.c (objfile_relocate1): Remove declaration.
5831         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5832         declaration.
5833         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5834         * coffread.c (coff_symtab_read): Remove declaration.
5835         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5836         compunit_filetabs.
5837
5838 2019-01-09  Tom Tromey  <tom@tromey.com>
5839
5840         * symtab.c (lookup_objfile_from_block)
5841         (find_pc_sect_compunit_symtab, search_symbols)
5842         (default_collect_symbol_completion_matches_break_on): Use
5843         objfile_compunits.
5844         * objfiles.h (ALL_COMPUNITS): Remove.
5845         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5846         * cp-support.c (add_symbol_overload_list_qualified): Use
5847         objfile_compunits.
5848         * ada-lang.c (ada_collect_symbol_completion_matches)
5849         (ada_add_global_exceptions): Use objfile_compunits.
5850
5851 2019-01-09  Tom Tromey  <tom@tromey.com>
5852
5853         * source.c (select_source_symtab)
5854         (forget_cached_source_info_for_objfile): Remove declaration.
5855         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5856         declaration.
5857         * maint.c (count_symtabs_and_blocks): Remove declaration.
5858         * cp-support.c (add_symbol_overload_list_qualified): Remove
5859         declaration.
5860         * coffread.c (coff_symtab_read): Remove declaration.
5861         * symtab.c (lookup_symbol_in_objfile_symtabs)
5862         (basic_lookup_transparent_type_1): Use objfile_compunits.
5863         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5864         (info_sources_command, search_symbols)
5865         (default_collect_symbol_completion_matches_break_on)
5866         (make_source_files_completion_list): Remove declaration.
5867         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5868         (ada_collect_symbol_completion_matches)
5869         (ada_add_global_exceptions): Remove declaration.
5870         * linespec.c (iterate_over_all_matching_symtabs): Use
5871         objfile_compunits.
5872         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5873         (class objfile_compunits): New.
5874         (ALL_COMPUNITS): Use objfile_compunits.
5875         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5876         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5877         objfile_compunits.
5878         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5879
5880 2019-01-09  Tom Tromey  <tom@tromey.com>
5881
5882         * symtab.c (search_symbols)
5883         (default_collect_symbol_completion_matches_break_on): Use
5884         objfile_msymbols.
5885         * ada-lang.c (ada_lookup_simple_minsym)
5886         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5887         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5888         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5889         objfile_msymbols.
5890         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5891         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5892         * objc-lang.c (find_methods): Use objfile_msymbols.
5893         (info_selectors_command, info_classes_command): Likewise.
5894         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5895         * objfiles.h (class objfile_msymbols): New.
5896         (ALL_OBJFILE_MSYMBOLS): Remove.
5897         (ALL_MSYMBOLS): Remove.
5898
5899 2019-01-09  Tom Tromey  <tom@tromey.com>
5900
5901         * common/next-iterator.h (next_adapter): Add Iterator template
5902         parameter.
5903         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5904         (class all_objfiles_safe): New.
5905         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5906         * objfiles.c (put_objfile_before): Update comment.
5907         (add_separate_debug_objfile): Likewise.
5908         (free_all_objfiles): Use all_objfiles_safe.
5909         (objfile_purge_solibs): Likewise.
5910
5911 2019-01-09  Tom Tromey  <tom@tromey.com>
5912
5913         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5914         (expand_symtab_containing_pc, lookup_static_symbol)
5915         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5916         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5917         all_objfiles.
5918         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5919         * breakpoint.c (create_overlay_event_breakpoint)
5920         (create_longjmp_master_breakpoint)
5921         (create_std_terminate_master_breakpoint)
5922         (create_exception_master_breakpoint): Use all_objfiles.
5923         * linux-thread-db.c (try_thread_db_load_from_pdir)
5924         (has_libpthread): Use all_objfiles.
5925         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5926         * linespec.c (iterate_over_all_matching_symtabs)
5927         (search_minsyms_for_name): Use all_objfiles.
5928         * maint.c (maintenance_info_sections): Use all_objfiles.
5929         * main.c (captured_main_1): Use all_objfiles.
5930         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5931         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5932         * guile/scm-pretty-print.c
5933         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5934         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5935         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5936         (maintenance_print_msymbols): Use all_objfiles.
5937         * source.c (select_source_symtab): Use all_objfiles.
5938         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5939         * symfile.c (remove_symbol_file_command)
5940         (expand_symtabs_matching, map_symbol_filenames): Use
5941         all_objfiles.
5942         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5943         all_objfiles.
5944         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5945         * objc-lang.c (find_methods): Use all_objfiles.
5946         * objfiles.c (have_partial_symbols, have_full_symbols)
5947         (have_minimal_symbols, qsort_cmp)
5948         (default_iterate_over_objfiles_in_search_order): Use
5949         all_objfiles.
5950         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5951         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5952         (maintenance_check_psymtabs): Use all_objfiles.
5953         (ALL_PSYMTABS): Remove.
5954         * compile/compile-object-run.c (do_module_cleanup): Use
5955         all_objfiles.
5956         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5957         * cp-support.c (add_symbol_overload_list_qualified): Use
5958         all_objfiles.
5959         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5960         Use all_objfiles.
5961         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5962         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5963         all_objfiles.
5964         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5965         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5966         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5967         Uses all_objfiles.
5968         * solib.c (solib_read_symbols): Use all_objfiles
5969
5970 2019-01-09  Tom Tromey  <tom@tromey.com>
5971
5972         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5973         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5974         all_objfiles.
5975         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5976         * symmisc.c (print_symbol_bcache_statistics)
5977         (print_objfile_statistics, maintenance_print_objfiles)
5978         (maintenance_info_symtabs, maintenance_check_symtabs)
5979         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5980         all_objfiles.
5981         * source.c (forget_cached_source_info): Use all_objfiles.
5982         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5983         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5984         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5985         * objfiles.c (update_section_map): Use all_objfiles.
5986         (shared_objfile_contains_address_p): Likewise.
5987         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5988         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5989
5990 2019-01-09  Tom Tromey  <tom@tromey.com>
5991
5992         * common/next-iterator.h: New file.
5993         * objfiles.h (class all_objfiles): New.
5994         (struct objfile_iterator): New.
5995
5996 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5997
5998         * NEWS: Move the description of the changed "frame", "select-frame",
5999          and "info frame" commands to the Changed commands section.
6000
6001 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6002
6003         * gdbtypes.c (check_stub_method_group): Remove handling of old
6004         mangling schemes.
6005         * linespec.c (find_methods): Likewise.
6006         * stabsread.c (read_member_functions): Likewise.
6007         * valops.c (search_struct_method): Likewise.
6008         (value_struct_elt_for_reference): Likewise.
6009         * NEWS: Mention this change.
6010
6011 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6012
6013         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6014         print_source_lines.
6015         * source.c (print_source_lines_base): Update line number check.
6016         (print_source_lines): New function.
6017         (source_lines_range::source_lines_range): New function.
6018         * source.h (class source_lines_range): New class.
6019         (print_source_lines): New declaration.
6020
6021 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6022
6023         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6024
6025 2019-01-08  Tom Tromey  <tom@tromey.com>
6026             Simon Marchi  <simon.marchi@ericsson.com>
6027
6028         PR gdb/24060
6029         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6030         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6031         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6032         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6033         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6034         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6035
6036 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6037
6038         * source.c (select_source_symtab): Move header comment to
6039         declaration in source.h.
6040         (forget_cached_source_info_for_objfile): Likewise.
6041         (forget_cached_source_info): Likewise.
6042         (identify_source_line): Likewise.
6043         * source.h (identify_source_line): Move declaration from symtab.h
6044         and add comment from source.c
6045         (print_source_lines): Likewise.
6046         (forget_cached_source_info_for_objfile): Likewise.
6047         (forget_cached_source_info): Likewise.
6048         (select_source_symtab): Likewise.
6049         (enum print_source_lines_flag): Move definition from symtab.h.
6050         * symtab.h (identify_source_line): Move declaration to source.h.
6051         (print_source_lines): Likewise.
6052         (forget_cached_source_info_for_objfile): Likewise.
6053         (forget_cached_source_info): Likewise.
6054         (select_source_symtab): Likewise.
6055         (enum print_source_lines_flag): Move definition to source.h.
6056         * tui/tui-hooks.c: Add 'source.h' include.
6057
6058 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6059
6060         * source.c (print_source_lines_base): Handle requests to print
6061         reverse line number sequences, and guard against empty lines
6062         string.
6063
6064 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6065
6066         * source.c (print_source_lines_base): Fix skip of '\r' if next
6067         character is '\n'.
6068
6069 2019-01-06  Tom Tromey  <tom@tromey.com>
6070
6071         * c-exp.y (struct c_parse_state) <macro_original_text,
6072         expansion_obstack>: New member.
6073         (macro_original_text, expansion_obstack): Remove globals.
6074         (scan_macro_expansion, scanning_macro_expansion)
6075         (finished_macro_expansion): Update.
6076         (scan_macro_cleanup): Remove.
6077         (yylex, c_parse): Update.
6078
6079 2019-01-06  Tom Tromey  <tom@tromey.com>
6080
6081         * c-exp.y (struct c_parse_state) <strings>: New member.
6082         (operator_stoken): Update.
6083
6084 2019-01-06  Tom Tromey  <tom@tromey.com>
6085
6086         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6087         (union type_stack_elt) <typelist_val>: Now a pointer to
6088         std::vector.
6089         (type_stack_cleanup): Don't declare.
6090         (push_typelist): Update.
6091         * parse.c (pop_typelist): Return a std::vector.
6092         (push_typelist): Take a std::vector.
6093         (follow_types): Update.  Do not free args.
6094         (type_stack_cleanup): Remove.
6095         * c-exp.y (struct c_parse_state): New.
6096         (cpstate): New global.
6097         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6098         (nonempty_typelist): Update.
6099         (func_mod): Create a new vector.
6100         (c_parse): Create a c_parse_state.
6101         (check_parameter_typelist): Do not delete params.
6102         (function_method): Update.  Do not delete type_list.
6103
6104 2019-01-06  Tom Tromey  <tom@tromey.com>
6105
6106         PR gdb/28155:
6107         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6108         check_typedef.
6109         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6110         (print_return_value): Likewise.
6111
6112 2019-01-05  Tom Tromey  <tom@tromey.com>
6113
6114         * contrib/cleanup_check.py: Remove.
6115         * contrib/gcc-with-excheck: Remove.
6116         * contrib/exsummary.py: Remove.
6117         * contrib/excheck.py: Remove.
6118
6119 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6120
6121         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6122         NULL. Initialize tpprev to NULL instead of assigning it
6123         to NULL on the next statement.
6124         * windows-nat.c (windows_delete_thread): Remove check for
6125         main_thread_id before printing thread exit notifications.
6126         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6127         Remove thread ID check against main_thread_id.
6128         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6129         windows_delete_thread.
6130         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6131
6132 2019-01-04  Tom Tromey  <tom@tromey.com>
6133
6134         * compile/compile.c (_initialize_compile): Use upper case for
6135         metasyntactic variables.
6136         * symmisc.c (_initialize_symmisc): Use upper case for
6137         metasyntactic variables.
6138         * psymtab.c (_initialize_psymtab): Use upper case for
6139         metasyntactic variables.
6140         * demangle.c (demangle_command): Use upper case for metasyntactic
6141         variables.
6142         (_initialize_demangler): Likewise.
6143         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6144         variables.
6145
6146 2019-01-03  Tom Tromey  <tom@tromey.com>
6147
6148         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6149
6150 2019-01-03  Tom Tromey  <tom@tromey.com>
6151
6152         * python/py-symtab.c (salpy_str): Update.
6153         (struct salpy_sal_object) <symtab>: Now a PyObject.
6154         (salpy_dealloc): Update.
6155         (del_objfile_sal): Use gdbpy_ref.
6156
6157 2019-01-03  Tom Tromey  <tom@tromey.com>
6158
6159         * python/py-type.c (convert_field): Use new_reference.  Return
6160         gdbpy_ref.
6161         (make_fielditem): Return gdbpy_ref.
6162         (typy_fields): Update.
6163         (typy_getitem): Update.
6164         (field_name): Return gdbpy_ref.  Use new_reference.
6165         (typy_iterator_iternext): Update.
6166
6167 2019-01-03  Tom Tromey  <tom@tromey.com>
6168
6169         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6170
6171 2019-01-03  Tom Tromey  <tom@tromey.com>
6172
6173         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6174         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6175         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6176         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6177         (pspy_set_type_printers): Likewise.
6178         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6179         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6180         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6181         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6182         (objfpy_set_type_printers): Likewise.
6183
6184 2019-01-03  Tom Tromey  <tom@tromey.com>
6185
6186         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6187         (gdbpy_print_stack): Use gdbpy_err_fetch.
6188         * python/python-internal.h (class gdbpy_err_fetch): New class.
6189         (class gdbpy_enter) <m_error_type, m_error_value,
6190         m_error_traceback>: Remove.
6191         <m_error>: New member.
6192         (gdbpy_exception_to_string): Don't declare.
6193         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6194         * python/py-value.c (convert_value_from_python): Use
6195         gdbpy_err_fetch.
6196         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6197         gdbpy_exception_to_string.
6198         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6199         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6200         gdbpy_err_fetch.
6201
6202 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6203
6204         * linux-nat.c (delete_lwp_cleanup): Delete.
6205         (struct lwp_deleter): New struct.
6206         (lwp_info_up): New typedef.
6207         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6208         lwp_info_up.
6209
6210 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6211
6212         * linux-fork.c (class scoped_switch_fork_info): New class.
6213         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6214
6215 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6216
6217         * valops.c (find_overload_match): Remove use of null_cleanup, and
6218         calls to do_cleanups.
6219
6220 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6221
6222         * compile/compile-cplus-types.c
6223         (compile_cplus_instance::decl_name): Handle changes to
6224         cp_func_name.
6225         * cp-support.c (cp_func_name): Update header comment, update
6226         return type.
6227         * cp-support.h (cp_func_name): Update return type in declaration.
6228         * valops.c (find_overload_match): Move temp_func local to top
6229         level of function and change its type.  Use temp_func to hold and
6230         delete temporary string obtained from cp_func_name.
6231
6232 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6233
6234         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6235         gdb::char_vector, remove cleanup, and update uses of `msg`.
6236
6237 2019-01-03  Jim Wilson  <jimw@sifive.com>
6238
6239         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6240
6241 2019-01-02  Tom Tromey  <tom@tromey.com>
6242
6243         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6244         (tdesc_parse_xml): Remove cleanups.
6245         * target-descriptions.h (make_cleanup_free_target_description):
6246         Don't declare.
6247         (target_desc_deleter): New struct.
6248         (target_desc_up): New typedef.
6249         * target-descriptions.c (target_desc_deleter::operator()): Rename
6250         from free_target_description.
6251         (make_cleanup_free_target_description): Remove.
6252
6253 2019-01-02  Tom Tromey  <tom@tromey.com>
6254
6255         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6256         constructor, destructor.
6257         (linespec_parser): Remove typedef.
6258         (~linespec_parser): Rename from linespec_parser_delete.
6259         (linespec_lex_to_end, linespec_complete_label)
6260         (linespec_complete): Update.
6261         (decode_line_full): Remove cleanups.
6262         (decode_line_1): Update.
6263
6264 2019-01-02  Tom Tromey  <tom@tromey.com>
6265
6266         * python/python-internal.h (inferior_to_inferior_object): Change
6267         return type.
6268         * python/py-exitedevent.c (create_exited_event_object): Update.
6269         * python/py-inferior.c (inferior_to_inferior_object): Return
6270         gdbpy_ref.
6271         (python_new_inferior, python_inferior_deleted)
6272         (thread_to_thread_object, delete_thread_object)
6273         (build_inferior_list, gdbpy_selected_inferior): Update.
6274         * python/py-infthread.c (create_thread_object): Update.  Also fail
6275         if inferior_to_inferior_object fails.
6276
6277 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6278
6279         * inferior.h (class inferior) <displaced_step_state>: New field.
6280         * infrun.h (struct displaced_step_state): Move here from
6281         infrun.c.  Initialize fields, add constructor.
6282         <inf>: Remove field.
6283         <reset>: New method.
6284         * infrun.c (struct displaced_step_inferior_state): Move to
6285         infrun.h.
6286         (displaced_step_inferior_states): Remove.
6287         (get_displaced_stepping_state): Adust.
6288         (displaced_step_in_progress_any_inferior): Adjust.
6289         (displaced_step_in_progress_thread): Adjust.
6290         (displaced_step_in_progress): Adjust.
6291         (add_displaced_stepping_state): Remove.
6292         (get_displaced_step_closure_by_addr): Adjust.
6293         (remove_displaced_stepping_state): Remove.
6294         (infrun_inferior_exit): Call displaced_step_state.reset.
6295         (use_displaced_stepping): Don't check for NULL.
6296         (displaced_step_prepare_throw): Call
6297         get_displaced_stepping_state.
6298         (displaced_step_fixup): Don't check for NULL.
6299         (prepare_for_detach): Don't check for NULL.
6300
6301 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6302
6303         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6304          in case of call that did not complete.
6305
6306 2019-01-02  Andrey Utkin  <autkin@undo.io>
6307
6308         * symfile.c (find_separate_debug_file): Fix search of debug files for
6309         remote debuggee.
6310
6311 2019-01-02  Tom Tromey  <tom@tromey.com>
6312
6313         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6314         indentation.
6315         * python/py-frame.c (frapy_older): Remove cast.
6316         (frapy_newer): Likewise.
6317         * python/py-breakpoint.c (local_setattro): Remove cast.
6318         * python/py-arch.c (archpy_name): Remove local variable.
6319         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6320
6321 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6322
6323         * unittests/basic_string_view/element_access/char/empty.cc:
6324         Fix year range in copyright header.
6325
6326 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6327
6328         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6329         Delete.
6330         <operator==>: Update with for removed field.
6331         <hash>: Likewise.
6332         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6333         <isa_features>: ...this.
6334         <abi_features>: New field.
6335         (riscv_isa_flen): Update comment.
6336         (riscv_abi_xlen): New declaration.
6337         (riscv_abi_flen): New declaration.
6338         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6339         isa_features.
6340         (riscv_abi_xlen): New function.
6341         (riscv_isa_flen): Update to get answer from isa_features.
6342         (riscv_abi_flen): New function.
6343         (riscv_has_fp_abi): Update to get answer from abi_features.
6344         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6345         xlen and flen.
6346         (riscv_call_info) <xlen, flen>: Update comment.
6347         (riscv_call_arg_struct): Remove invalid assertions
6348         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6349         is removed.
6350         (riscv_gdbarch_init): Gather isa features and abi features
6351         separately, ensure both match on the gdbarch when reusing an old
6352         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6353         a target with 64-bit float hardware.
6354
6355 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6356
6357         * source.c (search_command_helper): Stop reverse search
6358         when line 1 has been searched.
6359
6360 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6361
6362         * record-full.c (record_full_base_target::close): Rewrite
6363         record_full_core_buf_list free logic.
6364
6365 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6366
6367         * break-catch-syscall.c (print_one_catch_syscall): xfree
6368         the last text.
6369
6370 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6371
6372         * top.c (print_gdb_version): Update Copyright year in version
6373         message.
6374
6375 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6376
6377         Update copyright year range in all GDB files.
6378
6379 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6380
6381         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6382
6383 For older changes see ChangeLog-2018.
6384 \f
6385 Local Variables:
6386 mode: change-log
6387 left-margin: 8
6388 fill-column: 74
6389 version-control: never
6390 coding: utf-8
6391 End:
6392