gdb/ChangeLog

   1 2019-09-25  Tom Tromey  <tom@tromey.com>
   2
   3         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
   4         * utils.h (make_hex_string): Don't declare.
   5         * utils.c (make_hex_string): Remove.
   6
   7 2019-09-24  Tom de Vries  <tdevries@suse.de>
   8
   9         PR gdb/23815
  10         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
  11         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
  12
  13 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
  14
  15         * NEWS: Mention new simulator port for PRU.
  16
  17 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
  18
  19         * ada-exp.y (write_object_remaining): Update.
  20         * ada-lang.c (ada_decode): Return a std::string instead of a char*
  21         and eliminate the static buffer.
  22         (ada_decode_symbol): Update.
  23         (ada_la_decode): Update.
  24         (ada_sniff_from_mangled_name): Update.
  25         (is_valid_name_for_wild_match): Update.
  26         (ada_lookup_name_info::matches): Update and simplify.
  27         (name_matches_regex): Update.
  28         (ada_add_global_exceptions): Update.
  29         * ada-lang.h (ada_decode): Update signature.
  30         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
  31         * dwarf-index-write.c (debug_names::insert): Update.
  32
  33 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
  34
  35         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
  36         formatting.
  37
  38 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
  39
  40         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
  41         Change "nonzero" to "true" in documentation.
  42
  43 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
  44
  45         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
  46         (_initialize_darwin_solib): Don't set
  47         darwin_so_ops.lookup_lib_global_symbol.
  48         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
  49         set_gdbarch_iterate_over_objfiles_in_search_order.
  50         (elf_lookup_lib_symbol): Rename to...
  51         (svr4_iterate_over_objfiles_in_search_order): this, and update
  52         to iterate semantics.
  53         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
  54         * solib.c (solib_global_lookup): Remove.
  55         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
  56         (solib_global_lookup): Remove.
  57         * symtab.c (lookup_global_or_static_symbol): Remove call to
  58         solib_global_lookup.
  59
  60 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
  61
  62         * NEWS: Move entries about default MI version now being
  63         version 3, and about the GDB/MI fix for multi-location
  64         breakpoints to the "since GDB 8.3" section.
  65
  66 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
  67
  68         GDB 8.3.1 released.
  69
  70 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
  71
  72         * NEWS: Mention that Cell/B.E. debugging support was removed.
  73         * MAINTAINERS: Remove spu target.
  74
  75         * config/djgpp/fnchange.lst: Remove entries for removed files.
  76
  77         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
  78         spu-multiarch.o, and spu-tdep.o.
  79         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
  80         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
  81         spu-multiarch.c, and spu-tdep.c.
  82         * spu-linux-nat.c: Remove file.
  83         * spu-multiarch.c: Remove file.
  84         * spu-tdep.c: Remove file.
  85         * spu-tdep.h: Remove file.
  86         * solib-spu.c: Remove file.
  87         * solib-spu.h: Remove file.
  88
  89         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
  90         * configure.nat (spu-linux): Remove.
  91         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
  92         solib-multiarch.o from gdb_target_obs.
  93         (spu*-*-*): Remove.
  94
  95         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
  96         feature flag.
  97         (ppc_linux_no_features): Update.
  98         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
  99         Cell/B.E. support.
 100         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 101         (tdesc_powerpc_cell64l): Likewise.
 102         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 103         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 104         Cell/B.E. support.
 105         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 106         Do not include "features/rs6000/powerpc-cell32l.c" or
 107         "features/rs6000/powerpc-cell64l.c".
 108         (ppc_linux_spu_section): Remove.
 109         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 110         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 111         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 112         (ppc_linux_spe_context_lookup): Remove.
 113         (ppc_linux_spe_context_inferior_created): Remove.
 114         (ppc_linux_spe_context_solib_loaded): Remove.
 115         (ppc_linux_spe_context_solib_unloaded): Remove.
 116         (ppc_linux_spe_context): Remove.
 117         (struct ppu2spu_cache): Remove.
 118         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 119         (struct ppu2spu_data): Remove.
 120         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 121         ppu2spu_unwind): Remove.
 122         (ppc_linux_init_abi): Remove Cell/B.E. support.
 123         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 124
 125         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 126         (rs6000/powerpc-cell64l-expedite): Likewise
 127         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 128         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 129         rs6000/powerpc-cell64l.xml.
 130         * features/rs6000/powerpc-cell32l.xml: Remove.
 131         * features/rs6000/powerpc-cell64l.xml: Likewise.
 132         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 133         * features/rs6000/powerpc-cell64l.c: Likewise.
 134         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 135         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 136         * regformats/reg-spu.dat: Remove.
 137
 138         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 139         * corelow.c (struct spuid_list): Remove.
 140         (add_to_spuid_list): Remove.
 141         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 142         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 143         (remote_protocol_features): Remove associated entries.
 144         (_initialize_remote): No longer initialize them.
 145         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 146         * linux-nat.c (SPUFS_MAGIC): Remove.
 147         (linux_proc_xfer_spu): Remove.
 148         (spu_enumerate_spu_ids): Remove.
 149         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 150         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 151         (linux_make_corefile_notes): No longer call it.
 152
 153         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 154         (cooked_write_test): Likewise.
 155
 156 2019-09-20  Tom Tromey  <tom@tromey.com>
 157
 158         * NEWS: Mention case-sensitivity of TUI commands.
 159         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 160         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 161         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 162
 163 2019-09-20  Tom Tromey  <tom@tromey.com>
 164
 165         * tui/tui-source.c (tui_source_window::set_contents): Use
 166         make_unique_xstrdup.
 167         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 168         make_unique_xstrdup.
 169
 170 2019-09-20  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-data.c: Remove separator comments.
 173         * tui/tui-layout.c: Remove separator comments.
 174         * tui/tui-win.c: Remove separator comments.
 175         * tui/tui-wingeneral.c: Remove separator comments.
 176
 177 2019-09-20  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui.h (strcat_to_buf): Don't declare.
 180         * tui/tui.c (strcat_to_buf): Remove.
 181
 182 2019-09-20  Tom Tromey  <tom@tromey.com>
 183
 184         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 185         from "fullname".
 186         * tui/tui-source.c (tui_source_window::set_contents)
 187         (tui_source_window::location_matches_p)
 188         (tui_source_window::maybe_update): Update.
 189
 190 2019-09-20  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 193         Update.
 194         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 195         prefix.
 196         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 197         (tui_data_window::line_from_reg_element_no)
 198         (tui_data_window::first_reg_element_no_inline)
 199         (tui_data_window::show_registers)
 200         (tui_data_window::show_register_group)
 201         (tui_data_window::display_registers_from)
 202         (tui_data_window::display_registers_from_line)
 203         (tui_data_window::first_data_item_displayed)
 204         (tui_data_window::delete_data_content_windows)
 205         (tui_data_window::erase_data_content)
 206         (tui_data_window::do_scroll_vertical)
 207         (tui_data_window::refresh_window)
 208         (tui_data_window::check_register_values): Update.
 209
 210 2019-09-20  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 213         (struct tui_locator_window) <full_name, proc_name>: Now
 214         std::string.
 215         * tui/tui-stack.c (tui_locator_window::make_status_line)
 216         (tui_locator_window::set_locator_fullname)
 217         (tui_locator_window::set_locator_info): Update.
 218         * tui/tui-source.c (tui_source_window::set_contents)
 219         (tui_source_window::showing_source_p): Update.
 220
 221 2019-09-20  Tom Tromey  <tom@tromey.com>
 222
 223         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 224         Don't call tui_locator_win_info_ptr.
 225
 226 2019-09-20  Tom Tromey  <tom@tromey.com>
 227
 228         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 229
 230 2019-09-20  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 233         height for locator.
 234         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 235         * tui/tui-layout.c (show_source_disasm_command, show_data)
 236         (show_source_or_disasm_and_command): Use 1 as height for locator.
 237
 238 2019-09-20  Tom Tromey  <tom@tromey.com>
 239
 240         * tui/tui.c (tui_enable): Update.
 241         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 242         Update.
 243         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 244         Update.
 245         * tui/tui-data.c (win_resized): Now bool.
 246         (tui_win_resized): Return bool.
 247         (tui_set_win_resized_to): Accept a bool.
 248
 249 2019-09-20  Tom Tromey  <tom@tromey.com>
 250
 251         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 252         Change type of "refresh_values_only".
 253         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 254         type of "refresh_values_only".
 255
 256 2019-09-20  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 259         std::string.
 260         (tui_disassemble): Add "pos" parameter.
 261         (tui_disasm_window::set_contents): Simplify.
 262
 263 2019-09-20  Tom Tromey  <tom@tromey.com>
 264
 265         * tui/tui-winsource.h (struct tui_source_window_base)
 266         <show_source_content>: Now private.
 267         * tui/tui-winsource.c
 268         (tui_source_window_base::show_source_content): Don't handle empty
 269         content case.
 270
 271 2019-09-20  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-layout.c (show_source_disasm_command)
 274         (show_source_or_disasm_and_command): Don't call
 275         show_source_content.
 276
 277 2019-09-20  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 280         Declare.
 281         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 282         from tui_make_status_line.
 283         (tui_locator_window::rerender): Update.
 284
 285 2019-09-20  Tom Tromey  <tom@tromey.com>
 286
 287         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 288         (tui_locator_window::rerender): Update.
 289
 290 2019-09-20  Tom Tromey  <tom@tromey.com>
 291
 292         * tui/tui-winsource.h (struct tui_source_window_base)
 293         <~tui_source_window_base>: Don't declare.
 294         <fullname>: Remove.
 295         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 296         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 297         member.
 298         * tui/tui-source.c (tui_source_window::set_contents): Update.
 299         (tui_source_window::location_matches_p)
 300         (tui_source_window::maybe_update): Update.
 301
 302 2019-09-20  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-winsource.h (~tui_source_element): Remove.
 305         (tui_source_element): Update.
 306         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 307         * tui/tui-winsource.c (tui_show_source_line): Update.
 308         * tui/tui-source.c (tui_source_window::set_contents): Update.
 309         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 310
 311 2019-09-20  Tom Tromey  <tom@tromey.com>
 312
 313         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 314         declare.
 315         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 316         tui_clear_source_windows_detail.
 317         * tui/tui-winsource.h (struct tui_source_window_base)
 318         <clear_detail>: Don't declare.
 319         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 320         Remove.
 321         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 322
 323 2019-09-20  Tom Tromey  <tromey@adacore.com>
 324
 325         PR ada/24919:
 326         * block.c (contained_in): Fix final return value.
 327
 328 2019-09-20  Alan Modra  <amodra@gmail.com>
 329
 330         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 331         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 332         (read_indirect_string_from_dwz): Use bfd accessor.
 333         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 334         * machoread.c (macho_symfile_read_all_oso): Likewise.
 335         * solib.c (solib_bfd_open): Likewise.
 336
 337 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 338
 339         * eval.c: Move declaration of overload_resolution to...
 340         * value.h: ...here.
 341
 342 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 343
 344         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 345         * arm-linux-tdep.c: Likewise.
 346         * arm-nbsd-nat.c: Likewise.
 347         * arm-tdep.h: Declare arm_apcs_32.
 348         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 349
 350 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 351
 352         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 353         * dwarf2read.h: Declare dwarf_always_disassemble.
 354
 355 2019-09-19  Tom de Vries  <tdevries@suse.de>
 356
 357         PR gdb/25009
 358         * source-cache.c (source_cache::ensure): Catch exception thrown during
 359         construction of the highlighter.
 360
 361 2019-09-18  Alan Modra  <amodra@gmail.com>
 362
 363         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 364         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 365         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 366         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 367         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 368         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 369         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 370         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 371         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 372         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 373         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 374         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 375         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 376         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 377         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 378         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 379         * mi/mi-interp.c: Update throughout for bfd section macro and
 380         function changes.
 381         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 382         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 383
 384 2019-09-18  Tom Tromey  <tom@tromey.com>
 385
 386         * NEWS: Add entry.
 387         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 388         call rl_initialize.
 389         (tui_enable): Do not call rl_initialize.
 390
 391 2019-09-18  Christian Groessler  <chris@groessler.org>
 392
 393         * alpha-linux-nat.c: Include gdbarch.h.
 394
 395 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 396
 397         * ui-file.c: Include cli/cli-style.h.
 398         (term_cli_styling): Remove cli_styling declaration.
 399
 400 2019-09-18  Alan Modra  <amodra@gmail.com>
 401
 402         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 403         to bfd_asymbol_section.
 404
 405 2019-09-18  Alan Modra  <amodra@gmail.com>
 406
 407         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 408         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 409         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 410
 411 2019-09-18  Alan Modra  <amodra@gmail.com>
 412
 413         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 414         * spu-linux-nat.c (spu_bfd_open): Likewise.
 415
 416 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 417
 418         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 419         to bool to match definition in dwarf2read.c.
 420
 421 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 422
 423         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 424         (print_signatures): Likewise.
 425         (trust_pad_over_xvs): Likewise.
 426         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 427         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 428         * arm-linux-nat.c (arm_apcs_32): Likewise.
 429         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 430         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 431         * arm-tdep.c (arm_debug): Likewise.
 432         (arm_apcs_32): Likewise.
 433         * auto-load.c (debug_auto_load): Likewise.
 434         (auto_load_gdb_scripts): Likewise.
 435         (global_auto_load): Likewise.
 436         (auto_load_local_gdbinit): Likewise.
 437         (auto_load_local_gdbinit_loaded): Likewise.
 438         * auto-load.h (global_auto_load): Likewise.
 439         (auto_load_local_gdbinit): Likewise.
 440         (auto_load_local_gdbinit_loaded): Likewise.
 441         * breakpoint.c (disconnected_dprintf): Likewise.
 442         (breakpoint_proceeded): Likewise.
 443         (automatic_hardware_breakpoints): Likewise.
 444         (always_inserted_mode): Likewise.
 445         (target_exact_watchpoints): Likewise.
 446         (_initialize_breakpoint): Update.
 447         * breakpoint.h (target_exact_watchpoints): Change to bool.
 448         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 449         * cli/cli-cmds.c (trace_commands): Likewise.
 450         * cli/cli-cmds.h (trace_commands): Likewise.
 451         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 452         to bool*.
 453         * cli/cli-logging.c (logging_overwrite): Change to bool.
 454         (logging_redirect): Likewise.
 455         (debug_redirect): Likewise.
 456         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 457         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 458         to bool.
 459         <boolean_option_def>: Update.
 460         (struct flag_option_def): Change default type of Context to bool
 461         from int.
 462         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 463         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 464         (get_setshow_command_value_string): Likewise.
 465         * cli/cli-style.c (cli_styling): Change to bool.
 466         (source_styling): Likewise.
 467         * cli/cli-style.h (source_styling): Likewise.
 468         (cli_styling): Likewise.
 469         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 470         to bool.
 471         * command.h (var_types): Update comment.
 472         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 473         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 474         bool.
 475         (debug_compile_cplus_scopes): Likewise.
 476         * compile/compile-internal.h (compile_debug): Likewise.
 477         * compile/compile.c (compile_debug): Likewise.
 478         (struct compile_options) <raw>: Likewise.
 479         * cp-support.c (catch_demangler_crashes): Likewise.
 480         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 481         (usr_cmd_cris_dwarf2_cfi): Likewise.
 482         * csky-tdep.c (csky_debug): Likewise.
 483         * darwin-nat.c (enable_mach_exceptions): Likewise.
 484         * dcache.c (dcache_enabled_p): Likewise.
 485         * defs.h (info_verbose): Likewise.
 486         * demangle.c (demangle): Likewise.
 487         (asm_demangle): Likewise.
 488         * dwarf-index-cache.c (debug_index_cache): Likewise.
 489         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 490         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 491         * dwarf2read.c (check_physname): Likewise.
 492         (use_deprecated_index_sections): Likewise.
 493         (dwarf_always_disassemble): Likewise.
 494         * eval.c (overload_resolution): Likewise.
 495         * event-top.c (set_editing_cmd_var): Likewise.
 496         (exec_done_display_p): Likewise.
 497         * event-top.h (set_editing_cmd_var): Likewise.
 498         (exec_done_display_p): Likewise.
 499         * exec.c (write_files): Likewise.
 500         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 501         (debug_fbsd_nat): Likewise.
 502         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 503         Likewise.
 504         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 505         <backtrace_past_entry> Likewise.
 506         * gdb-demangle.h (demangle): Likewise.
 507         (asm_demangle): Likewise.
 508         * gdb_bfd.c (bfd_sharing): Likewise.
 509         * gdbcore.h (write_files): Likewise.
 510         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 511         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 512         * gdbthread.h (print_thread_events): Likewise.
 513         * gdbtypes.c (opaque_type_resolution): Likewise.
 514         (strict_type_checking): Likewise.
 515         * gnu-nat.c (gnu_debug_flag): Likewise.
 516         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 517         * guile/scm-param.c (pascm_variable): Add boolval.
 518         (add_setshow_generic): Update.
 519         (pascm_param_value): Update.
 520         (pascm_set_param_value_x): Update.
 521         * hppa-tdep.c (hppa_debug): Change to bool..
 522         * infcall.c (may_call_functions_p): Likewise.
 523         (coerce_float_to_double_p): Likewise.
 524         (unwind_on_signal_p): Likewise.
 525         (unwind_on_terminating_exception_p): Likewise.
 526         * infcmd.c (startup_with_shell): Likewise.
 527         * inferior.c (print_inferior_events): Likewise.
 528         * inferior.h (startup_with_shell): Likewise.
 529         (print_inferior_events): Likewise.
 530         * infrun.c (step_stop_if_no_debug): Likewise.
 531         (detach_fork): Likewise.
 532         (debug_displaced): Likewise.
 533         (disable_randomization): Likewise.
 534         (non_stop): Likewise.
 535         (non_stop_1): Likewise.
 536         (observer_mode): Likewise.
 537         (observer_mode_1): Likewise.
 538         (set_observer_mode): Update.
 539         (sched_multi): Change to bool.
 540         * infrun.h (debug_displaced): Likewise.
 541         (sched_multi): Likewise.
 542         (step_stop_if_no_debug): Likewise.
 543         (non_stop): Likewise.
 544         (disable_randomization): Likewise.
 545         * linux-tdep.c (use_coredump_filter): Likewise.
 546         (dump_excluded_mappings): Likewise.
 547         * linux-thread-db.c (auto_load_thread_db): Likewise.
 548         (check_thread_db_on_load): Likewise.
 549         * main.c (captured_main_1): Update.
 550         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 551         xx2_opt, boolean_opt>: Change to bool.
 552         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 553         * maint.c (maintenance_profile_p): Likewise.
 554         (per_command_time): Likewise.
 555         (per_command_space): Likewise.
 556         (per_command_symtab): Likewise.
 557         * memattr.c (inaccessible_by_default): Likewise.
 558         * mi/mi-main.c (mi_async): Likewise.
 559         (mi_async_1): Likewise.
 560         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 561         * nat/fork-inferior.h (startup_with_shell): Likewise.
 562         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 563         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 564         * nios2-tdep.c (nios2_debug): Likewise.
 565         * or1k-tdep.c (or1k_debug): Likewise.
 566         * parse.c (parser_debug): Likewise.
 567         * parser-defs.h (parser_debug): Likewise.
 568         * printcmd.c (print_symbol_filename): Likewise.
 569         * proc-api.c (procfs_trace): Likewise.
 570         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 571         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 572         (set_parameter_value): Update.
 573         (add_setshow_generic): Update.
 574         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 575         to bool*.
 576         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 577         int*.
 578         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 579         * record-btrace.c (record_btrace_target::store_registers): Update.
 580         * record-full.c (record_full_memory_query): Change to bool.
 581         (record_full_stop_at_limit): Likewise.
 582         * record-full.h (record_full_memory_query): Likewise.
 583         * remote-notif.c (notif_debug): Likewise.
 584         * remote-notif.h (notif_debug): Likewise.
 585         * remote.c (use_range_stepping): Likewise.
 586         (interrupt_on_connect): Likewise.
 587         (remote_break): Likewise.
 588         * ser-tcp.c (tcp_auto_retry): Likewise.
 589         * ser-unix.c (serial_hwflow): Likewise.
 590         * skip.c (debug_skip): Likewise.
 591         * solib-aix.c (solib_aix_debug): Likewise.
 592         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 593         (spu_auto_flush_cache_p): Likewise.
 594         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 595         Likewise.
 596         (struct info_print_options) <quiet>: Likewise.
 597         * symfile-debug.c (debug_symfile): Likewise.
 598         * symfile.c (auto_solib_add): Likewise.
 599         (separate_debug_file_debug): Likewise.
 600         * symfile.h (auto_solib_add): Likewise.
 601         (separate_debug_file_debug): Likewise.
 602         * symtab.c (basenames_may_differ): Likewise.
 603         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 604         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 605         (struct info_types_options) <quiet>: Likewise.
 606         * symtab.h (demangle): Likewise.
 607         (basenames_may_differ): Likewise.
 608         * target-dcache.c (stack_cache_enabled_1): Likewise.
 609         (code_cache_enabled_1): Likewise.
 610         * target.c (trust_readonly): Likewise.
 611         (may_write_registers): Likewise.
 612         (may_write_memory): Likewise.
 613         (may_insert_breakpoints): Likewise.
 614         (may_insert_tracepoints): Likewise.
 615         (may_insert_fast_tracepoints): Likewise.
 616         (may_stop): Likewise.
 617         (auto_connect_native_target): Likewise.
 618         (target_stop_and_wait): Update.
 619         (target_async_permitted): Change to bool.
 620         (target_async_permitted_1): Likewise.
 621         (may_write_registers_1): Likewise.
 622         (may_write_memory_1): Likewise.
 623         (may_insert_breakpoints_1): Likewise.
 624         (may_insert_tracepoints_1): Likewise.
 625         (may_insert_fast_tracepoints_1): Likewise.
 626         (may_stop_1): Likewise.
 627         * target.h (target_async_permitted): Likewise.
 628         (may_write_registers): Likewise.
 629         (may_write_memory): Likewise.
 630         (may_insert_breakpoints): Likewise.
 631         (may_insert_tracepoints): Likewise.
 632         (may_insert_fast_tracepoints): Likewise.
 633         (may_stop): Likewise.
 634         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 635         (make_thread_apply_all_options_def_group): Change argument from int*
 636         to bool*.
 637         (thread_apply_all_command): Update.
 638         (print_thread_events): Change to bool.
 639         * top.c (confirm): Likewise.
 640         (command_editing_p): Likewise.
 641         (history_expansion_p): Likewise.
 642         (write_history_p): Likewise.
 643         (info_verbose): Likewise.
 644         * top.h (confirm): Likewise.
 645         (history_expansion_p): Likewise.
 646         * tracepoint.c (disconnected_tracing): Likewise.
 647         (circular_trace_buffer): Likewise.
 648         * typeprint.c (print_methods): Likewise.
 649         (print_typedefs): Likewise.
 650         * utils.c (debug_timestamp): Likewise.
 651         (sevenbit_strings): Likewise.
 652         (pagination_enabled): Likewise.
 653         * utils.h (sevenbit_strings): Likewise.
 654         (pagination_enabled): Likewise.
 655         * valops.c (overload_resolution): Likewise.
 656         * valprint.h (struct value_print_options) <prettyformat_arrays,
 657         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 658         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 659         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 660         Likewise.
 661         * windows-nat.c (new_console): Likewise.
 662         (cygwin_exceptions): Likewise.
 663         (new_group): Likewise.
 664         (debug_exec): Likewise.
 665         (debug_events): Likewise.
 666         (debug_memory): Likewise.
 667         (debug_exceptions): Likewise.
 668         (useshell): Likewise.
 669         * windows-tdep.c (maint_display_all_tib): Likewise.
 670         * xml-support.c (debug_xml): Likewise.
 671
 672 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 673
 674         * source.c (prepare_path_for_appending): New function.
 675         (openp): Make use of new function.
 676         (find_and_open_source): Search for the compilation directory and
 677         source file as a relative path beneath the directory search path.
 678
 679 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 680
 681         * source-cache.c (source_cache::get_line_charpos): Catch
 682         exceptions and return false, this matches the behaviour documented
 683         in the header file.
 684
 685 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 686
 687         * ada-tasks.c (info_task): Remove quoting of the task's name.
 688
 689 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 690
 691         * symfile.c (auto_solib_add): Replace comment with a reference
 692         to the header file.
 693
 694 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 695
 696         * NEWS: Mention that gdb can now be compiled with Python 3
 697         on Windows.
 698
 699 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 700
 701         * maint.c (maint_print_section_data::maint_print_section_data):
 702         Force use of 'float log10 (float)' by casting the argument to
 703         float.
 704
 705 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 706
 707         * maint.c: Add 'cmath' include.
 708         (struct maint_print_section_data): New structure.
 709         (print_section_index): New function.
 710         (print_bfd_section_info): Add header comment, small whitespace
 711         cleanup, and update to call new print_section_index function.
 712         (print_objfile_section_info): Likewise.
 713         (maint_obj_section_from_bfd_section): New function.
 714         (print_bfd_section_info_maybe_relocated): New function.
 715         (maintenance_info_sections): Add header comment, always use
 716         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 717
 718 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 719
 720         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 721         inner scope, add check that the objfile has psymtabs before
 722         checking psymtabs_addrmap.
 723         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 724
 725 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 726
 727         * NEWS: Announce that Ada task names are now shown at more places,
 728         and between quotes (except in info task output).
 729         * gdb/ada-tasks.c (task_to_str): New function.
 730         (display_current_task_id): Call task_to_str.
 731         (task_command_1): Likewise.
 732         (print_ada_task_info): In non-mi mode, Properly align headers and data
 733         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 734
 735 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 736
 737         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 738         prstatus.pr_lwp.pr_info instead of making it up.
 739
 740 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 741
 742         * auto-load.c (auto_load_expand_dir_vars): Update.
 743         * defs.h (gdb_datadir): Change to std::string.
 744         (python_libdir): Likewise.
 745         (relocate_gdb_directory): Change return type to std::string.
 746         * guile/guile.c (gdbscm_data_directory): Update.
 747         (initialize_scheme_side): Update.
 748         * jit.c (jit_reader_dir): Change to std::string.
 749         (jit_reader_load_command): Update.
 750         * main.c (gdb_datadir): Change to std::string.
 751         (python_libdir): Likewise.
 752         (set_gdb_data_directory): Update.
 753         (relocate_path): Change to return std::string.
 754         (relocate_gdb_directory): Change to return std::string.
 755         (relocate_gdbinit_path_maybe_in_datadir): Update.
 756         (captured_main_1): Update.
 757         * python/python.c (do_start_initialization): Update.
 758         * top.c (show_gdb_datadir): Update.
 759         * xml-syscall.c (xml_init_syscalls_info): Update.
 760         (init_syscalls_info): Update.
 761
 762 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 763
 764         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 765         out of get_init_files.
 766         (get_init_files): Update.
 767
 768 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 769
 770         * main.c (get_init_files): Change to use std::string.
 771         (captured_main_1): Update.
 772         (print_gdb_help): Update.
 773
 774 2019-09-11  Ali Tamur  <tamur@google.com>
 775
 776         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 777         implementation.
 778
 779 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 780
 781         * dbxread.c (read_dbx_symtab): Update.
 782         * dwarf2read.c (load_partial_dies): Update.
 783         * mdebugread.c (parse_partial_symbols): Update.
 784         (handle_psymbol_enumerators): Update.
 785         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 786         * psymtab.c (add_psymbol_to_bcache): Likewise.
 787         (add_psymbol_to_list): Likewise.
 788         * symtab.c (symbol_set_names): Likewise.
 789         * symtab.h (symbol_set_names): Likewise.
 790         * xcoffread.c (scan_xcoff_symtab): Update.
 791
 792 2019-09-11  Tom Tromey  <tom@tromey.com>
 793
 794         * symfile-mem.c (symbol_file_add_from_memory): Use
 795         bfd_set_filename.
 796         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 797         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 798
 799 2019-09-10  Tom Tromey  <tromey@adacore.com>
 800
 801         * dwarf-index-write.c (write_psymbols): Extend error message.
 802         (debug_names::insert): Add Ada code.
 803         (debug_names::write_psymbols): Remove Ada check.
 804         (debug_names) <m_string_obstack>: New member.
 805         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 806         (gdb_index_symbol_name_matcher::matches): Remove.
 807         (mapped_index_base::find_name_components_bounds): Add "lang"
 808         parameter.
 809         (mapped_index_base::build_name_components): Also split names
 810         according to Ada syntax.
 811         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 812         type of "match_callback".
 813         (check_match, check_find_bounds_finds)
 814         (dw2_expand_symtabs_matching): Update.
 815         (dw2_debug_names_iterator): Add new constructor.
 816         (dw2_debug_names_map_matching_symbols): New function.
 817         (dw2_debug_names_expand_symtabs_matching): Update.
 818         (dwarf2_debug_names_functions): Use
 819         dw2_debug_names_map_matching_symbols.
 820
 821 2019-09-10  Tom Tromey  <tromey@adacore.com>
 822
 823         * dwarf2read.c (dw2_get_file_names_reader): Add the
 824         CU's file name to the results.
 825
 826 2019-09-10  Tom Tromey  <tromey@adacore.com>
 827
 828         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 829         map_matching_symbols.  Update.
 830         * dwarf2read.c (dw2_map_matching_symbols): Update.
 831         * psymtab.c (match_partial_symbol): Change type; update.
 832         (psym_map_matching_symbols): Likewise.
 833         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 834         type; update.
 835         * symfile.h (struct quick_symbol_functions)
 836         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 837         Remove "match".
 838
 839 2019-09-10  Tom Tromey  <tromey@adacore.com>
 840
 841         * psymtab.c (map_block): Remove.
 842         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 843         * symtab.c (iterate_over_symbols_terminated): New function.
 844         * symtab.c (iterate_over_symbols_terminated): Declare.
 845
 846 2019-09-10  Tom Tromey  <tromey@adacore.com>
 847
 848         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 849         * language.h (struct language_defn) <la_iterate_over_symbols>:
 850         Return bool.
 851         * symtab.c (iterate_over_symbols): Return bool.
 852         * symtab.h (iterate_over_symbols): Return bool.
 853
 854 2019-09-10  Tom Tromey  <tromey@adacore.com>
 855
 856         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 857         (add_nonlocal_symbols): Update.
 858         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 859         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 860         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 861         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 862         Change type of "callback".  Remove "data".
 863
 864
 865 2019-09-09  Ali Tamur  <tamur@google.com>
 866
 867         * dwarf2read.c (comp_unit_head): Update comment.
 868         (dwarf2_dwo_name): New function declaration.
 869         (dwarf_unit_type_name): New function declaration.
 870         (read_comp_unit_head): Add support for new compilation units,
 871         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 872         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 873         (currently named as "signature") in their header. Also clarify error
 874         messages.
 875         (lookup_dwo_id): New function. Returns the dwo id of the given
 876         compile unit.
 877         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 878         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 879         functions.
 880         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 881         (dwarf2_dwo_name): Get the dwo name if present.
 882         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 883         purposes.
 884
 885 2019-09-09  Tom Tromey  <tom@tromey.com>
 886
 887         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 888
 889 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 890
 891         * python/python.c (do_start_initialization): Make progname_copy static,
 892         to avoid a leak report.
 893
 894 2019-09-08  Tom Tromey  <tom@tromey.com>
 895
 896         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 897
 898 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 899
 900         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 901         Change type to gdb::optional<block_enum>.
 902         (dw2_symtab_iter_init): Change block_index parameter type
 903         to gdb::optional<block_enum>.
 904         (dw2_lookup_symbol): Change block_index parameter
 905         type to block_enum.c
 906         (dw2_debug_names_lookup_symbol): Likewise.
 907         * psymtab.c (psym_lookup_symbol): Likewise.
 908         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 909         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 910         Likewise.
 911
 912 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 913
 914         * defs.h (relocate_gdb_directory): Change int to bool in
 915         signature and rename flag to relocatable.
 916         * main.c (relocate_path): Likewise.
 917         (relocate_gdb_directory): Likewise.
 918
 919 2019-09-06  Alan Modra  <amodra@gmail.com>
 920
 921         * coffread.c (coff_symfile_read): Constify filename variable.
 922         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 923         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 924         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 925         * solib.c (reload_shared_libraries_1): Likewise.
 926         * symfile.c (reread_symbols): Likewise.
 927         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 928         * solib-darwin.c (darwin_bfd_open): Likewise.
 929         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 930
 931 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 932
 933         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 934         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 935
 936 2019-09-03  Tom Tromey  <tromey@adacore.com>
 937
 938         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 939         types.
 940         (has_negatives): Unbias a range type bound.
 941         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 942         * gdbtypes.c (operator==): Handle new field.
 943         (create_range_type): Add "bias" parameter.
 944         (create_static_range_type, resolve_dynamic_range): Update.
 945         * gdbtypes.h (struct range_bounds) <bias>: New member.
 946         (create_range_type): Add bias parameter.
 947         * printcmd.c (print_scalar_formatted): Unbias range types.
 948         * value.c (unpack_long): Unbias range types.
 949         (pack_long): Bias range types.
 950
 951 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 952
 953         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 954         probe arguments.
 955
 956 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 957
 958         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 959         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 960         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 961         (compile_probe_arg): Likewise.
 962         * probe.h (get_argument_count): Likewise.
 963         * solib-svr4.c (solib_event_probe_action): Likewise.
 964         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 965
 966 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 967
 968         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 969         code to here...
 970         (svr4_create_solib_event_breakpoints): ...from here.
 971
 972 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 973
 974         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 975         suffix from warning message.
 976
 977 2019-08-30  Tom Tromey  <tom@tromey.com>
 978
 979         * tui/tui-winsource.h (struct tui_source_window_base)
 980         <refresh_all>: Don't declare.
 981         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 982         Remove.
 983         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 984         tui_show_locator_content.
 985         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 986         declare.
 987         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 988         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 989         declare.
 990
 991 2019-08-30  Tom Tromey  <tom@tromey.com>
 992
 993         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 994
 995 2019-08-30  Tom Tromey  <tom@tromey.com>
 996
 997         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 998         Remove unnecessary forward declarations.
 999
1000 2019-08-30  Tom Tromey  <tom@tromey.com>
1001
1002         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1003         rerender.
1004         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1005         tui_show_locator_content.
1006
1007 2019-08-30  Tom Tromey  <tom@tromey.com>
1008
1009         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1010         (tui_locator_window::rerender): Rewrite using body of previous
1011         tui_show_locator_content.
1012
1013 2019-08-30  Tom Tromey  <tom@tromey.com>
1014
1015         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1016         set_locator_fullname>: New methods.
1017         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1018         Rename from tui_set_locator_fullname.
1019         (tui_locator_window::set_locator_info): Rename from
1020         tui_set_locator_info.  Return bool.
1021         (tui_update_locator_fullname, tui_show_frame_info): Update.
1022
1023 2019-08-30  Tom Tromey  <tom@tromey.com>
1024
1025         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1026
1027 2019-08-30  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1030         call touchwin.
1031
1032 2019-08-30  Tom Tromey  <tom@tromey.com>
1033
1034         * tui/tui-wingeneral.c (box_win): Assume win_info and
1035         win_info->handle cannot be NULL.
1036
1037 2019-08-30  Tom Tromey  <tom@tromey.com>
1038
1039         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1040         refresh_window>: Declare.
1041         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1042         resize.
1043         (tui_data_item_window::rerender): Rename from
1044         tui_display_register.
1045         (tui_data_item_window::refresh_window): New method.
1046         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1047         no-op.
1048
1049 2019-08-30  Tom Tromey  <tom@tromey.com>
1050
1051         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1052         regs_column_count, current_group>: Move later.  Now private.
1053         <get_current_group>: New method.
1054         * tui/tui-regs.c (tui_reg_command): Update.
1055         * tui/tui-layout.c (tui_set_layout): Update.
1056
1057 2019-08-30  Tom Tromey  <tom@tromey.com>
1058
1059         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1060         (tui_data_window::rerender): Don't call
1061         check_and_display_highlight_if_needed.
1062         (tui_data_window::refresh_all): Remove call to
1063         erase_data_content.
1064
1065 2019-08-30  Tom Tromey  <tom@tromey.com>
1066
1067         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1068         (tui_data_window::display_registers_from)
1069         (tui_data_window::display_reg_element_at_line)
1070         (tui_data_window::display_registers_from_line): Remove checks of
1071         "empty".
1072
1073 2019-08-30  Tom Tromey  <tom@tromey.com>
1074
1075         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1076         Don't declare.
1077         * tui/tui-regs.c (tui_data_window::show_registers): Call
1078         rerender.
1079         (tui_data_window::rerender): Rename from display_all_data.
1080         (tui_data_window::rerender): Remove old implementation.
1081
1082 2019-08-30  Tom Tromey  <tom@tromey.com>
1083
1084         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1085         text.
1086         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1087
1088 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1089             Sergio Durigan Junior  <sergiodj@redhat.com>
1090
1091         PR win32/24284
1092         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1093
1094 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1095
1096         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1097         when searching for types.
1098
1099 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1100
1101         * f-lang.c (f_language_defn): Use f_print_typedef.
1102         * f-lang.h (f_print_typedef): Declare.
1103         * f-typeprint.c (f_print_typedef): Define.
1104
1105 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1106
1107         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1108
1109 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1110
1111         * cli/cli-utils.c (info_print_options_defs): Delete.
1112         (make_info_print_options_def_group): Delete.
1113         (extract_info_print_options): Delete.
1114         (info_print_command_completer): Delete.
1115         (info_print_args_help): Add extra parameter, and optionally
1116         include text about -n flag.
1117         * cli/cli-utils.h (struct info_print_options): Delete.
1118         (extract_info_print_options): Delete declaration.
1119         (info_print_command_completer): Delete declaration.
1120         (info_print_args_help): Add extra parameter, extend header
1121         comment.
1122         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1123         search_symbols.
1124         * stack.c (struct info_print_options): New type.
1125         (info_print_options_defs): New file scoped variable.
1126         (make_info_print_options_def_group): New static function.
1127         (info_print_command_completer): New static function.
1128         (info_locals_command): Update to use new local functions.
1129         (info_args_command): Likewise.
1130         (_initialize_stack): Add extra parameter to calls to
1131         info_print_args_help.
1132         * symtab.c (search_symbols): Add extra parameter, use this to
1133         possibly excluse non-debug symbols.
1134         (symtab_symbol_info): Add extra parameter, which is passed on to
1135         search_symbols.
1136         (struct info_print_options): New type.
1137         (info_print_options_defs): New file scoped variable.
1138         (make_info_print_options_def_group): New static function.
1139         (info_print_command_completer): New static function.
1140         (info_variables_command): Update to use local functions, and pass
1141         extra parameter through to symtab_symbol_info.
1142         (info_functions_command): Likewise.
1143         (info_types_command): Pass additional argument through to
1144         symtab_symbol_info.
1145         (rbreak_command): Pass extra argument to search_symbols.
1146         (_initialize_symtab): Add extra arguments for calls to
1147         info_print_args_help, and update help text for 'info variables',
1148         'whereis', and 'info functions' commands.
1149         * symtab.h (search_symbols): Add extra argument to declaration.
1150         * NEWS: Mention new flags.
1151
1152 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1153
1154         * symtab.c (lookup_static_symbol): Call the new function (and move
1155         it down to be next to lookup_global_symbol).
1156         (struct global_sym_lookup_data): Add block_enum member and rename to...
1157         (struct global_or_static_sym_lookup_data): ...this.
1158         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1159         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1160         (lookup_symbol_global_or_static_iterator_cb): ...this.
1161         (lookup_global_or_static_symbol): New function.
1162         (lookup_global_symbol): Call new function.
1163
1164 2019-08-26  Tom de Vries  <tdevries@suse.de>
1165
1166         PR c++/24852
1167         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1168         when pc_probe.prob == NULL.
1169
1170 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1171
1172         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1173         variable symbol_linkage to symbol_linkage_.
1174
1175 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1176
1177         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1178         represent whether the symbol is static, dynamic, or we don't
1179         know.
1180
1181 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1182
1183         * gdb/rx-tdep.c (rx_register_names): New.
1184         (rx_register_name): Delete.
1185         (rx_psw_type): Delete.
1186         (rx_fpsw_type): Delete.
1187         (rx_register_type): Delete.
1188         (rx_gdbarch_init): Convert target-descriptions.
1189         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1190         * gdb/features/Makefile: Add rx.xml.
1191         * gdb/features/rx.xml: New.
1192         * gdb/features/rx.c: Generated.
1193         * gdb/NEWS: Mention target description support.
1194
1195 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1196
1197         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1198         *slot_ptr.
1199
1200 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1201
1202         * configure.ac: Don't check for 'dlfcn.h' (moved to
1203         gdbsupport/common.m4).
1204         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1205         'gdbsupport/'.
1206         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1207         * compile/compile-c-support.c: Include
1208         'gdbsupport/gdb-dlfcn.h'.
1209         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1210         * gdb-dlfcn.c: Move to...
1211         * gdbsupport/gdb-dlfcn.c: ... here.
1212         * gdb-dlfcn.h: Move to...
1213         * gdbsupport/gdb-dlfcn.h: ... here.
1214
1215 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1216
1217         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1218         the offset field signed.
1219
1220 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1221
1222         * python/lib/gdb/__init__.py (_execute_file): New function.
1223         * python/python.c (python_run_simple_file): Call gdb._execute_file
1224         on Windows.
1225
1226 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1229         all uses as this was never set to anything but a zero value.
1230
1231 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1232
1233         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1234
1235 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1236
1237         * tui/tui-data.h (tui_gen_win_info): Add an =default
1238         move constructor, required by some GCC versions.
1239
1240 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1241
1242         * go32-nat.c (go32_sysinfo): Add hygon_p.
1243
1244 2019-08-20  Tom Tromey  <tom@tromey.com>
1245
1246         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1247         line_from_reg_element_no, first_reg_element_no_inline,
1248         display_all_data, delete_data_content_windows,
1249         erase_data_content>: Now private.
1250
1251 2019-08-20  Tom Tromey  <tom@tromey.com>
1252
1253         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1254         (tui_unhighlight_win, tui_highlight_win)
1255         (tui_win_info::make_window): Update.
1256         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1257
1258 2019-08-20  Tom Tromey  <tom@tromey.com>
1259
1260         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1261         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1262         (MAX_PID_WIDTH): Move to tui-stack.c.
1263         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1264         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1265         (MAX_PID_WIDTH): Move from tui-data.h.
1266
1267 2019-08-20  Tom Tromey  <tom@tromey.com>
1268
1269         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1270         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1271         (box_win): Update.
1272         (tui_gen_win_info::make_window): Rename from tui_make_window.
1273         (tui_win_info::make_window): New method.
1274         (tui_gen_win_info::make_visible): Update.
1275         * tui/tui-source.c (tui_source_window::set_contents): Update.
1276         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1277         (tui_data_window::display_registers_from): Update.
1278         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1279         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1280         Declare.
1281         <can_box>: Remove.
1282         <title>: Remove.
1283         (struct tui_win_info) <make_window>: Declare.
1284         <can_box>: Now virtual.
1285         <title>: New member.
1286         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1287         * tui/tui-command.c (tui_cmd_window::resize): Update.
1288
1289 2019-08-20  Tom Tromey  <tom@tromey.com>
1290
1291         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1292         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1293         (tui_data_window::check_register_values): Update.
1294
1295 2019-08-20  Tom Tromey  <tom@tromey.com>
1296
1297         * tui/tui-regs.h (struct tui_data_window): Use
1298         DISABLE_COPY_AND_ASSIGN.
1299         <regs_content>: Change type, removing unique_ptr.
1300         <tui_data_window>: Add move constructor.
1301         * tui/tui-regs.c (tui_data_window::show_registers)
1302         (tui_data_window::show_register_group)
1303         (tui_data_window::display_registers_from)
1304         (tui_data_window::display_registers_from)
1305         (tui_data_window::first_data_item_displayed)
1306         (tui_data_window::delete_data_content_windows)
1307         (tui_data_window::rerender, tui_data_window::refresh_window)
1308         (tui_data_window::check_register_values): Update.
1309
1310 2019-08-20  Tom Tromey  <tom@tromey.com>
1311
1312         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1313         show_register_group>: Declare.
1314         (tui_show_register_group): Don't declare.
1315         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1316         tui_show_registers.
1317         (tui_data_window::show_register_group): Rename from
1318         tui_show_register_group.
1319         (tui_data_window::check_register_values, tui_reg_command):
1320         Update.
1321         * tui/tui-layout.c (tui_set_layout): Update.
1322
1323 2019-08-20  Tom Tromey  <tom@tromey.com>
1324
1325         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1326         Declare.
1327         (tui_check_register_values): Don't declare.
1328         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1329         from tui_check_register_values.
1330         * tui/tui-hooks.c (tui_register_changed): Update.
1331
1332 2019-08-20  Tom Tromey  <tom@tromey.com>
1333
1334         * tui/tui-regs.c (tui_reg_layout): Move later.
1335         (tui_show_registers): Don't enable TUI mode or change layout.
1336
1337 2019-08-20  Tom Tromey  <tom@tromey.com>
1338
1339         * tui/tui-regs.h (struct tui_data_item_window)
1340         <~tui_data_item_window>: Remove.
1341         <content>: Now a unique_xmalloc_ptr.
1342         * tui/tui-regs.c (tui_register_format): Return a
1343         unique_xmalloc_ptr.
1344         (tui_get_register): Update.
1345         (~tui_data_item_window): Remove.
1346         (tui_data_window::display_registers_from, tui_display_register):
1347         Update.
1348         * tui/tui-io.h (tui_expand_tabs): Update.
1349         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1350         Remove "col" parameter.
1351
1352 2019-08-20  Tom Tromey  <tom@tromey.com>
1353
1354         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1355         field.
1356         * tui/tui-regs.c (~tui_data_item_window): Update.
1357
1358 2019-08-20  Tom Tromey  <tom@tromey.com>
1359
1360         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1361         earlier.
1362
1363 2019-08-20  Tom Tromey  <tom@tromey.com>
1364
1365         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1366
1367 2019-08-20  Tom Tromey  <tom@tromey.com>
1368
1369         * tui/tui-source.h (struct tui_source_window): Update.
1370         * tui/tui-regs.c (tui_show_registers): Update.
1371         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1372         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1373         (NO_REGS_STRING): Remove defines.
1374
1375 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1376
1377         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1378         unnecessary thread walk if remote doesn't support the packet.
1379
1380 2019-08-19  Tom Tromey  <tromey@adacore.com>
1381
1382         * python/py-value.c (value_has_field): Fix indentation.
1383
1384 2019-08-19  Tom Tromey  <tromey@adacore.com>
1385
1386         * printcmd.c (do_one_display, info_display_command): Update.
1387         * block.h (contained_in): Return bool.  Add allow_nested
1388         parameter.
1389         * block.c (contained_in): Return bool.  Add allow_nested
1390         parameter.
1391
1392 2019-08-19  Tom Tromey  <tom@tromey.com>
1393
1394         * configure: Rebuild.
1395         * configure.ac: Disallow the combination of -static-libstdc++ and
1396         source highlight.
1397         * source-cache.c (get_language_name): Handle rust.
1398         (source_cache::get_source_lines): Ignore highlighting exceptions.
1399
1400 2019-08-16  Tom Tromey  <tom@tromey.com>
1401
1402         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1403         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1404         (struct tui_source_window_base) <make_visible, refresh_window,
1405         resize>: Remove methods.
1406         <execution_info>: Remove field.
1407         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1408         (tui_show_source_line, tui_source_window_base)
1409         (~tui_source_window_base): Update.
1410         (tui_source_window_base::resize)
1411         (tui_source_window_base::make_visible)
1412         (tui_source_window_base::refresh_window): Remove.
1413         (tui_source_window_base::update_exec_info): Update.
1414         * tui/tui-source.c (tui_source_window::set_contents): Update.
1415         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1416
1417 2019-08-16  Tom Tromey  <tom@tromey.com>
1418
1419         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1420         deprecated_query_hook.
1421
1422 2019-08-16  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1425         (tui_update_source_windows_with_line): Update.
1426         * tui/tui-source.h (struct tui_source_window)
1427         <show_symtab_source>: Declare.
1428         (tui_show_symtab_source): Don't declare.
1429         * tui/tui-source.c (tui_show_symtab_source): Rename from
1430         tui_show_symtab_source.
1431
1432 2019-08-16  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-winsource.h (struct tui_source_window_base)
1435         <set_contents>: Declare.
1436         * tui/tui-winsource.c
1437         (tui_source_window_base::update_source_window_as_is): Update.
1438         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1439         Declare.
1440         (tui_set_source_content): Don't declare.
1441         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1442         tui_set_source_content.
1443         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1444         Declare.
1445         (tui_set_disassem_content): Don't declare.
1446         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1447         tui_set_disassem_content.
1448
1449 2019-08-16  Tom Tromey  <tom@tromey.com>
1450
1451         * tui/tui-winsource.h (struct tui_source_window_base)
1452         <update_breakpoint_info>: Declare.
1453         (tui_update_breakpoint_info): Don't declare.
1454         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1455         (tui_update_all_breakpoint_info): Update.
1456         (tui_source_window_base::update_breakpoint_info): Rename from
1457         tui_update_breakpoint_info.
1458         (tui_source_window_base::update_exec_info): Update.
1459
1460 2019-08-16  Tom Tromey  <tom@tromey.com>
1461
1462         * tui/tui-winsource.h (struct tui_source_window_base)
1463         <update_source_window>: Declare.
1464         (tui_update_source_window): Don't declare.
1465         * tui/tui-winsource.c
1466         (tui_source_window_base::update_source_window): Rename from
1467         tui_update_source_window.
1468         (tui_source_window_base::rerender): Update.
1469         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1470         * tui/tui-disasm.c (tui_show_disassem)
1471         (tui_show_disassem_and_update_source)
1472         (tui_disasm_window::maybe_update): Update.
1473
1474 2019-08-16  Tom Tromey  <tom@tromey.com>
1475
1476         * tui/tui-winsource.h (struct tui_source_window_base)
1477         <update_source_window_as_is>: Declare.
1478         (tui_update_source_window_as_is): Don't declare.
1479         * tui/tui-winsource.c (tui_update_source_window): Update
1480         (tui_source_window_base::update_source_window_as_is): Rename from
1481         tui_update_source_window_as_is.
1482         (tui_source_window_base::refill): Update.
1483         * tui/tui-source.c (tui_show_symtab_source): Update.
1484         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1485         Update.
1486
1487 2019-08-16  Tom Tromey  <tom@tromey.com>
1488
1489         * tui/tui-winsource.h (tui_update_source_window)
1490         (tui_update_source_window_as_is): Remove "noerror" parameter.
1491         * tui/tui-winsource.c (tui_update_source_window)
1492         (tui_update_source_window_as_is): Remove "noerror" parameter.
1493         (tui_update_source_windows_with_addr)
1494         (tui_update_source_windows_with_line)
1495         (tui_source_window_base::rerender)
1496         (tui_source_window_base::refill): Update.
1497         * tui/tui-source.h (tui_set_source_content)
1498         (tui_show_symtab_source): Remove "noerror" parameter.
1499         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1500         parameter.
1501         (tui_show_symtab_source): Likewise.
1502         (tui_source_window::maybe_update): Update.
1503         * tui/tui-disasm.c (tui_show_disassem)
1504         (tui_show_disassem_and_update_source)
1505         (tui_disasm_window::do_scroll_vertical)
1506         (tui_disasm_window::maybe_update): Update.
1507
1508 2019-08-16  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui.c (tui_is_window_visible): Update.
1511         * tui/tui-wingeneral.c (tui_make_window)
1512         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1513         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1514         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1515         (tui_set_win_height_command, parse_scrolling_args): Update.
1516         * tui/tui-source.c (tui_source_window::style_changed): Update.
1517         * tui/tui-regs.c (tui_show_registers)
1518         (tui_data_window::first_data_item_displayed)
1519         (tui_data_window::delete_data_content_windows)
1520         (tui_check_register_values, tui_reg_command): Update.
1521         * tui/tui-disasm.c (tui_show_disassem): Update.
1522         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1523         method.
1524         <is_visible>: Remove field.
1525         * tui/tui-data.c (tui_next_win, tui_prev_win)
1526         (tui_delete_invisible_windows): Update.
1527
1528 2019-08-16  Tom Tromey  <tom@tromey.com>
1529
1530         * tui/tui-winsource.h (struct tui_source_window_base)
1531         <m_has_locator>: Remove.
1532         * tui/tui-layout.c (show_source_disasm_command, show_data)
1533         (show_source_or_disasm_and_command): Update.
1534
1535 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1536
1537         * NEWS (Other MI changes): New subsection.
1538         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1539         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1540         * arch-utils.c (default_get_pc_address_flags): New function.
1541         * arch-utils.h (default_get_pc_address_flags): New declaration.
1542         * gdbarch.sh: Add get_pc_address_flags.
1543         * gdbarch.c: Regenerate.
1544         * gdbarch.h: Likewise.
1545         * stack.c (print_pc): New function.
1546         (print_frame_info) (print_frame): Call print_pc.
1547
1548 2019-08-16  Tom de Vries  <tdevries@suse.de>
1549
1550         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1551         print_objfile_section_info.
1552
1553 2019-08-15  Tom Tromey  <tom@tromey.com>
1554
1555         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1556         calling update_cmdwin_start_line.
1557         * tui/tui-winsource.h (struct tui_source_window_base)
1558         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1559         <rerender>: Declare.
1560         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1561         Call rerender.
1562         (tui_source_window_base::set_new_height): Remove.
1563         (tui_source_window_base::rerender): Rename from
1564         do_make_visible_with_new_height.
1565         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1566         resize method.
1567         (tui_win_info::make_invisible_and_set_new_height)
1568         (tui_win_info::make_visible_with_new_height): Remove.
1569         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1570         Declare.
1571         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1572         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1573         do_make_visible_with_new_height>: Don't declare.
1574         <rerender>: Declare.
1575         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1576         set_new_height.
1577         (tui_data_window::do_make_visible_with_new_height): Remove.
1578         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1579         call tui_show_locator_content.
1580         (tui_gen_win_info::resize): Call rerender.
1581         (show_source_or_disasm_and_command): Don't call
1582         tui_show_locator_content.
1583         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1584         method.
1585         (struct tui_win_info) <rerender>: Declare.
1586         <set_new_height, make_invisible_and_set_new_height,
1587         make_visible_with_new_height>: Don't declare.
1588         * tui/tui-data.c (tui_win_list::rerender): New method.
1589         * tui/tui-command.h (struct tui_cmd_window)
1590         <do_make_visible_with_new_height>: Don't declare.
1591         * tui/tui-command.c
1592         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1593
1594 2019-08-15  Tom Tromey  <tromey@adacore.com>
1595
1596         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1597         * ada-lang.c (ada_enum_name): Likewise.
1598
1599 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1600
1601         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1602         leading underscore.
1603         (GdbOutputErrorFile): Likewise.
1604         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1605         accordingly.
1606         (execute_unwinders): Rename to have a leading underscore.
1607         (auto_load_packages): Likewise.
1608         (global scope): Adjust call to auto_load_packages accordingly.
1609         (GdbSetPythonDirectory): Likewise.
1610         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1611         instead of execute_unwinders.
1612
1613 2019-08-15  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1616         (show_data): Don't change window visibility.
1617         (tui_gen_win_info::resize): Remove special case for command
1618         window.  Use wresize, when available.
1619         (show_source_or_disasm_and_command): Don't change window
1620         visibility.
1621         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1622         <make_visible>: New method.
1623         * tui/tui-command.c (tui_cmd_window::resize): New method.
1624
1625 2019-08-15  Tom Tromey  <tom@tromey.com>
1626
1627         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1628         (struct tui_source_windows): New.
1629         * tui/tui-winsource.c (tui_display_main): Update.
1630         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1631         (new_height_ok, parse_scrolling_args): Update.
1632         * tui/tui-layout.c (show_layout, show_data): Update.
1633         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1634         (tui_add_to_source_windows): Don't declare.
1635         * tui/tui-data.c (source_windows, tui_source_windows)
1636         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1637
1638 2019-08-15  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1641         Rename from reset.
1642         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1643         * tui/tui-layout.c (show_source_disasm_command, show_data):
1644         Update.
1645         (tui_gen_win_info::resize): Rename.
1646         (show_source_or_disasm_and_command): Update.
1647         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1648         reset.
1649
1650 2019-08-15  Tom Tromey  <tom@tromey.com>
1651
1652         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1653         * tui/tui-interp.c (tui_interp::init): Don't call
1654         tui_initialize_static_data.
1655         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1656
1657 2019-08-15  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1660         examine tui_win_list.
1661
1662 2019-08-15  Tom Tromey  <tom@tromey.com>
1663
1664         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1665         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1666         tui_clear_source_content.
1667         (tui_clear_source_content): Remove.
1668         (tui_source_window_base::do_erase_source_content): Hoist call to
1669         content.clear().
1670         * tui/tui-stack.c (tui_show_frame_info): Don't call
1671         tui_clear_source_content.
1672
1673 2019-08-15  Tom Tromey  <tom@tromey.com>
1674
1675         * tui/tui-winsource.h (struct tui_source_window_base)
1676         <do_erase_source_content>: New method.
1677         <erase_source_content>: New method.
1678         (tui_erase_source_content): Don't declare.
1679         * tui/tui-winsource.c (tui_clear_source_content): Update.
1680         (tui_source_window_base::do_erase_source_content): Rename from
1681         tui_erase_source_content.
1682         (tui_source_window_base::show_source_content): Update.
1683         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1684         * tui/tui-source.h (struct tui_source_window)
1685         <erase_source_content>: New method.
1686         * tui/tui-disasm.h (struct tui_disasm_window)
1687         <erase_source_content>: New method.
1688
1689 2019-08-15  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1692         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1693         constructor.
1694         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1695         * tui/tui-source.c (tui_set_source_content): Update.
1696         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1697
1698 2019-08-15  Tom Tromey  <tom@tromey.com>
1699
1700         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1701         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1702         tui-source.c.
1703         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1704         Declare.
1705         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1706         method.
1707         (tui_source_window::maybe_update): Update.
1708
1709 2019-08-15  Tom Tromey  <tom@tromey.com>
1710
1711         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1712         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1713         tui-disasm.c.
1714         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1715         Declare.
1716         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1717         method.
1718         (tui_disasm_window::maybe_update): Update.
1719
1720 2019-08-15  Tom Tromey  <tom@tromey.com>
1721
1722         * tui/tui-winsource.h (struct tui_source_window_base)
1723         <maybe_update>: Declare.
1724         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1725         method.
1726         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1727         Declare.
1728         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1729         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1730         Declare.
1731         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1732
1733 2019-08-15  Tom Tromey  <tom@tromey.com>
1734
1735         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1736
1737 2019-08-15  Tom Tromey  <tom@tromey.com>
1738
1739         * tui/tui-wingeneral.c: Include tui-stack.h.
1740         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1741         (struct tui_locator_window): Move from tui-data.h.
1742         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1743         (tui_initialize_static_data): Move from tui-data.c.
1744         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1745         (struct tui_locator_window): Move to tui-stack.c.
1746         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1747         (tui_initialize_static_data): Move to tui-stack.c.
1748
1749 2019-08-15  Tom Tromey  <tom@tromey.com>
1750
1751         * tui/tui-layout.c (show_source_disasm_command)
1752         (show_source_or_disasm_and_command): Use make_visible method, not
1753         tui_make_window.
1754         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1755         Remove.
1756
1757 2019-08-15  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui-wingeneral.h (tui_make_window): Update.
1760         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1761         parameter.
1762         (tui_gen_win_info::make_visible): Update.
1763         * tui/tui-regs.c (tui_data_window::display_registers_from):
1764         Update.
1765         * tui/tui-layout.c (show_source_disasm_command)
1766         (show_source_or_disasm_and_command): Update.
1767         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1768         (enum tui_box): Remove.
1769         (struct tui_win_info) <can_box>: New method.
1770         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1771         method.
1772
1773 2019-08-15  Tom de Vries  <tdevries@suse.de>
1774
1775         * linux-nat-trad.c: Include gdbarch.h.
1776
1777 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1778
1779         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1780         register sizes.
1781
1782 2019-08-14  Tom Tromey  <tromey@adacore.com>
1783
1784         * darwin-nat.c: Include gdbarch.h.
1785         * darwin-nat-info.c: Include gdbarch.h.
1786
1787 2019-08-13  Tom Tromey  <tom@tromey.com>
1788
1789         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1790         Remove.
1791         * tui/tui-data.c (tui_initialize_static_data): Update.
1792
1793 2019-08-13  Tom Tromey  <tom@tromey.com>
1794
1795         * tui/tui-winsource.h (struct tui_exec_info_window)
1796         <~tui_exec_info_window, maybe_allocate_content, get_content,
1797         m_content>: Remove.
1798         (struct tui_source_window_base) <set_exec_info_content,
1799         show_exec_info_content>: Don't declare.
1800         * tui/tui-winsource.c
1801         (tui_exec_info_window::maybe_allocate_content): Remove.
1802         (tui_source_window_base::update_exec_info): Rename from
1803         set_exec_info_content.
1804         (tui_source_window_base::show_exec_info_content)
1805         (tui_source_window_base::update_exec_info): Remove.
1806
1807 2019-08-13  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1810         declare.
1811         * tui/tui-winsource.c (tui_update_source_window_as_is)
1812         (tui_update_source_windows_with_addr, tui_erase_source_content):
1813         Update.
1814         (tui_clear_exec_info_content): Remove.
1815
1816 2019-08-13  Tom Tromey  <tom@tromey.com>
1817
1818         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1819         declare.
1820         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1821         call tui_erase_exec_info_content.
1822         (tui_clear_exec_info_content): Rename from
1823         tui_erase_exec_info_content.
1824         (tui_clear_exec_info_content): Delete.
1825
1826 2019-08-13  Tom Tromey  <tom@tromey.com>
1827
1828         * tui/tui-winsource.h (struct tui_source_window_base)
1829         <show_exec_info_content>: Declare.
1830         (tui_show_exec_info_content): Don't declare.
1831         * tui/tui-winsource.c
1832         (tui_source_window_base::show_exec_info_content): Rename from
1833         tui_show_exec_info_content.
1834         (tui_source_window_base::update_exec_info): Update.
1835
1836 2019-08-13  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1839         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1840         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1841         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1842         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1843         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1844         ... here.
1845
1846 2019-08-13  Tom Tromey  <tom@tromey.com>
1847
1848         * tui/tui-winsource.h (struct tui_source_window_base)
1849         <update_exec_info>: Declare.
1850         (tui_update_exec_info): Don't declare.
1851         * tui/tui-winsource.c (tui_update_source_window_as_is)
1852         (tui_source_window_base::refresh_all)
1853         (tui_update_all_breakpoint_info): Update.
1854         (tui_source_window_base::update_exec_info): Rename from
1855         tui_update_exec_info.
1856         * tui/tui-stack.c (tui_show_frame_info): Update.
1857
1858 2019-08-13  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui-winsource.h (struct tui_source_window_base)
1861         <set_exec_info_content>: Declare.
1862         (tui_set_exec_info_content): Don't declare.
1863         * tui/tui-winsource.c
1864         (tui_source_window_base::set_exec_info_content): Rename from
1865         tui_set_exec_info_content.
1866         (tui_update_exec_info): Update.
1867
1868 2019-08-13  Tom Tromey  <tom@tromey.com>
1869
1870         * tui/tui-winsource.h (struct tui_source_window_base)
1871         <show_source_content>: Declare.
1872         (tui_show_source_content): Don't declare.
1873         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1874         (tui_source_window_base::show_source_content): Rename from
1875         tui_show_source_content.
1876         (tui_source_window_base::refresh_all): Update.
1877         * tui/tui-layout.c (show_source_disasm_command)
1878         (show_source_or_disasm_and_command): Update.
1879
1880 2019-08-13  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-winsource.c (tui_erase_source_content)
1883         (tui_show_source_content, tui_source_window_base::refresh_all):
1884         Update.
1885         * tui/tui-wingeneral.h
1886         (tui_check_and_display_highlight_if_needed): Don't declare.
1887         * tui/tui-wingeneral.c
1888         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1889         check_and_display_highlight_if_needed.
1890         * tui/tui-win.c (tui_rehighlight_all)
1891         (tui_win_info::make_visible_with_new_height): Update.
1892         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1893         (tui_data_window::erase_data_content)
1894         (tui_data_window::display_all_data): Update.
1895         * tui/tui-data.h (struct tui_win_info)
1896         <check_and_display_highlight_if_needed>: Declare.
1897
1898 2019-08-13  Tom Tromey  <tom@tromey.com>
1899
1900         * tui/tui-win.c (tui_resize_all): Call
1901         tui_delete_invisible_windows.
1902         * tui/tui-layout.c (show_layout): Call
1903         tui_delete_invisible_windows.
1904         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1905         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1906
1907 2019-08-13  Tom Tromey  <tom@tromey.com>
1908
1909         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1910         tui_add_win_to_layout.
1911
1912 2019-08-13  Tom Tromey  <tom@tromey.com>
1913
1914         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1915         * tui/tui-layout.c (tui_default_win_height): Now static.
1916
1917 2019-08-13  Tom Tromey  <tom@tromey.com>
1918
1919         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1920         single switch.
1921         (show_source_disasm_command, show_source_or_disasm_and_command):
1922         Don't check current layout.
1923
1924 2019-08-13  Tom Tromey  <tom@tromey.com>
1925
1926         * tui/tui-wingeneral.c (make_all_visible): Remove.
1927         (tui_make_all_invisible): Simplify.
1928         * tui/tui-layout.c (tui_make_all_invisible): Move from
1929         tui-wingeneral.c; simplify.
1930         (show_layout): Hoist call to tui_make_all_invisible.
1931         (show_data): Don't call tui_make_all_invisible.
1932
1933 2019-08-13  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1936         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1937
1938 2019-08-13  Tom Tromey  <tom@tromey.com>
1939
1940         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1941         tui-data.c.
1942         (show_source_disasm_command, show_data)
1943         (show_source_or_disasm_and_command): Don't use
1944         tui_set_current_layout_to.
1945         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1946         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1947         tui-layout.c.
1948         (tui_set_current_layout_to): Remove.
1949
1950 2019-08-13  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-layout.c (tui_set_layout): Update.
1953         * tui/tui-data.h (struct tui_layout_def): Remove.
1954         (tui_layout_def): Don't declare.
1955         * tui/tui-data.c (layout_def): Remove.
1956         (tui_layout_def): Remove.
1957
1958 2019-08-13  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-winsource.h (struct tui_source_window_base)
1961         <clear_detail>: No longer "override".
1962         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1963         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1964         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1965         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1966         Remove.
1967         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1968
1969 2019-08-13  Tom Tromey  <tromey@adacore.com>
1970
1971         * tracepoint.c: Don't include readline.h or history.h.
1972
1973 2019-08-12  Tom Tromey  <tom@tromey.com>
1974
1975         * configure: Rebuild.
1976         * configure.ac: Check for readline 7.
1977         * NEWS: Mention readline 7 requirement.
1978         * README: Update.
1979
1980 2019-08-12  Tom Tromey  <tom@tromey.com>
1981
1982         * mingw-hdep.c (gdb_select): Remove readline hack.
1983
1984 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1985
1986         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1987         when the function fails.
1988
1989 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1990
1991         * s390-tdep.c (s390_type_align): New function.
1992         (s390_gdbarch_init): Set it as type_align gdbarch method.
1993
1994 2019-08-09  Tom de Vries  <tdevries@suse.de>
1995
1996         PR gdb/24591
1997         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1998         pc_low with relocation offset.
1999
2000 2019-08-07  Tom Tromey  <tromey@adacore.com>
2001
2002         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2003         (print_frame_args): Update.
2004         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2005         Update.
2006         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2007         * frame.h (struct frame_arg): Add initializers.
2008         <error>: Now a unique_xmalloc_ptr.
2009
2010 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2011
2012         * NEWS: Expand the Pointer Authentication entry.
2013         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2014         (aarch64_frame_unmask_lr): ... to this.
2015         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2016         Call aarch64_frame_unmask_lr.
2017         * frame.c (struct frame_info): Add "masked" variable.
2018         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2019         (fprint_frame): Check for masked pc.
2020         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2021         declarations.
2022         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2023         * stack.c (print_frame): Check for masked pc.
2024
2025 2019-08-06  Tom Tromey  <tom@tromey.com>
2026
2027         * stabsread.c (patch_block_stabs, read_one_struct_field)
2028         (read_enum_type): Use obstack_strndup.
2029         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2030         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2031         * dwarf2read.c (guess_full_die_structure_name)
2032         (anonymous_struct_prefix): Use obstack_strndup.
2033         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2034         * c-exp.y (yylex): Use obstack_strndup.
2035         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2036         (write_var_or_type): Use obstack_strndup.
2037
2038 2019-08-06  Tom Tromey  <tom@tromey.com>
2039
2040         * symfile.c (reread_symbols): Use obstack_strdup.
2041         * stabsread.c (read_type): Use obstack_strdup.
2042         * gdb_obstack.h (obstack_strdup): New overload.
2043         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2044         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2045         (dwarf2_canonicalize_name): Use obstack_strdup.
2046         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2047         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2048         Use obstack_strdup.
2049
2050 2019-08-06  Tom Tromey  <tom@tromey.com>
2051
2052         * gdb_obstack.h (obstack_strdup): Define.
2053         * gdb_obstack.c (obstack_strdup): Don't define.
2054
2055 2019-08-06  Tom Tromey  <tom@tromey.com>
2056
2057         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2058         obstack_strdup.
2059         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2060         obstack_strdup.
2061         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2062         * stabsread.c (common_block_start): Use obstack_strdup.
2063         * objfiles.c (set_objfile_main_name, objfile): Use
2064         obstack_strdup.
2065         * namespace.c (add_using_directive): Use obstack_strdup.
2066         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2067         * jit.c (finalize_symtab): Use obstack_strdup.
2068         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2069         (guess_partial_die_structure_name, partial_die_info::fixup)
2070         (dwarf2_name): Use obstack_strdup.
2071         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2072         obstack_strdup.
2073         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2074         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2075         obstack_strdup.
2076         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2077
2078 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2079
2080         * unittests/help-doc-selftests.c: New file.
2081         * Makefile.in: Add the new file.
2082
2083 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2084
2085         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2086         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2087         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2088         the trailing '.' is not output, and the first character is uppercased.
2089         (print_help_for_command): Update call to print_doc_line.
2090         (print_doc_of_command): Likewise.
2091         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2092         * cli/cli-option.c (append_indented_doc): Do not append newline.
2093         (build_help_option): Append newline after first appended_indented_doc
2094         only if a second call is done.
2095         (build_help): Append 2 new lines before each option, except the first
2096         one.
2097         * compile/compile.c (_initialize_compile): Add new lines after
2098         %OPTIONS%, when not at the end of the help.
2099         Change help doc or code
2100         producing the help doc to respect the invariants.
2101         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2102         Also removed the new line after 'Options:', as all other commands
2103         do not put an empty line between 'Options:' and the first option.
2104         * printcmd.c (_initialize_printcmd): Likewise.
2105         * stack.c (_initialize_stack): Likewise.
2106         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2107         incorrectly telling COMMAND is optional.
2108         * ada-lang.c (_initialize_ada_language): Change help doc or code
2109         producing the help doc to respect the invariants.
2110         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2111         * breakpoint.c (_initialize_breakpoint): Likewise.
2112         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2113         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2114         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2115         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2116         _initialize_cli_style): Likewise.
2117         * corelow.c (core_target_info): Likewise.
2118         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2119         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2120         * filesystem.c (_initialize_filesystem): Likewise.
2121         * frame.c (_initialize_frame): Likewise.
2122         * gnu-nat.c (add_task_commands): Likewise.
2123         * infcall.c (_initialize_infcall): Likewise.
2124         * infcmd.c (_initialize_infcmd): Likewise.
2125         * interps.c (_initialize_interpreter): Likewise.
2126         * language.c (_initialize_language): Likewise.
2127         * linux-fork.c (_initialize_linux_fork): Likewise.
2128         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2129         * maint.c (_initialize_maint_cmds): Likewise.
2130         * memattr.c (_initialize_mem): Likewise.
2131         * printcmd.c (_initialize_printcmd): Likewise.
2132         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2133         _RegEx): Likewise.
2134         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2135         * record-btrace.c (_initialize_record_btrace): Likewise.
2136         * record-full.c (_initialize_record_full): Likewise.
2137         * record.c (_initialize_record): Likewise.
2138         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2139         * regcache.c (_initialize_regcache): Likewise.
2140         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2141         _initialize_remote): Likewise.
2142         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2143         * serial.c (_initialize_serial): Likewise.
2144         * skip.c (_initialize_step_skip): Likewise.
2145         * source.c (_initialize_source): Likewise.
2146         * stack.c (_initialize_stack): Likewise.
2147         * symfile.c (_initialize_symfile): Likewise.
2148         * symtab.c (_initialize_symtab): Likewise.
2149         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2150         * top.c (init_main): Likewise.
2151         * tracefile-tfile.c (tfile_target_info): Likewise.
2152         * tracepoint.c (_initialize_tracepoint): Likewise.
2153         * tui/tui-win.c (_initialize_tui_win): Likewise.
2154         * utils.c (add_internal_problem_command): Likewise.
2155         * valprint.c (value_print_option_defs): Likewise.
2156
2157 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2158
2159         PR build/24886
2160         * configure.ac: Drop enable-libmcheck support.
2161         * configure, config.in: Rebuild.
2162         * libmcheck.m4: Remove.
2163         * acinclude.m4: Don't include it.
2164         * Makefile.in: Don't distribute it.
2165         * top.c (print_gdb_configuration): Don't mention it.
2166
2167 2019-08-06  Tom Tromey  <tom@tromey.com>
2168
2169         * utils.c (set_output_style): Sometimes pass stream to
2170         emit_style_escape.
2171         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2172         * record-btrace.c (btrace_insn_history): Update.
2173         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2174         method.
2175         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2176         Update initializers.
2177         <m_uiout>: New field.
2178         <m_di>: Move lower.
2179         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2180         Remove "uiout" parameter.
2181         (dump_insns): Update.
2182         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2183         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2184
2185 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2186
2187         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2188         (error_in_psymtab_expansion): Likewise.
2189         (lookup_symbol_via_quick_fns): Likewise.
2190         (basic_lookup_transparent_type_quick): Likewise.
2191         (basic_lookup_transparent_type_1): Likewise.
2192
2193 2019-08-06  Tom Tromey  <tromey@adacore.com>
2194
2195         * source.c (last_source_error): Now bool.
2196         (print_source_lines_base): Make "noprint" bool.  Only open
2197         source file when last_source_visited changes.
2198
2199 2019-08-06  Tom Tromey  <tromey@adacore.com>
2200
2201         * annotate.c (annotate_source_line): Use g_source_cache.
2202         * source-cache.c (source_cache::get_plain_source_lines): Change
2203         parameters.  Populate m_offset_cache.
2204         (source_cache::ensure): New method.
2205         (source_cache::get_line_charpos): New method.
2206         (extract_lines): Move lower.  Change parameters.
2207         (source_cache::get_source_lines): Move lower.
2208         * source-cache.h (class source_cache): Update comment.
2209         <get_line_charpos>: New method.
2210         <get_source_lines>: Update comment.
2211         <clear>: Clear m_offset_cache.
2212         <get_plain_source_lines>: Change parameters.
2213         <ensure>: New method
2214         <m_offset_cache>: New member.
2215         * source.c (forget_cached_source_info_for_objfile): Update.
2216         (info_source_command): Use g_source_cache.
2217         (find_source_lines, open_source_file_with_line_charpos): Remove.
2218         (print_source_lines_base, search_command_helper): Use g_source_cache.
2219         * source.h (open_source_file_with_line_charpos): Don't declare.
2220         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2221         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2222         Use g_source_cache.
2223
2224 2019-08-06  Tom Tromey  <tromey@adacore.com>
2225
2226         * source-cache.c (source_cache::get_plain_source_lines):
2227         Remove "first_line" and "last_line" parameters.
2228         (source_cache::get_source_lines): Cache plain text.
2229         * source-cache.h (class source_cache)
2230         <get_plain_source_lines>: Update.
2231
2232 2019-08-06  Tom Tromey  <tromey@adacore.com>
2233
2234         * source-cache.c (extract_lines): No longer a method.
2235         Changed type of parameter.  Include final newline.
2236         (selftests::extract_lines_test): New function.
2237         (_initialize_source_cache): Likewise.
2238         * source-cache.h (class source_cache)
2239         <extract_lines>: Don't declare.
2240
2241 2019-08-06  Tom Tromey  <tromey@adacore.com>
2242
2243         * breakpoint.c (init_breakpoint_sal): Update.
2244         (breakpoint): Update.
2245         * breakpoint.h (struct breakpoint) <filter>: Now a
2246         unique_xmalloc_ptr.
2247
2248 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2249
2250         * NEWS: Mention dictionary access on blocks.
2251         * python/py-block.c (blpy_getitem): New function.
2252         (block_object_as_mapping): New struct.
2253         (block_object_type): Use new struct for tp_as_mapping field.
2254
2255 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2256
2257         * objfiles.h (objfile): Add a comment describing partial symbols.
2258
2259 2019-08-05  Tom Tromey  <tromey@adacore.com>
2260
2261         * compile/compile.c (_initialize_compile): Use _(), not N_().
2262         * thread.c (_initialize_thread): Use _(), not N_().
2263         * stack.c (_initialize_stack): Use _(), not N_().
2264         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2265
2266 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2267
2268         * dwarf2read.c (struct dw2_symtab_iterator):
2269         <want_specific_block>: Remove.
2270         <block_index>: Change type to gdb::optional.
2271         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2272         change type of BLOCK_INDEX parameter to gdb::optional.
2273         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2274         (dw2_lookup_symbol): Don't pass argument for
2275         WANT_SPECIFIC_BLOCK.
2276         (dw2_expand_symtabs_for_function): Don't pass argument for
2277         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2278         (class dw2_debug_names_iterator)
2279         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2280         parameter, change BLOCK_INDEX type to gdb::optional.
2281         <m_want_specific_block>: Remove.
2282         <m_block_index>: Change type to gdb::optional.
2283         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2284         gdb::optional.  Re-write in function of gdb::optional.
2285         (dw2_debug_names_lookup_symbol): Don't pass argument for
2286         WANT_SPECIFIC_BLOCK.
2287         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2288         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2289         BLOCK_INDEX.
2290
2291 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2292
2293         * NEWS: Mention changes to "info sources" command.
2294
2295 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2296
2297         * symtab.c (filename_partial_match_opts): New struct type.
2298         (struct output_source_filename_data): New members
2299         regexp, c_regexp, partial_match.
2300         (output_source_filename): Use new members to decide to print file.
2301         (info_sources_option_defs): New variable.
2302         (make_info_sources_options_def_group, print_info_sources_header,
2303         info_sources_command_completer):
2304         New functions.
2305         (info_sources_command): Read new optional arguments.
2306         (_initialize_symtab): Update info sources help.
2307
2308 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2309
2310         * ada-lang.c (exception_support_info_v0): Renamed from...
2311         (default_exception_support_info): ... this.  Create new
2312         definition for v1.
2313         (ada_has_this_exception_support): Look up catch_handlers_sym.
2314         (ada_exception_support_info_sniffer): Try v0 after default.
2315
2316 2019-08-01  Tom Tromey  <tromey@adacore.com>
2317
2318         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2319         gdbarch.h.
2320
2321 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2322
2323         * s12z-tdep.c: Fix include path for s12z-opc.h.
2324
2325 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2326
2327         * NEWS: Require GNU make 3.82.
2328
2329 2019-07-16  Tom Tromey  <tom@tromey.com>
2330
2331         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2332         declare.
2333
2334 2019-07-30  Tom Tromey  <tromey@adacore.com>
2335
2336         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2337
2338 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2339
2340         * printcmd.c (print_address_symbolic): Print negative offsets.
2341         (build_address_symbolic): Force signed arithmetic when computing
2342         offset.
2343
2344 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2345
2346         PR/24474: Add a function to lookup static variables.
2347         * NEWS: Mention this new function.
2348         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2349         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2350         * python/python.c (python_GdbMethods): Add new function.
2351
2352 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2353
2354         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2355         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2356         (objfpy_lookup_static_symbol): New function.
2357         (objfile_object_methods): Add new functions.
2358
2359 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2360
2361         * NEWS: Mention 'set|show print frame-info'.  Mention new
2362         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2363         backtrace argument.  Mention that python frame filtering code
2364         is now consistent with what 'backtrace' command prints.
2365
2366 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2367
2368         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2369         comments.
2370         (print_frame_info_auto, print_frame_info_source_line,
2371         print_frame_info_location, print_frame_info_source_and_location,
2372         print_frame_info_location_and_address, print_frame_info_short_location):
2373         New declarations.
2374         (struct frame_print_options): New member print_frame_info.
2375         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2376         * stack.h (get_user_print_what_frame_info): New declaration.
2377         (frame_show_address): New declaration.
2378         * stack.c (print_frame_arguments_choices): New value 'presence'.
2379         (print_frame_info_auto, print_frame_info_source_line,
2380         print_frame_info_location, print_frame_info_source_and_location,
2381         print_frame_info_location_and_address, print_frame_info_short_location,
2382         print_frame_info_choices, print_frame_info_print_what): New definitions.
2383         (print_frame_args): Only print dots for args if print frame-arguments
2384         is 'presence'.
2385         (frame_print_option_defs): New element for "frame-info".
2386         (get_user_print_what_frame_info): New function.
2387         (frame_show_address): Make non static.  Move comment to stack.h.
2388         (print_frame_info_to_print_what): New function.
2389         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2390         to decide what to print.
2391         (backtrace_command_1): Handle the new print_frame_arguments_presence
2392         value.
2393         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2394         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2395         (py_print_frame): In non-mi mode, use LOCATION as default for
2396         print_what, similarly to frame information printed directly by
2397         backtrace command. Handle frame-info user option in non MI mode.
2398
2399 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2400
2401         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2402         Add case for debugging 32-bit target on 64-bit host.  Revise
2403         comment.
2404
2405 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2406
2407         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2408         instead of find_function_entry_range_from_pc.
2409
2410 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2411
2412         * stack.c (find_frame_funname): Remove code which preferred
2413         minsym over symtab sym in "certain pathological cases".
2414
2415         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2416         parameter.  Change type of "do_demangle" to bool.
2417         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2418         Pass suitable "prefer_sym_over_minsym" flag to
2419         build_address_symbolic().  Don't output "+" for negative offsets.
2420         * printcmd.c (print_address_symbolic): Update invocation of
2421         build_address_symbolic to include a "prefer_sym_over_minsym"
2422         flag.
2423         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2424         Restrict cases in which use of minimal symbol is preferred to that
2425         of a found symbol.  Update comments.
2426
2427         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2428         for entry pc when entry pc is out of range for that FDE.
2429
2430 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2431
2432         PR gdb/24839:
2433         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2434         type.
2435
2436 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2437
2438         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2439         this function's Python signature.
2440
2441
2442 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2443
2444         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2445         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2446         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2447         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2448         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2449
2450
2451 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2452
2453         * h8300-tdep.c (h8300_register_name_common): New.
2454         h8300_register_name): Use h8300_register_name_common.
2455         (h8300s_register_name): Likewise.
2456         (h8300sx_register_name): Likewise.
2457         (h8300h_register_nam): New.
2458         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2459
2460
2461 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2462
2463         * arm-tdep.c (arm_skip_cmse_entry): New function.
2464         (arm_is_sgstubs_section): New function.
2465         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2466
2467 2019-07-22  Tom Tromey  <tom@tromey.com>
2468
2469         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2470         Don't self-assign.
2471
2472 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2473
2474         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2475         type_print.
2476
2477 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2478
2479         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2480         so that GDB doesn't match any msymbols when searching in the
2481         TYPES_DOMAIN.
2482         (print_symbol_info): Print using typedef_print or type_print based
2483         on the type of the symbol.  Add updated FIXME comment moved from...
2484         (_initialize_symtab): ... move and update FIXME comment to above.
2485
2486 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2487
2488         * NEWS: Mention adding -q option to "info types".
2489         * symtab.c (struct info_types_options): New struct.
2490         (info_types_options_defs): New variable.
2491         (make_info_types_options_def_group): New function.
2492         (info_types_command): Use gdb::option framework to parse options.
2493         (info_types_command_completer): New function.
2494         (_initialize_symtab): Extend the help text on "info types" and
2495         register command completer.
2496
2497 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2498
2499         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2500         (lookup_symbol_in_objfile): Change int to block_enum and add a
2501         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2502
2503 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2504
2505         * MAINTAINERS (Write After Approval): Add self.
2506
2507 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2508
2509         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2510         instruction to the dummy code region.
2511
2512 2019-07-19  Tom Tromey  <tromey@adacore.com>
2513
2514         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2515         (ARGSUSED, PARAMS, __func__): Remove rules.
2516
2517 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2518
2519         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2520         * features/arm/arm-with-iwmmxt.c: Remove.
2521         * features/arm/arm-with-iwmmxt.xml: Remove.
2522         * features/arm/arm-with-m-fpa-layout.c: Remove.
2523         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2524         * features/arm/arm-with-m-vfp-d16.c: Remove.
2525         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2526         * features/arm/arm-with-m.c: Remove.
2527         * features/arm/arm-with-m.xml: Remove.
2528         * features/arm/arm-with-neon.c: Remove.
2529         * features/arm/arm-with-neon.xml: Remove.
2530         * features/arm/arm-with-vfpv2.c: Remove.
2531         * features/arm/arm-with-vfpv2.xml: Remove.
2532         * features/arm/arm-with-vfpv3.c: Remove.
2533         * features/arm/arm-with-vfpv3.xml: Remove.
2534
2535 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2536
2537         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2538
2539 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2540
2541         * arch/aarch32.c (aarch32_create_target_description): Create
2542         target descriptions using features.
2543         * arch/arm.c (arm_create_target_description)
2544         (arm_create_mprofile_target_description): Likewise.
2545         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2546
2547 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2548
2549         * Makefile.in: Add new files.
2550         * aarch32-tdep.c: New file.
2551         * aarch32-tdep.h: New file.
2552         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2553         Call aarch32_read_description.
2554         * arch/aarch32.c: New file.
2555         * arch/aarch32.h: New file.
2556         * arch/arm.c (arm_create_target_description)
2557         (arm_create_mprofile_target_description): New function.
2558         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2559         (arm_create_target_description)
2560         (arm_create_mprofile_target_description): New declaration.
2561         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2562         read_description functions.
2563         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2564         Likewise.
2565         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2566         * arm-tdep.c (tdesc_arm_list): New variable.
2567         (arm_register_g_packet_guesses): Call create description functions.
2568         (arm_read_description) (arm_read_mprofile_description): New
2569         function.
2570         * arm-tdep.h (arm_read_description)
2571         (arm_read_mprofile_description): Add declaration.
2572         * configure.tgt: Add new files.
2573
2574 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2575
2576         * top.c (new_ui_command): Open specified terminal just once.
2577
2578 2019-07-18  Tom Tromey  <tromey@adacore.com>
2579
2580         * symtab.c (main_name): Constify return type.
2581         * symfile.c (set_initial_language): Update.
2582         * symtab.h (main_name): Constify return type.
2583
2584 2019-07-17  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-winsource.c (tui_update_source_window)
2587         (tui_update_source_window_as_is)
2588         (tui_update_source_windows_with_line): Remove return.
2589         * tui/tui-disasm.c (tui_show_disassem)
2590         (tui_show_disassem_and_update_source): Remove return.
2591         * tui/tui.c (tui_reset): Remove return.
2592         * tui/tui-wingeneral.c
2593         (tui_check_and_display_highlight_if_needed): Remove return.
2594
2595 2019-07-17  Tom Tromey  <tom@tromey.com>
2596
2597         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2598
2599 2019-07-17  Tom Tromey  <tom@tromey.com>
2600
2601         * tui/tui-winsource.h (struct tui_exec_info_window)
2602         (struct tui_source_window_base): Move from tui-data.h.
2603         * tui/tui-winsource.c: Move many method definitions from
2604         elsewhere.  Remove "structuring" comments.
2605         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2606         (tui_source_window_base::refresh_window): Move to
2607         tui-winsource.c.
2608         * tui/tui-win.c (tui_source_window_base::refresh_all)
2609         (tui_source_window_base::update_tab_width)
2610         (tui_source_window_base::set_new_height)
2611         (tui_source_window_base::do_make_visible_with_new_height): Move to
2612         tui-winsource.c.
2613         * tui/tui-source.h: Update.
2614         * tui/tui-source.c (tui_source_window_base::reset): Move to
2615         tui-winsource.c.
2616         * tui/tui-disasm.h: Update.
2617         * tui/tui-data.h (struct tui_exec_info_window): Move to
2618         tui-winsource.h.
2619         (struct tui_source_window_base): Likewise.
2620         * tui/tui-data.c (tui_source_window_base::clear_detail)
2621         (tui_source_window_base, ~tui_source_window_base): Move to
2622         tui-winsource.c.
2623
2624 2019-07-17  Tom Tromey  <tom@tromey.com>
2625
2626         * tui/tui-win.c (tui_resize_all)
2627         (tui_source_window_base::update_tab_width)
2628         (tui_adjust_win_heights): Update.
2629         (tui_win_info::make_invisible_and_set_new_height): Rename from
2630         make_invisible_and_set_new_height.
2631         * tui/tui-data.h (struct tui_win_info)
2632         <make_invisible_and_set_new_height>: New method.
2633
2634 2019-07-17  Tom Tromey  <tom@tromey.com>
2635
2636         * tui/tui.c: Update.
2637         * tui/tui-source.h (struct tui_source_window): Move from
2638         tui-data.h.
2639         * tui/tui-layout.c: Update.
2640         * tui/tui-disasm.c: Update.
2641         * tui/tui-data.h (struct tui_source_window): Move to
2642         tui-source.h.
2643
2644 2019-07-17  Tom Tromey  <tom@tromey.com>
2645
2646         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2647         tui-data.h.
2648         * tui/tui-data.h (struct tui_disasm_window): Move to
2649         tui-disasm.h.
2650
2651 2019-07-17  Tom Tromey  <tom@tromey.com>
2652
2653         * tui/tui-regs.h (struct tui_data_item_window): Move from
2654         tui-data.h.
2655         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2656         * tui/tui-data.h (struct tui_data_item_window): Move to
2657         tui-regs.h.
2658         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2659
2660 2019-07-17  Tom Tromey  <tom@tromey.com>
2661
2662         * tui/tui.c: Update.
2663         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2664         (tui_cmd_window::max_height): Move to tui-command.c.
2665         * tui/tui-layout.c: Update.
2666         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2667         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2668         tui-command.c.
2669         * tui/tui-command.h (struct tui_cmd_window): Move from
2670         tui-data.h.
2671         * tui/tui-command.c: Remove "structuring" comments.
2672         (tui_cmd_window::clear_detail)
2673         (tui_cmd_window::do_make_visible_with_new_height)
2674         (tui_cmd_window::max_height): Move from elsewhere.
2675
2676 2019-07-17  Tom Tromey  <tom@tromey.com>
2677
2678         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2679         Now static.
2680         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2681         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2682
2683 2019-07-17  Tom Tromey  <tom@tromey.com>
2684
2685         * tui/tui.c: Update.
2686         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2687         tui-regs.c.
2688         * tui/tui-windata.h: Remove file.
2689         * tui/tui-windata.c: Remove file.
2690         * tui/tui-win.c (tui_data_window::set_new_height)
2691         (tui_data_window::do_make_visible_with_new_height): Move to
2692         tui-regs.c.
2693         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2694         * tui/tui-regs.c: Remove "structuring" comments.
2695         (tui_data_window::first_data_item_displayed)
2696         (tui_data_window::delete_data_content_windows)
2697         (tui_data_window::erase_data_content)
2698         (tui_data_window::display_all_data)
2699         (tui_data_window::refresh_all)
2700         (tui_data_window::do_scroll_vertical)
2701         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2702         (tui_data_window::do_make_visible_with_new_height)
2703         (tui_data_window::refresh_window): Move from elsewhere.
2704         (_initialize_tui_regs): Move to end of file.
2705         * tui/tui-layout.c: Update.
2706         * tui/tui-hooks.c: Update.
2707         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2708         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2709         tui-regs.c.
2710         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2711
2712 2019-07-17  Tom Tromey  <tom@tromey.com>
2713
2714         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2715         seen.
2716
2717 2019-07-17  Tom Tromey  <tom@tromey.com>
2718
2719         * tui/tui-win.c (tui_source_window_base::set_new_height)
2720         (tui_source_window_base::do_make_visible_with_new_height): Use
2721         m_has_locator field directly.
2722         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2723         method.
2724         (struct tui_source_window_base) <has_locator>: Likewise.
2725
2726 2019-07-17  Tom Tromey  <tom@tromey.com>
2727
2728         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2729         Don't declare.
2730         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2731         Remove.
2732         * tui/tui-win.c (tui_source_window_base::set_new_height)
2733         (tui_source_window_base::set_new_height)
2734         (make_invisible_and_set_new_height)
2735         (tui_source_window_base::do_make_visible_with_new_height)
2736         (tui_source_window_base::do_make_visible_with_new_height):
2737         Update.
2738         * tui/tui-layout.c (show_source_disasm_command, show_data)
2739         (show_source_or_disasm_and_command): Update.
2740         * tui/tui-layout.c (show_layout): Update.
2741
2742 2019-07-17  Tom Tromey  <tom@tromey.com>
2743
2744         * tui/tui-layout.c (make_data_window): Remove.
2745         (show_data): Unify creation and re-initialization cases.
2746
2747 2019-07-17  Tom Tromey  <tom@tromey.com>
2748
2749         * tui/tui-layout.c (make_source_window, make_disasm_window):
2750         Remove.
2751         (show_data): Unify creation and re-initialization cases.
2752
2753 2019-07-17  Tom Tromey  <tom@tromey.com>
2754
2755         * tui/tui-layout.c (make_command_window): Remove.
2756         (show_source_disasm_command, show_source_or_disasm_and_command):
2757         Unify creation and re-initialization cases.
2758
2759 2019-07-17  Tom Tromey  <tom@tromey.com>
2760
2761         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2762         creation and re-initialization cases.
2763
2764 2019-07-17  Tom Tromey  <tom@tromey.com>
2765
2766         * tui/tui-regs.c (tui_get_register): Return void.
2767
2768 2019-07-17  Tom Tromey  <tom@tromey.com>
2769
2770         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2771         Simplify.
2772
2773 2019-07-17  Tom Tromey  <tom@tromey.com>
2774
2775         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2776         resetting.
2777
2778 2019-07-17  Tom Tromey  <tom@tromey.com>
2779
2780         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2781         * tui/tui-regs.c (tui_reg_layout): New function.
2782         (tui_show_registers, tui_reg_command): Use it.
2783         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2784         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2785         parameters.
2786         (tui_layout_command): Remove.
2787
2788 2019-07-17  Tom Tromey  <tom@tromey.com>
2789
2790         * tui/tui-layout.h (tui/tui-layout): Return void.
2791         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2792
2793 2019-07-17  Tom Tromey  <tom@tromey.com>
2794
2795         * tui/tui-layout.c (show_source_disasm_command, show_data):
2796         Update.
2797         (reset_locator): Remove.
2798         (show_source_or_disasm_and_command): Update.
2799
2800 2019-07-17  Tom Tromey  <tom@tromey.com>
2801
2802         * tui/tui-source.c (tui_source_window_base::reset): Remove
2803         win_type parameter.
2804         * tui/tui-layout.c (make_command_window, make_source_window)
2805         (make_disasm_window, make_data_window)
2806         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2807         (reset_locator, show_source_or_disasm_and_command): Update.
2808         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2809         win_type parameter.
2810         (struct tui_source_window_base) <reset>: Likewise.
2811
2812 2019-07-17  Tom Tromey  <tom@tromey.com>
2813
2814         * tui/tui-layout.c (show_source_disasm_command): Use
2815         reset_locator.
2816         (reset_locator): New function.
2817         (init_and_make_win): Remove.
2818         (show_source_or_disasm_and_command): Use reset_locator.
2819
2820 2019-07-17  Tom Tromey  <tom@tromey.com>
2821
2822         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2823         condition.
2824         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2825         Remove condition.
2826         * tui/tui-source.c (tui_source_window_base::reset): New method.
2827         * tui/tui-layout.c (make_command_window): Don't call
2828         init_and_make_win.
2829         (make_source_window, make_disasm_window): Don't call
2830         make_source_or_disasm_window.
2831         (make_data_window): Don't call init_and_make_win.  Change calling
2832         convention.
2833         (show_source_disasm_command, show_data): Simplify.
2834         (make_source_or_disasm_window): Remove.
2835         (show_source_or_disasm_and_command): Simplify.
2836         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2837         (struct tui_source_window_base) <reset>: Likewise.
2838         <execution_info>: Remove initializer.
2839         * tui/tui-data.c (tui_source_window_base): Initialize
2840         execution_info.
2841
2842 2019-07-17  Tom Tromey  <tom@tromey.com>
2843
2844         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2845         variable.
2846
2847 2019-07-17  Tom Tromey  <tom@tromey.com>
2848
2849         * tui/tui.c (tui_rl_other_window): Update.
2850         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2851         superclass method first.  Always iterate over regs_content.
2852         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2853         method.
2854         * tui/tui-win.c (tui_set_focus_command): Update.
2855
2856 2019-07-17  Tom Tromey  <tom@tromey.com>
2857
2858         * tui/tui-win.c (tui_set_focus_command): Rename from
2859         tui_set_focus.  Call tui_enable.
2860         (tui_set_focus_command): Remove.
2861
2862 2019-07-17  Tom Tromey  <tom@tromey.com>
2863
2864         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2865         refresh_window.
2866         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2867         touchwin.
2868         (tui_data_window::refresh_window): Call refresh_window on data
2869         items.  Always call superclass refresh_window.
2870         (tui_win_info::refresh): Remove.
2871         (tui_source_window_base::refresh_window): Update.
2872         (tui_refresh_all): Update.
2873         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2874         refresh_window.
2875         (show_source_or_disasm_and_command): Likewise.
2876         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2877         (struct tui_source_window_base) <refresh>: Likewise.
2878
2879 2019-07-17  Tom Tromey  <tom@tromey.com>
2880
2881         * tui/tui-winsource.c (tui_clear_source_content)
2882         (tui_show_source_content): Update.
2883         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2884         whether content is empty.
2885         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2886         Remove.
2887
2888 2019-07-17  Tom Tromey  <tom@tromey.com>
2889
2890         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2891         window's contents.
2892         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2893         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2894
2895 2019-07-17  Tom Tromey  <tom@tromey.com>
2896
2897         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2898         (struct tui_data_item_window): Update.
2899
2900 2019-07-17  Tom Tromey  <tom@tromey.com>
2901
2902         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2903         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2904         defines.
2905
2906 2019-07-17  Tom Tromey  <tom@tromey.com>
2907
2908         * tui/tui-winsource.h (tui_erase_source_content)
2909         (tui_clear_source_content): Remove "display_prompt" parameter.
2910         * tui/tui-winsource.c (tui_update_source_window_as_is)
2911         (tui_update_source_windows_with_addr): Update.
2912         (tui_clear_source_content): Remove "display_prompt" parameter.
2913         (tui_erase_source_content): Likewise.  Simplify.
2914         (tui_show_source_content): Update.
2915         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2916         * tui/tui-stack.c (tui_show_frame_info): Update.
2917         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2918         Remove defines.
2919
2920 2019-07-17  Tom Tromey  <tom@tromey.com>
2921
2922         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2923         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2924         parameter.
2925         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2926         parameter.
2927
2928 2019-07-17  Tom Tromey  <tom@tromey.com>
2929
2930         * tui/tui-winsource.c (tui_clear_source_content)
2931         (tui_show_source_content, tui_show_exec_info_content)
2932         (tui_clear_exec_info_content): Update.
2933         * tui/tui-stack.c (tui_show_locator_content): Update.
2934         (tui_show_frame_info): Update.
2935         * tui/tui-source.h (tui_source_window): Don't declare.
2936         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2937         from tui_source_is_displayed.
2938         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2939         Remove field.
2940         (struct tui_source_window_base) <content_in_use>: New field.  Now
2941         bool.
2942         (struct tui_source_window) <showing_source_p>: New method.
2943         (TUI_SRC_WIN): Change cast.
2944         * tui/tui-data.c (tui_initialize_static_data): Update.
2945
2946 2019-07-17  Tom Tromey  <tom@tromey.com>
2947
2948         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2949         location_matches_p.
2950         * tui/tui-source.c (tui_source_window::location_matches_p): New
2951         method.
2952         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2953         method.
2954         * tui/tui-data.h (struct tui_source_window_base)
2955         <location_matches_p>: New method.
2956         (struct tui_source_window, struct tui_disasm_window)
2957         <location_matches_p>: Likewise.
2958
2959 2019-07-17  Tom Tromey  <tom@tromey.com>
2960
2961         * tui/tui-win.c (tui_set_win_height_command): Rename from
2962         tui_set_win_height.
2963         (tui_set_win_height_command): Remove.
2964
2965 2019-07-17  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui-source.c (tui_source_window): New constructor.  Add
2968         observer.
2969         (~tui_source_window): New destructor.
2970         (tui_source_window::style_changed): New method.
2971         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2972         (tui_attach_detach_observers): Update.
2973         * tui/tui-data.h (struct tui_source_window): Make constructor not
2974         inline.  Add destructor.
2975         (struct tui_source_window) <style_changed>: New method.
2976         <m_observable>: New member.
2977
2978 2019-07-17  Tom Tromey  <tom@tromey.com>
2979
2980         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2981         * tui/tui-win.c (tui_resize_all): Fix typo.
2982
2983 2019-07-17  Tom Tromey  <tom@tromey.com>
2984
2985         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2986         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2987         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2988         * tui/tui-win.c (window_name_completer): Use foreach.
2989         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2990         (update_tab_width): Likewise.
2991         * tui/tui-layout.c (show_layout): Update.
2992         * tui/tui-data.h (class tui_window_iterator): New.
2993         (struct all_tui_windows): New.
2994         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2995
2996 2019-07-17  Tom Tromey  <tom@tromey.com>
2997
2998         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2999         parameter.  Don't reference globals.
3000         (tui_reg_command): Update.
3001
3002 2019-07-17  Tom Tromey  <tom@tromey.com>
3003
3004         * tui/tui-regs.c (tui_show_registers): Simplify.
3005
3006 2019-07-17  Tom Tromey  <tom@tromey.com>
3007
3008         * tui/tui-regs.c (tui_show_registers): Update.
3009         (tui_show_register_group): Add win_info parameter.
3010
3011 2019-07-17  Tom Tromey  <tom@tromey.com>
3012
3013         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3014         Rename from tui_display_reg_element_at_line.
3015         (tui_data_window::display_registers_from_line): Update.
3016         * tui/tui-data.h (struct tui_data_window)
3017         <display_reg_element_at_line>: New method.
3018
3019 2019-07-17  Tom Tromey  <tom@tromey.com>
3020
3021         * tui/tui-regs.h (tui_display_registers_from)
3022         (tui_display_registers_from_line): Don't declare.
3023         * tui/tui-windata.c (tui_data_window::display_all_data)
3024         (tui_data_window::refresh_all)
3025         (tui_data_window::do_scroll_vertical): Update.
3026         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3027         from tui_display_registers_from.
3028         (tui_display_reg_element_at_line): Update.
3029         (tui_data_window::display_registers_from_line): Rename from
3030         tui_display_registers_from_line.
3031         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3032         display_registers_from_line>: New methods.
3033
3034 2019-07-17  Tom Tromey  <tom@tromey.com>
3035
3036         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3037         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3038         from tui_erase_data_content.
3039         (tui_data_window::display_all_data)
3040         (tui_data_window::refresh_all)
3041         (tui_data_window::do_scroll_vertical): Update.
3042         * tui/tui-regs.c (tui_show_registers): Update.
3043         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3044         New method.
3045
3046 2019-07-17  Tom Tromey  <tom@tromey.com>
3047
3048         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3049         declare.
3050         * tui/tui-windata.c
3051         (tui_data_window::delete_data_content_windows): Rename from
3052         tui_delete_data_content_windows.
3053         (tui_data_window::display_all_data)
3054         (tui_data_window::do_scroll_vertical): Update.
3055         * tui/tui-data.h (struct tui_data_window)
3056         <delete_data_content_windows>: New method.
3057
3058 2019-07-17  Tom Tromey  <tom@tromey.com>
3059
3060         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3061         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3062
3063 2019-07-17  Tom Tromey  <tom@tromey.com>
3064
3065         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3066         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3067         from tui_display_all_data.
3068         * tui/tui-win.c
3069         (tui_data_window::do_make_visible_with_new_height): Update.
3070         * tui/tui-regs.c (tui_show_registers): Update.
3071         * tui/tui-layout.c (tui_set_layout): Update.
3072         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3073         method.
3074
3075 2019-07-17  Tom Tromey  <tom@tromey.com>
3076
3077         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3078         * tui/tui-windata.c (tui_display_data_from): Remove.
3079         (tui_data_window::refresh_all): Update.
3080
3081 2019-07-17  Tom Tromey  <tom@tromey.com>
3082
3083         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3084         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3085         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3086         tui_display_registers_from_line.
3087         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3088         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3089         "force_display" parameter.
3090
3091 2019-07-17  Tom Tromey  <tom@tromey.com>
3092
3093         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3094         declare.
3095         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3096         Rename from tui_first_reg_element_no_inline.
3097         (tui_display_reg_element_at_line)
3098         (tui_display_registers_from_line): Update.
3099         * tui/tui-data.h (struct tui_data_window)
3100         <first_reg_element_no_inline>: New method.
3101
3102 2019-07-17  Tom Tromey  <tom@tromey.com>
3103
3104         * tui/tui-windata.c (tui_display_data_from)
3105         (tui_data_window::do_scroll_vertical): Update.
3106         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3107         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3108         Rename from tui_line_from_reg_element_no.
3109         (tui_display_registers_from_line): Update.
3110         * tui/tui-data.h (struct tui_data_window)
3111         <line_from_reg_element_no>: New method.
3112
3113 2019-07-17  Tom Tromey  <tom@tromey.com>
3114
3115         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3116         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3117         tui_last_regs_line_no.
3118         (tui_display_reg_element_at_line)
3119         (tui_display_registers_from_line): Update.
3120         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3121         method.
3122
3123 2019-07-17  Tom Tromey  <tom@tromey.com>
3124
3125         PR tui/24722:
3126         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3127         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3128         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3129         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3130         (tui_update_breakpoint_info): Likewise.
3131         * tui/tui-hooks.c (tui_event_create_breakpoint)
3132         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3133         Update.
3134
3135 2019-07-17  Tom Tromey  <tom@tromey.com>
3136
3137         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3138
3139 2019-07-17  Tom Tromey  <tom@tromey.com>
3140
3141         * tui/tui-winsource.c (tui_update_source_window_as_is)
3142         (tui_update_source_windows_with_addr): Update.
3143         * tui/tui-source.h (tui_set_source_content)
3144         (tui_show_symtab_source): Add "win_info" parameter.
3145         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3146         parameter.
3147         (tui_show_symtab_source): Likewise.
3148
3149 2019-07-17  Tom Tromey  <tom@tromey.com>
3150
3151         * tui/tui-wingeneral.c
3152         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3153
3154 2019-07-17  Tom Tromey  <tom@tromey.com>
3155
3156         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3157         (struct tui_cmd_window) <can_scroll>: New method.
3158         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3159         method.
3160
3161 2019-07-17  Tom Tromey  <tromey@adacore.com>
3162
3163         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3164         do_field_signed>: Rename.  Change type of "value".
3165         * ui-out.c (ui_out::field_signed): Rename from field_int.
3166         Change type of "value".
3167         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3168         type of "value".
3169         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3170         do_field_int.  Change type of "value".
3171         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3172         do_field_int.  Change type of "value".
3173         * tracepoint.c (trace_status_mi, tfind_1)
3174         (print_one_static_tracepoint_marker): Update.
3175         * thread.c (print_thread_info_1, print_selected_thread_frame):
3176         Update.
3177         * stack.c (print_frame, print_frame_info): Update.
3178         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3179         Update.
3180         * source.c (print_source_lines_base): Update.
3181         * skip.c (info_skip_command): Update.
3182         * record-btrace.c (btrace_ui_out_decode_error)
3183         (btrace_call_history_src_line): Update.
3184         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3185         Update.
3186         * progspace.c (print_program_space): Update.
3187         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3188         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3189         do_field_int.  Change type of "value".
3190         * mi/mi-out.c (mi_ui_out::do_table_begin)
3191         (mi_ui_out::do_table_header): Update.
3192         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3193         type of "value".
3194         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3195         (mi_cmd_data_list_changed_registers, output_register)
3196         (mi_cmd_data_read_memory, mi_load_progress)
3197         (mi_cmd_trace_frame_collected): Update.
3198         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3199         Update.
3200         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3201         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3202         (mi_cmd_var_list_children, varobj_update_one): Update.
3203         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3204         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3205         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3206         * inferior.c (print_inferior): Update.
3207         * gdb_bfd.c (print_one_bfd): Update.
3208         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3209         Update.
3210         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3211         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3212         do_field_int.  Change type of "value".
3213         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3214         do_field_int.  Change type of "value".
3215         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3216         (print_one_breakpoint_location, print_it_catch_fork)
3217         (print_one_catch_fork, print_it_catch_vfork)
3218         (print_one_catch_vfork, print_it_catch_solib)
3219         (print_it_catch_exec, print_it_ranged_breakpoint)
3220         (print_mention_watchpoint, print_mention_masked_watchpoint)
3221         (bkpt_print_it, update_static_tracepoint): Update.
3222         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3223         * break-catch-syscall.c (print_it_catch_syscall): Update.
3224         * ada-tasks.c (print_ada_task_info): Update.
3225         * ada-lang.c (print_it_exception, print_mention_exception):
3226         Update.
3227
3228 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3229
3230         PR breakpoints/24541
3231         * gdbarch.c: Regenerate.
3232         * gdbarch.h: Regenerate.
3233         * gdbarch.sh: Adjust return type and parameter types for
3234         'stap_adjust_register'.
3235         (i386_stap_adjust_register): Adjust signature and return new
3236         register name.
3237         * stap-probe.c (stap_parse_register_operand): Adjust use of
3238         'gdbarch_stap_adjust_register'.
3239
3240 2019-07-17  Tom Tromey  <tromey@adacore.com>
3241
3242         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3243         declare VEC.
3244         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3245         std::vector.
3246         (struct s390_process_info): Add initializers.
3247         (s390_add_process): Use new.
3248         (s390_linux_nat_target::low_forget_process): Use delete.
3249         (s390_linux_nat_target::low_new_fork)
3250         (s390_linux_nat_target::stopped_by_watchpoint)
3251         (s390_linux_nat_target::low_prepare_to_resume)
3252         (s390_linux_nat_target::insert_watchpoint)
3253         (s390_linux_nat_target::insert_hw_breakpoint)
3254         (s390_linux_nat_target::remove_watchpoint)
3255         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3256
3257 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3258
3259         * aarch64-fbsd-nat.c: Include regcache.h.
3260         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3261         argument.
3262         (aarch64_fbsd_nat_target::fetch_registers)
3263         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3264         variable.
3265         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3266
3267 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3268
3269         * fbsd-nat.c: Include gdbarch.h.
3270
3271 2019-07-15  Tom Tromey  <tromey@adacore.com>
3272
3273         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3274
3275 2019-07-15  Tom Tromey  <tromey@adacore.com>
3276
3277         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3278         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3279         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3280         * cli-out.c (cli_ui_out::do_field_int): New method.
3281         * ui-out.c (ui_out::field_unsigned): New method.
3282         * symfile.c (generic_load): Use field_unsigned.
3283         (print_transfer_performance): Likewise.
3284         * record-btrace.c (ui_out_field_uint): Remove.
3285         (btrace_call_history_insn_range, btrace_call_history): Use
3286         field_unsigned.
3287         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3288         field_unsigned.
3289         * ui-out.h (class ui_out) <field_unsigned>: New method.
3290         <do_field_unsigned>: Likewise.
3291
3292 2019-07-15  Tom Tromey  <tromey@adacore.com>
3293
3294         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3295         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3296         * target.c (flash_erase_command): Use field_string.
3297         * infrun.c (print_signal_received_reason): Use field_string.
3298         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3299         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3300         field_string.
3301         * ada-tasks.c (print_ada_task_info): Use field_string.
3302
3303 2019-07-15  Tom Tromey  <tromey@adacore.com>
3304
3305         * target.c (flash_erase_command): Use field_core_addr.
3306         * symfile.c (generic_load): Use field_core_addr.
3307         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3308         Use field_core_addr.
3309         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3310         field_core_addr.
3311
3312 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3313
3314         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3315         value if its desired type is smaller than a CORE_ADDR and signed.
3316
3317 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3318
3319         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3320         of changes to field names, and use new is_reference field to
3321         decide if a property is a reference or not.
3322         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3323         field.
3324         (struct dwarf2_property_baton): Update header comment, rename
3325         'referenced_type' to 'property_type' and update comments.
3326         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3327         default property type, store in property baton, update to take
3328         accound of renamed field.
3329         (read_func_scope): Update call to attr_to_dynamic_prop.
3330         (read_array_type): Likewise.
3331         (dwarf2_per_cu_addr_sized_int_type): New function.
3332         (read_subrange_index_type): Move type finding code to
3333         dwarf2_per_cu_addr_sized_int_type.
3334         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3335         (dwarf2_per_cu_addr_type): New function.
3336         (set_die_type): Update calls to attr_to_dynamic_prop.
3337
3338 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3339
3340         * dwarf2read.c (read_subrange_index_type): New function.
3341         (read_subrange_type): Move code into new function and call it.
3342         * gdbtypes.c (create_range_type): Add some asserts.
3343
3344 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3345
3346         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3347         update return statements.
3348         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3349         declaration, and update comment to match.
3350         * gdbtypes.c (resolve_dynamic_array): Update call to
3351         dwarf2_evaluate_property to match new return type.
3352
3353 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3354
3355         * valarith.c (value_subscripted_rvalue): Change lowerbound
3356         parameter type from int to LONGEST.
3357         * value.h (value_subscripted_rvalue): Likewise in declaration.
3358
3359 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3360
3361         * cli/cli-utils.c (info_print_command_completer): New function.
3362         * cli/cli-utils.h: Add 'completer.h' include, and forward
3363         declaration for 'struct cmd_list_element'.
3364         (info_print_command_completer): Declare.
3365         * stack.c (_initialize_stack): Add completer for 'info locals' and
3366         'info args'.
3367         * symtab.c (_initialize_symtab): Add completer for 'info
3368         variables' and 'info functions'.
3369         * NEWS: Mention completion for additional info commands.
3370
3371 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3372
3373         * cli/cli-utils.c (extract_info_print_args): Delete.
3374         (extract_arg_maybe_quoted): Delete.
3375         (info_print_options_defs): New variable.
3376         (make_info_print_options_def_group): New function.
3377         (extract_info_print_options): Define new function.
3378         * cli/cli-utils.h (extract_info_print_args): Delete.
3379         (struct info_print_options): New structure.
3380         (extract_info_print_options): Declare new function.
3381         * stack.c (info_locals_command): Update to use new
3382         extract_info_print_options, also add a header comment.
3383         (info_args_command): Likewise.
3384         * symtab.c (info_variables_command): Likewise.
3385         (info_functions_command): Likewise.
3386
3387 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3388
3389         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3390         to extract string arguments.
3391         * common/common-utils.c (extract_string_maybe_quoted): New function.
3392         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3393
3394 2019-07-11  Tom Tromey  <tromey@adacore.com>
3395
3396         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3397         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3398         * top.h (gdbinit): Don't declare.
3399         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3400         into...
3401         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3402         * top.c (gdb_init): Don't call init_cli_cmds.
3403         (gdbinit): Remove.
3404         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3405
3406 2019-07-11  Tom Tromey  <tromey@adacore.com>
3407
3408         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3409         after it has been moved.
3410
3411 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3412
3413         * valops.c (value_must_coerce_to_target): Change return type to
3414         bool.
3415         * value.h (value_must_coerce_to_target): Likewise.
3416
3417 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3418
3419         * breakpoint.c (is_hardware_watchpoint): Remove
3420         forward-declaration.
3421         (is_masked_watchpoint): Change return type to bool.
3422         (is_tracepoint): Likewise.
3423         (is_breakpoint): Likewise.
3424         (is_hardware_watchpoint): Likewise.
3425         (is_watchpoint): Likewise.
3426         (is_no_memory_software_watchpoint): Likewise.
3427         (is_catchpoint): Likewise.
3428         (breakpoint_1): Make FILTER parameter's return type bool.
3429         is_masked_watchpoint): Change return type to bool.
3430         (save_breakpoints): Make FILTER parameter's return type bool.
3431         * breakpoint.h (is_breakpoint): Change return type to bool.
3432         (is_watchpoint): Likewise.
3433         (is_catchpoint): Likewise.
3434         (is_tracepoint): Likewise.
3435
3436 2019-07-10  Tom Tromey  <tom@tromey.com>
3437
3438         * defs.h: Don't include gdbarch.h.
3439         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3440         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3441         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3442         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3443         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3444         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3445         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3446         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3447         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3448         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3449         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3450         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3451         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3452         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3453         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3454         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3455         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3456         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3457         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3458         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3459         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3460         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3461         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3462         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3463         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3464         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3465         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3466
3467 2019-07-10  Tom Tromey  <tromey@adacore.com>
3468
3469         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3470         * breakpoint.c (init_ada_exception_breakpoint): Register as
3471         bp_catchpoint.
3472         (print_one_breakpoint_location, print_one_breakpoint): Use
3473         is_ada_exception_catchpoint.
3474         * ada-lang.c (class ada_catchpoint_location): Pass
3475         bp_loc_software_breakpoint to bp_location constructor.
3476         (is_ada_exception_catchpoint): New function.
3477
3478 2019-07-10  Tom Tromey  <tromey@adacore.com>
3479
3480         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3481         VEC.
3482         (struct arm_exidx_entry): New method operator<.
3483         (struct arm_exidx_data) <section_maps>: Change type.
3484         (arm_exidx_data_free): Remove.
3485         (arm_exidx_data_key): Change type.  Move lower.
3486         (arm_exidx_new_objfile): Update.
3487         (arm_compare_exidx_entries): Remove.
3488         (arm_find_exidx_entry, _initialize_arm_tdep)
3489
3490 2019-07-10  Tom Tromey  <tromey@adacore.com>
3491
3492         * solib-spu.c (ocl_program_data_key): Change type.
3493         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3494         Update.
3495
3496 2019-07-10  Tom Tromey  <tromey@adacore.com>
3497
3498         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3499         (struct solib_aix_inferior_data) <library_list>: Change type.
3500         (solib_aix_inferior_data_handle): Change type.
3501         (get_solib_aix_inferior_data): Update.
3502         (solib_aix_free_library_list): Remove.
3503         (library_list_start_library): Update.
3504         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3505         return type.
3506         (solib_aix_get_library_list)
3507         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3508         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3509
3510 2019-07-10  Tom Tromey  <tromey@adacore.com>
3511
3512         * solib-dsbt.c (struct dsbt_info): Add initializers.
3513         (solib_dsbt_pspace_data): Change type.
3514         (dsbt_pspace_data_cleanup): Remove.
3515         (get_dsbt_info, _initialize_dsbt_solib): Update.
3516
3517 2019-07-10  Tom Tromey  <tromey@adacore.com>
3518
3519         * spu-tdep.c (spu_overlay_data): Change type.
3520         (spu_get_overlay_table, spu_overlay_new_objfile)
3521         (_initialize_spu_tdep): Update.
3522
3523 2019-07-10  Tom Tromey  <tromey@adacore.com>
3524
3525         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3526         destructor.
3527         (dbx_objfile_data_key): Change type and declare later.
3528         (DBX_SYMFILE_INFO): Rewrite.
3529         * dbxread.c (dbx_objfile_data_key): Change type.
3530         (dbx_symfile_init): Update.
3531         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3532         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3533         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3534
3535 2019-07-10  Tom Tromey  <tromey@adacore.com>
3536
3537         * jit.c (jit_program_space_key): Change type.  Move lower.
3538         (get_jit_program_space_data): Update.
3539         (jit_program_space_data_cleanup): Remove.
3540         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3541         Update.
3542         (struct jit_program_space_data): Add initializers.
3543
3544 2019-07-10  Tom Tromey  <tromey@adacore.com>
3545
3546         * solib-darwin.c (struct darwin_info): Add initializers.
3547         (solib_darwin_pspace_data): Change type.
3548         (darwin_pspace_data_cleanup): Remove.
3549         (get_darwin_info, _initialize_darwin_solib): Update.
3550
3551 2019-07-10  Tom Tromey  <tromey@adacore.com>
3552
3553         * remote-sim.c (struct sim_inferior_data): Add initializers,
3554         constructor, and destructor.
3555         (sim_inferior_data_key): Change type.  Move lower.
3556         (check_for_duplicate_sim_descriptor): Update.
3557         (get_sim_inferior_data): Use new.  Update.
3558         (~sim_inferior_data_cleanup): Rename from
3559         sim_inferior_data_cleanup.  Simplify.
3560         (gdbsim_close_inferior, simulator_command)
3561         (sim_command_completer, _initialize_remote_sim): Update.
3562         (next_pid, INITIAL_PID): Move earlier.
3563
3564 2019-07-10  Tom Tromey  <tromey@adacore.com>
3565
3566         * python/python-internal.h (create_thread_object): Return
3567         gdbpy_ref.
3568         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3569         * python/py-inferior.c (struct threadlist_entry): Add
3570         constructor.
3571         <thread_obj>: Now a gdbpy_ref.
3572         (thread_to_thread_object): Update.
3573         (add_thread_object): Use new.
3574         (delete_thread_object): Use delete.
3575         (infpy_threads): Update.
3576         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3577         GIL.
3578
3579 2019-07-10  Tom Tromey  <tromey@adacore.com>
3580
3581         * valops.c (value_cast): Specialize error message for Ada.
3582
3583 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3584
3585         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3586
3587 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3588
3589         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3590         bpstat_should_step): Return bool, adjust comments.
3591         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3592         bpstat_should_step): Likewise.
3593
3594 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3595
3596         * features/Makefile: Use feature target descriptions for Arm.
3597         * features/arm/arm-core.c: Generate new file.
3598         * features/arm/arm-fpa.c: Likewise.
3599         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3600         * features/arm/arm-m-profile.c: Likewise.
3601         * features/arm/arm-vfpv2.c: Likewise.
3602         * features/arm/arm-vfpv3.c: Likewise.
3603         * features/arm/xscale-iwmmxt.c: Likewise.
3604         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3605
3606 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3607
3608         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3609         ptrace earlier.
3610
3611 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3612
3613         * features/aarch64-pauth.c: Regenerate.
3614
3615 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3616
3617         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3618         bool.
3619         (bpstat_what): Use false instead of 0.
3620
3621 2019-07-09  Pedro Alves  <palves@redhat.com>
3622
3623         * break-catch-throw.c (is_exception_catchpoint): New.
3624         * breakpoint.c (print_one_breakpoint_location): New parameter
3625         'raw_loc'.  Handle it.  Use
3626         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3627         looking at the breakpoint's type.
3628         (print_one_breakpoint): If handling "maint info breakpoints", also
3629         print locations of exception catchpoints.
3630         * breakpoint.h (is_exception_catchpoint): Declare.
3631
3632 2019-07-09  Pedro Alves  <palves@redhat.com>
3633
3634         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3635         "addr" field.
3636         (allocate_location_exception_catchpoint): New.
3637         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3638         (initialize_throw_catchpoint_ops): Install
3639         allocate_location_exception_catchpoint as allocate_location
3640         method.
3641         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3642         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3643         bp_loc_other.
3644         (breakpoint_address_is_meaningful): Delete.
3645         (bl_address_is_meaningful): New.
3646         (breakpoint_locations_match): Adjust comment.
3647         (bp_location_from_bp_type): New, factored out of...
3648         (bp_location::bp_location(breakpoint *)): ... this.
3649         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3650         factored out of...
3651         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3652         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3653         breakpoint_address_is_meaningful.
3654         (bp_locations_compare): Adjust comment.
3655         (update_global_location_list): Use bl_address_is_meaningful
3656         instead of breakpoint_address_is_meaningful.
3657         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3658         explicit.
3659         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3660         * python/py-breakpoint.c (bppy_get_location): No longer check
3661         whether location is null.
3662
3663 2019-07-09  Pedro Alves  <palves@redhat.com>
3664
3665         PR c++/15468
3666         * breakpoint.c (print_one_breakpoint_location): Remove
3667         single-location assert.
3668
3669 2019-07-09  Tom Tromey  <tom@tromey.com>
3670
3671         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3672         * configure: Rebuild.
3673         * configure.ac: Change common to gdbsupport.
3674         * gdbsupport: Rename from common.
3675         * acinclude.m4: Change common to gdbsupport.
3676         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3677         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3678         gdbsupport.
3679         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3680         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3681         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3682         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3683         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3684         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3685         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3686         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3687         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3688         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3689         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3690         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3691         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3692         coff-pe-read.c, command.h, compile/compile-c-support.c,
3693         compile/compile-c.h, compile/compile-cplus-symbols.c,
3694         compile/compile-cplus-types.c, compile/compile-cplus.h,
3695         compile/compile-loc2c.c, compile/compile.c, completer.c,
3696         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3697         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3698         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3699         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3700         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3701         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3702         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3703         features/aarch64-core.c, features/aarch64-fpu.c,
3704         features/aarch64-pauth.c, features/aarch64-sve.c,
3705         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3706         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3707         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3708         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3709         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3710         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3711         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3712         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3713         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3714         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3715         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3716         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3717         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3718         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3719         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3720         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3721         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3722         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3723         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3724         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3725         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3726         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3727         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3728         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3729         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3730         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3731         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3732         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3733         minsyms.c, mips-linux-tdep.c, namespace.h,
3734         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3735         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3736         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3737         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3738         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3739         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3740         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3741         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3742         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3743         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3744         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3745         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3746         procfs.c, producer.c, progspace.h, psymtab.h,
3747         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3748         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3749         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3750         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3751         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3752         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3753         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3754         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3755         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3756         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3757         target-memory.c, target.c, target.h, target/waitstatus.c,
3758         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3759         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3760         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3761         unittests/array-view-selftests.c,
3762         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3763         unittests/common-utils-selftests.c,
3764         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3765         unittests/format_pieces-selftests.c,
3766         unittests/function-view-selftests.c,
3767         unittests/lookup_name_info-selftests.c,
3768         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3769         unittests/mkdir-recursive-selftests.c,
3770         unittests/observable-selftests.c,
3771         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3772         unittests/parse-connection-spec-selftests.c,
3773         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3774         unittests/scoped_fd-selftests.c,
3775         unittests/scoped_mmap-selftests.c,
3776         unittests/scoped_restore-selftests.c,
3777         unittests/string_view-selftests.c, unittests/style-selftests.c,
3778         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3779         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3780         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3781         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3782         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3783         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3784
3785 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3786
3787         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3788         bool value.
3789         (decode_digits_ordinary): Set explicit_line field in sal.
3790         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3791         symtab_and_line that was set on an explicit line number in
3792         assembler code.  Do always update the recorded symtab and line if
3793         we do skip the prologue.
3794
3795 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3796
3797         * breakpoint.c (set_breakpoint_location_function): Remove
3798         explicit_loc parameter.
3799         (momentary_breakpoint_from_master): Update call to
3800         set_breakpoint_location_function.
3801         (add_location_to_breakpoint): Likewise.
3802
3803 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3804
3805         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3806         required features based on default bfd type when no specific bfd
3807         is present.
3808
3809 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3810
3811         * NEWS: Mention that GDB printf and eval commands can now print
3812         C-style and Ada-style convenience var strings without
3813         calling the inferior.
3814         * printcmd.c (printf_c_string): Locally print GDB internal var
3815         instead of transiting via the inferior.
3816         (printf_wide_c_string): Likewise.
3817
3818 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3819
3820         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3821
3822 2019-07-04  Tom Tromey  <tom@tromey.com>
3823
3824         PR tui/24724:
3825         * tui/tui-winsource.c (tui_clear_source_content): Update.
3826         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3827         (tui_update_breakpoint_info): Update.
3828         (tui_set_exec_info_content): Update.
3829         * tui/tui-source.c (tui_set_source_content_nil): Update.
3830         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3831         has_break.
3832         * tui/tui-data.h (enum tui_bp_flag): New.
3833         (tui_bp_flags): New enum flags type.
3834         (struct tui_source_element) <break_mode>: Change type.  Rename
3835         from has_break.
3836         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3837         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3838         constants.
3839         * tui/tui-winsource.h: Fix comment.
3840
3841 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3842
3843         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3844         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3845         (store_fpregs_to_thread)
3846         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3847         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3848         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3849         (IWMMXT_REGS_SIZE): Add define.
3850         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3851         (fetch_vfp_regs, store_vfp_regs)
3852         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3853         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3854
3855 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3856
3857         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3858         defines.
3859         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3860         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3861         (ARM_INT_REGISTER_SIZE): ...to this.
3862         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3863         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3864         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3865         (arm_linux_collect_gregset, supply_nwfpe_register)
3866         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3867         defines.
3868         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3869         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3870         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3871         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3872         (arm_return_in_memory, arm_store_return_value)
3873         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3874         (arm_record_ld_st_multiple): Likewise.
3875         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3876         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3877
3878 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3879
3880         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3881         AARCH64_DISPLACED_MODIFIED_INSNS.
3882         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3883         (aarch64_displaced_step_copy_insn): Likewise.
3884         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3885         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3886         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3887         ARM_DISPLACED_MODIFIED_INSNS.
3888         * arm-tdep.c (arm_gdbarch_init): Likewise.
3889         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3890         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3891         (struct arm_displaced_step_closure): Use
3892         ARM_DISPLACED_MODIFIED_INSNS.
3893
3894 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3895
3896         * features/Makefile: Remove unused xml files.
3897         * features/aarch64.xml: Remove.
3898         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3899         * features/i386/amd64-avx-avx512.xml: Remove.
3900         * features/i386/amd64-avx-linux.xml: Remove.
3901         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3902         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3903         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3904         * features/i386/amd64-avx-mpx.xml: Remove.
3905         * features/i386/amd64-avx.xml: Remove.
3906         * features/i386/amd64-linux.xml: Remove.
3907         * features/i386/amd64-mpx-linux.xml: Remove.
3908         * features/i386/amd64-mpx.xml: Remove.
3909         * features/i386/amd64.xml: Remove.
3910         * features/i386/i386-avx-avx512-linux.xml: Remove.
3911         * features/i386/i386-avx-avx512.xml: Remove.
3912         * features/i386/i386-avx-linux.xml: Remove.
3913         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3914         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3915         * features/i386/i386-avx-mpx-linux.xml: Remove.
3916         * features/i386/i386-avx-mpx.xml: Remove.
3917         * features/i386/i386-avx.xml: Remove.
3918         * features/i386/i386-linux.xml: Remove.
3919         * features/i386/i386-mmx-linux.xml: Remove.
3920         * features/i386/i386-mmx.xml: Remove.
3921         * features/i386/i386-mpx-linux.xml: Remove.
3922         * features/i386/i386-mpx.xml: Remove.
3923         * features/i386/i386.xml: Remove.
3924         * features/i386/x32-avx-avx512-linux.xml: Remove.
3925         * features/i386/x32-avx-linux.xml: Remove.
3926         * features/i386/x32-linux.xml: Remove.
3927
3928 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3929
3930         * regformats/aarch64.dat: Remove.
3931         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3932         * regformats/i386/amd64-avx-linux.dat: Remove.
3933         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3934         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3935         * regformats/i386/amd64-linux.dat: Remove.
3936         * regformats/i386/amd64-mpx-linux.dat: Remove.
3937         * regformats/i386/amd64.dat: Remove.
3938         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3939         * regformats/i386/i386-avx-linux.dat: Remove.
3940         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3941         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3942         * regformats/i386/i386-linux.dat: Remove.
3943         * regformats/i386/i386-mmx-linux.dat: Remove.
3944         * regformats/i386/i386-mpx-linux.dat: Remove.
3945         * regformats/i386/i386.dat: Remove.
3946         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3947         * regformats/i386/x32-avx-linux.dat: Remove.
3948         * regformats/i386/x32-linux.dat: Remove.
3949
3950 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3951
3952         * aarch64-tdep.c: Remove xml self tests.
3953         * amd64-linux-tdep.c: Likewise.
3954         * amd64-tdep.c: Likewise.
3955         * i386-linux-tdep.c: Likewise.
3956         * i386-tdep.c: Likewise.
3957
3958 2019-07-03  Pedro Alves  <palves@redhat.com>
3959
3960         PR cli/24732
3961         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3962         (pipe_cmd_option_defs): New.
3963         (make_pipe_cmd_options_def_group): New.
3964         (pipe_command): Use gdb::option::process_options.
3965         (pipe_command_completer): New function.
3966         (_initialize_cli_cmds): Install completer for "pipe" command.
3967
3968 2019-07-03  Pedro Alves  <palves@redhat.com>
3969
3970         * cli/cli-option.c (union option_value) <string>: New field.
3971         (struct option_def_and_value): Add ctor, move ctor, dtor and
3972         use DISABLE_COPY_AND_ASSIGN.
3973         (option_def_and_value::clear_value): New.
3974         (parse_option, save_option_value_in_ctx, get_val_type_str)
3975         (add_setshow_cmds_for_options): Handle var_string.
3976         * cli-option.h (union option_def::var_address) <string>: New
3977         field.
3978         (struct string_option_def): New.
3979         * maint-test-options.c (struct test_options_opts): Add default
3980         ctor and use DISABLE_COPY_AND_ASSIGN.
3981         <string_opt>: New field.
3982         (test_options_opts::~test_options_opts): New.
3983         (test_options_opts::dump): Also dump "-string".
3984         (test_options_option_defs): Install "string.
3985
3986 2019-07-03  Pedro Alves  <palves@redhat.com>
3987
3988         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3989         option_value with a null enumeration.
3990         (complete_options): Save the option values in the context.
3991         (save_option_value_in_ctx): New, factored out from ...
3992         (process_options): ... here.
3993         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3994         of the function.
3995         * maint-test-options.c (test_options_opts::dump): New, factored
3996         out from ...
3997         (maintenance_test_options_command_mode): ... here.
3998         (maintenance_test_options_command_completion_result): Delete.
3999         (maintenance_test_options_command_completion_text): Update
4000         comment.
4001         (maintenance_show_test_options_completion_result): Change
4002         prototype.  Just print
4003         maintenance_test_options_command_completion_text.
4004         (save_completion_result): New.
4005         (maintenance_test_options_completer_mode): Pass options context to
4006         complete_options, and then save a dump.
4007         (_initialize_maint_test_options): Use add_cmd to install "maint
4008         show test-options-completion-result".
4009
4010 2019-07-03  Pedro Alves  <palves@redhat.com>
4011
4012         * NEWS (New commands): Mention "with" and "maint with".
4013         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4014         (with_command, with_command_completer): New.
4015         (pipe_command): Adjust to new repeat_previous
4016         interface.
4017         (_initialize_cli_cmds): Install the "with" command and its "w"
4018         alias.
4019         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4020         declarations.
4021         * cli/cli-setshow.c (parse_cli_var_uinteger)
4022         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4023         argument strings for all var_types.
4024         (get_setshow_command_value_string): New, factored out from ...
4025         (do_show_command): ... this.
4026         * cli/cli-setshow.h: Include <string>.
4027         (get_setshow_command_value_string): Declare.
4028         * command.h (repeat_previous): Now returns const char *.  Adjust
4029         comment.
4030         * maint.c: Include "cli/cli-cmds.h".
4031         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4032         (_initialize_maint_cmds): Register the "maintenance with" command.
4033         * top.c (repeat_previous): Move bits from pipe_command here:
4034         Return the saved command line, if any; error out if there's no
4035         command to relaunch.
4036
4037 2019-07-03  Pedro Alves  <palves@redhat.com>
4038
4039         * NEWS (New commands): Mention "maint set/show test-settings"
4040         instead of "maint test-settings".
4041         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4042         (maintenance_test_settings_set_list): Rename to ...
4043         (maintenance_set_test_settings_list): ... this.
4044         (maintenance_test_settings_show_list): Rename to  ...
4045         (maintenance_show_test_settings_list): ... this.
4046         (maintenance_test_settings_cmd): Delete.
4047         (maintenance_test_settings_set_cmd): ...
4048         (maintenance_set_test_settings_cmd): ... this.
4049         (maintenance_test_settings_show_cmd): ...
4050         (maintenance_show_test_settings_cmd): ... this.
4051         (maintenance_test_settings_show_value_cmd):
4052         (maintenance_show_test_settings_value_cmd): ... this.
4053         (_initialize_maint_test_settings): No longer install the "maint
4054         test-settings" prefix command.  Rename "maint test-settings set"
4055         to "maint set test-settings", and "maint test-settings show" to
4056         "maint show test-settings".  Adjust all subcommands.
4057
4058 2019-07-03  Pedro Alves  <palves@redhat.com>
4059
4060         * maint-test-settings.c: Fix file's intro comment.  Replace all
4061         references to "test-options" with references to "test-settings",
4062         in comments.
4063
4064 2019-07-03  Pedro Alves  <palves@redhat.com>
4065
4066         * maint-test-settings.c (maintenance_test_settings_xxx)
4067         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4068         New.
4069         (maintenance_test_settings_enums): Use them.
4070         (maintenance_test_settings_enum): Default to
4071         maintenance_test_settings_xxx.
4072         (_initialize_maint_test_settings): Initialize
4073         MAINTENANCE_TEST_SETTINGS_FILENAME.
4074
4075 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4076
4077         * breakpoint.h (remove_breakpoints_inf): Change return type to
4078         void, move function documentation here.
4079         * breakpoint.c (remove_breakpoints_inf): Change return type to
4080         void, move function documentation to header.
4081
4082 2019-07-02  Pedro Alves  <palves@redhat.com>
4083
4084         * NEWS (Completion improvements): Mention "info threads".
4085         * thread.c (struct info_threads_opts, info_threads_option_defs)
4086         (make_info_threads_options_def_group): New.
4087         (info_threads_command): Use gdb::option::process_options.
4088         (info_threads_command_completer): New.
4089         (_initialize_thread): Use gdb::option::build_help to build the
4090         help text for "info threads".
4091
4092 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4093
4094         * defs.h (generic_load): Move from here...
4095         * symfile.h (generic_load): ... to here.  Rename name parameter
4096         to args.
4097         * symfile.c (generic_load): Add comment.
4098
4099 2019-07-01  Tom Tromey  <tromey@adacore.com>
4100
4101         * dwarf2read.c
4102         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4103         declaration of without_params.  Fix formatting.
4104
4105 2019-07-01  Tom Tromey  <tromey@adacore.com>
4106
4107         * ada-exp.y (find_primitive_type): Update.
4108         * ada-lang.h (ada_lookup_symbol): Update.
4109         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4110         parameter.
4111         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4112
4113 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4114
4115         PR breakpoints/24541
4116         * gdbarch.c: Regenerate.
4117         * gdbarch.h: Regenerate.
4118         * gdbarch.sh: Add 'stap_adjust_register'.
4119         * i386-tdep.c: Include '<unordered_set>'.
4120         (i386_stap_adjust_register): New function.
4121         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4122         * stap-probe.c (stap_parse_register_operand): Call
4123         'gdbarch_stap_adjust_register'.
4124
4125 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4126
4127         PR python/24742
4128         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4129         * python/python.c (do_start_initialization): Use 'xmalloc'
4130         instead of 'PyMem_Malloc'.
4131
4132 2019-06-28  Tom Tromey  <tromey@adacore.com>
4133
4134         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4135         for Ada.
4136
4137 2019-06-27  Tom Tromey  <tromey@adacore.com>
4138
4139         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4140         objfile_key.
4141         (arm_find_mapping_symbol, arm_record_special_symbol)
4142         (_initialize_arm_tdep): Update.
4143         (arm_objfile_data_free): Remove.
4144
4145 2019-06-27  Tom Tromey  <tromey@adacore.com>
4146
4147         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4148         to cp_print_static_field.
4149
4150 2019-06-26  Tom Tromey  <tromey@adacore.com>
4151
4152         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4153         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4154         declare.
4155
4156 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4157
4158         * features/aarch64-core.c (create_feature_aarch64_core):
4159         Regenerate.
4160         * features/aarch64-core.xml: Add cpsr flags.
4161
4162 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4163
4164         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4165         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4166
4167 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4168
4169         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4170         field.
4171         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4172         use.
4173         (arm_record_special_symbol): Don't insert new symbol in sorted
4174         position, push it at the end.
4175
4176 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4177
4178         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4179         (arm_mapping_symbol_s): Remove.
4180         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4181         (arm_mapping_symbol_vec): New typedef.
4182         (struct arm_per_objfile): Add constructor.
4183         <section_maps>: Change type to
4184         std::unique_ptr<arm_mapping_symbol_vec[]>.
4185         (arm_compare_mapping_symbols): Remove.
4186         (arm_find_mapping_symbol): Adjust to section_maps type change.
4187         (arm_objfile_data_free): Call delete on arm_per_objfile.
4188         (arm_record_special_symbol): Adjust to section_maps type change.
4189         Allocate arm_per_objfile with new.
4190
4191 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4192
4193         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4194         with the command prefix.
4195
4196 2019-06-25  Tom Tromey  <tom@tromey.com>
4197
4198         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4199         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4200
4201 2019-06-25  Tom Tromey  <tom@tromey.com>
4202
4203         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4204         type.
4205         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4206         protected.
4207
4208 2019-06-25  Tom Tromey  <tom@tromey.com>
4209
4210         * tui/tui-winsource.c
4211         (tui_source_window_base::set_is_exec_point_at): Add check against
4212         LOA_ADDRESS.
4213
4214 2019-06-25  Tom Tromey  <tom@tromey.com>
4215
4216         * tui/tui-source.c (tui_set_source_content): Don't check before
4217         xfree.
4218         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4219
4220 2019-06-25  Tom Tromey  <tom@tromey.com>
4221
4222         * tui/tui-winsource.h (tui_update_source_window_as_is)
4223         (tui_alloc_source_buffer, tui_line_is_displayed)
4224         (tui_addr_is_displayed): Change type of win_info.
4225         * tui/tui-winsource.c (tui_update_source_window_as_is)
4226         (tui_clear_source_content, tui_show_source_line)
4227         (tui_show_source_content, tui_source_window_base::refill)
4228         (tui_source_window_base::set_is_exec_point_at)
4229         (tui_source_window_base::set_is_exec_point_at)
4230         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4231         (tui_alloc_source_buffer, tui_line_is_displayed)
4232         (tui_addr_is_displayed): Change type of win_info.  Update.
4233         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4234         (tui_source_window_base::do_make_visible_with_new_height):
4235         Update.
4236         * tui/tui-source.c (tui_set_source_content)
4237         (tui_set_source_content_nil)
4238         (tui_source_window::do_scroll_vertical): Update.
4239         * tui/tui-layout.c (show_layout): Update.
4240         * tui/tui-disasm.c (tui_set_disassem_content)
4241         (tui_disasm_window::do_scroll_vertical): Update.
4242         * tui/tui-data.h (tui_win_content): Remove.
4243         (struct tui_gen_win_info) <content, content_size>: Remove.
4244         (struct tui_source_element): Add initializers and destructor.
4245         (union tui_which_element, struct tui_win_element): Remove.
4246         (struct tui_source_window_base) <content>: New field.
4247         (struct tui_data_window): Remove destructor.
4248         (tui_alloc_content, tui_free_win_content)
4249         (tui_free_all_source_wins_content): Don't declare.
4250         * tui/tui-data.c (tui_initialize_static_data): Update.
4251         (init_content_element, tui_alloc_content): Remove.
4252         (~tui_gen_win_info): Update.
4253         (~tui_data_window, tui_free_all_source_wins_content)
4254         (tui_free_win_content, free_content, free_content_elements):
4255         Remove.
4256
4257 2019-06-25  Tom Tromey  <tom@tromey.com>
4258
4259         * tui/tui-winsource.h (tui_clear_source_content)
4260         (tui_erase_source_content, tui_show_source_content): Change type
4261         of win_info.
4262         * tui/tui-winsource.c (tui_clear_source_content)
4263         (tui_erase_source_content, tui_show_source_content): Change type
4264         of win_info.
4265         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4266         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4267         win_info.
4268         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4269         win_info.
4270         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4271
4272 2019-06-25  Tom Tromey  <tom@tromey.com>
4273
4274         * tui/tui-winsource.c (tui_clear_source_content)
4275         (tui_source_window_base::set_is_exec_point_at): Update.
4276         * tui/tui-source.c (tui_set_source_content_nil): Update.
4277         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4278         a bool.
4279         * tui/tui-data.c (init_content_element): Update.
4280
4281 2019-06-25  Tom Tromey  <tom@tromey.com>
4282
4283         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4284         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4285         * tui/tui-layout.c (init_and_make_win): Update.
4286         * tui/tui.h (enum tui_win_type): Update.
4287         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4288         tui_win_is_auxillary.
4289         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4290         tui_win_is_auxillary.
4291
4292 2019-06-25  Tom Tromey  <tom@tromey.com>
4293
4294         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4295         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4296         (tui_delete_data_content_windows, tui_display_all_data)
4297         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4298         Update.
4299         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4300         * tui/tui-regs.c (tui_last_regs_line_no)
4301         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4302         (tui_show_registers): Update.
4303         (tui_show_register_group): Return void.  Update.
4304         (tui_display_registers_from, tui_display_reg_element_at_line)
4305         (tui_display_registers_from_line, tui_check_register_values):
4306         Update.
4307         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4308         member.
4309         (struct tui_data_window) <regs_content>: Now a std::vector.
4310         <regs_content_count>: Remove.
4311         (tui_add_content_elements, tui_free_data_content): Don't declare.
4312         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4313         (init_content_element): Remove DATA_WIN case.  Add assert.
4314         (tui_add_content_elements): Remove.
4315         (tui_data_window): Update.
4316         (tui_free_data_content): Remove.
4317         (free_content_elements): Remove DATA_WIN case.
4318
4319 2019-06-25  Tom Tromey  <tom@tromey.com>
4320
4321         * tui/tui-data.c (tui_data_item_window): Update.
4322         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4323         * tui/tui-windata.c (tui_display_all_data)
4324         (tui_display_data_from_line): Update.
4325         (tui_check_data_values): Remove.
4326         * tui/tui-regs.c (tui_show_register_group)
4327         (tui_display_reg_element_at_line): Update.
4328         * tui/tui-hooks.c (tui_register_changed)
4329         (tui_refresh_frame_and_register_information): Call
4330         tui_check_register_values.
4331         * tui/tui-data.h (struct tui_data_window) <data_content,
4332         data_content_count, data_type>: Remove.
4333         (enum tui_data_type): Remove.
4334
4335         * tui/tui-data.c (tui_data_window::clear_detail)
4336         (~tui_data_window): Update.
4337
4338 2019-06-25  Tom Tromey  <tom@tromey.com>
4339
4340         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4341         declare.
4342         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4343         Rename from tui_first_data_item_displayed.  Update.
4344         (tui_data_window::refresh_all)
4345         (tui_data_window::do_scroll_vertical): Update.
4346         * tui/tui-data.h (struct tui_data_window)
4347         <first_data_item_displayed>: Declare new method.
4348
4349 2019-06-25  Tom Tromey  <tom@tromey.com>
4350
4351         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4352         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4353         contents...
4354         (tui_initialize_static_data): ...here.
4355
4356 2019-06-25  Tom Tromey  <tom@tromey.com>
4357
4358         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4359         (tui_display_registers_from, tui_check_register_values): Update.
4360         (tui_display_register): Remove win_info parameter; update.
4361         (tui_get_register): Change type of parameters.
4362         * tui/tui-data.h (struct tui_data_element): Remove.
4363         (union tui_which_element) <data>: Remove.
4364         <data_window>: Change type.
4365         (struct tui_data_item_window): New.
4366         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4367         case.  Add assert.
4368         (~tui_data_item_window): New destructor.
4369         (free_content_elements): Remove DATA_ITEM_WIN case.
4370
4371 2019-06-25  Tom Tromey  <tom@tromey.com>
4372
4373         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4374         Remove.
4375
4376 2019-06-25  Tom Tromey  <tom@tromey.com>
4377
4378         * tui/tui-data.h (struct tui_command_element): Remove.
4379         (union tui_which_element) <command>: Remove.
4380         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4381         assert.
4382         (free_content_elements): Remove CMD_WIN case.
4383
4384 2019-06-25  Tom Tromey  <tom@tromey.com>
4385
4386         * tui/tui-layout.c (tui_set_layout): Update.
4387         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4388         * tui/tui-data.c (layout_def): Update.
4389
4390 2019-06-25  Tom Tromey  <tom@tromey.com>
4391
4392         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4393         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4394         (tui_source_window_base::set_new_height): Update.
4395         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4396         Update.
4397         (tui_set_locator_fullname, tui_set_locator_info)
4398         (tui_show_frame_info): Update.
4399         * tui/tui-source.c (tui_set_source_content)
4400         (tui_source_is_displayed): Update.
4401         * tui/tui-layout.c (show_source_disasm_command, show_data)
4402         (show_source_or_disasm_and_command): Update.
4403         * tui/tui-disasm.c (tui_set_disassem_content)
4404         (tui_get_begin_asm_address): Update.
4405         * tui/tui-data.h (struct tui_locator_element): Remove.
4406         (union tui_which_element) <locator>: Remove.
4407         (struct tui_locator_window): New.
4408         (tui_locator_win_info_ptr): Change return type.
4409         * tui/tui-data.c (_locator): Change type.
4410         (tui_locator_win_info_ptr): Change return type.
4411         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4412         (tui_alloc_content): Add assert.
4413
4414 2019-06-25  Tom Tromey  <tom@tromey.com>
4415
4416         * tui/tui-winsource.c
4417         (tui_exec_info_window::maybe_allocate_content): New method.
4418         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4419         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4420         (make_source_or_disasm_window): Add cast.
4421         * tui/tui-data.h (union tui_which_element) <simple_string>:
4422         Remove.
4423         (struct tui_source_info): New.
4424         (struct tui_source_window_base) <execution_info>: Change type.
4425         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4426         case, and add assert.
4427         (tui_alloc_content): Add assert.
4428
4429 2019-06-25  Tom Tromey  <tom@tromey.com>
4430
4431         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4432         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4433         * tui/tui-data.c (tui_alloc_win_info): Remove.
4434
4435 2019-06-25  Tom Tromey  <tom@tromey.com>
4436
4437         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4438         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4439         can_highlight.
4440
4441 2019-06-25  Tom Tromey  <tom@tromey.com>
4442
4443         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4444         make_visible_with_new_height method.
4445         (tui_win_info::make_visible_with_new_height): New method.
4446         (tui_source_window_base::do_make_visible_with_new_height)
4447         (tui_data_window::do_make_visible_with_new_height)
4448         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4449         (make_visible_with_new_height): Remove.
4450         (tui_resize_all, tui_adjust_win_heights): Use
4451         make_visible_with_new_height method.
4452         * tui/tui-data.h (struct tui_win_info)
4453         <do_make_visible_with_new_height, make_visible_with_new_height>:
4454         New methods.
4455         (struct tui_source_window_base, struct tui_data_window)
4456         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4457         methods.
4458
4459 2019-06-25  Tom Tromey  <tom@tromey.com>
4460
4461         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4462         method.
4463         (update_tab_width): Call update_tab_width method.
4464         * tui/tui-data.h (struct tui_win_info)
4465         (struct tui_source_window_base) <update_tab_width>: New methods.
4466
4467 2019-06-25  Tom Tromey  <tom@tromey.com>
4468
4469         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4470         parameter.
4471         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4472         parameter.
4473         (tui_gen_win_info::make_visible): Update.
4474         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4475         parameter.
4476         * tui/tui-data.h (enum tui_box): New enum.
4477         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4478
4479 2019-06-25  Tom Tromey  <tom@tromey.com>
4480
4481         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4482         init_and_make_win for EXEC_INFO_WIN.
4483         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4484         longer inline.
4485         (struct tui_win_info) <~tui_win_info>: Inline.
4486         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4487         Don't declare.
4488         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4489         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4490         Remove.
4491         (tui_initialize_static_data): Update.
4492         (~tui_gen_win_info): Handle more cleanup here.
4493         (~tui_source_window_base): Delete "execution_info".
4494         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4495
4496 2019-06-25  Tom Tromey  <tom@tromey.com>
4497
4498         * tui/tui-layout.c (make_command_window): Don't set
4499         can_highlight.
4500         (show_source_disasm_command): Call the reset method.
4501         (show_data): Don't set can_highlight.  Call the reset method.
4502         (tui_gen_win_info::reset): Rename from init_gen_win_info
4503         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4504         (show_source_or_disasm_and_command): Call the reset method.
4505         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4506         (struct tui_cmd_window): Set can_highlight.
4507
4508 2019-06-25  Tom Tromey  <tom@tromey.com>
4509
4510         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4511         from make_visible.
4512         (tui_make_visible, tui_make_invisible): Rewrite.
4513         (tui_win_info::make_visible): Remove.
4514         (tui_source_window_base::make_visible): Update.
4515         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4516         method.  Moved from...
4517         (struct tui_win_info) <make_visible>: ...here.
4518
4519 2019-06-25  Tom Tromey  <tom@tromey.com>
4520
4521         * tui/tui-winsource.c
4522         (tui_source_window_base::do_scroll_horizontal): Remove direction
4523         parameter.
4524         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4525         direction parameter.
4526         * tui/tui-win.c (tui_win_info::forward_scroll)
4527         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4528         (tui_win_info::right_scroll): Update.
4529         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4530         direction parameter.
4531         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4532         direction parameter.
4533         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4534         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4535         Remove direction parameter.
4536         (struct tui_source_window_base, struct tui_source_window)
4537         (struct tui_disasm_window, struct tui_data_window)
4538         (struct tui_cmd_window): Update.
4539
4540 2019-06-25  Tom Tromey  <tom@tromey.com>
4541
4542         * tui/tui-winsource.h (tui_set_exec_info_content)
4543         (tui_show_exec_info_content, tui_erase_exec_info_content)
4544         (tui_clear_exec_info_content, tui_update_exec_info): Change
4545         argument to tui_source_window_base.
4546         * tui/tui-winsource.c (tui_set_exec_info_content)
4547         (tui_show_exec_info_content, tui_erase_exec_info_content)
4548         (tui_clear_exec_info_content, tui_update_exec_info): Change
4549         argument to tui_source_window_base.
4550
4551 2019-06-25  Tom Tromey  <tom@tromey.com>
4552
4553         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4554         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4555
4556 2019-06-25  Tom Tromey  <tom@tromey.com>
4557
4558         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4559         check.
4560
4561 2019-06-25  Tom Tromey  <tom@tromey.com>
4562
4563         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4564         type to void.
4565         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4566         type to void.
4567         * tui/tui-source.c (tui_set_source_content): Update.
4568         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4569
4570 2019-06-25  Tom Tromey  <tom@tromey.com>
4571
4572         * tui/tui-win.c (window_name_completer, tui_set_focus)
4573         (tui_all_windows_info): Use name method.
4574         * tui/tui-data.h (struct tui_gen_win_info)
4575         (struct tui_source_window, struct tui_disasm_window)
4576         (struct tui_data_window, struct tui_cmd_window) <name>: New
4577         method.
4578         (tui_win_name): Don't declare.
4579         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4580         (tui_win_name): Remove.
4581
4582 2019-06-25  Tom Tromey  <tom@tromey.com>
4583
4584         * tui/tui-winsource.h (tui_update_source_window)
4585         (tui_update_source_window_as_is): Change parameter type.
4586         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4587         to be a tui_source_window_base.
4588         (tui_update_source_window_as_is): Likewise.
4589         * tui/tui-win.c (make_visible_with_new_height): Update.
4590
4591 2019-06-25  Tom Tromey  <tom@tromey.com>
4592
4593         * tui/tui-winsource.c (tui_erase_source_content)
4594         (tui_show_source_content, tui_show_exec_info_content)
4595         (tui_erase_exec_info_content): Use refresh_window method.
4596         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4597         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4598         from tui_refresh_win.
4599         (tui_data_window::refresh_window): New method.
4600         (tui_win_info::refresh, tui_source_window_base::refresh)
4601         (tui_refresh_all): Use refresh_window method.
4602         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4603         method.
4604         * tui/tui-regs.c (tui_display_register): Call refresh_window
4605         method.
4606         * tui/tui-layout.c (show_source_disasm_command)
4607         (show_source_or_disasm_and_command): Call refresh_window method.
4608         * tui/tui-data.h (struct tui_gen_win_info)
4609         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4610         New method.
4611
4612 2019-06-25  Tom Tromey  <tom@tromey.com>
4613
4614         * tui/tui.c (tui_rl_other_window, tui_enable)
4615         (tui_is_window_visible, tui_get_command_dimension): Update.
4616         * tui/tui-winsource.c (tui_update_source_window_as_is)
4617         (tui_clear_source_content, tui_erase_source_content)
4618         (tui_show_source_line, tui_source_window_base::refill)
4619         (tui_source_window_base::do_scroll_horizontal)
4620         (tui_source_window_base::set_is_exec_point_at)
4621         (tui_update_breakpoint_info, tui_set_exec_info_content)
4622         (tui_alloc_source_buffer, tui_line_is_displayed)
4623         (tui_addr_is_displayed): Update.
4624         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4625         (tui_check_and_display_highlight_if_needed)
4626         (tui_win_info::make_visible, tui_win_info::refresh)
4627         (tui_refresh_all): Update.
4628         * tui/tui-windata.c (tui_first_data_item_displayed)
4629         (tui_delete_data_content_windows, tui_erase_data_content)
4630         (tui_display_all_data, tui_data_window::refresh_all)
4631         (tui_check_data_values): Update.
4632         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4633         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4634         (tui_win_info::backward_scroll, tui_refresh_all_win)
4635         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4636         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4637         (tui_source_window_base::set_new_height)
4638         (tui_data_window::set_new_height)
4639         (make_invisible_and_set_new_height)
4640         (make_visible_with_new_height, new_height_ok)
4641         (parse_scrolling_args): Update.
4642         * tui/tui-stack.c (tui_show_frame_info): Update.
4643         * tui/tui-source.c (tui_set_source_content)
4644         (tui_set_source_content_nil, tui_source_is_displayed)
4645         (tui_source_window::do_scroll_vertical): Update.
4646         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4647         (tui_display_registers_from, tui_display_reg_element_at_line)
4648         (tui_check_register_values, tui_reg_command): Update.
4649         * tui/tui-layout.c (tui_default_win_height)
4650         (show_source_disasm_command, show_data, init_and_make_win)
4651         (show_source_or_disasm_and_command): Update.
4652         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4653         (tui_redisplay_readline, tui_mld_flush)
4654         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4655         (tui_getc): Update.
4656         * tui/tui-disasm.c (tui_set_disassem_content)
4657         (tui_disasm_window::do_scroll_vertical): Update.
4658         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4659         Now virtual.
4660         (struct tui_win_info): Derive from tui_gen_win_info.
4661         <~tui_win_info>: Mark as override.
4662         <generic>: Remove member.
4663         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4664         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4665         (~tui_data_window, ~tui_win_info)
4666         (tui_free_all_source_wins_content): Update.
4667         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4668
4669 2019-06-25  Tom Tromey  <tom@tromey.com>
4670
4671         * tui/tui-layout.c (init_and_make_win): Use new.
4672         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4673         destructor, initializers.
4674         (tui_alloc_generic_win_info): Don't declare.
4675         * tui/tui-data.c (_locator): Add argument to constructor.
4676         (source_win, disasm_win): New globals.
4677         (exec_info): Remove.
4678         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4679         Update.
4680         (tui_alloc_generic_win_info): Remove.
4681         (init_content_element): Use new.
4682         (tui_win_info::tui_win_info): Update.
4683         (free_content_elements) <case DATA_WIN>: Use delete.
4684
4685 2019-06-25  Tom Tromey  <tom@tromey.com>
4686
4687         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4688         * tui/tui-windata.c (tui_first_data_item_displayed)
4689         (tui_delete_data_content_windows): Update.
4690         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4691         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4692         (tui_display_registers_from, tui_check_register_values): Update.
4693         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4694         pointer.
4695         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4696         window.
4697         (tui_free_data_content): Update.
4698         (free_content_elements) <case DATA_WIN>: Free the window.
4699
4700 2019-06-25  Tom Tromey  <tom@tromey.com>
4701
4702         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4703         Update.
4704         * tui/tui-layout.c (make_command_window)
4705         (show_source_disasm_command, show_data, init_and_make_win)
4706         (show_source_or_disasm_and_command): Update.
4707         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4708         method.
4709         <can_highight, is_highlighted>: Now bool.
4710         (tui_set_win_highlight): Don't declare.
4711         * tui/tui-data.c (tui_set_win_highlight): Remove.
4712
4713 2019-06-25  Tom Tromey  <tom@tromey.com>
4714
4715         * tui/tui-wingeneral.c (make_visible): Remove check of window
4716         type.
4717
4718 2019-06-25  Tom Tromey  <tom@tromey.com>
4719
4720         * tui/tui-win.c (tui_win_info::max_height)
4721         (tui_cmd_window::max_height): New methods.
4722         (new_height_ok): Call max_height.
4723         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4724         <max_height>: New method.
4725
4726 2019-06-25  Tom Tromey  <tom@tromey.com>
4727
4728         * tui/tui-win.c (tui_source_window_base::set_new_height)
4729         (tui_data_window::set_new_height): New methods.
4730         (make_invisible_and_set_new_height): Call set_new_height method.
4731         * tui/tui-data.h (struct tui_win_info)
4732         (struct tui_source_window_base, struct tui_data_window)
4733         <set_new_height>: New method.
4734
4735 2019-06-25  Tom Tromey  <tom@tromey.com>
4736
4737         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4738         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4739         tui_refresh_data_win.
4740         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4741         method.
4742         (tui_refresh_all_win): Call the refresh_all method.
4743         (tui_set_focus): Likewise.
4744         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4745         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4746         Likewise.
4747
4748 2019-06-25  Tom Tromey  <tom@tromey.com>
4749
4750         * tui/tui-winsource.h (tui_refill_source_window)
4751         (tui_set_is_exec_point_at): Don't declare.
4752         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4753         (tui_source_window_base::refill): Rename from
4754         tui_refill_source_window.
4755         (tui_source_window_base::do_scroll_horizontal): Update.
4756         (tui_source_window_base::set_is_exec_point_at): Rename from
4757         tui_set_is_exec_point_at.
4758         (tui_update_all_breakpoint_info): Update.
4759         * tui/tui-stack.c (tui_show_frame_info): Update.
4760         * tui/tui-layout.c (show_data): Add cast.
4761         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4762         * tui/tui-data.h (struct tui_source_window_base) <refill,
4763         set_is_exec_point_at>: New methods.
4764         (tui_source_windows, tui_add_to_source_windows): Update types.
4765         (tui_add_to_source_windows): Remove redundant declaration.
4766         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4767         (tui_source_windows): Change return type.
4768         (tui_clear_source_windows_detail): Update.
4769         (tui_add_to_source_windows): Change type of parameter.
4770         (tui_free_all_source_wins_content): Update.
4771
4772 2019-06-25  Tom Tromey  <tom@tromey.com>
4773
4774         * tui/tui-wingeneral.c (tui_win_info::refresh)
4775         (tui_source_window_base::refresh): New methods.
4776         (tui_refresh_all): Call the refresh method.
4777         * tui/tui-data.h (struct tui_win_info)
4778         (struct tui_source_window_base) <refresh>: New method.
4779
4780 2019-06-25  Tom Tromey  <tom@tromey.com>
4781
4782         * tui/tui.h (tui_is_window_visible): Return bool.
4783         * tui/tui.c (tui_is_window_visible): Return bool.
4784         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4785         (tui_make_visible, tui_make_invisible)
4786         (tui_win_info::make_visible)
4787         (tui_source_window_base::make_visible, make_all_visible)
4788         (tui_make_all_visible, tui_make_all_invisible): Update.
4789         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4790         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4791         bool.
4792         (struct tui_win_info, struct tui_source_window_base)
4793         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4794         * tui/tui-data.c (tui_init_generic_part): Update.
4795
4796 2019-06-25  Tom Tromey  <tom@tromey.com>
4797
4798         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4799         (tui_source_window_base::make_visible): New methods.
4800         (make_all_visible): Make method call.
4801         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4802         (struct tui_source_window_base, struct tui_cmd_window): Override
4803         make_visible.
4804         (tui_win_is_source_type): Don't declare.
4805         * tui/tui-data.c (tui_win_is_source_type): Remove.
4806
4807 2019-06-25  Tom Tromey  <tom@tromey.com>
4808
4809         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4810         NULL check.
4811
4812 2019-06-25  Tom Tromey  <tom@tromey.com>
4813
4814         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4815         Inline constructor.  Add initializers for members.
4816         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4817         constructors; now inline in class.
4818
4819 2019-06-25  Tom Tromey  <tom@tromey.com>
4820
4821         * tui/tui-regs.c (tui_show_registers): Update.
4822         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4823         bool.
4824         * tui/tui-data.c (tui_data_window::clear_detail)
4825         (tui_data_window): Update.
4826
4827 2019-06-25  Tom Tromey  <tom@tromey.com>
4828
4829         * tui/tui-windata.c (tui_display_all_data)
4830         (tui_display_data_from_line, tui_display_data_from)
4831         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4832         Update.
4833         * tui/tui-regs.c (tui_last_regs_line_no)
4834         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4835         (tui_show_registers, tui_show_register_group)
4836         (tui_display_registers_from, tui_display_reg_element_at_line)
4837         (tui_display_registers_from_line, tui_check_register_values)
4838         (tui_reg_next, tui_reg_prev): Update.
4839         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4840         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4841         tui_data_window.
4842         (struct tui_win_info) <detail>: Remove.  Add new fields from
4843         tui_data_info.
4844         (TUI_DATA_WIN): Add cast.
4845         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4846         (~tui_data_window): Simplify.
4847
4848 2019-06-25  Tom Tromey  <tom@tromey.com>
4849
4850         * tui/tui-layout.c (show_source_disasm_command)
4851         (show_source_or_disasm_and_command): Update.
4852         * tui/tui-io.c (update_cmdwin_start_line)
4853         (tui_redisplay_readline): Update.
4854         * tui/tui-data.h (struct tui_command_info): Remove.
4855         (struct tui_win_info) <detail>: Remove command_info member.
4856         (struct tui_data_window) <start_line>: New member, from
4857         tui_command_info.
4858         (TUI_CMD_WIN): Add casts.
4859
4860 2019-06-25  Tom Tromey  <tom@tromey.com>
4861
4862         * tui/tui-winsource.c (tui_update_source_window)
4863         (tui_refill_source_window)
4864         (tui_source_window_base::do_scroll_horizontal)
4865         (tui_update_breakpoint_info, tui_set_exec_info_content)
4866         (tui_show_exec_info_content, tui_erase_exec_info_content)
4867         (tui_clear_exec_info_content): Update.
4868         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4869         Update.
4870         * tui/tui-win.c (make_invisible_and_set_new_height)
4871         (make_visible_with_new_height): Update.
4872         * tui/tui-source.c (tui_set_source_content)
4873         (tui_show_symtab_source): Update.
4874         * tui/tui-layout.c (extract_display_start_addr)
4875         (show_source_disasm_command, show_data)
4876         (make_source_or_disasm_window)
4877         (show_source_or_disasm_and_command): Update.
4878         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4879         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4880         "gdbarch".
4881         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4882         to tui_source_window_base.
4883         (struct tui_win_info) <detail>: Remove source_info member.
4884         (struct tui_source_window_base) <has_locator>: Inline.
4885         Move contents from tui_source_info; rename has_locator member to
4886         m_has_locator.
4887         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4888         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4889         header file.
4890         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4891         Simplify.
4892         (tui_free_all_source_wins_content): Cast to
4893         tui_source_window_base.
4894
4895 2019-06-25  Tom Tromey  <tom@tromey.com>
4896
4897         * tui/tui-win.c (make_invisible_and_set_new_height)
4898         (make_visible_with_new_height): Call has_locator method.
4899         * tui/tui-layout.c (show_source_disasm_command, show_data)
4900         (show_source_or_disasm_and_command): Update for bool change.
4901         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4902         (tui_win_info) <has_locator>: New method.
4903         (struct tui_source_window_base) <has_locator>: New method.
4904         (tui_win_has_locator): Don't declare.
4905         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4906         from tui_win_has_locator.
4907         (tui_source_window_base): Use false, not FALSE.
4908
4909 2019-06-25  Tom Tromey  <tom@tromey.com>
4910
4911         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4912         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4913         clear_detail method directly.
4914         (tui_clear_win_detail): Remove.
4915
4916 2019-06-25  Tom Tromey  <tom@tromey.com>
4917
4918         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4919         "this", not TUI_DISASM_WIN.
4920
4921 2019-06-25  Tom Tromey  <tom@tromey.com>
4922
4923         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4924         declare.
4925         * tui/tui-winsource.c
4926         (tui_source_window_base::do_scroll_horizontal): Rename from
4927         tui_horizontal_source_scroll.
4928         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4929         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4930         from tui_vertical_data_scroll.
4931         * tui/tui-win.h (tui_scroll): Don't declare.
4932         * tui/tui-win.c (tui_win_info::forward_scroll)
4933         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4934         (tui_win_info::right_scroll): Rename and update.
4935         (tui_scroll_forward_command, tui_scroll_backward_command)
4936         (tui_scroll_left_command, tui_scroll_right_command): Update.
4937         (tui_scroll): Remove.
4938         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4939         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4940         from tui_vertical_source_scroll.
4941         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4942         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4943         from tui_vertical_disassem_scroll.
4944         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4945         do_scroll_horizontal>: New methods.
4946         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4947         Likewise.
4948         (struct tui_source_window_base): Add do_scroll_horizontal.
4949         (struct tui_source_window, struct tui_disasm_window): Add
4950         do_scroll_vertical.
4951         (struct tui_data_window, struct tui_cmd_window): Add
4952         do_scroll_horizontal and do_scroll_vertical.
4953         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4954
4955 2019-06-25  Tom Tromey  <tom@tromey.com>
4956
4957         * tui/tui-data.h (struct tui_source_window_base): New struct.
4958         (struct tui_source_window): Derive from tui_source_window_base.
4959         (struct tui_disasm_window): New struct.
4960         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4961         from tui_source_window::clear_detail.
4962         (tui_source_window_base): Rename from tui_source_window.
4963         (~tui_source_window_base): Rename from ~tui_source_window.
4964         (tui_alloc_win_info): Create a tui_disasm_window.
4965
4966 2019-06-25  Tom Tromey  <tom@tromey.com>
4967
4968         * tui/tui-data.h (struct tui_source_window)
4969         (struct tui_data_window): Declare destructors.
4970         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4971         destructors.
4972         (tui_win_info): Simplify.
4973
4974 2019-06-25  Tom Tromey  <tom@tromey.com>
4975
4976         * tui/tui-winsource.c (tui_display_main)
4977         (tui_update_source_windows_with_addr)
4978         (tui_update_all_breakpoint_info): Update.
4979         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4980         (new_height_ok, parse_scrolling_args): Update.
4981         * tui/tui-stack.c (tui_show_frame_info): Update.
4982         * tui/tui-data.h (struct tui_list): Remove.
4983         (tui_source_windows): Return a reference to a std::vector.
4984         * tui/tui-data.c (source_windows): Now a std::vector.
4985         (tui_source_windows): Change return type.
4986         (tui_clear_source_windows): Rewrite.
4987         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4988         (tui_free_all_source_wins_content): Rewrite.
4989
4990 2019-06-25  Tom Tromey  <tom@tromey.com>
4991
4992         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4993         (struct tui_data_window, struct tui_cmd_window): Declare
4994         clear_detail method.
4995         * tui/tui-data.c (tui_source_window::clear_detail)
4996         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4997         methods.
4998         (tui_clear_win_detail): Simplify.
4999
5000 2019-06-25  Tom Tromey  <tom@tromey.com>
5001
5002         * tui/tui-layout.c (make_source_window, make_disasm_window)
5003         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5004         Return the new window.
5005         (show_source_disasm_command, show_data)
5006         (show_source_or_disasm_and_command): Update.
5007
5008 2019-06-25  Tom Tromey  <tom@tromey.com>
5009
5010         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5011         parameter.  Return the new window.
5012         (show_source_disasm_command): Update and remove NULL check.
5013         (show_source_or_disasm_and_command): Update.
5014
5015 2019-06-25  Tom Tromey  <tom@tromey.com>
5016
5017         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5018
5019 2019-06-25  Tom Tromey  <tom@tromey.com>
5020
5021         * tui/tui-data.h (struct tui_win_info): Make constructor
5022         protected.  Make destructor virtual.  Add initializers.
5023         (tui_source_window, tui_data_window, tui_cmd_window): New
5024         classes.
5025         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5026         constructor.  Add "type" parameter.
5027         (tui_source_window, tui_data_window, tui_cmd_window): New
5028         constructors.
5029         (tui_alloc_win_info): Instantiate the appropriate subclass.
5030
5031 2019-06-25  Tom Tromey  <tom@tromey.com>
5032
5033         * tui/tui-win.c (tui_resize_all): Use delete.
5034         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5035         destructor.
5036         (tui_free_window): Don't declare.
5037         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5038         Update.
5039
5040 2019-06-25  Tom Tromey  <tom@tromey.com>
5041
5042         * tui/tui-data.h (struct tui_win_info): Add constructor.
5043         * tui/tui-data.c (tui_alloc_win_info): Use new.
5044         (tui_free_window): Use delete.
5045
5046 2019-06-22  Tom Tromey  <tom@tromey.com>
5047
5048         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5049         declare.
5050         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5051
5052 2019-06-22  Tom Tromey  <tom@tromey.com>
5053
5054         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5055         declare.
5056         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5057
5058 2019-06-22  Tom de Vries  <tdevries@suse.de>
5059
5060         * dwarf2read.c (create_addrmap_from_aranges)
5061         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5062         instead of '%zu'.
5063
5064 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5065
5066         * dwarf2read.h (dwarf2_section_info_def): Remove.
5067         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5068         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5069         std::vector<dwarf2_section_info>.
5070         (struct dwo_file) <~dwo_file>: Remove.
5071         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5072         types field.
5073         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5074         (dwarf2_read_debug_names): Likewise.
5075         (create_debug_types_hash_table): Change parameter type to
5076         array_view, adjust code accordingly.
5077         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5078         (partial_die_info::fixup): Likewise.
5079         (determine_prefix): Likewise.
5080         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5081
5082 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5083
5084         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5085         gdb_bfd_ref_ptr.
5086         <~dwo_file>: Remove call to gdb_bfd_unref.
5087         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5088         gdb_bfd_ref_ptr::get.
5089
5090 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5091
5092         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5093         type to htab_up.
5094         * dwarf2read.c (struct dwo_file): Initialize fields.
5095         <~dwo_file>: New.
5096         (free_dwo_file): Remove, move content to ~dwo_file.
5097         (struct dwo_file_deleter): Remove.
5098         (dwo_file_up>: Remove custom deleter.
5099         (free_dwo_files): Remove.
5100         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5101         dwo_files.
5102         (process_skeletonless_type_units): Call unique_ptr::get.
5103         (allocate_dwo_file_hash_table): Add deleter to created hash
5104         table.  Change return type to htab_up.
5105         (lookup_dwo_file_slot): Don't memset dwo_file, call
5106         unique_ptr::get.
5107         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5108         (create_dwo_unit_in_dwp_v2): Likewise.
5109         (open_and_init_dwo_file): Likewise.
5110         (free_dwo_file_from_slot): Remove.
5111
5112 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5113
5114         * dwarf2read.h (struct dwarf2_section_info) <readin,
5115         is_virtual>: Change type to bool.
5116         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5117         true instead of 1.
5118
5119 2019-06-19  Tom Tromey  <tom@tromey.com>
5120
5121         * tui/tui-data.h (tui_init_content_element): Don't declare.
5122
5123 2019-06-19  Tom Tromey  <tom@tromey.com>
5124
5125         * tui/tui-data.h (tui_init_win_info): Don't declare.
5126
5127 2019-06-19  Tom de Vries  <tdevries@suse.de>
5128
5129         * dwarf2read.h (abstract_to_concrete): Change type to
5130         std::unordered_map<sect_offset, std::vector<sect_offset>,
5131         gdb::hash_enum<sect_offset>>.
5132
5133 2019-06-19  Tom Tromey  <tromey@adacore.com>
5134
5135         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5136         EVAL_AVOID_SIDE_EFFECTS specially.
5137
5138 2019-06-19  Tom Tromey  <tromey@adacore.com>
5139
5140         * source-cache.c (highlighter): New global.
5141         (source_cache::get_source_lines): Create a highlighter on demand.
5142
5143 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5144
5145         * defs.h (deprecated_interactive_hook): Delete declaration.
5146         * interps.c (clear_interpreter_hooks): Remove use of
5147         deprecated_interactive_hook.
5148         * top.c (deprecated_interactive_hook): Delete definition.
5149         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5150
5151 2019-06-18  Tom de Vries  <tdevries@suse.de>
5152
5153         PR gdb/24515
5154         * dwarf2read.h (abstract_to_concrete): Change type from
5155         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5156         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5157         * dwarf2read.c (read_variable): Update.
5158         (dwarf2_fetch_die_loc_sect_off): Update.
5159
5160 2019-06-17  Tom de Vries  <tdevries@suse.de>
5161
5162         PR gdb/24617
5163         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5164         accessing parent[parent_len - 1].
5165
5166 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5167
5168         PR gdb/24364
5169         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5170         call dtrace_process_dof with NULL dof.
5171
5172 2019-06-16  Tom de Vries  <tdevries@suse.de>
5173
5174         PR gdb/24445
5175         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5176
5177 2019-06-16  Tom Tromey  <tom@tromey.com>
5178
5179         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5180         (make_all_visible): Use address of member.
5181
5182 2019-06-16  Tom Tromey  <tom@tromey.com>
5183
5184         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5185         (tui_free_window, free_content, free_content_elements): Remove
5186         unnecessary cast.
5187         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5188         cast.
5189         * tui/tui-regs.c (tui_show_register_group)
5190         (tui_display_registers_from, tui_display_reg_element_at_line):
5191         Remove unnecessary cast.
5192
5193 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5194
5195         * linux-nat.c (normal_mask): Delete.
5196         (_initialize_linux_nat): Don't initialise normal_mask.
5197
5198 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5199
5200         PR gdb/24445
5201         * dwarf-index-write.h (write_psymtabs_to_index): Add
5202         dwz_basename parameter.
5203         * dwarf-index-write.c (write_gdbindex): Move file writing to
5204         write_gdbindex_1.  Change return type void.
5205         (assert_file_size): Move up, remove filename parameter.
5206         (write_gdbindex_1): New function.
5207         (write_debug_names): Change return type to void, call
5208         assert_file_size.
5209         (struct index_wip_file): New struct.
5210         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5211         file logic to index_wip_file.  Write index for dwz file if
5212         needed.
5213         (save_gdb_index_command): Pass basename of dwz file, if present.
5214         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5215         build-id of dwz file, if present.
5216         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5217         (dwarf2_get_dwz_file): Likewise.
5218         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5219         (dwarf2_get_dwz_file): Likewise.
5220
5221 2019-06-16  Tom Tromey  <tom@tromey.com>
5222
5223         * coffread.c (process_coff_symbol): Use xstrdup.
5224         * value.c (create_internalvar): Use xstrdup.
5225
5226 2019-06-16  Tom Tromey  <tom@tromey.com>
5227
5228         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5229         * breakpoint.c (stopin_command, stopat_command)
5230         (until_break_command, decode_location_default): Remove unnecessary
5231         cast.
5232         * utils.c (subset_compare): Remove unnecessary cast.
5233         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5234         cast.
5235         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5236         cast.
5237         * infcmd.c (path_command): Remove unnecessary cast.
5238         * coffread.c (decode_type): Remove unnecessary cast.
5239         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5240         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5241         * tui/tui-stack.c (tui_show_locator_content)
5242         (tui_show_frame_info): Remove unnecessary cast.
5243         * tui/tui-win.c (tui_scroll_forward_command)
5244         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5245         (parse_scrolling_args): Remove unnecessary cast.
5246         * tui/tui-data.c (init_win_info, tui_del_window)
5247         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5248         (free_content_elements): Remove unnecessary cast.
5249         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5250         unnecessary cast.
5251         * tui/tui-source.c (tui_set_source_content)
5252         (tui_vertical_source_scroll): Remove unnecessary cast.
5253         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5254         cast.
5255         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5256         * tui/tui-regs.c (tui_display_registers_from)
5257         (tui_display_register): Remove unnecessary cast.
5258         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5259         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5260         (make_visible): Remove unnecessary cast.
5261         * tui/tui-winsource.c (tui_erase_source_content)
5262         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5263         unnecessary cast.
5264         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5265         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5266         * stabsread.c (read_type, read_array_type, read_range_type):
5267         Remove unnecessary cast.
5268         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5269         (parse_symbol, parse_type, upgrade_type, parse_external)
5270         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5271         unnecessary cast.
5272         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5273
5274 2019-06-16  Tom Tromey  <tom@tromey.com>
5275
5276         * tui/tui-data.c (tui_alloc_generic_win_info)
5277         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5278         checks.
5279
5280 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5281             Andrew Burgess  <andrew.burgess@embecosm.com>
5282
5283         * f-typeprint.c (f_print_type): Don't return early for not
5284         associated or not allocated types.
5285         (f_type_print_varspec_suffix): Add print_rank parameter and print
5286         ranks of array types in case they dangling.
5287         (f_type_print_base): Add print_rank parameter.
5288
5289 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5290
5291         * NEWS: Mention new MI commands.
5292         * break-catch-throw.c (enum exception_event_kind): Move to
5293         breakpoint.h.
5294         (print_mention_exception_catchpoint): Output text as a single
5295         message.
5296         (catch_exception_command_1): Rename to...
5297         (catch_exception_event): ...this, make non-static, update header
5298         command, and change some parameter types.
5299         (catch_catch_command): Update for changes to
5300         catch_exception_command_1.
5301         (catch_throw_command): Likewise.
5302         (catch_rethrow_command): Likewise.
5303         * breakpoint.c (enum exception_event_kind): Delete.
5304         * breakpoint.h (enum exception_event_kind): Moved here from
5305         break-catch-throw.c.
5306         (catch_exception_event): Declare.
5307         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5308         (mi_cmd_catch_throw): New function.
5309         (mi_cmd_catch_rethrow): New function.
5310         (mi_cmd_catch_catch): New function.
5311         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5312         'catch-catch' entries.
5313         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5314         (mi_cmd_catch_rethrow): Declare.
5315         (mi_cmd_catch_catch): Declare.
5316
5317 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5318
5319         * annotate.c (annotate_source_line): Change return type to void,
5320         update implementation to match.
5321         * annotate.h (annotate_source_line): Change return type to void,
5322         update header comment.
5323         * stack.c (print_frame_info): Don't change what frame information
5324         is printed based on whether annotations are on or not.
5325
5326 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5327
5328         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5329         (annotate_source): Make static.
5330         (annotate_source_line): Moved from source.c and renamed from
5331         identify_source_line.  Update the return type.
5332         * annotate.h (annotate_source): Delete declaration.
5333         (annotate_source_line): Declaration moved from source.h, and
5334         renamed from identify_source_line.  Return type updated.
5335         * source.c (identify_source_line): Moved to annotate.c and renamed
5336         to annotate_source_line.
5337         (info_line_command): Remove check of annotation_level.
5338         * source.h (identify_source_line): Move declaration to annotate.h
5339         and rename to annotate_source_line.
5340         * stack.c: Add 'annotate.h' include.
5341         (print_frame_info): Remove check of annotation_level before
5342         calling annotate_source_line.
5343
5344 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5345
5346         * source-cache.c (source_cache::get_plain_source_lines): Use
5347         open_source_file_with_line_charpos instead of just
5348         open_source_file, remove call to find_source_lines.
5349         (source_cache::get_source_lines): Likewise.
5350         * source.c (find_source_lines): Make static.
5351         (get_filename_and_charpos): Renamed into...
5352         (open_source_file_with_line_charpos): ..this along with changes to
5353         return a scoped_fd, and some other minor clean ups.
5354         (identify_source_line): Use open_source_file_with_line_charpos.
5355         (search_command_helper): Use open_source_file_with_line_charpos
5356         instead of just open_source_file, remove call to
5357         find_source_lines.
5358         * source.h (open_source_file_with_line_charpos): Declare new
5359         function.
5360         (find_source_lines): Delete declaration.
5361
5362 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5363
5364         * source.c (get_filename_and_charpos): Remove fullname
5365         parameter.
5366         (identify_source_line): Update call to get_filename_and_charpos.
5367
5368 2019-06-14  Tom Tromey  <tromey@adacore.com>
5369
5370         PR gdb/24502:
5371         * ui-style.h (skip_ansi_escape): Update comment.
5372         * ui-file.h (class no_terminal_escape_file): New class.
5373         * ui-file.c (no_terminal_escape_file::write)
5374         (no_terminal_escape_file::puts): New methods.
5375         * cli/cli-logging.c (handle_redirections): Use
5376         no_terminal_escape_file.
5377
5378 2019-06-14  Tom Tromey  <tromey@adacore.com>
5379
5380         * NEWS: Move convenience variable news above Python news.
5381
5382 2019-06-14  Tom Tromey  <tom@tromey.com>
5383
5384         * gnulib: Move directory to top-level.
5385         * configure.ac: Don't configure gnulib.
5386         * configure: Rebuild.
5387         * common/common-defs.h: Use new path to gnulib.
5388         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5389         (GNULIB_H): Remove.
5390         (INCGNU): Look in new gnulib location.
5391         (HFILES_NO_SRCDIR): Remove gnulib files.
5392         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5393         (generated_files): Remove GNULIB_H.
5394         ($(LIBGNU), all-lib): Remove targets.
5395         (distclean): Don't mention GNULIB_BUILDDIR.
5396         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5397
5398 2019-06-14  Tom Tromey  <tromey@adacore.com>
5399
5400         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5401         Warn if symbol file does not provide any symbols.
5402
5403 2019-06-14  Tom Tromey  <tromey@adacore.com>
5404
5405         * source.c (find_and_open_source): Respect basenames_may_differ.
5406
5407 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5408
5409         * annotate.c (annotate_breakpoints_invalid): Make use of
5410         scoped_restore_terminal_state.
5411         (annotate_frames_invalid): Likewise.
5412
5413 2019-06-14  Tom Tromey  <tromey@adacore.com>
5414
5415         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5416         allow assignment to an internalvar.
5417
5418 2019-06-14  Tom Tromey  <tromey@adacore.com>
5419
5420         * ada-lex.l: Allow "_" in attribute names.
5421
5422 2019-06-14  Tom Tromey  <tromey@adacore.com>
5423
5424         PR gdb/24653:
5425         * regcache.c (registers_changed): Don't call alloca.
5426         * top.c (execute_command): Don't call alloca.
5427
5428 2019-06-13  Pedro Alves  <palves@redhat.com>
5429
5430         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5431         'expression'.  When parsing an expression, error out if there's
5432         junk after "unlimited".
5433         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5434         (do_set_command): Adjust calls to is_unlimited_literal.
5435
5436 2019-06-13  Pedro Alves  <palves@redhat.com>
5437
5438         * compile/compile.c (make_compile_options_def_group): Add braces
5439         around array_view initializer.
5440         * thread.c (make_thread_apply_all_options_def_group)
5441         (make_thread_apply_all_options_def_group): Likewise.
5442
5443 2019-06-13  Pedro Alves  <palves@redhat.com>
5444
5445         * NEWS (New commands): Mention "maint test-options
5446         require-delimiter", "maint test-options unknown-is-error", "maint
5447         test-options unknown-is-operand" and "maint show
5448         test-options-completion-result".
5449         (New command options, command completion): New section.
5450         (Completion improvements): New section.
5451         Mention that you can abbreviate "unlimited".
5452
5453 2019-06-13  Pedro Alves  <palves@redhat.com>
5454
5455         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5456         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5457         * unittests/cli-utils-selftests.c (test_parse_flags)
5458         (test_parse_flags_qcs): Delete.
5459         (test_cli_utils): Don't call deleted functions.
5460
5461 2019-06-13  Pedro Alves  <palves@redhat.com>
5462
5463         * thread.c: Include "cli/cli-option.h".
5464         (tp_array_compar_ascending): Global.
5465         (tp_array_compar): Delete function.
5466         (tp_array_compar_ascending, tp_array_compar_descending): New
5467         functions.
5468         (ascending_option_def, qcs_flag_option_def)
5469         (thr_qcs_flags_option_defs)
5470         (make_thread_apply_all_options_def_group)
5471         (make_thread_apply_options_def_group): New.
5472         (thread_apply_all_command): Use gdb::option::process_options.
5473         (thread_apply_command_completer)
5474         (thread_apply_all_command_completer): New.
5475         (thread_apply_command): Use gdb::option::process_options.
5476         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5477         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5478         to generate help text of "thread apply".  Adjust "taas"'s help.
5479         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5480         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5481
5482 2019-06-13  Pedro Alves  <palves@redhat.com>
5483
5484         * thread.c (thread_apply_command): Check for invalid TID with
5485         isdigit instead of !isalpha.
5486
5487 2019-06-13  Pedro Alves  <palves@redhat.com>
5488
5489         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5490         (validate_flags_qcs): New.
5491         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5492         (validate_flags_qcs): Declare.
5493         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5494         (make_frame_apply_options_def_group): New.
5495         (frame_apply_command_count): Process options with
5496         gdb::option::process_options.
5497         (frame_apply_completer): New.
5498         (frame_apply_level_completer, frame_apply_all_completer)
5499         (frame_apply_completer): New.
5500         (_initialize_stack): Update help of "frame apply", "frame apply
5501         level", "frame apply all" and "faas" to mention supported options
5502         and install command completers.
5503         * stack.h (frame_apply_all_completer): Declare.
5504         * thread.c: Include "stack.h".
5505         (tfaas_command): Add "--".
5506         (_initialize_thread): Update help "tfaas" to mention supported
5507         options and install command completer.
5508
5509 2019-06-13  Pedro Alves  <palves@redhat.com>
5510
5511         * completer.c (complete_nested_command_line): New.
5512         (gdb_completion_word_break_characters_throw): Add assertion.
5513         * completer.h (complete_nested_command_line): Declare.
5514
5515 2019-06-13  Pedro Alves  <palves@redhat.com>
5516
5517         * stack.c (parse_backtrace_qualifiers): New.
5518         (backtrace_command): Use it.
5519         (backtrace_command_completer): Complete on qualifiers.
5520
5521 2019-06-13  Pedro Alves  <palves@redhat.com>
5522
5523         * frame.c: Include "cli/cli-option.h.
5524         (user_set_backtrace_options): New.
5525         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5526         Delete.
5527         (get_prev_frame): Adjust.
5528         (boolean_option_def, uinteger_option_def)
5529         (set_backtrace_option_defs): New.
5530         (_initialize_frame): Adjust and use
5531         gdb::option::add_setshow_cmds_for_options to install "set
5532         backtrace past-main" and "set backtrace past-entry".
5533         * frame.h: Include "cli/cli-option.h".
5534         (struct frame_print_options): Forward declare.
5535         (print_frame_arguments_all, print_frame_arguments_scalars)
5536         (print_frame_arguments_none): Declare.
5537         (print_entry_values): Delete declaration.
5538         (struct frame_print_options, user_frame_print_options): New.
5539         (struct set_backtrace_options): New.
5540         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5541         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5542         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5543         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5544         (list_args_or_locals): Add frame_print_options parameter.
5545         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5546         * python/py-framefilter.c (enumerate_args): Pass down
5547         USER_FRAME_PRINT_OPTIONS.
5548         * stack.c: Include "cli/cli-option.h".
5549         (print_frame_arguments_all, print_frame_arguments_scalars)
5550         (print_frame_arguments_none): Declare.
5551         (print_raw_frame_arguments, print_entry_values): Delete.
5552         (user_frame_print_options): New.
5553         (boolean_option_def, enum_option_def, frame_print_option_defs):
5554         New.
5555         (struct backtrace_cmd_options): New.
5556         (bt_flag_option_def): New.
5557         (backtrace_command_option_defs): New.
5558         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5559         (print_frame_arg, read_frame_arg, print_frame_args)
5560         (print_frame_info, print_frame): Add frame_print_options parameter
5561         and use it.
5562         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5563         (backtrace_command_1): Add frame_print_options and
5564         backtrace_cmd_options parameters and use them.
5565         (make_backtrace_options_def_group): New.
5566         (backtrace_command): Process command options with
5567         gdb::option::process_options.
5568         (backtrace_command_completer): New.
5569         (_initialize_stack): Extend "backtrace"'s help to mention
5570         supported options.  Install completer for "backtrace".
5571         Install some settings commands with add_setshow_cmds_for_options.
5572
5573 2019-06-13  Pedro Alves  <palves@redhat.com>
5574
5575         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5576         and that "set/show print raw frame-arguments" are now deprecated.
5577
5578         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5579         command.
5580         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5581         * stack.c (_initialize_stack): Install "set/show print
5582         raw-frame-arguments", and deprecate "set/show print raw
5583         frame-arguments".
5584         * valprint.c (_initialize_valprint): Deprecate "set/show print
5585         raw".
5586
5587 2019-06-13  Pedro Alves  <palves@redhat.com>
5588
5589         * compile/compile.c (struct compile_options): New.
5590         (compile_flag_option_def, compile_command_option_defs)
5591         (make_compile_options_def_group): New.
5592         (compile_file_command): Handle options with
5593         gdb::option::process_options.
5594         (compile_file_command_completer): New function.
5595         (compile_code_command): Handle options with
5596         gdb::option::process_options.
5597         (compile_code_command_completer): New function.
5598         (_initialize_compiler): Install completers for "compile code" and
5599         "compile file".  Mention available options in "compile code" and
5600         "compile code"'s help.
5601         * completer.c (advance_to_completion_word): New, factored out from
5602         ...
5603         (advance_to_expression_complete_word_point): ... this.
5604         (advance_to_filename_complete_word_point): New.
5605         * completer.h (advance_to_filename_complete_word_point): New
5606         declaration.
5607
5608 2019-06-13  Pedro Alves  <palves@redhat.com>
5609
5610         * compile/compile.c: Include "cli/cli-option.h".
5611         (compile_print_value): Scope data pointer is now a
5612         value_print_options pointer; adjust.
5613         (compile_print_command): Process options.  Scope data pointer is
5614         now a value_print_options pointer; adjust.
5615         (_initialize_compile): Update "compile print"'s help to include
5616         supported options.  Install a completer for "compile print".
5617         * cp-valprint.c (show_vtblprint, show_objectprint)
5618         (show_static_field_print): Delete.
5619         (_initialize_cp_valprint): Don't install "set print
5620         static-members", "set print vtbl", "set print object" here.
5621         * printcmd.c: Include "cli/cli-option.h" and
5622         "common/gdb_optional.h".
5623         (print_command_parse_format): Rework to fill in a
5624         value_print_options instead of a format_data.
5625         (print_value): Change parameter type from format_data pointer to
5626         value_print_options reference.  Adjust.
5627         (print_command_1): Process options.  Adjust to pass down a
5628         value_print_options.
5629         (print_command_completer): New.
5630         (_initialize_printcmd): Install print_command_completer as
5631         handle_brkchars completer for the "print" command.  Update
5632         "print"'s help to include supported options.
5633         * valprint.c: Include "cli/cli-option.h".
5634         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5635         here from cp-valprint.c.
5636         (boolean_option_def, uinteger_option_def)
5637         (value_print_option_defs, make_value_print_options_def_group):
5638         New.  Use gdb::option::add_setshow_cmds_for_options to install
5639         "set print elements", "set print null-stop", "set print repeats",
5640         "set print pretty", "set print union", "set print array", "set
5641         print address", "set print symbol", "set print array-indexes".
5642         * valprint.h: Include <string> and "cli/cli-option.h".
5643         (make_value_print_options_def_group): Declare.
5644         (print_value): Change parameter type from format_data pointer to
5645         value_print_options reference.
5646         (print_command_completer): Declare.
5647
5648 2019-06-13  Pedro Alves  <palves@redhat.com>
5649
5650         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5651         (COMMON_SFILES): Add maint-test-settings.c.
5652         * cli/cli-decode.c (boolean_enums): New global, factored out from
5653         ...
5654         (add_setshow_boolean_cmd): ... here.
5655         * cli/cli-decode.h (boolean_enums): Declare.
5656         * cli/cli-option.c: New file.
5657         * cli/cli-option.h: New file.
5658         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5659         factored out from ...
5660         (parse_cli_boolean_value(const char *)): ... this.
5661         (is_unlimited_literal): Change parameter type to pointer to
5662         pointer.  Adjust and advance ARG pointer.
5663         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5664         (parse_cli_var_enum): New, factored out from ...
5665         (do_set_command): ... this.  Adjust.
5666         * cli/cli-setshow.h (parse_cli_boolean_value)
5667         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5668         (parse_cli_var_enum): Declare.
5669         * cli/cli-utils.c: Include "cli/cli-option.h".
5670         (get_ulongest): New.
5671         * cli/cli-utils.h (get_ulongest): Declare.
5672         (check_for_argument): New overloads.
5673         * maint-test-options.c: New file.
5674
5675 2019-06-13  Pedro Alves  <palves@redhat.com>
5676
5677         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5678         parse a range if "-" is at the end of the string.
5679
5680 2019-06-13  Pedro Alves  <palves@redhat.com>
5681
5682         * cli/cli-setshow.c (parse_auto_binary_operation)
5683         (parse_cli_boolean_value): Don't allow "o".
5684
5685 2019-06-13  Pedro Alves  <palves@redhat.com>
5686
5687         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5688         * NEWS: Mention maint test-settings KIND.
5689         * maint-test-settings.c: New file.
5690
5691 2019-06-13  Pedro Alves  <palves@redhat.com>
5692
5693         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5694         completer.
5695         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5696         "set" completers.
5697
5698 2019-06-13  Pedro Alves  <palves@redhat.com>
5699
5700         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5701         after item.
5702
5703 2019-06-13  Pedro Alves  <palves@redhat.com>
5704
5705         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5706
5707 2019-06-13  Pedro Alves <palves@redhat.com>
5708
5709         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5710         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5711         call.
5712         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5713         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5714         calls.
5715         (check_for_argument): Skip spaces after argument.
5716
5717 2019-06-13  Pedro Alves  <palves@redhat.com>
5718
5719         * thread.c (thread_apply_command): Adjust TID parsing.
5720         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5721         detected before end of string.
5722         (tid_is_in_list): Error out if LIST is invalid.
5723
5724 2019-06-13  Pedro Alves  <palves@redhat.com>
5725
5726         * completer.c (complete_line_internal_1): Rewind completion word
5727         point.
5728         (completion_tracker::advance_custom_word_point_by): Change
5729         parameter type to int.
5730         * completer.h (completion_tracker::advance_custom_word_point_by):
5731         Likewise.
5732
5733 2019-06-13  Pedro Alves  <palves@redhat.com>
5734
5735         * completer.c (advance_to_completion_word): Handle delimiters.
5736
5737 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5738
5739         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5740
5741 2019-06-11  Tom Tromey  <tom@tromey.com>
5742
5743         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5744         (xmalloc_failed): Move to alloc.c.
5745         * alloc.c: New file.
5746         * Makefile.in (COMMON_SFILES): Add alloc.c.
5747
5748 2019-06-11  Tom Tromey  <tom@tromey.com>
5749
5750         * nat/linux-waitpid.c: Don't include server.h.
5751         (linux_debug): Remove.
5752         (my_waitpid): Update.
5753
5754 2019-06-11  Tom Tromey  <tromey@adacore.com>
5755
5756         * infcall.c (_initialize_infcall): Remove trailing newline from
5757         help.
5758         * user-regs.c (_initialize_user_regs): Remove trailing newline
5759         from help.
5760         * typeprint.c (_initialize_typeprint): Remove trailing newline
5761         from help.
5762         * reverse.c (_initialize_reverse): Remove trailing newlines from
5763         help.
5764         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5765         from help.
5766         * language.c (add_set_language_command): Remove trailing newline
5767         from help.
5768         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5769         help.
5770         * disasm.c (_initialize_disasm): Remove trailing newline from
5771         help.
5772         * top.c (init_main): Remove trailing newline from help.
5773         * interps.c (_initialize_interpreter): Remove trailing newline
5774         from help.
5775         * btrace.c (_initialize_btrace): Remove trailing newlines from
5776         help.
5777         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5778         from help.
5779         * python/python.c (_initialize_python): Remove trailing newline
5780         from help.
5781         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5782         help.
5783         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5784         from help.  Reformat some text.
5785         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5786         from help.
5787         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5788         newline from help.
5789
5790 2019-06-11  Tom Tromey  <tromey@adacore.com>
5791
5792         * darwin-nat.c (darwin_decode_exception_message)
5793         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5794
5795 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5796
5797         * valops.c (value_slice): Check for not allocated or not
5798         associated values.
5799
5800 2019-06-10  Tom de Vries  <tdevries@suse.de>
5801
5802         PR gdb/24618
5803         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5804         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5805         invalid.
5806
5807 2019-06-10  Tom de Vries  <tdevries@suse.de>
5808
5809         PR gdb/24611
5810         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5811         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5812
5813 2019-06-10  Tom de Vries  <tdevries@suse.de>
5814
5815         PR symtab/24545
5816         * symtab.c (struct demangled_name_entry): Add language field.
5817         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5818         static minimal symbol".  Set and use language field.
5819
5820 2019-06-10  Tom Tromey  <tromey@adacore.com>
5821
5822         * ada-lang.c (_initialize_ada_language): Update help text.
5823
5824 2019-06-10  Tom Tromey  <tromey@adacore.com>
5825
5826         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5827         with a newline.
5828         * guile/guile.c (handle_boot_error): Don't end warning with a
5829         newline.
5830         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5831         warning with a newline.
5832         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5833         newline.
5834         (s12z_frame_cache): Likewise.
5835         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5836         a newline.
5837         * solib-svr4.c (disable_probes_interface): Don't end warning with
5838         a newline.
5839         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5840         newline.
5841         * python/python.c (do_finish_initialization): Don't end warning
5842         with a newline.
5843
5844 2019-06-10  Tom Tromey  <tom@tromey.com>
5845
5846         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5847         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5848         gdbpy_enter.
5849
5850 2019-06-10  Tom Tromey  <tromey@adacore.com>
5851
5852         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5853         data.
5854         (elf_new_init): Don't call stabsread_new_init.
5855         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5856         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5857         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5858
5859 2019-06-10  Tom de Vries  <tdevries@suse.de>
5860
5861         PR symtab/16264
5862         PR symtab/24517
5863         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5864
5865 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5866
5867         * source.c (find_and_open_source): Also rewrite relative file
5868         names.
5869
5870 2019-04-26  Amos Bird  <amosbird@gmail.com>
5871
5872         * annotate.c (annotate_thread_exited): Add "thread-exited"
5873         annotation.
5874
5875 2019-06-06  Tom Tromey  <tromey@adacore.com>
5876
5877         * maint.h (class scoped_command_stats): Use
5878         DISABLE_COPY_AND_ASSIGN.
5879         <print_time>: New method.
5880         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5881         print_time.
5882         (scoped_command_stats::print_time): New method.
5883
5884 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5885
5886         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5887         instructions of lengths 6 or 8 bytes.
5888
5889 2019-06-04  Pedro Alves  <palves@redhat.com>
5890
5891         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5892
5893         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5894         * breakpoint.c (condition_completer): Likewise.
5895         * cli/cli-dump.c (scan_expression): Likewise.
5896         * common/filestuff.c (mkdir_recursive): Likewise.
5897         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5898         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5899         (gdb_abspath): Likewise.
5900         * compile/compile-cplus-types.c
5901         (compile_cplus_instance::decl_name): Likewise.
5902         * completer.c (complete_explicit_location):
5903         (signal_completer, reg_or_group_completer_1): Likewise.
5904         * cp-support.c (cp_remove_params_if_any): Likewise.
5905         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5906         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5907         * infcmd.c (strip_bg_char): Likewise.
5908         * linespec.c (copy_token_string): Likewise.
5909         * mi/mi-main.c (output_cores): Likewise.
5910         * psymtab.c (psymtab_search_name):
5911         * symfile.c (test_set_ext_lang_command): Likewise.
5912         * target.c (target_fileio_read_stralloc): Likewise.
5913         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5914         * value.c (complete_internalvar): Likewise.
5915
5916 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5917
5918         Add objfile property to gdb.Type.
5919         * NEWS: Mention Python API addition.
5920         * python/py-type.c (typy_get_objfile): New method.
5921
5922 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5923
5924         * NEWS: Mention the new set|show style [title|highlight].
5925         Mention changes to "show style", "help" and "apropos".
5926
5927 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5928
5929         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5930         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5931         instead of print_help_for_command.
5932         (print_doc_of_command): New function.
5933         (help_list): Add 'apropos -v word' suggestion.
5934         (print_help_for_command): Style the command name using title style.
5935         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5936         (_initialize_cli_cmds): Describe -v in apropos_command help.
5937
5938 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5939
5940         * cli/cli-style.h (cli_style_option): Add name in constructor,
5941         add m_name class member, add constructor with intensity,
5942         add name class function.
5943         (cli_style_option::add_setshow_commands): Remove name argument.
5944         (highlight_style, title_style): New styles.
5945         * cli/cli-style.c (do_show): New function that shows a style
5946         characteristic styling the style name with itself.
5947         (set_style_name): New function.
5948         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5949         Update all callers according to the changes in cli/cli-style.h.
5950         * utils.h (fputs_highlighted): New function.
5951         * utils.c (fputs_highlighted): Likewise.
5952
5953 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5954
5955         * NEWS: Mention new pipe command and new convenience variables.
5956
5957 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5958
5959         * cli/cli-cmds.c (pipe_command): New function.
5960         (_initialize_cli_cmds): Call add_com for pipe_command.
5961         Define | as an alias for pipe.
5962         (exit_status_set_internal_vars): New function.
5963         (shell_escape): Call exit_status_set_internal_vars.
5964         cli/cli-decode.c (find_command_name_length): Recognize | as
5965         a single character command.
5966
5967 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5968
5969         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5970         top.c (execute_command_to_ui_file): New function, mostly a copy
5971         of execute_command_to_string.
5972         (execute_command_to_string): Implement by calling
5973         execute_command_to_ui_file.
5974
5975 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5976
5977         * top.h (saved_command_line): Remove declaration.
5978         * top.c (previous_saved_command_line, previous_repeat_arguments):
5979         New variables.
5980         (saved_command_line): Make static, define together with other
5981         'repeat variables'.
5982         (dont_repeat): Clear repeat_arguments.
5983         (repeat_previous, get_saved_command_line, save_command_line):
5984         New functions.
5985         (gdb_init): Initialize saved_command_line
5986         and previous_saved_command_line.
5987         * main.c (captured_main_1): Remove saved_command_line initialization.
5988         * event-top.c (handle_line_of_input): Update to use
5989         the new 'repeat' related functions instead of direct access to
5990         saved_command_line.
5991         * command.h (repeat_previous, get_saved_command_line,
5992         save_command_line): New declarations.
5993         (dont_repeat): Add comment.
5994
5995 2019-05-30  Tom Tromey  <tromey@adacore.com>
5996
5997         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5998         Fix comment.
5999         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6000
6001 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6002
6003         PR cli/24587
6004         * completer.c (complete): Initialize variable word.
6005
6006 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6007
6008         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6009         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6010         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6011         'body' is NULL to the outter 'if', protecting the '!is_define'
6012         situation as well.
6013
6014 2019-05-29  Tom Tromey  <tromey@adacore.com>
6015
6016         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6017         (dwarf_unknown): New function.
6018         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6019         (dwarf_type_encoding_name): Use dwarf_unknown.
6020
6021 2019-05-29  Tom Tromey  <tromey@adacore.com>
6022
6023         PR c++/20020:
6024         * cp-valprint.c (cp_print_value_fields): Call
6025         cp_print_static_field inside "try".
6026
6027 2019-05-29  Tom Tromey  <tromey@adacore.com>
6028
6029         * inflow.c (struct terminal_info): Add default operator=.
6030         * configure: Rebuild.
6031         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6032         -Wdeprecated-copy-dtor, -Wredundant-move.
6033
6034 2019-05-29  Tom Tromey  <tromey@adacore.com>
6035
6036         * NEWS: Add entry.
6037         * infcmd.c (print_return_value_1): Handle finish_print
6038         option.
6039         (show_print_finish): New function.
6040         (_initialize_infcmd): Add "set/show print finish" commands.
6041         * valprint.c (user_print_options): Initialize new member.
6042         * valprint.h (struct value_print_options) <finish_print>: New
6043         member.
6044
6045 2019-05-28  Tom Tromey  <tromey@adacore.com>
6046
6047         * ada-lang.c (ada_remove_Xbn_suffix)
6048         (find_old_style_renaming_symbol)
6049         (parse_old_style_renaming): Remove.
6050         (ada_find_renaming_symbol): Don't call
6051         find_old_style_renaming_symbol.
6052         (ada_is_renaming_symbol): Rename from
6053         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6054         bool.  Now static.
6055         (ada_read_var_value): Update and simplify.
6056         * ada-exp.y (write_var_or_type): Remove old code.
6057
6058 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6059
6060         * event-top.c: Remove include comment.
6061         * inflow.c (class scoped_ignore_sigttou): Move from here...
6062         * inflow.h (class scoped_ignore_sigttou): ...to here.
6063         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6064         * top.c:  Remove include comment.
6065
6066 2019-05-27  Tom Tromey  <tom@tromey.com>
6067
6068         * NEWS: Fix typo.
6069
6070 2019-05-22  Tom Tromey  <tromey@adacore.com>
6071
6072         * target.c (target_follow_exec): Constify parameter.
6073         * target-delegates.c: Rebuild.
6074         * remote.c (remote_target::follow_exec): Constify parameter.
6075         * infrun.c (follow_exec): Constify parameter.
6076         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6077         (target_follow_exec): Likewise.
6078
6079 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6080
6081         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6082         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6083
6084 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6085
6086         * NEWS: Add debugredirect and testsuite sections.
6087
6088 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6089
6090         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6091         target descriptions using exclusively floating point register name
6092         aliases.
6093
6094 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6095
6096         PR gdb/18644:
6097         * f-lang.c (build_fortran_types): Handle the case where
6098         gdbarch_floatformat_for_type returns a nullptr.
6099
6100 2019-05-21  Tom de Vries  <tdevries@suse.de>
6101
6102         PR cli/24587
6103         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6104
6105 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6106
6107         PR gdb/18644:
6108         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6109         16-byte floats.
6110         * i386-tdep.c (i386_floatformat_for_type): Use
6111         floatformats_ia64_quad for the 16-byte floating point component
6112         within a fortran 32-byte complex number.
6113
6114 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6115
6116         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6117         delete default constructor.
6118         (find_partial_die): Update to return const struct.
6119         (partial_die_parent_scope): Move variable declaration into scope
6120         of its use and change its type to auto.
6121         (guess_partial_die_structure_name): Likewise.
6122         (partial_die_info::fixup): Likewise.
6123
6124 2019-05-17  Tom Tromey  <tromey@adacore.com>
6125
6126         * source.c (find_and_open_source): Remove cast.
6127
6128 2019-05-17  Tom Tromey  <tromey@adacore.com>
6129
6130         * annotate.c (annotate_source): Make "filename" const.
6131         * annotate.h (annotate_source): Use const.
6132
6133 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6134
6135         * disasm.c (set_disassembler_options): Send errors to stderr.
6136
6137 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6138
6139         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6140         (cli_interp_base::set_logging): Check debug_redirect.
6141         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6142         * cli/cli-logging.c (debug_redirect): Add static variable.
6143         (pop_output_files): Add default param.
6144         (handle_redirections): Print debug setting.
6145         (show_logging_command): Likewise.
6146         (_initialize_cli_logging): Add debugredirect command.
6147         * interps.c (current_interp_set_logging): Add debug_redirect
6148         parameter.
6149         * interps.h (set_logging): Add debug_redirect parameter.
6150         (current_interp_set_logging): Likewise.
6151         * mi/mi-common.h: Likewise.
6152         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6153
6154 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6155             Tom Tromey  <tromey@adacore.com>
6156
6157         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6158         directly.
6159         * cli/cli-interp.h (make_logging_output): Remove declaration.
6160         * cli/cli-logging.c (make_logging_output): Remove function.
6161         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6162         directly.
6163         * ui-file.c (tee_file::tee_file): Remove bools.
6164         (tee_file::~tee_file): Remove deletes.
6165         * ui-file.h (tee_file): Remove bools.
6166
6167 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6168
6169         * mi/mi-cmds.h (mi_cmd_complete): New function.
6170         * mi/mi-main.c (mi_cmd_complete): Likewise.
6171         * mi/mi-cmds.c: Define new MI command -complete.
6172         * NEWS: Mention new -complete command.
6173
6174 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6175
6176         * completer.h (complete): New function.
6177         * completer.c (complete): Likewise.
6178         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6179         function defined in completer.h.
6180
6181 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6182
6183         * MAINTAINERS (Write After Approval): Add myself.
6184
6185 2019-05-17  Tom de Vries  <tdevries@suse.de>
6186
6187         PR gdb/24094
6188         * dwarf2read.c (struct cu_partial_die_info): New struct.
6189         (find_partial_die): Return cu_partial_die_info.
6190         (partial_die_parent_scope, guess_partial_die_structure_name)
6191         (partial_die_info::fixup): Handle new return type of find_partial_die.
6192
6193 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6194
6195         PR breakpoints/24541
6196         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6197         "std::string", simplifying the algorithm.
6198
6199 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6200
6201         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6202         (stap_static_probe_ops::get_probes): Likewise.
6203
6204 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6205
6206         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6207         '-')" and "else if".
6208         (stap_parse_single_operand): Join checks for
6209         "gdbarch_stap_parse_special_token_p" and
6210         "gdbarch_stap_parse_special_token" in the same "if" statement.
6211         Invert check when verifying for operation on register
6212         displacement.
6213
6214 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6215
6216         * stap-probe.c (stap_get_opcode): Update comment.
6217         (stap_get_expected_argument_type): Likewise.
6218         (handle_stap_probe): Likewise.
6219
6220 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6221
6222         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6223         return type to 'bool'.  Adjust comment.  Use 'bool' when
6224         appropriate.
6225         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6226         * stap-probe.c (stap_parse_argument_1): Likewise.
6227         (stap_is_operator): Likewise.
6228         (stap_is_generic_prefix): Likewise.
6229         (stap_is_register_prefix): Likewise.
6230         (stap_is_register_indirection_prefix): Likewise.
6231         (stap_is_integer_prefix): Likewise.
6232         (stap_generic_check_suffix): Likewise.
6233         (stap_check_integer_suffix): Likewise.
6234         (stap_check_register_suffix): Likewise.
6235         (stap_check_register_indirection_suffix): Likewise.
6236         (stap_parse_register_operand): Likewise.
6237         (stap_parse_single_operand): Likewise.
6238         (stap_parse_argument_1): Likewise.
6239         (stap_probe::get_argument_count): Likewise.
6240         (stap_is_operator): Likewise.
6241
6242 2019-05-16  Tom Tromey  <tromey@adacore.com>
6243
6244         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6245         keyword to foreach.
6246
6247 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6248
6249         * linux-thread-db.c (try_thread_db_load_1): Change return type
6250         to bool.
6251         (try_thread_db_load): Likewise.
6252         (try_thread_db_load_from_pdir_1): Likewise.
6253         (try_thread_db_load_from_pdir): Likewise.
6254         (try_thread_db_load_from_sdir): Likewise.
6255         (try_thread_db_load_from_dir): Likewise.
6256         (thread_db_load_search): Likewise.
6257         (has_libpthread): Likewise.
6258         (thread_db_load): Likewise.
6259
6260 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6261
6262         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6263         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6264         NULL, and complain/return if that's the case.
6265
6266 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6267
6268         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6269         (advance, posn, abstract_read_memory): New functions.
6270         [struct mem_read_abstraction]: New struct.
6271         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6272
6273 2019-05-14  Tom Tromey  <tromey@adacore.com>
6274
6275         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6276         value is not lval_memory.
6277
6278 2019-05-14  Tom Tromey  <tromey@adacore.com>
6279
6280         * solib.c (info_sharedlibrary_command): Style the file name.
6281
6282 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6283
6284         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6285         (aarch64_vnv_type): Likewise.
6286         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6287         * common/tdesc.c: Likewise.
6288         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6289         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6290         * features/aarch64-fpu.xml: Add ieee half view.
6291         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6292         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6293         * gdbtypes.h (struct builtin_type): Likewise.
6294         (struct objfile_type): Likewise.
6295
6296 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6297
6298         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6299         typo.
6300         * location.h (string_to_event_location): Likewise.
6301
6302 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6303
6304         GDB 8.3 released.
6305
6306 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6307
6308         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6309         New variable declaration.
6310         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6311         New variable.
6312         (print_one_breakpoint): Use ui_out::test_flags and new global
6313         variable to compute use_fixed_output.
6314         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6315         Remove.
6316         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6317         (mi_multi_location_breakpoint_output_fixed): Remove.
6318         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6319         new variable.
6320         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6321         fix_multi_location_breakpoint_output flag if version >= 3.
6322         * ui-out.h (enum ui_out_flag)
6323         <fix_multi_location_breakpoint_output>: New enumerator.
6324
6325 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6326
6327         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6328
6329 2019-05-10  Tom Tromey  <tromey@adacore.com>
6330
6331         * ada-lang.c (catch_ada_completer): New function.
6332         (_initialize_ada_language): Use it.
6333
6334 2019-05-10  Tom Tromey  <tromey@adacore.com>
6335
6336         * thread.c (print_thread_info): Make "requested_threads" const.
6337         * gdbthread.h (print_thread_info): Make "requested_threads"
6338         const.
6339         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6340         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6341
6342 2019-05-08  Tom Tromey  <tom@tromey.com>
6343
6344         * gdbtypes.c (objfile_type_data): Change type.
6345         (objfile_type, _initialize_gdbtypes): Update.
6346
6347 2019-05-08  Tom Tromey  <tom@tromey.com>
6348
6349         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6350         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6351         (_initialize_dwarf2_frame): Update.
6352
6353 2019-05-08  Tom Tromey  <tom@tromey.com>
6354
6355         * objc-lang.c (objc_objfile_data): Change type.
6356         (find_methods): Update.
6357         (_initialize_objc_lang): Remove.
6358
6359 2019-05-08  Tom Tromey  <tom@tromey.com>
6360
6361         * stabsread.c (rs6000_builtin_type_data): Change type.
6362         (rs6000_builtin_type, _initialize_stabsread): Update.
6363
6364 2019-05-08  Tom Tromey  <tom@tromey.com>
6365
6366         * mips-tdep.c (mips_pdr_data): Remove.
6367         (_initialize_mips_tdep): Update.
6368
6369 2019-05-08  Tom Tromey  <tom@tromey.com>
6370
6371         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6372         (hppa_init_objfile_priv_data, read_unwind_info)
6373         (find_unwind_entry, _initialize_hppa_tdep): Update.
6374
6375 2019-05-08  Tom Tromey  <tom@tromey.com>
6376
6377         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6378         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6379         on obstack.
6380         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6381
6382 2019-05-08  Tom Tromey  <tom@tromey.com>
6383
6384         * mdebugread.c (basic_type_data): Change type.
6385         (basic_type, _initialize_mdebugread): Update.
6386
6387 2019-05-08  Tom Tromey  <tom@tromey.com>
6388
6389         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6390
6391 2019-05-08  Tom Tromey  <tom@tromey.com>
6392
6393         * nto-tdep.c (nto_inferior_data_reg): Change type.
6394         (nto_inferior_data): Update.
6395         (nto_inferior_data_cleanup, nto_new_inferior_data)
6396         (_initialize_nto_tdep): Remove.
6397         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6398
6399 2019-05-08  Tom Tromey  <tom@tromey.com>
6400
6401         * ada-lang.c (struct ada_inferior_data): Add initializers.
6402         (ada_inferior_data): Change type.
6403         (ada_inferior_data_cleanup): Remove.
6404         (get_ada_inferior_data, ada_inferior_exit)
6405         (struct ada_pspace_data): Add initializers, destructor.
6406         (ada_pspace_data_handle): Change type.
6407         (get_ada_pspace_data): Update.
6408         (ada_pspace_data_cleanup): Remove.
6409
6410 2019-05-08  Tom Tromey  <tom@tromey.com>
6411
6412         * coffread.c (struct coff_symfile_info): Add initializers.
6413         (coff_objfile_data_key): Move lower.  Change type.
6414         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6415         Update.
6416         (coff_free_info): Remove.
6417
6418 2019-05-08  Tom Tromey  <tom@tromey.com>
6419
6420         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6421         (fbsd_pspace_data_handle): Move lower.  Change type.
6422         (get_fbsd_pspace_data): Update.
6423         (fbsd_pspace_data_cleanup): Remove.
6424         (_initialize_fbsd_tdep): Update.
6425
6426 2019-05-08  Tom Tromey  <tom@tromey.com>
6427
6428         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6429         (get_ada_tasks_pspace_data): Update.
6430         (ada_tasks_pspace_data_cleanup): Remove.
6431         (_initialize_tasks): Update.
6432         (ada_tasks_inferior_data_handle): Change type.
6433         (get_ada_tasks_inferior_data): Update.
6434         (ada_tasks_inferior_data_cleanup): Remove.
6435         (struct ada_tasks_pspace_data): Add initializers.
6436
6437 2019-05-08  Tom Tromey  <tom@tromey.com>
6438
6439         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6440         * symfile-debug.c (debug_sym_get_probes): Change type.
6441         * stap-probe.c (handle_stap_probe):
6442         (stap_static_probe_ops::get_probes): Change type.
6443         * probe.h (class static_probe_ops) <get_probes>: Change type.
6444         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6445         (parse_probes_in_pspace): Update.
6446         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6447         Update.
6448         (any_static_probe_ops::get_probes): Change type.
6449         * elfread.c (elfread_data): New typedef.
6450         (probe_key): Change type.
6451         (elf_get_probes): Likewise.  Update.
6452         (probe_key_free): Remove.
6453         (_initialize_elfread): Update.
6454         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6455         Change type.
6456         (dtrace_process_dof_probe, dtrace_process_dof)
6457         (dtrace_static_probe_ops::get_probe): Change type.
6458
6459 2019-05-08  Tom Tromey  <tom@tromey.com>
6460
6461         * xcoffread.c (struct xcoff_symfile_info): Rename from
6462         coff_symfile_info.  Add initializers.
6463         (xcoff_objfile_data_key): Move lower.  Change type.
6464         (XCOFF_DATA): Rewrite.
6465         (xcoff_free_info): Remove.
6466         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6467         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6468         (xcoff_initial_scan): Update.
6469
6470 2019-05-08  Tom Tromey  <tom@tromey.com>
6471
6472         * solib-svr4.c (struct svr4_info): Add initializers and
6473         destructor.
6474         <probes_table>: Now an htab_up.
6475         (solib_svr4_pspace_data): Change type.
6476         (free_probes_table): Simplify.
6477         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6478         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6479         (probes_table_remove_objfile_probes, register_solib_event_probe)
6480         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6481         (_initialize_svr4_solib): Update.
6482
6483 2019-05-08  Tom Tromey  <tom@tromey.com>
6484
6485         * remote.c (remote_pspace_data): Change type.
6486         (remote_pspace_data_cleanup): Remove.
6487         (get_remote_exec_file, set_pspace_remote_exec_file)
6488         (_initialize_remote): Update.
6489
6490 2019-05-08  Tom Tromey  <tom@tromey.com>
6491
6492         * breakpoint.c (breakpoint_objfile_key): Change type.
6493         (get_breakpoint_objfile_data): Update.
6494         (free_breakpoint_objfile_data): Remove.
6495         (_initialize_breakpoint): Update.
6496
6497 2019-05-08  Tom Tromey  <tom@tromey.com>
6498
6499         * linux-tdep.c (struct linux_info): Add initializers.
6500         (linux_inferior_data): Move.  Change type.
6501         (invalidate_linux_cache_inf): Update.
6502         (linux_inferior_data_cleanup): Remove.
6503         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6504
6505 2019-05-08  Tom Tromey  <tom@tromey.com>
6506
6507         * auxv.c (auxv_inferior_data): Move.  Change type.
6508         (auxv_inferior_data_cleanup): Remove.
6509         (invalidate_auxv_cache_inf): Rewrite.
6510         (get_auxv_inferior_data, _initialize_auxv): Update.
6511
6512 2019-05-08  Tom Tromey  <tom@tromey.com>
6513
6514         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6515         (symfile_debug_objfile_data_key): Change type.
6516         (symfile_debug_installed, debug_qf_has_symbols)
6517         (debug_qf_find_last_source_symtab)
6518         (debug_qf_forget_cached_source_info)
6519         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6520         (debug_qf_print_stats, debug_qf_dump)
6521         (debug_qf_expand_symtabs_for_function)
6522         (debug_qf_expand_all_symtabs)
6523         (debug_qf_expand_symtabs_with_fullname)
6524         (debug_qf_map_matching_symbols)
6525         (debug_qf_expand_symtabs_matching)
6526         (debug_qf_find_pc_sect_compunit_symtab)
6527         (debug_qf_map_symbol_filenames)
6528         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6529         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6530         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6531         (debug_sym_read_linetable, debug_sym_relocate): Update.
6532         (symfile_debug_free_objfile): Remove.
6533         (install_symfile_debug_logging, _initialize_symfile_debug):
6534         Update.
6535
6536 2019-05-08  Tom Tromey  <tom@tromey.com>
6537
6538         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6539         allocate_on_obstack.
6540         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6541         (get_dwarf2_per_objfile): Update.
6542         (set_dwarf2_per_objfile): Remove.
6543         (dwarf2_has_info, dwarf2_get_section_info): Update.
6544         (dwarf2_free_objfile): Remove.
6545         (_initialize_dwarf2_read): Update.
6546
6547 2019-05-08  Tom Tromey  <tom@tromey.com>
6548
6549         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6550         initializers.
6551         <unsupported_script_warning_printed,
6552         script_not_found_warning_printed>: Now bool.
6553         (auto_load_pspace_data): Change type.
6554         (~auto_load_pspace_info): Rename from
6555         auto_load_pspace_data_cleanup.
6556         (get_auto_load_pspace_data, init_loaded_scripts_info)
6557         (clear_section_scripts, maybe_print_unsupported_script_warning)
6558         (maybe_print_script_not_found_warning, _initialize_auto_load):
6559         Update.
6560
6561 2019-05-08  Tom Tromey  <tom@tromey.com>
6562
6563         * objfiles.c (objfile_pspace_info): Add destructor and
6564         initializers.
6565         (objfiles_pspace_data): Change type.
6566         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6567         (get_objfile_pspace_data): Update.
6568         (objfiles_bfd_data): Change type.
6569         (get_objfile_bfd_data): Update.
6570         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6571
6572 2019-05-08  Tom Tromey  <tom@tromey.com>
6573
6574         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6575         Change type.
6576         (get_catch_syscall_inferior_data): Update.
6577         (catch_syscall_inferior_data_cleanup): Remove.
6578         (_initialize_break_catch_syscall): Update.
6579
6580 2019-05-08  Tom Tromey  <tom@tromey.com>
6581
6582         * inflow.c (struct terminal_info): Add destructor and
6583         initializers.
6584         (inflow_inferior_data): Change type.
6585         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6586         (get_inflow_inferior_data, inflow_inferior_exit)
6587         (swap_terminal_info, _initialize_inflow): Update.
6588
6589 2019-05-08  Tom Tromey  <tom@tromey.com>
6590
6591         * target-dcache.c (target_dcache_cleanup): Remove.
6592         (target_dcache_aspace_key): Change type.
6593         (target_dcache_init_p, target_dcache_invalidate)
6594         (target_dcache_get, target_dcache_get_or_init)
6595         (_initialize_target_dcache): Update.
6596         * dcache.h (struct dcache_deleter): New.
6597
6598 2019-05-08  Tom Tromey  <tom@tromey.com>
6599
6600         * symtab.c (struct symbol_cache): Add destructor and
6601         initializers.
6602         (symbol_cache_key): Move.  Change type.
6603         (make_symbol_cache, free_symbol_cache): Remove.
6604         (get_symbol_cache): Update.
6605         (symbol_cache_cleanup): Remove.
6606         (ALL_PSPACES, symbol_cache_flush)
6607         (maintenance_print_symbol_cache)
6608         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6609         Update.
6610
6611 2019-05-08  Tom Tromey  <tom@tromey.com>
6612
6613         * symtab.c (struct main_info): Add destructor and initializers.
6614         (main_progspace_key): Move.  Change type.
6615         (get_main_info): Update.
6616         (main_info_cleanup): Remove.
6617         (_initialize_symtab): Update.
6618
6619 2019-05-08  Tom Tromey  <tom@tromey.com>
6620
6621         * registry.h (DECLARE_REGISTRY): Define the _key class.
6622
6623 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6624
6625         * NEWS: Merge two 'New commands' sections.
6626
6627 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6628
6629         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6630         parameter and use Ada language definition instead.
6631         (ada_val_print_ptr): Remove unused language parameter.
6632         (ada_val_print_num): Remove language parameter and use Ada language
6633         definition instead.
6634         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6635         parameter.
6636         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6637         parameter and use Ada language definition instead.
6638         (ada_val_print_1): Update all ada_val_print_xxx calls.
6639         Remove language parameter.
6640         (ada_val_print): Update ada_val_print_1 call.
6641
6642 2019-05-08  Tom Tromey  <tromey@adacore.com>
6643
6644         * remote.c (remote_hw_watchpoint_limit)
6645         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6646         Now static.
6647
6648 2019-05-08  Tom Tromey  <tromey@adacore.com>
6649
6650         * maint.c (_initialize_maint_cmds): Move initialization code to
6651         remote.c.
6652         (watchdog, show_watchdog): Move to remote.c.
6653         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6654         "watchdog" static.
6655         (_initialize_remote): Move initialization code from maint.c.
6656         * defs.h (watchdog): Don't declare.
6657
6658 2019-05-08  Tom Tromey  <tromey@adacore.com>
6659
6660         * tui/tui-interp.c: Include main.h.
6661         * interps.c: Include main.h.
6662         * main.h (interpreter_p): Declare.
6663         * defs.h (interpreter_p): Don't declare.
6664
6665 2019-05-08  Tom Tromey  <tromey@adacore.com>
6666
6667         * dwarf2loc.c: Include dwarf2read.h.
6668         * defs.h (read_unsigned_leb128): Don't declare.
6669         * dwarf2read.h (read_unsigned_leb128): Declare.
6670
6671 2019-05-08  Tom Tromey  <tromey@adacore.com>
6672
6673         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6674         method.
6675
6676 2019-05-08  Tom Tromey  <tromey@adacore.com>
6677
6678         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6679         when no wrap column is set.
6680
6681 2019-05-08  Tom Tromey  <tromey@adacore.com>
6682
6683         * c-lang.c (c_get_string): Handle non-C-style arrays.
6684
6685 2019-05-08  Tom Tromey  <tromey@adacore.com>
6686
6687         * typeprint.c (print_offset_data::update): Print the bit offset,
6688         not the number of bits remaining.
6689
6690 2019-05-08  Tom Tromey  <tromey@adacore.com>
6691
6692         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6693         padding at end of comment.
6694
6695 2019-05-08  Tom Tromey  <tromey@adacore.com>
6696
6697         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6698         Compare main types.
6699
6700 2019-05-06  Tom Tromey  <tom@tromey.com>
6701
6702         * common/scoped_mmap.c: Include common-defs.h.
6703         * common/scoped_mmap.h: Don't include config.h.
6704
6705 2019-05-04  Tom Tromey  <tom@tromey.com>
6706
6707         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6708         (struct aarch64_call_info): Add initializers.
6709         <si>: Now a std::vector.
6710         (pass_on_stack, aarch64_push_dummy_call): Update.
6711
6712 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6713             Tom Tromey  <tom@tromey.com>
6714
6715         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6716         (ppc_threads): Now a std::vector.  Now static.
6717         (hwdebug_find_thread_points_by_tid)
6718         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6719         Update.
6720
6721 2019-05-04  Tom Tromey  <tom@tromey.com>
6722
6723         * arc-tdep.c (arc_tdesc_init): Return bool.
6724
6725 2019-05-04  Tom Tromey  <tom@tromey.com>
6726
6727         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6728         Use gdb_assert_not_reached.
6729
6730 2019-05-04  Tom Tromey  <tom@tromey.com>
6731
6732         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6733         "false".
6734
6735 2019-05-04  Tom Tromey  <tom@tromey.com>
6736
6737         * arc-tdep.c (arc_tdesc_init): Use bool.
6738
6739 2019-05-04  Tom Tromey  <tom@tromey.com>
6740
6741         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6742
6743 2019-05-04  Tom Tromey  <tom@tromey.com>
6744
6745         * cli/cli-cmds.c (valid_command_p): Return bool.
6746
6747 2019-05-04  Tom Tromey  <tom@tromey.com>
6748
6749         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6750         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6751
6752 2019-05-04  Raul Tambre  <raul@tambre.ee>
6753
6754         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6755         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6756         operator for comparison.
6757
6758 2019-05-04  Tom Tromey  <tom@tromey.com>
6759
6760         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6761         (lookup_partial_symbol, print_partial_symbols)
6762         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6763         (psymbol_compare): Update.
6764         (add_psymbol_to_bcache): Clear the entire psymbol.
6765         (maintenance_check_psymtabs): Update.
6766         * psympriv.h (struct partial_symbol): Don't derive from
6767         general_symbol_info.
6768         <obj_section, unrelocated_address, address,
6769         set_unrelocated_address>: Update.
6770         <ginfo>: New member.
6771         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6772         (debug_names::write_psymbols): Update.
6773
6774 2019-05-04  Tom de Vries  <tdevries@suse.de>
6775
6776         * contrib/cc-with-tweaks.sh: Support -n arg.
6777
6778 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6779
6780         * corelow.c (core_target::detach): Ensure frame cache and
6781         register caches are cleared.
6782         inferior.c (exit_inferior_1): Likewise.
6783
6784 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6785             Tom Tromey  <tom@tromey.com>
6786
6787         * dictionary.c (collate_pending_symbols_by_language): Remove
6788         "struct" from foreach.
6789         * symtab.c (lookup_global_symbol_from_objfile)
6790         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6791         foreach.
6792         * ser-tcp.c (net_open): Remove "struct" from foreach.
6793         * objfiles.c (objfile_relocate, objfile_rebase)
6794         (objfile_has_symbols): Remove "struct" from foreach.
6795         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6796         from foreach.
6797         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6798         foreach.
6799         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6800         "struct" from foreach.
6801         * ada-lang.c (create_excep_cond_exprs)
6802         (ada_exception_catchpoint_cond_string): Remove "struct" from
6803         foreach.
6804
6805 2019-05-03  Tom Tromey  <tromey@adacore.com>
6806
6807         * ada-exp.y (convert_char_literal): Check suffix of each
6808         enumerator.
6809
6810 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6811
6812         PR ada/21406:
6813         * ada-exp.y (yywrap): Don't define.
6814         * ada-lex.l (%option): Add noyywrap
6815         (yywrap): Remove.
6816
6817 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6818
6819         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6820         _WIN32_WINNT to the XP level, unless already defined to a higher
6821         level.
6822
6823         * unittests/parse-connection-spec-selftests.c:
6824         * ser-tcp.c:
6825         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6826         override.
6827
6828         * symfile.c (find_separate_debug_file): Remove colon from the
6829         drive spec of DOS/Windows file names of the target, so that the
6830         file name produced from DEBUGDIR and the target's directory will
6831         be valid on DOS/Windows systems.
6832
6833 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6834
6835         * rust-lang.c (val_print_struct): Handle printing structures
6836         containing strings.
6837
6838 2019-05-02  Tom Tromey  <tromey@adacore.com>
6839
6840         * valarith.c (_initialize_valarith): Remove.
6841
6842 2019-05-01  Tom Tromey  <tromey@adacore.com>
6843
6844         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6845         bitfields.
6846
6847 2019-05-01  Tom Tromey  <tromey@adacore.com>
6848
6849         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6850         for big-endian copies.
6851
6852 2019-04-30  Ali Tamur  <tamur@google.com>
6853         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6854         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6855         (read_3_bytes): New function.
6856
6857 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6858
6859         * windows-nat.c (main_thread_id): Delete.
6860         (handle_output_debug_string): Replace main_thread_id by
6861         current_event.dwThreadId.
6862         (fake_create_process): Likewise.
6863         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6864         Do not set main_thread_id.
6865         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6866         current_event.dwThreadId.
6867         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6868
6869 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6870
6871         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6872         Use current_event.dwThreadId instead of main_thread_id.
6873
6874 2019-04-30  Tom Tromey  <tromey@adacore.com>
6875
6876         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6877         (create_excep_cond_exprs): Iterate over program spaces.
6878         (ada_exception_catchpoint_cond_string): Examine all minimal
6879         symbols for exception types.
6880
6881 2019-04-30  Tom Tromey  <tromey@adacore.com>
6882
6883         PR c++/24470:
6884         * dwarf2read.c (process_structure_scope): Handle case where type
6885         has template parameters but no symbol was created.
6886
6887 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6888             Chris January  <chris.january@arm.com>
6889
6890         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6891         qualifier.
6892         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6893
6894 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6895
6896         * f-typeprint.c (f_print_type): Update rules for printing
6897         whitespace.
6898         (f_type_print_varspec_suffix): Likewise.
6899
6900 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6901             Chris January  <chris.january@arm.com>
6902
6903         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6904         function arguments.
6905
6906 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6907
6908         * f-lang.c (build_fortran_types): Change name of void type to
6909         lower case.
6910         * f-typeprint.c (f_type_print_base): Print the name of the void
6911         type, rather than a fixed string.
6912         * f-valprint.c (f_decorations): Use lower case void string.
6913
6914 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6915             Chris January  <chris.january@arm.com>
6916
6917         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6918         types for Fortran.
6919
6920 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6921             Chris January  <chris.january@arm.com>
6922             David Lecomber  <david.lecomber@arm.com>
6923
6924         * f-exp.y (BINOP_INTRINSIC): New token.
6925         (exp): New parser rule handling BINOP_INTRINSIC.
6926         (f77_keywords): Add new builtin procedures.
6927         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6928         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6929         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6930         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6931         (print_unop_subexp_f): New function.
6932         (print_binop_subexp_f): New function.
6933         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6934         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6935         (dump_subexp_body_f): Likewise.
6936         (operator_check_f): Likewise.
6937         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6938         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6939
6940 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6941
6942         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6943         UNOP_KIND.
6944         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6945         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6946         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6947         (operator_length_f): New fuction.
6948         (print_subexp_f): New function.
6949         (op_name_f): New function.
6950         (dump_subexp_body_f): New function.
6951         (operator_check_f): New function.
6952         (exp_descriptor_f): Replace standard expression handling functions
6953         with new functions.
6954         * gdb/fortran-operator.def: New file.
6955         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6956         * gdb/std-operator.def: Remove UNOP_KIND.
6957
6958 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6959
6960         * std-operator.def: Remove unbalanced, stray double quote
6961         character.
6962
6963 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6964             Chris January  <chris.january@arm.com>
6965             Daniel Everett  <daniel.everett@arm.com>
6966             Nick Forrington  <nick.forrington@arm.com>
6967             Richard Bunt  <richard.bunt@arm.com>
6968
6969         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6970         of depth when printing anonymous structs or unions.
6971         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6972         Don't print either the top-level value, or the children if the
6973         max-depth is exceeded.
6974         (ppscm_print_children): When printing the key of a map, allow one
6975         extra level of depth.
6976         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6977         print either the top-level value, or the children if the max-depth
6978         is exceeded.
6979         (print_children): When printing the key of a map, allow one extra
6980         level of depth.
6981         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6982         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6983         (user_print_options): Initialise max_depth field.
6984         (val_print_scalar_or_string_type_p): New function.
6985         (val_print): Check to see if the max depth has been reached.
6986         (val_print_check_max_depth): Define new function.
6987         (show_print_max_depth): New function.
6988         (_initialize_valprint): Add 'print max-depth' option.
6989         * valprint.h (struct value_print_options) <max_depth>: New field.
6990         (val_print_check_max_depth): Declare new function.
6991         * NEWS: Document new feature.
6992
6993 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6994
6995         * ada-lang.c (ada_language_defn): Initialise new field.
6996         * c-lang.c (c_is_string_type_p): New function.
6997         (c_language_defn): Initialise new field.
6998         (cplus_language_defn): Initialise new field.
6999         (asm_language_defn): Initialise new field.
7000         (minimal_language_defn): Initialise new field.
7001         * c-lang.h (c_is_string_type_p): Declare new function.
7002         * d-lang.c (d_language_defn): Initialise new field.
7003         * f-lang.c (f_is_string_type_p): New function.
7004         (f_language_defn): Initialise new field.
7005         * go-lang.c (go_is_string_type_p): New function.
7006         (go_language_defn): Initialise new field.
7007         * language.c (default_is_string_type_p): New function.
7008         (unknown_language_defn): Initialise new field.
7009         (auto_language_defn): Initialise new field.
7010         * language.h (struct language_defn) <la_is_string_type_p>: New
7011         member variable.
7012         (default_is_string_type_p): Declare new function.
7013         * m2-lang.c (m2_language_defn): Initialise new field.
7014         * objc-lang.c (objc_language_defn): Initialise new field.
7015         * opencl-lang.c (opencl_language_defn): Initialise new field.
7016         * p-lang.c (pascal_is_string_type_p): New function.
7017         (pascal_language_defn): Initialise new field.
7018         * rust-lang.c (rust_is_string_type_p): New function.
7019         (rust_language_defn): Initialise new field.
7020
7021 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7022
7023         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7024         New field.
7025         * ada-lang.c (ada_language_defn): Initialise new field.
7026         * c-lang.c (c_language_defn): Likewise.
7027         (cplus_language_defn): Likewise.
7028         (asm_language_defn): Likewise.
7029         (minimal_language_defn): Likewise.
7030         * d-lang.c (d_language_defn): Likewise.
7031         * f-lang.c (f_language_defn): Likewise.
7032         * go-lang.c (go_language_defn): Likewise.
7033         * language.c (unknown_language_defn): Likewise.
7034         (auto_language_defn): Likewise.
7035         * m2-lang.c (m2_language_defn): Likewise.
7036         * objc-lang.c (objc_language_defn): Likewise.
7037         * opencl-lang.c (opencl_language_defn): Likewise.
7038         * p-lang.c (pascal_language_defn): Likewise.
7039         * rust-lang.c (rust_language_defn): Likewise.
7040
7041 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7042
7043         * ada-lang.c (ada_is_character_type): Change return type to bool.
7044         (ada_is_string_type): Likewise.
7045         * ada-lang.h (ada_is_character_type): Update declaration
7046         (ada_is_string_type): Likewise.
7047
7048 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7049
7050         Support style in 'frame|thread apply'
7051
7052         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7053         * record.c (record_start, record_stop): Update callers of
7054         execute_command_to_string with false.
7055         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7056         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7057         methods.
7058         (class string_file): New constructor with term_out parameter.
7059         Override methods term_out and can_emit_style_escape.  New member
7060         term_out.
7061         (class stdio_file): Override can_emit_style_escape.
7062         (class tee_file): Override term_out and can_emit_style_escape.
7063         * utils.h (can_emit_style_escape): Remove.
7064         * utils.c (can_emit_style_escape): Likewise.
7065         Update all callers of can_emit_style_escape (SOMESTREAM) to
7066         SOMESTREAM->can_emit_style_escape.
7067         * source-cache.c (source_cache::get_source_lines): Likewise.
7068         * stack.c (frame_apply_command_count): Call execute_command_to_string
7069         passing the term_out characteristic of the current gdb_stdout.
7070         * thread.c (thr_try_catch_cmd): Likewise.
7071         * top.c (execute_command_to_string): pass term_out parameter
7072         to construct the string_file for the command output.
7073         * ui-file.c (term_cli_styling): New function (most code moved
7074         from utils.c can_emit_style_escape).
7075         (string_file::string_file, string_file::can_emit_style_escape,
7076         stdio_file::can_emit_style_escape, tee_file::term_out,
7077         tee_file::can_emit_style_escape): New functions.
7078
7079 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7080
7081         * NEWS: Mention the new set|show may-call-functions.
7082         * infcall.c (may_call_functions_p): New variable.
7083         (show_may_call_functions_p): New function.
7084         (call_function_by_hand_dummy): Throws an error if not
7085         may-call-functions.
7086         (_initialize_infcall): Call add_setshow_boolean_cmd for
7087         may-call-functions.
7088
7089 2019-04-25  Keith Seitz  <keiths@redhat.com>
7090
7091         PR c++/24367
7092         * cp-support.c (inspect_type): Don't attempt substitutions
7093         of symbol with the same name.
7094
7095 2019-04-25  Tom Tromey  <tromey@adacore.com>
7096
7097         PR gdb/24475:
7098         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7099         static.
7100
7101 2019-04-25  Tom Tromey  <tromey@adacore.com>
7102
7103         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7104         rvalue reference.
7105         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7106         (gdb_xml_parser::parse): Use std::move.
7107         * python/python-internal.h (gdbpy_convert_exception): Take a const
7108         reference.
7109         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7110         std::move.
7111         * python/py-utils.c (gdbpy_convert_exception): Take a const
7112         reference.
7113         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7114         Use std::move.
7115         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7116         Use std::move.
7117         * mi/mi-main.c (mi_print_exception): Take a const reference.
7118         * main.c (handle_command_errors): Take a const reference.
7119         * linespec.c (parse_linespec): Use std::move.
7120         * infcall.c (run_inferior_call): Use std::move.
7121         (call_function_by_hand_dummy): Use std::move.
7122         * exec.c (try_open_exec_file): Use std::move.
7123         * exceptions.h (exception_print, exception_fprintf)
7124         (exception_print_same): Update.
7125         * exceptions.c (print_exception, exception_print)
7126         (exception_fprintf, exception_print_same): Change parameters to
7127         const reference.
7128         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7129         * common/new-op.c: Use std::move.
7130         * common/common-exceptions.h (struct gdb_exception): Add move
7131         constructor.
7132         (struct gdb_exception_error, struct gdb_exception_quit, struct
7133         gdb_quit_bad_alloc): Change constructor to move constructor.
7134         (throw_exception): Change parameter to rvalue reference.
7135         * common/common-exceptions.c (throw_exception): Take rvalue
7136         reference.
7137         * cli/cli-interp.c (safe_execute_command): Use std::move.
7138         * breakpoint.c (insert_bp_location, location_to_sals): Use
7139         std::move.
7140
7141 2019-04-25  Tom Tromey  <tromey@adacore.com>
7142
7143         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7144         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7145         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7146         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7147         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7148         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7149         guile/scm-value.c: Use unpack.
7150         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7151         gdbscm_gdb_exception.
7152         (gdbscm_throw_gdb_exception): Likewise.
7153         (struct gdbscm_gdb_exception): New.
7154         (unpack): New function.
7155         (gdbscm_wrap): Use unpack.
7156
7157 2019-04-25  Tom Tromey  <tromey@adacore.com>
7158
7159         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7160         (gdb_rl_callback_handler): Use std::move.
7161         * common/common-exceptions.h (struct gdb_exception): Add move
7162         assignment operator.
7163         (throw_exception_sjlj): Change "exception" to const reference.
7164         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7165         (throw_exception_sjlj): Change "exception" to const reference.
7166
7167 2019-04-25  Tom Tromey  <tromey@adacore.com>
7168
7169         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7170         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7171         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7172         Update.
7173         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7174         Update.
7175         * mi/mi-interp.c (mi_interp::exec): Update.
7176         * linespec.c (parse_linespec): Update.
7177         * infcall.c (run_inferior_call): Update.
7178         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7179         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7180         (gdbscm_lookup_global_symbol): Update.
7181         * guile/scm-param.c (gdbscm_parameter_value): Update.
7182         * guile/scm-frame.c (gdbscm_frame_read_register)
7183         (gdbscm_frame_read_var): Update.
7184         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7185         * exec.c (try_open_exec_file): Update.
7186         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7187         (gdb_rl_callback_handler): Update.
7188         * common/common-exceptions.h (exception_none): Don't declare.
7189         * common/common-exceptions.c (exception_none): Don't define.
7190         (struct catcher) <exception>: Update.
7191         * cli/cli-interp.c (safe_execute_command): Update.
7192         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7193
7194 2019-04-25  Ali Tamur  <tamur@google.com>
7195
7196         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7197         (read_attribute_value): Likewise.
7198         (dwarf2_read_addr_index): Update comment.
7199         (read_str_index): Add DW_FORM_strx.
7200         (dwarf2_string_attr): Likewise.
7201         (dwarf2_const_value_attr): Likewise.
7202         (dump_die_shallow): Likewise.
7203         (dwarf2_fetch_constant_bytes): Likewise.
7204         (skip_form_bytes): Likewise.
7205         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7206
7207 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7208
7209         PR corefiles/11608
7210         PR corefiles/18187
7211         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7212         OFFSET.  Verify if current mapping contains an ELF header.
7213         (linux_find_memory_regions_full): Adjust call to
7214         dump_mapping_p.
7215
7216 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7217             Kang Li <kanglictf@gmail.com>
7218
7219         PR gdb/21600
7220
7221         * dwarf2-frame.c (read_initial_length): Be consistent about using
7222         unsigned representation of length.
7223         (decode_frame_entry_1): Likewise.  Check for wraparound of
7224         end pointer as well as buffer overflow.
7225
7226 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7227
7228         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7229         "vq".
7230
7231 2019-04-24  Tom Tromey  <tromey@adacore.com>
7232
7233         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7234
7235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7236
7237         * s12z-tdep.c (s12z_unwind_pc): Delete.
7238         (s12z_unwind_sp): Delete.
7239         (s12z_gdbarch_init): Don't register deleted functions with
7240         gdbarch.
7241
7242 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7243
7244         * rl78-tdep.c (rl78_unwind_sp): Delete.
7245         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7246
7247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7248
7249         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7250         (xstormy16_unwind_pc): Delete.
7251         (xstormy16_dummy_id): Delete.
7252         (xstormy16_gdbarch_init): Don't register deleted functions with
7253         gdbarch.
7254
7255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7256
7257         * vax-tdep.c (vax_unwind_pc): Delete.
7258         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7259
7260 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7261
7262         * v850-tdep.c (v850_unwind_sp): Delete.
7263         (v850_unwind_pc): Delete.
7264         (v850_dummy_id): Delete.
7265         (v850_gdbarch_init): Don't register deleted functions with
7266         gdbarch.
7267
7268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7269
7270         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7271         (tilegx_unwind_pc): Delete.
7272         (tilegx_unwind_dummy_id): Delete.
7273         (tilegx_gdbarch_init): Don't register deleted functions with
7274         gdbarch.
7275
7276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7277
7278         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7279         (tic6x_dummy_id): Delete.
7280         (tic6x_gdbarch_init): Don't register deleted functions with
7281         gdbarch.
7282
7283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7284
7285         * sparc-tdep.c (sparc_unwind_pc): Delete.
7286         (sparc32_gdbarch_init): Don't register deleted function with
7287         gdbarch.
7288
7289 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7290
7291         * sh-tdep.c (sh_unwind_sp): Delete.
7292         (sh_unwind_pc): Delete.
7293         (sh_dummy_id): Delete.
7294         (sh_gdbarch_init): Don't register deleted functions with
7295         gdbarch.
7296
7297 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7298
7299         * score-tdep.c (score_unwind_sp): Delete.
7300         (score_unwind_pc): Delete.
7301         (score_dummy_id): Delete.
7302         (score_gdbarch_init): Don't register deleted functions with
7303         gdbarch.
7304
7305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7306
7307         * rx-tdep.c (rx_unwind_pc): Delete.
7308         (rx_unwind_sp): Delete.
7309         (rx_dummy_id): Delete.
7310         (rx_gdbarch_init): Don't register deleted functions with
7311         gdbarch.  Update comment.
7312
7313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7314
7315         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7316         (rs6000_dummy_id): Delete.
7317         (rs6000_gdbarch_init): Don't register deleted functions with
7318         gdbarch.
7319
7320 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7321
7322         * or1k-tdep.c (or1k_dummy_id): Delete.
7323         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7324
7325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7326
7327         * nios2-tdep.c (nios2_dummy_id): Delete.
7328         (nios2_unwind_sp): Delete.
7329         (nios2_gdbarch_init): Don't register deleted functions with
7330         gdbarch.
7331
7332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7333
7334         * nds32-tdep.c (nds32_dummy_id): Delete.
7335         (nds32_unwind_pc): Delete.
7336         (nds32_unwind_sp): Delete.
7337         (nds32_gdbarch_init): Don't register deleted functions with
7338         gdbarch.
7339
7340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7341
7342         * msp430-tdep.c (msp430_unwind_pc): Delete.
7343         (msp430_unwind_sp): Delete.
7344         (msp430_dummy_id): Delete.
7345         (msp430_gdbarch_init): Don't register deleted functions with
7346         gdbarch.
7347
7348 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7349
7350         * moxie-tdep.c (moxie_unwind_sp): Delete.
7351         (moxie_unwind_pc): Delete.
7352         (moxie_dummy_id): Delete.
7353         (moxie_gdbarch_init): Don't register deleted functions with
7354         gdbarch.
7355
7356 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7357
7358         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7359         (mn10300_unwind_pc): Delete.
7360         (mn10300_unwind_sp): Delete.
7361         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7362         mn10300_unwind_sp.
7363         (mn10300_frame_unwind_init): Don't register deleted functions with
7364         gdbarch.
7365
7366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7367
7368         * mep-tdep.c (mep_unwind_pc): Delete.
7369         (mep_unwind_sp): Delete.
7370         (mep_dummy_id): Delete.
7371         (mep_gdbarch_init): Don't register deleted functions with
7372         gdbarch.
7373
7374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7375
7376         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7377         (m68hc11_unwind_sp): Delete.
7378         (m68hc11_gdbarch_init): Don't register deleted functions with
7379         gdbarch.
7380
7381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7382
7383         * m32r-tdep.c (m32r_unwind_sp): Delete.
7384         (m32r_unwind_pc): Delete.
7385         (m32r_dummy_id): Delete.
7386         (m32r_gdbarch_init): Don't register deleted functions with
7387         gdbarch.
7388
7389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7390
7391         * m32c-tdep.c (m32c_unwind_pc): Delete.
7392         (m32c_unwind_sp): Delete.
7393         (m32c_dummy_id): Delete.
7394         (m32c_gdbarch_init): Don't register deleted functions with
7395         gdbarch.
7396
7397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7398
7399         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7400         (lm32_unwind_pc): Delete.
7401         (lm32_dummy_id): Delete.
7402         (lm32_gdbarch_init): Don't register deleted functions with
7403         gdbarch.
7404
7405 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7406
7407         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7408         (iq2000_unwind_pc): Delete.
7409         (iq2000_dummy_id): Delete.
7410         (iq2000_gdbarch_init): Don't register deleted functions with
7411         gdbarch.
7412
7413 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7414
7415         * nds32-tdep.c (nds32_type_align): Delete.
7416         (nds32_push_dummy_call): Use type_align instead.
7417
7418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7419
7420         * arm-tdep.c (arm_type_align): Only handle vector override case.
7421         (arm_push_dummy_call): Use type_align.
7422         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7423
7424 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7425
7426         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7427         case.
7428         (pass_on_stack): Use type_align.
7429         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7430         function.
7431
7432 2019-04-23  Tom Tromey  <tromey@adacore.com>
7433
7434         * dwarf2read.c (line_header::file_name_at): Remove unused
7435         overload.
7436
7437 2019-04-23  Tom de Vries  <tdevries@suse.de>
7438
7439         PR gdb/24438
7440         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7441         invocation.
7442
7443
7444 2019-03-27  Ali Tamur  <tamur@google.com>
7445
7446         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7447         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7448         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7449         (dwarf_expr_context::get_addr_index): Likewise
7450         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7451         (symbol_needs_eval_context::get_addr_index): Likewise
7452         (disassemble_dwarf_expression): Add DW_OP_addrx
7453         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7454         (read_cutu_die_from_dwo): Update comment
7455         (skip_one_die): Add DW_FORM_addrx
7456         (read_attribute_value): Likewise
7457         (var_decode_location): Add DW_OP_addrx
7458         (dwarf2_const_value_attr): Add DW_FORM_addrx
7459         (dump_die_shallow): Likewise
7460         (dwarf2_fetch_constant_bytes): Likewise
7461         (decode_locdesc): Add DW_OP_addrx
7462         (skip_form_bytes): Add DW_FORM_addrx
7463
7464 2019-04-22  Ali Tamur  <tamur@google.com>
7465
7466         * MAINTAINERS (Write After Approval): Add self.
7467
7468 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7469
7470         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7471         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7472         (open_symbol_file_object): Likewise.
7473         (svr4_default_sos): Add info parameter.
7474         (svr4_read_so_list): Likewise.
7475         (svr4_current_sos_direct): Adjust functions calls to pass down
7476         info.
7477         (svr4_current_sos_1): Add info parameter.
7478         (svr4_current_sos): Call get_svr4_info, pass info down to
7479         svr4_current_sos_1.
7480         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7481         get_svr4_info.
7482         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7483         get_svr4_info.
7484         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7485         to get_svr4_info.
7486         (probes_table_remove_objfile_probes): Likewise.
7487         (register_solib_event_probe): Add info parameter.
7488         (solist_update_incremental): Pass info parameter down to
7489         svr4_read_so_list.
7490         (disable_probes_interface): Add info parameter.
7491         (svr4_handle_solib_event): Pass current_program_space to
7492         get_svr4_info.  Adjust disable_probes_interface cleanup.
7493         (svr4_create_probe_breakpoints): Add info parameter, pass it
7494         down to register_solib_event_probe.
7495         (svr4_create_solib_event_breakpoints): Add info parameter,
7496         pass it down to svr4_create_probe_breakpoints.
7497         (enable_break): Pass info down to
7498         svr4_create_solib_event_breakpoints.
7499         (svr4_solib_create_inferior_hook): Pass current_program_space to
7500         get_svr4_info.
7501         (svr4_clear_solib): Likewise.
7502
7503 2019-04-22  Pedro Alves  <palves@redhat.com>
7504
7505         * solib-svr4.c (svr4_free_objfile_observer): New.
7506         (probe_and_action::objfile): New field.
7507         (probes_table_htab_remove_objfile_probes)
7508         (probes_table_remove_objfile_probes): New functions.
7509         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7510         in the new probe_and_action.  Don't store the probe in 'lookup'.
7511         (svr4_create_probe_breakpoints): Pass objfile to
7512         register_solib_event_probe.
7513         (_initialize_svr4_solib): Register a free_objfile observer.
7514
7515 2019-04-19  Tom Tromey  <tom@tromey.com>
7516
7517         * common/queue.h: Remove.
7518
7519 2019-04-19  Tom Tromey  <tom@tromey.com>
7520
7521         * event-loop.c: Don't include "common/queue.h".
7522
7523 2019-04-19  Tom Tromey  <tom@tromey.com>
7524
7525         * remote.c (remote_target): Use delete.
7526         * remote-notif.h: Include <list>, not "common/queue.h".
7527         (notif_client_p): Remove typedef.
7528         (remote_notif_state): Add constructor, destructor, initializer.
7529         <notif_queue>: Now a std::list.
7530         (remote_notif_state_xfree): Don't declare.
7531         * remote-notif.c (remote_notif_process, handle_notification)
7532         (remote_notif_state_allocate): Update.
7533         (~remote_notif_state): Rename from remote_notif_state_xfree.
7534
7535 2019-04-19  Tom Tromey  <tom@tromey.com>
7536
7537         * symfile.c (reread_symbols): Update.
7538         * objfiles.c (objfile_register_static_link)
7539         (objfile_lookup_static_link): Update
7540         (~objfile) Don't delete static_links.
7541         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7542
7543 2019-04-19  Tom Tromey  <tom@tromey.com>
7544
7545         * type-stack.h (struct type_stack) <insert>: Constify string.
7546         * type-stack.c (type_stack::insert): Constify string.
7547         * gdbtypes.h (lookup_template_type): Update.
7548         (address_space_name_to_int): Update.
7549         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7550         const.
7551         (lookup_template_type): Make name const.
7552         * c-exp.y: Update rules.
7553         (lex_one_token, classify_name, classify_inner_name)
7554         (c_print_token): Update.
7555         * p-exp.y: Update rules.
7556         (yylex): Update.
7557         * f-exp.y: Update rules.
7558         (yylex): Update.
7559         * d-exp.y: Update rules.
7560         (lex_one_token, classify_name, classify_inner_name): Update.
7561         * parse.c (write_dollar_variable, copy_name): Return std::string.
7562         * parser-defs.h (copy_name): Change return type.
7563         * m2-exp.y: Update rules.
7564         (yylex): Update.
7565         * go-exp.y (lex_one_token): Update.
7566         Update rules.
7567         (classify_unsafe_function, classify_packaged_name)
7568         (classify_name, yylex): Update.
7569
7570 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7571
7572         * configure.ac: add --enable-source-highlight switch.
7573         * configure: Regenerate.
7574         * top.c (print_gdb_version): plumb --enable-source-highlight
7575         status to "show configuration".
7576
7577 2019-04-19  Tom Tromey  <tromey@adacore.com>
7578
7579         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7580         Check ADA_TYPE_P.
7581         (empty_record, ada_template_to_fixed_record_type_1)
7582         (template_to_static_fixed_type)
7583         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7584         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7585         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7586         macros.
7587
7588 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7589
7590         PR symtab/24423:
7591         * source.c (print_source_lines_base): Advance "iter" when a
7592         control character is seen.
7593
7594 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7595
7596         * inferior.h (struct infcall_suspend_state_deleter):
7597         Catch exception in destructor to avoid crash.
7598
7599 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7600
7601         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7602         close to the add_com "shell".
7603
7604 2019-04-18  Tom Tromey  <tromey@adacore.com>
7605
7606         * process-stratum-target.h (class process_stratum_target)
7607         <stratum>: Add "final".
7608
7609 2019-04-17  Tom Tromey  <tromey@adacore.com>
7610
7611         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7612         against nullptr before use.
7613
7614 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7615
7616         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7617
7618 2019-04-17  Jim Wilson  <jimw@sifive.com>
7619             Andrew Burgess  <andrew.burgess@embecosm.com>
7620
7621         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7622         code read might fail, assume 4-byte breakpoint in that case.
7623
7624 2019-04-15  Leszek Swirski  <leszeks@google.com>
7625
7626         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7627         rather than a hand-rolled POD check when checking for forced MEMORY
7628         classification.
7629
7630 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7631
7632         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7633         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7634         function.
7635         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7636         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7637         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7638         declaration.
7639
7640 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7641
7642         * aarch64-linux-nat.c
7643         (aarch64_linux_nat_target::thread_architecture): Add override.
7644         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7645         each VQ.
7646
7647 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7648
7649         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7650
7651 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7652
7653         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7654         target types of size 96-bits, add some additional comments, and
7655         check that the builtin type we found was the correct size.
7656
7657 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7658
7659         * utils.c (prompt_for_continue): Don't restore the styling at the
7660         end, as applied_style has the wrong value.  This fixes styling in
7661         long lists of file names that are interrupted by the "Continue?"
7662         prompt.
7663
7664 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7665
7666         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7667         * c-lang.c (c_language_defn): Likewise.
7668         (cplus_language_defn): Likewise.
7669         (asm_language_defn): Likewise.
7670         (minimal_language_defn): Likewise.
7671         * d-lang.c (d_language_defn): Likewise.
7672         * f-lang.c (f_language_defn): Likewise.
7673         * go-lang.c (go_language_defn): Likewise.
7674         * language.c (unknown_language_defn): Likewise.
7675         (auto_language_defn): Likewise.
7676         * language.h (struct language_defn): Remove la_magic field.
7677         (LANG_MAGIC): Delete.
7678         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7679         * objc-lang.c (objc_language_defn): Likewise.
7680         * opencl-lang.c (opencl_language_defn): Likewise.
7681         * p-lang.c (pascal_language_defn): Likewise.
7682         * rust-lang.c (rust_language_defn): Likewise.
7683
7684 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7685
7686         * riscv-tdep.c (riscv_type_align): New function.
7687         (riscv_type_alignment): Delete.
7688         (riscv_arg_location): Use 'type_align'.
7689         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7690
7691 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7692
7693         * gdbtypes.c (type_align): A struct with no non-static fields also
7694         has alignment of 1.
7695
7696 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7697
7698         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7699         component to 0.
7700         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7701         member.
7702         (riscv_struct_info::analyse): New implementation using new
7703         analyse_inner member function.
7704         (riscv_struct_info::field_offset): New member function.
7705         (riscv_struct_info::m_offsets): New member variable.
7706         (riscv_struct_info::analyse_inner): New private member function,
7707         takes the old implementation of riscv_struct_info::analyse but
7708         extended to track field offsets.
7709         (riscv_call_arg_struct): Update the struct folding special cases
7710         to handle cases where empty C++ structs, which are non-zero
7711         length, are found.
7712         (riscv_arg_location): Initialise the length of each location, a
7713         non-zero length now indicates the location is in use.
7714         (riscv_push_dummy_call): Allow for the first location having a
7715         non-zero offset when setting up arguments.
7716         (riscv_return_value): Likewise, but for return values.
7717
7718 2019-04-11  Tom Tromey  <tromey@adacore.com>
7719
7720         * utils.c (internal_vproblem): Make "msg" const.
7721
7722 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7723
7724         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7725         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7726         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7727         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7728
7729 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7730
7731         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7732         function.
7733         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7734         of amd64_collect_native_gregset.
7735         (amd64_linux_nat_target::store_registers): Likewise.
7736
7737 2019-04-10  Tom Tromey  <tom@tromey.com>
7738
7739         * symtab.c (lookup_global_symbol_from_objfile)
7740         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7741         * objfiles.h (class separate_debug_iterator): New.
7742         (class separate_debug_range): New.
7743         (struct objfile) <separate_debug_objfiles>: New method.
7744         (objfile_separate_debug_iterate): Don't declare.
7745         * objfiles.c (separate_debug_iterator::operator++): Rename from
7746         objfile_separate_debug_iterate.
7747         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7748         iterator.
7749         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7750         iterator.
7751
7752 2019-04-10  Tom Tromey  <tom@tromey.com>
7753
7754         * symfile.c (reread_symbols): Remove old comment.
7755         * objfiles.c (free_all_objfiles): Fix a typo.
7756
7757 2019-04-10  Tom Tromey  <tom@tromey.com>
7758
7759         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7760         * minsyms.c (lookup_minimal_symbol): Use foreach.
7761         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7762         (lookup_minimal_symbol_solib_trampoline): Likewise.
7763         * symfile.c (reread_symbols): Use foreach.
7764
7765 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7766             Tom Tromey  <tromey@adacore.com>
7767
7768         PR rust/24414:
7769         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7770         (rust_lex_int_test): Change "value" to be LONGEST.
7771         (rust_lex_tests): Add test for long integer literal.
7772
7773 2019-04-09  Tom Tromey  <tromey@adacore.com>
7774
7775         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7776         to bool.
7777         (extended_remote_target::attach): Update.
7778         (remote_target::remote_notice_new_inferior): Update.
7779         (remote_target::add_current_inferior_and_thread): Update.
7780         * inferior.c (exit_inferior_1): Use "false".
7781         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7782
7783 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7784
7785         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7786         the "start" command.
7787
7788 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7789
7790         * python/py-inferior.c (infpy_thread_from_thread_handle):
7791         Adjust comments to reflect renaming of thread_from_thread_handle
7792         to thread_from_handle.  Adjust keywords.  Fix type error message.
7793         (inferior_object_methods): Add thread_from_handle.  Retain
7794         thread_from_thread_handle, but mark it as deprecated.
7795
7796 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7797
7798         * gdbthread.h (find_thread_by_handle): Revise declaration.
7799         * thread.c (find_thread_by_handle): Likewise.  Adjust
7800         implementation too.
7801         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7802         support for buffer objects as handles.
7803
7804 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7805
7806         * python/py-infthread.c (thpy_thread_handle): New function.
7807         (thread_object_methods): Register thpy_thread_handle.
7808
7809 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7810
7811         * gdbthread.h (thread_to_thread_handle): Declare.
7812         * thread.c (gdbtypes.h): Include.
7813         (thread_to_thread_handle): New function.
7814
7815         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7816         (target_thread_info_to_thread_handle): Declare.
7817         * target.c (target_thread_info_to_thread_handle): New function.
7818         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7819         * target-delegates.c: Regenerate.
7820
7821         * linux-thread-db.c (class thread_db_target): Add method
7822         thread_info_to_thread_handle.
7823         (thread_db_target::thread_info_to_thread_handle): Define.
7824         * remote.c (class remote_target): Add new method
7825         thread_info_to_thread_handle.
7826         (remote_target::thread_info_to_thread_handle): Define.
7827
7828 2019-04-08  Pedro Alves  <palves@redhat.com>
7829
7830         * common/common-exceptions.c (throw_exception): Don't create
7831         named object to throw; throw directly.
7832         (throw_it): Likewise.  Don't initialize gdb_exception::message
7833         here, with new; pass FMT and AP to the ctor instead.
7834         * common/common-exceptions.h: Include <string>.
7835         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7836         const char *, va_list)): New ctor.  Use std::make_shared.
7837         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7838         errors)): Delete.
7839         (gdb_exception_error::gdb_exception_error(enum errors, const char
7840         *, va_list)): New.
7841         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7842         Add assertion.
7843         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7844         errors)): Delete.
7845         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7846         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7847         Add assertion.
7848
7849 2019-04-08  Tom Tromey  <tom@tromey.com>
7850
7851         * valops.c (value_rtti_indirect_type): Replace throw_exception
7852         with throw.
7853         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7854         with throw.
7855         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7856         throw.
7857         * target.c (target_translate_tls_address): Replace throw_exception
7858         with throw.
7859         * stack.c (frame_apply_command_count): Replace throw_exception
7860         with throw.
7861         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7862         throw.
7863         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7864         with throw.
7865         * rs6000-tdep.c (rs6000_frame_cache)
7866         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7867         * remote.c: Replace throw_exception with throw.
7868         * record-full.c (record_full_message, record_full_wait_1)
7869         (record_full_restore): Replace throw_exception with throw.
7870         * record-btrace.c:
7871         (get_thread_current_frame_id, record_btrace_start_replaying)
7872         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7873         (cmd_record_btrace_start): Replace throw_exception with throw.
7874         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7875         throw.
7876         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7877         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7878         * linespec.c:
7879         (find_linespec_symbols): Replace throw_exception with throw.
7880         * infrun.c (displaced_step_prepare, resume): Replace
7881         throw_exception with throw.
7882         * infcmd.c (post_create_inferior): Replace throw_exception with
7883         throw.
7884         * inf-loop.c (inferior_event_handler): Replace throw_exception
7885         with throw.
7886         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7887         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7888         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7889         (get_prev_frame_always, get_frame_pc_if_available)
7890         (get_frame_address_in_block_if_available, get_frame_language):
7891         Replace throw_exception with throw.
7892         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7893         throw_exception with throw.
7894         * eval.c (fetch_subexp_value, evaluate_var_value)
7895         (evaluate_funcall, evaluate_subexp_standard): Replace
7896         throw_exception with throw.
7897         * dwarf2loc.c (call_site_find_chain)
7898         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7899         Replace throw_exception with throw.
7900         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7901         with throw.
7902         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7903         throw.
7904         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7905         * completer.c (complete_line_internal): Replace throw_exception
7906         with throw.
7907         * compile/compile-object-run.c (compile_object_run): Replace
7908         throw_exception with throw.
7909         * cli/cli-script.c (process_next_line): Replace throw_exception
7910         with throw.
7911         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7912         (btrace_enable, btrace_maint_update_pt_packets): Replace
7913         throw_exception with throw.
7914         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7915         throw_exception with throw.
7916         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7917         throw_exception with throw.
7918         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7919         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7920         * aarch64-tdep.c (aarch64_make_prologue_cache)
7921         (aarch64_make_stub_cache): Replace throw_exception with throw.
7922
7923 2019-04-08  Tom Tromey  <tom@tromey.com>
7924
7925         * common/common-exceptions.c (throw_exception): Rename from
7926         throw_exception_cxx.  Remove old copy.  Make argument const.
7927         (throw_it): Create and throw exception objects directly.
7928         * common/common-exceptions.h (throw_exception): Make argument
7929         const.
7930         (struct gdb_exception_error): Add constructor.
7931         (struct gdb_exception_quit): Add constructor.
7932
7933 2019-04-08  Tom Tromey  <tom@tromey.com>
7934
7935         * common/common-exceptions.h (exception_rethrow): Don't declare.
7936         (TRY_SJLJ): Update comment.
7937         (TRY, CATCH, END_CATCH): Remove.
7938         * common/common-exceptions.c (exception_rethrow): Remove.
7939
7940 2019-04-08  Tom Tromey  <tom@tromey.com>
7941
7942         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7943         Remove.
7944         (gdb_exception_error): Rename from
7945         gdb_exception_RETURN_MASK_ERROR.
7946         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7947         (gdb_quit_bad_alloc): Update.
7948         * aarch64-tdep.c: Update.
7949         * ada-lang.c: Update.
7950         * ada-typeprint.c: Update.
7951         * ada-valprint.c: Update.
7952         * amd64-tdep.c: Update.
7953         * arch-utils.c: Update.
7954         * break-catch-throw.c: Update.
7955         * breakpoint.c: Update.
7956         * btrace.c: Update.
7957         * c-varobj.c: Update.
7958         * cli/cli-cmds.c: Update.
7959         * cli/cli-interp.c: Update.
7960         * cli/cli-script.c: Update.
7961         * common/common-exceptions.c: Update.
7962         * common/new-op.c: Update.
7963         * common/selftest.c: Update.
7964         * compile/compile-c-symbols.c: Update.
7965         * compile/compile-cplus-symbols.c: Update.
7966         * compile/compile-object-load.c: Update.
7967         * compile/compile-object-run.c: Update.
7968         * completer.c: Update.
7969         * corelow.c: Update.
7970         * cp-abi.c: Update.
7971         * cp-support.c: Update.
7972         * cp-valprint.c: Update.
7973         * darwin-nat.c: Update.
7974         * disasm-selftests.c: Update.
7975         * dtrace-probe.c: Update.
7976         * dwarf-index-cache.c: Update.
7977         * dwarf-index-write.c: Update.
7978         * dwarf2-frame-tailcall.c: Update.
7979         * dwarf2-frame.c: Update.
7980         * dwarf2loc.c: Update.
7981         * dwarf2read.c: Update.
7982         * eval.c: Update.
7983         * event-loop.c: Update.
7984         * event-top.c: Update.
7985         * exec.c: Update.
7986         * f-valprint.c: Update.
7987         * fbsd-tdep.c: Update.
7988         * frame-unwind.c: Update.
7989         * frame.c: Update.
7990         * gdbtypes.c: Update.
7991         * gnu-v3-abi.c: Update.
7992         * guile/guile-internal.h: Update.
7993         * guile/scm-block.c: Update.
7994         * guile/scm-breakpoint.c: Update.
7995         * guile/scm-cmd.c: Update.
7996         * guile/scm-disasm.c: Update.
7997         * guile/scm-frame.c: Update.
7998         * guile/scm-lazy-string.c: Update.
7999         * guile/scm-math.c: Update.
8000         * guile/scm-param.c: Update.
8001         * guile/scm-ports.c: Update.
8002         * guile/scm-pretty-print.c: Update.
8003         * guile/scm-symbol.c: Update.
8004         * guile/scm-symtab.c: Update.
8005         * guile/scm-type.c: Update.
8006         * guile/scm-value.c: Update.
8007         * i386-linux-tdep.c: Update.
8008         * i386-tdep.c: Update.
8009         * inf-loop.c: Update.
8010         * infcall.c: Update.
8011         * infcmd.c: Update.
8012         * infrun.c: Update.
8013         * jit.c: Update.
8014         * language.c: Update.
8015         * linespec.c: Update.
8016         * linux-fork.c: Update.
8017         * linux-nat.c: Update.
8018         * linux-tdep.c: Update.
8019         * linux-thread-db.c: Update.
8020         * main.c: Update.
8021         * mi/mi-cmd-break.c: Update.
8022         * mi/mi-cmd-stack.c: Update.
8023         * mi/mi-interp.c: Update.
8024         * mi/mi-main.c: Update.
8025         * objc-lang.c: Update.
8026         * p-valprint.c: Update.
8027         * parse.c: Update.
8028         * ppc-linux-tdep.c: Update.
8029         * printcmd.c: Update.
8030         * python/py-arch.c: Update.
8031         * python/py-breakpoint.c: Update.
8032         * python/py-cmd.c: Update.
8033         * python/py-finishbreakpoint.c: Update.
8034         * python/py-frame.c: Update.
8035         * python/py-framefilter.c: Update.
8036         * python/py-gdb-readline.c: Update.
8037         * python/py-inferior.c: Update.
8038         * python/py-infthread.c: Update.
8039         * python/py-lazy-string.c: Update.
8040         * python/py-linetable.c: Update.
8041         * python/py-objfile.c: Update.
8042         * python/py-param.c: Update.
8043         * python/py-prettyprint.c: Update.
8044         * python/py-progspace.c: Update.
8045         * python/py-record-btrace.c: Update.
8046         * python/py-record.c: Update.
8047         * python/py-symbol.c: Update.
8048         * python/py-type.c: Update.
8049         * python/py-unwind.c: Update.
8050         * python/py-utils.c: Update.
8051         * python/py-value.c: Update.
8052         * python/python.c: Update.
8053         * record-btrace.c: Update.
8054         * record-full.c: Update.
8055         * remote-fileio.c: Update.
8056         * remote.c: Update.
8057         * riscv-tdep.c: Update.
8058         * rs6000-aix-tdep.c: Update.
8059         * rs6000-tdep.c: Update.
8060         * rust-exp.y: Update.
8061         * rust-lang.c: Update.
8062         * s390-tdep.c: Update.
8063         * selftest-arch.c: Update.
8064         * solib-dsbt.c: Update.
8065         * solib-frv.c: Update.
8066         * solib-spu.c: Update.
8067         * solib-svr4.c: Update.
8068         * solib.c: Update.
8069         * sparc64-linux-tdep.c: Update.
8070         * stack.c: Update.
8071         * symfile-mem.c: Update.
8072         * symmisc.c: Update.
8073         * target.c: Update.
8074         * thread.c: Update.
8075         * top.c: Update.
8076         * tracefile-tfile.c: Update.
8077         * tui/tui.c: Update.
8078         * typeprint.c: Update.
8079         * unittests/cli-utils-selftests.c: Update.
8080         * unittests/parse-connection-spec-selftests.c: Update.
8081         * valops.c: Update.
8082         * valprint.c: Update.
8083         * value.c: Update.
8084         * varobj.c: Update.
8085         * windows-nat.c: Update.
8086         * x86-linux-nat.c: Update.
8087         * xml-support.c: Update.
8088
8089 2019-04-08  Tom Tromey  <tom@tromey.com>
8090
8091         * xml-support.c: Use C++ exception handling.
8092         * x86-linux-nat.c: Use C++ exception handling.
8093         * windows-nat.c: Use C++ exception handling.
8094         * varobj.c: Use C++ exception handling.
8095         * value.c: Use C++ exception handling.
8096         * valprint.c: Use C++ exception handling.
8097         * valops.c: Use C++ exception handling.
8098         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8099         handling.
8100         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8101         * typeprint.c: Use C++ exception handling.
8102         * tui/tui.c: Use C++ exception handling.
8103         * tracefile-tfile.c: Use C++ exception handling.
8104         * top.c: Use C++ exception handling.
8105         * thread.c: Use C++ exception handling.
8106         * target.c: Use C++ exception handling.
8107         * symmisc.c: Use C++ exception handling.
8108         * symfile-mem.c: Use C++ exception handling.
8109         * stack.c: Use C++ exception handling.
8110         * sparc64-linux-tdep.c: Use C++ exception handling.
8111         * solib.c: Use C++ exception handling.
8112         * solib-svr4.c: Use C++ exception handling.
8113         * solib-spu.c: Use C++ exception handling.
8114         * solib-frv.c: Use C++ exception handling.
8115         * solib-dsbt.c: Use C++ exception handling.
8116         * selftest-arch.c: Use C++ exception handling.
8117         * s390-tdep.c: Use C++ exception handling.
8118         * rust-lang.c: Use C++ exception handling.
8119         * rust-exp.y: Use C++ exception handling.
8120         * rs6000-tdep.c: Use C++ exception handling.
8121         * rs6000-aix-tdep.c: Use C++ exception handling.
8122         * riscv-tdep.c: Use C++ exception handling.
8123         * remote.c: Use C++ exception handling.
8124         * remote-fileio.c: Use C++ exception handling.
8125         * record-full.c: Use C++ exception handling.
8126         * record-btrace.c: Use C++ exception handling.
8127         * python/python.c: Use C++ exception handling.
8128         * python/py-value.c: Use C++ exception handling.
8129         * python/py-utils.c: Use C++ exception handling.
8130         * python/py-unwind.c: Use C++ exception handling.
8131         * python/py-type.c: Use C++ exception handling.
8132         * python/py-symbol.c: Use C++ exception handling.
8133         * python/py-record.c: Use C++ exception handling.
8134         * python/py-record-btrace.c: Use C++ exception handling.
8135         * python/py-progspace.c: Use C++ exception handling.
8136         * python/py-prettyprint.c: Use C++ exception handling.
8137         * python/py-param.c: Use C++ exception handling.
8138         * python/py-objfile.c: Use C++ exception handling.
8139         * python/py-linetable.c: Use C++ exception handling.
8140         * python/py-lazy-string.c: Use C++ exception handling.
8141         * python/py-infthread.c: Use C++ exception handling.
8142         * python/py-inferior.c: Use C++ exception handling.
8143         * python/py-gdb-readline.c: Use C++ exception handling.
8144         * python/py-framefilter.c: Use C++ exception handling.
8145         * python/py-frame.c: Use C++ exception handling.
8146         * python/py-finishbreakpoint.c: Use C++ exception handling.
8147         * python/py-cmd.c: Use C++ exception handling.
8148         * python/py-breakpoint.c: Use C++ exception handling.
8149         * python/py-arch.c: Use C++ exception handling.
8150         * printcmd.c: Use C++ exception handling.
8151         * ppc-linux-tdep.c: Use C++ exception handling.
8152         * parse.c: Use C++ exception handling.
8153         * p-valprint.c: Use C++ exception handling.
8154         * objc-lang.c: Use C++ exception handling.
8155         * mi/mi-main.c: Use C++ exception handling.
8156         * mi/mi-interp.c: Use C++ exception handling.
8157         * mi/mi-cmd-stack.c: Use C++ exception handling.
8158         * mi/mi-cmd-break.c: Use C++ exception handling.
8159         * main.c: Use C++ exception handling.
8160         * linux-thread-db.c: Use C++ exception handling.
8161         * linux-tdep.c: Use C++ exception handling.
8162         * linux-nat.c: Use C++ exception handling.
8163         * linux-fork.c: Use C++ exception handling.
8164         * linespec.c: Use C++ exception handling.
8165         * language.c: Use C++ exception handling.
8166         * jit.c: Use C++ exception handling.
8167         * infrun.c: Use C++ exception handling.
8168         * infcmd.c: Use C++ exception handling.
8169         * infcall.c: Use C++ exception handling.
8170         * inf-loop.c: Use C++ exception handling.
8171         * i386-tdep.c: Use C++ exception handling.
8172         * i386-linux-tdep.c: Use C++ exception handling.
8173         * guile/scm-value.c: Use C++ exception handling.
8174         * guile/scm-type.c: Use C++ exception handling.
8175         * guile/scm-symtab.c: Use C++ exception handling.
8176         * guile/scm-symbol.c: Use C++ exception handling.
8177         * guile/scm-pretty-print.c: Use C++ exception handling.
8178         * guile/scm-ports.c: Use C++ exception handling.
8179         * guile/scm-param.c: Use C++ exception handling.
8180         * guile/scm-math.c: Use C++ exception handling.
8181         * guile/scm-lazy-string.c: Use C++ exception handling.
8182         * guile/scm-frame.c: Use C++ exception handling.
8183         * guile/scm-disasm.c: Use C++ exception handling.
8184         * guile/scm-cmd.c: Use C++ exception handling.
8185         * guile/scm-breakpoint.c: Use C++ exception handling.
8186         * guile/scm-block.c: Use C++ exception handling.
8187         * guile/guile-internal.h: Use C++ exception handling.
8188         * gnu-v3-abi.c: Use C++ exception handling.
8189         * gdbtypes.c: Use C++ exception handling.
8190         * frame.c: Use C++ exception handling.
8191         * frame-unwind.c: Use C++ exception handling.
8192         * fbsd-tdep.c: Use C++ exception handling.
8193         * f-valprint.c: Use C++ exception handling.
8194         * exec.c: Use C++ exception handling.
8195         * event-top.c: Use C++ exception handling.
8196         * event-loop.c: Use C++ exception handling.
8197         * eval.c: Use C++ exception handling.
8198         * dwarf2read.c: Use C++ exception handling.
8199         * dwarf2loc.c: Use C++ exception handling.
8200         * dwarf2-frame.c: Use C++ exception handling.
8201         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8202         * dwarf-index-write.c: Use C++ exception handling.
8203         * dwarf-index-cache.c: Use C++ exception handling.
8204         * dtrace-probe.c: Use C++ exception handling.
8205         * disasm-selftests.c: Use C++ exception handling.
8206         * darwin-nat.c: Use C++ exception handling.
8207         * cp-valprint.c: Use C++ exception handling.
8208         * cp-support.c: Use C++ exception handling.
8209         * cp-abi.c: Use C++ exception handling.
8210         * corelow.c: Use C++ exception handling.
8211         * completer.c: Use C++ exception handling.
8212         * compile/compile-object-run.c: Use C++ exception handling.
8213         * compile/compile-object-load.c: Use C++ exception handling.
8214         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8215         * compile/compile-c-symbols.c: Use C++ exception handling.
8216         * common/selftest.c: Use C++ exception handling.
8217         * common/new-op.c: Use C++ exception handling.
8218         * cli/cli-script.c: Use C++ exception handling.
8219         * cli/cli-interp.c: Use C++ exception handling.
8220         * cli/cli-cmds.c: Use C++ exception handling.
8221         * c-varobj.c: Use C++ exception handling.
8222         * btrace.c: Use C++ exception handling.
8223         * breakpoint.c: Use C++ exception handling.
8224         * break-catch-throw.c: Use C++ exception handling.
8225         * arch-utils.c: Use C++ exception handling.
8226         * amd64-tdep.c: Use C++ exception handling.
8227         * ada-valprint.c: Use C++ exception handling.
8228         * ada-typeprint.c: Use C++ exception handling.
8229         * ada-lang.c: Use C++ exception handling.
8230         * aarch64-tdep.c: Use C++ exception handling.
8231
8232 2019-04-08  Tom Tromey  <tom@tromey.com>
8233
8234         * xml-support.c (gdb_xml_parser::parse): Update.
8235         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8236         * value.c (show_convenience): Update.
8237         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8238         (test_parse_flags_qcs): Update.
8239         * thread.c (thr_try_catch_cmd): Update.
8240         * target.c (target_translate_tls_address): Update.
8241         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8242         (info_frame_command_core, frame_apply_command_count): Update.
8243         * rust-exp.y (rust_lex_exception_test): Update.
8244         * riscv-tdep.c (riscv_print_one_register_info): Update.
8245         * remote.c (remote_target::enable_btrace): Update.
8246         * record-btrace.c (record_btrace_enable_warn): Update.
8247         * python/py-utils.c (gdbpy_convert_exception): Update.
8248         * printcmd.c (do_one_display, print_variable_and_value): Update.
8249         * mi/mi-main.c (mi_print_exception): Update.
8250         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8251         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8252         * linux-nat.c (linux_nat_target::attach): Update.
8253         * linux-fork.c (class scoped_switch_fork_info): Update.
8254         * infrun.c (displaced_step_prepare): Update.
8255         * infcall.c (call_function_by_hand_dummy): Update.
8256         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8257         * gnu-v3-abi.c (print_one_vtable): Update.
8258         * frame.c (get_prev_frame_always): Update.
8259         * f-valprint.c (info_common_command_for_block): Update.
8260         * exec.c (try_open_exec_file): Update.
8261         * exceptions.c (print_exception, exception_print)
8262         (exception_fprintf, exception_print_same): Update.
8263         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8264         * dwarf-index-cache.c (index_cache::store)
8265         (index_cache::lookup_gdb_index): Update.
8266         * darwin-nat.c (maybe_cache_shell): Update.
8267         * cp-valprint.c (cp_print_value_fields): Update.
8268         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8269         (gcc_cplus_symbol_address): Update.
8270         * compile/compile-c-symbols.c (gcc_convert_symbol)
8271         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8272         * common/selftest.c: Update.
8273         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8274         a std::string.
8275         (exception_try_scope_entry, exception_try_scope_exit): Don't
8276         declare.
8277         (struct exception_try_scope): Remove.
8278         (TRY): Don't use exception_try_scope.
8279         (struct gdb_exception): Add constructor, operator=.
8280         <what>: New method.
8281         (struct gdb_exception_RETURN_MASK_ALL)
8282         (struct gdb_exception_RETURN_MASK_ERROR)
8283         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8284         (struct gdb_quit_bad_alloc): Update.
8285         * common/common-exceptions.c (exception_none): Change
8286         initializer.
8287         (struct catcher) <state, exception>: Initialize inline.
8288         <prev>: Remove member.
8289         (current_catcher): Remove.
8290         (catchers): New global.
8291         (exceptions_state_mc_init): Simplify.
8292         (catcher_pop): Remove.
8293         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8294         (try_scope_depth, exception_try_scope_entry)
8295         (exception_try_scope_exit): Remove.
8296         (throw_exception_sjlj): Update.
8297         (exception_messages, exception_messages_size): Remove.
8298         (throw_it): Simplify.
8299         (gdb_exception_sliced_copy): Remove.
8300         (throw_exception_cxx): Update.
8301         * cli/cli-script.c (script_from_file): Update.
8302         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8303         Update.
8304         * ada-valprint.c (ada_val_print): Update.
8305         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8306         (create_excep_cond_exprs): Update.
8307
8308 2019-04-08  Tom Tromey  <tom@tromey.com>
8309
8310         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8311         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8312         (TRY, CATCH, END_CATCH): Remove some definitions.
8313         * common/common-exceptions.c: Don't use GDB_XCPT.
8314         (catcher_list_size): Remove.
8315         (throw_exception, throw_it): Simplify.
8316
8317 2019-04-05  Tom Tromey  <tom@tromey.com>
8318
8319         Revert the header-sorting patch.
8320         * ft32-tdep.c: Revert.
8321         * frv-tdep.c: Revert.
8322         * frv-linux-tdep.c: Revert.
8323         * frame.c: Revert.
8324         * frame-unwind.c: Revert.
8325         * frame-base.c: Revert.
8326         * fork-child.c: Revert.
8327         * findvar.c: Revert.
8328         * findcmd.c: Revert.
8329         * filesystem.c: Revert.
8330         * filename-seen-cache.h: Revert.
8331         * filename-seen-cache.c: Revert.
8332         * fbsd-tdep.c: Revert.
8333         * fbsd-nat.h: Revert.
8334         * fbsd-nat.c: Revert.
8335         * f-valprint.c: Revert.
8336         * f-typeprint.c: Revert.
8337         * f-lang.c: Revert.
8338         * extension.h: Revert.
8339         * extension.c: Revert.
8340         * extension-priv.h: Revert.
8341         * expprint.c: Revert.
8342         * exec.h: Revert.
8343         * exec.c: Revert.
8344         * exceptions.c: Revert.
8345         * event-top.c: Revert.
8346         * event-loop.c: Revert.
8347         * eval.c: Revert.
8348         * elfread.c: Revert.
8349         * dwarf2read.h: Revert.
8350         * dwarf2read.c: Revert.
8351         * dwarf2loc.c: Revert.
8352         * dwarf2expr.h: Revert.
8353         * dwarf2expr.c: Revert.
8354         * dwarf2-frame.c: Revert.
8355         * dwarf2-frame-tailcall.c: Revert.
8356         * dwarf-index-write.h: Revert.
8357         * dwarf-index-write.c: Revert.
8358         * dwarf-index-common.c: Revert.
8359         * dwarf-index-cache.h: Revert.
8360         * dwarf-index-cache.c: Revert.
8361         * dummy-frame.c: Revert.
8362         * dtrace-probe.c: Revert.
8363         * disasm.h: Revert.
8364         * disasm.c: Revert.
8365         * disasm-selftests.c: Revert.
8366         * dictionary.c: Revert.
8367         * dicos-tdep.c: Revert.
8368         * demangle.c: Revert.
8369         * dcache.h: Revert.
8370         * dcache.c: Revert.
8371         * darwin-nat.h: Revert.
8372         * darwin-nat.c: Revert.
8373         * darwin-nat-info.c: Revert.
8374         * d-valprint.c: Revert.
8375         * d-namespace.c: Revert.
8376         * d-lang.c: Revert.
8377         * ctf.c: Revert.
8378         * csky-tdep.c: Revert.
8379         * csky-linux-tdep.c: Revert.
8380         * cris-tdep.c: Revert.
8381         * cris-linux-tdep.c: Revert.
8382         * cp-valprint.c: Revert.
8383         * cp-support.c: Revert.
8384         * cp-namespace.c: Revert.
8385         * cp-abi.c: Revert.
8386         * corelow.c: Revert.
8387         * corefile.c: Revert.
8388         * continuations.c: Revert.
8389         * completer.h: Revert.
8390         * completer.c: Revert.
8391         * complaints.c: Revert.
8392         * coffread.c: Revert.
8393         * coff-pe-read.c: Revert.
8394         * cli-out.h: Revert.
8395         * cli-out.c: Revert.
8396         * charset.c: Revert.
8397         * c-varobj.c: Revert.
8398         * c-valprint.c: Revert.
8399         * c-typeprint.c: Revert.
8400         * c-lang.c: Revert.
8401         * buildsym.c: Revert.
8402         * buildsym-legacy.c: Revert.
8403         * build-id.h: Revert.
8404         * build-id.c: Revert.
8405         * btrace.c: Revert.
8406         * bsd-uthread.c: Revert.
8407         * breakpoint.h: Revert.
8408         * breakpoint.c: Revert.
8409         * break-catch-throw.c: Revert.
8410         * break-catch-syscall.c: Revert.
8411         * break-catch-sig.c: Revert.
8412         * blockframe.c: Revert.
8413         * block.c: Revert.
8414         * bfin-tdep.c: Revert.
8415         * bfin-linux-tdep.c: Revert.
8416         * bfd-target.c: Revert.
8417         * bcache.c: Revert.
8418         * ax-general.c: Revert.
8419         * ax-gdb.h: Revert.
8420         * ax-gdb.c: Revert.
8421         * avr-tdep.c: Revert.
8422         * auxv.c: Revert.
8423         * auto-load.c: Revert.
8424         * arm-wince-tdep.c: Revert.
8425         * arm-tdep.c: Revert.
8426         * arm-symbian-tdep.c: Revert.
8427         * arm-pikeos-tdep.c: Revert.
8428         * arm-obsd-tdep.c: Revert.
8429         * arm-nbsd-tdep.c: Revert.
8430         * arm-nbsd-nat.c: Revert.
8431         * arm-linux-tdep.c: Revert.
8432         * arm-linux-nat.c: Revert.
8433         * arm-fbsd-tdep.c: Revert.
8434         * arm-fbsd-nat.c: Revert.
8435         * arm-bsd-tdep.c: Revert.
8436         * arch-utils.c: Revert.
8437         * arc-tdep.c: Revert.
8438         * arc-newlib-tdep.c: Revert.
8439         * annotate.h: Revert.
8440         * annotate.c: Revert.
8441         * amd64-windows-tdep.c: Revert.
8442         * amd64-windows-nat.c: Revert.
8443         * amd64-tdep.c: Revert.
8444         * amd64-sol2-tdep.c: Revert.
8445         * amd64-obsd-tdep.c: Revert.
8446         * amd64-obsd-nat.c: Revert.
8447         * amd64-nbsd-tdep.c: Revert.
8448         * amd64-nbsd-nat.c: Revert.
8449         * amd64-nat.c: Revert.
8450         * amd64-linux-tdep.c: Revert.
8451         * amd64-linux-nat.c: Revert.
8452         * amd64-fbsd-tdep.c: Revert.
8453         * amd64-fbsd-nat.c: Revert.
8454         * amd64-dicos-tdep.c: Revert.
8455         * amd64-darwin-tdep.c: Revert.
8456         * amd64-bsd-nat.c: Revert.
8457         * alpha-tdep.c: Revert.
8458         * alpha-obsd-tdep.c: Revert.
8459         * alpha-nbsd-tdep.c: Revert.
8460         * alpha-mdebug-tdep.c: Revert.
8461         * alpha-linux-tdep.c: Revert.
8462         * alpha-linux-nat.c: Revert.
8463         * alpha-bsd-tdep.c: Revert.
8464         * alpha-bsd-nat.c: Revert.
8465         * aix-thread.c: Revert.
8466         * agent.c: Revert.
8467         * addrmap.c: Revert.
8468         * ada-varobj.c: Revert.
8469         * ada-valprint.c: Revert.
8470         * ada-typeprint.c: Revert.
8471         * ada-tasks.c: Revert.
8472         * ada-lang.c: Revert.
8473         * aarch64-tdep.c: Revert.
8474         * aarch64-ravenscar-thread.c: Revert.
8475         * aarch64-newlib-tdep.c: Revert.
8476         * aarch64-linux-tdep.c: Revert.
8477         * aarch64-linux-nat.c: Revert.
8478         * aarch64-fbsd-tdep.c: Revert.
8479         * aarch64-fbsd-nat.c: Revert.
8480         * aarch32-linux-nat.c: Revert.
8481
8482 2019-04-05  Tom Tromey  <tom@tromey.com>
8483
8484         * ft32-tdep.c: Sort headers.
8485         * frv-tdep.c: Sort headers.
8486         * frv-linux-tdep.c: Sort headers.
8487         * frame.c: Sort headers.
8488         * frame-unwind.c: Sort headers.
8489         * frame-base.c: Sort headers.
8490         * fork-child.c: Sort headers.
8491         * findvar.c: Sort headers.
8492         * findcmd.c: Sort headers.
8493         * filesystem.c: Sort headers.
8494         * filename-seen-cache.h: Sort headers.
8495         * filename-seen-cache.c: Sort headers.
8496         * fbsd-tdep.c: Sort headers.
8497         * fbsd-nat.h: Sort headers.
8498         * fbsd-nat.c: Sort headers.
8499         * f-valprint.c: Sort headers.
8500         * f-typeprint.c: Sort headers.
8501         * f-lang.c: Sort headers.
8502         * extension.h: Sort headers.
8503         * extension.c: Sort headers.
8504         * extension-priv.h: Sort headers.
8505         * expprint.c: Sort headers.
8506         * exec.h: Sort headers.
8507         * exec.c: Sort headers.
8508         * exceptions.c: Sort headers.
8509         * event-top.c: Sort headers.
8510         * event-loop.c: Sort headers.
8511         * eval.c: Sort headers.
8512         * elfread.c: Sort headers.
8513         * dwarf2read.h: Sort headers.
8514         * dwarf2read.c: Sort headers.
8515         * dwarf2loc.c: Sort headers.
8516         * dwarf2expr.h: Sort headers.
8517         * dwarf2expr.c: Sort headers.
8518         * dwarf2-frame.c: Sort headers.
8519         * dwarf2-frame-tailcall.c: Sort headers.
8520         * dwarf-index-write.h: Sort headers.
8521         * dwarf-index-write.c: Sort headers.
8522         * dwarf-index-common.c: Sort headers.
8523         * dwarf-index-cache.h: Sort headers.
8524         * dwarf-index-cache.c: Sort headers.
8525         * dummy-frame.c: Sort headers.
8526         * dtrace-probe.c: Sort headers.
8527         * disasm.h: Sort headers.
8528         * disasm.c: Sort headers.
8529         * disasm-selftests.c: Sort headers.
8530         * dictionary.c: Sort headers.
8531         * dicos-tdep.c: Sort headers.
8532         * demangle.c: Sort headers.
8533         * dcache.h: Sort headers.
8534         * dcache.c: Sort headers.
8535         * darwin-nat.h: Sort headers.
8536         * darwin-nat.c: Sort headers.
8537         * darwin-nat-info.c: Sort headers.
8538         * d-valprint.c: Sort headers.
8539         * d-namespace.c: Sort headers.
8540         * d-lang.c: Sort headers.
8541         * ctf.c: Sort headers.
8542         * csky-tdep.c: Sort headers.
8543         * csky-linux-tdep.c: Sort headers.
8544         * cris-tdep.c: Sort headers.
8545         * cris-linux-tdep.c: Sort headers.
8546         * cp-valprint.c: Sort headers.
8547         * cp-support.c: Sort headers.
8548         * cp-namespace.c: Sort headers.
8549         * cp-abi.c: Sort headers.
8550         * corelow.c: Sort headers.
8551         * corefile.c: Sort headers.
8552         * continuations.c: Sort headers.
8553         * completer.h: Sort headers.
8554         * completer.c: Sort headers.
8555         * complaints.c: Sort headers.
8556         * coffread.c: Sort headers.
8557         * coff-pe-read.c: Sort headers.
8558         * cli-out.h: Sort headers.
8559         * cli-out.c: Sort headers.
8560         * charset.c: Sort headers.
8561         * c-varobj.c: Sort headers.
8562         * c-valprint.c: Sort headers.
8563         * c-typeprint.c: Sort headers.
8564         * c-lang.c: Sort headers.
8565         * buildsym.c: Sort headers.
8566         * buildsym-legacy.c: Sort headers.
8567         * build-id.h: Sort headers.
8568         * build-id.c: Sort headers.
8569         * btrace.c: Sort headers.
8570         * bsd-uthread.c: Sort headers.
8571         * breakpoint.h: Sort headers.
8572         * breakpoint.c: Sort headers.
8573         * break-catch-throw.c: Sort headers.
8574         * break-catch-syscall.c: Sort headers.
8575         * break-catch-sig.c: Sort headers.
8576         * blockframe.c: Sort headers.
8577         * block.c: Sort headers.
8578         * bfin-tdep.c: Sort headers.
8579         * bfin-linux-tdep.c: Sort headers.
8580         * bfd-target.c: Sort headers.
8581         * bcache.c: Sort headers.
8582         * ax-general.c: Sort headers.
8583         * ax-gdb.h: Sort headers.
8584         * ax-gdb.c: Sort headers.
8585         * avr-tdep.c: Sort headers.
8586         * auxv.c: Sort headers.
8587         * auto-load.c: Sort headers.
8588         * arm-wince-tdep.c: Sort headers.
8589         * arm-tdep.c: Sort headers.
8590         * arm-symbian-tdep.c: Sort headers.
8591         * arm-pikeos-tdep.c: Sort headers.
8592         * arm-obsd-tdep.c: Sort headers.
8593         * arm-nbsd-tdep.c: Sort headers.
8594         * arm-nbsd-nat.c: Sort headers.
8595         * arm-linux-tdep.c: Sort headers.
8596         * arm-linux-nat.c: Sort headers.
8597         * arm-fbsd-tdep.c: Sort headers.
8598         * arm-fbsd-nat.c: Sort headers.
8599         * arm-bsd-tdep.c: Sort headers.
8600         * arch-utils.c: Sort headers.
8601         * arc-tdep.c: Sort headers.
8602         * arc-newlib-tdep.c: Sort headers.
8603         * annotate.h: Sort headers.
8604         * annotate.c: Sort headers.
8605         * amd64-windows-tdep.c: Sort headers.
8606         * amd64-windows-nat.c: Sort headers.
8607         * amd64-tdep.c: Sort headers.
8608         * amd64-sol2-tdep.c: Sort headers.
8609         * amd64-obsd-tdep.c: Sort headers.
8610         * amd64-obsd-nat.c: Sort headers.
8611         * amd64-nbsd-tdep.c: Sort headers.
8612         * amd64-nbsd-nat.c: Sort headers.
8613         * amd64-nat.c: Sort headers.
8614         * amd64-linux-tdep.c: Sort headers.
8615         * amd64-linux-nat.c: Sort headers.
8616         * amd64-fbsd-tdep.c: Sort headers.
8617         * amd64-fbsd-nat.c: Sort headers.
8618         * amd64-dicos-tdep.c: Sort headers.
8619         * amd64-darwin-tdep.c: Sort headers.
8620         * amd64-bsd-nat.c: Sort headers.
8621         * alpha-tdep.c: Sort headers.
8622         * alpha-obsd-tdep.c: Sort headers.
8623         * alpha-nbsd-tdep.c: Sort headers.
8624         * alpha-mdebug-tdep.c: Sort headers.
8625         * alpha-linux-tdep.c: Sort headers.
8626         * alpha-linux-nat.c: Sort headers.
8627         * alpha-bsd-tdep.c: Sort headers.
8628         * alpha-bsd-nat.c: Sort headers.
8629         * aix-thread.c: Sort headers.
8630         * agent.c: Sort headers.
8631         * addrmap.c: Sort headers.
8632         * ada-varobj.c: Sort headers.
8633         * ada-valprint.c: Sort headers.
8634         * ada-typeprint.c: Sort headers.
8635         * ada-tasks.c: Sort headers.
8636         * ada-lang.c: Sort headers.
8637         * aarch64-tdep.c: Sort headers.
8638         * aarch64-ravenscar-thread.c: Sort headers.
8639         * aarch64-newlib-tdep.c: Sort headers.
8640         * aarch64-linux-tdep.c: Sort headers.
8641         * aarch64-linux-nat.c: Sort headers.
8642         * aarch64-fbsd-tdep.c: Sort headers.
8643         * aarch64-fbsd-nat.c: Sort headers.
8644         * aarch32-linux-nat.c: Sort headers.
8645
8646 2019-04-04  Tom Tromey  <tom@tromey.com>
8647
8648         * varobj.c (varobj_create): Update.
8649         * rust-exp.y (struct rust_parser) <update_innermost_block,
8650         lookup_symbol>: New methods.
8651         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8652         Rename.
8653         (rust_parser::rust_lookup_type)
8654         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8655         * printcmd.c (display_command, do_one_display): Update.
8656         * parser-defs.h (struct parser_state) <parser_state>: Add
8657         "tracker" parameter.
8658         (block_tracker): New member.
8659         (class innermost_block_tracker) <innermost_block_tracker>: Add
8660         "types" parameter.
8661         <reset>: Remove method.
8662         (innermost_block): Don't declare.
8663         (null_post_parser): Update.
8664         * parse.c (innermost_block): Remove global.
8665         (write_dollar_variable): Update.
8666         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8667         Remove "tracker_types" parameter.
8668         (parse_expression): Add "tracker" parameter.
8669         (parse_expression_for_completion): Update.
8670         (null_post_parser): Add "tracker" parameter.
8671         * p-exp.y: Update rules.
8672         * m2-exp.y: Update rules.
8673         * language.h (struct language_defn) <la_post_parser>: Add
8674         "tracker" parameter.
8675         * go-exp.y: Update rules.
8676         * f-exp.y: Update rules.
8677         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8678         parameter.
8679         * d-exp.y: Update rules.
8680         * c-exp.y: Update rules.
8681         * breakpoint.c (set_breakpoint_condition): Create an
8682         innermost_block_tracker.
8683         (watch_command_1): Likewise.
8684         * ada-lang.c (resolve): Add "tracker" parameter.
8685         (resolve_subexp): Likewise.
8686         * ada-exp.y (write_var_from_sym): Update.
8687
8688 2019-04-04  Tom Tromey  <tom@tromey.com>
8689
8690         * type-stack.h: New file.
8691         * type-stack.c: New file.
8692         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8693         type-stack.h.
8694         (insert_into_type_stack, insert_type, push_type, push_type_int)
8695         (insert_type_address_space, pop_type, pop_type_int)
8696         (pop_typelist, pop_type_stack, append_type_stack)
8697         (push_type_stack, get_type_stack, push_typelist)
8698         (follow_type_instance_flags, follow_types): Don't declare.
8699         * parse.c (type_stack): Remove global.
8700         (parse_exp_in_context): Update.
8701         (insert_into_type_stack, insert_type, push_type, push_type_int)
8702         (insert_type_address_space, pop_type, pop_type_int)
8703         (pop_typelist, pop_type_stack, append_type_stack)
8704         (push_type_stack, get_type_stack, push_typelist)
8705         (follow_type_instance_flags, follow_types): Remove (moved to
8706         type-stack.c).
8707         * f-exp.y (type_stack): New global.
8708         Update rules.
8709         (push_kind_type, f_parse): Update.
8710         * d-exp.y (type_stack): New global.
8711         Update rules.
8712         (d_parse): Update.
8713         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8714         Update rules.
8715         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8716         (HFILES_NO_SRCDIR): Add type-stack.h.
8717
8718 2019-04-04  Tom Tromey  <tom@tromey.com>
8719
8720         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8721         (rust_parser::convert_ast_to_expression, rust_parse)
8722         (rust_lex_test_completion, rust_lex_tests): Update.
8723         * parser-defs.h (struct expr_completion_state): New.
8724         (struct parser_state) <parser_state>: Add completion parameter.
8725         <mark_struct_expression, mark_completion_tag>: New methods.
8726         <parse_completion, m_completion_state>: New members.
8727         (prefixify_expression, null_post_parser): Update.
8728         (mark_struct_expression, mark_completion_tag): Don't declare.
8729         * parse.c (parse_completion, expout_last_struct)
8730         (expout_tag_completion_type, expout_completion_name): Remove
8731         globals.
8732         (parser_state::mark_struct_expression)
8733         (parser_state::mark_completion_tag): Now methods.
8734         (prefixify_expression): Add last_struct parameter.
8735         (prefixify_subexp): Likewise.
8736         (parse_exp_1): Update.
8737         (parse_exp_in_context): Add cstate parameter.  Update.
8738         (parse_expression_for_completion): Create an
8739         expr_completion_state.
8740         (null_post_parser): Add "completion" parameter.
8741         * p-exp.y: Update rules.
8742         (yylex): Update.
8743         * language.h (struct language_defn) <la_post_parser>: Add
8744         "completing" parameter.
8745         * go-exp.y: Update rules.
8746         (lex_one_token): Update.
8747         * expression.h (parse_completion): Don't declare.
8748         * d-exp.y: Update rules.
8749         (lex_one_token): Update rules.
8750         * c-exp.y: Update rules.
8751         (lex_one_token): Update.
8752         * ada-lang.c (resolve): Add "parse_completion" parameter.
8753         (resolve_subexp): Likewise.
8754         (ada_resolve_function): Likewise.
8755
8756 2019-04-04  Tom Tromey  <tom@tromey.com>
8757
8758         * parser-defs.h (struct parser_state) <start_arglist,
8759         end_arglist>: New methods.
8760         <arglist_len, m_funcall_chain>: New members.
8761         (arglist_len, start_arglist, end_arglist): Don't declare.
8762         * parse.c (arglist_len, funcall_chain): Remove global.
8763         (start_arglist, end_arglist): Remove functions.
8764         (parse_exp_in_context): Update.
8765         * p-exp.y: Update rules.
8766         * m2-exp.y: Update rules.
8767         * go-exp.y: Update rules.
8768         * f-exp.y: Update rules.
8769         * d-exp.y: Update rules.
8770         * c-exp.y: Update rules.
8771
8772 2019-04-04  Tom Tromey  <tom@tromey.com>
8773
8774         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8775         lex_operator, push_back>: New methods.
8776         Update all rules.
8777         (rust_parser::lex_hex, lex_escape): Rename and update.
8778         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8779         (rust_parser::lex_operator): Rename and update.
8780         (rust_parser::lex_number, rustyylex, rustyyerror)
8781         (rust_lex_test_init, rust_lex_test_sequence)
8782         (rust_lex_test_push_back, rust_lex_tests): Update.
8783         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8784         parameter.
8785         <lexptr, prev_lexptr>: New members.
8786         (lexptr, prev_lexptr): Don't declare.
8787         * parse.c (lexptr, prev_lexptr): Remove globals.
8788         (parse_exp_in_context): Update.
8789         * p-exp.y (yylex, yyerror): Update.
8790         * m2-exp.y (parse_number, yylex, yyerror): Update.
8791         * go-exp.y (lex_one_token, yyerror): Update.
8792         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8793         * d-exp.y (lex_one_token, yyerror): Update.
8794         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8795         (lex_one_token, yyerror): Update.
8796         * ada-lex.l (YY_INPUT): Update.
8797         (rewind_to_char): Update.
8798         * ada-exp.y (yyerror): Update.
8799
8800 2019-04-04  Tom Tromey  <tom@tromey.com>
8801
8802         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8803         * parser-defs.h (struct parser_state) <parser_state>: Add new
8804         parameter.
8805         <comma_terminates>: New member.
8806         (comma_terminates): Don't declare global.
8807         * parse.c (comma_terminates): Remove global.
8808         (parse_exp_in_context): Update.
8809         * p-exp.y (yylex): Update.
8810         * m2-exp.y (yylex): Update.
8811         * go-exp.y (lex_one_token): Update.
8812         * f-exp.y (yylex): Update.
8813         * d-exp.y (lex_one_token): Update.
8814         * c-exp.y (lex_one_token): Update.
8815         * ada-lex.l: Update.
8816
8817 2019-04-04  Tom Tromey  <tom@tromey.com>
8818
8819         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8820         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8821         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8822         * parser-defs.h (paren_depth): Don't declare.
8823         * parse.c (paren_depth): Remove global.
8824         (parse_exp_in_context): Update.
8825         * p-exp.y (paren_depth): New global.
8826         (pascal_parse): Initialize it.
8827         * m2-exp.y (paren_depth): New global.
8828         (m2_parse): Initialize it.
8829         * go-exp.y (paren_depth): New global.
8830         (go_parse): Initialize it.
8831         * f-exp.y (paren_depth): New global.
8832         (f_parse): Initialize it.
8833         * d-exp.y (paren_depth): New global.
8834         (d_parse): Initialize it.
8835         * c-exp.y (paren_depth): New global.
8836         (c_parse): Initialize it.
8837         * ada-lex.l (paren_depth): New global.
8838         (lexer_init): Initialize it.
8839
8840 2019-04-04  Tom Tromey  <tom@tromey.com>
8841
8842         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8843         (rust_parser::convert_ast_to_type)
8844         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8845         * parser-defs.h (struct parser_state) <parser_state>: Add
8846         parameters.  Initialize new members.
8847         <expression_context_block, expression_context_pc>: New members.
8848         * parse.c (expression_context_block, expression_context_pc):
8849         Remove globals.
8850         (parse_exp_in_context): Update.
8851         * p-exp.y: Update all rules.
8852         (yylex): Update.
8853         * m2-exp.y: Update all rules.
8854         (yylex): Update.
8855         * go-exp.y (yylex): Update.
8856         * f-exp.y (yylex): Update.
8857         * d-exp.y: Update all rules.
8858         (yylex): Update.
8859         * c-exp.y: Update all rules.
8860         (lex_one_token, classify_name, yylex, c_parse): Update.
8861         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8862
8863 2019-04-04  Tom Tromey  <tom@tromey.com>
8864
8865         * gdbarch.h, gdbarch.c: Rebuild.
8866         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8867         * stap-probe.h:
8868         (struct stap_parse_info): Replace "parser_state" with
8869         "expr_builder".
8870         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8871         (parser_state): New class.
8872         * parse.c (expr_builder): Rename.
8873         (expr_builder::release): Rename.
8874         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8875         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8876         (write_exp_elt_longcst, write_exp_elt_floatcst)
8877         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8878         (write_exp_string_vector, write_exp_bitstring)
8879         (write_exp_msymbol, mark_struct_expression)
8880         (write_dollar_variable)
8881         (insert_type_address_space, increase_expout_size): Replace
8882         "parser_state" with "expr_builder".
8883         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8884         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8885         "parser_state" with "expr_builder".
8886
8887 2019-04-04  Tom Tromey  <tom@tromey.com>
8888
8889         * rust-exp.y: Replace "parse_language" with method call.
8890         * p-exp.y:
8891         (yylex): Replace "parse_language" with method call.
8892         * m2-exp.y:
8893         (yylex): Replace "parse_language" with method call.
8894         * go-exp.y (classify_name): Replace "parse_language" with method
8895         call.
8896         * f-exp.y (yylex): Replace "parse_language" with method call.
8897         * d-exp.y (lex_one_token): Replace "parse_language" with method
8898         call.
8899         * c-exp.y:
8900         (lex_one_token, classify_name, yylex): Replace "parse_language"
8901         with method call.
8902         * ada-exp.y (find_primitive_type, type_char)
8903         (type_system_address): Replace "parse_language" with method call.
8904
8905 2019-04-04  Tom Tromey  <tom@tromey.com>
8906
8907         * rust-exp.y: Replace "parse_gdbarch" with method call.
8908         * parse.c (write_dollar_variable, insert_type_address_space):
8909         Replace "parse_gdbarch" with method call.
8910         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8911         call.
8912         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8913         call.
8914         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8915         "parse_gdbarch" with method call.
8916         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8917         with method call.
8918         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8919         "parse_gdbarch" with method call.
8920         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8921         "parse_gdbarch" with method call.
8922         * c-exp.y (parse_type, parse_number, classify_name): Replace
8923         "parse_gdbarch" with method call.
8924         * ada-lex.l: Replace "parse_gdbarch" with method call.
8925         * ada-exp.y (parse_type, find_primitive_type, type_char)
8926         (type_system_address): Replace "parse_gdbarch" with method call.
8927
8928 2019-04-04  Tom Tromey  <tom@tromey.com>
8929
8930         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8931         * stap-probe.c (stap_parse_argument): Update.
8932         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8933         initial_size parameter.
8934         * rust-exp.y (rust_lex_tests): Update.
8935         * parse.c (parser_state): Update.
8936         (parse_exp_in_context): Update.
8937         * parser-defs.h (struct parser_state) <parser_state>: Remove
8938         "initial_size" parameter.
8939
8940 2019-04-04  Tom Tromey  <tom@tromey.com>
8941
8942         * parser-defs.h (increase_expout_size): Don't declare.
8943         * parse.c (increase_expout_size): Now static.
8944
8945 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8946
8947         * gnu-nat.c (gnu_nat_target::wait): Fix
8948         target_waitstatus_to_string call.
8949
8950 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8951
8952         * eval.c (evaluate_subexp_standard): Handle internal functions
8953         during Fortran function call handling.
8954
8955 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8956
8957         * NEWS: Mention new internal functions.
8958         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8959         (read_base_type): Use dwarf2_init_complex_target_type.
8960         * value.c (creal_internal_fn): New function.
8961         (cimag_internal_fn): New function.
8962         (_initialize_values): Register new internal functions.
8963
8964 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8965
8966         * infrun.c (stop_all_threads): If debug_infrun, always
8967         trace the wait status after wait_one, using
8968         target_waitstatus_to_string and target_pid_to_str.
8969         (handle_inferior_event): Replace various trace of
8970         wait status kind by a single trace.
8971         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8972         wait status kind image by target_waitstatus_to_string.
8973         * target/waitstatus.c (target_waitstatus_to_string): Fix
8974         obsolete comment.
8975
8976 2019-04-01  Tom Tromey  <tromey@adacore.com>
8977
8978         PR symtab/23331:
8979         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8980
8981 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8982             Pedro Alves  <palves@redhat.com>
8983
8984         * top.c (quit_force): Call 'finalize_values'.
8985         * value.c (finalize_values): New function.
8986         * value.h (finalize_values): Declare.
8987
8988 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8989
8990         * NEWS: Announce $_gdb_major and $_gdb_minor.
8991
8992         * top.c (init_gdb_version_vars): New function.
8993         (gdb_init): Call init_gdb_version_vars.
8994
8995 2019-03-29  Tom Tromey  <tromey@adacore.com>
8996
8997         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8998         help text.  Remove dead code.
8999
9000 2019-03-29  Keith Seitz  <keiths@redhat.com>
9001
9002         From Siddhesh Poyarekar:
9003         * f-lang.h (f77_get_upperbound): Return LONGEST.
9004         (f77_get_lowerbound): Likewise.
9005         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9006         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9007         print them.
9008         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9009         plongest to format print it.
9010         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9011         (f77_get_upperbound): Likewise.
9012         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9013         LOWER_BOUND to LONGEST.
9014         (f77_create_arrayprint_offset_tbl): Likewise.
9015
9016 2019-03-29  Keith Seitz  <keiths@redhat.com>
9017
9018         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9019         %s/pulongest for TYPE_LENGTH instead of %d in format
9020         strings.
9021         * ada-typerint.c (ada_print_type): Likewise.
9022         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9023         * compile/compile-c-support.c (generate_register_struct): Likewise.
9024         * gdbtypes.c (recursive_dump_type): Likewise.
9025         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9026         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9027         instead of %d in format strings.
9028         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9029         to std::min to ULONGEST.
9030         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9031         instead of %d in format strings.
9032         * tracepoint.c (info_scope_command): Likewise.
9033         * typeprint.c (print_offset_data::update)
9034         (print_offset_data::finish): Likewise.
9035         * xtensa-tdep.c (xtensa_store_return_value)
9036         (xtensa_push_dummy_call): Likewise.
9037
9038 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9039
9040         * windows-nat.c (display_selector): Fixed format specifications
9041         for 64-bit Cygwin.
9042
9043 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9044
9045         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9046
9047 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9048
9049         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9050         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9051         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9052         (nios2_linux_init_abi): Install it.
9053
9054 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9055
9056         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9057
9058 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9059
9060         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9061
9062 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9063             Tom Tromey  <tromey@adacore.com>
9064
9065         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9066
9067 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9068
9069         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9070         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9071         method to compute the bounds of range types. Also print "[evaluated]"
9072         if the bounds' values come from a dynamic evaluation.
9073
9074 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9075
9076         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9077         whitespace when pretty printing is on.
9078
9079 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9080
9081         * ppc-linux-nat.c: Add include.
9082
9083 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9084
9085         * NEWS: Mention AArch64 Pointer Authentication.
9086
9087 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9088
9089         * arm-linux-nat.c: Add include.
9090
9091 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9092
9093         * source-cache.c (source_cache::get_source_lines): Re-read
9094         fullname after calling open_source_file.
9095
9096 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9097
9098         * NEWS: Mention TLS support for FreeBSD.
9099
9100 2019-03-25  Tom Tromey  <tromey@adacore.com>
9101
9102         * minsyms.c (BUNCH_SIZE): Update comment.
9103         (~minimal_symbol_reader): Remove old comment.
9104         (compact_minimal_symbols): Update comment.
9105         (minimal_symbol_reader::install): Remove old comment.  Update
9106         other comments.
9107
9108 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9109
9110         * s390-linux-nat.c: Add include.
9111
9112 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9113
9114         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9115         Call linux_get_hwcap.
9116         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9117         Likewise.
9118         (aarch64_linux_get_hwcap): Remove function.
9119         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9120         declaration.
9121         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9122         linux_get_hwcap.
9123         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9124         * linux-tdep.c (linux_get_hwcap): Add function.
9125         (linux_get_hwcap2): Likewise.
9126         * linux-tdep.h (linux_get_hwcap): Add declaration.
9127         (linux_get_hwcap2): Likewise.
9128         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9129         (ppc_linux_get_hwcap2): Likewise.
9130         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9131         linux_get_hwcap.
9132         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9133         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9134         (ppc_linux_nat_target::read_description): Likewise.
9135         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9136         * s390-linux-nat.c: Likewise.
9137         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9138
9139 2019-03-24  Tom Tromey  <tom@tromey.com>
9140
9141         * ada-lang.c (standard_lookup): Simplify initialization.
9142         (ada_lookup_symbol_nonlocal): Simplify return.
9143         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9144         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9145         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9146         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9147         initialization.
9148         * solib.c (solib_global_lookup): Simplify.
9149         * symtab.c (null_block_symbol): Remove.
9150         (symbol_cache_lookup): Simplify returns.
9151         (lookup_language_this): Simplify returns.
9152         (lookup_symbol_aux): Simplify return.
9153         (lookup_local_symbol): Simplify returns.
9154         (lookup_global_symbol_from_objfile): Simplify return.
9155         (lookup_symbol_in_objfile_symtabs)
9156         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9157         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9158         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9159         * cp-namespace.c (cp_lookup_bare_symbol)
9160         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9161         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9162         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9163         (cp_lookup_symbol_via_imports): Simplify initialization.
9164         (find_symbol_in_baseclass): Likewise.
9165         * symtab.h (null_block_symbol): Remove.
9166         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9167         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9168         (d_lookup_symbol_module): Likewise.
9169         (find_symbol_in_baseclass): Simplify initialization.
9170
9171 2019-03-24  Tom Tromey  <tom@tromey.com>
9172
9173         * expression.h: Don't include symtab.h.
9174         (struct block): Forward declare.
9175
9176 2019-03-24  Tom Tromey  <tom@tromey.com>
9177
9178         * c-exp.y (typebase): Remove casts.
9179         * gdbtypes.c (lookup_unsigned_typename, )
9180         (lookup_signed_typename): Remove cast.
9181         * eval.c (parse_to_comma_and_eval): Remove cast.
9182         * parse.c (write_dollar_variable): Remove cast.
9183         * block.h (struct block) <superblock>: Now const.
9184         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9185         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9186         (map_block): Make "block" const.
9187         * symfile.h (struct quick_symbol_functions)
9188         <map_matching_symbols>: Constify block argument to "callback".
9189         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9190         const.
9191         (find_pc_sect_compunit_symtab): Make "b" const.
9192         (find_symbol_at_address): Likewise.
9193         (search_symbols): Likewise.
9194         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9195         (dw2_debug_names_lookup_symbol): Likewise.
9196         (dw2_map_matching_symbols): Update.
9197         * p-valprint.c (pascal_val_print): Remove "block".
9198         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9199         (aux_add_nonlocal_symbols): Make "block" const.
9200         (resolve_subexp): Remove cast.
9201         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9202         const.
9203         (iterate_over_file_blocks): Likewise.
9204         * f-exp.y (%union) <bval>: Remove.
9205         * coffread.c (patch_opaque_types): Make "b" const.
9206         * spu-tdep.c (spu_catch_start): Make "block" const.
9207         * c-valprint.c (print_unpacked_pointer): Remove "block".
9208         * symmisc.c (dump_symtab_1): Make "b" const.
9209         (block_depth): Make "block" const.
9210         * d-exp.y (%union) <bval>: Remove.
9211         * cp-support.h (cp_lookup_rtti_type): Update.
9212         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9213         * psymtab.c (psym_lookup_symbol): Make "block" const.
9214         (maintenance_check_psymtabs): Make "b" const.
9215         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9216         (enumerate_locals, enumerate_args): Update.
9217         * python/py-symtab.c (stpy_global_block): Make "block" const.
9218         (stpy_static_block): Likewise.
9219         * inline-frame.c (block_starting_point_at): Make "new_block"
9220         const.
9221         * block.c (find_block_in_blockvector): Make return type const.
9222         (blockvector_for_pc_sect): Make "b" const.
9223         (find_block_in_blockvector): Make "b" const.
9224
9225 2019-03-23  Tom Tromey  <tom@tromey.com>
9226
9227         * varobj.c (varobj_create): Update.
9228         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9229         * printcmd.c (display_command, do_one_display): Don't reset
9230         innermost_block.
9231         * parser-defs.h (enum innermost_block_tracker_type): Move to
9232         expression.h.
9233         (innermost_block): Update comment.
9234         * parse.c (parse_exp_1): Add tracker_types parameter.
9235         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9236         tracker_types parameter.  Reset innermost_block.
9237         (parse_exp_in_context): Remove.
9238         (parse_expression_for_completion): Update.
9239         * objfiles.c (~objfile): Don't reset expression_context_block or
9240         innermost_block.
9241         * expression.h (enum innermost_block_tracker_type): Move from
9242         parser-defs.h.
9243         (parse_exp_1): Add tracker_types parameter.
9244         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9245         reset innermost_block.
9246
9247 2019-03-23  Tom Tromey  <tom@tromey.com>
9248
9249         * objfiles.h: Include bcache.h.
9250
9251 2019-03-23  Tom Tromey  <tom@tromey.com>
9252
9253         * linespec.c (get_current_search_block): Use
9254         scoped_restore_current_language.
9255         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9256
9257 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9258             Jiong Wang  <jiong.wang@arm.com>
9259
9260         * aarch64-linux-tdep.c
9261         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9262         section.
9263         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9264
9265 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9266             Jiong Wang  <jiong.wang@arm.com>
9267
9268         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9269         instructions.
9270         (aarch64_analyze_prologue_test): Add PACIASP test.
9271         (aarch64_prologue_prev_register): Unmask PC value.
9272
9273 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9274             Jiong Wang  <jiong.wang@arm.com>
9275
9276         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9277         (aarch64_dwarf2_prev_register): Unmask PC value.
9278         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9279         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9280         DW_CFA_AARCH64_negate_ra_state.
9281         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9282
9283 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9284             Jiong Wang  <jiong.wang@arm.com>
9285
9286         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9287         registers.
9288         (aarch64_pseudo_register_name): Likewise.
9289         (aarch64_pseudo_register_type): Likewise.
9290         (aarch64_pseudo_register_reggroup_p): Likewise.
9291         (aarch64_gdbarch_init): Add pauth registers.
9292         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9293         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9294         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9295         (struct gdbarch_tdep): Add regnum for ra_state.
9296
9297 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9298             Jiong Wang  <jiong.wang@arm.com>
9299
9300         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9301
9302 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9303             Jiong Wang  <jiong.wang@arm.com>
9304
9305         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9306         function.
9307         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9308         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9309         (aarch64_gdbarch_init): Add puth registers.
9310         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9311         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9312         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9313
9314 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9315             Jiong Wang  <jiong.wang@arm.com>
9316
9317         * aarch64-linux-nat.c
9318         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9319         * aarch64-linux-tdep.c
9320         (aarch64_linux_core_read_description): Likewise.
9321         (aarch64_linux_get_hwcap): New function.
9322         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9323         (aarch64_linux_get_hwcap): New declaration.
9324
9325 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9326             Jiong Wang  <jiong.wang@arm.com>
9327
9328         * aarch64-linux-nat.c
9329         (aarch64_linux_nat_target::read_description): Add pauth param.
9330         * aarch64-linux-tdep.c
9331         (aarch64_linux_core_read_description): Likewise.
9332         * aarch64-tdep.c (struct target_desc): Add in pauth.
9333         (aarch64_read_description): Add pauth param.
9334         (aarch64_gdbarch_init): Likewise.
9335         * aarch64-tdep.h (aarch64_read_description): Likewise.
9336         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9337         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9338         * features/Makefile: Add new files.
9339         * features/aarch64-pauth.c: New file.
9340         * features/aarch64-pauth.xml: New file.
9341
9342 2019-03-20  Tom Tromey  <tromey@adacore.com>
9343
9344         * infrun.c (handle_inferior_event): Rename from
9345         handle_inferior_event_1.  Create a scoped_value_mark.
9346         (handle_inferior_event): Remove.
9347
9348 2019-03-19  Tom Tromey  <tromey@adacore.com>
9349
9350         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9351         * infrun.h (print_stop_event): Add "displays" parameter.
9352         * infrun.c (print_stop_event): Add "displays" parameter.
9353
9354 2019-03-19  Pedro Alves  <palves@redhat.com>
9355
9356         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9357         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9358         to -1.  Fix TABs vs spaces.
9359         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9360         * tui/tui-out.h (tui_ui_out) Add intro comments.
9361         <m_line, m_start_of_line>: In-class initialize, and add describing
9362         comment.
9363
9364 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9365
9366         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9367         variable names.
9368         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9369
9370 2019-03-18  Pedro Alves  <palves@redhat.com>
9371             Eli Zaretskii <eliz@gnu.org>
9372
9373         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9374         m_line and m_start_of_line.
9375
9376 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9377
9378         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9379         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9380         it returns a newline.  This fixes a regression in TU mode, whereby
9381         the next line is output on the same screen line as the user input.
9382
9383 2019-03-18  Tom Tromey  <tromey@adacore.com>
9384
9385         * minsyms.c (minimal_symbol_reader::install): Remove call to
9386         obstack_blank.
9387
9388 2019-03-18  Pedro Alves  <palves@redhat.com>
9389
9390         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9391         New globals.
9392         (apply_style): New, factored out from ...
9393         (apply_ansi_escape): ... this.  Handle reverse video mode.
9394         (tui_set_reverse_mode): New function.
9395         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9396         * tui/tui-winsource.c (tui_show_source_line): Use
9397         tui_set_reverse_mode instead of setting A_STANDOUT.
9398         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9399         New setter methods.
9400
9401 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9402
9403         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9404         Handle tabs.
9405
9406 2019-03-18  Tom Tromey  <tromey@adacore.com>
9407
9408         * ada-lang.c (empty_array): Add "high" parameter.
9409         (ada_evaluate_subexp): Update.
9410
9411 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9412
9413         * unittests/string_view-selftests.c: Define
9414         _initialize_string_view_selftests unconditionally.
9415
9416 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9417
9418         PR gdb/24350
9419         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9420
9421 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9422
9423         PR gdb/24351
9424         * windows-nat.c (display_selector): Fix format specifiers.
9425
9426 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9427
9428         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9429         tui_refill_source_window instead of tui_refresh_win, to update the
9430         current execution line.  This fixes redisplay of the current line
9431         when stepping through the code with "next" or "step".
9432
9433 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9434
9435         * source-cache.c (source_cache::get_source_lines): Call
9436         find_source_lines to initialize s->nlines.  This fixes vertical
9437         scrolling of TUI source window when the DOWN arrow is pressed.
9438
9439 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9440
9441         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9442         linux-thread-db.c (_initialize_thread_db): Likewise.
9443
9444 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9445
9446         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9447         wclrtoeol in tui_show_source_line".  This reverts changes made in
9448         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9449
9450 2019-03-15  Tom Tromey  <tom@tromey.com>
9451
9452         * symtab.h (struct minimal_symbol): Derive from
9453         general_symbol_info.
9454         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9455         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9456         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9457         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9458         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9459         (MSYMBOL_SEARCH_NAME): Update.
9460         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9461         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9462         * minsyms.c (minimal_symbol_reader::record_full): Update.
9463
9464 2019-03-15  Tom Tromey  <tom@tromey.com>
9465
9466         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9467
9468 2019-03-15  Tom Tromey  <tom@tromey.com>
9469
9470         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9471         unique_xmalloc_ptr.
9472         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9473         Update.
9474         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9475         (build_minimal_symbol_hash_tables)
9476         (minimal_symbol_reader::install): Update.
9477
9478 2019-03-15  Tom Tromey  <tom@tromey.com>
9479
9480         * symtab.c (create_demangled_names_hash): Update.
9481         (symbol_set_names): Update.
9482         * objfiles.h (struct objfile_per_bfd_storage)
9483         <demangled_names_hash>: Now an htab_up.
9484         * objfiles.c (objfile_per_bfd_storage): Simplify.
9485
9486 2019-03-15  Tom Tromey  <tom@tromey.com>
9487
9488         * objfiles.h (struct objfile_per_bfd_storage): Declare
9489         destructor.
9490         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9491         New.
9492         (get_objfile_bfd_data): Use new.  Don't initialize
9493         language_of_main.
9494         (free_objfile_per_bfd_storage): Remove.
9495         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9496
9497 2019-03-15  Tom Tromey  <tom@tromey.com>
9498
9499         * symfile.c (reread_symbols): Update.
9500         * objfiles.c (objfile::objfile): Update.
9501         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9502         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9503         comment.
9504         (minimal_symbol_reader::install): Update.
9505         (terminate_minimal_symbol_table): Remove.
9506         * jit.c (jit_object_close_impl): Update.
9507
9508 2019-03-15  Tom Tromey  <tom@tromey.com>
9509
9510         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9511         initializations.
9512
9513 2019-03-15  Tom Tromey  <tom@tromey.com>
9514
9515         * objfiles.h (struct objfile_per_bfd_storage)
9516         <demangled_hash_languages>: Now a bitset.
9517         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9518         (lookup_minimal_symbol): Update.
9519
9520 2019-03-15  Tom Tromey  <tom@tromey.com>
9521
9522         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9523         Don't return the symbol.
9524         * coffread.c (record_minimal_symbol): Use record_full.
9525
9526 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9527
9528         The MS-Windows port of ncurses fails to switch to a color pair if
9529         one or both of the colors are the implicit default colors.  This
9530         change records the default colors when TUI is initialized, and
9531         then specifies them explicitly when a color pair uses the default
9532         colors.  This allows color styling in TUI mode on MS-Windows.
9533
9534         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9535         ncurses_norm_attr.
9536         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9537         colors in ncurses_norm_attr.
9538         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9539         "none", replace it with the default color recorded in
9540         ncurses_norm_attr.
9541
9542 2019-03-14  Tom Tromey  <tromey@adacore.com>
9543
9544         * source-cache.h (class source_cache) <get_source_lines>: Return
9545         std::string.
9546         * source-cache.c (source_cache::extract_lines): Handle case where
9547         first_pos==npos.  Return std::string.
9548         (source_cache::get_source_lines): Update.
9549
9550 2019-03-14  Tom Tromey  <tromey@adacore.com>
9551
9552         * NEWS: Add item for "style sources" commands.
9553         * source-cache.c (source_cache::get_source_lines): Check
9554         source_styling.
9555         * cli/cli-style.c (source_styling): New global.
9556         (_initialize_cli_style): Add "style sources" commands.
9557         (show_style_sources): New function.
9558         * cli/cli-style.h (source_styling): Declare.
9559
9560 2019-03-14  Pedro Alves  <palves@redhat.com>
9561             Tom Tromey  <tromey@adacore.com>
9562
9563         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9564         * tui/tui-winsource.c (tui_refill_source_window): New function,
9565         from...
9566         (tui_horizontal_source_scroll): ... here.  Move some logic.
9567         * cli/cli-style.c (set_style_enabled): Notify new observable.
9568         * tui/tui-hooks.c (tui_redisplay_source): New function.
9569         (tui_attach_detach_observers): Attach or detach
9570         tui_redisplay_source.
9571         * observable.h (source_styling_changed): New observable.
9572         * observable.c: Define source_styling_changed observable.
9573
9574 2019-03-13  Tom Tromey  <tromey@adacore.com>
9575
9576         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9577         (i386_gnu_nat_target::store_registers): Update.
9578         * target-debug.h (target_debug_print_std_string): New macro.
9579         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9580         * windows-tdep.c (display_one_tib): Update.
9581         * tui/tui-stack.c (tui_make_status_line): Update.
9582         * top.c (print_inferior_quit_action): Update.
9583         * thread.c (thr_try_catch_cmd): Update.
9584         (add_thread_with_info): Update.
9585         (thread_target_id_str): Update.
9586         (thr_try_catch_cmd): Update.
9587         (thread_command): Update.
9588         (thread_find_command): Update.
9589         * record-btrace.c (record_btrace_target::info_record)
9590         (record_btrace_resume_thread, record_btrace_target::resume)
9591         (record_btrace_cancel_resume, record_btrace_step_thread)
9592         (record_btrace_target::wait, record_btrace_target::wait)
9593         (record_btrace_target::wait, record_btrace_target::stop): Update.
9594         * progspace.c (print_program_space): Update.
9595         * process-stratum-target.c
9596         (process_stratum_target::thread_address_space): Update.
9597         * linux-fork.c (linux_fork_mourn_inferior)
9598         (detach_checkpoint_command, info_checkpoints_command)
9599         (linux_fork_context): Update.
9600         (linux_fork_detach): Update.
9601         (class scoped_switch_fork_info): Update.
9602         (delete_checkpoint_command): Update.
9603         * infrun.c (follow_fork_inferior): Update.
9604         (follow_fork_inferior): Update.
9605         (proceed_after_vfork_done): Update.
9606         (handle_vfork_child_exec_or_exit): Update.
9607         (follow_exec): Update.
9608         (displaced_step_prepare_throw): Update.
9609         (displaced_step_restore): Update.
9610         (start_step_over): Update.
9611         (resume_1): Update.
9612         (clear_proceed_status_thread): Update.
9613         (proceed): Update.
9614         (print_target_wait_results): Update.
9615         (do_target_wait): Update.
9616         (context_switch): Update.
9617         (stop_all_threads): Update.
9618         (restart_threads): Update.
9619         (finish_step_over): Update.
9620         (handle_signal_stop): Update.
9621         (switch_back_to_stepped_thread): Update.
9622         (keep_going_pass_signal): Update.
9623         (print_exited_reason): Update.
9624         (normal_stop): Update.
9625         * inferior.c (inferior_pid_to_str): Change return type.
9626         (print_selected_inferior): Update.
9627         (add_inferior): Update.
9628         (detach_inferior): Update.
9629         * dummy-frame.c (fprint_dummy_frames): Update.
9630         * dcache.c (dcache_info_1): Update.
9631         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9632         (btrace_fetch, btrace_clear): Update.
9633         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9634         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9635         type.
9636         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9637         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9638         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9639         * gdbarch.c, gdbarch.h: Rebuild.
9640         * gdbarch.sh (core_pid_to_str): Change return type.
9641         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9642         return type.
9643         (windows_nat_target::pid_to_str): Change return type.
9644         (windows_delete_thread): Update.
9645         (windows_nat_target::attach): Update.
9646         (windows_nat_target::files_info): Update.
9647         * target-delegates.c: Rebuild.
9648         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9649         return type.
9650         (sol_thread_target::pid_to_str): Change return type.
9651         * remote.c (class remote_target) <pid_to_str>: Change return
9652         type.
9653         (remote_target::pid_to_str): Change return type.
9654         (extended_remote_target::attach, remote_target::remote_stop_ns)
9655         (remote_target::remote_notif_remove_queued_reply)
9656         (remote_target::push_stop_reply, remote_target::disable_btrace):
9657         Update.
9658         (extended_remote_target::attach): Update.
9659         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9660         type.
9661         (gdbsim_target::pid_to_str): Change return type.
9662         * ravenscar-thread.c (struct ravenscar_thread_target)
9663         <pid_to_str>: Change return type.
9664         (ravenscar_thread_target::pid_to_str): Change return type.
9665         * procfs.c (class procfs_target) <pid_to_str>: Change return
9666         type.
9667         (procfs_target::pid_to_str): Change return type.
9668         (procfs_target::attach): Update.
9669         (procfs_target::detach): Update.
9670         (procfs_target::fetch_registers): Update.
9671         (procfs_target::store_registers): Update.
9672         (procfs_target::wait): Update.
9673         (procfs_target::files_info): Update.
9674         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9675         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9676         return type.
9677         (nto_procfs_target::pid_to_str): Change return type.
9678         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9679         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9680         return type.
9681         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9682         (exit_lwp): Update.
9683         (attach_proc_task_lwp_callback, get_detach_signal)
9684         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9685         (linux_nat_target::resume, wait_lwp, stop_callback)
9686         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9687         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9688         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9689         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9690         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9691         type.
9692         (inf_ptrace_target::attach): Update.
9693         (inf_ptrace_target::files_info): Update.
9694         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9695         type.
9696         (go32_nat_target::pid_to_str): Change return type.
9697         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9698         (gnu_nat_target::wait): Update.
9699         (gnu_nat_target::wait): Update.
9700         (gnu_nat_target::resume): Update.
9701         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9702         (fbsd_nat_target::wait): Update.
9703         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9704         type.
9705         (darwin_nat_target::attach): Update.
9706         * corelow.c (class core_target) <pid_to_str>: Change return type.
9707         (core_target::pid_to_str): Change return type.
9708         * target.c (normal_pid_to_str): Change return type.
9709         (default_pid_to_str): Likewise.
9710         (target_pid_to_str): Change return type.
9711         (target_translate_tls_address): Update.
9712         (target_announce_detach): Update.
9713         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9714         return type.
9715         (bsd_uthread_target::pid_to_str): Change return type.
9716         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9717         type.
9718         (bsd_kvm_target::pid_to_str): Change return type.
9719         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9720         return type.
9721         (aix_thread_target::pid_to_str): Change return type.
9722         * target.h (struct target_ops) <pid_to_str>: Change return type.
9723         (target_pid_to_str, normal_pid_to_str): Likewise.
9724         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9725         type.
9726         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9727         type.
9728         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9729         return type.
9730         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9731         type.
9732         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9733         type.
9734         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9735         return type.
9736
9737 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9738
9739         * NEWS: Mention that the new default MI version is 3.  Mention
9740         changes to the output of commands and events that deal with
9741         multi-location breakpoints.
9742         * breakpoint.c: Include "mi/mi-out.h".
9743         (print_one_breakpoint): Change output syntax if using MI version
9744         >= 3.
9745         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9746         New.
9747         (mi_multi_location_breakpoint_output_fixed): New.
9748         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9749         (mi_cmd_fix_multi_location_breakpoint_output): New.
9750         (mi_multi_location_breakpoint_output_fixed): New.
9751         * mi/mi-cmds.c (mi_cmds): Register command
9752         -fix-multi-location-breakpoint-output.
9753         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9754         interpreter "mi".
9755
9756 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9757
9758         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9759         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9760         instantiate mi_ui_out based on interpreter name.
9761         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9762         * mi/mi-main.c (mi_load_progress): Likewise.
9763
9764 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9765
9766         * NEWS: Combine separate "New targets" sections for 8.3.
9767
9768 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9769
9770         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9771         (ppcfbsd_init_abi): Install gdbarch
9772         "fetch_tls_load_module_address" and "get_thread_local_address"
9773         methods.
9774
9775 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9776
9777         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9778         (riscv_fbsd_init_abi): Install gdbarch
9779         "fetch_tls_load_module_address" and "get_thread_local_address"
9780         methods.
9781
9782 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9783
9784         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9785         (i386fbsd_init_abi): Install gdbarch
9786         "fetch_tls_load_module_address" and "get_thread_local_address"
9787         methods.
9788
9789 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9790
9791         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9792         (amd64fbsd_init_abi): Install gdbarch
9793         "fetch_tls_load_module_address" and "get_thread_local_address"
9794         methods.
9795
9796 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9797
9798         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9799         (struct fbsd_pspace_data): New type.
9800         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9801         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9802         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9803         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9804         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9805
9806 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9807
9808         * gdbtypes.c (lookup_struct_elt): New function.
9809         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9810         * gdbtypes.h (struct struct_elt): New type.
9811         (lookup_struct_elt): New prototype.
9812
9813 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9814
9815         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9816         remove disabled code block.
9817
9818 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9819
9820         * gdbarch.sh (get_thread_local_address): New method.
9821         * gdbarch.h, gdbarch.c: Regenerate.
9822         * target.c (target_translate_tls_address): Use
9823         gdbarch_get_thread_local_address if present instead of
9824         target::get_thread_local_address.
9825
9826 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9827
9828         * target.h (target::get_thread_local_address): Update comment.
9829
9830 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9831
9832         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9833         objfile->separate_debug_objfile_backlink if not NULL.
9834
9835 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9836
9837         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9838         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9839         (amd64bsd_store_inferior_registers): Likewise.
9840         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9841         Enable segment base registers.
9842         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9843         PT_GETFSBASE and PT_GETGSBASE.
9844         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9845         PT_SETGSBASE.
9846         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9847         segment base registers.
9848         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9849
9850 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9851
9852         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9853         Update calls to i386_target_description to add 'segments'
9854         parameter.
9855         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9856         add segment base registers.
9857         * arch/i386.c (i386_create_target_description): Add 'segments'
9858         parameter to enable segment base registers.
9859         * arch/i386.h (i386_create_target_description): Likewise.
9860         * features/i386/32bit-segments.xml: New file.
9861         * features/i386/32bit-segments.c: Generate.
9862         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9863         call to i386_target_description to add 'segments' parameter.
9864         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9865         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9866         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9867         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9868         if feature is present.
9869         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9870         Add 'segments' parameter to call to i386_target_description.
9871         (i386_target_description): Add 'segments' parameter to enable
9872         segment base registers.
9873         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9874         to call to i386_target_description.
9875         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9876         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9877         Define I386_NUM_REGS.
9878         (i386_target_description): Add 'segments' parameter to enable
9879         segment base registers.
9880
9881 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9882
9883         PR/24325
9884         * source-cache.c: #undef open and close, to avoid unresolved
9885         externals during linking.
9886
9887 2019-03-12  Tom Tromey  <tromey@adacore.com>
9888
9889         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9890         const.  Add initializers.
9891         (_initialize_remote): Don't initialize ptid globals.
9892
9893 2019-03-12  Pedro Alves  <palves@redhat.com>
9894
9895         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9896
9897 2019-03-12  Pedro Alves  <palves@redhat.com>
9898
9899         * cp-name-parser.y (main): Remove unused 'len' variable.
9900
9901 2019-03-12  Tom Tromey  <tromey@adacore.com>
9902
9903         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9904         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9905
9906 2019-03-12  Tom Tromey  <tromey@adacore.com>
9907
9908         * linux-nat.c (iterate_over_lwps): Update.
9909         (stop_callback): Remove parameter.
9910         (stop_wait_callback, detach_callback, resume_set_callback)
9911         (select_singlestep_lwp_callback, set_ignore_sigint)
9912         (status_callback, resumed_callback, resume_clear_callback)
9913         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9914         data parameter.
9915         (linux_nat_target::detach, linux_nat_target::resume)
9916         (linux_stop_and_wait_all_lwps, select_event_lwp)
9917         (linux_nat_filter_event, linux_nat_wait_1)
9918         (linux_nat_target::kill, linux_nat_target::stop)
9919         (linux_nat_target::stop): Update.
9920         (linux_nat_resume_callback): Change type.
9921         (resume_stopped_resumed_lwps, count_events_callback)
9922         (select_event_lwp_callback): Likewise.
9923         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9924         * arm-linux-nat.c (struct update_registers_data): Remove.
9925         (update_registers_callback): Change type.
9926         (arm_linux_insert_hw_breakpoint1): Update.
9927         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9928         parameter.
9929         (x86_linux_dr_set_addr): Update.
9930         (x86_linux_dr_set_control): Update.
9931         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9932         (iterate_over_lwps): Use gdb::function_view.
9933         * nat/aarch64-linux-hw-point.c (struct
9934         aarch64_dr_update_callback_param): Remove.
9935         (debug_reg_change_callback): Change type.
9936         (aarch64_notify_debug_reg_change): Update.
9937         * s390-linux-nat.c (s390_refresh_per_info): Update.
9938
9939 2019-03-11  Tom Tromey  <tromey@adacore.com>
9940
9941         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9942         redundant assignment to "this_cu".
9943
9944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9945
9946         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9947
9948 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9949
9950         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9951         from...
9952         (rank_one_type): ... this.
9953
9954 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9955
9956         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9957         from...
9958         (rank_one_type): ... this.
9959
9960 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9961
9962         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9963         from...
9964         (rank_one_type): ... this.
9965
9966 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9967
9968         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9969         from...
9970         (rank_one_type): ... this.
9971
9972 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9973
9974         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9975         from...
9976         (rank_one_type): ... this.
9977
9978 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9979
9980         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9981         from...
9982         (rank_one_type): ... this.
9983
9984 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9985
9986         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9987         from...
9988         (rank_one_type): ... this.
9989
9990 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9991
9992         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9993         from...
9994         (rank_one_type): ... this.
9995
9996 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9997
9998         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9999         from...
10000         (rank_one_type): ... this.
10001
10002 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10003
10004         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10005         from...
10006         (rank_one_type): ... this.
10007
10008 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10009
10010         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10011         from...
10012         (rank_one_type): ... this.
10013
10014 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10015
10016         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10017         from...
10018         (rank_one_type): ... this.
10019
10020 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10021
10022         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10023         inferior-events' shows the example events.
10024
10025 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10026
10027         Support styling on native MS-Windows console
10028
10029         PR/24315
10030         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10031         on MS-Windows if $TERM is not defined.
10032
10033         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10034
10035         * posix-hdep.c (gdb_console_fputs):
10036         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10037         functions.
10038         * ui-file.h (gdb_console_fputs): Add prototype.
10039
10040         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10041         back to fputs only if the former returns zero.
10042
10043 2019-03-07  Tom Tromey  <tom@tromey.com>
10044
10045         * symmisc.c (print_symbol_bcache_statistics): Update.
10046         (print_objfile_statistics): Update.
10047         * symfile.c (allocate_symtab): Update.
10048         * stabsread.c: Don't include bcache.h.
10049         * psymtab.h (struct psymbol_bcache): Don't declare.
10050         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10051         (psymbol_bcache_init, psymbol_bcache_free)
10052         (psymbol_bcache_get_bcache): Don't declare.
10053         * psymtab.c (struct psymbol_bcache): Remove.
10054         (psymtab_storage::psymtab_storage): Update.
10055         (psymtab_storage::~psymtab_storage): Update.
10056         (psymbol_bcache_init, psymbol_bcache_free)
10057         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10058         (add_psymbol_to_bcache): Update.
10059         (allocate_psymtab): Update.
10060         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10061         macro_cache>: No longer pointers.
10062         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10063         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10064         * macrotab.c (macro_bcache): Update.
10065         * macroexp.c: Don't include bcache.h.
10066         * gdbtypes.c (check_types_worklist): Update.
10067         (types_deeply_equal): Remove TRY/CATCH.  Update.
10068         * elfread.c (elf_symtab_read): Update.
10069         * dwarf2read.c: Don't include bcache.h.
10070         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10071         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10072         (print_bcache_statistics, bcache_memory_used): Don't declare.
10073         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10074         methods.  Rename all data members.
10075         * bcache.c (struct bcache): Move to bcache.h.
10076         (bcache::expand_hash_table): Rename from expand_hash_table.
10077         (bcache): Remove.
10078         (bcache::insert): Rename from bcache_full.
10079         (bcache::compare): Rename from bcache_compare.
10080         (bcache_xmalloc): Remove.
10081         (bcache::~bcache): Rename from bcache_xfree.
10082         (bcache::print_statistics): Rename from print_bcache_statistics.
10083         (bcache::memory_used): Rename from bcache_memory_used.
10084
10085 2019-03-07  Pedro Alves  <palves@redhat.com>
10086
10087         * infrun.c (normal_stop): Also check for
10088         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10089
10090 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10091
10092         * f-lang.c (value_from_host_double): Moved to...
10093         * value.c (value_from_host_double): ...here.
10094         * value.h (value_from_host_double): Declare.
10095         * guile/scm-math.c (vlscm_convert_typed_number): Use
10096         value_from_host_double.
10097         (vlscm_convert_number): Likewise.
10098         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10099         * python/py-value.c (convert_value_from_python): Likewise.
10100
10101 2019-03-06  Tom Tromey  <tom@tromey.com>
10102
10103         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10104
10105 2019-03-06  Tom Tromey  <tom@tromey.com>
10106
10107         * utils.h (free_current_contents): Don't declare.
10108         * utils.c (free_current_contents): Remove.
10109
10110 2019-03-06  Tom Tromey  <tom@tromey.com>
10111
10112         * top.c (quit_force): Update.
10113         * main.c (captured_command_loop): Update.
10114         * common/new-op.c (operator new): Update.
10115         * common/common-exceptions.c (struct catcher)
10116         <save_cleanup_chain>: Remove member.
10117         (exceptions_state_mc_init): Update.
10118         (exception_try_scope_entry): Return nullptr.
10119         (exception_try_scope_exit, exception_rethrow)
10120         (throw_exception_sjlj, throw_exception_cxx): Update.
10121         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10122         (all_cleanups, do_cleanups, discard_cleanups)
10123         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10124         (restore_cleanups, restore_final_cleanups): Don't declare.
10125         (do_final_cleanups): Remove parameter.
10126         * common/cleanups.c (cleanup_chain, make_cleanup)
10127         (make_cleanup_dtor, all_cleanups, do_cleanups)
10128         (discard_my_cleanups, discard_cleanups)
10129         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10130         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10131         (null_cleanup): Remove.
10132         (do_final_cleanups): Remove parameter.
10133
10134 2019-03-06  Tom Tromey  <tom@tromey.com>
10135
10136         * remote.c (remote_target::remote_parse_stop_reply): Use
10137         unique_xmalloc_ptr.
10138
10139 2019-03-06  Tom Tromey  <tom@tromey.com>
10140
10141         * stabsread.c (struct stabs_field_info): Rename from field_info.
10142         <list, fnlist>: Add initializers.
10143         <obstack>: New member.
10144         (read_member_functions, read_struct_fields, read_baseclasses):
10145         Allocate on obstack.  Don't use cleanups.
10146         (read_one_struct_field, read_member_functions, read_struct_fields)
10147         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10148         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10149         (read_struct_type): Update.
10150
10151 2019-03-06  Tom Tromey  <tom@tromey.com>
10152
10153         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10154         * common/filestuff.h (make_cleanup_close): Don't declare.
10155         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10156         Remove.
10157
10158 2019-03-06  Tom Tromey  <tom@tromey.com>
10159
10160         * solib-aix.c: Use make_scope_exit.
10161
10162 2019-03-06  Tom Tromey  <tom@tromey.com>
10163
10164         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10165         Use make_scope_exit.
10166
10167 2019-03-06  Tom Tromey  <tom@tromey.com>
10168
10169         * solib-svr4.c (disable_probes_interface): Remove parameter.
10170         (svr4_handle_solib_event): Use make_scope_exit.
10171
10172 2019-03-06  Tom Tromey  <tom@tromey.com>
10173
10174         * remote.c (struct stop_reply_deleter): Remove.
10175         (stop_reply_up): Update.
10176         (struct stop_reply): Derive from notif_event.  Don't typedef.
10177         <regcache>: Now a std::vector.
10178         (stop_reply_xfree): Remove.
10179         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10180         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10181         (remote_target::discard_pending_stop_replies): Use delete.
10182         (remote_target::remote_parse_stop_reply): Update.
10183         (remote_target::process_stop_reply): Update.
10184         * remote-notif.h (struct notif_event): Add virtual destructor.
10185         Remove "dtr" member.
10186         (struct notif_client) <alloc_event>: Return a unique_ptr.
10187         (notif_event_xfree): Don't declare.
10188         (notif_event_up): New typedef.
10189         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10190         (notif_event_xfree, do_notif_event_xfree): Remove.
10191         (remote_notif_state_xfree): Update.
10192
10193 2019-03-06  Tom Tromey  <tom@tromey.com>
10194
10195         * infrun.c (displaced_step_clear_cleanup): Now a
10196         forward_scope_exit type.
10197         (displaced_step_prepare_throw): Update.
10198         (displaced_step_fixup): Update.
10199
10200 2019-03-06  Tom Tromey  <tom@tromey.com>
10201
10202         * inferior.h (class inferior): Update comment.
10203         * gdbthread.h (class thread_info): Update comment.
10204
10205 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10206             Tom Tromey  <tom@tromey.com>
10207
10208         * stabsread.h (struct stab_section_list): Remove.
10209         (coffstab_build_psymtabs): Update.
10210         * dbxread.c (symbuf_sections): Now a std::vector.
10211         (sect_idx): New global.
10212         (fill_symbuf): Update.
10213         (coffstab_build_psymtabs): Change type of stabsects parameter.
10214         Update.
10215         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10216         std::vector.
10217         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10218         (coff_locate_sections): Update.
10219         (coff_symfile_read): Remove cleanups.  Update.
10220         (init_stringtab): Add storage parameter.
10221         (free_stringtab, free_stringtab_cleanup): Remove.
10222         (init_lineno): Add storage parameter.
10223         (free_linetab, free_linetab_cleanup): Remove.
10224
10225 2019-03-06  Pedro Alves  <palves@redhat.com>
10226
10227         * linux-fork.c (fork_info::clobber_regs): Delete.
10228         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10229         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10230         comment.  Adjust.
10231         (scoped_switch_fork_info::scoped_switch_fork_info)
10232         (checkpoint_command, linux_fork_context): Adjust
10233         fork_save_infrun_state calls.
10234
10235 2019-03-06  Pedro Alves  <palves@redhat.com>
10236
10237         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10238         (inf_has_multiple_threads): Return 'bool' and rewrite using
10239         inferior_info::threads().
10240
10241 2019-03-06  Pedro Alves  <palves@redhat.com>
10242
10243         * linux-fork.c: Include <list>.
10244         (fork_list): Now a std::list instance.
10245         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10246         (forks_exist_p, find_last_fork): Adjust.
10247         (new_fork): Delete.
10248         (one_fork_p): New.
10249         (add_fork): Adjust.
10250         (free_fork): Delete, folded into fork_info::~fork_info().
10251         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10252         Adjust.
10253         (init_fork_list): Delete.
10254         (linux_fork_killall, linux_fork_mourn_inferior)
10255         (linux_fork_detach, info_checkpoints_command): Adjust.
10256         (_initialize_linux_fork): No longer call init_fork_list.
10257
10258 2019-03-06  Pedro Alves  <palves@redhat.com>
10259
10260         * linux-fork.c (new_fork): New, split out of ...
10261         (add_fork): ... this.  Return void.  Move "first fork" special
10262         case from here, to ...
10263         (checkpoint_command): ... here.
10264         * linux-linux.h (add_fork): Return void.
10265
10266 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10267
10268         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10269
10270 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10271             Chris January  <chris.january@arm.com>
10272             David Lecomber  <david.lecomber@arm.com>
10273
10274         * f-exp.y: New token, UNOP_INTRINSIC.
10275         (exp): New pattern using UNOP_INTRINSIC token.
10276         (f77_keywords): Add 'abs' keyword.
10277         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10278         (value_from_host_double): New function.
10279         (evaluate_subexp_f): Support UNOP_ABS.
10280
10281 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10282
10283         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10284         types.
10285
10286 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10287
10288         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10289         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10290         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10291
10292 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10293
10294         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10295
10296 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10297             Chris January  <chris.january@arm.com>
10298
10299         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10300         * f-exp.y: Define 'KIND' token.
10301         (exp): New pattern for KIND expressions.
10302         (ptype): Handle types with a kind extension.
10303         (direct_abs_decl): Extend to spot kind extensions.
10304         (f77_keywords): Add 'kind' to the list.
10305         (push_kind_type): New function.
10306         (convert_to_kind_type): New function.
10307         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10308         * parse.c (operator_length_standard): Likewise.
10309         * parser-defs.h (enum type_pieces): Add tp_kind.
10310         * std-operator.def: Add UNOP_KIND.
10311
10312 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10313
10314         * f-exp.y (f_parse): Set yydebug.
10315
10316 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10317
10318         * f-lang.c (evaluate_subexp_f): New function.
10319         (exp_descriptor_f): New global.
10320         (f_language_defn): Use exp_descriptor_f instead of
10321         exp_descriptor_standard.
10322
10323 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10324
10325         * f-exp.y (struct token): Add comments.
10326         (dot_ops): Remove uppercase versions and the end marker.
10327         (f77_keywords): Likewise.
10328         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10329         entries in the dot_ops array are case insensitive, and use
10330         strncasecmp to compare strings.  Also some whitespace cleanup in
10331         this area.  Similar for the f77_keywords array, except entries in
10332         this list might be case sensitive.
10333
10334 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10335
10336         * f-exp.y (struct f77_boolean_val): Add comments.
10337         (boolean_values): Remove uppercase versions, and end marker.
10338         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10339         and use strncasecmp to achieve case insensitivity.  Additionally,
10340         perform whitespace cleanup around this code.
10341
10342 2019-03-06  Tom Tromey  <tromey@adacore.com>
10343
10344         * remote-sim.c (gdbsim_target_open): Use result of
10345         gdb_argv::release.
10346
10347 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10348         Dirk Schubert  <dirk.schubert@arm.com>
10349         Chris January  <chris.january@arm.com>
10350
10351         * eval.c (evaluate_subexp_standard): Call Fortran argument
10352         wrapping logic.
10353         * f-lang.c (struct value): A value which can be passed into a
10354         Fortran function call.
10355         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10356         where appropriate.
10357         (struct type): Value ready for a Fortran function call.
10358         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10359         is needed.
10360         * f-lang.h (fortran_argument_convert): Declaration.
10361         (fortran_preserve_arg_pointer): Declaration.
10362         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10363
10364 2019-03-05  Tom Tromey  <tromey@adacore.com>
10365
10366         * python/py-prettyprint.c (print_string_repr): Remove #if.
10367         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10368
10369 2019-03-05  Tom Tromey  <tromey@adacore.com>
10370
10371         * target.c (the_dummy_target): Move later.  Change type to
10372         "dummy_target".
10373         (initialize_targets): Don't initialize the_dummy_target.
10374
10375 2019-03-05  Tom Tromey  <tromey@adacore.com>
10376
10377         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10378         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10379
10380 2019-03-05  Tom Tromey  <tromey@adacore.com>
10381
10382         * windows-nat.c (windows_nat_target::attach)
10383         (windows_nat_target::detach): Don't call gdb_flush.
10384         * valprint.c (generic_val_print, val_print, val_print_string):
10385         Don't call gdb_flush.
10386         * utils.c (defaulted_query): Don't call gdb_flush.
10387         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10388         * target.c (target_announce_detach): Don't call gdb_flush.
10389         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10390         * remote.c (extended_remote_target::attach): Don't call
10391         gdb_flush.
10392         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10393         * printcmd.c (do_examine): Don't call gdb_flush.
10394         (info_display_command): Don't call gdb_flush.
10395         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10396         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10397         * memattr.c (info_mem_command): Don't call gdb_flush.
10398         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10399         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10400         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10401         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10402         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10403         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10404         (gnu_nat_target::detach): Don't call gdb_flush.
10405         * f-valprint.c (f_val_print): Don't call gdb_flush.
10406         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10407         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10408         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10409         gdb_flush.
10410         * c-valprint.c (c_val_print): Don't call gdb_flush.
10411         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10412
10413 2019-03-05  Tom Tromey  <tromey@adacore.com>
10414
10415         * varobj.c (update_dynamic_varobj_children): Update.
10416         (install_default_visualizer): Use reset, not release.
10417         * value.c (set_internalvar): Update.
10418         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10419         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10420         ATTRIBUTE_UNUSED_RESULT.
10421
10422 2019-03-05  Tom Tromey  <tromey@adacore.com>
10423
10424         * remote.c (class scoped_remote_fd) <release>: Add
10425         ATTRIBUTE_UNUSED_RESULT.
10426
10427 2019-03-05  Tom Tromey  <tromey@adacore.com>
10428
10429         * macroexp.c (struct macro_buffer) <release>: Add
10430         ATTRIBUTE_UNUSED_RESULT.
10431
10432 2019-03-05  Tom Tromey  <tromey@adacore.com>
10433
10434         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10435         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10436         ATTRIBUTE_UNUSED_RESULT.
10437
10438 2019-03-05  Tom Tromey  <tromey@adacore.com>
10439
10440         * common/scoped_fd.h (class scoped_fd) <release>: Add
10441         ATTRIBUTE_UNUSED_RESULT.
10442
10443 2019-03-05  Tom Tromey  <tromey@adacore.com>
10444
10445         * parser-defs.h (struct parser_state) <release>: Add
10446         ATTRIBUTE_UNUSED_RESULT.
10447
10448 2019-03-05  Tom Tromey  <tromey@adacore.com>
10449
10450         * utils.h (class gdb_argv) <release>: Add
10451         ATTRIBUTE_UNUSED_RESULT.
10452         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10453
10454 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10455
10456         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10457         for-loop range, to avoid compiler warnings.
10458
10459         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10460         avoid compiler warnings about unused variables.
10461
10462         * NEWS: Mention end of support for native debugging on MS-Windows
10463         before XP.
10464
10465         PR gdb/24292
10466         * common/netstuff.c:
10467         * gdbserver/gdbreplay.c
10468         * gdbserver/remote-utils.c:
10469         * ser-tcp.c:
10470         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10471         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10472         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10473         'getaddrinfo' and 'freeaddrinfo' were not available before
10474         Windows XP, and mingw.org's MinGW headers by default define
10475         _WIN32_WINNT to 0x500.
10476
10477 2019-03-01  Gary Benson <gbenson@redhat.com>
10478
10479         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10480
10481 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10482             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10483
10484         PR gdb/8527
10485         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10486         set_sigint_trap, clear_sigint_trap.
10487
10488 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10489
10490         * target.c (target_detach): Clear the regcache and the
10491         frame cache.
10492
10493 2019-02-27  Pedro Alves  <palves@redhat.com>
10494
10495         * utils.c (set_screen_size): When we cap the height/width sizes,
10496         tweak the corresponding command variable to show "unlimited":
10497
10498 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10499             Pedro Alves  <palves@redhat.com>
10500
10501         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10502         before calling rl_set_screen_size.
10503
10504 2019-02-27  Tom Tromey  <tromey@adacore.com>
10505
10506         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10507         define.
10508         * python/py-value.c: Remove Python 2.4 workaround.
10509         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10510         workaround.
10511         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10512         Python 2.4 workaround.
10513         * python/python-internal.h: Remove Python 2.4 comment.
10514         (Py_ssize_t): Don't define.
10515         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10516         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10517         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10518         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10519         * python/python.c (do_start_initialization): Remove Python 2.4
10520         workaround.
10521         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10522         (print_children): Remove Python 2.4 workaround.
10523         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10524         workaround.
10525         (CHARBUFFERPROC_NAME): Remove.
10526         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10527         Python 2.4 workaround.
10528
10529 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10530
10531         * NEWS: Note minimum Python version.
10532
10533 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10534
10535         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10536         code from these functions.  Remove corresponding ifdefs.  Use
10537         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10538         Remove gotos and target of gotos.
10539         (infpy_search_memory): Likewise.
10540
10541 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10542
10543         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10544         (hppa_gdbarch_init): Don't register deleted functions with
10545         gdbarch.
10546
10547 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10548
10549         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10550         (h8300_unwind_sp): Delete.
10551         (h8300_dummy_id): Delete.
10552         (h8300_gdbarch_init): Don't register deleted functions with
10553         gdbarch.
10554
10555 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10556
10557         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10558         (ft32_unwind_pc): Delete.
10559         (ft32_unwind_sp): Delete.
10560         (ft32_gdbarch_init): Don't register deleted functions with
10561         gdbarch.
10562
10563 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10564
10565         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10566         (frv_unwind_pc): Delete.
10567         (frv_unwind_sp): Delete.
10568         (frv_gdbarch_init): Don't register deleted functions with
10569         gdbarch.
10570
10571 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10572
10573         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10574         (riscv_unwind_pc): Delete.
10575         (riscv_unwind_sp): Delete.
10576         (riscv_gdbarch_init): Don't register deleted functions with
10577         gdbarch.
10578
10579 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10580
10581         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10582         (csky_unwind_pc): Delete.
10583         (csky_unwind_sp): Delete.
10584         (csky_gdbarch_init): Don't register deleted functions with
10585         gdbarch.
10586
10587 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10588
10589         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10590         (cris_unwind_pc): Delete.
10591         (cris_unwind_sp): Delete.
10592         (cris_gdbarch_init): Don't register deleted functions with
10593         gdbarch.
10594
10595 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10596
10597         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10598         (bfin_unwind_pc): Delete.
10599         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10600
10601 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10602
10603         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10604         (arm_unwind_pc): Delete.
10605         (arm_unwind_sp): Delete.
10606         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10607
10608 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10609
10610         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10611         (arc_unwind_pc): Delete.
10612         (arc_unwind_sp): Delete.
10613         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10614
10615 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10616
10617         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10618         (alpha_unwind_pc): Delete.
10619         (alpha_gdbarch_init): Don't register deleted functions with
10620         gdbarch.
10621
10622 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10623
10624         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10625         (aarch64_unwind_pc): Delete.
10626         (aarch64_unwind_sp): Delete.
10627         (aarch64_gdbarch_init): Don't register deleted functions with
10628         gdbarch.
10629
10630 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10631
10632         * gdbtypes.c (type_align): Don't consider static members when
10633         computing structure alignment.
10634
10635 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10636
10637         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10638         return 0 for other types.
10639         * arch-utils.c (default_type_align): Always return 0.
10640         * gdbarch.h: Regenerate.
10641         * gdbarch.sh (type_align): Extend comment.
10642         * gdbtypes.c (type_align): Add additional comments, always call
10643         gdbarch_type_align before applying the default rules.
10644         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10645         generic code will then apply a suitable default.
10646         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10647         types, return 0 for other types.
10648
10649 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10650
10651         * NEWS: Create a new section for the next release branch.
10652         Rename the section of the current branch, now that it has
10653         been cut.
10654
10655 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10656
10657         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10658         * version.in: Bump version to 8.3.50.DATE-git.
10659
10660 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10661
10662         * aix-thread.c (ptid_cmp): Remove unused variable.
10663         (get_signaled_thread): Likewise.
10664         (store_regs_user_thread): Likewise.
10665         (store_regs_kernel_thread): Likewise.
10666         (fetch_regs_kernel_thread): Remove shadowed variable.
10667
10668 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10669
10670         * features/riscv/32bit-cpu.xml: Add register numbers.
10671         * features/riscv/32bit-fpu.c: Regenerate.
10672         * features/riscv/32bit-fpu.xml: Add register numbers.
10673         * features/riscv/64bit-cpu.xml: Add register numbers.
10674         * features/riscv/64bit-fpu.c: Regenerate.
10675         * features/riscv/64bit-fpu.xml: Add register numbers.
10676
10677 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10678
10679         * NEWS: Mention two argument form of gdb.Value constructor.
10680         * python/py-value.c (convert_buffer_and_type_to_value): New
10681         function.
10682         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10683         Add support for handling an optional second argument.  Call
10684         convert_buffer_and_type_to_value as appropriate.
10685         * python/python-internal.h (Py_buffer_deleter): New struct.
10686         (Py_buffer_up): New typedef.
10687
10688 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10689
10690         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10691         instead of releasing ownership.
10692
10693 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10694
10695         * dwarf2read.c (open_and_init_dwp_file): Call
10696         elf_numsections instead of bfd_count_sections to initialize
10697         dwp_file->num_sections.
10698
10699 2019-02-25  Tom Tromey  <tromey@adacore.com>
10700
10701         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10702
10703 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10704
10705         * gcore.in: Add '--readnever' option when invoking GDB.
10706
10707 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10708
10709         * MAINTAINERS: Update my email address.
10710
10711 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10712
10713         * build-id.c (build_id_to_debug_bfd_1): New function.
10714         (build_id_to_debug_bfd): Look for separate debug file in
10715         sysroot.
10716
10717 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10718
10719         * gdbarch.sh: Update the copyright year range that is placed into
10720         generated files.
10721
10722 2019-02-22  Keith Seitz  <keiths@redhat.com>
10723
10724         PR symtab/23853
10725         * linespec.c (create_sals_line_offset): Search for the default
10726         symtab's filename instead of its fullname.
10727
10728 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10729
10730         * NEWS: Update style defaults.
10731
10732 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10733
10734         * main.c (captured_main_1): Disable styling in batch mode.
10735
10736 2019-02-20  Tom Tromey  <tom@tromey.com>
10737
10738         * symtab.c (symtab_symbol_info): Fix typos.
10739
10740 2019-02-20  Tom Tromey  <tromey@adacore.com>
10741
10742         * findcmd.c (_initialize_mem_search): Use upper case for
10743         metasyntactic variables.
10744
10745 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10746
10747         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10748         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10749
10750 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10751
10752         * top.h (source_file_name): Change to std::string.
10753         * top.c (source_file_name): Likewise.
10754         (command_line_input): Adjust.
10755         * cli/cli-script.c (script_from_file): Adjust.
10756
10757 2019-02-19  Tom Tromey  <tromey@adacore.com>
10758
10759         * ravenscar-thread.c
10760         (ravenscar_thread_target::update_thread_list): Don't call
10761         ada_build_task_list.
10762         * ada-lang.h (ada_build_task_list): Don't declare.
10763         * ada-tasks.c (struct ada_tasks_inferior_data)
10764         <task_list_valid_p>: Now bool.
10765         (read_known_tasks, ada_task_list_changed)
10766         (ada_tasks_invalidate_inferior_data): Update.
10767         (read_known_tasks_array): Return bool.
10768         (read_known_tasks_list): Likewise.
10769         (read_known_tasks): Return void.
10770         (ada_build_task_list): Now static.
10771
10772 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10773
10774         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10775         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10776
10777 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10778
10779         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10780         variant for ada_tasks_pspace_data_handle and
10781         ada_tasks_inferior_data_handle.
10782         (ada_tasks_pspace_data_cleanup): New function.
10783         (ada_tasks_inferior_data_cleanup): New function.
10784
10785 2019-02-17  Tom Tromey  <tom@tromey.com>
10786
10787         * macrotab.h (macro_source_fullname): Return a std::string.
10788         * macrotab.c (macro_include, check_for_redefinition)
10789         (macro_undef, macro_lookup_definition, foreach_macro)
10790         (foreach_macro_in_scope): Update.
10791         (macro_source_fullname): Return a std::string.
10792         * macrocmd.c (show_pp_source_pos): Update.
10793
10794 2019-02-17  Tom Tromey  <tom@tromey.com>
10795
10796         * macrocmd.c (show_pp_source_pos): Style the file names.
10797
10798 2019-02-17  Tom Tromey  <tom@tromey.com>
10799
10800         PR tui/24197:
10801         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10802
10803 2019-02-17  Tom Tromey  <tom@tromey.com>
10804
10805         * ada-lang.c (user_select_syms): Use filtered printing.
10806         * utils.c (wrap_style): New global.
10807         (desired_style): Remove.
10808         (emit_style_escape): Add stream parameter.
10809         (set_output_style, reset_terminal_style, prompt_for_continue):
10810         Update.
10811         (flush_wrap_buffer): Only flush gdb_stdout.
10812         (wrap_here): Set wrap_style.
10813         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10814         treat escape sequences as a character.  Change when wrap buffer is
10815         flushed.
10816         (fputs_styled): Do not set the output style when the default is
10817         requested.
10818         * ui-style.h (struct ui_file_style) <is_default>: New method.
10819         * source.c (print_source_lines_base): Emit escape sequences in one
10820         piece.
10821
10822 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10823
10824         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10825         integers and enumeration types.
10826
10827 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10828
10829         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10830         instead of lookup_symbol_in_language
10831         (do_exact_match): New function.
10832         (ada_get_symbol_name_matcher): Return do_exact_match when
10833         doing a verbatim match.
10834
10835 2019-02-15  Tom Tromey  <tromey@adacore.com>
10836
10837         * ravenscar-thread.c (ravenscar_thread_target::resume)
10838         (ravenscar_thread_target::wait): Special case wildcard requests.
10839
10840 2019-02-15  Tom Tromey  <tromey@adacore.com>
10841
10842         * ravenscar-thread.c (base_ptid): Remove.
10843         (struct ravenscar_thread_target) <close>: New method.
10844         <m_base_ptid>: New member.
10845         <update_inferior_ptid, active_task, task_is_currently_active,
10846         runtime_initialized>: Declare methods.
10847         <ravenscar_thread_target>: Add constructor.
10848         (ravenscar_thread_target::task_is_currently_active)
10849         (ravenscar_thread_target::update_inferior_ptid)
10850         (ravenscar_runtime_initialized): Rename.  Now methods.
10851         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10852         (ravenscar_thread_target::update_thread_list): Update.
10853         (ravenscar_thread_target::active_task): Now method.
10854         (ravenscar_thread_target::store_registers)
10855         (ravenscar_thread_target::prepare_to_store)
10856         (ravenscar_thread_target::prepare_to_store)
10857         (ravenscar_thread_target::mourn_inferior): Update.
10858         (ravenscar_inferior_created): Use "new" to create target.
10859         (ravenscar_thread_target::get_ada_task_ptid): Update.
10860         (_initialize_ravenscar): Don't initialize base_ptid.
10861         (ravenscar_ops): Remove global.
10862
10863 2019-02-15  Tom Tromey  <tromey@adacore.com>
10864
10865         * target.h (push_target): Declare new overload.
10866         * target.c (push_target): New overload, taking an rvalue reference.
10867         * remote.c (remote_target::open_1): Use push_target overload.
10868         * corelow.c (core_target_open): Use push_target overload.
10869
10870 2019-02-15  Tom Tromey  <tromey@adacore.com>
10871
10872         * ravenscar-thread.c (is_ravenscar_task)
10873         (ravenscar_task_is_currently_active): Return bool.
10874         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10875         (_initialize_ravenscar): Remove "(void)".
10876         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10877         Return bool.
10878
10879 2019-02-15  Tom Tromey  <tromey@adacore.com>
10880
10881         * ravenscar-thread.c (ravenscar_runtime_initializer)
10882         (has_ravenscar_runtime, get_running_thread_id)
10883         (ravenscar_thread_target::resume): Fix indentation.
10884
10885 2019-02-15  Tom Tromey  <tromey@adacore.com>
10886
10887         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10888         from ravenscar_arch_ops.
10889         (sparc_ravenscar_ops::fetch_registers)
10890         (sparc_ravenscar_ops::store_registers): Now methods.
10891         (sparc_ravenscar_prepare_to_store): Remove.
10892         (sparc_ravenscar_ops): Redefine.
10893         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10894         methods and destructor.  Remove members.
10895         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10896         (ravenscar_thread_target::store_registers)
10897         (ravenscar_thread_target::prepare_to_store): Update.
10898         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10899         Remove.
10900         (struct ppc_ravenscar_powerpc_ops): Derive from
10901         ravenscar_arch_ops.
10902         (ppc_ravenscar_powerpc_ops::fetch_registers)
10903         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10904         (ppc_ravenscar_powerpc_ops): Redefine.
10905         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10906         (ppc_ravenscar_e500_ops::fetch_registers)
10907         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10908         (ppc_ravenscar_e500_ops): Redefine.
10909         * aarch64-ravenscar-thread.c
10910         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10911         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10912         (aarch64_ravenscar_fetch_registers)
10913         (aarch64_ravenscar_store_registers): Now methods.
10914         (aarch64_ravenscar_ops): Redefine.
10915
10916 2019-02-15  Tom Tromey  <tromey@adacore.com>
10917
10918         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10919         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10920         (ravenscar_thread_target::stopped_by_watchpoint)
10921         (ravenscar_thread_target::stopped_data_address)
10922         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10923
10924 2019-02-15  Tom Tromey  <tromey@adacore.com>
10925
10926         * ravenscar-thread.c: Fix some typos.
10927
10928 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10929             Tom Tromey  <tromey@adacore.com>
10930
10931         * ada-lang.c (ada_exception_sal): Change addr_string to a
10932         std::string.
10933         (create_ada_exception_catchpoint): Update.
10934
10935 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10936             Tom Tromey  <tromey@adacore.com>
10937
10938         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10939         (bp_location_ops): Remove.
10940         (base_breakpoint_allocate_location): Update.
10941         (free_bp_location): Update.
10942         * ada-lang.c (class ada_catchpoint_location)
10943         <ada_catchpoint_location>: Remove ops parameter.
10944         (ada_catchpoint_location_dtor): Remove.
10945         (ada_catchpoint_location_ops): Remove.
10946         (allocate_location_exception): Update.
10947         * breakpoint.h (struct bp_location_ops): Remove.
10948         (class bp_location) <bp_location>: Remove bp_location_ops
10949         parameter.
10950         <~bp_location>: Add destructor.
10951         <ops>: Remove.
10952
10953 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10954             Pedro Alves  <palves@redhat.com>
10955
10956         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10957         'PATH_MAX'.
10958
10959 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10960             Samuel Thibault  <samuel.thibault@gnu.org>
10961             Thomas Schwinge  <thomas@codesourcery.com>
10962
10963         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10964         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10965
10966 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10967
10968         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10969         (check_empty): Use "const char *".
10970
10971         * gnu-nat.c (gnu_nat_target::detach): Instead of
10972         'detach_inferior (pid)' call
10973         'detach_inferior (find_inferior_pid (pid))'.
10974
10975         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10976         'nat/fork-inferior.o'.
10977         * gnu-nat.c: #include "nat/fork-inferior.h".
10978
10979         * gnu-nat.c (gnu_nat_target::detach): Instead of
10980         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10981         * gnu-nat.h: #include "inf-child.h".
10982         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10983         'i386_gnu_nat_target::fetch_registers'.
10984         (gnu_store_registers): Rename/move to
10985         'i386_gnu_nat_target::store_registers'.
10986
10987         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10988         * gnu-nat.h (mach_thread_info): New function.
10989         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10990
10991         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10992
10993 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10994
10995         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10996
10997 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10998
10999         * windows-nat.c (windows_add_thread): Add new parameter
11000         "main_thread_p" with default value set to false.  Update
11001         function documentation as well as all callers.
11002         (windows_delete_thread): Likewise.
11003         (fake_create_process): Update call to windows_add_thread.
11004         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11005         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11006         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11007         call to windows_delete_thread.
11008
11009 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11010
11011         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11012
11013 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11014
11015         * symfile.c (find_separate_debug_file): Use canonical path of
11016         sysroot with child_path instead of gdb_sysroot if it is valid.
11017
11018 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11019
11020         * symfile.c (find_separate_debug_file): Use child_path to
11021         determine if an object file is under a sysroot.
11022
11023 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11024
11025         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11026         unittests/child-path-selftests.c.
11027         * common/pathstuff.c (child_path): New function.
11028         * common/pathstuff.h (child_path): New prototype.
11029         * unittests/child-path-selftests.c: New file.
11030
11031 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11032
11033         * symfile.c (find_separate_debug_file): Look for separate debug
11034         files in debug directories under the sysroot.
11035
11036 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11037
11038         * symtab.h (struct minimal_symbol data_p): New const method.
11039         (struct minimal_symbol text_p): Likewise.
11040         * symtab.c (output_source_filename): Use file name style
11041         to print file name.
11042         (print_symbol_info): Likewise.
11043         (print_msymbol_info): Use address style to print addresses.
11044         Use function name style to print executable text symbols.
11045         (expand_symtab_containing_pc): Use data_p.
11046         (find_pc_sect_compunit_symtab): Likewise.
11047
11048 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11049
11050         * breakpoint.c (describe_other_breakpoints): Use address style
11051         to print addresses.
11052         (say_where): Likewise.
11053
11054 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11055
11056         * ada-typeprint.c (print_func_type): Print function name
11057         style to print function name.
11058         * c-typeprint.c (c_print_type_1): Likewise.
11059
11060 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11061
11062         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11063         for execve.
11064
11065 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11066
11067         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11068         type_stack.
11069
11070 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11071
11072         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11073         TYPE_CODE_REF types.
11074
11075 2019-02-08  Jim Wilson  <jimw@sifive.com>
11076
11077         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11078         (riscv_linux_fregset): New.
11079         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11080
11081 2019-02-07  Tom Tromey  <tom@tromey.com>
11082
11083         * thread.c (thread_cancel_execution_command): Update.
11084         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11085         methods.
11086         (struct thread_fsm_ops): Remove.
11087         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11088         (thread_fsm_should_stop, thread_fsm_return_value)
11089         (thread_fsm_set_finished, thread_fsm_finished_p)
11090         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11091         Don't declare.
11092         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11093         * infrun.c (clear_proceed_status_thread)
11094         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11095         (print_stop_event): Update.
11096         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11097         Add constructor.
11098         (step_command_fsm_ops): Remove.
11099         (new_step_command_fsm): Remove.
11100         (step_1): Update.
11101         (step_command_fsm::should_stop): Rename from
11102         step_command_fsm_should_stop.
11103         (step_command_fsm::clean_up): Rename from
11104         step_command_fsm_clean_up.
11105         (step_command_fsm::do_async_reply_reason): Rename from
11106         step_command_fsm_async_reply_reason.
11107         (struct until_next_fsm): Inherit from thread_fsm.  Add
11108         constructor.
11109         (until_next_fsm_ops): Remove.
11110         (new_until_next_fsm): Remove.
11111         (until_next_fsm::should_stop): Rename from
11112         until_next_fsm_should_stop.
11113         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11114         (until_next_fsm::do_async_reply_reason): Rename from
11115         until_next_fsm_async_reply_reason.
11116         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11117         constructor.  Change type of breakpoint.
11118         (finish_command_fsm_ops): Remove.
11119         (new_finish_command_fsm): Remove.
11120         (finish_command_fsm::should_stop): Rename from
11121         finish_command_fsm_should_stop.
11122         (finish_command_fsm::clean_up): Rename from
11123         finish_command_fsm_clean_up.
11124         (finish_command_fsm::return_value): Rename from
11125         finish_command_fsm_return_value.
11126         (finish_command_fsm::do_async_reply_reason): Rename from
11127         finish_command_fsm_async_reply_reason.
11128         (finish_command): Update.
11129         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11130         Add constructor.
11131         (call_thread_fsm_ops): Remove.
11132         (call_thread_fsm::call_thread_fsm): Rename from
11133         new_call_thread_fsm.
11134         (call_thread_fsm::should_stop): Rename from
11135         call_thread_fsm_should_stop.
11136         (call_thread_fsm::should_notify_stop): Rename from
11137         call_thread_fsm_should_notify_stop.
11138         (run_inferior_call, call_function_by_hand_dummy): Update.
11139         * cli/cli-interp.c (should_print_stop_to_console): Update.
11140         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11141         Add constructor.  Change type of location_breakpoint,
11142         caller_breakpoint.
11143         (until_break_fsm_ops): Remove.
11144         (new_until_break_fsm): Remove.
11145         (until_break_fsm::should_stop): Rename from
11146         until_break_fsm_should_stop.
11147         (until_break_fsm::clean_up): Rename from
11148         until_break_fsm_clean_up.
11149         (until_break_fsm::do_async_reply_reason): Rename from
11150         until_break_fsm_async_reply_reason.
11151         (until_break_command): Update.
11152         * thread-fsm.c: Remove.
11153         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11154
11155 2019-02-07  Tom Tromey  <tom@tromey.com>
11156
11157         * yy-remap.h: Add include guard.
11158         * xtensa-tdep.h: Add include guard.
11159         * xcoffread.h: Rename include guard.
11160         * varobj-iter.h: Add include guard.
11161         * tui/tui.h: Rename include guard.
11162         * tui/tui-winsource.h: Rename include guard.
11163         * tui/tui-wingeneral.h: Rename include guard.
11164         * tui/tui-windata.h: Rename include guard.
11165         * tui/tui-win.h: Rename include guard.
11166         * tui/tui-stack.h: Rename include guard.
11167         * tui/tui-source.h: Rename include guard.
11168         * tui/tui-regs.h: Rename include guard.
11169         * tui/tui-out.h: Rename include guard.
11170         * tui/tui-layout.h: Rename include guard.
11171         * tui/tui-io.h: Rename include guard.
11172         * tui/tui-hooks.h: Rename include guard.
11173         * tui/tui-file.h: Rename include guard.
11174         * tui/tui-disasm.h: Rename include guard.
11175         * tui/tui-data.h: Rename include guard.
11176         * tui/tui-command.h: Rename include guard.
11177         * tic6x-tdep.h: Add include guard.
11178         * target/waitstatus.h: Rename include guard.
11179         * target/wait.h: Rename include guard.
11180         * target/target.h: Rename include guard.
11181         * target/resume.h: Rename include guard.
11182         * target-float.h: Rename include guard.
11183         * stabsread.h: Add include guard.
11184         * rs6000-tdep.h: Add include guard.
11185         * riscv-fbsd-tdep.h: Add include guard.
11186         * regformats/regdef.h: Rename include guard.
11187         * record.h: Rename include guard.
11188         * python/python.h: Rename include guard.
11189         * python/python-internal.h: Rename include guard.
11190         * python/py-stopevent.h: Rename include guard.
11191         * python/py-ref.h: Rename include guard.
11192         * python/py-record.h: Rename include guard.
11193         * python/py-record-full.h: Rename include guard.
11194         * python/py-record-btrace.h: Rename include guard.
11195         * python/py-instruction.h: Rename include guard.
11196         * python/py-events.h: Rename include guard.
11197         * python/py-event.h: Rename include guard.
11198         * procfs.h: Add include guard.
11199         * proc-utils.h: Add include guard.
11200         * p-lang.h: Add include guard.
11201         * or1k-tdep.h: Rename include guard.
11202         * observable.h: Rename include guard.
11203         * nto-tdep.h: Rename include guard.
11204         * nat/x86-linux.h: Rename include guard.
11205         * nat/x86-linux-dregs.h: Rename include guard.
11206         * nat/x86-gcc-cpuid.h: Add include guard.
11207         * nat/x86-dregs.h: Rename include guard.
11208         * nat/x86-cpuid.h: Rename include guard.
11209         * nat/ppc-linux.h: Rename include guard.
11210         * nat/mips-linux-watch.h: Rename include guard.
11211         * nat/linux-waitpid.h: Rename include guard.
11212         * nat/linux-ptrace.h: Rename include guard.
11213         * nat/linux-procfs.h: Rename include guard.
11214         * nat/linux-osdata.h: Rename include guard.
11215         * nat/linux-nat.h: Rename include guard.
11216         * nat/linux-namespaces.h: Rename include guard.
11217         * nat/linux-btrace.h: Rename include guard.
11218         * nat/glibc_thread_db.h: Rename include guard.
11219         * nat/gdb_thread_db.h: Rename include guard.
11220         * nat/gdb_ptrace.h: Rename include guard.
11221         * nat/fork-inferior.h: Rename include guard.
11222         * nat/amd64-linux-siginfo.h: Rename include guard.
11223         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11224         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11225         * nat/aarch64-linux.h: Rename include guard.
11226         * nat/aarch64-linux-hw-point.h: Rename include guard.
11227         * mn10300-tdep.h: Add include guard.
11228         * mips-linux-tdep.h: Add include guard.
11229         * mi/mi-parse.h: Rename include guard.
11230         * mi/mi-out.h: Rename include guard.
11231         * mi/mi-main.h: Rename include guard.
11232         * mi/mi-interp.h: Rename include guard.
11233         * mi/mi-getopt.h: Rename include guard.
11234         * mi/mi-console.h: Rename include guard.
11235         * mi/mi-common.h: Rename include guard.
11236         * mi/mi-cmds.h: Rename include guard.
11237         * mi/mi-cmd-break.h: Rename include guard.
11238         * m2-lang.h: Add include guard.
11239         * location.h: Rename include guard.
11240         * linux-record.h: Rename include guard.
11241         * linux-nat.h: Add include guard.
11242         * linux-fork.h: Add include guard.
11243         * i386-darwin-tdep.h: Rename include guard.
11244         * hppa-linux-offsets.h: Add include guard.
11245         * guile/guile.h: Rename include guard.
11246         * guile/guile-internal.h: Rename include guard.
11247         * gnu-nat.h: Rename include guard.
11248         * gdb-stabs.h: Rename include guard.
11249         * frv-tdep.h: Add include guard.
11250         * f-lang.h: Add include guard.
11251         * event-loop.h: Add include guard.
11252         * darwin-nat.h: Rename include guard.
11253         * cp-abi.h: Rename include guard.
11254         * config/sparc/nm-sol2.h: Rename include guard.
11255         * config/nm-nto.h: Rename include guard.
11256         * config/nm-linux.h: Add include guard.
11257         * config/i386/nm-i386gnu.h: Rename include guard.
11258         * config/djgpp/nl_types.h: Rename include guard.
11259         * config/djgpp/langinfo.h: Rename include guard.
11260         * compile/gcc-cp-plugin.h: Add include guard.
11261         * compile/gcc-c-plugin.h: Add include guard.
11262         * compile/compile.h: Rename include guard.
11263         * compile/compile-object-run.h: Rename include guard.
11264         * compile/compile-object-load.h: Rename include guard.
11265         * compile/compile-internal.h: Rename include guard.
11266         * compile/compile-cplus.h: Rename include guard.
11267         * compile/compile-c.h: Rename include guard.
11268         * common/xml-utils.h: Rename include guard.
11269         * common/x86-xstate.h: Rename include guard.
11270         * common/version.h: Rename include guard.
11271         * common/vec.h: Rename include guard.
11272         * common/tdesc.h: Rename include guard.
11273         * common/selftest.h: Rename include guard.
11274         * common/scoped_restore.h: Rename include guard.
11275         * common/scoped_mmap.h: Rename include guard.
11276         * common/scoped_fd.h: Rename include guard.
11277         * common/safe-iterator.h: Rename include guard.
11278         * common/run-time-clock.h: Rename include guard.
11279         * common/refcounted-object.h: Rename include guard.
11280         * common/queue.h: Rename include guard.
11281         * common/ptid.h: Rename include guard.
11282         * common/print-utils.h: Rename include guard.
11283         * common/preprocessor.h: Rename include guard.
11284         * common/pathstuff.h: Rename include guard.
11285         * common/observable.h: Rename include guard.
11286         * common/netstuff.h: Rename include guard.
11287         * common/job-control.h: Rename include guard.
11288         * common/host-defs.h: Rename include guard.
11289         * common/gdb_wait.h: Rename include guard.
11290         * common/gdb_vecs.h: Rename include guard.
11291         * common/gdb_unlinker.h: Rename include guard.
11292         * common/gdb_unique_ptr.h: Rename include guard.
11293         * common/gdb_tilde_expand.h: Rename include guard.
11294         * common/gdb_sys_time.h: Rename include guard.
11295         * common/gdb_string_view.h: Rename include guard.
11296         * common/gdb_splay_tree.h: Rename include guard.
11297         * common/gdb_setjmp.h: Rename include guard.
11298         * common/gdb_ref_ptr.h: Rename include guard.
11299         * common/gdb_optional.h: Rename include guard.
11300         * common/gdb_locale.h: Rename include guard.
11301         * common/gdb_assert.h: Rename include guard.
11302         * common/filtered-iterator.h: Rename include guard.
11303         * common/filestuff.h: Rename include guard.
11304         * common/fileio.h: Rename include guard.
11305         * common/environ.h: Rename include guard.
11306         * common/common-utils.h: Rename include guard.
11307         * common/common-types.h: Rename include guard.
11308         * common/common-regcache.h: Rename include guard.
11309         * common/common-inferior.h: Rename include guard.
11310         * common/common-gdbthread.h: Rename include guard.
11311         * common/common-exceptions.h: Rename include guard.
11312         * common/common-defs.h: Rename include guard.
11313         * common/common-debug.h: Rename include guard.
11314         * common/cleanups.h: Rename include guard.
11315         * common/buffer.h: Rename include guard.
11316         * common/btrace-common.h: Rename include guard.
11317         * common/break-common.h: Rename include guard.
11318         * cli/cli-utils.h: Rename include guard.
11319         * cli/cli-style.h: Rename include guard.
11320         * cli/cli-setshow.h: Rename include guard.
11321         * cli/cli-script.h: Rename include guard.
11322         * cli/cli-interp.h: Rename include guard.
11323         * cli/cli-decode.h: Rename include guard.
11324         * cli/cli-cmds.h: Rename include guard.
11325         * charset-list.h: Add include guard.
11326         * buildsym-legacy.h: Rename include guard.
11327         * bfin-tdep.h: Add include guard.
11328         * ax.h: Rename include guard.
11329         * arm-linux-tdep.h: Add include guard.
11330         * arm-fbsd-tdep.h: Add include guard.
11331         * arch/xtensa.h: Rename include guard.
11332         * arch/tic6x.h: Add include guard.
11333         * arch/i386.h: Add include guard.
11334         * arch/arm.h: Rename include guard.
11335         * arch/arm-linux.h: Rename include guard.
11336         * arch/arm-get-next-pcs.h: Rename include guard.
11337         * arch/amd64.h: Add include guard.
11338         * arch/aarch64-insn.h: Rename include guard.
11339         * arch-utils.h: Rename include guard.
11340         * annotate.h: Add include guard.
11341         * amd64-darwin-tdep.h: Rename include guard.
11342         * aarch64-linux-tdep.h: Add include guard.
11343         * aarch64-fbsd-tdep.h: Add include guard.
11344         * aarch32-linux-nat.h: Add include guard.
11345
11346 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11347
11348         * macrotab.c (macro_define_internal): New function that
11349         factorizes macro_define_object_internal and macro_define_function
11350         code.
11351         (macro_define_object_internal): Use macro_define_internal.
11352         (macro_define_function): Likewise.
11353
11354 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11355
11356         * macrocmd.c (extract_identifier): Return
11357         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11358         callers.
11359
11360 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11361
11362         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11363
11364 2019-02-05  Tom Tromey  <tom@tromey.com>
11365
11366         * target.c (target_stack::unpush): Move assertion earlier.
11367
11368 2019-01-30  Tom Tromey  <tom@tromey.com>
11369
11370         PR python/23615:
11371         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11372         (gdbpy_parse_and_eval): Likewise.
11373         * python/python-internal.h (gdbpy_allow_threads): New class.
11374
11375 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11376
11377         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11378         (aarch64_fbsd_fpregmap): Move earlier.
11379         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11380         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11381         instead of individual calls to trad_frame_set_reg_addr.
11382         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11383         earlier.
11384         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11385         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11386         instead of individual calls to trad_frame_set_reg_addr.
11387
11388 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11389
11390         * CONTRIBUTE: Replace contribution list with wiki link.
11391
11392 2019-01-25  Tom Tromey  <tom@tromey.com>
11393
11394         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11395
11396 2019-01-25  Tom Tromey  <tom@tromey.com>
11397
11398         * xtensa-linux-nat.c: Fix common/ includes.
11399         * xml-support.h: Fix common/ includes.
11400         * xml-support.c: Fix common/ includes.
11401         * x86-linux-nat.c: Fix common/ includes.
11402         * windows-nat.c: Fix common/ includes.
11403         * varobj.h: Fix common/ includes.
11404         * varobj.c: Fix common/ includes.
11405         * value.c: Fix common/ includes.
11406         * valops.c: Fix common/ includes.
11407         * utils.c: Fix common/ includes.
11408         * unittests/xml-utils-selftests.c: Fix common/ includes.
11409         * unittests/utils-selftests.c: Fix common/ includes.
11410         * unittests/unpack-selftests.c: Fix common/ includes.
11411         * unittests/tracepoint-selftests.c: Fix common/ includes.
11412         * unittests/style-selftests.c: Fix common/ includes.
11413         * unittests/string_view-selftests.c: Fix common/ includes.
11414         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11415         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11416         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11417         * unittests/rsp-low-selftests.c: Fix common/ includes.
11418         * unittests/parse-connection-spec-selftests.c: Fix common/
11419         includes.
11420         * unittests/optional-selftests.c: Fix common/ includes.
11421         * unittests/offset-type-selftests.c: Fix common/ includes.
11422         * unittests/observable-selftests.c: Fix common/ includes.
11423         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11424         * unittests/memrange-selftests.c: Fix common/ includes.
11425         * unittests/memory-map-selftests.c: Fix common/ includes.
11426         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11427         * unittests/function-view-selftests.c: Fix common/ includes.
11428         * unittests/environ-selftests.c: Fix common/ includes.
11429         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11430         * unittests/common-utils-selftests.c: Fix common/ includes.
11431         * unittests/cli-utils-selftests.c: Fix common/ includes.
11432         * unittests/array-view-selftests.c: Fix common/ includes.
11433         * ui-file.c: Fix common/ includes.
11434         * tui/tui-io.c: Fix common/ includes.
11435         * tracepoint.h: Fix common/ includes.
11436         * tracepoint.c: Fix common/ includes.
11437         * tracefile-tfile.c: Fix common/ includes.
11438         * top.h: Fix common/ includes.
11439         * top.c: Fix common/ includes.
11440         * thread.c: Fix common/ includes.
11441         * target/waitstatus.h: Fix common/ includes.
11442         * target/waitstatus.c: Fix common/ includes.
11443         * target.h: Fix common/ includes.
11444         * target.c: Fix common/ includes.
11445         * target-memory.c: Fix common/ includes.
11446         * target-descriptions.c: Fix common/ includes.
11447         * symtab.h: Fix common/ includes.
11448         * symfile.c: Fix common/ includes.
11449         * stap-probe.c: Fix common/ includes.
11450         * spu-linux-nat.c: Fix common/ includes.
11451         * sparc-nat.c: Fix common/ includes.
11452         * source.c: Fix common/ includes.
11453         * solib.c: Fix common/ includes.
11454         * solib-target.c: Fix common/ includes.
11455         * ser-unix.c: Fix common/ includes.
11456         * ser-tcp.c: Fix common/ includes.
11457         * ser-pipe.c: Fix common/ includes.
11458         * ser-base.c: Fix common/ includes.
11459         * selftest-arch.c: Fix common/ includes.
11460         * s12z-tdep.c: Fix common/ includes.
11461         * rust-exp.y: Fix common/ includes.
11462         * rs6000-aix-tdep.c: Fix common/ includes.
11463         * riscv-tdep.c: Fix common/ includes.
11464         * remote.c: Fix common/ includes.
11465         * remote-notif.h: Fix common/ includes.
11466         * remote-fileio.h: Fix common/ includes.
11467         * remote-fileio.c: Fix common/ includes.
11468         * regcache.h: Fix common/ includes.
11469         * regcache.c: Fix common/ includes.
11470         * record-btrace.c: Fix common/ includes.
11471         * python/python.c: Fix common/ includes.
11472         * python/py-type.c: Fix common/ includes.
11473         * python/py-inferior.c: Fix common/ includes.
11474         * progspace.h: Fix common/ includes.
11475         * producer.c: Fix common/ includes.
11476         * procfs.c: Fix common/ includes.
11477         * proc-api.c: Fix common/ includes.
11478         * printcmd.c: Fix common/ includes.
11479         * ppc-linux-nat.c: Fix common/ includes.
11480         * parser-defs.h: Fix common/ includes.
11481         * osdata.c: Fix common/ includes.
11482         * obsd-nat.c: Fix common/ includes.
11483         * nat/x86-linux.c: Fix common/ includes.
11484         * nat/x86-linux-dregs.c: Fix common/ includes.
11485         * nat/x86-dregs.h: Fix common/ includes.
11486         * nat/x86-dregs.c: Fix common/ includes.
11487         * nat/ppc-linux.c: Fix common/ includes.
11488         * nat/mips-linux-watch.h: Fix common/ includes.
11489         * nat/mips-linux-watch.c: Fix common/ includes.
11490         * nat/linux-waitpid.c: Fix common/ includes.
11491         * nat/linux-ptrace.h: Fix common/ includes.
11492         * nat/linux-ptrace.c: Fix common/ includes.
11493         * nat/linux-procfs.c: Fix common/ includes.
11494         * nat/linux-personality.c: Fix common/ includes.
11495         * nat/linux-osdata.c: Fix common/ includes.
11496         * nat/linux-namespaces.c: Fix common/ includes.
11497         * nat/linux-btrace.h: Fix common/ includes.
11498         * nat/linux-btrace.c: Fix common/ includes.
11499         * nat/fork-inferior.c: Fix common/ includes.
11500         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11501         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11502         * nat/aarch64-linux.c: Fix common/ includes.
11503         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11504         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11505         * namespace.h: Fix common/ includes.
11506         * mips-linux-tdep.c: Fix common/ includes.
11507         * minsyms.c: Fix common/ includes.
11508         * mi/mi-parse.h: Fix common/ includes.
11509         * mi/mi-main.c: Fix common/ includes.
11510         * mi/mi-cmd-env.c: Fix common/ includes.
11511         * memrange.h: Fix common/ includes.
11512         * memattr.c: Fix common/ includes.
11513         * maint.h: Fix common/ includes.
11514         * maint.c: Fix common/ includes.
11515         * main.c: Fix common/ includes.
11516         * machoread.c: Fix common/ includes.
11517         * location.c: Fix common/ includes.
11518         * linux-thread-db.c: Fix common/ includes.
11519         * linux-nat.c: Fix common/ includes.
11520         * linux-fork.c: Fix common/ includes.
11521         * inline-frame.c: Fix common/ includes.
11522         * infrun.c: Fix common/ includes.
11523         * inflow.c: Fix common/ includes.
11524         * inferior.h: Fix common/ includes.
11525         * inferior.c: Fix common/ includes.
11526         * infcmd.c: Fix common/ includes.
11527         * inf-ptrace.c: Fix common/ includes.
11528         * inf-child.c: Fix common/ includes.
11529         * ia64-linux-nat.c: Fix common/ includes.
11530         * i387-tdep.c: Fix common/ includes.
11531         * i386-tdep.c: Fix common/ includes.
11532         * i386-linux-tdep.c: Fix common/ includes.
11533         * i386-linux-nat.c: Fix common/ includes.
11534         * i386-go32-tdep.c: Fix common/ includes.
11535         * i386-fbsd-tdep.c: Fix common/ includes.
11536         * i386-fbsd-nat.c: Fix common/ includes.
11537         * guile/scm-type.c: Fix common/ includes.
11538         * guile/guile.c: Fix common/ includes.
11539         * go32-nat.c: Fix common/ includes.
11540         * gnu-nat.c: Fix common/ includes.
11541         * gdbthread.h: Fix common/ includes.
11542         * gdbarch-selftests.c: Fix common/ includes.
11543         * gdb_usleep.c: Fix common/ includes.
11544         * gdb_select.h: Fix common/ includes.
11545         * gdb_bfd.c: Fix common/ includes.
11546         * gcore.c: Fix common/ includes.
11547         * fork-child.c: Fix common/ includes.
11548         * findvar.c: Fix common/ includes.
11549         * fbsd-nat.c: Fix common/ includes.
11550         * event-top.c: Fix common/ includes.
11551         * event-loop.c: Fix common/ includes.
11552         * dwarf2read.c: Fix common/ includes.
11553         * dwarf2loc.c: Fix common/ includes.
11554         * dwarf2-frame.c: Fix common/ includes.
11555         * dwarf-index-cache.c: Fix common/ includes.
11556         * dtrace-probe.c: Fix common/ includes.
11557         * disasm-selftests.c: Fix common/ includes.
11558         * defs.h: Fix common/ includes.
11559         * csky-tdep.c: Fix common/ includes.
11560         * cp-valprint.c: Fix common/ includes.
11561         * cp-support.h: Fix common/ includes.
11562         * cp-support.c: Fix common/ includes.
11563         * corelow.c: Fix common/ includes.
11564         * completer.h: Fix common/ includes.
11565         * completer.c: Fix common/ includes.
11566         * compile/compile.c: Fix common/ includes.
11567         * compile/compile-loc2c.c: Fix common/ includes.
11568         * compile/compile-cplus-types.c: Fix common/ includes.
11569         * compile/compile-cplus-symbols.c: Fix common/ includes.
11570         * command.h: Fix common/ includes.
11571         * cli/cli-dump.c: Fix common/ includes.
11572         * cli/cli-cmds.c: Fix common/ includes.
11573         * charset.c: Fix common/ includes.
11574         * build-id.c: Fix common/ includes.
11575         * btrace.h: Fix common/ includes.
11576         * btrace.c: Fix common/ includes.
11577         * breakpoint.h: Fix common/ includes.
11578         * breakpoint.c: Fix common/ includes.
11579         * ax.h:
11580         (enum agent_op): Fix common/ includes.
11581         * ax-general.c (struct aop_map): Fix common/ includes.
11582         * ax-gdb.c: Fix common/ includes.
11583         * auxv.c: Fix common/ includes.
11584         * auto-load.c: Fix common/ includes.
11585         * arm-tdep.c: Fix common/ includes.
11586         * arch/riscv.c: Fix common/ includes.
11587         * arch/ppc-linux-common.c: Fix common/ includes.
11588         * arch/i386.c: Fix common/ includes.
11589         * arch/arm.c: Fix common/ includes.
11590         * arch/arm-linux.c: Fix common/ includes.
11591         * arch/arm-get-next-pcs.c: Fix common/ includes.
11592         * arch/amd64.c: Fix common/ includes.
11593         * arch/aarch64.c: Fix common/ includes.
11594         * arch/aarch64-insn.c: Fix common/ includes.
11595         * arch-utils.c: Fix common/ includes.
11596         * amd64-windows-tdep.c: Fix common/ includes.
11597         * amd64-tdep.c: Fix common/ includes.
11598         * amd64-sol2-tdep.c: Fix common/ includes.
11599         * amd64-obsd-tdep.c: Fix common/ includes.
11600         * amd64-nbsd-tdep.c: Fix common/ includes.
11601         * amd64-linux-tdep.c: Fix common/ includes.
11602         * amd64-linux-nat.c: Fix common/ includes.
11603         * amd64-fbsd-tdep.c: Fix common/ includes.
11604         * amd64-fbsd-nat.c: Fix common/ includes.
11605         * amd64-dicos-tdep.c: Fix common/ includes.
11606         * amd64-darwin-tdep.c: Fix common/ includes.
11607         * agent.c: Fix common/ includes.
11608         * ada-lang.h: Fix common/ includes.
11609         * ada-lang.c: Fix common/ includes.
11610         * aarch64-tdep.c: Fix common/ includes.
11611
11612 2019-01-25  Tom Tromey  <tom@tromey.com>
11613
11614         * common/create-version.sh: Use common/version.h.
11615
11616 2019-01-24  Pedro Alves  <palves@redhat.com>
11617
11618         * infrun.c (signal_stop, signal_print, signal_program)
11619         (signal_catch, signal_pass): Now arrays instead of pointers.
11620         (update_signals_program_target, do_target_resume)
11621         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11622         * linux-nat.c (linux_nat_target::pass_signals)
11623         (linux_nat_target::create_inferior, linux_nat_target::attach):
11624         Adjust.
11625         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11626         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11627         * procfs.c (procfs_target::pass_signals): Adjust.
11628         * record-full.c (record_full_target::resume): Adjust.
11629         * remote.c (remote_target::pass_signals)
11630         (remote_target::program_signals): Adjust.
11631         * target-debug.h (target_debug_print_signals): Now takes a
11632         gdb::array_view as parameter.  Adjust.
11633         * target.h (target_ops) <pass_signals, program_signals>: Replace
11634         pointer and length parameters with gdb::array_view.
11635         (target_pass_signals, target_program_signals): Likewise.
11636         * target-delegates.c: Regenerate.
11637
11638 2019-01-24  Pedro Alves  <palves@redhat.com>
11639
11640         * common/forward-scope-exit.h
11641         (forward_scope_exit::forward_scope_exit): Pass arguments to
11642         m_bind_function directly, instead of creating a std::bind and
11643         copying that.
11644
11645 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11646
11647         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11648         for static members.
11649         (pass_in_v_vfp_candidate): Likewise.
11650
11651 2019-01-23  Tom Tromey  <tom@tromey.com>
11652             Pedro Alves  <palves@redhat.com>
11653
11654         * regcache.c (class regcache_invalidator): Remove.
11655         (regcache::raw_write): Use make_scope_exit.
11656
11657 2019-01-23  Tom Tromey  <tom@tromey.com>
11658
11659         * ui-out.h (class ui_out_emit_type): Update comment.
11660
11661 2019-01-23  Tom Tromey  <tom@tromey.com>
11662
11663         * infrun.c (fetch_inferior_event): Update comment.
11664
11665 2019-01-23  Tom Tromey  <tom@tromey.com>
11666             Pedro Alves  <palves@redhat.com>
11667
11668         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11669         parameter.
11670         (fetch_inferior_event): Use SCOPE_EXIT.
11671
11672
11673 2019-01-23  Tom Tromey  <tom@tromey.com>
11674             Pedro Alves  <palves@redhat.com>
11675
11676         * infrun.c (disable_thread_events): Delete.
11677         (stop_all_threads): Use SCOPE_EXIT.
11678
11679 2019-01-23  Tom Tromey  <tom@tromey.com>
11680             Pedro Alves  <palves@redhat.com>
11681
11682         * symfile.c: Include forward-scope-exit.h.
11683         (clear_symtab_users_cleanup): Replace forward declaration with
11684         a FORWARD_SCOPE_EXIT.
11685         (syms_from_objfile_1): Use the forward_scope_exit and
11686         gdb::optional instead of cleanup_function.
11687         (reread_symbols): Use the forward_scope_exit instead of
11688         cleanup_function.
11689         (clear_symtab_users_cleanup): Remove function.
11690
11691 2019-01-23  Tom Tromey  <tom@tromey.com>
11692             Pedro Alves  <palves@redhat.com>
11693
11694         * linux-nat.c: Include scope-exit.h.
11695         (cleanup_target_stop): Remove.
11696         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11697         SCOPE_EXIT.
11698
11699 2019-01-23  Tom Tromey  <tom@tromey.com>
11700             Pedro Alves  <palves@redhat.com>
11701
11702         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11703         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11704
11705 2019-01-23  Tom Tromey  <tom@tromey.com>
11706             Andrew Burgess  <andrew.burgess@embecosm.com>
11707             Pedro Alves  <palves@redhat.com>
11708
11709         * infrun.c (fetch_inferior_event): Use scope_exit.
11710         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11711         * top.c (execute_command): Use scope_exit.
11712         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11713         * utils.c (do_bpstat_clear_actions_cleanup)
11714         (make_bpstat_clear_actions_cleanup): Remove.
11715
11716 2019-01-23  Tom Tromey  <tom@tromey.com>
11717             Pedro Alves  <palves@redhat.com>
11718
11719         * infrun.c: Include "common/scope-exit.h"
11720         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11721         (wait_for_inferior): Use SCOPE_EXIT.
11722         (fetch_inferior_event): Use scope_exit.
11723
11724 2019-01-23  Tom Tromey  <tom@tromey.com>
11725             Pedro Alves  <palves@redhat.com>
11726
11727         * breakpoint.c (create_breakpoint): Remove cleanup.
11728
11729 2019-01-23  Tom Tromey  <tom@tromey.com>
11730             Andrew Burgess  <andrew.burgess@embecosm.com>
11731             Pedro Alves  <palves@redhat.com>
11732
11733 2019-01-23  Pedro Alves  <palves@redhat.com>
11734
11735         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11736
11737 2019-01-23  Pedro Alves  <palves@redhat.com>
11738             Andrew Burgess  <andrew.burgess@embecosm.com>
11739
11740         * gdbthread.h: Include "common/forward-scope-exit.h".
11741         (scoped_finish_thread_state): Redefine custom class in terms of
11742         forward_scope_exit.
11743
11744 2019-01-23  Pedro Alves  <palves@redhat.com>
11745             Andrew Burgess  <andrew.burgess@embecosm.com>
11746
11747         * common/forward-scope-exit.h: New file.
11748
11749 2019-01-23  Pedro Alves  <palves@redhat.com>
11750             Andrew Burgess  <andrew.burgess@embecosm.com>
11751             Tom Tromey  <tom@tromey.com>
11752
11753         * common/scope-exit.h: New file.
11754
11755 2019-01-23  Pedro Alves  <palves@redhat.com>
11756
11757         * common/preprocessor.h (ESC): Rename to ...
11758         (ESC_PARENS): ... this.
11759         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11760         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11761
11762 2019-01-23  Tom Tromey  <tom@tromey.com>
11763
11764         * language.h (class scoped_switch_to_sym_language_if_auto):
11765         Initialize m_lang in both cases.
11766
11767 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11768
11769         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11770         with XCNEW.
11771
11772 2019-01-22  Tom Tromey  <tom@tromey.com>
11773
11774         * corelow.c: Do not include sys/file.h.
11775
11776 2019-01-22  Tom Tromey  <tom@tromey.com>
11777
11778         * tui/tui-wingeneral.h: Include gdb_curses.h.
11779
11780 2019-01-22  Tom Tromey  <tom@tromey.com>
11781
11782         * source-cache.h (class source_cache) <get_source_lines,
11783         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11784
11785 2019-01-22  Tom Tromey  <tom@tromey.com>
11786
11787         * remote-fileio.h (struct remote_target): Declare.
11788
11789 2019-01-22  Tom Tromey  <tom@tromey.com>
11790
11791         * python/py-arch.c: Do not include py-ref.h.
11792         * python/py-bpevent.c: Do not include py-ref.h.
11793         * python/py-cmd.c: Do not include py-ref.h.
11794         * python/py-continueevent.c: Do not include py-ref.h.
11795         * python/py-event.h: Do not include py-ref.h.
11796         * python/py-evtregistry.c: Do not include py-ref.h.
11797         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11798         * python/py-frame.c: Do not include py-ref.h.
11799         * python/py-framefilter.c: Do not include py-ref.h.
11800         * python/py-function.c: Do not include py-ref.h.
11801         * python/py-infevents.c: Do not include py-ref.h.
11802         * python/py-linetable.c: Do not include py-ref.h.
11803         * python/py-objfile.c: Do not include py-ref.h.
11804         * python/py-param.c: Do not include py-ref.h.
11805         * python/py-prettyprint.c: Do not include py-ref.h.
11806         * python/py-progspace.c: Do not include py-ref.h.
11807         * python/py-symbol.c: Do not include py-ref.h.
11808         * python/py-symtab.c: Do not include py-ref.h.
11809         * python/py-type.c: Do not include py-ref.h.
11810         * python/py-unwind.c: Do not include py-ref.h.
11811         * python/py-utils.c: Do not include py-ref.h.
11812         * python/py-value.c: Do not include py-ref.h.
11813         * python/py-varobj.c: Do not include py-ref.h.
11814         * python/py-xmethods.c: Do not include py-ref.h.
11815         * python/python.c: Do not include py-ref.h.
11816         * varobj.c: Do not include py-ref.h.
11817
11818 2019-01-22  Tom Tromey  <tom@tromey.com>
11819
11820         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11821         keyword for bcache.
11822
11823 2019-01-22  Tom Tromey  <tom@tromey.com>
11824
11825         * compile/compile-cplus-types.c: Remove a comment by #include.
11826
11827 2019-01-22  Tom Tromey  <tom@tromey.com>
11828
11829         * compile/gcc-c-plugin.h: Include compile-internal.h.
11830
11831 2019-01-22  Tom Tromey  <tom@tromey.com>
11832
11833         * stabsread.c (EXTERN): Do not define.
11834         (symnum, next_symbol_text_func, processing_gcc_compilation)
11835         (within_function, global_sym_chain, global_stabs)
11836         (previous_stab_code, this_object_header_files)
11837         (n_this_object_header_files)
11838         (n_allocated_this_object_header_files): Define.
11839         * stabsread.h (EXTERN): Never define.  Use "extern".
11840
11841 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11842
11843         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11844         history_value.
11845
11846 2019-01-21  Tom Tromey  <tom@tromey.com>
11847
11848         * ui-out.c: Fix includes.
11849         * tui/tui-source.c: Fix includes.
11850         * target.c: Fix includes.
11851         * remote.c: Fix includes.
11852         * regcache.c: Fix includes.
11853         * python/py-block.c: Fix includes.
11854         * printcmd.c: Fix includes.
11855         * or1k-tdep.c: Fix includes.
11856         * mi/mi-main.c: Fix includes.
11857         * m32r-tdep.c: Fix includes.
11858         * csky-tdep.c: Fix includes.
11859         * compile/compile-cplus-types.c: Fix includes.
11860         * cli/cli-interp.c: Fix includes.
11861
11862 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11863
11864         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11865         for padding.
11866
11867 2019-01-16  Tom Tromey  <tom@tromey.com>
11868
11869         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11870         earlier.
11871         (struct objfile) <msymbols_range>: Move from top level.
11872         <msymbols>: New method.
11873         (class objfile_msymbols): Remove.
11874         * symtab.c (default_collect_symbol_completion_matches_break_on):
11875         Update.
11876         * symmisc.c (dump_msymbols): Update.
11877         * stabsread.c (scan_file_globals): Update.
11878         * objc-lang.c (info_selectors_command, info_classes_command)
11879         (find_methods): Update.
11880         * minsyms.c (find_solib_trampoline_target): Update.
11881         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11882         * coffread.c (coff_symfile_read): Update.
11883         * ada-lang.c (ada_lookup_simple_minsym)
11884         (ada_collect_symbol_completion_matches): Update.
11885
11886 2019-01-16  Tom Tromey  <tom@tromey.com>
11887
11888         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11889         type.  Remove no-argument constructor.
11890         <iterator::operator++>: Simplify.
11891         <begin>: Update.
11892         <end>: Use minimal_symbol_count.
11893
11894 2019-01-16  Tom Tromey  <tom@tromey.com>
11895
11896         * objfiles.h (struct objfile) <psymtabs>: New method.
11897         (class objfile_psymtabs): Remove.
11898         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11899         typedef.
11900         <range>: New method.
11901         (require_partial_symbols): Change return type.
11902         * psymtab.c (require_partial_symbols)
11903         (psym_expand_symtabs_matching): Update.
11904         * mdebugread.c (parse_partial_symbols): Update.
11905         * dbxread.c (dbx_end_psymtab): Update.
11906
11907 2019-01-15  Tom Tromey  <tom@tromey.com>
11908
11909         * symtab.c (lookup_objfile_from_block)
11910         (lookup_symbol_in_objfile_symtabs)
11911         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11912         (find_line_symtab, info_sources_command)
11913         (default_collect_symbol_completion_matches_break_on)
11914         (make_source_files_completion_list): Update.
11915         * symmisc.c (print_objfile_statistics, dump_objfile)
11916         (maintenance_print_symbols, maintenance_info_symtabs)
11917         (maintenance_check_symtabs, maintenance_info_line_tables):
11918         Update.
11919         * source.c (select_source_symtab)
11920         (forget_cached_source_info_for_objfile): Update.
11921         * objfiles.h (class objfile_compunits): Remove.
11922         (struct objfile) <compunits_range>: New typedef.
11923         (compunits): New method.
11924         * objfiles.c (objfile_relocate1): Update.
11925         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11926         * maint.c (count_symtabs_and_blocks): Update.
11927         * linespec.c (iterate_over_all_matching_symtabs): Update.
11928         * cp-support.c (add_symbol_overload_list_qualified): Update.
11929         * coffread.c (coff_symtab_read): Update.
11930         * ada-lang.c (add_nonlocal_symbols)
11931         (ada_collect_symbol_completion_matches)
11932         (ada_add_global_exceptions): Update.
11933
11934 2019-01-15  Tom Tromey  <tom@tromey.com>
11935
11936         * progspace.h (program_space) <objfiles_safe_range>: New
11937         typedef.
11938         <objfiles_safe>: New method.
11939         * objfiles.h (class all_objfiles_safe): Remove.
11940         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11941         * jit.c (jit_inferior_exit_hook): Update.
11942
11943 2019-01-17  Tom Tromey  <tom@tromey.com>
11944
11945         * progspace.h (program_space) <objfiles_range>: New typedef.
11946         <objfiles>: New method.
11947         <objfiles_head>: Rename from objfiles.
11948         (object_files): Update.
11949         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11950         * guile/scm-pretty-print.c
11951         (ppscm_find_pretty_printer_from_objfiles): Update.
11952         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11953         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11954         Update.
11955         * python/py-progspace.c (pspy_get_objfiles): Update.
11956         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11957         Update.
11958         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11959         (objfpy_lookup_objfile_by_build_id): Update.
11960         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11961         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11962         Update.
11963         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11964         (expand_symtab_containing_pc, lookup_objfile_from_block)
11965         (lookup_static_symbol, basic_lookup_transparent_type)
11966         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11967         (find_line_symtab, info_sources_command)
11968         (default_collect_symbol_completion_matches_break_on)
11969         (make_source_files_completion_list, find_main_name): Update.
11970         * symmisc.c (print_symbol_bcache_statistics)
11971         (print_objfile_statistics, maintenance_print_symbols)
11972         (maintenance_print_msymbols, maintenance_print_objfiles)
11973         (maintenance_info_symtabs, maintenance_check_symtabs)
11974         (maintenance_expand_symtabs, maintenance_info_line_tables):
11975         Update.
11976         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11977         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11978         (map_overlay_command, unmap_overlay_command)
11979         (simple_overlay_update, expand_symtabs_matching)
11980         (map_symbol_filenames): Update.
11981         * symfile-debug.c (set_debug_symfile): Update.
11982         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11983         Update.
11984         * source.c (select_source_symtab, forget_cached_source_info):
11985         Update.
11986         * solib.c (solib_read_symbols): Update.
11987         * solib-spu.c (append_ocl_sos): Update.
11988         * psymtab.c (maintenance_print_psymbols)
11989         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11990         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11991         * printcmd.c (info_symbol_command): Update.
11992         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11993         Update.
11994         * objfiles.h (class all_objfiles): Remove.
11995         * objfiles.c (have_partial_symbols, have_full_symbols)
11996         (have_minimal_symbols, qsort_cmp, update_section_map)
11997         (shared_objfile_contains_address_p)
11998         (default_iterate_over_objfiles_in_search_order): Update.
11999         * objc-lang.c (info_selectors_command, info_classes_command)
12000         (find_methods): Update.
12001         * minsyms.c (find_solib_trampoline_target): Update.
12002         * maint.c (maintenance_info_sections)
12003         (maintenance_translate_address, count_symtabs_and_blocks):
12004         Update.
12005         * main.c (captured_main_1): Update.
12006         * linux-thread-db.c (try_thread_db_load_from_pdir)
12007         (has_libpthread): Update.
12008         * linespec.c (iterate_over_all_matching_symtabs)
12009         (search_minsyms_for_name): Update.
12010         * jit.c (jit_find_objf_with_entry_addr): Update.
12011         * hppa-tdep.c (find_unwind_entry)
12012         (hppa_lookup_stub_minimal_symbol): Update.
12013         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12014         Update.
12015         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12016         (elf_gnu_ifunc_resolve_by_got): Update.
12017         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12018         * dwarf-index-write.c (save_gdb_index_command): Update.
12019         * cp-support.c (add_symbol_overload_list_qualified): Update.
12020         * breakpoint.c (create_overlay_event_breakpoint)
12021         (create_longjmp_master_breakpoint)
12022         (create_std_terminate_master_breakpoint)
12023         (create_exception_master_breakpoint): Update.
12024         * blockframe.c (find_pc_partial_function): Update.
12025         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12026         (ada_collect_symbol_completion_matches)
12027         (ada_add_global_exceptions): Update.
12028
12029 2019-01-17  Tom Tromey  <tom@tromey.com>
12030
12031         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12032         declare VEC.
12033         (solib_target_parse_libraries): Change return type.
12034         (library_list_start_segment, library_list_start_section)
12035         (library_list_end_library, library_list_start_library); Update.
12036         (solib_target_free_library_list): Remove.
12037         (solib_target_parse_libraries): Remove cleanup.  Change return
12038         type.
12039         (solib_target_current_sos): Update.
12040
12041 2019-01-17  Tom Tromey  <tromey@bapiya>
12042
12043         * valprint.c: Replace "the the" with "the".
12044         * symtab.c: Replace "the the" with "the".
12045         * solib.c: Replace "the the" with "the".
12046         * solib-dsbt.c: Replace "the the" with "the".
12047         * linespec.c: Replace "the the" with "the".
12048         * dwarf2loc.h: Replace "the the" with "the".
12049         * amd64-windows-tdep.c: Replace "the the" with "the".
12050         * aarch64-tdep.c: Replace "the the" with "the".
12051
12052 2019-01-16  Keith Seitz  <keiths@redhat.com>
12053
12054         PR gdb/23773
12055         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12056         <builder>: Rename to ..
12057         <m_builder>: ... this and make private.
12058         (dwarf2_cu::get_builder): New method.  Change all users of
12059         `builder' to use this method.
12060         (dwarf2_start_symtab): Move to ...
12061         (dwarf2_cu::start_symtab): ... here.  Update all callers
12062         (setup_type_unit_groups): Move to ...
12063         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12064         callers.
12065         (dwarf2_cu::reset_builder): New method.
12066         (process_full_compunit, process_full_type_unit): Use
12067         dwarf2_cu::reset_builder.
12068         (follow_die_offset): Record the ancestor CU if it is different
12069         from the followed DIE's CU.
12070         (follow_die_sig_1): Likewise.
12071
12072 2019-01-15  Tom Tromey  <tom@tromey.com>
12073
12074         * remote.c (class remote_state) <buf>: Now a char_vector.
12075         <buf_size>: Remove.
12076         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12077         parameter.
12078         (remote_target::getpkt_or_notif_sane_1)
12079         (remote_target::getpkt_sane)
12080         (remote_target::getpkt_or_notif_sane): Likewise.
12081         (class remote_target) <putpkt>: New overload.
12082         (remote_target::read_frame): Change type of "buf_p".  Remove
12083         sizeof_p parameter.
12084         (packet_ok): New overload.
12085         (packet_check_result): New overload.
12086         Update all uses.
12087
12088 2019-01-14  Tom Tromey  <tom@tromey.com>
12089
12090         * remote-notif.c (handle_notification, remote_notif_ack)
12091         (remote_notif_parse): Make "buf" const.
12092         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12093         const.
12094         (remote_notif_parse, remote_notif_ack, handle_notification):
12095         Likewise.
12096         * remote.c (remote_notif_stop_parse): Make "buf" const.
12097         (remote_target::remote_parse_stop_reply): Make "buf" const.
12098         (remote_notif_stop_ack): Make "buf" const.
12099
12100 2019-01-14  Tom Tromey  <tom@tromey.com>
12101
12102         * remote.c (remote_console_output): Make parameter const.
12103
12104 2019-01-14  Tom Tromey  <tom@tromey.com>
12105
12106         * target-debug.h (target_debug_print_signals): Constify.
12107         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12108         * procfs.c (procfs_target::pass_signals): Update.
12109         * linux-nat.c (linux_nat_target::pass_signals): Update.
12110         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12111         * target-delegates.c: Rebuild.
12112         * remote.c (remote_target::program_signals): Update.
12113         (remote_target::pass_signals): Update.
12114         * target.c (target_pass_signals): Constify argument.
12115         (target_program_signals): Likewise.
12116         * target.h (struct target_ops) <pass_signals, program_signals>:
12117         Constify argument.
12118         (target_pass_signals, target_program_signals): Constify argument.
12119
12120 2019-01-14  Tom Tromey  <tom@tromey.com>
12121
12122         PR tui/28819:
12123         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12124
12125 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12126
12127         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12128         field.
12129         * rs6000-tdep.c: Include reggroups.h.
12130         (IS_V_ALIAS_PSEUDOREG): Define.
12131         (rs6000_register_name): Return names for the "vX" aliases.
12132         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12133         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12134         aliases.  Call default_register_reggroup_p for all other
12135         pseudo-registers.
12136         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12137         New functions.
12138         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12139         Handle "vX" aliases.
12140         (v_alias_pseudo_register_collect): New function.
12141         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12142         (rs6000_gdbarch_init): Initialize "vX" aliases as
12143         pseudo-registers.  Restore registration of
12144         rs6000_pseudo_register_reggroup_p with
12145         set_tdesc_pseudo_register_reggroup_p.
12146
12147 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12148
12149         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12150         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12151         set_gdbarch_num_pseudo_regs.
12152
12153 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12154
12155         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12156         Remove arg prefixname, add do_set and do_show.
12157         Add member functions set_list and show_list.
12158         * cli/cli-style.c (class cli_style_option): Update accordingly.
12159         (style_set_list): Move to file scope.
12160         (style_show_list): Likewise.
12161         (set_style): Call help_list.
12162         (show_style): Call cmd_show_list.
12163         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12164         Update to use the new macro.
12165
12166 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12167
12168         * ada-lang.c (_initialize_ada_language): Expand the help text
12169         for the "catch exception" command.
12170
12171 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12172
12173         * symtab.c (matching_obj_sections): Initialize obj,
12174         declare it closer to its usage.
12175
12176 2019-01-10  Tom Tromey  <tom@tromey.com>
12177
12178         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12179         (basic_inf_threads_range): Remove.
12180         (inf_threads_range, inf_non_exited_threads_range)
12181         (safe_inf_threads_range): Use next_adapter.
12182
12183 2019-01-10  Keith Seitz  <keiths@redhat.com>
12184
12185         PR gdb/23712
12186         PR symtab/23010
12187         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12188         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12189
12190 2019-01-10  Keith Seitz  <keiths@redhat.com>
12191
12192         PR gdb/23712
12193         PR symtab/23010
12194         * dictionary.c (pending_to_vector): Remove.
12195         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12196         Remove _1 suffix, replacing functions of the same name.  Update
12197         all callers.
12198         (dict_create_hashed, dict_create_hashed_expandable)
12199         (dict_create_linear, dict_create_linear_expandable, dict_free)
12200         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12201         Make functions static.
12202
12203 2019-01-10  Keith Seitz  <keiths@redhat.com>
12204
12205         PR gdb/23712
12206         PR symtab/23010
12207         * dictionary.h (struct dictionary): Replace declaration with
12208         multidictionary.
12209         (dict_create_hashed, dict_create_hashed_expandable)
12210         (dict_create_linear, dict_create_linear_expandable)
12211         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12212         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12213         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12214         taking multidictionary argument.
12215         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12216         * block.h (struct block) <dict>: Change to multidictionary
12217         and rename `multidict'.
12218         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12219         symmisc.c: Update all dictionary references to multidictionary.
12220
12221 2019-01-10  Keith Seitz  <keiths@redhat.com>
12222
12223         PR gdb/23712
12224         PR symtab/23010
12225         * dictionary.c: Include unordered_map.
12226         (pending_to_vector): New function.
12227         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12228         Rewrite the non-"_1" functions to take vector instead
12229         of linked list.
12230         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12231         "new" _1 versions of the same name.
12232         (multidictionary): Define.
12233         (std::hash<enum language): New definition.
12234         (collate_pending_symbols_by_language, mdict_create_hashed)
12235         (mdict_create_hashed_expandable, mdict_create_linear)
12236         (mdict_create_linear_expandable, mdict_free)
12237         (find_language_dictionary, create_new_language_dictionary)
12238         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12239         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12240         (mdict_size, mdict_empty): New functions.
12241         * dictionary.h (mdict_iterator): Define.
12242
12243 2019-01-10  Pedro Alves  <palves@redhat.com>
12244
12245         * breakpoint.c (read_uploaded_action)
12246         (create_tracepoint_from_upload): Adjust to use
12247         gdb::unique_xmalloc_ptr.
12248         * ctf.c (ctf_write_uploaded_tp):
12249         (SET_ARRAY_FIELD): Use emplace_back.
12250         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12251         * tracefile-tfile.c (tfile_write_uploaded_tp):
12252         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12253         gdb::unique_xmalloc_ptr.
12254         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12255         at_string, cond_string, cmd_strings>: Replace char pointers
12256         with gdb::unique_xmalloc_ptr.
12257
12258 2019-01-10  Pedro Alves  <palves@redhat.com>
12259
12260         * solib-target.c (library_list_start_library): Don't xstrdup name.
12261
12262 2019-01-10  Pedro Alves  <palves@redhat.com>
12263
12264         * mdebugread.c (parse_partial_symbols): Use
12265         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12266
12267 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12268
12269         * linux-fork.c (scoped_switch_fork_info)
12270         <~scoped_switch_fork_info>: Fix incorrect variable name.
12271
12272 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12273
12274         * linux-fork.c (scoped_switch_fork_info)
12275         <scoped_switch_fork_info>: Make explicit.
12276         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12277
12278 2019-01-10  Tom Tromey  <tom@tromey.com>
12279
12280         * objfiles.h (objfile::reset_psymtabs): Update.
12281         * objfiles.c (objfile::objfile): Update.
12282         * psymtab.h (psymtab_storage::obstack): Update.
12283         (psymtab_storage::m_obstack): Use gdb::optional.
12284         (class psymtab_storage): Update comment.  Remove objfile
12285         parameter.
12286         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12287
12288 2019-01-10  Tom Tromey  <tom@tromey.com>
12289
12290         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12291         <free_psymtabs>: Now private.
12292         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12293         (allocate_psymtab): Use new method.
12294
12295 2019-01-10  Tom Tromey  <tom@tromey.com>
12296
12297         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12298         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12299         * mdebugread.c (parse_partial_symbols): Use
12300         allocate_dependencies.
12301         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12302         allocate_dependencies.
12303         (process_psymtab_comp_unit_reader)
12304         (build_type_psymtab_dependencies): Likewise.
12305         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12306
12307 2019-01-10  Tom Tromey  <tom@tromey.com>
12308
12309         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12310         PSYMBOL_SET_LANGUAGE.
12311         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12312
12313 2019-01-10  Tom Tromey  <tom@tromey.com>
12314
12315         * psymtab.h (psymtab_storage::obstack): New method.
12316         <m_obstack>: Rename from obstack; now private.
12317         * psymtab.c (psymtab_storage): Update.
12318         * dwarf2read.c (create_addrmap_from_index)
12319         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12320         Update.
12321
12322 2019-01-10  Tom Tromey  <tom@tromey.com>
12323
12324         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12325         * objfiles.h (objfile::reset_psymtabs): New method.
12326
12327 2019-01-10  Tom Tromey  <tom@tromey.com>
12328
12329         * symmisc.c (print_symbol_bcache_statistics): Update.
12330         (print_objfile_statistics): Update.
12331         * symfile.c (reread_symbols): Update.
12332         * psymtab.h (class psymtab_storage): New.
12333         * psymtab.c (psymtab_storage): New constructor.
12334         (~psymtab_storage): New destructor.
12335         (require_partial_symbols): Update.
12336         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12337         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12338         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12339         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12340         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12341         (start_psymtab_common, end_psymtab_common)
12342         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12343         (allocate_psymtab): Update.
12344         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12345         Update.
12346         (dump_psymtab_addrmap, maintenance_print_psymbols)
12347         (maintenance_check_psymtabs): Update.
12348         (class objfile_psymtabs): Move to objfiles.h.
12349         * psympriv.h (discard_psymtab): Now inline.
12350         (psymtab_discarder::psymtab_discarder): Update.
12351         (psymtab_discarder::~psymtab_discarder): Update.
12352         (ALL_OBJFILE_PSYMTABS): Rewrite.
12353         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12354         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12355         Remove fields.
12356         <partial_symtabs>: New field.
12357         (class objfile_psymtabs): Move from psymtab.h.  Update.
12358         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12359         psymbol_cache.
12360         (objfile::~objfile): Don't destroy psymbol_cache.
12361         * mdebugread.c (parse_partial_symbols): Update.
12362         * dwarf2read.c (create_addrmap_from_index)
12363         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12364         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12365         (add_partial_subprogram, dwarf2_ranges_read): Update.
12366         * dwarf-index-write.c (write_address_map)
12367         (write_one_signatured_type, recursively_write_psymbols)
12368         (class debug_names, class debug_names, write_psymtabs_to_index):
12369         Update.
12370
12371 2019-01-10  Tom Tromey  <tom@tromey.com>
12372
12373         * symtab.h (SYMBOL_SET_NAMES): Update.
12374         (symbol_set_names): Update.
12375         (MSYMBOL_SET_NAMES): Update.
12376         * symtab.c (symbol_set_names): Change argument to be an
12377         objfile_per_bfd_storage.
12378         * psymtab.c (add_psymbol_to_bcache): Update.
12379         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12380
12381 2019-01-10  Tom Tromey  <tom@tromey.com>
12382
12383         * symtab.c (create_demangled_names_hash): Change argument to be an
12384         objfile_per_bfd_storage.
12385         (symbol_set_names): Update.
12386
12387 2019-01-10  Tom Tromey  <tom@tromey.com>
12388
12389         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12390         init_psymbol_list.
12391         * psymtab.c (init_psymbol_list): Do nothing if already called.
12392         * psympriv.h (init_psymbol_list): Add comment.
12393         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12394         init_psymbol_list.
12395         * dbxread.c (dbx_symfile_read): Unconditionally call
12396         init_psymbol_list.
12397
12398 2019-01-10  Tom Tromey  <tom@tromey.com>
12399
12400         * xcoffread.c (scan_xcoff_symtab): Update.
12401         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12402         "where".
12403         * mdebugread.c (parse_partial_symbols)
12404         (handle_psymbol_enumerators): Update.
12405         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12406         * dbxread.c (read_dbx_symtab): Update.
12407         * psympriv.h (psymbol_placement): New enum.
12408         (add_psymbol_to_list): Update.
12409
12410 2019-01-10  Tom Tromey  <tom@tromey.com>
12411
12412         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12413         static_psymbols parameters.
12414         (scan_xcoff_symtab): Update.
12415         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12416         static_psymbols parameters.
12417         * psympriv.h (start_psymtab_common): Update.
12418         * mdebugread.c (parse_partial_symbols): Update.
12419         * dwarf2read.c (create_partial_symtab): Update.
12420         * dbxread.c (read_dbx_symtab): Update.
12421         (start_psymtab): Remove global_psymbols and static_psymbols
12422         parameters.
12423
12424 2019-01-10  Tom Tromey  <tom@tromey.com>
12425
12426         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12427         * psymtab.c (allocate_psymtab): Add comment.
12428         * psympriv.h (allocate_psymtab): Add comment.
12429         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12430         initializations.
12431         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12432
12433 2019-01-10  Tom Tromey  <tom@tromey.com>
12434
12435         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12436         Don't declare.
12437         * mipsread.c: Include mdebugread.h.
12438         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12439         Declare.
12440         * elfread.c: Include mdebugread.h.
12441
12442 2019-01-09  Tom Tromey  <tom@tromey.com>
12443
12444         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12445         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12446         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12447         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12448         (psym_lookup_symbol, psym_find_last_source_symtab)
12449         (psym_forget_cached_source_info, psym_print_stats)
12450         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12451         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12452         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12453         (psym_find_compunit_symtab_by_address)
12454         (maintenance_print_psymbols, maintenance_info_psymtabs)
12455         (maintenance_check_psymtabs): Use ranged for.
12456         * psymtab.h (class objfile_psymtabs): New.
12457         (require_partial_symbols): Return objfile_psymtabs.
12458         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12459
12460 2019-01-09  Tom Tromey  <tom@tromey.com>
12461
12462         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12463         (find_pc_mapped_section, list_overlays_command)
12464         (map_overlay_command, unmap_overlay_command)
12465         (simple_overlay_update): Use all_objfiles.
12466         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12467         * printcmd.c (info_symbol_command): Use all_objfiles.
12468         * objfiles.h (ALL_OBJSECTIONS): Remove.
12469         * maint.c (maintenance_translate_address): Use all_objfiles.
12470         * gcore.c (gcore_create_callback): Use all_objfiles.
12471         (objfile_find_memory_regions): Likewise.
12472
12473 2019-01-09  Tom Tromey  <tom@tromey.com>
12474
12475         * symtab.c (find_line_symtab, info_sources_command)
12476         (make_source_files_completion_list): Use objfile_compunits.
12477         * source.c (select_source_symtab): Use objfile_compunits.
12478         * objfiles.h (struct objfile): Update comment.
12479         (ALL_OBJFILES): Remove.
12480         (ALL_FILETABS): Remove.
12481         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12482         objfile_compunits.
12483
12484 2019-01-09  Tom Tromey  <tom@tromey.com>
12485
12486         * symmisc.c (print_objfile_statistics, dump_objfile)
12487         (maintenance_print_symbols): Use compunit_filetabs.
12488         * source.c (forget_cached_source_info_for_objfile): Use
12489         compunit_filetabs.
12490         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12491         (ALL_FILETABS): Use compunit_filetabs.
12492         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12493         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12494
12495 2019-01-09  Tom Tromey  <tom@tromey.com>
12496
12497         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12498         (compunit_filetabs): New.
12499         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12500         compunit_filetabs.
12501         (info_sources_command, make_source_files_completion_list): Remove
12502         declaration.
12503         * symmisc.c (print_objfile_statistics, dump_objfile)
12504         (maintenance_print_symbols): Remove declaration.
12505         (maintenance_info_symtabs): Use compunit_filetabs.
12506         (maintenance_info_line_tables): Likewise.
12507         * source.c (select_source_symtab): Change local variable name.
12508         (forget_cached_source_info_for_objfile): Remove declaration.
12509         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12510         * objfiles.c (objfile_relocate1): Remove declaration.
12511         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12512         declaration.
12513         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12514         * coffread.c (coff_symtab_read): Remove declaration.
12515         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12516         compunit_filetabs.
12517
12518 2019-01-09  Tom Tromey  <tom@tromey.com>
12519
12520         * symtab.c (lookup_objfile_from_block)
12521         (find_pc_sect_compunit_symtab, search_symbols)
12522         (default_collect_symbol_completion_matches_break_on): Use
12523         objfile_compunits.
12524         * objfiles.h (ALL_COMPUNITS): Remove.
12525         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12526         * cp-support.c (add_symbol_overload_list_qualified): Use
12527         objfile_compunits.
12528         * ada-lang.c (ada_collect_symbol_completion_matches)
12529         (ada_add_global_exceptions): Use objfile_compunits.
12530
12531 2019-01-09  Tom Tromey  <tom@tromey.com>
12532
12533         * source.c (select_source_symtab)
12534         (forget_cached_source_info_for_objfile): Remove declaration.
12535         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12536         declaration.
12537         * maint.c (count_symtabs_and_blocks): Remove declaration.
12538         * cp-support.c (add_symbol_overload_list_qualified): Remove
12539         declaration.
12540         * coffread.c (coff_symtab_read): Remove declaration.
12541         * symtab.c (lookup_symbol_in_objfile_symtabs)
12542         (basic_lookup_transparent_type_1): Use objfile_compunits.
12543         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12544         (info_sources_command, search_symbols)
12545         (default_collect_symbol_completion_matches_break_on)
12546         (make_source_files_completion_list): Remove declaration.
12547         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12548         (ada_collect_symbol_completion_matches)
12549         (ada_add_global_exceptions): Remove declaration.
12550         * linespec.c (iterate_over_all_matching_symtabs): Use
12551         objfile_compunits.
12552         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12553         (class objfile_compunits): New.
12554         (ALL_COMPUNITS): Use objfile_compunits.
12555         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12556         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12557         objfile_compunits.
12558         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12559
12560 2019-01-09  Tom Tromey  <tom@tromey.com>
12561
12562         * symtab.c (search_symbols)
12563         (default_collect_symbol_completion_matches_break_on): Use
12564         objfile_msymbols.
12565         * ada-lang.c (ada_lookup_simple_minsym)
12566         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12567         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12568         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12569         objfile_msymbols.
12570         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12571         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12572         * objc-lang.c (find_methods): Use objfile_msymbols.
12573         (info_selectors_command, info_classes_command): Likewise.
12574         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12575         * objfiles.h (class objfile_msymbols): New.
12576         (ALL_OBJFILE_MSYMBOLS): Remove.
12577         (ALL_MSYMBOLS): Remove.
12578
12579 2019-01-09  Tom Tromey  <tom@tromey.com>
12580
12581         * common/next-iterator.h (next_adapter): Add Iterator template
12582         parameter.
12583         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12584         (class all_objfiles_safe): New.
12585         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12586         * objfiles.c (put_objfile_before): Update comment.
12587         (add_separate_debug_objfile): Likewise.
12588         (free_all_objfiles): Use all_objfiles_safe.
12589         (objfile_purge_solibs): Likewise.
12590
12591 2019-01-09  Tom Tromey  <tom@tromey.com>
12592
12593         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12594         (expand_symtab_containing_pc, lookup_static_symbol)
12595         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12596         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12597         all_objfiles.
12598         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12599         * breakpoint.c (create_overlay_event_breakpoint)
12600         (create_longjmp_master_breakpoint)
12601         (create_std_terminate_master_breakpoint)
12602         (create_exception_master_breakpoint): Use all_objfiles.
12603         * linux-thread-db.c (try_thread_db_load_from_pdir)
12604         (has_libpthread): Use all_objfiles.
12605         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12606         * linespec.c (iterate_over_all_matching_symtabs)
12607         (search_minsyms_for_name): Use all_objfiles.
12608         * maint.c (maintenance_info_sections): Use all_objfiles.
12609         * main.c (captured_main_1): Use all_objfiles.
12610         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12611         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12612         * guile/scm-pretty-print.c
12613         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12614         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12615         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12616         (maintenance_print_msymbols): Use all_objfiles.
12617         * source.c (select_source_symtab): Use all_objfiles.
12618         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12619         * symfile.c (remove_symbol_file_command)
12620         (expand_symtabs_matching, map_symbol_filenames): Use
12621         all_objfiles.
12622         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12623         all_objfiles.
12624         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12625         * objc-lang.c (find_methods): Use all_objfiles.
12626         * objfiles.c (have_partial_symbols, have_full_symbols)
12627         (have_minimal_symbols, qsort_cmp)
12628         (default_iterate_over_objfiles_in_search_order): Use
12629         all_objfiles.
12630         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12631         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12632         (maintenance_check_psymtabs): Use all_objfiles.
12633         (ALL_PSYMTABS): Remove.
12634         * compile/compile-object-run.c (do_module_cleanup): Use
12635         all_objfiles.
12636         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12637         * cp-support.c (add_symbol_overload_list_qualified): Use
12638         all_objfiles.
12639         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12640         Use all_objfiles.
12641         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12642         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12643         all_objfiles.
12644         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12645         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12646         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12647         Uses all_objfiles.
12648         * solib.c (solib_read_symbols): Use all_objfiles
12649
12650 2019-01-09  Tom Tromey  <tom@tromey.com>
12651
12652         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12653         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12654         all_objfiles.
12655         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12656         * symmisc.c (print_symbol_bcache_statistics)
12657         (print_objfile_statistics, maintenance_print_objfiles)
12658         (maintenance_info_symtabs, maintenance_check_symtabs)
12659         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12660         all_objfiles.
12661         * source.c (forget_cached_source_info): Use all_objfiles.
12662         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12663         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12664         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12665         * objfiles.c (update_section_map): Use all_objfiles.
12666         (shared_objfile_contains_address_p): Likewise.
12667         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12668         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12669
12670 2019-01-09  Tom Tromey  <tom@tromey.com>
12671
12672         * common/next-iterator.h: New file.
12673         * objfiles.h (class all_objfiles): New.
12674         (struct objfile_iterator): New.
12675
12676 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12677
12678         * NEWS: Move the description of the changed "frame", "select-frame",
12679          and "info frame" commands to the Changed commands section.
12680
12681 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12682
12683         * gdbtypes.c (check_stub_method_group): Remove handling of old
12684         mangling schemes.
12685         * linespec.c (find_methods): Likewise.
12686         * stabsread.c (read_member_functions): Likewise.
12687         * valops.c (search_struct_method): Likewise.
12688         (value_struct_elt_for_reference): Likewise.
12689         * NEWS: Mention this change.
12690
12691 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12692
12693         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12694         print_source_lines.
12695         * source.c (print_source_lines_base): Update line number check.
12696         (print_source_lines): New function.
12697         (source_lines_range::source_lines_range): New function.
12698         * source.h (class source_lines_range): New class.
12699         (print_source_lines): New declaration.
12700
12701 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12702
12703         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12704
12705 2019-01-08  Tom Tromey  <tom@tromey.com>
12706             Simon Marchi  <simon.marchi@ericsson.com>
12707
12708         PR gdb/24060
12709         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12710         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12711         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12712         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12713         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12714         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12715
12716 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12717
12718         * source.c (select_source_symtab): Move header comment to
12719         declaration in source.h.
12720         (forget_cached_source_info_for_objfile): Likewise.
12721         (forget_cached_source_info): Likewise.
12722         (identify_source_line): Likewise.
12723         * source.h (identify_source_line): Move declaration from symtab.h
12724         and add comment from source.c
12725         (print_source_lines): Likewise.
12726         (forget_cached_source_info_for_objfile): Likewise.
12727         (forget_cached_source_info): Likewise.
12728         (select_source_symtab): Likewise.
12729         (enum print_source_lines_flag): Move definition from symtab.h.
12730         * symtab.h (identify_source_line): Move declaration to source.h.
12731         (print_source_lines): Likewise.
12732         (forget_cached_source_info_for_objfile): Likewise.
12733         (forget_cached_source_info): Likewise.
12734         (select_source_symtab): Likewise.
12735         (enum print_source_lines_flag): Move definition to source.h.
12736         * tui/tui-hooks.c: Add 'source.h' include.
12737
12738 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12739
12740         * source.c (print_source_lines_base): Handle requests to print
12741         reverse line number sequences, and guard against empty lines
12742         string.
12743
12744 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12745
12746         * source.c (print_source_lines_base): Fix skip of '\r' if next
12747         character is '\n'.
12748
12749 2019-01-06  Tom Tromey  <tom@tromey.com>
12750
12751         * c-exp.y (struct c_parse_state) <macro_original_text,
12752         expansion_obstack>: New member.
12753         (macro_original_text, expansion_obstack): Remove globals.
12754         (scan_macro_expansion, scanning_macro_expansion)
12755         (finished_macro_expansion): Update.
12756         (scan_macro_cleanup): Remove.
12757         (yylex, c_parse): Update.
12758
12759 2019-01-06  Tom Tromey  <tom@tromey.com>
12760
12761         * c-exp.y (struct c_parse_state) <strings>: New member.
12762         (operator_stoken): Update.
12763
12764 2019-01-06  Tom Tromey  <tom@tromey.com>
12765
12766         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12767         (union type_stack_elt) <typelist_val>: Now a pointer to
12768         std::vector.
12769         (type_stack_cleanup): Don't declare.
12770         (push_typelist): Update.
12771         * parse.c (pop_typelist): Return a std::vector.
12772         (push_typelist): Take a std::vector.
12773         (follow_types): Update.  Do not free args.
12774         (type_stack_cleanup): Remove.
12775         * c-exp.y (struct c_parse_state): New.
12776         (cpstate): New global.
12777         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12778         (nonempty_typelist): Update.
12779         (func_mod): Create a new vector.
12780         (c_parse): Create a c_parse_state.
12781         (check_parameter_typelist): Do not delete params.
12782         (function_method): Update.  Do not delete type_list.
12783
12784 2019-01-06  Tom Tromey  <tom@tromey.com>
12785
12786         PR gdb/28155:
12787         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12788         check_typedef.
12789         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12790         (print_return_value): Likewise.
12791
12792 2019-01-05  Tom Tromey  <tom@tromey.com>
12793
12794         * contrib/cleanup_check.py: Remove.
12795         * contrib/gcc-with-excheck: Remove.
12796         * contrib/exsummary.py: Remove.
12797         * contrib/excheck.py: Remove.
12798
12799 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12800
12801         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12802         NULL. Initialize tpprev to NULL instead of assigning it
12803         to NULL on the next statement.
12804         * windows-nat.c (windows_delete_thread): Remove check for
12805         main_thread_id before printing thread exit notifications.
12806         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12807         Remove thread ID check against main_thread_id.
12808         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12809         windows_delete_thread.
12810         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12811
12812 2019-01-04  Tom Tromey  <tom@tromey.com>
12813
12814         * compile/compile.c (_initialize_compile): Use upper case for
12815         metasyntactic variables.
12816         * symmisc.c (_initialize_symmisc): Use upper case for
12817         metasyntactic variables.
12818         * psymtab.c (_initialize_psymtab): Use upper case for
12819         metasyntactic variables.
12820         * demangle.c (demangle_command): Use upper case for metasyntactic
12821         variables.
12822         (_initialize_demangler): Likewise.
12823         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12824         variables.
12825
12826 2019-01-03  Tom Tromey  <tom@tromey.com>
12827
12828         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12829
12830 2019-01-03  Tom Tromey  <tom@tromey.com>
12831
12832         * python/py-symtab.c (salpy_str): Update.
12833         (struct salpy_sal_object) <symtab>: Now a PyObject.
12834         (salpy_dealloc): Update.
12835         (del_objfile_sal): Use gdbpy_ref.
12836
12837 2019-01-03  Tom Tromey  <tom@tromey.com>
12838
12839         * python/py-type.c (convert_field): Use new_reference.  Return
12840         gdbpy_ref.
12841         (make_fielditem): Return gdbpy_ref.
12842         (typy_fields): Update.
12843         (typy_getitem): Update.
12844         (field_name): Return gdbpy_ref.  Use new_reference.
12845         (typy_iterator_iternext): Update.
12846
12847 2019-01-03  Tom Tromey  <tom@tromey.com>
12848
12849         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12850
12851 2019-01-03  Tom Tromey  <tom@tromey.com>
12852
12853         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12854         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12855         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12856         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12857         (pspy_set_type_printers): Likewise.
12858         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12859         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12860         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12861         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12862         (objfpy_set_type_printers): Likewise.
12863
12864 2019-01-03  Tom Tromey  <tom@tromey.com>
12865
12866         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12867         (gdbpy_print_stack): Use gdbpy_err_fetch.
12868         * python/python-internal.h (class gdbpy_err_fetch): New class.
12869         (class gdbpy_enter) <m_error_type, m_error_value,
12870         m_error_traceback>: Remove.
12871         <m_error>: New member.
12872         (gdbpy_exception_to_string): Don't declare.
12873         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12874         * python/py-value.c (convert_value_from_python): Use
12875         gdbpy_err_fetch.
12876         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12877         gdbpy_exception_to_string.
12878         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12879         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12880         gdbpy_err_fetch.
12881
12882 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12883
12884         * linux-nat.c (delete_lwp_cleanup): Delete.
12885         (struct lwp_deleter): New struct.
12886         (lwp_info_up): New typedef.
12887         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12888         lwp_info_up.
12889
12890 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12891
12892         * linux-fork.c (class scoped_switch_fork_info): New class.
12893         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12894
12895 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12896
12897         * valops.c (find_overload_match): Remove use of null_cleanup, and
12898         calls to do_cleanups.
12899
12900 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12901
12902         * compile/compile-cplus-types.c
12903         (compile_cplus_instance::decl_name): Handle changes to
12904         cp_func_name.
12905         * cp-support.c (cp_func_name): Update header comment, update
12906         return type.
12907         * cp-support.h (cp_func_name): Update return type in declaration.
12908         * valops.c (find_overload_match): Move temp_func local to top
12909         level of function and change its type.  Use temp_func to hold and
12910         delete temporary string obtained from cp_func_name.
12911
12912 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12913
12914         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12915         gdb::char_vector, remove cleanup, and update uses of `msg`.
12916
12917 2019-01-03  Jim Wilson  <jimw@sifive.com>
12918
12919         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12920
12921 2019-01-02  Tom Tromey  <tom@tromey.com>
12922
12923         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12924         (tdesc_parse_xml): Remove cleanups.
12925         * target-descriptions.h (make_cleanup_free_target_description):
12926         Don't declare.
12927         (target_desc_deleter): New struct.
12928         (target_desc_up): New typedef.
12929         * target-descriptions.c (target_desc_deleter::operator()): Rename
12930         from free_target_description.
12931         (make_cleanup_free_target_description): Remove.
12932
12933 2019-01-02  Tom Tromey  <tom@tromey.com>
12934
12935         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12936         constructor, destructor.
12937         (linespec_parser): Remove typedef.
12938         (~linespec_parser): Rename from linespec_parser_delete.
12939         (linespec_lex_to_end, linespec_complete_label)
12940         (linespec_complete): Update.
12941         (decode_line_full): Remove cleanups.
12942         (decode_line_1): Update.
12943
12944 2019-01-02  Tom Tromey  <tom@tromey.com>
12945
12946         * python/python-internal.h (inferior_to_inferior_object): Change
12947         return type.
12948         * python/py-exitedevent.c (create_exited_event_object): Update.
12949         * python/py-inferior.c (inferior_to_inferior_object): Return
12950         gdbpy_ref.
12951         (python_new_inferior, python_inferior_deleted)
12952         (thread_to_thread_object, delete_thread_object)
12953         (build_inferior_list, gdbpy_selected_inferior): Update.
12954         * python/py-infthread.c (create_thread_object): Update.  Also fail
12955         if inferior_to_inferior_object fails.
12956
12957 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12958
12959         * inferior.h (class inferior) <displaced_step_state>: New field.
12960         * infrun.h (struct displaced_step_state): Move here from
12961         infrun.c.  Initialize fields, add constructor.
12962         <inf>: Remove field.
12963         <reset>: New method.
12964         * infrun.c (struct displaced_step_inferior_state): Move to
12965         infrun.h.
12966         (displaced_step_inferior_states): Remove.
12967         (get_displaced_stepping_state): Adust.
12968         (displaced_step_in_progress_any_inferior): Adjust.
12969         (displaced_step_in_progress_thread): Adjust.
12970         (displaced_step_in_progress): Adjust.
12971         (add_displaced_stepping_state): Remove.
12972         (get_displaced_step_closure_by_addr): Adjust.
12973         (remove_displaced_stepping_state): Remove.
12974         (infrun_inferior_exit): Call displaced_step_state.reset.
12975         (use_displaced_stepping): Don't check for NULL.
12976         (displaced_step_prepare_throw): Call
12977         get_displaced_stepping_state.
12978         (displaced_step_fixup): Don't check for NULL.
12979         (prepare_for_detach): Don't check for NULL.
12980
12981 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12982
12983         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12984          in case of call that did not complete.
12985
12986 2019-01-02  Andrey Utkin  <autkin@undo.io>
12987
12988         * symfile.c (find_separate_debug_file): Fix search of debug files for
12989         remote debuggee.
12990
12991 2019-01-02  Tom Tromey  <tom@tromey.com>
12992
12993         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12994         indentation.
12995         * python/py-frame.c (frapy_older): Remove cast.
12996         (frapy_newer): Likewise.
12997         * python/py-breakpoint.c (local_setattro): Remove cast.
12998         * python/py-arch.c (archpy_name): Remove local variable.
12999         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13000
13001 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13002
13003         * unittests/basic_string_view/element_access/char/empty.cc:
13004         Fix year range in copyright header.
13005
13006 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13007
13008         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13009         Delete.
13010         <operator==>: Update with for removed field.
13011         <hash>: Likewise.
13012         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13013         <isa_features>: ...this.
13014         <abi_features>: New field.
13015         (riscv_isa_flen): Update comment.
13016         (riscv_abi_xlen): New declaration.
13017         (riscv_abi_flen): New declaration.
13018         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13019         isa_features.
13020         (riscv_abi_xlen): New function.
13021         (riscv_isa_flen): Update to get answer from isa_features.
13022         (riscv_abi_flen): New function.
13023         (riscv_has_fp_abi): Update to get answer from abi_features.
13024         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13025         xlen and flen.
13026         (riscv_call_info) <xlen, flen>: Update comment.
13027         (riscv_call_arg_struct): Remove invalid assertions
13028         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13029         is removed.
13030         (riscv_gdbarch_init): Gather isa features and abi features
13031         separately, ensure both match on the gdbarch when reusing an old
13032         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13033         a target with 64-bit float hardware.
13034
13035 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13036
13037         * source.c (search_command_helper): Stop reverse search
13038         when line 1 has been searched.
13039
13040 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13041
13042         * record-full.c (record_full_base_target::close): Rewrite
13043         record_full_core_buf_list free logic.
13044
13045 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13046
13047         * break-catch-syscall.c (print_one_catch_syscall): xfree
13048         the last text.
13049
13050 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13051
13052         * top.c (print_gdb_version): Update Copyright year in version
13053         message.
13054
13055 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13056
13057         Update copyright year range in all GDB files.
13058
13059 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13060
13061         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13062
13063 For older changes see ChangeLog-2018.
13064 \f
13065 Local Variables:
13066 mode: change-log
13067 left-margin: 8
13068 fill-column: 74
13069 version-control: never
13070 coding: utf-8
13071 End:
13072