gdb/ChangeLog

   1 2019-08-06  Tom Tromey  <tromey@adacore.com>
   2
   3         * source-cache.c (source_cache::get_plain_source_lines):
   4         Remove "first_line" and "last_line" parameters.
   5         (source_cache::get_source_lines): Cache plain text.
   6         * source-cache.h (class source_cache)
   7         <get_plain_source_lines>: Update.
   8
   9 2019-08-06  Tom Tromey  <tromey@adacore.com>
  10
  11         * source-cache.c (extract_lines): No longer a method.
  12         Changed type of parameter.  Include final newline.
  13         (selftests::extract_lines_test): New function.
  14         (_initialize_source_cache): Likewise.
  15         * source-cache.h (class source_cache)
  16         <extract_lines>: Don't declare.
  17
  18 2019-08-06  Tom Tromey  <tromey@adacore.com>
  19
  20         * breakpoint.c (init_breakpoint_sal): Update.
  21         (breakpoint): Update.
  22         * breakpoint.h (struct breakpoint) <filter>: Now a
  23         unique_xmalloc_ptr.
  24
  25 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
  26
  27         * NEWS: Mention dictionary access on blocks.
  28         * python/py-block.c (blpy_getitem): New function.
  29         (block_object_as_mapping): New struct.
  30         (block_object_type): Use new struct for tp_as_mapping field.
  31
  32 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
  33
  34         * objfiles.h (objfile): Add a comment describing partial symbols.
  35
  36 2019-08-05  Tom Tromey  <tromey@adacore.com>
  37
  38         * compile/compile.c (_initialize_compile): Use _(), not N_().
  39         * thread.c (_initialize_thread): Use _(), not N_().
  40         * stack.c (_initialize_stack): Use _(), not N_().
  41         * printcmd.c (_initialize_printcmd): Use _(), not N_().
  42
  43 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
  44
  45         * dwarf2read.c (struct dw2_symtab_iterator):
  46         <want_specific_block>: Remove.
  47         <block_index>: Change type to gdb::optional.
  48         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
  49         change type of BLOCK_INDEX parameter to gdb::optional.
  50         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
  51         (dw2_lookup_symbol): Don't pass argument for
  52         WANT_SPECIFIC_BLOCK.
  53         (dw2_expand_symtabs_for_function): Don't pass argument for
  54         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
  55         (class dw2_debug_names_iterator)
  56         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
  57         parameter, change BLOCK_INDEX type to gdb::optional.
  58         <m_want_specific_block>: Remove.
  59         <m_block_index>: Change type to gdb::optional.
  60         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
  61         gdb::optional.  Re-write in function of gdb::optional.
  62         (dw2_debug_names_lookup_symbol): Don't pass argument for
  63         WANT_SPECIFIC_BLOCK.
  64         (dw2_debug_names_expand_symtabs_for_function): Don't pass
  65         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
  66         BLOCK_INDEX.
  67
  68 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  69
  70         * NEWS: Mention changes to "info sources" command.
  71
  72 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  73
  74         * symtab.c (filename_partial_match_opts): New struct type.
  75         (struct output_source_filename_data): New members
  76         regexp, c_regexp, partial_match.
  77         (output_source_filename): Use new members to decide to print file.
  78         (info_sources_option_defs): New variable.
  79         (make_info_sources_options_def_group, print_info_sources_header,
  80         info_sources_command_completer):
  81         New functions.
  82         (info_sources_command): Read new optional arguments.
  83         (_initialize_symtab): Update info sources help.
  84
  85 2019-08-02  Alexandre Oliva <oliva@adacore.com>
  86
  87         * ada-lang.c (exception_support_info_v0): Renamed from...
  88         (default_exception_support_info): ... this.  Create new
  89         definition for v1.
  90         (ada_has_this_exception_support): Look up catch_handlers_sym.
  91         (ada_exception_support_info_sniffer): Try v0 after default.
  92
  93 2019-08-01  Tom Tromey  <tromey@adacore.com>
  94
  95         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
  96         gdbarch.h.
  97
  98 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
  99
 100         * s12z-tdep.c: Fix include path for s12z-opc.h.
 101
 102 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 103
 104         * NEWS: Require GNU make 3.82.
 105
 106 2019-07-16  Tom Tromey  <tom@tromey.com>
 107
 108         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 109         declare.
 110
 111 2019-07-30  Tom Tromey  <tromey@adacore.com>
 112
 113         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 114
 115 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 116
 117         * printcmd.c (print_address_symbolic): Print negative offsets.
 118         (build_address_symbolic): Force signed arithmetic when computing
 119         offset.
 120
 121 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 122
 123         PR/24474: Add a function to lookup static variables.
 124         * NEWS: Mention this new function.
 125         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 126         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 127         * python/python.c (python_GdbMethods): Add new function.
 128
 129 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 130
 131         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 132         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 133         (objfpy_lookup_static_symbol): New function.
 134         (objfile_object_methods): Add new functions.
 135
 136 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 137
 138         * NEWS: Mention 'set|show print frame-info'.  Mention new
 139         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 140         backtrace argument.  Mention that python frame filtering code
 141         is now consistent with what 'backtrace' command prints.
 142
 143 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 144
 145         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 146         comments.
 147         (print_frame_info_auto, print_frame_info_source_line,
 148         print_frame_info_location, print_frame_info_source_and_location,
 149         print_frame_info_location_and_address, print_frame_info_short_location):
 150         New declarations.
 151         (struct frame_print_options): New member print_frame_info.
 152         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 153         * stack.h (get_user_print_what_frame_info): New declaration.
 154         (frame_show_address): New declaration.
 155         * stack.c (print_frame_arguments_choices): New value 'presence'.
 156         (print_frame_info_auto, print_frame_info_source_line,
 157         print_frame_info_location, print_frame_info_source_and_location,
 158         print_frame_info_location_and_address, print_frame_info_short_location,
 159         print_frame_info_choices, print_frame_info_print_what): New definitions.
 160         (print_frame_args): Only print dots for args if print frame-arguments
 161         is 'presence'.
 162         (frame_print_option_defs): New element for "frame-info".
 163         (get_user_print_what_frame_info): New function.
 164         (frame_show_address): Make non static.  Move comment to stack.h.
 165         (print_frame_info_to_print_what): New function.
 166         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 167         to decide what to print.
 168         (backtrace_command_1): Handle the new print_frame_arguments_presence
 169         value.
 170         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 171         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 172         (py_print_frame): In non-mi mode, use LOCATION as default for
 173         print_what, similarly to frame information printed directly by
 174         backtrace command. Handle frame-info user option in non MI mode.
 175
 176 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 177
 178         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 179         Add case for debugging 32-bit target on 64-bit host.  Revise
 180         comment.
 181
 182 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 183
 184         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 185         instead of find_function_entry_range_from_pc.
 186
 187 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 188
 189         * stack.c (find_frame_funname): Remove code which preferred
 190         minsym over symtab sym in "certain pathological cases".
 191
 192         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 193         parameter.  Change type of "do_demangle" to bool.
 194         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 195         Pass suitable "prefer_sym_over_minsym" flag to
 196         build_address_symbolic().  Don't output "+" for negative offsets.
 197         * printcmd.c (print_address_symbolic): Update invocation of
 198         build_address_symbolic to include a "prefer_sym_over_minsym"
 199         flag.
 200         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 201         Restrict cases in which use of minimal symbol is preferred to that
 202         of a found symbol.  Update comments.
 203
 204         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 205         for entry pc when entry pc is out of range for that FDE.
 206
 207 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 208
 209         PR gdb/24839:
 210         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 211         type.
 212
 213 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 214
 215         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 216         this function's Python signature.
 217
 218
 219 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 220
 221         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 222         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 223         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 224         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 225         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 226
 227
 228 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 229
 230         * h8300-tdep.c (h8300_register_name_common): New.
 231         h8300_register_name): Use h8300_register_name_common.
 232         (h8300s_register_name): Likewise.
 233         (h8300sx_register_name): Likewise.
 234         (h8300h_register_nam): New.
 235         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 236
 237
 238 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 239
 240         * arm-tdep.c (arm_skip_cmse_entry): New function.
 241         (arm_is_sgstubs_section): New function.
 242         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 243
 244 2019-07-22  Tom Tromey  <tom@tromey.com>
 245
 246         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 247         Don't self-assign.
 248
 249 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 250
 251         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 252         type_print.
 253
 254 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 255
 256         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 257         so that GDB doesn't match any msymbols when searching in the
 258         TYPES_DOMAIN.
 259         (print_symbol_info): Print using typedef_print or type_print based
 260         on the type of the symbol.  Add updated FIXME comment moved from...
 261         (_initialize_symtab): ... move and update FIXME comment to above.
 262
 263 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 264
 265         * NEWS: Mention adding -q option to "info types".
 266         * symtab.c (struct info_types_options): New struct.
 267         (info_types_options_defs): New variable.
 268         (make_info_types_options_def_group): New function.
 269         (info_types_command): Use gdb::option framework to parse options.
 270         (info_types_command_completer): New function.
 271         (_initialize_symtab): Extend the help text on "info types" and
 272         register command completer.
 273
 274 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 275
 276         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 277         (lookup_symbol_in_objfile): Change int to block_enum and add a
 278         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 279
 280 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 281
 282         * MAINTAINERS (Write After Approval): Add self.
 283
 284 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 285
 286         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 287         instruction to the dummy code region.
 288
 289 2019-07-19  Tom Tromey  <tromey@adacore.com>
 290
 291         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 292         (ARGSUSED, PARAMS, __func__): Remove rules.
 293
 294 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 295
 296         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 297         * features/arm/arm-with-iwmmxt.c: Remove.
 298         * features/arm/arm-with-iwmmxt.xml: Remove.
 299         * features/arm/arm-with-m-fpa-layout.c: Remove.
 300         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 301         * features/arm/arm-with-m-vfp-d16.c: Remove.
 302         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 303         * features/arm/arm-with-m.c: Remove.
 304         * features/arm/arm-with-m.xml: Remove.
 305         * features/arm/arm-with-neon.c: Remove.
 306         * features/arm/arm-with-neon.xml: Remove.
 307         * features/arm/arm-with-vfpv2.c: Remove.
 308         * features/arm/arm-with-vfpv2.xml: Remove.
 309         * features/arm/arm-with-vfpv3.c: Remove.
 310         * features/arm/arm-with-vfpv3.xml: Remove.
 311
 312 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 313
 314         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 315
 316 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 317
 318         * arch/aarch32.c (aarch32_create_target_description): Create
 319         target descriptions using features.
 320         * arch/arm.c (arm_create_target_description)
 321         (arm_create_mprofile_target_description): Likewise.
 322         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 323
 324 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 325
 326         * Makefile.in: Add new files.
 327         * aarch32-tdep.c: New file.
 328         * aarch32-tdep.h: New file.
 329         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 330         Call aarch32_read_description.
 331         * arch/aarch32.c: New file.
 332         * arch/aarch32.h: New file.
 333         * arch/arm.c (arm_create_target_description)
 334         (arm_create_mprofile_target_description): New function.
 335         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 336         (arm_create_target_description)
 337         (arm_create_mprofile_target_description): New declaration.
 338         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 339         read_description functions.
 340         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 341         Likewise.
 342         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 343         * arm-tdep.c (tdesc_arm_list): New variable.
 344         (arm_register_g_packet_guesses): Call create description functions.
 345         (arm_read_description) (arm_read_mprofile_description): New
 346         function.
 347         * arm-tdep.h (arm_read_description)
 348         (arm_read_mprofile_description): Add declaration.
 349         * configure.tgt: Add new files.
 350
 351 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 352
 353         * top.c (new_ui_command): Open specified terminal just once.
 354
 355 2019-07-18  Tom Tromey  <tromey@adacore.com>
 356
 357         * symtab.c (main_name): Constify return type.
 358         * symfile.c (set_initial_language): Update.
 359         * symtab.h (main_name): Constify return type.
 360
 361 2019-07-17  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-winsource.c (tui_update_source_window)
 364         (tui_update_source_window_as_is)
 365         (tui_update_source_windows_with_line): Remove return.
 366         * tui/tui-disasm.c (tui_show_disassem)
 367         (tui_show_disassem_and_update_source): Remove return.
 368         * tui/tui.c (tui_reset): Remove return.
 369         * tui/tui-wingeneral.c
 370         (tui_check_and_display_highlight_if_needed): Remove return.
 371
 372 2019-07-17  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 375
 376 2019-07-17  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-winsource.h (struct tui_exec_info_window)
 379         (struct tui_source_window_base): Move from tui-data.h.
 380         * tui/tui-winsource.c: Move many method definitions from
 381         elsewhere.  Remove "structuring" comments.
 382         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 383         (tui_source_window_base::refresh_window): Move to
 384         tui-winsource.c.
 385         * tui/tui-win.c (tui_source_window_base::refresh_all)
 386         (tui_source_window_base::update_tab_width)
 387         (tui_source_window_base::set_new_height)
 388         (tui_source_window_base::do_make_visible_with_new_height): Move to
 389         tui-winsource.c.
 390         * tui/tui-source.h: Update.
 391         * tui/tui-source.c (tui_source_window_base::reset): Move to
 392         tui-winsource.c.
 393         * tui/tui-disasm.h: Update.
 394         * tui/tui-data.h (struct tui_exec_info_window): Move to
 395         tui-winsource.h.
 396         (struct tui_source_window_base): Likewise.
 397         * tui/tui-data.c (tui_source_window_base::clear_detail)
 398         (tui_source_window_base, ~tui_source_window_base): Move to
 399         tui-winsource.c.
 400
 401 2019-07-17  Tom Tromey  <tom@tromey.com>
 402
 403         * tui/tui-win.c (tui_resize_all)
 404         (tui_source_window_base::update_tab_width)
 405         (tui_adjust_win_heights): Update.
 406         (tui_win_info::make_invisible_and_set_new_height): Rename from
 407         make_invisible_and_set_new_height.
 408         * tui/tui-data.h (struct tui_win_info)
 409         <make_invisible_and_set_new_height>: New method.
 410
 411 2019-07-17  Tom Tromey  <tom@tromey.com>
 412
 413         * tui/tui.c: Update.
 414         * tui/tui-source.h (struct tui_source_window): Move from
 415         tui-data.h.
 416         * tui/tui-layout.c: Update.
 417         * tui/tui-disasm.c: Update.
 418         * tui/tui-data.h (struct tui_source_window): Move to
 419         tui-source.h.
 420
 421 2019-07-17  Tom Tromey  <tom@tromey.com>
 422
 423         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 424         tui-data.h.
 425         * tui/tui-data.h (struct tui_disasm_window): Move to
 426         tui-disasm.h.
 427
 428 2019-07-17  Tom Tromey  <tom@tromey.com>
 429
 430         * tui/tui-regs.h (struct tui_data_item_window): Move from
 431         tui-data.h.
 432         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 433         * tui/tui-data.h (struct tui_data_item_window): Move to
 434         tui-regs.h.
 435         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 436
 437 2019-07-17  Tom Tromey  <tom@tromey.com>
 438
 439         * tui/tui.c: Update.
 440         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 441         (tui_cmd_window::max_height): Move to tui-command.c.
 442         * tui/tui-layout.c: Update.
 443         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 444         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 445         tui-command.c.
 446         * tui/tui-command.h (struct tui_cmd_window): Move from
 447         tui-data.h.
 448         * tui/tui-command.c: Remove "structuring" comments.
 449         (tui_cmd_window::clear_detail)
 450         (tui_cmd_window::do_make_visible_with_new_height)
 451         (tui_cmd_window::max_height): Move from elsewhere.
 452
 453 2019-07-17  Tom Tromey  <tom@tromey.com>
 454
 455         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 456         Now static.
 457         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 458         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 459
 460 2019-07-17  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui.c: Update.
 463         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 464         tui-regs.c.
 465         * tui/tui-windata.h: Remove file.
 466         * tui/tui-windata.c: Remove file.
 467         * tui/tui-win.c (tui_data_window::set_new_height)
 468         (tui_data_window::do_make_visible_with_new_height): Move to
 469         tui-regs.c.
 470         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 471         * tui/tui-regs.c: Remove "structuring" comments.
 472         (tui_data_window::first_data_item_displayed)
 473         (tui_data_window::delete_data_content_windows)
 474         (tui_data_window::erase_data_content)
 475         (tui_data_window::display_all_data)
 476         (tui_data_window::refresh_all)
 477         (tui_data_window::do_scroll_vertical)
 478         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 479         (tui_data_window::do_make_visible_with_new_height)
 480         (tui_data_window::refresh_window): Move from elsewhere.
 481         (_initialize_tui_regs): Move to end of file.
 482         * tui/tui-layout.c: Update.
 483         * tui/tui-hooks.c: Update.
 484         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 485         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 486         tui-regs.c.
 487         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 488
 489 2019-07-17  Tom Tromey  <tom@tromey.com>
 490
 491         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 492         seen.
 493
 494 2019-07-17  Tom Tromey  <tom@tromey.com>
 495
 496         * tui/tui-win.c (tui_source_window_base::set_new_height)
 497         (tui_source_window_base::do_make_visible_with_new_height): Use
 498         m_has_locator field directly.
 499         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 500         method.
 501         (struct tui_source_window_base) <has_locator>: Likewise.
 502
 503 2019-07-17  Tom Tromey  <tom@tromey.com>
 504
 505         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 506         Don't declare.
 507         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 508         Remove.
 509         * tui/tui-win.c (tui_source_window_base::set_new_height)
 510         (tui_source_window_base::set_new_height)
 511         (make_invisible_and_set_new_height)
 512         (tui_source_window_base::do_make_visible_with_new_height)
 513         (tui_source_window_base::do_make_visible_with_new_height):
 514         Update.
 515         * tui/tui-layout.c (show_source_disasm_command, show_data)
 516         (show_source_or_disasm_and_command): Update.
 517         * tui/tui-layout.c (show_layout): Update.
 518
 519 2019-07-17  Tom Tromey  <tom@tromey.com>
 520
 521         * tui/tui-layout.c (make_data_window): Remove.
 522         (show_data): Unify creation and re-initialization cases.
 523
 524 2019-07-17  Tom Tromey  <tom@tromey.com>
 525
 526         * tui/tui-layout.c (make_source_window, make_disasm_window):
 527         Remove.
 528         (show_data): Unify creation and re-initialization cases.
 529
 530 2019-07-17  Tom Tromey  <tom@tromey.com>
 531
 532         * tui/tui-layout.c (make_command_window): Remove.
 533         (show_source_disasm_command, show_source_or_disasm_and_command):
 534         Unify creation and re-initialization cases.
 535
 536 2019-07-17  Tom Tromey  <tom@tromey.com>
 537
 538         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 539         creation and re-initialization cases.
 540
 541 2019-07-17  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-regs.c (tui_get_register): Return void.
 544
 545 2019-07-17  Tom Tromey  <tom@tromey.com>
 546
 547         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 548         Simplify.
 549
 550 2019-07-17  Tom Tromey  <tom@tromey.com>
 551
 552         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 553         resetting.
 554
 555 2019-07-17  Tom Tromey  <tom@tromey.com>
 556
 557         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 558         * tui/tui-regs.c (tui_reg_layout): New function.
 559         (tui_show_registers, tui_reg_command): Use it.
 560         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 561         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 562         parameters.
 563         (tui_layout_command): Remove.
 564
 565 2019-07-17  Tom Tromey  <tom@tromey.com>
 566
 567         * tui/tui-layout.h (tui/tui-layout): Return void.
 568         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 569
 570 2019-07-17  Tom Tromey  <tom@tromey.com>
 571
 572         * tui/tui-layout.c (show_source_disasm_command, show_data):
 573         Update.
 574         (reset_locator): Remove.
 575         (show_source_or_disasm_and_command): Update.
 576
 577 2019-07-17  Tom Tromey  <tom@tromey.com>
 578
 579         * tui/tui-source.c (tui_source_window_base::reset): Remove
 580         win_type parameter.
 581         * tui/tui-layout.c (make_command_window, make_source_window)
 582         (make_disasm_window, make_data_window)
 583         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 584         (reset_locator, show_source_or_disasm_and_command): Update.
 585         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 586         win_type parameter.
 587         (struct tui_source_window_base) <reset>: Likewise.
 588
 589 2019-07-17  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui-layout.c (show_source_disasm_command): Use
 592         reset_locator.
 593         (reset_locator): New function.
 594         (init_and_make_win): Remove.
 595         (show_source_or_disasm_and_command): Use reset_locator.
 596
 597 2019-07-17  Tom Tromey  <tom@tromey.com>
 598
 599         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 600         condition.
 601         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 602         Remove condition.
 603         * tui/tui-source.c (tui_source_window_base::reset): New method.
 604         * tui/tui-layout.c (make_command_window): Don't call
 605         init_and_make_win.
 606         (make_source_window, make_disasm_window): Don't call
 607         make_source_or_disasm_window.
 608         (make_data_window): Don't call init_and_make_win.  Change calling
 609         convention.
 610         (show_source_disasm_command, show_data): Simplify.
 611         (make_source_or_disasm_window): Remove.
 612         (show_source_or_disasm_and_command): Simplify.
 613         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 614         (struct tui_source_window_base) <reset>: Likewise.
 615         <execution_info>: Remove initializer.
 616         * tui/tui-data.c (tui_source_window_base): Initialize
 617         execution_info.
 618
 619 2019-07-17  Tom Tromey  <tom@tromey.com>
 620
 621         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 622         variable.
 623
 624 2019-07-17  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui.c (tui_rl_other_window): Update.
 627         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 628         superclass method first.  Always iterate over regs_content.
 629         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 630         method.
 631         * tui/tui-win.c (tui_set_focus_command): Update.
 632
 633 2019-07-17  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui-win.c (tui_set_focus_command): Rename from
 636         tui_set_focus.  Call tui_enable.
 637         (tui_set_focus_command): Remove.
 638
 639 2019-07-17  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 642         refresh_window.
 643         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 644         touchwin.
 645         (tui_data_window::refresh_window): Call refresh_window on data
 646         items.  Always call superclass refresh_window.
 647         (tui_win_info::refresh): Remove.
 648         (tui_source_window_base::refresh_window): Update.
 649         (tui_refresh_all): Update.
 650         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 651         refresh_window.
 652         (show_source_or_disasm_and_command): Likewise.
 653         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 654         (struct tui_source_window_base) <refresh>: Likewise.
 655
 656 2019-07-17  Tom Tromey  <tom@tromey.com>
 657
 658         * tui/tui-winsource.c (tui_clear_source_content)
 659         (tui_show_source_content): Update.
 660         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 661         whether content is empty.
 662         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 663         Remove.
 664
 665 2019-07-17  Tom Tromey  <tom@tromey.com>
 666
 667         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 668         window's contents.
 669         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 670         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 671
 672 2019-07-17  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 675         (struct tui_data_item_window): Update.
 676
 677 2019-07-17  Tom Tromey  <tom@tromey.com>
 678
 679         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 680         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 681         defines.
 682
 683 2019-07-17  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui-winsource.h (tui_erase_source_content)
 686         (tui_clear_source_content): Remove "display_prompt" parameter.
 687         * tui/tui-winsource.c (tui_update_source_window_as_is)
 688         (tui_update_source_windows_with_addr): Update.
 689         (tui_clear_source_content): Remove "display_prompt" parameter.
 690         (tui_erase_source_content): Likewise.  Simplify.
 691         (tui_show_source_content): Update.
 692         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 693         * tui/tui-stack.c (tui_show_frame_info): Update.
 694         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 695         Remove defines.
 696
 697 2019-07-17  Tom Tromey  <tom@tromey.com>
 698
 699         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 700         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 701         parameter.
 702         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 703         parameter.
 704
 705 2019-07-17  Tom Tromey  <tom@tromey.com>
 706
 707         * tui/tui-winsource.c (tui_clear_source_content)
 708         (tui_show_source_content, tui_show_exec_info_content)
 709         (tui_clear_exec_info_content): Update.
 710         * tui/tui-stack.c (tui_show_locator_content): Update.
 711         (tui_show_frame_info): Update.
 712         * tui/tui-source.h (tui_source_window): Don't declare.
 713         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 714         from tui_source_is_displayed.
 715         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 716         Remove field.
 717         (struct tui_source_window_base) <content_in_use>: New field.  Now
 718         bool.
 719         (struct tui_source_window) <showing_source_p>: New method.
 720         (TUI_SRC_WIN): Change cast.
 721         * tui/tui-data.c (tui_initialize_static_data): Update.
 722
 723 2019-07-17  Tom Tromey  <tom@tromey.com>
 724
 725         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 726         location_matches_p.
 727         * tui/tui-source.c (tui_source_window::location_matches_p): New
 728         method.
 729         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 730         method.
 731         * tui/tui-data.h (struct tui_source_window_base)
 732         <location_matches_p>: New method.
 733         (struct tui_source_window, struct tui_disasm_window)
 734         <location_matches_p>: Likewise.
 735
 736 2019-07-17  Tom Tromey  <tom@tromey.com>
 737
 738         * tui/tui-win.c (tui_set_win_height_command): Rename from
 739         tui_set_win_height.
 740         (tui_set_win_height_command): Remove.
 741
 742 2019-07-17  Tom Tromey  <tom@tromey.com>
 743
 744         * tui/tui-source.c (tui_source_window): New constructor.  Add
 745         observer.
 746         (~tui_source_window): New destructor.
 747         (tui_source_window::style_changed): New method.
 748         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 749         (tui_attach_detach_observers): Update.
 750         * tui/tui-data.h (struct tui_source_window): Make constructor not
 751         inline.  Add destructor.
 752         (struct tui_source_window) <style_changed>: New method.
 753         <m_observable>: New member.
 754
 755 2019-07-17  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 758         * tui/tui-win.c (tui_resize_all): Fix typo.
 759
 760 2019-07-17  Tom Tromey  <tom@tromey.com>
 761
 762         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 763         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 764         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 765         * tui/tui-win.c (window_name_completer): Use foreach.
 766         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 767         (update_tab_width): Likewise.
 768         * tui/tui-layout.c (show_layout): Update.
 769         * tui/tui-data.h (class tui_window_iterator): New.
 770         (struct all_tui_windows): New.
 771         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 772
 773 2019-07-17  Tom Tromey  <tom@tromey.com>
 774
 775         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 776         parameter.  Don't reference globals.
 777         (tui_reg_command): Update.
 778
 779 2019-07-17  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-regs.c (tui_show_registers): Simplify.
 782
 783 2019-07-17  Tom Tromey  <tom@tromey.com>
 784
 785         * tui/tui-regs.c (tui_show_registers): Update.
 786         (tui_show_register_group): Add win_info parameter.
 787
 788 2019-07-17  Tom Tromey  <tom@tromey.com>
 789
 790         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 791         Rename from tui_display_reg_element_at_line.
 792         (tui_data_window::display_registers_from_line): Update.
 793         * tui/tui-data.h (struct tui_data_window)
 794         <display_reg_element_at_line>: New method.
 795
 796 2019-07-17  Tom Tromey  <tom@tromey.com>
 797
 798         * tui/tui-regs.h (tui_display_registers_from)
 799         (tui_display_registers_from_line): Don't declare.
 800         * tui/tui-windata.c (tui_data_window::display_all_data)
 801         (tui_data_window::refresh_all)
 802         (tui_data_window::do_scroll_vertical): Update.
 803         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 804         from tui_display_registers_from.
 805         (tui_display_reg_element_at_line): Update.
 806         (tui_data_window::display_registers_from_line): Rename from
 807         tui_display_registers_from_line.
 808         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 809         display_registers_from_line>: New methods.
 810
 811 2019-07-17  Tom Tromey  <tom@tromey.com>
 812
 813         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 814         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 815         from tui_erase_data_content.
 816         (tui_data_window::display_all_data)
 817         (tui_data_window::refresh_all)
 818         (tui_data_window::do_scroll_vertical): Update.
 819         * tui/tui-regs.c (tui_show_registers): Update.
 820         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 821         New method.
 822
 823 2019-07-17  Tom Tromey  <tom@tromey.com>
 824
 825         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 826         declare.
 827         * tui/tui-windata.c
 828         (tui_data_window::delete_data_content_windows): Rename from
 829         tui_delete_data_content_windows.
 830         (tui_data_window::display_all_data)
 831         (tui_data_window::do_scroll_vertical): Update.
 832         * tui/tui-data.h (struct tui_data_window)
 833         <delete_data_content_windows>: New method.
 834
 835 2019-07-17  Tom Tromey  <tom@tromey.com>
 836
 837         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 838         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 839
 840 2019-07-17  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 843         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 844         from tui_display_all_data.
 845         * tui/tui-win.c
 846         (tui_data_window::do_make_visible_with_new_height): Update.
 847         * tui/tui-regs.c (tui_show_registers): Update.
 848         * tui/tui-layout.c (tui_set_layout): Update.
 849         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 850         method.
 851
 852 2019-07-17  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 855         * tui/tui-windata.c (tui_display_data_from): Remove.
 856         (tui_data_window::refresh_all): Update.
 857
 858 2019-07-17  Tom Tromey  <tom@tromey.com>
 859
 860         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 861         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 862         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 863         tui_display_registers_from_line.
 864         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 865         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 866         "force_display" parameter.
 867
 868 2019-07-17  Tom Tromey  <tom@tromey.com>
 869
 870         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 871         declare.
 872         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 873         Rename from tui_first_reg_element_no_inline.
 874         (tui_display_reg_element_at_line)
 875         (tui_display_registers_from_line): Update.
 876         * tui/tui-data.h (struct tui_data_window)
 877         <first_reg_element_no_inline>: New method.
 878
 879 2019-07-17  Tom Tromey  <tom@tromey.com>
 880
 881         * tui/tui-windata.c (tui_display_data_from)
 882         (tui_data_window::do_scroll_vertical): Update.
 883         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 884         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 885         Rename from tui_line_from_reg_element_no.
 886         (tui_display_registers_from_line): Update.
 887         * tui/tui-data.h (struct tui_data_window)
 888         <line_from_reg_element_no>: New method.
 889
 890 2019-07-17  Tom Tromey  <tom@tromey.com>
 891
 892         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 893         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 894         tui_last_regs_line_no.
 895         (tui_display_reg_element_at_line)
 896         (tui_display_registers_from_line): Update.
 897         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 898         method.
 899
 900 2019-07-17  Tom Tromey  <tom@tromey.com>
 901
 902         PR tui/24722:
 903         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 904         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 905         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 906         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 907         (tui_update_breakpoint_info): Likewise.
 908         * tui/tui-hooks.c (tui_event_create_breakpoint)
 909         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 910         Update.
 911
 912 2019-07-17  Tom Tromey  <tom@tromey.com>
 913
 914         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 915
 916 2019-07-17  Tom Tromey  <tom@tromey.com>
 917
 918         * tui/tui-winsource.c (tui_update_source_window_as_is)
 919         (tui_update_source_windows_with_addr): Update.
 920         * tui/tui-source.h (tui_set_source_content)
 921         (tui_show_symtab_source): Add "win_info" parameter.
 922         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 923         parameter.
 924         (tui_show_symtab_source): Likewise.
 925
 926 2019-07-17  Tom Tromey  <tom@tromey.com>
 927
 928         * tui/tui-wingeneral.c
 929         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 930
 931 2019-07-17  Tom Tromey  <tom@tromey.com>
 932
 933         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 934         (struct tui_cmd_window) <can_scroll>: New method.
 935         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 936         method.
 937
 938 2019-07-17  Tom Tromey  <tromey@adacore.com>
 939
 940         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 941         do_field_signed>: Rename.  Change type of "value".
 942         * ui-out.c (ui_out::field_signed): Rename from field_int.
 943         Change type of "value".
 944         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 945         type of "value".
 946         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 947         do_field_int.  Change type of "value".
 948         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 949         do_field_int.  Change type of "value".
 950         * tracepoint.c (trace_status_mi, tfind_1)
 951         (print_one_static_tracepoint_marker): Update.
 952         * thread.c (print_thread_info_1, print_selected_thread_frame):
 953         Update.
 954         * stack.c (print_frame, print_frame_info): Update.
 955         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 956         Update.
 957         * source.c (print_source_lines_base): Update.
 958         * skip.c (info_skip_command): Update.
 959         * record-btrace.c (btrace_ui_out_decode_error)
 960         (btrace_call_history_src_line): Update.
 961         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 962         Update.
 963         * progspace.c (print_program_space): Update.
 964         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 965         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 966         do_field_int.  Change type of "value".
 967         * mi/mi-out.c (mi_ui_out::do_table_begin)
 968         (mi_ui_out::do_table_header): Update.
 969         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 970         type of "value".
 971         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 972         (mi_cmd_data_list_changed_registers, output_register)
 973         (mi_cmd_data_read_memory, mi_load_progress)
 974         (mi_cmd_trace_frame_collected): Update.
 975         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 976         Update.
 977         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 978         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 979         (mi_cmd_var_list_children, varobj_update_one): Update.
 980         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 981         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 982         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 983         * inferior.c (print_inferior): Update.
 984         * gdb_bfd.c (print_one_bfd): Update.
 985         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 986         Update.
 987         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 988         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 989         do_field_int.  Change type of "value".
 990         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 991         do_field_int.  Change type of "value".
 992         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 993         (print_one_breakpoint_location, print_it_catch_fork)
 994         (print_one_catch_fork, print_it_catch_vfork)
 995         (print_one_catch_vfork, print_it_catch_solib)
 996         (print_it_catch_exec, print_it_ranged_breakpoint)
 997         (print_mention_watchpoint, print_mention_masked_watchpoint)
 998         (bkpt_print_it, update_static_tracepoint): Update.
 999         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1000         * break-catch-syscall.c (print_it_catch_syscall): Update.
1001         * ada-tasks.c (print_ada_task_info): Update.
1002         * ada-lang.c (print_it_exception, print_mention_exception):
1003         Update.
1004
1005 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1006
1007         PR breakpoints/24541
1008         * gdbarch.c: Regenerate.
1009         * gdbarch.h: Regenerate.
1010         * gdbarch.sh: Adjust return type and parameter types for
1011         'stap_adjust_register'.
1012         (i386_stap_adjust_register): Adjust signature and return new
1013         register name.
1014         * stap-probe.c (stap_parse_register_operand): Adjust use of
1015         'gdbarch_stap_adjust_register'.
1016
1017 2019-07-17  Tom Tromey  <tromey@adacore.com>
1018
1019         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1020         declare VEC.
1021         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1022         std::vector.
1023         (struct s390_process_info): Add initializers.
1024         (s390_add_process): Use new.
1025         (s390_linux_nat_target::low_forget_process): Use delete.
1026         (s390_linux_nat_target::low_new_fork)
1027         (s390_linux_nat_target::stopped_by_watchpoint)
1028         (s390_linux_nat_target::low_prepare_to_resume)
1029         (s390_linux_nat_target::insert_watchpoint)
1030         (s390_linux_nat_target::insert_hw_breakpoint)
1031         (s390_linux_nat_target::remove_watchpoint)
1032         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1033
1034 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1035
1036         * aarch64-fbsd-nat.c: Include regcache.h.
1037         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1038         argument.
1039         (aarch64_fbsd_nat_target::fetch_registers)
1040         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1041         variable.
1042         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1043
1044 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1045
1046         * fbsd-nat.c: Include gdbarch.h.
1047
1048 2019-07-15  Tom Tromey  <tromey@adacore.com>
1049
1050         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1051
1052 2019-07-15  Tom Tromey  <tromey@adacore.com>
1053
1054         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1055         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1056         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1057         * cli-out.c (cli_ui_out::do_field_int): New method.
1058         * ui-out.c (ui_out::field_unsigned): New method.
1059         * symfile.c (generic_load): Use field_unsigned.
1060         (print_transfer_performance): Likewise.
1061         * record-btrace.c (ui_out_field_uint): Remove.
1062         (btrace_call_history_insn_range, btrace_call_history): Use
1063         field_unsigned.
1064         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1065         field_unsigned.
1066         * ui-out.h (class ui_out) <field_unsigned>: New method.
1067         <do_field_unsigned>: Likewise.
1068
1069 2019-07-15  Tom Tromey  <tromey@adacore.com>
1070
1071         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1072         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1073         * target.c (flash_erase_command): Use field_string.
1074         * infrun.c (print_signal_received_reason): Use field_string.
1075         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1076         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1077         field_string.
1078         * ada-tasks.c (print_ada_task_info): Use field_string.
1079
1080 2019-07-15  Tom Tromey  <tromey@adacore.com>
1081
1082         * target.c (flash_erase_command): Use field_core_addr.
1083         * symfile.c (generic_load): Use field_core_addr.
1084         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1085         Use field_core_addr.
1086         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1087         field_core_addr.
1088
1089 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1090
1091         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1092         value if its desired type is smaller than a CORE_ADDR and signed.
1093
1094 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1095
1096         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1097         of changes to field names, and use new is_reference field to
1098         decide if a property is a reference or not.
1099         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1100         field.
1101         (struct dwarf2_property_baton): Update header comment, rename
1102         'referenced_type' to 'property_type' and update comments.
1103         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1104         default property type, store in property baton, update to take
1105         accound of renamed field.
1106         (read_func_scope): Update call to attr_to_dynamic_prop.
1107         (read_array_type): Likewise.
1108         (dwarf2_per_cu_addr_sized_int_type): New function.
1109         (read_subrange_index_type): Move type finding code to
1110         dwarf2_per_cu_addr_sized_int_type.
1111         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1112         (dwarf2_per_cu_addr_type): New function.
1113         (set_die_type): Update calls to attr_to_dynamic_prop.
1114
1115 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1116
1117         * dwarf2read.c (read_subrange_index_type): New function.
1118         (read_subrange_type): Move code into new function and call it.
1119         * gdbtypes.c (create_range_type): Add some asserts.
1120
1121 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1122
1123         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1124         update return statements.
1125         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1126         declaration, and update comment to match.
1127         * gdbtypes.c (resolve_dynamic_array): Update call to
1128         dwarf2_evaluate_property to match new return type.
1129
1130 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1131
1132         * valarith.c (value_subscripted_rvalue): Change lowerbound
1133         parameter type from int to LONGEST.
1134         * value.h (value_subscripted_rvalue): Likewise in declaration.
1135
1136 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1137
1138         * cli/cli-utils.c (info_print_command_completer): New function.
1139         * cli/cli-utils.h: Add 'completer.h' include, and forward
1140         declaration for 'struct cmd_list_element'.
1141         (info_print_command_completer): Declare.
1142         * stack.c (_initialize_stack): Add completer for 'info locals' and
1143         'info args'.
1144         * symtab.c (_initialize_symtab): Add completer for 'info
1145         variables' and 'info functions'.
1146         * NEWS: Mention completion for additional info commands.
1147
1148 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1149
1150         * cli/cli-utils.c (extract_info_print_args): Delete.
1151         (extract_arg_maybe_quoted): Delete.
1152         (info_print_options_defs): New variable.
1153         (make_info_print_options_def_group): New function.
1154         (extract_info_print_options): Define new function.
1155         * cli/cli-utils.h (extract_info_print_args): Delete.
1156         (struct info_print_options): New structure.
1157         (extract_info_print_options): Declare new function.
1158         * stack.c (info_locals_command): Update to use new
1159         extract_info_print_options, also add a header comment.
1160         (info_args_command): Likewise.
1161         * symtab.c (info_variables_command): Likewise.
1162         (info_functions_command): Likewise.
1163
1164 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1165
1166         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1167         to extract string arguments.
1168         * common/common-utils.c (extract_string_maybe_quoted): New function.
1169         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1170
1171 2019-07-11  Tom Tromey  <tromey@adacore.com>
1172
1173         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1174         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1175         * top.h (gdbinit): Don't declare.
1176         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1177         into...
1178         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1179         * top.c (gdb_init): Don't call init_cli_cmds.
1180         (gdbinit): Remove.
1181         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1182
1183 2019-07-11  Tom Tromey  <tromey@adacore.com>
1184
1185         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1186         after it has been moved.
1187
1188 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1189
1190         * valops.c (value_must_coerce_to_target): Change return type to
1191         bool.
1192         * value.h (value_must_coerce_to_target): Likewise.
1193
1194 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1195
1196         * breakpoint.c (is_hardware_watchpoint): Remove
1197         forward-declaration.
1198         (is_masked_watchpoint): Change return type to bool.
1199         (is_tracepoint): Likewise.
1200         (is_breakpoint): Likewise.
1201         (is_hardware_watchpoint): Likewise.
1202         (is_watchpoint): Likewise.
1203         (is_no_memory_software_watchpoint): Likewise.
1204         (is_catchpoint): Likewise.
1205         (breakpoint_1): Make FILTER parameter's return type bool.
1206         is_masked_watchpoint): Change return type to bool.
1207         (save_breakpoints): Make FILTER parameter's return type bool.
1208         * breakpoint.h (is_breakpoint): Change return type to bool.
1209         (is_watchpoint): Likewise.
1210         (is_catchpoint): Likewise.
1211         (is_tracepoint): Likewise.
1212
1213 2019-07-10  Tom Tromey  <tom@tromey.com>
1214
1215         * defs.h: Don't include gdbarch.h.
1216         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1217         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1218         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1219         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1220         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1221         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1222         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1223         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1224         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1225         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1226         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1227         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1228         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1229         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1230         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1231         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1232         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1233         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1234         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1235         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1236         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1237         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1238         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1239         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1240         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1241         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1242         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1243
1244 2019-07-10  Tom Tromey  <tromey@adacore.com>
1245
1246         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1247         * breakpoint.c (init_ada_exception_breakpoint): Register as
1248         bp_catchpoint.
1249         (print_one_breakpoint_location, print_one_breakpoint): Use
1250         is_ada_exception_catchpoint.
1251         * ada-lang.c (class ada_catchpoint_location): Pass
1252         bp_loc_software_breakpoint to bp_location constructor.
1253         (is_ada_exception_catchpoint): New function.
1254
1255 2019-07-10  Tom Tromey  <tromey@adacore.com>
1256
1257         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1258         VEC.
1259         (struct arm_exidx_entry): New method operator<.
1260         (struct arm_exidx_data) <section_maps>: Change type.
1261         (arm_exidx_data_free): Remove.
1262         (arm_exidx_data_key): Change type.  Move lower.
1263         (arm_exidx_new_objfile): Update.
1264         (arm_compare_exidx_entries): Remove.
1265         (arm_find_exidx_entry, _initialize_arm_tdep)
1266
1267 2019-07-10  Tom Tromey  <tromey@adacore.com>
1268
1269         * solib-spu.c (ocl_program_data_key): Change type.
1270         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1271         Update.
1272
1273 2019-07-10  Tom Tromey  <tromey@adacore.com>
1274
1275         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1276         (struct solib_aix_inferior_data) <library_list>: Change type.
1277         (solib_aix_inferior_data_handle): Change type.
1278         (get_solib_aix_inferior_data): Update.
1279         (solib_aix_free_library_list): Remove.
1280         (library_list_start_library): Update.
1281         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1282         return type.
1283         (solib_aix_get_library_list)
1284         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1285         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1286
1287 2019-07-10  Tom Tromey  <tromey@adacore.com>
1288
1289         * solib-dsbt.c (struct dsbt_info): Add initializers.
1290         (solib_dsbt_pspace_data): Change type.
1291         (dsbt_pspace_data_cleanup): Remove.
1292         (get_dsbt_info, _initialize_dsbt_solib): Update.
1293
1294 2019-07-10  Tom Tromey  <tromey@adacore.com>
1295
1296         * spu-tdep.c (spu_overlay_data): Change type.
1297         (spu_get_overlay_table, spu_overlay_new_objfile)
1298         (_initialize_spu_tdep): Update.
1299
1300 2019-07-10  Tom Tromey  <tromey@adacore.com>
1301
1302         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1303         destructor.
1304         (dbx_objfile_data_key): Change type and declare later.
1305         (DBX_SYMFILE_INFO): Rewrite.
1306         * dbxread.c (dbx_objfile_data_key): Change type.
1307         (dbx_symfile_init): Update.
1308         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1309         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1310         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1311
1312 2019-07-10  Tom Tromey  <tromey@adacore.com>
1313
1314         * jit.c (jit_program_space_key): Change type.  Move lower.
1315         (get_jit_program_space_data): Update.
1316         (jit_program_space_data_cleanup): Remove.
1317         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1318         Update.
1319         (struct jit_program_space_data): Add initializers.
1320
1321 2019-07-10  Tom Tromey  <tromey@adacore.com>
1322
1323         * solib-darwin.c (struct darwin_info): Add initializers.
1324         (solib_darwin_pspace_data): Change type.
1325         (darwin_pspace_data_cleanup): Remove.
1326         (get_darwin_info, _initialize_darwin_solib): Update.
1327
1328 2019-07-10  Tom Tromey  <tromey@adacore.com>
1329
1330         * remote-sim.c (struct sim_inferior_data): Add initializers,
1331         constructor, and destructor.
1332         (sim_inferior_data_key): Change type.  Move lower.
1333         (check_for_duplicate_sim_descriptor): Update.
1334         (get_sim_inferior_data): Use new.  Update.
1335         (~sim_inferior_data_cleanup): Rename from
1336         sim_inferior_data_cleanup.  Simplify.
1337         (gdbsim_close_inferior, simulator_command)
1338         (sim_command_completer, _initialize_remote_sim): Update.
1339         (next_pid, INITIAL_PID): Move earlier.
1340
1341 2019-07-10  Tom Tromey  <tromey@adacore.com>
1342
1343         * python/python-internal.h (create_thread_object): Return
1344         gdbpy_ref.
1345         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1346         * python/py-inferior.c (struct threadlist_entry): Add
1347         constructor.
1348         <thread_obj>: Now a gdbpy_ref.
1349         (thread_to_thread_object): Update.
1350         (add_thread_object): Use new.
1351         (delete_thread_object): Use delete.
1352         (infpy_threads): Update.
1353         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1354         GIL.
1355
1356 2019-07-10  Tom Tromey  <tromey@adacore.com>
1357
1358         * valops.c (value_cast): Specialize error message for Ada.
1359
1360 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1361
1362         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1363
1364 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1365
1366         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1367         bpstat_should_step): Return bool, adjust comments.
1368         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1369         bpstat_should_step): Likewise.
1370
1371 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1372
1373         * features/Makefile: Use feature target descriptions for Arm.
1374         * features/arm/arm-core.c: Generate new file.
1375         * features/arm/arm-fpa.c: Likewise.
1376         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1377         * features/arm/arm-m-profile.c: Likewise.
1378         * features/arm/arm-vfpv2.c: Likewise.
1379         * features/arm/arm-vfpv3.c: Likewise.
1380         * features/arm/xscale-iwmmxt.c: Likewise.
1381         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1382
1383 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1384
1385         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1386         ptrace earlier.
1387
1388 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1389
1390         * features/aarch64-pauth.c: Regenerate.
1391
1392 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1393
1394         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1395         bool.
1396         (bpstat_what): Use false instead of 0.
1397
1398 2019-07-09  Pedro Alves  <palves@redhat.com>
1399
1400         * break-catch-throw.c (is_exception_catchpoint): New.
1401         * breakpoint.c (print_one_breakpoint_location): New parameter
1402         'raw_loc'.  Handle it.  Use
1403         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1404         looking at the breakpoint's type.
1405         (print_one_breakpoint): If handling "maint info breakpoints", also
1406         print locations of exception catchpoints.
1407         * breakpoint.h (is_exception_catchpoint): Declare.
1408
1409 2019-07-09  Pedro Alves  <palves@redhat.com>
1410
1411         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1412         "addr" field.
1413         (allocate_location_exception_catchpoint): New.
1414         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1415         (initialize_throw_catchpoint_ops): Install
1416         allocate_location_exception_catchpoint as allocate_location
1417         method.
1418         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1419         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1420         bp_loc_other.
1421         (breakpoint_address_is_meaningful): Delete.
1422         (bl_address_is_meaningful): New.
1423         (breakpoint_locations_match): Adjust comment.
1424         (bp_location_from_bp_type): New, factored out of...
1425         (bp_location::bp_location(breakpoint *)): ... this.
1426         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1427         factored out of...
1428         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1429         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1430         breakpoint_address_is_meaningful.
1431         (bp_locations_compare): Adjust comment.
1432         (update_global_location_list): Use bl_address_is_meaningful
1433         instead of breakpoint_address_is_meaningful.
1434         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1435         explicit.
1436         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1437         * python/py-breakpoint.c (bppy_get_location): No longer check
1438         whether location is null.
1439
1440 2019-07-09  Pedro Alves  <palves@redhat.com>
1441
1442         PR c++/15468
1443         * breakpoint.c (print_one_breakpoint_location): Remove
1444         single-location assert.
1445
1446 2019-07-09  Tom Tromey  <tom@tromey.com>
1447
1448         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1449         * configure: Rebuild.
1450         * configure.ac: Change common to gdbsupport.
1451         * gdbsupport: Rename from common.
1452         * acinclude.m4: Change common to gdbsupport.
1453         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1454         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1455         gdbsupport.
1456         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1457         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1458         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1459         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1460         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1461         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1462         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1463         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1464         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1465         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1466         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1467         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1468         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1469         coff-pe-read.c, command.h, compile/compile-c-support.c,
1470         compile/compile-c.h, compile/compile-cplus-symbols.c,
1471         compile/compile-cplus-types.c, compile/compile-cplus.h,
1472         compile/compile-loc2c.c, compile/compile.c, completer.c,
1473         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1474         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1475         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1476         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1477         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1478         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1479         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1480         features/aarch64-core.c, features/aarch64-fpu.c,
1481         features/aarch64-pauth.c, features/aarch64-sve.c,
1482         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1483         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1484         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1485         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1486         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1487         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1488         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1489         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1490         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1491         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1492         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1493         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1494         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1495         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1496         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1497         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1498         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1499         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1500         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1501         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1502         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1503         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1504         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1505         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1506         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1507         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1508         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1509         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1510         minsyms.c, mips-linux-tdep.c, namespace.h,
1511         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1512         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1513         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1514         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1515         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1516         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1517         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1518         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1519         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1520         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1521         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1522         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1523         procfs.c, producer.c, progspace.h, psymtab.h,
1524         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1525         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1526         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1527         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1528         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1529         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1530         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1531         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1532         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1533         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1534         target-memory.c, target.c, target.h, target/waitstatus.c,
1535         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1536         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1537         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1538         unittests/array-view-selftests.c,
1539         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1540         unittests/common-utils-selftests.c,
1541         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1542         unittests/format_pieces-selftests.c,
1543         unittests/function-view-selftests.c,
1544         unittests/lookup_name_info-selftests.c,
1545         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1546         unittests/mkdir-recursive-selftests.c,
1547         unittests/observable-selftests.c,
1548         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1549         unittests/parse-connection-spec-selftests.c,
1550         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1551         unittests/scoped_fd-selftests.c,
1552         unittests/scoped_mmap-selftests.c,
1553         unittests/scoped_restore-selftests.c,
1554         unittests/string_view-selftests.c, unittests/style-selftests.c,
1555         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1556         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1557         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1558         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1559         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1560         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1561
1562 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1563
1564         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1565         bool value.
1566         (decode_digits_ordinary): Set explicit_line field in sal.
1567         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1568         symtab_and_line that was set on an explicit line number in
1569         assembler code.  Do always update the recorded symtab and line if
1570         we do skip the prologue.
1571
1572 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1573
1574         * breakpoint.c (set_breakpoint_location_function): Remove
1575         explicit_loc parameter.
1576         (momentary_breakpoint_from_master): Update call to
1577         set_breakpoint_location_function.
1578         (add_location_to_breakpoint): Likewise.
1579
1580 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1581
1582         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1583         required features based on default bfd type when no specific bfd
1584         is present.
1585
1586 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1587
1588         * NEWS: Mention that GDB printf and eval commands can now print
1589         C-style and Ada-style convenience var strings without
1590         calling the inferior.
1591         * printcmd.c (printf_c_string): Locally print GDB internal var
1592         instead of transiting via the inferior.
1593         (printf_wide_c_string): Likewise.
1594
1595 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1596
1597         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1598
1599 2019-07-04  Tom Tromey  <tom@tromey.com>
1600
1601         PR tui/24724:
1602         * tui/tui-winsource.c (tui_clear_source_content): Update.
1603         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1604         (tui_update_breakpoint_info): Update.
1605         (tui_set_exec_info_content): Update.
1606         * tui/tui-source.c (tui_set_source_content_nil): Update.
1607         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1608         has_break.
1609         * tui/tui-data.h (enum tui_bp_flag): New.
1610         (tui_bp_flags): New enum flags type.
1611         (struct tui_source_element) <break_mode>: Change type.  Rename
1612         from has_break.
1613         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1614         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1615         constants.
1616         * tui/tui-winsource.h: Fix comment.
1617
1618 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1619
1620         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1621         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1622         (store_fpregs_to_thread)
1623         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1624         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1625         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1626         (IWMMXT_REGS_SIZE): Add define.
1627         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1628         (fetch_vfp_regs, store_vfp_regs)
1629         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1630         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1631
1632 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1633
1634         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1635         defines.
1636         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1637         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1638         (ARM_INT_REGISTER_SIZE): ...to this.
1639         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1640         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1641         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1642         (arm_linux_collect_gregset, supply_nwfpe_register)
1643         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1644         defines.
1645         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1646         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1647         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1648         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1649         (arm_return_in_memory, arm_store_return_value)
1650         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1651         (arm_record_ld_st_multiple): Likewise.
1652         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1653         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1654
1655 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1656
1657         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1658         AARCH64_DISPLACED_MODIFIED_INSNS.
1659         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1660         (aarch64_displaced_step_copy_insn): Likewise.
1661         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1662         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1663         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1664         ARM_DISPLACED_MODIFIED_INSNS.
1665         * arm-tdep.c (arm_gdbarch_init): Likewise.
1666         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1667         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1668         (struct arm_displaced_step_closure): Use
1669         ARM_DISPLACED_MODIFIED_INSNS.
1670
1671 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1672
1673         * features/Makefile: Remove unused xml files.
1674         * features/aarch64.xml: Remove.
1675         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1676         * features/i386/amd64-avx-avx512.xml: Remove.
1677         * features/i386/amd64-avx-linux.xml: Remove.
1678         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1679         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1680         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1681         * features/i386/amd64-avx-mpx.xml: Remove.
1682         * features/i386/amd64-avx.xml: Remove.
1683         * features/i386/amd64-linux.xml: Remove.
1684         * features/i386/amd64-mpx-linux.xml: Remove.
1685         * features/i386/amd64-mpx.xml: Remove.
1686         * features/i386/amd64.xml: Remove.
1687         * features/i386/i386-avx-avx512-linux.xml: Remove.
1688         * features/i386/i386-avx-avx512.xml: Remove.
1689         * features/i386/i386-avx-linux.xml: Remove.
1690         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1691         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1692         * features/i386/i386-avx-mpx-linux.xml: Remove.
1693         * features/i386/i386-avx-mpx.xml: Remove.
1694         * features/i386/i386-avx.xml: Remove.
1695         * features/i386/i386-linux.xml: Remove.
1696         * features/i386/i386-mmx-linux.xml: Remove.
1697         * features/i386/i386-mmx.xml: Remove.
1698         * features/i386/i386-mpx-linux.xml: Remove.
1699         * features/i386/i386-mpx.xml: Remove.
1700         * features/i386/i386.xml: Remove.
1701         * features/i386/x32-avx-avx512-linux.xml: Remove.
1702         * features/i386/x32-avx-linux.xml: Remove.
1703         * features/i386/x32-linux.xml: Remove.
1704
1705 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1706
1707         * regformats/aarch64.dat: Remove.
1708         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1709         * regformats/i386/amd64-avx-linux.dat: Remove.
1710         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1711         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1712         * regformats/i386/amd64-linux.dat: Remove.
1713         * regformats/i386/amd64-mpx-linux.dat: Remove.
1714         * regformats/i386/amd64.dat: Remove.
1715         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1716         * regformats/i386/i386-avx-linux.dat: Remove.
1717         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1718         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1719         * regformats/i386/i386-linux.dat: Remove.
1720         * regformats/i386/i386-mmx-linux.dat: Remove.
1721         * regformats/i386/i386-mpx-linux.dat: Remove.
1722         * regformats/i386/i386.dat: Remove.
1723         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1724         * regformats/i386/x32-avx-linux.dat: Remove.
1725         * regformats/i386/x32-linux.dat: Remove.
1726
1727 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1728
1729         * aarch64-tdep.c: Remove xml self tests.
1730         * amd64-linux-tdep.c: Likewise.
1731         * amd64-tdep.c: Likewise.
1732         * i386-linux-tdep.c: Likewise.
1733         * i386-tdep.c: Likewise.
1734
1735 2019-07-03  Pedro Alves  <palves@redhat.com>
1736
1737         PR cli/24732
1738         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1739         (pipe_cmd_option_defs): New.
1740         (make_pipe_cmd_options_def_group): New.
1741         (pipe_command): Use gdb::option::process_options.
1742         (pipe_command_completer): New function.
1743         (_initialize_cli_cmds): Install completer for "pipe" command.
1744
1745 2019-07-03  Pedro Alves  <palves@redhat.com>
1746
1747         * cli/cli-option.c (union option_value) <string>: New field.
1748         (struct option_def_and_value): Add ctor, move ctor, dtor and
1749         use DISABLE_COPY_AND_ASSIGN.
1750         (option_def_and_value::clear_value): New.
1751         (parse_option, save_option_value_in_ctx, get_val_type_str)
1752         (add_setshow_cmds_for_options): Handle var_string.
1753         * cli-option.h (union option_def::var_address) <string>: New
1754         field.
1755         (struct string_option_def): New.
1756         * maint-test-options.c (struct test_options_opts): Add default
1757         ctor and use DISABLE_COPY_AND_ASSIGN.
1758         <string_opt>: New field.
1759         (test_options_opts::~test_options_opts): New.
1760         (test_options_opts::dump): Also dump "-string".
1761         (test_options_option_defs): Install "string.
1762
1763 2019-07-03  Pedro Alves  <palves@redhat.com>
1764
1765         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1766         option_value with a null enumeration.
1767         (complete_options): Save the option values in the context.
1768         (save_option_value_in_ctx): New, factored out from ...
1769         (process_options): ... here.
1770         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1771         of the function.
1772         * maint-test-options.c (test_options_opts::dump): New, factored
1773         out from ...
1774         (maintenance_test_options_command_mode): ... here.
1775         (maintenance_test_options_command_completion_result): Delete.
1776         (maintenance_test_options_command_completion_text): Update
1777         comment.
1778         (maintenance_show_test_options_completion_result): Change
1779         prototype.  Just print
1780         maintenance_test_options_command_completion_text.
1781         (save_completion_result): New.
1782         (maintenance_test_options_completer_mode): Pass options context to
1783         complete_options, and then save a dump.
1784         (_initialize_maint_test_options): Use add_cmd to install "maint
1785         show test-options-completion-result".
1786
1787 2019-07-03  Pedro Alves  <palves@redhat.com>
1788
1789         * NEWS (New commands): Mention "with" and "maint with".
1790         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1791         (with_command, with_command_completer): New.
1792         (pipe_command): Adjust to new repeat_previous
1793         interface.
1794         (_initialize_cli_cmds): Install the "with" command and its "w"
1795         alias.
1796         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1797         declarations.
1798         * cli/cli-setshow.c (parse_cli_var_uinteger)
1799         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1800         argument strings for all var_types.
1801         (get_setshow_command_value_string): New, factored out from ...
1802         (do_show_command): ... this.
1803         * cli/cli-setshow.h: Include <string>.
1804         (get_setshow_command_value_string): Declare.
1805         * command.h (repeat_previous): Now returns const char *.  Adjust
1806         comment.
1807         * maint.c: Include "cli/cli-cmds.h".
1808         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1809         (_initialize_maint_cmds): Register the "maintenance with" command.
1810         * top.c (repeat_previous): Move bits from pipe_command here:
1811         Return the saved command line, if any; error out if there's no
1812         command to relaunch.
1813
1814 2019-07-03  Pedro Alves  <palves@redhat.com>
1815
1816         * NEWS (New commands): Mention "maint set/show test-settings"
1817         instead of "maint test-settings".
1818         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1819         (maintenance_test_settings_set_list): Rename to ...
1820         (maintenance_set_test_settings_list): ... this.
1821         (maintenance_test_settings_show_list): Rename to  ...
1822         (maintenance_show_test_settings_list): ... this.
1823         (maintenance_test_settings_cmd): Delete.
1824         (maintenance_test_settings_set_cmd): ...
1825         (maintenance_set_test_settings_cmd): ... this.
1826         (maintenance_test_settings_show_cmd): ...
1827         (maintenance_show_test_settings_cmd): ... this.
1828         (maintenance_test_settings_show_value_cmd):
1829         (maintenance_show_test_settings_value_cmd): ... this.
1830         (_initialize_maint_test_settings): No longer install the "maint
1831         test-settings" prefix command.  Rename "maint test-settings set"
1832         to "maint set test-settings", and "maint test-settings show" to
1833         "maint show test-settings".  Adjust all subcommands.
1834
1835 2019-07-03  Pedro Alves  <palves@redhat.com>
1836
1837         * maint-test-settings.c: Fix file's intro comment.  Replace all
1838         references to "test-options" with references to "test-settings",
1839         in comments.
1840
1841 2019-07-03  Pedro Alves  <palves@redhat.com>
1842
1843         * maint-test-settings.c (maintenance_test_settings_xxx)
1844         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1845         New.
1846         (maintenance_test_settings_enums): Use them.
1847         (maintenance_test_settings_enum): Default to
1848         maintenance_test_settings_xxx.
1849         (_initialize_maint_test_settings): Initialize
1850         MAINTENANCE_TEST_SETTINGS_FILENAME.
1851
1852 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1853
1854         * breakpoint.h (remove_breakpoints_inf): Change return type to
1855         void, move function documentation here.
1856         * breakpoint.c (remove_breakpoints_inf): Change return type to
1857         void, move function documentation to header.
1858
1859 2019-07-02  Pedro Alves  <palves@redhat.com>
1860
1861         * NEWS (Completion improvements): Mention "info threads".
1862         * thread.c (struct info_threads_opts, info_threads_option_defs)
1863         (make_info_threads_options_def_group): New.
1864         (info_threads_command): Use gdb::option::process_options.
1865         (info_threads_command_completer): New.
1866         (_initialize_thread): Use gdb::option::build_help to build the
1867         help text for "info threads".
1868
1869 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1870
1871         * defs.h (generic_load): Move from here...
1872         * symfile.h (generic_load): ... to here.  Rename name parameter
1873         to args.
1874         * symfile.c (generic_load): Add comment.
1875
1876 2019-07-01  Tom Tromey  <tromey@adacore.com>
1877
1878         * dwarf2read.c
1879         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1880         declaration of without_params.  Fix formatting.
1881
1882 2019-07-01  Tom Tromey  <tromey@adacore.com>
1883
1884         * ada-exp.y (find_primitive_type): Update.
1885         * ada-lang.h (ada_lookup_symbol): Update.
1886         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1887         parameter.
1888         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1889
1890 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1891
1892         PR breakpoints/24541
1893         * gdbarch.c: Regenerate.
1894         * gdbarch.h: Regenerate.
1895         * gdbarch.sh: Add 'stap_adjust_register'.
1896         * i386-tdep.c: Include '<unordered_set>'.
1897         (i386_stap_adjust_register): New function.
1898         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1899         * stap-probe.c (stap_parse_register_operand): Call
1900         'gdbarch_stap_adjust_register'.
1901
1902 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1903
1904         PR python/24742
1905         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1906         * python/python.c (do_start_initialization): Use 'xmalloc'
1907         instead of 'PyMem_Malloc'.
1908
1909 2019-06-28  Tom Tromey  <tromey@adacore.com>
1910
1911         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1912         for Ada.
1913
1914 2019-06-27  Tom Tromey  <tromey@adacore.com>
1915
1916         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1917         objfile_key.
1918         (arm_find_mapping_symbol, arm_record_special_symbol)
1919         (_initialize_arm_tdep): Update.
1920         (arm_objfile_data_free): Remove.
1921
1922 2019-06-27  Tom Tromey  <tromey@adacore.com>
1923
1924         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1925         to cp_print_static_field.
1926
1927 2019-06-26  Tom Tromey  <tromey@adacore.com>
1928
1929         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1930         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1931         declare.
1932
1933 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1934
1935         * features/aarch64-core.c (create_feature_aarch64_core):
1936         Regenerate.
1937         * features/aarch64-core.xml: Add cpsr flags.
1938
1939 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1940
1941         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1942         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1943
1944 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1945
1946         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1947         field.
1948         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1949         use.
1950         (arm_record_special_symbol): Don't insert new symbol in sorted
1951         position, push it at the end.
1952
1953 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1954
1955         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1956         (arm_mapping_symbol_s): Remove.
1957         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1958         (arm_mapping_symbol_vec): New typedef.
1959         (struct arm_per_objfile): Add constructor.
1960         <section_maps>: Change type to
1961         std::unique_ptr<arm_mapping_symbol_vec[]>.
1962         (arm_compare_mapping_symbols): Remove.
1963         (arm_find_mapping_symbol): Adjust to section_maps type change.
1964         (arm_objfile_data_free): Call delete on arm_per_objfile.
1965         (arm_record_special_symbol): Adjust to section_maps type change.
1966         Allocate arm_per_objfile with new.
1967
1968 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1969
1970         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1971         with the command prefix.
1972
1973 2019-06-25  Tom Tromey  <tom@tromey.com>
1974
1975         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1976         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1977
1978 2019-06-25  Tom Tromey  <tom@tromey.com>
1979
1980         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1981         type.
1982         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1983         protected.
1984
1985 2019-06-25  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-winsource.c
1988         (tui_source_window_base::set_is_exec_point_at): Add check against
1989         LOA_ADDRESS.
1990
1991 2019-06-25  Tom Tromey  <tom@tromey.com>
1992
1993         * tui/tui-source.c (tui_set_source_content): Don't check before
1994         xfree.
1995         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1996
1997 2019-06-25  Tom Tromey  <tom@tromey.com>
1998
1999         * tui/tui-winsource.h (tui_update_source_window_as_is)
2000         (tui_alloc_source_buffer, tui_line_is_displayed)
2001         (tui_addr_is_displayed): Change type of win_info.
2002         * tui/tui-winsource.c (tui_update_source_window_as_is)
2003         (tui_clear_source_content, tui_show_source_line)
2004         (tui_show_source_content, tui_source_window_base::refill)
2005         (tui_source_window_base::set_is_exec_point_at)
2006         (tui_source_window_base::set_is_exec_point_at)
2007         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2008         (tui_alloc_source_buffer, tui_line_is_displayed)
2009         (tui_addr_is_displayed): Change type of win_info.  Update.
2010         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2011         (tui_source_window_base::do_make_visible_with_new_height):
2012         Update.
2013         * tui/tui-source.c (tui_set_source_content)
2014         (tui_set_source_content_nil)
2015         (tui_source_window::do_scroll_vertical): Update.
2016         * tui/tui-layout.c (show_layout): Update.
2017         * tui/tui-disasm.c (tui_set_disassem_content)
2018         (tui_disasm_window::do_scroll_vertical): Update.
2019         * tui/tui-data.h (tui_win_content): Remove.
2020         (struct tui_gen_win_info) <content, content_size>: Remove.
2021         (struct tui_source_element): Add initializers and destructor.
2022         (union tui_which_element, struct tui_win_element): Remove.
2023         (struct tui_source_window_base) <content>: New field.
2024         (struct tui_data_window): Remove destructor.
2025         (tui_alloc_content, tui_free_win_content)
2026         (tui_free_all_source_wins_content): Don't declare.
2027         * tui/tui-data.c (tui_initialize_static_data): Update.
2028         (init_content_element, tui_alloc_content): Remove.
2029         (~tui_gen_win_info): Update.
2030         (~tui_data_window, tui_free_all_source_wins_content)
2031         (tui_free_win_content, free_content, free_content_elements):
2032         Remove.
2033
2034 2019-06-25  Tom Tromey  <tom@tromey.com>
2035
2036         * tui/tui-winsource.h (tui_clear_source_content)
2037         (tui_erase_source_content, tui_show_source_content): Change type
2038         of win_info.
2039         * tui/tui-winsource.c (tui_clear_source_content)
2040         (tui_erase_source_content, tui_show_source_content): Change type
2041         of win_info.
2042         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2043         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2044         win_info.
2045         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2046         win_info.
2047         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2048
2049 2019-06-25  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-winsource.c (tui_clear_source_content)
2052         (tui_source_window_base::set_is_exec_point_at): Update.
2053         * tui/tui-source.c (tui_set_source_content_nil): Update.
2054         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2055         a bool.
2056         * tui/tui-data.c (init_content_element): Update.
2057
2058 2019-06-25  Tom Tromey  <tom@tromey.com>
2059
2060         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2061         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2062         * tui/tui-layout.c (init_and_make_win): Update.
2063         * tui/tui.h (enum tui_win_type): Update.
2064         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2065         tui_win_is_auxillary.
2066         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2067         tui_win_is_auxillary.
2068
2069 2019-06-25  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2072         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2073         (tui_delete_data_content_windows, tui_display_all_data)
2074         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2075         Update.
2076         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2077         * tui/tui-regs.c (tui_last_regs_line_no)
2078         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2079         (tui_show_registers): Update.
2080         (tui_show_register_group): Return void.  Update.
2081         (tui_display_registers_from, tui_display_reg_element_at_line)
2082         (tui_display_registers_from_line, tui_check_register_values):
2083         Update.
2084         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2085         member.
2086         (struct tui_data_window) <regs_content>: Now a std::vector.
2087         <regs_content_count>: Remove.
2088         (tui_add_content_elements, tui_free_data_content): Don't declare.
2089         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2090         (init_content_element): Remove DATA_WIN case.  Add assert.
2091         (tui_add_content_elements): Remove.
2092         (tui_data_window): Update.
2093         (tui_free_data_content): Remove.
2094         (free_content_elements): Remove DATA_WIN case.
2095
2096 2019-06-25  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-data.c (tui_data_item_window): Update.
2099         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2100         * tui/tui-windata.c (tui_display_all_data)
2101         (tui_display_data_from_line): Update.
2102         (tui_check_data_values): Remove.
2103         * tui/tui-regs.c (tui_show_register_group)
2104         (tui_display_reg_element_at_line): Update.
2105         * tui/tui-hooks.c (tui_register_changed)
2106         (tui_refresh_frame_and_register_information): Call
2107         tui_check_register_values.
2108         * tui/tui-data.h (struct tui_data_window) <data_content,
2109         data_content_count, data_type>: Remove.
2110         (enum tui_data_type): Remove.
2111
2112         * tui/tui-data.c (tui_data_window::clear_detail)
2113         (~tui_data_window): Update.
2114
2115 2019-06-25  Tom Tromey  <tom@tromey.com>
2116
2117         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2118         declare.
2119         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2120         Rename from tui_first_data_item_displayed.  Update.
2121         (tui_data_window::refresh_all)
2122         (tui_data_window::do_scroll_vertical): Update.
2123         * tui/tui-data.h (struct tui_data_window)
2124         <first_data_item_displayed>: Declare new method.
2125
2126 2019-06-25  Tom Tromey  <tom@tromey.com>
2127
2128         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2129         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2130         contents...
2131         (tui_initialize_static_data): ...here.
2132
2133 2019-06-25  Tom Tromey  <tom@tromey.com>
2134
2135         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2136         (tui_display_registers_from, tui_check_register_values): Update.
2137         (tui_display_register): Remove win_info parameter; update.
2138         (tui_get_register): Change type of parameters.
2139         * tui/tui-data.h (struct tui_data_element): Remove.
2140         (union tui_which_element) <data>: Remove.
2141         <data_window>: Change type.
2142         (struct tui_data_item_window): New.
2143         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2144         case.  Add assert.
2145         (~tui_data_item_window): New destructor.
2146         (free_content_elements): Remove DATA_ITEM_WIN case.
2147
2148 2019-06-25  Tom Tromey  <tom@tromey.com>
2149
2150         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2151         Remove.
2152
2153 2019-06-25  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-data.h (struct tui_command_element): Remove.
2156         (union tui_which_element) <command>: Remove.
2157         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2158         assert.
2159         (free_content_elements): Remove CMD_WIN case.
2160
2161 2019-06-25  Tom Tromey  <tom@tromey.com>
2162
2163         * tui/tui-layout.c (tui_set_layout): Update.
2164         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2165         * tui/tui-data.c (layout_def): Update.
2166
2167 2019-06-25  Tom Tromey  <tom@tromey.com>
2168
2169         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2170         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2171         (tui_source_window_base::set_new_height): Update.
2172         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2173         Update.
2174         (tui_set_locator_fullname, tui_set_locator_info)
2175         (tui_show_frame_info): Update.
2176         * tui/tui-source.c (tui_set_source_content)
2177         (tui_source_is_displayed): Update.
2178         * tui/tui-layout.c (show_source_disasm_command, show_data)
2179         (show_source_or_disasm_and_command): Update.
2180         * tui/tui-disasm.c (tui_set_disassem_content)
2181         (tui_get_begin_asm_address): Update.
2182         * tui/tui-data.h (struct tui_locator_element): Remove.
2183         (union tui_which_element) <locator>: Remove.
2184         (struct tui_locator_window): New.
2185         (tui_locator_win_info_ptr): Change return type.
2186         * tui/tui-data.c (_locator): Change type.
2187         (tui_locator_win_info_ptr): Change return type.
2188         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2189         (tui_alloc_content): Add assert.
2190
2191 2019-06-25  Tom Tromey  <tom@tromey.com>
2192
2193         * tui/tui-winsource.c
2194         (tui_exec_info_window::maybe_allocate_content): New method.
2195         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2196         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2197         (make_source_or_disasm_window): Add cast.
2198         * tui/tui-data.h (union tui_which_element) <simple_string>:
2199         Remove.
2200         (struct tui_source_info): New.
2201         (struct tui_source_window_base) <execution_info>: Change type.
2202         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2203         case, and add assert.
2204         (tui_alloc_content): Add assert.
2205
2206 2019-06-25  Tom Tromey  <tom@tromey.com>
2207
2208         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2209         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2210         * tui/tui-data.c (tui_alloc_win_info): Remove.
2211
2212 2019-06-25  Tom Tromey  <tom@tromey.com>
2213
2214         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2215         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2216         can_highlight.
2217
2218 2019-06-25  Tom Tromey  <tom@tromey.com>
2219
2220         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2221         make_visible_with_new_height method.
2222         (tui_win_info::make_visible_with_new_height): New method.
2223         (tui_source_window_base::do_make_visible_with_new_height)
2224         (tui_data_window::do_make_visible_with_new_height)
2225         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2226         (make_visible_with_new_height): Remove.
2227         (tui_resize_all, tui_adjust_win_heights): Use
2228         make_visible_with_new_height method.
2229         * tui/tui-data.h (struct tui_win_info)
2230         <do_make_visible_with_new_height, make_visible_with_new_height>:
2231         New methods.
2232         (struct tui_source_window_base, struct tui_data_window)
2233         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2234         methods.
2235
2236 2019-06-25  Tom Tromey  <tom@tromey.com>
2237
2238         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2239         method.
2240         (update_tab_width): Call update_tab_width method.
2241         * tui/tui-data.h (struct tui_win_info)
2242         (struct tui_source_window_base) <update_tab_width>: New methods.
2243
2244 2019-06-25  Tom Tromey  <tom@tromey.com>
2245
2246         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2247         parameter.
2248         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2249         parameter.
2250         (tui_gen_win_info::make_visible): Update.
2251         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2252         parameter.
2253         * tui/tui-data.h (enum tui_box): New enum.
2254         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2255
2256 2019-06-25  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2259         init_and_make_win for EXEC_INFO_WIN.
2260         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2261         longer inline.
2262         (struct tui_win_info) <~tui_win_info>: Inline.
2263         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2264         Don't declare.
2265         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2266         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2267         Remove.
2268         (tui_initialize_static_data): Update.
2269         (~tui_gen_win_info): Handle more cleanup here.
2270         (~tui_source_window_base): Delete "execution_info".
2271         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2272
2273 2019-06-25  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-layout.c (make_command_window): Don't set
2276         can_highlight.
2277         (show_source_disasm_command): Call the reset method.
2278         (show_data): Don't set can_highlight.  Call the reset method.
2279         (tui_gen_win_info::reset): Rename from init_gen_win_info
2280         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2281         (show_source_or_disasm_and_command): Call the reset method.
2282         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2283         (struct tui_cmd_window): Set can_highlight.
2284
2285 2019-06-25  Tom Tromey  <tom@tromey.com>
2286
2287         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2288         from make_visible.
2289         (tui_make_visible, tui_make_invisible): Rewrite.
2290         (tui_win_info::make_visible): Remove.
2291         (tui_source_window_base::make_visible): Update.
2292         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2293         method.  Moved from...
2294         (struct tui_win_info) <make_visible>: ...here.
2295
2296 2019-06-25  Tom Tromey  <tom@tromey.com>
2297
2298         * tui/tui-winsource.c
2299         (tui_source_window_base::do_scroll_horizontal): Remove direction
2300         parameter.
2301         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2302         direction parameter.
2303         * tui/tui-win.c (tui_win_info::forward_scroll)
2304         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2305         (tui_win_info::right_scroll): Update.
2306         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2307         direction parameter.
2308         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2309         direction parameter.
2310         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2311         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2312         Remove direction parameter.
2313         (struct tui_source_window_base, struct tui_source_window)
2314         (struct tui_disasm_window, struct tui_data_window)
2315         (struct tui_cmd_window): Update.
2316
2317 2019-06-25  Tom Tromey  <tom@tromey.com>
2318
2319         * tui/tui-winsource.h (tui_set_exec_info_content)
2320         (tui_show_exec_info_content, tui_erase_exec_info_content)
2321         (tui_clear_exec_info_content, tui_update_exec_info): Change
2322         argument to tui_source_window_base.
2323         * tui/tui-winsource.c (tui_set_exec_info_content)
2324         (tui_show_exec_info_content, tui_erase_exec_info_content)
2325         (tui_clear_exec_info_content, tui_update_exec_info): Change
2326         argument to tui_source_window_base.
2327
2328 2019-06-25  Tom Tromey  <tom@tromey.com>
2329
2330         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2331         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2332
2333 2019-06-25  Tom Tromey  <tom@tromey.com>
2334
2335         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2336         check.
2337
2338 2019-06-25  Tom Tromey  <tom@tromey.com>
2339
2340         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2341         type to void.
2342         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2343         type to void.
2344         * tui/tui-source.c (tui_set_source_content): Update.
2345         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2346
2347 2019-06-25  Tom Tromey  <tom@tromey.com>
2348
2349         * tui/tui-win.c (window_name_completer, tui_set_focus)
2350         (tui_all_windows_info): Use name method.
2351         * tui/tui-data.h (struct tui_gen_win_info)
2352         (struct tui_source_window, struct tui_disasm_window)
2353         (struct tui_data_window, struct tui_cmd_window) <name>: New
2354         method.
2355         (tui_win_name): Don't declare.
2356         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2357         (tui_win_name): Remove.
2358
2359 2019-06-25  Tom Tromey  <tom@tromey.com>
2360
2361         * tui/tui-winsource.h (tui_update_source_window)
2362         (tui_update_source_window_as_is): Change parameter type.
2363         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2364         to be a tui_source_window_base.
2365         (tui_update_source_window_as_is): Likewise.
2366         * tui/tui-win.c (make_visible_with_new_height): Update.
2367
2368 2019-06-25  Tom Tromey  <tom@tromey.com>
2369
2370         * tui/tui-winsource.c (tui_erase_source_content)
2371         (tui_show_source_content, tui_show_exec_info_content)
2372         (tui_erase_exec_info_content): Use refresh_window method.
2373         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2374         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2375         from tui_refresh_win.
2376         (tui_data_window::refresh_window): New method.
2377         (tui_win_info::refresh, tui_source_window_base::refresh)
2378         (tui_refresh_all): Use refresh_window method.
2379         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2380         method.
2381         * tui/tui-regs.c (tui_display_register): Call refresh_window
2382         method.
2383         * tui/tui-layout.c (show_source_disasm_command)
2384         (show_source_or_disasm_and_command): Call refresh_window method.
2385         * tui/tui-data.h (struct tui_gen_win_info)
2386         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2387         New method.
2388
2389 2019-06-25  Tom Tromey  <tom@tromey.com>
2390
2391         * tui/tui.c (tui_rl_other_window, tui_enable)
2392         (tui_is_window_visible, tui_get_command_dimension): Update.
2393         * tui/tui-winsource.c (tui_update_source_window_as_is)
2394         (tui_clear_source_content, tui_erase_source_content)
2395         (tui_show_source_line, tui_source_window_base::refill)
2396         (tui_source_window_base::do_scroll_horizontal)
2397         (tui_source_window_base::set_is_exec_point_at)
2398         (tui_update_breakpoint_info, tui_set_exec_info_content)
2399         (tui_alloc_source_buffer, tui_line_is_displayed)
2400         (tui_addr_is_displayed): Update.
2401         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2402         (tui_check_and_display_highlight_if_needed)
2403         (tui_win_info::make_visible, tui_win_info::refresh)
2404         (tui_refresh_all): Update.
2405         * tui/tui-windata.c (tui_first_data_item_displayed)
2406         (tui_delete_data_content_windows, tui_erase_data_content)
2407         (tui_display_all_data, tui_data_window::refresh_all)
2408         (tui_check_data_values): Update.
2409         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2410         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2411         (tui_win_info::backward_scroll, tui_refresh_all_win)
2412         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2413         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2414         (tui_source_window_base::set_new_height)
2415         (tui_data_window::set_new_height)
2416         (make_invisible_and_set_new_height)
2417         (make_visible_with_new_height, new_height_ok)
2418         (parse_scrolling_args): Update.
2419         * tui/tui-stack.c (tui_show_frame_info): Update.
2420         * tui/tui-source.c (tui_set_source_content)
2421         (tui_set_source_content_nil, tui_source_is_displayed)
2422         (tui_source_window::do_scroll_vertical): Update.
2423         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2424         (tui_display_registers_from, tui_display_reg_element_at_line)
2425         (tui_check_register_values, tui_reg_command): Update.
2426         * tui/tui-layout.c (tui_default_win_height)
2427         (show_source_disasm_command, show_data, init_and_make_win)
2428         (show_source_or_disasm_and_command): Update.
2429         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2430         (tui_redisplay_readline, tui_mld_flush)
2431         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2432         (tui_getc): Update.
2433         * tui/tui-disasm.c (tui_set_disassem_content)
2434         (tui_disasm_window::do_scroll_vertical): Update.
2435         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2436         Now virtual.
2437         (struct tui_win_info): Derive from tui_gen_win_info.
2438         <~tui_win_info>: Mark as override.
2439         <generic>: Remove member.
2440         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2441         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2442         (~tui_data_window, ~tui_win_info)
2443         (tui_free_all_source_wins_content): Update.
2444         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2445
2446 2019-06-25  Tom Tromey  <tom@tromey.com>
2447
2448         * tui/tui-layout.c (init_and_make_win): Use new.
2449         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2450         destructor, initializers.
2451         (tui_alloc_generic_win_info): Don't declare.
2452         * tui/tui-data.c (_locator): Add argument to constructor.
2453         (source_win, disasm_win): New globals.
2454         (exec_info): Remove.
2455         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2456         Update.
2457         (tui_alloc_generic_win_info): Remove.
2458         (init_content_element): Use new.
2459         (tui_win_info::tui_win_info): Update.
2460         (free_content_elements) <case DATA_WIN>: Use delete.
2461
2462 2019-06-25  Tom Tromey  <tom@tromey.com>
2463
2464         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2465         * tui/tui-windata.c (tui_first_data_item_displayed)
2466         (tui_delete_data_content_windows): Update.
2467         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2468         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2469         (tui_display_registers_from, tui_check_register_values): Update.
2470         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2471         pointer.
2472         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2473         window.
2474         (tui_free_data_content): Update.
2475         (free_content_elements) <case DATA_WIN>: Free the window.
2476
2477 2019-06-25  Tom Tromey  <tom@tromey.com>
2478
2479         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2480         Update.
2481         * tui/tui-layout.c (make_command_window)
2482         (show_source_disasm_command, show_data, init_and_make_win)
2483         (show_source_or_disasm_and_command): Update.
2484         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2485         method.
2486         <can_highight, is_highlighted>: Now bool.
2487         (tui_set_win_highlight): Don't declare.
2488         * tui/tui-data.c (tui_set_win_highlight): Remove.
2489
2490 2019-06-25  Tom Tromey  <tom@tromey.com>
2491
2492         * tui/tui-wingeneral.c (make_visible): Remove check of window
2493         type.
2494
2495 2019-06-25  Tom Tromey  <tom@tromey.com>
2496
2497         * tui/tui-win.c (tui_win_info::max_height)
2498         (tui_cmd_window::max_height): New methods.
2499         (new_height_ok): Call max_height.
2500         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2501         <max_height>: New method.
2502
2503 2019-06-25  Tom Tromey  <tom@tromey.com>
2504
2505         * tui/tui-win.c (tui_source_window_base::set_new_height)
2506         (tui_data_window::set_new_height): New methods.
2507         (make_invisible_and_set_new_height): Call set_new_height method.
2508         * tui/tui-data.h (struct tui_win_info)
2509         (struct tui_source_window_base, struct tui_data_window)
2510         <set_new_height>: New method.
2511
2512 2019-06-25  Tom Tromey  <tom@tromey.com>
2513
2514         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2515         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2516         tui_refresh_data_win.
2517         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2518         method.
2519         (tui_refresh_all_win): Call the refresh_all method.
2520         (tui_set_focus): Likewise.
2521         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2522         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2523         Likewise.
2524
2525 2019-06-25  Tom Tromey  <tom@tromey.com>
2526
2527         * tui/tui-winsource.h (tui_refill_source_window)
2528         (tui_set_is_exec_point_at): Don't declare.
2529         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2530         (tui_source_window_base::refill): Rename from
2531         tui_refill_source_window.
2532         (tui_source_window_base::do_scroll_horizontal): Update.
2533         (tui_source_window_base::set_is_exec_point_at): Rename from
2534         tui_set_is_exec_point_at.
2535         (tui_update_all_breakpoint_info): Update.
2536         * tui/tui-stack.c (tui_show_frame_info): Update.
2537         * tui/tui-layout.c (show_data): Add cast.
2538         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2539         * tui/tui-data.h (struct tui_source_window_base) <refill,
2540         set_is_exec_point_at>: New methods.
2541         (tui_source_windows, tui_add_to_source_windows): Update types.
2542         (tui_add_to_source_windows): Remove redundant declaration.
2543         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2544         (tui_source_windows): Change return type.
2545         (tui_clear_source_windows_detail): Update.
2546         (tui_add_to_source_windows): Change type of parameter.
2547         (tui_free_all_source_wins_content): Update.
2548
2549 2019-06-25  Tom Tromey  <tom@tromey.com>
2550
2551         * tui/tui-wingeneral.c (tui_win_info::refresh)
2552         (tui_source_window_base::refresh): New methods.
2553         (tui_refresh_all): Call the refresh method.
2554         * tui/tui-data.h (struct tui_win_info)
2555         (struct tui_source_window_base) <refresh>: New method.
2556
2557 2019-06-25  Tom Tromey  <tom@tromey.com>
2558
2559         * tui/tui.h (tui_is_window_visible): Return bool.
2560         * tui/tui.c (tui_is_window_visible): Return bool.
2561         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2562         (tui_make_visible, tui_make_invisible)
2563         (tui_win_info::make_visible)
2564         (tui_source_window_base::make_visible, make_all_visible)
2565         (tui_make_all_visible, tui_make_all_invisible): Update.
2566         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2567         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2568         bool.
2569         (struct tui_win_info, struct tui_source_window_base)
2570         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2571         * tui/tui-data.c (tui_init_generic_part): Update.
2572
2573 2019-06-25  Tom Tromey  <tom@tromey.com>
2574
2575         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2576         (tui_source_window_base::make_visible): New methods.
2577         (make_all_visible): Make method call.
2578         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2579         (struct tui_source_window_base, struct tui_cmd_window): Override
2580         make_visible.
2581         (tui_win_is_source_type): Don't declare.
2582         * tui/tui-data.c (tui_win_is_source_type): Remove.
2583
2584 2019-06-25  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2587         NULL check.
2588
2589 2019-06-25  Tom Tromey  <tom@tromey.com>
2590
2591         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2592         Inline constructor.  Add initializers for members.
2593         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2594         constructors; now inline in class.
2595
2596 2019-06-25  Tom Tromey  <tom@tromey.com>
2597
2598         * tui/tui-regs.c (tui_show_registers): Update.
2599         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2600         bool.
2601         * tui/tui-data.c (tui_data_window::clear_detail)
2602         (tui_data_window): Update.
2603
2604 2019-06-25  Tom Tromey  <tom@tromey.com>
2605
2606         * tui/tui-windata.c (tui_display_all_data)
2607         (tui_display_data_from_line, tui_display_data_from)
2608         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2609         Update.
2610         * tui/tui-regs.c (tui_last_regs_line_no)
2611         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2612         (tui_show_registers, tui_show_register_group)
2613         (tui_display_registers_from, tui_display_reg_element_at_line)
2614         (tui_display_registers_from_line, tui_check_register_values)
2615         (tui_reg_next, tui_reg_prev): Update.
2616         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2617         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2618         tui_data_window.
2619         (struct tui_win_info) <detail>: Remove.  Add new fields from
2620         tui_data_info.
2621         (TUI_DATA_WIN): Add cast.
2622         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2623         (~tui_data_window): Simplify.
2624
2625 2019-06-25  Tom Tromey  <tom@tromey.com>
2626
2627         * tui/tui-layout.c (show_source_disasm_command)
2628         (show_source_or_disasm_and_command): Update.
2629         * tui/tui-io.c (update_cmdwin_start_line)
2630         (tui_redisplay_readline): Update.
2631         * tui/tui-data.h (struct tui_command_info): Remove.
2632         (struct tui_win_info) <detail>: Remove command_info member.
2633         (struct tui_data_window) <start_line>: New member, from
2634         tui_command_info.
2635         (TUI_CMD_WIN): Add casts.
2636
2637 2019-06-25  Tom Tromey  <tom@tromey.com>
2638
2639         * tui/tui-winsource.c (tui_update_source_window)
2640         (tui_refill_source_window)
2641         (tui_source_window_base::do_scroll_horizontal)
2642         (tui_update_breakpoint_info, tui_set_exec_info_content)
2643         (tui_show_exec_info_content, tui_erase_exec_info_content)
2644         (tui_clear_exec_info_content): Update.
2645         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2646         Update.
2647         * tui/tui-win.c (make_invisible_and_set_new_height)
2648         (make_visible_with_new_height): Update.
2649         * tui/tui-source.c (tui_set_source_content)
2650         (tui_show_symtab_source): Update.
2651         * tui/tui-layout.c (extract_display_start_addr)
2652         (show_source_disasm_command, show_data)
2653         (make_source_or_disasm_window)
2654         (show_source_or_disasm_and_command): Update.
2655         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2656         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2657         "gdbarch".
2658         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2659         to tui_source_window_base.
2660         (struct tui_win_info) <detail>: Remove source_info member.
2661         (struct tui_source_window_base) <has_locator>: Inline.
2662         Move contents from tui_source_info; rename has_locator member to
2663         m_has_locator.
2664         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2665         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2666         header file.
2667         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2668         Simplify.
2669         (tui_free_all_source_wins_content): Cast to
2670         tui_source_window_base.
2671
2672 2019-06-25  Tom Tromey  <tom@tromey.com>
2673
2674         * tui/tui-win.c (make_invisible_and_set_new_height)
2675         (make_visible_with_new_height): Call has_locator method.
2676         * tui/tui-layout.c (show_source_disasm_command, show_data)
2677         (show_source_or_disasm_and_command): Update for bool change.
2678         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2679         (tui_win_info) <has_locator>: New method.
2680         (struct tui_source_window_base) <has_locator>: New method.
2681         (tui_win_has_locator): Don't declare.
2682         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2683         from tui_win_has_locator.
2684         (tui_source_window_base): Use false, not FALSE.
2685
2686 2019-06-25  Tom Tromey  <tom@tromey.com>
2687
2688         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2689         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2690         clear_detail method directly.
2691         (tui_clear_win_detail): Remove.
2692
2693 2019-06-25  Tom Tromey  <tom@tromey.com>
2694
2695         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2696         "this", not TUI_DISASM_WIN.
2697
2698 2019-06-25  Tom Tromey  <tom@tromey.com>
2699
2700         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2701         declare.
2702         * tui/tui-winsource.c
2703         (tui_source_window_base::do_scroll_horizontal): Rename from
2704         tui_horizontal_source_scroll.
2705         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2706         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2707         from tui_vertical_data_scroll.
2708         * tui/tui-win.h (tui_scroll): Don't declare.
2709         * tui/tui-win.c (tui_win_info::forward_scroll)
2710         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2711         (tui_win_info::right_scroll): Rename and update.
2712         (tui_scroll_forward_command, tui_scroll_backward_command)
2713         (tui_scroll_left_command, tui_scroll_right_command): Update.
2714         (tui_scroll): Remove.
2715         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2716         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2717         from tui_vertical_source_scroll.
2718         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2719         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2720         from tui_vertical_disassem_scroll.
2721         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2722         do_scroll_horizontal>: New methods.
2723         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2724         Likewise.
2725         (struct tui_source_window_base): Add do_scroll_horizontal.
2726         (struct tui_source_window, struct tui_disasm_window): Add
2727         do_scroll_vertical.
2728         (struct tui_data_window, struct tui_cmd_window): Add
2729         do_scroll_horizontal and do_scroll_vertical.
2730         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2731
2732 2019-06-25  Tom Tromey  <tom@tromey.com>
2733
2734         * tui/tui-data.h (struct tui_source_window_base): New struct.
2735         (struct tui_source_window): Derive from tui_source_window_base.
2736         (struct tui_disasm_window): New struct.
2737         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2738         from tui_source_window::clear_detail.
2739         (tui_source_window_base): Rename from tui_source_window.
2740         (~tui_source_window_base): Rename from ~tui_source_window.
2741         (tui_alloc_win_info): Create a tui_disasm_window.
2742
2743 2019-06-25  Tom Tromey  <tom@tromey.com>
2744
2745         * tui/tui-data.h (struct tui_source_window)
2746         (struct tui_data_window): Declare destructors.
2747         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2748         destructors.
2749         (tui_win_info): Simplify.
2750
2751 2019-06-25  Tom Tromey  <tom@tromey.com>
2752
2753         * tui/tui-winsource.c (tui_display_main)
2754         (tui_update_source_windows_with_addr)
2755         (tui_update_all_breakpoint_info): Update.
2756         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2757         (new_height_ok, parse_scrolling_args): Update.
2758         * tui/tui-stack.c (tui_show_frame_info): Update.
2759         * tui/tui-data.h (struct tui_list): Remove.
2760         (tui_source_windows): Return a reference to a std::vector.
2761         * tui/tui-data.c (source_windows): Now a std::vector.
2762         (tui_source_windows): Change return type.
2763         (tui_clear_source_windows): Rewrite.
2764         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2765         (tui_free_all_source_wins_content): Rewrite.
2766
2767 2019-06-25  Tom Tromey  <tom@tromey.com>
2768
2769         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2770         (struct tui_data_window, struct tui_cmd_window): Declare
2771         clear_detail method.
2772         * tui/tui-data.c (tui_source_window::clear_detail)
2773         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2774         methods.
2775         (tui_clear_win_detail): Simplify.
2776
2777 2019-06-25  Tom Tromey  <tom@tromey.com>
2778
2779         * tui/tui-layout.c (make_source_window, make_disasm_window)
2780         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2781         Return the new window.
2782         (show_source_disasm_command, show_data)
2783         (show_source_or_disasm_and_command): Update.
2784
2785 2019-06-25  Tom Tromey  <tom@tromey.com>
2786
2787         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2788         parameter.  Return the new window.
2789         (show_source_disasm_command): Update and remove NULL check.
2790         (show_source_or_disasm_and_command): Update.
2791
2792 2019-06-25  Tom Tromey  <tom@tromey.com>
2793
2794         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2795
2796 2019-06-25  Tom Tromey  <tom@tromey.com>
2797
2798         * tui/tui-data.h (struct tui_win_info): Make constructor
2799         protected.  Make destructor virtual.  Add initializers.
2800         (tui_source_window, tui_data_window, tui_cmd_window): New
2801         classes.
2802         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2803         constructor.  Add "type" parameter.
2804         (tui_source_window, tui_data_window, tui_cmd_window): New
2805         constructors.
2806         (tui_alloc_win_info): Instantiate the appropriate subclass.
2807
2808 2019-06-25  Tom Tromey  <tom@tromey.com>
2809
2810         * tui/tui-win.c (tui_resize_all): Use delete.
2811         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2812         destructor.
2813         (tui_free_window): Don't declare.
2814         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2815         Update.
2816
2817 2019-06-25  Tom Tromey  <tom@tromey.com>
2818
2819         * tui/tui-data.h (struct tui_win_info): Add constructor.
2820         * tui/tui-data.c (tui_alloc_win_info): Use new.
2821         (tui_free_window): Use delete.
2822
2823 2019-06-22  Tom Tromey  <tom@tromey.com>
2824
2825         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2826         declare.
2827         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2828
2829 2019-06-22  Tom Tromey  <tom@tromey.com>
2830
2831         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2832         declare.
2833         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2834
2835 2019-06-22  Tom de Vries  <tdevries@suse.de>
2836
2837         * dwarf2read.c (create_addrmap_from_aranges)
2838         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2839         instead of '%zu'.
2840
2841 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2842
2843         * dwarf2read.h (dwarf2_section_info_def): Remove.
2844         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2845         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2846         std::vector<dwarf2_section_info>.
2847         (struct dwo_file) <~dwo_file>: Remove.
2848         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2849         types field.
2850         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2851         (dwarf2_read_debug_names): Likewise.
2852         (create_debug_types_hash_table): Change parameter type to
2853         array_view, adjust code accordingly.
2854         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2855         (partial_die_info::fixup): Likewise.
2856         (determine_prefix): Likewise.
2857         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2858
2859 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2860
2861         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2862         gdb_bfd_ref_ptr.
2863         <~dwo_file>: Remove call to gdb_bfd_unref.
2864         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2865         gdb_bfd_ref_ptr::get.
2866
2867 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2868
2869         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2870         type to htab_up.
2871         * dwarf2read.c (struct dwo_file): Initialize fields.
2872         <~dwo_file>: New.
2873         (free_dwo_file): Remove, move content to ~dwo_file.
2874         (struct dwo_file_deleter): Remove.
2875         (dwo_file_up>: Remove custom deleter.
2876         (free_dwo_files): Remove.
2877         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2878         dwo_files.
2879         (process_skeletonless_type_units): Call unique_ptr::get.
2880         (allocate_dwo_file_hash_table): Add deleter to created hash
2881         table.  Change return type to htab_up.
2882         (lookup_dwo_file_slot): Don't memset dwo_file, call
2883         unique_ptr::get.
2884         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2885         (create_dwo_unit_in_dwp_v2): Likewise.
2886         (open_and_init_dwo_file): Likewise.
2887         (free_dwo_file_from_slot): Remove.
2888
2889 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2890
2891         * dwarf2read.h (struct dwarf2_section_info) <readin,
2892         is_virtual>: Change type to bool.
2893         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2894         true instead of 1.
2895
2896 2019-06-19  Tom Tromey  <tom@tromey.com>
2897
2898         * tui/tui-data.h (tui_init_content_element): Don't declare.
2899
2900 2019-06-19  Tom Tromey  <tom@tromey.com>
2901
2902         * tui/tui-data.h (tui_init_win_info): Don't declare.
2903
2904 2019-06-19  Tom de Vries  <tdevries@suse.de>
2905
2906         * dwarf2read.h (abstract_to_concrete): Change type to
2907         std::unordered_map<sect_offset, std::vector<sect_offset>,
2908         gdb::hash_enum<sect_offset>>.
2909
2910 2019-06-19  Tom Tromey  <tromey@adacore.com>
2911
2912         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2913         EVAL_AVOID_SIDE_EFFECTS specially.
2914
2915 2019-06-19  Tom Tromey  <tromey@adacore.com>
2916
2917         * source-cache.c (highlighter): New global.
2918         (source_cache::get_source_lines): Create a highlighter on demand.
2919
2920 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2921
2922         * defs.h (deprecated_interactive_hook): Delete declaration.
2923         * interps.c (clear_interpreter_hooks): Remove use of
2924         deprecated_interactive_hook.
2925         * top.c (deprecated_interactive_hook): Delete definition.
2926         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2927
2928 2019-06-18  Tom de Vries  <tdevries@suse.de>
2929
2930         PR gdb/24515
2931         * dwarf2read.h (abstract_to_concrete): Change type from
2932         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2933         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2934         * dwarf2read.c (read_variable): Update.
2935         (dwarf2_fetch_die_loc_sect_off): Update.
2936
2937 2019-06-17  Tom de Vries  <tdevries@suse.de>
2938
2939         PR gdb/24617
2940         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2941         accessing parent[parent_len - 1].
2942
2943 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2944
2945         PR gdb/24364
2946         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2947         call dtrace_process_dof with NULL dof.
2948
2949 2019-06-16  Tom de Vries  <tdevries@suse.de>
2950
2951         PR gdb/24445
2952         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2953
2954 2019-06-16  Tom Tromey  <tom@tromey.com>
2955
2956         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2957         (make_all_visible): Use address of member.
2958
2959 2019-06-16  Tom Tromey  <tom@tromey.com>
2960
2961         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2962         (tui_free_window, free_content, free_content_elements): Remove
2963         unnecessary cast.
2964         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2965         cast.
2966         * tui/tui-regs.c (tui_show_register_group)
2967         (tui_display_registers_from, tui_display_reg_element_at_line):
2968         Remove unnecessary cast.
2969
2970 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2971
2972         * linux-nat.c (normal_mask): Delete.
2973         (_initialize_linux_nat): Don't initialise normal_mask.
2974
2975 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2976
2977         PR gdb/24445
2978         * dwarf-index-write.h (write_psymtabs_to_index): Add
2979         dwz_basename parameter.
2980         * dwarf-index-write.c (write_gdbindex): Move file writing to
2981         write_gdbindex_1.  Change return type void.
2982         (assert_file_size): Move up, remove filename parameter.
2983         (write_gdbindex_1): New function.
2984         (write_debug_names): Change return type to void, call
2985         assert_file_size.
2986         (struct index_wip_file): New struct.
2987         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2988         file logic to index_wip_file.  Write index for dwz file if
2989         needed.
2990         (save_gdb_index_command): Pass basename of dwz file, if present.
2991         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2992         build-id of dwz file, if present.
2993         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2994         (dwarf2_get_dwz_file): Likewise.
2995         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2996         (dwarf2_get_dwz_file): Likewise.
2997
2998 2019-06-16  Tom Tromey  <tom@tromey.com>
2999
3000         * coffread.c (process_coff_symbol): Use xstrdup.
3001         * value.c (create_internalvar): Use xstrdup.
3002
3003 2019-06-16  Tom Tromey  <tom@tromey.com>
3004
3005         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3006         * breakpoint.c (stopin_command, stopat_command)
3007         (until_break_command, decode_location_default): Remove unnecessary
3008         cast.
3009         * utils.c (subset_compare): Remove unnecessary cast.
3010         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3011         cast.
3012         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3013         cast.
3014         * infcmd.c (path_command): Remove unnecessary cast.
3015         * coffread.c (decode_type): Remove unnecessary cast.
3016         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3017         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3018         * tui/tui-stack.c (tui_show_locator_content)
3019         (tui_show_frame_info): Remove unnecessary cast.
3020         * tui/tui-win.c (tui_scroll_forward_command)
3021         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3022         (parse_scrolling_args): Remove unnecessary cast.
3023         * tui/tui-data.c (init_win_info, tui_del_window)
3024         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3025         (free_content_elements): Remove unnecessary cast.
3026         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3027         unnecessary cast.
3028         * tui/tui-source.c (tui_set_source_content)
3029         (tui_vertical_source_scroll): Remove unnecessary cast.
3030         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3031         cast.
3032         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3033         * tui/tui-regs.c (tui_display_registers_from)
3034         (tui_display_register): Remove unnecessary cast.
3035         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3036         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3037         (make_visible): Remove unnecessary cast.
3038         * tui/tui-winsource.c (tui_erase_source_content)
3039         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3040         unnecessary cast.
3041         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3042         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3043         * stabsread.c (read_type, read_array_type, read_range_type):
3044         Remove unnecessary cast.
3045         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3046         (parse_symbol, parse_type, upgrade_type, parse_external)
3047         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3048         unnecessary cast.
3049         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3050
3051 2019-06-16  Tom Tromey  <tom@tromey.com>
3052
3053         * tui/tui-data.c (tui_alloc_generic_win_info)
3054         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3055         checks.
3056
3057 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3058             Andrew Burgess  <andrew.burgess@embecosm.com>
3059
3060         * f-typeprint.c (f_print_type): Don't return early for not
3061         associated or not allocated types.
3062         (f_type_print_varspec_suffix): Add print_rank parameter and print
3063         ranks of array types in case they dangling.
3064         (f_type_print_base): Add print_rank parameter.
3065
3066 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3067
3068         * NEWS: Mention new MI commands.
3069         * break-catch-throw.c (enum exception_event_kind): Move to
3070         breakpoint.h.
3071         (print_mention_exception_catchpoint): Output text as a single
3072         message.
3073         (catch_exception_command_1): Rename to...
3074         (catch_exception_event): ...this, make non-static, update header
3075         command, and change some parameter types.
3076         (catch_catch_command): Update for changes to
3077         catch_exception_command_1.
3078         (catch_throw_command): Likewise.
3079         (catch_rethrow_command): Likewise.
3080         * breakpoint.c (enum exception_event_kind): Delete.
3081         * breakpoint.h (enum exception_event_kind): Moved here from
3082         break-catch-throw.c.
3083         (catch_exception_event): Declare.
3084         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3085         (mi_cmd_catch_throw): New function.
3086         (mi_cmd_catch_rethrow): New function.
3087         (mi_cmd_catch_catch): New function.
3088         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3089         'catch-catch' entries.
3090         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3091         (mi_cmd_catch_rethrow): Declare.
3092         (mi_cmd_catch_catch): Declare.
3093
3094 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3095
3096         * annotate.c (annotate_source_line): Change return type to void,
3097         update implementation to match.
3098         * annotate.h (annotate_source_line): Change return type to void,
3099         update header comment.
3100         * stack.c (print_frame_info): Don't change what frame information
3101         is printed based on whether annotations are on or not.
3102
3103 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3104
3105         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3106         (annotate_source): Make static.
3107         (annotate_source_line): Moved from source.c and renamed from
3108         identify_source_line.  Update the return type.
3109         * annotate.h (annotate_source): Delete declaration.
3110         (annotate_source_line): Declaration moved from source.h, and
3111         renamed from identify_source_line.  Return type updated.
3112         * source.c (identify_source_line): Moved to annotate.c and renamed
3113         to annotate_source_line.
3114         (info_line_command): Remove check of annotation_level.
3115         * source.h (identify_source_line): Move declaration to annotate.h
3116         and rename to annotate_source_line.
3117         * stack.c: Add 'annotate.h' include.
3118         (print_frame_info): Remove check of annotation_level before
3119         calling annotate_source_line.
3120
3121 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3122
3123         * source-cache.c (source_cache::get_plain_source_lines): Use
3124         open_source_file_with_line_charpos instead of just
3125         open_source_file, remove call to find_source_lines.
3126         (source_cache::get_source_lines): Likewise.
3127         * source.c (find_source_lines): Make static.
3128         (get_filename_and_charpos): Renamed into...
3129         (open_source_file_with_line_charpos): ..this along with changes to
3130         return a scoped_fd, and some other minor clean ups.
3131         (identify_source_line): Use open_source_file_with_line_charpos.
3132         (search_command_helper): Use open_source_file_with_line_charpos
3133         instead of just open_source_file, remove call to
3134         find_source_lines.
3135         * source.h (open_source_file_with_line_charpos): Declare new
3136         function.
3137         (find_source_lines): Delete declaration.
3138
3139 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3140
3141         * source.c (get_filename_and_charpos): Remove fullname
3142         parameter.
3143         (identify_source_line): Update call to get_filename_and_charpos.
3144
3145 2019-06-14  Tom Tromey  <tromey@adacore.com>
3146
3147         PR gdb/24502:
3148         * ui-style.h (skip_ansi_escape): Update comment.
3149         * ui-file.h (class no_terminal_escape_file): New class.
3150         * ui-file.c (no_terminal_escape_file::write)
3151         (no_terminal_escape_file::puts): New methods.
3152         * cli/cli-logging.c (handle_redirections): Use
3153         no_terminal_escape_file.
3154
3155 2019-06-14  Tom Tromey  <tromey@adacore.com>
3156
3157         * NEWS: Move convenience variable news above Python news.
3158
3159 2019-06-14  Tom Tromey  <tom@tromey.com>
3160
3161         * gnulib: Move directory to top-level.
3162         * configure.ac: Don't configure gnulib.
3163         * configure: Rebuild.
3164         * common/common-defs.h: Use new path to gnulib.
3165         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3166         (GNULIB_H): Remove.
3167         (INCGNU): Look in new gnulib location.
3168         (HFILES_NO_SRCDIR): Remove gnulib files.
3169         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3170         (generated_files): Remove GNULIB_H.
3171         ($(LIBGNU), all-lib): Remove targets.
3172         (distclean): Don't mention GNULIB_BUILDDIR.
3173         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3174
3175 2019-06-14  Tom Tromey  <tromey@adacore.com>
3176
3177         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3178         Warn if symbol file does not provide any symbols.
3179
3180 2019-06-14  Tom Tromey  <tromey@adacore.com>
3181
3182         * source.c (find_and_open_source): Respect basenames_may_differ.
3183
3184 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3185
3186         * annotate.c (annotate_breakpoints_invalid): Make use of
3187         scoped_restore_terminal_state.
3188         (annotate_frames_invalid): Likewise.
3189
3190 2019-06-14  Tom Tromey  <tromey@adacore.com>
3191
3192         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3193         allow assignment to an internalvar.
3194
3195 2019-06-14  Tom Tromey  <tromey@adacore.com>
3196
3197         * ada-lex.l: Allow "_" in attribute names.
3198
3199 2019-06-14  Tom Tromey  <tromey@adacore.com>
3200
3201         PR gdb/24653:
3202         * regcache.c (registers_changed): Don't call alloca.
3203         * top.c (execute_command): Don't call alloca.
3204
3205 2019-06-13  Pedro Alves  <palves@redhat.com>
3206
3207         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3208         'expression'.  When parsing an expression, error out if there's
3209         junk after "unlimited".
3210         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3211         (do_set_command): Adjust calls to is_unlimited_literal.
3212
3213 2019-06-13  Pedro Alves  <palves@redhat.com>
3214
3215         * compile/compile.c (make_compile_options_def_group): Add braces
3216         around array_view initializer.
3217         * thread.c (make_thread_apply_all_options_def_group)
3218         (make_thread_apply_all_options_def_group): Likewise.
3219
3220 2019-06-13  Pedro Alves  <palves@redhat.com>
3221
3222         * NEWS (New commands): Mention "maint test-options
3223         require-delimiter", "maint test-options unknown-is-error", "maint
3224         test-options unknown-is-operand" and "maint show
3225         test-options-completion-result".
3226         (New command options, command completion): New section.
3227         (Completion improvements): New section.
3228         Mention that you can abbreviate "unlimited".
3229
3230 2019-06-13  Pedro Alves  <palves@redhat.com>
3231
3232         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3233         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3234         * unittests/cli-utils-selftests.c (test_parse_flags)
3235         (test_parse_flags_qcs): Delete.
3236         (test_cli_utils): Don't call deleted functions.
3237
3238 2019-06-13  Pedro Alves  <palves@redhat.com>
3239
3240         * thread.c: Include "cli/cli-option.h".
3241         (tp_array_compar_ascending): Global.
3242         (tp_array_compar): Delete function.
3243         (tp_array_compar_ascending, tp_array_compar_descending): New
3244         functions.
3245         (ascending_option_def, qcs_flag_option_def)
3246         (thr_qcs_flags_option_defs)
3247         (make_thread_apply_all_options_def_group)
3248         (make_thread_apply_options_def_group): New.
3249         (thread_apply_all_command): Use gdb::option::process_options.
3250         (thread_apply_command_completer)
3251         (thread_apply_all_command_completer): New.
3252         (thread_apply_command): Use gdb::option::process_options.
3253         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3254         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3255         to generate help text of "thread apply".  Adjust "taas"'s help.
3256         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3257         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3258
3259 2019-06-13  Pedro Alves  <palves@redhat.com>
3260
3261         * thread.c (thread_apply_command): Check for invalid TID with
3262         isdigit instead of !isalpha.
3263
3264 2019-06-13  Pedro Alves  <palves@redhat.com>
3265
3266         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3267         (validate_flags_qcs): New.
3268         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3269         (validate_flags_qcs): Declare.
3270         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3271         (make_frame_apply_options_def_group): New.
3272         (frame_apply_command_count): Process options with
3273         gdb::option::process_options.
3274         (frame_apply_completer): New.
3275         (frame_apply_level_completer, frame_apply_all_completer)
3276         (frame_apply_completer): New.
3277         (_initialize_stack): Update help of "frame apply", "frame apply
3278         level", "frame apply all" and "faas" to mention supported options
3279         and install command completers.
3280         * stack.h (frame_apply_all_completer): Declare.
3281         * thread.c: Include "stack.h".
3282         (tfaas_command): Add "--".
3283         (_initialize_thread): Update help "tfaas" to mention supported
3284         options and install command completer.
3285
3286 2019-06-13  Pedro Alves  <palves@redhat.com>
3287
3288         * completer.c (complete_nested_command_line): New.
3289         (gdb_completion_word_break_characters_throw): Add assertion.
3290         * completer.h (complete_nested_command_line): Declare.
3291
3292 2019-06-13  Pedro Alves  <palves@redhat.com>
3293
3294         * stack.c (parse_backtrace_qualifiers): New.
3295         (backtrace_command): Use it.
3296         (backtrace_command_completer): Complete on qualifiers.
3297
3298 2019-06-13  Pedro Alves  <palves@redhat.com>
3299
3300         * frame.c: Include "cli/cli-option.h.
3301         (user_set_backtrace_options): New.
3302         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3303         Delete.
3304         (get_prev_frame): Adjust.
3305         (boolean_option_def, uinteger_option_def)
3306         (set_backtrace_option_defs): New.
3307         (_initialize_frame): Adjust and use
3308         gdb::option::add_setshow_cmds_for_options to install "set
3309         backtrace past-main" and "set backtrace past-entry".
3310         * frame.h: Include "cli/cli-option.h".
3311         (struct frame_print_options): Forward declare.
3312         (print_frame_arguments_all, print_frame_arguments_scalars)
3313         (print_frame_arguments_none): Declare.
3314         (print_entry_values): Delete declaration.
3315         (struct frame_print_options, user_frame_print_options): New.
3316         (struct set_backtrace_options): New.
3317         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3318         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3319         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3320         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3321         (list_args_or_locals): Add frame_print_options parameter.
3322         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3323         * python/py-framefilter.c (enumerate_args): Pass down
3324         USER_FRAME_PRINT_OPTIONS.
3325         * stack.c: Include "cli/cli-option.h".
3326         (print_frame_arguments_all, print_frame_arguments_scalars)
3327         (print_frame_arguments_none): Declare.
3328         (print_raw_frame_arguments, print_entry_values): Delete.
3329         (user_frame_print_options): New.
3330         (boolean_option_def, enum_option_def, frame_print_option_defs):
3331         New.
3332         (struct backtrace_cmd_options): New.
3333         (bt_flag_option_def): New.
3334         (backtrace_command_option_defs): New.
3335         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3336         (print_frame_arg, read_frame_arg, print_frame_args)
3337         (print_frame_info, print_frame): Add frame_print_options parameter
3338         and use it.
3339         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3340         (backtrace_command_1): Add frame_print_options and
3341         backtrace_cmd_options parameters and use them.
3342         (make_backtrace_options_def_group): New.
3343         (backtrace_command): Process command options with
3344         gdb::option::process_options.
3345         (backtrace_command_completer): New.
3346         (_initialize_stack): Extend "backtrace"'s help to mention
3347         supported options.  Install completer for "backtrace".
3348         Install some settings commands with add_setshow_cmds_for_options.
3349
3350 2019-06-13  Pedro Alves  <palves@redhat.com>
3351
3352         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3353         and that "set/show print raw frame-arguments" are now deprecated.
3354
3355         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3356         command.
3357         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3358         * stack.c (_initialize_stack): Install "set/show print
3359         raw-frame-arguments", and deprecate "set/show print raw
3360         frame-arguments".
3361         * valprint.c (_initialize_valprint): Deprecate "set/show print
3362         raw".
3363
3364 2019-06-13  Pedro Alves  <palves@redhat.com>
3365
3366         * compile/compile.c (struct compile_options): New.
3367         (compile_flag_option_def, compile_command_option_defs)
3368         (make_compile_options_def_group): New.
3369         (compile_file_command): Handle options with
3370         gdb::option::process_options.
3371         (compile_file_command_completer): New function.
3372         (compile_code_command): Handle options with
3373         gdb::option::process_options.
3374         (compile_code_command_completer): New function.
3375         (_initialize_compiler): Install completers for "compile code" and
3376         "compile file".  Mention available options in "compile code" and
3377         "compile code"'s help.
3378         * completer.c (advance_to_completion_word): New, factored out from
3379         ...
3380         (advance_to_expression_complete_word_point): ... this.
3381         (advance_to_filename_complete_word_point): New.
3382         * completer.h (advance_to_filename_complete_word_point): New
3383         declaration.
3384
3385 2019-06-13  Pedro Alves  <palves@redhat.com>
3386
3387         * compile/compile.c: Include "cli/cli-option.h".
3388         (compile_print_value): Scope data pointer is now a
3389         value_print_options pointer; adjust.
3390         (compile_print_command): Process options.  Scope data pointer is
3391         now a value_print_options pointer; adjust.
3392         (_initialize_compile): Update "compile print"'s help to include
3393         supported options.  Install a completer for "compile print".
3394         * cp-valprint.c (show_vtblprint, show_objectprint)
3395         (show_static_field_print): Delete.
3396         (_initialize_cp_valprint): Don't install "set print
3397         static-members", "set print vtbl", "set print object" here.
3398         * printcmd.c: Include "cli/cli-option.h" and
3399         "common/gdb_optional.h".
3400         (print_command_parse_format): Rework to fill in a
3401         value_print_options instead of a format_data.
3402         (print_value): Change parameter type from format_data pointer to
3403         value_print_options reference.  Adjust.
3404         (print_command_1): Process options.  Adjust to pass down a
3405         value_print_options.
3406         (print_command_completer): New.
3407         (_initialize_printcmd): Install print_command_completer as
3408         handle_brkchars completer for the "print" command.  Update
3409         "print"'s help to include supported options.
3410         * valprint.c: Include "cli/cli-option.h".
3411         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3412         here from cp-valprint.c.
3413         (boolean_option_def, uinteger_option_def)
3414         (value_print_option_defs, make_value_print_options_def_group):
3415         New.  Use gdb::option::add_setshow_cmds_for_options to install
3416         "set print elements", "set print null-stop", "set print repeats",
3417         "set print pretty", "set print union", "set print array", "set
3418         print address", "set print symbol", "set print array-indexes".
3419         * valprint.h: Include <string> and "cli/cli-option.h".
3420         (make_value_print_options_def_group): Declare.
3421         (print_value): Change parameter type from format_data pointer to
3422         value_print_options reference.
3423         (print_command_completer): Declare.
3424
3425 2019-06-13  Pedro Alves  <palves@redhat.com>
3426
3427         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3428         (COMMON_SFILES): Add maint-test-settings.c.
3429         * cli/cli-decode.c (boolean_enums): New global, factored out from
3430         ...
3431         (add_setshow_boolean_cmd): ... here.
3432         * cli/cli-decode.h (boolean_enums): Declare.
3433         * cli/cli-option.c: New file.
3434         * cli/cli-option.h: New file.
3435         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3436         factored out from ...
3437         (parse_cli_boolean_value(const char *)): ... this.
3438         (is_unlimited_literal): Change parameter type to pointer to
3439         pointer.  Adjust and advance ARG pointer.
3440         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3441         (parse_cli_var_enum): New, factored out from ...
3442         (do_set_command): ... this.  Adjust.
3443         * cli/cli-setshow.h (parse_cli_boolean_value)
3444         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3445         (parse_cli_var_enum): Declare.
3446         * cli/cli-utils.c: Include "cli/cli-option.h".
3447         (get_ulongest): New.
3448         * cli/cli-utils.h (get_ulongest): Declare.
3449         (check_for_argument): New overloads.
3450         * maint-test-options.c: New file.
3451
3452 2019-06-13  Pedro Alves  <palves@redhat.com>
3453
3454         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3455         parse a range if "-" is at the end of the string.
3456
3457 2019-06-13  Pedro Alves  <palves@redhat.com>
3458
3459         * cli/cli-setshow.c (parse_auto_binary_operation)
3460         (parse_cli_boolean_value): Don't allow "o".
3461
3462 2019-06-13  Pedro Alves  <palves@redhat.com>
3463
3464         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3465         * NEWS: Mention maint test-settings KIND.
3466         * maint-test-settings.c: New file.
3467
3468 2019-06-13  Pedro Alves  <palves@redhat.com>
3469
3470         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3471         completer.
3472         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3473         "set" completers.
3474
3475 2019-06-13  Pedro Alves  <palves@redhat.com>
3476
3477         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3478         after item.
3479
3480 2019-06-13  Pedro Alves  <palves@redhat.com>
3481
3482         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3483
3484 2019-06-13  Pedro Alves <palves@redhat.com>
3485
3486         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3487         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3488         call.
3489         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3490         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3491         calls.
3492         (check_for_argument): Skip spaces after argument.
3493
3494 2019-06-13  Pedro Alves  <palves@redhat.com>
3495
3496         * thread.c (thread_apply_command): Adjust TID parsing.
3497         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3498         detected before end of string.
3499         (tid_is_in_list): Error out if LIST is invalid.
3500
3501 2019-06-13  Pedro Alves  <palves@redhat.com>
3502
3503         * completer.c (complete_line_internal_1): Rewind completion word
3504         point.
3505         (completion_tracker::advance_custom_word_point_by): Change
3506         parameter type to int.
3507         * completer.h (completion_tracker::advance_custom_word_point_by):
3508         Likewise.
3509
3510 2019-06-13  Pedro Alves  <palves@redhat.com>
3511
3512         * completer.c (advance_to_completion_word): Handle delimiters.
3513
3514 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3515
3516         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3517
3518 2019-06-11  Tom Tromey  <tom@tromey.com>
3519
3520         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3521         (xmalloc_failed): Move to alloc.c.
3522         * alloc.c: New file.
3523         * Makefile.in (COMMON_SFILES): Add alloc.c.
3524
3525 2019-06-11  Tom Tromey  <tom@tromey.com>
3526
3527         * nat/linux-waitpid.c: Don't include server.h.
3528         (linux_debug): Remove.
3529         (my_waitpid): Update.
3530
3531 2019-06-11  Tom Tromey  <tromey@adacore.com>
3532
3533         * infcall.c (_initialize_infcall): Remove trailing newline from
3534         help.
3535         * user-regs.c (_initialize_user_regs): Remove trailing newline
3536         from help.
3537         * typeprint.c (_initialize_typeprint): Remove trailing newline
3538         from help.
3539         * reverse.c (_initialize_reverse): Remove trailing newlines from
3540         help.
3541         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3542         from help.
3543         * language.c (add_set_language_command): Remove trailing newline
3544         from help.
3545         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3546         help.
3547         * disasm.c (_initialize_disasm): Remove trailing newline from
3548         help.
3549         * top.c (init_main): Remove trailing newline from help.
3550         * interps.c (_initialize_interpreter): Remove trailing newline
3551         from help.
3552         * btrace.c (_initialize_btrace): Remove trailing newlines from
3553         help.
3554         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3555         from help.
3556         * python/python.c (_initialize_python): Remove trailing newline
3557         from help.
3558         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3559         help.
3560         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3561         from help.  Reformat some text.
3562         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3563         from help.
3564         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3565         newline from help.
3566
3567 2019-06-11  Tom Tromey  <tromey@adacore.com>
3568
3569         * darwin-nat.c (darwin_decode_exception_message)
3570         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3571
3572 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3573
3574         * valops.c (value_slice): Check for not allocated or not
3575         associated values.
3576
3577 2019-06-10  Tom de Vries  <tdevries@suse.de>
3578
3579         PR gdb/24618
3580         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3581         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3582         invalid.
3583
3584 2019-06-10  Tom de Vries  <tdevries@suse.de>
3585
3586         PR gdb/24611
3587         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3588         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3589
3590 2019-06-10  Tom de Vries  <tdevries@suse.de>
3591
3592         PR symtab/24545
3593         * symtab.c (struct demangled_name_entry): Add language field.
3594         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3595         static minimal symbol".  Set and use language field.
3596
3597 2019-06-10  Tom Tromey  <tromey@adacore.com>
3598
3599         * ada-lang.c (_initialize_ada_language): Update help text.
3600
3601 2019-06-10  Tom Tromey  <tromey@adacore.com>
3602
3603         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3604         with a newline.
3605         * guile/guile.c (handle_boot_error): Don't end warning with a
3606         newline.
3607         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3608         warning with a newline.
3609         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3610         newline.
3611         (s12z_frame_cache): Likewise.
3612         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3613         a newline.
3614         * solib-svr4.c (disable_probes_interface): Don't end warning with
3615         a newline.
3616         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3617         newline.
3618         * python/python.c (do_finish_initialization): Don't end warning
3619         with a newline.
3620
3621 2019-06-10  Tom Tromey  <tom@tromey.com>
3622
3623         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3624         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3625         gdbpy_enter.
3626
3627 2019-06-10  Tom Tromey  <tromey@adacore.com>
3628
3629         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3630         data.
3631         (elf_new_init): Don't call stabsread_new_init.
3632         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3633         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3634         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3635
3636 2019-06-10  Tom de Vries  <tdevries@suse.de>
3637
3638         PR symtab/16264
3639         PR symtab/24517
3640         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3641
3642 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3643
3644         * source.c (find_and_open_source): Also rewrite relative file
3645         names.
3646
3647 2019-04-26  Amos Bird  <amosbird@gmail.com>
3648
3649         * annotate.c (annotate_thread_exited): Add "thread-exited"
3650         annotation.
3651
3652 2019-06-06  Tom Tromey  <tromey@adacore.com>
3653
3654         * maint.h (class scoped_command_stats): Use
3655         DISABLE_COPY_AND_ASSIGN.
3656         <print_time>: New method.
3657         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3658         print_time.
3659         (scoped_command_stats::print_time): New method.
3660
3661 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3662
3663         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3664         instructions of lengths 6 or 8 bytes.
3665
3666 2019-06-04  Pedro Alves  <palves@redhat.com>
3667
3668         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3669
3670         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3671         * breakpoint.c (condition_completer): Likewise.
3672         * cli/cli-dump.c (scan_expression): Likewise.
3673         * common/filestuff.c (mkdir_recursive): Likewise.
3674         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3675         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3676         (gdb_abspath): Likewise.
3677         * compile/compile-cplus-types.c
3678         (compile_cplus_instance::decl_name): Likewise.
3679         * completer.c (complete_explicit_location):
3680         (signal_completer, reg_or_group_completer_1): Likewise.
3681         * cp-support.c (cp_remove_params_if_any): Likewise.
3682         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3683         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3684         * infcmd.c (strip_bg_char): Likewise.
3685         * linespec.c (copy_token_string): Likewise.
3686         * mi/mi-main.c (output_cores): Likewise.
3687         * psymtab.c (psymtab_search_name):
3688         * symfile.c (test_set_ext_lang_command): Likewise.
3689         * target.c (target_fileio_read_stralloc): Likewise.
3690         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3691         * value.c (complete_internalvar): Likewise.
3692
3693 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3694
3695         Add objfile property to gdb.Type.
3696         * NEWS: Mention Python API addition.
3697         * python/py-type.c (typy_get_objfile): New method.
3698
3699 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3700
3701         * NEWS: Mention the new set|show style [title|highlight].
3702         Mention changes to "show style", "help" and "apropos".
3703
3704 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3705
3706         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3707         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3708         instead of print_help_for_command.
3709         (print_doc_of_command): New function.
3710         (help_list): Add 'apropos -v word' suggestion.
3711         (print_help_for_command): Style the command name using title style.
3712         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3713         (_initialize_cli_cmds): Describe -v in apropos_command help.
3714
3715 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3716
3717         * cli/cli-style.h (cli_style_option): Add name in constructor,
3718         add m_name class member, add constructor with intensity,
3719         add name class function.
3720         (cli_style_option::add_setshow_commands): Remove name argument.
3721         (highlight_style, title_style): New styles.
3722         * cli/cli-style.c (do_show): New function that shows a style
3723         characteristic styling the style name with itself.
3724         (set_style_name): New function.
3725         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3726         Update all callers according to the changes in cli/cli-style.h.
3727         * utils.h (fputs_highlighted): New function.
3728         * utils.c (fputs_highlighted): Likewise.
3729
3730 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3731
3732         * NEWS: Mention new pipe command and new convenience variables.
3733
3734 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3735
3736         * cli/cli-cmds.c (pipe_command): New function.
3737         (_initialize_cli_cmds): Call add_com for pipe_command.
3738         Define | as an alias for pipe.
3739         (exit_status_set_internal_vars): New function.
3740         (shell_escape): Call exit_status_set_internal_vars.
3741         cli/cli-decode.c (find_command_name_length): Recognize | as
3742         a single character command.
3743
3744 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3745
3746         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3747         top.c (execute_command_to_ui_file): New function, mostly a copy
3748         of execute_command_to_string.
3749         (execute_command_to_string): Implement by calling
3750         execute_command_to_ui_file.
3751
3752 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3753
3754         * top.h (saved_command_line): Remove declaration.
3755         * top.c (previous_saved_command_line, previous_repeat_arguments):
3756         New variables.
3757         (saved_command_line): Make static, define together with other
3758         'repeat variables'.
3759         (dont_repeat): Clear repeat_arguments.
3760         (repeat_previous, get_saved_command_line, save_command_line):
3761         New functions.
3762         (gdb_init): Initialize saved_command_line
3763         and previous_saved_command_line.
3764         * main.c (captured_main_1): Remove saved_command_line initialization.
3765         * event-top.c (handle_line_of_input): Update to use
3766         the new 'repeat' related functions instead of direct access to
3767         saved_command_line.
3768         * command.h (repeat_previous, get_saved_command_line,
3769         save_command_line): New declarations.
3770         (dont_repeat): Add comment.
3771
3772 2019-05-30  Tom Tromey  <tromey@adacore.com>
3773
3774         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3775         Fix comment.
3776         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3777
3778 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3779
3780         PR cli/24587
3781         * completer.c (complete): Initialize variable word.
3782
3783 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3784
3785         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3786         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3787         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3788         'body' is NULL to the outter 'if', protecting the '!is_define'
3789         situation as well.
3790
3791 2019-05-29  Tom Tromey  <tromey@adacore.com>
3792
3793         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3794         (dwarf_unknown): New function.
3795         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3796         (dwarf_type_encoding_name): Use dwarf_unknown.
3797
3798 2019-05-29  Tom Tromey  <tromey@adacore.com>
3799
3800         PR c++/20020:
3801         * cp-valprint.c (cp_print_value_fields): Call
3802         cp_print_static_field inside "try".
3803
3804 2019-05-29  Tom Tromey  <tromey@adacore.com>
3805
3806         * inflow.c (struct terminal_info): Add default operator=.
3807         * configure: Rebuild.
3808         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3809         -Wdeprecated-copy-dtor, -Wredundant-move.
3810
3811 2019-05-29  Tom Tromey  <tromey@adacore.com>
3812
3813         * NEWS: Add entry.
3814         * infcmd.c (print_return_value_1): Handle finish_print
3815         option.
3816         (show_print_finish): New function.
3817         (_initialize_infcmd): Add "set/show print finish" commands.
3818         * valprint.c (user_print_options): Initialize new member.
3819         * valprint.h (struct value_print_options) <finish_print>: New
3820         member.
3821
3822 2019-05-28  Tom Tromey  <tromey@adacore.com>
3823
3824         * ada-lang.c (ada_remove_Xbn_suffix)
3825         (find_old_style_renaming_symbol)
3826         (parse_old_style_renaming): Remove.
3827         (ada_find_renaming_symbol): Don't call
3828         find_old_style_renaming_symbol.
3829         (ada_is_renaming_symbol): Rename from
3830         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3831         bool.  Now static.
3832         (ada_read_var_value): Update and simplify.
3833         * ada-exp.y (write_var_or_type): Remove old code.
3834
3835 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3836
3837         * event-top.c: Remove include comment.
3838         * inflow.c (class scoped_ignore_sigttou): Move from here...
3839         * inflow.h (class scoped_ignore_sigttou): ...to here.
3840         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3841         * top.c:  Remove include comment.
3842
3843 2019-05-27  Tom Tromey  <tom@tromey.com>
3844
3845         * NEWS: Fix typo.
3846
3847 2019-05-22  Tom Tromey  <tromey@adacore.com>
3848
3849         * target.c (target_follow_exec): Constify parameter.
3850         * target-delegates.c: Rebuild.
3851         * remote.c (remote_target::follow_exec): Constify parameter.
3852         * infrun.c (follow_exec): Constify parameter.
3853         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3854         (target_follow_exec): Likewise.
3855
3856 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3857
3858         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3859         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3860
3861 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3862
3863         * NEWS: Add debugredirect and testsuite sections.
3864
3865 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3866
3867         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3868         target descriptions using exclusively floating point register name
3869         aliases.
3870
3871 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3872
3873         PR gdb/18644:
3874         * f-lang.c (build_fortran_types): Handle the case where
3875         gdbarch_floatformat_for_type returns a nullptr.
3876
3877 2019-05-21  Tom de Vries  <tdevries@suse.de>
3878
3879         PR cli/24587
3880         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3881
3882 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3883
3884         PR gdb/18644:
3885         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3886         16-byte floats.
3887         * i386-tdep.c (i386_floatformat_for_type): Use
3888         floatformats_ia64_quad for the 16-byte floating point component
3889         within a fortran 32-byte complex number.
3890
3891 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3892
3893         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3894         delete default constructor.
3895         (find_partial_die): Update to return const struct.
3896         (partial_die_parent_scope): Move variable declaration into scope
3897         of its use and change its type to auto.
3898         (guess_partial_die_structure_name): Likewise.
3899         (partial_die_info::fixup): Likewise.
3900
3901 2019-05-17  Tom Tromey  <tromey@adacore.com>
3902
3903         * source.c (find_and_open_source): Remove cast.
3904
3905 2019-05-17  Tom Tromey  <tromey@adacore.com>
3906
3907         * annotate.c (annotate_source): Make "filename" const.
3908         * annotate.h (annotate_source): Use const.
3909
3910 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3911
3912         * disasm.c (set_disassembler_options): Send errors to stderr.
3913
3914 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3915
3916         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3917         (cli_interp_base::set_logging): Check debug_redirect.
3918         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3919         * cli/cli-logging.c (debug_redirect): Add static variable.
3920         (pop_output_files): Add default param.
3921         (handle_redirections): Print debug setting.
3922         (show_logging_command): Likewise.
3923         (_initialize_cli_logging): Add debugredirect command.
3924         * interps.c (current_interp_set_logging): Add debug_redirect
3925         parameter.
3926         * interps.h (set_logging): Add debug_redirect parameter.
3927         (current_interp_set_logging): Likewise.
3928         * mi/mi-common.h: Likewise.
3929         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3930
3931 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3932             Tom Tromey  <tromey@adacore.com>
3933
3934         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3935         directly.
3936         * cli/cli-interp.h (make_logging_output): Remove declaration.
3937         * cli/cli-logging.c (make_logging_output): Remove function.
3938         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3939         directly.
3940         * ui-file.c (tee_file::tee_file): Remove bools.
3941         (tee_file::~tee_file): Remove deletes.
3942         * ui-file.h (tee_file): Remove bools.
3943
3944 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3945
3946         * mi/mi-cmds.h (mi_cmd_complete): New function.
3947         * mi/mi-main.c (mi_cmd_complete): Likewise.
3948         * mi/mi-cmds.c: Define new MI command -complete.
3949         * NEWS: Mention new -complete command.
3950
3951 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3952
3953         * completer.h (complete): New function.
3954         * completer.c (complete): Likewise.
3955         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3956         function defined in completer.h.
3957
3958 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3959
3960         * MAINTAINERS (Write After Approval): Add myself.
3961
3962 2019-05-17  Tom de Vries  <tdevries@suse.de>
3963
3964         PR gdb/24094
3965         * dwarf2read.c (struct cu_partial_die_info): New struct.
3966         (find_partial_die): Return cu_partial_die_info.
3967         (partial_die_parent_scope, guess_partial_die_structure_name)
3968         (partial_die_info::fixup): Handle new return type of find_partial_die.
3969
3970 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3971
3972         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3973         "std::string", simplifying the algorithm.
3974
3975 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3976
3977         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3978         (stap_static_probe_ops::get_probes): Likewise.
3979
3980 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3981
3982         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3983         '-')" and "else if".
3984         (stap_parse_single_operand): Join checks for
3985         "gdbarch_stap_parse_special_token_p" and
3986         "gdbarch_stap_parse_special_token" in the same "if" statement.
3987         Invert check when verifying for operation on register
3988         displacement.
3989
3990 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3991
3992         * stap-probe.c (stap_get_opcode): Update comment.
3993         (stap_get_expected_argument_type): Likewise.
3994         (handle_stap_probe): Likewise.
3995
3996 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3997
3998         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3999         return type to 'bool'.  Adjust comment.  Use 'bool' when
4000         appropriate.
4001         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4002         * stap-probe.c (stap_parse_argument_1): Likewise.
4003         (stap_is_operator): Likewise.
4004         (stap_is_generic_prefix): Likewise.
4005         (stap_is_register_prefix): Likewise.
4006         (stap_is_register_indirection_prefix): Likewise.
4007         (stap_is_integer_prefix): Likewise.
4008         (stap_generic_check_suffix): Likewise.
4009         (stap_check_integer_suffix): Likewise.
4010         (stap_check_register_suffix): Likewise.
4011         (stap_check_register_indirection_suffix): Likewise.
4012         (stap_parse_register_operand): Likewise.
4013         (stap_parse_single_operand): Likewise.
4014         (stap_parse_argument_1): Likewise.
4015         (stap_probe::get_argument_count): Likewise.
4016         (stap_is_operator): Likewise.
4017
4018 2019-05-16  Tom Tromey  <tromey@adacore.com>
4019
4020         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4021         keyword to foreach.
4022
4023 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4024
4025         * linux-thread-db.c (try_thread_db_load_1): Change return type
4026         to bool.
4027         (try_thread_db_load): Likewise.
4028         (try_thread_db_load_from_pdir_1): Likewise.
4029         (try_thread_db_load_from_pdir): Likewise.
4030         (try_thread_db_load_from_sdir): Likewise.
4031         (try_thread_db_load_from_dir): Likewise.
4032         (thread_db_load_search): Likewise.
4033         (has_libpthread): Likewise.
4034         (thread_db_load): Likewise.
4035
4036 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4037
4038         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4039         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4040         NULL, and complain/return if that's the case.
4041
4042 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4043
4044         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4045         (advance, posn, abstract_read_memory): New functions.
4046         [struct mem_read_abstraction]: New struct.
4047         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4048
4049 2019-05-14  Tom Tromey  <tromey@adacore.com>
4050
4051         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4052         value is not lval_memory.
4053
4054 2019-05-14  Tom Tromey  <tromey@adacore.com>
4055
4056         * solib.c (info_sharedlibrary_command): Style the file name.
4057
4058 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4059
4060         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4061         (aarch64_vnv_type): Likewise.
4062         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4063         * common/tdesc.c: Likewise.
4064         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4065         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4066         * features/aarch64-fpu.xml: Add ieee half view.
4067         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4068         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4069         * gdbtypes.h (struct builtin_type): Likewise.
4070         (struct objfile_type): Likewise.
4071
4072 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4073
4074         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4075         typo.
4076         * location.h (string_to_event_location): Likewise.
4077
4078 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4079
4080         GDB 8.3 released.
4081
4082 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4083
4084         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4085         New variable declaration.
4086         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4087         New variable.
4088         (print_one_breakpoint): Use ui_out::test_flags and new global
4089         variable to compute use_fixed_output.
4090         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4091         Remove.
4092         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4093         (mi_multi_location_breakpoint_output_fixed): Remove.
4094         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4095         new variable.
4096         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4097         fix_multi_location_breakpoint_output flag if version >= 3.
4098         * ui-out.h (enum ui_out_flag)
4099         <fix_multi_location_breakpoint_output>: New enumerator.
4100
4101 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4102
4103         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4104
4105 2019-05-10  Tom Tromey  <tromey@adacore.com>
4106
4107         * ada-lang.c (catch_ada_completer): New function.
4108         (_initialize_ada_language): Use it.
4109
4110 2019-05-10  Tom Tromey  <tromey@adacore.com>
4111
4112         * thread.c (print_thread_info): Make "requested_threads" const.
4113         * gdbthread.h (print_thread_info): Make "requested_threads"
4114         const.
4115         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4116         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4117
4118 2019-05-08  Tom Tromey  <tom@tromey.com>
4119
4120         * gdbtypes.c (objfile_type_data): Change type.
4121         (objfile_type, _initialize_gdbtypes): Update.
4122
4123 2019-05-08  Tom Tromey  <tom@tromey.com>
4124
4125         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4126         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4127         (_initialize_dwarf2_frame): Update.
4128
4129 2019-05-08  Tom Tromey  <tom@tromey.com>
4130
4131         * objc-lang.c (objc_objfile_data): Change type.
4132         (find_methods): Update.
4133         (_initialize_objc_lang): Remove.
4134
4135 2019-05-08  Tom Tromey  <tom@tromey.com>
4136
4137         * stabsread.c (rs6000_builtin_type_data): Change type.
4138         (rs6000_builtin_type, _initialize_stabsread): Update.
4139
4140 2019-05-08  Tom Tromey  <tom@tromey.com>
4141
4142         * mips-tdep.c (mips_pdr_data): Remove.
4143         (_initialize_mips_tdep): Update.
4144
4145 2019-05-08  Tom Tromey  <tom@tromey.com>
4146
4147         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4148         (hppa_init_objfile_priv_data, read_unwind_info)
4149         (find_unwind_entry, _initialize_hppa_tdep): Update.
4150
4151 2019-05-08  Tom Tromey  <tom@tromey.com>
4152
4153         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4154         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4155         on obstack.
4156         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4157
4158 2019-05-08  Tom Tromey  <tom@tromey.com>
4159
4160         * mdebugread.c (basic_type_data): Change type.
4161         (basic_type, _initialize_mdebugread): Update.
4162
4163 2019-05-08  Tom Tromey  <tom@tromey.com>
4164
4165         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4166
4167 2019-05-08  Tom Tromey  <tom@tromey.com>
4168
4169         * nto-tdep.c (nto_inferior_data_reg): Change type.
4170         (nto_inferior_data): Update.
4171         (nto_inferior_data_cleanup, nto_new_inferior_data)
4172         (_initialize_nto_tdep): Remove.
4173         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4174
4175 2019-05-08  Tom Tromey  <tom@tromey.com>
4176
4177         * ada-lang.c (struct ada_inferior_data): Add initializers.
4178         (ada_inferior_data): Change type.
4179         (ada_inferior_data_cleanup): Remove.
4180         (get_ada_inferior_data, ada_inferior_exit)
4181         (struct ada_pspace_data): Add initializers, destructor.
4182         (ada_pspace_data_handle): Change type.
4183         (get_ada_pspace_data): Update.
4184         (ada_pspace_data_cleanup): Remove.
4185
4186 2019-05-08  Tom Tromey  <tom@tromey.com>
4187
4188         * coffread.c (struct coff_symfile_info): Add initializers.
4189         (coff_objfile_data_key): Move lower.  Change type.
4190         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4191         Update.
4192         (coff_free_info): Remove.
4193
4194 2019-05-08  Tom Tromey  <tom@tromey.com>
4195
4196         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4197         (fbsd_pspace_data_handle): Move lower.  Change type.
4198         (get_fbsd_pspace_data): Update.
4199         (fbsd_pspace_data_cleanup): Remove.
4200         (_initialize_fbsd_tdep): Update.
4201
4202 2019-05-08  Tom Tromey  <tom@tromey.com>
4203
4204         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4205         (get_ada_tasks_pspace_data): Update.
4206         (ada_tasks_pspace_data_cleanup): Remove.
4207         (_initialize_tasks): Update.
4208         (ada_tasks_inferior_data_handle): Change type.
4209         (get_ada_tasks_inferior_data): Update.
4210         (ada_tasks_inferior_data_cleanup): Remove.
4211         (struct ada_tasks_pspace_data): Add initializers.
4212
4213 2019-05-08  Tom Tromey  <tom@tromey.com>
4214
4215         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4216         * symfile-debug.c (debug_sym_get_probes): Change type.
4217         * stap-probe.c (handle_stap_probe):
4218         (stap_static_probe_ops::get_probes): Change type.
4219         * probe.h (class static_probe_ops) <get_probes>: Change type.
4220         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4221         (parse_probes_in_pspace): Update.
4222         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4223         Update.
4224         (any_static_probe_ops::get_probes): Change type.
4225         * elfread.c (elfread_data): New typedef.
4226         (probe_key): Change type.
4227         (elf_get_probes): Likewise.  Update.
4228         (probe_key_free): Remove.
4229         (_initialize_elfread): Update.
4230         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4231         Change type.
4232         (dtrace_process_dof_probe, dtrace_process_dof)
4233         (dtrace_static_probe_ops::get_probe): Change type.
4234
4235 2019-05-08  Tom Tromey  <tom@tromey.com>
4236
4237         * xcoffread.c (struct xcoff_symfile_info): Rename from
4238         coff_symfile_info.  Add initializers.
4239         (xcoff_objfile_data_key): Move lower.  Change type.
4240         (XCOFF_DATA): Rewrite.
4241         (xcoff_free_info): Remove.
4242         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4243         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4244         (xcoff_initial_scan): Update.
4245
4246 2019-05-08  Tom Tromey  <tom@tromey.com>
4247
4248         * solib-svr4.c (struct svr4_info): Add initializers and
4249         destructor.
4250         <probes_table>: Now an htab_up.
4251         (solib_svr4_pspace_data): Change type.
4252         (free_probes_table): Simplify.
4253         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4254         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4255         (probes_table_remove_objfile_probes, register_solib_event_probe)
4256         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4257         (_initialize_svr4_solib): Update.
4258
4259 2019-05-08  Tom Tromey  <tom@tromey.com>
4260
4261         * remote.c (remote_pspace_data): Change type.
4262         (remote_pspace_data_cleanup): Remove.
4263         (get_remote_exec_file, set_pspace_remote_exec_file)
4264         (_initialize_remote): Update.
4265
4266 2019-05-08  Tom Tromey  <tom@tromey.com>
4267
4268         * breakpoint.c (breakpoint_objfile_key): Change type.
4269         (get_breakpoint_objfile_data): Update.
4270         (free_breakpoint_objfile_data): Remove.
4271         (_initialize_breakpoint): Update.
4272
4273 2019-05-08  Tom Tromey  <tom@tromey.com>
4274
4275         * linux-tdep.c (struct linux_info): Add initializers.
4276         (linux_inferior_data): Move.  Change type.
4277         (invalidate_linux_cache_inf): Update.
4278         (linux_inferior_data_cleanup): Remove.
4279         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4280
4281 2019-05-08  Tom Tromey  <tom@tromey.com>
4282
4283         * auxv.c (auxv_inferior_data): Move.  Change type.
4284         (auxv_inferior_data_cleanup): Remove.
4285         (invalidate_auxv_cache_inf): Rewrite.
4286         (get_auxv_inferior_data, _initialize_auxv): Update.
4287
4288 2019-05-08  Tom Tromey  <tom@tromey.com>
4289
4290         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4291         (symfile_debug_objfile_data_key): Change type.
4292         (symfile_debug_installed, debug_qf_has_symbols)
4293         (debug_qf_find_last_source_symtab)
4294         (debug_qf_forget_cached_source_info)
4295         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4296         (debug_qf_print_stats, debug_qf_dump)
4297         (debug_qf_expand_symtabs_for_function)
4298         (debug_qf_expand_all_symtabs)
4299         (debug_qf_expand_symtabs_with_fullname)
4300         (debug_qf_map_matching_symbols)
4301         (debug_qf_expand_symtabs_matching)
4302         (debug_qf_find_pc_sect_compunit_symtab)
4303         (debug_qf_map_symbol_filenames)
4304         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4305         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4306         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4307         (debug_sym_read_linetable, debug_sym_relocate): Update.
4308         (symfile_debug_free_objfile): Remove.
4309         (install_symfile_debug_logging, _initialize_symfile_debug):
4310         Update.
4311
4312 2019-05-08  Tom Tromey  <tom@tromey.com>
4313
4314         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4315         allocate_on_obstack.
4316         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4317         (get_dwarf2_per_objfile): Update.
4318         (set_dwarf2_per_objfile): Remove.
4319         (dwarf2_has_info, dwarf2_get_section_info): Update.
4320         (dwarf2_free_objfile): Remove.
4321         (_initialize_dwarf2_read): Update.
4322
4323 2019-05-08  Tom Tromey  <tom@tromey.com>
4324
4325         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4326         initializers.
4327         <unsupported_script_warning_printed,
4328         script_not_found_warning_printed>: Now bool.
4329         (auto_load_pspace_data): Change type.
4330         (~auto_load_pspace_info): Rename from
4331         auto_load_pspace_data_cleanup.
4332         (get_auto_load_pspace_data, init_loaded_scripts_info)
4333         (clear_section_scripts, maybe_print_unsupported_script_warning)
4334         (maybe_print_script_not_found_warning, _initialize_auto_load):
4335         Update.
4336
4337 2019-05-08  Tom Tromey  <tom@tromey.com>
4338
4339         * objfiles.c (objfile_pspace_info): Add destructor and
4340         initializers.
4341         (objfiles_pspace_data): Change type.
4342         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4343         (get_objfile_pspace_data): Update.
4344         (objfiles_bfd_data): Change type.
4345         (get_objfile_bfd_data): Update.
4346         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4347
4348 2019-05-08  Tom Tromey  <tom@tromey.com>
4349
4350         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4351         Change type.
4352         (get_catch_syscall_inferior_data): Update.
4353         (catch_syscall_inferior_data_cleanup): Remove.
4354         (_initialize_break_catch_syscall): Update.
4355
4356 2019-05-08  Tom Tromey  <tom@tromey.com>
4357
4358         * inflow.c (struct terminal_info): Add destructor and
4359         initializers.
4360         (inflow_inferior_data): Change type.
4361         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4362         (get_inflow_inferior_data, inflow_inferior_exit)
4363         (swap_terminal_info, _initialize_inflow): Update.
4364
4365 2019-05-08  Tom Tromey  <tom@tromey.com>
4366
4367         * target-dcache.c (target_dcache_cleanup): Remove.
4368         (target_dcache_aspace_key): Change type.
4369         (target_dcache_init_p, target_dcache_invalidate)
4370         (target_dcache_get, target_dcache_get_or_init)
4371         (_initialize_target_dcache): Update.
4372         * dcache.h (struct dcache_deleter): New.
4373
4374 2019-05-08  Tom Tromey  <tom@tromey.com>
4375
4376         * symtab.c (struct symbol_cache): Add destructor and
4377         initializers.
4378         (symbol_cache_key): Move.  Change type.
4379         (make_symbol_cache, free_symbol_cache): Remove.
4380         (get_symbol_cache): Update.
4381         (symbol_cache_cleanup): Remove.
4382         (ALL_PSPACES, symbol_cache_flush)
4383         (maintenance_print_symbol_cache)
4384         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4385         Update.
4386
4387 2019-05-08  Tom Tromey  <tom@tromey.com>
4388
4389         * symtab.c (struct main_info): Add destructor and initializers.
4390         (main_progspace_key): Move.  Change type.
4391         (get_main_info): Update.
4392         (main_info_cleanup): Remove.
4393         (_initialize_symtab): Update.
4394
4395 2019-05-08  Tom Tromey  <tom@tromey.com>
4396
4397         * registry.h (DECLARE_REGISTRY): Define the _key class.
4398
4399 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4400
4401         * NEWS: Merge two 'New commands' sections.
4402
4403 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4404
4405         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4406         parameter and use Ada language definition instead.
4407         (ada_val_print_ptr): Remove unused language parameter.
4408         (ada_val_print_num): Remove language parameter and use Ada language
4409         definition instead.
4410         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4411         parameter.
4412         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4413         parameter and use Ada language definition instead.
4414         (ada_val_print_1): Update all ada_val_print_xxx calls.
4415         Remove language parameter.
4416         (ada_val_print): Update ada_val_print_1 call.
4417
4418 2019-05-08  Tom Tromey  <tromey@adacore.com>
4419
4420         * remote.c (remote_hw_watchpoint_limit)
4421         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4422         Now static.
4423
4424 2019-05-08  Tom Tromey  <tromey@adacore.com>
4425
4426         * maint.c (_initialize_maint_cmds): Move initialization code to
4427         remote.c.
4428         (watchdog, show_watchdog): Move to remote.c.
4429         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4430         "watchdog" static.
4431         (_initialize_remote): Move initialization code from maint.c.
4432         * defs.h (watchdog): Don't declare.
4433
4434 2019-05-08  Tom Tromey  <tromey@adacore.com>
4435
4436         * tui/tui-interp.c: Include main.h.
4437         * interps.c: Include main.h.
4438         * main.h (interpreter_p): Declare.
4439         * defs.h (interpreter_p): Don't declare.
4440
4441 2019-05-08  Tom Tromey  <tromey@adacore.com>
4442
4443         * dwarf2loc.c: Include dwarf2read.h.
4444         * defs.h (read_unsigned_leb128): Don't declare.
4445         * dwarf2read.h (read_unsigned_leb128): Declare.
4446
4447 2019-05-08  Tom Tromey  <tromey@adacore.com>
4448
4449         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4450         method.
4451
4452 2019-05-08  Tom Tromey  <tromey@adacore.com>
4453
4454         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4455         when no wrap column is set.
4456
4457 2019-05-08  Tom Tromey  <tromey@adacore.com>
4458
4459         * c-lang.c (c_get_string): Handle non-C-style arrays.
4460
4461 2019-05-08  Tom Tromey  <tromey@adacore.com>
4462
4463         * typeprint.c (print_offset_data::update): Print the bit offset,
4464         not the number of bits remaining.
4465
4466 2019-05-08  Tom Tromey  <tromey@adacore.com>
4467
4468         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4469         padding at end of comment.
4470
4471 2019-05-08  Tom Tromey  <tromey@adacore.com>
4472
4473         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4474         Compare main types.
4475
4476 2019-05-06  Tom Tromey  <tom@tromey.com>
4477
4478         * common/scoped_mmap.c: Include common-defs.h.
4479         * common/scoped_mmap.h: Don't include config.h.
4480
4481 2019-05-04  Tom Tromey  <tom@tromey.com>
4482
4483         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4484         (struct aarch64_call_info): Add initializers.
4485         <si>: Now a std::vector.
4486         (pass_on_stack, aarch64_push_dummy_call): Update.
4487
4488 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4489             Tom Tromey  <tom@tromey.com>
4490
4491         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4492         (ppc_threads): Now a std::vector.  Now static.
4493         (hwdebug_find_thread_points_by_tid)
4494         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4495         Update.
4496
4497 2019-05-04  Tom Tromey  <tom@tromey.com>
4498
4499         * arc-tdep.c (arc_tdesc_init): Return bool.
4500
4501 2019-05-04  Tom Tromey  <tom@tromey.com>
4502
4503         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4504         Use gdb_assert_not_reached.
4505
4506 2019-05-04  Tom Tromey  <tom@tromey.com>
4507
4508         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4509         "false".
4510
4511 2019-05-04  Tom Tromey  <tom@tromey.com>
4512
4513         * arc-tdep.c (arc_tdesc_init): Use bool.
4514
4515 2019-05-04  Tom Tromey  <tom@tromey.com>
4516
4517         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4518
4519 2019-05-04  Tom Tromey  <tom@tromey.com>
4520
4521         * cli/cli-cmds.c (valid_command_p): Return bool.
4522
4523 2019-05-04  Tom Tromey  <tom@tromey.com>
4524
4525         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4526         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4527
4528 2019-05-04  Raul Tambre  <raul@tambre.ee>
4529
4530         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4531         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4532         operator for comparison.
4533
4534 2019-05-04  Tom Tromey  <tom@tromey.com>
4535
4536         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4537         (lookup_partial_symbol, print_partial_symbols)
4538         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4539         (psymbol_compare): Update.
4540         (add_psymbol_to_bcache): Clear the entire psymbol.
4541         (maintenance_check_psymtabs): Update.
4542         * psympriv.h (struct partial_symbol): Don't derive from
4543         general_symbol_info.
4544         <obj_section, unrelocated_address, address,
4545         set_unrelocated_address>: Update.
4546         <ginfo>: New member.
4547         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4548         (debug_names::write_psymbols): Update.
4549
4550 2019-05-04  Tom de Vries  <tdevries@suse.de>
4551
4552         * contrib/cc-with-tweaks.sh: Support -n arg.
4553
4554 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4555
4556         * corelow.c (core_target::detach): Ensure frame cache and
4557         register caches are cleared.
4558         inferior.c (exit_inferior_1): Likewise.
4559
4560 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4561             Tom Tromey  <tom@tromey.com>
4562
4563         * dictionary.c (collate_pending_symbols_by_language): Remove
4564         "struct" from foreach.
4565         * symtab.c (lookup_global_symbol_from_objfile)
4566         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4567         foreach.
4568         * ser-tcp.c (net_open): Remove "struct" from foreach.
4569         * objfiles.c (objfile_relocate, objfile_rebase)
4570         (objfile_has_symbols): Remove "struct" from foreach.
4571         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4572         from foreach.
4573         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4574         foreach.
4575         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4576         "struct" from foreach.
4577         * ada-lang.c (create_excep_cond_exprs)
4578         (ada_exception_catchpoint_cond_string): Remove "struct" from
4579         foreach.
4580
4581 2019-05-03  Tom Tromey  <tromey@adacore.com>
4582
4583         * ada-exp.y (convert_char_literal): Check suffix of each
4584         enumerator.
4585
4586 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4587
4588         PR ada/21406:
4589         * ada-exp.y (yywrap): Don't define.
4590         * ada-lex.l (%option): Add noyywrap
4591         (yywrap): Remove.
4592
4593 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4594
4595         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4596         _WIN32_WINNT to the XP level, unless already defined to a higher
4597         level.
4598
4599         * unittests/parse-connection-spec-selftests.c:
4600         * ser-tcp.c:
4601         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4602         override.
4603
4604         * symfile.c (find_separate_debug_file): Remove colon from the
4605         drive spec of DOS/Windows file names of the target, so that the
4606         file name produced from DEBUGDIR and the target's directory will
4607         be valid on DOS/Windows systems.
4608
4609 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4610
4611         * rust-lang.c (val_print_struct): Handle printing structures
4612         containing strings.
4613
4614 2019-05-02  Tom Tromey  <tromey@adacore.com>
4615
4616         * valarith.c (_initialize_valarith): Remove.
4617
4618 2019-05-01  Tom Tromey  <tromey@adacore.com>
4619
4620         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4621         bitfields.
4622
4623 2019-05-01  Tom Tromey  <tromey@adacore.com>
4624
4625         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4626         for big-endian copies.
4627
4628 2019-04-30  Ali Tamur  <tamur@google.com>
4629         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4630         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4631         (read_3_bytes): New function.
4632
4633 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4634
4635         * windows-nat.c (main_thread_id): Delete.
4636         (handle_output_debug_string): Replace main_thread_id by
4637         current_event.dwThreadId.
4638         (fake_create_process): Likewise.
4639         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4640         Do not set main_thread_id.
4641         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4642         current_event.dwThreadId.
4643         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4644
4645 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4646
4647         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4648         Use current_event.dwThreadId instead of main_thread_id.
4649
4650 2019-04-30  Tom Tromey  <tromey@adacore.com>
4651
4652         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4653         (create_excep_cond_exprs): Iterate over program spaces.
4654         (ada_exception_catchpoint_cond_string): Examine all minimal
4655         symbols for exception types.
4656
4657 2019-04-30  Tom Tromey  <tromey@adacore.com>
4658
4659         PR c++/24470:
4660         * dwarf2read.c (process_structure_scope): Handle case where type
4661         has template parameters but no symbol was created.
4662
4663 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4664             Chris January  <chris.january@arm.com>
4665
4666         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4667         qualifier.
4668         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4669
4670 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4671
4672         * f-typeprint.c (f_print_type): Update rules for printing
4673         whitespace.
4674         (f_type_print_varspec_suffix): Likewise.
4675
4676 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4677             Chris January  <chris.january@arm.com>
4678
4679         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4680         function arguments.
4681
4682 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4683
4684         * f-lang.c (build_fortran_types): Change name of void type to
4685         lower case.
4686         * f-typeprint.c (f_type_print_base): Print the name of the void
4687         type, rather than a fixed string.
4688         * f-valprint.c (f_decorations): Use lower case void string.
4689
4690 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4691             Chris January  <chris.january@arm.com>
4692
4693         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4694         types for Fortran.
4695
4696 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4697             Chris January  <chris.january@arm.com>
4698             David Lecomber  <david.lecomber@arm.com>
4699
4700         * f-exp.y (BINOP_INTRINSIC): New token.
4701         (exp): New parser rule handling BINOP_INTRINSIC.
4702         (f77_keywords): Add new builtin procedures.
4703         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4704         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4705         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4706         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4707         (print_unop_subexp_f): New function.
4708         (print_binop_subexp_f): New function.
4709         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4710         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4711         (dump_subexp_body_f): Likewise.
4712         (operator_check_f): Likewise.
4713         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4714         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4715
4716 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4717
4718         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4719         UNOP_KIND.
4720         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4721         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4722         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4723         (operator_length_f): New fuction.
4724         (print_subexp_f): New function.
4725         (op_name_f): New function.
4726         (dump_subexp_body_f): New function.
4727         (operator_check_f): New function.
4728         (exp_descriptor_f): Replace standard expression handling functions
4729         with new functions.
4730         * gdb/fortran-operator.def: New file.
4731         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4732         * gdb/std-operator.def: Remove UNOP_KIND.
4733
4734 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4735
4736         * std-operator.def: Remove unbalanced, stray double quote
4737         character.
4738
4739 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4740             Chris January  <chris.january@arm.com>
4741             Daniel Everett  <daniel.everett@arm.com>
4742             Nick Forrington  <nick.forrington@arm.com>
4743             Richard Bunt  <richard.bunt@arm.com>
4744
4745         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4746         of depth when printing anonymous structs or unions.
4747         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4748         Don't print either the top-level value, or the children if the
4749         max-depth is exceeded.
4750         (ppscm_print_children): When printing the key of a map, allow one
4751         extra level of depth.
4752         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4753         print either the top-level value, or the children if the max-depth
4754         is exceeded.
4755         (print_children): When printing the key of a map, allow one extra
4756         level of depth.
4757         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4758         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4759         (user_print_options): Initialise max_depth field.
4760         (val_print_scalar_or_string_type_p): New function.
4761         (val_print): Check to see if the max depth has been reached.
4762         (val_print_check_max_depth): Define new function.
4763         (show_print_max_depth): New function.
4764         (_initialize_valprint): Add 'print max-depth' option.
4765         * valprint.h (struct value_print_options) <max_depth>: New field.
4766         (val_print_check_max_depth): Declare new function.
4767         * NEWS: Document new feature.
4768
4769 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4770
4771         * ada-lang.c (ada_language_defn): Initialise new field.
4772         * c-lang.c (c_is_string_type_p): New function.
4773         (c_language_defn): Initialise new field.
4774         (cplus_language_defn): Initialise new field.
4775         (asm_language_defn): Initialise new field.
4776         (minimal_language_defn): Initialise new field.
4777         * c-lang.h (c_is_string_type_p): Declare new function.
4778         * d-lang.c (d_language_defn): Initialise new field.
4779         * f-lang.c (f_is_string_type_p): New function.
4780         (f_language_defn): Initialise new field.
4781         * go-lang.c (go_is_string_type_p): New function.
4782         (go_language_defn): Initialise new field.
4783         * language.c (default_is_string_type_p): New function.
4784         (unknown_language_defn): Initialise new field.
4785         (auto_language_defn): Initialise new field.
4786         * language.h (struct language_defn) <la_is_string_type_p>: New
4787         member variable.
4788         (default_is_string_type_p): Declare new function.
4789         * m2-lang.c (m2_language_defn): Initialise new field.
4790         * objc-lang.c (objc_language_defn): Initialise new field.
4791         * opencl-lang.c (opencl_language_defn): Initialise new field.
4792         * p-lang.c (pascal_is_string_type_p): New function.
4793         (pascal_language_defn): Initialise new field.
4794         * rust-lang.c (rust_is_string_type_p): New function.
4795         (rust_language_defn): Initialise new field.
4796
4797 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4798
4799         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4800         New field.
4801         * ada-lang.c (ada_language_defn): Initialise new field.
4802         * c-lang.c (c_language_defn): Likewise.
4803         (cplus_language_defn): Likewise.
4804         (asm_language_defn): Likewise.
4805         (minimal_language_defn): Likewise.
4806         * d-lang.c (d_language_defn): Likewise.
4807         * f-lang.c (f_language_defn): Likewise.
4808         * go-lang.c (go_language_defn): Likewise.
4809         * language.c (unknown_language_defn): Likewise.
4810         (auto_language_defn): Likewise.
4811         * m2-lang.c (m2_language_defn): Likewise.
4812         * objc-lang.c (objc_language_defn): Likewise.
4813         * opencl-lang.c (opencl_language_defn): Likewise.
4814         * p-lang.c (pascal_language_defn): Likewise.
4815         * rust-lang.c (rust_language_defn): Likewise.
4816
4817 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4818
4819         * ada-lang.c (ada_is_character_type): Change return type to bool.
4820         (ada_is_string_type): Likewise.
4821         * ada-lang.h (ada_is_character_type): Update declaration
4822         (ada_is_string_type): Likewise.
4823
4824 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4825
4826         Support style in 'frame|thread apply'
4827
4828         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4829         * record.c (record_start, record_stop): Update callers of
4830         execute_command_to_string with false.
4831         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4832         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4833         methods.
4834         (class string_file): New constructor with term_out parameter.
4835         Override methods term_out and can_emit_style_escape.  New member
4836         term_out.
4837         (class stdio_file): Override can_emit_style_escape.
4838         (class tee_file): Override term_out and can_emit_style_escape.
4839         * utils.h (can_emit_style_escape): Remove.
4840         * utils.c (can_emit_style_escape): Likewise.
4841         Update all callers of can_emit_style_escape (SOMESTREAM) to
4842         SOMESTREAM->can_emit_style_escape.
4843         * source-cache.c (source_cache::get_source_lines): Likewise.
4844         * stack.c (frame_apply_command_count): Call execute_command_to_string
4845         passing the term_out characteristic of the current gdb_stdout.
4846         * thread.c (thr_try_catch_cmd): Likewise.
4847         * top.c (execute_command_to_string): pass term_out parameter
4848         to construct the string_file for the command output.
4849         * ui-file.c (term_cli_styling): New function (most code moved
4850         from utils.c can_emit_style_escape).
4851         (string_file::string_file, string_file::can_emit_style_escape,
4852         stdio_file::can_emit_style_escape, tee_file::term_out,
4853         tee_file::can_emit_style_escape): New functions.
4854
4855 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4856
4857         * NEWS: Mention the new set|show may-call-functions.
4858         * infcall.c (may_call_functions_p): New variable.
4859         (show_may_call_functions_p): New function.
4860         (call_function_by_hand_dummy): Throws an error if not
4861         may-call-functions.
4862         (_initialize_infcall): Call add_setshow_boolean_cmd for
4863         may-call-functions.
4864
4865 2019-04-25  Keith Seitz  <keiths@redhat.com>
4866
4867         PR c++/24367
4868         * cp-support.c (inspect_type): Don't attempt substitutions
4869         of symbol with the same name.
4870
4871 2019-04-25  Tom Tromey  <tromey@adacore.com>
4872
4873         PR gdb/24475:
4874         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4875         static.
4876
4877 2019-04-25  Tom Tromey  <tromey@adacore.com>
4878
4879         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4880         rvalue reference.
4881         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4882         (gdb_xml_parser::parse): Use std::move.
4883         * python/python-internal.h (gdbpy_convert_exception): Take a const
4884         reference.
4885         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4886         std::move.
4887         * python/py-utils.c (gdbpy_convert_exception): Take a const
4888         reference.
4889         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4890         Use std::move.
4891         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4892         Use std::move.
4893         * mi/mi-main.c (mi_print_exception): Take a const reference.
4894         * main.c (handle_command_errors): Take a const reference.
4895         * linespec.c (parse_linespec): Use std::move.
4896         * infcall.c (run_inferior_call): Use std::move.
4897         (call_function_by_hand_dummy): Use std::move.
4898         * exec.c (try_open_exec_file): Use std::move.
4899         * exceptions.h (exception_print, exception_fprintf)
4900         (exception_print_same): Update.
4901         * exceptions.c (print_exception, exception_print)
4902         (exception_fprintf, exception_print_same): Change parameters to
4903         const reference.
4904         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4905         * common/new-op.c: Use std::move.
4906         * common/common-exceptions.h (struct gdb_exception): Add move
4907         constructor.
4908         (struct gdb_exception_error, struct gdb_exception_quit, struct
4909         gdb_quit_bad_alloc): Change constructor to move constructor.
4910         (throw_exception): Change parameter to rvalue reference.
4911         * common/common-exceptions.c (throw_exception): Take rvalue
4912         reference.
4913         * cli/cli-interp.c (safe_execute_command): Use std::move.
4914         * breakpoint.c (insert_bp_location, location_to_sals): Use
4915         std::move.
4916
4917 2019-04-25  Tom Tromey  <tromey@adacore.com>
4918
4919         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4920         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4921         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4922         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4923         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4924         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4925         guile/scm-value.c: Use unpack.
4926         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4927         gdbscm_gdb_exception.
4928         (gdbscm_throw_gdb_exception): Likewise.
4929         (struct gdbscm_gdb_exception): New.
4930         (unpack): New function.
4931         (gdbscm_wrap): Use unpack.
4932
4933 2019-04-25  Tom Tromey  <tromey@adacore.com>
4934
4935         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4936         (gdb_rl_callback_handler): Use std::move.
4937         * common/common-exceptions.h (struct gdb_exception): Add move
4938         assignment operator.
4939         (throw_exception_sjlj): Change "exception" to const reference.
4940         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4941         (throw_exception_sjlj): Change "exception" to const reference.
4942
4943 2019-04-25  Tom Tromey  <tromey@adacore.com>
4944
4945         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4946         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4947         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4948         Update.
4949         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4950         Update.
4951         * mi/mi-interp.c (mi_interp::exec): Update.
4952         * linespec.c (parse_linespec): Update.
4953         * infcall.c (run_inferior_call): Update.
4954         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4955         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4956         (gdbscm_lookup_global_symbol): Update.
4957         * guile/scm-param.c (gdbscm_parameter_value): Update.
4958         * guile/scm-frame.c (gdbscm_frame_read_register)
4959         (gdbscm_frame_read_var): Update.
4960         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4961         * exec.c (try_open_exec_file): Update.
4962         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4963         (gdb_rl_callback_handler): Update.
4964         * common/common-exceptions.h (exception_none): Don't declare.
4965         * common/common-exceptions.c (exception_none): Don't define.
4966         (struct catcher) <exception>: Update.
4967         * cli/cli-interp.c (safe_execute_command): Update.
4968         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4969
4970 2019-04-25  Ali Tamur  <tamur@google.com>
4971
4972         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4973         (read_attribute_value): Likewise.
4974         (dwarf2_read_addr_index): Update comment.
4975         (read_str_index): Add DW_FORM_strx.
4976         (dwarf2_string_attr): Likewise.
4977         (dwarf2_const_value_attr): Likewise.
4978         (dump_die_shallow): Likewise.
4979         (dwarf2_fetch_constant_bytes): Likewise.
4980         (skip_form_bytes): Likewise.
4981         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4982
4983 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4984
4985         PR corefiles/11608
4986         PR corefiles/18187
4987         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4988         OFFSET.  Verify if current mapping contains an ELF header.
4989         (linux_find_memory_regions_full): Adjust call to
4990         dump_mapping_p.
4991
4992 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4993             Kang Li <kanglictf@gmail.com>
4994
4995         PR gdb/21600
4996
4997         * dwarf2-frame.c (read_initial_length): Be consistent about using
4998         unsigned representation of length.
4999         (decode_frame_entry_1): Likewise.  Check for wraparound of
5000         end pointer as well as buffer overflow.
5001
5002 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5003
5004         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5005         "vq".
5006
5007 2019-04-24  Tom Tromey  <tromey@adacore.com>
5008
5009         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5010
5011 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5012
5013         * s12z-tdep.c (s12z_unwind_pc): Delete.
5014         (s12z_unwind_sp): Delete.
5015         (s12z_gdbarch_init): Don't register deleted functions with
5016         gdbarch.
5017
5018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5019
5020         * rl78-tdep.c (rl78_unwind_sp): Delete.
5021         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5022
5023 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5024
5025         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5026         (xstormy16_unwind_pc): Delete.
5027         (xstormy16_dummy_id): Delete.
5028         (xstormy16_gdbarch_init): Don't register deleted functions with
5029         gdbarch.
5030
5031 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5032
5033         * vax-tdep.c (vax_unwind_pc): Delete.
5034         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5035
5036 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5037
5038         * v850-tdep.c (v850_unwind_sp): Delete.
5039         (v850_unwind_pc): Delete.
5040         (v850_dummy_id): Delete.
5041         (v850_gdbarch_init): Don't register deleted functions with
5042         gdbarch.
5043
5044 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5045
5046         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5047         (tilegx_unwind_pc): Delete.
5048         (tilegx_unwind_dummy_id): Delete.
5049         (tilegx_gdbarch_init): Don't register deleted functions with
5050         gdbarch.
5051
5052 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5053
5054         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5055         (tic6x_dummy_id): Delete.
5056         (tic6x_gdbarch_init): Don't register deleted functions with
5057         gdbarch.
5058
5059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5060
5061         * sparc-tdep.c (sparc_unwind_pc): Delete.
5062         (sparc32_gdbarch_init): Don't register deleted function with
5063         gdbarch.
5064
5065 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5066
5067         * sh-tdep.c (sh_unwind_sp): Delete.
5068         (sh_unwind_pc): Delete.
5069         (sh_dummy_id): Delete.
5070         (sh_gdbarch_init): Don't register deleted functions with
5071         gdbarch.
5072
5073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5074
5075         * score-tdep.c (score_unwind_sp): Delete.
5076         (score_unwind_pc): Delete.
5077         (score_dummy_id): Delete.
5078         (score_gdbarch_init): Don't register deleted functions with
5079         gdbarch.
5080
5081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5082
5083         * rx-tdep.c (rx_unwind_pc): Delete.
5084         (rx_unwind_sp): Delete.
5085         (rx_dummy_id): Delete.
5086         (rx_gdbarch_init): Don't register deleted functions with
5087         gdbarch.  Update comment.
5088
5089 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5090
5091         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5092         (rs6000_dummy_id): Delete.
5093         (rs6000_gdbarch_init): Don't register deleted functions with
5094         gdbarch.
5095
5096 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5097
5098         * or1k-tdep.c (or1k_dummy_id): Delete.
5099         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5100
5101 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5102
5103         * nios2-tdep.c (nios2_dummy_id): Delete.
5104         (nios2_unwind_sp): Delete.
5105         (nios2_gdbarch_init): Don't register deleted functions with
5106         gdbarch.
5107
5108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5109
5110         * nds32-tdep.c (nds32_dummy_id): Delete.
5111         (nds32_unwind_pc): Delete.
5112         (nds32_unwind_sp): Delete.
5113         (nds32_gdbarch_init): Don't register deleted functions with
5114         gdbarch.
5115
5116 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5117
5118         * msp430-tdep.c (msp430_unwind_pc): Delete.
5119         (msp430_unwind_sp): Delete.
5120         (msp430_dummy_id): Delete.
5121         (msp430_gdbarch_init): Don't register deleted functions with
5122         gdbarch.
5123
5124 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5125
5126         * moxie-tdep.c (moxie_unwind_sp): Delete.
5127         (moxie_unwind_pc): Delete.
5128         (moxie_dummy_id): Delete.
5129         (moxie_gdbarch_init): Don't register deleted functions with
5130         gdbarch.
5131
5132 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5133
5134         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5135         (mn10300_unwind_pc): Delete.
5136         (mn10300_unwind_sp): Delete.
5137         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5138         mn10300_unwind_sp.
5139         (mn10300_frame_unwind_init): Don't register deleted functions with
5140         gdbarch.
5141
5142 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5143
5144         * mep-tdep.c (mep_unwind_pc): Delete.
5145         (mep_unwind_sp): Delete.
5146         (mep_dummy_id): Delete.
5147         (mep_gdbarch_init): Don't register deleted functions with
5148         gdbarch.
5149
5150 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5151
5152         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5153         (m68hc11_unwind_sp): Delete.
5154         (m68hc11_gdbarch_init): Don't register deleted functions with
5155         gdbarch.
5156
5157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5158
5159         * m32r-tdep.c (m32r_unwind_sp): Delete.
5160         (m32r_unwind_pc): Delete.
5161         (m32r_dummy_id): Delete.
5162         (m32r_gdbarch_init): Don't register deleted functions with
5163         gdbarch.
5164
5165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5166
5167         * m32c-tdep.c (m32c_unwind_pc): Delete.
5168         (m32c_unwind_sp): Delete.
5169         (m32c_dummy_id): Delete.
5170         (m32c_gdbarch_init): Don't register deleted functions with
5171         gdbarch.
5172
5173 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5174
5175         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5176         (lm32_unwind_pc): Delete.
5177         (lm32_dummy_id): Delete.
5178         (lm32_gdbarch_init): Don't register deleted functions with
5179         gdbarch.
5180
5181 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5182
5183         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5184         (iq2000_unwind_pc): Delete.
5185         (iq2000_dummy_id): Delete.
5186         (iq2000_gdbarch_init): Don't register deleted functions with
5187         gdbarch.
5188
5189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5190
5191         * nds32-tdep.c (nds32_type_align): Delete.
5192         (nds32_push_dummy_call): Use type_align instead.
5193
5194 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5195
5196         * arm-tdep.c (arm_type_align): Only handle vector override case.
5197         (arm_push_dummy_call): Use type_align.
5198         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5199
5200 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5201
5202         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5203         case.
5204         (pass_on_stack): Use type_align.
5205         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5206         function.
5207
5208 2019-04-23  Tom Tromey  <tromey@adacore.com>
5209
5210         * dwarf2read.c (line_header::file_name_at): Remove unused
5211         overload.
5212
5213 2019-04-23  Tom de Vries  <tdevries@suse.de>
5214
5215         PR gdb/24438
5216         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5217         invocation.
5218
5219
5220 2019-03-27  Ali Tamur  <tamur@google.com>
5221
5222         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5223         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5224         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5225         (dwarf_expr_context::get_addr_index): Likewise
5226         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5227         (symbol_needs_eval_context::get_addr_index): Likewise
5228         (disassemble_dwarf_expression): Add DW_OP_addrx
5229         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5230         (read_cutu_die_from_dwo): Update comment
5231         (skip_one_die): Add DW_FORM_addrx
5232         (read_attribute_value): Likewise
5233         (var_decode_location): Add DW_OP_addrx
5234         (dwarf2_const_value_attr): Add DW_FORM_addrx
5235         (dump_die_shallow): Likewise
5236         (dwarf2_fetch_constant_bytes): Likewise
5237         (decode_locdesc): Add DW_OP_addrx
5238         (skip_form_bytes): Add DW_FORM_addrx
5239
5240 2019-04-22  Ali Tamur  <tamur@google.com>
5241
5242         * MAINTAINERS (Write After Approval): Add self.
5243
5244 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5245
5246         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5247         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5248         (open_symbol_file_object): Likewise.
5249         (svr4_default_sos): Add info parameter.
5250         (svr4_read_so_list): Likewise.
5251         (svr4_current_sos_direct): Adjust functions calls to pass down
5252         info.
5253         (svr4_current_sos_1): Add info parameter.
5254         (svr4_current_sos): Call get_svr4_info, pass info down to
5255         svr4_current_sos_1.
5256         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5257         get_svr4_info.
5258         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5259         get_svr4_info.
5260         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5261         to get_svr4_info.
5262         (probes_table_remove_objfile_probes): Likewise.
5263         (register_solib_event_probe): Add info parameter.
5264         (solist_update_incremental): Pass info parameter down to
5265         svr4_read_so_list.
5266         (disable_probes_interface): Add info parameter.
5267         (svr4_handle_solib_event): Pass current_program_space to
5268         get_svr4_info.  Adjust disable_probes_interface cleanup.
5269         (svr4_create_probe_breakpoints): Add info parameter, pass it
5270         down to register_solib_event_probe.
5271         (svr4_create_solib_event_breakpoints): Add info parameter,
5272         pass it down to svr4_create_probe_breakpoints.
5273         (enable_break): Pass info down to
5274         svr4_create_solib_event_breakpoints.
5275         (svr4_solib_create_inferior_hook): Pass current_program_space to
5276         get_svr4_info.
5277         (svr4_clear_solib): Likewise.
5278
5279 2019-04-22  Pedro Alves  <palves@redhat.com>
5280
5281         * solib-svr4.c (svr4_free_objfile_observer): New.
5282         (probe_and_action::objfile): New field.
5283         (probes_table_htab_remove_objfile_probes)
5284         (probes_table_remove_objfile_probes): New functions.
5285         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5286         in the new probe_and_action.  Don't store the probe in 'lookup'.
5287         (svr4_create_probe_breakpoints): Pass objfile to
5288         register_solib_event_probe.
5289         (_initialize_svr4_solib): Register a free_objfile observer.
5290
5291 2019-04-19  Tom Tromey  <tom@tromey.com>
5292
5293         * common/queue.h: Remove.
5294
5295 2019-04-19  Tom Tromey  <tom@tromey.com>
5296
5297         * event-loop.c: Don't include "common/queue.h".
5298
5299 2019-04-19  Tom Tromey  <tom@tromey.com>
5300
5301         * remote.c (remote_target): Use delete.
5302         * remote-notif.h: Include <list>, not "common/queue.h".
5303         (notif_client_p): Remove typedef.
5304         (remote_notif_state): Add constructor, destructor, initializer.
5305         <notif_queue>: Now a std::list.
5306         (remote_notif_state_xfree): Don't declare.
5307         * remote-notif.c (remote_notif_process, handle_notification)
5308         (remote_notif_state_allocate): Update.
5309         (~remote_notif_state): Rename from remote_notif_state_xfree.
5310
5311 2019-04-19  Tom Tromey  <tom@tromey.com>
5312
5313         * symfile.c (reread_symbols): Update.
5314         * objfiles.c (objfile_register_static_link)
5315         (objfile_lookup_static_link): Update
5316         (~objfile) Don't delete static_links.
5317         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5318
5319 2019-04-19  Tom Tromey  <tom@tromey.com>
5320
5321         * type-stack.h (struct type_stack) <insert>: Constify string.
5322         * type-stack.c (type_stack::insert): Constify string.
5323         * gdbtypes.h (lookup_template_type): Update.
5324         (address_space_name_to_int): Update.
5325         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5326         const.
5327         (lookup_template_type): Make name const.
5328         * c-exp.y: Update rules.
5329         (lex_one_token, classify_name, classify_inner_name)
5330         (c_print_token): Update.
5331         * p-exp.y: Update rules.
5332         (yylex): Update.
5333         * f-exp.y: Update rules.
5334         (yylex): Update.
5335         * d-exp.y: Update rules.
5336         (lex_one_token, classify_name, classify_inner_name): Update.
5337         * parse.c (write_dollar_variable, copy_name): Return std::string.
5338         * parser-defs.h (copy_name): Change return type.
5339         * m2-exp.y: Update rules.
5340         (yylex): Update.
5341         * go-exp.y (lex_one_token): Update.
5342         Update rules.
5343         (classify_unsafe_function, classify_packaged_name)
5344         (classify_name, yylex): Update.
5345
5346 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5347
5348         * configure.ac: add --enable-source-highlight switch.
5349         * configure: Regenerate.
5350         * top.c (print_gdb_version): plumb --enable-source-highlight
5351         status to "show configuration".
5352
5353 2019-04-19  Tom Tromey  <tromey@adacore.com>
5354
5355         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5356         Check ADA_TYPE_P.
5357         (empty_record, ada_template_to_fixed_record_type_1)
5358         (template_to_static_fixed_type)
5359         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5360         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5361         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5362         macros.
5363
5364 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5365
5366         PR symtab/24423:
5367         * source.c (print_source_lines_base): Advance "iter" when a
5368         control character is seen.
5369
5370 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5371
5372         * inferior.h (struct infcall_suspend_state_deleter):
5373         Catch exception in destructor to avoid crash.
5374
5375 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5376
5377         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5378         close to the add_com "shell".
5379
5380 2019-04-18  Tom Tromey  <tromey@adacore.com>
5381
5382         * process-stratum-target.h (class process_stratum_target)
5383         <stratum>: Add "final".
5384
5385 2019-04-17  Tom Tromey  <tromey@adacore.com>
5386
5387         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5388         against nullptr before use.
5389
5390 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5391
5392         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5393
5394 2019-04-17  Jim Wilson  <jimw@sifive.com>
5395             Andrew Burgess  <andrew.burgess@embecosm.com>
5396
5397         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5398         code read might fail, assume 4-byte breakpoint in that case.
5399
5400 2019-04-15  Leszek Swirski  <leszeks@google.com>
5401
5402         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5403         rather than a hand-rolled POD check when checking for forced MEMORY
5404         classification.
5405
5406 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5407
5408         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5409         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5410         function.
5411         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5412         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5413         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5414         declaration.
5415
5416 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5417
5418         * aarch64-linux-nat.c
5419         (aarch64_linux_nat_target::thread_architecture): Add override.
5420         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5421         each VQ.
5422
5423 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5424
5425         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5426
5427 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5428
5429         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5430         target types of size 96-bits, add some additional comments, and
5431         check that the builtin type we found was the correct size.
5432
5433 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5434
5435         * utils.c (prompt_for_continue): Don't restore the styling at the
5436         end, as applied_style has the wrong value.  This fixes styling in
5437         long lists of file names that are interrupted by the "Continue?"
5438         prompt.
5439
5440 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5441
5442         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5443         * c-lang.c (c_language_defn): Likewise.
5444         (cplus_language_defn): Likewise.
5445         (asm_language_defn): Likewise.
5446         (minimal_language_defn): Likewise.
5447         * d-lang.c (d_language_defn): Likewise.
5448         * f-lang.c (f_language_defn): Likewise.
5449         * go-lang.c (go_language_defn): Likewise.
5450         * language.c (unknown_language_defn): Likewise.
5451         (auto_language_defn): Likewise.
5452         * language.h (struct language_defn): Remove la_magic field.
5453         (LANG_MAGIC): Delete.
5454         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5455         * objc-lang.c (objc_language_defn): Likewise.
5456         * opencl-lang.c (opencl_language_defn): Likewise.
5457         * p-lang.c (pascal_language_defn): Likewise.
5458         * rust-lang.c (rust_language_defn): Likewise.
5459
5460 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5461
5462         * riscv-tdep.c (riscv_type_align): New function.
5463         (riscv_type_alignment): Delete.
5464         (riscv_arg_location): Use 'type_align'.
5465         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5466
5467 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5468
5469         * gdbtypes.c (type_align): A struct with no non-static fields also
5470         has alignment of 1.
5471
5472 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5473
5474         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5475         component to 0.
5476         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5477         member.
5478         (riscv_struct_info::analyse): New implementation using new
5479         analyse_inner member function.
5480         (riscv_struct_info::field_offset): New member function.
5481         (riscv_struct_info::m_offsets): New member variable.
5482         (riscv_struct_info::analyse_inner): New private member function,
5483         takes the old implementation of riscv_struct_info::analyse but
5484         extended to track field offsets.
5485         (riscv_call_arg_struct): Update the struct folding special cases
5486         to handle cases where empty C++ structs, which are non-zero
5487         length, are found.
5488         (riscv_arg_location): Initialise the length of each location, a
5489         non-zero length now indicates the location is in use.
5490         (riscv_push_dummy_call): Allow for the first location having a
5491         non-zero offset when setting up arguments.
5492         (riscv_return_value): Likewise, but for return values.
5493
5494 2019-04-11  Tom Tromey  <tromey@adacore.com>
5495
5496         * utils.c (internal_vproblem): Make "msg" const.
5497
5498 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5499
5500         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5501         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5502         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5503         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5504
5505 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5506
5507         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5508         function.
5509         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5510         of amd64_collect_native_gregset.
5511         (amd64_linux_nat_target::store_registers): Likewise.
5512
5513 2019-04-10  Tom Tromey  <tom@tromey.com>
5514
5515         * symtab.c (lookup_global_symbol_from_objfile)
5516         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5517         * objfiles.h (class separate_debug_iterator): New.
5518         (class separate_debug_range): New.
5519         (struct objfile) <separate_debug_objfiles>: New method.
5520         (objfile_separate_debug_iterate): Don't declare.
5521         * objfiles.c (separate_debug_iterator::operator++): Rename from
5522         objfile_separate_debug_iterate.
5523         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5524         iterator.
5525         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5526         iterator.
5527
5528 2019-04-10  Tom Tromey  <tom@tromey.com>
5529
5530         * symfile.c (reread_symbols): Remove old comment.
5531         * objfiles.c (free_all_objfiles): Fix a typo.
5532
5533 2019-04-10  Tom Tromey  <tom@tromey.com>
5534
5535         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5536         * minsyms.c (lookup_minimal_symbol): Use foreach.
5537         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5538         (lookup_minimal_symbol_solib_trampoline): Likewise.
5539         * symfile.c (reread_symbols): Use foreach.
5540
5541 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5542             Tom Tromey  <tromey@adacore.com>
5543
5544         PR rust/24414:
5545         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5546         (rust_lex_int_test): Change "value" to be LONGEST.
5547         (rust_lex_tests): Add test for long integer literal.
5548
5549 2019-04-09  Tom Tromey  <tromey@adacore.com>
5550
5551         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5552         to bool.
5553         (extended_remote_target::attach): Update.
5554         (remote_target::remote_notice_new_inferior): Update.
5555         (remote_target::add_current_inferior_and_thread): Update.
5556         * inferior.c (exit_inferior_1): Use "false".
5557         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5558
5559 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5560
5561         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5562         the "start" command.
5563
5564 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5565
5566         * python/py-inferior.c (infpy_thread_from_thread_handle):
5567         Adjust comments to reflect renaming of thread_from_thread_handle
5568         to thread_from_handle.  Adjust keywords.  Fix type error message.
5569         (inferior_object_methods): Add thread_from_handle.  Retain
5570         thread_from_thread_handle, but mark it as deprecated.
5571
5572 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5573
5574         * gdbthread.h (find_thread_by_handle): Revise declaration.
5575         * thread.c (find_thread_by_handle): Likewise.  Adjust
5576         implementation too.
5577         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5578         support for buffer objects as handles.
5579
5580 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5581
5582         * python/py-infthread.c (thpy_thread_handle): New function.
5583         (thread_object_methods): Register thpy_thread_handle.
5584
5585 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5586
5587         * gdbthread.h (thread_to_thread_handle): Declare.
5588         * thread.c (gdbtypes.h): Include.
5589         (thread_to_thread_handle): New function.
5590
5591         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5592         (target_thread_info_to_thread_handle): Declare.
5593         * target.c (target_thread_info_to_thread_handle): New function.
5594         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5595         * target-delegates.c: Regenerate.
5596
5597         * linux-thread-db.c (class thread_db_target): Add method
5598         thread_info_to_thread_handle.
5599         (thread_db_target::thread_info_to_thread_handle): Define.
5600         * remote.c (class remote_target): Add new method
5601         thread_info_to_thread_handle.
5602         (remote_target::thread_info_to_thread_handle): Define.
5603
5604 2019-04-08  Pedro Alves  <palves@redhat.com>
5605
5606         * common/common-exceptions.c (throw_exception): Don't create
5607         named object to throw; throw directly.
5608         (throw_it): Likewise.  Don't initialize gdb_exception::message
5609         here, with new; pass FMT and AP to the ctor instead.
5610         * common/common-exceptions.h: Include <string>.
5611         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5612         const char *, va_list)): New ctor.  Use std::make_shared.
5613         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5614         errors)): Delete.
5615         (gdb_exception_error::gdb_exception_error(enum errors, const char
5616         *, va_list)): New.
5617         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5618         Add assertion.
5619         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5620         errors)): Delete.
5621         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5622         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5623         Add assertion.
5624
5625 2019-04-08  Tom Tromey  <tom@tromey.com>
5626
5627         * valops.c (value_rtti_indirect_type): Replace throw_exception
5628         with throw.
5629         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5630         with throw.
5631         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5632         throw.
5633         * target.c (target_translate_tls_address): Replace throw_exception
5634         with throw.
5635         * stack.c (frame_apply_command_count): Replace throw_exception
5636         with throw.
5637         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5638         throw.
5639         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5640         with throw.
5641         * rs6000-tdep.c (rs6000_frame_cache)
5642         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5643         * remote.c: Replace throw_exception with throw.
5644         * record-full.c (record_full_message, record_full_wait_1)
5645         (record_full_restore): Replace throw_exception with throw.
5646         * record-btrace.c:
5647         (get_thread_current_frame_id, record_btrace_start_replaying)
5648         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5649         (cmd_record_btrace_start): Replace throw_exception with throw.
5650         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5651         throw.
5652         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5653         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5654         * linespec.c:
5655         (find_linespec_symbols): Replace throw_exception with throw.
5656         * infrun.c (displaced_step_prepare, resume): Replace
5657         throw_exception with throw.
5658         * infcmd.c (post_create_inferior): Replace throw_exception with
5659         throw.
5660         * inf-loop.c (inferior_event_handler): Replace throw_exception
5661         with throw.
5662         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5663         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5664         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5665         (get_prev_frame_always, get_frame_pc_if_available)
5666         (get_frame_address_in_block_if_available, get_frame_language):
5667         Replace throw_exception with throw.
5668         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5669         throw_exception with throw.
5670         * eval.c (fetch_subexp_value, evaluate_var_value)
5671         (evaluate_funcall, evaluate_subexp_standard): Replace
5672         throw_exception with throw.
5673         * dwarf2loc.c (call_site_find_chain)
5674         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5675         Replace throw_exception with throw.
5676         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5677         with throw.
5678         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5679         throw.
5680         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5681         * completer.c (complete_line_internal): Replace throw_exception
5682         with throw.
5683         * compile/compile-object-run.c (compile_object_run): Replace
5684         throw_exception with throw.
5685         * cli/cli-script.c (process_next_line): Replace throw_exception
5686         with throw.
5687         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5688         (btrace_enable, btrace_maint_update_pt_packets): Replace
5689         throw_exception with throw.
5690         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5691         throw_exception with throw.
5692         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5693         throw_exception with throw.
5694         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5695         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5696         * aarch64-tdep.c (aarch64_make_prologue_cache)
5697         (aarch64_make_stub_cache): Replace throw_exception with throw.
5698
5699 2019-04-08  Tom Tromey  <tom@tromey.com>
5700
5701         * common/common-exceptions.c (throw_exception): Rename from
5702         throw_exception_cxx.  Remove old copy.  Make argument const.
5703         (throw_it): Create and throw exception objects directly.
5704         * common/common-exceptions.h (throw_exception): Make argument
5705         const.
5706         (struct gdb_exception_error): Add constructor.
5707         (struct gdb_exception_quit): Add constructor.
5708
5709 2019-04-08  Tom Tromey  <tom@tromey.com>
5710
5711         * common/common-exceptions.h (exception_rethrow): Don't declare.
5712         (TRY_SJLJ): Update comment.
5713         (TRY, CATCH, END_CATCH): Remove.
5714         * common/common-exceptions.c (exception_rethrow): Remove.
5715
5716 2019-04-08  Tom Tromey  <tom@tromey.com>
5717
5718         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5719         Remove.
5720         (gdb_exception_error): Rename from
5721         gdb_exception_RETURN_MASK_ERROR.
5722         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5723         (gdb_quit_bad_alloc): Update.
5724         * aarch64-tdep.c: Update.
5725         * ada-lang.c: Update.
5726         * ada-typeprint.c: Update.
5727         * ada-valprint.c: Update.
5728         * amd64-tdep.c: Update.
5729         * arch-utils.c: Update.
5730         * break-catch-throw.c: Update.
5731         * breakpoint.c: Update.
5732         * btrace.c: Update.
5733         * c-varobj.c: Update.
5734         * cli/cli-cmds.c: Update.
5735         * cli/cli-interp.c: Update.
5736         * cli/cli-script.c: Update.
5737         * common/common-exceptions.c: Update.
5738         * common/new-op.c: Update.
5739         * common/selftest.c: Update.
5740         * compile/compile-c-symbols.c: Update.
5741         * compile/compile-cplus-symbols.c: Update.
5742         * compile/compile-object-load.c: Update.
5743         * compile/compile-object-run.c: Update.
5744         * completer.c: Update.
5745         * corelow.c: Update.
5746         * cp-abi.c: Update.
5747         * cp-support.c: Update.
5748         * cp-valprint.c: Update.
5749         * darwin-nat.c: Update.
5750         * disasm-selftests.c: Update.
5751         * dtrace-probe.c: Update.
5752         * dwarf-index-cache.c: Update.
5753         * dwarf-index-write.c: Update.
5754         * dwarf2-frame-tailcall.c: Update.
5755         * dwarf2-frame.c: Update.
5756         * dwarf2loc.c: Update.
5757         * dwarf2read.c: Update.
5758         * eval.c: Update.
5759         * event-loop.c: Update.
5760         * event-top.c: Update.
5761         * exec.c: Update.
5762         * f-valprint.c: Update.
5763         * fbsd-tdep.c: Update.
5764         * frame-unwind.c: Update.
5765         * frame.c: Update.
5766         * gdbtypes.c: Update.
5767         * gnu-v3-abi.c: Update.
5768         * guile/guile-internal.h: Update.
5769         * guile/scm-block.c: Update.
5770         * guile/scm-breakpoint.c: Update.
5771         * guile/scm-cmd.c: Update.
5772         * guile/scm-disasm.c: Update.
5773         * guile/scm-frame.c: Update.
5774         * guile/scm-lazy-string.c: Update.
5775         * guile/scm-math.c: Update.
5776         * guile/scm-param.c: Update.
5777         * guile/scm-ports.c: Update.
5778         * guile/scm-pretty-print.c: Update.
5779         * guile/scm-symbol.c: Update.
5780         * guile/scm-symtab.c: Update.
5781         * guile/scm-type.c: Update.
5782         * guile/scm-value.c: Update.
5783         * i386-linux-tdep.c: Update.
5784         * i386-tdep.c: Update.
5785         * inf-loop.c: Update.
5786         * infcall.c: Update.
5787         * infcmd.c: Update.
5788         * infrun.c: Update.
5789         * jit.c: Update.
5790         * language.c: Update.
5791         * linespec.c: Update.
5792         * linux-fork.c: Update.
5793         * linux-nat.c: Update.
5794         * linux-tdep.c: Update.
5795         * linux-thread-db.c: Update.
5796         * main.c: Update.
5797         * mi/mi-cmd-break.c: Update.
5798         * mi/mi-cmd-stack.c: Update.
5799         * mi/mi-interp.c: Update.
5800         * mi/mi-main.c: Update.
5801         * objc-lang.c: Update.
5802         * p-valprint.c: Update.
5803         * parse.c: Update.
5804         * ppc-linux-tdep.c: Update.
5805         * printcmd.c: Update.
5806         * python/py-arch.c: Update.
5807         * python/py-breakpoint.c: Update.
5808         * python/py-cmd.c: Update.
5809         * python/py-finishbreakpoint.c: Update.
5810         * python/py-frame.c: Update.
5811         * python/py-framefilter.c: Update.
5812         * python/py-gdb-readline.c: Update.
5813         * python/py-inferior.c: Update.
5814         * python/py-infthread.c: Update.
5815         * python/py-lazy-string.c: Update.
5816         * python/py-linetable.c: Update.
5817         * python/py-objfile.c: Update.
5818         * python/py-param.c: Update.
5819         * python/py-prettyprint.c: Update.
5820         * python/py-progspace.c: Update.
5821         * python/py-record-btrace.c: Update.
5822         * python/py-record.c: Update.
5823         * python/py-symbol.c: Update.
5824         * python/py-type.c: Update.
5825         * python/py-unwind.c: Update.
5826         * python/py-utils.c: Update.
5827         * python/py-value.c: Update.
5828         * python/python.c: Update.
5829         * record-btrace.c: Update.
5830         * record-full.c: Update.
5831         * remote-fileio.c: Update.
5832         * remote.c: Update.
5833         * riscv-tdep.c: Update.
5834         * rs6000-aix-tdep.c: Update.
5835         * rs6000-tdep.c: Update.
5836         * rust-exp.y: Update.
5837         * rust-lang.c: Update.
5838         * s390-tdep.c: Update.
5839         * selftest-arch.c: Update.
5840         * solib-dsbt.c: Update.
5841         * solib-frv.c: Update.
5842         * solib-spu.c: Update.
5843         * solib-svr4.c: Update.
5844         * solib.c: Update.
5845         * sparc64-linux-tdep.c: Update.
5846         * stack.c: Update.
5847         * symfile-mem.c: Update.
5848         * symmisc.c: Update.
5849         * target.c: Update.
5850         * thread.c: Update.
5851         * top.c: Update.
5852         * tracefile-tfile.c: Update.
5853         * tui/tui.c: Update.
5854         * typeprint.c: Update.
5855         * unittests/cli-utils-selftests.c: Update.
5856         * unittests/parse-connection-spec-selftests.c: Update.
5857         * valops.c: Update.
5858         * valprint.c: Update.
5859         * value.c: Update.
5860         * varobj.c: Update.
5861         * windows-nat.c: Update.
5862         * x86-linux-nat.c: Update.
5863         * xml-support.c: Update.
5864
5865 2019-04-08  Tom Tromey  <tom@tromey.com>
5866
5867         * xml-support.c: Use C++ exception handling.
5868         * x86-linux-nat.c: Use C++ exception handling.
5869         * windows-nat.c: Use C++ exception handling.
5870         * varobj.c: Use C++ exception handling.
5871         * value.c: Use C++ exception handling.
5872         * valprint.c: Use C++ exception handling.
5873         * valops.c: Use C++ exception handling.
5874         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5875         handling.
5876         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5877         * typeprint.c: Use C++ exception handling.
5878         * tui/tui.c: Use C++ exception handling.
5879         * tracefile-tfile.c: Use C++ exception handling.
5880         * top.c: Use C++ exception handling.
5881         * thread.c: Use C++ exception handling.
5882         * target.c: Use C++ exception handling.
5883         * symmisc.c: Use C++ exception handling.
5884         * symfile-mem.c: Use C++ exception handling.
5885         * stack.c: Use C++ exception handling.
5886         * sparc64-linux-tdep.c: Use C++ exception handling.
5887         * solib.c: Use C++ exception handling.
5888         * solib-svr4.c: Use C++ exception handling.
5889         * solib-spu.c: Use C++ exception handling.
5890         * solib-frv.c: Use C++ exception handling.
5891         * solib-dsbt.c: Use C++ exception handling.
5892         * selftest-arch.c: Use C++ exception handling.
5893         * s390-tdep.c: Use C++ exception handling.
5894         * rust-lang.c: Use C++ exception handling.
5895         * rust-exp.y: Use C++ exception handling.
5896         * rs6000-tdep.c: Use C++ exception handling.
5897         * rs6000-aix-tdep.c: Use C++ exception handling.
5898         * riscv-tdep.c: Use C++ exception handling.
5899         * remote.c: Use C++ exception handling.
5900         * remote-fileio.c: Use C++ exception handling.
5901         * record-full.c: Use C++ exception handling.
5902         * record-btrace.c: Use C++ exception handling.
5903         * python/python.c: Use C++ exception handling.
5904         * python/py-value.c: Use C++ exception handling.
5905         * python/py-utils.c: Use C++ exception handling.
5906         * python/py-unwind.c: Use C++ exception handling.
5907         * python/py-type.c: Use C++ exception handling.
5908         * python/py-symbol.c: Use C++ exception handling.
5909         * python/py-record.c: Use C++ exception handling.
5910         * python/py-record-btrace.c: Use C++ exception handling.
5911         * python/py-progspace.c: Use C++ exception handling.
5912         * python/py-prettyprint.c: Use C++ exception handling.
5913         * python/py-param.c: Use C++ exception handling.
5914         * python/py-objfile.c: Use C++ exception handling.
5915         * python/py-linetable.c: Use C++ exception handling.
5916         * python/py-lazy-string.c: Use C++ exception handling.
5917         * python/py-infthread.c: Use C++ exception handling.
5918         * python/py-inferior.c: Use C++ exception handling.
5919         * python/py-gdb-readline.c: Use C++ exception handling.
5920         * python/py-framefilter.c: Use C++ exception handling.
5921         * python/py-frame.c: Use C++ exception handling.
5922         * python/py-finishbreakpoint.c: Use C++ exception handling.
5923         * python/py-cmd.c: Use C++ exception handling.
5924         * python/py-breakpoint.c: Use C++ exception handling.
5925         * python/py-arch.c: Use C++ exception handling.
5926         * printcmd.c: Use C++ exception handling.
5927         * ppc-linux-tdep.c: Use C++ exception handling.
5928         * parse.c: Use C++ exception handling.
5929         * p-valprint.c: Use C++ exception handling.
5930         * objc-lang.c: Use C++ exception handling.
5931         * mi/mi-main.c: Use C++ exception handling.
5932         * mi/mi-interp.c: Use C++ exception handling.
5933         * mi/mi-cmd-stack.c: Use C++ exception handling.
5934         * mi/mi-cmd-break.c: Use C++ exception handling.
5935         * main.c: Use C++ exception handling.
5936         * linux-thread-db.c: Use C++ exception handling.
5937         * linux-tdep.c: Use C++ exception handling.
5938         * linux-nat.c: Use C++ exception handling.
5939         * linux-fork.c: Use C++ exception handling.
5940         * linespec.c: Use C++ exception handling.
5941         * language.c: Use C++ exception handling.
5942         * jit.c: Use C++ exception handling.
5943         * infrun.c: Use C++ exception handling.
5944         * infcmd.c: Use C++ exception handling.
5945         * infcall.c: Use C++ exception handling.
5946         * inf-loop.c: Use C++ exception handling.
5947         * i386-tdep.c: Use C++ exception handling.
5948         * i386-linux-tdep.c: Use C++ exception handling.
5949         * guile/scm-value.c: Use C++ exception handling.
5950         * guile/scm-type.c: Use C++ exception handling.
5951         * guile/scm-symtab.c: Use C++ exception handling.
5952         * guile/scm-symbol.c: Use C++ exception handling.
5953         * guile/scm-pretty-print.c: Use C++ exception handling.
5954         * guile/scm-ports.c: Use C++ exception handling.
5955         * guile/scm-param.c: Use C++ exception handling.
5956         * guile/scm-math.c: Use C++ exception handling.
5957         * guile/scm-lazy-string.c: Use C++ exception handling.
5958         * guile/scm-frame.c: Use C++ exception handling.
5959         * guile/scm-disasm.c: Use C++ exception handling.
5960         * guile/scm-cmd.c: Use C++ exception handling.
5961         * guile/scm-breakpoint.c: Use C++ exception handling.
5962         * guile/scm-block.c: Use C++ exception handling.
5963         * guile/guile-internal.h: Use C++ exception handling.
5964         * gnu-v3-abi.c: Use C++ exception handling.
5965         * gdbtypes.c: Use C++ exception handling.
5966         * frame.c: Use C++ exception handling.
5967         * frame-unwind.c: Use C++ exception handling.
5968         * fbsd-tdep.c: Use C++ exception handling.
5969         * f-valprint.c: Use C++ exception handling.
5970         * exec.c: Use C++ exception handling.
5971         * event-top.c: Use C++ exception handling.
5972         * event-loop.c: Use C++ exception handling.
5973         * eval.c: Use C++ exception handling.
5974         * dwarf2read.c: Use C++ exception handling.
5975         * dwarf2loc.c: Use C++ exception handling.
5976         * dwarf2-frame.c: Use C++ exception handling.
5977         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5978         * dwarf-index-write.c: Use C++ exception handling.
5979         * dwarf-index-cache.c: Use C++ exception handling.
5980         * dtrace-probe.c: Use C++ exception handling.
5981         * disasm-selftests.c: Use C++ exception handling.
5982         * darwin-nat.c: Use C++ exception handling.
5983         * cp-valprint.c: Use C++ exception handling.
5984         * cp-support.c: Use C++ exception handling.
5985         * cp-abi.c: Use C++ exception handling.
5986         * corelow.c: Use C++ exception handling.
5987         * completer.c: Use C++ exception handling.
5988         * compile/compile-object-run.c: Use C++ exception handling.
5989         * compile/compile-object-load.c: Use C++ exception handling.
5990         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5991         * compile/compile-c-symbols.c: Use C++ exception handling.
5992         * common/selftest.c: Use C++ exception handling.
5993         * common/new-op.c: Use C++ exception handling.
5994         * cli/cli-script.c: Use C++ exception handling.
5995         * cli/cli-interp.c: Use C++ exception handling.
5996         * cli/cli-cmds.c: Use C++ exception handling.
5997         * c-varobj.c: Use C++ exception handling.
5998         * btrace.c: Use C++ exception handling.
5999         * breakpoint.c: Use C++ exception handling.
6000         * break-catch-throw.c: Use C++ exception handling.
6001         * arch-utils.c: Use C++ exception handling.
6002         * amd64-tdep.c: Use C++ exception handling.
6003         * ada-valprint.c: Use C++ exception handling.
6004         * ada-typeprint.c: Use C++ exception handling.
6005         * ada-lang.c: Use C++ exception handling.
6006         * aarch64-tdep.c: Use C++ exception handling.
6007
6008 2019-04-08  Tom Tromey  <tom@tromey.com>
6009
6010         * xml-support.c (gdb_xml_parser::parse): Update.
6011         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6012         * value.c (show_convenience): Update.
6013         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6014         (test_parse_flags_qcs): Update.
6015         * thread.c (thr_try_catch_cmd): Update.
6016         * target.c (target_translate_tls_address): Update.
6017         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6018         (info_frame_command_core, frame_apply_command_count): Update.
6019         * rust-exp.y (rust_lex_exception_test): Update.
6020         * riscv-tdep.c (riscv_print_one_register_info): Update.
6021         * remote.c (remote_target::enable_btrace): Update.
6022         * record-btrace.c (record_btrace_enable_warn): Update.
6023         * python/py-utils.c (gdbpy_convert_exception): Update.
6024         * printcmd.c (do_one_display, print_variable_and_value): Update.
6025         * mi/mi-main.c (mi_print_exception): Update.
6026         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6027         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6028         * linux-nat.c (linux_nat_target::attach): Update.
6029         * linux-fork.c (class scoped_switch_fork_info): Update.
6030         * infrun.c (displaced_step_prepare): Update.
6031         * infcall.c (call_function_by_hand_dummy): Update.
6032         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6033         * gnu-v3-abi.c (print_one_vtable): Update.
6034         * frame.c (get_prev_frame_always): Update.
6035         * f-valprint.c (info_common_command_for_block): Update.
6036         * exec.c (try_open_exec_file): Update.
6037         * exceptions.c (print_exception, exception_print)
6038         (exception_fprintf, exception_print_same): Update.
6039         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6040         * dwarf-index-cache.c (index_cache::store)
6041         (index_cache::lookup_gdb_index): Update.
6042         * darwin-nat.c (maybe_cache_shell): Update.
6043         * cp-valprint.c (cp_print_value_fields): Update.
6044         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6045         (gcc_cplus_symbol_address): Update.
6046         * compile/compile-c-symbols.c (gcc_convert_symbol)
6047         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6048         * common/selftest.c: Update.
6049         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6050         a std::string.
6051         (exception_try_scope_entry, exception_try_scope_exit): Don't
6052         declare.
6053         (struct exception_try_scope): Remove.
6054         (TRY): Don't use exception_try_scope.
6055         (struct gdb_exception): Add constructor, operator=.
6056         <what>: New method.
6057         (struct gdb_exception_RETURN_MASK_ALL)
6058         (struct gdb_exception_RETURN_MASK_ERROR)
6059         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6060         (struct gdb_quit_bad_alloc): Update.
6061         * common/common-exceptions.c (exception_none): Change
6062         initializer.
6063         (struct catcher) <state, exception>: Initialize inline.
6064         <prev>: Remove member.
6065         (current_catcher): Remove.
6066         (catchers): New global.
6067         (exceptions_state_mc_init): Simplify.
6068         (catcher_pop): Remove.
6069         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6070         (try_scope_depth, exception_try_scope_entry)
6071         (exception_try_scope_exit): Remove.
6072         (throw_exception_sjlj): Update.
6073         (exception_messages, exception_messages_size): Remove.
6074         (throw_it): Simplify.
6075         (gdb_exception_sliced_copy): Remove.
6076         (throw_exception_cxx): Update.
6077         * cli/cli-script.c (script_from_file): Update.
6078         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6079         Update.
6080         * ada-valprint.c (ada_val_print): Update.
6081         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6082         (create_excep_cond_exprs): Update.
6083
6084 2019-04-08  Tom Tromey  <tom@tromey.com>
6085
6086         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6087         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6088         (TRY, CATCH, END_CATCH): Remove some definitions.
6089         * common/common-exceptions.c: Don't use GDB_XCPT.
6090         (catcher_list_size): Remove.
6091         (throw_exception, throw_it): Simplify.
6092
6093 2019-04-05  Tom Tromey  <tom@tromey.com>
6094
6095         Revert the header-sorting patch.
6096         * ft32-tdep.c: Revert.
6097         * frv-tdep.c: Revert.
6098         * frv-linux-tdep.c: Revert.
6099         * frame.c: Revert.
6100         * frame-unwind.c: Revert.
6101         * frame-base.c: Revert.
6102         * fork-child.c: Revert.
6103         * findvar.c: Revert.
6104         * findcmd.c: Revert.
6105         * filesystem.c: Revert.
6106         * filename-seen-cache.h: Revert.
6107         * filename-seen-cache.c: Revert.
6108         * fbsd-tdep.c: Revert.
6109         * fbsd-nat.h: Revert.
6110         * fbsd-nat.c: Revert.
6111         * f-valprint.c: Revert.
6112         * f-typeprint.c: Revert.
6113         * f-lang.c: Revert.
6114         * extension.h: Revert.
6115         * extension.c: Revert.
6116         * extension-priv.h: Revert.
6117         * expprint.c: Revert.
6118         * exec.h: Revert.
6119         * exec.c: Revert.
6120         * exceptions.c: Revert.
6121         * event-top.c: Revert.
6122         * event-loop.c: Revert.
6123         * eval.c: Revert.
6124         * elfread.c: Revert.
6125         * dwarf2read.h: Revert.
6126         * dwarf2read.c: Revert.
6127         * dwarf2loc.c: Revert.
6128         * dwarf2expr.h: Revert.
6129         * dwarf2expr.c: Revert.
6130         * dwarf2-frame.c: Revert.
6131         * dwarf2-frame-tailcall.c: Revert.
6132         * dwarf-index-write.h: Revert.
6133         * dwarf-index-write.c: Revert.
6134         * dwarf-index-common.c: Revert.
6135         * dwarf-index-cache.h: Revert.
6136         * dwarf-index-cache.c: Revert.
6137         * dummy-frame.c: Revert.
6138         * dtrace-probe.c: Revert.
6139         * disasm.h: Revert.
6140         * disasm.c: Revert.
6141         * disasm-selftests.c: Revert.
6142         * dictionary.c: Revert.
6143         * dicos-tdep.c: Revert.
6144         * demangle.c: Revert.
6145         * dcache.h: Revert.
6146         * dcache.c: Revert.
6147         * darwin-nat.h: Revert.
6148         * darwin-nat.c: Revert.
6149         * darwin-nat-info.c: Revert.
6150         * d-valprint.c: Revert.
6151         * d-namespace.c: Revert.
6152         * d-lang.c: Revert.
6153         * ctf.c: Revert.
6154         * csky-tdep.c: Revert.
6155         * csky-linux-tdep.c: Revert.
6156         * cris-tdep.c: Revert.
6157         * cris-linux-tdep.c: Revert.
6158         * cp-valprint.c: Revert.
6159         * cp-support.c: Revert.
6160         * cp-namespace.c: Revert.
6161         * cp-abi.c: Revert.
6162         * corelow.c: Revert.
6163         * corefile.c: Revert.
6164         * continuations.c: Revert.
6165         * completer.h: Revert.
6166         * completer.c: Revert.
6167         * complaints.c: Revert.
6168         * coffread.c: Revert.
6169         * coff-pe-read.c: Revert.
6170         * cli-out.h: Revert.
6171         * cli-out.c: Revert.
6172         * charset.c: Revert.
6173         * c-varobj.c: Revert.
6174         * c-valprint.c: Revert.
6175         * c-typeprint.c: Revert.
6176         * c-lang.c: Revert.
6177         * buildsym.c: Revert.
6178         * buildsym-legacy.c: Revert.
6179         * build-id.h: Revert.
6180         * build-id.c: Revert.
6181         * btrace.c: Revert.
6182         * bsd-uthread.c: Revert.
6183         * breakpoint.h: Revert.
6184         * breakpoint.c: Revert.
6185         * break-catch-throw.c: Revert.
6186         * break-catch-syscall.c: Revert.
6187         * break-catch-sig.c: Revert.
6188         * blockframe.c: Revert.
6189         * block.c: Revert.
6190         * bfin-tdep.c: Revert.
6191         * bfin-linux-tdep.c: Revert.
6192         * bfd-target.c: Revert.
6193         * bcache.c: Revert.
6194         * ax-general.c: Revert.
6195         * ax-gdb.h: Revert.
6196         * ax-gdb.c: Revert.
6197         * avr-tdep.c: Revert.
6198         * auxv.c: Revert.
6199         * auto-load.c: Revert.
6200         * arm-wince-tdep.c: Revert.
6201         * arm-tdep.c: Revert.
6202         * arm-symbian-tdep.c: Revert.
6203         * arm-pikeos-tdep.c: Revert.
6204         * arm-obsd-tdep.c: Revert.
6205         * arm-nbsd-tdep.c: Revert.
6206         * arm-nbsd-nat.c: Revert.
6207         * arm-linux-tdep.c: Revert.
6208         * arm-linux-nat.c: Revert.
6209         * arm-fbsd-tdep.c: Revert.
6210         * arm-fbsd-nat.c: Revert.
6211         * arm-bsd-tdep.c: Revert.
6212         * arch-utils.c: Revert.
6213         * arc-tdep.c: Revert.
6214         * arc-newlib-tdep.c: Revert.
6215         * annotate.h: Revert.
6216         * annotate.c: Revert.
6217         * amd64-windows-tdep.c: Revert.
6218         * amd64-windows-nat.c: Revert.
6219         * amd64-tdep.c: Revert.
6220         * amd64-sol2-tdep.c: Revert.
6221         * amd64-obsd-tdep.c: Revert.
6222         * amd64-obsd-nat.c: Revert.
6223         * amd64-nbsd-tdep.c: Revert.
6224         * amd64-nbsd-nat.c: Revert.
6225         * amd64-nat.c: Revert.
6226         * amd64-linux-tdep.c: Revert.
6227         * amd64-linux-nat.c: Revert.
6228         * amd64-fbsd-tdep.c: Revert.
6229         * amd64-fbsd-nat.c: Revert.
6230         * amd64-dicos-tdep.c: Revert.
6231         * amd64-darwin-tdep.c: Revert.
6232         * amd64-bsd-nat.c: Revert.
6233         * alpha-tdep.c: Revert.
6234         * alpha-obsd-tdep.c: Revert.
6235         * alpha-nbsd-tdep.c: Revert.
6236         * alpha-mdebug-tdep.c: Revert.
6237         * alpha-linux-tdep.c: Revert.
6238         * alpha-linux-nat.c: Revert.
6239         * alpha-bsd-tdep.c: Revert.
6240         * alpha-bsd-nat.c: Revert.
6241         * aix-thread.c: Revert.
6242         * agent.c: Revert.
6243         * addrmap.c: Revert.
6244         * ada-varobj.c: Revert.
6245         * ada-valprint.c: Revert.
6246         * ada-typeprint.c: Revert.
6247         * ada-tasks.c: Revert.
6248         * ada-lang.c: Revert.
6249         * aarch64-tdep.c: Revert.
6250         * aarch64-ravenscar-thread.c: Revert.
6251         * aarch64-newlib-tdep.c: Revert.
6252         * aarch64-linux-tdep.c: Revert.
6253         * aarch64-linux-nat.c: Revert.
6254         * aarch64-fbsd-tdep.c: Revert.
6255         * aarch64-fbsd-nat.c: Revert.
6256         * aarch32-linux-nat.c: Revert.
6257
6258 2019-04-05  Tom Tromey  <tom@tromey.com>
6259
6260         * ft32-tdep.c: Sort headers.
6261         * frv-tdep.c: Sort headers.
6262         * frv-linux-tdep.c: Sort headers.
6263         * frame.c: Sort headers.
6264         * frame-unwind.c: Sort headers.
6265         * frame-base.c: Sort headers.
6266         * fork-child.c: Sort headers.
6267         * findvar.c: Sort headers.
6268         * findcmd.c: Sort headers.
6269         * filesystem.c: Sort headers.
6270         * filename-seen-cache.h: Sort headers.
6271         * filename-seen-cache.c: Sort headers.
6272         * fbsd-tdep.c: Sort headers.
6273         * fbsd-nat.h: Sort headers.
6274         * fbsd-nat.c: Sort headers.
6275         * f-valprint.c: Sort headers.
6276         * f-typeprint.c: Sort headers.
6277         * f-lang.c: Sort headers.
6278         * extension.h: Sort headers.
6279         * extension.c: Sort headers.
6280         * extension-priv.h: Sort headers.
6281         * expprint.c: Sort headers.
6282         * exec.h: Sort headers.
6283         * exec.c: Sort headers.
6284         * exceptions.c: Sort headers.
6285         * event-top.c: Sort headers.
6286         * event-loop.c: Sort headers.
6287         * eval.c: Sort headers.
6288         * elfread.c: Sort headers.
6289         * dwarf2read.h: Sort headers.
6290         * dwarf2read.c: Sort headers.
6291         * dwarf2loc.c: Sort headers.
6292         * dwarf2expr.h: Sort headers.
6293         * dwarf2expr.c: Sort headers.
6294         * dwarf2-frame.c: Sort headers.
6295         * dwarf2-frame-tailcall.c: Sort headers.
6296         * dwarf-index-write.h: Sort headers.
6297         * dwarf-index-write.c: Sort headers.
6298         * dwarf-index-common.c: Sort headers.
6299         * dwarf-index-cache.h: Sort headers.
6300         * dwarf-index-cache.c: Sort headers.
6301         * dummy-frame.c: Sort headers.
6302         * dtrace-probe.c: Sort headers.
6303         * disasm.h: Sort headers.
6304         * disasm.c: Sort headers.
6305         * disasm-selftests.c: Sort headers.
6306         * dictionary.c: Sort headers.
6307         * dicos-tdep.c: Sort headers.
6308         * demangle.c: Sort headers.
6309         * dcache.h: Sort headers.
6310         * dcache.c: Sort headers.
6311         * darwin-nat.h: Sort headers.
6312         * darwin-nat.c: Sort headers.
6313         * darwin-nat-info.c: Sort headers.
6314         * d-valprint.c: Sort headers.
6315         * d-namespace.c: Sort headers.
6316         * d-lang.c: Sort headers.
6317         * ctf.c: Sort headers.
6318         * csky-tdep.c: Sort headers.
6319         * csky-linux-tdep.c: Sort headers.
6320         * cris-tdep.c: Sort headers.
6321         * cris-linux-tdep.c: Sort headers.
6322         * cp-valprint.c: Sort headers.
6323         * cp-support.c: Sort headers.
6324         * cp-namespace.c: Sort headers.
6325         * cp-abi.c: Sort headers.
6326         * corelow.c: Sort headers.
6327         * corefile.c: Sort headers.
6328         * continuations.c: Sort headers.
6329         * completer.h: Sort headers.
6330         * completer.c: Sort headers.
6331         * complaints.c: Sort headers.
6332         * coffread.c: Sort headers.
6333         * coff-pe-read.c: Sort headers.
6334         * cli-out.h: Sort headers.
6335         * cli-out.c: Sort headers.
6336         * charset.c: Sort headers.
6337         * c-varobj.c: Sort headers.
6338         * c-valprint.c: Sort headers.
6339         * c-typeprint.c: Sort headers.
6340         * c-lang.c: Sort headers.
6341         * buildsym.c: Sort headers.
6342         * buildsym-legacy.c: Sort headers.
6343         * build-id.h: Sort headers.
6344         * build-id.c: Sort headers.
6345         * btrace.c: Sort headers.
6346         * bsd-uthread.c: Sort headers.
6347         * breakpoint.h: Sort headers.
6348         * breakpoint.c: Sort headers.
6349         * break-catch-throw.c: Sort headers.
6350         * break-catch-syscall.c: Sort headers.
6351         * break-catch-sig.c: Sort headers.
6352         * blockframe.c: Sort headers.
6353         * block.c: Sort headers.
6354         * bfin-tdep.c: Sort headers.
6355         * bfin-linux-tdep.c: Sort headers.
6356         * bfd-target.c: Sort headers.
6357         * bcache.c: Sort headers.
6358         * ax-general.c: Sort headers.
6359         * ax-gdb.h: Sort headers.
6360         * ax-gdb.c: Sort headers.
6361         * avr-tdep.c: Sort headers.
6362         * auxv.c: Sort headers.
6363         * auto-load.c: Sort headers.
6364         * arm-wince-tdep.c: Sort headers.
6365         * arm-tdep.c: Sort headers.
6366         * arm-symbian-tdep.c: Sort headers.
6367         * arm-pikeos-tdep.c: Sort headers.
6368         * arm-obsd-tdep.c: Sort headers.
6369         * arm-nbsd-tdep.c: Sort headers.
6370         * arm-nbsd-nat.c: Sort headers.
6371         * arm-linux-tdep.c: Sort headers.
6372         * arm-linux-nat.c: Sort headers.
6373         * arm-fbsd-tdep.c: Sort headers.
6374         * arm-fbsd-nat.c: Sort headers.
6375         * arm-bsd-tdep.c: Sort headers.
6376         * arch-utils.c: Sort headers.
6377         * arc-tdep.c: Sort headers.
6378         * arc-newlib-tdep.c: Sort headers.
6379         * annotate.h: Sort headers.
6380         * annotate.c: Sort headers.
6381         * amd64-windows-tdep.c: Sort headers.
6382         * amd64-windows-nat.c: Sort headers.
6383         * amd64-tdep.c: Sort headers.
6384         * amd64-sol2-tdep.c: Sort headers.
6385         * amd64-obsd-tdep.c: Sort headers.
6386         * amd64-obsd-nat.c: Sort headers.
6387         * amd64-nbsd-tdep.c: Sort headers.
6388         * amd64-nbsd-nat.c: Sort headers.
6389         * amd64-nat.c: Sort headers.
6390         * amd64-linux-tdep.c: Sort headers.
6391         * amd64-linux-nat.c: Sort headers.
6392         * amd64-fbsd-tdep.c: Sort headers.
6393         * amd64-fbsd-nat.c: Sort headers.
6394         * amd64-dicos-tdep.c: Sort headers.
6395         * amd64-darwin-tdep.c: Sort headers.
6396         * amd64-bsd-nat.c: Sort headers.
6397         * alpha-tdep.c: Sort headers.
6398         * alpha-obsd-tdep.c: Sort headers.
6399         * alpha-nbsd-tdep.c: Sort headers.
6400         * alpha-mdebug-tdep.c: Sort headers.
6401         * alpha-linux-tdep.c: Sort headers.
6402         * alpha-linux-nat.c: Sort headers.
6403         * alpha-bsd-tdep.c: Sort headers.
6404         * alpha-bsd-nat.c: Sort headers.
6405         * aix-thread.c: Sort headers.
6406         * agent.c: Sort headers.
6407         * addrmap.c: Sort headers.
6408         * ada-varobj.c: Sort headers.
6409         * ada-valprint.c: Sort headers.
6410         * ada-typeprint.c: Sort headers.
6411         * ada-tasks.c: Sort headers.
6412         * ada-lang.c: Sort headers.
6413         * aarch64-tdep.c: Sort headers.
6414         * aarch64-ravenscar-thread.c: Sort headers.
6415         * aarch64-newlib-tdep.c: Sort headers.
6416         * aarch64-linux-tdep.c: Sort headers.
6417         * aarch64-linux-nat.c: Sort headers.
6418         * aarch64-fbsd-tdep.c: Sort headers.
6419         * aarch64-fbsd-nat.c: Sort headers.
6420         * aarch32-linux-nat.c: Sort headers.
6421
6422 2019-04-04  Tom Tromey  <tom@tromey.com>
6423
6424         * varobj.c (varobj_create): Update.
6425         * rust-exp.y (struct rust_parser) <update_innermost_block,
6426         lookup_symbol>: New methods.
6427         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6428         Rename.
6429         (rust_parser::rust_lookup_type)
6430         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6431         * printcmd.c (display_command, do_one_display): Update.
6432         * parser-defs.h (struct parser_state) <parser_state>: Add
6433         "tracker" parameter.
6434         (block_tracker): New member.
6435         (class innermost_block_tracker) <innermost_block_tracker>: Add
6436         "types" parameter.
6437         <reset>: Remove method.
6438         (innermost_block): Don't declare.
6439         (null_post_parser): Update.
6440         * parse.c (innermost_block): Remove global.
6441         (write_dollar_variable): Update.
6442         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6443         Remove "tracker_types" parameter.
6444         (parse_expression): Add "tracker" parameter.
6445         (parse_expression_for_completion): Update.
6446         (null_post_parser): Add "tracker" parameter.
6447         * p-exp.y: Update rules.
6448         * m2-exp.y: Update rules.
6449         * language.h (struct language_defn) <la_post_parser>: Add
6450         "tracker" parameter.
6451         * go-exp.y: Update rules.
6452         * f-exp.y: Update rules.
6453         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6454         parameter.
6455         * d-exp.y: Update rules.
6456         * c-exp.y: Update rules.
6457         * breakpoint.c (set_breakpoint_condition): Create an
6458         innermost_block_tracker.
6459         (watch_command_1): Likewise.
6460         * ada-lang.c (resolve): Add "tracker" parameter.
6461         (resolve_subexp): Likewise.
6462         * ada-exp.y (write_var_from_sym): Update.
6463
6464 2019-04-04  Tom Tromey  <tom@tromey.com>
6465
6466         * type-stack.h: New file.
6467         * type-stack.c: New file.
6468         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6469         type-stack.h.
6470         (insert_into_type_stack, insert_type, push_type, push_type_int)
6471         (insert_type_address_space, pop_type, pop_type_int)
6472         (pop_typelist, pop_type_stack, append_type_stack)
6473         (push_type_stack, get_type_stack, push_typelist)
6474         (follow_type_instance_flags, follow_types): Don't declare.
6475         * parse.c (type_stack): Remove global.
6476         (parse_exp_in_context): Update.
6477         (insert_into_type_stack, insert_type, push_type, push_type_int)
6478         (insert_type_address_space, pop_type, pop_type_int)
6479         (pop_typelist, pop_type_stack, append_type_stack)
6480         (push_type_stack, get_type_stack, push_typelist)
6481         (follow_type_instance_flags, follow_types): Remove (moved to
6482         type-stack.c).
6483         * f-exp.y (type_stack): New global.
6484         Update rules.
6485         (push_kind_type, f_parse): Update.
6486         * d-exp.y (type_stack): New global.
6487         Update rules.
6488         (d_parse): Update.
6489         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6490         Update rules.
6491         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6492         (HFILES_NO_SRCDIR): Add type-stack.h.
6493
6494 2019-04-04  Tom Tromey  <tom@tromey.com>
6495
6496         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6497         (rust_parser::convert_ast_to_expression, rust_parse)
6498         (rust_lex_test_completion, rust_lex_tests): Update.
6499         * parser-defs.h (struct expr_completion_state): New.
6500         (struct parser_state) <parser_state>: Add completion parameter.
6501         <mark_struct_expression, mark_completion_tag>: New methods.
6502         <parse_completion, m_completion_state>: New members.
6503         (prefixify_expression, null_post_parser): Update.
6504         (mark_struct_expression, mark_completion_tag): Don't declare.
6505         * parse.c (parse_completion, expout_last_struct)
6506         (expout_tag_completion_type, expout_completion_name): Remove
6507         globals.
6508         (parser_state::mark_struct_expression)
6509         (parser_state::mark_completion_tag): Now methods.
6510         (prefixify_expression): Add last_struct parameter.
6511         (prefixify_subexp): Likewise.
6512         (parse_exp_1): Update.
6513         (parse_exp_in_context): Add cstate parameter.  Update.
6514         (parse_expression_for_completion): Create an
6515         expr_completion_state.
6516         (null_post_parser): Add "completion" parameter.
6517         * p-exp.y: Update rules.
6518         (yylex): Update.
6519         * language.h (struct language_defn) <la_post_parser>: Add
6520         "completing" parameter.
6521         * go-exp.y: Update rules.
6522         (lex_one_token): Update.
6523         * expression.h (parse_completion): Don't declare.
6524         * d-exp.y: Update rules.
6525         (lex_one_token): Update rules.
6526         * c-exp.y: Update rules.
6527         (lex_one_token): Update.
6528         * ada-lang.c (resolve): Add "parse_completion" parameter.
6529         (resolve_subexp): Likewise.
6530         (ada_resolve_function): Likewise.
6531
6532 2019-04-04  Tom Tromey  <tom@tromey.com>
6533
6534         * parser-defs.h (struct parser_state) <start_arglist,
6535         end_arglist>: New methods.
6536         <arglist_len, m_funcall_chain>: New members.
6537         (arglist_len, start_arglist, end_arglist): Don't declare.
6538         * parse.c (arglist_len, funcall_chain): Remove global.
6539         (start_arglist, end_arglist): Remove functions.
6540         (parse_exp_in_context): Update.
6541         * p-exp.y: Update rules.
6542         * m2-exp.y: Update rules.
6543         * go-exp.y: Update rules.
6544         * f-exp.y: Update rules.
6545         * d-exp.y: Update rules.
6546         * c-exp.y: Update rules.
6547
6548 2019-04-04  Tom Tromey  <tom@tromey.com>
6549
6550         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6551         lex_operator, push_back>: New methods.
6552         Update all rules.
6553         (rust_parser::lex_hex, lex_escape): Rename and update.
6554         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6555         (rust_parser::lex_operator): Rename and update.
6556         (rust_parser::lex_number, rustyylex, rustyyerror)
6557         (rust_lex_test_init, rust_lex_test_sequence)
6558         (rust_lex_test_push_back, rust_lex_tests): Update.
6559         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6560         parameter.
6561         <lexptr, prev_lexptr>: New members.
6562         (lexptr, prev_lexptr): Don't declare.
6563         * parse.c (lexptr, prev_lexptr): Remove globals.
6564         (parse_exp_in_context): Update.
6565         * p-exp.y (yylex, yyerror): Update.
6566         * m2-exp.y (parse_number, yylex, yyerror): Update.
6567         * go-exp.y (lex_one_token, yyerror): Update.
6568         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6569         * d-exp.y (lex_one_token, yyerror): Update.
6570         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6571         (lex_one_token, yyerror): Update.
6572         * ada-lex.l (YY_INPUT): Update.
6573         (rewind_to_char): Update.
6574         * ada-exp.y (yyerror): Update.
6575
6576 2019-04-04  Tom Tromey  <tom@tromey.com>
6577
6578         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6579         * parser-defs.h (struct parser_state) <parser_state>: Add new
6580         parameter.
6581         <comma_terminates>: New member.
6582         (comma_terminates): Don't declare global.
6583         * parse.c (comma_terminates): Remove global.
6584         (parse_exp_in_context): Update.
6585         * p-exp.y (yylex): Update.
6586         * m2-exp.y (yylex): Update.
6587         * go-exp.y (lex_one_token): Update.
6588         * f-exp.y (yylex): Update.
6589         * d-exp.y (lex_one_token): Update.
6590         * c-exp.y (lex_one_token): Update.
6591         * ada-lex.l: Update.
6592
6593 2019-04-04  Tom Tromey  <tom@tromey.com>
6594
6595         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6596         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6597         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6598         * parser-defs.h (paren_depth): Don't declare.
6599         * parse.c (paren_depth): Remove global.
6600         (parse_exp_in_context): Update.
6601         * p-exp.y (paren_depth): New global.
6602         (pascal_parse): Initialize it.
6603         * m2-exp.y (paren_depth): New global.
6604         (m2_parse): Initialize it.
6605         * go-exp.y (paren_depth): New global.
6606         (go_parse): Initialize it.
6607         * f-exp.y (paren_depth): New global.
6608         (f_parse): Initialize it.
6609         * d-exp.y (paren_depth): New global.
6610         (d_parse): Initialize it.
6611         * c-exp.y (paren_depth): New global.
6612         (c_parse): Initialize it.
6613         * ada-lex.l (paren_depth): New global.
6614         (lexer_init): Initialize it.
6615
6616 2019-04-04  Tom Tromey  <tom@tromey.com>
6617
6618         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6619         (rust_parser::convert_ast_to_type)
6620         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6621         * parser-defs.h (struct parser_state) <parser_state>: Add
6622         parameters.  Initialize new members.
6623         <expression_context_block, expression_context_pc>: New members.
6624         * parse.c (expression_context_block, expression_context_pc):
6625         Remove globals.
6626         (parse_exp_in_context): Update.
6627         * p-exp.y: Update all rules.
6628         (yylex): Update.
6629         * m2-exp.y: Update all rules.
6630         (yylex): Update.
6631         * go-exp.y (yylex): Update.
6632         * f-exp.y (yylex): Update.
6633         * d-exp.y: Update all rules.
6634         (yylex): Update.
6635         * c-exp.y: Update all rules.
6636         (lex_one_token, classify_name, yylex, c_parse): Update.
6637         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6638
6639 2019-04-04  Tom Tromey  <tom@tromey.com>
6640
6641         * gdbarch.h, gdbarch.c: Rebuild.
6642         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6643         * stap-probe.h:
6644         (struct stap_parse_info): Replace "parser_state" with
6645         "expr_builder".
6646         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6647         (parser_state): New class.
6648         * parse.c (expr_builder): Rename.
6649         (expr_builder::release): Rename.
6650         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6651         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6652         (write_exp_elt_longcst, write_exp_elt_floatcst)
6653         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6654         (write_exp_string_vector, write_exp_bitstring)
6655         (write_exp_msymbol, mark_struct_expression)
6656         (write_dollar_variable)
6657         (insert_type_address_space, increase_expout_size): Replace
6658         "parser_state" with "expr_builder".
6659         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6660         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6661         "parser_state" with "expr_builder".
6662
6663 2019-04-04  Tom Tromey  <tom@tromey.com>
6664
6665         * rust-exp.y: Replace "parse_language" with method call.
6666         * p-exp.y:
6667         (yylex): Replace "parse_language" with method call.
6668         * m2-exp.y:
6669         (yylex): Replace "parse_language" with method call.
6670         * go-exp.y (classify_name): Replace "parse_language" with method
6671         call.
6672         * f-exp.y (yylex): Replace "parse_language" with method call.
6673         * d-exp.y (lex_one_token): Replace "parse_language" with method
6674         call.
6675         * c-exp.y:
6676         (lex_one_token, classify_name, yylex): Replace "parse_language"
6677         with method call.
6678         * ada-exp.y (find_primitive_type, type_char)
6679         (type_system_address): Replace "parse_language" with method call.
6680
6681 2019-04-04  Tom Tromey  <tom@tromey.com>
6682
6683         * rust-exp.y: Replace "parse_gdbarch" with method call.
6684         * parse.c (write_dollar_variable, insert_type_address_space):
6685         Replace "parse_gdbarch" with method call.
6686         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6687         call.
6688         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6689         call.
6690         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6691         "parse_gdbarch" with method call.
6692         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6693         with method call.
6694         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6695         "parse_gdbarch" with method call.
6696         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6697         "parse_gdbarch" with method call.
6698         * c-exp.y (parse_type, parse_number, classify_name): Replace
6699         "parse_gdbarch" with method call.
6700         * ada-lex.l: Replace "parse_gdbarch" with method call.
6701         * ada-exp.y (parse_type, find_primitive_type, type_char)
6702         (type_system_address): Replace "parse_gdbarch" with method call.
6703
6704 2019-04-04  Tom Tromey  <tom@tromey.com>
6705
6706         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6707         * stap-probe.c (stap_parse_argument): Update.
6708         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6709         initial_size parameter.
6710         * rust-exp.y (rust_lex_tests): Update.
6711         * parse.c (parser_state): Update.
6712         (parse_exp_in_context): Update.
6713         * parser-defs.h (struct parser_state) <parser_state>: Remove
6714         "initial_size" parameter.
6715
6716 2019-04-04  Tom Tromey  <tom@tromey.com>
6717
6718         * parser-defs.h (increase_expout_size): Don't declare.
6719         * parse.c (increase_expout_size): Now static.
6720
6721 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6722
6723         * gnu-nat.c (gnu_nat_target::wait): Fix
6724         target_waitstatus_to_string call.
6725
6726 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6727
6728         * eval.c (evaluate_subexp_standard): Handle internal functions
6729         during Fortran function call handling.
6730
6731 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6732
6733         * NEWS: Mention new internal functions.
6734         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6735         (read_base_type): Use dwarf2_init_complex_target_type.
6736         * value.c (creal_internal_fn): New function.
6737         (cimag_internal_fn): New function.
6738         (_initialize_values): Register new internal functions.
6739
6740 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6741
6742         * infrun.c (stop_all_threads): If debug_infrun, always
6743         trace the wait status after wait_one, using
6744         target_waitstatus_to_string and target_pid_to_str.
6745         (handle_inferior_event): Replace various trace of
6746         wait status kind by a single trace.
6747         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6748         wait status kind image by target_waitstatus_to_string.
6749         * target/waitstatus.c (target_waitstatus_to_string): Fix
6750         obsolete comment.
6751
6752 2019-04-01  Tom Tromey  <tromey@adacore.com>
6753
6754         PR symtab/23331:
6755         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6756
6757 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6758             Pedro Alves  <palves@redhat.com>
6759
6760         * top.c (quit_force): Call 'finalize_values'.
6761         * value.c (finalize_values): New function.
6762         * value.h (finalize_values): Declare.
6763
6764 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6765
6766         * NEWS: Announce $_gdb_major and $_gdb_minor.
6767
6768         * top.c (init_gdb_version_vars): New function.
6769         (gdb_init): Call init_gdb_version_vars.
6770
6771 2019-03-29  Tom Tromey  <tromey@adacore.com>
6772
6773         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6774         help text.  Remove dead code.
6775
6776 2019-03-29  Keith Seitz  <keiths@redhat.com>
6777
6778         From Siddhesh Poyarekar:
6779         * f-lang.h (f77_get_upperbound): Return LONGEST.
6780         (f77_get_lowerbound): Likewise.
6781         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6782         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6783         print them.
6784         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6785         plongest to format print it.
6786         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6787         (f77_get_upperbound): Likewise.
6788         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6789         LOWER_BOUND to LONGEST.
6790         (f77_create_arrayprint_offset_tbl): Likewise.
6791
6792 2019-03-29  Keith Seitz  <keiths@redhat.com>
6793
6794         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6795         %s/pulongest for TYPE_LENGTH instead of %d in format
6796         strings.
6797         * ada-typerint.c (ada_print_type): Likewise.
6798         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6799         * compile/compile-c-support.c (generate_register_struct): Likewise.
6800         * gdbtypes.c (recursive_dump_type): Likewise.
6801         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6802         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6803         instead of %d in format strings.
6804         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6805         to std::min to ULONGEST.
6806         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6807         instead of %d in format strings.
6808         * tracepoint.c (info_scope_command): Likewise.
6809         * typeprint.c (print_offset_data::update)
6810         (print_offset_data::finish): Likewise.
6811         * xtensa-tdep.c (xtensa_store_return_value)
6812         (xtensa_push_dummy_call): Likewise.
6813
6814 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6815
6816         * windows-nat.c (display_selector): Fixed format specifications
6817         for 64-bit Cygwin.
6818
6819 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6820
6821         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6822
6823 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6824
6825         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6826         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6827         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6828         (nios2_linux_init_abi): Install it.
6829
6830 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6831
6832         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6833
6834 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6835
6836         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6837
6838 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6839             Tom Tromey  <tromey@adacore.com>
6840
6841         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6842
6843 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6844
6845         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6846         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6847         method to compute the bounds of range types. Also print "[evaluated]"
6848         if the bounds' values come from a dynamic evaluation.
6849
6850 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6851
6852         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6853         whitespace when pretty printing is on.
6854
6855 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6856
6857         * ppc-linux-nat.c: Add include.
6858
6859 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6860
6861         * NEWS: Mention AArch64 Pointer Authentication.
6862
6863 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6864
6865         * arm-linux-nat.c: Add include.
6866
6867 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6868
6869         * source-cache.c (source_cache::get_source_lines): Re-read
6870         fullname after calling open_source_file.
6871
6872 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6873
6874         * NEWS: Mention TLS support for FreeBSD.
6875
6876 2019-03-25  Tom Tromey  <tromey@adacore.com>
6877
6878         * minsyms.c (BUNCH_SIZE): Update comment.
6879         (~minimal_symbol_reader): Remove old comment.
6880         (compact_minimal_symbols): Update comment.
6881         (minimal_symbol_reader::install): Remove old comment.  Update
6882         other comments.
6883
6884 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6885
6886         * s390-linux-nat.c: Add include.
6887
6888 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6889
6890         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6891         Call linux_get_hwcap.
6892         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6893         Likewise.
6894         (aarch64_linux_get_hwcap): Remove function.
6895         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6896         declaration.
6897         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6898         linux_get_hwcap.
6899         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6900         * linux-tdep.c (linux_get_hwcap): Add function.
6901         (linux_get_hwcap2): Likewise.
6902         * linux-tdep.h (linux_get_hwcap): Add declaration.
6903         (linux_get_hwcap2): Likewise.
6904         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6905         (ppc_linux_get_hwcap2): Likewise.
6906         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6907         linux_get_hwcap.
6908         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6909         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6910         (ppc_linux_nat_target::read_description): Likewise.
6911         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6912         * s390-linux-nat.c: Likewise.
6913         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6914
6915 2019-03-24  Tom Tromey  <tom@tromey.com>
6916
6917         * ada-lang.c (standard_lookup): Simplify initialization.
6918         (ada_lookup_symbol_nonlocal): Simplify return.
6919         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6920         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6921         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6922         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6923         initialization.
6924         * solib.c (solib_global_lookup): Simplify.
6925         * symtab.c (null_block_symbol): Remove.
6926         (symbol_cache_lookup): Simplify returns.
6927         (lookup_language_this): Simplify returns.
6928         (lookup_symbol_aux): Simplify return.
6929         (lookup_local_symbol): Simplify returns.
6930         (lookup_global_symbol_from_objfile): Simplify return.
6931         (lookup_symbol_in_objfile_symtabs)
6932         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6933         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6934         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6935         * cp-namespace.c (cp_lookup_bare_symbol)
6936         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6937         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6938         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6939         (cp_lookup_symbol_via_imports): Simplify initialization.
6940         (find_symbol_in_baseclass): Likewise.
6941         * symtab.h (null_block_symbol): Remove.
6942         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6943         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6944         (d_lookup_symbol_module): Likewise.
6945         (find_symbol_in_baseclass): Simplify initialization.
6946
6947 2019-03-24  Tom Tromey  <tom@tromey.com>
6948
6949         * expression.h: Don't include symtab.h.
6950         (struct block): Forward declare.
6951
6952 2019-03-24  Tom Tromey  <tom@tromey.com>
6953
6954         * c-exp.y (typebase): Remove casts.
6955         * gdbtypes.c (lookup_unsigned_typename, )
6956         (lookup_signed_typename): Remove cast.
6957         * eval.c (parse_to_comma_and_eval): Remove cast.
6958         * parse.c (write_dollar_variable): Remove cast.
6959         * block.h (struct block) <superblock>: Now const.
6960         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6961         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6962         (map_block): Make "block" const.
6963         * symfile.h (struct quick_symbol_functions)
6964         <map_matching_symbols>: Constify block argument to "callback".
6965         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6966         const.
6967         (find_pc_sect_compunit_symtab): Make "b" const.
6968         (find_symbol_at_address): Likewise.
6969         (search_symbols): Likewise.
6970         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6971         (dw2_debug_names_lookup_symbol): Likewise.
6972         (dw2_map_matching_symbols): Update.
6973         * p-valprint.c (pascal_val_print): Remove "block".
6974         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6975         (aux_add_nonlocal_symbols): Make "block" const.
6976         (resolve_subexp): Remove cast.
6977         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6978         const.
6979         (iterate_over_file_blocks): Likewise.
6980         * f-exp.y (%union) <bval>: Remove.
6981         * coffread.c (patch_opaque_types): Make "b" const.
6982         * spu-tdep.c (spu_catch_start): Make "block" const.
6983         * c-valprint.c (print_unpacked_pointer): Remove "block".
6984         * symmisc.c (dump_symtab_1): Make "b" const.
6985         (block_depth): Make "block" const.
6986         * d-exp.y (%union) <bval>: Remove.
6987         * cp-support.h (cp_lookup_rtti_type): Update.
6988         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6989         * psymtab.c (psym_lookup_symbol): Make "block" const.
6990         (maintenance_check_psymtabs): Make "b" const.
6991         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6992         (enumerate_locals, enumerate_args): Update.
6993         * python/py-symtab.c (stpy_global_block): Make "block" const.
6994         (stpy_static_block): Likewise.
6995         * inline-frame.c (block_starting_point_at): Make "new_block"
6996         const.
6997         * block.c (find_block_in_blockvector): Make return type const.
6998         (blockvector_for_pc_sect): Make "b" const.
6999         (find_block_in_blockvector): Make "b" const.
7000
7001 2019-03-23  Tom Tromey  <tom@tromey.com>
7002
7003         * varobj.c (varobj_create): Update.
7004         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7005         * printcmd.c (display_command, do_one_display): Don't reset
7006         innermost_block.
7007         * parser-defs.h (enum innermost_block_tracker_type): Move to
7008         expression.h.
7009         (innermost_block): Update comment.
7010         * parse.c (parse_exp_1): Add tracker_types parameter.
7011         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7012         tracker_types parameter.  Reset innermost_block.
7013         (parse_exp_in_context): Remove.
7014         (parse_expression_for_completion): Update.
7015         * objfiles.c (~objfile): Don't reset expression_context_block or
7016         innermost_block.
7017         * expression.h (enum innermost_block_tracker_type): Move from
7018         parser-defs.h.
7019         (parse_exp_1): Add tracker_types parameter.
7020         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7021         reset innermost_block.
7022
7023 2019-03-23  Tom Tromey  <tom@tromey.com>
7024
7025         * objfiles.h: Include bcache.h.
7026
7027 2019-03-23  Tom Tromey  <tom@tromey.com>
7028
7029         * linespec.c (get_current_search_block): Use
7030         scoped_restore_current_language.
7031         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7032
7033 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7034             Jiong Wang  <jiong.wang@arm.com>
7035
7036         * aarch64-linux-tdep.c
7037         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7038         section.
7039         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7040
7041 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7042             Jiong Wang  <jiong.wang@arm.com>
7043
7044         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7045         instructions.
7046         (aarch64_analyze_prologue_test): Add PACIASP test.
7047         (aarch64_prologue_prev_register): Unmask PC value.
7048
7049 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7050             Jiong Wang  <jiong.wang@arm.com>
7051
7052         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7053         (aarch64_dwarf2_prev_register): Unmask PC value.
7054         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7055         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7056         DW_CFA_AARCH64_negate_ra_state.
7057         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7058
7059 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7060             Jiong Wang  <jiong.wang@arm.com>
7061
7062         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7063         registers.
7064         (aarch64_pseudo_register_name): Likewise.
7065         (aarch64_pseudo_register_type): Likewise.
7066         (aarch64_pseudo_register_reggroup_p): Likewise.
7067         (aarch64_gdbarch_init): Add pauth registers.
7068         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7069         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7070         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7071         (struct gdbarch_tdep): Add regnum for ra_state.
7072
7073 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7074             Jiong Wang  <jiong.wang@arm.com>
7075
7076         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7077
7078 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7079             Jiong Wang  <jiong.wang@arm.com>
7080
7081         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7082         function.
7083         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7084         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7085         (aarch64_gdbarch_init): Add puth registers.
7086         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7087         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7088         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7089
7090 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7091             Jiong Wang  <jiong.wang@arm.com>
7092
7093         * aarch64-linux-nat.c
7094         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7095         * aarch64-linux-tdep.c
7096         (aarch64_linux_core_read_description): Likewise.
7097         (aarch64_linux_get_hwcap): New function.
7098         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7099         (aarch64_linux_get_hwcap): New declaration.
7100
7101 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7102             Jiong Wang  <jiong.wang@arm.com>
7103
7104         * aarch64-linux-nat.c
7105         (aarch64_linux_nat_target::read_description): Add pauth param.
7106         * aarch64-linux-tdep.c
7107         (aarch64_linux_core_read_description): Likewise.
7108         * aarch64-tdep.c (struct target_desc): Add in pauth.
7109         (aarch64_read_description): Add pauth param.
7110         (aarch64_gdbarch_init): Likewise.
7111         * aarch64-tdep.h (aarch64_read_description): Likewise.
7112         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7113         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7114         * features/Makefile: Add new files.
7115         * features/aarch64-pauth.c: New file.
7116         * features/aarch64-pauth.xml: New file.
7117
7118 2019-03-20  Tom Tromey  <tromey@adacore.com>
7119
7120         * infrun.c (handle_inferior_event): Rename from
7121         handle_inferior_event_1.  Create a scoped_value_mark.
7122         (handle_inferior_event): Remove.
7123
7124 2019-03-19  Tom Tromey  <tromey@adacore.com>
7125
7126         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7127         * infrun.h (print_stop_event): Add "displays" parameter.
7128         * infrun.c (print_stop_event): Add "displays" parameter.
7129
7130 2019-03-19  Pedro Alves  <palves@redhat.com>
7131
7132         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7133         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7134         to -1.  Fix TABs vs spaces.
7135         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7136         * tui/tui-out.h (tui_ui_out) Add intro comments.
7137         <m_line, m_start_of_line>: In-class initialize, and add describing
7138         comment.
7139
7140 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7141
7142         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7143         variable names.
7144         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7145
7146 2019-03-18  Pedro Alves  <palves@redhat.com>
7147             Eli Zaretskii <eliz@gnu.org>
7148
7149         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7150         m_line and m_start_of_line.
7151
7152 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7153
7154         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7155         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7156         it returns a newline.  This fixes a regression in TU mode, whereby
7157         the next line is output on the same screen line as the user input.
7158
7159 2019-03-18  Tom Tromey  <tromey@adacore.com>
7160
7161         * minsyms.c (minimal_symbol_reader::install): Remove call to
7162         obstack_blank.
7163
7164 2019-03-18  Pedro Alves  <palves@redhat.com>
7165
7166         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7167         New globals.
7168         (apply_style): New, factored out from ...
7169         (apply_ansi_escape): ... this.  Handle reverse video mode.
7170         (tui_set_reverse_mode): New function.
7171         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7172         * tui/tui-winsource.c (tui_show_source_line): Use
7173         tui_set_reverse_mode instead of setting A_STANDOUT.
7174         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7175         New setter methods.
7176
7177 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7178
7179         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7180         Handle tabs.
7181
7182 2019-03-18  Tom Tromey  <tromey@adacore.com>
7183
7184         * ada-lang.c (empty_array): Add "high" parameter.
7185         (ada_evaluate_subexp): Update.
7186
7187 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7188
7189         * unittests/string_view-selftests.c: Define
7190         _initialize_string_view_selftests unconditionally.
7191
7192 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7193
7194         PR gdb/24350
7195         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7196
7197 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7198
7199         PR gdb/24351
7200         * windows-nat.c (display_selector): Fix format specifiers.
7201
7202 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7203
7204         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7205         tui_refill_source_window instead of tui_refresh_win, to update the
7206         current execution line.  This fixes redisplay of the current line
7207         when stepping through the code with "next" or "step".
7208
7209 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7210
7211         * source-cache.c (source_cache::get_source_lines): Call
7212         find_source_lines to initialize s->nlines.  This fixes vertical
7213         scrolling of TUI source window when the DOWN arrow is pressed.
7214
7215 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7216
7217         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7218         linux-thread-db.c (_initialize_thread_db): Likewise.
7219
7220 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7221
7222         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7223         wclrtoeol in tui_show_source_line".  This reverts changes made in
7224         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7225
7226 2019-03-15  Tom Tromey  <tom@tromey.com>
7227
7228         * symtab.h (struct minimal_symbol): Derive from
7229         general_symbol_info.
7230         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7231         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7232         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7233         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7234         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7235         (MSYMBOL_SEARCH_NAME): Update.
7236         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7237         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7238         * minsyms.c (minimal_symbol_reader::record_full): Update.
7239
7240 2019-03-15  Tom Tromey  <tom@tromey.com>
7241
7242         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7243
7244 2019-03-15  Tom Tromey  <tom@tromey.com>
7245
7246         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7247         unique_xmalloc_ptr.
7248         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7249         Update.
7250         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7251         (build_minimal_symbol_hash_tables)
7252         (minimal_symbol_reader::install): Update.
7253
7254 2019-03-15  Tom Tromey  <tom@tromey.com>
7255
7256         * symtab.c (create_demangled_names_hash): Update.
7257         (symbol_set_names): Update.
7258         * objfiles.h (struct objfile_per_bfd_storage)
7259         <demangled_names_hash>: Now an htab_up.
7260         * objfiles.c (objfile_per_bfd_storage): Simplify.
7261
7262 2019-03-15  Tom Tromey  <tom@tromey.com>
7263
7264         * objfiles.h (struct objfile_per_bfd_storage): Declare
7265         destructor.
7266         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7267         New.
7268         (get_objfile_bfd_data): Use new.  Don't initialize
7269         language_of_main.
7270         (free_objfile_per_bfd_storage): Remove.
7271         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7272
7273 2019-03-15  Tom Tromey  <tom@tromey.com>
7274
7275         * symfile.c (reread_symbols): Update.
7276         * objfiles.c (objfile::objfile): Update.
7277         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7278         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7279         comment.
7280         (minimal_symbol_reader::install): Update.
7281         (terminate_minimal_symbol_table): Remove.
7282         * jit.c (jit_object_close_impl): Update.
7283
7284 2019-03-15  Tom Tromey  <tom@tromey.com>
7285
7286         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7287         initializations.
7288
7289 2019-03-15  Tom Tromey  <tom@tromey.com>
7290
7291         * objfiles.h (struct objfile_per_bfd_storage)
7292         <demangled_hash_languages>: Now a bitset.
7293         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7294         (lookup_minimal_symbol): Update.
7295
7296 2019-03-15  Tom Tromey  <tom@tromey.com>
7297
7298         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7299         Don't return the symbol.
7300         * coffread.c (record_minimal_symbol): Use record_full.
7301
7302 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7303
7304         The MS-Windows port of ncurses fails to switch to a color pair if
7305         one or both of the colors are the implicit default colors.  This
7306         change records the default colors when TUI is initialized, and
7307         then specifies them explicitly when a color pair uses the default
7308         colors.  This allows color styling in TUI mode on MS-Windows.
7309
7310         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7311         ncurses_norm_attr.
7312         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7313         colors in ncurses_norm_attr.
7314         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7315         "none", replace it with the default color recorded in
7316         ncurses_norm_attr.
7317
7318 2019-03-14  Tom Tromey  <tromey@adacore.com>
7319
7320         * source-cache.h (class source_cache) <get_source_lines>: Return
7321         std::string.
7322         * source-cache.c (source_cache::extract_lines): Handle case where
7323         first_pos==npos.  Return std::string.
7324         (source_cache::get_source_lines): Update.
7325
7326 2019-03-14  Tom Tromey  <tromey@adacore.com>
7327
7328         * NEWS: Add item for "style sources" commands.
7329         * source-cache.c (source_cache::get_source_lines): Check
7330         source_styling.
7331         * cli/cli-style.c (source_styling): New global.
7332         (_initialize_cli_style): Add "style sources" commands.
7333         (show_style_sources): New function.
7334         * cli/cli-style.h (source_styling): Declare.
7335
7336 2019-03-14  Pedro Alves  <palves@redhat.com>
7337             Tom Tromey  <tromey@adacore.com>
7338
7339         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7340         * tui/tui-winsource.c (tui_refill_source_window): New function,
7341         from...
7342         (tui_horizontal_source_scroll): ... here.  Move some logic.
7343         * cli/cli-style.c (set_style_enabled): Notify new observable.
7344         * tui/tui-hooks.c (tui_redisplay_source): New function.
7345         (tui_attach_detach_observers): Attach or detach
7346         tui_redisplay_source.
7347         * observable.h (source_styling_changed): New observable.
7348         * observable.c: Define source_styling_changed observable.
7349
7350 2019-03-13  Tom Tromey  <tromey@adacore.com>
7351
7352         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7353         (i386_gnu_nat_target::store_registers): Update.
7354         * target-debug.h (target_debug_print_std_string): New macro.
7355         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7356         * windows-tdep.c (display_one_tib): Update.
7357         * tui/tui-stack.c (tui_make_status_line): Update.
7358         * top.c (print_inferior_quit_action): Update.
7359         * thread.c (thr_try_catch_cmd): Update.
7360         (add_thread_with_info): Update.
7361         (thread_target_id_str): Update.
7362         (thr_try_catch_cmd): Update.
7363         (thread_command): Update.
7364         (thread_find_command): Update.
7365         * record-btrace.c (record_btrace_target::info_record)
7366         (record_btrace_resume_thread, record_btrace_target::resume)
7367         (record_btrace_cancel_resume, record_btrace_step_thread)
7368         (record_btrace_target::wait, record_btrace_target::wait)
7369         (record_btrace_target::wait, record_btrace_target::stop): Update.
7370         * progspace.c (print_program_space): Update.
7371         * process-stratum-target.c
7372         (process_stratum_target::thread_address_space): Update.
7373         * linux-fork.c (linux_fork_mourn_inferior)
7374         (detach_checkpoint_command, info_checkpoints_command)
7375         (linux_fork_context): Update.
7376         (linux_fork_detach): Update.
7377         (class scoped_switch_fork_info): Update.
7378         (delete_checkpoint_command): Update.
7379         * infrun.c (follow_fork_inferior): Update.
7380         (follow_fork_inferior): Update.
7381         (proceed_after_vfork_done): Update.
7382         (handle_vfork_child_exec_or_exit): Update.
7383         (follow_exec): Update.
7384         (displaced_step_prepare_throw): Update.
7385         (displaced_step_restore): Update.
7386         (start_step_over): Update.
7387         (resume_1): Update.
7388         (clear_proceed_status_thread): Update.
7389         (proceed): Update.
7390         (print_target_wait_results): Update.
7391         (do_target_wait): Update.
7392         (context_switch): Update.
7393         (stop_all_threads): Update.
7394         (restart_threads): Update.
7395         (finish_step_over): Update.
7396         (handle_signal_stop): Update.
7397         (switch_back_to_stepped_thread): Update.
7398         (keep_going_pass_signal): Update.
7399         (print_exited_reason): Update.
7400         (normal_stop): Update.
7401         * inferior.c (inferior_pid_to_str): Change return type.
7402         (print_selected_inferior): Update.
7403         (add_inferior): Update.
7404         (detach_inferior): Update.
7405         * dummy-frame.c (fprint_dummy_frames): Update.
7406         * dcache.c (dcache_info_1): Update.
7407         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7408         (btrace_fetch, btrace_clear): Update.
7409         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7410         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7411         type.
7412         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7413         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7414         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7415         * gdbarch.c, gdbarch.h: Rebuild.
7416         * gdbarch.sh (core_pid_to_str): Change return type.
7417         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7418         return type.
7419         (windows_nat_target::pid_to_str): Change return type.
7420         (windows_delete_thread): Update.
7421         (windows_nat_target::attach): Update.
7422         (windows_nat_target::files_info): Update.
7423         * target-delegates.c: Rebuild.
7424         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7425         return type.
7426         (sol_thread_target::pid_to_str): Change return type.
7427         * remote.c (class remote_target) <pid_to_str>: Change return
7428         type.
7429         (remote_target::pid_to_str): Change return type.
7430         (extended_remote_target::attach, remote_target::remote_stop_ns)
7431         (remote_target::remote_notif_remove_queued_reply)
7432         (remote_target::push_stop_reply, remote_target::disable_btrace):
7433         Update.
7434         (extended_remote_target::attach): Update.
7435         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7436         type.
7437         (gdbsim_target::pid_to_str): Change return type.
7438         * ravenscar-thread.c (struct ravenscar_thread_target)
7439         <pid_to_str>: Change return type.
7440         (ravenscar_thread_target::pid_to_str): Change return type.
7441         * procfs.c (class procfs_target) <pid_to_str>: Change return
7442         type.
7443         (procfs_target::pid_to_str): Change return type.
7444         (procfs_target::attach): Update.
7445         (procfs_target::detach): Update.
7446         (procfs_target::fetch_registers): Update.
7447         (procfs_target::store_registers): Update.
7448         (procfs_target::wait): Update.
7449         (procfs_target::files_info): Update.
7450         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7451         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7452         return type.
7453         (nto_procfs_target::pid_to_str): Change return type.
7454         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7455         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7456         return type.
7457         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7458         (exit_lwp): Update.
7459         (attach_proc_task_lwp_callback, get_detach_signal)
7460         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7461         (linux_nat_target::resume, wait_lwp, stop_callback)
7462         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7463         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7464         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7465         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7466         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7467         type.
7468         (inf_ptrace_target::attach): Update.
7469         (inf_ptrace_target::files_info): Update.
7470         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7471         type.
7472         (go32_nat_target::pid_to_str): Change return type.
7473         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7474         (gnu_nat_target::wait): Update.
7475         (gnu_nat_target::wait): Update.
7476         (gnu_nat_target::resume): Update.
7477         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7478         (fbsd_nat_target::wait): Update.
7479         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7480         type.
7481         (darwin_nat_target::attach): Update.
7482         * corelow.c (class core_target) <pid_to_str>: Change return type.
7483         (core_target::pid_to_str): Change return type.
7484         * target.c (normal_pid_to_str): Change return type.
7485         (default_pid_to_str): Likewise.
7486         (target_pid_to_str): Change return type.
7487         (target_translate_tls_address): Update.
7488         (target_announce_detach): Update.
7489         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7490         return type.
7491         (bsd_uthread_target::pid_to_str): Change return type.
7492         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7493         type.
7494         (bsd_kvm_target::pid_to_str): Change return type.
7495         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7496         return type.
7497         (aix_thread_target::pid_to_str): Change return type.
7498         * target.h (struct target_ops) <pid_to_str>: Change return type.
7499         (target_pid_to_str, normal_pid_to_str): Likewise.
7500         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7501         type.
7502         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7503         type.
7504         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7505         return type.
7506         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7507         type.
7508         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7509         type.
7510         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7511         return type.
7512
7513 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7514
7515         * NEWS: Mention that the new default MI version is 3.  Mention
7516         changes to the output of commands and events that deal with
7517         multi-location breakpoints.
7518         * breakpoint.c: Include "mi/mi-out.h".
7519         (print_one_breakpoint): Change output syntax if using MI version
7520         >= 3.
7521         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7522         New.
7523         (mi_multi_location_breakpoint_output_fixed): New.
7524         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7525         (mi_cmd_fix_multi_location_breakpoint_output): New.
7526         (mi_multi_location_breakpoint_output_fixed): New.
7527         * mi/mi-cmds.c (mi_cmds): Register command
7528         -fix-multi-location-breakpoint-output.
7529         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7530         interpreter "mi".
7531
7532 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7533
7534         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7535         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7536         instantiate mi_ui_out based on interpreter name.
7537         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7538         * mi/mi-main.c (mi_load_progress): Likewise.
7539
7540 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7541
7542         * NEWS: Combine separate "New targets" sections for 8.3.
7543
7544 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7545
7546         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7547         (ppcfbsd_init_abi): Install gdbarch
7548         "fetch_tls_load_module_address" and "get_thread_local_address"
7549         methods.
7550
7551 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7552
7553         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7554         (riscv_fbsd_init_abi): Install gdbarch
7555         "fetch_tls_load_module_address" and "get_thread_local_address"
7556         methods.
7557
7558 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7559
7560         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7561         (i386fbsd_init_abi): Install gdbarch
7562         "fetch_tls_load_module_address" and "get_thread_local_address"
7563         methods.
7564
7565 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7566
7567         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7568         (amd64fbsd_init_abi): Install gdbarch
7569         "fetch_tls_load_module_address" and "get_thread_local_address"
7570         methods.
7571
7572 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7573
7574         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7575         (struct fbsd_pspace_data): New type.
7576         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7577         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7578         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7579         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7580         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7581
7582 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7583
7584         * gdbtypes.c (lookup_struct_elt): New function.
7585         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7586         * gdbtypes.h (struct struct_elt): New type.
7587         (lookup_struct_elt): New prototype.
7588
7589 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7590
7591         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7592         remove disabled code block.
7593
7594 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7595
7596         * gdbarch.sh (get_thread_local_address): New method.
7597         * gdbarch.h, gdbarch.c: Regenerate.
7598         * target.c (target_translate_tls_address): Use
7599         gdbarch_get_thread_local_address if present instead of
7600         target::get_thread_local_address.
7601
7602 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7603
7604         * target.h (target::get_thread_local_address): Update comment.
7605
7606 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7607
7608         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7609         objfile->separate_debug_objfile_backlink if not NULL.
7610
7611 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7612
7613         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7614         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7615         (amd64bsd_store_inferior_registers): Likewise.
7616         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7617         Enable segment base registers.
7618         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7619         PT_GETFSBASE and PT_GETGSBASE.
7620         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7621         PT_SETGSBASE.
7622         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7623         segment base registers.
7624         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7625
7626 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7627
7628         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7629         Update calls to i386_target_description to add 'segments'
7630         parameter.
7631         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7632         add segment base registers.
7633         * arch/i386.c (i386_create_target_description): Add 'segments'
7634         parameter to enable segment base registers.
7635         * arch/i386.h (i386_create_target_description): Likewise.
7636         * features/i386/32bit-segments.xml: New file.
7637         * features/i386/32bit-segments.c: Generate.
7638         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7639         call to i386_target_description to add 'segments' parameter.
7640         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7641         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7642         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7643         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7644         if feature is present.
7645         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7646         Add 'segments' parameter to call to i386_target_description.
7647         (i386_target_description): Add 'segments' parameter to enable
7648         segment base registers.
7649         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7650         to call to i386_target_description.
7651         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7652         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7653         Define I386_NUM_REGS.
7654         (i386_target_description): Add 'segments' parameter to enable
7655         segment base registers.
7656
7657 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7658
7659         PR/24325
7660         * source-cache.c: #undef open and close, to avoid unresolved
7661         externals during linking.
7662
7663 2019-03-12  Tom Tromey  <tromey@adacore.com>
7664
7665         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7666         const.  Add initializers.
7667         (_initialize_remote): Don't initialize ptid globals.
7668
7669 2019-03-12  Pedro Alves  <palves@redhat.com>
7670
7671         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7672
7673 2019-03-12  Pedro Alves  <palves@redhat.com>
7674
7675         * cp-name-parser.y (main): Remove unused 'len' variable.
7676
7677 2019-03-12  Tom Tromey  <tromey@adacore.com>
7678
7679         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7680         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7681
7682 2019-03-12  Tom Tromey  <tromey@adacore.com>
7683
7684         * linux-nat.c (iterate_over_lwps): Update.
7685         (stop_callback): Remove parameter.
7686         (stop_wait_callback, detach_callback, resume_set_callback)
7687         (select_singlestep_lwp_callback, set_ignore_sigint)
7688         (status_callback, resumed_callback, resume_clear_callback)
7689         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7690         data parameter.
7691         (linux_nat_target::detach, linux_nat_target::resume)
7692         (linux_stop_and_wait_all_lwps, select_event_lwp)
7693         (linux_nat_filter_event, linux_nat_wait_1)
7694         (linux_nat_target::kill, linux_nat_target::stop)
7695         (linux_nat_target::stop): Update.
7696         (linux_nat_resume_callback): Change type.
7697         (resume_stopped_resumed_lwps, count_events_callback)
7698         (select_event_lwp_callback): Likewise.
7699         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7700         * arm-linux-nat.c (struct update_registers_data): Remove.
7701         (update_registers_callback): Change type.
7702         (arm_linux_insert_hw_breakpoint1): Update.
7703         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7704         parameter.
7705         (x86_linux_dr_set_addr): Update.
7706         (x86_linux_dr_set_control): Update.
7707         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7708         (iterate_over_lwps): Use gdb::function_view.
7709         * nat/aarch64-linux-hw-point.c (struct
7710         aarch64_dr_update_callback_param): Remove.
7711         (debug_reg_change_callback): Change type.
7712         (aarch64_notify_debug_reg_change): Update.
7713         * s390-linux-nat.c (s390_refresh_per_info): Update.
7714
7715 2019-03-11  Tom Tromey  <tromey@adacore.com>
7716
7717         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7718         redundant assignment to "this_cu".
7719
7720 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7721
7722         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7723
7724 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7725
7726         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7727         from...
7728         (rank_one_type): ... this.
7729
7730 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7731
7732         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7733         from...
7734         (rank_one_type): ... this.
7735
7736 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7737
7738         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7739         from...
7740         (rank_one_type): ... this.
7741
7742 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7743
7744         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7745         from...
7746         (rank_one_type): ... this.
7747
7748 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7749
7750         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7751         from...
7752         (rank_one_type): ... this.
7753
7754 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7755
7756         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7757         from...
7758         (rank_one_type): ... this.
7759
7760 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7761
7762         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7763         from...
7764         (rank_one_type): ... this.
7765
7766 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7767
7768         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7769         from...
7770         (rank_one_type): ... this.
7771
7772 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7773
7774         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7775         from...
7776         (rank_one_type): ... this.
7777
7778 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7779
7780         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7781         from...
7782         (rank_one_type): ... this.
7783
7784 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7785
7786         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7787         from...
7788         (rank_one_type): ... this.
7789
7790 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7791
7792         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7793         from...
7794         (rank_one_type): ... this.
7795
7796 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7797
7798         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7799         inferior-events' shows the example events.
7800
7801 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7802
7803         Support styling on native MS-Windows console
7804
7805         PR/24315
7806         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7807         on MS-Windows if $TERM is not defined.
7808
7809         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7810
7811         * posix-hdep.c (gdb_console_fputs):
7812         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7813         functions.
7814         * ui-file.h (gdb_console_fputs): Add prototype.
7815
7816         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7817         back to fputs only if the former returns zero.
7818
7819 2019-03-07  Tom Tromey  <tom@tromey.com>
7820
7821         * symmisc.c (print_symbol_bcache_statistics): Update.
7822         (print_objfile_statistics): Update.
7823         * symfile.c (allocate_symtab): Update.
7824         * stabsread.c: Don't include bcache.h.
7825         * psymtab.h (struct psymbol_bcache): Don't declare.
7826         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7827         (psymbol_bcache_init, psymbol_bcache_free)
7828         (psymbol_bcache_get_bcache): Don't declare.
7829         * psymtab.c (struct psymbol_bcache): Remove.
7830         (psymtab_storage::psymtab_storage): Update.
7831         (psymtab_storage::~psymtab_storage): Update.
7832         (psymbol_bcache_init, psymbol_bcache_free)
7833         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7834         (add_psymbol_to_bcache): Update.
7835         (allocate_psymtab): Update.
7836         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7837         macro_cache>: No longer pointers.
7838         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7839         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7840         * macrotab.c (macro_bcache): Update.
7841         * macroexp.c: Don't include bcache.h.
7842         * gdbtypes.c (check_types_worklist): Update.
7843         (types_deeply_equal): Remove TRY/CATCH.  Update.
7844         * elfread.c (elf_symtab_read): Update.
7845         * dwarf2read.c: Don't include bcache.h.
7846         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7847         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7848         (print_bcache_statistics, bcache_memory_used): Don't declare.
7849         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7850         methods.  Rename all data members.
7851         * bcache.c (struct bcache): Move to bcache.h.
7852         (bcache::expand_hash_table): Rename from expand_hash_table.
7853         (bcache): Remove.
7854         (bcache::insert): Rename from bcache_full.
7855         (bcache::compare): Rename from bcache_compare.
7856         (bcache_xmalloc): Remove.
7857         (bcache::~bcache): Rename from bcache_xfree.
7858         (bcache::print_statistics): Rename from print_bcache_statistics.
7859         (bcache::memory_used): Rename from bcache_memory_used.
7860
7861 2019-03-07  Pedro Alves  <palves@redhat.com>
7862
7863         * infrun.c (normal_stop): Also check for
7864         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7865
7866 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7867
7868         * f-lang.c (value_from_host_double): Moved to...
7869         * value.c (value_from_host_double): ...here.
7870         * value.h (value_from_host_double): Declare.
7871         * guile/scm-math.c (vlscm_convert_typed_number): Use
7872         value_from_host_double.
7873         (vlscm_convert_number): Likewise.
7874         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7875         * python/py-value.c (convert_value_from_python): Likewise.
7876
7877 2019-03-06  Tom Tromey  <tom@tromey.com>
7878
7879         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7880
7881 2019-03-06  Tom Tromey  <tom@tromey.com>
7882
7883         * utils.h (free_current_contents): Don't declare.
7884         * utils.c (free_current_contents): Remove.
7885
7886 2019-03-06  Tom Tromey  <tom@tromey.com>
7887
7888         * top.c (quit_force): Update.
7889         * main.c (captured_command_loop): Update.
7890         * common/new-op.c (operator new): Update.
7891         * common/common-exceptions.c (struct catcher)
7892         <save_cleanup_chain>: Remove member.
7893         (exceptions_state_mc_init): Update.
7894         (exception_try_scope_entry): Return nullptr.
7895         (exception_try_scope_exit, exception_rethrow)
7896         (throw_exception_sjlj, throw_exception_cxx): Update.
7897         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7898         (all_cleanups, do_cleanups, discard_cleanups)
7899         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7900         (restore_cleanups, restore_final_cleanups): Don't declare.
7901         (do_final_cleanups): Remove parameter.
7902         * common/cleanups.c (cleanup_chain, make_cleanup)
7903         (make_cleanup_dtor, all_cleanups, do_cleanups)
7904         (discard_my_cleanups, discard_cleanups)
7905         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7906         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7907         (null_cleanup): Remove.
7908         (do_final_cleanups): Remove parameter.
7909
7910 2019-03-06  Tom Tromey  <tom@tromey.com>
7911
7912         * remote.c (remote_target::remote_parse_stop_reply): Use
7913         unique_xmalloc_ptr.
7914
7915 2019-03-06  Tom Tromey  <tom@tromey.com>
7916
7917         * stabsread.c (struct stabs_field_info): Rename from field_info.
7918         <list, fnlist>: Add initializers.
7919         <obstack>: New member.
7920         (read_member_functions, read_struct_fields, read_baseclasses):
7921         Allocate on obstack.  Don't use cleanups.
7922         (read_one_struct_field, read_member_functions, read_struct_fields)
7923         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7924         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7925         (read_struct_type): Update.
7926
7927 2019-03-06  Tom Tromey  <tom@tromey.com>
7928
7929         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7930         * common/filestuff.h (make_cleanup_close): Don't declare.
7931         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7932         Remove.
7933
7934 2019-03-06  Tom Tromey  <tom@tromey.com>
7935
7936         * solib-aix.c: Use make_scope_exit.
7937
7938 2019-03-06  Tom Tromey  <tom@tromey.com>
7939
7940         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7941         Use make_scope_exit.
7942
7943 2019-03-06  Tom Tromey  <tom@tromey.com>
7944
7945         * solib-svr4.c (disable_probes_interface): Remove parameter.
7946         (svr4_handle_solib_event): Use make_scope_exit.
7947
7948 2019-03-06  Tom Tromey  <tom@tromey.com>
7949
7950         * remote.c (struct stop_reply_deleter): Remove.
7951         (stop_reply_up): Update.
7952         (struct stop_reply): Derive from notif_event.  Don't typedef.
7953         <regcache>: Now a std::vector.
7954         (stop_reply_xfree): Remove.
7955         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7956         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7957         (remote_target::discard_pending_stop_replies): Use delete.
7958         (remote_target::remote_parse_stop_reply): Update.
7959         (remote_target::process_stop_reply): Update.
7960         * remote-notif.h (struct notif_event): Add virtual destructor.
7961         Remove "dtr" member.
7962         (struct notif_client) <alloc_event>: Return a unique_ptr.
7963         (notif_event_xfree): Don't declare.
7964         (notif_event_up): New typedef.
7965         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7966         (notif_event_xfree, do_notif_event_xfree): Remove.
7967         (remote_notif_state_xfree): Update.
7968
7969 2019-03-06  Tom Tromey  <tom@tromey.com>
7970
7971         * infrun.c (displaced_step_clear_cleanup): Now a
7972         forward_scope_exit type.
7973         (displaced_step_prepare_throw): Update.
7974         (displaced_step_fixup): Update.
7975
7976 2019-03-06  Tom Tromey  <tom@tromey.com>
7977
7978         * inferior.h (class inferior): Update comment.
7979         * gdbthread.h (class thread_info): Update comment.
7980
7981 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7982             Tom Tromey  <tom@tromey.com>
7983
7984         * stabsread.h (struct stab_section_list): Remove.
7985         (coffstab_build_psymtabs): Update.
7986         * dbxread.c (symbuf_sections): Now a std::vector.
7987         (sect_idx): New global.
7988         (fill_symbuf): Update.
7989         (coffstab_build_psymtabs): Change type of stabsects parameter.
7990         Update.
7991         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7992         std::vector.
7993         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7994         (coff_locate_sections): Update.
7995         (coff_symfile_read): Remove cleanups.  Update.
7996         (init_stringtab): Add storage parameter.
7997         (free_stringtab, free_stringtab_cleanup): Remove.
7998         (init_lineno): Add storage parameter.
7999         (free_linetab, free_linetab_cleanup): Remove.
8000
8001 2019-03-06  Pedro Alves  <palves@redhat.com>
8002
8003         * linux-fork.c (fork_info::clobber_regs): Delete.
8004         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8005         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8006         comment.  Adjust.
8007         (scoped_switch_fork_info::scoped_switch_fork_info)
8008         (checkpoint_command, linux_fork_context): Adjust
8009         fork_save_infrun_state calls.
8010
8011 2019-03-06  Pedro Alves  <palves@redhat.com>
8012
8013         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8014         (inf_has_multiple_threads): Return 'bool' and rewrite using
8015         inferior_info::threads().
8016
8017 2019-03-06  Pedro Alves  <palves@redhat.com>
8018
8019         * linux-fork.c: Include <list>.
8020         (fork_list): Now a std::list instance.
8021         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8022         (forks_exist_p, find_last_fork): Adjust.
8023         (new_fork): Delete.
8024         (one_fork_p): New.
8025         (add_fork): Adjust.
8026         (free_fork): Delete, folded into fork_info::~fork_info().
8027         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8028         Adjust.
8029         (init_fork_list): Delete.
8030         (linux_fork_killall, linux_fork_mourn_inferior)
8031         (linux_fork_detach, info_checkpoints_command): Adjust.
8032         (_initialize_linux_fork): No longer call init_fork_list.
8033
8034 2019-03-06  Pedro Alves  <palves@redhat.com>
8035
8036         * linux-fork.c (new_fork): New, split out of ...
8037         (add_fork): ... this.  Return void.  Move "first fork" special
8038         case from here, to ...
8039         (checkpoint_command): ... here.
8040         * linux-linux.h (add_fork): Return void.
8041
8042 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8043
8044         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8045
8046 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8047             Chris January  <chris.january@arm.com>
8048             David Lecomber  <david.lecomber@arm.com>
8049
8050         * f-exp.y: New token, UNOP_INTRINSIC.
8051         (exp): New pattern using UNOP_INTRINSIC token.
8052         (f77_keywords): Add 'abs' keyword.
8053         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8054         (value_from_host_double): New function.
8055         (evaluate_subexp_f): Support UNOP_ABS.
8056
8057 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8058
8059         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8060         types.
8061
8062 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8063
8064         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8065         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8066         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8067
8068 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8069
8070         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8071
8072 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8073             Chris January  <chris.january@arm.com>
8074
8075         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8076         * f-exp.y: Define 'KIND' token.
8077         (exp): New pattern for KIND expressions.
8078         (ptype): Handle types with a kind extension.
8079         (direct_abs_decl): Extend to spot kind extensions.
8080         (f77_keywords): Add 'kind' to the list.
8081         (push_kind_type): New function.
8082         (convert_to_kind_type): New function.
8083         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8084         * parse.c (operator_length_standard): Likewise.
8085         * parser-defs.h (enum type_pieces): Add tp_kind.
8086         * std-operator.def: Add UNOP_KIND.
8087
8088 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8089
8090         * f-exp.y (f_parse): Set yydebug.
8091
8092 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8093
8094         * f-lang.c (evaluate_subexp_f): New function.
8095         (exp_descriptor_f): New global.
8096         (f_language_defn): Use exp_descriptor_f instead of
8097         exp_descriptor_standard.
8098
8099 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8100
8101         * f-exp.y (struct token): Add comments.
8102         (dot_ops): Remove uppercase versions and the end marker.
8103         (f77_keywords): Likewise.
8104         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8105         entries in the dot_ops array are case insensitive, and use
8106         strncasecmp to compare strings.  Also some whitespace cleanup in
8107         this area.  Similar for the f77_keywords array, except entries in
8108         this list might be case sensitive.
8109
8110 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8111
8112         * f-exp.y (struct f77_boolean_val): Add comments.
8113         (boolean_values): Remove uppercase versions, and end marker.
8114         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8115         and use strncasecmp to achieve case insensitivity.  Additionally,
8116         perform whitespace cleanup around this code.
8117
8118 2019-03-06  Tom Tromey  <tromey@adacore.com>
8119
8120         * remote-sim.c (gdbsim_target_open): Use result of
8121         gdb_argv::release.
8122
8123 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8124         Dirk Schubert  <dirk.schubert@arm.com>
8125         Chris January  <chris.january@arm.com>
8126
8127         * eval.c (evaluate_subexp_standard): Call Fortran argument
8128         wrapping logic.
8129         * f-lang.c (struct value): A value which can be passed into a
8130         Fortran function call.
8131         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8132         where appropriate.
8133         (struct type): Value ready for a Fortran function call.
8134         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8135         is needed.
8136         * f-lang.h (fortran_argument_convert): Declaration.
8137         (fortran_preserve_arg_pointer): Declaration.
8138         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8139
8140 2019-03-05  Tom Tromey  <tromey@adacore.com>
8141
8142         * python/py-prettyprint.c (print_string_repr): Remove #if.
8143         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8144
8145 2019-03-05  Tom Tromey  <tromey@adacore.com>
8146
8147         * target.c (the_dummy_target): Move later.  Change type to
8148         "dummy_target".
8149         (initialize_targets): Don't initialize the_dummy_target.
8150
8151 2019-03-05  Tom Tromey  <tromey@adacore.com>
8152
8153         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8154         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8155
8156 2019-03-05  Tom Tromey  <tromey@adacore.com>
8157
8158         * windows-nat.c (windows_nat_target::attach)
8159         (windows_nat_target::detach): Don't call gdb_flush.
8160         * valprint.c (generic_val_print, val_print, val_print_string):
8161         Don't call gdb_flush.
8162         * utils.c (defaulted_query): Don't call gdb_flush.
8163         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8164         * target.c (target_announce_detach): Don't call gdb_flush.
8165         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8166         * remote.c (extended_remote_target::attach): Don't call
8167         gdb_flush.
8168         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8169         * printcmd.c (do_examine): Don't call gdb_flush.
8170         (info_display_command): Don't call gdb_flush.
8171         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8172         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8173         * memattr.c (info_mem_command): Don't call gdb_flush.
8174         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8175         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8176         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8177         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8178         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8179         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8180         (gnu_nat_target::detach): Don't call gdb_flush.
8181         * f-valprint.c (f_val_print): Don't call gdb_flush.
8182         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8183         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8184         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8185         gdb_flush.
8186         * c-valprint.c (c_val_print): Don't call gdb_flush.
8187         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8188
8189 2019-03-05  Tom Tromey  <tromey@adacore.com>
8190
8191         * varobj.c (update_dynamic_varobj_children): Update.
8192         (install_default_visualizer): Use reset, not release.
8193         * value.c (set_internalvar): Update.
8194         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8195         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8196         ATTRIBUTE_UNUSED_RESULT.
8197
8198 2019-03-05  Tom Tromey  <tromey@adacore.com>
8199
8200         * remote.c (class scoped_remote_fd) <release>: Add
8201         ATTRIBUTE_UNUSED_RESULT.
8202
8203 2019-03-05  Tom Tromey  <tromey@adacore.com>
8204
8205         * macroexp.c (struct macro_buffer) <release>: Add
8206         ATTRIBUTE_UNUSED_RESULT.
8207
8208 2019-03-05  Tom Tromey  <tromey@adacore.com>
8209
8210         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8211         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8212         ATTRIBUTE_UNUSED_RESULT.
8213
8214 2019-03-05  Tom Tromey  <tromey@adacore.com>
8215
8216         * common/scoped_fd.h (class scoped_fd) <release>: Add
8217         ATTRIBUTE_UNUSED_RESULT.
8218
8219 2019-03-05  Tom Tromey  <tromey@adacore.com>
8220
8221         * parser-defs.h (struct parser_state) <release>: Add
8222         ATTRIBUTE_UNUSED_RESULT.
8223
8224 2019-03-05  Tom Tromey  <tromey@adacore.com>
8225
8226         * utils.h (class gdb_argv) <release>: Add
8227         ATTRIBUTE_UNUSED_RESULT.
8228         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8229
8230 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8231
8232         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8233         for-loop range, to avoid compiler warnings.
8234
8235         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8236         avoid compiler warnings about unused variables.
8237
8238         * NEWS: Mention end of support for native debugging on MS-Windows
8239         before XP.
8240
8241         PR gdb/24292
8242         * common/netstuff.c:
8243         * gdbserver/gdbreplay.c
8244         * gdbserver/remote-utils.c:
8245         * ser-tcp.c:
8246         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8247         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8248         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8249         'getaddrinfo' and 'freeaddrinfo' were not available before
8250         Windows XP, and mingw.org's MinGW headers by default define
8251         _WIN32_WINNT to 0x500.
8252
8253 2019-03-01  Gary Benson <gbenson@redhat.com>
8254
8255         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8256
8257 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8258             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8259
8260         PR gdb/8527
8261         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8262         set_sigint_trap, clear_sigint_trap.
8263
8264 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8265
8266         * target.c (target_detach): Clear the regcache and the
8267         frame cache.
8268
8269 2019-02-27  Pedro Alves  <palves@redhat.com>
8270
8271         * utils.c (set_screen_size): When we cap the height/width sizes,
8272         tweak the corresponding command variable to show "unlimited":
8273
8274 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8275             Pedro Alves  <palves@redhat.com>
8276
8277         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8278         before calling rl_set_screen_size.
8279
8280 2019-02-27  Tom Tromey  <tromey@adacore.com>
8281
8282         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8283         define.
8284         * python/py-value.c: Remove Python 2.4 workaround.
8285         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8286         workaround.
8287         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8288         Python 2.4 workaround.
8289         * python/python-internal.h: Remove Python 2.4 comment.
8290         (Py_ssize_t): Don't define.
8291         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8292         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8293         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8294         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8295         * python/python.c (do_start_initialization): Remove Python 2.4
8296         workaround.
8297         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8298         (print_children): Remove Python 2.4 workaround.
8299         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8300         workaround.
8301         (CHARBUFFERPROC_NAME): Remove.
8302         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8303         Python 2.4 workaround.
8304
8305 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8306
8307         * NEWS: Note minimum Python version.
8308
8309 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8310
8311         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8312         code from these functions.  Remove corresponding ifdefs.  Use
8313         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8314         Remove gotos and target of gotos.
8315         (infpy_search_memory): Likewise.
8316
8317 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8318
8319         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8320         (hppa_gdbarch_init): Don't register deleted functions with
8321         gdbarch.
8322
8323 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8324
8325         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8326         (h8300_unwind_sp): Delete.
8327         (h8300_dummy_id): Delete.
8328         (h8300_gdbarch_init): Don't register deleted functions with
8329         gdbarch.
8330
8331 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8332
8333         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8334         (ft32_unwind_pc): Delete.
8335         (ft32_unwind_sp): Delete.
8336         (ft32_gdbarch_init): Don't register deleted functions with
8337         gdbarch.
8338
8339 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8340
8341         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8342         (frv_unwind_pc): Delete.
8343         (frv_unwind_sp): Delete.
8344         (frv_gdbarch_init): Don't register deleted functions with
8345         gdbarch.
8346
8347 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8348
8349         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8350         (riscv_unwind_pc): Delete.
8351         (riscv_unwind_sp): Delete.
8352         (riscv_gdbarch_init): Don't register deleted functions with
8353         gdbarch.
8354
8355 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8356
8357         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8358         (csky_unwind_pc): Delete.
8359         (csky_unwind_sp): Delete.
8360         (csky_gdbarch_init): Don't register deleted functions with
8361         gdbarch.
8362
8363 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8364
8365         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8366         (cris_unwind_pc): Delete.
8367         (cris_unwind_sp): Delete.
8368         (cris_gdbarch_init): Don't register deleted functions with
8369         gdbarch.
8370
8371 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8372
8373         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8374         (bfin_unwind_pc): Delete.
8375         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8376
8377 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8378
8379         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8380         (arm_unwind_pc): Delete.
8381         (arm_unwind_sp): Delete.
8382         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8383
8384 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8385
8386         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8387         (arc_unwind_pc): Delete.
8388         (arc_unwind_sp): Delete.
8389         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8390
8391 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8392
8393         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8394         (alpha_unwind_pc): Delete.
8395         (alpha_gdbarch_init): Don't register deleted functions with
8396         gdbarch.
8397
8398 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8399
8400         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8401         (aarch64_unwind_pc): Delete.
8402         (aarch64_unwind_sp): Delete.
8403         (aarch64_gdbarch_init): Don't register deleted functions with
8404         gdbarch.
8405
8406 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8407
8408         * gdbtypes.c (type_align): Don't consider static members when
8409         computing structure alignment.
8410
8411 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8412
8413         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8414         return 0 for other types.
8415         * arch-utils.c (default_type_align): Always return 0.
8416         * gdbarch.h: Regenerate.
8417         * gdbarch.sh (type_align): Extend comment.
8418         * gdbtypes.c (type_align): Add additional comments, always call
8419         gdbarch_type_align before applying the default rules.
8420         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8421         generic code will then apply a suitable default.
8422         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8423         types, return 0 for other types.
8424
8425 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8426
8427         * NEWS: Create a new section for the next release branch.
8428         Rename the section of the current branch, now that it has
8429         been cut.
8430
8431 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8432
8433         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8434         * version.in: Bump version to 8.3.50.DATE-git.
8435
8436 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8437
8438         * aix-thread.c (ptid_cmp): Remove unused variable.
8439         (get_signaled_thread): Likewise.
8440         (store_regs_user_thread): Likewise.
8441         (store_regs_kernel_thread): Likewise.
8442         (fetch_regs_kernel_thread): Remove shadowed variable.
8443
8444 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8445
8446         * features/riscv/32bit-cpu.xml: Add register numbers.
8447         * features/riscv/32bit-fpu.c: Regenerate.
8448         * features/riscv/32bit-fpu.xml: Add register numbers.
8449         * features/riscv/64bit-cpu.xml: Add register numbers.
8450         * features/riscv/64bit-fpu.c: Regenerate.
8451         * features/riscv/64bit-fpu.xml: Add register numbers.
8452
8453 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8454
8455         * NEWS: Mention two argument form of gdb.Value constructor.
8456         * python/py-value.c (convert_buffer_and_type_to_value): New
8457         function.
8458         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8459         Add support for handling an optional second argument.  Call
8460         convert_buffer_and_type_to_value as appropriate.
8461         * python/python-internal.h (Py_buffer_deleter): New struct.
8462         (Py_buffer_up): New typedef.
8463
8464 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8465
8466         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8467         instead of releasing ownership.
8468
8469 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8470
8471         * dwarf2read.c (open_and_init_dwp_file): Call
8472         elf_numsections instead of bfd_count_sections to initialize
8473         dwp_file->num_sections.
8474
8475 2019-02-25  Tom Tromey  <tromey@adacore.com>
8476
8477         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8478
8479 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8480
8481         * gcore.in: Add '--readnever' option when invoking GDB.
8482
8483 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8484
8485         * MAINTAINERS: Update my email address.
8486
8487 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8488
8489         * build-id.c (build_id_to_debug_bfd_1): New function.
8490         (build_id_to_debug_bfd): Look for separate debug file in
8491         sysroot.
8492
8493 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8494
8495         * gdbarch.sh: Update the copyright year range that is placed into
8496         generated files.
8497
8498 2019-02-22  Keith Seitz  <keiths@redhat.com>
8499
8500         PR symtab/23853
8501         * linespec.c (create_sals_line_offset): Search for the default
8502         symtab's filename instead of its fullname.
8503
8504 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8505
8506         * NEWS: Update style defaults.
8507
8508 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8509
8510         * main.c (captured_main_1): Disable styling in batch mode.
8511
8512 2019-02-20  Tom Tromey  <tom@tromey.com>
8513
8514         * symtab.c (symtab_symbol_info): Fix typos.
8515
8516 2019-02-20  Tom Tromey  <tromey@adacore.com>
8517
8518         * findcmd.c (_initialize_mem_search): Use upper case for
8519         metasyntactic variables.
8520
8521 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8522
8523         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8524         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8525
8526 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8527
8528         * top.h (source_file_name): Change to std::string.
8529         * top.c (source_file_name): Likewise.
8530         (command_line_input): Adjust.
8531         * cli/cli-script.c (script_from_file): Adjust.
8532
8533 2019-02-19  Tom Tromey  <tromey@adacore.com>
8534
8535         * ravenscar-thread.c
8536         (ravenscar_thread_target::update_thread_list): Don't call
8537         ada_build_task_list.
8538         * ada-lang.h (ada_build_task_list): Don't declare.
8539         * ada-tasks.c (struct ada_tasks_inferior_data)
8540         <task_list_valid_p>: Now bool.
8541         (read_known_tasks, ada_task_list_changed)
8542         (ada_tasks_invalidate_inferior_data): Update.
8543         (read_known_tasks_array): Return bool.
8544         (read_known_tasks_list): Likewise.
8545         (read_known_tasks): Return void.
8546         (ada_build_task_list): Now static.
8547
8548 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8549
8550         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8551         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8552
8553 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8554
8555         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8556         variant for ada_tasks_pspace_data_handle and
8557         ada_tasks_inferior_data_handle.
8558         (ada_tasks_pspace_data_cleanup): New function.
8559         (ada_tasks_inferior_data_cleanup): New function.
8560
8561 2019-02-17  Tom Tromey  <tom@tromey.com>
8562
8563         * macrotab.h (macro_source_fullname): Return a std::string.
8564         * macrotab.c (macro_include, check_for_redefinition)
8565         (macro_undef, macro_lookup_definition, foreach_macro)
8566         (foreach_macro_in_scope): Update.
8567         (macro_source_fullname): Return a std::string.
8568         * macrocmd.c (show_pp_source_pos): Update.
8569
8570 2019-02-17  Tom Tromey  <tom@tromey.com>
8571
8572         * macrocmd.c (show_pp_source_pos): Style the file names.
8573
8574 2019-02-17  Tom Tromey  <tom@tromey.com>
8575
8576         PR tui/24197:
8577         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8578
8579 2019-02-17  Tom Tromey  <tom@tromey.com>
8580
8581         * ada-lang.c (user_select_syms): Use filtered printing.
8582         * utils.c (wrap_style): New global.
8583         (desired_style): Remove.
8584         (emit_style_escape): Add stream parameter.
8585         (set_output_style, reset_terminal_style, prompt_for_continue):
8586         Update.
8587         (flush_wrap_buffer): Only flush gdb_stdout.
8588         (wrap_here): Set wrap_style.
8589         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8590         treat escape sequences as a character.  Change when wrap buffer is
8591         flushed.
8592         (fputs_styled): Do not set the output style when the default is
8593         requested.
8594         * ui-style.h (struct ui_file_style) <is_default>: New method.
8595         * source.c (print_source_lines_base): Emit escape sequences in one
8596         piece.
8597
8598 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8599
8600         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8601         integers and enumeration types.
8602
8603 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8604
8605         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8606         instead of lookup_symbol_in_language
8607         (do_exact_match): New function.
8608         (ada_get_symbol_name_matcher): Return do_exact_match when
8609         doing a verbatim match.
8610
8611 2019-02-15  Tom Tromey  <tromey@adacore.com>
8612
8613         * ravenscar-thread.c (ravenscar_thread_target::resume)
8614         (ravenscar_thread_target::wait): Special case wildcard requests.
8615
8616 2019-02-15  Tom Tromey  <tromey@adacore.com>
8617
8618         * ravenscar-thread.c (base_ptid): Remove.
8619         (struct ravenscar_thread_target) <close>: New method.
8620         <m_base_ptid>: New member.
8621         <update_inferior_ptid, active_task, task_is_currently_active,
8622         runtime_initialized>: Declare methods.
8623         <ravenscar_thread_target>: Add constructor.
8624         (ravenscar_thread_target::task_is_currently_active)
8625         (ravenscar_thread_target::update_inferior_ptid)
8626         (ravenscar_runtime_initialized): Rename.  Now methods.
8627         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8628         (ravenscar_thread_target::update_thread_list): Update.
8629         (ravenscar_thread_target::active_task): Now method.
8630         (ravenscar_thread_target::store_registers)
8631         (ravenscar_thread_target::prepare_to_store)
8632         (ravenscar_thread_target::prepare_to_store)
8633         (ravenscar_thread_target::mourn_inferior): Update.
8634         (ravenscar_inferior_created): Use "new" to create target.
8635         (ravenscar_thread_target::get_ada_task_ptid): Update.
8636         (_initialize_ravenscar): Don't initialize base_ptid.
8637         (ravenscar_ops): Remove global.
8638
8639 2019-02-15  Tom Tromey  <tromey@adacore.com>
8640
8641         * target.h (push_target): Declare new overload.
8642         * target.c (push_target): New overload, taking an rvalue reference.
8643         * remote.c (remote_target::open_1): Use push_target overload.
8644         * corelow.c (core_target_open): Use push_target overload.
8645
8646 2019-02-15  Tom Tromey  <tromey@adacore.com>
8647
8648         * ravenscar-thread.c (is_ravenscar_task)
8649         (ravenscar_task_is_currently_active): Return bool.
8650         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8651         (_initialize_ravenscar): Remove "(void)".
8652         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8653         Return bool.
8654
8655 2019-02-15  Tom Tromey  <tromey@adacore.com>
8656
8657         * ravenscar-thread.c (ravenscar_runtime_initializer)
8658         (has_ravenscar_runtime, get_running_thread_id)
8659         (ravenscar_thread_target::resume): Fix indentation.
8660
8661 2019-02-15  Tom Tromey  <tromey@adacore.com>
8662
8663         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8664         from ravenscar_arch_ops.
8665         (sparc_ravenscar_ops::fetch_registers)
8666         (sparc_ravenscar_ops::store_registers): Now methods.
8667         (sparc_ravenscar_prepare_to_store): Remove.
8668         (sparc_ravenscar_ops): Redefine.
8669         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8670         methods and destructor.  Remove members.
8671         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8672         (ravenscar_thread_target::store_registers)
8673         (ravenscar_thread_target::prepare_to_store): Update.
8674         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8675         Remove.
8676         (struct ppc_ravenscar_powerpc_ops): Derive from
8677         ravenscar_arch_ops.
8678         (ppc_ravenscar_powerpc_ops::fetch_registers)
8679         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8680         (ppc_ravenscar_powerpc_ops): Redefine.
8681         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8682         (ppc_ravenscar_e500_ops::fetch_registers)
8683         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8684         (ppc_ravenscar_e500_ops): Redefine.
8685         * aarch64-ravenscar-thread.c
8686         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8687         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8688         (aarch64_ravenscar_fetch_registers)
8689         (aarch64_ravenscar_store_registers): Now methods.
8690         (aarch64_ravenscar_ops): Redefine.
8691
8692 2019-02-15  Tom Tromey  <tromey@adacore.com>
8693
8694         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8695         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8696         (ravenscar_thread_target::stopped_by_watchpoint)
8697         (ravenscar_thread_target::stopped_data_address)
8698         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8699
8700 2019-02-15  Tom Tromey  <tromey@adacore.com>
8701
8702         * ravenscar-thread.c: Fix some typos.
8703
8704 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8705             Tom Tromey  <tromey@adacore.com>
8706
8707         * ada-lang.c (ada_exception_sal): Change addr_string to a
8708         std::string.
8709         (create_ada_exception_catchpoint): Update.
8710
8711 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8712             Tom Tromey  <tromey@adacore.com>
8713
8714         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8715         (bp_location_ops): Remove.
8716         (base_breakpoint_allocate_location): Update.
8717         (free_bp_location): Update.
8718         * ada-lang.c (class ada_catchpoint_location)
8719         <ada_catchpoint_location>: Remove ops parameter.
8720         (ada_catchpoint_location_dtor): Remove.
8721         (ada_catchpoint_location_ops): Remove.
8722         (allocate_location_exception): Update.
8723         * breakpoint.h (struct bp_location_ops): Remove.
8724         (class bp_location) <bp_location>: Remove bp_location_ops
8725         parameter.
8726         <~bp_location>: Add destructor.
8727         <ops>: Remove.
8728
8729 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8730             Pedro Alves  <palves@redhat.com>
8731
8732         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8733         'PATH_MAX'.
8734
8735 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8736             Samuel Thibault  <samuel.thibault@gnu.org>
8737             Thomas Schwinge  <thomas@codesourcery.com>
8738
8739         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8740         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8741
8742 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8743
8744         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8745         (check_empty): Use "const char *".
8746
8747         * gnu-nat.c (gnu_nat_target::detach): Instead of
8748         'detach_inferior (pid)' call
8749         'detach_inferior (find_inferior_pid (pid))'.
8750
8751         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8752         'nat/fork-inferior.o'.
8753         * gnu-nat.c: #include "nat/fork-inferior.h".
8754
8755         * gnu-nat.c (gnu_nat_target::detach): Instead of
8756         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8757         * gnu-nat.h: #include "inf-child.h".
8758         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8759         'i386_gnu_nat_target::fetch_registers'.
8760         (gnu_store_registers): Rename/move to
8761         'i386_gnu_nat_target::store_registers'.
8762
8763         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8764         * gnu-nat.h (mach_thread_info): New function.
8765         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8766
8767         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8768
8769 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8770
8771         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8772
8773 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8774
8775         * windows-nat.c (windows_add_thread): Add new parameter
8776         "main_thread_p" with default value set to false.  Update
8777         function documentation as well as all callers.
8778         (windows_delete_thread): Likewise.
8779         (fake_create_process): Update call to windows_add_thread.
8780         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8781         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8782         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8783         call to windows_delete_thread.
8784
8785 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8786
8787         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8788
8789 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8790
8791         * symfile.c (find_separate_debug_file): Use canonical path of
8792         sysroot with child_path instead of gdb_sysroot if it is valid.
8793
8794 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8795
8796         * symfile.c (find_separate_debug_file): Use child_path to
8797         determine if an object file is under a sysroot.
8798
8799 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8800
8801         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8802         unittests/child-path-selftests.c.
8803         * common/pathstuff.c (child_path): New function.
8804         * common/pathstuff.h (child_path): New prototype.
8805         * unittests/child-path-selftests.c: New file.
8806
8807 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8808
8809         * symfile.c (find_separate_debug_file): Look for separate debug
8810         files in debug directories under the sysroot.
8811
8812 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8813
8814         * symtab.h (struct minimal_symbol data_p): New const method.
8815         (struct minimal_symbol text_p): Likewise.
8816         * symtab.c (output_source_filename): Use file name style
8817         to print file name.
8818         (print_symbol_info): Likewise.
8819         (print_msymbol_info): Use address style to print addresses.
8820         Use function name style to print executable text symbols.
8821         (expand_symtab_containing_pc): Use data_p.
8822         (find_pc_sect_compunit_symtab): Likewise.
8823
8824 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8825
8826         * breakpoint.c (describe_other_breakpoints): Use address style
8827         to print addresses.
8828         (say_where): Likewise.
8829
8830 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8831
8832         * ada-typeprint.c (print_func_type): Print function name
8833         style to print function name.
8834         * c-typeprint.c (c_print_type_1): Likewise.
8835
8836 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8837
8838         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8839         for execve.
8840
8841 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8842
8843         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8844         type_stack.
8845
8846 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8847
8848         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8849         TYPE_CODE_REF types.
8850
8851 2019-02-08  Jim Wilson  <jimw@sifive.com>
8852
8853         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8854         (riscv_linux_fregset): New.
8855         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8856
8857 2019-02-07  Tom Tromey  <tom@tromey.com>
8858
8859         * thread.c (thread_cancel_execution_command): Update.
8860         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8861         methods.
8862         (struct thread_fsm_ops): Remove.
8863         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8864         (thread_fsm_should_stop, thread_fsm_return_value)
8865         (thread_fsm_set_finished, thread_fsm_finished_p)
8866         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8867         Don't declare.
8868         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8869         * infrun.c (clear_proceed_status_thread)
8870         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8871         (print_stop_event): Update.
8872         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8873         Add constructor.
8874         (step_command_fsm_ops): Remove.
8875         (new_step_command_fsm): Remove.
8876         (step_1): Update.
8877         (step_command_fsm::should_stop): Rename from
8878         step_command_fsm_should_stop.
8879         (step_command_fsm::clean_up): Rename from
8880         step_command_fsm_clean_up.
8881         (step_command_fsm::do_async_reply_reason): Rename from
8882         step_command_fsm_async_reply_reason.
8883         (struct until_next_fsm): Inherit from thread_fsm.  Add
8884         constructor.
8885         (until_next_fsm_ops): Remove.
8886         (new_until_next_fsm): Remove.
8887         (until_next_fsm::should_stop): Rename from
8888         until_next_fsm_should_stop.
8889         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8890         (until_next_fsm::do_async_reply_reason): Rename from
8891         until_next_fsm_async_reply_reason.
8892         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8893         constructor.  Change type of breakpoint.
8894         (finish_command_fsm_ops): Remove.
8895         (new_finish_command_fsm): Remove.
8896         (finish_command_fsm::should_stop): Rename from
8897         finish_command_fsm_should_stop.
8898         (finish_command_fsm::clean_up): Rename from
8899         finish_command_fsm_clean_up.
8900         (finish_command_fsm::return_value): Rename from
8901         finish_command_fsm_return_value.
8902         (finish_command_fsm::do_async_reply_reason): Rename from
8903         finish_command_fsm_async_reply_reason.
8904         (finish_command): Update.
8905         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8906         Add constructor.
8907         (call_thread_fsm_ops): Remove.
8908         (call_thread_fsm::call_thread_fsm): Rename from
8909         new_call_thread_fsm.
8910         (call_thread_fsm::should_stop): Rename from
8911         call_thread_fsm_should_stop.
8912         (call_thread_fsm::should_notify_stop): Rename from
8913         call_thread_fsm_should_notify_stop.
8914         (run_inferior_call, call_function_by_hand_dummy): Update.
8915         * cli/cli-interp.c (should_print_stop_to_console): Update.
8916         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8917         Add constructor.  Change type of location_breakpoint,
8918         caller_breakpoint.
8919         (until_break_fsm_ops): Remove.
8920         (new_until_break_fsm): Remove.
8921         (until_break_fsm::should_stop): Rename from
8922         until_break_fsm_should_stop.
8923         (until_break_fsm::clean_up): Rename from
8924         until_break_fsm_clean_up.
8925         (until_break_fsm::do_async_reply_reason): Rename from
8926         until_break_fsm_async_reply_reason.
8927         (until_break_command): Update.
8928         * thread-fsm.c: Remove.
8929         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8930
8931 2019-02-07  Tom Tromey  <tom@tromey.com>
8932
8933         * yy-remap.h: Add include guard.
8934         * xtensa-tdep.h: Add include guard.
8935         * xcoffread.h: Rename include guard.
8936         * varobj-iter.h: Add include guard.
8937         * tui/tui.h: Rename include guard.
8938         * tui/tui-winsource.h: Rename include guard.
8939         * tui/tui-wingeneral.h: Rename include guard.
8940         * tui/tui-windata.h: Rename include guard.
8941         * tui/tui-win.h: Rename include guard.
8942         * tui/tui-stack.h: Rename include guard.
8943         * tui/tui-source.h: Rename include guard.
8944         * tui/tui-regs.h: Rename include guard.
8945         * tui/tui-out.h: Rename include guard.
8946         * tui/tui-layout.h: Rename include guard.
8947         * tui/tui-io.h: Rename include guard.
8948         * tui/tui-hooks.h: Rename include guard.
8949         * tui/tui-file.h: Rename include guard.
8950         * tui/tui-disasm.h: Rename include guard.
8951         * tui/tui-data.h: Rename include guard.
8952         * tui/tui-command.h: Rename include guard.
8953         * tic6x-tdep.h: Add include guard.
8954         * target/waitstatus.h: Rename include guard.
8955         * target/wait.h: Rename include guard.
8956         * target/target.h: Rename include guard.
8957         * target/resume.h: Rename include guard.
8958         * target-float.h: Rename include guard.
8959         * stabsread.h: Add include guard.
8960         * rs6000-tdep.h: Add include guard.
8961         * riscv-fbsd-tdep.h: Add include guard.
8962         * regformats/regdef.h: Rename include guard.
8963         * record.h: Rename include guard.
8964         * python/python.h: Rename include guard.
8965         * python/python-internal.h: Rename include guard.
8966         * python/py-stopevent.h: Rename include guard.
8967         * python/py-ref.h: Rename include guard.
8968         * python/py-record.h: Rename include guard.
8969         * python/py-record-full.h: Rename include guard.
8970         * python/py-record-btrace.h: Rename include guard.
8971         * python/py-instruction.h: Rename include guard.
8972         * python/py-events.h: Rename include guard.
8973         * python/py-event.h: Rename include guard.
8974         * procfs.h: Add include guard.
8975         * proc-utils.h: Add include guard.
8976         * p-lang.h: Add include guard.
8977         * or1k-tdep.h: Rename include guard.
8978         * observable.h: Rename include guard.
8979         * nto-tdep.h: Rename include guard.
8980         * nat/x86-linux.h: Rename include guard.
8981         * nat/x86-linux-dregs.h: Rename include guard.
8982         * nat/x86-gcc-cpuid.h: Add include guard.
8983         * nat/x86-dregs.h: Rename include guard.
8984         * nat/x86-cpuid.h: Rename include guard.
8985         * nat/ppc-linux.h: Rename include guard.
8986         * nat/mips-linux-watch.h: Rename include guard.
8987         * nat/linux-waitpid.h: Rename include guard.
8988         * nat/linux-ptrace.h: Rename include guard.
8989         * nat/linux-procfs.h: Rename include guard.
8990         * nat/linux-osdata.h: Rename include guard.
8991         * nat/linux-nat.h: Rename include guard.
8992         * nat/linux-namespaces.h: Rename include guard.
8993         * nat/linux-btrace.h: Rename include guard.
8994         * nat/glibc_thread_db.h: Rename include guard.
8995         * nat/gdb_thread_db.h: Rename include guard.
8996         * nat/gdb_ptrace.h: Rename include guard.
8997         * nat/fork-inferior.h: Rename include guard.
8998         * nat/amd64-linux-siginfo.h: Rename include guard.
8999         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9000         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9001         * nat/aarch64-linux.h: Rename include guard.
9002         * nat/aarch64-linux-hw-point.h: Rename include guard.
9003         * mn10300-tdep.h: Add include guard.
9004         * mips-linux-tdep.h: Add include guard.
9005         * mi/mi-parse.h: Rename include guard.
9006         * mi/mi-out.h: Rename include guard.
9007         * mi/mi-main.h: Rename include guard.
9008         * mi/mi-interp.h: Rename include guard.
9009         * mi/mi-getopt.h: Rename include guard.
9010         * mi/mi-console.h: Rename include guard.
9011         * mi/mi-common.h: Rename include guard.
9012         * mi/mi-cmds.h: Rename include guard.
9013         * mi/mi-cmd-break.h: Rename include guard.
9014         * m2-lang.h: Add include guard.
9015         * location.h: Rename include guard.
9016         * linux-record.h: Rename include guard.
9017         * linux-nat.h: Add include guard.
9018         * linux-fork.h: Add include guard.
9019         * i386-darwin-tdep.h: Rename include guard.
9020         * hppa-linux-offsets.h: Add include guard.
9021         * guile/guile.h: Rename include guard.
9022         * guile/guile-internal.h: Rename include guard.
9023         * gnu-nat.h: Rename include guard.
9024         * gdb-stabs.h: Rename include guard.
9025         * frv-tdep.h: Add include guard.
9026         * f-lang.h: Add include guard.
9027         * event-loop.h: Add include guard.
9028         * darwin-nat.h: Rename include guard.
9029         * cp-abi.h: Rename include guard.
9030         * config/sparc/nm-sol2.h: Rename include guard.
9031         * config/nm-nto.h: Rename include guard.
9032         * config/nm-linux.h: Add include guard.
9033         * config/i386/nm-i386gnu.h: Rename include guard.
9034         * config/djgpp/nl_types.h: Rename include guard.
9035         * config/djgpp/langinfo.h: Rename include guard.
9036         * compile/gcc-cp-plugin.h: Add include guard.
9037         * compile/gcc-c-plugin.h: Add include guard.
9038         * compile/compile.h: Rename include guard.
9039         * compile/compile-object-run.h: Rename include guard.
9040         * compile/compile-object-load.h: Rename include guard.
9041         * compile/compile-internal.h: Rename include guard.
9042         * compile/compile-cplus.h: Rename include guard.
9043         * compile/compile-c.h: Rename include guard.
9044         * common/xml-utils.h: Rename include guard.
9045         * common/x86-xstate.h: Rename include guard.
9046         * common/version.h: Rename include guard.
9047         * common/vec.h: Rename include guard.
9048         * common/tdesc.h: Rename include guard.
9049         * common/selftest.h: Rename include guard.
9050         * common/scoped_restore.h: Rename include guard.
9051         * common/scoped_mmap.h: Rename include guard.
9052         * common/scoped_fd.h: Rename include guard.
9053         * common/safe-iterator.h: Rename include guard.
9054         * common/run-time-clock.h: Rename include guard.
9055         * common/refcounted-object.h: Rename include guard.
9056         * common/queue.h: Rename include guard.
9057         * common/ptid.h: Rename include guard.
9058         * common/print-utils.h: Rename include guard.
9059         * common/preprocessor.h: Rename include guard.
9060         * common/pathstuff.h: Rename include guard.
9061         * common/observable.h: Rename include guard.
9062         * common/netstuff.h: Rename include guard.
9063         * common/job-control.h: Rename include guard.
9064         * common/host-defs.h: Rename include guard.
9065         * common/gdb_wait.h: Rename include guard.
9066         * common/gdb_vecs.h: Rename include guard.
9067         * common/gdb_unlinker.h: Rename include guard.
9068         * common/gdb_unique_ptr.h: Rename include guard.
9069         * common/gdb_tilde_expand.h: Rename include guard.
9070         * common/gdb_sys_time.h: Rename include guard.
9071         * common/gdb_string_view.h: Rename include guard.
9072         * common/gdb_splay_tree.h: Rename include guard.
9073         * common/gdb_setjmp.h: Rename include guard.
9074         * common/gdb_ref_ptr.h: Rename include guard.
9075         * common/gdb_optional.h: Rename include guard.
9076         * common/gdb_locale.h: Rename include guard.
9077         * common/gdb_assert.h: Rename include guard.
9078         * common/filtered-iterator.h: Rename include guard.
9079         * common/filestuff.h: Rename include guard.
9080         * common/fileio.h: Rename include guard.
9081         * common/environ.h: Rename include guard.
9082         * common/common-utils.h: Rename include guard.
9083         * common/common-types.h: Rename include guard.
9084         * common/common-regcache.h: Rename include guard.
9085         * common/common-inferior.h: Rename include guard.
9086         * common/common-gdbthread.h: Rename include guard.
9087         * common/common-exceptions.h: Rename include guard.
9088         * common/common-defs.h: Rename include guard.
9089         * common/common-debug.h: Rename include guard.
9090         * common/cleanups.h: Rename include guard.
9091         * common/buffer.h: Rename include guard.
9092         * common/btrace-common.h: Rename include guard.
9093         * common/break-common.h: Rename include guard.
9094         * cli/cli-utils.h: Rename include guard.
9095         * cli/cli-style.h: Rename include guard.
9096         * cli/cli-setshow.h: Rename include guard.
9097         * cli/cli-script.h: Rename include guard.
9098         * cli/cli-interp.h: Rename include guard.
9099         * cli/cli-decode.h: Rename include guard.
9100         * cli/cli-cmds.h: Rename include guard.
9101         * charset-list.h: Add include guard.
9102         * buildsym-legacy.h: Rename include guard.
9103         * bfin-tdep.h: Add include guard.
9104         * ax.h: Rename include guard.
9105         * arm-linux-tdep.h: Add include guard.
9106         * arm-fbsd-tdep.h: Add include guard.
9107         * arch/xtensa.h: Rename include guard.
9108         * arch/tic6x.h: Add include guard.
9109         * arch/i386.h: Add include guard.
9110         * arch/arm.h: Rename include guard.
9111         * arch/arm-linux.h: Rename include guard.
9112         * arch/arm-get-next-pcs.h: Rename include guard.
9113         * arch/amd64.h: Add include guard.
9114         * arch/aarch64-insn.h: Rename include guard.
9115         * arch-utils.h: Rename include guard.
9116         * annotate.h: Add include guard.
9117         * amd64-darwin-tdep.h: Rename include guard.
9118         * aarch64-linux-tdep.h: Add include guard.
9119         * aarch64-fbsd-tdep.h: Add include guard.
9120         * aarch32-linux-nat.h: Add include guard.
9121
9122 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9123
9124         * macrotab.c (macro_define_internal): New function that
9125         factorizes macro_define_object_internal and macro_define_function
9126         code.
9127         (macro_define_object_internal): Use macro_define_internal.
9128         (macro_define_function): Likewise.
9129
9130 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9131
9132         * macrocmd.c (extract_identifier): Return
9133         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9134         callers.
9135
9136 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9137
9138         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9139
9140 2019-02-05  Tom Tromey  <tom@tromey.com>
9141
9142         * target.c (target_stack::unpush): Move assertion earlier.
9143
9144 2019-01-30  Tom Tromey  <tom@tromey.com>
9145
9146         PR python/23615:
9147         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9148         (gdbpy_parse_and_eval): Likewise.
9149         * python/python-internal.h (gdbpy_allow_threads): New class.
9150
9151 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9152
9153         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9154         (aarch64_fbsd_fpregmap): Move earlier.
9155         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9156         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9157         instead of individual calls to trad_frame_set_reg_addr.
9158         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9159         earlier.
9160         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9161         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9162         instead of individual calls to trad_frame_set_reg_addr.
9163
9164 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9165
9166         * CONTRIBUTE: Replace contribution list with wiki link.
9167
9168 2019-01-25  Tom Tromey  <tom@tromey.com>
9169
9170         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9171
9172 2019-01-25  Tom Tromey  <tom@tromey.com>
9173
9174         * xtensa-linux-nat.c: Fix common/ includes.
9175         * xml-support.h: Fix common/ includes.
9176         * xml-support.c: Fix common/ includes.
9177         * x86-linux-nat.c: Fix common/ includes.
9178         * windows-nat.c: Fix common/ includes.
9179         * varobj.h: Fix common/ includes.
9180         * varobj.c: Fix common/ includes.
9181         * value.c: Fix common/ includes.
9182         * valops.c: Fix common/ includes.
9183         * utils.c: Fix common/ includes.
9184         * unittests/xml-utils-selftests.c: Fix common/ includes.
9185         * unittests/utils-selftests.c: Fix common/ includes.
9186         * unittests/unpack-selftests.c: Fix common/ includes.
9187         * unittests/tracepoint-selftests.c: Fix common/ includes.
9188         * unittests/style-selftests.c: Fix common/ includes.
9189         * unittests/string_view-selftests.c: Fix common/ includes.
9190         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9191         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9192         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9193         * unittests/rsp-low-selftests.c: Fix common/ includes.
9194         * unittests/parse-connection-spec-selftests.c: Fix common/
9195         includes.
9196         * unittests/optional-selftests.c: Fix common/ includes.
9197         * unittests/offset-type-selftests.c: Fix common/ includes.
9198         * unittests/observable-selftests.c: Fix common/ includes.
9199         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9200         * unittests/memrange-selftests.c: Fix common/ includes.
9201         * unittests/memory-map-selftests.c: Fix common/ includes.
9202         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9203         * unittests/function-view-selftests.c: Fix common/ includes.
9204         * unittests/environ-selftests.c: Fix common/ includes.
9205         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9206         * unittests/common-utils-selftests.c: Fix common/ includes.
9207         * unittests/cli-utils-selftests.c: Fix common/ includes.
9208         * unittests/array-view-selftests.c: Fix common/ includes.
9209         * ui-file.c: Fix common/ includes.
9210         * tui/tui-io.c: Fix common/ includes.
9211         * tracepoint.h: Fix common/ includes.
9212         * tracepoint.c: Fix common/ includes.
9213         * tracefile-tfile.c: Fix common/ includes.
9214         * top.h: Fix common/ includes.
9215         * top.c: Fix common/ includes.
9216         * thread.c: Fix common/ includes.
9217         * target/waitstatus.h: Fix common/ includes.
9218         * target/waitstatus.c: Fix common/ includes.
9219         * target.h: Fix common/ includes.
9220         * target.c: Fix common/ includes.
9221         * target-memory.c: Fix common/ includes.
9222         * target-descriptions.c: Fix common/ includes.
9223         * symtab.h: Fix common/ includes.
9224         * symfile.c: Fix common/ includes.
9225         * stap-probe.c: Fix common/ includes.
9226         * spu-linux-nat.c: Fix common/ includes.
9227         * sparc-nat.c: Fix common/ includes.
9228         * source.c: Fix common/ includes.
9229         * solib.c: Fix common/ includes.
9230         * solib-target.c: Fix common/ includes.
9231         * ser-unix.c: Fix common/ includes.
9232         * ser-tcp.c: Fix common/ includes.
9233         * ser-pipe.c: Fix common/ includes.
9234         * ser-base.c: Fix common/ includes.
9235         * selftest-arch.c: Fix common/ includes.
9236         * s12z-tdep.c: Fix common/ includes.
9237         * rust-exp.y: Fix common/ includes.
9238         * rs6000-aix-tdep.c: Fix common/ includes.
9239         * riscv-tdep.c: Fix common/ includes.
9240         * remote.c: Fix common/ includes.
9241         * remote-notif.h: Fix common/ includes.
9242         * remote-fileio.h: Fix common/ includes.
9243         * remote-fileio.c: Fix common/ includes.
9244         * regcache.h: Fix common/ includes.
9245         * regcache.c: Fix common/ includes.
9246         * record-btrace.c: Fix common/ includes.
9247         * python/python.c: Fix common/ includes.
9248         * python/py-type.c: Fix common/ includes.
9249         * python/py-inferior.c: Fix common/ includes.
9250         * progspace.h: Fix common/ includes.
9251         * producer.c: Fix common/ includes.
9252         * procfs.c: Fix common/ includes.
9253         * proc-api.c: Fix common/ includes.
9254         * printcmd.c: Fix common/ includes.
9255         * ppc-linux-nat.c: Fix common/ includes.
9256         * parser-defs.h: Fix common/ includes.
9257         * osdata.c: Fix common/ includes.
9258         * obsd-nat.c: Fix common/ includes.
9259         * nat/x86-linux.c: Fix common/ includes.
9260         * nat/x86-linux-dregs.c: Fix common/ includes.
9261         * nat/x86-dregs.h: Fix common/ includes.
9262         * nat/x86-dregs.c: Fix common/ includes.
9263         * nat/ppc-linux.c: Fix common/ includes.
9264         * nat/mips-linux-watch.h: Fix common/ includes.
9265         * nat/mips-linux-watch.c: Fix common/ includes.
9266         * nat/linux-waitpid.c: Fix common/ includes.
9267         * nat/linux-ptrace.h: Fix common/ includes.
9268         * nat/linux-ptrace.c: Fix common/ includes.
9269         * nat/linux-procfs.c: Fix common/ includes.
9270         * nat/linux-personality.c: Fix common/ includes.
9271         * nat/linux-osdata.c: Fix common/ includes.
9272         * nat/linux-namespaces.c: Fix common/ includes.
9273         * nat/linux-btrace.h: Fix common/ includes.
9274         * nat/linux-btrace.c: Fix common/ includes.
9275         * nat/fork-inferior.c: Fix common/ includes.
9276         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9277         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9278         * nat/aarch64-linux.c: Fix common/ includes.
9279         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9280         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9281         * namespace.h: Fix common/ includes.
9282         * mips-linux-tdep.c: Fix common/ includes.
9283         * minsyms.c: Fix common/ includes.
9284         * mi/mi-parse.h: Fix common/ includes.
9285         * mi/mi-main.c: Fix common/ includes.
9286         * mi/mi-cmd-env.c: Fix common/ includes.
9287         * memrange.h: Fix common/ includes.
9288         * memattr.c: Fix common/ includes.
9289         * maint.h: Fix common/ includes.
9290         * maint.c: Fix common/ includes.
9291         * main.c: Fix common/ includes.
9292         * machoread.c: Fix common/ includes.
9293         * location.c: Fix common/ includes.
9294         * linux-thread-db.c: Fix common/ includes.
9295         * linux-nat.c: Fix common/ includes.
9296         * linux-fork.c: Fix common/ includes.
9297         * inline-frame.c: Fix common/ includes.
9298         * infrun.c: Fix common/ includes.
9299         * inflow.c: Fix common/ includes.
9300         * inferior.h: Fix common/ includes.
9301         * inferior.c: Fix common/ includes.
9302         * infcmd.c: Fix common/ includes.
9303         * inf-ptrace.c: Fix common/ includes.
9304         * inf-child.c: Fix common/ includes.
9305         * ia64-linux-nat.c: Fix common/ includes.
9306         * i387-tdep.c: Fix common/ includes.
9307         * i386-tdep.c: Fix common/ includes.
9308         * i386-linux-tdep.c: Fix common/ includes.
9309         * i386-linux-nat.c: Fix common/ includes.
9310         * i386-go32-tdep.c: Fix common/ includes.
9311         * i386-fbsd-tdep.c: Fix common/ includes.
9312         * i386-fbsd-nat.c: Fix common/ includes.
9313         * guile/scm-type.c: Fix common/ includes.
9314         * guile/guile.c: Fix common/ includes.
9315         * go32-nat.c: Fix common/ includes.
9316         * gnu-nat.c: Fix common/ includes.
9317         * gdbthread.h: Fix common/ includes.
9318         * gdbarch-selftests.c: Fix common/ includes.
9319         * gdb_usleep.c: Fix common/ includes.
9320         * gdb_select.h: Fix common/ includes.
9321         * gdb_bfd.c: Fix common/ includes.
9322         * gcore.c: Fix common/ includes.
9323         * fork-child.c: Fix common/ includes.
9324         * findvar.c: Fix common/ includes.
9325         * fbsd-nat.c: Fix common/ includes.
9326         * event-top.c: Fix common/ includes.
9327         * event-loop.c: Fix common/ includes.
9328         * dwarf2read.c: Fix common/ includes.
9329         * dwarf2loc.c: Fix common/ includes.
9330         * dwarf2-frame.c: Fix common/ includes.
9331         * dwarf-index-cache.c: Fix common/ includes.
9332         * dtrace-probe.c: Fix common/ includes.
9333         * disasm-selftests.c: Fix common/ includes.
9334         * defs.h: Fix common/ includes.
9335         * csky-tdep.c: Fix common/ includes.
9336         * cp-valprint.c: Fix common/ includes.
9337         * cp-support.h: Fix common/ includes.
9338         * cp-support.c: Fix common/ includes.
9339         * corelow.c: Fix common/ includes.
9340         * completer.h: Fix common/ includes.
9341         * completer.c: Fix common/ includes.
9342         * compile/compile.c: Fix common/ includes.
9343         * compile/compile-loc2c.c: Fix common/ includes.
9344         * compile/compile-cplus-types.c: Fix common/ includes.
9345         * compile/compile-cplus-symbols.c: Fix common/ includes.
9346         * command.h: Fix common/ includes.
9347         * cli/cli-dump.c: Fix common/ includes.
9348         * cli/cli-cmds.c: Fix common/ includes.
9349         * charset.c: Fix common/ includes.
9350         * build-id.c: Fix common/ includes.
9351         * btrace.h: Fix common/ includes.
9352         * btrace.c: Fix common/ includes.
9353         * breakpoint.h: Fix common/ includes.
9354         * breakpoint.c: Fix common/ includes.
9355         * ax.h:
9356         (enum agent_op): Fix common/ includes.
9357         * ax-general.c (struct aop_map): Fix common/ includes.
9358         * ax-gdb.c: Fix common/ includes.
9359         * auxv.c: Fix common/ includes.
9360         * auto-load.c: Fix common/ includes.
9361         * arm-tdep.c: Fix common/ includes.
9362         * arch/riscv.c: Fix common/ includes.
9363         * arch/ppc-linux-common.c: Fix common/ includes.
9364         * arch/i386.c: Fix common/ includes.
9365         * arch/arm.c: Fix common/ includes.
9366         * arch/arm-linux.c: Fix common/ includes.
9367         * arch/arm-get-next-pcs.c: Fix common/ includes.
9368         * arch/amd64.c: Fix common/ includes.
9369         * arch/aarch64.c: Fix common/ includes.
9370         * arch/aarch64-insn.c: Fix common/ includes.
9371         * arch-utils.c: Fix common/ includes.
9372         * amd64-windows-tdep.c: Fix common/ includes.
9373         * amd64-tdep.c: Fix common/ includes.
9374         * amd64-sol2-tdep.c: Fix common/ includes.
9375         * amd64-obsd-tdep.c: Fix common/ includes.
9376         * amd64-nbsd-tdep.c: Fix common/ includes.
9377         * amd64-linux-tdep.c: Fix common/ includes.
9378         * amd64-linux-nat.c: Fix common/ includes.
9379         * amd64-fbsd-tdep.c: Fix common/ includes.
9380         * amd64-fbsd-nat.c: Fix common/ includes.
9381         * amd64-dicos-tdep.c: Fix common/ includes.
9382         * amd64-darwin-tdep.c: Fix common/ includes.
9383         * agent.c: Fix common/ includes.
9384         * ada-lang.h: Fix common/ includes.
9385         * ada-lang.c: Fix common/ includes.
9386         * aarch64-tdep.c: Fix common/ includes.
9387
9388 2019-01-25  Tom Tromey  <tom@tromey.com>
9389
9390         * common/create-version.sh: Use common/version.h.
9391
9392 2019-01-24  Pedro Alves  <palves@redhat.com>
9393
9394         * infrun.c (signal_stop, signal_print, signal_program)
9395         (signal_catch, signal_pass): Now arrays instead of pointers.
9396         (update_signals_program_target, do_target_resume)
9397         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9398         * linux-nat.c (linux_nat_target::pass_signals)
9399         (linux_nat_target::create_inferior, linux_nat_target::attach):
9400         Adjust.
9401         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9402         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9403         * procfs.c (procfs_target::pass_signals): Adjust.
9404         * record-full.c (record_full_target::resume): Adjust.
9405         * remote.c (remote_target::pass_signals)
9406         (remote_target::program_signals): Adjust.
9407         * target-debug.h (target_debug_print_signals): Now takes a
9408         gdb::array_view as parameter.  Adjust.
9409         * target.h (target_ops) <pass_signals, program_signals>: Replace
9410         pointer and length parameters with gdb::array_view.
9411         (target_pass_signals, target_program_signals): Likewise.
9412         * target-delegates.c: Regenerate.
9413
9414 2019-01-24  Pedro Alves  <palves@redhat.com>
9415
9416         * common/forward-scope-exit.h
9417         (forward_scope_exit::forward_scope_exit): Pass arguments to
9418         m_bind_function directly, instead of creating a std::bind and
9419         copying that.
9420
9421 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9422
9423         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9424         for static members.
9425         (pass_in_v_vfp_candidate): Likewise.
9426
9427 2019-01-23  Tom Tromey  <tom@tromey.com>
9428             Pedro Alves  <palves@redhat.com>
9429
9430         * regcache.c (class regcache_invalidator): Remove.
9431         (regcache::raw_write): Use make_scope_exit.
9432
9433 2019-01-23  Tom Tromey  <tom@tromey.com>
9434
9435         * ui-out.h (class ui_out_emit_type): Update comment.
9436
9437 2019-01-23  Tom Tromey  <tom@tromey.com>
9438
9439         * infrun.c (fetch_inferior_event): Update comment.
9440
9441 2019-01-23  Tom Tromey  <tom@tromey.com>
9442             Pedro Alves  <palves@redhat.com>
9443
9444         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9445         parameter.
9446         (fetch_inferior_event): Use SCOPE_EXIT.
9447
9448
9449 2019-01-23  Tom Tromey  <tom@tromey.com>
9450             Pedro Alves  <palves@redhat.com>
9451
9452         * infrun.c (disable_thread_events): Delete.
9453         (stop_all_threads): Use SCOPE_EXIT.
9454
9455 2019-01-23  Tom Tromey  <tom@tromey.com>
9456             Pedro Alves  <palves@redhat.com>
9457
9458         * symfile.c: Include forward-scope-exit.h.
9459         (clear_symtab_users_cleanup): Replace forward declaration with
9460         a FORWARD_SCOPE_EXIT.
9461         (syms_from_objfile_1): Use the forward_scope_exit and
9462         gdb::optional instead of cleanup_function.
9463         (reread_symbols): Use the forward_scope_exit instead of
9464         cleanup_function.
9465         (clear_symtab_users_cleanup): Remove function.
9466
9467 2019-01-23  Tom Tromey  <tom@tromey.com>
9468             Pedro Alves  <palves@redhat.com>
9469
9470         * linux-nat.c: Include scope-exit.h.
9471         (cleanup_target_stop): Remove.
9472         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9473         SCOPE_EXIT.
9474
9475 2019-01-23  Tom Tromey  <tom@tromey.com>
9476             Pedro Alves  <palves@redhat.com>
9477
9478         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9479         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9480
9481 2019-01-23  Tom Tromey  <tom@tromey.com>
9482             Andrew Burgess  <andrew.burgess@embecosm.com>
9483             Pedro Alves  <palves@redhat.com>
9484
9485         * infrun.c (fetch_inferior_event): Use scope_exit.
9486         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9487         * top.c (execute_command): Use scope_exit.
9488         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9489         * utils.c (do_bpstat_clear_actions_cleanup)
9490         (make_bpstat_clear_actions_cleanup): Remove.
9491
9492 2019-01-23  Tom Tromey  <tom@tromey.com>
9493             Pedro Alves  <palves@redhat.com>
9494
9495         * infrun.c: Include "common/scope-exit.h"
9496         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9497         (wait_for_inferior): Use SCOPE_EXIT.
9498         (fetch_inferior_event): Use scope_exit.
9499
9500 2019-01-23  Tom Tromey  <tom@tromey.com>
9501             Pedro Alves  <palves@redhat.com>
9502
9503         * breakpoint.c (create_breakpoint): Remove cleanup.
9504
9505 2019-01-23  Tom Tromey  <tom@tromey.com>
9506             Andrew Burgess  <andrew.burgess@embecosm.com>
9507             Pedro Alves  <palves@redhat.com>
9508
9509 2019-01-23  Pedro Alves  <palves@redhat.com>
9510
9511         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9512
9513 2019-01-23  Pedro Alves  <palves@redhat.com>
9514             Andrew Burgess  <andrew.burgess@embecosm.com>
9515
9516         * gdbthread.h: Include "common/forward-scope-exit.h".
9517         (scoped_finish_thread_state): Redefine custom class in terms of
9518         forward_scope_exit.
9519
9520 2019-01-23  Pedro Alves  <palves@redhat.com>
9521             Andrew Burgess  <andrew.burgess@embecosm.com>
9522
9523         * common/forward-scope-exit.h: New file.
9524
9525 2019-01-23  Pedro Alves  <palves@redhat.com>
9526             Andrew Burgess  <andrew.burgess@embecosm.com>
9527             Tom Tromey  <tom@tromey.com>
9528
9529         * common/scope-exit.h: New file.
9530
9531 2019-01-23  Pedro Alves  <palves@redhat.com>
9532
9533         * common/preprocessor.h (ESC): Rename to ...
9534         (ESC_PARENS): ... this.
9535         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9536         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9537
9538 2019-01-23  Tom Tromey  <tom@tromey.com>
9539
9540         * language.h (class scoped_switch_to_sym_language_if_auto):
9541         Initialize m_lang in both cases.
9542
9543 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9544
9545         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9546         with XCNEW.
9547
9548 2019-01-22  Tom Tromey  <tom@tromey.com>
9549
9550         * corelow.c: Do not include sys/file.h.
9551
9552 2019-01-22  Tom Tromey  <tom@tromey.com>
9553
9554         * tui/tui-wingeneral.h: Include gdb_curses.h.
9555
9556 2019-01-22  Tom Tromey  <tom@tromey.com>
9557
9558         * source-cache.h (class source_cache) <get_source_lines,
9559         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9560
9561 2019-01-22  Tom Tromey  <tom@tromey.com>
9562
9563         * remote-fileio.h (struct remote_target): Declare.
9564
9565 2019-01-22  Tom Tromey  <tom@tromey.com>
9566
9567         * python/py-arch.c: Do not include py-ref.h.
9568         * python/py-bpevent.c: Do not include py-ref.h.
9569         * python/py-cmd.c: Do not include py-ref.h.
9570         * python/py-continueevent.c: Do not include py-ref.h.
9571         * python/py-event.h: Do not include py-ref.h.
9572         * python/py-evtregistry.c: Do not include py-ref.h.
9573         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9574         * python/py-frame.c: Do not include py-ref.h.
9575         * python/py-framefilter.c: Do not include py-ref.h.
9576         * python/py-function.c: Do not include py-ref.h.
9577         * python/py-infevents.c: Do not include py-ref.h.
9578         * python/py-linetable.c: Do not include py-ref.h.
9579         * python/py-objfile.c: Do not include py-ref.h.
9580         * python/py-param.c: Do not include py-ref.h.
9581         * python/py-prettyprint.c: Do not include py-ref.h.
9582         * python/py-progspace.c: Do not include py-ref.h.
9583         * python/py-symbol.c: Do not include py-ref.h.
9584         * python/py-symtab.c: Do not include py-ref.h.
9585         * python/py-type.c: Do not include py-ref.h.
9586         * python/py-unwind.c: Do not include py-ref.h.
9587         * python/py-utils.c: Do not include py-ref.h.
9588         * python/py-value.c: Do not include py-ref.h.
9589         * python/py-varobj.c: Do not include py-ref.h.
9590         * python/py-xmethods.c: Do not include py-ref.h.
9591         * python/python.c: Do not include py-ref.h.
9592         * varobj.c: Do not include py-ref.h.
9593
9594 2019-01-22  Tom Tromey  <tom@tromey.com>
9595
9596         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9597         keyword for bcache.
9598
9599 2019-01-22  Tom Tromey  <tom@tromey.com>
9600
9601         * compile/compile-cplus-types.c: Remove a comment by #include.
9602
9603 2019-01-22  Tom Tromey  <tom@tromey.com>
9604
9605         * compile/gcc-c-plugin.h: Include compile-internal.h.
9606
9607 2019-01-22  Tom Tromey  <tom@tromey.com>
9608
9609         * stabsread.c (EXTERN): Do not define.
9610         (symnum, next_symbol_text_func, processing_gcc_compilation)
9611         (within_function, global_sym_chain, global_stabs)
9612         (previous_stab_code, this_object_header_files)
9613         (n_this_object_header_files)
9614         (n_allocated_this_object_header_files): Define.
9615         * stabsread.h (EXTERN): Never define.  Use "extern".
9616
9617 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9618
9619         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9620         history_value.
9621
9622 2019-01-21  Tom Tromey  <tom@tromey.com>
9623
9624         * ui-out.c: Fix includes.
9625         * tui/tui-source.c: Fix includes.
9626         * target.c: Fix includes.
9627         * remote.c: Fix includes.
9628         * regcache.c: Fix includes.
9629         * python/py-block.c: Fix includes.
9630         * printcmd.c: Fix includes.
9631         * or1k-tdep.c: Fix includes.
9632         * mi/mi-main.c: Fix includes.
9633         * m32r-tdep.c: Fix includes.
9634         * csky-tdep.c: Fix includes.
9635         * compile/compile-cplus-types.c: Fix includes.
9636         * cli/cli-interp.c: Fix includes.
9637
9638 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9639
9640         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9641         for padding.
9642
9643 2019-01-16  Tom Tromey  <tom@tromey.com>
9644
9645         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9646         earlier.
9647         (struct objfile) <msymbols_range>: Move from top level.
9648         <msymbols>: New method.
9649         (class objfile_msymbols): Remove.
9650         * symtab.c (default_collect_symbol_completion_matches_break_on):
9651         Update.
9652         * symmisc.c (dump_msymbols): Update.
9653         * stabsread.c (scan_file_globals): Update.
9654         * objc-lang.c (info_selectors_command, info_classes_command)
9655         (find_methods): Update.
9656         * minsyms.c (find_solib_trampoline_target): Update.
9657         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9658         * coffread.c (coff_symfile_read): Update.
9659         * ada-lang.c (ada_lookup_simple_minsym)
9660         (ada_collect_symbol_completion_matches): Update.
9661
9662 2019-01-16  Tom Tromey  <tom@tromey.com>
9663
9664         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9665         type.  Remove no-argument constructor.
9666         <iterator::operator++>: Simplify.
9667         <begin>: Update.
9668         <end>: Use minimal_symbol_count.
9669
9670 2019-01-16  Tom Tromey  <tom@tromey.com>
9671
9672         * objfiles.h (struct objfile) <psymtabs>: New method.
9673         (class objfile_psymtabs): Remove.
9674         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9675         typedef.
9676         <range>: New method.
9677         (require_partial_symbols): Change return type.
9678         * psymtab.c (require_partial_symbols)
9679         (psym_expand_symtabs_matching): Update.
9680         * mdebugread.c (parse_partial_symbols): Update.
9681         * dbxread.c (dbx_end_psymtab): Update.
9682
9683 2019-01-15  Tom Tromey  <tom@tromey.com>
9684
9685         * symtab.c (lookup_objfile_from_block)
9686         (lookup_symbol_in_objfile_symtabs)
9687         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9688         (find_line_symtab, info_sources_command)
9689         (default_collect_symbol_completion_matches_break_on)
9690         (make_source_files_completion_list): Update.
9691         * symmisc.c (print_objfile_statistics, dump_objfile)
9692         (maintenance_print_symbols, maintenance_info_symtabs)
9693         (maintenance_check_symtabs, maintenance_info_line_tables):
9694         Update.
9695         * source.c (select_source_symtab)
9696         (forget_cached_source_info_for_objfile): Update.
9697         * objfiles.h (class objfile_compunits): Remove.
9698         (struct objfile) <compunits_range>: New typedef.
9699         (compunits): New method.
9700         * objfiles.c (objfile_relocate1): Update.
9701         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9702         * maint.c (count_symtabs_and_blocks): Update.
9703         * linespec.c (iterate_over_all_matching_symtabs): Update.
9704         * cp-support.c (add_symbol_overload_list_qualified): Update.
9705         * coffread.c (coff_symtab_read): Update.
9706         * ada-lang.c (add_nonlocal_symbols)
9707         (ada_collect_symbol_completion_matches)
9708         (ada_add_global_exceptions): Update.
9709
9710 2019-01-15  Tom Tromey  <tom@tromey.com>
9711
9712         * progspace.h (program_space) <objfiles_safe_range>: New
9713         typedef.
9714         <objfiles_safe>: New method.
9715         * objfiles.h (class all_objfiles_safe): Remove.
9716         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9717         * jit.c (jit_inferior_exit_hook): Update.
9718
9719 2019-01-17  Tom Tromey  <tom@tromey.com>
9720
9721         * progspace.h (program_space) <objfiles_range>: New typedef.
9722         <objfiles>: New method.
9723         <objfiles_head>: Rename from objfiles.
9724         (object_files): Update.
9725         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9726         * guile/scm-pretty-print.c
9727         (ppscm_find_pretty_printer_from_objfiles): Update.
9728         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9729         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9730         Update.
9731         * python/py-progspace.c (pspy_get_objfiles): Update.
9732         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9733         Update.
9734         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9735         (objfpy_lookup_objfile_by_build_id): Update.
9736         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9737         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9738         Update.
9739         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9740         (expand_symtab_containing_pc, lookup_objfile_from_block)
9741         (lookup_static_symbol, basic_lookup_transparent_type)
9742         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9743         (find_line_symtab, info_sources_command)
9744         (default_collect_symbol_completion_matches_break_on)
9745         (make_source_files_completion_list, find_main_name): Update.
9746         * symmisc.c (print_symbol_bcache_statistics)
9747         (print_objfile_statistics, maintenance_print_symbols)
9748         (maintenance_print_msymbols, maintenance_print_objfiles)
9749         (maintenance_info_symtabs, maintenance_check_symtabs)
9750         (maintenance_expand_symtabs, maintenance_info_line_tables):
9751         Update.
9752         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9753         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9754         (map_overlay_command, unmap_overlay_command)
9755         (simple_overlay_update, expand_symtabs_matching)
9756         (map_symbol_filenames): Update.
9757         * symfile-debug.c (set_debug_symfile): Update.
9758         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9759         Update.
9760         * source.c (select_source_symtab, forget_cached_source_info):
9761         Update.
9762         * solib.c (solib_read_symbols): Update.
9763         * solib-spu.c (append_ocl_sos): Update.
9764         * psymtab.c (maintenance_print_psymbols)
9765         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9766         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9767         * printcmd.c (info_symbol_command): Update.
9768         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9769         Update.
9770         * objfiles.h (class all_objfiles): Remove.
9771         * objfiles.c (have_partial_symbols, have_full_symbols)
9772         (have_minimal_symbols, qsort_cmp, update_section_map)
9773         (shared_objfile_contains_address_p)
9774         (default_iterate_over_objfiles_in_search_order): Update.
9775         * objc-lang.c (info_selectors_command, info_classes_command)
9776         (find_methods): Update.
9777         * minsyms.c (find_solib_trampoline_target): Update.
9778         * maint.c (maintenance_info_sections)
9779         (maintenance_translate_address, count_symtabs_and_blocks):
9780         Update.
9781         * main.c (captured_main_1): Update.
9782         * linux-thread-db.c (try_thread_db_load_from_pdir)
9783         (has_libpthread): Update.
9784         * linespec.c (iterate_over_all_matching_symtabs)
9785         (search_minsyms_for_name): Update.
9786         * jit.c (jit_find_objf_with_entry_addr): Update.
9787         * hppa-tdep.c (find_unwind_entry)
9788         (hppa_lookup_stub_minimal_symbol): Update.
9789         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9790         Update.
9791         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9792         (elf_gnu_ifunc_resolve_by_got): Update.
9793         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9794         * dwarf-index-write.c (save_gdb_index_command): Update.
9795         * cp-support.c (add_symbol_overload_list_qualified): Update.
9796         * breakpoint.c (create_overlay_event_breakpoint)
9797         (create_longjmp_master_breakpoint)
9798         (create_std_terminate_master_breakpoint)
9799         (create_exception_master_breakpoint): Update.
9800         * blockframe.c (find_pc_partial_function): Update.
9801         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9802         (ada_collect_symbol_completion_matches)
9803         (ada_add_global_exceptions): Update.
9804
9805 2019-01-17  Tom Tromey  <tom@tromey.com>
9806
9807         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9808         declare VEC.
9809         (solib_target_parse_libraries): Change return type.
9810         (library_list_start_segment, library_list_start_section)
9811         (library_list_end_library, library_list_start_library); Update.
9812         (solib_target_free_library_list): Remove.
9813         (solib_target_parse_libraries): Remove cleanup.  Change return
9814         type.
9815         (solib_target_current_sos): Update.
9816
9817 2019-01-17  Tom Tromey  <tromey@bapiya>
9818
9819         * valprint.c: Replace "the the" with "the".
9820         * symtab.c: Replace "the the" with "the".
9821         * solib.c: Replace "the the" with "the".
9822         * solib-dsbt.c: Replace "the the" with "the".
9823         * linespec.c: Replace "the the" with "the".
9824         * dwarf2loc.h: Replace "the the" with "the".
9825         * amd64-windows-tdep.c: Replace "the the" with "the".
9826         * aarch64-tdep.c: Replace "the the" with "the".
9827
9828 2019-01-16  Keith Seitz  <keiths@redhat.com>
9829
9830         PR gdb/23773
9831         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9832         <builder>: Rename to ..
9833         <m_builder>: ... this and make private.
9834         (dwarf2_cu::get_builder): New method.  Change all users of
9835         `builder' to use this method.
9836         (dwarf2_start_symtab): Move to ...
9837         (dwarf2_cu::start_symtab): ... here.  Update all callers
9838         (setup_type_unit_groups): Move to ...
9839         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9840         callers.
9841         (dwarf2_cu::reset_builder): New method.
9842         (process_full_compunit, process_full_type_unit): Use
9843         dwarf2_cu::reset_builder.
9844         (follow_die_offset): Record the ancestor CU if it is different
9845         from the followed DIE's CU.
9846         (follow_die_sig_1): Likewise.
9847
9848 2019-01-15  Tom Tromey  <tom@tromey.com>
9849
9850         * remote.c (class remote_state) <buf>: Now a char_vector.
9851         <buf_size>: Remove.
9852         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9853         parameter.
9854         (remote_target::getpkt_or_notif_sane_1)
9855         (remote_target::getpkt_sane)
9856         (remote_target::getpkt_or_notif_sane): Likewise.
9857         (class remote_target) <putpkt>: New overload.
9858         (remote_target::read_frame): Change type of "buf_p".  Remove
9859         sizeof_p parameter.
9860         (packet_ok): New overload.
9861         (packet_check_result): New overload.
9862         Update all uses.
9863
9864 2019-01-14  Tom Tromey  <tom@tromey.com>
9865
9866         * remote-notif.c (handle_notification, remote_notif_ack)
9867         (remote_notif_parse): Make "buf" const.
9868         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9869         const.
9870         (remote_notif_parse, remote_notif_ack, handle_notification):
9871         Likewise.
9872         * remote.c (remote_notif_stop_parse): Make "buf" const.
9873         (remote_target::remote_parse_stop_reply): Make "buf" const.
9874         (remote_notif_stop_ack): Make "buf" const.
9875
9876 2019-01-14  Tom Tromey  <tom@tromey.com>
9877
9878         * remote.c (remote_console_output): Make parameter const.
9879
9880 2019-01-14  Tom Tromey  <tom@tromey.com>
9881
9882         * target-debug.h (target_debug_print_signals): Constify.
9883         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9884         * procfs.c (procfs_target::pass_signals): Update.
9885         * linux-nat.c (linux_nat_target::pass_signals): Update.
9886         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9887         * target-delegates.c: Rebuild.
9888         * remote.c (remote_target::program_signals): Update.
9889         (remote_target::pass_signals): Update.
9890         * target.c (target_pass_signals): Constify argument.
9891         (target_program_signals): Likewise.
9892         * target.h (struct target_ops) <pass_signals, program_signals>:
9893         Constify argument.
9894         (target_pass_signals, target_program_signals): Constify argument.
9895
9896 2019-01-14  Tom Tromey  <tom@tromey.com>
9897
9898         PR tui/28819:
9899         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9900
9901 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9902
9903         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9904         field.
9905         * rs6000-tdep.c: Include reggroups.h.
9906         (IS_V_ALIAS_PSEUDOREG): Define.
9907         (rs6000_register_name): Return names for the "vX" aliases.
9908         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9909         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9910         aliases.  Call default_register_reggroup_p for all other
9911         pseudo-registers.
9912         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9913         New functions.
9914         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9915         Handle "vX" aliases.
9916         (v_alias_pseudo_register_collect): New function.
9917         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9918         (rs6000_gdbarch_init): Initialize "vX" aliases as
9919         pseudo-registers.  Restore registration of
9920         rs6000_pseudo_register_reggroup_p with
9921         set_tdesc_pseudo_register_reggroup_p.
9922
9923 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9924
9925         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9926         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9927         set_gdbarch_num_pseudo_regs.
9928
9929 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9930
9931         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9932         Remove arg prefixname, add do_set and do_show.
9933         Add member functions set_list and show_list.
9934         * cli/cli-style.c (class cli_style_option): Update accordingly.
9935         (style_set_list): Move to file scope.
9936         (style_show_list): Likewise.
9937         (set_style): Call help_list.
9938         (show_style): Call cmd_show_list.
9939         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9940         Update to use the new macro.
9941
9942 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9943
9944         * ada-lang.c (_initialize_ada_language): Expand the help text
9945         for the "catch exception" command.
9946
9947 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9948
9949         * symtab.c (matching_obj_sections): Initialize obj,
9950         declare it closer to its usage.
9951
9952 2019-01-10  Tom Tromey  <tom@tromey.com>
9953
9954         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9955         (basic_inf_threads_range): Remove.
9956         (inf_threads_range, inf_non_exited_threads_range)
9957         (safe_inf_threads_range): Use next_adapter.
9958
9959 2019-01-10  Keith Seitz  <keiths@redhat.com>
9960
9961         PR gdb/23712
9962         PR symtab/23010
9963         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9964         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9965
9966 2019-01-10  Keith Seitz  <keiths@redhat.com>
9967
9968         PR gdb/23712
9969         PR symtab/23010
9970         * dictionary.c (pending_to_vector): Remove.
9971         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9972         Remove _1 suffix, replacing functions of the same name.  Update
9973         all callers.
9974         (dict_create_hashed, dict_create_hashed_expandable)
9975         (dict_create_linear, dict_create_linear_expandable, dict_free)
9976         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9977         Make functions static.
9978
9979 2019-01-10  Keith Seitz  <keiths@redhat.com>
9980
9981         PR gdb/23712
9982         PR symtab/23010
9983         * dictionary.h (struct dictionary): Replace declaration with
9984         multidictionary.
9985         (dict_create_hashed, dict_create_hashed_expandable)
9986         (dict_create_linear, dict_create_linear_expandable)
9987         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9988         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9989         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9990         taking multidictionary argument.
9991         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9992         * block.h (struct block) <dict>: Change to multidictionary
9993         and rename `multidict'.
9994         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9995         symmisc.c: Update all dictionary references to multidictionary.
9996
9997 2019-01-10  Keith Seitz  <keiths@redhat.com>
9998
9999         PR gdb/23712
10000         PR symtab/23010
10001         * dictionary.c: Include unordered_map.
10002         (pending_to_vector): New function.
10003         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10004         Rewrite the non-"_1" functions to take vector instead
10005         of linked list.
10006         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10007         "new" _1 versions of the same name.
10008         (multidictionary): Define.
10009         (std::hash<enum language): New definition.
10010         (collate_pending_symbols_by_language, mdict_create_hashed)
10011         (mdict_create_hashed_expandable, mdict_create_linear)
10012         (mdict_create_linear_expandable, mdict_free)
10013         (find_language_dictionary, create_new_language_dictionary)
10014         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10015         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10016         (mdict_size, mdict_empty): New functions.
10017         * dictionary.h (mdict_iterator): Define.
10018
10019 2019-01-10  Pedro Alves  <palves@redhat.com>
10020
10021         * breakpoint.c (read_uploaded_action)
10022         (create_tracepoint_from_upload): Adjust to use
10023         gdb::unique_xmalloc_ptr.
10024         * ctf.c (ctf_write_uploaded_tp):
10025         (SET_ARRAY_FIELD): Use emplace_back.
10026         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10027         * tracefile-tfile.c (tfile_write_uploaded_tp):
10028         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10029         gdb::unique_xmalloc_ptr.
10030         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10031         at_string, cond_string, cmd_strings>: Replace char pointers
10032         with gdb::unique_xmalloc_ptr.
10033
10034 2019-01-10  Pedro Alves  <palves@redhat.com>
10035
10036         * solib-target.c (library_list_start_library): Don't xstrdup name.
10037
10038 2019-01-10  Pedro Alves  <palves@redhat.com>
10039
10040         * mdebugread.c (parse_partial_symbols): Use
10041         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10042
10043 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10044
10045         * linux-fork.c (scoped_switch_fork_info)
10046         <~scoped_switch_fork_info>: Fix incorrect variable name.
10047
10048 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10049
10050         * linux-fork.c (scoped_switch_fork_info)
10051         <scoped_switch_fork_info>: Make explicit.
10052         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10053
10054 2019-01-10  Tom Tromey  <tom@tromey.com>
10055
10056         * objfiles.h (objfile::reset_psymtabs): Update.
10057         * objfiles.c (objfile::objfile): Update.
10058         * psymtab.h (psymtab_storage::obstack): Update.
10059         (psymtab_storage::m_obstack): Use gdb::optional.
10060         (class psymtab_storage): Update comment.  Remove objfile
10061         parameter.
10062         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10063
10064 2019-01-10  Tom Tromey  <tom@tromey.com>
10065
10066         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10067         <free_psymtabs>: Now private.
10068         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10069         (allocate_psymtab): Use new method.
10070
10071 2019-01-10  Tom Tromey  <tom@tromey.com>
10072
10073         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10074         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10075         * mdebugread.c (parse_partial_symbols): Use
10076         allocate_dependencies.
10077         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10078         allocate_dependencies.
10079         (process_psymtab_comp_unit_reader)
10080         (build_type_psymtab_dependencies): Likewise.
10081         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10082
10083 2019-01-10  Tom Tromey  <tom@tromey.com>
10084
10085         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10086         PSYMBOL_SET_LANGUAGE.
10087         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10088
10089 2019-01-10  Tom Tromey  <tom@tromey.com>
10090
10091         * psymtab.h (psymtab_storage::obstack): New method.
10092         <m_obstack>: Rename from obstack; now private.
10093         * psymtab.c (psymtab_storage): Update.
10094         * dwarf2read.c (create_addrmap_from_index)
10095         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10096         Update.
10097
10098 2019-01-10  Tom Tromey  <tom@tromey.com>
10099
10100         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10101         * objfiles.h (objfile::reset_psymtabs): New method.
10102
10103 2019-01-10  Tom Tromey  <tom@tromey.com>
10104
10105         * symmisc.c (print_symbol_bcache_statistics): Update.
10106         (print_objfile_statistics): Update.
10107         * symfile.c (reread_symbols): Update.
10108         * psymtab.h (class psymtab_storage): New.
10109         * psymtab.c (psymtab_storage): New constructor.
10110         (~psymtab_storage): New destructor.
10111         (require_partial_symbols): Update.
10112         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10113         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10114         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10115         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10116         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10117         (start_psymtab_common, end_psymtab_common)
10118         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10119         (allocate_psymtab): Update.
10120         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10121         Update.
10122         (dump_psymtab_addrmap, maintenance_print_psymbols)
10123         (maintenance_check_psymtabs): Update.
10124         (class objfile_psymtabs): Move to objfiles.h.
10125         * psympriv.h (discard_psymtab): Now inline.
10126         (psymtab_discarder::psymtab_discarder): Update.
10127         (psymtab_discarder::~psymtab_discarder): Update.
10128         (ALL_OBJFILE_PSYMTABS): Rewrite.
10129         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10130         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10131         Remove fields.
10132         <partial_symtabs>: New field.
10133         (class objfile_psymtabs): Move from psymtab.h.  Update.
10134         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10135         psymbol_cache.
10136         (objfile::~objfile): Don't destroy psymbol_cache.
10137         * mdebugread.c (parse_partial_symbols): Update.
10138         * dwarf2read.c (create_addrmap_from_index)
10139         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10140         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10141         (add_partial_subprogram, dwarf2_ranges_read): Update.
10142         * dwarf-index-write.c (write_address_map)
10143         (write_one_signatured_type, recursively_write_psymbols)
10144         (class debug_names, class debug_names, write_psymtabs_to_index):
10145         Update.
10146
10147 2019-01-10  Tom Tromey  <tom@tromey.com>
10148
10149         * symtab.h (SYMBOL_SET_NAMES): Update.
10150         (symbol_set_names): Update.
10151         (MSYMBOL_SET_NAMES): Update.
10152         * symtab.c (symbol_set_names): Change argument to be an
10153         objfile_per_bfd_storage.
10154         * psymtab.c (add_psymbol_to_bcache): Update.
10155         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10156
10157 2019-01-10  Tom Tromey  <tom@tromey.com>
10158
10159         * symtab.c (create_demangled_names_hash): Change argument to be an
10160         objfile_per_bfd_storage.
10161         (symbol_set_names): Update.
10162
10163 2019-01-10  Tom Tromey  <tom@tromey.com>
10164
10165         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10166         init_psymbol_list.
10167         * psymtab.c (init_psymbol_list): Do nothing if already called.
10168         * psympriv.h (init_psymbol_list): Add comment.
10169         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10170         init_psymbol_list.
10171         * dbxread.c (dbx_symfile_read): Unconditionally call
10172         init_psymbol_list.
10173
10174 2019-01-10  Tom Tromey  <tom@tromey.com>
10175
10176         * xcoffread.c (scan_xcoff_symtab): Update.
10177         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10178         "where".
10179         * mdebugread.c (parse_partial_symbols)
10180         (handle_psymbol_enumerators): Update.
10181         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10182         * dbxread.c (read_dbx_symtab): Update.
10183         * psympriv.h (psymbol_placement): New enum.
10184         (add_psymbol_to_list): Update.
10185
10186 2019-01-10  Tom Tromey  <tom@tromey.com>
10187
10188         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10189         static_psymbols parameters.
10190         (scan_xcoff_symtab): Update.
10191         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10192         static_psymbols parameters.
10193         * psympriv.h (start_psymtab_common): Update.
10194         * mdebugread.c (parse_partial_symbols): Update.
10195         * dwarf2read.c (create_partial_symtab): Update.
10196         * dbxread.c (read_dbx_symtab): Update.
10197         (start_psymtab): Remove global_psymbols and static_psymbols
10198         parameters.
10199
10200 2019-01-10  Tom Tromey  <tom@tromey.com>
10201
10202         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10203         * psymtab.c (allocate_psymtab): Add comment.
10204         * psympriv.h (allocate_psymtab): Add comment.
10205         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10206         initializations.
10207         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10208
10209 2019-01-10  Tom Tromey  <tom@tromey.com>
10210
10211         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10212         Don't declare.
10213         * mipsread.c: Include mdebugread.h.
10214         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10215         Declare.
10216         * elfread.c: Include mdebugread.h.
10217
10218 2019-01-09  Tom Tromey  <tom@tromey.com>
10219
10220         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10221         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10222         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10223         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10224         (psym_lookup_symbol, psym_find_last_source_symtab)
10225         (psym_forget_cached_source_info, psym_print_stats)
10226         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10227         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10228         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10229         (psym_find_compunit_symtab_by_address)
10230         (maintenance_print_psymbols, maintenance_info_psymtabs)
10231         (maintenance_check_psymtabs): Use ranged for.
10232         * psymtab.h (class objfile_psymtabs): New.
10233         (require_partial_symbols): Return objfile_psymtabs.
10234         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10235
10236 2019-01-09  Tom Tromey  <tom@tromey.com>
10237
10238         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10239         (find_pc_mapped_section, list_overlays_command)
10240         (map_overlay_command, unmap_overlay_command)
10241         (simple_overlay_update): Use all_objfiles.
10242         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10243         * printcmd.c (info_symbol_command): Use all_objfiles.
10244         * objfiles.h (ALL_OBJSECTIONS): Remove.
10245         * maint.c (maintenance_translate_address): Use all_objfiles.
10246         * gcore.c (gcore_create_callback): Use all_objfiles.
10247         (objfile_find_memory_regions): Likewise.
10248
10249 2019-01-09  Tom Tromey  <tom@tromey.com>
10250
10251         * symtab.c (find_line_symtab, info_sources_command)
10252         (make_source_files_completion_list): Use objfile_compunits.
10253         * source.c (select_source_symtab): Use objfile_compunits.
10254         * objfiles.h (struct objfile): Update comment.
10255         (ALL_OBJFILES): Remove.
10256         (ALL_FILETABS): Remove.
10257         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10258         objfile_compunits.
10259
10260 2019-01-09  Tom Tromey  <tom@tromey.com>
10261
10262         * symmisc.c (print_objfile_statistics, dump_objfile)
10263         (maintenance_print_symbols): Use compunit_filetabs.
10264         * source.c (forget_cached_source_info_for_objfile): Use
10265         compunit_filetabs.
10266         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10267         (ALL_FILETABS): Use compunit_filetabs.
10268         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10269         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10270
10271 2019-01-09  Tom Tromey  <tom@tromey.com>
10272
10273         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10274         (compunit_filetabs): New.
10275         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10276         compunit_filetabs.
10277         (info_sources_command, make_source_files_completion_list): Remove
10278         declaration.
10279         * symmisc.c (print_objfile_statistics, dump_objfile)
10280         (maintenance_print_symbols): Remove declaration.
10281         (maintenance_info_symtabs): Use compunit_filetabs.
10282         (maintenance_info_line_tables): Likewise.
10283         * source.c (select_source_symtab): Change local variable name.
10284         (forget_cached_source_info_for_objfile): Remove declaration.
10285         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10286         * objfiles.c (objfile_relocate1): Remove declaration.
10287         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10288         declaration.
10289         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10290         * coffread.c (coff_symtab_read): Remove declaration.
10291         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10292         compunit_filetabs.
10293
10294 2019-01-09  Tom Tromey  <tom@tromey.com>
10295
10296         * symtab.c (lookup_objfile_from_block)
10297         (find_pc_sect_compunit_symtab, search_symbols)
10298         (default_collect_symbol_completion_matches_break_on): Use
10299         objfile_compunits.
10300         * objfiles.h (ALL_COMPUNITS): Remove.
10301         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10302         * cp-support.c (add_symbol_overload_list_qualified): Use
10303         objfile_compunits.
10304         * ada-lang.c (ada_collect_symbol_completion_matches)
10305         (ada_add_global_exceptions): Use objfile_compunits.
10306
10307 2019-01-09  Tom Tromey  <tom@tromey.com>
10308
10309         * source.c (select_source_symtab)
10310         (forget_cached_source_info_for_objfile): Remove declaration.
10311         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10312         declaration.
10313         * maint.c (count_symtabs_and_blocks): Remove declaration.
10314         * cp-support.c (add_symbol_overload_list_qualified): Remove
10315         declaration.
10316         * coffread.c (coff_symtab_read): Remove declaration.
10317         * symtab.c (lookup_symbol_in_objfile_symtabs)
10318         (basic_lookup_transparent_type_1): Use objfile_compunits.
10319         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10320         (info_sources_command, search_symbols)
10321         (default_collect_symbol_completion_matches_break_on)
10322         (make_source_files_completion_list): Remove declaration.
10323         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10324         (ada_collect_symbol_completion_matches)
10325         (ada_add_global_exceptions): Remove declaration.
10326         * linespec.c (iterate_over_all_matching_symtabs): Use
10327         objfile_compunits.
10328         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10329         (class objfile_compunits): New.
10330         (ALL_COMPUNITS): Use objfile_compunits.
10331         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10332         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10333         objfile_compunits.
10334         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10335
10336 2019-01-09  Tom Tromey  <tom@tromey.com>
10337
10338         * symtab.c (search_symbols)
10339         (default_collect_symbol_completion_matches_break_on): Use
10340         objfile_msymbols.
10341         * ada-lang.c (ada_lookup_simple_minsym)
10342         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10343         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10344         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10345         objfile_msymbols.
10346         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10347         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10348         * objc-lang.c (find_methods): Use objfile_msymbols.
10349         (info_selectors_command, info_classes_command): Likewise.
10350         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10351         * objfiles.h (class objfile_msymbols): New.
10352         (ALL_OBJFILE_MSYMBOLS): Remove.
10353         (ALL_MSYMBOLS): Remove.
10354
10355 2019-01-09  Tom Tromey  <tom@tromey.com>
10356
10357         * common/next-iterator.h (next_adapter): Add Iterator template
10358         parameter.
10359         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10360         (class all_objfiles_safe): New.
10361         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10362         * objfiles.c (put_objfile_before): Update comment.
10363         (add_separate_debug_objfile): Likewise.
10364         (free_all_objfiles): Use all_objfiles_safe.
10365         (objfile_purge_solibs): Likewise.
10366
10367 2019-01-09  Tom Tromey  <tom@tromey.com>
10368
10369         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10370         (expand_symtab_containing_pc, lookup_static_symbol)
10371         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10372         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10373         all_objfiles.
10374         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10375         * breakpoint.c (create_overlay_event_breakpoint)
10376         (create_longjmp_master_breakpoint)
10377         (create_std_terminate_master_breakpoint)
10378         (create_exception_master_breakpoint): Use all_objfiles.
10379         * linux-thread-db.c (try_thread_db_load_from_pdir)
10380         (has_libpthread): Use all_objfiles.
10381         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10382         * linespec.c (iterate_over_all_matching_symtabs)
10383         (search_minsyms_for_name): Use all_objfiles.
10384         * maint.c (maintenance_info_sections): Use all_objfiles.
10385         * main.c (captured_main_1): Use all_objfiles.
10386         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10387         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10388         * guile/scm-pretty-print.c
10389         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10390         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10391         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10392         (maintenance_print_msymbols): Use all_objfiles.
10393         * source.c (select_source_symtab): Use all_objfiles.
10394         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10395         * symfile.c (remove_symbol_file_command)
10396         (expand_symtabs_matching, map_symbol_filenames): Use
10397         all_objfiles.
10398         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10399         all_objfiles.
10400         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10401         * objc-lang.c (find_methods): Use all_objfiles.
10402         * objfiles.c (have_partial_symbols, have_full_symbols)
10403         (have_minimal_symbols, qsort_cmp)
10404         (default_iterate_over_objfiles_in_search_order): Use
10405         all_objfiles.
10406         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10407         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10408         (maintenance_check_psymtabs): Use all_objfiles.
10409         (ALL_PSYMTABS): Remove.
10410         * compile/compile-object-run.c (do_module_cleanup): Use
10411         all_objfiles.
10412         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10413         * cp-support.c (add_symbol_overload_list_qualified): Use
10414         all_objfiles.
10415         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10416         Use all_objfiles.
10417         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10418         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10419         all_objfiles.
10420         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10421         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10422         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10423         Uses all_objfiles.
10424         * solib.c (solib_read_symbols): Use all_objfiles
10425
10426 2019-01-09  Tom Tromey  <tom@tromey.com>
10427
10428         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10429         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10430         all_objfiles.
10431         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10432         * symmisc.c (print_symbol_bcache_statistics)
10433         (print_objfile_statistics, maintenance_print_objfiles)
10434         (maintenance_info_symtabs, maintenance_check_symtabs)
10435         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10436         all_objfiles.
10437         * source.c (forget_cached_source_info): Use all_objfiles.
10438         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10439         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10440         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10441         * objfiles.c (update_section_map): Use all_objfiles.
10442         (shared_objfile_contains_address_p): Likewise.
10443         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10444         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10445
10446 2019-01-09  Tom Tromey  <tom@tromey.com>
10447
10448         * common/next-iterator.h: New file.
10449         * objfiles.h (class all_objfiles): New.
10450         (struct objfile_iterator): New.
10451
10452 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10453
10454         * NEWS: Move the description of the changed "frame", "select-frame",
10455          and "info frame" commands to the Changed commands section.
10456
10457 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10458
10459         * gdbtypes.c (check_stub_method_group): Remove handling of old
10460         mangling schemes.
10461         * linespec.c (find_methods): Likewise.
10462         * stabsread.c (read_member_functions): Likewise.
10463         * valops.c (search_struct_method): Likewise.
10464         (value_struct_elt_for_reference): Likewise.
10465         * NEWS: Mention this change.
10466
10467 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10468
10469         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10470         print_source_lines.
10471         * source.c (print_source_lines_base): Update line number check.
10472         (print_source_lines): New function.
10473         (source_lines_range::source_lines_range): New function.
10474         * source.h (class source_lines_range): New class.
10475         (print_source_lines): New declaration.
10476
10477 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10478
10479         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10480
10481 2019-01-08  Tom Tromey  <tom@tromey.com>
10482             Simon Marchi  <simon.marchi@ericsson.com>
10483
10484         PR gdb/24060
10485         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10486         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10487         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10488         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10489         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10490         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10491
10492 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10493
10494         * source.c (select_source_symtab): Move header comment to
10495         declaration in source.h.
10496         (forget_cached_source_info_for_objfile): Likewise.
10497         (forget_cached_source_info): Likewise.
10498         (identify_source_line): Likewise.
10499         * source.h (identify_source_line): Move declaration from symtab.h
10500         and add comment from source.c
10501         (print_source_lines): Likewise.
10502         (forget_cached_source_info_for_objfile): Likewise.
10503         (forget_cached_source_info): Likewise.
10504         (select_source_symtab): Likewise.
10505         (enum print_source_lines_flag): Move definition from symtab.h.
10506         * symtab.h (identify_source_line): Move declaration to source.h.
10507         (print_source_lines): Likewise.
10508         (forget_cached_source_info_for_objfile): Likewise.
10509         (forget_cached_source_info): Likewise.
10510         (select_source_symtab): Likewise.
10511         (enum print_source_lines_flag): Move definition to source.h.
10512         * tui/tui-hooks.c: Add 'source.h' include.
10513
10514 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10515
10516         * source.c (print_source_lines_base): Handle requests to print
10517         reverse line number sequences, and guard against empty lines
10518         string.
10519
10520 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10521
10522         * source.c (print_source_lines_base): Fix skip of '\r' if next
10523         character is '\n'.
10524
10525 2019-01-06  Tom Tromey  <tom@tromey.com>
10526
10527         * c-exp.y (struct c_parse_state) <macro_original_text,
10528         expansion_obstack>: New member.
10529         (macro_original_text, expansion_obstack): Remove globals.
10530         (scan_macro_expansion, scanning_macro_expansion)
10531         (finished_macro_expansion): Update.
10532         (scan_macro_cleanup): Remove.
10533         (yylex, c_parse): Update.
10534
10535 2019-01-06  Tom Tromey  <tom@tromey.com>
10536
10537         * c-exp.y (struct c_parse_state) <strings>: New member.
10538         (operator_stoken): Update.
10539
10540 2019-01-06  Tom Tromey  <tom@tromey.com>
10541
10542         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10543         (union type_stack_elt) <typelist_val>: Now a pointer to
10544         std::vector.
10545         (type_stack_cleanup): Don't declare.
10546         (push_typelist): Update.
10547         * parse.c (pop_typelist): Return a std::vector.
10548         (push_typelist): Take a std::vector.
10549         (follow_types): Update.  Do not free args.
10550         (type_stack_cleanup): Remove.
10551         * c-exp.y (struct c_parse_state): New.
10552         (cpstate): New global.
10553         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10554         (nonempty_typelist): Update.
10555         (func_mod): Create a new vector.
10556         (c_parse): Create a c_parse_state.
10557         (check_parameter_typelist): Do not delete params.
10558         (function_method): Update.  Do not delete type_list.
10559
10560 2019-01-06  Tom Tromey  <tom@tromey.com>
10561
10562         PR gdb/28155:
10563         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10564         check_typedef.
10565         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10566         (print_return_value): Likewise.
10567
10568 2019-01-05  Tom Tromey  <tom@tromey.com>
10569
10570         * contrib/cleanup_check.py: Remove.
10571         * contrib/gcc-with-excheck: Remove.
10572         * contrib/exsummary.py: Remove.
10573         * contrib/excheck.py: Remove.
10574
10575 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10576
10577         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10578         NULL. Initialize tpprev to NULL instead of assigning it
10579         to NULL on the next statement.
10580         * windows-nat.c (windows_delete_thread): Remove check for
10581         main_thread_id before printing thread exit notifications.
10582         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10583         Remove thread ID check against main_thread_id.
10584         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10585         windows_delete_thread.
10586         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10587
10588 2019-01-04  Tom Tromey  <tom@tromey.com>
10589
10590         * compile/compile.c (_initialize_compile): Use upper case for
10591         metasyntactic variables.
10592         * symmisc.c (_initialize_symmisc): Use upper case for
10593         metasyntactic variables.
10594         * psymtab.c (_initialize_psymtab): Use upper case for
10595         metasyntactic variables.
10596         * demangle.c (demangle_command): Use upper case for metasyntactic
10597         variables.
10598         (_initialize_demangler): Likewise.
10599         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10600         variables.
10601
10602 2019-01-03  Tom Tromey  <tom@tromey.com>
10603
10604         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10605
10606 2019-01-03  Tom Tromey  <tom@tromey.com>
10607
10608         * python/py-symtab.c (salpy_str): Update.
10609         (struct salpy_sal_object) <symtab>: Now a PyObject.
10610         (salpy_dealloc): Update.
10611         (del_objfile_sal): Use gdbpy_ref.
10612
10613 2019-01-03  Tom Tromey  <tom@tromey.com>
10614
10615         * python/py-type.c (convert_field): Use new_reference.  Return
10616         gdbpy_ref.
10617         (make_fielditem): Return gdbpy_ref.
10618         (typy_fields): Update.
10619         (typy_getitem): Update.
10620         (field_name): Return gdbpy_ref.  Use new_reference.
10621         (typy_iterator_iternext): Update.
10622
10623 2019-01-03  Tom Tromey  <tom@tromey.com>
10624
10625         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10626
10627 2019-01-03  Tom Tromey  <tom@tromey.com>
10628
10629         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10630         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10631         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10632         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10633         (pspy_set_type_printers): Likewise.
10634         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10635         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10636         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10637         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10638         (objfpy_set_type_printers): Likewise.
10639
10640 2019-01-03  Tom Tromey  <tom@tromey.com>
10641
10642         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10643         (gdbpy_print_stack): Use gdbpy_err_fetch.
10644         * python/python-internal.h (class gdbpy_err_fetch): New class.
10645         (class gdbpy_enter) <m_error_type, m_error_value,
10646         m_error_traceback>: Remove.
10647         <m_error>: New member.
10648         (gdbpy_exception_to_string): Don't declare.
10649         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10650         * python/py-value.c (convert_value_from_python): Use
10651         gdbpy_err_fetch.
10652         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10653         gdbpy_exception_to_string.
10654         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10655         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10656         gdbpy_err_fetch.
10657
10658 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10659
10660         * linux-nat.c (delete_lwp_cleanup): Delete.
10661         (struct lwp_deleter): New struct.
10662         (lwp_info_up): New typedef.
10663         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10664         lwp_info_up.
10665
10666 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10667
10668         * linux-fork.c (class scoped_switch_fork_info): New class.
10669         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10670
10671 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10672
10673         * valops.c (find_overload_match): Remove use of null_cleanup, and
10674         calls to do_cleanups.
10675
10676 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10677
10678         * compile/compile-cplus-types.c
10679         (compile_cplus_instance::decl_name): Handle changes to
10680         cp_func_name.
10681         * cp-support.c (cp_func_name): Update header comment, update
10682         return type.
10683         * cp-support.h (cp_func_name): Update return type in declaration.
10684         * valops.c (find_overload_match): Move temp_func local to top
10685         level of function and change its type.  Use temp_func to hold and
10686         delete temporary string obtained from cp_func_name.
10687
10688 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10689
10690         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10691         gdb::char_vector, remove cleanup, and update uses of `msg`.
10692
10693 2019-01-03  Jim Wilson  <jimw@sifive.com>
10694
10695         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10696
10697 2019-01-02  Tom Tromey  <tom@tromey.com>
10698
10699         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10700         (tdesc_parse_xml): Remove cleanups.
10701         * target-descriptions.h (make_cleanup_free_target_description):
10702         Don't declare.
10703         (target_desc_deleter): New struct.
10704         (target_desc_up): New typedef.
10705         * target-descriptions.c (target_desc_deleter::operator()): Rename
10706         from free_target_description.
10707         (make_cleanup_free_target_description): Remove.
10708
10709 2019-01-02  Tom Tromey  <tom@tromey.com>
10710
10711         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10712         constructor, destructor.
10713         (linespec_parser): Remove typedef.
10714         (~linespec_parser): Rename from linespec_parser_delete.
10715         (linespec_lex_to_end, linespec_complete_label)
10716         (linespec_complete): Update.
10717         (decode_line_full): Remove cleanups.
10718         (decode_line_1): Update.
10719
10720 2019-01-02  Tom Tromey  <tom@tromey.com>
10721
10722         * python/python-internal.h (inferior_to_inferior_object): Change
10723         return type.
10724         * python/py-exitedevent.c (create_exited_event_object): Update.
10725         * python/py-inferior.c (inferior_to_inferior_object): Return
10726         gdbpy_ref.
10727         (python_new_inferior, python_inferior_deleted)
10728         (thread_to_thread_object, delete_thread_object)
10729         (build_inferior_list, gdbpy_selected_inferior): Update.
10730         * python/py-infthread.c (create_thread_object): Update.  Also fail
10731         if inferior_to_inferior_object fails.
10732
10733 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10734
10735         * inferior.h (class inferior) <displaced_step_state>: New field.
10736         * infrun.h (struct displaced_step_state): Move here from
10737         infrun.c.  Initialize fields, add constructor.
10738         <inf>: Remove field.
10739         <reset>: New method.
10740         * infrun.c (struct displaced_step_inferior_state): Move to
10741         infrun.h.
10742         (displaced_step_inferior_states): Remove.
10743         (get_displaced_stepping_state): Adust.
10744         (displaced_step_in_progress_any_inferior): Adjust.
10745         (displaced_step_in_progress_thread): Adjust.
10746         (displaced_step_in_progress): Adjust.
10747         (add_displaced_stepping_state): Remove.
10748         (get_displaced_step_closure_by_addr): Adjust.
10749         (remove_displaced_stepping_state): Remove.
10750         (infrun_inferior_exit): Call displaced_step_state.reset.
10751         (use_displaced_stepping): Don't check for NULL.
10752         (displaced_step_prepare_throw): Call
10753         get_displaced_stepping_state.
10754         (displaced_step_fixup): Don't check for NULL.
10755         (prepare_for_detach): Don't check for NULL.
10756
10757 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10758
10759         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10760          in case of call that did not complete.
10761
10762 2019-01-02  Andrey Utkin  <autkin@undo.io>
10763
10764         * symfile.c (find_separate_debug_file): Fix search of debug files for
10765         remote debuggee.
10766
10767 2019-01-02  Tom Tromey  <tom@tromey.com>
10768
10769         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10770         indentation.
10771         * python/py-frame.c (frapy_older): Remove cast.
10772         (frapy_newer): Likewise.
10773         * python/py-breakpoint.c (local_setattro): Remove cast.
10774         * python/py-arch.c (archpy_name): Remove local variable.
10775         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10776
10777 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10778
10779         * unittests/basic_string_view/element_access/char/empty.cc:
10780         Fix year range in copyright header.
10781
10782 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10783
10784         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10785         Delete.
10786         <operator==>: Update with for removed field.
10787         <hash>: Likewise.
10788         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10789         <isa_features>: ...this.
10790         <abi_features>: New field.
10791         (riscv_isa_flen): Update comment.
10792         (riscv_abi_xlen): New declaration.
10793         (riscv_abi_flen): New declaration.
10794         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10795         isa_features.
10796         (riscv_abi_xlen): New function.
10797         (riscv_isa_flen): Update to get answer from isa_features.
10798         (riscv_abi_flen): New function.
10799         (riscv_has_fp_abi): Update to get answer from abi_features.
10800         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10801         xlen and flen.
10802         (riscv_call_info) <xlen, flen>: Update comment.
10803         (riscv_call_arg_struct): Remove invalid assertions
10804         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10805         is removed.
10806         (riscv_gdbarch_init): Gather isa features and abi features
10807         separately, ensure both match on the gdbarch when reusing an old
10808         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10809         a target with 64-bit float hardware.
10810
10811 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10812
10813         * source.c (search_command_helper): Stop reverse search
10814         when line 1 has been searched.
10815
10816 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10817
10818         * record-full.c (record_full_base_target::close): Rewrite
10819         record_full_core_buf_list free logic.
10820
10821 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10822
10823         * break-catch-syscall.c (print_one_catch_syscall): xfree
10824         the last text.
10825
10826 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10827
10828         * top.c (print_gdb_version): Update Copyright year in version
10829         message.
10830
10831 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10832
10833         Update copyright year range in all GDB files.
10834
10835 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10836
10837         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10838
10839 For older changes see ChangeLog-2018.
10840 \f
10841 Local Variables:
10842 mode: change-log
10843 left-margin: 8
10844 fill-column: 74
10845 version-control: never
10846 coding: utf-8
10847 End:
10848