gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
   4         (struct tui_data_window, struct tui_cmd_window): Declare
   5         clear_detail method.
   6         * tui/tui-data.c (tui_source_window::clear_detail)
   7         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
   8         methods.
   9         (tui_clear_win_detail): Simplify.
  10
  11 2019-06-25  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui-layout.c (make_source_window, make_disasm_window)
  14         (make_source_or_disasm_window): Remove win_info_ptr parameter.
  15         Return the new window.
  16         (show_source_disasm_command, show_data)
  17         (show_source_or_disasm_and_command): Update.
  18
  19 2019-06-25  Tom Tromey  <tom@tromey.com>
  20
  21         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
  22         parameter.  Return the new window.
  23         (show_source_disasm_command): Update and remove NULL check.
  24         (show_source_or_disasm_and_command): Update.
  25
  26 2019-06-25  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
  29
  30 2019-06-25  Tom Tromey  <tom@tromey.com>
  31
  32         * tui/tui-data.h (struct tui_win_info): Make constructor
  33         protected.  Make destructor virtual.  Add initializers.
  34         (tui_source_window, tui_data_window, tui_cmd_window): New
  35         classes.
  36         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
  37         constructor.  Add "type" parameter.
  38         (tui_source_window, tui_data_window, tui_cmd_window): New
  39         constructors.
  40         (tui_alloc_win_info): Instantiate the appropriate subclass.
  41
  42 2019-06-25  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-win.c (tui_resize_all): Use delete.
  45         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
  46         destructor.
  47         (tui_free_window): Don't declare.
  48         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
  49         Update.
  50
  51 2019-06-25  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui-data.h (struct tui_win_info): Add constructor.
  54         * tui/tui-data.c (tui_alloc_win_info): Use new.
  55         (tui_free_window): Use delete.
  56
  57 2019-06-22  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
  60         declare.
  61         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
  62
  63 2019-06-22  Tom Tromey  <tom@tromey.com>
  64
  65         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
  66         declare.
  67         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
  68
  69 2019-06-22  Tom de Vries  <tdevries@suse.de>
  70
  71         * dwarf2read.c (create_addrmap_from_aranges)
  72         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
  73         instead of '%zu'.
  74
  75 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
  76
  77         * dwarf2read.h (dwarf2_section_info_def): Remove.
  78         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
  79         * dwarf2read.c (struct dwo_sections) <types>: Change type to
  80         std::vector<dwarf2_section_info>.
  81         (struct dwo_file) <~dwo_file>: Remove.
  82         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
  83         types field.
  84         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
  85         (dwarf2_read_debug_names): Likewise.
  86         (create_debug_types_hash_table): Change parameter type to
  87         array_view, adjust code accordingly.
  88         (dwarf2_locate_dwo_sections): Adjust to std::vector.
  89         (partial_die_info::fixup): Likewise.
  90         (determine_prefix): Likewise.
  91         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
  92
  93 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  94
  95         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
  96         gdb_bfd_ref_ptr.
  97         <~dwo_file>: Remove call to gdb_bfd_unref.
  98         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
  99         gdb_bfd_ref_ptr::get.
 100
 101 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 102
 103         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 104         type to htab_up.
 105         * dwarf2read.c (struct dwo_file): Initialize fields.
 106         <~dwo_file>: New.
 107         (free_dwo_file): Remove, move content to ~dwo_file.
 108         (struct dwo_file_deleter): Remove.
 109         (dwo_file_up>: Remove custom deleter.
 110         (free_dwo_files): Remove.
 111         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 112         dwo_files.
 113         (process_skeletonless_type_units): Call unique_ptr::get.
 114         (allocate_dwo_file_hash_table): Add deleter to created hash
 115         table.  Change return type to htab_up.
 116         (lookup_dwo_file_slot): Don't memset dwo_file, call
 117         unique_ptr::get.
 118         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 119         (create_dwo_unit_in_dwp_v2): Likewise.
 120         (open_and_init_dwo_file): Likewise.
 121         (free_dwo_file_from_slot): Remove.
 122
 123 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 124
 125         * dwarf2read.h (struct dwarf2_section_info) <readin,
 126         is_virtual>: Change type to bool.
 127         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 128         true instead of 1.
 129
 130 2019-06-19  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-data.h (tui_init_content_element): Don't declare.
 133
 134 2019-06-19  Tom Tromey  <tom@tromey.com>
 135
 136         * tui/tui-data.h (tui_init_win_info): Don't declare.
 137
 138 2019-06-19  Tom de Vries  <tdevries@suse.de>
 139
 140         * dwarf2read.h (abstract_to_concrete): Change type to
 141         std::unordered_map<sect_offset, std::vector<sect_offset>,
 142         gdb::hash_enum<sect_offset>>.
 143
 144 2019-06-19  Tom Tromey  <tromey@adacore.com>
 145
 146         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 147         EVAL_AVOID_SIDE_EFFECTS specially.
 148
 149 2019-06-19  Tom Tromey  <tromey@adacore.com>
 150
 151         * source-cache.c (highlighter): New global.
 152         (source_cache::get_source_lines): Create a highlighter on demand.
 153
 154 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 155
 156         * defs.h (deprecated_interactive_hook): Delete declaration.
 157         * interps.c (clear_interpreter_hooks): Remove use of
 158         deprecated_interactive_hook.
 159         * top.c (deprecated_interactive_hook): Delete definition.
 160         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 161
 162 2019-06-18  Tom de Vries  <tdevries@suse.de>
 163
 164         PR gdb/24515
 165         * dwarf2read.h (abstract_to_concrete): Change type from
 166         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 167         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 168         * dwarf2read.c (read_variable): Update.
 169         (dwarf2_fetch_die_loc_sect_off): Update.
 170
 171 2019-06-17  Tom de Vries  <tdevries@suse.de>
 172
 173         PR gdb/24617
 174         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 175         accessing parent[parent_len - 1].
 176
 177 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 178
 179         PR gdb/24364
 180         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 181         call dtrace_process_dof with NULL dof.
 182
 183 2019-06-16  Tom de Vries  <tdevries@suse.de>
 184
 185         PR gdb/24445
 186         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 187
 188 2019-06-16  Tom Tromey  <tom@tromey.com>
 189
 190         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 191         (make_all_visible): Use address of member.
 192
 193 2019-06-16  Tom Tromey  <tom@tromey.com>
 194
 195         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 196         (tui_free_window, free_content, free_content_elements): Remove
 197         unnecessary cast.
 198         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 199         cast.
 200         * tui/tui-regs.c (tui_show_register_group)
 201         (tui_display_registers_from, tui_display_reg_element_at_line):
 202         Remove unnecessary cast.
 203
 204 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 205
 206         * linux-nat.c (normal_mask): Delete.
 207         (_initialize_linux_nat): Don't initialise normal_mask.
 208
 209 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 210
 211         PR gdb/24445
 212         * dwarf-index-write.h (write_psymtabs_to_index): Add
 213         dwz_basename parameter.
 214         * dwarf-index-write.c (write_gdbindex): Move file writing to
 215         write_gdbindex_1.  Change return type void.
 216         (assert_file_size): Move up, remove filename parameter.
 217         (write_gdbindex_1): New function.
 218         (write_debug_names): Change return type to void, call
 219         assert_file_size.
 220         (struct index_wip_file): New struct.
 221         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 222         file logic to index_wip_file.  Write index for dwz file if
 223         needed.
 224         (save_gdb_index_command): Pass basename of dwz file, if present.
 225         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 226         build-id of dwz file, if present.
 227         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 228         (dwarf2_get_dwz_file): Likewise.
 229         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 230         (dwarf2_get_dwz_file): Likewise.
 231
 232 2019-06-16  Tom Tromey  <tom@tromey.com>
 233
 234         * coffread.c (process_coff_symbol): Use xstrdup.
 235         * value.c (create_internalvar): Use xstrdup.
 236
 237 2019-06-16  Tom Tromey  <tom@tromey.com>
 238
 239         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 240         * breakpoint.c (stopin_command, stopat_command)
 241         (until_break_command, decode_location_default): Remove unnecessary
 242         cast.
 243         * utils.c (subset_compare): Remove unnecessary cast.
 244         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 245         cast.
 246         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 247         cast.
 248         * infcmd.c (path_command): Remove unnecessary cast.
 249         * coffread.c (decode_type): Remove unnecessary cast.
 250         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 251         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 252         * tui/tui-stack.c (tui_show_locator_content)
 253         (tui_show_frame_info): Remove unnecessary cast.
 254         * tui/tui-win.c (tui_scroll_forward_command)
 255         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 256         (parse_scrolling_args): Remove unnecessary cast.
 257         * tui/tui-data.c (init_win_info, tui_del_window)
 258         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 259         (free_content_elements): Remove unnecessary cast.
 260         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 261         unnecessary cast.
 262         * tui/tui-source.c (tui_set_source_content)
 263         (tui_vertical_source_scroll): Remove unnecessary cast.
 264         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 265         cast.
 266         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 267         * tui/tui-regs.c (tui_display_registers_from)
 268         (tui_display_register): Remove unnecessary cast.
 269         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 270         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 271         (make_visible): Remove unnecessary cast.
 272         * tui/tui-winsource.c (tui_erase_source_content)
 273         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 274         unnecessary cast.
 275         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 276         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 277         * stabsread.c (read_type, read_array_type, read_range_type):
 278         Remove unnecessary cast.
 279         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 280         (parse_symbol, parse_type, upgrade_type, parse_external)
 281         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 282         unnecessary cast.
 283         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 284
 285 2019-06-16  Tom Tromey  <tom@tromey.com>
 286
 287         * tui/tui-data.c (tui_alloc_generic_win_info)
 288         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 289         checks.
 290
 291 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 292             Andrew Burgess  <andrew.burgess@embecosm.com>
 293
 294         * f-typeprint.c (f_print_type): Don't return early for not
 295         associated or not allocated types.
 296         (f_type_print_varspec_suffix): Add print_rank parameter and print
 297         ranks of array types in case they dangling.
 298         (f_type_print_base): Add print_rank parameter.
 299
 300 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 301
 302         * NEWS: Mention new MI commands.
 303         * break-catch-throw.c (enum exception_event_kind): Move to
 304         breakpoint.h.
 305         (print_mention_exception_catchpoint): Output text as a single
 306         message.
 307         (catch_exception_command_1): Rename to...
 308         (catch_exception_event): ...this, make non-static, update header
 309         command, and change some parameter types.
 310         (catch_catch_command): Update for changes to
 311         catch_exception_command_1.
 312         (catch_throw_command): Likewise.
 313         (catch_rethrow_command): Likewise.
 314         * breakpoint.c (enum exception_event_kind): Delete.
 315         * breakpoint.h (enum exception_event_kind): Moved here from
 316         break-catch-throw.c.
 317         (catch_exception_event): Declare.
 318         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 319         (mi_cmd_catch_throw): New function.
 320         (mi_cmd_catch_rethrow): New function.
 321         (mi_cmd_catch_catch): New function.
 322         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 323         'catch-catch' entries.
 324         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 325         (mi_cmd_catch_rethrow): Declare.
 326         (mi_cmd_catch_catch): Declare.
 327
 328 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 329
 330         * annotate.c (annotate_source_line): Change return type to void,
 331         update implementation to match.
 332         * annotate.h (annotate_source_line): Change return type to void,
 333         update header comment.
 334         * stack.c (print_frame_info): Don't change what frame information
 335         is printed based on whether annotations are on or not.
 336
 337 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 338
 339         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 340         (annotate_source): Make static.
 341         (annotate_source_line): Moved from source.c and renamed from
 342         identify_source_line.  Update the return type.
 343         * annotate.h (annotate_source): Delete declaration.
 344         (annotate_source_line): Declaration moved from source.h, and
 345         renamed from identify_source_line.  Return type updated.
 346         * source.c (identify_source_line): Moved to annotate.c and renamed
 347         to annotate_source_line.
 348         (info_line_command): Remove check of annotation_level.
 349         * source.h (identify_source_line): Move declaration to annotate.h
 350         and rename to annotate_source_line.
 351         * stack.c: Add 'annotate.h' include.
 352         (print_frame_info): Remove check of annotation_level before
 353         calling annotate_source_line.
 354
 355 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 356
 357         * source-cache.c (source_cache::get_plain_source_lines): Use
 358         open_source_file_with_line_charpos instead of just
 359         open_source_file, remove call to find_source_lines.
 360         (source_cache::get_source_lines): Likewise.
 361         * source.c (find_source_lines): Make static.
 362         (get_filename_and_charpos): Renamed into...
 363         (open_source_file_with_line_charpos): ..this along with changes to
 364         return a scoped_fd, and some other minor clean ups.
 365         (identify_source_line): Use open_source_file_with_line_charpos.
 366         (search_command_helper): Use open_source_file_with_line_charpos
 367         instead of just open_source_file, remove call to
 368         find_source_lines.
 369         * source.h (open_source_file_with_line_charpos): Declare new
 370         function.
 371         (find_source_lines): Delete declaration.
 372
 373 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 374
 375         * source.c (get_filename_and_charpos): Remove fullname
 376         parameter.
 377         (identify_source_line): Update call to get_filename_and_charpos.
 378
 379 2019-06-14  Tom Tromey  <tromey@adacore.com>
 380
 381         PR gdb/24502:
 382         * ui-style.h (skip_ansi_escape): Update comment.
 383         * ui-file.h (class no_terminal_escape_file): New class.
 384         * ui-file.c (no_terminal_escape_file::write)
 385         (no_terminal_escape_file::puts): New methods.
 386         * cli/cli-logging.c (handle_redirections): Use
 387         no_terminal_escape_file.
 388
 389 2019-06-14  Tom Tromey  <tromey@adacore.com>
 390
 391         * NEWS: Move convenience variable news above Python news.
 392
 393 2019-06-14  Tom Tromey  <tom@tromey.com>
 394
 395         * gnulib: Move directory to top-level.
 396         * configure.ac: Don't configure gnulib.
 397         * configure: Rebuild.
 398         * common/common-defs.h: Use new path to gnulib.
 399         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 400         (GNULIB_H): Remove.
 401         (INCGNU): Look in new gnulib location.
 402         (HFILES_NO_SRCDIR): Remove gnulib files.
 403         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 404         (generated_files): Remove GNULIB_H.
 405         ($(LIBGNU), all-lib): Remove targets.
 406         (distclean): Don't mention GNULIB_BUILDDIR.
 407         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 408
 409 2019-06-14  Tom Tromey  <tromey@adacore.com>
 410
 411         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 412         Warn if symbol file does not provide any symbols.
 413
 414 2019-06-14  Tom Tromey  <tromey@adacore.com>
 415
 416         * source.c (find_and_open_source): Respect basenames_may_differ.
 417
 418 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 419
 420         * annotate.c (annotate_breakpoints_invalid): Make use of
 421         scoped_restore_terminal_state.
 422         (annotate_frames_invalid): Likewise.
 423
 424 2019-06-14  Tom Tromey  <tromey@adacore.com>
 425
 426         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 427         allow assignment to an internalvar.
 428
 429 2019-06-14  Tom Tromey  <tromey@adacore.com>
 430
 431         * ada-lex.l: Allow "_" in attribute names.
 432
 433 2019-06-14  Tom Tromey  <tromey@adacore.com>
 434
 435         PR gdb/24653:
 436         * regcache.c (registers_changed): Don't call alloca.
 437         * top.c (execute_command): Don't call alloca.
 438
 439 2019-06-13  Pedro Alves  <palves@redhat.com>
 440
 441         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 442         'expression'.  When parsing an expression, error out if there's
 443         junk after "unlimited".
 444         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 445         (do_set_command): Adjust calls to is_unlimited_literal.
 446
 447 2019-06-13  Pedro Alves  <palves@redhat.com>
 448
 449         * compile/compile.c (make_compile_options_def_group): Add braces
 450         around array_view initializer.
 451         * thread.c (make_thread_apply_all_options_def_group)
 452         (make_thread_apply_all_options_def_group): Likewise.
 453
 454 2019-06-13  Pedro Alves  <palves@redhat.com>
 455
 456         * NEWS (New commands): Mention "maint test-options
 457         require-delimiter", "maint test-options unknown-is-error", "maint
 458         test-options unknown-is-operand" and "maint show
 459         test-options-completion-result".
 460         (New command options, command completion): New section.
 461         (Completion improvements): New section.
 462         Mention that you can abbreviate "unlimited".
 463
 464 2019-06-13  Pedro Alves  <palves@redhat.com>
 465
 466         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 467         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 468         * unittests/cli-utils-selftests.c (test_parse_flags)
 469         (test_parse_flags_qcs): Delete.
 470         (test_cli_utils): Don't call deleted functions.
 471
 472 2019-06-13  Pedro Alves  <palves@redhat.com>
 473
 474         * thread.c: Include "cli/cli-option.h".
 475         (tp_array_compar_ascending): Global.
 476         (tp_array_compar): Delete function.
 477         (tp_array_compar_ascending, tp_array_compar_descending): New
 478         functions.
 479         (ascending_option_def, qcs_flag_option_def)
 480         (thr_qcs_flags_option_defs)
 481         (make_thread_apply_all_options_def_group)
 482         (make_thread_apply_options_def_group): New.
 483         (thread_apply_all_command): Use gdb::option::process_options.
 484         (thread_apply_command_completer)
 485         (thread_apply_all_command_completer): New.
 486         (thread_apply_command): Use gdb::option::process_options.
 487         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 488         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 489         to generate help text of "thread apply".  Adjust "taas"'s help.
 490         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 491         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 492
 493 2019-06-13  Pedro Alves  <palves@redhat.com>
 494
 495         * thread.c (thread_apply_command): Check for invalid TID with
 496         isdigit instead of !isalpha.
 497
 498 2019-06-13  Pedro Alves  <palves@redhat.com>
 499
 500         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 501         (validate_flags_qcs): New.
 502         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 503         (validate_flags_qcs): Declare.
 504         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 505         (make_frame_apply_options_def_group): New.
 506         (frame_apply_command_count): Process options with
 507         gdb::option::process_options.
 508         (frame_apply_completer): New.
 509         (frame_apply_level_completer, frame_apply_all_completer)
 510         (frame_apply_completer): New.
 511         (_initialize_stack): Update help of "frame apply", "frame apply
 512         level", "frame apply all" and "faas" to mention supported options
 513         and install command completers.
 514         * stack.h (frame_apply_all_completer): Declare.
 515         * thread.c: Include "stack.h".
 516         (tfaas_command): Add "--".
 517         (_initialize_thread): Update help "tfaas" to mention supported
 518         options and install command completer.
 519
 520 2019-06-13  Pedro Alves  <palves@redhat.com>
 521
 522         * completer.c (complete_nested_command_line): New.
 523         (gdb_completion_word_break_characters_throw): Add assertion.
 524         * completer.h (complete_nested_command_line): Declare.
 525
 526 2019-06-13  Pedro Alves  <palves@redhat.com>
 527
 528         * stack.c (parse_backtrace_qualifiers): New.
 529         (backtrace_command): Use it.
 530         (backtrace_command_completer): Complete on qualifiers.
 531
 532 2019-06-13  Pedro Alves  <palves@redhat.com>
 533
 534         * frame.c: Include "cli/cli-option.h.
 535         (user_set_backtrace_options): New.
 536         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 537         Delete.
 538         (get_prev_frame): Adjust.
 539         (boolean_option_def, uinteger_option_def)
 540         (set_backtrace_option_defs): New.
 541         (_initialize_frame): Adjust and use
 542         gdb::option::add_setshow_cmds_for_options to install "set
 543         backtrace past-main" and "set backtrace past-entry".
 544         * frame.h: Include "cli/cli-option.h".
 545         (struct frame_print_options): Forward declare.
 546         (print_frame_arguments_all, print_frame_arguments_scalars)
 547         (print_frame_arguments_none): Declare.
 548         (print_entry_values): Delete declaration.
 549         (struct frame_print_options, user_frame_print_options): New.
 550         (struct set_backtrace_options): New.
 551         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 552         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 553         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 554         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 555         (list_args_or_locals): Add frame_print_options parameter.
 556         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 557         * python/py-framefilter.c (enumerate_args): Pass down
 558         USER_FRAME_PRINT_OPTIONS.
 559         * stack.c: Include "cli/cli-option.h".
 560         (print_frame_arguments_all, print_frame_arguments_scalars)
 561         (print_frame_arguments_none): Declare.
 562         (print_raw_frame_arguments, print_entry_values): Delete.
 563         (user_frame_print_options): New.
 564         (boolean_option_def, enum_option_def, frame_print_option_defs):
 565         New.
 566         (struct backtrace_cmd_options): New.
 567         (bt_flag_option_def): New.
 568         (backtrace_command_option_defs): New.
 569         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 570         (print_frame_arg, read_frame_arg, print_frame_args)
 571         (print_frame_info, print_frame): Add frame_print_options parameter
 572         and use it.
 573         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 574         (backtrace_command_1): Add frame_print_options and
 575         backtrace_cmd_options parameters and use them.
 576         (make_backtrace_options_def_group): New.
 577         (backtrace_command): Process command options with
 578         gdb::option::process_options.
 579         (backtrace_command_completer): New.
 580         (_initialize_stack): Extend "backtrace"'s help to mention
 581         supported options.  Install completer for "backtrace".
 582         Install some settings commands with add_setshow_cmds_for_options.
 583
 584 2019-06-13  Pedro Alves  <palves@redhat.com>
 585
 586         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 587         and that "set/show print raw frame-arguments" are now deprecated.
 588
 589         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 590         command.
 591         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 592         * stack.c (_initialize_stack): Install "set/show print
 593         raw-frame-arguments", and deprecate "set/show print raw
 594         frame-arguments".
 595         * valprint.c (_initialize_valprint): Deprecate "set/show print
 596         raw".
 597
 598 2019-06-13  Pedro Alves  <palves@redhat.com>
 599
 600         * compile/compile.c (struct compile_options): New.
 601         (compile_flag_option_def, compile_command_option_defs)
 602         (make_compile_options_def_group): New.
 603         (compile_file_command): Handle options with
 604         gdb::option::process_options.
 605         (compile_file_command_completer): New function.
 606         (compile_code_command): Handle options with
 607         gdb::option::process_options.
 608         (compile_code_command_completer): New function.
 609         (_initialize_compiler): Install completers for "compile code" and
 610         "compile file".  Mention available options in "compile code" and
 611         "compile code"'s help.
 612         * completer.c (advance_to_completion_word): New, factored out from
 613         ...
 614         (advance_to_expression_complete_word_point): ... this.
 615         (advance_to_filename_complete_word_point): New.
 616         * completer.h (advance_to_filename_complete_word_point): New
 617         declaration.
 618
 619 2019-06-13  Pedro Alves  <palves@redhat.com>
 620
 621         * compile/compile.c: Include "cli/cli-option.h".
 622         (compile_print_value): Scope data pointer is now a
 623         value_print_options pointer; adjust.
 624         (compile_print_command): Process options.  Scope data pointer is
 625         now a value_print_options pointer; adjust.
 626         (_initialize_compile): Update "compile print"'s help to include
 627         supported options.  Install a completer for "compile print".
 628         * cp-valprint.c (show_vtblprint, show_objectprint)
 629         (show_static_field_print): Delete.
 630         (_initialize_cp_valprint): Don't install "set print
 631         static-members", "set print vtbl", "set print object" here.
 632         * printcmd.c: Include "cli/cli-option.h" and
 633         "common/gdb_optional.h".
 634         (print_command_parse_format): Rework to fill in a
 635         value_print_options instead of a format_data.
 636         (print_value): Change parameter type from format_data pointer to
 637         value_print_options reference.  Adjust.
 638         (print_command_1): Process options.  Adjust to pass down a
 639         value_print_options.
 640         (print_command_completer): New.
 641         (_initialize_printcmd): Install print_command_completer as
 642         handle_brkchars completer for the "print" command.  Update
 643         "print"'s help to include supported options.
 644         * valprint.c: Include "cli/cli-option.h".
 645         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 646         here from cp-valprint.c.
 647         (boolean_option_def, uinteger_option_def)
 648         (value_print_option_defs, make_value_print_options_def_group):
 649         New.  Use gdb::option::add_setshow_cmds_for_options to install
 650         "set print elements", "set print null-stop", "set print repeats",
 651         "set print pretty", "set print union", "set print array", "set
 652         print address", "set print symbol", "set print array-indexes".
 653         * valprint.h: Include <string> and "cli/cli-option.h".
 654         (make_value_print_options_def_group): Declare.
 655         (print_value): Change parameter type from format_data pointer to
 656         value_print_options reference.
 657         (print_command_completer): Declare.
 658
 659 2019-06-13  Pedro Alves  <palves@redhat.com>
 660
 661         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 662         (COMMON_SFILES): Add maint-test-settings.c.
 663         * cli/cli-decode.c (boolean_enums): New global, factored out from
 664         ...
 665         (add_setshow_boolean_cmd): ... here.
 666         * cli/cli-decode.h (boolean_enums): Declare.
 667         * cli/cli-option.c: New file.
 668         * cli/cli-option.h: New file.
 669         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 670         factored out from ...
 671         (parse_cli_boolean_value(const char *)): ... this.
 672         (is_unlimited_literal): Change parameter type to pointer to
 673         pointer.  Adjust and advance ARG pointer.
 674         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 675         (parse_cli_var_enum): New, factored out from ...
 676         (do_set_command): ... this.  Adjust.
 677         * cli/cli-setshow.h (parse_cli_boolean_value)
 678         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 679         (parse_cli_var_enum): Declare.
 680         * cli/cli-utils.c: Include "cli/cli-option.h".
 681         (get_ulongest): New.
 682         * cli/cli-utils.h (get_ulongest): Declare.
 683         (check_for_argument): New overloads.
 684         * maint-test-options.c: New file.
 685
 686 2019-06-13  Pedro Alves  <palves@redhat.com>
 687
 688         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 689         parse a range if "-" is at the end of the string.
 690
 691 2019-06-13  Pedro Alves  <palves@redhat.com>
 692
 693         * cli/cli-setshow.c (parse_auto_binary_operation)
 694         (parse_cli_boolean_value): Don't allow "o".
 695
 696 2019-06-13  Pedro Alves  <palves@redhat.com>
 697
 698         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 699         * NEWS: Mention maint test-settings KIND.
 700         * maint-test-settings.c: New file.
 701
 702 2019-06-13  Pedro Alves  <palves@redhat.com>
 703
 704         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 705         completer.
 706         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 707         "set" completers.
 708
 709 2019-06-13  Pedro Alves  <palves@redhat.com>
 710
 711         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 712         after item.
 713
 714 2019-06-13  Pedro Alves  <palves@redhat.com>
 715
 716         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 717
 718 2019-06-13  Pedro Alves <palves@redhat.com>
 719
 720         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 721         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 722         call.
 723         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 724         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 725         calls.
 726         (check_for_argument): Skip spaces after argument.
 727
 728 2019-06-13  Pedro Alves  <palves@redhat.com>
 729
 730         * thread.c (thread_apply_command): Adjust TID parsing.
 731         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 732         detected before end of string.
 733         (tid_is_in_list): Error out if LIST is invalid.
 734
 735 2019-06-13  Pedro Alves  <palves@redhat.com>
 736
 737         * completer.c (complete_line_internal_1): Rewind completion word
 738         point.
 739         (completion_tracker::advance_custom_word_point_by): Change
 740         parameter type to int.
 741         * completer.h (completion_tracker::advance_custom_word_point_by):
 742         Likewise.
 743
 744 2019-06-13  Pedro Alves  <palves@redhat.com>
 745
 746         * completer.c (advance_to_completion_word): Handle delimiters.
 747
 748 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 749
 750         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 751
 752 2019-06-11  Tom Tromey  <tom@tromey.com>
 753
 754         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 755         (xmalloc_failed): Move to alloc.c.
 756         * alloc.c: New file.
 757         * Makefile.in (COMMON_SFILES): Add alloc.c.
 758
 759 2019-06-11  Tom Tromey  <tom@tromey.com>
 760
 761         * nat/linux-waitpid.c: Don't include server.h.
 762         (linux_debug): Remove.
 763         (my_waitpid): Update.
 764
 765 2019-06-11  Tom Tromey  <tromey@adacore.com>
 766
 767         * infcall.c (_initialize_infcall): Remove trailing newline from
 768         help.
 769         * user-regs.c (_initialize_user_regs): Remove trailing newline
 770         from help.
 771         * typeprint.c (_initialize_typeprint): Remove trailing newline
 772         from help.
 773         * reverse.c (_initialize_reverse): Remove trailing newlines from
 774         help.
 775         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 776         from help.
 777         * language.c (add_set_language_command): Remove trailing newline
 778         from help.
 779         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 780         help.
 781         * disasm.c (_initialize_disasm): Remove trailing newline from
 782         help.
 783         * top.c (init_main): Remove trailing newline from help.
 784         * interps.c (_initialize_interpreter): Remove trailing newline
 785         from help.
 786         * btrace.c (_initialize_btrace): Remove trailing newlines from
 787         help.
 788         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 789         from help.
 790         * python/python.c (_initialize_python): Remove trailing newline
 791         from help.
 792         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 793         help.
 794         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 795         from help.  Reformat some text.
 796         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 797         from help.
 798         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 799         newline from help.
 800
 801 2019-06-11  Tom Tromey  <tromey@adacore.com>
 802
 803         * darwin-nat.c (darwin_decode_exception_message)
 804         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 805
 806 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 807
 808         * valops.c (value_slice): Check for not allocated or not
 809         associated values.
 810
 811 2019-06-10  Tom de Vries  <tdevries@suse.de>
 812
 813         PR gdb/24618
 814         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 815         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 816         invalid.
 817
 818 2019-06-10  Tom de Vries  <tdevries@suse.de>
 819
 820         PR gdb/24611
 821         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 822         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 823
 824 2019-06-10  Tom de Vries  <tdevries@suse.de>
 825
 826         PR symtab/24545
 827         * symtab.c (struct demangled_name_entry): Add language field.
 828         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 829         static minimal symbol".  Set and use language field.
 830
 831 2019-06-10  Tom Tromey  <tromey@adacore.com>
 832
 833         * ada-lang.c (_initialize_ada_language): Update help text.
 834
 835 2019-06-10  Tom Tromey  <tromey@adacore.com>
 836
 837         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 838         with a newline.
 839         * guile/guile.c (handle_boot_error): Don't end warning with a
 840         newline.
 841         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 842         warning with a newline.
 843         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 844         newline.
 845         (s12z_frame_cache): Likewise.
 846         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 847         a newline.
 848         * solib-svr4.c (disable_probes_interface): Don't end warning with
 849         a newline.
 850         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 851         newline.
 852         * python/python.c (do_finish_initialization): Don't end warning
 853         with a newline.
 854
 855 2019-06-10  Tom Tromey  <tom@tromey.com>
 856
 857         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 858         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 859         gdbpy_enter.
 860
 861 2019-06-10  Tom Tromey  <tromey@adacore.com>
 862
 863         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 864         data.
 865         (elf_new_init): Don't call stabsread_new_init.
 866         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 867         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 868         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 869
 870 2019-06-10  Tom de Vries  <tdevries@suse.de>
 871
 872         PR symtab/16264
 873         PR symtab/24517
 874         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 875
 876 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 877
 878         * source.c (find_and_open_source): Also rewrite relative file
 879         names.
 880
 881 2019-04-26  Amos Bird  <amosbird@gmail.com>
 882
 883         * annotate.c (annotate_thread_exited): Add "thread-exited"
 884         annotation.
 885
 886 2019-06-06  Tom Tromey  <tromey@adacore.com>
 887
 888         * maint.h (class scoped_command_stats): Use
 889         DISABLE_COPY_AND_ASSIGN.
 890         <print_time>: New method.
 891         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 892         print_time.
 893         (scoped_command_stats::print_time): New method.
 894
 895 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 896
 897         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 898         instructions of lengths 6 or 8 bytes.
 899
 900 2019-06-04  Pedro Alves  <palves@redhat.com>
 901
 902         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 903
 904         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 905         * breakpoint.c (condition_completer): Likewise.
 906         * cli/cli-dump.c (scan_expression): Likewise.
 907         * common/filestuff.c (mkdir_recursive): Likewise.
 908         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 909         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 910         (gdb_abspath): Likewise.
 911         * compile/compile-cplus-types.c
 912         (compile_cplus_instance::decl_name): Likewise.
 913         * completer.c (complete_explicit_location):
 914         (signal_completer, reg_or_group_completer_1): Likewise.
 915         * cp-support.c (cp_remove_params_if_any): Likewise.
 916         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 917         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 918         * infcmd.c (strip_bg_char): Likewise.
 919         * linespec.c (copy_token_string): Likewise.
 920         * mi/mi-main.c (output_cores): Likewise.
 921         * psymtab.c (psymtab_search_name):
 922         * symfile.c (test_set_ext_lang_command): Likewise.
 923         * target.c (target_fileio_read_stralloc): Likewise.
 924         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 925         * value.c (complete_internalvar): Likewise.
 926
 927 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 928
 929         Add objfile property to gdb.Type.
 930         * NEWS: Mention Python API addition.
 931         * python/py-type.c (typy_get_objfile): New method.
 932
 933 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 934
 935         * NEWS: Mention the new set|show style [title|highlight].
 936         Mention changes to "show style", "help" and "apropos".
 937
 938 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 939
 940         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 941         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 942         instead of print_help_for_command.
 943         (print_doc_of_command): New function.
 944         (help_list): Add 'apropos -v word' suggestion.
 945         (print_help_for_command): Style the command name using title style.
 946         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 947         (_initialize_cli_cmds): Describe -v in apropos_command help.
 948
 949 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 950
 951         * cli/cli-style.h (cli_style_option): Add name in constructor,
 952         add m_name class member, add constructor with intensity,
 953         add name class function.
 954         (cli_style_option::add_setshow_commands): Remove name argument.
 955         (highlight_style, title_style): New styles.
 956         * cli/cli-style.c (do_show): New function that shows a style
 957         characteristic styling the style name with itself.
 958         (set_style_name): New function.
 959         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 960         Update all callers according to the changes in cli/cli-style.h.
 961         * utils.h (fputs_highlighted): New function.
 962         * utils.c (fputs_highlighted): Likewise.
 963
 964 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 965
 966         * NEWS: Mention new pipe command and new convenience variables.
 967
 968 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 969
 970         * cli/cli-cmds.c (pipe_command): New function.
 971         (_initialize_cli_cmds): Call add_com for pipe_command.
 972         Define | as an alias for pipe.
 973         (exit_status_set_internal_vars): New function.
 974         (shell_escape): Call exit_status_set_internal_vars.
 975         cli/cli-decode.c (find_command_name_length): Recognize | as
 976         a single character command.
 977
 978 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 979
 980         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 981         top.c (execute_command_to_ui_file): New function, mostly a copy
 982         of execute_command_to_string.
 983         (execute_command_to_string): Implement by calling
 984         execute_command_to_ui_file.
 985
 986 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 987
 988         * top.h (saved_command_line): Remove declaration.
 989         * top.c (previous_saved_command_line, previous_repeat_arguments):
 990         New variables.
 991         (saved_command_line): Make static, define together with other
 992         'repeat variables'.
 993         (dont_repeat): Clear repeat_arguments.
 994         (repeat_previous, get_saved_command_line, save_command_line):
 995         New functions.
 996         (gdb_init): Initialize saved_command_line
 997         and previous_saved_command_line.
 998         * main.c (captured_main_1): Remove saved_command_line initialization.
 999         * event-top.c (handle_line_of_input): Update to use
1000         the new 'repeat' related functions instead of direct access to
1001         saved_command_line.
1002         * command.h (repeat_previous, get_saved_command_line,
1003         save_command_line): New declarations.
1004         (dont_repeat): Add comment.
1005
1006 2019-05-30  Tom Tromey  <tromey@adacore.com>
1007
1008         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1009         Fix comment.
1010         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1011
1012 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1013
1014         PR cli/24587
1015         * completer.c (complete): Initialize variable word.
1016
1017 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1018
1019         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1020         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1021         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1022         'body' is NULL to the outter 'if', protecting the '!is_define'
1023         situation as well.
1024
1025 2019-05-29  Tom Tromey  <tromey@adacore.com>
1026
1027         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1028         (dwarf_unknown): New function.
1029         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1030         (dwarf_type_encoding_name): Use dwarf_unknown.
1031
1032 2019-05-29  Tom Tromey  <tromey@adacore.com>
1033
1034         PR c++/20020:
1035         * cp-valprint.c (cp_print_value_fields): Call
1036         cp_print_static_field inside "try".
1037
1038 2019-05-29  Tom Tromey  <tromey@adacore.com>
1039
1040         * inflow.c (struct terminal_info): Add default operator=.
1041         * configure: Rebuild.
1042         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1043         -Wdeprecated-copy-dtor, -Wredundant-move.
1044
1045 2019-05-29  Tom Tromey  <tromey@adacore.com>
1046
1047         * NEWS: Add entry.
1048         * infcmd.c (print_return_value_1): Handle finish_print
1049         option.
1050         (show_print_finish): New function.
1051         (_initialize_infcmd): Add "set/show print finish" commands.
1052         * valprint.c (user_print_options): Initialize new member.
1053         * valprint.h (struct value_print_options) <finish_print>: New
1054         member.
1055
1056 2019-05-28  Tom Tromey  <tromey@adacore.com>
1057
1058         * ada-lang.c (ada_remove_Xbn_suffix)
1059         (find_old_style_renaming_symbol)
1060         (parse_old_style_renaming): Remove.
1061         (ada_find_renaming_symbol): Don't call
1062         find_old_style_renaming_symbol.
1063         (ada_is_renaming_symbol): Rename from
1064         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1065         bool.  Now static.
1066         (ada_read_var_value): Update and simplify.
1067         * ada-exp.y (write_var_or_type): Remove old code.
1068
1069 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1070
1071         * event-top.c: Remove include comment.
1072         * inflow.c (class scoped_ignore_sigttou): Move from here...
1073         * inflow.h (class scoped_ignore_sigttou): ...to here.
1074         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1075         * top.c:  Remove include comment.
1076
1077 2019-05-27  Tom Tromey  <tom@tromey.com>
1078
1079         * NEWS: Fix typo.
1080
1081 2019-05-22  Tom Tromey  <tromey@adacore.com>
1082
1083         * target.c (target_follow_exec): Constify parameter.
1084         * target-delegates.c: Rebuild.
1085         * remote.c (remote_target::follow_exec): Constify parameter.
1086         * infrun.c (follow_exec): Constify parameter.
1087         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1088         (target_follow_exec): Likewise.
1089
1090 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1091
1092         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1093         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1094
1095 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1096
1097         * NEWS: Add debugredirect and testsuite sections.
1098
1099 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1100
1101         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1102         target descriptions using exclusively floating point register name
1103         aliases.
1104
1105 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1106
1107         PR gdb/18644:
1108         * f-lang.c (build_fortran_types): Handle the case where
1109         gdbarch_floatformat_for_type returns a nullptr.
1110
1111 2019-05-21  Tom de Vries  <tdevries@suse.de>
1112
1113         PR cli/24587
1114         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1115
1116 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1117
1118         PR gdb/18644:
1119         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1120         16-byte floats.
1121         * i386-tdep.c (i386_floatformat_for_type): Use
1122         floatformats_ia64_quad for the 16-byte floating point component
1123         within a fortran 32-byte complex number.
1124
1125 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1126
1127         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1128         delete default constructor.
1129         (find_partial_die): Update to return const struct.
1130         (partial_die_parent_scope): Move variable declaration into scope
1131         of its use and change its type to auto.
1132         (guess_partial_die_structure_name): Likewise.
1133         (partial_die_info::fixup): Likewise.
1134
1135 2019-05-17  Tom Tromey  <tromey@adacore.com>
1136
1137         * source.c (find_and_open_source): Remove cast.
1138
1139 2019-05-17  Tom Tromey  <tromey@adacore.com>
1140
1141         * annotate.c (annotate_source): Make "filename" const.
1142         * annotate.h (annotate_source): Use const.
1143
1144 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1145
1146         * disasm.c (set_disassembler_options): Send errors to stderr.
1147
1148 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1149
1150         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1151         (cli_interp_base::set_logging): Check debug_redirect.
1152         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1153         * cli/cli-logging.c (debug_redirect): Add static variable.
1154         (pop_output_files): Add default param.
1155         (handle_redirections): Print debug setting.
1156         (show_logging_command): Likewise.
1157         (_initialize_cli_logging): Add debugredirect command.
1158         * interps.c (current_interp_set_logging): Add debug_redirect
1159         parameter.
1160         * interps.h (set_logging): Add debug_redirect parameter.
1161         (current_interp_set_logging): Likewise.
1162         * mi/mi-common.h: Likewise.
1163         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1164
1165 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1166             Tom Tromey  <tromey@adacore.com>
1167
1168         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1169         directly.
1170         * cli/cli-interp.h (make_logging_output): Remove declaration.
1171         * cli/cli-logging.c (make_logging_output): Remove function.
1172         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1173         directly.
1174         * ui-file.c (tee_file::tee_file): Remove bools.
1175         (tee_file::~tee_file): Remove deletes.
1176         * ui-file.h (tee_file): Remove bools.
1177
1178 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1179
1180         * mi/mi-cmds.h (mi_cmd_complete): New function.
1181         * mi/mi-main.c (mi_cmd_complete): Likewise.
1182         * mi/mi-cmds.c: Define new MI command -complete.
1183         * NEWS: Mention new -complete command.
1184
1185 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1186
1187         * completer.h (complete): New function.
1188         * completer.c (complete): Likewise.
1189         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1190         function defined in completer.h.
1191
1192 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1193
1194         * MAINTAINERS (Write After Approval): Add myself.
1195
1196 2019-05-17  Tom de Vries  <tdevries@suse.de>
1197
1198         PR gdb/24094
1199         * dwarf2read.c (struct cu_partial_die_info): New struct.
1200         (find_partial_die): Return cu_partial_die_info.
1201         (partial_die_parent_scope, guess_partial_die_structure_name)
1202         (partial_die_info::fixup): Handle new return type of find_partial_die.
1203
1204 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1205
1206         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1207         "std::string", simplifying the algorithm.
1208
1209 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1210
1211         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1212         (stap_static_probe_ops::get_probes): Likewise.
1213
1214 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1215
1216         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1217         '-')" and "else if".
1218         (stap_parse_single_operand): Join checks for
1219         "gdbarch_stap_parse_special_token_p" and
1220         "gdbarch_stap_parse_special_token" in the same "if" statement.
1221         Invert check when verifying for operation on register
1222         displacement.
1223
1224 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1225
1226         * stap-probe.c (stap_get_opcode): Update comment.
1227         (stap_get_expected_argument_type): Likewise.
1228         (handle_stap_probe): Likewise.
1229
1230 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1231
1232         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1233         return type to 'bool'.  Adjust comment.  Use 'bool' when
1234         appropriate.
1235         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1236         * stap-probe.c (stap_parse_argument_1): Likewise.
1237         (stap_is_operator): Likewise.
1238         (stap_is_generic_prefix): Likewise.
1239         (stap_is_register_prefix): Likewise.
1240         (stap_is_register_indirection_prefix): Likewise.
1241         (stap_is_integer_prefix): Likewise.
1242         (stap_generic_check_suffix): Likewise.
1243         (stap_check_integer_suffix): Likewise.
1244         (stap_check_register_suffix): Likewise.
1245         (stap_check_register_indirection_suffix): Likewise.
1246         (stap_parse_register_operand): Likewise.
1247         (stap_parse_single_operand): Likewise.
1248         (stap_parse_argument_1): Likewise.
1249         (stap_probe::get_argument_count): Likewise.
1250         (stap_is_operator): Likewise.
1251
1252 2019-05-16  Tom Tromey  <tromey@adacore.com>
1253
1254         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1255         keyword to foreach.
1256
1257 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1258
1259         * linux-thread-db.c (try_thread_db_load_1): Change return type
1260         to bool.
1261         (try_thread_db_load): Likewise.
1262         (try_thread_db_load_from_pdir_1): Likewise.
1263         (try_thread_db_load_from_pdir): Likewise.
1264         (try_thread_db_load_from_sdir): Likewise.
1265         (try_thread_db_load_from_dir): Likewise.
1266         (thread_db_load_search): Likewise.
1267         (has_libpthread): Likewise.
1268         (thread_db_load): Likewise.
1269
1270 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1271
1272         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1273         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1274         NULL, and complain/return if that's the case.
1275
1276 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1277
1278         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1279         (advance, posn, abstract_read_memory): New functions.
1280         [struct mem_read_abstraction]: New struct.
1281         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1282
1283 2019-05-14  Tom Tromey  <tromey@adacore.com>
1284
1285         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1286         value is not lval_memory.
1287
1288 2019-05-14  Tom Tromey  <tromey@adacore.com>
1289
1290         * solib.c (info_sharedlibrary_command): Style the file name.
1291
1292 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1293
1294         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1295         (aarch64_vnv_type): Likewise.
1296         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1297         * common/tdesc.c: Likewise.
1298         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1299         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1300         * features/aarch64-fpu.xml: Add ieee half view.
1301         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1302         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1303         * gdbtypes.h (struct builtin_type): Likewise.
1304         (struct objfile_type): Likewise.
1305
1306 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1307
1308         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1309         typo.
1310         * location.h (string_to_event_location): Likewise.
1311
1312 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1313
1314         GDB 8.3 released.
1315
1316 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1317
1318         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1319         New variable declaration.
1320         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1321         New variable.
1322         (print_one_breakpoint): Use ui_out::test_flags and new global
1323         variable to compute use_fixed_output.
1324         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1325         Remove.
1326         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1327         (mi_multi_location_breakpoint_output_fixed): Remove.
1328         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1329         new variable.
1330         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1331         fix_multi_location_breakpoint_output flag if version >= 3.
1332         * ui-out.h (enum ui_out_flag)
1333         <fix_multi_location_breakpoint_output>: New enumerator.
1334
1335 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1336
1337         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1338
1339 2019-05-10  Tom Tromey  <tromey@adacore.com>
1340
1341         * ada-lang.c (catch_ada_completer): New function.
1342         (_initialize_ada_language): Use it.
1343
1344 2019-05-10  Tom Tromey  <tromey@adacore.com>
1345
1346         * thread.c (print_thread_info): Make "requested_threads" const.
1347         * gdbthread.h (print_thread_info): Make "requested_threads"
1348         const.
1349         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1350         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1351
1352 2019-05-08  Tom Tromey  <tom@tromey.com>
1353
1354         * gdbtypes.c (objfile_type_data): Change type.
1355         (objfile_type, _initialize_gdbtypes): Update.
1356
1357 2019-05-08  Tom Tromey  <tom@tromey.com>
1358
1359         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1360         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1361         (_initialize_dwarf2_frame): Update.
1362
1363 2019-05-08  Tom Tromey  <tom@tromey.com>
1364
1365         * objc-lang.c (objc_objfile_data): Change type.
1366         (find_methods): Update.
1367         (_initialize_objc_lang): Remove.
1368
1369 2019-05-08  Tom Tromey  <tom@tromey.com>
1370
1371         * stabsread.c (rs6000_builtin_type_data): Change type.
1372         (rs6000_builtin_type, _initialize_stabsread): Update.
1373
1374 2019-05-08  Tom Tromey  <tom@tromey.com>
1375
1376         * mips-tdep.c (mips_pdr_data): Remove.
1377         (_initialize_mips_tdep): Update.
1378
1379 2019-05-08  Tom Tromey  <tom@tromey.com>
1380
1381         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1382         (hppa_init_objfile_priv_data, read_unwind_info)
1383         (find_unwind_entry, _initialize_hppa_tdep): Update.
1384
1385 2019-05-08  Tom Tromey  <tom@tromey.com>
1386
1387         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1388         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1389         on obstack.
1390         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1391
1392 2019-05-08  Tom Tromey  <tom@tromey.com>
1393
1394         * mdebugread.c (basic_type_data): Change type.
1395         (basic_type, _initialize_mdebugread): Update.
1396
1397 2019-05-08  Tom Tromey  <tom@tromey.com>
1398
1399         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1400
1401 2019-05-08  Tom Tromey  <tom@tromey.com>
1402
1403         * nto-tdep.c (nto_inferior_data_reg): Change type.
1404         (nto_inferior_data): Update.
1405         (nto_inferior_data_cleanup, nto_new_inferior_data)
1406         (_initialize_nto_tdep): Remove.
1407         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1408
1409 2019-05-08  Tom Tromey  <tom@tromey.com>
1410
1411         * ada-lang.c (struct ada_inferior_data): Add initializers.
1412         (ada_inferior_data): Change type.
1413         (ada_inferior_data_cleanup): Remove.
1414         (get_ada_inferior_data, ada_inferior_exit)
1415         (struct ada_pspace_data): Add initializers, destructor.
1416         (ada_pspace_data_handle): Change type.
1417         (get_ada_pspace_data): Update.
1418         (ada_pspace_data_cleanup): Remove.
1419
1420 2019-05-08  Tom Tromey  <tom@tromey.com>
1421
1422         * coffread.c (struct coff_symfile_info): Add initializers.
1423         (coff_objfile_data_key): Move lower.  Change type.
1424         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1425         Update.
1426         (coff_free_info): Remove.
1427
1428 2019-05-08  Tom Tromey  <tom@tromey.com>
1429
1430         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1431         (fbsd_pspace_data_handle): Move lower.  Change type.
1432         (get_fbsd_pspace_data): Update.
1433         (fbsd_pspace_data_cleanup): Remove.
1434         (_initialize_fbsd_tdep): Update.
1435
1436 2019-05-08  Tom Tromey  <tom@tromey.com>
1437
1438         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1439         (get_ada_tasks_pspace_data): Update.
1440         (ada_tasks_pspace_data_cleanup): Remove.
1441         (_initialize_tasks): Update.
1442         (ada_tasks_inferior_data_handle): Change type.
1443         (get_ada_tasks_inferior_data): Update.
1444         (ada_tasks_inferior_data_cleanup): Remove.
1445         (struct ada_tasks_pspace_data): Add initializers.
1446
1447 2019-05-08  Tom Tromey  <tom@tromey.com>
1448
1449         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1450         * symfile-debug.c (debug_sym_get_probes): Change type.
1451         * stap-probe.c (handle_stap_probe):
1452         (stap_static_probe_ops::get_probes): Change type.
1453         * probe.h (class static_probe_ops) <get_probes>: Change type.
1454         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1455         (parse_probes_in_pspace): Update.
1456         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1457         Update.
1458         (any_static_probe_ops::get_probes): Change type.
1459         * elfread.c (elfread_data): New typedef.
1460         (probe_key): Change type.
1461         (elf_get_probes): Likewise.  Update.
1462         (probe_key_free): Remove.
1463         (_initialize_elfread): Update.
1464         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1465         Change type.
1466         (dtrace_process_dof_probe, dtrace_process_dof)
1467         (dtrace_static_probe_ops::get_probe): Change type.
1468
1469 2019-05-08  Tom Tromey  <tom@tromey.com>
1470
1471         * xcoffread.c (struct xcoff_symfile_info): Rename from
1472         coff_symfile_info.  Add initializers.
1473         (xcoff_objfile_data_key): Move lower.  Change type.
1474         (XCOFF_DATA): Rewrite.
1475         (xcoff_free_info): Remove.
1476         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1477         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1478         (xcoff_initial_scan): Update.
1479
1480 2019-05-08  Tom Tromey  <tom@tromey.com>
1481
1482         * solib-svr4.c (struct svr4_info): Add initializers and
1483         destructor.
1484         <probes_table>: Now an htab_up.
1485         (solib_svr4_pspace_data): Change type.
1486         (free_probes_table): Simplify.
1487         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1488         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1489         (probes_table_remove_objfile_probes, register_solib_event_probe)
1490         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1491         (_initialize_svr4_solib): Update.
1492
1493 2019-05-08  Tom Tromey  <tom@tromey.com>
1494
1495         * remote.c (remote_pspace_data): Change type.
1496         (remote_pspace_data_cleanup): Remove.
1497         (get_remote_exec_file, set_pspace_remote_exec_file)
1498         (_initialize_remote): Update.
1499
1500 2019-05-08  Tom Tromey  <tom@tromey.com>
1501
1502         * breakpoint.c (breakpoint_objfile_key): Change type.
1503         (get_breakpoint_objfile_data): Update.
1504         (free_breakpoint_objfile_data): Remove.
1505         (_initialize_breakpoint): Update.
1506
1507 2019-05-08  Tom Tromey  <tom@tromey.com>
1508
1509         * linux-tdep.c (struct linux_info): Add initializers.
1510         (linux_inferior_data): Move.  Change type.
1511         (invalidate_linux_cache_inf): Update.
1512         (linux_inferior_data_cleanup): Remove.
1513         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1514
1515 2019-05-08  Tom Tromey  <tom@tromey.com>
1516
1517         * auxv.c (auxv_inferior_data): Move.  Change type.
1518         (auxv_inferior_data_cleanup): Remove.
1519         (invalidate_auxv_cache_inf): Rewrite.
1520         (get_auxv_inferior_data, _initialize_auxv): Update.
1521
1522 2019-05-08  Tom Tromey  <tom@tromey.com>
1523
1524         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1525         (symfile_debug_objfile_data_key): Change type.
1526         (symfile_debug_installed, debug_qf_has_symbols)
1527         (debug_qf_find_last_source_symtab)
1528         (debug_qf_forget_cached_source_info)
1529         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1530         (debug_qf_print_stats, debug_qf_dump)
1531         (debug_qf_expand_symtabs_for_function)
1532         (debug_qf_expand_all_symtabs)
1533         (debug_qf_expand_symtabs_with_fullname)
1534         (debug_qf_map_matching_symbols)
1535         (debug_qf_expand_symtabs_matching)
1536         (debug_qf_find_pc_sect_compunit_symtab)
1537         (debug_qf_map_symbol_filenames)
1538         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1539         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1540         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1541         (debug_sym_read_linetable, debug_sym_relocate): Update.
1542         (symfile_debug_free_objfile): Remove.
1543         (install_symfile_debug_logging, _initialize_symfile_debug):
1544         Update.
1545
1546 2019-05-08  Tom Tromey  <tom@tromey.com>
1547
1548         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1549         allocate_on_obstack.
1550         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1551         (get_dwarf2_per_objfile): Update.
1552         (set_dwarf2_per_objfile): Remove.
1553         (dwarf2_has_info, dwarf2_get_section_info): Update.
1554         (dwarf2_free_objfile): Remove.
1555         (_initialize_dwarf2_read): Update.
1556
1557 2019-05-08  Tom Tromey  <tom@tromey.com>
1558
1559         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1560         initializers.
1561         <unsupported_script_warning_printed,
1562         script_not_found_warning_printed>: Now bool.
1563         (auto_load_pspace_data): Change type.
1564         (~auto_load_pspace_info): Rename from
1565         auto_load_pspace_data_cleanup.
1566         (get_auto_load_pspace_data, init_loaded_scripts_info)
1567         (clear_section_scripts, maybe_print_unsupported_script_warning)
1568         (maybe_print_script_not_found_warning, _initialize_auto_load):
1569         Update.
1570
1571 2019-05-08  Tom Tromey  <tom@tromey.com>
1572
1573         * objfiles.c (objfile_pspace_info): Add destructor and
1574         initializers.
1575         (objfiles_pspace_data): Change type.
1576         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1577         (get_objfile_pspace_data): Update.
1578         (objfiles_bfd_data): Change type.
1579         (get_objfile_bfd_data): Update.
1580         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1581
1582 2019-05-08  Tom Tromey  <tom@tromey.com>
1583
1584         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1585         Change type.
1586         (get_catch_syscall_inferior_data): Update.
1587         (catch_syscall_inferior_data_cleanup): Remove.
1588         (_initialize_break_catch_syscall): Update.
1589
1590 2019-05-08  Tom Tromey  <tom@tromey.com>
1591
1592         * inflow.c (struct terminal_info): Add destructor and
1593         initializers.
1594         (inflow_inferior_data): Change type.
1595         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1596         (get_inflow_inferior_data, inflow_inferior_exit)
1597         (swap_terminal_info, _initialize_inflow): Update.
1598
1599 2019-05-08  Tom Tromey  <tom@tromey.com>
1600
1601         * target-dcache.c (target_dcache_cleanup): Remove.
1602         (target_dcache_aspace_key): Change type.
1603         (target_dcache_init_p, target_dcache_invalidate)
1604         (target_dcache_get, target_dcache_get_or_init)
1605         (_initialize_target_dcache): Update.
1606         * dcache.h (struct dcache_deleter): New.
1607
1608 2019-05-08  Tom Tromey  <tom@tromey.com>
1609
1610         * symtab.c (struct symbol_cache): Add destructor and
1611         initializers.
1612         (symbol_cache_key): Move.  Change type.
1613         (make_symbol_cache, free_symbol_cache): Remove.
1614         (get_symbol_cache): Update.
1615         (symbol_cache_cleanup): Remove.
1616         (ALL_PSPACES, symbol_cache_flush)
1617         (maintenance_print_symbol_cache)
1618         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1619         Update.
1620
1621 2019-05-08  Tom Tromey  <tom@tromey.com>
1622
1623         * symtab.c (struct main_info): Add destructor and initializers.
1624         (main_progspace_key): Move.  Change type.
1625         (get_main_info): Update.
1626         (main_info_cleanup): Remove.
1627         (_initialize_symtab): Update.
1628
1629 2019-05-08  Tom Tromey  <tom@tromey.com>
1630
1631         * registry.h (DECLARE_REGISTRY): Define the _key class.
1632
1633 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1634
1635         * NEWS: Merge two 'New commands' sections.
1636
1637 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1638
1639         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1640         parameter and use Ada language definition instead.
1641         (ada_val_print_ptr): Remove unused language parameter.
1642         (ada_val_print_num): Remove language parameter and use Ada language
1643         definition instead.
1644         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1645         parameter.
1646         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1647         parameter and use Ada language definition instead.
1648         (ada_val_print_1): Update all ada_val_print_xxx calls.
1649         Remove language parameter.
1650         (ada_val_print): Update ada_val_print_1 call.
1651
1652 2019-05-08  Tom Tromey  <tromey@adacore.com>
1653
1654         * remote.c (remote_hw_watchpoint_limit)
1655         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1656         Now static.
1657
1658 2019-05-08  Tom Tromey  <tromey@adacore.com>
1659
1660         * maint.c (_initialize_maint_cmds): Move initialization code to
1661         remote.c.
1662         (watchdog, show_watchdog): Move to remote.c.
1663         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1664         "watchdog" static.
1665         (_initialize_remote): Move initialization code from maint.c.
1666         * defs.h (watchdog): Don't declare.
1667
1668 2019-05-08  Tom Tromey  <tromey@adacore.com>
1669
1670         * tui/tui-interp.c: Include main.h.
1671         * interps.c: Include main.h.
1672         * main.h (interpreter_p): Declare.
1673         * defs.h (interpreter_p): Don't declare.
1674
1675 2019-05-08  Tom Tromey  <tromey@adacore.com>
1676
1677         * dwarf2loc.c: Include dwarf2read.h.
1678         * defs.h (read_unsigned_leb128): Don't declare.
1679         * dwarf2read.h (read_unsigned_leb128): Declare.
1680
1681 2019-05-08  Tom Tromey  <tromey@adacore.com>
1682
1683         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1684         method.
1685
1686 2019-05-08  Tom Tromey  <tromey@adacore.com>
1687
1688         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1689         when no wrap column is set.
1690
1691 2019-05-08  Tom Tromey  <tromey@adacore.com>
1692
1693         * c-lang.c (c_get_string): Handle non-C-style arrays.
1694
1695 2019-05-08  Tom Tromey  <tromey@adacore.com>
1696
1697         * typeprint.c (print_offset_data::update): Print the bit offset,
1698         not the number of bits remaining.
1699
1700 2019-05-08  Tom Tromey  <tromey@adacore.com>
1701
1702         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1703         padding at end of comment.
1704
1705 2019-05-08  Tom Tromey  <tromey@adacore.com>
1706
1707         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1708         Compare main types.
1709
1710 2019-05-06  Tom Tromey  <tom@tromey.com>
1711
1712         * common/scoped_mmap.c: Include common-defs.h.
1713         * common/scoped_mmap.h: Don't include config.h.
1714
1715 2019-05-04  Tom Tromey  <tom@tromey.com>
1716
1717         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1718         (struct aarch64_call_info): Add initializers.
1719         <si>: Now a std::vector.
1720         (pass_on_stack, aarch64_push_dummy_call): Update.
1721
1722 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1723             Tom Tromey  <tom@tromey.com>
1724
1725         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1726         (ppc_threads): Now a std::vector.  Now static.
1727         (hwdebug_find_thread_points_by_tid)
1728         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1729         Update.
1730
1731 2019-05-04  Tom Tromey  <tom@tromey.com>
1732
1733         * arc-tdep.c (arc_tdesc_init): Return bool.
1734
1735 2019-05-04  Tom Tromey  <tom@tromey.com>
1736
1737         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1738         Use gdb_assert_not_reached.
1739
1740 2019-05-04  Tom Tromey  <tom@tromey.com>
1741
1742         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1743         "false".
1744
1745 2019-05-04  Tom Tromey  <tom@tromey.com>
1746
1747         * arc-tdep.c (arc_tdesc_init): Use bool.
1748
1749 2019-05-04  Tom Tromey  <tom@tromey.com>
1750
1751         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1752
1753 2019-05-04  Tom Tromey  <tom@tromey.com>
1754
1755         * cli/cli-cmds.c (valid_command_p): Return bool.
1756
1757 2019-05-04  Tom Tromey  <tom@tromey.com>
1758
1759         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1760         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1761
1762 2019-05-04  Raul Tambre  <raul@tambre.ee>
1763
1764         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1765         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1766         operator for comparison.
1767
1768 2019-05-04  Tom Tromey  <tom@tromey.com>
1769
1770         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1771         (lookup_partial_symbol, print_partial_symbols)
1772         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1773         (psymbol_compare): Update.
1774         (add_psymbol_to_bcache): Clear the entire psymbol.
1775         (maintenance_check_psymtabs): Update.
1776         * psympriv.h (struct partial_symbol): Don't derive from
1777         general_symbol_info.
1778         <obj_section, unrelocated_address, address,
1779         set_unrelocated_address>: Update.
1780         <ginfo>: New member.
1781         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1782         (debug_names::write_psymbols): Update.
1783
1784 2019-05-04  Tom de Vries  <tdevries@suse.de>
1785
1786         * contrib/cc-with-tweaks.sh: Support -n arg.
1787
1788 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1789
1790         * corelow.c (core_target::detach): Ensure frame cache and
1791         register caches are cleared.
1792         inferior.c (exit_inferior_1): Likewise.
1793
1794 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1795             Tom Tromey  <tom@tromey.com>
1796
1797         * dictionary.c (collate_pending_symbols_by_language): Remove
1798         "struct" from foreach.
1799         * symtab.c (lookup_global_symbol_from_objfile)
1800         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1801         foreach.
1802         * ser-tcp.c (net_open): Remove "struct" from foreach.
1803         * objfiles.c (objfile_relocate, objfile_rebase)
1804         (objfile_has_symbols): Remove "struct" from foreach.
1805         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1806         from foreach.
1807         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1808         foreach.
1809         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1810         "struct" from foreach.
1811         * ada-lang.c (create_excep_cond_exprs)
1812         (ada_exception_catchpoint_cond_string): Remove "struct" from
1813         foreach.
1814
1815 2019-05-03  Tom Tromey  <tromey@adacore.com>
1816
1817         * ada-exp.y (convert_char_literal): Check suffix of each
1818         enumerator.
1819
1820 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1821
1822         PR ada/21406:
1823         * ada-exp.y (yywrap): Don't define.
1824         * ada-lex.l (%option): Add noyywrap
1825         (yywrap): Remove.
1826
1827 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1828
1829         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1830         _WIN32_WINNT to the XP level, unless already defined to a higher
1831         level.
1832
1833         * unittests/parse-connection-spec-selftests.c:
1834         * ser-tcp.c:
1835         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1836         override.
1837
1838         * symfile.c (find_separate_debug_file): Remove colon from the
1839         drive spec of DOS/Windows file names of the target, so that the
1840         file name produced from DEBUGDIR and the target's directory will
1841         be valid on DOS/Windows systems.
1842
1843 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1844
1845         * rust-lang.c (val_print_struct): Handle printing structures
1846         containing strings.
1847
1848 2019-05-02  Tom Tromey  <tromey@adacore.com>
1849
1850         * valarith.c (_initialize_valarith): Remove.
1851
1852 2019-05-01  Tom Tromey  <tromey@adacore.com>
1853
1854         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1855         bitfields.
1856
1857 2019-05-01  Tom Tromey  <tromey@adacore.com>
1858
1859         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1860         for big-endian copies.
1861
1862 2019-04-30  Ali Tamur  <tamur@google.com>
1863         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1864         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1865         (read_3_bytes): New function.
1866
1867 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1868
1869         * windows-nat.c (main_thread_id): Delete.
1870         (handle_output_debug_string): Replace main_thread_id by
1871         current_event.dwThreadId.
1872         (fake_create_process): Likewise.
1873         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1874         Do not set main_thread_id.
1875         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1876         current_event.dwThreadId.
1877         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1878
1879 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1880
1881         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1882         Use current_event.dwThreadId instead of main_thread_id.
1883
1884 2019-04-30  Tom Tromey  <tromey@adacore.com>
1885
1886         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1887         (create_excep_cond_exprs): Iterate over program spaces.
1888         (ada_exception_catchpoint_cond_string): Examine all minimal
1889         symbols for exception types.
1890
1891 2019-04-30  Tom Tromey  <tromey@adacore.com>
1892
1893         PR c++/24470:
1894         * dwarf2read.c (process_structure_scope): Handle case where type
1895         has template parameters but no symbol was created.
1896
1897 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1898             Chris January  <chris.january@arm.com>
1899
1900         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1901         qualifier.
1902         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1903
1904 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1905
1906         * f-typeprint.c (f_print_type): Update rules for printing
1907         whitespace.
1908         (f_type_print_varspec_suffix): Likewise.
1909
1910 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1911             Chris January  <chris.january@arm.com>
1912
1913         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1914         function arguments.
1915
1916 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1917
1918         * f-lang.c (build_fortran_types): Change name of void type to
1919         lower case.
1920         * f-typeprint.c (f_type_print_base): Print the name of the void
1921         type, rather than a fixed string.
1922         * f-valprint.c (f_decorations): Use lower case void string.
1923
1924 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1925             Chris January  <chris.january@arm.com>
1926
1927         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1928         types for Fortran.
1929
1930 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1931             Chris January  <chris.january@arm.com>
1932             David Lecomber  <david.lecomber@arm.com>
1933
1934         * f-exp.y (BINOP_INTRINSIC): New token.
1935         (exp): New parser rule handling BINOP_INTRINSIC.
1936         (f77_keywords): Add new builtin procedures.
1937         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1938         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1939         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1940         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1941         (print_unop_subexp_f): New function.
1942         (print_binop_subexp_f): New function.
1943         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1944         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1945         (dump_subexp_body_f): Likewise.
1946         (operator_check_f): Likewise.
1947         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1948         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1949
1950 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1951
1952         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1953         UNOP_KIND.
1954         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1955         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1956         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1957         (operator_length_f): New fuction.
1958         (print_subexp_f): New function.
1959         (op_name_f): New function.
1960         (dump_subexp_body_f): New function.
1961         (operator_check_f): New function.
1962         (exp_descriptor_f): Replace standard expression handling functions
1963         with new functions.
1964         * gdb/fortran-operator.def: New file.
1965         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1966         * gdb/std-operator.def: Remove UNOP_KIND.
1967
1968 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1969
1970         * std-operator.def: Remove unbalanced, stray double quote
1971         character.
1972
1973 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1974             Chris January  <chris.january@arm.com>
1975             Daniel Everett  <daniel.everett@arm.com>
1976             Nick Forrington  <nick.forrington@arm.com>
1977             Richard Bunt  <richard.bunt@arm.com>
1978
1979         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1980         of depth when printing anonymous structs or unions.
1981         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1982         Don't print either the top-level value, or the children if the
1983         max-depth is exceeded.
1984         (ppscm_print_children): When printing the key of a map, allow one
1985         extra level of depth.
1986         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1987         print either the top-level value, or the children if the max-depth
1988         is exceeded.
1989         (print_children): When printing the key of a map, allow one extra
1990         level of depth.
1991         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1992         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1993         (user_print_options): Initialise max_depth field.
1994         (val_print_scalar_or_string_type_p): New function.
1995         (val_print): Check to see if the max depth has been reached.
1996         (val_print_check_max_depth): Define new function.
1997         (show_print_max_depth): New function.
1998         (_initialize_valprint): Add 'print max-depth' option.
1999         * valprint.h (struct value_print_options) <max_depth>: New field.
2000         (val_print_check_max_depth): Declare new function.
2001         * NEWS: Document new feature.
2002
2003 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2004
2005         * ada-lang.c (ada_language_defn): Initialise new field.
2006         * c-lang.c (c_is_string_type_p): New function.
2007         (c_language_defn): Initialise new field.
2008         (cplus_language_defn): Initialise new field.
2009         (asm_language_defn): Initialise new field.
2010         (minimal_language_defn): Initialise new field.
2011         * c-lang.h (c_is_string_type_p): Declare new function.
2012         * d-lang.c (d_language_defn): Initialise new field.
2013         * f-lang.c (f_is_string_type_p): New function.
2014         (f_language_defn): Initialise new field.
2015         * go-lang.c (go_is_string_type_p): New function.
2016         (go_language_defn): Initialise new field.
2017         * language.c (default_is_string_type_p): New function.
2018         (unknown_language_defn): Initialise new field.
2019         (auto_language_defn): Initialise new field.
2020         * language.h (struct language_defn) <la_is_string_type_p>: New
2021         member variable.
2022         (default_is_string_type_p): Declare new function.
2023         * m2-lang.c (m2_language_defn): Initialise new field.
2024         * objc-lang.c (objc_language_defn): Initialise new field.
2025         * opencl-lang.c (opencl_language_defn): Initialise new field.
2026         * p-lang.c (pascal_is_string_type_p): New function.
2027         (pascal_language_defn): Initialise new field.
2028         * rust-lang.c (rust_is_string_type_p): New function.
2029         (rust_language_defn): Initialise new field.
2030
2031 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2032
2033         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2034         New field.
2035         * ada-lang.c (ada_language_defn): Initialise new field.
2036         * c-lang.c (c_language_defn): Likewise.
2037         (cplus_language_defn): Likewise.
2038         (asm_language_defn): Likewise.
2039         (minimal_language_defn): Likewise.
2040         * d-lang.c (d_language_defn): Likewise.
2041         * f-lang.c (f_language_defn): Likewise.
2042         * go-lang.c (go_language_defn): Likewise.
2043         * language.c (unknown_language_defn): Likewise.
2044         (auto_language_defn): Likewise.
2045         * m2-lang.c (m2_language_defn): Likewise.
2046         * objc-lang.c (objc_language_defn): Likewise.
2047         * opencl-lang.c (opencl_language_defn): Likewise.
2048         * p-lang.c (pascal_language_defn): Likewise.
2049         * rust-lang.c (rust_language_defn): Likewise.
2050
2051 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2052
2053         * ada-lang.c (ada_is_character_type): Change return type to bool.
2054         (ada_is_string_type): Likewise.
2055         * ada-lang.h (ada_is_character_type): Update declaration
2056         (ada_is_string_type): Likewise.
2057
2058 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2059
2060         Support style in 'frame|thread apply'
2061
2062         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2063         * record.c (record_start, record_stop): Update callers of
2064         execute_command_to_string with false.
2065         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2066         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2067         methods.
2068         (class string_file): New constructor with term_out parameter.
2069         Override methods term_out and can_emit_style_escape.  New member
2070         term_out.
2071         (class stdio_file): Override can_emit_style_escape.
2072         (class tee_file): Override term_out and can_emit_style_escape.
2073         * utils.h (can_emit_style_escape): Remove.
2074         * utils.c (can_emit_style_escape): Likewise.
2075         Update all callers of can_emit_style_escape (SOMESTREAM) to
2076         SOMESTREAM->can_emit_style_escape.
2077         * source-cache.c (source_cache::get_source_lines): Likewise.
2078         * stack.c (frame_apply_command_count): Call execute_command_to_string
2079         passing the term_out characteristic of the current gdb_stdout.
2080         * thread.c (thr_try_catch_cmd): Likewise.
2081         * top.c (execute_command_to_string): pass term_out parameter
2082         to construct the string_file for the command output.
2083         * ui-file.c (term_cli_styling): New function (most code moved
2084         from utils.c can_emit_style_escape).
2085         (string_file::string_file, string_file::can_emit_style_escape,
2086         stdio_file::can_emit_style_escape, tee_file::term_out,
2087         tee_file::can_emit_style_escape): New functions.
2088
2089 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2090
2091         * NEWS: Mention the new set|show may-call-functions.
2092         * infcall.c (may_call_functions_p): New variable.
2093         (show_may_call_functions_p): New function.
2094         (call_function_by_hand_dummy): Throws an error if not
2095         may-call-functions.
2096         (_initialize_infcall): Call add_setshow_boolean_cmd for
2097         may-call-functions.
2098
2099 2019-04-25  Keith Seitz  <keiths@redhat.com>
2100
2101         PR c++/24367
2102         * cp-support.c (inspect_type): Don't attempt substitutions
2103         of symbol with the same name.
2104
2105 2019-04-25  Tom Tromey  <tromey@adacore.com>
2106
2107         PR gdb/24475:
2108         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2109         static.
2110
2111 2019-04-25  Tom Tromey  <tromey@adacore.com>
2112
2113         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2114         rvalue reference.
2115         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2116         (gdb_xml_parser::parse): Use std::move.
2117         * python/python-internal.h (gdbpy_convert_exception): Take a const
2118         reference.
2119         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2120         std::move.
2121         * python/py-utils.c (gdbpy_convert_exception): Take a const
2122         reference.
2123         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2124         Use std::move.
2125         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2126         Use std::move.
2127         * mi/mi-main.c (mi_print_exception): Take a const reference.
2128         * main.c (handle_command_errors): Take a const reference.
2129         * linespec.c (parse_linespec): Use std::move.
2130         * infcall.c (run_inferior_call): Use std::move.
2131         (call_function_by_hand_dummy): Use std::move.
2132         * exec.c (try_open_exec_file): Use std::move.
2133         * exceptions.h (exception_print, exception_fprintf)
2134         (exception_print_same): Update.
2135         * exceptions.c (print_exception, exception_print)
2136         (exception_fprintf, exception_print_same): Change parameters to
2137         const reference.
2138         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2139         * common/new-op.c: Use std::move.
2140         * common/common-exceptions.h (struct gdb_exception): Add move
2141         constructor.
2142         (struct gdb_exception_error, struct gdb_exception_quit, struct
2143         gdb_quit_bad_alloc): Change constructor to move constructor.
2144         (throw_exception): Change parameter to rvalue reference.
2145         * common/common-exceptions.c (throw_exception): Take rvalue
2146         reference.
2147         * cli/cli-interp.c (safe_execute_command): Use std::move.
2148         * breakpoint.c (insert_bp_location, location_to_sals): Use
2149         std::move.
2150
2151 2019-04-25  Tom Tromey  <tromey@adacore.com>
2152
2153         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2154         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2155         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2156         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2157         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2158         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2159         guile/scm-value.c: Use unpack.
2160         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2161         gdbscm_gdb_exception.
2162         (gdbscm_throw_gdb_exception): Likewise.
2163         (struct gdbscm_gdb_exception): New.
2164         (unpack): New function.
2165         (gdbscm_wrap): Use unpack.
2166
2167 2019-04-25  Tom Tromey  <tromey@adacore.com>
2168
2169         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2170         (gdb_rl_callback_handler): Use std::move.
2171         * common/common-exceptions.h (struct gdb_exception): Add move
2172         assignment operator.
2173         (throw_exception_sjlj): Change "exception" to const reference.
2174         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2175         (throw_exception_sjlj): Change "exception" to const reference.
2176
2177 2019-04-25  Tom Tromey  <tromey@adacore.com>
2178
2179         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2180         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2181         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2182         Update.
2183         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2184         Update.
2185         * mi/mi-interp.c (mi_interp::exec): Update.
2186         * linespec.c (parse_linespec): Update.
2187         * infcall.c (run_inferior_call): Update.
2188         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2189         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2190         (gdbscm_lookup_global_symbol): Update.
2191         * guile/scm-param.c (gdbscm_parameter_value): Update.
2192         * guile/scm-frame.c (gdbscm_frame_read_register)
2193         (gdbscm_frame_read_var): Update.
2194         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2195         * exec.c (try_open_exec_file): Update.
2196         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2197         (gdb_rl_callback_handler): Update.
2198         * common/common-exceptions.h (exception_none): Don't declare.
2199         * common/common-exceptions.c (exception_none): Don't define.
2200         (struct catcher) <exception>: Update.
2201         * cli/cli-interp.c (safe_execute_command): Update.
2202         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2203
2204 2019-04-25  Ali Tamur  <tamur@google.com>
2205
2206         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2207         (read_attribute_value): Likewise.
2208         (dwarf2_read_addr_index): Update comment.
2209         (read_str_index): Add DW_FORM_strx.
2210         (dwarf2_string_attr): Likewise.
2211         (dwarf2_const_value_attr): Likewise.
2212         (dump_die_shallow): Likewise.
2213         (dwarf2_fetch_constant_bytes): Likewise.
2214         (skip_form_bytes): Likewise.
2215         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2216
2217 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2218
2219         PR corefiles/11608
2220         PR corefiles/18187
2221         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2222         OFFSET.  Verify if current mapping contains an ELF header.
2223         (linux_find_memory_regions_full): Adjust call to
2224         dump_mapping_p.
2225
2226 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2227             Kang Li <kanglictf@gmail.com>
2228
2229         PR gdb/21600
2230
2231         * dwarf2-frame.c (read_initial_length): Be consistent about using
2232         unsigned representation of length.
2233         (decode_frame_entry_1): Likewise.  Check for wraparound of
2234         end pointer as well as buffer overflow.
2235
2236 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2237
2238         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2239         "vq".
2240
2241 2019-04-24  Tom Tromey  <tromey@adacore.com>
2242
2243         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2244
2245 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2246
2247         * s12z-tdep.c (s12z_unwind_pc): Delete.
2248         (s12z_unwind_sp): Delete.
2249         (s12z_gdbarch_init): Don't register deleted functions with
2250         gdbarch.
2251
2252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2253
2254         * rl78-tdep.c (rl78_unwind_sp): Delete.
2255         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2256
2257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2258
2259         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2260         (xstormy16_unwind_pc): Delete.
2261         (xstormy16_dummy_id): Delete.
2262         (xstormy16_gdbarch_init): Don't register deleted functions with
2263         gdbarch.
2264
2265 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2266
2267         * vax-tdep.c (vax_unwind_pc): Delete.
2268         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2269
2270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2271
2272         * v850-tdep.c (v850_unwind_sp): Delete.
2273         (v850_unwind_pc): Delete.
2274         (v850_dummy_id): Delete.
2275         (v850_gdbarch_init): Don't register deleted functions with
2276         gdbarch.
2277
2278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2279
2280         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2281         (tilegx_unwind_pc): Delete.
2282         (tilegx_unwind_dummy_id): Delete.
2283         (tilegx_gdbarch_init): Don't register deleted functions with
2284         gdbarch.
2285
2286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2287
2288         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2289         (tic6x_dummy_id): Delete.
2290         (tic6x_gdbarch_init): Don't register deleted functions with
2291         gdbarch.
2292
2293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2294
2295         * sparc-tdep.c (sparc_unwind_pc): Delete.
2296         (sparc32_gdbarch_init): Don't register deleted function with
2297         gdbarch.
2298
2299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2300
2301         * sh-tdep.c (sh_unwind_sp): Delete.
2302         (sh_unwind_pc): Delete.
2303         (sh_dummy_id): Delete.
2304         (sh_gdbarch_init): Don't register deleted functions with
2305         gdbarch.
2306
2307 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2308
2309         * score-tdep.c (score_unwind_sp): Delete.
2310         (score_unwind_pc): Delete.
2311         (score_dummy_id): Delete.
2312         (score_gdbarch_init): Don't register deleted functions with
2313         gdbarch.
2314
2315 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2316
2317         * rx-tdep.c (rx_unwind_pc): Delete.
2318         (rx_unwind_sp): Delete.
2319         (rx_dummy_id): Delete.
2320         (rx_gdbarch_init): Don't register deleted functions with
2321         gdbarch.  Update comment.
2322
2323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2324
2325         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2326         (rs6000_dummy_id): Delete.
2327         (rs6000_gdbarch_init): Don't register deleted functions with
2328         gdbarch.
2329
2330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2331
2332         * or1k-tdep.c (or1k_dummy_id): Delete.
2333         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2334
2335 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2336
2337         * nios2-tdep.c (nios2_dummy_id): Delete.
2338         (nios2_unwind_sp): Delete.
2339         (nios2_gdbarch_init): Don't register deleted functions with
2340         gdbarch.
2341
2342 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2343
2344         * nds32-tdep.c (nds32_dummy_id): Delete.
2345         (nds32_unwind_pc): Delete.
2346         (nds32_unwind_sp): Delete.
2347         (nds32_gdbarch_init): Don't register deleted functions with
2348         gdbarch.
2349
2350 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2351
2352         * msp430-tdep.c (msp430_unwind_pc): Delete.
2353         (msp430_unwind_sp): Delete.
2354         (msp430_dummy_id): Delete.
2355         (msp430_gdbarch_init): Don't register deleted functions with
2356         gdbarch.
2357
2358 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2359
2360         * moxie-tdep.c (moxie_unwind_sp): Delete.
2361         (moxie_unwind_pc): Delete.
2362         (moxie_dummy_id): Delete.
2363         (moxie_gdbarch_init): Don't register deleted functions with
2364         gdbarch.
2365
2366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2367
2368         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2369         (mn10300_unwind_pc): Delete.
2370         (mn10300_unwind_sp): Delete.
2371         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2372         mn10300_unwind_sp.
2373         (mn10300_frame_unwind_init): Don't register deleted functions with
2374         gdbarch.
2375
2376 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2377
2378         * mep-tdep.c (mep_unwind_pc): Delete.
2379         (mep_unwind_sp): Delete.
2380         (mep_dummy_id): Delete.
2381         (mep_gdbarch_init): Don't register deleted functions with
2382         gdbarch.
2383
2384 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2385
2386         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2387         (m68hc11_unwind_sp): Delete.
2388         (m68hc11_gdbarch_init): Don't register deleted functions with
2389         gdbarch.
2390
2391 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2392
2393         * m32r-tdep.c (m32r_unwind_sp): Delete.
2394         (m32r_unwind_pc): Delete.
2395         (m32r_dummy_id): Delete.
2396         (m32r_gdbarch_init): Don't register deleted functions with
2397         gdbarch.
2398
2399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2400
2401         * m32c-tdep.c (m32c_unwind_pc): Delete.
2402         (m32c_unwind_sp): Delete.
2403         (m32c_dummy_id): Delete.
2404         (m32c_gdbarch_init): Don't register deleted functions with
2405         gdbarch.
2406
2407 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2408
2409         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2410         (lm32_unwind_pc): Delete.
2411         (lm32_dummy_id): Delete.
2412         (lm32_gdbarch_init): Don't register deleted functions with
2413         gdbarch.
2414
2415 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2416
2417         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2418         (iq2000_unwind_pc): Delete.
2419         (iq2000_dummy_id): Delete.
2420         (iq2000_gdbarch_init): Don't register deleted functions with
2421         gdbarch.
2422
2423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2424
2425         * nds32-tdep.c (nds32_type_align): Delete.
2426         (nds32_push_dummy_call): Use type_align instead.
2427
2428 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2429
2430         * arm-tdep.c (arm_type_align): Only handle vector override case.
2431         (arm_push_dummy_call): Use type_align.
2432         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2433
2434 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2435
2436         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2437         case.
2438         (pass_on_stack): Use type_align.
2439         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2440         function.
2441
2442 2019-04-23  Tom Tromey  <tromey@adacore.com>
2443
2444         * dwarf2read.c (line_header::file_name_at): Remove unused
2445         overload.
2446
2447 2019-04-23  Tom de Vries  <tdevries@suse.de>
2448
2449         PR gdb/24438
2450         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2451         invocation.
2452
2453
2454 2019-03-27  Ali Tamur  <tamur@google.com>
2455
2456         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2457         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2458         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2459         (dwarf_expr_context::get_addr_index): Likewise
2460         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2461         (symbol_needs_eval_context::get_addr_index): Likewise
2462         (disassemble_dwarf_expression): Add DW_OP_addrx
2463         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2464         (read_cutu_die_from_dwo): Update comment
2465         (skip_one_die): Add DW_FORM_addrx
2466         (read_attribute_value): Likewise
2467         (var_decode_location): Add DW_OP_addrx
2468         (dwarf2_const_value_attr): Add DW_FORM_addrx
2469         (dump_die_shallow): Likewise
2470         (dwarf2_fetch_constant_bytes): Likewise
2471         (decode_locdesc): Add DW_OP_addrx
2472         (skip_form_bytes): Add DW_FORM_addrx
2473
2474 2019-04-22  Ali Tamur  <tamur@google.com>
2475
2476         * MAINTAINERS (Write After Approval): Add self.
2477
2478 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2479
2480         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2481         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2482         (open_symbol_file_object): Likewise.
2483         (svr4_default_sos): Add info parameter.
2484         (svr4_read_so_list): Likewise.
2485         (svr4_current_sos_direct): Adjust functions calls to pass down
2486         info.
2487         (svr4_current_sos_1): Add info parameter.
2488         (svr4_current_sos): Call get_svr4_info, pass info down to
2489         svr4_current_sos_1.
2490         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2491         get_svr4_info.
2492         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2493         get_svr4_info.
2494         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2495         to get_svr4_info.
2496         (probes_table_remove_objfile_probes): Likewise.
2497         (register_solib_event_probe): Add info parameter.
2498         (solist_update_incremental): Pass info parameter down to
2499         svr4_read_so_list.
2500         (disable_probes_interface): Add info parameter.
2501         (svr4_handle_solib_event): Pass current_program_space to
2502         get_svr4_info.  Adjust disable_probes_interface cleanup.
2503         (svr4_create_probe_breakpoints): Add info parameter, pass it
2504         down to register_solib_event_probe.
2505         (svr4_create_solib_event_breakpoints): Add info parameter,
2506         pass it down to svr4_create_probe_breakpoints.
2507         (enable_break): Pass info down to
2508         svr4_create_solib_event_breakpoints.
2509         (svr4_solib_create_inferior_hook): Pass current_program_space to
2510         get_svr4_info.
2511         (svr4_clear_solib): Likewise.
2512
2513 2019-04-22  Pedro Alves  <palves@redhat.com>
2514
2515         * solib-svr4.c (svr4_free_objfile_observer): New.
2516         (probe_and_action::objfile): New field.
2517         (probes_table_htab_remove_objfile_probes)
2518         (probes_table_remove_objfile_probes): New functions.
2519         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2520         in the new probe_and_action.  Don't store the probe in 'lookup'.
2521         (svr4_create_probe_breakpoints): Pass objfile to
2522         register_solib_event_probe.
2523         (_initialize_svr4_solib): Register a free_objfile observer.
2524
2525 2019-04-19  Tom Tromey  <tom@tromey.com>
2526
2527         * common/queue.h: Remove.
2528
2529 2019-04-19  Tom Tromey  <tom@tromey.com>
2530
2531         * event-loop.c: Don't include "common/queue.h".
2532
2533 2019-04-19  Tom Tromey  <tom@tromey.com>
2534
2535         * remote.c (remote_target): Use delete.
2536         * remote-notif.h: Include <list>, not "common/queue.h".
2537         (notif_client_p): Remove typedef.
2538         (remote_notif_state): Add constructor, destructor, initializer.
2539         <notif_queue>: Now a std::list.
2540         (remote_notif_state_xfree): Don't declare.
2541         * remote-notif.c (remote_notif_process, handle_notification)
2542         (remote_notif_state_allocate): Update.
2543         (~remote_notif_state): Rename from remote_notif_state_xfree.
2544
2545 2019-04-19  Tom Tromey  <tom@tromey.com>
2546
2547         * symfile.c (reread_symbols): Update.
2548         * objfiles.c (objfile_register_static_link)
2549         (objfile_lookup_static_link): Update
2550         (~objfile) Don't delete static_links.
2551         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2552
2553 2019-04-19  Tom Tromey  <tom@tromey.com>
2554
2555         * type-stack.h (struct type_stack) <insert>: Constify string.
2556         * type-stack.c (type_stack::insert): Constify string.
2557         * gdbtypes.h (lookup_template_type): Update.
2558         (address_space_name_to_int): Update.
2559         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2560         const.
2561         (lookup_template_type): Make name const.
2562         * c-exp.y: Update rules.
2563         (lex_one_token, classify_name, classify_inner_name)
2564         (c_print_token): Update.
2565         * p-exp.y: Update rules.
2566         (yylex): Update.
2567         * f-exp.y: Update rules.
2568         (yylex): Update.
2569         * d-exp.y: Update rules.
2570         (lex_one_token, classify_name, classify_inner_name): Update.
2571         * parse.c (write_dollar_variable, copy_name): Return std::string.
2572         * parser-defs.h (copy_name): Change return type.
2573         * m2-exp.y: Update rules.
2574         (yylex): Update.
2575         * go-exp.y (lex_one_token): Update.
2576         Update rules.
2577         (classify_unsafe_function, classify_packaged_name)
2578         (classify_name, yylex): Update.
2579
2580 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2581
2582         * configure.ac: add --enable-source-highlight switch.
2583         * configure: Regenerate.
2584         * top.c (print_gdb_version): plumb --enable-source-highlight
2585         status to "show configuration".
2586
2587 2019-04-19  Tom Tromey  <tromey@adacore.com>
2588
2589         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2590         Check ADA_TYPE_P.
2591         (empty_record, ada_template_to_fixed_record_type_1)
2592         (template_to_static_fixed_type)
2593         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2594         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2595         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2596         macros.
2597
2598 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2599
2600         PR symtab/24423:
2601         * source.c (print_source_lines_base): Advance "iter" when a
2602         control character is seen.
2603
2604 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2605
2606         * inferior.h (struct infcall_suspend_state_deleter):
2607         Catch exception in destructor to avoid crash.
2608
2609 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2610
2611         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2612         close to the add_com "shell".
2613
2614 2019-04-18  Tom Tromey  <tromey@adacore.com>
2615
2616         * process-stratum-target.h (class process_stratum_target)
2617         <stratum>: Add "final".
2618
2619 2019-04-17  Tom Tromey  <tromey@adacore.com>
2620
2621         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2622         against nullptr before use.
2623
2624 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2625
2626         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2627
2628 2019-04-17  Jim Wilson  <jimw@sifive.com>
2629             Andrew Burgess  <andrew.burgess@embecosm.com>
2630
2631         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2632         code read might fail, assume 4-byte breakpoint in that case.
2633
2634 2019-04-15  Leszek Swirski  <leszeks@google.com>
2635
2636         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2637         rather than a hand-rolled POD check when checking for forced MEMORY
2638         classification.
2639
2640 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2641
2642         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2643         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2644         function.
2645         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2646         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2647         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2648         declaration.
2649
2650 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2651
2652         * aarch64-linux-nat.c
2653         (aarch64_linux_nat_target::thread_architecture): Add override.
2654         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2655         each VQ.
2656
2657 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2658
2659         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2660
2661 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2662
2663         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2664         target types of size 96-bits, add some additional comments, and
2665         check that the builtin type we found was the correct size.
2666
2667 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2668
2669         * utils.c (prompt_for_continue): Don't restore the styling at the
2670         end, as applied_style has the wrong value.  This fixes styling in
2671         long lists of file names that are interrupted by the "Continue?"
2672         prompt.
2673
2674 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2675
2676         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2677         * c-lang.c (c_language_defn): Likewise.
2678         (cplus_language_defn): Likewise.
2679         (asm_language_defn): Likewise.
2680         (minimal_language_defn): Likewise.
2681         * d-lang.c (d_language_defn): Likewise.
2682         * f-lang.c (f_language_defn): Likewise.
2683         * go-lang.c (go_language_defn): Likewise.
2684         * language.c (unknown_language_defn): Likewise.
2685         (auto_language_defn): Likewise.
2686         * language.h (struct language_defn): Remove la_magic field.
2687         (LANG_MAGIC): Delete.
2688         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2689         * objc-lang.c (objc_language_defn): Likewise.
2690         * opencl-lang.c (opencl_language_defn): Likewise.
2691         * p-lang.c (pascal_language_defn): Likewise.
2692         * rust-lang.c (rust_language_defn): Likewise.
2693
2694 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2695
2696         * riscv-tdep.c (riscv_type_align): New function.
2697         (riscv_type_alignment): Delete.
2698         (riscv_arg_location): Use 'type_align'.
2699         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2700
2701 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2702
2703         * gdbtypes.c (type_align): A struct with no non-static fields also
2704         has alignment of 1.
2705
2706 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2707
2708         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2709         component to 0.
2710         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2711         member.
2712         (riscv_struct_info::analyse): New implementation using new
2713         analyse_inner member function.
2714         (riscv_struct_info::field_offset): New member function.
2715         (riscv_struct_info::m_offsets): New member variable.
2716         (riscv_struct_info::analyse_inner): New private member function,
2717         takes the old implementation of riscv_struct_info::analyse but
2718         extended to track field offsets.
2719         (riscv_call_arg_struct): Update the struct folding special cases
2720         to handle cases where empty C++ structs, which are non-zero
2721         length, are found.
2722         (riscv_arg_location): Initialise the length of each location, a
2723         non-zero length now indicates the location is in use.
2724         (riscv_push_dummy_call): Allow for the first location having a
2725         non-zero offset when setting up arguments.
2726         (riscv_return_value): Likewise, but for return values.
2727
2728 2019-04-11  Tom Tromey  <tromey@adacore.com>
2729
2730         * utils.c (internal_vproblem): Make "msg" const.
2731
2732 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2733
2734         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2735         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2736         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2737         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2738
2739 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2740
2741         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2742         function.
2743         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2744         of amd64_collect_native_gregset.
2745         (amd64_linux_nat_target::store_registers): Likewise.
2746
2747 2019-04-10  Tom Tromey  <tom@tromey.com>
2748
2749         * symtab.c (lookup_global_symbol_from_objfile)
2750         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2751         * objfiles.h (class separate_debug_iterator): New.
2752         (class separate_debug_range): New.
2753         (struct objfile) <separate_debug_objfiles>: New method.
2754         (objfile_separate_debug_iterate): Don't declare.
2755         * objfiles.c (separate_debug_iterator::operator++): Rename from
2756         objfile_separate_debug_iterate.
2757         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2758         iterator.
2759         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2760         iterator.
2761
2762 2019-04-10  Tom Tromey  <tom@tromey.com>
2763
2764         * symfile.c (reread_symbols): Remove old comment.
2765         * objfiles.c (free_all_objfiles): Fix a typo.
2766
2767 2019-04-10  Tom Tromey  <tom@tromey.com>
2768
2769         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2770         * minsyms.c (lookup_minimal_symbol): Use foreach.
2771         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2772         (lookup_minimal_symbol_solib_trampoline): Likewise.
2773         * symfile.c (reread_symbols): Use foreach.
2774
2775 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2776             Tom Tromey  <tromey@adacore.com>
2777
2778         PR rust/24414:
2779         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2780         (rust_lex_int_test): Change "value" to be LONGEST.
2781         (rust_lex_tests): Add test for long integer literal.
2782
2783 2019-04-09  Tom Tromey  <tromey@adacore.com>
2784
2785         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2786         to bool.
2787         (extended_remote_target::attach): Update.
2788         (remote_target::remote_notice_new_inferior): Update.
2789         (remote_target::add_current_inferior_and_thread): Update.
2790         * inferior.c (exit_inferior_1): Use "false".
2791         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2792
2793 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2794
2795         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2796         the "start" command.
2797
2798 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2799
2800         * python/py-inferior.c (infpy_thread_from_thread_handle):
2801         Adjust comments to reflect renaming of thread_from_thread_handle
2802         to thread_from_handle.  Adjust keywords.  Fix type error message.
2803         (inferior_object_methods): Add thread_from_handle.  Retain
2804         thread_from_thread_handle, but mark it as deprecated.
2805
2806 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2807
2808         * gdbthread.h (find_thread_by_handle): Revise declaration.
2809         * thread.c (find_thread_by_handle): Likewise.  Adjust
2810         implementation too.
2811         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2812         support for buffer objects as handles.
2813
2814 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2815
2816         * python/py-infthread.c (thpy_thread_handle): New function.
2817         (thread_object_methods): Register thpy_thread_handle.
2818
2819 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2820
2821         * gdbthread.h (thread_to_thread_handle): Declare.
2822         * thread.c (gdbtypes.h): Include.
2823         (thread_to_thread_handle): New function.
2824
2825         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2826         (target_thread_info_to_thread_handle): Declare.
2827         * target.c (target_thread_info_to_thread_handle): New function.
2828         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2829         * target-delegates.c: Regenerate.
2830
2831         * linux-thread-db.c (class thread_db_target): Add method
2832         thread_info_to_thread_handle.
2833         (thread_db_target::thread_info_to_thread_handle): Define.
2834         * remote.c (class remote_target): Add new method
2835         thread_info_to_thread_handle.
2836         (remote_target::thread_info_to_thread_handle): Define.
2837
2838 2019-04-08  Pedro Alves  <palves@redhat.com>
2839
2840         * common/common-exceptions.c (throw_exception): Don't create
2841         named object to throw; throw directly.
2842         (throw_it): Likewise.  Don't initialize gdb_exception::message
2843         here, with new; pass FMT and AP to the ctor instead.
2844         * common/common-exceptions.h: Include <string>.
2845         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2846         const char *, va_list)): New ctor.  Use std::make_shared.
2847         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2848         errors)): Delete.
2849         (gdb_exception_error::gdb_exception_error(enum errors, const char
2850         *, va_list)): New.
2851         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2852         Add assertion.
2853         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2854         errors)): Delete.
2855         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2856         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2857         Add assertion.
2858
2859 2019-04-08  Tom Tromey  <tom@tromey.com>
2860
2861         * valops.c (value_rtti_indirect_type): Replace throw_exception
2862         with throw.
2863         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2864         with throw.
2865         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2866         throw.
2867         * target.c (target_translate_tls_address): Replace throw_exception
2868         with throw.
2869         * stack.c (frame_apply_command_count): Replace throw_exception
2870         with throw.
2871         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2872         throw.
2873         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2874         with throw.
2875         * rs6000-tdep.c (rs6000_frame_cache)
2876         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2877         * remote.c: Replace throw_exception with throw.
2878         * record-full.c (record_full_message, record_full_wait_1)
2879         (record_full_restore): Replace throw_exception with throw.
2880         * record-btrace.c:
2881         (get_thread_current_frame_id, record_btrace_start_replaying)
2882         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2883         (cmd_record_btrace_start): Replace throw_exception with throw.
2884         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2885         throw.
2886         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2887         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2888         * linespec.c:
2889         (find_linespec_symbols): Replace throw_exception with throw.
2890         * infrun.c (displaced_step_prepare, resume): Replace
2891         throw_exception with throw.
2892         * infcmd.c (post_create_inferior): Replace throw_exception with
2893         throw.
2894         * inf-loop.c (inferior_event_handler): Replace throw_exception
2895         with throw.
2896         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2897         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2898         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2899         (get_prev_frame_always, get_frame_pc_if_available)
2900         (get_frame_address_in_block_if_available, get_frame_language):
2901         Replace throw_exception with throw.
2902         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2903         throw_exception with throw.
2904         * eval.c (fetch_subexp_value, evaluate_var_value)
2905         (evaluate_funcall, evaluate_subexp_standard): Replace
2906         throw_exception with throw.
2907         * dwarf2loc.c (call_site_find_chain)
2908         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2909         Replace throw_exception with throw.
2910         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2911         with throw.
2912         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2913         throw.
2914         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2915         * completer.c (complete_line_internal): Replace throw_exception
2916         with throw.
2917         * compile/compile-object-run.c (compile_object_run): Replace
2918         throw_exception with throw.
2919         * cli/cli-script.c (process_next_line): Replace throw_exception
2920         with throw.
2921         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2922         (btrace_enable, btrace_maint_update_pt_packets): Replace
2923         throw_exception with throw.
2924         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2925         throw_exception with throw.
2926         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2927         throw_exception with throw.
2928         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2929         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2930         * aarch64-tdep.c (aarch64_make_prologue_cache)
2931         (aarch64_make_stub_cache): Replace throw_exception with throw.
2932
2933 2019-04-08  Tom Tromey  <tom@tromey.com>
2934
2935         * common/common-exceptions.c (throw_exception): Rename from
2936         throw_exception_cxx.  Remove old copy.  Make argument const.
2937         (throw_it): Create and throw exception objects directly.
2938         * common/common-exceptions.h (throw_exception): Make argument
2939         const.
2940         (struct gdb_exception_error): Add constructor.
2941         (struct gdb_exception_quit): Add constructor.
2942
2943 2019-04-08  Tom Tromey  <tom@tromey.com>
2944
2945         * common/common-exceptions.h (exception_rethrow): Don't declare.
2946         (TRY_SJLJ): Update comment.
2947         (TRY, CATCH, END_CATCH): Remove.
2948         * common/common-exceptions.c (exception_rethrow): Remove.
2949
2950 2019-04-08  Tom Tromey  <tom@tromey.com>
2951
2952         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2953         Remove.
2954         (gdb_exception_error): Rename from
2955         gdb_exception_RETURN_MASK_ERROR.
2956         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2957         (gdb_quit_bad_alloc): Update.
2958         * aarch64-tdep.c: Update.
2959         * ada-lang.c: Update.
2960         * ada-typeprint.c: Update.
2961         * ada-valprint.c: Update.
2962         * amd64-tdep.c: Update.
2963         * arch-utils.c: Update.
2964         * break-catch-throw.c: Update.
2965         * breakpoint.c: Update.
2966         * btrace.c: Update.
2967         * c-varobj.c: Update.
2968         * cli/cli-cmds.c: Update.
2969         * cli/cli-interp.c: Update.
2970         * cli/cli-script.c: Update.
2971         * common/common-exceptions.c: Update.
2972         * common/new-op.c: Update.
2973         * common/selftest.c: Update.
2974         * compile/compile-c-symbols.c: Update.
2975         * compile/compile-cplus-symbols.c: Update.
2976         * compile/compile-object-load.c: Update.
2977         * compile/compile-object-run.c: Update.
2978         * completer.c: Update.
2979         * corelow.c: Update.
2980         * cp-abi.c: Update.
2981         * cp-support.c: Update.
2982         * cp-valprint.c: Update.
2983         * darwin-nat.c: Update.
2984         * disasm-selftests.c: Update.
2985         * dtrace-probe.c: Update.
2986         * dwarf-index-cache.c: Update.
2987         * dwarf-index-write.c: Update.
2988         * dwarf2-frame-tailcall.c: Update.
2989         * dwarf2-frame.c: Update.
2990         * dwarf2loc.c: Update.
2991         * dwarf2read.c: Update.
2992         * eval.c: Update.
2993         * event-loop.c: Update.
2994         * event-top.c: Update.
2995         * exec.c: Update.
2996         * f-valprint.c: Update.
2997         * fbsd-tdep.c: Update.
2998         * frame-unwind.c: Update.
2999         * frame.c: Update.
3000         * gdbtypes.c: Update.
3001         * gnu-v3-abi.c: Update.
3002         * guile/guile-internal.h: Update.
3003         * guile/scm-block.c: Update.
3004         * guile/scm-breakpoint.c: Update.
3005         * guile/scm-cmd.c: Update.
3006         * guile/scm-disasm.c: Update.
3007         * guile/scm-frame.c: Update.
3008         * guile/scm-lazy-string.c: Update.
3009         * guile/scm-math.c: Update.
3010         * guile/scm-param.c: Update.
3011         * guile/scm-ports.c: Update.
3012         * guile/scm-pretty-print.c: Update.
3013         * guile/scm-symbol.c: Update.
3014         * guile/scm-symtab.c: Update.
3015         * guile/scm-type.c: Update.
3016         * guile/scm-value.c: Update.
3017         * i386-linux-tdep.c: Update.
3018         * i386-tdep.c: Update.
3019         * inf-loop.c: Update.
3020         * infcall.c: Update.
3021         * infcmd.c: Update.
3022         * infrun.c: Update.
3023         * jit.c: Update.
3024         * language.c: Update.
3025         * linespec.c: Update.
3026         * linux-fork.c: Update.
3027         * linux-nat.c: Update.
3028         * linux-tdep.c: Update.
3029         * linux-thread-db.c: Update.
3030         * main.c: Update.
3031         * mi/mi-cmd-break.c: Update.
3032         * mi/mi-cmd-stack.c: Update.
3033         * mi/mi-interp.c: Update.
3034         * mi/mi-main.c: Update.
3035         * objc-lang.c: Update.
3036         * p-valprint.c: Update.
3037         * parse.c: Update.
3038         * ppc-linux-tdep.c: Update.
3039         * printcmd.c: Update.
3040         * python/py-arch.c: Update.
3041         * python/py-breakpoint.c: Update.
3042         * python/py-cmd.c: Update.
3043         * python/py-finishbreakpoint.c: Update.
3044         * python/py-frame.c: Update.
3045         * python/py-framefilter.c: Update.
3046         * python/py-gdb-readline.c: Update.
3047         * python/py-inferior.c: Update.
3048         * python/py-infthread.c: Update.
3049         * python/py-lazy-string.c: Update.
3050         * python/py-linetable.c: Update.
3051         * python/py-objfile.c: Update.
3052         * python/py-param.c: Update.
3053         * python/py-prettyprint.c: Update.
3054         * python/py-progspace.c: Update.
3055         * python/py-record-btrace.c: Update.
3056         * python/py-record.c: Update.
3057         * python/py-symbol.c: Update.
3058         * python/py-type.c: Update.
3059         * python/py-unwind.c: Update.
3060         * python/py-utils.c: Update.
3061         * python/py-value.c: Update.
3062         * python/python.c: Update.
3063         * record-btrace.c: Update.
3064         * record-full.c: Update.
3065         * remote-fileio.c: Update.
3066         * remote.c: Update.
3067         * riscv-tdep.c: Update.
3068         * rs6000-aix-tdep.c: Update.
3069         * rs6000-tdep.c: Update.
3070         * rust-exp.y: Update.
3071         * rust-lang.c: Update.
3072         * s390-tdep.c: Update.
3073         * selftest-arch.c: Update.
3074         * solib-dsbt.c: Update.
3075         * solib-frv.c: Update.
3076         * solib-spu.c: Update.
3077         * solib-svr4.c: Update.
3078         * solib.c: Update.
3079         * sparc64-linux-tdep.c: Update.
3080         * stack.c: Update.
3081         * symfile-mem.c: Update.
3082         * symmisc.c: Update.
3083         * target.c: Update.
3084         * thread.c: Update.
3085         * top.c: Update.
3086         * tracefile-tfile.c: Update.
3087         * tui/tui.c: Update.
3088         * typeprint.c: Update.
3089         * unittests/cli-utils-selftests.c: Update.
3090         * unittests/parse-connection-spec-selftests.c: Update.
3091         * valops.c: Update.
3092         * valprint.c: Update.
3093         * value.c: Update.
3094         * varobj.c: Update.
3095         * windows-nat.c: Update.
3096         * x86-linux-nat.c: Update.
3097         * xml-support.c: Update.
3098
3099 2019-04-08  Tom Tromey  <tom@tromey.com>
3100
3101         * xml-support.c: Use C++ exception handling.
3102         * x86-linux-nat.c: Use C++ exception handling.
3103         * windows-nat.c: Use C++ exception handling.
3104         * varobj.c: Use C++ exception handling.
3105         * value.c: Use C++ exception handling.
3106         * valprint.c: Use C++ exception handling.
3107         * valops.c: Use C++ exception handling.
3108         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3109         handling.
3110         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3111         * typeprint.c: Use C++ exception handling.
3112         * tui/tui.c: Use C++ exception handling.
3113         * tracefile-tfile.c: Use C++ exception handling.
3114         * top.c: Use C++ exception handling.
3115         * thread.c: Use C++ exception handling.
3116         * target.c: Use C++ exception handling.
3117         * symmisc.c: Use C++ exception handling.
3118         * symfile-mem.c: Use C++ exception handling.
3119         * stack.c: Use C++ exception handling.
3120         * sparc64-linux-tdep.c: Use C++ exception handling.
3121         * solib.c: Use C++ exception handling.
3122         * solib-svr4.c: Use C++ exception handling.
3123         * solib-spu.c: Use C++ exception handling.
3124         * solib-frv.c: Use C++ exception handling.
3125         * solib-dsbt.c: Use C++ exception handling.
3126         * selftest-arch.c: Use C++ exception handling.
3127         * s390-tdep.c: Use C++ exception handling.
3128         * rust-lang.c: Use C++ exception handling.
3129         * rust-exp.y: Use C++ exception handling.
3130         * rs6000-tdep.c: Use C++ exception handling.
3131         * rs6000-aix-tdep.c: Use C++ exception handling.
3132         * riscv-tdep.c: Use C++ exception handling.
3133         * remote.c: Use C++ exception handling.
3134         * remote-fileio.c: Use C++ exception handling.
3135         * record-full.c: Use C++ exception handling.
3136         * record-btrace.c: Use C++ exception handling.
3137         * python/python.c: Use C++ exception handling.
3138         * python/py-value.c: Use C++ exception handling.
3139         * python/py-utils.c: Use C++ exception handling.
3140         * python/py-unwind.c: Use C++ exception handling.
3141         * python/py-type.c: Use C++ exception handling.
3142         * python/py-symbol.c: Use C++ exception handling.
3143         * python/py-record.c: Use C++ exception handling.
3144         * python/py-record-btrace.c: Use C++ exception handling.
3145         * python/py-progspace.c: Use C++ exception handling.
3146         * python/py-prettyprint.c: Use C++ exception handling.
3147         * python/py-param.c: Use C++ exception handling.
3148         * python/py-objfile.c: Use C++ exception handling.
3149         * python/py-linetable.c: Use C++ exception handling.
3150         * python/py-lazy-string.c: Use C++ exception handling.
3151         * python/py-infthread.c: Use C++ exception handling.
3152         * python/py-inferior.c: Use C++ exception handling.
3153         * python/py-gdb-readline.c: Use C++ exception handling.
3154         * python/py-framefilter.c: Use C++ exception handling.
3155         * python/py-frame.c: Use C++ exception handling.
3156         * python/py-finishbreakpoint.c: Use C++ exception handling.
3157         * python/py-cmd.c: Use C++ exception handling.
3158         * python/py-breakpoint.c: Use C++ exception handling.
3159         * python/py-arch.c: Use C++ exception handling.
3160         * printcmd.c: Use C++ exception handling.
3161         * ppc-linux-tdep.c: Use C++ exception handling.
3162         * parse.c: Use C++ exception handling.
3163         * p-valprint.c: Use C++ exception handling.
3164         * objc-lang.c: Use C++ exception handling.
3165         * mi/mi-main.c: Use C++ exception handling.
3166         * mi/mi-interp.c: Use C++ exception handling.
3167         * mi/mi-cmd-stack.c: Use C++ exception handling.
3168         * mi/mi-cmd-break.c: Use C++ exception handling.
3169         * main.c: Use C++ exception handling.
3170         * linux-thread-db.c: Use C++ exception handling.
3171         * linux-tdep.c: Use C++ exception handling.
3172         * linux-nat.c: Use C++ exception handling.
3173         * linux-fork.c: Use C++ exception handling.
3174         * linespec.c: Use C++ exception handling.
3175         * language.c: Use C++ exception handling.
3176         * jit.c: Use C++ exception handling.
3177         * infrun.c: Use C++ exception handling.
3178         * infcmd.c: Use C++ exception handling.
3179         * infcall.c: Use C++ exception handling.
3180         * inf-loop.c: Use C++ exception handling.
3181         * i386-tdep.c: Use C++ exception handling.
3182         * i386-linux-tdep.c: Use C++ exception handling.
3183         * guile/scm-value.c: Use C++ exception handling.
3184         * guile/scm-type.c: Use C++ exception handling.
3185         * guile/scm-symtab.c: Use C++ exception handling.
3186         * guile/scm-symbol.c: Use C++ exception handling.
3187         * guile/scm-pretty-print.c: Use C++ exception handling.
3188         * guile/scm-ports.c: Use C++ exception handling.
3189         * guile/scm-param.c: Use C++ exception handling.
3190         * guile/scm-math.c: Use C++ exception handling.
3191         * guile/scm-lazy-string.c: Use C++ exception handling.
3192         * guile/scm-frame.c: Use C++ exception handling.
3193         * guile/scm-disasm.c: Use C++ exception handling.
3194         * guile/scm-cmd.c: Use C++ exception handling.
3195         * guile/scm-breakpoint.c: Use C++ exception handling.
3196         * guile/scm-block.c: Use C++ exception handling.
3197         * guile/guile-internal.h: Use C++ exception handling.
3198         * gnu-v3-abi.c: Use C++ exception handling.
3199         * gdbtypes.c: Use C++ exception handling.
3200         * frame.c: Use C++ exception handling.
3201         * frame-unwind.c: Use C++ exception handling.
3202         * fbsd-tdep.c: Use C++ exception handling.
3203         * f-valprint.c: Use C++ exception handling.
3204         * exec.c: Use C++ exception handling.
3205         * event-top.c: Use C++ exception handling.
3206         * event-loop.c: Use C++ exception handling.
3207         * eval.c: Use C++ exception handling.
3208         * dwarf2read.c: Use C++ exception handling.
3209         * dwarf2loc.c: Use C++ exception handling.
3210         * dwarf2-frame.c: Use C++ exception handling.
3211         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3212         * dwarf-index-write.c: Use C++ exception handling.
3213         * dwarf-index-cache.c: Use C++ exception handling.
3214         * dtrace-probe.c: Use C++ exception handling.
3215         * disasm-selftests.c: Use C++ exception handling.
3216         * darwin-nat.c: Use C++ exception handling.
3217         * cp-valprint.c: Use C++ exception handling.
3218         * cp-support.c: Use C++ exception handling.
3219         * cp-abi.c: Use C++ exception handling.
3220         * corelow.c: Use C++ exception handling.
3221         * completer.c: Use C++ exception handling.
3222         * compile/compile-object-run.c: Use C++ exception handling.
3223         * compile/compile-object-load.c: Use C++ exception handling.
3224         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3225         * compile/compile-c-symbols.c: Use C++ exception handling.
3226         * common/selftest.c: Use C++ exception handling.
3227         * common/new-op.c: Use C++ exception handling.
3228         * cli/cli-script.c: Use C++ exception handling.
3229         * cli/cli-interp.c: Use C++ exception handling.
3230         * cli/cli-cmds.c: Use C++ exception handling.
3231         * c-varobj.c: Use C++ exception handling.
3232         * btrace.c: Use C++ exception handling.
3233         * breakpoint.c: Use C++ exception handling.
3234         * break-catch-throw.c: Use C++ exception handling.
3235         * arch-utils.c: Use C++ exception handling.
3236         * amd64-tdep.c: Use C++ exception handling.
3237         * ada-valprint.c: Use C++ exception handling.
3238         * ada-typeprint.c: Use C++ exception handling.
3239         * ada-lang.c: Use C++ exception handling.
3240         * aarch64-tdep.c: Use C++ exception handling.
3241
3242 2019-04-08  Tom Tromey  <tom@tromey.com>
3243
3244         * xml-support.c (gdb_xml_parser::parse): Update.
3245         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3246         * value.c (show_convenience): Update.
3247         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3248         (test_parse_flags_qcs): Update.
3249         * thread.c (thr_try_catch_cmd): Update.
3250         * target.c (target_translate_tls_address): Update.
3251         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3252         (info_frame_command_core, frame_apply_command_count): Update.
3253         * rust-exp.y (rust_lex_exception_test): Update.
3254         * riscv-tdep.c (riscv_print_one_register_info): Update.
3255         * remote.c (remote_target::enable_btrace): Update.
3256         * record-btrace.c (record_btrace_enable_warn): Update.
3257         * python/py-utils.c (gdbpy_convert_exception): Update.
3258         * printcmd.c (do_one_display, print_variable_and_value): Update.
3259         * mi/mi-main.c (mi_print_exception): Update.
3260         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3261         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3262         * linux-nat.c (linux_nat_target::attach): Update.
3263         * linux-fork.c (class scoped_switch_fork_info): Update.
3264         * infrun.c (displaced_step_prepare): Update.
3265         * infcall.c (call_function_by_hand_dummy): Update.
3266         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3267         * gnu-v3-abi.c (print_one_vtable): Update.
3268         * frame.c (get_prev_frame_always): Update.
3269         * f-valprint.c (info_common_command_for_block): Update.
3270         * exec.c (try_open_exec_file): Update.
3271         * exceptions.c (print_exception, exception_print)
3272         (exception_fprintf, exception_print_same): Update.
3273         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3274         * dwarf-index-cache.c (index_cache::store)
3275         (index_cache::lookup_gdb_index): Update.
3276         * darwin-nat.c (maybe_cache_shell): Update.
3277         * cp-valprint.c (cp_print_value_fields): Update.
3278         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3279         (gcc_cplus_symbol_address): Update.
3280         * compile/compile-c-symbols.c (gcc_convert_symbol)
3281         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3282         * common/selftest.c: Update.
3283         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3284         a std::string.
3285         (exception_try_scope_entry, exception_try_scope_exit): Don't
3286         declare.
3287         (struct exception_try_scope): Remove.
3288         (TRY): Don't use exception_try_scope.
3289         (struct gdb_exception): Add constructor, operator=.
3290         <what>: New method.
3291         (struct gdb_exception_RETURN_MASK_ALL)
3292         (struct gdb_exception_RETURN_MASK_ERROR)
3293         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3294         (struct gdb_quit_bad_alloc): Update.
3295         * common/common-exceptions.c (exception_none): Change
3296         initializer.
3297         (struct catcher) <state, exception>: Initialize inline.
3298         <prev>: Remove member.
3299         (current_catcher): Remove.
3300         (catchers): New global.
3301         (exceptions_state_mc_init): Simplify.
3302         (catcher_pop): Remove.
3303         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3304         (try_scope_depth, exception_try_scope_entry)
3305         (exception_try_scope_exit): Remove.
3306         (throw_exception_sjlj): Update.
3307         (exception_messages, exception_messages_size): Remove.
3308         (throw_it): Simplify.
3309         (gdb_exception_sliced_copy): Remove.
3310         (throw_exception_cxx): Update.
3311         * cli/cli-script.c (script_from_file): Update.
3312         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3313         Update.
3314         * ada-valprint.c (ada_val_print): Update.
3315         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3316         (create_excep_cond_exprs): Update.
3317
3318 2019-04-08  Tom Tromey  <tom@tromey.com>
3319
3320         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3321         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3322         (TRY, CATCH, END_CATCH): Remove some definitions.
3323         * common/common-exceptions.c: Don't use GDB_XCPT.
3324         (catcher_list_size): Remove.
3325         (throw_exception, throw_it): Simplify.
3326
3327 2019-04-05  Tom Tromey  <tom@tromey.com>
3328
3329         Revert the header-sorting patch.
3330         * ft32-tdep.c: Revert.
3331         * frv-tdep.c: Revert.
3332         * frv-linux-tdep.c: Revert.
3333         * frame.c: Revert.
3334         * frame-unwind.c: Revert.
3335         * frame-base.c: Revert.
3336         * fork-child.c: Revert.
3337         * findvar.c: Revert.
3338         * findcmd.c: Revert.
3339         * filesystem.c: Revert.
3340         * filename-seen-cache.h: Revert.
3341         * filename-seen-cache.c: Revert.
3342         * fbsd-tdep.c: Revert.
3343         * fbsd-nat.h: Revert.
3344         * fbsd-nat.c: Revert.
3345         * f-valprint.c: Revert.
3346         * f-typeprint.c: Revert.
3347         * f-lang.c: Revert.
3348         * extension.h: Revert.
3349         * extension.c: Revert.
3350         * extension-priv.h: Revert.
3351         * expprint.c: Revert.
3352         * exec.h: Revert.
3353         * exec.c: Revert.
3354         * exceptions.c: Revert.
3355         * event-top.c: Revert.
3356         * event-loop.c: Revert.
3357         * eval.c: Revert.
3358         * elfread.c: Revert.
3359         * dwarf2read.h: Revert.
3360         * dwarf2read.c: Revert.
3361         * dwarf2loc.c: Revert.
3362         * dwarf2expr.h: Revert.
3363         * dwarf2expr.c: Revert.
3364         * dwarf2-frame.c: Revert.
3365         * dwarf2-frame-tailcall.c: Revert.
3366         * dwarf-index-write.h: Revert.
3367         * dwarf-index-write.c: Revert.
3368         * dwarf-index-common.c: Revert.
3369         * dwarf-index-cache.h: Revert.
3370         * dwarf-index-cache.c: Revert.
3371         * dummy-frame.c: Revert.
3372         * dtrace-probe.c: Revert.
3373         * disasm.h: Revert.
3374         * disasm.c: Revert.
3375         * disasm-selftests.c: Revert.
3376         * dictionary.c: Revert.
3377         * dicos-tdep.c: Revert.
3378         * demangle.c: Revert.
3379         * dcache.h: Revert.
3380         * dcache.c: Revert.
3381         * darwin-nat.h: Revert.
3382         * darwin-nat.c: Revert.
3383         * darwin-nat-info.c: Revert.
3384         * d-valprint.c: Revert.
3385         * d-namespace.c: Revert.
3386         * d-lang.c: Revert.
3387         * ctf.c: Revert.
3388         * csky-tdep.c: Revert.
3389         * csky-linux-tdep.c: Revert.
3390         * cris-tdep.c: Revert.
3391         * cris-linux-tdep.c: Revert.
3392         * cp-valprint.c: Revert.
3393         * cp-support.c: Revert.
3394         * cp-namespace.c: Revert.
3395         * cp-abi.c: Revert.
3396         * corelow.c: Revert.
3397         * corefile.c: Revert.
3398         * continuations.c: Revert.
3399         * completer.h: Revert.
3400         * completer.c: Revert.
3401         * complaints.c: Revert.
3402         * coffread.c: Revert.
3403         * coff-pe-read.c: Revert.
3404         * cli-out.h: Revert.
3405         * cli-out.c: Revert.
3406         * charset.c: Revert.
3407         * c-varobj.c: Revert.
3408         * c-valprint.c: Revert.
3409         * c-typeprint.c: Revert.
3410         * c-lang.c: Revert.
3411         * buildsym.c: Revert.
3412         * buildsym-legacy.c: Revert.
3413         * build-id.h: Revert.
3414         * build-id.c: Revert.
3415         * btrace.c: Revert.
3416         * bsd-uthread.c: Revert.
3417         * breakpoint.h: Revert.
3418         * breakpoint.c: Revert.
3419         * break-catch-throw.c: Revert.
3420         * break-catch-syscall.c: Revert.
3421         * break-catch-sig.c: Revert.
3422         * blockframe.c: Revert.
3423         * block.c: Revert.
3424         * bfin-tdep.c: Revert.
3425         * bfin-linux-tdep.c: Revert.
3426         * bfd-target.c: Revert.
3427         * bcache.c: Revert.
3428         * ax-general.c: Revert.
3429         * ax-gdb.h: Revert.
3430         * ax-gdb.c: Revert.
3431         * avr-tdep.c: Revert.
3432         * auxv.c: Revert.
3433         * auto-load.c: Revert.
3434         * arm-wince-tdep.c: Revert.
3435         * arm-tdep.c: Revert.
3436         * arm-symbian-tdep.c: Revert.
3437         * arm-pikeos-tdep.c: Revert.
3438         * arm-obsd-tdep.c: Revert.
3439         * arm-nbsd-tdep.c: Revert.
3440         * arm-nbsd-nat.c: Revert.
3441         * arm-linux-tdep.c: Revert.
3442         * arm-linux-nat.c: Revert.
3443         * arm-fbsd-tdep.c: Revert.
3444         * arm-fbsd-nat.c: Revert.
3445         * arm-bsd-tdep.c: Revert.
3446         * arch-utils.c: Revert.
3447         * arc-tdep.c: Revert.
3448         * arc-newlib-tdep.c: Revert.
3449         * annotate.h: Revert.
3450         * annotate.c: Revert.
3451         * amd64-windows-tdep.c: Revert.
3452         * amd64-windows-nat.c: Revert.
3453         * amd64-tdep.c: Revert.
3454         * amd64-sol2-tdep.c: Revert.
3455         * amd64-obsd-tdep.c: Revert.
3456         * amd64-obsd-nat.c: Revert.
3457         * amd64-nbsd-tdep.c: Revert.
3458         * amd64-nbsd-nat.c: Revert.
3459         * amd64-nat.c: Revert.
3460         * amd64-linux-tdep.c: Revert.
3461         * amd64-linux-nat.c: Revert.
3462         * amd64-fbsd-tdep.c: Revert.
3463         * amd64-fbsd-nat.c: Revert.
3464         * amd64-dicos-tdep.c: Revert.
3465         * amd64-darwin-tdep.c: Revert.
3466         * amd64-bsd-nat.c: Revert.
3467         * alpha-tdep.c: Revert.
3468         * alpha-obsd-tdep.c: Revert.
3469         * alpha-nbsd-tdep.c: Revert.
3470         * alpha-mdebug-tdep.c: Revert.
3471         * alpha-linux-tdep.c: Revert.
3472         * alpha-linux-nat.c: Revert.
3473         * alpha-bsd-tdep.c: Revert.
3474         * alpha-bsd-nat.c: Revert.
3475         * aix-thread.c: Revert.
3476         * agent.c: Revert.
3477         * addrmap.c: Revert.
3478         * ada-varobj.c: Revert.
3479         * ada-valprint.c: Revert.
3480         * ada-typeprint.c: Revert.
3481         * ada-tasks.c: Revert.
3482         * ada-lang.c: Revert.
3483         * aarch64-tdep.c: Revert.
3484         * aarch64-ravenscar-thread.c: Revert.
3485         * aarch64-newlib-tdep.c: Revert.
3486         * aarch64-linux-tdep.c: Revert.
3487         * aarch64-linux-nat.c: Revert.
3488         * aarch64-fbsd-tdep.c: Revert.
3489         * aarch64-fbsd-nat.c: Revert.
3490         * aarch32-linux-nat.c: Revert.
3491
3492 2019-04-05  Tom Tromey  <tom@tromey.com>
3493
3494         * ft32-tdep.c: Sort headers.
3495         * frv-tdep.c: Sort headers.
3496         * frv-linux-tdep.c: Sort headers.
3497         * frame.c: Sort headers.
3498         * frame-unwind.c: Sort headers.
3499         * frame-base.c: Sort headers.
3500         * fork-child.c: Sort headers.
3501         * findvar.c: Sort headers.
3502         * findcmd.c: Sort headers.
3503         * filesystem.c: Sort headers.
3504         * filename-seen-cache.h: Sort headers.
3505         * filename-seen-cache.c: Sort headers.
3506         * fbsd-tdep.c: Sort headers.
3507         * fbsd-nat.h: Sort headers.
3508         * fbsd-nat.c: Sort headers.
3509         * f-valprint.c: Sort headers.
3510         * f-typeprint.c: Sort headers.
3511         * f-lang.c: Sort headers.
3512         * extension.h: Sort headers.
3513         * extension.c: Sort headers.
3514         * extension-priv.h: Sort headers.
3515         * expprint.c: Sort headers.
3516         * exec.h: Sort headers.
3517         * exec.c: Sort headers.
3518         * exceptions.c: Sort headers.
3519         * event-top.c: Sort headers.
3520         * event-loop.c: Sort headers.
3521         * eval.c: Sort headers.
3522         * elfread.c: Sort headers.
3523         * dwarf2read.h: Sort headers.
3524         * dwarf2read.c: Sort headers.
3525         * dwarf2loc.c: Sort headers.
3526         * dwarf2expr.h: Sort headers.
3527         * dwarf2expr.c: Sort headers.
3528         * dwarf2-frame.c: Sort headers.
3529         * dwarf2-frame-tailcall.c: Sort headers.
3530         * dwarf-index-write.h: Sort headers.
3531         * dwarf-index-write.c: Sort headers.
3532         * dwarf-index-common.c: Sort headers.
3533         * dwarf-index-cache.h: Sort headers.
3534         * dwarf-index-cache.c: Sort headers.
3535         * dummy-frame.c: Sort headers.
3536         * dtrace-probe.c: Sort headers.
3537         * disasm.h: Sort headers.
3538         * disasm.c: Sort headers.
3539         * disasm-selftests.c: Sort headers.
3540         * dictionary.c: Sort headers.
3541         * dicos-tdep.c: Sort headers.
3542         * demangle.c: Sort headers.
3543         * dcache.h: Sort headers.
3544         * dcache.c: Sort headers.
3545         * darwin-nat.h: Sort headers.
3546         * darwin-nat.c: Sort headers.
3547         * darwin-nat-info.c: Sort headers.
3548         * d-valprint.c: Sort headers.
3549         * d-namespace.c: Sort headers.
3550         * d-lang.c: Sort headers.
3551         * ctf.c: Sort headers.
3552         * csky-tdep.c: Sort headers.
3553         * csky-linux-tdep.c: Sort headers.
3554         * cris-tdep.c: Sort headers.
3555         * cris-linux-tdep.c: Sort headers.
3556         * cp-valprint.c: Sort headers.
3557         * cp-support.c: Sort headers.
3558         * cp-namespace.c: Sort headers.
3559         * cp-abi.c: Sort headers.
3560         * corelow.c: Sort headers.
3561         * corefile.c: Sort headers.
3562         * continuations.c: Sort headers.
3563         * completer.h: Sort headers.
3564         * completer.c: Sort headers.
3565         * complaints.c: Sort headers.
3566         * coffread.c: Sort headers.
3567         * coff-pe-read.c: Sort headers.
3568         * cli-out.h: Sort headers.
3569         * cli-out.c: Sort headers.
3570         * charset.c: Sort headers.
3571         * c-varobj.c: Sort headers.
3572         * c-valprint.c: Sort headers.
3573         * c-typeprint.c: Sort headers.
3574         * c-lang.c: Sort headers.
3575         * buildsym.c: Sort headers.
3576         * buildsym-legacy.c: Sort headers.
3577         * build-id.h: Sort headers.
3578         * build-id.c: Sort headers.
3579         * btrace.c: Sort headers.
3580         * bsd-uthread.c: Sort headers.
3581         * breakpoint.h: Sort headers.
3582         * breakpoint.c: Sort headers.
3583         * break-catch-throw.c: Sort headers.
3584         * break-catch-syscall.c: Sort headers.
3585         * break-catch-sig.c: Sort headers.
3586         * blockframe.c: Sort headers.
3587         * block.c: Sort headers.
3588         * bfin-tdep.c: Sort headers.
3589         * bfin-linux-tdep.c: Sort headers.
3590         * bfd-target.c: Sort headers.
3591         * bcache.c: Sort headers.
3592         * ax-general.c: Sort headers.
3593         * ax-gdb.h: Sort headers.
3594         * ax-gdb.c: Sort headers.
3595         * avr-tdep.c: Sort headers.
3596         * auxv.c: Sort headers.
3597         * auto-load.c: Sort headers.
3598         * arm-wince-tdep.c: Sort headers.
3599         * arm-tdep.c: Sort headers.
3600         * arm-symbian-tdep.c: Sort headers.
3601         * arm-pikeos-tdep.c: Sort headers.
3602         * arm-obsd-tdep.c: Sort headers.
3603         * arm-nbsd-tdep.c: Sort headers.
3604         * arm-nbsd-nat.c: Sort headers.
3605         * arm-linux-tdep.c: Sort headers.
3606         * arm-linux-nat.c: Sort headers.
3607         * arm-fbsd-tdep.c: Sort headers.
3608         * arm-fbsd-nat.c: Sort headers.
3609         * arm-bsd-tdep.c: Sort headers.
3610         * arch-utils.c: Sort headers.
3611         * arc-tdep.c: Sort headers.
3612         * arc-newlib-tdep.c: Sort headers.
3613         * annotate.h: Sort headers.
3614         * annotate.c: Sort headers.
3615         * amd64-windows-tdep.c: Sort headers.
3616         * amd64-windows-nat.c: Sort headers.
3617         * amd64-tdep.c: Sort headers.
3618         * amd64-sol2-tdep.c: Sort headers.
3619         * amd64-obsd-tdep.c: Sort headers.
3620         * amd64-obsd-nat.c: Sort headers.
3621         * amd64-nbsd-tdep.c: Sort headers.
3622         * amd64-nbsd-nat.c: Sort headers.
3623         * amd64-nat.c: Sort headers.
3624         * amd64-linux-tdep.c: Sort headers.
3625         * amd64-linux-nat.c: Sort headers.
3626         * amd64-fbsd-tdep.c: Sort headers.
3627         * amd64-fbsd-nat.c: Sort headers.
3628         * amd64-dicos-tdep.c: Sort headers.
3629         * amd64-darwin-tdep.c: Sort headers.
3630         * amd64-bsd-nat.c: Sort headers.
3631         * alpha-tdep.c: Sort headers.
3632         * alpha-obsd-tdep.c: Sort headers.
3633         * alpha-nbsd-tdep.c: Sort headers.
3634         * alpha-mdebug-tdep.c: Sort headers.
3635         * alpha-linux-tdep.c: Sort headers.
3636         * alpha-linux-nat.c: Sort headers.
3637         * alpha-bsd-tdep.c: Sort headers.
3638         * alpha-bsd-nat.c: Sort headers.
3639         * aix-thread.c: Sort headers.
3640         * agent.c: Sort headers.
3641         * addrmap.c: Sort headers.
3642         * ada-varobj.c: Sort headers.
3643         * ada-valprint.c: Sort headers.
3644         * ada-typeprint.c: Sort headers.
3645         * ada-tasks.c: Sort headers.
3646         * ada-lang.c: Sort headers.
3647         * aarch64-tdep.c: Sort headers.
3648         * aarch64-ravenscar-thread.c: Sort headers.
3649         * aarch64-newlib-tdep.c: Sort headers.
3650         * aarch64-linux-tdep.c: Sort headers.
3651         * aarch64-linux-nat.c: Sort headers.
3652         * aarch64-fbsd-tdep.c: Sort headers.
3653         * aarch64-fbsd-nat.c: Sort headers.
3654         * aarch32-linux-nat.c: Sort headers.
3655
3656 2019-04-04  Tom Tromey  <tom@tromey.com>
3657
3658         * varobj.c (varobj_create): Update.
3659         * rust-exp.y (struct rust_parser) <update_innermost_block,
3660         lookup_symbol>: New methods.
3661         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3662         Rename.
3663         (rust_parser::rust_lookup_type)
3664         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3665         * printcmd.c (display_command, do_one_display): Update.
3666         * parser-defs.h (struct parser_state) <parser_state>: Add
3667         "tracker" parameter.
3668         (block_tracker): New member.
3669         (class innermost_block_tracker) <innermost_block_tracker>: Add
3670         "types" parameter.
3671         <reset>: Remove method.
3672         (innermost_block): Don't declare.
3673         (null_post_parser): Update.
3674         * parse.c (innermost_block): Remove global.
3675         (write_dollar_variable): Update.
3676         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3677         Remove "tracker_types" parameter.
3678         (parse_expression): Add "tracker" parameter.
3679         (parse_expression_for_completion): Update.
3680         (null_post_parser): Add "tracker" parameter.
3681         * p-exp.y: Update rules.
3682         * m2-exp.y: Update rules.
3683         * language.h (struct language_defn) <la_post_parser>: Add
3684         "tracker" parameter.
3685         * go-exp.y: Update rules.
3686         * f-exp.y: Update rules.
3687         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3688         parameter.
3689         * d-exp.y: Update rules.
3690         * c-exp.y: Update rules.
3691         * breakpoint.c (set_breakpoint_condition): Create an
3692         innermost_block_tracker.
3693         (watch_command_1): Likewise.
3694         * ada-lang.c (resolve): Add "tracker" parameter.
3695         (resolve_subexp): Likewise.
3696         * ada-exp.y (write_var_from_sym): Update.
3697
3698 2019-04-04  Tom Tromey  <tom@tromey.com>
3699
3700         * type-stack.h: New file.
3701         * type-stack.c: New file.
3702         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3703         type-stack.h.
3704         (insert_into_type_stack, insert_type, push_type, push_type_int)
3705         (insert_type_address_space, pop_type, pop_type_int)
3706         (pop_typelist, pop_type_stack, append_type_stack)
3707         (push_type_stack, get_type_stack, push_typelist)
3708         (follow_type_instance_flags, follow_types): Don't declare.
3709         * parse.c (type_stack): Remove global.
3710         (parse_exp_in_context): Update.
3711         (insert_into_type_stack, insert_type, push_type, push_type_int)
3712         (insert_type_address_space, pop_type, pop_type_int)
3713         (pop_typelist, pop_type_stack, append_type_stack)
3714         (push_type_stack, get_type_stack, push_typelist)
3715         (follow_type_instance_flags, follow_types): Remove (moved to
3716         type-stack.c).
3717         * f-exp.y (type_stack): New global.
3718         Update rules.
3719         (push_kind_type, f_parse): Update.
3720         * d-exp.y (type_stack): New global.
3721         Update rules.
3722         (d_parse): Update.
3723         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3724         Update rules.
3725         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3726         (HFILES_NO_SRCDIR): Add type-stack.h.
3727
3728 2019-04-04  Tom Tromey  <tom@tromey.com>
3729
3730         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3731         (rust_parser::convert_ast_to_expression, rust_parse)
3732         (rust_lex_test_completion, rust_lex_tests): Update.
3733         * parser-defs.h (struct expr_completion_state): New.
3734         (struct parser_state) <parser_state>: Add completion parameter.
3735         <mark_struct_expression, mark_completion_tag>: New methods.
3736         <parse_completion, m_completion_state>: New members.
3737         (prefixify_expression, null_post_parser): Update.
3738         (mark_struct_expression, mark_completion_tag): Don't declare.
3739         * parse.c (parse_completion, expout_last_struct)
3740         (expout_tag_completion_type, expout_completion_name): Remove
3741         globals.
3742         (parser_state::mark_struct_expression)
3743         (parser_state::mark_completion_tag): Now methods.
3744         (prefixify_expression): Add last_struct parameter.
3745         (prefixify_subexp): Likewise.
3746         (parse_exp_1): Update.
3747         (parse_exp_in_context): Add cstate parameter.  Update.
3748         (parse_expression_for_completion): Create an
3749         expr_completion_state.
3750         (null_post_parser): Add "completion" parameter.
3751         * p-exp.y: Update rules.
3752         (yylex): Update.
3753         * language.h (struct language_defn) <la_post_parser>: Add
3754         "completing" parameter.
3755         * go-exp.y: Update rules.
3756         (lex_one_token): Update.
3757         * expression.h (parse_completion): Don't declare.
3758         * d-exp.y: Update rules.
3759         (lex_one_token): Update rules.
3760         * c-exp.y: Update rules.
3761         (lex_one_token): Update.
3762         * ada-lang.c (resolve): Add "parse_completion" parameter.
3763         (resolve_subexp): Likewise.
3764         (ada_resolve_function): Likewise.
3765
3766 2019-04-04  Tom Tromey  <tom@tromey.com>
3767
3768         * parser-defs.h (struct parser_state) <start_arglist,
3769         end_arglist>: New methods.
3770         <arglist_len, m_funcall_chain>: New members.
3771         (arglist_len, start_arglist, end_arglist): Don't declare.
3772         * parse.c (arglist_len, funcall_chain): Remove global.
3773         (start_arglist, end_arglist): Remove functions.
3774         (parse_exp_in_context): Update.
3775         * p-exp.y: Update rules.
3776         * m2-exp.y: Update rules.
3777         * go-exp.y: Update rules.
3778         * f-exp.y: Update rules.
3779         * d-exp.y: Update rules.
3780         * c-exp.y: Update rules.
3781
3782 2019-04-04  Tom Tromey  <tom@tromey.com>
3783
3784         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3785         lex_operator, push_back>: New methods.
3786         Update all rules.
3787         (rust_parser::lex_hex, lex_escape): Rename and update.
3788         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3789         (rust_parser::lex_operator): Rename and update.
3790         (rust_parser::lex_number, rustyylex, rustyyerror)
3791         (rust_lex_test_init, rust_lex_test_sequence)
3792         (rust_lex_test_push_back, rust_lex_tests): Update.
3793         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3794         parameter.
3795         <lexptr, prev_lexptr>: New members.
3796         (lexptr, prev_lexptr): Don't declare.
3797         * parse.c (lexptr, prev_lexptr): Remove globals.
3798         (parse_exp_in_context): Update.
3799         * p-exp.y (yylex, yyerror): Update.
3800         * m2-exp.y (parse_number, yylex, yyerror): Update.
3801         * go-exp.y (lex_one_token, yyerror): Update.
3802         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3803         * d-exp.y (lex_one_token, yyerror): Update.
3804         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3805         (lex_one_token, yyerror): Update.
3806         * ada-lex.l (YY_INPUT): Update.
3807         (rewind_to_char): Update.
3808         * ada-exp.y (yyerror): Update.
3809
3810 2019-04-04  Tom Tromey  <tom@tromey.com>
3811
3812         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3813         * parser-defs.h (struct parser_state) <parser_state>: Add new
3814         parameter.
3815         <comma_terminates>: New member.
3816         (comma_terminates): Don't declare global.
3817         * parse.c (comma_terminates): Remove global.
3818         (parse_exp_in_context): Update.
3819         * p-exp.y (yylex): Update.
3820         * m2-exp.y (yylex): Update.
3821         * go-exp.y (lex_one_token): Update.
3822         * f-exp.y (yylex): Update.
3823         * d-exp.y (lex_one_token): Update.
3824         * c-exp.y (lex_one_token): Update.
3825         * ada-lex.l: Update.
3826
3827 2019-04-04  Tom Tromey  <tom@tromey.com>
3828
3829         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3830         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3831         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3832         * parser-defs.h (paren_depth): Don't declare.
3833         * parse.c (paren_depth): Remove global.
3834         (parse_exp_in_context): Update.
3835         * p-exp.y (paren_depth): New global.
3836         (pascal_parse): Initialize it.
3837         * m2-exp.y (paren_depth): New global.
3838         (m2_parse): Initialize it.
3839         * go-exp.y (paren_depth): New global.
3840         (go_parse): Initialize it.
3841         * f-exp.y (paren_depth): New global.
3842         (f_parse): Initialize it.
3843         * d-exp.y (paren_depth): New global.
3844         (d_parse): Initialize it.
3845         * c-exp.y (paren_depth): New global.
3846         (c_parse): Initialize it.
3847         * ada-lex.l (paren_depth): New global.
3848         (lexer_init): Initialize it.
3849
3850 2019-04-04  Tom Tromey  <tom@tromey.com>
3851
3852         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3853         (rust_parser::convert_ast_to_type)
3854         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3855         * parser-defs.h (struct parser_state) <parser_state>: Add
3856         parameters.  Initialize new members.
3857         <expression_context_block, expression_context_pc>: New members.
3858         * parse.c (expression_context_block, expression_context_pc):
3859         Remove globals.
3860         (parse_exp_in_context): Update.
3861         * p-exp.y: Update all rules.
3862         (yylex): Update.
3863         * m2-exp.y: Update all rules.
3864         (yylex): Update.
3865         * go-exp.y (yylex): Update.
3866         * f-exp.y (yylex): Update.
3867         * d-exp.y: Update all rules.
3868         (yylex): Update.
3869         * c-exp.y: Update all rules.
3870         (lex_one_token, classify_name, yylex, c_parse): Update.
3871         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3872
3873 2019-04-04  Tom Tromey  <tom@tromey.com>
3874
3875         * gdbarch.h, gdbarch.c: Rebuild.
3876         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3877         * stap-probe.h:
3878         (struct stap_parse_info): Replace "parser_state" with
3879         "expr_builder".
3880         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3881         (parser_state): New class.
3882         * parse.c (expr_builder): Rename.
3883         (expr_builder::release): Rename.
3884         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3885         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3886         (write_exp_elt_longcst, write_exp_elt_floatcst)
3887         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3888         (write_exp_string_vector, write_exp_bitstring)
3889         (write_exp_msymbol, mark_struct_expression)
3890         (write_dollar_variable)
3891         (insert_type_address_space, increase_expout_size): Replace
3892         "parser_state" with "expr_builder".
3893         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3894         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3895         "parser_state" with "expr_builder".
3896
3897 2019-04-04  Tom Tromey  <tom@tromey.com>
3898
3899         * rust-exp.y: Replace "parse_language" with method call.
3900         * p-exp.y:
3901         (yylex): Replace "parse_language" with method call.
3902         * m2-exp.y:
3903         (yylex): Replace "parse_language" with method call.
3904         * go-exp.y (classify_name): Replace "parse_language" with method
3905         call.
3906         * f-exp.y (yylex): Replace "parse_language" with method call.
3907         * d-exp.y (lex_one_token): Replace "parse_language" with method
3908         call.
3909         * c-exp.y:
3910         (lex_one_token, classify_name, yylex): Replace "parse_language"
3911         with method call.
3912         * ada-exp.y (find_primitive_type, type_char)
3913         (type_system_address): Replace "parse_language" with method call.
3914
3915 2019-04-04  Tom Tromey  <tom@tromey.com>
3916
3917         * rust-exp.y: Replace "parse_gdbarch" with method call.
3918         * parse.c (write_dollar_variable, insert_type_address_space):
3919         Replace "parse_gdbarch" with method call.
3920         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3921         call.
3922         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3923         call.
3924         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3925         "parse_gdbarch" with method call.
3926         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3927         with method call.
3928         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3929         "parse_gdbarch" with method call.
3930         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3931         "parse_gdbarch" with method call.
3932         * c-exp.y (parse_type, parse_number, classify_name): Replace
3933         "parse_gdbarch" with method call.
3934         * ada-lex.l: Replace "parse_gdbarch" with method call.
3935         * ada-exp.y (parse_type, find_primitive_type, type_char)
3936         (type_system_address): Replace "parse_gdbarch" with method call.
3937
3938 2019-04-04  Tom Tromey  <tom@tromey.com>
3939
3940         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3941         * stap-probe.c (stap_parse_argument): Update.
3942         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3943         initial_size parameter.
3944         * rust-exp.y (rust_lex_tests): Update.
3945         * parse.c (parser_state): Update.
3946         (parse_exp_in_context): Update.
3947         * parser-defs.h (struct parser_state) <parser_state>: Remove
3948         "initial_size" parameter.
3949
3950 2019-04-04  Tom Tromey  <tom@tromey.com>
3951
3952         * parser-defs.h (increase_expout_size): Don't declare.
3953         * parse.c (increase_expout_size): Now static.
3954
3955 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3956
3957         * gnu-nat.c (gnu_nat_target::wait): Fix
3958         target_waitstatus_to_string call.
3959
3960 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3961
3962         * eval.c (evaluate_subexp_standard): Handle internal functions
3963         during Fortran function call handling.
3964
3965 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3966
3967         * NEWS: Mention new internal functions.
3968         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3969         (read_base_type): Use dwarf2_init_complex_target_type.
3970         * value.c (creal_internal_fn): New function.
3971         (cimag_internal_fn): New function.
3972         (_initialize_values): Register new internal functions.
3973
3974 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3975
3976         * infrun.c (stop_all_threads): If debug_infrun, always
3977         trace the wait status after wait_one, using
3978         target_waitstatus_to_string and target_pid_to_str.
3979         (handle_inferior_event): Replace various trace of
3980         wait status kind by a single trace.
3981         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3982         wait status kind image by target_waitstatus_to_string.
3983         * target/waitstatus.c (target_waitstatus_to_string): Fix
3984         obsolete comment.
3985
3986 2019-04-01  Tom Tromey  <tromey@adacore.com>
3987
3988         PR symtab/23331:
3989         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3990
3991 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3992             Pedro Alves  <palves@redhat.com>
3993
3994         * top.c (quit_force): Call 'finalize_values'.
3995         * value.c (finalize_values): New function.
3996         * value.h (finalize_values): Declare.
3997
3998 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3999
4000         * NEWS: Announce $_gdb_major and $_gdb_minor.
4001
4002         * top.c (init_gdb_version_vars): New function.
4003         (gdb_init): Call init_gdb_version_vars.
4004
4005 2019-03-29  Tom Tromey  <tromey@adacore.com>
4006
4007         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4008         help text.  Remove dead code.
4009
4010 2019-03-29  Keith Seitz  <keiths@redhat.com>
4011
4012         From Siddhesh Poyarekar:
4013         * f-lang.h (f77_get_upperbound): Return LONGEST.
4014         (f77_get_lowerbound): Likewise.
4015         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4016         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4017         print them.
4018         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4019         plongest to format print it.
4020         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4021         (f77_get_upperbound): Likewise.
4022         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4023         LOWER_BOUND to LONGEST.
4024         (f77_create_arrayprint_offset_tbl): Likewise.
4025
4026 2019-03-29  Keith Seitz  <keiths@redhat.com>
4027
4028         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4029         %s/pulongest for TYPE_LENGTH instead of %d in format
4030         strings.
4031         * ada-typerint.c (ada_print_type): Likewise.
4032         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4033         * compile/compile-c-support.c (generate_register_struct): Likewise.
4034         * gdbtypes.c (recursive_dump_type): Likewise.
4035         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4036         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4037         instead of %d in format strings.
4038         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4039         to std::min to ULONGEST.
4040         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4041         instead of %d in format strings.
4042         * tracepoint.c (info_scope_command): Likewise.
4043         * typeprint.c (print_offset_data::update)
4044         (print_offset_data::finish): Likewise.
4045         * xtensa-tdep.c (xtensa_store_return_value)
4046         (xtensa_push_dummy_call): Likewise.
4047
4048 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4049
4050         * windows-nat.c (display_selector): Fixed format specifications
4051         for 64-bit Cygwin.
4052
4053 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4054
4055         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4056
4057 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4058
4059         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4060         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4061         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4062         (nios2_linux_init_abi): Install it.
4063
4064 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4065
4066         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4067
4068 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4069
4070         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4071
4072 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4073             Tom Tromey  <tromey@adacore.com>
4074
4075         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4076
4077 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4078
4079         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4080         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4081         method to compute the bounds of range types. Also print "[evaluated]"
4082         if the bounds' values come from a dynamic evaluation.
4083
4084 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4085
4086         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4087         whitespace when pretty printing is on.
4088
4089 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4090
4091         * ppc-linux-nat.c: Add include.
4092
4093 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4094
4095         * NEWS: Mention AArch64 Pointer Authentication.
4096
4097 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4098
4099         * arm-linux-nat.c: Add include.
4100
4101 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4102
4103         * source-cache.c (source_cache::get_source_lines): Re-read
4104         fullname after calling open_source_file.
4105
4106 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4107
4108         * NEWS: Mention TLS support for FreeBSD.
4109
4110 2019-03-25  Tom Tromey  <tromey@adacore.com>
4111
4112         * minsyms.c (BUNCH_SIZE): Update comment.
4113         (~minimal_symbol_reader): Remove old comment.
4114         (compact_minimal_symbols): Update comment.
4115         (minimal_symbol_reader::install): Remove old comment.  Update
4116         other comments.
4117
4118 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4119
4120         * s390-linux-nat.c: Add include.
4121
4122 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4123
4124         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4125         Call linux_get_hwcap.
4126         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4127         Likewise.
4128         (aarch64_linux_get_hwcap): Remove function.
4129         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4130         declaration.
4131         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4132         linux_get_hwcap.
4133         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4134         * linux-tdep.c (linux_get_hwcap): Add function.
4135         (linux_get_hwcap2): Likewise.
4136         * linux-tdep.h (linux_get_hwcap): Add declaration.
4137         (linux_get_hwcap2): Likewise.
4138         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4139         (ppc_linux_get_hwcap2): Likewise.
4140         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4141         linux_get_hwcap.
4142         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4143         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4144         (ppc_linux_nat_target::read_description): Likewise.
4145         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4146         * s390-linux-nat.c: Likewise.
4147         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4148
4149 2019-03-24  Tom Tromey  <tom@tromey.com>
4150
4151         * ada-lang.c (standard_lookup): Simplify initialization.
4152         (ada_lookup_symbol_nonlocal): Simplify return.
4153         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4154         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4155         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4156         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4157         initialization.
4158         * solib.c (solib_global_lookup): Simplify.
4159         * symtab.c (null_block_symbol): Remove.
4160         (symbol_cache_lookup): Simplify returns.
4161         (lookup_language_this): Simplify returns.
4162         (lookup_symbol_aux): Simplify return.
4163         (lookup_local_symbol): Simplify returns.
4164         (lookup_global_symbol_from_objfile): Simplify return.
4165         (lookup_symbol_in_objfile_symtabs)
4166         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4167         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4168         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4169         * cp-namespace.c (cp_lookup_bare_symbol)
4170         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4171         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4172         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4173         (cp_lookup_symbol_via_imports): Simplify initialization.
4174         (find_symbol_in_baseclass): Likewise.
4175         * symtab.h (null_block_symbol): Remove.
4176         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4177         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4178         (d_lookup_symbol_module): Likewise.
4179         (find_symbol_in_baseclass): Simplify initialization.
4180
4181 2019-03-24  Tom Tromey  <tom@tromey.com>
4182
4183         * expression.h: Don't include symtab.h.
4184         (struct block): Forward declare.
4185
4186 2019-03-24  Tom Tromey  <tom@tromey.com>
4187
4188         * c-exp.y (typebase): Remove casts.
4189         * gdbtypes.c (lookup_unsigned_typename, )
4190         (lookup_signed_typename): Remove cast.
4191         * eval.c (parse_to_comma_and_eval): Remove cast.
4192         * parse.c (write_dollar_variable): Remove cast.
4193         * block.h (struct block) <superblock>: Now const.
4194         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4195         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4196         (map_block): Make "block" const.
4197         * symfile.h (struct quick_symbol_functions)
4198         <map_matching_symbols>: Constify block argument to "callback".
4199         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4200         const.
4201         (find_pc_sect_compunit_symtab): Make "b" const.
4202         (find_symbol_at_address): Likewise.
4203         (search_symbols): Likewise.
4204         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4205         (dw2_debug_names_lookup_symbol): Likewise.
4206         (dw2_map_matching_symbols): Update.
4207         * p-valprint.c (pascal_val_print): Remove "block".
4208         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4209         (aux_add_nonlocal_symbols): Make "block" const.
4210         (resolve_subexp): Remove cast.
4211         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4212         const.
4213         (iterate_over_file_blocks): Likewise.
4214         * f-exp.y (%union) <bval>: Remove.
4215         * coffread.c (patch_opaque_types): Make "b" const.
4216         * spu-tdep.c (spu_catch_start): Make "block" const.
4217         * c-valprint.c (print_unpacked_pointer): Remove "block".
4218         * symmisc.c (dump_symtab_1): Make "b" const.
4219         (block_depth): Make "block" const.
4220         * d-exp.y (%union) <bval>: Remove.
4221         * cp-support.h (cp_lookup_rtti_type): Update.
4222         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4223         * psymtab.c (psym_lookup_symbol): Make "block" const.
4224         (maintenance_check_psymtabs): Make "b" const.
4225         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4226         (enumerate_locals, enumerate_args): Update.
4227         * python/py-symtab.c (stpy_global_block): Make "block" const.
4228         (stpy_static_block): Likewise.
4229         * inline-frame.c (block_starting_point_at): Make "new_block"
4230         const.
4231         * block.c (find_block_in_blockvector): Make return type const.
4232         (blockvector_for_pc_sect): Make "b" const.
4233         (find_block_in_blockvector): Make "b" const.
4234
4235 2019-03-23  Tom Tromey  <tom@tromey.com>
4236
4237         * varobj.c (varobj_create): Update.
4238         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4239         * printcmd.c (display_command, do_one_display): Don't reset
4240         innermost_block.
4241         * parser-defs.h (enum innermost_block_tracker_type): Move to
4242         expression.h.
4243         (innermost_block): Update comment.
4244         * parse.c (parse_exp_1): Add tracker_types parameter.
4245         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4246         tracker_types parameter.  Reset innermost_block.
4247         (parse_exp_in_context): Remove.
4248         (parse_expression_for_completion): Update.
4249         * objfiles.c (~objfile): Don't reset expression_context_block or
4250         innermost_block.
4251         * expression.h (enum innermost_block_tracker_type): Move from
4252         parser-defs.h.
4253         (parse_exp_1): Add tracker_types parameter.
4254         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4255         reset innermost_block.
4256
4257 2019-03-23  Tom Tromey  <tom@tromey.com>
4258
4259         * objfiles.h: Include bcache.h.
4260
4261 2019-03-23  Tom Tromey  <tom@tromey.com>
4262
4263         * linespec.c (get_current_search_block): Use
4264         scoped_restore_current_language.
4265         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4266
4267 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4268             Jiong Wang  <jiong.wang@arm.com>
4269
4270         * aarch64-linux-tdep.c
4271         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4272         section.
4273         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4274
4275 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4276             Jiong Wang  <jiong.wang@arm.com>
4277
4278         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4279         instructions.
4280         (aarch64_analyze_prologue_test): Add PACIASP test.
4281         (aarch64_prologue_prev_register): Unmask PC value.
4282
4283 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4284             Jiong Wang  <jiong.wang@arm.com>
4285
4286         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4287         (aarch64_dwarf2_prev_register): Unmask PC value.
4288         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4289         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4290         DW_CFA_AARCH64_negate_ra_state.
4291         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4292
4293 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4294             Jiong Wang  <jiong.wang@arm.com>
4295
4296         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4297         registers.
4298         (aarch64_pseudo_register_name): Likewise.
4299         (aarch64_pseudo_register_type): Likewise.
4300         (aarch64_pseudo_register_reggroup_p): Likewise.
4301         (aarch64_gdbarch_init): Add pauth registers.
4302         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4303         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4304         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4305         (struct gdbarch_tdep): Add regnum for ra_state.
4306
4307 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4308             Jiong Wang  <jiong.wang@arm.com>
4309
4310         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4311
4312 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4313             Jiong Wang  <jiong.wang@arm.com>
4314
4315         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4316         function.
4317         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4318         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4319         (aarch64_gdbarch_init): Add puth registers.
4320         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4321         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4322         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4323
4324 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4325             Jiong Wang  <jiong.wang@arm.com>
4326
4327         * aarch64-linux-nat.c
4328         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4329         * aarch64-linux-tdep.c
4330         (aarch64_linux_core_read_description): Likewise.
4331         (aarch64_linux_get_hwcap): New function.
4332         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4333         (aarch64_linux_get_hwcap): New declaration.
4334
4335 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4336             Jiong Wang  <jiong.wang@arm.com>
4337
4338         * aarch64-linux-nat.c
4339         (aarch64_linux_nat_target::read_description): Add pauth param.
4340         * aarch64-linux-tdep.c
4341         (aarch64_linux_core_read_description): Likewise.
4342         * aarch64-tdep.c (struct target_desc): Add in pauth.
4343         (aarch64_read_description): Add pauth param.
4344         (aarch64_gdbarch_init): Likewise.
4345         * aarch64-tdep.h (aarch64_read_description): Likewise.
4346         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4347         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4348         * features/Makefile: Add new files.
4349         * features/aarch64-pauth.c: New file.
4350         * features/aarch64-pauth.xml: New file.
4351
4352 2019-03-20  Tom Tromey  <tromey@adacore.com>
4353
4354         * infrun.c (handle_inferior_event): Rename from
4355         handle_inferior_event_1.  Create a scoped_value_mark.
4356         (handle_inferior_event): Remove.
4357
4358 2019-03-19  Tom Tromey  <tromey@adacore.com>
4359
4360         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4361         * infrun.h (print_stop_event): Add "displays" parameter.
4362         * infrun.c (print_stop_event): Add "displays" parameter.
4363
4364 2019-03-19  Pedro Alves  <palves@redhat.com>
4365
4366         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4367         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4368         to -1.  Fix TABs vs spaces.
4369         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4370         * tui/tui-out.h (tui_ui_out) Add intro comments.
4371         <m_line, m_start_of_line>: In-class initialize, and add describing
4372         comment.
4373
4374 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4375
4376         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4377         variable names.
4378         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4379
4380 2019-03-18  Pedro Alves  <palves@redhat.com>
4381             Eli Zaretskii <eliz@gnu.org>
4382
4383         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4384         m_line and m_start_of_line.
4385
4386 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4387
4388         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4389         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4390         it returns a newline.  This fixes a regression in TU mode, whereby
4391         the next line is output on the same screen line as the user input.
4392
4393 2019-03-18  Tom Tromey  <tromey@adacore.com>
4394
4395         * minsyms.c (minimal_symbol_reader::install): Remove call to
4396         obstack_blank.
4397
4398 2019-03-18  Pedro Alves  <palves@redhat.com>
4399
4400         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4401         New globals.
4402         (apply_style): New, factored out from ...
4403         (apply_ansi_escape): ... this.  Handle reverse video mode.
4404         (tui_set_reverse_mode): New function.
4405         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4406         * tui/tui-winsource.c (tui_show_source_line): Use
4407         tui_set_reverse_mode instead of setting A_STANDOUT.
4408         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4409         New setter methods.
4410
4411 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4412
4413         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4414         Handle tabs.
4415
4416 2019-03-18  Tom Tromey  <tromey@adacore.com>
4417
4418         * ada-lang.c (empty_array): Add "high" parameter.
4419         (ada_evaluate_subexp): Update.
4420
4421 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4422
4423         * unittests/string_view-selftests.c: Define
4424         _initialize_string_view_selftests unconditionally.
4425
4426 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4427
4428         PR gdb/24350
4429         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4430
4431 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4432
4433         PR gdb/24351
4434         * windows-nat.c (display_selector): Fix format specifiers.
4435
4436 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4437
4438         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4439         tui_refill_source_window instead of tui_refresh_win, to update the
4440         current execution line.  This fixes redisplay of the current line
4441         when stepping through the code with "next" or "step".
4442
4443 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4444
4445         * source-cache.c (source_cache::get_source_lines): Call
4446         find_source_lines to initialize s->nlines.  This fixes vertical
4447         scrolling of TUI source window when the DOWN arrow is pressed.
4448
4449 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4450
4451         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4452         linux-thread-db.c (_initialize_thread_db): Likewise.
4453
4454 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4455
4456         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4457         wclrtoeol in tui_show_source_line".  This reverts changes made in
4458         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4459
4460 2019-03-15  Tom Tromey  <tom@tromey.com>
4461
4462         * symtab.h (struct minimal_symbol): Derive from
4463         general_symbol_info.
4464         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4465         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4466         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4467         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4468         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4469         (MSYMBOL_SEARCH_NAME): Update.
4470         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4471         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4472         * minsyms.c (minimal_symbol_reader::record_full): Update.
4473
4474 2019-03-15  Tom Tromey  <tom@tromey.com>
4475
4476         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4477
4478 2019-03-15  Tom Tromey  <tom@tromey.com>
4479
4480         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4481         unique_xmalloc_ptr.
4482         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4483         Update.
4484         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4485         (build_minimal_symbol_hash_tables)
4486         (minimal_symbol_reader::install): Update.
4487
4488 2019-03-15  Tom Tromey  <tom@tromey.com>
4489
4490         * symtab.c (create_demangled_names_hash): Update.
4491         (symbol_set_names): Update.
4492         * objfiles.h (struct objfile_per_bfd_storage)
4493         <demangled_names_hash>: Now an htab_up.
4494         * objfiles.c (objfile_per_bfd_storage): Simplify.
4495
4496 2019-03-15  Tom Tromey  <tom@tromey.com>
4497
4498         * objfiles.h (struct objfile_per_bfd_storage): Declare
4499         destructor.
4500         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4501         New.
4502         (get_objfile_bfd_data): Use new.  Don't initialize
4503         language_of_main.
4504         (free_objfile_per_bfd_storage): Remove.
4505         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4506
4507 2019-03-15  Tom Tromey  <tom@tromey.com>
4508
4509         * symfile.c (reread_symbols): Update.
4510         * objfiles.c (objfile::objfile): Update.
4511         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4512         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4513         comment.
4514         (minimal_symbol_reader::install): Update.
4515         (terminate_minimal_symbol_table): Remove.
4516         * jit.c (jit_object_close_impl): Update.
4517
4518 2019-03-15  Tom Tromey  <tom@tromey.com>
4519
4520         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4521         initializations.
4522
4523 2019-03-15  Tom Tromey  <tom@tromey.com>
4524
4525         * objfiles.h (struct objfile_per_bfd_storage)
4526         <demangled_hash_languages>: Now a bitset.
4527         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4528         (lookup_minimal_symbol): Update.
4529
4530 2019-03-15  Tom Tromey  <tom@tromey.com>
4531
4532         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4533         Don't return the symbol.
4534         * coffread.c (record_minimal_symbol): Use record_full.
4535
4536 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4537
4538         The MS-Windows port of ncurses fails to switch to a color pair if
4539         one or both of the colors are the implicit default colors.  This
4540         change records the default colors when TUI is initialized, and
4541         then specifies them explicitly when a color pair uses the default
4542         colors.  This allows color styling in TUI mode on MS-Windows.
4543
4544         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4545         ncurses_norm_attr.
4546         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4547         colors in ncurses_norm_attr.
4548         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4549         "none", replace it with the default color recorded in
4550         ncurses_norm_attr.
4551
4552 2019-03-14  Tom Tromey  <tromey@adacore.com>
4553
4554         * source-cache.h (class source_cache) <get_source_lines>: Return
4555         std::string.
4556         * source-cache.c (source_cache::extract_lines): Handle case where
4557         first_pos==npos.  Return std::string.
4558         (source_cache::get_source_lines): Update.
4559
4560 2019-03-14  Tom Tromey  <tromey@adacore.com>
4561
4562         * NEWS: Add item for "style sources" commands.
4563         * source-cache.c (source_cache::get_source_lines): Check
4564         source_styling.
4565         * cli/cli-style.c (source_styling): New global.
4566         (_initialize_cli_style): Add "style sources" commands.
4567         (show_style_sources): New function.
4568         * cli/cli-style.h (source_styling): Declare.
4569
4570 2019-03-14  Pedro Alves  <palves@redhat.com>
4571             Tom Tromey  <tromey@adacore.com>
4572
4573         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4574         * tui/tui-winsource.c (tui_refill_source_window): New function,
4575         from...
4576         (tui_horizontal_source_scroll): ... here.  Move some logic.
4577         * cli/cli-style.c (set_style_enabled): Notify new observable.
4578         * tui/tui-hooks.c (tui_redisplay_source): New function.
4579         (tui_attach_detach_observers): Attach or detach
4580         tui_redisplay_source.
4581         * observable.h (source_styling_changed): New observable.
4582         * observable.c: Define source_styling_changed observable.
4583
4584 2019-03-13  Tom Tromey  <tromey@adacore.com>
4585
4586         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4587         (i386_gnu_nat_target::store_registers): Update.
4588         * target-debug.h (target_debug_print_std_string): New macro.
4589         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4590         * windows-tdep.c (display_one_tib): Update.
4591         * tui/tui-stack.c (tui_make_status_line): Update.
4592         * top.c (print_inferior_quit_action): Update.
4593         * thread.c (thr_try_catch_cmd): Update.
4594         (add_thread_with_info): Update.
4595         (thread_target_id_str): Update.
4596         (thr_try_catch_cmd): Update.
4597         (thread_command): Update.
4598         (thread_find_command): Update.
4599         * record-btrace.c (record_btrace_target::info_record)
4600         (record_btrace_resume_thread, record_btrace_target::resume)
4601         (record_btrace_cancel_resume, record_btrace_step_thread)
4602         (record_btrace_target::wait, record_btrace_target::wait)
4603         (record_btrace_target::wait, record_btrace_target::stop): Update.
4604         * progspace.c (print_program_space): Update.
4605         * process-stratum-target.c
4606         (process_stratum_target::thread_address_space): Update.
4607         * linux-fork.c (linux_fork_mourn_inferior)
4608         (detach_checkpoint_command, info_checkpoints_command)
4609         (linux_fork_context): Update.
4610         (linux_fork_detach): Update.
4611         (class scoped_switch_fork_info): Update.
4612         (delete_checkpoint_command): Update.
4613         * infrun.c (follow_fork_inferior): Update.
4614         (follow_fork_inferior): Update.
4615         (proceed_after_vfork_done): Update.
4616         (handle_vfork_child_exec_or_exit): Update.
4617         (follow_exec): Update.
4618         (displaced_step_prepare_throw): Update.
4619         (displaced_step_restore): Update.
4620         (start_step_over): Update.
4621         (resume_1): Update.
4622         (clear_proceed_status_thread): Update.
4623         (proceed): Update.
4624         (print_target_wait_results): Update.
4625         (do_target_wait): Update.
4626         (context_switch): Update.
4627         (stop_all_threads): Update.
4628         (restart_threads): Update.
4629         (finish_step_over): Update.
4630         (handle_signal_stop): Update.
4631         (switch_back_to_stepped_thread): Update.
4632         (keep_going_pass_signal): Update.
4633         (print_exited_reason): Update.
4634         (normal_stop): Update.
4635         * inferior.c (inferior_pid_to_str): Change return type.
4636         (print_selected_inferior): Update.
4637         (add_inferior): Update.
4638         (detach_inferior): Update.
4639         * dummy-frame.c (fprint_dummy_frames): Update.
4640         * dcache.c (dcache_info_1): Update.
4641         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4642         (btrace_fetch, btrace_clear): Update.
4643         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4644         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4645         type.
4646         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4647         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4648         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4649         * gdbarch.c, gdbarch.h: Rebuild.
4650         * gdbarch.sh (core_pid_to_str): Change return type.
4651         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4652         return type.
4653         (windows_nat_target::pid_to_str): Change return type.
4654         (windows_delete_thread): Update.
4655         (windows_nat_target::attach): Update.
4656         (windows_nat_target::files_info): Update.
4657         * target-delegates.c: Rebuild.
4658         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4659         return type.
4660         (sol_thread_target::pid_to_str): Change return type.
4661         * remote.c (class remote_target) <pid_to_str>: Change return
4662         type.
4663         (remote_target::pid_to_str): Change return type.
4664         (extended_remote_target::attach, remote_target::remote_stop_ns)
4665         (remote_target::remote_notif_remove_queued_reply)
4666         (remote_target::push_stop_reply, remote_target::disable_btrace):
4667         Update.
4668         (extended_remote_target::attach): Update.
4669         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4670         type.
4671         (gdbsim_target::pid_to_str): Change return type.
4672         * ravenscar-thread.c (struct ravenscar_thread_target)
4673         <pid_to_str>: Change return type.
4674         (ravenscar_thread_target::pid_to_str): Change return type.
4675         * procfs.c (class procfs_target) <pid_to_str>: Change return
4676         type.
4677         (procfs_target::pid_to_str): Change return type.
4678         (procfs_target::attach): Update.
4679         (procfs_target::detach): Update.
4680         (procfs_target::fetch_registers): Update.
4681         (procfs_target::store_registers): Update.
4682         (procfs_target::wait): Update.
4683         (procfs_target::files_info): Update.
4684         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4685         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4686         return type.
4687         (nto_procfs_target::pid_to_str): Change return type.
4688         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4689         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4690         return type.
4691         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4692         (exit_lwp): Update.
4693         (attach_proc_task_lwp_callback, get_detach_signal)
4694         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4695         (linux_nat_target::resume, wait_lwp, stop_callback)
4696         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4697         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4698         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4699         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4700         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4701         type.
4702         (inf_ptrace_target::attach): Update.
4703         (inf_ptrace_target::files_info): Update.
4704         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4705         type.
4706         (go32_nat_target::pid_to_str): Change return type.
4707         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4708         (gnu_nat_target::wait): Update.
4709         (gnu_nat_target::wait): Update.
4710         (gnu_nat_target::resume): Update.
4711         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4712         (fbsd_nat_target::wait): Update.
4713         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4714         type.
4715         (darwin_nat_target::attach): Update.
4716         * corelow.c (class core_target) <pid_to_str>: Change return type.
4717         (core_target::pid_to_str): Change return type.
4718         * target.c (normal_pid_to_str): Change return type.
4719         (default_pid_to_str): Likewise.
4720         (target_pid_to_str): Change return type.
4721         (target_translate_tls_address): Update.
4722         (target_announce_detach): Update.
4723         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4724         return type.
4725         (bsd_uthread_target::pid_to_str): Change return type.
4726         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4727         type.
4728         (bsd_kvm_target::pid_to_str): Change return type.
4729         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4730         return type.
4731         (aix_thread_target::pid_to_str): Change return type.
4732         * target.h (struct target_ops) <pid_to_str>: Change return type.
4733         (target_pid_to_str, normal_pid_to_str): Likewise.
4734         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4735         type.
4736         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4737         type.
4738         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4739         return type.
4740         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4741         type.
4742         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4743         type.
4744         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4745         return type.
4746
4747 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4748
4749         * NEWS: Mention that the new default MI version is 3.  Mention
4750         changes to the output of commands and events that deal with
4751         multi-location breakpoints.
4752         * breakpoint.c: Include "mi/mi-out.h".
4753         (print_one_breakpoint): Change output syntax if using MI version
4754         >= 3.
4755         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4756         New.
4757         (mi_multi_location_breakpoint_output_fixed): New.
4758         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4759         (mi_cmd_fix_multi_location_breakpoint_output): New.
4760         (mi_multi_location_breakpoint_output_fixed): New.
4761         * mi/mi-cmds.c (mi_cmds): Register command
4762         -fix-multi-location-breakpoint-output.
4763         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4764         interpreter "mi".
4765
4766 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4767
4768         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4769         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4770         instantiate mi_ui_out based on interpreter name.
4771         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4772         * mi/mi-main.c (mi_load_progress): Likewise.
4773
4774 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4775
4776         * NEWS: Combine separate "New targets" sections for 8.3.
4777
4778 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4779
4780         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4781         (ppcfbsd_init_abi): Install gdbarch
4782         "fetch_tls_load_module_address" and "get_thread_local_address"
4783         methods.
4784
4785 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4786
4787         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4788         (riscv_fbsd_init_abi): Install gdbarch
4789         "fetch_tls_load_module_address" and "get_thread_local_address"
4790         methods.
4791
4792 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4793
4794         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4795         (i386fbsd_init_abi): Install gdbarch
4796         "fetch_tls_load_module_address" and "get_thread_local_address"
4797         methods.
4798
4799 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4800
4801         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4802         (amd64fbsd_init_abi): Install gdbarch
4803         "fetch_tls_load_module_address" and "get_thread_local_address"
4804         methods.
4805
4806 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4807
4808         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4809         (struct fbsd_pspace_data): New type.
4810         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4811         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4812         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4813         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4814         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4815
4816 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4817
4818         * gdbtypes.c (lookup_struct_elt): New function.
4819         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4820         * gdbtypes.h (struct struct_elt): New type.
4821         (lookup_struct_elt): New prototype.
4822
4823 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4824
4825         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4826         remove disabled code block.
4827
4828 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4829
4830         * gdbarch.sh (get_thread_local_address): New method.
4831         * gdbarch.h, gdbarch.c: Regenerate.
4832         * target.c (target_translate_tls_address): Use
4833         gdbarch_get_thread_local_address if present instead of
4834         target::get_thread_local_address.
4835
4836 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4837
4838         * target.h (target::get_thread_local_address): Update comment.
4839
4840 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4841
4842         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4843         objfile->separate_debug_objfile_backlink if not NULL.
4844
4845 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4846
4847         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4848         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4849         (amd64bsd_store_inferior_registers): Likewise.
4850         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4851         Enable segment base registers.
4852         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4853         PT_GETFSBASE and PT_GETGSBASE.
4854         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4855         PT_SETGSBASE.
4856         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4857         segment base registers.
4858         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4859
4860 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4861
4862         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4863         Update calls to i386_target_description to add 'segments'
4864         parameter.
4865         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4866         add segment base registers.
4867         * arch/i386.c (i386_create_target_description): Add 'segments'
4868         parameter to enable segment base registers.
4869         * arch/i386.h (i386_create_target_description): Likewise.
4870         * features/i386/32bit-segments.xml: New file.
4871         * features/i386/32bit-segments.c: Generate.
4872         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4873         call to i386_target_description to add 'segments' parameter.
4874         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4875         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4876         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4877         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4878         if feature is present.
4879         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4880         Add 'segments' parameter to call to i386_target_description.
4881         (i386_target_description): Add 'segments' parameter to enable
4882         segment base registers.
4883         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4884         to call to i386_target_description.
4885         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4886         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4887         Define I386_NUM_REGS.
4888         (i386_target_description): Add 'segments' parameter to enable
4889         segment base registers.
4890
4891 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4892
4893         PR/24325
4894         * source-cache.c: #undef open and close, to avoid unresolved
4895         externals during linking.
4896
4897 2019-03-12  Tom Tromey  <tromey@adacore.com>
4898
4899         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4900         const.  Add initializers.
4901         (_initialize_remote): Don't initialize ptid globals.
4902
4903 2019-03-12  Pedro Alves  <palves@redhat.com>
4904
4905         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4906
4907 2019-03-12  Pedro Alves  <palves@redhat.com>
4908
4909         * cp-name-parser.y (main): Remove unused 'len' variable.
4910
4911 2019-03-12  Tom Tromey  <tromey@adacore.com>
4912
4913         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4914         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4915
4916 2019-03-12  Tom Tromey  <tromey@adacore.com>
4917
4918         * linux-nat.c (iterate_over_lwps): Update.
4919         (stop_callback): Remove parameter.
4920         (stop_wait_callback, detach_callback, resume_set_callback)
4921         (select_singlestep_lwp_callback, set_ignore_sigint)
4922         (status_callback, resumed_callback, resume_clear_callback)
4923         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4924         data parameter.
4925         (linux_nat_target::detach, linux_nat_target::resume)
4926         (linux_stop_and_wait_all_lwps, select_event_lwp)
4927         (linux_nat_filter_event, linux_nat_wait_1)
4928         (linux_nat_target::kill, linux_nat_target::stop)
4929         (linux_nat_target::stop): Update.
4930         (linux_nat_resume_callback): Change type.
4931         (resume_stopped_resumed_lwps, count_events_callback)
4932         (select_event_lwp_callback): Likewise.
4933         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4934         * arm-linux-nat.c (struct update_registers_data): Remove.
4935         (update_registers_callback): Change type.
4936         (arm_linux_insert_hw_breakpoint1): Update.
4937         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4938         parameter.
4939         (x86_linux_dr_set_addr): Update.
4940         (x86_linux_dr_set_control): Update.
4941         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4942         (iterate_over_lwps): Use gdb::function_view.
4943         * nat/aarch64-linux-hw-point.c (struct
4944         aarch64_dr_update_callback_param): Remove.
4945         (debug_reg_change_callback): Change type.
4946         (aarch64_notify_debug_reg_change): Update.
4947         * s390-linux-nat.c (s390_refresh_per_info): Update.
4948
4949 2019-03-11  Tom Tromey  <tromey@adacore.com>
4950
4951         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4952         redundant assignment to "this_cu".
4953
4954 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4955
4956         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4957
4958 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4959
4960         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4961         from...
4962         (rank_one_type): ... this.
4963
4964 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4965
4966         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4967         from...
4968         (rank_one_type): ... this.
4969
4970 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4971
4972         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4973         from...
4974         (rank_one_type): ... this.
4975
4976 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4977
4978         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4979         from...
4980         (rank_one_type): ... this.
4981
4982 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4983
4984         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4985         from...
4986         (rank_one_type): ... this.
4987
4988 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4989
4990         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4991         from...
4992         (rank_one_type): ... this.
4993
4994 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4995
4996         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4997         from...
4998         (rank_one_type): ... this.
4999
5000 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5001
5002         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5003         from...
5004         (rank_one_type): ... this.
5005
5006 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5007
5008         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5009         from...
5010         (rank_one_type): ... this.
5011
5012 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5013
5014         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5015         from...
5016         (rank_one_type): ... this.
5017
5018 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5019
5020         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5021         from...
5022         (rank_one_type): ... this.
5023
5024 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5025
5026         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5027         from...
5028         (rank_one_type): ... this.
5029
5030 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5031
5032         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5033         inferior-events' shows the example events.
5034
5035 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5036
5037         Support styling on native MS-Windows console
5038
5039         PR/24315
5040         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5041         on MS-Windows if $TERM is not defined.
5042
5043         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5044
5045         * posix-hdep.c (gdb_console_fputs):
5046         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5047         functions.
5048         * ui-file.h (gdb_console_fputs): Add prototype.
5049
5050         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5051         back to fputs only if the former returns zero.
5052
5053 2019-03-07  Tom Tromey  <tom@tromey.com>
5054
5055         * symmisc.c (print_symbol_bcache_statistics): Update.
5056         (print_objfile_statistics): Update.
5057         * symfile.c (allocate_symtab): Update.
5058         * stabsread.c: Don't include bcache.h.
5059         * psymtab.h (struct psymbol_bcache): Don't declare.
5060         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5061         (psymbol_bcache_init, psymbol_bcache_free)
5062         (psymbol_bcache_get_bcache): Don't declare.
5063         * psymtab.c (struct psymbol_bcache): Remove.
5064         (psymtab_storage::psymtab_storage): Update.
5065         (psymtab_storage::~psymtab_storage): Update.
5066         (psymbol_bcache_init, psymbol_bcache_free)
5067         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5068         (add_psymbol_to_bcache): Update.
5069         (allocate_psymtab): Update.
5070         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5071         macro_cache>: No longer pointers.
5072         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5073         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5074         * macrotab.c (macro_bcache): Update.
5075         * macroexp.c: Don't include bcache.h.
5076         * gdbtypes.c (check_types_worklist): Update.
5077         (types_deeply_equal): Remove TRY/CATCH.  Update.
5078         * elfread.c (elf_symtab_read): Update.
5079         * dwarf2read.c: Don't include bcache.h.
5080         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5081         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5082         (print_bcache_statistics, bcache_memory_used): Don't declare.
5083         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5084         methods.  Rename all data members.
5085         * bcache.c (struct bcache): Move to bcache.h.
5086         (bcache::expand_hash_table): Rename from expand_hash_table.
5087         (bcache): Remove.
5088         (bcache::insert): Rename from bcache_full.
5089         (bcache::compare): Rename from bcache_compare.
5090         (bcache_xmalloc): Remove.
5091         (bcache::~bcache): Rename from bcache_xfree.
5092         (bcache::print_statistics): Rename from print_bcache_statistics.
5093         (bcache::memory_used): Rename from bcache_memory_used.
5094
5095 2019-03-07  Pedro Alves  <palves@redhat.com>
5096
5097         * infrun.c (normal_stop): Also check for
5098         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5099
5100 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5101
5102         * f-lang.c (value_from_host_double): Moved to...
5103         * value.c (value_from_host_double): ...here.
5104         * value.h (value_from_host_double): Declare.
5105         * guile/scm-math.c (vlscm_convert_typed_number): Use
5106         value_from_host_double.
5107         (vlscm_convert_number): Likewise.
5108         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5109         * python/py-value.c (convert_value_from_python): Likewise.
5110
5111 2019-03-06  Tom Tromey  <tom@tromey.com>
5112
5113         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5114
5115 2019-03-06  Tom Tromey  <tom@tromey.com>
5116
5117         * utils.h (free_current_contents): Don't declare.
5118         * utils.c (free_current_contents): Remove.
5119
5120 2019-03-06  Tom Tromey  <tom@tromey.com>
5121
5122         * top.c (quit_force): Update.
5123         * main.c (captured_command_loop): Update.
5124         * common/new-op.c (operator new): Update.
5125         * common/common-exceptions.c (struct catcher)
5126         <save_cleanup_chain>: Remove member.
5127         (exceptions_state_mc_init): Update.
5128         (exception_try_scope_entry): Return nullptr.
5129         (exception_try_scope_exit, exception_rethrow)
5130         (throw_exception_sjlj, throw_exception_cxx): Update.
5131         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5132         (all_cleanups, do_cleanups, discard_cleanups)
5133         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5134         (restore_cleanups, restore_final_cleanups): Don't declare.
5135         (do_final_cleanups): Remove parameter.
5136         * common/cleanups.c (cleanup_chain, make_cleanup)
5137         (make_cleanup_dtor, all_cleanups, do_cleanups)
5138         (discard_my_cleanups, discard_cleanups)
5139         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5140         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5141         (null_cleanup): Remove.
5142         (do_final_cleanups): Remove parameter.
5143
5144 2019-03-06  Tom Tromey  <tom@tromey.com>
5145
5146         * remote.c (remote_target::remote_parse_stop_reply): Use
5147         unique_xmalloc_ptr.
5148
5149 2019-03-06  Tom Tromey  <tom@tromey.com>
5150
5151         * stabsread.c (struct stabs_field_info): Rename from field_info.
5152         <list, fnlist>: Add initializers.
5153         <obstack>: New member.
5154         (read_member_functions, read_struct_fields, read_baseclasses):
5155         Allocate on obstack.  Don't use cleanups.
5156         (read_one_struct_field, read_member_functions, read_struct_fields)
5157         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5158         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5159         (read_struct_type): Update.
5160
5161 2019-03-06  Tom Tromey  <tom@tromey.com>
5162
5163         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5164         * common/filestuff.h (make_cleanup_close): Don't declare.
5165         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5166         Remove.
5167
5168 2019-03-06  Tom Tromey  <tom@tromey.com>
5169
5170         * solib-aix.c: Use make_scope_exit.
5171
5172 2019-03-06  Tom Tromey  <tom@tromey.com>
5173
5174         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5175         Use make_scope_exit.
5176
5177 2019-03-06  Tom Tromey  <tom@tromey.com>
5178
5179         * solib-svr4.c (disable_probes_interface): Remove parameter.
5180         (svr4_handle_solib_event): Use make_scope_exit.
5181
5182 2019-03-06  Tom Tromey  <tom@tromey.com>
5183
5184         * remote.c (struct stop_reply_deleter): Remove.
5185         (stop_reply_up): Update.
5186         (struct stop_reply): Derive from notif_event.  Don't typedef.
5187         <regcache>: Now a std::vector.
5188         (stop_reply_xfree): Remove.
5189         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5190         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5191         (remote_target::discard_pending_stop_replies): Use delete.
5192         (remote_target::remote_parse_stop_reply): Update.
5193         (remote_target::process_stop_reply): Update.
5194         * remote-notif.h (struct notif_event): Add virtual destructor.
5195         Remove "dtr" member.
5196         (struct notif_client) <alloc_event>: Return a unique_ptr.
5197         (notif_event_xfree): Don't declare.
5198         (notif_event_up): New typedef.
5199         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5200         (notif_event_xfree, do_notif_event_xfree): Remove.
5201         (remote_notif_state_xfree): Update.
5202
5203 2019-03-06  Tom Tromey  <tom@tromey.com>
5204
5205         * infrun.c (displaced_step_clear_cleanup): Now a
5206         forward_scope_exit type.
5207         (displaced_step_prepare_throw): Update.
5208         (displaced_step_fixup): Update.
5209
5210 2019-03-06  Tom Tromey  <tom@tromey.com>
5211
5212         * inferior.h (class inferior): Update comment.
5213         * gdbthread.h (class thread_info): Update comment.
5214
5215 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5216             Tom Tromey  <tom@tromey.com>
5217
5218         * stabsread.h (struct stab_section_list): Remove.
5219         (coffstab_build_psymtabs): Update.
5220         * dbxread.c (symbuf_sections): Now a std::vector.
5221         (sect_idx): New global.
5222         (fill_symbuf): Update.
5223         (coffstab_build_psymtabs): Change type of stabsects parameter.
5224         Update.
5225         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5226         std::vector.
5227         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5228         (coff_locate_sections): Update.
5229         (coff_symfile_read): Remove cleanups.  Update.
5230         (init_stringtab): Add storage parameter.
5231         (free_stringtab, free_stringtab_cleanup): Remove.
5232         (init_lineno): Add storage parameter.
5233         (free_linetab, free_linetab_cleanup): Remove.
5234
5235 2019-03-06  Pedro Alves  <palves@redhat.com>
5236
5237         * linux-fork.c (fork_info::clobber_regs): Delete.
5238         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5239         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5240         comment.  Adjust.
5241         (scoped_switch_fork_info::scoped_switch_fork_info)
5242         (checkpoint_command, linux_fork_context): Adjust
5243         fork_save_infrun_state calls.
5244
5245 2019-03-06  Pedro Alves  <palves@redhat.com>
5246
5247         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5248         (inf_has_multiple_threads): Return 'bool' and rewrite using
5249         inferior_info::threads().
5250
5251 2019-03-06  Pedro Alves  <palves@redhat.com>
5252
5253         * linux-fork.c: Include <list>.
5254         (fork_list): Now a std::list instance.
5255         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5256         (forks_exist_p, find_last_fork): Adjust.
5257         (new_fork): Delete.
5258         (one_fork_p): New.
5259         (add_fork): Adjust.
5260         (free_fork): Delete, folded into fork_info::~fork_info().
5261         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5262         Adjust.
5263         (init_fork_list): Delete.
5264         (linux_fork_killall, linux_fork_mourn_inferior)
5265         (linux_fork_detach, info_checkpoints_command): Adjust.
5266         (_initialize_linux_fork): No longer call init_fork_list.
5267
5268 2019-03-06  Pedro Alves  <palves@redhat.com>
5269
5270         * linux-fork.c (new_fork): New, split out of ...
5271         (add_fork): ... this.  Return void.  Move "first fork" special
5272         case from here, to ...
5273         (checkpoint_command): ... here.
5274         * linux-linux.h (add_fork): Return void.
5275
5276 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5277
5278         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5279
5280 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5281             Chris January  <chris.january@arm.com>
5282             David Lecomber  <david.lecomber@arm.com>
5283
5284         * f-exp.y: New token, UNOP_INTRINSIC.
5285         (exp): New pattern using UNOP_INTRINSIC token.
5286         (f77_keywords): Add 'abs' keyword.
5287         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5288         (value_from_host_double): New function.
5289         (evaluate_subexp_f): Support UNOP_ABS.
5290
5291 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5292
5293         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5294         types.
5295
5296 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5297
5298         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5299         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5300         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5301
5302 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5303
5304         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5305
5306 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5307             Chris January  <chris.january@arm.com>
5308
5309         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5310         * f-exp.y: Define 'KIND' token.
5311         (exp): New pattern for KIND expressions.
5312         (ptype): Handle types with a kind extension.
5313         (direct_abs_decl): Extend to spot kind extensions.
5314         (f77_keywords): Add 'kind' to the list.
5315         (push_kind_type): New function.
5316         (convert_to_kind_type): New function.
5317         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5318         * parse.c (operator_length_standard): Likewise.
5319         * parser-defs.h (enum type_pieces): Add tp_kind.
5320         * std-operator.def: Add UNOP_KIND.
5321
5322 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5323
5324         * f-exp.y (f_parse): Set yydebug.
5325
5326 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5327
5328         * f-lang.c (evaluate_subexp_f): New function.
5329         (exp_descriptor_f): New global.
5330         (f_language_defn): Use exp_descriptor_f instead of
5331         exp_descriptor_standard.
5332
5333 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5334
5335         * f-exp.y (struct token): Add comments.
5336         (dot_ops): Remove uppercase versions and the end marker.
5337         (f77_keywords): Likewise.
5338         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5339         entries in the dot_ops array are case insensitive, and use
5340         strncasecmp to compare strings.  Also some whitespace cleanup in
5341         this area.  Similar for the f77_keywords array, except entries in
5342         this list might be case sensitive.
5343
5344 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5345
5346         * f-exp.y (struct f77_boolean_val): Add comments.
5347         (boolean_values): Remove uppercase versions, and end marker.
5348         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5349         and use strncasecmp to achieve case insensitivity.  Additionally,
5350         perform whitespace cleanup around this code.
5351
5352 2019-03-06  Tom Tromey  <tromey@adacore.com>
5353
5354         * remote-sim.c (gdbsim_target_open): Use result of
5355         gdb_argv::release.
5356
5357 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5358         Dirk Schubert  <dirk.schubert@arm.com>
5359         Chris January  <chris.january@arm.com>
5360
5361         * eval.c (evaluate_subexp_standard): Call Fortran argument
5362         wrapping logic.
5363         * f-lang.c (struct value): A value which can be passed into a
5364         Fortran function call.
5365         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5366         where appropriate.
5367         (struct type): Value ready for a Fortran function call.
5368         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5369         is needed.
5370         * f-lang.h (fortran_argument_convert): Declaration.
5371         (fortran_preserve_arg_pointer): Declaration.
5372         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5373
5374 2019-03-05  Tom Tromey  <tromey@adacore.com>
5375
5376         * python/py-prettyprint.c (print_string_repr): Remove #if.
5377         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5378
5379 2019-03-05  Tom Tromey  <tromey@adacore.com>
5380
5381         * target.c (the_dummy_target): Move later.  Change type to
5382         "dummy_target".
5383         (initialize_targets): Don't initialize the_dummy_target.
5384
5385 2019-03-05  Tom Tromey  <tromey@adacore.com>
5386
5387         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5388         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5389
5390 2019-03-05  Tom Tromey  <tromey@adacore.com>
5391
5392         * windows-nat.c (windows_nat_target::attach)
5393         (windows_nat_target::detach): Don't call gdb_flush.
5394         * valprint.c (generic_val_print, val_print, val_print_string):
5395         Don't call gdb_flush.
5396         * utils.c (defaulted_query): Don't call gdb_flush.
5397         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5398         * target.c (target_announce_detach): Don't call gdb_flush.
5399         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5400         * remote.c (extended_remote_target::attach): Don't call
5401         gdb_flush.
5402         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5403         * printcmd.c (do_examine): Don't call gdb_flush.
5404         (info_display_command): Don't call gdb_flush.
5405         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5406         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5407         * memattr.c (info_mem_command): Don't call gdb_flush.
5408         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5409         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5410         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5411         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5412         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5413         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5414         (gnu_nat_target::detach): Don't call gdb_flush.
5415         * f-valprint.c (f_val_print): Don't call gdb_flush.
5416         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5417         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5418         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5419         gdb_flush.
5420         * c-valprint.c (c_val_print): Don't call gdb_flush.
5421         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5422
5423 2019-03-05  Tom Tromey  <tromey@adacore.com>
5424
5425         * varobj.c (update_dynamic_varobj_children): Update.
5426         (install_default_visualizer): Use reset, not release.
5427         * value.c (set_internalvar): Update.
5428         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5429         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5430         ATTRIBUTE_UNUSED_RESULT.
5431
5432 2019-03-05  Tom Tromey  <tromey@adacore.com>
5433
5434         * remote.c (class scoped_remote_fd) <release>: Add
5435         ATTRIBUTE_UNUSED_RESULT.
5436
5437 2019-03-05  Tom Tromey  <tromey@adacore.com>
5438
5439         * macroexp.c (struct macro_buffer) <release>: Add
5440         ATTRIBUTE_UNUSED_RESULT.
5441
5442 2019-03-05  Tom Tromey  <tromey@adacore.com>
5443
5444         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5445         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5446         ATTRIBUTE_UNUSED_RESULT.
5447
5448 2019-03-05  Tom Tromey  <tromey@adacore.com>
5449
5450         * common/scoped_fd.h (class scoped_fd) <release>: Add
5451         ATTRIBUTE_UNUSED_RESULT.
5452
5453 2019-03-05  Tom Tromey  <tromey@adacore.com>
5454
5455         * parser-defs.h (struct parser_state) <release>: Add
5456         ATTRIBUTE_UNUSED_RESULT.
5457
5458 2019-03-05  Tom Tromey  <tromey@adacore.com>
5459
5460         * utils.h (class gdb_argv) <release>: Add
5461         ATTRIBUTE_UNUSED_RESULT.
5462         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5463
5464 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5465
5466         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5467         for-loop range, to avoid compiler warnings.
5468
5469         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5470         avoid compiler warnings about unused variables.
5471
5472         * NEWS: Mention end of support for native debugging on MS-Windows
5473         before XP.
5474
5475         PR gdb/24292
5476         * common/netstuff.c:
5477         * gdbserver/gdbreplay.c
5478         * gdbserver/remote-utils.c:
5479         * ser-tcp.c:
5480         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5481         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5482         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5483         'getaddrinfo' and 'freeaddrinfo' were not available before
5484         Windows XP, and mingw.org's MinGW headers by default define
5485         _WIN32_WINNT to 0x500.
5486
5487 2019-03-01  Gary Benson <gbenson@redhat.com>
5488
5489         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5490
5491 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5492             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5493
5494         PR gdb/8527
5495         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5496         set_sigint_trap, clear_sigint_trap.
5497
5498 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5499
5500         * target.c (target_detach): Clear the regcache and the
5501         frame cache.
5502
5503 2019-02-27  Pedro Alves  <palves@redhat.com>
5504
5505         * utils.c (set_screen_size): When we cap the height/width sizes,
5506         tweak the corresponding command variable to show "unlimited":
5507
5508 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5509             Pedro Alves  <palves@redhat.com>
5510
5511         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5512         before calling rl_set_screen_size.
5513
5514 2019-02-27  Tom Tromey  <tromey@adacore.com>
5515
5516         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5517         define.
5518         * python/py-value.c: Remove Python 2.4 workaround.
5519         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5520         workaround.
5521         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5522         Python 2.4 workaround.
5523         * python/python-internal.h: Remove Python 2.4 comment.
5524         (Py_ssize_t): Don't define.
5525         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5526         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5527         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5528         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5529         * python/python.c (do_start_initialization): Remove Python 2.4
5530         workaround.
5531         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5532         (print_children): Remove Python 2.4 workaround.
5533         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5534         workaround.
5535         (CHARBUFFERPROC_NAME): Remove.
5536         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5537         Python 2.4 workaround.
5538
5539 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5540
5541         * NEWS: Note minimum Python version.
5542
5543 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5544
5545         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5546         code from these functions.  Remove corresponding ifdefs.  Use
5547         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5548         Remove gotos and target of gotos.
5549         (infpy_search_memory): Likewise.
5550
5551 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5552
5553         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5554         (hppa_gdbarch_init): Don't register deleted functions with
5555         gdbarch.
5556
5557 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5558
5559         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5560         (h8300_unwind_sp): Delete.
5561         (h8300_dummy_id): Delete.
5562         (h8300_gdbarch_init): Don't register deleted functions with
5563         gdbarch.
5564
5565 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5566
5567         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5568         (ft32_unwind_pc): Delete.
5569         (ft32_unwind_sp): Delete.
5570         (ft32_gdbarch_init): Don't register deleted functions with
5571         gdbarch.
5572
5573 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5574
5575         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5576         (frv_unwind_pc): Delete.
5577         (frv_unwind_sp): Delete.
5578         (frv_gdbarch_init): Don't register deleted functions with
5579         gdbarch.
5580
5581 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5582
5583         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5584         (riscv_unwind_pc): Delete.
5585         (riscv_unwind_sp): Delete.
5586         (riscv_gdbarch_init): Don't register deleted functions with
5587         gdbarch.
5588
5589 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5590
5591         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5592         (csky_unwind_pc): Delete.
5593         (csky_unwind_sp): Delete.
5594         (csky_gdbarch_init): Don't register deleted functions with
5595         gdbarch.
5596
5597 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5598
5599         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5600         (cris_unwind_pc): Delete.
5601         (cris_unwind_sp): Delete.
5602         (cris_gdbarch_init): Don't register deleted functions with
5603         gdbarch.
5604
5605 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5606
5607         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5608         (bfin_unwind_pc): Delete.
5609         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5610
5611 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5612
5613         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5614         (arm_unwind_pc): Delete.
5615         (arm_unwind_sp): Delete.
5616         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5617
5618 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5619
5620         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5621         (arc_unwind_pc): Delete.
5622         (arc_unwind_sp): Delete.
5623         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5624
5625 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5626
5627         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5628         (alpha_unwind_pc): Delete.
5629         (alpha_gdbarch_init): Don't register deleted functions with
5630         gdbarch.
5631
5632 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5633
5634         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5635         (aarch64_unwind_pc): Delete.
5636         (aarch64_unwind_sp): Delete.
5637         (aarch64_gdbarch_init): Don't register deleted functions with
5638         gdbarch.
5639
5640 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5641
5642         * gdbtypes.c (type_align): Don't consider static members when
5643         computing structure alignment.
5644
5645 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5646
5647         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5648         return 0 for other types.
5649         * arch-utils.c (default_type_align): Always return 0.
5650         * gdbarch.h: Regenerate.
5651         * gdbarch.sh (type_align): Extend comment.
5652         * gdbtypes.c (type_align): Add additional comments, always call
5653         gdbarch_type_align before applying the default rules.
5654         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5655         generic code will then apply a suitable default.
5656         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5657         types, return 0 for other types.
5658
5659 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5660
5661         * NEWS: Create a new section for the next release branch.
5662         Rename the section of the current branch, now that it has
5663         been cut.
5664
5665 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5666
5667         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5668         * version.in: Bump version to 8.3.50.DATE-git.
5669
5670 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5671
5672         * aix-thread.c (ptid_cmp): Remove unused variable.
5673         (get_signaled_thread): Likewise.
5674         (store_regs_user_thread): Likewise.
5675         (store_regs_kernel_thread): Likewise.
5676         (fetch_regs_kernel_thread): Remove shadowed variable.
5677
5678 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5679
5680         * features/riscv/32bit-cpu.xml: Add register numbers.
5681         * features/riscv/32bit-fpu.c: Regenerate.
5682         * features/riscv/32bit-fpu.xml: Add register numbers.
5683         * features/riscv/64bit-cpu.xml: Add register numbers.
5684         * features/riscv/64bit-fpu.c: Regenerate.
5685         * features/riscv/64bit-fpu.xml: Add register numbers.
5686
5687 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5688
5689         * NEWS: Mention two argument form of gdb.Value constructor.
5690         * python/py-value.c (convert_buffer_and_type_to_value): New
5691         function.
5692         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5693         Add support for handling an optional second argument.  Call
5694         convert_buffer_and_type_to_value as appropriate.
5695         * python/python-internal.h (Py_buffer_deleter): New struct.
5696         (Py_buffer_up): New typedef.
5697
5698 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5699
5700         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5701         instead of releasing ownership.
5702
5703 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5704
5705         * dwarf2read.c (open_and_init_dwp_file): Call
5706         elf_numsections instead of bfd_count_sections to initialize
5707         dwp_file->num_sections.
5708
5709 2019-02-25  Tom Tromey  <tromey@adacore.com>
5710
5711         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5712
5713 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5714
5715         * gcore.in: Add '--readnever' option when invoking GDB.
5716
5717 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5718
5719         * MAINTAINERS: Update my email address.
5720
5721 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5722
5723         * build-id.c (build_id_to_debug_bfd_1): New function.
5724         (build_id_to_debug_bfd): Look for separate debug file in
5725         sysroot.
5726
5727 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5728
5729         * gdbarch.sh: Update the copyright year range that is placed into
5730         generated files.
5731
5732 2019-02-22  Keith Seitz  <keiths@redhat.com>
5733
5734         PR symtab/23853
5735         * linespec.c (create_sals_line_offset): Search for the default
5736         symtab's filename instead of its fullname.
5737
5738 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5739
5740         * NEWS: Update style defaults.
5741
5742 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5743
5744         * main.c (captured_main_1): Disable styling in batch mode.
5745
5746 2019-02-20  Tom Tromey  <tom@tromey.com>
5747
5748         * symtab.c (symtab_symbol_info): Fix typos.
5749
5750 2019-02-20  Tom Tromey  <tromey@adacore.com>
5751
5752         * findcmd.c (_initialize_mem_search): Use upper case for
5753         metasyntactic variables.
5754
5755 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5756
5757         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5758         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5759
5760 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5761
5762         * top.h (source_file_name): Change to std::string.
5763         * top.c (source_file_name): Likewise.
5764         (command_line_input): Adjust.
5765         * cli/cli-script.c (script_from_file): Adjust.
5766
5767 2019-02-19  Tom Tromey  <tromey@adacore.com>
5768
5769         * ravenscar-thread.c
5770         (ravenscar_thread_target::update_thread_list): Don't call
5771         ada_build_task_list.
5772         * ada-lang.h (ada_build_task_list): Don't declare.
5773         * ada-tasks.c (struct ada_tasks_inferior_data)
5774         <task_list_valid_p>: Now bool.
5775         (read_known_tasks, ada_task_list_changed)
5776         (ada_tasks_invalidate_inferior_data): Update.
5777         (read_known_tasks_array): Return bool.
5778         (read_known_tasks_list): Likewise.
5779         (read_known_tasks): Return void.
5780         (ada_build_task_list): Now static.
5781
5782 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5783
5784         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5785         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5786
5787 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5788
5789         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5790         variant for ada_tasks_pspace_data_handle and
5791         ada_tasks_inferior_data_handle.
5792         (ada_tasks_pspace_data_cleanup): New function.
5793         (ada_tasks_inferior_data_cleanup): New function.
5794
5795 2019-02-17  Tom Tromey  <tom@tromey.com>
5796
5797         * macrotab.h (macro_source_fullname): Return a std::string.
5798         * macrotab.c (macro_include, check_for_redefinition)
5799         (macro_undef, macro_lookup_definition, foreach_macro)
5800         (foreach_macro_in_scope): Update.
5801         (macro_source_fullname): Return a std::string.
5802         * macrocmd.c (show_pp_source_pos): Update.
5803
5804 2019-02-17  Tom Tromey  <tom@tromey.com>
5805
5806         * macrocmd.c (show_pp_source_pos): Style the file names.
5807
5808 2019-02-17  Tom Tromey  <tom@tromey.com>
5809
5810         PR tui/24197:
5811         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5812
5813 2019-02-17  Tom Tromey  <tom@tromey.com>
5814
5815         * ada-lang.c (user_select_syms): Use filtered printing.
5816         * utils.c (wrap_style): New global.
5817         (desired_style): Remove.
5818         (emit_style_escape): Add stream parameter.
5819         (set_output_style, reset_terminal_style, prompt_for_continue):
5820         Update.
5821         (flush_wrap_buffer): Only flush gdb_stdout.
5822         (wrap_here): Set wrap_style.
5823         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5824         treat escape sequences as a character.  Change when wrap buffer is
5825         flushed.
5826         (fputs_styled): Do not set the output style when the default is
5827         requested.
5828         * ui-style.h (struct ui_file_style) <is_default>: New method.
5829         * source.c (print_source_lines_base): Emit escape sequences in one
5830         piece.
5831
5832 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5833
5834         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5835         integers and enumeration types.
5836
5837 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5838
5839         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5840         instead of lookup_symbol_in_language
5841         (do_exact_match): New function.
5842         (ada_get_symbol_name_matcher): Return do_exact_match when
5843         doing a verbatim match.
5844
5845 2019-02-15  Tom Tromey  <tromey@adacore.com>
5846
5847         * ravenscar-thread.c (ravenscar_thread_target::resume)
5848         (ravenscar_thread_target::wait): Special case wildcard requests.
5849
5850 2019-02-15  Tom Tromey  <tromey@adacore.com>
5851
5852         * ravenscar-thread.c (base_ptid): Remove.
5853         (struct ravenscar_thread_target) <close>: New method.
5854         <m_base_ptid>: New member.
5855         <update_inferior_ptid, active_task, task_is_currently_active,
5856         runtime_initialized>: Declare methods.
5857         <ravenscar_thread_target>: Add constructor.
5858         (ravenscar_thread_target::task_is_currently_active)
5859         (ravenscar_thread_target::update_inferior_ptid)
5860         (ravenscar_runtime_initialized): Rename.  Now methods.
5861         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5862         (ravenscar_thread_target::update_thread_list): Update.
5863         (ravenscar_thread_target::active_task): Now method.
5864         (ravenscar_thread_target::store_registers)
5865         (ravenscar_thread_target::prepare_to_store)
5866         (ravenscar_thread_target::prepare_to_store)
5867         (ravenscar_thread_target::mourn_inferior): Update.
5868         (ravenscar_inferior_created): Use "new" to create target.
5869         (ravenscar_thread_target::get_ada_task_ptid): Update.
5870         (_initialize_ravenscar): Don't initialize base_ptid.
5871         (ravenscar_ops): Remove global.
5872
5873 2019-02-15  Tom Tromey  <tromey@adacore.com>
5874
5875         * target.h (push_target): Declare new overload.
5876         * target.c (push_target): New overload, taking an rvalue reference.
5877         * remote.c (remote_target::open_1): Use push_target overload.
5878         * corelow.c (core_target_open): Use push_target overload.
5879
5880 2019-02-15  Tom Tromey  <tromey@adacore.com>
5881
5882         * ravenscar-thread.c (is_ravenscar_task)
5883         (ravenscar_task_is_currently_active): Return bool.
5884         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5885         (_initialize_ravenscar): Remove "(void)".
5886         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5887         Return bool.
5888
5889 2019-02-15  Tom Tromey  <tromey@adacore.com>
5890
5891         * ravenscar-thread.c (ravenscar_runtime_initializer)
5892         (has_ravenscar_runtime, get_running_thread_id)
5893         (ravenscar_thread_target::resume): Fix indentation.
5894
5895 2019-02-15  Tom Tromey  <tromey@adacore.com>
5896
5897         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5898         from ravenscar_arch_ops.
5899         (sparc_ravenscar_ops::fetch_registers)
5900         (sparc_ravenscar_ops::store_registers): Now methods.
5901         (sparc_ravenscar_prepare_to_store): Remove.
5902         (sparc_ravenscar_ops): Redefine.
5903         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5904         methods and destructor.  Remove members.
5905         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5906         (ravenscar_thread_target::store_registers)
5907         (ravenscar_thread_target::prepare_to_store): Update.
5908         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5909         Remove.
5910         (struct ppc_ravenscar_powerpc_ops): Derive from
5911         ravenscar_arch_ops.
5912         (ppc_ravenscar_powerpc_ops::fetch_registers)
5913         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5914         (ppc_ravenscar_powerpc_ops): Redefine.
5915         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5916         (ppc_ravenscar_e500_ops::fetch_registers)
5917         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5918         (ppc_ravenscar_e500_ops): Redefine.
5919         * aarch64-ravenscar-thread.c
5920         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5921         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5922         (aarch64_ravenscar_fetch_registers)
5923         (aarch64_ravenscar_store_registers): Now methods.
5924         (aarch64_ravenscar_ops): Redefine.
5925
5926 2019-02-15  Tom Tromey  <tromey@adacore.com>
5927
5928         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5929         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5930         (ravenscar_thread_target::stopped_by_watchpoint)
5931         (ravenscar_thread_target::stopped_data_address)
5932         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5933
5934 2019-02-15  Tom Tromey  <tromey@adacore.com>
5935
5936         * ravenscar-thread.c: Fix some typos.
5937
5938 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5939             Tom Tromey  <tromey@adacore.com>
5940
5941         * ada-lang.c (ada_exception_sal): Change addr_string to a
5942         std::string.
5943         (create_ada_exception_catchpoint): Update.
5944
5945 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5946             Tom Tromey  <tromey@adacore.com>
5947
5948         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5949         (bp_location_ops): Remove.
5950         (base_breakpoint_allocate_location): Update.
5951         (free_bp_location): Update.
5952         * ada-lang.c (class ada_catchpoint_location)
5953         <ada_catchpoint_location>: Remove ops parameter.
5954         (ada_catchpoint_location_dtor): Remove.
5955         (ada_catchpoint_location_ops): Remove.
5956         (allocate_location_exception): Update.
5957         * breakpoint.h (struct bp_location_ops): Remove.
5958         (class bp_location) <bp_location>: Remove bp_location_ops
5959         parameter.
5960         <~bp_location>: Add destructor.
5961         <ops>: Remove.
5962
5963 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5964             Pedro Alves  <palves@redhat.com>
5965
5966         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5967         'PATH_MAX'.
5968
5969 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5970             Samuel Thibault  <samuel.thibault@gnu.org>
5971             Thomas Schwinge  <thomas@codesourcery.com>
5972
5973         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5974         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5975
5976 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5977
5978         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5979         (check_empty): Use "const char *".
5980
5981         * gnu-nat.c (gnu_nat_target::detach): Instead of
5982         'detach_inferior (pid)' call
5983         'detach_inferior (find_inferior_pid (pid))'.
5984
5985         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5986         'nat/fork-inferior.o'.
5987         * gnu-nat.c: #include "nat/fork-inferior.h".
5988
5989         * gnu-nat.c (gnu_nat_target::detach): Instead of
5990         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5991         * gnu-nat.h: #include "inf-child.h".
5992         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5993         'i386_gnu_nat_target::fetch_registers'.
5994         (gnu_store_registers): Rename/move to
5995         'i386_gnu_nat_target::store_registers'.
5996
5997         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5998         * gnu-nat.h (mach_thread_info): New function.
5999         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6000
6001         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6002
6003 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6004
6005         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6006
6007 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6008
6009         * windows-nat.c (windows_add_thread): Add new parameter
6010         "main_thread_p" with default value set to false.  Update
6011         function documentation as well as all callers.
6012         (windows_delete_thread): Likewise.
6013         (fake_create_process): Update call to windows_add_thread.
6014         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6015         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6016         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6017         call to windows_delete_thread.
6018
6019 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6020
6021         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6022
6023 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6024
6025         * symfile.c (find_separate_debug_file): Use canonical path of
6026         sysroot with child_path instead of gdb_sysroot if it is valid.
6027
6028 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6029
6030         * symfile.c (find_separate_debug_file): Use child_path to
6031         determine if an object file is under a sysroot.
6032
6033 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6034
6035         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6036         unittests/child-path-selftests.c.
6037         * common/pathstuff.c (child_path): New function.
6038         * common/pathstuff.h (child_path): New prototype.
6039         * unittests/child-path-selftests.c: New file.
6040
6041 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6042
6043         * symfile.c (find_separate_debug_file): Look for separate debug
6044         files in debug directories under the sysroot.
6045
6046 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6047
6048         * symtab.h (struct minimal_symbol data_p): New const method.
6049         (struct minimal_symbol text_p): Likewise.
6050         * symtab.c (output_source_filename): Use file name style
6051         to print file name.
6052         (print_symbol_info): Likewise.
6053         (print_msymbol_info): Use address style to print addresses.
6054         Use function name style to print executable text symbols.
6055         (expand_symtab_containing_pc): Use data_p.
6056         (find_pc_sect_compunit_symtab): Likewise.
6057
6058 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6059
6060         * breakpoint.c (describe_other_breakpoints): Use address style
6061         to print addresses.
6062         (say_where): Likewise.
6063
6064 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6065
6066         * ada-typeprint.c (print_func_type): Print function name
6067         style to print function name.
6068         * c-typeprint.c (c_print_type_1): Likewise.
6069
6070 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6071
6072         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6073         for execve.
6074
6075 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6076
6077         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6078         type_stack.
6079
6080 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6081
6082         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6083         TYPE_CODE_REF types.
6084
6085 2019-02-08  Jim Wilson  <jimw@sifive.com>
6086
6087         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6088         (riscv_linux_fregset): New.
6089         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6090
6091 2019-02-07  Tom Tromey  <tom@tromey.com>
6092
6093         * thread.c (thread_cancel_execution_command): Update.
6094         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6095         methods.
6096         (struct thread_fsm_ops): Remove.
6097         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6098         (thread_fsm_should_stop, thread_fsm_return_value)
6099         (thread_fsm_set_finished, thread_fsm_finished_p)
6100         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6101         Don't declare.
6102         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6103         * infrun.c (clear_proceed_status_thread)
6104         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6105         (print_stop_event): Update.
6106         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6107         Add constructor.
6108         (step_command_fsm_ops): Remove.
6109         (new_step_command_fsm): Remove.
6110         (step_1): Update.
6111         (step_command_fsm::should_stop): Rename from
6112         step_command_fsm_should_stop.
6113         (step_command_fsm::clean_up): Rename from
6114         step_command_fsm_clean_up.
6115         (step_command_fsm::do_async_reply_reason): Rename from
6116         step_command_fsm_async_reply_reason.
6117         (struct until_next_fsm): Inherit from thread_fsm.  Add
6118         constructor.
6119         (until_next_fsm_ops): Remove.
6120         (new_until_next_fsm): Remove.
6121         (until_next_fsm::should_stop): Rename from
6122         until_next_fsm_should_stop.
6123         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6124         (until_next_fsm::do_async_reply_reason): Rename from
6125         until_next_fsm_async_reply_reason.
6126         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6127         constructor.  Change type of breakpoint.
6128         (finish_command_fsm_ops): Remove.
6129         (new_finish_command_fsm): Remove.
6130         (finish_command_fsm::should_stop): Rename from
6131         finish_command_fsm_should_stop.
6132         (finish_command_fsm::clean_up): Rename from
6133         finish_command_fsm_clean_up.
6134         (finish_command_fsm::return_value): Rename from
6135         finish_command_fsm_return_value.
6136         (finish_command_fsm::do_async_reply_reason): Rename from
6137         finish_command_fsm_async_reply_reason.
6138         (finish_command): Update.
6139         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6140         Add constructor.
6141         (call_thread_fsm_ops): Remove.
6142         (call_thread_fsm::call_thread_fsm): Rename from
6143         new_call_thread_fsm.
6144         (call_thread_fsm::should_stop): Rename from
6145         call_thread_fsm_should_stop.
6146         (call_thread_fsm::should_notify_stop): Rename from
6147         call_thread_fsm_should_notify_stop.
6148         (run_inferior_call, call_function_by_hand_dummy): Update.
6149         * cli/cli-interp.c (should_print_stop_to_console): Update.
6150         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6151         Add constructor.  Change type of location_breakpoint,
6152         caller_breakpoint.
6153         (until_break_fsm_ops): Remove.
6154         (new_until_break_fsm): Remove.
6155         (until_break_fsm::should_stop): Rename from
6156         until_break_fsm_should_stop.
6157         (until_break_fsm::clean_up): Rename from
6158         until_break_fsm_clean_up.
6159         (until_break_fsm::do_async_reply_reason): Rename from
6160         until_break_fsm_async_reply_reason.
6161         (until_break_command): Update.
6162         * thread-fsm.c: Remove.
6163         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6164
6165 2019-02-07  Tom Tromey  <tom@tromey.com>
6166
6167         * yy-remap.h: Add include guard.
6168         * xtensa-tdep.h: Add include guard.
6169         * xcoffread.h: Rename include guard.
6170         * varobj-iter.h: Add include guard.
6171         * tui/tui.h: Rename include guard.
6172         * tui/tui-winsource.h: Rename include guard.
6173         * tui/tui-wingeneral.h: Rename include guard.
6174         * tui/tui-windata.h: Rename include guard.
6175         * tui/tui-win.h: Rename include guard.
6176         * tui/tui-stack.h: Rename include guard.
6177         * tui/tui-source.h: Rename include guard.
6178         * tui/tui-regs.h: Rename include guard.
6179         * tui/tui-out.h: Rename include guard.
6180         * tui/tui-layout.h: Rename include guard.
6181         * tui/tui-io.h: Rename include guard.
6182         * tui/tui-hooks.h: Rename include guard.
6183         * tui/tui-file.h: Rename include guard.
6184         * tui/tui-disasm.h: Rename include guard.
6185         * tui/tui-data.h: Rename include guard.
6186         * tui/tui-command.h: Rename include guard.
6187         * tic6x-tdep.h: Add include guard.
6188         * target/waitstatus.h: Rename include guard.
6189         * target/wait.h: Rename include guard.
6190         * target/target.h: Rename include guard.
6191         * target/resume.h: Rename include guard.
6192         * target-float.h: Rename include guard.
6193         * stabsread.h: Add include guard.
6194         * rs6000-tdep.h: Add include guard.
6195         * riscv-fbsd-tdep.h: Add include guard.
6196         * regformats/regdef.h: Rename include guard.
6197         * record.h: Rename include guard.
6198         * python/python.h: Rename include guard.
6199         * python/python-internal.h: Rename include guard.
6200         * python/py-stopevent.h: Rename include guard.
6201         * python/py-ref.h: Rename include guard.
6202         * python/py-record.h: Rename include guard.
6203         * python/py-record-full.h: Rename include guard.
6204         * python/py-record-btrace.h: Rename include guard.
6205         * python/py-instruction.h: Rename include guard.
6206         * python/py-events.h: Rename include guard.
6207         * python/py-event.h: Rename include guard.
6208         * procfs.h: Add include guard.
6209         * proc-utils.h: Add include guard.
6210         * p-lang.h: Add include guard.
6211         * or1k-tdep.h: Rename include guard.
6212         * observable.h: Rename include guard.
6213         * nto-tdep.h: Rename include guard.
6214         * nat/x86-linux.h: Rename include guard.
6215         * nat/x86-linux-dregs.h: Rename include guard.
6216         * nat/x86-gcc-cpuid.h: Add include guard.
6217         * nat/x86-dregs.h: Rename include guard.
6218         * nat/x86-cpuid.h: Rename include guard.
6219         * nat/ppc-linux.h: Rename include guard.
6220         * nat/mips-linux-watch.h: Rename include guard.
6221         * nat/linux-waitpid.h: Rename include guard.
6222         * nat/linux-ptrace.h: Rename include guard.
6223         * nat/linux-procfs.h: Rename include guard.
6224         * nat/linux-osdata.h: Rename include guard.
6225         * nat/linux-nat.h: Rename include guard.
6226         * nat/linux-namespaces.h: Rename include guard.
6227         * nat/linux-btrace.h: Rename include guard.
6228         * nat/glibc_thread_db.h: Rename include guard.
6229         * nat/gdb_thread_db.h: Rename include guard.
6230         * nat/gdb_ptrace.h: Rename include guard.
6231         * nat/fork-inferior.h: Rename include guard.
6232         * nat/amd64-linux-siginfo.h: Rename include guard.
6233         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6234         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6235         * nat/aarch64-linux.h: Rename include guard.
6236         * nat/aarch64-linux-hw-point.h: Rename include guard.
6237         * mn10300-tdep.h: Add include guard.
6238         * mips-linux-tdep.h: Add include guard.
6239         * mi/mi-parse.h: Rename include guard.
6240         * mi/mi-out.h: Rename include guard.
6241         * mi/mi-main.h: Rename include guard.
6242         * mi/mi-interp.h: Rename include guard.
6243         * mi/mi-getopt.h: Rename include guard.
6244         * mi/mi-console.h: Rename include guard.
6245         * mi/mi-common.h: Rename include guard.
6246         * mi/mi-cmds.h: Rename include guard.
6247         * mi/mi-cmd-break.h: Rename include guard.
6248         * m2-lang.h: Add include guard.
6249         * location.h: Rename include guard.
6250         * linux-record.h: Rename include guard.
6251         * linux-nat.h: Add include guard.
6252         * linux-fork.h: Add include guard.
6253         * i386-darwin-tdep.h: Rename include guard.
6254         * hppa-linux-offsets.h: Add include guard.
6255         * guile/guile.h: Rename include guard.
6256         * guile/guile-internal.h: Rename include guard.
6257         * gnu-nat.h: Rename include guard.
6258         * gdb-stabs.h: Rename include guard.
6259         * frv-tdep.h: Add include guard.
6260         * f-lang.h: Add include guard.
6261         * event-loop.h: Add include guard.
6262         * darwin-nat.h: Rename include guard.
6263         * cp-abi.h: Rename include guard.
6264         * config/sparc/nm-sol2.h: Rename include guard.
6265         * config/nm-nto.h: Rename include guard.
6266         * config/nm-linux.h: Add include guard.
6267         * config/i386/nm-i386gnu.h: Rename include guard.
6268         * config/djgpp/nl_types.h: Rename include guard.
6269         * config/djgpp/langinfo.h: Rename include guard.
6270         * compile/gcc-cp-plugin.h: Add include guard.
6271         * compile/gcc-c-plugin.h: Add include guard.
6272         * compile/compile.h: Rename include guard.
6273         * compile/compile-object-run.h: Rename include guard.
6274         * compile/compile-object-load.h: Rename include guard.
6275         * compile/compile-internal.h: Rename include guard.
6276         * compile/compile-cplus.h: Rename include guard.
6277         * compile/compile-c.h: Rename include guard.
6278         * common/xml-utils.h: Rename include guard.
6279         * common/x86-xstate.h: Rename include guard.
6280         * common/version.h: Rename include guard.
6281         * common/vec.h: Rename include guard.
6282         * common/tdesc.h: Rename include guard.
6283         * common/selftest.h: Rename include guard.
6284         * common/scoped_restore.h: Rename include guard.
6285         * common/scoped_mmap.h: Rename include guard.
6286         * common/scoped_fd.h: Rename include guard.
6287         * common/safe-iterator.h: Rename include guard.
6288         * common/run-time-clock.h: Rename include guard.
6289         * common/refcounted-object.h: Rename include guard.
6290         * common/queue.h: Rename include guard.
6291         * common/ptid.h: Rename include guard.
6292         * common/print-utils.h: Rename include guard.
6293         * common/preprocessor.h: Rename include guard.
6294         * common/pathstuff.h: Rename include guard.
6295         * common/observable.h: Rename include guard.
6296         * common/netstuff.h: Rename include guard.
6297         * common/job-control.h: Rename include guard.
6298         * common/host-defs.h: Rename include guard.
6299         * common/gdb_wait.h: Rename include guard.
6300         * common/gdb_vecs.h: Rename include guard.
6301         * common/gdb_unlinker.h: Rename include guard.
6302         * common/gdb_unique_ptr.h: Rename include guard.
6303         * common/gdb_tilde_expand.h: Rename include guard.
6304         * common/gdb_sys_time.h: Rename include guard.
6305         * common/gdb_string_view.h: Rename include guard.
6306         * common/gdb_splay_tree.h: Rename include guard.
6307         * common/gdb_setjmp.h: Rename include guard.
6308         * common/gdb_ref_ptr.h: Rename include guard.
6309         * common/gdb_optional.h: Rename include guard.
6310         * common/gdb_locale.h: Rename include guard.
6311         * common/gdb_assert.h: Rename include guard.
6312         * common/filtered-iterator.h: Rename include guard.
6313         * common/filestuff.h: Rename include guard.
6314         * common/fileio.h: Rename include guard.
6315         * common/environ.h: Rename include guard.
6316         * common/common-utils.h: Rename include guard.
6317         * common/common-types.h: Rename include guard.
6318         * common/common-regcache.h: Rename include guard.
6319         * common/common-inferior.h: Rename include guard.
6320         * common/common-gdbthread.h: Rename include guard.
6321         * common/common-exceptions.h: Rename include guard.
6322         * common/common-defs.h: Rename include guard.
6323         * common/common-debug.h: Rename include guard.
6324         * common/cleanups.h: Rename include guard.
6325         * common/buffer.h: Rename include guard.
6326         * common/btrace-common.h: Rename include guard.
6327         * common/break-common.h: Rename include guard.
6328         * cli/cli-utils.h: Rename include guard.
6329         * cli/cli-style.h: Rename include guard.
6330         * cli/cli-setshow.h: Rename include guard.
6331         * cli/cli-script.h: Rename include guard.
6332         * cli/cli-interp.h: Rename include guard.
6333         * cli/cli-decode.h: Rename include guard.
6334         * cli/cli-cmds.h: Rename include guard.
6335         * charset-list.h: Add include guard.
6336         * buildsym-legacy.h: Rename include guard.
6337         * bfin-tdep.h: Add include guard.
6338         * ax.h: Rename include guard.
6339         * arm-linux-tdep.h: Add include guard.
6340         * arm-fbsd-tdep.h: Add include guard.
6341         * arch/xtensa.h: Rename include guard.
6342         * arch/tic6x.h: Add include guard.
6343         * arch/i386.h: Add include guard.
6344         * arch/arm.h: Rename include guard.
6345         * arch/arm-linux.h: Rename include guard.
6346         * arch/arm-get-next-pcs.h: Rename include guard.
6347         * arch/amd64.h: Add include guard.
6348         * arch/aarch64-insn.h: Rename include guard.
6349         * arch-utils.h: Rename include guard.
6350         * annotate.h: Add include guard.
6351         * amd64-darwin-tdep.h: Rename include guard.
6352         * aarch64-linux-tdep.h: Add include guard.
6353         * aarch64-fbsd-tdep.h: Add include guard.
6354         * aarch32-linux-nat.h: Add include guard.
6355
6356 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6357
6358         * macrotab.c (macro_define_internal): New function that
6359         factorizes macro_define_object_internal and macro_define_function
6360         code.
6361         (macro_define_object_internal): Use macro_define_internal.
6362         (macro_define_function): Likewise.
6363
6364 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6365
6366         * macrocmd.c (extract_identifier): Return
6367         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6368         callers.
6369
6370 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6371
6372         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6373
6374 2019-02-05  Tom Tromey  <tom@tromey.com>
6375
6376         * target.c (target_stack::unpush): Move assertion earlier.
6377
6378 2019-01-30  Tom Tromey  <tom@tromey.com>
6379
6380         PR python/23615:
6381         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6382         (gdbpy_parse_and_eval): Likewise.
6383         * python/python-internal.h (gdbpy_allow_threads): New class.
6384
6385 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6386
6387         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6388         (aarch64_fbsd_fpregmap): Move earlier.
6389         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6390         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6391         instead of individual calls to trad_frame_set_reg_addr.
6392         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6393         earlier.
6394         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6395         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6396         instead of individual calls to trad_frame_set_reg_addr.
6397
6398 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6399
6400         * CONTRIBUTE: Replace contribution list with wiki link.
6401
6402 2019-01-25  Tom Tromey  <tom@tromey.com>
6403
6404         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6405
6406 2019-01-25  Tom Tromey  <tom@tromey.com>
6407
6408         * xtensa-linux-nat.c: Fix common/ includes.
6409         * xml-support.h: Fix common/ includes.
6410         * xml-support.c: Fix common/ includes.
6411         * x86-linux-nat.c: Fix common/ includes.
6412         * windows-nat.c: Fix common/ includes.
6413         * varobj.h: Fix common/ includes.
6414         * varobj.c: Fix common/ includes.
6415         * value.c: Fix common/ includes.
6416         * valops.c: Fix common/ includes.
6417         * utils.c: Fix common/ includes.
6418         * unittests/xml-utils-selftests.c: Fix common/ includes.
6419         * unittests/utils-selftests.c: Fix common/ includes.
6420         * unittests/unpack-selftests.c: Fix common/ includes.
6421         * unittests/tracepoint-selftests.c: Fix common/ includes.
6422         * unittests/style-selftests.c: Fix common/ includes.
6423         * unittests/string_view-selftests.c: Fix common/ includes.
6424         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6425         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6426         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6427         * unittests/rsp-low-selftests.c: Fix common/ includes.
6428         * unittests/parse-connection-spec-selftests.c: Fix common/
6429         includes.
6430         * unittests/optional-selftests.c: Fix common/ includes.
6431         * unittests/offset-type-selftests.c: Fix common/ includes.
6432         * unittests/observable-selftests.c: Fix common/ includes.
6433         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6434         * unittests/memrange-selftests.c: Fix common/ includes.
6435         * unittests/memory-map-selftests.c: Fix common/ includes.
6436         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6437         * unittests/function-view-selftests.c: Fix common/ includes.
6438         * unittests/environ-selftests.c: Fix common/ includes.
6439         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6440         * unittests/common-utils-selftests.c: Fix common/ includes.
6441         * unittests/cli-utils-selftests.c: Fix common/ includes.
6442         * unittests/array-view-selftests.c: Fix common/ includes.
6443         * ui-file.c: Fix common/ includes.
6444         * tui/tui-io.c: Fix common/ includes.
6445         * tracepoint.h: Fix common/ includes.
6446         * tracepoint.c: Fix common/ includes.
6447         * tracefile-tfile.c: Fix common/ includes.
6448         * top.h: Fix common/ includes.
6449         * top.c: Fix common/ includes.
6450         * thread.c: Fix common/ includes.
6451         * target/waitstatus.h: Fix common/ includes.
6452         * target/waitstatus.c: Fix common/ includes.
6453         * target.h: Fix common/ includes.
6454         * target.c: Fix common/ includes.
6455         * target-memory.c: Fix common/ includes.
6456         * target-descriptions.c: Fix common/ includes.
6457         * symtab.h: Fix common/ includes.
6458         * symfile.c: Fix common/ includes.
6459         * stap-probe.c: Fix common/ includes.
6460         * spu-linux-nat.c: Fix common/ includes.
6461         * sparc-nat.c: Fix common/ includes.
6462         * source.c: Fix common/ includes.
6463         * solib.c: Fix common/ includes.
6464         * solib-target.c: Fix common/ includes.
6465         * ser-unix.c: Fix common/ includes.
6466         * ser-tcp.c: Fix common/ includes.
6467         * ser-pipe.c: Fix common/ includes.
6468         * ser-base.c: Fix common/ includes.
6469         * selftest-arch.c: Fix common/ includes.
6470         * s12z-tdep.c: Fix common/ includes.
6471         * rust-exp.y: Fix common/ includes.
6472         * rs6000-aix-tdep.c: Fix common/ includes.
6473         * riscv-tdep.c: Fix common/ includes.
6474         * remote.c: Fix common/ includes.
6475         * remote-notif.h: Fix common/ includes.
6476         * remote-fileio.h: Fix common/ includes.
6477         * remote-fileio.c: Fix common/ includes.
6478         * regcache.h: Fix common/ includes.
6479         * regcache.c: Fix common/ includes.
6480         * record-btrace.c: Fix common/ includes.
6481         * python/python.c: Fix common/ includes.
6482         * python/py-type.c: Fix common/ includes.
6483         * python/py-inferior.c: Fix common/ includes.
6484         * progspace.h: Fix common/ includes.
6485         * producer.c: Fix common/ includes.
6486         * procfs.c: Fix common/ includes.
6487         * proc-api.c: Fix common/ includes.
6488         * printcmd.c: Fix common/ includes.
6489         * ppc-linux-nat.c: Fix common/ includes.
6490         * parser-defs.h: Fix common/ includes.
6491         * osdata.c: Fix common/ includes.
6492         * obsd-nat.c: Fix common/ includes.
6493         * nat/x86-linux.c: Fix common/ includes.
6494         * nat/x86-linux-dregs.c: Fix common/ includes.
6495         * nat/x86-dregs.h: Fix common/ includes.
6496         * nat/x86-dregs.c: Fix common/ includes.
6497         * nat/ppc-linux.c: Fix common/ includes.
6498         * nat/mips-linux-watch.h: Fix common/ includes.
6499         * nat/mips-linux-watch.c: Fix common/ includes.
6500         * nat/linux-waitpid.c: Fix common/ includes.
6501         * nat/linux-ptrace.h: Fix common/ includes.
6502         * nat/linux-ptrace.c: Fix common/ includes.
6503         * nat/linux-procfs.c: Fix common/ includes.
6504         * nat/linux-personality.c: Fix common/ includes.
6505         * nat/linux-osdata.c: Fix common/ includes.
6506         * nat/linux-namespaces.c: Fix common/ includes.
6507         * nat/linux-btrace.h: Fix common/ includes.
6508         * nat/linux-btrace.c: Fix common/ includes.
6509         * nat/fork-inferior.c: Fix common/ includes.
6510         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6511         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6512         * nat/aarch64-linux.c: Fix common/ includes.
6513         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6514         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6515         * namespace.h: Fix common/ includes.
6516         * mips-linux-tdep.c: Fix common/ includes.
6517         * minsyms.c: Fix common/ includes.
6518         * mi/mi-parse.h: Fix common/ includes.
6519         * mi/mi-main.c: Fix common/ includes.
6520         * mi/mi-cmd-env.c: Fix common/ includes.
6521         * memrange.h: Fix common/ includes.
6522         * memattr.c: Fix common/ includes.
6523         * maint.h: Fix common/ includes.
6524         * maint.c: Fix common/ includes.
6525         * main.c: Fix common/ includes.
6526         * machoread.c: Fix common/ includes.
6527         * location.c: Fix common/ includes.
6528         * linux-thread-db.c: Fix common/ includes.
6529         * linux-nat.c: Fix common/ includes.
6530         * linux-fork.c: Fix common/ includes.
6531         * inline-frame.c: Fix common/ includes.
6532         * infrun.c: Fix common/ includes.
6533         * inflow.c: Fix common/ includes.
6534         * inferior.h: Fix common/ includes.
6535         * inferior.c: Fix common/ includes.
6536         * infcmd.c: Fix common/ includes.
6537         * inf-ptrace.c: Fix common/ includes.
6538         * inf-child.c: Fix common/ includes.
6539         * ia64-linux-nat.c: Fix common/ includes.
6540         * i387-tdep.c: Fix common/ includes.
6541         * i386-tdep.c: Fix common/ includes.
6542         * i386-linux-tdep.c: Fix common/ includes.
6543         * i386-linux-nat.c: Fix common/ includes.
6544         * i386-go32-tdep.c: Fix common/ includes.
6545         * i386-fbsd-tdep.c: Fix common/ includes.
6546         * i386-fbsd-nat.c: Fix common/ includes.
6547         * guile/scm-type.c: Fix common/ includes.
6548         * guile/guile.c: Fix common/ includes.
6549         * go32-nat.c: Fix common/ includes.
6550         * gnu-nat.c: Fix common/ includes.
6551         * gdbthread.h: Fix common/ includes.
6552         * gdbarch-selftests.c: Fix common/ includes.
6553         * gdb_usleep.c: Fix common/ includes.
6554         * gdb_select.h: Fix common/ includes.
6555         * gdb_bfd.c: Fix common/ includes.
6556         * gcore.c: Fix common/ includes.
6557         * fork-child.c: Fix common/ includes.
6558         * findvar.c: Fix common/ includes.
6559         * fbsd-nat.c: Fix common/ includes.
6560         * event-top.c: Fix common/ includes.
6561         * event-loop.c: Fix common/ includes.
6562         * dwarf2read.c: Fix common/ includes.
6563         * dwarf2loc.c: Fix common/ includes.
6564         * dwarf2-frame.c: Fix common/ includes.
6565         * dwarf-index-cache.c: Fix common/ includes.
6566         * dtrace-probe.c: Fix common/ includes.
6567         * disasm-selftests.c: Fix common/ includes.
6568         * defs.h: Fix common/ includes.
6569         * csky-tdep.c: Fix common/ includes.
6570         * cp-valprint.c: Fix common/ includes.
6571         * cp-support.h: Fix common/ includes.
6572         * cp-support.c: Fix common/ includes.
6573         * corelow.c: Fix common/ includes.
6574         * completer.h: Fix common/ includes.
6575         * completer.c: Fix common/ includes.
6576         * compile/compile.c: Fix common/ includes.
6577         * compile/compile-loc2c.c: Fix common/ includes.
6578         * compile/compile-cplus-types.c: Fix common/ includes.
6579         * compile/compile-cplus-symbols.c: Fix common/ includes.
6580         * command.h: Fix common/ includes.
6581         * cli/cli-dump.c: Fix common/ includes.
6582         * cli/cli-cmds.c: Fix common/ includes.
6583         * charset.c: Fix common/ includes.
6584         * build-id.c: Fix common/ includes.
6585         * btrace.h: Fix common/ includes.
6586         * btrace.c: Fix common/ includes.
6587         * breakpoint.h: Fix common/ includes.
6588         * breakpoint.c: Fix common/ includes.
6589         * ax.h:
6590         (enum agent_op): Fix common/ includes.
6591         * ax-general.c (struct aop_map): Fix common/ includes.
6592         * ax-gdb.c: Fix common/ includes.
6593         * auxv.c: Fix common/ includes.
6594         * auto-load.c: Fix common/ includes.
6595         * arm-tdep.c: Fix common/ includes.
6596         * arch/riscv.c: Fix common/ includes.
6597         * arch/ppc-linux-common.c: Fix common/ includes.
6598         * arch/i386.c: Fix common/ includes.
6599         * arch/arm.c: Fix common/ includes.
6600         * arch/arm-linux.c: Fix common/ includes.
6601         * arch/arm-get-next-pcs.c: Fix common/ includes.
6602         * arch/amd64.c: Fix common/ includes.
6603         * arch/aarch64.c: Fix common/ includes.
6604         * arch/aarch64-insn.c: Fix common/ includes.
6605         * arch-utils.c: Fix common/ includes.
6606         * amd64-windows-tdep.c: Fix common/ includes.
6607         * amd64-tdep.c: Fix common/ includes.
6608         * amd64-sol2-tdep.c: Fix common/ includes.
6609         * amd64-obsd-tdep.c: Fix common/ includes.
6610         * amd64-nbsd-tdep.c: Fix common/ includes.
6611         * amd64-linux-tdep.c: Fix common/ includes.
6612         * amd64-linux-nat.c: Fix common/ includes.
6613         * amd64-fbsd-tdep.c: Fix common/ includes.
6614         * amd64-fbsd-nat.c: Fix common/ includes.
6615         * amd64-dicos-tdep.c: Fix common/ includes.
6616         * amd64-darwin-tdep.c: Fix common/ includes.
6617         * agent.c: Fix common/ includes.
6618         * ada-lang.h: Fix common/ includes.
6619         * ada-lang.c: Fix common/ includes.
6620         * aarch64-tdep.c: Fix common/ includes.
6621
6622 2019-01-25  Tom Tromey  <tom@tromey.com>
6623
6624         * common/create-version.sh: Use common/version.h.
6625
6626 2019-01-24  Pedro Alves  <palves@redhat.com>
6627
6628         * infrun.c (signal_stop, signal_print, signal_program)
6629         (signal_catch, signal_pass): Now arrays instead of pointers.
6630         (update_signals_program_target, do_target_resume)
6631         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6632         * linux-nat.c (linux_nat_target::pass_signals)
6633         (linux_nat_target::create_inferior, linux_nat_target::attach):
6634         Adjust.
6635         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6636         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6637         * procfs.c (procfs_target::pass_signals): Adjust.
6638         * record-full.c (record_full_target::resume): Adjust.
6639         * remote.c (remote_target::pass_signals)
6640         (remote_target::program_signals): Adjust.
6641         * target-debug.h (target_debug_print_signals): Now takes a
6642         gdb::array_view as parameter.  Adjust.
6643         * target.h (target_ops) <pass_signals, program_signals>: Replace
6644         pointer and length parameters with gdb::array_view.
6645         (target_pass_signals, target_program_signals): Likewise.
6646         * target-delegates.c: Regenerate.
6647
6648 2019-01-24  Pedro Alves  <palves@redhat.com>
6649
6650         * common/forward-scope-exit.h
6651         (forward_scope_exit::forward_scope_exit): Pass arguments to
6652         m_bind_function directly, instead of creating a std::bind and
6653         copying that.
6654
6655 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6656
6657         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6658         for static members.
6659         (pass_in_v_vfp_candidate): Likewise.
6660
6661 2019-01-23  Tom Tromey  <tom@tromey.com>
6662             Pedro Alves  <palves@redhat.com>
6663
6664         * regcache.c (class regcache_invalidator): Remove.
6665         (regcache::raw_write): Use make_scope_exit.
6666
6667 2019-01-23  Tom Tromey  <tom@tromey.com>
6668
6669         * ui-out.h (class ui_out_emit_type): Update comment.
6670
6671 2019-01-23  Tom Tromey  <tom@tromey.com>
6672
6673         * infrun.c (fetch_inferior_event): Update comment.
6674
6675 2019-01-23  Tom Tromey  <tom@tromey.com>
6676             Pedro Alves  <palves@redhat.com>
6677
6678         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6679         parameter.
6680         (fetch_inferior_event): Use SCOPE_EXIT.
6681
6682
6683 2019-01-23  Tom Tromey  <tom@tromey.com>
6684             Pedro Alves  <palves@redhat.com>
6685
6686         * infrun.c (disable_thread_events): Delete.
6687         (stop_all_threads): Use SCOPE_EXIT.
6688
6689 2019-01-23  Tom Tromey  <tom@tromey.com>
6690             Pedro Alves  <palves@redhat.com>
6691
6692         * symfile.c: Include forward-scope-exit.h.
6693         (clear_symtab_users_cleanup): Replace forward declaration with
6694         a FORWARD_SCOPE_EXIT.
6695         (syms_from_objfile_1): Use the forward_scope_exit and
6696         gdb::optional instead of cleanup_function.
6697         (reread_symbols): Use the forward_scope_exit instead of
6698         cleanup_function.
6699         (clear_symtab_users_cleanup): Remove function.
6700
6701 2019-01-23  Tom Tromey  <tom@tromey.com>
6702             Pedro Alves  <palves@redhat.com>
6703
6704         * linux-nat.c: Include scope-exit.h.
6705         (cleanup_target_stop): Remove.
6706         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6707         SCOPE_EXIT.
6708
6709 2019-01-23  Tom Tromey  <tom@tromey.com>
6710             Pedro Alves  <palves@redhat.com>
6711
6712         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6713         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6714
6715 2019-01-23  Tom Tromey  <tom@tromey.com>
6716             Andrew Burgess  <andrew.burgess@embecosm.com>
6717             Pedro Alves  <palves@redhat.com>
6718
6719         * infrun.c (fetch_inferior_event): Use scope_exit.
6720         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6721         * top.c (execute_command): Use scope_exit.
6722         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6723         * utils.c (do_bpstat_clear_actions_cleanup)
6724         (make_bpstat_clear_actions_cleanup): Remove.
6725
6726 2019-01-23  Tom Tromey  <tom@tromey.com>
6727             Pedro Alves  <palves@redhat.com>
6728
6729         * infrun.c: Include "common/scope-exit.h"
6730         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6731         (wait_for_inferior): Use SCOPE_EXIT.
6732         (fetch_inferior_event): Use scope_exit.
6733
6734 2019-01-23  Tom Tromey  <tom@tromey.com>
6735             Pedro Alves  <palves@redhat.com>
6736
6737         * breakpoint.c (create_breakpoint): Remove cleanup.
6738
6739 2019-01-23  Tom Tromey  <tom@tromey.com>
6740             Andrew Burgess  <andrew.burgess@embecosm.com>
6741             Pedro Alves  <palves@redhat.com>
6742
6743 2019-01-23  Pedro Alves  <palves@redhat.com>
6744
6745         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6746
6747 2019-01-23  Pedro Alves  <palves@redhat.com>
6748             Andrew Burgess  <andrew.burgess@embecosm.com>
6749
6750         * gdbthread.h: Include "common/forward-scope-exit.h".
6751         (scoped_finish_thread_state): Redefine custom class in terms of
6752         forward_scope_exit.
6753
6754 2019-01-23  Pedro Alves  <palves@redhat.com>
6755             Andrew Burgess  <andrew.burgess@embecosm.com>
6756
6757         * common/forward-scope-exit.h: New file.
6758
6759 2019-01-23  Pedro Alves  <palves@redhat.com>
6760             Andrew Burgess  <andrew.burgess@embecosm.com>
6761             Tom Tromey  <tom@tromey.com>
6762
6763         * common/scope-exit.h: New file.
6764
6765 2019-01-23  Pedro Alves  <palves@redhat.com>
6766
6767         * common/preprocessor.h (ESC): Rename to ...
6768         (ESC_PARENS): ... this.
6769         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6770         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6771
6772 2019-01-23  Tom Tromey  <tom@tromey.com>
6773
6774         * language.h (class scoped_switch_to_sym_language_if_auto):
6775         Initialize m_lang in both cases.
6776
6777 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6778
6779         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6780         with XCNEW.
6781
6782 2019-01-22  Tom Tromey  <tom@tromey.com>
6783
6784         * corelow.c: Do not include sys/file.h.
6785
6786 2019-01-22  Tom Tromey  <tom@tromey.com>
6787
6788         * tui/tui-wingeneral.h: Include gdb_curses.h.
6789
6790 2019-01-22  Tom Tromey  <tom@tromey.com>
6791
6792         * source-cache.h (class source_cache) <get_source_lines,
6793         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6794
6795 2019-01-22  Tom Tromey  <tom@tromey.com>
6796
6797         * remote-fileio.h (struct remote_target): Declare.
6798
6799 2019-01-22  Tom Tromey  <tom@tromey.com>
6800
6801         * python/py-arch.c: Do not include py-ref.h.
6802         * python/py-bpevent.c: Do not include py-ref.h.
6803         * python/py-cmd.c: Do not include py-ref.h.
6804         * python/py-continueevent.c: Do not include py-ref.h.
6805         * python/py-event.h: Do not include py-ref.h.
6806         * python/py-evtregistry.c: Do not include py-ref.h.
6807         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6808         * python/py-frame.c: Do not include py-ref.h.
6809         * python/py-framefilter.c: Do not include py-ref.h.
6810         * python/py-function.c: Do not include py-ref.h.
6811         * python/py-infevents.c: Do not include py-ref.h.
6812         * python/py-linetable.c: Do not include py-ref.h.
6813         * python/py-objfile.c: Do not include py-ref.h.
6814         * python/py-param.c: Do not include py-ref.h.
6815         * python/py-prettyprint.c: Do not include py-ref.h.
6816         * python/py-progspace.c: Do not include py-ref.h.
6817         * python/py-symbol.c: Do not include py-ref.h.
6818         * python/py-symtab.c: Do not include py-ref.h.
6819         * python/py-type.c: Do not include py-ref.h.
6820         * python/py-unwind.c: Do not include py-ref.h.
6821         * python/py-utils.c: Do not include py-ref.h.
6822         * python/py-value.c: Do not include py-ref.h.
6823         * python/py-varobj.c: Do not include py-ref.h.
6824         * python/py-xmethods.c: Do not include py-ref.h.
6825         * python/python.c: Do not include py-ref.h.
6826         * varobj.c: Do not include py-ref.h.
6827
6828 2019-01-22  Tom Tromey  <tom@tromey.com>
6829
6830         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6831         keyword for bcache.
6832
6833 2019-01-22  Tom Tromey  <tom@tromey.com>
6834
6835         * compile/compile-cplus-types.c: Remove a comment by #include.
6836
6837 2019-01-22  Tom Tromey  <tom@tromey.com>
6838
6839         * compile/gcc-c-plugin.h: Include compile-internal.h.
6840
6841 2019-01-22  Tom Tromey  <tom@tromey.com>
6842
6843         * stabsread.c (EXTERN): Do not define.
6844         (symnum, next_symbol_text_func, processing_gcc_compilation)
6845         (within_function, global_sym_chain, global_stabs)
6846         (previous_stab_code, this_object_header_files)
6847         (n_this_object_header_files)
6848         (n_allocated_this_object_header_files): Define.
6849         * stabsread.h (EXTERN): Never define.  Use "extern".
6850
6851 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6852
6853         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6854         history_value.
6855
6856 2019-01-21  Tom Tromey  <tom@tromey.com>
6857
6858         * ui-out.c: Fix includes.
6859         * tui/tui-source.c: Fix includes.
6860         * target.c: Fix includes.
6861         * remote.c: Fix includes.
6862         * regcache.c: Fix includes.
6863         * python/py-block.c: Fix includes.
6864         * printcmd.c: Fix includes.
6865         * or1k-tdep.c: Fix includes.
6866         * mi/mi-main.c: Fix includes.
6867         * m32r-tdep.c: Fix includes.
6868         * csky-tdep.c: Fix includes.
6869         * compile/compile-cplus-types.c: Fix includes.
6870         * cli/cli-interp.c: Fix includes.
6871
6872 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6873
6874         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6875         for padding.
6876
6877 2019-01-16  Tom Tromey  <tom@tromey.com>
6878
6879         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6880         earlier.
6881         (struct objfile) <msymbols_range>: Move from top level.
6882         <msymbols>: New method.
6883         (class objfile_msymbols): Remove.
6884         * symtab.c (default_collect_symbol_completion_matches_break_on):
6885         Update.
6886         * symmisc.c (dump_msymbols): Update.
6887         * stabsread.c (scan_file_globals): Update.
6888         * objc-lang.c (info_selectors_command, info_classes_command)
6889         (find_methods): Update.
6890         * minsyms.c (find_solib_trampoline_target): Update.
6891         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6892         * coffread.c (coff_symfile_read): Update.
6893         * ada-lang.c (ada_lookup_simple_minsym)
6894         (ada_collect_symbol_completion_matches): Update.
6895
6896 2019-01-16  Tom Tromey  <tom@tromey.com>
6897
6898         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6899         type.  Remove no-argument constructor.
6900         <iterator::operator++>: Simplify.
6901         <begin>: Update.
6902         <end>: Use minimal_symbol_count.
6903
6904 2019-01-16  Tom Tromey  <tom@tromey.com>
6905
6906         * objfiles.h (struct objfile) <psymtabs>: New method.
6907         (class objfile_psymtabs): Remove.
6908         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6909         typedef.
6910         <range>: New method.
6911         (require_partial_symbols): Change return type.
6912         * psymtab.c (require_partial_symbols)
6913         (psym_expand_symtabs_matching): Update.
6914         * mdebugread.c (parse_partial_symbols): Update.
6915         * dbxread.c (dbx_end_psymtab): Update.
6916
6917 2019-01-15  Tom Tromey  <tom@tromey.com>
6918
6919         * symtab.c (lookup_objfile_from_block)
6920         (lookup_symbol_in_objfile_symtabs)
6921         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6922         (find_line_symtab, info_sources_command)
6923         (default_collect_symbol_completion_matches_break_on)
6924         (make_source_files_completion_list): Update.
6925         * symmisc.c (print_objfile_statistics, dump_objfile)
6926         (maintenance_print_symbols, maintenance_info_symtabs)
6927         (maintenance_check_symtabs, maintenance_info_line_tables):
6928         Update.
6929         * source.c (select_source_symtab)
6930         (forget_cached_source_info_for_objfile): Update.
6931         * objfiles.h (class objfile_compunits): Remove.
6932         (struct objfile) <compunits_range>: New typedef.
6933         (compunits): New method.
6934         * objfiles.c (objfile_relocate1): Update.
6935         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6936         * maint.c (count_symtabs_and_blocks): Update.
6937         * linespec.c (iterate_over_all_matching_symtabs): Update.
6938         * cp-support.c (add_symbol_overload_list_qualified): Update.
6939         * coffread.c (coff_symtab_read): Update.
6940         * ada-lang.c (add_nonlocal_symbols)
6941         (ada_collect_symbol_completion_matches)
6942         (ada_add_global_exceptions): Update.
6943
6944 2019-01-15  Tom Tromey  <tom@tromey.com>
6945
6946         * progspace.h (program_space) <objfiles_safe_range>: New
6947         typedef.
6948         <objfiles_safe>: New method.
6949         * objfiles.h (class all_objfiles_safe): Remove.
6950         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6951         * jit.c (jit_inferior_exit_hook): Update.
6952
6953 2019-01-17  Tom Tromey  <tom@tromey.com>
6954
6955         * progspace.h (program_space) <objfiles_range>: New typedef.
6956         <objfiles>: New method.
6957         <objfiles_head>: Rename from objfiles.
6958         (object_files): Update.
6959         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6960         * guile/scm-pretty-print.c
6961         (ppscm_find_pretty_printer_from_objfiles): Update.
6962         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6963         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6964         Update.
6965         * python/py-progspace.c (pspy_get_objfiles): Update.
6966         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6967         Update.
6968         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6969         (objfpy_lookup_objfile_by_build_id): Update.
6970         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6971         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6972         Update.
6973         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6974         (expand_symtab_containing_pc, lookup_objfile_from_block)
6975         (lookup_static_symbol, basic_lookup_transparent_type)
6976         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6977         (find_line_symtab, info_sources_command)
6978         (default_collect_symbol_completion_matches_break_on)
6979         (make_source_files_completion_list, find_main_name): Update.
6980         * symmisc.c (print_symbol_bcache_statistics)
6981         (print_objfile_statistics, maintenance_print_symbols)
6982         (maintenance_print_msymbols, maintenance_print_objfiles)
6983         (maintenance_info_symtabs, maintenance_check_symtabs)
6984         (maintenance_expand_symtabs, maintenance_info_line_tables):
6985         Update.
6986         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6987         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6988         (map_overlay_command, unmap_overlay_command)
6989         (simple_overlay_update, expand_symtabs_matching)
6990         (map_symbol_filenames): Update.
6991         * symfile-debug.c (set_debug_symfile): Update.
6992         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6993         Update.
6994         * source.c (select_source_symtab, forget_cached_source_info):
6995         Update.
6996         * solib.c (solib_read_symbols): Update.
6997         * solib-spu.c (append_ocl_sos): Update.
6998         * psymtab.c (maintenance_print_psymbols)
6999         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7000         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7001         * printcmd.c (info_symbol_command): Update.
7002         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7003         Update.
7004         * objfiles.h (class all_objfiles): Remove.
7005         * objfiles.c (have_partial_symbols, have_full_symbols)
7006         (have_minimal_symbols, qsort_cmp, update_section_map)
7007         (shared_objfile_contains_address_p)
7008         (default_iterate_over_objfiles_in_search_order): Update.
7009         * objc-lang.c (info_selectors_command, info_classes_command)
7010         (find_methods): Update.
7011         * minsyms.c (find_solib_trampoline_target): Update.
7012         * maint.c (maintenance_info_sections)
7013         (maintenance_translate_address, count_symtabs_and_blocks):
7014         Update.
7015         * main.c (captured_main_1): Update.
7016         * linux-thread-db.c (try_thread_db_load_from_pdir)
7017         (has_libpthread): Update.
7018         * linespec.c (iterate_over_all_matching_symtabs)
7019         (search_minsyms_for_name): Update.
7020         * jit.c (jit_find_objf_with_entry_addr): Update.
7021         * hppa-tdep.c (find_unwind_entry)
7022         (hppa_lookup_stub_minimal_symbol): Update.
7023         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7024         Update.
7025         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7026         (elf_gnu_ifunc_resolve_by_got): Update.
7027         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7028         * dwarf-index-write.c (save_gdb_index_command): Update.
7029         * cp-support.c (add_symbol_overload_list_qualified): Update.
7030         * breakpoint.c (create_overlay_event_breakpoint)
7031         (create_longjmp_master_breakpoint)
7032         (create_std_terminate_master_breakpoint)
7033         (create_exception_master_breakpoint): Update.
7034         * blockframe.c (find_pc_partial_function): Update.
7035         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7036         (ada_collect_symbol_completion_matches)
7037         (ada_add_global_exceptions): Update.
7038
7039 2019-01-17  Tom Tromey  <tom@tromey.com>
7040
7041         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7042         declare VEC.
7043         (solib_target_parse_libraries): Change return type.
7044         (library_list_start_segment, library_list_start_section)
7045         (library_list_end_library, library_list_start_library); Update.
7046         (solib_target_free_library_list): Remove.
7047         (solib_target_parse_libraries): Remove cleanup.  Change return
7048         type.
7049         (solib_target_current_sos): Update.
7050
7051 2019-01-17  Tom Tromey  <tromey@bapiya>
7052
7053         * valprint.c: Replace "the the" with "the".
7054         * symtab.c: Replace "the the" with "the".
7055         * solib.c: Replace "the the" with "the".
7056         * solib-dsbt.c: Replace "the the" with "the".
7057         * linespec.c: Replace "the the" with "the".
7058         * dwarf2loc.h: Replace "the the" with "the".
7059         * amd64-windows-tdep.c: Replace "the the" with "the".
7060         * aarch64-tdep.c: Replace "the the" with "the".
7061
7062 2019-01-16  Keith Seitz  <keiths@redhat.com>
7063
7064         PR gdb/23773
7065         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7066         <builder>: Rename to ..
7067         <m_builder>: ... this and make private.
7068         (dwarf2_cu::get_builder): New method.  Change all users of
7069         `builder' to use this method.
7070         (dwarf2_start_symtab): Move to ...
7071         (dwarf2_cu::start_symtab): ... here.  Update all callers
7072         (setup_type_unit_groups): Move to ...
7073         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7074         callers.
7075         (dwarf2_cu::reset_builder): New method.
7076         (process_full_compunit, process_full_type_unit): Use
7077         dwarf2_cu::reset_builder.
7078         (follow_die_offset): Record the ancestor CU if it is different
7079         from the followed DIE's CU.
7080         (follow_die_sig_1): Likewise.
7081
7082 2019-01-15  Tom Tromey  <tom@tromey.com>
7083
7084         * remote.c (class remote_state) <buf>: Now a char_vector.
7085         <buf_size>: Remove.
7086         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7087         parameter.
7088         (remote_target::getpkt_or_notif_sane_1)
7089         (remote_target::getpkt_sane)
7090         (remote_target::getpkt_or_notif_sane): Likewise.
7091         (class remote_target) <putpkt>: New overload.
7092         (remote_target::read_frame): Change type of "buf_p".  Remove
7093         sizeof_p parameter.
7094         (packet_ok): New overload.
7095         (packet_check_result): New overload.
7096         Update all uses.
7097
7098 2019-01-14  Tom Tromey  <tom@tromey.com>
7099
7100         * remote-notif.c (handle_notification, remote_notif_ack)
7101         (remote_notif_parse): Make "buf" const.
7102         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7103         const.
7104         (remote_notif_parse, remote_notif_ack, handle_notification):
7105         Likewise.
7106         * remote.c (remote_notif_stop_parse): Make "buf" const.
7107         (remote_target::remote_parse_stop_reply): Make "buf" const.
7108         (remote_notif_stop_ack): Make "buf" const.
7109
7110 2019-01-14  Tom Tromey  <tom@tromey.com>
7111
7112         * remote.c (remote_console_output): Make parameter const.
7113
7114 2019-01-14  Tom Tromey  <tom@tromey.com>
7115
7116         * target-debug.h (target_debug_print_signals): Constify.
7117         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7118         * procfs.c (procfs_target::pass_signals): Update.
7119         * linux-nat.c (linux_nat_target::pass_signals): Update.
7120         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7121         * target-delegates.c: Rebuild.
7122         * remote.c (remote_target::program_signals): Update.
7123         (remote_target::pass_signals): Update.
7124         * target.c (target_pass_signals): Constify argument.
7125         (target_program_signals): Likewise.
7126         * target.h (struct target_ops) <pass_signals, program_signals>:
7127         Constify argument.
7128         (target_pass_signals, target_program_signals): Constify argument.
7129
7130 2019-01-14  Tom Tromey  <tom@tromey.com>
7131
7132         PR tui/28819:
7133         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7134
7135 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7136
7137         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7138         field.
7139         * rs6000-tdep.c: Include reggroups.h.
7140         (IS_V_ALIAS_PSEUDOREG): Define.
7141         (rs6000_register_name): Return names for the "vX" aliases.
7142         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7143         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7144         aliases.  Call default_register_reggroup_p for all other
7145         pseudo-registers.
7146         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7147         New functions.
7148         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7149         Handle "vX" aliases.
7150         (v_alias_pseudo_register_collect): New function.
7151         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7152         (rs6000_gdbarch_init): Initialize "vX" aliases as
7153         pseudo-registers.  Restore registration of
7154         rs6000_pseudo_register_reggroup_p with
7155         set_tdesc_pseudo_register_reggroup_p.
7156
7157 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7158
7159         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7160         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7161         set_gdbarch_num_pseudo_regs.
7162
7163 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7164
7165         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7166         Remove arg prefixname, add do_set and do_show.
7167         Add member functions set_list and show_list.
7168         * cli/cli-style.c (class cli_style_option): Update accordingly.
7169         (style_set_list): Move to file scope.
7170         (style_show_list): Likewise.
7171         (set_style): Call help_list.
7172         (show_style): Call cmd_show_list.
7173         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7174         Update to use the new macro.
7175
7176 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7177
7178         * ada-lang.c (_initialize_ada_language): Expand the help text
7179         for the "catch exception" command.
7180
7181 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7182
7183         * symtab.c (matching_obj_sections): Initialize obj,
7184         declare it closer to its usage.
7185
7186 2019-01-10  Tom Tromey  <tom@tromey.com>
7187
7188         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7189         (basic_inf_threads_range): Remove.
7190         (inf_threads_range, inf_non_exited_threads_range)
7191         (safe_inf_threads_range): Use next_adapter.
7192
7193 2019-01-10  Keith Seitz  <keiths@redhat.com>
7194
7195         PR gdb/23712
7196         PR symtab/23010
7197         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7198         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7199
7200 2019-01-10  Keith Seitz  <keiths@redhat.com>
7201
7202         PR gdb/23712
7203         PR symtab/23010
7204         * dictionary.c (pending_to_vector): Remove.
7205         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7206         Remove _1 suffix, replacing functions of the same name.  Update
7207         all callers.
7208         (dict_create_hashed, dict_create_hashed_expandable)
7209         (dict_create_linear, dict_create_linear_expandable, dict_free)
7210         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7211         Make functions static.
7212
7213 2019-01-10  Keith Seitz  <keiths@redhat.com>
7214
7215         PR gdb/23712
7216         PR symtab/23010
7217         * dictionary.h (struct dictionary): Replace declaration with
7218         multidictionary.
7219         (dict_create_hashed, dict_create_hashed_expandable)
7220         (dict_create_linear, dict_create_linear_expandable)
7221         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7222         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7223         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7224         taking multidictionary argument.
7225         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7226         * block.h (struct block) <dict>: Change to multidictionary
7227         and rename `multidict'.
7228         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7229         symmisc.c: Update all dictionary references to multidictionary.
7230
7231 2019-01-10  Keith Seitz  <keiths@redhat.com>
7232
7233         PR gdb/23712
7234         PR symtab/23010
7235         * dictionary.c: Include unordered_map.
7236         (pending_to_vector): New function.
7237         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7238         Rewrite the non-"_1" functions to take vector instead
7239         of linked list.
7240         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7241         "new" _1 versions of the same name.
7242         (multidictionary): Define.
7243         (std::hash<enum language): New definition.
7244         (collate_pending_symbols_by_language, mdict_create_hashed)
7245         (mdict_create_hashed_expandable, mdict_create_linear)
7246         (mdict_create_linear_expandable, mdict_free)
7247         (find_language_dictionary, create_new_language_dictionary)
7248         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7249         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7250         (mdict_size, mdict_empty): New functions.
7251         * dictionary.h (mdict_iterator): Define.
7252
7253 2019-01-10  Pedro Alves  <palves@redhat.com>
7254
7255         * breakpoint.c (read_uploaded_action)
7256         (create_tracepoint_from_upload): Adjust to use
7257         gdb::unique_xmalloc_ptr.
7258         * ctf.c (ctf_write_uploaded_tp):
7259         (SET_ARRAY_FIELD): Use emplace_back.
7260         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7261         * tracefile-tfile.c (tfile_write_uploaded_tp):
7262         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7263         gdb::unique_xmalloc_ptr.
7264         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7265         at_string, cond_string, cmd_strings>: Replace char pointers
7266         with gdb::unique_xmalloc_ptr.
7267
7268 2019-01-10  Pedro Alves  <palves@redhat.com>
7269
7270         * solib-target.c (library_list_start_library): Don't xstrdup name.
7271
7272 2019-01-10  Pedro Alves  <palves@redhat.com>
7273
7274         * mdebugread.c (parse_partial_symbols): Use
7275         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7276
7277 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7278
7279         * linux-fork.c (scoped_switch_fork_info)
7280         <~scoped_switch_fork_info>: Fix incorrect variable name.
7281
7282 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7283
7284         * linux-fork.c (scoped_switch_fork_info)
7285         <scoped_switch_fork_info>: Make explicit.
7286         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7287
7288 2019-01-10  Tom Tromey  <tom@tromey.com>
7289
7290         * objfiles.h (objfile::reset_psymtabs): Update.
7291         * objfiles.c (objfile::objfile): Update.
7292         * psymtab.h (psymtab_storage::obstack): Update.
7293         (psymtab_storage::m_obstack): Use gdb::optional.
7294         (class psymtab_storage): Update comment.  Remove objfile
7295         parameter.
7296         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7297
7298 2019-01-10  Tom Tromey  <tom@tromey.com>
7299
7300         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7301         <free_psymtabs>: Now private.
7302         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7303         (allocate_psymtab): Use new method.
7304
7305 2019-01-10  Tom Tromey  <tom@tromey.com>
7306
7307         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7308         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7309         * mdebugread.c (parse_partial_symbols): Use
7310         allocate_dependencies.
7311         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7312         allocate_dependencies.
7313         (process_psymtab_comp_unit_reader)
7314         (build_type_psymtab_dependencies): Likewise.
7315         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7316
7317 2019-01-10  Tom Tromey  <tom@tromey.com>
7318
7319         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7320         PSYMBOL_SET_LANGUAGE.
7321         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7322
7323 2019-01-10  Tom Tromey  <tom@tromey.com>
7324
7325         * psymtab.h (psymtab_storage::obstack): New method.
7326         <m_obstack>: Rename from obstack; now private.
7327         * psymtab.c (psymtab_storage): Update.
7328         * dwarf2read.c (create_addrmap_from_index)
7329         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7330         Update.
7331
7332 2019-01-10  Tom Tromey  <tom@tromey.com>
7333
7334         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7335         * objfiles.h (objfile::reset_psymtabs): New method.
7336
7337 2019-01-10  Tom Tromey  <tom@tromey.com>
7338
7339         * symmisc.c (print_symbol_bcache_statistics): Update.
7340         (print_objfile_statistics): Update.
7341         * symfile.c (reread_symbols): Update.
7342         * psymtab.h (class psymtab_storage): New.
7343         * psymtab.c (psymtab_storage): New constructor.
7344         (~psymtab_storage): New destructor.
7345         (require_partial_symbols): Update.
7346         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7347         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7348         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7349         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7350         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7351         (start_psymtab_common, end_psymtab_common)
7352         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7353         (allocate_psymtab): Update.
7354         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7355         Update.
7356         (dump_psymtab_addrmap, maintenance_print_psymbols)
7357         (maintenance_check_psymtabs): Update.
7358         (class objfile_psymtabs): Move to objfiles.h.
7359         * psympriv.h (discard_psymtab): Now inline.
7360         (psymtab_discarder::psymtab_discarder): Update.
7361         (psymtab_discarder::~psymtab_discarder): Update.
7362         (ALL_OBJFILE_PSYMTABS): Rewrite.
7363         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7364         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7365         Remove fields.
7366         <partial_symtabs>: New field.
7367         (class objfile_psymtabs): Move from psymtab.h.  Update.
7368         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7369         psymbol_cache.
7370         (objfile::~objfile): Don't destroy psymbol_cache.
7371         * mdebugread.c (parse_partial_symbols): Update.
7372         * dwarf2read.c (create_addrmap_from_index)
7373         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7374         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7375         (add_partial_subprogram, dwarf2_ranges_read): Update.
7376         * dwarf-index-write.c (write_address_map)
7377         (write_one_signatured_type, recursively_write_psymbols)
7378         (class debug_names, class debug_names, write_psymtabs_to_index):
7379         Update.
7380
7381 2019-01-10  Tom Tromey  <tom@tromey.com>
7382
7383         * symtab.h (SYMBOL_SET_NAMES): Update.
7384         (symbol_set_names): Update.
7385         (MSYMBOL_SET_NAMES): Update.
7386         * symtab.c (symbol_set_names): Change argument to be an
7387         objfile_per_bfd_storage.
7388         * psymtab.c (add_psymbol_to_bcache): Update.
7389         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7390
7391 2019-01-10  Tom Tromey  <tom@tromey.com>
7392
7393         * symtab.c (create_demangled_names_hash): Change argument to be an
7394         objfile_per_bfd_storage.
7395         (symbol_set_names): Update.
7396
7397 2019-01-10  Tom Tromey  <tom@tromey.com>
7398
7399         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7400         init_psymbol_list.
7401         * psymtab.c (init_psymbol_list): Do nothing if already called.
7402         * psympriv.h (init_psymbol_list): Add comment.
7403         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7404         init_psymbol_list.
7405         * dbxread.c (dbx_symfile_read): Unconditionally call
7406         init_psymbol_list.
7407
7408 2019-01-10  Tom Tromey  <tom@tromey.com>
7409
7410         * xcoffread.c (scan_xcoff_symtab): Update.
7411         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7412         "where".
7413         * mdebugread.c (parse_partial_symbols)
7414         (handle_psymbol_enumerators): Update.
7415         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7416         * dbxread.c (read_dbx_symtab): Update.
7417         * psympriv.h (psymbol_placement): New enum.
7418         (add_psymbol_to_list): Update.
7419
7420 2019-01-10  Tom Tromey  <tom@tromey.com>
7421
7422         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7423         static_psymbols parameters.
7424         (scan_xcoff_symtab): Update.
7425         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7426         static_psymbols parameters.
7427         * psympriv.h (start_psymtab_common): Update.
7428         * mdebugread.c (parse_partial_symbols): Update.
7429         * dwarf2read.c (create_partial_symtab): Update.
7430         * dbxread.c (read_dbx_symtab): Update.
7431         (start_psymtab): Remove global_psymbols and static_psymbols
7432         parameters.
7433
7434 2019-01-10  Tom Tromey  <tom@tromey.com>
7435
7436         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7437         * psymtab.c (allocate_psymtab): Add comment.
7438         * psympriv.h (allocate_psymtab): Add comment.
7439         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7440         initializations.
7441         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7442
7443 2019-01-10  Tom Tromey  <tom@tromey.com>
7444
7445         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7446         Don't declare.
7447         * mipsread.c: Include mdebugread.h.
7448         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7449         Declare.
7450         * elfread.c: Include mdebugread.h.
7451
7452 2019-01-09  Tom Tromey  <tom@tromey.com>
7453
7454         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7455         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7456         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7457         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7458         (psym_lookup_symbol, psym_find_last_source_symtab)
7459         (psym_forget_cached_source_info, psym_print_stats)
7460         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7461         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7462         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7463         (psym_find_compunit_symtab_by_address)
7464         (maintenance_print_psymbols, maintenance_info_psymtabs)
7465         (maintenance_check_psymtabs): Use ranged for.
7466         * psymtab.h (class objfile_psymtabs): New.
7467         (require_partial_symbols): Return objfile_psymtabs.
7468         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7469
7470 2019-01-09  Tom Tromey  <tom@tromey.com>
7471
7472         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7473         (find_pc_mapped_section, list_overlays_command)
7474         (map_overlay_command, unmap_overlay_command)
7475         (simple_overlay_update): Use all_objfiles.
7476         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7477         * printcmd.c (info_symbol_command): Use all_objfiles.
7478         * objfiles.h (ALL_OBJSECTIONS): Remove.
7479         * maint.c (maintenance_translate_address): Use all_objfiles.
7480         * gcore.c (gcore_create_callback): Use all_objfiles.
7481         (objfile_find_memory_regions): Likewise.
7482
7483 2019-01-09  Tom Tromey  <tom@tromey.com>
7484
7485         * symtab.c (find_line_symtab, info_sources_command)
7486         (make_source_files_completion_list): Use objfile_compunits.
7487         * source.c (select_source_symtab): Use objfile_compunits.
7488         * objfiles.h (struct objfile): Update comment.
7489         (ALL_OBJFILES): Remove.
7490         (ALL_FILETABS): Remove.
7491         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7492         objfile_compunits.
7493
7494 2019-01-09  Tom Tromey  <tom@tromey.com>
7495
7496         * symmisc.c (print_objfile_statistics, dump_objfile)
7497         (maintenance_print_symbols): Use compunit_filetabs.
7498         * source.c (forget_cached_source_info_for_objfile): Use
7499         compunit_filetabs.
7500         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7501         (ALL_FILETABS): Use compunit_filetabs.
7502         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7503         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7504
7505 2019-01-09  Tom Tromey  <tom@tromey.com>
7506
7507         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7508         (compunit_filetabs): New.
7509         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7510         compunit_filetabs.
7511         (info_sources_command, make_source_files_completion_list): Remove
7512         declaration.
7513         * symmisc.c (print_objfile_statistics, dump_objfile)
7514         (maintenance_print_symbols): Remove declaration.
7515         (maintenance_info_symtabs): Use compunit_filetabs.
7516         (maintenance_info_line_tables): Likewise.
7517         * source.c (select_source_symtab): Change local variable name.
7518         (forget_cached_source_info_for_objfile): Remove declaration.
7519         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7520         * objfiles.c (objfile_relocate1): Remove declaration.
7521         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7522         declaration.
7523         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7524         * coffread.c (coff_symtab_read): Remove declaration.
7525         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7526         compunit_filetabs.
7527
7528 2019-01-09  Tom Tromey  <tom@tromey.com>
7529
7530         * symtab.c (lookup_objfile_from_block)
7531         (find_pc_sect_compunit_symtab, search_symbols)
7532         (default_collect_symbol_completion_matches_break_on): Use
7533         objfile_compunits.
7534         * objfiles.h (ALL_COMPUNITS): Remove.
7535         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7536         * cp-support.c (add_symbol_overload_list_qualified): Use
7537         objfile_compunits.
7538         * ada-lang.c (ada_collect_symbol_completion_matches)
7539         (ada_add_global_exceptions): Use objfile_compunits.
7540
7541 2019-01-09  Tom Tromey  <tom@tromey.com>
7542
7543         * source.c (select_source_symtab)
7544         (forget_cached_source_info_for_objfile): Remove declaration.
7545         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7546         declaration.
7547         * maint.c (count_symtabs_and_blocks): Remove declaration.
7548         * cp-support.c (add_symbol_overload_list_qualified): Remove
7549         declaration.
7550         * coffread.c (coff_symtab_read): Remove declaration.
7551         * symtab.c (lookup_symbol_in_objfile_symtabs)
7552         (basic_lookup_transparent_type_1): Use objfile_compunits.
7553         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7554         (info_sources_command, search_symbols)
7555         (default_collect_symbol_completion_matches_break_on)
7556         (make_source_files_completion_list): Remove declaration.
7557         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7558         (ada_collect_symbol_completion_matches)
7559         (ada_add_global_exceptions): Remove declaration.
7560         * linespec.c (iterate_over_all_matching_symtabs): Use
7561         objfile_compunits.
7562         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7563         (class objfile_compunits): New.
7564         (ALL_COMPUNITS): Use objfile_compunits.
7565         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7566         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7567         objfile_compunits.
7568         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7569
7570 2019-01-09  Tom Tromey  <tom@tromey.com>
7571
7572         * symtab.c (search_symbols)
7573         (default_collect_symbol_completion_matches_break_on): Use
7574         objfile_msymbols.
7575         * ada-lang.c (ada_lookup_simple_minsym)
7576         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7577         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7578         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7579         objfile_msymbols.
7580         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7581         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7582         * objc-lang.c (find_methods): Use objfile_msymbols.
7583         (info_selectors_command, info_classes_command): Likewise.
7584         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7585         * objfiles.h (class objfile_msymbols): New.
7586         (ALL_OBJFILE_MSYMBOLS): Remove.
7587         (ALL_MSYMBOLS): Remove.
7588
7589 2019-01-09  Tom Tromey  <tom@tromey.com>
7590
7591         * common/next-iterator.h (next_adapter): Add Iterator template
7592         parameter.
7593         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7594         (class all_objfiles_safe): New.
7595         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7596         * objfiles.c (put_objfile_before): Update comment.
7597         (add_separate_debug_objfile): Likewise.
7598         (free_all_objfiles): Use all_objfiles_safe.
7599         (objfile_purge_solibs): Likewise.
7600
7601 2019-01-09  Tom Tromey  <tom@tromey.com>
7602
7603         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7604         (expand_symtab_containing_pc, lookup_static_symbol)
7605         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7606         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7607         all_objfiles.
7608         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7609         * breakpoint.c (create_overlay_event_breakpoint)
7610         (create_longjmp_master_breakpoint)
7611         (create_std_terminate_master_breakpoint)
7612         (create_exception_master_breakpoint): Use all_objfiles.
7613         * linux-thread-db.c (try_thread_db_load_from_pdir)
7614         (has_libpthread): Use all_objfiles.
7615         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7616         * linespec.c (iterate_over_all_matching_symtabs)
7617         (search_minsyms_for_name): Use all_objfiles.
7618         * maint.c (maintenance_info_sections): Use all_objfiles.
7619         * main.c (captured_main_1): Use all_objfiles.
7620         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7621         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7622         * guile/scm-pretty-print.c
7623         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7624         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7625         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7626         (maintenance_print_msymbols): Use all_objfiles.
7627         * source.c (select_source_symtab): Use all_objfiles.
7628         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7629         * symfile.c (remove_symbol_file_command)
7630         (expand_symtabs_matching, map_symbol_filenames): Use
7631         all_objfiles.
7632         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7633         all_objfiles.
7634         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7635         * objc-lang.c (find_methods): Use all_objfiles.
7636         * objfiles.c (have_partial_symbols, have_full_symbols)
7637         (have_minimal_symbols, qsort_cmp)
7638         (default_iterate_over_objfiles_in_search_order): Use
7639         all_objfiles.
7640         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7641         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7642         (maintenance_check_psymtabs): Use all_objfiles.
7643         (ALL_PSYMTABS): Remove.
7644         * compile/compile-object-run.c (do_module_cleanup): Use
7645         all_objfiles.
7646         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7647         * cp-support.c (add_symbol_overload_list_qualified): Use
7648         all_objfiles.
7649         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7650         Use all_objfiles.
7651         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7652         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7653         all_objfiles.
7654         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7655         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7656         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7657         Uses all_objfiles.
7658         * solib.c (solib_read_symbols): Use all_objfiles
7659
7660 2019-01-09  Tom Tromey  <tom@tromey.com>
7661
7662         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7663         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7664         all_objfiles.
7665         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7666         * symmisc.c (print_symbol_bcache_statistics)
7667         (print_objfile_statistics, maintenance_print_objfiles)
7668         (maintenance_info_symtabs, maintenance_check_symtabs)
7669         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7670         all_objfiles.
7671         * source.c (forget_cached_source_info): Use all_objfiles.
7672         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7673         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7674         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7675         * objfiles.c (update_section_map): Use all_objfiles.
7676         (shared_objfile_contains_address_p): Likewise.
7677         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7678         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7679
7680 2019-01-09  Tom Tromey  <tom@tromey.com>
7681
7682         * common/next-iterator.h: New file.
7683         * objfiles.h (class all_objfiles): New.
7684         (struct objfile_iterator): New.
7685
7686 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7687
7688         * NEWS: Move the description of the changed "frame", "select-frame",
7689          and "info frame" commands to the Changed commands section.
7690
7691 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7692
7693         * gdbtypes.c (check_stub_method_group): Remove handling of old
7694         mangling schemes.
7695         * linespec.c (find_methods): Likewise.
7696         * stabsread.c (read_member_functions): Likewise.
7697         * valops.c (search_struct_method): Likewise.
7698         (value_struct_elt_for_reference): Likewise.
7699         * NEWS: Mention this change.
7700
7701 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7702
7703         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7704         print_source_lines.
7705         * source.c (print_source_lines_base): Update line number check.
7706         (print_source_lines): New function.
7707         (source_lines_range::source_lines_range): New function.
7708         * source.h (class source_lines_range): New class.
7709         (print_source_lines): New declaration.
7710
7711 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7712
7713         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7714
7715 2019-01-08  Tom Tromey  <tom@tromey.com>
7716             Simon Marchi  <simon.marchi@ericsson.com>
7717
7718         PR gdb/24060
7719         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7720         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7721         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7722         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7723         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7724         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7725
7726 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7727
7728         * source.c (select_source_symtab): Move header comment to
7729         declaration in source.h.
7730         (forget_cached_source_info_for_objfile): Likewise.
7731         (forget_cached_source_info): Likewise.
7732         (identify_source_line): Likewise.
7733         * source.h (identify_source_line): Move declaration from symtab.h
7734         and add comment from source.c
7735         (print_source_lines): Likewise.
7736         (forget_cached_source_info_for_objfile): Likewise.
7737         (forget_cached_source_info): Likewise.
7738         (select_source_symtab): Likewise.
7739         (enum print_source_lines_flag): Move definition from symtab.h.
7740         * symtab.h (identify_source_line): Move declaration to source.h.
7741         (print_source_lines): Likewise.
7742         (forget_cached_source_info_for_objfile): Likewise.
7743         (forget_cached_source_info): Likewise.
7744         (select_source_symtab): Likewise.
7745         (enum print_source_lines_flag): Move definition to source.h.
7746         * tui/tui-hooks.c: Add 'source.h' include.
7747
7748 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7749
7750         * source.c (print_source_lines_base): Handle requests to print
7751         reverse line number sequences, and guard against empty lines
7752         string.
7753
7754 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7755
7756         * source.c (print_source_lines_base): Fix skip of '\r' if next
7757         character is '\n'.
7758
7759 2019-01-06  Tom Tromey  <tom@tromey.com>
7760
7761         * c-exp.y (struct c_parse_state) <macro_original_text,
7762         expansion_obstack>: New member.
7763         (macro_original_text, expansion_obstack): Remove globals.
7764         (scan_macro_expansion, scanning_macro_expansion)
7765         (finished_macro_expansion): Update.
7766         (scan_macro_cleanup): Remove.
7767         (yylex, c_parse): Update.
7768
7769 2019-01-06  Tom Tromey  <tom@tromey.com>
7770
7771         * c-exp.y (struct c_parse_state) <strings>: New member.
7772         (operator_stoken): Update.
7773
7774 2019-01-06  Tom Tromey  <tom@tromey.com>
7775
7776         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7777         (union type_stack_elt) <typelist_val>: Now a pointer to
7778         std::vector.
7779         (type_stack_cleanup): Don't declare.
7780         (push_typelist): Update.
7781         * parse.c (pop_typelist): Return a std::vector.
7782         (push_typelist): Take a std::vector.
7783         (follow_types): Update.  Do not free args.
7784         (type_stack_cleanup): Remove.
7785         * c-exp.y (struct c_parse_state): New.
7786         (cpstate): New global.
7787         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7788         (nonempty_typelist): Update.
7789         (func_mod): Create a new vector.
7790         (c_parse): Create a c_parse_state.
7791         (check_parameter_typelist): Do not delete params.
7792         (function_method): Update.  Do not delete type_list.
7793
7794 2019-01-06  Tom Tromey  <tom@tromey.com>
7795
7796         PR gdb/28155:
7797         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7798         check_typedef.
7799         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7800         (print_return_value): Likewise.
7801
7802 2019-01-05  Tom Tromey  <tom@tromey.com>
7803
7804         * contrib/cleanup_check.py: Remove.
7805         * contrib/gcc-with-excheck: Remove.
7806         * contrib/exsummary.py: Remove.
7807         * contrib/excheck.py: Remove.
7808
7809 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7810
7811         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7812         NULL. Initialize tpprev to NULL instead of assigning it
7813         to NULL on the next statement.
7814         * windows-nat.c (windows_delete_thread): Remove check for
7815         main_thread_id before printing thread exit notifications.
7816         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7817         Remove thread ID check against main_thread_id.
7818         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7819         windows_delete_thread.
7820         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7821
7822 2019-01-04  Tom Tromey  <tom@tromey.com>
7823
7824         * compile/compile.c (_initialize_compile): Use upper case for
7825         metasyntactic variables.
7826         * symmisc.c (_initialize_symmisc): Use upper case for
7827         metasyntactic variables.
7828         * psymtab.c (_initialize_psymtab): Use upper case for
7829         metasyntactic variables.
7830         * demangle.c (demangle_command): Use upper case for metasyntactic
7831         variables.
7832         (_initialize_demangler): Likewise.
7833         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7834         variables.
7835
7836 2019-01-03  Tom Tromey  <tom@tromey.com>
7837
7838         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7839
7840 2019-01-03  Tom Tromey  <tom@tromey.com>
7841
7842         * python/py-symtab.c (salpy_str): Update.
7843         (struct salpy_sal_object) <symtab>: Now a PyObject.
7844         (salpy_dealloc): Update.
7845         (del_objfile_sal): Use gdbpy_ref.
7846
7847 2019-01-03  Tom Tromey  <tom@tromey.com>
7848
7849         * python/py-type.c (convert_field): Use new_reference.  Return
7850         gdbpy_ref.
7851         (make_fielditem): Return gdbpy_ref.
7852         (typy_fields): Update.
7853         (typy_getitem): Update.
7854         (field_name): Return gdbpy_ref.  Use new_reference.
7855         (typy_iterator_iternext): Update.
7856
7857 2019-01-03  Tom Tromey  <tom@tromey.com>
7858
7859         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7860
7861 2019-01-03  Tom Tromey  <tom@tromey.com>
7862
7863         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7864         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7865         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7866         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7867         (pspy_set_type_printers): Likewise.
7868         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7869         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7870         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7871         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7872         (objfpy_set_type_printers): Likewise.
7873
7874 2019-01-03  Tom Tromey  <tom@tromey.com>
7875
7876         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7877         (gdbpy_print_stack): Use gdbpy_err_fetch.
7878         * python/python-internal.h (class gdbpy_err_fetch): New class.
7879         (class gdbpy_enter) <m_error_type, m_error_value,
7880         m_error_traceback>: Remove.
7881         <m_error>: New member.
7882         (gdbpy_exception_to_string): Don't declare.
7883         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7884         * python/py-value.c (convert_value_from_python): Use
7885         gdbpy_err_fetch.
7886         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7887         gdbpy_exception_to_string.
7888         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7889         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7890         gdbpy_err_fetch.
7891
7892 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7893
7894         * linux-nat.c (delete_lwp_cleanup): Delete.
7895         (struct lwp_deleter): New struct.
7896         (lwp_info_up): New typedef.
7897         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7898         lwp_info_up.
7899
7900 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7901
7902         * linux-fork.c (class scoped_switch_fork_info): New class.
7903         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7904
7905 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7906
7907         * valops.c (find_overload_match): Remove use of null_cleanup, and
7908         calls to do_cleanups.
7909
7910 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7911
7912         * compile/compile-cplus-types.c
7913         (compile_cplus_instance::decl_name): Handle changes to
7914         cp_func_name.
7915         * cp-support.c (cp_func_name): Update header comment, update
7916         return type.
7917         * cp-support.h (cp_func_name): Update return type in declaration.
7918         * valops.c (find_overload_match): Move temp_func local to top
7919         level of function and change its type.  Use temp_func to hold and
7920         delete temporary string obtained from cp_func_name.
7921
7922 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7923
7924         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7925         gdb::char_vector, remove cleanup, and update uses of `msg`.
7926
7927 2019-01-03  Jim Wilson  <jimw@sifive.com>
7928
7929         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7930
7931 2019-01-02  Tom Tromey  <tom@tromey.com>
7932
7933         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7934         (tdesc_parse_xml): Remove cleanups.
7935         * target-descriptions.h (make_cleanup_free_target_description):
7936         Don't declare.
7937         (target_desc_deleter): New struct.
7938         (target_desc_up): New typedef.
7939         * target-descriptions.c (target_desc_deleter::operator()): Rename
7940         from free_target_description.
7941         (make_cleanup_free_target_description): Remove.
7942
7943 2019-01-02  Tom Tromey  <tom@tromey.com>
7944
7945         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7946         constructor, destructor.
7947         (linespec_parser): Remove typedef.
7948         (~linespec_parser): Rename from linespec_parser_delete.
7949         (linespec_lex_to_end, linespec_complete_label)
7950         (linespec_complete): Update.
7951         (decode_line_full): Remove cleanups.
7952         (decode_line_1): Update.
7953
7954 2019-01-02  Tom Tromey  <tom@tromey.com>
7955
7956         * python/python-internal.h (inferior_to_inferior_object): Change
7957         return type.
7958         * python/py-exitedevent.c (create_exited_event_object): Update.
7959         * python/py-inferior.c (inferior_to_inferior_object): Return
7960         gdbpy_ref.
7961         (python_new_inferior, python_inferior_deleted)
7962         (thread_to_thread_object, delete_thread_object)
7963         (build_inferior_list, gdbpy_selected_inferior): Update.
7964         * python/py-infthread.c (create_thread_object): Update.  Also fail
7965         if inferior_to_inferior_object fails.
7966
7967 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7968
7969         * inferior.h (class inferior) <displaced_step_state>: New field.
7970         * infrun.h (struct displaced_step_state): Move here from
7971         infrun.c.  Initialize fields, add constructor.
7972         <inf>: Remove field.
7973         <reset>: New method.
7974         * infrun.c (struct displaced_step_inferior_state): Move to
7975         infrun.h.
7976         (displaced_step_inferior_states): Remove.
7977         (get_displaced_stepping_state): Adust.
7978         (displaced_step_in_progress_any_inferior): Adjust.
7979         (displaced_step_in_progress_thread): Adjust.
7980         (displaced_step_in_progress): Adjust.
7981         (add_displaced_stepping_state): Remove.
7982         (get_displaced_step_closure_by_addr): Adjust.
7983         (remove_displaced_stepping_state): Remove.
7984         (infrun_inferior_exit): Call displaced_step_state.reset.
7985         (use_displaced_stepping): Don't check for NULL.
7986         (displaced_step_prepare_throw): Call
7987         get_displaced_stepping_state.
7988         (displaced_step_fixup): Don't check for NULL.
7989         (prepare_for_detach): Don't check for NULL.
7990
7991 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7992
7993         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7994          in case of call that did not complete.
7995
7996 2019-01-02  Andrey Utkin  <autkin@undo.io>
7997
7998         * symfile.c (find_separate_debug_file): Fix search of debug files for
7999         remote debuggee.
8000
8001 2019-01-02  Tom Tromey  <tom@tromey.com>
8002
8003         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8004         indentation.
8005         * python/py-frame.c (frapy_older): Remove cast.
8006         (frapy_newer): Likewise.
8007         * python/py-breakpoint.c (local_setattro): Remove cast.
8008         * python/py-arch.c (archpy_name): Remove local variable.
8009         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8010
8011 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8012
8013         * unittests/basic_string_view/element_access/char/empty.cc:
8014         Fix year range in copyright header.
8015
8016 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8017
8018         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8019         Delete.
8020         <operator==>: Update with for removed field.
8021         <hash>: Likewise.
8022         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8023         <isa_features>: ...this.
8024         <abi_features>: New field.
8025         (riscv_isa_flen): Update comment.
8026         (riscv_abi_xlen): New declaration.
8027         (riscv_abi_flen): New declaration.
8028         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8029         isa_features.
8030         (riscv_abi_xlen): New function.
8031         (riscv_isa_flen): Update to get answer from isa_features.
8032         (riscv_abi_flen): New function.
8033         (riscv_has_fp_abi): Update to get answer from abi_features.
8034         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8035         xlen and flen.
8036         (riscv_call_info) <xlen, flen>: Update comment.
8037         (riscv_call_arg_struct): Remove invalid assertions
8038         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8039         is removed.
8040         (riscv_gdbarch_init): Gather isa features and abi features
8041         separately, ensure both match on the gdbarch when reusing an old
8042         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8043         a target with 64-bit float hardware.
8044
8045 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8046
8047         * source.c (search_command_helper): Stop reverse search
8048         when line 1 has been searched.
8049
8050 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8051
8052         * record-full.c (record_full_base_target::close): Rewrite
8053         record_full_core_buf_list free logic.
8054
8055 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8056
8057         * break-catch-syscall.c (print_one_catch_syscall): xfree
8058         the last text.
8059
8060 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8061
8062         * top.c (print_gdb_version): Update Copyright year in version
8063         message.
8064
8065 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8066
8067         Update copyright year range in all GDB files.
8068
8069 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8070
8071         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8072
8073 For older changes see ChangeLog-2018.
8074 \f
8075 Local Variables:
8076 mode: change-log
8077 left-margin: 8
8078 fill-column: 74
8079 version-control: never
8080 coding: utf-8
8081 End:
8082