gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-disasm.h (struct tui_disasm_window): Move from
   4         tui-data.h.
   5         * tui/tui-data.h (struct tui_disasm_window): Move to
   6         tui-disasm.h.
   7
   8 2019-07-17  Tom Tromey  <tom@tromey.com>
   9
  10         * tui/tui-regs.h (struct tui_data_item_window): Move from
  11         tui-data.h.
  12         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
  13         * tui/tui-data.h (struct tui_data_item_window): Move to
  14         tui-regs.h.
  15         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
  16
  17 2019-07-17  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui.c: Update.
  20         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
  21         (tui_cmd_window::max_height): Move to tui-command.c.
  22         * tui/tui-layout.c: Update.
  23         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
  24         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
  25         tui-command.c.
  26         * tui/tui-command.h (struct tui_cmd_window): Move from
  27         tui-data.h.
  28         * tui/tui-command.c: Remove "structuring" comments.
  29         (tui_cmd_window::clear_detail)
  30         (tui_cmd_window::do_make_visible_with_new_height)
  31         (tui_cmd_window::max_height): Move from elsewhere.
  32
  33 2019-07-17  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
  36         Now static.
  37         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
  38         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
  39
  40 2019-07-17  Tom Tromey  <tom@tromey.com>
  41
  42         * tui/tui.c: Update.
  43         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
  44         tui-regs.c.
  45         * tui/tui-windata.h: Remove file.
  46         * tui/tui-windata.c: Remove file.
  47         * tui/tui-win.c (tui_data_window::set_new_height)
  48         (tui_data_window::do_make_visible_with_new_height): Move to
  49         tui-regs.c.
  50         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
  51         * tui/tui-regs.c: Remove "structuring" comments.
  52         (tui_data_window::first_data_item_displayed)
  53         (tui_data_window::delete_data_content_windows)
  54         (tui_data_window::erase_data_content)
  55         (tui_data_window::display_all_data)
  56         (tui_data_window::refresh_all)
  57         (tui_data_window::do_scroll_vertical)
  58         (tui_data_window::clear_detail, tui_data_window::set_new_height)
  59         (tui_data_window::do_make_visible_with_new_height)
  60         (tui_data_window::refresh_window): Move from elsewhere.
  61         (_initialize_tui_regs): Move to end of file.
  62         * tui/tui-layout.c: Update.
  63         * tui/tui-hooks.c: Update.
  64         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
  65         * tui/tui-data.c (tui_data_window::clear_detail): Move to
  66         tui-regs.c.
  67         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
  68
  69 2019-07-17  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
  72         seen.
  73
  74 2019-07-17  Tom Tromey  <tom@tromey.com>
  75
  76         * tui/tui-win.c (tui_source_window_base::set_new_height)
  77         (tui_source_window_base::do_make_visible_with_new_height): Use
  78         m_has_locator field directly.
  79         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
  80         method.
  81         (struct tui_source_window_base) <has_locator>: Likewise.
  82
  83 2019-07-17  Tom Tromey  <tom@tromey.com>
  84
  85         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
  86         Don't declare.
  87         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
  88         Remove.
  89         * tui/tui-win.c (tui_source_window_base::set_new_height)
  90         (tui_source_window_base::set_new_height)
  91         (make_invisible_and_set_new_height)
  92         (tui_source_window_base::do_make_visible_with_new_height)
  93         (tui_source_window_base::do_make_visible_with_new_height):
  94         Update.
  95         * tui/tui-layout.c (show_source_disasm_command, show_data)
  96         (show_source_or_disasm_and_command): Update.
  97         * tui/tui-layout.c (show_layout): Update.
  98
  99 2019-07-17  Tom Tromey  <tom@tromey.com>
 100
 101         * tui/tui-layout.c (make_data_window): Remove.
 102         (show_data): Unify creation and re-initialization cases.
 103
 104 2019-07-17  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-layout.c (make_source_window, make_disasm_window):
 107         Remove.
 108         (show_data): Unify creation and re-initialization cases.
 109
 110 2019-07-17  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-layout.c (make_command_window): Remove.
 113         (show_source_disasm_command, show_source_or_disasm_and_command):
 114         Unify creation and re-initialization cases.
 115
 116 2019-07-17  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 119         creation and re-initialization cases.
 120
 121 2019-07-17  Tom Tromey  <tom@tromey.com>
 122
 123         * tui/tui-regs.c (tui_get_register): Return void.
 124
 125 2019-07-17  Tom Tromey  <tom@tromey.com>
 126
 127         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 128         Simplify.
 129
 130 2019-07-17  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 133         resetting.
 134
 135 2019-07-17  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 138         * tui/tui-regs.c (tui_reg_layout): New function.
 139         (tui_show_registers, tui_reg_command): Use it.
 140         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 141         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 142         parameters.
 143         (tui_layout_command): Remove.
 144
 145 2019-07-17  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui-layout.h (tui/tui-layout): Return void.
 148         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 149
 150 2019-07-17  Tom Tromey  <tom@tromey.com>
 151
 152         * tui/tui-layout.c (show_source_disasm_command, show_data):
 153         Update.
 154         (reset_locator): Remove.
 155         (show_source_or_disasm_and_command): Update.
 156
 157 2019-07-17  Tom Tromey  <tom@tromey.com>
 158
 159         * tui/tui-source.c (tui_source_window_base::reset): Remove
 160         win_type parameter.
 161         * tui/tui-layout.c (make_command_window, make_source_window)
 162         (make_disasm_window, make_data_window)
 163         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 164         (reset_locator, show_source_or_disasm_and_command): Update.
 165         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 166         win_type parameter.
 167         (struct tui_source_window_base) <reset>: Likewise.
 168
 169 2019-07-17  Tom Tromey  <tom@tromey.com>
 170
 171         * tui/tui-layout.c (show_source_disasm_command): Use
 172         reset_locator.
 173         (reset_locator): New function.
 174         (init_and_make_win): Remove.
 175         (show_source_or_disasm_and_command): Use reset_locator.
 176
 177 2019-07-17  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 180         condition.
 181         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 182         Remove condition.
 183         * tui/tui-source.c (tui_source_window_base::reset): New method.
 184         * tui/tui-layout.c (make_command_window): Don't call
 185         init_and_make_win.
 186         (make_source_window, make_disasm_window): Don't call
 187         make_source_or_disasm_window.
 188         (make_data_window): Don't call init_and_make_win.  Change calling
 189         convention.
 190         (show_source_disasm_command, show_data): Simplify.
 191         (make_source_or_disasm_window): Remove.
 192         (show_source_or_disasm_and_command): Simplify.
 193         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 194         (struct tui_source_window_base) <reset>: Likewise.
 195         <execution_info>: Remove initializer.
 196         * tui/tui-data.c (tui_source_window_base): Initialize
 197         execution_info.
 198
 199 2019-07-17  Tom Tromey  <tom@tromey.com>
 200
 201         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 202         variable.
 203
 204 2019-07-17  Tom Tromey  <tom@tromey.com>
 205
 206         * tui/tui.c (tui_rl_other_window): Update.
 207         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 208         superclass method first.  Always iterate over regs_content.
 209         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 210         method.
 211         * tui/tui-win.c (tui_set_focus_command): Update.
 212
 213 2019-07-17  Tom Tromey  <tom@tromey.com>
 214
 215         * tui/tui-win.c (tui_set_focus_command): Rename from
 216         tui_set_focus.  Call tui_enable.
 217         (tui_set_focus_command): Remove.
 218
 219 2019-07-17  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 222         refresh_window.
 223         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 224         touchwin.
 225         (tui_data_window::refresh_window): Call refresh_window on data
 226         items.  Always call superclass refresh_window.
 227         (tui_win_info::refresh): Remove.
 228         (tui_source_window_base::refresh_window): Update.
 229         (tui_refresh_all): Update.
 230         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 231         refresh_window.
 232         (show_source_or_disasm_and_command): Likewise.
 233         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 234         (struct tui_source_window_base) <refresh>: Likewise.
 235
 236 2019-07-17  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-winsource.c (tui_clear_source_content)
 239         (tui_show_source_content): Update.
 240         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 241         whether content is empty.
 242         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 243         Remove.
 244
 245 2019-07-17  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 248         window's contents.
 249         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 250         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 251
 252 2019-07-17  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 255         (struct tui_data_item_window): Update.
 256
 257 2019-07-17  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 260         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 261         defines.
 262
 263 2019-07-17  Tom Tromey  <tom@tromey.com>
 264
 265         * tui/tui-winsource.h (tui_erase_source_content)
 266         (tui_clear_source_content): Remove "display_prompt" parameter.
 267         * tui/tui-winsource.c (tui_update_source_window_as_is)
 268         (tui_update_source_windows_with_addr): Update.
 269         (tui_clear_source_content): Remove "display_prompt" parameter.
 270         (tui_erase_source_content): Likewise.  Simplify.
 271         (tui_show_source_content): Update.
 272         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 273         * tui/tui-stack.c (tui_show_frame_info): Update.
 274         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 275         Remove defines.
 276
 277 2019-07-17  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 280         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 281         parameter.
 282         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 283         parameter.
 284
 285 2019-07-17  Tom Tromey  <tom@tromey.com>
 286
 287         * tui/tui-winsource.c (tui_clear_source_content)
 288         (tui_show_source_content, tui_show_exec_info_content)
 289         (tui_clear_exec_info_content): Update.
 290         * tui/tui-stack.c (tui_show_locator_content): Update.
 291         (tui_show_frame_info): Update.
 292         * tui/tui-source.h (tui_source_window): Don't declare.
 293         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 294         from tui_source_is_displayed.
 295         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 296         Remove field.
 297         (struct tui_source_window_base) <content_in_use>: New field.  Now
 298         bool.
 299         (struct tui_source_window) <showing_source_p>: New method.
 300         (TUI_SRC_WIN): Change cast.
 301         * tui/tui-data.c (tui_initialize_static_data): Update.
 302
 303 2019-07-17  Tom Tromey  <tom@tromey.com>
 304
 305         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 306         location_matches_p.
 307         * tui/tui-source.c (tui_source_window::location_matches_p): New
 308         method.
 309         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 310         method.
 311         * tui/tui-data.h (struct tui_source_window_base)
 312         <location_matches_p>: New method.
 313         (struct tui_source_window, struct tui_disasm_window)
 314         <location_matches_p>: Likewise.
 315
 316 2019-07-17  Tom Tromey  <tom@tromey.com>
 317
 318         * tui/tui-win.c (tui_set_win_height_command): Rename from
 319         tui_set_win_height.
 320         (tui_set_win_height_command): Remove.
 321
 322 2019-07-17  Tom Tromey  <tom@tromey.com>
 323
 324         * tui/tui-source.c (tui_source_window): New constructor.  Add
 325         observer.
 326         (~tui_source_window): New destructor.
 327         (tui_source_window::style_changed): New method.
 328         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 329         (tui_attach_detach_observers): Update.
 330         * tui/tui-data.h (struct tui_source_window): Make constructor not
 331         inline.  Add destructor.
 332         (struct tui_source_window) <style_changed>: New method.
 333         <m_observable>: New member.
 334
 335 2019-07-17  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 338         * tui/tui-win.c (tui_resize_all): Fix typo.
 339
 340 2019-07-17  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 343         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 344         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 345         * tui/tui-win.c (window_name_completer): Use foreach.
 346         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 347         (update_tab_width): Likewise.
 348         * tui/tui-layout.c (show_layout): Update.
 349         * tui/tui-data.h (class tui_window_iterator): New.
 350         (struct all_tui_windows): New.
 351         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 352
 353 2019-07-17  Tom Tromey  <tom@tromey.com>
 354
 355         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 356         parameter.  Don't reference globals.
 357         (tui_reg_command): Update.
 358
 359 2019-07-17  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-regs.c (tui_show_registers): Simplify.
 362
 363 2019-07-17  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-regs.c (tui_show_registers): Update.
 366         (tui_show_register_group): Add win_info parameter.
 367
 368 2019-07-17  Tom Tromey  <tom@tromey.com>
 369
 370         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 371         Rename from tui_display_reg_element_at_line.
 372         (tui_data_window::display_registers_from_line): Update.
 373         * tui/tui-data.h (struct tui_data_window)
 374         <display_reg_element_at_line>: New method.
 375
 376 2019-07-17  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-regs.h (tui_display_registers_from)
 379         (tui_display_registers_from_line): Don't declare.
 380         * tui/tui-windata.c (tui_data_window::display_all_data)
 381         (tui_data_window::refresh_all)
 382         (tui_data_window::do_scroll_vertical): Update.
 383         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 384         from tui_display_registers_from.
 385         (tui_display_reg_element_at_line): Update.
 386         (tui_data_window::display_registers_from_line): Rename from
 387         tui_display_registers_from_line.
 388         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 389         display_registers_from_line>: New methods.
 390
 391 2019-07-17  Tom Tromey  <tom@tromey.com>
 392
 393         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 394         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 395         from tui_erase_data_content.
 396         (tui_data_window::display_all_data)
 397         (tui_data_window::refresh_all)
 398         (tui_data_window::do_scroll_vertical): Update.
 399         * tui/tui-regs.c (tui_show_registers): Update.
 400         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 401         New method.
 402
 403 2019-07-17  Tom Tromey  <tom@tromey.com>
 404
 405         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 406         declare.
 407         * tui/tui-windata.c
 408         (tui_data_window::delete_data_content_windows): Rename from
 409         tui_delete_data_content_windows.
 410         (tui_data_window::display_all_data)
 411         (tui_data_window::do_scroll_vertical): Update.
 412         * tui/tui-data.h (struct tui_data_window)
 413         <delete_data_content_windows>: New method.
 414
 415 2019-07-17  Tom Tromey  <tom@tromey.com>
 416
 417         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 418         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 419
 420 2019-07-17  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 423         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 424         from tui_display_all_data.
 425         * tui/tui-win.c
 426         (tui_data_window::do_make_visible_with_new_height): Update.
 427         * tui/tui-regs.c (tui_show_registers): Update.
 428         * tui/tui-layout.c (tui_set_layout): Update.
 429         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 430         method.
 431
 432 2019-07-17  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 435         * tui/tui-windata.c (tui_display_data_from): Remove.
 436         (tui_data_window::refresh_all): Update.
 437
 438 2019-07-17  Tom Tromey  <tom@tromey.com>
 439
 440         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 441         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 442         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 443         tui_display_registers_from_line.
 444         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 445         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 446         "force_display" parameter.
 447
 448 2019-07-17  Tom Tromey  <tom@tromey.com>
 449
 450         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 451         declare.
 452         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 453         Rename from tui_first_reg_element_no_inline.
 454         (tui_display_reg_element_at_line)
 455         (tui_display_registers_from_line): Update.
 456         * tui/tui-data.h (struct tui_data_window)
 457         <first_reg_element_no_inline>: New method.
 458
 459 2019-07-17  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-windata.c (tui_display_data_from)
 462         (tui_data_window::do_scroll_vertical): Update.
 463         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 464         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 465         Rename from tui_line_from_reg_element_no.
 466         (tui_display_registers_from_line): Update.
 467         * tui/tui-data.h (struct tui_data_window)
 468         <line_from_reg_element_no>: New method.
 469
 470 2019-07-17  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 473         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 474         tui_last_regs_line_no.
 475         (tui_display_reg_element_at_line)
 476         (tui_display_registers_from_line): Update.
 477         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 478         method.
 479
 480 2019-07-17  Tom Tromey  <tom@tromey.com>
 481
 482         PR tui/24722:
 483         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 484         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 485         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 486         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 487         (tui_update_breakpoint_info): Likewise.
 488         * tui/tui-hooks.c (tui_event_create_breakpoint)
 489         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 490         Update.
 491
 492 2019-07-17  Tom Tromey  <tom@tromey.com>
 493
 494         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 495
 496 2019-07-17  Tom Tromey  <tom@tromey.com>
 497
 498         * tui/tui-winsource.c (tui_update_source_window_as_is)
 499         (tui_update_source_windows_with_addr): Update.
 500         * tui/tui-source.h (tui_set_source_content)
 501         (tui_show_symtab_source): Add "win_info" parameter.
 502         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 503         parameter.
 504         (tui_show_symtab_source): Likewise.
 505
 506 2019-07-17  Tom Tromey  <tom@tromey.com>
 507
 508         * tui/tui-wingeneral.c
 509         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 510
 511 2019-07-17  Tom Tromey  <tom@tromey.com>
 512
 513         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 514         (struct tui_cmd_window) <can_scroll>: New method.
 515         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 516         method.
 517
 518 2019-07-17  Tom Tromey  <tromey@adacore.com>
 519
 520         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 521         do_field_signed>: Rename.  Change type of "value".
 522         * ui-out.c (ui_out::field_signed): Rename from field_int.
 523         Change type of "value".
 524         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 525         type of "value".
 526         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 527         do_field_int.  Change type of "value".
 528         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 529         do_field_int.  Change type of "value".
 530         * tracepoint.c (trace_status_mi, tfind_1)
 531         (print_one_static_tracepoint_marker): Update.
 532         * thread.c (print_thread_info_1, print_selected_thread_frame):
 533         Update.
 534         * stack.c (print_frame, print_frame_info): Update.
 535         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 536         Update.
 537         * source.c (print_source_lines_base): Update.
 538         * skip.c (info_skip_command): Update.
 539         * record-btrace.c (btrace_ui_out_decode_error)
 540         (btrace_call_history_src_line): Update.
 541         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 542         Update.
 543         * progspace.c (print_program_space): Update.
 544         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 545         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 546         do_field_int.  Change type of "value".
 547         * mi/mi-out.c (mi_ui_out::do_table_begin)
 548         (mi_ui_out::do_table_header): Update.
 549         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 550         type of "value".
 551         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 552         (mi_cmd_data_list_changed_registers, output_register)
 553         (mi_cmd_data_read_memory, mi_load_progress)
 554         (mi_cmd_trace_frame_collected): Update.
 555         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 556         Update.
 557         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 558         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 559         (mi_cmd_var_list_children, varobj_update_one): Update.
 560         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 561         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 562         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 563         * inferior.c (print_inferior): Update.
 564         * gdb_bfd.c (print_one_bfd): Update.
 565         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 566         Update.
 567         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 568         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 569         do_field_int.  Change type of "value".
 570         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 571         do_field_int.  Change type of "value".
 572         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 573         (print_one_breakpoint_location, print_it_catch_fork)
 574         (print_one_catch_fork, print_it_catch_vfork)
 575         (print_one_catch_vfork, print_it_catch_solib)
 576         (print_it_catch_exec, print_it_ranged_breakpoint)
 577         (print_mention_watchpoint, print_mention_masked_watchpoint)
 578         (bkpt_print_it, update_static_tracepoint): Update.
 579         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 580         * break-catch-syscall.c (print_it_catch_syscall): Update.
 581         * ada-tasks.c (print_ada_task_info): Update.
 582         * ada-lang.c (print_it_exception, print_mention_exception):
 583         Update.
 584
 585 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 586
 587         PR breakpoints/24541
 588         * gdbarch.c: Regenerate.
 589         * gdbarch.h: Regenerate.
 590         * gdbarch.sh: Adjust return type and parameter types for
 591         'stap_adjust_register'.
 592         (i386_stap_adjust_register): Adjust signature and return new
 593         register name.
 594         * stap-probe.c (stap_parse_register_operand): Adjust use of
 595         'gdbarch_stap_adjust_register'.
 596
 597 2019-07-17  Tom Tromey  <tromey@adacore.com>
 598
 599         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 600         declare VEC.
 601         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 602         std::vector.
 603         (struct s390_process_info): Add initializers.
 604         (s390_add_process): Use new.
 605         (s390_linux_nat_target::low_forget_process): Use delete.
 606         (s390_linux_nat_target::low_new_fork)
 607         (s390_linux_nat_target::stopped_by_watchpoint)
 608         (s390_linux_nat_target::low_prepare_to_resume)
 609         (s390_linux_nat_target::insert_watchpoint)
 610         (s390_linux_nat_target::insert_hw_breakpoint)
 611         (s390_linux_nat_target::remove_watchpoint)
 612         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 613
 614 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 615
 616         * aarch64-fbsd-nat.c: Include regcache.h.
 617         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 618         argument.
 619         (aarch64_fbsd_nat_target::fetch_registers)
 620         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 621         variable.
 622         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 623
 624 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 625
 626         * fbsd-nat.c: Include gdbarch.h.
 627
 628 2019-07-15  Tom Tromey  <tromey@adacore.com>
 629
 630         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 631
 632 2019-07-15  Tom Tromey  <tromey@adacore.com>
 633
 634         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 635         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 636         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 637         * cli-out.c (cli_ui_out::do_field_int): New method.
 638         * ui-out.c (ui_out::field_unsigned): New method.
 639         * symfile.c (generic_load): Use field_unsigned.
 640         (print_transfer_performance): Likewise.
 641         * record-btrace.c (ui_out_field_uint): Remove.
 642         (btrace_call_history_insn_range, btrace_call_history): Use
 643         field_unsigned.
 644         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 645         field_unsigned.
 646         * ui-out.h (class ui_out) <field_unsigned>: New method.
 647         <do_field_unsigned>: Likewise.
 648
 649 2019-07-15  Tom Tromey  <tromey@adacore.com>
 650
 651         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 652         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 653         * target.c (flash_erase_command): Use field_string.
 654         * infrun.c (print_signal_received_reason): Use field_string.
 655         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 656         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 657         field_string.
 658         * ada-tasks.c (print_ada_task_info): Use field_string.
 659
 660 2019-07-15  Tom Tromey  <tromey@adacore.com>
 661
 662         * target.c (flash_erase_command): Use field_core_addr.
 663         * symfile.c (generic_load): Use field_core_addr.
 664         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 665         Use field_core_addr.
 666         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 667         field_core_addr.
 668
 669 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 670
 671         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 672         value if its desired type is smaller than a CORE_ADDR and signed.
 673
 674 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 675
 676         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 677         of changes to field names, and use new is_reference field to
 678         decide if a property is a reference or not.
 679         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 680         field.
 681         (struct dwarf2_property_baton): Update header comment, rename
 682         'referenced_type' to 'property_type' and update comments.
 683         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 684         default property type, store in property baton, update to take
 685         accound of renamed field.
 686         (read_func_scope): Update call to attr_to_dynamic_prop.
 687         (read_array_type): Likewise.
 688         (dwarf2_per_cu_addr_sized_int_type): New function.
 689         (read_subrange_index_type): Move type finding code to
 690         dwarf2_per_cu_addr_sized_int_type.
 691         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 692         (dwarf2_per_cu_addr_type): New function.
 693         (set_die_type): Update calls to attr_to_dynamic_prop.
 694
 695 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 696
 697         * dwarf2read.c (read_subrange_index_type): New function.
 698         (read_subrange_type): Move code into new function and call it.
 699         * gdbtypes.c (create_range_type): Add some asserts.
 700
 701 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 702
 703         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 704         update return statements.
 705         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 706         declaration, and update comment to match.
 707         * gdbtypes.c (resolve_dynamic_array): Update call to
 708         dwarf2_evaluate_property to match new return type.
 709
 710 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 711
 712         * valarith.c (value_subscripted_rvalue): Change lowerbound
 713         parameter type from int to LONGEST.
 714         * value.h (value_subscripted_rvalue): Likewise in declaration.
 715
 716 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 717
 718         * cli/cli-utils.c (info_print_command_completer): New function.
 719         * cli/cli-utils.h: Add 'completer.h' include, and forward
 720         declaration for 'struct cmd_list_element'.
 721         (info_print_command_completer): Declare.
 722         * stack.c (_initialize_stack): Add completer for 'info locals' and
 723         'info args'.
 724         * symtab.c (_initialize_symtab): Add completer for 'info
 725         variables' and 'info functions'.
 726         * NEWS: Mention completion for additional info commands.
 727
 728 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 729
 730         * cli/cli-utils.c (extract_info_print_args): Delete.
 731         (extract_arg_maybe_quoted): Delete.
 732         (info_print_options_defs): New variable.
 733         (make_info_print_options_def_group): New function.
 734         (extract_info_print_options): Define new function.
 735         * cli/cli-utils.h (extract_info_print_args): Delete.
 736         (struct info_print_options): New structure.
 737         (extract_info_print_options): Declare new function.
 738         * stack.c (info_locals_command): Update to use new
 739         extract_info_print_options, also add a header comment.
 740         (info_args_command): Likewise.
 741         * symtab.c (info_variables_command): Likewise.
 742         (info_functions_command): Likewise.
 743
 744 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 745
 746         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 747         to extract string arguments.
 748         * common/common-utils.c (extract_string_maybe_quoted): New function.
 749         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 750
 751 2019-07-11  Tom Tromey  <tromey@adacore.com>
 752
 753         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 754         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 755         * top.h (gdbinit): Don't declare.
 756         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 757         into...
 758         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 759         * top.c (gdb_init): Don't call init_cli_cmds.
 760         (gdbinit): Remove.
 761         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 762
 763 2019-07-11  Tom Tromey  <tromey@adacore.com>
 764
 765         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 766         after it has been moved.
 767
 768 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 769
 770         * valops.c (value_must_coerce_to_target): Change return type to
 771         bool.
 772         * value.h (value_must_coerce_to_target): Likewise.
 773
 774 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 775
 776         * breakpoint.c (is_hardware_watchpoint): Remove
 777         forward-declaration.
 778         (is_masked_watchpoint): Change return type to bool.
 779         (is_tracepoint): Likewise.
 780         (is_breakpoint): Likewise.
 781         (is_hardware_watchpoint): Likewise.
 782         (is_watchpoint): Likewise.
 783         (is_no_memory_software_watchpoint): Likewise.
 784         (is_catchpoint): Likewise.
 785         (breakpoint_1): Make FILTER parameter's return type bool.
 786         is_masked_watchpoint): Change return type to bool.
 787         (save_breakpoints): Make FILTER parameter's return type bool.
 788         * breakpoint.h (is_breakpoint): Change return type to bool.
 789         (is_watchpoint): Likewise.
 790         (is_catchpoint): Likewise.
 791         (is_tracepoint): Likewise.
 792
 793 2019-07-10  Tom Tromey  <tom@tromey.com>
 794
 795         * defs.h: Don't include gdbarch.h.
 796         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 797         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 798         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 799         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 800         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 801         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 802         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 803         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 804         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 805         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 806         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 807         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 808         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 809         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 810         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 811         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 812         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 813         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 814         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 815         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 816         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 817         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 818         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 819         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 820         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 821         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 822         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 823
 824 2019-07-10  Tom Tromey  <tromey@adacore.com>
 825
 826         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 827         * breakpoint.c (init_ada_exception_breakpoint): Register as
 828         bp_catchpoint.
 829         (print_one_breakpoint_location, print_one_breakpoint): Use
 830         is_ada_exception_catchpoint.
 831         * ada-lang.c (class ada_catchpoint_location): Pass
 832         bp_loc_software_breakpoint to bp_location constructor.
 833         (is_ada_exception_catchpoint): New function.
 834
 835 2019-07-10  Tom Tromey  <tromey@adacore.com>
 836
 837         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 838         VEC.
 839         (struct arm_exidx_entry): New method operator<.
 840         (struct arm_exidx_data) <section_maps>: Change type.
 841         (arm_exidx_data_free): Remove.
 842         (arm_exidx_data_key): Change type.  Move lower.
 843         (arm_exidx_new_objfile): Update.
 844         (arm_compare_exidx_entries): Remove.
 845         (arm_find_exidx_entry, _initialize_arm_tdep)
 846
 847 2019-07-10  Tom Tromey  <tromey@adacore.com>
 848
 849         * solib-spu.c (ocl_program_data_key): Change type.
 850         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 851         Update.
 852
 853 2019-07-10  Tom Tromey  <tromey@adacore.com>
 854
 855         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 856         (struct solib_aix_inferior_data) <library_list>: Change type.
 857         (solib_aix_inferior_data_handle): Change type.
 858         (get_solib_aix_inferior_data): Update.
 859         (solib_aix_free_library_list): Remove.
 860         (library_list_start_library): Update.
 861         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 862         return type.
 863         (solib_aix_get_library_list)
 864         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 865         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 866
 867 2019-07-10  Tom Tromey  <tromey@adacore.com>
 868
 869         * solib-dsbt.c (struct dsbt_info): Add initializers.
 870         (solib_dsbt_pspace_data): Change type.
 871         (dsbt_pspace_data_cleanup): Remove.
 872         (get_dsbt_info, _initialize_dsbt_solib): Update.
 873
 874 2019-07-10  Tom Tromey  <tromey@adacore.com>
 875
 876         * spu-tdep.c (spu_overlay_data): Change type.
 877         (spu_get_overlay_table, spu_overlay_new_objfile)
 878         (_initialize_spu_tdep): Update.
 879
 880 2019-07-10  Tom Tromey  <tromey@adacore.com>
 881
 882         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 883         destructor.
 884         (dbx_objfile_data_key): Change type and declare later.
 885         (DBX_SYMFILE_INFO): Rewrite.
 886         * dbxread.c (dbx_objfile_data_key): Change type.
 887         (dbx_symfile_init): Update.
 888         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 889         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 890         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 891
 892 2019-07-10  Tom Tromey  <tromey@adacore.com>
 893
 894         * jit.c (jit_program_space_key): Change type.  Move lower.
 895         (get_jit_program_space_data): Update.
 896         (jit_program_space_data_cleanup): Remove.
 897         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 898         Update.
 899         (struct jit_program_space_data): Add initializers.
 900
 901 2019-07-10  Tom Tromey  <tromey@adacore.com>
 902
 903         * solib-darwin.c (struct darwin_info): Add initializers.
 904         (solib_darwin_pspace_data): Change type.
 905         (darwin_pspace_data_cleanup): Remove.
 906         (get_darwin_info, _initialize_darwin_solib): Update.
 907
 908 2019-07-10  Tom Tromey  <tromey@adacore.com>
 909
 910         * remote-sim.c (struct sim_inferior_data): Add initializers,
 911         constructor, and destructor.
 912         (sim_inferior_data_key): Change type.  Move lower.
 913         (check_for_duplicate_sim_descriptor): Update.
 914         (get_sim_inferior_data): Use new.  Update.
 915         (~sim_inferior_data_cleanup): Rename from
 916         sim_inferior_data_cleanup.  Simplify.
 917         (gdbsim_close_inferior, simulator_command)
 918         (sim_command_completer, _initialize_remote_sim): Update.
 919         (next_pid, INITIAL_PID): Move earlier.
 920
 921 2019-07-10  Tom Tromey  <tromey@adacore.com>
 922
 923         * python/python-internal.h (create_thread_object): Return
 924         gdbpy_ref.
 925         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 926         * python/py-inferior.c (struct threadlist_entry): Add
 927         constructor.
 928         <thread_obj>: Now a gdbpy_ref.
 929         (thread_to_thread_object): Update.
 930         (add_thread_object): Use new.
 931         (delete_thread_object): Use delete.
 932         (infpy_threads): Update.
 933         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 934         GIL.
 935
 936 2019-07-10  Tom Tromey  <tromey@adacore.com>
 937
 938         * valops.c (value_cast): Specialize error message for Ada.
 939
 940 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 941
 942         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 943
 944 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 945
 946         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 947         bpstat_should_step): Return bool, adjust comments.
 948         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 949         bpstat_should_step): Likewise.
 950
 951 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 952
 953         * features/Makefile: Use feature target descriptions for Arm.
 954         * features/arm/arm-core.c: Generate new file.
 955         * features/arm/arm-fpa.c: Likewise.
 956         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 957         * features/arm/arm-m-profile.c: Likewise.
 958         * features/arm/arm-vfpv2.c: Likewise.
 959         * features/arm/arm-vfpv3.c: Likewise.
 960         * features/arm/xscale-iwmmxt.c: Likewise.
 961         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 962
 963 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 964
 965         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 966         ptrace earlier.
 967
 968 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 969
 970         * features/aarch64-pauth.c: Regenerate.
 971
 972 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 973
 974         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 975         bool.
 976         (bpstat_what): Use false instead of 0.
 977
 978 2019-07-09  Pedro Alves  <palves@redhat.com>
 979
 980         * break-catch-throw.c (is_exception_catchpoint): New.
 981         * breakpoint.c (print_one_breakpoint_location): New parameter
 982         'raw_loc'.  Handle it.  Use
 983         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 984         looking at the breakpoint's type.
 985         (print_one_breakpoint): If handling "maint info breakpoints", also
 986         print locations of exception catchpoints.
 987         * breakpoint.h (is_exception_catchpoint): Declare.
 988
 989 2019-07-09  Pedro Alves  <palves@redhat.com>
 990
 991         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 992         "addr" field.
 993         (allocate_location_exception_catchpoint): New.
 994         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 995         (initialize_throw_catchpoint_ops): Install
 996         allocate_location_exception_catchpoint as allocate_location
 997         method.
 998         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 999         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1000         bp_loc_other.
1001         (breakpoint_address_is_meaningful): Delete.
1002         (bl_address_is_meaningful): New.
1003         (breakpoint_locations_match): Adjust comment.
1004         (bp_location_from_bp_type): New, factored out of...
1005         (bp_location::bp_location(breakpoint *)): ... this.
1006         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1007         factored out of...
1008         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1009         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1010         breakpoint_address_is_meaningful.
1011         (bp_locations_compare): Adjust comment.
1012         (update_global_location_list): Use bl_address_is_meaningful
1013         instead of breakpoint_address_is_meaningful.
1014         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1015         explicit.
1016         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1017         * python/py-breakpoint.c (bppy_get_location): No longer check
1018         whether location is null.
1019
1020 2019-07-09  Pedro Alves  <palves@redhat.com>
1021
1022         PR c++/15468
1023         * breakpoint.c (print_one_breakpoint_location): Remove
1024         single-location assert.
1025
1026 2019-07-09  Tom Tromey  <tom@tromey.com>
1027
1028         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1029         * configure: Rebuild.
1030         * configure.ac: Change common to gdbsupport.
1031         * gdbsupport: Rename from common.
1032         * acinclude.m4: Change common to gdbsupport.
1033         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1034         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1035         gdbsupport.
1036         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1037         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1038         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1039         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1040         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1041         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1042         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1043         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1044         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1045         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1046         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1047         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1048         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1049         coff-pe-read.c, command.h, compile/compile-c-support.c,
1050         compile/compile-c.h, compile/compile-cplus-symbols.c,
1051         compile/compile-cplus-types.c, compile/compile-cplus.h,
1052         compile/compile-loc2c.c, compile/compile.c, completer.c,
1053         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1054         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1055         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1056         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1057         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1058         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1059         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1060         features/aarch64-core.c, features/aarch64-fpu.c,
1061         features/aarch64-pauth.c, features/aarch64-sve.c,
1062         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1063         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1064         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1065         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1066         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1067         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1068         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1069         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1070         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1071         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1072         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1073         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1074         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1075         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1076         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1077         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1078         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1079         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1080         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1081         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1082         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1083         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1084         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1085         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1086         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1087         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1088         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1089         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1090         minsyms.c, mips-linux-tdep.c, namespace.h,
1091         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1092         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1093         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1094         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1095         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1096         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1097         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1098         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1099         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1100         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1101         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1102         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1103         procfs.c, producer.c, progspace.h, psymtab.h,
1104         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1105         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1106         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1107         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1108         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1109         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1110         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1111         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1112         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1113         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1114         target-memory.c, target.c, target.h, target/waitstatus.c,
1115         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1116         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1117         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1118         unittests/array-view-selftests.c,
1119         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1120         unittests/common-utils-selftests.c,
1121         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1122         unittests/format_pieces-selftests.c,
1123         unittests/function-view-selftests.c,
1124         unittests/lookup_name_info-selftests.c,
1125         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1126         unittests/mkdir-recursive-selftests.c,
1127         unittests/observable-selftests.c,
1128         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1129         unittests/parse-connection-spec-selftests.c,
1130         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1131         unittests/scoped_fd-selftests.c,
1132         unittests/scoped_mmap-selftests.c,
1133         unittests/scoped_restore-selftests.c,
1134         unittests/string_view-selftests.c, unittests/style-selftests.c,
1135         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1136         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1137         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1138         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1139         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1140         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1141
1142 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1143
1144         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1145         bool value.
1146         (decode_digits_ordinary): Set explicit_line field in sal.
1147         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1148         symtab_and_line that was set on an explicit line number in
1149         assembler code.  Do always update the recorded symtab and line if
1150         we do skip the prologue.
1151
1152 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1153
1154         * breakpoint.c (set_breakpoint_location_function): Remove
1155         explicit_loc parameter.
1156         (momentary_breakpoint_from_master): Update call to
1157         set_breakpoint_location_function.
1158         (add_location_to_breakpoint): Likewise.
1159
1160 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1161
1162         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1163         required features based on default bfd type when no specific bfd
1164         is present.
1165
1166 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1167
1168         * NEWS: Mention that GDB printf and eval commands can now print
1169         C-style and Ada-style convenience var strings without
1170         calling the inferior.
1171         * printcmd.c (printf_c_string): Locally print GDB internal var
1172         instead of transiting via the inferior.
1173         (printf_wide_c_string): Likewise.
1174
1175 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1176
1177         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1178
1179 2019-07-04  Tom Tromey  <tom@tromey.com>
1180
1181         PR tui/24724:
1182         * tui/tui-winsource.c (tui_clear_source_content): Update.
1183         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1184         (tui_update_breakpoint_info): Update.
1185         (tui_set_exec_info_content): Update.
1186         * tui/tui-source.c (tui_set_source_content_nil): Update.
1187         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1188         has_break.
1189         * tui/tui-data.h (enum tui_bp_flag): New.
1190         (tui_bp_flags): New enum flags type.
1191         (struct tui_source_element) <break_mode>: Change type.  Rename
1192         from has_break.
1193         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1194         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1195         constants.
1196         * tui/tui-winsource.h: Fix comment.
1197
1198 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1199
1200         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1201         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1202         (store_fpregs_to_thread)
1203         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1204         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1205         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1206         (IWMMXT_REGS_SIZE): Add define.
1207         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1208         (fetch_vfp_regs, store_vfp_regs)
1209         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1210         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1211
1212 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1213
1214         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1215         defines.
1216         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1217         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1218         (ARM_INT_REGISTER_SIZE): ...to this.
1219         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1220         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1221         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1222         (arm_linux_collect_gregset, supply_nwfpe_register)
1223         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1224         defines.
1225         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1226         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1227         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1228         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1229         (arm_return_in_memory, arm_store_return_value)
1230         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1231         (arm_record_ld_st_multiple): Likewise.
1232         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1233         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1234
1235 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1236
1237         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1238         AARCH64_DISPLACED_MODIFIED_INSNS.
1239         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1240         (aarch64_displaced_step_copy_insn): Likewise.
1241         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1242         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1243         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1244         ARM_DISPLACED_MODIFIED_INSNS.
1245         * arm-tdep.c (arm_gdbarch_init): Likewise.
1246         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1247         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1248         (struct arm_displaced_step_closure): Use
1249         ARM_DISPLACED_MODIFIED_INSNS.
1250
1251 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1252
1253         * features/Makefile: Remove unused xml files.
1254         * features/aarch64.xml: Remove.
1255         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1256         * features/i386/amd64-avx-avx512.xml: Remove.
1257         * features/i386/amd64-avx-linux.xml: Remove.
1258         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1259         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1260         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1261         * features/i386/amd64-avx-mpx.xml: Remove.
1262         * features/i386/amd64-avx.xml: Remove.
1263         * features/i386/amd64-linux.xml: Remove.
1264         * features/i386/amd64-mpx-linux.xml: Remove.
1265         * features/i386/amd64-mpx.xml: Remove.
1266         * features/i386/amd64.xml: Remove.
1267         * features/i386/i386-avx-avx512-linux.xml: Remove.
1268         * features/i386/i386-avx-avx512.xml: Remove.
1269         * features/i386/i386-avx-linux.xml: Remove.
1270         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1271         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1272         * features/i386/i386-avx-mpx-linux.xml: Remove.
1273         * features/i386/i386-avx-mpx.xml: Remove.
1274         * features/i386/i386-avx.xml: Remove.
1275         * features/i386/i386-linux.xml: Remove.
1276         * features/i386/i386-mmx-linux.xml: Remove.
1277         * features/i386/i386-mmx.xml: Remove.
1278         * features/i386/i386-mpx-linux.xml: Remove.
1279         * features/i386/i386-mpx.xml: Remove.
1280         * features/i386/i386.xml: Remove.
1281         * features/i386/x32-avx-avx512-linux.xml: Remove.
1282         * features/i386/x32-avx-linux.xml: Remove.
1283         * features/i386/x32-linux.xml: Remove.
1284
1285 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1286
1287         * regformats/aarch64.dat: Remove.
1288         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1289         * regformats/i386/amd64-avx-linux.dat: Remove.
1290         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1291         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1292         * regformats/i386/amd64-linux.dat: Remove.
1293         * regformats/i386/amd64-mpx-linux.dat: Remove.
1294         * regformats/i386/amd64.dat: Remove.
1295         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1296         * regformats/i386/i386-avx-linux.dat: Remove.
1297         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1298         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1299         * regformats/i386/i386-linux.dat: Remove.
1300         * regformats/i386/i386-mmx-linux.dat: Remove.
1301         * regformats/i386/i386-mpx-linux.dat: Remove.
1302         * regformats/i386/i386.dat: Remove.
1303         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1304         * regformats/i386/x32-avx-linux.dat: Remove.
1305         * regformats/i386/x32-linux.dat: Remove.
1306
1307 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1308
1309         * aarch64-tdep.c: Remove xml self tests.
1310         * amd64-linux-tdep.c: Likewise.
1311         * amd64-tdep.c: Likewise.
1312         * i386-linux-tdep.c: Likewise.
1313         * i386-tdep.c: Likewise.
1314
1315 2019-07-03  Pedro Alves  <palves@redhat.com>
1316
1317         PR cli/24732
1318         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1319         (pipe_cmd_option_defs): New.
1320         (make_pipe_cmd_options_def_group): New.
1321         (pipe_command): Use gdb::option::process_options.
1322         (pipe_command_completer): New function.
1323         (_initialize_cli_cmds): Install completer for "pipe" command.
1324
1325 2019-07-03  Pedro Alves  <palves@redhat.com>
1326
1327         * cli/cli-option.c (union option_value) <string>: New field.
1328         (struct option_def_and_value): Add ctor, move ctor, dtor and
1329         use DISABLE_COPY_AND_ASSIGN.
1330         (option_def_and_value::clear_value): New.
1331         (parse_option, save_option_value_in_ctx, get_val_type_str)
1332         (add_setshow_cmds_for_options): Handle var_string.
1333         * cli-option.h (union option_def::var_address) <string>: New
1334         field.
1335         (struct string_option_def): New.
1336         * maint-test-options.c (struct test_options_opts): Add default
1337         ctor and use DISABLE_COPY_AND_ASSIGN.
1338         <string_opt>: New field.
1339         (test_options_opts::~test_options_opts): New.
1340         (test_options_opts::dump): Also dump "-string".
1341         (test_options_option_defs): Install "string.
1342
1343 2019-07-03  Pedro Alves  <palves@redhat.com>
1344
1345         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1346         option_value with a null enumeration.
1347         (complete_options): Save the option values in the context.
1348         (save_option_value_in_ctx): New, factored out from ...
1349         (process_options): ... here.
1350         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1351         of the function.
1352         * maint-test-options.c (test_options_opts::dump): New, factored
1353         out from ...
1354         (maintenance_test_options_command_mode): ... here.
1355         (maintenance_test_options_command_completion_result): Delete.
1356         (maintenance_test_options_command_completion_text): Update
1357         comment.
1358         (maintenance_show_test_options_completion_result): Change
1359         prototype.  Just print
1360         maintenance_test_options_command_completion_text.
1361         (save_completion_result): New.
1362         (maintenance_test_options_completer_mode): Pass options context to
1363         complete_options, and then save a dump.
1364         (_initialize_maint_test_options): Use add_cmd to install "maint
1365         show test-options-completion-result".
1366
1367 2019-07-03  Pedro Alves  <palves@redhat.com>
1368
1369         * NEWS (New commands): Mention "with" and "maint with".
1370         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1371         (with_command, with_command_completer): New.
1372         (pipe_command): Adjust to new repeat_previous
1373         interface.
1374         (_initialize_cli_cmds): Install the "with" command and its "w"
1375         alias.
1376         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1377         declarations.
1378         * cli/cli-setshow.c (parse_cli_var_uinteger)
1379         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1380         argument strings for all var_types.
1381         (get_setshow_command_value_string): New, factored out from ...
1382         (do_show_command): ... this.
1383         * cli/cli-setshow.h: Include <string>.
1384         (get_setshow_command_value_string): Declare.
1385         * command.h (repeat_previous): Now returns const char *.  Adjust
1386         comment.
1387         * maint.c: Include "cli/cli-cmds.h".
1388         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1389         (_initialize_maint_cmds): Register the "maintenance with" command.
1390         * top.c (repeat_previous): Move bits from pipe_command here:
1391         Return the saved command line, if any; error out if there's no
1392         command to relaunch.
1393
1394 2019-07-03  Pedro Alves  <palves@redhat.com>
1395
1396         * NEWS (New commands): Mention "maint set/show test-settings"
1397         instead of "maint test-settings".
1398         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1399         (maintenance_test_settings_set_list): Rename to ...
1400         (maintenance_set_test_settings_list): ... this.
1401         (maintenance_test_settings_show_list): Rename to  ...
1402         (maintenance_show_test_settings_list): ... this.
1403         (maintenance_test_settings_cmd): Delete.
1404         (maintenance_test_settings_set_cmd): ...
1405         (maintenance_set_test_settings_cmd): ... this.
1406         (maintenance_test_settings_show_cmd): ...
1407         (maintenance_show_test_settings_cmd): ... this.
1408         (maintenance_test_settings_show_value_cmd):
1409         (maintenance_show_test_settings_value_cmd): ... this.
1410         (_initialize_maint_test_settings): No longer install the "maint
1411         test-settings" prefix command.  Rename "maint test-settings set"
1412         to "maint set test-settings", and "maint test-settings show" to
1413         "maint show test-settings".  Adjust all subcommands.
1414
1415 2019-07-03  Pedro Alves  <palves@redhat.com>
1416
1417         * maint-test-settings.c: Fix file's intro comment.  Replace all
1418         references to "test-options" with references to "test-settings",
1419         in comments.
1420
1421 2019-07-03  Pedro Alves  <palves@redhat.com>
1422
1423         * maint-test-settings.c (maintenance_test_settings_xxx)
1424         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1425         New.
1426         (maintenance_test_settings_enums): Use them.
1427         (maintenance_test_settings_enum): Default to
1428         maintenance_test_settings_xxx.
1429         (_initialize_maint_test_settings): Initialize
1430         MAINTENANCE_TEST_SETTINGS_FILENAME.
1431
1432 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1433
1434         * breakpoint.h (remove_breakpoints_inf): Change return type to
1435         void, move function documentation here.
1436         * breakpoint.c (remove_breakpoints_inf): Change return type to
1437         void, move function documentation to header.
1438
1439 2019-07-02  Pedro Alves  <palves@redhat.com>
1440
1441         * NEWS (Completion improvements): Mention "info threads".
1442         * thread.c (struct info_threads_opts, info_threads_option_defs)
1443         (make_info_threads_options_def_group): New.
1444         (info_threads_command): Use gdb::option::process_options.
1445         (info_threads_command_completer): New.
1446         (_initialize_thread): Use gdb::option::build_help to build the
1447         help text for "info threads".
1448
1449 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1450
1451         * defs.h (generic_load): Move from here...
1452         * symfile.h (generic_load): ... to here.  Rename name parameter
1453         to args.
1454         * symfile.c (generic_load): Add comment.
1455
1456 2019-07-01  Tom Tromey  <tromey@adacore.com>
1457
1458         * dwarf2read.c
1459         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1460         declaration of without_params.  Fix formatting.
1461
1462 2019-07-01  Tom Tromey  <tromey@adacore.com>
1463
1464         * ada-exp.y (find_primitive_type): Update.
1465         * ada-lang.h (ada_lookup_symbol): Update.
1466         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1467         parameter.
1468         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1469
1470 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1471
1472         PR breakpoints/24541
1473         * gdbarch.c: Regenerate.
1474         * gdbarch.h: Regenerate.
1475         * gdbarch.sh: Add 'stap_adjust_register'.
1476         * i386-tdep.c: Include '<unordered_set>'.
1477         (i386_stap_adjust_register): New function.
1478         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1479         * stap-probe.c (stap_parse_register_operand): Call
1480         'gdbarch_stap_adjust_register'.
1481
1482 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1483
1484         PR python/24742
1485         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1486         * python/python.c (do_start_initialization): Use 'xmalloc'
1487         instead of 'PyMem_Malloc'.
1488
1489 2019-06-28  Tom Tromey  <tromey@adacore.com>
1490
1491         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1492         for Ada.
1493
1494 2019-06-27  Tom Tromey  <tromey@adacore.com>
1495
1496         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1497         objfile_key.
1498         (arm_find_mapping_symbol, arm_record_special_symbol)
1499         (_initialize_arm_tdep): Update.
1500         (arm_objfile_data_free): Remove.
1501
1502 2019-06-27  Tom Tromey  <tromey@adacore.com>
1503
1504         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1505         to cp_print_static_field.
1506
1507 2019-06-26  Tom Tromey  <tromey@adacore.com>
1508
1509         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1510         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1511         declare.
1512
1513 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1514
1515         * features/aarch64-core.c (create_feature_aarch64_core):
1516         Regenerate.
1517         * features/aarch64-core.xml: Add cpsr flags.
1518
1519 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1520
1521         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1522         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1523
1524 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1525
1526         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1527         field.
1528         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1529         use.
1530         (arm_record_special_symbol): Don't insert new symbol in sorted
1531         position, push it at the end.
1532
1533 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1534
1535         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1536         (arm_mapping_symbol_s): Remove.
1537         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1538         (arm_mapping_symbol_vec): New typedef.
1539         (struct arm_per_objfile): Add constructor.
1540         <section_maps>: Change type to
1541         std::unique_ptr<arm_mapping_symbol_vec[]>.
1542         (arm_compare_mapping_symbols): Remove.
1543         (arm_find_mapping_symbol): Adjust to section_maps type change.
1544         (arm_objfile_data_free): Call delete on arm_per_objfile.
1545         (arm_record_special_symbol): Adjust to section_maps type change.
1546         Allocate arm_per_objfile with new.
1547
1548 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1549
1550         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1551         with the command prefix.
1552
1553 2019-06-25  Tom Tromey  <tom@tromey.com>
1554
1555         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1556         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1557
1558 2019-06-25  Tom Tromey  <tom@tromey.com>
1559
1560         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1561         type.
1562         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1563         protected.
1564
1565 2019-06-25  Tom Tromey  <tom@tromey.com>
1566
1567         * tui/tui-winsource.c
1568         (tui_source_window_base::set_is_exec_point_at): Add check against
1569         LOA_ADDRESS.
1570
1571 2019-06-25  Tom Tromey  <tom@tromey.com>
1572
1573         * tui/tui-source.c (tui_set_source_content): Don't check before
1574         xfree.
1575         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1576
1577 2019-06-25  Tom Tromey  <tom@tromey.com>
1578
1579         * tui/tui-winsource.h (tui_update_source_window_as_is)
1580         (tui_alloc_source_buffer, tui_line_is_displayed)
1581         (tui_addr_is_displayed): Change type of win_info.
1582         * tui/tui-winsource.c (tui_update_source_window_as_is)
1583         (tui_clear_source_content, tui_show_source_line)
1584         (tui_show_source_content, tui_source_window_base::refill)
1585         (tui_source_window_base::set_is_exec_point_at)
1586         (tui_source_window_base::set_is_exec_point_at)
1587         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1588         (tui_alloc_source_buffer, tui_line_is_displayed)
1589         (tui_addr_is_displayed): Change type of win_info.  Update.
1590         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1591         (tui_source_window_base::do_make_visible_with_new_height):
1592         Update.
1593         * tui/tui-source.c (tui_set_source_content)
1594         (tui_set_source_content_nil)
1595         (tui_source_window::do_scroll_vertical): Update.
1596         * tui/tui-layout.c (show_layout): Update.
1597         * tui/tui-disasm.c (tui_set_disassem_content)
1598         (tui_disasm_window::do_scroll_vertical): Update.
1599         * tui/tui-data.h (tui_win_content): Remove.
1600         (struct tui_gen_win_info) <content, content_size>: Remove.
1601         (struct tui_source_element): Add initializers and destructor.
1602         (union tui_which_element, struct tui_win_element): Remove.
1603         (struct tui_source_window_base) <content>: New field.
1604         (struct tui_data_window): Remove destructor.
1605         (tui_alloc_content, tui_free_win_content)
1606         (tui_free_all_source_wins_content): Don't declare.
1607         * tui/tui-data.c (tui_initialize_static_data): Update.
1608         (init_content_element, tui_alloc_content): Remove.
1609         (~tui_gen_win_info): Update.
1610         (~tui_data_window, tui_free_all_source_wins_content)
1611         (tui_free_win_content, free_content, free_content_elements):
1612         Remove.
1613
1614 2019-06-25  Tom Tromey  <tom@tromey.com>
1615
1616         * tui/tui-winsource.h (tui_clear_source_content)
1617         (tui_erase_source_content, tui_show_source_content): Change type
1618         of win_info.
1619         * tui/tui-winsource.c (tui_clear_source_content)
1620         (tui_erase_source_content, tui_show_source_content): Change type
1621         of win_info.
1622         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1623         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1624         win_info.
1625         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1626         win_info.
1627         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1628
1629 2019-06-25  Tom Tromey  <tom@tromey.com>
1630
1631         * tui/tui-winsource.c (tui_clear_source_content)
1632         (tui_source_window_base::set_is_exec_point_at): Update.
1633         * tui/tui-source.c (tui_set_source_content_nil): Update.
1634         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1635         a bool.
1636         * tui/tui-data.c (init_content_element): Update.
1637
1638 2019-06-25  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1641         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1642         * tui/tui-layout.c (init_and_make_win): Update.
1643         * tui/tui.h (enum tui_win_type): Update.
1644         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1645         tui_win_is_auxillary.
1646         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1647         tui_win_is_auxillary.
1648
1649 2019-06-25  Tom Tromey  <tom@tromey.com>
1650
1651         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1652         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1653         (tui_delete_data_content_windows, tui_display_all_data)
1654         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1655         Update.
1656         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1657         * tui/tui-regs.c (tui_last_regs_line_no)
1658         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1659         (tui_show_registers): Update.
1660         (tui_show_register_group): Return void.  Update.
1661         (tui_display_registers_from, tui_display_reg_element_at_line)
1662         (tui_display_registers_from_line, tui_check_register_values):
1663         Update.
1664         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1665         member.
1666         (struct tui_data_window) <regs_content>: Now a std::vector.
1667         <regs_content_count>: Remove.
1668         (tui_add_content_elements, tui_free_data_content): Don't declare.
1669         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1670         (init_content_element): Remove DATA_WIN case.  Add assert.
1671         (tui_add_content_elements): Remove.
1672         (tui_data_window): Update.
1673         (tui_free_data_content): Remove.
1674         (free_content_elements): Remove DATA_WIN case.
1675
1676 2019-06-25  Tom Tromey  <tom@tromey.com>
1677
1678         * tui/tui-data.c (tui_data_item_window): Update.
1679         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1680         * tui/tui-windata.c (tui_display_all_data)
1681         (tui_display_data_from_line): Update.
1682         (tui_check_data_values): Remove.
1683         * tui/tui-regs.c (tui_show_register_group)
1684         (tui_display_reg_element_at_line): Update.
1685         * tui/tui-hooks.c (tui_register_changed)
1686         (tui_refresh_frame_and_register_information): Call
1687         tui_check_register_values.
1688         * tui/tui-data.h (struct tui_data_window) <data_content,
1689         data_content_count, data_type>: Remove.
1690         (enum tui_data_type): Remove.
1691
1692         * tui/tui-data.c (tui_data_window::clear_detail)
1693         (~tui_data_window): Update.
1694
1695 2019-06-25  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1698         declare.
1699         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1700         Rename from tui_first_data_item_displayed.  Update.
1701         (tui_data_window::refresh_all)
1702         (tui_data_window::do_scroll_vertical): Update.
1703         * tui/tui-data.h (struct tui_data_window)
1704         <first_data_item_displayed>: Declare new method.
1705
1706 2019-06-25  Tom Tromey  <tom@tromey.com>
1707
1708         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1709         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1710         contents...
1711         (tui_initialize_static_data): ...here.
1712
1713 2019-06-25  Tom Tromey  <tom@tromey.com>
1714
1715         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1716         (tui_display_registers_from, tui_check_register_values): Update.
1717         (tui_display_register): Remove win_info parameter; update.
1718         (tui_get_register): Change type of parameters.
1719         * tui/tui-data.h (struct tui_data_element): Remove.
1720         (union tui_which_element) <data>: Remove.
1721         <data_window>: Change type.
1722         (struct tui_data_item_window): New.
1723         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1724         case.  Add assert.
1725         (~tui_data_item_window): New destructor.
1726         (free_content_elements): Remove DATA_ITEM_WIN case.
1727
1728 2019-06-25  Tom Tromey  <tom@tromey.com>
1729
1730         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1731         Remove.
1732
1733 2019-06-25  Tom Tromey  <tom@tromey.com>
1734
1735         * tui/tui-data.h (struct tui_command_element): Remove.
1736         (union tui_which_element) <command>: Remove.
1737         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1738         assert.
1739         (free_content_elements): Remove CMD_WIN case.
1740
1741 2019-06-25  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-layout.c (tui_set_layout): Update.
1744         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1745         * tui/tui-data.c (layout_def): Update.
1746
1747 2019-06-25  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1750         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1751         (tui_source_window_base::set_new_height): Update.
1752         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1753         Update.
1754         (tui_set_locator_fullname, tui_set_locator_info)
1755         (tui_show_frame_info): Update.
1756         * tui/tui-source.c (tui_set_source_content)
1757         (tui_source_is_displayed): Update.
1758         * tui/tui-layout.c (show_source_disasm_command, show_data)
1759         (show_source_or_disasm_and_command): Update.
1760         * tui/tui-disasm.c (tui_set_disassem_content)
1761         (tui_get_begin_asm_address): Update.
1762         * tui/tui-data.h (struct tui_locator_element): Remove.
1763         (union tui_which_element) <locator>: Remove.
1764         (struct tui_locator_window): New.
1765         (tui_locator_win_info_ptr): Change return type.
1766         * tui/tui-data.c (_locator): Change type.
1767         (tui_locator_win_info_ptr): Change return type.
1768         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1769         (tui_alloc_content): Add assert.
1770
1771 2019-06-25  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-winsource.c
1774         (tui_exec_info_window::maybe_allocate_content): New method.
1775         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1776         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1777         (make_source_or_disasm_window): Add cast.
1778         * tui/tui-data.h (union tui_which_element) <simple_string>:
1779         Remove.
1780         (struct tui_source_info): New.
1781         (struct tui_source_window_base) <execution_info>: Change type.
1782         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1783         case, and add assert.
1784         (tui_alloc_content): Add assert.
1785
1786 2019-06-25  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1789         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1790         * tui/tui-data.c (tui_alloc_win_info): Remove.
1791
1792 2019-06-25  Tom Tromey  <tom@tromey.com>
1793
1794         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1795         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1796         can_highlight.
1797
1798 2019-06-25  Tom Tromey  <tom@tromey.com>
1799
1800         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1801         make_visible_with_new_height method.
1802         (tui_win_info::make_visible_with_new_height): New method.
1803         (tui_source_window_base::do_make_visible_with_new_height)
1804         (tui_data_window::do_make_visible_with_new_height)
1805         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1806         (make_visible_with_new_height): Remove.
1807         (tui_resize_all, tui_adjust_win_heights): Use
1808         make_visible_with_new_height method.
1809         * tui/tui-data.h (struct tui_win_info)
1810         <do_make_visible_with_new_height, make_visible_with_new_height>:
1811         New methods.
1812         (struct tui_source_window_base, struct tui_data_window)
1813         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1814         methods.
1815
1816 2019-06-25  Tom Tromey  <tom@tromey.com>
1817
1818         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1819         method.
1820         (update_tab_width): Call update_tab_width method.
1821         * tui/tui-data.h (struct tui_win_info)
1822         (struct tui_source_window_base) <update_tab_width>: New methods.
1823
1824 2019-06-25  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1827         parameter.
1828         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1829         parameter.
1830         (tui_gen_win_info::make_visible): Update.
1831         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1832         parameter.
1833         * tui/tui-data.h (enum tui_box): New enum.
1834         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1835
1836 2019-06-25  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1839         init_and_make_win for EXEC_INFO_WIN.
1840         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1841         longer inline.
1842         (struct tui_win_info) <~tui_win_info>: Inline.
1843         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1844         Don't declare.
1845         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1846         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1847         Remove.
1848         (tui_initialize_static_data): Update.
1849         (~tui_gen_win_info): Handle more cleanup here.
1850         (~tui_source_window_base): Delete "execution_info".
1851         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1852
1853 2019-06-25  Tom Tromey  <tom@tromey.com>
1854
1855         * tui/tui-layout.c (make_command_window): Don't set
1856         can_highlight.
1857         (show_source_disasm_command): Call the reset method.
1858         (show_data): Don't set can_highlight.  Call the reset method.
1859         (tui_gen_win_info::reset): Rename from init_gen_win_info
1860         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1861         (show_source_or_disasm_and_command): Call the reset method.
1862         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1863         (struct tui_cmd_window): Set can_highlight.
1864
1865 2019-06-25  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1868         from make_visible.
1869         (tui_make_visible, tui_make_invisible): Rewrite.
1870         (tui_win_info::make_visible): Remove.
1871         (tui_source_window_base::make_visible): Update.
1872         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1873         method.  Moved from...
1874         (struct tui_win_info) <make_visible>: ...here.
1875
1876 2019-06-25  Tom Tromey  <tom@tromey.com>
1877
1878         * tui/tui-winsource.c
1879         (tui_source_window_base::do_scroll_horizontal): Remove direction
1880         parameter.
1881         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1882         direction parameter.
1883         * tui/tui-win.c (tui_win_info::forward_scroll)
1884         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1885         (tui_win_info::right_scroll): Update.
1886         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1887         direction parameter.
1888         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1889         direction parameter.
1890         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1891         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1892         Remove direction parameter.
1893         (struct tui_source_window_base, struct tui_source_window)
1894         (struct tui_disasm_window, struct tui_data_window)
1895         (struct tui_cmd_window): Update.
1896
1897 2019-06-25  Tom Tromey  <tom@tromey.com>
1898
1899         * tui/tui-winsource.h (tui_set_exec_info_content)
1900         (tui_show_exec_info_content, tui_erase_exec_info_content)
1901         (tui_clear_exec_info_content, tui_update_exec_info): Change
1902         argument to tui_source_window_base.
1903         * tui/tui-winsource.c (tui_set_exec_info_content)
1904         (tui_show_exec_info_content, tui_erase_exec_info_content)
1905         (tui_clear_exec_info_content, tui_update_exec_info): Change
1906         argument to tui_source_window_base.
1907
1908 2019-06-25  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1911         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1912
1913 2019-06-25  Tom Tromey  <tom@tromey.com>
1914
1915         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1916         check.
1917
1918 2019-06-25  Tom Tromey  <tom@tromey.com>
1919
1920         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1921         type to void.
1922         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1923         type to void.
1924         * tui/tui-source.c (tui_set_source_content): Update.
1925         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1926
1927 2019-06-25  Tom Tromey  <tom@tromey.com>
1928
1929         * tui/tui-win.c (window_name_completer, tui_set_focus)
1930         (tui_all_windows_info): Use name method.
1931         * tui/tui-data.h (struct tui_gen_win_info)
1932         (struct tui_source_window, struct tui_disasm_window)
1933         (struct tui_data_window, struct tui_cmd_window) <name>: New
1934         method.
1935         (tui_win_name): Don't declare.
1936         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1937         (tui_win_name): Remove.
1938
1939 2019-06-25  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-winsource.h (tui_update_source_window)
1942         (tui_update_source_window_as_is): Change parameter type.
1943         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1944         to be a tui_source_window_base.
1945         (tui_update_source_window_as_is): Likewise.
1946         * tui/tui-win.c (make_visible_with_new_height): Update.
1947
1948 2019-06-25  Tom Tromey  <tom@tromey.com>
1949
1950         * tui/tui-winsource.c (tui_erase_source_content)
1951         (tui_show_source_content, tui_show_exec_info_content)
1952         (tui_erase_exec_info_content): Use refresh_window method.
1953         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1954         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1955         from tui_refresh_win.
1956         (tui_data_window::refresh_window): New method.
1957         (tui_win_info::refresh, tui_source_window_base::refresh)
1958         (tui_refresh_all): Use refresh_window method.
1959         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1960         method.
1961         * tui/tui-regs.c (tui_display_register): Call refresh_window
1962         method.
1963         * tui/tui-layout.c (show_source_disasm_command)
1964         (show_source_or_disasm_and_command): Call refresh_window method.
1965         * tui/tui-data.h (struct tui_gen_win_info)
1966         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1967         New method.
1968
1969 2019-06-25  Tom Tromey  <tom@tromey.com>
1970
1971         * tui/tui.c (tui_rl_other_window, tui_enable)
1972         (tui_is_window_visible, tui_get_command_dimension): Update.
1973         * tui/tui-winsource.c (tui_update_source_window_as_is)
1974         (tui_clear_source_content, tui_erase_source_content)
1975         (tui_show_source_line, tui_source_window_base::refill)
1976         (tui_source_window_base::do_scroll_horizontal)
1977         (tui_source_window_base::set_is_exec_point_at)
1978         (tui_update_breakpoint_info, tui_set_exec_info_content)
1979         (tui_alloc_source_buffer, tui_line_is_displayed)
1980         (tui_addr_is_displayed): Update.
1981         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1982         (tui_check_and_display_highlight_if_needed)
1983         (tui_win_info::make_visible, tui_win_info::refresh)
1984         (tui_refresh_all): Update.
1985         * tui/tui-windata.c (tui_first_data_item_displayed)
1986         (tui_delete_data_content_windows, tui_erase_data_content)
1987         (tui_display_all_data, tui_data_window::refresh_all)
1988         (tui_check_data_values): Update.
1989         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1990         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1991         (tui_win_info::backward_scroll, tui_refresh_all_win)
1992         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1993         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1994         (tui_source_window_base::set_new_height)
1995         (tui_data_window::set_new_height)
1996         (make_invisible_and_set_new_height)
1997         (make_visible_with_new_height, new_height_ok)
1998         (parse_scrolling_args): Update.
1999         * tui/tui-stack.c (tui_show_frame_info): Update.
2000         * tui/tui-source.c (tui_set_source_content)
2001         (tui_set_source_content_nil, tui_source_is_displayed)
2002         (tui_source_window::do_scroll_vertical): Update.
2003         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2004         (tui_display_registers_from, tui_display_reg_element_at_line)
2005         (tui_check_register_values, tui_reg_command): Update.
2006         * tui/tui-layout.c (tui_default_win_height)
2007         (show_source_disasm_command, show_data, init_and_make_win)
2008         (show_source_or_disasm_and_command): Update.
2009         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2010         (tui_redisplay_readline, tui_mld_flush)
2011         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2012         (tui_getc): Update.
2013         * tui/tui-disasm.c (tui_set_disassem_content)
2014         (tui_disasm_window::do_scroll_vertical): Update.
2015         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2016         Now virtual.
2017         (struct tui_win_info): Derive from tui_gen_win_info.
2018         <~tui_win_info>: Mark as override.
2019         <generic>: Remove member.
2020         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2021         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2022         (~tui_data_window, ~tui_win_info)
2023         (tui_free_all_source_wins_content): Update.
2024         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2025
2026 2019-06-25  Tom Tromey  <tom@tromey.com>
2027
2028         * tui/tui-layout.c (init_and_make_win): Use new.
2029         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2030         destructor, initializers.
2031         (tui_alloc_generic_win_info): Don't declare.
2032         * tui/tui-data.c (_locator): Add argument to constructor.
2033         (source_win, disasm_win): New globals.
2034         (exec_info): Remove.
2035         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2036         Update.
2037         (tui_alloc_generic_win_info): Remove.
2038         (init_content_element): Use new.
2039         (tui_win_info::tui_win_info): Update.
2040         (free_content_elements) <case DATA_WIN>: Use delete.
2041
2042 2019-06-25  Tom Tromey  <tom@tromey.com>
2043
2044         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2045         * tui/tui-windata.c (tui_first_data_item_displayed)
2046         (tui_delete_data_content_windows): Update.
2047         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2048         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2049         (tui_display_registers_from, tui_check_register_values): Update.
2050         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2051         pointer.
2052         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2053         window.
2054         (tui_free_data_content): Update.
2055         (free_content_elements) <case DATA_WIN>: Free the window.
2056
2057 2019-06-25  Tom Tromey  <tom@tromey.com>
2058
2059         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2060         Update.
2061         * tui/tui-layout.c (make_command_window)
2062         (show_source_disasm_command, show_data, init_and_make_win)
2063         (show_source_or_disasm_and_command): Update.
2064         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2065         method.
2066         <can_highight, is_highlighted>: Now bool.
2067         (tui_set_win_highlight): Don't declare.
2068         * tui/tui-data.c (tui_set_win_highlight): Remove.
2069
2070 2019-06-25  Tom Tromey  <tom@tromey.com>
2071
2072         * tui/tui-wingeneral.c (make_visible): Remove check of window
2073         type.
2074
2075 2019-06-25  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-win.c (tui_win_info::max_height)
2078         (tui_cmd_window::max_height): New methods.
2079         (new_height_ok): Call max_height.
2080         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2081         <max_height>: New method.
2082
2083 2019-06-25  Tom Tromey  <tom@tromey.com>
2084
2085         * tui/tui-win.c (tui_source_window_base::set_new_height)
2086         (tui_data_window::set_new_height): New methods.
2087         (make_invisible_and_set_new_height): Call set_new_height method.
2088         * tui/tui-data.h (struct tui_win_info)
2089         (struct tui_source_window_base, struct tui_data_window)
2090         <set_new_height>: New method.
2091
2092 2019-06-25  Tom Tromey  <tom@tromey.com>
2093
2094         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2095         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2096         tui_refresh_data_win.
2097         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2098         method.
2099         (tui_refresh_all_win): Call the refresh_all method.
2100         (tui_set_focus): Likewise.
2101         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2102         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2103         Likewise.
2104
2105 2019-06-25  Tom Tromey  <tom@tromey.com>
2106
2107         * tui/tui-winsource.h (tui_refill_source_window)
2108         (tui_set_is_exec_point_at): Don't declare.
2109         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2110         (tui_source_window_base::refill): Rename from
2111         tui_refill_source_window.
2112         (tui_source_window_base::do_scroll_horizontal): Update.
2113         (tui_source_window_base::set_is_exec_point_at): Rename from
2114         tui_set_is_exec_point_at.
2115         (tui_update_all_breakpoint_info): Update.
2116         * tui/tui-stack.c (tui_show_frame_info): Update.
2117         * tui/tui-layout.c (show_data): Add cast.
2118         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2119         * tui/tui-data.h (struct tui_source_window_base) <refill,
2120         set_is_exec_point_at>: New methods.
2121         (tui_source_windows, tui_add_to_source_windows): Update types.
2122         (tui_add_to_source_windows): Remove redundant declaration.
2123         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2124         (tui_source_windows): Change return type.
2125         (tui_clear_source_windows_detail): Update.
2126         (tui_add_to_source_windows): Change type of parameter.
2127         (tui_free_all_source_wins_content): Update.
2128
2129 2019-06-25  Tom Tromey  <tom@tromey.com>
2130
2131         * tui/tui-wingeneral.c (tui_win_info::refresh)
2132         (tui_source_window_base::refresh): New methods.
2133         (tui_refresh_all): Call the refresh method.
2134         * tui/tui-data.h (struct tui_win_info)
2135         (struct tui_source_window_base) <refresh>: New method.
2136
2137 2019-06-25  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui.h (tui_is_window_visible): Return bool.
2140         * tui/tui.c (tui_is_window_visible): Return bool.
2141         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2142         (tui_make_visible, tui_make_invisible)
2143         (tui_win_info::make_visible)
2144         (tui_source_window_base::make_visible, make_all_visible)
2145         (tui_make_all_visible, tui_make_all_invisible): Update.
2146         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2147         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2148         bool.
2149         (struct tui_win_info, struct tui_source_window_base)
2150         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2151         * tui/tui-data.c (tui_init_generic_part): Update.
2152
2153 2019-06-25  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2156         (tui_source_window_base::make_visible): New methods.
2157         (make_all_visible): Make method call.
2158         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2159         (struct tui_source_window_base, struct tui_cmd_window): Override
2160         make_visible.
2161         (tui_win_is_source_type): Don't declare.
2162         * tui/tui-data.c (tui_win_is_source_type): Remove.
2163
2164 2019-06-25  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2167         NULL check.
2168
2169 2019-06-25  Tom Tromey  <tom@tromey.com>
2170
2171         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2172         Inline constructor.  Add initializers for members.
2173         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2174         constructors; now inline in class.
2175
2176 2019-06-25  Tom Tromey  <tom@tromey.com>
2177
2178         * tui/tui-regs.c (tui_show_registers): Update.
2179         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2180         bool.
2181         * tui/tui-data.c (tui_data_window::clear_detail)
2182         (tui_data_window): Update.
2183
2184 2019-06-25  Tom Tromey  <tom@tromey.com>
2185
2186         * tui/tui-windata.c (tui_display_all_data)
2187         (tui_display_data_from_line, tui_display_data_from)
2188         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2189         Update.
2190         * tui/tui-regs.c (tui_last_regs_line_no)
2191         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2192         (tui_show_registers, tui_show_register_group)
2193         (tui_display_registers_from, tui_display_reg_element_at_line)
2194         (tui_display_registers_from_line, tui_check_register_values)
2195         (tui_reg_next, tui_reg_prev): Update.
2196         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2197         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2198         tui_data_window.
2199         (struct tui_win_info) <detail>: Remove.  Add new fields from
2200         tui_data_info.
2201         (TUI_DATA_WIN): Add cast.
2202         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2203         (~tui_data_window): Simplify.
2204
2205 2019-06-25  Tom Tromey  <tom@tromey.com>
2206
2207         * tui/tui-layout.c (show_source_disasm_command)
2208         (show_source_or_disasm_and_command): Update.
2209         * tui/tui-io.c (update_cmdwin_start_line)
2210         (tui_redisplay_readline): Update.
2211         * tui/tui-data.h (struct tui_command_info): Remove.
2212         (struct tui_win_info) <detail>: Remove command_info member.
2213         (struct tui_data_window) <start_line>: New member, from
2214         tui_command_info.
2215         (TUI_CMD_WIN): Add casts.
2216
2217 2019-06-25  Tom Tromey  <tom@tromey.com>
2218
2219         * tui/tui-winsource.c (tui_update_source_window)
2220         (tui_refill_source_window)
2221         (tui_source_window_base::do_scroll_horizontal)
2222         (tui_update_breakpoint_info, tui_set_exec_info_content)
2223         (tui_show_exec_info_content, tui_erase_exec_info_content)
2224         (tui_clear_exec_info_content): Update.
2225         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2226         Update.
2227         * tui/tui-win.c (make_invisible_and_set_new_height)
2228         (make_visible_with_new_height): Update.
2229         * tui/tui-source.c (tui_set_source_content)
2230         (tui_show_symtab_source): Update.
2231         * tui/tui-layout.c (extract_display_start_addr)
2232         (show_source_disasm_command, show_data)
2233         (make_source_or_disasm_window)
2234         (show_source_or_disasm_and_command): Update.
2235         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2236         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2237         "gdbarch".
2238         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2239         to tui_source_window_base.
2240         (struct tui_win_info) <detail>: Remove source_info member.
2241         (struct tui_source_window_base) <has_locator>: Inline.
2242         Move contents from tui_source_info; rename has_locator member to
2243         m_has_locator.
2244         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2245         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2246         header file.
2247         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2248         Simplify.
2249         (tui_free_all_source_wins_content): Cast to
2250         tui_source_window_base.
2251
2252 2019-06-25  Tom Tromey  <tom@tromey.com>
2253
2254         * tui/tui-win.c (make_invisible_and_set_new_height)
2255         (make_visible_with_new_height): Call has_locator method.
2256         * tui/tui-layout.c (show_source_disasm_command, show_data)
2257         (show_source_or_disasm_and_command): Update for bool change.
2258         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2259         (tui_win_info) <has_locator>: New method.
2260         (struct tui_source_window_base) <has_locator>: New method.
2261         (tui_win_has_locator): Don't declare.
2262         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2263         from tui_win_has_locator.
2264         (tui_source_window_base): Use false, not FALSE.
2265
2266 2019-06-25  Tom Tromey  <tom@tromey.com>
2267
2268         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2269         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2270         clear_detail method directly.
2271         (tui_clear_win_detail): Remove.
2272
2273 2019-06-25  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2276         "this", not TUI_DISASM_WIN.
2277
2278 2019-06-25  Tom Tromey  <tom@tromey.com>
2279
2280         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2281         declare.
2282         * tui/tui-winsource.c
2283         (tui_source_window_base::do_scroll_horizontal): Rename from
2284         tui_horizontal_source_scroll.
2285         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2286         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2287         from tui_vertical_data_scroll.
2288         * tui/tui-win.h (tui_scroll): Don't declare.
2289         * tui/tui-win.c (tui_win_info::forward_scroll)
2290         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2291         (tui_win_info::right_scroll): Rename and update.
2292         (tui_scroll_forward_command, tui_scroll_backward_command)
2293         (tui_scroll_left_command, tui_scroll_right_command): Update.
2294         (tui_scroll): Remove.
2295         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2296         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2297         from tui_vertical_source_scroll.
2298         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2299         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2300         from tui_vertical_disassem_scroll.
2301         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2302         do_scroll_horizontal>: New methods.
2303         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2304         Likewise.
2305         (struct tui_source_window_base): Add do_scroll_horizontal.
2306         (struct tui_source_window, struct tui_disasm_window): Add
2307         do_scroll_vertical.
2308         (struct tui_data_window, struct tui_cmd_window): Add
2309         do_scroll_horizontal and do_scroll_vertical.
2310         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2311
2312 2019-06-25  Tom Tromey  <tom@tromey.com>
2313
2314         * tui/tui-data.h (struct tui_source_window_base): New struct.
2315         (struct tui_source_window): Derive from tui_source_window_base.
2316         (struct tui_disasm_window): New struct.
2317         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2318         from tui_source_window::clear_detail.
2319         (tui_source_window_base): Rename from tui_source_window.
2320         (~tui_source_window_base): Rename from ~tui_source_window.
2321         (tui_alloc_win_info): Create a tui_disasm_window.
2322
2323 2019-06-25  Tom Tromey  <tom@tromey.com>
2324
2325         * tui/tui-data.h (struct tui_source_window)
2326         (struct tui_data_window): Declare destructors.
2327         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2328         destructors.
2329         (tui_win_info): Simplify.
2330
2331 2019-06-25  Tom Tromey  <tom@tromey.com>
2332
2333         * tui/tui-winsource.c (tui_display_main)
2334         (tui_update_source_windows_with_addr)
2335         (tui_update_all_breakpoint_info): Update.
2336         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2337         (new_height_ok, parse_scrolling_args): Update.
2338         * tui/tui-stack.c (tui_show_frame_info): Update.
2339         * tui/tui-data.h (struct tui_list): Remove.
2340         (tui_source_windows): Return a reference to a std::vector.
2341         * tui/tui-data.c (source_windows): Now a std::vector.
2342         (tui_source_windows): Change return type.
2343         (tui_clear_source_windows): Rewrite.
2344         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2345         (tui_free_all_source_wins_content): Rewrite.
2346
2347 2019-06-25  Tom Tromey  <tom@tromey.com>
2348
2349         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2350         (struct tui_data_window, struct tui_cmd_window): Declare
2351         clear_detail method.
2352         * tui/tui-data.c (tui_source_window::clear_detail)
2353         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2354         methods.
2355         (tui_clear_win_detail): Simplify.
2356
2357 2019-06-25  Tom Tromey  <tom@tromey.com>
2358
2359         * tui/tui-layout.c (make_source_window, make_disasm_window)
2360         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2361         Return the new window.
2362         (show_source_disasm_command, show_data)
2363         (show_source_or_disasm_and_command): Update.
2364
2365 2019-06-25  Tom Tromey  <tom@tromey.com>
2366
2367         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2368         parameter.  Return the new window.
2369         (show_source_disasm_command): Update and remove NULL check.
2370         (show_source_or_disasm_and_command): Update.
2371
2372 2019-06-25  Tom Tromey  <tom@tromey.com>
2373
2374         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2375
2376 2019-06-25  Tom Tromey  <tom@tromey.com>
2377
2378         * tui/tui-data.h (struct tui_win_info): Make constructor
2379         protected.  Make destructor virtual.  Add initializers.
2380         (tui_source_window, tui_data_window, tui_cmd_window): New
2381         classes.
2382         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2383         constructor.  Add "type" parameter.
2384         (tui_source_window, tui_data_window, tui_cmd_window): New
2385         constructors.
2386         (tui_alloc_win_info): Instantiate the appropriate subclass.
2387
2388 2019-06-25  Tom Tromey  <tom@tromey.com>
2389
2390         * tui/tui-win.c (tui_resize_all): Use delete.
2391         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2392         destructor.
2393         (tui_free_window): Don't declare.
2394         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2395         Update.
2396
2397 2019-06-25  Tom Tromey  <tom@tromey.com>
2398
2399         * tui/tui-data.h (struct tui_win_info): Add constructor.
2400         * tui/tui-data.c (tui_alloc_win_info): Use new.
2401         (tui_free_window): Use delete.
2402
2403 2019-06-22  Tom Tromey  <tom@tromey.com>
2404
2405         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2406         declare.
2407         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2408
2409 2019-06-22  Tom Tromey  <tom@tromey.com>
2410
2411         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2412         declare.
2413         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2414
2415 2019-06-22  Tom de Vries  <tdevries@suse.de>
2416
2417         * dwarf2read.c (create_addrmap_from_aranges)
2418         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2419         instead of '%zu'.
2420
2421 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2422
2423         * dwarf2read.h (dwarf2_section_info_def): Remove.
2424         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2425         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2426         std::vector<dwarf2_section_info>.
2427         (struct dwo_file) <~dwo_file>: Remove.
2428         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2429         types field.
2430         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2431         (dwarf2_read_debug_names): Likewise.
2432         (create_debug_types_hash_table): Change parameter type to
2433         array_view, adjust code accordingly.
2434         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2435         (partial_die_info::fixup): Likewise.
2436         (determine_prefix): Likewise.
2437         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2438
2439 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2440
2441         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2442         gdb_bfd_ref_ptr.
2443         <~dwo_file>: Remove call to gdb_bfd_unref.
2444         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2445         gdb_bfd_ref_ptr::get.
2446
2447 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2448
2449         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2450         type to htab_up.
2451         * dwarf2read.c (struct dwo_file): Initialize fields.
2452         <~dwo_file>: New.
2453         (free_dwo_file): Remove, move content to ~dwo_file.
2454         (struct dwo_file_deleter): Remove.
2455         (dwo_file_up>: Remove custom deleter.
2456         (free_dwo_files): Remove.
2457         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2458         dwo_files.
2459         (process_skeletonless_type_units): Call unique_ptr::get.
2460         (allocate_dwo_file_hash_table): Add deleter to created hash
2461         table.  Change return type to htab_up.
2462         (lookup_dwo_file_slot): Don't memset dwo_file, call
2463         unique_ptr::get.
2464         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2465         (create_dwo_unit_in_dwp_v2): Likewise.
2466         (open_and_init_dwo_file): Likewise.
2467         (free_dwo_file_from_slot): Remove.
2468
2469 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2470
2471         * dwarf2read.h (struct dwarf2_section_info) <readin,
2472         is_virtual>: Change type to bool.
2473         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2474         true instead of 1.
2475
2476 2019-06-19  Tom Tromey  <tom@tromey.com>
2477
2478         * tui/tui-data.h (tui_init_content_element): Don't declare.
2479
2480 2019-06-19  Tom Tromey  <tom@tromey.com>
2481
2482         * tui/tui-data.h (tui_init_win_info): Don't declare.
2483
2484 2019-06-19  Tom de Vries  <tdevries@suse.de>
2485
2486         * dwarf2read.h (abstract_to_concrete): Change type to
2487         std::unordered_map<sect_offset, std::vector<sect_offset>,
2488         gdb::hash_enum<sect_offset>>.
2489
2490 2019-06-19  Tom Tromey  <tromey@adacore.com>
2491
2492         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2493         EVAL_AVOID_SIDE_EFFECTS specially.
2494
2495 2019-06-19  Tom Tromey  <tromey@adacore.com>
2496
2497         * source-cache.c (highlighter): New global.
2498         (source_cache::get_source_lines): Create a highlighter on demand.
2499
2500 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2501
2502         * defs.h (deprecated_interactive_hook): Delete declaration.
2503         * interps.c (clear_interpreter_hooks): Remove use of
2504         deprecated_interactive_hook.
2505         * top.c (deprecated_interactive_hook): Delete definition.
2506         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2507
2508 2019-06-18  Tom de Vries  <tdevries@suse.de>
2509
2510         PR gdb/24515
2511         * dwarf2read.h (abstract_to_concrete): Change type from
2512         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2513         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2514         * dwarf2read.c (read_variable): Update.
2515         (dwarf2_fetch_die_loc_sect_off): Update.
2516
2517 2019-06-17  Tom de Vries  <tdevries@suse.de>
2518
2519         PR gdb/24617
2520         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2521         accessing parent[parent_len - 1].
2522
2523 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2524
2525         PR gdb/24364
2526         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2527         call dtrace_process_dof with NULL dof.
2528
2529 2019-06-16  Tom de Vries  <tdevries@suse.de>
2530
2531         PR gdb/24445
2532         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2533
2534 2019-06-16  Tom Tromey  <tom@tromey.com>
2535
2536         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2537         (make_all_visible): Use address of member.
2538
2539 2019-06-16  Tom Tromey  <tom@tromey.com>
2540
2541         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2542         (tui_free_window, free_content, free_content_elements): Remove
2543         unnecessary cast.
2544         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2545         cast.
2546         * tui/tui-regs.c (tui_show_register_group)
2547         (tui_display_registers_from, tui_display_reg_element_at_line):
2548         Remove unnecessary cast.
2549
2550 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2551
2552         * linux-nat.c (normal_mask): Delete.
2553         (_initialize_linux_nat): Don't initialise normal_mask.
2554
2555 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2556
2557         PR gdb/24445
2558         * dwarf-index-write.h (write_psymtabs_to_index): Add
2559         dwz_basename parameter.
2560         * dwarf-index-write.c (write_gdbindex): Move file writing to
2561         write_gdbindex_1.  Change return type void.
2562         (assert_file_size): Move up, remove filename parameter.
2563         (write_gdbindex_1): New function.
2564         (write_debug_names): Change return type to void, call
2565         assert_file_size.
2566         (struct index_wip_file): New struct.
2567         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2568         file logic to index_wip_file.  Write index for dwz file if
2569         needed.
2570         (save_gdb_index_command): Pass basename of dwz file, if present.
2571         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2572         build-id of dwz file, if present.
2573         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2574         (dwarf2_get_dwz_file): Likewise.
2575         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2576         (dwarf2_get_dwz_file): Likewise.
2577
2578 2019-06-16  Tom Tromey  <tom@tromey.com>
2579
2580         * coffread.c (process_coff_symbol): Use xstrdup.
2581         * value.c (create_internalvar): Use xstrdup.
2582
2583 2019-06-16  Tom Tromey  <tom@tromey.com>
2584
2585         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2586         * breakpoint.c (stopin_command, stopat_command)
2587         (until_break_command, decode_location_default): Remove unnecessary
2588         cast.
2589         * utils.c (subset_compare): Remove unnecessary cast.
2590         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2591         cast.
2592         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2593         cast.
2594         * infcmd.c (path_command): Remove unnecessary cast.
2595         * coffread.c (decode_type): Remove unnecessary cast.
2596         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2597         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2598         * tui/tui-stack.c (tui_show_locator_content)
2599         (tui_show_frame_info): Remove unnecessary cast.
2600         * tui/tui-win.c (tui_scroll_forward_command)
2601         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2602         (parse_scrolling_args): Remove unnecessary cast.
2603         * tui/tui-data.c (init_win_info, tui_del_window)
2604         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2605         (free_content_elements): Remove unnecessary cast.
2606         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2607         unnecessary cast.
2608         * tui/tui-source.c (tui_set_source_content)
2609         (tui_vertical_source_scroll): Remove unnecessary cast.
2610         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2611         cast.
2612         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2613         * tui/tui-regs.c (tui_display_registers_from)
2614         (tui_display_register): Remove unnecessary cast.
2615         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2616         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2617         (make_visible): Remove unnecessary cast.
2618         * tui/tui-winsource.c (tui_erase_source_content)
2619         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2620         unnecessary cast.
2621         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2622         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2623         * stabsread.c (read_type, read_array_type, read_range_type):
2624         Remove unnecessary cast.
2625         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2626         (parse_symbol, parse_type, upgrade_type, parse_external)
2627         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2628         unnecessary cast.
2629         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2630
2631 2019-06-16  Tom Tromey  <tom@tromey.com>
2632
2633         * tui/tui-data.c (tui_alloc_generic_win_info)
2634         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2635         checks.
2636
2637 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2638             Andrew Burgess  <andrew.burgess@embecosm.com>
2639
2640         * f-typeprint.c (f_print_type): Don't return early for not
2641         associated or not allocated types.
2642         (f_type_print_varspec_suffix): Add print_rank parameter and print
2643         ranks of array types in case they dangling.
2644         (f_type_print_base): Add print_rank parameter.
2645
2646 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2647
2648         * NEWS: Mention new MI commands.
2649         * break-catch-throw.c (enum exception_event_kind): Move to
2650         breakpoint.h.
2651         (print_mention_exception_catchpoint): Output text as a single
2652         message.
2653         (catch_exception_command_1): Rename to...
2654         (catch_exception_event): ...this, make non-static, update header
2655         command, and change some parameter types.
2656         (catch_catch_command): Update for changes to
2657         catch_exception_command_1.
2658         (catch_throw_command): Likewise.
2659         (catch_rethrow_command): Likewise.
2660         * breakpoint.c (enum exception_event_kind): Delete.
2661         * breakpoint.h (enum exception_event_kind): Moved here from
2662         break-catch-throw.c.
2663         (catch_exception_event): Declare.
2664         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2665         (mi_cmd_catch_throw): New function.
2666         (mi_cmd_catch_rethrow): New function.
2667         (mi_cmd_catch_catch): New function.
2668         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2669         'catch-catch' entries.
2670         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2671         (mi_cmd_catch_rethrow): Declare.
2672         (mi_cmd_catch_catch): Declare.
2673
2674 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2675
2676         * annotate.c (annotate_source_line): Change return type to void,
2677         update implementation to match.
2678         * annotate.h (annotate_source_line): Change return type to void,
2679         update header comment.
2680         * stack.c (print_frame_info): Don't change what frame information
2681         is printed based on whether annotations are on or not.
2682
2683 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2684
2685         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2686         (annotate_source): Make static.
2687         (annotate_source_line): Moved from source.c and renamed from
2688         identify_source_line.  Update the return type.
2689         * annotate.h (annotate_source): Delete declaration.
2690         (annotate_source_line): Declaration moved from source.h, and
2691         renamed from identify_source_line.  Return type updated.
2692         * source.c (identify_source_line): Moved to annotate.c and renamed
2693         to annotate_source_line.
2694         (info_line_command): Remove check of annotation_level.
2695         * source.h (identify_source_line): Move declaration to annotate.h
2696         and rename to annotate_source_line.
2697         * stack.c: Add 'annotate.h' include.
2698         (print_frame_info): Remove check of annotation_level before
2699         calling annotate_source_line.
2700
2701 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2702
2703         * source-cache.c (source_cache::get_plain_source_lines): Use
2704         open_source_file_with_line_charpos instead of just
2705         open_source_file, remove call to find_source_lines.
2706         (source_cache::get_source_lines): Likewise.
2707         * source.c (find_source_lines): Make static.
2708         (get_filename_and_charpos): Renamed into...
2709         (open_source_file_with_line_charpos): ..this along with changes to
2710         return a scoped_fd, and some other minor clean ups.
2711         (identify_source_line): Use open_source_file_with_line_charpos.
2712         (search_command_helper): Use open_source_file_with_line_charpos
2713         instead of just open_source_file, remove call to
2714         find_source_lines.
2715         * source.h (open_source_file_with_line_charpos): Declare new
2716         function.
2717         (find_source_lines): Delete declaration.
2718
2719 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2720
2721         * source.c (get_filename_and_charpos): Remove fullname
2722         parameter.
2723         (identify_source_line): Update call to get_filename_and_charpos.
2724
2725 2019-06-14  Tom Tromey  <tromey@adacore.com>
2726
2727         PR gdb/24502:
2728         * ui-style.h (skip_ansi_escape): Update comment.
2729         * ui-file.h (class no_terminal_escape_file): New class.
2730         * ui-file.c (no_terminal_escape_file::write)
2731         (no_terminal_escape_file::puts): New methods.
2732         * cli/cli-logging.c (handle_redirections): Use
2733         no_terminal_escape_file.
2734
2735 2019-06-14  Tom Tromey  <tromey@adacore.com>
2736
2737         * NEWS: Move convenience variable news above Python news.
2738
2739 2019-06-14  Tom Tromey  <tom@tromey.com>
2740
2741         * gnulib: Move directory to top-level.
2742         * configure.ac: Don't configure gnulib.
2743         * configure: Rebuild.
2744         * common/common-defs.h: Use new path to gnulib.
2745         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2746         (GNULIB_H): Remove.
2747         (INCGNU): Look in new gnulib location.
2748         (HFILES_NO_SRCDIR): Remove gnulib files.
2749         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2750         (generated_files): Remove GNULIB_H.
2751         ($(LIBGNU), all-lib): Remove targets.
2752         (distclean): Don't mention GNULIB_BUILDDIR.
2753         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2754
2755 2019-06-14  Tom Tromey  <tromey@adacore.com>
2756
2757         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2758         Warn if symbol file does not provide any symbols.
2759
2760 2019-06-14  Tom Tromey  <tromey@adacore.com>
2761
2762         * source.c (find_and_open_source): Respect basenames_may_differ.
2763
2764 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2765
2766         * annotate.c (annotate_breakpoints_invalid): Make use of
2767         scoped_restore_terminal_state.
2768         (annotate_frames_invalid): Likewise.
2769
2770 2019-06-14  Tom Tromey  <tromey@adacore.com>
2771
2772         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2773         allow assignment to an internalvar.
2774
2775 2019-06-14  Tom Tromey  <tromey@adacore.com>
2776
2777         * ada-lex.l: Allow "_" in attribute names.
2778
2779 2019-06-14  Tom Tromey  <tromey@adacore.com>
2780
2781         PR gdb/24653:
2782         * regcache.c (registers_changed): Don't call alloca.
2783         * top.c (execute_command): Don't call alloca.
2784
2785 2019-06-13  Pedro Alves  <palves@redhat.com>
2786
2787         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2788         'expression'.  When parsing an expression, error out if there's
2789         junk after "unlimited".
2790         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2791         (do_set_command): Adjust calls to is_unlimited_literal.
2792
2793 2019-06-13  Pedro Alves  <palves@redhat.com>
2794
2795         * compile/compile.c (make_compile_options_def_group): Add braces
2796         around array_view initializer.
2797         * thread.c (make_thread_apply_all_options_def_group)
2798         (make_thread_apply_all_options_def_group): Likewise.
2799
2800 2019-06-13  Pedro Alves  <palves@redhat.com>
2801
2802         * NEWS (New commands): Mention "maint test-options
2803         require-delimiter", "maint test-options unknown-is-error", "maint
2804         test-options unknown-is-operand" and "maint show
2805         test-options-completion-result".
2806         (New command options, command completion): New section.
2807         (Completion improvements): New section.
2808         Mention that you can abbreviate "unlimited".
2809
2810 2019-06-13  Pedro Alves  <palves@redhat.com>
2811
2812         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2813         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2814         * unittests/cli-utils-selftests.c (test_parse_flags)
2815         (test_parse_flags_qcs): Delete.
2816         (test_cli_utils): Don't call deleted functions.
2817
2818 2019-06-13  Pedro Alves  <palves@redhat.com>
2819
2820         * thread.c: Include "cli/cli-option.h".
2821         (tp_array_compar_ascending): Global.
2822         (tp_array_compar): Delete function.
2823         (tp_array_compar_ascending, tp_array_compar_descending): New
2824         functions.
2825         (ascending_option_def, qcs_flag_option_def)
2826         (thr_qcs_flags_option_defs)
2827         (make_thread_apply_all_options_def_group)
2828         (make_thread_apply_options_def_group): New.
2829         (thread_apply_all_command): Use gdb::option::process_options.
2830         (thread_apply_command_completer)
2831         (thread_apply_all_command_completer): New.
2832         (thread_apply_command): Use gdb::option::process_options.
2833         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2834         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2835         to generate help text of "thread apply".  Adjust "taas"'s help.
2836         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2837         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2838
2839 2019-06-13  Pedro Alves  <palves@redhat.com>
2840
2841         * thread.c (thread_apply_command): Check for invalid TID with
2842         isdigit instead of !isalpha.
2843
2844 2019-06-13  Pedro Alves  <palves@redhat.com>
2845
2846         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2847         (validate_flags_qcs): New.
2848         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2849         (validate_flags_qcs): Declare.
2850         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2851         (make_frame_apply_options_def_group): New.
2852         (frame_apply_command_count): Process options with
2853         gdb::option::process_options.
2854         (frame_apply_completer): New.
2855         (frame_apply_level_completer, frame_apply_all_completer)
2856         (frame_apply_completer): New.
2857         (_initialize_stack): Update help of "frame apply", "frame apply
2858         level", "frame apply all" and "faas" to mention supported options
2859         and install command completers.
2860         * stack.h (frame_apply_all_completer): Declare.
2861         * thread.c: Include "stack.h".
2862         (tfaas_command): Add "--".
2863         (_initialize_thread): Update help "tfaas" to mention supported
2864         options and install command completer.
2865
2866 2019-06-13  Pedro Alves  <palves@redhat.com>
2867
2868         * completer.c (complete_nested_command_line): New.
2869         (gdb_completion_word_break_characters_throw): Add assertion.
2870         * completer.h (complete_nested_command_line): Declare.
2871
2872 2019-06-13  Pedro Alves  <palves@redhat.com>
2873
2874         * stack.c (parse_backtrace_qualifiers): New.
2875         (backtrace_command): Use it.
2876         (backtrace_command_completer): Complete on qualifiers.
2877
2878 2019-06-13  Pedro Alves  <palves@redhat.com>
2879
2880         * frame.c: Include "cli/cli-option.h.
2881         (user_set_backtrace_options): New.
2882         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2883         Delete.
2884         (get_prev_frame): Adjust.
2885         (boolean_option_def, uinteger_option_def)
2886         (set_backtrace_option_defs): New.
2887         (_initialize_frame): Adjust and use
2888         gdb::option::add_setshow_cmds_for_options to install "set
2889         backtrace past-main" and "set backtrace past-entry".
2890         * frame.h: Include "cli/cli-option.h".
2891         (struct frame_print_options): Forward declare.
2892         (print_frame_arguments_all, print_frame_arguments_scalars)
2893         (print_frame_arguments_none): Declare.
2894         (print_entry_values): Delete declaration.
2895         (struct frame_print_options, user_frame_print_options): New.
2896         (struct set_backtrace_options): New.
2897         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2898         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2899         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2900         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2901         (list_args_or_locals): Add frame_print_options parameter.
2902         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2903         * python/py-framefilter.c (enumerate_args): Pass down
2904         USER_FRAME_PRINT_OPTIONS.
2905         * stack.c: Include "cli/cli-option.h".
2906         (print_frame_arguments_all, print_frame_arguments_scalars)
2907         (print_frame_arguments_none): Declare.
2908         (print_raw_frame_arguments, print_entry_values): Delete.
2909         (user_frame_print_options): New.
2910         (boolean_option_def, enum_option_def, frame_print_option_defs):
2911         New.
2912         (struct backtrace_cmd_options): New.
2913         (bt_flag_option_def): New.
2914         (backtrace_command_option_defs): New.
2915         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2916         (print_frame_arg, read_frame_arg, print_frame_args)
2917         (print_frame_info, print_frame): Add frame_print_options parameter
2918         and use it.
2919         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2920         (backtrace_command_1): Add frame_print_options and
2921         backtrace_cmd_options parameters and use them.
2922         (make_backtrace_options_def_group): New.
2923         (backtrace_command): Process command options with
2924         gdb::option::process_options.
2925         (backtrace_command_completer): New.
2926         (_initialize_stack): Extend "backtrace"'s help to mention
2927         supported options.  Install completer for "backtrace".
2928         Install some settings commands with add_setshow_cmds_for_options.
2929
2930 2019-06-13  Pedro Alves  <palves@redhat.com>
2931
2932         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2933         and that "set/show print raw frame-arguments" are now deprecated.
2934
2935         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2936         command.
2937         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2938         * stack.c (_initialize_stack): Install "set/show print
2939         raw-frame-arguments", and deprecate "set/show print raw
2940         frame-arguments".
2941         * valprint.c (_initialize_valprint): Deprecate "set/show print
2942         raw".
2943
2944 2019-06-13  Pedro Alves  <palves@redhat.com>
2945
2946         * compile/compile.c (struct compile_options): New.
2947         (compile_flag_option_def, compile_command_option_defs)
2948         (make_compile_options_def_group): New.
2949         (compile_file_command): Handle options with
2950         gdb::option::process_options.
2951         (compile_file_command_completer): New function.
2952         (compile_code_command): Handle options with
2953         gdb::option::process_options.
2954         (compile_code_command_completer): New function.
2955         (_initialize_compiler): Install completers for "compile code" and
2956         "compile file".  Mention available options in "compile code" and
2957         "compile code"'s help.
2958         * completer.c (advance_to_completion_word): New, factored out from
2959         ...
2960         (advance_to_expression_complete_word_point): ... this.
2961         (advance_to_filename_complete_word_point): New.
2962         * completer.h (advance_to_filename_complete_word_point): New
2963         declaration.
2964
2965 2019-06-13  Pedro Alves  <palves@redhat.com>
2966
2967         * compile/compile.c: Include "cli/cli-option.h".
2968         (compile_print_value): Scope data pointer is now a
2969         value_print_options pointer; adjust.
2970         (compile_print_command): Process options.  Scope data pointer is
2971         now a value_print_options pointer; adjust.
2972         (_initialize_compile): Update "compile print"'s help to include
2973         supported options.  Install a completer for "compile print".
2974         * cp-valprint.c (show_vtblprint, show_objectprint)
2975         (show_static_field_print): Delete.
2976         (_initialize_cp_valprint): Don't install "set print
2977         static-members", "set print vtbl", "set print object" here.
2978         * printcmd.c: Include "cli/cli-option.h" and
2979         "common/gdb_optional.h".
2980         (print_command_parse_format): Rework to fill in a
2981         value_print_options instead of a format_data.
2982         (print_value): Change parameter type from format_data pointer to
2983         value_print_options reference.  Adjust.
2984         (print_command_1): Process options.  Adjust to pass down a
2985         value_print_options.
2986         (print_command_completer): New.
2987         (_initialize_printcmd): Install print_command_completer as
2988         handle_brkchars completer for the "print" command.  Update
2989         "print"'s help to include supported options.
2990         * valprint.c: Include "cli/cli-option.h".
2991         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2992         here from cp-valprint.c.
2993         (boolean_option_def, uinteger_option_def)
2994         (value_print_option_defs, make_value_print_options_def_group):
2995         New.  Use gdb::option::add_setshow_cmds_for_options to install
2996         "set print elements", "set print null-stop", "set print repeats",
2997         "set print pretty", "set print union", "set print array", "set
2998         print address", "set print symbol", "set print array-indexes".
2999         * valprint.h: Include <string> and "cli/cli-option.h".
3000         (make_value_print_options_def_group): Declare.
3001         (print_value): Change parameter type from format_data pointer to
3002         value_print_options reference.
3003         (print_command_completer): Declare.
3004
3005 2019-06-13  Pedro Alves  <palves@redhat.com>
3006
3007         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3008         (COMMON_SFILES): Add maint-test-settings.c.
3009         * cli/cli-decode.c (boolean_enums): New global, factored out from
3010         ...
3011         (add_setshow_boolean_cmd): ... here.
3012         * cli/cli-decode.h (boolean_enums): Declare.
3013         * cli/cli-option.c: New file.
3014         * cli/cli-option.h: New file.
3015         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3016         factored out from ...
3017         (parse_cli_boolean_value(const char *)): ... this.
3018         (is_unlimited_literal): Change parameter type to pointer to
3019         pointer.  Adjust and advance ARG pointer.
3020         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3021         (parse_cli_var_enum): New, factored out from ...
3022         (do_set_command): ... this.  Adjust.
3023         * cli/cli-setshow.h (parse_cli_boolean_value)
3024         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3025         (parse_cli_var_enum): Declare.
3026         * cli/cli-utils.c: Include "cli/cli-option.h".
3027         (get_ulongest): New.
3028         * cli/cli-utils.h (get_ulongest): Declare.
3029         (check_for_argument): New overloads.
3030         * maint-test-options.c: New file.
3031
3032 2019-06-13  Pedro Alves  <palves@redhat.com>
3033
3034         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3035         parse a range if "-" is at the end of the string.
3036
3037 2019-06-13  Pedro Alves  <palves@redhat.com>
3038
3039         * cli/cli-setshow.c (parse_auto_binary_operation)
3040         (parse_cli_boolean_value): Don't allow "o".
3041
3042 2019-06-13  Pedro Alves  <palves@redhat.com>
3043
3044         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3045         * NEWS: Mention maint test-settings KIND.
3046         * maint-test-settings.c: New file.
3047
3048 2019-06-13  Pedro Alves  <palves@redhat.com>
3049
3050         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3051         completer.
3052         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3053         "set" completers.
3054
3055 2019-06-13  Pedro Alves  <palves@redhat.com>
3056
3057         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3058         after item.
3059
3060 2019-06-13  Pedro Alves  <palves@redhat.com>
3061
3062         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3063
3064 2019-06-13  Pedro Alves <palves@redhat.com>
3065
3066         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3067         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3068         call.
3069         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3070         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3071         calls.
3072         (check_for_argument): Skip spaces after argument.
3073
3074 2019-06-13  Pedro Alves  <palves@redhat.com>
3075
3076         * thread.c (thread_apply_command): Adjust TID parsing.
3077         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3078         detected before end of string.
3079         (tid_is_in_list): Error out if LIST is invalid.
3080
3081 2019-06-13  Pedro Alves  <palves@redhat.com>
3082
3083         * completer.c (complete_line_internal_1): Rewind completion word
3084         point.
3085         (completion_tracker::advance_custom_word_point_by): Change
3086         parameter type to int.
3087         * completer.h (completion_tracker::advance_custom_word_point_by):
3088         Likewise.
3089
3090 2019-06-13  Pedro Alves  <palves@redhat.com>
3091
3092         * completer.c (advance_to_completion_word): Handle delimiters.
3093
3094 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3095
3096         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3097
3098 2019-06-11  Tom Tromey  <tom@tromey.com>
3099
3100         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3101         (xmalloc_failed): Move to alloc.c.
3102         * alloc.c: New file.
3103         * Makefile.in (COMMON_SFILES): Add alloc.c.
3104
3105 2019-06-11  Tom Tromey  <tom@tromey.com>
3106
3107         * nat/linux-waitpid.c: Don't include server.h.
3108         (linux_debug): Remove.
3109         (my_waitpid): Update.
3110
3111 2019-06-11  Tom Tromey  <tromey@adacore.com>
3112
3113         * infcall.c (_initialize_infcall): Remove trailing newline from
3114         help.
3115         * user-regs.c (_initialize_user_regs): Remove trailing newline
3116         from help.
3117         * typeprint.c (_initialize_typeprint): Remove trailing newline
3118         from help.
3119         * reverse.c (_initialize_reverse): Remove trailing newlines from
3120         help.
3121         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3122         from help.
3123         * language.c (add_set_language_command): Remove trailing newline
3124         from help.
3125         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3126         help.
3127         * disasm.c (_initialize_disasm): Remove trailing newline from
3128         help.
3129         * top.c (init_main): Remove trailing newline from help.
3130         * interps.c (_initialize_interpreter): Remove trailing newline
3131         from help.
3132         * btrace.c (_initialize_btrace): Remove trailing newlines from
3133         help.
3134         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3135         from help.
3136         * python/python.c (_initialize_python): Remove trailing newline
3137         from help.
3138         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3139         help.
3140         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3141         from help.  Reformat some text.
3142         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3143         from help.
3144         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3145         newline from help.
3146
3147 2019-06-11  Tom Tromey  <tromey@adacore.com>
3148
3149         * darwin-nat.c (darwin_decode_exception_message)
3150         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3151
3152 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3153
3154         * valops.c (value_slice): Check for not allocated or not
3155         associated values.
3156
3157 2019-06-10  Tom de Vries  <tdevries@suse.de>
3158
3159         PR gdb/24618
3160         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3161         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3162         invalid.
3163
3164 2019-06-10  Tom de Vries  <tdevries@suse.de>
3165
3166         PR gdb/24611
3167         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3168         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3169
3170 2019-06-10  Tom de Vries  <tdevries@suse.de>
3171
3172         PR symtab/24545
3173         * symtab.c (struct demangled_name_entry): Add language field.
3174         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3175         static minimal symbol".  Set and use language field.
3176
3177 2019-06-10  Tom Tromey  <tromey@adacore.com>
3178
3179         * ada-lang.c (_initialize_ada_language): Update help text.
3180
3181 2019-06-10  Tom Tromey  <tromey@adacore.com>
3182
3183         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3184         with a newline.
3185         * guile/guile.c (handle_boot_error): Don't end warning with a
3186         newline.
3187         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3188         warning with a newline.
3189         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3190         newline.
3191         (s12z_frame_cache): Likewise.
3192         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3193         a newline.
3194         * solib-svr4.c (disable_probes_interface): Don't end warning with
3195         a newline.
3196         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3197         newline.
3198         * python/python.c (do_finish_initialization): Don't end warning
3199         with a newline.
3200
3201 2019-06-10  Tom Tromey  <tom@tromey.com>
3202
3203         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3204         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3205         gdbpy_enter.
3206
3207 2019-06-10  Tom Tromey  <tromey@adacore.com>
3208
3209         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3210         data.
3211         (elf_new_init): Don't call stabsread_new_init.
3212         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3213         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3214         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3215
3216 2019-06-10  Tom de Vries  <tdevries@suse.de>
3217
3218         PR symtab/16264
3219         PR symtab/24517
3220         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3221
3222 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3223
3224         * source.c (find_and_open_source): Also rewrite relative file
3225         names.
3226
3227 2019-04-26  Amos Bird  <amosbird@gmail.com>
3228
3229         * annotate.c (annotate_thread_exited): Add "thread-exited"
3230         annotation.
3231
3232 2019-06-06  Tom Tromey  <tromey@adacore.com>
3233
3234         * maint.h (class scoped_command_stats): Use
3235         DISABLE_COPY_AND_ASSIGN.
3236         <print_time>: New method.
3237         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3238         print_time.
3239         (scoped_command_stats::print_time): New method.
3240
3241 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3242
3243         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3244         instructions of lengths 6 or 8 bytes.
3245
3246 2019-06-04  Pedro Alves  <palves@redhat.com>
3247
3248         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3249
3250         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3251         * breakpoint.c (condition_completer): Likewise.
3252         * cli/cli-dump.c (scan_expression): Likewise.
3253         * common/filestuff.c (mkdir_recursive): Likewise.
3254         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3255         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3256         (gdb_abspath): Likewise.
3257         * compile/compile-cplus-types.c
3258         (compile_cplus_instance::decl_name): Likewise.
3259         * completer.c (complete_explicit_location):
3260         (signal_completer, reg_or_group_completer_1): Likewise.
3261         * cp-support.c (cp_remove_params_if_any): Likewise.
3262         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3263         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3264         * infcmd.c (strip_bg_char): Likewise.
3265         * linespec.c (copy_token_string): Likewise.
3266         * mi/mi-main.c (output_cores): Likewise.
3267         * psymtab.c (psymtab_search_name):
3268         * symfile.c (test_set_ext_lang_command): Likewise.
3269         * target.c (target_fileio_read_stralloc): Likewise.
3270         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3271         * value.c (complete_internalvar): Likewise.
3272
3273 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3274
3275         Add objfile property to gdb.Type.
3276         * NEWS: Mention Python API addition.
3277         * python/py-type.c (typy_get_objfile): New method.
3278
3279 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3280
3281         * NEWS: Mention the new set|show style [title|highlight].
3282         Mention changes to "show style", "help" and "apropos".
3283
3284 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3285
3286         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3287         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3288         instead of print_help_for_command.
3289         (print_doc_of_command): New function.
3290         (help_list): Add 'apropos -v word' suggestion.
3291         (print_help_for_command): Style the command name using title style.
3292         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3293         (_initialize_cli_cmds): Describe -v in apropos_command help.
3294
3295 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3296
3297         * cli/cli-style.h (cli_style_option): Add name in constructor,
3298         add m_name class member, add constructor with intensity,
3299         add name class function.
3300         (cli_style_option::add_setshow_commands): Remove name argument.
3301         (highlight_style, title_style): New styles.
3302         * cli/cli-style.c (do_show): New function that shows a style
3303         characteristic styling the style name with itself.
3304         (set_style_name): New function.
3305         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3306         Update all callers according to the changes in cli/cli-style.h.
3307         * utils.h (fputs_highlighted): New function.
3308         * utils.c (fputs_highlighted): Likewise.
3309
3310 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3311
3312         * NEWS: Mention new pipe command and new convenience variables.
3313
3314 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3315
3316         * cli/cli-cmds.c (pipe_command): New function.
3317         (_initialize_cli_cmds): Call add_com for pipe_command.
3318         Define | as an alias for pipe.
3319         (exit_status_set_internal_vars): New function.
3320         (shell_escape): Call exit_status_set_internal_vars.
3321         cli/cli-decode.c (find_command_name_length): Recognize | as
3322         a single character command.
3323
3324 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3325
3326         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3327         top.c (execute_command_to_ui_file): New function, mostly a copy
3328         of execute_command_to_string.
3329         (execute_command_to_string): Implement by calling
3330         execute_command_to_ui_file.
3331
3332 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3333
3334         * top.h (saved_command_line): Remove declaration.
3335         * top.c (previous_saved_command_line, previous_repeat_arguments):
3336         New variables.
3337         (saved_command_line): Make static, define together with other
3338         'repeat variables'.
3339         (dont_repeat): Clear repeat_arguments.
3340         (repeat_previous, get_saved_command_line, save_command_line):
3341         New functions.
3342         (gdb_init): Initialize saved_command_line
3343         and previous_saved_command_line.
3344         * main.c (captured_main_1): Remove saved_command_line initialization.
3345         * event-top.c (handle_line_of_input): Update to use
3346         the new 'repeat' related functions instead of direct access to
3347         saved_command_line.
3348         * command.h (repeat_previous, get_saved_command_line,
3349         save_command_line): New declarations.
3350         (dont_repeat): Add comment.
3351
3352 2019-05-30  Tom Tromey  <tromey@adacore.com>
3353
3354         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3355         Fix comment.
3356         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3357
3358 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3359
3360         PR cli/24587
3361         * completer.c (complete): Initialize variable word.
3362
3363 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3364
3365         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3366         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3367         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3368         'body' is NULL to the outter 'if', protecting the '!is_define'
3369         situation as well.
3370
3371 2019-05-29  Tom Tromey  <tromey@adacore.com>
3372
3373         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3374         (dwarf_unknown): New function.
3375         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3376         (dwarf_type_encoding_name): Use dwarf_unknown.
3377
3378 2019-05-29  Tom Tromey  <tromey@adacore.com>
3379
3380         PR c++/20020:
3381         * cp-valprint.c (cp_print_value_fields): Call
3382         cp_print_static_field inside "try".
3383
3384 2019-05-29  Tom Tromey  <tromey@adacore.com>
3385
3386         * inflow.c (struct terminal_info): Add default operator=.
3387         * configure: Rebuild.
3388         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3389         -Wdeprecated-copy-dtor, -Wredundant-move.
3390
3391 2019-05-29  Tom Tromey  <tromey@adacore.com>
3392
3393         * NEWS: Add entry.
3394         * infcmd.c (print_return_value_1): Handle finish_print
3395         option.
3396         (show_print_finish): New function.
3397         (_initialize_infcmd): Add "set/show print finish" commands.
3398         * valprint.c (user_print_options): Initialize new member.
3399         * valprint.h (struct value_print_options) <finish_print>: New
3400         member.
3401
3402 2019-05-28  Tom Tromey  <tromey@adacore.com>
3403
3404         * ada-lang.c (ada_remove_Xbn_suffix)
3405         (find_old_style_renaming_symbol)
3406         (parse_old_style_renaming): Remove.
3407         (ada_find_renaming_symbol): Don't call
3408         find_old_style_renaming_symbol.
3409         (ada_is_renaming_symbol): Rename from
3410         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3411         bool.  Now static.
3412         (ada_read_var_value): Update and simplify.
3413         * ada-exp.y (write_var_or_type): Remove old code.
3414
3415 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3416
3417         * event-top.c: Remove include comment.
3418         * inflow.c (class scoped_ignore_sigttou): Move from here...
3419         * inflow.h (class scoped_ignore_sigttou): ...to here.
3420         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3421         * top.c:  Remove include comment.
3422
3423 2019-05-27  Tom Tromey  <tom@tromey.com>
3424
3425         * NEWS: Fix typo.
3426
3427 2019-05-22  Tom Tromey  <tromey@adacore.com>
3428
3429         * target.c (target_follow_exec): Constify parameter.
3430         * target-delegates.c: Rebuild.
3431         * remote.c (remote_target::follow_exec): Constify parameter.
3432         * infrun.c (follow_exec): Constify parameter.
3433         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3434         (target_follow_exec): Likewise.
3435
3436 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3437
3438         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3439         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3440
3441 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3442
3443         * NEWS: Add debugredirect and testsuite sections.
3444
3445 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3446
3447         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3448         target descriptions using exclusively floating point register name
3449         aliases.
3450
3451 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3452
3453         PR gdb/18644:
3454         * f-lang.c (build_fortran_types): Handle the case where
3455         gdbarch_floatformat_for_type returns a nullptr.
3456
3457 2019-05-21  Tom de Vries  <tdevries@suse.de>
3458
3459         PR cli/24587
3460         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3461
3462 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3463
3464         PR gdb/18644:
3465         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3466         16-byte floats.
3467         * i386-tdep.c (i386_floatformat_for_type): Use
3468         floatformats_ia64_quad for the 16-byte floating point component
3469         within a fortran 32-byte complex number.
3470
3471 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3472
3473         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3474         delete default constructor.
3475         (find_partial_die): Update to return const struct.
3476         (partial_die_parent_scope): Move variable declaration into scope
3477         of its use and change its type to auto.
3478         (guess_partial_die_structure_name): Likewise.
3479         (partial_die_info::fixup): Likewise.
3480
3481 2019-05-17  Tom Tromey  <tromey@adacore.com>
3482
3483         * source.c (find_and_open_source): Remove cast.
3484
3485 2019-05-17  Tom Tromey  <tromey@adacore.com>
3486
3487         * annotate.c (annotate_source): Make "filename" const.
3488         * annotate.h (annotate_source): Use const.
3489
3490 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3491
3492         * disasm.c (set_disassembler_options): Send errors to stderr.
3493
3494 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3495
3496         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3497         (cli_interp_base::set_logging): Check debug_redirect.
3498         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3499         * cli/cli-logging.c (debug_redirect): Add static variable.
3500         (pop_output_files): Add default param.
3501         (handle_redirections): Print debug setting.
3502         (show_logging_command): Likewise.
3503         (_initialize_cli_logging): Add debugredirect command.
3504         * interps.c (current_interp_set_logging): Add debug_redirect
3505         parameter.
3506         * interps.h (set_logging): Add debug_redirect parameter.
3507         (current_interp_set_logging): Likewise.
3508         * mi/mi-common.h: Likewise.
3509         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3510
3511 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3512             Tom Tromey  <tromey@adacore.com>
3513
3514         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3515         directly.
3516         * cli/cli-interp.h (make_logging_output): Remove declaration.
3517         * cli/cli-logging.c (make_logging_output): Remove function.
3518         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3519         directly.
3520         * ui-file.c (tee_file::tee_file): Remove bools.
3521         (tee_file::~tee_file): Remove deletes.
3522         * ui-file.h (tee_file): Remove bools.
3523
3524 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3525
3526         * mi/mi-cmds.h (mi_cmd_complete): New function.
3527         * mi/mi-main.c (mi_cmd_complete): Likewise.
3528         * mi/mi-cmds.c: Define new MI command -complete.
3529         * NEWS: Mention new -complete command.
3530
3531 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3532
3533         * completer.h (complete): New function.
3534         * completer.c (complete): Likewise.
3535         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3536         function defined in completer.h.
3537
3538 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3539
3540         * MAINTAINERS (Write After Approval): Add myself.
3541
3542 2019-05-17  Tom de Vries  <tdevries@suse.de>
3543
3544         PR gdb/24094
3545         * dwarf2read.c (struct cu_partial_die_info): New struct.
3546         (find_partial_die): Return cu_partial_die_info.
3547         (partial_die_parent_scope, guess_partial_die_structure_name)
3548         (partial_die_info::fixup): Handle new return type of find_partial_die.
3549
3550 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3551
3552         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3553         "std::string", simplifying the algorithm.
3554
3555 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3556
3557         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3558         (stap_static_probe_ops::get_probes): Likewise.
3559
3560 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3561
3562         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3563         '-')" and "else if".
3564         (stap_parse_single_operand): Join checks for
3565         "gdbarch_stap_parse_special_token_p" and
3566         "gdbarch_stap_parse_special_token" in the same "if" statement.
3567         Invert check when verifying for operation on register
3568         displacement.
3569
3570 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3571
3572         * stap-probe.c (stap_get_opcode): Update comment.
3573         (stap_get_expected_argument_type): Likewise.
3574         (handle_stap_probe): Likewise.
3575
3576 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3577
3578         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3579         return type to 'bool'.  Adjust comment.  Use 'bool' when
3580         appropriate.
3581         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3582         * stap-probe.c (stap_parse_argument_1): Likewise.
3583         (stap_is_operator): Likewise.
3584         (stap_is_generic_prefix): Likewise.
3585         (stap_is_register_prefix): Likewise.
3586         (stap_is_register_indirection_prefix): Likewise.
3587         (stap_is_integer_prefix): Likewise.
3588         (stap_generic_check_suffix): Likewise.
3589         (stap_check_integer_suffix): Likewise.
3590         (stap_check_register_suffix): Likewise.
3591         (stap_check_register_indirection_suffix): Likewise.
3592         (stap_parse_register_operand): Likewise.
3593         (stap_parse_single_operand): Likewise.
3594         (stap_parse_argument_1): Likewise.
3595         (stap_probe::get_argument_count): Likewise.
3596         (stap_is_operator): Likewise.
3597
3598 2019-05-16  Tom Tromey  <tromey@adacore.com>
3599
3600         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3601         keyword to foreach.
3602
3603 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3604
3605         * linux-thread-db.c (try_thread_db_load_1): Change return type
3606         to bool.
3607         (try_thread_db_load): Likewise.
3608         (try_thread_db_load_from_pdir_1): Likewise.
3609         (try_thread_db_load_from_pdir): Likewise.
3610         (try_thread_db_load_from_sdir): Likewise.
3611         (try_thread_db_load_from_dir): Likewise.
3612         (thread_db_load_search): Likewise.
3613         (has_libpthread): Likewise.
3614         (thread_db_load): Likewise.
3615
3616 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3617
3618         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3619         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3620         NULL, and complain/return if that's the case.
3621
3622 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3623
3624         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3625         (advance, posn, abstract_read_memory): New functions.
3626         [struct mem_read_abstraction]: New struct.
3627         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3628
3629 2019-05-14  Tom Tromey  <tromey@adacore.com>
3630
3631         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3632         value is not lval_memory.
3633
3634 2019-05-14  Tom Tromey  <tromey@adacore.com>
3635
3636         * solib.c (info_sharedlibrary_command): Style the file name.
3637
3638 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3639
3640         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3641         (aarch64_vnv_type): Likewise.
3642         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3643         * common/tdesc.c: Likewise.
3644         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3645         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3646         * features/aarch64-fpu.xml: Add ieee half view.
3647         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3648         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3649         * gdbtypes.h (struct builtin_type): Likewise.
3650         (struct objfile_type): Likewise.
3651
3652 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3653
3654         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3655         typo.
3656         * location.h (string_to_event_location): Likewise.
3657
3658 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3659
3660         GDB 8.3 released.
3661
3662 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3663
3664         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3665         New variable declaration.
3666         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3667         New variable.
3668         (print_one_breakpoint): Use ui_out::test_flags and new global
3669         variable to compute use_fixed_output.
3670         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3671         Remove.
3672         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3673         (mi_multi_location_breakpoint_output_fixed): Remove.
3674         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3675         new variable.
3676         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3677         fix_multi_location_breakpoint_output flag if version >= 3.
3678         * ui-out.h (enum ui_out_flag)
3679         <fix_multi_location_breakpoint_output>: New enumerator.
3680
3681 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3682
3683         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3684
3685 2019-05-10  Tom Tromey  <tromey@adacore.com>
3686
3687         * ada-lang.c (catch_ada_completer): New function.
3688         (_initialize_ada_language): Use it.
3689
3690 2019-05-10  Tom Tromey  <tromey@adacore.com>
3691
3692         * thread.c (print_thread_info): Make "requested_threads" const.
3693         * gdbthread.h (print_thread_info): Make "requested_threads"
3694         const.
3695         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3696         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3697
3698 2019-05-08  Tom Tromey  <tom@tromey.com>
3699
3700         * gdbtypes.c (objfile_type_data): Change type.
3701         (objfile_type, _initialize_gdbtypes): Update.
3702
3703 2019-05-08  Tom Tromey  <tom@tromey.com>
3704
3705         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3706         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3707         (_initialize_dwarf2_frame): Update.
3708
3709 2019-05-08  Tom Tromey  <tom@tromey.com>
3710
3711         * objc-lang.c (objc_objfile_data): Change type.
3712         (find_methods): Update.
3713         (_initialize_objc_lang): Remove.
3714
3715 2019-05-08  Tom Tromey  <tom@tromey.com>
3716
3717         * stabsread.c (rs6000_builtin_type_data): Change type.
3718         (rs6000_builtin_type, _initialize_stabsread): Update.
3719
3720 2019-05-08  Tom Tromey  <tom@tromey.com>
3721
3722         * mips-tdep.c (mips_pdr_data): Remove.
3723         (_initialize_mips_tdep): Update.
3724
3725 2019-05-08  Tom Tromey  <tom@tromey.com>
3726
3727         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3728         (hppa_init_objfile_priv_data, read_unwind_info)
3729         (find_unwind_entry, _initialize_hppa_tdep): Update.
3730
3731 2019-05-08  Tom Tromey  <tom@tromey.com>
3732
3733         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3734         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3735         on obstack.
3736         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3737
3738 2019-05-08  Tom Tromey  <tom@tromey.com>
3739
3740         * mdebugread.c (basic_type_data): Change type.
3741         (basic_type, _initialize_mdebugread): Update.
3742
3743 2019-05-08  Tom Tromey  <tom@tromey.com>
3744
3745         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3746
3747 2019-05-08  Tom Tromey  <tom@tromey.com>
3748
3749         * nto-tdep.c (nto_inferior_data_reg): Change type.
3750         (nto_inferior_data): Update.
3751         (nto_inferior_data_cleanup, nto_new_inferior_data)
3752         (_initialize_nto_tdep): Remove.
3753         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3754
3755 2019-05-08  Tom Tromey  <tom@tromey.com>
3756
3757         * ada-lang.c (struct ada_inferior_data): Add initializers.
3758         (ada_inferior_data): Change type.
3759         (ada_inferior_data_cleanup): Remove.
3760         (get_ada_inferior_data, ada_inferior_exit)
3761         (struct ada_pspace_data): Add initializers, destructor.
3762         (ada_pspace_data_handle): Change type.
3763         (get_ada_pspace_data): Update.
3764         (ada_pspace_data_cleanup): Remove.
3765
3766 2019-05-08  Tom Tromey  <tom@tromey.com>
3767
3768         * coffread.c (struct coff_symfile_info): Add initializers.
3769         (coff_objfile_data_key): Move lower.  Change type.
3770         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3771         Update.
3772         (coff_free_info): Remove.
3773
3774 2019-05-08  Tom Tromey  <tom@tromey.com>
3775
3776         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3777         (fbsd_pspace_data_handle): Move lower.  Change type.
3778         (get_fbsd_pspace_data): Update.
3779         (fbsd_pspace_data_cleanup): Remove.
3780         (_initialize_fbsd_tdep): Update.
3781
3782 2019-05-08  Tom Tromey  <tom@tromey.com>
3783
3784         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3785         (get_ada_tasks_pspace_data): Update.
3786         (ada_tasks_pspace_data_cleanup): Remove.
3787         (_initialize_tasks): Update.
3788         (ada_tasks_inferior_data_handle): Change type.
3789         (get_ada_tasks_inferior_data): Update.
3790         (ada_tasks_inferior_data_cleanup): Remove.
3791         (struct ada_tasks_pspace_data): Add initializers.
3792
3793 2019-05-08  Tom Tromey  <tom@tromey.com>
3794
3795         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3796         * symfile-debug.c (debug_sym_get_probes): Change type.
3797         * stap-probe.c (handle_stap_probe):
3798         (stap_static_probe_ops::get_probes): Change type.
3799         * probe.h (class static_probe_ops) <get_probes>: Change type.
3800         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3801         (parse_probes_in_pspace): Update.
3802         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3803         Update.
3804         (any_static_probe_ops::get_probes): Change type.
3805         * elfread.c (elfread_data): New typedef.
3806         (probe_key): Change type.
3807         (elf_get_probes): Likewise.  Update.
3808         (probe_key_free): Remove.
3809         (_initialize_elfread): Update.
3810         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3811         Change type.
3812         (dtrace_process_dof_probe, dtrace_process_dof)
3813         (dtrace_static_probe_ops::get_probe): Change type.
3814
3815 2019-05-08  Tom Tromey  <tom@tromey.com>
3816
3817         * xcoffread.c (struct xcoff_symfile_info): Rename from
3818         coff_symfile_info.  Add initializers.
3819         (xcoff_objfile_data_key): Move lower.  Change type.
3820         (XCOFF_DATA): Rewrite.
3821         (xcoff_free_info): Remove.
3822         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3823         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3824         (xcoff_initial_scan): Update.
3825
3826 2019-05-08  Tom Tromey  <tom@tromey.com>
3827
3828         * solib-svr4.c (struct svr4_info): Add initializers and
3829         destructor.
3830         <probes_table>: Now an htab_up.
3831         (solib_svr4_pspace_data): Change type.
3832         (free_probes_table): Simplify.
3833         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3834         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3835         (probes_table_remove_objfile_probes, register_solib_event_probe)
3836         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3837         (_initialize_svr4_solib): Update.
3838
3839 2019-05-08  Tom Tromey  <tom@tromey.com>
3840
3841         * remote.c (remote_pspace_data): Change type.
3842         (remote_pspace_data_cleanup): Remove.
3843         (get_remote_exec_file, set_pspace_remote_exec_file)
3844         (_initialize_remote): Update.
3845
3846 2019-05-08  Tom Tromey  <tom@tromey.com>
3847
3848         * breakpoint.c (breakpoint_objfile_key): Change type.
3849         (get_breakpoint_objfile_data): Update.
3850         (free_breakpoint_objfile_data): Remove.
3851         (_initialize_breakpoint): Update.
3852
3853 2019-05-08  Tom Tromey  <tom@tromey.com>
3854
3855         * linux-tdep.c (struct linux_info): Add initializers.
3856         (linux_inferior_data): Move.  Change type.
3857         (invalidate_linux_cache_inf): Update.
3858         (linux_inferior_data_cleanup): Remove.
3859         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3860
3861 2019-05-08  Tom Tromey  <tom@tromey.com>
3862
3863         * auxv.c (auxv_inferior_data): Move.  Change type.
3864         (auxv_inferior_data_cleanup): Remove.
3865         (invalidate_auxv_cache_inf): Rewrite.
3866         (get_auxv_inferior_data, _initialize_auxv): Update.
3867
3868 2019-05-08  Tom Tromey  <tom@tromey.com>
3869
3870         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3871         (symfile_debug_objfile_data_key): Change type.
3872         (symfile_debug_installed, debug_qf_has_symbols)
3873         (debug_qf_find_last_source_symtab)
3874         (debug_qf_forget_cached_source_info)
3875         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3876         (debug_qf_print_stats, debug_qf_dump)
3877         (debug_qf_expand_symtabs_for_function)
3878         (debug_qf_expand_all_symtabs)
3879         (debug_qf_expand_symtabs_with_fullname)
3880         (debug_qf_map_matching_symbols)
3881         (debug_qf_expand_symtabs_matching)
3882         (debug_qf_find_pc_sect_compunit_symtab)
3883         (debug_qf_map_symbol_filenames)
3884         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3885         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3886         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3887         (debug_sym_read_linetable, debug_sym_relocate): Update.
3888         (symfile_debug_free_objfile): Remove.
3889         (install_symfile_debug_logging, _initialize_symfile_debug):
3890         Update.
3891
3892 2019-05-08  Tom Tromey  <tom@tromey.com>
3893
3894         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3895         allocate_on_obstack.
3896         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3897         (get_dwarf2_per_objfile): Update.
3898         (set_dwarf2_per_objfile): Remove.
3899         (dwarf2_has_info, dwarf2_get_section_info): Update.
3900         (dwarf2_free_objfile): Remove.
3901         (_initialize_dwarf2_read): Update.
3902
3903 2019-05-08  Tom Tromey  <tom@tromey.com>
3904
3905         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3906         initializers.
3907         <unsupported_script_warning_printed,
3908         script_not_found_warning_printed>: Now bool.
3909         (auto_load_pspace_data): Change type.
3910         (~auto_load_pspace_info): Rename from
3911         auto_load_pspace_data_cleanup.
3912         (get_auto_load_pspace_data, init_loaded_scripts_info)
3913         (clear_section_scripts, maybe_print_unsupported_script_warning)
3914         (maybe_print_script_not_found_warning, _initialize_auto_load):
3915         Update.
3916
3917 2019-05-08  Tom Tromey  <tom@tromey.com>
3918
3919         * objfiles.c (objfile_pspace_info): Add destructor and
3920         initializers.
3921         (objfiles_pspace_data): Change type.
3922         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3923         (get_objfile_pspace_data): Update.
3924         (objfiles_bfd_data): Change type.
3925         (get_objfile_bfd_data): Update.
3926         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3927
3928 2019-05-08  Tom Tromey  <tom@tromey.com>
3929
3930         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3931         Change type.
3932         (get_catch_syscall_inferior_data): Update.
3933         (catch_syscall_inferior_data_cleanup): Remove.
3934         (_initialize_break_catch_syscall): Update.
3935
3936 2019-05-08  Tom Tromey  <tom@tromey.com>
3937
3938         * inflow.c (struct terminal_info): Add destructor and
3939         initializers.
3940         (inflow_inferior_data): Change type.
3941         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3942         (get_inflow_inferior_data, inflow_inferior_exit)
3943         (swap_terminal_info, _initialize_inflow): Update.
3944
3945 2019-05-08  Tom Tromey  <tom@tromey.com>
3946
3947         * target-dcache.c (target_dcache_cleanup): Remove.
3948         (target_dcache_aspace_key): Change type.
3949         (target_dcache_init_p, target_dcache_invalidate)
3950         (target_dcache_get, target_dcache_get_or_init)
3951         (_initialize_target_dcache): Update.
3952         * dcache.h (struct dcache_deleter): New.
3953
3954 2019-05-08  Tom Tromey  <tom@tromey.com>
3955
3956         * symtab.c (struct symbol_cache): Add destructor and
3957         initializers.
3958         (symbol_cache_key): Move.  Change type.
3959         (make_symbol_cache, free_symbol_cache): Remove.
3960         (get_symbol_cache): Update.
3961         (symbol_cache_cleanup): Remove.
3962         (ALL_PSPACES, symbol_cache_flush)
3963         (maintenance_print_symbol_cache)
3964         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3965         Update.
3966
3967 2019-05-08  Tom Tromey  <tom@tromey.com>
3968
3969         * symtab.c (struct main_info): Add destructor and initializers.
3970         (main_progspace_key): Move.  Change type.
3971         (get_main_info): Update.
3972         (main_info_cleanup): Remove.
3973         (_initialize_symtab): Update.
3974
3975 2019-05-08  Tom Tromey  <tom@tromey.com>
3976
3977         * registry.h (DECLARE_REGISTRY): Define the _key class.
3978
3979 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3980
3981         * NEWS: Merge two 'New commands' sections.
3982
3983 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3984
3985         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3986         parameter and use Ada language definition instead.
3987         (ada_val_print_ptr): Remove unused language parameter.
3988         (ada_val_print_num): Remove language parameter and use Ada language
3989         definition instead.
3990         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3991         parameter.
3992         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3993         parameter and use Ada language definition instead.
3994         (ada_val_print_1): Update all ada_val_print_xxx calls.
3995         Remove language parameter.
3996         (ada_val_print): Update ada_val_print_1 call.
3997
3998 2019-05-08  Tom Tromey  <tromey@adacore.com>
3999
4000         * remote.c (remote_hw_watchpoint_limit)
4001         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4002         Now static.
4003
4004 2019-05-08  Tom Tromey  <tromey@adacore.com>
4005
4006         * maint.c (_initialize_maint_cmds): Move initialization code to
4007         remote.c.
4008         (watchdog, show_watchdog): Move to remote.c.
4009         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4010         "watchdog" static.
4011         (_initialize_remote): Move initialization code from maint.c.
4012         * defs.h (watchdog): Don't declare.
4013
4014 2019-05-08  Tom Tromey  <tromey@adacore.com>
4015
4016         * tui/tui-interp.c: Include main.h.
4017         * interps.c: Include main.h.
4018         * main.h (interpreter_p): Declare.
4019         * defs.h (interpreter_p): Don't declare.
4020
4021 2019-05-08  Tom Tromey  <tromey@adacore.com>
4022
4023         * dwarf2loc.c: Include dwarf2read.h.
4024         * defs.h (read_unsigned_leb128): Don't declare.
4025         * dwarf2read.h (read_unsigned_leb128): Declare.
4026
4027 2019-05-08  Tom Tromey  <tromey@adacore.com>
4028
4029         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4030         method.
4031
4032 2019-05-08  Tom Tromey  <tromey@adacore.com>
4033
4034         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4035         when no wrap column is set.
4036
4037 2019-05-08  Tom Tromey  <tromey@adacore.com>
4038
4039         * c-lang.c (c_get_string): Handle non-C-style arrays.
4040
4041 2019-05-08  Tom Tromey  <tromey@adacore.com>
4042
4043         * typeprint.c (print_offset_data::update): Print the bit offset,
4044         not the number of bits remaining.
4045
4046 2019-05-08  Tom Tromey  <tromey@adacore.com>
4047
4048         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4049         padding at end of comment.
4050
4051 2019-05-08  Tom Tromey  <tromey@adacore.com>
4052
4053         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4054         Compare main types.
4055
4056 2019-05-06  Tom Tromey  <tom@tromey.com>
4057
4058         * common/scoped_mmap.c: Include common-defs.h.
4059         * common/scoped_mmap.h: Don't include config.h.
4060
4061 2019-05-04  Tom Tromey  <tom@tromey.com>
4062
4063         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4064         (struct aarch64_call_info): Add initializers.
4065         <si>: Now a std::vector.
4066         (pass_on_stack, aarch64_push_dummy_call): Update.
4067
4068 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4069             Tom Tromey  <tom@tromey.com>
4070
4071         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4072         (ppc_threads): Now a std::vector.  Now static.
4073         (hwdebug_find_thread_points_by_tid)
4074         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4075         Update.
4076
4077 2019-05-04  Tom Tromey  <tom@tromey.com>
4078
4079         * arc-tdep.c (arc_tdesc_init): Return bool.
4080
4081 2019-05-04  Tom Tromey  <tom@tromey.com>
4082
4083         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4084         Use gdb_assert_not_reached.
4085
4086 2019-05-04  Tom Tromey  <tom@tromey.com>
4087
4088         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4089         "false".
4090
4091 2019-05-04  Tom Tromey  <tom@tromey.com>
4092
4093         * arc-tdep.c (arc_tdesc_init): Use bool.
4094
4095 2019-05-04  Tom Tromey  <tom@tromey.com>
4096
4097         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4098
4099 2019-05-04  Tom Tromey  <tom@tromey.com>
4100
4101         * cli/cli-cmds.c (valid_command_p): Return bool.
4102
4103 2019-05-04  Tom Tromey  <tom@tromey.com>
4104
4105         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4106         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4107
4108 2019-05-04  Raul Tambre  <raul@tambre.ee>
4109
4110         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4111         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4112         operator for comparison.
4113
4114 2019-05-04  Tom Tromey  <tom@tromey.com>
4115
4116         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4117         (lookup_partial_symbol, print_partial_symbols)
4118         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4119         (psymbol_compare): Update.
4120         (add_psymbol_to_bcache): Clear the entire psymbol.
4121         (maintenance_check_psymtabs): Update.
4122         * psympriv.h (struct partial_symbol): Don't derive from
4123         general_symbol_info.
4124         <obj_section, unrelocated_address, address,
4125         set_unrelocated_address>: Update.
4126         <ginfo>: New member.
4127         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4128         (debug_names::write_psymbols): Update.
4129
4130 2019-05-04  Tom de Vries  <tdevries@suse.de>
4131
4132         * contrib/cc-with-tweaks.sh: Support -n arg.
4133
4134 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4135
4136         * corelow.c (core_target::detach): Ensure frame cache and
4137         register caches are cleared.
4138         inferior.c (exit_inferior_1): Likewise.
4139
4140 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4141             Tom Tromey  <tom@tromey.com>
4142
4143         * dictionary.c (collate_pending_symbols_by_language): Remove
4144         "struct" from foreach.
4145         * symtab.c (lookup_global_symbol_from_objfile)
4146         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4147         foreach.
4148         * ser-tcp.c (net_open): Remove "struct" from foreach.
4149         * objfiles.c (objfile_relocate, objfile_rebase)
4150         (objfile_has_symbols): Remove "struct" from foreach.
4151         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4152         from foreach.
4153         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4154         foreach.
4155         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4156         "struct" from foreach.
4157         * ada-lang.c (create_excep_cond_exprs)
4158         (ada_exception_catchpoint_cond_string): Remove "struct" from
4159         foreach.
4160
4161 2019-05-03  Tom Tromey  <tromey@adacore.com>
4162
4163         * ada-exp.y (convert_char_literal): Check suffix of each
4164         enumerator.
4165
4166 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4167
4168         PR ada/21406:
4169         * ada-exp.y (yywrap): Don't define.
4170         * ada-lex.l (%option): Add noyywrap
4171         (yywrap): Remove.
4172
4173 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4174
4175         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4176         _WIN32_WINNT to the XP level, unless already defined to a higher
4177         level.
4178
4179         * unittests/parse-connection-spec-selftests.c:
4180         * ser-tcp.c:
4181         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4182         override.
4183
4184         * symfile.c (find_separate_debug_file): Remove colon from the
4185         drive spec of DOS/Windows file names of the target, so that the
4186         file name produced from DEBUGDIR and the target's directory will
4187         be valid on DOS/Windows systems.
4188
4189 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4190
4191         * rust-lang.c (val_print_struct): Handle printing structures
4192         containing strings.
4193
4194 2019-05-02  Tom Tromey  <tromey@adacore.com>
4195
4196         * valarith.c (_initialize_valarith): Remove.
4197
4198 2019-05-01  Tom Tromey  <tromey@adacore.com>
4199
4200         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4201         bitfields.
4202
4203 2019-05-01  Tom Tromey  <tromey@adacore.com>
4204
4205         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4206         for big-endian copies.
4207
4208 2019-04-30  Ali Tamur  <tamur@google.com>
4209         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4210         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4211         (read_3_bytes): New function.
4212
4213 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4214
4215         * windows-nat.c (main_thread_id): Delete.
4216         (handle_output_debug_string): Replace main_thread_id by
4217         current_event.dwThreadId.
4218         (fake_create_process): Likewise.
4219         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4220         Do not set main_thread_id.
4221         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4222         current_event.dwThreadId.
4223         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4224
4225 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4226
4227         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4228         Use current_event.dwThreadId instead of main_thread_id.
4229
4230 2019-04-30  Tom Tromey  <tromey@adacore.com>
4231
4232         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4233         (create_excep_cond_exprs): Iterate over program spaces.
4234         (ada_exception_catchpoint_cond_string): Examine all minimal
4235         symbols for exception types.
4236
4237 2019-04-30  Tom Tromey  <tromey@adacore.com>
4238
4239         PR c++/24470:
4240         * dwarf2read.c (process_structure_scope): Handle case where type
4241         has template parameters but no symbol was created.
4242
4243 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4244             Chris January  <chris.january@arm.com>
4245
4246         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4247         qualifier.
4248         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4249
4250 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4251
4252         * f-typeprint.c (f_print_type): Update rules for printing
4253         whitespace.
4254         (f_type_print_varspec_suffix): Likewise.
4255
4256 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4257             Chris January  <chris.january@arm.com>
4258
4259         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4260         function arguments.
4261
4262 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4263
4264         * f-lang.c (build_fortran_types): Change name of void type to
4265         lower case.
4266         * f-typeprint.c (f_type_print_base): Print the name of the void
4267         type, rather than a fixed string.
4268         * f-valprint.c (f_decorations): Use lower case void string.
4269
4270 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4271             Chris January  <chris.january@arm.com>
4272
4273         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4274         types for Fortran.
4275
4276 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4277             Chris January  <chris.january@arm.com>
4278             David Lecomber  <david.lecomber@arm.com>
4279
4280         * f-exp.y (BINOP_INTRINSIC): New token.
4281         (exp): New parser rule handling BINOP_INTRINSIC.
4282         (f77_keywords): Add new builtin procedures.
4283         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4284         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4285         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4286         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4287         (print_unop_subexp_f): New function.
4288         (print_binop_subexp_f): New function.
4289         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4290         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4291         (dump_subexp_body_f): Likewise.
4292         (operator_check_f): Likewise.
4293         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4294         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4295
4296 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4297
4298         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4299         UNOP_KIND.
4300         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4301         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4302         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4303         (operator_length_f): New fuction.
4304         (print_subexp_f): New function.
4305         (op_name_f): New function.
4306         (dump_subexp_body_f): New function.
4307         (operator_check_f): New function.
4308         (exp_descriptor_f): Replace standard expression handling functions
4309         with new functions.
4310         * gdb/fortran-operator.def: New file.
4311         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4312         * gdb/std-operator.def: Remove UNOP_KIND.
4313
4314 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4315
4316         * std-operator.def: Remove unbalanced, stray double quote
4317         character.
4318
4319 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4320             Chris January  <chris.january@arm.com>
4321             Daniel Everett  <daniel.everett@arm.com>
4322             Nick Forrington  <nick.forrington@arm.com>
4323             Richard Bunt  <richard.bunt@arm.com>
4324
4325         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4326         of depth when printing anonymous structs or unions.
4327         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4328         Don't print either the top-level value, or the children if the
4329         max-depth is exceeded.
4330         (ppscm_print_children): When printing the key of a map, allow one
4331         extra level of depth.
4332         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4333         print either the top-level value, or the children if the max-depth
4334         is exceeded.
4335         (print_children): When printing the key of a map, allow one extra
4336         level of depth.
4337         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4338         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4339         (user_print_options): Initialise max_depth field.
4340         (val_print_scalar_or_string_type_p): New function.
4341         (val_print): Check to see if the max depth has been reached.
4342         (val_print_check_max_depth): Define new function.
4343         (show_print_max_depth): New function.
4344         (_initialize_valprint): Add 'print max-depth' option.
4345         * valprint.h (struct value_print_options) <max_depth>: New field.
4346         (val_print_check_max_depth): Declare new function.
4347         * NEWS: Document new feature.
4348
4349 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4350
4351         * ada-lang.c (ada_language_defn): Initialise new field.
4352         * c-lang.c (c_is_string_type_p): New function.
4353         (c_language_defn): Initialise new field.
4354         (cplus_language_defn): Initialise new field.
4355         (asm_language_defn): Initialise new field.
4356         (minimal_language_defn): Initialise new field.
4357         * c-lang.h (c_is_string_type_p): Declare new function.
4358         * d-lang.c (d_language_defn): Initialise new field.
4359         * f-lang.c (f_is_string_type_p): New function.
4360         (f_language_defn): Initialise new field.
4361         * go-lang.c (go_is_string_type_p): New function.
4362         (go_language_defn): Initialise new field.
4363         * language.c (default_is_string_type_p): New function.
4364         (unknown_language_defn): Initialise new field.
4365         (auto_language_defn): Initialise new field.
4366         * language.h (struct language_defn) <la_is_string_type_p>: New
4367         member variable.
4368         (default_is_string_type_p): Declare new function.
4369         * m2-lang.c (m2_language_defn): Initialise new field.
4370         * objc-lang.c (objc_language_defn): Initialise new field.
4371         * opencl-lang.c (opencl_language_defn): Initialise new field.
4372         * p-lang.c (pascal_is_string_type_p): New function.
4373         (pascal_language_defn): Initialise new field.
4374         * rust-lang.c (rust_is_string_type_p): New function.
4375         (rust_language_defn): Initialise new field.
4376
4377 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4378
4379         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4380         New field.
4381         * ada-lang.c (ada_language_defn): Initialise new field.
4382         * c-lang.c (c_language_defn): Likewise.
4383         (cplus_language_defn): Likewise.
4384         (asm_language_defn): Likewise.
4385         (minimal_language_defn): Likewise.
4386         * d-lang.c (d_language_defn): Likewise.
4387         * f-lang.c (f_language_defn): Likewise.
4388         * go-lang.c (go_language_defn): Likewise.
4389         * language.c (unknown_language_defn): Likewise.
4390         (auto_language_defn): Likewise.
4391         * m2-lang.c (m2_language_defn): Likewise.
4392         * objc-lang.c (objc_language_defn): Likewise.
4393         * opencl-lang.c (opencl_language_defn): Likewise.
4394         * p-lang.c (pascal_language_defn): Likewise.
4395         * rust-lang.c (rust_language_defn): Likewise.
4396
4397 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4398
4399         * ada-lang.c (ada_is_character_type): Change return type to bool.
4400         (ada_is_string_type): Likewise.
4401         * ada-lang.h (ada_is_character_type): Update declaration
4402         (ada_is_string_type): Likewise.
4403
4404 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4405
4406         Support style in 'frame|thread apply'
4407
4408         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4409         * record.c (record_start, record_stop): Update callers of
4410         execute_command_to_string with false.
4411         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4412         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4413         methods.
4414         (class string_file): New constructor with term_out parameter.
4415         Override methods term_out and can_emit_style_escape.  New member
4416         term_out.
4417         (class stdio_file): Override can_emit_style_escape.
4418         (class tee_file): Override term_out and can_emit_style_escape.
4419         * utils.h (can_emit_style_escape): Remove.
4420         * utils.c (can_emit_style_escape): Likewise.
4421         Update all callers of can_emit_style_escape (SOMESTREAM) to
4422         SOMESTREAM->can_emit_style_escape.
4423         * source-cache.c (source_cache::get_source_lines): Likewise.
4424         * stack.c (frame_apply_command_count): Call execute_command_to_string
4425         passing the term_out characteristic of the current gdb_stdout.
4426         * thread.c (thr_try_catch_cmd): Likewise.
4427         * top.c (execute_command_to_string): pass term_out parameter
4428         to construct the string_file for the command output.
4429         * ui-file.c (term_cli_styling): New function (most code moved
4430         from utils.c can_emit_style_escape).
4431         (string_file::string_file, string_file::can_emit_style_escape,
4432         stdio_file::can_emit_style_escape, tee_file::term_out,
4433         tee_file::can_emit_style_escape): New functions.
4434
4435 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4436
4437         * NEWS: Mention the new set|show may-call-functions.
4438         * infcall.c (may_call_functions_p): New variable.
4439         (show_may_call_functions_p): New function.
4440         (call_function_by_hand_dummy): Throws an error if not
4441         may-call-functions.
4442         (_initialize_infcall): Call add_setshow_boolean_cmd for
4443         may-call-functions.
4444
4445 2019-04-25  Keith Seitz  <keiths@redhat.com>
4446
4447         PR c++/24367
4448         * cp-support.c (inspect_type): Don't attempt substitutions
4449         of symbol with the same name.
4450
4451 2019-04-25  Tom Tromey  <tromey@adacore.com>
4452
4453         PR gdb/24475:
4454         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4455         static.
4456
4457 2019-04-25  Tom Tromey  <tromey@adacore.com>
4458
4459         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4460         rvalue reference.
4461         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4462         (gdb_xml_parser::parse): Use std::move.
4463         * python/python-internal.h (gdbpy_convert_exception): Take a const
4464         reference.
4465         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4466         std::move.
4467         * python/py-utils.c (gdbpy_convert_exception): Take a const
4468         reference.
4469         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4470         Use std::move.
4471         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4472         Use std::move.
4473         * mi/mi-main.c (mi_print_exception): Take a const reference.
4474         * main.c (handle_command_errors): Take a const reference.
4475         * linespec.c (parse_linespec): Use std::move.
4476         * infcall.c (run_inferior_call): Use std::move.
4477         (call_function_by_hand_dummy): Use std::move.
4478         * exec.c (try_open_exec_file): Use std::move.
4479         * exceptions.h (exception_print, exception_fprintf)
4480         (exception_print_same): Update.
4481         * exceptions.c (print_exception, exception_print)
4482         (exception_fprintf, exception_print_same): Change parameters to
4483         const reference.
4484         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4485         * common/new-op.c: Use std::move.
4486         * common/common-exceptions.h (struct gdb_exception): Add move
4487         constructor.
4488         (struct gdb_exception_error, struct gdb_exception_quit, struct
4489         gdb_quit_bad_alloc): Change constructor to move constructor.
4490         (throw_exception): Change parameter to rvalue reference.
4491         * common/common-exceptions.c (throw_exception): Take rvalue
4492         reference.
4493         * cli/cli-interp.c (safe_execute_command): Use std::move.
4494         * breakpoint.c (insert_bp_location, location_to_sals): Use
4495         std::move.
4496
4497 2019-04-25  Tom Tromey  <tromey@adacore.com>
4498
4499         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4500         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4501         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4502         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4503         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4504         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4505         guile/scm-value.c: Use unpack.
4506         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4507         gdbscm_gdb_exception.
4508         (gdbscm_throw_gdb_exception): Likewise.
4509         (struct gdbscm_gdb_exception): New.
4510         (unpack): New function.
4511         (gdbscm_wrap): Use unpack.
4512
4513 2019-04-25  Tom Tromey  <tromey@adacore.com>
4514
4515         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4516         (gdb_rl_callback_handler): Use std::move.
4517         * common/common-exceptions.h (struct gdb_exception): Add move
4518         assignment operator.
4519         (throw_exception_sjlj): Change "exception" to const reference.
4520         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4521         (throw_exception_sjlj): Change "exception" to const reference.
4522
4523 2019-04-25  Tom Tromey  <tromey@adacore.com>
4524
4525         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4526         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4527         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4528         Update.
4529         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4530         Update.
4531         * mi/mi-interp.c (mi_interp::exec): Update.
4532         * linespec.c (parse_linespec): Update.
4533         * infcall.c (run_inferior_call): Update.
4534         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4535         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4536         (gdbscm_lookup_global_symbol): Update.
4537         * guile/scm-param.c (gdbscm_parameter_value): Update.
4538         * guile/scm-frame.c (gdbscm_frame_read_register)
4539         (gdbscm_frame_read_var): Update.
4540         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4541         * exec.c (try_open_exec_file): Update.
4542         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4543         (gdb_rl_callback_handler): Update.
4544         * common/common-exceptions.h (exception_none): Don't declare.
4545         * common/common-exceptions.c (exception_none): Don't define.
4546         (struct catcher) <exception>: Update.
4547         * cli/cli-interp.c (safe_execute_command): Update.
4548         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4549
4550 2019-04-25  Ali Tamur  <tamur@google.com>
4551
4552         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4553         (read_attribute_value): Likewise.
4554         (dwarf2_read_addr_index): Update comment.
4555         (read_str_index): Add DW_FORM_strx.
4556         (dwarf2_string_attr): Likewise.
4557         (dwarf2_const_value_attr): Likewise.
4558         (dump_die_shallow): Likewise.
4559         (dwarf2_fetch_constant_bytes): Likewise.
4560         (skip_form_bytes): Likewise.
4561         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4562
4563 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4564
4565         PR corefiles/11608
4566         PR corefiles/18187
4567         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4568         OFFSET.  Verify if current mapping contains an ELF header.
4569         (linux_find_memory_regions_full): Adjust call to
4570         dump_mapping_p.
4571
4572 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4573             Kang Li <kanglictf@gmail.com>
4574
4575         PR gdb/21600
4576
4577         * dwarf2-frame.c (read_initial_length): Be consistent about using
4578         unsigned representation of length.
4579         (decode_frame_entry_1): Likewise.  Check for wraparound of
4580         end pointer as well as buffer overflow.
4581
4582 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4583
4584         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4585         "vq".
4586
4587 2019-04-24  Tom Tromey  <tromey@adacore.com>
4588
4589         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4590
4591 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4592
4593         * s12z-tdep.c (s12z_unwind_pc): Delete.
4594         (s12z_unwind_sp): Delete.
4595         (s12z_gdbarch_init): Don't register deleted functions with
4596         gdbarch.
4597
4598 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4599
4600         * rl78-tdep.c (rl78_unwind_sp): Delete.
4601         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4602
4603 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4604
4605         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4606         (xstormy16_unwind_pc): Delete.
4607         (xstormy16_dummy_id): Delete.
4608         (xstormy16_gdbarch_init): Don't register deleted functions with
4609         gdbarch.
4610
4611 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4612
4613         * vax-tdep.c (vax_unwind_pc): Delete.
4614         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4615
4616 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4617
4618         * v850-tdep.c (v850_unwind_sp): Delete.
4619         (v850_unwind_pc): Delete.
4620         (v850_dummy_id): Delete.
4621         (v850_gdbarch_init): Don't register deleted functions with
4622         gdbarch.
4623
4624 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4625
4626         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4627         (tilegx_unwind_pc): Delete.
4628         (tilegx_unwind_dummy_id): Delete.
4629         (tilegx_gdbarch_init): Don't register deleted functions with
4630         gdbarch.
4631
4632 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4633
4634         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4635         (tic6x_dummy_id): Delete.
4636         (tic6x_gdbarch_init): Don't register deleted functions with
4637         gdbarch.
4638
4639 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4640
4641         * sparc-tdep.c (sparc_unwind_pc): Delete.
4642         (sparc32_gdbarch_init): Don't register deleted function with
4643         gdbarch.
4644
4645 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4646
4647         * sh-tdep.c (sh_unwind_sp): Delete.
4648         (sh_unwind_pc): Delete.
4649         (sh_dummy_id): Delete.
4650         (sh_gdbarch_init): Don't register deleted functions with
4651         gdbarch.
4652
4653 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4654
4655         * score-tdep.c (score_unwind_sp): Delete.
4656         (score_unwind_pc): Delete.
4657         (score_dummy_id): Delete.
4658         (score_gdbarch_init): Don't register deleted functions with
4659         gdbarch.
4660
4661 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4662
4663         * rx-tdep.c (rx_unwind_pc): Delete.
4664         (rx_unwind_sp): Delete.
4665         (rx_dummy_id): Delete.
4666         (rx_gdbarch_init): Don't register deleted functions with
4667         gdbarch.  Update comment.
4668
4669 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4670
4671         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4672         (rs6000_dummy_id): Delete.
4673         (rs6000_gdbarch_init): Don't register deleted functions with
4674         gdbarch.
4675
4676 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4677
4678         * or1k-tdep.c (or1k_dummy_id): Delete.
4679         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4680
4681 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4682
4683         * nios2-tdep.c (nios2_dummy_id): Delete.
4684         (nios2_unwind_sp): Delete.
4685         (nios2_gdbarch_init): Don't register deleted functions with
4686         gdbarch.
4687
4688 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4689
4690         * nds32-tdep.c (nds32_dummy_id): Delete.
4691         (nds32_unwind_pc): Delete.
4692         (nds32_unwind_sp): Delete.
4693         (nds32_gdbarch_init): Don't register deleted functions with
4694         gdbarch.
4695
4696 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4697
4698         * msp430-tdep.c (msp430_unwind_pc): Delete.
4699         (msp430_unwind_sp): Delete.
4700         (msp430_dummy_id): Delete.
4701         (msp430_gdbarch_init): Don't register deleted functions with
4702         gdbarch.
4703
4704 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4705
4706         * moxie-tdep.c (moxie_unwind_sp): Delete.
4707         (moxie_unwind_pc): Delete.
4708         (moxie_dummy_id): Delete.
4709         (moxie_gdbarch_init): Don't register deleted functions with
4710         gdbarch.
4711
4712 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4713
4714         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4715         (mn10300_unwind_pc): Delete.
4716         (mn10300_unwind_sp): Delete.
4717         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4718         mn10300_unwind_sp.
4719         (mn10300_frame_unwind_init): Don't register deleted functions with
4720         gdbarch.
4721
4722 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4723
4724         * mep-tdep.c (mep_unwind_pc): Delete.
4725         (mep_unwind_sp): Delete.
4726         (mep_dummy_id): Delete.
4727         (mep_gdbarch_init): Don't register deleted functions with
4728         gdbarch.
4729
4730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4731
4732         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4733         (m68hc11_unwind_sp): Delete.
4734         (m68hc11_gdbarch_init): Don't register deleted functions with
4735         gdbarch.
4736
4737 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4738
4739         * m32r-tdep.c (m32r_unwind_sp): Delete.
4740         (m32r_unwind_pc): Delete.
4741         (m32r_dummy_id): Delete.
4742         (m32r_gdbarch_init): Don't register deleted functions with
4743         gdbarch.
4744
4745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4746
4747         * m32c-tdep.c (m32c_unwind_pc): Delete.
4748         (m32c_unwind_sp): Delete.
4749         (m32c_dummy_id): Delete.
4750         (m32c_gdbarch_init): Don't register deleted functions with
4751         gdbarch.
4752
4753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4754
4755         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4756         (lm32_unwind_pc): Delete.
4757         (lm32_dummy_id): Delete.
4758         (lm32_gdbarch_init): Don't register deleted functions with
4759         gdbarch.
4760
4761 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4762
4763         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4764         (iq2000_unwind_pc): Delete.
4765         (iq2000_dummy_id): Delete.
4766         (iq2000_gdbarch_init): Don't register deleted functions with
4767         gdbarch.
4768
4769 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4770
4771         * nds32-tdep.c (nds32_type_align): Delete.
4772         (nds32_push_dummy_call): Use type_align instead.
4773
4774 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4775
4776         * arm-tdep.c (arm_type_align): Only handle vector override case.
4777         (arm_push_dummy_call): Use type_align.
4778         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4779
4780 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4781
4782         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4783         case.
4784         (pass_on_stack): Use type_align.
4785         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4786         function.
4787
4788 2019-04-23  Tom Tromey  <tromey@adacore.com>
4789
4790         * dwarf2read.c (line_header::file_name_at): Remove unused
4791         overload.
4792
4793 2019-04-23  Tom de Vries  <tdevries@suse.de>
4794
4795         PR gdb/24438
4796         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4797         invocation.
4798
4799
4800 2019-03-27  Ali Tamur  <tamur@google.com>
4801
4802         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4803         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4804         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4805         (dwarf_expr_context::get_addr_index): Likewise
4806         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4807         (symbol_needs_eval_context::get_addr_index): Likewise
4808         (disassemble_dwarf_expression): Add DW_OP_addrx
4809         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4810         (read_cutu_die_from_dwo): Update comment
4811         (skip_one_die): Add DW_FORM_addrx
4812         (read_attribute_value): Likewise
4813         (var_decode_location): Add DW_OP_addrx
4814         (dwarf2_const_value_attr): Add DW_FORM_addrx
4815         (dump_die_shallow): Likewise
4816         (dwarf2_fetch_constant_bytes): Likewise
4817         (decode_locdesc): Add DW_OP_addrx
4818         (skip_form_bytes): Add DW_FORM_addrx
4819
4820 2019-04-22  Ali Tamur  <tamur@google.com>
4821
4822         * MAINTAINERS (Write After Approval): Add self.
4823
4824 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4825
4826         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4827         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4828         (open_symbol_file_object): Likewise.
4829         (svr4_default_sos): Add info parameter.
4830         (svr4_read_so_list): Likewise.
4831         (svr4_current_sos_direct): Adjust functions calls to pass down
4832         info.
4833         (svr4_current_sos_1): Add info parameter.
4834         (svr4_current_sos): Call get_svr4_info, pass info down to
4835         svr4_current_sos_1.
4836         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4837         get_svr4_info.
4838         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4839         get_svr4_info.
4840         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4841         to get_svr4_info.
4842         (probes_table_remove_objfile_probes): Likewise.
4843         (register_solib_event_probe): Add info parameter.
4844         (solist_update_incremental): Pass info parameter down to
4845         svr4_read_so_list.
4846         (disable_probes_interface): Add info parameter.
4847         (svr4_handle_solib_event): Pass current_program_space to
4848         get_svr4_info.  Adjust disable_probes_interface cleanup.
4849         (svr4_create_probe_breakpoints): Add info parameter, pass it
4850         down to register_solib_event_probe.
4851         (svr4_create_solib_event_breakpoints): Add info parameter,
4852         pass it down to svr4_create_probe_breakpoints.
4853         (enable_break): Pass info down to
4854         svr4_create_solib_event_breakpoints.
4855         (svr4_solib_create_inferior_hook): Pass current_program_space to
4856         get_svr4_info.
4857         (svr4_clear_solib): Likewise.
4858
4859 2019-04-22  Pedro Alves  <palves@redhat.com>
4860
4861         * solib-svr4.c (svr4_free_objfile_observer): New.
4862         (probe_and_action::objfile): New field.
4863         (probes_table_htab_remove_objfile_probes)
4864         (probes_table_remove_objfile_probes): New functions.
4865         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4866         in the new probe_and_action.  Don't store the probe in 'lookup'.
4867         (svr4_create_probe_breakpoints): Pass objfile to
4868         register_solib_event_probe.
4869         (_initialize_svr4_solib): Register a free_objfile observer.
4870
4871 2019-04-19  Tom Tromey  <tom@tromey.com>
4872
4873         * common/queue.h: Remove.
4874
4875 2019-04-19  Tom Tromey  <tom@tromey.com>
4876
4877         * event-loop.c: Don't include "common/queue.h".
4878
4879 2019-04-19  Tom Tromey  <tom@tromey.com>
4880
4881         * remote.c (remote_target): Use delete.
4882         * remote-notif.h: Include <list>, not "common/queue.h".
4883         (notif_client_p): Remove typedef.
4884         (remote_notif_state): Add constructor, destructor, initializer.
4885         <notif_queue>: Now a std::list.
4886         (remote_notif_state_xfree): Don't declare.
4887         * remote-notif.c (remote_notif_process, handle_notification)
4888         (remote_notif_state_allocate): Update.
4889         (~remote_notif_state): Rename from remote_notif_state_xfree.
4890
4891 2019-04-19  Tom Tromey  <tom@tromey.com>
4892
4893         * symfile.c (reread_symbols): Update.
4894         * objfiles.c (objfile_register_static_link)
4895         (objfile_lookup_static_link): Update
4896         (~objfile) Don't delete static_links.
4897         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4898
4899 2019-04-19  Tom Tromey  <tom@tromey.com>
4900
4901         * type-stack.h (struct type_stack) <insert>: Constify string.
4902         * type-stack.c (type_stack::insert): Constify string.
4903         * gdbtypes.h (lookup_template_type): Update.
4904         (address_space_name_to_int): Update.
4905         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4906         const.
4907         (lookup_template_type): Make name const.
4908         * c-exp.y: Update rules.
4909         (lex_one_token, classify_name, classify_inner_name)
4910         (c_print_token): Update.
4911         * p-exp.y: Update rules.
4912         (yylex): Update.
4913         * f-exp.y: Update rules.
4914         (yylex): Update.
4915         * d-exp.y: Update rules.
4916         (lex_one_token, classify_name, classify_inner_name): Update.
4917         * parse.c (write_dollar_variable, copy_name): Return std::string.
4918         * parser-defs.h (copy_name): Change return type.
4919         * m2-exp.y: Update rules.
4920         (yylex): Update.
4921         * go-exp.y (lex_one_token): Update.
4922         Update rules.
4923         (classify_unsafe_function, classify_packaged_name)
4924         (classify_name, yylex): Update.
4925
4926 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4927
4928         * configure.ac: add --enable-source-highlight switch.
4929         * configure: Regenerate.
4930         * top.c (print_gdb_version): plumb --enable-source-highlight
4931         status to "show configuration".
4932
4933 2019-04-19  Tom Tromey  <tromey@adacore.com>
4934
4935         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4936         Check ADA_TYPE_P.
4937         (empty_record, ada_template_to_fixed_record_type_1)
4938         (template_to_static_fixed_type)
4939         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4940         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4941         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4942         macros.
4943
4944 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4945
4946         PR symtab/24423:
4947         * source.c (print_source_lines_base): Advance "iter" when a
4948         control character is seen.
4949
4950 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4951
4952         * inferior.h (struct infcall_suspend_state_deleter):
4953         Catch exception in destructor to avoid crash.
4954
4955 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4956
4957         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4958         close to the add_com "shell".
4959
4960 2019-04-18  Tom Tromey  <tromey@adacore.com>
4961
4962         * process-stratum-target.h (class process_stratum_target)
4963         <stratum>: Add "final".
4964
4965 2019-04-17  Tom Tromey  <tromey@adacore.com>
4966
4967         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4968         against nullptr before use.
4969
4970 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4971
4972         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4973
4974 2019-04-17  Jim Wilson  <jimw@sifive.com>
4975             Andrew Burgess  <andrew.burgess@embecosm.com>
4976
4977         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4978         code read might fail, assume 4-byte breakpoint in that case.
4979
4980 2019-04-15  Leszek Swirski  <leszeks@google.com>
4981
4982         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4983         rather than a hand-rolled POD check when checking for forced MEMORY
4984         classification.
4985
4986 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4987
4988         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4989         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4990         function.
4991         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4992         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4993         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4994         declaration.
4995
4996 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4997
4998         * aarch64-linux-nat.c
4999         (aarch64_linux_nat_target::thread_architecture): Add override.
5000         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5001         each VQ.
5002
5003 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5004
5005         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5006
5007 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5008
5009         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5010         target types of size 96-bits, add some additional comments, and
5011         check that the builtin type we found was the correct size.
5012
5013 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5014
5015         * utils.c (prompt_for_continue): Don't restore the styling at the
5016         end, as applied_style has the wrong value.  This fixes styling in
5017         long lists of file names that are interrupted by the "Continue?"
5018         prompt.
5019
5020 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5021
5022         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5023         * c-lang.c (c_language_defn): Likewise.
5024         (cplus_language_defn): Likewise.
5025         (asm_language_defn): Likewise.
5026         (minimal_language_defn): Likewise.
5027         * d-lang.c (d_language_defn): Likewise.
5028         * f-lang.c (f_language_defn): Likewise.
5029         * go-lang.c (go_language_defn): Likewise.
5030         * language.c (unknown_language_defn): Likewise.
5031         (auto_language_defn): Likewise.
5032         * language.h (struct language_defn): Remove la_magic field.
5033         (LANG_MAGIC): Delete.
5034         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5035         * objc-lang.c (objc_language_defn): Likewise.
5036         * opencl-lang.c (opencl_language_defn): Likewise.
5037         * p-lang.c (pascal_language_defn): Likewise.
5038         * rust-lang.c (rust_language_defn): Likewise.
5039
5040 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5041
5042         * riscv-tdep.c (riscv_type_align): New function.
5043         (riscv_type_alignment): Delete.
5044         (riscv_arg_location): Use 'type_align'.
5045         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5046
5047 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5048
5049         * gdbtypes.c (type_align): A struct with no non-static fields also
5050         has alignment of 1.
5051
5052 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5053
5054         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5055         component to 0.
5056         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5057         member.
5058         (riscv_struct_info::analyse): New implementation using new
5059         analyse_inner member function.
5060         (riscv_struct_info::field_offset): New member function.
5061         (riscv_struct_info::m_offsets): New member variable.
5062         (riscv_struct_info::analyse_inner): New private member function,
5063         takes the old implementation of riscv_struct_info::analyse but
5064         extended to track field offsets.
5065         (riscv_call_arg_struct): Update the struct folding special cases
5066         to handle cases where empty C++ structs, which are non-zero
5067         length, are found.
5068         (riscv_arg_location): Initialise the length of each location, a
5069         non-zero length now indicates the location is in use.
5070         (riscv_push_dummy_call): Allow for the first location having a
5071         non-zero offset when setting up arguments.
5072         (riscv_return_value): Likewise, but for return values.
5073
5074 2019-04-11  Tom Tromey  <tromey@adacore.com>
5075
5076         * utils.c (internal_vproblem): Make "msg" const.
5077
5078 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5079
5080         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5081         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5082         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5083         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5084
5085 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5086
5087         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5088         function.
5089         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5090         of amd64_collect_native_gregset.
5091         (amd64_linux_nat_target::store_registers): Likewise.
5092
5093 2019-04-10  Tom Tromey  <tom@tromey.com>
5094
5095         * symtab.c (lookup_global_symbol_from_objfile)
5096         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5097         * objfiles.h (class separate_debug_iterator): New.
5098         (class separate_debug_range): New.
5099         (struct objfile) <separate_debug_objfiles>: New method.
5100         (objfile_separate_debug_iterate): Don't declare.
5101         * objfiles.c (separate_debug_iterator::operator++): Rename from
5102         objfile_separate_debug_iterate.
5103         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5104         iterator.
5105         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5106         iterator.
5107
5108 2019-04-10  Tom Tromey  <tom@tromey.com>
5109
5110         * symfile.c (reread_symbols): Remove old comment.
5111         * objfiles.c (free_all_objfiles): Fix a typo.
5112
5113 2019-04-10  Tom Tromey  <tom@tromey.com>
5114
5115         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5116         * minsyms.c (lookup_minimal_symbol): Use foreach.
5117         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5118         (lookup_minimal_symbol_solib_trampoline): Likewise.
5119         * symfile.c (reread_symbols): Use foreach.
5120
5121 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5122             Tom Tromey  <tromey@adacore.com>
5123
5124         PR rust/24414:
5125         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5126         (rust_lex_int_test): Change "value" to be LONGEST.
5127         (rust_lex_tests): Add test for long integer literal.
5128
5129 2019-04-09  Tom Tromey  <tromey@adacore.com>
5130
5131         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5132         to bool.
5133         (extended_remote_target::attach): Update.
5134         (remote_target::remote_notice_new_inferior): Update.
5135         (remote_target::add_current_inferior_and_thread): Update.
5136         * inferior.c (exit_inferior_1): Use "false".
5137         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5138
5139 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5140
5141         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5142         the "start" command.
5143
5144 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5145
5146         * python/py-inferior.c (infpy_thread_from_thread_handle):
5147         Adjust comments to reflect renaming of thread_from_thread_handle
5148         to thread_from_handle.  Adjust keywords.  Fix type error message.
5149         (inferior_object_methods): Add thread_from_handle.  Retain
5150         thread_from_thread_handle, but mark it as deprecated.
5151
5152 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5153
5154         * gdbthread.h (find_thread_by_handle): Revise declaration.
5155         * thread.c (find_thread_by_handle): Likewise.  Adjust
5156         implementation too.
5157         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5158         support for buffer objects as handles.
5159
5160 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5161
5162         * python/py-infthread.c (thpy_thread_handle): New function.
5163         (thread_object_methods): Register thpy_thread_handle.
5164
5165 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5166
5167         * gdbthread.h (thread_to_thread_handle): Declare.
5168         * thread.c (gdbtypes.h): Include.
5169         (thread_to_thread_handle): New function.
5170
5171         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5172         (target_thread_info_to_thread_handle): Declare.
5173         * target.c (target_thread_info_to_thread_handle): New function.
5174         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5175         * target-delegates.c: Regenerate.
5176
5177         * linux-thread-db.c (class thread_db_target): Add method
5178         thread_info_to_thread_handle.
5179         (thread_db_target::thread_info_to_thread_handle): Define.
5180         * remote.c (class remote_target): Add new method
5181         thread_info_to_thread_handle.
5182         (remote_target::thread_info_to_thread_handle): Define.
5183
5184 2019-04-08  Pedro Alves  <palves@redhat.com>
5185
5186         * common/common-exceptions.c (throw_exception): Don't create
5187         named object to throw; throw directly.
5188         (throw_it): Likewise.  Don't initialize gdb_exception::message
5189         here, with new; pass FMT and AP to the ctor instead.
5190         * common/common-exceptions.h: Include <string>.
5191         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5192         const char *, va_list)): New ctor.  Use std::make_shared.
5193         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5194         errors)): Delete.
5195         (gdb_exception_error::gdb_exception_error(enum errors, const char
5196         *, va_list)): New.
5197         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5198         Add assertion.
5199         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5200         errors)): Delete.
5201         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5202         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5203         Add assertion.
5204
5205 2019-04-08  Tom Tromey  <tom@tromey.com>
5206
5207         * valops.c (value_rtti_indirect_type): Replace throw_exception
5208         with throw.
5209         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5210         with throw.
5211         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5212         throw.
5213         * target.c (target_translate_tls_address): Replace throw_exception
5214         with throw.
5215         * stack.c (frame_apply_command_count): Replace throw_exception
5216         with throw.
5217         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5218         throw.
5219         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5220         with throw.
5221         * rs6000-tdep.c (rs6000_frame_cache)
5222         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5223         * remote.c: Replace throw_exception with throw.
5224         * record-full.c (record_full_message, record_full_wait_1)
5225         (record_full_restore): Replace throw_exception with throw.
5226         * record-btrace.c:
5227         (get_thread_current_frame_id, record_btrace_start_replaying)
5228         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5229         (cmd_record_btrace_start): Replace throw_exception with throw.
5230         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5231         throw.
5232         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5233         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5234         * linespec.c:
5235         (find_linespec_symbols): Replace throw_exception with throw.
5236         * infrun.c (displaced_step_prepare, resume): Replace
5237         throw_exception with throw.
5238         * infcmd.c (post_create_inferior): Replace throw_exception with
5239         throw.
5240         * inf-loop.c (inferior_event_handler): Replace throw_exception
5241         with throw.
5242         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5243         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5244         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5245         (get_prev_frame_always, get_frame_pc_if_available)
5246         (get_frame_address_in_block_if_available, get_frame_language):
5247         Replace throw_exception with throw.
5248         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5249         throw_exception with throw.
5250         * eval.c (fetch_subexp_value, evaluate_var_value)
5251         (evaluate_funcall, evaluate_subexp_standard): Replace
5252         throw_exception with throw.
5253         * dwarf2loc.c (call_site_find_chain)
5254         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5255         Replace throw_exception with throw.
5256         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5257         with throw.
5258         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5259         throw.
5260         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5261         * completer.c (complete_line_internal): Replace throw_exception
5262         with throw.
5263         * compile/compile-object-run.c (compile_object_run): Replace
5264         throw_exception with throw.
5265         * cli/cli-script.c (process_next_line): Replace throw_exception
5266         with throw.
5267         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5268         (btrace_enable, btrace_maint_update_pt_packets): Replace
5269         throw_exception with throw.
5270         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5271         throw_exception with throw.
5272         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5273         throw_exception with throw.
5274         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5275         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5276         * aarch64-tdep.c (aarch64_make_prologue_cache)
5277         (aarch64_make_stub_cache): Replace throw_exception with throw.
5278
5279 2019-04-08  Tom Tromey  <tom@tromey.com>
5280
5281         * common/common-exceptions.c (throw_exception): Rename from
5282         throw_exception_cxx.  Remove old copy.  Make argument const.
5283         (throw_it): Create and throw exception objects directly.
5284         * common/common-exceptions.h (throw_exception): Make argument
5285         const.
5286         (struct gdb_exception_error): Add constructor.
5287         (struct gdb_exception_quit): Add constructor.
5288
5289 2019-04-08  Tom Tromey  <tom@tromey.com>
5290
5291         * common/common-exceptions.h (exception_rethrow): Don't declare.
5292         (TRY_SJLJ): Update comment.
5293         (TRY, CATCH, END_CATCH): Remove.
5294         * common/common-exceptions.c (exception_rethrow): Remove.
5295
5296 2019-04-08  Tom Tromey  <tom@tromey.com>
5297
5298         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5299         Remove.
5300         (gdb_exception_error): Rename from
5301         gdb_exception_RETURN_MASK_ERROR.
5302         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5303         (gdb_quit_bad_alloc): Update.
5304         * aarch64-tdep.c: Update.
5305         * ada-lang.c: Update.
5306         * ada-typeprint.c: Update.
5307         * ada-valprint.c: Update.
5308         * amd64-tdep.c: Update.
5309         * arch-utils.c: Update.
5310         * break-catch-throw.c: Update.
5311         * breakpoint.c: Update.
5312         * btrace.c: Update.
5313         * c-varobj.c: Update.
5314         * cli/cli-cmds.c: Update.
5315         * cli/cli-interp.c: Update.
5316         * cli/cli-script.c: Update.
5317         * common/common-exceptions.c: Update.
5318         * common/new-op.c: Update.
5319         * common/selftest.c: Update.
5320         * compile/compile-c-symbols.c: Update.
5321         * compile/compile-cplus-symbols.c: Update.
5322         * compile/compile-object-load.c: Update.
5323         * compile/compile-object-run.c: Update.
5324         * completer.c: Update.
5325         * corelow.c: Update.
5326         * cp-abi.c: Update.
5327         * cp-support.c: Update.
5328         * cp-valprint.c: Update.
5329         * darwin-nat.c: Update.
5330         * disasm-selftests.c: Update.
5331         * dtrace-probe.c: Update.
5332         * dwarf-index-cache.c: Update.
5333         * dwarf-index-write.c: Update.
5334         * dwarf2-frame-tailcall.c: Update.
5335         * dwarf2-frame.c: Update.
5336         * dwarf2loc.c: Update.
5337         * dwarf2read.c: Update.
5338         * eval.c: Update.
5339         * event-loop.c: Update.
5340         * event-top.c: Update.
5341         * exec.c: Update.
5342         * f-valprint.c: Update.
5343         * fbsd-tdep.c: Update.
5344         * frame-unwind.c: Update.
5345         * frame.c: Update.
5346         * gdbtypes.c: Update.
5347         * gnu-v3-abi.c: Update.
5348         * guile/guile-internal.h: Update.
5349         * guile/scm-block.c: Update.
5350         * guile/scm-breakpoint.c: Update.
5351         * guile/scm-cmd.c: Update.
5352         * guile/scm-disasm.c: Update.
5353         * guile/scm-frame.c: Update.
5354         * guile/scm-lazy-string.c: Update.
5355         * guile/scm-math.c: Update.
5356         * guile/scm-param.c: Update.
5357         * guile/scm-ports.c: Update.
5358         * guile/scm-pretty-print.c: Update.
5359         * guile/scm-symbol.c: Update.
5360         * guile/scm-symtab.c: Update.
5361         * guile/scm-type.c: Update.
5362         * guile/scm-value.c: Update.
5363         * i386-linux-tdep.c: Update.
5364         * i386-tdep.c: Update.
5365         * inf-loop.c: Update.
5366         * infcall.c: Update.
5367         * infcmd.c: Update.
5368         * infrun.c: Update.
5369         * jit.c: Update.
5370         * language.c: Update.
5371         * linespec.c: Update.
5372         * linux-fork.c: Update.
5373         * linux-nat.c: Update.
5374         * linux-tdep.c: Update.
5375         * linux-thread-db.c: Update.
5376         * main.c: Update.
5377         * mi/mi-cmd-break.c: Update.
5378         * mi/mi-cmd-stack.c: Update.
5379         * mi/mi-interp.c: Update.
5380         * mi/mi-main.c: Update.
5381         * objc-lang.c: Update.
5382         * p-valprint.c: Update.
5383         * parse.c: Update.
5384         * ppc-linux-tdep.c: Update.
5385         * printcmd.c: Update.
5386         * python/py-arch.c: Update.
5387         * python/py-breakpoint.c: Update.
5388         * python/py-cmd.c: Update.
5389         * python/py-finishbreakpoint.c: Update.
5390         * python/py-frame.c: Update.
5391         * python/py-framefilter.c: Update.
5392         * python/py-gdb-readline.c: Update.
5393         * python/py-inferior.c: Update.
5394         * python/py-infthread.c: Update.
5395         * python/py-lazy-string.c: Update.
5396         * python/py-linetable.c: Update.
5397         * python/py-objfile.c: Update.
5398         * python/py-param.c: Update.
5399         * python/py-prettyprint.c: Update.
5400         * python/py-progspace.c: Update.
5401         * python/py-record-btrace.c: Update.
5402         * python/py-record.c: Update.
5403         * python/py-symbol.c: Update.
5404         * python/py-type.c: Update.
5405         * python/py-unwind.c: Update.
5406         * python/py-utils.c: Update.
5407         * python/py-value.c: Update.
5408         * python/python.c: Update.
5409         * record-btrace.c: Update.
5410         * record-full.c: Update.
5411         * remote-fileio.c: Update.
5412         * remote.c: Update.
5413         * riscv-tdep.c: Update.
5414         * rs6000-aix-tdep.c: Update.
5415         * rs6000-tdep.c: Update.
5416         * rust-exp.y: Update.
5417         * rust-lang.c: Update.
5418         * s390-tdep.c: Update.
5419         * selftest-arch.c: Update.
5420         * solib-dsbt.c: Update.
5421         * solib-frv.c: Update.
5422         * solib-spu.c: Update.
5423         * solib-svr4.c: Update.
5424         * solib.c: Update.
5425         * sparc64-linux-tdep.c: Update.
5426         * stack.c: Update.
5427         * symfile-mem.c: Update.
5428         * symmisc.c: Update.
5429         * target.c: Update.
5430         * thread.c: Update.
5431         * top.c: Update.
5432         * tracefile-tfile.c: Update.
5433         * tui/tui.c: Update.
5434         * typeprint.c: Update.
5435         * unittests/cli-utils-selftests.c: Update.
5436         * unittests/parse-connection-spec-selftests.c: Update.
5437         * valops.c: Update.
5438         * valprint.c: Update.
5439         * value.c: Update.
5440         * varobj.c: Update.
5441         * windows-nat.c: Update.
5442         * x86-linux-nat.c: Update.
5443         * xml-support.c: Update.
5444
5445 2019-04-08  Tom Tromey  <tom@tromey.com>
5446
5447         * xml-support.c: Use C++ exception handling.
5448         * x86-linux-nat.c: Use C++ exception handling.
5449         * windows-nat.c: Use C++ exception handling.
5450         * varobj.c: Use C++ exception handling.
5451         * value.c: Use C++ exception handling.
5452         * valprint.c: Use C++ exception handling.
5453         * valops.c: Use C++ exception handling.
5454         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5455         handling.
5456         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5457         * typeprint.c: Use C++ exception handling.
5458         * tui/tui.c: Use C++ exception handling.
5459         * tracefile-tfile.c: Use C++ exception handling.
5460         * top.c: Use C++ exception handling.
5461         * thread.c: Use C++ exception handling.
5462         * target.c: Use C++ exception handling.
5463         * symmisc.c: Use C++ exception handling.
5464         * symfile-mem.c: Use C++ exception handling.
5465         * stack.c: Use C++ exception handling.
5466         * sparc64-linux-tdep.c: Use C++ exception handling.
5467         * solib.c: Use C++ exception handling.
5468         * solib-svr4.c: Use C++ exception handling.
5469         * solib-spu.c: Use C++ exception handling.
5470         * solib-frv.c: Use C++ exception handling.
5471         * solib-dsbt.c: Use C++ exception handling.
5472         * selftest-arch.c: Use C++ exception handling.
5473         * s390-tdep.c: Use C++ exception handling.
5474         * rust-lang.c: Use C++ exception handling.
5475         * rust-exp.y: Use C++ exception handling.
5476         * rs6000-tdep.c: Use C++ exception handling.
5477         * rs6000-aix-tdep.c: Use C++ exception handling.
5478         * riscv-tdep.c: Use C++ exception handling.
5479         * remote.c: Use C++ exception handling.
5480         * remote-fileio.c: Use C++ exception handling.
5481         * record-full.c: Use C++ exception handling.
5482         * record-btrace.c: Use C++ exception handling.
5483         * python/python.c: Use C++ exception handling.
5484         * python/py-value.c: Use C++ exception handling.
5485         * python/py-utils.c: Use C++ exception handling.
5486         * python/py-unwind.c: Use C++ exception handling.
5487         * python/py-type.c: Use C++ exception handling.
5488         * python/py-symbol.c: Use C++ exception handling.
5489         * python/py-record.c: Use C++ exception handling.
5490         * python/py-record-btrace.c: Use C++ exception handling.
5491         * python/py-progspace.c: Use C++ exception handling.
5492         * python/py-prettyprint.c: Use C++ exception handling.
5493         * python/py-param.c: Use C++ exception handling.
5494         * python/py-objfile.c: Use C++ exception handling.
5495         * python/py-linetable.c: Use C++ exception handling.
5496         * python/py-lazy-string.c: Use C++ exception handling.
5497         * python/py-infthread.c: Use C++ exception handling.
5498         * python/py-inferior.c: Use C++ exception handling.
5499         * python/py-gdb-readline.c: Use C++ exception handling.
5500         * python/py-framefilter.c: Use C++ exception handling.
5501         * python/py-frame.c: Use C++ exception handling.
5502         * python/py-finishbreakpoint.c: Use C++ exception handling.
5503         * python/py-cmd.c: Use C++ exception handling.
5504         * python/py-breakpoint.c: Use C++ exception handling.
5505         * python/py-arch.c: Use C++ exception handling.
5506         * printcmd.c: Use C++ exception handling.
5507         * ppc-linux-tdep.c: Use C++ exception handling.
5508         * parse.c: Use C++ exception handling.
5509         * p-valprint.c: Use C++ exception handling.
5510         * objc-lang.c: Use C++ exception handling.
5511         * mi/mi-main.c: Use C++ exception handling.
5512         * mi/mi-interp.c: Use C++ exception handling.
5513         * mi/mi-cmd-stack.c: Use C++ exception handling.
5514         * mi/mi-cmd-break.c: Use C++ exception handling.
5515         * main.c: Use C++ exception handling.
5516         * linux-thread-db.c: Use C++ exception handling.
5517         * linux-tdep.c: Use C++ exception handling.
5518         * linux-nat.c: Use C++ exception handling.
5519         * linux-fork.c: Use C++ exception handling.
5520         * linespec.c: Use C++ exception handling.
5521         * language.c: Use C++ exception handling.
5522         * jit.c: Use C++ exception handling.
5523         * infrun.c: Use C++ exception handling.
5524         * infcmd.c: Use C++ exception handling.
5525         * infcall.c: Use C++ exception handling.
5526         * inf-loop.c: Use C++ exception handling.
5527         * i386-tdep.c: Use C++ exception handling.
5528         * i386-linux-tdep.c: Use C++ exception handling.
5529         * guile/scm-value.c: Use C++ exception handling.
5530         * guile/scm-type.c: Use C++ exception handling.
5531         * guile/scm-symtab.c: Use C++ exception handling.
5532         * guile/scm-symbol.c: Use C++ exception handling.
5533         * guile/scm-pretty-print.c: Use C++ exception handling.
5534         * guile/scm-ports.c: Use C++ exception handling.
5535         * guile/scm-param.c: Use C++ exception handling.
5536         * guile/scm-math.c: Use C++ exception handling.
5537         * guile/scm-lazy-string.c: Use C++ exception handling.
5538         * guile/scm-frame.c: Use C++ exception handling.
5539         * guile/scm-disasm.c: Use C++ exception handling.
5540         * guile/scm-cmd.c: Use C++ exception handling.
5541         * guile/scm-breakpoint.c: Use C++ exception handling.
5542         * guile/scm-block.c: Use C++ exception handling.
5543         * guile/guile-internal.h: Use C++ exception handling.
5544         * gnu-v3-abi.c: Use C++ exception handling.
5545         * gdbtypes.c: Use C++ exception handling.
5546         * frame.c: Use C++ exception handling.
5547         * frame-unwind.c: Use C++ exception handling.
5548         * fbsd-tdep.c: Use C++ exception handling.
5549         * f-valprint.c: Use C++ exception handling.
5550         * exec.c: Use C++ exception handling.
5551         * event-top.c: Use C++ exception handling.
5552         * event-loop.c: Use C++ exception handling.
5553         * eval.c: Use C++ exception handling.
5554         * dwarf2read.c: Use C++ exception handling.
5555         * dwarf2loc.c: Use C++ exception handling.
5556         * dwarf2-frame.c: Use C++ exception handling.
5557         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5558         * dwarf-index-write.c: Use C++ exception handling.
5559         * dwarf-index-cache.c: Use C++ exception handling.
5560         * dtrace-probe.c: Use C++ exception handling.
5561         * disasm-selftests.c: Use C++ exception handling.
5562         * darwin-nat.c: Use C++ exception handling.
5563         * cp-valprint.c: Use C++ exception handling.
5564         * cp-support.c: Use C++ exception handling.
5565         * cp-abi.c: Use C++ exception handling.
5566         * corelow.c: Use C++ exception handling.
5567         * completer.c: Use C++ exception handling.
5568         * compile/compile-object-run.c: Use C++ exception handling.
5569         * compile/compile-object-load.c: Use C++ exception handling.
5570         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5571         * compile/compile-c-symbols.c: Use C++ exception handling.
5572         * common/selftest.c: Use C++ exception handling.
5573         * common/new-op.c: Use C++ exception handling.
5574         * cli/cli-script.c: Use C++ exception handling.
5575         * cli/cli-interp.c: Use C++ exception handling.
5576         * cli/cli-cmds.c: Use C++ exception handling.
5577         * c-varobj.c: Use C++ exception handling.
5578         * btrace.c: Use C++ exception handling.
5579         * breakpoint.c: Use C++ exception handling.
5580         * break-catch-throw.c: Use C++ exception handling.
5581         * arch-utils.c: Use C++ exception handling.
5582         * amd64-tdep.c: Use C++ exception handling.
5583         * ada-valprint.c: Use C++ exception handling.
5584         * ada-typeprint.c: Use C++ exception handling.
5585         * ada-lang.c: Use C++ exception handling.
5586         * aarch64-tdep.c: Use C++ exception handling.
5587
5588 2019-04-08  Tom Tromey  <tom@tromey.com>
5589
5590         * xml-support.c (gdb_xml_parser::parse): Update.
5591         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5592         * value.c (show_convenience): Update.
5593         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5594         (test_parse_flags_qcs): Update.
5595         * thread.c (thr_try_catch_cmd): Update.
5596         * target.c (target_translate_tls_address): Update.
5597         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5598         (info_frame_command_core, frame_apply_command_count): Update.
5599         * rust-exp.y (rust_lex_exception_test): Update.
5600         * riscv-tdep.c (riscv_print_one_register_info): Update.
5601         * remote.c (remote_target::enable_btrace): Update.
5602         * record-btrace.c (record_btrace_enable_warn): Update.
5603         * python/py-utils.c (gdbpy_convert_exception): Update.
5604         * printcmd.c (do_one_display, print_variable_and_value): Update.
5605         * mi/mi-main.c (mi_print_exception): Update.
5606         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5607         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5608         * linux-nat.c (linux_nat_target::attach): Update.
5609         * linux-fork.c (class scoped_switch_fork_info): Update.
5610         * infrun.c (displaced_step_prepare): Update.
5611         * infcall.c (call_function_by_hand_dummy): Update.
5612         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5613         * gnu-v3-abi.c (print_one_vtable): Update.
5614         * frame.c (get_prev_frame_always): Update.
5615         * f-valprint.c (info_common_command_for_block): Update.
5616         * exec.c (try_open_exec_file): Update.
5617         * exceptions.c (print_exception, exception_print)
5618         (exception_fprintf, exception_print_same): Update.
5619         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5620         * dwarf-index-cache.c (index_cache::store)
5621         (index_cache::lookup_gdb_index): Update.
5622         * darwin-nat.c (maybe_cache_shell): Update.
5623         * cp-valprint.c (cp_print_value_fields): Update.
5624         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5625         (gcc_cplus_symbol_address): Update.
5626         * compile/compile-c-symbols.c (gcc_convert_symbol)
5627         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5628         * common/selftest.c: Update.
5629         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5630         a std::string.
5631         (exception_try_scope_entry, exception_try_scope_exit): Don't
5632         declare.
5633         (struct exception_try_scope): Remove.
5634         (TRY): Don't use exception_try_scope.
5635         (struct gdb_exception): Add constructor, operator=.
5636         <what>: New method.
5637         (struct gdb_exception_RETURN_MASK_ALL)
5638         (struct gdb_exception_RETURN_MASK_ERROR)
5639         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5640         (struct gdb_quit_bad_alloc): Update.
5641         * common/common-exceptions.c (exception_none): Change
5642         initializer.
5643         (struct catcher) <state, exception>: Initialize inline.
5644         <prev>: Remove member.
5645         (current_catcher): Remove.
5646         (catchers): New global.
5647         (exceptions_state_mc_init): Simplify.
5648         (catcher_pop): Remove.
5649         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5650         (try_scope_depth, exception_try_scope_entry)
5651         (exception_try_scope_exit): Remove.
5652         (throw_exception_sjlj): Update.
5653         (exception_messages, exception_messages_size): Remove.
5654         (throw_it): Simplify.
5655         (gdb_exception_sliced_copy): Remove.
5656         (throw_exception_cxx): Update.
5657         * cli/cli-script.c (script_from_file): Update.
5658         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5659         Update.
5660         * ada-valprint.c (ada_val_print): Update.
5661         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5662         (create_excep_cond_exprs): Update.
5663
5664 2019-04-08  Tom Tromey  <tom@tromey.com>
5665
5666         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5667         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5668         (TRY, CATCH, END_CATCH): Remove some definitions.
5669         * common/common-exceptions.c: Don't use GDB_XCPT.
5670         (catcher_list_size): Remove.
5671         (throw_exception, throw_it): Simplify.
5672
5673 2019-04-05  Tom Tromey  <tom@tromey.com>
5674
5675         Revert the header-sorting patch.
5676         * ft32-tdep.c: Revert.
5677         * frv-tdep.c: Revert.
5678         * frv-linux-tdep.c: Revert.
5679         * frame.c: Revert.
5680         * frame-unwind.c: Revert.
5681         * frame-base.c: Revert.
5682         * fork-child.c: Revert.
5683         * findvar.c: Revert.
5684         * findcmd.c: Revert.
5685         * filesystem.c: Revert.
5686         * filename-seen-cache.h: Revert.
5687         * filename-seen-cache.c: Revert.
5688         * fbsd-tdep.c: Revert.
5689         * fbsd-nat.h: Revert.
5690         * fbsd-nat.c: Revert.
5691         * f-valprint.c: Revert.
5692         * f-typeprint.c: Revert.
5693         * f-lang.c: Revert.
5694         * extension.h: Revert.
5695         * extension.c: Revert.
5696         * extension-priv.h: Revert.
5697         * expprint.c: Revert.
5698         * exec.h: Revert.
5699         * exec.c: Revert.
5700         * exceptions.c: Revert.
5701         * event-top.c: Revert.
5702         * event-loop.c: Revert.
5703         * eval.c: Revert.
5704         * elfread.c: Revert.
5705         * dwarf2read.h: Revert.
5706         * dwarf2read.c: Revert.
5707         * dwarf2loc.c: Revert.
5708         * dwarf2expr.h: Revert.
5709         * dwarf2expr.c: Revert.
5710         * dwarf2-frame.c: Revert.
5711         * dwarf2-frame-tailcall.c: Revert.
5712         * dwarf-index-write.h: Revert.
5713         * dwarf-index-write.c: Revert.
5714         * dwarf-index-common.c: Revert.
5715         * dwarf-index-cache.h: Revert.
5716         * dwarf-index-cache.c: Revert.
5717         * dummy-frame.c: Revert.
5718         * dtrace-probe.c: Revert.
5719         * disasm.h: Revert.
5720         * disasm.c: Revert.
5721         * disasm-selftests.c: Revert.
5722         * dictionary.c: Revert.
5723         * dicos-tdep.c: Revert.
5724         * demangle.c: Revert.
5725         * dcache.h: Revert.
5726         * dcache.c: Revert.
5727         * darwin-nat.h: Revert.
5728         * darwin-nat.c: Revert.
5729         * darwin-nat-info.c: Revert.
5730         * d-valprint.c: Revert.
5731         * d-namespace.c: Revert.
5732         * d-lang.c: Revert.
5733         * ctf.c: Revert.
5734         * csky-tdep.c: Revert.
5735         * csky-linux-tdep.c: Revert.
5736         * cris-tdep.c: Revert.
5737         * cris-linux-tdep.c: Revert.
5738         * cp-valprint.c: Revert.
5739         * cp-support.c: Revert.
5740         * cp-namespace.c: Revert.
5741         * cp-abi.c: Revert.
5742         * corelow.c: Revert.
5743         * corefile.c: Revert.
5744         * continuations.c: Revert.
5745         * completer.h: Revert.
5746         * completer.c: Revert.
5747         * complaints.c: Revert.
5748         * coffread.c: Revert.
5749         * coff-pe-read.c: Revert.
5750         * cli-out.h: Revert.
5751         * cli-out.c: Revert.
5752         * charset.c: Revert.
5753         * c-varobj.c: Revert.
5754         * c-valprint.c: Revert.
5755         * c-typeprint.c: Revert.
5756         * c-lang.c: Revert.
5757         * buildsym.c: Revert.
5758         * buildsym-legacy.c: Revert.
5759         * build-id.h: Revert.
5760         * build-id.c: Revert.
5761         * btrace.c: Revert.
5762         * bsd-uthread.c: Revert.
5763         * breakpoint.h: Revert.
5764         * breakpoint.c: Revert.
5765         * break-catch-throw.c: Revert.
5766         * break-catch-syscall.c: Revert.
5767         * break-catch-sig.c: Revert.
5768         * blockframe.c: Revert.
5769         * block.c: Revert.
5770         * bfin-tdep.c: Revert.
5771         * bfin-linux-tdep.c: Revert.
5772         * bfd-target.c: Revert.
5773         * bcache.c: Revert.
5774         * ax-general.c: Revert.
5775         * ax-gdb.h: Revert.
5776         * ax-gdb.c: Revert.
5777         * avr-tdep.c: Revert.
5778         * auxv.c: Revert.
5779         * auto-load.c: Revert.
5780         * arm-wince-tdep.c: Revert.
5781         * arm-tdep.c: Revert.
5782         * arm-symbian-tdep.c: Revert.
5783         * arm-pikeos-tdep.c: Revert.
5784         * arm-obsd-tdep.c: Revert.
5785         * arm-nbsd-tdep.c: Revert.
5786         * arm-nbsd-nat.c: Revert.
5787         * arm-linux-tdep.c: Revert.
5788         * arm-linux-nat.c: Revert.
5789         * arm-fbsd-tdep.c: Revert.
5790         * arm-fbsd-nat.c: Revert.
5791         * arm-bsd-tdep.c: Revert.
5792         * arch-utils.c: Revert.
5793         * arc-tdep.c: Revert.
5794         * arc-newlib-tdep.c: Revert.
5795         * annotate.h: Revert.
5796         * annotate.c: Revert.
5797         * amd64-windows-tdep.c: Revert.
5798         * amd64-windows-nat.c: Revert.
5799         * amd64-tdep.c: Revert.
5800         * amd64-sol2-tdep.c: Revert.
5801         * amd64-obsd-tdep.c: Revert.
5802         * amd64-obsd-nat.c: Revert.
5803         * amd64-nbsd-tdep.c: Revert.
5804         * amd64-nbsd-nat.c: Revert.
5805         * amd64-nat.c: Revert.
5806         * amd64-linux-tdep.c: Revert.
5807         * amd64-linux-nat.c: Revert.
5808         * amd64-fbsd-tdep.c: Revert.
5809         * amd64-fbsd-nat.c: Revert.
5810         * amd64-dicos-tdep.c: Revert.
5811         * amd64-darwin-tdep.c: Revert.
5812         * amd64-bsd-nat.c: Revert.
5813         * alpha-tdep.c: Revert.
5814         * alpha-obsd-tdep.c: Revert.
5815         * alpha-nbsd-tdep.c: Revert.
5816         * alpha-mdebug-tdep.c: Revert.
5817         * alpha-linux-tdep.c: Revert.
5818         * alpha-linux-nat.c: Revert.
5819         * alpha-bsd-tdep.c: Revert.
5820         * alpha-bsd-nat.c: Revert.
5821         * aix-thread.c: Revert.
5822         * agent.c: Revert.
5823         * addrmap.c: Revert.
5824         * ada-varobj.c: Revert.
5825         * ada-valprint.c: Revert.
5826         * ada-typeprint.c: Revert.
5827         * ada-tasks.c: Revert.
5828         * ada-lang.c: Revert.
5829         * aarch64-tdep.c: Revert.
5830         * aarch64-ravenscar-thread.c: Revert.
5831         * aarch64-newlib-tdep.c: Revert.
5832         * aarch64-linux-tdep.c: Revert.
5833         * aarch64-linux-nat.c: Revert.
5834         * aarch64-fbsd-tdep.c: Revert.
5835         * aarch64-fbsd-nat.c: Revert.
5836         * aarch32-linux-nat.c: Revert.
5837
5838 2019-04-05  Tom Tromey  <tom@tromey.com>
5839
5840         * ft32-tdep.c: Sort headers.
5841         * frv-tdep.c: Sort headers.
5842         * frv-linux-tdep.c: Sort headers.
5843         * frame.c: Sort headers.
5844         * frame-unwind.c: Sort headers.
5845         * frame-base.c: Sort headers.
5846         * fork-child.c: Sort headers.
5847         * findvar.c: Sort headers.
5848         * findcmd.c: Sort headers.
5849         * filesystem.c: Sort headers.
5850         * filename-seen-cache.h: Sort headers.
5851         * filename-seen-cache.c: Sort headers.
5852         * fbsd-tdep.c: Sort headers.
5853         * fbsd-nat.h: Sort headers.
5854         * fbsd-nat.c: Sort headers.
5855         * f-valprint.c: Sort headers.
5856         * f-typeprint.c: Sort headers.
5857         * f-lang.c: Sort headers.
5858         * extension.h: Sort headers.
5859         * extension.c: Sort headers.
5860         * extension-priv.h: Sort headers.
5861         * expprint.c: Sort headers.
5862         * exec.h: Sort headers.
5863         * exec.c: Sort headers.
5864         * exceptions.c: Sort headers.
5865         * event-top.c: Sort headers.
5866         * event-loop.c: Sort headers.
5867         * eval.c: Sort headers.
5868         * elfread.c: Sort headers.
5869         * dwarf2read.h: Sort headers.
5870         * dwarf2read.c: Sort headers.
5871         * dwarf2loc.c: Sort headers.
5872         * dwarf2expr.h: Sort headers.
5873         * dwarf2expr.c: Sort headers.
5874         * dwarf2-frame.c: Sort headers.
5875         * dwarf2-frame-tailcall.c: Sort headers.
5876         * dwarf-index-write.h: Sort headers.
5877         * dwarf-index-write.c: Sort headers.
5878         * dwarf-index-common.c: Sort headers.
5879         * dwarf-index-cache.h: Sort headers.
5880         * dwarf-index-cache.c: Sort headers.
5881         * dummy-frame.c: Sort headers.
5882         * dtrace-probe.c: Sort headers.
5883         * disasm.h: Sort headers.
5884         * disasm.c: Sort headers.
5885         * disasm-selftests.c: Sort headers.
5886         * dictionary.c: Sort headers.
5887         * dicos-tdep.c: Sort headers.
5888         * demangle.c: Sort headers.
5889         * dcache.h: Sort headers.
5890         * dcache.c: Sort headers.
5891         * darwin-nat.h: Sort headers.
5892         * darwin-nat.c: Sort headers.
5893         * darwin-nat-info.c: Sort headers.
5894         * d-valprint.c: Sort headers.
5895         * d-namespace.c: Sort headers.
5896         * d-lang.c: Sort headers.
5897         * ctf.c: Sort headers.
5898         * csky-tdep.c: Sort headers.
5899         * csky-linux-tdep.c: Sort headers.
5900         * cris-tdep.c: Sort headers.
5901         * cris-linux-tdep.c: Sort headers.
5902         * cp-valprint.c: Sort headers.
5903         * cp-support.c: Sort headers.
5904         * cp-namespace.c: Sort headers.
5905         * cp-abi.c: Sort headers.
5906         * corelow.c: Sort headers.
5907         * corefile.c: Sort headers.
5908         * continuations.c: Sort headers.
5909         * completer.h: Sort headers.
5910         * completer.c: Sort headers.
5911         * complaints.c: Sort headers.
5912         * coffread.c: Sort headers.
5913         * coff-pe-read.c: Sort headers.
5914         * cli-out.h: Sort headers.
5915         * cli-out.c: Sort headers.
5916         * charset.c: Sort headers.
5917         * c-varobj.c: Sort headers.
5918         * c-valprint.c: Sort headers.
5919         * c-typeprint.c: Sort headers.
5920         * c-lang.c: Sort headers.
5921         * buildsym.c: Sort headers.
5922         * buildsym-legacy.c: Sort headers.
5923         * build-id.h: Sort headers.
5924         * build-id.c: Sort headers.
5925         * btrace.c: Sort headers.
5926         * bsd-uthread.c: Sort headers.
5927         * breakpoint.h: Sort headers.
5928         * breakpoint.c: Sort headers.
5929         * break-catch-throw.c: Sort headers.
5930         * break-catch-syscall.c: Sort headers.
5931         * break-catch-sig.c: Sort headers.
5932         * blockframe.c: Sort headers.
5933         * block.c: Sort headers.
5934         * bfin-tdep.c: Sort headers.
5935         * bfin-linux-tdep.c: Sort headers.
5936         * bfd-target.c: Sort headers.
5937         * bcache.c: Sort headers.
5938         * ax-general.c: Sort headers.
5939         * ax-gdb.h: Sort headers.
5940         * ax-gdb.c: Sort headers.
5941         * avr-tdep.c: Sort headers.
5942         * auxv.c: Sort headers.
5943         * auto-load.c: Sort headers.
5944         * arm-wince-tdep.c: Sort headers.
5945         * arm-tdep.c: Sort headers.
5946         * arm-symbian-tdep.c: Sort headers.
5947         * arm-pikeos-tdep.c: Sort headers.
5948         * arm-obsd-tdep.c: Sort headers.
5949         * arm-nbsd-tdep.c: Sort headers.
5950         * arm-nbsd-nat.c: Sort headers.
5951         * arm-linux-tdep.c: Sort headers.
5952         * arm-linux-nat.c: Sort headers.
5953         * arm-fbsd-tdep.c: Sort headers.
5954         * arm-fbsd-nat.c: Sort headers.
5955         * arm-bsd-tdep.c: Sort headers.
5956         * arch-utils.c: Sort headers.
5957         * arc-tdep.c: Sort headers.
5958         * arc-newlib-tdep.c: Sort headers.
5959         * annotate.h: Sort headers.
5960         * annotate.c: Sort headers.
5961         * amd64-windows-tdep.c: Sort headers.
5962         * amd64-windows-nat.c: Sort headers.
5963         * amd64-tdep.c: Sort headers.
5964         * amd64-sol2-tdep.c: Sort headers.
5965         * amd64-obsd-tdep.c: Sort headers.
5966         * amd64-obsd-nat.c: Sort headers.
5967         * amd64-nbsd-tdep.c: Sort headers.
5968         * amd64-nbsd-nat.c: Sort headers.
5969         * amd64-nat.c: Sort headers.
5970         * amd64-linux-tdep.c: Sort headers.
5971         * amd64-linux-nat.c: Sort headers.
5972         * amd64-fbsd-tdep.c: Sort headers.
5973         * amd64-fbsd-nat.c: Sort headers.
5974         * amd64-dicos-tdep.c: Sort headers.
5975         * amd64-darwin-tdep.c: Sort headers.
5976         * amd64-bsd-nat.c: Sort headers.
5977         * alpha-tdep.c: Sort headers.
5978         * alpha-obsd-tdep.c: Sort headers.
5979         * alpha-nbsd-tdep.c: Sort headers.
5980         * alpha-mdebug-tdep.c: Sort headers.
5981         * alpha-linux-tdep.c: Sort headers.
5982         * alpha-linux-nat.c: Sort headers.
5983         * alpha-bsd-tdep.c: Sort headers.
5984         * alpha-bsd-nat.c: Sort headers.
5985         * aix-thread.c: Sort headers.
5986         * agent.c: Sort headers.
5987         * addrmap.c: Sort headers.
5988         * ada-varobj.c: Sort headers.
5989         * ada-valprint.c: Sort headers.
5990         * ada-typeprint.c: Sort headers.
5991         * ada-tasks.c: Sort headers.
5992         * ada-lang.c: Sort headers.
5993         * aarch64-tdep.c: Sort headers.
5994         * aarch64-ravenscar-thread.c: Sort headers.
5995         * aarch64-newlib-tdep.c: Sort headers.
5996         * aarch64-linux-tdep.c: Sort headers.
5997         * aarch64-linux-nat.c: Sort headers.
5998         * aarch64-fbsd-tdep.c: Sort headers.
5999         * aarch64-fbsd-nat.c: Sort headers.
6000         * aarch32-linux-nat.c: Sort headers.
6001
6002 2019-04-04  Tom Tromey  <tom@tromey.com>
6003
6004         * varobj.c (varobj_create): Update.
6005         * rust-exp.y (struct rust_parser) <update_innermost_block,
6006         lookup_symbol>: New methods.
6007         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6008         Rename.
6009         (rust_parser::rust_lookup_type)
6010         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6011         * printcmd.c (display_command, do_one_display): Update.
6012         * parser-defs.h (struct parser_state) <parser_state>: Add
6013         "tracker" parameter.
6014         (block_tracker): New member.
6015         (class innermost_block_tracker) <innermost_block_tracker>: Add
6016         "types" parameter.
6017         <reset>: Remove method.
6018         (innermost_block): Don't declare.
6019         (null_post_parser): Update.
6020         * parse.c (innermost_block): Remove global.
6021         (write_dollar_variable): Update.
6022         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6023         Remove "tracker_types" parameter.
6024         (parse_expression): Add "tracker" parameter.
6025         (parse_expression_for_completion): Update.
6026         (null_post_parser): Add "tracker" parameter.
6027         * p-exp.y: Update rules.
6028         * m2-exp.y: Update rules.
6029         * language.h (struct language_defn) <la_post_parser>: Add
6030         "tracker" parameter.
6031         * go-exp.y: Update rules.
6032         * f-exp.y: Update rules.
6033         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6034         parameter.
6035         * d-exp.y: Update rules.
6036         * c-exp.y: Update rules.
6037         * breakpoint.c (set_breakpoint_condition): Create an
6038         innermost_block_tracker.
6039         (watch_command_1): Likewise.
6040         * ada-lang.c (resolve): Add "tracker" parameter.
6041         (resolve_subexp): Likewise.
6042         * ada-exp.y (write_var_from_sym): Update.
6043
6044 2019-04-04  Tom Tromey  <tom@tromey.com>
6045
6046         * type-stack.h: New file.
6047         * type-stack.c: New file.
6048         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6049         type-stack.h.
6050         (insert_into_type_stack, insert_type, push_type, push_type_int)
6051         (insert_type_address_space, pop_type, pop_type_int)
6052         (pop_typelist, pop_type_stack, append_type_stack)
6053         (push_type_stack, get_type_stack, push_typelist)
6054         (follow_type_instance_flags, follow_types): Don't declare.
6055         * parse.c (type_stack): Remove global.
6056         (parse_exp_in_context): Update.
6057         (insert_into_type_stack, insert_type, push_type, push_type_int)
6058         (insert_type_address_space, pop_type, pop_type_int)
6059         (pop_typelist, pop_type_stack, append_type_stack)
6060         (push_type_stack, get_type_stack, push_typelist)
6061         (follow_type_instance_flags, follow_types): Remove (moved to
6062         type-stack.c).
6063         * f-exp.y (type_stack): New global.
6064         Update rules.
6065         (push_kind_type, f_parse): Update.
6066         * d-exp.y (type_stack): New global.
6067         Update rules.
6068         (d_parse): Update.
6069         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6070         Update rules.
6071         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6072         (HFILES_NO_SRCDIR): Add type-stack.h.
6073
6074 2019-04-04  Tom Tromey  <tom@tromey.com>
6075
6076         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6077         (rust_parser::convert_ast_to_expression, rust_parse)
6078         (rust_lex_test_completion, rust_lex_tests): Update.
6079         * parser-defs.h (struct expr_completion_state): New.
6080         (struct parser_state) <parser_state>: Add completion parameter.
6081         <mark_struct_expression, mark_completion_tag>: New methods.
6082         <parse_completion, m_completion_state>: New members.
6083         (prefixify_expression, null_post_parser): Update.
6084         (mark_struct_expression, mark_completion_tag): Don't declare.
6085         * parse.c (parse_completion, expout_last_struct)
6086         (expout_tag_completion_type, expout_completion_name): Remove
6087         globals.
6088         (parser_state::mark_struct_expression)
6089         (parser_state::mark_completion_tag): Now methods.
6090         (prefixify_expression): Add last_struct parameter.
6091         (prefixify_subexp): Likewise.
6092         (parse_exp_1): Update.
6093         (parse_exp_in_context): Add cstate parameter.  Update.
6094         (parse_expression_for_completion): Create an
6095         expr_completion_state.
6096         (null_post_parser): Add "completion" parameter.
6097         * p-exp.y: Update rules.
6098         (yylex): Update.
6099         * language.h (struct language_defn) <la_post_parser>: Add
6100         "completing" parameter.
6101         * go-exp.y: Update rules.
6102         (lex_one_token): Update.
6103         * expression.h (parse_completion): Don't declare.
6104         * d-exp.y: Update rules.
6105         (lex_one_token): Update rules.
6106         * c-exp.y: Update rules.
6107         (lex_one_token): Update.
6108         * ada-lang.c (resolve): Add "parse_completion" parameter.
6109         (resolve_subexp): Likewise.
6110         (ada_resolve_function): Likewise.
6111
6112 2019-04-04  Tom Tromey  <tom@tromey.com>
6113
6114         * parser-defs.h (struct parser_state) <start_arglist,
6115         end_arglist>: New methods.
6116         <arglist_len, m_funcall_chain>: New members.
6117         (arglist_len, start_arglist, end_arglist): Don't declare.
6118         * parse.c (arglist_len, funcall_chain): Remove global.
6119         (start_arglist, end_arglist): Remove functions.
6120         (parse_exp_in_context): Update.
6121         * p-exp.y: Update rules.
6122         * m2-exp.y: Update rules.
6123         * go-exp.y: Update rules.
6124         * f-exp.y: Update rules.
6125         * d-exp.y: Update rules.
6126         * c-exp.y: Update rules.
6127
6128 2019-04-04  Tom Tromey  <tom@tromey.com>
6129
6130         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6131         lex_operator, push_back>: New methods.
6132         Update all rules.
6133         (rust_parser::lex_hex, lex_escape): Rename and update.
6134         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6135         (rust_parser::lex_operator): Rename and update.
6136         (rust_parser::lex_number, rustyylex, rustyyerror)
6137         (rust_lex_test_init, rust_lex_test_sequence)
6138         (rust_lex_test_push_back, rust_lex_tests): Update.
6139         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6140         parameter.
6141         <lexptr, prev_lexptr>: New members.
6142         (lexptr, prev_lexptr): Don't declare.
6143         * parse.c (lexptr, prev_lexptr): Remove globals.
6144         (parse_exp_in_context): Update.
6145         * p-exp.y (yylex, yyerror): Update.
6146         * m2-exp.y (parse_number, yylex, yyerror): Update.
6147         * go-exp.y (lex_one_token, yyerror): Update.
6148         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6149         * d-exp.y (lex_one_token, yyerror): Update.
6150         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6151         (lex_one_token, yyerror): Update.
6152         * ada-lex.l (YY_INPUT): Update.
6153         (rewind_to_char): Update.
6154         * ada-exp.y (yyerror): Update.
6155
6156 2019-04-04  Tom Tromey  <tom@tromey.com>
6157
6158         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6159         * parser-defs.h (struct parser_state) <parser_state>: Add new
6160         parameter.
6161         <comma_terminates>: New member.
6162         (comma_terminates): Don't declare global.
6163         * parse.c (comma_terminates): Remove global.
6164         (parse_exp_in_context): Update.
6165         * p-exp.y (yylex): Update.
6166         * m2-exp.y (yylex): Update.
6167         * go-exp.y (lex_one_token): Update.
6168         * f-exp.y (yylex): Update.
6169         * d-exp.y (lex_one_token): Update.
6170         * c-exp.y (lex_one_token): Update.
6171         * ada-lex.l: Update.
6172
6173 2019-04-04  Tom Tromey  <tom@tromey.com>
6174
6175         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6176         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6177         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6178         * parser-defs.h (paren_depth): Don't declare.
6179         * parse.c (paren_depth): Remove global.
6180         (parse_exp_in_context): Update.
6181         * p-exp.y (paren_depth): New global.
6182         (pascal_parse): Initialize it.
6183         * m2-exp.y (paren_depth): New global.
6184         (m2_parse): Initialize it.
6185         * go-exp.y (paren_depth): New global.
6186         (go_parse): Initialize it.
6187         * f-exp.y (paren_depth): New global.
6188         (f_parse): Initialize it.
6189         * d-exp.y (paren_depth): New global.
6190         (d_parse): Initialize it.
6191         * c-exp.y (paren_depth): New global.
6192         (c_parse): Initialize it.
6193         * ada-lex.l (paren_depth): New global.
6194         (lexer_init): Initialize it.
6195
6196 2019-04-04  Tom Tromey  <tom@tromey.com>
6197
6198         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6199         (rust_parser::convert_ast_to_type)
6200         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6201         * parser-defs.h (struct parser_state) <parser_state>: Add
6202         parameters.  Initialize new members.
6203         <expression_context_block, expression_context_pc>: New members.
6204         * parse.c (expression_context_block, expression_context_pc):
6205         Remove globals.
6206         (parse_exp_in_context): Update.
6207         * p-exp.y: Update all rules.
6208         (yylex): Update.
6209         * m2-exp.y: Update all rules.
6210         (yylex): Update.
6211         * go-exp.y (yylex): Update.
6212         * f-exp.y (yylex): Update.
6213         * d-exp.y: Update all rules.
6214         (yylex): Update.
6215         * c-exp.y: Update all rules.
6216         (lex_one_token, classify_name, yylex, c_parse): Update.
6217         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6218
6219 2019-04-04  Tom Tromey  <tom@tromey.com>
6220
6221         * gdbarch.h, gdbarch.c: Rebuild.
6222         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6223         * stap-probe.h:
6224         (struct stap_parse_info): Replace "parser_state" with
6225         "expr_builder".
6226         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6227         (parser_state): New class.
6228         * parse.c (expr_builder): Rename.
6229         (expr_builder::release): Rename.
6230         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6231         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6232         (write_exp_elt_longcst, write_exp_elt_floatcst)
6233         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6234         (write_exp_string_vector, write_exp_bitstring)
6235         (write_exp_msymbol, mark_struct_expression)
6236         (write_dollar_variable)
6237         (insert_type_address_space, increase_expout_size): Replace
6238         "parser_state" with "expr_builder".
6239         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6240         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6241         "parser_state" with "expr_builder".
6242
6243 2019-04-04  Tom Tromey  <tom@tromey.com>
6244
6245         * rust-exp.y: Replace "parse_language" with method call.
6246         * p-exp.y:
6247         (yylex): Replace "parse_language" with method call.
6248         * m2-exp.y:
6249         (yylex): Replace "parse_language" with method call.
6250         * go-exp.y (classify_name): Replace "parse_language" with method
6251         call.
6252         * f-exp.y (yylex): Replace "parse_language" with method call.
6253         * d-exp.y (lex_one_token): Replace "parse_language" with method
6254         call.
6255         * c-exp.y:
6256         (lex_one_token, classify_name, yylex): Replace "parse_language"
6257         with method call.
6258         * ada-exp.y (find_primitive_type, type_char)
6259         (type_system_address): Replace "parse_language" with method call.
6260
6261 2019-04-04  Tom Tromey  <tom@tromey.com>
6262
6263         * rust-exp.y: Replace "parse_gdbarch" with method call.
6264         * parse.c (write_dollar_variable, insert_type_address_space):
6265         Replace "parse_gdbarch" with method call.
6266         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6267         call.
6268         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6269         call.
6270         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6271         "parse_gdbarch" with method call.
6272         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6273         with method call.
6274         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6275         "parse_gdbarch" with method call.
6276         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6277         "parse_gdbarch" with method call.
6278         * c-exp.y (parse_type, parse_number, classify_name): Replace
6279         "parse_gdbarch" with method call.
6280         * ada-lex.l: Replace "parse_gdbarch" with method call.
6281         * ada-exp.y (parse_type, find_primitive_type, type_char)
6282         (type_system_address): Replace "parse_gdbarch" with method call.
6283
6284 2019-04-04  Tom Tromey  <tom@tromey.com>
6285
6286         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6287         * stap-probe.c (stap_parse_argument): Update.
6288         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6289         initial_size parameter.
6290         * rust-exp.y (rust_lex_tests): Update.
6291         * parse.c (parser_state): Update.
6292         (parse_exp_in_context): Update.
6293         * parser-defs.h (struct parser_state) <parser_state>: Remove
6294         "initial_size" parameter.
6295
6296 2019-04-04  Tom Tromey  <tom@tromey.com>
6297
6298         * parser-defs.h (increase_expout_size): Don't declare.
6299         * parse.c (increase_expout_size): Now static.
6300
6301 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6302
6303         * gnu-nat.c (gnu_nat_target::wait): Fix
6304         target_waitstatus_to_string call.
6305
6306 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6307
6308         * eval.c (evaluate_subexp_standard): Handle internal functions
6309         during Fortran function call handling.
6310
6311 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6312
6313         * NEWS: Mention new internal functions.
6314         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6315         (read_base_type): Use dwarf2_init_complex_target_type.
6316         * value.c (creal_internal_fn): New function.
6317         (cimag_internal_fn): New function.
6318         (_initialize_values): Register new internal functions.
6319
6320 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6321
6322         * infrun.c (stop_all_threads): If debug_infrun, always
6323         trace the wait status after wait_one, using
6324         target_waitstatus_to_string and target_pid_to_str.
6325         (handle_inferior_event): Replace various trace of
6326         wait status kind by a single trace.
6327         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6328         wait status kind image by target_waitstatus_to_string.
6329         * target/waitstatus.c (target_waitstatus_to_string): Fix
6330         obsolete comment.
6331
6332 2019-04-01  Tom Tromey  <tromey@adacore.com>
6333
6334         PR symtab/23331:
6335         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6336
6337 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6338             Pedro Alves  <palves@redhat.com>
6339
6340         * top.c (quit_force): Call 'finalize_values'.
6341         * value.c (finalize_values): New function.
6342         * value.h (finalize_values): Declare.
6343
6344 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6345
6346         * NEWS: Announce $_gdb_major and $_gdb_minor.
6347
6348         * top.c (init_gdb_version_vars): New function.
6349         (gdb_init): Call init_gdb_version_vars.
6350
6351 2019-03-29  Tom Tromey  <tromey@adacore.com>
6352
6353         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6354         help text.  Remove dead code.
6355
6356 2019-03-29  Keith Seitz  <keiths@redhat.com>
6357
6358         From Siddhesh Poyarekar:
6359         * f-lang.h (f77_get_upperbound): Return LONGEST.
6360         (f77_get_lowerbound): Likewise.
6361         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6362         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6363         print them.
6364         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6365         plongest to format print it.
6366         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6367         (f77_get_upperbound): Likewise.
6368         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6369         LOWER_BOUND to LONGEST.
6370         (f77_create_arrayprint_offset_tbl): Likewise.
6371
6372 2019-03-29  Keith Seitz  <keiths@redhat.com>
6373
6374         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6375         %s/pulongest for TYPE_LENGTH instead of %d in format
6376         strings.
6377         * ada-typerint.c (ada_print_type): Likewise.
6378         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6379         * compile/compile-c-support.c (generate_register_struct): Likewise.
6380         * gdbtypes.c (recursive_dump_type): Likewise.
6381         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6382         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6383         instead of %d in format strings.
6384         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6385         to std::min to ULONGEST.
6386         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6387         instead of %d in format strings.
6388         * tracepoint.c (info_scope_command): Likewise.
6389         * typeprint.c (print_offset_data::update)
6390         (print_offset_data::finish): Likewise.
6391         * xtensa-tdep.c (xtensa_store_return_value)
6392         (xtensa_push_dummy_call): Likewise.
6393
6394 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6395
6396         * windows-nat.c (display_selector): Fixed format specifications
6397         for 64-bit Cygwin.
6398
6399 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6400
6401         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6402
6403 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6404
6405         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6406         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6407         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6408         (nios2_linux_init_abi): Install it.
6409
6410 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6411
6412         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6413
6414 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6415
6416         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6417
6418 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6419             Tom Tromey  <tromey@adacore.com>
6420
6421         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6422
6423 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6424
6425         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6426         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6427         method to compute the bounds of range types. Also print "[evaluated]"
6428         if the bounds' values come from a dynamic evaluation.
6429
6430 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6431
6432         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6433         whitespace when pretty printing is on.
6434
6435 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6436
6437         * ppc-linux-nat.c: Add include.
6438
6439 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6440
6441         * NEWS: Mention AArch64 Pointer Authentication.
6442
6443 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6444
6445         * arm-linux-nat.c: Add include.
6446
6447 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6448
6449         * source-cache.c (source_cache::get_source_lines): Re-read
6450         fullname after calling open_source_file.
6451
6452 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6453
6454         * NEWS: Mention TLS support for FreeBSD.
6455
6456 2019-03-25  Tom Tromey  <tromey@adacore.com>
6457
6458         * minsyms.c (BUNCH_SIZE): Update comment.
6459         (~minimal_symbol_reader): Remove old comment.
6460         (compact_minimal_symbols): Update comment.
6461         (minimal_symbol_reader::install): Remove old comment.  Update
6462         other comments.
6463
6464 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6465
6466         * s390-linux-nat.c: Add include.
6467
6468 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6469
6470         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6471         Call linux_get_hwcap.
6472         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6473         Likewise.
6474         (aarch64_linux_get_hwcap): Remove function.
6475         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6476         declaration.
6477         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6478         linux_get_hwcap.
6479         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6480         * linux-tdep.c (linux_get_hwcap): Add function.
6481         (linux_get_hwcap2): Likewise.
6482         * linux-tdep.h (linux_get_hwcap): Add declaration.
6483         (linux_get_hwcap2): Likewise.
6484         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6485         (ppc_linux_get_hwcap2): Likewise.
6486         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6487         linux_get_hwcap.
6488         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6489         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6490         (ppc_linux_nat_target::read_description): Likewise.
6491         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6492         * s390-linux-nat.c: Likewise.
6493         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6494
6495 2019-03-24  Tom Tromey  <tom@tromey.com>
6496
6497         * ada-lang.c (standard_lookup): Simplify initialization.
6498         (ada_lookup_symbol_nonlocal): Simplify return.
6499         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6500         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6501         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6502         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6503         initialization.
6504         * solib.c (solib_global_lookup): Simplify.
6505         * symtab.c (null_block_symbol): Remove.
6506         (symbol_cache_lookup): Simplify returns.
6507         (lookup_language_this): Simplify returns.
6508         (lookup_symbol_aux): Simplify return.
6509         (lookup_local_symbol): Simplify returns.
6510         (lookup_global_symbol_from_objfile): Simplify return.
6511         (lookup_symbol_in_objfile_symtabs)
6512         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6513         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6514         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6515         * cp-namespace.c (cp_lookup_bare_symbol)
6516         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6517         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6518         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6519         (cp_lookup_symbol_via_imports): Simplify initialization.
6520         (find_symbol_in_baseclass): Likewise.
6521         * symtab.h (null_block_symbol): Remove.
6522         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6523         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6524         (d_lookup_symbol_module): Likewise.
6525         (find_symbol_in_baseclass): Simplify initialization.
6526
6527 2019-03-24  Tom Tromey  <tom@tromey.com>
6528
6529         * expression.h: Don't include symtab.h.
6530         (struct block): Forward declare.
6531
6532 2019-03-24  Tom Tromey  <tom@tromey.com>
6533
6534         * c-exp.y (typebase): Remove casts.
6535         * gdbtypes.c (lookup_unsigned_typename, )
6536         (lookup_signed_typename): Remove cast.
6537         * eval.c (parse_to_comma_and_eval): Remove cast.
6538         * parse.c (write_dollar_variable): Remove cast.
6539         * block.h (struct block) <superblock>: Now const.
6540         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6541         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6542         (map_block): Make "block" const.
6543         * symfile.h (struct quick_symbol_functions)
6544         <map_matching_symbols>: Constify block argument to "callback".
6545         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6546         const.
6547         (find_pc_sect_compunit_symtab): Make "b" const.
6548         (find_symbol_at_address): Likewise.
6549         (search_symbols): Likewise.
6550         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6551         (dw2_debug_names_lookup_symbol): Likewise.
6552         (dw2_map_matching_symbols): Update.
6553         * p-valprint.c (pascal_val_print): Remove "block".
6554         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6555         (aux_add_nonlocal_symbols): Make "block" const.
6556         (resolve_subexp): Remove cast.
6557         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6558         const.
6559         (iterate_over_file_blocks): Likewise.
6560         * f-exp.y (%union) <bval>: Remove.
6561         * coffread.c (patch_opaque_types): Make "b" const.
6562         * spu-tdep.c (spu_catch_start): Make "block" const.
6563         * c-valprint.c (print_unpacked_pointer): Remove "block".
6564         * symmisc.c (dump_symtab_1): Make "b" const.
6565         (block_depth): Make "block" const.
6566         * d-exp.y (%union) <bval>: Remove.
6567         * cp-support.h (cp_lookup_rtti_type): Update.
6568         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6569         * psymtab.c (psym_lookup_symbol): Make "block" const.
6570         (maintenance_check_psymtabs): Make "b" const.
6571         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6572         (enumerate_locals, enumerate_args): Update.
6573         * python/py-symtab.c (stpy_global_block): Make "block" const.
6574         (stpy_static_block): Likewise.
6575         * inline-frame.c (block_starting_point_at): Make "new_block"
6576         const.
6577         * block.c (find_block_in_blockvector): Make return type const.
6578         (blockvector_for_pc_sect): Make "b" const.
6579         (find_block_in_blockvector): Make "b" const.
6580
6581 2019-03-23  Tom Tromey  <tom@tromey.com>
6582
6583         * varobj.c (varobj_create): Update.
6584         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6585         * printcmd.c (display_command, do_one_display): Don't reset
6586         innermost_block.
6587         * parser-defs.h (enum innermost_block_tracker_type): Move to
6588         expression.h.
6589         (innermost_block): Update comment.
6590         * parse.c (parse_exp_1): Add tracker_types parameter.
6591         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6592         tracker_types parameter.  Reset innermost_block.
6593         (parse_exp_in_context): Remove.
6594         (parse_expression_for_completion): Update.
6595         * objfiles.c (~objfile): Don't reset expression_context_block or
6596         innermost_block.
6597         * expression.h (enum innermost_block_tracker_type): Move from
6598         parser-defs.h.
6599         (parse_exp_1): Add tracker_types parameter.
6600         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6601         reset innermost_block.
6602
6603 2019-03-23  Tom Tromey  <tom@tromey.com>
6604
6605         * objfiles.h: Include bcache.h.
6606
6607 2019-03-23  Tom Tromey  <tom@tromey.com>
6608
6609         * linespec.c (get_current_search_block): Use
6610         scoped_restore_current_language.
6611         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6612
6613 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6614             Jiong Wang  <jiong.wang@arm.com>
6615
6616         * aarch64-linux-tdep.c
6617         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6618         section.
6619         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6620
6621 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6622             Jiong Wang  <jiong.wang@arm.com>
6623
6624         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6625         instructions.
6626         (aarch64_analyze_prologue_test): Add PACIASP test.
6627         (aarch64_prologue_prev_register): Unmask PC value.
6628
6629 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6630             Jiong Wang  <jiong.wang@arm.com>
6631
6632         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6633         (aarch64_dwarf2_prev_register): Unmask PC value.
6634         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6635         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6636         DW_CFA_AARCH64_negate_ra_state.
6637         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6638
6639 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6640             Jiong Wang  <jiong.wang@arm.com>
6641
6642         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6643         registers.
6644         (aarch64_pseudo_register_name): Likewise.
6645         (aarch64_pseudo_register_type): Likewise.
6646         (aarch64_pseudo_register_reggroup_p): Likewise.
6647         (aarch64_gdbarch_init): Add pauth registers.
6648         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6649         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6650         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6651         (struct gdbarch_tdep): Add regnum for ra_state.
6652
6653 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6654             Jiong Wang  <jiong.wang@arm.com>
6655
6656         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6657
6658 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6659             Jiong Wang  <jiong.wang@arm.com>
6660
6661         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6662         function.
6663         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6664         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6665         (aarch64_gdbarch_init): Add puth registers.
6666         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6667         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6668         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6669
6670 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6671             Jiong Wang  <jiong.wang@arm.com>
6672
6673         * aarch64-linux-nat.c
6674         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6675         * aarch64-linux-tdep.c
6676         (aarch64_linux_core_read_description): Likewise.
6677         (aarch64_linux_get_hwcap): New function.
6678         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6679         (aarch64_linux_get_hwcap): New declaration.
6680
6681 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6682             Jiong Wang  <jiong.wang@arm.com>
6683
6684         * aarch64-linux-nat.c
6685         (aarch64_linux_nat_target::read_description): Add pauth param.
6686         * aarch64-linux-tdep.c
6687         (aarch64_linux_core_read_description): Likewise.
6688         * aarch64-tdep.c (struct target_desc): Add in pauth.
6689         (aarch64_read_description): Add pauth param.
6690         (aarch64_gdbarch_init): Likewise.
6691         * aarch64-tdep.h (aarch64_read_description): Likewise.
6692         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6693         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6694         * features/Makefile: Add new files.
6695         * features/aarch64-pauth.c: New file.
6696         * features/aarch64-pauth.xml: New file.
6697
6698 2019-03-20  Tom Tromey  <tromey@adacore.com>
6699
6700         * infrun.c (handle_inferior_event): Rename from
6701         handle_inferior_event_1.  Create a scoped_value_mark.
6702         (handle_inferior_event): Remove.
6703
6704 2019-03-19  Tom Tromey  <tromey@adacore.com>
6705
6706         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6707         * infrun.h (print_stop_event): Add "displays" parameter.
6708         * infrun.c (print_stop_event): Add "displays" parameter.
6709
6710 2019-03-19  Pedro Alves  <palves@redhat.com>
6711
6712         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6713         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6714         to -1.  Fix TABs vs spaces.
6715         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6716         * tui/tui-out.h (tui_ui_out) Add intro comments.
6717         <m_line, m_start_of_line>: In-class initialize, and add describing
6718         comment.
6719
6720 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6721
6722         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6723         variable names.
6724         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6725
6726 2019-03-18  Pedro Alves  <palves@redhat.com>
6727             Eli Zaretskii <eliz@gnu.org>
6728
6729         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6730         m_line and m_start_of_line.
6731
6732 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6733
6734         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6735         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6736         it returns a newline.  This fixes a regression in TU mode, whereby
6737         the next line is output on the same screen line as the user input.
6738
6739 2019-03-18  Tom Tromey  <tromey@adacore.com>
6740
6741         * minsyms.c (minimal_symbol_reader::install): Remove call to
6742         obstack_blank.
6743
6744 2019-03-18  Pedro Alves  <palves@redhat.com>
6745
6746         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6747         New globals.
6748         (apply_style): New, factored out from ...
6749         (apply_ansi_escape): ... this.  Handle reverse video mode.
6750         (tui_set_reverse_mode): New function.
6751         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6752         * tui/tui-winsource.c (tui_show_source_line): Use
6753         tui_set_reverse_mode instead of setting A_STANDOUT.
6754         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6755         New setter methods.
6756
6757 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6758
6759         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6760         Handle tabs.
6761
6762 2019-03-18  Tom Tromey  <tromey@adacore.com>
6763
6764         * ada-lang.c (empty_array): Add "high" parameter.
6765         (ada_evaluate_subexp): Update.
6766
6767 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6768
6769         * unittests/string_view-selftests.c: Define
6770         _initialize_string_view_selftests unconditionally.
6771
6772 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6773
6774         PR gdb/24350
6775         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6776
6777 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6778
6779         PR gdb/24351
6780         * windows-nat.c (display_selector): Fix format specifiers.
6781
6782 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6783
6784         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6785         tui_refill_source_window instead of tui_refresh_win, to update the
6786         current execution line.  This fixes redisplay of the current line
6787         when stepping through the code with "next" or "step".
6788
6789 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6790
6791         * source-cache.c (source_cache::get_source_lines): Call
6792         find_source_lines to initialize s->nlines.  This fixes vertical
6793         scrolling of TUI source window when the DOWN arrow is pressed.
6794
6795 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6796
6797         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6798         linux-thread-db.c (_initialize_thread_db): Likewise.
6799
6800 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6801
6802         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6803         wclrtoeol in tui_show_source_line".  This reverts changes made in
6804         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6805
6806 2019-03-15  Tom Tromey  <tom@tromey.com>
6807
6808         * symtab.h (struct minimal_symbol): Derive from
6809         general_symbol_info.
6810         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6811         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6812         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6813         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6814         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6815         (MSYMBOL_SEARCH_NAME): Update.
6816         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6817         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6818         * minsyms.c (minimal_symbol_reader::record_full): Update.
6819
6820 2019-03-15  Tom Tromey  <tom@tromey.com>
6821
6822         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6823
6824 2019-03-15  Tom Tromey  <tom@tromey.com>
6825
6826         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6827         unique_xmalloc_ptr.
6828         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6829         Update.
6830         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6831         (build_minimal_symbol_hash_tables)
6832         (minimal_symbol_reader::install): Update.
6833
6834 2019-03-15  Tom Tromey  <tom@tromey.com>
6835
6836         * symtab.c (create_demangled_names_hash): Update.
6837         (symbol_set_names): Update.
6838         * objfiles.h (struct objfile_per_bfd_storage)
6839         <demangled_names_hash>: Now an htab_up.
6840         * objfiles.c (objfile_per_bfd_storage): Simplify.
6841
6842 2019-03-15  Tom Tromey  <tom@tromey.com>
6843
6844         * objfiles.h (struct objfile_per_bfd_storage): Declare
6845         destructor.
6846         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6847         New.
6848         (get_objfile_bfd_data): Use new.  Don't initialize
6849         language_of_main.
6850         (free_objfile_per_bfd_storage): Remove.
6851         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6852
6853 2019-03-15  Tom Tromey  <tom@tromey.com>
6854
6855         * symfile.c (reread_symbols): Update.
6856         * objfiles.c (objfile::objfile): Update.
6857         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6858         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6859         comment.
6860         (minimal_symbol_reader::install): Update.
6861         (terminate_minimal_symbol_table): Remove.
6862         * jit.c (jit_object_close_impl): Update.
6863
6864 2019-03-15  Tom Tromey  <tom@tromey.com>
6865
6866         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6867         initializations.
6868
6869 2019-03-15  Tom Tromey  <tom@tromey.com>
6870
6871         * objfiles.h (struct objfile_per_bfd_storage)
6872         <demangled_hash_languages>: Now a bitset.
6873         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6874         (lookup_minimal_symbol): Update.
6875
6876 2019-03-15  Tom Tromey  <tom@tromey.com>
6877
6878         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6879         Don't return the symbol.
6880         * coffread.c (record_minimal_symbol): Use record_full.
6881
6882 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6883
6884         The MS-Windows port of ncurses fails to switch to a color pair if
6885         one or both of the colors are the implicit default colors.  This
6886         change records the default colors when TUI is initialized, and
6887         then specifies them explicitly when a color pair uses the default
6888         colors.  This allows color styling in TUI mode on MS-Windows.
6889
6890         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6891         ncurses_norm_attr.
6892         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6893         colors in ncurses_norm_attr.
6894         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6895         "none", replace it with the default color recorded in
6896         ncurses_norm_attr.
6897
6898 2019-03-14  Tom Tromey  <tromey@adacore.com>
6899
6900         * source-cache.h (class source_cache) <get_source_lines>: Return
6901         std::string.
6902         * source-cache.c (source_cache::extract_lines): Handle case where
6903         first_pos==npos.  Return std::string.
6904         (source_cache::get_source_lines): Update.
6905
6906 2019-03-14  Tom Tromey  <tromey@adacore.com>
6907
6908         * NEWS: Add item for "style sources" commands.
6909         * source-cache.c (source_cache::get_source_lines): Check
6910         source_styling.
6911         * cli/cli-style.c (source_styling): New global.
6912         (_initialize_cli_style): Add "style sources" commands.
6913         (show_style_sources): New function.
6914         * cli/cli-style.h (source_styling): Declare.
6915
6916 2019-03-14  Pedro Alves  <palves@redhat.com>
6917             Tom Tromey  <tromey@adacore.com>
6918
6919         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6920         * tui/tui-winsource.c (tui_refill_source_window): New function,
6921         from...
6922         (tui_horizontal_source_scroll): ... here.  Move some logic.
6923         * cli/cli-style.c (set_style_enabled): Notify new observable.
6924         * tui/tui-hooks.c (tui_redisplay_source): New function.
6925         (tui_attach_detach_observers): Attach or detach
6926         tui_redisplay_source.
6927         * observable.h (source_styling_changed): New observable.
6928         * observable.c: Define source_styling_changed observable.
6929
6930 2019-03-13  Tom Tromey  <tromey@adacore.com>
6931
6932         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6933         (i386_gnu_nat_target::store_registers): Update.
6934         * target-debug.h (target_debug_print_std_string): New macro.
6935         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6936         * windows-tdep.c (display_one_tib): Update.
6937         * tui/tui-stack.c (tui_make_status_line): Update.
6938         * top.c (print_inferior_quit_action): Update.
6939         * thread.c (thr_try_catch_cmd): Update.
6940         (add_thread_with_info): Update.
6941         (thread_target_id_str): Update.
6942         (thr_try_catch_cmd): Update.
6943         (thread_command): Update.
6944         (thread_find_command): Update.
6945         * record-btrace.c (record_btrace_target::info_record)
6946         (record_btrace_resume_thread, record_btrace_target::resume)
6947         (record_btrace_cancel_resume, record_btrace_step_thread)
6948         (record_btrace_target::wait, record_btrace_target::wait)
6949         (record_btrace_target::wait, record_btrace_target::stop): Update.
6950         * progspace.c (print_program_space): Update.
6951         * process-stratum-target.c
6952         (process_stratum_target::thread_address_space): Update.
6953         * linux-fork.c (linux_fork_mourn_inferior)
6954         (detach_checkpoint_command, info_checkpoints_command)
6955         (linux_fork_context): Update.
6956         (linux_fork_detach): Update.
6957         (class scoped_switch_fork_info): Update.
6958         (delete_checkpoint_command): Update.
6959         * infrun.c (follow_fork_inferior): Update.
6960         (follow_fork_inferior): Update.
6961         (proceed_after_vfork_done): Update.
6962         (handle_vfork_child_exec_or_exit): Update.
6963         (follow_exec): Update.
6964         (displaced_step_prepare_throw): Update.
6965         (displaced_step_restore): Update.
6966         (start_step_over): Update.
6967         (resume_1): Update.
6968         (clear_proceed_status_thread): Update.
6969         (proceed): Update.
6970         (print_target_wait_results): Update.
6971         (do_target_wait): Update.
6972         (context_switch): Update.
6973         (stop_all_threads): Update.
6974         (restart_threads): Update.
6975         (finish_step_over): Update.
6976         (handle_signal_stop): Update.
6977         (switch_back_to_stepped_thread): Update.
6978         (keep_going_pass_signal): Update.
6979         (print_exited_reason): Update.
6980         (normal_stop): Update.
6981         * inferior.c (inferior_pid_to_str): Change return type.
6982         (print_selected_inferior): Update.
6983         (add_inferior): Update.
6984         (detach_inferior): Update.
6985         * dummy-frame.c (fprint_dummy_frames): Update.
6986         * dcache.c (dcache_info_1): Update.
6987         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6988         (btrace_fetch, btrace_clear): Update.
6989         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6990         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6991         type.
6992         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6993         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6994         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6995         * gdbarch.c, gdbarch.h: Rebuild.
6996         * gdbarch.sh (core_pid_to_str): Change return type.
6997         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6998         return type.
6999         (windows_nat_target::pid_to_str): Change return type.
7000         (windows_delete_thread): Update.
7001         (windows_nat_target::attach): Update.
7002         (windows_nat_target::files_info): Update.
7003         * target-delegates.c: Rebuild.
7004         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7005         return type.
7006         (sol_thread_target::pid_to_str): Change return type.
7007         * remote.c (class remote_target) <pid_to_str>: Change return
7008         type.
7009         (remote_target::pid_to_str): Change return type.
7010         (extended_remote_target::attach, remote_target::remote_stop_ns)
7011         (remote_target::remote_notif_remove_queued_reply)
7012         (remote_target::push_stop_reply, remote_target::disable_btrace):
7013         Update.
7014         (extended_remote_target::attach): Update.
7015         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7016         type.
7017         (gdbsim_target::pid_to_str): Change return type.
7018         * ravenscar-thread.c (struct ravenscar_thread_target)
7019         <pid_to_str>: Change return type.
7020         (ravenscar_thread_target::pid_to_str): Change return type.
7021         * procfs.c (class procfs_target) <pid_to_str>: Change return
7022         type.
7023         (procfs_target::pid_to_str): Change return type.
7024         (procfs_target::attach): Update.
7025         (procfs_target::detach): Update.
7026         (procfs_target::fetch_registers): Update.
7027         (procfs_target::store_registers): Update.
7028         (procfs_target::wait): Update.
7029         (procfs_target::files_info): Update.
7030         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7031         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7032         return type.
7033         (nto_procfs_target::pid_to_str): Change return type.
7034         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7035         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7036         return type.
7037         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7038         (exit_lwp): Update.
7039         (attach_proc_task_lwp_callback, get_detach_signal)
7040         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7041         (linux_nat_target::resume, wait_lwp, stop_callback)
7042         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7043         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7044         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7045         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7046         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7047         type.
7048         (inf_ptrace_target::attach): Update.
7049         (inf_ptrace_target::files_info): Update.
7050         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7051         type.
7052         (go32_nat_target::pid_to_str): Change return type.
7053         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7054         (gnu_nat_target::wait): Update.
7055         (gnu_nat_target::wait): Update.
7056         (gnu_nat_target::resume): Update.
7057         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7058         (fbsd_nat_target::wait): Update.
7059         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7060         type.
7061         (darwin_nat_target::attach): Update.
7062         * corelow.c (class core_target) <pid_to_str>: Change return type.
7063         (core_target::pid_to_str): Change return type.
7064         * target.c (normal_pid_to_str): Change return type.
7065         (default_pid_to_str): Likewise.
7066         (target_pid_to_str): Change return type.
7067         (target_translate_tls_address): Update.
7068         (target_announce_detach): Update.
7069         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7070         return type.
7071         (bsd_uthread_target::pid_to_str): Change return type.
7072         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7073         type.
7074         (bsd_kvm_target::pid_to_str): Change return type.
7075         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7076         return type.
7077         (aix_thread_target::pid_to_str): Change return type.
7078         * target.h (struct target_ops) <pid_to_str>: Change return type.
7079         (target_pid_to_str, normal_pid_to_str): Likewise.
7080         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7081         type.
7082         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7083         type.
7084         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7085         return type.
7086         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7087         type.
7088         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7089         type.
7090         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7091         return type.
7092
7093 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7094
7095         * NEWS: Mention that the new default MI version is 3.  Mention
7096         changes to the output of commands and events that deal with
7097         multi-location breakpoints.
7098         * breakpoint.c: Include "mi/mi-out.h".
7099         (print_one_breakpoint): Change output syntax if using MI version
7100         >= 3.
7101         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7102         New.
7103         (mi_multi_location_breakpoint_output_fixed): New.
7104         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7105         (mi_cmd_fix_multi_location_breakpoint_output): New.
7106         (mi_multi_location_breakpoint_output_fixed): New.
7107         * mi/mi-cmds.c (mi_cmds): Register command
7108         -fix-multi-location-breakpoint-output.
7109         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7110         interpreter "mi".
7111
7112 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7113
7114         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7115         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7116         instantiate mi_ui_out based on interpreter name.
7117         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7118         * mi/mi-main.c (mi_load_progress): Likewise.
7119
7120 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7121
7122         * NEWS: Combine separate "New targets" sections for 8.3.
7123
7124 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7125
7126         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7127         (ppcfbsd_init_abi): Install gdbarch
7128         "fetch_tls_load_module_address" and "get_thread_local_address"
7129         methods.
7130
7131 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7132
7133         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7134         (riscv_fbsd_init_abi): Install gdbarch
7135         "fetch_tls_load_module_address" and "get_thread_local_address"
7136         methods.
7137
7138 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7139
7140         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7141         (i386fbsd_init_abi): Install gdbarch
7142         "fetch_tls_load_module_address" and "get_thread_local_address"
7143         methods.
7144
7145 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7146
7147         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7148         (amd64fbsd_init_abi): Install gdbarch
7149         "fetch_tls_load_module_address" and "get_thread_local_address"
7150         methods.
7151
7152 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7153
7154         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7155         (struct fbsd_pspace_data): New type.
7156         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7157         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7158         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7159         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7160         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7161
7162 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7163
7164         * gdbtypes.c (lookup_struct_elt): New function.
7165         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7166         * gdbtypes.h (struct struct_elt): New type.
7167         (lookup_struct_elt): New prototype.
7168
7169 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7170
7171         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7172         remove disabled code block.
7173
7174 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7175
7176         * gdbarch.sh (get_thread_local_address): New method.
7177         * gdbarch.h, gdbarch.c: Regenerate.
7178         * target.c (target_translate_tls_address): Use
7179         gdbarch_get_thread_local_address if present instead of
7180         target::get_thread_local_address.
7181
7182 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7183
7184         * target.h (target::get_thread_local_address): Update comment.
7185
7186 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7187
7188         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7189         objfile->separate_debug_objfile_backlink if not NULL.
7190
7191 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7192
7193         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7194         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7195         (amd64bsd_store_inferior_registers): Likewise.
7196         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7197         Enable segment base registers.
7198         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7199         PT_GETFSBASE and PT_GETGSBASE.
7200         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7201         PT_SETGSBASE.
7202         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7203         segment base registers.
7204         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7205
7206 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7207
7208         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7209         Update calls to i386_target_description to add 'segments'
7210         parameter.
7211         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7212         add segment base registers.
7213         * arch/i386.c (i386_create_target_description): Add 'segments'
7214         parameter to enable segment base registers.
7215         * arch/i386.h (i386_create_target_description): Likewise.
7216         * features/i386/32bit-segments.xml: New file.
7217         * features/i386/32bit-segments.c: Generate.
7218         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7219         call to i386_target_description to add 'segments' parameter.
7220         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7221         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7222         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7223         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7224         if feature is present.
7225         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7226         Add 'segments' parameter to call to i386_target_description.
7227         (i386_target_description): Add 'segments' parameter to enable
7228         segment base registers.
7229         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7230         to call to i386_target_description.
7231         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7232         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7233         Define I386_NUM_REGS.
7234         (i386_target_description): Add 'segments' parameter to enable
7235         segment base registers.
7236
7237 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7238
7239         PR/24325
7240         * source-cache.c: #undef open and close, to avoid unresolved
7241         externals during linking.
7242
7243 2019-03-12  Tom Tromey  <tromey@adacore.com>
7244
7245         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7246         const.  Add initializers.
7247         (_initialize_remote): Don't initialize ptid globals.
7248
7249 2019-03-12  Pedro Alves  <palves@redhat.com>
7250
7251         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7252
7253 2019-03-12  Pedro Alves  <palves@redhat.com>
7254
7255         * cp-name-parser.y (main): Remove unused 'len' variable.
7256
7257 2019-03-12  Tom Tromey  <tromey@adacore.com>
7258
7259         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7260         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7261
7262 2019-03-12  Tom Tromey  <tromey@adacore.com>
7263
7264         * linux-nat.c (iterate_over_lwps): Update.
7265         (stop_callback): Remove parameter.
7266         (stop_wait_callback, detach_callback, resume_set_callback)
7267         (select_singlestep_lwp_callback, set_ignore_sigint)
7268         (status_callback, resumed_callback, resume_clear_callback)
7269         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7270         data parameter.
7271         (linux_nat_target::detach, linux_nat_target::resume)
7272         (linux_stop_and_wait_all_lwps, select_event_lwp)
7273         (linux_nat_filter_event, linux_nat_wait_1)
7274         (linux_nat_target::kill, linux_nat_target::stop)
7275         (linux_nat_target::stop): Update.
7276         (linux_nat_resume_callback): Change type.
7277         (resume_stopped_resumed_lwps, count_events_callback)
7278         (select_event_lwp_callback): Likewise.
7279         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7280         * arm-linux-nat.c (struct update_registers_data): Remove.
7281         (update_registers_callback): Change type.
7282         (arm_linux_insert_hw_breakpoint1): Update.
7283         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7284         parameter.
7285         (x86_linux_dr_set_addr): Update.
7286         (x86_linux_dr_set_control): Update.
7287         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7288         (iterate_over_lwps): Use gdb::function_view.
7289         * nat/aarch64-linux-hw-point.c (struct
7290         aarch64_dr_update_callback_param): Remove.
7291         (debug_reg_change_callback): Change type.
7292         (aarch64_notify_debug_reg_change): Update.
7293         * s390-linux-nat.c (s390_refresh_per_info): Update.
7294
7295 2019-03-11  Tom Tromey  <tromey@adacore.com>
7296
7297         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7298         redundant assignment to "this_cu".
7299
7300 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7301
7302         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7303
7304 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7305
7306         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7307         from...
7308         (rank_one_type): ... this.
7309
7310 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7311
7312         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7313         from...
7314         (rank_one_type): ... this.
7315
7316 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7317
7318         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7319         from...
7320         (rank_one_type): ... this.
7321
7322 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7323
7324         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7325         from...
7326         (rank_one_type): ... this.
7327
7328 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7329
7330         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7331         from...
7332         (rank_one_type): ... this.
7333
7334 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7335
7336         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7337         from...
7338         (rank_one_type): ... this.
7339
7340 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7341
7342         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7343         from...
7344         (rank_one_type): ... this.
7345
7346 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7347
7348         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7349         from...
7350         (rank_one_type): ... this.
7351
7352 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7353
7354         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7355         from...
7356         (rank_one_type): ... this.
7357
7358 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7359
7360         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7361         from...
7362         (rank_one_type): ... this.
7363
7364 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7365
7366         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7367         from...
7368         (rank_one_type): ... this.
7369
7370 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7371
7372         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7373         from...
7374         (rank_one_type): ... this.
7375
7376 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7377
7378         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7379         inferior-events' shows the example events.
7380
7381 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7382
7383         Support styling on native MS-Windows console
7384
7385         PR/24315
7386         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7387         on MS-Windows if $TERM is not defined.
7388
7389         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7390
7391         * posix-hdep.c (gdb_console_fputs):
7392         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7393         functions.
7394         * ui-file.h (gdb_console_fputs): Add prototype.
7395
7396         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7397         back to fputs only if the former returns zero.
7398
7399 2019-03-07  Tom Tromey  <tom@tromey.com>
7400
7401         * symmisc.c (print_symbol_bcache_statistics): Update.
7402         (print_objfile_statistics): Update.
7403         * symfile.c (allocate_symtab): Update.
7404         * stabsread.c: Don't include bcache.h.
7405         * psymtab.h (struct psymbol_bcache): Don't declare.
7406         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7407         (psymbol_bcache_init, psymbol_bcache_free)
7408         (psymbol_bcache_get_bcache): Don't declare.
7409         * psymtab.c (struct psymbol_bcache): Remove.
7410         (psymtab_storage::psymtab_storage): Update.
7411         (psymtab_storage::~psymtab_storage): Update.
7412         (psymbol_bcache_init, psymbol_bcache_free)
7413         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7414         (add_psymbol_to_bcache): Update.
7415         (allocate_psymtab): Update.
7416         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7417         macro_cache>: No longer pointers.
7418         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7419         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7420         * macrotab.c (macro_bcache): Update.
7421         * macroexp.c: Don't include bcache.h.
7422         * gdbtypes.c (check_types_worklist): Update.
7423         (types_deeply_equal): Remove TRY/CATCH.  Update.
7424         * elfread.c (elf_symtab_read): Update.
7425         * dwarf2read.c: Don't include bcache.h.
7426         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7427         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7428         (print_bcache_statistics, bcache_memory_used): Don't declare.
7429         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7430         methods.  Rename all data members.
7431         * bcache.c (struct bcache): Move to bcache.h.
7432         (bcache::expand_hash_table): Rename from expand_hash_table.
7433         (bcache): Remove.
7434         (bcache::insert): Rename from bcache_full.
7435         (bcache::compare): Rename from bcache_compare.
7436         (bcache_xmalloc): Remove.
7437         (bcache::~bcache): Rename from bcache_xfree.
7438         (bcache::print_statistics): Rename from print_bcache_statistics.
7439         (bcache::memory_used): Rename from bcache_memory_used.
7440
7441 2019-03-07  Pedro Alves  <palves@redhat.com>
7442
7443         * infrun.c (normal_stop): Also check for
7444         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7445
7446 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7447
7448         * f-lang.c (value_from_host_double): Moved to...
7449         * value.c (value_from_host_double): ...here.
7450         * value.h (value_from_host_double): Declare.
7451         * guile/scm-math.c (vlscm_convert_typed_number): Use
7452         value_from_host_double.
7453         (vlscm_convert_number): Likewise.
7454         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7455         * python/py-value.c (convert_value_from_python): Likewise.
7456
7457 2019-03-06  Tom Tromey  <tom@tromey.com>
7458
7459         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7460
7461 2019-03-06  Tom Tromey  <tom@tromey.com>
7462
7463         * utils.h (free_current_contents): Don't declare.
7464         * utils.c (free_current_contents): Remove.
7465
7466 2019-03-06  Tom Tromey  <tom@tromey.com>
7467
7468         * top.c (quit_force): Update.
7469         * main.c (captured_command_loop): Update.
7470         * common/new-op.c (operator new): Update.
7471         * common/common-exceptions.c (struct catcher)
7472         <save_cleanup_chain>: Remove member.
7473         (exceptions_state_mc_init): Update.
7474         (exception_try_scope_entry): Return nullptr.
7475         (exception_try_scope_exit, exception_rethrow)
7476         (throw_exception_sjlj, throw_exception_cxx): Update.
7477         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7478         (all_cleanups, do_cleanups, discard_cleanups)
7479         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7480         (restore_cleanups, restore_final_cleanups): Don't declare.
7481         (do_final_cleanups): Remove parameter.
7482         * common/cleanups.c (cleanup_chain, make_cleanup)
7483         (make_cleanup_dtor, all_cleanups, do_cleanups)
7484         (discard_my_cleanups, discard_cleanups)
7485         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7486         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7487         (null_cleanup): Remove.
7488         (do_final_cleanups): Remove parameter.
7489
7490 2019-03-06  Tom Tromey  <tom@tromey.com>
7491
7492         * remote.c (remote_target::remote_parse_stop_reply): Use
7493         unique_xmalloc_ptr.
7494
7495 2019-03-06  Tom Tromey  <tom@tromey.com>
7496
7497         * stabsread.c (struct stabs_field_info): Rename from field_info.
7498         <list, fnlist>: Add initializers.
7499         <obstack>: New member.
7500         (read_member_functions, read_struct_fields, read_baseclasses):
7501         Allocate on obstack.  Don't use cleanups.
7502         (read_one_struct_field, read_member_functions, read_struct_fields)
7503         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7504         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7505         (read_struct_type): Update.
7506
7507 2019-03-06  Tom Tromey  <tom@tromey.com>
7508
7509         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7510         * common/filestuff.h (make_cleanup_close): Don't declare.
7511         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7512         Remove.
7513
7514 2019-03-06  Tom Tromey  <tom@tromey.com>
7515
7516         * solib-aix.c: Use make_scope_exit.
7517
7518 2019-03-06  Tom Tromey  <tom@tromey.com>
7519
7520         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7521         Use make_scope_exit.
7522
7523 2019-03-06  Tom Tromey  <tom@tromey.com>
7524
7525         * solib-svr4.c (disable_probes_interface): Remove parameter.
7526         (svr4_handle_solib_event): Use make_scope_exit.
7527
7528 2019-03-06  Tom Tromey  <tom@tromey.com>
7529
7530         * remote.c (struct stop_reply_deleter): Remove.
7531         (stop_reply_up): Update.
7532         (struct stop_reply): Derive from notif_event.  Don't typedef.
7533         <regcache>: Now a std::vector.
7534         (stop_reply_xfree): Remove.
7535         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7536         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7537         (remote_target::discard_pending_stop_replies): Use delete.
7538         (remote_target::remote_parse_stop_reply): Update.
7539         (remote_target::process_stop_reply): Update.
7540         * remote-notif.h (struct notif_event): Add virtual destructor.
7541         Remove "dtr" member.
7542         (struct notif_client) <alloc_event>: Return a unique_ptr.
7543         (notif_event_xfree): Don't declare.
7544         (notif_event_up): New typedef.
7545         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7546         (notif_event_xfree, do_notif_event_xfree): Remove.
7547         (remote_notif_state_xfree): Update.
7548
7549 2019-03-06  Tom Tromey  <tom@tromey.com>
7550
7551         * infrun.c (displaced_step_clear_cleanup): Now a
7552         forward_scope_exit type.
7553         (displaced_step_prepare_throw): Update.
7554         (displaced_step_fixup): Update.
7555
7556 2019-03-06  Tom Tromey  <tom@tromey.com>
7557
7558         * inferior.h (class inferior): Update comment.
7559         * gdbthread.h (class thread_info): Update comment.
7560
7561 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7562             Tom Tromey  <tom@tromey.com>
7563
7564         * stabsread.h (struct stab_section_list): Remove.
7565         (coffstab_build_psymtabs): Update.
7566         * dbxread.c (symbuf_sections): Now a std::vector.
7567         (sect_idx): New global.
7568         (fill_symbuf): Update.
7569         (coffstab_build_psymtabs): Change type of stabsects parameter.
7570         Update.
7571         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7572         std::vector.
7573         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7574         (coff_locate_sections): Update.
7575         (coff_symfile_read): Remove cleanups.  Update.
7576         (init_stringtab): Add storage parameter.
7577         (free_stringtab, free_stringtab_cleanup): Remove.
7578         (init_lineno): Add storage parameter.
7579         (free_linetab, free_linetab_cleanup): Remove.
7580
7581 2019-03-06  Pedro Alves  <palves@redhat.com>
7582
7583         * linux-fork.c (fork_info::clobber_regs): Delete.
7584         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7585         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7586         comment.  Adjust.
7587         (scoped_switch_fork_info::scoped_switch_fork_info)
7588         (checkpoint_command, linux_fork_context): Adjust
7589         fork_save_infrun_state calls.
7590
7591 2019-03-06  Pedro Alves  <palves@redhat.com>
7592
7593         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7594         (inf_has_multiple_threads): Return 'bool' and rewrite using
7595         inferior_info::threads().
7596
7597 2019-03-06  Pedro Alves  <palves@redhat.com>
7598
7599         * linux-fork.c: Include <list>.
7600         (fork_list): Now a std::list instance.
7601         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7602         (forks_exist_p, find_last_fork): Adjust.
7603         (new_fork): Delete.
7604         (one_fork_p): New.
7605         (add_fork): Adjust.
7606         (free_fork): Delete, folded into fork_info::~fork_info().
7607         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7608         Adjust.
7609         (init_fork_list): Delete.
7610         (linux_fork_killall, linux_fork_mourn_inferior)
7611         (linux_fork_detach, info_checkpoints_command): Adjust.
7612         (_initialize_linux_fork): No longer call init_fork_list.
7613
7614 2019-03-06  Pedro Alves  <palves@redhat.com>
7615
7616         * linux-fork.c (new_fork): New, split out of ...
7617         (add_fork): ... this.  Return void.  Move "first fork" special
7618         case from here, to ...
7619         (checkpoint_command): ... here.
7620         * linux-linux.h (add_fork): Return void.
7621
7622 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7623
7624         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7625
7626 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7627             Chris January  <chris.january@arm.com>
7628             David Lecomber  <david.lecomber@arm.com>
7629
7630         * f-exp.y: New token, UNOP_INTRINSIC.
7631         (exp): New pattern using UNOP_INTRINSIC token.
7632         (f77_keywords): Add 'abs' keyword.
7633         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7634         (value_from_host_double): New function.
7635         (evaluate_subexp_f): Support UNOP_ABS.
7636
7637 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7638
7639         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7640         types.
7641
7642 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7643
7644         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7645         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7646         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7647
7648 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7649
7650         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7651
7652 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7653             Chris January  <chris.january@arm.com>
7654
7655         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7656         * f-exp.y: Define 'KIND' token.
7657         (exp): New pattern for KIND expressions.
7658         (ptype): Handle types with a kind extension.
7659         (direct_abs_decl): Extend to spot kind extensions.
7660         (f77_keywords): Add 'kind' to the list.
7661         (push_kind_type): New function.
7662         (convert_to_kind_type): New function.
7663         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7664         * parse.c (operator_length_standard): Likewise.
7665         * parser-defs.h (enum type_pieces): Add tp_kind.
7666         * std-operator.def: Add UNOP_KIND.
7667
7668 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7669
7670         * f-exp.y (f_parse): Set yydebug.
7671
7672 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7673
7674         * f-lang.c (evaluate_subexp_f): New function.
7675         (exp_descriptor_f): New global.
7676         (f_language_defn): Use exp_descriptor_f instead of
7677         exp_descriptor_standard.
7678
7679 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7680
7681         * f-exp.y (struct token): Add comments.
7682         (dot_ops): Remove uppercase versions and the end marker.
7683         (f77_keywords): Likewise.
7684         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7685         entries in the dot_ops array are case insensitive, and use
7686         strncasecmp to compare strings.  Also some whitespace cleanup in
7687         this area.  Similar for the f77_keywords array, except entries in
7688         this list might be case sensitive.
7689
7690 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7691
7692         * f-exp.y (struct f77_boolean_val): Add comments.
7693         (boolean_values): Remove uppercase versions, and end marker.
7694         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7695         and use strncasecmp to achieve case insensitivity.  Additionally,
7696         perform whitespace cleanup around this code.
7697
7698 2019-03-06  Tom Tromey  <tromey@adacore.com>
7699
7700         * remote-sim.c (gdbsim_target_open): Use result of
7701         gdb_argv::release.
7702
7703 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7704         Dirk Schubert  <dirk.schubert@arm.com>
7705         Chris January  <chris.january@arm.com>
7706
7707         * eval.c (evaluate_subexp_standard): Call Fortran argument
7708         wrapping logic.
7709         * f-lang.c (struct value): A value which can be passed into a
7710         Fortran function call.
7711         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7712         where appropriate.
7713         (struct type): Value ready for a Fortran function call.
7714         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7715         is needed.
7716         * f-lang.h (fortran_argument_convert): Declaration.
7717         (fortran_preserve_arg_pointer): Declaration.
7718         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7719
7720 2019-03-05  Tom Tromey  <tromey@adacore.com>
7721
7722         * python/py-prettyprint.c (print_string_repr): Remove #if.
7723         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7724
7725 2019-03-05  Tom Tromey  <tromey@adacore.com>
7726
7727         * target.c (the_dummy_target): Move later.  Change type to
7728         "dummy_target".
7729         (initialize_targets): Don't initialize the_dummy_target.
7730
7731 2019-03-05  Tom Tromey  <tromey@adacore.com>
7732
7733         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7734         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7735
7736 2019-03-05  Tom Tromey  <tromey@adacore.com>
7737
7738         * windows-nat.c (windows_nat_target::attach)
7739         (windows_nat_target::detach): Don't call gdb_flush.
7740         * valprint.c (generic_val_print, val_print, val_print_string):
7741         Don't call gdb_flush.
7742         * utils.c (defaulted_query): Don't call gdb_flush.
7743         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7744         * target.c (target_announce_detach): Don't call gdb_flush.
7745         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7746         * remote.c (extended_remote_target::attach): Don't call
7747         gdb_flush.
7748         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7749         * printcmd.c (do_examine): Don't call gdb_flush.
7750         (info_display_command): Don't call gdb_flush.
7751         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7752         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7753         * memattr.c (info_mem_command): Don't call gdb_flush.
7754         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7755         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7756         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7757         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7758         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7759         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7760         (gnu_nat_target::detach): Don't call gdb_flush.
7761         * f-valprint.c (f_val_print): Don't call gdb_flush.
7762         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7763         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7764         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7765         gdb_flush.
7766         * c-valprint.c (c_val_print): Don't call gdb_flush.
7767         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7768
7769 2019-03-05  Tom Tromey  <tromey@adacore.com>
7770
7771         * varobj.c (update_dynamic_varobj_children): Update.
7772         (install_default_visualizer): Use reset, not release.
7773         * value.c (set_internalvar): Update.
7774         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7775         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7776         ATTRIBUTE_UNUSED_RESULT.
7777
7778 2019-03-05  Tom Tromey  <tromey@adacore.com>
7779
7780         * remote.c (class scoped_remote_fd) <release>: Add
7781         ATTRIBUTE_UNUSED_RESULT.
7782
7783 2019-03-05  Tom Tromey  <tromey@adacore.com>
7784
7785         * macroexp.c (struct macro_buffer) <release>: Add
7786         ATTRIBUTE_UNUSED_RESULT.
7787
7788 2019-03-05  Tom Tromey  <tromey@adacore.com>
7789
7790         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7791         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7792         ATTRIBUTE_UNUSED_RESULT.
7793
7794 2019-03-05  Tom Tromey  <tromey@adacore.com>
7795
7796         * common/scoped_fd.h (class scoped_fd) <release>: Add
7797         ATTRIBUTE_UNUSED_RESULT.
7798
7799 2019-03-05  Tom Tromey  <tromey@adacore.com>
7800
7801         * parser-defs.h (struct parser_state) <release>: Add
7802         ATTRIBUTE_UNUSED_RESULT.
7803
7804 2019-03-05  Tom Tromey  <tromey@adacore.com>
7805
7806         * utils.h (class gdb_argv) <release>: Add
7807         ATTRIBUTE_UNUSED_RESULT.
7808         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7809
7810 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7811
7812         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7813         for-loop range, to avoid compiler warnings.
7814
7815         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7816         avoid compiler warnings about unused variables.
7817
7818         * NEWS: Mention end of support for native debugging on MS-Windows
7819         before XP.
7820
7821         PR gdb/24292
7822         * common/netstuff.c:
7823         * gdbserver/gdbreplay.c
7824         * gdbserver/remote-utils.c:
7825         * ser-tcp.c:
7826         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7827         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7828         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7829         'getaddrinfo' and 'freeaddrinfo' were not available before
7830         Windows XP, and mingw.org's MinGW headers by default define
7831         _WIN32_WINNT to 0x500.
7832
7833 2019-03-01  Gary Benson <gbenson@redhat.com>
7834
7835         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7836
7837 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7838             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7839
7840         PR gdb/8527
7841         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7842         set_sigint_trap, clear_sigint_trap.
7843
7844 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7845
7846         * target.c (target_detach): Clear the regcache and the
7847         frame cache.
7848
7849 2019-02-27  Pedro Alves  <palves@redhat.com>
7850
7851         * utils.c (set_screen_size): When we cap the height/width sizes,
7852         tweak the corresponding command variable to show "unlimited":
7853
7854 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7855             Pedro Alves  <palves@redhat.com>
7856
7857         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7858         before calling rl_set_screen_size.
7859
7860 2019-02-27  Tom Tromey  <tromey@adacore.com>
7861
7862         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7863         define.
7864         * python/py-value.c: Remove Python 2.4 workaround.
7865         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7866         workaround.
7867         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7868         Python 2.4 workaround.
7869         * python/python-internal.h: Remove Python 2.4 comment.
7870         (Py_ssize_t): Don't define.
7871         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7872         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7873         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7874         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7875         * python/python.c (do_start_initialization): Remove Python 2.4
7876         workaround.
7877         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7878         (print_children): Remove Python 2.4 workaround.
7879         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7880         workaround.
7881         (CHARBUFFERPROC_NAME): Remove.
7882         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7883         Python 2.4 workaround.
7884
7885 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7886
7887         * NEWS: Note minimum Python version.
7888
7889 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7890
7891         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7892         code from these functions.  Remove corresponding ifdefs.  Use
7893         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7894         Remove gotos and target of gotos.
7895         (infpy_search_memory): Likewise.
7896
7897 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7898
7899         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7900         (hppa_gdbarch_init): Don't register deleted functions with
7901         gdbarch.
7902
7903 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7904
7905         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7906         (h8300_unwind_sp): Delete.
7907         (h8300_dummy_id): Delete.
7908         (h8300_gdbarch_init): Don't register deleted functions with
7909         gdbarch.
7910
7911 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7912
7913         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7914         (ft32_unwind_pc): Delete.
7915         (ft32_unwind_sp): Delete.
7916         (ft32_gdbarch_init): Don't register deleted functions with
7917         gdbarch.
7918
7919 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7920
7921         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7922         (frv_unwind_pc): Delete.
7923         (frv_unwind_sp): Delete.
7924         (frv_gdbarch_init): Don't register deleted functions with
7925         gdbarch.
7926
7927 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7928
7929         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7930         (riscv_unwind_pc): Delete.
7931         (riscv_unwind_sp): Delete.
7932         (riscv_gdbarch_init): Don't register deleted functions with
7933         gdbarch.
7934
7935 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7936
7937         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7938         (csky_unwind_pc): Delete.
7939         (csky_unwind_sp): Delete.
7940         (csky_gdbarch_init): Don't register deleted functions with
7941         gdbarch.
7942
7943 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7944
7945         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7946         (cris_unwind_pc): Delete.
7947         (cris_unwind_sp): Delete.
7948         (cris_gdbarch_init): Don't register deleted functions with
7949         gdbarch.
7950
7951 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7952
7953         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7954         (bfin_unwind_pc): Delete.
7955         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7956
7957 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7958
7959         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7960         (arm_unwind_pc): Delete.
7961         (arm_unwind_sp): Delete.
7962         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7963
7964 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7965
7966         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7967         (arc_unwind_pc): Delete.
7968         (arc_unwind_sp): Delete.
7969         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7970
7971 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7972
7973         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7974         (alpha_unwind_pc): Delete.
7975         (alpha_gdbarch_init): Don't register deleted functions with
7976         gdbarch.
7977
7978 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7979
7980         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7981         (aarch64_unwind_pc): Delete.
7982         (aarch64_unwind_sp): Delete.
7983         (aarch64_gdbarch_init): Don't register deleted functions with
7984         gdbarch.
7985
7986 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7987
7988         * gdbtypes.c (type_align): Don't consider static members when
7989         computing structure alignment.
7990
7991 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7992
7993         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7994         return 0 for other types.
7995         * arch-utils.c (default_type_align): Always return 0.
7996         * gdbarch.h: Regenerate.
7997         * gdbarch.sh (type_align): Extend comment.
7998         * gdbtypes.c (type_align): Add additional comments, always call
7999         gdbarch_type_align before applying the default rules.
8000         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8001         generic code will then apply a suitable default.
8002         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8003         types, return 0 for other types.
8004
8005 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8006
8007         * NEWS: Create a new section for the next release branch.
8008         Rename the section of the current branch, now that it has
8009         been cut.
8010
8011 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8012
8013         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8014         * version.in: Bump version to 8.3.50.DATE-git.
8015
8016 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8017
8018         * aix-thread.c (ptid_cmp): Remove unused variable.
8019         (get_signaled_thread): Likewise.
8020         (store_regs_user_thread): Likewise.
8021         (store_regs_kernel_thread): Likewise.
8022         (fetch_regs_kernel_thread): Remove shadowed variable.
8023
8024 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8025
8026         * features/riscv/32bit-cpu.xml: Add register numbers.
8027         * features/riscv/32bit-fpu.c: Regenerate.
8028         * features/riscv/32bit-fpu.xml: Add register numbers.
8029         * features/riscv/64bit-cpu.xml: Add register numbers.
8030         * features/riscv/64bit-fpu.c: Regenerate.
8031         * features/riscv/64bit-fpu.xml: Add register numbers.
8032
8033 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8034
8035         * NEWS: Mention two argument form of gdb.Value constructor.
8036         * python/py-value.c (convert_buffer_and_type_to_value): New
8037         function.
8038         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8039         Add support for handling an optional second argument.  Call
8040         convert_buffer_and_type_to_value as appropriate.
8041         * python/python-internal.h (Py_buffer_deleter): New struct.
8042         (Py_buffer_up): New typedef.
8043
8044 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8045
8046         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8047         instead of releasing ownership.
8048
8049 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8050
8051         * dwarf2read.c (open_and_init_dwp_file): Call
8052         elf_numsections instead of bfd_count_sections to initialize
8053         dwp_file->num_sections.
8054
8055 2019-02-25  Tom Tromey  <tromey@adacore.com>
8056
8057         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8058
8059 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8060
8061         * gcore.in: Add '--readnever' option when invoking GDB.
8062
8063 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8064
8065         * MAINTAINERS: Update my email address.
8066
8067 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8068
8069         * build-id.c (build_id_to_debug_bfd_1): New function.
8070         (build_id_to_debug_bfd): Look for separate debug file in
8071         sysroot.
8072
8073 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8074
8075         * gdbarch.sh: Update the copyright year range that is placed into
8076         generated files.
8077
8078 2019-02-22  Keith Seitz  <keiths@redhat.com>
8079
8080         PR symtab/23853
8081         * linespec.c (create_sals_line_offset): Search for the default
8082         symtab's filename instead of its fullname.
8083
8084 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8085
8086         * NEWS: Update style defaults.
8087
8088 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8089
8090         * main.c (captured_main_1): Disable styling in batch mode.
8091
8092 2019-02-20  Tom Tromey  <tom@tromey.com>
8093
8094         * symtab.c (symtab_symbol_info): Fix typos.
8095
8096 2019-02-20  Tom Tromey  <tromey@adacore.com>
8097
8098         * findcmd.c (_initialize_mem_search): Use upper case for
8099         metasyntactic variables.
8100
8101 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8102
8103         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8104         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8105
8106 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8107
8108         * top.h (source_file_name): Change to std::string.
8109         * top.c (source_file_name): Likewise.
8110         (command_line_input): Adjust.
8111         * cli/cli-script.c (script_from_file): Adjust.
8112
8113 2019-02-19  Tom Tromey  <tromey@adacore.com>
8114
8115         * ravenscar-thread.c
8116         (ravenscar_thread_target::update_thread_list): Don't call
8117         ada_build_task_list.
8118         * ada-lang.h (ada_build_task_list): Don't declare.
8119         * ada-tasks.c (struct ada_tasks_inferior_data)
8120         <task_list_valid_p>: Now bool.
8121         (read_known_tasks, ada_task_list_changed)
8122         (ada_tasks_invalidate_inferior_data): Update.
8123         (read_known_tasks_array): Return bool.
8124         (read_known_tasks_list): Likewise.
8125         (read_known_tasks): Return void.
8126         (ada_build_task_list): Now static.
8127
8128 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8129
8130         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8131         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8132
8133 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8134
8135         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8136         variant for ada_tasks_pspace_data_handle and
8137         ada_tasks_inferior_data_handle.
8138         (ada_tasks_pspace_data_cleanup): New function.
8139         (ada_tasks_inferior_data_cleanup): New function.
8140
8141 2019-02-17  Tom Tromey  <tom@tromey.com>
8142
8143         * macrotab.h (macro_source_fullname): Return a std::string.
8144         * macrotab.c (macro_include, check_for_redefinition)
8145         (macro_undef, macro_lookup_definition, foreach_macro)
8146         (foreach_macro_in_scope): Update.
8147         (macro_source_fullname): Return a std::string.
8148         * macrocmd.c (show_pp_source_pos): Update.
8149
8150 2019-02-17  Tom Tromey  <tom@tromey.com>
8151
8152         * macrocmd.c (show_pp_source_pos): Style the file names.
8153
8154 2019-02-17  Tom Tromey  <tom@tromey.com>
8155
8156         PR tui/24197:
8157         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8158
8159 2019-02-17  Tom Tromey  <tom@tromey.com>
8160
8161         * ada-lang.c (user_select_syms): Use filtered printing.
8162         * utils.c (wrap_style): New global.
8163         (desired_style): Remove.
8164         (emit_style_escape): Add stream parameter.
8165         (set_output_style, reset_terminal_style, prompt_for_continue):
8166         Update.
8167         (flush_wrap_buffer): Only flush gdb_stdout.
8168         (wrap_here): Set wrap_style.
8169         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8170         treat escape sequences as a character.  Change when wrap buffer is
8171         flushed.
8172         (fputs_styled): Do not set the output style when the default is
8173         requested.
8174         * ui-style.h (struct ui_file_style) <is_default>: New method.
8175         * source.c (print_source_lines_base): Emit escape sequences in one
8176         piece.
8177
8178 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8179
8180         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8181         integers and enumeration types.
8182
8183 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8184
8185         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8186         instead of lookup_symbol_in_language
8187         (do_exact_match): New function.
8188         (ada_get_symbol_name_matcher): Return do_exact_match when
8189         doing a verbatim match.
8190
8191 2019-02-15  Tom Tromey  <tromey@adacore.com>
8192
8193         * ravenscar-thread.c (ravenscar_thread_target::resume)
8194         (ravenscar_thread_target::wait): Special case wildcard requests.
8195
8196 2019-02-15  Tom Tromey  <tromey@adacore.com>
8197
8198         * ravenscar-thread.c (base_ptid): Remove.
8199         (struct ravenscar_thread_target) <close>: New method.
8200         <m_base_ptid>: New member.
8201         <update_inferior_ptid, active_task, task_is_currently_active,
8202         runtime_initialized>: Declare methods.
8203         <ravenscar_thread_target>: Add constructor.
8204         (ravenscar_thread_target::task_is_currently_active)
8205         (ravenscar_thread_target::update_inferior_ptid)
8206         (ravenscar_runtime_initialized): Rename.  Now methods.
8207         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8208         (ravenscar_thread_target::update_thread_list): Update.
8209         (ravenscar_thread_target::active_task): Now method.
8210         (ravenscar_thread_target::store_registers)
8211         (ravenscar_thread_target::prepare_to_store)
8212         (ravenscar_thread_target::prepare_to_store)
8213         (ravenscar_thread_target::mourn_inferior): Update.
8214         (ravenscar_inferior_created): Use "new" to create target.
8215         (ravenscar_thread_target::get_ada_task_ptid): Update.
8216         (_initialize_ravenscar): Don't initialize base_ptid.
8217         (ravenscar_ops): Remove global.
8218
8219 2019-02-15  Tom Tromey  <tromey@adacore.com>
8220
8221         * target.h (push_target): Declare new overload.
8222         * target.c (push_target): New overload, taking an rvalue reference.
8223         * remote.c (remote_target::open_1): Use push_target overload.
8224         * corelow.c (core_target_open): Use push_target overload.
8225
8226 2019-02-15  Tom Tromey  <tromey@adacore.com>
8227
8228         * ravenscar-thread.c (is_ravenscar_task)
8229         (ravenscar_task_is_currently_active): Return bool.
8230         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8231         (_initialize_ravenscar): Remove "(void)".
8232         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8233         Return bool.
8234
8235 2019-02-15  Tom Tromey  <tromey@adacore.com>
8236
8237         * ravenscar-thread.c (ravenscar_runtime_initializer)
8238         (has_ravenscar_runtime, get_running_thread_id)
8239         (ravenscar_thread_target::resume): Fix indentation.
8240
8241 2019-02-15  Tom Tromey  <tromey@adacore.com>
8242
8243         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8244         from ravenscar_arch_ops.
8245         (sparc_ravenscar_ops::fetch_registers)
8246         (sparc_ravenscar_ops::store_registers): Now methods.
8247         (sparc_ravenscar_prepare_to_store): Remove.
8248         (sparc_ravenscar_ops): Redefine.
8249         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8250         methods and destructor.  Remove members.
8251         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8252         (ravenscar_thread_target::store_registers)
8253         (ravenscar_thread_target::prepare_to_store): Update.
8254         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8255         Remove.
8256         (struct ppc_ravenscar_powerpc_ops): Derive from
8257         ravenscar_arch_ops.
8258         (ppc_ravenscar_powerpc_ops::fetch_registers)
8259         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8260         (ppc_ravenscar_powerpc_ops): Redefine.
8261         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8262         (ppc_ravenscar_e500_ops::fetch_registers)
8263         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8264         (ppc_ravenscar_e500_ops): Redefine.
8265         * aarch64-ravenscar-thread.c
8266         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8267         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8268         (aarch64_ravenscar_fetch_registers)
8269         (aarch64_ravenscar_store_registers): Now methods.
8270         (aarch64_ravenscar_ops): Redefine.
8271
8272 2019-02-15  Tom Tromey  <tromey@adacore.com>
8273
8274         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8275         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8276         (ravenscar_thread_target::stopped_by_watchpoint)
8277         (ravenscar_thread_target::stopped_data_address)
8278         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8279
8280 2019-02-15  Tom Tromey  <tromey@adacore.com>
8281
8282         * ravenscar-thread.c: Fix some typos.
8283
8284 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8285             Tom Tromey  <tromey@adacore.com>
8286
8287         * ada-lang.c (ada_exception_sal): Change addr_string to a
8288         std::string.
8289         (create_ada_exception_catchpoint): Update.
8290
8291 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8292             Tom Tromey  <tromey@adacore.com>
8293
8294         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8295         (bp_location_ops): Remove.
8296         (base_breakpoint_allocate_location): Update.
8297         (free_bp_location): Update.
8298         * ada-lang.c (class ada_catchpoint_location)
8299         <ada_catchpoint_location>: Remove ops parameter.
8300         (ada_catchpoint_location_dtor): Remove.
8301         (ada_catchpoint_location_ops): Remove.
8302         (allocate_location_exception): Update.
8303         * breakpoint.h (struct bp_location_ops): Remove.
8304         (class bp_location) <bp_location>: Remove bp_location_ops
8305         parameter.
8306         <~bp_location>: Add destructor.
8307         <ops>: Remove.
8308
8309 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8310             Pedro Alves  <palves@redhat.com>
8311
8312         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8313         'PATH_MAX'.
8314
8315 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8316             Samuel Thibault  <samuel.thibault@gnu.org>
8317             Thomas Schwinge  <thomas@codesourcery.com>
8318
8319         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8320         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8321
8322 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8323
8324         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8325         (check_empty): Use "const char *".
8326
8327         * gnu-nat.c (gnu_nat_target::detach): Instead of
8328         'detach_inferior (pid)' call
8329         'detach_inferior (find_inferior_pid (pid))'.
8330
8331         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8332         'nat/fork-inferior.o'.
8333         * gnu-nat.c: #include "nat/fork-inferior.h".
8334
8335         * gnu-nat.c (gnu_nat_target::detach): Instead of
8336         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8337         * gnu-nat.h: #include "inf-child.h".
8338         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8339         'i386_gnu_nat_target::fetch_registers'.
8340         (gnu_store_registers): Rename/move to
8341         'i386_gnu_nat_target::store_registers'.
8342
8343         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8344         * gnu-nat.h (mach_thread_info): New function.
8345         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8346
8347         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8348
8349 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8350
8351         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8352
8353 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8354
8355         * windows-nat.c (windows_add_thread): Add new parameter
8356         "main_thread_p" with default value set to false.  Update
8357         function documentation as well as all callers.
8358         (windows_delete_thread): Likewise.
8359         (fake_create_process): Update call to windows_add_thread.
8360         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8361         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8362         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8363         call to windows_delete_thread.
8364
8365 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8366
8367         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8368
8369 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8370
8371         * symfile.c (find_separate_debug_file): Use canonical path of
8372         sysroot with child_path instead of gdb_sysroot if it is valid.
8373
8374 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8375
8376         * symfile.c (find_separate_debug_file): Use child_path to
8377         determine if an object file is under a sysroot.
8378
8379 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8380
8381         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8382         unittests/child-path-selftests.c.
8383         * common/pathstuff.c (child_path): New function.
8384         * common/pathstuff.h (child_path): New prototype.
8385         * unittests/child-path-selftests.c: New file.
8386
8387 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8388
8389         * symfile.c (find_separate_debug_file): Look for separate debug
8390         files in debug directories under the sysroot.
8391
8392 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8393
8394         * symtab.h (struct minimal_symbol data_p): New const method.
8395         (struct minimal_symbol text_p): Likewise.
8396         * symtab.c (output_source_filename): Use file name style
8397         to print file name.
8398         (print_symbol_info): Likewise.
8399         (print_msymbol_info): Use address style to print addresses.
8400         Use function name style to print executable text symbols.
8401         (expand_symtab_containing_pc): Use data_p.
8402         (find_pc_sect_compunit_symtab): Likewise.
8403
8404 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8405
8406         * breakpoint.c (describe_other_breakpoints): Use address style
8407         to print addresses.
8408         (say_where): Likewise.
8409
8410 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8411
8412         * ada-typeprint.c (print_func_type): Print function name
8413         style to print function name.
8414         * c-typeprint.c (c_print_type_1): Likewise.
8415
8416 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8417
8418         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8419         for execve.
8420
8421 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8422
8423         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8424         type_stack.
8425
8426 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8427
8428         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8429         TYPE_CODE_REF types.
8430
8431 2019-02-08  Jim Wilson  <jimw@sifive.com>
8432
8433         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8434         (riscv_linux_fregset): New.
8435         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8436
8437 2019-02-07  Tom Tromey  <tom@tromey.com>
8438
8439         * thread.c (thread_cancel_execution_command): Update.
8440         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8441         methods.
8442         (struct thread_fsm_ops): Remove.
8443         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8444         (thread_fsm_should_stop, thread_fsm_return_value)
8445         (thread_fsm_set_finished, thread_fsm_finished_p)
8446         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8447         Don't declare.
8448         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8449         * infrun.c (clear_proceed_status_thread)
8450         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8451         (print_stop_event): Update.
8452         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8453         Add constructor.
8454         (step_command_fsm_ops): Remove.
8455         (new_step_command_fsm): Remove.
8456         (step_1): Update.
8457         (step_command_fsm::should_stop): Rename from
8458         step_command_fsm_should_stop.
8459         (step_command_fsm::clean_up): Rename from
8460         step_command_fsm_clean_up.
8461         (step_command_fsm::do_async_reply_reason): Rename from
8462         step_command_fsm_async_reply_reason.
8463         (struct until_next_fsm): Inherit from thread_fsm.  Add
8464         constructor.
8465         (until_next_fsm_ops): Remove.
8466         (new_until_next_fsm): Remove.
8467         (until_next_fsm::should_stop): Rename from
8468         until_next_fsm_should_stop.
8469         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8470         (until_next_fsm::do_async_reply_reason): Rename from
8471         until_next_fsm_async_reply_reason.
8472         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8473         constructor.  Change type of breakpoint.
8474         (finish_command_fsm_ops): Remove.
8475         (new_finish_command_fsm): Remove.
8476         (finish_command_fsm::should_stop): Rename from
8477         finish_command_fsm_should_stop.
8478         (finish_command_fsm::clean_up): Rename from
8479         finish_command_fsm_clean_up.
8480         (finish_command_fsm::return_value): Rename from
8481         finish_command_fsm_return_value.
8482         (finish_command_fsm::do_async_reply_reason): Rename from
8483         finish_command_fsm_async_reply_reason.
8484         (finish_command): Update.
8485         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8486         Add constructor.
8487         (call_thread_fsm_ops): Remove.
8488         (call_thread_fsm::call_thread_fsm): Rename from
8489         new_call_thread_fsm.
8490         (call_thread_fsm::should_stop): Rename from
8491         call_thread_fsm_should_stop.
8492         (call_thread_fsm::should_notify_stop): Rename from
8493         call_thread_fsm_should_notify_stop.
8494         (run_inferior_call, call_function_by_hand_dummy): Update.
8495         * cli/cli-interp.c (should_print_stop_to_console): Update.
8496         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8497         Add constructor.  Change type of location_breakpoint,
8498         caller_breakpoint.
8499         (until_break_fsm_ops): Remove.
8500         (new_until_break_fsm): Remove.
8501         (until_break_fsm::should_stop): Rename from
8502         until_break_fsm_should_stop.
8503         (until_break_fsm::clean_up): Rename from
8504         until_break_fsm_clean_up.
8505         (until_break_fsm::do_async_reply_reason): Rename from
8506         until_break_fsm_async_reply_reason.
8507         (until_break_command): Update.
8508         * thread-fsm.c: Remove.
8509         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8510
8511 2019-02-07  Tom Tromey  <tom@tromey.com>
8512
8513         * yy-remap.h: Add include guard.
8514         * xtensa-tdep.h: Add include guard.
8515         * xcoffread.h: Rename include guard.
8516         * varobj-iter.h: Add include guard.
8517         * tui/tui.h: Rename include guard.
8518         * tui/tui-winsource.h: Rename include guard.
8519         * tui/tui-wingeneral.h: Rename include guard.
8520         * tui/tui-windata.h: Rename include guard.
8521         * tui/tui-win.h: Rename include guard.
8522         * tui/tui-stack.h: Rename include guard.
8523         * tui/tui-source.h: Rename include guard.
8524         * tui/tui-regs.h: Rename include guard.
8525         * tui/tui-out.h: Rename include guard.
8526         * tui/tui-layout.h: Rename include guard.
8527         * tui/tui-io.h: Rename include guard.
8528         * tui/tui-hooks.h: Rename include guard.
8529         * tui/tui-file.h: Rename include guard.
8530         * tui/tui-disasm.h: Rename include guard.
8531         * tui/tui-data.h: Rename include guard.
8532         * tui/tui-command.h: Rename include guard.
8533         * tic6x-tdep.h: Add include guard.
8534         * target/waitstatus.h: Rename include guard.
8535         * target/wait.h: Rename include guard.
8536         * target/target.h: Rename include guard.
8537         * target/resume.h: Rename include guard.
8538         * target-float.h: Rename include guard.
8539         * stabsread.h: Add include guard.
8540         * rs6000-tdep.h: Add include guard.
8541         * riscv-fbsd-tdep.h: Add include guard.
8542         * regformats/regdef.h: Rename include guard.
8543         * record.h: Rename include guard.
8544         * python/python.h: Rename include guard.
8545         * python/python-internal.h: Rename include guard.
8546         * python/py-stopevent.h: Rename include guard.
8547         * python/py-ref.h: Rename include guard.
8548         * python/py-record.h: Rename include guard.
8549         * python/py-record-full.h: Rename include guard.
8550         * python/py-record-btrace.h: Rename include guard.
8551         * python/py-instruction.h: Rename include guard.
8552         * python/py-events.h: Rename include guard.
8553         * python/py-event.h: Rename include guard.
8554         * procfs.h: Add include guard.
8555         * proc-utils.h: Add include guard.
8556         * p-lang.h: Add include guard.
8557         * or1k-tdep.h: Rename include guard.
8558         * observable.h: Rename include guard.
8559         * nto-tdep.h: Rename include guard.
8560         * nat/x86-linux.h: Rename include guard.
8561         * nat/x86-linux-dregs.h: Rename include guard.
8562         * nat/x86-gcc-cpuid.h: Add include guard.
8563         * nat/x86-dregs.h: Rename include guard.
8564         * nat/x86-cpuid.h: Rename include guard.
8565         * nat/ppc-linux.h: Rename include guard.
8566         * nat/mips-linux-watch.h: Rename include guard.
8567         * nat/linux-waitpid.h: Rename include guard.
8568         * nat/linux-ptrace.h: Rename include guard.
8569         * nat/linux-procfs.h: Rename include guard.
8570         * nat/linux-osdata.h: Rename include guard.
8571         * nat/linux-nat.h: Rename include guard.
8572         * nat/linux-namespaces.h: Rename include guard.
8573         * nat/linux-btrace.h: Rename include guard.
8574         * nat/glibc_thread_db.h: Rename include guard.
8575         * nat/gdb_thread_db.h: Rename include guard.
8576         * nat/gdb_ptrace.h: Rename include guard.
8577         * nat/fork-inferior.h: Rename include guard.
8578         * nat/amd64-linux-siginfo.h: Rename include guard.
8579         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8580         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8581         * nat/aarch64-linux.h: Rename include guard.
8582         * nat/aarch64-linux-hw-point.h: Rename include guard.
8583         * mn10300-tdep.h: Add include guard.
8584         * mips-linux-tdep.h: Add include guard.
8585         * mi/mi-parse.h: Rename include guard.
8586         * mi/mi-out.h: Rename include guard.
8587         * mi/mi-main.h: Rename include guard.
8588         * mi/mi-interp.h: Rename include guard.
8589         * mi/mi-getopt.h: Rename include guard.
8590         * mi/mi-console.h: Rename include guard.
8591         * mi/mi-common.h: Rename include guard.
8592         * mi/mi-cmds.h: Rename include guard.
8593         * mi/mi-cmd-break.h: Rename include guard.
8594         * m2-lang.h: Add include guard.
8595         * location.h: Rename include guard.
8596         * linux-record.h: Rename include guard.
8597         * linux-nat.h: Add include guard.
8598         * linux-fork.h: Add include guard.
8599         * i386-darwin-tdep.h: Rename include guard.
8600         * hppa-linux-offsets.h: Add include guard.
8601         * guile/guile.h: Rename include guard.
8602         * guile/guile-internal.h: Rename include guard.
8603         * gnu-nat.h: Rename include guard.
8604         * gdb-stabs.h: Rename include guard.
8605         * frv-tdep.h: Add include guard.
8606         * f-lang.h: Add include guard.
8607         * event-loop.h: Add include guard.
8608         * darwin-nat.h: Rename include guard.
8609         * cp-abi.h: Rename include guard.
8610         * config/sparc/nm-sol2.h: Rename include guard.
8611         * config/nm-nto.h: Rename include guard.
8612         * config/nm-linux.h: Add include guard.
8613         * config/i386/nm-i386gnu.h: Rename include guard.
8614         * config/djgpp/nl_types.h: Rename include guard.
8615         * config/djgpp/langinfo.h: Rename include guard.
8616         * compile/gcc-cp-plugin.h: Add include guard.
8617         * compile/gcc-c-plugin.h: Add include guard.
8618         * compile/compile.h: Rename include guard.
8619         * compile/compile-object-run.h: Rename include guard.
8620         * compile/compile-object-load.h: Rename include guard.
8621         * compile/compile-internal.h: Rename include guard.
8622         * compile/compile-cplus.h: Rename include guard.
8623         * compile/compile-c.h: Rename include guard.
8624         * common/xml-utils.h: Rename include guard.
8625         * common/x86-xstate.h: Rename include guard.
8626         * common/version.h: Rename include guard.
8627         * common/vec.h: Rename include guard.
8628         * common/tdesc.h: Rename include guard.
8629         * common/selftest.h: Rename include guard.
8630         * common/scoped_restore.h: Rename include guard.
8631         * common/scoped_mmap.h: Rename include guard.
8632         * common/scoped_fd.h: Rename include guard.
8633         * common/safe-iterator.h: Rename include guard.
8634         * common/run-time-clock.h: Rename include guard.
8635         * common/refcounted-object.h: Rename include guard.
8636         * common/queue.h: Rename include guard.
8637         * common/ptid.h: Rename include guard.
8638         * common/print-utils.h: Rename include guard.
8639         * common/preprocessor.h: Rename include guard.
8640         * common/pathstuff.h: Rename include guard.
8641         * common/observable.h: Rename include guard.
8642         * common/netstuff.h: Rename include guard.
8643         * common/job-control.h: Rename include guard.
8644         * common/host-defs.h: Rename include guard.
8645         * common/gdb_wait.h: Rename include guard.
8646         * common/gdb_vecs.h: Rename include guard.
8647         * common/gdb_unlinker.h: Rename include guard.
8648         * common/gdb_unique_ptr.h: Rename include guard.
8649         * common/gdb_tilde_expand.h: Rename include guard.
8650         * common/gdb_sys_time.h: Rename include guard.
8651         * common/gdb_string_view.h: Rename include guard.
8652         * common/gdb_splay_tree.h: Rename include guard.
8653         * common/gdb_setjmp.h: Rename include guard.
8654         * common/gdb_ref_ptr.h: Rename include guard.
8655         * common/gdb_optional.h: Rename include guard.
8656         * common/gdb_locale.h: Rename include guard.
8657         * common/gdb_assert.h: Rename include guard.
8658         * common/filtered-iterator.h: Rename include guard.
8659         * common/filestuff.h: Rename include guard.
8660         * common/fileio.h: Rename include guard.
8661         * common/environ.h: Rename include guard.
8662         * common/common-utils.h: Rename include guard.
8663         * common/common-types.h: Rename include guard.
8664         * common/common-regcache.h: Rename include guard.
8665         * common/common-inferior.h: Rename include guard.
8666         * common/common-gdbthread.h: Rename include guard.
8667         * common/common-exceptions.h: Rename include guard.
8668         * common/common-defs.h: Rename include guard.
8669         * common/common-debug.h: Rename include guard.
8670         * common/cleanups.h: Rename include guard.
8671         * common/buffer.h: Rename include guard.
8672         * common/btrace-common.h: Rename include guard.
8673         * common/break-common.h: Rename include guard.
8674         * cli/cli-utils.h: Rename include guard.
8675         * cli/cli-style.h: Rename include guard.
8676         * cli/cli-setshow.h: Rename include guard.
8677         * cli/cli-script.h: Rename include guard.
8678         * cli/cli-interp.h: Rename include guard.
8679         * cli/cli-decode.h: Rename include guard.
8680         * cli/cli-cmds.h: Rename include guard.
8681         * charset-list.h: Add include guard.
8682         * buildsym-legacy.h: Rename include guard.
8683         * bfin-tdep.h: Add include guard.
8684         * ax.h: Rename include guard.
8685         * arm-linux-tdep.h: Add include guard.
8686         * arm-fbsd-tdep.h: Add include guard.
8687         * arch/xtensa.h: Rename include guard.
8688         * arch/tic6x.h: Add include guard.
8689         * arch/i386.h: Add include guard.
8690         * arch/arm.h: Rename include guard.
8691         * arch/arm-linux.h: Rename include guard.
8692         * arch/arm-get-next-pcs.h: Rename include guard.
8693         * arch/amd64.h: Add include guard.
8694         * arch/aarch64-insn.h: Rename include guard.
8695         * arch-utils.h: Rename include guard.
8696         * annotate.h: Add include guard.
8697         * amd64-darwin-tdep.h: Rename include guard.
8698         * aarch64-linux-tdep.h: Add include guard.
8699         * aarch64-fbsd-tdep.h: Add include guard.
8700         * aarch32-linux-nat.h: Add include guard.
8701
8702 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8703
8704         * macrotab.c (macro_define_internal): New function that
8705         factorizes macro_define_object_internal and macro_define_function
8706         code.
8707         (macro_define_object_internal): Use macro_define_internal.
8708         (macro_define_function): Likewise.
8709
8710 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8711
8712         * macrocmd.c (extract_identifier): Return
8713         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8714         callers.
8715
8716 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8717
8718         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8719
8720 2019-02-05  Tom Tromey  <tom@tromey.com>
8721
8722         * target.c (target_stack::unpush): Move assertion earlier.
8723
8724 2019-01-30  Tom Tromey  <tom@tromey.com>
8725
8726         PR python/23615:
8727         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8728         (gdbpy_parse_and_eval): Likewise.
8729         * python/python-internal.h (gdbpy_allow_threads): New class.
8730
8731 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8732
8733         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8734         (aarch64_fbsd_fpregmap): Move earlier.
8735         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8736         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8737         instead of individual calls to trad_frame_set_reg_addr.
8738         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8739         earlier.
8740         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8741         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8742         instead of individual calls to trad_frame_set_reg_addr.
8743
8744 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8745
8746         * CONTRIBUTE: Replace contribution list with wiki link.
8747
8748 2019-01-25  Tom Tromey  <tom@tromey.com>
8749
8750         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8751
8752 2019-01-25  Tom Tromey  <tom@tromey.com>
8753
8754         * xtensa-linux-nat.c: Fix common/ includes.
8755         * xml-support.h: Fix common/ includes.
8756         * xml-support.c: Fix common/ includes.
8757         * x86-linux-nat.c: Fix common/ includes.
8758         * windows-nat.c: Fix common/ includes.
8759         * varobj.h: Fix common/ includes.
8760         * varobj.c: Fix common/ includes.
8761         * value.c: Fix common/ includes.
8762         * valops.c: Fix common/ includes.
8763         * utils.c: Fix common/ includes.
8764         * unittests/xml-utils-selftests.c: Fix common/ includes.
8765         * unittests/utils-selftests.c: Fix common/ includes.
8766         * unittests/unpack-selftests.c: Fix common/ includes.
8767         * unittests/tracepoint-selftests.c: Fix common/ includes.
8768         * unittests/style-selftests.c: Fix common/ includes.
8769         * unittests/string_view-selftests.c: Fix common/ includes.
8770         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8771         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8772         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8773         * unittests/rsp-low-selftests.c: Fix common/ includes.
8774         * unittests/parse-connection-spec-selftests.c: Fix common/
8775         includes.
8776         * unittests/optional-selftests.c: Fix common/ includes.
8777         * unittests/offset-type-selftests.c: Fix common/ includes.
8778         * unittests/observable-selftests.c: Fix common/ includes.
8779         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8780         * unittests/memrange-selftests.c: Fix common/ includes.
8781         * unittests/memory-map-selftests.c: Fix common/ includes.
8782         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8783         * unittests/function-view-selftests.c: Fix common/ includes.
8784         * unittests/environ-selftests.c: Fix common/ includes.
8785         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8786         * unittests/common-utils-selftests.c: Fix common/ includes.
8787         * unittests/cli-utils-selftests.c: Fix common/ includes.
8788         * unittests/array-view-selftests.c: Fix common/ includes.
8789         * ui-file.c: Fix common/ includes.
8790         * tui/tui-io.c: Fix common/ includes.
8791         * tracepoint.h: Fix common/ includes.
8792         * tracepoint.c: Fix common/ includes.
8793         * tracefile-tfile.c: Fix common/ includes.
8794         * top.h: Fix common/ includes.
8795         * top.c: Fix common/ includes.
8796         * thread.c: Fix common/ includes.
8797         * target/waitstatus.h: Fix common/ includes.
8798         * target/waitstatus.c: Fix common/ includes.
8799         * target.h: Fix common/ includes.
8800         * target.c: Fix common/ includes.
8801         * target-memory.c: Fix common/ includes.
8802         * target-descriptions.c: Fix common/ includes.
8803         * symtab.h: Fix common/ includes.
8804         * symfile.c: Fix common/ includes.
8805         * stap-probe.c: Fix common/ includes.
8806         * spu-linux-nat.c: Fix common/ includes.
8807         * sparc-nat.c: Fix common/ includes.
8808         * source.c: Fix common/ includes.
8809         * solib.c: Fix common/ includes.
8810         * solib-target.c: Fix common/ includes.
8811         * ser-unix.c: Fix common/ includes.
8812         * ser-tcp.c: Fix common/ includes.
8813         * ser-pipe.c: Fix common/ includes.
8814         * ser-base.c: Fix common/ includes.
8815         * selftest-arch.c: Fix common/ includes.
8816         * s12z-tdep.c: Fix common/ includes.
8817         * rust-exp.y: Fix common/ includes.
8818         * rs6000-aix-tdep.c: Fix common/ includes.
8819         * riscv-tdep.c: Fix common/ includes.
8820         * remote.c: Fix common/ includes.
8821         * remote-notif.h: Fix common/ includes.
8822         * remote-fileio.h: Fix common/ includes.
8823         * remote-fileio.c: Fix common/ includes.
8824         * regcache.h: Fix common/ includes.
8825         * regcache.c: Fix common/ includes.
8826         * record-btrace.c: Fix common/ includes.
8827         * python/python.c: Fix common/ includes.
8828         * python/py-type.c: Fix common/ includes.
8829         * python/py-inferior.c: Fix common/ includes.
8830         * progspace.h: Fix common/ includes.
8831         * producer.c: Fix common/ includes.
8832         * procfs.c: Fix common/ includes.
8833         * proc-api.c: Fix common/ includes.
8834         * printcmd.c: Fix common/ includes.
8835         * ppc-linux-nat.c: Fix common/ includes.
8836         * parser-defs.h: Fix common/ includes.
8837         * osdata.c: Fix common/ includes.
8838         * obsd-nat.c: Fix common/ includes.
8839         * nat/x86-linux.c: Fix common/ includes.
8840         * nat/x86-linux-dregs.c: Fix common/ includes.
8841         * nat/x86-dregs.h: Fix common/ includes.
8842         * nat/x86-dregs.c: Fix common/ includes.
8843         * nat/ppc-linux.c: Fix common/ includes.
8844         * nat/mips-linux-watch.h: Fix common/ includes.
8845         * nat/mips-linux-watch.c: Fix common/ includes.
8846         * nat/linux-waitpid.c: Fix common/ includes.
8847         * nat/linux-ptrace.h: Fix common/ includes.
8848         * nat/linux-ptrace.c: Fix common/ includes.
8849         * nat/linux-procfs.c: Fix common/ includes.
8850         * nat/linux-personality.c: Fix common/ includes.
8851         * nat/linux-osdata.c: Fix common/ includes.
8852         * nat/linux-namespaces.c: Fix common/ includes.
8853         * nat/linux-btrace.h: Fix common/ includes.
8854         * nat/linux-btrace.c: Fix common/ includes.
8855         * nat/fork-inferior.c: Fix common/ includes.
8856         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8857         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8858         * nat/aarch64-linux.c: Fix common/ includes.
8859         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8860         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8861         * namespace.h: Fix common/ includes.
8862         * mips-linux-tdep.c: Fix common/ includes.
8863         * minsyms.c: Fix common/ includes.
8864         * mi/mi-parse.h: Fix common/ includes.
8865         * mi/mi-main.c: Fix common/ includes.
8866         * mi/mi-cmd-env.c: Fix common/ includes.
8867         * memrange.h: Fix common/ includes.
8868         * memattr.c: Fix common/ includes.
8869         * maint.h: Fix common/ includes.
8870         * maint.c: Fix common/ includes.
8871         * main.c: Fix common/ includes.
8872         * machoread.c: Fix common/ includes.
8873         * location.c: Fix common/ includes.
8874         * linux-thread-db.c: Fix common/ includes.
8875         * linux-nat.c: Fix common/ includes.
8876         * linux-fork.c: Fix common/ includes.
8877         * inline-frame.c: Fix common/ includes.
8878         * infrun.c: Fix common/ includes.
8879         * inflow.c: Fix common/ includes.
8880         * inferior.h: Fix common/ includes.
8881         * inferior.c: Fix common/ includes.
8882         * infcmd.c: Fix common/ includes.
8883         * inf-ptrace.c: Fix common/ includes.
8884         * inf-child.c: Fix common/ includes.
8885         * ia64-linux-nat.c: Fix common/ includes.
8886         * i387-tdep.c: Fix common/ includes.
8887         * i386-tdep.c: Fix common/ includes.
8888         * i386-linux-tdep.c: Fix common/ includes.
8889         * i386-linux-nat.c: Fix common/ includes.
8890         * i386-go32-tdep.c: Fix common/ includes.
8891         * i386-fbsd-tdep.c: Fix common/ includes.
8892         * i386-fbsd-nat.c: Fix common/ includes.
8893         * guile/scm-type.c: Fix common/ includes.
8894         * guile/guile.c: Fix common/ includes.
8895         * go32-nat.c: Fix common/ includes.
8896         * gnu-nat.c: Fix common/ includes.
8897         * gdbthread.h: Fix common/ includes.
8898         * gdbarch-selftests.c: Fix common/ includes.
8899         * gdb_usleep.c: Fix common/ includes.
8900         * gdb_select.h: Fix common/ includes.
8901         * gdb_bfd.c: Fix common/ includes.
8902         * gcore.c: Fix common/ includes.
8903         * fork-child.c: Fix common/ includes.
8904         * findvar.c: Fix common/ includes.
8905         * fbsd-nat.c: Fix common/ includes.
8906         * event-top.c: Fix common/ includes.
8907         * event-loop.c: Fix common/ includes.
8908         * dwarf2read.c: Fix common/ includes.
8909         * dwarf2loc.c: Fix common/ includes.
8910         * dwarf2-frame.c: Fix common/ includes.
8911         * dwarf-index-cache.c: Fix common/ includes.
8912         * dtrace-probe.c: Fix common/ includes.
8913         * disasm-selftests.c: Fix common/ includes.
8914         * defs.h: Fix common/ includes.
8915         * csky-tdep.c: Fix common/ includes.
8916         * cp-valprint.c: Fix common/ includes.
8917         * cp-support.h: Fix common/ includes.
8918         * cp-support.c: Fix common/ includes.
8919         * corelow.c: Fix common/ includes.
8920         * completer.h: Fix common/ includes.
8921         * completer.c: Fix common/ includes.
8922         * compile/compile.c: Fix common/ includes.
8923         * compile/compile-loc2c.c: Fix common/ includes.
8924         * compile/compile-cplus-types.c: Fix common/ includes.
8925         * compile/compile-cplus-symbols.c: Fix common/ includes.
8926         * command.h: Fix common/ includes.
8927         * cli/cli-dump.c: Fix common/ includes.
8928         * cli/cli-cmds.c: Fix common/ includes.
8929         * charset.c: Fix common/ includes.
8930         * build-id.c: Fix common/ includes.
8931         * btrace.h: Fix common/ includes.
8932         * btrace.c: Fix common/ includes.
8933         * breakpoint.h: Fix common/ includes.
8934         * breakpoint.c: Fix common/ includes.
8935         * ax.h:
8936         (enum agent_op): Fix common/ includes.
8937         * ax-general.c (struct aop_map): Fix common/ includes.
8938         * ax-gdb.c: Fix common/ includes.
8939         * auxv.c: Fix common/ includes.
8940         * auto-load.c: Fix common/ includes.
8941         * arm-tdep.c: Fix common/ includes.
8942         * arch/riscv.c: Fix common/ includes.
8943         * arch/ppc-linux-common.c: Fix common/ includes.
8944         * arch/i386.c: Fix common/ includes.
8945         * arch/arm.c: Fix common/ includes.
8946         * arch/arm-linux.c: Fix common/ includes.
8947         * arch/arm-get-next-pcs.c: Fix common/ includes.
8948         * arch/amd64.c: Fix common/ includes.
8949         * arch/aarch64.c: Fix common/ includes.
8950         * arch/aarch64-insn.c: Fix common/ includes.
8951         * arch-utils.c: Fix common/ includes.
8952         * amd64-windows-tdep.c: Fix common/ includes.
8953         * amd64-tdep.c: Fix common/ includes.
8954         * amd64-sol2-tdep.c: Fix common/ includes.
8955         * amd64-obsd-tdep.c: Fix common/ includes.
8956         * amd64-nbsd-tdep.c: Fix common/ includes.
8957         * amd64-linux-tdep.c: Fix common/ includes.
8958         * amd64-linux-nat.c: Fix common/ includes.
8959         * amd64-fbsd-tdep.c: Fix common/ includes.
8960         * amd64-fbsd-nat.c: Fix common/ includes.
8961         * amd64-dicos-tdep.c: Fix common/ includes.
8962         * amd64-darwin-tdep.c: Fix common/ includes.
8963         * agent.c: Fix common/ includes.
8964         * ada-lang.h: Fix common/ includes.
8965         * ada-lang.c: Fix common/ includes.
8966         * aarch64-tdep.c: Fix common/ includes.
8967
8968 2019-01-25  Tom Tromey  <tom@tromey.com>
8969
8970         * common/create-version.sh: Use common/version.h.
8971
8972 2019-01-24  Pedro Alves  <palves@redhat.com>
8973
8974         * infrun.c (signal_stop, signal_print, signal_program)
8975         (signal_catch, signal_pass): Now arrays instead of pointers.
8976         (update_signals_program_target, do_target_resume)
8977         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8978         * linux-nat.c (linux_nat_target::pass_signals)
8979         (linux_nat_target::create_inferior, linux_nat_target::attach):
8980         Adjust.
8981         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8982         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8983         * procfs.c (procfs_target::pass_signals): Adjust.
8984         * record-full.c (record_full_target::resume): Adjust.
8985         * remote.c (remote_target::pass_signals)
8986         (remote_target::program_signals): Adjust.
8987         * target-debug.h (target_debug_print_signals): Now takes a
8988         gdb::array_view as parameter.  Adjust.
8989         * target.h (target_ops) <pass_signals, program_signals>: Replace
8990         pointer and length parameters with gdb::array_view.
8991         (target_pass_signals, target_program_signals): Likewise.
8992         * target-delegates.c: Regenerate.
8993
8994 2019-01-24  Pedro Alves  <palves@redhat.com>
8995
8996         * common/forward-scope-exit.h
8997         (forward_scope_exit::forward_scope_exit): Pass arguments to
8998         m_bind_function directly, instead of creating a std::bind and
8999         copying that.
9000
9001 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9002
9003         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9004         for static members.
9005         (pass_in_v_vfp_candidate): Likewise.
9006
9007 2019-01-23  Tom Tromey  <tom@tromey.com>
9008             Pedro Alves  <palves@redhat.com>
9009
9010         * regcache.c (class regcache_invalidator): Remove.
9011         (regcache::raw_write): Use make_scope_exit.
9012
9013 2019-01-23  Tom Tromey  <tom@tromey.com>
9014
9015         * ui-out.h (class ui_out_emit_type): Update comment.
9016
9017 2019-01-23  Tom Tromey  <tom@tromey.com>
9018
9019         * infrun.c (fetch_inferior_event): Update comment.
9020
9021 2019-01-23  Tom Tromey  <tom@tromey.com>
9022             Pedro Alves  <palves@redhat.com>
9023
9024         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9025         parameter.
9026         (fetch_inferior_event): Use SCOPE_EXIT.
9027
9028
9029 2019-01-23  Tom Tromey  <tom@tromey.com>
9030             Pedro Alves  <palves@redhat.com>
9031
9032         * infrun.c (disable_thread_events): Delete.
9033         (stop_all_threads): Use SCOPE_EXIT.
9034
9035 2019-01-23  Tom Tromey  <tom@tromey.com>
9036             Pedro Alves  <palves@redhat.com>
9037
9038         * symfile.c: Include forward-scope-exit.h.
9039         (clear_symtab_users_cleanup): Replace forward declaration with
9040         a FORWARD_SCOPE_EXIT.
9041         (syms_from_objfile_1): Use the forward_scope_exit and
9042         gdb::optional instead of cleanup_function.
9043         (reread_symbols): Use the forward_scope_exit instead of
9044         cleanup_function.
9045         (clear_symtab_users_cleanup): Remove function.
9046
9047 2019-01-23  Tom Tromey  <tom@tromey.com>
9048             Pedro Alves  <palves@redhat.com>
9049
9050         * linux-nat.c: Include scope-exit.h.
9051         (cleanup_target_stop): Remove.
9052         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9053         SCOPE_EXIT.
9054
9055 2019-01-23  Tom Tromey  <tom@tromey.com>
9056             Pedro Alves  <palves@redhat.com>
9057
9058         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9059         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9060
9061 2019-01-23  Tom Tromey  <tom@tromey.com>
9062             Andrew Burgess  <andrew.burgess@embecosm.com>
9063             Pedro Alves  <palves@redhat.com>
9064
9065         * infrun.c (fetch_inferior_event): Use scope_exit.
9066         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9067         * top.c (execute_command): Use scope_exit.
9068         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9069         * utils.c (do_bpstat_clear_actions_cleanup)
9070         (make_bpstat_clear_actions_cleanup): Remove.
9071
9072 2019-01-23  Tom Tromey  <tom@tromey.com>
9073             Pedro Alves  <palves@redhat.com>
9074
9075         * infrun.c: Include "common/scope-exit.h"
9076         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9077         (wait_for_inferior): Use SCOPE_EXIT.
9078         (fetch_inferior_event): Use scope_exit.
9079
9080 2019-01-23  Tom Tromey  <tom@tromey.com>
9081             Pedro Alves  <palves@redhat.com>
9082
9083         * breakpoint.c (create_breakpoint): Remove cleanup.
9084
9085 2019-01-23  Tom Tromey  <tom@tromey.com>
9086             Andrew Burgess  <andrew.burgess@embecosm.com>
9087             Pedro Alves  <palves@redhat.com>
9088
9089 2019-01-23  Pedro Alves  <palves@redhat.com>
9090
9091         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9092
9093 2019-01-23  Pedro Alves  <palves@redhat.com>
9094             Andrew Burgess  <andrew.burgess@embecosm.com>
9095
9096         * gdbthread.h: Include "common/forward-scope-exit.h".
9097         (scoped_finish_thread_state): Redefine custom class in terms of
9098         forward_scope_exit.
9099
9100 2019-01-23  Pedro Alves  <palves@redhat.com>
9101             Andrew Burgess  <andrew.burgess@embecosm.com>
9102
9103         * common/forward-scope-exit.h: New file.
9104
9105 2019-01-23  Pedro Alves  <palves@redhat.com>
9106             Andrew Burgess  <andrew.burgess@embecosm.com>
9107             Tom Tromey  <tom@tromey.com>
9108
9109         * common/scope-exit.h: New file.
9110
9111 2019-01-23  Pedro Alves  <palves@redhat.com>
9112
9113         * common/preprocessor.h (ESC): Rename to ...
9114         (ESC_PARENS): ... this.
9115         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9116         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9117
9118 2019-01-23  Tom Tromey  <tom@tromey.com>
9119
9120         * language.h (class scoped_switch_to_sym_language_if_auto):
9121         Initialize m_lang in both cases.
9122
9123 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9124
9125         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9126         with XCNEW.
9127
9128 2019-01-22  Tom Tromey  <tom@tromey.com>
9129
9130         * corelow.c: Do not include sys/file.h.
9131
9132 2019-01-22  Tom Tromey  <tom@tromey.com>
9133
9134         * tui/tui-wingeneral.h: Include gdb_curses.h.
9135
9136 2019-01-22  Tom Tromey  <tom@tromey.com>
9137
9138         * source-cache.h (class source_cache) <get_source_lines,
9139         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9140
9141 2019-01-22  Tom Tromey  <tom@tromey.com>
9142
9143         * remote-fileio.h (struct remote_target): Declare.
9144
9145 2019-01-22  Tom Tromey  <tom@tromey.com>
9146
9147         * python/py-arch.c: Do not include py-ref.h.
9148         * python/py-bpevent.c: Do not include py-ref.h.
9149         * python/py-cmd.c: Do not include py-ref.h.
9150         * python/py-continueevent.c: Do not include py-ref.h.
9151         * python/py-event.h: Do not include py-ref.h.
9152         * python/py-evtregistry.c: Do not include py-ref.h.
9153         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9154         * python/py-frame.c: Do not include py-ref.h.
9155         * python/py-framefilter.c: Do not include py-ref.h.
9156         * python/py-function.c: Do not include py-ref.h.
9157         * python/py-infevents.c: Do not include py-ref.h.
9158         * python/py-linetable.c: Do not include py-ref.h.
9159         * python/py-objfile.c: Do not include py-ref.h.
9160         * python/py-param.c: Do not include py-ref.h.
9161         * python/py-prettyprint.c: Do not include py-ref.h.
9162         * python/py-progspace.c: Do not include py-ref.h.
9163         * python/py-symbol.c: Do not include py-ref.h.
9164         * python/py-symtab.c: Do not include py-ref.h.
9165         * python/py-type.c: Do not include py-ref.h.
9166         * python/py-unwind.c: Do not include py-ref.h.
9167         * python/py-utils.c: Do not include py-ref.h.
9168         * python/py-value.c: Do not include py-ref.h.
9169         * python/py-varobj.c: Do not include py-ref.h.
9170         * python/py-xmethods.c: Do not include py-ref.h.
9171         * python/python.c: Do not include py-ref.h.
9172         * varobj.c: Do not include py-ref.h.
9173
9174 2019-01-22  Tom Tromey  <tom@tromey.com>
9175
9176         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9177         keyword for bcache.
9178
9179 2019-01-22  Tom Tromey  <tom@tromey.com>
9180
9181         * compile/compile-cplus-types.c: Remove a comment by #include.
9182
9183 2019-01-22  Tom Tromey  <tom@tromey.com>
9184
9185         * compile/gcc-c-plugin.h: Include compile-internal.h.
9186
9187 2019-01-22  Tom Tromey  <tom@tromey.com>
9188
9189         * stabsread.c (EXTERN): Do not define.
9190         (symnum, next_symbol_text_func, processing_gcc_compilation)
9191         (within_function, global_sym_chain, global_stabs)
9192         (previous_stab_code, this_object_header_files)
9193         (n_this_object_header_files)
9194         (n_allocated_this_object_header_files): Define.
9195         * stabsread.h (EXTERN): Never define.  Use "extern".
9196
9197 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9198
9199         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9200         history_value.
9201
9202 2019-01-21  Tom Tromey  <tom@tromey.com>
9203
9204         * ui-out.c: Fix includes.
9205         * tui/tui-source.c: Fix includes.
9206         * target.c: Fix includes.
9207         * remote.c: Fix includes.
9208         * regcache.c: Fix includes.
9209         * python/py-block.c: Fix includes.
9210         * printcmd.c: Fix includes.
9211         * or1k-tdep.c: Fix includes.
9212         * mi/mi-main.c: Fix includes.
9213         * m32r-tdep.c: Fix includes.
9214         * csky-tdep.c: Fix includes.
9215         * compile/compile-cplus-types.c: Fix includes.
9216         * cli/cli-interp.c: Fix includes.
9217
9218 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9219
9220         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9221         for padding.
9222
9223 2019-01-16  Tom Tromey  <tom@tromey.com>
9224
9225         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9226         earlier.
9227         (struct objfile) <msymbols_range>: Move from top level.
9228         <msymbols>: New method.
9229         (class objfile_msymbols): Remove.
9230         * symtab.c (default_collect_symbol_completion_matches_break_on):
9231         Update.
9232         * symmisc.c (dump_msymbols): Update.
9233         * stabsread.c (scan_file_globals): Update.
9234         * objc-lang.c (info_selectors_command, info_classes_command)
9235         (find_methods): Update.
9236         * minsyms.c (find_solib_trampoline_target): Update.
9237         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9238         * coffread.c (coff_symfile_read): Update.
9239         * ada-lang.c (ada_lookup_simple_minsym)
9240         (ada_collect_symbol_completion_matches): Update.
9241
9242 2019-01-16  Tom Tromey  <tom@tromey.com>
9243
9244         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9245         type.  Remove no-argument constructor.
9246         <iterator::operator++>: Simplify.
9247         <begin>: Update.
9248         <end>: Use minimal_symbol_count.
9249
9250 2019-01-16  Tom Tromey  <tom@tromey.com>
9251
9252         * objfiles.h (struct objfile) <psymtabs>: New method.
9253         (class objfile_psymtabs): Remove.
9254         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9255         typedef.
9256         <range>: New method.
9257         (require_partial_symbols): Change return type.
9258         * psymtab.c (require_partial_symbols)
9259         (psym_expand_symtabs_matching): Update.
9260         * mdebugread.c (parse_partial_symbols): Update.
9261         * dbxread.c (dbx_end_psymtab): Update.
9262
9263 2019-01-15  Tom Tromey  <tom@tromey.com>
9264
9265         * symtab.c (lookup_objfile_from_block)
9266         (lookup_symbol_in_objfile_symtabs)
9267         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9268         (find_line_symtab, info_sources_command)
9269         (default_collect_symbol_completion_matches_break_on)
9270         (make_source_files_completion_list): Update.
9271         * symmisc.c (print_objfile_statistics, dump_objfile)
9272         (maintenance_print_symbols, maintenance_info_symtabs)
9273         (maintenance_check_symtabs, maintenance_info_line_tables):
9274         Update.
9275         * source.c (select_source_symtab)
9276         (forget_cached_source_info_for_objfile): Update.
9277         * objfiles.h (class objfile_compunits): Remove.
9278         (struct objfile) <compunits_range>: New typedef.
9279         (compunits): New method.
9280         * objfiles.c (objfile_relocate1): Update.
9281         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9282         * maint.c (count_symtabs_and_blocks): Update.
9283         * linespec.c (iterate_over_all_matching_symtabs): Update.
9284         * cp-support.c (add_symbol_overload_list_qualified): Update.
9285         * coffread.c (coff_symtab_read): Update.
9286         * ada-lang.c (add_nonlocal_symbols)
9287         (ada_collect_symbol_completion_matches)
9288         (ada_add_global_exceptions): Update.
9289
9290 2019-01-15  Tom Tromey  <tom@tromey.com>
9291
9292         * progspace.h (program_space) <objfiles_safe_range>: New
9293         typedef.
9294         <objfiles_safe>: New method.
9295         * objfiles.h (class all_objfiles_safe): Remove.
9296         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9297         * jit.c (jit_inferior_exit_hook): Update.
9298
9299 2019-01-17  Tom Tromey  <tom@tromey.com>
9300
9301         * progspace.h (program_space) <objfiles_range>: New typedef.
9302         <objfiles>: New method.
9303         <objfiles_head>: Rename from objfiles.
9304         (object_files): Update.
9305         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9306         * guile/scm-pretty-print.c
9307         (ppscm_find_pretty_printer_from_objfiles): Update.
9308         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9309         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9310         Update.
9311         * python/py-progspace.c (pspy_get_objfiles): Update.
9312         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9313         Update.
9314         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9315         (objfpy_lookup_objfile_by_build_id): Update.
9316         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9317         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9318         Update.
9319         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9320         (expand_symtab_containing_pc, lookup_objfile_from_block)
9321         (lookup_static_symbol, basic_lookup_transparent_type)
9322         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9323         (find_line_symtab, info_sources_command)
9324         (default_collect_symbol_completion_matches_break_on)
9325         (make_source_files_completion_list, find_main_name): Update.
9326         * symmisc.c (print_symbol_bcache_statistics)
9327         (print_objfile_statistics, maintenance_print_symbols)
9328         (maintenance_print_msymbols, maintenance_print_objfiles)
9329         (maintenance_info_symtabs, maintenance_check_symtabs)
9330         (maintenance_expand_symtabs, maintenance_info_line_tables):
9331         Update.
9332         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9333         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9334         (map_overlay_command, unmap_overlay_command)
9335         (simple_overlay_update, expand_symtabs_matching)
9336         (map_symbol_filenames): Update.
9337         * symfile-debug.c (set_debug_symfile): Update.
9338         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9339         Update.
9340         * source.c (select_source_symtab, forget_cached_source_info):
9341         Update.
9342         * solib.c (solib_read_symbols): Update.
9343         * solib-spu.c (append_ocl_sos): Update.
9344         * psymtab.c (maintenance_print_psymbols)
9345         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9346         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9347         * printcmd.c (info_symbol_command): Update.
9348         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9349         Update.
9350         * objfiles.h (class all_objfiles): Remove.
9351         * objfiles.c (have_partial_symbols, have_full_symbols)
9352         (have_minimal_symbols, qsort_cmp, update_section_map)
9353         (shared_objfile_contains_address_p)
9354         (default_iterate_over_objfiles_in_search_order): Update.
9355         * objc-lang.c (info_selectors_command, info_classes_command)
9356         (find_methods): Update.
9357         * minsyms.c (find_solib_trampoline_target): Update.
9358         * maint.c (maintenance_info_sections)
9359         (maintenance_translate_address, count_symtabs_and_blocks):
9360         Update.
9361         * main.c (captured_main_1): Update.
9362         * linux-thread-db.c (try_thread_db_load_from_pdir)
9363         (has_libpthread): Update.
9364         * linespec.c (iterate_over_all_matching_symtabs)
9365         (search_minsyms_for_name): Update.
9366         * jit.c (jit_find_objf_with_entry_addr): Update.
9367         * hppa-tdep.c (find_unwind_entry)
9368         (hppa_lookup_stub_minimal_symbol): Update.
9369         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9370         Update.
9371         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9372         (elf_gnu_ifunc_resolve_by_got): Update.
9373         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9374         * dwarf-index-write.c (save_gdb_index_command): Update.
9375         * cp-support.c (add_symbol_overload_list_qualified): Update.
9376         * breakpoint.c (create_overlay_event_breakpoint)
9377         (create_longjmp_master_breakpoint)
9378         (create_std_terminate_master_breakpoint)
9379         (create_exception_master_breakpoint): Update.
9380         * blockframe.c (find_pc_partial_function): Update.
9381         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9382         (ada_collect_symbol_completion_matches)
9383         (ada_add_global_exceptions): Update.
9384
9385 2019-01-17  Tom Tromey  <tom@tromey.com>
9386
9387         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9388         declare VEC.
9389         (solib_target_parse_libraries): Change return type.
9390         (library_list_start_segment, library_list_start_section)
9391         (library_list_end_library, library_list_start_library); Update.
9392         (solib_target_free_library_list): Remove.
9393         (solib_target_parse_libraries): Remove cleanup.  Change return
9394         type.
9395         (solib_target_current_sos): Update.
9396
9397 2019-01-17  Tom Tromey  <tromey@bapiya>
9398
9399         * valprint.c: Replace "the the" with "the".
9400         * symtab.c: Replace "the the" with "the".
9401         * solib.c: Replace "the the" with "the".
9402         * solib-dsbt.c: Replace "the the" with "the".
9403         * linespec.c: Replace "the the" with "the".
9404         * dwarf2loc.h: Replace "the the" with "the".
9405         * amd64-windows-tdep.c: Replace "the the" with "the".
9406         * aarch64-tdep.c: Replace "the the" with "the".
9407
9408 2019-01-16  Keith Seitz  <keiths@redhat.com>
9409
9410         PR gdb/23773
9411         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9412         <builder>: Rename to ..
9413         <m_builder>: ... this and make private.
9414         (dwarf2_cu::get_builder): New method.  Change all users of
9415         `builder' to use this method.
9416         (dwarf2_start_symtab): Move to ...
9417         (dwarf2_cu::start_symtab): ... here.  Update all callers
9418         (setup_type_unit_groups): Move to ...
9419         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9420         callers.
9421         (dwarf2_cu::reset_builder): New method.
9422         (process_full_compunit, process_full_type_unit): Use
9423         dwarf2_cu::reset_builder.
9424         (follow_die_offset): Record the ancestor CU if it is different
9425         from the followed DIE's CU.
9426         (follow_die_sig_1): Likewise.
9427
9428 2019-01-15  Tom Tromey  <tom@tromey.com>
9429
9430         * remote.c (class remote_state) <buf>: Now a char_vector.
9431         <buf_size>: Remove.
9432         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9433         parameter.
9434         (remote_target::getpkt_or_notif_sane_1)
9435         (remote_target::getpkt_sane)
9436         (remote_target::getpkt_or_notif_sane): Likewise.
9437         (class remote_target) <putpkt>: New overload.
9438         (remote_target::read_frame): Change type of "buf_p".  Remove
9439         sizeof_p parameter.
9440         (packet_ok): New overload.
9441         (packet_check_result): New overload.
9442         Update all uses.
9443
9444 2019-01-14  Tom Tromey  <tom@tromey.com>
9445
9446         * remote-notif.c (handle_notification, remote_notif_ack)
9447         (remote_notif_parse): Make "buf" const.
9448         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9449         const.
9450         (remote_notif_parse, remote_notif_ack, handle_notification):
9451         Likewise.
9452         * remote.c (remote_notif_stop_parse): Make "buf" const.
9453         (remote_target::remote_parse_stop_reply): Make "buf" const.
9454         (remote_notif_stop_ack): Make "buf" const.
9455
9456 2019-01-14  Tom Tromey  <tom@tromey.com>
9457
9458         * remote.c (remote_console_output): Make parameter const.
9459
9460 2019-01-14  Tom Tromey  <tom@tromey.com>
9461
9462         * target-debug.h (target_debug_print_signals): Constify.
9463         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9464         * procfs.c (procfs_target::pass_signals): Update.
9465         * linux-nat.c (linux_nat_target::pass_signals): Update.
9466         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9467         * target-delegates.c: Rebuild.
9468         * remote.c (remote_target::program_signals): Update.
9469         (remote_target::pass_signals): Update.
9470         * target.c (target_pass_signals): Constify argument.
9471         (target_program_signals): Likewise.
9472         * target.h (struct target_ops) <pass_signals, program_signals>:
9473         Constify argument.
9474         (target_pass_signals, target_program_signals): Constify argument.
9475
9476 2019-01-14  Tom Tromey  <tom@tromey.com>
9477
9478         PR tui/28819:
9479         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9480
9481 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9482
9483         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9484         field.
9485         * rs6000-tdep.c: Include reggroups.h.
9486         (IS_V_ALIAS_PSEUDOREG): Define.
9487         (rs6000_register_name): Return names for the "vX" aliases.
9488         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9489         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9490         aliases.  Call default_register_reggroup_p for all other
9491         pseudo-registers.
9492         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9493         New functions.
9494         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9495         Handle "vX" aliases.
9496         (v_alias_pseudo_register_collect): New function.
9497         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9498         (rs6000_gdbarch_init): Initialize "vX" aliases as
9499         pseudo-registers.  Restore registration of
9500         rs6000_pseudo_register_reggroup_p with
9501         set_tdesc_pseudo_register_reggroup_p.
9502
9503 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9504
9505         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9506         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9507         set_gdbarch_num_pseudo_regs.
9508
9509 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9510
9511         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9512         Remove arg prefixname, add do_set and do_show.
9513         Add member functions set_list and show_list.
9514         * cli/cli-style.c (class cli_style_option): Update accordingly.
9515         (style_set_list): Move to file scope.
9516         (style_show_list): Likewise.
9517         (set_style): Call help_list.
9518         (show_style): Call cmd_show_list.
9519         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9520         Update to use the new macro.
9521
9522 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9523
9524         * ada-lang.c (_initialize_ada_language): Expand the help text
9525         for the "catch exception" command.
9526
9527 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9528
9529         * symtab.c (matching_obj_sections): Initialize obj,
9530         declare it closer to its usage.
9531
9532 2019-01-10  Tom Tromey  <tom@tromey.com>
9533
9534         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9535         (basic_inf_threads_range): Remove.
9536         (inf_threads_range, inf_non_exited_threads_range)
9537         (safe_inf_threads_range): Use next_adapter.
9538
9539 2019-01-10  Keith Seitz  <keiths@redhat.com>
9540
9541         PR gdb/23712
9542         PR symtab/23010
9543         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9544         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9545
9546 2019-01-10  Keith Seitz  <keiths@redhat.com>
9547
9548         PR gdb/23712
9549         PR symtab/23010
9550         * dictionary.c (pending_to_vector): Remove.
9551         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9552         Remove _1 suffix, replacing functions of the same name.  Update
9553         all callers.
9554         (dict_create_hashed, dict_create_hashed_expandable)
9555         (dict_create_linear, dict_create_linear_expandable, dict_free)
9556         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9557         Make functions static.
9558
9559 2019-01-10  Keith Seitz  <keiths@redhat.com>
9560
9561         PR gdb/23712
9562         PR symtab/23010
9563         * dictionary.h (struct dictionary): Replace declaration with
9564         multidictionary.
9565         (dict_create_hashed, dict_create_hashed_expandable)
9566         (dict_create_linear, dict_create_linear_expandable)
9567         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9568         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9569         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9570         taking multidictionary argument.
9571         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9572         * block.h (struct block) <dict>: Change to multidictionary
9573         and rename `multidict'.
9574         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9575         symmisc.c: Update all dictionary references to multidictionary.
9576
9577 2019-01-10  Keith Seitz  <keiths@redhat.com>
9578
9579         PR gdb/23712
9580         PR symtab/23010
9581         * dictionary.c: Include unordered_map.
9582         (pending_to_vector): New function.
9583         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9584         Rewrite the non-"_1" functions to take vector instead
9585         of linked list.
9586         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9587         "new" _1 versions of the same name.
9588         (multidictionary): Define.
9589         (std::hash<enum language): New definition.
9590         (collate_pending_symbols_by_language, mdict_create_hashed)
9591         (mdict_create_hashed_expandable, mdict_create_linear)
9592         (mdict_create_linear_expandable, mdict_free)
9593         (find_language_dictionary, create_new_language_dictionary)
9594         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9595         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9596         (mdict_size, mdict_empty): New functions.
9597         * dictionary.h (mdict_iterator): Define.
9598
9599 2019-01-10  Pedro Alves  <palves@redhat.com>
9600
9601         * breakpoint.c (read_uploaded_action)
9602         (create_tracepoint_from_upload): Adjust to use
9603         gdb::unique_xmalloc_ptr.
9604         * ctf.c (ctf_write_uploaded_tp):
9605         (SET_ARRAY_FIELD): Use emplace_back.
9606         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9607         * tracefile-tfile.c (tfile_write_uploaded_tp):
9608         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9609         gdb::unique_xmalloc_ptr.
9610         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9611         at_string, cond_string, cmd_strings>: Replace char pointers
9612         with gdb::unique_xmalloc_ptr.
9613
9614 2019-01-10  Pedro Alves  <palves@redhat.com>
9615
9616         * solib-target.c (library_list_start_library): Don't xstrdup name.
9617
9618 2019-01-10  Pedro Alves  <palves@redhat.com>
9619
9620         * mdebugread.c (parse_partial_symbols): Use
9621         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9622
9623 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9624
9625         * linux-fork.c (scoped_switch_fork_info)
9626         <~scoped_switch_fork_info>: Fix incorrect variable name.
9627
9628 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9629
9630         * linux-fork.c (scoped_switch_fork_info)
9631         <scoped_switch_fork_info>: Make explicit.
9632         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9633
9634 2019-01-10  Tom Tromey  <tom@tromey.com>
9635
9636         * objfiles.h (objfile::reset_psymtabs): Update.
9637         * objfiles.c (objfile::objfile): Update.
9638         * psymtab.h (psymtab_storage::obstack): Update.
9639         (psymtab_storage::m_obstack): Use gdb::optional.
9640         (class psymtab_storage): Update comment.  Remove objfile
9641         parameter.
9642         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9643
9644 2019-01-10  Tom Tromey  <tom@tromey.com>
9645
9646         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9647         <free_psymtabs>: Now private.
9648         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9649         (allocate_psymtab): Use new method.
9650
9651 2019-01-10  Tom Tromey  <tom@tromey.com>
9652
9653         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9654         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9655         * mdebugread.c (parse_partial_symbols): Use
9656         allocate_dependencies.
9657         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9658         allocate_dependencies.
9659         (process_psymtab_comp_unit_reader)
9660         (build_type_psymtab_dependencies): Likewise.
9661         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9662
9663 2019-01-10  Tom Tromey  <tom@tromey.com>
9664
9665         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9666         PSYMBOL_SET_LANGUAGE.
9667         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9668
9669 2019-01-10  Tom Tromey  <tom@tromey.com>
9670
9671         * psymtab.h (psymtab_storage::obstack): New method.
9672         <m_obstack>: Rename from obstack; now private.
9673         * psymtab.c (psymtab_storage): Update.
9674         * dwarf2read.c (create_addrmap_from_index)
9675         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9676         Update.
9677
9678 2019-01-10  Tom Tromey  <tom@tromey.com>
9679
9680         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9681         * objfiles.h (objfile::reset_psymtabs): New method.
9682
9683 2019-01-10  Tom Tromey  <tom@tromey.com>
9684
9685         * symmisc.c (print_symbol_bcache_statistics): Update.
9686         (print_objfile_statistics): Update.
9687         * symfile.c (reread_symbols): Update.
9688         * psymtab.h (class psymtab_storage): New.
9689         * psymtab.c (psymtab_storage): New constructor.
9690         (~psymtab_storage): New destructor.
9691         (require_partial_symbols): Update.
9692         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9693         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9694         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9695         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9696         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9697         (start_psymtab_common, end_psymtab_common)
9698         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9699         (allocate_psymtab): Update.
9700         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9701         Update.
9702         (dump_psymtab_addrmap, maintenance_print_psymbols)
9703         (maintenance_check_psymtabs): Update.
9704         (class objfile_psymtabs): Move to objfiles.h.
9705         * psympriv.h (discard_psymtab): Now inline.
9706         (psymtab_discarder::psymtab_discarder): Update.
9707         (psymtab_discarder::~psymtab_discarder): Update.
9708         (ALL_OBJFILE_PSYMTABS): Rewrite.
9709         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9710         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9711         Remove fields.
9712         <partial_symtabs>: New field.
9713         (class objfile_psymtabs): Move from psymtab.h.  Update.
9714         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9715         psymbol_cache.
9716         (objfile::~objfile): Don't destroy psymbol_cache.
9717         * mdebugread.c (parse_partial_symbols): Update.
9718         * dwarf2read.c (create_addrmap_from_index)
9719         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9720         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9721         (add_partial_subprogram, dwarf2_ranges_read): Update.
9722         * dwarf-index-write.c (write_address_map)
9723         (write_one_signatured_type, recursively_write_psymbols)
9724         (class debug_names, class debug_names, write_psymtabs_to_index):
9725         Update.
9726
9727 2019-01-10  Tom Tromey  <tom@tromey.com>
9728
9729         * symtab.h (SYMBOL_SET_NAMES): Update.
9730         (symbol_set_names): Update.
9731         (MSYMBOL_SET_NAMES): Update.
9732         * symtab.c (symbol_set_names): Change argument to be an
9733         objfile_per_bfd_storage.
9734         * psymtab.c (add_psymbol_to_bcache): Update.
9735         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9736
9737 2019-01-10  Tom Tromey  <tom@tromey.com>
9738
9739         * symtab.c (create_demangled_names_hash): Change argument to be an
9740         objfile_per_bfd_storage.
9741         (symbol_set_names): Update.
9742
9743 2019-01-10  Tom Tromey  <tom@tromey.com>
9744
9745         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9746         init_psymbol_list.
9747         * psymtab.c (init_psymbol_list): Do nothing if already called.
9748         * psympriv.h (init_psymbol_list): Add comment.
9749         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9750         init_psymbol_list.
9751         * dbxread.c (dbx_symfile_read): Unconditionally call
9752         init_psymbol_list.
9753
9754 2019-01-10  Tom Tromey  <tom@tromey.com>
9755
9756         * xcoffread.c (scan_xcoff_symtab): Update.
9757         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9758         "where".
9759         * mdebugread.c (parse_partial_symbols)
9760         (handle_psymbol_enumerators): Update.
9761         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9762         * dbxread.c (read_dbx_symtab): Update.
9763         * psympriv.h (psymbol_placement): New enum.
9764         (add_psymbol_to_list): Update.
9765
9766 2019-01-10  Tom Tromey  <tom@tromey.com>
9767
9768         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9769         static_psymbols parameters.
9770         (scan_xcoff_symtab): Update.
9771         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9772         static_psymbols parameters.
9773         * psympriv.h (start_psymtab_common): Update.
9774         * mdebugread.c (parse_partial_symbols): Update.
9775         * dwarf2read.c (create_partial_symtab): Update.
9776         * dbxread.c (read_dbx_symtab): Update.
9777         (start_psymtab): Remove global_psymbols and static_psymbols
9778         parameters.
9779
9780 2019-01-10  Tom Tromey  <tom@tromey.com>
9781
9782         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9783         * psymtab.c (allocate_psymtab): Add comment.
9784         * psympriv.h (allocate_psymtab): Add comment.
9785         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9786         initializations.
9787         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9788
9789 2019-01-10  Tom Tromey  <tom@tromey.com>
9790
9791         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9792         Don't declare.
9793         * mipsread.c: Include mdebugread.h.
9794         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9795         Declare.
9796         * elfread.c: Include mdebugread.h.
9797
9798 2019-01-09  Tom Tromey  <tom@tromey.com>
9799
9800         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9801         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9802         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9803         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9804         (psym_lookup_symbol, psym_find_last_source_symtab)
9805         (psym_forget_cached_source_info, psym_print_stats)
9806         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9807         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9808         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9809         (psym_find_compunit_symtab_by_address)
9810         (maintenance_print_psymbols, maintenance_info_psymtabs)
9811         (maintenance_check_psymtabs): Use ranged for.
9812         * psymtab.h (class objfile_psymtabs): New.
9813         (require_partial_symbols): Return objfile_psymtabs.
9814         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9815
9816 2019-01-09  Tom Tromey  <tom@tromey.com>
9817
9818         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9819         (find_pc_mapped_section, list_overlays_command)
9820         (map_overlay_command, unmap_overlay_command)
9821         (simple_overlay_update): Use all_objfiles.
9822         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9823         * printcmd.c (info_symbol_command): Use all_objfiles.
9824         * objfiles.h (ALL_OBJSECTIONS): Remove.
9825         * maint.c (maintenance_translate_address): Use all_objfiles.
9826         * gcore.c (gcore_create_callback): Use all_objfiles.
9827         (objfile_find_memory_regions): Likewise.
9828
9829 2019-01-09  Tom Tromey  <tom@tromey.com>
9830
9831         * symtab.c (find_line_symtab, info_sources_command)
9832         (make_source_files_completion_list): Use objfile_compunits.
9833         * source.c (select_source_symtab): Use objfile_compunits.
9834         * objfiles.h (struct objfile): Update comment.
9835         (ALL_OBJFILES): Remove.
9836         (ALL_FILETABS): Remove.
9837         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9838         objfile_compunits.
9839
9840 2019-01-09  Tom Tromey  <tom@tromey.com>
9841
9842         * symmisc.c (print_objfile_statistics, dump_objfile)
9843         (maintenance_print_symbols): Use compunit_filetabs.
9844         * source.c (forget_cached_source_info_for_objfile): Use
9845         compunit_filetabs.
9846         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9847         (ALL_FILETABS): Use compunit_filetabs.
9848         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9849         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9850
9851 2019-01-09  Tom Tromey  <tom@tromey.com>
9852
9853         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9854         (compunit_filetabs): New.
9855         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9856         compunit_filetabs.
9857         (info_sources_command, make_source_files_completion_list): Remove
9858         declaration.
9859         * symmisc.c (print_objfile_statistics, dump_objfile)
9860         (maintenance_print_symbols): Remove declaration.
9861         (maintenance_info_symtabs): Use compunit_filetabs.
9862         (maintenance_info_line_tables): Likewise.
9863         * source.c (select_source_symtab): Change local variable name.
9864         (forget_cached_source_info_for_objfile): Remove declaration.
9865         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9866         * objfiles.c (objfile_relocate1): Remove declaration.
9867         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9868         declaration.
9869         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9870         * coffread.c (coff_symtab_read): Remove declaration.
9871         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9872         compunit_filetabs.
9873
9874 2019-01-09  Tom Tromey  <tom@tromey.com>
9875
9876         * symtab.c (lookup_objfile_from_block)
9877         (find_pc_sect_compunit_symtab, search_symbols)
9878         (default_collect_symbol_completion_matches_break_on): Use
9879         objfile_compunits.
9880         * objfiles.h (ALL_COMPUNITS): Remove.
9881         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9882         * cp-support.c (add_symbol_overload_list_qualified): Use
9883         objfile_compunits.
9884         * ada-lang.c (ada_collect_symbol_completion_matches)
9885         (ada_add_global_exceptions): Use objfile_compunits.
9886
9887 2019-01-09  Tom Tromey  <tom@tromey.com>
9888
9889         * source.c (select_source_symtab)
9890         (forget_cached_source_info_for_objfile): Remove declaration.
9891         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9892         declaration.
9893         * maint.c (count_symtabs_and_blocks): Remove declaration.
9894         * cp-support.c (add_symbol_overload_list_qualified): Remove
9895         declaration.
9896         * coffread.c (coff_symtab_read): Remove declaration.
9897         * symtab.c (lookup_symbol_in_objfile_symtabs)
9898         (basic_lookup_transparent_type_1): Use objfile_compunits.
9899         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9900         (info_sources_command, search_symbols)
9901         (default_collect_symbol_completion_matches_break_on)
9902         (make_source_files_completion_list): Remove declaration.
9903         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9904         (ada_collect_symbol_completion_matches)
9905         (ada_add_global_exceptions): Remove declaration.
9906         * linespec.c (iterate_over_all_matching_symtabs): Use
9907         objfile_compunits.
9908         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9909         (class objfile_compunits): New.
9910         (ALL_COMPUNITS): Use objfile_compunits.
9911         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9912         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9913         objfile_compunits.
9914         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9915
9916 2019-01-09  Tom Tromey  <tom@tromey.com>
9917
9918         * symtab.c (search_symbols)
9919         (default_collect_symbol_completion_matches_break_on): Use
9920         objfile_msymbols.
9921         * ada-lang.c (ada_lookup_simple_minsym)
9922         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9923         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9924         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9925         objfile_msymbols.
9926         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9927         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9928         * objc-lang.c (find_methods): Use objfile_msymbols.
9929         (info_selectors_command, info_classes_command): Likewise.
9930         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9931         * objfiles.h (class objfile_msymbols): New.
9932         (ALL_OBJFILE_MSYMBOLS): Remove.
9933         (ALL_MSYMBOLS): Remove.
9934
9935 2019-01-09  Tom Tromey  <tom@tromey.com>
9936
9937         * common/next-iterator.h (next_adapter): Add Iterator template
9938         parameter.
9939         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9940         (class all_objfiles_safe): New.
9941         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9942         * objfiles.c (put_objfile_before): Update comment.
9943         (add_separate_debug_objfile): Likewise.
9944         (free_all_objfiles): Use all_objfiles_safe.
9945         (objfile_purge_solibs): Likewise.
9946
9947 2019-01-09  Tom Tromey  <tom@tromey.com>
9948
9949         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9950         (expand_symtab_containing_pc, lookup_static_symbol)
9951         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9952         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9953         all_objfiles.
9954         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9955         * breakpoint.c (create_overlay_event_breakpoint)
9956         (create_longjmp_master_breakpoint)
9957         (create_std_terminate_master_breakpoint)
9958         (create_exception_master_breakpoint): Use all_objfiles.
9959         * linux-thread-db.c (try_thread_db_load_from_pdir)
9960         (has_libpthread): Use all_objfiles.
9961         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9962         * linespec.c (iterate_over_all_matching_symtabs)
9963         (search_minsyms_for_name): Use all_objfiles.
9964         * maint.c (maintenance_info_sections): Use all_objfiles.
9965         * main.c (captured_main_1): Use all_objfiles.
9966         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9967         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9968         * guile/scm-pretty-print.c
9969         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9970         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9971         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9972         (maintenance_print_msymbols): Use all_objfiles.
9973         * source.c (select_source_symtab): Use all_objfiles.
9974         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9975         * symfile.c (remove_symbol_file_command)
9976         (expand_symtabs_matching, map_symbol_filenames): Use
9977         all_objfiles.
9978         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9979         all_objfiles.
9980         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9981         * objc-lang.c (find_methods): Use all_objfiles.
9982         * objfiles.c (have_partial_symbols, have_full_symbols)
9983         (have_minimal_symbols, qsort_cmp)
9984         (default_iterate_over_objfiles_in_search_order): Use
9985         all_objfiles.
9986         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9987         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9988         (maintenance_check_psymtabs): Use all_objfiles.
9989         (ALL_PSYMTABS): Remove.
9990         * compile/compile-object-run.c (do_module_cleanup): Use
9991         all_objfiles.
9992         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9993         * cp-support.c (add_symbol_overload_list_qualified): Use
9994         all_objfiles.
9995         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9996         Use all_objfiles.
9997         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9998         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9999         all_objfiles.
10000         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10001         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10002         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10003         Uses all_objfiles.
10004         * solib.c (solib_read_symbols): Use all_objfiles
10005
10006 2019-01-09  Tom Tromey  <tom@tromey.com>
10007
10008         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10009         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10010         all_objfiles.
10011         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10012         * symmisc.c (print_symbol_bcache_statistics)
10013         (print_objfile_statistics, maintenance_print_objfiles)
10014         (maintenance_info_symtabs, maintenance_check_symtabs)
10015         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10016         all_objfiles.
10017         * source.c (forget_cached_source_info): Use all_objfiles.
10018         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10019         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10020         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10021         * objfiles.c (update_section_map): Use all_objfiles.
10022         (shared_objfile_contains_address_p): Likewise.
10023         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10024         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10025
10026 2019-01-09  Tom Tromey  <tom@tromey.com>
10027
10028         * common/next-iterator.h: New file.
10029         * objfiles.h (class all_objfiles): New.
10030         (struct objfile_iterator): New.
10031
10032 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10033
10034         * NEWS: Move the description of the changed "frame", "select-frame",
10035          and "info frame" commands to the Changed commands section.
10036
10037 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10038
10039         * gdbtypes.c (check_stub_method_group): Remove handling of old
10040         mangling schemes.
10041         * linespec.c (find_methods): Likewise.
10042         * stabsread.c (read_member_functions): Likewise.
10043         * valops.c (search_struct_method): Likewise.
10044         (value_struct_elt_for_reference): Likewise.
10045         * NEWS: Mention this change.
10046
10047 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10048
10049         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10050         print_source_lines.
10051         * source.c (print_source_lines_base): Update line number check.
10052         (print_source_lines): New function.
10053         (source_lines_range::source_lines_range): New function.
10054         * source.h (class source_lines_range): New class.
10055         (print_source_lines): New declaration.
10056
10057 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10058
10059         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10060
10061 2019-01-08  Tom Tromey  <tom@tromey.com>
10062             Simon Marchi  <simon.marchi@ericsson.com>
10063
10064         PR gdb/24060
10065         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10066         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10067         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10068         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10069         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10070         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10071
10072 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10073
10074         * source.c (select_source_symtab): Move header comment to
10075         declaration in source.h.
10076         (forget_cached_source_info_for_objfile): Likewise.
10077         (forget_cached_source_info): Likewise.
10078         (identify_source_line): Likewise.
10079         * source.h (identify_source_line): Move declaration from symtab.h
10080         and add comment from source.c
10081         (print_source_lines): Likewise.
10082         (forget_cached_source_info_for_objfile): Likewise.
10083         (forget_cached_source_info): Likewise.
10084         (select_source_symtab): Likewise.
10085         (enum print_source_lines_flag): Move definition from symtab.h.
10086         * symtab.h (identify_source_line): Move declaration to source.h.
10087         (print_source_lines): Likewise.
10088         (forget_cached_source_info_for_objfile): Likewise.
10089         (forget_cached_source_info): Likewise.
10090         (select_source_symtab): Likewise.
10091         (enum print_source_lines_flag): Move definition to source.h.
10092         * tui/tui-hooks.c: Add 'source.h' include.
10093
10094 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10095
10096         * source.c (print_source_lines_base): Handle requests to print
10097         reverse line number sequences, and guard against empty lines
10098         string.
10099
10100 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10101
10102         * source.c (print_source_lines_base): Fix skip of '\r' if next
10103         character is '\n'.
10104
10105 2019-01-06  Tom Tromey  <tom@tromey.com>
10106
10107         * c-exp.y (struct c_parse_state) <macro_original_text,
10108         expansion_obstack>: New member.
10109         (macro_original_text, expansion_obstack): Remove globals.
10110         (scan_macro_expansion, scanning_macro_expansion)
10111         (finished_macro_expansion): Update.
10112         (scan_macro_cleanup): Remove.
10113         (yylex, c_parse): Update.
10114
10115 2019-01-06  Tom Tromey  <tom@tromey.com>
10116
10117         * c-exp.y (struct c_parse_state) <strings>: New member.
10118         (operator_stoken): Update.
10119
10120 2019-01-06  Tom Tromey  <tom@tromey.com>
10121
10122         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10123         (union type_stack_elt) <typelist_val>: Now a pointer to
10124         std::vector.
10125         (type_stack_cleanup): Don't declare.
10126         (push_typelist): Update.
10127         * parse.c (pop_typelist): Return a std::vector.
10128         (push_typelist): Take a std::vector.
10129         (follow_types): Update.  Do not free args.
10130         (type_stack_cleanup): Remove.
10131         * c-exp.y (struct c_parse_state): New.
10132         (cpstate): New global.
10133         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10134         (nonempty_typelist): Update.
10135         (func_mod): Create a new vector.
10136         (c_parse): Create a c_parse_state.
10137         (check_parameter_typelist): Do not delete params.
10138         (function_method): Update.  Do not delete type_list.
10139
10140 2019-01-06  Tom Tromey  <tom@tromey.com>
10141
10142         PR gdb/28155:
10143         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10144         check_typedef.
10145         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10146         (print_return_value): Likewise.
10147
10148 2019-01-05  Tom Tromey  <tom@tromey.com>
10149
10150         * contrib/cleanup_check.py: Remove.
10151         * contrib/gcc-with-excheck: Remove.
10152         * contrib/exsummary.py: Remove.
10153         * contrib/excheck.py: Remove.
10154
10155 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10156
10157         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10158         NULL. Initialize tpprev to NULL instead of assigning it
10159         to NULL on the next statement.
10160         * windows-nat.c (windows_delete_thread): Remove check for
10161         main_thread_id before printing thread exit notifications.
10162         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10163         Remove thread ID check against main_thread_id.
10164         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10165         windows_delete_thread.
10166         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10167
10168 2019-01-04  Tom Tromey  <tom@tromey.com>
10169
10170         * compile/compile.c (_initialize_compile): Use upper case for
10171         metasyntactic variables.
10172         * symmisc.c (_initialize_symmisc): Use upper case for
10173         metasyntactic variables.
10174         * psymtab.c (_initialize_psymtab): Use upper case for
10175         metasyntactic variables.
10176         * demangle.c (demangle_command): Use upper case for metasyntactic
10177         variables.
10178         (_initialize_demangler): Likewise.
10179         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10180         variables.
10181
10182 2019-01-03  Tom Tromey  <tom@tromey.com>
10183
10184         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10185
10186 2019-01-03  Tom Tromey  <tom@tromey.com>
10187
10188         * python/py-symtab.c (salpy_str): Update.
10189         (struct salpy_sal_object) <symtab>: Now a PyObject.
10190         (salpy_dealloc): Update.
10191         (del_objfile_sal): Use gdbpy_ref.
10192
10193 2019-01-03  Tom Tromey  <tom@tromey.com>
10194
10195         * python/py-type.c (convert_field): Use new_reference.  Return
10196         gdbpy_ref.
10197         (make_fielditem): Return gdbpy_ref.
10198         (typy_fields): Update.
10199         (typy_getitem): Update.
10200         (field_name): Return gdbpy_ref.  Use new_reference.
10201         (typy_iterator_iternext): Update.
10202
10203 2019-01-03  Tom Tromey  <tom@tromey.com>
10204
10205         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10206
10207 2019-01-03  Tom Tromey  <tom@tromey.com>
10208
10209         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10210         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10211         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10212         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10213         (pspy_set_type_printers): Likewise.
10214         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10215         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10216         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10217         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10218         (objfpy_set_type_printers): Likewise.
10219
10220 2019-01-03  Tom Tromey  <tom@tromey.com>
10221
10222         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10223         (gdbpy_print_stack): Use gdbpy_err_fetch.
10224         * python/python-internal.h (class gdbpy_err_fetch): New class.
10225         (class gdbpy_enter) <m_error_type, m_error_value,
10226         m_error_traceback>: Remove.
10227         <m_error>: New member.
10228         (gdbpy_exception_to_string): Don't declare.
10229         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10230         * python/py-value.c (convert_value_from_python): Use
10231         gdbpy_err_fetch.
10232         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10233         gdbpy_exception_to_string.
10234         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10235         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10236         gdbpy_err_fetch.
10237
10238 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10239
10240         * linux-nat.c (delete_lwp_cleanup): Delete.
10241         (struct lwp_deleter): New struct.
10242         (lwp_info_up): New typedef.
10243         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10244         lwp_info_up.
10245
10246 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10247
10248         * linux-fork.c (class scoped_switch_fork_info): New class.
10249         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10250
10251 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10252
10253         * valops.c (find_overload_match): Remove use of null_cleanup, and
10254         calls to do_cleanups.
10255
10256 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10257
10258         * compile/compile-cplus-types.c
10259         (compile_cplus_instance::decl_name): Handle changes to
10260         cp_func_name.
10261         * cp-support.c (cp_func_name): Update header comment, update
10262         return type.
10263         * cp-support.h (cp_func_name): Update return type in declaration.
10264         * valops.c (find_overload_match): Move temp_func local to top
10265         level of function and change its type.  Use temp_func to hold and
10266         delete temporary string obtained from cp_func_name.
10267
10268 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10269
10270         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10271         gdb::char_vector, remove cleanup, and update uses of `msg`.
10272
10273 2019-01-03  Jim Wilson  <jimw@sifive.com>
10274
10275         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10276
10277 2019-01-02  Tom Tromey  <tom@tromey.com>
10278
10279         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10280         (tdesc_parse_xml): Remove cleanups.
10281         * target-descriptions.h (make_cleanup_free_target_description):
10282         Don't declare.
10283         (target_desc_deleter): New struct.
10284         (target_desc_up): New typedef.
10285         * target-descriptions.c (target_desc_deleter::operator()): Rename
10286         from free_target_description.
10287         (make_cleanup_free_target_description): Remove.
10288
10289 2019-01-02  Tom Tromey  <tom@tromey.com>
10290
10291         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10292         constructor, destructor.
10293         (linespec_parser): Remove typedef.
10294         (~linespec_parser): Rename from linespec_parser_delete.
10295         (linespec_lex_to_end, linespec_complete_label)
10296         (linespec_complete): Update.
10297         (decode_line_full): Remove cleanups.
10298         (decode_line_1): Update.
10299
10300 2019-01-02  Tom Tromey  <tom@tromey.com>
10301
10302         * python/python-internal.h (inferior_to_inferior_object): Change
10303         return type.
10304         * python/py-exitedevent.c (create_exited_event_object): Update.
10305         * python/py-inferior.c (inferior_to_inferior_object): Return
10306         gdbpy_ref.
10307         (python_new_inferior, python_inferior_deleted)
10308         (thread_to_thread_object, delete_thread_object)
10309         (build_inferior_list, gdbpy_selected_inferior): Update.
10310         * python/py-infthread.c (create_thread_object): Update.  Also fail
10311         if inferior_to_inferior_object fails.
10312
10313 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10314
10315         * inferior.h (class inferior) <displaced_step_state>: New field.
10316         * infrun.h (struct displaced_step_state): Move here from
10317         infrun.c.  Initialize fields, add constructor.
10318         <inf>: Remove field.
10319         <reset>: New method.
10320         * infrun.c (struct displaced_step_inferior_state): Move to
10321         infrun.h.
10322         (displaced_step_inferior_states): Remove.
10323         (get_displaced_stepping_state): Adust.
10324         (displaced_step_in_progress_any_inferior): Adjust.
10325         (displaced_step_in_progress_thread): Adjust.
10326         (displaced_step_in_progress): Adjust.
10327         (add_displaced_stepping_state): Remove.
10328         (get_displaced_step_closure_by_addr): Adjust.
10329         (remove_displaced_stepping_state): Remove.
10330         (infrun_inferior_exit): Call displaced_step_state.reset.
10331         (use_displaced_stepping): Don't check for NULL.
10332         (displaced_step_prepare_throw): Call
10333         get_displaced_stepping_state.
10334         (displaced_step_fixup): Don't check for NULL.
10335         (prepare_for_detach): Don't check for NULL.
10336
10337 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10338
10339         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10340          in case of call that did not complete.
10341
10342 2019-01-02  Andrey Utkin  <autkin@undo.io>
10343
10344         * symfile.c (find_separate_debug_file): Fix search of debug files for
10345         remote debuggee.
10346
10347 2019-01-02  Tom Tromey  <tom@tromey.com>
10348
10349         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10350         indentation.
10351         * python/py-frame.c (frapy_older): Remove cast.
10352         (frapy_newer): Likewise.
10353         * python/py-breakpoint.c (local_setattro): Remove cast.
10354         * python/py-arch.c (archpy_name): Remove local variable.
10355         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10356
10357 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10358
10359         * unittests/basic_string_view/element_access/char/empty.cc:
10360         Fix year range in copyright header.
10361
10362 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10363
10364         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10365         Delete.
10366         <operator==>: Update with for removed field.
10367         <hash>: Likewise.
10368         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10369         <isa_features>: ...this.
10370         <abi_features>: New field.
10371         (riscv_isa_flen): Update comment.
10372         (riscv_abi_xlen): New declaration.
10373         (riscv_abi_flen): New declaration.
10374         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10375         isa_features.
10376         (riscv_abi_xlen): New function.
10377         (riscv_isa_flen): Update to get answer from isa_features.
10378         (riscv_abi_flen): New function.
10379         (riscv_has_fp_abi): Update to get answer from abi_features.
10380         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10381         xlen and flen.
10382         (riscv_call_info) <xlen, flen>: Update comment.
10383         (riscv_call_arg_struct): Remove invalid assertions
10384         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10385         is removed.
10386         (riscv_gdbarch_init): Gather isa features and abi features
10387         separately, ensure both match on the gdbarch when reusing an old
10388         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10389         a target with 64-bit float hardware.
10390
10391 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10392
10393         * source.c (search_command_helper): Stop reverse search
10394         when line 1 has been searched.
10395
10396 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10397
10398         * record-full.c (record_full_base_target::close): Rewrite
10399         record_full_core_buf_list free logic.
10400
10401 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10402
10403         * break-catch-syscall.c (print_one_catch_syscall): xfree
10404         the last text.
10405
10406 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10407
10408         * top.c (print_gdb_version): Update Copyright year in version
10409         message.
10410
10411 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10412
10413         Update copyright year range in all GDB files.
10414
10415 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10416
10417         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10418
10419 For older changes see ChangeLog-2018.
10420 \f
10421 Local Variables:
10422 mode: change-log
10423 left-margin: 8
10424 fill-column: 74
10425 version-control: never
10426 coding: utf-8
10427 End:
10428