Fix regcache::cooked_read_test selftest for mep
[deliverable/binutils-gdb.git] / gdb / ChangeLog
1 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
2
3 * regcache.c (cooked_read_test): Initialize thread list of
4 mock_inferior.
5
6 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
7
8 * aarch64-linux-tdep.c: Remove includes.
9
10 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
11
12 * aarch64-tdep.c: Remove includes.
13
14 2019-12-04 Simon Marchi <simon.marchi@efficios.com>
15
16 * filtered-iterator.h (filtered_iterator) <operator==,
17 operator!=>: Compare wrapped iterators, not wrapped pointers.
18 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
19 unittests/filtered_iterator-selftests.c.
20 * unittests/filtered_iterator-selftests.c: New file.
21
22 2019-12-04 Tom Tromey <tromey@adacore.com>
23
24 * gdbtypes.c (create_range_type): Inherit endianity
25 from base type.
26
27 2019-12-04 Tom Tromey <tromey@adacore.com>
28
29 * ada-lang.c (decode_constrained_packed_array)
30 (ada_value_assign, value_assign_to_component): Update.
31 * dwarf2loc.c (rw_pieced_value, access_memory)
32 (dwarf2_compile_expr_to_ax): Update.
33 * dwarf2read.c (dwarf2_add_field): Update.
34 * eval.c (evaluate_subexp_standard): Update.
35 * gdbarch.c, gdbarch.h: Rebuild.
36 * gdbarch.sh (bits_big_endian): Remove.
37 * gdbtypes.h (union field_location): Update comment.
38 * target-descriptions.c (make_gdb_type): Update.
39 * valarith.c (value_bit_index): Update.
40 * value.c (struct value) <bitpos>: Update comment.
41 (unpack_bits_as_long, modify_field): Update.
42 * value.h (value_bitpos): Update comment.
43
44 2019-12-04 Tom Tromey <tromey@adacore.com>
45
46 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
47 endian-ness.
48
49 2019-12-04 Tom Tromey <tromey@adacore.com>
50
51 * dwarf2read.c (dwarf2_init_float_type)
52 (dwarf2_init_complex_target_type): Add byte_order parameter.
53 (read_base_type): Compute byte order earlier.
54 * gdbtypes.c (init_float_type): Add byte_order parameter.
55 * gdbtypes.h (init_float_type): Add byte_order parameter.
56
57 2019-12-04 Tom Tromey <tromey@adacore.com>
58
59 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
60
61 2019-12-04 Tom Tromey <tromey@adacore.com>
62
63 * dwarf2read.c (process_structure_scope): Initialize
64 "discr_offset".
65
66 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
67
68 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
69 add it into the search spec.
70 (parse_max_results_option): New function.
71 (mi_info_functions_or_variables): Parse -max-results flag and pass
72 it to mi_symbol_info.
73 (mi_cmd_symbol_info_modules): Likewise.
74 (mi_cmd_symbol_info_types): Likewise.
75 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
76 return type to bool, change result container into a set, and don't
77 add new results if we have enough already.
78 (global_symbol_searcher::add_matching_msymbols): Change return
79 type to bool, and don't add new results if we have enough already.
80 (sort_search_symbols_remove_dups): Delete.
81 (global_symbol_searcher::search): Early exit from search loop when
82 we have enough results. Use a std::set to collect the results
83 from calling add_matching_symbols.
84 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
85 member function.
86 (global_symbol_searcher) <m_max_search_results>: New member
87 variable.
88 (global_symbol_searcher) <add_matching_symbols>: Update header
89 comment and change return type to bool.
90 (global_symbol_searcher) <add_matching_msymbols>: Update header
91 comment and change return type to bool.
92
93 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
94
95 * symtab.c (symbol_search::compare_search_syms): Update header
96 comment.
97 (global_symbol_searcher::is_suitable_msymbol): New function.
98 (global_symbol_searcher::expand_symtabs): New function.
99 (global_symbol_searcher::add_matching_symbols): New function.
100 (global_symbol_searcher::add_matching_msymbols): New function.
101 (global_symbol_searcher::search): Move most of the content
102 into the new functions above, and call them as needed.
103 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
104 function.
105 (global_symbol_searcher) <add_matching_symbols>: New member
106 function.
107 (global_symbol_searcher) <add_matching_msymbols>: New member
108 function.
109 (global_symbol_searcher) <is_suitable_msymbol>: New member
110 function.
111
112 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
113
114 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
115 -symbol-info-module-variables entries.
116 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
117 (mi_cmd_symbol_info_module_variables): Declare.
118 * mi/mi-symbol-cmds.c
119 (module_symbol_search_iterator): New typedef.
120 (output_module_symbols_in_single_module_and_file): New function.
121 (output_module_symbols_in_single_module): New function.
122 (mi_info_module_functions_or_variables): New function.
123 (mi_cmd_symbol_info_module_functions): New function.
124 (mi_cmd_symbol_info_module_variables): New function.
125 * NEWS: Mention new MI command.
126
127 2019-12-03 Christian Biesinger <cbiesinger@google.com>
128
129 * bcache.c (hash): Remove.
130 (hash_continue): Remove.
131 * bcache.h (hash): Remove.
132 (hash_continue): Remove.
133 (struct bcache) <ctor>: Update.
134 * psymtab.c (psymbol_hash): Update.
135 * stabsread.c (hashname): Update.
136 * utils.h (fast_hash): Add an argument for a start value,
137 defaulting to zero.
138
139 2019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
140 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
141 (destroy_block_symbol_cache): New function.
142 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
143 (resize_symbol_cache): Likewise.
144
145 2019-12-02 Tom Tromey <tom@tromey.com>
146
147 * unittests/tui-selftests.c (run_tests): Make conditional.
148 (_initialize_tui_selftest): Make conditional.
149
150 2019-12-02 Christian Biesinger <cbiesinger@google.com>
151
152 * aix-thread.c (debug_aix_thread): Change type to bool.
153
154 2019-12-02 Luis Machado <luis.machado@linaro.org>
155
156 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
157
158 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
159
160 * dwarf2read.c (read_tag_string_type): Read the fields required to
161 make a dynamic string, and possibly create a dynamic range for the
162 string.
163 (attr_to_dynamic_prop): Setup is_reference based on the type of
164 attribute being processed.
165 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
166 (resolve_dynamic_array): Rename to...
167 (resolve_dynamic_array_or_string): ...this, update header comment,
168 and accept TYPE_CODE_STRING.
169 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
170
171 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
172
173 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
174 of its implementation from...
175 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
176 the new function.
177
178 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
179
180 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
181 create a range with stride where appropriate.
182 * f-valprint.c: Include 'gdbarch.h'.
183 (f77_print_array_1): Take the stride into account when walking the
184 array. Also convert the stride into addressable units.
185 * gdbtypes.c (create_range_type): Initialise the stride to
186 constant zero.
187 (create_range_type_with_stride): New function, initialise the
188 range as normal, and then setup the stride.
189 (has_static_range): Include the stride here. Also change the
190 return type to bool.
191 (create_array_type_with_stride): Consider the range stride if the
192 array isn't given its own stride.
193 (resolve_dynamic_range): Resolve the stride if needed.
194 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
195 (struct range_bounds) <flag_is_byte_stride>: New member variable.
196 (TYPE_BIT_STRIDE): Define.
197 (TYPE_ARRAY_BIT_STRIDE): Define.
198 (create_range_type_with_stride): Declare.
199 * valarith.c (value_subscripted_rvalue): Take range stride into
200 account when walking the array.
201
202 2019-12-01 Tom Tromey <tom@tromey.com>
203
204 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
205 specially.
206
207 2019-12-01 Tom Tromey <tom@tromey.com>
208
209 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
210 \0.
211 * unittests/tui-selftests.c: New file.
212 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
213
214 2019-12-01 Tom Tromey <tom@tromey.com>
215
216 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
217
218 2019-12-01 Tom Tromey <tom@tromey.com>
219
220 * NEWS: Document new settings.
221 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
222 * tui/tui-win.c (_initialize_tui_win): Add border style
223 observers.
224 * tui/tui-io.h (tui_apply_style): Declare.
225 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
226 longer static.
227 (apply_ansi_escape, tui_set_reverse_mode): Update.
228 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
229 Add "skip_intensity" parameter.
230 <changed>: New member.
231 <do_set_value>: Declare.
232 (tui_border_style, tui_active_border_style): Declare.
233 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
234 globals.
235 (cli_style_option): Initialize "changed".
236 (cli_style_option::do_set_value): New function.
237 (cli_style_option::add_setshow_commands): Add "skip_intensity"
238 parameter. Update.
239 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
240 (_initialize_cli_style): Update. Create TUI border style
241 commands.
242
243 2019-12-01 Tom Tromey <tom@tromey.com>
244
245 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
246 parameter.
247 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
248 parameter.
249 * tui/tui-win.h (compact_source): Declare.
250 * tui/tui-win.c (compact_source): New global.
251 (tui_set_compact_source, tui_show_compact_source): New functions.
252 (_initialize_tui_win): Add "compact-source" setting.
253 * tui/tui-source.c (tui_source_window::set_contents): Handle
254 compact_source setting.
255 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
256 * NEWS: Document new setting.
257
258 2019-11-30 Tom Tromey <tom@tromey.com>
259
260 * dwarf2read.c (dwarf2_add_field): Include field offset when
261 computing variant part length.
262
263 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
264 * NEWS: Mention define-prefix. Tell that command names can now
265 contain a . character.
266
267 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
268
269 * command.h (valid_cmd_char_p): Declare.
270 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
271 the check of valid command char.
272 (find_command_name_length, valid_user_defined_cmd_name_p): Use
273 valid_cmd_char_p.
274 * cli/cli-script.c (validate_comname): Likewise.
275 * completer.c (gdb_completer_command_word_break_characters):
276 Do not remove . from the word break char, update comments.
277 (complete_line_internal_1): Use valid_cmd_char_p.
278 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
279 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
280
281 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
282
283 * cli/cli-script.c (do_define_command): Ensure a redefined
284 prefix command is kept as a prefix command.
285 (define_prefix_command): New function.
286 (show_user_1): Report user defined prefixes.
287 (_initialize_cli_script): Create the new 'define-prefix' command.
288 Add completers for 'define' and 'document'.
289 * top.c (execute_command): If command is a user-defined prefix only
290 command, report the list of commands for this prefix command.
291
292 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
293
294 * valops.c (find_oload_champ): Improve debug output.
295
296 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
297
298 * valops.c (find_oload_champ): Print part of debug messages
299 before the badness vector is std::move'd.
300
301 2019-11-28 Tom Tromey <tom@tromey.com>
302
303 * value.c (creal_internal_fn): Fix comment.
304
305 2019-11-28 Tom Tromey <tom@tromey.com>
306
307 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
308 flag_bound_evaluated>: Now unsigned.
309
310 2019-11-28 Tom Tromey <tom@tromey.com>
311
312 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
313 declare.
314
315 2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
316
317 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
318 debug output.
319 * jit.c (jit_unregister_code): Add debug print to match
320 `jit_register_code`.
321
322 2019-11-27 Christian Biesinger <cbiesinger@google.com>
323
324 * NEWS: Mention the new multithreaded symbol loading.
325
326 2019-11-27 Christian Biesinger <cbiesinger@google.com>
327
328 * maint.c (n_worker_threads): Default to 0.
329 (worker_threads_disabled): New function.
330 * maint.h (worker_threads_disabled): New function.
331 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
332 here if worker_threads_disabled () is true.
333 (minimal_symbol_reader::install): Skip all threading if
334 worker_threads_disabled () is true.
335
336 2019-11-27 Christian Biesinger <cbiesinger@google.com>
337
338 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
339 hash code if possible.
340 (add_minsym_to_demangled_hash_table): Likewise.
341 (minimal_symbol_reader::install): Compute the hash codes for msymbol
342 on the background thread.
343 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
344 Add these fields.
345
346 2019-11-27 Christian Biesinger <cbiesinger@google.com>
347
348 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
349 of the mangled name on the background thread.
350 * symtab.c (symbol_set_names): Allow passing in the hash of the
351 linkage_name.
352 * symtab.h (symbol_set_names): Likewise.
353
354 2019-11-27 Kevin Buettner <kevinb@redhat.com>
355
356 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
357 physnames are computed for inherited DIEs.
358
359 2019-11-27 Tom Tromey <tromey@adacore.com>
360
361 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
362 backslashes.
363 * cp-support.c: Remove unnecessary backslashes.
364
365 2019-11-27 Christian Biesinger <cbiesinger@google.com>
366
367 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
368 with sym->set_linkage_name.
369 * coffread.c (coff_read_enum_type): Likewise.
370 * mdebugread.c (parse_symbol): Likewise.
371 * stabsread.c (patch_block_stabs): Likewise.
372 (define_symbol): Likewise.
373 (read_enum_type): Likewise.
374 (common_block_end): Likewise.
375 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
376 function.
377 (SYMBOL_SET_LINKAGE_NAME): Remove.
378 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
379 with sym->set_linkage_name.
380
381 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
382
383 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
384 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
385 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
386 * NEWS: Mention new MI command.
387
388 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
389
390 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
391 '-symbol-info-types', and '-symbol-info-variables'.
392 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
393 (mi_cmd_symbol_info_types): Declare.
394 (mi_cmd_symbol_info_variables): Declare.
395 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
396 (output_debug_symbol): New function.
397 (output_nondebug_symbol): New function.
398 (mi_symbol_info): New function.
399 (mi_info_functions_or_variables): New function.
400 (mi_cmd_symbol_info_functions): New function.
401 (mi_cmd_symbol_info_types): New function.
402 (mi_cmd_symbol_info_variables): New function.
403 * NEWS: Mention new commands.
404
405 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
406
407 * symtab.c (symbol_to_info_string): New function, most content
408 moved from print_symbol_info, but updated to return a std::string.
409 (print_symbol_info): Update to use symbol_to_info_string and print
410 returned string.
411 * symtab.h (symbol_to_info_string): Declare new function.
412
413 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
414
415 * python/python.c (gdbpy_rbreak): Convert to using
416 global_symbol_searcher.
417 * symtab.c (file_matches): Convert return type to bool, change
418 file list to std::vector, update header comment.
419 (search_symbols): Rename to...
420 (global_symbol_searcher::search): ...this and update now its
421 a member function of global_symbol_searcher. Take account of the
422 changes to file_matches.
423 (symtab_symbol_info): Convert to using global_symbol_searcher.
424 (rbreak_command): Likewise.
425 (search_module_symbols): Likewise.
426 * symtab.h (enum symbol_search): Update comment.
427 (search_symbols): Remove declaration.
428 (class global_symbol_searcher): New class.
429
430 2019-11-26 Tom Tromey <tromey@adacore.com>
431
432 * cp-support.c (_initialize_cp_support): Conditionally initialize
433 gdb_demangle_attempt_core_dump.
434
435 2019-11-26 Tom Tromey <tom@tromey.com>
436
437 * python/py-function.c (fnpy_init): Update.
438 * value.h (add_internal_function): Adjust declaration.
439 * value.c (function_destroyer): Remove.
440 (do_add_internal_function): Don't set destroyer or copy name.
441 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
442 Set name_allocated.
443 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
444 (cmdpy_init): Set name_allocated.
445 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
446 member.
447 (~cmd_list_element): Free "name" if needed.
448
449 2019-11-26 Tom Tromey <tom@tromey.com>
450
451 * value.h (add_internal_function): Add new overload. Move
452 documentation from value.h.
453 * value.c (do_add_internal_function): New function.
454 (add_internal_function): Use it. Add new overload.
455 (function_destroyer): Don't free doc.
456 * python/py-function.c (fnpy_init): Update.
457
458 2019-11-26 Tom Tromey <tom@tromey.com>
459
460 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
461 (cmdpy_init): Set "doc_allocated".
462
463 2019-11-26 Tom Tromey <tom@tromey.com>
464
465 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
466 name of worker thread.
467 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
468 pthread_setname_np.
469 * configure, config.in: Rebuild.
470
471 2019-11-26 Tom Tromey <tom@tromey.com>
472
473 * python/python.c (class gdbpy_gil): New.
474 (struct gdbpy_event): Add constructor, destructor, operator().
475 (gdbpy_post_event): Use run_on_main_thread.
476 (gdbpy_initialize_events): Remove.
477 (do_start_initialization): Update.
478
479 2019-11-26 Tom Tromey <tom@tromey.com>
480
481 * NEWS: Add entry.
482 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
483 commands. Call update_thread_pool_size.
484 (update_thread_pool_size, maintenance_set_worker_threads): New
485 functions.
486 (n_worker_threads): New global.
487
488 2019-11-26 Christian Biesinger <cbiesinger@google.com>
489 Tom Tromey <tom@tromey.com>
490
491 * minsyms.c (minimal_symbol_reader::install): Use
492 parallel_for_each.
493 * gdbsupport/parallel-for.h: New file.
494 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
495
496 2019-11-26 Christian Biesinger <cbiesinger@google.com>
497 Tom Tromey <tom@tromey.com>
498
499 * gdbsupport/thread-pool.h: New file.
500 * gdbsupport/thread-pool.c: New file.
501 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
502 (HFILES_NO_SRCDIR): Add thread-pool.h.
503
504 2019-11-26 Tom Tromey <tom@tromey.com>
505
506 * event-top.h (thread_local_segv_handler): Declare.
507 * event-top.c (thread_local_segv_handler): New global.
508 (install_handle_sigsegv, handle_sigsegv): New functions.
509 (async_init_signals): Install SIGSEGV handler.
510 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
511 thread-local.
512 (report_failed_demangle): New function.
513 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
514 handler-setting code, instead use segv_handler. Run warning code
515 on main thread.
516
517 2019-11-26 Tom Tromey <tom@tromey.com>
518
519 * run-on-main-thread.c: New file.
520 * run-on-main-thread.h: New file.
521 * unittests/main-thread-selftests.c: New file.
522 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
523 main-thread-selftests.c.
524 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
525 (COMMON_SFILES): Add run-on-main-thread.c.
526
527 2019-11-26 Tom Tromey <tom@tromey.com>
528
529 * main.c (setup_alternate_signal_stack): Remove.
530 (captured_main_1): Use gdb::alternate_signal_stack.
531 * gdbsupport/alt-stack.h: New file.
532
533 2019-11-26 Tom Tromey <tom@tromey.com>
534
535 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
536 Remove comment.
537 (save_original_signals_state, restore_original_signals_state): Use
538 gdb_sigmask.
539 * linux-nat.c (block_child_signals, restore_child_signals_mask)
540 (_initialize_linux_nat): Use gdb_sigmask.
541 * guile/guile.c (_initialize_guile): Use block_signals.
542 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
543 * gdbsupport/gdb-sigmask.h: New file.
544 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
545 * cp-support.c (gdb_demangle): Use gdb_sigmask.
546 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
547 pthread_sigmask.
548 * configure, config.in: Rebuild.
549 * gdbsupport/block-signals.h: New file.
550
551 2019-11-26 Tom Tromey <tom@tromey.com>
552
553 * acinclude.m4: Include ax_pthread.m4.
554 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
555 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
556 (CLIBS): Use PTHREAD_LIBS.
557 (aclocal_m4_deps): Add ax_pthread.m4.
558 * config.in, configure: Rebuild.
559 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
560
561 2019-11-26 Tom Tromey <tom@tromey.com>
562
563 * symtab.h (struct minimal_symbol) <name_set>: New member.
564 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
565 Don't call symbol_set_names.
566 (minimal_symbol_reader::install): Call symbol_set_names.
567
568 2019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
569
570 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
571 restore_active_ext_lang, as GIL is needed for (indirectly)
572 called PyOS_InterruptOccurred.
573
574 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
575
576 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
577 definition.
578
579 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
580
581 * remote-sim.c (simulator_command): Make static, remove
582 declaration.
583
584 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
585
586 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
587 static.
588 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
589 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
590 (main): Likewise.
591 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
592 (main): Likewise.
593 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
594 (main): Likewise.
595 * unittests/basic_string_view/element_access/char/1.cc (test01):
596 Likewise.
597 (main): Likewise.
598 * unittests/basic_string_view/element_access/char/empty.cc (main):
599 Likewise.
600 * unittests/basic_string_view/element_access/char/front_back.cc
601 (test01): Likewise.
602 (main): Likewise.
603 * unittests/basic_string_view/inserters/char/2.cc (test05):
604 Likewise.
605 (main): Likewise.
606 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
607 (test01): Likewise.
608 (main): Likewise.
609 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
610 (test01): Likewise.
611 (main): Likewise.
612 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
613 Likewise.
614 * unittests/basic_string_view/operations/compare/char/1.cc
615 (test01): Likewise.
616 (main): Likewise.
617 * unittests/basic_string_view/operations/compare/char/13650.cc
618 (test01): Likewise.
619 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
620 Likewise.
621 (main): Likewise.
622 * unittests/basic_string_view/operations/data/char/1.cc (test01):
623 Likewise.
624 (main): Likewise.
625 * unittests/basic_string_view/operations/find/char/1.cc (test01):
626 Likewise.
627 (main): Likewise.
628 * unittests/basic_string_view/operations/find/char/2.cc (test02):
629 Likewise.
630 (main): Likewise.
631 * unittests/basic_string_view/operations/find/char/3.cc (test03):
632 Likewise.
633 (main): Likewise.
634 * unittests/basic_string_view/operations/find/char/4.cc (main):
635 Likewise.
636 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
637 Likewise.
638 (main): Likewise.
639 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
640 Likewise.
641 (main): Likewise.
642 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
643 Likewise.
644 (main): Likewise.
645 * unittests/basic_string_view/operations/substr/char/1.cc
646 (test01): Likewise.
647 (main): Likewise.
648 * unittests/basic_string_view/operators/char/2.cc (main):
649 Likewise.
650 * unittests/optional/assignment/1.cc (test): Likewise.
651 * unittests/optional/assignment/2.cc (test): Likewise.
652 * unittests/optional/assignment/3.cc (test): Likewise.
653 * unittests/optional/assignment/4.cc (test): Likewise.
654 * unittests/optional/assignment/5.cc (test): Likewise.
655 * unittests/optional/assignment/6.cc (test): Likewise.
656 * unittests/optional/assignment/7.cc (test): Likewise.
657 * unittests/optional/cons/copy.cc (test): Likewise.
658 * unittests/optional/cons/default.cc (test): Likewise.
659 * unittests/optional/cons/move.cc (test): Likewise.
660 * unittests/optional/cons/value.cc (test): Likewise.
661 * unittests/optional/in_place.cc (test): Likewise.
662 * unittests/optional/observers/1.cc (test): Likewise.
663 * unittests/optional/observers/2.cc (test): Likewise.
664
665 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
666
667 * tui-win.h (tui_set_var_cmd): Remove.
668 * tui-win.c (tui_set_var_cmd): Make static.
669
670 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
671
672 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
673 rbreak_command_wrapper): Remove.
674 * symtab.c (rbreak_command_wrapper): Remove.
675
676 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
677
678 * inferior.h (info_terminal_command): Remove declaration.
679 * inflow.c (info_terminal_command): Make static.
680
681 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
682
683 * inferior.c (exit_inferior_silent): Remove.
684
685 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
686
687 * dictionary.c (dict_empty, mdict_empty): Remove.
688 * dictionary.c (mdict_empty): Remove.
689
690 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
691
692 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
693 (arc_insn_get_memory_offset): Likewise.
694 (arc_insn_dump): Likewise.
695 * cp-support.c (test_cp_symbol_name_matches): Likewise.
696 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
697 * dictionary.c (dict_iterator_next): Likewise.
698 (dict_iter_match_first): Likewise.
699 (dict_iter_match_next): Likewise.
700 * f-lang.c (evaluate_subexp_f): Likewise.
701 * hppa-tdep.c (hppa_read_pc): Likewise.
702 * i386-tdep.c (i386_floatformat_for_type): Likewise.
703 * parse.c (write_exp_elt_msym): Likewise.
704 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
705 * remote.c (remote_packet_size): Likewise.
706 (remote_notif_stop_parse): Likewise.
707 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
708 * s12z-tdep.c (s12z_disassemble_info): Likewise.
709 * source.c (prepare_path_for_appending): Likewise.
710 * sparc64-linux-tdep.c
711 (sparc64_linux_handle_segmentation_fault); Likewise.
712 * stack.c (frame_selection_by_function_completer): Likewise.
713
714 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
715
716 * completer.c (set_gdb_completion_word_break_characters):
717 Remove.
718
719 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
720
721 * dwarf-index-write.c: Include dwarf-index-write.h.
722 * mi/mi-interp.c: Include mi/mi-interp.h.
723
724 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
725
726 * aarch32-tdep.c: Include aarch32-tdep.h.
727 * aarch32-tdep.h: Forward-declare struct target_desc.
728
729 2019-11-26 Christian Biesinger <cbiesinger@google.com>
730
731 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
732 strerror.
733 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
734 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
735
736 2019-11-25 Tom de Vries <tdevries@suse.de>
737
738 * contrib/words.sh: Add -c option.
739
740 2019-11-25 Christian Biesinger <cbiesinger@google.com>
741
742 * solib.c (solib_find_1): Change int to bool.
743 (exec_file_find): Change int to bool.
744 (solib_find): Change int to bool.
745 (solib_read_symbols): Change int to bool.
746 (solib_used): Change int to bool.
747 (solib_add): Change int to bool.
748 (info_sharedlibrary_command): Change int to bool.
749 (solib_contains_address_p): Change int to bool.
750 (solib_keep_data_in_core): Change int to bool.
751 (in_solib_dynsym_resolve_code): Change int to bool.
752 (reload_shared_libraries_1): Change int to bool.
753 (gdb_sysroot_changed): Change int to bool.
754 * solib.h (solib_read_symbols): Change int to bool.
755 (solib_contains_address_p): Change int to bool.
756 (solib_keep_data_in_core): Change int to bool.
757 (in_solib_dynsym_resolve_code): Change int to bool.
758 (libpthread_name_p): Change int to bool.
759
760 2019-11-25 Luis Machado <luis.machado@linaro.org>
761
762 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
763 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
764 (remote_packet_max_chars): New static global.
765 (show_remote_packet_max_chars): New function.
766 (remote_target::putpkt_binary): Adjust to use new
767 remote_packet_max_chars option.
768 (remote_target::getpkt_or_notif_sane_1): Likewise.
769 (_initialize_remote): Register new remote-packet-max-chars option.
770
771 2019-11-24 Simon Marchi <simon.marchi@efficios.com>
772
773 * m68k-linux-nat.c: Include gdbarch.h.
774
775 2019-11-24 Tom Tromey <tom@tromey.com>
776
777 * symfile.c (read_symbols): Update.
778 * psymtab.c (require_partial_symbols): Change type of "verbose" to
779 bool.
780 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
781 (psym_lookup_symbol, psym_find_last_source_symtab)
782 (psym_forget_cached_source_info, psym_print_stats)
783 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
784 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
785 (psym_map_matching_symbols, psym_expand_symtabs_matching)
786 (psym_find_compunit_symtab_by_address)
787 (maintenance_print_psymbols, maintenance_info_psymtabs)
788 (maintenance_check_psymtabs): Update.
789 * psymtab.h (require_partial_symbols): Change type of "verbose" to
790 bool.
791
792 2019-11-22 Tom Tromey <tom@tromey.com>
793
794 * observable.h: Update comments.
795
796 2019-11-22 Tom Tromey <tromey@adacore.com>
797
798 * ada-tasks.c (ada_task_is_alive): Make parameter const.
799 (print_ada_task_info): Don't try to fetch thread id if task is not
800 alive.
801
802 2019-11-22 Christian Biesinger <cbiesinger@google.com>
803
804 * ada-exp.y: Update.
805 * ada-lang.c (sort_choices): Update.
806 (ada_print_symbol_signature): Update.
807 (resolve_subexp): Update.
808 (ada_parse_renaming): Update.
809 (ada_read_renaming_var_value): Update.
810 (lesseq_defined_than): Update.
811 (remove_extra_symbols): Update.
812 (remove_irrelevant_renamings): Update.
813 (ada_add_block_symbols): Update.
814 (ada_collect_symbol_completion_matches): Update.
815 (ada_is_renaming_symbol): Update.
816 (aggregate_assign_from_choices): Update.
817 (ada_evaluate_subexp): Update.
818 (ada_has_this_exception_support): Update.
819 (ada_is_non_standard_exception_sym): Update.
820 (ada_add_exceptions_from_frame): Update.
821 (ada_add_global_exceptions): Update.
822 (ada_print_subexp): Update.
823 * ax-gdb.c (gen_var_ref): Update.
824 (gen_maybe_namespace_elt): Update.
825 (gen_expr_for_cast): Update.
826 (gen_expr): Update.
827 * block.h: Update.
828 * blockframe.c (find_pc_partial_function): Update.
829 * breakpoint.c (print_breakpoint_location): Update.
830 (update_static_tracepoint): Update.
831 * btrace.c (ftrace_print_function_name): Update.
832 (ftrace_function_switched): Update.
833 * buildsym.c (find_symbol_in_list): Update.
834 * c-exp.y: Update.
835 * c-typeprint.c (c_print_typedef): Update.
836 (c_type_print_template_args): Update.
837 * cli/cli-cmds.c (edit_command): Update.
838 (list_command): Update.
839 (print_sal_location): Update.
840 * coffread.c (patch_opaque_types): Update.
841 (process_coff_symbol): Update.
842 (coff_read_enum_type): Update.
843 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
844 (convert_one_symbol): Update.
845 (hash_symname): Update.
846 (eq_symname): Update.
847 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
848 * compile/compile-cplus-types.c (debug_print_scope): Update.
849 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
850 * compile/compile-object-load.c (get_out_value_type): Update.
851 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
852 (search_symbol_list): Update.
853 (cp_lookup_symbol_imports_or_template): Update.
854 * cp-support.c (overload_list_add_symbol): Update.
855 * ctfread.c (psymtab_to_symtab): Update.
856 * dbxread.c (cp_set_block_scope): Update.
857 * dictionary.c (iter_match_first_hashed): Update.
858 (iter_match_next_hashed): Update.
859 (insert_symbol_hashed): Update.
860 (iter_match_next_linear): Update.
861 * dictionary.h: Update.
862 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
863 (locexpr_describe_location_piece): Update.
864 (locexpr_describe_location_1): Update.
865 (locexpr_generate_c_location): Update.
866 (loclist_describe_location): Update.
867 (loclist_generate_c_location): Update.
868 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
869 (read_func_scope): Update.
870 (process_enumeration_scope): Update.
871 (new_symbol): Update.
872 (dwarf2_const_value): Update.
873 (dwarf2_symbol_mark_computed): Update.
874 * eval.c (evaluate_funcall): Update.
875 (evaluate_subexp_standard): Update.
876 * expprint.c (print_subexp_standard): Update.
877 (dump_subexp_body_standard): Update.
878 * f-valprint.c (info_common_command_for_block): Update.
879 * findvar.c (get_hosting_frame): Update.
880 (default_read_var_value): Update.
881 * go-lang.c (go_symbol_package_name): Update.
882 * guile/scm-block.c (bkscm_print_block_smob): Update.
883 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
884 (gdbscm_symbol_name): Update.
885 (gdbscm_symbol_linkage_name): Update.
886 (gdbscm_symbol_print_name): Update.
887 * infcall.c (get_function_name): Update.
888 * infcmd.c (jump_command): Update.
889 (finish_command): Update.
890 * infrun.c (insert_exception_resume_breakpoint): Update.
891 * linespec.c (canonicalize_linespec): Update.
892 (create_sals_line_offset): Update.
893 (convert_linespec_to_sals): Update.
894 (complete_label): Update.
895 (find_label_symbols_in_block): Update.
896 * m2-typeprint.c (m2_print_typedef): Update.
897 * mdebugread.c (mdebug_reg_to_regnum): Update.
898 (parse_symbol): Update.
899 (mylookup_symbol): Update.
900 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
901 (list_args_or_locals): Update.
902 * objc-lang.c (compare_selectors): Update.
903 (info_selectors_command): Update.
904 (compare_classes): Update.
905 (info_classes_command): Update.
906 (find_imps): Update.
907 * p-typeprint.c (pascal_print_typedef): Update.
908 * printcmd.c (build_address_symbolic): Update.
909 (info_address_command): Update.
910 (print_variable_and_value): Update.
911 * python/py-framefilter.c (extract_sym): Update.
912 (py_print_single_arg): Update.
913 * python/py-symbol.c (sympy_str): Update.
914 (sympy_get_name): Update.
915 (sympy_get_linkage_name): Update.
916 * python/python.c (gdbpy_rbreak): Update.
917 * record-btrace.c (btrace_get_bfun_name): Update.
918 (btrace_call_history): Update.
919 * rust-lang.c (rust_print_typedef): Update.
920 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
921 * stabsread.c (stab_reg_to_regnum): Update.
922 (define_symbol): Update.
923 (read_enum_type): Update.
924 (common_block_end): Update.
925 (cleanup_undefined_types_1): Update.
926 (scan_file_globals): Update.
927 * stack.c (print_frame_arg): Update.
928 (print_frame_args): Update.
929 (find_frame_funname): Update.
930 (info_frame_command_core): Update.
931 (iterate_over_block_locals): Update.
932 (print_block_frame_labels): Update.
933 (do_print_variable_and_value): Update.
934 (iterate_over_block_arg_vars): Update.
935 (return_command): Update.
936 * symmisc.c (dump_symtab_1): Update.
937 (print_symbol): Update.
938 * symtab.c (eq_symbol_entry): Update.
939 (symbol_cache_dump): Update.
940 (lookup_language_this): Update.
941 (find_pc_sect_line): Update.
942 (skip_prologue_sal): Update.
943 (symbol_search::compare_search_syms): Update.
944 (treg_matches_sym_type_name): Update.
945 (search_symbols): Update.
946 (print_symbol_info): Update.
947 (rbreak_command): Update.
948 (completion_list_add_symbol): Update.
949 (find_gnu_ifunc): Update.
950 (get_symbol_address): Update.
951 (search_module_symbols): Update.
952 (info_module_subcommand): Update.
953 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
954 (SYMBOL_LINKAGE_NAME): Remove.
955 (SYMBOL_DEMANGLED_NAME): Remove.
956 (SYMBOL_PRINT_NAME): Remove.
957 (SYMBOL_SEARCH_NAME): Remove.
958 * tracepoint.c (set_traceframe_context): Update.
959 (validate_actionline): Update.
960 (collection_list::collect_symbol): Update.
961 (encode_actions_1): Update.
962 (info_scope_command): Update.
963 (print_one_static_tracepoint_marker): Update.
964 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
965 * valops.c (address_of_variable): Update.
966 (find_overload_match): Update.
967 (find_oload_champ): Update.
968
969 2019-11-22 Christian Biesinger <cbiesinger@google.com>
970
971 * ada-lang.c (ada_lookup_simple_minsym): Update.
972 (ada_collect_symbol_completion_matches): Update.
973 * ada-tasks.c (read_atcb): Update.
974 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
975 (amd64_windows_skip_trampoline_code): Update.
976 * arm-tdep.c (skip_prologue_function): Update.
977 (arm_skip_stack_protector): Update.
978 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
979 (arm_wince_skip_main_prologue): Update.
980 * ax-gdb.c (gen_expr): Update.
981 * block.c (call_site_for_pc): Update.
982 * blockframe.c (find_pc_partial_function): Update.
983 * breakpoint.c (set_breakpoint_location_function): Update.
984 * btrace.c (ftrace_print_function_name): Update.
985 (ftrace_function_switched): Update.
986 * c-valprint.c (print_unpacked_pointer): Update.
987 * coffread.c (coff_symfile_read): Update.
988 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
989 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
990 * dwarf-index-write.c (write_psymbols): Update.
991 * dwarf2loc.c (call_site_to_target_addr): Update.
992 (func_verify_no_selftailcall): Update.
993 (tailcall_dump): Update.
994 (call_site_find_chain_1): Update.
995 (dwarf_expr_reg_to_entry_parameter): Update.
996 * elfread.c (elf_gnu_ifunc_record_cache): Update.
997 * eval.c (evaluate_funcall): Update.
998 (evaluate_subexp_standard): Update.
999 (evaluate_subexp_for_sizeof): Update.
1000 * expprint.c (print_subexp_standard): Update.
1001 (dump_subexp_body_standard): Update.
1002 * frame.c (get_prev_frame_always_1): Update.
1003 * frv-tdep.c (frv_skip_main_prologue): Update.
1004 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1005 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1006 (gnuv3_get_typename_from_type_info): Update.
1007 (gnuv3_skip_trampoline): Update.
1008 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1009 * i386-tdep.c (i386_skip_main_prologue): Update.
1010 (i386_pe_skip_trampoline_code): Update.
1011 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1012 * infcall.c (get_function_name): Update.
1013 * linespec.c (minsym_found): Update.
1014 * linux-fork.c (info_checkpoints_command): Update.
1015 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1016 (m32c_m16c_pointer_to_address): Update.
1017 * maint.c (maintenance_translate_address): Update.
1018 * minsyms.c (add_minsym_to_hash_table): Update.
1019 (add_minsym_to_demangled_hash_table): Update.
1020 (lookup_minimal_symbol_mangled): Update.
1021 (lookup_minimal_symbol_demangled): Update.
1022 (lookup_minimal_symbol_linkage): Update.
1023 (lookup_minimal_symbol_text): Update.
1024 (lookup_minimal_symbol_by_pc_name): Update.
1025 (minimal_symbol_is_less_than): Update.
1026 (compact_minimal_symbols): Update.
1027 (build_minimal_symbol_hash_tables): Update.
1028 (find_solib_trampoline_target): Update.
1029 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1030 (mips_skip_pic_trampoline_code): Update.
1031 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1032 * objc-lang.c (info_selectors_command): Update.
1033 (info_classes_command): Update.
1034 (find_methods): Update.
1035 (find_imps): Update.
1036 * p-valprint.c (pascal_val_print): Update.
1037 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1038 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1039 * printcmd.c (build_address_symbolic): Update.
1040 (info_symbol_command): Update.
1041 * psymtab.c (psymbol_name_matches): Update.
1042 (match_partial_symbol): Update.
1043 (lookup_partial_symbol): Update.
1044 (print_partial_symbols): Update.
1045 (sort_pst_symbols): Update.
1046 (maintenance_check_psymtabs): Update.
1047 * python/py-framefilter.c (py_print_frame): Update.
1048 * python/python.c (gdbpy_rbreak): Update.
1049 * record-btrace.c (btrace_get_bfun_name): Update.
1050 (btrace_call_history): Update.
1051 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1052 (rs6000_skip_trampoline_code): Update.
1053 * sol-thread.c (info_cb): Update.
1054 * stabsread.c (scan_file_globals): Update.
1055 * stack.c (find_frame_funname): Update.
1056 (info_frame_command_core): Update.
1057 * symmisc.c (dump_msymbols): Update.
1058 * symtab.c (symbol_natural_name): Rename to..,
1059 (general_symbol_info::natural_name): ...this.
1060 (symbol_demangled_name): Rename to...
1061 (general_symbol_info::demangled_name): ...this.
1062 (symbol_search_name): Rename to...
1063 (general_symbol_info::search_name): ...this.
1064 (symbol_matches_search_name): Update.
1065 (find_pc_sect_line): Update.
1066 (skip_prologue_sal): Update.
1067 (search_symbols): Update.
1068 (print_msymbol_info): Update.
1069 (rbreak_command): Update.
1070 (completion_list_add_msymbol): Update.
1071 (completion_list_objc_symbol): Update.
1072 (get_msymbol_address): Update.
1073 * symtab.h (struct general_symbol_info): Add member functions
1074 natural_name (), linkage_name (), print_name (), demangled_name (),
1075 and search_name ().
1076 (SYMBOL_NATURAL_NAME): Update.
1077 (symbol_natural_name): Move to a member function on general_symbol_info.
1078 (SYMBOL_DEMANGLED_NAME): Update.
1079 (symbol_demangled_name): Move to a member function on
1080 general_symbol_info.
1081 (SYMBOL_SEARCH_NAME): Update.
1082 (symbol_search_name): Move to a member function on general_symbol_info.
1083 (MSYMBOL_NATURAL_NAME): Remove.
1084 (MSYMBOL_LINKAGE_NAME): Remove.
1085 (MSYMBOL_PRINT_NAME): Remove.
1086 (MSYMBOL_DEMANGLED_NAME): Remove.
1087 (MSYMBOL_SEARCH_NAME): Remove.
1088 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1089
1090 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1091
1092 * symtab.c (create_demangled_names_hash): Use per_bfd->
1093 minimal_symbol_count for computing the initial size, if greater
1094 than our default size.
1095
1096 2019-11-22 Tom de Vries <tdevries@suse.de>
1097
1098 * contrib/words.sh: Improve words extraction.
1099
1100 2019-11-22 Tom de Vries <tdevries@suse.de>
1101
1102 * contrib/words.sh: Combine sed invocations.
1103
1104 2019-11-21 Christian Biesinger <cbiesinger@google.com>
1105
1106 * Makefile.in: Update.
1107 * demangle.c: Rename to...
1108 * gdb-demangle.c: ..this.
1109 (is_cplus_marker): Change return type to bool.
1110 (_initialize_demangler): Rename to...
1111 (_initialize_gdb_demangle): ...this.
1112 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1113 * symtab.h (demangle): Remove declaration; instead include
1114 gdb-demangle.h.
1115
1116 2019-11-21 Tom Tromey <tromey@adacore.com>
1117
1118 * gdbsupport/format.c (format_pieces): Parse %I64d.
1119 * unittests/format_pieces-selftests.c (test_windows_formats): New
1120 function.
1121 (run_tests): Call it.
1122
1123 2019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1124
1125 Byte reverse display of variables with DW_END_big, DW_END_little
1126 (DW_AT_endianity) dwarf attributes if different than the native
1127 byte order.
1128 * ada-lang.c (ada_value_binop):
1129 Use type_byte_order instead of gdbarch_byte_order.
1130 * ada-valprint.c (printstr):
1131 (ada_val_print_string):
1132 * ada-lang.c (value_pointer):
1133 (ada_value_binop):
1134 Use type_byte_order instead of gdbarch_byte_order.
1135 * c-lang.c (c_get_string):
1136 Use type_byte_order instead of gdbarch_byte_order.
1137 * c-valprint.c (c_val_print_array):
1138 Use type_byte_order instead of gdbarch_byte_order.
1139 * cp-valprint.c (cp_print_class_member):
1140 Use type_byte_order instead of gdbarch_byte_order.
1141 * dwarf2loc.c (rw_pieced_value):
1142 Use type_byte_order instead of gdbarch_byte_order.
1143 * dwarf2read.c (read_base_type): Handle DW_END_big,
1144 DW_END_little
1145 * f-lang.c (f_get_encoding):
1146 Use type_byte_order instead of gdbarch_byte_order.
1147 * findvar.c (default_read_var_value):
1148 Use type_byte_order instead of gdbarch_byte_order.
1149 * gdbtypes.c (check_types_equal):
1150 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1151 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1152 and TYPE_ENDIANITY_LITTLE if set.
1153 (type_byte_order): new function.
1154 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1155 (struct main_type) <flag_endianity_not_default>:
1156 New field.
1157 (type_byte_order): New function.
1158 * infcmd.c (default_print_one_register_info):
1159 Use type_byte_order instead of gdbarch_byte_order.
1160 * p-lang.c (pascal_printstr):
1161 Use type_byte_order instead of gdbarch_byte_order.
1162 * p-valprint.c (pascal_val_print):
1163 Use type_byte_order instead of gdbarch_byte_order.
1164 * printcmd.c (print_scalar_formatted):
1165 Use type_byte_order instead of gdbarch_byte_order.
1166 * solib-darwin.c (darwin_current_sos):
1167 Use type_byte_order instead of gdbarch_byte_order.
1168 * solib-svr4.c (solib_svr4_r_ldsomap):
1169 Use type_byte_order instead of gdbarch_byte_order.
1170 * stap-probe.c (stap_modify_semaphore):
1171 Use type_byte_order instead of gdbarch_byte_order.
1172 * target-float.c (target_float_same_format_p):
1173 Use type_byte_order instead of gdbarch_byte_order.
1174 * valarith.c (scalar_binop):
1175 (value_bit_index):
1176 Use type_byte_order instead of gdbarch_byte_order.
1177 * valops.c (value_cast):
1178 Use type_byte_order instead of gdbarch_byte_order.
1179 * valprint.c (generic_emit_char):
1180 (generic_printstr):
1181 (val_print_string):
1182 Use type_byte_order instead of gdbarch_byte_order.
1183 * value.c (unpack_long):
1184 (unpack_bits_as_long):
1185 (unpack_value_bitfield):
1186 (modify_field):
1187 (pack_long):
1188 (pack_unsigned_long):
1189 Use type_byte_order instead of gdbarch_byte_order.
1190 * findvar.c (unsigned_pointer_to_address):
1191 (signed_pointer_to_address):
1192 (unsigned_address_to_pointer):
1193 (address_to_signed_pointer):
1194 (default_read_var_value):
1195 (default_value_from_register):
1196 Use type_byte_order instead of gdbarch_byte_order.
1197 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1198 Use type_byte_order instead of gdbarch_byte_order.
1199 * riscv-tdep.c (riscv_print_one_register_info):
1200 Use type_byte_order instead of gdbarch_byte_order.
1201
1202 2019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1203
1204 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1205 (current_ui_gdb_stdin_ptr): Likewise.
1206 (current_ui_gdb_stderr_ptr): Likewise.
1207 (current_ui_gdb_stdlog_ptr): Likewise.
1208 (current_ui_current_uiout_ptr): Likewise.
1209 (gen_ret_current_ui_field_ptr): Remove.
1210
1211 2019-11-21 Tom de Vries <tdevries@suse.de>
1212
1213 PR gdb/24956
1214 * cli/cli-script.c (execute_control_command): Only switch to
1215 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1216
1217 2019-11-19 Tom Tromey <tom@tromey.com>
1218
1219 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1220 Now static. Change type of "name".
1221 (tui_set_win_height_command): Don't copy "arg".
1222 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1223 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1224
1225 2019-11-19 Ali Tamur <tamur@google.com>
1226
1227 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1228 "if (attr != nullptr)".
1229 (dwarf2_find_base_address): Likewise.
1230 (dwarf2_build_include_psymtabs): Likewise.
1231 (read_cutu_die_from_dwo): Likewise.
1232 (read_func_scope): Likewise.
1233 (read_call_site_scope): Likewise.
1234 (dwarf2_get_pc_bounds): Likewise.
1235 (dwarf2_record_block_ranges): Likewise.
1236 (dwarf2_add_field): Likewise.
1237 (dwarf2_add_member_fn): Likewise.
1238 (read_structure_type): Likewise.
1239 (read_enumeration_type): Likewise.
1240 (read_array_type): Likewise.
1241 (read_array_order): Likewise.
1242 (read_set_type): Likewise.
1243 (read_common_block): Likewise.
1244 (read_tag_reference_type): Likewise.
1245 (read_tag_string_type): Likewise.
1246 (read_subroutine_type): Likewise.
1247 (read_base_type): Likewise.
1248 (read_subrange_type): Likewise.
1249 (new_symbol): Likewise.
1250 (prepare_one_comp_unit): Likewise.
1251
1252 2019-11-19 Tom Tromey <tromey@adacore.com>
1253
1254 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1255 result in error when DebugActiveProcess fails.
1256
1257 2019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1258 Pedro Alves <palves@redhat.com>
1259
1260 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1261 * target.c (target_stack::push): Call 'unpush' if there's a
1262 target on top of the stack.
1263
1264 2019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1265
1266 * python/py-block.c (blpy_dealloc): Call tp_free.
1267 (blpy_block_syms_dealloc): Likewise.
1268 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1269 * python/py-inferior.c (infpy_dealloc): Likewise.
1270 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1271 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1272 * python/py-symbol.c (sympy_dealloc): Likewise.
1273 * python/py-symtab.c (stpy_dealloc): Likewise.
1274 * python/py-type.c (typy_iterator_dealloc): Likewise.
1275
1276 2019-11-18 Christian Biesinger <cbiesinger@google.com>
1277
1278 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1279 constructor instead of using a class initializer.
1280
1281 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1282
1283 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1284 * configure: Regenerate.
1285 * configure.ac: Don't source common.host.
1286 * gdbsupport/common.host: Remove.
1287 * gdbsupport/mingw-strerror.c: Remove.
1288 * gdbsupport/posix-strerror.c: Rename to...
1289 * gdbsupport/safe-strerror.c: ...this.
1290
1291 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1292
1293 * maint.c (scoped_command_stats::print_time): Use localtime_r
1294 instead of localtime (provided through gnulib if necessary).
1295 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1296 of ctime.
1297
1298 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1299
1300 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1301 avoid compile errors.
1302
1303 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1304
1305 * config.in: Regenerate.
1306 * configure: Regenerate.
1307 * gdbsupport/common.m4: No longer check for strerror_r.
1308 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1309 POSIX version of strerror_r, now that gnulib provides it if
1310 necessary.
1311
1312 2019-11-14 Christian Biesinger <cbiesinger@google.com>
1313
1314 * README (`configure' options): Update.
1315
1316 2019-11-14 Tom Tromey <tromey@adacore.com>
1317
1318 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1319 expected type for the RHS if the LHS is a convenience variable.
1320
1321 2019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1322
1323 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1324 Provide explicit default and copy constructor.
1325
1326 2019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1327
1328 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1329 only call Py_INCREF (newbp) in the bppy_pending_object case.
1330
1331 2019-11-13 Tom Tromey <tromey@adacore.com>
1332
1333 PR build/25182:
1334 * psympriv.h (partial_symbol): Remove static assert.
1335 * symtab.h (general_symbol_info, symbol): Remove static assert.
1336
1337 2019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1338
1339 * gdbsupport/format.c (format_pieces::format_pieces): Support
1340 printf 'z' size modifier.
1341 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1342 * printcmd.c (ui_printf): Handle size_t_arg.
1343 * ui-out.c (ui_out::vmessage): Likewise.
1344 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1345 function.
1346 (run_tests): Call test_format_int_sizes.
1347
1348 2019-11-12 Christian Biesinger <cbiesinger@google.com>
1349
1350 * ada-exp.y (write_ambiguous_var): Update.
1351 * buildsym.c (add_symbol_to_list): Update.
1352 * dwarf2read.c (read_variable): Update.
1353 (new_symbol): Update.
1354 * jit.c (finalize_symtab): Update.
1355 * language.c (language_alloc_type_symbol): Update.
1356 * symtab.c (fixup_symbol_section): Update.
1357 (initialize_objfile_symbol_1): Move code to...
1358 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1359 (allocate_symbol): Update.
1360 (allocate_template_symbol): Update.
1361 (get_symbol_address): Update.
1362 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1363 of having as a field, and add a constructor.
1364 (SYMBOL_VALUE): Update.
1365 (SYMBOL_VALUE_ADDRESS): Update.
1366 (SET_SYMBOL_VALUE_ADDRESS): Update.
1367 (SYMBOL_VALUE_BYTES): Update.
1368 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1369 (SYMBOL_BLOCK_VALUE): Update.
1370 (SYMBOL_VALUE_CHAIN): Update.
1371 (SYMBOL_LANGUAGE): Update.
1372 (SYMBOL_SECTION): Update.
1373 (SYMBOL_OBJ_SECTION): Update.
1374 (SYMBOL_SET_LANGUAGE): Update.
1375 (SYMBOL_SET_LINKAGE_NAME): Update.
1376 (SYMBOL_SET_NAMES): Update.
1377 (SYMBOL_NATURAL_NAME): Update.
1378 (SYMBOL_LINKAGE_NAME): Update.
1379 (SYMBOL_DEMANGLED_NAME): Update.
1380 (SYMBOL_SEARCH_NAME): Update.
1381 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1382 (struct symbol): Update.
1383 (struct template_symbol): Update.
1384 (struct rust_vtable_symbol): Update.
1385 * xcoffread.c (SYMBOL_DUP): Update.
1386
1387 2019-11-12 Tom Tromey <tom@tromey.com>
1388
1389 * tui/tui-layout.c (show_layout): Set current_layout.
1390 (show_source_disasm_command, show_data)
1391 (show_source_or_disasm_and_command): Don't set current_layout.
1392
1393 2019-11-12 Tom Tromey <tom@tromey.com>
1394
1395 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1396
1397 2019-11-12 Tom Tromey <tom@tromey.com>
1398
1399 * tui/tui-win.c (resize_message): New global.
1400 (show_tui_resize_message): New function.
1401 (tui_async_resize_screen): Print message if requested.
1402 (_initialize_tui_win): Add tui-resize-message setting.
1403 * NEWS: Add entry for new commands.
1404
1405 2019-11-11 Tom Tromey <tom@tromey.com>
1406
1407 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1408 functions.
1409
1410 2019-11-11 Christian Biesinger <cbiesinger@google.com>
1411
1412 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1413
1414 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1415
1416 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1417 function.
1418 * python/python-internal.h (gdbpy_lookup_static_symbols):
1419 Declare new function.
1420 * python/python.c (python_GdbMethods): Add
1421 gdb.lookup_static_symbols method.
1422 * NEWS: Mention gdb.lookup_static_symbols.
1423
1424 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1425
1426 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1427 static block of current object file first. Also fix typo in
1428 header comment.
1429
1430 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1431
1432 * stack.c (set_last_displayed_sal): Delete.
1433 (last_displayed_sal_valid): Delete.
1434 (last_displayed_pspace): Delete.
1435 (last_displayed_addr): Delete.
1436 (last_displayed_symtab): Delete.
1437 (last_displayed_line): Delete.
1438 (class last_displayed_symtab_info_type): New.
1439 (last_displayed_symtab_info): New static global variable.
1440 (print_frame_info): Call methods on last_displayed_symtab_info.
1441 (clear_last_displayed_sal): Update header comment, and make use of
1442 last_displayed_symtab_info.
1443 (last_displayed_sal_is_valid): Likewise.
1444 (get_last_displayed_pspace): Likewise.
1445 (get_last_displayed_addr): Likewise.
1446 (get_last_displayed_symtab): Likewise.
1447 (get_last_displayed_line): Likewise.
1448 (get_last_displayed_sal): Likewise.
1449 * stack.h (clear_last_displayed_sal): Update header comment.
1450 (last_displayed_sal_is_valid): Likewise.
1451 (get_last_displayed_pspace): Likewise.
1452 (get_last_displayed_addr): Likewise.
1453 (get_last_displayed_symtab): Likewise.
1454 (get_last_displayed_line): Likewise.
1455 (get_last_displayed_sal): Likewise.
1456
1457 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1458
1459 * stack.c (frame_show_address): Convert return type to bool.
1460 * stack.h (frame_show_address): Likewise, and update header
1461 comment.
1462
1463 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1464
1465 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1466 * unittests/vec-utils-selftests.c: New file.
1467 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1468
1469 2019-11-10 Tom Tromey <tom@tromey.com>
1470
1471 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1472 (tui_highlight_win): Likewise.
1473 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1474 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1475 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1476 Don't set can_highlight.
1477
1478 2019-11-10 Tom Tromey <tom@tromey.com>
1479
1480 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1481 Remove unused declaration.
1482
1483 2019-11-08 Tom Tromey <tromey@adacore.com>
1484
1485 * top.c (read_command_file): Update.
1486 (command_line_input): Make return type const.
1487 * python/py-gdb-readline.c: Update.
1488 * linespec.c (decode_line_2): Update.
1489 * defs.h (command_line_input): Make return type const.
1490 * cli/cli-script.c (read_next_line): Make return type const.
1491 * ada-lang.c (get_selections): Update.
1492
1493 2019-11-06 Christian Biesinger <cbiesinger@google.com>
1494
1495 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1496 * mi/mi-main.c (output_cores): Likewise.
1497 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1498 (linux_xfer_osdata_modules): Likewise.
1499 * remote.c (register_remote_support_xml): Likewise.
1500 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1501 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1502
1503 2019-11-06 Tom Tromey <tom@tromey.com>
1504
1505 * tui/tui-interp.c: Don't include readline.h.
1506 * tui/tui-hooks.c: Don't include readline.h.
1507 * symmisc.c: Include tilde.h, not readline.h.
1508 * symfile.c: Include tilde.h, not readline.h.
1509 * source.c: Include tilde.h, not readline.h.
1510 * solib.c: Include tilde.h, not readline.h.
1511 * psymtab.c: Include tilde.h, not readline.h.
1512 * exec.c: Include tilde.h, not readline.h.
1513 * corelow.c: Include tilde.h, not readline.h.
1514 * cli/cli-dump.c: Include tilde.h, not readline.h.
1515 * cli/cli-cmds.c: Don't include readline.h.
1516
1517 2019-11-05 Tom Tromey <tom@tromey.com>
1518
1519 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1520 (tui_disassemble): Set addr_size.
1521 (tui_disasm_window::set_contents): Use addr_size.
1522
1523 2019-11-05 Tom Tromey <tom@tromey.com>
1524
1525 * rust-lang.c (rust_language_defn): Update.
1526 * python/py-value.c (valpy_string): Call c_get_string.
1527 * p-lang.c (pascal_language_defn): Update.
1528 * opencl-lang.c (opencl_language_defn): Update.
1529 * objc-lang.c (objc_language_defn): Update.
1530 * m2-lang.c (m2_language_defn): Update.
1531 * language.c (unknown_language_defn, auto_language_defn): Update.
1532 (default_get_string): Remove.
1533 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1534 * go-lang.c (go_language_defn): Update.
1535 * f-lang.c (f_language_defn): Update.
1536 * d-lang.c (d_language_defn): Update.
1537 * c-lang.c (c_language_defn, cplus_language_defn)
1538 (asm_language_defn, minimal_language_defn): Update.
1539 * ada-lang.c (ada_language_defn): Update.
1540 * language.h (struct language_defn) <la_get_string>: Remove.
1541 (LA_GET_STRING): Remove.
1542 (default_get_string): Don't declare.
1543
1544 2019-11-05 Tom Tromey <tom@tromey.com>
1545
1546 * tui/tui-source.h (struct tui_source_window): Inline
1547 constructor. Remove destructor.
1548 <style_changed, m_observable>: Move to superclass.
1549 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1550 (struct tui_source_window_base): Move private members to end.
1551 <style_changed, m_observable>: Move from tui_source_window.
1552 * tui/tui-winsource.c (tui_copy_source_line): Move from
1553 tui-source.c. Rename from copy_source_line. Add special handling
1554 for negative line number.
1555 (tui_source_window_base::style_changed): Move from
1556 tui_source_window.
1557 (tui_source_window_base): Register observer.
1558 (~tui_source_window_base): New.
1559 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1560 rename.
1561 (tui_source_window::set_contents): Use tui_copy_source_line.
1562 (tui_source_window::tui_source_window): Move to tui-source.h.
1563 (tui_source_window::~tui_source_window): Remove.
1564 (tui_source_window::style_changed): Move to superclass.
1565 * tui/tui-disasm.c (tui_disassemble): Create string file with
1566 styling, when possible. Add "addr_size" parameter.
1567 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1568 Don't compute maximum size.
1569 (len_without_escapes): New function
1570
1571 2019-11-05 Tom Tromey <tom@tromey.com>
1572
1573 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1574 std::string.
1575 * tui/tui-winsource.c (tui_show_source_line): Update.
1576 * tui/tui-source.c (tui_source_window::set_contents): Update.
1577 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1578
1579 2019-11-05 Christian Biesinger <cbiesinger@google.com>
1580
1581 * symtab.h (gdb_static_assert): Put && operator at the beginning
1582 of the line instead of the end.
1583
1584 2019-11-04 Christian Biesinger <cbiesinger@google.com>
1585
1586 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1587 and sizeof (symbol).
1588 * symtab.h: Add a static_assert for sizeof (partial_symbol).
1589
1590 2019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1591
1592 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1593 * configure.host: Mark *-*-solaris2.10* obsolete.
1594 * configure.tgt: Mark Solaris < 11 obsolete.
1595 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1596 Update target triplet.
1597
1598 2019-11-01 Tom Tromey <tromey@adacore.com>
1599
1600 * utils.c (print_sys_errmsg): Simplify.
1601
1602 2019-11-01 Tom Tromey <tromey@adacore.com>
1603
1604 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1605
1606 2019-11-01 Christian Biesinger <cbiesinger@google.com>
1607
1608 * configure: Regenerate.
1609 * configure.ac: Remove check for strerror_r.
1610 * gdbsupport/common.m4: Check for strerror_r.
1611
1612 2019-11-01 Luis Machado <luis.machado@linaro.org>
1613
1614 PR gdb/25124
1615
1616 * arm-tdep.c (arm_per_objfile): Rename to ...
1617 (arm_per_bfd): ... this.
1618 (arm_objfile_data_key): Rename to ...
1619 (arm_bfd_data_key): ... this.
1620 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1621 data.
1622 (arm_record_special_symbol): Likewise.
1623
1624 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1625
1626 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1627 end.
1628 * c-typeprint.c (c_print_typedef): Likewise.
1629 * f-typeprint.c (f_print_typedef): Likewise.
1630 * m2-typeprint.c (m2_print_typedef): Likewise.
1631 * p-typeprint.c (pascal_print_typedef): Likewise.
1632 * rust-lang.c (rust_print_typedef): Likewise.
1633 * symtab.c (print_symbol_info): Print a newline after calling
1634 typedef_print.
1635
1636 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1637
1638 * symtab.c (info_module_cmdlist): New variable.
1639 (info_module_command): New function.
1640 (search_module_symbols): New function.
1641 (info_module_subcommand): New function.
1642 (struct info_modules_var_func_options): New struct.
1643 (info_modules_var_func_options_defs): New variable.
1644 (make_info_modules_var_func_options_def_group): New function.
1645 (info_module_functions_command): New function.
1646 (info_module_variables_command): New function.
1647 (info_module_var_func_command_completer): New function.
1648 (_initialize_symtab): Register new 'info module functions' and
1649 'info module variables' commands.
1650 * symtab.h (typedef symbol_search_in_module): New typedef.
1651 (search_module_symbols): Declare new function.
1652 * NEWS: Mention new commands.
1653
1654 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1655
1656 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1657 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1658 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1659 MODULES_DOMAIN.
1660 (scan_partial_symbols): Only create partial module symbols for non
1661 declarations.
1662 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1663 and MODULES_DOMAIN.
1664 * symtab.c (search_domain_name): Likewise.
1665 (search_symbols): Likewise.
1666 (print_symbol_info): Likewise.
1667 (symtab_symbol_info): Likewise.
1668 (info_modules_command): New function.
1669 (_initialize_symtab): Register 'info modules' command.
1670 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1671 * NEWS: Mention new 'info modules' command.
1672
1673 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1674
1675 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1676 and $_gdb_maint_setting_str.
1677
1678 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1679
1680 * cli/cli-cmds.c (setting_cmd, value_from_setting)
1681 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1682 (str_value_from_setting, gdb_setting_str_internal_fn)
1683 (gdb_maint_setting_str_internal_fn): New functions.
1684 (_initialize_cli_cmds): Define the new convenience functions.
1685 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1686 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1687
1688 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1689
1690 * agent.c (set_can_use_agent): When the setting is turned on,
1691 look up agent symbols if we don't have them yet.
1692 (agent_new_objfile): Don't look up agent symbols when the agent
1693 setting is off.
1694
1695 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1696
1697 * config.in: Regenerate.
1698
1699 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1700
1701 * configure: Regenerate.
1702 * configure.ac: Check for strerror_r.
1703 * gdbsupport/common-utils.h (safe_strerror): Change return value
1704 to const char * and document that this function is now threadsafe.
1705 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1706 thread_local and call strerror_r, if available.
1707 * utils.c (perror_string): Update.
1708 (print_sys_errmsg): Update.
1709
1710 2019-10-31 Luis Machado <luis.machado@linaro.org>
1711
1712 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1713 objfile_key.
1714 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1715 objfile to fetch per-bfd data.
1716 (arm_find_exidx_entry): Likewise.
1717
1718 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1719
1720 * gdbsupport/agent.c (debug_agent): Change type to bool.
1721 (use_agent): Likewise.
1722 (all_agent_symbols_look_up): Likewise.
1723 (agent_loaded_p): Change return value to bool.
1724 (agent_look_up_symbols): Update.
1725 (agent_capability_check): Change return value to bool.
1726 * gdbsupport/agent.h (agent_loaded_p): Likewise.
1727 (debug_agent): Change type to bool.
1728 (use_agent): Likewise.
1729 (agent_capability_check): Change return value to bool.
1730
1731 2019-10-30 Christian Biesinger <cbiesinger@google.com>
1732
1733 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1734 (build_minimal_symbol_hash_tables): Code to clear the table moved
1735 to clear_minimal_symbol_hash_tables.
1736 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1737 when needed.
1738
1739 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1740
1741 * infcmd.c: Remove includes.
1742 * infrun.c: Remove includes.
1743
1744 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1745
1746 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1747 (grow_vect): Remove declaration.
1748 (ada_type_of_array): Remove declaration.
1749 (ada_update_initial_language): Remove declaration.
1750 (ada_fold_name): Remove declaration.
1751 (ada_fill_in_ada_prototype): Remove declaration.
1752 (user_select_syms): Remove declaration.
1753 (get_selections): Remove declaration.
1754 (ada_tag_type): Remove declaration.
1755 (ada_value_tag): Remove declaration.
1756 (ada_is_others_clause): Remove declaration.
1757 (ada_in_variant): Remove declaration.
1758 (ada_value_struct_elt): Remove declaration.
1759 (ada_attribute_name): Remove declaration.
1760 (ada_system_address_type): Remove declaration.
1761 * ada-lang.c (ada_watch_location_expression): Make static.
1762 (GROW_VECT): Move here from ada-lang.h.
1763 (grow_vect): Make static.
1764 (ada_update_initial_language): Make static.
1765 (ada_fold_name): Make static.
1766 (ada_type_of_array): Make static.
1767 (encoded_ordered_before): Move up.
1768 (sort_choices): Move up.
1769 (print_signatures): Move up.
1770 (ada_print_symbol_signature): Move up.
1771 (get_selections): Move up and make static.
1772 (user_select_syms): Move up and make static.
1773 (ada_value_struct_elt): Move up and make static.
1774 (ada_tag_type): Make static.
1775 (ada_value_tag): Make static.
1776 (ada_is_others_clause): Make static.
1777 (ada_in_variant): Make static.
1778 (ada_attribute_name): Make static.
1779
1780 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1781
1782 * ada-lang.c: Remove includes.
1783 * ada-typeprint.c: Remove includes.
1784 * ada-valprint.c: Remove includes.
1785
1786 2019-10-29 Simon Marchi <simon.marchi@efficios.com>
1787
1788 * addrmap.c: Add static assertions of type size, moved from
1789 _initialize_addrmap.
1790 (_initialize_addrmap): Remove.
1791
1792 2019-10-29 Christian Biesinger <cbiesinger@google.com>
1793
1794 * coffread.c (record_minimal_symbol): Update.
1795 (process_coff_symbol): Update.
1796 * dbxread.c (read_dbx_symtab): Update.
1797 * dwarf2read.c (add_partial_symbol): Update.
1798 (fixup_go_packaging): Update.
1799 (load_partial_dies): Update.
1800 (new_symbol): Update.
1801 * elfread.c (record_minimal_symbol): Change signature to use
1802 gdb::string_view instead of name+len.
1803 (elf_symtab_read): Update.
1804 (elf_rel_plt_read): Update.
1805 * mdebugread.c (parse_partial_symbols): Update.
1806 (handle_psymbol_enumerators): Update.
1807 (new_symbol): Update.
1808 * minsyms.c (minimal_symbol_reader::record_full): Change signature
1809 to use gdb::string_view instead of name+len.
1810 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1811 * psympriv.h (add_psymbol_to_list): Likewise.
1812 * psymtab.c (add_psymbol_to_bcache): Likewise.
1813 (add_psymbol_to_list): Likewise.
1814 * stabsread.c (define_symbol): Update.
1815 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1816 * symtab.h (SYMBOL_SET_NAMES): Likewise.
1817 (symbol_set_names): Likewise.
1818 * xcoffread.c (scan_xcoff_symtab): Update.
1819
1820 2019-10-29 Christian Biesinger <cbiesinger@google.com>
1821
1822 * symtab.h (symbol_set_names): Document that copy_name must be
1823 set to true for non-nullterminated strings.
1824 * symtab.c (symbol_set_names): Only make a nullterminated copy of
1825 linkage_name if the entry was not found and we need to demangle.
1826
1827 2019-10-29 Christian Biesinger <cbiesinger@google.com>
1828
1829 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1830 * dwarf2-frame.c (bsearch_fde_cmp): Update.
1831 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
1832 * gdbsupport/gdb_binary_search.h: New file.
1833
1834 2019-10-29 Christian Biesinger <cbiesinger@google.com>
1835
1836 * NEWS: Mention new --with-system-gdbinit-dir option.
1837 * config.in: Regenerate.
1838 * configure: Regenerate.
1839 * configure.ac: Add new option --with-system-gdbinit-dir.
1840 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
1841 for a ".gdb" suffix.
1842 * main.c (get_init_files): Change system_gdbinit argument to
1843 a vector and return the files in SYSTEM_GDBINIT_DIR in
1844 addition to SYSTEM_GDBINIT.
1845 (captured_main_1): Update.
1846 (print_gdb_help): Update.
1847 * top.c (print_gdb_configuration): Also print the value of
1848 SYSTEM_GDBINIT_DIR.
1849
1850 2019-10-28 Christian Biesinger <cbiesinger@google.com>
1851
1852 * gdbsupport/common-utils.h (startswith): Add an overloaded version
1853 that takes gdb::string_view arguments.
1854
1855 2019-10-26 Tom de Vries <tdevries@suse.de>
1856
1857 * aarch64-linux-tdep.c: Fix typos in comments.
1858 * aarch64-tdep.c: Same.
1859 * ada-lang.c: Same.
1860 * amd64-nat.c: Same.
1861 * arc-tdep.c: Same.
1862 * arch/aarch64-insn.c: Same.
1863 * block.c: Same.
1864 * breakpoint.h: Same.
1865 * btrace.h: Same.
1866 * c-varobj.c: Same.
1867 * cli/cli-decode.c: Same.
1868 * cli/cli-script.c: Same.
1869 * cli/cli-utils.h: Same.
1870 * coff-pe-read.c: Same.
1871 * coffread.c: Same.
1872 * compile/compile-cplus-symbols.c: Same.
1873 * compile/compile-object-run.c: Same.
1874 * completer.c: Same.
1875 * corelow.c: Same.
1876 * cp-support.c: Same.
1877 * demangle.c: Same.
1878 * dwarf-index-write.c: Same.
1879 * dwarf2-frame.c: Same.
1880 * dwarf2-frame.h: Same.
1881 * eval.c: Same.
1882 * frame-base.h: Same.
1883 * frame.h: Same.
1884 * gdbcmd.h: Same.
1885 * gdbtypes.h: Same.
1886 * gnu-nat.c: Same.
1887 * guile/scm-objfile.c: Same.
1888 * i386-tdep.c: Same.
1889 * i386-tdep.h: Same.
1890 * infcall.c: Same.
1891 * infcall.h: Same.
1892 * linux-nat.c: Same.
1893 * m68k-tdep.c: Same.
1894 * macroexp.c: Same.
1895 * memattr.c: Same.
1896 * mi/mi-cmd-disas.c: Same.
1897 * mi/mi-getopt.h: Same.
1898 * mi/mi-main.c: Same.
1899 * minsyms.c: Same.
1900 * nat/aarch64-sve-linux-sigcontext.h: Same.
1901 * objfiles.h: Same.
1902 * ppc-linux-nat.c: Same.
1903 * ppc-linux-tdep.c: Same.
1904 * ppc-tdep.h: Same.
1905 * progspace.h: Same.
1906 * prologue-value.h: Same.
1907 * python/py-evtregistry.c: Same.
1908 * python/py-instruction.h: Same.
1909 * record-btrace.c: Same.
1910 * record-full.c: Same.
1911 * remote.c: Same.
1912 * rs6000-tdep.c: Same.
1913 * ser-tcp.c: Same.
1914 * sol-thread.c: Same.
1915 * sparc-sol2-tdep.c: Same.
1916 * sparc64-tdep.c: Same.
1917 * stabsread.c: Same.
1918 * symfile.c: Same.
1919 * symtab.h: Same.
1920 * target.c: Same.
1921 * tracepoint.c: Same.
1922 * tui/tui-data.h: Same.
1923 * tui/tui-io.c: Same.
1924 * tui/tui-win.c: Same.
1925 * tui/tui.c: Same.
1926 * unittests/rsp-low-selftests.c: Same.
1927 * user-regs.h: Same.
1928 * utils.c: Same.
1929 * utils.h: Same.
1930 * valarith.c: Same.
1931 * valops.c: Same.
1932 * valprint.c: Same.
1933 * valprint.h: Same.
1934 * value.c: Same.
1935 * value.h: Same.
1936 * varobj.c: Same.
1937 * x86-nat.h: Same.
1938 * xtensa-tdep.c: Same.
1939
1940 2019-10-25 Ali Tamur <tamur@google.com>
1941
1942 * charset.c (find_charset_names): Reflect API change.
1943
1944 2019-10-25 Christian Biesinger <cbiesinger@google.com>
1945
1946 * symtab.c (struct demangled_name_entry): Change demangled name
1947 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
1948 part of the struct anymore.
1949 (symbol_set_names): No longer obstack allocate + copy the demangled
1950 name, just store the allocated name from bfd.
1951
1952 2019-10-25 Tom Tromey <tromey@adacore.com>
1953
1954 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
1955 (bsearch_cie_cmp, add_cie): Remove.
1956 (find_cie): Reimplement.
1957 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
1958 (dwarf2_build_frame_info): Update.
1959
1960 2019-10-24 H.J. Lu <hongjiu.lu@intel.com>
1961
1962 PR gdb/25126
1963 * symfile.c (reread_symbols): Call forget_cached_source_info to
1964 clear the stale source cache.
1965
1966 2019-10-24 Christian Biesinger <cbiesinger@google.com>
1967
1968 * configure: Regenerate.
1969 * configure.ac: Remove code that sets python_has_threads.
1970
1971 2019-10-24 Christian Biesinger <cbiesinger@google.com>
1972
1973 * config.in: Regenerate.
1974 * configure: Regenerate.
1975 * configure.ac: Remove the code that uses sed to get the python
1976 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
1977
1978 2019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
1979
1980 * python/py-progspace.c (pspy_block_for_pc): Return None for all
1981 error paths.
1982
1983 2019-10-23 Tom Tromey <tom@tromey.com>
1984
1985 * arc-tdep.c: Remove ".." from include.
1986 * frv-tdep.c: Remove ".." from include.
1987 * lm32-tdep.c: Remove ".." from include.
1988 * microblaze-tdep.c: Remove ".." from include.
1989 * or1k-tdep.h: Remove ".." from include.
1990 * s12z-tdep.c: Remove ".." from include.
1991 * Makefile.in (OPCODES_CFLAGS): Add comment.
1992 (TOP_CFLAGS): New variable.
1993 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
1994
1995 2019-10-23 Tom Tromey <tom@tromey.com>
1996
1997 * Makefile.in (READLINE_DIR): Update.
1998
1999 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2000
2001 * infcall.c (call_function_by_hand_dummy): Fix the function
2002 comment. And extract out a code section into...
2003 (reserve_stack_space): ...this new function.
2004
2005 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2006
2007 * infcall.c (value_arg_coerce): Remove an unused parameter.
2008 (call_function_by_hand_dummy): Update the call to
2009 'value_arg_coerce'.
2010
2011 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2012
2013 * infcall.c (call_function_by_hand_dummy): Refactor.
2014
2015 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2016
2017 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2018
2019 2019-10-23 Tom Tromey <tom@tromey.com>
2020
2021 * configure: Rebuild.
2022 * configure.ac: Don't check for sigprocmask.
2023 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2024
2025 2019-10-23 Tom Tromey <tom@tromey.com>
2026
2027 * configure: Rebuild.
2028 * acinclude.m4: Use m4_include, not sinclude.
2029
2030 2019-10-23 Tom de Vries <tdevries@suse.de>
2031
2032 PR breakpoints/24687
2033 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2034
2035 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2036
2037 * symtab.c (struct demangled_name_entry) <language>: Change from
2038 bitfield to regular variable.
2039
2040 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2041
2042 * symtab.c (struct demangled_name_entry): Add a constructor.
2043 (free_demangled_name_entry): New function to call the destructor
2044 for demangled_name_entry.
2045 (create_demangled_names_hash): Pass free_demangled_name_entry to
2046 htab_create_alloc.
2047 (symbol_set_names): Call placement new for demangled_name_entry.
2048 * utils.c: No longer include xxhash.h here, now that fast_hash
2049 is inlined in the header.
2050 * utils.h: Instead, include it here.
2051
2052 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2053
2054 * Makefile.in: Link with libxxhash.
2055 * config.in: Regenerate.
2056 * configure: Regenerate.
2057 * configure.ac: Search for libxxhash.
2058 * utils.c (fast_hash): Use xxhash if present.
2059
2060 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2061
2062 * utils.h (fast_hash): New function.
2063 * symtab.c (hash_demangled_name_entry): Call new function
2064 fast_hash.
2065
2066 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2067
2068 * symtab.c (struct demangled_name_entry): Change type of mangled
2069 to gdb::string_view. Also adds a constructor that takes the
2070 mangled name.
2071 (hash_demangled_name_entry): Update.
2072 (eq_demangled_name_entry): Update.
2073 (free_demangled_name_entry): New function to call the destructor
2074 now that this is not a POD anymore.
2075 (create_demangled_names_hash): Pass free_demangled_name_entry to
2076 htab_create_alloc.
2077 (symbol_set_names): Update.
2078
2079 2019-10-21 Ali Tamur <tamu@google.com>
2080
2081 * dwarf2read.c (dir_index): Change type.
2082 (file_name_index): Likewise.
2083 (line_header::include_dir_at): Change comment and implementation on
2084 whether it is DWARF 5.
2085 (line_header::is_valid_file_index): New function.
2086 (line_header::file_name_at): Change comment and implementation on
2087 whether it is DWARF 5.
2088 (line_header::file_names): Change to private field renamed as
2089 m_file_names and introduce a new accessor method.
2090 (line_header::file_names_size): New method.
2091 (line_header::include_dirs): Change to private field and rename as
2092 m_include_dirs.
2093 (dw2_get_file_names_reader): Define local var at a smaller scope and
2094 reflect API change.
2095 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2096 (process_structure_scope): Likewise.
2097 (line_header::add_include_dir): Change message and reflect renaming.
2098 (line_header::add_file_name): Likewise.
2099 (read_formatted_entries): Handle DW_FORM_data16.
2100 (dwarf_decode_line_header): Fix line header length calculation.
2101 (psymtab_include_file_name): Change comment and API.
2102 (lnp_state_machine::m_file): Update comment and reflect type change.
2103 (lnp_state_machine::record_line): Reflect type change.
2104 (dwarf_decode_lines): Reflect API change.
2105 (file_file_name): Likewise.
2106 (file_full_name): Likewise.
2107
2108 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2109
2110 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2111
2112 2019-10-21 Tom Tromey <tom@tromey.com>
2113
2114 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2115
2116 2019-10-21 Tom Tromey <tom@tromey.com>
2117
2118 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2119 NM_H. Use AC_CONFIG_LINKS.
2120 * configure: Rebuild.
2121 * Makefile.in (NM_H): New variable.
2122 (generated_files): Add NM_H. Remove gcore.
2123 (nm.h, stamp-nmh): New targets.
2124
2125 2019-10-20 Tom Tromey <tom@tromey.com>
2126
2127 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2128 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2129 obsolete comment.
2130 (put_objfile_before): Now static.
2131
2132 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2133
2134 * gdbsupport/common-utils.h (startswith): Change return type to
2135 bool.
2136
2137 2019-10-19 Christian Biesinger <cbiesinger@google.com>
2138
2139 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2140 * breakpoint.c (bp_locations_compare): Rename to...
2141 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2142 (update_global_location_list): Use std::sort instead of qsort.
2143 * buildsym.c (compare_line_numbers): Rename to...
2144 (lte_is_less_than): ...this, and change to std::sort semantics.
2145 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2146 instead of qsort.
2147 * disasm.c (compare_lines): Rename to...
2148 (line_is_less_than): ...this, and change to std::sort semantics.
2149 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2150 of qsort.
2151 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2152 (fde_is_less_than): ...this, and change to std::sort semantics.
2153 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2154 * mdebugread.c (compare_blocks):
2155 (block_is_less_than): ...this, and change to std::sort semantics.
2156 (sort_blocks): Call std::sort instead of qsort.
2157 * objfiles.c (qsort_cmp): Rename to...
2158 (sort_cmp): ...this, and change to std::sort semantics.
2159 (update_section_map): Call std::sort instead of qsort.
2160 * remote.c (compare_pnums): Remove.
2161 (map_regcache_remote_table): Call std::sort instead of qsort.
2162 * utils.c (compare_positive_ints): Remove.
2163 * utils.h (compare_positive_ints): Remove.
2164 * xcoffread.c (compare_lte): Remove.
2165 (arrange_linetable): Call std::sort instead of qsort.
2166
2167 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2168
2169 * symfile.c (init_entry_point_info): Fix typo.
2170 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2171
2172 2019-10-18 Tom de Vries <tdevries@suse.de>
2173
2174 * aarch64-tdep.c: Fix typos in comments.
2175 * ada-lang.c: Same.
2176 * ada-tasks.c: Same.
2177 * alpha-tdep.c: Same.
2178 * alpha-tdep.h: Same.
2179 * amd64-nat.c: Same.
2180 * amd64-windows-tdep.c: Same.
2181 * arc-tdep.c: Same.
2182 * arc-tdep.h: Same.
2183 * arch-utils.c: Same.
2184 * arm-nbsd-tdep.c: Same.
2185 * arm-tdep.c: Same.
2186 * ax-gdb.c: Same.
2187 * blockframe.c: Same.
2188 * btrace.c: Same.
2189 * c-varobj.c: Same.
2190 * coff-pe-read.c: Same.
2191 * coffread.c: Same.
2192 * cris-tdep.c: Same.
2193 * darwin-nat.c: Same.
2194 * dbxread.c: Same.
2195 * dcache.c: Same.
2196 * disasm.c: Same.
2197 * dtrace-probe.c: Same.
2198 * dwarf-index-write.c: Same.
2199 * dwarf2-frame-tailcall.c: Same.
2200 * dwarf2-frame.c: Same.
2201 * dwarf2read.c: Same.
2202 * eval.c: Same.
2203 * exceptions.c: Same.
2204 * fbsd-tdep.c: Same.
2205 * findvar.c: Same.
2206 * frame.c: Same.
2207 * frv-tdep.c: Same.
2208 * gnu-v3-abi.c: Same.
2209 * go32-nat.c: Same.
2210 * h8300-tdep.c: Same.
2211 * hppa-tdep.c: Same.
2212 * i386-linux-tdep.c: Same.
2213 * i386-tdep.c: Same.
2214 * ia64-libunwind-tdep.c: Same.
2215 * ia64-tdep.c: Same.
2216 * infcmd.c: Same.
2217 * infrun.c: Same.
2218 * linespec.c: Same.
2219 * linux-nat.c: Same.
2220 * linux-thread-db.c: Same.
2221 * machoread.c: Same.
2222 * mdebugread.c: Same.
2223 * mep-tdep.c: Same.
2224 * mn10300-tdep.c: Same.
2225 * namespace.c: Same.
2226 * objfiles.c: Same.
2227 * opencl-lang.c: Same.
2228 * or1k-tdep.c: Same.
2229 * osabi.c: Same.
2230 * ppc-linux-nat.c: Same.
2231 * ppc-linux-tdep.c: Same.
2232 * ppc-sysv-tdep.c: Same.
2233 * printcmd.c: Same.
2234 * procfs.c: Same.
2235 * record-btrace.c: Same.
2236 * record-full.c: Same.
2237 * remote-fileio.c: Same.
2238 * remote.c: Same.
2239 * rs6000-tdep.c: Same.
2240 * s12z-tdep.c: Same.
2241 * score-tdep.c: Same.
2242 * ser-base.c: Same.
2243 * ser-go32.c: Same.
2244 * skip.c: Same.
2245 * sol-thread.c: Same.
2246 * solib-svr4.c: Same.
2247 * solib.c: Same.
2248 * source.c: Same.
2249 * sparc-nat.c: Same.
2250 * sparc-sol2-tdep.c: Same.
2251 * sparc-tdep.c: Same.
2252 * sparc64-tdep.c: Same.
2253 * stabsread.c: Same.
2254 * stack.c: Same.
2255 * symfile.c: Same.
2256 * symtab.c: Same.
2257 * target-descriptions.c: Same.
2258 * target-float.c: Same.
2259 * thread.c: Same.
2260 * utils.c: Same.
2261 * valops.c: Same.
2262 * valprint.c: Same.
2263 * value.c: Same.
2264 * varobj.c: Same.
2265 * windows-nat.c: Same.
2266 * xcoffread.c: Same.
2267 * xstormy16-tdep.c: Same.
2268 * xtensa-tdep.c: Same.
2269
2270 2019-10-17 Tom Tromey <tromey@adacore.com>
2271
2272 * configure: Rebuild.
2273 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2274 in AC_CONFIG_FILES invocation.
2275 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2276 new-style config.status invocation.
2277
2278 2019-10-17 Tom de Vries <tdevries@suse.de>
2279
2280 * arm-nbsd-nat.c: Fix typos in comments.
2281 * arm-tdep.c: Same.
2282 * darwin-nat-info.c: Same.
2283 * dwarf2read.c: Same.
2284 * elfread.c: Same.
2285 * event-top.c: Same.
2286 * findvar.c: Same.
2287 * gdbtypes.c: Same.
2288 * hppa-tdep.c: Same.
2289 * i386-tdep.c: Same.
2290 * jit.c: Same.
2291 * main.c: Same.
2292 * mdebugread.c: Same.
2293 * moxie-tdep.c: Same.
2294 * nto-procfs.c: Same.
2295 * osabi.c: Same.
2296 * ppc-linux-tdep.c: Same.
2297 * remote.c: Same.
2298 * riscv-tdep.c: Same.
2299 * s390-tdep.c: Same.
2300 * sh-tdep.c: Same.
2301 * sparc-linux-tdep.c: Same.
2302 * sparc-nat.c: Same.
2303 * stack.c: Same.
2304 * target-descriptions.c: Same.
2305 * top.c: Same.
2306 * varobj.c: Same.
2307
2308 2019-10-16 Tom Tromey <tom@tromey.com>
2309
2310 * objfiles.h (struct objfile) <original_name>: Now const.
2311
2312 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2313
2314 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2315 pass on to sigsetjmp's second argument.
2316 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2317
2318 2019-10-16 Keith Seitz <keiths@redhat.com>
2319
2320 PR gdb/23567
2321 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2322 sections whose size is greater than the file size.
2323
2324 2019-10-16 Jim Wilson <jimw@sifive.com>
2325
2326 * riscv-tdep.c (riscv_gcc_target_options): New.
2327 (riscv_gnu_triplet_regexp): New.
2328 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2329 set_gdbarch_gnu_triplet_regexp.
2330
2331 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2332
2333 * Makefile.in: Add xml-builtin.h.
2334 * features/feature_to_c.sh: Add an include for xml-builtin.h
2335 to ensure that the compiler checks that the types match.
2336 * xml-builtin.h: New file.
2337 * xml-support.c (fetch_xml_builtin): Add missing const.
2338 * xml-support.h: Remove declaration of xml_builtins.
2339
2340 2019-10-16 Tom de Vries <tdevries@suse.de>
2341
2342 PR tdep/25096
2343 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2344 (amd64_classify_aggregate): ... here.
2345 (amd64_classify_aggregate_field): Handled fiels of nested structs
2346 recursively.
2347
2348 2019-10-16 Tom de Vries <tdevries@suse.de>
2349
2350 PR tdep/24104
2351 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2352 that handles 'theclass'.
2353
2354 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2355
2356 * linespec.c (decode_digits_ordinary): Update comment.
2357 * make-target-delegates: No longer need to handle VEC case.
2358 * memrange.c (normalize_mem_ranges): Update comment.
2359 * namespace.c (add_using_directive): Update comment.
2360 * objc-lang.c (uniquify_strings): Update comment.
2361 * ppc-linux-nat.c (struct thread_points): Update comment.
2362 * probe.h (find_probes_in_objfile): Update comment.
2363 * target.h (enum flash_preserve_mode): Update comment.
2364 * varobj.c (varobj_restrict_range): Update comment.
2365 * varobj.h (varobj_list_children): Update comment.
2366
2367 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2368
2369 * Makefile.in: Remove references to vec.h and vec.c.
2370 * aarch64-tdep.c: No longer include vec.h.
2371 * ada-lang.c: Likewise.
2372 * ada-lang.h: Likewise.
2373 * arm-tdep.c: Likewise.
2374 * ax.h: Likewise.
2375 * breakpoint.h: Likewise.
2376 * charset.c: Likewise.
2377 * cp-support.h: Likewise.
2378 * dtrace-probe.c: Likewise.
2379 * dwarf2read.c: Likewise.
2380 * extension.h: Likewise.
2381 * gdb_bfd.c: Likewise.
2382 * gdbsupport/gdb_vecs.h: Likewise.
2383 * gdbsupport/vec.c: Remove.
2384 * gdbsupport/vec.h: Remove.
2385 * gdbthread.h: Likewise.
2386 * guile/scm-type.c: Likewise.
2387 * inline-frame.c: Likewise.
2388 * machoread.c: Likewise.
2389 * memattr.c: Likewise.
2390 * memrange.h: Likewise.
2391 * namespace.h: Likewise.
2392 * nat/linux-btrace.h: Likewise.
2393 * osdata.c: Likewise.
2394 * parser-defs.h: Likewise.
2395 * progspace.h: Likewise.
2396 * python/py-type.c: Likewise.
2397 * record-btrace.c: Likewise.
2398 * rust-exp.y: Likewise.
2399 * solib-target.c: Likewise.
2400 * stap-probe.c: Likewise.
2401 * target-descriptions.c: Likewise.
2402 * target-memory.c: Likewise.
2403 * target.h: Likewise.
2404 * varobj.c: Likewise.
2405 * varobj.h: Likewise.
2406 * xml-support.h: Likewise.
2407
2408 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2409
2410 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2411 Update for new std::vector based implementation.
2412 (process_psymtab_comp_unit_reader): Likewise.
2413 (scan_partial_symbols): Likewise.
2414 (recursively_compute_inclusions): Likewise.
2415 (compute_compunit_symtab_includes): Likewise.
2416 (process_imported_unit_die): Likewise.
2417 (queue_and_load_dwo_tu): Likewise.
2418 (follow_die_sig_1): Likewise.
2419 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2420 (typedef dwarf2_per_cu_ptr): Remove.
2421 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2422 function.
2423 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2424 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2425 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2426 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2427 std::vector.
2428
2429 2019-10-15 Tom Tromey <tromey@adacore.com>
2430
2431 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2432 TID.
2433
2434 2019-10-15 Tom Tromey <tromey@adacore.com>
2435
2436 * windows-nat.c (windows_nat_target::fetch_registers)
2437 (windows_nat_target::store_registers): Rename "pid" to "tid".
2438
2439 2019-10-15 Tom Tromey <tromey@adacore.com>
2440
2441 * gdbarch.h, gdbarch.c: Rebuild.
2442 * gdbarch.sh (gcc_target_options): Change return type to
2443 std::string.
2444 * compile/compile.c (get_args): Update.
2445 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2446 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2447 std::string.
2448 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2449 std::string.
2450 * arch-utils.c (default_gcc_target_options): Return std::string.
2451 * arch-utils.h (default_gcc_target_options): Return std::string.
2452 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2453
2454 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2455
2456 * breakpoint.c (breakpoint_chain): Make static.
2457 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2458 of accessing breakpoint_chain.
2459
2460 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2461
2462 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2463 to a gdb::function_view and return value to bool.
2464 * breakpoint.h (iterate_over_breakpoints): Likewise.
2465 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2466 (pop_dummy_frame): Update.
2467 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2468 (gdbscm_breakpoints): Update.
2469 * python/py-breakpoint.c (build_bp_list): Update.
2470 (gdbpy_breakpoints): Update.
2471 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2472 Update.
2473 (bpfinishpy_handle_stop): Update.
2474 (bpfinishpy_handle_exit): Update.
2475 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2476 (svr4_update_solib_event_breakpoints): Update.
2477
2478 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2479
2480 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2481 when unwrapping single-field structs.
2482
2483 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2484
2485 * dwarf2read.c: Remove includes.
2486
2487 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2488
2489 * ui-out.c (ui_out::call_do_message): Silence
2490 -Wformat-nonliteral warning.
2491
2492 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2493
2494 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2495 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2496 include: readline/tilde.h.
2497
2498 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2499
2500 * remote.c (remote_target::get_trace_status): Remove declaration of
2501 trace_regblock_size.
2502
2503 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2504
2505 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2506 (show_user): Remove declaration of cmdlist.
2507 * cli/cli-cmds.h (max_user_call_depth): Declare.
2508 * cli/cli-script.c (execute_user_command): Remove declaration
2509 of max_user_call_depth.
2510
2511 2019-10-11 Jim Wilson <jimw@sifive.com>
2512
2513 * gdbsupport/print-utils.h (pulongest): Fix comment.
2514 (plongest): Likewise.
2515 (phex): Add missing comment, mention leading zeros.
2516 (phex_nz): Add mention of no leading zeros to comment.
2517
2518 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2519 plongest instead of unsigned long long cast.
2520
2521 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2522
2523 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2524 for external_editor_command and gdbtk_test.
2525
2526 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2527
2528 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2529 * varobj.c (varobjdebug): Move comment to...
2530 * varobj.h (varobjdebug): ...here, and declare.
2531
2532 2019-10-09 Tom Tromey <tom@tromey.com>
2533
2534 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2535 erase_data_content.
2536
2537 2019-10-09 Tom Tromey <tom@tromey.com>
2538
2539 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2540 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2541 * tui/tui-command.c (tui_cmd_window::resize)
2542 (tui_refresh_cmd_win): Update.
2543 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2544 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2545 * tui/tui-data.c (~tui_gen_win_info): Remove.
2546 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2547 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2548 (tui_redisplay_readline, tui_mld_flush)
2549 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2550 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2551 (tui_data_window::erase_data_content)
2552 (tui_data_item_window::rerender)
2553 (tui_data_item_window::refresh_window): Update.
2554 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2555 (box_win, tui_gen_win_info::make_window)
2556 (tui_gen_win_info::make_visible): Update.
2557 (tui_delete_win): Remove.
2558 * tui/tui-winsource.c
2559 (tui_source_window_base::do_erase_source_content): Update.
2560 (tui_show_source_line, tui_source_window_base::update_tab_width)
2561 (tui_source_window_base::update_exec_info): Update.
2562 * tui/tui-data.h (struct curses_deleter): New.
2563 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2564 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2565
2566 2019-10-09 Tom Tromey <tom@tromey.com>
2567
2568 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2569
2570 2019-10-09 Tom Tromey <tom@tromey.com>
2571
2572 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2573 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2574
2575 2019-10-09 Tom Tromey <tom@tromey.com>
2576
2577 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2578 window height directly.
2579 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2580 declare.
2581 * tui/tui-layout.c (tui_default_win_height): Remove.
2582 (tui_default_win_viewport_height): Remove.
2583
2584 2019-10-09 Tom Tromey <tom@tromey.com>
2585
2586 * tui/tui.h: Remove comments.
2587
2588 2019-10-09 Tom de Vries <tdevries@suse.de>
2589
2590 * python/lib/gdb/printer/bound_registers.py: Use
2591 '^builtin_type_bound128' as regexp argument for
2592 add_builtin_pretty_printer.
2593
2594 2019-10-09 Christian Biesinger <cbiesinger@google.com>
2595
2596 * guile/guile.c (guile_extension_script_ops): Remove forward
2597 declaration and mark as static.
2598 (guile_script_ops): Likewise.
2599 (extension_language_guile): Move further down in the file so
2600 it can reference the definitions for guile_{extension_,}script_ops.
2601
2602 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
2603
2604 * s390-tdep.c (390_process_record): Handle new arch13 instructions
2605 except SORTL, DFLTCC, and KDSA.
2606
2607 2019-10-08 Tom Tromey <tromey@adacore.com>
2608
2609 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2610 (struct safe_symbol_file_add_args): Remove.
2611
2612 2019-10-08 Tom Tromey <tromey@adacore.com>
2613
2614 * windows-nat.c: Don't include buildsym-legacy.h.
2615
2616 2019-10-08 Tom Tromey <tromey@adacore.com>
2617
2618 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2619
2620 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2621
2622 * gdbtypes.c (overload_debug): Move comment to header.
2623 * gdbtypes.h (overload_debug): Declare.
2624 * valops.c: Remove declaration of overload_debug, instead
2625 include gdbtypes.h.
2626
2627 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2628
2629 * language.c (show_language_command): Pass lang_frame_mismatch_warn
2630 through _().
2631 (lang_frame_mismatch_warn): Make const, mark with N_(), and
2632 move comment...
2633 * language.h (lang_frame_mismatch_warn): ... here. Also add
2634 declaration.
2635 * top.c (lang_frame_mismatch_warn): Remove declaration.
2636 (check_frame_language_change): Pass lang_frame_mismatch_warn
2637 through _().
2638
2639 2019-10-07 Christian Biesinger <cbiesinger@google.com>
2640
2641 * c-lang.h (vtbl_ptr_name): Declare.
2642 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2643 it from the header.
2644 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2645
2646 2019-10-07 Christian Biesinger <cbiesinger@google.com>
2647
2648 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2649 gdb_static_assert.
2650
2651 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
2652
2653 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2654 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2655 * ctfread.c: New file.
2656 * ctfread.h: New file.
2657 * elfread.c: Include ctfread.h.
2658 (struct elfinfo text_p): New member ctfsect.
2659 (elf_locate_sections): Mark CTF section.
2660 (elf_symfile_read): Call elfctf_build_psymtabs.
2661 * Makefile.in (LIBCTF): Add.
2662 (CLIBS): Use it.
2663 (CDEPS): Likewise.
2664 (DIST): Add ctfread.c.
2665
2666 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
2667
2668 * ctfread.c (struct nextfield): Renamed to ...
2669 (struct ctf_nextfield): ... this.
2670 (struct field_info): Renamed to ...
2671 (strut ctf_field_info): ... this.
2672 (attach_fields_to_type): Update for renamed structures.
2673 (ctf_add_member_cb): Likewise.
2674 (ctf_add_enum_member_cb): Likewise.
2675 (process_struct_members): Likewise.
2676 (process_enum_type): Likewise.
2677
2678 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
2679
2680 * tracectf.h: Rename, was ctf.h.
2681 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2682 * tracefile.c: Likewise.
2683 * tracepoint.c: Remove unused include ctf.h.
2684 * mi/mi-main.c: Likewise.
2685 * Makefile.in Replace ctf.c with tracectf.c.
2686
2687 2019-10-06 Joel Brobecker <brobecker@adacore.com>
2688
2689 * version.in: Change version number to "9.0.50.DATE-git".
2690
2691 2019-10-03 Tom Tromey <tom@tromey.com>
2692
2693 PR rust/24976:
2694 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2695
2696 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2697
2698 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2699 cp_search_name_hash.
2700 * NEWS: Add entry about nested function support.
2701
2702 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
2703 Andrew Burgess <andrew.burgess@embecosm.com>
2704
2705 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2706 for nested static variables when searchin VAR_DOMAIN.
2707 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2708 global scope, update comment.
2709 (add_partial_subprogram): Call add_partial_subprogram recursively
2710 for nested subroutines when processinng Fortran.
2711 (load_partial_dies): Process the child entities of a subprogram
2712 when processing Fortran.
2713 (partial_die_parent_scope): Handle building scope
2714 for Fortran nested functions.
2715 (process_die): Record that nested functions have a scope.
2716 (new_symbol): Always record Fortran subprograms on the global
2717 symbol list.
2718 (determine_prefix): How to build the prefix for Fortran
2719 subprograms.
2720
2721 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2722
2723 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2724 have just sent the thread a SIGSTOP and are waiting for it to
2725 arrive.
2726
2727 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2728
2729 * btrace.c (btrace_add_pc): Remove whitespace before the template
2730 parameter in 'std::vector <...>'.
2731 (parse_xml_btrace_block): Likewise.
2732 (btrace_maint_decode_pt): Likewise.
2733 (btrace_maint_update_packets): Likewise.
2734 (btrace_maint_print_packets): Likewise.
2735 * btrace.h (struct btrace_maint_info): Likewise.
2736 * dwarf2read.c (struct type_unit_group): Likewise.
2737 (build_type_psymtabs_reader): Likewise.
2738 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2739 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2740 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2741
2742 2019-10-03 Tom de Vries <tdevries@suse.de>
2743
2744 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2745 the first line of the help text for set/show style metadata.
2746
2747 2019-10-02 Tom Tromey <tromey@adacore.com>
2748
2749 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2750 * gdbsupport/common-inferior.c: New file.
2751 * infcmd.c (startup_with_shell): Don't define.
2752 * nat/fork-inferior.h (startup_with_shell): Don't declare.
2753 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2754 * inferior.h (startup_with_shell): Don't declare.
2755
2756 2019-10-02 Christian Biesinger <cbiesinger@google.com>
2757
2758 * gdbsupport/gdb_assert.h: Include errors.h.
2759 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2760
2761 2019-10-02 Tom Tromey <tromey@adacore.com>
2762
2763 * NEWS: Add $_ada_exception entry.
2764 * ada-lang.c (struct ada_catchpoint): Add constructor.
2765 <m_kind>: New member.
2766 (allocate_location_exception, re_set_exception): Remove
2767 "ex" parameter.
2768 (should_stop_exception): Compute $_ada_exception.
2769 (check_status_exception, print_it_exception)
2770 (print_one_exception, print_mention_exception): Remove
2771 "ex" parameter.
2772 (allocate_location_catch_exception, re_set_catch_exception)
2773 (check_status_exception, print_it_catch_exception)
2774 (print_one_catch_exception, print_mention_catch_exception)
2775 (print_recreate_catch_exception)
2776 (allocate_location_catch_exception_unhandled)
2777 (re_set_catch_exception_unhandled)
2778 (check_status_exception, print_it_catch_exception_unhandled)
2779 (print_one_catch_exception_unhandled)
2780 (print_mention_catch_exception_unhandled)
2781 (print_recreate_catch_exception_unhandled)
2782 (allocate_location_catch_assert, re_set_catch_assert)
2783 (check_status_assert, print_it_catch_assert)
2784 (print_one_catch_assert, print_mention_catch_assert)
2785 (print_recreate_catch_assert)
2786 (allocate_location_catch_handlers, re_set_catch_handlers)
2787 (check_status_handlers, print_it_catch_handlers)
2788 (print_one_catch_handlers, print_mention_catch_handlers)
2789 (print_recreate_catch_handlers): Remove.
2790 (create_ada_exception_catchpoint): Update.
2791 (initialize_ada_catchpoint_ops): Update.
2792
2793 2019-10-02 Tom Tromey <tromey@adacore.com>
2794
2795 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2796 (create_excep_cond_exprs): Simplify exception string computation.
2797 (ada_exception_catchpoint_cond_string): Likewise.
2798
2799 2019-10-02 Tom Tromey <tromey@adacore.com>
2800
2801 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2802 * ada-lang.c (lesseq_defined_than): Handle
2803 LOC_STATIC.
2804 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2805 parameter.
2806 (dwarf2_has_info): Likewise.
2807 (new_symbol): Set maybe_copied on symbol when
2808 appropriate.
2809 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2810 parameter.
2811 <can_copy>: New member.
2812 * elfread.c (record_minimal_symbol): Set maybe_copied
2813 on symbol when appropriate.
2814 (elf_symfile_read): Update call to dwarf2_has_info.
2815 * minsyms.c (lookup_minimal_symbol_linkage): New
2816 function.
2817 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2818 * symtab.c (get_symbol_address, get_msymbol_address):
2819 New functions.
2820 * symtab.h (get_symbol_address, get_msymbol_address):
2821 Declare.
2822 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2823 maybe_copied.
2824 (struct symbol, struct minimal_symbol) <maybe_copied>:
2825 New member.
2826
2827 2019-10-02 Tom Tromey <tromey@adacore.com>
2828
2829 * source.c (struct current_source_location): New.
2830 (current_source_key): New global.
2831 (current_source_symtab, current_source_line)
2832 (current_source_pspace): Remove.
2833 (get_source_location): New function.
2834 (get_current_source_symtab_and_line)
2835 (set_default_source_symtab_and_line)
2836 (set_current_source_symtab_and_line)
2837 (clear_current_source_symtab_and_line, select_source_symtab)
2838 (info_source_command, print_source_lines_base)
2839 (info_line_command, search_command_helper, _initialize_source):
2840 Update.
2841
2842 2019-10-02 Tom Tromey <tromey@adacore.com>
2843
2844 * source.c (select_source_symtab): Don't call
2845 decode_line_with_current_source.
2846
2847 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2848
2849 * symtab.c (lookup_global_symbol): Search global block.
2850
2851 2019-10-02 Tom Tromey <tromey@adacore.com>
2852
2853 * coffread.c (process_coff_symbol): Update.
2854 * dwarf2read.c (var_decode_location, new_symbol): Update.
2855 * mdebugread.c (parse_symbol): Update.
2856 * objfiles.c (relocate_one_symbol): Update.
2857 * stabsread.c (define_symbol, fix_common_block)
2858 (scan_file_globals): Update.
2859 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
2860 (SET_SYMBOL_VALUE_ADDRESS): New macro.
2861 * xcoffread.c (process_xcoff_symbol): Update.
2862
2863 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
2864
2865 * MAINTAINERS: Update my email address.
2866
2867 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2868
2869 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
2870 std::vector.
2871 (build_type_psymtabs_reader): Update for std::vector.
2872 (build_type_psymtab_dependencies): Likewise.
2873 * dwarf2read.h: Remove use of DEF_VEC_P.
2874 (typedef sig_type_ptr): Delete.
2875
2876 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2877
2878 * btrace.c (btrace_maint_clear): Update to handle change from VEC
2879 to std::vector.
2880 (btrace_maint_decode_pt): Likewise, and move allocation of the
2881 vector outside of the loop.
2882 (btrace_maint_update_packets): Update to handle change from VEC to
2883 std::vector.
2884 (btrace_maint_print_packets): Likewise.
2885 (maint_info_btrace_cmd): Likewise.
2886 * btrace.h: Remove use of DEF_VEC_O.
2887 (typedef btrace_pt_packet_s): Delete.
2888 (struct btrace_maint_info) <packets>: Change fromm VEC to
2889 std::vector.
2890 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
2891
2892 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2893
2894 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
2895 make accesses into the vector constant references.
2896 (btrace_add_pc): Update for std::vector.
2897 (btrace_stitch_bts): Likewise.
2898 (parse_xml_btrace_block): Likewise.
2899 (btrace_maint_update_packets): Likewise.
2900 (btrace_maint_print_packets): Likewise.
2901 (maint_info_btrace_cmd): Likewise.
2902 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
2903 std::vector.
2904 (btrace_data::empty): Likewise.
2905 (btrace_data_append): Likewise.
2906 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
2907 (typedef btrace_block_s): Delete.
2908 (struct btrace_block): Add constructor.
2909 (struct btrace_data_bts) <blocks>: Change to std::vector.
2910 * nat/linux-btrace.c (perf_event_read_bts): Update for
2911 std::vector.
2912 (linux_read_bts): Likewise.
2913
2914 2019-10-01 Tom Tromey <tom@tromey.com>
2915
2916 * cli/cli-logging.c (show_logging_filename): Use styled_string.
2917
2918 2019-10-01 Tom Tromey <tom@tromey.com>
2919
2920 * stack.c (print_frame, info_frame_command_core): Use
2921 styled_string.
2922 * linux-thread-db.c (try_thread_db_load_1)
2923 (try_thread_db_load_from_pdir_1): Use styled_string.
2924 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
2925 (auto_load_section_scripts, info_auto_load_local_gdbinit)
2926 (maybe_print_unsupported_script_warning)
2927 (maybe_print_script_not_found_warning): Use styled_string.
2928 * ada-lang.c (user_select_syms): Use styled_string.
2929
2930 2019-10-01 Tom Tromey <tom@tromey.com>
2931
2932 * p-lang.c (pascal_printstr): Use metadata style.
2933 * value.c (show_convenience): Use metadata style.
2934 * valprint.c (valprint_check_validity, val_print_optimized_out)
2935 (val_print_not_saved, val_print_unavailable)
2936 (val_print_invalid_address, generic_val_print, val_print)
2937 (value_check_printable, val_print_array_elements): Use metadata
2938 style.
2939 * ui-out.h (class ui_out) <field_fmt>: New overload.
2940 <do_field_fmt>: Add style parameter.
2941 * ui-out.c (ui_out::field_fmt): New overload.
2942 * typeprint.c (type_print_unknown_return_type)
2943 (val_print_not_allocated, val_print_not_associated): Use metadata
2944 style.
2945 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
2946 parameter.
2947 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
2948 * tracepoint.c (tvariables_info_1): Use metadata style.
2949 * stack.c (print_frame_arg, print_frame_info, print_frame)
2950 (info_frame_command_core): Use metadata style.
2951 * skip.c (info_skip_command): Use metadata style.
2952 * rust-lang.c (rust_print_enum): Use metadata style.
2953 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2954 metadata style.
2955 * python/py-framefilter.c (py_print_single_arg): Use metadata
2956 style.
2957 * printcmd.c (do_one_display, print_variable_and_value): Use
2958 metadata style.
2959 * p-valprint.c (pascal_val_print)
2960 (pascal_object_print_value_fields): Use metadata style.
2961 * p-typeprint.c (pascal_type_print_base): Use metadata style.
2962 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
2963 parameter.
2964 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
2965 * m2-valprint.c (m2_print_long_set): Use metadata style.
2966 * m2-typeprint.c (m2_print_type): Use metadata style.
2967 * infcmd.c (print_return_value_1): Use metadata style.
2968 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
2969 * f-valprint.c (info_common_command_for_block): Use metadata
2970 style.
2971 * f-typeprint.c (f_type_print_base): Use metadata style.
2972 * expprint.c (print_subexp_standard): Use metadata style.
2973 * cp-valprint.c (cp_print_value_fields): Use metadata style.
2974 * cli/cli-style.h (class cli_style_option): Add constructor.
2975 (metadata_style): Declare.
2976 * cli/cli-style.c (metadata_style): New global.
2977 (_initialize_cli_style): Register metadata style.
2978 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
2979 parameter.
2980 * cli-out.c (cli_ui_out::do_field_fmt): Update.
2981 * c-typeprint.c (c_type_print_base_struct_union)
2982 (c_type_print_base_1): Use metadata style.
2983 * breakpoint.c (watchpoint_value_print)
2984 (print_one_breakpoint_location): Use metadata style.
2985 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
2986 style.
2987 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
2988 style.
2989 * ada-valprint.c (val_print_packed_array_elements, printstr)
2990 (print_field_values, ada_val_print_ref, ada_val_print): Use
2991 metadata style.
2992 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
2993 style.
2994 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
2995 style.
2996 * ada-lang.c (user_select_syms): Use metadata style.
2997
2998 2019-10-01 Tom Tromey <tom@tromey.com>
2999
3000 * cli/cli-cmds.c (pwd_command): Style output.
3001
3002 2019-10-01 Pedro Alves <palves@redhat.com>
3003 Tom Tromey <tom@tromey.com>
3004
3005 * symtab.c (print_symbol_info): Use %ps.
3006 (print_msymbol_info): Use %ps.
3007 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3008 * printcmd.c (print_variable_and_value): Use %ps.
3009 * macrocmd.c (show_pp_source_pos): Use %ps.
3010 * infrun.c (print_exited_reason): Use ui_out::message.
3011 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3012 (describe_other_breakpoints): Use ui_out::message and new
3013 formats.
3014 (say_where): Use new formats.
3015 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3016 and new formats.
3017
3018 2019-10-01 Pedro Alves <palves@redhat.com>
3019 Tom Tromey <tom@tromey.com>
3020
3021 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3022 (test_gdb_formats): New function.
3023 (run_tests): Call it.
3024 (test_format_specifier): Update.
3025 * utils.h (fputs_filtered): Update comment.
3026 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3027 (fputs_styled_unfiltered): Declare.
3028 * utils.c (fputs_styled_unfiltered): New function.
3029 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3030 (vfprintf_filtered): Update.
3031 (vfprintf_unfiltered, vprintf_filtered): Update.
3032 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3033 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3034 disallow_ui_out_field>: New constants.
3035 (enum class field_kind): New.
3036 (struct base_field_s, struct signed_field_s): New.
3037 (signed_field): New function.
3038 (struct string_field_s): New.
3039 (string_field): New function.
3040 (struct styled_string_s): New.
3041 (styled_string): New function.
3042 (class ui_out) <message>: Add comment.
3043 <vmessage, call_do_message>: New methods.
3044 <do_message>: Add style parameter.
3045 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3046 methods.
3047 (ui_out::message): Rewrite.
3048 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3049 parameter.
3050 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3051 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3052 gdb_extensions parameter.
3053 (class format_piece): Add parameter to constructor.
3054 (n_int_args): New field.
3055 * gdbsupport/format.c (format_pieces::format_pieces): Add
3056 gdb_extensions parameter. Handle '*'.
3057 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3058 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3059 vfprintf_styled_no_gdbfmt.
3060 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3061 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3062 unfiltered output.
3063 * ui-style.h (struct ui_file_style) <ptr>: New method.
3064
3065 2019-10-01 Tom Tromey <tom@tromey.com>
3066
3067 * unittests/format_pieces-selftests.c: Update. Add final format.
3068 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3069 empty literal pieces.
3070
3071 2019-10-01 Tom Tromey <tom@tromey.com>
3072
3073 * ui-out.h (enum class ui_out_style_kind): Remove.
3074 (class ui_out) <field_string, field_stsream, do_field_string>:
3075 Change type of "style".
3076 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3077 (ui_out::field_string): Update.
3078 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3079 of "style".
3080 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3081 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3082 * stack.c (print_frame_arg, print_frame_info, print_frame):
3083 Update.
3084 * source.c (print_source_lines_base): Update.
3085 * solib.c (info_sharedlibrary_command): Update.
3086 * skip.c (info_skip_command): Update.
3087 * record-btrace.c (btrace_call_history_src_line)
3088 (btrace_call_history): Update.
3089 * python/py-framefilter.c (py_print_frame): Update.
3090 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3091 "style".
3092 * mi/mi-out.c (mi_ui_out::do_table_header)
3093 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3094 (mi_ui_out::do_field_string): Update.
3095 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3096 Update.
3097 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3098 "style".
3099 * cli-out.c (cli_ui_out::do_table_header)
3100 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3101 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3102 (cli_ui_out::do_field_fmt): Update.
3103 * breakpoint.c (print_breakpoint_location): Update.
3104 (update_static_tracepoint): Update.
3105
3106 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3107
3108 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3109 conversion of gdb_datadir.
3110 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3111 remove not needed c_str ().
3112
3113 2019-09-30 Ali Tamur <tamur@google.com>
3114
3115 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3116 (dwarf2_string_attr): Likewise.
3117
3118 2019-09-30 Ali Tamur <tamur@google.com>
3119
3120 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3121 (process_full_type_unit): Likewise.
3122 (dump_die_shallow): Likewise.
3123 (cu_debug_loc_section): Likewise.
3124
3125 2019-09-28 Christian Biesinger <cbiesinger@google.com>
3126
3127 * minsyms.c (compare_minimal_symbols): Rename to...
3128 (minimal_symbol_is_less_than): ...this, and adjust to STL
3129 conventions (return bool, take arguments as references)
3130 (minimal_symbol_reader::install): Call std::sort instead
3131 of qsort.
3132
3133 2019-09-29 Christian Biesinger <cbiesinger@google.com>
3134
3135 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3136 hash and why.
3137 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3138 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3139
3140 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3141
3142 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3143 * psympriv.h (add_psymbol_to_list): Move comment here and update
3144 it.
3145
3146 2019-09-29 Tom de Vries <tdevries@suse.de>
3147
3148 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3149 Use $tmpdir/$(basename "$output_file").dwz instead of
3150 "${output_file}.dwz".
3151
3152 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3153
3154 PR gdb/25045
3155 * hppa-linux-nat.c: Include gdbarch.h.
3156
3157 2019-09-26 Christian Biesinger <cbiesinger@google.com>
3158
3159 * blockframe.c (find_pc_partial_function): Change return type to bool.
3160 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3161 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3162 (stub_gnu_ifunc_resolve_name): Likewise.
3163 * symtab.c (compare_filenames_for_search): Likewise.
3164 (compare_glob_filenames_for_search): Likewise.
3165 (matching_obj_sections): Likewise.
3166 (symbol_matches_domain): Likewise.
3167 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3168 (find_line_pc): Change return type to bool.
3169 (find_line_pc_range): Likewise.
3170 (producer_is_realview): Likewise.
3171 * symtab.h (symbol_matches_domain): Likewise.
3172 (find_pc_partial_function): Likewise.
3173 (find_pc_line_pc_range): Likewise.
3174 (in_gnu_ifunc_stub): Likewise.
3175 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3176 (find_line_pc): Likewise.
3177 (find_line_pc_range): Likewise.
3178 (matching_obj_sections): Likewise.
3179 (find_line_symtab): Change out parameter to bool.
3180 (producer_is_realview): Change return type to bool.
3181 (compare_filenames_for_search): Likewise.
3182 (compare_glob_filenames_for_search): Likewise.
3183
3184 2019-09-26 Tom Tromey <tom@tromey.com>
3185
3186 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3187 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3188 * gdb_usleep.h: Remove.
3189 * gdb_usleep.c: Remove.
3190 * utils.c: Don't include gdb_usleep.h.
3191
3192 2019-09-26 Tom Tromey <tromey@adacore.com>
3193
3194 * python/py-type.c (type_to_type_object): Call check_typedef
3195 for stub types.
3196
3197 2019-09-26 Tom Tromey <tom@tromey.com>
3198
3199 * utils.h (initialize_utils): Don't declare.
3200 * top.c (gdb_init): Don't call initialize_utils.
3201 * utils.c (initialize_utils): Remove. Move contents...
3202 (_initialize_utils): ... here.
3203
3204 2019-09-25 Tom Tromey <tom@tromey.com>
3205
3206 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3207 * utils.h (make_hex_string): Don't declare.
3208 * utils.c (make_hex_string): Remove.
3209
3210 2019-09-24 Tom de Vries <tdevries@suse.de>
3211
3212 PR gdb/23815
3213 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3214 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3215
3216 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3217
3218 * NEWS: Mention new simulator port for PRU.
3219
3220 2019-09-23 Christian Biesinger <cbiesinger@google.com>
3221
3222 * ada-exp.y (write_object_remaining): Update.
3223 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3224 and eliminate the static buffer.
3225 (ada_decode_symbol): Update.
3226 (ada_la_decode): Update.
3227 (ada_sniff_from_mangled_name): Update.
3228 (is_valid_name_for_wild_match): Update.
3229 (ada_lookup_name_info::matches): Update and simplify.
3230 (name_matches_regex): Update.
3231 (ada_add_global_exceptions): Update.
3232 * ada-lang.h (ada_decode): Update signature.
3233 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3234 * dwarf-index-write.c (debug_names::insert): Update.
3235
3236 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3237
3238 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3239 formatting.
3240
3241 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3242
3243 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3244 Change "nonzero" to "true" in documentation.
3245
3246 2019-09-20 Christian Biesinger <cbiesinger@google.com>
3247
3248 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3249 (_initialize_darwin_solib): Don't set
3250 darwin_so_ops.lookup_lib_global_symbol.
3251 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3252 set_gdbarch_iterate_over_objfiles_in_search_order.
3253 (elf_lookup_lib_symbol): Rename to...
3254 (svr4_iterate_over_objfiles_in_search_order): this, and update
3255 to iterate semantics.
3256 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3257 * solib.c (solib_global_lookup): Remove.
3258 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3259 (solib_global_lookup): Remove.
3260 * symtab.c (lookup_global_or_static_symbol): Remove call to
3261 solib_global_lookup.
3262
3263 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3264
3265 * NEWS: Move entries about default MI version now being
3266 version 3, and about the GDB/MI fix for multi-location
3267 breakpoints to the "since GDB 8.3" section.
3268
3269 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3270
3271 GDB 8.3.1 released.
3272
3273 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3274
3275 * NEWS: Mention that Cell/B.E. debugging support was removed.
3276 * MAINTAINERS: Remove spu target.
3277
3278 * config/djgpp/fnchange.lst: Remove entries for removed files.
3279
3280 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3281 spu-multiarch.o, and spu-tdep.o.
3282 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3283 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3284 spu-multiarch.c, and spu-tdep.c.
3285 * spu-linux-nat.c: Remove file.
3286 * spu-multiarch.c: Remove file.
3287 * spu-tdep.c: Remove file.
3288 * spu-tdep.h: Remove file.
3289 * solib-spu.c: Remove file.
3290 * solib-spu.h: Remove file.
3291
3292 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3293 * configure.nat (spu-linux): Remove.
3294 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3295 solib-multiarch.o from gdb_target_obs.
3296 (spu*-*-*): Remove.
3297
3298 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3299 feature flag.
3300 (ppc_linux_no_features): Update.
3301 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3302 Cell/B.E. support.
3303 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3304 (tdesc_powerpc_cell64l): Likewise.
3305 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3306 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3307 Cell/B.E. support.
3308 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3309 Do not include "features/rs6000/powerpc-cell32l.c" or
3310 "features/rs6000/powerpc-cell64l.c".
3311 (ppc_linux_spu_section): Remove.
3312 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3313 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3314 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3315 (ppc_linux_spe_context_lookup): Remove.
3316 (ppc_linux_spe_context_inferior_created): Remove.
3317 (ppc_linux_spe_context_solib_loaded): Remove.
3318 (ppc_linux_spe_context_solib_unloaded): Remove.
3319 (ppc_linux_spe_context): Remove.
3320 (struct ppu2spu_cache): Remove.
3321 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3322 (struct ppu2spu_data): Remove.
3323 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3324 ppu2spu_unwind): Remove.
3325 (ppc_linux_init_abi): Remove Cell/B.E. support.
3326 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3327
3328 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3329 (rs6000/powerpc-cell64l-expedite): Likewise
3330 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3331 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3332 rs6000/powerpc-cell64l.xml.
3333 * features/rs6000/powerpc-cell32l.xml: Remove.
3334 * features/rs6000/powerpc-cell64l.xml: Likewise.
3335 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3336 * features/rs6000/powerpc-cell64l.c: Likewise.
3337 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3338 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3339 * regformats/reg-spu.dat: Remove.
3340
3341 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3342 * corelow.c (struct spuid_list): Remove.
3343 (add_to_spuid_list): Remove.
3344 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3345 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3346 (remote_protocol_features): Remove associated entries.
3347 (_initialize_remote): No longer initialize them.
3348 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3349 * linux-nat.c (SPUFS_MAGIC): Remove.
3350 (linux_proc_xfer_spu): Remove.
3351 (spu_enumerate_spu_ids): Remove.
3352 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3353 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3354 (linux_make_corefile_notes): No longer call it.
3355
3356 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3357 (cooked_write_test): Likewise.
3358
3359 2019-09-20 Tom Tromey <tom@tromey.com>
3360
3361 * NEWS: Mention case-sensitivity of TUI commands.
3362 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3363 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3364 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3365
3366 2019-09-20 Tom Tromey <tom@tromey.com>
3367
3368 * tui/tui-source.c (tui_source_window::set_contents): Use
3369 make_unique_xstrdup.
3370 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3371 make_unique_xstrdup.
3372
3373 2019-09-20 Tom Tromey <tom@tromey.com>
3374
3375 * tui/tui-data.c: Remove separator comments.
3376 * tui/tui-layout.c: Remove separator comments.
3377 * tui/tui-win.c: Remove separator comments.
3378 * tui/tui-wingeneral.c: Remove separator comments.
3379
3380 2019-09-20 Tom Tromey <tom@tromey.com>
3381
3382 * tui/tui.h (strcat_to_buf): Don't declare.
3383 * tui/tui.c (strcat_to_buf): Remove.
3384
3385 2019-09-20 Tom Tromey <tom@tromey.com>
3386
3387 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3388 from "fullname".
3389 * tui/tui-source.c (tui_source_window::set_contents)
3390 (tui_source_window::location_matches_p)
3391 (tui_source_window::maybe_update): Update.
3392
3393 2019-09-20 Tom Tromey <tom@tromey.com>
3394
3395 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3396 Update.
3397 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3398 prefix.
3399 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3400 (tui_data_window::line_from_reg_element_no)
3401 (tui_data_window::first_reg_element_no_inline)
3402 (tui_data_window::show_registers)
3403 (tui_data_window::show_register_group)
3404 (tui_data_window::display_registers_from)
3405 (tui_data_window::display_registers_from_line)
3406 (tui_data_window::first_data_item_displayed)
3407 (tui_data_window::delete_data_content_windows)
3408 (tui_data_window::erase_data_content)
3409 (tui_data_window::do_scroll_vertical)
3410 (tui_data_window::refresh_window)
3411 (tui_data_window::check_register_values): Update.
3412
3413 2019-09-20 Tom Tromey <tom@tromey.com>
3414
3415 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3416 (struct tui_locator_window) <full_name, proc_name>: Now
3417 std::string.
3418 * tui/tui-stack.c (tui_locator_window::make_status_line)
3419 (tui_locator_window::set_locator_fullname)
3420 (tui_locator_window::set_locator_info): Update.
3421 * tui/tui-source.c (tui_source_window::set_contents)
3422 (tui_source_window::showing_source_p): Update.
3423
3424 2019-09-20 Tom Tromey <tom@tromey.com>
3425
3426 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3427 Don't call tui_locator_win_info_ptr.
3428
3429 2019-09-20 Tom Tromey <tom@tromey.com>
3430
3431 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3432
3433 2019-09-20 Tom Tromey <tom@tromey.com>
3434
3435 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3436 height for locator.
3437 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3438 * tui/tui-layout.c (show_source_disasm_command, show_data)
3439 (show_source_or_disasm_and_command): Use 1 as height for locator.
3440
3441 2019-09-20 Tom Tromey <tom@tromey.com>
3442
3443 * tui/tui.c (tui_enable): Update.
3444 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3445 Update.
3446 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3447 Update.
3448 * tui/tui-data.c (win_resized): Now bool.
3449 (tui_win_resized): Return bool.
3450 (tui_set_win_resized_to): Accept a bool.
3451
3452 2019-09-20 Tom Tromey <tom@tromey.com>
3453
3454 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3455 Change type of "refresh_values_only".
3456 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3457 type of "refresh_values_only".
3458
3459 2019-09-20 Tom Tromey <tom@tromey.com>
3460
3461 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3462 std::string.
3463 (tui_disassemble): Add "pos" parameter.
3464 (tui_disasm_window::set_contents): Simplify.
3465
3466 2019-09-20 Tom Tromey <tom@tromey.com>
3467
3468 * tui/tui-winsource.h (struct tui_source_window_base)
3469 <show_source_content>: Now private.
3470 * tui/tui-winsource.c
3471 (tui_source_window_base::show_source_content): Don't handle empty
3472 content case.
3473
3474 2019-09-20 Tom Tromey <tom@tromey.com>
3475
3476 * tui/tui-layout.c (show_source_disasm_command)
3477 (show_source_or_disasm_and_command): Don't call
3478 show_source_content.
3479
3480 2019-09-20 Tom Tromey <tom@tromey.com>
3481
3482 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3483 Declare.
3484 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3485 from tui_make_status_line.
3486 (tui_locator_window::rerender): Update.
3487
3488 2019-09-20 Tom Tromey <tom@tromey.com>
3489
3490 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3491 (tui_locator_window::rerender): Update.
3492
3493 2019-09-20 Tom Tromey <tom@tromey.com>
3494
3495 * tui/tui-winsource.h (struct tui_source_window_base)
3496 <~tui_source_window_base>: Don't declare.
3497 <fullname>: Remove.
3498 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3499 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3500 member.
3501 * tui/tui-source.c (tui_source_window::set_contents): Update.
3502 (tui_source_window::location_matches_p)
3503 (tui_source_window::maybe_update): Update.
3504
3505 2019-09-20 Tom Tromey <tom@tromey.com>
3506
3507 * tui/tui-winsource.h (~tui_source_element): Remove.
3508 (tui_source_element): Update.
3509 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3510 * tui/tui-winsource.c (tui_show_source_line): Update.
3511 * tui/tui-source.c (tui_source_window::set_contents): Update.
3512 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3513
3514 2019-09-20 Tom Tromey <tom@tromey.com>
3515
3516 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3517 declare.
3518 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3519 tui_clear_source_windows_detail.
3520 * tui/tui-winsource.h (struct tui_source_window_base)
3521 <clear_detail>: Don't declare.
3522 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3523 Remove.
3524 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3525
3526 2019-09-20 Tom Tromey <tromey@adacore.com>
3527
3528 PR ada/24919:
3529 * block.c (contained_in): Fix final return value.
3530
3531 2019-09-20 Alan Modra <amodra@gmail.com>
3532
3533 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3534 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3535 (read_indirect_string_from_dwz): Use bfd accessor.
3536 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3537 * machoread.c (macho_symfile_read_all_oso): Likewise.
3538 * solib.c (solib_bfd_open): Likewise.
3539
3540 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3541
3542 * eval.c: Move declaration of overload_resolution to...
3543 * value.h: ...here.
3544
3545 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3546
3547 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3548 * arm-linux-tdep.c: Likewise.
3549 * arm-nbsd-nat.c: Likewise.
3550 * arm-tdep.h: Declare arm_apcs_32.
3551 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3552
3553 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3554
3555 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3556 * dwarf2read.h: Declare dwarf_always_disassemble.
3557
3558 2019-09-19 Tom de Vries <tdevries@suse.de>
3559
3560 PR gdb/25009
3561 * source-cache.c (source_cache::ensure): Catch exception thrown during
3562 construction of the highlighter.
3563
3564 2019-09-18 Alan Modra <amodra@gmail.com>
3565
3566 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3567 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3568 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3569 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3570 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3571 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3572 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3573 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3574 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3575 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3576 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3577 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3578 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3579 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3580 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3581 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3582 * mi/mi-interp.c: Update throughout for bfd section macro and
3583 function changes.
3584 * gcore (gcore_create_callback): Use bfd_set_section_lma.
3585 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3586
3587 2019-09-18 Tom Tromey <tom@tromey.com>
3588
3589 * NEWS: Add entry.
3590 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
3591 call rl_initialize.
3592 (tui_enable): Do not call rl_initialize.
3593
3594 2019-09-18 Christian Groessler <chris@groessler.org>
3595
3596 * alpha-linux-nat.c: Include gdbarch.h.
3597
3598 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
3599
3600 * ui-file.c: Include cli/cli-style.h.
3601 (term_cli_styling): Remove cli_styling declaration.
3602
3603 2019-09-18 Alan Modra <amodra@gmail.com>
3604
3605 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3606 to bfd_asymbol_section.
3607
3608 2019-09-18 Alan Modra <amodra@gmail.com>
3609
3610 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3611 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3612 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3613
3614 2019-09-18 Alan Modra <amodra@gmail.com>
3615
3616 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3617 * spu-linux-nat.c (spu_bfd_open): Likewise.
3618
3619 2019-09-18 Christian Biesinger <cbiesinger@google.com>
3620
3621 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3622 to bool to match definition in dwarf2read.c.
3623
3624 2019-09-17 Christian Biesinger <cbiesinger@google.com>
3625
3626 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3627 (print_signatures): Likewise.
3628 (trust_pad_over_xvs): Likewise.
3629 * arch/aarch64-insn.c (aarch64_debug): Likewise.
3630 * arch/aarch64-insn.h (aarch64_debug): Likewise.
3631 * arm-linux-nat.c (arm_apcs_32): Likewise.
3632 * arm-linux-tdep.c (arm_apcs_32): Likewise.
3633 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3634 * arm-tdep.c (arm_debug): Likewise.
3635 (arm_apcs_32): Likewise.
3636 * auto-load.c (debug_auto_load): Likewise.
3637 (auto_load_gdb_scripts): Likewise.
3638 (global_auto_load): Likewise.
3639 (auto_load_local_gdbinit): Likewise.
3640 (auto_load_local_gdbinit_loaded): Likewise.
3641 * auto-load.h (global_auto_load): Likewise.
3642 (auto_load_local_gdbinit): Likewise.
3643 (auto_load_local_gdbinit_loaded): Likewise.
3644 * breakpoint.c (disconnected_dprintf): Likewise.
3645 (breakpoint_proceeded): Likewise.
3646 (automatic_hardware_breakpoints): Likewise.
3647 (always_inserted_mode): Likewise.
3648 (target_exact_watchpoints): Likewise.
3649 (_initialize_breakpoint): Update.
3650 * breakpoint.h (target_exact_watchpoints): Change to bool.
3651 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3652 * cli/cli-cmds.c (trace_commands): Likewise.
3653 * cli/cli-cmds.h (trace_commands): Likewise.
3654 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3655 to bool*.
3656 * cli/cli-logging.c (logging_overwrite): Change to bool.
3657 (logging_redirect): Likewise.
3658 (debug_redirect): Likewise.
3659 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3660 (struct boolean_option_def) <get_var_address_cb_>: Change return type
3661 to bool.
3662 <boolean_option_def>: Update.
3663 (struct flag_option_def): Change default type of Context to bool
3664 from int.
3665 <flag_option_def>: Change return type of var_address_cb_ to bool*.
3666 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3667 (get_setshow_command_value_string): Likewise.
3668 * cli/cli-style.c (cli_styling): Change to bool.
3669 (source_styling): Likewise.
3670 * cli/cli-style.h (source_styling): Likewise.
3671 (cli_styling): Likewise.
3672 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3673 to bool.
3674 * command.h (var_types): Update comment.
3675 (add_setshow_boolean_cmd): Change int* var argument to bool*.
3676 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3677 bool.
3678 (debug_compile_cplus_scopes): Likewise.
3679 * compile/compile-internal.h (compile_debug): Likewise.
3680 * compile/compile.c (compile_debug): Likewise.
3681 (struct compile_options) <raw>: Likewise.
3682 * cp-support.c (catch_demangler_crashes): Likewise.
3683 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3684 (usr_cmd_cris_dwarf2_cfi): Likewise.
3685 * csky-tdep.c (csky_debug): Likewise.
3686 * darwin-nat.c (enable_mach_exceptions): Likewise.
3687 * dcache.c (dcache_enabled_p): Likewise.
3688 * defs.h (info_verbose): Likewise.
3689 * demangle.c (demangle): Likewise.
3690 (asm_demangle): Likewise.
3691 * dwarf-index-cache.c (debug_index_cache): Likewise.
3692 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3693 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3694 * dwarf2read.c (check_physname): Likewise.
3695 (use_deprecated_index_sections): Likewise.
3696 (dwarf_always_disassemble): Likewise.
3697 * eval.c (overload_resolution): Likewise.
3698 * event-top.c (set_editing_cmd_var): Likewise.
3699 (exec_done_display_p): Likewise.
3700 * event-top.h (set_editing_cmd_var): Likewise.
3701 (exec_done_display_p): Likewise.
3702 * exec.c (write_files): Likewise.
3703 * fbsd-nat.c (debug_fbsd_lwp): Likewise
3704 (debug_fbsd_nat): Likewise.
3705 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3706 Likewise.
3707 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3708 <backtrace_past_entry> Likewise.
3709 * gdb-demangle.h (demangle): Likewise.
3710 (asm_demangle): Likewise.
3711 * gdb_bfd.c (bfd_sharing): Likewise.
3712 * gdbcore.h (write_files): Likewise.
3713 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3714 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3715 * gdbthread.h (print_thread_events): Likewise.
3716 * gdbtypes.c (opaque_type_resolution): Likewise.
3717 (strict_type_checking): Likewise.
3718 * gnu-nat.c (gnu_debug_flag): Likewise.
3719 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3720 * guile/scm-param.c (pascm_variable): Add boolval.
3721 (add_setshow_generic): Update.
3722 (pascm_param_value): Update.
3723 (pascm_set_param_value_x): Update.
3724 * hppa-tdep.c (hppa_debug): Change to bool..
3725 * infcall.c (may_call_functions_p): Likewise.
3726 (coerce_float_to_double_p): Likewise.
3727 (unwind_on_signal_p): Likewise.
3728 (unwind_on_terminating_exception_p): Likewise.
3729 * infcmd.c (startup_with_shell): Likewise.
3730 * inferior.c (print_inferior_events): Likewise.
3731 * inferior.h (startup_with_shell): Likewise.
3732 (print_inferior_events): Likewise.
3733 * infrun.c (step_stop_if_no_debug): Likewise.
3734 (detach_fork): Likewise.
3735 (debug_displaced): Likewise.
3736 (disable_randomization): Likewise.
3737 (non_stop): Likewise.
3738 (non_stop_1): Likewise.
3739 (observer_mode): Likewise.
3740 (observer_mode_1): Likewise.
3741 (set_observer_mode): Update.
3742 (sched_multi): Change to bool.
3743 * infrun.h (debug_displaced): Likewise.
3744 (sched_multi): Likewise.
3745 (step_stop_if_no_debug): Likewise.
3746 (non_stop): Likewise.
3747 (disable_randomization): Likewise.
3748 * linux-tdep.c (use_coredump_filter): Likewise.
3749 (dump_excluded_mappings): Likewise.
3750 * linux-thread-db.c (auto_load_thread_db): Likewise.
3751 (check_thread_db_on_load): Likewise.
3752 * main.c (captured_main_1): Update.
3753 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3754 xx2_opt, boolean_opt>: Change to bool.
3755 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3756 * maint.c (maintenance_profile_p): Likewise.
3757 (per_command_time): Likewise.
3758 (per_command_space): Likewise.
3759 (per_command_symtab): Likewise.
3760 * memattr.c (inaccessible_by_default): Likewise.
3761 * mi/mi-main.c (mi_async): Likewise.
3762 (mi_async_1): Likewise.
3763 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3764 * nat/fork-inferior.h (startup_with_shell): Likewise.
3765 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3766 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3767 * nios2-tdep.c (nios2_debug): Likewise.
3768 * or1k-tdep.c (or1k_debug): Likewise.
3769 * parse.c (parser_debug): Likewise.
3770 * parser-defs.h (parser_debug): Likewise.
3771 * printcmd.c (print_symbol_filename): Likewise.
3772 * proc-api.c (procfs_trace): Likewise.
3773 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3774 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3775 (set_parameter_value): Update.
3776 (add_setshow_generic): Update.
3777 * python/py-value.c (copy_py_bool_obj): Change argument from int*
3778 to bool*.
3779 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3780 int*.
3781 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3782 * record-btrace.c (record_btrace_target::store_registers): Update.
3783 * record-full.c (record_full_memory_query): Change to bool.
3784 (record_full_stop_at_limit): Likewise.
3785 * record-full.h (record_full_memory_query): Likewise.
3786 * remote-notif.c (notif_debug): Likewise.
3787 * remote-notif.h (notif_debug): Likewise.
3788 * remote.c (use_range_stepping): Likewise.
3789 (interrupt_on_connect): Likewise.
3790 (remote_break): Likewise.
3791 * ser-tcp.c (tcp_auto_retry): Likewise.
3792 * ser-unix.c (serial_hwflow): Likewise.
3793 * skip.c (debug_skip): Likewise.
3794 * solib-aix.c (solib_aix_debug): Likewise.
3795 * spu-tdep.c (spu_stop_on_load_p): Likewise.
3796 (spu_auto_flush_cache_p): Likewise.
3797 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3798 Likewise.
3799 (struct info_print_options) <quiet>: Likewise.
3800 * symfile-debug.c (debug_symfile): Likewise.
3801 * symfile.c (auto_solib_add): Likewise.
3802 (separate_debug_file_debug): Likewise.
3803 * symfile.h (auto_solib_add): Likewise.
3804 (separate_debug_file_debug): Likewise.
3805 * symtab.c (basenames_may_differ): Likewise.
3806 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3807 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3808 (struct info_types_options) <quiet>: Likewise.
3809 * symtab.h (demangle): Likewise.
3810 (basenames_may_differ): Likewise.
3811 * target-dcache.c (stack_cache_enabled_1): Likewise.
3812 (code_cache_enabled_1): Likewise.
3813 * target.c (trust_readonly): Likewise.
3814 (may_write_registers): Likewise.
3815 (may_write_memory): Likewise.
3816 (may_insert_breakpoints): Likewise.
3817 (may_insert_tracepoints): Likewise.
3818 (may_insert_fast_tracepoints): Likewise.
3819 (may_stop): Likewise.
3820 (auto_connect_native_target): Likewise.
3821 (target_stop_and_wait): Update.
3822 (target_async_permitted): Change to bool.
3823 (target_async_permitted_1): Likewise.
3824 (may_write_registers_1): Likewise.
3825 (may_write_memory_1): Likewise.
3826 (may_insert_breakpoints_1): Likewise.
3827 (may_insert_tracepoints_1): Likewise.
3828 (may_insert_fast_tracepoints_1): Likewise.
3829 (may_stop_1): Likewise.
3830 * target.h (target_async_permitted): Likewise.
3831 (may_write_registers): Likewise.
3832 (may_write_memory): Likewise.
3833 (may_insert_breakpoints): Likewise.
3834 (may_insert_tracepoints): Likewise.
3835 (may_insert_fast_tracepoints): Likewise.
3836 (may_stop): Likewise.
3837 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
3838 (make_thread_apply_all_options_def_group): Change argument from int*
3839 to bool*.
3840 (thread_apply_all_command): Update.
3841 (print_thread_events): Change to bool.
3842 * top.c (confirm): Likewise.
3843 (command_editing_p): Likewise.
3844 (history_expansion_p): Likewise.
3845 (write_history_p): Likewise.
3846 (info_verbose): Likewise.
3847 * top.h (confirm): Likewise.
3848 (history_expansion_p): Likewise.
3849 * tracepoint.c (disconnected_tracing): Likewise.
3850 (circular_trace_buffer): Likewise.
3851 * typeprint.c (print_methods): Likewise.
3852 (print_typedefs): Likewise.
3853 * utils.c (debug_timestamp): Likewise.
3854 (sevenbit_strings): Likewise.
3855 (pagination_enabled): Likewise.
3856 * utils.h (sevenbit_strings): Likewise.
3857 (pagination_enabled): Likewise.
3858 * valops.c (overload_resolution): Likewise.
3859 * valprint.h (struct value_print_options) <prettyformat_arrays,
3860 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
3861 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
3862 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
3863 Likewise.
3864 * windows-nat.c (new_console): Likewise.
3865 (cygwin_exceptions): Likewise.
3866 (new_group): Likewise.
3867 (debug_exec): Likewise.
3868 (debug_events): Likewise.
3869 (debug_memory): Likewise.
3870 (debug_exceptions): Likewise.
3871 (useshell): Likewise.
3872 * windows-tdep.c (maint_display_all_tib): Likewise.
3873 * xml-support.c (debug_xml): Likewise.
3874
3875 2019-09-17 Mike Gulick <mgulick@mathworks.com>
3876
3877 * source.c (prepare_path_for_appending): New function.
3878 (openp): Make use of new function.
3879 (find_and_open_source): Search for the compilation directory and
3880 source file as a relative path beneath the directory search path.
3881
3882 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
3883
3884 * source-cache.c (source_cache::get_line_charpos): Catch
3885 exceptions and return false, this matches the behaviour documented
3886 in the header file.
3887
3888 2019-09-17 Joel Brobecker <brobecker@adacore.com>
3889
3890 * ada-tasks.c (info_task): Remove quoting of the task's name.
3891
3892 2019-09-16 Christian Biesinger <cbiesinger@google.com>
3893
3894 * symfile.c (auto_solib_add): Replace comment with a reference
3895 to the header file.
3896
3897 2019-09-14 Christian Biesinger <cbiesinger@google.com>
3898
3899 * NEWS: Mention that gdb can now be compiled with Python 3
3900 on Windows.
3901
3902 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
3903
3904 * maint.c (maint_print_section_data::maint_print_section_data):
3905 Force use of 'float log10 (float)' by casting the argument to
3906 float.
3907
3908 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
3909
3910 * maint.c: Add 'cmath' include.
3911 (struct maint_print_section_data): New structure.
3912 (print_section_index): New function.
3913 (print_bfd_section_info): Add header comment, small whitespace
3914 cleanup, and update to call new print_section_index function.
3915 (print_objfile_section_info): Likewise.
3916 (maint_obj_section_from_bfd_section): New function.
3917 (print_bfd_section_info_maybe_relocated): New function.
3918 (maintenance_info_sections): Add header comment, always use
3919 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
3920
3921 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
3922
3923 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
3924 inner scope, add check that the objfile has psymtabs before
3925 checking psymtabs_addrmap.
3926 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
3927
3928 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3929
3930 * NEWS: Announce that Ada task names are now shown at more places,
3931 and between quotes (except in info task output).
3932 * gdb/ada-tasks.c (task_to_str): New function.
3933 (display_current_task_id): Call task_to_str.
3934 (task_command_1): Likewise.
3935 (print_ada_task_info): In non-mi mode, Properly align headers and data
3936 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
3937
3938 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
3939
3940 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
3941 prstatus.pr_lwp.pr_info instead of making it up.
3942
3943 2019-09-11 Christian Biesinger <cbiesinger@google.com>
3944
3945 * auto-load.c (auto_load_expand_dir_vars): Update.
3946 * defs.h (gdb_datadir): Change to std::string.
3947 (python_libdir): Likewise.
3948 (relocate_gdb_directory): Change return type to std::string.
3949 * guile/guile.c (gdbscm_data_directory): Update.
3950 (initialize_scheme_side): Update.
3951 * jit.c (jit_reader_dir): Change to std::string.
3952 (jit_reader_load_command): Update.
3953 * main.c (gdb_datadir): Change to std::string.
3954 (python_libdir): Likewise.
3955 (set_gdb_data_directory): Update.
3956 (relocate_path): Change to return std::string.
3957 (relocate_gdb_directory): Change to return std::string.
3958 (relocate_gdbinit_path_maybe_in_datadir): Update.
3959 (captured_main_1): Update.
3960 * python/python.c (do_start_initialization): Update.
3961 * top.c (show_gdb_datadir): Update.
3962 * xml-syscall.c (xml_init_syscalls_info): Update.
3963 (init_syscalls_info): Update.
3964
3965 2019-09-11 Christian Biesinger <cbiesinger@google.com>
3966
3967 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
3968 out of get_init_files.
3969 (get_init_files): Update.
3970
3971 2019-09-11 Christian Biesinger <cbiesinger@google.com>
3972
3973 * main.c (get_init_files): Change to use std::string.
3974 (captured_main_1): Update.
3975 (print_gdb_help): Update.
3976
3977 2019-09-11 Ali Tamur <tamur@google.com>
3978
3979 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
3980 implementation.
3981
3982 2019-09-11 Christian Biesinger <cbiesinger@google.com>
3983
3984 * dbxread.c (read_dbx_symtab): Update.
3985 * dwarf2read.c (load_partial_dies): Update.
3986 * mdebugread.c (parse_partial_symbols): Update.
3987 (handle_psymbol_enumerators): Update.
3988 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
3989 * psymtab.c (add_psymbol_to_bcache): Likewise.
3990 (add_psymbol_to_list): Likewise.
3991 * symtab.c (symbol_set_names): Likewise.
3992 * symtab.h (symbol_set_names): Likewise.
3993 * xcoffread.c (scan_xcoff_symtab): Update.
3994
3995 2019-09-11 Tom Tromey <tom@tromey.com>
3996
3997 * symfile-mem.c (symbol_file_add_from_memory): Use
3998 bfd_set_filename.
3999 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4000 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4001
4002 2019-09-10 Tom Tromey <tromey@adacore.com>
4003
4004 * dwarf-index-write.c (write_psymbols): Extend error message.
4005 (debug_names::insert): Add Ada code.
4006 (debug_names::write_psymbols): Remove Ada check.
4007 (debug_names) <m_string_obstack>: New member.
4008 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4009 (gdb_index_symbol_name_matcher::matches): Remove.
4010 (mapped_index_base::find_name_components_bounds): Add "lang"
4011 parameter.
4012 (mapped_index_base::build_name_components): Also split names
4013 according to Ada syntax.
4014 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4015 type of "match_callback".
4016 (check_match, check_find_bounds_finds)
4017 (dw2_expand_symtabs_matching): Update.
4018 (dw2_debug_names_iterator): Add new constructor.
4019 (dw2_debug_names_map_matching_symbols): New function.
4020 (dw2_debug_names_expand_symtabs_matching): Update.
4021 (dwarf2_debug_names_functions): Use
4022 dw2_debug_names_map_matching_symbols.
4023
4024 2019-09-10 Tom Tromey <tromey@adacore.com>
4025
4026 * dwarf2read.c (dw2_get_file_names_reader): Add the
4027 CU's file name to the results.
4028
4029 2019-09-10 Tom Tromey <tromey@adacore.com>
4030
4031 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4032 map_matching_symbols. Update.
4033 * dwarf2read.c (dw2_map_matching_symbols): Update.
4034 * psymtab.c (match_partial_symbol): Change type; update.
4035 (psym_map_matching_symbols): Likewise.
4036 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4037 type; update.
4038 * symfile.h (struct quick_symbol_functions)
4039 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4040 Remove "match".
4041
4042 2019-09-10 Tom Tromey <tromey@adacore.com>
4043
4044 * psymtab.c (map_block): Remove.
4045 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4046 * symtab.c (iterate_over_symbols_terminated): New function.
4047 * symtab.c (iterate_over_symbols_terminated): Declare.
4048
4049 2019-09-10 Tom Tromey <tromey@adacore.com>
4050
4051 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4052 * language.h (struct language_defn) <la_iterate_over_symbols>:
4053 Return bool.
4054 * symtab.c (iterate_over_symbols): Return bool.
4055 * symtab.h (iterate_over_symbols): Return bool.
4056
4057 2019-09-10 Tom Tromey <tromey@adacore.com>
4058
4059 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4060 (add_nonlocal_symbols): Update.
4061 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4062 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4063 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4064 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4065 Change type of "callback". Remove "data".
4066
4067
4068 2019-09-09 Ali Tamur <tamur@google.com>
4069
4070 * dwarf2read.c (comp_unit_head): Update comment.
4071 (dwarf2_dwo_name): New function declaration.
4072 (dwarf_unit_type_name): New function declaration.
4073 (read_comp_unit_head): Add support for new compilation units,
4074 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4075 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4076 (currently named as "signature") in their header. Also clarify error
4077 messages.
4078 (lookup_dwo_id): New function. Returns the dwo id of the given
4079 compile unit.
4080 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4081 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4082 functions.
4083 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4084 (dwarf2_dwo_name): Get the dwo name if present.
4085 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4086 purposes.
4087
4088 2019-09-09 Tom Tromey <tom@tromey.com>
4089
4090 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4091
4092 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4093
4094 * python/python.c (do_start_initialization): Make progname_copy static,
4095 to avoid a leak report.
4096
4097 2019-09-08 Tom Tromey <tom@tromey.com>
4098
4099 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4100
4101 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
4102
4103 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4104 Change type to gdb::optional<block_enum>.
4105 (dw2_symtab_iter_init): Change block_index parameter type
4106 to gdb::optional<block_enum>.
4107 (dw2_lookup_symbol): Change block_index parameter
4108 type to block_enum.c
4109 (dw2_debug_names_lookup_symbol): Likewise.
4110 * psymtab.c (psym_lookup_symbol): Likewise.
4111 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4112 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4113 Likewise.
4114
4115 2019-09-06 Christian Biesinger <cbiesinger@google.com>
4116
4117 * defs.h (relocate_gdb_directory): Change int to bool in
4118 signature and rename flag to relocatable.
4119 * main.c (relocate_path): Likewise.
4120 (relocate_gdb_directory): Likewise.
4121
4122 2019-09-06 Alan Modra <amodra@gmail.com>
4123
4124 * coffread.c (coff_symfile_read): Constify filename variable.
4125 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4126 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4127 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4128 * solib.c (reload_shared_libraries_1): Likewise.
4129 * symfile.c (reread_symbols): Likewise.
4130 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4131 * solib-darwin.c (darwin_bfd_open): Likewise.
4132 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4133
4134 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4135
4136 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4137 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4138
4139 2019-09-03 Tom Tromey <tromey@adacore.com>
4140
4141 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4142 types.
4143 (has_negatives): Unbias a range type bound.
4144 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4145 * gdbtypes.c (operator==): Handle new field.
4146 (create_range_type): Add "bias" parameter.
4147 (create_static_range_type, resolve_dynamic_range): Update.
4148 * gdbtypes.h (struct range_bounds) <bias>: New member.
4149 (create_range_type): Add bias parameter.
4150 * printcmd.c (print_scalar_formatted): Unbias range types.
4151 * value.c (unpack_long): Unbias range types.
4152 (pack_long): Bias range types.
4153
4154 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4155
4156 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4157 probe arguments.
4158
4159 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4160
4161 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4162 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4163 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4164 (compile_probe_arg): Likewise.
4165 * probe.h (get_argument_count): Likewise.
4166 * solib-svr4.c (solib_event_probe_action): Likewise.
4167 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4168
4169 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4170
4171 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4172 code to here...
4173 (svr4_create_solib_event_breakpoints): ...from here.
4174
4175 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4176
4177 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4178 suffix from warning message.
4179
4180 2019-08-30 Tom Tromey <tom@tromey.com>
4181
4182 * tui/tui-winsource.h (struct tui_source_window_base)
4183 <refresh_all>: Don't declare.
4184 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4185 Remove.
4186 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4187 tui_show_locator_content.
4188 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4189 declare.
4190 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4191 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4192 declare.
4193
4194 2019-08-30 Tom Tromey <tom@tromey.com>
4195
4196 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4197
4198 2019-08-30 Tom Tromey <tom@tromey.com>
4199
4200 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4201 Remove unnecessary forward declarations.
4202
4203 2019-08-30 Tom Tromey <tom@tromey.com>
4204
4205 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4206 rerender.
4207 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4208 tui_show_locator_content.
4209
4210 2019-08-30 Tom Tromey <tom@tromey.com>
4211
4212 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4213 (tui_locator_window::rerender): Rewrite using body of previous
4214 tui_show_locator_content.
4215
4216 2019-08-30 Tom Tromey <tom@tromey.com>
4217
4218 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4219 set_locator_fullname>: New methods.
4220 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4221 Rename from tui_set_locator_fullname.
4222 (tui_locator_window::set_locator_info): Rename from
4223 tui_set_locator_info. Return bool.
4224 (tui_update_locator_fullname, tui_show_frame_info): Update.
4225
4226 2019-08-30 Tom Tromey <tom@tromey.com>
4227
4228 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4229
4230 2019-08-30 Tom Tromey <tom@tromey.com>
4231
4232 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4233 call touchwin.
4234
4235 2019-08-30 Tom Tromey <tom@tromey.com>
4236
4237 * tui/tui-wingeneral.c (box_win): Assume win_info and
4238 win_info->handle cannot be NULL.
4239
4240 2019-08-30 Tom Tromey <tom@tromey.com>
4241
4242 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4243 refresh_window>: Declare.
4244 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4245 resize.
4246 (tui_data_item_window::rerender): Rename from
4247 tui_display_register.
4248 (tui_data_item_window::refresh_window): New method.
4249 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4250 no-op.
4251
4252 2019-08-30 Tom Tromey <tom@tromey.com>
4253
4254 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4255 regs_column_count, current_group>: Move later. Now private.
4256 <get_current_group>: New method.
4257 * tui/tui-regs.c (tui_reg_command): Update.
4258 * tui/tui-layout.c (tui_set_layout): Update.
4259
4260 2019-08-30 Tom Tromey <tom@tromey.com>
4261
4262 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4263 (tui_data_window::rerender): Don't call
4264 check_and_display_highlight_if_needed.
4265 (tui_data_window::refresh_all): Remove call to
4266 erase_data_content.
4267
4268 2019-08-30 Tom Tromey <tom@tromey.com>
4269
4270 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4271 (tui_data_window::display_registers_from)
4272 (tui_data_window::display_reg_element_at_line)
4273 (tui_data_window::display_registers_from_line): Remove checks of
4274 "empty".
4275
4276 2019-08-30 Tom Tromey <tom@tromey.com>
4277
4278 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4279 Don't declare.
4280 * tui/tui-regs.c (tui_data_window::show_registers): Call
4281 rerender.
4282 (tui_data_window::rerender): Rename from display_all_data.
4283 (tui_data_window::rerender): Remove old implementation.
4284
4285 2019-08-30 Tom Tromey <tom@tromey.com>
4286
4287 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4288 text.
4289 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4290
4291 2019-08-29 Bernhard Wodok <barto@gmx.net>
4292 Sergio Durigan Junior <sergiodj@redhat.com>
4293
4294 PR win32/24284
4295 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4296
4297 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4298
4299 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4300 when searching for types.
4301
4302 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4303
4304 * f-lang.c (f_language_defn): Use f_print_typedef.
4305 * f-lang.h (f_print_typedef): Declare.
4306 * f-typeprint.c (f_print_typedef): Define.
4307
4308 2019-08-27 Christian Biesinger <cbiesinger@google.com>
4309
4310 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4311
4312 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4313
4314 * cli/cli-utils.c (info_print_options_defs): Delete.
4315 (make_info_print_options_def_group): Delete.
4316 (extract_info_print_options): Delete.
4317 (info_print_command_completer): Delete.
4318 (info_print_args_help): Add extra parameter, and optionally
4319 include text about -n flag.
4320 * cli/cli-utils.h (struct info_print_options): Delete.
4321 (extract_info_print_options): Delete declaration.
4322 (info_print_command_completer): Delete declaration.
4323 (info_print_args_help): Add extra parameter, extend header
4324 comment.
4325 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4326 search_symbols.
4327 * stack.c (struct info_print_options): New type.
4328 (info_print_options_defs): New file scoped variable.
4329 (make_info_print_options_def_group): New static function.
4330 (info_print_command_completer): New static function.
4331 (info_locals_command): Update to use new local functions.
4332 (info_args_command): Likewise.
4333 (_initialize_stack): Add extra parameter to calls to
4334 info_print_args_help.
4335 * symtab.c (search_symbols): Add extra parameter, use this to
4336 possibly excluse non-debug symbols.
4337 (symtab_symbol_info): Add extra parameter, which is passed on to
4338 search_symbols.
4339 (struct info_print_options): New type.
4340 (info_print_options_defs): New file scoped variable.
4341 (make_info_print_options_def_group): New static function.
4342 (info_print_command_completer): New static function.
4343 (info_variables_command): Update to use local functions, and pass
4344 extra parameter through to symtab_symbol_info.
4345 (info_functions_command): Likewise.
4346 (info_types_command): Pass additional argument through to
4347 symtab_symbol_info.
4348 (rbreak_command): Pass extra argument to search_symbols.
4349 (_initialize_symtab): Add extra arguments for calls to
4350 info_print_args_help, and update help text for 'info variables',
4351 'whereis', and 'info functions' commands.
4352 * symtab.h (search_symbols): Add extra argument to declaration.
4353 * NEWS: Mention new flags.
4354
4355 2019-08-26 Christian Biesinger <cbiesinger@google.com>
4356
4357 * symtab.c (lookup_static_symbol): Call the new function (and move
4358 it down to be next to lookup_global_symbol).
4359 (struct global_sym_lookup_data): Add block_enum member and rename to...
4360 (struct global_or_static_sym_lookup_data): ...this.
4361 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4362 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4363 (lookup_symbol_global_or_static_iterator_cb): ...this.
4364 (lookup_global_or_static_symbol): New function.
4365 (lookup_global_symbol): Call new function.
4366
4367 2019-08-26 Tom de Vries <tdevries@suse.de>
4368
4369 PR c++/24852
4370 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4371 when pc_probe.prob == NULL.
4372
4373 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4374
4375 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4376 variable symbol_linkage to symbol_linkage_.
4377
4378 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4379
4380 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4381 represent whether the symbol is static, dynamic, or we don't
4382 know.
4383
4384 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4385
4386 * gdb/rx-tdep.c (rx_register_names): New.
4387 (rx_register_name): Delete.
4388 (rx_psw_type): Delete.
4389 (rx_fpsw_type): Delete.
4390 (rx_register_type): Delete.
4391 (rx_gdbarch_init): Convert target-descriptions.
4392 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4393 * gdb/features/Makefile: Add rx.xml.
4394 * gdb/features/rx.xml: New.
4395 * gdb/features/rx.c: Generated.
4396 * gdb/NEWS: Mention target description support.
4397
4398 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4399
4400 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4401 *slot_ptr.
4402
4403 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4404
4405 * configure.ac: Don't check for 'dlfcn.h' (moved to
4406 gdbsupport/common.m4).
4407 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4408 'gdbsupport/'.
4409 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4410 * compile/compile-c-support.c: Include
4411 'gdbsupport/gdb-dlfcn.h'.
4412 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4413 * gdb-dlfcn.c: Move to...
4414 * gdbsupport/gdb-dlfcn.c: ... here.
4415 * gdb-dlfcn.h: Move to...
4416 * gdbsupport/gdb-dlfcn.h: ... here.
4417
4418 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4419
4420 * nios2-tdep.c (struct reg_value): Improve comments. Make
4421 the offset field signed.
4422
4423 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4424
4425 * python/lib/gdb/__init__.py (_execute_file): New function.
4426 * python/python.c (python_run_simple_file): Call gdb._execute_file
4427 on Windows.
4428
4429 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4430
4431 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4432 all uses as this was never set to anything but a zero value.
4433
4434 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4435
4436 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4437
4438 2019-08-21 Christian Biesinger <cbiesinger@google.com>
4439
4440 * tui/tui-data.h (tui_gen_win_info): Add an =default
4441 move constructor, required by some GCC versions.
4442
4443 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
4444
4445 * go32-nat.c (go32_sysinfo): Add hygon_p.
4446
4447 2019-08-20 Tom Tromey <tom@tromey.com>
4448
4449 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4450 line_from_reg_element_no, first_reg_element_no_inline,
4451 display_all_data, delete_data_content_windows,
4452 erase_data_content>: Now private.
4453
4454 2019-08-20 Tom Tromey <tom@tromey.com>
4455
4456 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4457 (tui_unhighlight_win, tui_highlight_win)
4458 (tui_win_info::make_window): Update.
4459 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4460
4461 2019-08-20 Tom Tromey <tom@tromey.com>
4462
4463 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4464 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4465 (MAX_PID_WIDTH): Move to tui-stack.c.
4466 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4467 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4468 (MAX_PID_WIDTH): Move from tui-data.h.
4469
4470 2019-08-20 Tom Tromey <tom@tromey.com>
4471
4472 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4473 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4474 (box_win): Update.
4475 (tui_gen_win_info::make_window): Rename from tui_make_window.
4476 (tui_win_info::make_window): New method.
4477 (tui_gen_win_info::make_visible): Update.
4478 * tui/tui-source.c (tui_source_window::set_contents): Update.
4479 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4480 (tui_data_window::display_registers_from): Update.
4481 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4482 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4483 Declare.
4484 <can_box>: Remove.
4485 <title>: Remove.
4486 (struct tui_win_info) <make_window>: Declare.
4487 <can_box>: Now virtual.
4488 <title>: New member.
4489 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4490 * tui/tui-command.c (tui_cmd_window::resize): Update.
4491
4492 2019-08-20 Tom Tromey <tom@tromey.com>
4493
4494 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4495 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4496 (tui_data_window::check_register_values): Update.
4497
4498 2019-08-20 Tom Tromey <tom@tromey.com>
4499
4500 * tui/tui-regs.h (struct tui_data_window): Use
4501 DISABLE_COPY_AND_ASSIGN.
4502 <regs_content>: Change type, removing unique_ptr.
4503 <tui_data_window>: Add move constructor.
4504 * tui/tui-regs.c (tui_data_window::show_registers)
4505 (tui_data_window::show_register_group)
4506 (tui_data_window::display_registers_from)
4507 (tui_data_window::display_registers_from)
4508 (tui_data_window::first_data_item_displayed)
4509 (tui_data_window::delete_data_content_windows)
4510 (tui_data_window::rerender, tui_data_window::refresh_window)
4511 (tui_data_window::check_register_values): Update.
4512
4513 2019-08-20 Tom Tromey <tom@tromey.com>
4514
4515 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4516 show_register_group>: Declare.
4517 (tui_show_register_group): Don't declare.
4518 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4519 tui_show_registers.
4520 (tui_data_window::show_register_group): Rename from
4521 tui_show_register_group.
4522 (tui_data_window::check_register_values, tui_reg_command):
4523 Update.
4524 * tui/tui-layout.c (tui_set_layout): Update.
4525
4526 2019-08-20 Tom Tromey <tom@tromey.com>
4527
4528 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4529 Declare.
4530 (tui_check_register_values): Don't declare.
4531 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4532 from tui_check_register_values.
4533 * tui/tui-hooks.c (tui_register_changed): Update.
4534
4535 2019-08-20 Tom Tromey <tom@tromey.com>
4536
4537 * tui/tui-regs.c (tui_reg_layout): Move later.
4538 (tui_show_registers): Don't enable TUI mode or change layout.
4539
4540 2019-08-20 Tom Tromey <tom@tromey.com>
4541
4542 * tui/tui-regs.h (struct tui_data_item_window)
4543 <~tui_data_item_window>: Remove.
4544 <content>: Now a unique_xmalloc_ptr.
4545 * tui/tui-regs.c (tui_register_format): Return a
4546 unique_xmalloc_ptr.
4547 (tui_get_register): Update.
4548 (~tui_data_item_window): Remove.
4549 (tui_data_window::display_registers_from, tui_display_register):
4550 Update.
4551 * tui/tui-io.h (tui_expand_tabs): Update.
4552 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4553 Remove "col" parameter.
4554
4555 2019-08-20 Tom Tromey <tom@tromey.com>
4556
4557 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4558 field.
4559 * tui/tui-regs.c (~tui_data_item_window): Update.
4560
4561 2019-08-20 Tom Tromey <tom@tromey.com>
4562
4563 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4564 earlier.
4565
4566 2019-08-20 Tom Tromey <tom@tromey.com>
4567
4568 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4569
4570 2019-08-20 Tom Tromey <tom@tromey.com>
4571
4572 * tui/tui-source.h (struct tui_source_window): Update.
4573 * tui/tui-regs.c (tui_show_registers): Update.
4574 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4575 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4576 (NO_REGS_STRING): Remove defines.
4577
4578 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
4579
4580 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4581 unnecessary thread walk if remote doesn't support the packet.
4582
4583 2019-08-19 Tom Tromey <tromey@adacore.com>
4584
4585 * python/py-value.c (value_has_field): Fix indentation.
4586
4587 2019-08-19 Tom Tromey <tromey@adacore.com>
4588
4589 * printcmd.c (do_one_display, info_display_command): Update.
4590 * block.h (contained_in): Return bool. Add allow_nested
4591 parameter.
4592 * block.c (contained_in): Return bool. Add allow_nested
4593 parameter.
4594
4595 2019-08-19 Tom Tromey <tom@tromey.com>
4596
4597 * configure: Rebuild.
4598 * configure.ac: Disallow the combination of -static-libstdc++ and
4599 source highlight.
4600 * source-cache.c (get_language_name): Handle rust.
4601 (source_cache::get_source_lines): Ignore highlighting exceptions.
4602
4603 2019-08-16 Tom Tromey <tom@tromey.com>
4604
4605 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4606 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4607 (struct tui_source_window_base) <make_visible, refresh_window,
4608 resize>: Remove methods.
4609 <execution_info>: Remove field.
4610 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4611 (tui_show_source_line, tui_source_window_base)
4612 (~tui_source_window_base): Update.
4613 (tui_source_window_base::resize)
4614 (tui_source_window_base::make_visible)
4615 (tui_source_window_base::refresh_window): Remove.
4616 (tui_source_window_base::update_exec_info): Update.
4617 * tui/tui-source.c (tui_source_window::set_contents): Update.
4618 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4619
4620 2019-08-16 Tom Tromey <tom@tromey.com>
4621
4622 * tui/tui-hooks.c (tui_remove_hooks): Don't set
4623 deprecated_query_hook.
4624
4625 2019-08-16 Tom Tromey <tom@tromey.com>
4626
4627 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4628 (tui_update_source_windows_with_line): Update.
4629 * tui/tui-source.h (struct tui_source_window)
4630 <show_symtab_source>: Declare.
4631 (tui_show_symtab_source): Don't declare.
4632 * tui/tui-source.c (tui_show_symtab_source): Rename from
4633 tui_show_symtab_source.
4634
4635 2019-08-16 Tom Tromey <tom@tromey.com>
4636
4637 * tui/tui-winsource.h (struct tui_source_window_base)
4638 <set_contents>: Declare.
4639 * tui/tui-winsource.c
4640 (tui_source_window_base::update_source_window_as_is): Update.
4641 * tui/tui-source.h (struct tui_source_window) <set_contents>:
4642 Declare.
4643 (tui_set_source_content): Don't declare.
4644 * tui/tui-source.c (tui_source_window::set_contents): Rename from
4645 tui_set_source_content.
4646 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4647 Declare.
4648 (tui_set_disassem_content): Don't declare.
4649 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4650 tui_set_disassem_content.
4651
4652 2019-08-16 Tom Tromey <tom@tromey.com>
4653
4654 * tui/tui-winsource.h (struct tui_source_window_base)
4655 <update_breakpoint_info>: Declare.
4656 (tui_update_breakpoint_info): Don't declare.
4657 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4658 (tui_update_all_breakpoint_info): Update.
4659 (tui_source_window_base::update_breakpoint_info): Rename from
4660 tui_update_breakpoint_info.
4661 (tui_source_window_base::update_exec_info): Update.
4662
4663 2019-08-16 Tom Tromey <tom@tromey.com>
4664
4665 * tui/tui-winsource.h (struct tui_source_window_base)
4666 <update_source_window>: Declare.
4667 (tui_update_source_window): Don't declare.
4668 * tui/tui-winsource.c
4669 (tui_source_window_base::update_source_window): Rename from
4670 tui_update_source_window.
4671 (tui_source_window_base::rerender): Update.
4672 * tui/tui-source.c (tui_source_window::maybe_update): Update.
4673 * tui/tui-disasm.c (tui_show_disassem)
4674 (tui_show_disassem_and_update_source)
4675 (tui_disasm_window::maybe_update): Update.
4676
4677 2019-08-16 Tom Tromey <tom@tromey.com>
4678
4679 * tui/tui-winsource.h (struct tui_source_window_base)
4680 <update_source_window_as_is>: Declare.
4681 (tui_update_source_window_as_is): Don't declare.
4682 * tui/tui-winsource.c (tui_update_source_window): Update
4683 (tui_source_window_base::update_source_window_as_is): Rename from
4684 tui_update_source_window_as_is.
4685 (tui_source_window_base::refill): Update.
4686 * tui/tui-source.c (tui_show_symtab_source): Update.
4687 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4688 Update.
4689
4690 2019-08-16 Tom Tromey <tom@tromey.com>
4691
4692 * tui/tui-winsource.h (tui_update_source_window)
4693 (tui_update_source_window_as_is): Remove "noerror" parameter.
4694 * tui/tui-winsource.c (tui_update_source_window)
4695 (tui_update_source_window_as_is): Remove "noerror" parameter.
4696 (tui_update_source_windows_with_addr)
4697 (tui_update_source_windows_with_line)
4698 (tui_source_window_base::rerender)
4699 (tui_source_window_base::refill): Update.
4700 * tui/tui-source.h (tui_set_source_content)
4701 (tui_show_symtab_source): Remove "noerror" parameter.
4702 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4703 parameter.
4704 (tui_show_symtab_source): Likewise.
4705 (tui_source_window::maybe_update): Update.
4706 * tui/tui-disasm.c (tui_show_disassem)
4707 (tui_show_disassem_and_update_source)
4708 (tui_disasm_window::do_scroll_vertical)
4709 (tui_disasm_window::maybe_update): Update.
4710
4711 2019-08-16 Tom Tromey <tom@tromey.com>
4712
4713 * tui/tui.c (tui_is_window_visible): Update.
4714 * tui/tui-wingeneral.c (tui_make_window)
4715 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4716 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4717 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4718 (tui_set_win_height_command, parse_scrolling_args): Update.
4719 * tui/tui-source.c (tui_source_window::style_changed): Update.
4720 * tui/tui-regs.c (tui_show_registers)
4721 (tui_data_window::first_data_item_displayed)
4722 (tui_data_window::delete_data_content_windows)
4723 (tui_check_register_values, tui_reg_command): Update.
4724 * tui/tui-disasm.c (tui_show_disassem): Update.
4725 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4726 method.
4727 <is_visible>: Remove field.
4728 * tui/tui-data.c (tui_next_win, tui_prev_win)
4729 (tui_delete_invisible_windows): Update.
4730
4731 2019-08-16 Tom Tromey <tom@tromey.com>
4732
4733 * tui/tui-winsource.h (struct tui_source_window_base)
4734 <m_has_locator>: Remove.
4735 * tui/tui-layout.c (show_source_disasm_command, show_data)
4736 (show_source_or_disasm_and_command): Update.
4737
4738 2019-08-16 Alan Hayward <alan.hayward@arm.com>
4739
4740 * NEWS (Other MI changes): New subsection.
4741 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4742 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4743 * arch-utils.c (default_get_pc_address_flags): New function.
4744 * arch-utils.h (default_get_pc_address_flags): New declaration.
4745 * gdbarch.sh: Add get_pc_address_flags.
4746 * gdbarch.c: Regenerate.
4747 * gdbarch.h: Likewise.
4748 * stack.c (print_pc): New function.
4749 (print_frame_info) (print_frame): Call print_pc.
4750
4751 2019-08-16 Tom de Vries <tdevries@suse.de>
4752
4753 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4754 print_objfile_section_info.
4755
4756 2019-08-15 Tom Tromey <tom@tromey.com>
4757
4758 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4759 calling update_cmdwin_start_line.
4760 * tui/tui-winsource.h (struct tui_source_window_base)
4761 <do_make_visible_with_new_height, set_new_height>: Don't declare.
4762 <rerender>: Declare.
4763 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4764 Call rerender.
4765 (tui_source_window_base::set_new_height): Remove.
4766 (tui_source_window_base::rerender): Rename from
4767 do_make_visible_with_new_height.
4768 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4769 resize method.
4770 (tui_win_info::make_invisible_and_set_new_height)
4771 (tui_win_info::make_visible_with_new_height): Remove.
4772 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4773 Declare.
4774 * tui/tui-stack.c (tui_locator_window::rerender): New method.
4775 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4776 do_make_visible_with_new_height>: Don't declare.
4777 <rerender>: Declare.
4778 * tui/tui-regs.c (tui_data_window::rerender): Rename from
4779 set_new_height.
4780 (tui_data_window::do_make_visible_with_new_height): Remove.
4781 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4782 call tui_show_locator_content.
4783 (tui_gen_win_info::resize): Call rerender.
4784 (show_source_or_disasm_and_command): Don't call
4785 tui_show_locator_content.
4786 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4787 method.
4788 (struct tui_win_info) <rerender>: Declare.
4789 <set_new_height, make_invisible_and_set_new_height,
4790 make_visible_with_new_height>: Don't declare.
4791 * tui/tui-data.c (tui_win_list::rerender): New method.
4792 * tui/tui-command.h (struct tui_cmd_window)
4793 <do_make_visible_with_new_height>: Don't declare.
4794 * tui/tui-command.c
4795 (tui_cmd_window::do_make_visible_with_new_height): Remove.
4796
4797 2019-08-15 Tom Tromey <tromey@adacore.com>
4798
4799 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4800 * ada-lang.c (ada_enum_name): Likewise.
4801
4802 2019-08-15 Christian Biesinger <cbiesinger@google.com>
4803
4804 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4805 leading underscore.
4806 (GdbOutputErrorFile): Likewise.
4807 (global scope): Adjust constructor calls to GdbOutput{,Error}File
4808 accordingly.
4809 (execute_unwinders): Rename to have a leading underscore.
4810 (auto_load_packages): Likewise.
4811 (global scope): Adjust call to auto_load_packages accordingly.
4812 (GdbSetPythonDirectory): Likewise.
4813 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4814 instead of execute_unwinders.
4815
4816 2019-08-15 Tom Tromey <tom@tromey.com>
4817
4818 * tui/tui-layout.c (show_layout, show_source_disasm_command)
4819 (show_data): Don't change window visibility.
4820 (tui_gen_win_info::resize): Remove special case for command
4821 window. Use wresize, when available.
4822 (show_source_or_disasm_and_command): Don't change window
4823 visibility.
4824 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4825 <make_visible>: New method.
4826 * tui/tui-command.c (tui_cmd_window::resize): New method.
4827
4828 2019-08-15 Tom Tromey <tom@tromey.com>
4829
4830 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4831 (struct tui_source_windows): New.
4832 * tui/tui-winsource.c (tui_display_main): Update.
4833 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4834 (new_height_ok, parse_scrolling_args): Update.
4835 * tui/tui-layout.c (show_layout, show_data): Update.
4836 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
4837 (tui_add_to_source_windows): Don't declare.
4838 * tui/tui-data.c (source_windows, tui_source_windows)
4839 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
4840
4841 2019-08-15 Tom Tromey <tom@tromey.com>
4842
4843 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
4844 Rename from reset.
4845 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
4846 * tui/tui-layout.c (show_source_disasm_command, show_data):
4847 Update.
4848 (tui_gen_win_info::resize): Rename.
4849 (show_source_or_disasm_and_command): Update.
4850 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
4851 reset.
4852
4853 2019-08-15 Tom Tromey <tom@tromey.com>
4854
4855 * tui/tui-stack.c (tui_initialize_static_data): Remove.
4856 * tui/tui-interp.c (tui_interp::init): Don't call
4857 tui_initialize_static_data.
4858 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
4859
4860 2019-08-15 Tom Tromey <tom@tromey.com>
4861
4862 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
4863 examine tui_win_list.
4864
4865 2019-08-15 Tom Tromey <tom@tromey.com>
4866
4867 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
4868 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
4869 tui_clear_source_content.
4870 (tui_clear_source_content): Remove.
4871 (tui_source_window_base::do_erase_source_content): Hoist call to
4872 content.clear().
4873 * tui/tui-stack.c (tui_show_frame_info): Don't call
4874 tui_clear_source_content.
4875
4876 2019-08-15 Tom Tromey <tom@tromey.com>
4877
4878 * tui/tui-winsource.h (struct tui_source_window_base)
4879 <do_erase_source_content>: New method.
4880 <erase_source_content>: New method.
4881 (tui_erase_source_content): Don't declare.
4882 * tui/tui-winsource.c (tui_clear_source_content): Update.
4883 (tui_source_window_base::do_erase_source_content): Rename from
4884 tui_erase_source_content.
4885 (tui_source_window_base::show_source_content): Update.
4886 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4887 * tui/tui-source.h (struct tui_source_window)
4888 <erase_source_content>: New method.
4889 * tui/tui-disasm.h (struct tui_disasm_window)
4890 <erase_source_content>: New method.
4891
4892 2019-08-15 Tom Tromey <tom@tromey.com>
4893
4894 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
4895 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
4896 constructor.
4897 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
4898 * tui/tui-source.c (tui_set_source_content): Update.
4899 * tui/tui-disasm.c (tui_set_disassem_content): Update.
4900
4901 2019-08-15 Tom Tromey <tom@tromey.com>
4902
4903 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
4904 * tui/tui-winsource.c (tui_line_is_displayed): Move to
4905 tui-source.c.
4906 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
4907 Declare.
4908 * tui/tui-source.c (tui_source_window::line_is_displayed): New
4909 method.
4910 (tui_source_window::maybe_update): Update.
4911
4912 2019-08-15 Tom Tromey <tom@tromey.com>
4913
4914 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
4915 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
4916 tui-disasm.c.
4917 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
4918 Declare.
4919 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
4920 method.
4921 (tui_disasm_window::maybe_update): Update.
4922
4923 2019-08-15 Tom Tromey <tom@tromey.com>
4924
4925 * tui/tui-winsource.h (struct tui_source_window_base)
4926 <maybe_update>: Declare.
4927 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
4928 method.
4929 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
4930 Declare.
4931 * tui/tui-source.c (tui_source_window::maybe_update): New method.
4932 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
4933 Declare.
4934 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
4935
4936 2019-08-15 Tom Tromey <tom@tromey.com>
4937
4938 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
4939
4940 2019-08-15 Tom Tromey <tom@tromey.com>
4941
4942 * tui/tui-wingeneral.c: Include tui-stack.h.
4943 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
4944 (struct tui_locator_window): Move from tui-data.h.
4945 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
4946 (tui_initialize_static_data): Move from tui-data.c.
4947 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
4948 (struct tui_locator_window): Move to tui-stack.c.
4949 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
4950 (tui_initialize_static_data): Move to tui-stack.c.
4951
4952 2019-08-15 Tom Tromey <tom@tromey.com>
4953
4954 * tui/tui-layout.c (show_source_disasm_command)
4955 (show_source_or_disasm_and_command): Use make_visible method, not
4956 tui_make_window.
4957 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
4958 Remove.
4959
4960 2019-08-15 Tom Tromey <tom@tromey.com>
4961
4962 * tui/tui-wingeneral.h (tui_make_window): Update.
4963 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
4964 parameter.
4965 (tui_gen_win_info::make_visible): Update.
4966 * tui/tui-regs.c (tui_data_window::display_registers_from):
4967 Update.
4968 * tui/tui-layout.c (show_source_disasm_command)
4969 (show_source_or_disasm_and_command): Update.
4970 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
4971 (enum tui_box): Remove.
4972 (struct tui_win_info) <can_box>: New method.
4973 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
4974 method.
4975
4976 2019-08-15 Tom de Vries <tdevries@suse.de>
4977
4978 * linux-nat-trad.c: Include gdbarch.h.
4979
4980 2019-08-14 Alan Hayward <alan.hayward@arm.com>
4981
4982 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
4983 register sizes.
4984
4985 2019-08-14 Tom Tromey <tromey@adacore.com>
4986
4987 * darwin-nat.c: Include gdbarch.h.
4988 * darwin-nat-info.c: Include gdbarch.h.
4989
4990 2019-08-13 Tom Tromey <tom@tromey.com>
4991
4992 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
4993 Remove.
4994 * tui/tui-data.c (tui_initialize_static_data): Update.
4995
4996 2019-08-13 Tom Tromey <tom@tromey.com>
4997
4998 * tui/tui-winsource.h (struct tui_exec_info_window)
4999 <~tui_exec_info_window, maybe_allocate_content, get_content,
5000 m_content>: Remove.
5001 (struct tui_source_window_base) <set_exec_info_content,
5002 show_exec_info_content>: Don't declare.
5003 * tui/tui-winsource.c
5004 (tui_exec_info_window::maybe_allocate_content): Remove.
5005 (tui_source_window_base::update_exec_info): Rename from
5006 set_exec_info_content.
5007 (tui_source_window_base::show_exec_info_content)
5008 (tui_source_window_base::update_exec_info): Remove.
5009
5010 2019-08-13 Tom Tromey <tom@tromey.com>
5011
5012 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5013 declare.
5014 * tui/tui-winsource.c (tui_update_source_window_as_is)
5015 (tui_update_source_windows_with_addr, tui_erase_source_content):
5016 Update.
5017 (tui_clear_exec_info_content): Remove.
5018
5019 2019-08-13 Tom Tromey <tom@tromey.com>
5020
5021 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5022 declare.
5023 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5024 call tui_erase_exec_info_content.
5025 (tui_clear_exec_info_content): Rename from
5026 tui_erase_exec_info_content.
5027 (tui_clear_exec_info_content): Delete.
5028
5029 2019-08-13 Tom Tromey <tom@tromey.com>
5030
5031 * tui/tui-winsource.h (struct tui_source_window_base)
5032 <show_exec_info_content>: Declare.
5033 (tui_show_exec_info_content): Don't declare.
5034 * tui/tui-winsource.c
5035 (tui_source_window_base::show_exec_info_content): Rename from
5036 tui_show_exec_info_content.
5037 (tui_source_window_base::update_exec_info): Update.
5038
5039 2019-08-13 Tom Tromey <tom@tromey.com>
5040
5041 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5042 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5043 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5044 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5045 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5046 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5047 ... here.
5048
5049 2019-08-13 Tom Tromey <tom@tromey.com>
5050
5051 * tui/tui-winsource.h (struct tui_source_window_base)
5052 <update_exec_info>: Declare.
5053 (tui_update_exec_info): Don't declare.
5054 * tui/tui-winsource.c (tui_update_source_window_as_is)
5055 (tui_source_window_base::refresh_all)
5056 (tui_update_all_breakpoint_info): Update.
5057 (tui_source_window_base::update_exec_info): Rename from
5058 tui_update_exec_info.
5059 * tui/tui-stack.c (tui_show_frame_info): Update.
5060
5061 2019-08-13 Tom Tromey <tom@tromey.com>
5062
5063 * tui/tui-winsource.h (struct tui_source_window_base)
5064 <set_exec_info_content>: Declare.
5065 (tui_set_exec_info_content): Don't declare.
5066 * tui/tui-winsource.c
5067 (tui_source_window_base::set_exec_info_content): Rename from
5068 tui_set_exec_info_content.
5069 (tui_update_exec_info): Update.
5070
5071 2019-08-13 Tom Tromey <tom@tromey.com>
5072
5073 * tui/tui-winsource.h (struct tui_source_window_base)
5074 <show_source_content>: Declare.
5075 (tui_show_source_content): Don't declare.
5076 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5077 (tui_source_window_base::show_source_content): Rename from
5078 tui_show_source_content.
5079 (tui_source_window_base::refresh_all): Update.
5080 * tui/tui-layout.c (show_source_disasm_command)
5081 (show_source_or_disasm_and_command): Update.
5082
5083 2019-08-13 Tom Tromey <tom@tromey.com>
5084
5085 * tui/tui-winsource.c (tui_erase_source_content)
5086 (tui_show_source_content, tui_source_window_base::refresh_all):
5087 Update.
5088 * tui/tui-wingeneral.h
5089 (tui_check_and_display_highlight_if_needed): Don't declare.
5090 * tui/tui-wingeneral.c
5091 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5092 check_and_display_highlight_if_needed.
5093 * tui/tui-win.c (tui_rehighlight_all)
5094 (tui_win_info::make_visible_with_new_height): Update.
5095 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5096 (tui_data_window::erase_data_content)
5097 (tui_data_window::display_all_data): Update.
5098 * tui/tui-data.h (struct tui_win_info)
5099 <check_and_display_highlight_if_needed>: Declare.
5100
5101 2019-08-13 Tom Tromey <tom@tromey.com>
5102
5103 * tui/tui-win.c (tui_resize_all): Call
5104 tui_delete_invisible_windows.
5105 * tui/tui-layout.c (show_layout): Call
5106 tui_delete_invisible_windows.
5107 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5108 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5109
5110 2019-08-13 Tom Tromey <tom@tromey.com>
5111
5112 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5113 tui_add_win_to_layout.
5114
5115 2019-08-13 Tom Tromey <tom@tromey.com>
5116
5117 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5118 * tui/tui-layout.c (tui_default_win_height): Now static.
5119
5120 2019-08-13 Tom Tromey <tom@tromey.com>
5121
5122 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5123 single switch.
5124 (show_source_disasm_command, show_source_or_disasm_and_command):
5125 Don't check current layout.
5126
5127 2019-08-13 Tom Tromey <tom@tromey.com>
5128
5129 * tui/tui-wingeneral.c (make_all_visible): Remove.
5130 (tui_make_all_invisible): Simplify.
5131 * tui/tui-layout.c (tui_make_all_invisible): Move from
5132 tui-wingeneral.c; simplify.
5133 (show_layout): Hoist call to tui_make_all_invisible.
5134 (show_data): Don't call tui_make_all_invisible.
5135
5136 2019-08-13 Tom Tromey <tom@tromey.com>
5137
5138 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5139 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5140
5141 2019-08-13 Tom Tromey <tom@tromey.com>
5142
5143 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5144 tui-data.c.
5145 (show_source_disasm_command, show_data)
5146 (show_source_or_disasm_and_command): Don't use
5147 tui_set_current_layout_to.
5148 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5149 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5150 tui-layout.c.
5151 (tui_set_current_layout_to): Remove.
5152
5153 2019-08-13 Tom Tromey <tom@tromey.com>
5154
5155 * tui/tui-layout.c (tui_set_layout): Update.
5156 * tui/tui-data.h (struct tui_layout_def): Remove.
5157 (tui_layout_def): Don't declare.
5158 * tui/tui-data.c (layout_def): Remove.
5159 (tui_layout_def): Remove.
5160
5161 2019-08-13 Tom Tromey <tom@tromey.com>
5162
5163 * tui/tui-winsource.h (struct tui_source_window_base)
5164 <clear_detail>: No longer "override".
5165 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5166 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5167 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5168 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5169 Remove.
5170 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5171
5172 2019-08-13 Tom Tromey <tromey@adacore.com>
5173
5174 * tracepoint.c: Don't include readline.h or history.h.
5175
5176 2019-08-12 Tom Tromey <tom@tromey.com>
5177
5178 * configure: Rebuild.
5179 * configure.ac: Check for readline 7.
5180 * NEWS: Mention readline 7 requirement.
5181 * README: Update.
5182
5183 2019-08-12 Tom Tromey <tom@tromey.com>
5184
5185 * mingw-hdep.c (gdb_select): Remove readline hack.
5186
5187 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5188
5189 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5190 when the function fails.
5191
5192 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5193
5194 * s390-tdep.c (s390_type_align): New function.
5195 (s390_gdbarch_init): Set it as type_align gdbarch method.
5196
5197 2019-08-09 Tom de Vries <tdevries@suse.de>
5198
5199 PR gdb/24591
5200 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5201 pc_low with relocation offset.
5202
5203 2019-08-07 Tom Tromey <tromey@adacore.com>
5204
5205 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5206 (print_frame_args): Update.
5207 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5208 Update.
5209 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5210 * frame.h (struct frame_arg): Add initializers.
5211 <error>: Now a unique_xmalloc_ptr.
5212
5213 2019-08-07 Alan Hayward <alan.hayward@arm.com>
5214
5215 * NEWS: Expand the Pointer Authentication entry.
5216 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5217 (aarch64_frame_unmask_lr): ... to this.
5218 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5219 Call aarch64_frame_unmask_lr.
5220 * frame.c (struct frame_info): Add "masked" variable.
5221 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5222 (fprint_frame): Check for masked pc.
5223 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5224 declarations.
5225 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5226 * stack.c (print_frame): Check for masked pc.
5227
5228 2019-08-06 Tom Tromey <tom@tromey.com>
5229
5230 * stabsread.c (patch_block_stabs, read_one_struct_field)
5231 (read_enum_type): Use obstack_strndup.
5232 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5233 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5234 * dwarf2read.c (guess_full_die_structure_name)
5235 (anonymous_struct_prefix): Use obstack_strndup.
5236 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5237 * c-exp.y (yylex): Use obstack_strndup.
5238 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5239 (write_var_or_type): Use obstack_strndup.
5240
5241 2019-08-06 Tom Tromey <tom@tromey.com>
5242
5243 * symfile.c (reread_symbols): Use obstack_strdup.
5244 * stabsread.c (read_type): Use obstack_strdup.
5245 * gdb_obstack.h (obstack_strdup): New overload.
5246 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5247 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5248 (dwarf2_canonicalize_name): Use obstack_strdup.
5249 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5250 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5251 Use obstack_strdup.
5252
5253 2019-08-06 Tom Tromey <tom@tromey.com>
5254
5255 * gdb_obstack.h (obstack_strdup): Define.
5256 * gdb_obstack.c (obstack_strdup): Don't define.
5257
5258 2019-08-06 Tom Tromey <tom@tromey.com>
5259
5260 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5261 obstack_strdup.
5262 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5263 obstack_strdup.
5264 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5265 * stabsread.c (common_block_start): Use obstack_strdup.
5266 * objfiles.c (set_objfile_main_name, objfile): Use
5267 obstack_strdup.
5268 * namespace.c (add_using_directive): Use obstack_strdup.
5269 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5270 * jit.c (finalize_symtab): Use obstack_strdup.
5271 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5272 (guess_partial_die_structure_name, partial_die_info::fixup)
5273 (dwarf2_name): Use obstack_strdup.
5274 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5275 obstack_strdup.
5276 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5277 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5278 obstack_strdup.
5279 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5280
5281 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5282
5283 * unittests/help-doc-selftests.c: New file.
5284 * Makefile.in: Add the new file.
5285
5286 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5287
5288 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5289 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5290 the full first line, except when FOR_VALUE_PREFIX. In this case,
5291 the trailing '.' is not output, and the first character is uppercased.
5292 (print_help_for_command): Update call to print_doc_line.
5293 (print_doc_of_command): Likewise.
5294 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5295 * cli/cli-option.c (append_indented_doc): Do not append newline.
5296 (build_help_option): Append newline after first appended_indented_doc
5297 only if a second call is done.
5298 (build_help): Append 2 new lines before each option, except the first
5299 one.
5300 * compile/compile.c (_initialize_compile): Add new lines after
5301 %OPTIONS%, when not at the end of the help.
5302 Change help doc or code
5303 producing the help doc to respect the invariants.
5304 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5305 Also removed the new line after 'Options:', as all other commands
5306 do not put an empty line between 'Options:' and the first option.
5307 * printcmd.c (_initialize_printcmd): Likewise.
5308 * stack.c (_initialize_stack): Likewise.
5309 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5310 incorrectly telling COMMAND is optional.
5311 * ada-lang.c (_initialize_ada_language): Change help doc or code
5312 producing the help doc to respect the invariants.
5313 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5314 * breakpoint.c (_initialize_breakpoint): Likewise.
5315 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5316 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5317 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5318 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5319 _initialize_cli_style): Likewise.
5320 * corelow.c (core_target_info): Likewise.
5321 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5322 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5323 * filesystem.c (_initialize_filesystem): Likewise.
5324 * frame.c (_initialize_frame): Likewise.
5325 * gnu-nat.c (add_task_commands): Likewise.
5326 * infcall.c (_initialize_infcall): Likewise.
5327 * infcmd.c (_initialize_infcmd): Likewise.
5328 * interps.c (_initialize_interpreter): Likewise.
5329 * language.c (_initialize_language): Likewise.
5330 * linux-fork.c (_initialize_linux_fork): Likewise.
5331 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5332 * maint.c (_initialize_maint_cmds): Likewise.
5333 * memattr.c (_initialize_mem): Likewise.
5334 * printcmd.c (_initialize_printcmd): Likewise.
5335 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5336 _RegEx): Likewise.
5337 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5338 * record-btrace.c (_initialize_record_btrace): Likewise.
5339 * record-full.c (_initialize_record_full): Likewise.
5340 * record.c (_initialize_record): Likewise.
5341 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5342 * regcache.c (_initialize_regcache): Likewise.
5343 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5344 _initialize_remote): Likewise.
5345 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5346 * serial.c (_initialize_serial): Likewise.
5347 * skip.c (_initialize_step_skip): Likewise.
5348 * source.c (_initialize_source): Likewise.
5349 * stack.c (_initialize_stack): Likewise.
5350 * symfile.c (_initialize_symfile): Likewise.
5351 * symtab.c (_initialize_symtab): Likewise.
5352 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5353 * top.c (init_main): Likewise.
5354 * tracefile-tfile.c (tfile_target_info): Likewise.
5355 * tracepoint.c (_initialize_tracepoint): Likewise.
5356 * tui/tui-win.c (_initialize_tui_win): Likewise.
5357 * utils.c (add_internal_problem_command): Likewise.
5358 * valprint.c (value_print_option_defs): Likewise.
5359
5360 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
5361
5362 PR build/24886
5363 * configure.ac: Drop enable-libmcheck support.
5364 * configure, config.in: Rebuild.
5365 * libmcheck.m4: Remove.
5366 * acinclude.m4: Don't include it.
5367 * Makefile.in: Don't distribute it.
5368 * top.c (print_gdb_configuration): Don't mention it.
5369
5370 2019-08-06 Tom Tromey <tom@tromey.com>
5371
5372 * utils.c (set_output_style): Sometimes pass stream to
5373 emit_style_escape.
5374 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5375 * record-btrace.c (btrace_insn_history): Update.
5376 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5377 method.
5378 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5379 Update initializers.
5380 <m_uiout>: New field.
5381 <m_di>: Move lower.
5382 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5383 Remove "uiout" parameter.
5384 (dump_insns): Update.
5385 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5386 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5387
5388 2019-08-06 Christian Biesinger <cbiesinger@google.com>
5389
5390 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5391 (error_in_psymtab_expansion): Likewise.
5392 (lookup_symbol_via_quick_fns): Likewise.
5393 (basic_lookup_transparent_type_quick): Likewise.
5394 (basic_lookup_transparent_type_1): Likewise.
5395
5396 2019-08-06 Tom Tromey <tromey@adacore.com>
5397
5398 * source.c (last_source_error): Now bool.
5399 (print_source_lines_base): Make "noprint" bool. Only open
5400 source file when last_source_visited changes.
5401
5402 2019-08-06 Tom Tromey <tromey@adacore.com>
5403
5404 * annotate.c (annotate_source_line): Use g_source_cache.
5405 * source-cache.c (source_cache::get_plain_source_lines): Change
5406 parameters. Populate m_offset_cache.
5407 (source_cache::ensure): New method.
5408 (source_cache::get_line_charpos): New method.
5409 (extract_lines): Move lower. Change parameters.
5410 (source_cache::get_source_lines): Move lower.
5411 * source-cache.h (class source_cache): Update comment.
5412 <get_line_charpos>: New method.
5413 <get_source_lines>: Update comment.
5414 <clear>: Clear m_offset_cache.
5415 <get_plain_source_lines>: Change parameters.
5416 <ensure>: New method
5417 <m_offset_cache>: New member.
5418 * source.c (forget_cached_source_info_for_objfile): Update.
5419 (info_source_command): Use g_source_cache.
5420 (find_source_lines, open_source_file_with_line_charpos): Remove.
5421 (print_source_lines_base, search_command_helper): Use g_source_cache.
5422 * source.h (open_source_file_with_line_charpos): Don't declare.
5423 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5424 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5425 Use g_source_cache.
5426
5427 2019-08-06 Tom Tromey <tromey@adacore.com>
5428
5429 * source-cache.c (source_cache::get_plain_source_lines):
5430 Remove "first_line" and "last_line" parameters.
5431 (source_cache::get_source_lines): Cache plain text.
5432 * source-cache.h (class source_cache)
5433 <get_plain_source_lines>: Update.
5434
5435 2019-08-06 Tom Tromey <tromey@adacore.com>
5436
5437 * source-cache.c (extract_lines): No longer a method.
5438 Changed type of parameter. Include final newline.
5439 (selftests::extract_lines_test): New function.
5440 (_initialize_source_cache): Likewise.
5441 * source-cache.h (class source_cache)
5442 <extract_lines>: Don't declare.
5443
5444 2019-08-06 Tom Tromey <tromey@adacore.com>
5445
5446 * breakpoint.c (init_breakpoint_sal): Update.
5447 (breakpoint): Update.
5448 * breakpoint.h (struct breakpoint) <filter>: Now a
5449 unique_xmalloc_ptr.
5450
5451 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5452
5453 * NEWS: Mention dictionary access on blocks.
5454 * python/py-block.c (blpy_getitem): New function.
5455 (block_object_as_mapping): New struct.
5456 (block_object_type): Use new struct for tp_as_mapping field.
5457
5458 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5459
5460 * objfiles.h (objfile): Add a comment describing partial symbols.
5461
5462 2019-08-05 Tom Tromey <tromey@adacore.com>
5463
5464 * compile/compile.c (_initialize_compile): Use _(), not N_().
5465 * thread.c (_initialize_thread): Use _(), not N_().
5466 * stack.c (_initialize_stack): Use _(), not N_().
5467 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5468
5469 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5470
5471 * dwarf2read.c (struct dw2_symtab_iterator):
5472 <want_specific_block>: Remove.
5473 <block_index>: Change type to gdb::optional.
5474 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5475 change type of BLOCK_INDEX parameter to gdb::optional.
5476 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5477 (dw2_lookup_symbol): Don't pass argument for
5478 WANT_SPECIFIC_BLOCK.
5479 (dw2_expand_symtabs_for_function): Don't pass argument for
5480 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5481 (class dw2_debug_names_iterator)
5482 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5483 parameter, change BLOCK_INDEX type to gdb::optional.
5484 <m_want_specific_block>: Remove.
5485 <m_block_index>: Change type to gdb::optional.
5486 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5487 gdb::optional. Re-write in function of gdb::optional.
5488 (dw2_debug_names_lookup_symbol): Don't pass argument for
5489 WANT_SPECIFIC_BLOCK.
5490 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5491 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5492 BLOCK_INDEX.
5493
5494 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5495
5496 * NEWS: Mention changes to "info sources" command.
5497
5498 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5499
5500 * symtab.c (filename_partial_match_opts): New struct type.
5501 (struct output_source_filename_data): New members
5502 regexp, c_regexp, partial_match.
5503 (output_source_filename): Use new members to decide to print file.
5504 (info_sources_option_defs): New variable.
5505 (make_info_sources_options_def_group, print_info_sources_header,
5506 info_sources_command_completer):
5507 New functions.
5508 (info_sources_command): Read new optional arguments.
5509 (_initialize_symtab): Update info sources help.
5510
5511 2019-08-02 Alexandre Oliva <oliva@adacore.com>
5512
5513 * ada-lang.c (exception_support_info_v0): Renamed from...
5514 (default_exception_support_info): ... this. Create new
5515 definition for v1.
5516 (ada_has_this_exception_support): Look up catch_handlers_sym.
5517 (ada_exception_support_info_sniffer): Try v0 after default.
5518
5519 2019-08-01 Tom Tromey <tromey@adacore.com>
5520
5521 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5522 gdbarch.h.
5523
5524 2019-08-01 Christian Biesinger <cbiesinger@google.com>
5525
5526 * s12z-tdep.c: Fix include path for s12z-opc.h.
5527
5528 2019-08-01 Alan Hayward <alan.hayward@arm.com>
5529
5530 * NEWS: Require GNU make 3.82.
5531
5532 2019-07-16 Tom Tromey <tom@tromey.com>
5533
5534 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5535 declare.
5536
5537 2019-07-30 Tom Tromey <tromey@adacore.com>
5538
5539 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5540
5541 2019-07-30 Kevin Buettner <kevinb@redhat.com>
5542
5543 * printcmd.c (print_address_symbolic): Print negative offsets.
5544 (build_address_symbolic): Force signed arithmetic when computing
5545 offset.
5546
5547 2019-07-30 Christian Biesinger <cbiesinger@google.com>
5548
5549 PR/24474: Add a function to lookup static variables.
5550 * NEWS: Mention this new function.
5551 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5552 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5553 * python/python.c (python_GdbMethods): Add new function.
5554
5555 2019-07-29 Christian Biesinger <cbiesinger@google.com>
5556
5557 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5558 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5559 (objfpy_lookup_static_symbol): New function.
5560 (objfile_object_methods): Add new functions.
5561
5562 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5563
5564 * NEWS: Mention 'set|show print frame-info'. Mention new
5565 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5566 backtrace argument. Mention that python frame filtering code
5567 is now consistent with what 'backtrace' command prints.
5568
5569 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5570
5571 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5572 comments.
5573 (print_frame_info_auto, print_frame_info_source_line,
5574 print_frame_info_location, print_frame_info_source_and_location,
5575 print_frame_info_location_and_address, print_frame_info_short_location):
5576 New declarations.
5577 (struct frame_print_options): New member print_frame_info.
5578 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5579 * stack.h (get_user_print_what_frame_info): New declaration.
5580 (frame_show_address): New declaration.
5581 * stack.c (print_frame_arguments_choices): New value 'presence'.
5582 (print_frame_info_auto, print_frame_info_source_line,
5583 print_frame_info_location, print_frame_info_source_and_location,
5584 print_frame_info_location_and_address, print_frame_info_short_location,
5585 print_frame_info_choices, print_frame_info_print_what): New definitions.
5586 (print_frame_args): Only print dots for args if print frame-arguments
5587 is 'presence'.
5588 (frame_print_option_defs): New element for "frame-info".
5589 (get_user_print_what_frame_info): New function.
5590 (frame_show_address): Make non static. Move comment to stack.h.
5591 (print_frame_info_to_print_what): New function.
5592 (print_frame_info): Update comment. Use fp_opts.print_frame_info
5593 to decide what to print.
5594 (backtrace_command_1): Handle the new print_frame_arguments_presence
5595 value.
5596 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5597 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5598 (py_print_frame): In non-mi mode, use LOCATION as default for
5599 print_what, similarly to frame information printed directly by
5600 backtrace command. Handle frame-info user option in non MI mode.
5601
5602 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5603
5604 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5605 Add case for debugging 32-bit target on 64-bit host. Revise
5606 comment.
5607
5608 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5609
5610 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5611 instead of find_function_entry_range_from_pc.
5612
5613 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5614
5615 * stack.c (find_frame_funname): Remove code which preferred
5616 minsym over symtab sym in "certain pathological cases".
5617
5618 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5619 parameter. Change type of "do_demangle" to bool.
5620 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5621 Pass suitable "prefer_sym_over_minsym" flag to
5622 build_address_symbolic(). Don't output "+" for negative offsets.
5623 * printcmd.c (print_address_symbolic): Update invocation of
5624 build_address_symbolic to include a "prefer_sym_over_minsym"
5625 flag.
5626 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5627 Restrict cases in which use of minimal symbol is preferred to that
5628 of a found symbol. Update comments.
5629
5630 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5631 for entry pc when entry pc is out of range for that FDE.
5632
5633 2019-07-26 Brian Callahan <bcallah@openbsd.org>
5634
5635 PR gdb/24839:
5636 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5637 type.
5638
5639 2019-07-25 Christian Biesinger <cbiesinger@google.com>
5640
5641 * python/py-objfile.c (add_separate_debug_file): Fix comment about
5642 this function's Python signature.
5643
5644
5645 2019-07-24 Christian Biesinger <cbiesinger@google.com>
5646
5647 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5648 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5649 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5650 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5651 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5652
5653
5654 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
5655
5656 * h8300-tdep.c (h8300_register_name_common): New.
5657 h8300_register_name): Use h8300_register_name_common.
5658 (h8300s_register_name): Likewise.
5659 (h8300sx_register_name): Likewise.
5660 (h8300h_register_nam): New.
5661 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5662
5663
5664 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
5665
5666 * arm-tdep.c (arm_skip_cmse_entry): New function.
5667 (arm_is_sgstubs_section): New function.
5668 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5669
5670 2019-07-22 Tom Tromey <tom@tromey.com>
5671
5672 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5673 Don't self-assign.
5674
5675 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5676
5677 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5678 type_print.
5679
5680 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5681
5682 * symtab.c (search_symbols): Adjust msymbol matching type arrays
5683 so that GDB doesn't match any msymbols when searching in the
5684 TYPES_DOMAIN.
5685 (print_symbol_info): Print using typedef_print or type_print based
5686 on the type of the symbol. Add updated FIXME comment moved from...
5687 (_initialize_symtab): ... move and update FIXME comment to above.
5688
5689 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5690
5691 * NEWS: Mention adding -q option to "info types".
5692 * symtab.c (struct info_types_options): New struct.
5693 (info_types_options_defs): New variable.
5694 (make_info_types_options_def_group): New function.
5695 (info_types_command): Use gdb::option framework to parse options.
5696 (info_types_command_completer): New function.
5697 (_initialize_symtab): Extend the help text on "info types" and
5698 register command completer.
5699
5700 2019-07-21 Christian Biesinger <cbiesinger@google.com>
5701
5702 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5703 (lookup_symbol_in_objfile): Change int to block_enum and add a
5704 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5705
5706 2019-07-20 Christian Biesinger <cbiesinger@google.com>
5707
5708 * MAINTAINERS (Write After Approval): Add self.
5709
5710 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
5711
5712 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5713 instruction to the dummy code region.
5714
5715 2019-07-19 Tom Tromey <tromey@adacore.com>
5716
5717 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5718 (ARGSUSED, PARAMS, __func__): Remove rules.
5719
5720 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5721
5722 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5723 * features/arm/arm-with-iwmmxt.c: Remove.
5724 * features/arm/arm-with-iwmmxt.xml: Remove.
5725 * features/arm/arm-with-m-fpa-layout.c: Remove.
5726 * features/arm/arm-with-m-fpa-layout.xml: Remove.
5727 * features/arm/arm-with-m-vfp-d16.c: Remove.
5728 * features/arm/arm-with-m-vfp-d16.xml: Remove.
5729 * features/arm/arm-with-m.c: Remove.
5730 * features/arm/arm-with-m.xml: Remove.
5731 * features/arm/arm-with-neon.c: Remove.
5732 * features/arm/arm-with-neon.xml: Remove.
5733 * features/arm/arm-with-vfpv2.c: Remove.
5734 * features/arm/arm-with-vfpv2.xml: Remove.
5735 * features/arm/arm-with-vfpv3.c: Remove.
5736 * features/arm/arm-with-vfpv3.xml: Remove.
5737
5738 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5739
5740 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5741
5742 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5743
5744 * arch/aarch32.c (aarch32_create_target_description): Create
5745 target descriptions using features.
5746 * arch/arm.c (arm_create_target_description)
5747 (arm_create_mprofile_target_description): Likewise.
5748 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5749
5750 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5751
5752 * Makefile.in: Add new files.
5753 * aarch32-tdep.c: New file.
5754 * aarch32-tdep.h: New file.
5755 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5756 Call aarch32_read_description.
5757 * arch/aarch32.c: New file.
5758 * arch/aarch32.h: New file.
5759 * arch/arm.c (arm_create_target_description)
5760 (arm_create_mprofile_target_description): New function.
5761 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5762 (arm_create_target_description)
5763 (arm_create_mprofile_target_description): New declaration.
5764 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5765 read_description functions.
5766 * arm-linux-nat.c (arm_linux_nat_target::read_description):
5767 Likewise.
5768 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5769 * arm-tdep.c (tdesc_arm_list): New variable.
5770 (arm_register_g_packet_guesses): Call create description functions.
5771 (arm_read_description) (arm_read_mprofile_description): New
5772 function.
5773 * arm-tdep.h (arm_read_description)
5774 (arm_read_mprofile_description): Add declaration.
5775 * configure.tgt: Add new files.
5776
5777 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
5778
5779 * top.c (new_ui_command): Open specified terminal just once.
5780
5781 2019-07-18 Tom Tromey <tromey@adacore.com>
5782
5783 * symtab.c (main_name): Constify return type.
5784 * symfile.c (set_initial_language): Update.
5785 * symtab.h (main_name): Constify return type.
5786
5787 2019-07-17 Tom Tromey <tom@tromey.com>
5788
5789 * tui/tui-winsource.c (tui_update_source_window)
5790 (tui_update_source_window_as_is)
5791 (tui_update_source_windows_with_line): Remove return.
5792 * tui/tui-disasm.c (tui_show_disassem)
5793 (tui_show_disassem_and_update_source): Remove return.
5794 * tui/tui.c (tui_reset): Remove return.
5795 * tui/tui-wingeneral.c
5796 (tui_check_and_display_highlight_if_needed): Remove return.
5797
5798 2019-07-17 Tom Tromey <tom@tromey.com>
5799
5800 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5801
5802 2019-07-17 Tom Tromey <tom@tromey.com>
5803
5804 * tui/tui-winsource.h (struct tui_exec_info_window)
5805 (struct tui_source_window_base): Move from tui-data.h.
5806 * tui/tui-winsource.c: Move many method definitions from
5807 elsewhere. Remove "structuring" comments.
5808 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5809 (tui_source_window_base::refresh_window): Move to
5810 tui-winsource.c.
5811 * tui/tui-win.c (tui_source_window_base::refresh_all)
5812 (tui_source_window_base::update_tab_width)
5813 (tui_source_window_base::set_new_height)
5814 (tui_source_window_base::do_make_visible_with_new_height): Move to
5815 tui-winsource.c.
5816 * tui/tui-source.h: Update.
5817 * tui/tui-source.c (tui_source_window_base::reset): Move to
5818 tui-winsource.c.
5819 * tui/tui-disasm.h: Update.
5820 * tui/tui-data.h (struct tui_exec_info_window): Move to
5821 tui-winsource.h.
5822 (struct tui_source_window_base): Likewise.
5823 * tui/tui-data.c (tui_source_window_base::clear_detail)
5824 (tui_source_window_base, ~tui_source_window_base): Move to
5825 tui-winsource.c.
5826
5827 2019-07-17 Tom Tromey <tom@tromey.com>
5828
5829 * tui/tui-win.c (tui_resize_all)
5830 (tui_source_window_base::update_tab_width)
5831 (tui_adjust_win_heights): Update.
5832 (tui_win_info::make_invisible_and_set_new_height): Rename from
5833 make_invisible_and_set_new_height.
5834 * tui/tui-data.h (struct tui_win_info)
5835 <make_invisible_and_set_new_height>: New method.
5836
5837 2019-07-17 Tom Tromey <tom@tromey.com>
5838
5839 * tui/tui.c: Update.
5840 * tui/tui-source.h (struct tui_source_window): Move from
5841 tui-data.h.
5842 * tui/tui-layout.c: Update.
5843 * tui/tui-disasm.c: Update.
5844 * tui/tui-data.h (struct tui_source_window): Move to
5845 tui-source.h.
5846
5847 2019-07-17 Tom Tromey <tom@tromey.com>
5848
5849 * tui/tui-disasm.h (struct tui_disasm_window): Move from
5850 tui-data.h.
5851 * tui/tui-data.h (struct tui_disasm_window): Move to
5852 tui-disasm.h.
5853
5854 2019-07-17 Tom Tromey <tom@tromey.com>
5855
5856 * tui/tui-regs.h (struct tui_data_item_window): Move from
5857 tui-data.h.
5858 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
5859 * tui/tui-data.h (struct tui_data_item_window): Move to
5860 tui-regs.h.
5861 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
5862
5863 2019-07-17 Tom Tromey <tom@tromey.com>
5864
5865 * tui/tui.c: Update.
5866 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
5867 (tui_cmd_window::max_height): Move to tui-command.c.
5868 * tui/tui-layout.c: Update.
5869 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
5870 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
5871 tui-command.c.
5872 * tui/tui-command.h (struct tui_cmd_window): Move from
5873 tui-data.h.
5874 * tui/tui-command.c: Remove "structuring" comments.
5875 (tui_cmd_window::clear_detail)
5876 (tui_cmd_window::do_make_visible_with_new_height)
5877 (tui_cmd_window::max_height): Move from elsewhere.
5878
5879 2019-07-17 Tom Tromey <tom@tromey.com>
5880
5881 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
5882 Now static.
5883 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
5884 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
5885
5886 2019-07-17 Tom Tromey <tom@tromey.com>
5887
5888 * tui/tui.c: Update.
5889 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
5890 tui-regs.c.
5891 * tui/tui-windata.h: Remove file.
5892 * tui/tui-windata.c: Remove file.
5893 * tui/tui-win.c (tui_data_window::set_new_height)
5894 (tui_data_window::do_make_visible_with_new_height): Move to
5895 tui-regs.c.
5896 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
5897 * tui/tui-regs.c: Remove "structuring" comments.
5898 (tui_data_window::first_data_item_displayed)
5899 (tui_data_window::delete_data_content_windows)
5900 (tui_data_window::erase_data_content)
5901 (tui_data_window::display_all_data)
5902 (tui_data_window::refresh_all)
5903 (tui_data_window::do_scroll_vertical)
5904 (tui_data_window::clear_detail, tui_data_window::set_new_height)
5905 (tui_data_window::do_make_visible_with_new_height)
5906 (tui_data_window::refresh_window): Move from elsewhere.
5907 (_initialize_tui_regs): Move to end of file.
5908 * tui/tui-layout.c: Update.
5909 * tui/tui-hooks.c: Update.
5910 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
5911 * tui/tui-data.c (tui_data_window::clear_detail): Move to
5912 tui-regs.c.
5913 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
5914
5915 2019-07-17 Tom Tromey <tom@tromey.com>
5916
5917 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
5918 seen.
5919
5920 2019-07-17 Tom Tromey <tom@tromey.com>
5921
5922 * tui/tui-win.c (tui_source_window_base::set_new_height)
5923 (tui_source_window_base::do_make_visible_with_new_height): Use
5924 m_has_locator field directly.
5925 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
5926 method.
5927 (struct tui_source_window_base) <has_locator>: Likewise.
5928
5929 2019-07-17 Tom Tromey <tom@tromey.com>
5930
5931 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
5932 Don't declare.
5933 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
5934 Remove.
5935 * tui/tui-win.c (tui_source_window_base::set_new_height)
5936 (tui_source_window_base::set_new_height)
5937 (make_invisible_and_set_new_height)
5938 (tui_source_window_base::do_make_visible_with_new_height)
5939 (tui_source_window_base::do_make_visible_with_new_height):
5940 Update.
5941 * tui/tui-layout.c (show_source_disasm_command, show_data)
5942 (show_source_or_disasm_and_command): Update.
5943 * tui/tui-layout.c (show_layout): Update.
5944
5945 2019-07-17 Tom Tromey <tom@tromey.com>
5946
5947 * tui/tui-layout.c (make_data_window): Remove.
5948 (show_data): Unify creation and re-initialization cases.
5949
5950 2019-07-17 Tom Tromey <tom@tromey.com>
5951
5952 * tui/tui-layout.c (make_source_window, make_disasm_window):
5953 Remove.
5954 (show_data): Unify creation and re-initialization cases.
5955
5956 2019-07-17 Tom Tromey <tom@tromey.com>
5957
5958 * tui/tui-layout.c (make_command_window): Remove.
5959 (show_source_disasm_command, show_source_or_disasm_and_command):
5960 Unify creation and re-initialization cases.
5961
5962 2019-07-17 Tom Tromey <tom@tromey.com>
5963
5964 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
5965 creation and re-initialization cases.
5966
5967 2019-07-17 Tom Tromey <tom@tromey.com>
5968
5969 * tui/tui-regs.c (tui_get_register): Return void.
5970
5971 2019-07-17 Tom Tromey <tom@tromey.com>
5972
5973 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
5974 Simplify.
5975
5976 2019-07-17 Tom Tromey <tom@tromey.com>
5977
5978 * tui/tui-layout.c (show_source_disasm_command): Simplify window
5979 resetting.
5980
5981 2019-07-17 Tom Tromey <tom@tromey.com>
5982
5983 * tui/tui.h (tui_set_layout_by_name): Don't declare.
5984 * tui/tui-regs.c (tui_reg_layout): New function.
5985 (tui_show_registers, tui_reg_command): Use it.
5986 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
5987 (tui_layout_command): Rename from tui_set_layout_by_name. Change
5988 parameters.
5989 (tui_layout_command): Remove.
5990
5991 2019-07-17 Tom Tromey <tom@tromey.com>
5992
5993 * tui/tui-layout.h (tui/tui-layout): Return void.
5994 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
5995
5996 2019-07-17 Tom Tromey <tom@tromey.com>
5997
5998 * tui/tui-layout.c (show_source_disasm_command, show_data):
5999 Update.
6000 (reset_locator): Remove.
6001 (show_source_or_disasm_and_command): Update.
6002
6003 2019-07-17 Tom Tromey <tom@tromey.com>
6004
6005 * tui/tui-source.c (tui_source_window_base::reset): Remove
6006 win_type parameter.
6007 * tui/tui-layout.c (make_command_window, make_source_window)
6008 (make_disasm_window, make_data_window)
6009 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6010 (reset_locator, show_source_or_disasm_and_command): Update.
6011 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6012 win_type parameter.
6013 (struct tui_source_window_base) <reset>: Likewise.
6014
6015 2019-07-17 Tom Tromey <tom@tromey.com>
6016
6017 * tui/tui-layout.c (show_source_disasm_command): Use
6018 reset_locator.
6019 (reset_locator): New function.
6020 (init_and_make_win): Remove.
6021 (show_source_or_disasm_and_command): Use reset_locator.
6022
6023 2019-07-17 Tom Tromey <tom@tromey.com>
6024
6025 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6026 condition.
6027 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6028 Remove condition.
6029 * tui/tui-source.c (tui_source_window_base::reset): New method.
6030 * tui/tui-layout.c (make_command_window): Don't call
6031 init_and_make_win.
6032 (make_source_window, make_disasm_window): Don't call
6033 make_source_or_disasm_window.
6034 (make_data_window): Don't call init_and_make_win. Change calling
6035 convention.
6036 (show_source_disasm_command, show_data): Simplify.
6037 (make_source_or_disasm_window): Remove.
6038 (show_source_or_disasm_and_command): Simplify.
6039 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6040 (struct tui_source_window_base) <reset>: Likewise.
6041 <execution_info>: Remove initializer.
6042 * tui/tui-data.c (tui_source_window_base): Initialize
6043 execution_info.
6044
6045 2019-07-17 Tom Tromey <tom@tromey.com>
6046
6047 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6048 variable.
6049
6050 2019-07-17 Tom Tromey <tom@tromey.com>
6051
6052 * tui/tui.c (tui_rl_other_window): Update.
6053 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6054 superclass method first. Always iterate over regs_content.
6055 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6056 method.
6057 * tui/tui-win.c (tui_set_focus_command): Update.
6058
6059 2019-07-17 Tom Tromey <tom@tromey.com>
6060
6061 * tui/tui-win.c (tui_set_focus_command): Rename from
6062 tui_set_focus. Call tui_enable.
6063 (tui_set_focus_command): Remove.
6064
6065 2019-07-17 Tom Tromey <tom@tromey.com>
6066
6067 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6068 refresh_window.
6069 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6070 touchwin.
6071 (tui_data_window::refresh_window): Call refresh_window on data
6072 items. Always call superclass refresh_window.
6073 (tui_win_info::refresh): Remove.
6074 (tui_source_window_base::refresh_window): Update.
6075 (tui_refresh_all): Update.
6076 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6077 refresh_window.
6078 (show_source_or_disasm_and_command): Likewise.
6079 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6080 (struct tui_source_window_base) <refresh>: Likewise.
6081
6082 2019-07-17 Tom Tromey <tom@tromey.com>
6083
6084 * tui/tui-winsource.c (tui_clear_source_content)
6085 (tui_show_source_content): Update.
6086 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6087 whether content is empty.
6088 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6089 Remove.
6090
6091 2019-07-17 Tom Tromey <tom@tromey.com>
6092
6093 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6094 window's contents.
6095 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6096 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6097
6098 2019-07-17 Tom Tromey <tom@tromey.com>
6099
6100 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6101 (struct tui_data_item_window): Update.
6102
6103 2019-07-17 Tom Tromey <tom@tromey.com>
6104
6105 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6106 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6107 defines.
6108
6109 2019-07-17 Tom Tromey <tom@tromey.com>
6110
6111 * tui/tui-winsource.h (tui_erase_source_content)
6112 (tui_clear_source_content): Remove "display_prompt" parameter.
6113 * tui/tui-winsource.c (tui_update_source_window_as_is)
6114 (tui_update_source_windows_with_addr): Update.
6115 (tui_clear_source_content): Remove "display_prompt" parameter.
6116 (tui_erase_source_content): Likewise. Simplify.
6117 (tui_show_source_content): Update.
6118 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6119 * tui/tui-stack.c (tui_show_frame_info): Update.
6120 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6121 Remove defines.
6122
6123 2019-07-17 Tom Tromey <tom@tromey.com>
6124
6125 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6126 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6127 parameter.
6128 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6129 parameter.
6130
6131 2019-07-17 Tom Tromey <tom@tromey.com>
6132
6133 * tui/tui-winsource.c (tui_clear_source_content)
6134 (tui_show_source_content, tui_show_exec_info_content)
6135 (tui_clear_exec_info_content): Update.
6136 * tui/tui-stack.c (tui_show_locator_content): Update.
6137 (tui_show_frame_info): Update.
6138 * tui/tui-source.h (tui_source_window): Don't declare.
6139 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6140 from tui_source_is_displayed.
6141 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6142 Remove field.
6143 (struct tui_source_window_base) <content_in_use>: New field. Now
6144 bool.
6145 (struct tui_source_window) <showing_source_p>: New method.
6146 (TUI_SRC_WIN): Change cast.
6147 * tui/tui-data.c (tui_initialize_static_data): Update.
6148
6149 2019-07-17 Tom Tromey <tom@tromey.com>
6150
6151 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6152 location_matches_p.
6153 * tui/tui-source.c (tui_source_window::location_matches_p): New
6154 method.
6155 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6156 method.
6157 * tui/tui-data.h (struct tui_source_window_base)
6158 <location_matches_p>: New method.
6159 (struct tui_source_window, struct tui_disasm_window)
6160 <location_matches_p>: Likewise.
6161
6162 2019-07-17 Tom Tromey <tom@tromey.com>
6163
6164 * tui/tui-win.c (tui_set_win_height_command): Rename from
6165 tui_set_win_height.
6166 (tui_set_win_height_command): Remove.
6167
6168 2019-07-17 Tom Tromey <tom@tromey.com>
6169
6170 * tui/tui-source.c (tui_source_window): New constructor. Add
6171 observer.
6172 (~tui_source_window): New destructor.
6173 (tui_source_window::style_changed): New method.
6174 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6175 (tui_attach_detach_observers): Update.
6176 * tui/tui-data.h (struct tui_source_window): Make constructor not
6177 inline. Add destructor.
6178 (struct tui_source_window) <style_changed>: New method.
6179 <m_observable>: New member.
6180
6181 2019-07-17 Tom Tromey <tom@tromey.com>
6182
6183 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6184 * tui/tui-win.c (tui_resize_all): Fix typo.
6185
6186 2019-07-17 Tom Tromey <tom@tromey.com>
6187
6188 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6189 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6190 (tui_refresh_all): Remove "list" parameter. Use foreach.
6191 * tui/tui-win.c (window_name_completer): Use foreach.
6192 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6193 (update_tab_width): Likewise.
6194 * tui/tui-layout.c (show_layout): Update.
6195 * tui/tui-data.h (class tui_window_iterator): New.
6196 (struct all_tui_windows): New.
6197 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6198
6199 2019-07-17 Tom Tromey <tom@tromey.com>
6200
6201 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6202 parameter. Don't reference globals.
6203 (tui_reg_command): Update.
6204
6205 2019-07-17 Tom Tromey <tom@tromey.com>
6206
6207 * tui/tui-regs.c (tui_show_registers): Simplify.
6208
6209 2019-07-17 Tom Tromey <tom@tromey.com>
6210
6211 * tui/tui-regs.c (tui_show_registers): Update.
6212 (tui_show_register_group): Add win_info parameter.
6213
6214 2019-07-17 Tom Tromey <tom@tromey.com>
6215
6216 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6217 Rename from tui_display_reg_element_at_line.
6218 (tui_data_window::display_registers_from_line): Update.
6219 * tui/tui-data.h (struct tui_data_window)
6220 <display_reg_element_at_line>: New method.
6221
6222 2019-07-17 Tom Tromey <tom@tromey.com>
6223
6224 * tui/tui-regs.h (tui_display_registers_from)
6225 (tui_display_registers_from_line): Don't declare.
6226 * tui/tui-windata.c (tui_data_window::display_all_data)
6227 (tui_data_window::refresh_all)
6228 (tui_data_window::do_scroll_vertical): Update.
6229 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6230 from tui_display_registers_from.
6231 (tui_display_reg_element_at_line): Update.
6232 (tui_data_window::display_registers_from_line): Rename from
6233 tui_display_registers_from_line.
6234 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6235 display_registers_from_line>: New methods.
6236
6237 2019-07-17 Tom Tromey <tom@tromey.com>
6238
6239 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6240 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6241 from tui_erase_data_content.
6242 (tui_data_window::display_all_data)
6243 (tui_data_window::refresh_all)
6244 (tui_data_window::do_scroll_vertical): Update.
6245 * tui/tui-regs.c (tui_show_registers): Update.
6246 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6247 New method.
6248
6249 2019-07-17 Tom Tromey <tom@tromey.com>
6250
6251 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6252 declare.
6253 * tui/tui-windata.c
6254 (tui_data_window::delete_data_content_windows): Rename from
6255 tui_delete_data_content_windows.
6256 (tui_data_window::display_all_data)
6257 (tui_data_window::do_scroll_vertical): Update.
6258 * tui/tui-data.h (struct tui_data_window)
6259 <delete_data_content_windows>: New method.
6260
6261 2019-07-17 Tom Tromey <tom@tromey.com>
6262
6263 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6264 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6265
6266 2019-07-17 Tom Tromey <tom@tromey.com>
6267
6268 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6269 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6270 from tui_display_all_data.
6271 * tui/tui-win.c
6272 (tui_data_window::do_make_visible_with_new_height): Update.
6273 * tui/tui-regs.c (tui_show_registers): Update.
6274 * tui/tui-layout.c (tui_set_layout): Update.
6275 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6276 method.
6277
6278 2019-07-17 Tom Tromey <tom@tromey.com>
6279
6280 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6281 * tui/tui-windata.c (tui_display_data_from): Remove.
6282 (tui_data_window::refresh_all): Update.
6283
6284 2019-07-17 Tom Tromey <tom@tromey.com>
6285
6286 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6287 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6288 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6289 tui_display_registers_from_line.
6290 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6291 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6292 "force_display" parameter.
6293
6294 2019-07-17 Tom Tromey <tom@tromey.com>
6295
6296 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6297 declare.
6298 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6299 Rename from tui_first_reg_element_no_inline.
6300 (tui_display_reg_element_at_line)
6301 (tui_display_registers_from_line): Update.
6302 * tui/tui-data.h (struct tui_data_window)
6303 <first_reg_element_no_inline>: New method.
6304
6305 2019-07-17 Tom Tromey <tom@tromey.com>
6306
6307 * tui/tui-windata.c (tui_display_data_from)
6308 (tui_data_window::do_scroll_vertical): Update.
6309 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6310 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6311 Rename from tui_line_from_reg_element_no.
6312 (tui_display_registers_from_line): Update.
6313 * tui/tui-data.h (struct tui_data_window)
6314 <line_from_reg_element_no>: New method.
6315
6316 2019-07-17 Tom Tromey <tom@tromey.com>
6317
6318 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6319 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6320 tui_last_regs_line_no.
6321 (tui_display_reg_element_at_line)
6322 (tui_display_registers_from_line): Update.
6323 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6324 method.
6325
6326 2019-07-17 Tom Tromey <tom@tromey.com>
6327
6328 PR tui/24722:
6329 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6330 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6331 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6332 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6333 (tui_update_breakpoint_info): Likewise.
6334 * tui/tui-hooks.c (tui_event_create_breakpoint)
6335 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6336 Update.
6337
6338 2019-07-17 Tom Tromey <tom@tromey.com>
6339
6340 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6341
6342 2019-07-17 Tom Tromey <tom@tromey.com>
6343
6344 * tui/tui-winsource.c (tui_update_source_window_as_is)
6345 (tui_update_source_windows_with_addr): Update.
6346 * tui/tui-source.h (tui_set_source_content)
6347 (tui_show_symtab_source): Add "win_info" parameter.
6348 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6349 parameter.
6350 (tui_show_symtab_source): Likewise.
6351
6352 2019-07-17 Tom Tromey <tom@tromey.com>
6353
6354 * tui/tui-wingeneral.c
6355 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6356
6357 2019-07-17 Tom Tromey <tom@tromey.com>
6358
6359 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6360 (struct tui_cmd_window) <can_scroll>: New method.
6361 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6362 method.
6363
6364 2019-07-17 Tom Tromey <tromey@adacore.com>
6365
6366 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6367 do_field_signed>: Rename. Change type of "value".
6368 * ui-out.c (ui_out::field_signed): Rename from field_int.
6369 Change type of "value".
6370 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6371 type of "value".
6372 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6373 do_field_int. Change type of "value".
6374 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6375 do_field_int. Change type of "value".
6376 * tracepoint.c (trace_status_mi, tfind_1)
6377 (print_one_static_tracepoint_marker): Update.
6378 * thread.c (print_thread_info_1, print_selected_thread_frame):
6379 Update.
6380 * stack.c (print_frame, print_frame_info): Update.
6381 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6382 Update.
6383 * source.c (print_source_lines_base): Update.
6384 * skip.c (info_skip_command): Update.
6385 * record-btrace.c (btrace_ui_out_decode_error)
6386 (btrace_call_history_src_line): Update.
6387 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6388 Update.
6389 * progspace.c (print_program_space): Update.
6390 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6391 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6392 do_field_int. Change type of "value".
6393 * mi/mi-out.c (mi_ui_out::do_table_begin)
6394 (mi_ui_out::do_table_header): Update.
6395 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6396 type of "value".
6397 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6398 (mi_cmd_data_list_changed_registers, output_register)
6399 (mi_cmd_data_read_memory, mi_load_progress)
6400 (mi_cmd_trace_frame_collected): Update.
6401 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6402 Update.
6403 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6404 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6405 (mi_cmd_var_list_children, varobj_update_one): Update.
6406 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6407 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6408 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6409 * inferior.c (print_inferior): Update.
6410 * gdb_bfd.c (print_one_bfd): Update.
6411 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6412 Update.
6413 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6414 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6415 do_field_int. Change type of "value".
6416 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6417 do_field_int. Change type of "value".
6418 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6419 (print_one_breakpoint_location, print_it_catch_fork)
6420 (print_one_catch_fork, print_it_catch_vfork)
6421 (print_one_catch_vfork, print_it_catch_solib)
6422 (print_it_catch_exec, print_it_ranged_breakpoint)
6423 (print_mention_watchpoint, print_mention_masked_watchpoint)
6424 (bkpt_print_it, update_static_tracepoint): Update.
6425 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6426 * break-catch-syscall.c (print_it_catch_syscall): Update.
6427 * ada-tasks.c (print_ada_task_info): Update.
6428 * ada-lang.c (print_it_exception, print_mention_exception):
6429 Update.
6430
6431 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6432
6433 PR breakpoints/24541
6434 * gdbarch.c: Regenerate.
6435 * gdbarch.h: Regenerate.
6436 * gdbarch.sh: Adjust return type and parameter types for
6437 'stap_adjust_register'.
6438 (i386_stap_adjust_register): Adjust signature and return new
6439 register name.
6440 * stap-probe.c (stap_parse_register_operand): Adjust use of
6441 'gdbarch_stap_adjust_register'.
6442
6443 2019-07-17 Tom Tromey <tromey@adacore.com>
6444
6445 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6446 declare VEC.
6447 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6448 std::vector.
6449 (struct s390_process_info): Add initializers.
6450 (s390_add_process): Use new.
6451 (s390_linux_nat_target::low_forget_process): Use delete.
6452 (s390_linux_nat_target::low_new_fork)
6453 (s390_linux_nat_target::stopped_by_watchpoint)
6454 (s390_linux_nat_target::low_prepare_to_resume)
6455 (s390_linux_nat_target::insert_watchpoint)
6456 (s390_linux_nat_target::insert_hw_breakpoint)
6457 (s390_linux_nat_target::remove_watchpoint)
6458 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6459
6460 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6461
6462 * aarch64-fbsd-nat.c: Include regcache.h.
6463 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6464 argument.
6465 (aarch64_fbsd_nat_target::fetch_registers)
6466 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6467 variable.
6468 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6469
6470 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6471
6472 * fbsd-nat.c: Include gdbarch.h.
6473
6474 2019-07-15 Tom Tromey <tromey@adacore.com>
6475
6476 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6477
6478 2019-07-15 Tom Tromey <tromey@adacore.com>
6479
6480 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6481 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6482 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6483 * cli-out.c (cli_ui_out::do_field_int): New method.
6484 * ui-out.c (ui_out::field_unsigned): New method.
6485 * symfile.c (generic_load): Use field_unsigned.
6486 (print_transfer_performance): Likewise.
6487 * record-btrace.c (ui_out_field_uint): Remove.
6488 (btrace_call_history_insn_range, btrace_call_history): Use
6489 field_unsigned.
6490 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6491 field_unsigned.
6492 * ui-out.h (class ui_out) <field_unsigned>: New method.
6493 <do_field_unsigned>: Likewise.
6494
6495 2019-07-15 Tom Tromey <tromey@adacore.com>
6496
6497 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6498 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6499 * target.c (flash_erase_command): Use field_string.
6500 * infrun.c (print_signal_received_reason): Use field_string.
6501 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6502 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6503 field_string.
6504 * ada-tasks.c (print_ada_task_info): Use field_string.
6505
6506 2019-07-15 Tom Tromey <tromey@adacore.com>
6507
6508 * target.c (flash_erase_command): Use field_core_addr.
6509 * symfile.c (generic_load): Use field_core_addr.
6510 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6511 Use field_core_addr.
6512 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6513 field_core_addr.
6514
6515 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6516
6517 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6518 value if its desired type is smaller than a CORE_ADDR and signed.
6519
6520 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6521
6522 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6523 of changes to field names, and use new is_reference field to
6524 decide if a property is a reference or not.
6525 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6526 field.
6527 (struct dwarf2_property_baton): Update header comment, rename
6528 'referenced_type' to 'property_type' and update comments.
6529 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6530 default property type, store in property baton, update to take
6531 accound of renamed field.
6532 (read_func_scope): Update call to attr_to_dynamic_prop.
6533 (read_array_type): Likewise.
6534 (dwarf2_per_cu_addr_sized_int_type): New function.
6535 (read_subrange_index_type): Move type finding code to
6536 dwarf2_per_cu_addr_sized_int_type.
6537 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6538 (dwarf2_per_cu_addr_type): New function.
6539 (set_die_type): Update calls to attr_to_dynamic_prop.
6540
6541 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6542
6543 * dwarf2read.c (read_subrange_index_type): New function.
6544 (read_subrange_type): Move code into new function and call it.
6545 * gdbtypes.c (create_range_type): Add some asserts.
6546
6547 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6548
6549 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6550 update return statements.
6551 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6552 declaration, and update comment to match.
6553 * gdbtypes.c (resolve_dynamic_array): Update call to
6554 dwarf2_evaluate_property to match new return type.
6555
6556 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6557
6558 * valarith.c (value_subscripted_rvalue): Change lowerbound
6559 parameter type from int to LONGEST.
6560 * value.h (value_subscripted_rvalue): Likewise in declaration.
6561
6562 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6563
6564 * cli/cli-utils.c (info_print_command_completer): New function.
6565 * cli/cli-utils.h: Add 'completer.h' include, and forward
6566 declaration for 'struct cmd_list_element'.
6567 (info_print_command_completer): Declare.
6568 * stack.c (_initialize_stack): Add completer for 'info locals' and
6569 'info args'.
6570 * symtab.c (_initialize_symtab): Add completer for 'info
6571 variables' and 'info functions'.
6572 * NEWS: Mention completion for additional info commands.
6573
6574 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6575
6576 * cli/cli-utils.c (extract_info_print_args): Delete.
6577 (extract_arg_maybe_quoted): Delete.
6578 (info_print_options_defs): New variable.
6579 (make_info_print_options_def_group): New function.
6580 (extract_info_print_options): Define new function.
6581 * cli/cli-utils.h (extract_info_print_args): Delete.
6582 (struct info_print_options): New structure.
6583 (extract_info_print_options): Declare new function.
6584 * stack.c (info_locals_command): Update to use new
6585 extract_info_print_options, also add a header comment.
6586 (info_args_command): Likewise.
6587 * symtab.c (info_variables_command): Likewise.
6588 (info_functions_command): Likewise.
6589
6590 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6591
6592 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6593 to extract string arguments.
6594 * common/common-utils.c (extract_string_maybe_quoted): New function.
6595 * common/common-utils.h (extract_string_maybe_quoted): Declare.
6596
6597 2019-07-11 Tom Tromey <tromey@adacore.com>
6598
6599 * main.c (get_init_files): Use GDBINIT, not gdbinit.
6600 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6601 * top.h (gdbinit): Don't declare.
6602 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6603 into...
6604 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
6605 * top.c (gdb_init): Don't call init_cli_cmds.
6606 (gdbinit): Remove.
6607 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6608
6609 2019-07-11 Tom Tromey <tromey@adacore.com>
6610
6611 * python/py-inferior.c (add_thread_object): Don't use thread_obj
6612 after it has been moved.
6613
6614 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6615
6616 * valops.c (value_must_coerce_to_target): Change return type to
6617 bool.
6618 * value.h (value_must_coerce_to_target): Likewise.
6619
6620 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
6621
6622 * breakpoint.c (is_hardware_watchpoint): Remove
6623 forward-declaration.
6624 (is_masked_watchpoint): Change return type to bool.
6625 (is_tracepoint): Likewise.
6626 (is_breakpoint): Likewise.
6627 (is_hardware_watchpoint): Likewise.
6628 (is_watchpoint): Likewise.
6629 (is_no_memory_software_watchpoint): Likewise.
6630 (is_catchpoint): Likewise.
6631 (breakpoint_1): Make FILTER parameter's return type bool.
6632 is_masked_watchpoint): Change return type to bool.
6633 (save_breakpoints): Make FILTER parameter's return type bool.
6634 * breakpoint.h (is_breakpoint): Change return type to bool.
6635 (is_watchpoint): Likewise.
6636 (is_catchpoint): Likewise.
6637 (is_tracepoint): Likewise.
6638
6639 2019-07-10 Tom Tromey <tom@tromey.com>
6640
6641 * defs.h: Don't include gdbarch.h.
6642 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6643 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6644 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6645 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6646 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6647 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6648 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6649 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6650 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6651 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6652 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6653 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6654 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6655 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6656 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6657 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6658 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6659 record-btrace.c, record.h, regcache-dump.c, regcache.h,
6660 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6661 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6662 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6663 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6664 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6665 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6666 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6667 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6668 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6669
6670 2019-07-10 Tom Tromey <tromey@adacore.com>
6671
6672 * ada-lang.h (is_ada_exception_catchpoint): Declare.
6673 * breakpoint.c (init_ada_exception_breakpoint): Register as
6674 bp_catchpoint.
6675 (print_one_breakpoint_location, print_one_breakpoint): Use
6676 is_ada_exception_catchpoint.
6677 * ada-lang.c (class ada_catchpoint_location): Pass
6678 bp_loc_software_breakpoint to bp_location constructor.
6679 (is_ada_exception_catchpoint): New function.
6680
6681 2019-07-10 Tom Tromey <tromey@adacore.com>
6682
6683 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
6684 VEC.
6685 (struct arm_exidx_entry): New method operator<.
6686 (struct arm_exidx_data) <section_maps>: Change type.
6687 (arm_exidx_data_free): Remove.
6688 (arm_exidx_data_key): Change type. Move lower.
6689 (arm_exidx_new_objfile): Update.
6690 (arm_compare_exidx_entries): Remove.
6691 (arm_find_exidx_entry, _initialize_arm_tdep)
6692
6693 2019-07-10 Tom Tromey <tromey@adacore.com>
6694
6695 * solib-spu.c (ocl_program_data_key): Change type.
6696 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6697 Update.
6698
6699 2019-07-10 Tom Tromey <tromey@adacore.com>
6700
6701 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
6702 (struct solib_aix_inferior_data) <library_list>: Change type.
6703 (solib_aix_inferior_data_handle): Change type.
6704 (get_solib_aix_inferior_data): Update.
6705 (solib_aix_free_library_list): Remove.
6706 (library_list_start_library): Update.
6707 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6708 return type.
6709 (solib_aix_get_library_list)
6710 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6711 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6712
6713 2019-07-10 Tom Tromey <tromey@adacore.com>
6714
6715 * solib-dsbt.c (struct dsbt_info): Add initializers.
6716 (solib_dsbt_pspace_data): Change type.
6717 (dsbt_pspace_data_cleanup): Remove.
6718 (get_dsbt_info, _initialize_dsbt_solib): Update.
6719
6720 2019-07-10 Tom Tromey <tromey@adacore.com>
6721
6722 * spu-tdep.c (spu_overlay_data): Change type.
6723 (spu_get_overlay_table, spu_overlay_new_objfile)
6724 (_initialize_spu_tdep): Update.
6725
6726 2019-07-10 Tom Tromey <tromey@adacore.com>
6727
6728 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6729 destructor.
6730 (dbx_objfile_data_key): Change type and declare later.
6731 (DBX_SYMFILE_INFO): Rewrite.
6732 * dbxread.c (dbx_objfile_data_key): Change type.
6733 (dbx_symfile_init): Update.
6734 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
6735 (coffstab_build_psymtabs, elfstab_build_psymtabs)
6736 (stabsect_build_psymtabs, _initialize_dbxread): Update.
6737
6738 2019-07-10 Tom Tromey <tromey@adacore.com>
6739
6740 * jit.c (jit_program_space_key): Change type. Move lower.
6741 (get_jit_program_space_data): Update.
6742 (jit_program_space_data_cleanup): Remove.
6743 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6744 Update.
6745 (struct jit_program_space_data): Add initializers.
6746
6747 2019-07-10 Tom Tromey <tromey@adacore.com>
6748
6749 * solib-darwin.c (struct darwin_info): Add initializers.
6750 (solib_darwin_pspace_data): Change type.
6751 (darwin_pspace_data_cleanup): Remove.
6752 (get_darwin_info, _initialize_darwin_solib): Update.
6753
6754 2019-07-10 Tom Tromey <tromey@adacore.com>
6755
6756 * remote-sim.c (struct sim_inferior_data): Add initializers,
6757 constructor, and destructor.
6758 (sim_inferior_data_key): Change type. Move lower.
6759 (check_for_duplicate_sim_descriptor): Update.
6760 (get_sim_inferior_data): Use new. Update.
6761 (~sim_inferior_data_cleanup): Rename from
6762 sim_inferior_data_cleanup. Simplify.
6763 (gdbsim_close_inferior, simulator_command)
6764 (sim_command_completer, _initialize_remote_sim): Update.
6765 (next_pid, INITIAL_PID): Move earlier.
6766
6767 2019-07-10 Tom Tromey <tromey@adacore.com>
6768
6769 * python/python-internal.h (create_thread_object): Return
6770 gdbpy_ref.
6771 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6772 * python/py-inferior.c (struct threadlist_entry): Add
6773 constructor.
6774 <thread_obj>: Now a gdbpy_ref.
6775 (thread_to_thread_object): Update.
6776 (add_thread_object): Use new.
6777 (delete_thread_object): Use delete.
6778 (infpy_threads): Update.
6779 (py_free_inferior): Update. Construct "inf_obj" after acquiring
6780 GIL.
6781
6782 2019-07-10 Tom Tromey <tromey@adacore.com>
6783
6784 * valops.c (value_cast): Specialize error message for Ada.
6785
6786 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6787
6788 * breakpoint.c (breakpoint_1): Update doc and parameter names.
6789
6790 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6791
6792 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6793 bpstat_should_step): Return bool, adjust comments.
6794 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6795 bpstat_should_step): Likewise.
6796
6797 2019-07-10 Alan Hayward <alan.hayward@arm.com>
6798
6799 * features/Makefile: Use feature target descriptions for Arm.
6800 * features/arm/arm-core.c: Generate new file.
6801 * features/arm/arm-fpa.c: Likewise.
6802 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6803 * features/arm/arm-m-profile.c: Likewise.
6804 * features/arm/arm-vfpv2.c: Likewise.
6805 * features/arm/arm-vfpv3.c: Likewise.
6806 * features/arm/xscale-iwmmxt.c: Likewise.
6807 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6808
6809 2019-07-10 Alan Hayward <alan.hayward@arm.com>
6810
6811 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6812 ptrace earlier.
6813
6814 2019-07-10 Alan Hayward <alan.hayward@arm.com>
6815
6816 * features/aarch64-pauth.c: Regenerate.
6817
6818 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
6819
6820 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6821 bool.
6822 (bpstat_what): Use false instead of 0.
6823
6824 2019-07-09 Pedro Alves <palves@redhat.com>
6825
6826 * break-catch-throw.c (is_exception_catchpoint): New.
6827 * breakpoint.c (print_one_breakpoint_location): New parameter
6828 'raw_loc'. Handle it. Use
6829 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6830 looking at the breakpoint's type.
6831 (print_one_breakpoint): If handling "maint info breakpoints", also
6832 print locations of exception catchpoints.
6833 * breakpoint.h (is_exception_catchpoint): Declare.
6834
6835 2019-07-09 Pedro Alves <palves@redhat.com>
6836
6837 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
6838 "addr" field.
6839 (allocate_location_exception_catchpoint): New.
6840 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
6841 (initialize_throw_catchpoint_ops): Install
6842 allocate_location_exception_catchpoint as allocate_location
6843 method.
6844 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
6845 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
6846 bp_loc_other.
6847 (breakpoint_address_is_meaningful): Delete.
6848 (bl_address_is_meaningful): New.
6849 (breakpoint_locations_match): Adjust comment.
6850 (bp_location_from_bp_type): New, factored out of...
6851 (bp_location::bp_location(breakpoint *)): ... this.
6852 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
6853 factored out of...
6854 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
6855 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
6856 breakpoint_address_is_meaningful.
6857 (bp_locations_compare): Adjust comment.
6858 (update_global_location_list): Use bl_address_is_meaningful
6859 instead of breakpoint_address_is_meaningful.
6860 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
6861 explicit.
6862 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
6863 * python/py-breakpoint.c (bppy_get_location): No longer check
6864 whether location is null.
6865
6866 2019-07-09 Pedro Alves <palves@redhat.com>
6867
6868 PR c++/15468
6869 * breakpoint.c (print_one_breakpoint_location): Remove
6870 single-location assert.
6871
6872 2019-07-09 Tom Tromey <tom@tromey.com>
6873
6874 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
6875 * configure: Rebuild.
6876 * configure.ac: Change common to gdbsupport.
6877 * gdbsupport: Rename from common.
6878 * acinclude.m4: Change common to gdbsupport.
6879 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
6880 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
6881 gdbsupport.
6882 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
6883 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
6884 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
6885 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
6886 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
6887 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
6888 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
6889 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
6890 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
6891 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
6892 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
6893 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
6894 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
6895 coff-pe-read.c, command.h, compile/compile-c-support.c,
6896 compile/compile-c.h, compile/compile-cplus-symbols.c,
6897 compile/compile-cplus-types.c, compile/compile-cplus.h,
6898 compile/compile-loc2c.c, compile/compile.c, completer.c,
6899 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
6900 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
6901 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
6902 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
6903 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
6904 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
6905 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
6906 features/aarch64-core.c, features/aarch64-fpu.c,
6907 features/aarch64-pauth.c, features/aarch64-sve.c,
6908 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
6909 features/i386/32bit-core.c, features/i386/32bit-linux.c,
6910 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
6911 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
6912 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
6913 features/i386/64bit-core.c, features/i386/64bit-linux.c,
6914 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
6915 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
6916 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
6917 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
6918 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
6919 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
6920 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
6921 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
6922 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
6923 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
6924 go32-nat.c, guile/guile.c, guile/scm-ports.c,
6925 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
6926 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
6927 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
6928 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
6929 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
6930 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
6931 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
6932 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
6933 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
6934 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
6935 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
6936 minsyms.c, mips-linux-tdep.c, namespace.h,
6937 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
6938 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
6939 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
6940 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
6941 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
6942 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
6943 nat/linux-waitpid.c, nat/mips-linux-watch.c,
6944 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
6945 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
6946 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
6947 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
6948 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
6949 procfs.c, producer.c, progspace.h, psymtab.h,
6950 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
6951 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
6952 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
6953 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
6954 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
6955 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
6956 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
6957 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
6958 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
6959 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
6960 target-memory.c, target.c, target.h, target/waitstatus.c,
6961 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
6962 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
6963 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
6964 unittests/array-view-selftests.c,
6965 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
6966 unittests/common-utils-selftests.c,
6967 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
6968 unittests/format_pieces-selftests.c,
6969 unittests/function-view-selftests.c,
6970 unittests/lookup_name_info-selftests.c,
6971 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
6972 unittests/mkdir-recursive-selftests.c,
6973 unittests/observable-selftests.c,
6974 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
6975 unittests/parse-connection-spec-selftests.c,
6976 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
6977 unittests/scoped_fd-selftests.c,
6978 unittests/scoped_mmap-selftests.c,
6979 unittests/scoped_restore-selftests.c,
6980 unittests/string_view-selftests.c, unittests/style-selftests.c,
6981 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
6982 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
6983 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
6984 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
6985 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
6986 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
6987
6988 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
6989
6990 * linespec.c (decode_digits_list_mode): Set explicit_line to a
6991 bool value.
6992 (decode_digits_ordinary): Set explicit_line field in sal.
6993 * symtab.c (skip_prologue_sal): Don't skip prologue for a
6994 symtab_and_line that was set on an explicit line number in
6995 assembler code. Do always update the recorded symtab and line if
6996 we do skip the prologue.
6997
6998 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
6999
7000 * breakpoint.c (set_breakpoint_location_function): Remove
7001 explicit_loc parameter.
7002 (momentary_breakpoint_from_master): Update call to
7003 set_breakpoint_location_function.
7004 (add_location_to_breakpoint): Likewise.
7005
7006 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7007
7008 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7009 required features based on default bfd type when no specific bfd
7010 is present.
7011
7012 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7013
7014 * NEWS: Mention that GDB printf and eval commands can now print
7015 C-style and Ada-style convenience var strings without
7016 calling the inferior.
7017 * printcmd.c (printf_c_string): Locally print GDB internal var
7018 instead of transiting via the inferior.
7019 (printf_wide_c_string): Likewise.
7020
7021 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7022
7023 PR breakpoints/25011
7024 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7025
7026 2019-07-04 Tom Tromey <tom@tromey.com>
7027
7028 PR tui/24724:
7029 * tui/tui-winsource.c (tui_clear_source_content): Update.
7030 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7031 (tui_update_breakpoint_info): Update.
7032 (tui_set_exec_info_content): Update.
7033 * tui/tui-source.c (tui_set_source_content_nil): Update.
7034 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7035 has_break.
7036 * tui/tui-data.h (enum tui_bp_flag): New.
7037 (tui_bp_flags): New enum flags type.
7038 (struct tui_source_element) <break_mode>: Change type. Rename
7039 from has_break.
7040 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7041 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7042 constants.
7043 * tui/tui-winsource.h: Fix comment.
7044
7045 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7046
7047 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7048 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7049 (store_fpregs_to_thread)
7050 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7051 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7052 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7053 (IWMMXT_REGS_SIZE): Add define.
7054 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7055 (fetch_vfp_regs, store_vfp_regs)
7056 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7057 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7058
7059 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7060
7061 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7062 defines.
7063 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7064 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7065 (ARM_INT_REGISTER_SIZE): ...to this.
7066 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7067 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7068 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7069 (arm_linux_collect_gregset, supply_nwfpe_register)
7070 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7071 defines.
7072 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7073 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7074 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7075 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7076 (arm_return_in_memory, arm_store_return_value)
7077 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7078 (arm_record_ld_st_multiple): Likewise.
7079 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7080 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7081
7082 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7083
7084 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7085 AARCH64_DISPLACED_MODIFIED_INSNS.
7086 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7087 (aarch64_displaced_step_copy_insn): Likewise.
7088 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7089 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7090 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7091 ARM_DISPLACED_MODIFIED_INSNS.
7092 * arm-tdep.c (arm_gdbarch_init): Likewise.
7093 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7094 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7095 (struct arm_displaced_step_closure): Use
7096 ARM_DISPLACED_MODIFIED_INSNS.
7097
7098 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7099
7100 * features/Makefile: Remove unused xml files.
7101 * features/aarch64.xml: Remove.
7102 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7103 * features/i386/amd64-avx-avx512.xml: Remove.
7104 * features/i386/amd64-avx-linux.xml: Remove.
7105 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7106 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7107 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7108 * features/i386/amd64-avx-mpx.xml: Remove.
7109 * features/i386/amd64-avx.xml: Remove.
7110 * features/i386/amd64-linux.xml: Remove.
7111 * features/i386/amd64-mpx-linux.xml: Remove.
7112 * features/i386/amd64-mpx.xml: Remove.
7113 * features/i386/amd64.xml: Remove.
7114 * features/i386/i386-avx-avx512-linux.xml: Remove.
7115 * features/i386/i386-avx-avx512.xml: Remove.
7116 * features/i386/i386-avx-linux.xml: Remove.
7117 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7118 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7119 * features/i386/i386-avx-mpx-linux.xml: Remove.
7120 * features/i386/i386-avx-mpx.xml: Remove.
7121 * features/i386/i386-avx.xml: Remove.
7122 * features/i386/i386-linux.xml: Remove.
7123 * features/i386/i386-mmx-linux.xml: Remove.
7124 * features/i386/i386-mmx.xml: Remove.
7125 * features/i386/i386-mpx-linux.xml: Remove.
7126 * features/i386/i386-mpx.xml: Remove.
7127 * features/i386/i386.xml: Remove.
7128 * features/i386/x32-avx-avx512-linux.xml: Remove.
7129 * features/i386/x32-avx-linux.xml: Remove.
7130 * features/i386/x32-linux.xml: Remove.
7131
7132 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7133
7134 * regformats/aarch64.dat: Remove.
7135 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7136 * regformats/i386/amd64-avx-linux.dat: Remove.
7137 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7138 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7139 * regformats/i386/amd64-linux.dat: Remove.
7140 * regformats/i386/amd64-mpx-linux.dat: Remove.
7141 * regformats/i386/amd64.dat: Remove.
7142 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7143 * regformats/i386/i386-avx-linux.dat: Remove.
7144 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7145 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7146 * regformats/i386/i386-linux.dat: Remove.
7147 * regformats/i386/i386-mmx-linux.dat: Remove.
7148 * regformats/i386/i386-mpx-linux.dat: Remove.
7149 * regformats/i386/i386.dat: Remove.
7150 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7151 * regformats/i386/x32-avx-linux.dat: Remove.
7152 * regformats/i386/x32-linux.dat: Remove.
7153
7154 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7155
7156 * aarch64-tdep.c: Remove xml self tests.
7157 * amd64-linux-tdep.c: Likewise.
7158 * amd64-tdep.c: Likewise.
7159 * i386-linux-tdep.c: Likewise.
7160 * i386-tdep.c: Likewise.
7161
7162 2019-07-03 Pedro Alves <palves@redhat.com>
7163
7164 PR cli/24732
7165 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7166 (pipe_cmd_option_defs): New.
7167 (make_pipe_cmd_options_def_group): New.
7168 (pipe_command): Use gdb::option::process_options.
7169 (pipe_command_completer): New function.
7170 (_initialize_cli_cmds): Install completer for "pipe" command.
7171
7172 2019-07-03 Pedro Alves <palves@redhat.com>
7173
7174 * cli/cli-option.c (union option_value) <string>: New field.
7175 (struct option_def_and_value): Add ctor, move ctor, dtor and
7176 use DISABLE_COPY_AND_ASSIGN.
7177 (option_def_and_value::clear_value): New.
7178 (parse_option, save_option_value_in_ctx, get_val_type_str)
7179 (add_setshow_cmds_for_options): Handle var_string.
7180 * cli-option.h (union option_def::var_address) <string>: New
7181 field.
7182 (struct string_option_def): New.
7183 * maint-test-options.c (struct test_options_opts): Add default
7184 ctor and use DISABLE_COPY_AND_ASSIGN.
7185 <string_opt>: New field.
7186 (test_options_opts::~test_options_opts): New.
7187 (test_options_opts::dump): Also dump "-string".
7188 (test_options_option_defs): Install "string.
7189
7190 2019-07-03 Pedro Alves <palves@redhat.com>
7191
7192 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7193 option_value with a null enumeration.
7194 (complete_options): Save the option values in the context.
7195 (save_option_value_in_ctx): New, factored out from ...
7196 (process_options): ... here.
7197 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7198 of the function.
7199 * maint-test-options.c (test_options_opts::dump): New, factored
7200 out from ...
7201 (maintenance_test_options_command_mode): ... here.
7202 (maintenance_test_options_command_completion_result): Delete.
7203 (maintenance_test_options_command_completion_text): Update
7204 comment.
7205 (maintenance_show_test_options_completion_result): Change
7206 prototype. Just print
7207 maintenance_test_options_command_completion_text.
7208 (save_completion_result): New.
7209 (maintenance_test_options_completer_mode): Pass options context to
7210 complete_options, and then save a dump.
7211 (_initialize_maint_test_options): Use add_cmd to install "maint
7212 show test-options-completion-result".
7213
7214 2019-07-03 Pedro Alves <palves@redhat.com>
7215
7216 * NEWS (New commands): Mention "with" and "maint with".
7217 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7218 (with_command, with_command_completer): New.
7219 (pipe_command): Adjust to new repeat_previous
7220 interface.
7221 (_initialize_cli_cmds): Install the "with" command and its "w"
7222 alias.
7223 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7224 declarations.
7225 * cli/cli-setshow.c (parse_cli_var_uinteger)
7226 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7227 argument strings for all var_types.
7228 (get_setshow_command_value_string): New, factored out from ...
7229 (do_show_command): ... this.
7230 * cli/cli-setshow.h: Include <string>.
7231 (get_setshow_command_value_string): Declare.
7232 * command.h (repeat_previous): Now returns const char *. Adjust
7233 comment.
7234 * maint.c: Include "cli/cli-cmds.h".
7235 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7236 (_initialize_maint_cmds): Register the "maintenance with" command.
7237 * top.c (repeat_previous): Move bits from pipe_command here:
7238 Return the saved command line, if any; error out if there's no
7239 command to relaunch.
7240
7241 2019-07-03 Pedro Alves <palves@redhat.com>
7242
7243 * NEWS (New commands): Mention "maint set/show test-settings"
7244 instead of "maint test-settings".
7245 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7246 (maintenance_test_settings_set_list): Rename to ...
7247 (maintenance_set_test_settings_list): ... this.
7248 (maintenance_test_settings_show_list): Rename to ...
7249 (maintenance_show_test_settings_list): ... this.
7250 (maintenance_test_settings_cmd): Delete.
7251 (maintenance_test_settings_set_cmd): ...
7252 (maintenance_set_test_settings_cmd): ... this.
7253 (maintenance_test_settings_show_cmd): ...
7254 (maintenance_show_test_settings_cmd): ... this.
7255 (maintenance_test_settings_show_value_cmd):
7256 (maintenance_show_test_settings_value_cmd): ... this.
7257 (_initialize_maint_test_settings): No longer install the "maint
7258 test-settings" prefix command. Rename "maint test-settings set"
7259 to "maint set test-settings", and "maint test-settings show" to
7260 "maint show test-settings". Adjust all subcommands.
7261
7262 2019-07-03 Pedro Alves <palves@redhat.com>
7263
7264 * maint-test-settings.c: Fix file's intro comment. Replace all
7265 references to "test-options" with references to "test-settings",
7266 in comments.
7267
7268 2019-07-03 Pedro Alves <palves@redhat.com>
7269
7270 * maint-test-settings.c (maintenance_test_settings_xxx)
7271 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7272 New.
7273 (maintenance_test_settings_enums): Use them.
7274 (maintenance_test_settings_enum): Default to
7275 maintenance_test_settings_xxx.
7276 (_initialize_maint_test_settings): Initialize
7277 MAINTENANCE_TEST_SETTINGS_FILENAME.
7278
7279 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7280
7281 * breakpoint.h (remove_breakpoints_inf): Change return type to
7282 void, move function documentation here.
7283 * breakpoint.c (remove_breakpoints_inf): Change return type to
7284 void, move function documentation to header.
7285
7286 2019-07-02 Pedro Alves <palves@redhat.com>
7287
7288 * NEWS (Completion improvements): Mention "info threads".
7289 * thread.c (struct info_threads_opts, info_threads_option_defs)
7290 (make_info_threads_options_def_group): New.
7291 (info_threads_command): Use gdb::option::process_options.
7292 (info_threads_command_completer): New.
7293 (_initialize_thread): Use gdb::option::build_help to build the
7294 help text for "info threads".
7295
7296 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7297
7298 * defs.h (generic_load): Move from here...
7299 * symfile.h (generic_load): ... to here. Rename name parameter
7300 to args.
7301 * symfile.c (generic_load): Add comment.
7302
7303 2019-07-01 Tom Tromey <tromey@adacore.com>
7304
7305 * dwarf2read.c
7306 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7307 declaration of without_params. Fix formatting.
7308
7309 2019-07-01 Tom Tromey <tromey@adacore.com>
7310
7311 * ada-exp.y (find_primitive_type): Update.
7312 * ada-lang.h (ada_lookup_symbol): Update.
7313 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7314 parameter.
7315 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7316
7317 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7318
7319 PR breakpoints/24541
7320 * gdbarch.c: Regenerate.
7321 * gdbarch.h: Regenerate.
7322 * gdbarch.sh: Add 'stap_adjust_register'.
7323 * i386-tdep.c: Include '<unordered_set>'.
7324 (i386_stap_adjust_register): New function.
7325 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7326 * stap-probe.c (stap_parse_register_operand): Call
7327 'gdbarch_stap_adjust_register'.
7328
7329 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7330
7331 PR python/24742
7332 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7333 * python/python.c (do_start_initialization): Use 'xmalloc'
7334 instead of 'PyMem_Malloc'.
7335
7336 2019-06-28 Tom Tromey <tromey@adacore.com>
7337
7338 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7339 for Ada.
7340
7341 2019-06-27 Tom Tromey <tromey@adacore.com>
7342
7343 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7344 objfile_key.
7345 (arm_find_mapping_symbol, arm_record_special_symbol)
7346 (_initialize_arm_tdep): Update.
7347 (arm_objfile_data_free): Remove.
7348
7349 2019-06-27 Tom Tromey <tromey@adacore.com>
7350
7351 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7352 to cp_print_static_field.
7353
7354 2019-06-26 Tom Tromey <tromey@adacore.com>
7355
7356 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7357 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7358 declare.
7359
7360 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7361
7362 * features/aarch64-core.c (create_feature_aarch64_core):
7363 Regenerate.
7364 * features/aarch64-core.xml: Add cpsr flags.
7365
7366 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7367
7368 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7369 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7370
7371 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7372
7373 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7374 field.
7375 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7376 use.
7377 (arm_record_special_symbol): Don't insert new symbol in sorted
7378 position, push it at the end.
7379
7380 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7381
7382 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7383 (arm_mapping_symbol_s): Remove.
7384 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7385 (arm_mapping_symbol_vec): New typedef.
7386 (struct arm_per_objfile): Add constructor.
7387 <section_maps>: Change type to
7388 std::unique_ptr<arm_mapping_symbol_vec[]>.
7389 (arm_compare_mapping_symbols): Remove.
7390 (arm_find_mapping_symbol): Adjust to section_maps type change.
7391 (arm_objfile_data_free): Call delete on arm_per_objfile.
7392 (arm_record_special_symbol): Adjust to section_maps type change.
7393 Allocate arm_per_objfile with new.
7394
7395 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7396
7397 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7398 with the command prefix.
7399
7400 2019-06-25 Tom Tromey <tom@tromey.com>
7401
7402 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7403 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7404
7405 2019-06-25 Tom Tromey <tom@tromey.com>
7406
7407 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7408 type.
7409 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7410 protected.
7411
7412 2019-06-25 Tom Tromey <tom@tromey.com>
7413
7414 * tui/tui-winsource.c
7415 (tui_source_window_base::set_is_exec_point_at): Add check against
7416 LOA_ADDRESS.
7417
7418 2019-06-25 Tom Tromey <tom@tromey.com>
7419
7420 * tui/tui-source.c (tui_set_source_content): Don't check before
7421 xfree.
7422 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7423
7424 2019-06-25 Tom Tromey <tom@tromey.com>
7425
7426 * tui/tui-winsource.h (tui_update_source_window_as_is)
7427 (tui_alloc_source_buffer, tui_line_is_displayed)
7428 (tui_addr_is_displayed): Change type of win_info.
7429 * tui/tui-winsource.c (tui_update_source_window_as_is)
7430 (tui_clear_source_content, tui_show_source_line)
7431 (tui_show_source_content, tui_source_window_base::refill)
7432 (tui_source_window_base::set_is_exec_point_at)
7433 (tui_source_window_base::set_is_exec_point_at)
7434 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7435 (tui_alloc_source_buffer, tui_line_is_displayed)
7436 (tui_addr_is_displayed): Change type of win_info. Update.
7437 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7438 (tui_source_window_base::do_make_visible_with_new_height):
7439 Update.
7440 * tui/tui-source.c (tui_set_source_content)
7441 (tui_set_source_content_nil)
7442 (tui_source_window::do_scroll_vertical): Update.
7443 * tui/tui-layout.c (show_layout): Update.
7444 * tui/tui-disasm.c (tui_set_disassem_content)
7445 (tui_disasm_window::do_scroll_vertical): Update.
7446 * tui/tui-data.h (tui_win_content): Remove.
7447 (struct tui_gen_win_info) <content, content_size>: Remove.
7448 (struct tui_source_element): Add initializers and destructor.
7449 (union tui_which_element, struct tui_win_element): Remove.
7450 (struct tui_source_window_base) <content>: New field.
7451 (struct tui_data_window): Remove destructor.
7452 (tui_alloc_content, tui_free_win_content)
7453 (tui_free_all_source_wins_content): Don't declare.
7454 * tui/tui-data.c (tui_initialize_static_data): Update.
7455 (init_content_element, tui_alloc_content): Remove.
7456 (~tui_gen_win_info): Update.
7457 (~tui_data_window, tui_free_all_source_wins_content)
7458 (tui_free_win_content, free_content, free_content_elements):
7459 Remove.
7460
7461 2019-06-25 Tom Tromey <tom@tromey.com>
7462
7463 * tui/tui-winsource.h (tui_clear_source_content)
7464 (tui_erase_source_content, tui_show_source_content): Change type
7465 of win_info.
7466 * tui/tui-winsource.c (tui_clear_source_content)
7467 (tui_erase_source_content, tui_show_source_content): Change type
7468 of win_info.
7469 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7470 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7471 win_info.
7472 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7473 win_info.
7474 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7475
7476 2019-06-25 Tom Tromey <tom@tromey.com>
7477
7478 * tui/tui-winsource.c (tui_clear_source_content)
7479 (tui_source_window_base::set_is_exec_point_at): Update.
7480 * tui/tui-source.c (tui_set_source_content_nil): Update.
7481 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7482 a bool.
7483 * tui/tui-data.c (init_content_element): Update.
7484
7485 2019-06-25 Tom Tromey <tom@tromey.com>
7486
7487 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7488 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7489 * tui/tui-layout.c (init_and_make_win): Update.
7490 * tui/tui.h (enum tui_win_type): Update.
7491 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7492 tui_win_is_auxillary.
7493 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7494 tui_win_is_auxillary.
7495
7496 2019-06-25 Tom Tromey <tom@tromey.com>
7497
7498 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7499 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7500 (tui_delete_data_content_windows, tui_display_all_data)
7501 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7502 Update.
7503 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7504 * tui/tui-regs.c (tui_last_regs_line_no)
7505 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7506 (tui_show_registers): Update.
7507 (tui_show_register_group): Return void. Update.
7508 (tui_display_registers_from, tui_display_reg_element_at_line)
7509 (tui_display_registers_from_line, tui_check_register_values):
7510 Update.
7511 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7512 member.
7513 (struct tui_data_window) <regs_content>: Now a std::vector.
7514 <regs_content_count>: Remove.
7515 (tui_add_content_elements, tui_free_data_content): Don't declare.
7516 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7517 (init_content_element): Remove DATA_WIN case. Add assert.
7518 (tui_add_content_elements): Remove.
7519 (tui_data_window): Update.
7520 (tui_free_data_content): Remove.
7521 (free_content_elements): Remove DATA_WIN case.
7522
7523 2019-06-25 Tom Tromey <tom@tromey.com>
7524
7525 * tui/tui-data.c (tui_data_item_window): Update.
7526 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7527 * tui/tui-windata.c (tui_display_all_data)
7528 (tui_display_data_from_line): Update.
7529 (tui_check_data_values): Remove.
7530 * tui/tui-regs.c (tui_show_register_group)
7531 (tui_display_reg_element_at_line): Update.
7532 * tui/tui-hooks.c (tui_register_changed)
7533 (tui_refresh_frame_and_register_information): Call
7534 tui_check_register_values.
7535 * tui/tui-data.h (struct tui_data_window) <data_content,
7536 data_content_count, data_type>: Remove.
7537 (enum tui_data_type): Remove.
7538
7539 * tui/tui-data.c (tui_data_window::clear_detail)
7540 (~tui_data_window): Update.
7541
7542 2019-06-25 Tom Tromey <tom@tromey.com>
7543
7544 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7545 declare.
7546 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7547 Rename from tui_first_data_item_displayed. Update.
7548 (tui_data_window::refresh_all)
7549 (tui_data_window::do_scroll_vertical): Update.
7550 * tui/tui-data.h (struct tui_data_window)
7551 <first_data_item_displayed>: Declare new method.
7552
7553 2019-06-25 Tom Tromey <tom@tromey.com>
7554
7555 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7556 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7557 contents...
7558 (tui_initialize_static_data): ...here.
7559
7560 2019-06-25 Tom Tromey <tom@tromey.com>
7561
7562 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7563 (tui_display_registers_from, tui_check_register_values): Update.
7564 (tui_display_register): Remove win_info parameter; update.
7565 (tui_get_register): Change type of parameters.
7566 * tui/tui-data.h (struct tui_data_element): Remove.
7567 (union tui_which_element) <data>: Remove.
7568 <data_window>: Change type.
7569 (struct tui_data_item_window): New.
7570 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7571 case. Add assert.
7572 (~tui_data_item_window): New destructor.
7573 (free_content_elements): Remove DATA_ITEM_WIN case.
7574
7575 2019-06-25 Tom Tromey <tom@tromey.com>
7576
7577 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7578 Remove.
7579
7580 2019-06-25 Tom Tromey <tom@tromey.com>
7581
7582 * tui/tui-data.h (struct tui_command_element): Remove.
7583 (union tui_which_element) <command>: Remove.
7584 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
7585 assert.
7586 (free_content_elements): Remove CMD_WIN case.
7587
7588 2019-06-25 Tom Tromey <tom@tromey.com>
7589
7590 * tui/tui-layout.c (tui_set_layout): Update.
7591 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7592 * tui/tui-data.c (layout_def): Update.
7593
7594 2019-06-25 Tom Tromey <tom@tromey.com>
7595
7596 * tui/tui-wingeneral.c (tui_refresh_all): Update.
7597 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7598 (tui_source_window_base::set_new_height): Update.
7599 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7600 Update.
7601 (tui_set_locator_fullname, tui_set_locator_info)
7602 (tui_show_frame_info): Update.
7603 * tui/tui-source.c (tui_set_source_content)
7604 (tui_source_is_displayed): Update.
7605 * tui/tui-layout.c (show_source_disasm_command, show_data)
7606 (show_source_or_disasm_and_command): Update.
7607 * tui/tui-disasm.c (tui_set_disassem_content)
7608 (tui_get_begin_asm_address): Update.
7609 * tui/tui-data.h (struct tui_locator_element): Remove.
7610 (union tui_which_element) <locator>: Remove.
7611 (struct tui_locator_window): New.
7612 (tui_locator_win_info_ptr): Change return type.
7613 * tui/tui-data.c (_locator): Change type.
7614 (tui_locator_win_info_ptr): Change return type.
7615 (init_content_element): Remove LOCATOR_WIN case. Add assert.
7616 (tui_alloc_content): Add assert.
7617
7618 2019-06-25 Tom Tromey <tom@tromey.com>
7619
7620 * tui/tui-winsource.c
7621 (tui_exec_info_window::maybe_allocate_content): New method.
7622 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7623 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7624 (make_source_or_disasm_window): Add cast.
7625 * tui/tui-data.h (union tui_which_element) <simple_string>:
7626 Remove.
7627 (struct tui_source_info): New.
7628 (struct tui_source_window_base) <execution_info>: Change type.
7629 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7630 case, and add assert.
7631 (tui_alloc_content): Add assert.
7632
7633 2019-06-25 Tom Tromey <tom@tromey.com>
7634
7635 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7636 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7637 * tui/tui-data.c (tui_alloc_win_info): Remove.
7638
7639 2019-06-25 Tom Tromey <tom@tromey.com>
7640
7641 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7642 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7643 can_highlight.
7644
7645 2019-06-25 Tom Tromey <tom@tromey.com>
7646
7647 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7648 make_visible_with_new_height method.
7649 (tui_win_info::make_visible_with_new_height): New method.
7650 (tui_source_window_base::do_make_visible_with_new_height)
7651 (tui_data_window::do_make_visible_with_new_height)
7652 (tui_cmd_window::do_make_visible_with_new_height): New methods.
7653 (make_visible_with_new_height): Remove.
7654 (tui_resize_all, tui_adjust_win_heights): Use
7655 make_visible_with_new_height method.
7656 * tui/tui-data.h (struct tui_win_info)
7657 <do_make_visible_with_new_height, make_visible_with_new_height>:
7658 New methods.
7659 (struct tui_source_window_base, struct tui_data_window)
7660 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7661 methods.
7662
7663 2019-06-25 Tom Tromey <tom@tromey.com>
7664
7665 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7666 method.
7667 (update_tab_width): Call update_tab_width method.
7668 * tui/tui-data.h (struct tui_win_info)
7669 (struct tui_source_window_base) <update_tab_width>: New methods.
7670
7671 2019-06-25 Tom Tromey <tom@tromey.com>
7672
7673 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7674 parameter.
7675 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7676 parameter.
7677 (tui_gen_win_info::make_visible): Update.
7678 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7679 parameter.
7680 * tui/tui-data.h (enum tui_box): New enum.
7681 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7682
7683 2019-06-25 Tom Tromey <tom@tromey.com>
7684
7685 * tui/tui-layout.c (make_source_or_disasm_window): Always use
7686 init_and_make_win for EXEC_INFO_WIN.
7687 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7688 longer inline.
7689 (struct tui_win_info) <~tui_win_info>: Inline.
7690 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7691 Don't declare.
7692 * tui/tui-data.c (source_win, disasm_win): Remove globals.
7693 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7694 Remove.
7695 (tui_initialize_static_data): Update.
7696 (~tui_gen_win_info): Handle more cleanup here.
7697 (~tui_source_window_base): Delete "execution_info".
7698 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7699
7700 2019-06-25 Tom Tromey <tom@tromey.com>
7701
7702 * tui/tui-layout.c (make_command_window): Don't set
7703 can_highlight.
7704 (show_source_disasm_command): Call the reset method.
7705 (show_data): Don't set can_highlight. Call the reset method.
7706 (tui_gen_win_info::reset): Rename from init_gen_win_info
7707 (init_and_make_win): Simplify. Return tui_gen_win_info.
7708 (show_source_or_disasm_and_command): Call the reset method.
7709 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7710 (struct tui_cmd_window): Set can_highlight.
7711
7712 2019-06-25 Tom Tromey <tom@tromey.com>
7713
7714 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7715 from make_visible.
7716 (tui_make_visible, tui_make_invisible): Rewrite.
7717 (tui_win_info::make_visible): Remove.
7718 (tui_source_window_base::make_visible): Update.
7719 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7720 method. Moved from...
7721 (struct tui_win_info) <make_visible>: ...here.
7722
7723 2019-06-25 Tom Tromey <tom@tromey.com>
7724
7725 * tui/tui-winsource.c
7726 (tui_source_window_base::do_scroll_horizontal): Remove direction
7727 parameter.
7728 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7729 direction parameter.
7730 * tui/tui-win.c (tui_win_info::forward_scroll)
7731 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7732 (tui_win_info::right_scroll): Update.
7733 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7734 direction parameter.
7735 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7736 direction parameter.
7737 * tui/tui-data.h (enum tui_scroll_direction): Remove.
7738 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7739 Remove direction parameter.
7740 (struct tui_source_window_base, struct tui_source_window)
7741 (struct tui_disasm_window, struct tui_data_window)
7742 (struct tui_cmd_window): Update.
7743
7744 2019-06-25 Tom Tromey <tom@tromey.com>
7745
7746 * tui/tui-winsource.h (tui_set_exec_info_content)
7747 (tui_show_exec_info_content, tui_erase_exec_info_content)
7748 (tui_clear_exec_info_content, tui_update_exec_info): Change
7749 argument to tui_source_window_base.
7750 * tui/tui-winsource.c (tui_set_exec_info_content)
7751 (tui_show_exec_info_content, tui_erase_exec_info_content)
7752 (tui_clear_exec_info_content, tui_update_exec_info): Change
7753 argument to tui_source_window_base.
7754
7755 2019-06-25 Tom Tromey <tom@tromey.com>
7756
7757 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7758 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7759
7760 2019-06-25 Tom Tromey <tom@tromey.com>
7761
7762 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7763 check.
7764
7765 2019-06-25 Tom Tromey <tom@tromey.com>
7766
7767 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7768 type to void.
7769 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7770 type to void.
7771 * tui/tui-source.c (tui_set_source_content): Update.
7772 * tui/tui-disasm.c (tui_set_disassem_content): Update.
7773
7774 2019-06-25 Tom Tromey <tom@tromey.com>
7775
7776 * tui/tui-win.c (window_name_completer, tui_set_focus)
7777 (tui_all_windows_info): Use name method.
7778 * tui/tui-data.h (struct tui_gen_win_info)
7779 (struct tui_source_window, struct tui_disasm_window)
7780 (struct tui_data_window, struct tui_cmd_window) <name>: New
7781 method.
7782 (tui_win_name): Don't declare.
7783 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7784 (tui_win_name): Remove.
7785
7786 2019-06-25 Tom Tromey <tom@tromey.com>
7787
7788 * tui/tui-winsource.h (tui_update_source_window)
7789 (tui_update_source_window_as_is): Change parameter type.
7790 * tui/tui-winsource.c (tui_update_source_window): Change win_info
7791 to be a tui_source_window_base.
7792 (tui_update_source_window_as_is): Likewise.
7793 * tui/tui-win.c (make_visible_with_new_height): Update.
7794
7795 2019-06-25 Tom Tromey <tom@tromey.com>
7796
7797 * tui/tui-winsource.c (tui_erase_source_content)
7798 (tui_show_source_content, tui_show_exec_info_content)
7799 (tui_erase_exec_info_content): Use refresh_window method.
7800 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7801 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7802 from tui_refresh_win.
7803 (tui_data_window::refresh_window): New method.
7804 (tui_win_info::refresh, tui_source_window_base::refresh)
7805 (tui_refresh_all): Use refresh_window method.
7806 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7807 method.
7808 * tui/tui-regs.c (tui_display_register): Call refresh_window
7809 method.
7810 * tui/tui-layout.c (show_source_disasm_command)
7811 (show_source_or_disasm_and_command): Call refresh_window method.
7812 * tui/tui-data.h (struct tui_gen_win_info)
7813 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7814 New method.
7815
7816 2019-06-25 Tom Tromey <tom@tromey.com>
7817
7818 * tui/tui.c (tui_rl_other_window, tui_enable)
7819 (tui_is_window_visible, tui_get_command_dimension): Update.
7820 * tui/tui-winsource.c (tui_update_source_window_as_is)
7821 (tui_clear_source_content, tui_erase_source_content)
7822 (tui_show_source_line, tui_source_window_base::refill)
7823 (tui_source_window_base::do_scroll_horizontal)
7824 (tui_source_window_base::set_is_exec_point_at)
7825 (tui_update_breakpoint_info, tui_set_exec_info_content)
7826 (tui_alloc_source_buffer, tui_line_is_displayed)
7827 (tui_addr_is_displayed): Update.
7828 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7829 (tui_check_and_display_highlight_if_needed)
7830 (tui_win_info::make_visible, tui_win_info::refresh)
7831 (tui_refresh_all): Update.
7832 * tui/tui-windata.c (tui_first_data_item_displayed)
7833 (tui_delete_data_content_windows, tui_erase_data_content)
7834 (tui_display_all_data, tui_data_window::refresh_all)
7835 (tui_check_data_values): Update.
7836 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
7837 (tui_set_win_focus_to, tui_win_info::forward_scroll)
7838 (tui_win_info::backward_scroll, tui_refresh_all_win)
7839 (tui_resize_all, tui_set_focus, tui_all_windows_info)
7840 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
7841 (tui_source_window_base::set_new_height)
7842 (tui_data_window::set_new_height)
7843 (make_invisible_and_set_new_height)
7844 (make_visible_with_new_height, new_height_ok)
7845 (parse_scrolling_args): Update.
7846 * tui/tui-stack.c (tui_show_frame_info): Update.
7847 * tui/tui-source.c (tui_set_source_content)
7848 (tui_set_source_content_nil, tui_source_is_displayed)
7849 (tui_source_window::do_scroll_vertical): Update.
7850 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7851 (tui_display_registers_from, tui_display_reg_element_at_line)
7852 (tui_check_register_values, tui_reg_command): Update.
7853 * tui/tui-layout.c (tui_default_win_height)
7854 (show_source_disasm_command, show_data, init_and_make_win)
7855 (show_source_or_disasm_and_command): Update.
7856 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
7857 (tui_redisplay_readline, tui_mld_flush)
7858 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
7859 (tui_getc): Update.
7860 * tui/tui-disasm.c (tui_set_disassem_content)
7861 (tui_disasm_window::do_scroll_vertical): Update.
7862 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
7863 Now virtual.
7864 (struct tui_win_info): Derive from tui_gen_win_info.
7865 <~tui_win_info>: Mark as override.
7866 <generic>: Remove member.
7867 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
7868 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
7869 (~tui_data_window, ~tui_win_info)
7870 (tui_free_all_source_wins_content): Update.
7871 * tui/tui-command.c (tui_refresh_cmd_win): Update.
7872
7873 2019-06-25 Tom Tromey <tom@tromey.com>
7874
7875 * tui/tui-layout.c (init_and_make_win): Use new.
7876 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
7877 destructor, initializers.
7878 (tui_alloc_generic_win_info): Don't declare.
7879 * tui/tui-data.c (_locator): Add argument to constructor.
7880 (source_win, disasm_win): New globals.
7881 (exec_info): Remove.
7882 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7883 Update.
7884 (tui_alloc_generic_win_info): Remove.
7885 (init_content_element): Use new.
7886 (tui_win_info::tui_win_info): Update.
7887 (free_content_elements) <case DATA_WIN>: Use delete.
7888
7889 2019-06-25 Tom Tromey <tom@tromey.com>
7890
7891 * tui/tui-wingeneral.c (tui_refresh_win): Update.
7892 * tui/tui-windata.c (tui_first_data_item_displayed)
7893 (tui_delete_data_content_windows): Update.
7894 * tui/tui-win.c (tui_data_window::set_new_height): Update.
7895 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7896 (tui_display_registers_from, tui_check_register_values): Update.
7897 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
7898 pointer.
7899 * tui/tui-data.c (init_content_element): Update. Allocate the new
7900 window.
7901 (tui_free_data_content): Update.
7902 (free_content_elements) <case DATA_WIN>: Free the window.
7903
7904 2019-06-25 Tom Tromey <tom@tromey.com>
7905
7906 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
7907 Update.
7908 * tui/tui-layout.c (make_command_window)
7909 (show_source_disasm_command, show_data, init_and_make_win)
7910 (show_source_or_disasm_and_command): Update.
7911 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
7912 method.
7913 <can_highight, is_highlighted>: Now bool.
7914 (tui_set_win_highlight): Don't declare.
7915 * tui/tui-data.c (tui_set_win_highlight): Remove.
7916
7917 2019-06-25 Tom Tromey <tom@tromey.com>
7918
7919 * tui/tui-wingeneral.c (make_visible): Remove check of window
7920 type.
7921
7922 2019-06-25 Tom Tromey <tom@tromey.com>
7923
7924 * tui/tui-win.c (tui_win_info::max_height)
7925 (tui_cmd_window::max_height): New methods.
7926 (new_height_ok): Call max_height.
7927 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
7928 <max_height>: New method.
7929
7930 2019-06-25 Tom Tromey <tom@tromey.com>
7931
7932 * tui/tui-win.c (tui_source_window_base::set_new_height)
7933 (tui_data_window::set_new_height): New methods.
7934 (make_invisible_and_set_new_height): Call set_new_height method.
7935 * tui/tui-data.h (struct tui_win_info)
7936 (struct tui_source_window_base, struct tui_data_window)
7937 <set_new_height>: New method.
7938
7939 2019-06-25 Tom Tromey <tom@tromey.com>
7940
7941 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
7942 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
7943 tui_refresh_data_win.
7944 * tui/tui-win.c (tui_source_window_base::refresh_all): New
7945 method.
7946 (tui_refresh_all_win): Call the refresh_all method.
7947 (tui_set_focus): Likewise.
7948 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
7949 (struct tui_source_window_base, struct tui_data_window) <refresh>:
7950 Likewise.
7951
7952 2019-06-25 Tom Tromey <tom@tromey.com>
7953
7954 * tui/tui-winsource.h (tui_refill_source_window)
7955 (tui_set_is_exec_point_at): Don't declare.
7956 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
7957 (tui_source_window_base::refill): Rename from
7958 tui_refill_source_window.
7959 (tui_source_window_base::do_scroll_horizontal): Update.
7960 (tui_source_window_base::set_is_exec_point_at): Rename from
7961 tui_set_is_exec_point_at.
7962 (tui_update_all_breakpoint_info): Update.
7963 * tui/tui-stack.c (tui_show_frame_info): Update.
7964 * tui/tui-layout.c (show_data): Add cast.
7965 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
7966 * tui/tui-data.h (struct tui_source_window_base) <refill,
7967 set_is_exec_point_at>: New methods.
7968 (tui_source_windows, tui_add_to_source_windows): Update types.
7969 (tui_add_to_source_windows): Remove redundant declaration.
7970 * tui/tui-data.c (source_windows): Store tui_source_window_base.
7971 (tui_source_windows): Change return type.
7972 (tui_clear_source_windows_detail): Update.
7973 (tui_add_to_source_windows): Change type of parameter.
7974 (tui_free_all_source_wins_content): Update.
7975
7976 2019-06-25 Tom Tromey <tom@tromey.com>
7977
7978 * tui/tui-wingeneral.c (tui_win_info::refresh)
7979 (tui_source_window_base::refresh): New methods.
7980 (tui_refresh_all): Call the refresh method.
7981 * tui/tui-data.h (struct tui_win_info)
7982 (struct tui_source_window_base) <refresh>: New method.
7983
7984 2019-06-25 Tom Tromey <tom@tromey.com>
7985
7986 * tui/tui.h (tui_is_window_visible): Return bool.
7987 * tui/tui.c (tui_is_window_visible): Return bool.
7988 * tui/tui-wingeneral.c (tui_make_window, make_visible)
7989 (tui_make_visible, tui_make_invisible)
7990 (tui_win_info::make_visible)
7991 (tui_source_window_base::make_visible, make_all_visible)
7992 (tui_make_all_visible, tui_make_all_invisible): Update.
7993 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
7994 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
7995 bool.
7996 (struct tui_win_info, struct tui_source_window_base)
7997 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
7998 * tui/tui-data.c (tui_init_generic_part): Update.
7999
8000 2019-06-25 Tom Tromey <tom@tromey.com>
8001
8002 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8003 (tui_source_window_base::make_visible): New methods.
8004 (make_all_visible): Make method call.
8005 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8006 (struct tui_source_window_base, struct tui_cmd_window): Override
8007 make_visible.
8008 (tui_win_is_source_type): Don't declare.
8009 * tui/tui-data.c (tui_win_is_source_type): Remove.
8010
8011 2019-06-25 Tom Tromey <tom@tromey.com>
8012
8013 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8014 NULL check.
8015
8016 2019-06-25 Tom Tromey <tom@tromey.com>
8017
8018 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8019 Inline constructor. Add initializers for members.
8020 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8021 constructors; now inline in class.
8022
8023 2019-06-25 Tom Tromey <tom@tromey.com>
8024
8025 * tui/tui-regs.c (tui_show_registers): Update.
8026 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8027 bool.
8028 * tui/tui-data.c (tui_data_window::clear_detail)
8029 (tui_data_window): Update.
8030
8031 2019-06-25 Tom Tromey <tom@tromey.com>
8032
8033 * tui/tui-windata.c (tui_display_all_data)
8034 (tui_display_data_from_line, tui_display_data_from)
8035 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8036 Update.
8037 * tui/tui-regs.c (tui_last_regs_line_no)
8038 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8039 (tui_show_registers, tui_show_register_group)
8040 (tui_display_registers_from, tui_display_reg_element_at_line)
8041 (tui_display_registers_from_line, tui_check_register_values)
8042 (tui_reg_next, tui_reg_prev): Update.
8043 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8044 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8045 tui_data_window.
8046 (struct tui_win_info) <detail>: Remove. Add new fields from
8047 tui_data_info.
8048 (TUI_DATA_WIN): Add cast.
8049 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8050 (~tui_data_window): Simplify.
8051
8052 2019-06-25 Tom Tromey <tom@tromey.com>
8053
8054 * tui/tui-layout.c (show_source_disasm_command)
8055 (show_source_or_disasm_and_command): Update.
8056 * tui/tui-io.c (update_cmdwin_start_line)
8057 (tui_redisplay_readline): Update.
8058 * tui/tui-data.h (struct tui_command_info): Remove.
8059 (struct tui_win_info) <detail>: Remove command_info member.
8060 (struct tui_data_window) <start_line>: New member, from
8061 tui_command_info.
8062 (TUI_CMD_WIN): Add casts.
8063
8064 2019-06-25 Tom Tromey <tom@tromey.com>
8065
8066 * tui/tui-winsource.c (tui_update_source_window)
8067 (tui_refill_source_window)
8068 (tui_source_window_base::do_scroll_horizontal)
8069 (tui_update_breakpoint_info, tui_set_exec_info_content)
8070 (tui_show_exec_info_content, tui_erase_exec_info_content)
8071 (tui_clear_exec_info_content): Update.
8072 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8073 Update.
8074 * tui/tui-win.c (make_invisible_and_set_new_height)
8075 (make_visible_with_new_height): Update.
8076 * tui/tui-source.c (tui_set_source_content)
8077 (tui_show_symtab_source): Update.
8078 * tui/tui-layout.c (extract_display_start_addr)
8079 (show_source_disasm_command, show_data)
8080 (make_source_or_disasm_window)
8081 (show_source_or_disasm_and_command): Update.
8082 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8083 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8084 "gdbarch".
8085 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8086 to tui_source_window_base.
8087 (struct tui_win_info) <detail>: Remove source_info member.
8088 (struct tui_source_window_base) <has_locator>: Inline.
8089 Move contents from tui_source_info; rename has_locator member to
8090 m_has_locator.
8091 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8092 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8093 header file.
8094 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8095 Simplify.
8096 (tui_free_all_source_wins_content): Cast to
8097 tui_source_window_base.
8098
8099 2019-06-25 Tom Tromey <tom@tromey.com>
8100
8101 * tui/tui-win.c (make_invisible_and_set_new_height)
8102 (make_visible_with_new_height): Call has_locator method.
8103 * tui/tui-layout.c (show_source_disasm_command, show_data)
8104 (show_source_or_disasm_and_command): Update for bool change.
8105 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8106 (tui_win_info) <has_locator>: New method.
8107 (struct tui_source_window_base) <has_locator>: New method.
8108 (tui_win_has_locator): Don't declare.
8109 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8110 from tui_win_has_locator.
8111 (tui_source_window_base): Use false, not FALSE.
8112
8113 2019-06-25 Tom Tromey <tom@tromey.com>
8114
8115 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8116 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8117 clear_detail method directly.
8118 (tui_clear_win_detail): Remove.
8119
8120 2019-06-25 Tom Tromey <tom@tromey.com>
8121
8122 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8123 "this", not TUI_DISASM_WIN.
8124
8125 2019-06-25 Tom Tromey <tom@tromey.com>
8126
8127 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8128 declare.
8129 * tui/tui-winsource.c
8130 (tui_source_window_base::do_scroll_horizontal): Rename from
8131 tui_horizontal_source_scroll.
8132 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8133 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8134 from tui_vertical_data_scroll.
8135 * tui/tui-win.h (tui_scroll): Don't declare.
8136 * tui/tui-win.c (tui_win_info::forward_scroll)
8137 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8138 (tui_win_info::right_scroll): Rename and update.
8139 (tui_scroll_forward_command, tui_scroll_backward_command)
8140 (tui_scroll_left_command, tui_scroll_right_command): Update.
8141 (tui_scroll): Remove.
8142 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8143 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8144 from tui_vertical_source_scroll.
8145 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8146 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8147 from tui_vertical_disassem_scroll.
8148 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8149 do_scroll_horizontal>: New methods.
8150 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8151 Likewise.
8152 (struct tui_source_window_base): Add do_scroll_horizontal.
8153 (struct tui_source_window, struct tui_disasm_window): Add
8154 do_scroll_vertical.
8155 (struct tui_data_window, struct tui_cmd_window): Add
8156 do_scroll_horizontal and do_scroll_vertical.
8157 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8158
8159 2019-06-25 Tom Tromey <tom@tromey.com>
8160
8161 * tui/tui-data.h (struct tui_source_window_base): New struct.
8162 (struct tui_source_window): Derive from tui_source_window_base.
8163 (struct tui_disasm_window): New struct.
8164 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8165 from tui_source_window::clear_detail.
8166 (tui_source_window_base): Rename from tui_source_window.
8167 (~tui_source_window_base): Rename from ~tui_source_window.
8168 (tui_alloc_win_info): Create a tui_disasm_window.
8169
8170 2019-06-25 Tom Tromey <tom@tromey.com>
8171
8172 * tui/tui-data.h (struct tui_source_window)
8173 (struct tui_data_window): Declare destructors.
8174 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8175 destructors.
8176 (tui_win_info): Simplify.
8177
8178 2019-06-25 Tom Tromey <tom@tromey.com>
8179
8180 * tui/tui-winsource.c (tui_display_main)
8181 (tui_update_source_windows_with_addr)
8182 (tui_update_all_breakpoint_info): Update.
8183 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8184 (new_height_ok, parse_scrolling_args): Update.
8185 * tui/tui-stack.c (tui_show_frame_info): Update.
8186 * tui/tui-data.h (struct tui_list): Remove.
8187 (tui_source_windows): Return a reference to a std::vector.
8188 * tui/tui-data.c (source_windows): Now a std::vector.
8189 (tui_source_windows): Change return type.
8190 (tui_clear_source_windows): Rewrite.
8191 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8192 (tui_free_all_source_wins_content): Rewrite.
8193
8194 2019-06-25 Tom Tromey <tom@tromey.com>
8195
8196 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8197 (struct tui_data_window, struct tui_cmd_window): Declare
8198 clear_detail method.
8199 * tui/tui-data.c (tui_source_window::clear_detail)
8200 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8201 methods.
8202 (tui_clear_win_detail): Simplify.
8203
8204 2019-06-25 Tom Tromey <tom@tromey.com>
8205
8206 * tui/tui-layout.c (make_source_window, make_disasm_window)
8207 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8208 Return the new window.
8209 (show_source_disasm_command, show_data)
8210 (show_source_or_disasm_and_command): Update.
8211
8212 2019-06-25 Tom Tromey <tom@tromey.com>
8213
8214 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8215 parameter. Return the new window.
8216 (show_source_disasm_command): Update and remove NULL check.
8217 (show_source_or_disasm_and_command): Update.
8218
8219 2019-06-25 Tom Tromey <tom@tromey.com>
8220
8221 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8222
8223 2019-06-25 Tom Tromey <tom@tromey.com>
8224
8225 * tui/tui-data.h (struct tui_win_info): Make constructor
8226 protected. Make destructor virtual. Add initializers.
8227 (tui_source_window, tui_data_window, tui_cmd_window): New
8228 classes.
8229 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8230 constructor. Add "type" parameter.
8231 (tui_source_window, tui_data_window, tui_cmd_window): New
8232 constructors.
8233 (tui_alloc_win_info): Instantiate the appropriate subclass.
8234
8235 2019-06-25 Tom Tromey <tom@tromey.com>
8236
8237 * tui/tui-win.c (tui_resize_all): Use delete.
8238 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8239 destructor.
8240 (tui_free_window): Don't declare.
8241 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8242 Update.
8243
8244 2019-06-25 Tom Tromey <tom@tromey.com>
8245
8246 * tui/tui-data.h (struct tui_win_info): Add constructor.
8247 * tui/tui-data.c (tui_alloc_win_info): Use new.
8248 (tui_free_window): Use delete.
8249
8250 2019-06-22 Tom Tromey <tom@tromey.com>
8251
8252 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8253 declare.
8254 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8255
8256 2019-06-22 Tom Tromey <tom@tromey.com>
8257
8258 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8259 declare.
8260 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8261
8262 2019-06-22 Tom de Vries <tdevries@suse.de>
8263
8264 * dwarf2read.c (create_addrmap_from_aranges)
8265 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8266 instead of '%zu'.
8267
8268 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
8269
8270 * dwarf2read.h (dwarf2_section_info_def): Remove.
8271 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8272 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8273 std::vector<dwarf2_section_info>.
8274 (struct dwo_file) <~dwo_file>: Remove.
8275 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8276 types field.
8277 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8278 (dwarf2_read_debug_names): Likewise.
8279 (create_debug_types_hash_table): Change parameter type to
8280 array_view, adjust code accordingly.
8281 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8282 (partial_die_info::fixup): Likewise.
8283 (determine_prefix): Likewise.
8284 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8285
8286 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8287
8288 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8289 gdb_bfd_ref_ptr.
8290 <~dwo_file>: Remove call to gdb_bfd_unref.
8291 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8292 gdb_bfd_ref_ptr::get.
8293
8294 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8295
8296 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8297 type to htab_up.
8298 * dwarf2read.c (struct dwo_file): Initialize fields.
8299 <~dwo_file>: New.
8300 (free_dwo_file): Remove, move content to ~dwo_file.
8301 (struct dwo_file_deleter): Remove.
8302 (dwo_file_up>: Remove custom deleter.
8303 (free_dwo_files): Remove.
8304 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8305 dwo_files.
8306 (process_skeletonless_type_units): Call unique_ptr::get.
8307 (allocate_dwo_file_hash_table): Add deleter to created hash
8308 table. Change return type to htab_up.
8309 (lookup_dwo_file_slot): Don't memset dwo_file, call
8310 unique_ptr::get.
8311 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8312 (create_dwo_unit_in_dwp_v2): Likewise.
8313 (open_and_init_dwo_file): Likewise.
8314 (free_dwo_file_from_slot): Remove.
8315
8316 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8317
8318 * dwarf2read.h (struct dwarf2_section_info) <readin,
8319 is_virtual>: Change type to bool.
8320 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8321 true instead of 1.
8322
8323 2019-06-19 Tom Tromey <tom@tromey.com>
8324
8325 * tui/tui-data.h (tui_init_content_element): Don't declare.
8326
8327 2019-06-19 Tom Tromey <tom@tromey.com>
8328
8329 * tui/tui-data.h (tui_init_win_info): Don't declare.
8330
8331 2019-06-19 Tom de Vries <tdevries@suse.de>
8332
8333 * dwarf2read.h (abstract_to_concrete): Change type to
8334 std::unordered_map<sect_offset, std::vector<sect_offset>,
8335 gdb::hash_enum<sect_offset>>.
8336
8337 2019-06-19 Tom Tromey <tromey@adacore.com>
8338
8339 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8340 EVAL_AVOID_SIDE_EFFECTS specially.
8341
8342 2019-06-19 Tom Tromey <tromey@adacore.com>
8343
8344 * source-cache.c (highlighter): New global.
8345 (source_cache::get_source_lines): Create a highlighter on demand.
8346
8347 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8348
8349 * defs.h (deprecated_interactive_hook): Delete declaration.
8350 * interps.c (clear_interpreter_hooks): Remove use of
8351 deprecated_interactive_hook.
8352 * top.c (deprecated_interactive_hook): Delete definition.
8353 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8354
8355 2019-06-18 Tom de Vries <tdevries@suse.de>
8356
8357 PR gdb/24515
8358 * dwarf2read.h (abstract_to_concrete): Change type from
8359 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8360 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8361 * dwarf2read.c (read_variable): Update.
8362 (dwarf2_fetch_die_loc_sect_off): Update.
8363
8364 2019-06-17 Tom de Vries <tdevries@suse.de>
8365
8366 PR gdb/24617
8367 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8368 accessing parent[parent_len - 1].
8369
8370 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8371
8372 PR gdb/24364
8373 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8374 call dtrace_process_dof with NULL dof.
8375
8376 2019-06-16 Tom de Vries <tdevries@suse.de>
8377
8378 PR gdb/24445
8379 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8380
8381 2019-06-16 Tom Tromey <tom@tromey.com>
8382
8383 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8384 (make_all_visible): Use address of member.
8385
8386 2019-06-16 Tom Tromey <tom@tromey.com>
8387
8388 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8389 (tui_free_window, free_content, free_content_elements): Remove
8390 unnecessary cast.
8391 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8392 cast.
8393 * tui/tui-regs.c (tui_show_register_group)
8394 (tui_display_registers_from, tui_display_reg_element_at_line):
8395 Remove unnecessary cast.
8396
8397 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8398
8399 * linux-nat.c (normal_mask): Delete.
8400 (_initialize_linux_nat): Don't initialise normal_mask.
8401
8402 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8403
8404 PR gdb/24445
8405 * dwarf-index-write.h (write_psymtabs_to_index): Add
8406 dwz_basename parameter.
8407 * dwarf-index-write.c (write_gdbindex): Move file writing to
8408 write_gdbindex_1. Change return type void.
8409 (assert_file_size): Move up, remove filename parameter.
8410 (write_gdbindex_1): New function.
8411 (write_debug_names): Change return type to void, call
8412 assert_file_size.
8413 (struct index_wip_file): New struct.
8414 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8415 file logic to index_wip_file. Write index for dwz file if
8416 needed.
8417 (save_gdb_index_command): Pass basename of dwz file, if present.
8418 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8419 build-id of dwz file, if present.
8420 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8421 (dwarf2_get_dwz_file): Likewise.
8422 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8423 (dwarf2_get_dwz_file): Likewise.
8424
8425 2019-06-16 Tom Tromey <tom@tromey.com>
8426
8427 * coffread.c (process_coff_symbol): Use xstrdup.
8428 * value.c (create_internalvar): Use xstrdup.
8429
8430 2019-06-16 Tom Tromey <tom@tromey.com>
8431
8432 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8433 * breakpoint.c (stopin_command, stopat_command)
8434 (until_break_command, decode_location_default): Remove unnecessary
8435 cast.
8436 * utils.c (subset_compare): Remove unnecessary cast.
8437 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8438 cast.
8439 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8440 cast.
8441 * infcmd.c (path_command): Remove unnecessary cast.
8442 * coffread.c (decode_type): Remove unnecessary cast.
8443 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8444 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8445 * tui/tui-stack.c (tui_show_locator_content)
8446 (tui_show_frame_info): Remove unnecessary cast.
8447 * tui/tui-win.c (tui_scroll_forward_command)
8448 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8449 (parse_scrolling_args): Remove unnecessary cast.
8450 * tui/tui-data.c (init_win_info, tui_del_window)
8451 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8452 (free_content_elements): Remove unnecessary cast.
8453 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8454 unnecessary cast.
8455 * tui/tui-source.c (tui_set_source_content)
8456 (tui_vertical_source_scroll): Remove unnecessary cast.
8457 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8458 cast.
8459 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8460 * tui/tui-regs.c (tui_display_registers_from)
8461 (tui_display_register): Remove unnecessary cast.
8462 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8463 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8464 (make_visible): Remove unnecessary cast.
8465 * tui/tui-winsource.c (tui_erase_source_content)
8466 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8467 unnecessary cast.
8468 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8469 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8470 * stabsread.c (read_type, read_array_type, read_range_type):
8471 Remove unnecessary cast.
8472 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8473 (parse_symbol, parse_type, upgrade_type, parse_external)
8474 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8475 unnecessary cast.
8476 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8477
8478 2019-06-16 Tom Tromey <tom@tromey.com>
8479
8480 * tui/tui-data.c (tui_alloc_generic_win_info)
8481 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8482 checks.
8483
8484 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8485 Andrew Burgess <andrew.burgess@embecosm.com>
8486
8487 * f-typeprint.c (f_print_type): Don't return early for not
8488 associated or not allocated types.
8489 (f_type_print_varspec_suffix): Add print_rank parameter and print
8490 ranks of array types in case they dangling.
8491 (f_type_print_base): Add print_rank parameter.
8492
8493 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8494
8495 * NEWS: Mention new MI commands.
8496 * break-catch-throw.c (enum exception_event_kind): Move to
8497 breakpoint.h.
8498 (print_mention_exception_catchpoint): Output text as a single
8499 message.
8500 (catch_exception_command_1): Rename to...
8501 (catch_exception_event): ...this, make non-static, update header
8502 command, and change some parameter types.
8503 (catch_catch_command): Update for changes to
8504 catch_exception_command_1.
8505 (catch_throw_command): Likewise.
8506 (catch_rethrow_command): Likewise.
8507 * breakpoint.c (enum exception_event_kind): Delete.
8508 * breakpoint.h (enum exception_event_kind): Moved here from
8509 break-catch-throw.c.
8510 (catch_exception_event): Declare.
8511 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8512 (mi_cmd_catch_throw): New function.
8513 (mi_cmd_catch_rethrow): New function.
8514 (mi_cmd_catch_catch): New function.
8515 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8516 'catch-catch' entries.
8517 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8518 (mi_cmd_catch_rethrow): Declare.
8519 (mi_cmd_catch_catch): Declare.
8520
8521 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8522
8523 * annotate.c (annotate_source_line): Change return type to void,
8524 update implementation to match.
8525 * annotate.h (annotate_source_line): Change return type to void,
8526 update header comment.
8527 * stack.c (print_frame_info): Don't change what frame information
8528 is printed based on whether annotations are on or not.
8529
8530 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8531
8532 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8533 (annotate_source): Make static.
8534 (annotate_source_line): Moved from source.c and renamed from
8535 identify_source_line. Update the return type.
8536 * annotate.h (annotate_source): Delete declaration.
8537 (annotate_source_line): Declaration moved from source.h, and
8538 renamed from identify_source_line. Return type updated.
8539 * source.c (identify_source_line): Moved to annotate.c and renamed
8540 to annotate_source_line.
8541 (info_line_command): Remove check of annotation_level.
8542 * source.h (identify_source_line): Move declaration to annotate.h
8543 and rename to annotate_source_line.
8544 * stack.c: Add 'annotate.h' include.
8545 (print_frame_info): Remove check of annotation_level before
8546 calling annotate_source_line.
8547
8548 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8549
8550 * source-cache.c (source_cache::get_plain_source_lines): Use
8551 open_source_file_with_line_charpos instead of just
8552 open_source_file, remove call to find_source_lines.
8553 (source_cache::get_source_lines): Likewise.
8554 * source.c (find_source_lines): Make static.
8555 (get_filename_and_charpos): Renamed into...
8556 (open_source_file_with_line_charpos): ..this along with changes to
8557 return a scoped_fd, and some other minor clean ups.
8558 (identify_source_line): Use open_source_file_with_line_charpos.
8559 (search_command_helper): Use open_source_file_with_line_charpos
8560 instead of just open_source_file, remove call to
8561 find_source_lines.
8562 * source.h (open_source_file_with_line_charpos): Declare new
8563 function.
8564 (find_source_lines): Delete declaration.
8565
8566 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8567
8568 * source.c (get_filename_and_charpos): Remove fullname
8569 parameter.
8570 (identify_source_line): Update call to get_filename_and_charpos.
8571
8572 2019-06-14 Tom Tromey <tromey@adacore.com>
8573
8574 PR gdb/24502:
8575 * ui-style.h (skip_ansi_escape): Update comment.
8576 * ui-file.h (class no_terminal_escape_file): New class.
8577 * ui-file.c (no_terminal_escape_file::write)
8578 (no_terminal_escape_file::puts): New methods.
8579 * cli/cli-logging.c (handle_redirections): Use
8580 no_terminal_escape_file.
8581
8582 2019-06-14 Tom Tromey <tromey@adacore.com>
8583
8584 * NEWS: Move convenience variable news above Python news.
8585
8586 2019-06-14 Tom Tromey <tom@tromey.com>
8587
8588 * gnulib: Move directory to top-level.
8589 * configure.ac: Don't configure gnulib.
8590 * configure: Rebuild.
8591 * common/common-defs.h: Use new path to gnulib.
8592 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8593 (GNULIB_H): Remove.
8594 (INCGNU): Look in new gnulib location.
8595 (HFILES_NO_SRCDIR): Remove gnulib files.
8596 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8597 (generated_files): Remove GNULIB_H.
8598 ($(LIBGNU), all-lib): Remove targets.
8599 (distclean): Don't mention GNULIB_BUILDDIR.
8600 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8601
8602 2019-06-14 Tom Tromey <tromey@adacore.com>
8603
8604 * symfile.c (add_symbol_file_command): Remove obsolete comment.
8605 Warn if symbol file does not provide any symbols.
8606
8607 2019-06-14 Tom Tromey <tromey@adacore.com>
8608
8609 * source.c (find_and_open_source): Respect basenames_may_differ.
8610
8611 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
8612
8613 * annotate.c (annotate_breakpoints_invalid): Make use of
8614 scoped_restore_terminal_state.
8615 (annotate_frames_invalid): Likewise.
8616
8617 2019-06-14 Tom Tromey <tromey@adacore.com>
8618
8619 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8620 allow assignment to an internalvar.
8621
8622 2019-06-14 Tom Tromey <tromey@adacore.com>
8623
8624 * ada-lex.l: Allow "_" in attribute names.
8625
8626 2019-06-14 Tom Tromey <tromey@adacore.com>
8627
8628 PR gdb/24653:
8629 * regcache.c (registers_changed): Don't call alloca.
8630 * top.c (execute_command): Don't call alloca.
8631
8632 2019-06-13 Pedro Alves <palves@redhat.com>
8633
8634 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8635 'expression'. When parsing an expression, error out if there's
8636 junk after "unlimited".
8637 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8638 (do_set_command): Adjust calls to is_unlimited_literal.
8639
8640 2019-06-13 Pedro Alves <palves@redhat.com>
8641
8642 * compile/compile.c (make_compile_options_def_group): Add braces
8643 around array_view initializer.
8644 * thread.c (make_thread_apply_all_options_def_group)
8645 (make_thread_apply_all_options_def_group): Likewise.
8646
8647 2019-06-13 Pedro Alves <palves@redhat.com>
8648
8649 * NEWS (New commands): Mention "maint test-options
8650 require-delimiter", "maint test-options unknown-is-error", "maint
8651 test-options unknown-is-operand" and "maint show
8652 test-options-completion-result".
8653 (New command options, command completion): New section.
8654 (Completion improvements): New section.
8655 Mention that you can abbreviate "unlimited".
8656
8657 2019-06-13 Pedro Alves <palves@redhat.com>
8658
8659 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8660 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8661 * unittests/cli-utils-selftests.c (test_parse_flags)
8662 (test_parse_flags_qcs): Delete.
8663 (test_cli_utils): Don't call deleted functions.
8664
8665 2019-06-13 Pedro Alves <palves@redhat.com>
8666
8667 * thread.c: Include "cli/cli-option.h".
8668 (tp_array_compar_ascending): Global.
8669 (tp_array_compar): Delete function.
8670 (tp_array_compar_ascending, tp_array_compar_descending): New
8671 functions.
8672 (ascending_option_def, qcs_flag_option_def)
8673 (thr_qcs_flags_option_defs)
8674 (make_thread_apply_all_options_def_group)
8675 (make_thread_apply_options_def_group): New.
8676 (thread_apply_all_command): Use gdb::option::process_options.
8677 (thread_apply_command_completer)
8678 (thread_apply_all_command_completer): New.
8679 (thread_apply_command): Use gdb::option::process_options.
8680 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8681 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
8682 to generate help text of "thread apply". Adjust "taas"'s help.
8683 * tid-parse.c (tid_range_parser::in_thread_range): New method.
8684 * tid-parse.h (tid_range_parser::in_thread_range): New method.
8685
8686 2019-06-13 Pedro Alves <palves@redhat.com>
8687
8688 * thread.c (thread_apply_command): Check for invalid TID with
8689 isdigit instead of !isalpha.
8690
8691 2019-06-13 Pedro Alves <palves@redhat.com>
8692
8693 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8694 (validate_flags_qcs): New.
8695 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8696 (validate_flags_qcs): Declare.
8697 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8698 (make_frame_apply_options_def_group): New.
8699 (frame_apply_command_count): Process options with
8700 gdb::option::process_options.
8701 (frame_apply_completer): New.
8702 (frame_apply_level_completer, frame_apply_all_completer)
8703 (frame_apply_completer): New.
8704 (_initialize_stack): Update help of "frame apply", "frame apply
8705 level", "frame apply all" and "faas" to mention supported options
8706 and install command completers.
8707 * stack.h (frame_apply_all_completer): Declare.
8708 * thread.c: Include "stack.h".
8709 (tfaas_command): Add "--".
8710 (_initialize_thread): Update help "tfaas" to mention supported
8711 options and install command completer.
8712
8713 2019-06-13 Pedro Alves <palves@redhat.com>
8714
8715 * completer.c (complete_nested_command_line): New.
8716 (gdb_completion_word_break_characters_throw): Add assertion.
8717 * completer.h (complete_nested_command_line): Declare.
8718
8719 2019-06-13 Pedro Alves <palves@redhat.com>
8720
8721 * stack.c (parse_backtrace_qualifiers): New.
8722 (backtrace_command): Use it.
8723 (backtrace_command_completer): Complete on qualifiers.
8724
8725 2019-06-13 Pedro Alves <palves@redhat.com>
8726
8727 * frame.c: Include "cli/cli-option.h.
8728 (user_set_backtrace_options): New.
8729 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8730 Delete.
8731 (get_prev_frame): Adjust.
8732 (boolean_option_def, uinteger_option_def)
8733 (set_backtrace_option_defs): New.
8734 (_initialize_frame): Adjust and use
8735 gdb::option::add_setshow_cmds_for_options to install "set
8736 backtrace past-main" and "set backtrace past-entry".
8737 * frame.h: Include "cli/cli-option.h".
8738 (struct frame_print_options): Forward declare.
8739 (print_frame_arguments_all, print_frame_arguments_scalars)
8740 (print_frame_arguments_none): Declare.
8741 (print_entry_values): Delete declaration.
8742 (struct frame_print_options, user_frame_print_options): New.
8743 (struct set_backtrace_options): New.
8744 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8745 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8746 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8747 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8748 (list_args_or_locals): Add frame_print_options parameter.
8749 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8750 * python/py-framefilter.c (enumerate_args): Pass down
8751 USER_FRAME_PRINT_OPTIONS.
8752 * stack.c: Include "cli/cli-option.h".
8753 (print_frame_arguments_all, print_frame_arguments_scalars)
8754 (print_frame_arguments_none): Declare.
8755 (print_raw_frame_arguments, print_entry_values): Delete.
8756 (user_frame_print_options): New.
8757 (boolean_option_def, enum_option_def, frame_print_option_defs):
8758 New.
8759 (struct backtrace_cmd_options): New.
8760 (bt_flag_option_def): New.
8761 (backtrace_command_option_defs): New.
8762 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8763 (print_frame_arg, read_frame_arg, print_frame_args)
8764 (print_frame_info, print_frame): Add frame_print_options parameter
8765 and use it.
8766 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8767 (backtrace_command_1): Add frame_print_options and
8768 backtrace_cmd_options parameters and use them.
8769 (make_backtrace_options_def_group): New.
8770 (backtrace_command): Process command options with
8771 gdb::option::process_options.
8772 (backtrace_command_completer): New.
8773 (_initialize_stack): Extend "backtrace"'s help to mention
8774 supported options. Install completer for "backtrace".
8775 Install some settings commands with add_setshow_cmds_for_options.
8776
8777 2019-06-13 Pedro Alves <palves@redhat.com>
8778
8779 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8780 and that "set/show print raw frame-arguments" are now deprecated.
8781
8782 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8783 command.
8784 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8785 * stack.c (_initialize_stack): Install "set/show print
8786 raw-frame-arguments", and deprecate "set/show print raw
8787 frame-arguments".
8788 * valprint.c (_initialize_valprint): Deprecate "set/show print
8789 raw".
8790
8791 2019-06-13 Pedro Alves <palves@redhat.com>
8792
8793 * compile/compile.c (struct compile_options): New.
8794 (compile_flag_option_def, compile_command_option_defs)
8795 (make_compile_options_def_group): New.
8796 (compile_file_command): Handle options with
8797 gdb::option::process_options.
8798 (compile_file_command_completer): New function.
8799 (compile_code_command): Handle options with
8800 gdb::option::process_options.
8801 (compile_code_command_completer): New function.
8802 (_initialize_compiler): Install completers for "compile code" and
8803 "compile file". Mention available options in "compile code" and
8804 "compile code"'s help.
8805 * completer.c (advance_to_completion_word): New, factored out from
8806 ...
8807 (advance_to_expression_complete_word_point): ... this.
8808 (advance_to_filename_complete_word_point): New.
8809 * completer.h (advance_to_filename_complete_word_point): New
8810 declaration.
8811
8812 2019-06-13 Pedro Alves <palves@redhat.com>
8813
8814 * compile/compile.c: Include "cli/cli-option.h".
8815 (compile_print_value): Scope data pointer is now a
8816 value_print_options pointer; adjust.
8817 (compile_print_command): Process options. Scope data pointer is
8818 now a value_print_options pointer; adjust.
8819 (_initialize_compile): Update "compile print"'s help to include
8820 supported options. Install a completer for "compile print".
8821 * cp-valprint.c (show_vtblprint, show_objectprint)
8822 (show_static_field_print): Delete.
8823 (_initialize_cp_valprint): Don't install "set print
8824 static-members", "set print vtbl", "set print object" here.
8825 * printcmd.c: Include "cli/cli-option.h" and
8826 "common/gdb_optional.h".
8827 (print_command_parse_format): Rework to fill in a
8828 value_print_options instead of a format_data.
8829 (print_value): Change parameter type from format_data pointer to
8830 value_print_options reference. Adjust.
8831 (print_command_1): Process options. Adjust to pass down a
8832 value_print_options.
8833 (print_command_completer): New.
8834 (_initialize_printcmd): Install print_command_completer as
8835 handle_brkchars completer for the "print" command. Update
8836 "print"'s help to include supported options.
8837 * valprint.c: Include "cli/cli-option.h".
8838 (show_vtblprint, show_objectprint, show_static_field_print): Moved
8839 here from cp-valprint.c.
8840 (boolean_option_def, uinteger_option_def)
8841 (value_print_option_defs, make_value_print_options_def_group):
8842 New. Use gdb::option::add_setshow_cmds_for_options to install
8843 "set print elements", "set print null-stop", "set print repeats",
8844 "set print pretty", "set print union", "set print array", "set
8845 print address", "set print symbol", "set print array-indexes".
8846 * valprint.h: Include <string> and "cli/cli-option.h".
8847 (make_value_print_options_def_group): Declare.
8848 (print_value): Change parameter type from format_data pointer to
8849 value_print_options reference.
8850 (print_command_completer): Declare.
8851
8852 2019-06-13 Pedro Alves <palves@redhat.com>
8853
8854 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
8855 (COMMON_SFILES): Add maint-test-settings.c.
8856 * cli/cli-decode.c (boolean_enums): New global, factored out from
8857 ...
8858 (add_setshow_boolean_cmd): ... here.
8859 * cli/cli-decode.h (boolean_enums): Declare.
8860 * cli/cli-option.c: New file.
8861 * cli/cli-option.h: New file.
8862 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
8863 factored out from ...
8864 (parse_cli_boolean_value(const char *)): ... this.
8865 (is_unlimited_literal): Change parameter type to pointer to
8866 pointer. Adjust and advance ARG pointer.
8867 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8868 (parse_cli_var_enum): New, factored out from ...
8869 (do_set_command): ... this. Adjust.
8870 * cli/cli-setshow.h (parse_cli_boolean_value)
8871 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8872 (parse_cli_var_enum): Declare.
8873 * cli/cli-utils.c: Include "cli/cli-option.h".
8874 (get_ulongest): New.
8875 * cli/cli-utils.h (get_ulongest): Declare.
8876 (check_for_argument): New overloads.
8877 * maint-test-options.c: New file.
8878
8879 2019-06-13 Pedro Alves <palves@redhat.com>
8880
8881 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
8882 parse a range if "-" is at the end of the string.
8883
8884 2019-06-13 Pedro Alves <palves@redhat.com>
8885
8886 * cli/cli-setshow.c (parse_auto_binary_operation)
8887 (parse_cli_boolean_value): Don't allow "o".
8888
8889 2019-06-13 Pedro Alves <palves@redhat.com>
8890
8891 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
8892 * NEWS: Mention maint test-settings KIND.
8893 * maint-test-settings.c: New file.
8894
8895 2019-06-13 Pedro Alves <palves@redhat.com>
8896
8897 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
8898 completer.
8899 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
8900 "set" completers.
8901
8902 2019-06-13 Pedro Alves <palves@redhat.com>
8903
8904 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
8905 after item.
8906
8907 2019-06-13 Pedro Alves <palves@redhat.com>
8908
8909 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
8910
8911 2019-06-13 Pedro Alves <palves@redhat.com>
8912
8913 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
8914 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
8915 call.
8916 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
8917 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
8918 calls.
8919 (check_for_argument): Skip spaces after argument.
8920
8921 2019-06-13 Pedro Alves <palves@redhat.com>
8922
8923 * thread.c (thread_apply_command): Adjust TID parsing.
8924 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
8925 detected before end of string.
8926 (tid_is_in_list): Error out if LIST is invalid.
8927
8928 2019-06-13 Pedro Alves <palves@redhat.com>
8929
8930 * completer.c (complete_line_internal_1): Rewind completion word
8931 point.
8932 (completion_tracker::advance_custom_word_point_by): Change
8933 parameter type to int.
8934 * completer.h (completion_tracker::advance_custom_word_point_by):
8935 Likewise.
8936
8937 2019-06-13 Pedro Alves <palves@redhat.com>
8938
8939 * completer.c (advance_to_completion_word): Handle delimiters.
8940
8941 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
8942
8943 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
8944
8945 2019-06-11 Tom Tromey <tom@tromey.com>
8946
8947 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
8948 (xmalloc_failed): Move to alloc.c.
8949 * alloc.c: New file.
8950 * Makefile.in (COMMON_SFILES): Add alloc.c.
8951
8952 2019-06-11 Tom Tromey <tom@tromey.com>
8953
8954 * nat/linux-waitpid.c: Don't include server.h.
8955 (linux_debug): Remove.
8956 (my_waitpid): Update.
8957
8958 2019-06-11 Tom Tromey <tromey@adacore.com>
8959
8960 * infcall.c (_initialize_infcall): Remove trailing newline from
8961 help.
8962 * user-regs.c (_initialize_user_regs): Remove trailing newline
8963 from help.
8964 * typeprint.c (_initialize_typeprint): Remove trailing newline
8965 from help.
8966 * reverse.c (_initialize_reverse): Remove trailing newlines from
8967 help.
8968 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
8969 from help.
8970 * language.c (add_set_language_command): Remove trailing newline
8971 from help.
8972 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
8973 help.
8974 * disasm.c (_initialize_disasm): Remove trailing newline from
8975 help.
8976 * top.c (init_main): Remove trailing newline from help.
8977 * interps.c (_initialize_interpreter): Remove trailing newline
8978 from help.
8979 * btrace.c (_initialize_btrace): Remove trailing newlines from
8980 help.
8981 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
8982 from help.
8983 * python/python.c (_initialize_python): Remove trailing newline
8984 from help.
8985 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
8986 help.
8987 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
8988 from help. Reformat some text.
8989 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
8990 from help.
8991 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
8992 newline from help.
8993
8994 2019-06-11 Tom Tromey <tromey@adacore.com>
8995
8996 * darwin-nat.c (darwin_decode_exception_message)
8997 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
8998
8999 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9000
9001 * valops.c (value_slice): Check for not allocated or not
9002 associated values.
9003
9004 2019-06-10 Tom de Vries <tdevries@suse.de>
9005
9006 PR gdb/24618
9007 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9008 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9009 invalid.
9010
9011 2019-06-10 Tom de Vries <tdevries@suse.de>
9012
9013 PR gdb/24611
9014 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9015 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9016
9017 2019-06-10 Tom de Vries <tdevries@suse.de>
9018
9019 PR symtab/24545
9020 * symtab.c (struct demangled_name_entry): Add language field.
9021 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9022 static minimal symbol". Set and use language field.
9023
9024 2019-06-10 Tom Tromey <tromey@adacore.com>
9025
9026 * ada-lang.c (_initialize_ada_language): Update help text.
9027
9028 2019-06-10 Tom Tromey <tromey@adacore.com>
9029
9030 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9031 with a newline.
9032 * guile/guile.c (handle_boot_error): Don't end warning with a
9033 newline.
9034 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9035 warning with a newline.
9036 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9037 newline.
9038 (s12z_frame_cache): Likewise.
9039 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9040 a newline.
9041 * solib-svr4.c (disable_probes_interface): Don't end warning with
9042 a newline.
9043 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9044 newline.
9045 * python/python.c (do_finish_initialization): Don't end warning
9046 with a newline.
9047
9048 2019-06-10 Tom Tromey <tom@tromey.com>
9049
9050 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9051 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9052 gdbpy_enter.
9053
9054 2019-06-10 Tom Tromey <tromey@adacore.com>
9055
9056 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9057 data.
9058 (elf_new_init): Don't call stabsread_new_init.
9059 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9060 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9061 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9062
9063 2019-06-10 Tom de Vries <tdevries@suse.de>
9064
9065 PR symtab/16264
9066 PR symtab/24517
9067 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9068
9069 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9070
9071 * source.c (find_and_open_source): Also rewrite relative file
9072 names.
9073
9074 2019-04-26 Amos Bird <amosbird@gmail.com>
9075
9076 * annotate.c (annotate_thread_exited): Add "thread-exited"
9077 annotation.
9078
9079 2019-06-06 Tom Tromey <tromey@adacore.com>
9080
9081 * maint.h (class scoped_command_stats): Use
9082 DISABLE_COPY_AND_ASSIGN.
9083 <print_time>: New method.
9084 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9085 print_time.
9086 (scoped_command_stats::print_time): New method.
9087
9088 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9089
9090 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9091 instructions of lengths 6 or 8 bytes.
9092
9093 2019-06-04 Pedro Alves <palves@redhat.com>
9094
9095 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9096
9097 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9098 * breakpoint.c (condition_completer): Likewise.
9099 * cli/cli-dump.c (scan_expression): Likewise.
9100 * common/filestuff.c (mkdir_recursive): Likewise.
9101 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9102 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9103 (gdb_abspath): Likewise.
9104 * compile/compile-cplus-types.c
9105 (compile_cplus_instance::decl_name): Likewise.
9106 * completer.c (complete_explicit_location):
9107 (signal_completer, reg_or_group_completer_1): Likewise.
9108 * cp-support.c (cp_remove_params_if_any): Likewise.
9109 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9110 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9111 * infcmd.c (strip_bg_char): Likewise.
9112 * linespec.c (copy_token_string): Likewise.
9113 * mi/mi-main.c (output_cores): Likewise.
9114 * psymtab.c (psymtab_search_name):
9115 * symfile.c (test_set_ext_lang_command): Likewise.
9116 * target.c (target_fileio_read_stralloc): Likewise.
9117 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9118 * value.c (complete_internalvar): Likewise.
9119
9120 2019-06-04 Christian Biesinger <cbiesinger@google.com>
9121
9122 Add objfile property to gdb.Type.
9123 * NEWS: Mention Python API addition.
9124 * python/py-type.c (typy_get_objfile): New method.
9125
9126 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9127
9128 * NEWS: Mention the new set|show style [title|highlight].
9129 Mention changes to "show style", "help" and "apropos".
9130
9131 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9132
9133 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9134 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9135 instead of print_help_for_command.
9136 (print_doc_of_command): New function.
9137 (help_list): Add 'apropos -v word' suggestion.
9138 (print_help_for_command): Style the command name using title style.
9139 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9140 (_initialize_cli_cmds): Describe -v in apropos_command help.
9141
9142 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9143
9144 * cli/cli-style.h (cli_style_option): Add name in constructor,
9145 add m_name class member, add constructor with intensity,
9146 add name class function.
9147 (cli_style_option::add_setshow_commands): Remove name argument.
9148 (highlight_style, title_style): New styles.
9149 * cli/cli-style.c (do_show): New function that shows a style
9150 characteristic styling the style name with itself.
9151 (set_style_name): New function.
9152 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9153 Update all callers according to the changes in cli/cli-style.h.
9154 * utils.h (fputs_highlighted): New function.
9155 * utils.c (fputs_highlighted): Likewise.
9156
9157 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9158
9159 * NEWS: Mention new pipe command and new convenience variables.
9160
9161 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9162
9163 * cli/cli-cmds.c (pipe_command): New function.
9164 (_initialize_cli_cmds): Call add_com for pipe_command.
9165 Define | as an alias for pipe.
9166 (exit_status_set_internal_vars): New function.
9167 (shell_escape): Call exit_status_set_internal_vars.
9168 cli/cli-decode.c (find_command_name_length): Recognize | as
9169 a single character command.
9170
9171 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9172
9173 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9174 top.c (execute_command_to_ui_file): New function, mostly a copy
9175 of execute_command_to_string.
9176 (execute_command_to_string): Implement by calling
9177 execute_command_to_ui_file.
9178
9179 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9180
9181 * top.h (saved_command_line): Remove declaration.
9182 * top.c (previous_saved_command_line, previous_repeat_arguments):
9183 New variables.
9184 (saved_command_line): Make static, define together with other
9185 'repeat variables'.
9186 (dont_repeat): Clear repeat_arguments.
9187 (repeat_previous, get_saved_command_line, save_command_line):
9188 New functions.
9189 (gdb_init): Initialize saved_command_line
9190 and previous_saved_command_line.
9191 * main.c (captured_main_1): Remove saved_command_line initialization.
9192 * event-top.c (handle_line_of_input): Update to use
9193 the new 'repeat' related functions instead of direct access to
9194 saved_command_line.
9195 * command.h (repeat_previous, get_saved_command_line,
9196 save_command_line): New declarations.
9197 (dont_repeat): Add comment.
9198
9199 2019-05-30 Tom Tromey <tromey@adacore.com>
9200
9201 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9202 Fix comment.
9203 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9204
9205 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9206
9207 PR cli/24587
9208 * completer.c (complete): Initialize variable word.
9209
9210 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9211
9212 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9213 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9214 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9215 'body' is NULL to the outter 'if', protecting the '!is_define'
9216 situation as well.
9217
9218 2019-05-29 Tom Tromey <tromey@adacore.com>
9219
9220 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9221 (dwarf_unknown): New function.
9222 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9223 (dwarf_type_encoding_name): Use dwarf_unknown.
9224
9225 2019-05-29 Tom Tromey <tromey@adacore.com>
9226
9227 PR c++/20020:
9228 * cp-valprint.c (cp_print_value_fields): Call
9229 cp_print_static_field inside "try".
9230
9231 2019-05-29 Tom Tromey <tromey@adacore.com>
9232
9233 * inflow.c (struct terminal_info): Add default operator=.
9234 * configure: Rebuild.
9235 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9236 -Wdeprecated-copy-dtor, -Wredundant-move.
9237
9238 2019-05-29 Tom Tromey <tromey@adacore.com>
9239
9240 * NEWS: Add entry.
9241 * infcmd.c (print_return_value_1): Handle finish_print
9242 option.
9243 (show_print_finish): New function.
9244 (_initialize_infcmd): Add "set/show print finish" commands.
9245 * valprint.c (user_print_options): Initialize new member.
9246 * valprint.h (struct value_print_options) <finish_print>: New
9247 member.
9248
9249 2019-05-28 Tom Tromey <tromey@adacore.com>
9250
9251 * ada-lang.c (ada_remove_Xbn_suffix)
9252 (find_old_style_renaming_symbol)
9253 (parse_old_style_renaming): Remove.
9254 (ada_find_renaming_symbol): Don't call
9255 find_old_style_renaming_symbol.
9256 (ada_is_renaming_symbol): Rename from
9257 ada_find_renaming_symbol. Remove "block" parameter. Return
9258 bool. Now static.
9259 (ada_read_var_value): Update and simplify.
9260 * ada-exp.y (write_var_or_type): Remove old code.
9261
9262 2019-05-28 Alan Hayward <alan.hayward@arm.com>
9263
9264 PR gdb/25010
9265 * event-top.c: Remove include comment.
9266 * inflow.c (class scoped_ignore_sigttou): Move from here...
9267 * inflow.h (class scoped_ignore_sigttou): ...to here.
9268 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9269 * top.c: Remove include comment.
9270
9271 2019-05-27 Tom Tromey <tom@tromey.com>
9272
9273 * NEWS: Fix typo.
9274
9275 2019-05-22 Tom Tromey <tromey@adacore.com>
9276
9277 * target.c (target_follow_exec): Constify parameter.
9278 * target-delegates.c: Rebuild.
9279 * remote.c (remote_target::follow_exec): Constify parameter.
9280 * infrun.c (follow_exec): Constify parameter.
9281 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9282 (target_follow_exec): Likewise.
9283
9284 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9285
9286 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9287 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9288
9289 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9290
9291 * NEWS: Add debugredirect and testsuite sections.
9292
9293 2019-05-22 Simon Cook <simon.cook@embecosm.com>
9294
9295 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9296 target descriptions using exclusively floating point register name
9297 aliases.
9298
9299 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9300
9301 PR gdb/18644:
9302 * f-lang.c (build_fortran_types): Handle the case where
9303 gdbarch_floatformat_for_type returns a nullptr.
9304
9305 2019-05-21 Tom de Vries <tdevries@suse.de>
9306
9307 PR cli/24587
9308 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9309
9310 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9311
9312 PR gdb/18644:
9313 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9314 16-byte floats.
9315 * i386-tdep.c (i386_floatformat_for_type): Use
9316 floatformats_ia64_quad for the 16-byte floating point component
9317 within a fortran 32-byte complex number.
9318
9319 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9320
9321 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9322 delete default constructor.
9323 (find_partial_die): Update to return const struct.
9324 (partial_die_parent_scope): Move variable declaration into scope
9325 of its use and change its type to auto.
9326 (guess_partial_die_structure_name): Likewise.
9327 (partial_die_info::fixup): Likewise.
9328
9329 2019-05-17 Tom Tromey <tromey@adacore.com>
9330
9331 * source.c (find_and_open_source): Remove cast.
9332
9333 2019-05-17 Tom Tromey <tromey@adacore.com>
9334
9335 * annotate.c (annotate_source): Make "filename" const.
9336 * annotate.h (annotate_source): Use const.
9337
9338 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9339
9340 * disasm.c (set_disassembler_options): Send errors to stderr.
9341
9342 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9343
9344 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9345 (cli_interp_base::set_logging): Check debug_redirect.
9346 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9347 * cli/cli-logging.c (debug_redirect): Add static variable.
9348 (pop_output_files): Add default param.
9349 (handle_redirections): Print debug setting.
9350 (show_logging_command): Likewise.
9351 (_initialize_cli_logging): Add debugredirect command.
9352 * interps.c (current_interp_set_logging): Add debug_redirect
9353 parameter.
9354 * interps.h (set_logging): Add debug_redirect parameter.
9355 (current_interp_set_logging): Likewise.
9356 * mi/mi-common.h: Likewise.
9357 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9358
9359 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9360 Tom Tromey <tromey@adacore.com>
9361
9362 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9363 directly.
9364 * cli/cli-interp.h (make_logging_output): Remove declaration.
9365 * cli/cli-logging.c (make_logging_output): Remove function.
9366 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9367 directly.
9368 * ui-file.c (tee_file::tee_file): Remove bools.
9369 (tee_file::~tee_file): Remove deletes.
9370 * ui-file.h (tee_file): Remove bools.
9371
9372 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9373
9374 * mi/mi-cmds.h (mi_cmd_complete): New function.
9375 * mi/mi-main.c (mi_cmd_complete): Likewise.
9376 * mi/mi-cmds.c: Define new MI command -complete.
9377 * NEWS: Mention new -complete command.
9378
9379 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9380
9381 * completer.h (complete): New function.
9382 * completer.c (complete): Likewise.
9383 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9384 function defined in completer.h.
9385
9386 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9387
9388 * MAINTAINERS (Write After Approval): Add myself.
9389
9390 2019-05-17 Tom de Vries <tdevries@suse.de>
9391
9392 PR gdb/24094
9393 * dwarf2read.c (struct cu_partial_die_info): New struct.
9394 (find_partial_die): Return cu_partial_die_info.
9395 (partial_die_parent_scope, guess_partial_die_structure_name)
9396 (partial_die_info::fixup): Handle new return type of find_partial_die.
9397
9398 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9399
9400 PR breakpoints/24541
9401 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9402 "std::string", simplifying the algorithm.
9403
9404 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9405
9406 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9407 (stap_static_probe_ops::get_probes): Likewise.
9408
9409 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9410
9411 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9412 '-')" and "else if".
9413 (stap_parse_single_operand): Join checks for
9414 "gdbarch_stap_parse_special_token_p" and
9415 "gdbarch_stap_parse_special_token" in the same "if" statement.
9416 Invert check when verifying for operation on register
9417 displacement.
9418
9419 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9420
9421 * stap-probe.c (stap_get_opcode): Update comment.
9422 (stap_get_expected_argument_type): Likewise.
9423 (handle_stap_probe): Likewise.
9424
9425 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9426
9427 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9428 return type to 'bool'. Adjust comment. Use 'bool' when
9429 appropriate.
9430 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9431 * stap-probe.c (stap_parse_argument_1): Likewise.
9432 (stap_is_operator): Likewise.
9433 (stap_is_generic_prefix): Likewise.
9434 (stap_is_register_prefix): Likewise.
9435 (stap_is_register_indirection_prefix): Likewise.
9436 (stap_is_integer_prefix): Likewise.
9437 (stap_generic_check_suffix): Likewise.
9438 (stap_check_integer_suffix): Likewise.
9439 (stap_check_register_suffix): Likewise.
9440 (stap_check_register_indirection_suffix): Likewise.
9441 (stap_parse_register_operand): Likewise.
9442 (stap_parse_single_operand): Likewise.
9443 (stap_parse_argument_1): Likewise.
9444 (stap_probe::get_argument_count): Likewise.
9445 (stap_is_operator): Likewise.
9446
9447 2019-05-16 Tom Tromey <tromey@adacore.com>
9448
9449 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9450 keyword to foreach.
9451
9452 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
9453
9454 * linux-thread-db.c (try_thread_db_load_1): Change return type
9455 to bool.
9456 (try_thread_db_load): Likewise.
9457 (try_thread_db_load_from_pdir_1): Likewise.
9458 (try_thread_db_load_from_pdir): Likewise.
9459 (try_thread_db_load_from_sdir): Likewise.
9460 (try_thread_db_load_from_dir): Likewise.
9461 (thread_db_load_search): Likewise.
9462 (has_libpthread): Likewise.
9463 (thread_db_load): Likewise.
9464
9465 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9466
9467 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9468 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9469 NULL, and complain/return if that's the case.
9470
9471 2019-05-15 John Darrington <john@darrington.wattle.id.au>
9472
9473 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9474 (advance, posn, abstract_read_memory): New functions.
9475 [struct mem_read_abstraction]: New struct.
9476 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9477
9478 2019-05-14 Tom Tromey <tromey@adacore.com>
9479
9480 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9481 value is not lval_memory.
9482
9483 2019-05-14 Tom Tromey <tromey@adacore.com>
9484
9485 * solib.c (info_sharedlibrary_command): Style the file name.
9486
9487 2019-05-14 Alan Hayward <alan.hayward@arm.com>
9488
9489 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9490 (aarch64_vnv_type): Likewise.
9491 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9492 * common/tdesc.c: Likewise.
9493 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9494 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9495 * features/aarch64-fpu.xml: Add ieee half view.
9496 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9497 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9498 * gdbtypes.h (struct builtin_type): Likewise.
9499 (struct objfile_type): Likewise.
9500
9501 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
9502
9503 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9504 typo.
9505 * location.h (string_to_event_location): Likewise.
9506
9507 2019-05-11 Joel Brobecker <brobecker@adacore.com>
9508
9509 GDB 8.3 released.
9510
9511 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9512
9513 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9514 New variable declaration.
9515 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9516 New variable.
9517 (print_one_breakpoint): Use ui_out::test_flags and new global
9518 variable to compute use_fixed_output.
9519 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9520 Remove.
9521 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9522 (mi_multi_location_breakpoint_output_fixed): Remove.
9523 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9524 new variable.
9525 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9526 fix_multi_location_breakpoint_output flag if version >= 3.
9527 * ui-out.h (enum ui_out_flag)
9528 <fix_multi_location_breakpoint_output>: New enumerator.
9529
9530 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9531
9532 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9533
9534 2019-05-10 Tom Tromey <tromey@adacore.com>
9535
9536 * ada-lang.c (catch_ada_completer): New function.
9537 (_initialize_ada_language): Use it.
9538
9539 2019-05-10 Tom Tromey <tromey@adacore.com>
9540
9541 * thread.c (print_thread_info): Make "requested_threads" const.
9542 * gdbthread.h (print_thread_info): Make "requested_threads"
9543 const.
9544 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9545 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9546
9547 2019-05-08 Tom Tromey <tom@tromey.com>
9548
9549 * gdbtypes.c (objfile_type_data): Change type.
9550 (objfile_type, _initialize_gdbtypes): Update.
9551
9552 2019-05-08 Tom Tromey <tom@tromey.com>
9553
9554 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9555 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9556 (_initialize_dwarf2_frame): Update.
9557
9558 2019-05-08 Tom Tromey <tom@tromey.com>
9559
9560 * objc-lang.c (objc_objfile_data): Change type.
9561 (find_methods): Update.
9562 (_initialize_objc_lang): Remove.
9563
9564 2019-05-08 Tom Tromey <tom@tromey.com>
9565
9566 * stabsread.c (rs6000_builtin_type_data): Change type.
9567 (rs6000_builtin_type, _initialize_stabsread): Update.
9568
9569 2019-05-08 Tom Tromey <tom@tromey.com>
9570
9571 * mips-tdep.c (mips_pdr_data): Remove.
9572 (_initialize_mips_tdep): Update.
9573
9574 2019-05-08 Tom Tromey <tom@tromey.com>
9575
9576 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9577 (hppa_init_objfile_priv_data, read_unwind_info)
9578 (find_unwind_entry, _initialize_hppa_tdep): Update.
9579
9580 2019-05-08 Tom Tromey <tom@tromey.com>
9581
9582 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9583 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9584 on obstack.
9585 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9586
9587 2019-05-08 Tom Tromey <tom@tromey.com>
9588
9589 * mdebugread.c (basic_type_data): Change type.
9590 (basic_type, _initialize_mdebugread): Update.
9591
9592 2019-05-08 Tom Tromey <tom@tromey.com>
9593
9594 * common/gdb_unique_ptr.h (struct noop_deleter): New.
9595
9596 2019-05-08 Tom Tromey <tom@tromey.com>
9597
9598 * nto-tdep.c (nto_inferior_data_reg): Change type.
9599 (nto_inferior_data): Update.
9600 (nto_inferior_data_cleanup, nto_new_inferior_data)
9601 (_initialize_nto_tdep): Remove.
9602 * nto-tdep.h (struct nto_inferior_data): Add initializers.
9603
9604 2019-05-08 Tom Tromey <tom@tromey.com>
9605
9606 * ada-lang.c (struct ada_inferior_data): Add initializers.
9607 (ada_inferior_data): Change type.
9608 (ada_inferior_data_cleanup): Remove.
9609 (get_ada_inferior_data, ada_inferior_exit)
9610 (struct ada_pspace_data): Add initializers, destructor.
9611 (ada_pspace_data_handle): Change type.
9612 (get_ada_pspace_data): Update.
9613 (ada_pspace_data_cleanup): Remove.
9614
9615 2019-05-08 Tom Tromey <tom@tromey.com>
9616
9617 * coffread.c (struct coff_symfile_info): Add initializers.
9618 (coff_objfile_data_key): Move lower. Change type.
9619 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9620 Update.
9621 (coff_free_info): Remove.
9622
9623 2019-05-08 Tom Tromey <tom@tromey.com>
9624
9625 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9626 (fbsd_pspace_data_handle): Move lower. Change type.
9627 (get_fbsd_pspace_data): Update.
9628 (fbsd_pspace_data_cleanup): Remove.
9629 (_initialize_fbsd_tdep): Update.
9630
9631 2019-05-08 Tom Tromey <tom@tromey.com>
9632
9633 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9634 (get_ada_tasks_pspace_data): Update.
9635 (ada_tasks_pspace_data_cleanup): Remove.
9636 (_initialize_tasks): Update.
9637 (ada_tasks_inferior_data_handle): Change type.
9638 (get_ada_tasks_inferior_data): Update.
9639 (ada_tasks_inferior_data_cleanup): Remove.
9640 (struct ada_tasks_pspace_data): Add initializers.
9641
9642 2019-05-08 Tom Tromey <tom@tromey.com>
9643
9644 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9645 * symfile-debug.c (debug_sym_get_probes): Change type.
9646 * stap-probe.c (handle_stap_probe):
9647 (stap_static_probe_ops::get_probes): Change type.
9648 * probe.h (class static_probe_ops) <get_probes>: Change type.
9649 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9650 (parse_probes_in_pspace): Update.
9651 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9652 Update.
9653 (any_static_probe_ops::get_probes): Change type.
9654 * elfread.c (elfread_data): New typedef.
9655 (probe_key): Change type.
9656 (elf_get_probes): Likewise. Update.
9657 (probe_key_free): Remove.
9658 (_initialize_elfread): Update.
9659 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9660 Change type.
9661 (dtrace_process_dof_probe, dtrace_process_dof)
9662 (dtrace_static_probe_ops::get_probe): Change type.
9663
9664 2019-05-08 Tom Tromey <tom@tromey.com>
9665
9666 * xcoffread.c (struct xcoff_symfile_info): Rename from
9667 coff_symfile_info. Add initializers.
9668 (xcoff_objfile_data_key): Move lower. Change type.
9669 (XCOFF_DATA): Rewrite.
9670 (xcoff_free_info): Remove.
9671 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9672 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9673 (xcoff_initial_scan): Update.
9674
9675 2019-05-08 Tom Tromey <tom@tromey.com>
9676
9677 * solib-svr4.c (struct svr4_info): Add initializers and
9678 destructor.
9679 <probes_table>: Now an htab_up.
9680 (solib_svr4_pspace_data): Change type.
9681 (free_probes_table): Simplify.
9682 (~svr4_info): Rename from svr4_pspace_data_cleanup.
9683 (get_svr4_info, probes_table_htab_remove_objfile_probes)
9684 (probes_table_remove_objfile_probes, register_solib_event_probe)
9685 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9686 (_initialize_svr4_solib): Update.
9687
9688 2019-05-08 Tom Tromey <tom@tromey.com>
9689
9690 * remote.c (remote_pspace_data): Change type.
9691 (remote_pspace_data_cleanup): Remove.
9692 (get_remote_exec_file, set_pspace_remote_exec_file)
9693 (_initialize_remote): Update.
9694
9695 2019-05-08 Tom Tromey <tom@tromey.com>
9696
9697 * breakpoint.c (breakpoint_objfile_key): Change type.
9698 (get_breakpoint_objfile_data): Update.
9699 (free_breakpoint_objfile_data): Remove.
9700 (_initialize_breakpoint): Update.
9701
9702 2019-05-08 Tom Tromey <tom@tromey.com>
9703
9704 * linux-tdep.c (struct linux_info): Add initializers.
9705 (linux_inferior_data): Move. Change type.
9706 (invalidate_linux_cache_inf): Update.
9707 (linux_inferior_data_cleanup): Remove.
9708 (get_linux_inferior_data, _initialize_linux_tdep): Update.
9709
9710 2019-05-08 Tom Tromey <tom@tromey.com>
9711
9712 * auxv.c (auxv_inferior_data): Move. Change type.
9713 (auxv_inferior_data_cleanup): Remove.
9714 (invalidate_auxv_cache_inf): Rewrite.
9715 (get_auxv_inferior_data, _initialize_auxv): Update.
9716
9717 2019-05-08 Tom Tromey <tom@tromey.com>
9718
9719 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9720 (symfile_debug_objfile_data_key): Change type.
9721 (symfile_debug_installed, debug_qf_has_symbols)
9722 (debug_qf_find_last_source_symtab)
9723 (debug_qf_forget_cached_source_info)
9724 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9725 (debug_qf_print_stats, debug_qf_dump)
9726 (debug_qf_expand_symtabs_for_function)
9727 (debug_qf_expand_all_symtabs)
9728 (debug_qf_expand_symtabs_with_fullname)
9729 (debug_qf_map_matching_symbols)
9730 (debug_qf_expand_symtabs_matching)
9731 (debug_qf_find_pc_sect_compunit_symtab)
9732 (debug_qf_map_symbol_filenames)
9733 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9734 (debug_sym_new_init, debug_sym_init, debug_sym_read)
9735 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9736 (debug_sym_read_linetable, debug_sym_relocate): Update.
9737 (symfile_debug_free_objfile): Remove.
9738 (install_symfile_debug_logging, _initialize_symfile_debug):
9739 Update.
9740
9741 2019-05-08 Tom Tromey <tom@tromey.com>
9742
9743 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9744 allocate_on_obstack.
9745 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9746 (get_dwarf2_per_objfile): Update.
9747 (set_dwarf2_per_objfile): Remove.
9748 (dwarf2_has_info, dwarf2_get_section_info): Update.
9749 (dwarf2_free_objfile): Remove.
9750 (_initialize_dwarf2_read): Update.
9751
9752 2019-05-08 Tom Tromey <tom@tromey.com>
9753
9754 * auto-load.c (struct auto_load_pspace_info): Add destructor and
9755 initializers.
9756 <unsupported_script_warning_printed,
9757 script_not_found_warning_printed>: Now bool.
9758 (auto_load_pspace_data): Change type.
9759 (~auto_load_pspace_info): Rename from
9760 auto_load_pspace_data_cleanup.
9761 (get_auto_load_pspace_data, init_loaded_scripts_info)
9762 (clear_section_scripts, maybe_print_unsupported_script_warning)
9763 (maybe_print_script_not_found_warning, _initialize_auto_load):
9764 Update.
9765
9766 2019-05-08 Tom Tromey <tom@tromey.com>
9767
9768 * objfiles.c (objfile_pspace_info): Add destructor and
9769 initializers.
9770 (objfiles_pspace_data): Change type.
9771 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9772 (get_objfile_pspace_data): Update.
9773 (objfiles_bfd_data): Change type.
9774 (get_objfile_bfd_data): Update.
9775 (objfile_bfd_data_free, _initialize_objfiles): Remove.
9776
9777 2019-05-08 Tom Tromey <tom@tromey.com>
9778
9779 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9780 Change type.
9781 (get_catch_syscall_inferior_data): Update.
9782 (catch_syscall_inferior_data_cleanup): Remove.
9783 (_initialize_break_catch_syscall): Update.
9784
9785 2019-05-08 Tom Tromey <tom@tromey.com>
9786
9787 * inflow.c (struct terminal_info): Add destructor and
9788 initializers.
9789 (inflow_inferior_data): Change type.
9790 (~terminal_info): Rename from inflow_inferior_data_cleanup.
9791 (get_inflow_inferior_data, inflow_inferior_exit)
9792 (swap_terminal_info, _initialize_inflow): Update.
9793
9794 2019-05-08 Tom Tromey <tom@tromey.com>
9795
9796 * target-dcache.c (target_dcache_cleanup): Remove.
9797 (target_dcache_aspace_key): Change type.
9798 (target_dcache_init_p, target_dcache_invalidate)
9799 (target_dcache_get, target_dcache_get_or_init)
9800 (_initialize_target_dcache): Update.
9801 * dcache.h (struct dcache_deleter): New.
9802
9803 2019-05-08 Tom Tromey <tom@tromey.com>
9804
9805 * symtab.c (struct symbol_cache): Add destructor and
9806 initializers.
9807 (symbol_cache_key): Move. Change type.
9808 (make_symbol_cache, free_symbol_cache): Remove.
9809 (get_symbol_cache): Update.
9810 (symbol_cache_cleanup): Remove.
9811 (ALL_PSPACES, symbol_cache_flush)
9812 (maintenance_print_symbol_cache)
9813 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9814 Update.
9815
9816 2019-05-08 Tom Tromey <tom@tromey.com>
9817
9818 * symtab.c (struct main_info): Add destructor and initializers.
9819 (main_progspace_key): Move. Change type.
9820 (get_main_info): Update.
9821 (main_info_cleanup): Remove.
9822 (_initialize_symtab): Update.
9823
9824 2019-05-08 Tom Tromey <tom@tromey.com>
9825
9826 * registry.h (DECLARE_REGISTRY): Define the _key class.
9827
9828 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
9829
9830 * NEWS: Merge two 'New commands' sections.
9831
9832 2019-05-08 Joel Brobecker <brobecker@adacore.com>
9833
9834 * ada-valprint.c (ada_val_print_gnat_array): Remove language
9835 parameter and use Ada language definition instead.
9836 (ada_val_print_ptr): Remove unused language parameter.
9837 (ada_val_print_num): Remove language parameter and use Ada language
9838 definition instead.
9839 (ada_val_print_enum, ada_val_print_flt): Remove unused language
9840 parameter.
9841 (ada_val_print_struct_union, ada_val_print_ref): Remove language
9842 parameter and use Ada language definition instead.
9843 (ada_val_print_1): Update all ada_val_print_xxx calls.
9844 Remove language parameter.
9845 (ada_val_print): Update ada_val_print_1 call.
9846
9847 2019-05-08 Tom Tromey <tromey@adacore.com>
9848
9849 * remote.c (remote_hw_watchpoint_limit)
9850 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
9851 Now static.
9852
9853 2019-05-08 Tom Tromey <tromey@adacore.com>
9854
9855 * maint.c (_initialize_maint_cmds): Move initialization code to
9856 remote.c.
9857 (watchdog, show_watchdog): Move to remote.c.
9858 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
9859 "watchdog" static.
9860 (_initialize_remote): Move initialization code from maint.c.
9861 * defs.h (watchdog): Don't declare.
9862
9863 2019-05-08 Tom Tromey <tromey@adacore.com>
9864
9865 * tui/tui-interp.c: Include main.h.
9866 * interps.c: Include main.h.
9867 * main.h (interpreter_p): Declare.
9868 * defs.h (interpreter_p): Don't declare.
9869
9870 2019-05-08 Tom Tromey <tromey@adacore.com>
9871
9872 * dwarf2loc.c: Include dwarf2read.h.
9873 * defs.h (read_unsigned_leb128): Don't declare.
9874 * dwarf2read.h (read_unsigned_leb128): Declare.
9875
9876 2019-05-08 Tom Tromey <tromey@adacore.com>
9877
9878 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
9879 method.
9880
9881 2019-05-08 Tom Tromey <tromey@adacore.com>
9882
9883 * utils.c (fputs_maybe_filtered): Reset style after paging, even
9884 when no wrap column is set.
9885
9886 2019-05-08 Tom Tromey <tromey@adacore.com>
9887
9888 * c-lang.c (c_get_string): Handle non-C-style arrays.
9889
9890 2019-05-08 Tom Tromey <tromey@adacore.com>
9891
9892 * typeprint.c (print_offset_data::update): Print the bit offset,
9893 not the number of bits remaining.
9894
9895 2019-05-08 Tom Tromey <tromey@adacore.com>
9896
9897 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
9898 padding at end of comment.
9899
9900 2019-05-08 Tom Tromey <tromey@adacore.com>
9901
9902 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
9903 Compare main types.
9904
9905 2019-05-06 Tom Tromey <tom@tromey.com>
9906
9907 * common/scoped_mmap.c: Include common-defs.h.
9908 * common/scoped_mmap.h: Don't include config.h.
9909
9910 2019-05-04 Tom Tromey <tom@tromey.com>
9911
9912 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
9913 (struct aarch64_call_info): Add initializers.
9914 <si>: Now a std::vector.
9915 (pass_on_stack, aarch64_push_dummy_call): Update.
9916
9917 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
9918 Tom Tromey <tom@tromey.com>
9919
9920 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
9921 (ppc_threads): Now a std::vector. Now static.
9922 (hwdebug_find_thread_points_by_tid)
9923 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
9924 Update.
9925
9926 2019-05-04 Tom Tromey <tom@tromey.com>
9927
9928 * arc-tdep.c (arc_tdesc_init): Return bool.
9929
9930 2019-05-04 Tom Tromey <tom@tromey.com>
9931
9932 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
9933 Use gdb_assert_not_reached.
9934
9935 2019-05-04 Tom Tromey <tom@tromey.com>
9936
9937 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
9938 "false".
9939
9940 2019-05-04 Tom Tromey <tom@tromey.com>
9941
9942 * arc-tdep.c (arc_tdesc_init): Use bool.
9943
9944 2019-05-04 Tom Tromey <tom@tromey.com>
9945
9946 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
9947
9948 2019-05-04 Tom Tromey <tom@tromey.com>
9949
9950 * cli/cli-cmds.c (valid_command_p): Return bool.
9951
9952 2019-05-04 Tom Tromey <tom@tromey.com>
9953
9954 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
9955 * command.h (valid_user_defined_cmd_name_p): Channge return type.
9956
9957 2019-05-04 Raul Tambre <raul@tambre.ee>
9958
9959 * python/lib/gdb/prompt.py (_ExtendedPrompt)
9960 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
9961 operator for comparison.
9962
9963 2019-05-04 Tom Tromey <tom@tromey.com>
9964
9965 * psymtab.c (psymbol_name_matches, match_partial_symbol)
9966 (lookup_partial_symbol, print_partial_symbols)
9967 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
9968 (psymbol_compare): Update.
9969 (add_psymbol_to_bcache): Clear the entire psymbol.
9970 (maintenance_check_psymtabs): Update.
9971 * psympriv.h (struct partial_symbol): Don't derive from
9972 general_symbol_info.
9973 <obj_section, unrelocated_address, address,
9974 set_unrelocated_address>: Update.
9975 <ginfo>: New member.
9976 * dwarf-index-write.c (write_psymbols, debug_names::insert)
9977 (debug_names::write_psymbols): Update.
9978
9979 2019-05-04 Tom de Vries <tdevries@suse.de>
9980
9981 * contrib/cc-with-tweaks.sh: Support -n arg.
9982
9983 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9984
9985 * corelow.c (core_target::detach): Ensure frame cache and
9986 register caches are cleared.
9987 inferior.c (exit_inferior_1): Likewise.
9988
9989 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
9990 Tom Tromey <tom@tromey.com>
9991
9992 * dictionary.c (collate_pending_symbols_by_language): Remove
9993 "struct" from foreach.
9994 * symtab.c (lookup_global_symbol_from_objfile)
9995 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
9996 foreach.
9997 * ser-tcp.c (net_open): Remove "struct" from foreach.
9998 * objfiles.c (objfile_relocate, objfile_rebase)
9999 (objfile_has_symbols): Remove "struct" from foreach.
10000 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10001 from foreach.
10002 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10003 foreach.
10004 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10005 "struct" from foreach.
10006 * ada-lang.c (create_excep_cond_exprs)
10007 (ada_exception_catchpoint_cond_string): Remove "struct" from
10008 foreach.
10009
10010 2019-05-03 Tom Tromey <tromey@adacore.com>
10011
10012 * ada-exp.y (convert_char_literal): Check suffix of each
10013 enumerator.
10014
10015 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10016
10017 PR ada/21406:
10018 * ada-exp.y (yywrap): Don't define.
10019 * ada-lex.l (%option): Add noyywrap
10020 (yywrap): Remove.
10021
10022 2019-05-03 Eli Zaretskii <eliz@gnu.org>
10023
10024 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10025 _WIN32_WINNT to the XP level, unless already defined to a higher
10026 level.
10027
10028 * unittests/parse-connection-spec-selftests.c:
10029 * ser-tcp.c:
10030 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10031 override.
10032
10033 * symfile.c (find_separate_debug_file): Remove colon from the
10034 drive spec of DOS/Windows file names of the target, so that the
10035 file name produced from DEBUGDIR and the target's directory will
10036 be valid on DOS/Windows systems.
10037
10038 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10039
10040 * rust-lang.c (val_print_struct): Handle printing structures
10041 containing strings.
10042
10043 2019-05-02 Tom Tromey <tromey@adacore.com>
10044
10045 * valarith.c (_initialize_valarith): Remove.
10046
10047 2019-05-01 Tom Tromey <tromey@adacore.com>
10048
10049 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10050 bitfields.
10051
10052 2019-05-01 Tom Tromey <tromey@adacore.com>
10053
10054 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10055 for big-endian copies.
10056
10057 2019-04-30 Ali Tamur <tamur@google.com>
10058 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10059 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10060 (read_3_bytes): New function.
10061
10062 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10063
10064 * windows-nat.c (main_thread_id): Delete.
10065 (handle_output_debug_string): Replace main_thread_id by
10066 current_event.dwThreadId.
10067 (fake_create_process): Likewise.
10068 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10069 Do not set main_thread_id.
10070 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10071 current_event.dwThreadId.
10072 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10073
10074 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10075
10076 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10077 Use current_event.dwThreadId instead of main_thread_id.
10078
10079 2019-04-30 Tom Tromey <tromey@adacore.com>
10080
10081 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10082 (create_excep_cond_exprs): Iterate over program spaces.
10083 (ada_exception_catchpoint_cond_string): Examine all minimal
10084 symbols for exception types.
10085
10086 2019-04-30 Tom Tromey <tromey@adacore.com>
10087
10088 PR c++/24470:
10089 * dwarf2read.c (process_structure_scope): Handle case where type
10090 has template parameters but no symbol was created.
10091
10092 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10093 Chris January <chris.january@arm.com>
10094
10095 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10096 qualifier.
10097 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10098
10099 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10100
10101 * f-typeprint.c (f_print_type): Update rules for printing
10102 whitespace.
10103 (f_type_print_varspec_suffix): Likewise.
10104
10105 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10106 Chris January <chris.january@arm.com>
10107
10108 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10109 function arguments.
10110
10111 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10112
10113 * f-lang.c (build_fortran_types): Change name of void type to
10114 lower case.
10115 * f-typeprint.c (f_type_print_base): Print the name of the void
10116 type, rather than a fixed string.
10117 * f-valprint.c (f_decorations): Use lower case void string.
10118
10119 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10120 Chris January <chris.january@arm.com>
10121
10122 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10123 types for Fortran.
10124
10125 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10126 Chris January <chris.january@arm.com>
10127 David Lecomber <david.lecomber@arm.com>
10128
10129 * f-exp.y (BINOP_INTRINSIC): New token.
10130 (exp): New parser rule handling BINOP_INTRINSIC.
10131 (f77_keywords): Add new builtin procedures.
10132 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10133 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10134 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10135 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10136 (print_unop_subexp_f): New function.
10137 (print_binop_subexp_f): New function.
10138 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10139 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10140 (dump_subexp_body_f): Likewise.
10141 (operator_check_f): Likewise.
10142 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10143 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10144
10145 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10146
10147 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10148 UNOP_KIND.
10149 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10150 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10151 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10152 (operator_length_f): New fuction.
10153 (print_subexp_f): New function.
10154 (op_name_f): New function.
10155 (dump_subexp_body_f): New function.
10156 (operator_check_f): New function.
10157 (exp_descriptor_f): Replace standard expression handling functions
10158 with new functions.
10159 * gdb/fortran-operator.def: New file.
10160 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10161 * gdb/std-operator.def: Remove UNOP_KIND.
10162
10163 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10164
10165 * std-operator.def: Remove unbalanced, stray double quote
10166 character.
10167
10168 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10169 Chris January <chris.january@arm.com>
10170 Daniel Everett <daniel.everett@arm.com>
10171 Nick Forrington <nick.forrington@arm.com>
10172 Richard Bunt <richard.bunt@arm.com>
10173
10174 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10175 of depth when printing anonymous structs or unions.
10176 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10177 Don't print either the top-level value, or the children if the
10178 max-depth is exceeded.
10179 (ppscm_print_children): When printing the key of a map, allow one
10180 extra level of depth.
10181 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10182 print either the top-level value, or the children if the max-depth
10183 is exceeded.
10184 (print_children): When printing the key of a map, allow one extra
10185 level of depth.
10186 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10187 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10188 (user_print_options): Initialise max_depth field.
10189 (val_print_scalar_or_string_type_p): New function.
10190 (val_print): Check to see if the max depth has been reached.
10191 (val_print_check_max_depth): Define new function.
10192 (show_print_max_depth): New function.
10193 (_initialize_valprint): Add 'print max-depth' option.
10194 * valprint.h (struct value_print_options) <max_depth>: New field.
10195 (val_print_check_max_depth): Declare new function.
10196 * NEWS: Document new feature.
10197
10198 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10199
10200 * ada-lang.c (ada_language_defn): Initialise new field.
10201 * c-lang.c (c_is_string_type_p): New function.
10202 (c_language_defn): Initialise new field.
10203 (cplus_language_defn): Initialise new field.
10204 (asm_language_defn): Initialise new field.
10205 (minimal_language_defn): Initialise new field.
10206 * c-lang.h (c_is_string_type_p): Declare new function.
10207 * d-lang.c (d_language_defn): Initialise new field.
10208 * f-lang.c (f_is_string_type_p): New function.
10209 (f_language_defn): Initialise new field.
10210 * go-lang.c (go_is_string_type_p): New function.
10211 (go_language_defn): Initialise new field.
10212 * language.c (default_is_string_type_p): New function.
10213 (unknown_language_defn): Initialise new field.
10214 (auto_language_defn): Initialise new field.
10215 * language.h (struct language_defn) <la_is_string_type_p>: New
10216 member variable.
10217 (default_is_string_type_p): Declare new function.
10218 * m2-lang.c (m2_language_defn): Initialise new field.
10219 * objc-lang.c (objc_language_defn): Initialise new field.
10220 * opencl-lang.c (opencl_language_defn): Initialise new field.
10221 * p-lang.c (pascal_is_string_type_p): New function.
10222 (pascal_language_defn): Initialise new field.
10223 * rust-lang.c (rust_is_string_type_p): New function.
10224 (rust_language_defn): Initialise new field.
10225
10226 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10227
10228 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10229 New field.
10230 * ada-lang.c (ada_language_defn): Initialise new field.
10231 * c-lang.c (c_language_defn): Likewise.
10232 (cplus_language_defn): Likewise.
10233 (asm_language_defn): Likewise.
10234 (minimal_language_defn): Likewise.
10235 * d-lang.c (d_language_defn): Likewise.
10236 * f-lang.c (f_language_defn): Likewise.
10237 * go-lang.c (go_language_defn): Likewise.
10238 * language.c (unknown_language_defn): Likewise.
10239 (auto_language_defn): Likewise.
10240 * m2-lang.c (m2_language_defn): Likewise.
10241 * objc-lang.c (objc_language_defn): Likewise.
10242 * opencl-lang.c (opencl_language_defn): Likewise.
10243 * p-lang.c (pascal_language_defn): Likewise.
10244 * rust-lang.c (rust_language_defn): Likewise.
10245
10246 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10247
10248 * ada-lang.c (ada_is_character_type): Change return type to bool.
10249 (ada_is_string_type): Likewise.
10250 * ada-lang.h (ada_is_character_type): Update declaration
10251 (ada_is_string_type): Likewise.
10252
10253 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10254
10255 Support style in 'frame|thread apply'
10256
10257 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10258 * record.c (record_start, record_stop): Update callers of
10259 execute_command_to_string with false.
10260 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10261 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10262 methods.
10263 (class string_file): New constructor with term_out parameter.
10264 Override methods term_out and can_emit_style_escape. New member
10265 term_out.
10266 (class stdio_file): Override can_emit_style_escape.
10267 (class tee_file): Override term_out and can_emit_style_escape.
10268 * utils.h (can_emit_style_escape): Remove.
10269 * utils.c (can_emit_style_escape): Likewise.
10270 Update all callers of can_emit_style_escape (SOMESTREAM) to
10271 SOMESTREAM->can_emit_style_escape.
10272 * source-cache.c (source_cache::get_source_lines): Likewise.
10273 * stack.c (frame_apply_command_count): Call execute_command_to_string
10274 passing the term_out characteristic of the current gdb_stdout.
10275 * thread.c (thr_try_catch_cmd): Likewise.
10276 * top.c (execute_command_to_string): pass term_out parameter
10277 to construct the string_file for the command output.
10278 * ui-file.c (term_cli_styling): New function (most code moved
10279 from utils.c can_emit_style_escape).
10280 (string_file::string_file, string_file::can_emit_style_escape,
10281 stdio_file::can_emit_style_escape, tee_file::term_out,
10282 tee_file::can_emit_style_escape): New functions.
10283
10284 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10285
10286 * NEWS: Mention the new set|show may-call-functions.
10287 * infcall.c (may_call_functions_p): New variable.
10288 (show_may_call_functions_p): New function.
10289 (call_function_by_hand_dummy): Throws an error if not
10290 may-call-functions.
10291 (_initialize_infcall): Call add_setshow_boolean_cmd for
10292 may-call-functions.
10293
10294 2019-04-25 Keith Seitz <keiths@redhat.com>
10295
10296 PR c++/24367
10297 * cp-support.c (inspect_type): Don't attempt substitutions
10298 of symbol with the same name.
10299
10300 2019-04-25 Tom Tromey <tromey@adacore.com>
10301
10302 PR gdb/24475:
10303 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10304 static.
10305
10306 2019-04-25 Tom Tromey <tromey@adacore.com>
10307
10308 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10309 rvalue reference.
10310 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10311 (gdb_xml_parser::parse): Use std::move.
10312 * python/python-internal.h (gdbpy_convert_exception): Take a const
10313 reference.
10314 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10315 std::move.
10316 * python/py-utils.c (gdbpy_convert_exception): Take a const
10317 reference.
10318 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10319 Use std::move.
10320 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10321 Use std::move.
10322 * mi/mi-main.c (mi_print_exception): Take a const reference.
10323 * main.c (handle_command_errors): Take a const reference.
10324 * linespec.c (parse_linespec): Use std::move.
10325 * infcall.c (run_inferior_call): Use std::move.
10326 (call_function_by_hand_dummy): Use std::move.
10327 * exec.c (try_open_exec_file): Use std::move.
10328 * exceptions.h (exception_print, exception_fprintf)
10329 (exception_print_same): Update.
10330 * exceptions.c (print_exception, exception_print)
10331 (exception_fprintf, exception_print_same): Change parameters to
10332 const reference.
10333 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10334 * common/new-op.c: Use std::move.
10335 * common/common-exceptions.h (struct gdb_exception): Add move
10336 constructor.
10337 (struct gdb_exception_error, struct gdb_exception_quit, struct
10338 gdb_quit_bad_alloc): Change constructor to move constructor.
10339 (throw_exception): Change parameter to rvalue reference.
10340 * common/common-exceptions.c (throw_exception): Take rvalue
10341 reference.
10342 * cli/cli-interp.c (safe_execute_command): Use std::move.
10343 * breakpoint.c (insert_bp_location, location_to_sals): Use
10344 std::move.
10345
10346 2019-04-25 Tom Tromey <tromey@adacore.com>
10347
10348 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10349 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10350 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10351 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10352 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10353 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10354 guile/scm-value.c: Use unpack.
10355 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10356 gdbscm_gdb_exception.
10357 (gdbscm_throw_gdb_exception): Likewise.
10358 (struct gdbscm_gdb_exception): New.
10359 (unpack): New function.
10360 (gdbscm_wrap): Use unpack.
10361
10362 2019-04-25 Tom Tromey <tromey@adacore.com>
10363
10364 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10365 (gdb_rl_callback_handler): Use std::move.
10366 * common/common-exceptions.h (struct gdb_exception): Add move
10367 assignment operator.
10368 (throw_exception_sjlj): Change "exception" to const reference.
10369 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10370 (throw_exception_sjlj): Change "exception" to const reference.
10371
10372 2019-04-25 Tom Tromey <tromey@adacore.com>
10373
10374 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10375 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10376 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10377 Update.
10378 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10379 Update.
10380 * mi/mi-interp.c (mi_interp::exec): Update.
10381 * linespec.c (parse_linespec): Update.
10382 * infcall.c (run_inferior_call): Update.
10383 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10384 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10385 (gdbscm_lookup_global_symbol): Update.
10386 * guile/scm-param.c (gdbscm_parameter_value): Update.
10387 * guile/scm-frame.c (gdbscm_frame_read_register)
10388 (gdbscm_frame_read_var): Update.
10389 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10390 * exec.c (try_open_exec_file): Update.
10391 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10392 (gdb_rl_callback_handler): Update.
10393 * common/common-exceptions.h (exception_none): Don't declare.
10394 * common/common-exceptions.c (exception_none): Don't define.
10395 (struct catcher) <exception>: Update.
10396 * cli/cli-interp.c (safe_execute_command): Update.
10397 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10398
10399 2019-04-25 Ali Tamur <tamur@google.com>
10400
10401 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10402 (read_attribute_value): Likewise.
10403 (dwarf2_read_addr_index): Update comment.
10404 (read_str_index): Add DW_FORM_strx.
10405 (dwarf2_string_attr): Likewise.
10406 (dwarf2_const_value_attr): Likewise.
10407 (dump_die_shallow): Likewise.
10408 (dwarf2_fetch_constant_bytes): Likewise.
10409 (skip_form_bytes): Likewise.
10410 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10411
10412 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10413
10414 PR corefiles/11608
10415 PR corefiles/18187
10416 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10417 OFFSET. Verify if current mapping contains an ELF header.
10418 (linux_find_memory_regions_full): Adjust call to
10419 dump_mapping_p.
10420
10421 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10422 Kang Li <kanglictf@gmail.com>
10423
10424 PR gdb/21600
10425
10426 * dwarf2-frame.c (read_initial_length): Be consistent about using
10427 unsigned representation of length.
10428 (decode_frame_entry_1): Likewise. Check for wraparound of
10429 end pointer as well as buffer overflow.
10430
10431 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10432
10433 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10434 "vq".
10435
10436 2019-04-24 Tom Tromey <tromey@adacore.com>
10437
10438 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10439
10440 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10441
10442 * s12z-tdep.c (s12z_unwind_pc): Delete.
10443 (s12z_unwind_sp): Delete.
10444 (s12z_gdbarch_init): Don't register deleted functions with
10445 gdbarch.
10446
10447 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10448
10449 * rl78-tdep.c (rl78_unwind_sp): Delete.
10450 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10451
10452 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10453
10454 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10455 (xstormy16_unwind_pc): Delete.
10456 (xstormy16_dummy_id): Delete.
10457 (xstormy16_gdbarch_init): Don't register deleted functions with
10458 gdbarch.
10459
10460 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10461
10462 * vax-tdep.c (vax_unwind_pc): Delete.
10463 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10464
10465 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10466
10467 * v850-tdep.c (v850_unwind_sp): Delete.
10468 (v850_unwind_pc): Delete.
10469 (v850_dummy_id): Delete.
10470 (v850_gdbarch_init): Don't register deleted functions with
10471 gdbarch.
10472
10473 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10474
10475 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10476 (tilegx_unwind_pc): Delete.
10477 (tilegx_unwind_dummy_id): Delete.
10478 (tilegx_gdbarch_init): Don't register deleted functions with
10479 gdbarch.
10480
10481 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10482
10483 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10484 (tic6x_dummy_id): Delete.
10485 (tic6x_gdbarch_init): Don't register deleted functions with
10486 gdbarch.
10487
10488 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10489
10490 * sparc-tdep.c (sparc_unwind_pc): Delete.
10491 (sparc32_gdbarch_init): Don't register deleted function with
10492 gdbarch.
10493
10494 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10495
10496 * sh-tdep.c (sh_unwind_sp): Delete.
10497 (sh_unwind_pc): Delete.
10498 (sh_dummy_id): Delete.
10499 (sh_gdbarch_init): Don't register deleted functions with
10500 gdbarch.
10501
10502 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10503
10504 * score-tdep.c (score_unwind_sp): Delete.
10505 (score_unwind_pc): Delete.
10506 (score_dummy_id): Delete.
10507 (score_gdbarch_init): Don't register deleted functions with
10508 gdbarch.
10509
10510 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10511
10512 * rx-tdep.c (rx_unwind_pc): Delete.
10513 (rx_unwind_sp): Delete.
10514 (rx_dummy_id): Delete.
10515 (rx_gdbarch_init): Don't register deleted functions with
10516 gdbarch. Update comment.
10517
10518 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10519
10520 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10521 (rs6000_dummy_id): Delete.
10522 (rs6000_gdbarch_init): Don't register deleted functions with
10523 gdbarch.
10524
10525 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10526
10527 * or1k-tdep.c (or1k_dummy_id): Delete.
10528 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10529
10530 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10531
10532 * nios2-tdep.c (nios2_dummy_id): Delete.
10533 (nios2_unwind_sp): Delete.
10534 (nios2_gdbarch_init): Don't register deleted functions with
10535 gdbarch.
10536
10537 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10538
10539 * nds32-tdep.c (nds32_dummy_id): Delete.
10540 (nds32_unwind_pc): Delete.
10541 (nds32_unwind_sp): Delete.
10542 (nds32_gdbarch_init): Don't register deleted functions with
10543 gdbarch.
10544
10545 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10546
10547 * msp430-tdep.c (msp430_unwind_pc): Delete.
10548 (msp430_unwind_sp): Delete.
10549 (msp430_dummy_id): Delete.
10550 (msp430_gdbarch_init): Don't register deleted functions with
10551 gdbarch.
10552
10553 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10554
10555 * moxie-tdep.c (moxie_unwind_sp): Delete.
10556 (moxie_unwind_pc): Delete.
10557 (moxie_dummy_id): Delete.
10558 (moxie_gdbarch_init): Don't register deleted functions with
10559 gdbarch.
10560
10561 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10562
10563 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10564 (mn10300_unwind_pc): Delete.
10565 (mn10300_unwind_sp): Delete.
10566 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10567 mn10300_unwind_sp.
10568 (mn10300_frame_unwind_init): Don't register deleted functions with
10569 gdbarch.
10570
10571 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10572
10573 * mep-tdep.c (mep_unwind_pc): Delete.
10574 (mep_unwind_sp): Delete.
10575 (mep_dummy_id): Delete.
10576 (mep_gdbarch_init): Don't register deleted functions with
10577 gdbarch.
10578
10579 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10580
10581 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10582 (m68hc11_unwind_sp): Delete.
10583 (m68hc11_gdbarch_init): Don't register deleted functions with
10584 gdbarch.
10585
10586 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10587
10588 * m32r-tdep.c (m32r_unwind_sp): Delete.
10589 (m32r_unwind_pc): Delete.
10590 (m32r_dummy_id): Delete.
10591 (m32r_gdbarch_init): Don't register deleted functions with
10592 gdbarch.
10593
10594 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10595
10596 * m32c-tdep.c (m32c_unwind_pc): Delete.
10597 (m32c_unwind_sp): Delete.
10598 (m32c_dummy_id): Delete.
10599 (m32c_gdbarch_init): Don't register deleted functions with
10600 gdbarch.
10601
10602 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10603
10604 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10605 (lm32_unwind_pc): Delete.
10606 (lm32_dummy_id): Delete.
10607 (lm32_gdbarch_init): Don't register deleted functions with
10608 gdbarch.
10609
10610 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10611
10612 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10613 (iq2000_unwind_pc): Delete.
10614 (iq2000_dummy_id): Delete.
10615 (iq2000_gdbarch_init): Don't register deleted functions with
10616 gdbarch.
10617
10618 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10619
10620 * nds32-tdep.c (nds32_type_align): Delete.
10621 (nds32_push_dummy_call): Use type_align instead.
10622
10623 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10624
10625 * arm-tdep.c (arm_type_align): Only handle vector override case.
10626 (arm_push_dummy_call): Use type_align.
10627 (arm_gdbarch_init): Register arm_type_align gdbarch function.
10628
10629 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10630
10631 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10632 case.
10633 (pass_on_stack): Use type_align.
10634 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10635 function.
10636
10637 2019-04-23 Tom Tromey <tromey@adacore.com>
10638
10639 * dwarf2read.c (line_header::file_name_at): Remove unused
10640 overload.
10641
10642 2019-04-23 Tom de Vries <tdevries@suse.de>
10643
10644 PR gdb/24438
10645 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10646 invocation.
10647
10648
10649 2019-03-27 Ali Tamur <tamur@google.com>
10650
10651 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10652 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10653 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10654 (dwarf_expr_context::get_addr_index): Likewise
10655 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10656 (symbol_needs_eval_context::get_addr_index): Likewise
10657 (disassemble_dwarf_expression): Add DW_OP_addrx
10658 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10659 (read_cutu_die_from_dwo): Update comment
10660 (skip_one_die): Add DW_FORM_addrx
10661 (read_attribute_value): Likewise
10662 (var_decode_location): Add DW_OP_addrx
10663 (dwarf2_const_value_attr): Add DW_FORM_addrx
10664 (dump_die_shallow): Likewise
10665 (dwarf2_fetch_constant_bytes): Likewise
10666 (decode_locdesc): Add DW_OP_addrx
10667 (skip_form_bytes): Add DW_FORM_addrx
10668
10669 2019-04-22 Ali Tamur <tamur@google.com>
10670
10671 * MAINTAINERS (Write After Approval): Add self.
10672
10673 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
10674
10675 * solib-svr4.c (get_svr4_info): Add pspace parameter.
10676 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10677 (open_symbol_file_object): Likewise.
10678 (svr4_default_sos): Add info parameter.
10679 (svr4_read_so_list): Likewise.
10680 (svr4_current_sos_direct): Adjust functions calls to pass down
10681 info.
10682 (svr4_current_sos_1): Add info parameter.
10683 (svr4_current_sos): Call get_svr4_info, pass info down to
10684 svr4_current_sos_1.
10685 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10686 get_svr4_info.
10687 (svr4_in_dynsym_resolve_code): Pass current_program_space to
10688 get_svr4_info.
10689 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10690 to get_svr4_info.
10691 (probes_table_remove_objfile_probes): Likewise.
10692 (register_solib_event_probe): Add info parameter.
10693 (solist_update_incremental): Pass info parameter down to
10694 svr4_read_so_list.
10695 (disable_probes_interface): Add info parameter.
10696 (svr4_handle_solib_event): Pass current_program_space to
10697 get_svr4_info. Adjust disable_probes_interface cleanup.
10698 (svr4_create_probe_breakpoints): Add info parameter, pass it
10699 down to register_solib_event_probe.
10700 (svr4_create_solib_event_breakpoints): Add info parameter,
10701 pass it down to svr4_create_probe_breakpoints.
10702 (enable_break): Pass info down to
10703 svr4_create_solib_event_breakpoints.
10704 (svr4_solib_create_inferior_hook): Pass current_program_space to
10705 get_svr4_info.
10706 (svr4_clear_solib): Likewise.
10707
10708 2019-04-22 Pedro Alves <palves@redhat.com>
10709
10710 * solib-svr4.c (svr4_free_objfile_observer): New.
10711 (probe_and_action::objfile): New field.
10712 (probes_table_htab_remove_objfile_probes)
10713 (probes_table_remove_objfile_probes): New functions.
10714 (register_solib_event_probe): Add 'objfile' parameter. Store it
10715 in the new probe_and_action. Don't store the probe in 'lookup'.
10716 (svr4_create_probe_breakpoints): Pass objfile to
10717 register_solib_event_probe.
10718 (_initialize_svr4_solib): Register a free_objfile observer.
10719
10720 2019-04-19 Tom Tromey <tom@tromey.com>
10721
10722 * common/queue.h: Remove.
10723
10724 2019-04-19 Tom Tromey <tom@tromey.com>
10725
10726 * event-loop.c: Don't include "common/queue.h".
10727
10728 2019-04-19 Tom Tromey <tom@tromey.com>
10729
10730 * remote.c (remote_target): Use delete.
10731 * remote-notif.h: Include <list>, not "common/queue.h".
10732 (notif_client_p): Remove typedef.
10733 (remote_notif_state): Add constructor, destructor, initializer.
10734 <notif_queue>: Now a std::list.
10735 (remote_notif_state_xfree): Don't declare.
10736 * remote-notif.c (remote_notif_process, handle_notification)
10737 (remote_notif_state_allocate): Update.
10738 (~remote_notif_state): Rename from remote_notif_state_xfree.
10739
10740 2019-04-19 Tom Tromey <tom@tromey.com>
10741
10742 * symfile.c (reread_symbols): Update.
10743 * objfiles.c (objfile_register_static_link)
10744 (objfile_lookup_static_link): Update
10745 (~objfile) Don't delete static_links.
10746 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10747
10748 2019-04-19 Tom Tromey <tom@tromey.com>
10749
10750 * type-stack.h (struct type_stack) <insert>: Constify string.
10751 * type-stack.c (type_stack::insert): Constify string.
10752 * gdbtypes.h (lookup_template_type): Update.
10753 (address_space_name_to_int): Update.
10754 * gdbtypes.c (address_space_name_to_int): Make space_identifier
10755 const.
10756 (lookup_template_type): Make name const.
10757 * c-exp.y: Update rules.
10758 (lex_one_token, classify_name, classify_inner_name)
10759 (c_print_token): Update.
10760 * p-exp.y: Update rules.
10761 (yylex): Update.
10762 * f-exp.y: Update rules.
10763 (yylex): Update.
10764 * d-exp.y: Update rules.
10765 (lex_one_token, classify_name, classify_inner_name): Update.
10766 * parse.c (write_dollar_variable, copy_name): Return std::string.
10767 * parser-defs.h (copy_name): Change return type.
10768 * m2-exp.y: Update rules.
10769 (yylex): Update.
10770 * go-exp.y (lex_one_token): Update.
10771 Update rules.
10772 (classify_unsafe_function, classify_packaged_name)
10773 (classify_name, yylex): Update.
10774
10775 2019-04-19 Sergei Trofimovich <siarheit@google.com>
10776
10777 * configure.ac: add --enable-source-highlight switch.
10778 * configure: Regenerate.
10779 * top.c (print_gdb_version): plumb --enable-source-highlight
10780 status to "show configuration".
10781
10782 2019-04-19 Tom Tromey <tromey@adacore.com>
10783
10784 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10785 Check ADA_TYPE_P.
10786 (empty_record, ada_template_to_fixed_record_type_1)
10787 (template_to_static_fixed_type)
10788 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10789 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10790 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10791 macros.
10792
10793 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
10794
10795 PR symtab/24423:
10796 * source.c (print_source_lines_base): Advance "iter" when a
10797 control character is seen.
10798
10799 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10800
10801 * inferior.h (struct infcall_suspend_state_deleter):
10802 Catch exception in destructor to avoid crash.
10803
10804 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10805
10806 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10807 close to the add_com "shell".
10808
10809 2019-04-18 Tom Tromey <tromey@adacore.com>
10810
10811 * process-stratum-target.h (class process_stratum_target)
10812 <stratum>: Add "final".
10813
10814 2019-04-17 Tom Tromey <tromey@adacore.com>
10815
10816 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10817 against nullptr before use.
10818
10819 2019-04-17 Alan Hayward <alan.hayward@arm.com>
10820
10821 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10822
10823 2019-04-17 Jim Wilson <jimw@sifive.com>
10824 Andrew Burgess <andrew.burgess@embecosm.com>
10825
10826 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10827 code read might fail, assume 4-byte breakpoint in that case.
10828
10829 2019-04-15 Leszek Swirski <leszeks@google.com>
10830
10831 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10832 rather than a hand-rolled POD check when checking for forced MEMORY
10833 classification.
10834
10835 2019-04-15 Alan Hayward <alan.hayward@arm.com>
10836
10837 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
10838 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
10839 function.
10840 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
10841 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
10842 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
10843 declaration.
10844
10845 2019-04-15 Alan Hayward <alan.hayward@arm.com>
10846
10847 * aarch64-linux-nat.c
10848 (aarch64_linux_nat_target::thread_architecture): Add override.
10849 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
10850 each VQ.
10851
10852 2019-04-15 Alan Hayward <alan.hayward@arm.com>
10853
10854 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
10855
10856 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
10857
10858 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
10859 target types of size 96-bits, add some additional comments, and
10860 check that the builtin type we found was the correct size.
10861
10862 2019-04-12 Eli Zaretskii <eliz@gnu.org>
10863
10864 * utils.c (prompt_for_continue): Don't restore the styling at the
10865 end, as applied_style has the wrong value. This fixes styling in
10866 long lists of file names that are interrupted by the "Continue?"
10867 prompt.
10868
10869 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
10870
10871 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
10872 * c-lang.c (c_language_defn): Likewise.
10873 (cplus_language_defn): Likewise.
10874 (asm_language_defn): Likewise.
10875 (minimal_language_defn): Likewise.
10876 * d-lang.c (d_language_defn): Likewise.
10877 * f-lang.c (f_language_defn): Likewise.
10878 * go-lang.c (go_language_defn): Likewise.
10879 * language.c (unknown_language_defn): Likewise.
10880 (auto_language_defn): Likewise.
10881 * language.h (struct language_defn): Remove la_magic field.
10882 (LANG_MAGIC): Delete.
10883 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
10884 * objc-lang.c (objc_language_defn): Likewise.
10885 * opencl-lang.c (opencl_language_defn): Likewise.
10886 * p-lang.c (pascal_language_defn): Likewise.
10887 * rust-lang.c (rust_language_defn): Likewise.
10888
10889 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
10890
10891 * riscv-tdep.c (riscv_type_align): New function.
10892 (riscv_type_alignment): Delete.
10893 (riscv_arg_location): Use 'type_align'.
10894 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
10895
10896 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
10897
10898 * gdbtypes.c (type_align): A struct with no non-static fields also
10899 has alignment of 1.
10900
10901 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
10902
10903 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
10904 component to 0.
10905 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
10906 member.
10907 (riscv_struct_info::analyse): New implementation using new
10908 analyse_inner member function.
10909 (riscv_struct_info::field_offset): New member function.
10910 (riscv_struct_info::m_offsets): New member variable.
10911 (riscv_struct_info::analyse_inner): New private member function,
10912 takes the old implementation of riscv_struct_info::analyse but
10913 extended to track field offsets.
10914 (riscv_call_arg_struct): Update the struct folding special cases
10915 to handle cases where empty C++ structs, which are non-zero
10916 length, are found.
10917 (riscv_arg_location): Initialise the length of each location, a
10918 non-zero length now indicates the location is in use.
10919 (riscv_push_dummy_call): Allow for the first location having a
10920 non-zero offset when setting up arguments.
10921 (riscv_return_value): Likewise, but for return values.
10922
10923 2019-04-11 Tom Tromey <tromey@adacore.com>
10924
10925 * utils.c (internal_vproblem): Make "msg" const.
10926
10927 2019-04-11 Alan Hayward <alan.hayward@arm.com>
10928
10929 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
10930 * trad-frame.c (trad_frame_reset_saved_regs): New function.
10931 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
10932 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
10933
10934 2019-04-10 Kevin Buettner <kevinb@redhat.com>
10935
10936 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
10937 function.
10938 (fill_gregset): Call amd64_linux_collect_native_gregset instead
10939 of amd64_collect_native_gregset.
10940 (amd64_linux_nat_target::store_registers): Likewise.
10941
10942 2019-04-10 Tom Tromey <tom@tromey.com>
10943
10944 * symtab.c (lookup_global_symbol_from_objfile)
10945 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
10946 * objfiles.h (class separate_debug_iterator): New.
10947 (class separate_debug_range): New.
10948 (struct objfile) <separate_debug_objfiles>: New method.
10949 (objfile_separate_debug_iterate): Don't declare.
10950 * objfiles.c (separate_debug_iterator::operator++): Rename from
10951 objfile_separate_debug_iterate.
10952 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
10953 iterator.
10954 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
10955 iterator.
10956
10957 2019-04-10 Tom Tromey <tom@tromey.com>
10958
10959 * symfile.c (reread_symbols): Remove old comment.
10960 * objfiles.c (free_all_objfiles): Fix a typo.
10961
10962 2019-04-10 Tom Tromey <tom@tromey.com>
10963
10964 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
10965 * minsyms.c (lookup_minimal_symbol): Use foreach.
10966 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
10967 (lookup_minimal_symbol_solib_trampoline): Likewise.
10968 * symfile.c (reread_symbols): Use foreach.
10969
10970 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
10971 Tom Tromey <tromey@adacore.com>
10972
10973 PR rust/24414:
10974 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
10975 (rust_lex_int_test): Change "value" to be LONGEST.
10976 (rust_lex_tests): Add test for long integer literal.
10977
10978 2019-04-09 Tom Tromey <tromey@adacore.com>
10979
10980 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
10981 to bool.
10982 (extended_remote_target::attach): Update.
10983 (remote_target::remote_notice_new_inferior): Update.
10984 (remote_target::add_current_inferior_and_thread): Update.
10985 * inferior.c (exit_inferior_1): Use "false".
10986 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
10987
10988 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
10989
10990 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
10991 the "start" command.
10992
10993 2019-04-08 Kevin Buettner <kevinb@redhat.com>
10994
10995 * python/py-inferior.c (infpy_thread_from_thread_handle):
10996 Adjust comments to reflect renaming of thread_from_thread_handle
10997 to thread_from_handle. Adjust keywords. Fix type error message.
10998 (inferior_object_methods): Add thread_from_handle. Retain
10999 thread_from_thread_handle, but mark it as deprecated.
11000
11001 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11002
11003 * gdbthread.h (find_thread_by_handle): Revise declaration.
11004 * thread.c (find_thread_by_handle): Likewise. Adjust
11005 implementation too.
11006 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11007 support for buffer objects as handles.
11008
11009 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11010
11011 * python/py-infthread.c (thpy_thread_handle): New function.
11012 (thread_object_methods): Register thpy_thread_handle.
11013
11014 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11015
11016 * gdbthread.h (thread_to_thread_handle): Declare.
11017 * thread.c (gdbtypes.h): Include.
11018 (thread_to_thread_handle): New function.
11019
11020 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11021 (target_thread_info_to_thread_handle): Declare.
11022 * target.c (target_thread_info_to_thread_handle): New function.
11023 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11024 * target-delegates.c: Regenerate.
11025
11026 * linux-thread-db.c (class thread_db_target): Add method
11027 thread_info_to_thread_handle.
11028 (thread_db_target::thread_info_to_thread_handle): Define.
11029 * remote.c (class remote_target): Add new method
11030 thread_info_to_thread_handle.
11031 (remote_target::thread_info_to_thread_handle): Define.
11032
11033 2019-04-08 Pedro Alves <palves@redhat.com>
11034
11035 * common/common-exceptions.c (throw_exception): Don't create
11036 named object to throw; throw directly.
11037 (throw_it): Likewise. Don't initialize gdb_exception::message
11038 here, with new; pass FMT and AP to the ctor instead.
11039 * common/common-exceptions.h: Include <string>.
11040 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11041 const char *, va_list)): New ctor. Use std::make_shared.
11042 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11043 errors)): Delete.
11044 (gdb_exception_error::gdb_exception_error(enum errors, const char
11045 *, va_list)): New.
11046 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11047 Add assertion.
11048 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11049 errors)): Delete.
11050 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11051 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11052 Add assertion.
11053
11054 2019-04-08 Tom Tromey <tom@tromey.com>
11055
11056 * valops.c (value_rtti_indirect_type): Replace throw_exception
11057 with throw.
11058 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11059 with throw.
11060 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11061 throw.
11062 * target.c (target_translate_tls_address): Replace throw_exception
11063 with throw.
11064 * stack.c (frame_apply_command_count): Replace throw_exception
11065 with throw.
11066 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11067 throw.
11068 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11069 with throw.
11070 * rs6000-tdep.c (rs6000_frame_cache)
11071 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11072 * remote.c: Replace throw_exception with throw.
11073 * record-full.c (record_full_message, record_full_wait_1)
11074 (record_full_restore): Replace throw_exception with throw.
11075 * record-btrace.c:
11076 (get_thread_current_frame_id, record_btrace_start_replaying)
11077 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11078 (cmd_record_btrace_start): Replace throw_exception with throw.
11079 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11080 throw.
11081 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11082 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11083 * linespec.c:
11084 (find_linespec_symbols): Replace throw_exception with throw.
11085 * infrun.c (displaced_step_prepare, resume): Replace
11086 throw_exception with throw.
11087 * infcmd.c (post_create_inferior): Replace throw_exception with
11088 throw.
11089 * inf-loop.c (inferior_event_handler): Replace throw_exception
11090 with throw.
11091 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11092 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11093 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11094 (get_prev_frame_always, get_frame_pc_if_available)
11095 (get_frame_address_in_block_if_available, get_frame_language):
11096 Replace throw_exception with throw.
11097 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11098 throw_exception with throw.
11099 * eval.c (fetch_subexp_value, evaluate_var_value)
11100 (evaluate_funcall, evaluate_subexp_standard): Replace
11101 throw_exception with throw.
11102 * dwarf2loc.c (call_site_find_chain)
11103 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11104 Replace throw_exception with throw.
11105 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11106 with throw.
11107 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11108 throw.
11109 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11110 * completer.c (complete_line_internal): Replace throw_exception
11111 with throw.
11112 * compile/compile-object-run.c (compile_object_run): Replace
11113 throw_exception with throw.
11114 * cli/cli-script.c (process_next_line): Replace throw_exception
11115 with throw.
11116 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11117 (btrace_enable, btrace_maint_update_pt_packets): Replace
11118 throw_exception with throw.
11119 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11120 throw_exception with throw.
11121 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11122 throw_exception with throw.
11123 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11124 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11125 * aarch64-tdep.c (aarch64_make_prologue_cache)
11126 (aarch64_make_stub_cache): Replace throw_exception with throw.
11127
11128 2019-04-08 Tom Tromey <tom@tromey.com>
11129
11130 * common/common-exceptions.c (throw_exception): Rename from
11131 throw_exception_cxx. Remove old copy. Make argument const.
11132 (throw_it): Create and throw exception objects directly.
11133 * common/common-exceptions.h (throw_exception): Make argument
11134 const.
11135 (struct gdb_exception_error): Add constructor.
11136 (struct gdb_exception_quit): Add constructor.
11137
11138 2019-04-08 Tom Tromey <tom@tromey.com>
11139
11140 * common/common-exceptions.h (exception_rethrow): Don't declare.
11141 (TRY_SJLJ): Update comment.
11142 (TRY, CATCH, END_CATCH): Remove.
11143 * common/common-exceptions.c (exception_rethrow): Remove.
11144
11145 2019-04-08 Tom Tromey <tom@tromey.com>
11146
11147 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11148 Remove.
11149 (gdb_exception_error): Rename from
11150 gdb_exception_RETURN_MASK_ERROR.
11151 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11152 (gdb_quit_bad_alloc): Update.
11153 * aarch64-tdep.c: Update.
11154 * ada-lang.c: Update.
11155 * ada-typeprint.c: Update.
11156 * ada-valprint.c: Update.
11157 * amd64-tdep.c: Update.
11158 * arch-utils.c: Update.
11159 * break-catch-throw.c: Update.
11160 * breakpoint.c: Update.
11161 * btrace.c: Update.
11162 * c-varobj.c: Update.
11163 * cli/cli-cmds.c: Update.
11164 * cli/cli-interp.c: Update.
11165 * cli/cli-script.c: Update.
11166 * common/common-exceptions.c: Update.
11167 * common/new-op.c: Update.
11168 * common/selftest.c: Update.
11169 * compile/compile-c-symbols.c: Update.
11170 * compile/compile-cplus-symbols.c: Update.
11171 * compile/compile-object-load.c: Update.
11172 * compile/compile-object-run.c: Update.
11173 * completer.c: Update.
11174 * corelow.c: Update.
11175 * cp-abi.c: Update.
11176 * cp-support.c: Update.
11177 * cp-valprint.c: Update.
11178 * darwin-nat.c: Update.
11179 * disasm-selftests.c: Update.
11180 * dtrace-probe.c: Update.
11181 * dwarf-index-cache.c: Update.
11182 * dwarf-index-write.c: Update.
11183 * dwarf2-frame-tailcall.c: Update.
11184 * dwarf2-frame.c: Update.
11185 * dwarf2loc.c: Update.
11186 * dwarf2read.c: Update.
11187 * eval.c: Update.
11188 * event-loop.c: Update.
11189 * event-top.c: Update.
11190 * exec.c: Update.
11191 * f-valprint.c: Update.
11192 * fbsd-tdep.c: Update.
11193 * frame-unwind.c: Update.
11194 * frame.c: Update.
11195 * gdbtypes.c: Update.
11196 * gnu-v3-abi.c: Update.
11197 * guile/guile-internal.h: Update.
11198 * guile/scm-block.c: Update.
11199 * guile/scm-breakpoint.c: Update.
11200 * guile/scm-cmd.c: Update.
11201 * guile/scm-disasm.c: Update.
11202 * guile/scm-frame.c: Update.
11203 * guile/scm-lazy-string.c: Update.
11204 * guile/scm-math.c: Update.
11205 * guile/scm-param.c: Update.
11206 * guile/scm-ports.c: Update.
11207 * guile/scm-pretty-print.c: Update.
11208 * guile/scm-symbol.c: Update.
11209 * guile/scm-symtab.c: Update.
11210 * guile/scm-type.c: Update.
11211 * guile/scm-value.c: Update.
11212 * i386-linux-tdep.c: Update.
11213 * i386-tdep.c: Update.
11214 * inf-loop.c: Update.
11215 * infcall.c: Update.
11216 * infcmd.c: Update.
11217 * infrun.c: Update.
11218 * jit.c: Update.
11219 * language.c: Update.
11220 * linespec.c: Update.
11221 * linux-fork.c: Update.
11222 * linux-nat.c: Update.
11223 * linux-tdep.c: Update.
11224 * linux-thread-db.c: Update.
11225 * main.c: Update.
11226 * mi/mi-cmd-break.c: Update.
11227 * mi/mi-cmd-stack.c: Update.
11228 * mi/mi-interp.c: Update.
11229 * mi/mi-main.c: Update.
11230 * objc-lang.c: Update.
11231 * p-valprint.c: Update.
11232 * parse.c: Update.
11233 * ppc-linux-tdep.c: Update.
11234 * printcmd.c: Update.
11235 * python/py-arch.c: Update.
11236 * python/py-breakpoint.c: Update.
11237 * python/py-cmd.c: Update.
11238 * python/py-finishbreakpoint.c: Update.
11239 * python/py-frame.c: Update.
11240 * python/py-framefilter.c: Update.
11241 * python/py-gdb-readline.c: Update.
11242 * python/py-inferior.c: Update.
11243 * python/py-infthread.c: Update.
11244 * python/py-lazy-string.c: Update.
11245 * python/py-linetable.c: Update.
11246 * python/py-objfile.c: Update.
11247 * python/py-param.c: Update.
11248 * python/py-prettyprint.c: Update.
11249 * python/py-progspace.c: Update.
11250 * python/py-record-btrace.c: Update.
11251 * python/py-record.c: Update.
11252 * python/py-symbol.c: Update.
11253 * python/py-type.c: Update.
11254 * python/py-unwind.c: Update.
11255 * python/py-utils.c: Update.
11256 * python/py-value.c: Update.
11257 * python/python.c: Update.
11258 * record-btrace.c: Update.
11259 * record-full.c: Update.
11260 * remote-fileio.c: Update.
11261 * remote.c: Update.
11262 * riscv-tdep.c: Update.
11263 * rs6000-aix-tdep.c: Update.
11264 * rs6000-tdep.c: Update.
11265 * rust-exp.y: Update.
11266 * rust-lang.c: Update.
11267 * s390-tdep.c: Update.
11268 * selftest-arch.c: Update.
11269 * solib-dsbt.c: Update.
11270 * solib-frv.c: Update.
11271 * solib-spu.c: Update.
11272 * solib-svr4.c: Update.
11273 * solib.c: Update.
11274 * sparc64-linux-tdep.c: Update.
11275 * stack.c: Update.
11276 * symfile-mem.c: Update.
11277 * symmisc.c: Update.
11278 * target.c: Update.
11279 * thread.c: Update.
11280 * top.c: Update.
11281 * tracefile-tfile.c: Update.
11282 * tui/tui.c: Update.
11283 * typeprint.c: Update.
11284 * unittests/cli-utils-selftests.c: Update.
11285 * unittests/parse-connection-spec-selftests.c: Update.
11286 * valops.c: Update.
11287 * valprint.c: Update.
11288 * value.c: Update.
11289 * varobj.c: Update.
11290 * windows-nat.c: Update.
11291 * x86-linux-nat.c: Update.
11292 * xml-support.c: Update.
11293
11294 2019-04-08 Tom Tromey <tom@tromey.com>
11295
11296 * xml-support.c: Use C++ exception handling.
11297 * x86-linux-nat.c: Use C++ exception handling.
11298 * windows-nat.c: Use C++ exception handling.
11299 * varobj.c: Use C++ exception handling.
11300 * value.c: Use C++ exception handling.
11301 * valprint.c: Use C++ exception handling.
11302 * valops.c: Use C++ exception handling.
11303 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11304 handling.
11305 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11306 * typeprint.c: Use C++ exception handling.
11307 * tui/tui.c: Use C++ exception handling.
11308 * tracefile-tfile.c: Use C++ exception handling.
11309 * top.c: Use C++ exception handling.
11310 * thread.c: Use C++ exception handling.
11311 * target.c: Use C++ exception handling.
11312 * symmisc.c: Use C++ exception handling.
11313 * symfile-mem.c: Use C++ exception handling.
11314 * stack.c: Use C++ exception handling.
11315 * sparc64-linux-tdep.c: Use C++ exception handling.
11316 * solib.c: Use C++ exception handling.
11317 * solib-svr4.c: Use C++ exception handling.
11318 * solib-spu.c: Use C++ exception handling.
11319 * solib-frv.c: Use C++ exception handling.
11320 * solib-dsbt.c: Use C++ exception handling.
11321 * selftest-arch.c: Use C++ exception handling.
11322 * s390-tdep.c: Use C++ exception handling.
11323 * rust-lang.c: Use C++ exception handling.
11324 * rust-exp.y: Use C++ exception handling.
11325 * rs6000-tdep.c: Use C++ exception handling.
11326 * rs6000-aix-tdep.c: Use C++ exception handling.
11327 * riscv-tdep.c: Use C++ exception handling.
11328 * remote.c: Use C++ exception handling.
11329 * remote-fileio.c: Use C++ exception handling.
11330 * record-full.c: Use C++ exception handling.
11331 * record-btrace.c: Use C++ exception handling.
11332 * python/python.c: Use C++ exception handling.
11333 * python/py-value.c: Use C++ exception handling.
11334 * python/py-utils.c: Use C++ exception handling.
11335 * python/py-unwind.c: Use C++ exception handling.
11336 * python/py-type.c: Use C++ exception handling.
11337 * python/py-symbol.c: Use C++ exception handling.
11338 * python/py-record.c: Use C++ exception handling.
11339 * python/py-record-btrace.c: Use C++ exception handling.
11340 * python/py-progspace.c: Use C++ exception handling.
11341 * python/py-prettyprint.c: Use C++ exception handling.
11342 * python/py-param.c: Use C++ exception handling.
11343 * python/py-objfile.c: Use C++ exception handling.
11344 * python/py-linetable.c: Use C++ exception handling.
11345 * python/py-lazy-string.c: Use C++ exception handling.
11346 * python/py-infthread.c: Use C++ exception handling.
11347 * python/py-inferior.c: Use C++ exception handling.
11348 * python/py-gdb-readline.c: Use C++ exception handling.
11349 * python/py-framefilter.c: Use C++ exception handling.
11350 * python/py-frame.c: Use C++ exception handling.
11351 * python/py-finishbreakpoint.c: Use C++ exception handling.
11352 * python/py-cmd.c: Use C++ exception handling.
11353 * python/py-breakpoint.c: Use C++ exception handling.
11354 * python/py-arch.c: Use C++ exception handling.
11355 * printcmd.c: Use C++ exception handling.
11356 * ppc-linux-tdep.c: Use C++ exception handling.
11357 * parse.c: Use C++ exception handling.
11358 * p-valprint.c: Use C++ exception handling.
11359 * objc-lang.c: Use C++ exception handling.
11360 * mi/mi-main.c: Use C++ exception handling.
11361 * mi/mi-interp.c: Use C++ exception handling.
11362 * mi/mi-cmd-stack.c: Use C++ exception handling.
11363 * mi/mi-cmd-break.c: Use C++ exception handling.
11364 * main.c: Use C++ exception handling.
11365 * linux-thread-db.c: Use C++ exception handling.
11366 * linux-tdep.c: Use C++ exception handling.
11367 * linux-nat.c: Use C++ exception handling.
11368 * linux-fork.c: Use C++ exception handling.
11369 * linespec.c: Use C++ exception handling.
11370 * language.c: Use C++ exception handling.
11371 * jit.c: Use C++ exception handling.
11372 * infrun.c: Use C++ exception handling.
11373 * infcmd.c: Use C++ exception handling.
11374 * infcall.c: Use C++ exception handling.
11375 * inf-loop.c: Use C++ exception handling.
11376 * i386-tdep.c: Use C++ exception handling.
11377 * i386-linux-tdep.c: Use C++ exception handling.
11378 * guile/scm-value.c: Use C++ exception handling.
11379 * guile/scm-type.c: Use C++ exception handling.
11380 * guile/scm-symtab.c: Use C++ exception handling.
11381 * guile/scm-symbol.c: Use C++ exception handling.
11382 * guile/scm-pretty-print.c: Use C++ exception handling.
11383 * guile/scm-ports.c: Use C++ exception handling.
11384 * guile/scm-param.c: Use C++ exception handling.
11385 * guile/scm-math.c: Use C++ exception handling.
11386 * guile/scm-lazy-string.c: Use C++ exception handling.
11387 * guile/scm-frame.c: Use C++ exception handling.
11388 * guile/scm-disasm.c: Use C++ exception handling.
11389 * guile/scm-cmd.c: Use C++ exception handling.
11390 * guile/scm-breakpoint.c: Use C++ exception handling.
11391 * guile/scm-block.c: Use C++ exception handling.
11392 * guile/guile-internal.h: Use C++ exception handling.
11393 * gnu-v3-abi.c: Use C++ exception handling.
11394 * gdbtypes.c: Use C++ exception handling.
11395 * frame.c: Use C++ exception handling.
11396 * frame-unwind.c: Use C++ exception handling.
11397 * fbsd-tdep.c: Use C++ exception handling.
11398 * f-valprint.c: Use C++ exception handling.
11399 * exec.c: Use C++ exception handling.
11400 * event-top.c: Use C++ exception handling.
11401 * event-loop.c: Use C++ exception handling.
11402 * eval.c: Use C++ exception handling.
11403 * dwarf2read.c: Use C++ exception handling.
11404 * dwarf2loc.c: Use C++ exception handling.
11405 * dwarf2-frame.c: Use C++ exception handling.
11406 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11407 * dwarf-index-write.c: Use C++ exception handling.
11408 * dwarf-index-cache.c: Use C++ exception handling.
11409 * dtrace-probe.c: Use C++ exception handling.
11410 * disasm-selftests.c: Use C++ exception handling.
11411 * darwin-nat.c: Use C++ exception handling.
11412 * cp-valprint.c: Use C++ exception handling.
11413 * cp-support.c: Use C++ exception handling.
11414 * cp-abi.c: Use C++ exception handling.
11415 * corelow.c: Use C++ exception handling.
11416 * completer.c: Use C++ exception handling.
11417 * compile/compile-object-run.c: Use C++ exception handling.
11418 * compile/compile-object-load.c: Use C++ exception handling.
11419 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11420 * compile/compile-c-symbols.c: Use C++ exception handling.
11421 * common/selftest.c: Use C++ exception handling.
11422 * common/new-op.c: Use C++ exception handling.
11423 * cli/cli-script.c: Use C++ exception handling.
11424 * cli/cli-interp.c: Use C++ exception handling.
11425 * cli/cli-cmds.c: Use C++ exception handling.
11426 * c-varobj.c: Use C++ exception handling.
11427 * btrace.c: Use C++ exception handling.
11428 * breakpoint.c: Use C++ exception handling.
11429 * break-catch-throw.c: Use C++ exception handling.
11430 * arch-utils.c: Use C++ exception handling.
11431 * amd64-tdep.c: Use C++ exception handling.
11432 * ada-valprint.c: Use C++ exception handling.
11433 * ada-typeprint.c: Use C++ exception handling.
11434 * ada-lang.c: Use C++ exception handling.
11435 * aarch64-tdep.c: Use C++ exception handling.
11436
11437 2019-04-08 Tom Tromey <tom@tromey.com>
11438
11439 * xml-support.c (gdb_xml_parser::parse): Update.
11440 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11441 * value.c (show_convenience): Update.
11442 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11443 (test_parse_flags_qcs): Update.
11444 * thread.c (thr_try_catch_cmd): Update.
11445 * target.c (target_translate_tls_address): Update.
11446 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11447 (info_frame_command_core, frame_apply_command_count): Update.
11448 * rust-exp.y (rust_lex_exception_test): Update.
11449 * riscv-tdep.c (riscv_print_one_register_info): Update.
11450 * remote.c (remote_target::enable_btrace): Update.
11451 * record-btrace.c (record_btrace_enable_warn): Update.
11452 * python/py-utils.c (gdbpy_convert_exception): Update.
11453 * printcmd.c (do_one_display, print_variable_and_value): Update.
11454 * mi/mi-main.c (mi_print_exception): Update.
11455 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11456 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11457 * linux-nat.c (linux_nat_target::attach): Update.
11458 * linux-fork.c (class scoped_switch_fork_info): Update.
11459 * infrun.c (displaced_step_prepare): Update.
11460 * infcall.c (call_function_by_hand_dummy): Update.
11461 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11462 * gnu-v3-abi.c (print_one_vtable): Update.
11463 * frame.c (get_prev_frame_always): Update.
11464 * f-valprint.c (info_common_command_for_block): Update.
11465 * exec.c (try_open_exec_file): Update.
11466 * exceptions.c (print_exception, exception_print)
11467 (exception_fprintf, exception_print_same): Update.
11468 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11469 * dwarf-index-cache.c (index_cache::store)
11470 (index_cache::lookup_gdb_index): Update.
11471 * darwin-nat.c (maybe_cache_shell): Update.
11472 * cp-valprint.c (cp_print_value_fields): Update.
11473 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11474 (gcc_cplus_symbol_address): Update.
11475 * compile/compile-c-symbols.c (gcc_convert_symbol)
11476 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11477 * common/selftest.c: Update.
11478 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11479 a std::string.
11480 (exception_try_scope_entry, exception_try_scope_exit): Don't
11481 declare.
11482 (struct exception_try_scope): Remove.
11483 (TRY): Don't use exception_try_scope.
11484 (struct gdb_exception): Add constructor, operator=.
11485 <what>: New method.
11486 (struct gdb_exception_RETURN_MASK_ALL)
11487 (struct gdb_exception_RETURN_MASK_ERROR)
11488 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11489 (struct gdb_quit_bad_alloc): Update.
11490 * common/common-exceptions.c (exception_none): Change
11491 initializer.
11492 (struct catcher) <state, exception>: Initialize inline.
11493 <prev>: Remove member.
11494 (current_catcher): Remove.
11495 (catchers): New global.
11496 (exceptions_state_mc_init): Simplify.
11497 (catcher_pop): Remove.
11498 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11499 (try_scope_depth, exception_try_scope_entry)
11500 (exception_try_scope_exit): Remove.
11501 (throw_exception_sjlj): Update.
11502 (exception_messages, exception_messages_size): Remove.
11503 (throw_it): Simplify.
11504 (gdb_exception_sliced_copy): Remove.
11505 (throw_exception_cxx): Update.
11506 * cli/cli-script.c (script_from_file): Update.
11507 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11508 Update.
11509 * ada-valprint.c (ada_val_print): Update.
11510 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11511 (create_excep_cond_exprs): Update.
11512
11513 2019-04-08 Tom Tromey <tom@tromey.com>
11514
11515 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11516 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11517 (TRY, CATCH, END_CATCH): Remove some definitions.
11518 * common/common-exceptions.c: Don't use GDB_XCPT.
11519 (catcher_list_size): Remove.
11520 (throw_exception, throw_it): Simplify.
11521
11522 2019-04-05 Tom Tromey <tom@tromey.com>
11523
11524 Revert the header-sorting patch.
11525 * ft32-tdep.c: Revert.
11526 * frv-tdep.c: Revert.
11527 * frv-linux-tdep.c: Revert.
11528 * frame.c: Revert.
11529 * frame-unwind.c: Revert.
11530 * frame-base.c: Revert.
11531 * fork-child.c: Revert.
11532 * findvar.c: Revert.
11533 * findcmd.c: Revert.
11534 * filesystem.c: Revert.
11535 * filename-seen-cache.h: Revert.
11536 * filename-seen-cache.c: Revert.
11537 * fbsd-tdep.c: Revert.
11538 * fbsd-nat.h: Revert.
11539 * fbsd-nat.c: Revert.
11540 * f-valprint.c: Revert.
11541 * f-typeprint.c: Revert.
11542 * f-lang.c: Revert.
11543 * extension.h: Revert.
11544 * extension.c: Revert.
11545 * extension-priv.h: Revert.
11546 * expprint.c: Revert.
11547 * exec.h: Revert.
11548 * exec.c: Revert.
11549 * exceptions.c: Revert.
11550 * event-top.c: Revert.
11551 * event-loop.c: Revert.
11552 * eval.c: Revert.
11553 * elfread.c: Revert.
11554 * dwarf2read.h: Revert.
11555 * dwarf2read.c: Revert.
11556 * dwarf2loc.c: Revert.
11557 * dwarf2expr.h: Revert.
11558 * dwarf2expr.c: Revert.
11559 * dwarf2-frame.c: Revert.
11560 * dwarf2-frame-tailcall.c: Revert.
11561 * dwarf-index-write.h: Revert.
11562 * dwarf-index-write.c: Revert.
11563 * dwarf-index-common.c: Revert.
11564 * dwarf-index-cache.h: Revert.
11565 * dwarf-index-cache.c: Revert.
11566 * dummy-frame.c: Revert.
11567 * dtrace-probe.c: Revert.
11568 * disasm.h: Revert.
11569 * disasm.c: Revert.
11570 * disasm-selftests.c: Revert.
11571 * dictionary.c: Revert.
11572 * dicos-tdep.c: Revert.
11573 * demangle.c: Revert.
11574 * dcache.h: Revert.
11575 * dcache.c: Revert.
11576 * darwin-nat.h: Revert.
11577 * darwin-nat.c: Revert.
11578 * darwin-nat-info.c: Revert.
11579 * d-valprint.c: Revert.
11580 * d-namespace.c: Revert.
11581 * d-lang.c: Revert.
11582 * ctf.c: Revert.
11583 * csky-tdep.c: Revert.
11584 * csky-linux-tdep.c: Revert.
11585 * cris-tdep.c: Revert.
11586 * cris-linux-tdep.c: Revert.
11587 * cp-valprint.c: Revert.
11588 * cp-support.c: Revert.
11589 * cp-namespace.c: Revert.
11590 * cp-abi.c: Revert.
11591 * corelow.c: Revert.
11592 * corefile.c: Revert.
11593 * continuations.c: Revert.
11594 * completer.h: Revert.
11595 * completer.c: Revert.
11596 * complaints.c: Revert.
11597 * coffread.c: Revert.
11598 * coff-pe-read.c: Revert.
11599 * cli-out.h: Revert.
11600 * cli-out.c: Revert.
11601 * charset.c: Revert.
11602 * c-varobj.c: Revert.
11603 * c-valprint.c: Revert.
11604 * c-typeprint.c: Revert.
11605 * c-lang.c: Revert.
11606 * buildsym.c: Revert.
11607 * buildsym-legacy.c: Revert.
11608 * build-id.h: Revert.
11609 * build-id.c: Revert.
11610 * btrace.c: Revert.
11611 * bsd-uthread.c: Revert.
11612 * breakpoint.h: Revert.
11613 * breakpoint.c: Revert.
11614 * break-catch-throw.c: Revert.
11615 * break-catch-syscall.c: Revert.
11616 * break-catch-sig.c: Revert.
11617 * blockframe.c: Revert.
11618 * block.c: Revert.
11619 * bfin-tdep.c: Revert.
11620 * bfin-linux-tdep.c: Revert.
11621 * bfd-target.c: Revert.
11622 * bcache.c: Revert.
11623 * ax-general.c: Revert.
11624 * ax-gdb.h: Revert.
11625 * ax-gdb.c: Revert.
11626 * avr-tdep.c: Revert.
11627 * auxv.c: Revert.
11628 * auto-load.c: Revert.
11629 * arm-wince-tdep.c: Revert.
11630 * arm-tdep.c: Revert.
11631 * arm-symbian-tdep.c: Revert.
11632 * arm-pikeos-tdep.c: Revert.
11633 * arm-obsd-tdep.c: Revert.
11634 * arm-nbsd-tdep.c: Revert.
11635 * arm-nbsd-nat.c: Revert.
11636 * arm-linux-tdep.c: Revert.
11637 * arm-linux-nat.c: Revert.
11638 * arm-fbsd-tdep.c: Revert.
11639 * arm-fbsd-nat.c: Revert.
11640 * arm-bsd-tdep.c: Revert.
11641 * arch-utils.c: Revert.
11642 * arc-tdep.c: Revert.
11643 * arc-newlib-tdep.c: Revert.
11644 * annotate.h: Revert.
11645 * annotate.c: Revert.
11646 * amd64-windows-tdep.c: Revert.
11647 * amd64-windows-nat.c: Revert.
11648 * amd64-tdep.c: Revert.
11649 * amd64-sol2-tdep.c: Revert.
11650 * amd64-obsd-tdep.c: Revert.
11651 * amd64-obsd-nat.c: Revert.
11652 * amd64-nbsd-tdep.c: Revert.
11653 * amd64-nbsd-nat.c: Revert.
11654 * amd64-nat.c: Revert.
11655 * amd64-linux-tdep.c: Revert.
11656 * amd64-linux-nat.c: Revert.
11657 * amd64-fbsd-tdep.c: Revert.
11658 * amd64-fbsd-nat.c: Revert.
11659 * amd64-dicos-tdep.c: Revert.
11660 * amd64-darwin-tdep.c: Revert.
11661 * amd64-bsd-nat.c: Revert.
11662 * alpha-tdep.c: Revert.
11663 * alpha-obsd-tdep.c: Revert.
11664 * alpha-nbsd-tdep.c: Revert.
11665 * alpha-mdebug-tdep.c: Revert.
11666 * alpha-linux-tdep.c: Revert.
11667 * alpha-linux-nat.c: Revert.
11668 * alpha-bsd-tdep.c: Revert.
11669 * alpha-bsd-nat.c: Revert.
11670 * aix-thread.c: Revert.
11671 * agent.c: Revert.
11672 * addrmap.c: Revert.
11673 * ada-varobj.c: Revert.
11674 * ada-valprint.c: Revert.
11675 * ada-typeprint.c: Revert.
11676 * ada-tasks.c: Revert.
11677 * ada-lang.c: Revert.
11678 * aarch64-tdep.c: Revert.
11679 * aarch64-ravenscar-thread.c: Revert.
11680 * aarch64-newlib-tdep.c: Revert.
11681 * aarch64-linux-tdep.c: Revert.
11682 * aarch64-linux-nat.c: Revert.
11683 * aarch64-fbsd-tdep.c: Revert.
11684 * aarch64-fbsd-nat.c: Revert.
11685 * aarch32-linux-nat.c: Revert.
11686
11687 2019-04-05 Tom Tromey <tom@tromey.com>
11688
11689 * ft32-tdep.c: Sort headers.
11690 * frv-tdep.c: Sort headers.
11691 * frv-linux-tdep.c: Sort headers.
11692 * frame.c: Sort headers.
11693 * frame-unwind.c: Sort headers.
11694 * frame-base.c: Sort headers.
11695 * fork-child.c: Sort headers.
11696 * findvar.c: Sort headers.
11697 * findcmd.c: Sort headers.
11698 * filesystem.c: Sort headers.
11699 * filename-seen-cache.h: Sort headers.
11700 * filename-seen-cache.c: Sort headers.
11701 * fbsd-tdep.c: Sort headers.
11702 * fbsd-nat.h: Sort headers.
11703 * fbsd-nat.c: Sort headers.
11704 * f-valprint.c: Sort headers.
11705 * f-typeprint.c: Sort headers.
11706 * f-lang.c: Sort headers.
11707 * extension.h: Sort headers.
11708 * extension.c: Sort headers.
11709 * extension-priv.h: Sort headers.
11710 * expprint.c: Sort headers.
11711 * exec.h: Sort headers.
11712 * exec.c: Sort headers.
11713 * exceptions.c: Sort headers.
11714 * event-top.c: Sort headers.
11715 * event-loop.c: Sort headers.
11716 * eval.c: Sort headers.
11717 * elfread.c: Sort headers.
11718 * dwarf2read.h: Sort headers.
11719 * dwarf2read.c: Sort headers.
11720 * dwarf2loc.c: Sort headers.
11721 * dwarf2expr.h: Sort headers.
11722 * dwarf2expr.c: Sort headers.
11723 * dwarf2-frame.c: Sort headers.
11724 * dwarf2-frame-tailcall.c: Sort headers.
11725 * dwarf-index-write.h: Sort headers.
11726 * dwarf-index-write.c: Sort headers.
11727 * dwarf-index-common.c: Sort headers.
11728 * dwarf-index-cache.h: Sort headers.
11729 * dwarf-index-cache.c: Sort headers.
11730 * dummy-frame.c: Sort headers.
11731 * dtrace-probe.c: Sort headers.
11732 * disasm.h: Sort headers.
11733 * disasm.c: Sort headers.
11734 * disasm-selftests.c: Sort headers.
11735 * dictionary.c: Sort headers.
11736 * dicos-tdep.c: Sort headers.
11737 * demangle.c: Sort headers.
11738 * dcache.h: Sort headers.
11739 * dcache.c: Sort headers.
11740 * darwin-nat.h: Sort headers.
11741 * darwin-nat.c: Sort headers.
11742 * darwin-nat-info.c: Sort headers.
11743 * d-valprint.c: Sort headers.
11744 * d-namespace.c: Sort headers.
11745 * d-lang.c: Sort headers.
11746 * ctf.c: Sort headers.
11747 * csky-tdep.c: Sort headers.
11748 * csky-linux-tdep.c: Sort headers.
11749 * cris-tdep.c: Sort headers.
11750 * cris-linux-tdep.c: Sort headers.
11751 * cp-valprint.c: Sort headers.
11752 * cp-support.c: Sort headers.
11753 * cp-namespace.c: Sort headers.
11754 * cp-abi.c: Sort headers.
11755 * corelow.c: Sort headers.
11756 * corefile.c: Sort headers.
11757 * continuations.c: Sort headers.
11758 * completer.h: Sort headers.
11759 * completer.c: Sort headers.
11760 * complaints.c: Sort headers.
11761 * coffread.c: Sort headers.
11762 * coff-pe-read.c: Sort headers.
11763 * cli-out.h: Sort headers.
11764 * cli-out.c: Sort headers.
11765 * charset.c: Sort headers.
11766 * c-varobj.c: Sort headers.
11767 * c-valprint.c: Sort headers.
11768 * c-typeprint.c: Sort headers.
11769 * c-lang.c: Sort headers.
11770 * buildsym.c: Sort headers.
11771 * buildsym-legacy.c: Sort headers.
11772 * build-id.h: Sort headers.
11773 * build-id.c: Sort headers.
11774 * btrace.c: Sort headers.
11775 * bsd-uthread.c: Sort headers.
11776 * breakpoint.h: Sort headers.
11777 * breakpoint.c: Sort headers.
11778 * break-catch-throw.c: Sort headers.
11779 * break-catch-syscall.c: Sort headers.
11780 * break-catch-sig.c: Sort headers.
11781 * blockframe.c: Sort headers.
11782 * block.c: Sort headers.
11783 * bfin-tdep.c: Sort headers.
11784 * bfin-linux-tdep.c: Sort headers.
11785 * bfd-target.c: Sort headers.
11786 * bcache.c: Sort headers.
11787 * ax-general.c: Sort headers.
11788 * ax-gdb.h: Sort headers.
11789 * ax-gdb.c: Sort headers.
11790 * avr-tdep.c: Sort headers.
11791 * auxv.c: Sort headers.
11792 * auto-load.c: Sort headers.
11793 * arm-wince-tdep.c: Sort headers.
11794 * arm-tdep.c: Sort headers.
11795 * arm-symbian-tdep.c: Sort headers.
11796 * arm-pikeos-tdep.c: Sort headers.
11797 * arm-obsd-tdep.c: Sort headers.
11798 * arm-nbsd-tdep.c: Sort headers.
11799 * arm-nbsd-nat.c: Sort headers.
11800 * arm-linux-tdep.c: Sort headers.
11801 * arm-linux-nat.c: Sort headers.
11802 * arm-fbsd-tdep.c: Sort headers.
11803 * arm-fbsd-nat.c: Sort headers.
11804 * arm-bsd-tdep.c: Sort headers.
11805 * arch-utils.c: Sort headers.
11806 * arc-tdep.c: Sort headers.
11807 * arc-newlib-tdep.c: Sort headers.
11808 * annotate.h: Sort headers.
11809 * annotate.c: Sort headers.
11810 * amd64-windows-tdep.c: Sort headers.
11811 * amd64-windows-nat.c: Sort headers.
11812 * amd64-tdep.c: Sort headers.
11813 * amd64-sol2-tdep.c: Sort headers.
11814 * amd64-obsd-tdep.c: Sort headers.
11815 * amd64-obsd-nat.c: Sort headers.
11816 * amd64-nbsd-tdep.c: Sort headers.
11817 * amd64-nbsd-nat.c: Sort headers.
11818 * amd64-nat.c: Sort headers.
11819 * amd64-linux-tdep.c: Sort headers.
11820 * amd64-linux-nat.c: Sort headers.
11821 * amd64-fbsd-tdep.c: Sort headers.
11822 * amd64-fbsd-nat.c: Sort headers.
11823 * amd64-dicos-tdep.c: Sort headers.
11824 * amd64-darwin-tdep.c: Sort headers.
11825 * amd64-bsd-nat.c: Sort headers.
11826 * alpha-tdep.c: Sort headers.
11827 * alpha-obsd-tdep.c: Sort headers.
11828 * alpha-nbsd-tdep.c: Sort headers.
11829 * alpha-mdebug-tdep.c: Sort headers.
11830 * alpha-linux-tdep.c: Sort headers.
11831 * alpha-linux-nat.c: Sort headers.
11832 * alpha-bsd-tdep.c: Sort headers.
11833 * alpha-bsd-nat.c: Sort headers.
11834 * aix-thread.c: Sort headers.
11835 * agent.c: Sort headers.
11836 * addrmap.c: Sort headers.
11837 * ada-varobj.c: Sort headers.
11838 * ada-valprint.c: Sort headers.
11839 * ada-typeprint.c: Sort headers.
11840 * ada-tasks.c: Sort headers.
11841 * ada-lang.c: Sort headers.
11842 * aarch64-tdep.c: Sort headers.
11843 * aarch64-ravenscar-thread.c: Sort headers.
11844 * aarch64-newlib-tdep.c: Sort headers.
11845 * aarch64-linux-tdep.c: Sort headers.
11846 * aarch64-linux-nat.c: Sort headers.
11847 * aarch64-fbsd-tdep.c: Sort headers.
11848 * aarch64-fbsd-nat.c: Sort headers.
11849 * aarch32-linux-nat.c: Sort headers.
11850
11851 2019-04-04 Tom Tromey <tom@tromey.com>
11852
11853 * varobj.c (varobj_create): Update.
11854 * rust-exp.y (struct rust_parser) <update_innermost_block,
11855 lookup_symbol>: New methods.
11856 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
11857 Rename.
11858 (rust_parser::rust_lookup_type)
11859 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11860 * printcmd.c (display_command, do_one_display): Update.
11861 * parser-defs.h (struct parser_state) <parser_state>: Add
11862 "tracker" parameter.
11863 (block_tracker): New member.
11864 (class innermost_block_tracker) <innermost_block_tracker>: Add
11865 "types" parameter.
11866 <reset>: Remove method.
11867 (innermost_block): Don't declare.
11868 (null_post_parser): Update.
11869 * parse.c (innermost_block): Remove global.
11870 (write_dollar_variable): Update.
11871 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
11872 Remove "tracker_types" parameter.
11873 (parse_expression): Add "tracker" parameter.
11874 (parse_expression_for_completion): Update.
11875 (null_post_parser): Add "tracker" parameter.
11876 * p-exp.y: Update rules.
11877 * m2-exp.y: Update rules.
11878 * language.h (struct language_defn) <la_post_parser>: Add
11879 "tracker" parameter.
11880 * go-exp.y: Update rules.
11881 * f-exp.y: Update rules.
11882 * expression.h (parse_expression, parse_exp_1): Add "tracker"
11883 parameter.
11884 * d-exp.y: Update rules.
11885 * c-exp.y: Update rules.
11886 * breakpoint.c (set_breakpoint_condition): Create an
11887 innermost_block_tracker.
11888 (watch_command_1): Likewise.
11889 * ada-lang.c (resolve): Add "tracker" parameter.
11890 (resolve_subexp): Likewise.
11891 * ada-exp.y (write_var_from_sym): Update.
11892
11893 2019-04-04 Tom Tromey <tom@tromey.com>
11894
11895 * type-stack.h: New file.
11896 * type-stack.c: New file.
11897 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
11898 type-stack.h.
11899 (insert_into_type_stack, insert_type, push_type, push_type_int)
11900 (insert_type_address_space, pop_type, pop_type_int)
11901 (pop_typelist, pop_type_stack, append_type_stack)
11902 (push_type_stack, get_type_stack, push_typelist)
11903 (follow_type_instance_flags, follow_types): Don't declare.
11904 * parse.c (type_stack): Remove global.
11905 (parse_exp_in_context): Update.
11906 (insert_into_type_stack, insert_type, push_type, push_type_int)
11907 (insert_type_address_space, pop_type, pop_type_int)
11908 (pop_typelist, pop_type_stack, append_type_stack)
11909 (push_type_stack, get_type_stack, push_typelist)
11910 (follow_type_instance_flags, follow_types): Remove (moved to
11911 type-stack.c).
11912 * f-exp.y (type_stack): New global.
11913 Update rules.
11914 (push_kind_type, f_parse): Update.
11915 * d-exp.y (type_stack): New global.
11916 Update rules.
11917 (d_parse): Update.
11918 * c-exp.y (struct c_parse_state) <type_stack>: New member.
11919 Update rules.
11920 * Makefile.in (COMMON_SFILES): Add type-stack.c.
11921 (HFILES_NO_SRCDIR): Add type-stack.h.
11922
11923 2019-04-04 Tom Tromey <tom@tromey.com>
11924
11925 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
11926 (rust_parser::convert_ast_to_expression, rust_parse)
11927 (rust_lex_test_completion, rust_lex_tests): Update.
11928 * parser-defs.h (struct expr_completion_state): New.
11929 (struct parser_state) <parser_state>: Add completion parameter.
11930 <mark_struct_expression, mark_completion_tag>: New methods.
11931 <parse_completion, m_completion_state>: New members.
11932 (prefixify_expression, null_post_parser): Update.
11933 (mark_struct_expression, mark_completion_tag): Don't declare.
11934 * parse.c (parse_completion, expout_last_struct)
11935 (expout_tag_completion_type, expout_completion_name): Remove
11936 globals.
11937 (parser_state::mark_struct_expression)
11938 (parser_state::mark_completion_tag): Now methods.
11939 (prefixify_expression): Add last_struct parameter.
11940 (prefixify_subexp): Likewise.
11941 (parse_exp_1): Update.
11942 (parse_exp_in_context): Add cstate parameter. Update.
11943 (parse_expression_for_completion): Create an
11944 expr_completion_state.
11945 (null_post_parser): Add "completion" parameter.
11946 * p-exp.y: Update rules.
11947 (yylex): Update.
11948 * language.h (struct language_defn) <la_post_parser>: Add
11949 "completing" parameter.
11950 * go-exp.y: Update rules.
11951 (lex_one_token): Update.
11952 * expression.h (parse_completion): Don't declare.
11953 * d-exp.y: Update rules.
11954 (lex_one_token): Update rules.
11955 * c-exp.y: Update rules.
11956 (lex_one_token): Update.
11957 * ada-lang.c (resolve): Add "parse_completion" parameter.
11958 (resolve_subexp): Likewise.
11959 (ada_resolve_function): Likewise.
11960
11961 2019-04-04 Tom Tromey <tom@tromey.com>
11962
11963 * parser-defs.h (struct parser_state) <start_arglist,
11964 end_arglist>: New methods.
11965 <arglist_len, m_funcall_chain>: New members.
11966 (arglist_len, start_arglist, end_arglist): Don't declare.
11967 * parse.c (arglist_len, funcall_chain): Remove global.
11968 (start_arglist, end_arglist): Remove functions.
11969 (parse_exp_in_context): Update.
11970 * p-exp.y: Update rules.
11971 * m2-exp.y: Update rules.
11972 * go-exp.y: Update rules.
11973 * f-exp.y: Update rules.
11974 * d-exp.y: Update rules.
11975 * c-exp.y: Update rules.
11976
11977 2019-04-04 Tom Tromey <tom@tromey.com>
11978
11979 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
11980 lex_operator, push_back>: New methods.
11981 Update all rules.
11982 (rust_parser::lex_hex, lex_escape): Rename and update.
11983 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
11984 (rust_parser::lex_operator): Rename and update.
11985 (rust_parser::lex_number, rustyylex, rustyyerror)
11986 (rust_lex_test_init, rust_lex_test_sequence)
11987 (rust_lex_test_push_back, rust_lex_tests): Update.
11988 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
11989 parameter.
11990 <lexptr, prev_lexptr>: New members.
11991 (lexptr, prev_lexptr): Don't declare.
11992 * parse.c (lexptr, prev_lexptr): Remove globals.
11993 (parse_exp_in_context): Update.
11994 * p-exp.y (yylex, yyerror): Update.
11995 * m2-exp.y (parse_number, yylex, yyerror): Update.
11996 * go-exp.y (lex_one_token, yyerror): Update.
11997 * f-exp.y (match_string_literal, yylex, yyerror): Update.
11998 * d-exp.y (lex_one_token, yyerror): Update.
11999 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12000 (lex_one_token, yyerror): Update.
12001 * ada-lex.l (YY_INPUT): Update.
12002 (rewind_to_char): Update.
12003 * ada-exp.y (yyerror): Update.
12004
12005 2019-04-04 Tom Tromey <tom@tromey.com>
12006
12007 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12008 * parser-defs.h (struct parser_state) <parser_state>: Add new
12009 parameter.
12010 <comma_terminates>: New member.
12011 (comma_terminates): Don't declare global.
12012 * parse.c (comma_terminates): Remove global.
12013 (parse_exp_in_context): Update.
12014 * p-exp.y (yylex): Update.
12015 * m2-exp.y (yylex): Update.
12016 * go-exp.y (lex_one_token): Update.
12017 * f-exp.y (yylex): Update.
12018 * d-exp.y (lex_one_token): Update.
12019 * c-exp.y (lex_one_token): Update.
12020 * ada-lex.l: Update.
12021
12022 2019-04-04 Tom Tromey <tom@tromey.com>
12023
12024 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12025 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12026 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12027 * parser-defs.h (paren_depth): Don't declare.
12028 * parse.c (paren_depth): Remove global.
12029 (parse_exp_in_context): Update.
12030 * p-exp.y (paren_depth): New global.
12031 (pascal_parse): Initialize it.
12032 * m2-exp.y (paren_depth): New global.
12033 (m2_parse): Initialize it.
12034 * go-exp.y (paren_depth): New global.
12035 (go_parse): Initialize it.
12036 * f-exp.y (paren_depth): New global.
12037 (f_parse): Initialize it.
12038 * d-exp.y (paren_depth): New global.
12039 (d_parse): Initialize it.
12040 * c-exp.y (paren_depth): New global.
12041 (c_parse): Initialize it.
12042 * ada-lex.l (paren_depth): New global.
12043 (lexer_init): Initialize it.
12044
12045 2019-04-04 Tom Tromey <tom@tromey.com>
12046
12047 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12048 (rust_parser::convert_ast_to_type)
12049 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12050 * parser-defs.h (struct parser_state) <parser_state>: Add
12051 parameters. Initialize new members.
12052 <expression_context_block, expression_context_pc>: New members.
12053 * parse.c (expression_context_block, expression_context_pc):
12054 Remove globals.
12055 (parse_exp_in_context): Update.
12056 * p-exp.y: Update all rules.
12057 (yylex): Update.
12058 * m2-exp.y: Update all rules.
12059 (yylex): Update.
12060 * go-exp.y (yylex): Update.
12061 * f-exp.y (yylex): Update.
12062 * d-exp.y: Update all rules.
12063 (yylex): Update.
12064 * c-exp.y: Update all rules.
12065 (lex_one_token, classify_name, yylex, c_parse): Update.
12066 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12067
12068 2019-04-04 Tom Tromey <tom@tromey.com>
12069
12070 * gdbarch.h, gdbarch.c: Rebuild.
12071 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12072 * stap-probe.h:
12073 (struct stap_parse_info): Replace "parser_state" with
12074 "expr_builder".
12075 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12076 (parser_state): New class.
12077 * parse.c (expr_builder): Rename.
12078 (expr_builder::release): Rename.
12079 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12080 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12081 (write_exp_elt_longcst, write_exp_elt_floatcst)
12082 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12083 (write_exp_string_vector, write_exp_bitstring)
12084 (write_exp_msymbol, mark_struct_expression)
12085 (write_dollar_variable)
12086 (insert_type_address_space, increase_expout_size): Replace
12087 "parser_state" with "expr_builder".
12088 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12089 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12090 "parser_state" with "expr_builder".
12091
12092 2019-04-04 Tom Tromey <tom@tromey.com>
12093
12094 * rust-exp.y: Replace "parse_language" with method call.
12095 * p-exp.y:
12096 (yylex): Replace "parse_language" with method call.
12097 * m2-exp.y:
12098 (yylex): Replace "parse_language" with method call.
12099 * go-exp.y (classify_name): Replace "parse_language" with method
12100 call.
12101 * f-exp.y (yylex): Replace "parse_language" with method call.
12102 * d-exp.y (lex_one_token): Replace "parse_language" with method
12103 call.
12104 * c-exp.y:
12105 (lex_one_token, classify_name, yylex): Replace "parse_language"
12106 with method call.
12107 * ada-exp.y (find_primitive_type, type_char)
12108 (type_system_address): Replace "parse_language" with method call.
12109
12110 2019-04-04 Tom Tromey <tom@tromey.com>
12111
12112 * rust-exp.y: Replace "parse_gdbarch" with method call.
12113 * parse.c (write_dollar_variable, insert_type_address_space):
12114 Replace "parse_gdbarch" with method call.
12115 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12116 call.
12117 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12118 call.
12119 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12120 "parse_gdbarch" with method call.
12121 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12122 with method call.
12123 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12124 "parse_gdbarch" with method call.
12125 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12126 "parse_gdbarch" with method call.
12127 * c-exp.y (parse_type, parse_number, classify_name): Replace
12128 "parse_gdbarch" with method call.
12129 * ada-lex.l: Replace "parse_gdbarch" with method call.
12130 * ada-exp.y (parse_type, find_primitive_type, type_char)
12131 (type_system_address): Replace "parse_gdbarch" with method call.
12132
12133 2019-04-04 Tom Tromey <tom@tromey.com>
12134
12135 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12136 * stap-probe.c (stap_parse_argument): Update.
12137 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12138 initial_size parameter.
12139 * rust-exp.y (rust_lex_tests): Update.
12140 * parse.c (parser_state): Update.
12141 (parse_exp_in_context): Update.
12142 * parser-defs.h (struct parser_state) <parser_state>: Remove
12143 "initial_size" parameter.
12144
12145 2019-04-04 Tom Tromey <tom@tromey.com>
12146
12147 * parser-defs.h (increase_expout_size): Don't declare.
12148 * parse.c (increase_expout_size): Now static.
12149
12150 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12151
12152 * gnu-nat.c (gnu_nat_target::wait): Fix
12153 target_waitstatus_to_string call.
12154
12155 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12156
12157 * eval.c (evaluate_subexp_standard): Handle internal functions
12158 during Fortran function call handling.
12159
12160 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12161
12162 * NEWS: Mention new internal functions.
12163 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12164 (read_base_type): Use dwarf2_init_complex_target_type.
12165 * value.c (creal_internal_fn): New function.
12166 (cimag_internal_fn): New function.
12167 (_initialize_values): Register new internal functions.
12168
12169 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12170
12171 * infrun.c (stop_all_threads): If debug_infrun, always
12172 trace the wait status after wait_one, using
12173 target_waitstatus_to_string and target_pid_to_str.
12174 (handle_inferior_event): Replace various trace of
12175 wait status kind by a single trace.
12176 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12177 wait status kind image by target_waitstatus_to_string.
12178 * target/waitstatus.c (target_waitstatus_to_string): Fix
12179 obsolete comment.
12180
12181 2019-04-01 Tom Tromey <tromey@adacore.com>
12182
12183 PR symtab/23331:
12184 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12185
12186 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12187 Pedro Alves <palves@redhat.com>
12188
12189 * top.c (quit_force): Call 'finalize_values'.
12190 * value.c (finalize_values): New function.
12191 * value.h (finalize_values): Declare.
12192
12193 2019-03-30 Eli Zaretskii <eliz@gnu.org>
12194
12195 * NEWS: Announce $_gdb_major and $_gdb_minor.
12196
12197 * top.c (init_gdb_version_vars): New function.
12198 (gdb_init): Call init_gdb_version_vars.
12199
12200 2019-03-29 Tom Tromey <tromey@adacore.com>
12201
12202 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12203 help text. Remove dead code.
12204
12205 2019-03-29 Keith Seitz <keiths@redhat.com>
12206
12207 From Siddhesh Poyarekar:
12208 * f-lang.h (f77_get_upperbound): Return LONGEST.
12209 (f77_get_lowerbound): Likewise.
12210 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12211 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12212 print them.
12213 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12214 plongest to format print it.
12215 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12216 (f77_get_upperbound): Likewise.
12217 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12218 LOWER_BOUND to LONGEST.
12219 (f77_create_arrayprint_offset_tbl): Likewise.
12220
12221 2019-03-29 Keith Seitz <keiths@redhat.com>
12222
12223 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12224 %s/pulongest for TYPE_LENGTH instead of %d in format
12225 strings.
12226 * ada-typerint.c (ada_print_type): Likewise.
12227 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12228 * compile/compile-c-support.c (generate_register_struct): Likewise.
12229 * gdbtypes.c (recursive_dump_type): Likewise.
12230 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12231 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12232 instead of %d in format strings.
12233 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12234 to std::min to ULONGEST.
12235 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12236 instead of %d in format strings.
12237 * tracepoint.c (info_scope_command): Likewise.
12238 * typeprint.c (print_offset_data::update)
12239 (print_offset_data::finish): Likewise.
12240 * xtensa-tdep.c (xtensa_store_return_value)
12241 (xtensa_push_dummy_call): Likewise.
12242
12243 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12244
12245 * windows-nat.c (display_selector): Fixed format specifications
12246 for 64-bit Cygwin.
12247
12248 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12249
12250 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12251
12252 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12253
12254 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12255 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12256 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12257 (nios2_linux_init_abi): Install it.
12258
12259 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12260
12261 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12262
12263 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12264
12265 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12266
12267 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12268 Tom Tromey <tromey@adacore.com>
12269
12270 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12271
12272 2019-03-26 Joel Brobecker <brobecker@adacore.com>
12273
12274 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12275 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12276 method to compute the bounds of range types. Also print "[evaluated]"
12277 if the bounds' values come from a dynamic evaluation.
12278
12279 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12280
12281 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12282 whitespace when pretty printing is on.
12283
12284 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12285
12286 * ppc-linux-nat.c: Add include.
12287
12288 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12289
12290 * NEWS: Mention AArch64 Pointer Authentication.
12291
12292 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12293
12294 * arm-linux-nat.c: Add include.
12295
12296 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12297
12298 * source-cache.c (source_cache::get_source_lines): Re-read
12299 fullname after calling open_source_file.
12300
12301 2019-03-25 John Baldwin <jhb@FreeBSD.org>
12302
12303 * NEWS: Mention TLS support for FreeBSD.
12304
12305 2019-03-25 Tom Tromey <tromey@adacore.com>
12306
12307 * minsyms.c (BUNCH_SIZE): Update comment.
12308 (~minimal_symbol_reader): Remove old comment.
12309 (compact_minimal_symbols): Update comment.
12310 (minimal_symbol_reader::install): Remove old comment. Update
12311 other comments.
12312
12313 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12314
12315 * s390-linux-nat.c: Add include.
12316
12317 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12318
12319 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12320 Call linux_get_hwcap.
12321 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12322 Likewise.
12323 (aarch64_linux_get_hwcap): Remove function.
12324 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12325 declaration.
12326 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12327 linux_get_hwcap.
12328 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12329 * linux-tdep.c (linux_get_hwcap): Add function.
12330 (linux_get_hwcap2): Likewise.
12331 * linux-tdep.h (linux_get_hwcap): Add declaration.
12332 (linux_get_hwcap2): Likewise.
12333 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12334 (ppc_linux_get_hwcap2): Likewise.
12335 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12336 linux_get_hwcap.
12337 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12338 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12339 (ppc_linux_nat_target::read_description): Likewise.
12340 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12341 * s390-linux-nat.c: Likewise.
12342 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12343
12344 2019-03-24 Tom Tromey <tom@tromey.com>
12345
12346 * ada-lang.c (standard_lookup): Simplify initialization.
12347 (ada_lookup_symbol_nonlocal): Simplify return.
12348 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12349 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12350 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12351 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12352 initialization.
12353 * solib.c (solib_global_lookup): Simplify.
12354 * symtab.c (null_block_symbol): Remove.
12355 (symbol_cache_lookup): Simplify returns.
12356 (lookup_language_this): Simplify returns.
12357 (lookup_symbol_aux): Simplify return.
12358 (lookup_local_symbol): Simplify returns.
12359 (lookup_global_symbol_from_objfile): Simplify return.
12360 (lookup_symbol_in_objfile_symtabs)
12361 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12362 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12363 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12364 * cp-namespace.c (cp_lookup_bare_symbol)
12365 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12366 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12367 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12368 (cp_lookup_symbol_via_imports): Simplify initialization.
12369 (find_symbol_in_baseclass): Likewise.
12370 * symtab.h (null_block_symbol): Remove.
12371 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12372 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12373 (d_lookup_symbol_module): Likewise.
12374 (find_symbol_in_baseclass): Simplify initialization.
12375
12376 2019-03-24 Tom Tromey <tom@tromey.com>
12377
12378 * expression.h: Don't include symtab.h.
12379 (struct block): Forward declare.
12380
12381 2019-03-24 Tom Tromey <tom@tromey.com>
12382
12383 * c-exp.y (typebase): Remove casts.
12384 * gdbtypes.c (lookup_unsigned_typename, )
12385 (lookup_signed_typename): Remove cast.
12386 * eval.c (parse_to_comma_and_eval): Remove cast.
12387 * parse.c (write_dollar_variable): Remove cast.
12388 * block.h (struct block) <superblock>: Now const.
12389 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12390 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12391 (map_block): Make "block" const.
12392 * symfile.h (struct quick_symbol_functions)
12393 <map_matching_symbols>: Constify block argument to "callback".
12394 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12395 const.
12396 (find_pc_sect_compunit_symtab): Make "b" const.
12397 (find_symbol_at_address): Likewise.
12398 (search_symbols): Likewise.
12399 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12400 (dw2_debug_names_lookup_symbol): Likewise.
12401 (dw2_map_matching_symbols): Update.
12402 * p-valprint.c (pascal_val_print): Remove "block".
12403 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12404 (aux_add_nonlocal_symbols): Make "block" const.
12405 (resolve_subexp): Remove cast.
12406 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12407 const.
12408 (iterate_over_file_blocks): Likewise.
12409 * f-exp.y (%union) <bval>: Remove.
12410 * coffread.c (patch_opaque_types): Make "b" const.
12411 * spu-tdep.c (spu_catch_start): Make "block" const.
12412 * c-valprint.c (print_unpacked_pointer): Remove "block".
12413 * symmisc.c (dump_symtab_1): Make "b" const.
12414 (block_depth): Make "block" const.
12415 * d-exp.y (%union) <bval>: Remove.
12416 * cp-support.h (cp_lookup_rtti_type): Update.
12417 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12418 * psymtab.c (psym_lookup_symbol): Make "block" const.
12419 (maintenance_check_psymtabs): Make "b" const.
12420 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12421 (enumerate_locals, enumerate_args): Update.
12422 * python/py-symtab.c (stpy_global_block): Make "block" const.
12423 (stpy_static_block): Likewise.
12424 * inline-frame.c (block_starting_point_at): Make "new_block"
12425 const.
12426 * block.c (find_block_in_blockvector): Make return type const.
12427 (blockvector_for_pc_sect): Make "b" const.
12428 (find_block_in_blockvector): Make "b" const.
12429
12430 2019-03-23 Tom Tromey <tom@tromey.com>
12431
12432 * varobj.c (varobj_create): Update.
12433 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12434 * printcmd.c (display_command, do_one_display): Don't reset
12435 innermost_block.
12436 * parser-defs.h (enum innermost_block_tracker_type): Move to
12437 expression.h.
12438 (innermost_block): Update comment.
12439 * parse.c (parse_exp_1): Add tracker_types parameter.
12440 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12441 tracker_types parameter. Reset innermost_block.
12442 (parse_exp_in_context): Remove.
12443 (parse_expression_for_completion): Update.
12444 * objfiles.c (~objfile): Don't reset expression_context_block or
12445 innermost_block.
12446 * expression.h (enum innermost_block_tracker_type): Move from
12447 parser-defs.h.
12448 (parse_exp_1): Add tracker_types parameter.
12449 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12450 reset innermost_block.
12451
12452 2019-03-23 Tom Tromey <tom@tromey.com>
12453
12454 * objfiles.h: Include bcache.h.
12455
12456 2019-03-23 Tom Tromey <tom@tromey.com>
12457
12458 * linespec.c (get_current_search_block): Use
12459 scoped_restore_current_language.
12460 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12461
12462 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12463 Jiong Wang <jiong.wang@arm.com>
12464
12465 * aarch64-linux-tdep.c
12466 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12467 section.
12468 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12469
12470 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12471 Jiong Wang <jiong.wang@arm.com>
12472
12473 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12474 instructions.
12475 (aarch64_analyze_prologue_test): Add PACIASP test.
12476 (aarch64_prologue_prev_register): Unmask PC value.
12477
12478 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12479 Jiong Wang <jiong.wang@arm.com>
12480
12481 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12482 (aarch64_dwarf2_prev_register): Unmask PC value.
12483 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12484 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12485 DW_CFA_AARCH64_negate_ra_state.
12486 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12487
12488 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12489 Jiong Wang <jiong.wang@arm.com>
12490
12491 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12492 registers.
12493 (aarch64_pseudo_register_name): Likewise.
12494 (aarch64_pseudo_register_type): Likewise.
12495 (aarch64_pseudo_register_reggroup_p): Likewise.
12496 (aarch64_gdbarch_init): Add pauth registers.
12497 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12498 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12499 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12500 (struct gdbarch_tdep): Add regnum for ra_state.
12501
12502 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12503 Jiong Wang <jiong.wang@arm.com>
12504
12505 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12506
12507 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12508 Jiong Wang <jiong.wang@arm.com>
12509
12510 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12511 function.
12512 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12513 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12514 (aarch64_gdbarch_init): Add puth registers.
12515 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12516 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12517 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12518
12519 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12520 Jiong Wang <jiong.wang@arm.com>
12521
12522 * aarch64-linux-nat.c
12523 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12524 * aarch64-linux-tdep.c
12525 (aarch64_linux_core_read_description): Likewise.
12526 (aarch64_linux_get_hwcap): New function.
12527 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12528 (aarch64_linux_get_hwcap): New declaration.
12529
12530 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12531 Jiong Wang <jiong.wang@arm.com>
12532
12533 * aarch64-linux-nat.c
12534 (aarch64_linux_nat_target::read_description): Add pauth param.
12535 * aarch64-linux-tdep.c
12536 (aarch64_linux_core_read_description): Likewise.
12537 * aarch64-tdep.c (struct target_desc): Add in pauth.
12538 (aarch64_read_description): Add pauth param.
12539 (aarch64_gdbarch_init): Likewise.
12540 * aarch64-tdep.h (aarch64_read_description): Likewise.
12541 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12542 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12543 * features/Makefile: Add new files.
12544 * features/aarch64-pauth.c: New file.
12545 * features/aarch64-pauth.xml: New file.
12546
12547 2019-03-20 Tom Tromey <tromey@adacore.com>
12548
12549 * infrun.c (handle_inferior_event): Rename from
12550 handle_inferior_event_1. Create a scoped_value_mark.
12551 (handle_inferior_event): Remove.
12552
12553 2019-03-19 Tom Tromey <tromey@adacore.com>
12554
12555 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12556 * infrun.h (print_stop_event): Add "displays" parameter.
12557 * infrun.c (print_stop_event): Add "displays" parameter.
12558
12559 2019-03-19 Pedro Alves <palves@redhat.com>
12560
12561 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12562 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12563 to -1. Fix TABs vs spaces.
12564 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12565 * tui/tui-out.h (tui_ui_out) Add intro comments.
12566 <m_line, m_start_of_line>: In-class initialize, and add describing
12567 comment.
12568
12569 2019-03-18 Alan Hayward <alan.hayward@arm.com>
12570
12571 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12572 variable names.
12573 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12574
12575 2019-03-18 Pedro Alves <palves@redhat.com>
12576 Eli Zaretskii <eliz@gnu.org>
12577
12578 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12579 m_line and m_start_of_line.
12580
12581 2019-03-18 Eli Zaretskii <eliz@gnu.org>
12582
12583 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12584 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12585 it returns a newline. This fixes a regression in TU mode, whereby
12586 the next line is output on the same screen line as the user input.
12587
12588 2019-03-18 Tom Tromey <tromey@adacore.com>
12589
12590 * minsyms.c (minimal_symbol_reader::install): Remove call to
12591 obstack_blank.
12592
12593 2019-03-18 Pedro Alves <palves@redhat.com>
12594
12595 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12596 New globals.
12597 (apply_style): New, factored out from ...
12598 (apply_ansi_escape): ... this. Handle reverse video mode.
12599 (tui_set_reverse_mode): New function.
12600 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12601 * tui/tui-winsource.c (tui_show_source_line): Use
12602 tui_set_reverse_mode instead of setting A_STANDOUT.
12603 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12604 New setter methods.
12605
12606 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
12607
12608 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12609 Handle tabs.
12610
12611 2019-03-18 Tom Tromey <tromey@adacore.com>
12612
12613 * ada-lang.c (empty_array): Add "high" parameter.
12614 (ada_evaluate_subexp): Update.
12615
12616 2019-03-17 Sergei Trofimovich <siarheit@google.com>
12617
12618 * unittests/string_view-selftests.c: Define
12619 _initialize_string_view_selftests unconditionally.
12620
12621 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12622
12623 PR gdb/24350
12624 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12625
12626 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12627
12628 PR gdb/24351
12629 * windows-nat.c (display_selector): Fix format specifiers.
12630
12631 2019-03-17 Eli Zaretskii <eliz@gnu.org>
12632
12633 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12634 tui_refill_source_window instead of tui_refresh_win, to update the
12635 current execution line. This fixes redisplay of the current line
12636 when stepping through the code with "next" or "step".
12637
12638 2019-03-16 Eli Zaretskii <eliz@gnu.org>
12639
12640 * source-cache.c (source_cache::get_source_lines): Call
12641 find_source_lines to initialize s->nlines. This fixes vertical
12642 scrolling of TUI source window when the DOWN arrow is pressed.
12643
12644 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12645
12646 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12647 linux-thread-db.c (_initialize_thread_db): Likewise.
12648
12649 2019-03-16 Eli Zaretskii <eliz@gnu.org>
12650
12651 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12652 wclrtoeol in tui_show_source_line". This reverts changes made in
12653 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12654
12655 2019-03-15 Tom Tromey <tom@tromey.com>
12656
12657 * symtab.h (struct minimal_symbol): Derive from
12658 general_symbol_info.
12659 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12660 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12661 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12662 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12663 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12664 (MSYMBOL_SEARCH_NAME): Update.
12665 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12666 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12667 * minsyms.c (minimal_symbol_reader::record_full): Update.
12668
12669 2019-03-15 Tom Tromey <tom@tromey.com>
12670
12671 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12672
12673 2019-03-15 Tom Tromey <tom@tromey.com>
12674
12675 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12676 unique_xmalloc_ptr.
12677 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12678 Update.
12679 * minsyms.c (lookup_minimal_symbol_by_pc_section)
12680 (build_minimal_symbol_hash_tables)
12681 (minimal_symbol_reader::install): Update.
12682
12683 2019-03-15 Tom Tromey <tom@tromey.com>
12684
12685 * symtab.c (create_demangled_names_hash): Update.
12686 (symbol_set_names): Update.
12687 * objfiles.h (struct objfile_per_bfd_storage)
12688 <demangled_names_hash>: Now an htab_up.
12689 * objfiles.c (objfile_per_bfd_storage): Simplify.
12690
12691 2019-03-15 Tom Tromey <tom@tromey.com>
12692
12693 * objfiles.h (struct objfile_per_bfd_storage): Declare
12694 destructor.
12695 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12696 New.
12697 (get_objfile_bfd_data): Use new. Don't initialize
12698 language_of_main.
12699 (free_objfile_per_bfd_storage): Remove.
12700 (objfile_bfd_data_free, objfile::~objfile): Use delete.
12701
12702 2019-03-15 Tom Tromey <tom@tromey.com>
12703
12704 * symfile.c (reread_symbols): Update.
12705 * objfiles.c (objfile::objfile): Update.
12706 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12707 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12708 comment.
12709 (minimal_symbol_reader::install): Update.
12710 (terminate_minimal_symbol_table): Remove.
12711 * jit.c (jit_object_close_impl): Update.
12712
12713 2019-03-15 Tom Tromey <tom@tromey.com>
12714
12715 * minsyms.c (minimal_symbol_reader::record_full): Remove some
12716 initializations.
12717
12718 2019-03-15 Tom Tromey <tom@tromey.com>
12719
12720 * objfiles.h (struct objfile_per_bfd_storage)
12721 <demangled_hash_languages>: Now a bitset.
12722 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12723 (lookup_minimal_symbol): Update.
12724
12725 2019-03-15 Tom Tromey <tom@tromey.com>
12726
12727 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12728 Don't return the symbol.
12729 * coffread.c (record_minimal_symbol): Use record_full.
12730
12731 2019-03-14 Eli Zaretskii <eliz@gnu.org>
12732
12733 The MS-Windows port of ncurses fails to switch to a color pair if
12734 one or both of the colors are the implicit default colors. This
12735 change records the default colors when TUI is initialized, and
12736 then specifies them explicitly when a color pair uses the default
12737 colors. This allows color styling in TUI mode on MS-Windows.
12738
12739 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
12740 ncurses_norm_attr.
12741 (tui_initialize_io) [__MINGW32__]: Record the default terminal
12742 colors in ncurses_norm_attr.
12743 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12744 "none", replace it with the default color recorded in
12745 ncurses_norm_attr.
12746
12747 2019-03-14 Tom Tromey <tromey@adacore.com>
12748
12749 * source-cache.h (class source_cache) <get_source_lines>: Return
12750 std::string.
12751 * source-cache.c (source_cache::extract_lines): Handle case where
12752 first_pos==npos. Return std::string.
12753 (source_cache::get_source_lines): Update.
12754
12755 2019-03-14 Tom Tromey <tromey@adacore.com>
12756
12757 * NEWS: Add item for "style sources" commands.
12758 * source-cache.c (source_cache::get_source_lines): Check
12759 source_styling.
12760 * cli/cli-style.c (source_styling): New global.
12761 (_initialize_cli_style): Add "style sources" commands.
12762 (show_style_sources): New function.
12763 * cli/cli-style.h (source_styling): Declare.
12764
12765 2019-03-14 Pedro Alves <palves@redhat.com>
12766 Tom Tromey <tromey@adacore.com>
12767
12768 * tui/tui-winsource.h (tui_refill_source_window): Declare.
12769 * tui/tui-winsource.c (tui_refill_source_window): New function,
12770 from...
12771 (tui_horizontal_source_scroll): ... here. Move some logic.
12772 * cli/cli-style.c (set_style_enabled): Notify new observable.
12773 * tui/tui-hooks.c (tui_redisplay_source): New function.
12774 (tui_attach_detach_observers): Attach or detach
12775 tui_redisplay_source.
12776 * observable.h (source_styling_changed): New observable.
12777 * observable.c: Define source_styling_changed observable.
12778
12779 2019-03-13 Tom Tromey <tromey@adacore.com>
12780
12781 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12782 (i386_gnu_nat_target::store_registers): Update.
12783 * target-debug.h (target_debug_print_std_string): New macro.
12784 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12785 * windows-tdep.c (display_one_tib): Update.
12786 * tui/tui-stack.c (tui_make_status_line): Update.
12787 * top.c (print_inferior_quit_action): Update.
12788 * thread.c (thr_try_catch_cmd): Update.
12789 (add_thread_with_info): Update.
12790 (thread_target_id_str): Update.
12791 (thr_try_catch_cmd): Update.
12792 (thread_command): Update.
12793 (thread_find_command): Update.
12794 * record-btrace.c (record_btrace_target::info_record)
12795 (record_btrace_resume_thread, record_btrace_target::resume)
12796 (record_btrace_cancel_resume, record_btrace_step_thread)
12797 (record_btrace_target::wait, record_btrace_target::wait)
12798 (record_btrace_target::wait, record_btrace_target::stop): Update.
12799 * progspace.c (print_program_space): Update.
12800 * process-stratum-target.c
12801 (process_stratum_target::thread_address_space): Update.
12802 * linux-fork.c (linux_fork_mourn_inferior)
12803 (detach_checkpoint_command, info_checkpoints_command)
12804 (linux_fork_context): Update.
12805 (linux_fork_detach): Update.
12806 (class scoped_switch_fork_info): Update.
12807 (delete_checkpoint_command): Update.
12808 * infrun.c (follow_fork_inferior): Update.
12809 (follow_fork_inferior): Update.
12810 (proceed_after_vfork_done): Update.
12811 (handle_vfork_child_exec_or_exit): Update.
12812 (follow_exec): Update.
12813 (displaced_step_prepare_throw): Update.
12814 (displaced_step_restore): Update.
12815 (start_step_over): Update.
12816 (resume_1): Update.
12817 (clear_proceed_status_thread): Update.
12818 (proceed): Update.
12819 (print_target_wait_results): Update.
12820 (do_target_wait): Update.
12821 (context_switch): Update.
12822 (stop_all_threads): Update.
12823 (restart_threads): Update.
12824 (finish_step_over): Update.
12825 (handle_signal_stop): Update.
12826 (switch_back_to_stepped_thread): Update.
12827 (keep_going_pass_signal): Update.
12828 (print_exited_reason): Update.
12829 (normal_stop): Update.
12830 * inferior.c (inferior_pid_to_str): Change return type.
12831 (print_selected_inferior): Update.
12832 (add_inferior): Update.
12833 (detach_inferior): Update.
12834 * dummy-frame.c (fprint_dummy_frames): Update.
12835 * dcache.c (dcache_info_1): Update.
12836 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
12837 (btrace_fetch, btrace_clear): Update.
12838 * linux-tdep.c (linux_core_pid_to_str): Change return type.
12839 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
12840 type.
12841 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
12842 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
12843 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
12844 * gdbarch.c, gdbarch.h: Rebuild.
12845 * gdbarch.sh (core_pid_to_str): Change return type.
12846 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
12847 return type.
12848 (windows_nat_target::pid_to_str): Change return type.
12849 (windows_delete_thread): Update.
12850 (windows_nat_target::attach): Update.
12851 (windows_nat_target::files_info): Update.
12852 * target-delegates.c: Rebuild.
12853 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
12854 return type.
12855 (sol_thread_target::pid_to_str): Change return type.
12856 * remote.c (class remote_target) <pid_to_str>: Change return
12857 type.
12858 (remote_target::pid_to_str): Change return type.
12859 (extended_remote_target::attach, remote_target::remote_stop_ns)
12860 (remote_target::remote_notif_remove_queued_reply)
12861 (remote_target::push_stop_reply, remote_target::disable_btrace):
12862 Update.
12863 (extended_remote_target::attach): Update.
12864 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
12865 type.
12866 (gdbsim_target::pid_to_str): Change return type.
12867 * ravenscar-thread.c (struct ravenscar_thread_target)
12868 <pid_to_str>: Change return type.
12869 (ravenscar_thread_target::pid_to_str): Change return type.
12870 * procfs.c (class procfs_target) <pid_to_str>: Change return
12871 type.
12872 (procfs_target::pid_to_str): Change return type.
12873 (procfs_target::attach): Update.
12874 (procfs_target::detach): Update.
12875 (procfs_target::fetch_registers): Update.
12876 (procfs_target::store_registers): Update.
12877 (procfs_target::wait): Update.
12878 (procfs_target::files_info): Update.
12879 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
12880 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
12881 return type.
12882 (nto_procfs_target::pid_to_str): Change return type.
12883 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
12884 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
12885 return type.
12886 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
12887 (exit_lwp): Update.
12888 (attach_proc_task_lwp_callback, get_detach_signal)
12889 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
12890 (linux_nat_target::resume, wait_lwp, stop_callback)
12891 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
12892 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
12893 (linux_nat_wait_1, resume_stopped_resumed_lwps)
12894 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
12895 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
12896 type.
12897 (inf_ptrace_target::attach): Update.
12898 (inf_ptrace_target::files_info): Update.
12899 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
12900 type.
12901 (go32_nat_target::pid_to_str): Change return type.
12902 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
12903 (gnu_nat_target::wait): Update.
12904 (gnu_nat_target::wait): Update.
12905 (gnu_nat_target::resume): Update.
12906 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
12907 (fbsd_nat_target::wait): Update.
12908 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
12909 type.
12910 (darwin_nat_target::attach): Update.
12911 * corelow.c (class core_target) <pid_to_str>: Change return type.
12912 (core_target::pid_to_str): Change return type.
12913 * target.c (normal_pid_to_str): Change return type.
12914 (default_pid_to_str): Likewise.
12915 (target_pid_to_str): Change return type.
12916 (target_translate_tls_address): Update.
12917 (target_announce_detach): Update.
12918 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
12919 return type.
12920 (bsd_uthread_target::pid_to_str): Change return type.
12921 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
12922 type.
12923 (bsd_kvm_target::pid_to_str): Change return type.
12924 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
12925 return type.
12926 (aix_thread_target::pid_to_str): Change return type.
12927 * target.h (struct target_ops) <pid_to_str>: Change return type.
12928 (target_pid_to_str, normal_pid_to_str): Likewise.
12929 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
12930 type.
12931 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
12932 type.
12933 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
12934 return type.
12935 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
12936 type.
12937 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
12938 type.
12939 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
12940 return type.
12941
12942 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
12943
12944 * NEWS: Mention that the new default MI version is 3. Mention
12945 changes to the output of commands and events that deal with
12946 multi-location breakpoints.
12947 * breakpoint.c: Include "mi/mi-out.h".
12948 (print_one_breakpoint): Change output syntax if using MI version
12949 >= 3.
12950 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
12951 New.
12952 (mi_multi_location_breakpoint_output_fixed): New.
12953 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
12954 (mi_cmd_fix_multi_location_breakpoint_output): New.
12955 (mi_multi_location_breakpoint_output_fixed): New.
12956 * mi/mi-cmds.c (mi_cmds): Register command
12957 -fix-multi-location-breakpoint-output.
12958 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
12959 interpreter "mi".
12960
12961 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
12962
12963 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
12964 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
12965 instantiate mi_ui_out based on interpreter name.
12966 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
12967 * mi/mi-main.c (mi_load_progress): Likewise.
12968
12969 2019-03-12 John Baldwin <jhb@FreeBSD.org>
12970
12971 * NEWS: Combine separate "New targets" sections for 8.3.
12972
12973 2019-03-12 John Baldwin <jhb@FreeBSD.org>
12974
12975 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
12976 (ppcfbsd_init_abi): Install gdbarch
12977 "fetch_tls_load_module_address" and "get_thread_local_address"
12978 methods.
12979
12980 2019-03-12 John Baldwin <jhb@FreeBSD.org>
12981
12982 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
12983 (riscv_fbsd_init_abi): Install gdbarch
12984 "fetch_tls_load_module_address" and "get_thread_local_address"
12985 methods.
12986
12987 2019-03-12 John Baldwin <jhb@FreeBSD.org>
12988
12989 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
12990 (i386fbsd_init_abi): Install gdbarch
12991 "fetch_tls_load_module_address" and "get_thread_local_address"
12992 methods.
12993
12994 2019-03-12 John Baldwin <jhb@FreeBSD.org>
12995
12996 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
12997 (amd64fbsd_init_abi): Install gdbarch
12998 "fetch_tls_load_module_address" and "get_thread_local_address"
12999 methods.
13000
13001 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13002
13003 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13004 (struct fbsd_pspace_data): New type.
13005 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13006 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13007 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13008 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13009 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13010
13011 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13012
13013 * gdbtypes.c (lookup_struct_elt): New function.
13014 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13015 * gdbtypes.h (struct struct_elt): New type.
13016 (lookup_struct_elt): New prototype.
13017
13018 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13019
13020 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13021 remove disabled code block.
13022
13023 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13024
13025 * gdbarch.sh (get_thread_local_address): New method.
13026 * gdbarch.h, gdbarch.c: Regenerate.
13027 * target.c (target_translate_tls_address): Use
13028 gdbarch_get_thread_local_address if present instead of
13029 target::get_thread_local_address.
13030
13031 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13032
13033 * target.h (target::get_thread_local_address): Update comment.
13034
13035 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13036
13037 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13038 objfile->separate_debug_objfile_backlink if not NULL.
13039
13040 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13041
13042 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13043 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13044 (amd64bsd_store_inferior_registers): Likewise.
13045 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13046 Enable segment base registers.
13047 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13048 PT_GETFSBASE and PT_GETGSBASE.
13049 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13050 PT_SETGSBASE.
13051 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13052 segment base registers.
13053 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13054
13055 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13056
13057 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13058 Update calls to i386_target_description to add 'segments'
13059 parameter.
13060 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13061 add segment base registers.
13062 * arch/i386.c (i386_create_target_description): Add 'segments'
13063 parameter to enable segment base registers.
13064 * arch/i386.h (i386_create_target_description): Likewise.
13065 * features/i386/32bit-segments.xml: New file.
13066 * features/i386/32bit-segments.c: Generate.
13067 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13068 call to i386_target_description to add 'segments' parameter.
13069 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13070 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13071 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13072 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13073 if feature is present.
13074 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13075 Add 'segments' parameter to call to i386_target_description.
13076 (i386_target_description): Add 'segments' parameter to enable
13077 segment base registers.
13078 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13079 to call to i386_target_description.
13080 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13081 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13082 Define I386_NUM_REGS.
13083 (i386_target_description): Add 'segments' parameter to enable
13084 segment base registers.
13085
13086 2019-03-12 Eli Zaretskii <eliz@gnu.org>
13087
13088 PR/24325
13089 * source-cache.c: #undef open and close, to avoid unresolved
13090 externals during linking.
13091
13092 2019-03-12 Tom Tromey <tromey@adacore.com>
13093
13094 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13095 const. Add initializers.
13096 (_initialize_remote): Don't initialize ptid globals.
13097
13098 2019-03-12 Pedro Alves <palves@redhat.com>
13099
13100 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13101
13102 2019-03-12 Pedro Alves <palves@redhat.com>
13103
13104 * cp-name-parser.y (main): Remove unused 'len' variable.
13105
13106 2019-03-12 Tom Tromey <tromey@adacore.com>
13107
13108 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13109 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13110
13111 2019-03-12 Tom Tromey <tromey@adacore.com>
13112
13113 * linux-nat.c (iterate_over_lwps): Update.
13114 (stop_callback): Remove parameter.
13115 (stop_wait_callback, detach_callback, resume_set_callback)
13116 (select_singlestep_lwp_callback, set_ignore_sigint)
13117 (status_callback, resumed_callback, resume_clear_callback)
13118 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13119 data parameter.
13120 (linux_nat_target::detach, linux_nat_target::resume)
13121 (linux_stop_and_wait_all_lwps, select_event_lwp)
13122 (linux_nat_filter_event, linux_nat_wait_1)
13123 (linux_nat_target::kill, linux_nat_target::stop)
13124 (linux_nat_target::stop): Update.
13125 (linux_nat_resume_callback): Change type.
13126 (resume_stopped_resumed_lwps, count_events_callback)
13127 (select_event_lwp_callback): Likewise.
13128 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13129 * arm-linux-nat.c (struct update_registers_data): Remove.
13130 (update_registers_callback): Change type.
13131 (arm_linux_insert_hw_breakpoint1): Update.
13132 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13133 parameter.
13134 (x86_linux_dr_set_addr): Update.
13135 (x86_linux_dr_set_control): Update.
13136 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13137 (iterate_over_lwps): Use gdb::function_view.
13138 * nat/aarch64-linux-hw-point.c (struct
13139 aarch64_dr_update_callback_param): Remove.
13140 (debug_reg_change_callback): Change type.
13141 (aarch64_notify_debug_reg_change): Update.
13142 * s390-linux-nat.c (s390_refresh_per_info): Update.
13143
13144 2019-03-11 Tom Tromey <tromey@adacore.com>
13145
13146 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13147 redundant assignment to "this_cu".
13148
13149 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13150
13151 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13152
13153 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13154
13155 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13156 from...
13157 (rank_one_type): ... this.
13158
13159 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13160
13161 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13162 from...
13163 (rank_one_type): ... this.
13164
13165 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13166
13167 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13168 from...
13169 (rank_one_type): ... this.
13170
13171 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13172
13173 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13174 from...
13175 (rank_one_type): ... this.
13176
13177 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13178
13179 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13180 from...
13181 (rank_one_type): ... this.
13182
13183 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13184
13185 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13186 from...
13187 (rank_one_type): ... this.
13188
13189 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13190
13191 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13192 from...
13193 (rank_one_type): ... this.
13194
13195 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13196
13197 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13198 from...
13199 (rank_one_type): ... this.
13200
13201 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13202
13203 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13204 from...
13205 (rank_one_type): ... this.
13206
13207 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13208
13209 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13210 from...
13211 (rank_one_type): ... this.
13212
13213 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13214
13215 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13216 from...
13217 (rank_one_type): ... this.
13218
13219 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13220
13221 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13222 from...
13223 (rank_one_type): ... this.
13224
13225 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13226
13227 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13228 inferior-events' shows the example events.
13229
13230 2019-03-08 Eli Zaretskii <eliz@gnu.org>
13231
13232 Support styling on native MS-Windows console
13233
13234 PR/24315
13235 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13236 on MS-Windows if $TERM is not defined.
13237
13238 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13239
13240 * posix-hdep.c (gdb_console_fputs):
13241 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13242 functions.
13243 * ui-file.h (gdb_console_fputs): Add prototype.
13244
13245 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13246 back to fputs only if the former returns zero.
13247
13248 2019-03-07 Tom Tromey <tom@tromey.com>
13249
13250 * symmisc.c (print_symbol_bcache_statistics): Update.
13251 (print_objfile_statistics): Update.
13252 * symfile.c (allocate_symtab): Update.
13253 * stabsread.c: Don't include bcache.h.
13254 * psymtab.h (struct psymbol_bcache): Don't declare.
13255 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13256 (psymbol_bcache_init, psymbol_bcache_free)
13257 (psymbol_bcache_get_bcache): Don't declare.
13258 * psymtab.c (struct psymbol_bcache): Remove.
13259 (psymtab_storage::psymtab_storage): Update.
13260 (psymtab_storage::~psymtab_storage): Update.
13261 (psymbol_bcache_init, psymbol_bcache_free)
13262 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13263 (add_psymbol_to_bcache): Update.
13264 (allocate_psymtab): Update.
13265 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13266 macro_cache>: No longer pointers.
13267 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13268 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13269 * macrotab.c (macro_bcache): Update.
13270 * macroexp.c: Don't include bcache.h.
13271 * gdbtypes.c (check_types_worklist): Update.
13272 (types_deeply_equal): Remove TRY/CATCH. Update.
13273 * elfread.c (elf_symtab_read): Update.
13274 * dwarf2read.c: Don't include bcache.h.
13275 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13276 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13277 (print_bcache_statistics, bcache_memory_used): Don't declare.
13278 (struct bcache): Move from bcache.c. Add constructor, destructor,
13279 methods. Rename all data members.
13280 * bcache.c (struct bcache): Move to bcache.h.
13281 (bcache::expand_hash_table): Rename from expand_hash_table.
13282 (bcache): Remove.
13283 (bcache::insert): Rename from bcache_full.
13284 (bcache::compare): Rename from bcache_compare.
13285 (bcache_xmalloc): Remove.
13286 (bcache::~bcache): Rename from bcache_xfree.
13287 (bcache::print_statistics): Rename from print_bcache_statistics.
13288 (bcache::memory_used): Rename from bcache_memory_used.
13289
13290 2019-03-07 Pedro Alves <palves@redhat.com>
13291
13292 * infrun.c (normal_stop): Also check for
13293 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13294
13295 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13296
13297 * f-lang.c (value_from_host_double): Moved to...
13298 * value.c (value_from_host_double): ...here.
13299 * value.h (value_from_host_double): Declare.
13300 * guile/scm-math.c (vlscm_convert_typed_number): Use
13301 value_from_host_double.
13302 (vlscm_convert_number): Likewise.
13303 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13304 * python/py-value.c (convert_value_from_python): Likewise.
13305
13306 2019-03-06 Tom Tromey <tom@tromey.com>
13307
13308 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13309
13310 2019-03-06 Tom Tromey <tom@tromey.com>
13311
13312 * utils.h (free_current_contents): Don't declare.
13313 * utils.c (free_current_contents): Remove.
13314
13315 2019-03-06 Tom Tromey <tom@tromey.com>
13316
13317 * top.c (quit_force): Update.
13318 * main.c (captured_command_loop): Update.
13319 * common/new-op.c (operator new): Update.
13320 * common/common-exceptions.c (struct catcher)
13321 <save_cleanup_chain>: Remove member.
13322 (exceptions_state_mc_init): Update.
13323 (exception_try_scope_entry): Return nullptr.
13324 (exception_try_scope_exit, exception_rethrow)
13325 (throw_exception_sjlj, throw_exception_cxx): Update.
13326 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13327 (all_cleanups, do_cleanups, discard_cleanups)
13328 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13329 (restore_cleanups, restore_final_cleanups): Don't declare.
13330 (do_final_cleanups): Remove parameter.
13331 * common/cleanups.c (cleanup_chain, make_cleanup)
13332 (make_cleanup_dtor, all_cleanups, do_cleanups)
13333 (discard_my_cleanups, discard_cleanups)
13334 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13335 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13336 (null_cleanup): Remove.
13337 (do_final_cleanups): Remove parameter.
13338
13339 2019-03-06 Tom Tromey <tom@tromey.com>
13340
13341 * remote.c (remote_target::remote_parse_stop_reply): Use
13342 unique_xmalloc_ptr.
13343
13344 2019-03-06 Tom Tromey <tom@tromey.com>
13345
13346 * stabsread.c (struct stabs_field_info): Rename from field_info.
13347 <list, fnlist>: Add initializers.
13348 <obstack>: New member.
13349 (read_member_functions, read_struct_fields, read_baseclasses):
13350 Allocate on obstack. Don't use cleanups.
13351 (read_one_struct_field, read_member_functions, read_struct_fields)
13352 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13353 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13354 (read_struct_type): Update.
13355
13356 2019-03-06 Tom Tromey <tom@tromey.com>
13357
13358 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13359 * common/filestuff.h (make_cleanup_close): Don't declare.
13360 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13361 Remove.
13362
13363 2019-03-06 Tom Tromey <tom@tromey.com>
13364
13365 * solib-aix.c: Use make_scope_exit.
13366
13367 2019-03-06 Tom Tromey <tom@tromey.com>
13368
13369 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13370 Use make_scope_exit.
13371
13372 2019-03-06 Tom Tromey <tom@tromey.com>
13373
13374 * solib-svr4.c (disable_probes_interface): Remove parameter.
13375 (svr4_handle_solib_event): Use make_scope_exit.
13376
13377 2019-03-06 Tom Tromey <tom@tromey.com>
13378
13379 * remote.c (struct stop_reply_deleter): Remove.
13380 (stop_reply_up): Update.
13381 (struct stop_reply): Derive from notif_event. Don't typedef.
13382 <regcache>: Now a std::vector.
13383 (stop_reply_xfree): Remove.
13384 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13385 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13386 (remote_target::discard_pending_stop_replies): Use delete.
13387 (remote_target::remote_parse_stop_reply): Update.
13388 (remote_target::process_stop_reply): Update.
13389 * remote-notif.h (struct notif_event): Add virtual destructor.
13390 Remove "dtr" member.
13391 (struct notif_client) <alloc_event>: Return a unique_ptr.
13392 (notif_event_xfree): Don't declare.
13393 (notif_event_up): New typedef.
13394 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13395 (notif_event_xfree, do_notif_event_xfree): Remove.
13396 (remote_notif_state_xfree): Update.
13397
13398 2019-03-06 Tom Tromey <tom@tromey.com>
13399
13400 * infrun.c (displaced_step_clear_cleanup): Now a
13401 forward_scope_exit type.
13402 (displaced_step_prepare_throw): Update.
13403 (displaced_step_fixup): Update.
13404
13405 2019-03-06 Tom Tromey <tom@tromey.com>
13406
13407 * inferior.h (class inferior): Update comment.
13408 * gdbthread.h (class thread_info): Update comment.
13409
13410 2019-03-06 Joel Brobecker <brobecker@adacore.com>
13411 Tom Tromey <tom@tromey.com>
13412
13413 * stabsread.h (struct stab_section_list): Remove.
13414 (coffstab_build_psymtabs): Update.
13415 * dbxread.c (symbuf_sections): Now a std::vector.
13416 (sect_idx): New global.
13417 (fill_symbuf): Update.
13418 (coffstab_build_psymtabs): Change type of stabsects parameter.
13419 Update.
13420 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13421 std::vector.
13422 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13423 (coff_locate_sections): Update.
13424 (coff_symfile_read): Remove cleanups. Update.
13425 (init_stringtab): Add storage parameter.
13426 (free_stringtab, free_stringtab_cleanup): Remove.
13427 (init_lineno): Add storage parameter.
13428 (free_linetab, free_linetab_cleanup): Remove.
13429
13430 2019-03-06 Pedro Alves <palves@redhat.com>
13431
13432 * linux-fork.c (fork_info::clobber_regs): Delete.
13433 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13434 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13435 comment. Adjust.
13436 (scoped_switch_fork_info::scoped_switch_fork_info)
13437 (checkpoint_command, linux_fork_context): Adjust
13438 fork_save_infrun_state calls.
13439
13440 2019-03-06 Pedro Alves <palves@redhat.com>
13441
13442 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13443 (inf_has_multiple_threads): Return 'bool' and rewrite using
13444 inferior_info::threads().
13445
13446 2019-03-06 Pedro Alves <palves@redhat.com>
13447
13448 * linux-fork.c: Include <list>.
13449 (fork_list): Now a std::list instance.
13450 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13451 (forks_exist_p, find_last_fork): Adjust.
13452 (new_fork): Delete.
13453 (one_fork_p): New.
13454 (add_fork): Adjust.
13455 (free_fork): Delete, folded into fork_info::~fork_info().
13456 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13457 Adjust.
13458 (init_fork_list): Delete.
13459 (linux_fork_killall, linux_fork_mourn_inferior)
13460 (linux_fork_detach, info_checkpoints_command): Adjust.
13461 (_initialize_linux_fork): No longer call init_fork_list.
13462
13463 2019-03-06 Pedro Alves <palves@redhat.com>
13464
13465 * linux-fork.c (new_fork): New, split out of ...
13466 (add_fork): ... this. Return void. Move "first fork" special
13467 case from here, to ...
13468 (checkpoint_command): ... here.
13469 * linux-linux.h (add_fork): Return void.
13470
13471 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13472
13473 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13474
13475 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13476 Chris January <chris.january@arm.com>
13477 David Lecomber <david.lecomber@arm.com>
13478
13479 * f-exp.y: New token, UNOP_INTRINSIC.
13480 (exp): New pattern using UNOP_INTRINSIC token.
13481 (f77_keywords): Add 'abs' keyword.
13482 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13483 (value_from_host_double): New function.
13484 (evaluate_subexp_f): Support UNOP_ABS.
13485
13486 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13487
13488 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13489 types.
13490
13491 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13492
13493 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13494 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13495 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13496
13497 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13498
13499 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13500
13501 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13502 Chris January <chris.january@arm.com>
13503
13504 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13505 * f-exp.y: Define 'KIND' token.
13506 (exp): New pattern for KIND expressions.
13507 (ptype): Handle types with a kind extension.
13508 (direct_abs_decl): Extend to spot kind extensions.
13509 (f77_keywords): Add 'kind' to the list.
13510 (push_kind_type): New function.
13511 (convert_to_kind_type): New function.
13512 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13513 * parse.c (operator_length_standard): Likewise.
13514 * parser-defs.h (enum type_pieces): Add tp_kind.
13515 * std-operator.def: Add UNOP_KIND.
13516
13517 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13518
13519 * f-exp.y (f_parse): Set yydebug.
13520
13521 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13522
13523 * f-lang.c (evaluate_subexp_f): New function.
13524 (exp_descriptor_f): New global.
13525 (f_language_defn): Use exp_descriptor_f instead of
13526 exp_descriptor_standard.
13527
13528 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13529
13530 * f-exp.y (struct token): Add comments.
13531 (dot_ops): Remove uppercase versions and the end marker.
13532 (f77_keywords): Likewise.
13533 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13534 entries in the dot_ops array are case insensitive, and use
13535 strncasecmp to compare strings. Also some whitespace cleanup in
13536 this area. Similar for the f77_keywords array, except entries in
13537 this list might be case sensitive.
13538
13539 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13540
13541 * f-exp.y (struct f77_boolean_val): Add comments.
13542 (boolean_values): Remove uppercase versions, and end marker.
13543 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13544 and use strncasecmp to achieve case insensitivity. Additionally,
13545 perform whitespace cleanup around this code.
13546
13547 2019-03-06 Tom Tromey <tromey@adacore.com>
13548
13549 * remote-sim.c (gdbsim_target_open): Use result of
13550 gdb_argv::release.
13551
13552 2019-03-06 Richard Bunt <richard.bunt@arm.com>
13553 Dirk Schubert <dirk.schubert@arm.com>
13554 Chris January <chris.january@arm.com>
13555
13556 * eval.c (evaluate_subexp_standard): Call Fortran argument
13557 wrapping logic.
13558 * f-lang.c (struct value): A value which can be passed into a
13559 Fortran function call.
13560 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13561 where appropriate.
13562 (struct type): Value ready for a Fortran function call.
13563 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13564 is needed.
13565 * f-lang.h (fortran_argument_convert): Declaration.
13566 (fortran_preserve_arg_pointer): Declaration.
13567 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13568
13569 2019-03-05 Tom Tromey <tromey@adacore.com>
13570
13571 * python/py-prettyprint.c (print_string_repr): Remove #if.
13572 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13573
13574 2019-03-05 Tom Tromey <tromey@adacore.com>
13575
13576 * target.c (the_dummy_target): Move later. Change type to
13577 "dummy_target".
13578 (initialize_targets): Don't initialize the_dummy_target.
13579
13580 2019-03-05 Tom Tromey <tromey@adacore.com>
13581
13582 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13583 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13584
13585 2019-03-05 Tom Tromey <tromey@adacore.com>
13586
13587 * windows-nat.c (windows_nat_target::attach)
13588 (windows_nat_target::detach): Don't call gdb_flush.
13589 * valprint.c (generic_val_print, val_print, val_print_string):
13590 Don't call gdb_flush.
13591 * utils.c (defaulted_query): Don't call gdb_flush.
13592 * typeprint.c (print_type_scalar): Don't call gdb_flush.
13593 * target.c (target_announce_detach): Don't call gdb_flush.
13594 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13595 * remote.c (extended_remote_target::attach): Don't call
13596 gdb_flush.
13597 * procfs.c (procfs_target::detach): Don't call gdb_flush.
13598 * printcmd.c (do_examine): Don't call gdb_flush.
13599 (info_display_command): Don't call gdb_flush.
13600 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13601 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13602 * memattr.c (info_mem_command): Don't call gdb_flush.
13603 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13604 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13605 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13606 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13607 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13608 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13609 (gnu_nat_target::detach): Don't call gdb_flush.
13610 * f-valprint.c (f_val_print): Don't call gdb_flush.
13611 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13612 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13613 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13614 gdb_flush.
13615 * c-valprint.c (c_val_print): Don't call gdb_flush.
13616 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13617
13618 2019-03-05 Tom Tromey <tromey@adacore.com>
13619
13620 * varobj.c (update_dynamic_varobj_children): Update.
13621 (install_default_visualizer): Use reset, not release.
13622 * value.c (set_internalvar): Update.
13623 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13624 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13625 ATTRIBUTE_UNUSED_RESULT.
13626
13627 2019-03-05 Tom Tromey <tromey@adacore.com>
13628
13629 * remote.c (class scoped_remote_fd) <release>: Add
13630 ATTRIBUTE_UNUSED_RESULT.
13631
13632 2019-03-05 Tom Tromey <tromey@adacore.com>
13633
13634 * macroexp.c (struct macro_buffer) <release>: Add
13635 ATTRIBUTE_UNUSED_RESULT.
13636
13637 2019-03-05 Tom Tromey <tromey@adacore.com>
13638
13639 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13640 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13641 ATTRIBUTE_UNUSED_RESULT.
13642
13643 2019-03-05 Tom Tromey <tromey@adacore.com>
13644
13645 * common/scoped_fd.h (class scoped_fd) <release>: Add
13646 ATTRIBUTE_UNUSED_RESULT.
13647
13648 2019-03-05 Tom Tromey <tromey@adacore.com>
13649
13650 * parser-defs.h (struct parser_state) <release>: Add
13651 ATTRIBUTE_UNUSED_RESULT.
13652
13653 2019-03-05 Tom Tromey <tromey@adacore.com>
13654
13655 * utils.h (class gdb_argv) <release>: Add
13656 ATTRIBUTE_UNUSED_RESULT.
13657 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13658
13659 2019-03-02 Eli Zaretskii <eliz@gnu.org>
13660
13661 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13662 for-loop range, to avoid compiler warnings.
13663
13664 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13665 avoid compiler warnings about unused variables.
13666
13667 * NEWS: Mention end of support for native debugging on MS-Windows
13668 before XP.
13669
13670 PR gdb/24292
13671 * common/netstuff.c:
13672 * gdbserver/gdbreplay.c
13673 * gdbserver/remote-utils.c:
13674 * ser-tcp.c:
13675 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13676 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
13677 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13678 'getaddrinfo' and 'freeaddrinfo' were not available before
13679 Windows XP, and mingw.org's MinGW headers by default define
13680 _WIN32_WINNT to 0x500.
13681
13682 2019-03-01 Gary Benson <gbenson@redhat.com>
13683
13684 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13685
13686 2019-02-28 Brian Vandenberg <phantall@gmail.com>
13687 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
13688
13689 PR gdb/8527
13690 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13691 set_sigint_trap, clear_sigint_trap.
13692
13693 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13694
13695 * target.c (target_detach): Clear the regcache and the
13696 frame cache.
13697
13698 2019-02-27 Pedro Alves <palves@redhat.com>
13699
13700 * utils.c (set_screen_size): When we cap the height/width sizes,
13701 tweak the corresponding command variable to show "unlimited":
13702
13703 2019-02-27 Saagar Jha <saagar@saagarjha.com>
13704 Pedro Alves <palves@redhat.com>
13705
13706 * utils.c (set_screen_size): Reduce "infinite" rows and columns
13707 before calling rl_set_screen_size.
13708
13709 2019-02-27 Tom Tromey <tromey@adacore.com>
13710
13711 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13712 define.
13713 * python/py-value.c: Remove Python 2.4 workaround.
13714 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13715 workaround.
13716 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13717 Python 2.4 workaround.
13718 * python/python-internal.h: Remove Python 2.4 comment.
13719 (Py_ssize_t): Don't define.
13720 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13721 (gdb_Py_DECREF): Remove Python 2.4 workaround.
13722 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13723 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13724 * python/python.c (do_start_initialization): Remove Python 2.4
13725 workaround.
13726 * python/py-prettyprint.c (class dummy_python_frame): Remove.
13727 (print_children): Remove Python 2.4 workaround.
13728 * python/py-inferior.c (buffer_procs): Remove Python 2.4
13729 workaround.
13730 (CHARBUFFERPROC_NAME): Remove.
13731 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13732 Python 2.4 workaround.
13733
13734 2019-02-27 Kevin Buettner <kevinb@redhat.com>
13735
13736 * NEWS: Note minimum Python version.
13737
13738 2019-02-27 Kevin Buettner <kevinb@redhat.com>
13739
13740 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13741 code from these functions. Remove corresponding ifdefs. Use
13742 Py_buffer_up instead of explicit calls to PyBuffer_Release.
13743 Remove gotos and target of gotos.
13744 (infpy_search_memory): Likewise.
13745
13746 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13747
13748 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13749 (hppa_gdbarch_init): Don't register deleted functions with
13750 gdbarch.
13751
13752 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13753
13754 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13755 (h8300_unwind_sp): Delete.
13756 (h8300_dummy_id): Delete.
13757 (h8300_gdbarch_init): Don't register deleted functions with
13758 gdbarch.
13759
13760 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13761
13762 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13763 (ft32_unwind_pc): Delete.
13764 (ft32_unwind_sp): Delete.
13765 (ft32_gdbarch_init): Don't register deleted functions with
13766 gdbarch.
13767
13768 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13769
13770 * gdb/frv-tdep.c (frv_dummy_id): Delete.
13771 (frv_unwind_pc): Delete.
13772 (frv_unwind_sp): Delete.
13773 (frv_gdbarch_init): Don't register deleted functions with
13774 gdbarch.
13775
13776 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13777
13778 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13779 (riscv_unwind_pc): Delete.
13780 (riscv_unwind_sp): Delete.
13781 (riscv_gdbarch_init): Don't register deleted functions with
13782 gdbarch.
13783
13784 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13785
13786 * gdb/csky-tdep.c (csky_dummy_id): Delete.
13787 (csky_unwind_pc): Delete.
13788 (csky_unwind_sp): Delete.
13789 (csky_gdbarch_init): Don't register deleted functions with
13790 gdbarch.
13791
13792 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13793
13794 * gdb/cris-tdep.c (cris_dummy_id): Delete.
13795 (cris_unwind_pc): Delete.
13796 (cris_unwind_sp): Delete.
13797 (cris_gdbarch_init): Don't register deleted functions with
13798 gdbarch.
13799
13800 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13801
13802 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13803 (bfin_unwind_pc): Delete.
13804 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13805
13806 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13807
13808 * gdb/arm-tdep.c (arm_dummy_id): Delete.
13809 (arm_unwind_pc): Delete.
13810 (arm_unwind_sp): Delete.
13811 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13812
13813 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13814
13815 * gdb/arc-tdep.c (arc_dummy_id): Delete.
13816 (arc_unwind_pc): Delete.
13817 (arc_unwind_sp): Delete.
13818 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13819
13820 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13821
13822 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13823 (alpha_unwind_pc): Delete.
13824 (alpha_gdbarch_init): Don't register deleted functions with
13825 gdbarch.
13826
13827 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13828
13829 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13830 (aarch64_unwind_pc): Delete.
13831 (aarch64_unwind_sp): Delete.
13832 (aarch64_gdbarch_init): Don't register deleted functions with
13833 gdbarch.
13834
13835 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13836
13837 * gdbtypes.c (type_align): Don't consider static members when
13838 computing structure alignment.
13839
13840 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13841
13842 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
13843 return 0 for other types.
13844 * arch-utils.c (default_type_align): Always return 0.
13845 * gdbarch.h: Regenerate.
13846 * gdbarch.sh (type_align): Extend comment.
13847 * gdbtypes.c (type_align): Add additional comments, always call
13848 gdbarch_type_align before applying the default rules.
13849 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
13850 generic code will then apply a suitable default.
13851 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
13852 types, return 0 for other types.
13853
13854 2019-02-27 Joel Brobecker <brobecker@adacore.com>
13855
13856 * NEWS: Create a new section for the next release branch.
13857 Rename the section of the current branch, now that it has
13858 been cut.
13859
13860 2019-02-27 Joel Brobecker <brobecker@adacore.com>
13861
13862 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
13863 * version.in: Bump version to 8.3.50.DATE-git.
13864
13865 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
13866
13867 * aix-thread.c (ptid_cmp): Remove unused variable.
13868 (get_signaled_thread): Likewise.
13869 (store_regs_user_thread): Likewise.
13870 (store_regs_kernel_thread): Likewise.
13871 (fetch_regs_kernel_thread): Remove shadowed variable.
13872
13873 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
13874
13875 * features/riscv/32bit-cpu.xml: Add register numbers.
13876 * features/riscv/32bit-fpu.c: Regenerate.
13877 * features/riscv/32bit-fpu.xml: Add register numbers.
13878 * features/riscv/64bit-cpu.xml: Add register numbers.
13879 * features/riscv/64bit-fpu.c: Regenerate.
13880 * features/riscv/64bit-fpu.xml: Add register numbers.
13881
13882 2019-02-26 Kevin Buettner <kevinb@redhat.com>
13883
13884 * NEWS: Mention two argument form of gdb.Value constructor.
13885 * python/py-value.c (convert_buffer_and_type_to_value): New
13886 function.
13887 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
13888 Add support for handling an optional second argument. Call
13889 convert_buffer_and_type_to_value as appropriate.
13890 * python/python-internal.h (Py_buffer_deleter): New struct.
13891 (Py_buffer_up): New typedef.
13892
13893 2019-02-25 John Baldwin <jhb@FreeBSD.org>
13894
13895 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
13896 instead of releasing ownership.
13897
13898 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
13899
13900 * dwarf2read.c (open_and_init_dwp_file): Call
13901 elf_numsections instead of bfd_count_sections to initialize
13902 dwp_file->num_sections.
13903
13904 2019-02-25 Tom Tromey <tromey@adacore.com>
13905
13906 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
13907
13908 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
13909
13910 * gcore.in: Add '--readnever' option when invoking GDB.
13911
13912 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
13913
13914 * MAINTAINERS: Update my email address.
13915
13916 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
13917
13918 * build-id.c (build_id_to_debug_bfd_1): New function.
13919 (build_id_to_debug_bfd): Look for separate debug file in
13920 sysroot.
13921
13922 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
13923
13924 * gdbarch.sh: Update the copyright year range that is placed into
13925 generated files.
13926
13927 2019-02-22 Keith Seitz <keiths@redhat.com>
13928
13929 PR symtab/23853
13930 * linespec.c (create_sals_line_offset): Search for the default
13931 symtab's filename instead of its fullname.
13932
13933 2019-02-21 Alan Hayward <alan.hayward@arm.com>
13934
13935 * NEWS: Update style defaults.
13936
13937 2019-02-21 Alan Hayward <alan.hayward@arm.com>
13938
13939 * main.c (captured_main_1): Disable styling in batch mode.
13940
13941 2019-02-20 Tom Tromey <tom@tromey.com>
13942
13943 * symtab.c (symtab_symbol_info): Fix typos.
13944
13945 2019-02-20 Tom Tromey <tromey@adacore.com>
13946
13947 * findcmd.c (_initialize_mem_search): Use upper case for
13948 metasyntactic variables.
13949
13950 2019-02-20 Alan Hayward <alan.hayward@arm.com>
13951
13952 * aarch64-tdep.c (aarch64_add_reggroups): New function.
13953 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
13954
13955 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
13956
13957 * top.h (source_file_name): Change to std::string.
13958 * top.c (source_file_name): Likewise.
13959 (command_line_input): Adjust.
13960 * cli/cli-script.c (script_from_file): Adjust.
13961
13962 2019-02-19 Tom Tromey <tromey@adacore.com>
13963
13964 * ravenscar-thread.c
13965 (ravenscar_thread_target::update_thread_list): Don't call
13966 ada_build_task_list.
13967 * ada-lang.h (ada_build_task_list): Don't declare.
13968 * ada-tasks.c (struct ada_tasks_inferior_data)
13969 <task_list_valid_p>: Now bool.
13970 (read_known_tasks, ada_task_list_changed)
13971 (ada_tasks_invalidate_inferior_data): Update.
13972 (read_known_tasks_array): Return bool.
13973 (read_known_tasks_list): Likewise.
13974 (read_known_tasks): Return void.
13975 (ada_build_task_list): Now static.
13976
13977 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
13978
13979 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
13980 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
13981
13982 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13983
13984 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
13985 variant for ada_tasks_pspace_data_handle and
13986 ada_tasks_inferior_data_handle.
13987 (ada_tasks_pspace_data_cleanup): New function.
13988 (ada_tasks_inferior_data_cleanup): New function.
13989
13990 2019-02-17 Tom Tromey <tom@tromey.com>
13991
13992 * macrotab.h (macro_source_fullname): Return a std::string.
13993 * macrotab.c (macro_include, check_for_redefinition)
13994 (macro_undef, macro_lookup_definition, foreach_macro)
13995 (foreach_macro_in_scope): Update.
13996 (macro_source_fullname): Return a std::string.
13997 * macrocmd.c (show_pp_source_pos): Update.
13998
13999 2019-02-17 Tom Tromey <tom@tromey.com>
14000
14001 * macrocmd.c (show_pp_source_pos): Style the file names.
14002
14003 2019-02-17 Tom Tromey <tom@tromey.com>
14004
14005 PR tui/24197:
14006 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14007
14008 2019-02-17 Tom Tromey <tom@tromey.com>
14009
14010 * ada-lang.c (user_select_syms): Use filtered printing.
14011 * utils.c (wrap_style): New global.
14012 (desired_style): Remove.
14013 (emit_style_escape): Add stream parameter.
14014 (set_output_style, reset_terminal_style, prompt_for_continue):
14015 Update.
14016 (flush_wrap_buffer): Only flush gdb_stdout.
14017 (wrap_here): Set wrap_style.
14018 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14019 treat escape sequences as a character. Change when wrap buffer is
14020 flushed.
14021 (fputs_styled): Do not set the output style when the default is
14022 requested.
14023 * ui-style.h (struct ui_file_style) <is_default>: New method.
14024 * source.c (print_source_lines_base): Emit escape sequences in one
14025 piece.
14026
14027 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14028
14029 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14030 integers and enumeration types.
14031
14032 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14033
14034 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14035 instead of lookup_symbol_in_language
14036 (do_exact_match): New function.
14037 (ada_get_symbol_name_matcher): Return do_exact_match when
14038 doing a verbatim match.
14039
14040 2019-02-15 Tom Tromey <tromey@adacore.com>
14041
14042 * ravenscar-thread.c (ravenscar_thread_target::resume)
14043 (ravenscar_thread_target::wait): Special case wildcard requests.
14044
14045 2019-02-15 Tom Tromey <tromey@adacore.com>
14046
14047 * ravenscar-thread.c (base_ptid): Remove.
14048 (struct ravenscar_thread_target) <close>: New method.
14049 <m_base_ptid>: New member.
14050 <update_inferior_ptid, active_task, task_is_currently_active,
14051 runtime_initialized>: Declare methods.
14052 <ravenscar_thread_target>: Add constructor.
14053 (ravenscar_thread_target::task_is_currently_active)
14054 (ravenscar_thread_target::update_inferior_ptid)
14055 (ravenscar_runtime_initialized): Rename. Now methods.
14056 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14057 (ravenscar_thread_target::update_thread_list): Update.
14058 (ravenscar_thread_target::active_task): Now method.
14059 (ravenscar_thread_target::store_registers)
14060 (ravenscar_thread_target::prepare_to_store)
14061 (ravenscar_thread_target::prepare_to_store)
14062 (ravenscar_thread_target::mourn_inferior): Update.
14063 (ravenscar_inferior_created): Use "new" to create target.
14064 (ravenscar_thread_target::get_ada_task_ptid): Update.
14065 (_initialize_ravenscar): Don't initialize base_ptid.
14066 (ravenscar_ops): Remove global.
14067
14068 2019-02-15 Tom Tromey <tromey@adacore.com>
14069
14070 * target.h (push_target): Declare new overload.
14071 * target.c (push_target): New overload, taking an rvalue reference.
14072 * remote.c (remote_target::open_1): Use push_target overload.
14073 * corelow.c (core_target_open): Use push_target overload.
14074
14075 2019-02-15 Tom Tromey <tromey@adacore.com>
14076
14077 * ravenscar-thread.c (is_ravenscar_task)
14078 (ravenscar_task_is_currently_active): Return bool.
14079 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14080 (_initialize_ravenscar): Remove "(void)".
14081 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14082 Return bool.
14083
14084 2019-02-15 Tom Tromey <tromey@adacore.com>
14085
14086 * ravenscar-thread.c (ravenscar_runtime_initializer)
14087 (has_ravenscar_runtime, get_running_thread_id)
14088 (ravenscar_thread_target::resume): Fix indentation.
14089
14090 2019-02-15 Tom Tromey <tromey@adacore.com>
14091
14092 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14093 from ravenscar_arch_ops.
14094 (sparc_ravenscar_ops::fetch_registers)
14095 (sparc_ravenscar_ops::store_registers): Now methods.
14096 (sparc_ravenscar_prepare_to_store): Remove.
14097 (sparc_ravenscar_ops): Redefine.
14098 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14099 methods and destructor. Remove members.
14100 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14101 (ravenscar_thread_target::store_registers)
14102 (ravenscar_thread_target::prepare_to_store): Update.
14103 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14104 Remove.
14105 (struct ppc_ravenscar_powerpc_ops): Derive from
14106 ravenscar_arch_ops.
14107 (ppc_ravenscar_powerpc_ops::fetch_registers)
14108 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14109 (ppc_ravenscar_powerpc_ops): Redefine.
14110 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14111 (ppc_ravenscar_e500_ops::fetch_registers)
14112 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14113 (ppc_ravenscar_e500_ops): Redefine.
14114 * aarch64-ravenscar-thread.c
14115 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14116 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14117 (aarch64_ravenscar_fetch_registers)
14118 (aarch64_ravenscar_store_registers): Now methods.
14119 (aarch64_ravenscar_ops): Redefine.
14120
14121 2019-02-15 Tom Tromey <tromey@adacore.com>
14122
14123 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14124 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14125 (ravenscar_thread_target::stopped_by_watchpoint)
14126 (ravenscar_thread_target::stopped_data_address)
14127 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14128
14129 2019-02-15 Tom Tromey <tromey@adacore.com>
14130
14131 * ravenscar-thread.c: Fix some typos.
14132
14133 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14134 Tom Tromey <tromey@adacore.com>
14135
14136 * ada-lang.c (ada_exception_sal): Change addr_string to a
14137 std::string.
14138 (create_ada_exception_catchpoint): Update.
14139
14140 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14141 Tom Tromey <tromey@adacore.com>
14142
14143 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14144 (bp_location_ops): Remove.
14145 (base_breakpoint_allocate_location): Update.
14146 (free_bp_location): Update.
14147 * ada-lang.c (class ada_catchpoint_location)
14148 <ada_catchpoint_location>: Remove ops parameter.
14149 (ada_catchpoint_location_dtor): Remove.
14150 (ada_catchpoint_location_ops): Remove.
14151 (allocate_location_exception): Update.
14152 * breakpoint.h (struct bp_location_ops): Remove.
14153 (class bp_location) <bp_location>: Remove bp_location_ops
14154 parameter.
14155 <~bp_location>: Add destructor.
14156 <ops>: Remove.
14157
14158 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14159 Pedro Alves <palves@redhat.com>
14160
14161 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14162 'PATH_MAX'.
14163
14164 2019-02-14 David Michael <fedora.dm0@gmail.com>
14165 Samuel Thibault <samuel.thibault@gnu.org>
14166 Thomas Schwinge <thomas@codesourcery.com>
14167
14168 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14169 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14170
14171 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14172
14173 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14174 (check_empty): Use "const char *".
14175
14176 * gnu-nat.c (gnu_nat_target::detach): Instead of
14177 'detach_inferior (pid)' call
14178 'detach_inferior (find_inferior_pid (pid))'.
14179
14180 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14181 'nat/fork-inferior.o'.
14182 * gnu-nat.c: #include "nat/fork-inferior.h".
14183
14184 * gnu-nat.c (gnu_nat_target::detach): Instead of
14185 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14186 * gnu-nat.h: #include "inf-child.h".
14187 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14188 'i386_gnu_nat_target::fetch_registers'.
14189 (gnu_store_registers): Rename/move to
14190 'i386_gnu_nat_target::store_registers'.
14191
14192 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14193 * gnu-nat.h (mach_thread_info): New function.
14194 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14195
14196 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14197
14198 2019-02-14 Frederic Konrad <konrad@adacore.com>
14199
14200 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14201
14202 2019-02-14 Joel Brobecker <brobecker@adacore.com>
14203
14204 * windows-nat.c (windows_add_thread): Add new parameter
14205 "main_thread_p" with default value set to false. Update
14206 function documentation as well as all callers.
14207 (windows_delete_thread): Likewise.
14208 (fake_create_process): Update call to windows_add_thread.
14209 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14210 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14211 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14212 call to windows_delete_thread.
14213
14214 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14215
14216 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14217
14218 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14219
14220 * symfile.c (find_separate_debug_file): Use canonical path of
14221 sysroot with child_path instead of gdb_sysroot if it is valid.
14222
14223 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14224
14225 * symfile.c (find_separate_debug_file): Use child_path to
14226 determine if an object file is under a sysroot.
14227
14228 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14229
14230 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14231 unittests/child-path-selftests.c.
14232 * common/pathstuff.c (child_path): New function.
14233 * common/pathstuff.h (child_path): New prototype.
14234 * unittests/child-path-selftests.c: New file.
14235
14236 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14237
14238 * symfile.c (find_separate_debug_file): Look for separate debug
14239 files in debug directories under the sysroot.
14240
14241 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14242
14243 * symtab.h (struct minimal_symbol data_p): New const method.
14244 (struct minimal_symbol text_p): Likewise.
14245 * symtab.c (output_source_filename): Use file name style
14246 to print file name.
14247 (print_symbol_info): Likewise.
14248 (print_msymbol_info): Use address style to print addresses.
14249 Use function name style to print executable text symbols.
14250 (expand_symtab_containing_pc): Use data_p.
14251 (find_pc_sect_compunit_symtab): Likewise.
14252
14253 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14254
14255 * breakpoint.c (describe_other_breakpoints): Use address style
14256 to print addresses.
14257 (say_where): Likewise.
14258
14259 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14260
14261 * ada-typeprint.c (print_func_type): Print function name
14262 style to print function name.
14263 * c-typeprint.c (c_print_type_1): Likewise.
14264
14265 2019-02-11 Alan Hayward <alan.hayward@arm.com>
14266
14267 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14268 for execve.
14269
14270 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14271
14272 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14273 type_stack.
14274
14275 2019-02-10 Joel Brobecker <brobecker@adacore.com>
14276
14277 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14278 TYPE_CODE_REF types.
14279
14280 2019-02-08 Jim Wilson <jimw@sifive.com>
14281
14282 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14283 (riscv_linux_fregset): New.
14284 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14285
14286 2019-02-07 Tom Tromey <tom@tromey.com>
14287
14288 * thread.c (thread_cancel_execution_command): Update.
14289 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14290 methods.
14291 (struct thread_fsm_ops): Remove.
14292 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14293 (thread_fsm_should_stop, thread_fsm_return_value)
14294 (thread_fsm_set_finished, thread_fsm_finished_p)
14295 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14296 Don't declare.
14297 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14298 * infrun.c (clear_proceed_status_thread)
14299 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14300 (print_stop_event): Update.
14301 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14302 Add constructor.
14303 (step_command_fsm_ops): Remove.
14304 (new_step_command_fsm): Remove.
14305 (step_1): Update.
14306 (step_command_fsm::should_stop): Rename from
14307 step_command_fsm_should_stop.
14308 (step_command_fsm::clean_up): Rename from
14309 step_command_fsm_clean_up.
14310 (step_command_fsm::do_async_reply_reason): Rename from
14311 step_command_fsm_async_reply_reason.
14312 (struct until_next_fsm): Inherit from thread_fsm. Add
14313 constructor.
14314 (until_next_fsm_ops): Remove.
14315 (new_until_next_fsm): Remove.
14316 (until_next_fsm::should_stop): Rename from
14317 until_next_fsm_should_stop.
14318 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14319 (until_next_fsm::do_async_reply_reason): Rename from
14320 until_next_fsm_async_reply_reason.
14321 (struct finish_command_fsm): Inherit from thread_fsm. Add
14322 constructor. Change type of breakpoint.
14323 (finish_command_fsm_ops): Remove.
14324 (new_finish_command_fsm): Remove.
14325 (finish_command_fsm::should_stop): Rename from
14326 finish_command_fsm_should_stop.
14327 (finish_command_fsm::clean_up): Rename from
14328 finish_command_fsm_clean_up.
14329 (finish_command_fsm::return_value): Rename from
14330 finish_command_fsm_return_value.
14331 (finish_command_fsm::do_async_reply_reason): Rename from
14332 finish_command_fsm_async_reply_reason.
14333 (finish_command): Update.
14334 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14335 Add constructor.
14336 (call_thread_fsm_ops): Remove.
14337 (call_thread_fsm::call_thread_fsm): Rename from
14338 new_call_thread_fsm.
14339 (call_thread_fsm::should_stop): Rename from
14340 call_thread_fsm_should_stop.
14341 (call_thread_fsm::should_notify_stop): Rename from
14342 call_thread_fsm_should_notify_stop.
14343 (run_inferior_call, call_function_by_hand_dummy): Update.
14344 * cli/cli-interp.c (should_print_stop_to_console): Update.
14345 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14346 Add constructor. Change type of location_breakpoint,
14347 caller_breakpoint.
14348 (until_break_fsm_ops): Remove.
14349 (new_until_break_fsm): Remove.
14350 (until_break_fsm::should_stop): Rename from
14351 until_break_fsm_should_stop.
14352 (until_break_fsm::clean_up): Rename from
14353 until_break_fsm_clean_up.
14354 (until_break_fsm::do_async_reply_reason): Rename from
14355 until_break_fsm_async_reply_reason.
14356 (until_break_command): Update.
14357 * thread-fsm.c: Remove.
14358 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14359
14360 2019-02-07 Tom Tromey <tom@tromey.com>
14361
14362 * yy-remap.h: Add include guard.
14363 * xtensa-tdep.h: Add include guard.
14364 * xcoffread.h: Rename include guard.
14365 * varobj-iter.h: Add include guard.
14366 * tui/tui.h: Rename include guard.
14367 * tui/tui-winsource.h: Rename include guard.
14368 * tui/tui-wingeneral.h: Rename include guard.
14369 * tui/tui-windata.h: Rename include guard.
14370 * tui/tui-win.h: Rename include guard.
14371 * tui/tui-stack.h: Rename include guard.
14372 * tui/tui-source.h: Rename include guard.
14373 * tui/tui-regs.h: Rename include guard.
14374 * tui/tui-out.h: Rename include guard.
14375 * tui/tui-layout.h: Rename include guard.
14376 * tui/tui-io.h: Rename include guard.
14377 * tui/tui-hooks.h: Rename include guard.
14378 * tui/tui-file.h: Rename include guard.
14379 * tui/tui-disasm.h: Rename include guard.
14380 * tui/tui-data.h: Rename include guard.
14381 * tui/tui-command.h: Rename include guard.
14382 * tic6x-tdep.h: Add include guard.
14383 * target/waitstatus.h: Rename include guard.
14384 * target/wait.h: Rename include guard.
14385 * target/target.h: Rename include guard.
14386 * target/resume.h: Rename include guard.
14387 * target-float.h: Rename include guard.
14388 * stabsread.h: Add include guard.
14389 * rs6000-tdep.h: Add include guard.
14390 * riscv-fbsd-tdep.h: Add include guard.
14391 * regformats/regdef.h: Rename include guard.
14392 * record.h: Rename include guard.
14393 * python/python.h: Rename include guard.
14394 * python/python-internal.h: Rename include guard.
14395 * python/py-stopevent.h: Rename include guard.
14396 * python/py-ref.h: Rename include guard.
14397 * python/py-record.h: Rename include guard.
14398 * python/py-record-full.h: Rename include guard.
14399 * python/py-record-btrace.h: Rename include guard.
14400 * python/py-instruction.h: Rename include guard.
14401 * python/py-events.h: Rename include guard.
14402 * python/py-event.h: Rename include guard.
14403 * procfs.h: Add include guard.
14404 * proc-utils.h: Add include guard.
14405 * p-lang.h: Add include guard.
14406 * or1k-tdep.h: Rename include guard.
14407 * observable.h: Rename include guard.
14408 * nto-tdep.h: Rename include guard.
14409 * nat/x86-linux.h: Rename include guard.
14410 * nat/x86-linux-dregs.h: Rename include guard.
14411 * nat/x86-gcc-cpuid.h: Add include guard.
14412 * nat/x86-dregs.h: Rename include guard.
14413 * nat/x86-cpuid.h: Rename include guard.
14414 * nat/ppc-linux.h: Rename include guard.
14415 * nat/mips-linux-watch.h: Rename include guard.
14416 * nat/linux-waitpid.h: Rename include guard.
14417 * nat/linux-ptrace.h: Rename include guard.
14418 * nat/linux-procfs.h: Rename include guard.
14419 * nat/linux-osdata.h: Rename include guard.
14420 * nat/linux-nat.h: Rename include guard.
14421 * nat/linux-namespaces.h: Rename include guard.
14422 * nat/linux-btrace.h: Rename include guard.
14423 * nat/glibc_thread_db.h: Rename include guard.
14424 * nat/gdb_thread_db.h: Rename include guard.
14425 * nat/gdb_ptrace.h: Rename include guard.
14426 * nat/fork-inferior.h: Rename include guard.
14427 * nat/amd64-linux-siginfo.h: Rename include guard.
14428 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14429 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14430 * nat/aarch64-linux.h: Rename include guard.
14431 * nat/aarch64-linux-hw-point.h: Rename include guard.
14432 * mn10300-tdep.h: Add include guard.
14433 * mips-linux-tdep.h: Add include guard.
14434 * mi/mi-parse.h: Rename include guard.
14435 * mi/mi-out.h: Rename include guard.
14436 * mi/mi-main.h: Rename include guard.
14437 * mi/mi-interp.h: Rename include guard.
14438 * mi/mi-getopt.h: Rename include guard.
14439 * mi/mi-console.h: Rename include guard.
14440 * mi/mi-common.h: Rename include guard.
14441 * mi/mi-cmds.h: Rename include guard.
14442 * mi/mi-cmd-break.h: Rename include guard.
14443 * m2-lang.h: Add include guard.
14444 * location.h: Rename include guard.
14445 * linux-record.h: Rename include guard.
14446 * linux-nat.h: Add include guard.
14447 * linux-fork.h: Add include guard.
14448 * i386-darwin-tdep.h: Rename include guard.
14449 * hppa-linux-offsets.h: Add include guard.
14450 * guile/guile.h: Rename include guard.
14451 * guile/guile-internal.h: Rename include guard.
14452 * gnu-nat.h: Rename include guard.
14453 * gdb-stabs.h: Rename include guard.
14454 * frv-tdep.h: Add include guard.
14455 * f-lang.h: Add include guard.
14456 * event-loop.h: Add include guard.
14457 * darwin-nat.h: Rename include guard.
14458 * cp-abi.h: Rename include guard.
14459 * config/sparc/nm-sol2.h: Rename include guard.
14460 * config/nm-nto.h: Rename include guard.
14461 * config/nm-linux.h: Add include guard.
14462 * config/i386/nm-i386gnu.h: Rename include guard.
14463 * config/djgpp/nl_types.h: Rename include guard.
14464 * config/djgpp/langinfo.h: Rename include guard.
14465 * compile/gcc-cp-plugin.h: Add include guard.
14466 * compile/gcc-c-plugin.h: Add include guard.
14467 * compile/compile.h: Rename include guard.
14468 * compile/compile-object-run.h: Rename include guard.
14469 * compile/compile-object-load.h: Rename include guard.
14470 * compile/compile-internal.h: Rename include guard.
14471 * compile/compile-cplus.h: Rename include guard.
14472 * compile/compile-c.h: Rename include guard.
14473 * common/xml-utils.h: Rename include guard.
14474 * common/x86-xstate.h: Rename include guard.
14475 * common/version.h: Rename include guard.
14476 * common/vec.h: Rename include guard.
14477 * common/tdesc.h: Rename include guard.
14478 * common/selftest.h: Rename include guard.
14479 * common/scoped_restore.h: Rename include guard.
14480 * common/scoped_mmap.h: Rename include guard.
14481 * common/scoped_fd.h: Rename include guard.
14482 * common/safe-iterator.h: Rename include guard.
14483 * common/run-time-clock.h: Rename include guard.
14484 * common/refcounted-object.h: Rename include guard.
14485 * common/queue.h: Rename include guard.
14486 * common/ptid.h: Rename include guard.
14487 * common/print-utils.h: Rename include guard.
14488 * common/preprocessor.h: Rename include guard.
14489 * common/pathstuff.h: Rename include guard.
14490 * common/observable.h: Rename include guard.
14491 * common/netstuff.h: Rename include guard.
14492 * common/job-control.h: Rename include guard.
14493 * common/host-defs.h: Rename include guard.
14494 * common/gdb_wait.h: Rename include guard.
14495 * common/gdb_vecs.h: Rename include guard.
14496 * common/gdb_unlinker.h: Rename include guard.
14497 * common/gdb_unique_ptr.h: Rename include guard.
14498 * common/gdb_tilde_expand.h: Rename include guard.
14499 * common/gdb_sys_time.h: Rename include guard.
14500 * common/gdb_string_view.h: Rename include guard.
14501 * common/gdb_splay_tree.h: Rename include guard.
14502 * common/gdb_setjmp.h: Rename include guard.
14503 * common/gdb_ref_ptr.h: Rename include guard.
14504 * common/gdb_optional.h: Rename include guard.
14505 * common/gdb_locale.h: Rename include guard.
14506 * common/gdb_assert.h: Rename include guard.
14507 * common/filtered-iterator.h: Rename include guard.
14508 * common/filestuff.h: Rename include guard.
14509 * common/fileio.h: Rename include guard.
14510 * common/environ.h: Rename include guard.
14511 * common/common-utils.h: Rename include guard.
14512 * common/common-types.h: Rename include guard.
14513 * common/common-regcache.h: Rename include guard.
14514 * common/common-inferior.h: Rename include guard.
14515 * common/common-gdbthread.h: Rename include guard.
14516 * common/common-exceptions.h: Rename include guard.
14517 * common/common-defs.h: Rename include guard.
14518 * common/common-debug.h: Rename include guard.
14519 * common/cleanups.h: Rename include guard.
14520 * common/buffer.h: Rename include guard.
14521 * common/btrace-common.h: Rename include guard.
14522 * common/break-common.h: Rename include guard.
14523 * cli/cli-utils.h: Rename include guard.
14524 * cli/cli-style.h: Rename include guard.
14525 * cli/cli-setshow.h: Rename include guard.
14526 * cli/cli-script.h: Rename include guard.
14527 * cli/cli-interp.h: Rename include guard.
14528 * cli/cli-decode.h: Rename include guard.
14529 * cli/cli-cmds.h: Rename include guard.
14530 * charset-list.h: Add include guard.
14531 * buildsym-legacy.h: Rename include guard.
14532 * bfin-tdep.h: Add include guard.
14533 * ax.h: Rename include guard.
14534 * arm-linux-tdep.h: Add include guard.
14535 * arm-fbsd-tdep.h: Add include guard.
14536 * arch/xtensa.h: Rename include guard.
14537 * arch/tic6x.h: Add include guard.
14538 * arch/i386.h: Add include guard.
14539 * arch/arm.h: Rename include guard.
14540 * arch/arm-linux.h: Rename include guard.
14541 * arch/arm-get-next-pcs.h: Rename include guard.
14542 * arch/amd64.h: Add include guard.
14543 * arch/aarch64-insn.h: Rename include guard.
14544 * arch-utils.h: Rename include guard.
14545 * annotate.h: Add include guard.
14546 * amd64-darwin-tdep.h: Rename include guard.
14547 * aarch64-linux-tdep.h: Add include guard.
14548 * aarch64-fbsd-tdep.h: Add include guard.
14549 * aarch32-linux-nat.h: Add include guard.
14550
14551 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14552
14553 * macrotab.c (macro_define_internal): New function that
14554 factorizes macro_define_object_internal and macro_define_function
14555 code.
14556 (macro_define_object_internal): Use macro_define_internal.
14557 (macro_define_function): Likewise.
14558
14559 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14560
14561 * macrocmd.c (extract_identifier): Return
14562 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14563 callers.
14564
14565 2019-02-06 John Baldwin <jhb@FreeBSD.org>
14566
14567 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14568
14569 2019-02-05 Tom Tromey <tom@tromey.com>
14570
14571 * target.c (target_stack::unpush): Move assertion earlier.
14572
14573 2019-01-30 Tom Tromey <tom@tromey.com>
14574
14575 PR python/23615:
14576 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14577 (gdbpy_parse_and_eval): Likewise.
14578 * python/python-internal.h (gdbpy_allow_threads): New class.
14579
14580 2019-01-28 John Baldwin <jhb@FreeBSD.org>
14581
14582 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14583 (aarch64_fbsd_fpregmap): Move earlier.
14584 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14585 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14586 instead of individual calls to trad_frame_set_reg_addr.
14587 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14588 earlier.
14589 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14590 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14591 instead of individual calls to trad_frame_set_reg_addr.
14592
14593 2019-01-28 Alan Hayward <alan.hayward@arm.com>
14594
14595 * CONTRIBUTE: Replace contribution list with wiki link.
14596
14597 2019-01-25 Tom Tromey <tom@tromey.com>
14598
14599 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14600
14601 2019-01-25 Tom Tromey <tom@tromey.com>
14602
14603 * xtensa-linux-nat.c: Fix common/ includes.
14604 * xml-support.h: Fix common/ includes.
14605 * xml-support.c: Fix common/ includes.
14606 * x86-linux-nat.c: Fix common/ includes.
14607 * windows-nat.c: Fix common/ includes.
14608 * varobj.h: Fix common/ includes.
14609 * varobj.c: Fix common/ includes.
14610 * value.c: Fix common/ includes.
14611 * valops.c: Fix common/ includes.
14612 * utils.c: Fix common/ includes.
14613 * unittests/xml-utils-selftests.c: Fix common/ includes.
14614 * unittests/utils-selftests.c: Fix common/ includes.
14615 * unittests/unpack-selftests.c: Fix common/ includes.
14616 * unittests/tracepoint-selftests.c: Fix common/ includes.
14617 * unittests/style-selftests.c: Fix common/ includes.
14618 * unittests/string_view-selftests.c: Fix common/ includes.
14619 * unittests/scoped_restore-selftests.c: Fix common/ includes.
14620 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14621 * unittests/scoped_fd-selftests.c: Fix common/ includes.
14622 * unittests/rsp-low-selftests.c: Fix common/ includes.
14623 * unittests/parse-connection-spec-selftests.c: Fix common/
14624 includes.
14625 * unittests/optional-selftests.c: Fix common/ includes.
14626 * unittests/offset-type-selftests.c: Fix common/ includes.
14627 * unittests/observable-selftests.c: Fix common/ includes.
14628 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14629 * unittests/memrange-selftests.c: Fix common/ includes.
14630 * unittests/memory-map-selftests.c: Fix common/ includes.
14631 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14632 * unittests/function-view-selftests.c: Fix common/ includes.
14633 * unittests/environ-selftests.c: Fix common/ includes.
14634 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14635 * unittests/common-utils-selftests.c: Fix common/ includes.
14636 * unittests/cli-utils-selftests.c: Fix common/ includes.
14637 * unittests/array-view-selftests.c: Fix common/ includes.
14638 * ui-file.c: Fix common/ includes.
14639 * tui/tui-io.c: Fix common/ includes.
14640 * tracepoint.h: Fix common/ includes.
14641 * tracepoint.c: Fix common/ includes.
14642 * tracefile-tfile.c: Fix common/ includes.
14643 * top.h: Fix common/ includes.
14644 * top.c: Fix common/ includes.
14645 * thread.c: Fix common/ includes.
14646 * target/waitstatus.h: Fix common/ includes.
14647 * target/waitstatus.c: Fix common/ includes.
14648 * target.h: Fix common/ includes.
14649 * target.c: Fix common/ includes.
14650 * target-memory.c: Fix common/ includes.
14651 * target-descriptions.c: Fix common/ includes.
14652 * symtab.h: Fix common/ includes.
14653 * symfile.c: Fix common/ includes.
14654 * stap-probe.c: Fix common/ includes.
14655 * spu-linux-nat.c: Fix common/ includes.
14656 * sparc-nat.c: Fix common/ includes.
14657 * source.c: Fix common/ includes.
14658 * solib.c: Fix common/ includes.
14659 * solib-target.c: Fix common/ includes.
14660 * ser-unix.c: Fix common/ includes.
14661 * ser-tcp.c: Fix common/ includes.
14662 * ser-pipe.c: Fix common/ includes.
14663 * ser-base.c: Fix common/ includes.
14664 * selftest-arch.c: Fix common/ includes.
14665 * s12z-tdep.c: Fix common/ includes.
14666 * rust-exp.y: Fix common/ includes.
14667 * rs6000-aix-tdep.c: Fix common/ includes.
14668 * riscv-tdep.c: Fix common/ includes.
14669 * remote.c: Fix common/ includes.
14670 * remote-notif.h: Fix common/ includes.
14671 * remote-fileio.h: Fix common/ includes.
14672 * remote-fileio.c: Fix common/ includes.
14673 * regcache.h: Fix common/ includes.
14674 * regcache.c: Fix common/ includes.
14675 * record-btrace.c: Fix common/ includes.
14676 * python/python.c: Fix common/ includes.
14677 * python/py-type.c: Fix common/ includes.
14678 * python/py-inferior.c: Fix common/ includes.
14679 * progspace.h: Fix common/ includes.
14680 * producer.c: Fix common/ includes.
14681 * procfs.c: Fix common/ includes.
14682 * proc-api.c: Fix common/ includes.
14683 * printcmd.c: Fix common/ includes.
14684 * ppc-linux-nat.c: Fix common/ includes.
14685 * parser-defs.h: Fix common/ includes.
14686 * osdata.c: Fix common/ includes.
14687 * obsd-nat.c: Fix common/ includes.
14688 * nat/x86-linux.c: Fix common/ includes.
14689 * nat/x86-linux-dregs.c: Fix common/ includes.
14690 * nat/x86-dregs.h: Fix common/ includes.
14691 * nat/x86-dregs.c: Fix common/ includes.
14692 * nat/ppc-linux.c: Fix common/ includes.
14693 * nat/mips-linux-watch.h: Fix common/ includes.
14694 * nat/mips-linux-watch.c: Fix common/ includes.
14695 * nat/linux-waitpid.c: Fix common/ includes.
14696 * nat/linux-ptrace.h: Fix common/ includes.
14697 * nat/linux-ptrace.c: Fix common/ includes.
14698 * nat/linux-procfs.c: Fix common/ includes.
14699 * nat/linux-personality.c: Fix common/ includes.
14700 * nat/linux-osdata.c: Fix common/ includes.
14701 * nat/linux-namespaces.c: Fix common/ includes.
14702 * nat/linux-btrace.h: Fix common/ includes.
14703 * nat/linux-btrace.c: Fix common/ includes.
14704 * nat/fork-inferior.c: Fix common/ includes.
14705 * nat/amd64-linux-siginfo.c: Fix common/ includes.
14706 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14707 * nat/aarch64-linux.c: Fix common/ includes.
14708 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14709 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14710 * namespace.h: Fix common/ includes.
14711 * mips-linux-tdep.c: Fix common/ includes.
14712 * minsyms.c: Fix common/ includes.
14713 * mi/mi-parse.h: Fix common/ includes.
14714 * mi/mi-main.c: Fix common/ includes.
14715 * mi/mi-cmd-env.c: Fix common/ includes.
14716 * memrange.h: Fix common/ includes.
14717 * memattr.c: Fix common/ includes.
14718 * maint.h: Fix common/ includes.
14719 * maint.c: Fix common/ includes.
14720 * main.c: Fix common/ includes.
14721 * machoread.c: Fix common/ includes.
14722 * location.c: Fix common/ includes.
14723 * linux-thread-db.c: Fix common/ includes.
14724 * linux-nat.c: Fix common/ includes.
14725 * linux-fork.c: Fix common/ includes.
14726 * inline-frame.c: Fix common/ includes.
14727 * infrun.c: Fix common/ includes.
14728 * inflow.c: Fix common/ includes.
14729 * inferior.h: Fix common/ includes.
14730 * inferior.c: Fix common/ includes.
14731 * infcmd.c: Fix common/ includes.
14732 * inf-ptrace.c: Fix common/ includes.
14733 * inf-child.c: Fix common/ includes.
14734 * ia64-linux-nat.c: Fix common/ includes.
14735 * i387-tdep.c: Fix common/ includes.
14736 * i386-tdep.c: Fix common/ includes.
14737 * i386-linux-tdep.c: Fix common/ includes.
14738 * i386-linux-nat.c: Fix common/ includes.
14739 * i386-go32-tdep.c: Fix common/ includes.
14740 * i386-fbsd-tdep.c: Fix common/ includes.
14741 * i386-fbsd-nat.c: Fix common/ includes.
14742 * guile/scm-type.c: Fix common/ includes.
14743 * guile/guile.c: Fix common/ includes.
14744 * go32-nat.c: Fix common/ includes.
14745 * gnu-nat.c: Fix common/ includes.
14746 * gdbthread.h: Fix common/ includes.
14747 * gdbarch-selftests.c: Fix common/ includes.
14748 * gdb_usleep.c: Fix common/ includes.
14749 * gdb_select.h: Fix common/ includes.
14750 * gdb_bfd.c: Fix common/ includes.
14751 * gcore.c: Fix common/ includes.
14752 * fork-child.c: Fix common/ includes.
14753 * findvar.c: Fix common/ includes.
14754 * fbsd-nat.c: Fix common/ includes.
14755 * event-top.c: Fix common/ includes.
14756 * event-loop.c: Fix common/ includes.
14757 * dwarf2read.c: Fix common/ includes.
14758 * dwarf2loc.c: Fix common/ includes.
14759 * dwarf2-frame.c: Fix common/ includes.
14760 * dwarf-index-cache.c: Fix common/ includes.
14761 * dtrace-probe.c: Fix common/ includes.
14762 * disasm-selftests.c: Fix common/ includes.
14763 * defs.h: Fix common/ includes.
14764 * csky-tdep.c: Fix common/ includes.
14765 * cp-valprint.c: Fix common/ includes.
14766 * cp-support.h: Fix common/ includes.
14767 * cp-support.c: Fix common/ includes.
14768 * corelow.c: Fix common/ includes.
14769 * completer.h: Fix common/ includes.
14770 * completer.c: Fix common/ includes.
14771 * compile/compile.c: Fix common/ includes.
14772 * compile/compile-loc2c.c: Fix common/ includes.
14773 * compile/compile-cplus-types.c: Fix common/ includes.
14774 * compile/compile-cplus-symbols.c: Fix common/ includes.
14775 * command.h: Fix common/ includes.
14776 * cli/cli-dump.c: Fix common/ includes.
14777 * cli/cli-cmds.c: Fix common/ includes.
14778 * charset.c: Fix common/ includes.
14779 * build-id.c: Fix common/ includes.
14780 * btrace.h: Fix common/ includes.
14781 * btrace.c: Fix common/ includes.
14782 * breakpoint.h: Fix common/ includes.
14783 * breakpoint.c: Fix common/ includes.
14784 * ax.h:
14785 (enum agent_op): Fix common/ includes.
14786 * ax-general.c (struct aop_map): Fix common/ includes.
14787 * ax-gdb.c: Fix common/ includes.
14788 * auxv.c: Fix common/ includes.
14789 * auto-load.c: Fix common/ includes.
14790 * arm-tdep.c: Fix common/ includes.
14791 * arch/riscv.c: Fix common/ includes.
14792 * arch/ppc-linux-common.c: Fix common/ includes.
14793 * arch/i386.c: Fix common/ includes.
14794 * arch/arm.c: Fix common/ includes.
14795 * arch/arm-linux.c: Fix common/ includes.
14796 * arch/arm-get-next-pcs.c: Fix common/ includes.
14797 * arch/amd64.c: Fix common/ includes.
14798 * arch/aarch64.c: Fix common/ includes.
14799 * arch/aarch64-insn.c: Fix common/ includes.
14800 * arch-utils.c: Fix common/ includes.
14801 * amd64-windows-tdep.c: Fix common/ includes.
14802 * amd64-tdep.c: Fix common/ includes.
14803 * amd64-sol2-tdep.c: Fix common/ includes.
14804 * amd64-obsd-tdep.c: Fix common/ includes.
14805 * amd64-nbsd-tdep.c: Fix common/ includes.
14806 * amd64-linux-tdep.c: Fix common/ includes.
14807 * amd64-linux-nat.c: Fix common/ includes.
14808 * amd64-fbsd-tdep.c: Fix common/ includes.
14809 * amd64-fbsd-nat.c: Fix common/ includes.
14810 * amd64-dicos-tdep.c: Fix common/ includes.
14811 * amd64-darwin-tdep.c: Fix common/ includes.
14812 * agent.c: Fix common/ includes.
14813 * ada-lang.h: Fix common/ includes.
14814 * ada-lang.c: Fix common/ includes.
14815 * aarch64-tdep.c: Fix common/ includes.
14816
14817 2019-01-25 Tom Tromey <tom@tromey.com>
14818
14819 * common/create-version.sh: Use common/version.h.
14820
14821 2019-01-24 Pedro Alves <palves@redhat.com>
14822
14823 * infrun.c (signal_stop, signal_print, signal_program)
14824 (signal_catch, signal_pass): Now arrays instead of pointers.
14825 (update_signals_program_target, do_target_resume)
14826 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14827 * linux-nat.c (linux_nat_target::pass_signals)
14828 (linux_nat_target::create_inferior, linux_nat_target::attach):
14829 Adjust.
14830 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14831 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
14832 * procfs.c (procfs_target::pass_signals): Adjust.
14833 * record-full.c (record_full_target::resume): Adjust.
14834 * remote.c (remote_target::pass_signals)
14835 (remote_target::program_signals): Adjust.
14836 * target-debug.h (target_debug_print_signals): Now takes a
14837 gdb::array_view as parameter. Adjust.
14838 * target.h (target_ops) <pass_signals, program_signals>: Replace
14839 pointer and length parameters with gdb::array_view.
14840 (target_pass_signals, target_program_signals): Likewise.
14841 * target-delegates.c: Regenerate.
14842
14843 2019-01-24 Pedro Alves <palves@redhat.com>
14844
14845 * common/forward-scope-exit.h
14846 (forward_scope_exit::forward_scope_exit): Pass arguments to
14847 m_bind_function directly, instead of creating a std::bind and
14848 copying that.
14849
14850 2019-01-24 Alan Hayward <alan.hayward@arm.com>
14851
14852 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14853 for static members.
14854 (pass_in_v_vfp_candidate): Likewise.
14855
14856 2019-01-23 Tom Tromey <tom@tromey.com>
14857 Pedro Alves <palves@redhat.com>
14858
14859 * regcache.c (class regcache_invalidator): Remove.
14860 (regcache::raw_write): Use make_scope_exit.
14861
14862 2019-01-23 Tom Tromey <tom@tromey.com>
14863
14864 * ui-out.h (class ui_out_emit_type): Update comment.
14865
14866 2019-01-23 Tom Tromey <tom@tromey.com>
14867
14868 * infrun.c (fetch_inferior_event): Update comment.
14869
14870 2019-01-23 Tom Tromey <tom@tromey.com>
14871 Pedro Alves <palves@redhat.com>
14872
14873 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
14874 parameter.
14875 (fetch_inferior_event): Use SCOPE_EXIT.
14876
14877
14878 2019-01-23 Tom Tromey <tom@tromey.com>
14879 Pedro Alves <palves@redhat.com>
14880
14881 * infrun.c (disable_thread_events): Delete.
14882 (stop_all_threads): Use SCOPE_EXIT.
14883
14884 2019-01-23 Tom Tromey <tom@tromey.com>
14885 Pedro Alves <palves@redhat.com>
14886
14887 * symfile.c: Include forward-scope-exit.h.
14888 (clear_symtab_users_cleanup): Replace forward declaration with
14889 a FORWARD_SCOPE_EXIT.
14890 (syms_from_objfile_1): Use the forward_scope_exit and
14891 gdb::optional instead of cleanup_function.
14892 (reread_symbols): Use the forward_scope_exit instead of
14893 cleanup_function.
14894 (clear_symtab_users_cleanup): Remove function.
14895
14896 2019-01-23 Tom Tromey <tom@tromey.com>
14897 Pedro Alves <palves@redhat.com>
14898
14899 * linux-nat.c: Include scope-exit.h.
14900 (cleanup_target_stop): Remove.
14901 (linux_nat_target::static_tracepoint_markers_by_strid): Use
14902 SCOPE_EXIT.
14903
14904 2019-01-23 Tom Tromey <tom@tromey.com>
14905 Pedro Alves <palves@redhat.com>
14906
14907 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
14908 (call_function_by_hand_dummy): Use SCOPE_EXIT.
14909
14910 2019-01-23 Tom Tromey <tom@tromey.com>
14911 Andrew Burgess <andrew.burgess@embecosm.com>
14912 Pedro Alves <palves@redhat.com>
14913
14914 * infrun.c (fetch_inferior_event): Use scope_exit.
14915 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
14916 * top.c (execute_command): Use scope_exit.
14917 * breakpoint.c (bpstat_do_actions): Use scope_exit.
14918 * utils.c (do_bpstat_clear_actions_cleanup)
14919 (make_bpstat_clear_actions_cleanup): Remove.
14920
14921 2019-01-23 Tom Tromey <tom@tromey.com>
14922 Pedro Alves <palves@redhat.com>
14923
14924 * infrun.c: Include "common/scope-exit.h"
14925 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
14926 (wait_for_inferior): Use SCOPE_EXIT.
14927 (fetch_inferior_event): Use scope_exit.
14928
14929 2019-01-23 Tom Tromey <tom@tromey.com>
14930 Pedro Alves <palves@redhat.com>
14931
14932 * breakpoint.c (create_breakpoint): Remove cleanup.
14933
14934 2019-01-23 Tom Tromey <tom@tromey.com>
14935 Andrew Burgess <andrew.burgess@embecosm.com>
14936 Pedro Alves <palves@redhat.com>
14937
14938 2019-01-23 Pedro Alves <palves@redhat.com>
14939
14940 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
14941
14942 2019-01-23 Pedro Alves <palves@redhat.com>
14943 Andrew Burgess <andrew.burgess@embecosm.com>
14944
14945 * gdbthread.h: Include "common/forward-scope-exit.h".
14946 (scoped_finish_thread_state): Redefine custom class in terms of
14947 forward_scope_exit.
14948
14949 2019-01-23 Pedro Alves <palves@redhat.com>
14950 Andrew Burgess <andrew.burgess@embecosm.com>
14951
14952 * common/forward-scope-exit.h: New file.
14953
14954 2019-01-23 Pedro Alves <palves@redhat.com>
14955 Andrew Burgess <andrew.burgess@embecosm.com>
14956 Tom Tromey <tom@tromey.com>
14957
14958 * common/scope-exit.h: New file.
14959
14960 2019-01-23 Pedro Alves <palves@redhat.com>
14961
14962 * common/preprocessor.h (ESC): Rename to ...
14963 (ESC_PARENS): ... this.
14964 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
14965 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
14966
14967 2019-01-23 Tom Tromey <tom@tromey.com>
14968
14969 * language.h (class scoped_switch_to_sym_language_if_auto):
14970 Initialize m_lang in both cases.
14971
14972 2019-01-23 Alan Hayward <alan.hayward@arm.com>
14973
14974 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
14975 with XCNEW.
14976
14977 2019-01-22 Tom Tromey <tom@tromey.com>
14978
14979 * corelow.c: Do not include sys/file.h.
14980
14981 2019-01-22 Tom Tromey <tom@tromey.com>
14982
14983 * tui/tui-wingeneral.h: Include gdb_curses.h.
14984
14985 2019-01-22 Tom Tromey <tom@tromey.com>
14986
14987 * source-cache.h (class source_cache) <get_source_lines,
14988 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
14989
14990 2019-01-22 Tom Tromey <tom@tromey.com>
14991
14992 * remote-fileio.h (struct remote_target): Declare.
14993
14994 2019-01-22 Tom Tromey <tom@tromey.com>
14995
14996 * python/py-arch.c: Do not include py-ref.h.
14997 * python/py-bpevent.c: Do not include py-ref.h.
14998 * python/py-cmd.c: Do not include py-ref.h.
14999 * python/py-continueevent.c: Do not include py-ref.h.
15000 * python/py-event.h: Do not include py-ref.h.
15001 * python/py-evtregistry.c: Do not include py-ref.h.
15002 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15003 * python/py-frame.c: Do not include py-ref.h.
15004 * python/py-framefilter.c: Do not include py-ref.h.
15005 * python/py-function.c: Do not include py-ref.h.
15006 * python/py-infevents.c: Do not include py-ref.h.
15007 * python/py-linetable.c: Do not include py-ref.h.
15008 * python/py-objfile.c: Do not include py-ref.h.
15009 * python/py-param.c: Do not include py-ref.h.
15010 * python/py-prettyprint.c: Do not include py-ref.h.
15011 * python/py-progspace.c: Do not include py-ref.h.
15012 * python/py-symbol.c: Do not include py-ref.h.
15013 * python/py-symtab.c: Do not include py-ref.h.
15014 * python/py-type.c: Do not include py-ref.h.
15015 * python/py-unwind.c: Do not include py-ref.h.
15016 * python/py-utils.c: Do not include py-ref.h.
15017 * python/py-value.c: Do not include py-ref.h.
15018 * python/py-varobj.c: Do not include py-ref.h.
15019 * python/py-xmethods.c: Do not include py-ref.h.
15020 * python/python.c: Do not include py-ref.h.
15021 * varobj.c: Do not include py-ref.h.
15022
15023 2019-01-22 Tom Tromey <tom@tromey.com>
15024
15025 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15026 keyword for bcache.
15027
15028 2019-01-22 Tom Tromey <tom@tromey.com>
15029
15030 * compile/compile-cplus-types.c: Remove a comment by #include.
15031
15032 2019-01-22 Tom Tromey <tom@tromey.com>
15033
15034 * compile/gcc-c-plugin.h: Include compile-internal.h.
15035
15036 2019-01-22 Tom Tromey <tom@tromey.com>
15037
15038 * stabsread.c (EXTERN): Do not define.
15039 (symnum, next_symbol_text_func, processing_gcc_compilation)
15040 (within_function, global_sym_chain, global_stabs)
15041 (previous_stab_code, this_object_header_files)
15042 (n_this_object_header_files)
15043 (n_allocated_this_object_header_files): Define.
15044 * stabsread.h (EXTERN): Never define. Use "extern".
15045
15046 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15047
15048 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15049 history_value.
15050
15051 2019-01-21 Tom Tromey <tom@tromey.com>
15052
15053 * ui-out.c: Fix includes.
15054 * tui/tui-source.c: Fix includes.
15055 * target.c: Fix includes.
15056 * remote.c: Fix includes.
15057 * regcache.c: Fix includes.
15058 * python/py-block.c: Fix includes.
15059 * printcmd.c: Fix includes.
15060 * or1k-tdep.c: Fix includes.
15061 * mi/mi-main.c: Fix includes.
15062 * m32r-tdep.c: Fix includes.
15063 * csky-tdep.c: Fix includes.
15064 * compile/compile-cplus-types.c: Fix includes.
15065 * cli/cli-interp.c: Fix includes.
15066
15067 2019-01-21 Alan Hayward <alan.hayward@arm.com>
15068
15069 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15070 for padding.
15071
15072 2019-01-16 Tom Tromey <tom@tromey.com>
15073
15074 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15075 earlier.
15076 (struct objfile) <msymbols_range>: Move from top level.
15077 <msymbols>: New method.
15078 (class objfile_msymbols): Remove.
15079 * symtab.c (default_collect_symbol_completion_matches_break_on):
15080 Update.
15081 * symmisc.c (dump_msymbols): Update.
15082 * stabsread.c (scan_file_globals): Update.
15083 * objc-lang.c (info_selectors_command, info_classes_command)
15084 (find_methods): Update.
15085 * minsyms.c (find_solib_trampoline_target): Update.
15086 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15087 * coffread.c (coff_symfile_read): Update.
15088 * ada-lang.c (ada_lookup_simple_minsym)
15089 (ada_collect_symbol_completion_matches): Update.
15090
15091 2019-01-16 Tom Tromey <tom@tromey.com>
15092
15093 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15094 type. Remove no-argument constructor.
15095 <iterator::operator++>: Simplify.
15096 <begin>: Update.
15097 <end>: Use minimal_symbol_count.
15098
15099 2019-01-16 Tom Tromey <tom@tromey.com>
15100
15101 * objfiles.h (struct objfile) <psymtabs>: New method.
15102 (class objfile_psymtabs): Remove.
15103 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15104 typedef.
15105 <range>: New method.
15106 (require_partial_symbols): Change return type.
15107 * psymtab.c (require_partial_symbols)
15108 (psym_expand_symtabs_matching): Update.
15109 * mdebugread.c (parse_partial_symbols): Update.
15110 * dbxread.c (dbx_end_psymtab): Update.
15111
15112 2019-01-15 Tom Tromey <tom@tromey.com>
15113
15114 * symtab.c (lookup_objfile_from_block)
15115 (lookup_symbol_in_objfile_symtabs)
15116 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15117 (find_line_symtab, info_sources_command)
15118 (default_collect_symbol_completion_matches_break_on)
15119 (make_source_files_completion_list): Update.
15120 * symmisc.c (print_objfile_statistics, dump_objfile)
15121 (maintenance_print_symbols, maintenance_info_symtabs)
15122 (maintenance_check_symtabs, maintenance_info_line_tables):
15123 Update.
15124 * source.c (select_source_symtab)
15125 (forget_cached_source_info_for_objfile): Update.
15126 * objfiles.h (class objfile_compunits): Remove.
15127 (struct objfile) <compunits_range>: New typedef.
15128 (compunits): New method.
15129 * objfiles.c (objfile_relocate1): Update.
15130 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15131 * maint.c (count_symtabs_and_blocks): Update.
15132 * linespec.c (iterate_over_all_matching_symtabs): Update.
15133 * cp-support.c (add_symbol_overload_list_qualified): Update.
15134 * coffread.c (coff_symtab_read): Update.
15135 * ada-lang.c (add_nonlocal_symbols)
15136 (ada_collect_symbol_completion_matches)
15137 (ada_add_global_exceptions): Update.
15138
15139 2019-01-15 Tom Tromey <tom@tromey.com>
15140
15141 * progspace.h (program_space) <objfiles_safe_range>: New
15142 typedef.
15143 <objfiles_safe>: New method.
15144 * objfiles.h (class all_objfiles_safe): Remove.
15145 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15146 * jit.c (jit_inferior_exit_hook): Update.
15147
15148 2019-01-17 Tom Tromey <tom@tromey.com>
15149
15150 * progspace.h (program_space) <objfiles_range>: New typedef.
15151 <objfiles>: New method.
15152 <objfiles_head>: Rename from objfiles.
15153 (object_files): Update.
15154 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15155 * guile/scm-pretty-print.c
15156 (ppscm_find_pretty_printer_from_objfiles): Update.
15157 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15158 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15159 Update.
15160 * python/py-progspace.c (pspy_get_objfiles): Update.
15161 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15162 Update.
15163 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15164 (objfpy_lookup_objfile_by_build_id): Update.
15165 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15166 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15167 Update.
15168 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15169 (expand_symtab_containing_pc, lookup_objfile_from_block)
15170 (lookup_static_symbol, basic_lookup_transparent_type)
15171 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15172 (find_line_symtab, info_sources_command)
15173 (default_collect_symbol_completion_matches_break_on)
15174 (make_source_files_completion_list, find_main_name): Update.
15175 * symmisc.c (print_symbol_bcache_statistics)
15176 (print_objfile_statistics, maintenance_print_symbols)
15177 (maintenance_print_msymbols, maintenance_print_objfiles)
15178 (maintenance_info_symtabs, maintenance_check_symtabs)
15179 (maintenance_expand_symtabs, maintenance_info_line_tables):
15180 Update.
15181 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15182 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15183 (map_overlay_command, unmap_overlay_command)
15184 (simple_overlay_update, expand_symtabs_matching)
15185 (map_symbol_filenames): Update.
15186 * symfile-debug.c (set_debug_symfile): Update.
15187 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15188 Update.
15189 * source.c (select_source_symtab, forget_cached_source_info):
15190 Update.
15191 * solib.c (solib_read_symbols): Update.
15192 * solib-spu.c (append_ocl_sos): Update.
15193 * psymtab.c (maintenance_print_psymbols)
15194 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15195 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15196 * printcmd.c (info_symbol_command): Update.
15197 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15198 Update.
15199 * objfiles.h (class all_objfiles): Remove.
15200 * objfiles.c (have_partial_symbols, have_full_symbols)
15201 (have_minimal_symbols, qsort_cmp, update_section_map)
15202 (shared_objfile_contains_address_p)
15203 (default_iterate_over_objfiles_in_search_order): Update.
15204 * objc-lang.c (info_selectors_command, info_classes_command)
15205 (find_methods): Update.
15206 * minsyms.c (find_solib_trampoline_target): Update.
15207 * maint.c (maintenance_info_sections)
15208 (maintenance_translate_address, count_symtabs_and_blocks):
15209 Update.
15210 * main.c (captured_main_1): Update.
15211 * linux-thread-db.c (try_thread_db_load_from_pdir)
15212 (has_libpthread): Update.
15213 * linespec.c (iterate_over_all_matching_symtabs)
15214 (search_minsyms_for_name): Update.
15215 * jit.c (jit_find_objf_with_entry_addr): Update.
15216 * hppa-tdep.c (find_unwind_entry)
15217 (hppa_lookup_stub_minimal_symbol): Update.
15218 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15219 Update.
15220 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15221 (elf_gnu_ifunc_resolve_by_got): Update.
15222 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15223 * dwarf-index-write.c (save_gdb_index_command): Update.
15224 * cp-support.c (add_symbol_overload_list_qualified): Update.
15225 * breakpoint.c (create_overlay_event_breakpoint)
15226 (create_longjmp_master_breakpoint)
15227 (create_std_terminate_master_breakpoint)
15228 (create_exception_master_breakpoint): Update.
15229 * blockframe.c (find_pc_partial_function): Update.
15230 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15231 (ada_collect_symbol_completion_matches)
15232 (ada_add_global_exceptions): Update.
15233
15234 2019-01-17 Tom Tromey <tom@tromey.com>
15235
15236 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15237 declare VEC.
15238 (solib_target_parse_libraries): Change return type.
15239 (library_list_start_segment, library_list_start_section)
15240 (library_list_end_library, library_list_start_library); Update.
15241 (solib_target_free_library_list): Remove.
15242 (solib_target_parse_libraries): Remove cleanup. Change return
15243 type.
15244 (solib_target_current_sos): Update.
15245
15246 2019-01-17 Tom Tromey <tromey@bapiya>
15247
15248 * valprint.c: Replace "the the" with "the".
15249 * symtab.c: Replace "the the" with "the".
15250 * solib.c: Replace "the the" with "the".
15251 * solib-dsbt.c: Replace "the the" with "the".
15252 * linespec.c: Replace "the the" with "the".
15253 * dwarf2loc.h: Replace "the the" with "the".
15254 * amd64-windows-tdep.c: Replace "the the" with "the".
15255 * aarch64-tdep.c: Replace "the the" with "the".
15256
15257 2019-01-16 Keith Seitz <keiths@redhat.com>
15258
15259 PR gdb/23773
15260 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15261 <builder>: Rename to ..
15262 <m_builder>: ... this and make private.
15263 (dwarf2_cu::get_builder): New method. Change all users of
15264 `builder' to use this method.
15265 (dwarf2_start_symtab): Move to ...
15266 (dwarf2_cu::start_symtab): ... here. Update all callers
15267 (setup_type_unit_groups): Move to ...
15268 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15269 callers.
15270 (dwarf2_cu::reset_builder): New method.
15271 (process_full_compunit, process_full_type_unit): Use
15272 dwarf2_cu::reset_builder.
15273 (follow_die_offset): Record the ancestor CU if it is different
15274 from the followed DIE's CU.
15275 (follow_die_sig_1): Likewise.
15276
15277 2019-01-15 Tom Tromey <tom@tromey.com>
15278
15279 * remote.c (class remote_state) <buf>: Now a char_vector.
15280 <buf_size>: Remove.
15281 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15282 parameter.
15283 (remote_target::getpkt_or_notif_sane_1)
15284 (remote_target::getpkt_sane)
15285 (remote_target::getpkt_or_notif_sane): Likewise.
15286 (class remote_target) <putpkt>: New overload.
15287 (remote_target::read_frame): Change type of "buf_p". Remove
15288 sizeof_p parameter.
15289 (packet_ok): New overload.
15290 (packet_check_result): New overload.
15291 Update all uses.
15292
15293 2019-01-14 Tom Tromey <tom@tromey.com>
15294
15295 * remote-notif.c (handle_notification, remote_notif_ack)
15296 (remote_notif_parse): Make "buf" const.
15297 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15298 const.
15299 (remote_notif_parse, remote_notif_ack, handle_notification):
15300 Likewise.
15301 * remote.c (remote_notif_stop_parse): Make "buf" const.
15302 (remote_target::remote_parse_stop_reply): Make "buf" const.
15303 (remote_notif_stop_ack): Make "buf" const.
15304
15305 2019-01-14 Tom Tromey <tom@tromey.com>
15306
15307 * remote.c (remote_console_output): Make parameter const.
15308
15309 2019-01-14 Tom Tromey <tom@tromey.com>
15310
15311 * target-debug.h (target_debug_print_signals): Constify.
15312 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15313 * procfs.c (procfs_target::pass_signals): Update.
15314 * linux-nat.c (linux_nat_target::pass_signals): Update.
15315 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15316 * target-delegates.c: Rebuild.
15317 * remote.c (remote_target::program_signals): Update.
15318 (remote_target::pass_signals): Update.
15319 * target.c (target_pass_signals): Constify argument.
15320 (target_program_signals): Likewise.
15321 * target.h (struct target_ops) <pass_signals, program_signals>:
15322 Constify argument.
15323 (target_pass_signals, target_program_signals): Constify argument.
15324
15325 2019-01-14 Tom Tromey <tom@tromey.com>
15326
15327 PR tui/28819:
15328 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15329
15330 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15331
15332 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15333 field.
15334 * rs6000-tdep.c: Include reggroups.h.
15335 (IS_V_ALIAS_PSEUDOREG): Define.
15336 (rs6000_register_name): Return names for the "vX" aliases.
15337 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15338 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15339 aliases. Call default_register_reggroup_p for all other
15340 pseudo-registers.
15341 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15342 New functions.
15343 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15344 Handle "vX" aliases.
15345 (v_alias_pseudo_register_collect): New function.
15346 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15347 (rs6000_gdbarch_init): Initialize "vX" aliases as
15348 pseudo-registers. Restore registration of
15349 rs6000_pseudo_register_reggroup_p with
15350 set_tdesc_pseudo_register_reggroup_p.
15351
15352 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15353
15354 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15355 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15356 set_gdbarch_num_pseudo_regs.
15357
15358 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15359
15360 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15361 Remove arg prefixname, add do_set and do_show.
15362 Add member functions set_list and show_list.
15363 * cli/cli-style.c (class cli_style_option): Update accordingly.
15364 (style_set_list): Move to file scope.
15365 (style_show_list): Likewise.
15366 (set_style): Call help_list.
15367 (show_style): Call cmd_show_list.
15368 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15369 Update to use the new macro.
15370
15371 2019-10-12 Joel Brobecker <brobecker@adacore.com>
15372
15373 * ada-lang.c (_initialize_ada_language): Expand the help text
15374 for the "catch exception" command.
15375
15376 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15377
15378 * symtab.c (matching_obj_sections): Initialize obj,
15379 declare it closer to its usage.
15380
15381 2019-01-10 Tom Tromey <tom@tromey.com>
15382
15383 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15384 (basic_inf_threads_range): Remove.
15385 (inf_threads_range, inf_non_exited_threads_range)
15386 (safe_inf_threads_range): Use next_adapter.
15387
15388 2019-01-10 Keith Seitz <keiths@redhat.com>
15389
15390 PR gdb/23712
15391 PR symtab/23010
15392 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15393 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15394
15395 2019-01-10 Keith Seitz <keiths@redhat.com>
15396
15397 PR gdb/23712
15398 PR symtab/23010
15399 * dictionary.c (pending_to_vector): Remove.
15400 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15401 Remove _1 suffix, replacing functions of the same name. Update
15402 all callers.
15403 (dict_create_hashed, dict_create_hashed_expandable)
15404 (dict_create_linear, dict_create_linear_expandable, dict_free)
15405 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15406 Make functions static.
15407
15408 2019-01-10 Keith Seitz <keiths@redhat.com>
15409
15410 PR gdb/23712
15411 PR symtab/23010
15412 * dictionary.h (struct dictionary): Replace declaration with
15413 multidictionary.
15414 (dict_create_hashed, dict_create_hashed_expandable)
15415 (dict_create_linear, dict_create_linear_expandable)
15416 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15417 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15418 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15419 taking multidictionary argument.
15420 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15421 * block.h (struct block) <dict>: Change to multidictionary
15422 and rename `multidict'.
15423 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15424 symmisc.c: Update all dictionary references to multidictionary.
15425
15426 2019-01-10 Keith Seitz <keiths@redhat.com>
15427
15428 PR gdb/23712
15429 PR symtab/23010
15430 * dictionary.c: Include unordered_map.
15431 (pending_to_vector): New function.
15432 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15433 Rewrite the non-"_1" functions to take vector instead
15434 of linked list.
15435 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15436 "new" _1 versions of the same name.
15437 (multidictionary): Define.
15438 (std::hash<enum language): New definition.
15439 (collate_pending_symbols_by_language, mdict_create_hashed)
15440 (mdict_create_hashed_expandable, mdict_create_linear)
15441 (mdict_create_linear_expandable, mdict_free)
15442 (find_language_dictionary, create_new_language_dictionary)
15443 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15444 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15445 (mdict_size, mdict_empty): New functions.
15446 * dictionary.h (mdict_iterator): Define.
15447
15448 2019-01-10 Pedro Alves <palves@redhat.com>
15449
15450 * breakpoint.c (read_uploaded_action)
15451 (create_tracepoint_from_upload): Adjust to use
15452 gdb::unique_xmalloc_ptr.
15453 * ctf.c (ctf_write_uploaded_tp):
15454 (SET_ARRAY_FIELD): Use emplace_back.
15455 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15456 * tracefile-tfile.c (tfile_write_uploaded_tp):
15457 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15458 gdb::unique_xmalloc_ptr.
15459 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15460 at_string, cond_string, cmd_strings>: Replace char pointers
15461 with gdb::unique_xmalloc_ptr.
15462
15463 2019-01-10 Pedro Alves <palves@redhat.com>
15464
15465 * solib-target.c (library_list_start_library): Don't xstrdup name.
15466
15467 2019-01-10 Pedro Alves <palves@redhat.com>
15468
15469 * mdebugread.c (parse_partial_symbols): Use
15470 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15471
15472 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15473
15474 * linux-fork.c (scoped_switch_fork_info)
15475 <~scoped_switch_fork_info>: Fix incorrect variable name.
15476
15477 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15478
15479 * linux-fork.c (scoped_switch_fork_info)
15480 <scoped_switch_fork_info>: Make explicit.
15481 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15482
15483 2019-01-10 Tom Tromey <tom@tromey.com>
15484
15485 * objfiles.h (objfile::reset_psymtabs): Update.
15486 * objfiles.c (objfile::objfile): Update.
15487 * psymtab.h (psymtab_storage::obstack): Update.
15488 (psymtab_storage::m_obstack): Use gdb::optional.
15489 (class psymtab_storage): Update comment. Remove objfile
15490 parameter.
15491 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15492
15493 2019-01-10 Tom Tromey <tom@tromey.com>
15494
15495 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15496 <free_psymtabs>: Now private.
15497 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15498 (allocate_psymtab): Use new method.
15499
15500 2019-01-10 Tom Tromey <tom@tromey.com>
15501
15502 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15503 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15504 * mdebugread.c (parse_partial_symbols): Use
15505 allocate_dependencies.
15506 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15507 allocate_dependencies.
15508 (process_psymtab_comp_unit_reader)
15509 (build_type_psymtab_dependencies): Likewise.
15510 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15511
15512 2019-01-10 Tom Tromey <tom@tromey.com>
15513
15514 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15515 PSYMBOL_SET_LANGUAGE.
15516 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15517
15518 2019-01-10 Tom Tromey <tom@tromey.com>
15519
15520 * psymtab.h (psymtab_storage::obstack): New method.
15521 <m_obstack>: Rename from obstack; now private.
15522 * psymtab.c (psymtab_storage): Update.
15523 * dwarf2read.c (create_addrmap_from_index)
15524 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15525 Update.
15526
15527 2019-01-10 Tom Tromey <tom@tromey.com>
15528
15529 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15530 * objfiles.h (objfile::reset_psymtabs): New method.
15531
15532 2019-01-10 Tom Tromey <tom@tromey.com>
15533
15534 * symmisc.c (print_symbol_bcache_statistics): Update.
15535 (print_objfile_statistics): Update.
15536 * symfile.c (reread_symbols): Update.
15537 * psymtab.h (class psymtab_storage): New.
15538 * psymtab.c (psymtab_storage): New constructor.
15539 (~psymtab_storage): New destructor.
15540 (require_partial_symbols): Update.
15541 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15542 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15543 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15544 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15545 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15546 (start_psymtab_common, end_psymtab_common)
15547 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15548 (allocate_psymtab): Update.
15549 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15550 Update.
15551 (dump_psymtab_addrmap, maintenance_print_psymbols)
15552 (maintenance_check_psymtabs): Update.
15553 (class objfile_psymtabs): Move to objfiles.h.
15554 * psympriv.h (discard_psymtab): Now inline.
15555 (psymtab_discarder::psymtab_discarder): Update.
15556 (psymtab_discarder::~psymtab_discarder): Update.
15557 (ALL_OBJFILE_PSYMTABS): Rewrite.
15558 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15559 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15560 Remove fields.
15561 <partial_symtabs>: New field.
15562 (class objfile_psymtabs): Move from psymtab.h. Update.
15563 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15564 psymbol_cache.
15565 (objfile::~objfile): Don't destroy psymbol_cache.
15566 * mdebugread.c (parse_partial_symbols): Update.
15567 * dwarf2read.c (create_addrmap_from_index)
15568 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15569 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15570 (add_partial_subprogram, dwarf2_ranges_read): Update.
15571 * dwarf-index-write.c (write_address_map)
15572 (write_one_signatured_type, recursively_write_psymbols)
15573 (class debug_names, class debug_names, write_psymtabs_to_index):
15574 Update.
15575
15576 2019-01-10 Tom Tromey <tom@tromey.com>
15577
15578 * symtab.h (SYMBOL_SET_NAMES): Update.
15579 (symbol_set_names): Update.
15580 (MSYMBOL_SET_NAMES): Update.
15581 * symtab.c (symbol_set_names): Change argument to be an
15582 objfile_per_bfd_storage.
15583 * psymtab.c (add_psymbol_to_bcache): Update.
15584 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15585
15586 2019-01-10 Tom Tromey <tom@tromey.com>
15587
15588 * symtab.c (create_demangled_names_hash): Change argument to be an
15589 objfile_per_bfd_storage.
15590 (symbol_set_names): Update.
15591
15592 2019-01-10 Tom Tromey <tom@tromey.com>
15593
15594 * xcoffread.c (xcoff_initial_scan): Unconditionally call
15595 init_psymbol_list.
15596 * psymtab.c (init_psymbol_list): Do nothing if already called.
15597 * psympriv.h (init_psymbol_list): Add comment.
15598 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15599 init_psymbol_list.
15600 * dbxread.c (dbx_symfile_read): Unconditionally call
15601 init_psymbol_list.
15602
15603 2019-01-10 Tom Tromey <tom@tromey.com>
15604
15605 * xcoffread.c (scan_xcoff_symtab): Update.
15606 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15607 "where".
15608 * mdebugread.c (parse_partial_symbols)
15609 (handle_psymbol_enumerators): Update.
15610 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15611 * dbxread.c (read_dbx_symtab): Update.
15612 * psympriv.h (psymbol_placement): New enum.
15613 (add_psymbol_to_list): Update.
15614
15615 2019-01-10 Tom Tromey <tom@tromey.com>
15616
15617 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15618 static_psymbols parameters.
15619 (scan_xcoff_symtab): Update.
15620 * psymtab.c (start_psymtab_common): Remove global_psymbols and
15621 static_psymbols parameters.
15622 * psympriv.h (start_psymtab_common): Update.
15623 * mdebugread.c (parse_partial_symbols): Update.
15624 * dwarf2read.c (create_partial_symtab): Update.
15625 * dbxread.c (read_dbx_symtab): Update.
15626 (start_psymtab): Remove global_psymbols and static_psymbols
15627 parameters.
15628
15629 2019-01-10 Tom Tromey <tom@tromey.com>
15630
15631 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15632 * psymtab.c (allocate_psymtab): Add comment.
15633 * psympriv.h (allocate_psymtab): Add comment.
15634 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15635 initializations.
15636 * dbxread.c (dbx_end_psymtab): Remove some initializations.
15637
15638 2019-01-10 Tom Tromey <tom@tromey.com>
15639
15640 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15641 Don't declare.
15642 * mipsread.c: Include mdebugread.h.
15643 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15644 Declare.
15645 * elfread.c: Include mdebugread.h.
15646
15647 2019-01-09 Tom Tromey <tom@tromey.com>
15648
15649 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15650 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15651 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15652 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15653 (psym_lookup_symbol, psym_find_last_source_symtab)
15654 (psym_forget_cached_source_info, psym_print_stats)
15655 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15656 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15657 (psym_map_matching_symbols, psym_expand_symtabs_matching)
15658 (psym_find_compunit_symtab_by_address)
15659 (maintenance_print_psymbols, maintenance_info_psymtabs)
15660 (maintenance_check_psymtabs): Use ranged for.
15661 * psymtab.h (class objfile_psymtabs): New.
15662 (require_partial_symbols): Return objfile_psymtabs.
15663 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15664
15665 2019-01-09 Tom Tromey <tom@tromey.com>
15666
15667 * symfile.c (overlay_invalidate_all, find_pc_overlay)
15668 (find_pc_mapped_section, list_overlays_command)
15669 (map_overlay_command, unmap_overlay_command)
15670 (simple_overlay_update): Use all_objfiles.
15671 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15672 * printcmd.c (info_symbol_command): Use all_objfiles.
15673 * objfiles.h (ALL_OBJSECTIONS): Remove.
15674 * maint.c (maintenance_translate_address): Use all_objfiles.
15675 * gcore.c (gcore_create_callback): Use all_objfiles.
15676 (objfile_find_memory_regions): Likewise.
15677
15678 2019-01-09 Tom Tromey <tom@tromey.com>
15679
15680 * symtab.c (find_line_symtab, info_sources_command)
15681 (make_source_files_completion_list): Use objfile_compunits.
15682 * source.c (select_source_symtab): Use objfile_compunits.
15683 * objfiles.h (struct objfile): Update comment.
15684 (ALL_OBJFILES): Remove.
15685 (ALL_FILETABS): Remove.
15686 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15687 objfile_compunits.
15688
15689 2019-01-09 Tom Tromey <tom@tromey.com>
15690
15691 * symmisc.c (print_objfile_statistics, dump_objfile)
15692 (maintenance_print_symbols): Use compunit_filetabs.
15693 * source.c (forget_cached_source_info_for_objfile): Use
15694 compunit_filetabs.
15695 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15696 (ALL_FILETABS): Use compunit_filetabs.
15697 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15698 * coffread.c (coff_symtab_read): Use compunit_filetabs.
15699
15700 2019-01-09 Tom Tromey <tom@tromey.com>
15701
15702 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15703 (compunit_filetabs): New.
15704 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15705 compunit_filetabs.
15706 (info_sources_command, make_source_files_completion_list): Remove
15707 declaration.
15708 * symmisc.c (print_objfile_statistics, dump_objfile)
15709 (maintenance_print_symbols): Remove declaration.
15710 (maintenance_info_symtabs): Use compunit_filetabs.
15711 (maintenance_info_line_tables): Likewise.
15712 * source.c (select_source_symtab): Change local variable name.
15713 (forget_cached_source_info_for_objfile): Remove declaration.
15714 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15715 * objfiles.c (objfile_relocate1): Remove declaration.
15716 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15717 declaration.
15718 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15719 * coffread.c (coff_symtab_read): Remove declaration.
15720 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15721 compunit_filetabs.
15722
15723 2019-01-09 Tom Tromey <tom@tromey.com>
15724
15725 * symtab.c (lookup_objfile_from_block)
15726 (find_pc_sect_compunit_symtab, search_symbols)
15727 (default_collect_symbol_completion_matches_break_on): Use
15728 objfile_compunits.
15729 * objfiles.h (ALL_COMPUNITS): Remove.
15730 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15731 * cp-support.c (add_symbol_overload_list_qualified): Use
15732 objfile_compunits.
15733 * ada-lang.c (ada_collect_symbol_completion_matches)
15734 (ada_add_global_exceptions): Use objfile_compunits.
15735
15736 2019-01-09 Tom Tromey <tom@tromey.com>
15737
15738 * source.c (select_source_symtab)
15739 (forget_cached_source_info_for_objfile): Remove declaration.
15740 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15741 declaration.
15742 * maint.c (count_symtabs_and_blocks): Remove declaration.
15743 * cp-support.c (add_symbol_overload_list_qualified): Remove
15744 declaration.
15745 * coffread.c (coff_symtab_read): Remove declaration.
15746 * symtab.c (lookup_symbol_in_objfile_symtabs)
15747 (basic_lookup_transparent_type_1): Use objfile_compunits.
15748 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15749 (info_sources_command, search_symbols)
15750 (default_collect_symbol_completion_matches_break_on)
15751 (make_source_files_completion_list): Remove declaration.
15752 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15753 (ada_collect_symbol_completion_matches)
15754 (ada_add_global_exceptions): Remove declaration.
15755 * linespec.c (iterate_over_all_matching_symtabs): Use
15756 objfile_compunits.
15757 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15758 (class objfile_compunits): New.
15759 (ALL_COMPUNITS): Use objfile_compunits.
15760 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15761 (maintenance_check_symtabs, maintenance_info_line_tables): Use
15762 objfile_compunits.
15763 * objfiles.c (objfile_relocate1): Use objfile_compunits.
15764
15765 2019-01-09 Tom Tromey <tom@tromey.com>
15766
15767 * symtab.c (search_symbols)
15768 (default_collect_symbol_completion_matches_break_on): Use
15769 objfile_msymbols.
15770 * ada-lang.c (ada_lookup_simple_minsym)
15771 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15772 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15773 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15774 objfile_msymbols.
15775 * coffread.c (coff_symfile_read): Use objfile_msymbols.
15776 * symmisc.c (dump_msymbols): Use objfile_msymbols.
15777 * objc-lang.c (find_methods): Use objfile_msymbols.
15778 (info_selectors_command, info_classes_command): Likewise.
15779 * stabsread.c (scan_file_globals): Use objfile_msymbols.
15780 * objfiles.h (class objfile_msymbols): New.
15781 (ALL_OBJFILE_MSYMBOLS): Remove.
15782 (ALL_MSYMBOLS): Remove.
15783
15784 2019-01-09 Tom Tromey <tom@tromey.com>
15785
15786 * common/next-iterator.h (next_adapter): Add Iterator template
15787 parameter.
15788 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15789 (class all_objfiles_safe): New.
15790 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15791 * objfiles.c (put_objfile_before): Update comment.
15792 (add_separate_debug_objfile): Likewise.
15793 (free_all_objfiles): Use all_objfiles_safe.
15794 (objfile_purge_solibs): Likewise.
15795
15796 2019-01-09 Tom Tromey <tom@tromey.com>
15797
15798 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15799 (expand_symtab_containing_pc, lookup_static_symbol)
15800 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15801 (find_symbol_at_address, find_line_symtab, find_main_name): Use
15802 all_objfiles.
15803 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15804 * breakpoint.c (create_overlay_event_breakpoint)
15805 (create_longjmp_master_breakpoint)
15806 (create_std_terminate_master_breakpoint)
15807 (create_exception_master_breakpoint): Use all_objfiles.
15808 * linux-thread-db.c (try_thread_db_load_from_pdir)
15809 (has_libpthread): Use all_objfiles.
15810 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15811 * linespec.c (iterate_over_all_matching_symtabs)
15812 (search_minsyms_for_name): Use all_objfiles.
15813 * maint.c (maintenance_info_sections): Use all_objfiles.
15814 * main.c (captured_main_1): Use all_objfiles.
15815 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15816 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15817 * guile/scm-pretty-print.c
15818 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15819 * solib-spu.c (append_ocl_sos): Use all_objfiles.
15820 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15821 (maintenance_print_msymbols): Use all_objfiles.
15822 * source.c (select_source_symtab): Use all_objfiles.
15823 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15824 * symfile.c (remove_symbol_file_command)
15825 (expand_symtabs_matching, map_symbol_filenames): Use
15826 all_objfiles.
15827 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15828 all_objfiles.
15829 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15830 * objc-lang.c (find_methods): Use all_objfiles.
15831 * objfiles.c (have_partial_symbols, have_full_symbols)
15832 (have_minimal_symbols, qsort_cmp)
15833 (default_iterate_over_objfiles_in_search_order): Use
15834 all_objfiles.
15835 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
15836 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
15837 (maintenance_check_psymtabs): Use all_objfiles.
15838 (ALL_PSYMTABS): Remove.
15839 * compile/compile-object-run.c (do_module_cleanup): Use
15840 all_objfiles.
15841 * blockframe.c (find_pc_partial_function): Use all_objfiles.
15842 * cp-support.c (add_symbol_overload_list_qualified): Use
15843 all_objfiles.
15844 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15845 Use all_objfiles.
15846 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
15847 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
15848 all_objfiles.
15849 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15850 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
15851 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15852 Uses all_objfiles.
15853 * solib.c (solib_read_symbols): Use all_objfiles
15854
15855 2019-01-09 Tom Tromey <tom@tromey.com>
15856
15857 * probe.c (parse_probes_in_pspace): Use all_objfiles.
15858 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
15859 all_objfiles.
15860 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
15861 * symmisc.c (print_symbol_bcache_statistics)
15862 (print_objfile_statistics, maintenance_print_objfiles)
15863 (maintenance_info_symtabs, maintenance_check_symtabs)
15864 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
15865 all_objfiles.
15866 * source.c (forget_cached_source_info): Use all_objfiles.
15867 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
15868 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15869 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
15870 * objfiles.c (update_section_map): Use all_objfiles.
15871 (shared_objfile_contains_address_p): Likewise.
15872 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
15873 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
15874
15875 2019-01-09 Tom Tromey <tom@tromey.com>
15876
15877 * common/next-iterator.h: New file.
15878 * objfiles.h (class all_objfiles): New.
15879 (struct objfile_iterator): New.
15880
15881 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15882
15883 * NEWS: Move the description of the changed "frame", "select-frame",
15884 and "info frame" commands to the Changed commands section.
15885
15886 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
15887
15888 * gdbtypes.c (check_stub_method_group): Remove handling of old
15889 mangling schemes.
15890 * linespec.c (find_methods): Likewise.
15891 * stabsread.c (read_member_functions): Likewise.
15892 * valops.c (search_struct_method): Likewise.
15893 (value_struct_elt_for_reference): Likewise.
15894 * NEWS: Mention this change.
15895
15896 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
15897
15898 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
15899 print_source_lines.
15900 * source.c (print_source_lines_base): Update line number check.
15901 (print_source_lines): New function.
15902 (source_lines_range::source_lines_range): New function.
15903 * source.h (class source_lines_range): New class.
15904 (print_source_lines): New declaration.
15905
15906 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15907
15908 * linespec.c (linespec_state_destructor): Free self->canonical_names.
15909
15910 2019-01-08 Tom Tromey <tom@tromey.com>
15911 Simon Marchi <simon.marchi@ericsson.com>
15912
15913 PR gdb/24060
15914 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
15915 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
15916 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15917 * f-exp.y (DOLLAR_VARIABLE): Likewise.
15918 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
15919 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15920
15921 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
15922
15923 * source.c (select_source_symtab): Move header comment to
15924 declaration in source.h.
15925 (forget_cached_source_info_for_objfile): Likewise.
15926 (forget_cached_source_info): Likewise.
15927 (identify_source_line): Likewise.
15928 * source.h (identify_source_line): Move declaration from symtab.h
15929 and add comment from source.c
15930 (print_source_lines): Likewise.
15931 (forget_cached_source_info_for_objfile): Likewise.
15932 (forget_cached_source_info): Likewise.
15933 (select_source_symtab): Likewise.
15934 (enum print_source_lines_flag): Move definition from symtab.h.
15935 * symtab.h (identify_source_line): Move declaration to source.h.
15936 (print_source_lines): Likewise.
15937 (forget_cached_source_info_for_objfile): Likewise.
15938 (forget_cached_source_info): Likewise.
15939 (select_source_symtab): Likewise.
15940 (enum print_source_lines_flag): Move definition to source.h.
15941 * tui/tui-hooks.c: Add 'source.h' include.
15942
15943 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
15944
15945 * source.c (print_source_lines_base): Handle requests to print
15946 reverse line number sequences, and guard against empty lines
15947 string.
15948
15949 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
15950
15951 * source.c (print_source_lines_base): Fix skip of '\r' if next
15952 character is '\n'.
15953
15954 2019-01-06 Tom Tromey <tom@tromey.com>
15955
15956 * c-exp.y (struct c_parse_state) <macro_original_text,
15957 expansion_obstack>: New member.
15958 (macro_original_text, expansion_obstack): Remove globals.
15959 (scan_macro_expansion, scanning_macro_expansion)
15960 (finished_macro_expansion): Update.
15961 (scan_macro_cleanup): Remove.
15962 (yylex, c_parse): Update.
15963
15964 2019-01-06 Tom Tromey <tom@tromey.com>
15965
15966 * c-exp.y (struct c_parse_state) <strings>: New member.
15967 (operator_stoken): Update.
15968
15969 2019-01-06 Tom Tromey <tom@tromey.com>
15970
15971 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
15972 (union type_stack_elt) <typelist_val>: Now a pointer to
15973 std::vector.
15974 (type_stack_cleanup): Don't declare.
15975 (push_typelist): Update.
15976 * parse.c (pop_typelist): Return a std::vector.
15977 (push_typelist): Take a std::vector.
15978 (follow_types): Update. Do not free args.
15979 (type_stack_cleanup): Remove.
15980 * c-exp.y (struct c_parse_state): New.
15981 (cpstate): New global.
15982 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
15983 (nonempty_typelist): Update.
15984 (func_mod): Create a new vector.
15985 (c_parse): Create a c_parse_state.
15986 (check_parameter_typelist): Do not delete params.
15987 (function_method): Update. Do not delete type_list.
15988
15989 2019-01-06 Tom Tromey <tom@tromey.com>
15990
15991 PR gdb/28155:
15992 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
15993 check_typedef.
15994 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
15995 (print_return_value): Likewise.
15996
15997 2019-01-05 Tom Tromey <tom@tromey.com>
15998
15999 * contrib/cleanup_check.py: Remove.
16000 * contrib/gcc-with-excheck: Remove.
16001 * contrib/exsummary.py: Remove.
16002 * contrib/excheck.py: Remove.
16003
16004 2019-01-05 Joel Brobecker <brobecker@adacore.com>
16005
16006 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16007 NULL. Initialize tpprev to NULL instead of assigning it
16008 to NULL on the next statement.
16009 * windows-nat.c (windows_delete_thread): Remove check for
16010 main_thread_id before printing thread exit notifications.
16011 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16012 Remove thread ID check against main_thread_id.
16013 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16014 windows_delete_thread.
16015 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16016
16017 2019-01-04 Tom Tromey <tom@tromey.com>
16018
16019 * compile/compile.c (_initialize_compile): Use upper case for
16020 metasyntactic variables.
16021 * symmisc.c (_initialize_symmisc): Use upper case for
16022 metasyntactic variables.
16023 * psymtab.c (_initialize_psymtab): Use upper case for
16024 metasyntactic variables.
16025 * demangle.c (demangle_command): Use upper case for metasyntactic
16026 variables.
16027 (_initialize_demangler): Likewise.
16028 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16029 variables.
16030
16031 2019-01-03 Tom Tromey <tom@tromey.com>
16032
16033 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16034
16035 2019-01-03 Tom Tromey <tom@tromey.com>
16036
16037 * python/py-symtab.c (salpy_str): Update.
16038 (struct salpy_sal_object) <symtab>: Now a PyObject.
16039 (salpy_dealloc): Update.
16040 (del_objfile_sal): Use gdbpy_ref.
16041
16042 2019-01-03 Tom Tromey <tom@tromey.com>
16043
16044 * python/py-type.c (convert_field): Use new_reference. Return
16045 gdbpy_ref.
16046 (make_fielditem): Return gdbpy_ref.
16047 (typy_fields): Update.
16048 (typy_getitem): Update.
16049 (field_name): Return gdbpy_ref. Use new_reference.
16050 (typy_iterator_iternext): Update.
16051
16052 2019-01-03 Tom Tromey <tom@tromey.com>
16053
16054 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16055
16056 2019-01-03 Tom Tromey <tom@tromey.com>
16057
16058 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16059 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16060 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16061 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16062 (pspy_set_type_printers): Likewise.
16063 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16064 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16065 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16066 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16067 (objfpy_set_type_printers): Likewise.
16068
16069 2019-01-03 Tom Tromey <tom@tromey.com>
16070
16071 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16072 (gdbpy_print_stack): Use gdbpy_err_fetch.
16073 * python/python-internal.h (class gdbpy_err_fetch): New class.
16074 (class gdbpy_enter) <m_error_type, m_error_value,
16075 m_error_traceback>: Remove.
16076 <m_error>: New member.
16077 (gdbpy_exception_to_string): Don't declare.
16078 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16079 * python/py-value.c (convert_value_from_python): Use
16080 gdbpy_err_fetch.
16081 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16082 gdbpy_exception_to_string.
16083 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16084 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16085 gdbpy_err_fetch.
16086
16087 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16088
16089 * linux-nat.c (delete_lwp_cleanup): Delete.
16090 (struct lwp_deleter): New struct.
16091 (lwp_info_up): New typedef.
16092 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16093 lwp_info_up.
16094
16095 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16096
16097 * linux-fork.c (class scoped_switch_fork_info): New class.
16098 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16099
16100 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16101
16102 * valops.c (find_overload_match): Remove use of null_cleanup, and
16103 calls to do_cleanups.
16104
16105 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16106
16107 * compile/compile-cplus-types.c
16108 (compile_cplus_instance::decl_name): Handle changes to
16109 cp_func_name.
16110 * cp-support.c (cp_func_name): Update header comment, update
16111 return type.
16112 * cp-support.h (cp_func_name): Update return type in declaration.
16113 * valops.c (find_overload_match): Move temp_func local to top
16114 level of function and change its type. Use temp_func to hold and
16115 delete temporary string obtained from cp_func_name.
16116
16117 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16118
16119 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16120 gdb::char_vector, remove cleanup, and update uses of `msg`.
16121
16122 2019-01-03 Jim Wilson <jimw@sifive.com>
16123
16124 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16125
16126 2019-01-02 Tom Tromey <tom@tromey.com>
16127
16128 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16129 (tdesc_parse_xml): Remove cleanups.
16130 * target-descriptions.h (make_cleanup_free_target_description):
16131 Don't declare.
16132 (target_desc_deleter): New struct.
16133 (target_desc_up): New typedef.
16134 * target-descriptions.c (target_desc_deleter::operator()): Rename
16135 from free_target_description.
16136 (make_cleanup_free_target_description): Remove.
16137
16138 2019-01-02 Tom Tromey <tom@tromey.com>
16139
16140 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16141 constructor, destructor.
16142 (linespec_parser): Remove typedef.
16143 (~linespec_parser): Rename from linespec_parser_delete.
16144 (linespec_lex_to_end, linespec_complete_label)
16145 (linespec_complete): Update.
16146 (decode_line_full): Remove cleanups.
16147 (decode_line_1): Update.
16148
16149 2019-01-02 Tom Tromey <tom@tromey.com>
16150
16151 * python/python-internal.h (inferior_to_inferior_object): Change
16152 return type.
16153 * python/py-exitedevent.c (create_exited_event_object): Update.
16154 * python/py-inferior.c (inferior_to_inferior_object): Return
16155 gdbpy_ref.
16156 (python_new_inferior, python_inferior_deleted)
16157 (thread_to_thread_object, delete_thread_object)
16158 (build_inferior_list, gdbpy_selected_inferior): Update.
16159 * python/py-infthread.c (create_thread_object): Update. Also fail
16160 if inferior_to_inferior_object fails.
16161
16162 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16163
16164 * inferior.h (class inferior) <displaced_step_state>: New field.
16165 * infrun.h (struct displaced_step_state): Move here from
16166 infrun.c. Initialize fields, add constructor.
16167 <inf>: Remove field.
16168 <reset>: New method.
16169 * infrun.c (struct displaced_step_inferior_state): Move to
16170 infrun.h.
16171 (displaced_step_inferior_states): Remove.
16172 (get_displaced_stepping_state): Adust.
16173 (displaced_step_in_progress_any_inferior): Adjust.
16174 (displaced_step_in_progress_thread): Adjust.
16175 (displaced_step_in_progress): Adjust.
16176 (add_displaced_stepping_state): Remove.
16177 (get_displaced_step_closure_by_addr): Adjust.
16178 (remove_displaced_stepping_state): Remove.
16179 (infrun_inferior_exit): Call displaced_step_state.reset.
16180 (use_displaced_stepping): Don't check for NULL.
16181 (displaced_step_prepare_throw): Call
16182 get_displaced_stepping_state.
16183 (displaced_step_fixup): Don't check for NULL.
16184 (prepare_for_detach): Don't check for NULL.
16185
16186 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16187
16188 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16189 in case of call that did not complete.
16190
16191 2019-01-02 Andrey Utkin <autkin@undo.io>
16192
16193 * symfile.c (find_separate_debug_file): Fix search of debug files for
16194 remote debuggee.
16195
16196 2019-01-02 Tom Tromey <tom@tromey.com>
16197
16198 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16199 indentation.
16200 * python/py-frame.c (frapy_older): Remove cast.
16201 (frapy_newer): Likewise.
16202 * python/py-breakpoint.c (local_setattro): Remove cast.
16203 * python/py-arch.c (archpy_name): Remove local variable.
16204 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16205
16206 2019-01-02 Joel Brobecker <brobecker@adacore.com>
16207
16208 * unittests/basic_string_view/element_access/char/empty.cc:
16209 Fix year range in copyright header.
16210
16211 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16212
16213 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16214 Delete.
16215 <operator==>: Update with for removed field.
16216 <hash>: Likewise.
16217 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16218 <isa_features>: ...this.
16219 <abi_features>: New field.
16220 (riscv_isa_flen): Update comment.
16221 (riscv_abi_xlen): New declaration.
16222 (riscv_abi_flen): New declaration.
16223 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16224 isa_features.
16225 (riscv_abi_xlen): New function.
16226 (riscv_isa_flen): Update to get answer from isa_features.
16227 (riscv_abi_flen): New function.
16228 (riscv_has_fp_abi): Update to get answer from abi_features.
16229 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16230 xlen and flen.
16231 (riscv_call_info) <xlen, flen>: Update comment.
16232 (riscv_call_arg_struct): Remove invalid assertions
16233 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16234 is removed.
16235 (riscv_gdbarch_init): Gather isa features and abi features
16236 separately, ensure both match on the gdbarch when reusing an old
16237 gdbarch. Relax an error check to allow 32-bit abi float to run on
16238 a target with 64-bit float hardware.
16239
16240 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16241
16242 * source.c (search_command_helper): Stop reverse search
16243 when line 1 has been searched.
16244
16245 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16246
16247 * record-full.c (record_full_base_target::close): Rewrite
16248 record_full_core_buf_list free logic.
16249
16250 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16251
16252 * break-catch-syscall.c (print_one_catch_syscall): xfree
16253 the last text.
16254
16255 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16256
16257 * top.c (print_gdb_version): Update Copyright year in version
16258 message.
16259
16260 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16261
16262 Update copyright year range in all GDB files.
16263
16264 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
16265
16266 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16267
16268 For older changes see ChangeLog-2018.
16269 \f
16270 Local Variables:
16271 mode: change-log
16272 left-margin: 8
16273 fill-column: 74
16274 version-control: never
16275 coding: utf-8
16276 End:
16277
This page took 0.392123 seconds and 5 git commands to generate.