gdb/ChangeLog

   1 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * symfile.h (struct symfile_segment_data)
   4         <~symfile_segment_data>: Remove.
   5         <segment_info>: Change to std::vector.
   6         * symfile.c (default_symfile_segments): Update.
   7         * elfread.c (elf_symfile_segments): Update.
   8
   9 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
  10
  11         * symfile.h (struct symfile_segment_data) <struct segment>: New.
  12         <segments>: New.
  13         <segment_bases, segment_sizes>: Remove.
  14         * symfile.c (default_symfile_segments): Update.
  15         * elfread.c (elf_symfile_segments): Update.
  16         * remote.c (remote_target::get_offsets): Update.
  17         * solib-target.c (solib_target_relocate_section_addresses):
  18         Update.
  19
  20 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
  21
  22         * symfile.h (struct symfile_segment_data): Initialize fields.
  23         <~symfile_segment_data>: Add.
  24         (symfile_segment_data_up): New.
  25         (struct sym_fns) <sym_segments>: Return a
  26         symfile_segment_data_up.
  27         (default_symfile_segments): Return a symfile_segment_data_up.
  28         (free_symfile_segment_data): Remove.
  29         (get_symfile_segment_data): Return a symfile_segment_data_up.
  30         * symfile.c (default_symfile_segments): Likewise.
  31         (get_symfile_segment_data): Likewise.
  32         (free_symfile_segment_data): Remove.
  33         (symfile_find_segment_sections): Update.
  34         * elfread.c (elf_symfile_segments): Return a
  35         symfile_segment_data_up.
  36         * remote.c (remote_target::get_offsets): Update.
  37         * solib-target.c (solib_target_relocate_section_addresses):
  38         Update.
  39         * symfile-debug.c (debug_sym_segments): Return a
  40         symfile_segment_data_up.
  41
  42 2020-05-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
  43
  44         PR build/25981
  45         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
  46         Hardcode register numbers.
  47
  48         PR build/25981
  49         * procfs.c [(__i386__ || __x86_64__) && sun] (proc_get_LDT_entry,
  50         procfs_find_LDT_entry): Remove.
  51         * procfs.h [(__i386__ || __x86_64__) && sun] (struct ssd,
  52         procfs_find_LDT_entry): Remove.
  53         * sol-thread.c [(__i386__ || __x86_64__) && sun] (ps_lgetLDT):
  54         Remove.
  55
  56 2020-05-17  Pedro Alves  <palves@redhat.com>
  57             Andrew Burgess  <andrew.burgess@embecosm.com>
  58             Keno Fischer  <keno@juliacomputing.com>
  59
  60         PR gdb/25741
  61         * breakpoint.c (build_target_condition_list): Update comments.
  62         (build_target_command_list): Update comments and skip matching
  63         locations.
  64         (insert_bp_location): Move "set breakpoint auto-hw on" handling to
  65         a separate function.  Simplify "set breakpoint auto-hw off"
  66         handling.
  67         (insert_breakpoints): Update comment.
  68         (tracepoint_locations_match): New parameter.  For breakpoints,
  69         compare location types too, if the caller wants to.
  70         (handle_automatic_hardware_breakpoints): New functions.
  71         (bp_location_is_less_than): Also sort by location type and
  72         hardware breakpoint length.
  73         (update_global_location_list): Handle "set breakpoint auto-hw on"
  74         here.
  75         (update_breakpoint_locations): Ask breakpoint_locations_match to
  76         ignore location types.
  77
  78 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
  79
  80         * gdbtypes.h (TYPE_NAME): Remove.  Change all cal sites to use
  81         type::name instead.
  82
  83 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
  84
  85         * gdbtypes.h (struct type) <name, set_name>: New methods.
  86         (TYPE_CODE): Use type::name.  Change all call sites used to set
  87         the name to use type::set_name instead.
  88
  89 2020-05-16  Tom Tromey  <tom@tromey.com>
  90
  91         * top.c (quit_force): Update.
  92         * infrun.c (handle_no_resumed): Update.
  93         * top.h (all_uis): New function.
  94         (ALL_UIS): Remove.
  95
  96 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
  97
  98         * mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
  99
 100 2020-05-16  Pedro Alves  <palves@redhat.com>
 101
 102         * ia64-linux-nat.c
 103         (ia64_linux_nat_target) <enable_watchpoints_in_psr(ptid_t)>:
 104         Declare method.
 105         (enable_watchpoints_in_psr): Now a method of ia64_linux_nat_target.
 106
 107 2020-05-15  Simon Marchi  <simon.marchi@efficios.com>
 108
 109         * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct).
 110         (sparc64_adi_info): Likewise.
 111
 112 2020-05-15  Tom Tromey  <tom@tromey.com>
 113
 114         * symtab.c (lookup_language_this, lookup_symbol_aux): Use
 115         block_objfile.
 116         (lookup_objfile_from_block): Remove.
 117         (lookup_symbol_in_block, lookup_symbol_in_static_block)
 118         (lookup_global_symbol): Use block_objfile.
 119         * symtab.h (lookup_objfile_from_block): Don't declare.
 120         * printcmd.c (clear_dangling_display_expressions): Use
 121         block_objfile.
 122         * parse.c (operator_check_standard): Use block_objfile.
 123
 124 2020-05-15  Tom Tromey  <tom@tromey.com>
 125
 126         * language.c (language_alloc_type_symbol): Set
 127         SYMBOL_SECTION.
 128         * symtab.c (initialize_objfile_symbol): Remove.
 129         (allocate_symbol): Remove.
 130         (allocate_template_symbol): Remove.
 131         * dwarf2/read.c (fixup_go_packaging): Use "new".
 132         (new_symbol): Use "new".
 133         (read_variable): Don't call initialize_objfile_symbol.  Use
 134         "new".
 135         (read_func_scope): Use "new".
 136         * xcoffread.c (process_xcoff_symbol): Don't call
 137         initialize_objfile_symbol.
 138         (SYMBOL_DUP): Remove.
 139         * coffread.c (process_coff_symbol, coff_read_enum_type): Use
 140         "new".
 141         * symtab.h (allocate_symbol, initialize_objfile_symbol)
 142         (allocate_template_symbol): Don't declare.
 143         (struct symbol): Add copy constructor.  Change defaults.
 144         * jit.c (finalize_symtab): Use "new".
 145         * ctfread.c (ctf_add_enum_member_cb, new_symbol, ctf_add_var_cb):
 146         Use "new".
 147         * stabsread.c (patch_block_stabs, define_symbol, read_enum_type)
 148         (common_block_end): Use "new".
 149         * mdebugread.c (parse_symbol): Use "new".
 150         (new_symbol): Likewise.
 151
 152 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 153
 154         * NEWS: Mention changes to help and apropos.
 155
 156 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 157
 158         * command.h (enum command_class): Improve comments, document
 159         that class_alias is for user-defined aliases, give the class
 160         name for each class, remove unused class_xdb.
 161         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
 162         * breakpoint.c (_initialize_breakpoint): Replace class_alias
 163         by a precise class.
 164         * infcmd.c (_initialize_infcmd): Likewise.
 165         * reverse.c (_initialize_reverse): Likewise.
 166         * stack.c (_initialize_stack): Likewise.
 167         * symfile.c (_initialize_symfile): Likewise.
 168         * tracepoint.c (_initialize_tracepoint): Likewise.
 169
 170 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 171
 172         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
 173         when their aliased command is traversed.
 174         (help_cmd): Add fput_command_names_styled call to
 175         output command name and aliases when command has an alias.
 176
 177 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 178
 179         * cli/cli-decode.h (help_cmd_list): Remove declaration.
 180         * cli/cli-decode.c (help_cmd_list): Declare as static,
 181         remove prefix argument, use bool for recurse arg, rework to show the aliases of
 182         a command together with the command.
 183         (fput_command_name_styled, fput_command_names_styled): New functions.
 184         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
 185         fput_command_name_styled.
 186         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
 187         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
 188
 189 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 190
 191         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
 192         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
 193         * command.h (cmd_show_list): Likewise.
 194         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
 195         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
 196
 197 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 198
 199         * unittests/command-def-selftests.c (traverse_command_structure):
 200         Verify all commands of a list have the same prefix command and
 201         that only the top cmdlist commands have a null prefix.
 202
 203 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 204
 205         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
 206         as prefix, not one of its aliases.
 207         (set_cmd_prefix): Remove.
 208         (do_add_cmd): Centralize the setting of the prefix of a command, when
 209         command is defined after its full chain of prefix commands.
 210         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
 211         (add_setshow_cmd_full): Likewise.
 212         (update_prefix_field_of_prefixed_commands): New function.
 213         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
 214         update_prefix_field_of_prefixed_commands.
 215         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
 216         addresses of remote_set_cmdlist and remote_show_cmdlist given
 217         as argument, not the address of an argument.
 218         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
 219         * gdb/remote.c (_initialize_remote): Likewise.
 220
 221 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 222
 223         * cli/cli-cmds.c (alias_command): Check for an existing alias
 224         using lookup_cmd_composition, as valid_command_p is too strict
 225         and forbids aliases that are the prefix of an existing alias
 226         or command.
 227         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
 228         command is properly recognised as a valid command.
 229
 230 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 231
 232         * unittests/help-doc-selftests.c: Rename to
 233         unittests/command-def-selftests.c
 234         * unittests/command-def-selftests.c (help_doc_tests): Update some
 235         comments.
 236         (command_structure_tests, traverse_command_structure): New namespace
 237         and function.
 238         (command_structure_invariants_tests): New function.
 239         (_initialize_command_def_selftests) Renamed from
 240         _initialize_help_doc_selftests, register command_structure_invariants
 241         selftest.
 242
 243 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 244
 245         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
 246         an alias of 'show'.
 247
 248 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
 249
 250         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
 251         ada_is_fixed_point_type.  Update all callers.
 252         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
 253         all callers.
 254         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
 255         Update all callers.
 256         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
 257         print_fixed_point_type.  Update all callers.
 258         * ada-valprint.c (ada_value_print_num): Replace call to
 259         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
 260
 261 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
 262
 263         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
 264         processors.
 265         (cpu_supports_bts): Add CV_AMD case.
 266
 267 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
 268             Simon Marchi  <simon.marchi@efficios.com>
 269
 270         * infrun.c (stop_all_threads): Collect multiple wait events at
 271         each pass.
 272
 273 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
 274
 275         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
 276         type::code instead.
 277
 278 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
 279
 280         * gdbtypes.h (struct type) <code, set_code>: New methods.
 281         (TYPE_CODE): Use type::code.  Change all call sites used to set
 282         the code to use type::set_code instead.
 283
 284 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 285             Tom de Vries  <tdevries@suse.de>
 286             Pedro Alves  <palves@redhat.com>
 287
 288         PR threads/25478
 289         * infrun.c (stop_all_threads): Do NOT ignore
 290         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
 291         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
 292         received.
 293         (handle_no_resumed): Remove code handling a live inferior with no
 294         threads.
 295         * remote.c (has_single_non_exited_thread): New.
 296         (remote_target::update_thread_list): Do not delete a thread if is
 297         the last thread of the process.
 298         * thread.c (thread_select): Call delete_exited_threads instead of
 299         prune_threads.
 300
 301 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 302
 303         * infrun.c (stop_all_threads): Enable/disable thread events of all
 304         targets.  Move a debug message denoting the end of the function
 305         into the SCOPED_EXIT block.
 306
 307 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 308
 309         * process-stratum-target.h: Include <set>.
 310         (all_non_exited_process_targets, switch_to_target_no_thread): New
 311         function declarations.
 312         * process-stratum-target.c (all_non_exited_process_targets)
 313         (switch_to_target_no_thread): New function implementations.
 314
 315 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 316
 317         * infrun.c (handle_inferior_event): Extract out a piece of code
 318         into...
 319         (mark_non_executing_threads): ...this new function.
 320
 321 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 322
 323         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
 324         use.
 325
 326 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 327
 328         * regcache.c (regcache_read_pc_protected): New function
 329         implementation that returns 0 if the PC cannot read via
 330         'regcache_read_pc'.
 331         * infrun.c (proceed): Call 'regcache_read_pc_protected'
 332         instead of 'regcache_read_pc'.
 333         (keep_going_pass_signal): Ditto.
 334
 335 2020-05-13  Tom Tromey  <tromey@adacore.com>
 336
 337         * ada-lang.c (align_value): Remove.
 338         (ada_template_to_fixed_record_type_1): Use align_up.
 339
 340 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 341
 342         * async-event.c: Update the copyright year.
 343         * async-event.h: Update the copyright year.
 344
 345 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
 346
 347         * objfiles.h (is_addr_in_objfile,
 348         shared_objfile_contains_address_p): Return bool.
 349         * objfile.c (is_addr_in_objfile,
 350         shared_objfile_contains_address_p): Return bool.
 351
 352 2020-05-11  Tom Tromey  <tromey@adacore.com>
 353
 354         * cli/cli-cmds.c (info_command): Restore.
 355         (_initialize_cli_cmds): Use add_prefix_command for "info".
 356         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
 357
 358 2020-05-11  Tom Tromey  <tromey@adacore.com>
 359
 360         * ada-lang.c (ada_value_primitive_field): Now public.
 361         * ada-lang.h (ada_value_primitive_field): Declare.
 362         * ada-valprint.c (print_field_values): Use
 363         ada_value_primitive_field for wrapper fields.
 364
 365 2020-05-11  Tom de Vries  <tdevries@suse.de>
 366
 367         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
 368         MODULE_DOMAIN.
 369
 370 2020-05-11  Tom de Vries  <tdevries@suse.de>
 371
 372         PR symtab/25941
 373         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
 374         with length 0, if not gdb-produced.
 375         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
 376
 377 2020-05-09  Tom de Vries  <tdevries@suse.de>
 378
 379         PR gdb/25955
 380         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
 381         calculation.
 382
 383 2020-05-09  Tom Tromey  <tom@tromey.com>
 384
 385         * top.c (server_command): Now bool.
 386         * top.h (server_command): Now bool.
 387
 388 2020-05-08  Tom Tromey  <tromey@adacore.com>
 389
 390         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
 391         already being processed.
 392
 393 2020-05-08  Tom Tromey  <tom@tromey.com>
 394
 395         * printcmd.c (struct display) <next>: Remove.
 396         <display>: New constructor.
 397         <exp_string>: Now a std::string.
 398         <enabled_p>: Now a bool.
 399         (display_number): Move definition earlier.
 400         (displays): Rename from display_chain.  Now a std::vector.
 401         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
 402         (display_command): Update.
 403         (do_one_display, disable_display)
 404         (enable_disable_display_command, do_enable_disable_display):
 405         Update.
 406         (free_display): Remove.
 407         (clear_displays): Rewrite.
 408         (delete_display): Update.
 409         (map_display_numbers): Use function_view.  Remove "data"
 410         parameter.  Update.
 411         (do_delete_display): Remove.
 412         (undisplay_command): Update.
 413         (do_one_display, do_displays, disable_display)
 414         (info_display_command): Update.
 415         (do_enable_disable_display): Remove.
 416         (enable_disable_display_command)
 417         (clear_dangling_display_expressions): Update.
 418
 419 2020-05-08  Tom Tromey  <tom@tromey.com>
 420
 421         * symtab.c (set_symbol_cache_size)
 422         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
 423         (maintenance_print_symbol_cache_statistics): Update.
 424         * symmisc.c (print_symbol_bcache_statistics)
 425         (print_objfile_statistics, maintenance_print_objfiles)
 426         (maintenance_info_symtabs, maintenance_check_symtabs)
 427         (maintenance_expand_symtabs, maintenance_info_line_tables):
 428         Update.
 429         * symfile-debug.c (set_debug_symfile): Update.
 430         * source.c (forget_cached_source_info): Update.
 431         * python/python.c (gdbpy_progspaces): Update.
 432         * psymtab.c (maintenance_info_psymtabs): Update.
 433         * probe.c (parse_probes): Update.
 434         * linespec.c (iterate_over_all_matching_symtabs)
 435         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
 436         * guile/scm-progspace.c (gdbscm_progspaces): Update.
 437         * exec.c (exec_target::close): Update.
 438         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
 439         * breakpoint.c (print_one_breakpoint_location)
 440         (create_longjmp_master_breakpoint)
 441         (create_std_terminate_master_breakpoint): Update.
 442         * progspace.c (program_spaces): Now a std::vector.
 443         (maybe_new_address_space): Update.
 444         (add_program_space): Remove.
 445         (program_space::program_space): Update.
 446         (remove_program_space): Update.
 447         (number_of_program_spaces): Remove.
 448         (print_program_space, update_address_spaces): Update.
 449         * progspace.h (program_spaces): Change type.
 450         (ALL_PSPACES): Remove.
 451         (number_of_program_spaces): Don't declare.
 452         (struct program_space) <next>: Remove.
 453
 454 2020-05-08  Tom Tromey  <tom@tromey.com>
 455
 456         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
 457         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
 458         (enable_break): Update.
 459         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
 460         (frv_fdpic_find_canonical_descriptor): Update.
 461         (frv_fetch_objfile_link_map): Update.
 462         * progspace.c (program_space::free_all_objfiles): Update.
 463         (program_space::solibs): New method.
 464         * progspace.h (struct program_space) <solibs>: New method.
 465         * solist.h (master_so_list): Don't declare.
 466         (ALL_SO_LIBS): Remove.
 467         * solib.h (so_list_head): Remove.
 468         (update_solib_list): Update comment.
 469         * solib.c (master_so_list): Remove.
 470         (solib_used, update_solib_list, solib_add)
 471         (info_sharedlibrary_command, clear_solib)
 472         (reload_shared_libraries_1, remove_user_added_objfile): Update.
 473
 474 2020-05-08  Tom Tromey  <tom@tromey.com>
 475
 476         * extension.c (extension_languages): Now a std::array.
 477         (ALL_EXTENSION_LANGUAGES): Remove.
 478         (get_ext_lang_defn, get_ext_lang_of_file)
 479         (eval_ext_lang_from_control_command): Update.
 480         (finish_ext_lang_initialization)
 481         (auto_load_ext_lang_scripts_for_objfile)
 482         (ext_lang_type_printers::ext_lang_type_printers)
 483         (apply_ext_lang_type_printers)
 484         (ext_lang_type_printers::~ext_lang_type_printers)
 485         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
 486         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
 487         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
 488         (get_matching_xmethod_workers, ext_lang_colorize)
 489         (ext_lang_before_prompt): Update.
 490         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
 491
 492 2020-05-08  Tom Tromey  <tom@tromey.com>
 493
 494         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
 495         overload.
 496         <swap_string, m_string>: Remove.
 497         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
 498         Update.
 499         * stabsread.c (define_symbol, read_type): Update.
 500         * linespec.c (find_linespec_symbols): Update.
 501         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
 502         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
 503         * dbxread.c (read_dbx_symtab): Update.
 504         * cp-support.h (cp_canonicalize_string_full)
 505         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
 506         Return unique_xmalloc_ptr.
 507         * cp-support.c (inspect_type): Update.
 508         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
 509         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
 510         Likewise.
 511         * c-typeprint.c (print_name_maybe_canonical): Update.
 512         * break-catch-throw.c (check_status_exception_catchpoint):
 513         Update.
 514
 515 2020-05-08  Tom de Vries  <tdevries@suse.de>
 516
 517         * infrun.c (follow_fork): Copy current_line and current_symtab to
 518         child thread.
 519
 520 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 521
 522         * async-event.c (struct async_signal_handler, struct
 523         async_event_handler): Reformat, remove typedef.
 524
 525 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 526
 527         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
 528         access thistype->main_type->dyn_prop_list directly.
 529
 530 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 531
 532         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
 533         (remove_dyn_prop): Remove.  Update all users to use
 534         type::remove_dyn_prop.
 535         * gdbtypes.c (remove_dyn_prop): Rename to...
 536         (type::remove_dyn_prop): ... this.
 537
 538 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
 539
 540         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
 541         (add_dyn_prop): Remove.  Update all users to use
 542         type::add_dyn_prop.
 543         * gdbtypes.c (add_dyn_prop): Rename to...
 544         (type::add_dyn_prop): ... this.
 545
 546 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 547
 548         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
 549         (get_dyn_prop): Remove.  Update all users to use
 550         type::dyn_prop.
 551         * gdbtypes.c (get_dyn_prop): Rename to...
 552         (type::dyn_prop): ... this.
 553
 554 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
 555
 556         * gdbtypes.h (struct main_type) <flag_static>: Remove.
 557
 558 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
 559
 560         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
 561         instruction, skip it if it's there.
 562
 563 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
 564
 565         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
 566
 567 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
 568
 569         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
 570         * gdbtypes.c (recursive_dump_type): Remove use of
 571         TYPE_INCOMPLETE.
 572
 573 2020-05-03  Tom Tromey  <tom@tromey.com>
 574
 575         * breakpoint.c (catch_command, tcatch_command): Remove.
 576         (_initialize_breakpoint): Use add_basic_prefix_cmd,
 577         add_show_prefix_cmd.
 578         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
 579         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
 580         Remove.
 581         (add_internal_problem_command): Use add_basic_prefix_cmd,
 582         add_show_prefix_cmd.
 583         * mips-tdep.c (set_mipsfpu_command): Remove.
 584         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
 585         * dwarf2/index-cache.c (set_index_cache_command): Remove.
 586         (_initialize_index_cache): Use add_basic_prefix_cmd.
 587         * memattr.c (dummy_cmd): Remove.
 588         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
 589         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
 590         (_initialize_tui_win): Use add_basic_prefix_cmd,
 591         add_show_prefix_cmd.
 592         * cli/cli-logging.c (set_logging_command): Remove.
 593         (_initialize_cli_logging): Use add_basic_prefix_cmd,
 594         add_show_prefix_cmd.
 595         (show_logging_command): Remove.
 596         * target.c (target_command): Remove.
 597         (add_target): Use add_basic_prefix_cmd.
 598
 599 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
 600
 601         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
 602
 603 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 604
 605         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
 606         info_command.
 607
 608 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
 609
 610         * nbsd-nat.c (nbsd_enable_proc_events)
 611         (nbsd_nat_target::post_startup_inferior): Add.
 612         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
 613         (nbsd_nat_target::update_thread_list): Rewrite.
 614         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
 615         "PTRACE_LWP_CREATE".
 616         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
 617
 618 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 619
 620         * stack.c (_initialize_stack): Remove duplicated creation
 621         of "frame" command and "f" alias.
 622
 623 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
 624
 625         PR gdb/18706
 626         * gdbtypes.c (check_typedef): Calculate size of array of
 627         stubbed type.
 628
 629 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
 630
 631         PR gdb/15559
 632         * i386-tdep.c (i386_push_dummy_call): Call
 633         i386_thiscall_push_dummy_call.
 634         (i386_thiscall_push_dummy_call): New function.
 635         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
 636         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
 637         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
 638
 639 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 640
 641         * gdbarch.sh (do_read): Add shellcheck disable directive for
 642         warning SC2162.
 643
 644 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 645
 646         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
 647         "referenced but not assigned" warning.
 648
 649 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 650
 651         * gdbarch.sh: Remove code that sets fallbackdefault.
 652
 653 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 654
 655         * gdbarch.sh: Use shell operators && and || instead of
 656         -a and -o.
 657
 658 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 659
 660         * gdbarch.sh: Use $(...) instead of `...`.
 661
 662 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 663
 664         * gdbarch.sh: Use double quotes around variables.
 665
 666 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 667
 668         * gdbarch.sh: Use %s with printf, instead of variables in the
 669         format string.
 670
 671 2020-04-29  Tom Tromey  <tromey@adacore.com>
 672
 673         PR ada/25875:
 674         * dwarf2/read.c (update_enumeration_type_from_children): Compute
 675         type fields here.
 676         (read_enumeration_type): Call
 677         update_enumeration_type_from_children later.  Update comments.
 678         (process_enumeration_scope): Don't create type fields.
 679
 680 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
 681
 682         * nbsd-tdep.c: Include "xml-syscall.h".
 683         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
 684
 685 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
 686
 687         * nbsd-nat.c: Include "sys/wait.h".
 688         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
 689         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
 690         (nbsd_nat_target::remove_exec_catchpoint)
 691         (nbsd_nat_target::set_syscall_catchpoint): Add.
 692         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
 693         (nbsd_nat_target::insert_exec_catchpoint)
 694         (nbsd_nat_target::remove_exec_catchpoint)
 695         (nbsd_nat_target::set_syscall_catchpoint): Add.
 696         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
 697         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
 698         `nbsd_get_syscall_number'.
 699
 700 2020-04-29  Tom Tromey  <tom@tromey.com>
 701
 702         * stack.c (print_block_frame_labels): Remove.
 703
 704 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
 705
 706         PR gdb/17320
 707         * ada-valprint.c (val_print_packed_array_elements): Move array
 708         end bracket to new line.
 709         (ada_val_print_string): Remove extra spaces before first array
 710         element.
 711         * c-valprint.c (c_value_print_array): Likewise.
 712         * m2-valprint.c (m2_print_array_contents): Likewise.
 713         (m2_value_print_inner): Likewise.
 714         * p-valprint.c (pascal_value_print_inner): Likewise.
 715         * valprint.c (generic_val_print_array): Likewise.
 716         (value_print_array_elements): Move first array element and array
 717         end bracket to new line.
 718
 719 2020-04-29  Tom de Vries  <tdevries@suse.de>
 720
 721         PR symtab/25889
 722         * linespec.c (find_method): Fix ix calculation.
 723
 724 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
 725
 726         * syscalls/update-netbsd.sh: New file.
 727         * syscalls/netbsd.xml: Regenerate.
 728         * data-directory/Makefile.in: Register `netbsd.xml' in
 729         `SYSCALLS_FILES'.
 730
 731 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
 732
 733         * syscalls/update-freebsd.sh: Add double quotes.
 734
 735 2020-04-28  Tom Tromey  <tom@tromey.com>
 736
 737         * NEWS: Update.
 738         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
 739         (cmdpy_init): Allow class_tui.
 740
 741 2020-04-28 Mark Williams <mark@myosotissp.com>
 742
 743         PR gdb/24480
 744         * dwarf2read.c: Add missing assingments to list_in_scope when
 745         start_symtab was already called.
 746
 747 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
 748
 749         PR gdb/25881
 750         * dwarf2/read.c (offset_map_type): Use
 751         gdb:hash_enum<sect_offset> as hash function.
 752
 753 2020-04-28  Tom de Vries  <tdevries@suse.de>
 754
 755         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
 756         with DW_AT_signature.
 757
 758 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
 759
 760         * configure.ac: Remove check for fs_base/gs_base in
 761         user_regs_struct.
 762         * configure: Re-generate.
 763         * config.in: Re-generate.
 764         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
 765         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
 766         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
 767
 768 2020-04-27  Luis Machado  <luis.machado@linaro.org>
 769
 770         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
 771         problematic inline frame unwinding situation.
 772         * frame.c (frame_id_computed_p): New function.
 773         * frame.h (frame_id_computed_p): New prototype.
 774
 775 2020-04-26  Tom Tromey  <tom@tromey.com>
 776
 777         * command.h (enum command_class) <class_pseudo>: Remove.
 778
 779 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 780
 781         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
 782         and whitespace.
 783
 784 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
 785
 786        * inf-ptrace.c (inf_ptrace_target::wait): Remove
 787        `PT_GET_PROCESS_STATE' block.
 788
 789 2020-04-24  Tom Tromey  <tom@tromey.com>
 790
 791         * symtab.h (symbol_get_demangled_name): Don't declare.
 792         * symtab.c (symbol_get_demangled_name): Remove.
 793         (general_symbol_info::natural_name)
 794         (general_symbol_info::demangled_name): Update.
 795
 796 2020-04-24  Tom Tromey  <tom@tromey.com>
 797
 798         PR rust/25025:
 799         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
 800
 801 2020-04-24  Tom Tromey  <tom@tromey.com>
 802
 803         PR symtab/12707:
 804         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
 805         exists.
 806         (new_symbol): Likewise.
 807         * compile/compile-object-load.c (get_out_value_type): Use
 808         symbol_matches_search_name.
 809
 810 2020-04-24  Tom Tromey  <tom@tromey.com>
 811
 812         * dwarf2/read.c (add_partial_symbol): Do not call
 813         compute_and_set_names.
 814
 815 2020-04-24  Tom Tromey  <tom@tromey.com>
 816
 817         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
 818         overload.
 819
 820 2020-04-24  Tom Tromey  <tom@tromey.com>
 821
 822         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
 823         (add_psymbol_to_list): New overload.  Make old overload call new
 824         one.
 825         * psympriv.h (add_psymbol_to_list): New overload.
 826
 827 2020-04-24  Tom Tromey  <tom@tromey.com>
 828
 829         * dwarf2/read.c (partial_die_info::read) <case
 830         DW_AT_linkage_name>: Use value_as_string.
 831         (dwarf2_string_attr): Use value_as_string.
 832         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
 833         method.
 834         * dwarf2/attribute.c (attribute::value_as_string): New method.
 835
 836 2020-04-24  Tom Tromey  <tom@tromey.com>
 837
 838         * symtab.c (general_symbol_info::natural_name)
 839         (general_symbol_info::demangled_name): Check for language_rust.
 840
 841 2020-04-24  Tom Tromey  <tom@tromey.com>
 842
 843         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
 844         (dwarf2_physname): ... from here.
 845         (partial_die_info::read): Add Rust "{" hack.
 846
 847 2020-04-24  Tom Tromey  <tom@tromey.com>
 848
 849         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
 850         method.
 851         (symbol_set_demangled_name): Don't declare.
 852         * symtab.c (general_symbol_info::set_demangled_name): Rename from
 853         symbol_set_demangled_name.
 854         (general_symbol_info::set_language)
 855         (general_symbol_info::compute_and_set_names): Update.
 856         * minsyms.c (minimal_symbol_reader::install): Update.
 857         * dwarf2/read.c (new_symbol): Update.
 858
 859 2020-04-24  Tom Tromey  <tromey@adacore.com>
 860
 861         PR python/23662:
 862         * python/py-type.c (convert_field): Handle
 863         FIELD_LOC_KIND_DWARF_BLOCK.
 864         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
 865         (typy_get_dynamic): Nw function.
 866         (type_object_getset): Add "dynamic".
 867         * NEWS: Add entry.
 868
 869 2020-04-24  Tom Tromey  <tromey@adacore.com>
 870
 871         * ada-typeprint.c (print_choices, print_variant_part)
 872         (print_record_field_types_dynamic): New functions.
 873         (print_record_field_types): Use print_record_field_types_dynamic.
 874
 875 2020-04-24  Tom Tromey  <tromey@adacore.com>
 876
 877         * dwarf2/read.c (handle_data_member_location): New overload.
 878         (dwarf2_add_field): Use it.
 879         (decode_locdesc): Add "computed" parameter.  Update comment.
 880         * gdbtypes.c (is_dynamic_type_internal): Also look for
 881         FIELD_LOC_KIND_DWARF_BLOCK.
 882         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
 883         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
 884         virtual base classes.
 885         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
 886         FIELD_LOC_KIND_DWARF_BLOCK.
 887
 888 2020-04-24  Tom Tromey  <tromey@adacore.com>
 889
 890         * dwarf2/read.c (read_structure_type): Handle dynamic length.
 891         * gdbtypes.c (is_dynamic_type_internal): Check
 892         TYPE_HAS_DYNAMIC_LENGTH.
 893         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
 894         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
 895         New macros.
 896         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
 897         constant.
 898
 899 2020-04-24  Tom Tromey  <tromey@adacore.com>
 900
 901         * dwarf2/read.c (struct variant_field): Rewrite.
 902         (struct variant_part_builder): New.
 903         (struct nextfield): Remove "variant" field.  Add "offset".
 904         (struct field_info): Add "current_variant_part" and
 905         "variant_parts".
 906         (alloc_discriminant_info): Remove.
 907         (alloc_rust_variant): New function.
 908         (quirk_rust_enum): Update.
 909         (dwarf2_add_field): Set "offset" member.  Don't handle
 910         DW_TAG_variant_part.
 911         (offset_map_type): New typedef.
 912         (convert_variant_range, create_one_variant)
 913         (create_one_variant_part, create_variant_parts)
 914         (add_variant_property): New functions.
 915         (dwarf2_attach_fields_to_type): Call add_variant_property.
 916         (read_structure_type): Don't handle DW_TAG_variant_part.
 917         (handle_variant_part, handle_variant): New functions.
 918         (handle_struct_member_die): Use them.
 919         (process_structure_scope): Don't handle variant parts.
 920         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
 921         (struct discriminant_info): Remove.
 922         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
 923         (struct main_type) <flag_discriminated_union>: Remove.
 924         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
 925         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
 926         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
 927         Update.
 928         * valops.c (value_union_variant): Remove.
 929         * value.h (value_union_variant): Don't declare.
 930
 931 2020-04-24  Tom Tromey  <tromey@adacore.com>
 932
 933         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
 934         (ada_value_primitive_packed_val): Update.
 935         * ada-valprint.c (ada_value_print_1): Update.
 936         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
 937         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
 938         just an address.  Use evaluate_for_locexpr_baton.
 939         (dwarf2_evaluate_property): Update.
 940         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
 941         array_view.
 942         * findvar.c (default_read_var_value): Update.
 943         * gdbtypes.c (compute_variant_fields_inner)
 944         (resolve_dynamic_type_internal): Update.
 945         (resolve_dynamic_type): Change type of valaddr parameter.
 946         * gdbtypes.h (resolve_dynamic_type): Update.
 947         * valarith.c (value_subscripted_rvalue): Update.
 948         * value.c (value_from_contents_and_address): Update.
 949
 950 2020-04-24  Tom Tromey  <tromey@adacore.com>
 951
 952         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
 953         "push_initial_value" parameter.
 954         (dwarf2_evaluate_property): Likewise.
 955         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
 956
 957 2020-04-24  Tom Tromey  <tromey@adacore.com>
 958
 959         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
 960         (variant::matches, compute_variant_fields_recurse)
 961         (compute_variant_fields_inner, compute_variant_fields): New
 962         functions.
 963         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
 964         Use resolved_type after type is made.
 965         (operator==): Add new cases.
 966         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
 967         (struct discriminant_range, struct variant, struct variant_part):
 968         New.
 969         (union dynamic_prop_data) <variant_parts, original_type>: New
 970         members.
 971         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
 972         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
 973         constants.
 974         * value.c (unpack_bits_as_long): Now public.
 975         * value.h (unpack_bits_as_long): Declare.
 976
 977 2020-04-24  Tom Tromey  <tromey@adacore.com>
 978
 979         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
 980         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
 981
 982 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
 983
 984         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
 985
 986 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
 987
 988         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
 989         (remove_fork_catchpoint, post_startup_inferior)
 990         (post_attach): Move...
 991         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
 992         (remove_fork_catchpoint, post_startup_inferior)
 993         (post_attach): ...here.
 994         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
 995         (remove_fork_catchpoint, post_startup_inferior)
 996         (post_attach): Move...
 997         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
 998         (remove_fork_catchpoint, post_startup_inferior)
 999         (post_attach): ...here.
1000
1001 2020-04-24  Tom Tromey  <tromey@adacore.com>
1002
1003         * nat/windows-nat.h (struct windows_thread_info)
1004         <pc_adjusted>: New member.
1005         * windows-nat.c (windows_fetch_one_register): Check
1006         pc_adjusted.
1007         (windows_nat_target::get_windows_debug_event)
1008         (windows_nat_target::wait): Set pc_adjusted.
1009
1010 2020-04-24  Tom de Vries  <tdevries@suse.de>
1011
1012         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
1013         Run gdb-add-index inside temp dir.
1014
1015 2020-04-23  Tom Tromey  <tromey@adacore.com>
1016
1017         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
1018         in loop.
1019
1020 2020-04-23  Luis Machado  <luis.machado@linaro.org>
1021
1022         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
1023         get_frame_register instead of gdbarch_unwind_pc.
1024
1025 2020-04-23  Tom de Vries  <tdevries@suse.de>
1026
1027         * symtab.c (lookup_global_symbol): Prefer def over decl.
1028
1029 2020-04-23  Tom de Vries  <tdevries@suse.de>
1030
1031         PR symtab/25807
1032         * block.c (best_symbol, better_symbol): Promote to external.
1033         * block.h (best_symbol, better_symbol): Declare.
1034         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
1035         decl.
1036
1037 2020-04-23  Tom Tromey  <tromey@adacore.com>
1038
1039         PR ada/25837:
1040         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
1041         "const char *", not a "const std::string &".
1042         <name_and_matcher::operator==>: Update.
1043         * unittests/lookup_name_info-selftests.c: Change type of
1044         "result".
1045
1046 2020-04-23  Tom Tromey  <tom@tromey.com>
1047
1048         * inferior.h (iterate_over_inferiors): Don't declare.
1049         * inferior.c (iterate_over_inferiors): Remove.
1050         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
1051         Remove.
1052         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
1053         use iterate_over_inferiors.
1054         (darwin_resume_inferior_it)
1055         (struct resume_inferior_threads_param)
1056         (darwin_resume_inferior_threads_it): Remove.
1057         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
1058
1059 2020-04-23  Tom de Vries  <tdevries@suse.de>
1060
1061         * blockframe.c (find_pc_partial_function): Use
1062         find_pc_sect_compunit_symtab rather than
1063         objfile->sf->qf->find_pc_sect_compunit_symtab.
1064
1065 2020-04-22  Tom de Vries  <tdevries@suse.de>
1066
1067         PR symtab/25764
1068         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
1069         in psymtabs.
1070
1071 2020-04-22  Tom de Vries  <tdevries@suse.de>
1072
1073         PR symtab/25801
1074         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
1075         symtabs.
1076
1077 2020-04-22  Tom de Vries  <tdevries@suse.de>
1078
1079         PR symtab/25700
1080         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
1081         CU if already created.
1082
1083 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1084
1085         * infrun.c (displaced_step_fixup): Switch to the event_thread
1086         before calling displaced_step_restore, not after.
1087
1088 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
1089
1090         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
1091         its inferior is not recorded by us.
1092         (record_btrace_target_open): Replace call to
1093         all_non_exited_threads () with call to current_inferior
1094         ()->non_exited_threads ().
1095         (record_btrace_target::stop_recording): Likewise.
1096         (record_btrace_target::close): Likewise.
1097         (record_btrace_target::wait): Likewise.
1098         (record_btrace_target::record_stop_replaying): Likewise.
1099
1100 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
1101
1102         * btrace.c (btrace_enable): Throw an error on double enables and
1103         when enabling recording fails.
1104         (btrace_disable): Throw an error if the thread is not recorded.
1105
1106 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
1107
1108         * record-btrace.c (record_btrace_target::fetch_registers): Forward
1109         request if we do not have a thread_info.
1110
1111 2020-04-21  Tom de Vries  <tdevries@suse.de>
1112
1113         PR gdb/25471
1114         * thread.c
1115         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
1116         exception in get_frame_id.
1117
1118 2020-04-20  Tom Tromey  <tromey@adacore.com>
1119
1120         * python/python.c (struct gdbpy_event): Mark move constructor as
1121         noexcept.
1122         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
1123         constructor as noexcept.
1124         * completer.h (struct completion_result): Mark move constructor as
1125         noexcept.
1126         * completer.c (completion_result::completion_result): Use
1127         initialization style.  Don't call reset_match_list.
1128
1129 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
1130
1131         * MAINTAINERS (Write After Approval): Add myself.
1132
1133 2020-04-18  Tom Tromey  <tom@tromey.com>
1134
1135         * windows-tdep.c (init_w32_command_list)
1136         (w32_prefix_command_valid): Restore.
1137         (_initialize_windows_tdep): Call init_w32_command_list.
1138
1139 2020-04-18  Tom Tromey  <tom@tromey.com>
1140
1141         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
1142         * value.c (value_fn_field): Update.
1143         * valops.c (find_function_in_inferior)
1144         (value_allocate_space_in_inferior): Update.
1145         * tui/tui-winsource.c (tui_update_source_windows_with_line):
1146         Update.
1147         * tui/tui-source.c (tui_source_window::set_contents): Update.
1148         * symtab.c (lookup_global_or_static_symbol)
1149         (find_function_start_sal_1, skip_prologue_sal)
1150         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
1151         * symmisc.c (dump_msymbols, dump_symtab_1)
1152         (maintenance_print_one_line_table): Update.
1153         * symfile.c (init_entry_point_info, section_is_mapped)
1154         (list_overlays_command, simple_read_overlay_table)
1155         (simple_overlay_update_1): Update.
1156         * stap-probe.c (handle_stap_probe): Update.
1157         * stabsread.c (dbx_init_float_type, define_symbol)
1158         (read_one_struct_field, read_enum_type, read_range_type): Update.
1159         * source.c (info_line_command): Update.
1160         * python/python.c (gdbpy_source_objfile_script)
1161         (gdbpy_execute_objfile_script): Update.
1162         * python/py-type.c (save_objfile_types): Update.
1163         * python/py-objfile.c (py_free_objfile): Update.
1164         * python/py-inferior.c (python_new_objfile): Update.
1165         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
1166         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
1167         (maintenance_check_psymtabs): Update.
1168         * printcmd.c (info_address_command): Update.
1169         * objfiles.h (struct objfile) <arch>: New method, from
1170         get_objfile_arch.
1171         (get_objfile_arch): Don't declare.
1172         * objfiles.c (get_objfile_arch): Remove.
1173         (filter_overlapping_sections): Update.
1174         * minsyms.c (msymbol_is_function): Update.
1175         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
1176         (output_nondebug_symbol): Update.
1177         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
1178         (mdebug_expand_psymtab): Update.
1179         * machoread.c (macho_add_oso_symfile): Update.
1180         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
1181         Update.
1182         * linux-fork.c (checkpoint_command): Update.
1183         * linespec.c (convert_linespec_to_sals): Update.
1184         * jit.c (finalize_symtab): Update.
1185         * infrun.c (insert_exception_resume_from_probe): Update.
1186         * ia64-tdep.c (ia64_find_unwind_table): Update.
1187         * hppa-tdep.c (internalize_unwinds): Update.
1188         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
1189         Update.
1190         * gcore.c (call_target_sbrk): Update.
1191         * elfread.c (record_minimal_symbol, elf_symtab_read)
1192         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
1193         (elf_gnu_ifunc_resolve_by_got): Update.
1194         * dwarf2/read.c (create_addrmap_from_index)
1195         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1196         (read_debug_names_from_section)
1197         (process_psymtab_comp_unit_reader, add_partial_symbol)
1198         (add_partial_subprogram, process_full_comp_unit)
1199         (read_file_scope, read_func_scope, read_lexical_block_scope)
1200         (read_call_site_scope, dwarf2_ranges_read)
1201         (dwarf2_record_block_ranges, dwarf2_add_field)
1202         (mark_common_block_symbol_computed, read_tag_pointer_type)
1203         (read_tag_string_type, dwarf2_init_float_type)
1204         (dwarf2_init_complex_target_type, read_base_type)
1205         (partial_die_info::read, partial_die_info::read)
1206         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
1207         (dwarf2_fetch_die_loc_sect_off): Update.
1208         * dwarf2/loc.c (dwarf2_find_location_expression)
1209         (class dwarf_evaluate_loc_desc, rw_pieced_value)
1210         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
1211         (dwarf2_loc_desc_get_symbol_read_needs)
1212         (locexpr_describe_location_piece, locexpr_describe_location_1)
1213         (loclist_describe_location): Update.
1214         * dwarf2/index-write.c (write_debug_names): Update.
1215         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
1216         * dtrace-probe.c (dtrace_process_dof): Update.
1217         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
1218         (process_one_symbol): Update.
1219         * ctfread.c (ctf_init_float_type, read_base_type): Update.
1220         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
1221         (coff_read_enum_type): Update.
1222         * cli/cli-cmds.c (edit_command, list_command): Update.
1223         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
1224         * breakpoint.c (create_overlay_event_breakpoint)
1225         (create_longjmp_master_breakpoint)
1226         (create_std_terminate_master_breakpoint)
1227         (create_exception_master_breakpoint, get_sal_arch): Update.
1228         * block.c (block_gdbarch): Update.
1229         * annotate.c (annotate_source_line): Update.
1230
1231 2020-04-17  Tom Tromey  <tromey@adacore.com>
1232
1233         * auto-load.c (show_auto_load_cmd): Remove.
1234         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
1235         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
1236         (maintenance_print_arc_command): Remove.
1237         * tui/tui-win.c (tui_command): Remove.
1238         (tui_get_cmd_list): Use add_basic_prefix_cmd.
1239         * tui/tui-layout.c (tui_layout_command): Remove.
1240         (_initialize_tui_layout): Use add_basic_prefix_cmd.
1241         * python/python.c (user_set_python, user_show_python): Remove.
1242         (_initialize_python): Use add_basic_prefix_cmd,
1243         add_show_prefix_cmd.
1244         * guile/guile.c (set_guile_command, show_guile_command): Remove.
1245         (install_gdb_commands): Use add_basic_prefix_cmd,
1246         add_show_prefix_cmd.
1247         (info_guile_command): Remove.
1248         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
1249         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
1250         add_show_prefix_cmd.
1251         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1252         Remove do_set and do_show parameters.
1253         * cli/cli-style.c (set_style, show_style): Remove.
1254         (_initialize_cli_style): Use add_basic_prefix_cmd,
1255         add_show_prefix_cmd.
1256         (cli_style_option::add_setshow_commands): Remove do_set and
1257         do_show parameters.
1258         (cli_style_option::add_setshow_commands): Use
1259         add_basic_prefix_cmd, add_show_prefix_cmd.
1260         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
1261         (set_style_name): Remove.
1262         * cli/cli-dump.c (dump_command, append_command): Remove.
1263         (srec_dump_command, ihex_dump_command, verilog_dump_command)
1264         (tekhex_dump_command, binary_dump_command)
1265         (binary_append_command): Remove.
1266         (_initialize_cli_dump): Use add_basic_prefix_cmd.
1267         * windows-tdep.c (w32_prefix_command_valid): Remove global.
1268         (init_w32_command_list): Remove; move into ...
1269         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
1270         * valprint.c (set_print, show_print, set_print_raw)
1271         (show_print_raw): Remove.
1272         (_initialize_valprint): Use add_basic_prefix_cmd,
1273         add_show_prefix_cmd.
1274         * typeprint.c (set_print_type, show_print_type): Remove.
1275         (_initialize_typeprint): Use add_basic_prefix_cmd,
1276         add_show_prefix_cmd.
1277         * record.c (set_record_command, show_record_command): Remove.
1278         (_initialize_record): Use add_basic_prefix_cmd,
1279         add_show_prefix_cmd.
1280         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
1281         add_show_prefix_cmd.
1282         (info_command, show_command, set_debug, show_debug): Remove.
1283         * top.h (set_history, show_history): Don't declare.
1284         * top.c (set_history, show_history): Remove.
1285         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
1286         (unset_tdesc_cmd): Remove.
1287         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
1288         add_show_prefix_cmd.
1289         * symtab.c (info_module_command): Remove.
1290         (_initialize_symtab): Use add_basic_prefix_cmd.
1291         * symfile.c (overlay_command): Remove.
1292         (_initialize_symfile): Use add_basic_prefix_cmd.
1293         * sparc64-tdep.c (info_adi_command): Remove.
1294         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
1295         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
1296         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
1297         add_show_prefix_cmd.
1298         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
1299         (_initialize_serial): Use add_basic_prefix_cmd,
1300         add_show_prefix_cmd.
1301         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
1302         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
1303         add_show_prefix_cmd.
1304         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
1305         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
1306         add_show_prefix_cmd.
1307         * riscv-tdep.c (show_riscv_command, set_riscv_command)
1308         (show_debug_riscv_command, set_debug_riscv_command): Remove.
1309         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
1310         add_show_prefix_cmd.
1311         * remote.c (remote_command, set_remote_cmd): Remove.
1312         (_initialize_remote): Use add_basic_prefix_cmd.
1313         * record-full.c (set_record_full_command)
1314         (show_record_full_command): Remove.
1315         (_initialize_record_full): Use add_basic_prefix_cmd,
1316         add_show_prefix_cmd.
1317         * record-btrace.c (cmd_set_record_btrace)
1318         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
1319         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
1320         (cmd_show_record_btrace_pt): Remove.
1321         (_initialize_record_btrace): Use add_basic_prefix_cmd,
1322         add_show_prefix_cmd.
1323         * ravenscar-thread.c (set_ravenscar_command)
1324         (show_ravenscar_command): Remove.
1325         (_initialize_ravenscar): Use add_basic_prefix_cmd,
1326         add_show_prefix_cmd.
1327         * mips-tdep.c (show_mips_command, set_mips_command)
1328         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
1329         add_show_prefix_cmd.
1330         * maint.c (maintenance_command, maintenance_info_command)
1331         (maintenance_check_command, maintenance_print_command)
1332         (maintenance_set_cmd, maintenance_show_cmd): Remove.
1333         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
1334         add_show_prefix_cmd.
1335         (show_per_command_cmd): Remove.
1336         * maint-test-settings.c (maintenance_set_test_settings_cmd):
1337         Remove.
1338         (maintenance_show_test_settings_cmd): Remove.
1339         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
1340         add_show_prefix_cmd.
1341         * maint-test-options.c (maintenance_test_options_command):
1342         Remove.
1343         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
1344         * macrocmd.c (macro_command): Remove
1345         (_initialize_macrocmd): Use add_basic_prefix_cmd.
1346         * language.c (set_check, show_check): Remove.
1347         (_initialize_language): Use add_basic_prefix_cmd,
1348         add_show_prefix_cmd.
1349         * infcmd.c (unset_command): Remove.
1350         (_initialize_infcmd): Use add_basic_prefix_cmd.
1351         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
1352         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
1353         add_show_prefix_cmd.
1354         * go32-nat.c (go32_info_dos_command): Remove.
1355         (_initialize_go32_nat): Use add_basic_prefix_cmd.
1356         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
1357         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
1358         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
1359         (_initialize_frame): Use add_basic_prefix_cmd,
1360         add_show_prefix_cmd.
1361         * dcache.c (set_dcache_command, show_dcache_command): Remove.
1362         (_initialize_dcache): Use add_basic_prefix_cmd,
1363         add_show_prefix_cmd.
1364         * cp-support.c (maint_cplus_command): Remove.
1365         (_initialize_cp_support): Use add_basic_prefix_cmd.
1366         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
1367         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
1368         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
1369         add_basic_prefix_cmd, add_show_prefix_cmd.
1370         * breakpoint.c (save_command): Remove.
1371         (_initialize_breakpoint): Use add_basic_prefix_cmd.
1372         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
1373         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
1374         add_show_prefix_cmd.
1375         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
1376         (set_ada_command, show_ada_command): Remove.
1377         (_initialize_ada_language): Use add_basic_prefix_cmd,
1378         add_show_prefix_cmd.
1379         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
1380
1381 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
1382
1383         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
1384         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
1385
1386 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
1387
1388         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
1389         warning messages.
1390
1391 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
1392
1393         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
1394         import table is not at beginning of .idata section.
1395
1396 2020-04-16  Pedro Alves  <palves@redhat.com>
1397
1398         * inferior.c (delete_inferior): Use delete operator directly
1399         instead of delete_program_space.
1400         * progspace.c (add_program_space): New, factored out from
1401         program_space::program_space.
1402         (remove_program_space): New, factored out from
1403         delete_program_space.
1404         (program_space::program_space): Remove intro comment.  Rewrite.
1405         (program_space::~program_space): Remove intro comment.  Call
1406         remove_program_space.
1407         (delete_program_space): Delete.
1408         * progspace.h (program_space::program_space): Make explicit.  Move
1409         intro comment here, adjusted.
1410         (program_space::~program_space): Move intro comment here,
1411         adjusted.
1412         (delete_program_space): Remove.
1413
1414 2020-04-16  Tom Tromey  <tromey@adacore.com>
1415
1416         * windows-nat.c (windows_nat::handle_access_violation): New
1417         function.
1418         * nat/windows-nat.h (handle_access_violation): Declare.
1419         * nat/windows-nat.c (handle_exception): Move Cygwin code to
1420         windows-nat.c.  Call handle_access_violation.
1421
1422 2020-04-16  Tom de Vries  <tdevries@suse.de>
1423
1424         PR symtab/25791
1425         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
1426         CUs without psymtab.
1427
1428 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
1429
1430         * python/python.c (do_start_initialization): Don't call
1431         PyEval_InitThreads for Python 3.9 and beyond.
1432
1433 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
1434
1435         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
1436         thread functions.
1437         (obsd_nat_target::wait): Likewise.
1438
1439 2020-04-15  Tom Tromey  <tromey@adacore.com>
1440
1441         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
1442         (DEBUG_EXCEPT): Use debug_printf.
1443
1444 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1445
1446         * completer.c (class completion_tracker::completion_hash_entry)
1447         <hash_name>: New member function.
1448         (completion_tracker::discard_completions): New callback to hash a
1449         completion_hash_entry, pass this to htab_create_alloc.
1450
1451 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
1452
1453         * windows-nat.c (windows_make_so): Warn rather than stopping with
1454         an error if realpath() fails.
1455
1456 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
1457
1458         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
1459         (nbsd_nat_target::info_proc): Add do_status.
1460
1461 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
1462             Tom de Vries  <tdevries@suse.de>
1463
1464         PR symtab/25718
1465         * psympriv.h (struct partial_symtab::read_symtab)
1466         (struct partial_symtab::expand_psymtab)
1467         (struct partial_symtab::read_dependencies): Update comments.
1468         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
1469         read_symtab for includer.
1470         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
1471         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
1472         (struct dwarf2_include_psymtab::m_readin): Remove.
1473         (struct dwarf2_include_psymtab::includer): New member function.
1474         (dwarf2_psymtab::expand_psymtab): Assert !readin.
1475
1476 2020-04-14  Tom de Vries  <tdevries@suse.de>
1477
1478         PR symtab/25720
1479         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
1480         with NULL symbol_matcher and lookup_name.
1481         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
1482         and lookup_name.
1483         * dwarf2/read.c (dw2_expand_symtabs_matching)
1484         (dw2_debug_names_expand_symtabs_matching): Same.
1485         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
1486         Make lookup_name a pointer.  Update comment.
1487         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
1488         lookup_name being a pointer.
1489         * symfile.c (expand_symtabs_matching): Same.
1490         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
1491         * linespec.c (iterate_over_all_matching_symtabs): Same.
1492
1493 2020-04-13  Tom Tromey  <tom@tromey.com>
1494
1495         * run-on-main-thread.c: Update include.
1496         * unittests/main-thread-selftests.c: Update include.
1497         * tui/tui-win.c: Update include.
1498         * tui/tui-io.c: Update include.
1499         * tui/tui-interp.c: Update include.
1500         * tui/tui-hooks.c: Update include.
1501         * top.h: Update include.
1502         * top.c: Update include.
1503         * ser-base.c: Update include.
1504         * remote.c: Update include.
1505         * remote-notif.c: Update include.
1506         * remote-fileio.c: Update include.
1507         * record-full.c: Update include.
1508         * record-btrace.c: Update include.
1509         * python/python.c: Update include.
1510         * posix-hdep.c: Update include.
1511         * mingw-hdep.c: Update include.
1512         * mi/mi-main.c: Update include.
1513         * mi/mi-interp.c: Update include.
1514         * main.c: Update include.
1515         * linux-nat.c: Update include.
1516         * interps.c: Update include.
1517         * infrun.c: Update include.
1518         * inf-loop.c: Update include.
1519         * event-top.c: Update include.
1520         * event-loop.c: Move to ../gdbsupport/.
1521         * event-loop.h: Move to ../gdbsupport/.
1522         * async-event.h: Update include.
1523         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
1524
1525 2020-04-13  Tom Tromey  <tom@tromey.com>
1526
1527         * tui/tui-win.c: Include async-event.h.
1528         * remote.c: Include async-event.h.
1529         * remote-notif.c: Include async-event.h.
1530         * record-full.c: Include async-event.h.
1531         * record-btrace.c: Include async-event.h.
1532         * infrun.c: Include async-event.h.
1533         * event-top.c: Include async-event.h.
1534         * event-loop.h: Move some declarations to async-event.h.
1535         * event-loop.c: Don't include ser-event.h or top.h.  Move some
1536         code to async-event.c.
1537         * async-event.h: New file.
1538         * async-event.c: New file.
1539         * Makefile.in (COMMON_SFILES): Add async-event.c.
1540         (HFILES_NO_SRCDIR): Add async-event.h.
1541
1542 2020-04-13  Tom Tromey  <tom@tromey.com>
1543
1544         * utils.c (flush_streams): New function.
1545         * event-loop.c (gdb_wait_for_event): Call flush_streams.
1546
1547 2020-04-13  Tom Tromey  <tom@tromey.com>
1548
1549         * event-loop.c (handle_file_event): Use warning, not
1550         printf_unfiltered.
1551
1552 2020-04-13  Tom Tromey  <tom@tromey.com>
1553
1554         * event-loop.c: Include <chrono>.
1555
1556 2020-04-13  Tom Tromey  <tom@tromey.com>
1557
1558         * gdb_select.h: Move to ../gdbsupport/.
1559         * event-loop.c: Update include path.
1560         * top.c: Update include path.
1561         * ser-base.c: Update include path.
1562         * ui-file.c: Update include path.
1563         * ser-tcp.c: Update include path.
1564         * guile/scm-ports.c: Update include path.
1565         * posix-hdep.c: Update include path.
1566         * ser-unix.c: Update include path.
1567         * gdb_usleep.c: Update include path.
1568         * mingw-hdep.c: Update include path.
1569         * inflow.c: Update include path.
1570         * infrun.c: Update include path.
1571         * event-top.c: Update include path.
1572
1573 2020-04-13  Tom Tromey  <tom@tromey.com>
1574
1575         * configure: Rebuild.
1576         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
1577
1578 2020-04-13  Tom Tromey  <tom@tromey.com>
1579
1580         * event-loop.h (start_event_loop): Don't declare.
1581         * event-loop.c (start_event_loop): Move...
1582         * main.c (start_event_loop): ...here.  Now static.
1583
1584 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
1585
1586         * MAINTAINERS: Update my email address.
1587
1588 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1589
1590         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
1591         IP_ALL.
1592
1593 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1594
1595         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
1596         (nbsd_nat_target::info_proc): Add do_cmdline.
1597
1598 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1599
1600         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
1601         (nbsd_nat_target::info_proc): Add do_cwd.
1602
1603 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1604
1605         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
1606
1607 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
1608
1609         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
1610         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
1611         (nbsd_nat_target::info_proc): New functions.
1612         * nbsd-nat.c (kinfo_get_vmmap): New function.
1613         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
1614         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
1615         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
1616         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
1617         functions.
1618         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
1619         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
1620         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
1621         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
1622         (KINFO_VME_FLAG_GROWS_DOWN): New.
1623
1624 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
1625
1626         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
1627         bit shift.
1628
1629 2020-04-10  Tom Tromey  <tromey@adacore.com>
1630
1631         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
1632
1633 2020-04-10  Tom Tromey  <tromey@adacore.com>
1634
1635         * symtab.c (get_symbol_address, get_msymbol_address): Skip
1636         separate debug files.
1637
1638 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
1639
1640         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
1641         Move to...
1642         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
1643         ... here.
1644         * windows-nat.c (windows_nat_target::get_windows_debug_event):
1645         Check for STATUS_WX86_BREAKPOINT.
1646         (windows_nat_target::wait): Same.
1647
1648 2020-04-10  Tom de Vries  <tdevries@suse.de>
1649
1650         PR cli/25808
1651         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
1652
1653 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
1654
1655         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
1656         (Write After Approval): Remove Tom de Vries.
1657
1658 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1659
1660         revert partially:
1661         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1662
1663         * buildsym.c (record_line): Fix undefined behavior and preserve
1664         lines at eof.
1665
1666 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
1667
1668         * auxv.h (svr4_auxv_parse): New.
1669         * auxv.c (default_auxv_parse): Split into default_auxv_parse
1670         and generic_auxv_parse.
1671         (svr4_auxv_parse): Add.
1672         * obsd-tdep.c: Include "auxv.h".
1673         (obsd_auxv_parse): Remove.
1674         (obsd_init_abi): Remove comment.
1675         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
1676         from `obsd_auxv_parse' to `svr4_auxv_parse'.
1677         * nbsd-tdep.c: Include "auxv.h".
1678         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
1679
1680 2020-04-08  Tom Tromey  <tromey@adacore.com>
1681
1682         * nat/windows-nat.h (last_wait_event): Don't declare.
1683         (wait_for_debug_event): Update comment.
1684         * nat/windows-nat.c (last_wait_event): Now static.
1685
1686 2020-04-08  Tom Tromey  <tromey@adacore.com>
1687
1688         * windows-nat.c (wait_for_debug_event): Move to
1689         nat/windows-nat.c.
1690         * nat/windows-nat.h (wait_for_debug_event): Declare.
1691         * nat/windows-nat.c (wait_for_debug_event): Move from
1692         windows-nat.c.  No longer static.
1693
1694 2020-04-08  Tom Tromey  <tromey@adacore.com>
1695
1696         * windows-nat.c (get_windows_debug_event): Use
1697         fetch_pending_stop.
1698         * nat/windows-nat.h (fetch_pending_stop): Declare.
1699         * nat/windows-nat.c (fetch_pending_stop): New function.
1700
1701 2020-04-08  Tom Tromey  <tromey@adacore.com>
1702
1703         * windows-nat.c (windows_continue): Use matching_pending_stop and
1704         continue_last_debug_event.
1705         * nat/windows-nat.h (matching_pending_stop)
1706         (continue_last_debug_event): Declare.
1707         * nat/windows-nat.c (DEBUG_EVENTS): New define.
1708         (matching_pending_stop, continue_last_debug_event): New
1709         functions.
1710
1711 2020-04-08  Tom Tromey  <tromey@adacore.com>
1712
1713         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
1714         (handle_exception_result): Move to nat/windows-nat.h.
1715         (DEBUG_EXCEPTION_SIMPLE): Remove.
1716         (windows_nat::handle_ms_vc_exception): New function.
1717         (handle_exception): Move to nat/windows-nat.c.
1718         (get_windows_debug_event): Update.
1719         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
1720         nat/windows-nat.c.
1721         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
1722         (handle_exception_result): Move from windows-nat.c.
1723         (handle_exception): Declare.
1724         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
1725         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
1726         windows-nat.c.
1727
1728 2020-04-08  Tom Tromey  <tromey@adacore.com>
1729
1730         * windows-nat.c (exception_count, event_count): Remove.
1731         (handle_exception, get_windows_debug_event)
1732         (do_initial_windows_stuff): Update.
1733
1734 2020-04-08  Tom Tromey  <tromey@adacore.com>
1735
1736         * windows-nat.c (windows_nat::handle_load_dll)
1737         (windows_nat::handle_unload_dll): Rename.  No longer static.
1738         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
1739         Declare.
1740
1741 2020-04-08  Tom Tromey  <tromey@adacore.com>
1742
1743         * complaints.h (stop_whining): Declare at top-level.
1744         (complaint): Don't declare stop_whining.
1745
1746 2020-04-08  Tom Tromey  <tromey@adacore.com>
1747
1748         * windows-nat.c (windows_nat::handle_output_debug_string):
1749         Rename.  No longer static.
1750         * nat/windows-nat.h (handle_output_debug_string): Declare.
1751
1752 2020-04-08  Tom Tromey  <tromey@adacore.com>
1753
1754         * windows-nat.c (current_process_handle, current_process_id)
1755         (main_thread_id, last_sig, current_event, last_wait_event)
1756         (current_windows_thread, desired_stop_thread_id, pending_stops)
1757         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
1758         (display_selectors, fake_create_process)
1759         (get_windows_debug_event): Update.
1760         * nat/windows-nat.h (current_process_handle, current_process_id)
1761         (main_thread_id, last_sig, current_event, last_wait_event)
1762         (current_windows_thread, desired_stop_thread_id, pending_stops)
1763         (struct pending_stop, siginfo_er): Move from windows-nat.c.
1764         * nat/windows-nat.c (current_process_handle, current_process_id)
1765         (main_thread_id, last_sig, current_event, last_wait_event)
1766         (current_windows_thread, desired_stop_thread_id, pending_stops)
1767         (siginfo_er): New globals.  Move from windows-nat.c.
1768
1769 2020-04-08  Tom Tromey  <tromey@adacore.com>
1770
1771         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
1772         (handle_load_dll): Update.
1773         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
1774
1775 2020-04-08  Tom Tromey  <tromey@adacore.com>
1776
1777         * windows-nat.c (enum thread_disposition_type): Move to
1778         nat/windows-nat.h.
1779         (windows_nat::thread_rec): Rename from thread_rec.  No longer
1780         static.
1781         (windows_add_thread, windows_nat_target::fetch_registers)
1782         (windows_nat_target::store_registers, handle_exception)
1783         (windows_nat_target::resume, get_windows_debug_event)
1784         (windows_nat_target::get_tib_address)
1785         (windows_nat_target::thread_name)
1786         (windows_nat_target::thread_alive): Update.
1787         * nat/windows-nat.h (enum thread_disposition_type): Move from
1788         windows-nat.c.
1789         (thread_rec): Declare.
1790
1791 2020-04-08  Tom Tromey  <tromey@adacore.com>
1792
1793         * windows-nat.c: Add "using namespace".
1794         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
1795         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
1796
1797 2020-04-08  Tom Tromey  <tromey@adacore.com>
1798
1799         * nat/windows-nat.h (struct windows_thread_info): Declare
1800         destructor.
1801         * nat/windows-nat.c (~windows_thread_info): New.
1802
1803 2020-04-08  Tom Tromey  <tromey@adacore.com>
1804
1805         PR gdb/22992
1806         * windows-nat.c (current_event): Update comment.
1807         (last_wait_event, desired_stop_thread_id): New globals.
1808         (struct pending_stop): New.
1809         (pending_stops): New global.
1810         (windows_nat_target) <stopped_by_sw_breakpoint>
1811         <supports_stopped_by_sw_breakpoint>: New methods.
1812         (windows_fetch_one_register): Add assertions.  Adjust PC.
1813         (windows_continue): Handle pending stops.  Suspend other threads
1814         when stepping.  Use last_wait_event
1815         (wait_for_debug_event): New function.
1816         (get_windows_debug_event): Use wait_for_debug_event.  Handle
1817         pending stops.  Queue spurious stops.
1818         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
1819         (windows_nat_target::kill): Use wait_for_debug_event.
1820         * nat/windows-nat.h (struct windows_thread_info)
1821         <stopped_at_software_breakpoint>: New field.
1822         * nat/windows-nat.c (windows_thread_info::resume): Clear
1823         stopped_at_software_breakpoint.
1824
1825 2020-04-08  Tom Tromey  <tromey@adacore.com>
1826
1827         * windows-nat.c (enum thread_disposition_type): New.
1828         (thread_rec): Replace "get_context" parameter with "disposition";
1829         change type.
1830         (windows_add_thread, windows_nat_target::fetch_registers)
1831         (windows_nat_target::store_registers, handle_exception)
1832         (windows_nat_target::resume, get_windows_debug_event)
1833         (windows_nat_target::get_tib_address)
1834         (windows_nat_target::thread_name)
1835         (windows_nat_target::thread_alive): Update.
1836
1837 2020-04-08  Tom Tromey  <tromey@adacore.com>
1838
1839         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
1840         (windows_continue): Use windows_continue::resume.
1841         * nat/windows-nat.h (struct windows_thread_info) <suspend,
1842         resume>: Declare new methods.
1843         * nat/windows-nat.c: New file.
1844         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
1845
1846 2020-04-08  Tom Tromey  <tromey@adacore.com>
1847
1848         * windows-nat.c (windows_add_thread, windows_delete_thread)
1849         (windows_nat_target::fetch_registers)
1850         (windows_nat_target::store_registers, fake_create_process)
1851         (windows_nat_target::resume, windows_nat_target::resume)
1852         (get_windows_debug_event, windows_nat_target::wait)
1853         (windows_nat_target::pid_to_str)
1854         (windows_nat_target::get_tib_address)
1855         (windows_nat_target::get_ada_task_ptid)
1856         (windows_nat_target::thread_name)
1857         (windows_nat_target::thread_alive): Use lwp, not tid.
1858
1859 2020-04-08  Tom Tromey  <tromey@adacore.com>
1860
1861         * windows-nat.c (handle_exception)
1862         (windows_nat_target::thread_name): Update.
1863         * nat/windows-nat.h (windows_thread_info): Remove destructor.
1864         <name>: Now unique_xmalloc_ptr.
1865
1866 2020-04-08  Tom Tromey  <tromey@adacore.com>
1867
1868         * windows-nat.c (thread_rec)
1869         (windows_nat_target::fetch_registers): Update.
1870         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
1871         Update comment.
1872         <debug_registers_changed, reload_context>: Now bool.
1873
1874 2020-04-08  Tom Tromey  <tromey@adacore.com>
1875
1876         * windows-nat.c (windows_add_thread): Use new.
1877         (windows_init_thread_list, windows_delete_thread): Use delete.
1878         (get_windows_debug_event): Update.
1879         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
1880         destructor, and initializers.
1881
1882 2020-04-08  Tom Tromey  <tromey@adacore.com>
1883
1884         * windows-nat.c (struct windows_thread_info): Remove.
1885         * nat/windows-nat.h: New file.
1886
1887 2020-04-08  Tom Tromey  <tromey@adacore.com>
1888
1889         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
1890         (thread_rec, windows_add_thread, windows_delete_thread)
1891         (windows_continue): Update.
1892
1893 2020-04-08  Tom Tromey  <tromey@adacore.com>
1894
1895         * windows-nat.c (struct windows_thread_info): Remove typedef.
1896         (thread_head): Remove.
1897         (thread_list): New global.
1898         (thread_rec, windows_add_thread, windows_init_thread_list)
1899         (windows_delete_thread, windows_continue): Update.
1900
1901 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1902
1903         * windows-tdep.h (windows_init_abi): Add comment.
1904         (cygwin_init_abi): New declaration.
1905         * windows-tdep.c: Split signal enumeration in two, one for
1906         Windows and one for Cygwin.
1907         (windows_gdb_signal_to_target): Only deal with signal of the
1908         Windows OS ABI.
1909         (cygwin_gdb_signal_to_target): New function.
1910         (windows_init_abi): Rename to windows_init_abi_common, don't set
1911         gdb_signal_to_target gdbarch method.  Add new new function with
1912         this name.
1913         (cygwin_init_abi): New function.
1914         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
1915         comment.  Don't call windows_init_abi.
1916         (amd64_windows_init_abi): Add comment, call windows_init_abi.
1917         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
1918         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
1919         i386_windows_init_abi_common, don't call windows_init_abi.  Add
1920         a new function of this name.
1921         (i386_cygwin_init_abi): New function.
1922         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
1923         OS ABI Cygwin.
1924
1925 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1926
1927         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
1928         parameter.c.
1929         (dwarf2_read_gdb_index): Update.
1930
1931 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
1932
1933         * nbsd-tdep.c: Include "objfiles.h".
1934         (nbsd_skip_solib_resolver): New.
1935         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
1936
1937 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1938
1939         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
1940         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
1941         with DW_LLE_base_addressx are being emitted in DWARFv5.
1942         Add the newly added kind DW_LOC_OFFSET_PAIR also.
1943         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
1944         unsigned integer.
1945
1946 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1947
1948         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
1949         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
1950         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
1951         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
1952         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
1953         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
1954         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
1955
1956
1957 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1958
1959         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
1960         (read_loclist_index): New function definition.
1961         (lookup_loclist_base): New function definition.
1962         (read_loclist_header): New function definition.
1963         (dwarf2_cu): Add loclist_base and loclist_header field.
1964         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
1965         (read_full_die_1): Read the value of DW_AT_loclists_base.
1966         (read_attribute_reprocess): Handle DW_FORM_loclistx.
1967         (read_attribute_value): Handle DW_FORM_loclistx.
1968         (skip_one_die): Handle DW_FORM_loclistx.
1969         (loclist_header): New structure declaration.
1970         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
1971
1972 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
1973
1974         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
1975         constructor.  Remove `addr` parameter from other constructor and
1976         add `per_cu` parameter.
1977         * dwarf2/read.c (create_partial_symtab): Update.
1978
1979 2020-04-07  Tom de Vries  <tdevries@suse.de>
1980
1981         PR symtab/25796
1982         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
1983         (partial_die_info::fixup): Inherit has_const_value.
1984
1985 2020-04-07  Tom de Vries  <tdevries@suse.de>
1986
1987         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
1988         symbols without address.
1989
1990 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1991
1992         * nbsd-nat.h (struct thread_info): Add forward declaration.
1993         (nbsd_nat_target::thread_alive): Add.
1994         (nbsd_nat_target::thread_name): Likewise.
1995         (nbsd_nat_target::update_thread_list): Likewise.
1996         (update_thread_list::post_attach): Likewise.
1997         (post_attach::pid_to_str): Likewise.
1998         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
1999         (nbsd_thread_lister): Add.
2000         (nbsd_nat_target::thread_alive): Likewise.
2001         (nbsd_nat_target::thread_name): Likewise.
2002         (nbsd_add_threads): Likewise.
2003         (update_thread_list::post_attach): Likewise.
2004         (nbsd_nat_target::update_thread_list): Likewise.
2005         (post_attach::pid_to_str): Likewise.
2006
2007 2020-04-06  Tom Tromey  <tromey@adacore.com>
2008
2009         * ada-valprint.c (print_variant_part): Extract the variant field.
2010         (print_field_values): Use the field as the outer value when
2011         recursing.
2012
2013 2020-04-06  Tom Tromey  <tromey@adacore.com>
2014
2015         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
2016         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
2017         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
2018         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
2019         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
2020
2021 2020-04-06  Tom Tromey  <tromey@adacore.com>
2022
2023         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
2024         TYPE_CODE_ERROR.
2025
2026 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
2027
2028         * nbsd-tdep.c: Include "gdbarch.h".
2029         Define enum with NetBSD signal numbers.
2030         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
2031         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
2032         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
2033         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
2034         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
2035         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
2036         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
2037         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
2038         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
2039         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
2040         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
2041         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
2042
2043 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
2044
2045         PR gdb/25325
2046         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
2047
2048 2020-04-03  Tom Tromey  <tromey@adacore.com>
2049
2050         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
2051         Read constant block.
2052
2053 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
2054
2055         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
2056         (gdb_bfd_get_full_section_contents): New declaration.
2057         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
2058         * windows-tdep.c (is_linked_with_cygwin_dll): Use
2059         gdb_bfd_get_full_section_contents.
2060
2061 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
2062
2063         * exec.c (build_section_table): Replace internal_error with
2064         gdb_assert.
2065         (section_table_xfer_memory_partial): Likewise.
2066         * mdebugread.c (parse_partial_symbols): Likewise.
2067         * psymtab.c (lookup_partial_symbol): Likewise.
2068         * utils.c (wrap_here): Likewise.
2069
2070 2020-04-02  Tom Tromey  <tromey@adacore.com>
2071
2072         * f-lang.c (build_fortran_types): Use arch_type to initialize
2073         builtin_complex_s32 in the TYPE_CODE_ERROR case.
2074
2075 2020-04-02  Tom Tromey  <tromey@adacore.com>
2076
2077         * dwarf2/read.c (partial_die_info::read): Do not create a vector
2078         of attributes.
2079
2080 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2081             Bernd Edlinger <bernd.edlinger@hotmail.de>
2082             Tom Tromey  <tromey@adacore.com>
2083
2084         * buildsym.c (buildsym_compunit::record_line): Remove
2085         deduplication code.
2086
2087 2020-04-02  Tom de Vries  <tdevries@suse.de>
2088
2089         PR ada/24671
2090         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
2091
2092 2020-04-02  Tom de Vries  <tdevries@suse.de>
2093
2094         * dwarf2/read.c (dwarf2_gdb_index_functions,
2095         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
2096         NULL.
2097         * psymtab.c (psym_lookup_global_symbol_language): New function.
2098         (psym_functions): Init psym_lookup_global_symbol_language with
2099         psym_lookup_global_symbol_language.
2100         * symfile-debug.c (debug_sym_quick_functions): Init
2101         lookup_global_symbol_language with NULL.
2102         * symfile.c (set_initial_language): Remove fixme comment.
2103         * symfile.h (struct quick_symbol_functions): Add
2104         lookup_global_symbol_language.
2105         * symtab.c (find_quick_global_symbol_language): New function.
2106         (find_main_name): Use find_quick_global_symbol_language.
2107
2108 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
2109
2110         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
2111
2112 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2113
2114         * buildsym.c (record_line): Fix undefined behavior and preserve
2115         lines at eof.
2116
2117 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2118
2119         * buildsym.c (record_line): Fix the resizing condition.
2120
2121 2020-04-01  Tom Tromey  <tom@tromey.com>
2122
2123         * value.h (value_literal_complex): Add comment.
2124         * valops.c (value_literal_complex): Refer to value.h.
2125
2126 2020-04-01  Tom Tromey  <tom@tromey.com>
2127
2128         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
2129         (scalar_type): New rule, from typebase.
2130         (typebase): Use scalar_type.  Recognize complex types.
2131         (field_name): Handle FLOAT_KEYWORD.
2132         (ident_tokens): Add _Complex and __complex__.
2133
2134 2020-04-01  Tom Tromey  <tom@tromey.com>
2135
2136         PR exp/25299:
2137         * valarith.c (promotion_type, complex_binop): New functions.
2138         (scalar_binop): Handle complex numbers.  Use promotion_type.
2139         (value_pos, value_neg, value_complement): Handle complex numbers.
2140
2141 2020-04-01  Tom Tromey  <tom@tromey.com>
2142
2143         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
2144         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
2145         (parse_number): Handle complex numbers.
2146
2147 2020-04-01  Tom Tromey  <tom@tromey.com>
2148
2149         * c-valprint.c (c_decorations): Change complex suffix to "i".
2150
2151 2020-04-01  Tom Tromey  <tom@tromey.com>
2152
2153         * valprint.c (generic_value_print_complex): Use accessors.
2154         * value.h (value_real_part, value_imaginary_part): Declare.
2155         * valops.c (value_real_part, value_imaginary_part): New
2156         functions.
2157         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
2158
2159 2020-04-01  Tom Tromey  <tom@tromey.com>
2160
2161         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
2162         (read_range_type): Update.
2163         * mdebugread.c (basic_type): Update.
2164         * go-lang.c (build_go_types): Use init_complex_type.
2165         * gdbtypes.h (struct main_type) <complex_type>: New member.
2166         (init_complex_type): Update.
2167         (arch_complex_type): Don't declare.
2168         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
2169         Make name if none given.  Use alloc_type_copy.  Look for cached
2170         complex type.
2171         (arch_complex_type): Remove.
2172         (gdbtypes_post_init): Use init_complex_type.
2173         * f-lang.c (build_fortran_types): Use init_complex_type.
2174         * dwarf2/read.c (read_base_type): Update.
2175         * d-lang.c (build_d_types): Use init_complex_type.
2176         * ctfread.c (read_base_type): Update.
2177
2178 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2179
2180         * infrun.c (stop_all_threads): Update assertion, plus when
2181         stopping threads, take into account that we might be trying
2182         to stop an all-stop target.
2183         (stop_waiting): Call 'stop_all_threads' if there exists a
2184         non-stop target.
2185
2186 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2187
2188         * target.h (exists_non_stop_target): New function declaration.
2189         * target.c (exists_non_stop_target): New function.
2190
2191 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
2192
2193         PR gdb/24789
2194         * eval.c (is_integral_or_integral_reference): New function.
2195         (evaluate_subexp_standard): Allow integer references in
2196         pointer arithmetic.
2197
2198 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2199
2200         * remote.c (remote_target::remote_parse_stop_reply): Remove the
2201         check for no ptid in the stop reply when the target is non-stop.
2202
2203 2020-04-01  Tom Tromey  <tromey@adacore.com>
2204
2205         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
2206         "name" parameter to rvalue reference.  Initialize m_name_holder.
2207         <lookup_name_info>: New overloads.
2208         <name>: Return gdb::string_view.
2209         <c_str>: New method.
2210         <make_ignore_params>: Update.
2211         <search_name_hash>: Update.
2212         <language_lookup_name>: Return const char *.
2213         <m_name>: Change type.
2214         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
2215         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
2216         (lookup_name_info::match_any): Update.
2217         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
2218         Update.
2219         * minsyms.c (linkage_name_str): Update.
2220         * language.c (default_symbol_name_matcher): Update.
2221         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
2222         Update.
2223         * ada-lang.c (ada_fold_name): Change parameter to string_view.
2224         (ada_lookup_name_info::ada_lookup_name_info): Update.
2225         (literal_symbol_name_matcher): Update.
2226
2227 2020-04-01  Tom Tromey  <tromey@adacore.com>
2228
2229         * psymtab.c (psymtab_search_name): Remove function.
2230         (psym_lookup_symbol): Create search name and lookup name here.
2231         (lookup_partial_symbol): Remove "name" parameter; add
2232         lookup_name.
2233         (psym_expand_symtabs_for_function): Update.
2234
2235 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
2236
2237         PR tui/25597:
2238         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
2239
2240 2020-03-31  Tom Tromey  <tromey@adacore.com>
2241
2242         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
2243         memcpy.
2244
2245 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
2246
2247         * features/riscv/32bit-csr.xml: Regenerated.
2248         * features/riscv/64bit-csr.xml: Regenerated.
2249
2250 2020-03-30  Tom Tromey  <tromey@adacore.com>
2251
2252         * ada-valprint.c (print_variant_part): Update.
2253         * ada-lang.h (ada_which_variant_applies): Update.
2254         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
2255         outer_valaddr parameters; replace with "outer" value parameter.
2256         (to_fixed_variant_branch_type): Update.
2257
2258 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2259
2260         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
2261         <list>.  Remove inclusion of observable.h.
2262         (PPC_DEBUG_CURRENT_VERSION): Move up define.
2263         (struct arch_lwp_info): New struct.
2264         (class ppc_linux_dreg_interface): New class.
2265         (struct ppc_linux_process_info): New struct.
2266         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
2267         <low_new_clone, low_forget_process, low_prepare_to_resume>
2268         <copy_thread_dreg_state, mark_thread_stale>
2269         <mark_debug_registers_changed, register_hw_breakpoint>
2270         <clear_hw_breakpoint, register_wp, clear_wp>
2271         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
2272         <num_memory_accesses, get_trigger_type>
2273         <create_watchpoint_request, hwdebug_point_cmp>
2274         <init_arch_lwp_info, get_arch_lwp_info>
2275         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
2276         methods.
2277         <struct ptid_hash>: New inner struct.
2278         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
2279         members.
2280         (saved_dabr_value, hwdebug_info, max_slots_number)
2281         (struct hw_break_tuple, struct thread_points, ppc_threads)
2282         (have_ptrace_hwdebug_interface)
2283         (hwdebug_find_thread_points_by_tid)
2284         (hwdebug_insert_point, hwdebug_remove_point): Remove.
2285         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
2286         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
2287         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
2288         use m_dreg_interface.
2289         (hwdebug_point_cmp): Change to...
2290         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
2291         reference arguments instead of pointers.
2292         (ppc_linux_nat_target::ranged_break_num_registers): Use
2293         m_dreg_interface.
2294         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
2295         m_dreg_interface.  Call register_hw_breakpoint.
2296         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
2297         m_dreg_interface.  Call clear_hw_breakpoint.
2298         (get_trigger_type): Change to...
2299         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
2300         comment.
2301         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
2302         use m_dreg_interface.  Call register_hw_breakpoint.
2303         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
2304         use m_dreg_interface.  Call clear_hw_breakpoint.
2305         (can_use_watchpoint_cond_accel): Change to...
2306         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
2307         method.  Update comment, use m_dreg_interface and
2308         m_process_info.
2309         (calculate_dvc): Change to...
2310         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
2311         m_dreg_interface.
2312         (num_memory_accesses): Change to...
2313         (ppc_linux_nat_target::num_memory_accesses): ...this method.
2314         (check_condition): Change to...
2315         (ppc_linux_nat_target::check_condition): ...this method.
2316         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
2317         comment, use m_dreg_interface.
2318         (create_watchpoint_request): Change to...
2319         (ppc_linux_nat_target::create_watchpoint_request): ...this
2320         method.  Use m_dreg_interface.
2321         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
2322         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
2323         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
2324         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
2325         (ppc_linux_nat_target::low_forget_process)
2326         (ppc_linux_nat_target::low_new_fork)
2327         (ppc_linux_nat_target::low_new_clone)
2328         (ppc_linux_nat_target::low_delete_thread)
2329         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
2330         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
2331         only call mark_thread_stale.
2332         (ppc_linux_thread_exit): Remove.
2333         (ppc_linux_nat_target::stopped_data_address): Change to...
2334         (ppc_linux_nat_target::low_stopped_data_address): This. Add
2335         comment, use m_dreg_interface and m_thread_hw_breakpoints.
2336         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
2337         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
2338         comment.  Call low_stopped_data_address.
2339         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
2340         m_dreg_interface.
2341         (ppc_linux_nat_target::masked_watch_num_registers): Use
2342         m_dreg_interface.
2343         (ppc_linux_nat_target::copy_thread_dreg_state)
2344         (ppc_linux_nat_target::mark_thread_stale)
2345         (ppc_linux_nat_target::mark_debug_registers_changed)
2346         (ppc_linux_nat_target::register_hw_breakpoint)
2347         (ppc_linux_nat_target::clear_hw_breakpoint)
2348         (ppc_linux_nat_target::register_wp)
2349         (ppc_linux_nat_target::clear_wp)
2350         (ppc_linux_nat_target::init_arch_lwp_info)
2351         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
2352         (_initialize_ppc_linux_nat): Remove observer callback.
2353
2354 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2355
2356         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
2357         (ppc_linux_nat_target::auxv_parse)
2358         (ppc_linux_nat_target::read_description)
2359         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
2360         Move up.
2361
2362 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2363
2364         * linux-nat.h (low_new_clone): New method.
2365         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
2366
2367 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
2368
2369         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
2370         (dbx_expand_psymtab): ... this.
2371         (start_psymtab): Update.
2372         * mdebugread.c (psymtab_to_symtab_1): Rename to...
2373         (mdebug_expand_psymtab): ... this.
2374         (parse_partial_symbols): Update.
2375         (new_psymtab): Update.
2376         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
2377         (xcoff_expand_psymtab): ... this.
2378         (xcoff_start_psymtab): Update.
2379
2380 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
2381
2382         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
2383         <expand_dependencies>: ... this.
2384         * psymtab.c (partial_symtab::read_dependencies): Rename to...
2385         (partial_symtab::expand_dependencies): ... this.
2386         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
2387         Update.
2388         (dwarf2_psymtab::expand_psymtab): Update.
2389         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
2390         * mdebugread.c (psymtab_to_symtab_1): Update.
2391         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
2392
2393 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
2394
2395         * psympriv.h (discard_psymtab): Remove.
2396         * dbxread.c (dbx_end_psymtab): Update.
2397         * xcoffread.c (xcoff_end_psymtab): Update.
2398
2399 2020-03-28  Tom Tromey  <tom@tromey.com>
2400
2401         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
2402         comment.
2403
2404 2020-03-28  Tom Tromey  <tom@tromey.com>
2405
2406         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
2407
2408 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
2409
2410         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
2411
2412 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
2413
2414         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
2415
2416 2020-03-26  Tom Tromey  <tom@tromey.com>
2417
2418         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
2419         (mark_common_block_symbol_computed, read_tag_string_type)
2420         (attr_to_dynamic_prop, read_subrange_type): Update.
2421         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
2422         to be methods on struct attribute.
2423         (skip_one_die, process_imported_unit_die, read_namespace_alias)
2424         (read_call_site_scope, partial_die_info::read)
2425         (partial_die_info::read, lookup_die_type, follow_die_ref):
2426         Update.
2427         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
2428         from dwarf2_get_ref_die_offset.
2429         (attribute::constant_value): New method, from
2430         dwarf2_get_attr_constant_value.
2431         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
2432         Declare method.
2433         <constant_value>: New method.
2434
2435 2020-03-26  Tom Tromey  <tom@tromey.com>
2436
2437         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
2438         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
2439         (dwarf_type_encoding_name): Move to stringify.c.
2440         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
2441         * dwarf2/stringify.c: New file.
2442         * dwarf2/stringify.h: New file.
2443
2444 2020-03-26  Tom Tromey  <tom@tromey.com>
2445
2446         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
2447         Rewrite.
2448
2449 2020-03-26  Tom Tromey  <tom@tromey.com>
2450
2451         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
2452         methods.
2453         * dwarf2/read.c (lookup_addr_base): Move to die.h.
2454         (lookup_ranges_base): Likewise.
2455         (read_cutu_die_from_dwo, read_full_die_1): Update.
2456
2457 2020-03-26  Tom Tromey  <tom@tromey.com>
2458
2459         * dwarf2/read.c (read_import_statement, read_file_scope)
2460         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
2461         (read_lexical_block_scope, read_call_site_scope)
2462         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
2463         (handle_struct_member_die, process_structure_scope)
2464         (update_enumeration_type_from_children)
2465         (process_enumeration_scope, read_array_type, read_common_block)
2466         (read_namespace, read_module, read_subroutine_type): Update.
2467         (sibling_die): Remove.
2468
2469 2020-03-26  Tom Tromey  <tom@tromey.com>
2470
2471         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
2472         (build_type_psymtabs_reader, read_structure_type)
2473         (read_enumeration_type, read_full_die_1): Update.
2474         (dwarf2_attr_no_follow): Move to die.h.
2475         * dwarf2/die.h (struct die_info) <attr>: New method.
2476
2477 2020-03-26  Tom Tromey  <tom@tromey.com>
2478
2479         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
2480         <base_address>: Now an optional.
2481         (dwarf2_find_base_address, dwarf2_rnglists_process)
2482         (dwarf2_ranges_process, fill_in_loclist_baton)
2483         (dwarf2_symbol_mark_computed): Update.
2484
2485 2020-03-26  Tom Tromey  <tom@tromey.com>
2486
2487         * dwarf2/read.c (struct die_info): Move to die.h.
2488         * dwarf2/die.h: New file.
2489
2490 2020-03-26  Tom Tromey  <tom@tromey.com>
2491
2492         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
2493         * dwarf2/read.c
2494         (dwarf2_statement_list_fits_in_line_number_section_complaint):
2495         Move to line-header.c.
2496         (read_checked_initial_length_and_offset, read_formatted_entries):
2497         Likewise.
2498         (dwarf_decode_line_header): Split into two.
2499         * dwarf2/line-header.c
2500         (dwarf2_statement_list_fits_in_line_number_section_complaint):
2501         Move from read.c.
2502         (read_checked_initial_length_and_offset, read_formatted_entries):
2503         Likewise.
2504         (dwarf_decode_line_header): New function, split from read.c.
2505
2506 2020-03-26  Tom Tromey  <tom@tromey.com>
2507
2508         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
2509         Declare method.
2510         * dwarf2/read.c (read_attribute_value): Update.
2511         (dwarf2_per_objfile::read_line_string): Rename from
2512         read_indirect_line_string.
2513         (read_formatted_entries): Update.
2514
2515 2020-03-26  Tom Tromey  <tom@tromey.com>
2516
2517         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
2518         variable.
2519
2520 2020-03-26  Tom Tromey  <tom@tromey.com>
2521
2522         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
2523         const.
2524         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
2525         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
2526         parameter const.
2527
2528 2020-03-26  Tom Tromey  <tom@tromey.com>
2529
2530         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
2531         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
2532         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
2533         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
2534
2535 2020-03-26  Tom Tromey  <tom@tromey.com>
2536
2537         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
2538         file_names_size, file_full_name, file_file_name>: Use const.
2539         <file_name_at, file_names>: Add const overload.
2540         * dwarf2/line-header.c (line_header::file_file_name)
2541         (line_header::file_full_name): Update.
2542
2543 2020-03-26  Tom Tromey  <tom@tromey.com>
2544
2545         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
2546         (macro_start_file, consume_improper_spaces)
2547         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
2548         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
2549         (dwarf_decode_macros): Move to macro.c.
2550         * dwarf2/macro.c: New file.
2551         * dwarf2/macro.h: New file.
2552         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
2553
2554 2020-03-26  Tom Tromey  <tom@tromey.com>
2555
2556         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
2557         method.
2558         * dwarf2/section.c: New method.  From
2559         read_indirect_string_at_offset_from.
2560         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
2561         (read_indirect_string_at_offset_from): Move to section.c.
2562         (read_indirect_string_at_offset): Rewrite.
2563         (read_indirect_line_string_at_offset): Remove.
2564         (read_indirect_string, read_indirect_line_string)
2565         (dwarf_decode_macro_bytes): Update.
2566
2567 2020-03-26  Tom Tromey  <tom@tromey.com>
2568
2569         * dwarf2/section.h (struct dwarf2_section_info)
2570         <overload_complaint>: Declare.
2571         (dwarf2_section_buffer_overflow_complaint): Don't declare.
2572         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
2573         Rename from dwarf2_section_buffer_overflow_complaint.
2574         * dwarf2/read.c (skip_one_die, partial_die_info::read)
2575         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
2576
2577 2020-03-26  Tom Tromey  <tom@tromey.com>
2578
2579         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
2580         Declare.
2581         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
2582         Move from read.c.
2583         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
2584         to section.c.
2585
2586 2020-03-26  Tom Tromey  <tom@tromey.com>
2587
2588         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
2589
2590 2020-03-26  Tom Tromey  <tom@tromey.com>
2591
2592         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
2593         "builder".
2594         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
2595         parameter.
2596         (dwarf_decode_macros): Update.
2597
2598 2020-03-26  Tom Tromey  <tom@tromey.com>
2599
2600         * dwarf2/read.c (read_attribute_value): Update.
2601         (read_indirect_string_from_dwz): Move to dwz.c; change into
2602         method.
2603         (dwarf_decode_macro_bytes): Update.
2604         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
2605         * dwarf2/dwz.c: New file.
2606         * Makefile.in (COMMON_SFILES): Add dwz.c.
2607
2608 2020-03-26  Tom Tromey  <tom@tromey.com>
2609
2610         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
2611         * dwarf2/read.c: Add include.
2612         * dwarf2/index-write.c: Add include.
2613         * dwarf2/index-cache.c: Add include.
2614         * dwarf2/dwz.h: New file.
2615
2616 2020-03-25  Tom Tromey  <tom@tromey.com>
2617
2618         * compile/compile-object-load.c (get_out_value_type): Mention
2619         correct symbol name in error message.
2620
2621 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
2622
2623         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
2624
2625 2020-03-25  Tom de Vries  <tdevries@suse.de>
2626
2627         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
2628         * symmisc.c (dump_symtab_1): Print user and includes fields.
2629         (maintenance_info_symtabs): Same.
2630
2631 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2632
2633         PR gdb/25534
2634         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
2635         (riscv_regcache_cooked_write): New function.
2636         (riscv_push_dummy_call): Use new function.
2637         (riscv_return_value): Likewise.
2638
2639 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
2640
2641         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
2642         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
2643         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
2644         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
2645         * infrun.c (follow_fork): Likewise.
2646         (follow_fork_inferior): Likewise.
2647         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
2648         * linux-nat.h (class linux_nat_target): Likewise.
2649         * remote.c (class remote_target) <follow_fork>: Likewise.
2650         (remote_target::follow_fork): Likewise.
2651         * target-delegates.c: Re-generate.
2652         * target.c (default_follow_fork): Likewise.
2653         (target_follow_fork): Likewise.
2654         * target.h (struct target_ops) <follow_fork>: Likewise.
2655         (target_follow_fork): Likewise.
2656
2657 2020-03-24  Tom de Vries  <tdevries@suse.de>
2658
2659         * psymtab.c (maintenance_info_psymtabs): Print user field.
2660
2661 2020-03-20  Tom Tromey  <tromey@adacore.com>
2662
2663         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
2664         const.
2665         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
2666         const.
2667
2668 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
2669
2670         * ptrace.m4: Don't check for ptrace declaration.
2671         * config.in: Re-generate.
2672         * configure: Re-generate.
2673         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
2674         not defined.
2675
2676 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2677
2678         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
2679         `PTRACE_TYPE_RET'.
2680         * i386-bsd-nat.c (gdb_ptrace): Likewise.
2681         * sparc-nat.c (gdb_ptrace): Likewise.
2682         * x86-bsd-nat.c (gdb_ptrace): Likewise.
2683
2684 2020-03-20  Tom Tromey  <tromey@adacore.com>
2685
2686         * c-exp.y (lex_one_token): Fix assert.
2687
2688 2020-03-20  Tom Tromey  <tromey@adacore.com>
2689
2690         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
2691         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
2692         strncpy call.
2693
2694 2020-03-20  Tom Tromey  <tromey@adacore.com>
2695
2696         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
2697
2698 2020-03-20  Tom Tromey  <tromey@adacore.com>
2699
2700         * ada-valprint.c (print_variant_part): Remove parameters; switch
2701         to value-based API.
2702         (print_field_values): Likewise.
2703         (ada_val_print_struct_union): Likewise.
2704         (ada_value_print_1): Update.
2705
2706 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2707
2708         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
2709         nbsd_nat_target instead of inf_ptrace_target.
2710         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2711         nbsd_nat_target.
2712
2713 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2714
2715         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
2716         it to the ptrace call.
2717         * (store_registers): Likewise.
2718
2719 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2720
2721         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
2722         it to the ptrace call.
2723         * (store_registers): Likewise.
2724
2725 2020-03-19  Luis Machado  <luis.machado@linaro.org>
2726
2727         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
2728         valid, fetch vg value from ptrace.
2729
2730 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2731         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
2732         * inf-ptrace.c: Likewise.
2733         * (gdb_ptrace): Add.
2734         * (inf_ptrace_target::resume): Update.
2735         * (inf_ptrace_target::xfer_partial): Likewise.
2736         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
2737         * (inf_ptrace_peek_poke): Update.
2738
2739 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2740
2741         * x86-bsd-nat.c (gdb_ptrace): New.
2742         * (x86bsd_dr_set): Add new argument `ptid'.
2743         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
2744         x86bsd_dr_set_addr): Update.
2745
2746 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2747
2748         * remote.c (remote_target::process_stop_reply): Handle events for
2749         all threads differently.
2750
2751 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2752
2753         * completer.c (completion_tracker::remove_completion): Define new
2754         function.
2755         * completer.h (completion_tracker::remove_completion): Declare new
2756         function.
2757         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
2758         when adding a C++ function symbol.
2759
2760 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2761
2762         * completer.c (completion_tracker::completion_hash_entry): Define
2763         new class.
2764         (advance_to_filename_complete_word_point): Call
2765         recompute_lowest_common_denominator.
2766         (completion_tracker::completion_tracker): Call discard_completions
2767         to setup the hash table.
2768         (completion_tracker::discard_completions): Allow for being called
2769         from the constructor, pass new equal function, and element deleter
2770         when constructing the hash table.  Initialise new class member
2771         variables.
2772         (completion_tracker::maybe_add_completion): Remove use of
2773         m_entries_vec, and store more information into m_entries_hash.
2774         (completion_tracker::recompute_lcd_visitor): New function, most
2775         content taken from...
2776         (completion_tracker::recompute_lowest_common_denominator):
2777         ...here, this now just visits each item in the hash calling the
2778         above visitor.
2779         (completion_tracker::build_completion_result): Remove use of
2780         m_entries_vec, call recompute_lowest_common_denominator.
2781         * completer.h (completion_tracker::have_completions): Remove use
2782         of m_entries_vec.
2783         (completion_tracker::completion_hash_entry): Declare new class.
2784         (completion_tracker::recompute_lowest_common_denominator): Change
2785         function signature.
2786         (completion_tracker::recompute_lcd_visitor): Declare new function.
2787         (completion_tracker::m_entries_vec): Delete.
2788         (completion_tracker::m_entries_hash): Initialize to NULL.
2789         (completion_tracker::m_lowest_common_denominator_valid): New
2790         member variable.
2791         (completion_tracker::m_lowest_common_denominator_max_length): New
2792         member variable.
2793
2794 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2795
2796         * regformats/regdef.h: Put reg in gdb namespace.
2797
2798 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2799
2800         * i386-bsd-nat.c (gdb_ptrace): New.
2801         * (i386bsd_fetch_inferior_registers,
2802         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2803         * (i386bsd_fetch_inferior_registers,
2804         i386bsd_store_inferior_registers) Use gdb_ptrace.
2805
2806 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2807
2808         * amd64-bsd-nat.c (gdb_ptrace): New.
2809         * (amd64bsd_fetch_inferior_registers,
2810         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2811         * (amd64bsd_fetch_inferior_registers,
2812         amd64bsd_store_inferior_registers) Use gdb_ptrace.
2813
2814 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2815
2816         * user-regs.c (user_reg::read): Rename to...
2817         (user_reg::xread): ...this.
2818         * (append_user_reg): Rename argument `read' to `xread'.
2819         * (user_reg_add_builtin): Likewise.
2820         * (user_reg_add): Likewise.
2821         * (value_of_user_reg): Likewise.
2822
2823 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2824
2825         * sparc-nat.c (gdb_ptrace): New.
2826         * sparc-nat.c (sparc_fetch_inferior_registers)
2827         (sparc_store_inferior_registers) Remove obsolete comment.
2828         * sparc-nat.c (sparc_fetch_inferior_registers)
2829         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
2830         * sparc-nat.c (sparc_fetch_inferior_registers)
2831         (sparc_store_inferior_registers) Use gdb_ptrace.
2832
2833 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2834
2835         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
2836         it to the ptrace call.
2837         * sh-nbsd-nat.c (store_registers): Likewise.
2838
2839 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2840
2841         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
2842         nbsd_nat_target instead of inf_ptrace_target.
2843         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2844         nbsd_nat_target.
2845
2846 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2847
2848         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
2849
2850 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2851
2852         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
2853         <sys/sysctl.h>.
2854         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
2855
2856 2020-03-17  Tom de Vries  <tdevries@suse.de>
2857
2858         PR gdb/23710
2859         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
2860         fields.
2861         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
2862         fields.
2863         (process_imported_unit_die): Skip import of c++ CUs.
2864
2865 2020-03-16  Tom Tromey  <tom@tromey.com>
2866
2867         * p-valprint.c (pascal_object_print_value): Initialize
2868         base_value.
2869
2870 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
2871             Shahab Vahedi  <shahab@synopsys.com>
2872
2873         * Makefile.in: Add arch/arc.o
2874         * configure.tgt: Likewise.
2875         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
2876         (_initialize_arc_tdep): Don't initialize old target descriptions.
2877         (arc_read_description): New function to cache target descriptions.
2878         * arc-tdep.h (arc_read_description): Add proto type.
2879         * arch/arc.c: New file.
2880         * arch/arc.h: Likewise.
2881         * features/Makefile: Replace old target descriptions with new.
2882         * features/arc-arcompact.c: Remove.
2883         * features/arc-arcompact.xml: Likewise.
2884         * features/arc-v2.c: Likewise
2885         * features/arc-v2.xml: Likewise
2886         * features/arc/aux-arcompact.xml: New file.
2887         * features/arc/aux-v2.xml: Likewise.
2888         * features/arc/core-arcompact.xml: Likewise.
2889         * features/arc/core-v2.xml: Likewise.
2890         * features/arc/aux-arcompact.c: Generate.
2891         * features/arc/aux-v2.c: Likewise.
2892         * features/arc/core-arcompact.c: Likewise.
2893         * features/arc/core-v2.c: Likewise.
2894         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
2895
2896 2020-03-16  Tom Tromey  <tromey@adacore.com>
2897
2898         PR gdb/25663:
2899         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
2900         putting value into bcache.
2901
2902 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2903
2904         PR gdb/21500
2905         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
2906         to...
2907         (amd64_windows_init_abi_common): ... this.  Don't set size of
2908         long type.
2909         (amd64_windows_init_abi): New function.
2910         (amd64_cygwin_init_abi): New function.
2911         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
2912         the Cygwin OS ABI.
2913         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
2914         comment.
2915
2916 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2917
2918         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
2919         * windows-tdep.c (CYGWIN_DLL_NAME): New.
2920         (pe_import_directory_entry): New struct type.
2921         (is_linked_with_cygwin_dll): New function.
2922         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
2923         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
2924         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
2925
2926 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2927
2928         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
2929         i386_cygwin_core_osabi_sniffer.
2930
2931 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2932
2933         * i386-cygwin-tdep.c: Rename to...
2934         * i386-windows-tdep.c: ... this.
2935         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
2936         i386-windows-tdep.c.
2937         * configure.tgt: Likewise.
2938
2939 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2940
2941         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
2942         * osabi.c (gdb_osabi_names): Add "Windows".
2943         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
2944         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
2945         (i386_cygwin_core_osabi_sniffer): New function, extracted from
2946         i386_cygwin_osabi_sniffer.
2947         (_initialize_i386_cygwin_tdep): Register OS ABI
2948         GDB_OSABI_WINDOWS for i386.
2949         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
2950         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
2951         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
2952         for x86-64.
2953         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
2954         when the target matches '*-*-mingw*'.
2955
2956 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2957
2958         * defs.h (enum gdb_osabi): Move to...
2959         * osabi.h (enum gdb_osabi): ... here.
2960         * gdbarch.sh: Include osabi.h in gdbarch.h.
2961         * gdbarch.h: Re-generate.
2962
2963 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2964
2965         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
2966         function.
2967         (_initialize_amd64_windows_tdep): Register osabi sniffer.
2968
2969 2020-03-14  Tom Tromey  <tom@tromey.com>
2970
2971         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
2972         for C++.
2973         (c_type_print_modifier): Likewise.  Add "language" parameter.
2974         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
2975         (c_type_print_base_1): Update.
2976         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
2977         constants.
2978         * type-stack.c (type_stack::insert): Handle tp_atomic and
2979         tp_restrict.
2980         (type_stack::follow_type_instance_flags): Likewise.
2981         (type_stack::follow_types): Likewise.  Merge type-following code.
2982         * c-exp.y (RESTRICT, ATOMIC): New tokens.
2983         (space_identifier, cv_with_space_id)
2984         (const_or_volatile_or_space_identifier_noopt)
2985         (const_or_volatile_or_space_identifier): Remove.
2986         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
2987         rules.
2988         (ptr_operator, typebase): Update.
2989         (enum token_flag) <FLAG_C>: New constant.
2990         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
2991         "_Atomic".
2992         (lex_one_token): Handle FLAG_C.
2993
2994 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2995
2996         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
2997         it to the ptrace call.
2998         * m68k-bsd-nat.c (store_registers): Likewise.
2999
3000 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3001
3002         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
3003         gdb_byte *.
3004         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
3005         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
3006         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
3007
3008 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3009
3010         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
3011         nbsd_nat_target instead of inf_ptrace_target.
3012         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
3013         nbsd_nat_target.
3014
3015 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3016
3017         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
3018         register_t.
3019
3020 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3021
3022         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
3023         it to the ptrace call.
3024         * alpha-bsd-nat.c (store_registers): Likewise.
3025
3026 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3027
3028         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
3029         includes.
3030         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
3031         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
3032         fill_fpregset): Likewise.
3033
3034 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3035
3036         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
3037         nbsd_nat_target instead of inf_ptrace_target.
3038         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
3039         nbsd_nat_target.
3040
3041 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3042
3043         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
3044         register_t.
3045
3046 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3047
3048         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
3049         it to the ptrace call.
3050         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
3051         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
3052         * arm-nbsd-nat.c (store_register): Likewise.
3053         * arm-nbsd-nat.c (store_regs): Likewise.
3054         * arm-nbsd-nat.c (store_fp_register): Likewise.
3055         * arm-nbsd-nat.c (store_fp_regs): Likewise.
3056
3057 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3058
3059         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
3060         nbsd_nat_target instead of inf_ptrace_target.
3061         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
3062         nbsd_nat_target.
3063
3064 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3065
3066         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
3067         it to the ptrace call.
3068         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
3069
3070 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3071
3072         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
3073         it to the ptrace call.
3074         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
3075
3076 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3077
3078         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
3079         gdb_byte *.
3080         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
3081
3082 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3083
3084         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
3085         instead of inf_ptrace_target.
3086         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
3087         nbsd_nat_target.
3088
3089 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3090
3091         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
3092         register_t.
3093
3094 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3095
3096         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
3097         register_t.
3098
3099 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3100
3101         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
3102         register_t.
3103
3104 2020-03-13  Tom Tromey  <tom@tromey.com>
3105
3106         * value.h (val_print): Don't declare.
3107         * valprint.h (val_print_array_elements)
3108         (val_print_scalar_formatted, generic_val_print): Don't declare.
3109         * valprint.c (generic_val_print_array): Take a struct value.
3110         (generic_val_print_ptr, generic_val_print_memberptr)
3111         (generic_val_print_bool, generic_val_print_int)
3112         (generic_val_print_char, generic_val_print_complex)
3113         (generic_val_print): Remove.
3114         (generic_value_print): Update.
3115         (do_val_print): Remove unused parameters.  Don't call
3116         la_val_print.
3117         (val_print): Remove.
3118         (common_val_print): Update.  Don't call value_check_printable.
3119         (val_print_scalar_formatted, val_print_array_elements): Remove.
3120         * rust-lang.c (rust_val_print): Remove.
3121         (rust_language_defn): Update.
3122         * p-valprint.c (pascal_val_print): Remove.
3123         (pascal_value_print_inner): Update.
3124         (pascal_object_print_val_fields, pascal_object_print_val):
3125         Remove.
3126         (pascal_object_print_static_field): Update.
3127         * p-lang.h (pascal_val_print): Don't declare.
3128         * p-lang.c (pascal_language_defn): Update.
3129         * opencl-lang.c (opencl_language_defn): Update.
3130         * objc-lang.c (objc_language_defn): Update.
3131         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
3132         * m2-lang.h (m2_val_print): Don't declare.
3133         * m2-lang.c (m2_language_defn): Update.
3134         * language.h (struct language_defn) <la_val_print>: Remove.
3135         * language.c (unk_lang_value_print_inner): Rename.  Change
3136         argument types.
3137         (unknown_language_defn, auto_language_defn): Update.
3138         * go-valprint.c (go_val_print): Remove.
3139         * go-lang.h (go_val_print): Don't declare.
3140         * go-lang.c (go_language_defn): Update.
3141         * f-valprint.c (f_val_print): Remove.
3142         * f-lang.h (f_value_print): Don't declare.
3143         * f-lang.c (f_language_defn): Update.
3144         * d-valprint.c (d_val_print): Remove.
3145         * d-lang.h (d_value_print): Don't declare.
3146         * d-lang.c (d_language_defn): Update.
3147         * cp-valprint.c (cp_print_value_fields)
3148         (cp_print_value_fields_rtti, cp_print_value): Remove.
3149         (cp_print_static_field): Update.
3150         * c-valprint.c (c_val_print_array, c_val_print_ptr)
3151         (c_val_print_struct, c_val_print_union, c_val_print_int)
3152         (c_val_print_memberptr, c_val_print): Remove.
3153         * c-lang.h (c_val_print_array, cp_print_value_fields)
3154         (cp_print_value_fields_rtti): Don't declare.
3155         * c-lang.c (c_language_defn, cplus_language_defn)
3156         (asm_language_defn, minimal_language_defn): Update.
3157         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
3158         (ada_val_print_enum): Take a struct value.
3159         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
3160         (ada_val_print): Remove.
3161         (ada_value_print_1): Update.
3162         (printable_val_type): Remove.
3163         * ada-lang.h (ada_val_print): Don't declare.
3164         * ada-lang.c (ada_language_defn): Update.
3165
3166 2020-03-13  Tom Tromey  <tom@tromey.com>
3167
3168         * valprint.c (do_val_print): Update.
3169         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
3170         a struct value.
3171         (value_to_value_object_no_release): Declare.
3172         * python/py-value.c (value_to_value_object_no_release): New
3173         function.
3174         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
3175         struct value.
3176         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
3177         function.
3178         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
3179         a struct value.
3180         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
3181         Declare.
3182         (gdbscm_apply_val_pretty_printer): Take a struct value.
3183         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
3184         value.
3185         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
3186         value.
3187         * extension-priv.h (struct extension_language_ops)
3188         <apply_val_pretty_printer>: Take a struct value.
3189         * cp-valprint.c (cp_print_value): Create a struct value.
3190         (cp_print_value): Update.
3191
3192 2020-03-13  Tom Tromey  <tom@tromey.com>
3193
3194         * ada-valprint.c (print_field_values): Call common_val_print.
3195
3196 2020-03-13  Tom Tromey  <tom@tromey.com>
3197
3198         * ada-valprint.c (val_print_packed_array_elements): Remove
3199         bitoffset and val parameters.  Call common_val_print.
3200         (ada_val_print_string): Remove offset, address, and original_value
3201         parameters.
3202         (ada_val_print_array): Update.
3203         (ada_value_print_array): New function.
3204         (ada_value_print_1): Call it.
3205
3206 2020-03-13  Tom Tromey  <tom@tromey.com>
3207
3208         * ada-valprint.c (ada_value_print): Use common_val_print.
3209
3210 2020-03-13  Tom Tromey  <tom@tromey.com>
3211
3212         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
3213
3214 2020-03-13  Tom Tromey  <tom@tromey.com>
3215
3216         * ada-valprint.c (ada_value_print_num): New function.
3217         (ada_value_print_1): Use it.
3218
3219 2020-03-13  Tom Tromey  <tom@tromey.com>
3220
3221         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
3222
3223 2020-03-13  Tom Tromey  <tom@tromey.com>
3224
3225         * ada-valprint.c (ada_value_print_ptr): New function.
3226         (ada_value_print_1): Use it.
3227
3228 2020-03-13  Tom Tromey  <tom@tromey.com>
3229
3230         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
3231         call common_val_print.
3232         (ada_val_print_1): Update.
3233         (ada_value_print_1): New function.
3234         (ada_value_print_inner): Rewrite.
3235
3236 2020-03-13  Tom Tromey  <tom@tromey.com>
3237
3238         * cp-valprint.c (cp_print_value_fields): Update.
3239         (cp_print_value): New function.
3240
3241 2020-03-13  Tom Tromey  <tom@tromey.com>
3242
3243         * m2-valprint.c (m2_value_print_inner): Use
3244         cp_print_value_fields.
3245         * cp-valprint.c (cp_print_value_fields): New function.
3246         * c-valprint.c (c_value_print_struct): New function.
3247         (c_value_print_inner): Use c_value_print_struct.
3248         * c-lang.h (cp_print_value_fields): Declare.
3249
3250 2020-03-13  Tom Tromey  <tom@tromey.com>
3251
3252         * c-valprint.c (c_value_print_array): New function.
3253         (c_value_print_inner): Use it.
3254
3255 2020-03-13  Tom Tromey  <tom@tromey.com>
3256
3257         * c-valprint.c (c_value_print_memberptr): New function.
3258         (c_value_print_inner): Use it.
3259
3260 2020-03-13  Tom Tromey  <tom@tromey.com>
3261
3262         * c-valprint.c (c_value_print_int): New function.
3263         (c_value_print_inner): Use it.
3264
3265 2020-03-13  Tom Tromey  <tom@tromey.com>
3266
3267         * c-valprint.c (c_value_print_ptr): New function.
3268         (c_value_print_inner): Use it.
3269
3270 2020-03-13  Tom Tromey  <tom@tromey.com>
3271
3272         * c-valprint.c (c_value_print_inner): Rewrite.
3273
3274 2020-03-13  Tom Tromey  <tom@tromey.com>
3275
3276         * valprint.c (generic_value_print_complex): New function.
3277         (generic_value_print): Use it.
3278
3279 2020-03-13  Tom Tromey  <tom@tromey.com>
3280
3281         * valprint.c (generic_val_print_float): Don't call
3282         val_print_scalar_formatted.
3283         (generic_val_print, generic_value_print): Update.
3284
3285 2020-03-13  Tom Tromey  <tom@tromey.com>
3286
3287         * valprint.c (generic_value_print_char): New function
3288         (generic_value_print): Use it.
3289
3290 2020-03-13  Tom Tromey  <tom@tromey.com>
3291
3292         * valprint.c (generic_value_print_int): New function.
3293         (generic_value_print): Use it.
3294
3295 2020-03-13  Tom Tromey  <tom@tromey.com>
3296
3297         * valprint.c (generic_value_print_bool): New function.
3298         (generic_value_print): Use it.
3299
3300 2020-03-13  Tom Tromey  <tom@tromey.com>
3301
3302         * valprint.c (generic_val_print_func): Simplify.
3303         (generic_val_print, generic_value_print): Update.
3304
3305 2020-03-13  Tom Tromey  <tom@tromey.com>
3306
3307         * valprint.c (generic_val_print_flags): Remove.
3308         (generic_val_print, generic_value_print): Update.
3309         (val_print_type_code_flags): Add original_value parameter.
3310
3311 2020-03-13  Tom Tromey  <tom@tromey.com>
3312
3313         * valprint.c (generic_val_print): Update.
3314         (generic_value_print): Update.
3315         * valprint.c (generic_val_print_enum): Don't call
3316         val_print_scalar_formatted.
3317
3318 2020-03-13  Tom Tromey  <tom@tromey.com>
3319
3320         * valprint.c (generic_value_print): Call generic_value_print_ptr.
3321         * valprint.c (generic_value_print_ptr): New function.
3322
3323 2020-03-13  Tom Tromey  <tom@tromey.com>
3324
3325         * valprint.c (generic_value_print): Rewrite.
3326
3327 2020-03-13  Tom Tromey  <tom@tromey.com>
3328
3329         * p-valprint.c (pascal_object_print_value_fields)
3330         (pascal_object_print_value): New functions.
3331
3332 2020-03-13  Tom Tromey  <tom@tromey.com>
3333
3334         * p-valprint.c (pascal_value_print_inner): Rewrite.
3335
3336 2020-03-13  Tom Tromey  <tom@tromey.com>
3337
3338         * f-valprint.c (f_value_print_innner): Rewrite.
3339
3340 2020-03-13  Tom Tromey  <tom@tromey.com>
3341
3342         * m2-valprint.c (m2_print_unbounded_array): New overload.
3343         (m2_print_unbounded_array): Update.
3344         (m2_print_array_contents): Take a struct value.
3345         (m2_value_print_inner): Rewrite.
3346
3347 2020-03-13  Tom Tromey  <tom@tromey.com>
3348
3349         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
3350         (d_value_print_inner): New function.
3351         * d-lang.h (d_value_print_inner): Declare.
3352         * d-lang.c (d_language_defn): Use d_value_print_inner.
3353
3354 2020-03-13  Tom Tromey  <tom@tromey.com>
3355
3356         * go-valprint.c (go_value_print_inner): New function.
3357         * go-lang.h (go_value_print_inner): Declare.
3358         * go-lang.c (go_language_defn): Use go_value_print_inner.
3359
3360 2020-03-13  Tom Tromey  <tom@tromey.com>
3361
3362         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
3363         API.
3364         (rust_val_print): Rewrite.
3365         (rust_value_print_inner): New function, from rust_val_print.
3366         (rust_language_defn): Use rust_value_print_inner.
3367
3368 2020-03-13  Tom Tromey  <tom@tromey.com>
3369
3370         * ada-valprint.c (ada_value_print_inner): New function.
3371         * ada-lang.h (ada_value_print_inner): Declare.
3372         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
3373
3374 2020-03-13  Tom Tromey  <tom@tromey.com>
3375
3376         * f-valprint.c (f_value_print_innner): New function.
3377         * f-lang.h (f_value_print_innner): Declare.
3378         * f-lang.c (f_language_defn): Use f_value_print_innner.
3379
3380 2020-03-13  Tom Tromey  <tom@tromey.com>
3381
3382         * p-valprint.c (pascal_value_print_inner): New function.
3383         * p-lang.h (pascal_value_print_inner): Declare.
3384         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
3385
3386 2020-03-13  Tom Tromey  <tom@tromey.com>
3387
3388         * m2-valprint.c (m2_value_print_inner): New function.
3389         * m2-lang.h (m2_value_print_inner): Declare.
3390         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
3391
3392 2020-03-13  Tom Tromey  <tom@tromey.com>
3393
3394         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
3395         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
3396         * c-valprint.c (c_value_print_inner): New function.
3397         * c-lang.h (c_value_print_inner): Declare.
3398         * c-lang.c (c_language_defn, cplus_language_defn)
3399         (asm_language_defn, minimal_language_defn): Use
3400         c_value_print_inner.
3401
3402 2020-03-13  Tom Tromey  <tom@tromey.com>
3403
3404         * p-valprint.c (pascal_object_print_value_fields): Now static.
3405         * p-lang.h (pascal_object_print_value_fields): Don't declare.
3406
3407 2020-03-13  Tom Tromey  <tom@tromey.com>
3408
3409         * c-valprint.c (c_val_print_array): Simplify.
3410
3411 2020-03-13  Tom Tromey  <tom@tromey.com>
3412
3413         * valprint.c (value_print_array_elements): New function.
3414         * valprint.h (value_print_array_elements): Declare.
3415
3416 2020-03-13  Tom Tromey  <tom@tromey.com>
3417
3418         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
3419         * mips-tdep.c (mips_print_register): Use
3420         value_print_scalar_formatted.
3421
3422 2020-03-13  Tom Tromey  <tom@tromey.com>
3423
3424         * valprint.h (value_print_scalar_formatted): Declare.
3425         * valprint.c (value_print_scalar_formatted): New function.
3426
3427 2020-03-13  Tom Tromey  <tom@tromey.com>
3428
3429         * valprint.h (generic_value_print): Declare.
3430         * valprint.c (generic_value_print): New function.
3431
3432 2020-03-13  Tom Tromey  <tom@tromey.com>
3433
3434         * valprint.c (do_val_print): Call la_value_print_inner, if
3435         available.
3436         * rust-lang.c (rust_language_defn): Update.
3437         * p-lang.c (pascal_language_defn): Update.
3438         * opencl-lang.c (opencl_language_defn): Update.
3439         * objc-lang.c (objc_language_defn): Update.
3440         * m2-lang.c (m2_language_defn): Update.
3441         * language.h (struct language_defn) <la_value_print_inner>: New
3442         member.
3443         * language.c (unknown_language_defn, auto_language_defn): Update.
3444         * go-lang.c (go_language_defn): Update.
3445         * f-lang.c (f_language_defn): Update.
3446         * d-lang.c (d_language_defn): Update.
3447         * c-lang.c (c_language_defn, cplus_language_defn)
3448         (asm_language_defn, minimal_language_defn): Update.
3449         * ada-lang.c (ada_language_defn): Update.
3450
3451 2020-03-13  Tom Tromey  <tom@tromey.com>
3452
3453         * c-valprint.c (c_value_print): Use common_val_print.
3454
3455 2020-03-13  Tom Tromey  <tom@tromey.com>
3456
3457         * cp-valprint.c (cp_print_static_field): Use common_val_print.
3458
3459 2020-03-13  Tom Tromey  <tom@tromey.com>
3460
3461         * f-valprint.c (f77_print_array_1, f_val_print): Use
3462         common_val_print.
3463
3464 2020-03-13  Tom Tromey  <tom@tromey.com>
3465
3466         * riscv-tdep.c (riscv_print_one_register_info): Use
3467         common_val_print.
3468
3469 2020-03-13  Tom Tromey  <tom@tromey.com>
3470
3471         * mi/mi-main.c (output_register): Use common_val_print.
3472
3473 2020-03-13  Tom Tromey  <tom@tromey.com>
3474
3475         * infcmd.c (default_print_one_register_info): Use
3476         common_val_print.
3477
3478 2020-03-13  Tom Tromey  <tom@tromey.com>
3479
3480         * valprint.h (common_val_print_checked): Declare.
3481         * valprint.c (common_val_print_checked): New function.
3482         * stack.c (print_frame_arg): Use common_val_print_checked.
3483
3484 2020-03-13  Tom Tromey  <tom@tromey.com>
3485
3486         * valprint.c (do_val_print): New function, from val_print.
3487         (val_print): Use do_val_print.
3488         (common_val_print): Use do_val_print.
3489
3490 2020-03-13  Tom Tromey  <tom@tromey.com>
3491
3492         * valprint.c (value_print): Use scoped_value_mark.
3493
3494 2020-03-13  Tom de Vries  <tdevries@suse.de>
3495
3496         PR symtab/25646
3497         * psymtab.c (partial_symtab::partial_symtab): Don't set
3498         globals_offset and statics_offset.  Push element onto
3499         current_global_psymbols and current_static_psymbols stacks.
3500         (concat): New function.
3501         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
3502         element from current_global_psymbols and current_static_psymbols
3503         stacks.  Concat popped elements to global_psymbols and
3504         static_symbols.
3505         (add_psymbol_to_list): Use current_global_psymbols and
3506         current_static_psymbols stacks.
3507         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
3508         current_static_psymbols fields.
3509
3510 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
3511
3512         * corelow.c (sniff_core_bfd): Remove.
3513         (class core_target) <m_core_vec>: Remove.
3514         (core_target::core_target): Update.
3515         (core_file_fns): Remove.
3516         (deprecated_add_core_fns): Remove.
3517         (default_core_sniffer): Remove.
3518         (sniff_core_bfd): Remove.
3519         (default_check_format): Remove.
3520         (gdb_check_format): Remove.
3521         (core_target_open): Update.
3522         (core_target::get_core_register_section): Update.
3523         (get_core_registers_cb): Update.
3524         (core_target::fetch_registers): Update.
3525         * gdbcore.h (struct core_fns): Remove.
3526         (deprecated_add_core_fns): Remove.
3527         (default_core_sniffer): Remove.
3528         (default_check_format): Remove.
3529
3530 2020-03-12  Tom Tromey  <tom@tromey.com>
3531
3532         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
3533         CORE_ADDR.
3534         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
3535
3536 2020-03-12  Tom Tromey  <tom@tromey.com>
3537
3538         * remote.c (remote_target::download_tracepoint)
3539         (remote_target::enable_tracepoint)
3540         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
3541         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
3542         sprintf_vma.
3543
3544 2020-03-12  Tom Tromey  <tom@tromey.com>
3545
3546         * symfile-mem.c: Update CORE_ADDR size assert.
3547
3548 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3549
3550         * selftest.m4: Move to gdbsupport/.
3551         * acinclude.m4: Update path to selftest.m4.
3552
3553 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3554
3555         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
3556         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
3557         gdbarch-selfselftests.c and selftest-arch.c.
3558         (SUBDIR_UNITTESTS_OBS): Rename to...
3559         (SELFTESTS_OBS): ... this.
3560         (COMMON_SFILES): Remove disasm-selftests.c and
3561         gdbarch-selftests.c.
3562         * configure.ac: Don't add selftest-arch.{c,o} to
3563         CONFIG_{SRCS,OBS}.
3564         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
3565         preprocessor conditions.
3566
3567 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3568
3569         * configure.ac: Don't source bfd/development.sh.
3570         * selftest.m4: Modify comment.
3571         * configure: Re-generate.
3572
3573 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3574
3575         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
3576         not "true" or "false".
3577         * configure: Re-generate.
3578
3579 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
3580
3581         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
3582         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
3583         renamed to arm_nbsd_supply_gregset.
3584         (fetch_register): Update to call arm_nbsd_supply_gregset.
3585         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
3586         (arm_netbsd_nat_target::fetch_registers): Update.
3587         (fetch_elfcore_registers): Removed.
3588         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
3589         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
3590         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
3591         not require NetBSD system headers.
3592         (arm_nbsd_regset): New struct.
3593         (arm_nbsd_iterate_over_regset_sections): New function.
3594         (arm_netbsd_init_abi_common): Updated to call
3595         set_gdbarch_iterate_over_regset_sections.
3596         * arm-nbsd-tdep.h: New file.
3597
3598 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
3599
3600         * symtab.c (find_pc_sect_line): Add check which prevents infinite
3601         recursion.
3602
3603 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
3604
3605         * configure: Re-generate.
3606
3607 2020-03-11  Tom Tromey  <tromey@adacore.com>
3608
3609         * ada-typeprint.c (print_choices): Fix comment.
3610
3611 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3612
3613         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
3614         previous item in the list, when the list has no items.
3615
3616 2020-03-11  Tom de Vries  <tdevries@suse.de>
3617
3618         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
3619         PROP_LOCLIST handling code.
3620
3621 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3622
3623         * buildsym-legacy.c (record_line): Pass extra parameter to
3624         record_line.
3625         * buildsym.c (buildsym_compunit::record_line): Take an extra
3626         parameter, reduce duplication in the line table, and record the
3627         is_stmt flag in the line table.
3628         * buildsym.h (buildsym_compunit::record_line): Add extra
3629         parameter.
3630         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
3631         non-statement lines.
3632         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
3633         this to the symtab builder.
3634         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
3635         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
3636         through to dwarf_record_line_1.
3637         * infrun.c (process_event_stop_test): When stepping, don't stop at
3638         a non-statement instruction, and only refresh the step info when
3639         we land in the middle of a line's range.  Also add an extra
3640         comment.
3641         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
3642         field.
3643         * record-btrace.c (btrace_find_line_range): Only record lines
3644         marked as is-statement.
3645         * stack.c (frame_show_address): Show the frame address if we are
3646         in a non-statement sal.
3647         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
3648         (maintenance_print_one_line_table): Print a header for the is_stmt
3649         column, and include is_stmt information in the output.
3650         * symtab.c (find_pc_sect_line): Find lines marked as statements in
3651         preference to non-statements.
3652         (find_pcs_for_symtab_line): Prefer is-statement entries.
3653         (find_line_common): Likewise.
3654         * symtab.h (struct linetable_entry): Add is_stmt field.
3655         (struct symtab_and_line): Likewise.
3656         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
3657         arranging the line table.
3658
3659 2020-03-07  Tom de Vries  <tdevries@suse.de>
3660
3661         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
3662         DIE.
3663
3664 2020-03-07  Tom Tromey  <tom@tromey.com>
3665
3666         * valops.c (value_literal_complex): Remove obsolete comment.
3667         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
3668         comment.
3669
3670 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
3671
3672         * infrun.h: Forward-declare thread_info.
3673         (set_step_info): Add thread_info parameter, add doc.
3674         * infrun.c (set_step_info): Add thread_info parameter, move doc
3675         to header.
3676         * infrun.c (process_event_stop_test): Pass thread to
3677         set_step_info call.
3678         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
3679         set_step_info.
3680         (prepare_one_step): Add thread_info parameter, pass it to
3681         set_step_frame and prepare_one_step (recursive) call.
3682         (step_1): Pass thread to prepare_one_step call.
3683         (step_command_fsm::should_stop): Pass thread to
3684         prepare_one_step.
3685         (until_next_fsm): Pass thread to set_step_frame call.
3686         (finish_command): Pass thread to set_step_info call.
3687
3688 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
3689
3690         * windows-tdep.c (windows_solib_create_inferior_hook):
3691         Check if inferior is running.
3692
3693 2020-03-06  Tom de Vries  <tdevries@suse.de>
3694
3695         * NEWS: Fix "the the".
3696         * ctfread.c: Same.
3697
3698 2020-03-06  Tom de Vries  <tdevries@suse.de>
3699
3700         * psymtab.c (psymtab_to_symtab): Don't print "done.".
3701
3702 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3703
3704         * .dir-locals.el: Add a comment referencing the other copies of
3705         this file.
3706
3707 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
3708
3709         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
3710         psargs.
3711
3712 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3713
3714         * .gitattributes: New file.
3715
3716 2020-03-04  Tom Tromey  <tom@tromey.com>
3717
3718         * symmisc.c (print_symbol_bcache_statistics)
3719         (print_objfile_statistics): Update.
3720         * symfile.c (allocate_symtab): Use intern.
3721         * psymtab.c (partial_symtab::partial_symtab): Use intern.
3722         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3723         macro_cache>: Remove.
3724         <string_cache>: New member.
3725         (struct objfile) <intern>: New methods.
3726         * elfread.c (elf_symtab_read): Use intern.
3727         * dwarf2/read.c (fixup_go_packaging): Intern package name.
3728         (dwarf2_compute_name, dwarf2_physname)
3729         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
3730         names.
3731         (guess_partial_die_structure_name): Update.
3732         (partial_die_info::fixup): Intern name.
3733         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
3734         name.
3735         (dwarf2_name): Intern name.  Update.
3736         * buildsym.c (buildsym_compunit::get_macro_table): Use
3737         string_cache.
3738
3739 2020-03-04  Tom Tromey  <tom@tromey.com>
3740
3741         * jit.c (bfd_open_from_target_memory): Make "target" const.
3742         * corefile.c (gnutarget): Now const.
3743         * gdbcore.h (gnutarget): Now const.
3744
3745 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
3746
3747         * NEWS: Mention support for WOW64 processes.
3748         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
3749         (amd64_windows_segment_register_p): Remove static.
3750         (_initialize_amd64_windows_nat): Update.
3751         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
3752         * i386-windows-nat.c (context_offset): Update.
3753         (i386_mappings): Rename and remove static.
3754         (i386_windows_segment_register_p): Remove static.
3755         (_initialize_i386_windows_nat): Update.
3756         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
3757         (STATUS_WX86_SINGLE_STEP): New macro.
3758         (EnumProcessModulesEx): New macro.
3759         (Wow64SuspendThread): New macro.
3760         (Wow64GetThreadContext): New macro.
3761         (Wow64SetThreadContext): New macro.
3762         (Wow64GetThreadSelectorEntry): New macro.
3763         (windows_set_context_register_offsets): Add static.
3764         (windows_set_segment_register_p): Likewise.
3765         (windows_add_thread): Adapt for WOW64 processes.
3766         (windows_fetch_one_register): Likewise.
3767         (windows_nat_target::fetch_registers): Likewise.
3768         (windows_store_one_register): Likewise.
3769         (display_selector): Likewise.
3770         (display_selectors): Likewise.
3771         (handle_exception): Likewise.
3772         (windows_continue): Likewise.
3773         (windows_nat_target::resume): Likewise.
3774         (windows_add_all_dlls): Likewise.
3775         (do_initial_windows_stuff): Likewise.
3776         (windows_nat_target::attach): Likewise.
3777         (windows_get_exec_module_filename): Likewise.
3778         (windows_nat_target::create_inferior): Likewise.
3779         (windows_xfer_siginfo): Likewise.
3780         (_initialize_loadable): Initialize Wow64SuspendThread,
3781         Wow64GetThreadContext, Wow64SetThreadContext,
3782         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
3783         * windows-nat.h (windows_set_context_register_offsets):
3784         Remove declaration.
3785         (windows_set_segment_register_p): Likewise.
3786         (i386_windows_segment_register_p): Add declaration.
3787         (amd64_windows_segment_register_p): Likewise.
3788
3789 2020-03-04  Luis Machado  <luis.machado@linaro.org>
3790
3791         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
3792         in "info registers" for AArch64/ARM.
3793
3794         The change caused "info registers" to not print GPR's.
3795
3796         gdb/ChangeLog:
3797
3798         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
3799
3800         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
3801         when reg->group is empty and reggroup is not.
3802
3803 2020-03-03  Tom Tromey  <tromey@adacore.com>
3804
3805         * dwarf2/frame.c (struct dwarf2_frame_cache)
3806         <checked_tailcall_bottom, entry_cfa_sp_offset,
3807         entry_cfa_sp_offset_p>: Remove members.
3808         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
3809         (dwarf2_frame_prev_register): Don't call
3810         dwarf2_tailcall_sniffer_first.
3811         (dwarf2_append_unwinders): Don't append tailcall unwinder.
3812         * frame-unwind.c (add_unwinder): New fuction.
3813         (frame_unwind_init): Use it.  Add tailcall unwinder.
3814
3815 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3816             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
3817
3818         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
3819         value should be printed as true.
3820
3821 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
3822
3823         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
3824         (windows_init_abi): Set and use windows_so_ops.
3825
3826 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
3827
3828         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
3829         when verifying if dealing with a convenience variable.
3830
3831 2020-03-03  Luis Machado  <luis.machado@linaro.org>
3832
3833         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
3834
3835 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
3836
3837         * infrun.c (gdbarch_supports_displaced_stepping): New.
3838         (use_displaced_stepping): Break up conditions in smaller pieces.
3839         Use gdbarch_supports_displaced_stepping.
3840         (displaced_step_prepare_throw): Use
3841         gdbarch_supports_displaced_stepping.
3842
3843 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3844
3845         * NEWS: Mention new behaviour of the history filename.
3846         * top.c (write_history_p): Add comment.
3847         (show_write_history_p): Add header comment, give a different
3848         message when history writing is on, but the history filename is
3849         empty.
3850         (history_filename): Add comment.
3851         (history_filename_empty): New function.
3852         (show_history_filename): Add header comment, give a different
3853         message when the filename is empty.
3854         (init_history): Compare history_filename against nullptr, and only
3855         read history if the filename is not empty.
3856         (set_history_filename): Add header comment, and only make
3857         non-empty filenames absolute.
3858         (init_main): Make the filename argument to 'set history filename'
3859         optional.
3860
3861 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
3862
3863         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
3864         (arm_supply_vfpregset): ...this, and update to use VFP registers.
3865         (fetch_fp_register): Update.
3866         (fetch_fp_regs): Update.
3867         (store_fp_register): Update.
3868         (store_fp_regs): Update.
3869         (arm_netbsd_nat_target::read_description): New function.
3870         (fetch_elfcore_registers): Update.
3871
3872 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3873
3874         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
3875         general_thread if the stop reply is missing a thread-id.
3876         (remote_target::process_stop_reply): Use the first non-exited
3877         thread if the target didn't pass a thread-id.
3878         * infrun.c (do_target_wait): Move call to
3879         switch_to_inferior_no_thread to ....
3880         (do_target_wait_1): ... here.
3881
3882 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
3883
3884         * debuginfod-support.c: Include defs.h first.
3885
3886 2020-02-28  Tom de Vries  <tdevries@suse.de>
3887
3888         * symfile.c (set_initial_language): Use default language for lookup.
3889
3890 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
3891
3892         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
3893         reader variable, pass `this` to read_cutu_die_from_dwo.
3894
3895 2020-02-27  Aaron Merey  <amerey@redhat.com>
3896
3897         * source.c (open_source_file): Check for nullptr when computing
3898         srcpath.
3899
3900 2020-02-27  Tom Tromey  <tromey@adacore.com>
3901
3902         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
3903         member.
3904         (dwarf2_add_field): Don't update nfields.
3905         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
3906
3907 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3908
3909         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
3910         abs.
3911
3912 2020-02-26  Tom Tromey  <tom@tromey.com>
3913
3914         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
3915         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
3916         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
3917         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
3918         per_cu_data.
3919
3920 2020-02-26  Tom Tromey  <tom@tromey.com>
3921
3922         * dwarf2/index-write.c (psym_index_map): Change type.
3923         (add_address_entry_worker, write_one_signatured_type)
3924         (recursively_count_psymbols, recursively_write_psymbols)
3925         (class debug_names, psyms_seen_size, write_gdbindex)
3926         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
3927
3928 2020-02-26  Aaron Merey  <amerey@redhat.com>
3929
3930         * Makefile.in: Handle optional debuginfod support.
3931         * NEWS: Update.
3932         * README: Add --with-debuginfod summary.
3933         * config.in: Regenerate.
3934         * configure: Regenerate.
3935         * configure.ac: Handle optional debuginfod support.
3936         * debuginfod-support.c: debuginfod helper functions.
3937         * debuginfod-support.h: Ditto.
3938         * doc/gdb.texinfo: Add --with-debuginfod to configure options
3939         summary.
3940         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
3941         when a dwz file cannot be found.
3942         * elfread.c (elf_symfile_read): Query debuginfod servers when a
3943         debuginfo file cannot be found.
3944         * source.c (open_source_file): Query debuginfod servers when a
3945         source file cannot be found.
3946         * top.c (print_gdb_configuration): Include
3947         --{with,without}-debuginfod in the output.
3948
3949 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
3950
3951         * thread.c (thr_try_catch_cmd): Print thread name.
3952
3953 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
3954
3955         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
3956         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3957         dwarf2_fetch_die_type_sect_off): Move to...
3958         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
3959         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3960         dwarf2_fetch_die_type_sect_off): ... here.
3961         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
3962         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3963         dwarf2_fetch_die_type_sect_off): Move doc to header file.
3964
3965 2020-02-26  Tom de Vries  <tdevries@suse.de>
3966
3967         PR gdb/25603
3968         * symfile.c (set_initial_language): Exit-early if
3969         language_mode == language_mode_manual.
3970
3971 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3972
3973         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
3974         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
3975         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
3976
3977 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
3978
3979         * gdbtypes.c (create_array_type_with_stride): Handle negative
3980         array strides.
3981         * valarith.c (value_subscripted_rvalue): Likewise.
3982
3983 2020-02-25  Luis Machado  <luis.machado@linaro.org>
3984
3985         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
3986
3987 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3988
3989         * loc.h (dwarf2_get_die_type): Move to...
3990         * read.h (dwarf2_get_die_type): ... here.
3991         * read.c (dwarf2_get_die_type): Move doc to header.
3992
3993 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
3994
3995         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
3996         'gnulib/Makefile.in' to the list.
3997
3998 2020-02-24  Tom Tromey  <tom@tromey.com>
3999
4000         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
4001         Remove.
4002         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
4003         XOBNEWVEC.
4004
4005 2020-02-24  Tom Tromey  <tom@tromey.com>
4006
4007         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
4008         New method.
4009         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
4010         (dw2_do_instantiate_symtab, dw2_get_file_names)
4011         (build_type_psymtab_dependencies, load_full_type_unit): Update.
4012
4013 2020-02-24  Tom Tromey  <tom@tromey.com>
4014
4015         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
4016         make_scoped_restore.
4017         (dwarf2_psymtab::read_symtab): Don't clear
4018         reading_partial_symbols.
4019
4020 2020-02-24  Tom de Vries  <tdevries@suse.de>
4021
4022         PR gdb/25592
4023         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
4024
4025 2020-02-24  Tom de Vries  <tdevries@suse.de>
4026
4027         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
4028         commands layout next/prev/regs.
4029
4030 2020-02-22  Tom Tromey  <tom@tromey.com>
4031
4032         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
4033         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
4034
4035 2020-02-22  Tom Tromey  <tom@tromey.com>
4036
4037         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
4038
4039 2020-02-22  Tom Tromey  <tom@tromey.com>
4040
4041         * tui/tui-win.c (_initialize_tui_win): Add usage text.
4042         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
4043         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
4044         * tui/tui.c (_initialize_tui): Add usage text.
4045
4046 2020-02-22  Tom Tromey  <tom@tromey.com>
4047
4048         * tui/tui-win.c (tui_set_focus_command)
4049         (tui_set_win_height_command): Use error_no_arg.
4050         (_initialize_tui_win): Update help text.
4051         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
4052
4053 2020-02-22  Tom Tromey  <tom@tromey.com>
4054
4055         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
4056         * tui/tui-disasm.h (struct tui_disasm_window)
4057         <display_start_addr>: Declare.
4058         * tui/tui-source.h (struct tui_source_window)
4059         <display_start_addr>: Declare.
4060         * tui/tui-winsource.h (struct tui_source_window_base)
4061         <show_source_line, display_start_addr>: New methods.
4062         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
4063         Rename and move to protected section.
4064         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
4065         (tui_source_window_base::do_erase_source_content): Update.
4066         (tui_source_window_base::show_source_line): Now a method.
4067         (tui_source_window_base::show_source_content)
4068         (tui_source_window_base::tui_source_window_base)
4069         (tui_source_window_base::rerender)
4070         (tui_source_window_base::refill)
4071         (tui_source_window_base::do_scroll_horizontal)
4072         (tui_source_window_base::set_is_exec_point_at)
4073         (tui_source_window_base::update_breakpoint_info)
4074         (tui_source_window_base::update_exec_info): Update.
4075         * tui/tui-source.c (tui_source_window::set_contents)
4076         (tui_source_window::showing_source_p)
4077         (tui_source_window::do_scroll_vertical)
4078         (tui_source_window::location_matches_p)
4079         (tui_source_window::line_is_displayed): Update.
4080         (tui_source_window::display_start_addr): New method.
4081         * tui/tui-disasm.c (tui_disasm_window::set_contents)
4082         (tui_disasm_window::do_scroll_vertical)
4083         (tui_disasm_window::location_matches_p): Update.
4084         (tui_disasm_window::display_start_addr): New method.
4085
4086 2020-02-22  Tom Tromey  <tom@tromey.com>
4087
4088         * NEWS: Add entry for gdb.register_window_type.
4089         * tui/tui-layout.h (window_factory): New typedef.
4090         (tui_register_window): Declare.
4091         * tui/tui-layout.c (saved_tui_windows): New global.
4092         (tui_apply_current_layout): Use it.
4093         (tui_register_window): New function.
4094         * python/python.c (do_start_initialization): Call
4095         gdbpy_initialize_tui.
4096         (python_GdbMethods): Add "register_window_type" function.
4097         * python/python-internal.h (gdbpy_register_tui_window)
4098         (gdbpy_initialize_tui): Declare.
4099         * python/py-tui.c: New file.
4100         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
4101
4102 2020-02-22  Tom Tromey  <tom@tromey.com>
4103
4104         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
4105
4106 2020-02-22  Tom Tromey  <tom@tromey.com>
4107
4108         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
4109         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
4110         * tui/tui-data.c (tui_set_win_with_focus): Remove.
4111         (tui_set_win_focus_to): Move from tui-win.c.
4112
4113 2020-02-22  Tom Tromey  <tom@tromey.com>
4114
4115         * tui/tui-layout.c (make_standard_window, get_locator_window): New
4116         functions.
4117         (known_window_types): New global.
4118         (tui_get_window_by_name): Reimplement.
4119         (initialize_known_windows): New function.
4120         (validate_window_name): Rewrite.
4121         (_initialize_tui_layout): Call initialize_known_windows.
4122
4123 2020-02-22  Tom Tromey  <tom@tromey.com>
4124
4125         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
4126         Remove constants.
4127         * tui/tui-winsource.h (struct tui_source_window_base)
4128         <tui_source_window_base>: Remove parameter.
4129         * tui/tui-winsource.c
4130         (tui_source_window_base::tui_source_window_base): Remove
4131         parameter.
4132         (tui_source_window_base::refill): Update.
4133         * tui/tui-stack.h (struct tui_locator_window)
4134         <tui_locator_window>: Update.
4135         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
4136         Default the constructor.
4137         * tui/tui-regs.h (struct tui_data_item_window)
4138         <tui_data_item_window>: Default the constructor.
4139         (struct tui_data_window) <tui_data_window>: Likewise.
4140         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
4141         Default the constructor.
4142         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
4143         Default the constructor.
4144         <type>: Remove.
4145         (struct tui_win_info) <tui_win_info>: Default the constructor.
4146         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
4147         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
4148         Default the constructor.
4149
4150 2020-02-22  Tom Tromey  <tom@tromey.com>
4151
4152         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
4153         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
4154         * tui/tui-win.c (tui_resize_all): Don't call
4155         tui_delete_invisible_windows.
4156         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
4157         done.
4158         (tui_set_layout): Update.
4159         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
4160         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
4161         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
4162
4163 2020-02-22  Tom Tromey  <tom@tromey.com>
4164
4165         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
4166         correctly.
4167
4168 2020-02-22  Tom Tromey  <tom@tromey.com>
4169
4170         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
4171
4172 2020-02-22  Tom Tromey  <tom@tromey.com>
4173
4174         * tui/tui-winsource.h (struct tui_source_window_iterator)
4175         <inner_iterator>: New etytypedef.
4176         <tui_source_window_iterator>: Take "end" parameter.
4177         <tui_source_window_iterator>: Take iterator.
4178         <operator*, advance>: Update.
4179         <m_iter>: Change type.
4180         <m_end>: New field.
4181         (struct tui_source_windows) <begin, end>: Update.
4182         * tui/tui-layout.c (tui_windows): New global.
4183         (tui_apply_current_layout): Clear tui_windows.
4184         (tui_layout_window::apply): Update tui_windows.
4185         * tui/tui-data.h (tui_windows): Declare.
4186         (all_tui_windows): Now inline function.
4187         (class tui_window_iterator, struct all_tui_windows): Remove.
4188
4189 2020-02-22  Tom Tromey  <tom@tromey.com>
4190
4191         PR tui/17850:
4192         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
4193         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
4194         "height" argument.
4195         (class tui_layout_window) <get_sizes>: Likewise.
4196         (class tui_layout_split) <tui_layout_split>: Add "vertical"
4197         argument.
4198         <get_sizes>: Add "height" argument.
4199         <m_vertical>: New field.
4200         * tui/tui-layout.c (tui_layout_split::clone): Update.
4201         (tui_layout_split::get_sizes): Add "height" argument.
4202         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
4203         (tui_new_layout_command): Parse "-horizontal".
4204         (_initialize_tui_layout): Update help string.
4205         (tui_layout_split::specification): Add "-horizontal" when needed.
4206         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
4207         argument.
4208         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
4209         New methods.
4210
4211 2020-02-22  Tom Tromey  <tom@tromey.com>
4212
4213         * tui/tui-layout.h (enum tui_adjust_result): New.
4214         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
4215         (class tui_layout_window) <adjust_size>: Return
4216         tui_adjust_result.  Rewrite.
4217         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
4218         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
4219
4220 2020-02-22  Tom Tromey  <tom@tromey.com>
4221
4222         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
4223         parameter and return types.
4224         (class tui_layout_base) <specification>: Add "depth".
4225         (class tui_layout_window) <specification>: Add "depth".
4226         (class tui_layout_split) <specification>: Add "depth".
4227         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
4228         and return types.
4229         (tui_new_layout_command): Parse sub-layouts.
4230         (_initialize_tui_layout): Update help string.
4231         (tui_layout_window::specification): Add "depth".
4232         (add_layout_command): Update.
4233
4234 2020-02-22  Tom Tromey  <tom@tromey.com>
4235
4236         * NEWS: Add "tui new-layout" item.
4237         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
4238         Add new-layout command to help text.
4239         (validate_window_name): New function.
4240         (tui_new_layout_command): New function.
4241         (_initialize_tui_layout): Register "new-layout".
4242         (tui_layout_window::specification): New method.
4243         (tui_layout_window::specification): New method.
4244         * tui/tui-layout.h (class tui_layout_base) <specification>: New
4245         method.
4246         (class tui_layout_window) <specification>: New method.
4247         (class tui_layout_split) <specification>: New method.
4248
4249 2020-02-22  Tom Tromey  <tom@tromey.com>
4250
4251         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
4252         * tui/tui-win.c (window_name_completer): Update comment.
4253         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
4254         Declare method.
4255         (class tui_layout_window) <replace_window>: Likewise.
4256         (class tui_layout_split) <replace_window>: Likewise.
4257         (tui_set_layout): Don't declare.
4258         (tui_set_initial_layout): Declare function.
4259         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
4260         (asm_regs_layout): New globals.
4261         (tui_current_layout, show_layout): Remove.
4262         (tui_set_layout, tui_add_win_to_layout): Rewrite.
4263         (find_layout, tui_apply_layout): New function.
4264         (layout_completer): Remove.
4265         (tui_next_layout): Reimplement.
4266         (tui_next_layout_command): New function.
4267         (tui_set_initial_layout, tui_prev_layout_command): New functions.
4268         (tui_regs_layout): Reimplement.
4269         (tui_regs_layout_command): New function.
4270         (extract_display_start_addr): Rewrite.
4271         (next_layout, prev_layout): Remove.
4272         (tui_layout_window::replace_window): New method.
4273         (tui_layout_split::replace_window): New method.
4274         (destroy_layout): New function.
4275         (layout_list): New global.
4276         (add_layout_command): New function.
4277         (initialize_layouts): Update.
4278         (tui_layout_command): New function.
4279         (_initialize_tui_layout): Install "layout" commands.
4280         * tui/tui-data.h (enum tui_layout_type): Remove.
4281         (tui_current_layout): Don't declare.
4282
4283 2020-02-22  Tom Tromey  <tom@tromey.com>
4284
4285         * tui/tui-regs.c (tui_reg_layout): Remove.
4286         (tui_reg_command): Use tui_regs_layout.
4287         * tui/tui-layout.h (tui_reg_command): Declare.
4288         * tui/tui-layout.c (tui_reg_command): New function.
4289
4290 2020-02-22  Tom Tromey  <tom@tromey.com>
4291
4292         * tui/tui.c (tui_rl_delete_other_windows): Call
4293         tui_remove_some_windows.
4294         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
4295         Declare method.
4296         (class tui_layout_window) <remove_windows>: New method.
4297         (class tui_layout_split) <remove_windows>: Declare.
4298         (tui_remove_some_windows): Declare.
4299         * tui/tui-layout.c (tui_remove_some_windows): New function.
4300         (tui_layout_split::remove_windows): New method.
4301
4302 2020-02-22  Tom Tromey  <tom@tromey.com>
4303
4304         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
4305         * tui/tui-layout.h (tui_next_layout): Declare.
4306         * tui/tui-layout.c (tui_next_layout): New function.
4307
4308 2020-02-22  Tom Tromey  <tom@tromey.com>
4309
4310         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
4311         correct coordinates.
4312
4313 2020-02-22  Tom Tromey  <tom@tromey.com>
4314
4315         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
4316         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
4317         DATA_WIN case.
4318
4319 2020-02-22  Tom Tromey  <tom@tromey.com>
4320
4321         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
4322         TUI_DISASM_WIN, not tui_win_list.
4323
4324 2020-02-22  Tom Tromey  <tom@tromey.com>
4325
4326         * valprint.c (generic_val_print_enum_1)
4327         (val_print_type_code_flags): Style member names.
4328         * rust-lang.c (val_print_struct, rust_print_enum)
4329         (rust_print_struct_def, rust_internal_print_type): Style member
4330         names.
4331         * p-valprint.c (pascal_object_print_value_fields): Style member
4332         names.  Only call fprintf_symbol_filtered for static members.
4333         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
4334         * f-valprint.c (f_val_print): Style member names.
4335         * f-typeprint.c (f_type_print_base): Style member names.
4336         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
4337         call fprintf_symbol_filtered for static members.
4338         (cp_print_class_member): Style member names.
4339         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
4340         member names.
4341         * ada-valprint.c (ada_print_scalar): Style enum names.
4342         (ada_val_print_enum): Likewise.
4343         * ada-typeprint.c (print_enum_type): Style enum names.
4344
4345 2020-02-21  Tom Tromey  <tom@tromey.com>
4346
4347         * psympriv.h (struct partial_symtab): Update comment.
4348
4349 2020-02-21  Tom Tromey  <tromey@adacore.com>
4350
4351         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
4352         type is CORE_ADDR.
4353
4354 2020-02-21  Tom de Vries  <tdevries@suse.de>
4355
4356         PR gdb/25534
4357         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
4358         if dependencies[i]->user != NULL.
4359
4360 2020-02-21  Ali Tamur  <tamur@google.com>
4361
4362         * dwarf2/read.c (dwarf2_name): Add null check.
4363
4364 2020-02-20  Tom Tromey  <tom@tromey.com>
4365
4366         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
4367         ">=", in binary search.
4368         (dwarf2_find_containing_comp_unit): New overload.
4369         (run_test): New self-test.
4370         (_initialize_dwarf2_read): Register new test.
4371
4372 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
4373
4374         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
4375         * riscv-tdep.h: Likewise.
4376         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
4377         rv32-only CSR.
4378         * features/riscv/64bit-csr.xml: Regenerated.
4379
4380 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
4381             Tom Tromey  <tom@tromey.com>
4382
4383         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
4384         of 'fputc_unfiltered'.
4385         (putchar_unfiltered): Call 'fputc_unfiltered'.
4386         (fputc_unfiltered): Call 'fputs_unfiltered'.
4387
4388 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
4389
4390         * config.in: Regenerate.
4391         * configure: Regenerate.
4392         * configure.ac: Add --with-python-libdir option.
4393         * main.c: Use WITH_PYTHON_LIBDIR.
4394
4395 2020-02-19  Tom Tromey  <tom@tromey.com>
4396
4397         * symtab.c (general_symbol_info::compute_and_set_names): Use
4398         obstack_strndup.  Simplify call to symbol_set_demangled_name.
4399
4400 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
4401
4402         * dwarf2/read.c (allocate_signatured_type_table,
4403         allocate_dwo_unit_table, allocate_type_unit_groups_table,
4404         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
4405         Remove objfile parameter, update all callers.
4406
4407 2020-02-19  Doug Evans  <dje@google.com>
4408
4409         PR rust/25535
4410         * rust-lang.c (rust_print_enum): Apply embedded_offset to
4411         rust_enum_variant calculation.
4412
4413 2020-02-19  Tom Tromey  <tromey@adacore.com>
4414
4415         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
4416
4417 2020-02-19  Tom Tromey  <tromey@adacore.com>
4418
4419         * ada-lang.c (cache_symbol): Use obstack_strdup.
4420
4421 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4422
4423         * configure: Regenerate.
4424
4425 2020-02-19  Tom Tromey  <tromey@adacore.com>
4426
4427         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
4428         NULL check.
4429
4430 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
4431
4432         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
4433
4434 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4435
4436         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
4437         if GDBSERVER is not defined.
4438         (riscv_tdesc_cache): Likewise, also store const target_desc.
4439         (STATIC_IN_GDB): Define.
4440         (riscv_create_target_description): Update declaration with
4441         STATIC_IN_GDB.
4442         (riscv_lookup_target_description): New function, only define if
4443         GDBSERVER is not defined.
4444         * arch/riscv.h (riscv_create_target_description): Declare only
4445         when GDBSERVER is defined.
4446         (riscv_lookup_target_description): New declaration when GDBSERVER
4447         is not defined.
4448         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
4449         (riscv_linux_read_features): ...this, and return
4450         riscv_gdbarch_features instead of target_desc.
4451         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
4452         (riscv_linux_read_description): Rename to...
4453         (riscv_linux_read_features): ...this.
4454         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
4455         Update to use riscv_gdbarch_features and
4456         riscv_lookup_target_description.
4457         * riscv-tdep.c (riscv_find_default_target_description): Use
4458         riscv_lookup_target_description instead of
4459         riscv_create_target_description.
4460
4461 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4462
4463         * valprint.c (generic_val_print_enum_1): When printing a flag
4464         enum with value 0 and there is no enumerator with value 0, print
4465         just "0" instead of "(unknown: 0x0)".
4466
4467 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4468
4469         * valprint.c (generic_val_print_enum_1): Print unknown part of
4470         flag enum in hex.
4471
4472 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4473
4474         * dwarf2/read.c (update_enumeration_type_from_children): Allow
4475         flag enums to contain duplicate enumerators.
4476         * valprint.c (generic_val_print_enum_1): Update comment.
4477
4478 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4479
4480         * dwarf2/read.c: Include "count-one-bits.h".
4481         (update_enumeration_type_from_children): If an enumerator has
4482         multiple bits set, don't treat the enumeration as a "flag enum".
4483         * valprint.c (generic_val_print_enum_1): Assert that enumerators
4484         of flag enums have 0 or 1 bit set.
4485
4486 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4487
4488         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
4489         conversion.
4490         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
4491         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
4492         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4493         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
4494         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4495
4496 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4497
4498         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
4499
4500 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4501
4502         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
4503         displaced_step_closure_up.
4504         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
4505         (struct displaced_step_closure_up):
4506         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
4507         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
4508         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
4509         Likewise.
4510         * gdbarch.sh (displaced_step_copy_insn): Likewise.
4511         * gdbarch.c, gdbarch.h: Re-generate.
4512         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
4513         displaced_step_closure_up.
4514         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4515         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
4516         * infrun.h (displaced_step_closure_up): New type alias.
4517         (struct displaced_step_inferior_state) <step_closure>: Change
4518         type to displaced_step_closure_up.
4519         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
4520         displaced_step_closure_up.
4521         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4522
4523 2020-02-14  Tom Tromey  <tom@tromey.com>
4524
4525         * minidebug.c (gnu_debug_key): New global.
4526         (find_separate_debug_file_in_section): Use it.
4527
4528 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4529
4530         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
4531         std::unique_ptr.
4532         * gdbarch.c: Re-generate.
4533         * gdbarch.h: Re-generate.
4534         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
4535         change.
4536         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
4537         type to std::unique_ptr.
4538         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
4539         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
4540         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
4541         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
4542         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
4543         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4544         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
4545         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
4546         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4547
4548 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4549
4550         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
4551         std::unique_ptr.
4552         (displaced_step_clear): Rename to...
4553         (displaced_step_reset): ... this.  Just call displaced->reset ().
4554         (displaced_step_clear_cleanup): Rename to...
4555         (displaced_step_reset_cleanup): ... this.
4556         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
4557         (displaced_step_fixup): Likewise.
4558         (resume_1): Likewise.
4559         (handle_inferior_event): Restore child's memory before calling
4560         displaced_step_fixup on the parent.
4561         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
4562         to std::unique_ptr.
4563         <step_closure>: Change type to std::unique_ptr.
4564
4565 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4566
4567         * arm-tdep.c: Include count-one-bits.h.
4568         (cleanup_block_store_pc): Use count_one_bits.
4569         (cleanup_block_load_pc): Use count_one_bits.
4570         (arm_copy_block_xfer): Use count_one_bits.
4571         (thumb2_copy_block_xfer): Use count_one_bits.
4572         (thumb_copy_pop_pc_16bit): Use count_one_bits.
4573         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
4574         (thumb_get_next_pcs_raw): Use count_one_bits.
4575         (arm_get_next_pcs_raw): Use count_one_bits_l.
4576         * arch/arm.c (bitcount): Remove.
4577         * arch/arm.h (bitcount): Remove.
4578
4579 2020-02-14  Tom Tromey  <tromey@adacore.com>
4580
4581         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
4582         Update.
4583         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
4584         * dwarf2/loc.c (call_site_find_chain_1): Return
4585         unique_xmalloc_ptr.
4586         (call_site_find_chain): Likewise.
4587
4588 2020-02-14  Richard Biener  <rguenther@suse.de>
4589
4590         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
4591         on expression with division operators.
4592
4593 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
4594
4595         * MAINTAINERS (Write After Approval): Adding myself.
4596
4597 2020-02-12  Tom Tromey  <tom@tromey.com>
4598
4599         * event-loop.c (event_data, gdb_event, event_handler_func):
4600         Remove.
4601
4602 2020-02-12  Tom Tromey  <tom@tromey.com>
4603
4604         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
4605         (dwarf2_frame_objfile_data): Add comment.
4606         (find_comp_unit, set_comp_unit): New functions.
4607         (dwarf2_frame_find_fde): Use find_comp_unit.
4608         (dwarf2_build_frame_info): Use set_comp_unit.
4609
4610 2020-02-12  Tom Tromey  <tom@tromey.com>
4611
4612         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
4613         (comp_unit): Don't initialize objfile.
4614         (execute_cfa_program): Add text_offset parameter.
4615         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
4616         (dwarf2_frame_cache): Update.
4617         (dwarf2_build_frame_info): Don't set "objfile" member.
4618
4619 2020-02-12  Tom Tromey  <tom@tromey.com>
4620
4621         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
4622         (decode_frame_entry): Likewise.
4623         (dwarf2_build_frame_info): Update.
4624
4625 2020-02-12  Tom Tromey  <tom@tromey.com>
4626
4627         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
4628         (decode_frame_entry_1): Use the comp_unit obstack.
4629
4630 2020-02-12  Tom Tromey  <tom@tromey.com>
4631
4632         * dwarf2/frame.c (struct comp_unit): Add initializers and
4633         constructor.
4634         (dwarf2_frame_objfile_data): Store a comp_unit.
4635         (dwarf2_frame_find_fde): Update.
4636         (dwarf2_build_frame_info): Use "new".
4637
4638 2020-02-12  Tom Tromey  <tom@tromey.com>
4639
4640         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
4641         (dwarf2_fde_table): Typedef for std::vector.
4642         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
4643         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
4644         (decode_frame_entry): Update.
4645         (dwarf2_build_frame_info): Use "new".
4646
4647 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
4648
4649         * arm-tdep.c (arm_gdbarch_init): Update.
4650         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
4651         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
4652         have_neon, is_m>: Change to bool.
4653
4654 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
4655
4656         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
4657
4658 2020-02-12  Tom Tromey  <tom@tromey.com>
4659
4660         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
4661
4662 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
4663
4664         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
4665         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
4666
4667 2020-02-11  Tom Tromey  <tom@tromey.com>
4668
4669         * psymtab.h: Update comment.
4670
4671 2020-02-11  Tom Tromey  <tom@tromey.com>
4672
4673         * gdb_obstack.h (struct auto_obstack): Use
4674         DISABLE_COPY_AND_ASSIGN.
4675
4676 2020-02-11  Tom Tromey  <tom@tromey.com>
4677
4678         * dwarf2/frame.h (struct objfile): Don't forward declare.
4679
4680 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4681
4682         * cris-tdep.c (cris_supply_gregset): Change signature to match
4683         what struct regset expects.
4684         (cris_regset): New struct.
4685         (fetch_core_registers): Remove.
4686         (cris_iterate_over_regset_sections): New function.
4687         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
4688         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
4689
4690 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4691
4692         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
4693         registers.
4694
4695 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4696
4697         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
4698
4699 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4700
4701         * configure: Re-generate.
4702
4703 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4704
4705         * configure: Re-generate.
4706
4707 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4708
4709         * acinclude: Update warning.m4 path.
4710         * warning.m4: Move to gdbsupport.
4711
4712 2020-02-11  Tom Tromey  <tromey@adacore.com>
4713
4714         * remote.c (remote_console_output): Update.
4715         * printcmd.c (printf_command): Update.
4716         * event-loop.c (gdb_wait_for_event): Update.
4717         * linux-nat.c (sigchld_handler): Update.
4718         * remote-sim.c (gdb_os_write_stdout): Update.
4719         (gdb_os_flush_stdout): Update.
4720         (gdb_os_flush_stderr): Update.
4721         (gdb_os_write_stderr): Update.
4722         * exceptions.c (print_exception): Update.
4723         * remote-fileio.c (remote_fileio_func_read): Update.
4724         (remote_fileio_func_write): Update.
4725         * tui/tui.c (tui_enable): Update.
4726         * tui/tui-interp.c (tui_interp::init): Update.
4727         * utils.c (init_page_info): Update.
4728         (putchar_unfiltered, fputc_unfiltered): Update.
4729         (gdb_flush): Update.
4730         (emit_style_escape): Update.
4731         (flush_wrap_buffer, fputs_maybe_filtered): Update.
4732         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
4733         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
4734         (stderr_file::write): Update.
4735         (stderr_file::puts): Update.
4736         * ui-file.h (ui_file_isatty, ui_file_write)
4737         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
4738         (ui_file_puts): Don't declare.
4739
4740 2020-02-10  Tom de Vries  <tdevries@suse.de>
4741
4742         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
4743         sentinel to char *.
4744
4745 2020-02-09  Tom de Vries  <tdevries@suse.de>
4746
4747         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
4748         filename if it matches "<artificial>".
4749
4750 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4751
4752         * windows-tdep.c (struct enum_value_name): New struct.
4753         (create_enum): New function.
4754         (windows_get_siginfo_type): Create and use enum types.
4755
4756 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4757
4758         * NEWS: Mention $_siginfo support for Windows.
4759         * windows-nat.c (handle_exception): Set siginfo_er.
4760         (windows_nat_target::mourn_inferior): Reset siginfo_er.
4761         (windows_xfer_siginfo): New function.
4762         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
4763         * windows-tdep.c (struct windows_gdbarch_data): New struct.
4764         (init_windows_gdbarch_data): New function.
4765         (get_windows_gdbarch_data): New function.
4766         (windows_get_siginfo_type): New function.
4767         (windows_init_abi): Register windows_get_siginfo_type.
4768         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
4769
4770 2020-02-08  Tom Tromey  <tom@tromey.com>
4771
4772         * dwarf2/read.c (class cutu_reader) <cutu_reader,
4773         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
4774         <keep>: Declare method.
4775         <m_keep>: Remove member.
4776         <~cutu_reader>: Remove.
4777         (cutu_reader::init_tu_and_read_dwo_dies): Update.
4778         (cutu_reader::cutu_reader): Update.
4779         (cutu_reader::keep): Rename from ~cutu_reader.
4780         (process_psymtab_comp_unit, build_type_psymtabs_1)
4781         (process_skeletonless_type_unit, load_partial_comp_unit)
4782         (load_full_comp_unit, dwarf2_read_addr_index)
4783         (read_signatured_type): Update.
4784
4785 2020-02-08  Tom Tromey  <tom@tromey.com>
4786
4787         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
4788         "want_partial_unit" parameter.
4789         (process_psymtab_comp_unit): Change want_partial_unit to bool.
4790         Inline check for DW_TAG_partial_unit.
4791         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
4792
4793 2020-02-08  Tom Tromey  <tom@tromey.com>
4794
4795         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
4796         read.c.
4797         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
4798         read.c.
4799
4800 2020-02-08  Tom Tromey  <tom@tromey.com>
4801
4802         * dwarf2/read.c (read_address): Move to comp-unit.c.
4803         (dwarf2_rnglists_process, dwarf2_ranges_process)
4804         (read_attribute_value, dwarf_decode_lines_1)
4805         (var_decode_location, decode_locdesc): Update.
4806         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
4807         read.c.  Remove "cu" parameter.
4808         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
4809         method.
4810
4811 2020-02-08  Tom Tromey  <tom@tromey.com>
4812
4813         * dwarf2/read.c (read_attribute_value, read_indirect_string)
4814         (read_indirect_line_string): Update.
4815         * dwarf2/comp-unit.c (read_offset): Remove.
4816         (read_comp_unit_head): Update.
4817         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
4818         method.
4819         (read_offset): Don't declare.
4820
4821 2020-02-08  Tom Tromey  <tom@tromey.com>
4822
4823         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
4824         * dwarf2/read.c (struct comp_unit_head): Move to
4825         dwarf2/comp-unit.h.
4826         (enum class rcuh_kind): Move to comp-unit.h.
4827         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
4828         (read_comp_unit_head, error_check_comp_unit_head)
4829         (read_and_check_comp_unit_head): Move to comp-unit.c.
4830         (read_offset, dwarf_unit_type_name): Likewise.
4831         (create_debug_type_hash_table, read_cutu_die_from_dwo)
4832         (cutu_reader::cutu_reader, read_call_site_scope)
4833         (find_partial_die, follow_die_offset): Update.
4834         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
4835
4836 2020-02-08  Tom Tromey  <tom@tromey.com>
4837
4838         * dwarf2/read.c (read_offset_1): Move to leb.c.
4839         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
4840         (dwarf_decode_macro_bytes): Update.
4841         * dwarf2/leb.c (read_offset): Rename; move from read.c.
4842         * dwarf2/leb.h (read_offset): Declare.
4843
4844 2020-02-08  Tom Tromey  <tom@tromey.com>
4845
4846         * dwarf2/read.c (dwarf2_section_size): Remove.
4847         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
4848         Update.
4849         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
4850
4851 2020-02-08  Tom Tromey  <tom@tromey.com>
4852
4853         * dwarf2/read.c (read_initial_length): Move to leb.c.
4854         * dwarf2/leb.h (read_initial_length): Declare.
4855         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
4856         handle_nonstd parameter.
4857         * dwarf2/frame.c (read_initial_length): Remove.
4858         (decode_frame_entry_1): Update.
4859
4860 2020-02-08  Tom Tromey  <tom@tromey.com>
4861
4862         * dwarf2/loc.c (dwarf2_find_location_expression)
4863         (dwarf_evaluate_loc_desc::get_tls_address)
4864         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
4865         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
4866         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
4867         (dwarf2_compile_property_to_c)
4868         (dwarf2_loc_desc_get_symbol_read_needs)
4869         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
4870         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
4871         (loclist_describe_location, loclist_tracepoint_var_ref)
4872         (loclist_generate_c_location): Update.
4873         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
4874         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
4875         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
4876         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
4877         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
4878         (dwarf2_per_cu_data::addr_size)
4879         (dwarf2_per_cu_data::ref_addr_size)
4880         (dwarf2_per_cu_data::text_offset)
4881         (dwarf2_per_cu_data::addr_type): Now methods.
4882         (per_cu_header_read_in): Make per_cu "const".
4883         (dwarf2_version): Remove.
4884         (dwarf2_per_cu_data::int_type): Now a method.
4885         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
4886         (set_die_type, read_array_type, read_subrange_index_type)
4887         (read_tag_string_type, read_subrange_type): Update.
4888         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
4889         offset_size, ref_addr_size, text_offset, addr_type, version,
4890         objfile, int_type, addr_sized_int_type>: Declare methods.
4891
4892 2020-02-08  Tom Tromey  <tom@tromey.com>
4893
4894         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
4895         Move earlier.
4896
4897 2020-02-08  Tom Tromey  <tom@tromey.com>
4898
4899         * dwarf2/read.h (dwarf_line_debug): Declare.
4900         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
4901         * dwarf2/read.c: Move line_header code to new files.
4902         (dwarf_line_debug): No longer static.
4903         * dwarf2/line-header.c: New file.
4904         * dwarf2/line-header.h: New file.
4905
4906 2020-02-08  Tom Tromey  <tom@tromey.com>
4907
4908         * dwarf2/read.c (struct line_header) <file_full_name,
4909         file_file_name>: Return unique_xmalloc_ptr.
4910         (line_header::file_file_name): Update.
4911         (line_header::file_full_name): Update.
4912         (dw2_get_file_names_reader): Update.
4913         (macro_start_file): Update.
4914
4915 2020-02-08  Tom Tromey  <tom@tromey.com>
4916
4917         * dwarf2/read.c (struct line_header) <file_full_name,
4918         file_file_name>: Declare methods.
4919         (dw2_get_file_names_reader): Update.
4920         (file_file_name): Now a method.
4921         (file_full_name): Likewise.
4922         (macro_start_file): Update.
4923
4924 2020-02-08  Tom Tromey  <tom@tromey.com>
4925
4926         * dwarf2/read.c (dwarf_always_disassemble)
4927         (show_dwarf_always_disassemble): Move to loc.c.
4928         (_initialize_dwarf2_read): Move "always-disassemble" registration
4929         to loc.c.
4930         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
4931         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
4932         static.
4933         (show_dwarf_always_disassemble): Move from read.c.
4934         (_initialize_dwarf2loc): Move always-disassemble from read.c.
4935
4936 2020-02-08  Tom Tromey  <tom@tromey.com>
4937
4938         * dwarf2/read.c (~dwarf2_per_objfile): Update.
4939         (create_quick_file_names_table): Return htab_up.
4940         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
4941         Update.
4942         * dwarf2/read.h (struct dwarf2_per_objfile)
4943         <quick_file_names_table>: Now htab_up.
4944
4945 2020-02-08  Tom Tromey  <tom@tromey.com>
4946
4947         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
4948
4949 2020-02-08  Tom Tromey  <tom@tromey.com>
4950
4951         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
4952         Rewrite.
4953         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
4954         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
4955         (abbrev_table::abbrev_table): No longer inline.
4956         (ABBREV_HASH_SIZE): Remove.
4957         (abbrev_table::m_abbrevs): Now an htab_up.
4958
4959 2020-02-08  Tom Tromey  <tom@tromey.com>
4960
4961         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
4962         (cutu_reader): Update.
4963         (build_type_psymtabs_1): Update.
4964         * dwarf2/abbrev.c (abbrev_table::read): Rename.
4965         (abbrev_table::alloc_abbrev): Update.
4966         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
4967         (abbrev_table::read): New static method, renamed from
4968         abbrev_table_read_table.
4969         (abbrev_table::alloc_abbrev)
4970         (abbrev_table::add_abbrev): Now private.
4971         (abbrev_table::abbrev_table): Now private.
4972         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
4973
4974 2020-02-08  Tom Tromey  <tom@tromey.com>
4975
4976         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
4977         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
4978         htab_up.
4979
4980 2020-02-08  Tom Tromey  <tom@tromey.com>
4981
4982         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
4983         htab_up.
4984         (lookup_dwo_unit_in_dwp): Update.
4985         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
4986         on obstack.
4987
4988 2020-02-08  Tom Tromey  <tom@tromey.com>
4989
4990         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
4991         obstack.
4992
4993 2020-02-08  Tom Tromey  <tom@tromey.com>
4994
4995         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
4996         line_header_hash.
4997         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
4998         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
4999         Change type to htab_up.
5000
5001 2020-02-08  Tom Tromey  <tom@tromey.com>
5002
5003         * dwarf2/read.c (allocate_type_unit_groups_table): Return
5004         htab_up.  Don't allocate on obstack.
5005         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
5006         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
5007         Change type to htab_up.
5008
5009 2020-02-08  Tom Tromey  <tom@tromey.com>
5010
5011         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
5012         Change type to htab_up.
5013         * dwarf2/read.c (create_signatured_type_table_from_index)
5014         (create_signatured_type_table_from_debug_names)
5015         (create_all_type_units, add_type_unit)
5016         (lookup_dwo_signatured_type, lookup_signatured_type)
5017         (process_skeletonless_type_unit): Update.
5018         (create_debug_type_hash_table, create_debug_types_hash_table):
5019         Change type of types_htab.
5020         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
5021         htab_up.  Don't allocate on obstack.
5022         (create_cus_hash_table): Change type of cus_htab parameter.
5023         (struct dwo_file) <cus, tus>: Now htab_up.
5024         (lookup_dwo_signatured_type, lookup_dwo_cutu)
5025         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
5026         (queue_and_load_all_dwo_tus): Update.
5027         * dwarf2/index-write.c (write_gdbindex): Update.
5028         (write_debug_names): Update.
5029
5030 2020-02-08  Tom Tromey  <tom@tromey.com>
5031
5032         * dwarf2/read.h (struct dwarf2_queue_item): Move from
5033         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
5034         destructor.
5035         (struct dwarf2_per_objfile) <queue>: New member.
5036         * dwarf2/read.c (struct dwarf2_queue_item): Move to
5037         dwarf2/read.h.
5038         (dwarf2_queue, dwarf2_queue_tail): Remove.
5039         (class dwarf2_queue_guard): Add parameter to constructor.  Use
5040         DISABLE_COPY_AND_ASSIGN.
5041         <m_per_objfile>: New member.
5042         <~dwarf2_queue_guard>: Rewrite.
5043         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
5044         Update.
5045         (~dwarf2_queue_item): New.
5046
5047 2020-02-08  Tom Tromey  <tom@tromey.com>
5048
5049         * dwarf2/read.c (struct die_info) <has_children>: New member.
5050         (dw2_get_file_names_reader): Remove has_children.
5051         (dw2_get_file_names): Update.
5052         (read_cutu_die_from_dwo): Remove has_children.
5053         (cutu_reader::init_tu_and_read_dwo_dies)
5054         (cutu_reader::cutu_reader): Update.
5055         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
5056         Remove has_children.
5057         (build_type_psymtabs_1, process_skeletonless_type_unit)
5058         (load_partial_comp_unit, load_full_comp_unit): Update.
5059         (create_dwo_cu_reader): Remove has_children.
5060         (create_cus_hash_table, read_die_and_children): Update.
5061         (read_full_die_1,read_full_die): Remove has_children.
5062         (read_signatured_type): Update.
5063         (class cutu_reader) <has_children>: Remove.
5064
5065 2020-02-08  Tom Tromey  <tom@tromey.com>
5066
5067         * dwarf2/expr.c: Rename from dwarf2expr.c.
5068         * dwarf2/expr.h: Rename from dwarf2expr.h.
5069         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
5070         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
5071         * dwarf2/frame.c: Rename from dwarf2-frame.c.
5072         * dwarf2/frame.h: Rename from dwarf2-frame.h.
5073         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
5074         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
5075         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
5076         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
5077         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
5078         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
5079         * dwarf2/loc.c: Rename from dwarf2loc.c.
5080         * dwarf2/loc.h: Rename from dwarf2loc.h.
5081         * dwarf2/read.c: Rename from dwarf2read.c.
5082         * dwarf2/read.h: Rename from dwarf2read.h.
5083         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
5084         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
5085         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
5086         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
5087         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
5088         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
5089         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
5090         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
5091         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
5092         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
5093         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
5094         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
5095         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
5096         Update.
5097         * Makefile.in (COMMON_SFILES): Update.
5098         (HFILES_NO_SRCDIR): Update.
5099
5100 2020-02-08  Tom Tromey  <tom@tromey.com>
5101
5102         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
5103         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
5104
5105 2020-02-08  Tom Tromey  <tom@tromey.com>
5106
5107         * dwarf2read.h (struct die_info): Don't declare.
5108
5109 2020-02-08  Tom Tromey  <tom@tromey.com>
5110
5111         * dwarf2read.h (die_info_ptr): Remove typedef.
5112
5113 2020-02-08  Tom Tromey  <tom@tromey.com>
5114
5115         * dwarf2read.c (read_call_site_scope)
5116         (handle_data_member_location, dwarf2_add_member_fn)
5117         (mark_common_block_symbol_computed, read_common_block)
5118         (attr_to_dynamic_prop, partial_die_info::read)
5119         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
5120         (dwarf2_symbol_mark_computed, set_die_type): Update.
5121         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
5122         method.
5123         (attr_form_is_block): Don't declare.
5124         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
5125
5126 2020-02-08  Tom Tromey  <tom@tromey.com>
5127
5128         * dwarf2read.c (dwarf2_find_base_address, )
5129         (read_call_site_scope, rust_containing_type)
5130         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
5131         (handle_data_member_location, dwarf2_add_member_fn)
5132         (get_alignment, read_structure_type, process_structure_scope)
5133         (mark_common_block_symbol_computed, read_common_block)
5134         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
5135         (partial_die_info::read, read_attribute_value, new_symbol)
5136         (lookup_die_type, dwarf2_get_ref_die_offset)
5137         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
5138         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
5139         (dwarf2_symbol_mark_computed): Update.
5140         * dwarf2/attribute.h (struct attribute) <value_as_address,
5141         form_is_section_offset, form_is_constant, form_is_ref>: Declare
5142         methods.
5143         (value_as_address, attr_form_is_section_offset)
5144         (attr_form_is_constant, attr_form_is_ref): Don't declare.
5145         * dwarf2/attribute.c (attribute::value_as_address)
5146         (attribute::form_is_section_offset, attribute::form_is_constant)
5147         (attribute::form_is_ref): Now methods.
5148
5149 2020-02-08  Tom Tromey  <tom@tromey.com>
5150
5151         * dwarf2read.c (struct attribute, DW_STRING)
5152         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
5153         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
5154         (attr_form_is_block, attr_form_is_section_offset)
5155         (attr_form_is_constant, attr_form_is_ref): Move.
5156         * dwarf2/attribute.h: New file.
5157         * dwarf2/attribute.c: New file, from dwarf2read.c.
5158         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
5159
5160 2020-02-08  Tom Tromey  <tom@tromey.com>
5161
5162         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
5163         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
5164         Move.
5165         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
5166         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
5167         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
5168         abbrev.c.
5169         * dwarf2/abbrev.h: New file.
5170         * dwarf2/abbrev.c: New file, from dwarf2read.c.
5171         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
5172
5173 2020-02-08  Tom Tromey  <tom@tromey.com>
5174
5175         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
5176         (dwarf2_section_size, dwarf2_get_section_info)
5177         (create_signatured_type_table_from_debug_names)
5178         (create_addrmap_from_aranges, read_debug_names_from_section)
5179         (get_gdb_index_contents_from_section, read_comp_unit_head)
5180         (error_check_comp_unit_head, read_abbrev_offset)
5181         (create_debug_type_hash_table, init_cu_die_reader)
5182         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
5183         (read_comp_units_from_section, create_cus_hash_table)
5184         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
5185         (create_dwp_v2_section, dwarf2_rnglists_process)
5186         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
5187         (abbrev_table_read_table, read_indirect_string_at_offset_from)
5188         (read_indirect_string_from_dwz, read_addr_index_1)
5189         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
5190         (dwarf_decode_macro_bytes, dwarf_decode_macros)
5191         (fill_in_loclist_baton): Update.
5192         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
5193         get_containing_section, get_bfd_owner, get_bfd_section,
5194         get_file_name, get_id, get_flags, empty, read>: Declare methods.
5195         (dwarf2_read_section, get_section_name, get_section_file_name)
5196         (get_containing_section, get_section_bfd_owner)
5197         (get_section_bfd_section, get_section_name, get_section_file_name)
5198         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
5199         declare.
5200         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
5201         (dwarf2_section_info::get_bfd_owner)
5202         (dwarf2_section_info::get_bfd_section)
5203         (dwarf2_section_info::get_name)
5204         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
5205         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
5206         (dwarf2_section_info::read): Now methods.
5207         * dwarf-index-write.c (class debug_names): Update.
5208
5209 2020-02-08  Tom Tromey  <tom@tromey.com>
5210
5211         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
5212         Move to dwarf2/section.h.
5213         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
5214         (get_section_bfd_section, get_section_name)
5215         (get_section_file_name, get_section_id, get_section_flags)
5216         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
5217         dwarf2/section.c.
5218         * dwarf2/section.h: New file.
5219         * dwarf2/section.c: New file, from dwarf2read.c.
5220         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
5221
5222 2020-02-08  Tom Tromey  <tom@tromey.com>
5223
5224         * dwarf2read.h (read_unsigned_leb128): Don't declare.
5225         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
5226         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
5227         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
5228         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
5229         * dwarf2/leb.h: New file, from dwarf2read.c.
5230         * dwarf2/leb.c: New file, from dwarf2read.c.
5231         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
5232         Remove.
5233         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
5234         (COMMON_SFILES): Add dwarf2/leb.c.
5235
5236 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
5237
5238         GDB 9.1 released.
5239
5240 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
5241
5242         PR gdb/25190:
5243         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
5244         * gdb/remote.c (remote_console_output): Update.
5245         * gdb/ui-file.c (fputs_unfiltered): Rename to...
5246         (ui_file_puts): ...this.
5247         * gdb/ui-file.h (ui_file_puts): Add declaration.
5248         * gdb/utils.c (emit_style_escape): Update.
5249         (flush_wrap_buffer): Update.
5250         (fputs_maybe_filtered): Update.
5251         (fputs_unfiltered): Add function.
5252
5253 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
5254
5255         * gdb/event-loop.c (gdb_wait_for_event): Update.
5256         * gdb/printcmd.c (printf_command): Update.
5257         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
5258         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
5259         (gdb_os_flush_stderr): Update.
5260         * gdb/remote.c (remote_console_output): Update.
5261         * gdb/ui-file.c (gdb_flush): Rename to...
5262         (ui_file_flush): ...this.
5263         (stderr_file::write): Update.
5264         (stderr_file::puts): Update.
5265         * gdb/ui-file.h (gdb_flush): Rename to...
5266         (ui_file_flush): ...this.
5267         * gdb/utils.c (gdb_flush): Add function.
5268         * gdb/utils.h (gdb_flush): Add declaration.
5269
5270 2020-02-07  Tom Tromey  <tromey@adacore.com>
5271
5272         PR breakpoints/24915:
5273         * source.c (find_and_open_source): Do not check basenames_may_differ.
5274
5275 2020-02-07  Tom Tromey  <tom@tromey.com>
5276
5277         * README: Update gdbserver documentation.
5278         * gdbserver: Move to top level.
5279         * configure.tgt (build_gdbserver): Remove.
5280         * configure.ac: Remove --enable-gdbserver.
5281         * configure: Rebuild.
5282         * Makefile.in (distclean): Don't mention gdbserver.
5283
5284 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
5285
5286         * source-cache.c (source_cache::ensure): Surround
5287         get_plain_source_lines with a try/catch.
5288         (source_cache::get_line_charpos): Get rid of try/catch
5289         and only check for the return value of "ensure".
5290         * tui/tui-source.c (tui_source_window::set_contents):
5291         Simplify "nlines" calculation.
5292
5293 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
5294
5295         * MAINTAINERS (Write After Approval): Add myself.
5296
5297 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
5298
5299         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
5300         function call.
5301
5302 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
5303
5304         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
5305
5306 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
5307
5308         * nat/riscv-linux-tdesc.h: New file.
5309         * nat/riscv-linux-tdesc.c: New file, taking code from...
5310         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
5311         ... here.
5312         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
5313         NATDEPFILES.
5314
5315 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
5316
5317         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
5318         we don't set the fake simulator ptid to the null_ptid.
5319
5320 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
5321
5322         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
5323         * gdbthread.h (class thread_info) <resumed>: Likewise.
5324         * infrun.c (resume_1): Likewise.
5325         (proceed): Likewise.
5326         (infrun_thread_stop_requested): Likewise.
5327         (stop_all_threads): Likewise.
5328         (handle_inferior_event): Likewise.
5329         (restart_threads): Likewise.
5330         (finish_step_over): Likewise.
5331         (keep_going_stepped_thread): Likewise.
5332         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
5333         (linux_handle_extended_wait): Likewise.
5334         * record-btrace.c (get_thread_current_frame_id): Likewise.
5335         * record-full.c (record_full_wait_1): Likewise.
5336         * remote.c (remote_target::process_initial_stop_replies): Likewise.
5337         * target.c (target_resume): Likewise.
5338         * thread.c (set_running_thread): Likewise.
5339
5340 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
5341
5342         * f-valprint.c (f77_print_array_1): Changed datatype of index
5343         variable to LONGEST from int to enable it to contain bound
5344         values correctly.
5345
5346 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
5347
5348         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
5349         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
5350         offsets according to FLEN determined.
5351         (riscv_linux_nat_target::read_description): Determine FLEN
5352         dynamically.
5353         (riscv_linux_nat_target::fetch_registers): Size regset buffer
5354         according to FLEN determined.
5355         (riscv_linux_nat_target::store_registers): Likewise.
5356
5357 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
5358
5359         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
5360         when reg->group is empty and reggroup is not.
5361
5362 2020-01-31  Tom Tromey  <tromey@adacore.com>
5363
5364         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
5365         Call beneath target's mourn_inferior after unpushing.
5366
5367 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
5368
5369         PR tui/9765
5370         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
5371         have enough lines to fill the screen, still return the lowest
5372         address we found.
5373
5374 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
5375
5376         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
5377         '-', '<', and '>' commands.
5378
5379 2020-01-29  Pedro Alves  <palves@redhat.com>
5380             Sergio Durigan Junior  <sergiodj@redhat.com>
5381
5382         * infcmd.c (construct_inferior_arguments): Assert that
5383         'argc' is greater than 0.
5384
5385 2020-01-29  Luis Machado  <luis.machado@linaro.org>
5386
5387         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
5388         (BRK_INSN_MASK): Define to 0xd4200000.
5389         (aarch64_program_breakpoint_here_p): New function.
5390         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
5391         * arch-utils.c (default_program_breakpoint_here_p): Moved from
5392         breakpoint.c.
5393         * arch-utils.h (default_program_breakpoint_here_p): Moved from
5394         breakpoint.h
5395         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
5396         call gdbarch_program_breakpoint_here_p.
5397         (program_breakpoint_here): Moved to arch-utils.c, renamed to
5398         default_program_breakpoint_here_p, changed return type to bool and
5399         simplified.
5400         * breakpoint.h (program_breakpoint_here): Moved prototype to
5401         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
5402         return type to bool.
5403         * gdbarch.c: Regenerate.
5404         * gdbarch.h: Regenerate.
5405         * gdbarch.sh (program_breakpoint_here_p): New method.
5406         * infrun.c (handle_signal_stop): Call
5407         gdbarch_program_breakpoint_here_p.
5408
5409 2020-01-26  Tom Tromey  <tom@tromey.com>
5410
5411         * ctfread.c (struct ctf_fp_info): Reindent.
5412         (_initialize_ctfread): Remove.
5413
5414 2020-01-26  Tom Tromey  <tom@tromey.com>
5415
5416         * psymtab.c (partial_map_expand_apply)
5417         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
5418         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
5419         (psym_print_stats, psym_expand_symtabs_for_function)
5420         (psym_map_symbol_filenames, psym_map_matching_symbols)
5421         (psym_expand_symtabs_matching)
5422         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
5423         (maintenance_check_psymtabs): Use new methods.
5424         * psympriv.h (struct partial_symtab) <readin_p,
5425         get_compunit_symtab>: New methods.
5426         <readin, compunit_symtab>: Remove members.
5427         (struct standard_psymtab): New.
5428         (struct legacy_psymtab): Derive from standard_psymtab.
5429         * dwarf2read.h (struct dwarf2_psymtab): Derive from
5430         standard_psymtab.
5431         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
5432
5433 2020-01-26  Tom Tromey  <tom@tromey.com>
5434
5435         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
5436         read_dependencies.  Add assert.
5437         * psymtab.c (partial_symtab::read_dependencies): New method.
5438         * psympriv.h (struct partial_symtab) <read_dependencies>: New
5439         method.
5440         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
5441         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
5442         read_dependencies.
5443         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
5444         Add assert.
5445
5446 2020-01-26  Tom Tromey  <tom@tromey.com>
5447
5448         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
5449         Call expand_psymtab.
5450         (xcoff_read_symtab): Call expand_psymtab.
5451         (xcoff_start_psymtab, xcoff_end_psymtab): Set
5452         legacy_expand_psymtab.
5453         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
5454         method.
5455         (struct legacy_psymtab) <expand_psymtab>: Implement.
5456         <legacy_expand_psymtab>: New member.
5457         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
5458         (parse_partial_symbols): Set legacy_expand_psymtab.
5459         (psymtab_to_symtab_1): Change argument order.  Call
5460         expand_psymtab.
5461         (new_psymtab): Set legacy_expand_psymtab.
5462         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
5463         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
5464         expand_psymtab.
5465         (dwarf2_psymtab::expand_psymtab): Rename from
5466         psymtab_to_symtab_1.  Call expand_psymtab.
5467         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
5468         (dbx_end_psymtab): Likewise.
5469         (dbx_psymtab_to_symtab_1): Change argument order. Call
5470         expand_psymtab.
5471         (dbx_read_symtab): Call expand_psymtab.
5472         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
5473         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
5474         (ctf_psymtab::read_symtab): Call expand_psymtab.
5475
5476 2020-01-26  Tom Tromey  <tom@tromey.com>
5477
5478         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
5479         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
5480         messages.
5481         * mdebugread.c (mdebug_read_symtab): Remove prints.
5482         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
5483         assert.
5484         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
5485
5486 2020-01-26  Tom Tromey  <tom@tromey.com>
5487
5488         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
5489         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
5490         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
5491         legacy_symtab.
5492         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
5493         * psymtab.c (psymtab_to_symtab): Call method.
5494         (dump_psymtab): Update.
5495         * psympriv.h (struct partial_symtab): Add virtual destructor.
5496         <read_symtab>: New method.
5497         (struct legacy_symtab): New.
5498         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
5499         (struct pst_map) <pst>: Now a legacy_psymtab.
5500         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
5501         (new_psymtab): Use legacy_psymtab.
5502         * dwarf2read.h (struct dwarf2_psymtab): New.
5503         (struct dwarf2_per_cu_data) <psymtab>: Use it.
5504         * dwarf2read.c (dwarf2_create_include_psymtab)
5505         (dwarf2_build_include_psymtabs, create_type_unit_group)
5506         (create_partial_symtab, process_psymtab_comp_unit_reader)
5507         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
5508         (set_partial_user): Use dwarf2_psymtab.
5509         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
5510         (psymtab_to_symtab_1, process_full_comp_unit)
5511         (process_full_type_unit, dwarf2_ranges_read)
5512         (dwarf2_get_pc_bounds, psymtab_include_file_name)
5513         (dwarf_decode_lines): Use dwarf2_psymtab.
5514         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
5515         (add_address_entry_worker, write_one_signatured_type)
5516         (recursively_count_psymbols, recursively_write_psymbols)
5517         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
5518         (write_debug_names): Likewise.
5519         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
5520         <pst>: Now a legacy_psymtab.
5521         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
5522         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
5523         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
5524         * ctfread.c (struct ctf_psymtab): New.
5525         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
5526         ctf_psymtab.
5527         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
5528         (create_partial_symtab): Return a ctf_psymtab.
5529         (scan_partial_symbols): Update.
5530
5531 2020-01-26  Tom Tromey  <tom@tromey.com>
5532
5533         * xcoffread.c (xcoff_start_psymtab): Use new.
5534         * psymtab.c (partial_symtab::partial_symtab): New constructor,
5535         renamed from start_psymtab_common.
5536         * psympriv.h (struct partial_symtab): Add new constructor.
5537         (start_psymtab_common): Don't declare.
5538         * mdebugread.c (parse_partial_symbols): Use new.
5539         * dwarf2read.c (create_partial_symtab): Use new.
5540         * dbxread.c (start_psymtab): Use new.
5541         * ctfread.c (create_partial_symtab): Use new.
5542
5543 2020-01-26  Tom Tromey  <tom@tromey.com>
5544
5545         * xcoffread.c (xcoff_end_psymtab): Use new.
5546         * psymtab.c (start_psymtab_common): Use new.
5547         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
5548         Update.
5549         * psympriv.h (struct partial_symtab): Add parameters to
5550         constructor.  Don't inline.
5551         (allocate_psymtab): Don't declare.
5552         * mdebugread.c (new_psymtab): Use new.
5553         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
5554         * dbxread.c (dbx_end_psymtab): Use new.
5555
5556 2020-01-26  Tom Tromey  <tom@tromey.com>
5557
5558         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
5559         allocate_psymtab.  Update documentation.
5560         * psymtab.c (psymtab_storage::install_psymtab): Rename from
5561         allocate_psymtab.  Do not use new.
5562         (allocate_psymtab): Use new.  Update.
5563
5564 2020-01-26  Tom Tromey  <tom@tromey.com>
5565
5566         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
5567         * psymtab.c (psym_print_stats): Update.
5568         * psympriv.h (struct partial_symtab) <readin,
5569         psymtabs_addrmap_supported, anonymous>: Now bool.
5570         * mdebugread.c (psymtab_to_symtab_1): Update.
5571         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
5572         (build_type_psymtabs_reader, psymtab_to_symtab_1)
5573         (process_full_comp_unit, process_full_type_unit): Update.
5574         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
5575         * ctfread.c (psymtab_to_symtab): Update.
5576
5577 2020-01-26  Tom Tromey  <tom@tromey.com>
5578
5579         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
5580         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
5581         * psymtab.c (psymtab_storage): Delete psymtabs.
5582         (psymtab_storage::allocate_psymtab): Use new.
5583         (psymtab_storage::discard_psymtab): Use delete.
5584         * psympriv.h (struct partial_symtab): Add constructor and
5585         initializers.
5586
5587 2020-01-26  Tom Tromey  <tom@tromey.com>
5588
5589         * machoread.c: Do not include psympriv.h.
5590
5591 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5592
5593         * NEWS: Mention the new option and the set/show commands.
5594
5595 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5596
5597         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
5598         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
5599         (validate_exec_file): New variables, enums, functions.
5600         (exec_file_locate_attach, print_section_info): Style the filenames.
5601         (_initialize_exec): Install show_exec_file_mismatch_command and
5602          set_exec_file_mismatch_command.
5603         * gdbcore.h (validate_exec_file): Declare.
5604         * infcmd.c (attach_command): Call validate_exec_file.
5605         * remote.c ( remote_target::remote_add_inferior): Likewise.
5606
5607 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5608
5609         * frame.c (find_frame_sal): Move call to get_next_frame into more
5610         inner scope.
5611         * inline-frame.c (inilne_state) <inline_state>: Update argument
5612         types.
5613         (inilne_state) <skipped_symbol>: Rename to...
5614         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
5615         (skip_inline_frames): Build vector of skipped symbols and use this
5616         to reate the inline_state.
5617         (inline_skipped_symbol): Add a comment and some assertions, fetch
5618         skipped symbol from the list.
5619
5620 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5621
5622         * buildsym.c (lte_is_less_than): Delete.
5623         (buildsym_compunit::end_symtab_with_blockvector): Create local
5624         lambda function to sort line table entries, and use
5625         std::stable_sort instead of std::sort.
5626         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
5627         markers when looking for a previous line.
5628
5629 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5630
5631         * dwarf2read.c (lnp_state_machine::record_line): Include
5632         end_sequence parameter in debug print out.  Record the line if we
5633         are at an end_sequence marker even if it's not the start of a
5634         statement.
5635         * symmisc.c (maintenance_print_one_line_table): Print end of
5636         sequence markers with 'END' not '0'.
5637
5638 2020-01-24  Pedro Alves  <palves@redhat.com>
5639
5640         PR gdb/25410
5641         * thread.c (scoped_restore_current_thread::restore): Use
5642         switch_to_inferior_no_thread.
5643         * exec.c: Include "progspace-and-thread.h".
5644         (add_target_sections, remove_target_sections):
5645         scoped_restore_current_pspace_and_thread instead of
5646         scoped_restore_current_thread.
5647         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
5648         and aspace to the inferior before calling clone_program_space.
5649         Remove stale comment.
5650
5651 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5652
5653         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
5654         (arm_netbsd_nat_target::fetch_registers): ...this.
5655         (arm_nbsd_nat_target::store_registers): Rename to...
5656         (arm_netbsd_nat_target::store_registers): ...this.
5657
5658 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5659
5660         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5661         register_t.
5662
5663 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5664
5665         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
5666         Update comment.
5667         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
5668         Likewise.
5669         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
5670         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
5671         the correct replacement (iterate_over_regset_sections).
5672         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
5673         Update comment.
5674
5675 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
5676
5677         PR gdb/23718
5678         * gdb/python/python.c (execute_gdb_command): Call
5679         async_enable_stdin in catch block.
5680
5681 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5682
5683         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
5684         SWITCH_THRU_ALL_UIS.
5685
5686 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5687
5688         PR tui/9765
5689         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
5690         comment, add extra parameter, and update to store previous symbol
5691         when appropriate.
5692         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
5693         add extra parameter.
5694         * tui/tui-disasm.c (tui_disassemble): Update header comment,
5695         remove unneeded parameter, add try/catch around gdb_print_insn,
5696         rewrite to add items to asm_lines vector.
5697         (tui_find_backward_disassembly_start_address): New function.
5698         (tui_find_disassembly_address): Updated throughout.
5699         (tui_disasm_window::set_contents): Update for changes to
5700         tui_disassemble.
5701         (tui_disasm_window::do_scroll_vertical): No need to adjust the
5702         number of lines to scroll.
5703
5704 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
5705
5706         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
5707         (SECT_OFF_DATA): Likewise.
5708         (SECT_OFF_RODATA): Likewise.
5709         (SECT_OFF_TEXT): Likewise.
5710         (SECT_OFF_BSS): Likewise.
5711         (struct objfile) <text_section_offset, data_section_offset>: New
5712         methods.
5713         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
5714         objfile::text_section_offset.
5715         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
5716         * coffread.c (coff_symtab_read): Likewise.
5717         (enter_linenos): Likewise.
5718         (process_coff_symbol): Likewise.
5719         * ctfread.c (get_objfile_text_range): Likewise.
5720         * dtrace-probe.c (dtrace_probe::get_relocated_address):
5721         Use objfile::data_section_offset.
5722         * dwarf2-frame.c (execute_cfa_program): Use
5723         objfile::text_section_offset.
5724         (dwarf2_frame_find_fde): Likewise.
5725         * dwarf2read.c (create_addrmap_from_index): Likewise.
5726         (create_addrmap_from_aranges): Likewise.
5727         (dw2_find_pc_sect_compunit_symtab): Likewise.
5728         (process_psymtab_comp_unit_reader): Likewise.
5729         (add_partial_symbol): Likewise.
5730         (add_partial_subprogram): Likewise.
5731         (process_full_comp_unit): Likewise.
5732         (read_file_scope): Likewise.
5733         (read_func_scope): Likewise.
5734         (read_lexical_block_scope): Likewise.
5735         (read_call_site_scope): Likewise.
5736         (dwarf2_rnglists_process): Likewise.
5737         (dwarf2_ranges_process): Likewise.
5738         (dwarf2_ranges_read): Likewise.
5739         (dwarf_decode_lines_1): Likewise.
5740         (new_symbol): Likewise.
5741         (dwarf2_fetch_die_loc_sect_off): Likewise.
5742         (dwarf2_per_cu_text_offset): Likewise.
5743         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
5744         * hppa-tdep.c (read_unwind_info): Likewise.
5745         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
5746         * psympriv.h (struct partial_symtab): Likewise.
5747         * psymtab.c (find_pc_sect_psymtab): Likewise.
5748         * solib-svr4.c (enable_break): Likewise.
5749         * stap-probe.c (relocate_address): Use
5750         objfile::data_section_offset.
5751         * xcoffread.c (enter_line_range): Use
5752         objfile::text_section_offset.
5753         (read_xcoff_symtab): Likewise.
5754
5755 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5756
5757         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
5758         declaration to narrower scopes.
5759
5760 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5761
5762         * darwin-nat.h (struct darwin_exception_msg, enum
5763         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
5764         Move up.
5765         (class darwin_nat_target) <wait_1, check_new_threads,
5766         decode_exception_message, decode_message, stop_inferior,
5767         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
5768         * darwin-nat.c (darwin_check_new_threads): Rename to...
5769         (darwin_nat_target::check_new_threads): ... this.
5770         (darwin_suspend_inferior_it): Remove.
5771         (darwin_decode_exception_message): Rename to...
5772         (darwin_nat_target::decode_exception_message): ... this.
5773         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
5774         (darwin_decode_message): Rename to...
5775         (darwin_nat_target::decode_message): ... this.
5776         (cancel_breakpoint): Rename to...
5777         (darwin_nat_target::cancel_breakpoint): ... this.
5778         (darwin_wait): Rename to...
5779         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
5780         instead of iterate_over_inferiors.
5781         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
5782         (darwin_stop_inferior): Rename to...
5783         (darwin_nat_target::stop_inferior): ... this.
5784         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
5785         (darwin_init_thread_list): Rename to...
5786         (darwin_nat_target::init_thread_list): ... this.
5787         (darwin_ptrace_him): Rename to...
5788         (darwin_nat_target::ptrace_him): ... this.
5789         (darwin_nat_target::create_inferior): Pass lambda function to
5790         fork_inferior.
5791         (darwin_nat_target::detach): Call stop_inferior instead of
5792         darwin_stop_inferior.
5793         * fork-inferior.h (fork_inferior): Change init_trace_fun
5794         parameter to gdb::function_view.
5795         * fork-inferior.c (fork_inferior): Likewise.
5796
5797 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
5798
5799         * i386-cygwin-tdep.c (core_process_module_section): Update.
5800         * windows-nat.c (struct lm_info_windows): Add text_offset.
5801         (windows_xfer_shared_libraries): Update.
5802         * windows-tdep.c (windows_xfer_shared_library):
5803         Add text_offset_cached argument.
5804         * windows-tdep.h (windows_xfer_shared_library): Update.
5805
5806 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5807
5808         * gdbarch.sh: Add declaration for _initialize_gdbarch.
5809
5810 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5811
5812         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
5813         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
5814         replace with range-based for.
5815         (gdbsim_interrupt_inferior): Remove.
5816         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
5817         with a range-based for.  Inline code from
5818         gdbsim_interrupt_inferior.
5819
5820 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5821
5822         * infrun.c (proceed): Fix indentation.
5823
5824 2020-01-21  Tom Tromey  <tromey@adacore.com>
5825
5826         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
5827         * python/python.c (python_extension_ops): Update.
5828         (gdbpy_colorize): New function.
5829         * python/lib/gdb/__init__.py (colorize): New function.
5830         * extension.h (ext_lang_colorize): Declare.
5831         * extension.c (ext_lang_colorize): New function.
5832         * extension-priv.h (struct extension_language_ops) <colorize>: New
5833         member.
5834         * cli/cli-style.c (_initialize_cli_style): Update help text.
5835
5836 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5837
5838         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
5839         <cond>: Change type to bool.
5840         (aarch64_displaced_step_b_cond): Update cond to use bool type.
5841         (aarch64_displaced_step_cb): Likewise.
5842         (aarch64_displaced_step_tb): Likewise.
5843
5844 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5845
5846         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
5847         output.
5848
5849 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5850
5851         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
5852         <pc_adjust>: Adjust the documentation.
5853         (aarch64_displaced_step_fixup): Check if PC really moved before
5854         adjusting it.
5855
5856 2020-01-19  Tom Tromey  <tom@tromey.com>
5857
5858         * disasm.c (~gdb_disassembler): New destructor.
5859         (gdb_buffered_insn_length): Call disassemble_free_target.
5860         * disasm.h (class gdb_disassembler): Declare destructor.  Use
5861         DISABLE_COPY_AND_ASSIGN.
5862
5863 2020-01-19  Tom Tromey  <tom@tromey.com>
5864
5865         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
5866         (die_reader_func_ftype): Remove.
5867         (cutu_reader): New class.
5868         (dw2_get_file_names_reader): Remove "data" parameter.
5869         (dw2_get_file_names): Use cutu_reader.
5870         (create_debug_type_hash_table): Update.
5871         (read_cutu_die_from_dwo): Update comment.
5872         (lookup_dwo_unit): Add dwo_name parameter.
5873         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
5874         die_reader_func_ftype and data parameters.
5875         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
5876         Remove die_reader_func_ftype and data parameters.
5877         (~cutu_reader): New; from init_cutu_and_read_dies.
5878         (cutu_reader::cutu_reader): Rename from
5879         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
5880         and data parameters.
5881         (init_cutu_and_read_dies_simple): Remove.
5882         (struct process_psymtab_comp_unit_data): Remove.
5883         (process_psymtab_comp_unit_reader): Remove data parameter; add
5884         want_partial_unit and pretend_language parameters.
5885         (process_psymtab_comp_unit): Use cutu_reader.
5886         (build_type_psymtabs_reader): Remove data parameter.
5887         (build_type_psymtabs_1): Use cutu_reader.
5888         (process_skeletonless_type_unit): Likewise.
5889         (load_partial_comp_unit_reader): Remove.
5890         (load_partial_comp_unit): Use cutu_reader.
5891         (load_full_comp_unit_reader): Remove.
5892         (load_full_comp_unit): Use cutu_reader.
5893         (struct create_dwo_cu_data): Remove.
5894         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
5895         dwo_unit parameters.
5896         (create_cus_hash_table): Use cutu_reader.
5897         (struct dwarf2_read_addr_index_data): Remove.
5898         (dwarf2_read_addr_index_reader): Remove.
5899         (dwarf2_read_addr_index): Use cutu_reader.
5900         (read_signatured_type_reader): Remove.
5901         (read_signatured_type): Use cutu_reader.
5902
5903 2020-01-19  Tom Tromey  <tom@tromey.com>
5904
5905         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
5906         * tui/tui-wingeneral.h (class tui_suppress_output): New.
5907         (tui_wrefresh): Declare.
5908         * tui/tui-wingeneral.c (suppress_output): New global.
5909         (tui_suppress_output, ~tui_suppress_output): New constructor and
5910         destructor.
5911         (tui_wrefresh): New function.
5912         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
5913         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
5914         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
5915         method.
5916         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
5917         tui_wrefresh.
5918         (tui_data_window::no_refresh): New method.
5919         (tui_data_item_window::refresh_window): Call tui_wrefresh.
5920         (tui_reg_command): Use tui_suppress_output
5921         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
5922         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
5923         method.
5924         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
5925
5926 2020-01-19  Tom Tromey  <tom@tromey.com>
5927
5928         * tui/tui-winsource.c (tui_update_source_windows_with_line):
5929         Handle case where symtab is null.
5930
5931 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
5932
5933         * linux-fork.c (one_fork_p): Simplify.
5934
5935 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5936
5937         * top.c (struct qt_args): Remove.
5938         (kill_or_detach): Change return type to void, replace `void *`
5939         parameter with a proper one.
5940         (print_inferior_quit_action):  Likewise.
5941         (quit_confirm): Use range-based for loop to iterate over inferiors.
5942         (quit_force): Likewise.
5943
5944 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5945
5946         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
5947         `void *` parameter with proper parameters.
5948         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
5949         (print_one_inferior): Change return type to void, replace `void *`
5950         parameter with proper parameters.
5951         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
5952         inferiors.
5953         (get_other_inferior): Remove.
5954         (mi_cmd_remove_inferior): Use range-based loop to iterate over
5955         inferiors.
5956
5957 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5958
5959         * mi/mi-interp.c (report_initial_inferior): Remove.
5960         (mi_interp::init): Use range-based for to iterate over inferiors.
5961
5962 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5963
5964         * python/py-inferior.c (build_inferior_list): Remove.
5965         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
5966
5967 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
5968
5969         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
5970         (btrace_stitch_trace): Likewise.
5971         * charset.c (intermediate_encoding): Likewise (vaild).
5972         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
5973         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
5974         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
5975
5976 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
5977
5978         * windows-tdep.c (windows_get_tlb_type):
5979         Add rtl_user_process_parameters type.
5980
5981 2020-01-16  Pedro Alves  <palves@redhat.com>
5982             Norbert Lange  <nolange79@gmail.com>
5983
5984         PR build/24805
5985         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
5986         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
5987         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
5988         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
5989         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
5990         (ps_plog): Redeclare exported functions with default visibility.
5991
5992 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
5993
5994         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
5995         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
5996
5997 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
5998
5999         * infcmd.c (post_create_inferior): Use get_thread_regcache
6000         instead of get_current_regcache.
6001
6002 2020-01-14  Tom Tromey  <tom@tromey.com>
6003
6004         PR symtab/12535:
6005         * python/python.c (gdbpy_decode_line): Treat empty string the same
6006         as no argument.
6007
6008 2020-01-14  Tom Tromey  <tom@tromey.com>
6009
6010         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
6011
6012 2020-01-14  Tom Tromey  <tom@tromey.com>
6013
6014         * nat/linux-btrace.c: Don't include <config.h>.
6015         * nat/linux-ptrace.c: Don't include <config.h>.
6016         * nat/x86-linux-dregs.c: Don't include <config.h>.
6017
6018 2020-01-14  Tom Tromey  <tom@tromey.com>
6019
6020         * configure: Rebuild.
6021         * configure.ac: Move many checks to ../gdbsupport/common.m4.
6022
6023 2020-01-14  Tom Tromey  <tom@tromey.com>
6024
6025         * nat/x86-linux-dregs.c: Include configh.h.
6026         * nat/linux-ptrace.c: Include configh.h.
6027         * nat/linux-btrace.c: Include configh.h.
6028         * defs.h: Include config.h, bfd.h.
6029         * configure.ac: Don't source common.host.
6030         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
6031         * configure: Rebuild.
6032         * acinclude.m4: Update path.
6033         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
6034         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
6035         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
6036         (CLIBS): Add LIBSUPPORT.
6037         (CDEPS): Likewise.
6038         (COMMON_SFILES): Remove gdbsupport files.
6039         (HFILES_NO_SRCDIR): Likewise.
6040         (stamp-version): Update path to create-version.sh.
6041         (ALLDEPFILES): Remove gdbsupport files.
6042
6043 2020-01-14  Tom Tromey  <tom@tromey.com>
6044
6045         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
6046         USE_WIN32API when needed.
6047         * configure.ac (USE_WIN32API): Don't define.
6048         (WIN32LIBS): Use WIN32APILIBS.
6049         * configure: Rebuild.
6050
6051 2020-01-14  Tom Tromey  <tom@tromey.com>
6052
6053         * configure: Rebuild.
6054         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
6055
6056 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6057
6058         * skip.c (skip_function_command): Make skip w/o arguments use the
6059         name of the inlined function if pc is inside any inlined function.
6060
6061 2020-01-14  Luis Machado  <luis.machado@linaro.org>
6062
6063         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
6064         * infrun.c (resume_1): Likewise.
6065         (handle_inferior_event): Remove stale comment.
6066         * linux-nat.c (linux_nat_target::resume): Update comments.
6067         (save_stop_reason): Likewise.
6068         (linux_nat_filter_event): Likewise.
6069         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
6070
6071 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6072
6073         * elfread.c (record_minimal_symbol): Set section index to 0 for
6074         non-allocatable sections.
6075
6076
6077 2020-01-13  Ali Tamur <tamur@google.com>
6078
6079         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
6080         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
6081         to gdb::optional.  Update comments.
6082         (dwo_file): Update comments.
6083         (read_attribute): Update API to take an additional out parameter,
6084         need_reprocess.  This is used to mark attributes that need other
6085         attributes (e.g. str_offsets_base) for correct computation which may not
6086         have been read yet.
6087         (read_attribute_reprocess): New function declaration.
6088         (read_addr_index): Likewise.
6089         (read_dwo_str_index): Likewise.
6090         (read_stub_str_index): Likewise.
6091         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
6092         (lookup_addr_base): New function definition.
6093         (lookup_ranges_base): Likewise.
6094         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
6095         lookup_ranges_base.
6096         (init_cutu_and_read_dies): Update comments.
6097         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
6098         unit.  This is used to inherit parent's str_offsets_base and addr_base.
6099         Update comments.
6100         (init_cutu_and_read_dies_simple): Reflect API changes.
6101         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
6102         (create_cus_hash_table): Change API to take parent compile unit.
6103         Reflect API changes.
6104         (open_and_init_dwo_file): Reflect API changes.
6105         (dwarf2_get_pc_bounds): Update comments.
6106         (dwarf2_record_block_ranges): Likewise.
6107         (read_full_die_1): Change implementation to reprocess attributes that
6108         need str_offsets_base and addr_base.
6109         (partial_die_info::read): Likewise.
6110         (read_attribute_reprocess): New function definition.
6111         (read_attribute_value): Change API to take an additional out parameter,
6112         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
6113         when a non-dwo compile unit has index based attributes.
6114         (read_attribute): Reflect API changes.
6115         (read_addr_index_1): Reflect API changes.  Update comments.
6116         (dwarf2_read_addr_index_data): Reflect API changes.
6117         (dwarf2_read_addr_index): Likewise.
6118         (read_str_index): Change API and implementation.  This becomes a helper
6119         to be used by the new string index related methods.  Update error
6120         message and comments.
6121         (read_dwo_str_index): New function definition.
6122         (read_stub_str_index): Likewise.
6123         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
6124         * symfile.h (dwarf2_debug_sections): Likewise.
6125         * xcoffread.c (dwarf2_debug_sections): Likewise.
6126
6127 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
6128
6129         * gdbcore.h (struct core_fns) <core_read_registers>: Change
6130         core_reg_sect type to gdb_byte *.
6131         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
6132         * cris-tdep.c (fetch_core_registers): Likewise.
6133         * corelow.c (core_target::get_core_register_section): Change
6134         type of `contents` to gdb::byte_vector.
6135
6136 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6137
6138         * tui/tui-wingeneral.c (box_win): Position the title in the center
6139         of the border.
6140
6141 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6142
6143         * corelow.c (core_target::get_core_register_section): Use
6144           std::vector instead of alloca.
6145
6146 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
6147
6148         * warning.m4: Add -Wmissing-declarations to build_warnings.
6149         * configure: Re-generate.
6150
6151 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
6152
6153         * python/python.c (init__gdb_module): Add declaration.
6154
6155 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
6156
6157         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
6158         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
6159         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
6160         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
6161         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
6162         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
6163         * ada-exp.y (_initialize_ada_exp): Add declaration.
6164         * ada-lang.c (_initialize_ada_language): Add declaration.
6165         * ada-tasks.c (_initialize_tasks): Add declaration.
6166         * agent.c (_initialize_agent): Add declaration.
6167         * aix-thread.c (_initialize_aix_thread): Add declaration.
6168         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
6169         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
6170         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
6171         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
6172         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
6173         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
6174         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
6175         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
6176         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
6177         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
6178         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
6179         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
6180         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
6181         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
6182         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
6183         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
6184         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
6185         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
6186         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
6187         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
6188         * annotate.c (_initialize_annotate): Add declaration.
6189         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
6190         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
6191         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
6192         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
6193         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
6194         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
6195         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
6196         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
6197         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
6198         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
6199         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
6200         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
6201         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
6202         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
6203         * auto-load.c (_initialize_auto_load): Add declaration.
6204         * auxv.c (_initialize_auxv): Add declaration.
6205         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
6206         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
6207         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
6208         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
6209         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
6210         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
6211         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
6212         * breakpoint.c (_initialize_breakpoint): Add declaration.
6213         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
6214         * btrace.c (_initialize_btrace): Add declaration.
6215         * charset.c (_initialize_charset): Add declaration.
6216         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
6217         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
6218         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
6219         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
6220         * cli/cli-script.c (_initialize_cli_script): Add declaration.
6221         * cli/cli-style.c (_initialize_cli_style): Add declaration.
6222         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
6223         * coffread.c (_initialize_coffread): Add declaration.
6224         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
6225         * compile/compile.c (_initialize_compile): Add declaration.
6226         * complaints.c (_initialize_complaints): Add declaration.
6227         * completer.c (_initialize_completer): Add declaration.
6228         * copying.c (_initialize_copying): Add declaration.
6229         * corefile.c (_initialize_core): Add declaration.
6230         * corelow.c (_initialize_corelow): Add declaration.
6231         * cp-abi.c (_initialize_cp_abi): Add declaration.
6232         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
6233         * cp-support.c (_initialize_cp_support): Add declaration.
6234         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
6235         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
6236         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
6237         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
6238         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
6239         * ctfread.c (_initialize_ctfread): Add declaration.
6240         * d-lang.c (_initialize_d_language): Add declaration.
6241         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
6242         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
6243         * dbxread.c (_initialize_dbxread): Add declaration.
6244         * dcache.c (_initialize_dcache): Add declaration.
6245         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
6246         * disasm.c (_initialize_disasm): Add declaration.
6247         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
6248         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
6249         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
6250         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
6251         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
6252         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
6253         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
6254         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
6255         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
6256         * elfread.c (_initialize_elfread): Add declaration.
6257         * exec.c (_initialize_exec): Add declaration.
6258         * extension.c (_initialize_extension): Add declaration.
6259         * f-lang.c (_initialize_f_language): Add declaration.
6260         * f-valprint.c (_initialize_f_valprint): Add declaration.
6261         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
6262         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
6263         * filesystem.c (_initialize_filesystem): Add declaration.
6264         * findcmd.c (_initialize_mem_search): Add declaration.
6265         * findvar.c (_initialize_findvar): Add declaration.
6266         * fork-child.c (_initialize_fork_child): Add declaration.
6267         * frame-base.c (_initialize_frame_base): Add declaration.
6268         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
6269         * frame.c (_initialize_frame): Add declaration.
6270         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
6271         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
6272         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
6273         * gcore.c (_initialize_gcore): Add declaration.
6274         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
6275         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
6276         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
6277         * gdbarch.c (_initialize_gdbarch): Add declaration.
6278         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
6279         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
6280         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
6281         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
6282         * go-lang.c (_initialize_go_language): Add declaration.
6283         * go32-nat.c (_initialize_go32_nat): Add declaration.
6284         * guile/guile.c (_initialize_guile): Add declaration.
6285         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
6286         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
6287         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
6288         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
6289         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
6290         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
6291         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
6292         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
6293         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
6294         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
6295         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
6296         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
6297         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
6298         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
6299         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
6300         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
6301         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
6302         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
6303         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
6304         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
6305         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
6306         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
6307         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
6308         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
6309         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
6310         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
6311         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
6312         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
6313         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
6314         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
6315         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
6316         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
6317         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
6318         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
6319         * infcall.c (_initialize_infcall): Add declaration.
6320         * infcmd.c (_initialize_infcmd): Add declaration.
6321         * inflow.c (_initialize_inflow): Add declaration.
6322         * infrun.c (_initialize_infrun): Add declaration.
6323         * interps.c (_initialize_interpreter): Add declaration.
6324         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
6325         * jit.c (_initialize_jit): Add declaration.
6326         * language.c (_initialize_language): Add declaration.
6327         * linux-fork.c (_initialize_linux_fork): Add declaration.
6328         * linux-nat.c (_initialize_linux_nat): Add declaration.
6329         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
6330         * linux-thread-db.c (_initialize_thread_db): Add declaration.
6331         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
6332         * m2-lang.c (_initialize_m2_language): Add declaration.
6333         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
6334         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
6335         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
6336         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
6337         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
6338         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
6339         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
6340         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
6341         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
6342         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
6343         * machoread.c (_initialize_machoread): Add declaration.
6344         * macrocmd.c (_initialize_macrocmd): Add declaration.
6345         * macroscope.c (_initialize_macroscope): Add declaration.
6346         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
6347         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
6348         * maint.c (_initialize_maint_cmds): Add declaration.
6349         * mdebugread.c (_initialize_mdebugread): Add declaration.
6350         * memattr.c (_initialize_mem): Add declaration.
6351         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
6352         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
6353         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
6354         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
6355         * mi/mi-main.c (_initialize_mi_main): Add declaration.
6356         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
6357         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
6358         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
6359         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
6360         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
6361         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
6362         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
6363         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
6364         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
6365         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
6366         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
6367         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
6368         * mipsread.c (_initialize_mipsread): Add declaration.
6369         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
6370         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
6371         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
6372         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
6373         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
6374         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
6375         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
6376         * nto-procfs.c (_initialize_procfs): Add declaration.
6377         * objc-lang.c (_initialize_objc_language): Add declaration.
6378         * observable.c (_initialize_observer): Add declaration.
6379         * opencl-lang.c (_initialize_opencl_language): Add declaration.
6380         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
6381         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
6382         * osabi.c (_initialize_gdb_osabi): Add declaration.
6383         * osdata.c (_initialize_osdata): Add declaration.
6384         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
6385         * parse.c (_initialize_parse): Add declaration.
6386         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
6387         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
6388         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
6389         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
6390         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
6391         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
6392         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
6393         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
6394         * printcmd.c (_initialize_printcmd): Add declaration.
6395         * probe.c (_initialize_probe): Add declaration.
6396         * proc-api.c (_initialize_proc_api): Add declaration.
6397         * proc-events.c (_initialize_proc_events): Add declaration.
6398         * proc-service.c (_initialize_proc_service): Add declaration.
6399         * procfs.c (_initialize_procfs): Add declaration.
6400         * producer.c (_initialize_producer): Add declaration.
6401         * psymtab.c (_initialize_psymtab): Add declaration.
6402         * python/python.c (_initialize_python): Add declaration.
6403         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
6404         * record-btrace.c (_initialize_record_btrace): Add declaration.
6405         * record-full.c (_initialize_record_full): Add declaration.
6406         * record.c (_initialize_record): Add declaration.
6407         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
6408         * regcache.c (_initialize_regcache): Add declaration.
6409         * reggroups.c (_initialize_reggroup): Add declaration.
6410         * remote-notif.c (_initialize_notif): Add declaration.
6411         * remote-sim.c (_initialize_remote_sim): Add declaration.
6412         * remote.c (_initialize_remote): Add declaration.
6413         * reverse.c (_initialize_reverse): Add declaration.
6414         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
6415         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
6416         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
6417         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
6418         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
6419         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
6420         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
6421         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
6422         Add declaration.
6423         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
6424         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
6425         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
6426         * rust-exp.y (_initialize_rust_exp): Add declaration.
6427         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
6428         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
6429         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
6430         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
6431         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
6432         * score-tdep.c (_initialize_score_tdep): Add declaration.
6433         * ser-go32.c (_initialize_ser_dos): Add declaration.
6434         * ser-mingw.c (_initialize_ser_windows): Add declaration.
6435         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
6436         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
6437         * ser-uds.c (_initialize_ser_socket): Add declaration.
6438         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
6439         * serial.c (_initialize_serial): Add declaration.
6440         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
6441         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
6442         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
6443         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
6444         * skip.c (_initialize_step_skip): Add declaration.
6445         * sol-thread.c (_initialize_sol_thread): Add declaration.
6446         * solib-aix.c (_initialize_solib_aix): Add declaration.
6447         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
6448         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
6449         * solib-frv.c (_initialize_frv_solib): Add declaration.
6450         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
6451         * solib-target.c (_initialize_solib_target): Add declaration.
6452         * solib.c (_initialize_solib): Add declaration.
6453         * source-cache.c (_initialize_source_cache): Add declaration.
6454         * source.c (_initialize_source): Add declaration.
6455         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
6456         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
6457         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
6458         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
6459         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
6460         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
6461         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
6462         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
6463         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
6464         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
6465         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
6466         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
6467         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
6468         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
6469         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
6470         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
6471         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
6472         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
6473         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
6474         * stabsread.c (_initialize_stabsread): Add declaration.
6475         * stack.c (_initialize_stack): Add declaration.
6476         * stap-probe.c (_initialize_stap_probe): Add declaration.
6477         * std-regs.c (_initialize_frame_reg): Add declaration.
6478         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
6479         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
6480         * symfile.c (_initialize_symfile): Add declaration.
6481         * symmisc.c (_initialize_symmisc): Add declaration.
6482         * symtab.c (_initialize_symtab): Add declaration.
6483         * target.c (_initialize_target): Add declaration.
6484         * target-connection.c (_initialize_target_connection): Add
6485         declaration.
6486         * target-dcache.c (_initialize_target_dcache): Add declaration.
6487         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
6488         * thread.c (_initialize_thread): Add declaration.
6489         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
6490         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
6491         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
6492         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
6493         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
6494         * tracectf.c (_initialize_ctf): Add declaration.
6495         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
6496         * tracefile.c (_initialize_tracefile): Add declaration.
6497         * tracepoint.c (_initialize_tracepoint): Add declaration.
6498         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
6499         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
6500         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
6501         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
6502         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
6503         * tui/tui-win.c (_initialize_tui_win): Add declaration.
6504         * tui/tui.c (_initialize_tui): Add declaration.
6505         * typeprint.c (_initialize_typeprint): Add declaration.
6506         * ui-style.c (_initialize_ui_style): Add declaration.
6507         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
6508         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
6509         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
6510         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
6511         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
6512         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
6513         * unittests/filtered_iterator-selftests.c
6514         (_initialize_filtered_iterator_selftests): Add declaration.
6515         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
6516         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
6517         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
6518         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
6519         * unittests/main-thread-selftests.c
6520         (_initialize_main_thread_selftests): Add declaration.
6521         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
6522         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
6523         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
6524         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
6525         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
6526         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
6527         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
6528         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
6529         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
6530         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
6531         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
6532         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
6533         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
6534         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
6535         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
6536         declaration.
6537         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
6538         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
6539         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
6540         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
6541         * user-regs.c (_initialize_user_regs): Add declaration.
6542         * utils.c (_initialize_utils): Add declaration.
6543         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
6544         * valops.c (_initialize_valops): Add declaration.
6545         * valprint.c (_initialize_valprint): Add declaration.
6546         * value.c (_initialize_values): Add declaration.
6547         * varobj.c (_initialize_varobj): Add declaration.
6548         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
6549         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
6550         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
6551         * windows-nat.c (_initialize_windows_nat): Add declaration.
6552         (_initialize_check_for_gdb_ini): Add declaration.
6553         (_initialize_loadable): Add declaration.
6554         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
6555         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
6556         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
6557         * xcoffread.c (_initialize_xcoffread): Add declaration.
6558         * xml-support.c (_initialize_xml_support): Add declaration.
6559         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
6560         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
6561         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
6562         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
6563
6564 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6565
6566         * regformats/regdat.sh: Generate declaration for init function.
6567
6568 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6569
6570         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
6571         up.
6572         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
6573         close_one_inferior>: New methods.
6574         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
6575         pass down target to find_inferior_pid.
6576         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
6577         Pass down target to find_inferior_ptid.
6578         (gdbsim_target::create_inferior): Pass down target to
6579         add_thread_silent.
6580         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
6581         target down to find_inferior_ptid and switch_to_thread.
6582         (gdbsim_target::close): Update to call close_one_inferior.
6583         (struct resume_data): Remove.
6584         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
6585         directly, rather than through a void pointer.
6586         (gdbsim_target::resume): Update to call resume_one_inferior.
6587
6588 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
6589
6590         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
6591
6592 2020-01-12  Pedro Alves  <palves@redhat.com>
6593
6594         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
6595         directly for the current inferior instead of
6596         discard_all_inferiors.
6597         (discard_all_inferiors): Delete.
6598
6599 2020-01-11  Tom Tromey  <tom@tromey.com>
6600
6601         * tui/tui-wingeneral.c (box_win): Check cli_styling.
6602         * tui/tui-winsource.c (tui_source_window_base::refill): Use
6603         deprecated_safe_get_selected_frame.
6604
6605 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6606
6607         * inferior.c (print_inferior): Switch inferior before printing it.
6608
6609 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
6610             Pedro Alves  <palves@redhat.com>
6611
6612         * progspace-and-thread.c (switch_to_program_space_and_thread):
6613         Assert there's an inferior for PSPACE.  Use
6614         switch_to_inferior_no_thread to switch the inferior too.
6615         * progspace.c (program_space::~program_space): Call
6616         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
6617         (program_space::free_all_objfiles): Don't call clear_symtab_users
6618         here.
6619         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
6620
6621 2020-01-10  Pedro Alves  <palves@redhat.com>
6622
6623         * NEWS: Mention multi-target debugging, "info connections", and
6624         "add-inferior -no-connection".
6625
6626 2020-01-10  Pedro Alves  <palves@redhat.com>
6627
6628         * infrun.c: Include "target-connection.h".
6629         (check_multi_target_resumption): New.
6630         (proceed): Call it.
6631         * target-connection.c (make_target_connection_string): Make
6632         extern.
6633         * target-connection.h (make_target_connection_string): Declare.
6634
6635 2020-01-10  Pedro Alves  <palves@redhat.com>
6636
6637         * Makefile.in (COMMON_SFILES): Add target-connection.c.
6638         * inferior.c (uiout_field_connection): New function.
6639         (print_inferior): Add new "connection-id" column.
6640         (add_inferior_command): Show connection number/string of added
6641         inferior.
6642         * process-stratum-target.h
6643         (process_stratum_target::connection_string): New virtual method.
6644         (process_stratum_target::connection_number): New field.
6645         * remote.c (remote_target::connection_string): New override.
6646         * target-connection.c: New file.
6647         * target-connection.h: New file.
6648         * target.c (decref_target): Remove process_stratum targets from
6649         the connection list.
6650         (target_stack::push): Add process_stratum targets to the
6651         connection list.
6652
6653 2020-01-10  Pedro Alves  <palves@redhat.com>
6654
6655         Revert:
6656         2016-04-12  Pedro Alves  <palves@redhat.com>
6657         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
6658         Remove references to name.
6659         * serial.h (struct serial) <name>: Delete.
6660
6661 2020-01-10  Pedro Alves  <palves@redhat.com>
6662
6663         * gdbarch-selftests.c (register_to_value_test): Remove "target
6664         already pushed" check.
6665
6666 2020-01-10  Pedro Alves  <palves@redhat.com>
6667             John Baldwin  <jhb@FreeBSD.org>
6668
6669         * aarch64-linux-nat.c
6670         (aarch64_linux_nat_target::thread_architecture): Adjust.
6671         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
6672         (task_command_1): Likewise.
6673         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
6674         (aix_thread_target::wait, aix_thread_target::fetch_registers)
6675         (aix_thread_target::store_registers)
6676         (aix_thread_target::thread_alive): Adjust.
6677         * amd64-fbsd-tdep.c: Include "inferior.h".
6678         (amd64fbsd_get_thread_local_address): Pass down target.
6679         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
6680         thread's gdbarch instead of target_gdbarch.
6681         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
6682         get_last_target_status.
6683         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
6684         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
6685         inferiors.
6686         (update_inserted_breakpoint_locations): Skip if inferiors with no
6687         execution.
6688         (update_global_location_list): When handling moribund locations,
6689         find representative inferior for location's pspace, and use thread
6690         count of its process_stratum target.
6691         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
6692         * bsd-uthread.c (bsd_uthread_target::wait): Use
6693         as_process_stratum_target and adjust thread_change_ptid and
6694         add_thread calls.
6695         (bsd_uthread_target::update_thread_list): Use
6696         as_process_stratum_target and adjust find_thread_ptid,
6697         thread_change_ptid and add_thread calls.
6698         * btrace.c (maint_btrace_packet_history_cmd): Adjust
6699         find_thread_ptid call.
6700         * corelow.c (add_to_thread_list): Adjust add_thread call.
6701         (core_target_open): Adjust add_thread_silent and thread_count
6702         calls.
6703         (core_target::pid_to_str): Adjust find_inferior_ptid call.
6704         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
6705         * event-top.c (async_disconnect): Pop targets from all inferiors.
6706         * exec.c (add_target_sections): Push exec target on all inferiors
6707         sharing the program space.
6708         (remove_target_sections): Remove the exec target from all
6709         inferiors sharing the program space.
6710         (exec_on_vfork): New.
6711         * exec.h (exec_on_vfork): Declare.
6712         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
6713         Pass it down.
6714         (fbsd_nat_target::update_thread_list): Adjust.
6715         (fbsd_nat_target::resume): Adjust.
6716         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
6717         down.
6718         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
6719         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
6720         get_thread_arch_regcache call.
6721         * fork-child.c (gdb_startup_inferior): Pass target down to
6722         startup_inferior and set_executing.
6723         * gdbthread.h (struct process_stratum_target): Forward declare.
6724         (add_thread, add_thread_silent, add_thread_with_info)
6725         (in_thread_list): Add process_stratum_target parameter.
6726         (find_thread_ptid(inferior*, ptid_t)): New overload.
6727         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
6728         parameter.
6729         (all_threads()): Delete overload.
6730         (all_threads, all_non_exited_threads): Add process_stratum_target
6731         parameter.
6732         (all_threads_safe): Use brace initialization.
6733         (thread_count): Add process_stratum_target parameter.
6734         (set_resumed, set_running, set_stop_requested, set_executing)
6735         (threads_are_executing, finish_thread_state): Add
6736         process_stratum_target parameter.
6737         (switch_to_thread): Use is_current_thread.
6738         * i386-fbsd-tdep.c: Include "inferior.h".
6739         (i386fbsd_get_thread_local_address): Pass down target.
6740         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
6741         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
6742         have_inferiors check.
6743         * inf-ptrace.c (inf_ptrace_target::create_inferior)
6744         (inf_ptrace_target::attach): Adjust.
6745         * infcall.c (run_inferior_call): Adjust.
6746         * infcmd.c (run_command_1): Pass target to
6747         scoped_finish_thread_state.
6748         (proceed_thread_callback): Skip inferiors with no execution.
6749         (continue_command): Rename 'all_threads' local to avoid hiding
6750         'all_threads' function.  Adjust get_last_target_status call.
6751         (prepare_one_step): Adjust set_running call.
6752         (signal_command): Use user_visible_resume_target.  Compare thread
6753         pointers instead of inferior_ptid.
6754         (info_program_command): Adjust to pass down target.
6755         (attach_command): Mark target's 'thread_executing' flag.
6756         (stop_current_target_threads_ns): New, factored out from ...
6757         (interrupt_target_1): ... this.  Switch inferior before making
6758         target calls.
6759         * inferior-iter.h
6760         (struct all_inferiors_iterator, struct all_inferiors_range)
6761         (struct all_inferiors_safe_range)
6762         (struct all_non_exited_inferiors_range): Filter on
6763         process_stratum_target too.  Remove explicit.
6764         * inferior.c (inferior::inferior): Push dummy target on target
6765         stack.
6766         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
6767         Add process_stratum_target parameter, and pass it down.
6768         (have_live_inferiors): Adjust.
6769         (switch_to_inferior_and_push_target): New.
6770         (add_inferior_command, clone_inferior_command): Handle
6771         "-no-connection" parameter.  Use
6772         switch_to_inferior_and_push_target.
6773         (_initialize_inferior): Mention "-no-connection" option in
6774         the help of "add-inferior" and "clone-inferior" commands.
6775         * inferior.h: Include "process-stratum-target.h".
6776         (interrupt_target_1): Use bool.
6777         (struct inferior) <push_target, unpush_target, target_is_pushed,
6778         find_target_beneath, top_target, process_target, target_at,
6779         m_stack>: New.
6780         (discard_all_inferiors): Delete.
6781         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
6782         (all_inferiors, all_non_exited_inferiors): Add
6783         process_stratum_target parameter.
6784         * infrun.c: Include "gdb_select.h" and <unordered_map>.
6785         (target_last_proc_target): New global.
6786         (follow_fork_inferior): Push target on new inferior.  Pass target
6787         to add_thread_silent.  Call exec_on_vfork.  Handle target's
6788         reference count.
6789         (follow_fork): Adjust get_last_target_status call.  Also consider
6790         target.
6791         (follow_exec): Push target on new inferior.
6792         (struct execution_control_state) <target>: New field.
6793         (user_visible_resume_target): New.
6794         (do_target_resume): Call target_async.
6795         (resume_1): Set target's threads_executing flag.  Consider resume
6796         target.
6797         (commit_resume_all_targets): New.
6798         (proceed): Also consider resume target.  Skip threads of inferiors
6799         with no execution.  Commit resumtion in all targets.
6800         (start_remote): Pass current inferior to wait_for_inferior.
6801         (infrun_thread_stop_requested): Consider target as well.  Pass
6802         thread_info pointer to clear_inline_frame_state instead of ptid.
6803         (infrun_thread_thread_exit): Consider target as well.
6804         (random_pending_event_thread): New inferior parameter.  Use it.
6805         (do_target_wait): Rename to ...
6806         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
6807         down.
6808         (threads_are_resumed_pending_p, do_target_wait): New.
6809         (prepare_for_detach): Adjust calls.
6810         (wait_for_inferior): New inferior parameter.  Handle it.  Use
6811         do_target_wait_1 instead of do_target_wait.
6812         (fetch_inferior_event): Adjust.  Switch to representative
6813         inferior.  Pass target down.
6814         (set_last_target_status): Add process_stratum_target parameter.
6815         Save target in global.
6816         (get_last_target_status): Add process_stratum_target parameter and
6817         handle it.
6818         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
6819         (context_switch): Check inferior_ptid == null_ptid before calling
6820         inferior_thread().
6821         (get_inferior_stop_soon): Pass down target.
6822         (wait_one): Rename to ...
6823         (poll_one_curr_target): ... this.
6824         (struct wait_one_event): New.
6825         (wait_one): New.
6826         (stop_all_threads): Adjust.
6827         (handle_no_resumed, handle_inferior_event): Adjust to consider the
6828         event's target.
6829         (switch_back_to_stepped_thread): Also consider target.
6830         (print_stop_event): Update.
6831         (normal_stop): Update.  Also consider the resume target.
6832         * infrun.h (wait_for_inferior): Remove declaration.
6833         (user_visible_resume_target): New declaration.
6834         (get_last_target_status, set_last_target_status): New
6835         process_stratum_target parameter.
6836         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6837         process_stratum_target parameter, and use it.
6838         (clear_inline_frame_state (thread_info*)): New.
6839         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6840         process_stratum_target parameter.
6841         (clear_inline_frame_state (thread_info*)): Declare.
6842         * linux-fork.c (delete_checkpoint_command): Pass target down to
6843         find_thread_ptid.
6844         (checkpoint_command): Adjust.
6845         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
6846         instead of just tweaking inferior_ptid.
6847         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
6848         (exit_lwp): Pass target down to find_thread_ptid.
6849         (attach_proc_task_lwp_callback): Pass target down to
6850         add_thread/set_running/set_executing.
6851         (linux_nat_target::attach): Pass target down to
6852         thread_change_ptid.
6853         (get_detach_signal): Pass target down to find_thread_ptid.
6854         Consider last target status's target.
6855         (linux_resume_one_lwp_throw, resume_lwp)
6856         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
6857         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
6858         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
6859         (linux_nat_target::async_wait_fd): New.
6860         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
6861         target down.
6862         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
6863         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
6864         * linux-thread-db.c (struct thread_db_info::process_target): New
6865         field.
6866         (add_thread_db_info): Save target.
6867         (get_thread_db_info): New process_stratum_target parameter.  Also
6868         match target.
6869         (delete_thread_db_info): New process_stratum_target parameter.
6870         Also match target.
6871         (thread_from_lwp): Adjust to pass down target.
6872         (thread_db_notice_clone): Pass down target.
6873         (check_thread_db_callback): Pass down target.
6874         (try_thread_db_load_1): Always push the thread_db target.
6875         (try_thread_db_load, record_thread): Pass target down.
6876         (thread_db_target::detach): Pass target down.  Always unpush the
6877         thread_db target.
6878         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
6879         target down.  Always unpush the thread_db target.
6880         (find_new_threads_callback, thread_db_find_new_threads_2)
6881         (thread_db_target::update_thread_list): Pass target down.
6882         (thread_db_target::pid_to_str): Pass current inferior down.
6883         (thread_db_target::get_thread_local_address): Pass target down.
6884         (thread_db_target::resume, maintenance_check_libthread_db): Pass
6885         target down.
6886         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
6887         * procfs.c (procfs_target::procfs_init_inferior): Declare.
6888         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
6889         (procfs_init_inferior): Rename to ...
6890         (procfs_target::procfs_init_inferior): ... this and adjust.
6891         (procfs_target::create_inferior, procfs_notice_thread)
6892         (procfs_do_thread_registers): Adjust.
6893         * ppc-fbsd-tdep.c: Include "inferior.h".
6894         (ppcfbsd_get_thread_local_address): Pass down target.
6895         * proc-service.c (ps_xfer_memory): Switch current inferior and
6896         program space as well.
6897         (get_ps_regcache): Pass target down.
6898         * process-stratum-target.c
6899         (process_stratum_target::thread_address_space)
6900         (process_stratum_target::thread_architecture): Pass target down.
6901         * process-stratum-target.h
6902         (process_stratum_target::threads_executing): New field.
6903         (as_process_stratum_target): New.
6904         * ravenscar-thread.c
6905         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
6906         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
6907         down.
6908         * record-btrace.c (record_btrace_target::info_record): Adjust.
6909         (record_btrace_target::record_method)
6910         (record_btrace_target::record_is_replaying)
6911         (record_btrace_target::fetch_registers)
6912         (get_thread_current_frame_id, record_btrace_target::resume)
6913         (record_btrace_target::wait, record_btrace_target::stop): Pass
6914         target down.
6915         * record-full.c (record_full_wait_1): Switch to event thread.
6916         Pass target down.
6917         * regcache.c (regcache::regcache)
6918         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
6919         process_stratum_target parameter and handle it.
6920         (current_thread_target): New global.
6921         (get_thread_regcache): Add process_stratum_target parameter and
6922         handle it.  Switch inferior before calling target method.
6923         (get_thread_regcache): Pass target down.
6924         (get_thread_regcache_for_ptid): Pass target down.
6925         (registers_changed_ptid): Add process_stratum_target parameter and
6926         handle it.
6927         (registers_changed_thread, registers_changed): Pass target down.
6928         (test_get_thread_arch_aspace_regcache): New.
6929         (current_regcache_test): Define a couple local test_target_ops
6930         instances and use them for testing.
6931         (readwrite_regcache): Pass process_stratum_target parameter.
6932         (cooked_read_test, cooked_write_test): Pass mock_target down.
6933         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
6934         (get_thread_arch_aspace_regcache): Add process_stratum_target
6935         parameter.
6936         (regcache::target): New method.
6937         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
6938         (regcache::registers_changed_ptid): Add process_stratum_target
6939         parameter.
6940         (regcache::m_target): New field.
6941         (registers_changed_ptid): Add process_stratum_target parameter.
6942         * remote.c (remote_state::supports_vCont_probed): New field.
6943         (remote_target::async_wait_fd): New method.
6944         (remote_unpush_and_throw): Add remote_target parameter.
6945         (get_current_remote_target): Adjust.
6946         (remote_target::remote_add_inferior): Push target.
6947         (remote_target::remote_add_thread)
6948         (remote_target::remote_notice_new_inferior)
6949         (get_remote_thread_info): Pass target down.
6950         (remote_target::update_thread_list): Skip threads of inferiors
6951         bound to other targets.  (remote_target::close): Don't discard
6952         inferiors.  (remote_target::add_current_inferior_and_thread)
6953         (remote_target::process_initial_stop_replies)
6954         (remote_target::start_remote)
6955         (remote_target::remote_serial_quit_handler): Pass down target.
6956         (remote_target::remote_unpush_target): New remote_target
6957         parameter.  Unpush the target from all inferiors.
6958         (remote_target::remote_unpush_and_throw): New remote_target
6959         parameter.  Pass it down.
6960         (remote_target::open_1): Check whether the current inferior has
6961         execution instead of checking whether any inferior is live.  Pass
6962         target down.
6963         (remote_target::remote_detach_1): Pass down target.  Use
6964         remote_unpush_target.
6965         (extended_remote_target::attach): Pass down target.
6966         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
6967         (remote_target::append_resumption): Pass down target.
6968         (remote_target::append_pending_thread_resumptions)
6969         (remote_target::remote_resume_with_hc, remote_target::resume)
6970         (remote_target::commit_resume): Pass down target.
6971         (remote_target::remote_stop_ns): Check supports_vCont_probed.
6972         (remote_target::interrupt_query)
6973         (remote_target::remove_new_fork_children)
6974         (remote_target::check_pending_events_prevent_wildcard_vcont)
6975         (remote_target::remote_parse_stop_reply)
6976         (remote_target::process_stop_reply): Pass down target.
6977         (first_remote_resumed_thread): New remote_target parameter.  Pass
6978         it down.
6979         (remote_target::wait_as): Pass down target.
6980         (unpush_and_perror): New remote_target parameter.  Pass it down.
6981         (remote_target::readchar, remote_target::remote_serial_write)
6982         (remote_target::getpkt_or_notif_sane_1)
6983         (remote_target::kill_new_fork_children, remote_target::kill): Pass
6984         down target.
6985         (remote_target::mourn_inferior): Pass down target.  Use
6986         remote_unpush_target.
6987         (remote_target::core_of_thread)
6988         (remote_target::remote_btrace_maybe_reopen): Pass down target.
6989         (remote_target::pid_to_exec_file)
6990         (remote_target::thread_handle_to_thread_info): Pass down target.
6991         (remote_target::async_wait_fd): New.
6992         * riscv-fbsd-tdep.c: Include "inferior.h".
6993         (riscv_fbsd_get_thread_local_address): Pass down target.
6994         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
6995         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
6996         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
6997         Adjust.
6998         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
6999         * solib-svr4.c (enable_break): Pass down target.
7000         * spu-multiarch.c (parse_spufs_run): Pass down target.
7001         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
7002         * target-delegates.c: Regenerate.
7003         * target.c (g_target_stack): Delete.
7004         (current_top_target): Return the current inferior's top target.
7005         (target_has_execution_1): Refer to the passed-in inferior's top
7006         target.
7007         (target_supports_terminal_ours): Check whether the initial
7008         inferior was already created.
7009         (decref_target): New.
7010         (target_stack::push): Incref/decref the target.
7011         (push_target, push_target, unpush_target): Adjust.
7012         (target_stack::unpush): Defref target.
7013         (target_is_pushed): Return bool.  Adjust to refer to the current
7014         inferior's target stack.
7015         (dispose_inferior): Delete, and inline parts ...
7016         (target_preopen): ... here.  Only dispose of the current inferior.
7017         (target_detach): Hold strong target reference while detaching.
7018         Pass target down.
7019         (target_thread_name): Add assertion.
7020         (target_resume): Pass down target.
7021         (target_ops::beneath, find_target_at): Adjust to refer to the
7022         current inferior's target stack.
7023         (get_dummy_target): New.
7024         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
7025         has a thread running.
7026         (initialize_targets): Rename to ...
7027         (_initialize_target): ... this.
7028         * target.h: Include "gdbsupport/refcounted-object.h".
7029         (struct target_ops): Inherit refcounted_object.
7030         (target_ops::shortname, target_ops::longname): Make const.
7031         (target_ops::async_wait_fd): New method.
7032         (decref_target): Declare.
7033         (struct target_ops_ref_policy): New.
7034         (target_ops_ref): New typedef.
7035         (get_dummy_target): Declare function.
7036         (target_is_pushed): Return bool.
7037         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
7038         (all_matching_threads_iterator::all_matching_threads_iterator):
7039         Handle filter target.
7040         * thread-iter.h (struct all_matching_threads_iterator, struct
7041         all_matching_threads_range, class all_non_exited_threads_range):
7042         Filter by target too.  Remove explicit.
7043         * thread.c (threads_executing): Delete.
7044         (inferior_thread): Pass down current inferior.
7045         (clear_thread_inferior_resources): Pass down thread pointer
7046         instead of ptid_t.
7047         (add_thread_silent, add_thread_with_info, add_thread): Add
7048         process_stratum_target parameter.  Use it for thread and inferior
7049         searches.
7050         (is_current_thread): New.
7051         (thread_info::deletable): Use it.
7052         (find_thread_ptid, thread_count, in_thread_list)
7053         (thread_change_ptid, set_resumed, set_running): New
7054         process_stratum_target parameter.  Pass it down.
7055         (set_executing): New process_stratum_target parameter.  Pass it
7056         down.  Adjust reference to 'threads_executing'.
7057         (threads_are_executing): New process_stratum_target parameter.
7058         Adjust reference to 'threads_executing'.
7059         (set_stop_requested, finish_thread_state): New
7060         process_stratum_target parameter.  Pass it down.
7061         (switch_to_thread): Also match inferior.
7062         (switch_to_thread): New process_stratum_target parameter.  Pass it
7063         down.
7064         (update_threads_executing): Reimplement.
7065         * top.c (quit_force): Pop targets from all inferior.
7066         (gdb_init): Don't call initialize_targets.
7067         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
7068         Declare.
7069         (windows_add_thread, windows_delete_thread): Adjust.
7070         (get_windows_debug_event): Rename to ...
7071         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
7072         * tracefile-tfile.c (tfile_target_open): Pass down target.
7073         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
7074         Forward declare.
7075         (switch_to_thread): Add process_stratum_target parameter.
7076         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
7077         parameter.  Use it.
7078         (mi_on_resume): Pass target down.
7079         * nat/fork-inferior.c (startup_inferior): Add
7080         process_stratum_target parameter.  Pass it down.
7081         * nat/fork-inferior.h (startup_inferior): Add
7082         process_stratum_target parameter.
7083         * python/py-threadevent.c (py_get_event_thread): Pass target down.
7084
7085 2020-01-10  Pedro Alves  <palves@redhat.com>
7086
7087         * remote.c (remote_target::start_remote): Don't set inferior_ptid
7088         directly.  Instead find the first thread in the thread list and
7089         use switch_to_thread.
7090
7091 2020-01-10  Pedro Alves  <palves@redhat.com>
7092
7093         * remote.c (remote_target::remote_add_inferior): Don't bind a
7094         process to the current inferior if the current inferior is already
7095         bound to a process.
7096
7097 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
7098             Pedro Alves  <palves@redhat.com>
7099
7100         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
7101         If no process is specified, return null_ptid instead of
7102         inferior_ptid.
7103         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
7104         TARGET_WAITKIND_SIGNALLED with no pid.
7105
7106 2020-01-10  Pedro Alves  <palves@redhat.com>
7107
7108         * remote.c (first_remote_resumed_thread): New.
7109         (remote_target::wait_as): Use it as default event_ptid instead of
7110         inferior_ptid.
7111
7112 2020-01-10  Pedro Alves  <palves@redhat.com>
7113
7114         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
7115
7116 2020-01-10  Pedro Alves  <palves@redhat.com>
7117
7118         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
7119         not -1.
7120
7121 2020-01-10  Pedro Alves  <palves@redhat.com>
7122
7123         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
7124         ptid to get_last_target_status.
7125         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
7126         ptid to get_last_target_status.
7127         * infcmd.c (continue_command): Don't pass a target_waitstatus to
7128         get_last_target_status.
7129         (info_program_command): Don't pass a target_waitstatus to
7130         get_last_target_status.
7131         * infrun.c (init_wait_for_inferior): Use
7132         nullify_last_target_wait_ptid.
7133         (get_last_target_status): Handle nullptr arguments.
7134         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
7135         (print_stop_event): Don't pass a ptid to get_last_target_status.
7136         (normal_stop): Don't pass a ptid to get_last_target_status.
7137         * infrun.h (get_last_target_status, set_last_target_status): Move
7138         comments here and update.
7139         (nullify_last_target_wait_ptid): Declare.
7140         * linux-fork.c (fork_load_infrun_state): Remove local extern
7141         declaration of nullify_last_target_wait_ptid.
7142         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
7143         to get_last_target_status.
7144
7145 2020-01-10  Pedro Alves  <palves@redhat.com>
7146
7147         * gdbthread.h (scoped_restore_current_thread)
7148         <dont_restore, restore, m_dont_restore>: Declare.
7149         * thread.c (thread_alive): Add assertion.  Return bool.
7150         (switch_to_thread_if_alive): New.
7151         (prune_threads): Switch inferior/thread.
7152         (print_thread_info_1): Switch thread before calling target methods.
7153         (scoped_restore_current_thread::restore): New, factored out from
7154         ...
7155         (scoped_restore_current_thread::~scoped_restore_current_thread):
7156         ... this.
7157         (scoped_restore_current_thread::scoped_restore_current_thread):
7158         Add assertion.
7159         (thread_apply_all_command, thread_select): Use
7160         switch_to_thread_if_alive.
7161         * infrun.c (proceed, restart_threads, handle_signal_stop)
7162         (switch_back_to_stepped_thread): Switch current thread before
7163         calling target methods.
7164
7165 2020-01-10  Pedro Alves <palves@redhat.com>
7166
7167         * inferior.c (switch_to_inferior_no_thread): New function,
7168         factored out from ...
7169         (inferior_command): ... here.
7170         * inferior.h (switch_to_inferior_no_thread): Declare.
7171         * mi/mi-main.c (run_one_inferior): Use
7172         switch_to_inferior_no_thread.
7173
7174 2020-01-10  Pedro Alves  <palves@redhat.com>
7175
7176         * infcmd.c (kill_command): Remove dead code.
7177
7178 2020-01-10  Pedro Alves  <palves@redhat.com>
7179
7180         * remote.c (remote_target::mourn_inferior): No longer check
7181         whether the target is running.
7182
7183 2020-01-10  Pedro Alves  <palves@redhat.com>
7184
7185         * corelow.c (core_target::has_execution): Change parameter type to
7186         inferior pointer.
7187         * inferior.c (number_of_live_inferiors): Use
7188         inferior::has_execution instead of target_has_execution_1.
7189         * inferior.h (inferior::has_execution): New.
7190         * linux-thread-db.c (thread_db_target::update_thread_list): Use
7191         inferior::has_execution instead of target_has_execution_1.
7192         * process-stratum-target.c
7193         (process_stratum_target::has_execution): Change parameter type to
7194         inferior pointer.  Check the inferior's PID instead of
7195         inferior_ptid.
7196         * process-stratum-target.h
7197         (process_stratum_target::has_execution): Change parameter type to
7198         inferior pointer.
7199         * record-full.c (record_full_core_target::has_execution): Change
7200         parameter type to inferior pointer.
7201         * target.c (target_has_execution_1): Change parameter type to
7202         inferior pointer.
7203         (target_has_execution_current): Adjust.
7204         * target.h (target_ops::has_execution): Change parameter type to
7205         inferior pointer.
7206         (target_has_execution_1): Change parameter type to inferior
7207         pointer.  Change return type to bool.
7208         * tracefile.h (tracefile_target::has_execution): Change parameter
7209         type to inferior pointer.
7210
7211 2020-01-10  Pedro Alves  <palves@redhat.com>
7212
7213         * exceptions.c (print_flush): Remove current_top_target() check.
7214
7215 2020-01-10  Pedro Alves  <palves@redhat.com>
7216
7217         * remote.c (show_remote_exec_file): Show the current inferior's
7218         exec-file instead of the command variable's value.
7219
7220 2020-01-10  Pedro Alves  <palves@redhat.com>
7221
7222         * record-full.c (record_full_resume_ptid): New global.
7223         (record_full_target::resume): Set it.
7224         (record_full_wait_1): Use record_full_resume_ptid instead of
7225         inferior_ptid.
7226
7227 2020-01-10  Pedro Alves  <palves@redhat.com>
7228
7229         * gdbthread.h (scoped_restore_current_thread)
7230         <dont_restore, restore, m_dont_restore>: Declare.
7231         * thread.c (thread_alive): Add assertion.  Return bool.
7232         (switch_to_thread_if_alive): New.
7233         (prune_threads): Switch inferior/thread.
7234         (print_thread_info_1): Switch thread before calling target methods.
7235         (scoped_restore_current_thread::restore): New, factored out from
7236         ...
7237         (scoped_restore_current_thread::~scoped_restore_current_thread):
7238         ... this.
7239         (scoped_restore_current_thread::scoped_restore_current_thread):
7240         Add assertion.
7241         (thread_apply_all_command, thread_select): Use
7242         switch_to_thread_if_alive.
7243
7244 2020-01-10  George Barrett  <bob@bob131.so>
7245
7246         * stap-probe.c (stap_modify_semaphore): Don't check for null
7247         semaphores.
7248         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
7249         for null semaphores.
7250
7251 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7252
7253         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
7254         all source windows, and maintain horizontal scroll status while
7255         doing so.
7256
7257 2020-01-09  Tom Tromey  <tom@tromey.com>
7258
7259         PR tui/18932:
7260         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
7261         update_source_window, not print_source_lines.
7262
7263 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7264
7265         * tui/tui.c (tui_enable): Register tui hooks after calling
7266         tui_display_main.
7267
7268 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
7269
7270         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
7271
7272 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
7273
7274         * thread.c (print_thread_info_1): Fix indentation.
7275
7276 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
7277
7278         * symtab.c (general_symbol_info::compute_and_set_names): Move the
7279         unique_xmalloc_ptr outside the if to always free the demangled name.
7280
7281 2020-01-08  Tom Tromey  <tromey@adacore.com>
7282
7283         * xcoffread.c (enter_line_range, read_xcoff_symtab)
7284         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
7285         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
7286         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
7287         Remove.
7288         (section_offsets): New typedef.
7289         * symtab.c (fixup_section, get_msymbol_address): Update.
7290         * symmisc.c (dump_msymbols): Update.
7291         * symfile.h (relative_addr_info_to_section_offsets)
7292         (symfile_map_offsets_to_segments): Update.
7293         * symfile.c (build_section_addr_info_from_objfile)
7294         (init_objfile_sect_indices): Update.
7295         (struct place_section_arg): Change type of "offsets".
7296         (place_section): Update.
7297         (relative_addr_info_to_section_offsets): Change type of
7298         "section_offsets".  Remove "num_sections" parameter.
7299         (default_symfile_offsets, syms_from_objfile_1)
7300         (set_objfile_default_section_offset): Update.
7301         (reread_symbols): No need to preserve section offsets by hand.
7302         (symfile_map_offsets_to_segments): Change type of "offsets".
7303         * stap-probe.c (relocate_address): Update.
7304         * stabsread.h (process_one_symbol): Update.
7305         * solib-target.c (struct lm_info_target) <offsets>: Change type.
7306         (solib_target_relocate_section_addresses): Update.
7307         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
7308         Update.
7309         * solib-frv.c (frv_relocate_main_executable): Update.
7310         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
7311         * solib-aix.c (solib_aix_get_section_offsets): Change return
7312         type.
7313         (solib_aix_solib_create_inferior_hook): Update.
7314         * remote.c (remote_target::get_offsets): Update.
7315         * psymtab.c (find_pc_sect_psymtab): Update.
7316         * psympriv.h (struct partial_symbol) <address, text_low,
7317         text_high>: Update.
7318         * objfiles.h (obj_section_offset): Update.
7319         (struct objfile) <section_offsets>: Change type.
7320         <num_sections>: Remove.
7321         (objfile_relocate): Update.
7322         * objfiles.c (entry_point_address_query): Update
7323         (relocate_one_symbol): Change type of "section_offsets".
7324         (objfile_relocate1, objfile_relocate1): Change type of
7325         "new_offsets".
7326         (objfile_rebase1): Update.
7327         * mipsread.c (mipscoff_symfile_read): Update.
7328         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
7329         parameter.
7330         * mdebugread.c (parse_symbol): Change type of "section_offsets".
7331         (parse_external, psymtab_to_symtab_1): Update.
7332         * machoread.c (macho_symfile_offsets): Update.
7333         * ia64-tdep.c (ia64_find_unwind_table): Update.
7334         * hppa-tdep.c (read_unwind_info): Update.
7335         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
7336         * dwarf2read.c (create_addrmap_from_index)
7337         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7338         (process_psymtab_comp_unit_reader, add_partial_symbol)
7339         (add_partial_subprogram, process_full_comp_unit)
7340         (read_file_scope, read_func_scope, read_lexical_block_scope)
7341         (read_call_site_scope, dwarf2_rnglists_process)
7342         (dwarf2_ranges_process, dwarf2_ranges_read)
7343         (dwarf_decode_lines_1, var_decode_location, new_symbol)
7344         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
7345         Update.
7346         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
7347         Update.
7348         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
7349         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
7350         (process_one_symbol): Change type of "section_offsets".
7351         * ctfread.c (get_objfile_text_range): Update.
7352         * coffread.c (coff_symtab_read, enter_linenos)
7353         (process_coff_symbol): Update.
7354         * coff-pe-read.c (add_pe_forwarded_sym): Update.
7355         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
7356
7357 2020-01-08  Tom Tromey  <tromey@adacore.com>
7358
7359         * dwarf2read.c (parse_macro_definition): Use std::string.
7360         (parse_macro_definition): Likewise.
7361
7362 2020-01-08  Tom Tromey  <tromey@adacore.com>
7363
7364         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
7365         (ATTR_ALLOC_CHUNK): Remove.
7366
7367 2020-01-08  Tom Tromey  <tromey@adacore.com>
7368
7369         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
7370
7371 2020-01-08  Tom Tromey  <tromey@adacore.com>
7372
7373         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
7374         (dwarf2_compute_name, open_dwo_file): Likewise.
7375         (process_enumeration_scope): Use std::vector.
7376         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
7377         (partial_die_info::fixup, dwarf2_start_subfile)
7378         (guess_full_die_structure_name, dwarf2_name): Likewise.
7379         (determine_prefix): Update.
7380         (guess_full_die_structure_name): Make return type const.
7381         (partial_die_full_name): Return unique_xmalloc_ptr.
7382         (DW_FIELD_ALLOC_CHUNK): Remove.
7383
7384 2020-01-07  Tom Tromey  <tromey@adacore.com>
7385
7386         PR build/24937:
7387         * stap-probe.c (class stap_static_probe_ops): Add constructor.
7388
7389 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
7390
7391         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
7392
7393 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7394
7395         * stack.c (print_frame_info): Move disassemble_next_line code
7396         inside source_print block.
7397
7398 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7399
7400         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
7401         gdb/signals.h, as we are now using native signal symbols.
7402
7403 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
7404
7405         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
7406         overflow by an early check of content vs threshold.
7407         * tui/tui-source.c (tui_source_window::line_is_displayed):
7408         Likewise.
7409
7410 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7411
7412         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
7413
7414 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
7415
7416         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
7417         export table if no section contains it's RVA.
7418
7419 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7420
7421         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
7422
7423 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
7424
7425         * source.c (print_source_lines_base): Set last_line_listed.
7426
7427 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
7428
7429         * tui/tui-disasm.c: Remove trailing spaces.
7430
7431 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7432             Pedro Alves  <palves@redhat.com>
7433
7434         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
7435         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
7436         (windows_gdb_signal_to_target): New function, uses the above
7437         enumeration to convert GDB internal signal codes to equivalent
7438         Windows codes.
7439         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
7440         * windows-nat.c: Include "gdb_wait.h".
7441         (get_windows_debug_event): Extract the fatal exception from the
7442         exit status and convert to the equivalent Posix signal number.
7443         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
7444         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
7445         * gdbsupport/gdb_wait.c: New file, implements
7446         windows_status_to_termsig.
7447         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
7448         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
7449
7450 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7451
7452         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
7453         show_layout.
7454
7455 2020-01-05  Luis Machado  <luis.machado@linaro.org>
7456
7457         * aarch64-linux-nat.c
7458         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
7459         and bfd_mach_aarch64.
7460
7461 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7462
7463         * ui-file.c (stdio_file::can_emit_style_escape)
7464         (tee_file::can_emit_style_escape): Ensure style is used also on
7465         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
7466         to gdb_stdout.
7467         * main.c (set_gdb_data_directory): Use file style to output the
7468         warning that the given pathname is not a directory.
7469         * top.c (show_history_filename, gdb_safe_append_history)
7470         (show_gdb_datadir): Use file style.
7471
7472 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
7473
7474         * solib-target.c (struct lm_info_target):
7475         Change offsets to be a unique_xmalloc_ptr.
7476         (solib_target_relocate_section_addresses): Update.
7477
7478 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
7479
7480         * windows-nat.c (windows_clear_solib): Free so_list linked list.
7481
7482 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
7483
7484         * MAINTAINERS (Write After Approval): Add myself.
7485
7486 2020-01-02  Luis Machado  <luis.machado@linaro.org>
7487
7488         * proc-service.c (get_ps_regcache): Remove reference to obsolete
7489         Cell BE architecture.
7490         * target.h (struct target_ops) <thread_architecture>: Likewise.
7491
7492 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
7493
7494         * Makefile.in: Use INSTALL_PROGRAM_ENV.
7495
7496 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
7497
7498         * MAINTAINERS (Write After Approval): Add myself.
7499
7500 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7501
7502         * gdbarch.sh: Update copyright year range of generated files.
7503
7504 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7505
7506         Update copyright year range in all GDB files.
7507
7508 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7509
7510         * copyright.py: Convert to Python 3.
7511
7512 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7513
7514         * copyright.py: Adapt after move of gnulib directory from gdb
7515         directory to toplevel directory.
7516
7517 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7518
7519         * copyright.py (main): Exit if run from the wrong directory.
7520
7521 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7522
7523         * top.c (print_gdb_version): Change copyright year to 2020.
7524
7525 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7526
7527         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
7528
7529 For older changes see ChangeLog-2019.
7530 \f
7531 Local Variables:
7532 mode: change-log
7533 left-margin: 8
7534 fill-column: 74
7535 version-control: never
7536 coding: utf-8
7537 End: