gdb/ChangeLog

   1 2019-06-13  Pedro Alves  <palves@redhat.com>
   2
   3         * stack.c (parse_backtrace_qualifiers): New.
   4         (backtrace_command): Use it.
   5         (backtrace_command_completer): Complete on qualifiers.
   6
   7 2019-06-13  Pedro Alves  <palves@redhat.com>
   8
   9         * frame.c: Include "cli/cli-option.h.
  10         (user_set_backtrace_options): New.
  11         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
  12         Delete.
  13         (get_prev_frame): Adjust.
  14         (boolean_option_def, uinteger_option_def)
  15         (set_backtrace_option_defs): New.
  16         (_initialize_frame): Adjust and use
  17         gdb::option::add_setshow_cmds_for_options to install "set
  18         backtrace past-main" and "set backtrace past-entry".
  19         * frame.h: Include "cli/cli-option.h".
  20         (struct frame_print_options): Forward declare.
  21         (print_frame_arguments_all, print_frame_arguments_scalars)
  22         (print_frame_arguments_none): Declare.
  23         (print_entry_values): Delete declaration.
  24         (struct frame_print_options, user_frame_print_options): New.
  25         (struct set_backtrace_options): New.
  26         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
  27         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
  28         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
  29         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
  30         (list_args_or_locals): Add frame_print_options parameter.
  31         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
  32         * python/py-framefilter.c (enumerate_args): Pass down
  33         USER_FRAME_PRINT_OPTIONS.
  34         * stack.c: Include "cli/cli-option.h".
  35         (print_frame_arguments_all, print_frame_arguments_scalars)
  36         (print_frame_arguments_none): Declare.
  37         (print_raw_frame_arguments, print_entry_values): Delete.
  38         (user_frame_print_options): New.
  39         (boolean_option_def, enum_option_def, frame_print_option_defs):
  40         New.
  41         (struct backtrace_cmd_options): New.
  42         (bt_flag_option_def): New.
  43         (backtrace_command_option_defs): New.
  44         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
  45         (print_frame_arg, read_frame_arg, print_frame_args)
  46         (print_frame_info, print_frame): Add frame_print_options parameter
  47         and use it.
  48         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
  49         (backtrace_command_1): Add frame_print_options and
  50         backtrace_cmd_options parameters and use them.
  51         (make_backtrace_options_def_group): New.
  52         (backtrace_command): Process command options with
  53         gdb::option::process_options.
  54         (backtrace_command_completer): New.
  55         (_initialize_stack): Extend "backtrace"'s help to mention
  56         supported options.  Install completer for "backtrace".
  57         Install some settings commands with add_setshow_cmds_for_options.
  58
  59 2019-06-13  Pedro Alves  <palves@redhat.com>
  60
  61         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
  62         and that "set/show print raw frame-arguments" are now deprecated.
  63
  64         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
  65         command.
  66         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
  67         * stack.c (_initialize_stack): Install "set/show print
  68         raw-frame-arguments", and deprecate "set/show print raw
  69         frame-arguments".
  70         * valprint.c (_initialize_valprint): Deprecate "set/show print
  71         raw".
  72
  73 2019-06-13  Pedro Alves  <palves@redhat.com>
  74
  75         * compile/compile.c (struct compile_options): New.
  76         (compile_flag_option_def, compile_command_option_defs)
  77         (make_compile_options_def_group): New.
  78         (compile_file_command): Handle options with
  79         gdb::option::process_options.
  80         (compile_file_command_completer): New function.
  81         (compile_code_command): Handle options with
  82         gdb::option::process_options.
  83         (compile_code_command_completer): New function.
  84         (_initialize_compiler): Install completers for "compile code" and
  85         "compile file".  Mention available options in "compile code" and
  86         "compile code"'s help.
  87         * completer.c (advance_to_completion_word): New, factored out from
  88         ...
  89         (advance_to_expression_complete_word_point): ... this.
  90         (advance_to_filename_complete_word_point): New.
  91         * completer.h (advance_to_filename_complete_word_point): New
  92         declaration.
  93
  94 2019-06-13  Pedro Alves  <palves@redhat.com>
  95
  96         * compile/compile.c: Include "cli/cli-option.h".
  97         (compile_print_value): Scope data pointer is now a
  98         value_print_options pointer; adjust.
  99         (compile_print_command): Process options.  Scope data pointer is
 100         now a value_print_options pointer; adjust.
 101         (_initialize_compile): Update "compile print"'s help to include
 102         supported options.  Install a completer for "compile print".
 103         * cp-valprint.c (show_vtblprint, show_objectprint)
 104         (show_static_field_print): Delete.
 105         (_initialize_cp_valprint): Don't install "set print
 106         static-members", "set print vtbl", "set print object" here.
 107         * printcmd.c: Include "cli/cli-option.h" and
 108         "common/gdb_optional.h".
 109         (print_command_parse_format): Rework to fill in a
 110         value_print_options instead of a format_data.
 111         (print_value): Change parameter type from format_data pointer to
 112         value_print_options reference.  Adjust.
 113         (print_command_1): Process options.  Adjust to pass down a
 114         value_print_options.
 115         (print_command_completer): New.
 116         (_initialize_printcmd): Install print_command_completer as
 117         handle_brkchars completer for the "print" command.  Update
 118         "print"'s help to include supported options.
 119         * valprint.c: Include "cli/cli-option.h".
 120         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 121         here from cp-valprint.c.
 122         (boolean_option_def, uinteger_option_def)
 123         (value_print_option_defs, make_value_print_options_def_group):
 124         New.  Use gdb::option::add_setshow_cmds_for_options to install
 125         "set print elements", "set print null-stop", "set print repeats",
 126         "set print pretty", "set print union", "set print array", "set
 127         print address", "set print symbol", "set print array-indexes".
 128         * valprint.h: Include <string> and "cli/cli-option.h".
 129         (make_value_print_options_def_group): Declare.
 130         (print_value): Change parameter type from format_data pointer to
 131         value_print_options reference.
 132         (print_command_completer): Declare.
 133
 134 2019-06-13  Pedro Alves  <palves@redhat.com>
 135
 136         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 137         (COMMON_SFILES): Add maint-test-settings.c.
 138         * cli/cli-decode.c (boolean_enums): New global, factored out from
 139         ...
 140         (add_setshow_boolean_cmd): ... here.
 141         * cli/cli-decode.h (boolean_enums): Declare.
 142         * cli/cli-option.c: New file.
 143         * cli/cli-option.h: New file.
 144         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 145         factored out from ...
 146         (parse_cli_boolean_value(const char *)): ... this.
 147         (is_unlimited_literal): Change parameter type to pointer to
 148         pointer.  Adjust and advance ARG pointer.
 149         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 150         (parse_cli_var_enum): New, factored out from ...
 151         (do_set_command): ... this.  Adjust.
 152         * cli/cli-setshow.h (parse_cli_boolean_value)
 153         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 154         (parse_cli_var_enum): Declare.
 155         * cli/cli-utils.c: Include "cli/cli-option.h".
 156         (get_ulongest): New.
 157         * cli/cli-utils.h (get_ulongest): Declare.
 158         (check_for_argument): New overloads.
 159         * maint-test-options.c: New file.
 160
 161 2019-06-13  Pedro Alves  <palves@redhat.com>
 162
 163         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 164         parse a range if "-" is at the end of the string.
 165
 166 2019-06-13  Pedro Alves  <palves@redhat.com>
 167
 168         * cli/cli-setshow.c (parse_auto_binary_operation)
 169         (parse_cli_boolean_value): Don't allow "o".
 170
 171 2019-06-13  Pedro Alves  <palves@redhat.com>
 172
 173         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 174         * NEWS: Mention maint test-settings KIND.
 175         * maint-test-settings.c: New file.
 176
 177 2019-06-13  Pedro Alves  <palves@redhat.com>
 178
 179         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 180         completer.
 181         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 182         "set" completers.
 183
 184 2019-06-13  Pedro Alves  <palves@redhat.com>
 185
 186         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 187         after item.
 188
 189 2019-06-13  Pedro Alves  <palves@redhat.com>
 190
 191         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 192
 193 2019-06-13  Pedro Alves <palves@redhat.com>
 194
 195         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 196         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 197         call.
 198         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 199         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 200         calls.
 201         (check_for_argument): Skip spaces after argument.
 202
 203 2019-06-13  Pedro Alves  <palves@redhat.com>
 204
 205         * thread.c (thread_apply_command): Adjust TID parsing.
 206         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 207         detected before end of string.
 208         (tid_is_in_list): Error out if LIST is invalid.
 209
 210 2019-06-13  Pedro Alves  <palves@redhat.com>
 211
 212         * completer.c (complete_line_internal_1): Rewind completion word
 213         point.
 214         (completion_tracker::advance_custom_word_point_by): Change
 215         parameter type to int.
 216         * completer.h (completion_tracker::advance_custom_word_point_by):
 217         Likewise.
 218
 219 2019-06-13  Pedro Alves  <palves@redhat.com>
 220
 221         * completer.c (advance_to_completion_word): Handle delimiters.
 222
 223 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 224
 225         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 226
 227 2019-06-11  Tom Tromey  <tom@tromey.com>
 228
 229         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 230         (xmalloc_failed): Move to alloc.c.
 231         * alloc.c: New file.
 232         * Makefile.in (COMMON_SFILES): Add alloc.c.
 233
 234 2019-06-11  Tom Tromey  <tom@tromey.com>
 235
 236         * nat/linux-waitpid.c: Don't include server.h.
 237         (linux_debug): Remove.
 238         (my_waitpid): Update.
 239
 240 2019-06-11  Tom Tromey  <tromey@adacore.com>
 241
 242         * infcall.c (_initialize_infcall): Remove trailing newline from
 243         help.
 244         * user-regs.c (_initialize_user_regs): Remove trailing newline
 245         from help.
 246         * typeprint.c (_initialize_typeprint): Remove trailing newline
 247         from help.
 248         * reverse.c (_initialize_reverse): Remove trailing newlines from
 249         help.
 250         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 251         from help.
 252         * language.c (add_set_language_command): Remove trailing newline
 253         from help.
 254         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 255         help.
 256         * disasm.c (_initialize_disasm): Remove trailing newline from
 257         help.
 258         * top.c (init_main): Remove trailing newline from help.
 259         * interps.c (_initialize_interpreter): Remove trailing newline
 260         from help.
 261         * btrace.c (_initialize_btrace): Remove trailing newlines from
 262         help.
 263         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 264         from help.
 265         * python/python.c (_initialize_python): Remove trailing newline
 266         from help.
 267         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 268         help.
 269         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 270         from help.  Reformat some text.
 271         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 272         from help.
 273         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 274         newline from help.
 275
 276 2019-06-11  Tom Tromey  <tromey@adacore.com>
 277
 278         * darwin-nat.c (darwin_decode_exception_message)
 279         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 280
 281 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 282
 283         * valops.c (value_slice): Check for not allocated or not
 284         associated values.
 285
 286 2019-06-10  Tom de Vries  <tdevries@suse.de>
 287
 288         PR gdb/24618
 289         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 290         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 291         invalid.
 292
 293 2019-06-10  Tom de Vries  <tdevries@suse.de>
 294
 295         PR gdb/24611
 296         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 297         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 298
 299 2019-06-10  Tom de Vries  <tdevries@suse.de>
 300
 301         PR symtab/24545
 302         * symtab.c (struct demangled_name_entry): Add language field.
 303         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 304         static minimal symbol".  Set and use language field.
 305
 306 2019-06-10  Tom Tromey  <tromey@adacore.com>
 307
 308         * ada-lang.c (_initialize_ada_language): Update help text.
 309
 310 2019-06-10  Tom Tromey  <tromey@adacore.com>
 311
 312         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 313         with a newline.
 314         * guile/guile.c (handle_boot_error): Don't end warning with a
 315         newline.
 316         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 317         warning with a newline.
 318         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 319         newline.
 320         (s12z_frame_cache): Likewise.
 321         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 322         a newline.
 323         * solib-svr4.c (disable_probes_interface): Don't end warning with
 324         a newline.
 325         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 326         newline.
 327         * python/python.c (do_finish_initialization): Don't end warning
 328         with a newline.
 329
 330 2019-06-10  Tom Tromey  <tom@tromey.com>
 331
 332         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 333         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 334         gdbpy_enter.
 335
 336 2019-06-10  Tom Tromey  <tromey@adacore.com>
 337
 338         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 339         data.
 340         (elf_new_init): Don't call stabsread_new_init.
 341         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 342         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 343         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 344
 345 2019-06-10  Tom de Vries  <tdevries@suse.de>
 346
 347         PR symtab/16264
 348         PR symtab/24517
 349         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 350
 351 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 352
 353         * source.c (find_and_open_source): Also rewrite relative file
 354         names.
 355
 356 2019-04-26  Amos Bird  <amosbird@gmail.com>
 357
 358         * annotate.c (annotate_thread_exited): Add "thread-exited"
 359         annotation.
 360
 361 2019-06-06  Tom Tromey  <tromey@adacore.com>
 362
 363         * maint.h (class scoped_command_stats): Use
 364         DISABLE_COPY_AND_ASSIGN.
 365         <print_time>: New method.
 366         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 367         print_time.
 368         (scoped_command_stats::print_time): New method.
 369
 370 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 371
 372         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 373         instructions of lengths 6 or 8 bytes.
 374
 375 2019-06-04  Pedro Alves  <palves@redhat.com>
 376
 377         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 378
 379         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 380         * breakpoint.c (condition_completer): Likewise.
 381         * cli/cli-dump.c (scan_expression): Likewise.
 382         * common/filestuff.c (mkdir_recursive): Likewise.
 383         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 384         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 385         (gdb_abspath): Likewise.
 386         * compile/compile-cplus-types.c
 387         (compile_cplus_instance::decl_name): Likewise.
 388         * completer.c (complete_explicit_location):
 389         (signal_completer, reg_or_group_completer_1): Likewise.
 390         * cp-support.c (cp_remove_params_if_any): Likewise.
 391         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 392         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 393         * infcmd.c (strip_bg_char): Likewise.
 394         * linespec.c (copy_token_string): Likewise.
 395         * mi/mi-main.c (output_cores): Likewise.
 396         * psymtab.c (psymtab_search_name):
 397         * symfile.c (test_set_ext_lang_command): Likewise.
 398         * target.c (target_fileio_read_stralloc): Likewise.
 399         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 400         * value.c (complete_internalvar): Likewise.
 401
 402 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 403
 404         Add objfile property to gdb.Type.
 405         * NEWS: Mention Python API addition.
 406         * python/py-type.c (typy_get_objfile): New method.
 407
 408 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 409
 410         * NEWS: Mention the new set|show style [title|highlight].
 411         Mention changes to "show style", "help" and "apropos".
 412
 413 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 414
 415         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 416         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 417         instead of print_help_for_command.
 418         (print_doc_of_command): New function.
 419         (help_list): Add 'apropos -v word' suggestion.
 420         (print_help_for_command): Style the command name using title style.
 421         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 422         (_initialize_cli_cmds): Describe -v in apropos_command help.
 423
 424 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 425
 426         * cli/cli-style.h (cli_style_option): Add name in constructor,
 427         add m_name class member, add constructor with intensity,
 428         add name class function.
 429         (cli_style_option::add_setshow_commands): Remove name argument.
 430         (highlight_style, title_style): New styles.
 431         * cli/cli-style.c (do_show): New function that shows a style
 432         characteristic styling the style name with itself.
 433         (set_style_name): New function.
 434         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 435         Update all callers according to the changes in cli/cli-style.h.
 436         * utils.h (fputs_highlighted): New function.
 437         * utils.c (fputs_highlighted): Likewise.
 438
 439 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 440
 441         * NEWS: Mention new pipe command and new convenience variables.
 442
 443 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 444
 445         * cli/cli-cmds.c (pipe_command): New function.
 446         (_initialize_cli_cmds): Call add_com for pipe_command.
 447         Define | as an alias for pipe.
 448         (exit_status_set_internal_vars): New function.
 449         (shell_escape): Call exit_status_set_internal_vars.
 450         cli/cli-decode.c (find_command_name_length): Recognize | as
 451         a single character command.
 452
 453 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 454
 455         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 456         top.c (execute_command_to_ui_file): New function, mostly a copy
 457         of execute_command_to_string.
 458         (execute_command_to_string): Implement by calling
 459         execute_command_to_ui_file.
 460
 461 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 462
 463         * top.h (saved_command_line): Remove declaration.
 464         * top.c (previous_saved_command_line, previous_repeat_arguments):
 465         New variables.
 466         (saved_command_line): Make static, define together with other
 467         'repeat variables'.
 468         (dont_repeat): Clear repeat_arguments.
 469         (repeat_previous, get_saved_command_line, save_command_line):
 470         New functions.
 471         (gdb_init): Initialize saved_command_line
 472         and previous_saved_command_line.
 473         * main.c (captured_main_1): Remove saved_command_line initialization.
 474         * event-top.c (handle_line_of_input): Update to use
 475         the new 'repeat' related functions instead of direct access to
 476         saved_command_line.
 477         * command.h (repeat_previous, get_saved_command_line,
 478         save_command_line): New declarations.
 479         (dont_repeat): Add comment.
 480
 481 2019-05-30  Tom Tromey  <tromey@adacore.com>
 482
 483         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 484         Fix comment.
 485         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 486
 487 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 488
 489         PR cli/24587
 490         * completer.c (complete): Initialize variable word.
 491
 492 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 493
 494         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 495         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 496         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 497         'body' is NULL to the outter 'if', protecting the '!is_define'
 498         situation as well.
 499
 500 2019-05-29  Tom Tromey  <tromey@adacore.com>
 501
 502         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 503         (dwarf_unknown): New function.
 504         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 505         (dwarf_type_encoding_name): Use dwarf_unknown.
 506
 507 2019-05-29  Tom Tromey  <tromey@adacore.com>
 508
 509         PR c++/20020:
 510         * cp-valprint.c (cp_print_value_fields): Call
 511         cp_print_static_field inside "try".
 512
 513 2019-05-29  Tom Tromey  <tromey@adacore.com>
 514
 515         * inflow.c (struct terminal_info): Add default operator=.
 516         * configure: Rebuild.
 517         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 518         -Wdeprecated-copy-dtor, -Wredundant-move.
 519
 520 2019-05-29  Tom Tromey  <tromey@adacore.com>
 521
 522         * NEWS: Add entry.
 523         * infcmd.c (print_return_value_1): Handle finish_print
 524         option.
 525         (show_print_finish): New function.
 526         (_initialize_infcmd): Add "set/show print finish" commands.
 527         * valprint.c (user_print_options): Initialize new member.
 528         * valprint.h (struct value_print_options) <finish_print>: New
 529         member.
 530
 531 2019-05-28  Tom Tromey  <tromey@adacore.com>
 532
 533         * ada-lang.c (ada_remove_Xbn_suffix)
 534         (find_old_style_renaming_symbol)
 535         (parse_old_style_renaming): Remove.
 536         (ada_find_renaming_symbol): Don't call
 537         find_old_style_renaming_symbol.
 538         (ada_is_renaming_symbol): Rename from
 539         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 540         bool.  Now static.
 541         (ada_read_var_value): Update and simplify.
 542         * ada-exp.y (write_var_or_type): Remove old code.
 543
 544 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 545
 546         * event-top.c: Remove include comment.
 547         * inflow.c (class scoped_ignore_sigttou): Move from here...
 548         * inflow.h (class scoped_ignore_sigttou): ...to here.
 549         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 550         * top.c:  Remove include comment.
 551
 552 2019-05-27  Tom Tromey  <tom@tromey.com>
 553
 554         * NEWS: Fix typo.
 555
 556 2019-05-22  Tom Tromey  <tromey@adacore.com>
 557
 558         * target.c (target_follow_exec): Constify parameter.
 559         * target-delegates.c: Rebuild.
 560         * remote.c (remote_target::follow_exec): Constify parameter.
 561         * infrun.c (follow_exec): Constify parameter.
 562         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 563         (target_follow_exec): Likewise.
 564
 565 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 566
 567         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 568         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 569
 570 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 571
 572         * NEWS: Add debugredirect and testsuite sections.
 573
 574 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 575
 576         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 577         target descriptions using exclusively floating point register name
 578         aliases.
 579
 580 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 581
 582         PR gdb/18644:
 583         * f-lang.c (build_fortran_types): Handle the case where
 584         gdbarch_floatformat_for_type returns a nullptr.
 585
 586 2019-05-21  Tom de Vries  <tdevries@suse.de>
 587
 588         PR cli/24587
 589         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 590
 591 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 592
 593         PR gdb/18644:
 594         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 595         16-byte floats.
 596         * i386-tdep.c (i386_floatformat_for_type): Use
 597         floatformats_ia64_quad for the 16-byte floating point component
 598         within a fortran 32-byte complex number.
 599
 600 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 601
 602         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 603         delete default constructor.
 604         (find_partial_die): Update to return const struct.
 605         (partial_die_parent_scope): Move variable declaration into scope
 606         of its use and change its type to auto.
 607         (guess_partial_die_structure_name): Likewise.
 608         (partial_die_info::fixup): Likewise.
 609
 610 2019-05-17  Tom Tromey  <tromey@adacore.com>
 611
 612         * source.c (find_and_open_source): Remove cast.
 613
 614 2019-05-17  Tom Tromey  <tromey@adacore.com>
 615
 616         * annotate.c (annotate_source): Make "filename" const.
 617         * annotate.h (annotate_source): Use const.
 618
 619 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 620
 621         * disasm.c (set_disassembler_options): Send errors to stderr.
 622
 623 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 624
 625         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 626         (cli_interp_base::set_logging): Check debug_redirect.
 627         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 628         * cli/cli-logging.c (debug_redirect): Add static variable.
 629         (pop_output_files): Add default param.
 630         (handle_redirections): Print debug setting.
 631         (show_logging_command): Likewise.
 632         (_initialize_cli_logging): Add debugredirect command.
 633         * interps.c (current_interp_set_logging): Add debug_redirect
 634         parameter.
 635         * interps.h (set_logging): Add debug_redirect parameter.
 636         (current_interp_set_logging): Likewise.
 637         * mi/mi-common.h: Likewise.
 638         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 639
 640 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 641             Tom Tromey  <tromey@adacore.com>
 642
 643         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 644         directly.
 645         * cli/cli-interp.h (make_logging_output): Remove declaration.
 646         * cli/cli-logging.c (make_logging_output): Remove function.
 647         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 648         directly.
 649         * ui-file.c (tee_file::tee_file): Remove bools.
 650         (tee_file::~tee_file): Remove deletes.
 651         * ui-file.h (tee_file): Remove bools.
 652
 653 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 654
 655         * mi/mi-cmds.h (mi_cmd_complete): New function.
 656         * mi/mi-main.c (mi_cmd_complete): Likewise.
 657         * mi/mi-cmds.c: Define new MI command -complete.
 658         * NEWS: Mention new -complete command.
 659
 660 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 661
 662         * completer.h (complete): New function.
 663         * completer.c (complete): Likewise.
 664         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 665         function defined in completer.h.
 666
 667 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 668
 669        * MAINTAINERS (Write After Approval): Add myself.
 670
 671 2019-05-17  Tom de Vries  <tdevries@suse.de>
 672
 673         PR gdb/24094
 674         * dwarf2read.c (struct cu_partial_die_info): New struct.
 675         (find_partial_die): Return cu_partial_die_info.
 676         (partial_die_parent_scope, guess_partial_die_structure_name)
 677         (partial_die_info::fixup): Handle new return type of find_partial_die.
 678
 679 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 680
 681         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 682         "std::string", simplifying the algorithm.
 683
 684 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 685
 686         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 687         (stap_static_probe_ops::get_probes): Likewise.
 688
 689 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 690
 691         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 692         '-')" and "else if".
 693         (stap_parse_single_operand): Join checks for
 694         "gdbarch_stap_parse_special_token_p" and
 695         "gdbarch_stap_parse_special_token" in the same "if" statement.
 696         Invert check when verifying for operation on register
 697         displacement.
 698
 699 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 700
 701         * stap-probe.c (stap_get_opcode): Update comment.
 702         (stap_get_expected_argument_type): Likewise.
 703         (handle_stap_probe): Likewise.
 704
 705 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 706
 707         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 708         return type to 'bool'.  Adjust comment.  Use 'bool' when
 709         appropriate.
 710         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 711         * stap-probe.c (stap_parse_argument_1): Likewise.
 712         (stap_is_operator): Likewise.
 713         (stap_is_generic_prefix): Likewise.
 714         (stap_is_register_prefix): Likewise.
 715         (stap_is_register_indirection_prefix): Likewise.
 716         (stap_is_integer_prefix): Likewise.
 717         (stap_generic_check_suffix): Likewise.
 718         (stap_check_integer_suffix): Likewise.
 719         (stap_check_register_suffix): Likewise.
 720         (stap_check_register_indirection_suffix): Likewise.
 721         (stap_parse_register_operand): Likewise.
 722         (stap_parse_single_operand): Likewise.
 723         (stap_parse_argument_1): Likewise.
 724         (stap_probe::get_argument_count): Likewise.
 725         (stap_is_operator): Likewise.
 726
 727 2019-05-16  Tom Tromey  <tromey@adacore.com>
 728
 729         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 730         keyword to foreach.
 731
 732 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 733
 734         * linux-thread-db.c (try_thread_db_load_1): Change return type
 735         to bool.
 736         (try_thread_db_load): Likewise.
 737         (try_thread_db_load_from_pdir_1): Likewise.
 738         (try_thread_db_load_from_pdir): Likewise.
 739         (try_thread_db_load_from_sdir): Likewise.
 740         (try_thread_db_load_from_dir): Likewise.
 741         (thread_db_load_search): Likewise.
 742         (has_libpthread): Likewise.
 743         (thread_db_load): Likewise.
 744
 745 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 746
 747         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 748         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 749         NULL, and complain/return if that's the case.
 750
 751 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 752
 753         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 754         (advance, posn, abstract_read_memory): New functions.
 755         [struct mem_read_abstraction]: New struct.
 756         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 757
 758 2019-05-14  Tom Tromey  <tromey@adacore.com>
 759
 760         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 761         value is not lval_memory.
 762
 763 2019-05-14  Tom Tromey  <tromey@adacore.com>
 764
 765         * solib.c (info_sharedlibrary_command): Style the file name.
 766
 767 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 768
 769         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 770         (aarch64_vnv_type): Likewise.
 771         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 772         * common/tdesc.c: Likewise.
 773         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 774         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 775         * features/aarch64-fpu.xml: Add ieee half view.
 776         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 777         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 778         * gdbtypes.h (struct builtin_type): Likewise.
 779         (struct objfile_type): Likewise.
 780
 781 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 782
 783         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 784         typo.
 785         * location.h (string_to_event_location): Likewise.
 786
 787 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 788
 789         GDB 8.3 released.
 790
 791 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 792
 793         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 794         New variable declaration.
 795         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 796         New variable.
 797         (print_one_breakpoint): Use ui_out::test_flags and new global
 798         variable to compute use_fixed_output.
 799         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 800         Remove.
 801         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 802         (mi_multi_location_breakpoint_output_fixed): Remove.
 803         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 804         new variable.
 805         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 806         fix_multi_location_breakpoint_output flag if version >= 3.
 807         * ui-out.h (enum ui_out_flag)
 808         <fix_multi_location_breakpoint_output>: New enumerator.
 809
 810 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 811
 812         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 813
 814 2019-05-10  Tom Tromey  <tromey@adacore.com>
 815
 816         * ada-lang.c (catch_ada_completer): New function.
 817         (_initialize_ada_language): Use it.
 818
 819 2019-05-10  Tom Tromey  <tromey@adacore.com>
 820
 821         * thread.c (print_thread_info): Make "requested_threads" const.
 822         * gdbthread.h (print_thread_info): Make "requested_threads"
 823         const.
 824         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 825         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 826
 827 2019-05-08  Tom Tromey  <tom@tromey.com>
 828
 829         * gdbtypes.c (objfile_type_data): Change type.
 830         (objfile_type, _initialize_gdbtypes): Update.
 831
 832 2019-05-08  Tom Tromey  <tom@tromey.com>
 833
 834         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 835         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 836         (_initialize_dwarf2_frame): Update.
 837
 838 2019-05-08  Tom Tromey  <tom@tromey.com>
 839
 840         * objc-lang.c (objc_objfile_data): Change type.
 841         (find_methods): Update.
 842         (_initialize_objc_lang): Remove.
 843
 844 2019-05-08  Tom Tromey  <tom@tromey.com>
 845
 846         * stabsread.c (rs6000_builtin_type_data): Change type.
 847         (rs6000_builtin_type, _initialize_stabsread): Update.
 848
 849 2019-05-08  Tom Tromey  <tom@tromey.com>
 850
 851         * mips-tdep.c (mips_pdr_data): Remove.
 852         (_initialize_mips_tdep): Update.
 853
 854 2019-05-08  Tom Tromey  <tom@tromey.com>
 855
 856         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 857         (hppa_init_objfile_priv_data, read_unwind_info)
 858         (find_unwind_entry, _initialize_hppa_tdep): Update.
 859
 860 2019-05-08  Tom Tromey  <tom@tromey.com>
 861
 862         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 863         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 864         on obstack.
 865         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 866
 867 2019-05-08  Tom Tromey  <tom@tromey.com>
 868
 869         * mdebugread.c (basic_type_data): Change type.
 870         (basic_type, _initialize_mdebugread): Update.
 871
 872 2019-05-08  Tom Tromey  <tom@tromey.com>
 873
 874         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 875
 876 2019-05-08  Tom Tromey  <tom@tromey.com>
 877
 878         * nto-tdep.c (nto_inferior_data_reg): Change type.
 879         (nto_inferior_data): Update.
 880         (nto_inferior_data_cleanup, nto_new_inferior_data)
 881         (_initialize_nto_tdep): Remove.
 882         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 883
 884 2019-05-08  Tom Tromey  <tom@tromey.com>
 885
 886         * ada-lang.c (struct ada_inferior_data): Add initializers.
 887         (ada_inferior_data): Change type.
 888         (ada_inferior_data_cleanup): Remove.
 889         (get_ada_inferior_data, ada_inferior_exit)
 890         (struct ada_pspace_data): Add initializers, destructor.
 891         (ada_pspace_data_handle): Change type.
 892         (get_ada_pspace_data): Update.
 893         (ada_pspace_data_cleanup): Remove.
 894
 895 2019-05-08  Tom Tromey  <tom@tromey.com>
 896
 897         * coffread.c (struct coff_symfile_info): Add initializers.
 898         (coff_objfile_data_key): Move lower.  Change type.
 899         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 900         Update.
 901         (coff_free_info): Remove.
 902
 903 2019-05-08  Tom Tromey  <tom@tromey.com>
 904
 905         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 906         (fbsd_pspace_data_handle): Move lower.  Change type.
 907         (get_fbsd_pspace_data): Update.
 908         (fbsd_pspace_data_cleanup): Remove.
 909         (_initialize_fbsd_tdep): Update.
 910
 911 2019-05-08  Tom Tromey  <tom@tromey.com>
 912
 913         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 914         (get_ada_tasks_pspace_data): Update.
 915         (ada_tasks_pspace_data_cleanup): Remove.
 916         (_initialize_tasks): Update.
 917         (ada_tasks_inferior_data_handle): Change type.
 918         (get_ada_tasks_inferior_data): Update.
 919         (ada_tasks_inferior_data_cleanup): Remove.
 920         (struct ada_tasks_pspace_data): Add initializers.
 921
 922 2019-05-08  Tom Tromey  <tom@tromey.com>
 923
 924         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 925         * symfile-debug.c (debug_sym_get_probes): Change type.
 926         * stap-probe.c (handle_stap_probe):
 927         (stap_static_probe_ops::get_probes): Change type.
 928         * probe.h (class static_probe_ops) <get_probes>: Change type.
 929         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 930         (parse_probes_in_pspace): Update.
 931         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 932         Update.
 933         (any_static_probe_ops::get_probes): Change type.
 934         * elfread.c (elfread_data): New typedef.
 935         (probe_key): Change type.
 936         (elf_get_probes): Likewise.  Update.
 937         (probe_key_free): Remove.
 938         (_initialize_elfread): Update.
 939         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 940         Change type.
 941         (dtrace_process_dof_probe, dtrace_process_dof)
 942         (dtrace_static_probe_ops::get_probe): Change type.
 943
 944 2019-05-08  Tom Tromey  <tom@tromey.com>
 945
 946         * xcoffread.c (struct xcoff_symfile_info): Rename from
 947         coff_symfile_info.  Add initializers.
 948         (xcoff_objfile_data_key): Move lower.  Change type.
 949         (XCOFF_DATA): Rewrite.
 950         (xcoff_free_info): Remove.
 951         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 952         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 953         (xcoff_initial_scan): Update.
 954
 955 2019-05-08  Tom Tromey  <tom@tromey.com>
 956
 957         * solib-svr4.c (struct svr4_info): Add initializers and
 958         destructor.
 959         <probes_table>: Now an htab_up.
 960         (solib_svr4_pspace_data): Change type.
 961         (free_probes_table): Simplify.
 962         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 963         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 964         (probes_table_remove_objfile_probes, register_solib_event_probe)
 965         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 966         (_initialize_svr4_solib): Update.
 967
 968 2019-05-08  Tom Tromey  <tom@tromey.com>
 969
 970         * remote.c (remote_pspace_data): Change type.
 971         (remote_pspace_data_cleanup): Remove.
 972         (get_remote_exec_file, set_pspace_remote_exec_file)
 973         (_initialize_remote): Update.
 974
 975 2019-05-08  Tom Tromey  <tom@tromey.com>
 976
 977         * breakpoint.c (breakpoint_objfile_key): Change type.
 978         (get_breakpoint_objfile_data): Update.
 979         (free_breakpoint_objfile_data): Remove.
 980         (_initialize_breakpoint): Update.
 981
 982 2019-05-08  Tom Tromey  <tom@tromey.com>
 983
 984         * linux-tdep.c (struct linux_info): Add initializers.
 985         (linux_inferior_data): Move.  Change type.
 986         (invalidate_linux_cache_inf): Update.
 987         (linux_inferior_data_cleanup): Remove.
 988         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 989
 990 2019-05-08  Tom Tromey  <tom@tromey.com>
 991
 992         * auxv.c (auxv_inferior_data): Move.  Change type.
 993         (auxv_inferior_data_cleanup): Remove.
 994         (invalidate_auxv_cache_inf): Rewrite.
 995         (get_auxv_inferior_data, _initialize_auxv): Update.
 996
 997 2019-05-08  Tom Tromey  <tom@tromey.com>
 998
 999         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1000         (symfile_debug_objfile_data_key): Change type.
1001         (symfile_debug_installed, debug_qf_has_symbols)
1002         (debug_qf_find_last_source_symtab)
1003         (debug_qf_forget_cached_source_info)
1004         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1005         (debug_qf_print_stats, debug_qf_dump)
1006         (debug_qf_expand_symtabs_for_function)
1007         (debug_qf_expand_all_symtabs)
1008         (debug_qf_expand_symtabs_with_fullname)
1009         (debug_qf_map_matching_symbols)
1010         (debug_qf_expand_symtabs_matching)
1011         (debug_qf_find_pc_sect_compunit_symtab)
1012         (debug_qf_map_symbol_filenames)
1013         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1014         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1015         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1016         (debug_sym_read_linetable, debug_sym_relocate): Update.
1017         (symfile_debug_free_objfile): Remove.
1018         (install_symfile_debug_logging, _initialize_symfile_debug):
1019         Update.
1020
1021 2019-05-08  Tom Tromey  <tom@tromey.com>
1022
1023         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1024         allocate_on_obstack.
1025         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1026         (get_dwarf2_per_objfile): Update.
1027         (set_dwarf2_per_objfile): Remove.
1028         (dwarf2_has_info, dwarf2_get_section_info): Update.
1029         (dwarf2_free_objfile): Remove.
1030         (_initialize_dwarf2_read): Update.
1031
1032 2019-05-08  Tom Tromey  <tom@tromey.com>
1033
1034         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1035         initializers.
1036         <unsupported_script_warning_printed,
1037         script_not_found_warning_printed>: Now bool.
1038         (auto_load_pspace_data): Change type.
1039         (~auto_load_pspace_info): Rename from
1040         auto_load_pspace_data_cleanup.
1041         (get_auto_load_pspace_data, init_loaded_scripts_info)
1042         (clear_section_scripts, maybe_print_unsupported_script_warning)
1043         (maybe_print_script_not_found_warning, _initialize_auto_load):
1044         Update.
1045
1046 2019-05-08  Tom Tromey  <tom@tromey.com>
1047
1048         * objfiles.c (objfile_pspace_info): Add destructor and
1049         initializers.
1050         (objfiles_pspace_data): Change type.
1051         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1052         (get_objfile_pspace_data): Update.
1053         (objfiles_bfd_data): Change type.
1054         (get_objfile_bfd_data): Update.
1055         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1056
1057 2019-05-08  Tom Tromey  <tom@tromey.com>
1058
1059         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1060         Change type.
1061         (get_catch_syscall_inferior_data): Update.
1062         (catch_syscall_inferior_data_cleanup): Remove.
1063         (_initialize_break_catch_syscall): Update.
1064
1065 2019-05-08  Tom Tromey  <tom@tromey.com>
1066
1067         * inflow.c (struct terminal_info): Add destructor and
1068         initializers.
1069         (inflow_inferior_data): Change type.
1070         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1071         (get_inflow_inferior_data, inflow_inferior_exit)
1072         (swap_terminal_info, _initialize_inflow): Update.
1073
1074 2019-05-08  Tom Tromey  <tom@tromey.com>
1075
1076         * target-dcache.c (target_dcache_cleanup): Remove.
1077         (target_dcache_aspace_key): Change type.
1078         (target_dcache_init_p, target_dcache_invalidate)
1079         (target_dcache_get, target_dcache_get_or_init)
1080         (_initialize_target_dcache): Update.
1081         * dcache.h (struct dcache_deleter): New.
1082
1083 2019-05-08  Tom Tromey  <tom@tromey.com>
1084
1085         * symtab.c (struct symbol_cache): Add destructor and
1086         initializers.
1087         (symbol_cache_key): Move.  Change type.
1088         (make_symbol_cache, free_symbol_cache): Remove.
1089         (get_symbol_cache): Update.
1090         (symbol_cache_cleanup): Remove.
1091         (ALL_PSPACES, symbol_cache_flush)
1092         (maintenance_print_symbol_cache)
1093         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1094         Update.
1095
1096 2019-05-08  Tom Tromey  <tom@tromey.com>
1097
1098         * symtab.c (struct main_info): Add destructor and initializers.
1099         (main_progspace_key): Move.  Change type.
1100         (get_main_info): Update.
1101         (main_info_cleanup): Remove.
1102         (_initialize_symtab): Update.
1103
1104 2019-05-08  Tom Tromey  <tom@tromey.com>
1105
1106         * registry.h (DECLARE_REGISTRY): Define the _key class.
1107
1108 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1109
1110         * NEWS: Merge two 'New commands' sections.
1111
1112 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1113
1114         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1115         parameter and use Ada language definition instead.
1116         (ada_val_print_ptr): Remove unused language parameter.
1117         (ada_val_print_num): Remove language parameter and use Ada language
1118         definition instead.
1119         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1120         parameter.
1121         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1122         parameter and use Ada language definition instead.
1123         (ada_val_print_1): Update all ada_val_print_xxx calls.
1124         Remove language parameter.
1125         (ada_val_print): Update ada_val_print_1 call.
1126
1127 2019-05-08  Tom Tromey  <tromey@adacore.com>
1128
1129         * remote.c (remote_hw_watchpoint_limit)
1130         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1131         Now static.
1132
1133 2019-05-08  Tom Tromey  <tromey@adacore.com>
1134
1135         * maint.c (_initialize_maint_cmds): Move initialization code to
1136         remote.c.
1137         (watchdog, show_watchdog): Move to remote.c.
1138         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1139         "watchdog" static.
1140         (_initialize_remote): Move initialization code from maint.c.
1141         * defs.h (watchdog): Don't declare.
1142
1143 2019-05-08  Tom Tromey  <tromey@adacore.com>
1144
1145         * tui/tui-interp.c: Include main.h.
1146         * interps.c: Include main.h.
1147         * main.h (interpreter_p): Declare.
1148         * defs.h (interpreter_p): Don't declare.
1149
1150 2019-05-08  Tom Tromey  <tromey@adacore.com>
1151
1152         * dwarf2loc.c: Include dwarf2read.h.
1153         * defs.h (read_unsigned_leb128): Don't declare.
1154         * dwarf2read.h (read_unsigned_leb128): Declare.
1155
1156 2019-05-08  Tom Tromey  <tromey@adacore.com>
1157
1158         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1159         method.
1160
1161 2019-05-08  Tom Tromey  <tromey@adacore.com>
1162
1163         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1164         when no wrap column is set.
1165
1166 2019-05-08  Tom Tromey  <tromey@adacore.com>
1167
1168         * c-lang.c (c_get_string): Handle non-C-style arrays.
1169
1170 2019-05-08  Tom Tromey  <tromey@adacore.com>
1171
1172         * typeprint.c (print_offset_data::update): Print the bit offset,
1173         not the number of bits remaining.
1174
1175 2019-05-08  Tom Tromey  <tromey@adacore.com>
1176
1177         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1178         padding at end of comment.
1179
1180 2019-05-08  Tom Tromey  <tromey@adacore.com>
1181
1182         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1183         Compare main types.
1184
1185 2019-05-06  Tom Tromey  <tom@tromey.com>
1186
1187         * common/scoped_mmap.c: Include common-defs.h.
1188         * common/scoped_mmap.h: Don't include config.h.
1189
1190 2019-05-04  Tom Tromey  <tom@tromey.com>
1191
1192         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1193         (struct aarch64_call_info): Add initializers.
1194         <si>: Now a std::vector.
1195         (pass_on_stack, aarch64_push_dummy_call): Update.
1196
1197 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1198             Tom Tromey  <tom@tromey.com>
1199
1200         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1201         (ppc_threads): Now a std::vector.  Now static.
1202         (hwdebug_find_thread_points_by_tid)
1203         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1204         Update.
1205
1206 2019-05-04  Tom Tromey  <tom@tromey.com>
1207
1208         * arc-tdep.c (arc_tdesc_init): Return bool.
1209
1210 2019-05-04  Tom Tromey  <tom@tromey.com>
1211
1212         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1213         Use gdb_assert_not_reached.
1214
1215 2019-05-04  Tom Tromey  <tom@tromey.com>
1216
1217         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1218         "false".
1219
1220 2019-05-04  Tom Tromey  <tom@tromey.com>
1221
1222         * arc-tdep.c (arc_tdesc_init): Use bool.
1223
1224 2019-05-04  Tom Tromey  <tom@tromey.com>
1225
1226         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1227
1228 2019-05-04  Tom Tromey  <tom@tromey.com>
1229
1230         * cli/cli-cmds.c (valid_command_p): Return bool.
1231
1232 2019-05-04  Tom Tromey  <tom@tromey.com>
1233
1234         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1235         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1236
1237 2019-05-04  Raul Tambre  <raul@tambre.ee>
1238
1239         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1240         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1241         operator for comparison.
1242
1243 2019-05-04  Tom Tromey  <tom@tromey.com>
1244
1245         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1246         (lookup_partial_symbol, print_partial_symbols)
1247         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1248         (psymbol_compare): Update.
1249         (add_psymbol_to_bcache): Clear the entire psymbol.
1250         (maintenance_check_psymtabs): Update.
1251         * psympriv.h (struct partial_symbol): Don't derive from
1252         general_symbol_info.
1253         <obj_section, unrelocated_address, address,
1254         set_unrelocated_address>: Update.
1255         <ginfo>: New member.
1256         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1257         (debug_names::write_psymbols): Update.
1258
1259 2019-05-04  Tom de Vries  <tdevries@suse.de>
1260
1261         * contrib/cc-with-tweaks.sh: Support -n arg.
1262
1263 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1264
1265         * corelow.c (core_target::detach): Ensure frame cache and
1266         register caches are cleared.
1267         inferior.c (exit_inferior_1): Likewise.
1268
1269 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1270             Tom Tromey  <tom@tromey.com>
1271
1272         * dictionary.c (collate_pending_symbols_by_language): Remove
1273         "struct" from foreach.
1274         * symtab.c (lookup_global_symbol_from_objfile)
1275         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1276         foreach.
1277         * ser-tcp.c (net_open): Remove "struct" from foreach.
1278         * objfiles.c (objfile_relocate, objfile_rebase)
1279         (objfile_has_symbols): Remove "struct" from foreach.
1280         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1281         from foreach.
1282         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1283         foreach.
1284         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1285         "struct" from foreach.
1286         * ada-lang.c (create_excep_cond_exprs)
1287         (ada_exception_catchpoint_cond_string): Remove "struct" from
1288         foreach.
1289
1290 2019-05-03  Tom Tromey  <tromey@adacore.com>
1291
1292         * ada-exp.y (convert_char_literal): Check suffix of each
1293         enumerator.
1294
1295 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1296
1297         PR ada/21406:
1298         * ada-exp.y (yywrap): Don't define.
1299         * ada-lex.l (%option): Add noyywrap
1300         (yywrap): Remove.
1301
1302 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1303
1304         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1305         _WIN32_WINNT to the XP level, unless already defined to a higher
1306         level.
1307
1308         * unittests/parse-connection-spec-selftests.c:
1309         * ser-tcp.c:
1310         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1311         override.
1312
1313         * symfile.c (find_separate_debug_file): Remove colon from the
1314         drive spec of DOS/Windows file names of the target, so that the
1315         file name produced from DEBUGDIR and the target's directory will
1316         be valid on DOS/Windows systems.
1317
1318 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1319
1320         * rust-lang.c (val_print_struct): Handle printing structures
1321         containing strings.
1322
1323 2019-05-02  Tom Tromey  <tromey@adacore.com>
1324
1325         * valarith.c (_initialize_valarith): Remove.
1326
1327 2019-05-01  Tom Tromey  <tromey@adacore.com>
1328
1329         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1330         bitfields.
1331
1332 2019-05-01  Tom Tromey  <tromey@adacore.com>
1333
1334         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1335         for big-endian copies.
1336
1337 2019-04-30  Ali Tamur  <tamur@google.com>
1338         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1339         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1340         (read_3_bytes): New function.
1341
1342 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1343
1344         * windows-nat.c (main_thread_id): Delete.
1345         (handle_output_debug_string): Replace main_thread_id by
1346         current_event.dwThreadId.
1347         (fake_create_process): Likewise.
1348         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1349         Do not set main_thread_id.
1350         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1351         current_event.dwThreadId.
1352         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1353
1354 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1355
1356         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1357         Use current_event.dwThreadId instead of main_thread_id.
1358
1359 2019-04-30  Tom Tromey  <tromey@adacore.com>
1360
1361         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1362         (create_excep_cond_exprs): Iterate over program spaces.
1363         (ada_exception_catchpoint_cond_string): Examine all minimal
1364         symbols for exception types.
1365
1366 2019-04-30  Tom Tromey  <tromey@adacore.com>
1367
1368         PR c++/24470:
1369         * dwarf2read.c (process_structure_scope): Handle case where type
1370         has template parameters but no symbol was created.
1371
1372 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1373             Chris January  <chris.january@arm.com>
1374
1375         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1376         qualifier.
1377         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1378
1379 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1380
1381         * f-typeprint.c (f_print_type): Update rules for printing
1382         whitespace.
1383         (f_type_print_varspec_suffix): Likewise.
1384
1385 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1386             Chris January  <chris.january@arm.com>
1387
1388         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1389         function arguments.
1390
1391 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1392
1393         * f-lang.c (build_fortran_types): Change name of void type to
1394         lower case.
1395         * f-typeprint.c (f_type_print_base): Print the name of the void
1396         type, rather than a fixed string.
1397         * f-valprint.c (f_decorations): Use lower case void string.
1398
1399 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1400             Chris January  <chris.january@arm.com>
1401
1402         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1403         types for Fortran.
1404
1405 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1406             Chris January  <chris.january@arm.com>
1407             David Lecomber  <david.lecomber@arm.com>
1408
1409         * f-exp.y (BINOP_INTRINSIC): New token.
1410         (exp): New parser rule handling BINOP_INTRINSIC.
1411         (f77_keywords): Add new builtin procedures.
1412         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1413         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1414         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1415         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1416         (print_unop_subexp_f): New function.
1417         (print_binop_subexp_f): New function.
1418         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1419         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1420         (dump_subexp_body_f): Likewise.
1421         (operator_check_f): Likewise.
1422         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1423         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1424
1425 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1426
1427         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1428         UNOP_KIND.
1429         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1430         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1431         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1432         (operator_length_f): New fuction.
1433         (print_subexp_f): New function.
1434         (op_name_f): New function.
1435         (dump_subexp_body_f): New function.
1436         (operator_check_f): New function.
1437         (exp_descriptor_f): Replace standard expression handling functions
1438         with new functions.
1439         * gdb/fortran-operator.def: New file.
1440         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1441         * gdb/std-operator.def: Remove UNOP_KIND.
1442
1443 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1444
1445         * std-operator.def: Remove unbalanced, stray double quote
1446         character.
1447
1448 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1449             Chris January  <chris.january@arm.com>
1450             Daniel Everett  <daniel.everett@arm.com>
1451             Nick Forrington  <nick.forrington@arm.com>
1452             Richard Bunt  <richard.bunt@arm.com>
1453
1454         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1455         of depth when printing anonymous structs or unions.
1456         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1457         Don't print either the top-level value, or the children if the
1458         max-depth is exceeded.
1459         (ppscm_print_children): When printing the key of a map, allow one
1460         extra level of depth.
1461         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1462         print either the top-level value, or the children if the max-depth
1463         is exceeded.
1464         (print_children): When printing the key of a map, allow one extra
1465         level of depth.
1466         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1467         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1468         (user_print_options): Initialise max_depth field.
1469         (val_print_scalar_or_string_type_p): New function.
1470         (val_print): Check to see if the max depth has been reached.
1471         (val_print_check_max_depth): Define new function.
1472         (show_print_max_depth): New function.
1473         (_initialize_valprint): Add 'print max-depth' option.
1474         * valprint.h (struct value_print_options) <max_depth>: New field.
1475         (val_print_check_max_depth): Declare new function.
1476         * NEWS: Document new feature.
1477
1478 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1479
1480         * ada-lang.c (ada_language_defn): Initialise new field.
1481         * c-lang.c (c_is_string_type_p): New function.
1482         (c_language_defn): Initialise new field.
1483         (cplus_language_defn): Initialise new field.
1484         (asm_language_defn): Initialise new field.
1485         (minimal_language_defn): Initialise new field.
1486         * c-lang.h (c_is_string_type_p): Declare new function.
1487         * d-lang.c (d_language_defn): Initialise new field.
1488         * f-lang.c (f_is_string_type_p): New function.
1489         (f_language_defn): Initialise new field.
1490         * go-lang.c (go_is_string_type_p): New function.
1491         (go_language_defn): Initialise new field.
1492         * language.c (default_is_string_type_p): New function.
1493         (unknown_language_defn): Initialise new field.
1494         (auto_language_defn): Initialise new field.
1495         * language.h (struct language_defn) <la_is_string_type_p>: New
1496         member variable.
1497         (default_is_string_type_p): Declare new function.
1498         * m2-lang.c (m2_language_defn): Initialise new field.
1499         * objc-lang.c (objc_language_defn): Initialise new field.
1500         * opencl-lang.c (opencl_language_defn): Initialise new field.
1501         * p-lang.c (pascal_is_string_type_p): New function.
1502         (pascal_language_defn): Initialise new field.
1503         * rust-lang.c (rust_is_string_type_p): New function.
1504         (rust_language_defn): Initialise new field.
1505
1506 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1507
1508         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1509         New field.
1510         * ada-lang.c (ada_language_defn): Initialise new field.
1511         * c-lang.c (c_language_defn): Likewise.
1512         (cplus_language_defn): Likewise.
1513         (asm_language_defn): Likewise.
1514         (minimal_language_defn): Likewise.
1515         * d-lang.c (d_language_defn): Likewise.
1516         * f-lang.c (f_language_defn): Likewise.
1517         * go-lang.c (go_language_defn): Likewise.
1518         * language.c (unknown_language_defn): Likewise.
1519         (auto_language_defn): Likewise.
1520         * m2-lang.c (m2_language_defn): Likewise.
1521         * objc-lang.c (objc_language_defn): Likewise.
1522         * opencl-lang.c (opencl_language_defn): Likewise.
1523         * p-lang.c (pascal_language_defn): Likewise.
1524         * rust-lang.c (rust_language_defn): Likewise.
1525
1526 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1527
1528         * ada-lang.c (ada_is_character_type): Change return type to bool.
1529         (ada_is_string_type): Likewise.
1530         * ada-lang.h (ada_is_character_type): Update declaration
1531         (ada_is_string_type): Likewise.
1532
1533 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1534
1535         Support style in 'frame|thread apply'
1536
1537         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1538         * record.c (record_start, record_stop): Update callers of
1539         execute_command_to_string with false.
1540         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1541         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1542         methods.
1543         (class string_file): New constructor with term_out parameter.
1544         Override methods term_out and can_emit_style_escape.  New member
1545         term_out.
1546         (class stdio_file): Override can_emit_style_escape.
1547         (class tee_file): Override term_out and can_emit_style_escape.
1548         * utils.h (can_emit_style_escape): Remove.
1549         * utils.c (can_emit_style_escape): Likewise.
1550         Update all callers of can_emit_style_escape (SOMESTREAM) to
1551         SOMESTREAM->can_emit_style_escape.
1552         * source-cache.c (source_cache::get_source_lines): Likewise.
1553         * stack.c (frame_apply_command_count): Call execute_command_to_string
1554         passing the term_out characteristic of the current gdb_stdout.
1555         * thread.c (thr_try_catch_cmd): Likewise.
1556         * top.c (execute_command_to_string): pass term_out parameter
1557         to construct the string_file for the command output.
1558         * ui-file.c (term_cli_styling): New function (most code moved
1559         from utils.c can_emit_style_escape).
1560         (string_file::string_file, string_file::can_emit_style_escape,
1561         stdio_file::can_emit_style_escape, tee_file::term_out,
1562         tee_file::can_emit_style_escape): New functions.
1563
1564 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1565
1566         * NEWS: Mention the new set|show may-call-functions.
1567         * infcall.c (may_call_functions_p): New variable.
1568         (show_may_call_functions_p): New function.
1569         (call_function_by_hand_dummy): Throws an error if not
1570         may-call-functions.
1571         (_initialize_infcall): Call add_setshow_boolean_cmd for
1572         may-call-functions.
1573
1574 2019-04-25  Keith Seitz  <keiths@redhat.com>
1575
1576         PR c++/24367
1577         * cp-support.c (inspect_type): Don't attempt substitutions
1578         of symbol with the same name.
1579
1580 2019-04-25  Tom Tromey  <tromey@adacore.com>
1581
1582         PR gdb/24475:
1583         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1584         static.
1585
1586 2019-04-25  Tom Tromey  <tromey@adacore.com>
1587
1588         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1589         rvalue reference.
1590         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1591         (gdb_xml_parser::parse): Use std::move.
1592         * python/python-internal.h (gdbpy_convert_exception): Take a const
1593         reference.
1594         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1595         std::move.
1596         * python/py-utils.c (gdbpy_convert_exception): Take a const
1597         reference.
1598         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1599         Use std::move.
1600         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1601         Use std::move.
1602         * mi/mi-main.c (mi_print_exception): Take a const reference.
1603         * main.c (handle_command_errors): Take a const reference.
1604         * linespec.c (parse_linespec): Use std::move.
1605         * infcall.c (run_inferior_call): Use std::move.
1606         (call_function_by_hand_dummy): Use std::move.
1607         * exec.c (try_open_exec_file): Use std::move.
1608         * exceptions.h (exception_print, exception_fprintf)
1609         (exception_print_same): Update.
1610         * exceptions.c (print_exception, exception_print)
1611         (exception_fprintf, exception_print_same): Change parameters to
1612         const reference.
1613         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1614         * common/new-op.c: Use std::move.
1615         * common/common-exceptions.h (struct gdb_exception): Add move
1616         constructor.
1617         (struct gdb_exception_error, struct gdb_exception_quit, struct
1618         gdb_quit_bad_alloc): Change constructor to move constructor.
1619         (throw_exception): Change parameter to rvalue reference.
1620         * common/common-exceptions.c (throw_exception): Take rvalue
1621         reference.
1622         * cli/cli-interp.c (safe_execute_command): Use std::move.
1623         * breakpoint.c (insert_bp_location, location_to_sals): Use
1624         std::move.
1625
1626 2019-04-25  Tom Tromey  <tromey@adacore.com>
1627
1628         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1629         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1630         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1631         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1632         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1633         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1634         guile/scm-value.c: Use unpack.
1635         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1636         gdbscm_gdb_exception.
1637         (gdbscm_throw_gdb_exception): Likewise.
1638         (struct gdbscm_gdb_exception): New.
1639         (unpack): New function.
1640         (gdbscm_wrap): Use unpack.
1641
1642 2019-04-25  Tom Tromey  <tromey@adacore.com>
1643
1644         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1645         (gdb_rl_callback_handler): Use std::move.
1646         * common/common-exceptions.h (struct gdb_exception): Add move
1647         assignment operator.
1648         (throw_exception_sjlj): Change "exception" to const reference.
1649         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1650         (throw_exception_sjlj): Change "exception" to const reference.
1651
1652 2019-04-25  Tom Tromey  <tromey@adacore.com>
1653
1654         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1655         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1656         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1657         Update.
1658         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1659         Update.
1660         * mi/mi-interp.c (mi_interp::exec): Update.
1661         * linespec.c (parse_linespec): Update.
1662         * infcall.c (run_inferior_call): Update.
1663         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1664         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1665         (gdbscm_lookup_global_symbol): Update.
1666         * guile/scm-param.c (gdbscm_parameter_value): Update.
1667         * guile/scm-frame.c (gdbscm_frame_read_register)
1668         (gdbscm_frame_read_var): Update.
1669         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1670         * exec.c (try_open_exec_file): Update.
1671         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1672         (gdb_rl_callback_handler): Update.
1673         * common/common-exceptions.h (exception_none): Don't declare.
1674         * common/common-exceptions.c (exception_none): Don't define.
1675         (struct catcher) <exception>: Update.
1676         * cli/cli-interp.c (safe_execute_command): Update.
1677         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1678
1679 2019-04-25  Ali Tamur  <tamur@google.com>
1680
1681         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1682         (read_attribute_value): Likewise.
1683         (dwarf2_read_addr_index): Update comment.
1684         (read_str_index): Add DW_FORM_strx.
1685         (dwarf2_string_attr): Likewise.
1686         (dwarf2_const_value_attr): Likewise.
1687         (dump_die_shallow): Likewise.
1688         (dwarf2_fetch_constant_bytes): Likewise.
1689         (skip_form_bytes): Likewise.
1690         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1691
1692 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1693
1694         PR corefiles/11608
1695         PR corefiles/18187
1696         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1697         OFFSET.  Verify if current mapping contains an ELF header.
1698         (linux_find_memory_regions_full): Adjust call to
1699         dump_mapping_p.
1700
1701 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1702             Kang Li <kanglictf@gmail.com>
1703
1704         PR gdb/21600
1705
1706         * dwarf2-frame.c (read_initial_length): Be consistent about using
1707         unsigned representation of length.
1708         (decode_frame_entry_1): Likewise.  Check for wraparound of
1709         end pointer as well as buffer overflow.
1710
1711 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1712
1713         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1714         "vq".
1715
1716 2019-04-24  Tom Tromey  <tromey@adacore.com>
1717
1718         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1719
1720 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1721
1722         * s12z-tdep.c (s12z_unwind_pc): Delete.
1723         (s12z_unwind_sp): Delete.
1724         (s12z_gdbarch_init): Don't register deleted functions with
1725         gdbarch.
1726
1727 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1728
1729         * rl78-tdep.c (rl78_unwind_sp): Delete.
1730         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1731
1732 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1733
1734         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1735         (xstormy16_unwind_pc): Delete.
1736         (xstormy16_dummy_id): Delete.
1737         (xstormy16_gdbarch_init): Don't register deleted functions with
1738         gdbarch.
1739
1740 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1741
1742         * vax-tdep.c (vax_unwind_pc): Delete.
1743         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1744
1745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1746
1747         * v850-tdep.c (v850_unwind_sp): Delete.
1748         (v850_unwind_pc): Delete.
1749         (v850_dummy_id): Delete.
1750         (v850_gdbarch_init): Don't register deleted functions with
1751         gdbarch.
1752
1753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1754
1755         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1756         (tilegx_unwind_pc): Delete.
1757         (tilegx_unwind_dummy_id): Delete.
1758         (tilegx_gdbarch_init): Don't register deleted functions with
1759         gdbarch.
1760
1761 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1762
1763         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1764         (tic6x_dummy_id): Delete.
1765         (tic6x_gdbarch_init): Don't register deleted functions with
1766         gdbarch.
1767
1768 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1769
1770         * sparc-tdep.c (sparc_unwind_pc): Delete.
1771         (sparc32_gdbarch_init): Don't register deleted function with
1772         gdbarch.
1773
1774 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1775
1776         * sh-tdep.c (sh_unwind_sp): Delete.
1777         (sh_unwind_pc): Delete.
1778         (sh_dummy_id): Delete.
1779         (sh_gdbarch_init): Don't register deleted functions with
1780         gdbarch.
1781
1782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1783
1784         * score-tdep.c (score_unwind_sp): Delete.
1785         (score_unwind_pc): Delete.
1786         (score_dummy_id): Delete.
1787         (score_gdbarch_init): Don't register deleted functions with
1788         gdbarch.
1789
1790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1791
1792         * rx-tdep.c (rx_unwind_pc): Delete.
1793         (rx_unwind_sp): Delete.
1794         (rx_dummy_id): Delete.
1795         (rx_gdbarch_init): Don't register deleted functions with
1796         gdbarch.  Update comment.
1797
1798 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1799
1800         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1801         (rs6000_dummy_id): Delete.
1802         (rs6000_gdbarch_init): Don't register deleted functions with
1803         gdbarch.
1804
1805 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1806
1807         * or1k-tdep.c (or1k_dummy_id): Delete.
1808         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1809
1810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1811
1812         * nios2-tdep.c (nios2_dummy_id): Delete.
1813         (nios2_unwind_sp): Delete.
1814         (nios2_gdbarch_init): Don't register deleted functions with
1815         gdbarch.
1816
1817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1818
1819         * nds32-tdep.c (nds32_dummy_id): Delete.
1820         (nds32_unwind_pc): Delete.
1821         (nds32_unwind_sp): Delete.
1822         (nds32_gdbarch_init): Don't register deleted functions with
1823         gdbarch.
1824
1825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1826
1827         * msp430-tdep.c (msp430_unwind_pc): Delete.
1828         (msp430_unwind_sp): Delete.
1829         (msp430_dummy_id): Delete.
1830         (msp430_gdbarch_init): Don't register deleted functions with
1831         gdbarch.
1832
1833 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1834
1835         * moxie-tdep.c (moxie_unwind_sp): Delete.
1836         (moxie_unwind_pc): Delete.
1837         (moxie_dummy_id): Delete.
1838         (moxie_gdbarch_init): Don't register deleted functions with
1839         gdbarch.
1840
1841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1842
1843         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1844         (mn10300_unwind_pc): Delete.
1845         (mn10300_unwind_sp): Delete.
1846         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1847         mn10300_unwind_sp.
1848         (mn10300_frame_unwind_init): Don't register deleted functions with
1849         gdbarch.
1850
1851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1852
1853         * mep-tdep.c (mep_unwind_pc): Delete.
1854         (mep_unwind_sp): Delete.
1855         (mep_dummy_id): Delete.
1856         (mep_gdbarch_init): Don't register deleted functions with
1857         gdbarch.
1858
1859 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1860
1861         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1862         (m68hc11_unwind_sp): Delete.
1863         (m68hc11_gdbarch_init): Don't register deleted functions with
1864         gdbarch.
1865
1866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1867
1868         * m32r-tdep.c (m32r_unwind_sp): Delete.
1869         (m32r_unwind_pc): Delete.
1870         (m32r_dummy_id): Delete.
1871         (m32r_gdbarch_init): Don't register deleted functions with
1872         gdbarch.
1873
1874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1875
1876         * m32c-tdep.c (m32c_unwind_pc): Delete.
1877         (m32c_unwind_sp): Delete.
1878         (m32c_dummy_id): Delete.
1879         (m32c_gdbarch_init): Don't register deleted functions with
1880         gdbarch.
1881
1882 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1883
1884         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1885         (lm32_unwind_pc): Delete.
1886         (lm32_dummy_id): Delete.
1887         (lm32_gdbarch_init): Don't register deleted functions with
1888         gdbarch.
1889
1890 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1891
1892         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1893         (iq2000_unwind_pc): Delete.
1894         (iq2000_dummy_id): Delete.
1895         (iq2000_gdbarch_init): Don't register deleted functions with
1896         gdbarch.
1897
1898 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1899
1900         * nds32-tdep.c (nds32_type_align): Delete.
1901         (nds32_push_dummy_call): Use type_align instead.
1902
1903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1904
1905         * arm-tdep.c (arm_type_align): Only handle vector override case.
1906         (arm_push_dummy_call): Use type_align.
1907         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1908
1909 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1910
1911         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1912         case.
1913         (pass_on_stack): Use type_align.
1914         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1915         function.
1916
1917 2019-04-23  Tom Tromey  <tromey@adacore.com>
1918
1919         * dwarf2read.c (line_header::file_name_at): Remove unused
1920         overload.
1921
1922 2019-04-23  Tom de Vries  <tdevries@suse.de>
1923
1924         PR gdb/24438
1925         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1926         invocation.
1927
1928
1929 2019-03-27  Ali Tamur  <tamur@google.com>
1930
1931         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1932         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1933         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1934         (dwarf_expr_context::get_addr_index): Likewise
1935         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1936         (symbol_needs_eval_context::get_addr_index): Likewise
1937         (disassemble_dwarf_expression): Add DW_OP_addrx
1938         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1939         (read_cutu_die_from_dwo): Update comment
1940         (skip_one_die): Add DW_FORM_addrx
1941         (read_attribute_value): Likewise
1942         (var_decode_location): Add DW_OP_addrx
1943         (dwarf2_const_value_attr): Add DW_FORM_addrx
1944         (dump_die_shallow): Likewise
1945         (dwarf2_fetch_constant_bytes): Likewise
1946         (decode_locdesc): Add DW_OP_addrx
1947         (skip_form_bytes): Add DW_FORM_addrx
1948
1949 2019-04-22  Ali Tamur  <tamur@google.com>
1950
1951         * MAINTAINERS (Write After Approval): Add self.
1952
1953 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1954
1955         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1956         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1957         (open_symbol_file_object): Likewise.
1958         (svr4_default_sos): Add info parameter.
1959         (svr4_read_so_list): Likewise.
1960         (svr4_current_sos_direct): Adjust functions calls to pass down
1961         info.
1962         (svr4_current_sos_1): Add info parameter.
1963         (svr4_current_sos): Call get_svr4_info, pass info down to
1964         svr4_current_sos_1.
1965         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1966         get_svr4_info.
1967         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1968         get_svr4_info.
1969         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1970         to get_svr4_info.
1971         (probes_table_remove_objfile_probes): Likewise.
1972         (register_solib_event_probe): Add info parameter.
1973         (solist_update_incremental): Pass info parameter down to
1974         svr4_read_so_list.
1975         (disable_probes_interface): Add info parameter.
1976         (svr4_handle_solib_event): Pass current_program_space to
1977         get_svr4_info.  Adjust disable_probes_interface cleanup.
1978         (svr4_create_probe_breakpoints): Add info parameter, pass it
1979         down to register_solib_event_probe.
1980         (svr4_create_solib_event_breakpoints): Add info parameter,
1981         pass it down to svr4_create_probe_breakpoints.
1982         (enable_break): Pass info down to
1983         svr4_create_solib_event_breakpoints.
1984         (svr4_solib_create_inferior_hook): Pass current_program_space to
1985         get_svr4_info.
1986         (svr4_clear_solib): Likewise.
1987
1988 2019-04-22  Pedro Alves  <palves@redhat.com>
1989
1990         * solib-svr4.c (svr4_free_objfile_observer): New.
1991         (probe_and_action::objfile): New field.
1992         (probes_table_htab_remove_objfile_probes)
1993         (probes_table_remove_objfile_probes): New functions.
1994         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1995         in the new probe_and_action.  Don't store the probe in 'lookup'.
1996         (svr4_create_probe_breakpoints): Pass objfile to
1997         register_solib_event_probe.
1998         (_initialize_svr4_solib): Register a free_objfile observer.
1999
2000 2019-04-19  Tom Tromey  <tom@tromey.com>
2001
2002         * common/queue.h: Remove.
2003
2004 2019-04-19  Tom Tromey  <tom@tromey.com>
2005
2006         * event-loop.c: Don't include "common/queue.h".
2007
2008 2019-04-19  Tom Tromey  <tom@tromey.com>
2009
2010         * remote.c (remote_target): Use delete.
2011         * remote-notif.h: Include <list>, not "common/queue.h".
2012         (notif_client_p): Remove typedef.
2013         (remote_notif_state): Add constructor, destructor, initializer.
2014         <notif_queue>: Now a std::list.
2015         (remote_notif_state_xfree): Don't declare.
2016         * remote-notif.c (remote_notif_process, handle_notification)
2017         (remote_notif_state_allocate): Update.
2018         (~remote_notif_state): Rename from remote_notif_state_xfree.
2019
2020 2019-04-19  Tom Tromey  <tom@tromey.com>
2021
2022         * symfile.c (reread_symbols): Update.
2023         * objfiles.c (objfile_register_static_link)
2024         (objfile_lookup_static_link): Update
2025         (~objfile) Don't delete static_links.
2026         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2027
2028 2019-04-19  Tom Tromey  <tom@tromey.com>
2029
2030         * type-stack.h (struct type_stack) <insert>: Constify string.
2031         * type-stack.c (type_stack::insert): Constify string.
2032         * gdbtypes.h (lookup_template_type): Update.
2033         (address_space_name_to_int): Update.
2034         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2035         const.
2036         (lookup_template_type): Make name const.
2037         * c-exp.y: Update rules.
2038         (lex_one_token, classify_name, classify_inner_name)
2039         (c_print_token): Update.
2040         * p-exp.y: Update rules.
2041         (yylex): Update.
2042         * f-exp.y: Update rules.
2043         (yylex): Update.
2044         * d-exp.y: Update rules.
2045         (lex_one_token, classify_name, classify_inner_name): Update.
2046         * parse.c (write_dollar_variable, copy_name): Return std::string.
2047         * parser-defs.h (copy_name): Change return type.
2048         * m2-exp.y: Update rules.
2049         (yylex): Update.
2050         * go-exp.y (lex_one_token): Update.
2051         Update rules.
2052         (classify_unsafe_function, classify_packaged_name)
2053         (classify_name, yylex): Update.
2054
2055 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2056
2057         * configure.ac: add --enable-source-highlight switch.
2058         * configure: Regenerate.
2059         * top.c (print_gdb_version): plumb --enable-source-highlight
2060         status to "show configuration".
2061
2062 2019-04-19  Tom Tromey  <tromey@adacore.com>
2063
2064         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2065         Check ADA_TYPE_P.
2066         (empty_record, ada_template_to_fixed_record_type_1)
2067         (template_to_static_fixed_type)
2068         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2069         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2070         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2071         macros.
2072
2073 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2074
2075         PR symtab/24423:
2076         * source.c (print_source_lines_base): Advance "iter" when a
2077         control character is seen.
2078
2079 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2080
2081         * inferior.h (struct infcall_suspend_state_deleter):
2082         Catch exception in destructor to avoid crash.
2083
2084 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2085
2086         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2087         close to the add_com "shell".
2088
2089 2019-04-18  Tom Tromey  <tromey@adacore.com>
2090
2091         * process-stratum-target.h (class process_stratum_target)
2092         <stratum>: Add "final".
2093
2094 2019-04-17  Tom Tromey  <tromey@adacore.com>
2095
2096         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2097         against nullptr before use.
2098
2099 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2100
2101         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2102
2103 2019-04-17  Jim Wilson  <jimw@sifive.com>
2104             Andrew Burgess  <andrew.burgess@embecosm.com>
2105
2106         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2107         code read might fail, assume 4-byte breakpoint in that case.
2108
2109 2019-04-15  Leszek Swirski  <leszeks@google.com>
2110
2111         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2112         rather than a hand-rolled POD check when checking for forced MEMORY
2113         classification.
2114
2115 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2116
2117         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2118         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2119         function.
2120         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2121         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2122         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2123         declaration.
2124
2125 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2126
2127         * aarch64-linux-nat.c
2128         (aarch64_linux_nat_target::thread_architecture): Add override.
2129         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2130         each VQ.
2131
2132 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2133
2134         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2135
2136 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2137
2138         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2139         target types of size 96-bits, add some additional comments, and
2140         check that the builtin type we found was the correct size.
2141
2142 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2143
2144         * utils.c (prompt_for_continue): Don't restore the styling at the
2145         end, as applied_style has the wrong value.  This fixes styling in
2146         long lists of file names that are interrupted by the "Continue?"
2147         prompt.
2148
2149 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2150
2151         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2152         * c-lang.c (c_language_defn): Likewise.
2153         (cplus_language_defn): Likewise.
2154         (asm_language_defn): Likewise.
2155         (minimal_language_defn): Likewise.
2156         * d-lang.c (d_language_defn): Likewise.
2157         * f-lang.c (f_language_defn): Likewise.
2158         * go-lang.c (go_language_defn): Likewise.
2159         * language.c (unknown_language_defn): Likewise.
2160         (auto_language_defn): Likewise.
2161         * language.h (struct language_defn): Remove la_magic field.
2162         (LANG_MAGIC): Delete.
2163         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2164         * objc-lang.c (objc_language_defn): Likewise.
2165         * opencl-lang.c (opencl_language_defn): Likewise.
2166         * p-lang.c (pascal_language_defn): Likewise.
2167         * rust-lang.c (rust_language_defn): Likewise.
2168
2169 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2170
2171         * riscv-tdep.c (riscv_type_align): New function.
2172         (riscv_type_alignment): Delete.
2173         (riscv_arg_location): Use 'type_align'.
2174         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2175
2176 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2177
2178         * gdbtypes.c (type_align): A struct with no non-static fields also
2179         has alignment of 1.
2180
2181 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2182
2183         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2184         component to 0.
2185         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2186         member.
2187         (riscv_struct_info::analyse): New implementation using new
2188         analyse_inner member function.
2189         (riscv_struct_info::field_offset): New member function.
2190         (riscv_struct_info::m_offsets): New member variable.
2191         (riscv_struct_info::analyse_inner): New private member function,
2192         takes the old implementation of riscv_struct_info::analyse but
2193         extended to track field offsets.
2194         (riscv_call_arg_struct): Update the struct folding special cases
2195         to handle cases where empty C++ structs, which are non-zero
2196         length, are found.
2197         (riscv_arg_location): Initialise the length of each location, a
2198         non-zero length now indicates the location is in use.
2199         (riscv_push_dummy_call): Allow for the first location having a
2200         non-zero offset when setting up arguments.
2201         (riscv_return_value): Likewise, but for return values.
2202
2203 2019-04-11  Tom Tromey  <tromey@adacore.com>
2204
2205         * utils.c (internal_vproblem): Make "msg" const.
2206
2207 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2208
2209         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2210         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2211         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2212         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2213
2214 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2215
2216         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2217         function.
2218         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2219         of amd64_collect_native_gregset.
2220         (amd64_linux_nat_target::store_registers): Likewise.
2221
2222 2019-04-10  Tom Tromey  <tom@tromey.com>
2223
2224         * symtab.c (lookup_global_symbol_from_objfile)
2225         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2226         * objfiles.h (class separate_debug_iterator): New.
2227         (class separate_debug_range): New.
2228         (struct objfile) <separate_debug_objfiles>: New method.
2229         (objfile_separate_debug_iterate): Don't declare.
2230         * objfiles.c (separate_debug_iterator::operator++): Rename from
2231         objfile_separate_debug_iterate.
2232         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2233         iterator.
2234         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2235         iterator.
2236
2237 2019-04-10  Tom Tromey  <tom@tromey.com>
2238
2239         * symfile.c (reread_symbols): Remove old comment.
2240         * objfiles.c (free_all_objfiles): Fix a typo.
2241
2242 2019-04-10  Tom Tromey  <tom@tromey.com>
2243
2244         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2245         * minsyms.c (lookup_minimal_symbol): Use foreach.
2246         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2247         (lookup_minimal_symbol_solib_trampoline): Likewise.
2248         * symfile.c (reread_symbols): Use foreach.
2249
2250 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2251             Tom Tromey  <tromey@adacore.com>
2252
2253         PR rust/24414:
2254         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2255         (rust_lex_int_test): Change "value" to be LONGEST.
2256         (rust_lex_tests): Add test for long integer literal.
2257
2258 2019-04-09  Tom Tromey  <tromey@adacore.com>
2259
2260         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2261         to bool.
2262         (extended_remote_target::attach): Update.
2263         (remote_target::remote_notice_new_inferior): Update.
2264         (remote_target::add_current_inferior_and_thread): Update.
2265         * inferior.c (exit_inferior_1): Use "false".
2266         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2267
2268 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2269
2270         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2271         the "start" command.
2272
2273 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2274
2275         * python/py-inferior.c (infpy_thread_from_thread_handle):
2276         Adjust comments to reflect renaming of thread_from_thread_handle
2277         to thread_from_handle.  Adjust keywords.  Fix type error message.
2278         (inferior_object_methods): Add thread_from_handle.  Retain
2279         thread_from_thread_handle, but mark it as deprecated.
2280
2281 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2282
2283         * gdbthread.h (find_thread_by_handle): Revise declaration.
2284         * thread.c (find_thread_by_handle): Likewise.  Adjust
2285         implementation too.
2286         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2287         support for buffer objects as handles.
2288
2289 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2290
2291         * python/py-infthread.c (thpy_thread_handle): New function.
2292         (thread_object_methods): Register thpy_thread_handle.
2293
2294 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2295
2296         * gdbthread.h (thread_to_thread_handle): Declare.
2297         * thread.c (gdbtypes.h): Include.
2298         (thread_to_thread_handle): New function.
2299
2300         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2301         (target_thread_info_to_thread_handle): Declare.
2302         * target.c (target_thread_info_to_thread_handle): New function.
2303         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2304         * target-delegates.c: Regenerate.
2305
2306         * linux-thread-db.c (class thread_db_target): Add method
2307         thread_info_to_thread_handle.
2308         (thread_db_target::thread_info_to_thread_handle): Define.
2309         * remote.c (class remote_target): Add new method
2310         thread_info_to_thread_handle.
2311         (remote_target::thread_info_to_thread_handle): Define.
2312
2313 2019-04-08  Pedro Alves  <palves@redhat.com>
2314
2315         * common/common-exceptions.c (throw_exception): Don't create
2316         named object to throw; throw directly.
2317         (throw_it): Likewise.  Don't initialize gdb_exception::message
2318         here, with new; pass FMT and AP to the ctor instead.
2319         * common/common-exceptions.h: Include <string>.
2320         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2321         const char *, va_list)): New ctor.  Use std::make_shared.
2322         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2323         errors)): Delete.
2324         (gdb_exception_error::gdb_exception_error(enum errors, const char
2325         *, va_list)): New.
2326         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2327         Add assertion.
2328         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2329         errors)): Delete.
2330         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2331         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2332         Add assertion.
2333
2334 2019-04-08  Tom Tromey  <tom@tromey.com>
2335
2336         * valops.c (value_rtti_indirect_type): Replace throw_exception
2337         with throw.
2338         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2339         with throw.
2340         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2341         throw.
2342         * target.c (target_translate_tls_address): Replace throw_exception
2343         with throw.
2344         * stack.c (frame_apply_command_count): Replace throw_exception
2345         with throw.
2346         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2347         throw.
2348         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2349         with throw.
2350         * rs6000-tdep.c (rs6000_frame_cache)
2351         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2352         * remote.c: Replace throw_exception with throw.
2353         * record-full.c (record_full_message, record_full_wait_1)
2354         (record_full_restore): Replace throw_exception with throw.
2355         * record-btrace.c:
2356         (get_thread_current_frame_id, record_btrace_start_replaying)
2357         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2358         (cmd_record_btrace_start): Replace throw_exception with throw.
2359         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2360         throw.
2361         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2362         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2363         * linespec.c:
2364         (find_linespec_symbols): Replace throw_exception with throw.
2365         * infrun.c (displaced_step_prepare, resume): Replace
2366         throw_exception with throw.
2367         * infcmd.c (post_create_inferior): Replace throw_exception with
2368         throw.
2369         * inf-loop.c (inferior_event_handler): Replace throw_exception
2370         with throw.
2371         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2372         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2373         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2374         (get_prev_frame_always, get_frame_pc_if_available)
2375         (get_frame_address_in_block_if_available, get_frame_language):
2376         Replace throw_exception with throw.
2377         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2378         throw_exception with throw.
2379         * eval.c (fetch_subexp_value, evaluate_var_value)
2380         (evaluate_funcall, evaluate_subexp_standard): Replace
2381         throw_exception with throw.
2382         * dwarf2loc.c (call_site_find_chain)
2383         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2384         Replace throw_exception with throw.
2385         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2386         with throw.
2387         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2388         throw.
2389         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2390         * completer.c (complete_line_internal): Replace throw_exception
2391         with throw.
2392         * compile/compile-object-run.c (compile_object_run): Replace
2393         throw_exception with throw.
2394         * cli/cli-script.c (process_next_line): Replace throw_exception
2395         with throw.
2396         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2397         (btrace_enable, btrace_maint_update_pt_packets): Replace
2398         throw_exception with throw.
2399         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2400         throw_exception with throw.
2401         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2402         throw_exception with throw.
2403         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2404         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2405         * aarch64-tdep.c (aarch64_make_prologue_cache)
2406         (aarch64_make_stub_cache): Replace throw_exception with throw.
2407
2408 2019-04-08  Tom Tromey  <tom@tromey.com>
2409
2410         * common/common-exceptions.c (throw_exception): Rename from
2411         throw_exception_cxx.  Remove old copy.  Make argument const.
2412         (throw_it): Create and throw exception objects directly.
2413         * common/common-exceptions.h (throw_exception): Make argument
2414         const.
2415         (struct gdb_exception_error): Add constructor.
2416         (struct gdb_exception_quit): Add constructor.
2417
2418 2019-04-08  Tom Tromey  <tom@tromey.com>
2419
2420         * common/common-exceptions.h (exception_rethrow): Don't declare.
2421         (TRY_SJLJ): Update comment.
2422         (TRY, CATCH, END_CATCH): Remove.
2423         * common/common-exceptions.c (exception_rethrow): Remove.
2424
2425 2019-04-08  Tom Tromey  <tom@tromey.com>
2426
2427         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2428         Remove.
2429         (gdb_exception_error): Rename from
2430         gdb_exception_RETURN_MASK_ERROR.
2431         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2432         (gdb_quit_bad_alloc): Update.
2433         * aarch64-tdep.c: Update.
2434         * ada-lang.c: Update.
2435         * ada-typeprint.c: Update.
2436         * ada-valprint.c: Update.
2437         * amd64-tdep.c: Update.
2438         * arch-utils.c: Update.
2439         * break-catch-throw.c: Update.
2440         * breakpoint.c: Update.
2441         * btrace.c: Update.
2442         * c-varobj.c: Update.
2443         * cli/cli-cmds.c: Update.
2444         * cli/cli-interp.c: Update.
2445         * cli/cli-script.c: Update.
2446         * common/common-exceptions.c: Update.
2447         * common/new-op.c: Update.
2448         * common/selftest.c: Update.
2449         * compile/compile-c-symbols.c: Update.
2450         * compile/compile-cplus-symbols.c: Update.
2451         * compile/compile-object-load.c: Update.
2452         * compile/compile-object-run.c: Update.
2453         * completer.c: Update.
2454         * corelow.c: Update.
2455         * cp-abi.c: Update.
2456         * cp-support.c: Update.
2457         * cp-valprint.c: Update.
2458         * darwin-nat.c: Update.
2459         * disasm-selftests.c: Update.
2460         * dtrace-probe.c: Update.
2461         * dwarf-index-cache.c: Update.
2462         * dwarf-index-write.c: Update.
2463         * dwarf2-frame-tailcall.c: Update.
2464         * dwarf2-frame.c: Update.
2465         * dwarf2loc.c: Update.
2466         * dwarf2read.c: Update.
2467         * eval.c: Update.
2468         * event-loop.c: Update.
2469         * event-top.c: Update.
2470         * exec.c: Update.
2471         * f-valprint.c: Update.
2472         * fbsd-tdep.c: Update.
2473         * frame-unwind.c: Update.
2474         * frame.c: Update.
2475         * gdbtypes.c: Update.
2476         * gnu-v3-abi.c: Update.
2477         * guile/guile-internal.h: Update.
2478         * guile/scm-block.c: Update.
2479         * guile/scm-breakpoint.c: Update.
2480         * guile/scm-cmd.c: Update.
2481         * guile/scm-disasm.c: Update.
2482         * guile/scm-frame.c: Update.
2483         * guile/scm-lazy-string.c: Update.
2484         * guile/scm-math.c: Update.
2485         * guile/scm-param.c: Update.
2486         * guile/scm-ports.c: Update.
2487         * guile/scm-pretty-print.c: Update.
2488         * guile/scm-symbol.c: Update.
2489         * guile/scm-symtab.c: Update.
2490         * guile/scm-type.c: Update.
2491         * guile/scm-value.c: Update.
2492         * i386-linux-tdep.c: Update.
2493         * i386-tdep.c: Update.
2494         * inf-loop.c: Update.
2495         * infcall.c: Update.
2496         * infcmd.c: Update.
2497         * infrun.c: Update.
2498         * jit.c: Update.
2499         * language.c: Update.
2500         * linespec.c: Update.
2501         * linux-fork.c: Update.
2502         * linux-nat.c: Update.
2503         * linux-tdep.c: Update.
2504         * linux-thread-db.c: Update.
2505         * main.c: Update.
2506         * mi/mi-cmd-break.c: Update.
2507         * mi/mi-cmd-stack.c: Update.
2508         * mi/mi-interp.c: Update.
2509         * mi/mi-main.c: Update.
2510         * objc-lang.c: Update.
2511         * p-valprint.c: Update.
2512         * parse.c: Update.
2513         * ppc-linux-tdep.c: Update.
2514         * printcmd.c: Update.
2515         * python/py-arch.c: Update.
2516         * python/py-breakpoint.c: Update.
2517         * python/py-cmd.c: Update.
2518         * python/py-finishbreakpoint.c: Update.
2519         * python/py-frame.c: Update.
2520         * python/py-framefilter.c: Update.
2521         * python/py-gdb-readline.c: Update.
2522         * python/py-inferior.c: Update.
2523         * python/py-infthread.c: Update.
2524         * python/py-lazy-string.c: Update.
2525         * python/py-linetable.c: Update.
2526         * python/py-objfile.c: Update.
2527         * python/py-param.c: Update.
2528         * python/py-prettyprint.c: Update.
2529         * python/py-progspace.c: Update.
2530         * python/py-record-btrace.c: Update.
2531         * python/py-record.c: Update.
2532         * python/py-symbol.c: Update.
2533         * python/py-type.c: Update.
2534         * python/py-unwind.c: Update.
2535         * python/py-utils.c: Update.
2536         * python/py-value.c: Update.
2537         * python/python.c: Update.
2538         * record-btrace.c: Update.
2539         * record-full.c: Update.
2540         * remote-fileio.c: Update.
2541         * remote.c: Update.
2542         * riscv-tdep.c: Update.
2543         * rs6000-aix-tdep.c: Update.
2544         * rs6000-tdep.c: Update.
2545         * rust-exp.y: Update.
2546         * rust-lang.c: Update.
2547         * s390-tdep.c: Update.
2548         * selftest-arch.c: Update.
2549         * solib-dsbt.c: Update.
2550         * solib-frv.c: Update.
2551         * solib-spu.c: Update.
2552         * solib-svr4.c: Update.
2553         * solib.c: Update.
2554         * sparc64-linux-tdep.c: Update.
2555         * stack.c: Update.
2556         * symfile-mem.c: Update.
2557         * symmisc.c: Update.
2558         * target.c: Update.
2559         * thread.c: Update.
2560         * top.c: Update.
2561         * tracefile-tfile.c: Update.
2562         * tui/tui.c: Update.
2563         * typeprint.c: Update.
2564         * unittests/cli-utils-selftests.c: Update.
2565         * unittests/parse-connection-spec-selftests.c: Update.
2566         * valops.c: Update.
2567         * valprint.c: Update.
2568         * value.c: Update.
2569         * varobj.c: Update.
2570         * windows-nat.c: Update.
2571         * x86-linux-nat.c: Update.
2572         * xml-support.c: Update.
2573
2574 2019-04-08  Tom Tromey  <tom@tromey.com>
2575
2576         * xml-support.c: Use C++ exception handling.
2577         * x86-linux-nat.c: Use C++ exception handling.
2578         * windows-nat.c: Use C++ exception handling.
2579         * varobj.c: Use C++ exception handling.
2580         * value.c: Use C++ exception handling.
2581         * valprint.c: Use C++ exception handling.
2582         * valops.c: Use C++ exception handling.
2583         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2584         handling.
2585         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2586         * typeprint.c: Use C++ exception handling.
2587         * tui/tui.c: Use C++ exception handling.
2588         * tracefile-tfile.c: Use C++ exception handling.
2589         * top.c: Use C++ exception handling.
2590         * thread.c: Use C++ exception handling.
2591         * target.c: Use C++ exception handling.
2592         * symmisc.c: Use C++ exception handling.
2593         * symfile-mem.c: Use C++ exception handling.
2594         * stack.c: Use C++ exception handling.
2595         * sparc64-linux-tdep.c: Use C++ exception handling.
2596         * solib.c: Use C++ exception handling.
2597         * solib-svr4.c: Use C++ exception handling.
2598         * solib-spu.c: Use C++ exception handling.
2599         * solib-frv.c: Use C++ exception handling.
2600         * solib-dsbt.c: Use C++ exception handling.
2601         * selftest-arch.c: Use C++ exception handling.
2602         * s390-tdep.c: Use C++ exception handling.
2603         * rust-lang.c: Use C++ exception handling.
2604         * rust-exp.y: Use C++ exception handling.
2605         * rs6000-tdep.c: Use C++ exception handling.
2606         * rs6000-aix-tdep.c: Use C++ exception handling.
2607         * riscv-tdep.c: Use C++ exception handling.
2608         * remote.c: Use C++ exception handling.
2609         * remote-fileio.c: Use C++ exception handling.
2610         * record-full.c: Use C++ exception handling.
2611         * record-btrace.c: Use C++ exception handling.
2612         * python/python.c: Use C++ exception handling.
2613         * python/py-value.c: Use C++ exception handling.
2614         * python/py-utils.c: Use C++ exception handling.
2615         * python/py-unwind.c: Use C++ exception handling.
2616         * python/py-type.c: Use C++ exception handling.
2617         * python/py-symbol.c: Use C++ exception handling.
2618         * python/py-record.c: Use C++ exception handling.
2619         * python/py-record-btrace.c: Use C++ exception handling.
2620         * python/py-progspace.c: Use C++ exception handling.
2621         * python/py-prettyprint.c: Use C++ exception handling.
2622         * python/py-param.c: Use C++ exception handling.
2623         * python/py-objfile.c: Use C++ exception handling.
2624         * python/py-linetable.c: Use C++ exception handling.
2625         * python/py-lazy-string.c: Use C++ exception handling.
2626         * python/py-infthread.c: Use C++ exception handling.
2627         * python/py-inferior.c: Use C++ exception handling.
2628         * python/py-gdb-readline.c: Use C++ exception handling.
2629         * python/py-framefilter.c: Use C++ exception handling.
2630         * python/py-frame.c: Use C++ exception handling.
2631         * python/py-finishbreakpoint.c: Use C++ exception handling.
2632         * python/py-cmd.c: Use C++ exception handling.
2633         * python/py-breakpoint.c: Use C++ exception handling.
2634         * python/py-arch.c: Use C++ exception handling.
2635         * printcmd.c: Use C++ exception handling.
2636         * ppc-linux-tdep.c: Use C++ exception handling.
2637         * parse.c: Use C++ exception handling.
2638         * p-valprint.c: Use C++ exception handling.
2639         * objc-lang.c: Use C++ exception handling.
2640         * mi/mi-main.c: Use C++ exception handling.
2641         * mi/mi-interp.c: Use C++ exception handling.
2642         * mi/mi-cmd-stack.c: Use C++ exception handling.
2643         * mi/mi-cmd-break.c: Use C++ exception handling.
2644         * main.c: Use C++ exception handling.
2645         * linux-thread-db.c: Use C++ exception handling.
2646         * linux-tdep.c: Use C++ exception handling.
2647         * linux-nat.c: Use C++ exception handling.
2648         * linux-fork.c: Use C++ exception handling.
2649         * linespec.c: Use C++ exception handling.
2650         * language.c: Use C++ exception handling.
2651         * jit.c: Use C++ exception handling.
2652         * infrun.c: Use C++ exception handling.
2653         * infcmd.c: Use C++ exception handling.
2654         * infcall.c: Use C++ exception handling.
2655         * inf-loop.c: Use C++ exception handling.
2656         * i386-tdep.c: Use C++ exception handling.
2657         * i386-linux-tdep.c: Use C++ exception handling.
2658         * guile/scm-value.c: Use C++ exception handling.
2659         * guile/scm-type.c: Use C++ exception handling.
2660         * guile/scm-symtab.c: Use C++ exception handling.
2661         * guile/scm-symbol.c: Use C++ exception handling.
2662         * guile/scm-pretty-print.c: Use C++ exception handling.
2663         * guile/scm-ports.c: Use C++ exception handling.
2664         * guile/scm-param.c: Use C++ exception handling.
2665         * guile/scm-math.c: Use C++ exception handling.
2666         * guile/scm-lazy-string.c: Use C++ exception handling.
2667         * guile/scm-frame.c: Use C++ exception handling.
2668         * guile/scm-disasm.c: Use C++ exception handling.
2669         * guile/scm-cmd.c: Use C++ exception handling.
2670         * guile/scm-breakpoint.c: Use C++ exception handling.
2671         * guile/scm-block.c: Use C++ exception handling.
2672         * guile/guile-internal.h: Use C++ exception handling.
2673         * gnu-v3-abi.c: Use C++ exception handling.
2674         * gdbtypes.c: Use C++ exception handling.
2675         * frame.c: Use C++ exception handling.
2676         * frame-unwind.c: Use C++ exception handling.
2677         * fbsd-tdep.c: Use C++ exception handling.
2678         * f-valprint.c: Use C++ exception handling.
2679         * exec.c: Use C++ exception handling.
2680         * event-top.c: Use C++ exception handling.
2681         * event-loop.c: Use C++ exception handling.
2682         * eval.c: Use C++ exception handling.
2683         * dwarf2read.c: Use C++ exception handling.
2684         * dwarf2loc.c: Use C++ exception handling.
2685         * dwarf2-frame.c: Use C++ exception handling.
2686         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2687         * dwarf-index-write.c: Use C++ exception handling.
2688         * dwarf-index-cache.c: Use C++ exception handling.
2689         * dtrace-probe.c: Use C++ exception handling.
2690         * disasm-selftests.c: Use C++ exception handling.
2691         * darwin-nat.c: Use C++ exception handling.
2692         * cp-valprint.c: Use C++ exception handling.
2693         * cp-support.c: Use C++ exception handling.
2694         * cp-abi.c: Use C++ exception handling.
2695         * corelow.c: Use C++ exception handling.
2696         * completer.c: Use C++ exception handling.
2697         * compile/compile-object-run.c: Use C++ exception handling.
2698         * compile/compile-object-load.c: Use C++ exception handling.
2699         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2700         * compile/compile-c-symbols.c: Use C++ exception handling.
2701         * common/selftest.c: Use C++ exception handling.
2702         * common/new-op.c: Use C++ exception handling.
2703         * cli/cli-script.c: Use C++ exception handling.
2704         * cli/cli-interp.c: Use C++ exception handling.
2705         * cli/cli-cmds.c: Use C++ exception handling.
2706         * c-varobj.c: Use C++ exception handling.
2707         * btrace.c: Use C++ exception handling.
2708         * breakpoint.c: Use C++ exception handling.
2709         * break-catch-throw.c: Use C++ exception handling.
2710         * arch-utils.c: Use C++ exception handling.
2711         * amd64-tdep.c: Use C++ exception handling.
2712         * ada-valprint.c: Use C++ exception handling.
2713         * ada-typeprint.c: Use C++ exception handling.
2714         * ada-lang.c: Use C++ exception handling.
2715         * aarch64-tdep.c: Use C++ exception handling.
2716
2717 2019-04-08  Tom Tromey  <tom@tromey.com>
2718
2719         * xml-support.c (gdb_xml_parser::parse): Update.
2720         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2721         * value.c (show_convenience): Update.
2722         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2723         (test_parse_flags_qcs): Update.
2724         * thread.c (thr_try_catch_cmd): Update.
2725         * target.c (target_translate_tls_address): Update.
2726         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2727         (info_frame_command_core, frame_apply_command_count): Update.
2728         * rust-exp.y (rust_lex_exception_test): Update.
2729         * riscv-tdep.c (riscv_print_one_register_info): Update.
2730         * remote.c (remote_target::enable_btrace): Update.
2731         * record-btrace.c (record_btrace_enable_warn): Update.
2732         * python/py-utils.c (gdbpy_convert_exception): Update.
2733         * printcmd.c (do_one_display, print_variable_and_value): Update.
2734         * mi/mi-main.c (mi_print_exception): Update.
2735         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2736         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2737         * linux-nat.c (linux_nat_target::attach): Update.
2738         * linux-fork.c (class scoped_switch_fork_info): Update.
2739         * infrun.c (displaced_step_prepare): Update.
2740         * infcall.c (call_function_by_hand_dummy): Update.
2741         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2742         * gnu-v3-abi.c (print_one_vtable): Update.
2743         * frame.c (get_prev_frame_always): Update.
2744         * f-valprint.c (info_common_command_for_block): Update.
2745         * exec.c (try_open_exec_file): Update.
2746         * exceptions.c (print_exception, exception_print)
2747         (exception_fprintf, exception_print_same): Update.
2748         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2749         * dwarf-index-cache.c (index_cache::store)
2750         (index_cache::lookup_gdb_index): Update.
2751         * darwin-nat.c (maybe_cache_shell): Update.
2752         * cp-valprint.c (cp_print_value_fields): Update.
2753         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2754         (gcc_cplus_symbol_address): Update.
2755         * compile/compile-c-symbols.c (gcc_convert_symbol)
2756         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2757         * common/selftest.c: Update.
2758         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2759         a std::string.
2760         (exception_try_scope_entry, exception_try_scope_exit): Don't
2761         declare.
2762         (struct exception_try_scope): Remove.
2763         (TRY): Don't use exception_try_scope.
2764         (struct gdb_exception): Add constructor, operator=.
2765         <what>: New method.
2766         (struct gdb_exception_RETURN_MASK_ALL)
2767         (struct gdb_exception_RETURN_MASK_ERROR)
2768         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2769         (struct gdb_quit_bad_alloc): Update.
2770         * common/common-exceptions.c (exception_none): Change
2771         initializer.
2772         (struct catcher) <state, exception>: Initialize inline.
2773         <prev>: Remove member.
2774         (current_catcher): Remove.
2775         (catchers): New global.
2776         (exceptions_state_mc_init): Simplify.
2777         (catcher_pop): Remove.
2778         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2779         (try_scope_depth, exception_try_scope_entry)
2780         (exception_try_scope_exit): Remove.
2781         (throw_exception_sjlj): Update.
2782         (exception_messages, exception_messages_size): Remove.
2783         (throw_it): Simplify.
2784         (gdb_exception_sliced_copy): Remove.
2785         (throw_exception_cxx): Update.
2786         * cli/cli-script.c (script_from_file): Update.
2787         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2788         Update.
2789         * ada-valprint.c (ada_val_print): Update.
2790         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2791         (create_excep_cond_exprs): Update.
2792
2793 2019-04-08  Tom Tromey  <tom@tromey.com>
2794
2795         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2796         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2797         (TRY, CATCH, END_CATCH): Remove some definitions.
2798         * common/common-exceptions.c: Don't use GDB_XCPT.
2799         (catcher_list_size): Remove.
2800         (throw_exception, throw_it): Simplify.
2801
2802 2019-04-05  Tom Tromey  <tom@tromey.com>
2803
2804         Revert the header-sorting patch.
2805         * ft32-tdep.c: Revert.
2806         * frv-tdep.c: Revert.
2807         * frv-linux-tdep.c: Revert.
2808         * frame.c: Revert.
2809         * frame-unwind.c: Revert.
2810         * frame-base.c: Revert.
2811         * fork-child.c: Revert.
2812         * findvar.c: Revert.
2813         * findcmd.c: Revert.
2814         * filesystem.c: Revert.
2815         * filename-seen-cache.h: Revert.
2816         * filename-seen-cache.c: Revert.
2817         * fbsd-tdep.c: Revert.
2818         * fbsd-nat.h: Revert.
2819         * fbsd-nat.c: Revert.
2820         * f-valprint.c: Revert.
2821         * f-typeprint.c: Revert.
2822         * f-lang.c: Revert.
2823         * extension.h: Revert.
2824         * extension.c: Revert.
2825         * extension-priv.h: Revert.
2826         * expprint.c: Revert.
2827         * exec.h: Revert.
2828         * exec.c: Revert.
2829         * exceptions.c: Revert.
2830         * event-top.c: Revert.
2831         * event-loop.c: Revert.
2832         * eval.c: Revert.
2833         * elfread.c: Revert.
2834         * dwarf2read.h: Revert.
2835         * dwarf2read.c: Revert.
2836         * dwarf2loc.c: Revert.
2837         * dwarf2expr.h: Revert.
2838         * dwarf2expr.c: Revert.
2839         * dwarf2-frame.c: Revert.
2840         * dwarf2-frame-tailcall.c: Revert.
2841         * dwarf-index-write.h: Revert.
2842         * dwarf-index-write.c: Revert.
2843         * dwarf-index-common.c: Revert.
2844         * dwarf-index-cache.h: Revert.
2845         * dwarf-index-cache.c: Revert.
2846         * dummy-frame.c: Revert.
2847         * dtrace-probe.c: Revert.
2848         * disasm.h: Revert.
2849         * disasm.c: Revert.
2850         * disasm-selftests.c: Revert.
2851         * dictionary.c: Revert.
2852         * dicos-tdep.c: Revert.
2853         * demangle.c: Revert.
2854         * dcache.h: Revert.
2855         * dcache.c: Revert.
2856         * darwin-nat.h: Revert.
2857         * darwin-nat.c: Revert.
2858         * darwin-nat-info.c: Revert.
2859         * d-valprint.c: Revert.
2860         * d-namespace.c: Revert.
2861         * d-lang.c: Revert.
2862         * ctf.c: Revert.
2863         * csky-tdep.c: Revert.
2864         * csky-linux-tdep.c: Revert.
2865         * cris-tdep.c: Revert.
2866         * cris-linux-tdep.c: Revert.
2867         * cp-valprint.c: Revert.
2868         * cp-support.c: Revert.
2869         * cp-namespace.c: Revert.
2870         * cp-abi.c: Revert.
2871         * corelow.c: Revert.
2872         * corefile.c: Revert.
2873         * continuations.c: Revert.
2874         * completer.h: Revert.
2875         * completer.c: Revert.
2876         * complaints.c: Revert.
2877         * coffread.c: Revert.
2878         * coff-pe-read.c: Revert.
2879         * cli-out.h: Revert.
2880         * cli-out.c: Revert.
2881         * charset.c: Revert.
2882         * c-varobj.c: Revert.
2883         * c-valprint.c: Revert.
2884         * c-typeprint.c: Revert.
2885         * c-lang.c: Revert.
2886         * buildsym.c: Revert.
2887         * buildsym-legacy.c: Revert.
2888         * build-id.h: Revert.
2889         * build-id.c: Revert.
2890         * btrace.c: Revert.
2891         * bsd-uthread.c: Revert.
2892         * breakpoint.h: Revert.
2893         * breakpoint.c: Revert.
2894         * break-catch-throw.c: Revert.
2895         * break-catch-syscall.c: Revert.
2896         * break-catch-sig.c: Revert.
2897         * blockframe.c: Revert.
2898         * block.c: Revert.
2899         * bfin-tdep.c: Revert.
2900         * bfin-linux-tdep.c: Revert.
2901         * bfd-target.c: Revert.
2902         * bcache.c: Revert.
2903         * ax-general.c: Revert.
2904         * ax-gdb.h: Revert.
2905         * ax-gdb.c: Revert.
2906         * avr-tdep.c: Revert.
2907         * auxv.c: Revert.
2908         * auto-load.c: Revert.
2909         * arm-wince-tdep.c: Revert.
2910         * arm-tdep.c: Revert.
2911         * arm-symbian-tdep.c: Revert.
2912         * arm-pikeos-tdep.c: Revert.
2913         * arm-obsd-tdep.c: Revert.
2914         * arm-nbsd-tdep.c: Revert.
2915         * arm-nbsd-nat.c: Revert.
2916         * arm-linux-tdep.c: Revert.
2917         * arm-linux-nat.c: Revert.
2918         * arm-fbsd-tdep.c: Revert.
2919         * arm-fbsd-nat.c: Revert.
2920         * arm-bsd-tdep.c: Revert.
2921         * arch-utils.c: Revert.
2922         * arc-tdep.c: Revert.
2923         * arc-newlib-tdep.c: Revert.
2924         * annotate.h: Revert.
2925         * annotate.c: Revert.
2926         * amd64-windows-tdep.c: Revert.
2927         * amd64-windows-nat.c: Revert.
2928         * amd64-tdep.c: Revert.
2929         * amd64-sol2-tdep.c: Revert.
2930         * amd64-obsd-tdep.c: Revert.
2931         * amd64-obsd-nat.c: Revert.
2932         * amd64-nbsd-tdep.c: Revert.
2933         * amd64-nbsd-nat.c: Revert.
2934         * amd64-nat.c: Revert.
2935         * amd64-linux-tdep.c: Revert.
2936         * amd64-linux-nat.c: Revert.
2937         * amd64-fbsd-tdep.c: Revert.
2938         * amd64-fbsd-nat.c: Revert.
2939         * amd64-dicos-tdep.c: Revert.
2940         * amd64-darwin-tdep.c: Revert.
2941         * amd64-bsd-nat.c: Revert.
2942         * alpha-tdep.c: Revert.
2943         * alpha-obsd-tdep.c: Revert.
2944         * alpha-nbsd-tdep.c: Revert.
2945         * alpha-mdebug-tdep.c: Revert.
2946         * alpha-linux-tdep.c: Revert.
2947         * alpha-linux-nat.c: Revert.
2948         * alpha-bsd-tdep.c: Revert.
2949         * alpha-bsd-nat.c: Revert.
2950         * aix-thread.c: Revert.
2951         * agent.c: Revert.
2952         * addrmap.c: Revert.
2953         * ada-varobj.c: Revert.
2954         * ada-valprint.c: Revert.
2955         * ada-typeprint.c: Revert.
2956         * ada-tasks.c: Revert.
2957         * ada-lang.c: Revert.
2958         * aarch64-tdep.c: Revert.
2959         * aarch64-ravenscar-thread.c: Revert.
2960         * aarch64-newlib-tdep.c: Revert.
2961         * aarch64-linux-tdep.c: Revert.
2962         * aarch64-linux-nat.c: Revert.
2963         * aarch64-fbsd-tdep.c: Revert.
2964         * aarch64-fbsd-nat.c: Revert.
2965         * aarch32-linux-nat.c: Revert.
2966
2967 2019-04-05  Tom Tromey  <tom@tromey.com>
2968
2969         * ft32-tdep.c: Sort headers.
2970         * frv-tdep.c: Sort headers.
2971         * frv-linux-tdep.c: Sort headers.
2972         * frame.c: Sort headers.
2973         * frame-unwind.c: Sort headers.
2974         * frame-base.c: Sort headers.
2975         * fork-child.c: Sort headers.
2976         * findvar.c: Sort headers.
2977         * findcmd.c: Sort headers.
2978         * filesystem.c: Sort headers.
2979         * filename-seen-cache.h: Sort headers.
2980         * filename-seen-cache.c: Sort headers.
2981         * fbsd-tdep.c: Sort headers.
2982         * fbsd-nat.h: Sort headers.
2983         * fbsd-nat.c: Sort headers.
2984         * f-valprint.c: Sort headers.
2985         * f-typeprint.c: Sort headers.
2986         * f-lang.c: Sort headers.
2987         * extension.h: Sort headers.
2988         * extension.c: Sort headers.
2989         * extension-priv.h: Sort headers.
2990         * expprint.c: Sort headers.
2991         * exec.h: Sort headers.
2992         * exec.c: Sort headers.
2993         * exceptions.c: Sort headers.
2994         * event-top.c: Sort headers.
2995         * event-loop.c: Sort headers.
2996         * eval.c: Sort headers.
2997         * elfread.c: Sort headers.
2998         * dwarf2read.h: Sort headers.
2999         * dwarf2read.c: Sort headers.
3000         * dwarf2loc.c: Sort headers.
3001         * dwarf2expr.h: Sort headers.
3002         * dwarf2expr.c: Sort headers.
3003         * dwarf2-frame.c: Sort headers.
3004         * dwarf2-frame-tailcall.c: Sort headers.
3005         * dwarf-index-write.h: Sort headers.
3006         * dwarf-index-write.c: Sort headers.
3007         * dwarf-index-common.c: Sort headers.
3008         * dwarf-index-cache.h: Sort headers.
3009         * dwarf-index-cache.c: Sort headers.
3010         * dummy-frame.c: Sort headers.
3011         * dtrace-probe.c: Sort headers.
3012         * disasm.h: Sort headers.
3013         * disasm.c: Sort headers.
3014         * disasm-selftests.c: Sort headers.
3015         * dictionary.c: Sort headers.
3016         * dicos-tdep.c: Sort headers.
3017         * demangle.c: Sort headers.
3018         * dcache.h: Sort headers.
3019         * dcache.c: Sort headers.
3020         * darwin-nat.h: Sort headers.
3021         * darwin-nat.c: Sort headers.
3022         * darwin-nat-info.c: Sort headers.
3023         * d-valprint.c: Sort headers.
3024         * d-namespace.c: Sort headers.
3025         * d-lang.c: Sort headers.
3026         * ctf.c: Sort headers.
3027         * csky-tdep.c: Sort headers.
3028         * csky-linux-tdep.c: Sort headers.
3029         * cris-tdep.c: Sort headers.
3030         * cris-linux-tdep.c: Sort headers.
3031         * cp-valprint.c: Sort headers.
3032         * cp-support.c: Sort headers.
3033         * cp-namespace.c: Sort headers.
3034         * cp-abi.c: Sort headers.
3035         * corelow.c: Sort headers.
3036         * corefile.c: Sort headers.
3037         * continuations.c: Sort headers.
3038         * completer.h: Sort headers.
3039         * completer.c: Sort headers.
3040         * complaints.c: Sort headers.
3041         * coffread.c: Sort headers.
3042         * coff-pe-read.c: Sort headers.
3043         * cli-out.h: Sort headers.
3044         * cli-out.c: Sort headers.
3045         * charset.c: Sort headers.
3046         * c-varobj.c: Sort headers.
3047         * c-valprint.c: Sort headers.
3048         * c-typeprint.c: Sort headers.
3049         * c-lang.c: Sort headers.
3050         * buildsym.c: Sort headers.
3051         * buildsym-legacy.c: Sort headers.
3052         * build-id.h: Sort headers.
3053         * build-id.c: Sort headers.
3054         * btrace.c: Sort headers.
3055         * bsd-uthread.c: Sort headers.
3056         * breakpoint.h: Sort headers.
3057         * breakpoint.c: Sort headers.
3058         * break-catch-throw.c: Sort headers.
3059         * break-catch-syscall.c: Sort headers.
3060         * break-catch-sig.c: Sort headers.
3061         * blockframe.c: Sort headers.
3062         * block.c: Sort headers.
3063         * bfin-tdep.c: Sort headers.
3064         * bfin-linux-tdep.c: Sort headers.
3065         * bfd-target.c: Sort headers.
3066         * bcache.c: Sort headers.
3067         * ax-general.c: Sort headers.
3068         * ax-gdb.h: Sort headers.
3069         * ax-gdb.c: Sort headers.
3070         * avr-tdep.c: Sort headers.
3071         * auxv.c: Sort headers.
3072         * auto-load.c: Sort headers.
3073         * arm-wince-tdep.c: Sort headers.
3074         * arm-tdep.c: Sort headers.
3075         * arm-symbian-tdep.c: Sort headers.
3076         * arm-pikeos-tdep.c: Sort headers.
3077         * arm-obsd-tdep.c: Sort headers.
3078         * arm-nbsd-tdep.c: Sort headers.
3079         * arm-nbsd-nat.c: Sort headers.
3080         * arm-linux-tdep.c: Sort headers.
3081         * arm-linux-nat.c: Sort headers.
3082         * arm-fbsd-tdep.c: Sort headers.
3083         * arm-fbsd-nat.c: Sort headers.
3084         * arm-bsd-tdep.c: Sort headers.
3085         * arch-utils.c: Sort headers.
3086         * arc-tdep.c: Sort headers.
3087         * arc-newlib-tdep.c: Sort headers.
3088         * annotate.h: Sort headers.
3089         * annotate.c: Sort headers.
3090         * amd64-windows-tdep.c: Sort headers.
3091         * amd64-windows-nat.c: Sort headers.
3092         * amd64-tdep.c: Sort headers.
3093         * amd64-sol2-tdep.c: Sort headers.
3094         * amd64-obsd-tdep.c: Sort headers.
3095         * amd64-obsd-nat.c: Sort headers.
3096         * amd64-nbsd-tdep.c: Sort headers.
3097         * amd64-nbsd-nat.c: Sort headers.
3098         * amd64-nat.c: Sort headers.
3099         * amd64-linux-tdep.c: Sort headers.
3100         * amd64-linux-nat.c: Sort headers.
3101         * amd64-fbsd-tdep.c: Sort headers.
3102         * amd64-fbsd-nat.c: Sort headers.
3103         * amd64-dicos-tdep.c: Sort headers.
3104         * amd64-darwin-tdep.c: Sort headers.
3105         * amd64-bsd-nat.c: Sort headers.
3106         * alpha-tdep.c: Sort headers.
3107         * alpha-obsd-tdep.c: Sort headers.
3108         * alpha-nbsd-tdep.c: Sort headers.
3109         * alpha-mdebug-tdep.c: Sort headers.
3110         * alpha-linux-tdep.c: Sort headers.
3111         * alpha-linux-nat.c: Sort headers.
3112         * alpha-bsd-tdep.c: Sort headers.
3113         * alpha-bsd-nat.c: Sort headers.
3114         * aix-thread.c: Sort headers.
3115         * agent.c: Sort headers.
3116         * addrmap.c: Sort headers.
3117         * ada-varobj.c: Sort headers.
3118         * ada-valprint.c: Sort headers.
3119         * ada-typeprint.c: Sort headers.
3120         * ada-tasks.c: Sort headers.
3121         * ada-lang.c: Sort headers.
3122         * aarch64-tdep.c: Sort headers.
3123         * aarch64-ravenscar-thread.c: Sort headers.
3124         * aarch64-newlib-tdep.c: Sort headers.
3125         * aarch64-linux-tdep.c: Sort headers.
3126         * aarch64-linux-nat.c: Sort headers.
3127         * aarch64-fbsd-tdep.c: Sort headers.
3128         * aarch64-fbsd-nat.c: Sort headers.
3129         * aarch32-linux-nat.c: Sort headers.
3130
3131 2019-04-04  Tom Tromey  <tom@tromey.com>
3132
3133         * varobj.c (varobj_create): Update.
3134         * rust-exp.y (struct rust_parser) <update_innermost_block,
3135         lookup_symbol>: New methods.
3136         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3137         Rename.
3138         (rust_parser::rust_lookup_type)
3139         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3140         * printcmd.c (display_command, do_one_display): Update.
3141         * parser-defs.h (struct parser_state) <parser_state>: Add
3142         "tracker" parameter.
3143         (block_tracker): New member.
3144         (class innermost_block_tracker) <innermost_block_tracker>: Add
3145         "types" parameter.
3146         <reset>: Remove method.
3147         (innermost_block): Don't declare.
3148         (null_post_parser): Update.
3149         * parse.c (innermost_block): Remove global.
3150         (write_dollar_variable): Update.
3151         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3152         Remove "tracker_types" parameter.
3153         (parse_expression): Add "tracker" parameter.
3154         (parse_expression_for_completion): Update.
3155         (null_post_parser): Add "tracker" parameter.
3156         * p-exp.y: Update rules.
3157         * m2-exp.y: Update rules.
3158         * language.h (struct language_defn) <la_post_parser>: Add
3159         "tracker" parameter.
3160         * go-exp.y: Update rules.
3161         * f-exp.y: Update rules.
3162         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3163         parameter.
3164         * d-exp.y: Update rules.
3165         * c-exp.y: Update rules.
3166         * breakpoint.c (set_breakpoint_condition): Create an
3167         innermost_block_tracker.
3168         (watch_command_1): Likewise.
3169         * ada-lang.c (resolve): Add "tracker" parameter.
3170         (resolve_subexp): Likewise.
3171         * ada-exp.y (write_var_from_sym): Update.
3172
3173 2019-04-04  Tom Tromey  <tom@tromey.com>
3174
3175         * type-stack.h: New file.
3176         * type-stack.c: New file.
3177         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3178         type-stack.h.
3179         (insert_into_type_stack, insert_type, push_type, push_type_int)
3180         (insert_type_address_space, pop_type, pop_type_int)
3181         (pop_typelist, pop_type_stack, append_type_stack)
3182         (push_type_stack, get_type_stack, push_typelist)
3183         (follow_type_instance_flags, follow_types): Don't declare.
3184         * parse.c (type_stack): Remove global.
3185         (parse_exp_in_context): Update.
3186         (insert_into_type_stack, insert_type, push_type, push_type_int)
3187         (insert_type_address_space, pop_type, pop_type_int)
3188         (pop_typelist, pop_type_stack, append_type_stack)
3189         (push_type_stack, get_type_stack, push_typelist)
3190         (follow_type_instance_flags, follow_types): Remove (moved to
3191         type-stack.c).
3192         * f-exp.y (type_stack): New global.
3193         Update rules.
3194         (push_kind_type, f_parse): Update.
3195         * d-exp.y (type_stack): New global.
3196         Update rules.
3197         (d_parse): Update.
3198         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3199         Update rules.
3200         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3201         (HFILES_NO_SRCDIR): Add type-stack.h.
3202
3203 2019-04-04  Tom Tromey  <tom@tromey.com>
3204
3205         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3206         (rust_parser::convert_ast_to_expression, rust_parse)
3207         (rust_lex_test_completion, rust_lex_tests): Update.
3208         * parser-defs.h (struct expr_completion_state): New.
3209         (struct parser_state) <parser_state>: Add completion parameter.
3210         <mark_struct_expression, mark_completion_tag>: New methods.
3211         <parse_completion, m_completion_state>: New members.
3212         (prefixify_expression, null_post_parser): Update.
3213         (mark_struct_expression, mark_completion_tag): Don't declare.
3214         * parse.c (parse_completion, expout_last_struct)
3215         (expout_tag_completion_type, expout_completion_name): Remove
3216         globals.
3217         (parser_state::mark_struct_expression)
3218         (parser_state::mark_completion_tag): Now methods.
3219         (prefixify_expression): Add last_struct parameter.
3220         (prefixify_subexp): Likewise.
3221         (parse_exp_1): Update.
3222         (parse_exp_in_context): Add cstate parameter.  Update.
3223         (parse_expression_for_completion): Create an
3224         expr_completion_state.
3225         (null_post_parser): Add "completion" parameter.
3226         * p-exp.y: Update rules.
3227         (yylex): Update.
3228         * language.h (struct language_defn) <la_post_parser>: Add
3229         "completing" parameter.
3230         * go-exp.y: Update rules.
3231         (lex_one_token): Update.
3232         * expression.h (parse_completion): Don't declare.
3233         * d-exp.y: Update rules.
3234         (lex_one_token): Update rules.
3235         * c-exp.y: Update rules.
3236         (lex_one_token): Update.
3237         * ada-lang.c (resolve): Add "parse_completion" parameter.
3238         (resolve_subexp): Likewise.
3239         (ada_resolve_function): Likewise.
3240
3241 2019-04-04  Tom Tromey  <tom@tromey.com>
3242
3243         * parser-defs.h (struct parser_state) <start_arglist,
3244         end_arglist>: New methods.
3245         <arglist_len, m_funcall_chain>: New members.
3246         (arglist_len, start_arglist, end_arglist): Don't declare.
3247         * parse.c (arglist_len, funcall_chain): Remove global.
3248         (start_arglist, end_arglist): Remove functions.
3249         (parse_exp_in_context): Update.
3250         * p-exp.y: Update rules.
3251         * m2-exp.y: Update rules.
3252         * go-exp.y: Update rules.
3253         * f-exp.y: Update rules.
3254         * d-exp.y: Update rules.
3255         * c-exp.y: Update rules.
3256
3257 2019-04-04  Tom Tromey  <tom@tromey.com>
3258
3259         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3260         lex_operator, push_back>: New methods.
3261         Update all rules.
3262         (rust_parser::lex_hex, lex_escape): Rename and update.
3263         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3264         (rust_parser::lex_operator): Rename and update.
3265         (rust_parser::lex_number, rustyylex, rustyyerror)
3266         (rust_lex_test_init, rust_lex_test_sequence)
3267         (rust_lex_test_push_back, rust_lex_tests): Update.
3268         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3269         parameter.
3270         <lexptr, prev_lexptr>: New members.
3271         (lexptr, prev_lexptr): Don't declare.
3272         * parse.c (lexptr, prev_lexptr): Remove globals.
3273         (parse_exp_in_context): Update.
3274         * p-exp.y (yylex, yyerror): Update.
3275         * m2-exp.y (parse_number, yylex, yyerror): Update.
3276         * go-exp.y (lex_one_token, yyerror): Update.
3277         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3278         * d-exp.y (lex_one_token, yyerror): Update.
3279         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3280         (lex_one_token, yyerror): Update.
3281         * ada-lex.l (YY_INPUT): Update.
3282         (rewind_to_char): Update.
3283         * ada-exp.y (yyerror): Update.
3284
3285 2019-04-04  Tom Tromey  <tom@tromey.com>
3286
3287         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3288         * parser-defs.h (struct parser_state) <parser_state>: Add new
3289         parameter.
3290         <comma_terminates>: New member.
3291         (comma_terminates): Don't declare global.
3292         * parse.c (comma_terminates): Remove global.
3293         (parse_exp_in_context): Update.
3294         * p-exp.y (yylex): Update.
3295         * m2-exp.y (yylex): Update.
3296         * go-exp.y (lex_one_token): Update.
3297         * f-exp.y (yylex): Update.
3298         * d-exp.y (lex_one_token): Update.
3299         * c-exp.y (lex_one_token): Update.
3300         * ada-lex.l: Update.
3301
3302 2019-04-04  Tom Tromey  <tom@tromey.com>
3303
3304         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3305         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3306         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3307         * parser-defs.h (paren_depth): Don't declare.
3308         * parse.c (paren_depth): Remove global.
3309         (parse_exp_in_context): Update.
3310         * p-exp.y (paren_depth): New global.
3311         (pascal_parse): Initialize it.
3312         * m2-exp.y (paren_depth): New global.
3313         (m2_parse): Initialize it.
3314         * go-exp.y (paren_depth): New global.
3315         (go_parse): Initialize it.
3316         * f-exp.y (paren_depth): New global.
3317         (f_parse): Initialize it.
3318         * d-exp.y (paren_depth): New global.
3319         (d_parse): Initialize it.
3320         * c-exp.y (paren_depth): New global.
3321         (c_parse): Initialize it.
3322         * ada-lex.l (paren_depth): New global.
3323         (lexer_init): Initialize it.
3324
3325 2019-04-04  Tom Tromey  <tom@tromey.com>
3326
3327         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3328         (rust_parser::convert_ast_to_type)
3329         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3330         * parser-defs.h (struct parser_state) <parser_state>: Add
3331         parameters.  Initialize new members.
3332         <expression_context_block, expression_context_pc>: New members.
3333         * parse.c (expression_context_block, expression_context_pc):
3334         Remove globals.
3335         (parse_exp_in_context): Update.
3336         * p-exp.y: Update all rules.
3337         (yylex): Update.
3338         * m2-exp.y: Update all rules.
3339         (yylex): Update.
3340         * go-exp.y (yylex): Update.
3341         * f-exp.y (yylex): Update.
3342         * d-exp.y: Update all rules.
3343         (yylex): Update.
3344         * c-exp.y: Update all rules.
3345         (lex_one_token, classify_name, yylex, c_parse): Update.
3346         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3347
3348 2019-04-04  Tom Tromey  <tom@tromey.com>
3349
3350         * gdbarch.h, gdbarch.c: Rebuild.
3351         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3352         * stap-probe.h:
3353         (struct stap_parse_info): Replace "parser_state" with
3354         "expr_builder".
3355         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3356         (parser_state): New class.
3357         * parse.c (expr_builder): Rename.
3358         (expr_builder::release): Rename.
3359         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3360         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3361         (write_exp_elt_longcst, write_exp_elt_floatcst)
3362         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3363         (write_exp_string_vector, write_exp_bitstring)
3364         (write_exp_msymbol, mark_struct_expression)
3365         (write_dollar_variable)
3366         (insert_type_address_space, increase_expout_size): Replace
3367         "parser_state" with "expr_builder".
3368         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3369         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3370         "parser_state" with "expr_builder".
3371
3372 2019-04-04  Tom Tromey  <tom@tromey.com>
3373
3374         * rust-exp.y: Replace "parse_language" with method call.
3375         * p-exp.y:
3376         (yylex): Replace "parse_language" with method call.
3377         * m2-exp.y:
3378         (yylex): Replace "parse_language" with method call.
3379         * go-exp.y (classify_name): Replace "parse_language" with method
3380         call.
3381         * f-exp.y (yylex): Replace "parse_language" with method call.
3382         * d-exp.y (lex_one_token): Replace "parse_language" with method
3383         call.
3384         * c-exp.y:
3385         (lex_one_token, classify_name, yylex): Replace "parse_language"
3386         with method call.
3387         * ada-exp.y (find_primitive_type, type_char)
3388         (type_system_address): Replace "parse_language" with method call.
3389
3390 2019-04-04  Tom Tromey  <tom@tromey.com>
3391
3392         * rust-exp.y: Replace "parse_gdbarch" with method call.
3393         * parse.c (write_dollar_variable, insert_type_address_space):
3394         Replace "parse_gdbarch" with method call.
3395         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3396         call.
3397         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3398         call.
3399         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3400         "parse_gdbarch" with method call.
3401         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3402         with method call.
3403         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3404         "parse_gdbarch" with method call.
3405         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3406         "parse_gdbarch" with method call.
3407         * c-exp.y (parse_type, parse_number, classify_name): Replace
3408         "parse_gdbarch" with method call.
3409         * ada-lex.l: Replace "parse_gdbarch" with method call.
3410         * ada-exp.y (parse_type, find_primitive_type, type_char)
3411         (type_system_address): Replace "parse_gdbarch" with method call.
3412
3413 2019-04-04  Tom Tromey  <tom@tromey.com>
3414
3415         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3416         * stap-probe.c (stap_parse_argument): Update.
3417         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3418         initial_size parameter.
3419         * rust-exp.y (rust_lex_tests): Update.
3420         * parse.c (parser_state): Update.
3421         (parse_exp_in_context): Update.
3422         * parser-defs.h (struct parser_state) <parser_state>: Remove
3423         "initial_size" parameter.
3424
3425 2019-04-04  Tom Tromey  <tom@tromey.com>
3426
3427         * parser-defs.h (increase_expout_size): Don't declare.
3428         * parse.c (increase_expout_size): Now static.
3429
3430 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3431
3432         * gnu-nat.c (gnu_nat_target::wait): Fix
3433         target_waitstatus_to_string call.
3434
3435 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3436
3437         * eval.c (evaluate_subexp_standard): Handle internal functions
3438         during Fortran function call handling.
3439
3440 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3441
3442         * NEWS: Mention new internal functions.
3443         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3444         (read_base_type): Use dwarf2_init_complex_target_type.
3445         * value.c (creal_internal_fn): New function.
3446         (cimag_internal_fn): New function.
3447         (_initialize_values): Register new internal functions.
3448
3449 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3450
3451         * infrun.c (stop_all_threads): If debug_infrun, always
3452         trace the wait status after wait_one, using
3453         target_waitstatus_to_string and target_pid_to_str.
3454         (handle_inferior_event): Replace various trace of
3455         wait status kind by a single trace.
3456         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3457         wait status kind image by target_waitstatus_to_string.
3458         * target/waitstatus.c (target_waitstatus_to_string): Fix
3459         obsolete comment.
3460
3461 2019-04-01  Tom Tromey  <tromey@adacore.com>
3462
3463         PR symtab/23331:
3464         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3465
3466 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3467             Pedro Alves  <palves@redhat.com>
3468
3469         * top.c (quit_force): Call 'finalize_values'.
3470         * value.c (finalize_values): New function.
3471         * value.h (finalize_values): Declare.
3472
3473 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3474
3475         * NEWS: Announce $_gdb_major and $_gdb_minor.
3476
3477         * top.c (init_gdb_version_vars): New function.
3478         (gdb_init): Call init_gdb_version_vars.
3479
3480 2019-03-29  Tom Tromey  <tromey@adacore.com>
3481
3482         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3483         help text.  Remove dead code.
3484
3485 2019-03-29  Keith Seitz  <keiths@redhat.com>
3486
3487         From Siddhesh Poyarekar:
3488         * f-lang.h (f77_get_upperbound): Return LONGEST.
3489         (f77_get_lowerbound): Likewise.
3490         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3491         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3492         print them.
3493         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3494         plongest to format print it.
3495         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3496         (f77_get_upperbound): Likewise.
3497         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3498         LOWER_BOUND to LONGEST.
3499         (f77_create_arrayprint_offset_tbl): Likewise.
3500
3501 2019-03-29  Keith Seitz  <keiths@redhat.com>
3502
3503         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3504         %s/pulongest for TYPE_LENGTH instead of %d in format
3505         strings.
3506         * ada-typerint.c (ada_print_type): Likewise.
3507         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3508         * compile/compile-c-support.c (generate_register_struct): Likewise.
3509         * gdbtypes.c (recursive_dump_type): Likewise.
3510         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3511         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3512         instead of %d in format strings.
3513         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3514         to std::min to ULONGEST.
3515         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3516         instead of %d in format strings.
3517         * tracepoint.c (info_scope_command): Likewise.
3518         * typeprint.c (print_offset_data::update)
3519         (print_offset_data::finish): Likewise.
3520         * xtensa-tdep.c (xtensa_store_return_value)
3521         (xtensa_push_dummy_call): Likewise.
3522
3523 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3524
3525         * windows-nat.c (display_selector): Fixed format specifications
3526         for 64-bit Cygwin.
3527
3528 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3529
3530         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3531
3532 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3533
3534         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3535         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3536         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3537         (nios2_linux_init_abi): Install it.
3538
3539 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3540
3541         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3542
3543 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3544
3545         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3546
3547 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3548             Tom Tromey  <tromey@adacore.com>
3549
3550         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3551
3552 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3553
3554         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3555         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3556         method to compute the bounds of range types. Also print "[evaluated]"
3557         if the bounds' values come from a dynamic evaluation.
3558
3559 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3560
3561         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3562         whitespace when pretty printing is on.
3563
3564 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3565
3566         * ppc-linux-nat.c: Add include.
3567
3568 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3569
3570         * NEWS: Mention AArch64 Pointer Authentication.
3571
3572 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3573
3574         * arm-linux-nat.c: Add include.
3575
3576 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3577
3578         * source-cache.c (source_cache::get_source_lines): Re-read
3579         fullname after calling open_source_file.
3580
3581 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3582
3583         * NEWS: Mention TLS support for FreeBSD.
3584
3585 2019-03-25  Tom Tromey  <tromey@adacore.com>
3586
3587         * minsyms.c (BUNCH_SIZE): Update comment.
3588         (~minimal_symbol_reader): Remove old comment.
3589         (compact_minimal_symbols): Update comment.
3590         (minimal_symbol_reader::install): Remove old comment.  Update
3591         other comments.
3592
3593 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3594
3595         * s390-linux-nat.c: Add include.
3596
3597 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3598
3599         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3600         Call linux_get_hwcap.
3601         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3602         Likewise.
3603         (aarch64_linux_get_hwcap): Remove function.
3604         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3605         declaration.
3606         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3607         linux_get_hwcap.
3608         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3609         * linux-tdep.c (linux_get_hwcap): Add function.
3610         (linux_get_hwcap2): Likewise.
3611         * linux-tdep.h (linux_get_hwcap): Add declaration.
3612         (linux_get_hwcap2): Likewise.
3613         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3614         (ppc_linux_get_hwcap2): Likewise.
3615         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3616         linux_get_hwcap.
3617         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3618         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3619         (ppc_linux_nat_target::read_description): Likewise.
3620         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3621         * s390-linux-nat.c: Likewise.
3622         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3623
3624 2019-03-24  Tom Tromey  <tom@tromey.com>
3625
3626         * ada-lang.c (standard_lookup): Simplify initialization.
3627         (ada_lookup_symbol_nonlocal): Simplify return.
3628         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3629         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3630         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3631         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3632         initialization.
3633         * solib.c (solib_global_lookup): Simplify.
3634         * symtab.c (null_block_symbol): Remove.
3635         (symbol_cache_lookup): Simplify returns.
3636         (lookup_language_this): Simplify returns.
3637         (lookup_symbol_aux): Simplify return.
3638         (lookup_local_symbol): Simplify returns.
3639         (lookup_global_symbol_from_objfile): Simplify return.
3640         (lookup_symbol_in_objfile_symtabs)
3641         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3642         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3643         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3644         * cp-namespace.c (cp_lookup_bare_symbol)
3645         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3646         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3647         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3648         (cp_lookup_symbol_via_imports): Simplify initialization.
3649         (find_symbol_in_baseclass): Likewise.
3650         * symtab.h (null_block_symbol): Remove.
3651         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3652         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3653         (d_lookup_symbol_module): Likewise.
3654         (find_symbol_in_baseclass): Simplify initialization.
3655
3656 2019-03-24  Tom Tromey  <tom@tromey.com>
3657
3658         * expression.h: Don't include symtab.h.
3659         (struct block): Forward declare.
3660
3661 2019-03-24  Tom Tromey  <tom@tromey.com>
3662
3663         * c-exp.y (typebase): Remove casts.
3664         * gdbtypes.c (lookup_unsigned_typename, )
3665         (lookup_signed_typename): Remove cast.
3666         * eval.c (parse_to_comma_and_eval): Remove cast.
3667         * parse.c (write_dollar_variable): Remove cast.
3668         * block.h (struct block) <superblock>: Now const.
3669         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3670         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3671         (map_block): Make "block" const.
3672         * symfile.h (struct quick_symbol_functions)
3673         <map_matching_symbols>: Constify block argument to "callback".
3674         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3675         const.
3676         (find_pc_sect_compunit_symtab): Make "b" const.
3677         (find_symbol_at_address): Likewise.
3678         (search_symbols): Likewise.
3679         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3680         (dw2_debug_names_lookup_symbol): Likewise.
3681         (dw2_map_matching_symbols): Update.
3682         * p-valprint.c (pascal_val_print): Remove "block".
3683         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3684         (aux_add_nonlocal_symbols): Make "block" const.
3685         (resolve_subexp): Remove cast.
3686         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3687         const.
3688         (iterate_over_file_blocks): Likewise.
3689         * f-exp.y (%union) <bval>: Remove.
3690         * coffread.c (patch_opaque_types): Make "b" const.
3691         * spu-tdep.c (spu_catch_start): Make "block" const.
3692         * c-valprint.c (print_unpacked_pointer): Remove "block".
3693         * symmisc.c (dump_symtab_1): Make "b" const.
3694         (block_depth): Make "block" const.
3695         * d-exp.y (%union) <bval>: Remove.
3696         * cp-support.h (cp_lookup_rtti_type): Update.
3697         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3698         * psymtab.c (psym_lookup_symbol): Make "block" const.
3699         (maintenance_check_psymtabs): Make "b" const.
3700         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3701         (enumerate_locals, enumerate_args): Update.
3702         * python/py-symtab.c (stpy_global_block): Make "block" const.
3703         (stpy_static_block): Likewise.
3704         * inline-frame.c (block_starting_point_at): Make "new_block"
3705         const.
3706         * block.c (find_block_in_blockvector): Make return type const.
3707         (blockvector_for_pc_sect): Make "b" const.
3708         (find_block_in_blockvector): Make "b" const.
3709
3710 2019-03-23  Tom Tromey  <tom@tromey.com>
3711
3712         * varobj.c (varobj_create): Update.
3713         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3714         * printcmd.c (display_command, do_one_display): Don't reset
3715         innermost_block.
3716         * parser-defs.h (enum innermost_block_tracker_type): Move to
3717         expression.h.
3718         (innermost_block): Update comment.
3719         * parse.c (parse_exp_1): Add tracker_types parameter.
3720         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3721         tracker_types parameter.  Reset innermost_block.
3722         (parse_exp_in_context): Remove.
3723         (parse_expression_for_completion): Update.
3724         * objfiles.c (~objfile): Don't reset expression_context_block or
3725         innermost_block.
3726         * expression.h (enum innermost_block_tracker_type): Move from
3727         parser-defs.h.
3728         (parse_exp_1): Add tracker_types parameter.
3729         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3730         reset innermost_block.
3731
3732 2019-03-23  Tom Tromey  <tom@tromey.com>
3733
3734         * objfiles.h: Include bcache.h.
3735
3736 2019-03-23  Tom Tromey  <tom@tromey.com>
3737
3738         * linespec.c (get_current_search_block): Use
3739         scoped_restore_current_language.
3740         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3741
3742 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3743             Jiong Wang  <jiong.wang@arm.com>
3744
3745         * aarch64-linux-tdep.c
3746         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3747         section.
3748         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3749
3750 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3751             Jiong Wang  <jiong.wang@arm.com>
3752
3753         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3754         instructions.
3755         (aarch64_analyze_prologue_test): Add PACIASP test.
3756         (aarch64_prologue_prev_register): Unmask PC value.
3757
3758 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3759             Jiong Wang  <jiong.wang@arm.com>
3760
3761         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3762         (aarch64_dwarf2_prev_register): Unmask PC value.
3763         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3764         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3765         DW_CFA_AARCH64_negate_ra_state.
3766         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3767
3768 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3769             Jiong Wang  <jiong.wang@arm.com>
3770
3771         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3772         registers.
3773         (aarch64_pseudo_register_name): Likewise.
3774         (aarch64_pseudo_register_type): Likewise.
3775         (aarch64_pseudo_register_reggroup_p): Likewise.
3776         (aarch64_gdbarch_init): Add pauth registers.
3777         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3778         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3779         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3780         (struct gdbarch_tdep): Add regnum for ra_state.
3781
3782 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3783             Jiong Wang  <jiong.wang@arm.com>
3784
3785         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3786
3787 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3788             Jiong Wang  <jiong.wang@arm.com>
3789
3790         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3791         function.
3792         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3793         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3794         (aarch64_gdbarch_init): Add puth registers.
3795         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3796         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3797         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3798
3799 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3800             Jiong Wang  <jiong.wang@arm.com>
3801
3802         * aarch64-linux-nat.c
3803         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3804         * aarch64-linux-tdep.c
3805         (aarch64_linux_core_read_description): Likewise.
3806         (aarch64_linux_get_hwcap): New function.
3807         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3808         (aarch64_linux_get_hwcap): New declaration.
3809
3810 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3811             Jiong Wang  <jiong.wang@arm.com>
3812
3813         * aarch64-linux-nat.c
3814         (aarch64_linux_nat_target::read_description): Add pauth param.
3815         * aarch64-linux-tdep.c
3816         (aarch64_linux_core_read_description): Likewise.
3817         * aarch64-tdep.c (struct target_desc): Add in pauth.
3818         (aarch64_read_description): Add pauth param.
3819         (aarch64_gdbarch_init): Likewise.
3820         * aarch64-tdep.h (aarch64_read_description): Likewise.
3821         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3822         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3823         * features/Makefile: Add new files.
3824         * features/aarch64-pauth.c: New file.
3825         * features/aarch64-pauth.xml: New file.
3826
3827 2019-03-20  Tom Tromey  <tromey@adacore.com>
3828
3829         * infrun.c (handle_inferior_event): Rename from
3830         handle_inferior_event_1.  Create a scoped_value_mark.
3831         (handle_inferior_event): Remove.
3832
3833 2019-03-19  Tom Tromey  <tromey@adacore.com>
3834
3835         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3836         * infrun.h (print_stop_event): Add "displays" parameter.
3837         * infrun.c (print_stop_event): Add "displays" parameter.
3838
3839 2019-03-19  Pedro Alves  <palves@redhat.com>
3840
3841         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3842         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3843         to -1.  Fix TABs vs spaces.
3844         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3845         * tui/tui-out.h (tui_ui_out) Add intro comments.
3846         <m_line, m_start_of_line>: In-class initialize, and add describing
3847         comment.
3848
3849 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3850
3851         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3852         variable names.
3853         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3854
3855 2019-03-18  Pedro Alves  <palves@redhat.com>
3856             Eli Zaretskii <eliz@gnu.org>
3857
3858         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3859         m_line and m_start_of_line.
3860
3861 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3862
3863         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3864         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3865         it returns a newline.  This fixes a regression in TU mode, whereby
3866         the next line is output on the same screen line as the user input.
3867
3868 2019-03-18  Tom Tromey  <tromey@adacore.com>
3869
3870         * minsyms.c (minimal_symbol_reader::install): Remove call to
3871         obstack_blank.
3872
3873 2019-03-18  Pedro Alves  <palves@redhat.com>
3874
3875         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3876         New globals.
3877         (apply_style): New, factored out from ...
3878         (apply_ansi_escape): ... this.  Handle reverse video mode.
3879         (tui_set_reverse_mode): New function.
3880         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3881         * tui/tui-winsource.c (tui_show_source_line): Use
3882         tui_set_reverse_mode instead of setting A_STANDOUT.
3883         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3884         New setter methods.
3885
3886 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3887
3888         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3889         Handle tabs.
3890
3891 2019-03-18  Tom Tromey  <tromey@adacore.com>
3892
3893         * ada-lang.c (empty_array): Add "high" parameter.
3894         (ada_evaluate_subexp): Update.
3895
3896 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3897
3898         * unittests/string_view-selftests.c: Define
3899         _initialize_string_view_selftests unconditionally.
3900
3901 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3902
3903         PR gdb/24350
3904         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3905
3906 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3907
3908         PR gdb/24351
3909         * windows-nat.c (display_selector): Fix format specifiers.
3910
3911 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3912
3913         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3914         tui_refill_source_window instead of tui_refresh_win, to update the
3915         current execution line.  This fixes redisplay of the current line
3916         when stepping through the code with "next" or "step".
3917
3918 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3919
3920         * source-cache.c (source_cache::get_source_lines): Call
3921         find_source_lines to initialize s->nlines.  This fixes vertical
3922         scrolling of TUI source window when the DOWN arrow is pressed.
3923
3924 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3925
3926         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3927         linux-thread-db.c (_initialize_thread_db): Likewise.
3928
3929 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3930
3931         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3932         wclrtoeol in tui_show_source_line".  This reverts changes made in
3933         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3934
3935 2019-03-15  Tom Tromey  <tom@tromey.com>
3936
3937         * symtab.h (struct minimal_symbol): Derive from
3938         general_symbol_info.
3939         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3940         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3941         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3942         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3943         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3944         (MSYMBOL_SEARCH_NAME): Update.
3945         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3946         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3947         * minsyms.c (minimal_symbol_reader::record_full): Update.
3948
3949 2019-03-15  Tom Tromey  <tom@tromey.com>
3950
3951         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3952
3953 2019-03-15  Tom Tromey  <tom@tromey.com>
3954
3955         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3956         unique_xmalloc_ptr.
3957         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3958         Update.
3959         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3960         (build_minimal_symbol_hash_tables)
3961         (minimal_symbol_reader::install): Update.
3962
3963 2019-03-15  Tom Tromey  <tom@tromey.com>
3964
3965         * symtab.c (create_demangled_names_hash): Update.
3966         (symbol_set_names): Update.
3967         * objfiles.h (struct objfile_per_bfd_storage)
3968         <demangled_names_hash>: Now an htab_up.
3969         * objfiles.c (objfile_per_bfd_storage): Simplify.
3970
3971 2019-03-15  Tom Tromey  <tom@tromey.com>
3972
3973         * objfiles.h (struct objfile_per_bfd_storage): Declare
3974         destructor.
3975         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3976         New.
3977         (get_objfile_bfd_data): Use new.  Don't initialize
3978         language_of_main.
3979         (free_objfile_per_bfd_storage): Remove.
3980         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3981
3982 2019-03-15  Tom Tromey  <tom@tromey.com>
3983
3984         * symfile.c (reread_symbols): Update.
3985         * objfiles.c (objfile::objfile): Update.
3986         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3987         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3988         comment.
3989         (minimal_symbol_reader::install): Update.
3990         (terminate_minimal_symbol_table): Remove.
3991         * jit.c (jit_object_close_impl): Update.
3992
3993 2019-03-15  Tom Tromey  <tom@tromey.com>
3994
3995         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3996         initializations.
3997
3998 2019-03-15  Tom Tromey  <tom@tromey.com>
3999
4000         * objfiles.h (struct objfile_per_bfd_storage)
4001         <demangled_hash_languages>: Now a bitset.
4002         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4003         (lookup_minimal_symbol): Update.
4004
4005 2019-03-15  Tom Tromey  <tom@tromey.com>
4006
4007         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4008         Don't return the symbol.
4009         * coffread.c (record_minimal_symbol): Use record_full.
4010
4011 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4012
4013         The MS-Windows port of ncurses fails to switch to a color pair if
4014         one or both of the colors are the implicit default colors.  This
4015         change records the default colors when TUI is initialized, and
4016         then specifies them explicitly when a color pair uses the default
4017         colors.  This allows color styling in TUI mode on MS-Windows.
4018
4019         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4020         ncurses_norm_attr.
4021         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4022         colors in ncurses_norm_attr.
4023         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4024         "none", replace it with the default color recorded in
4025         ncurses_norm_attr.
4026
4027 2019-03-14  Tom Tromey  <tromey@adacore.com>
4028
4029         * source-cache.h (class source_cache) <get_source_lines>: Return
4030         std::string.
4031         * source-cache.c (source_cache::extract_lines): Handle case where
4032         first_pos==npos.  Return std::string.
4033         (source_cache::get_source_lines): Update.
4034
4035 2019-03-14  Tom Tromey  <tromey@adacore.com>
4036
4037         * NEWS: Add item for "style sources" commands.
4038         * source-cache.c (source_cache::get_source_lines): Check
4039         source_styling.
4040         * cli/cli-style.c (source_styling): New global.
4041         (_initialize_cli_style): Add "style sources" commands.
4042         (show_style_sources): New function.
4043         * cli/cli-style.h (source_styling): Declare.
4044
4045 2019-03-14  Pedro Alves  <palves@redhat.com>
4046             Tom Tromey  <tromey@adacore.com>
4047
4048         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4049         * tui/tui-winsource.c (tui_refill_source_window): New function,
4050         from...
4051         (tui_horizontal_source_scroll): ... here.  Move some logic.
4052         * cli/cli-style.c (set_style_enabled): Notify new observable.
4053         * tui/tui-hooks.c (tui_redisplay_source): New function.
4054         (tui_attach_detach_observers): Attach or detach
4055         tui_redisplay_source.
4056         * observable.h (source_styling_changed): New observable.
4057         * observable.c: Define source_styling_changed observable.
4058
4059 2019-03-13  Tom Tromey  <tromey@adacore.com>
4060
4061         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4062         (i386_gnu_nat_target::store_registers): Update.
4063         * target-debug.h (target_debug_print_std_string): New macro.
4064         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4065         * windows-tdep.c (display_one_tib): Update.
4066         * tui/tui-stack.c (tui_make_status_line): Update.
4067         * top.c (print_inferior_quit_action): Update.
4068         * thread.c (thr_try_catch_cmd): Update.
4069         (add_thread_with_info): Update.
4070         (thread_target_id_str): Update.
4071         (thr_try_catch_cmd): Update.
4072         (thread_command): Update.
4073         (thread_find_command): Update.
4074         * record-btrace.c (record_btrace_target::info_record)
4075         (record_btrace_resume_thread, record_btrace_target::resume)
4076         (record_btrace_cancel_resume, record_btrace_step_thread)
4077         (record_btrace_target::wait, record_btrace_target::wait)
4078         (record_btrace_target::wait, record_btrace_target::stop): Update.
4079         * progspace.c (print_program_space): Update.
4080         * process-stratum-target.c
4081         (process_stratum_target::thread_address_space): Update.
4082         * linux-fork.c (linux_fork_mourn_inferior)
4083         (detach_checkpoint_command, info_checkpoints_command)
4084         (linux_fork_context): Update.
4085         (linux_fork_detach): Update.
4086         (class scoped_switch_fork_info): Update.
4087         (delete_checkpoint_command): Update.
4088         * infrun.c (follow_fork_inferior): Update.
4089         (follow_fork_inferior): Update.
4090         (proceed_after_vfork_done): Update.
4091         (handle_vfork_child_exec_or_exit): Update.
4092         (follow_exec): Update.
4093         (displaced_step_prepare_throw): Update.
4094         (displaced_step_restore): Update.
4095         (start_step_over): Update.
4096         (resume_1): Update.
4097         (clear_proceed_status_thread): Update.
4098         (proceed): Update.
4099         (print_target_wait_results): Update.
4100         (do_target_wait): Update.
4101         (context_switch): Update.
4102         (stop_all_threads): Update.
4103         (restart_threads): Update.
4104         (finish_step_over): Update.
4105         (handle_signal_stop): Update.
4106         (switch_back_to_stepped_thread): Update.
4107         (keep_going_pass_signal): Update.
4108         (print_exited_reason): Update.
4109         (normal_stop): Update.
4110         * inferior.c (inferior_pid_to_str): Change return type.
4111         (print_selected_inferior): Update.
4112         (add_inferior): Update.
4113         (detach_inferior): Update.
4114         * dummy-frame.c (fprint_dummy_frames): Update.
4115         * dcache.c (dcache_info_1): Update.
4116         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4117         (btrace_fetch, btrace_clear): Update.
4118         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4119         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4120         type.
4121         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4122         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4123         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4124         * gdbarch.c, gdbarch.h: Rebuild.
4125         * gdbarch.sh (core_pid_to_str): Change return type.
4126         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4127         return type.
4128         (windows_nat_target::pid_to_str): Change return type.
4129         (windows_delete_thread): Update.
4130         (windows_nat_target::attach): Update.
4131         (windows_nat_target::files_info): Update.
4132         * target-delegates.c: Rebuild.
4133         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4134         return type.
4135         (sol_thread_target::pid_to_str): Change return type.
4136         * remote.c (class remote_target) <pid_to_str>: Change return
4137         type.
4138         (remote_target::pid_to_str): Change return type.
4139         (extended_remote_target::attach, remote_target::remote_stop_ns)
4140         (remote_target::remote_notif_remove_queued_reply)
4141         (remote_target::push_stop_reply, remote_target::disable_btrace):
4142         Update.
4143         (extended_remote_target::attach): Update.
4144         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4145         type.
4146         (gdbsim_target::pid_to_str): Change return type.
4147         * ravenscar-thread.c (struct ravenscar_thread_target)
4148         <pid_to_str>: Change return type.
4149         (ravenscar_thread_target::pid_to_str): Change return type.
4150         * procfs.c (class procfs_target) <pid_to_str>: Change return
4151         type.
4152         (procfs_target::pid_to_str): Change return type.
4153         (procfs_target::attach): Update.
4154         (procfs_target::detach): Update.
4155         (procfs_target::fetch_registers): Update.
4156         (procfs_target::store_registers): Update.
4157         (procfs_target::wait): Update.
4158         (procfs_target::files_info): Update.
4159         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4160         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4161         return type.
4162         (nto_procfs_target::pid_to_str): Change return type.
4163         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4164         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4165         return type.
4166         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4167         (exit_lwp): Update.
4168         (attach_proc_task_lwp_callback, get_detach_signal)
4169         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4170         (linux_nat_target::resume, wait_lwp, stop_callback)
4171         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4172         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4173         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4174         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4175         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4176         type.
4177         (inf_ptrace_target::attach): Update.
4178         (inf_ptrace_target::files_info): Update.
4179         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4180         type.
4181         (go32_nat_target::pid_to_str): Change return type.
4182         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4183         (gnu_nat_target::wait): Update.
4184         (gnu_nat_target::wait): Update.
4185         (gnu_nat_target::resume): Update.
4186         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4187         (fbsd_nat_target::wait): Update.
4188         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4189         type.
4190         (darwin_nat_target::attach): Update.
4191         * corelow.c (class core_target) <pid_to_str>: Change return type.
4192         (core_target::pid_to_str): Change return type.
4193         * target.c (normal_pid_to_str): Change return type.
4194         (default_pid_to_str): Likewise.
4195         (target_pid_to_str): Change return type.
4196         (target_translate_tls_address): Update.
4197         (target_announce_detach): Update.
4198         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4199         return type.
4200         (bsd_uthread_target::pid_to_str): Change return type.
4201         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4202         type.
4203         (bsd_kvm_target::pid_to_str): Change return type.
4204         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4205         return type.
4206         (aix_thread_target::pid_to_str): Change return type.
4207         * target.h (struct target_ops) <pid_to_str>: Change return type.
4208         (target_pid_to_str, normal_pid_to_str): Likewise.
4209         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4210         type.
4211         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4212         type.
4213         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4214         return type.
4215         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4216         type.
4217         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4218         type.
4219         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4220         return type.
4221
4222 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4223
4224         * NEWS: Mention that the new default MI version is 3.  Mention
4225         changes to the output of commands and events that deal with
4226         multi-location breakpoints.
4227         * breakpoint.c: Include "mi/mi-out.h".
4228         (print_one_breakpoint): Change output syntax if using MI version
4229         >= 3.
4230         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4231         New.
4232         (mi_multi_location_breakpoint_output_fixed): New.
4233         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4234         (mi_cmd_fix_multi_location_breakpoint_output): New.
4235         (mi_multi_location_breakpoint_output_fixed): New.
4236         * mi/mi-cmds.c (mi_cmds): Register command
4237         -fix-multi-location-breakpoint-output.
4238         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4239         interpreter "mi".
4240
4241 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4242
4243         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4244         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4245         instantiate mi_ui_out based on interpreter name.
4246         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4247         * mi/mi-main.c (mi_load_progress): Likewise.
4248
4249 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4250
4251         * NEWS: Combine separate "New targets" sections for 8.3.
4252
4253 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4254
4255         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4256         (ppcfbsd_init_abi): Install gdbarch
4257         "fetch_tls_load_module_address" and "get_thread_local_address"
4258         methods.
4259
4260 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4261
4262         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4263         (riscv_fbsd_init_abi): Install gdbarch
4264         "fetch_tls_load_module_address" and "get_thread_local_address"
4265         methods.
4266
4267 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4268
4269         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4270         (i386fbsd_init_abi): Install gdbarch
4271         "fetch_tls_load_module_address" and "get_thread_local_address"
4272         methods.
4273
4274 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4275
4276         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4277         (amd64fbsd_init_abi): Install gdbarch
4278         "fetch_tls_load_module_address" and "get_thread_local_address"
4279         methods.
4280
4281 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4282
4283         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4284         (struct fbsd_pspace_data): New type.
4285         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4286         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4287         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4288         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4289         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4290
4291 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4292
4293         * gdbtypes.c (lookup_struct_elt): New function.
4294         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4295         * gdbtypes.h (struct struct_elt): New type.
4296         (lookup_struct_elt): New prototype.
4297
4298 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4299
4300         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4301         remove disabled code block.
4302
4303 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4304
4305         * gdbarch.sh (get_thread_local_address): New method.
4306         * gdbarch.h, gdbarch.c: Regenerate.
4307         * target.c (target_translate_tls_address): Use
4308         gdbarch_get_thread_local_address if present instead of
4309         target::get_thread_local_address.
4310
4311 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4312
4313         * target.h (target::get_thread_local_address): Update comment.
4314
4315 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4316
4317         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4318         objfile->separate_debug_objfile_backlink if not NULL.
4319
4320 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4321
4322         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4323         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4324         (amd64bsd_store_inferior_registers): Likewise.
4325         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4326         Enable segment base registers.
4327         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4328         PT_GETFSBASE and PT_GETGSBASE.
4329         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4330         PT_SETGSBASE.
4331         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4332         segment base registers.
4333         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4334
4335 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4336
4337         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4338         Update calls to i386_target_description to add 'segments'
4339         parameter.
4340         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4341         add segment base registers.
4342         * arch/i386.c (i386_create_target_description): Add 'segments'
4343         parameter to enable segment base registers.
4344         * arch/i386.h (i386_create_target_description): Likewise.
4345         * features/i386/32bit-segments.xml: New file.
4346         * features/i386/32bit-segments.c: Generate.
4347         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4348         call to i386_target_description to add 'segments' parameter.
4349         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4350         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4351         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4352         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4353         if feature is present.
4354         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4355         Add 'segments' parameter to call to i386_target_description.
4356         (i386_target_description): Add 'segments' parameter to enable
4357         segment base registers.
4358         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4359         to call to i386_target_description.
4360         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4361         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4362         Define I386_NUM_REGS.
4363         (i386_target_description): Add 'segments' parameter to enable
4364         segment base registers.
4365
4366 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4367
4368         PR/24325
4369         * source-cache.c: #undef open and close, to avoid unresolved
4370         externals during linking.
4371
4372 2019-03-12  Tom Tromey  <tromey@adacore.com>
4373
4374         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4375         const.  Add initializers.
4376         (_initialize_remote): Don't initialize ptid globals.
4377
4378 2019-03-12  Pedro Alves  <palves@redhat.com>
4379
4380         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4381
4382 2019-03-12  Pedro Alves  <palves@redhat.com>
4383
4384         * cp-name-parser.y (main): Remove unused 'len' variable.
4385
4386 2019-03-12  Tom Tromey  <tromey@adacore.com>
4387
4388         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4389         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4390
4391 2019-03-12  Tom Tromey  <tromey@adacore.com>
4392
4393         * linux-nat.c (iterate_over_lwps): Update.
4394         (stop_callback): Remove parameter.
4395         (stop_wait_callback, detach_callback, resume_set_callback)
4396         (select_singlestep_lwp_callback, set_ignore_sigint)
4397         (status_callback, resumed_callback, resume_clear_callback)
4398         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4399         data parameter.
4400         (linux_nat_target::detach, linux_nat_target::resume)
4401         (linux_stop_and_wait_all_lwps, select_event_lwp)
4402         (linux_nat_filter_event, linux_nat_wait_1)
4403         (linux_nat_target::kill, linux_nat_target::stop)
4404         (linux_nat_target::stop): Update.
4405         (linux_nat_resume_callback): Change type.
4406         (resume_stopped_resumed_lwps, count_events_callback)
4407         (select_event_lwp_callback): Likewise.
4408         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4409         * arm-linux-nat.c (struct update_registers_data): Remove.
4410         (update_registers_callback): Change type.
4411         (arm_linux_insert_hw_breakpoint1): Update.
4412         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4413         parameter.
4414         (x86_linux_dr_set_addr): Update.
4415         (x86_linux_dr_set_control): Update.
4416         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4417         (iterate_over_lwps): Use gdb::function_view.
4418         * nat/aarch64-linux-hw-point.c (struct
4419         aarch64_dr_update_callback_param): Remove.
4420         (debug_reg_change_callback): Change type.
4421         (aarch64_notify_debug_reg_change): Update.
4422         * s390-linux-nat.c (s390_refresh_per_info): Update.
4423
4424 2019-03-11  Tom Tromey  <tromey@adacore.com>
4425
4426         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4427         redundant assignment to "this_cu".
4428
4429 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4430
4431         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4432
4433 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4434
4435         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4436         from...
4437         (rank_one_type): ... this.
4438
4439 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4440
4441         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4442         from...
4443         (rank_one_type): ... this.
4444
4445 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4446
4447         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4448         from...
4449         (rank_one_type): ... this.
4450
4451 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4452
4453         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4454         from...
4455         (rank_one_type): ... this.
4456
4457 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4458
4459         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4460         from...
4461         (rank_one_type): ... this.
4462
4463 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4464
4465         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4466         from...
4467         (rank_one_type): ... this.
4468
4469 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4470
4471         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4472         from...
4473         (rank_one_type): ... this.
4474
4475 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4476
4477         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4478         from...
4479         (rank_one_type): ... this.
4480
4481 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4482
4483         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4484         from...
4485         (rank_one_type): ... this.
4486
4487 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4488
4489         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4490         from...
4491         (rank_one_type): ... this.
4492
4493 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4494
4495         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4496         from...
4497         (rank_one_type): ... this.
4498
4499 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4500
4501         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4502         from...
4503         (rank_one_type): ... this.
4504
4505 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4506
4507         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4508         inferior-events' shows the example events.
4509
4510 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4511
4512         Support styling on native MS-Windows console
4513
4514         PR/24315
4515         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4516         on MS-Windows if $TERM is not defined.
4517
4518         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4519
4520         * posix-hdep.c (gdb_console_fputs):
4521         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4522         functions.
4523         * ui-file.h (gdb_console_fputs): Add prototype.
4524
4525         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4526         back to fputs only if the former returns zero.
4527
4528 2019-03-07  Tom Tromey  <tom@tromey.com>
4529
4530         * symmisc.c (print_symbol_bcache_statistics): Update.
4531         (print_objfile_statistics): Update.
4532         * symfile.c (allocate_symtab): Update.
4533         * stabsread.c: Don't include bcache.h.
4534         * psymtab.h (struct psymbol_bcache): Don't declare.
4535         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4536         (psymbol_bcache_init, psymbol_bcache_free)
4537         (psymbol_bcache_get_bcache): Don't declare.
4538         * psymtab.c (struct psymbol_bcache): Remove.
4539         (psymtab_storage::psymtab_storage): Update.
4540         (psymtab_storage::~psymtab_storage): Update.
4541         (psymbol_bcache_init, psymbol_bcache_free)
4542         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4543         (add_psymbol_to_bcache): Update.
4544         (allocate_psymtab): Update.
4545         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4546         macro_cache>: No longer pointers.
4547         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4548         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4549         * macrotab.c (macro_bcache): Update.
4550         * macroexp.c: Don't include bcache.h.
4551         * gdbtypes.c (check_types_worklist): Update.
4552         (types_deeply_equal): Remove TRY/CATCH.  Update.
4553         * elfread.c (elf_symtab_read): Update.
4554         * dwarf2read.c: Don't include bcache.h.
4555         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4556         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4557         (print_bcache_statistics, bcache_memory_used): Don't declare.
4558         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4559         methods.  Rename all data members.
4560         * bcache.c (struct bcache): Move to bcache.h.
4561         (bcache::expand_hash_table): Rename from expand_hash_table.
4562         (bcache): Remove.
4563         (bcache::insert): Rename from bcache_full.
4564         (bcache::compare): Rename from bcache_compare.
4565         (bcache_xmalloc): Remove.
4566         (bcache::~bcache): Rename from bcache_xfree.
4567         (bcache::print_statistics): Rename from print_bcache_statistics.
4568         (bcache::memory_used): Rename from bcache_memory_used.
4569
4570 2019-03-07  Pedro Alves  <palves@redhat.com>
4571
4572         * infrun.c (normal_stop): Also check for
4573         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4574
4575 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4576
4577         * f-lang.c (value_from_host_double): Moved to...
4578         * value.c (value_from_host_double): ...here.
4579         * value.h (value_from_host_double): Declare.
4580         * guile/scm-math.c (vlscm_convert_typed_number): Use
4581         value_from_host_double.
4582         (vlscm_convert_number): Likewise.
4583         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4584         * python/py-value.c (convert_value_from_python): Likewise.
4585
4586 2019-03-06  Tom Tromey  <tom@tromey.com>
4587
4588         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4589
4590 2019-03-06  Tom Tromey  <tom@tromey.com>
4591
4592         * utils.h (free_current_contents): Don't declare.
4593         * utils.c (free_current_contents): Remove.
4594
4595 2019-03-06  Tom Tromey  <tom@tromey.com>
4596
4597         * top.c (quit_force): Update.
4598         * main.c (captured_command_loop): Update.
4599         * common/new-op.c (operator new): Update.
4600         * common/common-exceptions.c (struct catcher)
4601         <save_cleanup_chain>: Remove member.
4602         (exceptions_state_mc_init): Update.
4603         (exception_try_scope_entry): Return nullptr.
4604         (exception_try_scope_exit, exception_rethrow)
4605         (throw_exception_sjlj, throw_exception_cxx): Update.
4606         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4607         (all_cleanups, do_cleanups, discard_cleanups)
4608         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4609         (restore_cleanups, restore_final_cleanups): Don't declare.
4610         (do_final_cleanups): Remove parameter.
4611         * common/cleanups.c (cleanup_chain, make_cleanup)
4612         (make_cleanup_dtor, all_cleanups, do_cleanups)
4613         (discard_my_cleanups, discard_cleanups)
4614         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4615         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4616         (null_cleanup): Remove.
4617         (do_final_cleanups): Remove parameter.
4618
4619 2019-03-06  Tom Tromey  <tom@tromey.com>
4620
4621         * remote.c (remote_target::remote_parse_stop_reply): Use
4622         unique_xmalloc_ptr.
4623
4624 2019-03-06  Tom Tromey  <tom@tromey.com>
4625
4626         * stabsread.c (struct stabs_field_info): Rename from field_info.
4627         <list, fnlist>: Add initializers.
4628         <obstack>: New member.
4629         (read_member_functions, read_struct_fields, read_baseclasses):
4630         Allocate on obstack.  Don't use cleanups.
4631         (read_one_struct_field, read_member_functions, read_struct_fields)
4632         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4633         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4634         (read_struct_type): Update.
4635
4636 2019-03-06  Tom Tromey  <tom@tromey.com>
4637
4638         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4639         * common/filestuff.h (make_cleanup_close): Don't declare.
4640         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4641         Remove.
4642
4643 2019-03-06  Tom Tromey  <tom@tromey.com>
4644
4645         * solib-aix.c: Use make_scope_exit.
4646
4647 2019-03-06  Tom Tromey  <tom@tromey.com>
4648
4649         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4650         Use make_scope_exit.
4651
4652 2019-03-06  Tom Tromey  <tom@tromey.com>
4653
4654         * solib-svr4.c (disable_probes_interface): Remove parameter.
4655         (svr4_handle_solib_event): Use make_scope_exit.
4656
4657 2019-03-06  Tom Tromey  <tom@tromey.com>
4658
4659         * remote.c (struct stop_reply_deleter): Remove.
4660         (stop_reply_up): Update.
4661         (struct stop_reply): Derive from notif_event.  Don't typedef.
4662         <regcache>: Now a std::vector.
4663         (stop_reply_xfree): Remove.
4664         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4665         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4666         (remote_target::discard_pending_stop_replies): Use delete.
4667         (remote_target::remote_parse_stop_reply): Update.
4668         (remote_target::process_stop_reply): Update.
4669         * remote-notif.h (struct notif_event): Add virtual destructor.
4670         Remove "dtr" member.
4671         (struct notif_client) <alloc_event>: Return a unique_ptr.
4672         (notif_event_xfree): Don't declare.
4673         (notif_event_up): New typedef.
4674         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4675         (notif_event_xfree, do_notif_event_xfree): Remove.
4676         (remote_notif_state_xfree): Update.
4677
4678 2019-03-06  Tom Tromey  <tom@tromey.com>
4679
4680         * infrun.c (displaced_step_clear_cleanup): Now a
4681         forward_scope_exit type.
4682         (displaced_step_prepare_throw): Update.
4683         (displaced_step_fixup): Update.
4684
4685 2019-03-06  Tom Tromey  <tom@tromey.com>
4686
4687         * inferior.h (class inferior): Update comment.
4688         * gdbthread.h (class thread_info): Update comment.
4689
4690 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4691             Tom Tromey  <tom@tromey.com>
4692
4693         * stabsread.h (struct stab_section_list): Remove.
4694         (coffstab_build_psymtabs): Update.
4695         * dbxread.c (symbuf_sections): Now a std::vector.
4696         (sect_idx): New global.
4697         (fill_symbuf): Update.
4698         (coffstab_build_psymtabs): Change type of stabsects parameter.
4699         Update.
4700         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4701         std::vector.
4702         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4703         (coff_locate_sections): Update.
4704         (coff_symfile_read): Remove cleanups.  Update.
4705         (init_stringtab): Add storage parameter.
4706         (free_stringtab, free_stringtab_cleanup): Remove.
4707         (init_lineno): Add storage parameter.
4708         (free_linetab, free_linetab_cleanup): Remove.
4709
4710 2019-03-06  Pedro Alves  <palves@redhat.com>
4711
4712         * linux-fork.c (fork_info::clobber_regs): Delete.
4713         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4714         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4715         comment.  Adjust.
4716         (scoped_switch_fork_info::scoped_switch_fork_info)
4717         (checkpoint_command, linux_fork_context): Adjust
4718         fork_save_infrun_state calls.
4719
4720 2019-03-06  Pedro Alves  <palves@redhat.com>
4721
4722         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4723         (inf_has_multiple_threads): Return 'bool' and rewrite using
4724         inferior_info::threads().
4725
4726 2019-03-06  Pedro Alves  <palves@redhat.com>
4727
4728         * linux-fork.c: Include <list>.
4729         (fork_list): Now a std::list instance.
4730         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4731         (forks_exist_p, find_last_fork): Adjust.
4732         (new_fork): Delete.
4733         (one_fork_p): New.
4734         (add_fork): Adjust.
4735         (free_fork): Delete, folded into fork_info::~fork_info().
4736         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4737         Adjust.
4738         (init_fork_list): Delete.
4739         (linux_fork_killall, linux_fork_mourn_inferior)
4740         (linux_fork_detach, info_checkpoints_command): Adjust.
4741         (_initialize_linux_fork): No longer call init_fork_list.
4742
4743 2019-03-06  Pedro Alves  <palves@redhat.com>
4744
4745         * linux-fork.c (new_fork): New, split out of ...
4746         (add_fork): ... this.  Return void.  Move "first fork" special
4747         case from here, to ...
4748         (checkpoint_command): ... here.
4749         * linux-linux.h (add_fork): Return void.
4750
4751 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4752
4753         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4754
4755 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4756             Chris January  <chris.january@arm.com>
4757             David Lecomber  <david.lecomber@arm.com>
4758
4759         * f-exp.y: New token, UNOP_INTRINSIC.
4760         (exp): New pattern using UNOP_INTRINSIC token.
4761         (f77_keywords): Add 'abs' keyword.
4762         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4763         (value_from_host_double): New function.
4764         (evaluate_subexp_f): Support UNOP_ABS.
4765
4766 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4767
4768         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4769         types.
4770
4771 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4772
4773         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4774         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4775         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4776
4777 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4778
4779         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4780
4781 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4782             Chris January  <chris.january@arm.com>
4783
4784         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4785         * f-exp.y: Define 'KIND' token.
4786         (exp): New pattern for KIND expressions.
4787         (ptype): Handle types with a kind extension.
4788         (direct_abs_decl): Extend to spot kind extensions.
4789         (f77_keywords): Add 'kind' to the list.
4790         (push_kind_type): New function.
4791         (convert_to_kind_type): New function.
4792         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4793         * parse.c (operator_length_standard): Likewise.
4794         * parser-defs.h (enum type_pieces): Add tp_kind.
4795         * std-operator.def: Add UNOP_KIND.
4796
4797 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4798
4799         * f-exp.y (f_parse): Set yydebug.
4800
4801 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4802
4803         * f-lang.c (evaluate_subexp_f): New function.
4804         (exp_descriptor_f): New global.
4805         (f_language_defn): Use exp_descriptor_f instead of
4806         exp_descriptor_standard.
4807
4808 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4809
4810         * f-exp.y (struct token): Add comments.
4811         (dot_ops): Remove uppercase versions and the end marker.
4812         (f77_keywords): Likewise.
4813         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4814         entries in the dot_ops array are case insensitive, and use
4815         strncasecmp to compare strings.  Also some whitespace cleanup in
4816         this area.  Similar for the f77_keywords array, except entries in
4817         this list might be case sensitive.
4818
4819 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4820
4821         * f-exp.y (struct f77_boolean_val): Add comments.
4822         (boolean_values): Remove uppercase versions, and end marker.
4823         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4824         and use strncasecmp to achieve case insensitivity.  Additionally,
4825         perform whitespace cleanup around this code.
4826
4827 2019-03-06  Tom Tromey  <tromey@adacore.com>
4828
4829         * remote-sim.c (gdbsim_target_open): Use result of
4830         gdb_argv::release.
4831
4832 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4833         Dirk Schubert  <dirk.schubert@arm.com>
4834         Chris January  <chris.january@arm.com>
4835
4836         * eval.c (evaluate_subexp_standard): Call Fortran argument
4837         wrapping logic.
4838         * f-lang.c (struct value): A value which can be passed into a
4839         Fortran function call.
4840         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4841         where appropriate.
4842         (struct type): Value ready for a Fortran function call.
4843         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4844         is needed.
4845         * f-lang.h (fortran_argument_convert): Declaration.
4846         (fortran_preserve_arg_pointer): Declaration.
4847         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4848
4849 2019-03-05  Tom Tromey  <tromey@adacore.com>
4850
4851         * python/py-prettyprint.c (print_string_repr): Remove #if.
4852         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4853
4854 2019-03-05  Tom Tromey  <tromey@adacore.com>
4855
4856         * target.c (the_dummy_target): Move later.  Change type to
4857         "dummy_target".
4858         (initialize_targets): Don't initialize the_dummy_target.
4859
4860 2019-03-05  Tom Tromey  <tromey@adacore.com>
4861
4862         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4863         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4864
4865 2019-03-05  Tom Tromey  <tromey@adacore.com>
4866
4867         * windows-nat.c (windows_nat_target::attach)
4868         (windows_nat_target::detach): Don't call gdb_flush.
4869         * valprint.c (generic_val_print, val_print, val_print_string):
4870         Don't call gdb_flush.
4871         * utils.c (defaulted_query): Don't call gdb_flush.
4872         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4873         * target.c (target_announce_detach): Don't call gdb_flush.
4874         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4875         * remote.c (extended_remote_target::attach): Don't call
4876         gdb_flush.
4877         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4878         * printcmd.c (do_examine): Don't call gdb_flush.
4879         (info_display_command): Don't call gdb_flush.
4880         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4881         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4882         * memattr.c (info_mem_command): Don't call gdb_flush.
4883         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4884         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4885         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4886         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4887         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4888         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4889         (gnu_nat_target::detach): Don't call gdb_flush.
4890         * f-valprint.c (f_val_print): Don't call gdb_flush.
4891         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4892         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4893         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4894         gdb_flush.
4895         * c-valprint.c (c_val_print): Don't call gdb_flush.
4896         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4897
4898 2019-03-05  Tom Tromey  <tromey@adacore.com>
4899
4900         * varobj.c (update_dynamic_varobj_children): Update.
4901         (install_default_visualizer): Use reset, not release.
4902         * value.c (set_internalvar): Update.
4903         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4904         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4905         ATTRIBUTE_UNUSED_RESULT.
4906
4907 2019-03-05  Tom Tromey  <tromey@adacore.com>
4908
4909         * remote.c (class scoped_remote_fd) <release>: Add
4910         ATTRIBUTE_UNUSED_RESULT.
4911
4912 2019-03-05  Tom Tromey  <tromey@adacore.com>
4913
4914         * macroexp.c (struct macro_buffer) <release>: Add
4915         ATTRIBUTE_UNUSED_RESULT.
4916
4917 2019-03-05  Tom Tromey  <tromey@adacore.com>
4918
4919         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4920         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4921         ATTRIBUTE_UNUSED_RESULT.
4922
4923 2019-03-05  Tom Tromey  <tromey@adacore.com>
4924
4925         * common/scoped_fd.h (class scoped_fd) <release>: Add
4926         ATTRIBUTE_UNUSED_RESULT.
4927
4928 2019-03-05  Tom Tromey  <tromey@adacore.com>
4929
4930         * parser-defs.h (struct parser_state) <release>: Add
4931         ATTRIBUTE_UNUSED_RESULT.
4932
4933 2019-03-05  Tom Tromey  <tromey@adacore.com>
4934
4935         * utils.h (class gdb_argv) <release>: Add
4936         ATTRIBUTE_UNUSED_RESULT.
4937         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4938
4939 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4940
4941         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4942         for-loop range, to avoid compiler warnings.
4943
4944         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4945         avoid compiler warnings about unused variables.
4946
4947         * NEWS: Mention end of support for native debugging on MS-Windows
4948         before XP.
4949
4950         PR gdb/24292
4951         * common/netstuff.c:
4952         * gdbserver/gdbreplay.c
4953         * gdbserver/remote-utils.c:
4954         * ser-tcp.c:
4955         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4956         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4957         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4958         'getaddrinfo' and 'freeaddrinfo' were not available before
4959         Windows XP, and mingw.org's MinGW headers by default define
4960         _WIN32_WINNT to 0x500.
4961
4962 2019-03-01  Gary Benson <gbenson@redhat.com>
4963
4964         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4965
4966 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4967             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4968
4969         PR gdb/8527
4970         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4971         set_sigint_trap, clear_sigint_trap.
4972
4973 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4974
4975         * target.c (target_detach): Clear the regcache and the
4976         frame cache.
4977
4978 2019-02-27  Pedro Alves  <palves@redhat.com>
4979
4980         * utils.c (set_screen_size): When we cap the height/width sizes,
4981         tweak the corresponding command variable to show "unlimited":
4982
4983 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4984             Pedro Alves  <palves@redhat.com>
4985
4986         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4987         before calling rl_set_screen_size.
4988
4989 2019-02-27  Tom Tromey  <tromey@adacore.com>
4990
4991         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4992         define.
4993         * python/py-value.c: Remove Python 2.4 workaround.
4994         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4995         workaround.
4996         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4997         Python 2.4 workaround.
4998         * python/python-internal.h: Remove Python 2.4 comment.
4999         (Py_ssize_t): Don't define.
5000         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5001         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5002         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5003         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5004         * python/python.c (do_start_initialization): Remove Python 2.4
5005         workaround.
5006         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5007         (print_children): Remove Python 2.4 workaround.
5008         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5009         workaround.
5010         (CHARBUFFERPROC_NAME): Remove.
5011         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5012         Python 2.4 workaround.
5013
5014 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5015
5016         * NEWS: Note minimum Python version.
5017
5018 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5019
5020         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5021         code from these functions.  Remove corresponding ifdefs.  Use
5022         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5023         Remove gotos and target of gotos.
5024         (infpy_search_memory): Likewise.
5025
5026 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5027
5028         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5029         (hppa_gdbarch_init): Don't register deleted functions with
5030         gdbarch.
5031
5032 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5033
5034         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5035         (h8300_unwind_sp): Delete.
5036         (h8300_dummy_id): Delete.
5037         (h8300_gdbarch_init): Don't register deleted functions with
5038         gdbarch.
5039
5040 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5041
5042         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5043         (ft32_unwind_pc): Delete.
5044         (ft32_unwind_sp): Delete.
5045         (ft32_gdbarch_init): Don't register deleted functions with
5046         gdbarch.
5047
5048 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5049
5050         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5051         (frv_unwind_pc): Delete.
5052         (frv_unwind_sp): Delete.
5053         (frv_gdbarch_init): Don't register deleted functions with
5054         gdbarch.
5055
5056 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5057
5058         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5059         (riscv_unwind_pc): Delete.
5060         (riscv_unwind_sp): Delete.
5061         (riscv_gdbarch_init): Don't register deleted functions with
5062         gdbarch.
5063
5064 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5065
5066         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5067         (csky_unwind_pc): Delete.
5068         (csky_unwind_sp): Delete.
5069         (csky_gdbarch_init): Don't register deleted functions with
5070         gdbarch.
5071
5072 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5073
5074         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5075         (cris_unwind_pc): Delete.
5076         (cris_unwind_sp): Delete.
5077         (cris_gdbarch_init): Don't register deleted functions with
5078         gdbarch.
5079
5080 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5081
5082         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5083         (bfin_unwind_pc): Delete.
5084         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5085
5086 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5087
5088         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5089         (arm_unwind_pc): Delete.
5090         (arm_unwind_sp): Delete.
5091         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5092
5093 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5094
5095         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5096         (arc_unwind_pc): Delete.
5097         (arc_unwind_sp): Delete.
5098         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5099
5100 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5101
5102         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5103         (alpha_unwind_pc): Delete.
5104         (alpha_gdbarch_init): Don't register deleted functions with
5105         gdbarch.
5106
5107 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5108
5109         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5110         (aarch64_unwind_pc): Delete.
5111         (aarch64_unwind_sp): Delete.
5112         (aarch64_gdbarch_init): Don't register deleted functions with
5113         gdbarch.
5114
5115 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5116
5117         * gdbtypes.c (type_align): Don't consider static members when
5118         computing structure alignment.
5119
5120 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5121
5122         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5123         return 0 for other types.
5124         * arch-utils.c (default_type_align): Always return 0.
5125         * gdbarch.h: Regenerate.
5126         * gdbarch.sh (type_align): Extend comment.
5127         * gdbtypes.c (type_align): Add additional comments, always call
5128         gdbarch_type_align before applying the default rules.
5129         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5130         generic code will then apply a suitable default.
5131         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5132         types, return 0 for other types.
5133
5134 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5135
5136         * NEWS: Create a new section for the next release branch.
5137         Rename the section of the current branch, now that it has
5138         been cut.
5139
5140 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5141
5142         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5143         * version.in: Bump version to 8.3.50.DATE-git.
5144
5145 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5146
5147         * aix-thread.c (ptid_cmp): Remove unused variable.
5148         (get_signaled_thread): Likewise.
5149         (store_regs_user_thread): Likewise.
5150         (store_regs_kernel_thread): Likewise.
5151         (fetch_regs_kernel_thread): Remove shadowed variable.
5152
5153 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5154
5155         * features/riscv/32bit-cpu.xml: Add register numbers.
5156         * features/riscv/32bit-fpu.c: Regenerate.
5157         * features/riscv/32bit-fpu.xml: Add register numbers.
5158         * features/riscv/64bit-cpu.xml: Add register numbers.
5159         * features/riscv/64bit-fpu.c: Regenerate.
5160         * features/riscv/64bit-fpu.xml: Add register numbers.
5161
5162 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5163
5164         * NEWS: Mention two argument form of gdb.Value constructor.
5165         * python/py-value.c (convert_buffer_and_type_to_value): New
5166         function.
5167         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5168         Add support for handling an optional second argument.  Call
5169         convert_buffer_and_type_to_value as appropriate.
5170         * python/python-internal.h (Py_buffer_deleter): New struct.
5171         (Py_buffer_up): New typedef.
5172
5173 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5174
5175         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5176         instead of releasing ownership.
5177
5178 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5179
5180         * dwarf2read.c (open_and_init_dwp_file): Call
5181         elf_numsections instead of bfd_count_sections to initialize
5182         dwp_file->num_sections.
5183
5184 2019-02-25  Tom Tromey  <tromey@adacore.com>
5185
5186         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5187
5188 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5189
5190         * gcore.in: Add '--readnever' option when invoking GDB.
5191
5192 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5193
5194         * MAINTAINERS: Update my email address.
5195
5196 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5197
5198         * build-id.c (build_id_to_debug_bfd_1): New function.
5199         (build_id_to_debug_bfd): Look for separate debug file in
5200         sysroot.
5201
5202 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5203
5204         * gdbarch.sh: Update the copyright year range that is placed into
5205         generated files.
5206
5207 2019-02-22  Keith Seitz  <keiths@redhat.com>
5208
5209         PR symtab/23853
5210         * linespec.c (create_sals_line_offset): Search for the default
5211         symtab's filename instead of its fullname.
5212
5213 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5214
5215         * NEWS: Update style defaults.
5216
5217 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5218
5219         * main.c (captured_main_1): Disable styling in batch mode.
5220
5221 2019-02-20  Tom Tromey  <tom@tromey.com>
5222
5223         * symtab.c (symtab_symbol_info): Fix typos.
5224
5225 2019-02-20  Tom Tromey  <tromey@adacore.com>
5226
5227         * findcmd.c (_initialize_mem_search): Use upper case for
5228         metasyntactic variables.
5229
5230 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5231
5232         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5233         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5234
5235 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5236
5237         * top.h (source_file_name): Change to std::string.
5238         * top.c (source_file_name): Likewise.
5239         (command_line_input): Adjust.
5240         * cli/cli-script.c (script_from_file): Adjust.
5241
5242 2019-02-19  Tom Tromey  <tromey@adacore.com>
5243
5244         * ravenscar-thread.c
5245         (ravenscar_thread_target::update_thread_list): Don't call
5246         ada_build_task_list.
5247         * ada-lang.h (ada_build_task_list): Don't declare.
5248         * ada-tasks.c (struct ada_tasks_inferior_data)
5249         <task_list_valid_p>: Now bool.
5250         (read_known_tasks, ada_task_list_changed)
5251         (ada_tasks_invalidate_inferior_data): Update.
5252         (read_known_tasks_array): Return bool.
5253         (read_known_tasks_list): Likewise.
5254         (read_known_tasks): Return void.
5255         (ada_build_task_list): Now static.
5256
5257 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5258
5259         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5260         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5261
5262 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5263
5264         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5265         variant for ada_tasks_pspace_data_handle and
5266         ada_tasks_inferior_data_handle.
5267         (ada_tasks_pspace_data_cleanup): New function.
5268         (ada_tasks_inferior_data_cleanup): New function.
5269
5270 2019-02-17  Tom Tromey  <tom@tromey.com>
5271
5272         * macrotab.h (macro_source_fullname): Return a std::string.
5273         * macrotab.c (macro_include, check_for_redefinition)
5274         (macro_undef, macro_lookup_definition, foreach_macro)
5275         (foreach_macro_in_scope): Update.
5276         (macro_source_fullname): Return a std::string.
5277         * macrocmd.c (show_pp_source_pos): Update.
5278
5279 2019-02-17  Tom Tromey  <tom@tromey.com>
5280
5281         * macrocmd.c (show_pp_source_pos): Style the file names.
5282
5283 2019-02-17  Tom Tromey  <tom@tromey.com>
5284
5285         PR tui/24197:
5286         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5287
5288 2019-02-17  Tom Tromey  <tom@tromey.com>
5289
5290         * ada-lang.c (user_select_syms): Use filtered printing.
5291         * utils.c (wrap_style): New global.
5292         (desired_style): Remove.
5293         (emit_style_escape): Add stream parameter.
5294         (set_output_style, reset_terminal_style, prompt_for_continue):
5295         Update.
5296         (flush_wrap_buffer): Only flush gdb_stdout.
5297         (wrap_here): Set wrap_style.
5298         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5299         treat escape sequences as a character.  Change when wrap buffer is
5300         flushed.
5301         (fputs_styled): Do not set the output style when the default is
5302         requested.
5303         * ui-style.h (struct ui_file_style) <is_default>: New method.
5304         * source.c (print_source_lines_base): Emit escape sequences in one
5305         piece.
5306
5307 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5308
5309         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5310         integers and enumeration types.
5311
5312 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5313
5314         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5315         instead of lookup_symbol_in_language
5316         (do_exact_match): New function.
5317         (ada_get_symbol_name_matcher): Return do_exact_match when
5318         doing a verbatim match.
5319
5320 2019-02-15  Tom Tromey  <tromey@adacore.com>
5321
5322         * ravenscar-thread.c (ravenscar_thread_target::resume)
5323         (ravenscar_thread_target::wait): Special case wildcard requests.
5324
5325 2019-02-15  Tom Tromey  <tromey@adacore.com>
5326
5327         * ravenscar-thread.c (base_ptid): Remove.
5328         (struct ravenscar_thread_target) <close>: New method.
5329         <m_base_ptid>: New member.
5330         <update_inferior_ptid, active_task, task_is_currently_active,
5331         runtime_initialized>: Declare methods.
5332         <ravenscar_thread_target>: Add constructor.
5333         (ravenscar_thread_target::task_is_currently_active)
5334         (ravenscar_thread_target::update_inferior_ptid)
5335         (ravenscar_runtime_initialized): Rename.  Now methods.
5336         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5337         (ravenscar_thread_target::update_thread_list): Update.
5338         (ravenscar_thread_target::active_task): Now method.
5339         (ravenscar_thread_target::store_registers)
5340         (ravenscar_thread_target::prepare_to_store)
5341         (ravenscar_thread_target::prepare_to_store)
5342         (ravenscar_thread_target::mourn_inferior): Update.
5343         (ravenscar_inferior_created): Use "new" to create target.
5344         (ravenscar_thread_target::get_ada_task_ptid): Update.
5345         (_initialize_ravenscar): Don't initialize base_ptid.
5346         (ravenscar_ops): Remove global.
5347
5348 2019-02-15  Tom Tromey  <tromey@adacore.com>
5349
5350         * target.h (push_target): Declare new overload.
5351         * target.c (push_target): New overload, taking an rvalue reference.
5352         * remote.c (remote_target::open_1): Use push_target overload.
5353         * corelow.c (core_target_open): Use push_target overload.
5354
5355 2019-02-15  Tom Tromey  <tromey@adacore.com>
5356
5357         * ravenscar-thread.c (is_ravenscar_task)
5358         (ravenscar_task_is_currently_active): Return bool.
5359         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5360         (_initialize_ravenscar): Remove "(void)".
5361         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5362         Return bool.
5363
5364 2019-02-15  Tom Tromey  <tromey@adacore.com>
5365
5366         * ravenscar-thread.c (ravenscar_runtime_initializer)
5367         (has_ravenscar_runtime, get_running_thread_id)
5368         (ravenscar_thread_target::resume): Fix indentation.
5369
5370 2019-02-15  Tom Tromey  <tromey@adacore.com>
5371
5372         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5373         from ravenscar_arch_ops.
5374         (sparc_ravenscar_ops::fetch_registers)
5375         (sparc_ravenscar_ops::store_registers): Now methods.
5376         (sparc_ravenscar_prepare_to_store): Remove.
5377         (sparc_ravenscar_ops): Redefine.
5378         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5379         methods and destructor.  Remove members.
5380         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5381         (ravenscar_thread_target::store_registers)
5382         (ravenscar_thread_target::prepare_to_store): Update.
5383         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5384         Remove.
5385         (struct ppc_ravenscar_powerpc_ops): Derive from
5386         ravenscar_arch_ops.
5387         (ppc_ravenscar_powerpc_ops::fetch_registers)
5388         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5389         (ppc_ravenscar_powerpc_ops): Redefine.
5390         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5391         (ppc_ravenscar_e500_ops::fetch_registers)
5392         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5393         (ppc_ravenscar_e500_ops): Redefine.
5394         * aarch64-ravenscar-thread.c
5395         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5396         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5397         (aarch64_ravenscar_fetch_registers)
5398         (aarch64_ravenscar_store_registers): Now methods.
5399         (aarch64_ravenscar_ops): Redefine.
5400
5401 2019-02-15  Tom Tromey  <tromey@adacore.com>
5402
5403         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5404         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5405         (ravenscar_thread_target::stopped_by_watchpoint)
5406         (ravenscar_thread_target::stopped_data_address)
5407         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5408
5409 2019-02-15  Tom Tromey  <tromey@adacore.com>
5410
5411         * ravenscar-thread.c: Fix some typos.
5412
5413 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5414             Tom Tromey  <tromey@adacore.com>
5415
5416         * ada-lang.c (ada_exception_sal): Change addr_string to a
5417         std::string.
5418         (create_ada_exception_catchpoint): Update.
5419
5420 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5421             Tom Tromey  <tromey@adacore.com>
5422
5423         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5424         (bp_location_ops): Remove.
5425         (base_breakpoint_allocate_location): Update.
5426         (free_bp_location): Update.
5427         * ada-lang.c (class ada_catchpoint_location)
5428         <ada_catchpoint_location>: Remove ops parameter.
5429         (ada_catchpoint_location_dtor): Remove.
5430         (ada_catchpoint_location_ops): Remove.
5431         (allocate_location_exception): Update.
5432         * breakpoint.h (struct bp_location_ops): Remove.
5433         (class bp_location) <bp_location>: Remove bp_location_ops
5434         parameter.
5435         <~bp_location>: Add destructor.
5436         <ops>: Remove.
5437
5438 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5439             Pedro Alves  <palves@redhat.com>
5440
5441         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5442         'PATH_MAX'.
5443
5444 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5445             Samuel Thibault  <samuel.thibault@gnu.org>
5446             Thomas Schwinge  <thomas@codesourcery.com>
5447
5448         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5449         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5450
5451 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5452
5453         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5454         (check_empty): Use "const char *".
5455
5456         * gnu-nat.c (gnu_nat_target::detach): Instead of
5457         'detach_inferior (pid)' call
5458         'detach_inferior (find_inferior_pid (pid))'.
5459
5460         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5461         'nat/fork-inferior.o'.
5462         * gnu-nat.c: #include "nat/fork-inferior.h".
5463
5464         * gnu-nat.c (gnu_nat_target::detach): Instead of
5465         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5466         * gnu-nat.h: #include "inf-child.h".
5467         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5468         'i386_gnu_nat_target::fetch_registers'.
5469         (gnu_store_registers): Rename/move to
5470         'i386_gnu_nat_target::store_registers'.
5471
5472         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5473         * gnu-nat.h (mach_thread_info): New function.
5474         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5475
5476         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5477
5478 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5479
5480         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5481
5482 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5483
5484         * windows-nat.c (windows_add_thread): Add new parameter
5485         "main_thread_p" with default value set to false.  Update
5486         function documentation as well as all callers.
5487         (windows_delete_thread): Likewise.
5488         (fake_create_process): Update call to windows_add_thread.
5489         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5490         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5491         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5492         call to windows_delete_thread.
5493
5494 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5495
5496         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5497
5498 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5499
5500         * symfile.c (find_separate_debug_file): Use canonical path of
5501         sysroot with child_path instead of gdb_sysroot if it is valid.
5502
5503 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5504
5505         * symfile.c (find_separate_debug_file): Use child_path to
5506         determine if an object file is under a sysroot.
5507
5508 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5509
5510         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5511         unittests/child-path-selftests.c.
5512         * common/pathstuff.c (child_path): New function.
5513         * common/pathstuff.h (child_path): New prototype.
5514         * unittests/child-path-selftests.c: New file.
5515
5516 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5517
5518         * symfile.c (find_separate_debug_file): Look for separate debug
5519         files in debug directories under the sysroot.
5520
5521 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5522
5523         * symtab.h (struct minimal_symbol data_p): New const method.
5524         (struct minimal_symbol text_p): Likewise.
5525         * symtab.c (output_source_filename): Use file name style
5526         to print file name.
5527         (print_symbol_info): Likewise.
5528         (print_msymbol_info): Use address style to print addresses.
5529         Use function name style to print executable text symbols.
5530         (expand_symtab_containing_pc): Use data_p.
5531         (find_pc_sect_compunit_symtab): Likewise.
5532
5533 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5534
5535         * breakpoint.c (describe_other_breakpoints): Use address style
5536         to print addresses.
5537         (say_where): Likewise.
5538
5539 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5540
5541         * ada-typeprint.c (print_func_type): Print function name
5542         style to print function name.
5543         * c-typeprint.c (c_print_type_1): Likewise.
5544
5545 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5546
5547         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5548         for execve.
5549
5550 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5551
5552         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5553         type_stack.
5554
5555 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5556
5557         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5558         TYPE_CODE_REF types.
5559
5560 2019-02-08  Jim Wilson  <jimw@sifive.com>
5561
5562         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5563         (riscv_linux_fregset): New.
5564         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5565
5566 2019-02-07  Tom Tromey  <tom@tromey.com>
5567
5568         * thread.c (thread_cancel_execution_command): Update.
5569         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5570         methods.
5571         (struct thread_fsm_ops): Remove.
5572         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5573         (thread_fsm_should_stop, thread_fsm_return_value)
5574         (thread_fsm_set_finished, thread_fsm_finished_p)
5575         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5576         Don't declare.
5577         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5578         * infrun.c (clear_proceed_status_thread)
5579         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5580         (print_stop_event): Update.
5581         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5582         Add constructor.
5583         (step_command_fsm_ops): Remove.
5584         (new_step_command_fsm): Remove.
5585         (step_1): Update.
5586         (step_command_fsm::should_stop): Rename from
5587         step_command_fsm_should_stop.
5588         (step_command_fsm::clean_up): Rename from
5589         step_command_fsm_clean_up.
5590         (step_command_fsm::do_async_reply_reason): Rename from
5591         step_command_fsm_async_reply_reason.
5592         (struct until_next_fsm): Inherit from thread_fsm.  Add
5593         constructor.
5594         (until_next_fsm_ops): Remove.
5595         (new_until_next_fsm): Remove.
5596         (until_next_fsm::should_stop): Rename from
5597         until_next_fsm_should_stop.
5598         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5599         (until_next_fsm::do_async_reply_reason): Rename from
5600         until_next_fsm_async_reply_reason.
5601         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5602         constructor.  Change type of breakpoint.
5603         (finish_command_fsm_ops): Remove.
5604         (new_finish_command_fsm): Remove.
5605         (finish_command_fsm::should_stop): Rename from
5606         finish_command_fsm_should_stop.
5607         (finish_command_fsm::clean_up): Rename from
5608         finish_command_fsm_clean_up.
5609         (finish_command_fsm::return_value): Rename from
5610         finish_command_fsm_return_value.
5611         (finish_command_fsm::do_async_reply_reason): Rename from
5612         finish_command_fsm_async_reply_reason.
5613         (finish_command): Update.
5614         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5615         Add constructor.
5616         (call_thread_fsm_ops): Remove.
5617         (call_thread_fsm::call_thread_fsm): Rename from
5618         new_call_thread_fsm.
5619         (call_thread_fsm::should_stop): Rename from
5620         call_thread_fsm_should_stop.
5621         (call_thread_fsm::should_notify_stop): Rename from
5622         call_thread_fsm_should_notify_stop.
5623         (run_inferior_call, call_function_by_hand_dummy): Update.
5624         * cli/cli-interp.c (should_print_stop_to_console): Update.
5625         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5626         Add constructor.  Change type of location_breakpoint,
5627         caller_breakpoint.
5628         (until_break_fsm_ops): Remove.
5629         (new_until_break_fsm): Remove.
5630         (until_break_fsm::should_stop): Rename from
5631         until_break_fsm_should_stop.
5632         (until_break_fsm::clean_up): Rename from
5633         until_break_fsm_clean_up.
5634         (until_break_fsm::do_async_reply_reason): Rename from
5635         until_break_fsm_async_reply_reason.
5636         (until_break_command): Update.
5637         * thread-fsm.c: Remove.
5638         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5639
5640 2019-02-07  Tom Tromey  <tom@tromey.com>
5641
5642         * yy-remap.h: Add include guard.
5643         * xtensa-tdep.h: Add include guard.
5644         * xcoffread.h: Rename include guard.
5645         * varobj-iter.h: Add include guard.
5646         * tui/tui.h: Rename include guard.
5647         * tui/tui-winsource.h: Rename include guard.
5648         * tui/tui-wingeneral.h: Rename include guard.
5649         * tui/tui-windata.h: Rename include guard.
5650         * tui/tui-win.h: Rename include guard.
5651         * tui/tui-stack.h: Rename include guard.
5652         * tui/tui-source.h: Rename include guard.
5653         * tui/tui-regs.h: Rename include guard.
5654         * tui/tui-out.h: Rename include guard.
5655         * tui/tui-layout.h: Rename include guard.
5656         * tui/tui-io.h: Rename include guard.
5657         * tui/tui-hooks.h: Rename include guard.
5658         * tui/tui-file.h: Rename include guard.
5659         * tui/tui-disasm.h: Rename include guard.
5660         * tui/tui-data.h: Rename include guard.
5661         * tui/tui-command.h: Rename include guard.
5662         * tic6x-tdep.h: Add include guard.
5663         * target/waitstatus.h: Rename include guard.
5664         * target/wait.h: Rename include guard.
5665         * target/target.h: Rename include guard.
5666         * target/resume.h: Rename include guard.
5667         * target-float.h: Rename include guard.
5668         * stabsread.h: Add include guard.
5669         * rs6000-tdep.h: Add include guard.
5670         * riscv-fbsd-tdep.h: Add include guard.
5671         * regformats/regdef.h: Rename include guard.
5672         * record.h: Rename include guard.
5673         * python/python.h: Rename include guard.
5674         * python/python-internal.h: Rename include guard.
5675         * python/py-stopevent.h: Rename include guard.
5676         * python/py-ref.h: Rename include guard.
5677         * python/py-record.h: Rename include guard.
5678         * python/py-record-full.h: Rename include guard.
5679         * python/py-record-btrace.h: Rename include guard.
5680         * python/py-instruction.h: Rename include guard.
5681         * python/py-events.h: Rename include guard.
5682         * python/py-event.h: Rename include guard.
5683         * procfs.h: Add include guard.
5684         * proc-utils.h: Add include guard.
5685         * p-lang.h: Add include guard.
5686         * or1k-tdep.h: Rename include guard.
5687         * observable.h: Rename include guard.
5688         * nto-tdep.h: Rename include guard.
5689         * nat/x86-linux.h: Rename include guard.
5690         * nat/x86-linux-dregs.h: Rename include guard.
5691         * nat/x86-gcc-cpuid.h: Add include guard.
5692         * nat/x86-dregs.h: Rename include guard.
5693         * nat/x86-cpuid.h: Rename include guard.
5694         * nat/ppc-linux.h: Rename include guard.
5695         * nat/mips-linux-watch.h: Rename include guard.
5696         * nat/linux-waitpid.h: Rename include guard.
5697         * nat/linux-ptrace.h: Rename include guard.
5698         * nat/linux-procfs.h: Rename include guard.
5699         * nat/linux-osdata.h: Rename include guard.
5700         * nat/linux-nat.h: Rename include guard.
5701         * nat/linux-namespaces.h: Rename include guard.
5702         * nat/linux-btrace.h: Rename include guard.
5703         * nat/glibc_thread_db.h: Rename include guard.
5704         * nat/gdb_thread_db.h: Rename include guard.
5705         * nat/gdb_ptrace.h: Rename include guard.
5706         * nat/fork-inferior.h: Rename include guard.
5707         * nat/amd64-linux-siginfo.h: Rename include guard.
5708         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5709         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5710         * nat/aarch64-linux.h: Rename include guard.
5711         * nat/aarch64-linux-hw-point.h: Rename include guard.
5712         * mn10300-tdep.h: Add include guard.
5713         * mips-linux-tdep.h: Add include guard.
5714         * mi/mi-parse.h: Rename include guard.
5715         * mi/mi-out.h: Rename include guard.
5716         * mi/mi-main.h: Rename include guard.
5717         * mi/mi-interp.h: Rename include guard.
5718         * mi/mi-getopt.h: Rename include guard.
5719         * mi/mi-console.h: Rename include guard.
5720         * mi/mi-common.h: Rename include guard.
5721         * mi/mi-cmds.h: Rename include guard.
5722         * mi/mi-cmd-break.h: Rename include guard.
5723         * m2-lang.h: Add include guard.
5724         * location.h: Rename include guard.
5725         * linux-record.h: Rename include guard.
5726         * linux-nat.h: Add include guard.
5727         * linux-fork.h: Add include guard.
5728         * i386-darwin-tdep.h: Rename include guard.
5729         * hppa-linux-offsets.h: Add include guard.
5730         * guile/guile.h: Rename include guard.
5731         * guile/guile-internal.h: Rename include guard.
5732         * gnu-nat.h: Rename include guard.
5733         * gdb-stabs.h: Rename include guard.
5734         * frv-tdep.h: Add include guard.
5735         * f-lang.h: Add include guard.
5736         * event-loop.h: Add include guard.
5737         * darwin-nat.h: Rename include guard.
5738         * cp-abi.h: Rename include guard.
5739         * config/sparc/nm-sol2.h: Rename include guard.
5740         * config/nm-nto.h: Rename include guard.
5741         * config/nm-linux.h: Add include guard.
5742         * config/i386/nm-i386gnu.h: Rename include guard.
5743         * config/djgpp/nl_types.h: Rename include guard.
5744         * config/djgpp/langinfo.h: Rename include guard.
5745         * compile/gcc-cp-plugin.h: Add include guard.
5746         * compile/gcc-c-plugin.h: Add include guard.
5747         * compile/compile.h: Rename include guard.
5748         * compile/compile-object-run.h: Rename include guard.
5749         * compile/compile-object-load.h: Rename include guard.
5750         * compile/compile-internal.h: Rename include guard.
5751         * compile/compile-cplus.h: Rename include guard.
5752         * compile/compile-c.h: Rename include guard.
5753         * common/xml-utils.h: Rename include guard.
5754         * common/x86-xstate.h: Rename include guard.
5755         * common/version.h: Rename include guard.
5756         * common/vec.h: Rename include guard.
5757         * common/tdesc.h: Rename include guard.
5758         * common/selftest.h: Rename include guard.
5759         * common/scoped_restore.h: Rename include guard.
5760         * common/scoped_mmap.h: Rename include guard.
5761         * common/scoped_fd.h: Rename include guard.
5762         * common/safe-iterator.h: Rename include guard.
5763         * common/run-time-clock.h: Rename include guard.
5764         * common/refcounted-object.h: Rename include guard.
5765         * common/queue.h: Rename include guard.
5766         * common/ptid.h: Rename include guard.
5767         * common/print-utils.h: Rename include guard.
5768         * common/preprocessor.h: Rename include guard.
5769         * common/pathstuff.h: Rename include guard.
5770         * common/observable.h: Rename include guard.
5771         * common/netstuff.h: Rename include guard.
5772         * common/job-control.h: Rename include guard.
5773         * common/host-defs.h: Rename include guard.
5774         * common/gdb_wait.h: Rename include guard.
5775         * common/gdb_vecs.h: Rename include guard.
5776         * common/gdb_unlinker.h: Rename include guard.
5777         * common/gdb_unique_ptr.h: Rename include guard.
5778         * common/gdb_tilde_expand.h: Rename include guard.
5779         * common/gdb_sys_time.h: Rename include guard.
5780         * common/gdb_string_view.h: Rename include guard.
5781         * common/gdb_splay_tree.h: Rename include guard.
5782         * common/gdb_setjmp.h: Rename include guard.
5783         * common/gdb_ref_ptr.h: Rename include guard.
5784         * common/gdb_optional.h: Rename include guard.
5785         * common/gdb_locale.h: Rename include guard.
5786         * common/gdb_assert.h: Rename include guard.
5787         * common/filtered-iterator.h: Rename include guard.
5788         * common/filestuff.h: Rename include guard.
5789         * common/fileio.h: Rename include guard.
5790         * common/environ.h: Rename include guard.
5791         * common/common-utils.h: Rename include guard.
5792         * common/common-types.h: Rename include guard.
5793         * common/common-regcache.h: Rename include guard.
5794         * common/common-inferior.h: Rename include guard.
5795         * common/common-gdbthread.h: Rename include guard.
5796         * common/common-exceptions.h: Rename include guard.
5797         * common/common-defs.h: Rename include guard.
5798         * common/common-debug.h: Rename include guard.
5799         * common/cleanups.h: Rename include guard.
5800         * common/buffer.h: Rename include guard.
5801         * common/btrace-common.h: Rename include guard.
5802         * common/break-common.h: Rename include guard.
5803         * cli/cli-utils.h: Rename include guard.
5804         * cli/cli-style.h: Rename include guard.
5805         * cli/cli-setshow.h: Rename include guard.
5806         * cli/cli-script.h: Rename include guard.
5807         * cli/cli-interp.h: Rename include guard.
5808         * cli/cli-decode.h: Rename include guard.
5809         * cli/cli-cmds.h: Rename include guard.
5810         * charset-list.h: Add include guard.
5811         * buildsym-legacy.h: Rename include guard.
5812         * bfin-tdep.h: Add include guard.
5813         * ax.h: Rename include guard.
5814         * arm-linux-tdep.h: Add include guard.
5815         * arm-fbsd-tdep.h: Add include guard.
5816         * arch/xtensa.h: Rename include guard.
5817         * arch/tic6x.h: Add include guard.
5818         * arch/i386.h: Add include guard.
5819         * arch/arm.h: Rename include guard.
5820         * arch/arm-linux.h: Rename include guard.
5821         * arch/arm-get-next-pcs.h: Rename include guard.
5822         * arch/amd64.h: Add include guard.
5823         * arch/aarch64-insn.h: Rename include guard.
5824         * arch-utils.h: Rename include guard.
5825         * annotate.h: Add include guard.
5826         * amd64-darwin-tdep.h: Rename include guard.
5827         * aarch64-linux-tdep.h: Add include guard.
5828         * aarch64-fbsd-tdep.h: Add include guard.
5829         * aarch32-linux-nat.h: Add include guard.
5830
5831 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5832
5833         * macrotab.c (macro_define_internal): New function that
5834         factorizes macro_define_object_internal and macro_define_function
5835         code.
5836         (macro_define_object_internal): Use macro_define_internal.
5837         (macro_define_function): Likewise.
5838
5839 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5840
5841         * macrocmd.c (extract_identifier): Return
5842         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5843         callers.
5844
5845 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5846
5847         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5848
5849 2019-02-05  Tom Tromey  <tom@tromey.com>
5850
5851         * target.c (target_stack::unpush): Move assertion earlier.
5852
5853 2019-01-30  Tom Tromey  <tom@tromey.com>
5854
5855         PR python/23615:
5856         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5857         (gdbpy_parse_and_eval): Likewise.
5858         * python/python-internal.h (gdbpy_allow_threads): New class.
5859
5860 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5861
5862         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5863         (aarch64_fbsd_fpregmap): Move earlier.
5864         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5865         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5866         instead of individual calls to trad_frame_set_reg_addr.
5867         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5868         earlier.
5869         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5870         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5871         instead of individual calls to trad_frame_set_reg_addr.
5872
5873 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5874
5875         * CONTRIBUTE: Replace contribution list with wiki link.
5876
5877 2019-01-25  Tom Tromey  <tom@tromey.com>
5878
5879         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5880
5881 2019-01-25  Tom Tromey  <tom@tromey.com>
5882
5883         * xtensa-linux-nat.c: Fix common/ includes.
5884         * xml-support.h: Fix common/ includes.
5885         * xml-support.c: Fix common/ includes.
5886         * x86-linux-nat.c: Fix common/ includes.
5887         * windows-nat.c: Fix common/ includes.
5888         * varobj.h: Fix common/ includes.
5889         * varobj.c: Fix common/ includes.
5890         * value.c: Fix common/ includes.
5891         * valops.c: Fix common/ includes.
5892         * utils.c: Fix common/ includes.
5893         * unittests/xml-utils-selftests.c: Fix common/ includes.
5894         * unittests/utils-selftests.c: Fix common/ includes.
5895         * unittests/unpack-selftests.c: Fix common/ includes.
5896         * unittests/tracepoint-selftests.c: Fix common/ includes.
5897         * unittests/style-selftests.c: Fix common/ includes.
5898         * unittests/string_view-selftests.c: Fix common/ includes.
5899         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5900         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5901         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5902         * unittests/rsp-low-selftests.c: Fix common/ includes.
5903         * unittests/parse-connection-spec-selftests.c: Fix common/
5904         includes.
5905         * unittests/optional-selftests.c: Fix common/ includes.
5906         * unittests/offset-type-selftests.c: Fix common/ includes.
5907         * unittests/observable-selftests.c: Fix common/ includes.
5908         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5909         * unittests/memrange-selftests.c: Fix common/ includes.
5910         * unittests/memory-map-selftests.c: Fix common/ includes.
5911         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5912         * unittests/function-view-selftests.c: Fix common/ includes.
5913         * unittests/environ-selftests.c: Fix common/ includes.
5914         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5915         * unittests/common-utils-selftests.c: Fix common/ includes.
5916         * unittests/cli-utils-selftests.c: Fix common/ includes.
5917         * unittests/array-view-selftests.c: Fix common/ includes.
5918         * ui-file.c: Fix common/ includes.
5919         * tui/tui-io.c: Fix common/ includes.
5920         * tracepoint.h: Fix common/ includes.
5921         * tracepoint.c: Fix common/ includes.
5922         * tracefile-tfile.c: Fix common/ includes.
5923         * top.h: Fix common/ includes.
5924         * top.c: Fix common/ includes.
5925         * thread.c: Fix common/ includes.
5926         * target/waitstatus.h: Fix common/ includes.
5927         * target/waitstatus.c: Fix common/ includes.
5928         * target.h: Fix common/ includes.
5929         * target.c: Fix common/ includes.
5930         * target-memory.c: Fix common/ includes.
5931         * target-descriptions.c: Fix common/ includes.
5932         * symtab.h: Fix common/ includes.
5933         * symfile.c: Fix common/ includes.
5934         * stap-probe.c: Fix common/ includes.
5935         * spu-linux-nat.c: Fix common/ includes.
5936         * sparc-nat.c: Fix common/ includes.
5937         * source.c: Fix common/ includes.
5938         * solib.c: Fix common/ includes.
5939         * solib-target.c: Fix common/ includes.
5940         * ser-unix.c: Fix common/ includes.
5941         * ser-tcp.c: Fix common/ includes.
5942         * ser-pipe.c: Fix common/ includes.
5943         * ser-base.c: Fix common/ includes.
5944         * selftest-arch.c: Fix common/ includes.
5945         * s12z-tdep.c: Fix common/ includes.
5946         * rust-exp.y: Fix common/ includes.
5947         * rs6000-aix-tdep.c: Fix common/ includes.
5948         * riscv-tdep.c: Fix common/ includes.
5949         * remote.c: Fix common/ includes.
5950         * remote-notif.h: Fix common/ includes.
5951         * remote-fileio.h: Fix common/ includes.
5952         * remote-fileio.c: Fix common/ includes.
5953         * regcache.h: Fix common/ includes.
5954         * regcache.c: Fix common/ includes.
5955         * record-btrace.c: Fix common/ includes.
5956         * python/python.c: Fix common/ includes.
5957         * python/py-type.c: Fix common/ includes.
5958         * python/py-inferior.c: Fix common/ includes.
5959         * progspace.h: Fix common/ includes.
5960         * producer.c: Fix common/ includes.
5961         * procfs.c: Fix common/ includes.
5962         * proc-api.c: Fix common/ includes.
5963         * printcmd.c: Fix common/ includes.
5964         * ppc-linux-nat.c: Fix common/ includes.
5965         * parser-defs.h: Fix common/ includes.
5966         * osdata.c: Fix common/ includes.
5967         * obsd-nat.c: Fix common/ includes.
5968         * nat/x86-linux.c: Fix common/ includes.
5969         * nat/x86-linux-dregs.c: Fix common/ includes.
5970         * nat/x86-dregs.h: Fix common/ includes.
5971         * nat/x86-dregs.c: Fix common/ includes.
5972         * nat/ppc-linux.c: Fix common/ includes.
5973         * nat/mips-linux-watch.h: Fix common/ includes.
5974         * nat/mips-linux-watch.c: Fix common/ includes.
5975         * nat/linux-waitpid.c: Fix common/ includes.
5976         * nat/linux-ptrace.h: Fix common/ includes.
5977         * nat/linux-ptrace.c: Fix common/ includes.
5978         * nat/linux-procfs.c: Fix common/ includes.
5979         * nat/linux-personality.c: Fix common/ includes.
5980         * nat/linux-osdata.c: Fix common/ includes.
5981         * nat/linux-namespaces.c: Fix common/ includes.
5982         * nat/linux-btrace.h: Fix common/ includes.
5983         * nat/linux-btrace.c: Fix common/ includes.
5984         * nat/fork-inferior.c: Fix common/ includes.
5985         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5986         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5987         * nat/aarch64-linux.c: Fix common/ includes.
5988         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5989         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5990         * namespace.h: Fix common/ includes.
5991         * mips-linux-tdep.c: Fix common/ includes.
5992         * minsyms.c: Fix common/ includes.
5993         * mi/mi-parse.h: Fix common/ includes.
5994         * mi/mi-main.c: Fix common/ includes.
5995         * mi/mi-cmd-env.c: Fix common/ includes.
5996         * memrange.h: Fix common/ includes.
5997         * memattr.c: Fix common/ includes.
5998         * maint.h: Fix common/ includes.
5999         * maint.c: Fix common/ includes.
6000         * main.c: Fix common/ includes.
6001         * machoread.c: Fix common/ includes.
6002         * location.c: Fix common/ includes.
6003         * linux-thread-db.c: Fix common/ includes.
6004         * linux-nat.c: Fix common/ includes.
6005         * linux-fork.c: Fix common/ includes.
6006         * inline-frame.c: Fix common/ includes.
6007         * infrun.c: Fix common/ includes.
6008         * inflow.c: Fix common/ includes.
6009         * inferior.h: Fix common/ includes.
6010         * inferior.c: Fix common/ includes.
6011         * infcmd.c: Fix common/ includes.
6012         * inf-ptrace.c: Fix common/ includes.
6013         * inf-child.c: Fix common/ includes.
6014         * ia64-linux-nat.c: Fix common/ includes.
6015         * i387-tdep.c: Fix common/ includes.
6016         * i386-tdep.c: Fix common/ includes.
6017         * i386-linux-tdep.c: Fix common/ includes.
6018         * i386-linux-nat.c: Fix common/ includes.
6019         * i386-go32-tdep.c: Fix common/ includes.
6020         * i386-fbsd-tdep.c: Fix common/ includes.
6021         * i386-fbsd-nat.c: Fix common/ includes.
6022         * guile/scm-type.c: Fix common/ includes.
6023         * guile/guile.c: Fix common/ includes.
6024         * go32-nat.c: Fix common/ includes.
6025         * gnu-nat.c: Fix common/ includes.
6026         * gdbthread.h: Fix common/ includes.
6027         * gdbarch-selftests.c: Fix common/ includes.
6028         * gdb_usleep.c: Fix common/ includes.
6029         * gdb_select.h: Fix common/ includes.
6030         * gdb_bfd.c: Fix common/ includes.
6031         * gcore.c: Fix common/ includes.
6032         * fork-child.c: Fix common/ includes.
6033         * findvar.c: Fix common/ includes.
6034         * fbsd-nat.c: Fix common/ includes.
6035         * event-top.c: Fix common/ includes.
6036         * event-loop.c: Fix common/ includes.
6037         * dwarf2read.c: Fix common/ includes.
6038         * dwarf2loc.c: Fix common/ includes.
6039         * dwarf2-frame.c: Fix common/ includes.
6040         * dwarf-index-cache.c: Fix common/ includes.
6041         * dtrace-probe.c: Fix common/ includes.
6042         * disasm-selftests.c: Fix common/ includes.
6043         * defs.h: Fix common/ includes.
6044         * csky-tdep.c: Fix common/ includes.
6045         * cp-valprint.c: Fix common/ includes.
6046         * cp-support.h: Fix common/ includes.
6047         * cp-support.c: Fix common/ includes.
6048         * corelow.c: Fix common/ includes.
6049         * completer.h: Fix common/ includes.
6050         * completer.c: Fix common/ includes.
6051         * compile/compile.c: Fix common/ includes.
6052         * compile/compile-loc2c.c: Fix common/ includes.
6053         * compile/compile-cplus-types.c: Fix common/ includes.
6054         * compile/compile-cplus-symbols.c: Fix common/ includes.
6055         * command.h: Fix common/ includes.
6056         * cli/cli-dump.c: Fix common/ includes.
6057         * cli/cli-cmds.c: Fix common/ includes.
6058         * charset.c: Fix common/ includes.
6059         * build-id.c: Fix common/ includes.
6060         * btrace.h: Fix common/ includes.
6061         * btrace.c: Fix common/ includes.
6062         * breakpoint.h: Fix common/ includes.
6063         * breakpoint.c: Fix common/ includes.
6064         * ax.h:
6065         (enum agent_op): Fix common/ includes.
6066         * ax-general.c (struct aop_map): Fix common/ includes.
6067         * ax-gdb.c: Fix common/ includes.
6068         * auxv.c: Fix common/ includes.
6069         * auto-load.c: Fix common/ includes.
6070         * arm-tdep.c: Fix common/ includes.
6071         * arch/riscv.c: Fix common/ includes.
6072         * arch/ppc-linux-common.c: Fix common/ includes.
6073         * arch/i386.c: Fix common/ includes.
6074         * arch/arm.c: Fix common/ includes.
6075         * arch/arm-linux.c: Fix common/ includes.
6076         * arch/arm-get-next-pcs.c: Fix common/ includes.
6077         * arch/amd64.c: Fix common/ includes.
6078         * arch/aarch64.c: Fix common/ includes.
6079         * arch/aarch64-insn.c: Fix common/ includes.
6080         * arch-utils.c: Fix common/ includes.
6081         * amd64-windows-tdep.c: Fix common/ includes.
6082         * amd64-tdep.c: Fix common/ includes.
6083         * amd64-sol2-tdep.c: Fix common/ includes.
6084         * amd64-obsd-tdep.c: Fix common/ includes.
6085         * amd64-nbsd-tdep.c: Fix common/ includes.
6086         * amd64-linux-tdep.c: Fix common/ includes.
6087         * amd64-linux-nat.c: Fix common/ includes.
6088         * amd64-fbsd-tdep.c: Fix common/ includes.
6089         * amd64-fbsd-nat.c: Fix common/ includes.
6090         * amd64-dicos-tdep.c: Fix common/ includes.
6091         * amd64-darwin-tdep.c: Fix common/ includes.
6092         * agent.c: Fix common/ includes.
6093         * ada-lang.h: Fix common/ includes.
6094         * ada-lang.c: Fix common/ includes.
6095         * aarch64-tdep.c: Fix common/ includes.
6096
6097 2019-01-25  Tom Tromey  <tom@tromey.com>
6098
6099         * common/create-version.sh: Use common/version.h.
6100
6101 2019-01-24  Pedro Alves  <palves@redhat.com>
6102
6103         * infrun.c (signal_stop, signal_print, signal_program)
6104         (signal_catch, signal_pass): Now arrays instead of pointers.
6105         (update_signals_program_target, do_target_resume)
6106         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6107         * linux-nat.c (linux_nat_target::pass_signals)
6108         (linux_nat_target::create_inferior, linux_nat_target::attach):
6109         Adjust.
6110         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6111         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6112         * procfs.c (procfs_target::pass_signals): Adjust.
6113         * record-full.c (record_full_target::resume): Adjust.
6114         * remote.c (remote_target::pass_signals)
6115         (remote_target::program_signals): Adjust.
6116         * target-debug.h (target_debug_print_signals): Now takes a
6117         gdb::array_view as parameter.  Adjust.
6118         * target.h (target_ops) <pass_signals, program_signals>: Replace
6119         pointer and length parameters with gdb::array_view.
6120         (target_pass_signals, target_program_signals): Likewise.
6121         * target-delegates.c: Regenerate.
6122
6123 2019-01-24  Pedro Alves  <palves@redhat.com>
6124
6125         * common/forward-scope-exit.h
6126         (forward_scope_exit::forward_scope_exit): Pass arguments to
6127         m_bind_function directly, instead of creating a std::bind and
6128         copying that.
6129
6130 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6131
6132         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6133         for static members.
6134         (pass_in_v_vfp_candidate): Likewise.
6135
6136 2019-01-23  Tom Tromey  <tom@tromey.com>
6137             Pedro Alves  <palves@redhat.com>
6138
6139         * regcache.c (class regcache_invalidator): Remove.
6140         (regcache::raw_write): Use make_scope_exit.
6141
6142 2019-01-23  Tom Tromey  <tom@tromey.com>
6143
6144         * ui-out.h (class ui_out_emit_type): Update comment.
6145
6146 2019-01-23  Tom Tromey  <tom@tromey.com>
6147
6148         * infrun.c (fetch_inferior_event): Update comment.
6149
6150 2019-01-23  Tom Tromey  <tom@tromey.com>
6151             Pedro Alves  <palves@redhat.com>
6152
6153         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6154         parameter.
6155         (fetch_inferior_event): Use SCOPE_EXIT.
6156
6157
6158 2019-01-23  Tom Tromey  <tom@tromey.com>
6159             Pedro Alves  <palves@redhat.com>
6160
6161         * infrun.c (disable_thread_events): Delete.
6162         (stop_all_threads): Use SCOPE_EXIT.
6163
6164 2019-01-23  Tom Tromey  <tom@tromey.com>
6165             Pedro Alves  <palves@redhat.com>
6166
6167         * symfile.c: Include forward-scope-exit.h.
6168         (clear_symtab_users_cleanup): Replace forward declaration with
6169         a FORWARD_SCOPE_EXIT.
6170         (syms_from_objfile_1): Use the forward_scope_exit and
6171         gdb::optional instead of cleanup_function.
6172         (reread_symbols): Use the forward_scope_exit instead of
6173         cleanup_function.
6174         (clear_symtab_users_cleanup): Remove function.
6175
6176 2019-01-23  Tom Tromey  <tom@tromey.com>
6177             Pedro Alves  <palves@redhat.com>
6178
6179         * linux-nat.c: Include scope-exit.h.
6180         (cleanup_target_stop): Remove.
6181         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6182         SCOPE_EXIT.
6183
6184 2019-01-23  Tom Tromey  <tom@tromey.com>
6185             Pedro Alves  <palves@redhat.com>
6186
6187         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6188         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6189
6190 2019-01-23  Tom Tromey  <tom@tromey.com>
6191             Andrew Burgess  <andrew.burgess@embecosm.com>
6192             Pedro Alves  <palves@redhat.com>
6193
6194         * infrun.c (fetch_inferior_event): Use scope_exit.
6195         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6196         * top.c (execute_command): Use scope_exit.
6197         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6198         * utils.c (do_bpstat_clear_actions_cleanup)
6199         (make_bpstat_clear_actions_cleanup): Remove.
6200
6201 2019-01-23  Tom Tromey  <tom@tromey.com>
6202             Pedro Alves  <palves@redhat.com>
6203
6204         * infrun.c: Include "common/scope-exit.h"
6205         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6206         (wait_for_inferior): Use SCOPE_EXIT.
6207         (fetch_inferior_event): Use scope_exit.
6208
6209 2019-01-23  Tom Tromey  <tom@tromey.com>
6210             Pedro Alves  <palves@redhat.com>
6211
6212         * breakpoint.c (create_breakpoint): Remove cleanup.
6213
6214 2019-01-23  Tom Tromey  <tom@tromey.com>
6215             Andrew Burgess  <andrew.burgess@embecosm.com>
6216             Pedro Alves  <palves@redhat.com>
6217
6218 2019-01-23  Pedro Alves  <palves@redhat.com>
6219
6220         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6221
6222 2019-01-23  Pedro Alves  <palves@redhat.com>
6223             Andrew Burgess  <andrew.burgess@embecosm.com>
6224
6225         * gdbthread.h: Include "common/forward-scope-exit.h".
6226         (scoped_finish_thread_state): Redefine custom class in terms of
6227         forward_scope_exit.
6228
6229 2019-01-23  Pedro Alves  <palves@redhat.com>
6230             Andrew Burgess  <andrew.burgess@embecosm.com>
6231
6232         * common/forward-scope-exit.h: New file.
6233
6234 2019-01-23  Pedro Alves  <palves@redhat.com>
6235             Andrew Burgess  <andrew.burgess@embecosm.com>
6236             Tom Tromey  <tom@tromey.com>
6237
6238         * common/scope-exit.h: New file.
6239
6240 2019-01-23  Pedro Alves  <palves@redhat.com>
6241
6242         * common/preprocessor.h (ESC): Rename to ...
6243         (ESC_PARENS): ... this.
6244         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6245         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6246
6247 2019-01-23  Tom Tromey  <tom@tromey.com>
6248
6249         * language.h (class scoped_switch_to_sym_language_if_auto):
6250         Initialize m_lang in both cases.
6251
6252 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6253
6254         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6255         with XCNEW.
6256
6257 2019-01-22  Tom Tromey  <tom@tromey.com>
6258
6259         * corelow.c: Do not include sys/file.h.
6260
6261 2019-01-22  Tom Tromey  <tom@tromey.com>
6262
6263         * tui/tui-wingeneral.h: Include gdb_curses.h.
6264
6265 2019-01-22  Tom Tromey  <tom@tromey.com>
6266
6267         * source-cache.h (class source_cache) <get_source_lines,
6268         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6269
6270 2019-01-22  Tom Tromey  <tom@tromey.com>
6271
6272         * remote-fileio.h (struct remote_target): Declare.
6273
6274 2019-01-22  Tom Tromey  <tom@tromey.com>
6275
6276         * python/py-arch.c: Do not include py-ref.h.
6277         * python/py-bpevent.c: Do not include py-ref.h.
6278         * python/py-cmd.c: Do not include py-ref.h.
6279         * python/py-continueevent.c: Do not include py-ref.h.
6280         * python/py-event.h: Do not include py-ref.h.
6281         * python/py-evtregistry.c: Do not include py-ref.h.
6282         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6283         * python/py-frame.c: Do not include py-ref.h.
6284         * python/py-framefilter.c: Do not include py-ref.h.
6285         * python/py-function.c: Do not include py-ref.h.
6286         * python/py-infevents.c: Do not include py-ref.h.
6287         * python/py-linetable.c: Do not include py-ref.h.
6288         * python/py-objfile.c: Do not include py-ref.h.
6289         * python/py-param.c: Do not include py-ref.h.
6290         * python/py-prettyprint.c: Do not include py-ref.h.
6291         * python/py-progspace.c: Do not include py-ref.h.
6292         * python/py-symbol.c: Do not include py-ref.h.
6293         * python/py-symtab.c: Do not include py-ref.h.
6294         * python/py-type.c: Do not include py-ref.h.
6295         * python/py-unwind.c: Do not include py-ref.h.
6296         * python/py-utils.c: Do not include py-ref.h.
6297         * python/py-value.c: Do not include py-ref.h.
6298         * python/py-varobj.c: Do not include py-ref.h.
6299         * python/py-xmethods.c: Do not include py-ref.h.
6300         * python/python.c: Do not include py-ref.h.
6301         * varobj.c: Do not include py-ref.h.
6302
6303 2019-01-22  Tom Tromey  <tom@tromey.com>
6304
6305         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6306         keyword for bcache.
6307
6308 2019-01-22  Tom Tromey  <tom@tromey.com>
6309
6310         * compile/compile-cplus-types.c: Remove a comment by #include.
6311
6312 2019-01-22  Tom Tromey  <tom@tromey.com>
6313
6314         * compile/gcc-c-plugin.h: Include compile-internal.h.
6315
6316 2019-01-22  Tom Tromey  <tom@tromey.com>
6317
6318         * stabsread.c (EXTERN): Do not define.
6319         (symnum, next_symbol_text_func, processing_gcc_compilation)
6320         (within_function, global_sym_chain, global_stabs)
6321         (previous_stab_code, this_object_header_files)
6322         (n_this_object_header_files)
6323         (n_allocated_this_object_header_files): Define.
6324         * stabsread.h (EXTERN): Never define.  Use "extern".
6325
6326 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6327
6328         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6329         history_value.
6330
6331 2019-01-21  Tom Tromey  <tom@tromey.com>
6332
6333         * ui-out.c: Fix includes.
6334         * tui/tui-source.c: Fix includes.
6335         * target.c: Fix includes.
6336         * remote.c: Fix includes.
6337         * regcache.c: Fix includes.
6338         * python/py-block.c: Fix includes.
6339         * printcmd.c: Fix includes.
6340         * or1k-tdep.c: Fix includes.
6341         * mi/mi-main.c: Fix includes.
6342         * m32r-tdep.c: Fix includes.
6343         * csky-tdep.c: Fix includes.
6344         * compile/compile-cplus-types.c: Fix includes.
6345         * cli/cli-interp.c: Fix includes.
6346
6347 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6348
6349         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6350         for padding.
6351
6352 2019-01-16  Tom Tromey  <tom@tromey.com>
6353
6354         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6355         earlier.
6356         (struct objfile) <msymbols_range>: Move from top level.
6357         <msymbols>: New method.
6358         (class objfile_msymbols): Remove.
6359         * symtab.c (default_collect_symbol_completion_matches_break_on):
6360         Update.
6361         * symmisc.c (dump_msymbols): Update.
6362         * stabsread.c (scan_file_globals): Update.
6363         * objc-lang.c (info_selectors_command, info_classes_command)
6364         (find_methods): Update.
6365         * minsyms.c (find_solib_trampoline_target): Update.
6366         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6367         * coffread.c (coff_symfile_read): Update.
6368         * ada-lang.c (ada_lookup_simple_minsym)
6369         (ada_collect_symbol_completion_matches): Update.
6370
6371 2019-01-16  Tom Tromey  <tom@tromey.com>
6372
6373         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6374         type.  Remove no-argument constructor.
6375         <iterator::operator++>: Simplify.
6376         <begin>: Update.
6377         <end>: Use minimal_symbol_count.
6378
6379 2019-01-16  Tom Tromey  <tom@tromey.com>
6380
6381         * objfiles.h (struct objfile) <psymtabs>: New method.
6382         (class objfile_psymtabs): Remove.
6383         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6384         typedef.
6385         <range>: New method.
6386         (require_partial_symbols): Change return type.
6387         * psymtab.c (require_partial_symbols)
6388         (psym_expand_symtabs_matching): Update.
6389         * mdebugread.c (parse_partial_symbols): Update.
6390         * dbxread.c (dbx_end_psymtab): Update.
6391
6392 2019-01-15  Tom Tromey  <tom@tromey.com>
6393
6394         * symtab.c (lookup_objfile_from_block)
6395         (lookup_symbol_in_objfile_symtabs)
6396         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6397         (find_line_symtab, info_sources_command)
6398         (default_collect_symbol_completion_matches_break_on)
6399         (make_source_files_completion_list): Update.
6400         * symmisc.c (print_objfile_statistics, dump_objfile)
6401         (maintenance_print_symbols, maintenance_info_symtabs)
6402         (maintenance_check_symtabs, maintenance_info_line_tables):
6403         Update.
6404         * source.c (select_source_symtab)
6405         (forget_cached_source_info_for_objfile): Update.
6406         * objfiles.h (class objfile_compunits): Remove.
6407         (struct objfile) <compunits_range>: New typedef.
6408         (compunits): New method.
6409         * objfiles.c (objfile_relocate1): Update.
6410         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6411         * maint.c (count_symtabs_and_blocks): Update.
6412         * linespec.c (iterate_over_all_matching_symtabs): Update.
6413         * cp-support.c (add_symbol_overload_list_qualified): Update.
6414         * coffread.c (coff_symtab_read): Update.
6415         * ada-lang.c (add_nonlocal_symbols)
6416         (ada_collect_symbol_completion_matches)
6417         (ada_add_global_exceptions): Update.
6418
6419 2019-01-15  Tom Tromey  <tom@tromey.com>
6420
6421         * progspace.h (program_space) <objfiles_safe_range>: New
6422         typedef.
6423         <objfiles_safe>: New method.
6424         * objfiles.h (class all_objfiles_safe): Remove.
6425         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6426         * jit.c (jit_inferior_exit_hook): Update.
6427
6428 2019-01-17  Tom Tromey  <tom@tromey.com>
6429
6430         * progspace.h (program_space) <objfiles_range>: New typedef.
6431         <objfiles>: New method.
6432         <objfiles_head>: Rename from objfiles.
6433         (object_files): Update.
6434         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6435         * guile/scm-pretty-print.c
6436         (ppscm_find_pretty_printer_from_objfiles): Update.
6437         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6438         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6439         Update.
6440         * python/py-progspace.c (pspy_get_objfiles): Update.
6441         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6442         Update.
6443         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6444         (objfpy_lookup_objfile_by_build_id): Update.
6445         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6446         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6447         Update.
6448         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6449         (expand_symtab_containing_pc, lookup_objfile_from_block)
6450         (lookup_static_symbol, basic_lookup_transparent_type)
6451         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6452         (find_line_symtab, info_sources_command)
6453         (default_collect_symbol_completion_matches_break_on)
6454         (make_source_files_completion_list, find_main_name): Update.
6455         * symmisc.c (print_symbol_bcache_statistics)
6456         (print_objfile_statistics, maintenance_print_symbols)
6457         (maintenance_print_msymbols, maintenance_print_objfiles)
6458         (maintenance_info_symtabs, maintenance_check_symtabs)
6459         (maintenance_expand_symtabs, maintenance_info_line_tables):
6460         Update.
6461         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6462         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6463         (map_overlay_command, unmap_overlay_command)
6464         (simple_overlay_update, expand_symtabs_matching)
6465         (map_symbol_filenames): Update.
6466         * symfile-debug.c (set_debug_symfile): Update.
6467         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6468         Update.
6469         * source.c (select_source_symtab, forget_cached_source_info):
6470         Update.
6471         * solib.c (solib_read_symbols): Update.
6472         * solib-spu.c (append_ocl_sos): Update.
6473         * psymtab.c (maintenance_print_psymbols)
6474         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6475         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6476         * printcmd.c (info_symbol_command): Update.
6477         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6478         Update.
6479         * objfiles.h (class all_objfiles): Remove.
6480         * objfiles.c (have_partial_symbols, have_full_symbols)
6481         (have_minimal_symbols, qsort_cmp, update_section_map)
6482         (shared_objfile_contains_address_p)
6483         (default_iterate_over_objfiles_in_search_order): Update.
6484         * objc-lang.c (info_selectors_command, info_classes_command)
6485         (find_methods): Update.
6486         * minsyms.c (find_solib_trampoline_target): Update.
6487         * maint.c (maintenance_info_sections)
6488         (maintenance_translate_address, count_symtabs_and_blocks):
6489         Update.
6490         * main.c (captured_main_1): Update.
6491         * linux-thread-db.c (try_thread_db_load_from_pdir)
6492         (has_libpthread): Update.
6493         * linespec.c (iterate_over_all_matching_symtabs)
6494         (search_minsyms_for_name): Update.
6495         * jit.c (jit_find_objf_with_entry_addr): Update.
6496         * hppa-tdep.c (find_unwind_entry)
6497         (hppa_lookup_stub_minimal_symbol): Update.
6498         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6499         Update.
6500         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6501         (elf_gnu_ifunc_resolve_by_got): Update.
6502         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6503         * dwarf-index-write.c (save_gdb_index_command): Update.
6504         * cp-support.c (add_symbol_overload_list_qualified): Update.
6505         * breakpoint.c (create_overlay_event_breakpoint)
6506         (create_longjmp_master_breakpoint)
6507         (create_std_terminate_master_breakpoint)
6508         (create_exception_master_breakpoint): Update.
6509         * blockframe.c (find_pc_partial_function): Update.
6510         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6511         (ada_collect_symbol_completion_matches)
6512         (ada_add_global_exceptions): Update.
6513
6514 2019-01-17  Tom Tromey  <tom@tromey.com>
6515
6516         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6517         declare VEC.
6518         (solib_target_parse_libraries): Change return type.
6519         (library_list_start_segment, library_list_start_section)
6520         (library_list_end_library, library_list_start_library); Update.
6521         (solib_target_free_library_list): Remove.
6522         (solib_target_parse_libraries): Remove cleanup.  Change return
6523         type.
6524         (solib_target_current_sos): Update.
6525
6526 2019-01-17  Tom Tromey  <tromey@bapiya>
6527
6528         * valprint.c: Replace "the the" with "the".
6529         * symtab.c: Replace "the the" with "the".
6530         * solib.c: Replace "the the" with "the".
6531         * solib-dsbt.c: Replace "the the" with "the".
6532         * linespec.c: Replace "the the" with "the".
6533         * dwarf2loc.h: Replace "the the" with "the".
6534         * amd64-windows-tdep.c: Replace "the the" with "the".
6535         * aarch64-tdep.c: Replace "the the" with "the".
6536
6537 2019-01-16  Keith Seitz  <keiths@redhat.com>
6538
6539         PR gdb/23773
6540         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6541         <builder>: Rename to ..
6542         <m_builder>: ... this and make private.
6543         (dwarf2_cu::get_builder): New method.  Change all users of
6544         `builder' to use this method.
6545         (dwarf2_start_symtab): Move to ...
6546         (dwarf2_cu::start_symtab): ... here.  Update all callers
6547         (setup_type_unit_groups): Move to ...
6548         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6549         callers.
6550         (dwarf2_cu::reset_builder): New method.
6551         (process_full_compunit, process_full_type_unit): Use
6552         dwarf2_cu::reset_builder.
6553         (follow_die_offset): Record the ancestor CU if it is different
6554         from the followed DIE's CU.
6555         (follow_die_sig_1): Likewise.
6556
6557 2019-01-15  Tom Tromey  <tom@tromey.com>
6558
6559         * remote.c (class remote_state) <buf>: Now a char_vector.
6560         <buf_size>: Remove.
6561         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6562         parameter.
6563         (remote_target::getpkt_or_notif_sane_1)
6564         (remote_target::getpkt_sane)
6565         (remote_target::getpkt_or_notif_sane): Likewise.
6566         (class remote_target) <putpkt>: New overload.
6567         (remote_target::read_frame): Change type of "buf_p".  Remove
6568         sizeof_p parameter.
6569         (packet_ok): New overload.
6570         (packet_check_result): New overload.
6571         Update all uses.
6572
6573 2019-01-14  Tom Tromey  <tom@tromey.com>
6574
6575         * remote-notif.c (handle_notification, remote_notif_ack)
6576         (remote_notif_parse): Make "buf" const.
6577         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6578         const.
6579         (remote_notif_parse, remote_notif_ack, handle_notification):
6580         Likewise.
6581         * remote.c (remote_notif_stop_parse): Make "buf" const.
6582         (remote_target::remote_parse_stop_reply): Make "buf" const.
6583         (remote_notif_stop_ack): Make "buf" const.
6584
6585 2019-01-14  Tom Tromey  <tom@tromey.com>
6586
6587         * remote.c (remote_console_output): Make parameter const.
6588
6589 2019-01-14  Tom Tromey  <tom@tromey.com>
6590
6591         * target-debug.h (target_debug_print_signals): Constify.
6592         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6593         * procfs.c (procfs_target::pass_signals): Update.
6594         * linux-nat.c (linux_nat_target::pass_signals): Update.
6595         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6596         * target-delegates.c: Rebuild.
6597         * remote.c (remote_target::program_signals): Update.
6598         (remote_target::pass_signals): Update.
6599         * target.c (target_pass_signals): Constify argument.
6600         (target_program_signals): Likewise.
6601         * target.h (struct target_ops) <pass_signals, program_signals>:
6602         Constify argument.
6603         (target_pass_signals, target_program_signals): Constify argument.
6604
6605 2019-01-14  Tom Tromey  <tom@tromey.com>
6606
6607         PR tui/28819:
6608         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6609
6610 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6611
6612         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6613         field.
6614         * rs6000-tdep.c: Include reggroups.h.
6615         (IS_V_ALIAS_PSEUDOREG): Define.
6616         (rs6000_register_name): Return names for the "vX" aliases.
6617         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6618         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6619         aliases.  Call default_register_reggroup_p for all other
6620         pseudo-registers.
6621         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6622         New functions.
6623         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6624         Handle "vX" aliases.
6625         (v_alias_pseudo_register_collect): New function.
6626         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6627         (rs6000_gdbarch_init): Initialize "vX" aliases as
6628         pseudo-registers.  Restore registration of
6629         rs6000_pseudo_register_reggroup_p with
6630         set_tdesc_pseudo_register_reggroup_p.
6631
6632 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6633
6634         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6635         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6636         set_gdbarch_num_pseudo_regs.
6637
6638 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6639
6640         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6641         Remove arg prefixname, add do_set and do_show.
6642         Add member functions set_list and show_list.
6643         * cli/cli-style.c (class cli_style_option): Update accordingly.
6644         (style_set_list): Move to file scope.
6645         (style_show_list): Likewise.
6646         (set_style): Call help_list.
6647         (show_style): Call cmd_show_list.
6648         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6649         Update to use the new macro.
6650
6651 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6652
6653         * ada-lang.c (_initialize_ada_language): Expand the help text
6654         for the "catch exception" command.
6655
6656 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6657
6658         * symtab.c (matching_obj_sections): Initialize obj,
6659         declare it closer to its usage.
6660
6661 2019-01-10  Tom Tromey  <tom@tromey.com>
6662
6663         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6664         (basic_inf_threads_range): Remove.
6665         (inf_threads_range, inf_non_exited_threads_range)
6666         (safe_inf_threads_range): Use next_adapter.
6667
6668 2019-01-10  Keith Seitz  <keiths@redhat.com>
6669
6670         PR gdb/23712
6671         PR symtab/23010
6672         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6673         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6674
6675 2019-01-10  Keith Seitz  <keiths@redhat.com>
6676
6677         PR gdb/23712
6678         PR symtab/23010
6679         * dictionary.c (pending_to_vector): Remove.
6680         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6681         Remove _1 suffix, replacing functions of the same name.  Update
6682         all callers.
6683         (dict_create_hashed, dict_create_hashed_expandable)
6684         (dict_create_linear, dict_create_linear_expandable, dict_free)
6685         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6686         Make functions static.
6687
6688 2019-01-10  Keith Seitz  <keiths@redhat.com>
6689
6690         PR gdb/23712
6691         PR symtab/23010
6692         * dictionary.h (struct dictionary): Replace declaration with
6693         multidictionary.
6694         (dict_create_hashed, dict_create_hashed_expandable)
6695         (dict_create_linear, dict_create_linear_expandable)
6696         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6697         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6698         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6699         taking multidictionary argument.
6700         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6701         * block.h (struct block) <dict>: Change to multidictionary
6702         and rename `multidict'.
6703         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6704         symmisc.c: Update all dictionary references to multidictionary.
6705
6706 2019-01-10  Keith Seitz  <keiths@redhat.com>
6707
6708         PR gdb/23712
6709         PR symtab/23010
6710         * dictionary.c: Include unordered_map.
6711         (pending_to_vector): New function.
6712         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6713         Rewrite the non-"_1" functions to take vector instead
6714         of linked list.
6715         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6716         "new" _1 versions of the same name.
6717         (multidictionary): Define.
6718         (std::hash<enum language): New definition.
6719         (collate_pending_symbols_by_language, mdict_create_hashed)
6720         (mdict_create_hashed_expandable, mdict_create_linear)
6721         (mdict_create_linear_expandable, mdict_free)
6722         (find_language_dictionary, create_new_language_dictionary)
6723         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6724         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6725         (mdict_size, mdict_empty): New functions.
6726         * dictionary.h (mdict_iterator): Define.
6727
6728 2019-01-10  Pedro Alves  <palves@redhat.com>
6729
6730         * breakpoint.c (read_uploaded_action)
6731         (create_tracepoint_from_upload): Adjust to use
6732         gdb::unique_xmalloc_ptr.
6733         * ctf.c (ctf_write_uploaded_tp):
6734         (SET_ARRAY_FIELD): Use emplace_back.
6735         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6736         * tracefile-tfile.c (tfile_write_uploaded_tp):
6737         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6738         gdb::unique_xmalloc_ptr.
6739         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6740         at_string, cond_string, cmd_strings>: Replace char pointers
6741         with gdb::unique_xmalloc_ptr.
6742
6743 2019-01-10  Pedro Alves  <palves@redhat.com>
6744
6745         * solib-target.c (library_list_start_library): Don't xstrdup name.
6746
6747 2019-01-10  Pedro Alves  <palves@redhat.com>
6748
6749         * mdebugread.c (parse_partial_symbols): Use
6750         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6751
6752 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6753
6754         * linux-fork.c (scoped_switch_fork_info)
6755         <~scoped_switch_fork_info>: Fix incorrect variable name.
6756
6757 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6758
6759         * linux-fork.c (scoped_switch_fork_info)
6760         <scoped_switch_fork_info>: Make explicit.
6761         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6762
6763 2019-01-10  Tom Tromey  <tom@tromey.com>
6764
6765         * objfiles.h (objfile::reset_psymtabs): Update.
6766         * objfiles.c (objfile::objfile): Update.
6767         * psymtab.h (psymtab_storage::obstack): Update.
6768         (psymtab_storage::m_obstack): Use gdb::optional.
6769         (class psymtab_storage): Update comment.  Remove objfile
6770         parameter.
6771         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6772
6773 2019-01-10  Tom Tromey  <tom@tromey.com>
6774
6775         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6776         <free_psymtabs>: Now private.
6777         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6778         (allocate_psymtab): Use new method.
6779
6780 2019-01-10  Tom Tromey  <tom@tromey.com>
6781
6782         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6783         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6784         * mdebugread.c (parse_partial_symbols): Use
6785         allocate_dependencies.
6786         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6787         allocate_dependencies.
6788         (process_psymtab_comp_unit_reader)
6789         (build_type_psymtab_dependencies): Likewise.
6790         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6791
6792 2019-01-10  Tom Tromey  <tom@tromey.com>
6793
6794         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6795         PSYMBOL_SET_LANGUAGE.
6796         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6797
6798 2019-01-10  Tom Tromey  <tom@tromey.com>
6799
6800         * psymtab.h (psymtab_storage::obstack): New method.
6801         <m_obstack>: Rename from obstack; now private.
6802         * psymtab.c (psymtab_storage): Update.
6803         * dwarf2read.c (create_addrmap_from_index)
6804         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6805         Update.
6806
6807 2019-01-10  Tom Tromey  <tom@tromey.com>
6808
6809         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6810         * objfiles.h (objfile::reset_psymtabs): New method.
6811
6812 2019-01-10  Tom Tromey  <tom@tromey.com>
6813
6814         * symmisc.c (print_symbol_bcache_statistics): Update.
6815         (print_objfile_statistics): Update.
6816         * symfile.c (reread_symbols): Update.
6817         * psymtab.h (class psymtab_storage): New.
6818         * psymtab.c (psymtab_storage): New constructor.
6819         (~psymtab_storage): New destructor.
6820         (require_partial_symbols): Update.
6821         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6822         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6823         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6824         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6825         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6826         (start_psymtab_common, end_psymtab_common)
6827         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6828         (allocate_psymtab): Update.
6829         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6830         Update.
6831         (dump_psymtab_addrmap, maintenance_print_psymbols)
6832         (maintenance_check_psymtabs): Update.
6833         (class objfile_psymtabs): Move to objfiles.h.
6834         * psympriv.h (discard_psymtab): Now inline.
6835         (psymtab_discarder::psymtab_discarder): Update.
6836         (psymtab_discarder::~psymtab_discarder): Update.
6837         (ALL_OBJFILE_PSYMTABS): Rewrite.
6838         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6839         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6840         Remove fields.
6841         <partial_symtabs>: New field.
6842         (class objfile_psymtabs): Move from psymtab.h.  Update.
6843         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6844         psymbol_cache.
6845         (objfile::~objfile): Don't destroy psymbol_cache.
6846         * mdebugread.c (parse_partial_symbols): Update.
6847         * dwarf2read.c (create_addrmap_from_index)
6848         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6849         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6850         (add_partial_subprogram, dwarf2_ranges_read): Update.
6851         * dwarf-index-write.c (write_address_map)
6852         (write_one_signatured_type, recursively_write_psymbols)
6853         (class debug_names, class debug_names, write_psymtabs_to_index):
6854         Update.
6855
6856 2019-01-10  Tom Tromey  <tom@tromey.com>
6857
6858         * symtab.h (SYMBOL_SET_NAMES): Update.
6859         (symbol_set_names): Update.
6860         (MSYMBOL_SET_NAMES): Update.
6861         * symtab.c (symbol_set_names): Change argument to be an
6862         objfile_per_bfd_storage.
6863         * psymtab.c (add_psymbol_to_bcache): Update.
6864         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6865
6866 2019-01-10  Tom Tromey  <tom@tromey.com>
6867
6868         * symtab.c (create_demangled_names_hash): Change argument to be an
6869         objfile_per_bfd_storage.
6870         (symbol_set_names): Update.
6871
6872 2019-01-10  Tom Tromey  <tom@tromey.com>
6873
6874         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6875         init_psymbol_list.
6876         * psymtab.c (init_psymbol_list): Do nothing if already called.
6877         * psympriv.h (init_psymbol_list): Add comment.
6878         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6879         init_psymbol_list.
6880         * dbxread.c (dbx_symfile_read): Unconditionally call
6881         init_psymbol_list.
6882
6883 2019-01-10  Tom Tromey  <tom@tromey.com>
6884
6885         * xcoffread.c (scan_xcoff_symtab): Update.
6886         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6887         "where".
6888         * mdebugread.c (parse_partial_symbols)
6889         (handle_psymbol_enumerators): Update.
6890         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6891         * dbxread.c (read_dbx_symtab): Update.
6892         * psympriv.h (psymbol_placement): New enum.
6893         (add_psymbol_to_list): Update.
6894
6895 2019-01-10  Tom Tromey  <tom@tromey.com>
6896
6897         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6898         static_psymbols parameters.
6899         (scan_xcoff_symtab): Update.
6900         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6901         static_psymbols parameters.
6902         * psympriv.h (start_psymtab_common): Update.
6903         * mdebugread.c (parse_partial_symbols): Update.
6904         * dwarf2read.c (create_partial_symtab): Update.
6905         * dbxread.c (read_dbx_symtab): Update.
6906         (start_psymtab): Remove global_psymbols and static_psymbols
6907         parameters.
6908
6909 2019-01-10  Tom Tromey  <tom@tromey.com>
6910
6911         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6912         * psymtab.c (allocate_psymtab): Add comment.
6913         * psympriv.h (allocate_psymtab): Add comment.
6914         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6915         initializations.
6916         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6917
6918 2019-01-10  Tom Tromey  <tom@tromey.com>
6919
6920         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6921         Don't declare.
6922         * mipsread.c: Include mdebugread.h.
6923         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6924         Declare.
6925         * elfread.c: Include mdebugread.h.
6926
6927 2019-01-09  Tom Tromey  <tom@tromey.com>
6928
6929         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6930         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6931         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6932         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6933         (psym_lookup_symbol, psym_find_last_source_symtab)
6934         (psym_forget_cached_source_info, psym_print_stats)
6935         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6936         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6937         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6938         (psym_find_compunit_symtab_by_address)
6939         (maintenance_print_psymbols, maintenance_info_psymtabs)
6940         (maintenance_check_psymtabs): Use ranged for.
6941         * psymtab.h (class objfile_psymtabs): New.
6942         (require_partial_symbols): Return objfile_psymtabs.
6943         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6944
6945 2019-01-09  Tom Tromey  <tom@tromey.com>
6946
6947         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6948         (find_pc_mapped_section, list_overlays_command)
6949         (map_overlay_command, unmap_overlay_command)
6950         (simple_overlay_update): Use all_objfiles.
6951         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6952         * printcmd.c (info_symbol_command): Use all_objfiles.
6953         * objfiles.h (ALL_OBJSECTIONS): Remove.
6954         * maint.c (maintenance_translate_address): Use all_objfiles.
6955         * gcore.c (gcore_create_callback): Use all_objfiles.
6956         (objfile_find_memory_regions): Likewise.
6957
6958 2019-01-09  Tom Tromey  <tom@tromey.com>
6959
6960         * symtab.c (find_line_symtab, info_sources_command)
6961         (make_source_files_completion_list): Use objfile_compunits.
6962         * source.c (select_source_symtab): Use objfile_compunits.
6963         * objfiles.h (struct objfile): Update comment.
6964         (ALL_OBJFILES): Remove.
6965         (ALL_FILETABS): Remove.
6966         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6967         objfile_compunits.
6968
6969 2019-01-09  Tom Tromey  <tom@tromey.com>
6970
6971         * symmisc.c (print_objfile_statistics, dump_objfile)
6972         (maintenance_print_symbols): Use compunit_filetabs.
6973         * source.c (forget_cached_source_info_for_objfile): Use
6974         compunit_filetabs.
6975         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6976         (ALL_FILETABS): Use compunit_filetabs.
6977         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6978         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6979
6980 2019-01-09  Tom Tromey  <tom@tromey.com>
6981
6982         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6983         (compunit_filetabs): New.
6984         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6985         compunit_filetabs.
6986         (info_sources_command, make_source_files_completion_list): Remove
6987         declaration.
6988         * symmisc.c (print_objfile_statistics, dump_objfile)
6989         (maintenance_print_symbols): Remove declaration.
6990         (maintenance_info_symtabs): Use compunit_filetabs.
6991         (maintenance_info_line_tables): Likewise.
6992         * source.c (select_source_symtab): Change local variable name.
6993         (forget_cached_source_info_for_objfile): Remove declaration.
6994         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6995         * objfiles.c (objfile_relocate1): Remove declaration.
6996         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6997         declaration.
6998         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6999         * coffread.c (coff_symtab_read): Remove declaration.
7000         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7001         compunit_filetabs.
7002
7003 2019-01-09  Tom Tromey  <tom@tromey.com>
7004
7005         * symtab.c (lookup_objfile_from_block)
7006         (find_pc_sect_compunit_symtab, search_symbols)
7007         (default_collect_symbol_completion_matches_break_on): Use
7008         objfile_compunits.
7009         * objfiles.h (ALL_COMPUNITS): Remove.
7010         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7011         * cp-support.c (add_symbol_overload_list_qualified): Use
7012         objfile_compunits.
7013         * ada-lang.c (ada_collect_symbol_completion_matches)
7014         (ada_add_global_exceptions): Use objfile_compunits.
7015
7016 2019-01-09  Tom Tromey  <tom@tromey.com>
7017
7018         * source.c (select_source_symtab)
7019         (forget_cached_source_info_for_objfile): Remove declaration.
7020         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7021         declaration.
7022         * maint.c (count_symtabs_and_blocks): Remove declaration.
7023         * cp-support.c (add_symbol_overload_list_qualified): Remove
7024         declaration.
7025         * coffread.c (coff_symtab_read): Remove declaration.
7026         * symtab.c (lookup_symbol_in_objfile_symtabs)
7027         (basic_lookup_transparent_type_1): Use objfile_compunits.
7028         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7029         (info_sources_command, search_symbols)
7030         (default_collect_symbol_completion_matches_break_on)
7031         (make_source_files_completion_list): Remove declaration.
7032         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7033         (ada_collect_symbol_completion_matches)
7034         (ada_add_global_exceptions): Remove declaration.
7035         * linespec.c (iterate_over_all_matching_symtabs): Use
7036         objfile_compunits.
7037         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7038         (class objfile_compunits): New.
7039         (ALL_COMPUNITS): Use objfile_compunits.
7040         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7041         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7042         objfile_compunits.
7043         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7044
7045 2019-01-09  Tom Tromey  <tom@tromey.com>
7046
7047         * symtab.c (search_symbols)
7048         (default_collect_symbol_completion_matches_break_on): Use
7049         objfile_msymbols.
7050         * ada-lang.c (ada_lookup_simple_minsym)
7051         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7052         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7053         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7054         objfile_msymbols.
7055         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7056         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7057         * objc-lang.c (find_methods): Use objfile_msymbols.
7058         (info_selectors_command, info_classes_command): Likewise.
7059         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7060         * objfiles.h (class objfile_msymbols): New.
7061         (ALL_OBJFILE_MSYMBOLS): Remove.
7062         (ALL_MSYMBOLS): Remove.
7063
7064 2019-01-09  Tom Tromey  <tom@tromey.com>
7065
7066         * common/next-iterator.h (next_adapter): Add Iterator template
7067         parameter.
7068         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7069         (class all_objfiles_safe): New.
7070         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7071         * objfiles.c (put_objfile_before): Update comment.
7072         (add_separate_debug_objfile): Likewise.
7073         (free_all_objfiles): Use all_objfiles_safe.
7074         (objfile_purge_solibs): Likewise.
7075
7076 2019-01-09  Tom Tromey  <tom@tromey.com>
7077
7078         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7079         (expand_symtab_containing_pc, lookup_static_symbol)
7080         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7081         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7082         all_objfiles.
7083         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7084         * breakpoint.c (create_overlay_event_breakpoint)
7085         (create_longjmp_master_breakpoint)
7086         (create_std_terminate_master_breakpoint)
7087         (create_exception_master_breakpoint): Use all_objfiles.
7088         * linux-thread-db.c (try_thread_db_load_from_pdir)
7089         (has_libpthread): Use all_objfiles.
7090         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7091         * linespec.c (iterate_over_all_matching_symtabs)
7092         (search_minsyms_for_name): Use all_objfiles.
7093         * maint.c (maintenance_info_sections): Use all_objfiles.
7094         * main.c (captured_main_1): Use all_objfiles.
7095         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7096         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7097         * guile/scm-pretty-print.c
7098         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7099         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7100         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7101         (maintenance_print_msymbols): Use all_objfiles.
7102         * source.c (select_source_symtab): Use all_objfiles.
7103         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7104         * symfile.c (remove_symbol_file_command)
7105         (expand_symtabs_matching, map_symbol_filenames): Use
7106         all_objfiles.
7107         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7108         all_objfiles.
7109         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7110         * objc-lang.c (find_methods): Use all_objfiles.
7111         * objfiles.c (have_partial_symbols, have_full_symbols)
7112         (have_minimal_symbols, qsort_cmp)
7113         (default_iterate_over_objfiles_in_search_order): Use
7114         all_objfiles.
7115         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7116         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7117         (maintenance_check_psymtabs): Use all_objfiles.
7118         (ALL_PSYMTABS): Remove.
7119         * compile/compile-object-run.c (do_module_cleanup): Use
7120         all_objfiles.
7121         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7122         * cp-support.c (add_symbol_overload_list_qualified): Use
7123         all_objfiles.
7124         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7125         Use all_objfiles.
7126         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7127         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7128         all_objfiles.
7129         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7130         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7131         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7132         Uses all_objfiles.
7133         * solib.c (solib_read_symbols): Use all_objfiles
7134
7135 2019-01-09  Tom Tromey  <tom@tromey.com>
7136
7137         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7138         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7139         all_objfiles.
7140         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7141         * symmisc.c (print_symbol_bcache_statistics)
7142         (print_objfile_statistics, maintenance_print_objfiles)
7143         (maintenance_info_symtabs, maintenance_check_symtabs)
7144         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7145         all_objfiles.
7146         * source.c (forget_cached_source_info): Use all_objfiles.
7147         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7148         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7149         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7150         * objfiles.c (update_section_map): Use all_objfiles.
7151         (shared_objfile_contains_address_p): Likewise.
7152         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7153         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7154
7155 2019-01-09  Tom Tromey  <tom@tromey.com>
7156
7157         * common/next-iterator.h: New file.
7158         * objfiles.h (class all_objfiles): New.
7159         (struct objfile_iterator): New.
7160
7161 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7162
7163         * NEWS: Move the description of the changed "frame", "select-frame",
7164          and "info frame" commands to the Changed commands section.
7165
7166 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7167
7168         * gdbtypes.c (check_stub_method_group): Remove handling of old
7169         mangling schemes.
7170         * linespec.c (find_methods): Likewise.
7171         * stabsread.c (read_member_functions): Likewise.
7172         * valops.c (search_struct_method): Likewise.
7173         (value_struct_elt_for_reference): Likewise.
7174         * NEWS: Mention this change.
7175
7176 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7177
7178         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7179         print_source_lines.
7180         * source.c (print_source_lines_base): Update line number check.
7181         (print_source_lines): New function.
7182         (source_lines_range::source_lines_range): New function.
7183         * source.h (class source_lines_range): New class.
7184         (print_source_lines): New declaration.
7185
7186 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7187
7188         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7189
7190 2019-01-08  Tom Tromey  <tom@tromey.com>
7191             Simon Marchi  <simon.marchi@ericsson.com>
7192
7193         PR gdb/24060
7194         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7195         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7196         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7197         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7198         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7199         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7200
7201 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7202
7203         * source.c (select_source_symtab): Move header comment to
7204         declaration in source.h.
7205         (forget_cached_source_info_for_objfile): Likewise.
7206         (forget_cached_source_info): Likewise.
7207         (identify_source_line): Likewise.
7208         * source.h (identify_source_line): Move declaration from symtab.h
7209         and add comment from source.c
7210         (print_source_lines): Likewise.
7211         (forget_cached_source_info_for_objfile): Likewise.
7212         (forget_cached_source_info): Likewise.
7213         (select_source_symtab): Likewise.
7214         (enum print_source_lines_flag): Move definition from symtab.h.
7215         * symtab.h (identify_source_line): Move declaration to source.h.
7216         (print_source_lines): Likewise.
7217         (forget_cached_source_info_for_objfile): Likewise.
7218         (forget_cached_source_info): Likewise.
7219         (select_source_symtab): Likewise.
7220         (enum print_source_lines_flag): Move definition to source.h.
7221         * tui/tui-hooks.c: Add 'source.h' include.
7222
7223 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7224
7225         * source.c (print_source_lines_base): Handle requests to print
7226         reverse line number sequences, and guard against empty lines
7227         string.
7228
7229 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7230
7231         * source.c (print_source_lines_base): Fix skip of '\r' if next
7232         character is '\n'.
7233
7234 2019-01-06  Tom Tromey  <tom@tromey.com>
7235
7236         * c-exp.y (struct c_parse_state) <macro_original_text,
7237         expansion_obstack>: New member.
7238         (macro_original_text, expansion_obstack): Remove globals.
7239         (scan_macro_expansion, scanning_macro_expansion)
7240         (finished_macro_expansion): Update.
7241         (scan_macro_cleanup): Remove.
7242         (yylex, c_parse): Update.
7243
7244 2019-01-06  Tom Tromey  <tom@tromey.com>
7245
7246         * c-exp.y (struct c_parse_state) <strings>: New member.
7247         (operator_stoken): Update.
7248
7249 2019-01-06  Tom Tromey  <tom@tromey.com>
7250
7251         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7252         (union type_stack_elt) <typelist_val>: Now a pointer to
7253         std::vector.
7254         (type_stack_cleanup): Don't declare.
7255         (push_typelist): Update.
7256         * parse.c (pop_typelist): Return a std::vector.
7257         (push_typelist): Take a std::vector.
7258         (follow_types): Update.  Do not free args.
7259         (type_stack_cleanup): Remove.
7260         * c-exp.y (struct c_parse_state): New.
7261         (cpstate): New global.
7262         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7263         (nonempty_typelist): Update.
7264         (func_mod): Create a new vector.
7265         (c_parse): Create a c_parse_state.
7266         (check_parameter_typelist): Do not delete params.
7267         (function_method): Update.  Do not delete type_list.
7268
7269 2019-01-06  Tom Tromey  <tom@tromey.com>
7270
7271         PR gdb/28155:
7272         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7273         check_typedef.
7274         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7275         (print_return_value): Likewise.
7276
7277 2019-01-05  Tom Tromey  <tom@tromey.com>
7278
7279         * contrib/cleanup_check.py: Remove.
7280         * contrib/gcc-with-excheck: Remove.
7281         * contrib/exsummary.py: Remove.
7282         * contrib/excheck.py: Remove.
7283
7284 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7285
7286         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7287         NULL. Initialize tpprev to NULL instead of assigning it
7288         to NULL on the next statement.
7289         * windows-nat.c (windows_delete_thread): Remove check for
7290         main_thread_id before printing thread exit notifications.
7291         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7292         Remove thread ID check against main_thread_id.
7293         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7294         windows_delete_thread.
7295         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7296
7297 2019-01-04  Tom Tromey  <tom@tromey.com>
7298
7299         * compile/compile.c (_initialize_compile): Use upper case for
7300         metasyntactic variables.
7301         * symmisc.c (_initialize_symmisc): Use upper case for
7302         metasyntactic variables.
7303         * psymtab.c (_initialize_psymtab): Use upper case for
7304         metasyntactic variables.
7305         * demangle.c (demangle_command): Use upper case for metasyntactic
7306         variables.
7307         (_initialize_demangler): Likewise.
7308         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7309         variables.
7310
7311 2019-01-03  Tom Tromey  <tom@tromey.com>
7312
7313         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7314
7315 2019-01-03  Tom Tromey  <tom@tromey.com>
7316
7317         * python/py-symtab.c (salpy_str): Update.
7318         (struct salpy_sal_object) <symtab>: Now a PyObject.
7319         (salpy_dealloc): Update.
7320         (del_objfile_sal): Use gdbpy_ref.
7321
7322 2019-01-03  Tom Tromey  <tom@tromey.com>
7323
7324         * python/py-type.c (convert_field): Use new_reference.  Return
7325         gdbpy_ref.
7326         (make_fielditem): Return gdbpy_ref.
7327         (typy_fields): Update.
7328         (typy_getitem): Update.
7329         (field_name): Return gdbpy_ref.  Use new_reference.
7330         (typy_iterator_iternext): Update.
7331
7332 2019-01-03  Tom Tromey  <tom@tromey.com>
7333
7334         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7335
7336 2019-01-03  Tom Tromey  <tom@tromey.com>
7337
7338         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7339         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7340         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7341         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7342         (pspy_set_type_printers): Likewise.
7343         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7344         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7345         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7346         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7347         (objfpy_set_type_printers): Likewise.
7348
7349 2019-01-03  Tom Tromey  <tom@tromey.com>
7350
7351         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7352         (gdbpy_print_stack): Use gdbpy_err_fetch.
7353         * python/python-internal.h (class gdbpy_err_fetch): New class.
7354         (class gdbpy_enter) <m_error_type, m_error_value,
7355         m_error_traceback>: Remove.
7356         <m_error>: New member.
7357         (gdbpy_exception_to_string): Don't declare.
7358         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7359         * python/py-value.c (convert_value_from_python): Use
7360         gdbpy_err_fetch.
7361         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7362         gdbpy_exception_to_string.
7363         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7364         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7365         gdbpy_err_fetch.
7366
7367 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7368
7369         * linux-nat.c (delete_lwp_cleanup): Delete.
7370         (struct lwp_deleter): New struct.
7371         (lwp_info_up): New typedef.
7372         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7373         lwp_info_up.
7374
7375 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7376
7377         * linux-fork.c (class scoped_switch_fork_info): New class.
7378         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7379
7380 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7381
7382         * valops.c (find_overload_match): Remove use of null_cleanup, and
7383         calls to do_cleanups.
7384
7385 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7386
7387         * compile/compile-cplus-types.c
7388         (compile_cplus_instance::decl_name): Handle changes to
7389         cp_func_name.
7390         * cp-support.c (cp_func_name): Update header comment, update
7391         return type.
7392         * cp-support.h (cp_func_name): Update return type in declaration.
7393         * valops.c (find_overload_match): Move temp_func local to top
7394         level of function and change its type.  Use temp_func to hold and
7395         delete temporary string obtained from cp_func_name.
7396
7397 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7398
7399         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7400         gdb::char_vector, remove cleanup, and update uses of `msg`.
7401
7402 2019-01-03  Jim Wilson  <jimw@sifive.com>
7403
7404         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7405
7406 2019-01-02  Tom Tromey  <tom@tromey.com>
7407
7408         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7409         (tdesc_parse_xml): Remove cleanups.
7410         * target-descriptions.h (make_cleanup_free_target_description):
7411         Don't declare.
7412         (target_desc_deleter): New struct.
7413         (target_desc_up): New typedef.
7414         * target-descriptions.c (target_desc_deleter::operator()): Rename
7415         from free_target_description.
7416         (make_cleanup_free_target_description): Remove.
7417
7418 2019-01-02  Tom Tromey  <tom@tromey.com>
7419
7420         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7421         constructor, destructor.
7422         (linespec_parser): Remove typedef.
7423         (~linespec_parser): Rename from linespec_parser_delete.
7424         (linespec_lex_to_end, linespec_complete_label)
7425         (linespec_complete): Update.
7426         (decode_line_full): Remove cleanups.
7427         (decode_line_1): Update.
7428
7429 2019-01-02  Tom Tromey  <tom@tromey.com>
7430
7431         * python/python-internal.h (inferior_to_inferior_object): Change
7432         return type.
7433         * python/py-exitedevent.c (create_exited_event_object): Update.
7434         * python/py-inferior.c (inferior_to_inferior_object): Return
7435         gdbpy_ref.
7436         (python_new_inferior, python_inferior_deleted)
7437         (thread_to_thread_object, delete_thread_object)
7438         (build_inferior_list, gdbpy_selected_inferior): Update.
7439         * python/py-infthread.c (create_thread_object): Update.  Also fail
7440         if inferior_to_inferior_object fails.
7441
7442 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7443
7444         * inferior.h (class inferior) <displaced_step_state>: New field.
7445         * infrun.h (struct displaced_step_state): Move here from
7446         infrun.c.  Initialize fields, add constructor.
7447         <inf>: Remove field.
7448         <reset>: New method.
7449         * infrun.c (struct displaced_step_inferior_state): Move to
7450         infrun.h.
7451         (displaced_step_inferior_states): Remove.
7452         (get_displaced_stepping_state): Adust.
7453         (displaced_step_in_progress_any_inferior): Adjust.
7454         (displaced_step_in_progress_thread): Adjust.
7455         (displaced_step_in_progress): Adjust.
7456         (add_displaced_stepping_state): Remove.
7457         (get_displaced_step_closure_by_addr): Adjust.
7458         (remove_displaced_stepping_state): Remove.
7459         (infrun_inferior_exit): Call displaced_step_state.reset.
7460         (use_displaced_stepping): Don't check for NULL.
7461         (displaced_step_prepare_throw): Call
7462         get_displaced_stepping_state.
7463         (displaced_step_fixup): Don't check for NULL.
7464         (prepare_for_detach): Don't check for NULL.
7465
7466 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7467
7468         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7469          in case of call that did not complete.
7470
7471 2019-01-02  Andrey Utkin  <autkin@undo.io>
7472
7473         * symfile.c (find_separate_debug_file): Fix search of debug files for
7474         remote debuggee.
7475
7476 2019-01-02  Tom Tromey  <tom@tromey.com>
7477
7478         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7479         indentation.
7480         * python/py-frame.c (frapy_older): Remove cast.
7481         (frapy_newer): Likewise.
7482         * python/py-breakpoint.c (local_setattro): Remove cast.
7483         * python/py-arch.c (archpy_name): Remove local variable.
7484         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7485
7486 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7487
7488         * unittests/basic_string_view/element_access/char/empty.cc:
7489         Fix year range in copyright header.
7490
7491 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7492
7493         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7494         Delete.
7495         <operator==>: Update with for removed field.
7496         <hash>: Likewise.
7497         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7498         <isa_features>: ...this.
7499         <abi_features>: New field.
7500         (riscv_isa_flen): Update comment.
7501         (riscv_abi_xlen): New declaration.
7502         (riscv_abi_flen): New declaration.
7503         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7504         isa_features.
7505         (riscv_abi_xlen): New function.
7506         (riscv_isa_flen): Update to get answer from isa_features.
7507         (riscv_abi_flen): New function.
7508         (riscv_has_fp_abi): Update to get answer from abi_features.
7509         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7510         xlen and flen.
7511         (riscv_call_info) <xlen, flen>: Update comment.
7512         (riscv_call_arg_struct): Remove invalid assertions
7513         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7514         is removed.
7515         (riscv_gdbarch_init): Gather isa features and abi features
7516         separately, ensure both match on the gdbarch when reusing an old
7517         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7518         a target with 64-bit float hardware.
7519
7520 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7521
7522         * source.c (search_command_helper): Stop reverse search
7523         when line 1 has been searched.
7524
7525 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7526
7527         * record-full.c (record_full_base_target::close): Rewrite
7528         record_full_core_buf_list free logic.
7529
7530 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7531
7532         * break-catch-syscall.c (print_one_catch_syscall): xfree
7533         the last text.
7534
7535 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7536
7537         * top.c (print_gdb_version): Update Copyright year in version
7538         message.
7539
7540 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7541
7542         Update copyright year range in all GDB files.
7543
7544 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7545
7546         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7547
7548 For older changes see ChangeLog-2018.
7549 \f
7550 Local Variables:
7551 mode: change-log
7552 left-margin: 8
7553 fill-column: 74
7554 version-control: never
7555 coding: utf-8
7556 End:
7557