gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * mdebugread.c (basic_type_data): Change type.
   4         (basic_type, _initialize_mdebugread): Update.
   5
   6 2019-05-08  Tom Tromey  <tom@tromey.com>
   7
   8         * common/gdb_unique_ptr.h (struct noop_deleter): New.
   9
  10 2019-05-08  Tom Tromey  <tom@tromey.com>
  11
  12         * nto-tdep.c (nto_inferior_data_reg): Change type.
  13         (nto_inferior_data): Update.
  14         (nto_inferior_data_cleanup, nto_new_inferior_data)
  15         (_initialize_nto_tdep): Remove.
  16         * nto-tdep.h (struct nto_inferior_data): Add initializers.
  17
  18 2019-05-08  Tom Tromey  <tom@tromey.com>
  19
  20         * ada-lang.c (struct ada_inferior_data): Add initializers.
  21         (ada_inferior_data): Change type.
  22         (ada_inferior_data_cleanup): Remove.
  23         (get_ada_inferior_data, ada_inferior_exit)
  24         (struct ada_pspace_data): Add initializers, destructor.
  25         (ada_pspace_data_handle): Change type.
  26         (get_ada_pspace_data): Update.
  27         (ada_pspace_data_cleanup): Remove.
  28
  29 2019-05-08  Tom Tromey  <tom@tromey.com>
  30
  31         * coffread.c (struct coff_symfile_info): Add initializers.
  32         (coff_objfile_data_key): Move lower.  Change type.
  33         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
  34         Update.
  35         (coff_free_info): Remove.
  36
  37 2019-05-08  Tom Tromey  <tom@tromey.com>
  38
  39         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
  40         (fbsd_pspace_data_handle): Move lower.  Change type.
  41         (get_fbsd_pspace_data): Update.
  42         (fbsd_pspace_data_cleanup): Remove.
  43         (_initialize_fbsd_tdep): Update.
  44
  45 2019-05-08  Tom Tromey  <tom@tromey.com>
  46
  47         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
  48         (get_ada_tasks_pspace_data): Update.
  49         (ada_tasks_pspace_data_cleanup): Remove.
  50         (_initialize_tasks): Update.
  51         (ada_tasks_inferior_data_handle): Change type.
  52         (get_ada_tasks_inferior_data): Update.
  53         (ada_tasks_inferior_data_cleanup): Remove.
  54         (struct ada_tasks_pspace_data): Add initializers.
  55
  56 2019-05-08  Tom Tromey  <tom@tromey.com>
  57
  58         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
  59         * symfile-debug.c (debug_sym_get_probes): Change type.
  60         * stap-probe.c (handle_stap_probe):
  61         (stap_static_probe_ops::get_probes): Change type.
  62         * probe.h (class static_probe_ops) <get_probes>: Change type.
  63         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
  64         (parse_probes_in_pspace): Update.
  65         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
  66         Update.
  67         (any_static_probe_ops::get_probes): Change type.
  68         * elfread.c (elfread_data): New typedef.
  69         (probe_key): Change type.
  70         (elf_get_probes): Likewise.  Update.
  71         (probe_key_free): Remove.
  72         (_initialize_elfread): Update.
  73         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
  74         Change type.
  75         (dtrace_process_dof_probe, dtrace_process_dof)
  76         (dtrace_static_probe_ops::get_probe): Change type.
  77
  78 2019-05-08  Tom Tromey  <tom@tromey.com>
  79
  80         * xcoffread.c (struct xcoff_symfile_info): Rename from
  81         coff_symfile_info.  Add initializers.
  82         (xcoff_objfile_data_key): Move lower.  Change type.
  83         (XCOFF_DATA): Rewrite.
  84         (xcoff_free_info): Remove.
  85         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
  86         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
  87         (xcoff_initial_scan): Update.
  88
  89 2019-05-08  Tom Tromey  <tom@tromey.com>
  90
  91         * solib-svr4.c (struct svr4_info): Add initializers and
  92         destructor.
  93         <probes_table>: Now an htab_up.
  94         (solib_svr4_pspace_data): Change type.
  95         (free_probes_table): Simplify.
  96         (~svr4_info): Rename from svr4_pspace_data_cleanup.
  97         (get_svr4_info, probes_table_htab_remove_objfile_probes)
  98         (probes_table_remove_objfile_probes, register_solib_event_probe)
  99         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 100         (_initialize_svr4_solib): Update.
 101
 102 2019-05-08  Tom Tromey  <tom@tromey.com>
 103
 104         * remote.c (remote_pspace_data): Change type.
 105         (remote_pspace_data_cleanup): Remove.
 106         (get_remote_exec_file, set_pspace_remote_exec_file)
 107         (_initialize_remote): Update.
 108
 109 2019-05-08  Tom Tromey  <tom@tromey.com>
 110
 111         * breakpoint.c (breakpoint_objfile_key): Change type.
 112         (get_breakpoint_objfile_data): Update.
 113         (free_breakpoint_objfile_data): Remove.
 114         (_initialize_breakpoint): Update.
 115
 116 2019-05-08  Tom Tromey  <tom@tromey.com>
 117
 118         * linux-tdep.c (struct linux_info): Add initializers.
 119         (linux_inferior_data): Move.  Change type.
 120         (invalidate_linux_cache_inf): Update.
 121         (linux_inferior_data_cleanup): Remove.
 122         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 123
 124 2019-05-08  Tom Tromey  <tom@tromey.com>
 125
 126         * auxv.c (auxv_inferior_data): Move.  Change type.
 127         (auxv_inferior_data_cleanup): Remove.
 128         (invalidate_auxv_cache_inf): Rewrite.
 129         (get_auxv_inferior_data, _initialize_auxv): Update.
 130
 131 2019-05-08  Tom Tromey  <tom@tromey.com>
 132
 133         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 134         (symfile_debug_objfile_data_key): Change type.
 135         (symfile_debug_installed, debug_qf_has_symbols)
 136         (debug_qf_find_last_source_symtab)
 137         (debug_qf_forget_cached_source_info)
 138         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 139         (debug_qf_print_stats, debug_qf_dump)
 140         (debug_qf_expand_symtabs_for_function)
 141         (debug_qf_expand_all_symtabs)
 142         (debug_qf_expand_symtabs_with_fullname)
 143         (debug_qf_map_matching_symbols)
 144         (debug_qf_expand_symtabs_matching)
 145         (debug_qf_find_pc_sect_compunit_symtab)
 146         (debug_qf_map_symbol_filenames)
 147         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 148         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 149         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 150         (debug_sym_read_linetable, debug_sym_relocate): Update.
 151         (symfile_debug_free_objfile): Remove.
 152         (install_symfile_debug_logging, _initialize_symfile_debug):
 153         Update.
 154
 155 2019-05-08  Tom Tromey  <tom@tromey.com>
 156
 157         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 158         allocate_on_obstack.
 159         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 160         (get_dwarf2_per_objfile): Update.
 161         (set_dwarf2_per_objfile): Remove.
 162         (dwarf2_has_info, dwarf2_get_section_info): Update.
 163         (dwarf2_free_objfile): Remove.
 164         (_initialize_dwarf2_read): Update.
 165
 166 2019-05-08  Tom Tromey  <tom@tromey.com>
 167
 168         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 169         initializers.
 170         <unsupported_script_warning_printed,
 171         script_not_found_warning_printed>: Now bool.
 172         (auto_load_pspace_data): Change type.
 173         (~auto_load_pspace_info): Rename from
 174         auto_load_pspace_data_cleanup.
 175         (get_auto_load_pspace_data, init_loaded_scripts_info)
 176         (clear_section_scripts, maybe_print_unsupported_script_warning)
 177         (maybe_print_script_not_found_warning, _initialize_auto_load):
 178         Update.
 179
 180 2019-05-08  Tom Tromey  <tom@tromey.com>
 181
 182         * objfiles.c (objfile_pspace_info): Add destructor and
 183         initializers.
 184         (objfiles_pspace_data): Change type.
 185         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 186         (get_objfile_pspace_data): Update.
 187         (objfiles_bfd_data): Change type.
 188         (get_objfile_bfd_data): Update.
 189         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 190
 191 2019-05-08  Tom Tromey  <tom@tromey.com>
 192
 193         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 194         Change type.
 195         (get_catch_syscall_inferior_data): Update.
 196         (catch_syscall_inferior_data_cleanup): Remove.
 197         (_initialize_break_catch_syscall): Update.
 198
 199 2019-05-08  Tom Tromey  <tom@tromey.com>
 200
 201         * inflow.c (struct terminal_info): Add destructor and
 202         initializers.
 203         (inflow_inferior_data): Change type.
 204         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 205         (get_inflow_inferior_data, inflow_inferior_exit)
 206         (swap_terminal_info, _initialize_inflow): Update.
 207
 208 2019-05-08  Tom Tromey  <tom@tromey.com>
 209
 210         * target-dcache.c (target_dcache_cleanup): Remove.
 211         (target_dcache_aspace_key): Change type.
 212         (target_dcache_init_p, target_dcache_invalidate)
 213         (target_dcache_get, target_dcache_get_or_init)
 214         (_initialize_target_dcache): Update.
 215         * dcache.h (struct dcache_deleter): New.
 216
 217 2019-05-08  Tom Tromey  <tom@tromey.com>
 218
 219         * symtab.c (struct symbol_cache): Add destructor and
 220         initializers.
 221         (symbol_cache_key): Move.  Change type.
 222         (make_symbol_cache, free_symbol_cache): Remove.
 223         (get_symbol_cache): Update.
 224         (symbol_cache_cleanup): Remove.
 225         (ALL_PSPACES, symbol_cache_flush)
 226         (maintenance_print_symbol_cache)
 227         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 228         Update.
 229
 230 2019-05-08  Tom Tromey  <tom@tromey.com>
 231
 232         * symtab.c (struct main_info): Add destructor and initializers.
 233         (main_progspace_key): Move.  Change type.
 234         (get_main_info): Update.
 235         (main_info_cleanup): Remove.
 236         (_initialize_symtab): Update.
 237
 238 2019-05-08  Tom Tromey  <tom@tromey.com>
 239
 240         * registry.h (DECLARE_REGISTRY): Define the _key class.
 241
 242 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 243
 244         * NEWS: Merge two 'New commands' sections.
 245
 246 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 247
 248         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 249         parameter and use Ada language definition instead.
 250         (ada_val_print_ptr): Remove unused language parameter.
 251         (ada_val_print_num): Remove language parameter and use Ada language
 252         definition instead.
 253         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 254         parameter.
 255         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 256         parameter and use Ada language definition instead.
 257         (ada_val_print_1): Update all ada_val_print_xxx calls.
 258         Remove language parameter.
 259         (ada_val_print): Update ada_val_print_1 call.
 260
 261 2019-05-08  Tom Tromey  <tromey@adacore.com>
 262
 263         * remote.c (remote_hw_watchpoint_limit)
 264         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 265         Now static.
 266
 267 2019-05-08  Tom Tromey  <tromey@adacore.com>
 268
 269         * maint.c (_initialize_maint_cmds): Move initialization code to
 270         remote.c.
 271         (watchdog, show_watchdog): Move to remote.c.
 272         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 273         "watchdog" static.
 274         (_initialize_remote): Move initialization code from maint.c.
 275         * defs.h (watchdog): Don't declare.
 276
 277 2019-05-08  Tom Tromey  <tromey@adacore.com>
 278
 279         * tui/tui-interp.c: Include main.h.
 280         * interps.c: Include main.h.
 281         * main.h (interpreter_p): Declare.
 282         * defs.h (interpreter_p): Don't declare.
 283
 284 2019-05-08  Tom Tromey  <tromey@adacore.com>
 285
 286         * dwarf2loc.c: Include dwarf2read.h.
 287         * defs.h (read_unsigned_leb128): Don't declare.
 288         * dwarf2read.h (read_unsigned_leb128): Declare.
 289
 290 2019-05-08  Tom Tromey  <tromey@adacore.com>
 291
 292         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 293         method.
 294
 295 2019-05-08  Tom Tromey  <tromey@adacore.com>
 296
 297         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 298         when no wrap column is set.
 299
 300 2019-05-08  Tom Tromey  <tromey@adacore.com>
 301
 302         * c-lang.c (c_get_string): Handle non-C-style arrays.
 303
 304 2019-05-08  Tom Tromey  <tromey@adacore.com>
 305
 306         * typeprint.c (print_offset_data::update): Print the bit offset,
 307         not the number of bits remaining.
 308
 309 2019-05-08  Tom Tromey  <tromey@adacore.com>
 310
 311         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 312         padding at end of comment.
 313
 314 2019-05-08  Tom Tromey  <tromey@adacore.com>
 315
 316         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 317         Compare main types.
 318
 319 2019-05-06  Tom Tromey  <tom@tromey.com>
 320
 321         * common/scoped_mmap.c: Include common-defs.h.
 322         * common/scoped_mmap.h: Don't include config.h.
 323
 324 2019-05-04  Tom Tromey  <tom@tromey.com>
 325
 326         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 327         (struct aarch64_call_info): Add initializers.
 328         <si>: Now a std::vector.
 329         (pass_on_stack, aarch64_push_dummy_call): Update.
 330
 331 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 332             Tom Tromey  <tom@tromey.com>
 333
 334         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 335         (ppc_threads): Now a std::vector.  Now static.
 336         (hwdebug_find_thread_points_by_tid)
 337         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 338         Update.
 339
 340 2019-05-04  Tom Tromey  <tom@tromey.com>
 341
 342         * arc-tdep.c (arc_tdesc_init): Return bool.
 343
 344 2019-05-04  Tom Tromey  <tom@tromey.com>
 345
 346         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 347         Use gdb_assert_not_reached.
 348
 349 2019-05-04  Tom Tromey  <tom@tromey.com>
 350
 351         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 352         "false".
 353
 354 2019-05-04  Tom Tromey  <tom@tromey.com>
 355
 356         * arc-tdep.c (arc_tdesc_init): Use bool.
 357
 358 2019-05-04  Tom Tromey  <tom@tromey.com>
 359
 360         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 361
 362 2019-05-04  Tom Tromey  <tom@tromey.com>
 363
 364         * cli/cli-cmds.c (valid_command_p): Return bool.
 365
 366 2019-05-04  Tom Tromey  <tom@tromey.com>
 367
 368         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 369         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 370
 371 2019-05-04  Raul Tambre  <raul@tambre.ee>
 372
 373         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 374         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 375         operator for comparison.
 376
 377 2019-05-04  Tom Tromey  <tom@tromey.com>
 378
 379         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 380         (lookup_partial_symbol, print_partial_symbols)
 381         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 382         (psymbol_compare): Update.
 383         (add_psymbol_to_bcache): Clear the entire psymbol.
 384         (maintenance_check_psymtabs): Update.
 385         * psympriv.h (struct partial_symbol): Don't derive from
 386         general_symbol_info.
 387         <obj_section, unrelocated_address, address,
 388         set_unrelocated_address>: Update.
 389         <ginfo>: New member.
 390         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 391         (debug_names::write_psymbols): Update.
 392
 393 2019-05-04  Tom de Vries  <tdevries@suse.de>
 394
 395         * contrib/cc-with-tweaks.sh: Support -n arg.
 396
 397 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 398
 399         * corelow.c (core_target::detach): Ensure frame cache and
 400         register caches are cleared.
 401         inferior.c (exit_inferior_1): Likewise.
 402
 403 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 404             Tom Tromey  <tom@tromey.com>
 405
 406         * dictionary.c (collate_pending_symbols_by_language): Remove
 407         "struct" from foreach.
 408         * symtab.c (lookup_global_symbol_from_objfile)
 409         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 410         foreach.
 411         * ser-tcp.c (net_open): Remove "struct" from foreach.
 412         * objfiles.c (objfile_relocate, objfile_rebase)
 413         (objfile_has_symbols): Remove "struct" from foreach.
 414         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 415         from foreach.
 416         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 417         foreach.
 418         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 419         "struct" from foreach.
 420         * ada-lang.c (create_excep_cond_exprs)
 421         (ada_exception_catchpoint_cond_string): Remove "struct" from
 422         foreach.
 423
 424 2019-05-03  Tom Tromey  <tromey@adacore.com>
 425
 426         * ada-exp.y (convert_char_literal): Check suffix of each
 427         enumerator.
 428
 429 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 430
 431         PR ada/21406:
 432         * ada-exp.y (yywrap): Don't define.
 433         * ada-lex.l (%option): Add noyywrap
 434         (yywrap): Remove.
 435
 436 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 437
 438         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 439         _WIN32_WINNT to the XP level, unless already defined to a higher
 440         level.
 441
 442         * unittests/parse-connection-spec-selftests.c:
 443         * ser-tcp.c:
 444         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 445         override.
 446
 447         * symfile.c (find_separate_debug_file): Remove colon from the
 448         drive spec of DOS/Windows file names of the target, so that the
 449         file name produced from DEBUGDIR and the target's directory will
 450         be valid on DOS/Windows systems.
 451
 452 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 453
 454         * rust-lang.c (val_print_struct): Handle printing structures
 455         containing strings.
 456
 457 2019-05-02  Tom Tromey  <tromey@adacore.com>
 458
 459         * valarith.c (_initialize_valarith): Remove.
 460
 461 2019-05-01  Tom Tromey  <tromey@adacore.com>
 462
 463         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 464         bitfields.
 465
 466 2019-05-01  Tom Tromey  <tromey@adacore.com>
 467
 468         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 469         for big-endian copies.
 470
 471 2019-04-30  Ali Tamur  <tamur@google.com>
 472         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 473         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 474         (read_3_bytes): New function.
 475
 476 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 477
 478         * windows-nat.c (main_thread_id): Delete.
 479         (handle_output_debug_string): Replace main_thread_id by
 480         current_event.dwThreadId.
 481         (fake_create_process): Likewise.
 482         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 483         Do not set main_thread_id.
 484         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 485         current_event.dwThreadId.
 486         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 487
 488 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 489
 490         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 491         Use current_event.dwThreadId instead of main_thread_id.
 492
 493 2019-04-30  Tom Tromey  <tromey@adacore.com>
 494
 495         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 496         (create_excep_cond_exprs): Iterate over program spaces.
 497         (ada_exception_catchpoint_cond_string): Examine all minimal
 498         symbols for exception types.
 499
 500 2019-04-30  Tom Tromey  <tromey@adacore.com>
 501
 502         PR c++/24470:
 503         * dwarf2read.c (process_structure_scope): Handle case where type
 504         has template parameters but no symbol was created.
 505
 506 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 507             Chris January  <chris.january@arm.com>
 508
 509         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 510         qualifier.
 511         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 512
 513 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 514
 515         * f-typeprint.c (f_print_type): Update rules for printing
 516         whitespace.
 517         (f_type_print_varspec_suffix): Likewise.
 518
 519 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 520             Chris January  <chris.january@arm.com>
 521
 522         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 523         function arguments.
 524
 525 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 526
 527         * f-lang.c (build_fortran_types): Change name of void type to
 528         lower case.
 529         * f-typeprint.c (f_type_print_base): Print the name of the void
 530         type, rather than a fixed string.
 531         * f-valprint.c (f_decorations): Use lower case void string.
 532
 533 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 534             Chris January  <chris.january@arm.com>
 535
 536         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 537         types for Fortran.
 538
 539 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 540             Chris January  <chris.january@arm.com>
 541             David Lecomber  <david.lecomber@arm.com>
 542
 543         * f-exp.y (BINOP_INTRINSIC): New token.
 544         (exp): New parser rule handling BINOP_INTRINSIC.
 545         (f77_keywords): Add new builtin procedures.
 546         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 547         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 548         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 549         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 550         (print_unop_subexp_f): New function.
 551         (print_binop_subexp_f): New function.
 552         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 553         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 554         (dump_subexp_body_f): Likewise.
 555         (operator_check_f): Likewise.
 556         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 557         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 558
 559 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 560
 561         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 562         UNOP_KIND.
 563         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 564         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 565         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 566         (operator_length_f): New fuction.
 567         (print_subexp_f): New function.
 568         (op_name_f): New function.
 569         (dump_subexp_body_f): New function.
 570         (operator_check_f): New function.
 571         (exp_descriptor_f): Replace standard expression handling functions
 572         with new functions.
 573         * gdb/fortran-operator.def: New file.
 574         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 575         * gdb/std-operator.def: Remove UNOP_KIND.
 576
 577 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 578
 579         * std-operator.def: Remove unbalanced, stray double quote
 580         character.
 581
 582 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 583             Chris January  <chris.january@arm.com>
 584             Daniel Everett  <daniel.everett@arm.com>
 585             Nick Forrington  <nick.forrington@arm.com>
 586             Richard Bunt  <richard.bunt@arm.com>
 587
 588         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 589         of depth when printing anonymous structs or unions.
 590         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 591         Don't print either the top-level value, or the children if the
 592         max-depth is exceeded.
 593         (ppscm_print_children): When printing the key of a map, allow one
 594         extra level of depth.
 595         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 596         print either the top-level value, or the children if the max-depth
 597         is exceeded.
 598         (print_children): When printing the key of a map, allow one extra
 599         level of depth.
 600         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 601         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 602         (user_print_options): Initialise max_depth field.
 603         (val_print_scalar_or_string_type_p): New function.
 604         (val_print): Check to see if the max depth has been reached.
 605         (val_print_check_max_depth): Define new function.
 606         (show_print_max_depth): New function.
 607         (_initialize_valprint): Add 'print max-depth' option.
 608         * valprint.h (struct value_print_options) <max_depth>: New field.
 609         (val_print_check_max_depth): Declare new function.
 610         * NEWS: Document new feature.
 611
 612 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 613
 614         * ada-lang.c (ada_language_defn): Initialise new field.
 615         * c-lang.c (c_is_string_type_p): New function.
 616         (c_language_defn): Initialise new field.
 617         (cplus_language_defn): Initialise new field.
 618         (asm_language_defn): Initialise new field.
 619         (minimal_language_defn): Initialise new field.
 620         * c-lang.h (c_is_string_type_p): Declare new function.
 621         * d-lang.c (d_language_defn): Initialise new field.
 622         * f-lang.c (f_is_string_type_p): New function.
 623         (f_language_defn): Initialise new field.
 624         * go-lang.c (go_is_string_type_p): New function.
 625         (go_language_defn): Initialise new field.
 626         * language.c (default_is_string_type_p): New function.
 627         (unknown_language_defn): Initialise new field.
 628         (auto_language_defn): Initialise new field.
 629         * language.h (struct language_defn) <la_is_string_type_p>: New
 630         member variable.
 631         (default_is_string_type_p): Declare new function.
 632         * m2-lang.c (m2_language_defn): Initialise new field.
 633         * objc-lang.c (objc_language_defn): Initialise new field.
 634         * opencl-lang.c (opencl_language_defn): Initialise new field.
 635         * p-lang.c (pascal_is_string_type_p): New function.
 636         (pascal_language_defn): Initialise new field.
 637         * rust-lang.c (rust_is_string_type_p): New function.
 638         (rust_language_defn): Initialise new field.
 639
 640 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 641
 642         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 643         New field.
 644         * ada-lang.c (ada_language_defn): Initialise new field.
 645         * c-lang.c (c_language_defn): Likewise.
 646         (cplus_language_defn): Likewise.
 647         (asm_language_defn): Likewise.
 648         (minimal_language_defn): Likewise.
 649         * d-lang.c (d_language_defn): Likewise.
 650         * f-lang.c (f_language_defn): Likewise.
 651         * go-lang.c (go_language_defn): Likewise.
 652         * language.c (unknown_language_defn): Likewise.
 653         (auto_language_defn): Likewise.
 654         * m2-lang.c (m2_language_defn): Likewise.
 655         * objc-lang.c (objc_language_defn): Likewise.
 656         * opencl-lang.c (opencl_language_defn): Likewise.
 657         * p-lang.c (pascal_language_defn): Likewise.
 658         * rust-lang.c (rust_language_defn): Likewise.
 659
 660 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 661
 662         * ada-lang.c (ada_is_character_type): Change return type to bool.
 663         (ada_is_string_type): Likewise.
 664         * ada-lang.h (ada_is_character_type): Update declaration
 665         (ada_is_string_type): Likewise.
 666
 667 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 668
 669         Support style in 'frame|thread apply'
 670
 671         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 672         * record.c (record_start, record_stop): Update callers of
 673         execute_command_to_string with false.
 674         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 675         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 676         methods.
 677         (class string_file): New constructor with term_out parameter.
 678         Override methods term_out and can_emit_style_escape.  New member
 679         term_out.
 680         (class stdio_file): Override can_emit_style_escape.
 681         (class tee_file): Override term_out and can_emit_style_escape.
 682         * utils.h (can_emit_style_escape): Remove.
 683         * utils.c (can_emit_style_escape): Likewise.
 684         Update all callers of can_emit_style_escape (SOMESTREAM) to
 685         SOMESTREAM->can_emit_style_escape.
 686         * source-cache.c (source_cache::get_source_lines): Likewise.
 687         * stack.c (frame_apply_command_count): Call execute_command_to_string
 688         passing the term_out characteristic of the current gdb_stdout.
 689         * thread.c (thr_try_catch_cmd): Likewise.
 690         * top.c (execute_command_to_string): pass term_out parameter
 691         to construct the string_file for the command output.
 692         * ui-file.c (term_cli_styling): New function (most code moved
 693         from utils.c can_emit_style_escape).
 694         (string_file::string_file, string_file::can_emit_style_escape,
 695         stdio_file::can_emit_style_escape, tee_file::term_out,
 696         tee_file::can_emit_style_escape): New functions.
 697
 698 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 699
 700         * NEWS: Mention the new set|show may-call-functions.
 701         * infcall.c (may_call_functions_p): New variable.
 702         (show_may_call_functions_p): New function.
 703         (call_function_by_hand_dummy): Throws an error if not
 704         may-call-functions.
 705         (_initialize_infcall): Call add_setshow_boolean_cmd for
 706         may-call-functions.
 707
 708 2019-04-25  Keith Seitz  <keiths@redhat.com>
 709
 710         PR c++/24367
 711         * cp-support.c (inspect_type): Don't attempt substitutions
 712         of symbol with the same name.
 713
 714 2019-04-25  Tom Tromey  <tromey@adacore.com>
 715
 716         PR gdb/24475:
 717         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 718         static.
 719
 720 2019-04-25  Tom Tromey  <tromey@adacore.com>
 721
 722         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 723         rvalue reference.
 724         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 725         (gdb_xml_parser::parse): Use std::move.
 726         * python/python-internal.h (gdbpy_convert_exception): Take a const
 727         reference.
 728         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 729         std::move.
 730         * python/py-utils.c (gdbpy_convert_exception): Take a const
 731         reference.
 732         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 733         Use std::move.
 734         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 735         Use std::move.
 736         * mi/mi-main.c (mi_print_exception): Take a const reference.
 737         * main.c (handle_command_errors): Take a const reference.
 738         * linespec.c (parse_linespec): Use std::move.
 739         * infcall.c (run_inferior_call): Use std::move.
 740         (call_function_by_hand_dummy): Use std::move.
 741         * exec.c (try_open_exec_file): Use std::move.
 742         * exceptions.h (exception_print, exception_fprintf)
 743         (exception_print_same): Update.
 744         * exceptions.c (print_exception, exception_print)
 745         (exception_fprintf, exception_print_same): Change parameters to
 746         const reference.
 747         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 748         * common/new-op.c: Use std::move.
 749         * common/common-exceptions.h (struct gdb_exception): Add move
 750         constructor.
 751         (struct gdb_exception_error, struct gdb_exception_quit, struct
 752         gdb_quit_bad_alloc): Change constructor to move constructor.
 753         (throw_exception): Change parameter to rvalue reference.
 754         * common/common-exceptions.c (throw_exception): Take rvalue
 755         reference.
 756         * cli/cli-interp.c (safe_execute_command): Use std::move.
 757         * breakpoint.c (insert_bp_location, location_to_sals): Use
 758         std::move.
 759
 760 2019-04-25  Tom Tromey  <tromey@adacore.com>
 761
 762         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 763         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 764         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 765         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 766         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 767         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 768         guile/scm-value.c: Use unpack.
 769         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 770         gdbscm_gdb_exception.
 771         (gdbscm_throw_gdb_exception): Likewise.
 772         (struct gdbscm_gdb_exception): New.
 773         (unpack): New function.
 774         (gdbscm_wrap): Use unpack.
 775
 776 2019-04-25  Tom Tromey  <tromey@adacore.com>
 777
 778         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 779         (gdb_rl_callback_handler): Use std::move.
 780         * common/common-exceptions.h (struct gdb_exception): Add move
 781         assignment operator.
 782         (throw_exception_sjlj): Change "exception" to const reference.
 783         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 784         (throw_exception_sjlj): Change "exception" to const reference.
 785
 786 2019-04-25  Tom Tromey  <tromey@adacore.com>
 787
 788         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 789         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 790         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 791         Update.
 792         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 793         Update.
 794         * mi/mi-interp.c (mi_interp::exec): Update.
 795         * linespec.c (parse_linespec): Update.
 796         * infcall.c (run_inferior_call): Update.
 797         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 798         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 799         (gdbscm_lookup_global_symbol): Update.
 800         * guile/scm-param.c (gdbscm_parameter_value): Update.
 801         * guile/scm-frame.c (gdbscm_frame_read_register)
 802         (gdbscm_frame_read_var): Update.
 803         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 804         * exec.c (try_open_exec_file): Update.
 805         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 806         (gdb_rl_callback_handler): Update.
 807         * common/common-exceptions.h (exception_none): Don't declare.
 808         * common/common-exceptions.c (exception_none): Don't define.
 809         (struct catcher) <exception>: Update.
 810         * cli/cli-interp.c (safe_execute_command): Update.
 811         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 812
 813 2019-04-25  Ali Tamur  <tamur@google.com>
 814
 815         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 816         (read_attribute_value): Likewise.
 817         (dwarf2_read_addr_index): Update comment.
 818         (read_str_index): Add DW_FORM_strx.
 819         (dwarf2_string_attr): Likewise.
 820         (dwarf2_const_value_attr): Likewise.
 821         (dump_die_shallow): Likewise.
 822         (dwarf2_fetch_constant_bytes): Likewise.
 823         (skip_form_bytes): Likewise.
 824         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 825
 826 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 827
 828         PR corefiles/11608
 829         PR corefiles/18187
 830         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 831         OFFSET.  Verify if current mapping contains an ELF header.
 832         (linux_find_memory_regions_full): Adjust call to
 833         dump_mapping_p.
 834
 835 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 836             Kang Li <kanglictf@gmail.com>
 837
 838         PR gdb/21600
 839
 840         * dwarf2-frame.c (read_initial_length): Be consistent about using
 841         unsigned representation of length.
 842         (decode_frame_entry_1): Likewise.  Check for wraparound of
 843         end pointer as well as buffer overflow.
 844
 845 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 846
 847         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 848         "vq".
 849
 850 2019-04-24  Tom Tromey  <tromey@adacore.com>
 851
 852         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 853
 854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 855
 856         * s12z-tdep.c (s12z_unwind_pc): Delete.
 857         (s12z_unwind_sp): Delete.
 858         (s12z_gdbarch_init): Don't register deleted functions with
 859         gdbarch.
 860
 861 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 862
 863         * rl78-tdep.c (rl78_unwind_sp): Delete.
 864         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 865
 866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 867
 868         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 869         (xstormy16_unwind_pc): Delete.
 870         (xstormy16_dummy_id): Delete.
 871         (xstormy16_gdbarch_init): Don't register deleted functions with
 872         gdbarch.
 873
 874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 875
 876         * vax-tdep.c (vax_unwind_pc): Delete.
 877         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 878
 879 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 880
 881         * v850-tdep.c (v850_unwind_sp): Delete.
 882         (v850_unwind_pc): Delete.
 883         (v850_dummy_id): Delete.
 884         (v850_gdbarch_init): Don't register deleted functions with
 885         gdbarch.
 886
 887 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 888
 889         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 890         (tilegx_unwind_pc): Delete.
 891         (tilegx_unwind_dummy_id): Delete.
 892         (tilegx_gdbarch_init): Don't register deleted functions with
 893         gdbarch.
 894
 895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 896
 897         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 898         (tic6x_dummy_id): Delete.
 899         (tic6x_gdbarch_init): Don't register deleted functions with
 900         gdbarch.
 901
 902 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 903
 904         * sparc-tdep.c (sparc_unwind_pc): Delete.
 905         (sparc32_gdbarch_init): Don't register deleted function with
 906         gdbarch.
 907
 908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 909
 910         * sh-tdep.c (sh_unwind_sp): Delete.
 911         (sh_unwind_pc): Delete.
 912         (sh_dummy_id): Delete.
 913         (sh_gdbarch_init): Don't register deleted functions with
 914         gdbarch.
 915
 916 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 917
 918         * score-tdep.c (score_unwind_sp): Delete.
 919         (score_unwind_pc): Delete.
 920         (score_dummy_id): Delete.
 921         (score_gdbarch_init): Don't register deleted functions with
 922         gdbarch.
 923
 924 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 925
 926         * rx-tdep.c (rx_unwind_pc): Delete.
 927         (rx_unwind_sp): Delete.
 928         (rx_dummy_id): Delete.
 929         (rx_gdbarch_init): Don't register deleted functions with
 930         gdbarch.  Update comment.
 931
 932 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 933
 934         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 935         (rs6000_dummy_id): Delete.
 936         (rs6000_gdbarch_init): Don't register deleted functions with
 937         gdbarch.
 938
 939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 940
 941         * or1k-tdep.c (or1k_dummy_id): Delete.
 942         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 943
 944 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 945
 946         * nios2-tdep.c (nios2_dummy_id): Delete.
 947         (nios2_unwind_sp): Delete.
 948         (nios2_gdbarch_init): Don't register deleted functions with
 949         gdbarch.
 950
 951 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 952
 953         * nds32-tdep.c (nds32_dummy_id): Delete.
 954         (nds32_unwind_pc): Delete.
 955         (nds32_unwind_sp): Delete.
 956         (nds32_gdbarch_init): Don't register deleted functions with
 957         gdbarch.
 958
 959 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 960
 961         * msp430-tdep.c (msp430_unwind_pc): Delete.
 962         (msp430_unwind_sp): Delete.
 963         (msp430_dummy_id): Delete.
 964         (msp430_gdbarch_init): Don't register deleted functions with
 965         gdbarch.
 966
 967 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 968
 969         * moxie-tdep.c (moxie_unwind_sp): Delete.
 970         (moxie_unwind_pc): Delete.
 971         (moxie_dummy_id): Delete.
 972         (moxie_gdbarch_init): Don't register deleted functions with
 973         gdbarch.
 974
 975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 976
 977         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 978         (mn10300_unwind_pc): Delete.
 979         (mn10300_unwind_sp): Delete.
 980         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 981         mn10300_unwind_sp.
 982         (mn10300_frame_unwind_init): Don't register deleted functions with
 983         gdbarch.
 984
 985 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 986
 987         * mep-tdep.c (mep_unwind_pc): Delete.
 988         (mep_unwind_sp): Delete.
 989         (mep_dummy_id): Delete.
 990         (mep_gdbarch_init): Don't register deleted functions with
 991         gdbarch.
 992
 993 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 994
 995         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 996         (m68hc11_unwind_sp): Delete.
 997         (m68hc11_gdbarch_init): Don't register deleted functions with
 998         gdbarch.
 999
1000 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1001
1002         * m32r-tdep.c (m32r_unwind_sp): Delete.
1003         (m32r_unwind_pc): Delete.
1004         (m32r_dummy_id): Delete.
1005         (m32r_gdbarch_init): Don't register deleted functions with
1006         gdbarch.
1007
1008 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1009
1010         * m32c-tdep.c (m32c_unwind_pc): Delete.
1011         (m32c_unwind_sp): Delete.
1012         (m32c_dummy_id): Delete.
1013         (m32c_gdbarch_init): Don't register deleted functions with
1014         gdbarch.
1015
1016 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1017
1018         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1019         (lm32_unwind_pc): Delete.
1020         (lm32_dummy_id): Delete.
1021         (lm32_gdbarch_init): Don't register deleted functions with
1022         gdbarch.
1023
1024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1025
1026         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1027         (iq2000_unwind_pc): Delete.
1028         (iq2000_dummy_id): Delete.
1029         (iq2000_gdbarch_init): Don't register deleted functions with
1030         gdbarch.
1031
1032 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1033
1034         * nds32-tdep.c (nds32_type_align): Delete.
1035         (nds32_push_dummy_call): Use type_align instead.
1036
1037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1038
1039         * arm-tdep.c (arm_type_align): Only handle vector override case.
1040         (arm_push_dummy_call): Use type_align.
1041         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1042
1043 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1044
1045         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1046         case.
1047         (pass_on_stack): Use type_align.
1048         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1049         function.
1050
1051 2019-04-23  Tom Tromey  <tromey@adacore.com>
1052
1053         * dwarf2read.c (line_header::file_name_at): Remove unused
1054         overload.
1055
1056 2019-04-23  Tom de Vries  <tdevries@suse.de>
1057
1058         PR gdb/24438
1059         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1060         invocation.
1061
1062
1063 2019-03-27  Ali Tamur  <tamur@google.com>
1064
1065         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1066         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1067         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1068         (dwarf_expr_context::get_addr_index): Likewise
1069         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1070         (symbol_needs_eval_context::get_addr_index): Likewise
1071         (disassemble_dwarf_expression): Add DW_OP_addrx
1072         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1073         (read_cutu_die_from_dwo): Update comment
1074         (skip_one_die): Add DW_FORM_addrx
1075         (read_attribute_value): Likewise
1076         (var_decode_location): Add DW_OP_addrx
1077         (dwarf2_const_value_attr): Add DW_FORM_addrx
1078         (dump_die_shallow): Likewise
1079         (dwarf2_fetch_constant_bytes): Likewise
1080         (decode_locdesc): Add DW_OP_addrx
1081         (skip_form_bytes): Add DW_FORM_addrx
1082
1083 2019-04-22  Ali Tamur  <tamur@google.com>
1084
1085         * MAINTAINERS (Write After Approval): Add self.
1086
1087 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1088
1089         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1090         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1091         (open_symbol_file_object): Likewise.
1092         (svr4_default_sos): Add info parameter.
1093         (svr4_read_so_list): Likewise.
1094         (svr4_current_sos_direct): Adjust functions calls to pass down
1095         info.
1096         (svr4_current_sos_1): Add info parameter.
1097         (svr4_current_sos): Call get_svr4_info, pass info down to
1098         svr4_current_sos_1.
1099         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1100         get_svr4_info.
1101         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1102         get_svr4_info.
1103         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1104         to get_svr4_info.
1105         (probes_table_remove_objfile_probes): Likewise.
1106         (register_solib_event_probe): Add info parameter.
1107         (solist_update_incremental): Pass info parameter down to
1108         svr4_read_so_list.
1109         (disable_probes_interface): Add info parameter.
1110         (svr4_handle_solib_event): Pass current_program_space to
1111         get_svr4_info.  Adjust disable_probes_interface cleanup.
1112         (svr4_create_probe_breakpoints): Add info parameter, pass it
1113         down to register_solib_event_probe.
1114         (svr4_create_solib_event_breakpoints): Add info parameter,
1115         pass it down to svr4_create_probe_breakpoints.
1116         (enable_break): Pass info down to
1117         svr4_create_solib_event_breakpoints.
1118         (svr4_solib_create_inferior_hook): Pass current_program_space to
1119         get_svr4_info.
1120         (svr4_clear_solib): Likewise.
1121
1122 2019-04-22  Pedro Alves  <palves@redhat.com>
1123
1124         * solib-svr4.c (svr4_free_objfile_observer): New.
1125         (probe_and_action::objfile): New field.
1126         (probes_table_htab_remove_objfile_probes)
1127         (probes_table_remove_objfile_probes): New functions.
1128         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1129         in the new probe_and_action.  Don't store the probe in 'lookup'.
1130         (svr4_create_probe_breakpoints): Pass objfile to
1131         register_solib_event_probe.
1132         (_initialize_svr4_solib): Register a free_objfile observer.
1133
1134 2019-04-19  Tom Tromey  <tom@tromey.com>
1135
1136         * common/queue.h: Remove.
1137
1138 2019-04-19  Tom Tromey  <tom@tromey.com>
1139
1140         * event-loop.c: Don't include "common/queue.h".
1141
1142 2019-04-19  Tom Tromey  <tom@tromey.com>
1143
1144         * remote.c (remote_target): Use delete.
1145         * remote-notif.h: Include <list>, not "common/queue.h".
1146         (notif_client_p): Remove typedef.
1147         (remote_notif_state): Add constructor, destructor, initializer.
1148         <notif_queue>: Now a std::list.
1149         (remote_notif_state_xfree): Don't declare.
1150         * remote-notif.c (remote_notif_process, handle_notification)
1151         (remote_notif_state_allocate): Update.
1152         (~remote_notif_state): Rename from remote_notif_state_xfree.
1153
1154 2019-04-19  Tom Tromey  <tom@tromey.com>
1155
1156         * symfile.c (reread_symbols): Update.
1157         * objfiles.c (objfile_register_static_link)
1158         (objfile_lookup_static_link): Update
1159         (~objfile) Don't delete static_links.
1160         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1161
1162 2019-04-19  Tom Tromey  <tom@tromey.com>
1163
1164         * type-stack.h (struct type_stack) <insert>: Constify string.
1165         * type-stack.c (type_stack::insert): Constify string.
1166         * gdbtypes.h (lookup_template_type): Update.
1167         (address_space_name_to_int): Update.
1168         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1169         const.
1170         (lookup_template_type): Make name const.
1171         * c-exp.y: Update rules.
1172         (lex_one_token, classify_name, classify_inner_name)
1173         (c_print_token): Update.
1174         * p-exp.y: Update rules.
1175         (yylex): Update.
1176         * f-exp.y: Update rules.
1177         (yylex): Update.
1178         * d-exp.y: Update rules.
1179         (lex_one_token, classify_name, classify_inner_name): Update.
1180         * parse.c (write_dollar_variable, copy_name): Return std::string.
1181         * parser-defs.h (copy_name): Change return type.
1182         * m2-exp.y: Update rules.
1183         (yylex): Update.
1184         * go-exp.y (lex_one_token): Update.
1185         Update rules.
1186         (classify_unsafe_function, classify_packaged_name)
1187         (classify_name, yylex): Update.
1188
1189 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1190
1191         * configure.ac: add --enable-source-highlight switch.
1192         * configure: Regenerate.
1193         * top.c (print_gdb_version): plumb --enable-source-highlight
1194         status to "show configuration".
1195
1196 2019-04-19  Tom Tromey  <tromey@adacore.com>
1197
1198         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1199         Check ADA_TYPE_P.
1200         (empty_record, ada_template_to_fixed_record_type_1)
1201         (template_to_static_fixed_type)
1202         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1203         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1204         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1205         macros.
1206
1207 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1208
1209         PR symtab/24423:
1210         * source.c (print_source_lines_base): Advance "iter" when a
1211         control character is seen.
1212
1213 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1214
1215         * inferior.h (struct infcall_suspend_state_deleter):
1216         Catch exception in destructor to avoid crash.
1217
1218 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1219
1220         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1221         close to the add_com "shell".
1222
1223 2019-04-18  Tom Tromey  <tromey@adacore.com>
1224
1225         * process-stratum-target.h (class process_stratum_target)
1226         <stratum>: Add "final".
1227
1228 2019-04-17  Tom Tromey  <tromey@adacore.com>
1229
1230         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1231         against nullptr before use.
1232
1233 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1234
1235         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1236
1237 2019-04-17  Jim Wilson  <jimw@sifive.com>
1238             Andrew Burgess  <andrew.burgess@embecosm.com>
1239
1240         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1241         code read might fail, assume 4-byte breakpoint in that case.
1242
1243 2019-04-15  Leszek Swirski  <leszeks@google.com>
1244
1245         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1246         rather than a hand-rolled POD check when checking for forced MEMORY
1247         classification.
1248
1249 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1250
1251         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1252         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1253         function.
1254         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1255         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1256         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1257         declaration.
1258
1259 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1260
1261         * aarch64-linux-nat.c
1262         (aarch64_linux_nat_target::thread_architecture): Add override.
1263         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1264         each VQ.
1265
1266 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1267
1268         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1269
1270 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1271
1272         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1273         target types of size 96-bits, add some additional comments, and
1274         check that the builtin type we found was the correct size.
1275
1276 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1277
1278         * utils.c (prompt_for_continue): Don't restore the styling at the
1279         end, as applied_style has the wrong value.  This fixes styling in
1280         long lists of file names that are interrupted by the "Continue?"
1281         prompt.
1282
1283 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1284
1285         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1286         * c-lang.c (c_language_defn): Likewise.
1287         (cplus_language_defn): Likewise.
1288         (asm_language_defn): Likewise.
1289         (minimal_language_defn): Likewise.
1290         * d-lang.c (d_language_defn): Likewise.
1291         * f-lang.c (f_language_defn): Likewise.
1292         * go-lang.c (go_language_defn): Likewise.
1293         * language.c (unknown_language_defn): Likewise.
1294         (auto_language_defn): Likewise.
1295         * language.h (struct language_defn): Remove la_magic field.
1296         (LANG_MAGIC): Delete.
1297         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1298         * objc-lang.c (objc_language_defn): Likewise.
1299         * opencl-lang.c (opencl_language_defn): Likewise.
1300         * p-lang.c (pascal_language_defn): Likewise.
1301         * rust-lang.c (rust_language_defn): Likewise.
1302
1303 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1304
1305         * riscv-tdep.c (riscv_type_align): New function.
1306         (riscv_type_alignment): Delete.
1307         (riscv_arg_location): Use 'type_align'.
1308         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1309
1310 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1311
1312         * gdbtypes.c (type_align): A struct with no non-static fields also
1313         has alignment of 1.
1314
1315 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1316
1317         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1318         component to 0.
1319         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1320         member.
1321         (riscv_struct_info::analyse): New implementation using new
1322         analyse_inner member function.
1323         (riscv_struct_info::field_offset): New member function.
1324         (riscv_struct_info::m_offsets): New member variable.
1325         (riscv_struct_info::analyse_inner): New private member function,
1326         takes the old implementation of riscv_struct_info::analyse but
1327         extended to track field offsets.
1328         (riscv_call_arg_struct): Update the struct folding special cases
1329         to handle cases where empty C++ structs, which are non-zero
1330         length, are found.
1331         (riscv_arg_location): Initialise the length of each location, a
1332         non-zero length now indicates the location is in use.
1333         (riscv_push_dummy_call): Allow for the first location having a
1334         non-zero offset when setting up arguments.
1335         (riscv_return_value): Likewise, but for return values.
1336
1337 2019-04-11  Tom Tromey  <tromey@adacore.com>
1338
1339         * utils.c (internal_vproblem): Make "msg" const.
1340
1341 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1342
1343         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1344         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1345         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1346         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1347
1348 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1349
1350         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1351         function.
1352         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1353         of amd64_collect_native_gregset.
1354         (amd64_linux_nat_target::store_registers): Likewise.
1355
1356 2019-04-10  Tom Tromey  <tom@tromey.com>
1357
1358         * symtab.c (lookup_global_symbol_from_objfile)
1359         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1360         * objfiles.h (class separate_debug_iterator): New.
1361         (class separate_debug_range): New.
1362         (struct objfile) <separate_debug_objfiles>: New method.
1363         (objfile_separate_debug_iterate): Don't declare.
1364         * objfiles.c (separate_debug_iterator::operator++): Rename from
1365         objfile_separate_debug_iterate.
1366         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1367         iterator.
1368         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1369         iterator.
1370
1371 2019-04-10  Tom Tromey  <tom@tromey.com>
1372
1373         * symfile.c (reread_symbols): Remove old comment.
1374         * objfiles.c (free_all_objfiles): Fix a typo.
1375
1376 2019-04-10  Tom Tromey  <tom@tromey.com>
1377
1378         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1379         * minsyms.c (lookup_minimal_symbol): Use foreach.
1380         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1381         (lookup_minimal_symbol_solib_trampoline): Likewise.
1382         * symfile.c (reread_symbols): Use foreach.
1383
1384 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1385             Tom Tromey  <tromey@adacore.com>
1386
1387         PR rust/24414:
1388         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1389         (rust_lex_int_test): Change "value" to be LONGEST.
1390         (rust_lex_tests): Add test for long integer literal.
1391
1392 2019-04-09  Tom Tromey  <tromey@adacore.com>
1393
1394         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1395         to bool.
1396         (extended_remote_target::attach): Update.
1397         (remote_target::remote_notice_new_inferior): Update.
1398         (remote_target::add_current_inferior_and_thread): Update.
1399         * inferior.c (exit_inferior_1): Use "false".
1400         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1401
1402 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1403
1404         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1405         the "start" command.
1406
1407 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1408
1409         * python/py-inferior.c (infpy_thread_from_thread_handle):
1410         Adjust comments to reflect renaming of thread_from_thread_handle
1411         to thread_from_handle.  Adjust keywords.  Fix type error message.
1412         (inferior_object_methods): Add thread_from_handle.  Retain
1413         thread_from_thread_handle, but mark it as deprecated.
1414
1415 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1416
1417         * gdbthread.h (find_thread_by_handle): Revise declaration.
1418         * thread.c (find_thread_by_handle): Likewise.  Adjust
1419         implementation too.
1420         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1421         support for buffer objects as handles.
1422
1423 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1424
1425         * python/py-infthread.c (thpy_thread_handle): New function.
1426         (thread_object_methods): Register thpy_thread_handle.
1427
1428 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1429
1430         * gdbthread.h (thread_to_thread_handle): Declare.
1431         * thread.c (gdbtypes.h): Include.
1432         (thread_to_thread_handle): New function.
1433
1434         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1435         (target_thread_info_to_thread_handle): Declare.
1436         * target.c (target_thread_info_to_thread_handle): New function.
1437         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1438         * target-delegates.c: Regenerate.
1439
1440         * linux-thread-db.c (class thread_db_target): Add method
1441         thread_info_to_thread_handle.
1442         (thread_db_target::thread_info_to_thread_handle): Define.
1443         * remote.c (class remote_target): Add new method
1444         thread_info_to_thread_handle.
1445         (remote_target::thread_info_to_thread_handle): Define.
1446
1447 2019-04-08  Pedro Alves  <palves@redhat.com>
1448
1449         * common/common-exceptions.c (throw_exception): Don't create
1450         named object to throw; throw directly.
1451         (throw_it): Likewise.  Don't initialize gdb_exception::message
1452         here, with new; pass FMT and AP to the ctor instead.
1453         * common/common-exceptions.h: Include <string>.
1454         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1455         const char *, va_list)): New ctor.  Use std::make_shared.
1456         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1457         errors)): Delete.
1458         (gdb_exception_error::gdb_exception_error(enum errors, const char
1459         *, va_list)): New.
1460         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1461         Add assertion.
1462         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1463         errors)): Delete.
1464         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1465         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1466         Add assertion.
1467
1468 2019-04-08  Tom Tromey  <tom@tromey.com>
1469
1470         * valops.c (value_rtti_indirect_type): Replace throw_exception
1471         with throw.
1472         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1473         with throw.
1474         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1475         throw.
1476         * target.c (target_translate_tls_address): Replace throw_exception
1477         with throw.
1478         * stack.c (frame_apply_command_count): Replace throw_exception
1479         with throw.
1480         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1481         throw.
1482         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1483         with throw.
1484         * rs6000-tdep.c (rs6000_frame_cache)
1485         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1486         * remote.c: Replace throw_exception with throw.
1487         * record-full.c (record_full_message, record_full_wait_1)
1488         (record_full_restore): Replace throw_exception with throw.
1489         * record-btrace.c:
1490         (get_thread_current_frame_id, record_btrace_start_replaying)
1491         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1492         (cmd_record_btrace_start): Replace throw_exception with throw.
1493         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1494         throw.
1495         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1496         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1497         * linespec.c:
1498         (find_linespec_symbols): Replace throw_exception with throw.
1499         * infrun.c (displaced_step_prepare, resume): Replace
1500         throw_exception with throw.
1501         * infcmd.c (post_create_inferior): Replace throw_exception with
1502         throw.
1503         * inf-loop.c (inferior_event_handler): Replace throw_exception
1504         with throw.
1505         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1506         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1507         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1508         (get_prev_frame_always, get_frame_pc_if_available)
1509         (get_frame_address_in_block_if_available, get_frame_language):
1510         Replace throw_exception with throw.
1511         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1512         throw_exception with throw.
1513         * eval.c (fetch_subexp_value, evaluate_var_value)
1514         (evaluate_funcall, evaluate_subexp_standard): Replace
1515         throw_exception with throw.
1516         * dwarf2loc.c (call_site_find_chain)
1517         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1518         Replace throw_exception with throw.
1519         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1520         with throw.
1521         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1522         throw.
1523         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1524         * completer.c (complete_line_internal): Replace throw_exception
1525         with throw.
1526         * compile/compile-object-run.c (compile_object_run): Replace
1527         throw_exception with throw.
1528         * cli/cli-script.c (process_next_line): Replace throw_exception
1529         with throw.
1530         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1531         (btrace_enable, btrace_maint_update_pt_packets): Replace
1532         throw_exception with throw.
1533         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1534         throw_exception with throw.
1535         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1536         throw_exception with throw.
1537         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1538         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1539         * aarch64-tdep.c (aarch64_make_prologue_cache)
1540         (aarch64_make_stub_cache): Replace throw_exception with throw.
1541
1542 2019-04-08  Tom Tromey  <tom@tromey.com>
1543
1544         * common/common-exceptions.c (throw_exception): Rename from
1545         throw_exception_cxx.  Remove old copy.  Make argument const.
1546         (throw_it): Create and throw exception objects directly.
1547         * common/common-exceptions.h (throw_exception): Make argument
1548         const.
1549         (struct gdb_exception_error): Add constructor.
1550         (struct gdb_exception_quit): Add constructor.
1551
1552 2019-04-08  Tom Tromey  <tom@tromey.com>
1553
1554         * common/common-exceptions.h (exception_rethrow): Don't declare.
1555         (TRY_SJLJ): Update comment.
1556         (TRY, CATCH, END_CATCH): Remove.
1557         * common/common-exceptions.c (exception_rethrow): Remove.
1558
1559 2019-04-08  Tom Tromey  <tom@tromey.com>
1560
1561         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1562         Remove.
1563         (gdb_exception_error): Rename from
1564         gdb_exception_RETURN_MASK_ERROR.
1565         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1566         (gdb_quit_bad_alloc): Update.
1567         * aarch64-tdep.c: Update.
1568         * ada-lang.c: Update.
1569         * ada-typeprint.c: Update.
1570         * ada-valprint.c: Update.
1571         * amd64-tdep.c: Update.
1572         * arch-utils.c: Update.
1573         * break-catch-throw.c: Update.
1574         * breakpoint.c: Update.
1575         * btrace.c: Update.
1576         * c-varobj.c: Update.
1577         * cli/cli-cmds.c: Update.
1578         * cli/cli-interp.c: Update.
1579         * cli/cli-script.c: Update.
1580         * common/common-exceptions.c: Update.
1581         * common/new-op.c: Update.
1582         * common/selftest.c: Update.
1583         * compile/compile-c-symbols.c: Update.
1584         * compile/compile-cplus-symbols.c: Update.
1585         * compile/compile-object-load.c: Update.
1586         * compile/compile-object-run.c: Update.
1587         * completer.c: Update.
1588         * corelow.c: Update.
1589         * cp-abi.c: Update.
1590         * cp-support.c: Update.
1591         * cp-valprint.c: Update.
1592         * darwin-nat.c: Update.
1593         * disasm-selftests.c: Update.
1594         * dtrace-probe.c: Update.
1595         * dwarf-index-cache.c: Update.
1596         * dwarf-index-write.c: Update.
1597         * dwarf2-frame-tailcall.c: Update.
1598         * dwarf2-frame.c: Update.
1599         * dwarf2loc.c: Update.
1600         * dwarf2read.c: Update.
1601         * eval.c: Update.
1602         * event-loop.c: Update.
1603         * event-top.c: Update.
1604         * exec.c: Update.
1605         * f-valprint.c: Update.
1606         * fbsd-tdep.c: Update.
1607         * frame-unwind.c: Update.
1608         * frame.c: Update.
1609         * gdbtypes.c: Update.
1610         * gnu-v3-abi.c: Update.
1611         * guile/guile-internal.h: Update.
1612         * guile/scm-block.c: Update.
1613         * guile/scm-breakpoint.c: Update.
1614         * guile/scm-cmd.c: Update.
1615         * guile/scm-disasm.c: Update.
1616         * guile/scm-frame.c: Update.
1617         * guile/scm-lazy-string.c: Update.
1618         * guile/scm-math.c: Update.
1619         * guile/scm-param.c: Update.
1620         * guile/scm-ports.c: Update.
1621         * guile/scm-pretty-print.c: Update.
1622         * guile/scm-symbol.c: Update.
1623         * guile/scm-symtab.c: Update.
1624         * guile/scm-type.c: Update.
1625         * guile/scm-value.c: Update.
1626         * i386-linux-tdep.c: Update.
1627         * i386-tdep.c: Update.
1628         * inf-loop.c: Update.
1629         * infcall.c: Update.
1630         * infcmd.c: Update.
1631         * infrun.c: Update.
1632         * jit.c: Update.
1633         * language.c: Update.
1634         * linespec.c: Update.
1635         * linux-fork.c: Update.
1636         * linux-nat.c: Update.
1637         * linux-tdep.c: Update.
1638         * linux-thread-db.c: Update.
1639         * main.c: Update.
1640         * mi/mi-cmd-break.c: Update.
1641         * mi/mi-cmd-stack.c: Update.
1642         * mi/mi-interp.c: Update.
1643         * mi/mi-main.c: Update.
1644         * objc-lang.c: Update.
1645         * p-valprint.c: Update.
1646         * parse.c: Update.
1647         * ppc-linux-tdep.c: Update.
1648         * printcmd.c: Update.
1649         * python/py-arch.c: Update.
1650         * python/py-breakpoint.c: Update.
1651         * python/py-cmd.c: Update.
1652         * python/py-finishbreakpoint.c: Update.
1653         * python/py-frame.c: Update.
1654         * python/py-framefilter.c: Update.
1655         * python/py-gdb-readline.c: Update.
1656         * python/py-inferior.c: Update.
1657         * python/py-infthread.c: Update.
1658         * python/py-lazy-string.c: Update.
1659         * python/py-linetable.c: Update.
1660         * python/py-objfile.c: Update.
1661         * python/py-param.c: Update.
1662         * python/py-prettyprint.c: Update.
1663         * python/py-progspace.c: Update.
1664         * python/py-record-btrace.c: Update.
1665         * python/py-record.c: Update.
1666         * python/py-symbol.c: Update.
1667         * python/py-type.c: Update.
1668         * python/py-unwind.c: Update.
1669         * python/py-utils.c: Update.
1670         * python/py-value.c: Update.
1671         * python/python.c: Update.
1672         * record-btrace.c: Update.
1673         * record-full.c: Update.
1674         * remote-fileio.c: Update.
1675         * remote.c: Update.
1676         * riscv-tdep.c: Update.
1677         * rs6000-aix-tdep.c: Update.
1678         * rs6000-tdep.c: Update.
1679         * rust-exp.y: Update.
1680         * rust-lang.c: Update.
1681         * s390-tdep.c: Update.
1682         * selftest-arch.c: Update.
1683         * solib-dsbt.c: Update.
1684         * solib-frv.c: Update.
1685         * solib-spu.c: Update.
1686         * solib-svr4.c: Update.
1687         * solib.c: Update.
1688         * sparc64-linux-tdep.c: Update.
1689         * stack.c: Update.
1690         * symfile-mem.c: Update.
1691         * symmisc.c: Update.
1692         * target.c: Update.
1693         * thread.c: Update.
1694         * top.c: Update.
1695         * tracefile-tfile.c: Update.
1696         * tui/tui.c: Update.
1697         * typeprint.c: Update.
1698         * unittests/cli-utils-selftests.c: Update.
1699         * unittests/parse-connection-spec-selftests.c: Update.
1700         * valops.c: Update.
1701         * valprint.c: Update.
1702         * value.c: Update.
1703         * varobj.c: Update.
1704         * windows-nat.c: Update.
1705         * x86-linux-nat.c: Update.
1706         * xml-support.c: Update.
1707
1708 2019-04-08  Tom Tromey  <tom@tromey.com>
1709
1710         * xml-support.c: Use C++ exception handling.
1711         * x86-linux-nat.c: Use C++ exception handling.
1712         * windows-nat.c: Use C++ exception handling.
1713         * varobj.c: Use C++ exception handling.
1714         * value.c: Use C++ exception handling.
1715         * valprint.c: Use C++ exception handling.
1716         * valops.c: Use C++ exception handling.
1717         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1718         handling.
1719         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1720         * typeprint.c: Use C++ exception handling.
1721         * tui/tui.c: Use C++ exception handling.
1722         * tracefile-tfile.c: Use C++ exception handling.
1723         * top.c: Use C++ exception handling.
1724         * thread.c: Use C++ exception handling.
1725         * target.c: Use C++ exception handling.
1726         * symmisc.c: Use C++ exception handling.
1727         * symfile-mem.c: Use C++ exception handling.
1728         * stack.c: Use C++ exception handling.
1729         * sparc64-linux-tdep.c: Use C++ exception handling.
1730         * solib.c: Use C++ exception handling.
1731         * solib-svr4.c: Use C++ exception handling.
1732         * solib-spu.c: Use C++ exception handling.
1733         * solib-frv.c: Use C++ exception handling.
1734         * solib-dsbt.c: Use C++ exception handling.
1735         * selftest-arch.c: Use C++ exception handling.
1736         * s390-tdep.c: Use C++ exception handling.
1737         * rust-lang.c: Use C++ exception handling.
1738         * rust-exp.y: Use C++ exception handling.
1739         * rs6000-tdep.c: Use C++ exception handling.
1740         * rs6000-aix-tdep.c: Use C++ exception handling.
1741         * riscv-tdep.c: Use C++ exception handling.
1742         * remote.c: Use C++ exception handling.
1743         * remote-fileio.c: Use C++ exception handling.
1744         * record-full.c: Use C++ exception handling.
1745         * record-btrace.c: Use C++ exception handling.
1746         * python/python.c: Use C++ exception handling.
1747         * python/py-value.c: Use C++ exception handling.
1748         * python/py-utils.c: Use C++ exception handling.
1749         * python/py-unwind.c: Use C++ exception handling.
1750         * python/py-type.c: Use C++ exception handling.
1751         * python/py-symbol.c: Use C++ exception handling.
1752         * python/py-record.c: Use C++ exception handling.
1753         * python/py-record-btrace.c: Use C++ exception handling.
1754         * python/py-progspace.c: Use C++ exception handling.
1755         * python/py-prettyprint.c: Use C++ exception handling.
1756         * python/py-param.c: Use C++ exception handling.
1757         * python/py-objfile.c: Use C++ exception handling.
1758         * python/py-linetable.c: Use C++ exception handling.
1759         * python/py-lazy-string.c: Use C++ exception handling.
1760         * python/py-infthread.c: Use C++ exception handling.
1761         * python/py-inferior.c: Use C++ exception handling.
1762         * python/py-gdb-readline.c: Use C++ exception handling.
1763         * python/py-framefilter.c: Use C++ exception handling.
1764         * python/py-frame.c: Use C++ exception handling.
1765         * python/py-finishbreakpoint.c: Use C++ exception handling.
1766         * python/py-cmd.c: Use C++ exception handling.
1767         * python/py-breakpoint.c: Use C++ exception handling.
1768         * python/py-arch.c: Use C++ exception handling.
1769         * printcmd.c: Use C++ exception handling.
1770         * ppc-linux-tdep.c: Use C++ exception handling.
1771         * parse.c: Use C++ exception handling.
1772         * p-valprint.c: Use C++ exception handling.
1773         * objc-lang.c: Use C++ exception handling.
1774         * mi/mi-main.c: Use C++ exception handling.
1775         * mi/mi-interp.c: Use C++ exception handling.
1776         * mi/mi-cmd-stack.c: Use C++ exception handling.
1777         * mi/mi-cmd-break.c: Use C++ exception handling.
1778         * main.c: Use C++ exception handling.
1779         * linux-thread-db.c: Use C++ exception handling.
1780         * linux-tdep.c: Use C++ exception handling.
1781         * linux-nat.c: Use C++ exception handling.
1782         * linux-fork.c: Use C++ exception handling.
1783         * linespec.c: Use C++ exception handling.
1784         * language.c: Use C++ exception handling.
1785         * jit.c: Use C++ exception handling.
1786         * infrun.c: Use C++ exception handling.
1787         * infcmd.c: Use C++ exception handling.
1788         * infcall.c: Use C++ exception handling.
1789         * inf-loop.c: Use C++ exception handling.
1790         * i386-tdep.c: Use C++ exception handling.
1791         * i386-linux-tdep.c: Use C++ exception handling.
1792         * guile/scm-value.c: Use C++ exception handling.
1793         * guile/scm-type.c: Use C++ exception handling.
1794         * guile/scm-symtab.c: Use C++ exception handling.
1795         * guile/scm-symbol.c: Use C++ exception handling.
1796         * guile/scm-pretty-print.c: Use C++ exception handling.
1797         * guile/scm-ports.c: Use C++ exception handling.
1798         * guile/scm-param.c: Use C++ exception handling.
1799         * guile/scm-math.c: Use C++ exception handling.
1800         * guile/scm-lazy-string.c: Use C++ exception handling.
1801         * guile/scm-frame.c: Use C++ exception handling.
1802         * guile/scm-disasm.c: Use C++ exception handling.
1803         * guile/scm-cmd.c: Use C++ exception handling.
1804         * guile/scm-breakpoint.c: Use C++ exception handling.
1805         * guile/scm-block.c: Use C++ exception handling.
1806         * guile/guile-internal.h: Use C++ exception handling.
1807         * gnu-v3-abi.c: Use C++ exception handling.
1808         * gdbtypes.c: Use C++ exception handling.
1809         * frame.c: Use C++ exception handling.
1810         * frame-unwind.c: Use C++ exception handling.
1811         * fbsd-tdep.c: Use C++ exception handling.
1812         * f-valprint.c: Use C++ exception handling.
1813         * exec.c: Use C++ exception handling.
1814         * event-top.c: Use C++ exception handling.
1815         * event-loop.c: Use C++ exception handling.
1816         * eval.c: Use C++ exception handling.
1817         * dwarf2read.c: Use C++ exception handling.
1818         * dwarf2loc.c: Use C++ exception handling.
1819         * dwarf2-frame.c: Use C++ exception handling.
1820         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1821         * dwarf-index-write.c: Use C++ exception handling.
1822         * dwarf-index-cache.c: Use C++ exception handling.
1823         * dtrace-probe.c: Use C++ exception handling.
1824         * disasm-selftests.c: Use C++ exception handling.
1825         * darwin-nat.c: Use C++ exception handling.
1826         * cp-valprint.c: Use C++ exception handling.
1827         * cp-support.c: Use C++ exception handling.
1828         * cp-abi.c: Use C++ exception handling.
1829         * corelow.c: Use C++ exception handling.
1830         * completer.c: Use C++ exception handling.
1831         * compile/compile-object-run.c: Use C++ exception handling.
1832         * compile/compile-object-load.c: Use C++ exception handling.
1833         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1834         * compile/compile-c-symbols.c: Use C++ exception handling.
1835         * common/selftest.c: Use C++ exception handling.
1836         * common/new-op.c: Use C++ exception handling.
1837         * cli/cli-script.c: Use C++ exception handling.
1838         * cli/cli-interp.c: Use C++ exception handling.
1839         * cli/cli-cmds.c: Use C++ exception handling.
1840         * c-varobj.c: Use C++ exception handling.
1841         * btrace.c: Use C++ exception handling.
1842         * breakpoint.c: Use C++ exception handling.
1843         * break-catch-throw.c: Use C++ exception handling.
1844         * arch-utils.c: Use C++ exception handling.
1845         * amd64-tdep.c: Use C++ exception handling.
1846         * ada-valprint.c: Use C++ exception handling.
1847         * ada-typeprint.c: Use C++ exception handling.
1848         * ada-lang.c: Use C++ exception handling.
1849         * aarch64-tdep.c: Use C++ exception handling.
1850
1851 2019-04-08  Tom Tromey  <tom@tromey.com>
1852
1853         * xml-support.c (gdb_xml_parser::parse): Update.
1854         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1855         * value.c (show_convenience): Update.
1856         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1857         (test_parse_flags_qcs): Update.
1858         * thread.c (thr_try_catch_cmd): Update.
1859         * target.c (target_translate_tls_address): Update.
1860         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1861         (info_frame_command_core, frame_apply_command_count): Update.
1862         * rust-exp.y (rust_lex_exception_test): Update.
1863         * riscv-tdep.c (riscv_print_one_register_info): Update.
1864         * remote.c (remote_target::enable_btrace): Update.
1865         * record-btrace.c (record_btrace_enable_warn): Update.
1866         * python/py-utils.c (gdbpy_convert_exception): Update.
1867         * printcmd.c (do_one_display, print_variable_and_value): Update.
1868         * mi/mi-main.c (mi_print_exception): Update.
1869         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1870         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1871         * linux-nat.c (linux_nat_target::attach): Update.
1872         * linux-fork.c (class scoped_switch_fork_info): Update.
1873         * infrun.c (displaced_step_prepare): Update.
1874         * infcall.c (call_function_by_hand_dummy): Update.
1875         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1876         * gnu-v3-abi.c (print_one_vtable): Update.
1877         * frame.c (get_prev_frame_always): Update.
1878         * f-valprint.c (info_common_command_for_block): Update.
1879         * exec.c (try_open_exec_file): Update.
1880         * exceptions.c (print_exception, exception_print)
1881         (exception_fprintf, exception_print_same): Update.
1882         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1883         * dwarf-index-cache.c (index_cache::store)
1884         (index_cache::lookup_gdb_index): Update.
1885         * darwin-nat.c (maybe_cache_shell): Update.
1886         * cp-valprint.c (cp_print_value_fields): Update.
1887         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1888         (gcc_cplus_symbol_address): Update.
1889         * compile/compile-c-symbols.c (gcc_convert_symbol)
1890         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1891         * common/selftest.c: Update.
1892         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1893         a std::string.
1894         (exception_try_scope_entry, exception_try_scope_exit): Don't
1895         declare.
1896         (struct exception_try_scope): Remove.
1897         (TRY): Don't use exception_try_scope.
1898         (struct gdb_exception): Add constructor, operator=.
1899         <what>: New method.
1900         (struct gdb_exception_RETURN_MASK_ALL)
1901         (struct gdb_exception_RETURN_MASK_ERROR)
1902         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1903         (struct gdb_quit_bad_alloc): Update.
1904         * common/common-exceptions.c (exception_none): Change
1905         initializer.
1906         (struct catcher) <state, exception>: Initialize inline.
1907         <prev>: Remove member.
1908         (current_catcher): Remove.
1909         (catchers): New global.
1910         (exceptions_state_mc_init): Simplify.
1911         (catcher_pop): Remove.
1912         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1913         (try_scope_depth, exception_try_scope_entry)
1914         (exception_try_scope_exit): Remove.
1915         (throw_exception_sjlj): Update.
1916         (exception_messages, exception_messages_size): Remove.
1917         (throw_it): Simplify.
1918         (gdb_exception_sliced_copy): Remove.
1919         (throw_exception_cxx): Update.
1920         * cli/cli-script.c (script_from_file): Update.
1921         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1922         Update.
1923         * ada-valprint.c (ada_val_print): Update.
1924         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1925         (create_excep_cond_exprs): Update.
1926
1927 2019-04-08  Tom Tromey  <tom@tromey.com>
1928
1929         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1930         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1931         (TRY, CATCH, END_CATCH): Remove some definitions.
1932         * common/common-exceptions.c: Don't use GDB_XCPT.
1933         (catcher_list_size): Remove.
1934         (throw_exception, throw_it): Simplify.
1935
1936 2019-04-05  Tom Tromey  <tom@tromey.com>
1937
1938         Revert the header-sorting patch.
1939         * ft32-tdep.c: Revert.
1940         * frv-tdep.c: Revert.
1941         * frv-linux-tdep.c: Revert.
1942         * frame.c: Revert.
1943         * frame-unwind.c: Revert.
1944         * frame-base.c: Revert.
1945         * fork-child.c: Revert.
1946         * findvar.c: Revert.
1947         * findcmd.c: Revert.
1948         * filesystem.c: Revert.
1949         * filename-seen-cache.h: Revert.
1950         * filename-seen-cache.c: Revert.
1951         * fbsd-tdep.c: Revert.
1952         * fbsd-nat.h: Revert.
1953         * fbsd-nat.c: Revert.
1954         * f-valprint.c: Revert.
1955         * f-typeprint.c: Revert.
1956         * f-lang.c: Revert.
1957         * extension.h: Revert.
1958         * extension.c: Revert.
1959         * extension-priv.h: Revert.
1960         * expprint.c: Revert.
1961         * exec.h: Revert.
1962         * exec.c: Revert.
1963         * exceptions.c: Revert.
1964         * event-top.c: Revert.
1965         * event-loop.c: Revert.
1966         * eval.c: Revert.
1967         * elfread.c: Revert.
1968         * dwarf2read.h: Revert.
1969         * dwarf2read.c: Revert.
1970         * dwarf2loc.c: Revert.
1971         * dwarf2expr.h: Revert.
1972         * dwarf2expr.c: Revert.
1973         * dwarf2-frame.c: Revert.
1974         * dwarf2-frame-tailcall.c: Revert.
1975         * dwarf-index-write.h: Revert.
1976         * dwarf-index-write.c: Revert.
1977         * dwarf-index-common.c: Revert.
1978         * dwarf-index-cache.h: Revert.
1979         * dwarf-index-cache.c: Revert.
1980         * dummy-frame.c: Revert.
1981         * dtrace-probe.c: Revert.
1982         * disasm.h: Revert.
1983         * disasm.c: Revert.
1984         * disasm-selftests.c: Revert.
1985         * dictionary.c: Revert.
1986         * dicos-tdep.c: Revert.
1987         * demangle.c: Revert.
1988         * dcache.h: Revert.
1989         * dcache.c: Revert.
1990         * darwin-nat.h: Revert.
1991         * darwin-nat.c: Revert.
1992         * darwin-nat-info.c: Revert.
1993         * d-valprint.c: Revert.
1994         * d-namespace.c: Revert.
1995         * d-lang.c: Revert.
1996         * ctf.c: Revert.
1997         * csky-tdep.c: Revert.
1998         * csky-linux-tdep.c: Revert.
1999         * cris-tdep.c: Revert.
2000         * cris-linux-tdep.c: Revert.
2001         * cp-valprint.c: Revert.
2002         * cp-support.c: Revert.
2003         * cp-namespace.c: Revert.
2004         * cp-abi.c: Revert.
2005         * corelow.c: Revert.
2006         * corefile.c: Revert.
2007         * continuations.c: Revert.
2008         * completer.h: Revert.
2009         * completer.c: Revert.
2010         * complaints.c: Revert.
2011         * coffread.c: Revert.
2012         * coff-pe-read.c: Revert.
2013         * cli-out.h: Revert.
2014         * cli-out.c: Revert.
2015         * charset.c: Revert.
2016         * c-varobj.c: Revert.
2017         * c-valprint.c: Revert.
2018         * c-typeprint.c: Revert.
2019         * c-lang.c: Revert.
2020         * buildsym.c: Revert.
2021         * buildsym-legacy.c: Revert.
2022         * build-id.h: Revert.
2023         * build-id.c: Revert.
2024         * btrace.c: Revert.
2025         * bsd-uthread.c: Revert.
2026         * breakpoint.h: Revert.
2027         * breakpoint.c: Revert.
2028         * break-catch-throw.c: Revert.
2029         * break-catch-syscall.c: Revert.
2030         * break-catch-sig.c: Revert.
2031         * blockframe.c: Revert.
2032         * block.c: Revert.
2033         * bfin-tdep.c: Revert.
2034         * bfin-linux-tdep.c: Revert.
2035         * bfd-target.c: Revert.
2036         * bcache.c: Revert.
2037         * ax-general.c: Revert.
2038         * ax-gdb.h: Revert.
2039         * ax-gdb.c: Revert.
2040         * avr-tdep.c: Revert.
2041         * auxv.c: Revert.
2042         * auto-load.c: Revert.
2043         * arm-wince-tdep.c: Revert.
2044         * arm-tdep.c: Revert.
2045         * arm-symbian-tdep.c: Revert.
2046         * arm-pikeos-tdep.c: Revert.
2047         * arm-obsd-tdep.c: Revert.
2048         * arm-nbsd-tdep.c: Revert.
2049         * arm-nbsd-nat.c: Revert.
2050         * arm-linux-tdep.c: Revert.
2051         * arm-linux-nat.c: Revert.
2052         * arm-fbsd-tdep.c: Revert.
2053         * arm-fbsd-nat.c: Revert.
2054         * arm-bsd-tdep.c: Revert.
2055         * arch-utils.c: Revert.
2056         * arc-tdep.c: Revert.
2057         * arc-newlib-tdep.c: Revert.
2058         * annotate.h: Revert.
2059         * annotate.c: Revert.
2060         * amd64-windows-tdep.c: Revert.
2061         * amd64-windows-nat.c: Revert.
2062         * amd64-tdep.c: Revert.
2063         * amd64-sol2-tdep.c: Revert.
2064         * amd64-obsd-tdep.c: Revert.
2065         * amd64-obsd-nat.c: Revert.
2066         * amd64-nbsd-tdep.c: Revert.
2067         * amd64-nbsd-nat.c: Revert.
2068         * amd64-nat.c: Revert.
2069         * amd64-linux-tdep.c: Revert.
2070         * amd64-linux-nat.c: Revert.
2071         * amd64-fbsd-tdep.c: Revert.
2072         * amd64-fbsd-nat.c: Revert.
2073         * amd64-dicos-tdep.c: Revert.
2074         * amd64-darwin-tdep.c: Revert.
2075         * amd64-bsd-nat.c: Revert.
2076         * alpha-tdep.c: Revert.
2077         * alpha-obsd-tdep.c: Revert.
2078         * alpha-nbsd-tdep.c: Revert.
2079         * alpha-mdebug-tdep.c: Revert.
2080         * alpha-linux-tdep.c: Revert.
2081         * alpha-linux-nat.c: Revert.
2082         * alpha-bsd-tdep.c: Revert.
2083         * alpha-bsd-nat.c: Revert.
2084         * aix-thread.c: Revert.
2085         * agent.c: Revert.
2086         * addrmap.c: Revert.
2087         * ada-varobj.c: Revert.
2088         * ada-valprint.c: Revert.
2089         * ada-typeprint.c: Revert.
2090         * ada-tasks.c: Revert.
2091         * ada-lang.c: Revert.
2092         * aarch64-tdep.c: Revert.
2093         * aarch64-ravenscar-thread.c: Revert.
2094         * aarch64-newlib-tdep.c: Revert.
2095         * aarch64-linux-tdep.c: Revert.
2096         * aarch64-linux-nat.c: Revert.
2097         * aarch64-fbsd-tdep.c: Revert.
2098         * aarch64-fbsd-nat.c: Revert.
2099         * aarch32-linux-nat.c: Revert.
2100
2101 2019-04-05  Tom Tromey  <tom@tromey.com>
2102
2103         * ft32-tdep.c: Sort headers.
2104         * frv-tdep.c: Sort headers.
2105         * frv-linux-tdep.c: Sort headers.
2106         * frame.c: Sort headers.
2107         * frame-unwind.c: Sort headers.
2108         * frame-base.c: Sort headers.
2109         * fork-child.c: Sort headers.
2110         * findvar.c: Sort headers.
2111         * findcmd.c: Sort headers.
2112         * filesystem.c: Sort headers.
2113         * filename-seen-cache.h: Sort headers.
2114         * filename-seen-cache.c: Sort headers.
2115         * fbsd-tdep.c: Sort headers.
2116         * fbsd-nat.h: Sort headers.
2117         * fbsd-nat.c: Sort headers.
2118         * f-valprint.c: Sort headers.
2119         * f-typeprint.c: Sort headers.
2120         * f-lang.c: Sort headers.
2121         * extension.h: Sort headers.
2122         * extension.c: Sort headers.
2123         * extension-priv.h: Sort headers.
2124         * expprint.c: Sort headers.
2125         * exec.h: Sort headers.
2126         * exec.c: Sort headers.
2127         * exceptions.c: Sort headers.
2128         * event-top.c: Sort headers.
2129         * event-loop.c: Sort headers.
2130         * eval.c: Sort headers.
2131         * elfread.c: Sort headers.
2132         * dwarf2read.h: Sort headers.
2133         * dwarf2read.c: Sort headers.
2134         * dwarf2loc.c: Sort headers.
2135         * dwarf2expr.h: Sort headers.
2136         * dwarf2expr.c: Sort headers.
2137         * dwarf2-frame.c: Sort headers.
2138         * dwarf2-frame-tailcall.c: Sort headers.
2139         * dwarf-index-write.h: Sort headers.
2140         * dwarf-index-write.c: Sort headers.
2141         * dwarf-index-common.c: Sort headers.
2142         * dwarf-index-cache.h: Sort headers.
2143         * dwarf-index-cache.c: Sort headers.
2144         * dummy-frame.c: Sort headers.
2145         * dtrace-probe.c: Sort headers.
2146         * disasm.h: Sort headers.
2147         * disasm.c: Sort headers.
2148         * disasm-selftests.c: Sort headers.
2149         * dictionary.c: Sort headers.
2150         * dicos-tdep.c: Sort headers.
2151         * demangle.c: Sort headers.
2152         * dcache.h: Sort headers.
2153         * dcache.c: Sort headers.
2154         * darwin-nat.h: Sort headers.
2155         * darwin-nat.c: Sort headers.
2156         * darwin-nat-info.c: Sort headers.
2157         * d-valprint.c: Sort headers.
2158         * d-namespace.c: Sort headers.
2159         * d-lang.c: Sort headers.
2160         * ctf.c: Sort headers.
2161         * csky-tdep.c: Sort headers.
2162         * csky-linux-tdep.c: Sort headers.
2163         * cris-tdep.c: Sort headers.
2164         * cris-linux-tdep.c: Sort headers.
2165         * cp-valprint.c: Sort headers.
2166         * cp-support.c: Sort headers.
2167         * cp-namespace.c: Sort headers.
2168         * cp-abi.c: Sort headers.
2169         * corelow.c: Sort headers.
2170         * corefile.c: Sort headers.
2171         * continuations.c: Sort headers.
2172         * completer.h: Sort headers.
2173         * completer.c: Sort headers.
2174         * complaints.c: Sort headers.
2175         * coffread.c: Sort headers.
2176         * coff-pe-read.c: Sort headers.
2177         * cli-out.h: Sort headers.
2178         * cli-out.c: Sort headers.
2179         * charset.c: Sort headers.
2180         * c-varobj.c: Sort headers.
2181         * c-valprint.c: Sort headers.
2182         * c-typeprint.c: Sort headers.
2183         * c-lang.c: Sort headers.
2184         * buildsym.c: Sort headers.
2185         * buildsym-legacy.c: Sort headers.
2186         * build-id.h: Sort headers.
2187         * build-id.c: Sort headers.
2188         * btrace.c: Sort headers.
2189         * bsd-uthread.c: Sort headers.
2190         * breakpoint.h: Sort headers.
2191         * breakpoint.c: Sort headers.
2192         * break-catch-throw.c: Sort headers.
2193         * break-catch-syscall.c: Sort headers.
2194         * break-catch-sig.c: Sort headers.
2195         * blockframe.c: Sort headers.
2196         * block.c: Sort headers.
2197         * bfin-tdep.c: Sort headers.
2198         * bfin-linux-tdep.c: Sort headers.
2199         * bfd-target.c: Sort headers.
2200         * bcache.c: Sort headers.
2201         * ax-general.c: Sort headers.
2202         * ax-gdb.h: Sort headers.
2203         * ax-gdb.c: Sort headers.
2204         * avr-tdep.c: Sort headers.
2205         * auxv.c: Sort headers.
2206         * auto-load.c: Sort headers.
2207         * arm-wince-tdep.c: Sort headers.
2208         * arm-tdep.c: Sort headers.
2209         * arm-symbian-tdep.c: Sort headers.
2210         * arm-pikeos-tdep.c: Sort headers.
2211         * arm-obsd-tdep.c: Sort headers.
2212         * arm-nbsd-tdep.c: Sort headers.
2213         * arm-nbsd-nat.c: Sort headers.
2214         * arm-linux-tdep.c: Sort headers.
2215         * arm-linux-nat.c: Sort headers.
2216         * arm-fbsd-tdep.c: Sort headers.
2217         * arm-fbsd-nat.c: Sort headers.
2218         * arm-bsd-tdep.c: Sort headers.
2219         * arch-utils.c: Sort headers.
2220         * arc-tdep.c: Sort headers.
2221         * arc-newlib-tdep.c: Sort headers.
2222         * annotate.h: Sort headers.
2223         * annotate.c: Sort headers.
2224         * amd64-windows-tdep.c: Sort headers.
2225         * amd64-windows-nat.c: Sort headers.
2226         * amd64-tdep.c: Sort headers.
2227         * amd64-sol2-tdep.c: Sort headers.
2228         * amd64-obsd-tdep.c: Sort headers.
2229         * amd64-obsd-nat.c: Sort headers.
2230         * amd64-nbsd-tdep.c: Sort headers.
2231         * amd64-nbsd-nat.c: Sort headers.
2232         * amd64-nat.c: Sort headers.
2233         * amd64-linux-tdep.c: Sort headers.
2234         * amd64-linux-nat.c: Sort headers.
2235         * amd64-fbsd-tdep.c: Sort headers.
2236         * amd64-fbsd-nat.c: Sort headers.
2237         * amd64-dicos-tdep.c: Sort headers.
2238         * amd64-darwin-tdep.c: Sort headers.
2239         * amd64-bsd-nat.c: Sort headers.
2240         * alpha-tdep.c: Sort headers.
2241         * alpha-obsd-tdep.c: Sort headers.
2242         * alpha-nbsd-tdep.c: Sort headers.
2243         * alpha-mdebug-tdep.c: Sort headers.
2244         * alpha-linux-tdep.c: Sort headers.
2245         * alpha-linux-nat.c: Sort headers.
2246         * alpha-bsd-tdep.c: Sort headers.
2247         * alpha-bsd-nat.c: Sort headers.
2248         * aix-thread.c: Sort headers.
2249         * agent.c: Sort headers.
2250         * addrmap.c: Sort headers.
2251         * ada-varobj.c: Sort headers.
2252         * ada-valprint.c: Sort headers.
2253         * ada-typeprint.c: Sort headers.
2254         * ada-tasks.c: Sort headers.
2255         * ada-lang.c: Sort headers.
2256         * aarch64-tdep.c: Sort headers.
2257         * aarch64-ravenscar-thread.c: Sort headers.
2258         * aarch64-newlib-tdep.c: Sort headers.
2259         * aarch64-linux-tdep.c: Sort headers.
2260         * aarch64-linux-nat.c: Sort headers.
2261         * aarch64-fbsd-tdep.c: Sort headers.
2262         * aarch64-fbsd-nat.c: Sort headers.
2263         * aarch32-linux-nat.c: Sort headers.
2264
2265 2019-04-04  Tom Tromey  <tom@tromey.com>
2266
2267         * varobj.c (varobj_create): Update.
2268         * rust-exp.y (struct rust_parser) <update_innermost_block,
2269         lookup_symbol>: New methods.
2270         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2271         Rename.
2272         (rust_parser::rust_lookup_type)
2273         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2274         * printcmd.c (display_command, do_one_display): Update.
2275         * parser-defs.h (struct parser_state) <parser_state>: Add
2276         "tracker" parameter.
2277         (block_tracker): New member.
2278         (class innermost_block_tracker) <innermost_block_tracker>: Add
2279         "types" parameter.
2280         <reset>: Remove method.
2281         (innermost_block): Don't declare.
2282         (null_post_parser): Update.
2283         * parse.c (innermost_block): Remove global.
2284         (write_dollar_variable): Update.
2285         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2286         Remove "tracker_types" parameter.
2287         (parse_expression): Add "tracker" parameter.
2288         (parse_expression_for_completion): Update.
2289         (null_post_parser): Add "tracker" parameter.
2290         * p-exp.y: Update rules.
2291         * m2-exp.y: Update rules.
2292         * language.h (struct language_defn) <la_post_parser>: Add
2293         "tracker" parameter.
2294         * go-exp.y: Update rules.
2295         * f-exp.y: Update rules.
2296         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2297         parameter.
2298         * d-exp.y: Update rules.
2299         * c-exp.y: Update rules.
2300         * breakpoint.c (set_breakpoint_condition): Create an
2301         innermost_block_tracker.
2302         (watch_command_1): Likewise.
2303         * ada-lang.c (resolve): Add "tracker" parameter.
2304         (resolve_subexp): Likewise.
2305         * ada-exp.y (write_var_from_sym): Update.
2306
2307 2019-04-04  Tom Tromey  <tom@tromey.com>
2308
2309         * type-stack.h: New file.
2310         * type-stack.c: New file.
2311         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2312         type-stack.h.
2313         (insert_into_type_stack, insert_type, push_type, push_type_int)
2314         (insert_type_address_space, pop_type, pop_type_int)
2315         (pop_typelist, pop_type_stack, append_type_stack)
2316         (push_type_stack, get_type_stack, push_typelist)
2317         (follow_type_instance_flags, follow_types): Don't declare.
2318         * parse.c (type_stack): Remove global.
2319         (parse_exp_in_context): Update.
2320         (insert_into_type_stack, insert_type, push_type, push_type_int)
2321         (insert_type_address_space, pop_type, pop_type_int)
2322         (pop_typelist, pop_type_stack, append_type_stack)
2323         (push_type_stack, get_type_stack, push_typelist)
2324         (follow_type_instance_flags, follow_types): Remove (moved to
2325         type-stack.c).
2326         * f-exp.y (type_stack): New global.
2327         Update rules.
2328         (push_kind_type, f_parse): Update.
2329         * d-exp.y (type_stack): New global.
2330         Update rules.
2331         (d_parse): Update.
2332         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2333         Update rules.
2334         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2335         (HFILES_NO_SRCDIR): Add type-stack.h.
2336
2337 2019-04-04  Tom Tromey  <tom@tromey.com>
2338
2339         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2340         (rust_parser::convert_ast_to_expression, rust_parse)
2341         (rust_lex_test_completion, rust_lex_tests): Update.
2342         * parser-defs.h (struct expr_completion_state): New.
2343         (struct parser_state) <parser_state>: Add completion parameter.
2344         <mark_struct_expression, mark_completion_tag>: New methods.
2345         <parse_completion, m_completion_state>: New members.
2346         (prefixify_expression, null_post_parser): Update.
2347         (mark_struct_expression, mark_completion_tag): Don't declare.
2348         * parse.c (parse_completion, expout_last_struct)
2349         (expout_tag_completion_type, expout_completion_name): Remove
2350         globals.
2351         (parser_state::mark_struct_expression)
2352         (parser_state::mark_completion_tag): Now methods.
2353         (prefixify_expression): Add last_struct parameter.
2354         (prefixify_subexp): Likewise.
2355         (parse_exp_1): Update.
2356         (parse_exp_in_context): Add cstate parameter.  Update.
2357         (parse_expression_for_completion): Create an
2358         expr_completion_state.
2359         (null_post_parser): Add "completion" parameter.
2360         * p-exp.y: Update rules.
2361         (yylex): Update.
2362         * language.h (struct language_defn) <la_post_parser>: Add
2363         "completing" parameter.
2364         * go-exp.y: Update rules.
2365         (lex_one_token): Update.
2366         * expression.h (parse_completion): Don't declare.
2367         * d-exp.y: Update rules.
2368         (lex_one_token): Update rules.
2369         * c-exp.y: Update rules.
2370         (lex_one_token): Update.
2371         * ada-lang.c (resolve): Add "parse_completion" parameter.
2372         (resolve_subexp): Likewise.
2373         (ada_resolve_function): Likewise.
2374
2375 2019-04-04  Tom Tromey  <tom@tromey.com>
2376
2377         * parser-defs.h (struct parser_state) <start_arglist,
2378         end_arglist>: New methods.
2379         <arglist_len, m_funcall_chain>: New members.
2380         (arglist_len, start_arglist, end_arglist): Don't declare.
2381         * parse.c (arglist_len, funcall_chain): Remove global.
2382         (start_arglist, end_arglist): Remove functions.
2383         (parse_exp_in_context): Update.
2384         * p-exp.y: Update rules.
2385         * m2-exp.y: Update rules.
2386         * go-exp.y: Update rules.
2387         * f-exp.y: Update rules.
2388         * d-exp.y: Update rules.
2389         * c-exp.y: Update rules.
2390
2391 2019-04-04  Tom Tromey  <tom@tromey.com>
2392
2393         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2394         lex_operator, push_back>: New methods.
2395         Update all rules.
2396         (rust_parser::lex_hex, lex_escape): Rename and update.
2397         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2398         (rust_parser::lex_operator): Rename and update.
2399         (rust_parser::lex_number, rustyylex, rustyyerror)
2400         (rust_lex_test_init, rust_lex_test_sequence)
2401         (rust_lex_test_push_back, rust_lex_tests): Update.
2402         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2403         parameter.
2404         <lexptr, prev_lexptr>: New members.
2405         (lexptr, prev_lexptr): Don't declare.
2406         * parse.c (lexptr, prev_lexptr): Remove globals.
2407         (parse_exp_in_context): Update.
2408         * p-exp.y (yylex, yyerror): Update.
2409         * m2-exp.y (parse_number, yylex, yyerror): Update.
2410         * go-exp.y (lex_one_token, yyerror): Update.
2411         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2412         * d-exp.y (lex_one_token, yyerror): Update.
2413         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2414         (lex_one_token, yyerror): Update.
2415         * ada-lex.l (YY_INPUT): Update.
2416         (rewind_to_char): Update.
2417         * ada-exp.y (yyerror): Update.
2418
2419 2019-04-04  Tom Tromey  <tom@tromey.com>
2420
2421         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2422         * parser-defs.h (struct parser_state) <parser_state>: Add new
2423         parameter.
2424         <comma_terminates>: New member.
2425         (comma_terminates): Don't declare global.
2426         * parse.c (comma_terminates): Remove global.
2427         (parse_exp_in_context): Update.
2428         * p-exp.y (yylex): Update.
2429         * m2-exp.y (yylex): Update.
2430         * go-exp.y (lex_one_token): Update.
2431         * f-exp.y (yylex): Update.
2432         * d-exp.y (lex_one_token): Update.
2433         * c-exp.y (lex_one_token): Update.
2434         * ada-lex.l: Update.
2435
2436 2019-04-04  Tom Tromey  <tom@tromey.com>
2437
2438         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2439         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2440         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2441         * parser-defs.h (paren_depth): Don't declare.
2442         * parse.c (paren_depth): Remove global.
2443         (parse_exp_in_context): Update.
2444         * p-exp.y (paren_depth): New global.
2445         (pascal_parse): Initialize it.
2446         * m2-exp.y (paren_depth): New global.
2447         (m2_parse): Initialize it.
2448         * go-exp.y (paren_depth): New global.
2449         (go_parse): Initialize it.
2450         * f-exp.y (paren_depth): New global.
2451         (f_parse): Initialize it.
2452         * d-exp.y (paren_depth): New global.
2453         (d_parse): Initialize it.
2454         * c-exp.y (paren_depth): New global.
2455         (c_parse): Initialize it.
2456         * ada-lex.l (paren_depth): New global.
2457         (lexer_init): Initialize it.
2458
2459 2019-04-04  Tom Tromey  <tom@tromey.com>
2460
2461         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2462         (rust_parser::convert_ast_to_type)
2463         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2464         * parser-defs.h (struct parser_state) <parser_state>: Add
2465         parameters.  Initialize new members.
2466         <expression_context_block, expression_context_pc>: New members.
2467         * parse.c (expression_context_block, expression_context_pc):
2468         Remove globals.
2469         (parse_exp_in_context): Update.
2470         * p-exp.y: Update all rules.
2471         (yylex): Update.
2472         * m2-exp.y: Update all rules.
2473         (yylex): Update.
2474         * go-exp.y (yylex): Update.
2475         * f-exp.y (yylex): Update.
2476         * d-exp.y: Update all rules.
2477         (yylex): Update.
2478         * c-exp.y: Update all rules.
2479         (lex_one_token, classify_name, yylex, c_parse): Update.
2480         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2481
2482 2019-04-04  Tom Tromey  <tom@tromey.com>
2483
2484         * gdbarch.h, gdbarch.c: Rebuild.
2485         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2486         * stap-probe.h:
2487         (struct stap_parse_info): Replace "parser_state" with
2488         "expr_builder".
2489         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2490         (parser_state): New class.
2491         * parse.c (expr_builder): Rename.
2492         (expr_builder::release): Rename.
2493         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2494         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2495         (write_exp_elt_longcst, write_exp_elt_floatcst)
2496         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2497         (write_exp_string_vector, write_exp_bitstring)
2498         (write_exp_msymbol, mark_struct_expression)
2499         (write_dollar_variable)
2500         (insert_type_address_space, increase_expout_size): Replace
2501         "parser_state" with "expr_builder".
2502         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2503         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2504         "parser_state" with "expr_builder".
2505
2506 2019-04-04  Tom Tromey  <tom@tromey.com>
2507
2508         * rust-exp.y: Replace "parse_language" with method call.
2509         * p-exp.y:
2510         (yylex): Replace "parse_language" with method call.
2511         * m2-exp.y:
2512         (yylex): Replace "parse_language" with method call.
2513         * go-exp.y (classify_name): Replace "parse_language" with method
2514         call.
2515         * f-exp.y (yylex): Replace "parse_language" with method call.
2516         * d-exp.y (lex_one_token): Replace "parse_language" with method
2517         call.
2518         * c-exp.y:
2519         (lex_one_token, classify_name, yylex): Replace "parse_language"
2520         with method call.
2521         * ada-exp.y (find_primitive_type, type_char)
2522         (type_system_address): Replace "parse_language" with method call.
2523
2524 2019-04-04  Tom Tromey  <tom@tromey.com>
2525
2526         * rust-exp.y: Replace "parse_gdbarch" with method call.
2527         * parse.c (write_dollar_variable, insert_type_address_space):
2528         Replace "parse_gdbarch" with method call.
2529         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2530         call.
2531         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2532         call.
2533         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2534         "parse_gdbarch" with method call.
2535         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2536         with method call.
2537         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2538         "parse_gdbarch" with method call.
2539         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2540         "parse_gdbarch" with method call.
2541         * c-exp.y (parse_type, parse_number, classify_name): Replace
2542         "parse_gdbarch" with method call.
2543         * ada-lex.l: Replace "parse_gdbarch" with method call.
2544         * ada-exp.y (parse_type, find_primitive_type, type_char)
2545         (type_system_address): Replace "parse_gdbarch" with method call.
2546
2547 2019-04-04  Tom Tromey  <tom@tromey.com>
2548
2549         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2550         * stap-probe.c (stap_parse_argument): Update.
2551         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2552         initial_size parameter.
2553         * rust-exp.y (rust_lex_tests): Update.
2554         * parse.c (parser_state): Update.
2555         (parse_exp_in_context): Update.
2556         * parser-defs.h (struct parser_state) <parser_state>: Remove
2557         "initial_size" parameter.
2558
2559 2019-04-04  Tom Tromey  <tom@tromey.com>
2560
2561         * parser-defs.h (increase_expout_size): Don't declare.
2562         * parse.c (increase_expout_size): Now static.
2563
2564 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2565
2566         * gnu-nat.c (gnu_nat_target::wait): Fix
2567         target_waitstatus_to_string call.
2568
2569 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2570
2571         * eval.c (evaluate_subexp_standard): Handle internal functions
2572         during Fortran function call handling.
2573
2574 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2575
2576         * NEWS: Mention new internal functions.
2577         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2578         (read_base_type): Use dwarf2_init_complex_target_type.
2579         * value.c (creal_internal_fn): New function.
2580         (cimag_internal_fn): New function.
2581         (_initialize_values): Register new internal functions.
2582
2583 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2584
2585         * infrun.c (stop_all_threads): If debug_infrun, always
2586         trace the wait status after wait_one, using
2587         target_waitstatus_to_string and target_pid_to_str.
2588         (handle_inferior_event): Replace various trace of
2589         wait status kind by a single trace.
2590         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2591         wait status kind image by target_waitstatus_to_string.
2592         * target/waitstatus.c (target_waitstatus_to_string): Fix
2593         obsolete comment.
2594
2595 2019-04-01  Tom Tromey  <tromey@adacore.com>
2596
2597         PR symtab/23331:
2598         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2599
2600 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2601             Pedro Alves  <palves@redhat.com>
2602
2603         * top.c (quit_force): Call 'finalize_values'.
2604         * value.c (finalize_values): New function.
2605         * value.h (finalize_values): Declare.
2606
2607 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2608
2609         * NEWS: Announce $_gdb_major and $_gdb_minor.
2610
2611         * top.c (init_gdb_version_vars): New function.
2612         (gdb_init): Call init_gdb_version_vars.
2613
2614 2019-03-29  Tom Tromey  <tromey@adacore.com>
2615
2616         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2617         help text.  Remove dead code.
2618
2619 2019-03-29  Keith Seitz  <keiths@redhat.com>
2620
2621         From Siddhesh Poyarekar:
2622         * f-lang.h (f77_get_upperbound): Return LONGEST.
2623         (f77_get_lowerbound): Likewise.
2624         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2625         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2626         print them.
2627         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2628         plongest to format print it.
2629         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2630         (f77_get_upperbound): Likewise.
2631         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2632         LOWER_BOUND to LONGEST.
2633         (f77_create_arrayprint_offset_tbl): Likewise.
2634
2635 2019-03-29  Keith Seitz  <keiths@redhat.com>
2636
2637         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2638         %s/pulongest for TYPE_LENGTH instead of %d in format
2639         strings.
2640         * ada-typerint.c (ada_print_type): Likewise.
2641         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2642         * compile/compile-c-support.c (generate_register_struct): Likewise.
2643         * gdbtypes.c (recursive_dump_type): Likewise.
2644         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2645         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2646         instead of %d in format strings.
2647         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2648         to std::min to ULONGEST.
2649         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2650         instead of %d in format strings.
2651         * tracepoint.c (info_scope_command): Likewise.
2652         * typeprint.c (print_offset_data::update)
2653         (print_offset_data::finish): Likewise.
2654         * xtensa-tdep.c (xtensa_store_return_value)
2655         (xtensa_push_dummy_call): Likewise.
2656
2657 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2658
2659         * windows-nat.c (display_selector): Fixed format specifications
2660         for 64-bit Cygwin.
2661
2662 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2663
2664         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2665
2666 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2667
2668         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2669         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2670         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2671         (nios2_linux_init_abi): Install it.
2672
2673 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2674
2675         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2676
2677 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2678
2679         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2680
2681 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2682             Tom Tromey  <tromey@adacore.com>
2683
2684         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2685
2686 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2687
2688         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2689         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2690         method to compute the bounds of range types. Also print "[evaluated]"
2691         if the bounds' values come from a dynamic evaluation.
2692
2693 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2694
2695         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2696         whitespace when pretty printing is on.
2697
2698 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2699
2700         * ppc-linux-nat.c: Add include.
2701
2702 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2703
2704         * NEWS: Mention AArch64 Pointer Authentication.
2705
2706 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2707
2708         * arm-linux-nat.c: Add include.
2709
2710 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2711
2712         * source-cache.c (source_cache::get_source_lines): Re-read
2713         fullname after calling open_source_file.
2714
2715 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2716
2717         * NEWS: Mention TLS support for FreeBSD.
2718
2719 2019-03-25  Tom Tromey  <tromey@adacore.com>
2720
2721         * minsyms.c (BUNCH_SIZE): Update comment.
2722         (~minimal_symbol_reader): Remove old comment.
2723         (compact_minimal_symbols): Update comment.
2724         (minimal_symbol_reader::install): Remove old comment.  Update
2725         other comments.
2726
2727 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2728
2729         * s390-linux-nat.c: Add include.
2730
2731 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2732
2733         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2734         Call linux_get_hwcap.
2735         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2736         Likewise.
2737         (aarch64_linux_get_hwcap): Remove function.
2738         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2739         declaration.
2740         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2741         linux_get_hwcap.
2742         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2743         * linux-tdep.c (linux_get_hwcap): Add function.
2744         (linux_get_hwcap2): Likewise.
2745         * linux-tdep.h (linux_get_hwcap): Add declaration.
2746         (linux_get_hwcap2): Likewise.
2747         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2748         (ppc_linux_get_hwcap2): Likewise.
2749         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2750         linux_get_hwcap.
2751         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2752         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2753         (ppc_linux_nat_target::read_description): Likewise.
2754         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2755         * s390-linux-nat.c: Likewise.
2756         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2757
2758 2019-03-24  Tom Tromey  <tom@tromey.com>
2759
2760         * ada-lang.c (standard_lookup): Simplify initialization.
2761         (ada_lookup_symbol_nonlocal): Simplify return.
2762         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2763         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2764         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2765         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2766         initialization.
2767         * solib.c (solib_global_lookup): Simplify.
2768         * symtab.c (null_block_symbol): Remove.
2769         (symbol_cache_lookup): Simplify returns.
2770         (lookup_language_this): Simplify returns.
2771         (lookup_symbol_aux): Simplify return.
2772         (lookup_local_symbol): Simplify returns.
2773         (lookup_global_symbol_from_objfile): Simplify return.
2774         (lookup_symbol_in_objfile_symtabs)
2775         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2776         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2777         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2778         * cp-namespace.c (cp_lookup_bare_symbol)
2779         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2780         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2781         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2782         (cp_lookup_symbol_via_imports): Simplify initialization.
2783         (find_symbol_in_baseclass): Likewise.
2784         * symtab.h (null_block_symbol): Remove.
2785         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2786         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2787         (d_lookup_symbol_module): Likewise.
2788         (find_symbol_in_baseclass): Simplify initialization.
2789
2790 2019-03-24  Tom Tromey  <tom@tromey.com>
2791
2792         * expression.h: Don't include symtab.h.
2793         (struct block): Forward declare.
2794
2795 2019-03-24  Tom Tromey  <tom@tromey.com>
2796
2797         * c-exp.y (typebase): Remove casts.
2798         * gdbtypes.c (lookup_unsigned_typename, )
2799         (lookup_signed_typename): Remove cast.
2800         * eval.c (parse_to_comma_and_eval): Remove cast.
2801         * parse.c (write_dollar_variable): Remove cast.
2802         * block.h (struct block) <superblock>: Now const.
2803         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2804         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2805         (map_block): Make "block" const.
2806         * symfile.h (struct quick_symbol_functions)
2807         <map_matching_symbols>: Constify block argument to "callback".
2808         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2809         const.
2810         (find_pc_sect_compunit_symtab): Make "b" const.
2811         (find_symbol_at_address): Likewise.
2812         (search_symbols): Likewise.
2813         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2814         (dw2_debug_names_lookup_symbol): Likewise.
2815         (dw2_map_matching_symbols): Update.
2816         * p-valprint.c (pascal_val_print): Remove "block".
2817         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2818         (aux_add_nonlocal_symbols): Make "block" const.
2819         (resolve_subexp): Remove cast.
2820         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2821         const.
2822         (iterate_over_file_blocks): Likewise.
2823         * f-exp.y (%union) <bval>: Remove.
2824         * coffread.c (patch_opaque_types): Make "b" const.
2825         * spu-tdep.c (spu_catch_start): Make "block" const.
2826         * c-valprint.c (print_unpacked_pointer): Remove "block".
2827         * symmisc.c (dump_symtab_1): Make "b" const.
2828         (block_depth): Make "block" const.
2829         * d-exp.y (%union) <bval>: Remove.
2830         * cp-support.h (cp_lookup_rtti_type): Update.
2831         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2832         * psymtab.c (psym_lookup_symbol): Make "block" const.
2833         (maintenance_check_psymtabs): Make "b" const.
2834         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2835         (enumerate_locals, enumerate_args): Update.
2836         * python/py-symtab.c (stpy_global_block): Make "block" const.
2837         (stpy_static_block): Likewise.
2838         * inline-frame.c (block_starting_point_at): Make "new_block"
2839         const.
2840         * block.c (find_block_in_blockvector): Make return type const.
2841         (blockvector_for_pc_sect): Make "b" const.
2842         (find_block_in_blockvector): Make "b" const.
2843
2844 2019-03-23  Tom Tromey  <tom@tromey.com>
2845
2846         * varobj.c (varobj_create): Update.
2847         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2848         * printcmd.c (display_command, do_one_display): Don't reset
2849         innermost_block.
2850         * parser-defs.h (enum innermost_block_tracker_type): Move to
2851         expression.h.
2852         (innermost_block): Update comment.
2853         * parse.c (parse_exp_1): Add tracker_types parameter.
2854         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2855         tracker_types parameter.  Reset innermost_block.
2856         (parse_exp_in_context): Remove.
2857         (parse_expression_for_completion): Update.
2858         * objfiles.c (~objfile): Don't reset expression_context_block or
2859         innermost_block.
2860         * expression.h (enum innermost_block_tracker_type): Move from
2861         parser-defs.h.
2862         (parse_exp_1): Add tracker_types parameter.
2863         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2864         reset innermost_block.
2865
2866 2019-03-23  Tom Tromey  <tom@tromey.com>
2867
2868         * objfiles.h: Include bcache.h.
2869
2870 2019-03-23  Tom Tromey  <tom@tromey.com>
2871
2872         * linespec.c (get_current_search_block): Use
2873         scoped_restore_current_language.
2874         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2875
2876 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2877             Jiong Wang  <jiong.wang@arm.com>
2878
2879         * aarch64-linux-tdep.c
2880         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2881         section.
2882         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2883
2884 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2885             Jiong Wang  <jiong.wang@arm.com>
2886
2887         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2888         instructions.
2889         (aarch64_analyze_prologue_test): Add PACIASP test.
2890         (aarch64_prologue_prev_register): Unmask PC value.
2891
2892 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2893             Jiong Wang  <jiong.wang@arm.com>
2894
2895         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2896         (aarch64_dwarf2_prev_register): Unmask PC value.
2897         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2898         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2899         DW_CFA_AARCH64_negate_ra_state.
2900         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2901
2902 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2903             Jiong Wang  <jiong.wang@arm.com>
2904
2905         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2906         registers.
2907         (aarch64_pseudo_register_name): Likewise.
2908         (aarch64_pseudo_register_type): Likewise.
2909         (aarch64_pseudo_register_reggroup_p): Likewise.
2910         (aarch64_gdbarch_init): Add pauth registers.
2911         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2912         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2913         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2914         (struct gdbarch_tdep): Add regnum for ra_state.
2915
2916 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2917             Jiong Wang  <jiong.wang@arm.com>
2918
2919         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2920
2921 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2922             Jiong Wang  <jiong.wang@arm.com>
2923
2924         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2925         function.
2926         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2927         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2928         (aarch64_gdbarch_init): Add puth registers.
2929         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2930         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2931         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2932
2933 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2934             Jiong Wang  <jiong.wang@arm.com>
2935
2936         * aarch64-linux-nat.c
2937         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2938         * aarch64-linux-tdep.c
2939         (aarch64_linux_core_read_description): Likewise.
2940         (aarch64_linux_get_hwcap): New function.
2941         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2942         (aarch64_linux_get_hwcap): New declaration.
2943
2944 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2945             Jiong Wang  <jiong.wang@arm.com>
2946
2947         * aarch64-linux-nat.c
2948         (aarch64_linux_nat_target::read_description): Add pauth param.
2949         * aarch64-linux-tdep.c
2950         (aarch64_linux_core_read_description): Likewise.
2951         * aarch64-tdep.c (struct target_desc): Add in pauth.
2952         (aarch64_read_description): Add pauth param.
2953         (aarch64_gdbarch_init): Likewise.
2954         * aarch64-tdep.h (aarch64_read_description): Likewise.
2955         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2956         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2957         * features/Makefile: Add new files.
2958         * features/aarch64-pauth.c: New file.
2959         * features/aarch64-pauth.xml: New file.
2960
2961 2019-03-20  Tom Tromey  <tromey@adacore.com>
2962
2963         * infrun.c (handle_inferior_event): Rename from
2964         handle_inferior_event_1.  Create a scoped_value_mark.
2965         (handle_inferior_event): Remove.
2966
2967 2019-03-19  Tom Tromey  <tromey@adacore.com>
2968
2969         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2970         * infrun.h (print_stop_event): Add "displays" parameter.
2971         * infrun.c (print_stop_event): Add "displays" parameter.
2972
2973 2019-03-19  Pedro Alves  <palves@redhat.com>
2974
2975         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2976         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2977         to -1.  Fix TABs vs spaces.
2978         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2979         * tui/tui-out.h (tui_ui_out) Add intro comments.
2980         <m_line, m_start_of_line>: In-class initialize, and add describing
2981         comment.
2982
2983 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2984
2985         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2986         variable names.
2987         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2988
2989 2019-03-18  Pedro Alves  <palves@redhat.com>
2990             Eli Zaretskii <eliz@gnu.org>
2991
2992         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2993         m_line and m_start_of_line.
2994
2995 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2996
2997         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2998         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2999         it returns a newline.  This fixes a regression in TU mode, whereby
3000         the next line is output on the same screen line as the user input.
3001
3002 2019-03-18  Tom Tromey  <tromey@adacore.com>
3003
3004         * minsyms.c (minimal_symbol_reader::install): Remove call to
3005         obstack_blank.
3006
3007 2019-03-18  Pedro Alves  <palves@redhat.com>
3008
3009         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3010         New globals.
3011         (apply_style): New, factored out from ...
3012         (apply_ansi_escape): ... this.  Handle reverse video mode.
3013         (tui_set_reverse_mode): New function.
3014         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3015         * tui/tui-winsource.c (tui_show_source_line): Use
3016         tui_set_reverse_mode instead of setting A_STANDOUT.
3017         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3018         New setter methods.
3019
3020 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3021
3022         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3023         Handle tabs.
3024
3025 2019-03-18  Tom Tromey  <tromey@adacore.com>
3026
3027         * ada-lang.c (empty_array): Add "high" parameter.
3028         (ada_evaluate_subexp): Update.
3029
3030 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3031
3032         * unittests/string_view-selftests.c: Define
3033         _initialize_string_view_selftests unconditionally.
3034
3035 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3036
3037         PR gdb/24350
3038         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3039
3040 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3041
3042         PR gdb/24351
3043         * windows-nat.c (display_selector): Fix format specifiers.
3044
3045 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3046
3047         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3048         tui_refill_source_window instead of tui_refresh_win, to update the
3049         current execution line.  This fixes redisplay of the current line
3050         when stepping through the code with "next" or "step".
3051
3052 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3053
3054         * source-cache.c (source_cache::get_source_lines): Call
3055         find_source_lines to initialize s->nlines.  This fixes vertical
3056         scrolling of TUI source window when the DOWN arrow is pressed.
3057
3058 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3059
3060         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3061         linux-thread-db.c (_initialize_thread_db): Likewise.
3062
3063 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3064
3065         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3066         wclrtoeol in tui_show_source_line".  This reverts changes made in
3067         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3068
3069 2019-03-15  Tom Tromey  <tom@tromey.com>
3070
3071         * symtab.h (struct minimal_symbol): Derive from
3072         general_symbol_info.
3073         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3074         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3075         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3076         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3077         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3078         (MSYMBOL_SEARCH_NAME): Update.
3079         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3080         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3081         * minsyms.c (minimal_symbol_reader::record_full): Update.
3082
3083 2019-03-15  Tom Tromey  <tom@tromey.com>
3084
3085         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3086
3087 2019-03-15  Tom Tromey  <tom@tromey.com>
3088
3089         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3090         unique_xmalloc_ptr.
3091         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3092         Update.
3093         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3094         (build_minimal_symbol_hash_tables)
3095         (minimal_symbol_reader::install): Update.
3096
3097 2019-03-15  Tom Tromey  <tom@tromey.com>
3098
3099         * symtab.c (create_demangled_names_hash): Update.
3100         (symbol_set_names): Update.
3101         * objfiles.h (struct objfile_per_bfd_storage)
3102         <demangled_names_hash>: Now an htab_up.
3103         * objfiles.c (objfile_per_bfd_storage): Simplify.
3104
3105 2019-03-15  Tom Tromey  <tom@tromey.com>
3106
3107         * objfiles.h (struct objfile_per_bfd_storage): Declare
3108         destructor.
3109         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3110         New.
3111         (get_objfile_bfd_data): Use new.  Don't initialize
3112         language_of_main.
3113         (free_objfile_per_bfd_storage): Remove.
3114         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3115
3116 2019-03-15  Tom Tromey  <tom@tromey.com>
3117
3118         * symfile.c (reread_symbols): Update.
3119         * objfiles.c (objfile::objfile): Update.
3120         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3121         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3122         comment.
3123         (minimal_symbol_reader::install): Update.
3124         (terminate_minimal_symbol_table): Remove.
3125         * jit.c (jit_object_close_impl): Update.
3126
3127 2019-03-15  Tom Tromey  <tom@tromey.com>
3128
3129         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3130         initializations.
3131
3132 2019-03-15  Tom Tromey  <tom@tromey.com>
3133
3134         * objfiles.h (struct objfile_per_bfd_storage)
3135         <demangled_hash_languages>: Now a bitset.
3136         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3137         (lookup_minimal_symbol): Update.
3138
3139 2019-03-15  Tom Tromey  <tom@tromey.com>
3140
3141         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3142         Don't return the symbol.
3143         * coffread.c (record_minimal_symbol): Use record_full.
3144
3145 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3146
3147         The MS-Windows port of ncurses fails to switch to a color pair if
3148         one or both of the colors are the implicit default colors.  This
3149         change records the default colors when TUI is initialized, and
3150         then specifies them explicitly when a color pair uses the default
3151         colors.  This allows color styling in TUI mode on MS-Windows.
3152
3153         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3154         ncurses_norm_attr.
3155         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3156         colors in ncurses_norm_attr.
3157         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3158         "none", replace it with the default color recorded in
3159         ncurses_norm_attr.
3160
3161 2019-03-14  Tom Tromey  <tromey@adacore.com>
3162
3163         * source-cache.h (class source_cache) <get_source_lines>: Return
3164         std::string.
3165         * source-cache.c (source_cache::extract_lines): Handle case where
3166         first_pos==npos.  Return std::string.
3167         (source_cache::get_source_lines): Update.
3168
3169 2019-03-14  Tom Tromey  <tromey@adacore.com>
3170
3171         * NEWS: Add item for "style sources" commands.
3172         * source-cache.c (source_cache::get_source_lines): Check
3173         source_styling.
3174         * cli/cli-style.c (source_styling): New global.
3175         (_initialize_cli_style): Add "style sources" commands.
3176         (show_style_sources): New function.
3177         * cli/cli-style.h (source_styling): Declare.
3178
3179 2019-03-14  Pedro Alves  <palves@redhat.com>
3180             Tom Tromey  <tromey@adacore.com>
3181
3182         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3183         * tui/tui-winsource.c (tui_refill_source_window): New function,
3184         from...
3185         (tui_horizontal_source_scroll): ... here.  Move some logic.
3186         * cli/cli-style.c (set_style_enabled): Notify new observable.
3187         * tui/tui-hooks.c (tui_redisplay_source): New function.
3188         (tui_attach_detach_observers): Attach or detach
3189         tui_redisplay_source.
3190         * observable.h (source_styling_changed): New observable.
3191         * observable.c: Define source_styling_changed observable.
3192
3193 2019-03-13  Tom Tromey  <tromey@adacore.com>
3194
3195         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3196         (i386_gnu_nat_target::store_registers): Update.
3197         * target-debug.h (target_debug_print_std_string): New macro.
3198         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3199         * windows-tdep.c (display_one_tib): Update.
3200         * tui/tui-stack.c (tui_make_status_line): Update.
3201         * top.c (print_inferior_quit_action): Update.
3202         * thread.c (thr_try_catch_cmd): Update.
3203         (add_thread_with_info): Update.
3204         (thread_target_id_str): Update.
3205         (thr_try_catch_cmd): Update.
3206         (thread_command): Update.
3207         (thread_find_command): Update.
3208         * record-btrace.c (record_btrace_target::info_record)
3209         (record_btrace_resume_thread, record_btrace_target::resume)
3210         (record_btrace_cancel_resume, record_btrace_step_thread)
3211         (record_btrace_target::wait, record_btrace_target::wait)
3212         (record_btrace_target::wait, record_btrace_target::stop): Update.
3213         * progspace.c (print_program_space): Update.
3214         * process-stratum-target.c
3215         (process_stratum_target::thread_address_space): Update.
3216         * linux-fork.c (linux_fork_mourn_inferior)
3217         (detach_checkpoint_command, info_checkpoints_command)
3218         (linux_fork_context): Update.
3219         (linux_fork_detach): Update.
3220         (class scoped_switch_fork_info): Update.
3221         (delete_checkpoint_command): Update.
3222         * infrun.c (follow_fork_inferior): Update.
3223         (follow_fork_inferior): Update.
3224         (proceed_after_vfork_done): Update.
3225         (handle_vfork_child_exec_or_exit): Update.
3226         (follow_exec): Update.
3227         (displaced_step_prepare_throw): Update.
3228         (displaced_step_restore): Update.
3229         (start_step_over): Update.
3230         (resume_1): Update.
3231         (clear_proceed_status_thread): Update.
3232         (proceed): Update.
3233         (print_target_wait_results): Update.
3234         (do_target_wait): Update.
3235         (context_switch): Update.
3236         (stop_all_threads): Update.
3237         (restart_threads): Update.
3238         (finish_step_over): Update.
3239         (handle_signal_stop): Update.
3240         (switch_back_to_stepped_thread): Update.
3241         (keep_going_pass_signal): Update.
3242         (print_exited_reason): Update.
3243         (normal_stop): Update.
3244         * inferior.c (inferior_pid_to_str): Change return type.
3245         (print_selected_inferior): Update.
3246         (add_inferior): Update.
3247         (detach_inferior): Update.
3248         * dummy-frame.c (fprint_dummy_frames): Update.
3249         * dcache.c (dcache_info_1): Update.
3250         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3251         (btrace_fetch, btrace_clear): Update.
3252         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3253         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3254         type.
3255         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3256         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3257         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3258         * gdbarch.c, gdbarch.h: Rebuild.
3259         * gdbarch.sh (core_pid_to_str): Change return type.
3260         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3261         return type.
3262         (windows_nat_target::pid_to_str): Change return type.
3263         (windows_delete_thread): Update.
3264         (windows_nat_target::attach): Update.
3265         (windows_nat_target::files_info): Update.
3266         * target-delegates.c: Rebuild.
3267         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3268         return type.
3269         (sol_thread_target::pid_to_str): Change return type.
3270         * remote.c (class remote_target) <pid_to_str>: Change return
3271         type.
3272         (remote_target::pid_to_str): Change return type.
3273         (extended_remote_target::attach, remote_target::remote_stop_ns)
3274         (remote_target::remote_notif_remove_queued_reply)
3275         (remote_target::push_stop_reply, remote_target::disable_btrace):
3276         Update.
3277         (extended_remote_target::attach): Update.
3278         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3279         type.
3280         (gdbsim_target::pid_to_str): Change return type.
3281         * ravenscar-thread.c (struct ravenscar_thread_target)
3282         <pid_to_str>: Change return type.
3283         (ravenscar_thread_target::pid_to_str): Change return type.
3284         * procfs.c (class procfs_target) <pid_to_str>: Change return
3285         type.
3286         (procfs_target::pid_to_str): Change return type.
3287         (procfs_target::attach): Update.
3288         (procfs_target::detach): Update.
3289         (procfs_target::fetch_registers): Update.
3290         (procfs_target::store_registers): Update.
3291         (procfs_target::wait): Update.
3292         (procfs_target::files_info): Update.
3293         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3294         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3295         return type.
3296         (nto_procfs_target::pid_to_str): Change return type.
3297         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3298         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3299         return type.
3300         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3301         (exit_lwp): Update.
3302         (attach_proc_task_lwp_callback, get_detach_signal)
3303         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3304         (linux_nat_target::resume, wait_lwp, stop_callback)
3305         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3306         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3307         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3308         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3309         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3310         type.
3311         (inf_ptrace_target::attach): Update.
3312         (inf_ptrace_target::files_info): Update.
3313         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3314         type.
3315         (go32_nat_target::pid_to_str): Change return type.
3316         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3317         (gnu_nat_target::wait): Update.
3318         (gnu_nat_target::wait): Update.
3319         (gnu_nat_target::resume): Update.
3320         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3321         (fbsd_nat_target::wait): Update.
3322         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3323         type.
3324         (darwin_nat_target::attach): Update.
3325         * corelow.c (class core_target) <pid_to_str>: Change return type.
3326         (core_target::pid_to_str): Change return type.
3327         * target.c (normal_pid_to_str): Change return type.
3328         (default_pid_to_str): Likewise.
3329         (target_pid_to_str): Change return type.
3330         (target_translate_tls_address): Update.
3331         (target_announce_detach): Update.
3332         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3333         return type.
3334         (bsd_uthread_target::pid_to_str): Change return type.
3335         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3336         type.
3337         (bsd_kvm_target::pid_to_str): Change return type.
3338         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3339         return type.
3340         (aix_thread_target::pid_to_str): Change return type.
3341         * target.h (struct target_ops) <pid_to_str>: Change return type.
3342         (target_pid_to_str, normal_pid_to_str): Likewise.
3343         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3344         type.
3345         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3346         type.
3347         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3348         return type.
3349         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3350         type.
3351         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3352         type.
3353         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3354         return type.
3355
3356 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3357
3358         * NEWS: Mention that the new default MI version is 3.  Mention
3359         changes to the output of commands and events that deal with
3360         multi-location breakpoints.
3361         * breakpoint.c: Include "mi/mi-out.h".
3362         (print_one_breakpoint): Change output syntax if using MI version
3363         >= 3.
3364         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3365         New.
3366         (mi_multi_location_breakpoint_output_fixed): New.
3367         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3368         (mi_cmd_fix_multi_location_breakpoint_output): New.
3369         (mi_multi_location_breakpoint_output_fixed): New.
3370         * mi/mi-cmds.c (mi_cmds): Register command
3371         -fix-multi-location-breakpoint-output.
3372         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3373         interpreter "mi".
3374
3375 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3376
3377         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3378         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3379         instantiate mi_ui_out based on interpreter name.
3380         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3381         * mi/mi-main.c (mi_load_progress): Likewise.
3382
3383 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3384
3385         * NEWS: Combine separate "New targets" sections for 8.3.
3386
3387 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3388
3389         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3390         (ppcfbsd_init_abi): Install gdbarch
3391         "fetch_tls_load_module_address" and "get_thread_local_address"
3392         methods.
3393
3394 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3395
3396         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3397         (riscv_fbsd_init_abi): Install gdbarch
3398         "fetch_tls_load_module_address" and "get_thread_local_address"
3399         methods.
3400
3401 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3402
3403         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3404         (i386fbsd_init_abi): Install gdbarch
3405         "fetch_tls_load_module_address" and "get_thread_local_address"
3406         methods.
3407
3408 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3409
3410         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3411         (amd64fbsd_init_abi): Install gdbarch
3412         "fetch_tls_load_module_address" and "get_thread_local_address"
3413         methods.
3414
3415 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3416
3417         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3418         (struct fbsd_pspace_data): New type.
3419         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3420         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3421         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3422         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3423         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3424
3425 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3426
3427         * gdbtypes.c (lookup_struct_elt): New function.
3428         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3429         * gdbtypes.h (struct struct_elt): New type.
3430         (lookup_struct_elt): New prototype.
3431
3432 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3433
3434         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3435         remove disabled code block.
3436
3437 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3438
3439         * gdbarch.sh (get_thread_local_address): New method.
3440         * gdbarch.h, gdbarch.c: Regenerate.
3441         * target.c (target_translate_tls_address): Use
3442         gdbarch_get_thread_local_address if present instead of
3443         target::get_thread_local_address.
3444
3445 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3446
3447         * target.h (target::get_thread_local_address): Update comment.
3448
3449 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3450
3451         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3452         objfile->separate_debug_objfile_backlink if not NULL.
3453
3454 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3455
3456         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3457         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3458         (amd64bsd_store_inferior_registers): Likewise.
3459         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3460         Enable segment base registers.
3461         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3462         PT_GETFSBASE and PT_GETGSBASE.
3463         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3464         PT_SETGSBASE.
3465         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3466         segment base registers.
3467         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3468
3469 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3470
3471         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3472         Update calls to i386_target_description to add 'segments'
3473         parameter.
3474         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3475         add segment base registers.
3476         * arch/i386.c (i386_create_target_description): Add 'segments'
3477         parameter to enable segment base registers.
3478         * arch/i386.h (i386_create_target_description): Likewise.
3479         * features/i386/32bit-segments.xml: New file.
3480         * features/i386/32bit-segments.c: Generate.
3481         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3482         call to i386_target_description to add 'segments' parameter.
3483         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3484         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3485         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3486         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3487         if feature is present.
3488         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3489         Add 'segments' parameter to call to i386_target_description.
3490         (i386_target_description): Add 'segments' parameter to enable
3491         segment base registers.
3492         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3493         to call to i386_target_description.
3494         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3495         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3496         Define I386_NUM_REGS.
3497         (i386_target_description): Add 'segments' parameter to enable
3498         segment base registers.
3499
3500 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3501
3502         PR/24325
3503         * source-cache.c: #undef open and close, to avoid unresolved
3504         externals during linking.
3505
3506 2019-03-12  Tom Tromey  <tromey@adacore.com>
3507
3508         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3509         const.  Add initializers.
3510         (_initialize_remote): Don't initialize ptid globals.
3511
3512 2019-03-12  Pedro Alves  <palves@redhat.com>
3513
3514         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3515
3516 2019-03-12  Pedro Alves  <palves@redhat.com>
3517
3518         * cp-name-parser.y (main): Remove unused 'len' variable.
3519
3520 2019-03-12  Tom Tromey  <tromey@adacore.com>
3521
3522         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3523         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3524
3525 2019-03-12  Tom Tromey  <tromey@adacore.com>
3526
3527         * linux-nat.c (iterate_over_lwps): Update.
3528         (stop_callback): Remove parameter.
3529         (stop_wait_callback, detach_callback, resume_set_callback)
3530         (select_singlestep_lwp_callback, set_ignore_sigint)
3531         (status_callback, resumed_callback, resume_clear_callback)
3532         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3533         data parameter.
3534         (linux_nat_target::detach, linux_nat_target::resume)
3535         (linux_stop_and_wait_all_lwps, select_event_lwp)
3536         (linux_nat_filter_event, linux_nat_wait_1)
3537         (linux_nat_target::kill, linux_nat_target::stop)
3538         (linux_nat_target::stop): Update.
3539         (linux_nat_resume_callback): Change type.
3540         (resume_stopped_resumed_lwps, count_events_callback)
3541         (select_event_lwp_callback): Likewise.
3542         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3543         * arm-linux-nat.c (struct update_registers_data): Remove.
3544         (update_registers_callback): Change type.
3545         (arm_linux_insert_hw_breakpoint1): Update.
3546         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3547         parameter.
3548         (x86_linux_dr_set_addr): Update.
3549         (x86_linux_dr_set_control): Update.
3550         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3551         (iterate_over_lwps): Use gdb::function_view.
3552         * nat/aarch64-linux-hw-point.c (struct
3553         aarch64_dr_update_callback_param): Remove.
3554         (debug_reg_change_callback): Change type.
3555         (aarch64_notify_debug_reg_change): Update.
3556         * s390-linux-nat.c (s390_refresh_per_info): Update.
3557
3558 2019-03-11  Tom Tromey  <tromey@adacore.com>
3559
3560         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3561         redundant assignment to "this_cu".
3562
3563 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3564
3565         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3566
3567 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3568
3569         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3570         from...
3571         (rank_one_type): ... this.
3572
3573 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3574
3575         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3576         from...
3577         (rank_one_type): ... this.
3578
3579 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3580
3581         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3582         from...
3583         (rank_one_type): ... this.
3584
3585 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3586
3587         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3588         from...
3589         (rank_one_type): ... this.
3590
3591 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3592
3593         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3594         from...
3595         (rank_one_type): ... this.
3596
3597 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3598
3599         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3600         from...
3601         (rank_one_type): ... this.
3602
3603 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3604
3605         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3606         from...
3607         (rank_one_type): ... this.
3608
3609 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3610
3611         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3612         from...
3613         (rank_one_type): ... this.
3614
3615 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3616
3617         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3618         from...
3619         (rank_one_type): ... this.
3620
3621 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3622
3623         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3624         from...
3625         (rank_one_type): ... this.
3626
3627 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3628
3629         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3630         from...
3631         (rank_one_type): ... this.
3632
3633 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3634
3635         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3636         from...
3637         (rank_one_type): ... this.
3638
3639 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3640
3641         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3642         inferior-events' shows the example events.
3643
3644 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3645
3646         Support styling on native MS-Windows console
3647
3648         PR/24315
3649         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3650         on MS-Windows if $TERM is not defined.
3651
3652         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3653
3654         * posix-hdep.c (gdb_console_fputs):
3655         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3656         functions.
3657         * ui-file.h (gdb_console_fputs): Add prototype.
3658
3659         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3660         back to fputs only if the former returns zero.
3661
3662 2019-03-07  Tom Tromey  <tom@tromey.com>
3663
3664         * symmisc.c (print_symbol_bcache_statistics): Update.
3665         (print_objfile_statistics): Update.
3666         * symfile.c (allocate_symtab): Update.
3667         * stabsread.c: Don't include bcache.h.
3668         * psymtab.h (struct psymbol_bcache): Don't declare.
3669         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3670         (psymbol_bcache_init, psymbol_bcache_free)
3671         (psymbol_bcache_get_bcache): Don't declare.
3672         * psymtab.c (struct psymbol_bcache): Remove.
3673         (psymtab_storage::psymtab_storage): Update.
3674         (psymtab_storage::~psymtab_storage): Update.
3675         (psymbol_bcache_init, psymbol_bcache_free)
3676         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3677         (add_psymbol_to_bcache): Update.
3678         (allocate_psymtab): Update.
3679         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3680         macro_cache>: No longer pointers.
3681         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3682         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3683         * macrotab.c (macro_bcache): Update.
3684         * macroexp.c: Don't include bcache.h.
3685         * gdbtypes.c (check_types_worklist): Update.
3686         (types_deeply_equal): Remove TRY/CATCH.  Update.
3687         * elfread.c (elf_symtab_read): Update.
3688         * dwarf2read.c: Don't include bcache.h.
3689         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3690         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3691         (print_bcache_statistics, bcache_memory_used): Don't declare.
3692         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3693         methods.  Rename all data members.
3694         * bcache.c (struct bcache): Move to bcache.h.
3695         (bcache::expand_hash_table): Rename from expand_hash_table.
3696         (bcache): Remove.
3697         (bcache::insert): Rename from bcache_full.
3698         (bcache::compare): Rename from bcache_compare.
3699         (bcache_xmalloc): Remove.
3700         (bcache::~bcache): Rename from bcache_xfree.
3701         (bcache::print_statistics): Rename from print_bcache_statistics.
3702         (bcache::memory_used): Rename from bcache_memory_used.
3703
3704 2019-03-07  Pedro Alves  <palves@redhat.com>
3705
3706         * infrun.c (normal_stop): Also check for
3707         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3708
3709 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3710
3711         * f-lang.c (value_from_host_double): Moved to...
3712         * value.c (value_from_host_double): ...here.
3713         * value.h (value_from_host_double): Declare.
3714         * guile/scm-math.c (vlscm_convert_typed_number): Use
3715         value_from_host_double.
3716         (vlscm_convert_number): Likewise.
3717         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3718         * python/py-value.c (convert_value_from_python): Likewise.
3719
3720 2019-03-06  Tom Tromey  <tom@tromey.com>
3721
3722         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3723
3724 2019-03-06  Tom Tromey  <tom@tromey.com>
3725
3726         * utils.h (free_current_contents): Don't declare.
3727         * utils.c (free_current_contents): Remove.
3728
3729 2019-03-06  Tom Tromey  <tom@tromey.com>
3730
3731         * top.c (quit_force): Update.
3732         * main.c (captured_command_loop): Update.
3733         * common/new-op.c (operator new): Update.
3734         * common/common-exceptions.c (struct catcher)
3735         <save_cleanup_chain>: Remove member.
3736         (exceptions_state_mc_init): Update.
3737         (exception_try_scope_entry): Return nullptr.
3738         (exception_try_scope_exit, exception_rethrow)
3739         (throw_exception_sjlj, throw_exception_cxx): Update.
3740         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3741         (all_cleanups, do_cleanups, discard_cleanups)
3742         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3743         (restore_cleanups, restore_final_cleanups): Don't declare.
3744         (do_final_cleanups): Remove parameter.
3745         * common/cleanups.c (cleanup_chain, make_cleanup)
3746         (make_cleanup_dtor, all_cleanups, do_cleanups)
3747         (discard_my_cleanups, discard_cleanups)
3748         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3749         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3750         (null_cleanup): Remove.
3751         (do_final_cleanups): Remove parameter.
3752
3753 2019-03-06  Tom Tromey  <tom@tromey.com>
3754
3755         * remote.c (remote_target::remote_parse_stop_reply): Use
3756         unique_xmalloc_ptr.
3757
3758 2019-03-06  Tom Tromey  <tom@tromey.com>
3759
3760         * stabsread.c (struct stabs_field_info): Rename from field_info.
3761         <list, fnlist>: Add initializers.
3762         <obstack>: New member.
3763         (read_member_functions, read_struct_fields, read_baseclasses):
3764         Allocate on obstack.  Don't use cleanups.
3765         (read_one_struct_field, read_member_functions, read_struct_fields)
3766         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3767         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3768         (read_struct_type): Update.
3769
3770 2019-03-06  Tom Tromey  <tom@tromey.com>
3771
3772         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3773         * common/filestuff.h (make_cleanup_close): Don't declare.
3774         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3775         Remove.
3776
3777 2019-03-06  Tom Tromey  <tom@tromey.com>
3778
3779         * solib-aix.c: Use make_scope_exit.
3780
3781 2019-03-06  Tom Tromey  <tom@tromey.com>
3782
3783         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3784         Use make_scope_exit.
3785
3786 2019-03-06  Tom Tromey  <tom@tromey.com>
3787
3788         * solib-svr4.c (disable_probes_interface): Remove parameter.
3789         (svr4_handle_solib_event): Use make_scope_exit.
3790
3791 2019-03-06  Tom Tromey  <tom@tromey.com>
3792
3793         * remote.c (struct stop_reply_deleter): Remove.
3794         (stop_reply_up): Update.
3795         (struct stop_reply): Derive from notif_event.  Don't typedef.
3796         <regcache>: Now a std::vector.
3797         (stop_reply_xfree): Remove.
3798         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3799         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3800         (remote_target::discard_pending_stop_replies): Use delete.
3801         (remote_target::remote_parse_stop_reply): Update.
3802         (remote_target::process_stop_reply): Update.
3803         * remote-notif.h (struct notif_event): Add virtual destructor.
3804         Remove "dtr" member.
3805         (struct notif_client) <alloc_event>: Return a unique_ptr.
3806         (notif_event_xfree): Don't declare.
3807         (notif_event_up): New typedef.
3808         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3809         (notif_event_xfree, do_notif_event_xfree): Remove.
3810         (remote_notif_state_xfree): Update.
3811
3812 2019-03-06  Tom Tromey  <tom@tromey.com>
3813
3814         * infrun.c (displaced_step_clear_cleanup): Now a
3815         forward_scope_exit type.
3816         (displaced_step_prepare_throw): Update.
3817         (displaced_step_fixup): Update.
3818
3819 2019-03-06  Tom Tromey  <tom@tromey.com>
3820
3821         * inferior.h (class inferior): Update comment.
3822         * gdbthread.h (class thread_info): Update comment.
3823
3824 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3825             Tom Tromey  <tom@tromey.com>
3826
3827         * stabsread.h (struct stab_section_list): Remove.
3828         (coffstab_build_psymtabs): Update.
3829         * dbxread.c (symbuf_sections): Now a std::vector.
3830         (sect_idx): New global.
3831         (fill_symbuf): Update.
3832         (coffstab_build_psymtabs): Change type of stabsects parameter.
3833         Update.
3834         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3835         std::vector.
3836         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3837         (coff_locate_sections): Update.
3838         (coff_symfile_read): Remove cleanups.  Update.
3839         (init_stringtab): Add storage parameter.
3840         (free_stringtab, free_stringtab_cleanup): Remove.
3841         (init_lineno): Add storage parameter.
3842         (free_linetab, free_linetab_cleanup): Remove.
3843
3844 2019-03-06  Pedro Alves  <palves@redhat.com>
3845
3846         * linux-fork.c (fork_info::clobber_regs): Delete.
3847         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3848         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3849         comment.  Adjust.
3850         (scoped_switch_fork_info::scoped_switch_fork_info)
3851         (checkpoint_command, linux_fork_context): Adjust
3852         fork_save_infrun_state calls.
3853
3854 2019-03-06  Pedro Alves  <palves@redhat.com>
3855
3856         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3857         (inf_has_multiple_threads): Return 'bool' and rewrite using
3858         inferior_info::threads().
3859
3860 2019-03-06  Pedro Alves  <palves@redhat.com>
3861
3862         * linux-fork.c: Include <list>.
3863         (fork_list): Now a std::list instance.
3864         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3865         (forks_exist_p, find_last_fork): Adjust.
3866         (new_fork): Delete.
3867         (one_fork_p): New.
3868         (add_fork): Adjust.
3869         (free_fork): Delete, folded into fork_info::~fork_info().
3870         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3871         Adjust.
3872         (init_fork_list): Delete.
3873         (linux_fork_killall, linux_fork_mourn_inferior)
3874         (linux_fork_detach, info_checkpoints_command): Adjust.
3875         (_initialize_linux_fork): No longer call init_fork_list.
3876
3877 2019-03-06  Pedro Alves  <palves@redhat.com>
3878
3879         * linux-fork.c (new_fork): New, split out of ...
3880         (add_fork): ... this.  Return void.  Move "first fork" special
3881         case from here, to ...
3882         (checkpoint_command): ... here.
3883         * linux-linux.h (add_fork): Return void.
3884
3885 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3886
3887         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3888
3889 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3890             Chris January  <chris.january@arm.com>
3891             David Lecomber  <david.lecomber@arm.com>
3892
3893         * f-exp.y: New token, UNOP_INTRINSIC.
3894         (exp): New pattern using UNOP_INTRINSIC token.
3895         (f77_keywords): Add 'abs' keyword.
3896         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3897         (value_from_host_double): New function.
3898         (evaluate_subexp_f): Support UNOP_ABS.
3899
3900 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3901
3902         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3903         types.
3904
3905 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3906
3907         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3908         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3909         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3910
3911 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3912
3913         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3914
3915 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3916             Chris January  <chris.january@arm.com>
3917
3918         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3919         * f-exp.y: Define 'KIND' token.
3920         (exp): New pattern for KIND expressions.
3921         (ptype): Handle types with a kind extension.
3922         (direct_abs_decl): Extend to spot kind extensions.
3923         (f77_keywords): Add 'kind' to the list.
3924         (push_kind_type): New function.
3925         (convert_to_kind_type): New function.
3926         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3927         * parse.c (operator_length_standard): Likewise.
3928         * parser-defs.h (enum type_pieces): Add tp_kind.
3929         * std-operator.def: Add UNOP_KIND.
3930
3931 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3932
3933         * f-exp.y (f_parse): Set yydebug.
3934
3935 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3936
3937         * f-lang.c (evaluate_subexp_f): New function.
3938         (exp_descriptor_f): New global.
3939         (f_language_defn): Use exp_descriptor_f instead of
3940         exp_descriptor_standard.
3941
3942 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3943
3944         * f-exp.y (struct token): Add comments.
3945         (dot_ops): Remove uppercase versions and the end marker.
3946         (f77_keywords): Likewise.
3947         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3948         entries in the dot_ops array are case insensitive, and use
3949         strncasecmp to compare strings.  Also some whitespace cleanup in
3950         this area.  Similar for the f77_keywords array, except entries in
3951         this list might be case sensitive.
3952
3953 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3954
3955         * f-exp.y (struct f77_boolean_val): Add comments.
3956         (boolean_values): Remove uppercase versions, and end marker.
3957         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3958         and use strncasecmp to achieve case insensitivity.  Additionally,
3959         perform whitespace cleanup around this code.
3960
3961 2019-03-06  Tom Tromey  <tromey@adacore.com>
3962
3963         * remote-sim.c (gdbsim_target_open): Use result of
3964         gdb_argv::release.
3965
3966 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3967         Dirk Schubert  <dirk.schubert@arm.com>
3968         Chris January  <chris.january@arm.com>
3969
3970         * eval.c (evaluate_subexp_standard): Call Fortran argument
3971         wrapping logic.
3972         * f-lang.c (struct value): A value which can be passed into a
3973         Fortran function call.
3974         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3975         where appropriate.
3976         (struct type): Value ready for a Fortran function call.
3977         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3978         is needed.
3979         * f-lang.h (fortran_argument_convert): Declaration.
3980         (fortran_preserve_arg_pointer): Declaration.
3981         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3982
3983 2019-03-05  Tom Tromey  <tromey@adacore.com>
3984
3985         * python/py-prettyprint.c (print_string_repr): Remove #if.
3986         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3987
3988 2019-03-05  Tom Tromey  <tromey@adacore.com>
3989
3990         * target.c (the_dummy_target): Move later.  Change type to
3991         "dummy_target".
3992         (initialize_targets): Don't initialize the_dummy_target.
3993
3994 2019-03-05  Tom Tromey  <tromey@adacore.com>
3995
3996         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3997         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3998
3999 2019-03-05  Tom Tromey  <tromey@adacore.com>
4000
4001         * windows-nat.c (windows_nat_target::attach)
4002         (windows_nat_target::detach): Don't call gdb_flush.
4003         * valprint.c (generic_val_print, val_print, val_print_string):
4004         Don't call gdb_flush.
4005         * utils.c (defaulted_query): Don't call gdb_flush.
4006         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4007         * target.c (target_announce_detach): Don't call gdb_flush.
4008         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4009         * remote.c (extended_remote_target::attach): Don't call
4010         gdb_flush.
4011         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4012         * printcmd.c (do_examine): Don't call gdb_flush.
4013         (info_display_command): Don't call gdb_flush.
4014         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4015         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4016         * memattr.c (info_mem_command): Don't call gdb_flush.
4017         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4018         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4019         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4020         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4021         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4022         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4023         (gnu_nat_target::detach): Don't call gdb_flush.
4024         * f-valprint.c (f_val_print): Don't call gdb_flush.
4025         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4026         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4027         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4028         gdb_flush.
4029         * c-valprint.c (c_val_print): Don't call gdb_flush.
4030         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4031
4032 2019-03-05  Tom Tromey  <tromey@adacore.com>
4033
4034         * varobj.c (update_dynamic_varobj_children): Update.
4035         (install_default_visualizer): Use reset, not release.
4036         * value.c (set_internalvar): Update.
4037         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4038         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4039         ATTRIBUTE_UNUSED_RESULT.
4040
4041 2019-03-05  Tom Tromey  <tromey@adacore.com>
4042
4043         * remote.c (class scoped_remote_fd) <release>: Add
4044         ATTRIBUTE_UNUSED_RESULT.
4045
4046 2019-03-05  Tom Tromey  <tromey@adacore.com>
4047
4048         * macroexp.c (struct macro_buffer) <release>: Add
4049         ATTRIBUTE_UNUSED_RESULT.
4050
4051 2019-03-05  Tom Tromey  <tromey@adacore.com>
4052
4053         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4054         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4055         ATTRIBUTE_UNUSED_RESULT.
4056
4057 2019-03-05  Tom Tromey  <tromey@adacore.com>
4058
4059         * common/scoped_fd.h (class scoped_fd) <release>: Add
4060         ATTRIBUTE_UNUSED_RESULT.
4061
4062 2019-03-05  Tom Tromey  <tromey@adacore.com>
4063
4064         * parser-defs.h (struct parser_state) <release>: Add
4065         ATTRIBUTE_UNUSED_RESULT.
4066
4067 2019-03-05  Tom Tromey  <tromey@adacore.com>
4068
4069         * utils.h (class gdb_argv) <release>: Add
4070         ATTRIBUTE_UNUSED_RESULT.
4071         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4072
4073 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4074
4075         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4076         for-loop range, to avoid compiler warnings.
4077
4078         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4079         avoid compiler warnings about unused variables.
4080
4081         * NEWS: Mention end of support for native debugging on MS-Windows
4082         before XP.
4083
4084         PR gdb/24292
4085         * common/netstuff.c:
4086         * gdbserver/gdbreplay.c
4087         * gdbserver/remote-utils.c:
4088         * ser-tcp.c:
4089         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4090         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4091         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4092         'getaddrinfo' and 'freeaddrinfo' were not available before
4093         Windows XP, and mingw.org's MinGW headers by default define
4094         _WIN32_WINNT to 0x500.
4095
4096 2019-03-01  Gary Benson <gbenson@redhat.com>
4097
4098         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4099
4100 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4101             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4102
4103         PR gdb/8527
4104         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4105         set_sigint_trap, clear_sigint_trap.
4106
4107 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4108
4109         * target.c (target_detach): Clear the regcache and the
4110         frame cache.
4111
4112 2019-02-27  Pedro Alves  <palves@redhat.com>
4113
4114         * utils.c (set_screen_size): When we cap the height/width sizes,
4115         tweak the corresponding command variable to show "unlimited":
4116
4117 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4118             Pedro Alves  <palves@redhat.com>
4119
4120         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4121         before calling rl_set_screen_size.
4122
4123 2019-02-27  Tom Tromey  <tromey@adacore.com>
4124
4125         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4126         define.
4127         * python/py-value.c: Remove Python 2.4 workaround.
4128         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4129         workaround.
4130         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4131         Python 2.4 workaround.
4132         * python/python-internal.h: Remove Python 2.4 comment.
4133         (Py_ssize_t): Don't define.
4134         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4135         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4136         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4137         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4138         * python/python.c (do_start_initialization): Remove Python 2.4
4139         workaround.
4140         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4141         (print_children): Remove Python 2.4 workaround.
4142         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4143         workaround.
4144         (CHARBUFFERPROC_NAME): Remove.
4145         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4146         Python 2.4 workaround.
4147
4148 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4149
4150         * NEWS: Note minimum Python version.
4151
4152 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4153
4154         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4155         code from these functions.  Remove corresponding ifdefs.  Use
4156         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4157         Remove gotos and target of gotos.
4158         (infpy_search_memory): Likewise.
4159
4160 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4161
4162         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4163         (hppa_gdbarch_init): Don't register deleted functions with
4164         gdbarch.
4165
4166 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4167
4168         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4169         (h8300_unwind_sp): Delete.
4170         (h8300_dummy_id): Delete.
4171         (h8300_gdbarch_init): Don't register deleted functions with
4172         gdbarch.
4173
4174 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4175
4176         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4177         (ft32_unwind_pc): Delete.
4178         (ft32_unwind_sp): Delete.
4179         (ft32_gdbarch_init): Don't register deleted functions with
4180         gdbarch.
4181
4182 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4183
4184         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4185         (frv_unwind_pc): Delete.
4186         (frv_unwind_sp): Delete.
4187         (frv_gdbarch_init): Don't register deleted functions with
4188         gdbarch.
4189
4190 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4191
4192         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4193         (riscv_unwind_pc): Delete.
4194         (riscv_unwind_sp): Delete.
4195         (riscv_gdbarch_init): Don't register deleted functions with
4196         gdbarch.
4197
4198 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4199
4200         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4201         (csky_unwind_pc): Delete.
4202         (csky_unwind_sp): Delete.
4203         (csky_gdbarch_init): Don't register deleted functions with
4204         gdbarch.
4205
4206 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4207
4208         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4209         (cris_unwind_pc): Delete.
4210         (cris_unwind_sp): Delete.
4211         (cris_gdbarch_init): Don't register deleted functions with
4212         gdbarch.
4213
4214 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4215
4216         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4217         (bfin_unwind_pc): Delete.
4218         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4219
4220 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4221
4222         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4223         (arm_unwind_pc): Delete.
4224         (arm_unwind_sp): Delete.
4225         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4226
4227 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4228
4229         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4230         (arc_unwind_pc): Delete.
4231         (arc_unwind_sp): Delete.
4232         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4233
4234 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4235
4236         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4237         (alpha_unwind_pc): Delete.
4238         (alpha_gdbarch_init): Don't register deleted functions with
4239         gdbarch.
4240
4241 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4242
4243         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4244         (aarch64_unwind_pc): Delete.
4245         (aarch64_unwind_sp): Delete.
4246         (aarch64_gdbarch_init): Don't register deleted functions with
4247         gdbarch.
4248
4249 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4250
4251         * gdbtypes.c (type_align): Don't consider static members when
4252         computing structure alignment.
4253
4254 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4255
4256         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4257         return 0 for other types.
4258         * arch-utils.c (default_type_align): Always return 0.
4259         * gdbarch.h: Regenerate.
4260         * gdbarch.sh (type_align): Extend comment.
4261         * gdbtypes.c (type_align): Add additional comments, always call
4262         gdbarch_type_align before applying the default rules.
4263         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4264         generic code will then apply a suitable default.
4265         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4266         types, return 0 for other types.
4267
4268 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4269
4270         * NEWS: Create a new section for the next release branch.
4271         Rename the section of the current branch, now that it has
4272         been cut.
4273
4274 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4275
4276         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4277         * version.in: Bump version to 8.3.50.DATE-git.
4278
4279 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4280
4281         * aix-thread.c (ptid_cmp): Remove unused variable.
4282         (get_signaled_thread): Likewise.
4283         (store_regs_user_thread): Likewise.
4284         (store_regs_kernel_thread): Likewise.
4285         (fetch_regs_kernel_thread): Remove shadowed variable.
4286
4287 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4288
4289         * features/riscv/32bit-cpu.xml: Add register numbers.
4290         * features/riscv/32bit-fpu.c: Regenerate.
4291         * features/riscv/32bit-fpu.xml: Add register numbers.
4292         * features/riscv/64bit-cpu.xml: Add register numbers.
4293         * features/riscv/64bit-fpu.c: Regenerate.
4294         * features/riscv/64bit-fpu.xml: Add register numbers.
4295
4296 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4297
4298         * NEWS: Mention two argument form of gdb.Value constructor.
4299         * python/py-value.c (convert_buffer_and_type_to_value): New
4300         function.
4301         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4302         Add support for handling an optional second argument.  Call
4303         convert_buffer_and_type_to_value as appropriate.
4304         * python/python-internal.h (Py_buffer_deleter): New struct.
4305         (Py_buffer_up): New typedef.
4306
4307 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4308
4309         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4310         instead of releasing ownership.
4311
4312 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4313
4314         * dwarf2read.c (open_and_init_dwp_file): Call
4315         elf_numsections instead of bfd_count_sections to initialize
4316         dwp_file->num_sections.
4317
4318 2019-02-25  Tom Tromey  <tromey@adacore.com>
4319
4320         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4321
4322 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4323
4324         * gcore.in: Add '--readnever' option when invoking GDB.
4325
4326 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4327
4328         * MAINTAINERS: Update my email address.
4329
4330 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4331
4332         * build-id.c (build_id_to_debug_bfd_1): New function.
4333         (build_id_to_debug_bfd): Look for separate debug file in
4334         sysroot.
4335
4336 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4337
4338         * gdbarch.sh: Update the copyright year range that is placed into
4339         generated files.
4340
4341 2019-02-22  Keith Seitz  <keiths@redhat.com>
4342
4343         PR symtab/23853
4344         * linespec.c (create_sals_line_offset): Search for the default
4345         symtab's filename instead of its fullname.
4346
4347 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4348
4349         * NEWS: Update style defaults.
4350
4351 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4352
4353         * main.c (captured_main_1): Disable styling in batch mode.
4354
4355 2019-02-20  Tom Tromey  <tom@tromey.com>
4356
4357         * symtab.c (symtab_symbol_info): Fix typos.
4358
4359 2019-02-20  Tom Tromey  <tromey@adacore.com>
4360
4361         * findcmd.c (_initialize_mem_search): Use upper case for
4362         metasyntactic variables.
4363
4364 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4365
4366         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4367         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4368
4369 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4370
4371         * top.h (source_file_name): Change to std::string.
4372         * top.c (source_file_name): Likewise.
4373         (command_line_input): Adjust.
4374         * cli/cli-script.c (script_from_file): Adjust.
4375
4376 2019-02-19  Tom Tromey  <tromey@adacore.com>
4377
4378         * ravenscar-thread.c
4379         (ravenscar_thread_target::update_thread_list): Don't call
4380         ada_build_task_list.
4381         * ada-lang.h (ada_build_task_list): Don't declare.
4382         * ada-tasks.c (struct ada_tasks_inferior_data)
4383         <task_list_valid_p>: Now bool.
4384         (read_known_tasks, ada_task_list_changed)
4385         (ada_tasks_invalidate_inferior_data): Update.
4386         (read_known_tasks_array): Return bool.
4387         (read_known_tasks_list): Likewise.
4388         (read_known_tasks): Return void.
4389         (ada_build_task_list): Now static.
4390
4391 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4392
4393         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4394         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4395
4396 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4397
4398         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4399         variant for ada_tasks_pspace_data_handle and
4400         ada_tasks_inferior_data_handle.
4401         (ada_tasks_pspace_data_cleanup): New function.
4402         (ada_tasks_inferior_data_cleanup): New function.
4403
4404 2019-02-17  Tom Tromey  <tom@tromey.com>
4405
4406         * macrotab.h (macro_source_fullname): Return a std::string.
4407         * macrotab.c (macro_include, check_for_redefinition)
4408         (macro_undef, macro_lookup_definition, foreach_macro)
4409         (foreach_macro_in_scope): Update.
4410         (macro_source_fullname): Return a std::string.
4411         * macrocmd.c (show_pp_source_pos): Update.
4412
4413 2019-02-17  Tom Tromey  <tom@tromey.com>
4414
4415         * macrocmd.c (show_pp_source_pos): Style the file names.
4416
4417 2019-02-17  Tom Tromey  <tom@tromey.com>
4418
4419         PR tui/24197:
4420         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4421
4422 2019-02-17  Tom Tromey  <tom@tromey.com>
4423
4424         * ada-lang.c (user_select_syms): Use filtered printing.
4425         * utils.c (wrap_style): New global.
4426         (desired_style): Remove.
4427         (emit_style_escape): Add stream parameter.
4428         (set_output_style, reset_terminal_style, prompt_for_continue):
4429         Update.
4430         (flush_wrap_buffer): Only flush gdb_stdout.
4431         (wrap_here): Set wrap_style.
4432         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4433         treat escape sequences as a character.  Change when wrap buffer is
4434         flushed.
4435         (fputs_styled): Do not set the output style when the default is
4436         requested.
4437         * ui-style.h (struct ui_file_style) <is_default>: New method.
4438         * source.c (print_source_lines_base): Emit escape sequences in one
4439         piece.
4440
4441 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4442
4443         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4444         integers and enumeration types.
4445
4446 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4447
4448         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4449         instead of lookup_symbol_in_language
4450         (do_exact_match): New function.
4451         (ada_get_symbol_name_matcher): Return do_exact_match when
4452         doing a verbatim match.
4453
4454 2019-02-15  Tom Tromey  <tromey@adacore.com>
4455
4456         * ravenscar-thread.c (ravenscar_thread_target::resume)
4457         (ravenscar_thread_target::wait): Special case wildcard requests.
4458
4459 2019-02-15  Tom Tromey  <tromey@adacore.com>
4460
4461         * ravenscar-thread.c (base_ptid): Remove.
4462         (struct ravenscar_thread_target) <close>: New method.
4463         <m_base_ptid>: New member.
4464         <update_inferior_ptid, active_task, task_is_currently_active,
4465         runtime_initialized>: Declare methods.
4466         <ravenscar_thread_target>: Add constructor.
4467         (ravenscar_thread_target::task_is_currently_active)
4468         (ravenscar_thread_target::update_inferior_ptid)
4469         (ravenscar_runtime_initialized): Rename.  Now methods.
4470         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4471         (ravenscar_thread_target::update_thread_list): Update.
4472         (ravenscar_thread_target::active_task): Now method.
4473         (ravenscar_thread_target::store_registers)
4474         (ravenscar_thread_target::prepare_to_store)
4475         (ravenscar_thread_target::prepare_to_store)
4476         (ravenscar_thread_target::mourn_inferior): Update.
4477         (ravenscar_inferior_created): Use "new" to create target.
4478         (ravenscar_thread_target::get_ada_task_ptid): Update.
4479         (_initialize_ravenscar): Don't initialize base_ptid.
4480         (ravenscar_ops): Remove global.
4481
4482 2019-02-15  Tom Tromey  <tromey@adacore.com>
4483
4484         * target.h (push_target): Declare new overload.
4485         * target.c (push_target): New overload, taking an rvalue reference.
4486         * remote.c (remote_target::open_1): Use push_target overload.
4487         * corelow.c (core_target_open): Use push_target overload.
4488
4489 2019-02-15  Tom Tromey  <tromey@adacore.com>
4490
4491         * ravenscar-thread.c (is_ravenscar_task)
4492         (ravenscar_task_is_currently_active): Return bool.
4493         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4494         (_initialize_ravenscar): Remove "(void)".
4495         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4496         Return bool.
4497
4498 2019-02-15  Tom Tromey  <tromey@adacore.com>
4499
4500         * ravenscar-thread.c (ravenscar_runtime_initializer)
4501         (has_ravenscar_runtime, get_running_thread_id)
4502         (ravenscar_thread_target::resume): Fix indentation.
4503
4504 2019-02-15  Tom Tromey  <tromey@adacore.com>
4505
4506         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4507         from ravenscar_arch_ops.
4508         (sparc_ravenscar_ops::fetch_registers)
4509         (sparc_ravenscar_ops::store_registers): Now methods.
4510         (sparc_ravenscar_prepare_to_store): Remove.
4511         (sparc_ravenscar_ops): Redefine.
4512         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4513         methods and destructor.  Remove members.
4514         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4515         (ravenscar_thread_target::store_registers)
4516         (ravenscar_thread_target::prepare_to_store): Update.
4517         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4518         Remove.
4519         (struct ppc_ravenscar_powerpc_ops): Derive from
4520         ravenscar_arch_ops.
4521         (ppc_ravenscar_powerpc_ops::fetch_registers)
4522         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4523         (ppc_ravenscar_powerpc_ops): Redefine.
4524         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4525         (ppc_ravenscar_e500_ops::fetch_registers)
4526         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4527         (ppc_ravenscar_e500_ops): Redefine.
4528         * aarch64-ravenscar-thread.c
4529         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4530         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4531         (aarch64_ravenscar_fetch_registers)
4532         (aarch64_ravenscar_store_registers): Now methods.
4533         (aarch64_ravenscar_ops): Redefine.
4534
4535 2019-02-15  Tom Tromey  <tromey@adacore.com>
4536
4537         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4538         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4539         (ravenscar_thread_target::stopped_by_watchpoint)
4540         (ravenscar_thread_target::stopped_data_address)
4541         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4542
4543 2019-02-15  Tom Tromey  <tromey@adacore.com>
4544
4545         * ravenscar-thread.c: Fix some typos.
4546
4547 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4548             Tom Tromey  <tromey@adacore.com>
4549
4550         * ada-lang.c (ada_exception_sal): Change addr_string to a
4551         std::string.
4552         (create_ada_exception_catchpoint): Update.
4553
4554 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4555             Tom Tromey  <tromey@adacore.com>
4556
4557         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4558         (bp_location_ops): Remove.
4559         (base_breakpoint_allocate_location): Update.
4560         (free_bp_location): Update.
4561         * ada-lang.c (class ada_catchpoint_location)
4562         <ada_catchpoint_location>: Remove ops parameter.
4563         (ada_catchpoint_location_dtor): Remove.
4564         (ada_catchpoint_location_ops): Remove.
4565         (allocate_location_exception): Update.
4566         * breakpoint.h (struct bp_location_ops): Remove.
4567         (class bp_location) <bp_location>: Remove bp_location_ops
4568         parameter.
4569         <~bp_location>: Add destructor.
4570         <ops>: Remove.
4571
4572 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4573             Pedro Alves  <palves@redhat.com>
4574
4575         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4576         'PATH_MAX'.
4577
4578 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4579             Samuel Thibault  <samuel.thibault@gnu.org>
4580             Thomas Schwinge  <thomas@codesourcery.com>
4581
4582         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4583         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4584
4585 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4586
4587         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4588         (check_empty): Use "const char *".
4589
4590         * gnu-nat.c (gnu_nat_target::detach): Instead of
4591         'detach_inferior (pid)' call
4592         'detach_inferior (find_inferior_pid (pid))'.
4593
4594         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4595         'nat/fork-inferior.o'.
4596         * gnu-nat.c: #include "nat/fork-inferior.h".
4597
4598         * gnu-nat.c (gnu_nat_target::detach): Instead of
4599         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4600         * gnu-nat.h: #include "inf-child.h".
4601         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4602         'i386_gnu_nat_target::fetch_registers'.
4603         (gnu_store_registers): Rename/move to
4604         'i386_gnu_nat_target::store_registers'.
4605
4606         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4607         * gnu-nat.h (mach_thread_info): New function.
4608         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4609
4610         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4611
4612 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4613
4614         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4615
4616 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4617
4618         * windows-nat.c (windows_add_thread): Add new parameter
4619         "main_thread_p" with default value set to false.  Update
4620         function documentation as well as all callers.
4621         (windows_delete_thread): Likewise.
4622         (fake_create_process): Update call to windows_add_thread.
4623         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4624         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4625         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4626         call to windows_delete_thread.
4627
4628 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4629
4630         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4631
4632 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4633
4634         * symfile.c (find_separate_debug_file): Use canonical path of
4635         sysroot with child_path instead of gdb_sysroot if it is valid.
4636
4637 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4638
4639         * symfile.c (find_separate_debug_file): Use child_path to
4640         determine if an object file is under a sysroot.
4641
4642 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4643
4644         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4645         unittests/child-path-selftests.c.
4646         * common/pathstuff.c (child_path): New function.
4647         * common/pathstuff.h (child_path): New prototype.
4648         * unittests/child-path-selftests.c: New file.
4649
4650 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4651
4652         * symfile.c (find_separate_debug_file): Look for separate debug
4653         files in debug directories under the sysroot.
4654
4655 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4656
4657         * symtab.h (struct minimal_symbol data_p): New const method.
4658         (struct minimal_symbol text_p): Likewise.
4659         * symtab.c (output_source_filename): Use file name style
4660         to print file name.
4661         (print_symbol_info): Likewise.
4662         (print_msymbol_info): Use address style to print addresses.
4663         Use function name style to print executable text symbols.
4664         (expand_symtab_containing_pc): Use data_p.
4665         (find_pc_sect_compunit_symtab): Likewise.
4666
4667 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4668
4669         * breakpoint.c (describe_other_breakpoints): Use address style
4670         to print addresses.
4671         (say_where): Likewise.
4672
4673 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4674
4675         * ada-typeprint.c (print_func_type): Print function name
4676         style to print function name.
4677         * c-typeprint.c (c_print_type_1): Likewise.
4678
4679 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4680
4681         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4682         for execve.
4683
4684 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4685
4686         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4687         type_stack.
4688
4689 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4690
4691         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4692         TYPE_CODE_REF types.
4693
4694 2019-02-08  Jim Wilson  <jimw@sifive.com>
4695
4696         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4697         (riscv_linux_fregset): New.
4698         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4699
4700 2019-02-07  Tom Tromey  <tom@tromey.com>
4701
4702         * thread.c (thread_cancel_execution_command): Update.
4703         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4704         methods.
4705         (struct thread_fsm_ops): Remove.
4706         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4707         (thread_fsm_should_stop, thread_fsm_return_value)
4708         (thread_fsm_set_finished, thread_fsm_finished_p)
4709         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4710         Don't declare.
4711         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4712         * infrun.c (clear_proceed_status_thread)
4713         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4714         (print_stop_event): Update.
4715         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4716         Add constructor.
4717         (step_command_fsm_ops): Remove.
4718         (new_step_command_fsm): Remove.
4719         (step_1): Update.
4720         (step_command_fsm::should_stop): Rename from
4721         step_command_fsm_should_stop.
4722         (step_command_fsm::clean_up): Rename from
4723         step_command_fsm_clean_up.
4724         (step_command_fsm::do_async_reply_reason): Rename from
4725         step_command_fsm_async_reply_reason.
4726         (struct until_next_fsm): Inherit from thread_fsm.  Add
4727         constructor.
4728         (until_next_fsm_ops): Remove.
4729         (new_until_next_fsm): Remove.
4730         (until_next_fsm::should_stop): Rename from
4731         until_next_fsm_should_stop.
4732         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4733         (until_next_fsm::do_async_reply_reason): Rename from
4734         until_next_fsm_async_reply_reason.
4735         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4736         constructor.  Change type of breakpoint.
4737         (finish_command_fsm_ops): Remove.
4738         (new_finish_command_fsm): Remove.
4739         (finish_command_fsm::should_stop): Rename from
4740         finish_command_fsm_should_stop.
4741         (finish_command_fsm::clean_up): Rename from
4742         finish_command_fsm_clean_up.
4743         (finish_command_fsm::return_value): Rename from
4744         finish_command_fsm_return_value.
4745         (finish_command_fsm::do_async_reply_reason): Rename from
4746         finish_command_fsm_async_reply_reason.
4747         (finish_command): Update.
4748         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4749         Add constructor.
4750         (call_thread_fsm_ops): Remove.
4751         (call_thread_fsm::call_thread_fsm): Rename from
4752         new_call_thread_fsm.
4753         (call_thread_fsm::should_stop): Rename from
4754         call_thread_fsm_should_stop.
4755         (call_thread_fsm::should_notify_stop): Rename from
4756         call_thread_fsm_should_notify_stop.
4757         (run_inferior_call, call_function_by_hand_dummy): Update.
4758         * cli/cli-interp.c (should_print_stop_to_console): Update.
4759         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4760         Add constructor.  Change type of location_breakpoint,
4761         caller_breakpoint.
4762         (until_break_fsm_ops): Remove.
4763         (new_until_break_fsm): Remove.
4764         (until_break_fsm::should_stop): Rename from
4765         until_break_fsm_should_stop.
4766         (until_break_fsm::clean_up): Rename from
4767         until_break_fsm_clean_up.
4768         (until_break_fsm::do_async_reply_reason): Rename from
4769         until_break_fsm_async_reply_reason.
4770         (until_break_command): Update.
4771         * thread-fsm.c: Remove.
4772         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4773
4774 2019-02-07  Tom Tromey  <tom@tromey.com>
4775
4776         * yy-remap.h: Add include guard.
4777         * xtensa-tdep.h: Add include guard.
4778         * xcoffread.h: Rename include guard.
4779         * varobj-iter.h: Add include guard.
4780         * tui/tui.h: Rename include guard.
4781         * tui/tui-winsource.h: Rename include guard.
4782         * tui/tui-wingeneral.h: Rename include guard.
4783         * tui/tui-windata.h: Rename include guard.
4784         * tui/tui-win.h: Rename include guard.
4785         * tui/tui-stack.h: Rename include guard.
4786         * tui/tui-source.h: Rename include guard.
4787         * tui/tui-regs.h: Rename include guard.
4788         * tui/tui-out.h: Rename include guard.
4789         * tui/tui-layout.h: Rename include guard.
4790         * tui/tui-io.h: Rename include guard.
4791         * tui/tui-hooks.h: Rename include guard.
4792         * tui/tui-file.h: Rename include guard.
4793         * tui/tui-disasm.h: Rename include guard.
4794         * tui/tui-data.h: Rename include guard.
4795         * tui/tui-command.h: Rename include guard.
4796         * tic6x-tdep.h: Add include guard.
4797         * target/waitstatus.h: Rename include guard.
4798         * target/wait.h: Rename include guard.
4799         * target/target.h: Rename include guard.
4800         * target/resume.h: Rename include guard.
4801         * target-float.h: Rename include guard.
4802         * stabsread.h: Add include guard.
4803         * rs6000-tdep.h: Add include guard.
4804         * riscv-fbsd-tdep.h: Add include guard.
4805         * regformats/regdef.h: Rename include guard.
4806         * record.h: Rename include guard.
4807         * python/python.h: Rename include guard.
4808         * python/python-internal.h: Rename include guard.
4809         * python/py-stopevent.h: Rename include guard.
4810         * python/py-ref.h: Rename include guard.
4811         * python/py-record.h: Rename include guard.
4812         * python/py-record-full.h: Rename include guard.
4813         * python/py-record-btrace.h: Rename include guard.
4814         * python/py-instruction.h: Rename include guard.
4815         * python/py-events.h: Rename include guard.
4816         * python/py-event.h: Rename include guard.
4817         * procfs.h: Add include guard.
4818         * proc-utils.h: Add include guard.
4819         * p-lang.h: Add include guard.
4820         * or1k-tdep.h: Rename include guard.
4821         * observable.h: Rename include guard.
4822         * nto-tdep.h: Rename include guard.
4823         * nat/x86-linux.h: Rename include guard.
4824         * nat/x86-linux-dregs.h: Rename include guard.
4825         * nat/x86-gcc-cpuid.h: Add include guard.
4826         * nat/x86-dregs.h: Rename include guard.
4827         * nat/x86-cpuid.h: Rename include guard.
4828         * nat/ppc-linux.h: Rename include guard.
4829         * nat/mips-linux-watch.h: Rename include guard.
4830         * nat/linux-waitpid.h: Rename include guard.
4831         * nat/linux-ptrace.h: Rename include guard.
4832         * nat/linux-procfs.h: Rename include guard.
4833         * nat/linux-osdata.h: Rename include guard.
4834         * nat/linux-nat.h: Rename include guard.
4835         * nat/linux-namespaces.h: Rename include guard.
4836         * nat/linux-btrace.h: Rename include guard.
4837         * nat/glibc_thread_db.h: Rename include guard.
4838         * nat/gdb_thread_db.h: Rename include guard.
4839         * nat/gdb_ptrace.h: Rename include guard.
4840         * nat/fork-inferior.h: Rename include guard.
4841         * nat/amd64-linux-siginfo.h: Rename include guard.
4842         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4843         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4844         * nat/aarch64-linux.h: Rename include guard.
4845         * nat/aarch64-linux-hw-point.h: Rename include guard.
4846         * mn10300-tdep.h: Add include guard.
4847         * mips-linux-tdep.h: Add include guard.
4848         * mi/mi-parse.h: Rename include guard.
4849         * mi/mi-out.h: Rename include guard.
4850         * mi/mi-main.h: Rename include guard.
4851         * mi/mi-interp.h: Rename include guard.
4852         * mi/mi-getopt.h: Rename include guard.
4853         * mi/mi-console.h: Rename include guard.
4854         * mi/mi-common.h: Rename include guard.
4855         * mi/mi-cmds.h: Rename include guard.
4856         * mi/mi-cmd-break.h: Rename include guard.
4857         * m2-lang.h: Add include guard.
4858         * location.h: Rename include guard.
4859         * linux-record.h: Rename include guard.
4860         * linux-nat.h: Add include guard.
4861         * linux-fork.h: Add include guard.
4862         * i386-darwin-tdep.h: Rename include guard.
4863         * hppa-linux-offsets.h: Add include guard.
4864         * guile/guile.h: Rename include guard.
4865         * guile/guile-internal.h: Rename include guard.
4866         * gnu-nat.h: Rename include guard.
4867         * gdb-stabs.h: Rename include guard.
4868         * frv-tdep.h: Add include guard.
4869         * f-lang.h: Add include guard.
4870         * event-loop.h: Add include guard.
4871         * darwin-nat.h: Rename include guard.
4872         * cp-abi.h: Rename include guard.
4873         * config/sparc/nm-sol2.h: Rename include guard.
4874         * config/nm-nto.h: Rename include guard.
4875         * config/nm-linux.h: Add include guard.
4876         * config/i386/nm-i386gnu.h: Rename include guard.
4877         * config/djgpp/nl_types.h: Rename include guard.
4878         * config/djgpp/langinfo.h: Rename include guard.
4879         * compile/gcc-cp-plugin.h: Add include guard.
4880         * compile/gcc-c-plugin.h: Add include guard.
4881         * compile/compile.h: Rename include guard.
4882         * compile/compile-object-run.h: Rename include guard.
4883         * compile/compile-object-load.h: Rename include guard.
4884         * compile/compile-internal.h: Rename include guard.
4885         * compile/compile-cplus.h: Rename include guard.
4886         * compile/compile-c.h: Rename include guard.
4887         * common/xml-utils.h: Rename include guard.
4888         * common/x86-xstate.h: Rename include guard.
4889         * common/version.h: Rename include guard.
4890         * common/vec.h: Rename include guard.
4891         * common/tdesc.h: Rename include guard.
4892         * common/selftest.h: Rename include guard.
4893         * common/scoped_restore.h: Rename include guard.
4894         * common/scoped_mmap.h: Rename include guard.
4895         * common/scoped_fd.h: Rename include guard.
4896         * common/safe-iterator.h: Rename include guard.
4897         * common/run-time-clock.h: Rename include guard.
4898         * common/refcounted-object.h: Rename include guard.
4899         * common/queue.h: Rename include guard.
4900         * common/ptid.h: Rename include guard.
4901         * common/print-utils.h: Rename include guard.
4902         * common/preprocessor.h: Rename include guard.
4903         * common/pathstuff.h: Rename include guard.
4904         * common/observable.h: Rename include guard.
4905         * common/netstuff.h: Rename include guard.
4906         * common/job-control.h: Rename include guard.
4907         * common/host-defs.h: Rename include guard.
4908         * common/gdb_wait.h: Rename include guard.
4909         * common/gdb_vecs.h: Rename include guard.
4910         * common/gdb_unlinker.h: Rename include guard.
4911         * common/gdb_unique_ptr.h: Rename include guard.
4912         * common/gdb_tilde_expand.h: Rename include guard.
4913         * common/gdb_sys_time.h: Rename include guard.
4914         * common/gdb_string_view.h: Rename include guard.
4915         * common/gdb_splay_tree.h: Rename include guard.
4916         * common/gdb_setjmp.h: Rename include guard.
4917         * common/gdb_ref_ptr.h: Rename include guard.
4918         * common/gdb_optional.h: Rename include guard.
4919         * common/gdb_locale.h: Rename include guard.
4920         * common/gdb_assert.h: Rename include guard.
4921         * common/filtered-iterator.h: Rename include guard.
4922         * common/filestuff.h: Rename include guard.
4923         * common/fileio.h: Rename include guard.
4924         * common/environ.h: Rename include guard.
4925         * common/common-utils.h: Rename include guard.
4926         * common/common-types.h: Rename include guard.
4927         * common/common-regcache.h: Rename include guard.
4928         * common/common-inferior.h: Rename include guard.
4929         * common/common-gdbthread.h: Rename include guard.
4930         * common/common-exceptions.h: Rename include guard.
4931         * common/common-defs.h: Rename include guard.
4932         * common/common-debug.h: Rename include guard.
4933         * common/cleanups.h: Rename include guard.
4934         * common/buffer.h: Rename include guard.
4935         * common/btrace-common.h: Rename include guard.
4936         * common/break-common.h: Rename include guard.
4937         * cli/cli-utils.h: Rename include guard.
4938         * cli/cli-style.h: Rename include guard.
4939         * cli/cli-setshow.h: Rename include guard.
4940         * cli/cli-script.h: Rename include guard.
4941         * cli/cli-interp.h: Rename include guard.
4942         * cli/cli-decode.h: Rename include guard.
4943         * cli/cli-cmds.h: Rename include guard.
4944         * charset-list.h: Add include guard.
4945         * buildsym-legacy.h: Rename include guard.
4946         * bfin-tdep.h: Add include guard.
4947         * ax.h: Rename include guard.
4948         * arm-linux-tdep.h: Add include guard.
4949         * arm-fbsd-tdep.h: Add include guard.
4950         * arch/xtensa.h: Rename include guard.
4951         * arch/tic6x.h: Add include guard.
4952         * arch/i386.h: Add include guard.
4953         * arch/arm.h: Rename include guard.
4954         * arch/arm-linux.h: Rename include guard.
4955         * arch/arm-get-next-pcs.h: Rename include guard.
4956         * arch/amd64.h: Add include guard.
4957         * arch/aarch64-insn.h: Rename include guard.
4958         * arch-utils.h: Rename include guard.
4959         * annotate.h: Add include guard.
4960         * amd64-darwin-tdep.h: Rename include guard.
4961         * aarch64-linux-tdep.h: Add include guard.
4962         * aarch64-fbsd-tdep.h: Add include guard.
4963         * aarch32-linux-nat.h: Add include guard.
4964
4965 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4966
4967         * macrotab.c (macro_define_internal): New function that
4968         factorizes macro_define_object_internal and macro_define_function
4969         code.
4970         (macro_define_object_internal): Use macro_define_internal.
4971         (macro_define_function): Likewise.
4972
4973 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4974
4975         * macrocmd.c (extract_identifier): Return
4976         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4977         callers.
4978
4979 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4980
4981         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4982
4983 2019-02-05  Tom Tromey  <tom@tromey.com>
4984
4985         * target.c (target_stack::unpush): Move assertion earlier.
4986
4987 2019-01-30  Tom Tromey  <tom@tromey.com>
4988
4989         PR python/23615:
4990         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4991         (gdbpy_parse_and_eval): Likewise.
4992         * python/python-internal.h (gdbpy_allow_threads): New class.
4993
4994 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4995
4996         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4997         (aarch64_fbsd_fpregmap): Move earlier.
4998         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4999         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5000         instead of individual calls to trad_frame_set_reg_addr.
5001         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5002         earlier.
5003         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5004         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5005         instead of individual calls to trad_frame_set_reg_addr.
5006
5007 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5008
5009         * CONTRIBUTE: Replace contribution list with wiki link.
5010
5011 2019-01-25  Tom Tromey  <tom@tromey.com>
5012
5013         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5014
5015 2019-01-25  Tom Tromey  <tom@tromey.com>
5016
5017         * xtensa-linux-nat.c: Fix common/ includes.
5018         * xml-support.h: Fix common/ includes.
5019         * xml-support.c: Fix common/ includes.
5020         * x86-linux-nat.c: Fix common/ includes.
5021         * windows-nat.c: Fix common/ includes.
5022         * varobj.h: Fix common/ includes.
5023         * varobj.c: Fix common/ includes.
5024         * value.c: Fix common/ includes.
5025         * valops.c: Fix common/ includes.
5026         * utils.c: Fix common/ includes.
5027         * unittests/xml-utils-selftests.c: Fix common/ includes.
5028         * unittests/utils-selftests.c: Fix common/ includes.
5029         * unittests/unpack-selftests.c: Fix common/ includes.
5030         * unittests/tracepoint-selftests.c: Fix common/ includes.
5031         * unittests/style-selftests.c: Fix common/ includes.
5032         * unittests/string_view-selftests.c: Fix common/ includes.
5033         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5034         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5035         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5036         * unittests/rsp-low-selftests.c: Fix common/ includes.
5037         * unittests/parse-connection-spec-selftests.c: Fix common/
5038         includes.
5039         * unittests/optional-selftests.c: Fix common/ includes.
5040         * unittests/offset-type-selftests.c: Fix common/ includes.
5041         * unittests/observable-selftests.c: Fix common/ includes.
5042         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5043         * unittests/memrange-selftests.c: Fix common/ includes.
5044         * unittests/memory-map-selftests.c: Fix common/ includes.
5045         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5046         * unittests/function-view-selftests.c: Fix common/ includes.
5047         * unittests/environ-selftests.c: Fix common/ includes.
5048         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5049         * unittests/common-utils-selftests.c: Fix common/ includes.
5050         * unittests/cli-utils-selftests.c: Fix common/ includes.
5051         * unittests/array-view-selftests.c: Fix common/ includes.
5052         * ui-file.c: Fix common/ includes.
5053         * tui/tui-io.c: Fix common/ includes.
5054         * tracepoint.h: Fix common/ includes.
5055         * tracepoint.c: Fix common/ includes.
5056         * tracefile-tfile.c: Fix common/ includes.
5057         * top.h: Fix common/ includes.
5058         * top.c: Fix common/ includes.
5059         * thread.c: Fix common/ includes.
5060         * target/waitstatus.h: Fix common/ includes.
5061         * target/waitstatus.c: Fix common/ includes.
5062         * target.h: Fix common/ includes.
5063         * target.c: Fix common/ includes.
5064         * target-memory.c: Fix common/ includes.
5065         * target-descriptions.c: Fix common/ includes.
5066         * symtab.h: Fix common/ includes.
5067         * symfile.c: Fix common/ includes.
5068         * stap-probe.c: Fix common/ includes.
5069         * spu-linux-nat.c: Fix common/ includes.
5070         * sparc-nat.c: Fix common/ includes.
5071         * source.c: Fix common/ includes.
5072         * solib.c: Fix common/ includes.
5073         * solib-target.c: Fix common/ includes.
5074         * ser-unix.c: Fix common/ includes.
5075         * ser-tcp.c: Fix common/ includes.
5076         * ser-pipe.c: Fix common/ includes.
5077         * ser-base.c: Fix common/ includes.
5078         * selftest-arch.c: Fix common/ includes.
5079         * s12z-tdep.c: Fix common/ includes.
5080         * rust-exp.y: Fix common/ includes.
5081         * rs6000-aix-tdep.c: Fix common/ includes.
5082         * riscv-tdep.c: Fix common/ includes.
5083         * remote.c: Fix common/ includes.
5084         * remote-notif.h: Fix common/ includes.
5085         * remote-fileio.h: Fix common/ includes.
5086         * remote-fileio.c: Fix common/ includes.
5087         * regcache.h: Fix common/ includes.
5088         * regcache.c: Fix common/ includes.
5089         * record-btrace.c: Fix common/ includes.
5090         * python/python.c: Fix common/ includes.
5091         * python/py-type.c: Fix common/ includes.
5092         * python/py-inferior.c: Fix common/ includes.
5093         * progspace.h: Fix common/ includes.
5094         * producer.c: Fix common/ includes.
5095         * procfs.c: Fix common/ includes.
5096         * proc-api.c: Fix common/ includes.
5097         * printcmd.c: Fix common/ includes.
5098         * ppc-linux-nat.c: Fix common/ includes.
5099         * parser-defs.h: Fix common/ includes.
5100         * osdata.c: Fix common/ includes.
5101         * obsd-nat.c: Fix common/ includes.
5102         * nat/x86-linux.c: Fix common/ includes.
5103         * nat/x86-linux-dregs.c: Fix common/ includes.
5104         * nat/x86-dregs.h: Fix common/ includes.
5105         * nat/x86-dregs.c: Fix common/ includes.
5106         * nat/ppc-linux.c: Fix common/ includes.
5107         * nat/mips-linux-watch.h: Fix common/ includes.
5108         * nat/mips-linux-watch.c: Fix common/ includes.
5109         * nat/linux-waitpid.c: Fix common/ includes.
5110         * nat/linux-ptrace.h: Fix common/ includes.
5111         * nat/linux-ptrace.c: Fix common/ includes.
5112         * nat/linux-procfs.c: Fix common/ includes.
5113         * nat/linux-personality.c: Fix common/ includes.
5114         * nat/linux-osdata.c: Fix common/ includes.
5115         * nat/linux-namespaces.c: Fix common/ includes.
5116         * nat/linux-btrace.h: Fix common/ includes.
5117         * nat/linux-btrace.c: Fix common/ includes.
5118         * nat/fork-inferior.c: Fix common/ includes.
5119         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5120         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5121         * nat/aarch64-linux.c: Fix common/ includes.
5122         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5123         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5124         * namespace.h: Fix common/ includes.
5125         * mips-linux-tdep.c: Fix common/ includes.
5126         * minsyms.c: Fix common/ includes.
5127         * mi/mi-parse.h: Fix common/ includes.
5128         * mi/mi-main.c: Fix common/ includes.
5129         * mi/mi-cmd-env.c: Fix common/ includes.
5130         * memrange.h: Fix common/ includes.
5131         * memattr.c: Fix common/ includes.
5132         * maint.h: Fix common/ includes.
5133         * maint.c: Fix common/ includes.
5134         * main.c: Fix common/ includes.
5135         * machoread.c: Fix common/ includes.
5136         * location.c: Fix common/ includes.
5137         * linux-thread-db.c: Fix common/ includes.
5138         * linux-nat.c: Fix common/ includes.
5139         * linux-fork.c: Fix common/ includes.
5140         * inline-frame.c: Fix common/ includes.
5141         * infrun.c: Fix common/ includes.
5142         * inflow.c: Fix common/ includes.
5143         * inferior.h: Fix common/ includes.
5144         * inferior.c: Fix common/ includes.
5145         * infcmd.c: Fix common/ includes.
5146         * inf-ptrace.c: Fix common/ includes.
5147         * inf-child.c: Fix common/ includes.
5148         * ia64-linux-nat.c: Fix common/ includes.
5149         * i387-tdep.c: Fix common/ includes.
5150         * i386-tdep.c: Fix common/ includes.
5151         * i386-linux-tdep.c: Fix common/ includes.
5152         * i386-linux-nat.c: Fix common/ includes.
5153         * i386-go32-tdep.c: Fix common/ includes.
5154         * i386-fbsd-tdep.c: Fix common/ includes.
5155         * i386-fbsd-nat.c: Fix common/ includes.
5156         * guile/scm-type.c: Fix common/ includes.
5157         * guile/guile.c: Fix common/ includes.
5158         * go32-nat.c: Fix common/ includes.
5159         * gnu-nat.c: Fix common/ includes.
5160         * gdbthread.h: Fix common/ includes.
5161         * gdbarch-selftests.c: Fix common/ includes.
5162         * gdb_usleep.c: Fix common/ includes.
5163         * gdb_select.h: Fix common/ includes.
5164         * gdb_bfd.c: Fix common/ includes.
5165         * gcore.c: Fix common/ includes.
5166         * fork-child.c: Fix common/ includes.
5167         * findvar.c: Fix common/ includes.
5168         * fbsd-nat.c: Fix common/ includes.
5169         * event-top.c: Fix common/ includes.
5170         * event-loop.c: Fix common/ includes.
5171         * dwarf2read.c: Fix common/ includes.
5172         * dwarf2loc.c: Fix common/ includes.
5173         * dwarf2-frame.c: Fix common/ includes.
5174         * dwarf-index-cache.c: Fix common/ includes.
5175         * dtrace-probe.c: Fix common/ includes.
5176         * disasm-selftests.c: Fix common/ includes.
5177         * defs.h: Fix common/ includes.
5178         * csky-tdep.c: Fix common/ includes.
5179         * cp-valprint.c: Fix common/ includes.
5180         * cp-support.h: Fix common/ includes.
5181         * cp-support.c: Fix common/ includes.
5182         * corelow.c: Fix common/ includes.
5183         * completer.h: Fix common/ includes.
5184         * completer.c: Fix common/ includes.
5185         * compile/compile.c: Fix common/ includes.
5186         * compile/compile-loc2c.c: Fix common/ includes.
5187         * compile/compile-cplus-types.c: Fix common/ includes.
5188         * compile/compile-cplus-symbols.c: Fix common/ includes.
5189         * command.h: Fix common/ includes.
5190         * cli/cli-dump.c: Fix common/ includes.
5191         * cli/cli-cmds.c: Fix common/ includes.
5192         * charset.c: Fix common/ includes.
5193         * build-id.c: Fix common/ includes.
5194         * btrace.h: Fix common/ includes.
5195         * btrace.c: Fix common/ includes.
5196         * breakpoint.h: Fix common/ includes.
5197         * breakpoint.c: Fix common/ includes.
5198         * ax.h:
5199         (enum agent_op): Fix common/ includes.
5200         * ax-general.c (struct aop_map): Fix common/ includes.
5201         * ax-gdb.c: Fix common/ includes.
5202         * auxv.c: Fix common/ includes.
5203         * auto-load.c: Fix common/ includes.
5204         * arm-tdep.c: Fix common/ includes.
5205         * arch/riscv.c: Fix common/ includes.
5206         * arch/ppc-linux-common.c: Fix common/ includes.
5207         * arch/i386.c: Fix common/ includes.
5208         * arch/arm.c: Fix common/ includes.
5209         * arch/arm-linux.c: Fix common/ includes.
5210         * arch/arm-get-next-pcs.c: Fix common/ includes.
5211         * arch/amd64.c: Fix common/ includes.
5212         * arch/aarch64.c: Fix common/ includes.
5213         * arch/aarch64-insn.c: Fix common/ includes.
5214         * arch-utils.c: Fix common/ includes.
5215         * amd64-windows-tdep.c: Fix common/ includes.
5216         * amd64-tdep.c: Fix common/ includes.
5217         * amd64-sol2-tdep.c: Fix common/ includes.
5218         * amd64-obsd-tdep.c: Fix common/ includes.
5219         * amd64-nbsd-tdep.c: Fix common/ includes.
5220         * amd64-linux-tdep.c: Fix common/ includes.
5221         * amd64-linux-nat.c: Fix common/ includes.
5222         * amd64-fbsd-tdep.c: Fix common/ includes.
5223         * amd64-fbsd-nat.c: Fix common/ includes.
5224         * amd64-dicos-tdep.c: Fix common/ includes.
5225         * amd64-darwin-tdep.c: Fix common/ includes.
5226         * agent.c: Fix common/ includes.
5227         * ada-lang.h: Fix common/ includes.
5228         * ada-lang.c: Fix common/ includes.
5229         * aarch64-tdep.c: Fix common/ includes.
5230
5231 2019-01-25  Tom Tromey  <tom@tromey.com>
5232
5233         * common/create-version.sh: Use common/version.h.
5234
5235 2019-01-24  Pedro Alves  <palves@redhat.com>
5236
5237         * infrun.c (signal_stop, signal_print, signal_program)
5238         (signal_catch, signal_pass): Now arrays instead of pointers.
5239         (update_signals_program_target, do_target_resume)
5240         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5241         * linux-nat.c (linux_nat_target::pass_signals)
5242         (linux_nat_target::create_inferior, linux_nat_target::attach):
5243         Adjust.
5244         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5245         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5246         * procfs.c (procfs_target::pass_signals): Adjust.
5247         * record-full.c (record_full_target::resume): Adjust.
5248         * remote.c (remote_target::pass_signals)
5249         (remote_target::program_signals): Adjust.
5250         * target-debug.h (target_debug_print_signals): Now takes a
5251         gdb::array_view as parameter.  Adjust.
5252         * target.h (target_ops) <pass_signals, program_signals>: Replace
5253         pointer and length parameters with gdb::array_view.
5254         (target_pass_signals, target_program_signals): Likewise.
5255         * target-delegates.c: Regenerate.
5256
5257 2019-01-24  Pedro Alves  <palves@redhat.com>
5258
5259         * common/forward-scope-exit.h
5260         (forward_scope_exit::forward_scope_exit): Pass arguments to
5261         m_bind_function directly, instead of creating a std::bind and
5262         copying that.
5263
5264 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5265
5266         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5267         for static members.
5268         (pass_in_v_vfp_candidate): Likewise.
5269
5270 2019-01-23  Tom Tromey  <tom@tromey.com>
5271             Pedro Alves  <palves@redhat.com>
5272
5273         * regcache.c (class regcache_invalidator): Remove.
5274         (regcache::raw_write): Use make_scope_exit.
5275
5276 2019-01-23  Tom Tromey  <tom@tromey.com>
5277
5278         * ui-out.h (class ui_out_emit_type): Update comment.
5279
5280 2019-01-23  Tom Tromey  <tom@tromey.com>
5281
5282         * infrun.c (fetch_inferior_event): Update comment.
5283
5284 2019-01-23  Tom Tromey  <tom@tromey.com>
5285             Pedro Alves  <palves@redhat.com>
5286
5287         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5288         parameter.
5289         (fetch_inferior_event): Use SCOPE_EXIT.
5290
5291
5292 2019-01-23  Tom Tromey  <tom@tromey.com>
5293             Pedro Alves  <palves@redhat.com>
5294
5295         * infrun.c (disable_thread_events): Delete.
5296         (stop_all_threads): Use SCOPE_EXIT.
5297
5298 2019-01-23  Tom Tromey  <tom@tromey.com>
5299             Pedro Alves  <palves@redhat.com>
5300
5301         * symfile.c: Include forward-scope-exit.h.
5302         (clear_symtab_users_cleanup): Replace forward declaration with
5303         a FORWARD_SCOPE_EXIT.
5304         (syms_from_objfile_1): Use the forward_scope_exit and
5305         gdb::optional instead of cleanup_function.
5306         (reread_symbols): Use the forward_scope_exit instead of
5307         cleanup_function.
5308         (clear_symtab_users_cleanup): Remove function.
5309
5310 2019-01-23  Tom Tromey  <tom@tromey.com>
5311             Pedro Alves  <palves@redhat.com>
5312
5313         * linux-nat.c: Include scope-exit.h.
5314         (cleanup_target_stop): Remove.
5315         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5316         SCOPE_EXIT.
5317
5318 2019-01-23  Tom Tromey  <tom@tromey.com>
5319             Pedro Alves  <palves@redhat.com>
5320
5321         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5322         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5323
5324 2019-01-23  Tom Tromey  <tom@tromey.com>
5325             Andrew Burgess  <andrew.burgess@embecosm.com>
5326             Pedro Alves  <palves@redhat.com>
5327
5328         * infrun.c (fetch_inferior_event): Use scope_exit.
5329         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5330         * top.c (execute_command): Use scope_exit.
5331         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5332         * utils.c (do_bpstat_clear_actions_cleanup)
5333         (make_bpstat_clear_actions_cleanup): Remove.
5334
5335 2019-01-23  Tom Tromey  <tom@tromey.com>
5336             Pedro Alves  <palves@redhat.com>
5337
5338         * infrun.c: Include "common/scope-exit.h"
5339         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5340         (wait_for_inferior): Use SCOPE_EXIT.
5341         (fetch_inferior_event): Use scope_exit.
5342
5343 2019-01-23  Tom Tromey  <tom@tromey.com>
5344             Pedro Alves  <palves@redhat.com>
5345
5346         * breakpoint.c (create_breakpoint): Remove cleanup.
5347
5348 2019-01-23  Tom Tromey  <tom@tromey.com>
5349             Andrew Burgess  <andrew.burgess@embecosm.com>
5350             Pedro Alves  <palves@redhat.com>
5351
5352 2019-01-23  Pedro Alves  <palves@redhat.com>
5353
5354         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5355
5356 2019-01-23  Pedro Alves  <palves@redhat.com>
5357             Andrew Burgess  <andrew.burgess@embecosm.com>
5358
5359         * gdbthread.h: Include "common/forward-scope-exit.h".
5360         (scoped_finish_thread_state): Redefine custom class in terms of
5361         forward_scope_exit.
5362
5363 2019-01-23  Pedro Alves  <palves@redhat.com>
5364             Andrew Burgess  <andrew.burgess@embecosm.com>
5365
5366         * common/forward-scope-exit.h: New file.
5367
5368 2019-01-23  Pedro Alves  <palves@redhat.com>
5369             Andrew Burgess  <andrew.burgess@embecosm.com>
5370             Tom Tromey  <tom@tromey.com>
5371
5372         * common/scope-exit.h: New file.
5373
5374 2019-01-23  Pedro Alves  <palves@redhat.com>
5375
5376         * common/preprocessor.h (ESC): Rename to ...
5377         (ESC_PARENS): ... this.
5378         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5379         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5380
5381 2019-01-23  Tom Tromey  <tom@tromey.com>
5382
5383         * language.h (class scoped_switch_to_sym_language_if_auto):
5384         Initialize m_lang in both cases.
5385
5386 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5387
5388         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5389         with XCNEW.
5390
5391 2019-01-22  Tom Tromey  <tom@tromey.com>
5392
5393         * corelow.c: Do not include sys/file.h.
5394
5395 2019-01-22  Tom Tromey  <tom@tromey.com>
5396
5397         * tui/tui-wingeneral.h: Include gdb_curses.h.
5398
5399 2019-01-22  Tom Tromey  <tom@tromey.com>
5400
5401         * source-cache.h (class source_cache) <get_source_lines,
5402         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5403
5404 2019-01-22  Tom Tromey  <tom@tromey.com>
5405
5406         * remote-fileio.h (struct remote_target): Declare.
5407
5408 2019-01-22  Tom Tromey  <tom@tromey.com>
5409
5410         * python/py-arch.c: Do not include py-ref.h.
5411         * python/py-bpevent.c: Do not include py-ref.h.
5412         * python/py-cmd.c: Do not include py-ref.h.
5413         * python/py-continueevent.c: Do not include py-ref.h.
5414         * python/py-event.h: Do not include py-ref.h.
5415         * python/py-evtregistry.c: Do not include py-ref.h.
5416         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5417         * python/py-frame.c: Do not include py-ref.h.
5418         * python/py-framefilter.c: Do not include py-ref.h.
5419         * python/py-function.c: Do not include py-ref.h.
5420         * python/py-infevents.c: Do not include py-ref.h.
5421         * python/py-linetable.c: Do not include py-ref.h.
5422         * python/py-objfile.c: Do not include py-ref.h.
5423         * python/py-param.c: Do not include py-ref.h.
5424         * python/py-prettyprint.c: Do not include py-ref.h.
5425         * python/py-progspace.c: Do not include py-ref.h.
5426         * python/py-symbol.c: Do not include py-ref.h.
5427         * python/py-symtab.c: Do not include py-ref.h.
5428         * python/py-type.c: Do not include py-ref.h.
5429         * python/py-unwind.c: Do not include py-ref.h.
5430         * python/py-utils.c: Do not include py-ref.h.
5431         * python/py-value.c: Do not include py-ref.h.
5432         * python/py-varobj.c: Do not include py-ref.h.
5433         * python/py-xmethods.c: Do not include py-ref.h.
5434         * python/python.c: Do not include py-ref.h.
5435         * varobj.c: Do not include py-ref.h.
5436
5437 2019-01-22  Tom Tromey  <tom@tromey.com>
5438
5439         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5440         keyword for bcache.
5441
5442 2019-01-22  Tom Tromey  <tom@tromey.com>
5443
5444         * compile/compile-cplus-types.c: Remove a comment by #include.
5445
5446 2019-01-22  Tom Tromey  <tom@tromey.com>
5447
5448         * compile/gcc-c-plugin.h: Include compile-internal.h.
5449
5450 2019-01-22  Tom Tromey  <tom@tromey.com>
5451
5452         * stabsread.c (EXTERN): Do not define.
5453         (symnum, next_symbol_text_func, processing_gcc_compilation)
5454         (within_function, global_sym_chain, global_stabs)
5455         (previous_stab_code, this_object_header_files)
5456         (n_this_object_header_files)
5457         (n_allocated_this_object_header_files): Define.
5458         * stabsread.h (EXTERN): Never define.  Use "extern".
5459
5460 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5461
5462         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5463         history_value.
5464
5465 2019-01-21  Tom Tromey  <tom@tromey.com>
5466
5467         * ui-out.c: Fix includes.
5468         * tui/tui-source.c: Fix includes.
5469         * target.c: Fix includes.
5470         * remote.c: Fix includes.
5471         * regcache.c: Fix includes.
5472         * python/py-block.c: Fix includes.
5473         * printcmd.c: Fix includes.
5474         * or1k-tdep.c: Fix includes.
5475         * mi/mi-main.c: Fix includes.
5476         * m32r-tdep.c: Fix includes.
5477         * csky-tdep.c: Fix includes.
5478         * compile/compile-cplus-types.c: Fix includes.
5479         * cli/cli-interp.c: Fix includes.
5480
5481 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5482
5483         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5484         for padding.
5485
5486 2019-01-16  Tom Tromey  <tom@tromey.com>
5487
5488         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5489         earlier.
5490         (struct objfile) <msymbols_range>: Move from top level.
5491         <msymbols>: New method.
5492         (class objfile_msymbols): Remove.
5493         * symtab.c (default_collect_symbol_completion_matches_break_on):
5494         Update.
5495         * symmisc.c (dump_msymbols): Update.
5496         * stabsread.c (scan_file_globals): Update.
5497         * objc-lang.c (info_selectors_command, info_classes_command)
5498         (find_methods): Update.
5499         * minsyms.c (find_solib_trampoline_target): Update.
5500         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5501         * coffread.c (coff_symfile_read): Update.
5502         * ada-lang.c (ada_lookup_simple_minsym)
5503         (ada_collect_symbol_completion_matches): Update.
5504
5505 2019-01-16  Tom Tromey  <tom@tromey.com>
5506
5507         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5508         type.  Remove no-argument constructor.
5509         <iterator::operator++>: Simplify.
5510         <begin>: Update.
5511         <end>: Use minimal_symbol_count.
5512
5513 2019-01-16  Tom Tromey  <tom@tromey.com>
5514
5515         * objfiles.h (struct objfile) <psymtabs>: New method.
5516         (class objfile_psymtabs): Remove.
5517         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5518         typedef.
5519         <range>: New method.
5520         (require_partial_symbols): Change return type.
5521         * psymtab.c (require_partial_symbols)
5522         (psym_expand_symtabs_matching): Update.
5523         * mdebugread.c (parse_partial_symbols): Update.
5524         * dbxread.c (dbx_end_psymtab): Update.
5525
5526 2019-01-15  Tom Tromey  <tom@tromey.com>
5527
5528         * symtab.c (lookup_objfile_from_block)
5529         (lookup_symbol_in_objfile_symtabs)
5530         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5531         (find_line_symtab, info_sources_command)
5532         (default_collect_symbol_completion_matches_break_on)
5533         (make_source_files_completion_list): Update.
5534         * symmisc.c (print_objfile_statistics, dump_objfile)
5535         (maintenance_print_symbols, maintenance_info_symtabs)
5536         (maintenance_check_symtabs, maintenance_info_line_tables):
5537         Update.
5538         * source.c (select_source_symtab)
5539         (forget_cached_source_info_for_objfile): Update.
5540         * objfiles.h (class objfile_compunits): Remove.
5541         (struct objfile) <compunits_range>: New typedef.
5542         (compunits): New method.
5543         * objfiles.c (objfile_relocate1): Update.
5544         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5545         * maint.c (count_symtabs_and_blocks): Update.
5546         * linespec.c (iterate_over_all_matching_symtabs): Update.
5547         * cp-support.c (add_symbol_overload_list_qualified): Update.
5548         * coffread.c (coff_symtab_read): Update.
5549         * ada-lang.c (add_nonlocal_symbols)
5550         (ada_collect_symbol_completion_matches)
5551         (ada_add_global_exceptions): Update.
5552
5553 2019-01-15  Tom Tromey  <tom@tromey.com>
5554
5555         * progspace.h (program_space) <objfiles_safe_range>: New
5556         typedef.
5557         <objfiles_safe>: New method.
5558         * objfiles.h (class all_objfiles_safe): Remove.
5559         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5560         * jit.c (jit_inferior_exit_hook): Update.
5561
5562 2019-01-17  Tom Tromey  <tom@tromey.com>
5563
5564         * progspace.h (program_space) <objfiles_range>: New typedef.
5565         <objfiles>: New method.
5566         <objfiles_head>: Rename from objfiles.
5567         (object_files): Update.
5568         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5569         * guile/scm-pretty-print.c
5570         (ppscm_find_pretty_printer_from_objfiles): Update.
5571         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5572         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5573         Update.
5574         * python/py-progspace.c (pspy_get_objfiles): Update.
5575         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5576         Update.
5577         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5578         (objfpy_lookup_objfile_by_build_id): Update.
5579         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5580         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5581         Update.
5582         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5583         (expand_symtab_containing_pc, lookup_objfile_from_block)
5584         (lookup_static_symbol, basic_lookup_transparent_type)
5585         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5586         (find_line_symtab, info_sources_command)
5587         (default_collect_symbol_completion_matches_break_on)
5588         (make_source_files_completion_list, find_main_name): Update.
5589         * symmisc.c (print_symbol_bcache_statistics)
5590         (print_objfile_statistics, maintenance_print_symbols)
5591         (maintenance_print_msymbols, maintenance_print_objfiles)
5592         (maintenance_info_symtabs, maintenance_check_symtabs)
5593         (maintenance_expand_symtabs, maintenance_info_line_tables):
5594         Update.
5595         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5596         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5597         (map_overlay_command, unmap_overlay_command)
5598         (simple_overlay_update, expand_symtabs_matching)
5599         (map_symbol_filenames): Update.
5600         * symfile-debug.c (set_debug_symfile): Update.
5601         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5602         Update.
5603         * source.c (select_source_symtab, forget_cached_source_info):
5604         Update.
5605         * solib.c (solib_read_symbols): Update.
5606         * solib-spu.c (append_ocl_sos): Update.
5607         * psymtab.c (maintenance_print_psymbols)
5608         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5609         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5610         * printcmd.c (info_symbol_command): Update.
5611         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5612         Update.
5613         * objfiles.h (class all_objfiles): Remove.
5614         * objfiles.c (have_partial_symbols, have_full_symbols)
5615         (have_minimal_symbols, qsort_cmp, update_section_map)
5616         (shared_objfile_contains_address_p)
5617         (default_iterate_over_objfiles_in_search_order): Update.
5618         * objc-lang.c (info_selectors_command, info_classes_command)
5619         (find_methods): Update.
5620         * minsyms.c (find_solib_trampoline_target): Update.
5621         * maint.c (maintenance_info_sections)
5622         (maintenance_translate_address, count_symtabs_and_blocks):
5623         Update.
5624         * main.c (captured_main_1): Update.
5625         * linux-thread-db.c (try_thread_db_load_from_pdir)
5626         (has_libpthread): Update.
5627         * linespec.c (iterate_over_all_matching_symtabs)
5628         (search_minsyms_for_name): Update.
5629         * jit.c (jit_find_objf_with_entry_addr): Update.
5630         * hppa-tdep.c (find_unwind_entry)
5631         (hppa_lookup_stub_minimal_symbol): Update.
5632         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5633         Update.
5634         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5635         (elf_gnu_ifunc_resolve_by_got): Update.
5636         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5637         * dwarf-index-write.c (save_gdb_index_command): Update.
5638         * cp-support.c (add_symbol_overload_list_qualified): Update.
5639         * breakpoint.c (create_overlay_event_breakpoint)
5640         (create_longjmp_master_breakpoint)
5641         (create_std_terminate_master_breakpoint)
5642         (create_exception_master_breakpoint): Update.
5643         * blockframe.c (find_pc_partial_function): Update.
5644         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5645         (ada_collect_symbol_completion_matches)
5646         (ada_add_global_exceptions): Update.
5647
5648 2019-01-17  Tom Tromey  <tom@tromey.com>
5649
5650         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5651         declare VEC.
5652         (solib_target_parse_libraries): Change return type.
5653         (library_list_start_segment, library_list_start_section)
5654         (library_list_end_library, library_list_start_library); Update.
5655         (solib_target_free_library_list): Remove.
5656         (solib_target_parse_libraries): Remove cleanup.  Change return
5657         type.
5658         (solib_target_current_sos): Update.
5659
5660 2019-01-17  Tom Tromey  <tromey@bapiya>
5661
5662         * valprint.c: Replace "the the" with "the".
5663         * symtab.c: Replace "the the" with "the".
5664         * solib.c: Replace "the the" with "the".
5665         * solib-dsbt.c: Replace "the the" with "the".
5666         * linespec.c: Replace "the the" with "the".
5667         * dwarf2loc.h: Replace "the the" with "the".
5668         * amd64-windows-tdep.c: Replace "the the" with "the".
5669         * aarch64-tdep.c: Replace "the the" with "the".
5670
5671 2019-01-16  Keith Seitz  <keiths@redhat.com>
5672
5673         PR gdb/23773
5674         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5675         <builder>: Rename to ..
5676         <m_builder>: ... this and make private.
5677         (dwarf2_cu::get_builder): New method.  Change all users of
5678         `builder' to use this method.
5679         (dwarf2_start_symtab): Move to ...
5680         (dwarf2_cu::start_symtab): ... here.  Update all callers
5681         (setup_type_unit_groups): Move to ...
5682         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5683         callers.
5684         (dwarf2_cu::reset_builder): New method.
5685         (process_full_compunit, process_full_type_unit): Use
5686         dwarf2_cu::reset_builder.
5687         (follow_die_offset): Record the ancestor CU if it is different
5688         from the followed DIE's CU.
5689         (follow_die_sig_1): Likewise.
5690
5691 2019-01-15  Tom Tromey  <tom@tromey.com>
5692
5693         * remote.c (class remote_state) <buf>: Now a char_vector.
5694         <buf_size>: Remove.
5695         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5696         parameter.
5697         (remote_target::getpkt_or_notif_sane_1)
5698         (remote_target::getpkt_sane)
5699         (remote_target::getpkt_or_notif_sane): Likewise.
5700         (class remote_target) <putpkt>: New overload.
5701         (remote_target::read_frame): Change type of "buf_p".  Remove
5702         sizeof_p parameter.
5703         (packet_ok): New overload.
5704         (packet_check_result): New overload.
5705         Update all uses.
5706
5707 2019-01-14  Tom Tromey  <tom@tromey.com>
5708
5709         * remote-notif.c (handle_notification, remote_notif_ack)
5710         (remote_notif_parse): Make "buf" const.
5711         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5712         const.
5713         (remote_notif_parse, remote_notif_ack, handle_notification):
5714         Likewise.
5715         * remote.c (remote_notif_stop_parse): Make "buf" const.
5716         (remote_target::remote_parse_stop_reply): Make "buf" const.
5717         (remote_notif_stop_ack): Make "buf" const.
5718
5719 2019-01-14  Tom Tromey  <tom@tromey.com>
5720
5721         * remote.c (remote_console_output): Make parameter const.
5722
5723 2019-01-14  Tom Tromey  <tom@tromey.com>
5724
5725         * target-debug.h (target_debug_print_signals): Constify.
5726         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5727         * procfs.c (procfs_target::pass_signals): Update.
5728         * linux-nat.c (linux_nat_target::pass_signals): Update.
5729         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5730         * target-delegates.c: Rebuild.
5731         * remote.c (remote_target::program_signals): Update.
5732         (remote_target::pass_signals): Update.
5733         * target.c (target_pass_signals): Constify argument.
5734         (target_program_signals): Likewise.
5735         * target.h (struct target_ops) <pass_signals, program_signals>:
5736         Constify argument.
5737         (target_pass_signals, target_program_signals): Constify argument.
5738
5739 2019-01-14  Tom Tromey  <tom@tromey.com>
5740
5741         PR tui/28819:
5742         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5743
5744 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5745
5746         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5747         field.
5748         * rs6000-tdep.c: Include reggroups.h.
5749         (IS_V_ALIAS_PSEUDOREG): Define.
5750         (rs6000_register_name): Return names for the "vX" aliases.
5751         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5752         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5753         aliases.  Call default_register_reggroup_p for all other
5754         pseudo-registers.
5755         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5756         New functions.
5757         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5758         Handle "vX" aliases.
5759         (v_alias_pseudo_register_collect): New function.
5760         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5761         (rs6000_gdbarch_init): Initialize "vX" aliases as
5762         pseudo-registers.  Restore registration of
5763         rs6000_pseudo_register_reggroup_p with
5764         set_tdesc_pseudo_register_reggroup_p.
5765
5766 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5767
5768         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5769         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5770         set_gdbarch_num_pseudo_regs.
5771
5772 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5773
5774         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5775         Remove arg prefixname, add do_set and do_show.
5776         Add member functions set_list and show_list.
5777         * cli/cli-style.c (class cli_style_option): Update accordingly.
5778         (style_set_list): Move to file scope.
5779         (style_show_list): Likewise.
5780         (set_style): Call help_list.
5781         (show_style): Call cmd_show_list.
5782         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5783         Update to use the new macro.
5784
5785 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5786
5787         * ada-lang.c (_initialize_ada_language): Expand the help text
5788         for the "catch exception" command.
5789
5790 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5791
5792         * symtab.c (matching_obj_sections): Initialize obj,
5793         declare it closer to its usage.
5794
5795 2019-01-10  Tom Tromey  <tom@tromey.com>
5796
5797         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5798         (basic_inf_threads_range): Remove.
5799         (inf_threads_range, inf_non_exited_threads_range)
5800         (safe_inf_threads_range): Use next_adapter.
5801
5802 2019-01-10  Keith Seitz  <keiths@redhat.com>
5803
5804         PR gdb/23712
5805         PR symtab/23010
5806         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5807         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5808
5809 2019-01-10  Keith Seitz  <keiths@redhat.com>
5810
5811         PR gdb/23712
5812         PR symtab/23010
5813         * dictionary.c (pending_to_vector): Remove.
5814         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5815         Remove _1 suffix, replacing functions of the same name.  Update
5816         all callers.
5817         (dict_create_hashed, dict_create_hashed_expandable)
5818         (dict_create_linear, dict_create_linear_expandable, dict_free)
5819         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5820         Make functions static.
5821
5822 2019-01-10  Keith Seitz  <keiths@redhat.com>
5823
5824         PR gdb/23712
5825         PR symtab/23010
5826         * dictionary.h (struct dictionary): Replace declaration with
5827         multidictionary.
5828         (dict_create_hashed, dict_create_hashed_expandable)
5829         (dict_create_linear, dict_create_linear_expandable)
5830         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5831         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5832         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5833         taking multidictionary argument.
5834         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5835         * block.h (struct block) <dict>: Change to multidictionary
5836         and rename `multidict'.
5837         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5838         symmisc.c: Update all dictionary references to multidictionary.
5839
5840 2019-01-10  Keith Seitz  <keiths@redhat.com>
5841
5842         PR gdb/23712
5843         PR symtab/23010
5844         * dictionary.c: Include unordered_map.
5845         (pending_to_vector): New function.
5846         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5847         Rewrite the non-"_1" functions to take vector instead
5848         of linked list.
5849         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5850         "new" _1 versions of the same name.
5851         (multidictionary): Define.
5852         (std::hash<enum language): New definition.
5853         (collate_pending_symbols_by_language, mdict_create_hashed)
5854         (mdict_create_hashed_expandable, mdict_create_linear)
5855         (mdict_create_linear_expandable, mdict_free)
5856         (find_language_dictionary, create_new_language_dictionary)
5857         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5858         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5859         (mdict_size, mdict_empty): New functions.
5860         * dictionary.h (mdict_iterator): Define.
5861
5862 2019-01-10  Pedro Alves  <palves@redhat.com>
5863
5864         * breakpoint.c (read_uploaded_action)
5865         (create_tracepoint_from_upload): Adjust to use
5866         gdb::unique_xmalloc_ptr.
5867         * ctf.c (ctf_write_uploaded_tp):
5868         (SET_ARRAY_FIELD): Use emplace_back.
5869         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5870         * tracefile-tfile.c (tfile_write_uploaded_tp):
5871         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5872         gdb::unique_xmalloc_ptr.
5873         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5874         at_string, cond_string, cmd_strings>: Replace char pointers
5875         with gdb::unique_xmalloc_ptr.
5876
5877 2019-01-10  Pedro Alves  <palves@redhat.com>
5878
5879         * solib-target.c (library_list_start_library): Don't xstrdup name.
5880
5881 2019-01-10  Pedro Alves  <palves@redhat.com>
5882
5883         * mdebugread.c (parse_partial_symbols): Use
5884         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5885
5886 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5887
5888         * linux-fork.c (scoped_switch_fork_info)
5889         <~scoped_switch_fork_info>: Fix incorrect variable name.
5890
5891 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5892
5893         * linux-fork.c (scoped_switch_fork_info)
5894         <scoped_switch_fork_info>: Make explicit.
5895         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5896
5897 2019-01-10  Tom Tromey  <tom@tromey.com>
5898
5899         * objfiles.h (objfile::reset_psymtabs): Update.
5900         * objfiles.c (objfile::objfile): Update.
5901         * psymtab.h (psymtab_storage::obstack): Update.
5902         (psymtab_storage::m_obstack): Use gdb::optional.
5903         (class psymtab_storage): Update comment.  Remove objfile
5904         parameter.
5905         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5906
5907 2019-01-10  Tom Tromey  <tom@tromey.com>
5908
5909         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5910         <free_psymtabs>: Now private.
5911         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5912         (allocate_psymtab): Use new method.
5913
5914 2019-01-10  Tom Tromey  <tom@tromey.com>
5915
5916         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5917         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5918         * mdebugread.c (parse_partial_symbols): Use
5919         allocate_dependencies.
5920         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5921         allocate_dependencies.
5922         (process_psymtab_comp_unit_reader)
5923         (build_type_psymtab_dependencies): Likewise.
5924         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5925
5926 2019-01-10  Tom Tromey  <tom@tromey.com>
5927
5928         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5929         PSYMBOL_SET_LANGUAGE.
5930         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5931
5932 2019-01-10  Tom Tromey  <tom@tromey.com>
5933
5934         * psymtab.h (psymtab_storage::obstack): New method.
5935         <m_obstack>: Rename from obstack; now private.
5936         * psymtab.c (psymtab_storage): Update.
5937         * dwarf2read.c (create_addrmap_from_index)
5938         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5939         Update.
5940
5941 2019-01-10  Tom Tromey  <tom@tromey.com>
5942
5943         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5944         * objfiles.h (objfile::reset_psymtabs): New method.
5945
5946 2019-01-10  Tom Tromey  <tom@tromey.com>
5947
5948         * symmisc.c (print_symbol_bcache_statistics): Update.
5949         (print_objfile_statistics): Update.
5950         * symfile.c (reread_symbols): Update.
5951         * psymtab.h (class psymtab_storage): New.
5952         * psymtab.c (psymtab_storage): New constructor.
5953         (~psymtab_storage): New destructor.
5954         (require_partial_symbols): Update.
5955         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5956         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5957         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5958         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5959         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5960         (start_psymtab_common, end_psymtab_common)
5961         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5962         (allocate_psymtab): Update.
5963         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5964         Update.
5965         (dump_psymtab_addrmap, maintenance_print_psymbols)
5966         (maintenance_check_psymtabs): Update.
5967         (class objfile_psymtabs): Move to objfiles.h.
5968         * psympriv.h (discard_psymtab): Now inline.
5969         (psymtab_discarder::psymtab_discarder): Update.
5970         (psymtab_discarder::~psymtab_discarder): Update.
5971         (ALL_OBJFILE_PSYMTABS): Rewrite.
5972         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5973         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5974         Remove fields.
5975         <partial_symtabs>: New field.
5976         (class objfile_psymtabs): Move from psymtab.h.  Update.
5977         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5978         psymbol_cache.
5979         (objfile::~objfile): Don't destroy psymbol_cache.
5980         * mdebugread.c (parse_partial_symbols): Update.
5981         * dwarf2read.c (create_addrmap_from_index)
5982         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5983         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5984         (add_partial_subprogram, dwarf2_ranges_read): Update.
5985         * dwarf-index-write.c (write_address_map)
5986         (write_one_signatured_type, recursively_write_psymbols)
5987         (class debug_names, class debug_names, write_psymtabs_to_index):
5988         Update.
5989
5990 2019-01-10  Tom Tromey  <tom@tromey.com>
5991
5992         * symtab.h (SYMBOL_SET_NAMES): Update.
5993         (symbol_set_names): Update.
5994         (MSYMBOL_SET_NAMES): Update.
5995         * symtab.c (symbol_set_names): Change argument to be an
5996         objfile_per_bfd_storage.
5997         * psymtab.c (add_psymbol_to_bcache): Update.
5998         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5999
6000 2019-01-10  Tom Tromey  <tom@tromey.com>
6001
6002         * symtab.c (create_demangled_names_hash): Change argument to be an
6003         objfile_per_bfd_storage.
6004         (symbol_set_names): Update.
6005
6006 2019-01-10  Tom Tromey  <tom@tromey.com>
6007
6008         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6009         init_psymbol_list.
6010         * psymtab.c (init_psymbol_list): Do nothing if already called.
6011         * psympriv.h (init_psymbol_list): Add comment.
6012         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6013         init_psymbol_list.
6014         * dbxread.c (dbx_symfile_read): Unconditionally call
6015         init_psymbol_list.
6016
6017 2019-01-10  Tom Tromey  <tom@tromey.com>
6018
6019         * xcoffread.c (scan_xcoff_symtab): Update.
6020         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6021         "where".
6022         * mdebugread.c (parse_partial_symbols)
6023         (handle_psymbol_enumerators): Update.
6024         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6025         * dbxread.c (read_dbx_symtab): Update.
6026         * psympriv.h (psymbol_placement): New enum.
6027         (add_psymbol_to_list): Update.
6028
6029 2019-01-10  Tom Tromey  <tom@tromey.com>
6030
6031         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6032         static_psymbols parameters.
6033         (scan_xcoff_symtab): Update.
6034         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6035         static_psymbols parameters.
6036         * psympriv.h (start_psymtab_common): Update.
6037         * mdebugread.c (parse_partial_symbols): Update.
6038         * dwarf2read.c (create_partial_symtab): Update.
6039         * dbxread.c (read_dbx_symtab): Update.
6040         (start_psymtab): Remove global_psymbols and static_psymbols
6041         parameters.
6042
6043 2019-01-10  Tom Tromey  <tom@tromey.com>
6044
6045         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6046         * psymtab.c (allocate_psymtab): Add comment.
6047         * psympriv.h (allocate_psymtab): Add comment.
6048         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6049         initializations.
6050         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6051
6052 2019-01-10  Tom Tromey  <tom@tromey.com>
6053
6054         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6055         Don't declare.
6056         * mipsread.c: Include mdebugread.h.
6057         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6058         Declare.
6059         * elfread.c: Include mdebugread.h.
6060
6061 2019-01-09  Tom Tromey  <tom@tromey.com>
6062
6063         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6064         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6065         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6066         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6067         (psym_lookup_symbol, psym_find_last_source_symtab)
6068         (psym_forget_cached_source_info, psym_print_stats)
6069         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6070         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6071         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6072         (psym_find_compunit_symtab_by_address)
6073         (maintenance_print_psymbols, maintenance_info_psymtabs)
6074         (maintenance_check_psymtabs): Use ranged for.
6075         * psymtab.h (class objfile_psymtabs): New.
6076         (require_partial_symbols): Return objfile_psymtabs.
6077         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6078
6079 2019-01-09  Tom Tromey  <tom@tromey.com>
6080
6081         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6082         (find_pc_mapped_section, list_overlays_command)
6083         (map_overlay_command, unmap_overlay_command)
6084         (simple_overlay_update): Use all_objfiles.
6085         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6086         * printcmd.c (info_symbol_command): Use all_objfiles.
6087         * objfiles.h (ALL_OBJSECTIONS): Remove.
6088         * maint.c (maintenance_translate_address): Use all_objfiles.
6089         * gcore.c (gcore_create_callback): Use all_objfiles.
6090         (objfile_find_memory_regions): Likewise.
6091
6092 2019-01-09  Tom Tromey  <tom@tromey.com>
6093
6094         * symtab.c (find_line_symtab, info_sources_command)
6095         (make_source_files_completion_list): Use objfile_compunits.
6096         * source.c (select_source_symtab): Use objfile_compunits.
6097         * objfiles.h (struct objfile): Update comment.
6098         (ALL_OBJFILES): Remove.
6099         (ALL_FILETABS): Remove.
6100         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6101         objfile_compunits.
6102
6103 2019-01-09  Tom Tromey  <tom@tromey.com>
6104
6105         * symmisc.c (print_objfile_statistics, dump_objfile)
6106         (maintenance_print_symbols): Use compunit_filetabs.
6107         * source.c (forget_cached_source_info_for_objfile): Use
6108         compunit_filetabs.
6109         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6110         (ALL_FILETABS): Use compunit_filetabs.
6111         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6112         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6113
6114 2019-01-09  Tom Tromey  <tom@tromey.com>
6115
6116         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6117         (compunit_filetabs): New.
6118         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6119         compunit_filetabs.
6120         (info_sources_command, make_source_files_completion_list): Remove
6121         declaration.
6122         * symmisc.c (print_objfile_statistics, dump_objfile)
6123         (maintenance_print_symbols): Remove declaration.
6124         (maintenance_info_symtabs): Use compunit_filetabs.
6125         (maintenance_info_line_tables): Likewise.
6126         * source.c (select_source_symtab): Change local variable name.
6127         (forget_cached_source_info_for_objfile): Remove declaration.
6128         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6129         * objfiles.c (objfile_relocate1): Remove declaration.
6130         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6131         declaration.
6132         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6133         * coffread.c (coff_symtab_read): Remove declaration.
6134         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6135         compunit_filetabs.
6136
6137 2019-01-09  Tom Tromey  <tom@tromey.com>
6138
6139         * symtab.c (lookup_objfile_from_block)
6140         (find_pc_sect_compunit_symtab, search_symbols)
6141         (default_collect_symbol_completion_matches_break_on): Use
6142         objfile_compunits.
6143         * objfiles.h (ALL_COMPUNITS): Remove.
6144         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6145         * cp-support.c (add_symbol_overload_list_qualified): Use
6146         objfile_compunits.
6147         * ada-lang.c (ada_collect_symbol_completion_matches)
6148         (ada_add_global_exceptions): Use objfile_compunits.
6149
6150 2019-01-09  Tom Tromey  <tom@tromey.com>
6151
6152         * source.c (select_source_symtab)
6153         (forget_cached_source_info_for_objfile): Remove declaration.
6154         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6155         declaration.
6156         * maint.c (count_symtabs_and_blocks): Remove declaration.
6157         * cp-support.c (add_symbol_overload_list_qualified): Remove
6158         declaration.
6159         * coffread.c (coff_symtab_read): Remove declaration.
6160         * symtab.c (lookup_symbol_in_objfile_symtabs)
6161         (basic_lookup_transparent_type_1): Use objfile_compunits.
6162         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6163         (info_sources_command, search_symbols)
6164         (default_collect_symbol_completion_matches_break_on)
6165         (make_source_files_completion_list): Remove declaration.
6166         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6167         (ada_collect_symbol_completion_matches)
6168         (ada_add_global_exceptions): Remove declaration.
6169         * linespec.c (iterate_over_all_matching_symtabs): Use
6170         objfile_compunits.
6171         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6172         (class objfile_compunits): New.
6173         (ALL_COMPUNITS): Use objfile_compunits.
6174         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6175         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6176         objfile_compunits.
6177         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6178
6179 2019-01-09  Tom Tromey  <tom@tromey.com>
6180
6181         * symtab.c (search_symbols)
6182         (default_collect_symbol_completion_matches_break_on): Use
6183         objfile_msymbols.
6184         * ada-lang.c (ada_lookup_simple_minsym)
6185         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6186         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6187         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6188         objfile_msymbols.
6189         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6190         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6191         * objc-lang.c (find_methods): Use objfile_msymbols.
6192         (info_selectors_command, info_classes_command): Likewise.
6193         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6194         * objfiles.h (class objfile_msymbols): New.
6195         (ALL_OBJFILE_MSYMBOLS): Remove.
6196         (ALL_MSYMBOLS): Remove.
6197
6198 2019-01-09  Tom Tromey  <tom@tromey.com>
6199
6200         * common/next-iterator.h (next_adapter): Add Iterator template
6201         parameter.
6202         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6203         (class all_objfiles_safe): New.
6204         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6205         * objfiles.c (put_objfile_before): Update comment.
6206         (add_separate_debug_objfile): Likewise.
6207         (free_all_objfiles): Use all_objfiles_safe.
6208         (objfile_purge_solibs): Likewise.
6209
6210 2019-01-09  Tom Tromey  <tom@tromey.com>
6211
6212         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6213         (expand_symtab_containing_pc, lookup_static_symbol)
6214         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6215         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6216         all_objfiles.
6217         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6218         * breakpoint.c (create_overlay_event_breakpoint)
6219         (create_longjmp_master_breakpoint)
6220         (create_std_terminate_master_breakpoint)
6221         (create_exception_master_breakpoint): Use all_objfiles.
6222         * linux-thread-db.c (try_thread_db_load_from_pdir)
6223         (has_libpthread): Use all_objfiles.
6224         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6225         * linespec.c (iterate_over_all_matching_symtabs)
6226         (search_minsyms_for_name): Use all_objfiles.
6227         * maint.c (maintenance_info_sections): Use all_objfiles.
6228         * main.c (captured_main_1): Use all_objfiles.
6229         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6230         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6231         * guile/scm-pretty-print.c
6232         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6233         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6234         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6235         (maintenance_print_msymbols): Use all_objfiles.
6236         * source.c (select_source_symtab): Use all_objfiles.
6237         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6238         * symfile.c (remove_symbol_file_command)
6239         (expand_symtabs_matching, map_symbol_filenames): Use
6240         all_objfiles.
6241         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6242         all_objfiles.
6243         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6244         * objc-lang.c (find_methods): Use all_objfiles.
6245         * objfiles.c (have_partial_symbols, have_full_symbols)
6246         (have_minimal_symbols, qsort_cmp)
6247         (default_iterate_over_objfiles_in_search_order): Use
6248         all_objfiles.
6249         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6250         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6251         (maintenance_check_psymtabs): Use all_objfiles.
6252         (ALL_PSYMTABS): Remove.
6253         * compile/compile-object-run.c (do_module_cleanup): Use
6254         all_objfiles.
6255         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6256         * cp-support.c (add_symbol_overload_list_qualified): Use
6257         all_objfiles.
6258         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6259         Use all_objfiles.
6260         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6261         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6262         all_objfiles.
6263         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6264         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6265         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6266         Uses all_objfiles.
6267         * solib.c (solib_read_symbols): Use all_objfiles
6268
6269 2019-01-09  Tom Tromey  <tom@tromey.com>
6270
6271         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6272         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6273         all_objfiles.
6274         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6275         * symmisc.c (print_symbol_bcache_statistics)
6276         (print_objfile_statistics, maintenance_print_objfiles)
6277         (maintenance_info_symtabs, maintenance_check_symtabs)
6278         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6279         all_objfiles.
6280         * source.c (forget_cached_source_info): Use all_objfiles.
6281         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6282         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6283         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6284         * objfiles.c (update_section_map): Use all_objfiles.
6285         (shared_objfile_contains_address_p): Likewise.
6286         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6287         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6288
6289 2019-01-09  Tom Tromey  <tom@tromey.com>
6290
6291         * common/next-iterator.h: New file.
6292         * objfiles.h (class all_objfiles): New.
6293         (struct objfile_iterator): New.
6294
6295 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6296
6297         * NEWS: Move the description of the changed "frame", "select-frame",
6298          and "info frame" commands to the Changed commands section.
6299
6300 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6301
6302         * gdbtypes.c (check_stub_method_group): Remove handling of old
6303         mangling schemes.
6304         * linespec.c (find_methods): Likewise.
6305         * stabsread.c (read_member_functions): Likewise.
6306         * valops.c (search_struct_method): Likewise.
6307         (value_struct_elt_for_reference): Likewise.
6308         * NEWS: Mention this change.
6309
6310 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6311
6312         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6313         print_source_lines.
6314         * source.c (print_source_lines_base): Update line number check.
6315         (print_source_lines): New function.
6316         (source_lines_range::source_lines_range): New function.
6317         * source.h (class source_lines_range): New class.
6318         (print_source_lines): New declaration.
6319
6320 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6321
6322         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6323
6324 2019-01-08  Tom Tromey  <tom@tromey.com>
6325             Simon Marchi  <simon.marchi@ericsson.com>
6326
6327         PR gdb/24060
6328         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6329         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6330         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6331         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6332         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6333         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6334
6335 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6336
6337         * source.c (select_source_symtab): Move header comment to
6338         declaration in source.h.
6339         (forget_cached_source_info_for_objfile): Likewise.
6340         (forget_cached_source_info): Likewise.
6341         (identify_source_line): Likewise.
6342         * source.h (identify_source_line): Move declaration from symtab.h
6343         and add comment from source.c
6344         (print_source_lines): Likewise.
6345         (forget_cached_source_info_for_objfile): Likewise.
6346         (forget_cached_source_info): Likewise.
6347         (select_source_symtab): Likewise.
6348         (enum print_source_lines_flag): Move definition from symtab.h.
6349         * symtab.h (identify_source_line): Move declaration to source.h.
6350         (print_source_lines): Likewise.
6351         (forget_cached_source_info_for_objfile): Likewise.
6352         (forget_cached_source_info): Likewise.
6353         (select_source_symtab): Likewise.
6354         (enum print_source_lines_flag): Move definition to source.h.
6355         * tui/tui-hooks.c: Add 'source.h' include.
6356
6357 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6358
6359         * source.c (print_source_lines_base): Handle requests to print
6360         reverse line number sequences, and guard against empty lines
6361         string.
6362
6363 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6364
6365         * source.c (print_source_lines_base): Fix skip of '\r' if next
6366         character is '\n'.
6367
6368 2019-01-06  Tom Tromey  <tom@tromey.com>
6369
6370         * c-exp.y (struct c_parse_state) <macro_original_text,
6371         expansion_obstack>: New member.
6372         (macro_original_text, expansion_obstack): Remove globals.
6373         (scan_macro_expansion, scanning_macro_expansion)
6374         (finished_macro_expansion): Update.
6375         (scan_macro_cleanup): Remove.
6376         (yylex, c_parse): Update.
6377
6378 2019-01-06  Tom Tromey  <tom@tromey.com>
6379
6380         * c-exp.y (struct c_parse_state) <strings>: New member.
6381         (operator_stoken): Update.
6382
6383 2019-01-06  Tom Tromey  <tom@tromey.com>
6384
6385         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6386         (union type_stack_elt) <typelist_val>: Now a pointer to
6387         std::vector.
6388         (type_stack_cleanup): Don't declare.
6389         (push_typelist): Update.
6390         * parse.c (pop_typelist): Return a std::vector.
6391         (push_typelist): Take a std::vector.
6392         (follow_types): Update.  Do not free args.
6393         (type_stack_cleanup): Remove.
6394         * c-exp.y (struct c_parse_state): New.
6395         (cpstate): New global.
6396         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6397         (nonempty_typelist): Update.
6398         (func_mod): Create a new vector.
6399         (c_parse): Create a c_parse_state.
6400         (check_parameter_typelist): Do not delete params.
6401         (function_method): Update.  Do not delete type_list.
6402
6403 2019-01-06  Tom Tromey  <tom@tromey.com>
6404
6405         PR gdb/28155:
6406         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6407         check_typedef.
6408         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6409         (print_return_value): Likewise.
6410
6411 2019-01-05  Tom Tromey  <tom@tromey.com>
6412
6413         * contrib/cleanup_check.py: Remove.
6414         * contrib/gcc-with-excheck: Remove.
6415         * contrib/exsummary.py: Remove.
6416         * contrib/excheck.py: Remove.
6417
6418 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6419
6420         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6421         NULL. Initialize tpprev to NULL instead of assigning it
6422         to NULL on the next statement.
6423         * windows-nat.c (windows_delete_thread): Remove check for
6424         main_thread_id before printing thread exit notifications.
6425         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6426         Remove thread ID check against main_thread_id.
6427         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6428         windows_delete_thread.
6429         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6430
6431 2019-01-04  Tom Tromey  <tom@tromey.com>
6432
6433         * compile/compile.c (_initialize_compile): Use upper case for
6434         metasyntactic variables.
6435         * symmisc.c (_initialize_symmisc): Use upper case for
6436         metasyntactic variables.
6437         * psymtab.c (_initialize_psymtab): Use upper case for
6438         metasyntactic variables.
6439         * demangle.c (demangle_command): Use upper case for metasyntactic
6440         variables.
6441         (_initialize_demangler): Likewise.
6442         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6443         variables.
6444
6445 2019-01-03  Tom Tromey  <tom@tromey.com>
6446
6447         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6448
6449 2019-01-03  Tom Tromey  <tom@tromey.com>
6450
6451         * python/py-symtab.c (salpy_str): Update.
6452         (struct salpy_sal_object) <symtab>: Now a PyObject.
6453         (salpy_dealloc): Update.
6454         (del_objfile_sal): Use gdbpy_ref.
6455
6456 2019-01-03  Tom Tromey  <tom@tromey.com>
6457
6458         * python/py-type.c (convert_field): Use new_reference.  Return
6459         gdbpy_ref.
6460         (make_fielditem): Return gdbpy_ref.
6461         (typy_fields): Update.
6462         (typy_getitem): Update.
6463         (field_name): Return gdbpy_ref.  Use new_reference.
6464         (typy_iterator_iternext): Update.
6465
6466 2019-01-03  Tom Tromey  <tom@tromey.com>
6467
6468         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6469
6470 2019-01-03  Tom Tromey  <tom@tromey.com>
6471
6472         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6473         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6474         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6475         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6476         (pspy_set_type_printers): Likewise.
6477         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6478         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6479         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6480         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6481         (objfpy_set_type_printers): Likewise.
6482
6483 2019-01-03  Tom Tromey  <tom@tromey.com>
6484
6485         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6486         (gdbpy_print_stack): Use gdbpy_err_fetch.
6487         * python/python-internal.h (class gdbpy_err_fetch): New class.
6488         (class gdbpy_enter) <m_error_type, m_error_value,
6489         m_error_traceback>: Remove.
6490         <m_error>: New member.
6491         (gdbpy_exception_to_string): Don't declare.
6492         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6493         * python/py-value.c (convert_value_from_python): Use
6494         gdbpy_err_fetch.
6495         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6496         gdbpy_exception_to_string.
6497         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6498         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6499         gdbpy_err_fetch.
6500
6501 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6502
6503         * linux-nat.c (delete_lwp_cleanup): Delete.
6504         (struct lwp_deleter): New struct.
6505         (lwp_info_up): New typedef.
6506         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6507         lwp_info_up.
6508
6509 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6510
6511         * linux-fork.c (class scoped_switch_fork_info): New class.
6512         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6513
6514 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6515
6516         * valops.c (find_overload_match): Remove use of null_cleanup, and
6517         calls to do_cleanups.
6518
6519 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6520
6521         * compile/compile-cplus-types.c
6522         (compile_cplus_instance::decl_name): Handle changes to
6523         cp_func_name.
6524         * cp-support.c (cp_func_name): Update header comment, update
6525         return type.
6526         * cp-support.h (cp_func_name): Update return type in declaration.
6527         * valops.c (find_overload_match): Move temp_func local to top
6528         level of function and change its type.  Use temp_func to hold and
6529         delete temporary string obtained from cp_func_name.
6530
6531 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6532
6533         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6534         gdb::char_vector, remove cleanup, and update uses of `msg`.
6535
6536 2019-01-03  Jim Wilson  <jimw@sifive.com>
6537
6538         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6539
6540 2019-01-02  Tom Tromey  <tom@tromey.com>
6541
6542         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6543         (tdesc_parse_xml): Remove cleanups.
6544         * target-descriptions.h (make_cleanup_free_target_description):
6545         Don't declare.
6546         (target_desc_deleter): New struct.
6547         (target_desc_up): New typedef.
6548         * target-descriptions.c (target_desc_deleter::operator()): Rename
6549         from free_target_description.
6550         (make_cleanup_free_target_description): Remove.
6551
6552 2019-01-02  Tom Tromey  <tom@tromey.com>
6553
6554         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6555         constructor, destructor.
6556         (linespec_parser): Remove typedef.
6557         (~linespec_parser): Rename from linespec_parser_delete.
6558         (linespec_lex_to_end, linespec_complete_label)
6559         (linespec_complete): Update.
6560         (decode_line_full): Remove cleanups.
6561         (decode_line_1): Update.
6562
6563 2019-01-02  Tom Tromey  <tom@tromey.com>
6564
6565         * python/python-internal.h (inferior_to_inferior_object): Change
6566         return type.
6567         * python/py-exitedevent.c (create_exited_event_object): Update.
6568         * python/py-inferior.c (inferior_to_inferior_object): Return
6569         gdbpy_ref.
6570         (python_new_inferior, python_inferior_deleted)
6571         (thread_to_thread_object, delete_thread_object)
6572         (build_inferior_list, gdbpy_selected_inferior): Update.
6573         * python/py-infthread.c (create_thread_object): Update.  Also fail
6574         if inferior_to_inferior_object fails.
6575
6576 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6577
6578         * inferior.h (class inferior) <displaced_step_state>: New field.
6579         * infrun.h (struct displaced_step_state): Move here from
6580         infrun.c.  Initialize fields, add constructor.
6581         <inf>: Remove field.
6582         <reset>: New method.
6583         * infrun.c (struct displaced_step_inferior_state): Move to
6584         infrun.h.
6585         (displaced_step_inferior_states): Remove.
6586         (get_displaced_stepping_state): Adust.
6587         (displaced_step_in_progress_any_inferior): Adjust.
6588         (displaced_step_in_progress_thread): Adjust.
6589         (displaced_step_in_progress): Adjust.
6590         (add_displaced_stepping_state): Remove.
6591         (get_displaced_step_closure_by_addr): Adjust.
6592         (remove_displaced_stepping_state): Remove.
6593         (infrun_inferior_exit): Call displaced_step_state.reset.
6594         (use_displaced_stepping): Don't check for NULL.
6595         (displaced_step_prepare_throw): Call
6596         get_displaced_stepping_state.
6597         (displaced_step_fixup): Don't check for NULL.
6598         (prepare_for_detach): Don't check for NULL.
6599
6600 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6601
6602         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6603          in case of call that did not complete.
6604
6605 2019-01-02  Andrey Utkin  <autkin@undo.io>
6606
6607         * symfile.c (find_separate_debug_file): Fix search of debug files for
6608         remote debuggee.
6609
6610 2019-01-02  Tom Tromey  <tom@tromey.com>
6611
6612         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6613         indentation.
6614         * python/py-frame.c (frapy_older): Remove cast.
6615         (frapy_newer): Likewise.
6616         * python/py-breakpoint.c (local_setattro): Remove cast.
6617         * python/py-arch.c (archpy_name): Remove local variable.
6618         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6619
6620 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6621
6622         * unittests/basic_string_view/element_access/char/empty.cc:
6623         Fix year range in copyright header.
6624
6625 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6626
6627         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6628         Delete.
6629         <operator==>: Update with for removed field.
6630         <hash>: Likewise.
6631         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6632         <isa_features>: ...this.
6633         <abi_features>: New field.
6634         (riscv_isa_flen): Update comment.
6635         (riscv_abi_xlen): New declaration.
6636         (riscv_abi_flen): New declaration.
6637         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6638         isa_features.
6639         (riscv_abi_xlen): New function.
6640         (riscv_isa_flen): Update to get answer from isa_features.
6641         (riscv_abi_flen): New function.
6642         (riscv_has_fp_abi): Update to get answer from abi_features.
6643         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6644         xlen and flen.
6645         (riscv_call_info) <xlen, flen>: Update comment.
6646         (riscv_call_arg_struct): Remove invalid assertions
6647         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6648         is removed.
6649         (riscv_gdbarch_init): Gather isa features and abi features
6650         separately, ensure both match on the gdbarch when reusing an old
6651         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6652         a target with 64-bit float hardware.
6653
6654 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6655
6656         * source.c (search_command_helper): Stop reverse search
6657         when line 1 has been searched.
6658
6659 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6660
6661         * record-full.c (record_full_base_target::close): Rewrite
6662         record_full_core_buf_list free logic.
6663
6664 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6665
6666         * break-catch-syscall.c (print_one_catch_syscall): xfree
6667         the last text.
6668
6669 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6670
6671         * top.c (print_gdb_version): Update Copyright year in version
6672         message.
6673
6674 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6675
6676         Update copyright year range in all GDB files.
6677
6678 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6679
6680         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6681
6682 For older changes see ChangeLog-2018.
6683 \f
6684 Local Variables:
6685 mode: change-log
6686 left-margin: 8
6687 fill-column: 74
6688 version-control: never
6689 coding: utf-8
6690 End:
6691