gdb/ChangeLog

   1 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
   4         of changes to field names, and use new is_reference field to
   5         decide if a property is a reference or not.
   6         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
   7         field.
   8         (struct dwarf2_property_baton): Update header comment, rename
   9         'referenced_type' to 'property_type' and update comments.
  10         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
  11         default property type, store in property baton, update to take
  12         accound of renamed field.
  13         (read_func_scope): Update call to attr_to_dynamic_prop.
  14         (read_array_type): Likewise.
  15         (dwarf2_per_cu_addr_sized_int_type): New function.
  16         (read_subrange_index_type): Move type finding code to
  17         dwarf2_per_cu_addr_sized_int_type.
  18         (read_subrange_type): Update calls to attr_to_dynamic_prop.
  19         (dwarf2_per_cu_addr_type): New function.
  20         (set_die_type): Update calls to attr_to_dynamic_prop.
  21
  22 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  23
  24         * dwarf2read.c (read_subrange_index_type): New function.
  25         (read_subrange_type): Move code into new function and call it.
  26         * gdbtypes.c (create_range_type): Add some asserts.
  27
  28 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  29
  30         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
  31         update return statements.
  32         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
  33         declaration, and update comment to match.
  34         * gdbtypes.c (resolve_dynamic_array): Update call to
  35         dwarf2_evaluate_property to match new return type.
  36
  37 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  38
  39         * valarith.c (value_subscripted_rvalue): Change lowerbound
  40         parameter type from int to LONGEST.
  41         * value.h (value_subscripted_rvalue): Likewise in declaration.
  42
  43 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  44
  45         * cli/cli-utils.c (info_print_command_completer): New function.
  46         * cli/cli-utils.h: Add 'completer.h' include, and forward
  47         declaration for 'struct cmd_list_element'.
  48         (info_print_command_completer): Declare.
  49         * stack.c (_initialize_stack): Add completer for 'info locals' and
  50         'info args'.
  51         * symtab.c (_initialize_symtab): Add completer for 'info
  52         variables' and 'info functions'.
  53         * NEWS: Mention completion for additional info commands.
  54
  55 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  56
  57         * cli/cli-utils.c (extract_info_print_args): Delete.
  58         (extract_arg_maybe_quoted): Delete.
  59         (info_print_options_defs): New variable.
  60         (make_info_print_options_def_group): New function.
  61         (extract_info_print_options): Define new function.
  62         * cli/cli-utils.h (extract_info_print_args): Delete.
  63         (struct info_print_options): New structure.
  64         (extract_info_print_options): Declare new function.
  65         * stack.c (info_locals_command): Update to use new
  66         extract_info_print_options, also add a header comment.
  67         (info_args_command): Likewise.
  68         * symtab.c (info_variables_command): Likewise.
  69         (info_functions_command): Likewise.
  70
  71 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  72
  73         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
  74         to extract string arguments.
  75         * common/common-utils.c (extract_string_maybe_quoted): New function.
  76         * common/common-utils.h (extract_string_maybe_quoted): Declare.
  77
  78 2019-07-11  Tom Tromey  <tromey@adacore.com>
  79
  80         * main.c (get_init_files): Use GDBINIT, not gdbinit.
  81         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
  82         * top.h (gdbinit): Don't declare.
  83         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
  84         into...
  85         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
  86         * top.c (gdb_init): Don't call init_cli_cmds.
  87         (gdbinit): Remove.
  88         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
  89
  90 2019-07-11  Tom Tromey  <tromey@adacore.com>
  91
  92         * python/py-inferior.c (add_thread_object): Don't use thread_obj
  93         after it has been moved.
  94
  95 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  96
  97         * valops.c (value_must_coerce_to_target): Change return type to
  98         bool.
  99         * value.h (value_must_coerce_to_target): Likewise.
 100
 101 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 102
 103         * breakpoint.c (is_hardware_watchpoint): Remove
 104         forward-declaration.
 105         (is_masked_watchpoint): Change return type to bool.
 106         (is_tracepoint): Likewise.
 107         (is_breakpoint): Likewise.
 108         (is_hardware_watchpoint): Likewise.
 109         (is_watchpoint): Likewise.
 110         (is_no_memory_software_watchpoint): Likewise.
 111         (is_catchpoint): Likewise.
 112         (breakpoint_1): Make FILTER parameter's return type bool.
 113         is_masked_watchpoint): Change return type to bool.
 114         (save_breakpoints): Make FILTER parameter's return type bool.
 115         * breakpoint.h (is_breakpoint): Change return type to bool.
 116         (is_watchpoint): Likewise.
 117         (is_catchpoint): Likewise.
 118         (is_tracepoint): Likewise.
 119
 120 2019-07-10  Tom Tromey  <tom@tromey.com>
 121
 122         * defs.h: Don't include gdbarch.h.
 123         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 124         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 125         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 126         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 127         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 128         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 129         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 130         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 131         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 132         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 133         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 134         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 135         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 136         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 137         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 138         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 139         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 140         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 141         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 142         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 143         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 144         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 145         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 146         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 147         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 148         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 149         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 150
 151 2019-07-10  Tom Tromey  <tromey@adacore.com>
 152
 153         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 154         * breakpoint.c (init_ada_exception_breakpoint): Register as
 155         bp_catchpoint.
 156         (print_one_breakpoint_location, print_one_breakpoint): Use
 157         is_ada_exception_catchpoint.
 158         * ada-lang.c (class ada_catchpoint_location): Pass
 159         bp_loc_software_breakpoint to bp_location constructor.
 160         (is_ada_exception_catchpoint): New function.
 161
 162 2019-07-10  Tom Tromey  <tromey@adacore.com>
 163
 164         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 165         VEC.
 166         (struct arm_exidx_entry): New method operator<.
 167         (struct arm_exidx_data) <section_maps>: Change type.
 168         (arm_exidx_data_free): Remove.
 169         (arm_exidx_data_key): Change type.  Move lower.
 170         (arm_exidx_new_objfile): Update.
 171         (arm_compare_exidx_entries): Remove.
 172         (arm_find_exidx_entry, _initialize_arm_tdep)
 173
 174 2019-07-10  Tom Tromey  <tromey@adacore.com>
 175
 176         * solib-spu.c (ocl_program_data_key): Change type.
 177         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 178         Update.
 179
 180 2019-07-10  Tom Tromey  <tromey@adacore.com>
 181
 182         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 183         (struct solib_aix_inferior_data) <library_list>: Change type.
 184         (solib_aix_inferior_data_handle): Change type.
 185         (get_solib_aix_inferior_data): Update.
 186         (solib_aix_free_library_list): Remove.
 187         (library_list_start_library): Update.
 188         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 189         return type.
 190         (solib_aix_get_library_list)
 191         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 192         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 193
 194 2019-07-10  Tom Tromey  <tromey@adacore.com>
 195
 196         * solib-dsbt.c (struct dsbt_info): Add initializers.
 197         (solib_dsbt_pspace_data): Change type.
 198         (dsbt_pspace_data_cleanup): Remove.
 199         (get_dsbt_info, _initialize_dsbt_solib): Update.
 200
 201 2019-07-10  Tom Tromey  <tromey@adacore.com>
 202
 203         * spu-tdep.c (spu_overlay_data): Change type.
 204         (spu_get_overlay_table, spu_overlay_new_objfile)
 205         (_initialize_spu_tdep): Update.
 206
 207 2019-07-10  Tom Tromey  <tromey@adacore.com>
 208
 209         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 210         destructor.
 211         (dbx_objfile_data_key): Change type and declare later.
 212         (DBX_SYMFILE_INFO): Rewrite.
 213         * dbxread.c (dbx_objfile_data_key): Change type.
 214         (dbx_symfile_init): Update.
 215         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 216         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 217         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 218
 219 2019-07-10  Tom Tromey  <tromey@adacore.com>
 220
 221         * jit.c (jit_program_space_key): Change type.  Move lower.
 222         (get_jit_program_space_data): Update.
 223         (jit_program_space_data_cleanup): Remove.
 224         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 225         Update.
 226         (struct jit_program_space_data): Add initializers.
 227
 228 2019-07-10  Tom Tromey  <tromey@adacore.com>
 229
 230         * solib-darwin.c (struct darwin_info): Add initializers.
 231         (solib_darwin_pspace_data): Change type.
 232         (darwin_pspace_data_cleanup): Remove.
 233         (get_darwin_info, _initialize_darwin_solib): Update.
 234
 235 2019-07-10  Tom Tromey  <tromey@adacore.com>
 236
 237         * remote-sim.c (struct sim_inferior_data): Add initializers,
 238         constructor, and destructor.
 239         (sim_inferior_data_key): Change type.  Move lower.
 240         (check_for_duplicate_sim_descriptor): Update.
 241         (get_sim_inferior_data): Use new.  Update.
 242         (~sim_inferior_data_cleanup): Rename from
 243         sim_inferior_data_cleanup.  Simplify.
 244         (gdbsim_close_inferior, simulator_command)
 245         (sim_command_completer, _initialize_remote_sim): Update.
 246         (next_pid, INITIAL_PID): Move earlier.
 247
 248 2019-07-10  Tom Tromey  <tromey@adacore.com>
 249
 250         * python/python-internal.h (create_thread_object): Return
 251         gdbpy_ref.
 252         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 253         * python/py-inferior.c (struct threadlist_entry): Add
 254         constructor.
 255         <thread_obj>: Now a gdbpy_ref.
 256         (thread_to_thread_object): Update.
 257         (add_thread_object): Use new.
 258         (delete_thread_object): Use delete.
 259         (infpy_threads): Update.
 260         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 261         GIL.
 262
 263 2019-07-10  Tom Tromey  <tromey@adacore.com>
 264
 265         * valops.c (value_cast): Specialize error message for Ada.
 266
 267 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 268
 269         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 270
 271 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 272
 273         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 274         bpstat_should_step): Return bool, adjust comments.
 275         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 276         bpstat_should_step): Likewise.
 277
 278 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 279
 280         * features/Makefile: Use feature target descriptions for Arm.
 281         * features/arm/arm-core.c: Generate new file.
 282         * features/arm/arm-fpa.c: Likewise.
 283         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 284         * features/arm/arm-m-profile.c: Likewise.
 285         * features/arm/arm-vfpv2.c: Likewise.
 286         * features/arm/arm-vfpv3.c: Likewise.
 287         * features/arm/xscale-iwmmxt.c: Likewise.
 288         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 289
 290 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 291
 292         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 293         ptrace earlier.
 294
 295 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 296
 297         * features/aarch64-pauth.c: Regenerate.
 298
 299 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 300
 301         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 302         bool.
 303         (bpstat_what): Use false instead of 0.
 304
 305 2019-07-09  Pedro Alves  <palves@redhat.com>
 306
 307         * break-catch-throw.c (is_exception_catchpoint): New.
 308         * breakpoint.c (print_one_breakpoint_location): New parameter
 309         'raw_loc'.  Handle it.  Use
 310         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 311         looking at the breakpoint's type.
 312         (print_one_breakpoint): If handling "maint info breakpoints", also
 313         print locations of exception catchpoints.
 314         * breakpoint.h (is_exception_catchpoint): Declare.
 315
 316 2019-07-09  Pedro Alves  <palves@redhat.com>
 317
 318         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 319         "addr" field.
 320         (allocate_location_exception_catchpoint): New.
 321         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 322         (initialize_throw_catchpoint_ops): Install
 323         allocate_location_exception_catchpoint as allocate_location
 324         method.
 325         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 326         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 327         bp_loc_other.
 328         (breakpoint_address_is_meaningful): Delete.
 329         (bl_address_is_meaningful): New.
 330         (breakpoint_locations_match): Adjust comment.
 331         (bp_location_from_bp_type): New, factored out of...
 332         (bp_location::bp_location(breakpoint *)): ... this.
 333         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 334         factored out of...
 335         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 336         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 337         breakpoint_address_is_meaningful.
 338         (bp_locations_compare): Adjust comment.
 339         (update_global_location_list): Use bl_address_is_meaningful
 340         instead of breakpoint_address_is_meaningful.
 341         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 342         explicit.
 343         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 344         * python/py-breakpoint.c (bppy_get_location): No longer check
 345         whether location is null.
 346
 347 2019-07-09  Pedro Alves  <palves@redhat.com>
 348
 349         PR c++/15468
 350         * breakpoint.c (print_one_breakpoint_location): Remove
 351         single-location assert.
 352
 353 2019-07-09  Tom Tromey  <tom@tromey.com>
 354
 355         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 356         * configure: Rebuild.
 357         * configure.ac: Change common to gdbsupport.
 358         * gdbsupport: Rename from common.
 359         * acinclude.m4: Change common to gdbsupport.
 360         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 361         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 362         gdbsupport.
 363         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 364         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 365         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 366         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 367         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 368         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 369         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 370         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 371         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 372         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 373         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 374         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 375         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 376         coff-pe-read.c, command.h, compile/compile-c-support.c,
 377         compile/compile-c.h, compile/compile-cplus-symbols.c,
 378         compile/compile-cplus-types.c, compile/compile-cplus.h,
 379         compile/compile-loc2c.c, compile/compile.c, completer.c,
 380         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 381         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 382         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 383         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 384         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 385         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 386         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 387         features/aarch64-core.c, features/aarch64-fpu.c,
 388         features/aarch64-pauth.c, features/aarch64-sve.c,
 389         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 390         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 391         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 392         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 393         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 394         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 395         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 396         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 397         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 398         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 399         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 400         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 401         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 402         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 403         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 404         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 405         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 406         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 407         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 408         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 409         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 410         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 411         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 412         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 413         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 414         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 415         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 416         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 417         minsyms.c, mips-linux-tdep.c, namespace.h,
 418         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 419         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 420         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 421         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 422         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 423         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 424         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 425         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 426         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 427         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 428         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 429         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 430         procfs.c, producer.c, progspace.h, psymtab.h,
 431         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 432         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 433         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 434         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 435         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 436         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 437         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 438         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 439         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 440         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 441         target-memory.c, target.c, target.h, target/waitstatus.c,
 442         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 443         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 444         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 445         unittests/array-view-selftests.c,
 446         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 447         unittests/common-utils-selftests.c,
 448         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 449         unittests/format_pieces-selftests.c,
 450         unittests/function-view-selftests.c,
 451         unittests/lookup_name_info-selftests.c,
 452         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 453         unittests/mkdir-recursive-selftests.c,
 454         unittests/observable-selftests.c,
 455         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 456         unittests/parse-connection-spec-selftests.c,
 457         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 458         unittests/scoped_fd-selftests.c,
 459         unittests/scoped_mmap-selftests.c,
 460         unittests/scoped_restore-selftests.c,
 461         unittests/string_view-selftests.c, unittests/style-selftests.c,
 462         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 463         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 464         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 465         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 466         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 467         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 468
 469 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 470
 471         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 472         bool value.
 473         (decode_digits_ordinary): Set explicit_line field in sal.
 474         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 475         symtab_and_line that was set on an explicit line number in
 476         assembler code.  Do always update the recorded symtab and line if
 477         we do skip the prologue.
 478
 479 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 480
 481         * breakpoint.c (set_breakpoint_location_function): Remove
 482         explicit_loc parameter.
 483         (momentary_breakpoint_from_master): Update call to
 484         set_breakpoint_location_function.
 485         (add_location_to_breakpoint): Likewise.
 486
 487 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 488
 489         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 490         required features based on default bfd type when no specific bfd
 491         is present.
 492
 493 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 494
 495         * NEWS: Mention that GDB printf and eval commands can now print
 496         C-style and Ada-style convenience var strings without
 497         calling the inferior.
 498         * printcmd.c (printf_c_string): Locally print GDB internal var
 499         instead of transiting via the inferior.
 500         (printf_wide_c_string): Likewise.
 501
 502 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 503
 504         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 505
 506 2019-07-04  Tom Tromey  <tom@tromey.com>
 507
 508         PR tui/24724:
 509         * tui/tui-winsource.c (tui_clear_source_content): Update.
 510         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 511         (tui_update_breakpoint_info): Update.
 512         (tui_set_exec_info_content): Update.
 513         * tui/tui-source.c (tui_set_source_content_nil): Update.
 514         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 515         has_break.
 516         * tui/tui-data.h (enum tui_bp_flag): New.
 517         (tui_bp_flags): New enum flags type.
 518         (struct tui_source_element) <break_mode>: Change type.  Rename
 519         from has_break.
 520         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 521         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 522         constants.
 523         * tui/tui-winsource.h: Fix comment.
 524
 525 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 526
 527         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 528         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 529         (store_fpregs_to_thread)
 530         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 531         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 532         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 533         (IWMMXT_REGS_SIZE): Add define.
 534         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 535         (fetch_vfp_regs, store_vfp_regs)
 536         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 537         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 538
 539 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 540
 541         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 542         defines.
 543         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 544         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 545         (ARM_INT_REGISTER_SIZE): ...to this.
 546         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 547         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 548         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 549         (arm_linux_collect_gregset, supply_nwfpe_register)
 550         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 551         defines.
 552         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 553         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 554         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 555         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 556         (arm_return_in_memory, arm_store_return_value)
 557         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 558         (arm_record_ld_st_multiple): Likewise.
 559         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 560         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 561
 562 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 563
 564         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 565         AARCH64_DISPLACED_MODIFIED_INSNS.
 566         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 567         (aarch64_displaced_step_copy_insn): Likewise.
 568         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 569         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 570         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 571         ARM_DISPLACED_MODIFIED_INSNS.
 572         * arm-tdep.c (arm_gdbarch_init): Likewise.
 573         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 574         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 575         (struct arm_displaced_step_closure): Use
 576         ARM_DISPLACED_MODIFIED_INSNS.
 577
 578 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 579
 580         * features/Makefile: Remove unused xml files.
 581         * features/aarch64.xml: Remove.
 582         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 583         * features/i386/amd64-avx-avx512.xml: Remove.
 584         * features/i386/amd64-avx-linux.xml: Remove.
 585         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 586         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 587         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 588         * features/i386/amd64-avx-mpx.xml: Remove.
 589         * features/i386/amd64-avx.xml: Remove.
 590         * features/i386/amd64-linux.xml: Remove.
 591         * features/i386/amd64-mpx-linux.xml: Remove.
 592         * features/i386/amd64-mpx.xml: Remove.
 593         * features/i386/amd64.xml: Remove.
 594         * features/i386/i386-avx-avx512-linux.xml: Remove.
 595         * features/i386/i386-avx-avx512.xml: Remove.
 596         * features/i386/i386-avx-linux.xml: Remove.
 597         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 598         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 599         * features/i386/i386-avx-mpx-linux.xml: Remove.
 600         * features/i386/i386-avx-mpx.xml: Remove.
 601         * features/i386/i386-avx.xml: Remove.
 602         * features/i386/i386-linux.xml: Remove.
 603         * features/i386/i386-mmx-linux.xml: Remove.
 604         * features/i386/i386-mmx.xml: Remove.
 605         * features/i386/i386-mpx-linux.xml: Remove.
 606         * features/i386/i386-mpx.xml: Remove.
 607         * features/i386/i386.xml: Remove.
 608         * features/i386/x32-avx-avx512-linux.xml: Remove.
 609         * features/i386/x32-avx-linux.xml: Remove.
 610         * features/i386/x32-linux.xml: Remove.
 611
 612 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 613
 614         * regformats/aarch64.dat: Remove.
 615         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 616         * regformats/i386/amd64-avx-linux.dat: Remove.
 617         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 618         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 619         * regformats/i386/amd64-linux.dat: Remove.
 620         * regformats/i386/amd64-mpx-linux.dat: Remove.
 621         * regformats/i386/amd64.dat: Remove.
 622         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 623         * regformats/i386/i386-avx-linux.dat: Remove.
 624         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 625         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 626         * regformats/i386/i386-linux.dat: Remove.
 627         * regformats/i386/i386-mmx-linux.dat: Remove.
 628         * regformats/i386/i386-mpx-linux.dat: Remove.
 629         * regformats/i386/i386.dat: Remove.
 630         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 631         * regformats/i386/x32-avx-linux.dat: Remove.
 632         * regformats/i386/x32-linux.dat: Remove.
 633
 634 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 635
 636         * aarch64-tdep.c: Remove xml self tests.
 637         * amd64-linux-tdep.c: Likewise.
 638         * amd64-tdep.c: Likewise.
 639         * i386-linux-tdep.c: Likewise.
 640         * i386-tdep.c: Likewise.
 641
 642 2019-07-03  Pedro Alves  <palves@redhat.com>
 643
 644         PR cli/24732
 645         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 646         (pipe_cmd_option_defs): New.
 647         (make_pipe_cmd_options_def_group): New.
 648         (pipe_command): Use gdb::option::process_options.
 649         (pipe_command_completer): New function.
 650         (_initialize_cli_cmds): Install completer for "pipe" command.
 651
 652 2019-07-03  Pedro Alves  <palves@redhat.com>
 653
 654         * cli/cli-option.c (union option_value) <string>: New field.
 655         (struct option_def_and_value): Add ctor, move ctor, dtor and
 656         use DISABLE_COPY_AND_ASSIGN.
 657         (option_def_and_value::clear_value): New.
 658         (parse_option, save_option_value_in_ctx, get_val_type_str)
 659         (add_setshow_cmds_for_options): Handle var_string.
 660         * cli-option.h (union option_def::var_address) <string>: New
 661         field.
 662         (struct string_option_def): New.
 663         * maint-test-options.c (struct test_options_opts): Add default
 664         ctor and use DISABLE_COPY_AND_ASSIGN.
 665         <string_opt>: New field.
 666         (test_options_opts::~test_options_opts): New.
 667         (test_options_opts::dump): Also dump "-string".
 668         (test_options_option_defs): Install "string.
 669
 670 2019-07-03  Pedro Alves  <palves@redhat.com>
 671
 672         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 673         option_value with a null enumeration.
 674         (complete_options): Save the option values in the context.
 675         (save_option_value_in_ctx): New, factored out from ...
 676         (process_options): ... here.
 677         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 678         of the function.
 679         * maint-test-options.c (test_options_opts::dump): New, factored
 680         out from ...
 681         (maintenance_test_options_command_mode): ... here.
 682         (maintenance_test_options_command_completion_result): Delete.
 683         (maintenance_test_options_command_completion_text): Update
 684         comment.
 685         (maintenance_show_test_options_completion_result): Change
 686         prototype.  Just print
 687         maintenance_test_options_command_completion_text.
 688         (save_completion_result): New.
 689         (maintenance_test_options_completer_mode): Pass options context to
 690         complete_options, and then save a dump.
 691         (_initialize_maint_test_options): Use add_cmd to install "maint
 692         show test-options-completion-result".
 693
 694 2019-07-03  Pedro Alves  <palves@redhat.com>
 695
 696         * NEWS (New commands): Mention "with" and "maint with".
 697         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 698         (with_command, with_command_completer): New.
 699         (pipe_command): Adjust to new repeat_previous
 700         interface.
 701         (_initialize_cli_cmds): Install the "with" command and its "w"
 702         alias.
 703         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 704         declarations.
 705         * cli/cli-setshow.c (parse_cli_var_uinteger)
 706         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 707         argument strings for all var_types.
 708         (get_setshow_command_value_string): New, factored out from ...
 709         (do_show_command): ... this.
 710         * cli/cli-setshow.h: Include <string>.
 711         (get_setshow_command_value_string): Declare.
 712         * command.h (repeat_previous): Now returns const char *.  Adjust
 713         comment.
 714         * maint.c: Include "cli/cli-cmds.h".
 715         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 716         (_initialize_maint_cmds): Register the "maintenance with" command.
 717         * top.c (repeat_previous): Move bits from pipe_command here:
 718         Return the saved command line, if any; error out if there's no
 719         command to relaunch.
 720
 721 2019-07-03  Pedro Alves  <palves@redhat.com>
 722
 723         * NEWS (New commands): Mention "maint set/show test-settings"
 724         instead of "maint test-settings".
 725         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 726         (maintenance_test_settings_set_list): Rename to ...
 727         (maintenance_set_test_settings_list): ... this.
 728         (maintenance_test_settings_show_list): Rename to  ...
 729         (maintenance_show_test_settings_list): ... this.
 730         (maintenance_test_settings_cmd): Delete.
 731         (maintenance_test_settings_set_cmd): ...
 732         (maintenance_set_test_settings_cmd): ... this.
 733         (maintenance_test_settings_show_cmd): ...
 734         (maintenance_show_test_settings_cmd): ... this.
 735         (maintenance_test_settings_show_value_cmd):
 736         (maintenance_show_test_settings_value_cmd): ... this.
 737         (_initialize_maint_test_settings): No longer install the "maint
 738         test-settings" prefix command.  Rename "maint test-settings set"
 739         to "maint set test-settings", and "maint test-settings show" to
 740         "maint show test-settings".  Adjust all subcommands.
 741
 742 2019-07-03  Pedro Alves  <palves@redhat.com>
 743
 744         * maint-test-settings.c: Fix file's intro comment.  Replace all
 745         references to "test-options" with references to "test-settings",
 746         in comments.
 747
 748 2019-07-03  Pedro Alves  <palves@redhat.com>
 749
 750         * maint-test-settings.c (maintenance_test_settings_xxx)
 751         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 752         New.
 753         (maintenance_test_settings_enums): Use them.
 754         (maintenance_test_settings_enum): Default to
 755         maintenance_test_settings_xxx.
 756         (_initialize_maint_test_settings): Initialize
 757         MAINTENANCE_TEST_SETTINGS_FILENAME.
 758
 759 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 760
 761         * breakpoint.h (remove_breakpoints_inf): Change return type to
 762         void, move function documentation here.
 763         * breakpoint.c (remove_breakpoints_inf): Change return type to
 764         void, move function documentation to header.
 765
 766 2019-07-02  Pedro Alves  <palves@redhat.com>
 767
 768         * NEWS (Completion improvements): Mention "info threads".
 769         * thread.c (struct info_threads_opts, info_threads_option_defs)
 770         (make_info_threads_options_def_group): New.
 771         (info_threads_command): Use gdb::option::process_options.
 772         (info_threads_command_completer): New.
 773         (_initialize_thread): Use gdb::option::build_help to build the
 774         help text for "info threads".
 775
 776 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 777
 778         * defs.h (generic_load): Move from here...
 779         * symfile.h (generic_load): ... to here.  Rename name parameter
 780         to args.
 781         * symfile.c (generic_load): Add comment.
 782
 783 2019-07-01  Tom Tromey  <tromey@adacore.com>
 784
 785         * dwarf2read.c
 786         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 787         declaration of without_params.  Fix formatting.
 788
 789 2019-07-01  Tom Tromey  <tromey@adacore.com>
 790
 791         * ada-exp.y (find_primitive_type): Update.
 792         * ada-lang.h (ada_lookup_symbol): Update.
 793         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 794         parameter.
 795         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 796
 797 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 798
 799         PR breakpoints/24541
 800         * gdbarch.c: Regenerate.
 801         * gdbarch.h: Regenerate.
 802         * gdbarch.sh: Add 'stap_adjust_register'.
 803         * i386-tdep.c: Include '<unordered_set>'.
 804         (i386_stap_adjust_register): New function.
 805         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 806         * stap-probe.c (stap_parse_register_operand): Call
 807         'gdbarch_stap_adjust_register'.
 808
 809 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 810
 811         PR python/24742
 812         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 813         * python/python.c (do_start_initialization): Use 'xmalloc'
 814         instead of 'PyMem_Malloc'.
 815
 816 2019-06-28  Tom Tromey  <tromey@adacore.com>
 817
 818         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 819         for Ada.
 820
 821 2019-06-27  Tom Tromey  <tromey@adacore.com>
 822
 823         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 824         objfile_key.
 825         (arm_find_mapping_symbol, arm_record_special_symbol)
 826         (_initialize_arm_tdep): Update.
 827         (arm_objfile_data_free): Remove.
 828
 829 2019-06-27  Tom Tromey  <tromey@adacore.com>
 830
 831         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 832         to cp_print_static_field.
 833
 834 2019-06-26  Tom Tromey  <tromey@adacore.com>
 835
 836         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 837         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 838         declare.
 839
 840 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 841
 842         * features/aarch64-core.c (create_feature_aarch64_core):
 843         Regenerate.
 844         * features/aarch64-core.xml: Add cpsr flags.
 845
 846 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 847
 848         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 849         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 850
 851 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 852
 853         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 854         field.
 855         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 856         use.
 857         (arm_record_special_symbol): Don't insert new symbol in sorted
 858         position, push it at the end.
 859
 860 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 861
 862         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 863         (arm_mapping_symbol_s): Remove.
 864         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 865         (arm_mapping_symbol_vec): New typedef.
 866         (struct arm_per_objfile): Add constructor.
 867         <section_maps>: Change type to
 868         std::unique_ptr<arm_mapping_symbol_vec[]>.
 869         (arm_compare_mapping_symbols): Remove.
 870         (arm_find_mapping_symbol): Adjust to section_maps type change.
 871         (arm_objfile_data_free): Call delete on arm_per_objfile.
 872         (arm_record_special_symbol): Adjust to section_maps type change.
 873         Allocate arm_per_objfile with new.
 874
 875 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 876
 877         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 878         with the command prefix.
 879
 880 2019-06-25  Tom Tromey  <tom@tromey.com>
 881
 882         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 883         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 884
 885 2019-06-25  Tom Tromey  <tom@tromey.com>
 886
 887         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 888         type.
 889         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 890         protected.
 891
 892 2019-06-25  Tom Tromey  <tom@tromey.com>
 893
 894         * tui/tui-winsource.c
 895         (tui_source_window_base::set_is_exec_point_at): Add check against
 896         LOA_ADDRESS.
 897
 898 2019-06-25  Tom Tromey  <tom@tromey.com>
 899
 900         * tui/tui-source.c (tui_set_source_content): Don't check before
 901         xfree.
 902         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 903
 904 2019-06-25  Tom Tromey  <tom@tromey.com>
 905
 906         * tui/tui-winsource.h (tui_update_source_window_as_is)
 907         (tui_alloc_source_buffer, tui_line_is_displayed)
 908         (tui_addr_is_displayed): Change type of win_info.
 909         * tui/tui-winsource.c (tui_update_source_window_as_is)
 910         (tui_clear_source_content, tui_show_source_line)
 911         (tui_show_source_content, tui_source_window_base::refill)
 912         (tui_source_window_base::set_is_exec_point_at)
 913         (tui_source_window_base::set_is_exec_point_at)
 914         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 915         (tui_alloc_source_buffer, tui_line_is_displayed)
 916         (tui_addr_is_displayed): Change type of win_info.  Update.
 917         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 918         (tui_source_window_base::do_make_visible_with_new_height):
 919         Update.
 920         * tui/tui-source.c (tui_set_source_content)
 921         (tui_set_source_content_nil)
 922         (tui_source_window::do_scroll_vertical): Update.
 923         * tui/tui-layout.c (show_layout): Update.
 924         * tui/tui-disasm.c (tui_set_disassem_content)
 925         (tui_disasm_window::do_scroll_vertical): Update.
 926         * tui/tui-data.h (tui_win_content): Remove.
 927         (struct tui_gen_win_info) <content, content_size>: Remove.
 928         (struct tui_source_element): Add initializers and destructor.
 929         (union tui_which_element, struct tui_win_element): Remove.
 930         (struct tui_source_window_base) <content>: New field.
 931         (struct tui_data_window): Remove destructor.
 932         (tui_alloc_content, tui_free_win_content)
 933         (tui_free_all_source_wins_content): Don't declare.
 934         * tui/tui-data.c (tui_initialize_static_data): Update.
 935         (init_content_element, tui_alloc_content): Remove.
 936         (~tui_gen_win_info): Update.
 937         (~tui_data_window, tui_free_all_source_wins_content)
 938         (tui_free_win_content, free_content, free_content_elements):
 939         Remove.
 940
 941 2019-06-25  Tom Tromey  <tom@tromey.com>
 942
 943         * tui/tui-winsource.h (tui_clear_source_content)
 944         (tui_erase_source_content, tui_show_source_content): Change type
 945         of win_info.
 946         * tui/tui-winsource.c (tui_clear_source_content)
 947         (tui_erase_source_content, tui_show_source_content): Change type
 948         of win_info.
 949         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 950         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 951         win_info.
 952         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 953         win_info.
 954         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 955
 956 2019-06-25  Tom Tromey  <tom@tromey.com>
 957
 958         * tui/tui-winsource.c (tui_clear_source_content)
 959         (tui_source_window_base::set_is_exec_point_at): Update.
 960         * tui/tui-source.c (tui_set_source_content_nil): Update.
 961         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 962         a bool.
 963         * tui/tui-data.c (init_content_element): Update.
 964
 965 2019-06-25  Tom Tromey  <tom@tromey.com>
 966
 967         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 968         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 969         * tui/tui-layout.c (init_and_make_win): Update.
 970         * tui/tui.h (enum tui_win_type): Update.
 971         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 972         tui_win_is_auxillary.
 973         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 974         tui_win_is_auxillary.
 975
 976 2019-06-25  Tom Tromey  <tom@tromey.com>
 977
 978         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 979         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 980         (tui_delete_data_content_windows, tui_display_all_data)
 981         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 982         Update.
 983         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 984         * tui/tui-regs.c (tui_last_regs_line_no)
 985         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 986         (tui_show_registers): Update.
 987         (tui_show_register_group): Return void.  Update.
 988         (tui_display_registers_from, tui_display_reg_element_at_line)
 989         (tui_display_registers_from_line, tui_check_register_values):
 990         Update.
 991         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 992         member.
 993         (struct tui_data_window) <regs_content>: Now a std::vector.
 994         <regs_content_count>: Remove.
 995         (tui_add_content_elements, tui_free_data_content): Don't declare.
 996         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 997         (init_content_element): Remove DATA_WIN case.  Add assert.
 998         (tui_add_content_elements): Remove.
 999         (tui_data_window): Update.
1000         (tui_free_data_content): Remove.
1001         (free_content_elements): Remove DATA_WIN case.
1002
1003 2019-06-25  Tom Tromey  <tom@tromey.com>
1004
1005         * tui/tui-data.c (tui_data_item_window): Update.
1006         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1007         * tui/tui-windata.c (tui_display_all_data)
1008         (tui_display_data_from_line): Update.
1009         (tui_check_data_values): Remove.
1010         * tui/tui-regs.c (tui_show_register_group)
1011         (tui_display_reg_element_at_line): Update.
1012         * tui/tui-hooks.c (tui_register_changed)
1013         (tui_refresh_frame_and_register_information): Call
1014         tui_check_register_values.
1015         * tui/tui-data.h (struct tui_data_window) <data_content,
1016         data_content_count, data_type>: Remove.
1017         (enum tui_data_type): Remove.
1018
1019         * tui/tui-data.c (tui_data_window::clear_detail)
1020         (~tui_data_window): Update.
1021
1022 2019-06-25  Tom Tromey  <tom@tromey.com>
1023
1024         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1025         declare.
1026         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1027         Rename from tui_first_data_item_displayed.  Update.
1028         (tui_data_window::refresh_all)
1029         (tui_data_window::do_scroll_vertical): Update.
1030         * tui/tui-data.h (struct tui_data_window)
1031         <first_data_item_displayed>: Declare new method.
1032
1033 2019-06-25  Tom Tromey  <tom@tromey.com>
1034
1035         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1036         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1037         contents...
1038         (tui_initialize_static_data): ...here.
1039
1040 2019-06-25  Tom Tromey  <tom@tromey.com>
1041
1042         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1043         (tui_display_registers_from, tui_check_register_values): Update.
1044         (tui_display_register): Remove win_info parameter; update.
1045         (tui_get_register): Change type of parameters.
1046         * tui/tui-data.h (struct tui_data_element): Remove.
1047         (union tui_which_element) <data>: Remove.
1048         <data_window>: Change type.
1049         (struct tui_data_item_window): New.
1050         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1051         case.  Add assert.
1052         (~tui_data_item_window): New destructor.
1053         (free_content_elements): Remove DATA_ITEM_WIN case.
1054
1055 2019-06-25  Tom Tromey  <tom@tromey.com>
1056
1057         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1058         Remove.
1059
1060 2019-06-25  Tom Tromey  <tom@tromey.com>
1061
1062         * tui/tui-data.h (struct tui_command_element): Remove.
1063         (union tui_which_element) <command>: Remove.
1064         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1065         assert.
1066         (free_content_elements): Remove CMD_WIN case.
1067
1068 2019-06-25  Tom Tromey  <tom@tromey.com>
1069
1070         * tui/tui-layout.c (tui_set_layout): Update.
1071         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1072         * tui/tui-data.c (layout_def): Update.
1073
1074 2019-06-25  Tom Tromey  <tom@tromey.com>
1075
1076         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1077         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1078         (tui_source_window_base::set_new_height): Update.
1079         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1080         Update.
1081         (tui_set_locator_fullname, tui_set_locator_info)
1082         (tui_show_frame_info): Update.
1083         * tui/tui-source.c (tui_set_source_content)
1084         (tui_source_is_displayed): Update.
1085         * tui/tui-layout.c (show_source_disasm_command, show_data)
1086         (show_source_or_disasm_and_command): Update.
1087         * tui/tui-disasm.c (tui_set_disassem_content)
1088         (tui_get_begin_asm_address): Update.
1089         * tui/tui-data.h (struct tui_locator_element): Remove.
1090         (union tui_which_element) <locator>: Remove.
1091         (struct tui_locator_window): New.
1092         (tui_locator_win_info_ptr): Change return type.
1093         * tui/tui-data.c (_locator): Change type.
1094         (tui_locator_win_info_ptr): Change return type.
1095         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1096         (tui_alloc_content): Add assert.
1097
1098 2019-06-25  Tom Tromey  <tom@tromey.com>
1099
1100         * tui/tui-winsource.c
1101         (tui_exec_info_window::maybe_allocate_content): New method.
1102         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1103         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1104         (make_source_or_disasm_window): Add cast.
1105         * tui/tui-data.h (union tui_which_element) <simple_string>:
1106         Remove.
1107         (struct tui_source_info): New.
1108         (struct tui_source_window_base) <execution_info>: Change type.
1109         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1110         case, and add assert.
1111         (tui_alloc_content): Add assert.
1112
1113 2019-06-25  Tom Tromey  <tom@tromey.com>
1114
1115         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1116         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1117         * tui/tui-data.c (tui_alloc_win_info): Remove.
1118
1119 2019-06-25  Tom Tromey  <tom@tromey.com>
1120
1121         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1122         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1123         can_highlight.
1124
1125 2019-06-25  Tom Tromey  <tom@tromey.com>
1126
1127         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1128         make_visible_with_new_height method.
1129         (tui_win_info::make_visible_with_new_height): New method.
1130         (tui_source_window_base::do_make_visible_with_new_height)
1131         (tui_data_window::do_make_visible_with_new_height)
1132         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1133         (make_visible_with_new_height): Remove.
1134         (tui_resize_all, tui_adjust_win_heights): Use
1135         make_visible_with_new_height method.
1136         * tui/tui-data.h (struct tui_win_info)
1137         <do_make_visible_with_new_height, make_visible_with_new_height>:
1138         New methods.
1139         (struct tui_source_window_base, struct tui_data_window)
1140         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1141         methods.
1142
1143 2019-06-25  Tom Tromey  <tom@tromey.com>
1144
1145         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1146         method.
1147         (update_tab_width): Call update_tab_width method.
1148         * tui/tui-data.h (struct tui_win_info)
1149         (struct tui_source_window_base) <update_tab_width>: New methods.
1150
1151 2019-06-25  Tom Tromey  <tom@tromey.com>
1152
1153         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1154         parameter.
1155         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1156         parameter.
1157         (tui_gen_win_info::make_visible): Update.
1158         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1159         parameter.
1160         * tui/tui-data.h (enum tui_box): New enum.
1161         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1162
1163 2019-06-25  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1166         init_and_make_win for EXEC_INFO_WIN.
1167         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1168         longer inline.
1169         (struct tui_win_info) <~tui_win_info>: Inline.
1170         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1171         Don't declare.
1172         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1173         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1174         Remove.
1175         (tui_initialize_static_data): Update.
1176         (~tui_gen_win_info): Handle more cleanup here.
1177         (~tui_source_window_base): Delete "execution_info".
1178         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1179
1180 2019-06-25  Tom Tromey  <tom@tromey.com>
1181
1182         * tui/tui-layout.c (make_command_window): Don't set
1183         can_highlight.
1184         (show_source_disasm_command): Call the reset method.
1185         (show_data): Don't set can_highlight.  Call the reset method.
1186         (tui_gen_win_info::reset): Rename from init_gen_win_info
1187         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1188         (show_source_or_disasm_and_command): Call the reset method.
1189         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1190         (struct tui_cmd_window): Set can_highlight.
1191
1192 2019-06-25  Tom Tromey  <tom@tromey.com>
1193
1194         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1195         from make_visible.
1196         (tui_make_visible, tui_make_invisible): Rewrite.
1197         (tui_win_info::make_visible): Remove.
1198         (tui_source_window_base::make_visible): Update.
1199         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1200         method.  Moved from...
1201         (struct tui_win_info) <make_visible>: ...here.
1202
1203 2019-06-25  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui-winsource.c
1206         (tui_source_window_base::do_scroll_horizontal): Remove direction
1207         parameter.
1208         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1209         direction parameter.
1210         * tui/tui-win.c (tui_win_info::forward_scroll)
1211         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1212         (tui_win_info::right_scroll): Update.
1213         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1214         direction parameter.
1215         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1216         direction parameter.
1217         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1218         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1219         Remove direction parameter.
1220         (struct tui_source_window_base, struct tui_source_window)
1221         (struct tui_disasm_window, struct tui_data_window)
1222         (struct tui_cmd_window): Update.
1223
1224 2019-06-25  Tom Tromey  <tom@tromey.com>
1225
1226         * tui/tui-winsource.h (tui_set_exec_info_content)
1227         (tui_show_exec_info_content, tui_erase_exec_info_content)
1228         (tui_clear_exec_info_content, tui_update_exec_info): Change
1229         argument to tui_source_window_base.
1230         * tui/tui-winsource.c (tui_set_exec_info_content)
1231         (tui_show_exec_info_content, tui_erase_exec_info_content)
1232         (tui_clear_exec_info_content, tui_update_exec_info): Change
1233         argument to tui_source_window_base.
1234
1235 2019-06-25  Tom Tromey  <tom@tromey.com>
1236
1237         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1238         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1239
1240 2019-06-25  Tom Tromey  <tom@tromey.com>
1241
1242         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1243         check.
1244
1245 2019-06-25  Tom Tromey  <tom@tromey.com>
1246
1247         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1248         type to void.
1249         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1250         type to void.
1251         * tui/tui-source.c (tui_set_source_content): Update.
1252         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1253
1254 2019-06-25  Tom Tromey  <tom@tromey.com>
1255
1256         * tui/tui-win.c (window_name_completer, tui_set_focus)
1257         (tui_all_windows_info): Use name method.
1258         * tui/tui-data.h (struct tui_gen_win_info)
1259         (struct tui_source_window, struct tui_disasm_window)
1260         (struct tui_data_window, struct tui_cmd_window) <name>: New
1261         method.
1262         (tui_win_name): Don't declare.
1263         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1264         (tui_win_name): Remove.
1265
1266 2019-06-25  Tom Tromey  <tom@tromey.com>
1267
1268         * tui/tui-winsource.h (tui_update_source_window)
1269         (tui_update_source_window_as_is): Change parameter type.
1270         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1271         to be a tui_source_window_base.
1272         (tui_update_source_window_as_is): Likewise.
1273         * tui/tui-win.c (make_visible_with_new_height): Update.
1274
1275 2019-06-25  Tom Tromey  <tom@tromey.com>
1276
1277         * tui/tui-winsource.c (tui_erase_source_content)
1278         (tui_show_source_content, tui_show_exec_info_content)
1279         (tui_erase_exec_info_content): Use refresh_window method.
1280         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1281         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1282         from tui_refresh_win.
1283         (tui_data_window::refresh_window): New method.
1284         (tui_win_info::refresh, tui_source_window_base::refresh)
1285         (tui_refresh_all): Use refresh_window method.
1286         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1287         method.
1288         * tui/tui-regs.c (tui_display_register): Call refresh_window
1289         method.
1290         * tui/tui-layout.c (show_source_disasm_command)
1291         (show_source_or_disasm_and_command): Call refresh_window method.
1292         * tui/tui-data.h (struct tui_gen_win_info)
1293         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1294         New method.
1295
1296 2019-06-25  Tom Tromey  <tom@tromey.com>
1297
1298         * tui/tui.c (tui_rl_other_window, tui_enable)
1299         (tui_is_window_visible, tui_get_command_dimension): Update.
1300         * tui/tui-winsource.c (tui_update_source_window_as_is)
1301         (tui_clear_source_content, tui_erase_source_content)
1302         (tui_show_source_line, tui_source_window_base::refill)
1303         (tui_source_window_base::do_scroll_horizontal)
1304         (tui_source_window_base::set_is_exec_point_at)
1305         (tui_update_breakpoint_info, tui_set_exec_info_content)
1306         (tui_alloc_source_buffer, tui_line_is_displayed)
1307         (tui_addr_is_displayed): Update.
1308         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1309         (tui_check_and_display_highlight_if_needed)
1310         (tui_win_info::make_visible, tui_win_info::refresh)
1311         (tui_refresh_all): Update.
1312         * tui/tui-windata.c (tui_first_data_item_displayed)
1313         (tui_delete_data_content_windows, tui_erase_data_content)
1314         (tui_display_all_data, tui_data_window::refresh_all)
1315         (tui_check_data_values): Update.
1316         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1317         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1318         (tui_win_info::backward_scroll, tui_refresh_all_win)
1319         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1320         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1321         (tui_source_window_base::set_new_height)
1322         (tui_data_window::set_new_height)
1323         (make_invisible_and_set_new_height)
1324         (make_visible_with_new_height, new_height_ok)
1325         (parse_scrolling_args): Update.
1326         * tui/tui-stack.c (tui_show_frame_info): Update.
1327         * tui/tui-source.c (tui_set_source_content)
1328         (tui_set_source_content_nil, tui_source_is_displayed)
1329         (tui_source_window::do_scroll_vertical): Update.
1330         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1331         (tui_display_registers_from, tui_display_reg_element_at_line)
1332         (tui_check_register_values, tui_reg_command): Update.
1333         * tui/tui-layout.c (tui_default_win_height)
1334         (show_source_disasm_command, show_data, init_and_make_win)
1335         (show_source_or_disasm_and_command): Update.
1336         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1337         (tui_redisplay_readline, tui_mld_flush)
1338         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1339         (tui_getc): Update.
1340         * tui/tui-disasm.c (tui_set_disassem_content)
1341         (tui_disasm_window::do_scroll_vertical): Update.
1342         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1343         Now virtual.
1344         (struct tui_win_info): Derive from tui_gen_win_info.
1345         <~tui_win_info>: Mark as override.
1346         <generic>: Remove member.
1347         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1348         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1349         (~tui_data_window, ~tui_win_info)
1350         (tui_free_all_source_wins_content): Update.
1351         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1352
1353 2019-06-25  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui-layout.c (init_and_make_win): Use new.
1356         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1357         destructor, initializers.
1358         (tui_alloc_generic_win_info): Don't declare.
1359         * tui/tui-data.c (_locator): Add argument to constructor.
1360         (source_win, disasm_win): New globals.
1361         (exec_info): Remove.
1362         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1363         Update.
1364         (tui_alloc_generic_win_info): Remove.
1365         (init_content_element): Use new.
1366         (tui_win_info::tui_win_info): Update.
1367         (free_content_elements) <case DATA_WIN>: Use delete.
1368
1369 2019-06-25  Tom Tromey  <tom@tromey.com>
1370
1371         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1372         * tui/tui-windata.c (tui_first_data_item_displayed)
1373         (tui_delete_data_content_windows): Update.
1374         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1375         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1376         (tui_display_registers_from, tui_check_register_values): Update.
1377         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1378         pointer.
1379         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1380         window.
1381         (tui_free_data_content): Update.
1382         (free_content_elements) <case DATA_WIN>: Free the window.
1383
1384 2019-06-25  Tom Tromey  <tom@tromey.com>
1385
1386         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1387         Update.
1388         * tui/tui-layout.c (make_command_window)
1389         (show_source_disasm_command, show_data, init_and_make_win)
1390         (show_source_or_disasm_and_command): Update.
1391         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1392         method.
1393         <can_highight, is_highlighted>: Now bool.
1394         (tui_set_win_highlight): Don't declare.
1395         * tui/tui-data.c (tui_set_win_highlight): Remove.
1396
1397 2019-06-25  Tom Tromey  <tom@tromey.com>
1398
1399         * tui/tui-wingeneral.c (make_visible): Remove check of window
1400         type.
1401
1402 2019-06-25  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-win.c (tui_win_info::max_height)
1405         (tui_cmd_window::max_height): New methods.
1406         (new_height_ok): Call max_height.
1407         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1408         <max_height>: New method.
1409
1410 2019-06-25  Tom Tromey  <tom@tromey.com>
1411
1412         * tui/tui-win.c (tui_source_window_base::set_new_height)
1413         (tui_data_window::set_new_height): New methods.
1414         (make_invisible_and_set_new_height): Call set_new_height method.
1415         * tui/tui-data.h (struct tui_win_info)
1416         (struct tui_source_window_base, struct tui_data_window)
1417         <set_new_height>: New method.
1418
1419 2019-06-25  Tom Tromey  <tom@tromey.com>
1420
1421         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1422         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1423         tui_refresh_data_win.
1424         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1425         method.
1426         (tui_refresh_all_win): Call the refresh_all method.
1427         (tui_set_focus): Likewise.
1428         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1429         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1430         Likewise.
1431
1432 2019-06-25  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-winsource.h (tui_refill_source_window)
1435         (tui_set_is_exec_point_at): Don't declare.
1436         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1437         (tui_source_window_base::refill): Rename from
1438         tui_refill_source_window.
1439         (tui_source_window_base::do_scroll_horizontal): Update.
1440         (tui_source_window_base::set_is_exec_point_at): Rename from
1441         tui_set_is_exec_point_at.
1442         (tui_update_all_breakpoint_info): Update.
1443         * tui/tui-stack.c (tui_show_frame_info): Update.
1444         * tui/tui-layout.c (show_data): Add cast.
1445         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1446         * tui/tui-data.h (struct tui_source_window_base) <refill,
1447         set_is_exec_point_at>: New methods.
1448         (tui_source_windows, tui_add_to_source_windows): Update types.
1449         (tui_add_to_source_windows): Remove redundant declaration.
1450         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1451         (tui_source_windows): Change return type.
1452         (tui_clear_source_windows_detail): Update.
1453         (tui_add_to_source_windows): Change type of parameter.
1454         (tui_free_all_source_wins_content): Update.
1455
1456 2019-06-25  Tom Tromey  <tom@tromey.com>
1457
1458         * tui/tui-wingeneral.c (tui_win_info::refresh)
1459         (tui_source_window_base::refresh): New methods.
1460         (tui_refresh_all): Call the refresh method.
1461         * tui/tui-data.h (struct tui_win_info)
1462         (struct tui_source_window_base) <refresh>: New method.
1463
1464 2019-06-25  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui.h (tui_is_window_visible): Return bool.
1467         * tui/tui.c (tui_is_window_visible): Return bool.
1468         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1469         (tui_make_visible, tui_make_invisible)
1470         (tui_win_info::make_visible)
1471         (tui_source_window_base::make_visible, make_all_visible)
1472         (tui_make_all_visible, tui_make_all_invisible): Update.
1473         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1474         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1475         bool.
1476         (struct tui_win_info, struct tui_source_window_base)
1477         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1478         * tui/tui-data.c (tui_init_generic_part): Update.
1479
1480 2019-06-25  Tom Tromey  <tom@tromey.com>
1481
1482         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1483         (tui_source_window_base::make_visible): New methods.
1484         (make_all_visible): Make method call.
1485         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1486         (struct tui_source_window_base, struct tui_cmd_window): Override
1487         make_visible.
1488         (tui_win_is_source_type): Don't declare.
1489         * tui/tui-data.c (tui_win_is_source_type): Remove.
1490
1491 2019-06-25  Tom Tromey  <tom@tromey.com>
1492
1493         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1494         NULL check.
1495
1496 2019-06-25  Tom Tromey  <tom@tromey.com>
1497
1498         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1499         Inline constructor.  Add initializers for members.
1500         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1501         constructors; now inline in class.
1502
1503 2019-06-25  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui-regs.c (tui_show_registers): Update.
1506         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1507         bool.
1508         * tui/tui-data.c (tui_data_window::clear_detail)
1509         (tui_data_window): Update.
1510
1511 2019-06-25  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui-windata.c (tui_display_all_data)
1514         (tui_display_data_from_line, tui_display_data_from)
1515         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1516         Update.
1517         * tui/tui-regs.c (tui_last_regs_line_no)
1518         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1519         (tui_show_registers, tui_show_register_group)
1520         (tui_display_registers_from, tui_display_reg_element_at_line)
1521         (tui_display_registers_from_line, tui_check_register_values)
1522         (tui_reg_next, tui_reg_prev): Update.
1523         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1524         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1525         tui_data_window.
1526         (struct tui_win_info) <detail>: Remove.  Add new fields from
1527         tui_data_info.
1528         (TUI_DATA_WIN): Add cast.
1529         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1530         (~tui_data_window): Simplify.
1531
1532 2019-06-25  Tom Tromey  <tom@tromey.com>
1533
1534         * tui/tui-layout.c (show_source_disasm_command)
1535         (show_source_or_disasm_and_command): Update.
1536         * tui/tui-io.c (update_cmdwin_start_line)
1537         (tui_redisplay_readline): Update.
1538         * tui/tui-data.h (struct tui_command_info): Remove.
1539         (struct tui_win_info) <detail>: Remove command_info member.
1540         (struct tui_data_window) <start_line>: New member, from
1541         tui_command_info.
1542         (TUI_CMD_WIN): Add casts.
1543
1544 2019-06-25  Tom Tromey  <tom@tromey.com>
1545
1546         * tui/tui-winsource.c (tui_update_source_window)
1547         (tui_refill_source_window)
1548         (tui_source_window_base::do_scroll_horizontal)
1549         (tui_update_breakpoint_info, tui_set_exec_info_content)
1550         (tui_show_exec_info_content, tui_erase_exec_info_content)
1551         (tui_clear_exec_info_content): Update.
1552         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1553         Update.
1554         * tui/tui-win.c (make_invisible_and_set_new_height)
1555         (make_visible_with_new_height): Update.
1556         * tui/tui-source.c (tui_set_source_content)
1557         (tui_show_symtab_source): Update.
1558         * tui/tui-layout.c (extract_display_start_addr)
1559         (show_source_disasm_command, show_data)
1560         (make_source_or_disasm_window)
1561         (show_source_or_disasm_and_command): Update.
1562         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1563         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1564         "gdbarch".
1565         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1566         to tui_source_window_base.
1567         (struct tui_win_info) <detail>: Remove source_info member.
1568         (struct tui_source_window_base) <has_locator>: Inline.
1569         Move contents from tui_source_info; rename has_locator member to
1570         m_has_locator.
1571         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1572         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1573         header file.
1574         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1575         Simplify.
1576         (tui_free_all_source_wins_content): Cast to
1577         tui_source_window_base.
1578
1579 2019-06-25  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-win.c (make_invisible_and_set_new_height)
1582         (make_visible_with_new_height): Call has_locator method.
1583         * tui/tui-layout.c (show_source_disasm_command, show_data)
1584         (show_source_or_disasm_and_command): Update for bool change.
1585         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1586         (tui_win_info) <has_locator>: New method.
1587         (struct tui_source_window_base) <has_locator>: New method.
1588         (tui_win_has_locator): Don't declare.
1589         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1590         from tui_win_has_locator.
1591         (tui_source_window_base): Use false, not FALSE.
1592
1593 2019-06-25  Tom Tromey  <tom@tromey.com>
1594
1595         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1596         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1597         clear_detail method directly.
1598         (tui_clear_win_detail): Remove.
1599
1600 2019-06-25  Tom Tromey  <tom@tromey.com>
1601
1602         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1603         "this", not TUI_DISASM_WIN.
1604
1605 2019-06-25  Tom Tromey  <tom@tromey.com>
1606
1607         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1608         declare.
1609         * tui/tui-winsource.c
1610         (tui_source_window_base::do_scroll_horizontal): Rename from
1611         tui_horizontal_source_scroll.
1612         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1613         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1614         from tui_vertical_data_scroll.
1615         * tui/tui-win.h (tui_scroll): Don't declare.
1616         * tui/tui-win.c (tui_win_info::forward_scroll)
1617         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1618         (tui_win_info::right_scroll): Rename and update.
1619         (tui_scroll_forward_command, tui_scroll_backward_command)
1620         (tui_scroll_left_command, tui_scroll_right_command): Update.
1621         (tui_scroll): Remove.
1622         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1623         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1624         from tui_vertical_source_scroll.
1625         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1626         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1627         from tui_vertical_disassem_scroll.
1628         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1629         do_scroll_horizontal>: New methods.
1630         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1631         Likewise.
1632         (struct tui_source_window_base): Add do_scroll_horizontal.
1633         (struct tui_source_window, struct tui_disasm_window): Add
1634         do_scroll_vertical.
1635         (struct tui_data_window, struct tui_cmd_window): Add
1636         do_scroll_horizontal and do_scroll_vertical.
1637         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1638
1639 2019-06-25  Tom Tromey  <tom@tromey.com>
1640
1641         * tui/tui-data.h (struct tui_source_window_base): New struct.
1642         (struct tui_source_window): Derive from tui_source_window_base.
1643         (struct tui_disasm_window): New struct.
1644         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1645         from tui_source_window::clear_detail.
1646         (tui_source_window_base): Rename from tui_source_window.
1647         (~tui_source_window_base): Rename from ~tui_source_window.
1648         (tui_alloc_win_info): Create a tui_disasm_window.
1649
1650 2019-06-25  Tom Tromey  <tom@tromey.com>
1651
1652         * tui/tui-data.h (struct tui_source_window)
1653         (struct tui_data_window): Declare destructors.
1654         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1655         destructors.
1656         (tui_win_info): Simplify.
1657
1658 2019-06-25  Tom Tromey  <tom@tromey.com>
1659
1660         * tui/tui-winsource.c (tui_display_main)
1661         (tui_update_source_windows_with_addr)
1662         (tui_update_all_breakpoint_info): Update.
1663         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1664         (new_height_ok, parse_scrolling_args): Update.
1665         * tui/tui-stack.c (tui_show_frame_info): Update.
1666         * tui/tui-data.h (struct tui_list): Remove.
1667         (tui_source_windows): Return a reference to a std::vector.
1668         * tui/tui-data.c (source_windows): Now a std::vector.
1669         (tui_source_windows): Change return type.
1670         (tui_clear_source_windows): Rewrite.
1671         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1672         (tui_free_all_source_wins_content): Rewrite.
1673
1674 2019-06-25  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1677         (struct tui_data_window, struct tui_cmd_window): Declare
1678         clear_detail method.
1679         * tui/tui-data.c (tui_source_window::clear_detail)
1680         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1681         methods.
1682         (tui_clear_win_detail): Simplify.
1683
1684 2019-06-25  Tom Tromey  <tom@tromey.com>
1685
1686         * tui/tui-layout.c (make_source_window, make_disasm_window)
1687         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1688         Return the new window.
1689         (show_source_disasm_command, show_data)
1690         (show_source_or_disasm_and_command): Update.
1691
1692 2019-06-25  Tom Tromey  <tom@tromey.com>
1693
1694         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1695         parameter.  Return the new window.
1696         (show_source_disasm_command): Update and remove NULL check.
1697         (show_source_or_disasm_and_command): Update.
1698
1699 2019-06-25  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1702
1703 2019-06-25  Tom Tromey  <tom@tromey.com>
1704
1705         * tui/tui-data.h (struct tui_win_info): Make constructor
1706         protected.  Make destructor virtual.  Add initializers.
1707         (tui_source_window, tui_data_window, tui_cmd_window): New
1708         classes.
1709         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1710         constructor.  Add "type" parameter.
1711         (tui_source_window, tui_data_window, tui_cmd_window): New
1712         constructors.
1713         (tui_alloc_win_info): Instantiate the appropriate subclass.
1714
1715 2019-06-25  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-win.c (tui_resize_all): Use delete.
1718         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1719         destructor.
1720         (tui_free_window): Don't declare.
1721         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1722         Update.
1723
1724 2019-06-25  Tom Tromey  <tom@tromey.com>
1725
1726         * tui/tui-data.h (struct tui_win_info): Add constructor.
1727         * tui/tui-data.c (tui_alloc_win_info): Use new.
1728         (tui_free_window): Use delete.
1729
1730 2019-06-22  Tom Tromey  <tom@tromey.com>
1731
1732         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1733         declare.
1734         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1735
1736 2019-06-22  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1739         declare.
1740         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1741
1742 2019-06-22  Tom de Vries  <tdevries@suse.de>
1743
1744         * dwarf2read.c (create_addrmap_from_aranges)
1745         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1746         instead of '%zu'.
1747
1748 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1749
1750         * dwarf2read.h (dwarf2_section_info_def): Remove.
1751         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1752         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1753         std::vector<dwarf2_section_info>.
1754         (struct dwo_file) <~dwo_file>: Remove.
1755         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1756         types field.
1757         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1758         (dwarf2_read_debug_names): Likewise.
1759         (create_debug_types_hash_table): Change parameter type to
1760         array_view, adjust code accordingly.
1761         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1762         (partial_die_info::fixup): Likewise.
1763         (determine_prefix): Likewise.
1764         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1765
1766 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1767
1768         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1769         gdb_bfd_ref_ptr.
1770         <~dwo_file>: Remove call to gdb_bfd_unref.
1771         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1772         gdb_bfd_ref_ptr::get.
1773
1774 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1775
1776         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1777         type to htab_up.
1778         * dwarf2read.c (struct dwo_file): Initialize fields.
1779         <~dwo_file>: New.
1780         (free_dwo_file): Remove, move content to ~dwo_file.
1781         (struct dwo_file_deleter): Remove.
1782         (dwo_file_up>: Remove custom deleter.
1783         (free_dwo_files): Remove.
1784         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1785         dwo_files.
1786         (process_skeletonless_type_units): Call unique_ptr::get.
1787         (allocate_dwo_file_hash_table): Add deleter to created hash
1788         table.  Change return type to htab_up.
1789         (lookup_dwo_file_slot): Don't memset dwo_file, call
1790         unique_ptr::get.
1791         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1792         (create_dwo_unit_in_dwp_v2): Likewise.
1793         (open_and_init_dwo_file): Likewise.
1794         (free_dwo_file_from_slot): Remove.
1795
1796 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1797
1798         * dwarf2read.h (struct dwarf2_section_info) <readin,
1799         is_virtual>: Change type to bool.
1800         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1801         true instead of 1.
1802
1803 2019-06-19  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-data.h (tui_init_content_element): Don't declare.
1806
1807 2019-06-19  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-data.h (tui_init_win_info): Don't declare.
1810
1811 2019-06-19  Tom de Vries  <tdevries@suse.de>
1812
1813         * dwarf2read.h (abstract_to_concrete): Change type to
1814         std::unordered_map<sect_offset, std::vector<sect_offset>,
1815         gdb::hash_enum<sect_offset>>.
1816
1817 2019-06-19  Tom Tromey  <tromey@adacore.com>
1818
1819         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1820         EVAL_AVOID_SIDE_EFFECTS specially.
1821
1822 2019-06-19  Tom Tromey  <tromey@adacore.com>
1823
1824         * source-cache.c (highlighter): New global.
1825         (source_cache::get_source_lines): Create a highlighter on demand.
1826
1827 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1828
1829         * defs.h (deprecated_interactive_hook): Delete declaration.
1830         * interps.c (clear_interpreter_hooks): Remove use of
1831         deprecated_interactive_hook.
1832         * top.c (deprecated_interactive_hook): Delete definition.
1833         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1834
1835 2019-06-18  Tom de Vries  <tdevries@suse.de>
1836
1837         PR gdb/24515
1838         * dwarf2read.h (abstract_to_concrete): Change type from
1839         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1840         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1841         * dwarf2read.c (read_variable): Update.
1842         (dwarf2_fetch_die_loc_sect_off): Update.
1843
1844 2019-06-17  Tom de Vries  <tdevries@suse.de>
1845
1846         PR gdb/24617
1847         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1848         accessing parent[parent_len - 1].
1849
1850 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1851
1852         PR gdb/24364
1853         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1854         call dtrace_process_dof with NULL dof.
1855
1856 2019-06-16  Tom de Vries  <tdevries@suse.de>
1857
1858         PR gdb/24445
1859         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1860
1861 2019-06-16  Tom Tromey  <tom@tromey.com>
1862
1863         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1864         (make_all_visible): Use address of member.
1865
1866 2019-06-16  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1869         (tui_free_window, free_content, free_content_elements): Remove
1870         unnecessary cast.
1871         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1872         cast.
1873         * tui/tui-regs.c (tui_show_register_group)
1874         (tui_display_registers_from, tui_display_reg_element_at_line):
1875         Remove unnecessary cast.
1876
1877 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1878
1879         * linux-nat.c (normal_mask): Delete.
1880         (_initialize_linux_nat): Don't initialise normal_mask.
1881
1882 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1883
1884         PR gdb/24445
1885         * dwarf-index-write.h (write_psymtabs_to_index): Add
1886         dwz_basename parameter.
1887         * dwarf-index-write.c (write_gdbindex): Move file writing to
1888         write_gdbindex_1.  Change return type void.
1889         (assert_file_size): Move up, remove filename parameter.
1890         (write_gdbindex_1): New function.
1891         (write_debug_names): Change return type to void, call
1892         assert_file_size.
1893         (struct index_wip_file): New struct.
1894         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1895         file logic to index_wip_file.  Write index for dwz file if
1896         needed.
1897         (save_gdb_index_command): Pass basename of dwz file, if present.
1898         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1899         build-id of dwz file, if present.
1900         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1901         (dwarf2_get_dwz_file): Likewise.
1902         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1903         (dwarf2_get_dwz_file): Likewise.
1904
1905 2019-06-16  Tom Tromey  <tom@tromey.com>
1906
1907         * coffread.c (process_coff_symbol): Use xstrdup.
1908         * value.c (create_internalvar): Use xstrdup.
1909
1910 2019-06-16  Tom Tromey  <tom@tromey.com>
1911
1912         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1913         * breakpoint.c (stopin_command, stopat_command)
1914         (until_break_command, decode_location_default): Remove unnecessary
1915         cast.
1916         * utils.c (subset_compare): Remove unnecessary cast.
1917         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1918         cast.
1919         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1920         cast.
1921         * infcmd.c (path_command): Remove unnecessary cast.
1922         * coffread.c (decode_type): Remove unnecessary cast.
1923         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1924         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1925         * tui/tui-stack.c (tui_show_locator_content)
1926         (tui_show_frame_info): Remove unnecessary cast.
1927         * tui/tui-win.c (tui_scroll_forward_command)
1928         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1929         (parse_scrolling_args): Remove unnecessary cast.
1930         * tui/tui-data.c (init_win_info, tui_del_window)
1931         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1932         (free_content_elements): Remove unnecessary cast.
1933         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1934         unnecessary cast.
1935         * tui/tui-source.c (tui_set_source_content)
1936         (tui_vertical_source_scroll): Remove unnecessary cast.
1937         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1938         cast.
1939         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1940         * tui/tui-regs.c (tui_display_registers_from)
1941         (tui_display_register): Remove unnecessary cast.
1942         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1943         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1944         (make_visible): Remove unnecessary cast.
1945         * tui/tui-winsource.c (tui_erase_source_content)
1946         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1947         unnecessary cast.
1948         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1949         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1950         * stabsread.c (read_type, read_array_type, read_range_type):
1951         Remove unnecessary cast.
1952         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1953         (parse_symbol, parse_type, upgrade_type, parse_external)
1954         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1955         unnecessary cast.
1956         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1957
1958 2019-06-16  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-data.c (tui_alloc_generic_win_info)
1961         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1962         checks.
1963
1964 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1965             Andrew Burgess  <andrew.burgess@embecosm.com>
1966
1967         * f-typeprint.c (f_print_type): Don't return early for not
1968         associated or not allocated types.
1969         (f_type_print_varspec_suffix): Add print_rank parameter and print
1970         ranks of array types in case they dangling.
1971         (f_type_print_base): Add print_rank parameter.
1972
1973 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1974
1975         * NEWS: Mention new MI commands.
1976         * break-catch-throw.c (enum exception_event_kind): Move to
1977         breakpoint.h.
1978         (print_mention_exception_catchpoint): Output text as a single
1979         message.
1980         (catch_exception_command_1): Rename to...
1981         (catch_exception_event): ...this, make non-static, update header
1982         command, and change some parameter types.
1983         (catch_catch_command): Update for changes to
1984         catch_exception_command_1.
1985         (catch_throw_command): Likewise.
1986         (catch_rethrow_command): Likewise.
1987         * breakpoint.c (enum exception_event_kind): Delete.
1988         * breakpoint.h (enum exception_event_kind): Moved here from
1989         break-catch-throw.c.
1990         (catch_exception_event): Declare.
1991         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1992         (mi_cmd_catch_throw): New function.
1993         (mi_cmd_catch_rethrow): New function.
1994         (mi_cmd_catch_catch): New function.
1995         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1996         'catch-catch' entries.
1997         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1998         (mi_cmd_catch_rethrow): Declare.
1999         (mi_cmd_catch_catch): Declare.
2000
2001 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2002
2003         * annotate.c (annotate_source_line): Change return type to void,
2004         update implementation to match.
2005         * annotate.h (annotate_source_line): Change return type to void,
2006         update header comment.
2007         * stack.c (print_frame_info): Don't change what frame information
2008         is printed based on whether annotations are on or not.
2009
2010 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2011
2012         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2013         (annotate_source): Make static.
2014         (annotate_source_line): Moved from source.c and renamed from
2015         identify_source_line.  Update the return type.
2016         * annotate.h (annotate_source): Delete declaration.
2017         (annotate_source_line): Declaration moved from source.h, and
2018         renamed from identify_source_line.  Return type updated.
2019         * source.c (identify_source_line): Moved to annotate.c and renamed
2020         to annotate_source_line.
2021         (info_line_command): Remove check of annotation_level.
2022         * source.h (identify_source_line): Move declaration to annotate.h
2023         and rename to annotate_source_line.
2024         * stack.c: Add 'annotate.h' include.
2025         (print_frame_info): Remove check of annotation_level before
2026         calling annotate_source_line.
2027
2028 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2029
2030         * source-cache.c (source_cache::get_plain_source_lines): Use
2031         open_source_file_with_line_charpos instead of just
2032         open_source_file, remove call to find_source_lines.
2033         (source_cache::get_source_lines): Likewise.
2034         * source.c (find_source_lines): Make static.
2035         (get_filename_and_charpos): Renamed into...
2036         (open_source_file_with_line_charpos): ..this along with changes to
2037         return a scoped_fd, and some other minor clean ups.
2038         (identify_source_line): Use open_source_file_with_line_charpos.
2039         (search_command_helper): Use open_source_file_with_line_charpos
2040         instead of just open_source_file, remove call to
2041         find_source_lines.
2042         * source.h (open_source_file_with_line_charpos): Declare new
2043         function.
2044         (find_source_lines): Delete declaration.
2045
2046 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2047
2048         * source.c (get_filename_and_charpos): Remove fullname
2049         parameter.
2050         (identify_source_line): Update call to get_filename_and_charpos.
2051
2052 2019-06-14  Tom Tromey  <tromey@adacore.com>
2053
2054         PR gdb/24502:
2055         * ui-style.h (skip_ansi_escape): Update comment.
2056         * ui-file.h (class no_terminal_escape_file): New class.
2057         * ui-file.c (no_terminal_escape_file::write)
2058         (no_terminal_escape_file::puts): New methods.
2059         * cli/cli-logging.c (handle_redirections): Use
2060         no_terminal_escape_file.
2061
2062 2019-06-14  Tom Tromey  <tromey@adacore.com>
2063
2064         * NEWS: Move convenience variable news above Python news.
2065
2066 2019-06-14  Tom Tromey  <tom@tromey.com>
2067
2068         * gnulib: Move directory to top-level.
2069         * configure.ac: Don't configure gnulib.
2070         * configure: Rebuild.
2071         * common/common-defs.h: Use new path to gnulib.
2072         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2073         (GNULIB_H): Remove.
2074         (INCGNU): Look in new gnulib location.
2075         (HFILES_NO_SRCDIR): Remove gnulib files.
2076         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2077         (generated_files): Remove GNULIB_H.
2078         ($(LIBGNU), all-lib): Remove targets.
2079         (distclean): Don't mention GNULIB_BUILDDIR.
2080         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2081
2082 2019-06-14  Tom Tromey  <tromey@adacore.com>
2083
2084         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2085         Warn if symbol file does not provide any symbols.
2086
2087 2019-06-14  Tom Tromey  <tromey@adacore.com>
2088
2089         * source.c (find_and_open_source): Respect basenames_may_differ.
2090
2091 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2092
2093         * annotate.c (annotate_breakpoints_invalid): Make use of
2094         scoped_restore_terminal_state.
2095         (annotate_frames_invalid): Likewise.
2096
2097 2019-06-14  Tom Tromey  <tromey@adacore.com>
2098
2099         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2100         allow assignment to an internalvar.
2101
2102 2019-06-14  Tom Tromey  <tromey@adacore.com>
2103
2104         * ada-lex.l: Allow "_" in attribute names.
2105
2106 2019-06-14  Tom Tromey  <tromey@adacore.com>
2107
2108         PR gdb/24653:
2109         * regcache.c (registers_changed): Don't call alloca.
2110         * top.c (execute_command): Don't call alloca.
2111
2112 2019-06-13  Pedro Alves  <palves@redhat.com>
2113
2114         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2115         'expression'.  When parsing an expression, error out if there's
2116         junk after "unlimited".
2117         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2118         (do_set_command): Adjust calls to is_unlimited_literal.
2119
2120 2019-06-13  Pedro Alves  <palves@redhat.com>
2121
2122         * compile/compile.c (make_compile_options_def_group): Add braces
2123         around array_view initializer.
2124         * thread.c (make_thread_apply_all_options_def_group)
2125         (make_thread_apply_all_options_def_group): Likewise.
2126
2127 2019-06-13  Pedro Alves  <palves@redhat.com>
2128
2129         * NEWS (New commands): Mention "maint test-options
2130         require-delimiter", "maint test-options unknown-is-error", "maint
2131         test-options unknown-is-operand" and "maint show
2132         test-options-completion-result".
2133         (New command options, command completion): New section.
2134         (Completion improvements): New section.
2135         Mention that you can abbreviate "unlimited".
2136
2137 2019-06-13  Pedro Alves  <palves@redhat.com>
2138
2139         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2140         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2141         * unittests/cli-utils-selftests.c (test_parse_flags)
2142         (test_parse_flags_qcs): Delete.
2143         (test_cli_utils): Don't call deleted functions.
2144
2145 2019-06-13  Pedro Alves  <palves@redhat.com>
2146
2147         * thread.c: Include "cli/cli-option.h".
2148         (tp_array_compar_ascending): Global.
2149         (tp_array_compar): Delete function.
2150         (tp_array_compar_ascending, tp_array_compar_descending): New
2151         functions.
2152         (ascending_option_def, qcs_flag_option_def)
2153         (thr_qcs_flags_option_defs)
2154         (make_thread_apply_all_options_def_group)
2155         (make_thread_apply_options_def_group): New.
2156         (thread_apply_all_command): Use gdb::option::process_options.
2157         (thread_apply_command_completer)
2158         (thread_apply_all_command_completer): New.
2159         (thread_apply_command): Use gdb::option::process_options.
2160         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2161         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2162         to generate help text of "thread apply".  Adjust "taas"'s help.
2163         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2164         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2165
2166 2019-06-13  Pedro Alves  <palves@redhat.com>
2167
2168         * thread.c (thread_apply_command): Check for invalid TID with
2169         isdigit instead of !isalpha.
2170
2171 2019-06-13  Pedro Alves  <palves@redhat.com>
2172
2173         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2174         (validate_flags_qcs): New.
2175         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2176         (validate_flags_qcs): Declare.
2177         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2178         (make_frame_apply_options_def_group): New.
2179         (frame_apply_command_count): Process options with
2180         gdb::option::process_options.
2181         (frame_apply_completer): New.
2182         (frame_apply_level_completer, frame_apply_all_completer)
2183         (frame_apply_completer): New.
2184         (_initialize_stack): Update help of "frame apply", "frame apply
2185         level", "frame apply all" and "faas" to mention supported options
2186         and install command completers.
2187         * stack.h (frame_apply_all_completer): Declare.
2188         * thread.c: Include "stack.h".
2189         (tfaas_command): Add "--".
2190         (_initialize_thread): Update help "tfaas" to mention supported
2191         options and install command completer.
2192
2193 2019-06-13  Pedro Alves  <palves@redhat.com>
2194
2195         * completer.c (complete_nested_command_line): New.
2196         (gdb_completion_word_break_characters_throw): Add assertion.
2197         * completer.h (complete_nested_command_line): Declare.
2198
2199 2019-06-13  Pedro Alves  <palves@redhat.com>
2200
2201         * stack.c (parse_backtrace_qualifiers): New.
2202         (backtrace_command): Use it.
2203         (backtrace_command_completer): Complete on qualifiers.
2204
2205 2019-06-13  Pedro Alves  <palves@redhat.com>
2206
2207         * frame.c: Include "cli/cli-option.h.
2208         (user_set_backtrace_options): New.
2209         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2210         Delete.
2211         (get_prev_frame): Adjust.
2212         (boolean_option_def, uinteger_option_def)
2213         (set_backtrace_option_defs): New.
2214         (_initialize_frame): Adjust and use
2215         gdb::option::add_setshow_cmds_for_options to install "set
2216         backtrace past-main" and "set backtrace past-entry".
2217         * frame.h: Include "cli/cli-option.h".
2218         (struct frame_print_options): Forward declare.
2219         (print_frame_arguments_all, print_frame_arguments_scalars)
2220         (print_frame_arguments_none): Declare.
2221         (print_entry_values): Delete declaration.
2222         (struct frame_print_options, user_frame_print_options): New.
2223         (struct set_backtrace_options): New.
2224         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2225         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2226         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2227         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2228         (list_args_or_locals): Add frame_print_options parameter.
2229         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2230         * python/py-framefilter.c (enumerate_args): Pass down
2231         USER_FRAME_PRINT_OPTIONS.
2232         * stack.c: Include "cli/cli-option.h".
2233         (print_frame_arguments_all, print_frame_arguments_scalars)
2234         (print_frame_arguments_none): Declare.
2235         (print_raw_frame_arguments, print_entry_values): Delete.
2236         (user_frame_print_options): New.
2237         (boolean_option_def, enum_option_def, frame_print_option_defs):
2238         New.
2239         (struct backtrace_cmd_options): New.
2240         (bt_flag_option_def): New.
2241         (backtrace_command_option_defs): New.
2242         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2243         (print_frame_arg, read_frame_arg, print_frame_args)
2244         (print_frame_info, print_frame): Add frame_print_options parameter
2245         and use it.
2246         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2247         (backtrace_command_1): Add frame_print_options and
2248         backtrace_cmd_options parameters and use them.
2249         (make_backtrace_options_def_group): New.
2250         (backtrace_command): Process command options with
2251         gdb::option::process_options.
2252         (backtrace_command_completer): New.
2253         (_initialize_stack): Extend "backtrace"'s help to mention
2254         supported options.  Install completer for "backtrace".
2255         Install some settings commands with add_setshow_cmds_for_options.
2256
2257 2019-06-13  Pedro Alves  <palves@redhat.com>
2258
2259         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2260         and that "set/show print raw frame-arguments" are now deprecated.
2261
2262         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2263         command.
2264         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2265         * stack.c (_initialize_stack): Install "set/show print
2266         raw-frame-arguments", and deprecate "set/show print raw
2267         frame-arguments".
2268         * valprint.c (_initialize_valprint): Deprecate "set/show print
2269         raw".
2270
2271 2019-06-13  Pedro Alves  <palves@redhat.com>
2272
2273         * compile/compile.c (struct compile_options): New.
2274         (compile_flag_option_def, compile_command_option_defs)
2275         (make_compile_options_def_group): New.
2276         (compile_file_command): Handle options with
2277         gdb::option::process_options.
2278         (compile_file_command_completer): New function.
2279         (compile_code_command): Handle options with
2280         gdb::option::process_options.
2281         (compile_code_command_completer): New function.
2282         (_initialize_compiler): Install completers for "compile code" and
2283         "compile file".  Mention available options in "compile code" and
2284         "compile code"'s help.
2285         * completer.c (advance_to_completion_word): New, factored out from
2286         ...
2287         (advance_to_expression_complete_word_point): ... this.
2288         (advance_to_filename_complete_word_point): New.
2289         * completer.h (advance_to_filename_complete_word_point): New
2290         declaration.
2291
2292 2019-06-13  Pedro Alves  <palves@redhat.com>
2293
2294         * compile/compile.c: Include "cli/cli-option.h".
2295         (compile_print_value): Scope data pointer is now a
2296         value_print_options pointer; adjust.
2297         (compile_print_command): Process options.  Scope data pointer is
2298         now a value_print_options pointer; adjust.
2299         (_initialize_compile): Update "compile print"'s help to include
2300         supported options.  Install a completer for "compile print".
2301         * cp-valprint.c (show_vtblprint, show_objectprint)
2302         (show_static_field_print): Delete.
2303         (_initialize_cp_valprint): Don't install "set print
2304         static-members", "set print vtbl", "set print object" here.
2305         * printcmd.c: Include "cli/cli-option.h" and
2306         "common/gdb_optional.h".
2307         (print_command_parse_format): Rework to fill in a
2308         value_print_options instead of a format_data.
2309         (print_value): Change parameter type from format_data pointer to
2310         value_print_options reference.  Adjust.
2311         (print_command_1): Process options.  Adjust to pass down a
2312         value_print_options.
2313         (print_command_completer): New.
2314         (_initialize_printcmd): Install print_command_completer as
2315         handle_brkchars completer for the "print" command.  Update
2316         "print"'s help to include supported options.
2317         * valprint.c: Include "cli/cli-option.h".
2318         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2319         here from cp-valprint.c.
2320         (boolean_option_def, uinteger_option_def)
2321         (value_print_option_defs, make_value_print_options_def_group):
2322         New.  Use gdb::option::add_setshow_cmds_for_options to install
2323         "set print elements", "set print null-stop", "set print repeats",
2324         "set print pretty", "set print union", "set print array", "set
2325         print address", "set print symbol", "set print array-indexes".
2326         * valprint.h: Include <string> and "cli/cli-option.h".
2327         (make_value_print_options_def_group): Declare.
2328         (print_value): Change parameter type from format_data pointer to
2329         value_print_options reference.
2330         (print_command_completer): Declare.
2331
2332 2019-06-13  Pedro Alves  <palves@redhat.com>
2333
2334         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2335         (COMMON_SFILES): Add maint-test-settings.c.
2336         * cli/cli-decode.c (boolean_enums): New global, factored out from
2337         ...
2338         (add_setshow_boolean_cmd): ... here.
2339         * cli/cli-decode.h (boolean_enums): Declare.
2340         * cli/cli-option.c: New file.
2341         * cli/cli-option.h: New file.
2342         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2343         factored out from ...
2344         (parse_cli_boolean_value(const char *)): ... this.
2345         (is_unlimited_literal): Change parameter type to pointer to
2346         pointer.  Adjust and advance ARG pointer.
2347         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2348         (parse_cli_var_enum): New, factored out from ...
2349         (do_set_command): ... this.  Adjust.
2350         * cli/cli-setshow.h (parse_cli_boolean_value)
2351         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2352         (parse_cli_var_enum): Declare.
2353         * cli/cli-utils.c: Include "cli/cli-option.h".
2354         (get_ulongest): New.
2355         * cli/cli-utils.h (get_ulongest): Declare.
2356         (check_for_argument): New overloads.
2357         * maint-test-options.c: New file.
2358
2359 2019-06-13  Pedro Alves  <palves@redhat.com>
2360
2361         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2362         parse a range if "-" is at the end of the string.
2363
2364 2019-06-13  Pedro Alves  <palves@redhat.com>
2365
2366         * cli/cli-setshow.c (parse_auto_binary_operation)
2367         (parse_cli_boolean_value): Don't allow "o".
2368
2369 2019-06-13  Pedro Alves  <palves@redhat.com>
2370
2371         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2372         * NEWS: Mention maint test-settings KIND.
2373         * maint-test-settings.c: New file.
2374
2375 2019-06-13  Pedro Alves  <palves@redhat.com>
2376
2377         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2378         completer.
2379         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2380         "set" completers.
2381
2382 2019-06-13  Pedro Alves  <palves@redhat.com>
2383
2384         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2385         after item.
2386
2387 2019-06-13  Pedro Alves  <palves@redhat.com>
2388
2389         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2390
2391 2019-06-13  Pedro Alves <palves@redhat.com>
2392
2393         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2394         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2395         call.
2396         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2397         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2398         calls.
2399         (check_for_argument): Skip spaces after argument.
2400
2401 2019-06-13  Pedro Alves  <palves@redhat.com>
2402
2403         * thread.c (thread_apply_command): Adjust TID parsing.
2404         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2405         detected before end of string.
2406         (tid_is_in_list): Error out if LIST is invalid.
2407
2408 2019-06-13  Pedro Alves  <palves@redhat.com>
2409
2410         * completer.c (complete_line_internal_1): Rewind completion word
2411         point.
2412         (completion_tracker::advance_custom_word_point_by): Change
2413         parameter type to int.
2414         * completer.h (completion_tracker::advance_custom_word_point_by):
2415         Likewise.
2416
2417 2019-06-13  Pedro Alves  <palves@redhat.com>
2418
2419         * completer.c (advance_to_completion_word): Handle delimiters.
2420
2421 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2422
2423         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2424
2425 2019-06-11  Tom Tromey  <tom@tromey.com>
2426
2427         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2428         (xmalloc_failed): Move to alloc.c.
2429         * alloc.c: New file.
2430         * Makefile.in (COMMON_SFILES): Add alloc.c.
2431
2432 2019-06-11  Tom Tromey  <tom@tromey.com>
2433
2434         * nat/linux-waitpid.c: Don't include server.h.
2435         (linux_debug): Remove.
2436         (my_waitpid): Update.
2437
2438 2019-06-11  Tom Tromey  <tromey@adacore.com>
2439
2440         * infcall.c (_initialize_infcall): Remove trailing newline from
2441         help.
2442         * user-regs.c (_initialize_user_regs): Remove trailing newline
2443         from help.
2444         * typeprint.c (_initialize_typeprint): Remove trailing newline
2445         from help.
2446         * reverse.c (_initialize_reverse): Remove trailing newlines from
2447         help.
2448         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2449         from help.
2450         * language.c (add_set_language_command): Remove trailing newline
2451         from help.
2452         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2453         help.
2454         * disasm.c (_initialize_disasm): Remove trailing newline from
2455         help.
2456         * top.c (init_main): Remove trailing newline from help.
2457         * interps.c (_initialize_interpreter): Remove trailing newline
2458         from help.
2459         * btrace.c (_initialize_btrace): Remove trailing newlines from
2460         help.
2461         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2462         from help.
2463         * python/python.c (_initialize_python): Remove trailing newline
2464         from help.
2465         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2466         help.
2467         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2468         from help.  Reformat some text.
2469         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2470         from help.
2471         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2472         newline from help.
2473
2474 2019-06-11  Tom Tromey  <tromey@adacore.com>
2475
2476         * darwin-nat.c (darwin_decode_exception_message)
2477         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2478
2479 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2480
2481         * valops.c (value_slice): Check for not allocated or not
2482         associated values.
2483
2484 2019-06-10  Tom de Vries  <tdevries@suse.de>
2485
2486         PR gdb/24618
2487         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2488         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2489         invalid.
2490
2491 2019-06-10  Tom de Vries  <tdevries@suse.de>
2492
2493         PR gdb/24611
2494         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2495         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2496
2497 2019-06-10  Tom de Vries  <tdevries@suse.de>
2498
2499         PR symtab/24545
2500         * symtab.c (struct demangled_name_entry): Add language field.
2501         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2502         static minimal symbol".  Set and use language field.
2503
2504 2019-06-10  Tom Tromey  <tromey@adacore.com>
2505
2506         * ada-lang.c (_initialize_ada_language): Update help text.
2507
2508 2019-06-10  Tom Tromey  <tromey@adacore.com>
2509
2510         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2511         with a newline.
2512         * guile/guile.c (handle_boot_error): Don't end warning with a
2513         newline.
2514         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2515         warning with a newline.
2516         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2517         newline.
2518         (s12z_frame_cache): Likewise.
2519         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2520         a newline.
2521         * solib-svr4.c (disable_probes_interface): Don't end warning with
2522         a newline.
2523         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2524         newline.
2525         * python/python.c (do_finish_initialization): Don't end warning
2526         with a newline.
2527
2528 2019-06-10  Tom Tromey  <tom@tromey.com>
2529
2530         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2531         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2532         gdbpy_enter.
2533
2534 2019-06-10  Tom Tromey  <tromey@adacore.com>
2535
2536         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2537         data.
2538         (elf_new_init): Don't call stabsread_new_init.
2539         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2540         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2541         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2542
2543 2019-06-10  Tom de Vries  <tdevries@suse.de>
2544
2545         PR symtab/16264
2546         PR symtab/24517
2547         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2548
2549 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2550
2551         * source.c (find_and_open_source): Also rewrite relative file
2552         names.
2553
2554 2019-04-26  Amos Bird  <amosbird@gmail.com>
2555
2556         * annotate.c (annotate_thread_exited): Add "thread-exited"
2557         annotation.
2558
2559 2019-06-06  Tom Tromey  <tromey@adacore.com>
2560
2561         * maint.h (class scoped_command_stats): Use
2562         DISABLE_COPY_AND_ASSIGN.
2563         <print_time>: New method.
2564         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2565         print_time.
2566         (scoped_command_stats::print_time): New method.
2567
2568 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2569
2570         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2571         instructions of lengths 6 or 8 bytes.
2572
2573 2019-06-04  Pedro Alves  <palves@redhat.com>
2574
2575         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2576
2577         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2578         * breakpoint.c (condition_completer): Likewise.
2579         * cli/cli-dump.c (scan_expression): Likewise.
2580         * common/filestuff.c (mkdir_recursive): Likewise.
2581         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2582         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2583         (gdb_abspath): Likewise.
2584         * compile/compile-cplus-types.c
2585         (compile_cplus_instance::decl_name): Likewise.
2586         * completer.c (complete_explicit_location):
2587         (signal_completer, reg_or_group_completer_1): Likewise.
2588         * cp-support.c (cp_remove_params_if_any): Likewise.
2589         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2590         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2591         * infcmd.c (strip_bg_char): Likewise.
2592         * linespec.c (copy_token_string): Likewise.
2593         * mi/mi-main.c (output_cores): Likewise.
2594         * psymtab.c (psymtab_search_name):
2595         * symfile.c (test_set_ext_lang_command): Likewise.
2596         * target.c (target_fileio_read_stralloc): Likewise.
2597         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2598         * value.c (complete_internalvar): Likewise.
2599
2600 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2601
2602         Add objfile property to gdb.Type.
2603         * NEWS: Mention Python API addition.
2604         * python/py-type.c (typy_get_objfile): New method.
2605
2606 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2607
2608         * NEWS: Mention the new set|show style [title|highlight].
2609         Mention changes to "show style", "help" and "apropos".
2610
2611 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2612
2613         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2614         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2615         instead of print_help_for_command.
2616         (print_doc_of_command): New function.
2617         (help_list): Add 'apropos -v word' suggestion.
2618         (print_help_for_command): Style the command name using title style.
2619         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2620         (_initialize_cli_cmds): Describe -v in apropos_command help.
2621
2622 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2623
2624         * cli/cli-style.h (cli_style_option): Add name in constructor,
2625         add m_name class member, add constructor with intensity,
2626         add name class function.
2627         (cli_style_option::add_setshow_commands): Remove name argument.
2628         (highlight_style, title_style): New styles.
2629         * cli/cli-style.c (do_show): New function that shows a style
2630         characteristic styling the style name with itself.
2631         (set_style_name): New function.
2632         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2633         Update all callers according to the changes in cli/cli-style.h.
2634         * utils.h (fputs_highlighted): New function.
2635         * utils.c (fputs_highlighted): Likewise.
2636
2637 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2638
2639         * NEWS: Mention new pipe command and new convenience variables.
2640
2641 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2642
2643         * cli/cli-cmds.c (pipe_command): New function.
2644         (_initialize_cli_cmds): Call add_com for pipe_command.
2645         Define | as an alias for pipe.
2646         (exit_status_set_internal_vars): New function.
2647         (shell_escape): Call exit_status_set_internal_vars.
2648         cli/cli-decode.c (find_command_name_length): Recognize | as
2649         a single character command.
2650
2651 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2652
2653         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2654         top.c (execute_command_to_ui_file): New function, mostly a copy
2655         of execute_command_to_string.
2656         (execute_command_to_string): Implement by calling
2657         execute_command_to_ui_file.
2658
2659 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2660
2661         * top.h (saved_command_line): Remove declaration.
2662         * top.c (previous_saved_command_line, previous_repeat_arguments):
2663         New variables.
2664         (saved_command_line): Make static, define together with other
2665         'repeat variables'.
2666         (dont_repeat): Clear repeat_arguments.
2667         (repeat_previous, get_saved_command_line, save_command_line):
2668         New functions.
2669         (gdb_init): Initialize saved_command_line
2670         and previous_saved_command_line.
2671         * main.c (captured_main_1): Remove saved_command_line initialization.
2672         * event-top.c (handle_line_of_input): Update to use
2673         the new 'repeat' related functions instead of direct access to
2674         saved_command_line.
2675         * command.h (repeat_previous, get_saved_command_line,
2676         save_command_line): New declarations.
2677         (dont_repeat): Add comment.
2678
2679 2019-05-30  Tom Tromey  <tromey@adacore.com>
2680
2681         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2682         Fix comment.
2683         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2684
2685 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2686
2687         PR cli/24587
2688         * completer.c (complete): Initialize variable word.
2689
2690 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2691
2692         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2693         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2694         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2695         'body' is NULL to the outter 'if', protecting the '!is_define'
2696         situation as well.
2697
2698 2019-05-29  Tom Tromey  <tromey@adacore.com>
2699
2700         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2701         (dwarf_unknown): New function.
2702         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2703         (dwarf_type_encoding_name): Use dwarf_unknown.
2704
2705 2019-05-29  Tom Tromey  <tromey@adacore.com>
2706
2707         PR c++/20020:
2708         * cp-valprint.c (cp_print_value_fields): Call
2709         cp_print_static_field inside "try".
2710
2711 2019-05-29  Tom Tromey  <tromey@adacore.com>
2712
2713         * inflow.c (struct terminal_info): Add default operator=.
2714         * configure: Rebuild.
2715         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2716         -Wdeprecated-copy-dtor, -Wredundant-move.
2717
2718 2019-05-29  Tom Tromey  <tromey@adacore.com>
2719
2720         * NEWS: Add entry.
2721         * infcmd.c (print_return_value_1): Handle finish_print
2722         option.
2723         (show_print_finish): New function.
2724         (_initialize_infcmd): Add "set/show print finish" commands.
2725         * valprint.c (user_print_options): Initialize new member.
2726         * valprint.h (struct value_print_options) <finish_print>: New
2727         member.
2728
2729 2019-05-28  Tom Tromey  <tromey@adacore.com>
2730
2731         * ada-lang.c (ada_remove_Xbn_suffix)
2732         (find_old_style_renaming_symbol)
2733         (parse_old_style_renaming): Remove.
2734         (ada_find_renaming_symbol): Don't call
2735         find_old_style_renaming_symbol.
2736         (ada_is_renaming_symbol): Rename from
2737         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2738         bool.  Now static.
2739         (ada_read_var_value): Update and simplify.
2740         * ada-exp.y (write_var_or_type): Remove old code.
2741
2742 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2743
2744         * event-top.c: Remove include comment.
2745         * inflow.c (class scoped_ignore_sigttou): Move from here...
2746         * inflow.h (class scoped_ignore_sigttou): ...to here.
2747         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2748         * top.c:  Remove include comment.
2749
2750 2019-05-27  Tom Tromey  <tom@tromey.com>
2751
2752         * NEWS: Fix typo.
2753
2754 2019-05-22  Tom Tromey  <tromey@adacore.com>
2755
2756         * target.c (target_follow_exec): Constify parameter.
2757         * target-delegates.c: Rebuild.
2758         * remote.c (remote_target::follow_exec): Constify parameter.
2759         * infrun.c (follow_exec): Constify parameter.
2760         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2761         (target_follow_exec): Likewise.
2762
2763 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2764
2765         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2766         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2767
2768 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2769
2770         * NEWS: Add debugredirect and testsuite sections.
2771
2772 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2773
2774         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2775         target descriptions using exclusively floating point register name
2776         aliases.
2777
2778 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2779
2780         PR gdb/18644:
2781         * f-lang.c (build_fortran_types): Handle the case where
2782         gdbarch_floatformat_for_type returns a nullptr.
2783
2784 2019-05-21  Tom de Vries  <tdevries@suse.de>
2785
2786         PR cli/24587
2787         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2788
2789 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2790
2791         PR gdb/18644:
2792         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2793         16-byte floats.
2794         * i386-tdep.c (i386_floatformat_for_type): Use
2795         floatformats_ia64_quad for the 16-byte floating point component
2796         within a fortran 32-byte complex number.
2797
2798 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2799
2800         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2801         delete default constructor.
2802         (find_partial_die): Update to return const struct.
2803         (partial_die_parent_scope): Move variable declaration into scope
2804         of its use and change its type to auto.
2805         (guess_partial_die_structure_name): Likewise.
2806         (partial_die_info::fixup): Likewise.
2807
2808 2019-05-17  Tom Tromey  <tromey@adacore.com>
2809
2810         * source.c (find_and_open_source): Remove cast.
2811
2812 2019-05-17  Tom Tromey  <tromey@adacore.com>
2813
2814         * annotate.c (annotate_source): Make "filename" const.
2815         * annotate.h (annotate_source): Use const.
2816
2817 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2818
2819         * disasm.c (set_disassembler_options): Send errors to stderr.
2820
2821 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2822
2823         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2824         (cli_interp_base::set_logging): Check debug_redirect.
2825         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2826         * cli/cli-logging.c (debug_redirect): Add static variable.
2827         (pop_output_files): Add default param.
2828         (handle_redirections): Print debug setting.
2829         (show_logging_command): Likewise.
2830         (_initialize_cli_logging): Add debugredirect command.
2831         * interps.c (current_interp_set_logging): Add debug_redirect
2832         parameter.
2833         * interps.h (set_logging): Add debug_redirect parameter.
2834         (current_interp_set_logging): Likewise.
2835         * mi/mi-common.h: Likewise.
2836         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2837
2838 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2839             Tom Tromey  <tromey@adacore.com>
2840
2841         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2842         directly.
2843         * cli/cli-interp.h (make_logging_output): Remove declaration.
2844         * cli/cli-logging.c (make_logging_output): Remove function.
2845         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2846         directly.
2847         * ui-file.c (tee_file::tee_file): Remove bools.
2848         (tee_file::~tee_file): Remove deletes.
2849         * ui-file.h (tee_file): Remove bools.
2850
2851 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2852
2853         * mi/mi-cmds.h (mi_cmd_complete): New function.
2854         * mi/mi-main.c (mi_cmd_complete): Likewise.
2855         * mi/mi-cmds.c: Define new MI command -complete.
2856         * NEWS: Mention new -complete command.
2857
2858 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2859
2860         * completer.h (complete): New function.
2861         * completer.c (complete): Likewise.
2862         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2863         function defined in completer.h.
2864
2865 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2866
2867         * MAINTAINERS (Write After Approval): Add myself.
2868
2869 2019-05-17  Tom de Vries  <tdevries@suse.de>
2870
2871         PR gdb/24094
2872         * dwarf2read.c (struct cu_partial_die_info): New struct.
2873         (find_partial_die): Return cu_partial_die_info.
2874         (partial_die_parent_scope, guess_partial_die_structure_name)
2875         (partial_die_info::fixup): Handle new return type of find_partial_die.
2876
2877 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2878
2879         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2880         "std::string", simplifying the algorithm.
2881
2882 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2883
2884         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2885         (stap_static_probe_ops::get_probes): Likewise.
2886
2887 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2888
2889         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2890         '-')" and "else if".
2891         (stap_parse_single_operand): Join checks for
2892         "gdbarch_stap_parse_special_token_p" and
2893         "gdbarch_stap_parse_special_token" in the same "if" statement.
2894         Invert check when verifying for operation on register
2895         displacement.
2896
2897 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2898
2899         * stap-probe.c (stap_get_opcode): Update comment.
2900         (stap_get_expected_argument_type): Likewise.
2901         (handle_stap_probe): Likewise.
2902
2903 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2904
2905         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2906         return type to 'bool'.  Adjust comment.  Use 'bool' when
2907         appropriate.
2908         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2909         * stap-probe.c (stap_parse_argument_1): Likewise.
2910         (stap_is_operator): Likewise.
2911         (stap_is_generic_prefix): Likewise.
2912         (stap_is_register_prefix): Likewise.
2913         (stap_is_register_indirection_prefix): Likewise.
2914         (stap_is_integer_prefix): Likewise.
2915         (stap_generic_check_suffix): Likewise.
2916         (stap_check_integer_suffix): Likewise.
2917         (stap_check_register_suffix): Likewise.
2918         (stap_check_register_indirection_suffix): Likewise.
2919         (stap_parse_register_operand): Likewise.
2920         (stap_parse_single_operand): Likewise.
2921         (stap_parse_argument_1): Likewise.
2922         (stap_probe::get_argument_count): Likewise.
2923         (stap_is_operator): Likewise.
2924
2925 2019-05-16  Tom Tromey  <tromey@adacore.com>
2926
2927         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2928         keyword to foreach.
2929
2930 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2931
2932         * linux-thread-db.c (try_thread_db_load_1): Change return type
2933         to bool.
2934         (try_thread_db_load): Likewise.
2935         (try_thread_db_load_from_pdir_1): Likewise.
2936         (try_thread_db_load_from_pdir): Likewise.
2937         (try_thread_db_load_from_sdir): Likewise.
2938         (try_thread_db_load_from_dir): Likewise.
2939         (thread_db_load_search): Likewise.
2940         (has_libpthread): Likewise.
2941         (thread_db_load): Likewise.
2942
2943 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2944
2945         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2946         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2947         NULL, and complain/return if that's the case.
2948
2949 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2950
2951         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2952         (advance, posn, abstract_read_memory): New functions.
2953         [struct mem_read_abstraction]: New struct.
2954         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2955
2956 2019-05-14  Tom Tromey  <tromey@adacore.com>
2957
2958         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2959         value is not lval_memory.
2960
2961 2019-05-14  Tom Tromey  <tromey@adacore.com>
2962
2963         * solib.c (info_sharedlibrary_command): Style the file name.
2964
2965 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2966
2967         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2968         (aarch64_vnv_type): Likewise.
2969         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2970         * common/tdesc.c: Likewise.
2971         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2972         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2973         * features/aarch64-fpu.xml: Add ieee half view.
2974         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2975         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2976         * gdbtypes.h (struct builtin_type): Likewise.
2977         (struct objfile_type): Likewise.
2978
2979 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2980
2981         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2982         typo.
2983         * location.h (string_to_event_location): Likewise.
2984
2985 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2986
2987         GDB 8.3 released.
2988
2989 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2990
2991         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2992         New variable declaration.
2993         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2994         New variable.
2995         (print_one_breakpoint): Use ui_out::test_flags and new global
2996         variable to compute use_fixed_output.
2997         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2998         Remove.
2999         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3000         (mi_multi_location_breakpoint_output_fixed): Remove.
3001         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3002         new variable.
3003         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3004         fix_multi_location_breakpoint_output flag if version >= 3.
3005         * ui-out.h (enum ui_out_flag)
3006         <fix_multi_location_breakpoint_output>: New enumerator.
3007
3008 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3009
3010         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3011
3012 2019-05-10  Tom Tromey  <tromey@adacore.com>
3013
3014         * ada-lang.c (catch_ada_completer): New function.
3015         (_initialize_ada_language): Use it.
3016
3017 2019-05-10  Tom Tromey  <tromey@adacore.com>
3018
3019         * thread.c (print_thread_info): Make "requested_threads" const.
3020         * gdbthread.h (print_thread_info): Make "requested_threads"
3021         const.
3022         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3023         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3024
3025 2019-05-08  Tom Tromey  <tom@tromey.com>
3026
3027         * gdbtypes.c (objfile_type_data): Change type.
3028         (objfile_type, _initialize_gdbtypes): Update.
3029
3030 2019-05-08  Tom Tromey  <tom@tromey.com>
3031
3032         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3033         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3034         (_initialize_dwarf2_frame): Update.
3035
3036 2019-05-08  Tom Tromey  <tom@tromey.com>
3037
3038         * objc-lang.c (objc_objfile_data): Change type.
3039         (find_methods): Update.
3040         (_initialize_objc_lang): Remove.
3041
3042 2019-05-08  Tom Tromey  <tom@tromey.com>
3043
3044         * stabsread.c (rs6000_builtin_type_data): Change type.
3045         (rs6000_builtin_type, _initialize_stabsread): Update.
3046
3047 2019-05-08  Tom Tromey  <tom@tromey.com>
3048
3049         * mips-tdep.c (mips_pdr_data): Remove.
3050         (_initialize_mips_tdep): Update.
3051
3052 2019-05-08  Tom Tromey  <tom@tromey.com>
3053
3054         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3055         (hppa_init_objfile_priv_data, read_unwind_info)
3056         (find_unwind_entry, _initialize_hppa_tdep): Update.
3057
3058 2019-05-08  Tom Tromey  <tom@tromey.com>
3059
3060         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3061         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3062         on obstack.
3063         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3064
3065 2019-05-08  Tom Tromey  <tom@tromey.com>
3066
3067         * mdebugread.c (basic_type_data): Change type.
3068         (basic_type, _initialize_mdebugread): Update.
3069
3070 2019-05-08  Tom Tromey  <tom@tromey.com>
3071
3072         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3073
3074 2019-05-08  Tom Tromey  <tom@tromey.com>
3075
3076         * nto-tdep.c (nto_inferior_data_reg): Change type.
3077         (nto_inferior_data): Update.
3078         (nto_inferior_data_cleanup, nto_new_inferior_data)
3079         (_initialize_nto_tdep): Remove.
3080         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3081
3082 2019-05-08  Tom Tromey  <tom@tromey.com>
3083
3084         * ada-lang.c (struct ada_inferior_data): Add initializers.
3085         (ada_inferior_data): Change type.
3086         (ada_inferior_data_cleanup): Remove.
3087         (get_ada_inferior_data, ada_inferior_exit)
3088         (struct ada_pspace_data): Add initializers, destructor.
3089         (ada_pspace_data_handle): Change type.
3090         (get_ada_pspace_data): Update.
3091         (ada_pspace_data_cleanup): Remove.
3092
3093 2019-05-08  Tom Tromey  <tom@tromey.com>
3094
3095         * coffread.c (struct coff_symfile_info): Add initializers.
3096         (coff_objfile_data_key): Move lower.  Change type.
3097         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3098         Update.
3099         (coff_free_info): Remove.
3100
3101 2019-05-08  Tom Tromey  <tom@tromey.com>
3102
3103         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3104         (fbsd_pspace_data_handle): Move lower.  Change type.
3105         (get_fbsd_pspace_data): Update.
3106         (fbsd_pspace_data_cleanup): Remove.
3107         (_initialize_fbsd_tdep): Update.
3108
3109 2019-05-08  Tom Tromey  <tom@tromey.com>
3110
3111         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3112         (get_ada_tasks_pspace_data): Update.
3113         (ada_tasks_pspace_data_cleanup): Remove.
3114         (_initialize_tasks): Update.
3115         (ada_tasks_inferior_data_handle): Change type.
3116         (get_ada_tasks_inferior_data): Update.
3117         (ada_tasks_inferior_data_cleanup): Remove.
3118         (struct ada_tasks_pspace_data): Add initializers.
3119
3120 2019-05-08  Tom Tromey  <tom@tromey.com>
3121
3122         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3123         * symfile-debug.c (debug_sym_get_probes): Change type.
3124         * stap-probe.c (handle_stap_probe):
3125         (stap_static_probe_ops::get_probes): Change type.
3126         * probe.h (class static_probe_ops) <get_probes>: Change type.
3127         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3128         (parse_probes_in_pspace): Update.
3129         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3130         Update.
3131         (any_static_probe_ops::get_probes): Change type.
3132         * elfread.c (elfread_data): New typedef.
3133         (probe_key): Change type.
3134         (elf_get_probes): Likewise.  Update.
3135         (probe_key_free): Remove.
3136         (_initialize_elfread): Update.
3137         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3138         Change type.
3139         (dtrace_process_dof_probe, dtrace_process_dof)
3140         (dtrace_static_probe_ops::get_probe): Change type.
3141
3142 2019-05-08  Tom Tromey  <tom@tromey.com>
3143
3144         * xcoffread.c (struct xcoff_symfile_info): Rename from
3145         coff_symfile_info.  Add initializers.
3146         (xcoff_objfile_data_key): Move lower.  Change type.
3147         (XCOFF_DATA): Rewrite.
3148         (xcoff_free_info): Remove.
3149         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3150         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3151         (xcoff_initial_scan): Update.
3152
3153 2019-05-08  Tom Tromey  <tom@tromey.com>
3154
3155         * solib-svr4.c (struct svr4_info): Add initializers and
3156         destructor.
3157         <probes_table>: Now an htab_up.
3158         (solib_svr4_pspace_data): Change type.
3159         (free_probes_table): Simplify.
3160         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3161         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3162         (probes_table_remove_objfile_probes, register_solib_event_probe)
3163         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3164         (_initialize_svr4_solib): Update.
3165
3166 2019-05-08  Tom Tromey  <tom@tromey.com>
3167
3168         * remote.c (remote_pspace_data): Change type.
3169         (remote_pspace_data_cleanup): Remove.
3170         (get_remote_exec_file, set_pspace_remote_exec_file)
3171         (_initialize_remote): Update.
3172
3173 2019-05-08  Tom Tromey  <tom@tromey.com>
3174
3175         * breakpoint.c (breakpoint_objfile_key): Change type.
3176         (get_breakpoint_objfile_data): Update.
3177         (free_breakpoint_objfile_data): Remove.
3178         (_initialize_breakpoint): Update.
3179
3180 2019-05-08  Tom Tromey  <tom@tromey.com>
3181
3182         * linux-tdep.c (struct linux_info): Add initializers.
3183         (linux_inferior_data): Move.  Change type.
3184         (invalidate_linux_cache_inf): Update.
3185         (linux_inferior_data_cleanup): Remove.
3186         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3187
3188 2019-05-08  Tom Tromey  <tom@tromey.com>
3189
3190         * auxv.c (auxv_inferior_data): Move.  Change type.
3191         (auxv_inferior_data_cleanup): Remove.
3192         (invalidate_auxv_cache_inf): Rewrite.
3193         (get_auxv_inferior_data, _initialize_auxv): Update.
3194
3195 2019-05-08  Tom Tromey  <tom@tromey.com>
3196
3197         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3198         (symfile_debug_objfile_data_key): Change type.
3199         (symfile_debug_installed, debug_qf_has_symbols)
3200         (debug_qf_find_last_source_symtab)
3201         (debug_qf_forget_cached_source_info)
3202         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3203         (debug_qf_print_stats, debug_qf_dump)
3204         (debug_qf_expand_symtabs_for_function)
3205         (debug_qf_expand_all_symtabs)
3206         (debug_qf_expand_symtabs_with_fullname)
3207         (debug_qf_map_matching_symbols)
3208         (debug_qf_expand_symtabs_matching)
3209         (debug_qf_find_pc_sect_compunit_symtab)
3210         (debug_qf_map_symbol_filenames)
3211         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3212         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3213         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3214         (debug_sym_read_linetable, debug_sym_relocate): Update.
3215         (symfile_debug_free_objfile): Remove.
3216         (install_symfile_debug_logging, _initialize_symfile_debug):
3217         Update.
3218
3219 2019-05-08  Tom Tromey  <tom@tromey.com>
3220
3221         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3222         allocate_on_obstack.
3223         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3224         (get_dwarf2_per_objfile): Update.
3225         (set_dwarf2_per_objfile): Remove.
3226         (dwarf2_has_info, dwarf2_get_section_info): Update.
3227         (dwarf2_free_objfile): Remove.
3228         (_initialize_dwarf2_read): Update.
3229
3230 2019-05-08  Tom Tromey  <tom@tromey.com>
3231
3232         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3233         initializers.
3234         <unsupported_script_warning_printed,
3235         script_not_found_warning_printed>: Now bool.
3236         (auto_load_pspace_data): Change type.
3237         (~auto_load_pspace_info): Rename from
3238         auto_load_pspace_data_cleanup.
3239         (get_auto_load_pspace_data, init_loaded_scripts_info)
3240         (clear_section_scripts, maybe_print_unsupported_script_warning)
3241         (maybe_print_script_not_found_warning, _initialize_auto_load):
3242         Update.
3243
3244 2019-05-08  Tom Tromey  <tom@tromey.com>
3245
3246         * objfiles.c (objfile_pspace_info): Add destructor and
3247         initializers.
3248         (objfiles_pspace_data): Change type.
3249         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3250         (get_objfile_pspace_data): Update.
3251         (objfiles_bfd_data): Change type.
3252         (get_objfile_bfd_data): Update.
3253         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3254
3255 2019-05-08  Tom Tromey  <tom@tromey.com>
3256
3257         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3258         Change type.
3259         (get_catch_syscall_inferior_data): Update.
3260         (catch_syscall_inferior_data_cleanup): Remove.
3261         (_initialize_break_catch_syscall): Update.
3262
3263 2019-05-08  Tom Tromey  <tom@tromey.com>
3264
3265         * inflow.c (struct terminal_info): Add destructor and
3266         initializers.
3267         (inflow_inferior_data): Change type.
3268         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3269         (get_inflow_inferior_data, inflow_inferior_exit)
3270         (swap_terminal_info, _initialize_inflow): Update.
3271
3272 2019-05-08  Tom Tromey  <tom@tromey.com>
3273
3274         * target-dcache.c (target_dcache_cleanup): Remove.
3275         (target_dcache_aspace_key): Change type.
3276         (target_dcache_init_p, target_dcache_invalidate)
3277         (target_dcache_get, target_dcache_get_or_init)
3278         (_initialize_target_dcache): Update.
3279         * dcache.h (struct dcache_deleter): New.
3280
3281 2019-05-08  Tom Tromey  <tom@tromey.com>
3282
3283         * symtab.c (struct symbol_cache): Add destructor and
3284         initializers.
3285         (symbol_cache_key): Move.  Change type.
3286         (make_symbol_cache, free_symbol_cache): Remove.
3287         (get_symbol_cache): Update.
3288         (symbol_cache_cleanup): Remove.
3289         (ALL_PSPACES, symbol_cache_flush)
3290         (maintenance_print_symbol_cache)
3291         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3292         Update.
3293
3294 2019-05-08  Tom Tromey  <tom@tromey.com>
3295
3296         * symtab.c (struct main_info): Add destructor and initializers.
3297         (main_progspace_key): Move.  Change type.
3298         (get_main_info): Update.
3299         (main_info_cleanup): Remove.
3300         (_initialize_symtab): Update.
3301
3302 2019-05-08  Tom Tromey  <tom@tromey.com>
3303
3304         * registry.h (DECLARE_REGISTRY): Define the _key class.
3305
3306 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3307
3308         * NEWS: Merge two 'New commands' sections.
3309
3310 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3311
3312         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3313         parameter and use Ada language definition instead.
3314         (ada_val_print_ptr): Remove unused language parameter.
3315         (ada_val_print_num): Remove language parameter and use Ada language
3316         definition instead.
3317         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3318         parameter.
3319         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3320         parameter and use Ada language definition instead.
3321         (ada_val_print_1): Update all ada_val_print_xxx calls.
3322         Remove language parameter.
3323         (ada_val_print): Update ada_val_print_1 call.
3324
3325 2019-05-08  Tom Tromey  <tromey@adacore.com>
3326
3327         * remote.c (remote_hw_watchpoint_limit)
3328         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3329         Now static.
3330
3331 2019-05-08  Tom Tromey  <tromey@adacore.com>
3332
3333         * maint.c (_initialize_maint_cmds): Move initialization code to
3334         remote.c.
3335         (watchdog, show_watchdog): Move to remote.c.
3336         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3337         "watchdog" static.
3338         (_initialize_remote): Move initialization code from maint.c.
3339         * defs.h (watchdog): Don't declare.
3340
3341 2019-05-08  Tom Tromey  <tromey@adacore.com>
3342
3343         * tui/tui-interp.c: Include main.h.
3344         * interps.c: Include main.h.
3345         * main.h (interpreter_p): Declare.
3346         * defs.h (interpreter_p): Don't declare.
3347
3348 2019-05-08  Tom Tromey  <tromey@adacore.com>
3349
3350         * dwarf2loc.c: Include dwarf2read.h.
3351         * defs.h (read_unsigned_leb128): Don't declare.
3352         * dwarf2read.h (read_unsigned_leb128): Declare.
3353
3354 2019-05-08  Tom Tromey  <tromey@adacore.com>
3355
3356         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3357         method.
3358
3359 2019-05-08  Tom Tromey  <tromey@adacore.com>
3360
3361         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3362         when no wrap column is set.
3363
3364 2019-05-08  Tom Tromey  <tromey@adacore.com>
3365
3366         * c-lang.c (c_get_string): Handle non-C-style arrays.
3367
3368 2019-05-08  Tom Tromey  <tromey@adacore.com>
3369
3370         * typeprint.c (print_offset_data::update): Print the bit offset,
3371         not the number of bits remaining.
3372
3373 2019-05-08  Tom Tromey  <tromey@adacore.com>
3374
3375         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3376         padding at end of comment.
3377
3378 2019-05-08  Tom Tromey  <tromey@adacore.com>
3379
3380         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3381         Compare main types.
3382
3383 2019-05-06  Tom Tromey  <tom@tromey.com>
3384
3385         * common/scoped_mmap.c: Include common-defs.h.
3386         * common/scoped_mmap.h: Don't include config.h.
3387
3388 2019-05-04  Tom Tromey  <tom@tromey.com>
3389
3390         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3391         (struct aarch64_call_info): Add initializers.
3392         <si>: Now a std::vector.
3393         (pass_on_stack, aarch64_push_dummy_call): Update.
3394
3395 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3396             Tom Tromey  <tom@tromey.com>
3397
3398         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3399         (ppc_threads): Now a std::vector.  Now static.
3400         (hwdebug_find_thread_points_by_tid)
3401         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3402         Update.
3403
3404 2019-05-04  Tom Tromey  <tom@tromey.com>
3405
3406         * arc-tdep.c (arc_tdesc_init): Return bool.
3407
3408 2019-05-04  Tom Tromey  <tom@tromey.com>
3409
3410         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3411         Use gdb_assert_not_reached.
3412
3413 2019-05-04  Tom Tromey  <tom@tromey.com>
3414
3415         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3416         "false".
3417
3418 2019-05-04  Tom Tromey  <tom@tromey.com>
3419
3420         * arc-tdep.c (arc_tdesc_init): Use bool.
3421
3422 2019-05-04  Tom Tromey  <tom@tromey.com>
3423
3424         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3425
3426 2019-05-04  Tom Tromey  <tom@tromey.com>
3427
3428         * cli/cli-cmds.c (valid_command_p): Return bool.
3429
3430 2019-05-04  Tom Tromey  <tom@tromey.com>
3431
3432         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3433         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3434
3435 2019-05-04  Raul Tambre  <raul@tambre.ee>
3436
3437         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3438         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3439         operator for comparison.
3440
3441 2019-05-04  Tom Tromey  <tom@tromey.com>
3442
3443         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3444         (lookup_partial_symbol, print_partial_symbols)
3445         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3446         (psymbol_compare): Update.
3447         (add_psymbol_to_bcache): Clear the entire psymbol.
3448         (maintenance_check_psymtabs): Update.
3449         * psympriv.h (struct partial_symbol): Don't derive from
3450         general_symbol_info.
3451         <obj_section, unrelocated_address, address,
3452         set_unrelocated_address>: Update.
3453         <ginfo>: New member.
3454         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3455         (debug_names::write_psymbols): Update.
3456
3457 2019-05-04  Tom de Vries  <tdevries@suse.de>
3458
3459         * contrib/cc-with-tweaks.sh: Support -n arg.
3460
3461 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3462
3463         * corelow.c (core_target::detach): Ensure frame cache and
3464         register caches are cleared.
3465         inferior.c (exit_inferior_1): Likewise.
3466
3467 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3468             Tom Tromey  <tom@tromey.com>
3469
3470         * dictionary.c (collate_pending_symbols_by_language): Remove
3471         "struct" from foreach.
3472         * symtab.c (lookup_global_symbol_from_objfile)
3473         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3474         foreach.
3475         * ser-tcp.c (net_open): Remove "struct" from foreach.
3476         * objfiles.c (objfile_relocate, objfile_rebase)
3477         (objfile_has_symbols): Remove "struct" from foreach.
3478         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3479         from foreach.
3480         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3481         foreach.
3482         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3483         "struct" from foreach.
3484         * ada-lang.c (create_excep_cond_exprs)
3485         (ada_exception_catchpoint_cond_string): Remove "struct" from
3486         foreach.
3487
3488 2019-05-03  Tom Tromey  <tromey@adacore.com>
3489
3490         * ada-exp.y (convert_char_literal): Check suffix of each
3491         enumerator.
3492
3493 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3494
3495         PR ada/21406:
3496         * ada-exp.y (yywrap): Don't define.
3497         * ada-lex.l (%option): Add noyywrap
3498         (yywrap): Remove.
3499
3500 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3501
3502         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3503         _WIN32_WINNT to the XP level, unless already defined to a higher
3504         level.
3505
3506         * unittests/parse-connection-spec-selftests.c:
3507         * ser-tcp.c:
3508         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3509         override.
3510
3511         * symfile.c (find_separate_debug_file): Remove colon from the
3512         drive spec of DOS/Windows file names of the target, so that the
3513         file name produced from DEBUGDIR and the target's directory will
3514         be valid on DOS/Windows systems.
3515
3516 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3517
3518         * rust-lang.c (val_print_struct): Handle printing structures
3519         containing strings.
3520
3521 2019-05-02  Tom Tromey  <tromey@adacore.com>
3522
3523         * valarith.c (_initialize_valarith): Remove.
3524
3525 2019-05-01  Tom Tromey  <tromey@adacore.com>
3526
3527         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3528         bitfields.
3529
3530 2019-05-01  Tom Tromey  <tromey@adacore.com>
3531
3532         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3533         for big-endian copies.
3534
3535 2019-04-30  Ali Tamur  <tamur@google.com>
3536         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3537         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3538         (read_3_bytes): New function.
3539
3540 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3541
3542         * windows-nat.c (main_thread_id): Delete.
3543         (handle_output_debug_string): Replace main_thread_id by
3544         current_event.dwThreadId.
3545         (fake_create_process): Likewise.
3546         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3547         Do not set main_thread_id.
3548         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3549         current_event.dwThreadId.
3550         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3551
3552 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3553
3554         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3555         Use current_event.dwThreadId instead of main_thread_id.
3556
3557 2019-04-30  Tom Tromey  <tromey@adacore.com>
3558
3559         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3560         (create_excep_cond_exprs): Iterate over program spaces.
3561         (ada_exception_catchpoint_cond_string): Examine all minimal
3562         symbols for exception types.
3563
3564 2019-04-30  Tom Tromey  <tromey@adacore.com>
3565
3566         PR c++/24470:
3567         * dwarf2read.c (process_structure_scope): Handle case where type
3568         has template parameters but no symbol was created.
3569
3570 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3571             Chris January  <chris.january@arm.com>
3572
3573         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3574         qualifier.
3575         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3576
3577 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3578
3579         * f-typeprint.c (f_print_type): Update rules for printing
3580         whitespace.
3581         (f_type_print_varspec_suffix): Likewise.
3582
3583 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3584             Chris January  <chris.january@arm.com>
3585
3586         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3587         function arguments.
3588
3589 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3590
3591         * f-lang.c (build_fortran_types): Change name of void type to
3592         lower case.
3593         * f-typeprint.c (f_type_print_base): Print the name of the void
3594         type, rather than a fixed string.
3595         * f-valprint.c (f_decorations): Use lower case void string.
3596
3597 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3598             Chris January  <chris.january@arm.com>
3599
3600         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3601         types for Fortran.
3602
3603 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3604             Chris January  <chris.january@arm.com>
3605             David Lecomber  <david.lecomber@arm.com>
3606
3607         * f-exp.y (BINOP_INTRINSIC): New token.
3608         (exp): New parser rule handling BINOP_INTRINSIC.
3609         (f77_keywords): Add new builtin procedures.
3610         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3611         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3612         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3613         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3614         (print_unop_subexp_f): New function.
3615         (print_binop_subexp_f): New function.
3616         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3617         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3618         (dump_subexp_body_f): Likewise.
3619         (operator_check_f): Likewise.
3620         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3621         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3622
3623 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3624
3625         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3626         UNOP_KIND.
3627         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3628         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3629         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3630         (operator_length_f): New fuction.
3631         (print_subexp_f): New function.
3632         (op_name_f): New function.
3633         (dump_subexp_body_f): New function.
3634         (operator_check_f): New function.
3635         (exp_descriptor_f): Replace standard expression handling functions
3636         with new functions.
3637         * gdb/fortran-operator.def: New file.
3638         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3639         * gdb/std-operator.def: Remove UNOP_KIND.
3640
3641 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3642
3643         * std-operator.def: Remove unbalanced, stray double quote
3644         character.
3645
3646 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3647             Chris January  <chris.january@arm.com>
3648             Daniel Everett  <daniel.everett@arm.com>
3649             Nick Forrington  <nick.forrington@arm.com>
3650             Richard Bunt  <richard.bunt@arm.com>
3651
3652         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3653         of depth when printing anonymous structs or unions.
3654         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3655         Don't print either the top-level value, or the children if the
3656         max-depth is exceeded.
3657         (ppscm_print_children): When printing the key of a map, allow one
3658         extra level of depth.
3659         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3660         print either the top-level value, or the children if the max-depth
3661         is exceeded.
3662         (print_children): When printing the key of a map, allow one extra
3663         level of depth.
3664         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3665         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3666         (user_print_options): Initialise max_depth field.
3667         (val_print_scalar_or_string_type_p): New function.
3668         (val_print): Check to see if the max depth has been reached.
3669         (val_print_check_max_depth): Define new function.
3670         (show_print_max_depth): New function.
3671         (_initialize_valprint): Add 'print max-depth' option.
3672         * valprint.h (struct value_print_options) <max_depth>: New field.
3673         (val_print_check_max_depth): Declare new function.
3674         * NEWS: Document new feature.
3675
3676 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3677
3678         * ada-lang.c (ada_language_defn): Initialise new field.
3679         * c-lang.c (c_is_string_type_p): New function.
3680         (c_language_defn): Initialise new field.
3681         (cplus_language_defn): Initialise new field.
3682         (asm_language_defn): Initialise new field.
3683         (minimal_language_defn): Initialise new field.
3684         * c-lang.h (c_is_string_type_p): Declare new function.
3685         * d-lang.c (d_language_defn): Initialise new field.
3686         * f-lang.c (f_is_string_type_p): New function.
3687         (f_language_defn): Initialise new field.
3688         * go-lang.c (go_is_string_type_p): New function.
3689         (go_language_defn): Initialise new field.
3690         * language.c (default_is_string_type_p): New function.
3691         (unknown_language_defn): Initialise new field.
3692         (auto_language_defn): Initialise new field.
3693         * language.h (struct language_defn) <la_is_string_type_p>: New
3694         member variable.
3695         (default_is_string_type_p): Declare new function.
3696         * m2-lang.c (m2_language_defn): Initialise new field.
3697         * objc-lang.c (objc_language_defn): Initialise new field.
3698         * opencl-lang.c (opencl_language_defn): Initialise new field.
3699         * p-lang.c (pascal_is_string_type_p): New function.
3700         (pascal_language_defn): Initialise new field.
3701         * rust-lang.c (rust_is_string_type_p): New function.
3702         (rust_language_defn): Initialise new field.
3703
3704 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3705
3706         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3707         New field.
3708         * ada-lang.c (ada_language_defn): Initialise new field.
3709         * c-lang.c (c_language_defn): Likewise.
3710         (cplus_language_defn): Likewise.
3711         (asm_language_defn): Likewise.
3712         (minimal_language_defn): Likewise.
3713         * d-lang.c (d_language_defn): Likewise.
3714         * f-lang.c (f_language_defn): Likewise.
3715         * go-lang.c (go_language_defn): Likewise.
3716         * language.c (unknown_language_defn): Likewise.
3717         (auto_language_defn): Likewise.
3718         * m2-lang.c (m2_language_defn): Likewise.
3719         * objc-lang.c (objc_language_defn): Likewise.
3720         * opencl-lang.c (opencl_language_defn): Likewise.
3721         * p-lang.c (pascal_language_defn): Likewise.
3722         * rust-lang.c (rust_language_defn): Likewise.
3723
3724 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3725
3726         * ada-lang.c (ada_is_character_type): Change return type to bool.
3727         (ada_is_string_type): Likewise.
3728         * ada-lang.h (ada_is_character_type): Update declaration
3729         (ada_is_string_type): Likewise.
3730
3731 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3732
3733         Support style in 'frame|thread apply'
3734
3735         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3736         * record.c (record_start, record_stop): Update callers of
3737         execute_command_to_string with false.
3738         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3739         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3740         methods.
3741         (class string_file): New constructor with term_out parameter.
3742         Override methods term_out and can_emit_style_escape.  New member
3743         term_out.
3744         (class stdio_file): Override can_emit_style_escape.
3745         (class tee_file): Override term_out and can_emit_style_escape.
3746         * utils.h (can_emit_style_escape): Remove.
3747         * utils.c (can_emit_style_escape): Likewise.
3748         Update all callers of can_emit_style_escape (SOMESTREAM) to
3749         SOMESTREAM->can_emit_style_escape.
3750         * source-cache.c (source_cache::get_source_lines): Likewise.
3751         * stack.c (frame_apply_command_count): Call execute_command_to_string
3752         passing the term_out characteristic of the current gdb_stdout.
3753         * thread.c (thr_try_catch_cmd): Likewise.
3754         * top.c (execute_command_to_string): pass term_out parameter
3755         to construct the string_file for the command output.
3756         * ui-file.c (term_cli_styling): New function (most code moved
3757         from utils.c can_emit_style_escape).
3758         (string_file::string_file, string_file::can_emit_style_escape,
3759         stdio_file::can_emit_style_escape, tee_file::term_out,
3760         tee_file::can_emit_style_escape): New functions.
3761
3762 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3763
3764         * NEWS: Mention the new set|show may-call-functions.
3765         * infcall.c (may_call_functions_p): New variable.
3766         (show_may_call_functions_p): New function.
3767         (call_function_by_hand_dummy): Throws an error if not
3768         may-call-functions.
3769         (_initialize_infcall): Call add_setshow_boolean_cmd for
3770         may-call-functions.
3771
3772 2019-04-25  Keith Seitz  <keiths@redhat.com>
3773
3774         PR c++/24367
3775         * cp-support.c (inspect_type): Don't attempt substitutions
3776         of symbol with the same name.
3777
3778 2019-04-25  Tom Tromey  <tromey@adacore.com>
3779
3780         PR gdb/24475:
3781         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3782         static.
3783
3784 2019-04-25  Tom Tromey  <tromey@adacore.com>
3785
3786         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3787         rvalue reference.
3788         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3789         (gdb_xml_parser::parse): Use std::move.
3790         * python/python-internal.h (gdbpy_convert_exception): Take a const
3791         reference.
3792         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3793         std::move.
3794         * python/py-utils.c (gdbpy_convert_exception): Take a const
3795         reference.
3796         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3797         Use std::move.
3798         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3799         Use std::move.
3800         * mi/mi-main.c (mi_print_exception): Take a const reference.
3801         * main.c (handle_command_errors): Take a const reference.
3802         * linespec.c (parse_linespec): Use std::move.
3803         * infcall.c (run_inferior_call): Use std::move.
3804         (call_function_by_hand_dummy): Use std::move.
3805         * exec.c (try_open_exec_file): Use std::move.
3806         * exceptions.h (exception_print, exception_fprintf)
3807         (exception_print_same): Update.
3808         * exceptions.c (print_exception, exception_print)
3809         (exception_fprintf, exception_print_same): Change parameters to
3810         const reference.
3811         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3812         * common/new-op.c: Use std::move.
3813         * common/common-exceptions.h (struct gdb_exception): Add move
3814         constructor.
3815         (struct gdb_exception_error, struct gdb_exception_quit, struct
3816         gdb_quit_bad_alloc): Change constructor to move constructor.
3817         (throw_exception): Change parameter to rvalue reference.
3818         * common/common-exceptions.c (throw_exception): Take rvalue
3819         reference.
3820         * cli/cli-interp.c (safe_execute_command): Use std::move.
3821         * breakpoint.c (insert_bp_location, location_to_sals): Use
3822         std::move.
3823
3824 2019-04-25  Tom Tromey  <tromey@adacore.com>
3825
3826         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3827         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3828         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3829         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3830         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3831         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3832         guile/scm-value.c: Use unpack.
3833         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3834         gdbscm_gdb_exception.
3835         (gdbscm_throw_gdb_exception): Likewise.
3836         (struct gdbscm_gdb_exception): New.
3837         (unpack): New function.
3838         (gdbscm_wrap): Use unpack.
3839
3840 2019-04-25  Tom Tromey  <tromey@adacore.com>
3841
3842         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3843         (gdb_rl_callback_handler): Use std::move.
3844         * common/common-exceptions.h (struct gdb_exception): Add move
3845         assignment operator.
3846         (throw_exception_sjlj): Change "exception" to const reference.
3847         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3848         (throw_exception_sjlj): Change "exception" to const reference.
3849
3850 2019-04-25  Tom Tromey  <tromey@adacore.com>
3851
3852         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3853         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3854         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3855         Update.
3856         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3857         Update.
3858         * mi/mi-interp.c (mi_interp::exec): Update.
3859         * linespec.c (parse_linespec): Update.
3860         * infcall.c (run_inferior_call): Update.
3861         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3862         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3863         (gdbscm_lookup_global_symbol): Update.
3864         * guile/scm-param.c (gdbscm_parameter_value): Update.
3865         * guile/scm-frame.c (gdbscm_frame_read_register)
3866         (gdbscm_frame_read_var): Update.
3867         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3868         * exec.c (try_open_exec_file): Update.
3869         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3870         (gdb_rl_callback_handler): Update.
3871         * common/common-exceptions.h (exception_none): Don't declare.
3872         * common/common-exceptions.c (exception_none): Don't define.
3873         (struct catcher) <exception>: Update.
3874         * cli/cli-interp.c (safe_execute_command): Update.
3875         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3876
3877 2019-04-25  Ali Tamur  <tamur@google.com>
3878
3879         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3880         (read_attribute_value): Likewise.
3881         (dwarf2_read_addr_index): Update comment.
3882         (read_str_index): Add DW_FORM_strx.
3883         (dwarf2_string_attr): Likewise.
3884         (dwarf2_const_value_attr): Likewise.
3885         (dump_die_shallow): Likewise.
3886         (dwarf2_fetch_constant_bytes): Likewise.
3887         (skip_form_bytes): Likewise.
3888         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3889
3890 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3891
3892         PR corefiles/11608
3893         PR corefiles/18187
3894         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3895         OFFSET.  Verify if current mapping contains an ELF header.
3896         (linux_find_memory_regions_full): Adjust call to
3897         dump_mapping_p.
3898
3899 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3900             Kang Li <kanglictf@gmail.com>
3901
3902         PR gdb/21600
3903
3904         * dwarf2-frame.c (read_initial_length): Be consistent about using
3905         unsigned representation of length.
3906         (decode_frame_entry_1): Likewise.  Check for wraparound of
3907         end pointer as well as buffer overflow.
3908
3909 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3910
3911         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3912         "vq".
3913
3914 2019-04-24  Tom Tromey  <tromey@adacore.com>
3915
3916         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3917
3918 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3919
3920         * s12z-tdep.c (s12z_unwind_pc): Delete.
3921         (s12z_unwind_sp): Delete.
3922         (s12z_gdbarch_init): Don't register deleted functions with
3923         gdbarch.
3924
3925 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3926
3927         * rl78-tdep.c (rl78_unwind_sp): Delete.
3928         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3929
3930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3931
3932         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3933         (xstormy16_unwind_pc): Delete.
3934         (xstormy16_dummy_id): Delete.
3935         (xstormy16_gdbarch_init): Don't register deleted functions with
3936         gdbarch.
3937
3938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3939
3940         * vax-tdep.c (vax_unwind_pc): Delete.
3941         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3942
3943 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3944
3945         * v850-tdep.c (v850_unwind_sp): Delete.
3946         (v850_unwind_pc): Delete.
3947         (v850_dummy_id): Delete.
3948         (v850_gdbarch_init): Don't register deleted functions with
3949         gdbarch.
3950
3951 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3952
3953         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3954         (tilegx_unwind_pc): Delete.
3955         (tilegx_unwind_dummy_id): Delete.
3956         (tilegx_gdbarch_init): Don't register deleted functions with
3957         gdbarch.
3958
3959 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3960
3961         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3962         (tic6x_dummy_id): Delete.
3963         (tic6x_gdbarch_init): Don't register deleted functions with
3964         gdbarch.
3965
3966 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3967
3968         * sparc-tdep.c (sparc_unwind_pc): Delete.
3969         (sparc32_gdbarch_init): Don't register deleted function with
3970         gdbarch.
3971
3972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3973
3974         * sh-tdep.c (sh_unwind_sp): Delete.
3975         (sh_unwind_pc): Delete.
3976         (sh_dummy_id): Delete.
3977         (sh_gdbarch_init): Don't register deleted functions with
3978         gdbarch.
3979
3980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3981
3982         * score-tdep.c (score_unwind_sp): Delete.
3983         (score_unwind_pc): Delete.
3984         (score_dummy_id): Delete.
3985         (score_gdbarch_init): Don't register deleted functions with
3986         gdbarch.
3987
3988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3989
3990         * rx-tdep.c (rx_unwind_pc): Delete.
3991         (rx_unwind_sp): Delete.
3992         (rx_dummy_id): Delete.
3993         (rx_gdbarch_init): Don't register deleted functions with
3994         gdbarch.  Update comment.
3995
3996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3997
3998         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3999         (rs6000_dummy_id): Delete.
4000         (rs6000_gdbarch_init): Don't register deleted functions with
4001         gdbarch.
4002
4003 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4004
4005         * or1k-tdep.c (or1k_dummy_id): Delete.
4006         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4007
4008 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4009
4010         * nios2-tdep.c (nios2_dummy_id): Delete.
4011         (nios2_unwind_sp): Delete.
4012         (nios2_gdbarch_init): Don't register deleted functions with
4013         gdbarch.
4014
4015 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4016
4017         * nds32-tdep.c (nds32_dummy_id): Delete.
4018         (nds32_unwind_pc): Delete.
4019         (nds32_unwind_sp): Delete.
4020         (nds32_gdbarch_init): Don't register deleted functions with
4021         gdbarch.
4022
4023 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4024
4025         * msp430-tdep.c (msp430_unwind_pc): Delete.
4026         (msp430_unwind_sp): Delete.
4027         (msp430_dummy_id): Delete.
4028         (msp430_gdbarch_init): Don't register deleted functions with
4029         gdbarch.
4030
4031 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4032
4033         * moxie-tdep.c (moxie_unwind_sp): Delete.
4034         (moxie_unwind_pc): Delete.
4035         (moxie_dummy_id): Delete.
4036         (moxie_gdbarch_init): Don't register deleted functions with
4037         gdbarch.
4038
4039 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4040
4041         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4042         (mn10300_unwind_pc): Delete.
4043         (mn10300_unwind_sp): Delete.
4044         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4045         mn10300_unwind_sp.
4046         (mn10300_frame_unwind_init): Don't register deleted functions with
4047         gdbarch.
4048
4049 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4050
4051         * mep-tdep.c (mep_unwind_pc): Delete.
4052         (mep_unwind_sp): Delete.
4053         (mep_dummy_id): Delete.
4054         (mep_gdbarch_init): Don't register deleted functions with
4055         gdbarch.
4056
4057 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4058
4059         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4060         (m68hc11_unwind_sp): Delete.
4061         (m68hc11_gdbarch_init): Don't register deleted functions with
4062         gdbarch.
4063
4064 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4065
4066         * m32r-tdep.c (m32r_unwind_sp): Delete.
4067         (m32r_unwind_pc): Delete.
4068         (m32r_dummy_id): Delete.
4069         (m32r_gdbarch_init): Don't register deleted functions with
4070         gdbarch.
4071
4072 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4073
4074         * m32c-tdep.c (m32c_unwind_pc): Delete.
4075         (m32c_unwind_sp): Delete.
4076         (m32c_dummy_id): Delete.
4077         (m32c_gdbarch_init): Don't register deleted functions with
4078         gdbarch.
4079
4080 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4081
4082         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4083         (lm32_unwind_pc): Delete.
4084         (lm32_dummy_id): Delete.
4085         (lm32_gdbarch_init): Don't register deleted functions with
4086         gdbarch.
4087
4088 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4089
4090         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4091         (iq2000_unwind_pc): Delete.
4092         (iq2000_dummy_id): Delete.
4093         (iq2000_gdbarch_init): Don't register deleted functions with
4094         gdbarch.
4095
4096 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4097
4098         * nds32-tdep.c (nds32_type_align): Delete.
4099         (nds32_push_dummy_call): Use type_align instead.
4100
4101 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4102
4103         * arm-tdep.c (arm_type_align): Only handle vector override case.
4104         (arm_push_dummy_call): Use type_align.
4105         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4106
4107 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4108
4109         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4110         case.
4111         (pass_on_stack): Use type_align.
4112         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4113         function.
4114
4115 2019-04-23  Tom Tromey  <tromey@adacore.com>
4116
4117         * dwarf2read.c (line_header::file_name_at): Remove unused
4118         overload.
4119
4120 2019-04-23  Tom de Vries  <tdevries@suse.de>
4121
4122         PR gdb/24438
4123         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4124         invocation.
4125
4126
4127 2019-03-27  Ali Tamur  <tamur@google.com>
4128
4129         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4130         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4131         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4132         (dwarf_expr_context::get_addr_index): Likewise
4133         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4134         (symbol_needs_eval_context::get_addr_index): Likewise
4135         (disassemble_dwarf_expression): Add DW_OP_addrx
4136         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4137         (read_cutu_die_from_dwo): Update comment
4138         (skip_one_die): Add DW_FORM_addrx
4139         (read_attribute_value): Likewise
4140         (var_decode_location): Add DW_OP_addrx
4141         (dwarf2_const_value_attr): Add DW_FORM_addrx
4142         (dump_die_shallow): Likewise
4143         (dwarf2_fetch_constant_bytes): Likewise
4144         (decode_locdesc): Add DW_OP_addrx
4145         (skip_form_bytes): Add DW_FORM_addrx
4146
4147 2019-04-22  Ali Tamur  <tamur@google.com>
4148
4149         * MAINTAINERS (Write After Approval): Add self.
4150
4151 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4152
4153         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4154         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4155         (open_symbol_file_object): Likewise.
4156         (svr4_default_sos): Add info parameter.
4157         (svr4_read_so_list): Likewise.
4158         (svr4_current_sos_direct): Adjust functions calls to pass down
4159         info.
4160         (svr4_current_sos_1): Add info parameter.
4161         (svr4_current_sos): Call get_svr4_info, pass info down to
4162         svr4_current_sos_1.
4163         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4164         get_svr4_info.
4165         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4166         get_svr4_info.
4167         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4168         to get_svr4_info.
4169         (probes_table_remove_objfile_probes): Likewise.
4170         (register_solib_event_probe): Add info parameter.
4171         (solist_update_incremental): Pass info parameter down to
4172         svr4_read_so_list.
4173         (disable_probes_interface): Add info parameter.
4174         (svr4_handle_solib_event): Pass current_program_space to
4175         get_svr4_info.  Adjust disable_probes_interface cleanup.
4176         (svr4_create_probe_breakpoints): Add info parameter, pass it
4177         down to register_solib_event_probe.
4178         (svr4_create_solib_event_breakpoints): Add info parameter,
4179         pass it down to svr4_create_probe_breakpoints.
4180         (enable_break): Pass info down to
4181         svr4_create_solib_event_breakpoints.
4182         (svr4_solib_create_inferior_hook): Pass current_program_space to
4183         get_svr4_info.
4184         (svr4_clear_solib): Likewise.
4185
4186 2019-04-22  Pedro Alves  <palves@redhat.com>
4187
4188         * solib-svr4.c (svr4_free_objfile_observer): New.
4189         (probe_and_action::objfile): New field.
4190         (probes_table_htab_remove_objfile_probes)
4191         (probes_table_remove_objfile_probes): New functions.
4192         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4193         in the new probe_and_action.  Don't store the probe in 'lookup'.
4194         (svr4_create_probe_breakpoints): Pass objfile to
4195         register_solib_event_probe.
4196         (_initialize_svr4_solib): Register a free_objfile observer.
4197
4198 2019-04-19  Tom Tromey  <tom@tromey.com>
4199
4200         * common/queue.h: Remove.
4201
4202 2019-04-19  Tom Tromey  <tom@tromey.com>
4203
4204         * event-loop.c: Don't include "common/queue.h".
4205
4206 2019-04-19  Tom Tromey  <tom@tromey.com>
4207
4208         * remote.c (remote_target): Use delete.
4209         * remote-notif.h: Include <list>, not "common/queue.h".
4210         (notif_client_p): Remove typedef.
4211         (remote_notif_state): Add constructor, destructor, initializer.
4212         <notif_queue>: Now a std::list.
4213         (remote_notif_state_xfree): Don't declare.
4214         * remote-notif.c (remote_notif_process, handle_notification)
4215         (remote_notif_state_allocate): Update.
4216         (~remote_notif_state): Rename from remote_notif_state_xfree.
4217
4218 2019-04-19  Tom Tromey  <tom@tromey.com>
4219
4220         * symfile.c (reread_symbols): Update.
4221         * objfiles.c (objfile_register_static_link)
4222         (objfile_lookup_static_link): Update
4223         (~objfile) Don't delete static_links.
4224         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4225
4226 2019-04-19  Tom Tromey  <tom@tromey.com>
4227
4228         * type-stack.h (struct type_stack) <insert>: Constify string.
4229         * type-stack.c (type_stack::insert): Constify string.
4230         * gdbtypes.h (lookup_template_type): Update.
4231         (address_space_name_to_int): Update.
4232         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4233         const.
4234         (lookup_template_type): Make name const.
4235         * c-exp.y: Update rules.
4236         (lex_one_token, classify_name, classify_inner_name)
4237         (c_print_token): Update.
4238         * p-exp.y: Update rules.
4239         (yylex): Update.
4240         * f-exp.y: Update rules.
4241         (yylex): Update.
4242         * d-exp.y: Update rules.
4243         (lex_one_token, classify_name, classify_inner_name): Update.
4244         * parse.c (write_dollar_variable, copy_name): Return std::string.
4245         * parser-defs.h (copy_name): Change return type.
4246         * m2-exp.y: Update rules.
4247         (yylex): Update.
4248         * go-exp.y (lex_one_token): Update.
4249         Update rules.
4250         (classify_unsafe_function, classify_packaged_name)
4251         (classify_name, yylex): Update.
4252
4253 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4254
4255         * configure.ac: add --enable-source-highlight switch.
4256         * configure: Regenerate.
4257         * top.c (print_gdb_version): plumb --enable-source-highlight
4258         status to "show configuration".
4259
4260 2019-04-19  Tom Tromey  <tromey@adacore.com>
4261
4262         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4263         Check ADA_TYPE_P.
4264         (empty_record, ada_template_to_fixed_record_type_1)
4265         (template_to_static_fixed_type)
4266         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4267         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4268         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4269         macros.
4270
4271 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4272
4273         PR symtab/24423:
4274         * source.c (print_source_lines_base): Advance "iter" when a
4275         control character is seen.
4276
4277 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4278
4279         * inferior.h (struct infcall_suspend_state_deleter):
4280         Catch exception in destructor to avoid crash.
4281
4282 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4283
4284         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4285         close to the add_com "shell".
4286
4287 2019-04-18  Tom Tromey  <tromey@adacore.com>
4288
4289         * process-stratum-target.h (class process_stratum_target)
4290         <stratum>: Add "final".
4291
4292 2019-04-17  Tom Tromey  <tromey@adacore.com>
4293
4294         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4295         against nullptr before use.
4296
4297 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4298
4299         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4300
4301 2019-04-17  Jim Wilson  <jimw@sifive.com>
4302             Andrew Burgess  <andrew.burgess@embecosm.com>
4303
4304         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4305         code read might fail, assume 4-byte breakpoint in that case.
4306
4307 2019-04-15  Leszek Swirski  <leszeks@google.com>
4308
4309         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4310         rather than a hand-rolled POD check when checking for forced MEMORY
4311         classification.
4312
4313 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4314
4315         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4316         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4317         function.
4318         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4319         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4320         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4321         declaration.
4322
4323 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4324
4325         * aarch64-linux-nat.c
4326         (aarch64_linux_nat_target::thread_architecture): Add override.
4327         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4328         each VQ.
4329
4330 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4331
4332         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4333
4334 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4335
4336         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4337         target types of size 96-bits, add some additional comments, and
4338         check that the builtin type we found was the correct size.
4339
4340 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4341
4342         * utils.c (prompt_for_continue): Don't restore the styling at the
4343         end, as applied_style has the wrong value.  This fixes styling in
4344         long lists of file names that are interrupted by the "Continue?"
4345         prompt.
4346
4347 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4348
4349         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4350         * c-lang.c (c_language_defn): Likewise.
4351         (cplus_language_defn): Likewise.
4352         (asm_language_defn): Likewise.
4353         (minimal_language_defn): Likewise.
4354         * d-lang.c (d_language_defn): Likewise.
4355         * f-lang.c (f_language_defn): Likewise.
4356         * go-lang.c (go_language_defn): Likewise.
4357         * language.c (unknown_language_defn): Likewise.
4358         (auto_language_defn): Likewise.
4359         * language.h (struct language_defn): Remove la_magic field.
4360         (LANG_MAGIC): Delete.
4361         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4362         * objc-lang.c (objc_language_defn): Likewise.
4363         * opencl-lang.c (opencl_language_defn): Likewise.
4364         * p-lang.c (pascal_language_defn): Likewise.
4365         * rust-lang.c (rust_language_defn): Likewise.
4366
4367 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4368
4369         * riscv-tdep.c (riscv_type_align): New function.
4370         (riscv_type_alignment): Delete.
4371         (riscv_arg_location): Use 'type_align'.
4372         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4373
4374 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4375
4376         * gdbtypes.c (type_align): A struct with no non-static fields also
4377         has alignment of 1.
4378
4379 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4380
4381         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4382         component to 0.
4383         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4384         member.
4385         (riscv_struct_info::analyse): New implementation using new
4386         analyse_inner member function.
4387         (riscv_struct_info::field_offset): New member function.
4388         (riscv_struct_info::m_offsets): New member variable.
4389         (riscv_struct_info::analyse_inner): New private member function,
4390         takes the old implementation of riscv_struct_info::analyse but
4391         extended to track field offsets.
4392         (riscv_call_arg_struct): Update the struct folding special cases
4393         to handle cases where empty C++ structs, which are non-zero
4394         length, are found.
4395         (riscv_arg_location): Initialise the length of each location, a
4396         non-zero length now indicates the location is in use.
4397         (riscv_push_dummy_call): Allow for the first location having a
4398         non-zero offset when setting up arguments.
4399         (riscv_return_value): Likewise, but for return values.
4400
4401 2019-04-11  Tom Tromey  <tromey@adacore.com>
4402
4403         * utils.c (internal_vproblem): Make "msg" const.
4404
4405 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4406
4407         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4408         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4409         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4410         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4411
4412 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4413
4414         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4415         function.
4416         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4417         of amd64_collect_native_gregset.
4418         (amd64_linux_nat_target::store_registers): Likewise.
4419
4420 2019-04-10  Tom Tromey  <tom@tromey.com>
4421
4422         * symtab.c (lookup_global_symbol_from_objfile)
4423         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4424         * objfiles.h (class separate_debug_iterator): New.
4425         (class separate_debug_range): New.
4426         (struct objfile) <separate_debug_objfiles>: New method.
4427         (objfile_separate_debug_iterate): Don't declare.
4428         * objfiles.c (separate_debug_iterator::operator++): Rename from
4429         objfile_separate_debug_iterate.
4430         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4431         iterator.
4432         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4433         iterator.
4434
4435 2019-04-10  Tom Tromey  <tom@tromey.com>
4436
4437         * symfile.c (reread_symbols): Remove old comment.
4438         * objfiles.c (free_all_objfiles): Fix a typo.
4439
4440 2019-04-10  Tom Tromey  <tom@tromey.com>
4441
4442         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4443         * minsyms.c (lookup_minimal_symbol): Use foreach.
4444         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4445         (lookup_minimal_symbol_solib_trampoline): Likewise.
4446         * symfile.c (reread_symbols): Use foreach.
4447
4448 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4449             Tom Tromey  <tromey@adacore.com>
4450
4451         PR rust/24414:
4452         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4453         (rust_lex_int_test): Change "value" to be LONGEST.
4454         (rust_lex_tests): Add test for long integer literal.
4455
4456 2019-04-09  Tom Tromey  <tromey@adacore.com>
4457
4458         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4459         to bool.
4460         (extended_remote_target::attach): Update.
4461         (remote_target::remote_notice_new_inferior): Update.
4462         (remote_target::add_current_inferior_and_thread): Update.
4463         * inferior.c (exit_inferior_1): Use "false".
4464         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4465
4466 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4467
4468         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4469         the "start" command.
4470
4471 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4472
4473         * python/py-inferior.c (infpy_thread_from_thread_handle):
4474         Adjust comments to reflect renaming of thread_from_thread_handle
4475         to thread_from_handle.  Adjust keywords.  Fix type error message.
4476         (inferior_object_methods): Add thread_from_handle.  Retain
4477         thread_from_thread_handle, but mark it as deprecated.
4478
4479 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4480
4481         * gdbthread.h (find_thread_by_handle): Revise declaration.
4482         * thread.c (find_thread_by_handle): Likewise.  Adjust
4483         implementation too.
4484         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4485         support for buffer objects as handles.
4486
4487 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4488
4489         * python/py-infthread.c (thpy_thread_handle): New function.
4490         (thread_object_methods): Register thpy_thread_handle.
4491
4492 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4493
4494         * gdbthread.h (thread_to_thread_handle): Declare.
4495         * thread.c (gdbtypes.h): Include.
4496         (thread_to_thread_handle): New function.
4497
4498         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4499         (target_thread_info_to_thread_handle): Declare.
4500         * target.c (target_thread_info_to_thread_handle): New function.
4501         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4502         * target-delegates.c: Regenerate.
4503
4504         * linux-thread-db.c (class thread_db_target): Add method
4505         thread_info_to_thread_handle.
4506         (thread_db_target::thread_info_to_thread_handle): Define.
4507         * remote.c (class remote_target): Add new method
4508         thread_info_to_thread_handle.
4509         (remote_target::thread_info_to_thread_handle): Define.
4510
4511 2019-04-08  Pedro Alves  <palves@redhat.com>
4512
4513         * common/common-exceptions.c (throw_exception): Don't create
4514         named object to throw; throw directly.
4515         (throw_it): Likewise.  Don't initialize gdb_exception::message
4516         here, with new; pass FMT and AP to the ctor instead.
4517         * common/common-exceptions.h: Include <string>.
4518         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4519         const char *, va_list)): New ctor.  Use std::make_shared.
4520         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4521         errors)): Delete.
4522         (gdb_exception_error::gdb_exception_error(enum errors, const char
4523         *, va_list)): New.
4524         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4525         Add assertion.
4526         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4527         errors)): Delete.
4528         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4529         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4530         Add assertion.
4531
4532 2019-04-08  Tom Tromey  <tom@tromey.com>
4533
4534         * valops.c (value_rtti_indirect_type): Replace throw_exception
4535         with throw.
4536         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4537         with throw.
4538         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4539         throw.
4540         * target.c (target_translate_tls_address): Replace throw_exception
4541         with throw.
4542         * stack.c (frame_apply_command_count): Replace throw_exception
4543         with throw.
4544         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4545         throw.
4546         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4547         with throw.
4548         * rs6000-tdep.c (rs6000_frame_cache)
4549         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4550         * remote.c: Replace throw_exception with throw.
4551         * record-full.c (record_full_message, record_full_wait_1)
4552         (record_full_restore): Replace throw_exception with throw.
4553         * record-btrace.c:
4554         (get_thread_current_frame_id, record_btrace_start_replaying)
4555         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4556         (cmd_record_btrace_start): Replace throw_exception with throw.
4557         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4558         throw.
4559         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4560         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4561         * linespec.c:
4562         (find_linespec_symbols): Replace throw_exception with throw.
4563         * infrun.c (displaced_step_prepare, resume): Replace
4564         throw_exception with throw.
4565         * infcmd.c (post_create_inferior): Replace throw_exception with
4566         throw.
4567         * inf-loop.c (inferior_event_handler): Replace throw_exception
4568         with throw.
4569         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4570         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4571         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4572         (get_prev_frame_always, get_frame_pc_if_available)
4573         (get_frame_address_in_block_if_available, get_frame_language):
4574         Replace throw_exception with throw.
4575         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4576         throw_exception with throw.
4577         * eval.c (fetch_subexp_value, evaluate_var_value)
4578         (evaluate_funcall, evaluate_subexp_standard): Replace
4579         throw_exception with throw.
4580         * dwarf2loc.c (call_site_find_chain)
4581         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4582         Replace throw_exception with throw.
4583         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4584         with throw.
4585         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4586         throw.
4587         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4588         * completer.c (complete_line_internal): Replace throw_exception
4589         with throw.
4590         * compile/compile-object-run.c (compile_object_run): Replace
4591         throw_exception with throw.
4592         * cli/cli-script.c (process_next_line): Replace throw_exception
4593         with throw.
4594         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4595         (btrace_enable, btrace_maint_update_pt_packets): Replace
4596         throw_exception with throw.
4597         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4598         throw_exception with throw.
4599         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4600         throw_exception with throw.
4601         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4602         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4603         * aarch64-tdep.c (aarch64_make_prologue_cache)
4604         (aarch64_make_stub_cache): Replace throw_exception with throw.
4605
4606 2019-04-08  Tom Tromey  <tom@tromey.com>
4607
4608         * common/common-exceptions.c (throw_exception): Rename from
4609         throw_exception_cxx.  Remove old copy.  Make argument const.
4610         (throw_it): Create and throw exception objects directly.
4611         * common/common-exceptions.h (throw_exception): Make argument
4612         const.
4613         (struct gdb_exception_error): Add constructor.
4614         (struct gdb_exception_quit): Add constructor.
4615
4616 2019-04-08  Tom Tromey  <tom@tromey.com>
4617
4618         * common/common-exceptions.h (exception_rethrow): Don't declare.
4619         (TRY_SJLJ): Update comment.
4620         (TRY, CATCH, END_CATCH): Remove.
4621         * common/common-exceptions.c (exception_rethrow): Remove.
4622
4623 2019-04-08  Tom Tromey  <tom@tromey.com>
4624
4625         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4626         Remove.
4627         (gdb_exception_error): Rename from
4628         gdb_exception_RETURN_MASK_ERROR.
4629         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4630         (gdb_quit_bad_alloc): Update.
4631         * aarch64-tdep.c: Update.
4632         * ada-lang.c: Update.
4633         * ada-typeprint.c: Update.
4634         * ada-valprint.c: Update.
4635         * amd64-tdep.c: Update.
4636         * arch-utils.c: Update.
4637         * break-catch-throw.c: Update.
4638         * breakpoint.c: Update.
4639         * btrace.c: Update.
4640         * c-varobj.c: Update.
4641         * cli/cli-cmds.c: Update.
4642         * cli/cli-interp.c: Update.
4643         * cli/cli-script.c: Update.
4644         * common/common-exceptions.c: Update.
4645         * common/new-op.c: Update.
4646         * common/selftest.c: Update.
4647         * compile/compile-c-symbols.c: Update.
4648         * compile/compile-cplus-symbols.c: Update.
4649         * compile/compile-object-load.c: Update.
4650         * compile/compile-object-run.c: Update.
4651         * completer.c: Update.
4652         * corelow.c: Update.
4653         * cp-abi.c: Update.
4654         * cp-support.c: Update.
4655         * cp-valprint.c: Update.
4656         * darwin-nat.c: Update.
4657         * disasm-selftests.c: Update.
4658         * dtrace-probe.c: Update.
4659         * dwarf-index-cache.c: Update.
4660         * dwarf-index-write.c: Update.
4661         * dwarf2-frame-tailcall.c: Update.
4662         * dwarf2-frame.c: Update.
4663         * dwarf2loc.c: Update.
4664         * dwarf2read.c: Update.
4665         * eval.c: Update.
4666         * event-loop.c: Update.
4667         * event-top.c: Update.
4668         * exec.c: Update.
4669         * f-valprint.c: Update.
4670         * fbsd-tdep.c: Update.
4671         * frame-unwind.c: Update.
4672         * frame.c: Update.
4673         * gdbtypes.c: Update.
4674         * gnu-v3-abi.c: Update.
4675         * guile/guile-internal.h: Update.
4676         * guile/scm-block.c: Update.
4677         * guile/scm-breakpoint.c: Update.
4678         * guile/scm-cmd.c: Update.
4679         * guile/scm-disasm.c: Update.
4680         * guile/scm-frame.c: Update.
4681         * guile/scm-lazy-string.c: Update.
4682         * guile/scm-math.c: Update.
4683         * guile/scm-param.c: Update.
4684         * guile/scm-ports.c: Update.
4685         * guile/scm-pretty-print.c: Update.
4686         * guile/scm-symbol.c: Update.
4687         * guile/scm-symtab.c: Update.
4688         * guile/scm-type.c: Update.
4689         * guile/scm-value.c: Update.
4690         * i386-linux-tdep.c: Update.
4691         * i386-tdep.c: Update.
4692         * inf-loop.c: Update.
4693         * infcall.c: Update.
4694         * infcmd.c: Update.
4695         * infrun.c: Update.
4696         * jit.c: Update.
4697         * language.c: Update.
4698         * linespec.c: Update.
4699         * linux-fork.c: Update.
4700         * linux-nat.c: Update.
4701         * linux-tdep.c: Update.
4702         * linux-thread-db.c: Update.
4703         * main.c: Update.
4704         * mi/mi-cmd-break.c: Update.
4705         * mi/mi-cmd-stack.c: Update.
4706         * mi/mi-interp.c: Update.
4707         * mi/mi-main.c: Update.
4708         * objc-lang.c: Update.
4709         * p-valprint.c: Update.
4710         * parse.c: Update.
4711         * ppc-linux-tdep.c: Update.
4712         * printcmd.c: Update.
4713         * python/py-arch.c: Update.
4714         * python/py-breakpoint.c: Update.
4715         * python/py-cmd.c: Update.
4716         * python/py-finishbreakpoint.c: Update.
4717         * python/py-frame.c: Update.
4718         * python/py-framefilter.c: Update.
4719         * python/py-gdb-readline.c: Update.
4720         * python/py-inferior.c: Update.
4721         * python/py-infthread.c: Update.
4722         * python/py-lazy-string.c: Update.
4723         * python/py-linetable.c: Update.
4724         * python/py-objfile.c: Update.
4725         * python/py-param.c: Update.
4726         * python/py-prettyprint.c: Update.
4727         * python/py-progspace.c: Update.
4728         * python/py-record-btrace.c: Update.
4729         * python/py-record.c: Update.
4730         * python/py-symbol.c: Update.
4731         * python/py-type.c: Update.
4732         * python/py-unwind.c: Update.
4733         * python/py-utils.c: Update.
4734         * python/py-value.c: Update.
4735         * python/python.c: Update.
4736         * record-btrace.c: Update.
4737         * record-full.c: Update.
4738         * remote-fileio.c: Update.
4739         * remote.c: Update.
4740         * riscv-tdep.c: Update.
4741         * rs6000-aix-tdep.c: Update.
4742         * rs6000-tdep.c: Update.
4743         * rust-exp.y: Update.
4744         * rust-lang.c: Update.
4745         * s390-tdep.c: Update.
4746         * selftest-arch.c: Update.
4747         * solib-dsbt.c: Update.
4748         * solib-frv.c: Update.
4749         * solib-spu.c: Update.
4750         * solib-svr4.c: Update.
4751         * solib.c: Update.
4752         * sparc64-linux-tdep.c: Update.
4753         * stack.c: Update.
4754         * symfile-mem.c: Update.
4755         * symmisc.c: Update.
4756         * target.c: Update.
4757         * thread.c: Update.
4758         * top.c: Update.
4759         * tracefile-tfile.c: Update.
4760         * tui/tui.c: Update.
4761         * typeprint.c: Update.
4762         * unittests/cli-utils-selftests.c: Update.
4763         * unittests/parse-connection-spec-selftests.c: Update.
4764         * valops.c: Update.
4765         * valprint.c: Update.
4766         * value.c: Update.
4767         * varobj.c: Update.
4768         * windows-nat.c: Update.
4769         * x86-linux-nat.c: Update.
4770         * xml-support.c: Update.
4771
4772 2019-04-08  Tom Tromey  <tom@tromey.com>
4773
4774         * xml-support.c: Use C++ exception handling.
4775         * x86-linux-nat.c: Use C++ exception handling.
4776         * windows-nat.c: Use C++ exception handling.
4777         * varobj.c: Use C++ exception handling.
4778         * value.c: Use C++ exception handling.
4779         * valprint.c: Use C++ exception handling.
4780         * valops.c: Use C++ exception handling.
4781         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4782         handling.
4783         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4784         * typeprint.c: Use C++ exception handling.
4785         * tui/tui.c: Use C++ exception handling.
4786         * tracefile-tfile.c: Use C++ exception handling.
4787         * top.c: Use C++ exception handling.
4788         * thread.c: Use C++ exception handling.
4789         * target.c: Use C++ exception handling.
4790         * symmisc.c: Use C++ exception handling.
4791         * symfile-mem.c: Use C++ exception handling.
4792         * stack.c: Use C++ exception handling.
4793         * sparc64-linux-tdep.c: Use C++ exception handling.
4794         * solib.c: Use C++ exception handling.
4795         * solib-svr4.c: Use C++ exception handling.
4796         * solib-spu.c: Use C++ exception handling.
4797         * solib-frv.c: Use C++ exception handling.
4798         * solib-dsbt.c: Use C++ exception handling.
4799         * selftest-arch.c: Use C++ exception handling.
4800         * s390-tdep.c: Use C++ exception handling.
4801         * rust-lang.c: Use C++ exception handling.
4802         * rust-exp.y: Use C++ exception handling.
4803         * rs6000-tdep.c: Use C++ exception handling.
4804         * rs6000-aix-tdep.c: Use C++ exception handling.
4805         * riscv-tdep.c: Use C++ exception handling.
4806         * remote.c: Use C++ exception handling.
4807         * remote-fileio.c: Use C++ exception handling.
4808         * record-full.c: Use C++ exception handling.
4809         * record-btrace.c: Use C++ exception handling.
4810         * python/python.c: Use C++ exception handling.
4811         * python/py-value.c: Use C++ exception handling.
4812         * python/py-utils.c: Use C++ exception handling.
4813         * python/py-unwind.c: Use C++ exception handling.
4814         * python/py-type.c: Use C++ exception handling.
4815         * python/py-symbol.c: Use C++ exception handling.
4816         * python/py-record.c: Use C++ exception handling.
4817         * python/py-record-btrace.c: Use C++ exception handling.
4818         * python/py-progspace.c: Use C++ exception handling.
4819         * python/py-prettyprint.c: Use C++ exception handling.
4820         * python/py-param.c: Use C++ exception handling.
4821         * python/py-objfile.c: Use C++ exception handling.
4822         * python/py-linetable.c: Use C++ exception handling.
4823         * python/py-lazy-string.c: Use C++ exception handling.
4824         * python/py-infthread.c: Use C++ exception handling.
4825         * python/py-inferior.c: Use C++ exception handling.
4826         * python/py-gdb-readline.c: Use C++ exception handling.
4827         * python/py-framefilter.c: Use C++ exception handling.
4828         * python/py-frame.c: Use C++ exception handling.
4829         * python/py-finishbreakpoint.c: Use C++ exception handling.
4830         * python/py-cmd.c: Use C++ exception handling.
4831         * python/py-breakpoint.c: Use C++ exception handling.
4832         * python/py-arch.c: Use C++ exception handling.
4833         * printcmd.c: Use C++ exception handling.
4834         * ppc-linux-tdep.c: Use C++ exception handling.
4835         * parse.c: Use C++ exception handling.
4836         * p-valprint.c: Use C++ exception handling.
4837         * objc-lang.c: Use C++ exception handling.
4838         * mi/mi-main.c: Use C++ exception handling.
4839         * mi/mi-interp.c: Use C++ exception handling.
4840         * mi/mi-cmd-stack.c: Use C++ exception handling.
4841         * mi/mi-cmd-break.c: Use C++ exception handling.
4842         * main.c: Use C++ exception handling.
4843         * linux-thread-db.c: Use C++ exception handling.
4844         * linux-tdep.c: Use C++ exception handling.
4845         * linux-nat.c: Use C++ exception handling.
4846         * linux-fork.c: Use C++ exception handling.
4847         * linespec.c: Use C++ exception handling.
4848         * language.c: Use C++ exception handling.
4849         * jit.c: Use C++ exception handling.
4850         * infrun.c: Use C++ exception handling.
4851         * infcmd.c: Use C++ exception handling.
4852         * infcall.c: Use C++ exception handling.
4853         * inf-loop.c: Use C++ exception handling.
4854         * i386-tdep.c: Use C++ exception handling.
4855         * i386-linux-tdep.c: Use C++ exception handling.
4856         * guile/scm-value.c: Use C++ exception handling.
4857         * guile/scm-type.c: Use C++ exception handling.
4858         * guile/scm-symtab.c: Use C++ exception handling.
4859         * guile/scm-symbol.c: Use C++ exception handling.
4860         * guile/scm-pretty-print.c: Use C++ exception handling.
4861         * guile/scm-ports.c: Use C++ exception handling.
4862         * guile/scm-param.c: Use C++ exception handling.
4863         * guile/scm-math.c: Use C++ exception handling.
4864         * guile/scm-lazy-string.c: Use C++ exception handling.
4865         * guile/scm-frame.c: Use C++ exception handling.
4866         * guile/scm-disasm.c: Use C++ exception handling.
4867         * guile/scm-cmd.c: Use C++ exception handling.
4868         * guile/scm-breakpoint.c: Use C++ exception handling.
4869         * guile/scm-block.c: Use C++ exception handling.
4870         * guile/guile-internal.h: Use C++ exception handling.
4871         * gnu-v3-abi.c: Use C++ exception handling.
4872         * gdbtypes.c: Use C++ exception handling.
4873         * frame.c: Use C++ exception handling.
4874         * frame-unwind.c: Use C++ exception handling.
4875         * fbsd-tdep.c: Use C++ exception handling.
4876         * f-valprint.c: Use C++ exception handling.
4877         * exec.c: Use C++ exception handling.
4878         * event-top.c: Use C++ exception handling.
4879         * event-loop.c: Use C++ exception handling.
4880         * eval.c: Use C++ exception handling.
4881         * dwarf2read.c: Use C++ exception handling.
4882         * dwarf2loc.c: Use C++ exception handling.
4883         * dwarf2-frame.c: Use C++ exception handling.
4884         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4885         * dwarf-index-write.c: Use C++ exception handling.
4886         * dwarf-index-cache.c: Use C++ exception handling.
4887         * dtrace-probe.c: Use C++ exception handling.
4888         * disasm-selftests.c: Use C++ exception handling.
4889         * darwin-nat.c: Use C++ exception handling.
4890         * cp-valprint.c: Use C++ exception handling.
4891         * cp-support.c: Use C++ exception handling.
4892         * cp-abi.c: Use C++ exception handling.
4893         * corelow.c: Use C++ exception handling.
4894         * completer.c: Use C++ exception handling.
4895         * compile/compile-object-run.c: Use C++ exception handling.
4896         * compile/compile-object-load.c: Use C++ exception handling.
4897         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4898         * compile/compile-c-symbols.c: Use C++ exception handling.
4899         * common/selftest.c: Use C++ exception handling.
4900         * common/new-op.c: Use C++ exception handling.
4901         * cli/cli-script.c: Use C++ exception handling.
4902         * cli/cli-interp.c: Use C++ exception handling.
4903         * cli/cli-cmds.c: Use C++ exception handling.
4904         * c-varobj.c: Use C++ exception handling.
4905         * btrace.c: Use C++ exception handling.
4906         * breakpoint.c: Use C++ exception handling.
4907         * break-catch-throw.c: Use C++ exception handling.
4908         * arch-utils.c: Use C++ exception handling.
4909         * amd64-tdep.c: Use C++ exception handling.
4910         * ada-valprint.c: Use C++ exception handling.
4911         * ada-typeprint.c: Use C++ exception handling.
4912         * ada-lang.c: Use C++ exception handling.
4913         * aarch64-tdep.c: Use C++ exception handling.
4914
4915 2019-04-08  Tom Tromey  <tom@tromey.com>
4916
4917         * xml-support.c (gdb_xml_parser::parse): Update.
4918         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4919         * value.c (show_convenience): Update.
4920         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4921         (test_parse_flags_qcs): Update.
4922         * thread.c (thr_try_catch_cmd): Update.
4923         * target.c (target_translate_tls_address): Update.
4924         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4925         (info_frame_command_core, frame_apply_command_count): Update.
4926         * rust-exp.y (rust_lex_exception_test): Update.
4927         * riscv-tdep.c (riscv_print_one_register_info): Update.
4928         * remote.c (remote_target::enable_btrace): Update.
4929         * record-btrace.c (record_btrace_enable_warn): Update.
4930         * python/py-utils.c (gdbpy_convert_exception): Update.
4931         * printcmd.c (do_one_display, print_variable_and_value): Update.
4932         * mi/mi-main.c (mi_print_exception): Update.
4933         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4934         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4935         * linux-nat.c (linux_nat_target::attach): Update.
4936         * linux-fork.c (class scoped_switch_fork_info): Update.
4937         * infrun.c (displaced_step_prepare): Update.
4938         * infcall.c (call_function_by_hand_dummy): Update.
4939         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4940         * gnu-v3-abi.c (print_one_vtable): Update.
4941         * frame.c (get_prev_frame_always): Update.
4942         * f-valprint.c (info_common_command_for_block): Update.
4943         * exec.c (try_open_exec_file): Update.
4944         * exceptions.c (print_exception, exception_print)
4945         (exception_fprintf, exception_print_same): Update.
4946         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4947         * dwarf-index-cache.c (index_cache::store)
4948         (index_cache::lookup_gdb_index): Update.
4949         * darwin-nat.c (maybe_cache_shell): Update.
4950         * cp-valprint.c (cp_print_value_fields): Update.
4951         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4952         (gcc_cplus_symbol_address): Update.
4953         * compile/compile-c-symbols.c (gcc_convert_symbol)
4954         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4955         * common/selftest.c: Update.
4956         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4957         a std::string.
4958         (exception_try_scope_entry, exception_try_scope_exit): Don't
4959         declare.
4960         (struct exception_try_scope): Remove.
4961         (TRY): Don't use exception_try_scope.
4962         (struct gdb_exception): Add constructor, operator=.
4963         <what>: New method.
4964         (struct gdb_exception_RETURN_MASK_ALL)
4965         (struct gdb_exception_RETURN_MASK_ERROR)
4966         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4967         (struct gdb_quit_bad_alloc): Update.
4968         * common/common-exceptions.c (exception_none): Change
4969         initializer.
4970         (struct catcher) <state, exception>: Initialize inline.
4971         <prev>: Remove member.
4972         (current_catcher): Remove.
4973         (catchers): New global.
4974         (exceptions_state_mc_init): Simplify.
4975         (catcher_pop): Remove.
4976         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4977         (try_scope_depth, exception_try_scope_entry)
4978         (exception_try_scope_exit): Remove.
4979         (throw_exception_sjlj): Update.
4980         (exception_messages, exception_messages_size): Remove.
4981         (throw_it): Simplify.
4982         (gdb_exception_sliced_copy): Remove.
4983         (throw_exception_cxx): Update.
4984         * cli/cli-script.c (script_from_file): Update.
4985         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4986         Update.
4987         * ada-valprint.c (ada_val_print): Update.
4988         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4989         (create_excep_cond_exprs): Update.
4990
4991 2019-04-08  Tom Tromey  <tom@tromey.com>
4992
4993         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4994         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4995         (TRY, CATCH, END_CATCH): Remove some definitions.
4996         * common/common-exceptions.c: Don't use GDB_XCPT.
4997         (catcher_list_size): Remove.
4998         (throw_exception, throw_it): Simplify.
4999
5000 2019-04-05  Tom Tromey  <tom@tromey.com>
5001
5002         Revert the header-sorting patch.
5003         * ft32-tdep.c: Revert.
5004         * frv-tdep.c: Revert.
5005         * frv-linux-tdep.c: Revert.
5006         * frame.c: Revert.
5007         * frame-unwind.c: Revert.
5008         * frame-base.c: Revert.
5009         * fork-child.c: Revert.
5010         * findvar.c: Revert.
5011         * findcmd.c: Revert.
5012         * filesystem.c: Revert.
5013         * filename-seen-cache.h: Revert.
5014         * filename-seen-cache.c: Revert.
5015         * fbsd-tdep.c: Revert.
5016         * fbsd-nat.h: Revert.
5017         * fbsd-nat.c: Revert.
5018         * f-valprint.c: Revert.
5019         * f-typeprint.c: Revert.
5020         * f-lang.c: Revert.
5021         * extension.h: Revert.
5022         * extension.c: Revert.
5023         * extension-priv.h: Revert.
5024         * expprint.c: Revert.
5025         * exec.h: Revert.
5026         * exec.c: Revert.
5027         * exceptions.c: Revert.
5028         * event-top.c: Revert.
5029         * event-loop.c: Revert.
5030         * eval.c: Revert.
5031         * elfread.c: Revert.
5032         * dwarf2read.h: Revert.
5033         * dwarf2read.c: Revert.
5034         * dwarf2loc.c: Revert.
5035         * dwarf2expr.h: Revert.
5036         * dwarf2expr.c: Revert.
5037         * dwarf2-frame.c: Revert.
5038         * dwarf2-frame-tailcall.c: Revert.
5039         * dwarf-index-write.h: Revert.
5040         * dwarf-index-write.c: Revert.
5041         * dwarf-index-common.c: Revert.
5042         * dwarf-index-cache.h: Revert.
5043         * dwarf-index-cache.c: Revert.
5044         * dummy-frame.c: Revert.
5045         * dtrace-probe.c: Revert.
5046         * disasm.h: Revert.
5047         * disasm.c: Revert.
5048         * disasm-selftests.c: Revert.
5049         * dictionary.c: Revert.
5050         * dicos-tdep.c: Revert.
5051         * demangle.c: Revert.
5052         * dcache.h: Revert.
5053         * dcache.c: Revert.
5054         * darwin-nat.h: Revert.
5055         * darwin-nat.c: Revert.
5056         * darwin-nat-info.c: Revert.
5057         * d-valprint.c: Revert.
5058         * d-namespace.c: Revert.
5059         * d-lang.c: Revert.
5060         * ctf.c: Revert.
5061         * csky-tdep.c: Revert.
5062         * csky-linux-tdep.c: Revert.
5063         * cris-tdep.c: Revert.
5064         * cris-linux-tdep.c: Revert.
5065         * cp-valprint.c: Revert.
5066         * cp-support.c: Revert.
5067         * cp-namespace.c: Revert.
5068         * cp-abi.c: Revert.
5069         * corelow.c: Revert.
5070         * corefile.c: Revert.
5071         * continuations.c: Revert.
5072         * completer.h: Revert.
5073         * completer.c: Revert.
5074         * complaints.c: Revert.
5075         * coffread.c: Revert.
5076         * coff-pe-read.c: Revert.
5077         * cli-out.h: Revert.
5078         * cli-out.c: Revert.
5079         * charset.c: Revert.
5080         * c-varobj.c: Revert.
5081         * c-valprint.c: Revert.
5082         * c-typeprint.c: Revert.
5083         * c-lang.c: Revert.
5084         * buildsym.c: Revert.
5085         * buildsym-legacy.c: Revert.
5086         * build-id.h: Revert.
5087         * build-id.c: Revert.
5088         * btrace.c: Revert.
5089         * bsd-uthread.c: Revert.
5090         * breakpoint.h: Revert.
5091         * breakpoint.c: Revert.
5092         * break-catch-throw.c: Revert.
5093         * break-catch-syscall.c: Revert.
5094         * break-catch-sig.c: Revert.
5095         * blockframe.c: Revert.
5096         * block.c: Revert.
5097         * bfin-tdep.c: Revert.
5098         * bfin-linux-tdep.c: Revert.
5099         * bfd-target.c: Revert.
5100         * bcache.c: Revert.
5101         * ax-general.c: Revert.
5102         * ax-gdb.h: Revert.
5103         * ax-gdb.c: Revert.
5104         * avr-tdep.c: Revert.
5105         * auxv.c: Revert.
5106         * auto-load.c: Revert.
5107         * arm-wince-tdep.c: Revert.
5108         * arm-tdep.c: Revert.
5109         * arm-symbian-tdep.c: Revert.
5110         * arm-pikeos-tdep.c: Revert.
5111         * arm-obsd-tdep.c: Revert.
5112         * arm-nbsd-tdep.c: Revert.
5113         * arm-nbsd-nat.c: Revert.
5114         * arm-linux-tdep.c: Revert.
5115         * arm-linux-nat.c: Revert.
5116         * arm-fbsd-tdep.c: Revert.
5117         * arm-fbsd-nat.c: Revert.
5118         * arm-bsd-tdep.c: Revert.
5119         * arch-utils.c: Revert.
5120         * arc-tdep.c: Revert.
5121         * arc-newlib-tdep.c: Revert.
5122         * annotate.h: Revert.
5123         * annotate.c: Revert.
5124         * amd64-windows-tdep.c: Revert.
5125         * amd64-windows-nat.c: Revert.
5126         * amd64-tdep.c: Revert.
5127         * amd64-sol2-tdep.c: Revert.
5128         * amd64-obsd-tdep.c: Revert.
5129         * amd64-obsd-nat.c: Revert.
5130         * amd64-nbsd-tdep.c: Revert.
5131         * amd64-nbsd-nat.c: Revert.
5132         * amd64-nat.c: Revert.
5133         * amd64-linux-tdep.c: Revert.
5134         * amd64-linux-nat.c: Revert.
5135         * amd64-fbsd-tdep.c: Revert.
5136         * amd64-fbsd-nat.c: Revert.
5137         * amd64-dicos-tdep.c: Revert.
5138         * amd64-darwin-tdep.c: Revert.
5139         * amd64-bsd-nat.c: Revert.
5140         * alpha-tdep.c: Revert.
5141         * alpha-obsd-tdep.c: Revert.
5142         * alpha-nbsd-tdep.c: Revert.
5143         * alpha-mdebug-tdep.c: Revert.
5144         * alpha-linux-tdep.c: Revert.
5145         * alpha-linux-nat.c: Revert.
5146         * alpha-bsd-tdep.c: Revert.
5147         * alpha-bsd-nat.c: Revert.
5148         * aix-thread.c: Revert.
5149         * agent.c: Revert.
5150         * addrmap.c: Revert.
5151         * ada-varobj.c: Revert.
5152         * ada-valprint.c: Revert.
5153         * ada-typeprint.c: Revert.
5154         * ada-tasks.c: Revert.
5155         * ada-lang.c: Revert.
5156         * aarch64-tdep.c: Revert.
5157         * aarch64-ravenscar-thread.c: Revert.
5158         * aarch64-newlib-tdep.c: Revert.
5159         * aarch64-linux-tdep.c: Revert.
5160         * aarch64-linux-nat.c: Revert.
5161         * aarch64-fbsd-tdep.c: Revert.
5162         * aarch64-fbsd-nat.c: Revert.
5163         * aarch32-linux-nat.c: Revert.
5164
5165 2019-04-05  Tom Tromey  <tom@tromey.com>
5166
5167         * ft32-tdep.c: Sort headers.
5168         * frv-tdep.c: Sort headers.
5169         * frv-linux-tdep.c: Sort headers.
5170         * frame.c: Sort headers.
5171         * frame-unwind.c: Sort headers.
5172         * frame-base.c: Sort headers.
5173         * fork-child.c: Sort headers.
5174         * findvar.c: Sort headers.
5175         * findcmd.c: Sort headers.
5176         * filesystem.c: Sort headers.
5177         * filename-seen-cache.h: Sort headers.
5178         * filename-seen-cache.c: Sort headers.
5179         * fbsd-tdep.c: Sort headers.
5180         * fbsd-nat.h: Sort headers.
5181         * fbsd-nat.c: Sort headers.
5182         * f-valprint.c: Sort headers.
5183         * f-typeprint.c: Sort headers.
5184         * f-lang.c: Sort headers.
5185         * extension.h: Sort headers.
5186         * extension.c: Sort headers.
5187         * extension-priv.h: Sort headers.
5188         * expprint.c: Sort headers.
5189         * exec.h: Sort headers.
5190         * exec.c: Sort headers.
5191         * exceptions.c: Sort headers.
5192         * event-top.c: Sort headers.
5193         * event-loop.c: Sort headers.
5194         * eval.c: Sort headers.
5195         * elfread.c: Sort headers.
5196         * dwarf2read.h: Sort headers.
5197         * dwarf2read.c: Sort headers.
5198         * dwarf2loc.c: Sort headers.
5199         * dwarf2expr.h: Sort headers.
5200         * dwarf2expr.c: Sort headers.
5201         * dwarf2-frame.c: Sort headers.
5202         * dwarf2-frame-tailcall.c: Sort headers.
5203         * dwarf-index-write.h: Sort headers.
5204         * dwarf-index-write.c: Sort headers.
5205         * dwarf-index-common.c: Sort headers.
5206         * dwarf-index-cache.h: Sort headers.
5207         * dwarf-index-cache.c: Sort headers.
5208         * dummy-frame.c: Sort headers.
5209         * dtrace-probe.c: Sort headers.
5210         * disasm.h: Sort headers.
5211         * disasm.c: Sort headers.
5212         * disasm-selftests.c: Sort headers.
5213         * dictionary.c: Sort headers.
5214         * dicos-tdep.c: Sort headers.
5215         * demangle.c: Sort headers.
5216         * dcache.h: Sort headers.
5217         * dcache.c: Sort headers.
5218         * darwin-nat.h: Sort headers.
5219         * darwin-nat.c: Sort headers.
5220         * darwin-nat-info.c: Sort headers.
5221         * d-valprint.c: Sort headers.
5222         * d-namespace.c: Sort headers.
5223         * d-lang.c: Sort headers.
5224         * ctf.c: Sort headers.
5225         * csky-tdep.c: Sort headers.
5226         * csky-linux-tdep.c: Sort headers.
5227         * cris-tdep.c: Sort headers.
5228         * cris-linux-tdep.c: Sort headers.
5229         * cp-valprint.c: Sort headers.
5230         * cp-support.c: Sort headers.
5231         * cp-namespace.c: Sort headers.
5232         * cp-abi.c: Sort headers.
5233         * corelow.c: Sort headers.
5234         * corefile.c: Sort headers.
5235         * continuations.c: Sort headers.
5236         * completer.h: Sort headers.
5237         * completer.c: Sort headers.
5238         * complaints.c: Sort headers.
5239         * coffread.c: Sort headers.
5240         * coff-pe-read.c: Sort headers.
5241         * cli-out.h: Sort headers.
5242         * cli-out.c: Sort headers.
5243         * charset.c: Sort headers.
5244         * c-varobj.c: Sort headers.
5245         * c-valprint.c: Sort headers.
5246         * c-typeprint.c: Sort headers.
5247         * c-lang.c: Sort headers.
5248         * buildsym.c: Sort headers.
5249         * buildsym-legacy.c: Sort headers.
5250         * build-id.h: Sort headers.
5251         * build-id.c: Sort headers.
5252         * btrace.c: Sort headers.
5253         * bsd-uthread.c: Sort headers.
5254         * breakpoint.h: Sort headers.
5255         * breakpoint.c: Sort headers.
5256         * break-catch-throw.c: Sort headers.
5257         * break-catch-syscall.c: Sort headers.
5258         * break-catch-sig.c: Sort headers.
5259         * blockframe.c: Sort headers.
5260         * block.c: Sort headers.
5261         * bfin-tdep.c: Sort headers.
5262         * bfin-linux-tdep.c: Sort headers.
5263         * bfd-target.c: Sort headers.
5264         * bcache.c: Sort headers.
5265         * ax-general.c: Sort headers.
5266         * ax-gdb.h: Sort headers.
5267         * ax-gdb.c: Sort headers.
5268         * avr-tdep.c: Sort headers.
5269         * auxv.c: Sort headers.
5270         * auto-load.c: Sort headers.
5271         * arm-wince-tdep.c: Sort headers.
5272         * arm-tdep.c: Sort headers.
5273         * arm-symbian-tdep.c: Sort headers.
5274         * arm-pikeos-tdep.c: Sort headers.
5275         * arm-obsd-tdep.c: Sort headers.
5276         * arm-nbsd-tdep.c: Sort headers.
5277         * arm-nbsd-nat.c: Sort headers.
5278         * arm-linux-tdep.c: Sort headers.
5279         * arm-linux-nat.c: Sort headers.
5280         * arm-fbsd-tdep.c: Sort headers.
5281         * arm-fbsd-nat.c: Sort headers.
5282         * arm-bsd-tdep.c: Sort headers.
5283         * arch-utils.c: Sort headers.
5284         * arc-tdep.c: Sort headers.
5285         * arc-newlib-tdep.c: Sort headers.
5286         * annotate.h: Sort headers.
5287         * annotate.c: Sort headers.
5288         * amd64-windows-tdep.c: Sort headers.
5289         * amd64-windows-nat.c: Sort headers.
5290         * amd64-tdep.c: Sort headers.
5291         * amd64-sol2-tdep.c: Sort headers.
5292         * amd64-obsd-tdep.c: Sort headers.
5293         * amd64-obsd-nat.c: Sort headers.
5294         * amd64-nbsd-tdep.c: Sort headers.
5295         * amd64-nbsd-nat.c: Sort headers.
5296         * amd64-nat.c: Sort headers.
5297         * amd64-linux-tdep.c: Sort headers.
5298         * amd64-linux-nat.c: Sort headers.
5299         * amd64-fbsd-tdep.c: Sort headers.
5300         * amd64-fbsd-nat.c: Sort headers.
5301         * amd64-dicos-tdep.c: Sort headers.
5302         * amd64-darwin-tdep.c: Sort headers.
5303         * amd64-bsd-nat.c: Sort headers.
5304         * alpha-tdep.c: Sort headers.
5305         * alpha-obsd-tdep.c: Sort headers.
5306         * alpha-nbsd-tdep.c: Sort headers.
5307         * alpha-mdebug-tdep.c: Sort headers.
5308         * alpha-linux-tdep.c: Sort headers.
5309         * alpha-linux-nat.c: Sort headers.
5310         * alpha-bsd-tdep.c: Sort headers.
5311         * alpha-bsd-nat.c: Sort headers.
5312         * aix-thread.c: Sort headers.
5313         * agent.c: Sort headers.
5314         * addrmap.c: Sort headers.
5315         * ada-varobj.c: Sort headers.
5316         * ada-valprint.c: Sort headers.
5317         * ada-typeprint.c: Sort headers.
5318         * ada-tasks.c: Sort headers.
5319         * ada-lang.c: Sort headers.
5320         * aarch64-tdep.c: Sort headers.
5321         * aarch64-ravenscar-thread.c: Sort headers.
5322         * aarch64-newlib-tdep.c: Sort headers.
5323         * aarch64-linux-tdep.c: Sort headers.
5324         * aarch64-linux-nat.c: Sort headers.
5325         * aarch64-fbsd-tdep.c: Sort headers.
5326         * aarch64-fbsd-nat.c: Sort headers.
5327         * aarch32-linux-nat.c: Sort headers.
5328
5329 2019-04-04  Tom Tromey  <tom@tromey.com>
5330
5331         * varobj.c (varobj_create): Update.
5332         * rust-exp.y (struct rust_parser) <update_innermost_block,
5333         lookup_symbol>: New methods.
5334         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5335         Rename.
5336         (rust_parser::rust_lookup_type)
5337         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5338         * printcmd.c (display_command, do_one_display): Update.
5339         * parser-defs.h (struct parser_state) <parser_state>: Add
5340         "tracker" parameter.
5341         (block_tracker): New member.
5342         (class innermost_block_tracker) <innermost_block_tracker>: Add
5343         "types" parameter.
5344         <reset>: Remove method.
5345         (innermost_block): Don't declare.
5346         (null_post_parser): Update.
5347         * parse.c (innermost_block): Remove global.
5348         (write_dollar_variable): Update.
5349         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5350         Remove "tracker_types" parameter.
5351         (parse_expression): Add "tracker" parameter.
5352         (parse_expression_for_completion): Update.
5353         (null_post_parser): Add "tracker" parameter.
5354         * p-exp.y: Update rules.
5355         * m2-exp.y: Update rules.
5356         * language.h (struct language_defn) <la_post_parser>: Add
5357         "tracker" parameter.
5358         * go-exp.y: Update rules.
5359         * f-exp.y: Update rules.
5360         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5361         parameter.
5362         * d-exp.y: Update rules.
5363         * c-exp.y: Update rules.
5364         * breakpoint.c (set_breakpoint_condition): Create an
5365         innermost_block_tracker.
5366         (watch_command_1): Likewise.
5367         * ada-lang.c (resolve): Add "tracker" parameter.
5368         (resolve_subexp): Likewise.
5369         * ada-exp.y (write_var_from_sym): Update.
5370
5371 2019-04-04  Tom Tromey  <tom@tromey.com>
5372
5373         * type-stack.h: New file.
5374         * type-stack.c: New file.
5375         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5376         type-stack.h.
5377         (insert_into_type_stack, insert_type, push_type, push_type_int)
5378         (insert_type_address_space, pop_type, pop_type_int)
5379         (pop_typelist, pop_type_stack, append_type_stack)
5380         (push_type_stack, get_type_stack, push_typelist)
5381         (follow_type_instance_flags, follow_types): Don't declare.
5382         * parse.c (type_stack): Remove global.
5383         (parse_exp_in_context): Update.
5384         (insert_into_type_stack, insert_type, push_type, push_type_int)
5385         (insert_type_address_space, pop_type, pop_type_int)
5386         (pop_typelist, pop_type_stack, append_type_stack)
5387         (push_type_stack, get_type_stack, push_typelist)
5388         (follow_type_instance_flags, follow_types): Remove (moved to
5389         type-stack.c).
5390         * f-exp.y (type_stack): New global.
5391         Update rules.
5392         (push_kind_type, f_parse): Update.
5393         * d-exp.y (type_stack): New global.
5394         Update rules.
5395         (d_parse): Update.
5396         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5397         Update rules.
5398         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5399         (HFILES_NO_SRCDIR): Add type-stack.h.
5400
5401 2019-04-04  Tom Tromey  <tom@tromey.com>
5402
5403         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5404         (rust_parser::convert_ast_to_expression, rust_parse)
5405         (rust_lex_test_completion, rust_lex_tests): Update.
5406         * parser-defs.h (struct expr_completion_state): New.
5407         (struct parser_state) <parser_state>: Add completion parameter.
5408         <mark_struct_expression, mark_completion_tag>: New methods.
5409         <parse_completion, m_completion_state>: New members.
5410         (prefixify_expression, null_post_parser): Update.
5411         (mark_struct_expression, mark_completion_tag): Don't declare.
5412         * parse.c (parse_completion, expout_last_struct)
5413         (expout_tag_completion_type, expout_completion_name): Remove
5414         globals.
5415         (parser_state::mark_struct_expression)
5416         (parser_state::mark_completion_tag): Now methods.
5417         (prefixify_expression): Add last_struct parameter.
5418         (prefixify_subexp): Likewise.
5419         (parse_exp_1): Update.
5420         (parse_exp_in_context): Add cstate parameter.  Update.
5421         (parse_expression_for_completion): Create an
5422         expr_completion_state.
5423         (null_post_parser): Add "completion" parameter.
5424         * p-exp.y: Update rules.
5425         (yylex): Update.
5426         * language.h (struct language_defn) <la_post_parser>: Add
5427         "completing" parameter.
5428         * go-exp.y: Update rules.
5429         (lex_one_token): Update.
5430         * expression.h (parse_completion): Don't declare.
5431         * d-exp.y: Update rules.
5432         (lex_one_token): Update rules.
5433         * c-exp.y: Update rules.
5434         (lex_one_token): Update.
5435         * ada-lang.c (resolve): Add "parse_completion" parameter.
5436         (resolve_subexp): Likewise.
5437         (ada_resolve_function): Likewise.
5438
5439 2019-04-04  Tom Tromey  <tom@tromey.com>
5440
5441         * parser-defs.h (struct parser_state) <start_arglist,
5442         end_arglist>: New methods.
5443         <arglist_len, m_funcall_chain>: New members.
5444         (arglist_len, start_arglist, end_arglist): Don't declare.
5445         * parse.c (arglist_len, funcall_chain): Remove global.
5446         (start_arglist, end_arglist): Remove functions.
5447         (parse_exp_in_context): Update.
5448         * p-exp.y: Update rules.
5449         * m2-exp.y: Update rules.
5450         * go-exp.y: Update rules.
5451         * f-exp.y: Update rules.
5452         * d-exp.y: Update rules.
5453         * c-exp.y: Update rules.
5454
5455 2019-04-04  Tom Tromey  <tom@tromey.com>
5456
5457         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5458         lex_operator, push_back>: New methods.
5459         Update all rules.
5460         (rust_parser::lex_hex, lex_escape): Rename and update.
5461         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5462         (rust_parser::lex_operator): Rename and update.
5463         (rust_parser::lex_number, rustyylex, rustyyerror)
5464         (rust_lex_test_init, rust_lex_test_sequence)
5465         (rust_lex_test_push_back, rust_lex_tests): Update.
5466         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5467         parameter.
5468         <lexptr, prev_lexptr>: New members.
5469         (lexptr, prev_lexptr): Don't declare.
5470         * parse.c (lexptr, prev_lexptr): Remove globals.
5471         (parse_exp_in_context): Update.
5472         * p-exp.y (yylex, yyerror): Update.
5473         * m2-exp.y (parse_number, yylex, yyerror): Update.
5474         * go-exp.y (lex_one_token, yyerror): Update.
5475         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5476         * d-exp.y (lex_one_token, yyerror): Update.
5477         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5478         (lex_one_token, yyerror): Update.
5479         * ada-lex.l (YY_INPUT): Update.
5480         (rewind_to_char): Update.
5481         * ada-exp.y (yyerror): Update.
5482
5483 2019-04-04  Tom Tromey  <tom@tromey.com>
5484
5485         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5486         * parser-defs.h (struct parser_state) <parser_state>: Add new
5487         parameter.
5488         <comma_terminates>: New member.
5489         (comma_terminates): Don't declare global.
5490         * parse.c (comma_terminates): Remove global.
5491         (parse_exp_in_context): Update.
5492         * p-exp.y (yylex): Update.
5493         * m2-exp.y (yylex): Update.
5494         * go-exp.y (lex_one_token): Update.
5495         * f-exp.y (yylex): Update.
5496         * d-exp.y (lex_one_token): Update.
5497         * c-exp.y (lex_one_token): Update.
5498         * ada-lex.l: Update.
5499
5500 2019-04-04  Tom Tromey  <tom@tromey.com>
5501
5502         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5503         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5504         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5505         * parser-defs.h (paren_depth): Don't declare.
5506         * parse.c (paren_depth): Remove global.
5507         (parse_exp_in_context): Update.
5508         * p-exp.y (paren_depth): New global.
5509         (pascal_parse): Initialize it.
5510         * m2-exp.y (paren_depth): New global.
5511         (m2_parse): Initialize it.
5512         * go-exp.y (paren_depth): New global.
5513         (go_parse): Initialize it.
5514         * f-exp.y (paren_depth): New global.
5515         (f_parse): Initialize it.
5516         * d-exp.y (paren_depth): New global.
5517         (d_parse): Initialize it.
5518         * c-exp.y (paren_depth): New global.
5519         (c_parse): Initialize it.
5520         * ada-lex.l (paren_depth): New global.
5521         (lexer_init): Initialize it.
5522
5523 2019-04-04  Tom Tromey  <tom@tromey.com>
5524
5525         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5526         (rust_parser::convert_ast_to_type)
5527         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5528         * parser-defs.h (struct parser_state) <parser_state>: Add
5529         parameters.  Initialize new members.
5530         <expression_context_block, expression_context_pc>: New members.
5531         * parse.c (expression_context_block, expression_context_pc):
5532         Remove globals.
5533         (parse_exp_in_context): Update.
5534         * p-exp.y: Update all rules.
5535         (yylex): Update.
5536         * m2-exp.y: Update all rules.
5537         (yylex): Update.
5538         * go-exp.y (yylex): Update.
5539         * f-exp.y (yylex): Update.
5540         * d-exp.y: Update all rules.
5541         (yylex): Update.
5542         * c-exp.y: Update all rules.
5543         (lex_one_token, classify_name, yylex, c_parse): Update.
5544         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5545
5546 2019-04-04  Tom Tromey  <tom@tromey.com>
5547
5548         * gdbarch.h, gdbarch.c: Rebuild.
5549         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5550         * stap-probe.h:
5551         (struct stap_parse_info): Replace "parser_state" with
5552         "expr_builder".
5553         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5554         (parser_state): New class.
5555         * parse.c (expr_builder): Rename.
5556         (expr_builder::release): Rename.
5557         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5558         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5559         (write_exp_elt_longcst, write_exp_elt_floatcst)
5560         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5561         (write_exp_string_vector, write_exp_bitstring)
5562         (write_exp_msymbol, mark_struct_expression)
5563         (write_dollar_variable)
5564         (insert_type_address_space, increase_expout_size): Replace
5565         "parser_state" with "expr_builder".
5566         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5567         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5568         "parser_state" with "expr_builder".
5569
5570 2019-04-04  Tom Tromey  <tom@tromey.com>
5571
5572         * rust-exp.y: Replace "parse_language" with method call.
5573         * p-exp.y:
5574         (yylex): Replace "parse_language" with method call.
5575         * m2-exp.y:
5576         (yylex): Replace "parse_language" with method call.
5577         * go-exp.y (classify_name): Replace "parse_language" with method
5578         call.
5579         * f-exp.y (yylex): Replace "parse_language" with method call.
5580         * d-exp.y (lex_one_token): Replace "parse_language" with method
5581         call.
5582         * c-exp.y:
5583         (lex_one_token, classify_name, yylex): Replace "parse_language"
5584         with method call.
5585         * ada-exp.y (find_primitive_type, type_char)
5586         (type_system_address): Replace "parse_language" with method call.
5587
5588 2019-04-04  Tom Tromey  <tom@tromey.com>
5589
5590         * rust-exp.y: Replace "parse_gdbarch" with method call.
5591         * parse.c (write_dollar_variable, insert_type_address_space):
5592         Replace "parse_gdbarch" with method call.
5593         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5594         call.
5595         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5596         call.
5597         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5598         "parse_gdbarch" with method call.
5599         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5600         with method call.
5601         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5602         "parse_gdbarch" with method call.
5603         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5604         "parse_gdbarch" with method call.
5605         * c-exp.y (parse_type, parse_number, classify_name): Replace
5606         "parse_gdbarch" with method call.
5607         * ada-lex.l: Replace "parse_gdbarch" with method call.
5608         * ada-exp.y (parse_type, find_primitive_type, type_char)
5609         (type_system_address): Replace "parse_gdbarch" with method call.
5610
5611 2019-04-04  Tom Tromey  <tom@tromey.com>
5612
5613         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5614         * stap-probe.c (stap_parse_argument): Update.
5615         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5616         initial_size parameter.
5617         * rust-exp.y (rust_lex_tests): Update.
5618         * parse.c (parser_state): Update.
5619         (parse_exp_in_context): Update.
5620         * parser-defs.h (struct parser_state) <parser_state>: Remove
5621         "initial_size" parameter.
5622
5623 2019-04-04  Tom Tromey  <tom@tromey.com>
5624
5625         * parser-defs.h (increase_expout_size): Don't declare.
5626         * parse.c (increase_expout_size): Now static.
5627
5628 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5629
5630         * gnu-nat.c (gnu_nat_target::wait): Fix
5631         target_waitstatus_to_string call.
5632
5633 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5634
5635         * eval.c (evaluate_subexp_standard): Handle internal functions
5636         during Fortran function call handling.
5637
5638 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5639
5640         * NEWS: Mention new internal functions.
5641         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5642         (read_base_type): Use dwarf2_init_complex_target_type.
5643         * value.c (creal_internal_fn): New function.
5644         (cimag_internal_fn): New function.
5645         (_initialize_values): Register new internal functions.
5646
5647 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5648
5649         * infrun.c (stop_all_threads): If debug_infrun, always
5650         trace the wait status after wait_one, using
5651         target_waitstatus_to_string and target_pid_to_str.
5652         (handle_inferior_event): Replace various trace of
5653         wait status kind by a single trace.
5654         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5655         wait status kind image by target_waitstatus_to_string.
5656         * target/waitstatus.c (target_waitstatus_to_string): Fix
5657         obsolete comment.
5658
5659 2019-04-01  Tom Tromey  <tromey@adacore.com>
5660
5661         PR symtab/23331:
5662         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5663
5664 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5665             Pedro Alves  <palves@redhat.com>
5666
5667         * top.c (quit_force): Call 'finalize_values'.
5668         * value.c (finalize_values): New function.
5669         * value.h (finalize_values): Declare.
5670
5671 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5672
5673         * NEWS: Announce $_gdb_major and $_gdb_minor.
5674
5675         * top.c (init_gdb_version_vars): New function.
5676         (gdb_init): Call init_gdb_version_vars.
5677
5678 2019-03-29  Tom Tromey  <tromey@adacore.com>
5679
5680         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5681         help text.  Remove dead code.
5682
5683 2019-03-29  Keith Seitz  <keiths@redhat.com>
5684
5685         From Siddhesh Poyarekar:
5686         * f-lang.h (f77_get_upperbound): Return LONGEST.
5687         (f77_get_lowerbound): Likewise.
5688         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5689         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5690         print them.
5691         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5692         plongest to format print it.
5693         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5694         (f77_get_upperbound): Likewise.
5695         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5696         LOWER_BOUND to LONGEST.
5697         (f77_create_arrayprint_offset_tbl): Likewise.
5698
5699 2019-03-29  Keith Seitz  <keiths@redhat.com>
5700
5701         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5702         %s/pulongest for TYPE_LENGTH instead of %d in format
5703         strings.
5704         * ada-typerint.c (ada_print_type): Likewise.
5705         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5706         * compile/compile-c-support.c (generate_register_struct): Likewise.
5707         * gdbtypes.c (recursive_dump_type): Likewise.
5708         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5709         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5710         instead of %d in format strings.
5711         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5712         to std::min to ULONGEST.
5713         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5714         instead of %d in format strings.
5715         * tracepoint.c (info_scope_command): Likewise.
5716         * typeprint.c (print_offset_data::update)
5717         (print_offset_data::finish): Likewise.
5718         * xtensa-tdep.c (xtensa_store_return_value)
5719         (xtensa_push_dummy_call): Likewise.
5720
5721 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5722
5723         * windows-nat.c (display_selector): Fixed format specifications
5724         for 64-bit Cygwin.
5725
5726 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5727
5728         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5729
5730 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5731
5732         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5733         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5734         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5735         (nios2_linux_init_abi): Install it.
5736
5737 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5738
5739         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5740
5741 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5742
5743         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5744
5745 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5746             Tom Tromey  <tromey@adacore.com>
5747
5748         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5749
5750 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5751
5752         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5753         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5754         method to compute the bounds of range types. Also print "[evaluated]"
5755         if the bounds' values come from a dynamic evaluation.
5756
5757 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5758
5759         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5760         whitespace when pretty printing is on.
5761
5762 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5763
5764         * ppc-linux-nat.c: Add include.
5765
5766 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5767
5768         * NEWS: Mention AArch64 Pointer Authentication.
5769
5770 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5771
5772         * arm-linux-nat.c: Add include.
5773
5774 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5775
5776         * source-cache.c (source_cache::get_source_lines): Re-read
5777         fullname after calling open_source_file.
5778
5779 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5780
5781         * NEWS: Mention TLS support for FreeBSD.
5782
5783 2019-03-25  Tom Tromey  <tromey@adacore.com>
5784
5785         * minsyms.c (BUNCH_SIZE): Update comment.
5786         (~minimal_symbol_reader): Remove old comment.
5787         (compact_minimal_symbols): Update comment.
5788         (minimal_symbol_reader::install): Remove old comment.  Update
5789         other comments.
5790
5791 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5792
5793         * s390-linux-nat.c: Add include.
5794
5795 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5796
5797         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5798         Call linux_get_hwcap.
5799         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5800         Likewise.
5801         (aarch64_linux_get_hwcap): Remove function.
5802         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5803         declaration.
5804         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5805         linux_get_hwcap.
5806         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5807         * linux-tdep.c (linux_get_hwcap): Add function.
5808         (linux_get_hwcap2): Likewise.
5809         * linux-tdep.h (linux_get_hwcap): Add declaration.
5810         (linux_get_hwcap2): Likewise.
5811         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5812         (ppc_linux_get_hwcap2): Likewise.
5813         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5814         linux_get_hwcap.
5815         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5816         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5817         (ppc_linux_nat_target::read_description): Likewise.
5818         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5819         * s390-linux-nat.c: Likewise.
5820         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5821
5822 2019-03-24  Tom Tromey  <tom@tromey.com>
5823
5824         * ada-lang.c (standard_lookup): Simplify initialization.
5825         (ada_lookup_symbol_nonlocal): Simplify return.
5826         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5827         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5828         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5829         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5830         initialization.
5831         * solib.c (solib_global_lookup): Simplify.
5832         * symtab.c (null_block_symbol): Remove.
5833         (symbol_cache_lookup): Simplify returns.
5834         (lookup_language_this): Simplify returns.
5835         (lookup_symbol_aux): Simplify return.
5836         (lookup_local_symbol): Simplify returns.
5837         (lookup_global_symbol_from_objfile): Simplify return.
5838         (lookup_symbol_in_objfile_symtabs)
5839         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5840         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5841         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5842         * cp-namespace.c (cp_lookup_bare_symbol)
5843         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5844         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5845         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5846         (cp_lookup_symbol_via_imports): Simplify initialization.
5847         (find_symbol_in_baseclass): Likewise.
5848         * symtab.h (null_block_symbol): Remove.
5849         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5850         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5851         (d_lookup_symbol_module): Likewise.
5852         (find_symbol_in_baseclass): Simplify initialization.
5853
5854 2019-03-24  Tom Tromey  <tom@tromey.com>
5855
5856         * expression.h: Don't include symtab.h.
5857         (struct block): Forward declare.
5858
5859 2019-03-24  Tom Tromey  <tom@tromey.com>
5860
5861         * c-exp.y (typebase): Remove casts.
5862         * gdbtypes.c (lookup_unsigned_typename, )
5863         (lookup_signed_typename): Remove cast.
5864         * eval.c (parse_to_comma_and_eval): Remove cast.
5865         * parse.c (write_dollar_variable): Remove cast.
5866         * block.h (struct block) <superblock>: Now const.
5867         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5868         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5869         (map_block): Make "block" const.
5870         * symfile.h (struct quick_symbol_functions)
5871         <map_matching_symbols>: Constify block argument to "callback".
5872         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5873         const.
5874         (find_pc_sect_compunit_symtab): Make "b" const.
5875         (find_symbol_at_address): Likewise.
5876         (search_symbols): Likewise.
5877         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5878         (dw2_debug_names_lookup_symbol): Likewise.
5879         (dw2_map_matching_symbols): Update.
5880         * p-valprint.c (pascal_val_print): Remove "block".
5881         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5882         (aux_add_nonlocal_symbols): Make "block" const.
5883         (resolve_subexp): Remove cast.
5884         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5885         const.
5886         (iterate_over_file_blocks): Likewise.
5887         * f-exp.y (%union) <bval>: Remove.
5888         * coffread.c (patch_opaque_types): Make "b" const.
5889         * spu-tdep.c (spu_catch_start): Make "block" const.
5890         * c-valprint.c (print_unpacked_pointer): Remove "block".
5891         * symmisc.c (dump_symtab_1): Make "b" const.
5892         (block_depth): Make "block" const.
5893         * d-exp.y (%union) <bval>: Remove.
5894         * cp-support.h (cp_lookup_rtti_type): Update.
5895         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5896         * psymtab.c (psym_lookup_symbol): Make "block" const.
5897         (maintenance_check_psymtabs): Make "b" const.
5898         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5899         (enumerate_locals, enumerate_args): Update.
5900         * python/py-symtab.c (stpy_global_block): Make "block" const.
5901         (stpy_static_block): Likewise.
5902         * inline-frame.c (block_starting_point_at): Make "new_block"
5903         const.
5904         * block.c (find_block_in_blockvector): Make return type const.
5905         (blockvector_for_pc_sect): Make "b" const.
5906         (find_block_in_blockvector): Make "b" const.
5907
5908 2019-03-23  Tom Tromey  <tom@tromey.com>
5909
5910         * varobj.c (varobj_create): Update.
5911         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5912         * printcmd.c (display_command, do_one_display): Don't reset
5913         innermost_block.
5914         * parser-defs.h (enum innermost_block_tracker_type): Move to
5915         expression.h.
5916         (innermost_block): Update comment.
5917         * parse.c (parse_exp_1): Add tracker_types parameter.
5918         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5919         tracker_types parameter.  Reset innermost_block.
5920         (parse_exp_in_context): Remove.
5921         (parse_expression_for_completion): Update.
5922         * objfiles.c (~objfile): Don't reset expression_context_block or
5923         innermost_block.
5924         * expression.h (enum innermost_block_tracker_type): Move from
5925         parser-defs.h.
5926         (parse_exp_1): Add tracker_types parameter.
5927         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5928         reset innermost_block.
5929
5930 2019-03-23  Tom Tromey  <tom@tromey.com>
5931
5932         * objfiles.h: Include bcache.h.
5933
5934 2019-03-23  Tom Tromey  <tom@tromey.com>
5935
5936         * linespec.c (get_current_search_block): Use
5937         scoped_restore_current_language.
5938         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5939
5940 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5941             Jiong Wang  <jiong.wang@arm.com>
5942
5943         * aarch64-linux-tdep.c
5944         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5945         section.
5946         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5947
5948 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5949             Jiong Wang  <jiong.wang@arm.com>
5950
5951         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5952         instructions.
5953         (aarch64_analyze_prologue_test): Add PACIASP test.
5954         (aarch64_prologue_prev_register): Unmask PC value.
5955
5956 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5957             Jiong Wang  <jiong.wang@arm.com>
5958
5959         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5960         (aarch64_dwarf2_prev_register): Unmask PC value.
5961         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5962         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5963         DW_CFA_AARCH64_negate_ra_state.
5964         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5965
5966 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5967             Jiong Wang  <jiong.wang@arm.com>
5968
5969         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5970         registers.
5971         (aarch64_pseudo_register_name): Likewise.
5972         (aarch64_pseudo_register_type): Likewise.
5973         (aarch64_pseudo_register_reggroup_p): Likewise.
5974         (aarch64_gdbarch_init): Add pauth registers.
5975         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5976         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5977         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5978         (struct gdbarch_tdep): Add regnum for ra_state.
5979
5980 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5981             Jiong Wang  <jiong.wang@arm.com>
5982
5983         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5984
5985 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5986             Jiong Wang  <jiong.wang@arm.com>
5987
5988         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5989         function.
5990         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5991         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5992         (aarch64_gdbarch_init): Add puth registers.
5993         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5994         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5995         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5996
5997 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5998             Jiong Wang  <jiong.wang@arm.com>
5999
6000         * aarch64-linux-nat.c
6001         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6002         * aarch64-linux-tdep.c
6003         (aarch64_linux_core_read_description): Likewise.
6004         (aarch64_linux_get_hwcap): New function.
6005         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6006         (aarch64_linux_get_hwcap): New declaration.
6007
6008 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6009             Jiong Wang  <jiong.wang@arm.com>
6010
6011         * aarch64-linux-nat.c
6012         (aarch64_linux_nat_target::read_description): Add pauth param.
6013         * aarch64-linux-tdep.c
6014         (aarch64_linux_core_read_description): Likewise.
6015         * aarch64-tdep.c (struct target_desc): Add in pauth.
6016         (aarch64_read_description): Add pauth param.
6017         (aarch64_gdbarch_init): Likewise.
6018         * aarch64-tdep.h (aarch64_read_description): Likewise.
6019         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6020         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6021         * features/Makefile: Add new files.
6022         * features/aarch64-pauth.c: New file.
6023         * features/aarch64-pauth.xml: New file.
6024
6025 2019-03-20  Tom Tromey  <tromey@adacore.com>
6026
6027         * infrun.c (handle_inferior_event): Rename from
6028         handle_inferior_event_1.  Create a scoped_value_mark.
6029         (handle_inferior_event): Remove.
6030
6031 2019-03-19  Tom Tromey  <tromey@adacore.com>
6032
6033         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6034         * infrun.h (print_stop_event): Add "displays" parameter.
6035         * infrun.c (print_stop_event): Add "displays" parameter.
6036
6037 2019-03-19  Pedro Alves  <palves@redhat.com>
6038
6039         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6040         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6041         to -1.  Fix TABs vs spaces.
6042         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6043         * tui/tui-out.h (tui_ui_out) Add intro comments.
6044         <m_line, m_start_of_line>: In-class initialize, and add describing
6045         comment.
6046
6047 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6048
6049         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6050         variable names.
6051         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6052
6053 2019-03-18  Pedro Alves  <palves@redhat.com>
6054             Eli Zaretskii <eliz@gnu.org>
6055
6056         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6057         m_line and m_start_of_line.
6058
6059 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6060
6061         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6062         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6063         it returns a newline.  This fixes a regression in TU mode, whereby
6064         the next line is output on the same screen line as the user input.
6065
6066 2019-03-18  Tom Tromey  <tromey@adacore.com>
6067
6068         * minsyms.c (minimal_symbol_reader::install): Remove call to
6069         obstack_blank.
6070
6071 2019-03-18  Pedro Alves  <palves@redhat.com>
6072
6073         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6074         New globals.
6075         (apply_style): New, factored out from ...
6076         (apply_ansi_escape): ... this.  Handle reverse video mode.
6077         (tui_set_reverse_mode): New function.
6078         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6079         * tui/tui-winsource.c (tui_show_source_line): Use
6080         tui_set_reverse_mode instead of setting A_STANDOUT.
6081         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6082         New setter methods.
6083
6084 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6085
6086         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6087         Handle tabs.
6088
6089 2019-03-18  Tom Tromey  <tromey@adacore.com>
6090
6091         * ada-lang.c (empty_array): Add "high" parameter.
6092         (ada_evaluate_subexp): Update.
6093
6094 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6095
6096         * unittests/string_view-selftests.c: Define
6097         _initialize_string_view_selftests unconditionally.
6098
6099 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6100
6101         PR gdb/24350
6102         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6103
6104 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6105
6106         PR gdb/24351
6107         * windows-nat.c (display_selector): Fix format specifiers.
6108
6109 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6110
6111         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6112         tui_refill_source_window instead of tui_refresh_win, to update the
6113         current execution line.  This fixes redisplay of the current line
6114         when stepping through the code with "next" or "step".
6115
6116 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6117
6118         * source-cache.c (source_cache::get_source_lines): Call
6119         find_source_lines to initialize s->nlines.  This fixes vertical
6120         scrolling of TUI source window when the DOWN arrow is pressed.
6121
6122 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6123
6124         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6125         linux-thread-db.c (_initialize_thread_db): Likewise.
6126
6127 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6128
6129         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6130         wclrtoeol in tui_show_source_line".  This reverts changes made in
6131         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6132
6133 2019-03-15  Tom Tromey  <tom@tromey.com>
6134
6135         * symtab.h (struct minimal_symbol): Derive from
6136         general_symbol_info.
6137         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6138         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6139         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6140         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6141         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6142         (MSYMBOL_SEARCH_NAME): Update.
6143         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6144         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6145         * minsyms.c (minimal_symbol_reader::record_full): Update.
6146
6147 2019-03-15  Tom Tromey  <tom@tromey.com>
6148
6149         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6150
6151 2019-03-15  Tom Tromey  <tom@tromey.com>
6152
6153         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6154         unique_xmalloc_ptr.
6155         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6156         Update.
6157         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6158         (build_minimal_symbol_hash_tables)
6159         (minimal_symbol_reader::install): Update.
6160
6161 2019-03-15  Tom Tromey  <tom@tromey.com>
6162
6163         * symtab.c (create_demangled_names_hash): Update.
6164         (symbol_set_names): Update.
6165         * objfiles.h (struct objfile_per_bfd_storage)
6166         <demangled_names_hash>: Now an htab_up.
6167         * objfiles.c (objfile_per_bfd_storage): Simplify.
6168
6169 2019-03-15  Tom Tromey  <tom@tromey.com>
6170
6171         * objfiles.h (struct objfile_per_bfd_storage): Declare
6172         destructor.
6173         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6174         New.
6175         (get_objfile_bfd_data): Use new.  Don't initialize
6176         language_of_main.
6177         (free_objfile_per_bfd_storage): Remove.
6178         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6179
6180 2019-03-15  Tom Tromey  <tom@tromey.com>
6181
6182         * symfile.c (reread_symbols): Update.
6183         * objfiles.c (objfile::objfile): Update.
6184         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6185         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6186         comment.
6187         (minimal_symbol_reader::install): Update.
6188         (terminate_minimal_symbol_table): Remove.
6189         * jit.c (jit_object_close_impl): Update.
6190
6191 2019-03-15  Tom Tromey  <tom@tromey.com>
6192
6193         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6194         initializations.
6195
6196 2019-03-15  Tom Tromey  <tom@tromey.com>
6197
6198         * objfiles.h (struct objfile_per_bfd_storage)
6199         <demangled_hash_languages>: Now a bitset.
6200         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6201         (lookup_minimal_symbol): Update.
6202
6203 2019-03-15  Tom Tromey  <tom@tromey.com>
6204
6205         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6206         Don't return the symbol.
6207         * coffread.c (record_minimal_symbol): Use record_full.
6208
6209 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6210
6211         The MS-Windows port of ncurses fails to switch to a color pair if
6212         one or both of the colors are the implicit default colors.  This
6213         change records the default colors when TUI is initialized, and
6214         then specifies them explicitly when a color pair uses the default
6215         colors.  This allows color styling in TUI mode on MS-Windows.
6216
6217         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6218         ncurses_norm_attr.
6219         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6220         colors in ncurses_norm_attr.
6221         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6222         "none", replace it with the default color recorded in
6223         ncurses_norm_attr.
6224
6225 2019-03-14  Tom Tromey  <tromey@adacore.com>
6226
6227         * source-cache.h (class source_cache) <get_source_lines>: Return
6228         std::string.
6229         * source-cache.c (source_cache::extract_lines): Handle case where
6230         first_pos==npos.  Return std::string.
6231         (source_cache::get_source_lines): Update.
6232
6233 2019-03-14  Tom Tromey  <tromey@adacore.com>
6234
6235         * NEWS: Add item for "style sources" commands.
6236         * source-cache.c (source_cache::get_source_lines): Check
6237         source_styling.
6238         * cli/cli-style.c (source_styling): New global.
6239         (_initialize_cli_style): Add "style sources" commands.
6240         (show_style_sources): New function.
6241         * cli/cli-style.h (source_styling): Declare.
6242
6243 2019-03-14  Pedro Alves  <palves@redhat.com>
6244             Tom Tromey  <tromey@adacore.com>
6245
6246         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6247         * tui/tui-winsource.c (tui_refill_source_window): New function,
6248         from...
6249         (tui_horizontal_source_scroll): ... here.  Move some logic.
6250         * cli/cli-style.c (set_style_enabled): Notify new observable.
6251         * tui/tui-hooks.c (tui_redisplay_source): New function.
6252         (tui_attach_detach_observers): Attach or detach
6253         tui_redisplay_source.
6254         * observable.h (source_styling_changed): New observable.
6255         * observable.c: Define source_styling_changed observable.
6256
6257 2019-03-13  Tom Tromey  <tromey@adacore.com>
6258
6259         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6260         (i386_gnu_nat_target::store_registers): Update.
6261         * target-debug.h (target_debug_print_std_string): New macro.
6262         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6263         * windows-tdep.c (display_one_tib): Update.
6264         * tui/tui-stack.c (tui_make_status_line): Update.
6265         * top.c (print_inferior_quit_action): Update.
6266         * thread.c (thr_try_catch_cmd): Update.
6267         (add_thread_with_info): Update.
6268         (thread_target_id_str): Update.
6269         (thr_try_catch_cmd): Update.
6270         (thread_command): Update.
6271         (thread_find_command): Update.
6272         * record-btrace.c (record_btrace_target::info_record)
6273         (record_btrace_resume_thread, record_btrace_target::resume)
6274         (record_btrace_cancel_resume, record_btrace_step_thread)
6275         (record_btrace_target::wait, record_btrace_target::wait)
6276         (record_btrace_target::wait, record_btrace_target::stop): Update.
6277         * progspace.c (print_program_space): Update.
6278         * process-stratum-target.c
6279         (process_stratum_target::thread_address_space): Update.
6280         * linux-fork.c (linux_fork_mourn_inferior)
6281         (detach_checkpoint_command, info_checkpoints_command)
6282         (linux_fork_context): Update.
6283         (linux_fork_detach): Update.
6284         (class scoped_switch_fork_info): Update.
6285         (delete_checkpoint_command): Update.
6286         * infrun.c (follow_fork_inferior): Update.
6287         (follow_fork_inferior): Update.
6288         (proceed_after_vfork_done): Update.
6289         (handle_vfork_child_exec_or_exit): Update.
6290         (follow_exec): Update.
6291         (displaced_step_prepare_throw): Update.
6292         (displaced_step_restore): Update.
6293         (start_step_over): Update.
6294         (resume_1): Update.
6295         (clear_proceed_status_thread): Update.
6296         (proceed): Update.
6297         (print_target_wait_results): Update.
6298         (do_target_wait): Update.
6299         (context_switch): Update.
6300         (stop_all_threads): Update.
6301         (restart_threads): Update.
6302         (finish_step_over): Update.
6303         (handle_signal_stop): Update.
6304         (switch_back_to_stepped_thread): Update.
6305         (keep_going_pass_signal): Update.
6306         (print_exited_reason): Update.
6307         (normal_stop): Update.
6308         * inferior.c (inferior_pid_to_str): Change return type.
6309         (print_selected_inferior): Update.
6310         (add_inferior): Update.
6311         (detach_inferior): Update.
6312         * dummy-frame.c (fprint_dummy_frames): Update.
6313         * dcache.c (dcache_info_1): Update.
6314         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6315         (btrace_fetch, btrace_clear): Update.
6316         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6317         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6318         type.
6319         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6320         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6321         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6322         * gdbarch.c, gdbarch.h: Rebuild.
6323         * gdbarch.sh (core_pid_to_str): Change return type.
6324         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6325         return type.
6326         (windows_nat_target::pid_to_str): Change return type.
6327         (windows_delete_thread): Update.
6328         (windows_nat_target::attach): Update.
6329         (windows_nat_target::files_info): Update.
6330         * target-delegates.c: Rebuild.
6331         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6332         return type.
6333         (sol_thread_target::pid_to_str): Change return type.
6334         * remote.c (class remote_target) <pid_to_str>: Change return
6335         type.
6336         (remote_target::pid_to_str): Change return type.
6337         (extended_remote_target::attach, remote_target::remote_stop_ns)
6338         (remote_target::remote_notif_remove_queued_reply)
6339         (remote_target::push_stop_reply, remote_target::disable_btrace):
6340         Update.
6341         (extended_remote_target::attach): Update.
6342         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6343         type.
6344         (gdbsim_target::pid_to_str): Change return type.
6345         * ravenscar-thread.c (struct ravenscar_thread_target)
6346         <pid_to_str>: Change return type.
6347         (ravenscar_thread_target::pid_to_str): Change return type.
6348         * procfs.c (class procfs_target) <pid_to_str>: Change return
6349         type.
6350         (procfs_target::pid_to_str): Change return type.
6351         (procfs_target::attach): Update.
6352         (procfs_target::detach): Update.
6353         (procfs_target::fetch_registers): Update.
6354         (procfs_target::store_registers): Update.
6355         (procfs_target::wait): Update.
6356         (procfs_target::files_info): Update.
6357         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6358         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6359         return type.
6360         (nto_procfs_target::pid_to_str): Change return type.
6361         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6362         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6363         return type.
6364         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6365         (exit_lwp): Update.
6366         (attach_proc_task_lwp_callback, get_detach_signal)
6367         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6368         (linux_nat_target::resume, wait_lwp, stop_callback)
6369         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6370         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6371         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6372         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6373         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6374         type.
6375         (inf_ptrace_target::attach): Update.
6376         (inf_ptrace_target::files_info): Update.
6377         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6378         type.
6379         (go32_nat_target::pid_to_str): Change return type.
6380         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6381         (gnu_nat_target::wait): Update.
6382         (gnu_nat_target::wait): Update.
6383         (gnu_nat_target::resume): Update.
6384         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6385         (fbsd_nat_target::wait): Update.
6386         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6387         type.
6388         (darwin_nat_target::attach): Update.
6389         * corelow.c (class core_target) <pid_to_str>: Change return type.
6390         (core_target::pid_to_str): Change return type.
6391         * target.c (normal_pid_to_str): Change return type.
6392         (default_pid_to_str): Likewise.
6393         (target_pid_to_str): Change return type.
6394         (target_translate_tls_address): Update.
6395         (target_announce_detach): Update.
6396         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6397         return type.
6398         (bsd_uthread_target::pid_to_str): Change return type.
6399         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6400         type.
6401         (bsd_kvm_target::pid_to_str): Change return type.
6402         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6403         return type.
6404         (aix_thread_target::pid_to_str): Change return type.
6405         * target.h (struct target_ops) <pid_to_str>: Change return type.
6406         (target_pid_to_str, normal_pid_to_str): Likewise.
6407         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6408         type.
6409         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6410         type.
6411         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6412         return type.
6413         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6414         type.
6415         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6416         type.
6417         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6418         return type.
6419
6420 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6421
6422         * NEWS: Mention that the new default MI version is 3.  Mention
6423         changes to the output of commands and events that deal with
6424         multi-location breakpoints.
6425         * breakpoint.c: Include "mi/mi-out.h".
6426         (print_one_breakpoint): Change output syntax if using MI version
6427         >= 3.
6428         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6429         New.
6430         (mi_multi_location_breakpoint_output_fixed): New.
6431         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6432         (mi_cmd_fix_multi_location_breakpoint_output): New.
6433         (mi_multi_location_breakpoint_output_fixed): New.
6434         * mi/mi-cmds.c (mi_cmds): Register command
6435         -fix-multi-location-breakpoint-output.
6436         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6437         interpreter "mi".
6438
6439 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6440
6441         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6442         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6443         instantiate mi_ui_out based on interpreter name.
6444         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6445         * mi/mi-main.c (mi_load_progress): Likewise.
6446
6447 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6448
6449         * NEWS: Combine separate "New targets" sections for 8.3.
6450
6451 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6452
6453         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6454         (ppcfbsd_init_abi): Install gdbarch
6455         "fetch_tls_load_module_address" and "get_thread_local_address"
6456         methods.
6457
6458 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6459
6460         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6461         (riscv_fbsd_init_abi): Install gdbarch
6462         "fetch_tls_load_module_address" and "get_thread_local_address"
6463         methods.
6464
6465 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6466
6467         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6468         (i386fbsd_init_abi): Install gdbarch
6469         "fetch_tls_load_module_address" and "get_thread_local_address"
6470         methods.
6471
6472 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6473
6474         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6475         (amd64fbsd_init_abi): Install gdbarch
6476         "fetch_tls_load_module_address" and "get_thread_local_address"
6477         methods.
6478
6479 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6480
6481         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6482         (struct fbsd_pspace_data): New type.
6483         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6484         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6485         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6486         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6487         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6488
6489 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6490
6491         * gdbtypes.c (lookup_struct_elt): New function.
6492         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6493         * gdbtypes.h (struct struct_elt): New type.
6494         (lookup_struct_elt): New prototype.
6495
6496 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6497
6498         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6499         remove disabled code block.
6500
6501 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6502
6503         * gdbarch.sh (get_thread_local_address): New method.
6504         * gdbarch.h, gdbarch.c: Regenerate.
6505         * target.c (target_translate_tls_address): Use
6506         gdbarch_get_thread_local_address if present instead of
6507         target::get_thread_local_address.
6508
6509 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6510
6511         * target.h (target::get_thread_local_address): Update comment.
6512
6513 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6514
6515         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6516         objfile->separate_debug_objfile_backlink if not NULL.
6517
6518 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6519
6520         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6521         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6522         (amd64bsd_store_inferior_registers): Likewise.
6523         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6524         Enable segment base registers.
6525         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6526         PT_GETFSBASE and PT_GETGSBASE.
6527         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6528         PT_SETGSBASE.
6529         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6530         segment base registers.
6531         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6532
6533 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6534
6535         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6536         Update calls to i386_target_description to add 'segments'
6537         parameter.
6538         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6539         add segment base registers.
6540         * arch/i386.c (i386_create_target_description): Add 'segments'
6541         parameter to enable segment base registers.
6542         * arch/i386.h (i386_create_target_description): Likewise.
6543         * features/i386/32bit-segments.xml: New file.
6544         * features/i386/32bit-segments.c: Generate.
6545         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6546         call to i386_target_description to add 'segments' parameter.
6547         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6548         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6549         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6550         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6551         if feature is present.
6552         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6553         Add 'segments' parameter to call to i386_target_description.
6554         (i386_target_description): Add 'segments' parameter to enable
6555         segment base registers.
6556         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6557         to call to i386_target_description.
6558         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6559         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6560         Define I386_NUM_REGS.
6561         (i386_target_description): Add 'segments' parameter to enable
6562         segment base registers.
6563
6564 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6565
6566         PR/24325
6567         * source-cache.c: #undef open and close, to avoid unresolved
6568         externals during linking.
6569
6570 2019-03-12  Tom Tromey  <tromey@adacore.com>
6571
6572         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6573         const.  Add initializers.
6574         (_initialize_remote): Don't initialize ptid globals.
6575
6576 2019-03-12  Pedro Alves  <palves@redhat.com>
6577
6578         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6579
6580 2019-03-12  Pedro Alves  <palves@redhat.com>
6581
6582         * cp-name-parser.y (main): Remove unused 'len' variable.
6583
6584 2019-03-12  Tom Tromey  <tromey@adacore.com>
6585
6586         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6587         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6588
6589 2019-03-12  Tom Tromey  <tromey@adacore.com>
6590
6591         * linux-nat.c (iterate_over_lwps): Update.
6592         (stop_callback): Remove parameter.
6593         (stop_wait_callback, detach_callback, resume_set_callback)
6594         (select_singlestep_lwp_callback, set_ignore_sigint)
6595         (status_callback, resumed_callback, resume_clear_callback)
6596         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6597         data parameter.
6598         (linux_nat_target::detach, linux_nat_target::resume)
6599         (linux_stop_and_wait_all_lwps, select_event_lwp)
6600         (linux_nat_filter_event, linux_nat_wait_1)
6601         (linux_nat_target::kill, linux_nat_target::stop)
6602         (linux_nat_target::stop): Update.
6603         (linux_nat_resume_callback): Change type.
6604         (resume_stopped_resumed_lwps, count_events_callback)
6605         (select_event_lwp_callback): Likewise.
6606         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6607         * arm-linux-nat.c (struct update_registers_data): Remove.
6608         (update_registers_callback): Change type.
6609         (arm_linux_insert_hw_breakpoint1): Update.
6610         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6611         parameter.
6612         (x86_linux_dr_set_addr): Update.
6613         (x86_linux_dr_set_control): Update.
6614         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6615         (iterate_over_lwps): Use gdb::function_view.
6616         * nat/aarch64-linux-hw-point.c (struct
6617         aarch64_dr_update_callback_param): Remove.
6618         (debug_reg_change_callback): Change type.
6619         (aarch64_notify_debug_reg_change): Update.
6620         * s390-linux-nat.c (s390_refresh_per_info): Update.
6621
6622 2019-03-11  Tom Tromey  <tromey@adacore.com>
6623
6624         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6625         redundant assignment to "this_cu".
6626
6627 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6628
6629         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6630
6631 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6632
6633         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6634         from...
6635         (rank_one_type): ... this.
6636
6637 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6638
6639         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6640         from...
6641         (rank_one_type): ... this.
6642
6643 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6644
6645         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6646         from...
6647         (rank_one_type): ... this.
6648
6649 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6650
6651         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6652         from...
6653         (rank_one_type): ... this.
6654
6655 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6656
6657         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6658         from...
6659         (rank_one_type): ... this.
6660
6661 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6662
6663         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6664         from...
6665         (rank_one_type): ... this.
6666
6667 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6668
6669         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6670         from...
6671         (rank_one_type): ... this.
6672
6673 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6674
6675         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6676         from...
6677         (rank_one_type): ... this.
6678
6679 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6680
6681         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6682         from...
6683         (rank_one_type): ... this.
6684
6685 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6686
6687         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6688         from...
6689         (rank_one_type): ... this.
6690
6691 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6692
6693         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6694         from...
6695         (rank_one_type): ... this.
6696
6697 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6698
6699         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6700         from...
6701         (rank_one_type): ... this.
6702
6703 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6704
6705         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6706         inferior-events' shows the example events.
6707
6708 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6709
6710         Support styling on native MS-Windows console
6711
6712         PR/24315
6713         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6714         on MS-Windows if $TERM is not defined.
6715
6716         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6717
6718         * posix-hdep.c (gdb_console_fputs):
6719         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6720         functions.
6721         * ui-file.h (gdb_console_fputs): Add prototype.
6722
6723         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6724         back to fputs only if the former returns zero.
6725
6726 2019-03-07  Tom Tromey  <tom@tromey.com>
6727
6728         * symmisc.c (print_symbol_bcache_statistics): Update.
6729         (print_objfile_statistics): Update.
6730         * symfile.c (allocate_symtab): Update.
6731         * stabsread.c: Don't include bcache.h.
6732         * psymtab.h (struct psymbol_bcache): Don't declare.
6733         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6734         (psymbol_bcache_init, psymbol_bcache_free)
6735         (psymbol_bcache_get_bcache): Don't declare.
6736         * psymtab.c (struct psymbol_bcache): Remove.
6737         (psymtab_storage::psymtab_storage): Update.
6738         (psymtab_storage::~psymtab_storage): Update.
6739         (psymbol_bcache_init, psymbol_bcache_free)
6740         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6741         (add_psymbol_to_bcache): Update.
6742         (allocate_psymtab): Update.
6743         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6744         macro_cache>: No longer pointers.
6745         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6746         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6747         * macrotab.c (macro_bcache): Update.
6748         * macroexp.c: Don't include bcache.h.
6749         * gdbtypes.c (check_types_worklist): Update.
6750         (types_deeply_equal): Remove TRY/CATCH.  Update.
6751         * elfread.c (elf_symtab_read): Update.
6752         * dwarf2read.c: Don't include bcache.h.
6753         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6754         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6755         (print_bcache_statistics, bcache_memory_used): Don't declare.
6756         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6757         methods.  Rename all data members.
6758         * bcache.c (struct bcache): Move to bcache.h.
6759         (bcache::expand_hash_table): Rename from expand_hash_table.
6760         (bcache): Remove.
6761         (bcache::insert): Rename from bcache_full.
6762         (bcache::compare): Rename from bcache_compare.
6763         (bcache_xmalloc): Remove.
6764         (bcache::~bcache): Rename from bcache_xfree.
6765         (bcache::print_statistics): Rename from print_bcache_statistics.
6766         (bcache::memory_used): Rename from bcache_memory_used.
6767
6768 2019-03-07  Pedro Alves  <palves@redhat.com>
6769
6770         * infrun.c (normal_stop): Also check for
6771         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6772
6773 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6774
6775         * f-lang.c (value_from_host_double): Moved to...
6776         * value.c (value_from_host_double): ...here.
6777         * value.h (value_from_host_double): Declare.
6778         * guile/scm-math.c (vlscm_convert_typed_number): Use
6779         value_from_host_double.
6780         (vlscm_convert_number): Likewise.
6781         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6782         * python/py-value.c (convert_value_from_python): Likewise.
6783
6784 2019-03-06  Tom Tromey  <tom@tromey.com>
6785
6786         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6787
6788 2019-03-06  Tom Tromey  <tom@tromey.com>
6789
6790         * utils.h (free_current_contents): Don't declare.
6791         * utils.c (free_current_contents): Remove.
6792
6793 2019-03-06  Tom Tromey  <tom@tromey.com>
6794
6795         * top.c (quit_force): Update.
6796         * main.c (captured_command_loop): Update.
6797         * common/new-op.c (operator new): Update.
6798         * common/common-exceptions.c (struct catcher)
6799         <save_cleanup_chain>: Remove member.
6800         (exceptions_state_mc_init): Update.
6801         (exception_try_scope_entry): Return nullptr.
6802         (exception_try_scope_exit, exception_rethrow)
6803         (throw_exception_sjlj, throw_exception_cxx): Update.
6804         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6805         (all_cleanups, do_cleanups, discard_cleanups)
6806         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6807         (restore_cleanups, restore_final_cleanups): Don't declare.
6808         (do_final_cleanups): Remove parameter.
6809         * common/cleanups.c (cleanup_chain, make_cleanup)
6810         (make_cleanup_dtor, all_cleanups, do_cleanups)
6811         (discard_my_cleanups, discard_cleanups)
6812         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6813         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6814         (null_cleanup): Remove.
6815         (do_final_cleanups): Remove parameter.
6816
6817 2019-03-06  Tom Tromey  <tom@tromey.com>
6818
6819         * remote.c (remote_target::remote_parse_stop_reply): Use
6820         unique_xmalloc_ptr.
6821
6822 2019-03-06  Tom Tromey  <tom@tromey.com>
6823
6824         * stabsread.c (struct stabs_field_info): Rename from field_info.
6825         <list, fnlist>: Add initializers.
6826         <obstack>: New member.
6827         (read_member_functions, read_struct_fields, read_baseclasses):
6828         Allocate on obstack.  Don't use cleanups.
6829         (read_one_struct_field, read_member_functions, read_struct_fields)
6830         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6831         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6832         (read_struct_type): Update.
6833
6834 2019-03-06  Tom Tromey  <tom@tromey.com>
6835
6836         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6837         * common/filestuff.h (make_cleanup_close): Don't declare.
6838         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6839         Remove.
6840
6841 2019-03-06  Tom Tromey  <tom@tromey.com>
6842
6843         * solib-aix.c: Use make_scope_exit.
6844
6845 2019-03-06  Tom Tromey  <tom@tromey.com>
6846
6847         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6848         Use make_scope_exit.
6849
6850 2019-03-06  Tom Tromey  <tom@tromey.com>
6851
6852         * solib-svr4.c (disable_probes_interface): Remove parameter.
6853         (svr4_handle_solib_event): Use make_scope_exit.
6854
6855 2019-03-06  Tom Tromey  <tom@tromey.com>
6856
6857         * remote.c (struct stop_reply_deleter): Remove.
6858         (stop_reply_up): Update.
6859         (struct stop_reply): Derive from notif_event.  Don't typedef.
6860         <regcache>: Now a std::vector.
6861         (stop_reply_xfree): Remove.
6862         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6863         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6864         (remote_target::discard_pending_stop_replies): Use delete.
6865         (remote_target::remote_parse_stop_reply): Update.
6866         (remote_target::process_stop_reply): Update.
6867         * remote-notif.h (struct notif_event): Add virtual destructor.
6868         Remove "dtr" member.
6869         (struct notif_client) <alloc_event>: Return a unique_ptr.
6870         (notif_event_xfree): Don't declare.
6871         (notif_event_up): New typedef.
6872         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6873         (notif_event_xfree, do_notif_event_xfree): Remove.
6874         (remote_notif_state_xfree): Update.
6875
6876 2019-03-06  Tom Tromey  <tom@tromey.com>
6877
6878         * infrun.c (displaced_step_clear_cleanup): Now a
6879         forward_scope_exit type.
6880         (displaced_step_prepare_throw): Update.
6881         (displaced_step_fixup): Update.
6882
6883 2019-03-06  Tom Tromey  <tom@tromey.com>
6884
6885         * inferior.h (class inferior): Update comment.
6886         * gdbthread.h (class thread_info): Update comment.
6887
6888 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6889             Tom Tromey  <tom@tromey.com>
6890
6891         * stabsread.h (struct stab_section_list): Remove.
6892         (coffstab_build_psymtabs): Update.
6893         * dbxread.c (symbuf_sections): Now a std::vector.
6894         (sect_idx): New global.
6895         (fill_symbuf): Update.
6896         (coffstab_build_psymtabs): Change type of stabsects parameter.
6897         Update.
6898         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6899         std::vector.
6900         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6901         (coff_locate_sections): Update.
6902         (coff_symfile_read): Remove cleanups.  Update.
6903         (init_stringtab): Add storage parameter.
6904         (free_stringtab, free_stringtab_cleanup): Remove.
6905         (init_lineno): Add storage parameter.
6906         (free_linetab, free_linetab_cleanup): Remove.
6907
6908 2019-03-06  Pedro Alves  <palves@redhat.com>
6909
6910         * linux-fork.c (fork_info::clobber_regs): Delete.
6911         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6912         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6913         comment.  Adjust.
6914         (scoped_switch_fork_info::scoped_switch_fork_info)
6915         (checkpoint_command, linux_fork_context): Adjust
6916         fork_save_infrun_state calls.
6917
6918 2019-03-06  Pedro Alves  <palves@redhat.com>
6919
6920         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6921         (inf_has_multiple_threads): Return 'bool' and rewrite using
6922         inferior_info::threads().
6923
6924 2019-03-06  Pedro Alves  <palves@redhat.com>
6925
6926         * linux-fork.c: Include <list>.
6927         (fork_list): Now a std::list instance.
6928         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6929         (forks_exist_p, find_last_fork): Adjust.
6930         (new_fork): Delete.
6931         (one_fork_p): New.
6932         (add_fork): Adjust.
6933         (free_fork): Delete, folded into fork_info::~fork_info().
6934         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6935         Adjust.
6936         (init_fork_list): Delete.
6937         (linux_fork_killall, linux_fork_mourn_inferior)
6938         (linux_fork_detach, info_checkpoints_command): Adjust.
6939         (_initialize_linux_fork): No longer call init_fork_list.
6940
6941 2019-03-06  Pedro Alves  <palves@redhat.com>
6942
6943         * linux-fork.c (new_fork): New, split out of ...
6944         (add_fork): ... this.  Return void.  Move "first fork" special
6945         case from here, to ...
6946         (checkpoint_command): ... here.
6947         * linux-linux.h (add_fork): Return void.
6948
6949 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6950
6951         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6952
6953 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6954             Chris January  <chris.january@arm.com>
6955             David Lecomber  <david.lecomber@arm.com>
6956
6957         * f-exp.y: New token, UNOP_INTRINSIC.
6958         (exp): New pattern using UNOP_INTRINSIC token.
6959         (f77_keywords): Add 'abs' keyword.
6960         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6961         (value_from_host_double): New function.
6962         (evaluate_subexp_f): Support UNOP_ABS.
6963
6964 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6965
6966         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6967         types.
6968
6969 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6970
6971         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6972         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6973         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6974
6975 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6976
6977         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6978
6979 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6980             Chris January  <chris.january@arm.com>
6981
6982         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6983         * f-exp.y: Define 'KIND' token.
6984         (exp): New pattern for KIND expressions.
6985         (ptype): Handle types with a kind extension.
6986         (direct_abs_decl): Extend to spot kind extensions.
6987         (f77_keywords): Add 'kind' to the list.
6988         (push_kind_type): New function.
6989         (convert_to_kind_type): New function.
6990         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6991         * parse.c (operator_length_standard): Likewise.
6992         * parser-defs.h (enum type_pieces): Add tp_kind.
6993         * std-operator.def: Add UNOP_KIND.
6994
6995 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6996
6997         * f-exp.y (f_parse): Set yydebug.
6998
6999 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7000
7001         * f-lang.c (evaluate_subexp_f): New function.
7002         (exp_descriptor_f): New global.
7003         (f_language_defn): Use exp_descriptor_f instead of
7004         exp_descriptor_standard.
7005
7006 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7007
7008         * f-exp.y (struct token): Add comments.
7009         (dot_ops): Remove uppercase versions and the end marker.
7010         (f77_keywords): Likewise.
7011         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7012         entries in the dot_ops array are case insensitive, and use
7013         strncasecmp to compare strings.  Also some whitespace cleanup in
7014         this area.  Similar for the f77_keywords array, except entries in
7015         this list might be case sensitive.
7016
7017 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7018
7019         * f-exp.y (struct f77_boolean_val): Add comments.
7020         (boolean_values): Remove uppercase versions, and end marker.
7021         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7022         and use strncasecmp to achieve case insensitivity.  Additionally,
7023         perform whitespace cleanup around this code.
7024
7025 2019-03-06  Tom Tromey  <tromey@adacore.com>
7026
7027         * remote-sim.c (gdbsim_target_open): Use result of
7028         gdb_argv::release.
7029
7030 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7031         Dirk Schubert  <dirk.schubert@arm.com>
7032         Chris January  <chris.january@arm.com>
7033
7034         * eval.c (evaluate_subexp_standard): Call Fortran argument
7035         wrapping logic.
7036         * f-lang.c (struct value): A value which can be passed into a
7037         Fortran function call.
7038         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7039         where appropriate.
7040         (struct type): Value ready for a Fortran function call.
7041         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7042         is needed.
7043         * f-lang.h (fortran_argument_convert): Declaration.
7044         (fortran_preserve_arg_pointer): Declaration.
7045         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7046
7047 2019-03-05  Tom Tromey  <tromey@adacore.com>
7048
7049         * python/py-prettyprint.c (print_string_repr): Remove #if.
7050         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7051
7052 2019-03-05  Tom Tromey  <tromey@adacore.com>
7053
7054         * target.c (the_dummy_target): Move later.  Change type to
7055         "dummy_target".
7056         (initialize_targets): Don't initialize the_dummy_target.
7057
7058 2019-03-05  Tom Tromey  <tromey@adacore.com>
7059
7060         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7061         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7062
7063 2019-03-05  Tom Tromey  <tromey@adacore.com>
7064
7065         * windows-nat.c (windows_nat_target::attach)
7066         (windows_nat_target::detach): Don't call gdb_flush.
7067         * valprint.c (generic_val_print, val_print, val_print_string):
7068         Don't call gdb_flush.
7069         * utils.c (defaulted_query): Don't call gdb_flush.
7070         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7071         * target.c (target_announce_detach): Don't call gdb_flush.
7072         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7073         * remote.c (extended_remote_target::attach): Don't call
7074         gdb_flush.
7075         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7076         * printcmd.c (do_examine): Don't call gdb_flush.
7077         (info_display_command): Don't call gdb_flush.
7078         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7079         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7080         * memattr.c (info_mem_command): Don't call gdb_flush.
7081         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7082         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7083         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7084         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7085         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7086         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7087         (gnu_nat_target::detach): Don't call gdb_flush.
7088         * f-valprint.c (f_val_print): Don't call gdb_flush.
7089         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7090         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7091         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7092         gdb_flush.
7093         * c-valprint.c (c_val_print): Don't call gdb_flush.
7094         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7095
7096 2019-03-05  Tom Tromey  <tromey@adacore.com>
7097
7098         * varobj.c (update_dynamic_varobj_children): Update.
7099         (install_default_visualizer): Use reset, not release.
7100         * value.c (set_internalvar): Update.
7101         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7102         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7103         ATTRIBUTE_UNUSED_RESULT.
7104
7105 2019-03-05  Tom Tromey  <tromey@adacore.com>
7106
7107         * remote.c (class scoped_remote_fd) <release>: Add
7108         ATTRIBUTE_UNUSED_RESULT.
7109
7110 2019-03-05  Tom Tromey  <tromey@adacore.com>
7111
7112         * macroexp.c (struct macro_buffer) <release>: Add
7113         ATTRIBUTE_UNUSED_RESULT.
7114
7115 2019-03-05  Tom Tromey  <tromey@adacore.com>
7116
7117         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7118         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7119         ATTRIBUTE_UNUSED_RESULT.
7120
7121 2019-03-05  Tom Tromey  <tromey@adacore.com>
7122
7123         * common/scoped_fd.h (class scoped_fd) <release>: Add
7124         ATTRIBUTE_UNUSED_RESULT.
7125
7126 2019-03-05  Tom Tromey  <tromey@adacore.com>
7127
7128         * parser-defs.h (struct parser_state) <release>: Add
7129         ATTRIBUTE_UNUSED_RESULT.
7130
7131 2019-03-05  Tom Tromey  <tromey@adacore.com>
7132
7133         * utils.h (class gdb_argv) <release>: Add
7134         ATTRIBUTE_UNUSED_RESULT.
7135         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7136
7137 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7138
7139         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7140         for-loop range, to avoid compiler warnings.
7141
7142         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7143         avoid compiler warnings about unused variables.
7144
7145         * NEWS: Mention end of support for native debugging on MS-Windows
7146         before XP.
7147
7148         PR gdb/24292
7149         * common/netstuff.c:
7150         * gdbserver/gdbreplay.c
7151         * gdbserver/remote-utils.c:
7152         * ser-tcp.c:
7153         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7154         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7155         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7156         'getaddrinfo' and 'freeaddrinfo' were not available before
7157         Windows XP, and mingw.org's MinGW headers by default define
7158         _WIN32_WINNT to 0x500.
7159
7160 2019-03-01  Gary Benson <gbenson@redhat.com>
7161
7162         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7163
7164 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7165             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7166
7167         PR gdb/8527
7168         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7169         set_sigint_trap, clear_sigint_trap.
7170
7171 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7172
7173         * target.c (target_detach): Clear the regcache and the
7174         frame cache.
7175
7176 2019-02-27  Pedro Alves  <palves@redhat.com>
7177
7178         * utils.c (set_screen_size): When we cap the height/width sizes,
7179         tweak the corresponding command variable to show "unlimited":
7180
7181 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7182             Pedro Alves  <palves@redhat.com>
7183
7184         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7185         before calling rl_set_screen_size.
7186
7187 2019-02-27  Tom Tromey  <tromey@adacore.com>
7188
7189         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7190         define.
7191         * python/py-value.c: Remove Python 2.4 workaround.
7192         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7193         workaround.
7194         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7195         Python 2.4 workaround.
7196         * python/python-internal.h: Remove Python 2.4 comment.
7197         (Py_ssize_t): Don't define.
7198         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7199         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7200         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7201         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7202         * python/python.c (do_start_initialization): Remove Python 2.4
7203         workaround.
7204         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7205         (print_children): Remove Python 2.4 workaround.
7206         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7207         workaround.
7208         (CHARBUFFERPROC_NAME): Remove.
7209         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7210         Python 2.4 workaround.
7211
7212 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7213
7214         * NEWS: Note minimum Python version.
7215
7216 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7217
7218         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7219         code from these functions.  Remove corresponding ifdefs.  Use
7220         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7221         Remove gotos and target of gotos.
7222         (infpy_search_memory): Likewise.
7223
7224 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7225
7226         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7227         (hppa_gdbarch_init): Don't register deleted functions with
7228         gdbarch.
7229
7230 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7231
7232         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7233         (h8300_unwind_sp): Delete.
7234         (h8300_dummy_id): Delete.
7235         (h8300_gdbarch_init): Don't register deleted functions with
7236         gdbarch.
7237
7238 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7239
7240         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7241         (ft32_unwind_pc): Delete.
7242         (ft32_unwind_sp): Delete.
7243         (ft32_gdbarch_init): Don't register deleted functions with
7244         gdbarch.
7245
7246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7247
7248         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7249         (frv_unwind_pc): Delete.
7250         (frv_unwind_sp): Delete.
7251         (frv_gdbarch_init): Don't register deleted functions with
7252         gdbarch.
7253
7254 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7255
7256         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7257         (riscv_unwind_pc): Delete.
7258         (riscv_unwind_sp): Delete.
7259         (riscv_gdbarch_init): Don't register deleted functions with
7260         gdbarch.
7261
7262 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7263
7264         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7265         (csky_unwind_pc): Delete.
7266         (csky_unwind_sp): Delete.
7267         (csky_gdbarch_init): Don't register deleted functions with
7268         gdbarch.
7269
7270 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7271
7272         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7273         (cris_unwind_pc): Delete.
7274         (cris_unwind_sp): Delete.
7275         (cris_gdbarch_init): Don't register deleted functions with
7276         gdbarch.
7277
7278 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7279
7280         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7281         (bfin_unwind_pc): Delete.
7282         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7283
7284 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7285
7286         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7287         (arm_unwind_pc): Delete.
7288         (arm_unwind_sp): Delete.
7289         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7290
7291 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7292
7293         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7294         (arc_unwind_pc): Delete.
7295         (arc_unwind_sp): Delete.
7296         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7297
7298 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7299
7300         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7301         (alpha_unwind_pc): Delete.
7302         (alpha_gdbarch_init): Don't register deleted functions with
7303         gdbarch.
7304
7305 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7306
7307         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7308         (aarch64_unwind_pc): Delete.
7309         (aarch64_unwind_sp): Delete.
7310         (aarch64_gdbarch_init): Don't register deleted functions with
7311         gdbarch.
7312
7313 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7314
7315         * gdbtypes.c (type_align): Don't consider static members when
7316         computing structure alignment.
7317
7318 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7319
7320         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7321         return 0 for other types.
7322         * arch-utils.c (default_type_align): Always return 0.
7323         * gdbarch.h: Regenerate.
7324         * gdbarch.sh (type_align): Extend comment.
7325         * gdbtypes.c (type_align): Add additional comments, always call
7326         gdbarch_type_align before applying the default rules.
7327         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7328         generic code will then apply a suitable default.
7329         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7330         types, return 0 for other types.
7331
7332 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7333
7334         * NEWS: Create a new section for the next release branch.
7335         Rename the section of the current branch, now that it has
7336         been cut.
7337
7338 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7339
7340         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7341         * version.in: Bump version to 8.3.50.DATE-git.
7342
7343 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7344
7345         * aix-thread.c (ptid_cmp): Remove unused variable.
7346         (get_signaled_thread): Likewise.
7347         (store_regs_user_thread): Likewise.
7348         (store_regs_kernel_thread): Likewise.
7349         (fetch_regs_kernel_thread): Remove shadowed variable.
7350
7351 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7352
7353         * features/riscv/32bit-cpu.xml: Add register numbers.
7354         * features/riscv/32bit-fpu.c: Regenerate.
7355         * features/riscv/32bit-fpu.xml: Add register numbers.
7356         * features/riscv/64bit-cpu.xml: Add register numbers.
7357         * features/riscv/64bit-fpu.c: Regenerate.
7358         * features/riscv/64bit-fpu.xml: Add register numbers.
7359
7360 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7361
7362         * NEWS: Mention two argument form of gdb.Value constructor.
7363         * python/py-value.c (convert_buffer_and_type_to_value): New
7364         function.
7365         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7366         Add support for handling an optional second argument.  Call
7367         convert_buffer_and_type_to_value as appropriate.
7368         * python/python-internal.h (Py_buffer_deleter): New struct.
7369         (Py_buffer_up): New typedef.
7370
7371 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7372
7373         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7374         instead of releasing ownership.
7375
7376 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7377
7378         * dwarf2read.c (open_and_init_dwp_file): Call
7379         elf_numsections instead of bfd_count_sections to initialize
7380         dwp_file->num_sections.
7381
7382 2019-02-25  Tom Tromey  <tromey@adacore.com>
7383
7384         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7385
7386 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7387
7388         * gcore.in: Add '--readnever' option when invoking GDB.
7389
7390 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7391
7392         * MAINTAINERS: Update my email address.
7393
7394 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7395
7396         * build-id.c (build_id_to_debug_bfd_1): New function.
7397         (build_id_to_debug_bfd): Look for separate debug file in
7398         sysroot.
7399
7400 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7401
7402         * gdbarch.sh: Update the copyright year range that is placed into
7403         generated files.
7404
7405 2019-02-22  Keith Seitz  <keiths@redhat.com>
7406
7407         PR symtab/23853
7408         * linespec.c (create_sals_line_offset): Search for the default
7409         symtab's filename instead of its fullname.
7410
7411 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7412
7413         * NEWS: Update style defaults.
7414
7415 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7416
7417         * main.c (captured_main_1): Disable styling in batch mode.
7418
7419 2019-02-20  Tom Tromey  <tom@tromey.com>
7420
7421         * symtab.c (symtab_symbol_info): Fix typos.
7422
7423 2019-02-20  Tom Tromey  <tromey@adacore.com>
7424
7425         * findcmd.c (_initialize_mem_search): Use upper case for
7426         metasyntactic variables.
7427
7428 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7429
7430         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7431         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7432
7433 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7434
7435         * top.h (source_file_name): Change to std::string.
7436         * top.c (source_file_name): Likewise.
7437         (command_line_input): Adjust.
7438         * cli/cli-script.c (script_from_file): Adjust.
7439
7440 2019-02-19  Tom Tromey  <tromey@adacore.com>
7441
7442         * ravenscar-thread.c
7443         (ravenscar_thread_target::update_thread_list): Don't call
7444         ada_build_task_list.
7445         * ada-lang.h (ada_build_task_list): Don't declare.
7446         * ada-tasks.c (struct ada_tasks_inferior_data)
7447         <task_list_valid_p>: Now bool.
7448         (read_known_tasks, ada_task_list_changed)
7449         (ada_tasks_invalidate_inferior_data): Update.
7450         (read_known_tasks_array): Return bool.
7451         (read_known_tasks_list): Likewise.
7452         (read_known_tasks): Return void.
7453         (ada_build_task_list): Now static.
7454
7455 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7456
7457         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7458         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7459
7460 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7461
7462         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7463         variant for ada_tasks_pspace_data_handle and
7464         ada_tasks_inferior_data_handle.
7465         (ada_tasks_pspace_data_cleanup): New function.
7466         (ada_tasks_inferior_data_cleanup): New function.
7467
7468 2019-02-17  Tom Tromey  <tom@tromey.com>
7469
7470         * macrotab.h (macro_source_fullname): Return a std::string.
7471         * macrotab.c (macro_include, check_for_redefinition)
7472         (macro_undef, macro_lookup_definition, foreach_macro)
7473         (foreach_macro_in_scope): Update.
7474         (macro_source_fullname): Return a std::string.
7475         * macrocmd.c (show_pp_source_pos): Update.
7476
7477 2019-02-17  Tom Tromey  <tom@tromey.com>
7478
7479         * macrocmd.c (show_pp_source_pos): Style the file names.
7480
7481 2019-02-17  Tom Tromey  <tom@tromey.com>
7482
7483         PR tui/24197:
7484         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7485
7486 2019-02-17  Tom Tromey  <tom@tromey.com>
7487
7488         * ada-lang.c (user_select_syms): Use filtered printing.
7489         * utils.c (wrap_style): New global.
7490         (desired_style): Remove.
7491         (emit_style_escape): Add stream parameter.
7492         (set_output_style, reset_terminal_style, prompt_for_continue):
7493         Update.
7494         (flush_wrap_buffer): Only flush gdb_stdout.
7495         (wrap_here): Set wrap_style.
7496         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7497         treat escape sequences as a character.  Change when wrap buffer is
7498         flushed.
7499         (fputs_styled): Do not set the output style when the default is
7500         requested.
7501         * ui-style.h (struct ui_file_style) <is_default>: New method.
7502         * source.c (print_source_lines_base): Emit escape sequences in one
7503         piece.
7504
7505 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7506
7507         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7508         integers and enumeration types.
7509
7510 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7511
7512         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7513         instead of lookup_symbol_in_language
7514         (do_exact_match): New function.
7515         (ada_get_symbol_name_matcher): Return do_exact_match when
7516         doing a verbatim match.
7517
7518 2019-02-15  Tom Tromey  <tromey@adacore.com>
7519
7520         * ravenscar-thread.c (ravenscar_thread_target::resume)
7521         (ravenscar_thread_target::wait): Special case wildcard requests.
7522
7523 2019-02-15  Tom Tromey  <tromey@adacore.com>
7524
7525         * ravenscar-thread.c (base_ptid): Remove.
7526         (struct ravenscar_thread_target) <close>: New method.
7527         <m_base_ptid>: New member.
7528         <update_inferior_ptid, active_task, task_is_currently_active,
7529         runtime_initialized>: Declare methods.
7530         <ravenscar_thread_target>: Add constructor.
7531         (ravenscar_thread_target::task_is_currently_active)
7532         (ravenscar_thread_target::update_inferior_ptid)
7533         (ravenscar_runtime_initialized): Rename.  Now methods.
7534         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7535         (ravenscar_thread_target::update_thread_list): Update.
7536         (ravenscar_thread_target::active_task): Now method.
7537         (ravenscar_thread_target::store_registers)
7538         (ravenscar_thread_target::prepare_to_store)
7539         (ravenscar_thread_target::prepare_to_store)
7540         (ravenscar_thread_target::mourn_inferior): Update.
7541         (ravenscar_inferior_created): Use "new" to create target.
7542         (ravenscar_thread_target::get_ada_task_ptid): Update.
7543         (_initialize_ravenscar): Don't initialize base_ptid.
7544         (ravenscar_ops): Remove global.
7545
7546 2019-02-15  Tom Tromey  <tromey@adacore.com>
7547
7548         * target.h (push_target): Declare new overload.
7549         * target.c (push_target): New overload, taking an rvalue reference.
7550         * remote.c (remote_target::open_1): Use push_target overload.
7551         * corelow.c (core_target_open): Use push_target overload.
7552
7553 2019-02-15  Tom Tromey  <tromey@adacore.com>
7554
7555         * ravenscar-thread.c (is_ravenscar_task)
7556         (ravenscar_task_is_currently_active): Return bool.
7557         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7558         (_initialize_ravenscar): Remove "(void)".
7559         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7560         Return bool.
7561
7562 2019-02-15  Tom Tromey  <tromey@adacore.com>
7563
7564         * ravenscar-thread.c (ravenscar_runtime_initializer)
7565         (has_ravenscar_runtime, get_running_thread_id)
7566         (ravenscar_thread_target::resume): Fix indentation.
7567
7568 2019-02-15  Tom Tromey  <tromey@adacore.com>
7569
7570         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7571         from ravenscar_arch_ops.
7572         (sparc_ravenscar_ops::fetch_registers)
7573         (sparc_ravenscar_ops::store_registers): Now methods.
7574         (sparc_ravenscar_prepare_to_store): Remove.
7575         (sparc_ravenscar_ops): Redefine.
7576         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7577         methods and destructor.  Remove members.
7578         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7579         (ravenscar_thread_target::store_registers)
7580         (ravenscar_thread_target::prepare_to_store): Update.
7581         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7582         Remove.
7583         (struct ppc_ravenscar_powerpc_ops): Derive from
7584         ravenscar_arch_ops.
7585         (ppc_ravenscar_powerpc_ops::fetch_registers)
7586         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7587         (ppc_ravenscar_powerpc_ops): Redefine.
7588         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7589         (ppc_ravenscar_e500_ops::fetch_registers)
7590         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7591         (ppc_ravenscar_e500_ops): Redefine.
7592         * aarch64-ravenscar-thread.c
7593         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7594         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7595         (aarch64_ravenscar_fetch_registers)
7596         (aarch64_ravenscar_store_registers): Now methods.
7597         (aarch64_ravenscar_ops): Redefine.
7598
7599 2019-02-15  Tom Tromey  <tromey@adacore.com>
7600
7601         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7602         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7603         (ravenscar_thread_target::stopped_by_watchpoint)
7604         (ravenscar_thread_target::stopped_data_address)
7605         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7606
7607 2019-02-15  Tom Tromey  <tromey@adacore.com>
7608
7609         * ravenscar-thread.c: Fix some typos.
7610
7611 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7612             Tom Tromey  <tromey@adacore.com>
7613
7614         * ada-lang.c (ada_exception_sal): Change addr_string to a
7615         std::string.
7616         (create_ada_exception_catchpoint): Update.
7617
7618 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7619             Tom Tromey  <tromey@adacore.com>
7620
7621         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7622         (bp_location_ops): Remove.
7623         (base_breakpoint_allocate_location): Update.
7624         (free_bp_location): Update.
7625         * ada-lang.c (class ada_catchpoint_location)
7626         <ada_catchpoint_location>: Remove ops parameter.
7627         (ada_catchpoint_location_dtor): Remove.
7628         (ada_catchpoint_location_ops): Remove.
7629         (allocate_location_exception): Update.
7630         * breakpoint.h (struct bp_location_ops): Remove.
7631         (class bp_location) <bp_location>: Remove bp_location_ops
7632         parameter.
7633         <~bp_location>: Add destructor.
7634         <ops>: Remove.
7635
7636 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7637             Pedro Alves  <palves@redhat.com>
7638
7639         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7640         'PATH_MAX'.
7641
7642 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7643             Samuel Thibault  <samuel.thibault@gnu.org>
7644             Thomas Schwinge  <thomas@codesourcery.com>
7645
7646         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7647         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7648
7649 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7650
7651         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7652         (check_empty): Use "const char *".
7653
7654         * gnu-nat.c (gnu_nat_target::detach): Instead of
7655         'detach_inferior (pid)' call
7656         'detach_inferior (find_inferior_pid (pid))'.
7657
7658         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7659         'nat/fork-inferior.o'.
7660         * gnu-nat.c: #include "nat/fork-inferior.h".
7661
7662         * gnu-nat.c (gnu_nat_target::detach): Instead of
7663         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7664         * gnu-nat.h: #include "inf-child.h".
7665         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7666         'i386_gnu_nat_target::fetch_registers'.
7667         (gnu_store_registers): Rename/move to
7668         'i386_gnu_nat_target::store_registers'.
7669
7670         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7671         * gnu-nat.h (mach_thread_info): New function.
7672         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7673
7674         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7675
7676 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7677
7678         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7679
7680 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7681
7682         * windows-nat.c (windows_add_thread): Add new parameter
7683         "main_thread_p" with default value set to false.  Update
7684         function documentation as well as all callers.
7685         (windows_delete_thread): Likewise.
7686         (fake_create_process): Update call to windows_add_thread.
7687         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7688         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7689         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7690         call to windows_delete_thread.
7691
7692 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7693
7694         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7695
7696 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7697
7698         * symfile.c (find_separate_debug_file): Use canonical path of
7699         sysroot with child_path instead of gdb_sysroot if it is valid.
7700
7701 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7702
7703         * symfile.c (find_separate_debug_file): Use child_path to
7704         determine if an object file is under a sysroot.
7705
7706 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7707
7708         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7709         unittests/child-path-selftests.c.
7710         * common/pathstuff.c (child_path): New function.
7711         * common/pathstuff.h (child_path): New prototype.
7712         * unittests/child-path-selftests.c: New file.
7713
7714 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7715
7716         * symfile.c (find_separate_debug_file): Look for separate debug
7717         files in debug directories under the sysroot.
7718
7719 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7720
7721         * symtab.h (struct minimal_symbol data_p): New const method.
7722         (struct minimal_symbol text_p): Likewise.
7723         * symtab.c (output_source_filename): Use file name style
7724         to print file name.
7725         (print_symbol_info): Likewise.
7726         (print_msymbol_info): Use address style to print addresses.
7727         Use function name style to print executable text symbols.
7728         (expand_symtab_containing_pc): Use data_p.
7729         (find_pc_sect_compunit_symtab): Likewise.
7730
7731 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7732
7733         * breakpoint.c (describe_other_breakpoints): Use address style
7734         to print addresses.
7735         (say_where): Likewise.
7736
7737 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7738
7739         * ada-typeprint.c (print_func_type): Print function name
7740         style to print function name.
7741         * c-typeprint.c (c_print_type_1): Likewise.
7742
7743 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7744
7745         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7746         for execve.
7747
7748 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7749
7750         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7751         type_stack.
7752
7753 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7754
7755         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7756         TYPE_CODE_REF types.
7757
7758 2019-02-08  Jim Wilson  <jimw@sifive.com>
7759
7760         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7761         (riscv_linux_fregset): New.
7762         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7763
7764 2019-02-07  Tom Tromey  <tom@tromey.com>
7765
7766         * thread.c (thread_cancel_execution_command): Update.
7767         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7768         methods.
7769         (struct thread_fsm_ops): Remove.
7770         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7771         (thread_fsm_should_stop, thread_fsm_return_value)
7772         (thread_fsm_set_finished, thread_fsm_finished_p)
7773         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7774         Don't declare.
7775         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7776         * infrun.c (clear_proceed_status_thread)
7777         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7778         (print_stop_event): Update.
7779         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7780         Add constructor.
7781         (step_command_fsm_ops): Remove.
7782         (new_step_command_fsm): Remove.
7783         (step_1): Update.
7784         (step_command_fsm::should_stop): Rename from
7785         step_command_fsm_should_stop.
7786         (step_command_fsm::clean_up): Rename from
7787         step_command_fsm_clean_up.
7788         (step_command_fsm::do_async_reply_reason): Rename from
7789         step_command_fsm_async_reply_reason.
7790         (struct until_next_fsm): Inherit from thread_fsm.  Add
7791         constructor.
7792         (until_next_fsm_ops): Remove.
7793         (new_until_next_fsm): Remove.
7794         (until_next_fsm::should_stop): Rename from
7795         until_next_fsm_should_stop.
7796         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7797         (until_next_fsm::do_async_reply_reason): Rename from
7798         until_next_fsm_async_reply_reason.
7799         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7800         constructor.  Change type of breakpoint.
7801         (finish_command_fsm_ops): Remove.
7802         (new_finish_command_fsm): Remove.
7803         (finish_command_fsm::should_stop): Rename from
7804         finish_command_fsm_should_stop.
7805         (finish_command_fsm::clean_up): Rename from
7806         finish_command_fsm_clean_up.
7807         (finish_command_fsm::return_value): Rename from
7808         finish_command_fsm_return_value.
7809         (finish_command_fsm::do_async_reply_reason): Rename from
7810         finish_command_fsm_async_reply_reason.
7811         (finish_command): Update.
7812         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7813         Add constructor.
7814         (call_thread_fsm_ops): Remove.
7815         (call_thread_fsm::call_thread_fsm): Rename from
7816         new_call_thread_fsm.
7817         (call_thread_fsm::should_stop): Rename from
7818         call_thread_fsm_should_stop.
7819         (call_thread_fsm::should_notify_stop): Rename from
7820         call_thread_fsm_should_notify_stop.
7821         (run_inferior_call, call_function_by_hand_dummy): Update.
7822         * cli/cli-interp.c (should_print_stop_to_console): Update.
7823         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7824         Add constructor.  Change type of location_breakpoint,
7825         caller_breakpoint.
7826         (until_break_fsm_ops): Remove.
7827         (new_until_break_fsm): Remove.
7828         (until_break_fsm::should_stop): Rename from
7829         until_break_fsm_should_stop.
7830         (until_break_fsm::clean_up): Rename from
7831         until_break_fsm_clean_up.
7832         (until_break_fsm::do_async_reply_reason): Rename from
7833         until_break_fsm_async_reply_reason.
7834         (until_break_command): Update.
7835         * thread-fsm.c: Remove.
7836         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7837
7838 2019-02-07  Tom Tromey  <tom@tromey.com>
7839
7840         * yy-remap.h: Add include guard.
7841         * xtensa-tdep.h: Add include guard.
7842         * xcoffread.h: Rename include guard.
7843         * varobj-iter.h: Add include guard.
7844         * tui/tui.h: Rename include guard.
7845         * tui/tui-winsource.h: Rename include guard.
7846         * tui/tui-wingeneral.h: Rename include guard.
7847         * tui/tui-windata.h: Rename include guard.
7848         * tui/tui-win.h: Rename include guard.
7849         * tui/tui-stack.h: Rename include guard.
7850         * tui/tui-source.h: Rename include guard.
7851         * tui/tui-regs.h: Rename include guard.
7852         * tui/tui-out.h: Rename include guard.
7853         * tui/tui-layout.h: Rename include guard.
7854         * tui/tui-io.h: Rename include guard.
7855         * tui/tui-hooks.h: Rename include guard.
7856         * tui/tui-file.h: Rename include guard.
7857         * tui/tui-disasm.h: Rename include guard.
7858         * tui/tui-data.h: Rename include guard.
7859         * tui/tui-command.h: Rename include guard.
7860         * tic6x-tdep.h: Add include guard.
7861         * target/waitstatus.h: Rename include guard.
7862         * target/wait.h: Rename include guard.
7863         * target/target.h: Rename include guard.
7864         * target/resume.h: Rename include guard.
7865         * target-float.h: Rename include guard.
7866         * stabsread.h: Add include guard.
7867         * rs6000-tdep.h: Add include guard.
7868         * riscv-fbsd-tdep.h: Add include guard.
7869         * regformats/regdef.h: Rename include guard.
7870         * record.h: Rename include guard.
7871         * python/python.h: Rename include guard.
7872         * python/python-internal.h: Rename include guard.
7873         * python/py-stopevent.h: Rename include guard.
7874         * python/py-ref.h: Rename include guard.
7875         * python/py-record.h: Rename include guard.
7876         * python/py-record-full.h: Rename include guard.
7877         * python/py-record-btrace.h: Rename include guard.
7878         * python/py-instruction.h: Rename include guard.
7879         * python/py-events.h: Rename include guard.
7880         * python/py-event.h: Rename include guard.
7881         * procfs.h: Add include guard.
7882         * proc-utils.h: Add include guard.
7883         * p-lang.h: Add include guard.
7884         * or1k-tdep.h: Rename include guard.
7885         * observable.h: Rename include guard.
7886         * nto-tdep.h: Rename include guard.
7887         * nat/x86-linux.h: Rename include guard.
7888         * nat/x86-linux-dregs.h: Rename include guard.
7889         * nat/x86-gcc-cpuid.h: Add include guard.
7890         * nat/x86-dregs.h: Rename include guard.
7891         * nat/x86-cpuid.h: Rename include guard.
7892         * nat/ppc-linux.h: Rename include guard.
7893         * nat/mips-linux-watch.h: Rename include guard.
7894         * nat/linux-waitpid.h: Rename include guard.
7895         * nat/linux-ptrace.h: Rename include guard.
7896         * nat/linux-procfs.h: Rename include guard.
7897         * nat/linux-osdata.h: Rename include guard.
7898         * nat/linux-nat.h: Rename include guard.
7899         * nat/linux-namespaces.h: Rename include guard.
7900         * nat/linux-btrace.h: Rename include guard.
7901         * nat/glibc_thread_db.h: Rename include guard.
7902         * nat/gdb_thread_db.h: Rename include guard.
7903         * nat/gdb_ptrace.h: Rename include guard.
7904         * nat/fork-inferior.h: Rename include guard.
7905         * nat/amd64-linux-siginfo.h: Rename include guard.
7906         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7907         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7908         * nat/aarch64-linux.h: Rename include guard.
7909         * nat/aarch64-linux-hw-point.h: Rename include guard.
7910         * mn10300-tdep.h: Add include guard.
7911         * mips-linux-tdep.h: Add include guard.
7912         * mi/mi-parse.h: Rename include guard.
7913         * mi/mi-out.h: Rename include guard.
7914         * mi/mi-main.h: Rename include guard.
7915         * mi/mi-interp.h: Rename include guard.
7916         * mi/mi-getopt.h: Rename include guard.
7917         * mi/mi-console.h: Rename include guard.
7918         * mi/mi-common.h: Rename include guard.
7919         * mi/mi-cmds.h: Rename include guard.
7920         * mi/mi-cmd-break.h: Rename include guard.
7921         * m2-lang.h: Add include guard.
7922         * location.h: Rename include guard.
7923         * linux-record.h: Rename include guard.
7924         * linux-nat.h: Add include guard.
7925         * linux-fork.h: Add include guard.
7926         * i386-darwin-tdep.h: Rename include guard.
7927         * hppa-linux-offsets.h: Add include guard.
7928         * guile/guile.h: Rename include guard.
7929         * guile/guile-internal.h: Rename include guard.
7930         * gnu-nat.h: Rename include guard.
7931         * gdb-stabs.h: Rename include guard.
7932         * frv-tdep.h: Add include guard.
7933         * f-lang.h: Add include guard.
7934         * event-loop.h: Add include guard.
7935         * darwin-nat.h: Rename include guard.
7936         * cp-abi.h: Rename include guard.
7937         * config/sparc/nm-sol2.h: Rename include guard.
7938         * config/nm-nto.h: Rename include guard.
7939         * config/nm-linux.h: Add include guard.
7940         * config/i386/nm-i386gnu.h: Rename include guard.
7941         * config/djgpp/nl_types.h: Rename include guard.
7942         * config/djgpp/langinfo.h: Rename include guard.
7943         * compile/gcc-cp-plugin.h: Add include guard.
7944         * compile/gcc-c-plugin.h: Add include guard.
7945         * compile/compile.h: Rename include guard.
7946         * compile/compile-object-run.h: Rename include guard.
7947         * compile/compile-object-load.h: Rename include guard.
7948         * compile/compile-internal.h: Rename include guard.
7949         * compile/compile-cplus.h: Rename include guard.
7950         * compile/compile-c.h: Rename include guard.
7951         * common/xml-utils.h: Rename include guard.
7952         * common/x86-xstate.h: Rename include guard.
7953         * common/version.h: Rename include guard.
7954         * common/vec.h: Rename include guard.
7955         * common/tdesc.h: Rename include guard.
7956         * common/selftest.h: Rename include guard.
7957         * common/scoped_restore.h: Rename include guard.
7958         * common/scoped_mmap.h: Rename include guard.
7959         * common/scoped_fd.h: Rename include guard.
7960         * common/safe-iterator.h: Rename include guard.
7961         * common/run-time-clock.h: Rename include guard.
7962         * common/refcounted-object.h: Rename include guard.
7963         * common/queue.h: Rename include guard.
7964         * common/ptid.h: Rename include guard.
7965         * common/print-utils.h: Rename include guard.
7966         * common/preprocessor.h: Rename include guard.
7967         * common/pathstuff.h: Rename include guard.
7968         * common/observable.h: Rename include guard.
7969         * common/netstuff.h: Rename include guard.
7970         * common/job-control.h: Rename include guard.
7971         * common/host-defs.h: Rename include guard.
7972         * common/gdb_wait.h: Rename include guard.
7973         * common/gdb_vecs.h: Rename include guard.
7974         * common/gdb_unlinker.h: Rename include guard.
7975         * common/gdb_unique_ptr.h: Rename include guard.
7976         * common/gdb_tilde_expand.h: Rename include guard.
7977         * common/gdb_sys_time.h: Rename include guard.
7978         * common/gdb_string_view.h: Rename include guard.
7979         * common/gdb_splay_tree.h: Rename include guard.
7980         * common/gdb_setjmp.h: Rename include guard.
7981         * common/gdb_ref_ptr.h: Rename include guard.
7982         * common/gdb_optional.h: Rename include guard.
7983         * common/gdb_locale.h: Rename include guard.
7984         * common/gdb_assert.h: Rename include guard.
7985         * common/filtered-iterator.h: Rename include guard.
7986         * common/filestuff.h: Rename include guard.
7987         * common/fileio.h: Rename include guard.
7988         * common/environ.h: Rename include guard.
7989         * common/common-utils.h: Rename include guard.
7990         * common/common-types.h: Rename include guard.
7991         * common/common-regcache.h: Rename include guard.
7992         * common/common-inferior.h: Rename include guard.
7993         * common/common-gdbthread.h: Rename include guard.
7994         * common/common-exceptions.h: Rename include guard.
7995         * common/common-defs.h: Rename include guard.
7996         * common/common-debug.h: Rename include guard.
7997         * common/cleanups.h: Rename include guard.
7998         * common/buffer.h: Rename include guard.
7999         * common/btrace-common.h: Rename include guard.
8000         * common/break-common.h: Rename include guard.
8001         * cli/cli-utils.h: Rename include guard.
8002         * cli/cli-style.h: Rename include guard.
8003         * cli/cli-setshow.h: Rename include guard.
8004         * cli/cli-script.h: Rename include guard.
8005         * cli/cli-interp.h: Rename include guard.
8006         * cli/cli-decode.h: Rename include guard.
8007         * cli/cli-cmds.h: Rename include guard.
8008         * charset-list.h: Add include guard.
8009         * buildsym-legacy.h: Rename include guard.
8010         * bfin-tdep.h: Add include guard.
8011         * ax.h: Rename include guard.
8012         * arm-linux-tdep.h: Add include guard.
8013         * arm-fbsd-tdep.h: Add include guard.
8014         * arch/xtensa.h: Rename include guard.
8015         * arch/tic6x.h: Add include guard.
8016         * arch/i386.h: Add include guard.
8017         * arch/arm.h: Rename include guard.
8018         * arch/arm-linux.h: Rename include guard.
8019         * arch/arm-get-next-pcs.h: Rename include guard.
8020         * arch/amd64.h: Add include guard.
8021         * arch/aarch64-insn.h: Rename include guard.
8022         * arch-utils.h: Rename include guard.
8023         * annotate.h: Add include guard.
8024         * amd64-darwin-tdep.h: Rename include guard.
8025         * aarch64-linux-tdep.h: Add include guard.
8026         * aarch64-fbsd-tdep.h: Add include guard.
8027         * aarch32-linux-nat.h: Add include guard.
8028
8029 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8030
8031         * macrotab.c (macro_define_internal): New function that
8032         factorizes macro_define_object_internal and macro_define_function
8033         code.
8034         (macro_define_object_internal): Use macro_define_internal.
8035         (macro_define_function): Likewise.
8036
8037 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8038
8039         * macrocmd.c (extract_identifier): Return
8040         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8041         callers.
8042
8043 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8044
8045         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8046
8047 2019-02-05  Tom Tromey  <tom@tromey.com>
8048
8049         * target.c (target_stack::unpush): Move assertion earlier.
8050
8051 2019-01-30  Tom Tromey  <tom@tromey.com>
8052
8053         PR python/23615:
8054         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8055         (gdbpy_parse_and_eval): Likewise.
8056         * python/python-internal.h (gdbpy_allow_threads): New class.
8057
8058 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8059
8060         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8061         (aarch64_fbsd_fpregmap): Move earlier.
8062         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8063         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8064         instead of individual calls to trad_frame_set_reg_addr.
8065         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8066         earlier.
8067         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8068         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8069         instead of individual calls to trad_frame_set_reg_addr.
8070
8071 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8072
8073         * CONTRIBUTE: Replace contribution list with wiki link.
8074
8075 2019-01-25  Tom Tromey  <tom@tromey.com>
8076
8077         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8078
8079 2019-01-25  Tom Tromey  <tom@tromey.com>
8080
8081         * xtensa-linux-nat.c: Fix common/ includes.
8082         * xml-support.h: Fix common/ includes.
8083         * xml-support.c: Fix common/ includes.
8084         * x86-linux-nat.c: Fix common/ includes.
8085         * windows-nat.c: Fix common/ includes.
8086         * varobj.h: Fix common/ includes.
8087         * varobj.c: Fix common/ includes.
8088         * value.c: Fix common/ includes.
8089         * valops.c: Fix common/ includes.
8090         * utils.c: Fix common/ includes.
8091         * unittests/xml-utils-selftests.c: Fix common/ includes.
8092         * unittests/utils-selftests.c: Fix common/ includes.
8093         * unittests/unpack-selftests.c: Fix common/ includes.
8094         * unittests/tracepoint-selftests.c: Fix common/ includes.
8095         * unittests/style-selftests.c: Fix common/ includes.
8096         * unittests/string_view-selftests.c: Fix common/ includes.
8097         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8098         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8099         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8100         * unittests/rsp-low-selftests.c: Fix common/ includes.
8101         * unittests/parse-connection-spec-selftests.c: Fix common/
8102         includes.
8103         * unittests/optional-selftests.c: Fix common/ includes.
8104         * unittests/offset-type-selftests.c: Fix common/ includes.
8105         * unittests/observable-selftests.c: Fix common/ includes.
8106         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8107         * unittests/memrange-selftests.c: Fix common/ includes.
8108         * unittests/memory-map-selftests.c: Fix common/ includes.
8109         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8110         * unittests/function-view-selftests.c: Fix common/ includes.
8111         * unittests/environ-selftests.c: Fix common/ includes.
8112         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8113         * unittests/common-utils-selftests.c: Fix common/ includes.
8114         * unittests/cli-utils-selftests.c: Fix common/ includes.
8115         * unittests/array-view-selftests.c: Fix common/ includes.
8116         * ui-file.c: Fix common/ includes.
8117         * tui/tui-io.c: Fix common/ includes.
8118         * tracepoint.h: Fix common/ includes.
8119         * tracepoint.c: Fix common/ includes.
8120         * tracefile-tfile.c: Fix common/ includes.
8121         * top.h: Fix common/ includes.
8122         * top.c: Fix common/ includes.
8123         * thread.c: Fix common/ includes.
8124         * target/waitstatus.h: Fix common/ includes.
8125         * target/waitstatus.c: Fix common/ includes.
8126         * target.h: Fix common/ includes.
8127         * target.c: Fix common/ includes.
8128         * target-memory.c: Fix common/ includes.
8129         * target-descriptions.c: Fix common/ includes.
8130         * symtab.h: Fix common/ includes.
8131         * symfile.c: Fix common/ includes.
8132         * stap-probe.c: Fix common/ includes.
8133         * spu-linux-nat.c: Fix common/ includes.
8134         * sparc-nat.c: Fix common/ includes.
8135         * source.c: Fix common/ includes.
8136         * solib.c: Fix common/ includes.
8137         * solib-target.c: Fix common/ includes.
8138         * ser-unix.c: Fix common/ includes.
8139         * ser-tcp.c: Fix common/ includes.
8140         * ser-pipe.c: Fix common/ includes.
8141         * ser-base.c: Fix common/ includes.
8142         * selftest-arch.c: Fix common/ includes.
8143         * s12z-tdep.c: Fix common/ includes.
8144         * rust-exp.y: Fix common/ includes.
8145         * rs6000-aix-tdep.c: Fix common/ includes.
8146         * riscv-tdep.c: Fix common/ includes.
8147         * remote.c: Fix common/ includes.
8148         * remote-notif.h: Fix common/ includes.
8149         * remote-fileio.h: Fix common/ includes.
8150         * remote-fileio.c: Fix common/ includes.
8151         * regcache.h: Fix common/ includes.
8152         * regcache.c: Fix common/ includes.
8153         * record-btrace.c: Fix common/ includes.
8154         * python/python.c: Fix common/ includes.
8155         * python/py-type.c: Fix common/ includes.
8156         * python/py-inferior.c: Fix common/ includes.
8157         * progspace.h: Fix common/ includes.
8158         * producer.c: Fix common/ includes.
8159         * procfs.c: Fix common/ includes.
8160         * proc-api.c: Fix common/ includes.
8161         * printcmd.c: Fix common/ includes.
8162         * ppc-linux-nat.c: Fix common/ includes.
8163         * parser-defs.h: Fix common/ includes.
8164         * osdata.c: Fix common/ includes.
8165         * obsd-nat.c: Fix common/ includes.
8166         * nat/x86-linux.c: Fix common/ includes.
8167         * nat/x86-linux-dregs.c: Fix common/ includes.
8168         * nat/x86-dregs.h: Fix common/ includes.
8169         * nat/x86-dregs.c: Fix common/ includes.
8170         * nat/ppc-linux.c: Fix common/ includes.
8171         * nat/mips-linux-watch.h: Fix common/ includes.
8172         * nat/mips-linux-watch.c: Fix common/ includes.
8173         * nat/linux-waitpid.c: Fix common/ includes.
8174         * nat/linux-ptrace.h: Fix common/ includes.
8175         * nat/linux-ptrace.c: Fix common/ includes.
8176         * nat/linux-procfs.c: Fix common/ includes.
8177         * nat/linux-personality.c: Fix common/ includes.
8178         * nat/linux-osdata.c: Fix common/ includes.
8179         * nat/linux-namespaces.c: Fix common/ includes.
8180         * nat/linux-btrace.h: Fix common/ includes.
8181         * nat/linux-btrace.c: Fix common/ includes.
8182         * nat/fork-inferior.c: Fix common/ includes.
8183         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8184         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8185         * nat/aarch64-linux.c: Fix common/ includes.
8186         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8187         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8188         * namespace.h: Fix common/ includes.
8189         * mips-linux-tdep.c: Fix common/ includes.
8190         * minsyms.c: Fix common/ includes.
8191         * mi/mi-parse.h: Fix common/ includes.
8192         * mi/mi-main.c: Fix common/ includes.
8193         * mi/mi-cmd-env.c: Fix common/ includes.
8194         * memrange.h: Fix common/ includes.
8195         * memattr.c: Fix common/ includes.
8196         * maint.h: Fix common/ includes.
8197         * maint.c: Fix common/ includes.
8198         * main.c: Fix common/ includes.
8199         * machoread.c: Fix common/ includes.
8200         * location.c: Fix common/ includes.
8201         * linux-thread-db.c: Fix common/ includes.
8202         * linux-nat.c: Fix common/ includes.
8203         * linux-fork.c: Fix common/ includes.
8204         * inline-frame.c: Fix common/ includes.
8205         * infrun.c: Fix common/ includes.
8206         * inflow.c: Fix common/ includes.
8207         * inferior.h: Fix common/ includes.
8208         * inferior.c: Fix common/ includes.
8209         * infcmd.c: Fix common/ includes.
8210         * inf-ptrace.c: Fix common/ includes.
8211         * inf-child.c: Fix common/ includes.
8212         * ia64-linux-nat.c: Fix common/ includes.
8213         * i387-tdep.c: Fix common/ includes.
8214         * i386-tdep.c: Fix common/ includes.
8215         * i386-linux-tdep.c: Fix common/ includes.
8216         * i386-linux-nat.c: Fix common/ includes.
8217         * i386-go32-tdep.c: Fix common/ includes.
8218         * i386-fbsd-tdep.c: Fix common/ includes.
8219         * i386-fbsd-nat.c: Fix common/ includes.
8220         * guile/scm-type.c: Fix common/ includes.
8221         * guile/guile.c: Fix common/ includes.
8222         * go32-nat.c: Fix common/ includes.
8223         * gnu-nat.c: Fix common/ includes.
8224         * gdbthread.h: Fix common/ includes.
8225         * gdbarch-selftests.c: Fix common/ includes.
8226         * gdb_usleep.c: Fix common/ includes.
8227         * gdb_select.h: Fix common/ includes.
8228         * gdb_bfd.c: Fix common/ includes.
8229         * gcore.c: Fix common/ includes.
8230         * fork-child.c: Fix common/ includes.
8231         * findvar.c: Fix common/ includes.
8232         * fbsd-nat.c: Fix common/ includes.
8233         * event-top.c: Fix common/ includes.
8234         * event-loop.c: Fix common/ includes.
8235         * dwarf2read.c: Fix common/ includes.
8236         * dwarf2loc.c: Fix common/ includes.
8237         * dwarf2-frame.c: Fix common/ includes.
8238         * dwarf-index-cache.c: Fix common/ includes.
8239         * dtrace-probe.c: Fix common/ includes.
8240         * disasm-selftests.c: Fix common/ includes.
8241         * defs.h: Fix common/ includes.
8242         * csky-tdep.c: Fix common/ includes.
8243         * cp-valprint.c: Fix common/ includes.
8244         * cp-support.h: Fix common/ includes.
8245         * cp-support.c: Fix common/ includes.
8246         * corelow.c: Fix common/ includes.
8247         * completer.h: Fix common/ includes.
8248         * completer.c: Fix common/ includes.
8249         * compile/compile.c: Fix common/ includes.
8250         * compile/compile-loc2c.c: Fix common/ includes.
8251         * compile/compile-cplus-types.c: Fix common/ includes.
8252         * compile/compile-cplus-symbols.c: Fix common/ includes.
8253         * command.h: Fix common/ includes.
8254         * cli/cli-dump.c: Fix common/ includes.
8255         * cli/cli-cmds.c: Fix common/ includes.
8256         * charset.c: Fix common/ includes.
8257         * build-id.c: Fix common/ includes.
8258         * btrace.h: Fix common/ includes.
8259         * btrace.c: Fix common/ includes.
8260         * breakpoint.h: Fix common/ includes.
8261         * breakpoint.c: Fix common/ includes.
8262         * ax.h:
8263         (enum agent_op): Fix common/ includes.
8264         * ax-general.c (struct aop_map): Fix common/ includes.
8265         * ax-gdb.c: Fix common/ includes.
8266         * auxv.c: Fix common/ includes.
8267         * auto-load.c: Fix common/ includes.
8268         * arm-tdep.c: Fix common/ includes.
8269         * arch/riscv.c: Fix common/ includes.
8270         * arch/ppc-linux-common.c: Fix common/ includes.
8271         * arch/i386.c: Fix common/ includes.
8272         * arch/arm.c: Fix common/ includes.
8273         * arch/arm-linux.c: Fix common/ includes.
8274         * arch/arm-get-next-pcs.c: Fix common/ includes.
8275         * arch/amd64.c: Fix common/ includes.
8276         * arch/aarch64.c: Fix common/ includes.
8277         * arch/aarch64-insn.c: Fix common/ includes.
8278         * arch-utils.c: Fix common/ includes.
8279         * amd64-windows-tdep.c: Fix common/ includes.
8280         * amd64-tdep.c: Fix common/ includes.
8281         * amd64-sol2-tdep.c: Fix common/ includes.
8282         * amd64-obsd-tdep.c: Fix common/ includes.
8283         * amd64-nbsd-tdep.c: Fix common/ includes.
8284         * amd64-linux-tdep.c: Fix common/ includes.
8285         * amd64-linux-nat.c: Fix common/ includes.
8286         * amd64-fbsd-tdep.c: Fix common/ includes.
8287         * amd64-fbsd-nat.c: Fix common/ includes.
8288         * amd64-dicos-tdep.c: Fix common/ includes.
8289         * amd64-darwin-tdep.c: Fix common/ includes.
8290         * agent.c: Fix common/ includes.
8291         * ada-lang.h: Fix common/ includes.
8292         * ada-lang.c: Fix common/ includes.
8293         * aarch64-tdep.c: Fix common/ includes.
8294
8295 2019-01-25  Tom Tromey  <tom@tromey.com>
8296
8297         * common/create-version.sh: Use common/version.h.
8298
8299 2019-01-24  Pedro Alves  <palves@redhat.com>
8300
8301         * infrun.c (signal_stop, signal_print, signal_program)
8302         (signal_catch, signal_pass): Now arrays instead of pointers.
8303         (update_signals_program_target, do_target_resume)
8304         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8305         * linux-nat.c (linux_nat_target::pass_signals)
8306         (linux_nat_target::create_inferior, linux_nat_target::attach):
8307         Adjust.
8308         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8309         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8310         * procfs.c (procfs_target::pass_signals): Adjust.
8311         * record-full.c (record_full_target::resume): Adjust.
8312         * remote.c (remote_target::pass_signals)
8313         (remote_target::program_signals): Adjust.
8314         * target-debug.h (target_debug_print_signals): Now takes a
8315         gdb::array_view as parameter.  Adjust.
8316         * target.h (target_ops) <pass_signals, program_signals>: Replace
8317         pointer and length parameters with gdb::array_view.
8318         (target_pass_signals, target_program_signals): Likewise.
8319         * target-delegates.c: Regenerate.
8320
8321 2019-01-24  Pedro Alves  <palves@redhat.com>
8322
8323         * common/forward-scope-exit.h
8324         (forward_scope_exit::forward_scope_exit): Pass arguments to
8325         m_bind_function directly, instead of creating a std::bind and
8326         copying that.
8327
8328 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8329
8330         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8331         for static members.
8332         (pass_in_v_vfp_candidate): Likewise.
8333
8334 2019-01-23  Tom Tromey  <tom@tromey.com>
8335             Pedro Alves  <palves@redhat.com>
8336
8337         * regcache.c (class regcache_invalidator): Remove.
8338         (regcache::raw_write): Use make_scope_exit.
8339
8340 2019-01-23  Tom Tromey  <tom@tromey.com>
8341
8342         * ui-out.h (class ui_out_emit_type): Update comment.
8343
8344 2019-01-23  Tom Tromey  <tom@tromey.com>
8345
8346         * infrun.c (fetch_inferior_event): Update comment.
8347
8348 2019-01-23  Tom Tromey  <tom@tromey.com>
8349             Pedro Alves  <palves@redhat.com>
8350
8351         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8352         parameter.
8353         (fetch_inferior_event): Use SCOPE_EXIT.
8354
8355
8356 2019-01-23  Tom Tromey  <tom@tromey.com>
8357             Pedro Alves  <palves@redhat.com>
8358
8359         * infrun.c (disable_thread_events): Delete.
8360         (stop_all_threads): Use SCOPE_EXIT.
8361
8362 2019-01-23  Tom Tromey  <tom@tromey.com>
8363             Pedro Alves  <palves@redhat.com>
8364
8365         * symfile.c: Include forward-scope-exit.h.
8366         (clear_symtab_users_cleanup): Replace forward declaration with
8367         a FORWARD_SCOPE_EXIT.
8368         (syms_from_objfile_1): Use the forward_scope_exit and
8369         gdb::optional instead of cleanup_function.
8370         (reread_symbols): Use the forward_scope_exit instead of
8371         cleanup_function.
8372         (clear_symtab_users_cleanup): Remove function.
8373
8374 2019-01-23  Tom Tromey  <tom@tromey.com>
8375             Pedro Alves  <palves@redhat.com>
8376
8377         * linux-nat.c: Include scope-exit.h.
8378         (cleanup_target_stop): Remove.
8379         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8380         SCOPE_EXIT.
8381
8382 2019-01-23  Tom Tromey  <tom@tromey.com>
8383             Pedro Alves  <palves@redhat.com>
8384
8385         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8386         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8387
8388 2019-01-23  Tom Tromey  <tom@tromey.com>
8389             Andrew Burgess  <andrew.burgess@embecosm.com>
8390             Pedro Alves  <palves@redhat.com>
8391
8392         * infrun.c (fetch_inferior_event): Use scope_exit.
8393         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8394         * top.c (execute_command): Use scope_exit.
8395         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8396         * utils.c (do_bpstat_clear_actions_cleanup)
8397         (make_bpstat_clear_actions_cleanup): Remove.
8398
8399 2019-01-23  Tom Tromey  <tom@tromey.com>
8400             Pedro Alves  <palves@redhat.com>
8401
8402         * infrun.c: Include "common/scope-exit.h"
8403         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8404         (wait_for_inferior): Use SCOPE_EXIT.
8405         (fetch_inferior_event): Use scope_exit.
8406
8407 2019-01-23  Tom Tromey  <tom@tromey.com>
8408             Pedro Alves  <palves@redhat.com>
8409
8410         * breakpoint.c (create_breakpoint): Remove cleanup.
8411
8412 2019-01-23  Tom Tromey  <tom@tromey.com>
8413             Andrew Burgess  <andrew.burgess@embecosm.com>
8414             Pedro Alves  <palves@redhat.com>
8415
8416 2019-01-23  Pedro Alves  <palves@redhat.com>
8417
8418         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8419
8420 2019-01-23  Pedro Alves  <palves@redhat.com>
8421             Andrew Burgess  <andrew.burgess@embecosm.com>
8422
8423         * gdbthread.h: Include "common/forward-scope-exit.h".
8424         (scoped_finish_thread_state): Redefine custom class in terms of
8425         forward_scope_exit.
8426
8427 2019-01-23  Pedro Alves  <palves@redhat.com>
8428             Andrew Burgess  <andrew.burgess@embecosm.com>
8429
8430         * common/forward-scope-exit.h: New file.
8431
8432 2019-01-23  Pedro Alves  <palves@redhat.com>
8433             Andrew Burgess  <andrew.burgess@embecosm.com>
8434             Tom Tromey  <tom@tromey.com>
8435
8436         * common/scope-exit.h: New file.
8437
8438 2019-01-23  Pedro Alves  <palves@redhat.com>
8439
8440         * common/preprocessor.h (ESC): Rename to ...
8441         (ESC_PARENS): ... this.
8442         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8443         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8444
8445 2019-01-23  Tom Tromey  <tom@tromey.com>
8446
8447         * language.h (class scoped_switch_to_sym_language_if_auto):
8448         Initialize m_lang in both cases.
8449
8450 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8451
8452         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8453         with XCNEW.
8454
8455 2019-01-22  Tom Tromey  <tom@tromey.com>
8456
8457         * corelow.c: Do not include sys/file.h.
8458
8459 2019-01-22  Tom Tromey  <tom@tromey.com>
8460
8461         * tui/tui-wingeneral.h: Include gdb_curses.h.
8462
8463 2019-01-22  Tom Tromey  <tom@tromey.com>
8464
8465         * source-cache.h (class source_cache) <get_source_lines,
8466         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8467
8468 2019-01-22  Tom Tromey  <tom@tromey.com>
8469
8470         * remote-fileio.h (struct remote_target): Declare.
8471
8472 2019-01-22  Tom Tromey  <tom@tromey.com>
8473
8474         * python/py-arch.c: Do not include py-ref.h.
8475         * python/py-bpevent.c: Do not include py-ref.h.
8476         * python/py-cmd.c: Do not include py-ref.h.
8477         * python/py-continueevent.c: Do not include py-ref.h.
8478         * python/py-event.h: Do not include py-ref.h.
8479         * python/py-evtregistry.c: Do not include py-ref.h.
8480         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8481         * python/py-frame.c: Do not include py-ref.h.
8482         * python/py-framefilter.c: Do not include py-ref.h.
8483         * python/py-function.c: Do not include py-ref.h.
8484         * python/py-infevents.c: Do not include py-ref.h.
8485         * python/py-linetable.c: Do not include py-ref.h.
8486         * python/py-objfile.c: Do not include py-ref.h.
8487         * python/py-param.c: Do not include py-ref.h.
8488         * python/py-prettyprint.c: Do not include py-ref.h.
8489         * python/py-progspace.c: Do not include py-ref.h.
8490         * python/py-symbol.c: Do not include py-ref.h.
8491         * python/py-symtab.c: Do not include py-ref.h.
8492         * python/py-type.c: Do not include py-ref.h.
8493         * python/py-unwind.c: Do not include py-ref.h.
8494         * python/py-utils.c: Do not include py-ref.h.
8495         * python/py-value.c: Do not include py-ref.h.
8496         * python/py-varobj.c: Do not include py-ref.h.
8497         * python/py-xmethods.c: Do not include py-ref.h.
8498         * python/python.c: Do not include py-ref.h.
8499         * varobj.c: Do not include py-ref.h.
8500
8501 2019-01-22  Tom Tromey  <tom@tromey.com>
8502
8503         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8504         keyword for bcache.
8505
8506 2019-01-22  Tom Tromey  <tom@tromey.com>
8507
8508         * compile/compile-cplus-types.c: Remove a comment by #include.
8509
8510 2019-01-22  Tom Tromey  <tom@tromey.com>
8511
8512         * compile/gcc-c-plugin.h: Include compile-internal.h.
8513
8514 2019-01-22  Tom Tromey  <tom@tromey.com>
8515
8516         * stabsread.c (EXTERN): Do not define.
8517         (symnum, next_symbol_text_func, processing_gcc_compilation)
8518         (within_function, global_sym_chain, global_stabs)
8519         (previous_stab_code, this_object_header_files)
8520         (n_this_object_header_files)
8521         (n_allocated_this_object_header_files): Define.
8522         * stabsread.h (EXTERN): Never define.  Use "extern".
8523
8524 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8525
8526         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8527         history_value.
8528
8529 2019-01-21  Tom Tromey  <tom@tromey.com>
8530
8531         * ui-out.c: Fix includes.
8532         * tui/tui-source.c: Fix includes.
8533         * target.c: Fix includes.
8534         * remote.c: Fix includes.
8535         * regcache.c: Fix includes.
8536         * python/py-block.c: Fix includes.
8537         * printcmd.c: Fix includes.
8538         * or1k-tdep.c: Fix includes.
8539         * mi/mi-main.c: Fix includes.
8540         * m32r-tdep.c: Fix includes.
8541         * csky-tdep.c: Fix includes.
8542         * compile/compile-cplus-types.c: Fix includes.
8543         * cli/cli-interp.c: Fix includes.
8544
8545 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8546
8547         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8548         for padding.
8549
8550 2019-01-16  Tom Tromey  <tom@tromey.com>
8551
8552         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8553         earlier.
8554         (struct objfile) <msymbols_range>: Move from top level.
8555         <msymbols>: New method.
8556         (class objfile_msymbols): Remove.
8557         * symtab.c (default_collect_symbol_completion_matches_break_on):
8558         Update.
8559         * symmisc.c (dump_msymbols): Update.
8560         * stabsread.c (scan_file_globals): Update.
8561         * objc-lang.c (info_selectors_command, info_classes_command)
8562         (find_methods): Update.
8563         * minsyms.c (find_solib_trampoline_target): Update.
8564         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8565         * coffread.c (coff_symfile_read): Update.
8566         * ada-lang.c (ada_lookup_simple_minsym)
8567         (ada_collect_symbol_completion_matches): Update.
8568
8569 2019-01-16  Tom Tromey  <tom@tromey.com>
8570
8571         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8572         type.  Remove no-argument constructor.
8573         <iterator::operator++>: Simplify.
8574         <begin>: Update.
8575         <end>: Use minimal_symbol_count.
8576
8577 2019-01-16  Tom Tromey  <tom@tromey.com>
8578
8579         * objfiles.h (struct objfile) <psymtabs>: New method.
8580         (class objfile_psymtabs): Remove.
8581         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8582         typedef.
8583         <range>: New method.
8584         (require_partial_symbols): Change return type.
8585         * psymtab.c (require_partial_symbols)
8586         (psym_expand_symtabs_matching): Update.
8587         * mdebugread.c (parse_partial_symbols): Update.
8588         * dbxread.c (dbx_end_psymtab): Update.
8589
8590 2019-01-15  Tom Tromey  <tom@tromey.com>
8591
8592         * symtab.c (lookup_objfile_from_block)
8593         (lookup_symbol_in_objfile_symtabs)
8594         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8595         (find_line_symtab, info_sources_command)
8596         (default_collect_symbol_completion_matches_break_on)
8597         (make_source_files_completion_list): Update.
8598         * symmisc.c (print_objfile_statistics, dump_objfile)
8599         (maintenance_print_symbols, maintenance_info_symtabs)
8600         (maintenance_check_symtabs, maintenance_info_line_tables):
8601         Update.
8602         * source.c (select_source_symtab)
8603         (forget_cached_source_info_for_objfile): Update.
8604         * objfiles.h (class objfile_compunits): Remove.
8605         (struct objfile) <compunits_range>: New typedef.
8606         (compunits): New method.
8607         * objfiles.c (objfile_relocate1): Update.
8608         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8609         * maint.c (count_symtabs_and_blocks): Update.
8610         * linespec.c (iterate_over_all_matching_symtabs): Update.
8611         * cp-support.c (add_symbol_overload_list_qualified): Update.
8612         * coffread.c (coff_symtab_read): Update.
8613         * ada-lang.c (add_nonlocal_symbols)
8614         (ada_collect_symbol_completion_matches)
8615         (ada_add_global_exceptions): Update.
8616
8617 2019-01-15  Tom Tromey  <tom@tromey.com>
8618
8619         * progspace.h (program_space) <objfiles_safe_range>: New
8620         typedef.
8621         <objfiles_safe>: New method.
8622         * objfiles.h (class all_objfiles_safe): Remove.
8623         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8624         * jit.c (jit_inferior_exit_hook): Update.
8625
8626 2019-01-17  Tom Tromey  <tom@tromey.com>
8627
8628         * progspace.h (program_space) <objfiles_range>: New typedef.
8629         <objfiles>: New method.
8630         <objfiles_head>: Rename from objfiles.
8631         (object_files): Update.
8632         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8633         * guile/scm-pretty-print.c
8634         (ppscm_find_pretty_printer_from_objfiles): Update.
8635         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8636         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8637         Update.
8638         * python/py-progspace.c (pspy_get_objfiles): Update.
8639         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8640         Update.
8641         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8642         (objfpy_lookup_objfile_by_build_id): Update.
8643         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8644         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8645         Update.
8646         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8647         (expand_symtab_containing_pc, lookup_objfile_from_block)
8648         (lookup_static_symbol, basic_lookup_transparent_type)
8649         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8650         (find_line_symtab, info_sources_command)
8651         (default_collect_symbol_completion_matches_break_on)
8652         (make_source_files_completion_list, find_main_name): Update.
8653         * symmisc.c (print_symbol_bcache_statistics)
8654         (print_objfile_statistics, maintenance_print_symbols)
8655         (maintenance_print_msymbols, maintenance_print_objfiles)
8656         (maintenance_info_symtabs, maintenance_check_symtabs)
8657         (maintenance_expand_symtabs, maintenance_info_line_tables):
8658         Update.
8659         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8660         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8661         (map_overlay_command, unmap_overlay_command)
8662         (simple_overlay_update, expand_symtabs_matching)
8663         (map_symbol_filenames): Update.
8664         * symfile-debug.c (set_debug_symfile): Update.
8665         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8666         Update.
8667         * source.c (select_source_symtab, forget_cached_source_info):
8668         Update.
8669         * solib.c (solib_read_symbols): Update.
8670         * solib-spu.c (append_ocl_sos): Update.
8671         * psymtab.c (maintenance_print_psymbols)
8672         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8673         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8674         * printcmd.c (info_symbol_command): Update.
8675         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8676         Update.
8677         * objfiles.h (class all_objfiles): Remove.
8678         * objfiles.c (have_partial_symbols, have_full_symbols)
8679         (have_minimal_symbols, qsort_cmp, update_section_map)
8680         (shared_objfile_contains_address_p)
8681         (default_iterate_over_objfiles_in_search_order): Update.
8682         * objc-lang.c (info_selectors_command, info_classes_command)
8683         (find_methods): Update.
8684         * minsyms.c (find_solib_trampoline_target): Update.
8685         * maint.c (maintenance_info_sections)
8686         (maintenance_translate_address, count_symtabs_and_blocks):
8687         Update.
8688         * main.c (captured_main_1): Update.
8689         * linux-thread-db.c (try_thread_db_load_from_pdir)
8690         (has_libpthread): Update.
8691         * linespec.c (iterate_over_all_matching_symtabs)
8692         (search_minsyms_for_name): Update.
8693         * jit.c (jit_find_objf_with_entry_addr): Update.
8694         * hppa-tdep.c (find_unwind_entry)
8695         (hppa_lookup_stub_minimal_symbol): Update.
8696         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8697         Update.
8698         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8699         (elf_gnu_ifunc_resolve_by_got): Update.
8700         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8701         * dwarf-index-write.c (save_gdb_index_command): Update.
8702         * cp-support.c (add_symbol_overload_list_qualified): Update.
8703         * breakpoint.c (create_overlay_event_breakpoint)
8704         (create_longjmp_master_breakpoint)
8705         (create_std_terminate_master_breakpoint)
8706         (create_exception_master_breakpoint): Update.
8707         * blockframe.c (find_pc_partial_function): Update.
8708         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8709         (ada_collect_symbol_completion_matches)
8710         (ada_add_global_exceptions): Update.
8711
8712 2019-01-17  Tom Tromey  <tom@tromey.com>
8713
8714         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8715         declare VEC.
8716         (solib_target_parse_libraries): Change return type.
8717         (library_list_start_segment, library_list_start_section)
8718         (library_list_end_library, library_list_start_library); Update.
8719         (solib_target_free_library_list): Remove.
8720         (solib_target_parse_libraries): Remove cleanup.  Change return
8721         type.
8722         (solib_target_current_sos): Update.
8723
8724 2019-01-17  Tom Tromey  <tromey@bapiya>
8725
8726         * valprint.c: Replace "the the" with "the".
8727         * symtab.c: Replace "the the" with "the".
8728         * solib.c: Replace "the the" with "the".
8729         * solib-dsbt.c: Replace "the the" with "the".
8730         * linespec.c: Replace "the the" with "the".
8731         * dwarf2loc.h: Replace "the the" with "the".
8732         * amd64-windows-tdep.c: Replace "the the" with "the".
8733         * aarch64-tdep.c: Replace "the the" with "the".
8734
8735 2019-01-16  Keith Seitz  <keiths@redhat.com>
8736
8737         PR gdb/23773
8738         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8739         <builder>: Rename to ..
8740         <m_builder>: ... this and make private.
8741         (dwarf2_cu::get_builder): New method.  Change all users of
8742         `builder' to use this method.
8743         (dwarf2_start_symtab): Move to ...
8744         (dwarf2_cu::start_symtab): ... here.  Update all callers
8745         (setup_type_unit_groups): Move to ...
8746         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8747         callers.
8748         (dwarf2_cu::reset_builder): New method.
8749         (process_full_compunit, process_full_type_unit): Use
8750         dwarf2_cu::reset_builder.
8751         (follow_die_offset): Record the ancestor CU if it is different
8752         from the followed DIE's CU.
8753         (follow_die_sig_1): Likewise.
8754
8755 2019-01-15  Tom Tromey  <tom@tromey.com>
8756
8757         * remote.c (class remote_state) <buf>: Now a char_vector.
8758         <buf_size>: Remove.
8759         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8760         parameter.
8761         (remote_target::getpkt_or_notif_sane_1)
8762         (remote_target::getpkt_sane)
8763         (remote_target::getpkt_or_notif_sane): Likewise.
8764         (class remote_target) <putpkt>: New overload.
8765         (remote_target::read_frame): Change type of "buf_p".  Remove
8766         sizeof_p parameter.
8767         (packet_ok): New overload.
8768         (packet_check_result): New overload.
8769         Update all uses.
8770
8771 2019-01-14  Tom Tromey  <tom@tromey.com>
8772
8773         * remote-notif.c (handle_notification, remote_notif_ack)
8774         (remote_notif_parse): Make "buf" const.
8775         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8776         const.
8777         (remote_notif_parse, remote_notif_ack, handle_notification):
8778         Likewise.
8779         * remote.c (remote_notif_stop_parse): Make "buf" const.
8780         (remote_target::remote_parse_stop_reply): Make "buf" const.
8781         (remote_notif_stop_ack): Make "buf" const.
8782
8783 2019-01-14  Tom Tromey  <tom@tromey.com>
8784
8785         * remote.c (remote_console_output): Make parameter const.
8786
8787 2019-01-14  Tom Tromey  <tom@tromey.com>
8788
8789         * target-debug.h (target_debug_print_signals): Constify.
8790         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8791         * procfs.c (procfs_target::pass_signals): Update.
8792         * linux-nat.c (linux_nat_target::pass_signals): Update.
8793         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8794         * target-delegates.c: Rebuild.
8795         * remote.c (remote_target::program_signals): Update.
8796         (remote_target::pass_signals): Update.
8797         * target.c (target_pass_signals): Constify argument.
8798         (target_program_signals): Likewise.
8799         * target.h (struct target_ops) <pass_signals, program_signals>:
8800         Constify argument.
8801         (target_pass_signals, target_program_signals): Constify argument.
8802
8803 2019-01-14  Tom Tromey  <tom@tromey.com>
8804
8805         PR tui/28819:
8806         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8807
8808 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8809
8810         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8811         field.
8812         * rs6000-tdep.c: Include reggroups.h.
8813         (IS_V_ALIAS_PSEUDOREG): Define.
8814         (rs6000_register_name): Return names for the "vX" aliases.
8815         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8816         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8817         aliases.  Call default_register_reggroup_p for all other
8818         pseudo-registers.
8819         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8820         New functions.
8821         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8822         Handle "vX" aliases.
8823         (v_alias_pseudo_register_collect): New function.
8824         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8825         (rs6000_gdbarch_init): Initialize "vX" aliases as
8826         pseudo-registers.  Restore registration of
8827         rs6000_pseudo_register_reggroup_p with
8828         set_tdesc_pseudo_register_reggroup_p.
8829
8830 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8831
8832         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8833         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8834         set_gdbarch_num_pseudo_regs.
8835
8836 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8837
8838         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8839         Remove arg prefixname, add do_set and do_show.
8840         Add member functions set_list and show_list.
8841         * cli/cli-style.c (class cli_style_option): Update accordingly.
8842         (style_set_list): Move to file scope.
8843         (style_show_list): Likewise.
8844         (set_style): Call help_list.
8845         (show_style): Call cmd_show_list.
8846         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8847         Update to use the new macro.
8848
8849 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8850
8851         * ada-lang.c (_initialize_ada_language): Expand the help text
8852         for the "catch exception" command.
8853
8854 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8855
8856         * symtab.c (matching_obj_sections): Initialize obj,
8857         declare it closer to its usage.
8858
8859 2019-01-10  Tom Tromey  <tom@tromey.com>
8860
8861         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8862         (basic_inf_threads_range): Remove.
8863         (inf_threads_range, inf_non_exited_threads_range)
8864         (safe_inf_threads_range): Use next_adapter.
8865
8866 2019-01-10  Keith Seitz  <keiths@redhat.com>
8867
8868         PR gdb/23712
8869         PR symtab/23010
8870         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8871         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8872
8873 2019-01-10  Keith Seitz  <keiths@redhat.com>
8874
8875         PR gdb/23712
8876         PR symtab/23010
8877         * dictionary.c (pending_to_vector): Remove.
8878         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8879         Remove _1 suffix, replacing functions of the same name.  Update
8880         all callers.
8881         (dict_create_hashed, dict_create_hashed_expandable)
8882         (dict_create_linear, dict_create_linear_expandable, dict_free)
8883         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8884         Make functions static.
8885
8886 2019-01-10  Keith Seitz  <keiths@redhat.com>
8887
8888         PR gdb/23712
8889         PR symtab/23010
8890         * dictionary.h (struct dictionary): Replace declaration with
8891         multidictionary.
8892         (dict_create_hashed, dict_create_hashed_expandable)
8893         (dict_create_linear, dict_create_linear_expandable)
8894         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8895         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8896         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8897         taking multidictionary argument.
8898         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8899         * block.h (struct block) <dict>: Change to multidictionary
8900         and rename `multidict'.
8901         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8902         symmisc.c: Update all dictionary references to multidictionary.
8903
8904 2019-01-10  Keith Seitz  <keiths@redhat.com>
8905
8906         PR gdb/23712
8907         PR symtab/23010
8908         * dictionary.c: Include unordered_map.
8909         (pending_to_vector): New function.
8910         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8911         Rewrite the non-"_1" functions to take vector instead
8912         of linked list.
8913         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8914         "new" _1 versions of the same name.
8915         (multidictionary): Define.
8916         (std::hash<enum language): New definition.
8917         (collate_pending_symbols_by_language, mdict_create_hashed)
8918         (mdict_create_hashed_expandable, mdict_create_linear)
8919         (mdict_create_linear_expandable, mdict_free)
8920         (find_language_dictionary, create_new_language_dictionary)
8921         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8922         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8923         (mdict_size, mdict_empty): New functions.
8924         * dictionary.h (mdict_iterator): Define.
8925
8926 2019-01-10  Pedro Alves  <palves@redhat.com>
8927
8928         * breakpoint.c (read_uploaded_action)
8929         (create_tracepoint_from_upload): Adjust to use
8930         gdb::unique_xmalloc_ptr.
8931         * ctf.c (ctf_write_uploaded_tp):
8932         (SET_ARRAY_FIELD): Use emplace_back.
8933         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8934         * tracefile-tfile.c (tfile_write_uploaded_tp):
8935         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8936         gdb::unique_xmalloc_ptr.
8937         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8938         at_string, cond_string, cmd_strings>: Replace char pointers
8939         with gdb::unique_xmalloc_ptr.
8940
8941 2019-01-10  Pedro Alves  <palves@redhat.com>
8942
8943         * solib-target.c (library_list_start_library): Don't xstrdup name.
8944
8945 2019-01-10  Pedro Alves  <palves@redhat.com>
8946
8947         * mdebugread.c (parse_partial_symbols): Use
8948         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8949
8950 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8951
8952         * linux-fork.c (scoped_switch_fork_info)
8953         <~scoped_switch_fork_info>: Fix incorrect variable name.
8954
8955 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8956
8957         * linux-fork.c (scoped_switch_fork_info)
8958         <scoped_switch_fork_info>: Make explicit.
8959         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8960
8961 2019-01-10  Tom Tromey  <tom@tromey.com>
8962
8963         * objfiles.h (objfile::reset_psymtabs): Update.
8964         * objfiles.c (objfile::objfile): Update.
8965         * psymtab.h (psymtab_storage::obstack): Update.
8966         (psymtab_storage::m_obstack): Use gdb::optional.
8967         (class psymtab_storage): Update comment.  Remove objfile
8968         parameter.
8969         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8970
8971 2019-01-10  Tom Tromey  <tom@tromey.com>
8972
8973         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8974         <free_psymtabs>: Now private.
8975         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8976         (allocate_psymtab): Use new method.
8977
8978 2019-01-10  Tom Tromey  <tom@tromey.com>
8979
8980         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8981         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8982         * mdebugread.c (parse_partial_symbols): Use
8983         allocate_dependencies.
8984         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8985         allocate_dependencies.
8986         (process_psymtab_comp_unit_reader)
8987         (build_type_psymtab_dependencies): Likewise.
8988         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8989
8990 2019-01-10  Tom Tromey  <tom@tromey.com>
8991
8992         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8993         PSYMBOL_SET_LANGUAGE.
8994         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8995
8996 2019-01-10  Tom Tromey  <tom@tromey.com>
8997
8998         * psymtab.h (psymtab_storage::obstack): New method.
8999         <m_obstack>: Rename from obstack; now private.
9000         * psymtab.c (psymtab_storage): Update.
9001         * dwarf2read.c (create_addrmap_from_index)
9002         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9003         Update.
9004
9005 2019-01-10  Tom Tromey  <tom@tromey.com>
9006
9007         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9008         * objfiles.h (objfile::reset_psymtabs): New method.
9009
9010 2019-01-10  Tom Tromey  <tom@tromey.com>
9011
9012         * symmisc.c (print_symbol_bcache_statistics): Update.
9013         (print_objfile_statistics): Update.
9014         * symfile.c (reread_symbols): Update.
9015         * psymtab.h (class psymtab_storage): New.
9016         * psymtab.c (psymtab_storage): New constructor.
9017         (~psymtab_storage): New destructor.
9018         (require_partial_symbols): Update.
9019         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9020         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9021         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9022         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9023         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9024         (start_psymtab_common, end_psymtab_common)
9025         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9026         (allocate_psymtab): Update.
9027         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9028         Update.
9029         (dump_psymtab_addrmap, maintenance_print_psymbols)
9030         (maintenance_check_psymtabs): Update.
9031         (class objfile_psymtabs): Move to objfiles.h.
9032         * psympriv.h (discard_psymtab): Now inline.
9033         (psymtab_discarder::psymtab_discarder): Update.
9034         (psymtab_discarder::~psymtab_discarder): Update.
9035         (ALL_OBJFILE_PSYMTABS): Rewrite.
9036         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9037         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9038         Remove fields.
9039         <partial_symtabs>: New field.
9040         (class objfile_psymtabs): Move from psymtab.h.  Update.
9041         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9042         psymbol_cache.
9043         (objfile::~objfile): Don't destroy psymbol_cache.
9044         * mdebugread.c (parse_partial_symbols): Update.
9045         * dwarf2read.c (create_addrmap_from_index)
9046         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9047         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9048         (add_partial_subprogram, dwarf2_ranges_read): Update.
9049         * dwarf-index-write.c (write_address_map)
9050         (write_one_signatured_type, recursively_write_psymbols)
9051         (class debug_names, class debug_names, write_psymtabs_to_index):
9052         Update.
9053
9054 2019-01-10  Tom Tromey  <tom@tromey.com>
9055
9056         * symtab.h (SYMBOL_SET_NAMES): Update.
9057         (symbol_set_names): Update.
9058         (MSYMBOL_SET_NAMES): Update.
9059         * symtab.c (symbol_set_names): Change argument to be an
9060         objfile_per_bfd_storage.
9061         * psymtab.c (add_psymbol_to_bcache): Update.
9062         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9063
9064 2019-01-10  Tom Tromey  <tom@tromey.com>
9065
9066         * symtab.c (create_demangled_names_hash): Change argument to be an
9067         objfile_per_bfd_storage.
9068         (symbol_set_names): Update.
9069
9070 2019-01-10  Tom Tromey  <tom@tromey.com>
9071
9072         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9073         init_psymbol_list.
9074         * psymtab.c (init_psymbol_list): Do nothing if already called.
9075         * psympriv.h (init_psymbol_list): Add comment.
9076         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9077         init_psymbol_list.
9078         * dbxread.c (dbx_symfile_read): Unconditionally call
9079         init_psymbol_list.
9080
9081 2019-01-10  Tom Tromey  <tom@tromey.com>
9082
9083         * xcoffread.c (scan_xcoff_symtab): Update.
9084         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9085         "where".
9086         * mdebugread.c (parse_partial_symbols)
9087         (handle_psymbol_enumerators): Update.
9088         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9089         * dbxread.c (read_dbx_symtab): Update.
9090         * psympriv.h (psymbol_placement): New enum.
9091         (add_psymbol_to_list): Update.
9092
9093 2019-01-10  Tom Tromey  <tom@tromey.com>
9094
9095         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9096         static_psymbols parameters.
9097         (scan_xcoff_symtab): Update.
9098         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9099         static_psymbols parameters.
9100         * psympriv.h (start_psymtab_common): Update.
9101         * mdebugread.c (parse_partial_symbols): Update.
9102         * dwarf2read.c (create_partial_symtab): Update.
9103         * dbxread.c (read_dbx_symtab): Update.
9104         (start_psymtab): Remove global_psymbols and static_psymbols
9105         parameters.
9106
9107 2019-01-10  Tom Tromey  <tom@tromey.com>
9108
9109         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9110         * psymtab.c (allocate_psymtab): Add comment.
9111         * psympriv.h (allocate_psymtab): Add comment.
9112         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9113         initializations.
9114         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9115
9116 2019-01-10  Tom Tromey  <tom@tromey.com>
9117
9118         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9119         Don't declare.
9120         * mipsread.c: Include mdebugread.h.
9121         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9122         Declare.
9123         * elfread.c: Include mdebugread.h.
9124
9125 2019-01-09  Tom Tromey  <tom@tromey.com>
9126
9127         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9128         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9129         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9130         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9131         (psym_lookup_symbol, psym_find_last_source_symtab)
9132         (psym_forget_cached_source_info, psym_print_stats)
9133         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9134         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9135         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9136         (psym_find_compunit_symtab_by_address)
9137         (maintenance_print_psymbols, maintenance_info_psymtabs)
9138         (maintenance_check_psymtabs): Use ranged for.
9139         * psymtab.h (class objfile_psymtabs): New.
9140         (require_partial_symbols): Return objfile_psymtabs.
9141         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9142
9143 2019-01-09  Tom Tromey  <tom@tromey.com>
9144
9145         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9146         (find_pc_mapped_section, list_overlays_command)
9147         (map_overlay_command, unmap_overlay_command)
9148         (simple_overlay_update): Use all_objfiles.
9149         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9150         * printcmd.c (info_symbol_command): Use all_objfiles.
9151         * objfiles.h (ALL_OBJSECTIONS): Remove.
9152         * maint.c (maintenance_translate_address): Use all_objfiles.
9153         * gcore.c (gcore_create_callback): Use all_objfiles.
9154         (objfile_find_memory_regions): Likewise.
9155
9156 2019-01-09  Tom Tromey  <tom@tromey.com>
9157
9158         * symtab.c (find_line_symtab, info_sources_command)
9159         (make_source_files_completion_list): Use objfile_compunits.
9160         * source.c (select_source_symtab): Use objfile_compunits.
9161         * objfiles.h (struct objfile): Update comment.
9162         (ALL_OBJFILES): Remove.
9163         (ALL_FILETABS): Remove.
9164         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9165         objfile_compunits.
9166
9167 2019-01-09  Tom Tromey  <tom@tromey.com>
9168
9169         * symmisc.c (print_objfile_statistics, dump_objfile)
9170         (maintenance_print_symbols): Use compunit_filetabs.
9171         * source.c (forget_cached_source_info_for_objfile): Use
9172         compunit_filetabs.
9173         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9174         (ALL_FILETABS): Use compunit_filetabs.
9175         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9176         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9177
9178 2019-01-09  Tom Tromey  <tom@tromey.com>
9179
9180         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9181         (compunit_filetabs): New.
9182         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9183         compunit_filetabs.
9184         (info_sources_command, make_source_files_completion_list): Remove
9185         declaration.
9186         * symmisc.c (print_objfile_statistics, dump_objfile)
9187         (maintenance_print_symbols): Remove declaration.
9188         (maintenance_info_symtabs): Use compunit_filetabs.
9189         (maintenance_info_line_tables): Likewise.
9190         * source.c (select_source_symtab): Change local variable name.
9191         (forget_cached_source_info_for_objfile): Remove declaration.
9192         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9193         * objfiles.c (objfile_relocate1): Remove declaration.
9194         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9195         declaration.
9196         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9197         * coffread.c (coff_symtab_read): Remove declaration.
9198         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9199         compunit_filetabs.
9200
9201 2019-01-09  Tom Tromey  <tom@tromey.com>
9202
9203         * symtab.c (lookup_objfile_from_block)
9204         (find_pc_sect_compunit_symtab, search_symbols)
9205         (default_collect_symbol_completion_matches_break_on): Use
9206         objfile_compunits.
9207         * objfiles.h (ALL_COMPUNITS): Remove.
9208         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9209         * cp-support.c (add_symbol_overload_list_qualified): Use
9210         objfile_compunits.
9211         * ada-lang.c (ada_collect_symbol_completion_matches)
9212         (ada_add_global_exceptions): Use objfile_compunits.
9213
9214 2019-01-09  Tom Tromey  <tom@tromey.com>
9215
9216         * source.c (select_source_symtab)
9217         (forget_cached_source_info_for_objfile): Remove declaration.
9218         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9219         declaration.
9220         * maint.c (count_symtabs_and_blocks): Remove declaration.
9221         * cp-support.c (add_symbol_overload_list_qualified): Remove
9222         declaration.
9223         * coffread.c (coff_symtab_read): Remove declaration.
9224         * symtab.c (lookup_symbol_in_objfile_symtabs)
9225         (basic_lookup_transparent_type_1): Use objfile_compunits.
9226         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9227         (info_sources_command, search_symbols)
9228         (default_collect_symbol_completion_matches_break_on)
9229         (make_source_files_completion_list): Remove declaration.
9230         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9231         (ada_collect_symbol_completion_matches)
9232         (ada_add_global_exceptions): Remove declaration.
9233         * linespec.c (iterate_over_all_matching_symtabs): Use
9234         objfile_compunits.
9235         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9236         (class objfile_compunits): New.
9237         (ALL_COMPUNITS): Use objfile_compunits.
9238         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9239         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9240         objfile_compunits.
9241         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9242
9243 2019-01-09  Tom Tromey  <tom@tromey.com>
9244
9245         * symtab.c (search_symbols)
9246         (default_collect_symbol_completion_matches_break_on): Use
9247         objfile_msymbols.
9248         * ada-lang.c (ada_lookup_simple_minsym)
9249         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9250         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9251         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9252         objfile_msymbols.
9253         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9254         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9255         * objc-lang.c (find_methods): Use objfile_msymbols.
9256         (info_selectors_command, info_classes_command): Likewise.
9257         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9258         * objfiles.h (class objfile_msymbols): New.
9259         (ALL_OBJFILE_MSYMBOLS): Remove.
9260         (ALL_MSYMBOLS): Remove.
9261
9262 2019-01-09  Tom Tromey  <tom@tromey.com>
9263
9264         * common/next-iterator.h (next_adapter): Add Iterator template
9265         parameter.
9266         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9267         (class all_objfiles_safe): New.
9268         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9269         * objfiles.c (put_objfile_before): Update comment.
9270         (add_separate_debug_objfile): Likewise.
9271         (free_all_objfiles): Use all_objfiles_safe.
9272         (objfile_purge_solibs): Likewise.
9273
9274 2019-01-09  Tom Tromey  <tom@tromey.com>
9275
9276         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9277         (expand_symtab_containing_pc, lookup_static_symbol)
9278         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9279         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9280         all_objfiles.
9281         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9282         * breakpoint.c (create_overlay_event_breakpoint)
9283         (create_longjmp_master_breakpoint)
9284         (create_std_terminate_master_breakpoint)
9285         (create_exception_master_breakpoint): Use all_objfiles.
9286         * linux-thread-db.c (try_thread_db_load_from_pdir)
9287         (has_libpthread): Use all_objfiles.
9288         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9289         * linespec.c (iterate_over_all_matching_symtabs)
9290         (search_minsyms_for_name): Use all_objfiles.
9291         * maint.c (maintenance_info_sections): Use all_objfiles.
9292         * main.c (captured_main_1): Use all_objfiles.
9293         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9294         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9295         * guile/scm-pretty-print.c
9296         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9297         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9298         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9299         (maintenance_print_msymbols): Use all_objfiles.
9300         * source.c (select_source_symtab): Use all_objfiles.
9301         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9302         * symfile.c (remove_symbol_file_command)
9303         (expand_symtabs_matching, map_symbol_filenames): Use
9304         all_objfiles.
9305         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9306         all_objfiles.
9307         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9308         * objc-lang.c (find_methods): Use all_objfiles.
9309         * objfiles.c (have_partial_symbols, have_full_symbols)
9310         (have_minimal_symbols, qsort_cmp)
9311         (default_iterate_over_objfiles_in_search_order): Use
9312         all_objfiles.
9313         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9314         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9315         (maintenance_check_psymtabs): Use all_objfiles.
9316         (ALL_PSYMTABS): Remove.
9317         * compile/compile-object-run.c (do_module_cleanup): Use
9318         all_objfiles.
9319         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9320         * cp-support.c (add_symbol_overload_list_qualified): Use
9321         all_objfiles.
9322         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9323         Use all_objfiles.
9324         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9325         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9326         all_objfiles.
9327         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9328         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9329         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9330         Uses all_objfiles.
9331         * solib.c (solib_read_symbols): Use all_objfiles
9332
9333 2019-01-09  Tom Tromey  <tom@tromey.com>
9334
9335         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9336         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9337         all_objfiles.
9338         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9339         * symmisc.c (print_symbol_bcache_statistics)
9340         (print_objfile_statistics, maintenance_print_objfiles)
9341         (maintenance_info_symtabs, maintenance_check_symtabs)
9342         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9343         all_objfiles.
9344         * source.c (forget_cached_source_info): Use all_objfiles.
9345         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9346         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9347         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9348         * objfiles.c (update_section_map): Use all_objfiles.
9349         (shared_objfile_contains_address_p): Likewise.
9350         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9351         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9352
9353 2019-01-09  Tom Tromey  <tom@tromey.com>
9354
9355         * common/next-iterator.h: New file.
9356         * objfiles.h (class all_objfiles): New.
9357         (struct objfile_iterator): New.
9358
9359 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9360
9361         * NEWS: Move the description of the changed "frame", "select-frame",
9362          and "info frame" commands to the Changed commands section.
9363
9364 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9365
9366         * gdbtypes.c (check_stub_method_group): Remove handling of old
9367         mangling schemes.
9368         * linespec.c (find_methods): Likewise.
9369         * stabsread.c (read_member_functions): Likewise.
9370         * valops.c (search_struct_method): Likewise.
9371         (value_struct_elt_for_reference): Likewise.
9372         * NEWS: Mention this change.
9373
9374 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9375
9376         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9377         print_source_lines.
9378         * source.c (print_source_lines_base): Update line number check.
9379         (print_source_lines): New function.
9380         (source_lines_range::source_lines_range): New function.
9381         * source.h (class source_lines_range): New class.
9382         (print_source_lines): New declaration.
9383
9384 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9385
9386         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9387
9388 2019-01-08  Tom Tromey  <tom@tromey.com>
9389             Simon Marchi  <simon.marchi@ericsson.com>
9390
9391         PR gdb/24060
9392         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9393         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9394         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9395         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9396         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9397         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9398
9399 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9400
9401         * source.c (select_source_symtab): Move header comment to
9402         declaration in source.h.
9403         (forget_cached_source_info_for_objfile): Likewise.
9404         (forget_cached_source_info): Likewise.
9405         (identify_source_line): Likewise.
9406         * source.h (identify_source_line): Move declaration from symtab.h
9407         and add comment from source.c
9408         (print_source_lines): Likewise.
9409         (forget_cached_source_info_for_objfile): Likewise.
9410         (forget_cached_source_info): Likewise.
9411         (select_source_symtab): Likewise.
9412         (enum print_source_lines_flag): Move definition from symtab.h.
9413         * symtab.h (identify_source_line): Move declaration to source.h.
9414         (print_source_lines): Likewise.
9415         (forget_cached_source_info_for_objfile): Likewise.
9416         (forget_cached_source_info): Likewise.
9417         (select_source_symtab): Likewise.
9418         (enum print_source_lines_flag): Move definition to source.h.
9419         * tui/tui-hooks.c: Add 'source.h' include.
9420
9421 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9422
9423         * source.c (print_source_lines_base): Handle requests to print
9424         reverse line number sequences, and guard against empty lines
9425         string.
9426
9427 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9428
9429         * source.c (print_source_lines_base): Fix skip of '\r' if next
9430         character is '\n'.
9431
9432 2019-01-06  Tom Tromey  <tom@tromey.com>
9433
9434         * c-exp.y (struct c_parse_state) <macro_original_text,
9435         expansion_obstack>: New member.
9436         (macro_original_text, expansion_obstack): Remove globals.
9437         (scan_macro_expansion, scanning_macro_expansion)
9438         (finished_macro_expansion): Update.
9439         (scan_macro_cleanup): Remove.
9440         (yylex, c_parse): Update.
9441
9442 2019-01-06  Tom Tromey  <tom@tromey.com>
9443
9444         * c-exp.y (struct c_parse_state) <strings>: New member.
9445         (operator_stoken): Update.
9446
9447 2019-01-06  Tom Tromey  <tom@tromey.com>
9448
9449         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9450         (union type_stack_elt) <typelist_val>: Now a pointer to
9451         std::vector.
9452         (type_stack_cleanup): Don't declare.
9453         (push_typelist): Update.
9454         * parse.c (pop_typelist): Return a std::vector.
9455         (push_typelist): Take a std::vector.
9456         (follow_types): Update.  Do not free args.
9457         (type_stack_cleanup): Remove.
9458         * c-exp.y (struct c_parse_state): New.
9459         (cpstate): New global.
9460         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9461         (nonempty_typelist): Update.
9462         (func_mod): Create a new vector.
9463         (c_parse): Create a c_parse_state.
9464         (check_parameter_typelist): Do not delete params.
9465         (function_method): Update.  Do not delete type_list.
9466
9467 2019-01-06  Tom Tromey  <tom@tromey.com>
9468
9469         PR gdb/28155:
9470         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9471         check_typedef.
9472         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9473         (print_return_value): Likewise.
9474
9475 2019-01-05  Tom Tromey  <tom@tromey.com>
9476
9477         * contrib/cleanup_check.py: Remove.
9478         * contrib/gcc-with-excheck: Remove.
9479         * contrib/exsummary.py: Remove.
9480         * contrib/excheck.py: Remove.
9481
9482 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9483
9484         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9485         NULL. Initialize tpprev to NULL instead of assigning it
9486         to NULL on the next statement.
9487         * windows-nat.c (windows_delete_thread): Remove check for
9488         main_thread_id before printing thread exit notifications.
9489         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9490         Remove thread ID check against main_thread_id.
9491         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9492         windows_delete_thread.
9493         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9494
9495 2019-01-04  Tom Tromey  <tom@tromey.com>
9496
9497         * compile/compile.c (_initialize_compile): Use upper case for
9498         metasyntactic variables.
9499         * symmisc.c (_initialize_symmisc): Use upper case for
9500         metasyntactic variables.
9501         * psymtab.c (_initialize_psymtab): Use upper case for
9502         metasyntactic variables.
9503         * demangle.c (demangle_command): Use upper case for metasyntactic
9504         variables.
9505         (_initialize_demangler): Likewise.
9506         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9507         variables.
9508
9509 2019-01-03  Tom Tromey  <tom@tromey.com>
9510
9511         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9512
9513 2019-01-03  Tom Tromey  <tom@tromey.com>
9514
9515         * python/py-symtab.c (salpy_str): Update.
9516         (struct salpy_sal_object) <symtab>: Now a PyObject.
9517         (salpy_dealloc): Update.
9518         (del_objfile_sal): Use gdbpy_ref.
9519
9520 2019-01-03  Tom Tromey  <tom@tromey.com>
9521
9522         * python/py-type.c (convert_field): Use new_reference.  Return
9523         gdbpy_ref.
9524         (make_fielditem): Return gdbpy_ref.
9525         (typy_fields): Update.
9526         (typy_getitem): Update.
9527         (field_name): Return gdbpy_ref.  Use new_reference.
9528         (typy_iterator_iternext): Update.
9529
9530 2019-01-03  Tom Tromey  <tom@tromey.com>
9531
9532         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9533
9534 2019-01-03  Tom Tromey  <tom@tromey.com>
9535
9536         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9537         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9538         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9539         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9540         (pspy_set_type_printers): Likewise.
9541         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9542         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9543         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9544         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9545         (objfpy_set_type_printers): Likewise.
9546
9547 2019-01-03  Tom Tromey  <tom@tromey.com>
9548
9549         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9550         (gdbpy_print_stack): Use gdbpy_err_fetch.
9551         * python/python-internal.h (class gdbpy_err_fetch): New class.
9552         (class gdbpy_enter) <m_error_type, m_error_value,
9553         m_error_traceback>: Remove.
9554         <m_error>: New member.
9555         (gdbpy_exception_to_string): Don't declare.
9556         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9557         * python/py-value.c (convert_value_from_python): Use
9558         gdbpy_err_fetch.
9559         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9560         gdbpy_exception_to_string.
9561         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9562         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9563         gdbpy_err_fetch.
9564
9565 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9566
9567         * linux-nat.c (delete_lwp_cleanup): Delete.
9568         (struct lwp_deleter): New struct.
9569         (lwp_info_up): New typedef.
9570         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9571         lwp_info_up.
9572
9573 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9574
9575         * linux-fork.c (class scoped_switch_fork_info): New class.
9576         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9577
9578 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9579
9580         * valops.c (find_overload_match): Remove use of null_cleanup, and
9581         calls to do_cleanups.
9582
9583 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9584
9585         * compile/compile-cplus-types.c
9586         (compile_cplus_instance::decl_name): Handle changes to
9587         cp_func_name.
9588         * cp-support.c (cp_func_name): Update header comment, update
9589         return type.
9590         * cp-support.h (cp_func_name): Update return type in declaration.
9591         * valops.c (find_overload_match): Move temp_func local to top
9592         level of function and change its type.  Use temp_func to hold and
9593         delete temporary string obtained from cp_func_name.
9594
9595 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9596
9597         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9598         gdb::char_vector, remove cleanup, and update uses of `msg`.
9599
9600 2019-01-03  Jim Wilson  <jimw@sifive.com>
9601
9602         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9603
9604 2019-01-02  Tom Tromey  <tom@tromey.com>
9605
9606         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9607         (tdesc_parse_xml): Remove cleanups.
9608         * target-descriptions.h (make_cleanup_free_target_description):
9609         Don't declare.
9610         (target_desc_deleter): New struct.
9611         (target_desc_up): New typedef.
9612         * target-descriptions.c (target_desc_deleter::operator()): Rename
9613         from free_target_description.
9614         (make_cleanup_free_target_description): Remove.
9615
9616 2019-01-02  Tom Tromey  <tom@tromey.com>
9617
9618         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9619         constructor, destructor.
9620         (linespec_parser): Remove typedef.
9621         (~linespec_parser): Rename from linespec_parser_delete.
9622         (linespec_lex_to_end, linespec_complete_label)
9623         (linespec_complete): Update.
9624         (decode_line_full): Remove cleanups.
9625         (decode_line_1): Update.
9626
9627 2019-01-02  Tom Tromey  <tom@tromey.com>
9628
9629         * python/python-internal.h (inferior_to_inferior_object): Change
9630         return type.
9631         * python/py-exitedevent.c (create_exited_event_object): Update.
9632         * python/py-inferior.c (inferior_to_inferior_object): Return
9633         gdbpy_ref.
9634         (python_new_inferior, python_inferior_deleted)
9635         (thread_to_thread_object, delete_thread_object)
9636         (build_inferior_list, gdbpy_selected_inferior): Update.
9637         * python/py-infthread.c (create_thread_object): Update.  Also fail
9638         if inferior_to_inferior_object fails.
9639
9640 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9641
9642         * inferior.h (class inferior) <displaced_step_state>: New field.
9643         * infrun.h (struct displaced_step_state): Move here from
9644         infrun.c.  Initialize fields, add constructor.
9645         <inf>: Remove field.
9646         <reset>: New method.
9647         * infrun.c (struct displaced_step_inferior_state): Move to
9648         infrun.h.
9649         (displaced_step_inferior_states): Remove.
9650         (get_displaced_stepping_state): Adust.
9651         (displaced_step_in_progress_any_inferior): Adjust.
9652         (displaced_step_in_progress_thread): Adjust.
9653         (displaced_step_in_progress): Adjust.
9654         (add_displaced_stepping_state): Remove.
9655         (get_displaced_step_closure_by_addr): Adjust.
9656         (remove_displaced_stepping_state): Remove.
9657         (infrun_inferior_exit): Call displaced_step_state.reset.
9658         (use_displaced_stepping): Don't check for NULL.
9659         (displaced_step_prepare_throw): Call
9660         get_displaced_stepping_state.
9661         (displaced_step_fixup): Don't check for NULL.
9662         (prepare_for_detach): Don't check for NULL.
9663
9664 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9665
9666         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9667          in case of call that did not complete.
9668
9669 2019-01-02  Andrey Utkin  <autkin@undo.io>
9670
9671         * symfile.c (find_separate_debug_file): Fix search of debug files for
9672         remote debuggee.
9673
9674 2019-01-02  Tom Tromey  <tom@tromey.com>
9675
9676         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9677         indentation.
9678         * python/py-frame.c (frapy_older): Remove cast.
9679         (frapy_newer): Likewise.
9680         * python/py-breakpoint.c (local_setattro): Remove cast.
9681         * python/py-arch.c (archpy_name): Remove local variable.
9682         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9683
9684 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9685
9686         * unittests/basic_string_view/element_access/char/empty.cc:
9687         Fix year range in copyright header.
9688
9689 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9690
9691         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9692         Delete.
9693         <operator==>: Update with for removed field.
9694         <hash>: Likewise.
9695         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9696         <isa_features>: ...this.
9697         <abi_features>: New field.
9698         (riscv_isa_flen): Update comment.
9699         (riscv_abi_xlen): New declaration.
9700         (riscv_abi_flen): New declaration.
9701         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9702         isa_features.
9703         (riscv_abi_xlen): New function.
9704         (riscv_isa_flen): Update to get answer from isa_features.
9705         (riscv_abi_flen): New function.
9706         (riscv_has_fp_abi): Update to get answer from abi_features.
9707         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9708         xlen and flen.
9709         (riscv_call_info) <xlen, flen>: Update comment.
9710         (riscv_call_arg_struct): Remove invalid assertions
9711         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9712         is removed.
9713         (riscv_gdbarch_init): Gather isa features and abi features
9714         separately, ensure both match on the gdbarch when reusing an old
9715         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9716         a target with 64-bit float hardware.
9717
9718 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9719
9720         * source.c (search_command_helper): Stop reverse search
9721         when line 1 has been searched.
9722
9723 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9724
9725         * record-full.c (record_full_base_target::close): Rewrite
9726         record_full_core_buf_list free logic.
9727
9728 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9729
9730         * break-catch-syscall.c (print_one_catch_syscall): xfree
9731         the last text.
9732
9733 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9734
9735         * top.c (print_gdb_version): Update Copyright year in version
9736         message.
9737
9738 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9739
9740         Update copyright year range in all GDB files.
9741
9742 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9743
9744         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9745
9746 For older changes see ChangeLog-2018.
9747 \f
9748 Local Variables:
9749 mode: change-log
9750 left-margin: 8
9751 fill-column: 74
9752 version-control: never
9753 coding: utf-8
9754 End:
9755