gdb/ChangeLog

   1 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * cli/cli-cmds.c (setting_cmd, value_from_setting)
   4         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
   5         (str_value_from_setting, gdb_setting_str_internal_fn)
   6         (gdb_maint_setting_str_internal_fn): New functions.
   7         (_initialize_cli_cmds): Define the new convenience functions.
   8         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
   9         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
  10
  11 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  12
  13         * agent.c (set_can_use_agent): When the setting is turned on,
  14         look up agent symbols if we don't have them yet.
  15         (agent_new_objfile): Don't look up agent symbols when the agent
  16         setting is off.
  17
  18 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  19
  20         * config.in: Regenerate.
  21
  22 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  23
  24         * configure: Regenerate.
  25         * configure.ac: Check for strerror_r.
  26         * gdbsupport/common-utils.h (safe_strerror): Change return value
  27         to const char * and document that this function is now threadsafe.
  28         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
  29         thread_local and call strerror_r, if available.
  30         * utils.c (perror_string): Update.
  31         (print_sys_errmsg): Update.
  32
  33 2019-10-31  Luis Machado  <luis.machado@linaro.org>
  34
  35         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
  36         objfile_key.
  37         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
  38         objfile to fetch per-bfd data.
  39         (arm_find_exidx_entry): Likewise.
  40
  41 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  42
  43         * gdbsupport/agent.c (debug_agent): Change type to bool.
  44         (use_agent): Likewise.
  45         (all_agent_symbols_look_up): Likewise.
  46         (agent_loaded_p): Change return value to bool.
  47         (agent_look_up_symbols): Update.
  48         (agent_capability_check): Change return value to bool.
  49         * gdbsupport/agent.h (agent_loaded_p): Likewise.
  50         (debug_agent): Change type to bool.
  51         (use_agent): Likewise.
  52         (agent_capability_check): Change return value to bool.
  53
  54 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
  55
  56         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
  57         (build_minimal_symbol_hash_tables): Code to clear the table moved
  58         to clear_minimal_symbol_hash_tables.
  59         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
  60         when needed.
  61
  62 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
  63
  64         * infcmd.c: Remove includes.
  65         * infrun.c: Remove includes.
  66
  67 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
  68
  69         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
  70         (grow_vect): Remove declaration.
  71         (ada_type_of_array): Remove declaration.
  72         (ada_update_initial_language): Remove declaration.
  73         (ada_fold_name): Remove declaration.
  74         (ada_fill_in_ada_prototype): Remove declaration.
  75         (user_select_syms): Remove declaration.
  76         (get_selections): Remove declaration.
  77         (ada_tag_type): Remove declaration.
  78         (ada_value_tag): Remove declaration.
  79         (ada_is_others_clause): Remove declaration.
  80         (ada_in_variant): Remove declaration.
  81         (ada_value_struct_elt): Remove declaration.
  82         (ada_attribute_name): Remove declaration.
  83         (ada_system_address_type): Remove declaration.
  84         * ada-lang.c (ada_watch_location_expression): Make static.
  85         (GROW_VECT): Move here from ada-lang.h.
  86         (grow_vect): Make static.
  87         (ada_update_initial_language): Make static.
  88         (ada_fold_name): Make static.
  89         (ada_type_of_array): Make static.
  90         (encoded_ordered_before): Move up.
  91         (sort_choices): Move up.
  92         (print_signatures): Move up.
  93         (ada_print_symbol_signature): Move up.
  94         (get_selections): Move up and make static.
  95         (user_select_syms): Move up and make static.
  96         (ada_value_struct_elt): Move up and make static.
  97         (ada_tag_type): Make static.
  98         (ada_value_tag): Make static.
  99         (ada_is_others_clause): Make static.
 100         (ada_in_variant): Make static.
 101         (ada_attribute_name): Make static.
 102
 103 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 104
 105         * ada-lang.c: Remove includes.
 106         * ada-typeprint.c: Remove includes.
 107         * ada-valprint.c: Remove includes.
 108
 109 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 110
 111         * addrmap.c: Add static assertions of type size, moved from
 112         _initialize_addrmap.
 113         (_initialize_addrmap): Remove.
 114
 115 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 116
 117         * coffread.c (record_minimal_symbol): Update.
 118         (process_coff_symbol): Update.
 119         * dbxread.c (read_dbx_symtab): Update.
 120         * dwarf2read.c (add_partial_symbol): Update.
 121         (fixup_go_packaging): Update.
 122         (load_partial_dies): Update.
 123         (new_symbol): Update.
 124         * elfread.c (record_minimal_symbol): Change signature to use
 125         gdb::string_view instead of name+len.
 126         (elf_symtab_read): Update.
 127         (elf_rel_plt_read): Update.
 128         * mdebugread.c (parse_partial_symbols): Update.
 129         (handle_psymbol_enumerators): Update.
 130         (new_symbol): Update.
 131         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 132         to use gdb::string_view instead of name+len.
 133         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 134         * psympriv.h (add_psymbol_to_list): Likewise.
 135         * psymtab.c (add_psymbol_to_bcache): Likewise.
 136         (add_psymbol_to_list): Likewise.
 137         * stabsread.c (define_symbol): Update.
 138         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 139         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 140         (symbol_set_names): Likewise.
 141         * xcoffread.c (scan_xcoff_symtab): Update.
 142
 143 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 144
 145         * symtab.h (symbol_set_names): Document that copy_name must be
 146         set to true for non-nullterminated strings.
 147         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 148         linkage_name if the entry was not found and we need to demangle.
 149
 150 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 151
 152         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 153         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 154         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 155         * gdbsupport/gdb_binary_search.h: New file.
 156
 157 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 158
 159         * NEWS: Mention new --with-system-gdbinit-dir option.
 160         * config.in: Regenerate.
 161         * configure: Regenerate.
 162         * configure.ac: Add new option --with-system-gdbinit-dir.
 163         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 164         for a ".gdb" suffix.
 165         * main.c (get_init_files): Change system_gdbinit argument to
 166         a vector and return the files in SYSTEM_GDBINIT_DIR in
 167         addition to SYSTEM_GDBINIT.
 168         (captured_main_1): Update.
 169         (print_gdb_help): Update.
 170         * top.c (print_gdb_configuration): Also print the value of
 171         SYSTEM_GDBINIT_DIR.
 172
 173 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 174
 175         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 176         that takes gdb::string_view arguments.
 177
 178 2019-10-26  Tom de Vries  <tdevries@suse.de>
 179
 180         * aarch64-linux-tdep.c: Fix typos in comments.
 181         * aarch64-tdep.c: Same.
 182         * ada-lang.c: Same.
 183         * amd64-nat.c: Same.
 184         * arc-tdep.c: Same.
 185         * arch/aarch64-insn.c: Same.
 186         * block.c: Same.
 187         * breakpoint.h: Same.
 188         * btrace.h: Same.
 189         * c-varobj.c: Same.
 190         * cli/cli-decode.c: Same.
 191         * cli/cli-script.c: Same.
 192         * cli/cli-utils.h: Same.
 193         * coff-pe-read.c: Same.
 194         * coffread.c: Same.
 195         * compile/compile-cplus-symbols.c: Same.
 196         * compile/compile-object-run.c: Same.
 197         * completer.c: Same.
 198         * corelow.c: Same.
 199         * cp-support.c: Same.
 200         * demangle.c: Same.
 201         * dwarf-index-write.c: Same.
 202         * dwarf2-frame.c: Same.
 203         * dwarf2-frame.h: Same.
 204         * eval.c: Same.
 205         * frame-base.h: Same.
 206         * frame.h: Same.
 207         * gdbcmd.h: Same.
 208         * gdbtypes.h: Same.
 209         * gnu-nat.c: Same.
 210         * guile/scm-objfile.c: Same.
 211         * i386-tdep.c: Same.
 212         * i386-tdep.h: Same.
 213         * infcall.c: Same.
 214         * infcall.h: Same.
 215         * linux-nat.c: Same.
 216         * m68k-tdep.c: Same.
 217         * macroexp.c: Same.
 218         * memattr.c: Same.
 219         * mi/mi-cmd-disas.c: Same.
 220         * mi/mi-getopt.h: Same.
 221         * mi/mi-main.c: Same.
 222         * minsyms.c: Same.
 223         * nat/aarch64-sve-linux-sigcontext.h: Same.
 224         * objfiles.h: Same.
 225         * ppc-linux-nat.c: Same.
 226         * ppc-linux-tdep.c: Same.
 227         * ppc-tdep.h: Same.
 228         * progspace.h: Same.
 229         * prologue-value.h: Same.
 230         * python/py-evtregistry.c: Same.
 231         * python/py-instruction.h: Same.
 232         * record-btrace.c: Same.
 233         * record-full.c: Same.
 234         * remote.c: Same.
 235         * rs6000-tdep.c: Same.
 236         * ser-tcp.c: Same.
 237         * sol-thread.c: Same.
 238         * sparc-sol2-tdep.c: Same.
 239         * sparc64-tdep.c: Same.
 240         * stabsread.c: Same.
 241         * symfile.c: Same.
 242         * symtab.h: Same.
 243         * target.c: Same.
 244         * tracepoint.c: Same.
 245         * tui/tui-data.h: Same.
 246         * tui/tui-io.c: Same.
 247         * tui/tui-win.c: Same.
 248         * tui/tui.c: Same.
 249         * unittests/rsp-low-selftests.c: Same.
 250         * user-regs.h: Same.
 251         * utils.c: Same.
 252         * utils.h: Same.
 253         * valarith.c: Same.
 254         * valops.c: Same.
 255         * valprint.c: Same.
 256         * valprint.h: Same.
 257         * value.c: Same.
 258         * value.h: Same.
 259         * varobj.c: Same.
 260         * x86-nat.h: Same.
 261         * xtensa-tdep.c: Same.
 262
 263 2019-10-25  Ali Tamur <tamur@google.com>
 264
 265         * charset.c (find_charset_names): Reflect API change.
 266
 267 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 268
 269         * symtab.c (struct demangled_name_entry): Change demangled name
 270         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 271         part of the struct anymore.
 272         (symbol_set_names): No longer obstack allocate + copy the demangled
 273         name, just store the allocated name from bfd.
 274
 275 2019-10-25  Tom Tromey  <tromey@adacore.com>
 276
 277         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 278         (bsearch_cie_cmp, add_cie): Remove.
 279         (find_cie): Reimplement.
 280         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 281         (dwarf2_build_frame_info): Update.
 282
 283 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 284
 285         PR gdb/25126
 286         * symfile.c (reread_symbols): Call forget_cached_source_info to
 287         clear the stale source cache.
 288
 289 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 290
 291         * configure: Regenerate.
 292         * configure.ac: Remove code that sets python_has_threads.
 293
 294 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 295
 296         * config.in: Regenerate.
 297         * configure: Regenerate.
 298         * configure.ac: Remove the code that uses sed to get the python
 299         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 300
 301 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 302
 303         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 304         error paths.
 305
 306 2019-10-23  Tom Tromey  <tom@tromey.com>
 307
 308         * arc-tdep.c: Remove ".." from include.
 309         * frv-tdep.c: Remove ".." from include.
 310         * lm32-tdep.c: Remove ".." from include.
 311         * microblaze-tdep.c: Remove ".." from include.
 312         * or1k-tdep.h: Remove ".." from include.
 313         * s12z-tdep.c: Remove ".." from include.
 314         * Makefile.in (OPCODES_CFLAGS): Add comment.
 315         (TOP_CFLAGS): New variable.
 316         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 317
 318 2019-10-23  Tom Tromey  <tom@tromey.com>
 319
 320         * Makefile.in (READLINE_DIR): Update.
 321
 322 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 323
 324         * infcall.c (call_function_by_hand_dummy): Fix the function
 325         comment.  And extract out a code section into...
 326         (reserve_stack_space): ...this new function.
 327
 328 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 329
 330         * infcall.c (value_arg_coerce): Remove an unused parameter.
 331         (call_function_by_hand_dummy): Update the call to
 332         'value_arg_coerce'.
 333
 334 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 335
 336         * infcall.c (call_function_by_hand_dummy): Refactor.
 337
 338 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 339
 340         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 341
 342 2019-10-23  Tom Tromey  <tom@tromey.com>
 343
 344         * configure: Rebuild.
 345         * configure.ac: Don't check for sigprocmask.
 346         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 347
 348 2019-10-23  Tom Tromey  <tom@tromey.com>
 349
 350         * configure: Rebuild.
 351         * acinclude.m4: Use m4_include, not sinclude.
 352
 353 2019-10-23  Tom de Vries  <tdevries@suse.de>
 354
 355         PR breakpoints/24687
 356         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 357
 358 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 359
 360         * symtab.c (struct demangled_name_entry) <language>: Change from
 361         bitfield to regular variable.
 362
 363 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 364
 365         * symtab.c (struct demangled_name_entry): Add a constructor.
 366         (free_demangled_name_entry): New function to call the destructor
 367         for demangled_name_entry.
 368         (create_demangled_names_hash): Pass free_demangled_name_entry to
 369         htab_create_alloc.
 370         (symbol_set_names): Call placement new for demangled_name_entry.
 371         * utils.c: No longer include xxhash.h here, now that fast_hash
 372         is inlined in the header.
 373         * utils.h: Instead, include it here.
 374
 375 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 376
 377         * Makefile.in: Link with libxxhash.
 378         * config.in: Regenerate.
 379         * configure: Regenerate.
 380         * configure.ac: Search for libxxhash.
 381         * utils.c (fast_hash): Use xxhash if present.
 382
 383 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 384
 385         * utils.h (fast_hash): New function.
 386         * symtab.c (hash_demangled_name_entry): Call new function
 387         fast_hash.
 388
 389 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 390
 391         * symtab.c (struct demangled_name_entry): Change type of mangled
 392         to gdb::string_view. Also adds a constructor that takes the
 393         mangled name.
 394         (hash_demangled_name_entry): Update.
 395         (eq_demangled_name_entry): Update.
 396         (free_demangled_name_entry): New function to call the destructor
 397         now that this is not a POD anymore.
 398         (create_demangled_names_hash): Pass free_demangled_name_entry to
 399         htab_create_alloc.
 400         (symbol_set_names): Update.
 401
 402 2019-10-21  Ali Tamur  <tamu@google.com>
 403
 404         * dwarf2read.c (dir_index): Change type.
 405         (file_name_index): Likewise.
 406         (line_header::include_dir_at): Change comment and implementation on
 407         whether it is DWARF 5.
 408         (line_header::is_valid_file_index): New function.
 409         (line_header::file_name_at): Change comment and implementation on
 410         whether it is DWARF 5.
 411         (line_header::file_names): Change to private field renamed as
 412         m_file_names and introduce a new accessor method.
 413         (line_header::file_names_size): New method.
 414         (line_header::include_dirs): Change to private field and rename as
 415         m_include_dirs.
 416         (dw2_get_file_names_reader): Define local var at a smaller scope and
 417         reflect API change.
 418         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 419         (process_structure_scope): Likewise.
 420         (line_header::add_include_dir): Change message and reflect renaming.
 421         (line_header::add_file_name): Likewise.
 422         (read_formatted_entries): Handle DW_FORM_data16.
 423         (dwarf_decode_line_header): Fix line header length calculation.
 424         (psymtab_include_file_name): Change comment and API.
 425         (lnp_state_machine::m_file): Update comment and reflect type change.
 426         (lnp_state_machine::record_line): Reflect type change.
 427         (dwarf_decode_lines): Reflect API change.
 428         (file_file_name): Likewise.
 429         (file_full_name): Likewise.
 430
 431 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 432
 433         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 434
 435 2019-10-21  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 438
 439 2019-10-21  Tom Tromey  <tom@tromey.com>
 440
 441         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 442         NM_H.   Use AC_CONFIG_LINKS.
 443         * configure: Rebuild.
 444         * Makefile.in (NM_H): New variable.
 445         (generated_files): Add NM_H.  Remove gcore.
 446         (nm.h, stamp-nmh): New targets.
 447
 448 2019-10-20  Tom Tromey  <tom@tromey.com>
 449
 450         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 451         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 452         obsolete comment.
 453         (put_objfile_before): Now static.
 454
 455 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 456
 457         * gdbsupport/common-utils.h (startswith): Change return type to
 458         bool.
 459
 460 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 461
 462         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 463         * breakpoint.c (bp_locations_compare): Rename to...
 464         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 465         (update_global_location_list): Use std::sort instead of qsort.
 466         * buildsym.c (compare_line_numbers): Rename to...
 467         (lte_is_less_than): ...this, and change to std::sort semantics.
 468         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 469         instead of qsort.
 470         * disasm.c (compare_lines): Rename to...
 471         (line_is_less_than): ...this, and change to std::sort semantics.
 472         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 473         of qsort.
 474         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 475         (fde_is_less_than): ...this, and change to std::sort semantics.
 476         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 477         * mdebugread.c (compare_blocks):
 478         (block_is_less_than): ...this, and change to std::sort semantics.
 479         (sort_blocks): Call std::sort instead of qsort.
 480         * objfiles.c (qsort_cmp): Rename to...
 481         (sort_cmp): ...this, and change to std::sort semantics.
 482         (update_section_map): Call std::sort instead of qsort.
 483         * remote.c (compare_pnums): Remove.
 484         (map_regcache_remote_table): Call std::sort instead of qsort.
 485         * utils.c (compare_positive_ints): Remove.
 486         * utils.h (compare_positive_ints): Remove.
 487         * xcoffread.c (compare_lte): Remove.
 488         (arrange_linetable): Call std::sort instead of qsort.
 489
 490 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 491
 492         * symfile.c (init_entry_point_info): Fix typo.
 493         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 494
 495 2019-10-18  Tom de Vries  <tdevries@suse.de>
 496
 497         * aarch64-tdep.c: Fix typos in comments.
 498         * ada-lang.c: Same.
 499         * ada-tasks.c: Same.
 500         * alpha-tdep.c: Same.
 501         * alpha-tdep.h: Same.
 502         * amd64-nat.c: Same.
 503         * amd64-windows-tdep.c: Same.
 504         * arc-tdep.c: Same.
 505         * arc-tdep.h: Same.
 506         * arch-utils.c: Same.
 507         * arm-nbsd-tdep.c: Same.
 508         * arm-tdep.c: Same.
 509         * ax-gdb.c: Same.
 510         * blockframe.c: Same.
 511         * btrace.c: Same.
 512         * c-varobj.c: Same.
 513         * coff-pe-read.c: Same.
 514         * coffread.c: Same.
 515         * cris-tdep.c: Same.
 516         * darwin-nat.c: Same.
 517         * dbxread.c: Same.
 518         * dcache.c: Same.
 519         * disasm.c: Same.
 520         * dtrace-probe.c: Same.
 521         * dwarf-index-write.c: Same.
 522         * dwarf2-frame-tailcall.c: Same.
 523         * dwarf2-frame.c: Same.
 524         * dwarf2read.c: Same.
 525         * eval.c: Same.
 526         * exceptions.c: Same.
 527         * fbsd-tdep.c: Same.
 528         * findvar.c: Same.
 529         * frame.c: Same.
 530         * frv-tdep.c: Same.
 531         * gnu-v3-abi.c: Same.
 532         * go32-nat.c: Same.
 533         * h8300-tdep.c: Same.
 534         * hppa-tdep.c: Same.
 535         * i386-linux-tdep.c: Same.
 536         * i386-tdep.c: Same.
 537         * ia64-libunwind-tdep.c: Same.
 538         * ia64-tdep.c: Same.
 539         * infcmd.c: Same.
 540         * infrun.c: Same.
 541         * linespec.c: Same.
 542         * linux-nat.c: Same.
 543         * linux-thread-db.c: Same.
 544         * machoread.c: Same.
 545         * mdebugread.c: Same.
 546         * mep-tdep.c: Same.
 547         * mn10300-tdep.c: Same.
 548         * namespace.c: Same.
 549         * objfiles.c: Same.
 550         * opencl-lang.c: Same.
 551         * or1k-tdep.c: Same.
 552         * osabi.c: Same.
 553         * ppc-linux-nat.c: Same.
 554         * ppc-linux-tdep.c: Same.
 555         * ppc-sysv-tdep.c: Same.
 556         * printcmd.c: Same.
 557         * procfs.c: Same.
 558         * record-btrace.c: Same.
 559         * record-full.c: Same.
 560         * remote-fileio.c: Same.
 561         * remote.c: Same.
 562         * rs6000-tdep.c: Same.
 563         * s12z-tdep.c: Same.
 564         * score-tdep.c: Same.
 565         * ser-base.c: Same.
 566         * ser-go32.c: Same.
 567         * skip.c: Same.
 568         * sol-thread.c: Same.
 569         * solib-svr4.c: Same.
 570         * solib.c: Same.
 571         * source.c: Same.
 572         * sparc-nat.c: Same.
 573         * sparc-sol2-tdep.c: Same.
 574         * sparc-tdep.c: Same.
 575         * sparc64-tdep.c: Same.
 576         * stabsread.c: Same.
 577         * stack.c: Same.
 578         * symfile.c: Same.
 579         * symtab.c: Same.
 580         * target-descriptions.c: Same.
 581         * target-float.c: Same.
 582         * thread.c: Same.
 583         * utils.c: Same.
 584         * valops.c: Same.
 585         * valprint.c: Same.
 586         * value.c: Same.
 587         * varobj.c: Same.
 588         * windows-nat.c: Same.
 589         * xcoffread.c: Same.
 590         * xstormy16-tdep.c: Same.
 591         * xtensa-tdep.c: Same.
 592
 593 2019-10-17  Tom Tromey  <tromey@adacore.com>
 594
 595         * configure: Rebuild.
 596         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 597         in AC_CONFIG_FILES invocation.
 598         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 599         new-style config.status invocation.
 600
 601 2019-10-17  Tom de Vries  <tdevries@suse.de>
 602
 603         * arm-nbsd-nat.c: Fix typos in comments.
 604         * arm-tdep.c: Same.
 605         * darwin-nat-info.c: Same.
 606         * dwarf2read.c: Same.
 607         * elfread.c: Same.
 608         * event-top.c: Same.
 609         * findvar.c: Same.
 610         * gdbtypes.c: Same.
 611         * hppa-tdep.c: Same.
 612         * i386-tdep.c: Same.
 613         * jit.c: Same.
 614         * main.c: Same.
 615         * mdebugread.c: Same.
 616         * moxie-tdep.c: Same.
 617         * nto-procfs.c: Same.
 618         * osabi.c: Same.
 619         * ppc-linux-tdep.c: Same.
 620         * remote.c: Same.
 621         * riscv-tdep.c: Same.
 622         * s390-tdep.c: Same.
 623         * sh-tdep.c: Same.
 624         * sparc-linux-tdep.c: Same.
 625         * sparc-nat.c: Same.
 626         * stack.c: Same.
 627         * target-descriptions.c: Same.
 628         * top.c: Same.
 629         * varobj.c: Same.
 630
 631 2019-10-16  Tom Tromey  <tom@tromey.com>
 632
 633         * objfiles.h (struct objfile) <original_name>: Now const.
 634
 635 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 636
 637         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 638         pass on to sigsetjmp's second argument.
 639         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 640
 641 2019-10-16  Keith Seitz  <keiths@redhat.com>
 642
 643         PR gdb/23567
 644         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 645         sections whose size is greater than the file size.
 646
 647 2019-10-16  Jim Wilson  <jimw@sifive.com>
 648
 649         * riscv-tdep.c (riscv_gcc_target_options): New.
 650         (riscv_gnu_triplet_regexp): New.
 651         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 652         set_gdbarch_gnu_triplet_regexp.
 653
 654 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 655
 656         * Makefile.in: Add xml-builtin.h.
 657         * features/feature_to_c.sh: Add an include for xml-builtin.h
 658         to ensure that the compiler checks that the types match.
 659         * xml-builtin.h: New file.
 660         * xml-support.c (fetch_xml_builtin): Add missing const.
 661         * xml-support.h: Remove declaration of xml_builtins.
 662
 663 2019-10-16  Tom de Vries  <tdevries@suse.de>
 664
 665         PR tdep/25096
 666         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 667         (amd64_classify_aggregate): ... here.
 668         (amd64_classify_aggregate_field): Handled fiels of nested structs
 669         recursively.
 670
 671 2019-10-16  Tom de Vries  <tdevries@suse.de>
 672
 673         PR tdep/24104
 674         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 675         that handles 'theclass'.
 676
 677 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 678
 679         * linespec.c (decode_digits_ordinary): Update comment.
 680         * make-target-delegates: No longer need to handle VEC case.
 681         * memrange.c (normalize_mem_ranges): Update comment.
 682         * namespace.c (add_using_directive): Update comment.
 683         * objc-lang.c (uniquify_strings): Update comment.
 684         * ppc-linux-nat.c (struct thread_points): Update comment.
 685         * probe.h (find_probes_in_objfile): Update comment.
 686         * target.h (enum flash_preserve_mode): Update comment.
 687         * varobj.c (varobj_restrict_range): Update comment.
 688         * varobj.h (varobj_list_children): Update comment.
 689
 690 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 691
 692         * Makefile.in: Remove references to vec.h and vec.c.
 693         * aarch64-tdep.c: No longer include vec.h.
 694         * ada-lang.c: Likewise.
 695         * ada-lang.h: Likewise.
 696         * arm-tdep.c: Likewise.
 697         * ax.h: Likewise.
 698         * breakpoint.h: Likewise.
 699         * charset.c: Likewise.
 700         * cp-support.h: Likewise.
 701         * dtrace-probe.c: Likewise.
 702         * dwarf2read.c: Likewise.
 703         * extension.h: Likewise.
 704         * gdb_bfd.c: Likewise.
 705         * gdbsupport/gdb_vecs.h: Likewise.
 706         * gdbsupport/vec.c: Remove.
 707         * gdbsupport/vec.h: Remove.
 708         * gdbthread.h: Likewise.
 709         * guile/scm-type.c: Likewise.
 710         * inline-frame.c: Likewise.
 711         * machoread.c: Likewise.
 712         * memattr.c: Likewise.
 713         * memrange.h: Likewise.
 714         * namespace.h: Likewise.
 715         * nat/linux-btrace.h: Likewise.
 716         * osdata.c: Likewise.
 717         * parser-defs.h: Likewise.
 718         * progspace.h: Likewise.
 719         * python/py-type.c: Likewise.
 720         * record-btrace.c: Likewise.
 721         * rust-exp.y: Likewise.
 722         * solib-target.c: Likewise.
 723         * stap-probe.c: Likewise.
 724         * target-descriptions.c: Likewise.
 725         * target-memory.c: Likewise.
 726         * target.h: Likewise.
 727         * varobj.c: Likewise.
 728         * varobj.h: Likewise.
 729         * xml-support.h: Likewise.
 730
 731 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 732
 733         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 734         Update for new std::vector based implementation.
 735         (process_psymtab_comp_unit_reader): Likewise.
 736         (scan_partial_symbols): Likewise.
 737         (recursively_compute_inclusions): Likewise.
 738         (compute_compunit_symtab_includes): Likewise.
 739         (process_imported_unit_die): Likewise.
 740         (queue_and_load_dwo_tu): Likewise.
 741         (follow_die_sig_1): Likewise.
 742         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 743         (typedef dwarf2_per_cu_ptr): Remove.
 744         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 745         function.
 746         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 747         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 748         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 749         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 750         std::vector.
 751
 752 2019-10-15  Tom Tromey  <tromey@adacore.com>
 753
 754         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 755         TID.
 756
 757 2019-10-15  Tom Tromey  <tromey@adacore.com>
 758
 759         * windows-nat.c (windows_nat_target::fetch_registers)
 760         (windows_nat_target::store_registers): Rename "pid" to "tid".
 761
 762 2019-10-15  Tom Tromey  <tromey@adacore.com>
 763
 764         * gdbarch.h, gdbarch.c: Rebuild.
 765         * gdbarch.sh (gcc_target_options): Change return type to
 766         std::string.
 767         * compile/compile.c (get_args): Update.
 768         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 769         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 770         std::string.
 771         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 772         std::string.
 773         * arch-utils.c (default_gcc_target_options): Return std::string.
 774         * arch-utils.h (default_gcc_target_options): Return std::string.
 775         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 776
 777 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 778
 779         * breakpoint.c (breakpoint_chain): Make static.
 780         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 781         of accessing breakpoint_chain.
 782
 783 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 784
 785         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 786         to a gdb::function_view and return value to bool.
 787         * breakpoint.h (iterate_over_breakpoints): Likewise.
 788         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 789         (pop_dummy_frame): Update.
 790         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 791         (gdbscm_breakpoints): Update.
 792         * python/py-breakpoint.c (build_bp_list): Update.
 793         (gdbpy_breakpoints): Update.
 794         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 795         Update.
 796         (bpfinishpy_handle_stop): Update.
 797         (bpfinishpy_handle_exit): Update.
 798         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 799         (svr4_update_solib_event_breakpoints): Update.
 800
 801 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 802
 803         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 804         when unwrapping single-field structs.
 805
 806 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 807
 808         * dwarf2read.c: Remove includes.
 809
 810 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 811
 812         * ui-out.c (ui_out::call_do_message): Silence
 813         -Wformat-nonliteral warning.
 814
 815 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 816
 817         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 818         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 819         include: readline/tilde.h.
 820
 821 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 822
 823         * remote.c (remote_target::get_trace_status): Remove declaration of
 824         trace_regblock_size.
 825
 826 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 827
 828         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 829         (show_user): Remove declaration of cmdlist.
 830         * cli/cli-cmds.h (max_user_call_depth): Declare.
 831         * cli/cli-script.c (execute_user_command): Remove declaration
 832         of max_user_call_depth.
 833
 834 2019-10-11  Jim Wilson  <jimw@sifive.com>
 835
 836         * gdbsupport/print-utils.h (pulongest): Fix comment.
 837         (plongest): Likewise.
 838         (phex): Add missing comment, mention leading zeros.
 839         (phex_nz): Add mention of no leading zeros to comment.
 840
 841         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 842         plongest instead of unsigned long long cast.
 843
 844 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 845
 846         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 847         for external_editor_command and gdbtk_test.
 848
 849 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 850
 851         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 852         * varobj.c (varobjdebug): Move comment to...
 853         * varobj.h (varobjdebug): ...here, and declare.
 854
 855 2019-10-09  Tom Tromey  <tom@tromey.com>
 856
 857         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 858         erase_data_content.
 859
 860 2019-10-09  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 863         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 864         * tui/tui-command.c (tui_cmd_window::resize)
 865         (tui_refresh_cmd_win): Update.
 866         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 867         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 868         * tui/tui-data.c (~tui_gen_win_info): Remove.
 869         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 870         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 871         (tui_redisplay_readline, tui_mld_flush)
 872         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 873         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 874         (tui_data_window::erase_data_content)
 875         (tui_data_item_window::rerender)
 876         (tui_data_item_window::refresh_window): Update.
 877         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 878         (box_win, tui_gen_win_info::make_window)
 879         (tui_gen_win_info::make_visible): Update.
 880         (tui_delete_win): Remove.
 881         * tui/tui-winsource.c
 882         (tui_source_window_base::do_erase_source_content): Update.
 883         (tui_show_source_line, tui_source_window_base::update_tab_width)
 884         (tui_source_window_base::update_exec_info): Update.
 885         * tui/tui-data.h (struct curses_deleter): New.
 886         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 887         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 888
 889 2019-10-09  Tom Tromey  <tom@tromey.com>
 890
 891         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 892
 893 2019-10-09  Tom Tromey  <tom@tromey.com>
 894
 895         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 896         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 897
 898 2019-10-09  Tom Tromey  <tom@tromey.com>
 899
 900         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 901         window height directly.
 902         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 903         declare.
 904         * tui/tui-layout.c (tui_default_win_height): Remove.
 905         (tui_default_win_viewport_height): Remove.
 906
 907 2019-10-09  Tom Tromey  <tom@tromey.com>
 908
 909         * tui/tui.h: Remove comments.
 910
 911 2019-10-09  Tom de Vries  <tdevries@suse.de>
 912
 913         * python/lib/gdb/printer/bound_registers.py: Use
 914         '^builtin_type_bound128' as regexp argument for
 915         add_builtin_pretty_printer.
 916
 917 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 918
 919         * guile/guile.c (guile_extension_script_ops): Remove forward
 920         declaration and mark as static.
 921         (guile_script_ops): Likewise.
 922         (extension_language_guile): Move further down in the file so
 923         it can reference the definitions for guile_{extension_,}script_ops.
 924
 925 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 926
 927         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 928         except SORTL, DFLTCC, and KDSA.
 929
 930 2019-10-08  Tom Tromey  <tromey@adacore.com>
 931
 932         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 933         (struct safe_symbol_file_add_args): Remove.
 934
 935 2019-10-08  Tom Tromey  <tromey@adacore.com>
 936
 937         * windows-nat.c: Don't include buildsym-legacy.h.
 938
 939 2019-10-08  Tom Tromey  <tromey@adacore.com>
 940
 941         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 942
 943 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 944
 945         * gdbtypes.c (overload_debug): Move comment to header.
 946         * gdbtypes.h (overload_debug): Declare.
 947         * valops.c: Remove declaration of overload_debug, instead
 948         include gdbtypes.h.
 949
 950 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 951
 952         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 953         through _().
 954         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 955         move comment...
 956         * language.h (lang_frame_mismatch_warn): ... here. Also add
 957         declaration.
 958         * top.c (lang_frame_mismatch_warn): Remove declaration.
 959         (check_frame_language_change): Pass lang_frame_mismatch_warn
 960         through _().
 961
 962 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 963
 964         * c-lang.h (vtbl_ptr_name): Declare.
 965         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 966         it from the header.
 967         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 968
 969 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 970
 971         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 972         gdb_static_assert.
 973
 974 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 975
 976         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 977         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 978         * ctfread.c: New file.
 979         * ctfread.h: New file.
 980         * elfread.c: Include ctfread.h.
 981         (struct elfinfo text_p): New member ctfsect.
 982         (elf_locate_sections): Mark CTF section.
 983         (elf_symfile_read): Call elfctf_build_psymtabs.
 984         * Makefile.in (LIBCTF): Add.
 985         (CLIBS): Use it.
 986         (CDEPS): Likewise.
 987         (DIST): Add ctfread.c.
 988
 989 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 990
 991         * ctfread.c (struct nextfield): Renamed to ...
 992         (struct ctf_nextfield): ... this.
 993         (struct field_info): Renamed to ...
 994         (strut ctf_field_info): ... this.
 995         (attach_fields_to_type): Update for renamed structures.
 996         (ctf_add_member_cb): Likewise.
 997         (ctf_add_enum_member_cb): Likewise.
 998         (process_struct_members): Likewise.
 999         (process_enum_type): Likewise.
1000
1001 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1002
1003         * tracectf.h: Rename, was ctf.h.
1004         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1005         * tracefile.c: Likewise.
1006         * tracepoint.c: Remove unused include ctf.h.
1007         * mi/mi-main.c: Likewise.
1008         * Makefile.in Replace ctf.c with tracectf.c.
1009
1010 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1011
1012         * version.in: Change version number to "9.0.50.DATE-git".
1013
1014 2019-10-03  Tom Tromey  <tom@tromey.com>
1015
1016         PR rust/24976:
1017         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1018
1019 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1020
1021         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1022         cp_search_name_hash.
1023         * NEWS: Add entry about nested function support.
1024
1025 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1026             Andrew Burgess  <andrew.burgess@embecosm.com>
1027
1028         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1029         for nested static variables when searchin VAR_DOMAIN.
1030         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1031         global scope, update comment.
1032         (add_partial_subprogram): Call add_partial_subprogram recursively
1033         for nested subroutines when processinng Fortran.
1034         (load_partial_dies): Process the child entities of a subprogram
1035         when processing Fortran.
1036         (partial_die_parent_scope): Handle building scope
1037         for Fortran nested functions.
1038         (process_die): Record that nested functions have a scope.
1039         (new_symbol): Always record Fortran subprograms on the global
1040         symbol list.
1041         (determine_prefix): How to build the prefix for Fortran
1042         subprograms.
1043
1044 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1045
1046         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1047         have just sent the thread a SIGSTOP and are waiting for it to
1048         arrive.
1049
1050 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1051
1052         * btrace.c (btrace_add_pc): Remove whitespace before the template
1053         parameter in 'std::vector <...>'.
1054         (parse_xml_btrace_block): Likewise.
1055         (btrace_maint_decode_pt): Likewise.
1056         (btrace_maint_update_packets): Likewise.
1057         (btrace_maint_print_packets): Likewise.
1058         * btrace.h (struct btrace_maint_info): Likewise.
1059         * dwarf2read.c (struct type_unit_group): Likewise.
1060         (build_type_psymtabs_reader): Likewise.
1061         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1062         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1063         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1064
1065 2019-10-03  Tom de Vries  <tdevries@suse.de>
1066
1067         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1068         the first line of the help text for set/show style metadata.
1069
1070 2019-10-02  Tom Tromey  <tromey@adacore.com>
1071
1072         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1073         * gdbsupport/common-inferior.c: New file.
1074         * infcmd.c (startup_with_shell): Don't define.
1075         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1076         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1077         * inferior.h (startup_with_shell): Don't declare.
1078
1079 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1080
1081         * gdbsupport/gdb_assert.h: Include errors.h.
1082         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1083
1084 2019-10-02  Tom Tromey  <tromey@adacore.com>
1085
1086         * NEWS: Add $_ada_exception entry.
1087         * ada-lang.c (struct ada_catchpoint): Add constructor.
1088         <m_kind>: New member.
1089         (allocate_location_exception, re_set_exception): Remove
1090         "ex" parameter.
1091         (should_stop_exception): Compute $_ada_exception.
1092         (check_status_exception, print_it_exception)
1093         (print_one_exception, print_mention_exception): Remove
1094         "ex" parameter.
1095         (allocate_location_catch_exception, re_set_catch_exception)
1096         (check_status_exception, print_it_catch_exception)
1097         (print_one_catch_exception, print_mention_catch_exception)
1098         (print_recreate_catch_exception)
1099         (allocate_location_catch_exception_unhandled)
1100         (re_set_catch_exception_unhandled)
1101         (check_status_exception, print_it_catch_exception_unhandled)
1102         (print_one_catch_exception_unhandled)
1103         (print_mention_catch_exception_unhandled)
1104         (print_recreate_catch_exception_unhandled)
1105         (allocate_location_catch_assert, re_set_catch_assert)
1106         (check_status_assert, print_it_catch_assert)
1107         (print_one_catch_assert, print_mention_catch_assert)
1108         (print_recreate_catch_assert)
1109         (allocate_location_catch_handlers, re_set_catch_handlers)
1110         (check_status_handlers, print_it_catch_handlers)
1111         (print_one_catch_handlers, print_mention_catch_handlers)
1112         (print_recreate_catch_handlers): Remove.
1113         (create_ada_exception_catchpoint): Update.
1114         (initialize_ada_catchpoint_ops): Update.
1115
1116 2019-10-02  Tom Tromey  <tromey@adacore.com>
1117
1118         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1119         (create_excep_cond_exprs): Simplify exception string computation.
1120         (ada_exception_catchpoint_cond_string): Likewise.
1121
1122 2019-10-02  Tom Tromey  <tromey@adacore.com>
1123
1124         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1125         * ada-lang.c (lesseq_defined_than): Handle
1126         LOC_STATIC.
1127         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1128         parameter.
1129         (dwarf2_has_info): Likewise.
1130         (new_symbol): Set maybe_copied on symbol when
1131         appropriate.
1132         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1133         parameter.
1134         <can_copy>: New member.
1135         * elfread.c (record_minimal_symbol): Set maybe_copied
1136         on symbol when appropriate.
1137         (elf_symfile_read): Update call to dwarf2_has_info.
1138         * minsyms.c (lookup_minimal_symbol_linkage): New
1139         function.
1140         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1141         * symtab.c (get_symbol_address, get_msymbol_address):
1142         New functions.
1143         * symtab.h (get_symbol_address, get_msymbol_address):
1144         Declare.
1145         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1146         maybe_copied.
1147         (struct symbol, struct minimal_symbol) <maybe_copied>:
1148         New member.
1149
1150 2019-10-02  Tom Tromey  <tromey@adacore.com>
1151
1152         * source.c (struct current_source_location): New.
1153         (current_source_key): New global.
1154         (current_source_symtab, current_source_line)
1155         (current_source_pspace): Remove.
1156         (get_source_location): New function.
1157         (get_current_source_symtab_and_line)
1158         (set_default_source_symtab_and_line)
1159         (set_current_source_symtab_and_line)
1160         (clear_current_source_symtab_and_line, select_source_symtab)
1161         (info_source_command, print_source_lines_base)
1162         (info_line_command, search_command_helper, _initialize_source):
1163         Update.
1164
1165 2019-10-02  Tom Tromey  <tromey@adacore.com>
1166
1167         * source.c (select_source_symtab): Don't call
1168         decode_line_with_current_source.
1169
1170 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1171
1172         * symtab.c (lookup_global_symbol): Search global block.
1173
1174 2019-10-02  Tom Tromey  <tromey@adacore.com>
1175
1176         * coffread.c (process_coff_symbol): Update.
1177         * dwarf2read.c (var_decode_location, new_symbol): Update.
1178         * mdebugread.c (parse_symbol): Update.
1179         * objfiles.c (relocate_one_symbol): Update.
1180         * stabsread.c (define_symbol, fix_common_block)
1181         (scan_file_globals): Update.
1182         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1183         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1184         * xcoffread.c (process_xcoff_symbol): Update.
1185
1186 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1187
1188         * MAINTAINERS: Update my email address.
1189
1190 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1191
1192         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1193         std::vector.
1194         (build_type_psymtabs_reader): Update for std::vector.
1195         (build_type_psymtab_dependencies): Likewise.
1196         * dwarf2read.h: Remove use of DEF_VEC_P.
1197         (typedef sig_type_ptr): Delete.
1198
1199 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1200
1201         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1202         to std::vector.
1203         (btrace_maint_decode_pt): Likewise, and move allocation of the
1204         vector outside of the loop.
1205         (btrace_maint_update_packets): Update to handle change from VEC to
1206         std::vector.
1207         (btrace_maint_print_packets): Likewise.
1208         (maint_info_btrace_cmd): Likewise.
1209         * btrace.h: Remove use of DEF_VEC_O.
1210         (typedef btrace_pt_packet_s): Delete.
1211         (struct btrace_maint_info) <packets>: Change fromm VEC to
1212         std::vector.
1213         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1214
1215 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1216
1217         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1218         make accesses into the vector constant references.
1219         (btrace_add_pc): Update for std::vector.
1220         (btrace_stitch_bts): Likewise.
1221         (parse_xml_btrace_block): Likewise.
1222         (btrace_maint_update_packets): Likewise.
1223         (btrace_maint_print_packets): Likewise.
1224         (maint_info_btrace_cmd): Likewise.
1225         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1226         std::vector.
1227         (btrace_data::empty): Likewise.
1228         (btrace_data_append): Likewise.
1229         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1230         (typedef btrace_block_s): Delete.
1231         (struct btrace_block): Add constructor.
1232         (struct btrace_data_bts) <blocks>: Change to std::vector.
1233         * nat/linux-btrace.c (perf_event_read_bts): Update for
1234         std::vector.
1235         (linux_read_bts): Likewise.
1236
1237 2019-10-01  Tom Tromey  <tom@tromey.com>
1238
1239         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1240
1241 2019-10-01  Tom Tromey  <tom@tromey.com>
1242
1243         * stack.c (print_frame, info_frame_command_core): Use
1244         styled_string.
1245         * linux-thread-db.c (try_thread_db_load_1)
1246         (try_thread_db_load_from_pdir_1): Use styled_string.
1247         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1248         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1249         (maybe_print_unsupported_script_warning)
1250         (maybe_print_script_not_found_warning): Use styled_string.
1251         * ada-lang.c (user_select_syms): Use styled_string.
1252
1253 2019-10-01  Tom Tromey  <tom@tromey.com>
1254
1255         * p-lang.c (pascal_printstr): Use metadata style.
1256         * value.c (show_convenience): Use metadata style.
1257         * valprint.c (valprint_check_validity, val_print_optimized_out)
1258         (val_print_not_saved, val_print_unavailable)
1259         (val_print_invalid_address, generic_val_print, val_print)
1260         (value_check_printable, val_print_array_elements): Use metadata
1261         style.
1262         * ui-out.h (class ui_out) <field_fmt>: New overload.
1263         <do_field_fmt>: Add style parameter.
1264         * ui-out.c (ui_out::field_fmt): New overload.
1265         * typeprint.c (type_print_unknown_return_type)
1266         (val_print_not_allocated, val_print_not_associated): Use metadata
1267         style.
1268         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1269         parameter.
1270         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1271         * tracepoint.c (tvariables_info_1): Use metadata style.
1272         * stack.c (print_frame_arg, print_frame_info, print_frame)
1273         (info_frame_command_core): Use metadata style.
1274         * skip.c (info_skip_command): Use metadata style.
1275         * rust-lang.c (rust_print_enum): Use metadata style.
1276         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1277         metadata style.
1278         * python/py-framefilter.c (py_print_single_arg): Use metadata
1279         style.
1280         * printcmd.c (do_one_display, print_variable_and_value): Use
1281         metadata style.
1282         * p-valprint.c (pascal_val_print)
1283         (pascal_object_print_value_fields): Use metadata style.
1284         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1285         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1286         parameter.
1287         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1288         * m2-valprint.c (m2_print_long_set): Use metadata style.
1289         * m2-typeprint.c (m2_print_type): Use metadata style.
1290         * infcmd.c (print_return_value_1): Use metadata style.
1291         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1292         * f-valprint.c (info_common_command_for_block): Use metadata
1293         style.
1294         * f-typeprint.c (f_type_print_base): Use metadata style.
1295         * expprint.c (print_subexp_standard): Use metadata style.
1296         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1297         * cli/cli-style.h (class cli_style_option): Add constructor.
1298         (metadata_style): Declare.
1299         * cli/cli-style.c (metadata_style): New global.
1300         (_initialize_cli_style): Register metadata style.
1301         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1302         parameter.
1303         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1304         * c-typeprint.c (c_type_print_base_struct_union)
1305         (c_type_print_base_1): Use metadata style.
1306         * breakpoint.c (watchpoint_value_print)
1307         (print_one_breakpoint_location): Use metadata style.
1308         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1309         style.
1310         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1311         style.
1312         * ada-valprint.c (val_print_packed_array_elements, printstr)
1313         (print_field_values, ada_val_print_ref, ada_val_print): Use
1314         metadata style.
1315         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1316         style.
1317         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1318         style.
1319         * ada-lang.c (user_select_syms): Use metadata style.
1320
1321 2019-10-01  Tom Tromey  <tom@tromey.com>
1322
1323         * cli/cli-cmds.c (pwd_command): Style output.
1324
1325 2019-10-01  Pedro Alves  <palves@redhat.com>
1326             Tom Tromey  <tom@tromey.com>
1327
1328         * symtab.c (print_symbol_info): Use %ps.
1329         (print_msymbol_info): Use %ps.
1330         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1331         * printcmd.c (print_variable_and_value): Use %ps.
1332         * macrocmd.c (show_pp_source_pos): Use %ps.
1333         * infrun.c (print_exited_reason): Use ui_out::message.
1334         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1335         (describe_other_breakpoints): Use ui_out::message and new
1336         formats.
1337         (say_where): Use new formats.
1338         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1339         and new formats.
1340
1341 2019-10-01  Pedro Alves  <palves@redhat.com>
1342             Tom Tromey  <tom@tromey.com>
1343
1344         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1345         (test_gdb_formats): New function.
1346         (run_tests): Call it.
1347         (test_format_specifier): Update.
1348         * utils.h (fputs_filtered): Update comment.
1349         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1350         (fputs_styled_unfiltered): Declare.
1351         * utils.c (fputs_styled_unfiltered): New function.
1352         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1353         (vfprintf_filtered): Update.
1354         (vfprintf_unfiltered, vprintf_filtered): Update.
1355         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1356         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1357         disallow_ui_out_field>: New constants.
1358         (enum class field_kind): New.
1359         (struct base_field_s, struct signed_field_s): New.
1360         (signed_field): New function.
1361         (struct string_field_s): New.
1362         (string_field): New function.
1363         (struct styled_string_s): New.
1364         (styled_string): New function.
1365         (class ui_out) <message>: Add comment.
1366         <vmessage, call_do_message>: New methods.
1367         <do_message>: Add style parameter.
1368         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1369         methods.
1370         (ui_out::message): Rewrite.
1371         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1372         parameter.
1373         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1374         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1375         gdb_extensions parameter.
1376         (class format_piece): Add parameter to constructor.
1377         (n_int_args): New field.
1378         * gdbsupport/format.c (format_pieces::format_pieces): Add
1379         gdb_extensions parameter.  Handle '*'.
1380         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1381         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1382         vfprintf_styled_no_gdbfmt.
1383         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1384         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1385         unfiltered output.
1386         * ui-style.h (struct ui_file_style) <ptr>: New method.
1387
1388 2019-10-01  Tom Tromey  <tom@tromey.com>
1389
1390         * unittests/format_pieces-selftests.c: Update.  Add final format.
1391         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1392         empty literal pieces.
1393
1394 2019-10-01  Tom Tromey  <tom@tromey.com>
1395
1396         * ui-out.h (enum class ui_out_style_kind): Remove.
1397         (class ui_out) <field_string, field_stsream, do_field_string>:
1398         Change type of "style".
1399         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1400         (ui_out::field_string): Update.
1401         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1402         of "style".
1403         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1404         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1405         * stack.c (print_frame_arg, print_frame_info, print_frame):
1406         Update.
1407         * source.c (print_source_lines_base): Update.
1408         * solib.c (info_sharedlibrary_command): Update.
1409         * skip.c (info_skip_command): Update.
1410         * record-btrace.c (btrace_call_history_src_line)
1411         (btrace_call_history): Update.
1412         * python/py-framefilter.c (py_print_frame): Update.
1413         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1414         "style".
1415         * mi/mi-out.c (mi_ui_out::do_table_header)
1416         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1417         (mi_ui_out::do_field_string): Update.
1418         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1419         Update.
1420         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1421         "style".
1422         * cli-out.c (cli_ui_out::do_table_header)
1423         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1424         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1425         (cli_ui_out::do_field_fmt): Update.
1426         * breakpoint.c (print_breakpoint_location): Update.
1427         (update_static_tracepoint): Update.
1428
1429 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1430
1431         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1432         conversion of gdb_datadir.
1433         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1434         remove not needed c_str ().
1435
1436 2019-09-30  Ali Tamur <tamur@google.com>
1437
1438         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1439         (dwarf2_string_attr): Likewise.
1440
1441 2019-09-30  Ali Tamur <tamur@google.com>
1442
1443         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1444         (process_full_type_unit): Likewise.
1445         (dump_die_shallow): Likewise.
1446         (cu_debug_loc_section): Likewise.
1447
1448 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1449
1450         * minsyms.c (compare_minimal_symbols): Rename to...
1451         (minimal_symbol_is_less_than): ...this, and adjust to STL
1452         conventions (return bool, take arguments as references)
1453         (minimal_symbol_reader::install): Call std::sort instead
1454         of qsort.
1455
1456 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1457
1458         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1459         hash and why.
1460         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1461         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1462
1463 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1464
1465         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1466         * psympriv.h (add_psymbol_to_list): Move comment here and update
1467         it.
1468
1469 2019-09-29  Tom de Vries  <tdevries@suse.de>
1470
1471         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1472         Use $tmpdir/$(basename "$output_file").dwz instead of
1473         "${output_file}.dwz".
1474
1475 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1476
1477         PR gdb/25045
1478         * hppa-linux-nat.c: Include gdbarch.h.
1479
1480 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1481
1482         * blockframe.c (find_pc_partial_function): Change return type to bool.
1483         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1484         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1485         (stub_gnu_ifunc_resolve_name): Likewise.
1486         * symtab.c (compare_filenames_for_search): Likewise.
1487         (compare_glob_filenames_for_search): Likewise.
1488         (matching_obj_sections): Likewise.
1489         (symbol_matches_domain): Likewise.
1490         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1491         (find_line_pc): Change return type to bool.
1492         (find_line_pc_range): Likewise.
1493         (producer_is_realview): Likewise.
1494         * symtab.h (symbol_matches_domain): Likewise.
1495         (find_pc_partial_function): Likewise.
1496         (find_pc_line_pc_range): Likewise.
1497         (in_gnu_ifunc_stub): Likewise.
1498         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1499         (find_line_pc): Likewise.
1500         (find_line_pc_range): Likewise.
1501         (matching_obj_sections): Likewise.
1502         (find_line_symtab): Change out parameter to bool.
1503         (producer_is_realview): Change return type to bool.
1504         (compare_filenames_for_search): Likewise.
1505         (compare_glob_filenames_for_search): Likewise.
1506
1507 2019-09-26  Tom Tromey  <tom@tromey.com>
1508
1509         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1510         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1511         * gdb_usleep.h: Remove.
1512         * gdb_usleep.c: Remove.
1513         * utils.c: Don't include gdb_usleep.h.
1514
1515 2019-09-26  Tom Tromey  <tromey@adacore.com>
1516
1517         * python/py-type.c (type_to_type_object): Call check_typedef
1518         for stub types.
1519
1520 2019-09-26  Tom Tromey  <tom@tromey.com>
1521
1522         * utils.h (initialize_utils): Don't declare.
1523         * top.c (gdb_init): Don't call initialize_utils.
1524         * utils.c (initialize_utils): Remove.  Move contents...
1525         (_initialize_utils): ... here.
1526
1527 2019-09-25  Tom Tromey  <tom@tromey.com>
1528
1529         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1530         * utils.h (make_hex_string): Don't declare.
1531         * utils.c (make_hex_string): Remove.
1532
1533 2019-09-24  Tom de Vries  <tdevries@suse.de>
1534
1535         PR gdb/23815
1536         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1537         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1538
1539 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1540
1541         * NEWS: Mention new simulator port for PRU.
1542
1543 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1544
1545         * ada-exp.y (write_object_remaining): Update.
1546         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1547         and eliminate the static buffer.
1548         (ada_decode_symbol): Update.
1549         (ada_la_decode): Update.
1550         (ada_sniff_from_mangled_name): Update.
1551         (is_valid_name_for_wild_match): Update.
1552         (ada_lookup_name_info::matches): Update and simplify.
1553         (name_matches_regex): Update.
1554         (ada_add_global_exceptions): Update.
1555         * ada-lang.h (ada_decode): Update signature.
1556         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1557         * dwarf-index-write.c (debug_names::insert): Update.
1558
1559 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1560
1561         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1562         formatting.
1563
1564 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1565
1566         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1567         Change "nonzero" to "true" in documentation.
1568
1569 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1570
1571         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1572         (_initialize_darwin_solib): Don't set
1573         darwin_so_ops.lookup_lib_global_symbol.
1574         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1575         set_gdbarch_iterate_over_objfiles_in_search_order.
1576         (elf_lookup_lib_symbol): Rename to...
1577         (svr4_iterate_over_objfiles_in_search_order): this, and update
1578         to iterate semantics.
1579         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1580         * solib.c (solib_global_lookup): Remove.
1581         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1582         (solib_global_lookup): Remove.
1583         * symtab.c (lookup_global_or_static_symbol): Remove call to
1584         solib_global_lookup.
1585
1586 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1587
1588         * NEWS: Move entries about default MI version now being
1589         version 3, and about the GDB/MI fix for multi-location
1590         breakpoints to the "since GDB 8.3" section.
1591
1592 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1593
1594         GDB 8.3.1 released.
1595
1596 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1597
1598         * NEWS: Mention that Cell/B.E. debugging support was removed.
1599         * MAINTAINERS: Remove spu target.
1600
1601         * config/djgpp/fnchange.lst: Remove entries for removed files.
1602
1603         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1604         spu-multiarch.o, and spu-tdep.o.
1605         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1606         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1607         spu-multiarch.c, and spu-tdep.c.
1608         * spu-linux-nat.c: Remove file.
1609         * spu-multiarch.c: Remove file.
1610         * spu-tdep.c: Remove file.
1611         * spu-tdep.h: Remove file.
1612         * solib-spu.c: Remove file.
1613         * solib-spu.h: Remove file.
1614
1615         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1616         * configure.nat (spu-linux): Remove.
1617         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1618         solib-multiarch.o from gdb_target_obs.
1619         (spu*-*-*): Remove.
1620
1621         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1622         feature flag.
1623         (ppc_linux_no_features): Update.
1624         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1625         Cell/B.E. support.
1626         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1627         (tdesc_powerpc_cell64l): Likewise.
1628         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1629         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1630         Cell/B.E. support.
1631         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1632         Do not include "features/rs6000/powerpc-cell32l.c" or
1633         "features/rs6000/powerpc-cell64l.c".
1634         (ppc_linux_spu_section): Remove.
1635         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1636         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1637         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1638         (ppc_linux_spe_context_lookup): Remove.
1639         (ppc_linux_spe_context_inferior_created): Remove.
1640         (ppc_linux_spe_context_solib_loaded): Remove.
1641         (ppc_linux_spe_context_solib_unloaded): Remove.
1642         (ppc_linux_spe_context): Remove.
1643         (struct ppu2spu_cache): Remove.
1644         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1645         (struct ppu2spu_data): Remove.
1646         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1647         ppu2spu_unwind): Remove.
1648         (ppc_linux_init_abi): Remove Cell/B.E. support.
1649         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1650
1651         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1652         (rs6000/powerpc-cell64l-expedite): Likewise
1653         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1654         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1655         rs6000/powerpc-cell64l.xml.
1656         * features/rs6000/powerpc-cell32l.xml: Remove.
1657         * features/rs6000/powerpc-cell64l.xml: Likewise.
1658         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1659         * features/rs6000/powerpc-cell64l.c: Likewise.
1660         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1661         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1662         * regformats/reg-spu.dat: Remove.
1663
1664         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1665         * corelow.c (struct spuid_list): Remove.
1666         (add_to_spuid_list): Remove.
1667         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1668         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1669         (remote_protocol_features): Remove associated entries.
1670         (_initialize_remote): No longer initialize them.
1671         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1672         * linux-nat.c (SPUFS_MAGIC): Remove.
1673         (linux_proc_xfer_spu): Remove.
1674         (spu_enumerate_spu_ids): Remove.
1675         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1676         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1677         (linux_make_corefile_notes): No longer call it.
1678
1679         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1680         (cooked_write_test): Likewise.
1681
1682 2019-09-20  Tom Tromey  <tom@tromey.com>
1683
1684         * NEWS: Mention case-sensitivity of TUI commands.
1685         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1686         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1687         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1688
1689 2019-09-20  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-source.c (tui_source_window::set_contents): Use
1692         make_unique_xstrdup.
1693         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1694         make_unique_xstrdup.
1695
1696 2019-09-20  Tom Tromey  <tom@tromey.com>
1697
1698         * tui/tui-data.c: Remove separator comments.
1699         * tui/tui-layout.c: Remove separator comments.
1700         * tui/tui-win.c: Remove separator comments.
1701         * tui/tui-wingeneral.c: Remove separator comments.
1702
1703 2019-09-20  Tom Tromey  <tom@tromey.com>
1704
1705         * tui/tui.h (strcat_to_buf): Don't declare.
1706         * tui/tui.c (strcat_to_buf): Remove.
1707
1708 2019-09-20  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1711         from "fullname".
1712         * tui/tui-source.c (tui_source_window::set_contents)
1713         (tui_source_window::location_matches_p)
1714         (tui_source_window::maybe_update): Update.
1715
1716 2019-09-20  Tom Tromey  <tom@tromey.com>
1717
1718         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1719         Update.
1720         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1721         prefix.
1722         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1723         (tui_data_window::line_from_reg_element_no)
1724         (tui_data_window::first_reg_element_no_inline)
1725         (tui_data_window::show_registers)
1726         (tui_data_window::show_register_group)
1727         (tui_data_window::display_registers_from)
1728         (tui_data_window::display_registers_from_line)
1729         (tui_data_window::first_data_item_displayed)
1730         (tui_data_window::delete_data_content_windows)
1731         (tui_data_window::erase_data_content)
1732         (tui_data_window::do_scroll_vertical)
1733         (tui_data_window::refresh_window)
1734         (tui_data_window::check_register_values): Update.
1735
1736 2019-09-20  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1739         (struct tui_locator_window) <full_name, proc_name>: Now
1740         std::string.
1741         * tui/tui-stack.c (tui_locator_window::make_status_line)
1742         (tui_locator_window::set_locator_fullname)
1743         (tui_locator_window::set_locator_info): Update.
1744         * tui/tui-source.c (tui_source_window::set_contents)
1745         (tui_source_window::showing_source_p): Update.
1746
1747 2019-09-20  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1750         Don't call tui_locator_win_info_ptr.
1751
1752 2019-09-20  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1755
1756 2019-09-20  Tom Tromey  <tom@tromey.com>
1757
1758         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1759         height for locator.
1760         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1761         * tui/tui-layout.c (show_source_disasm_command, show_data)
1762         (show_source_or_disasm_and_command): Use 1 as height for locator.
1763
1764 2019-09-20  Tom Tromey  <tom@tromey.com>
1765
1766         * tui/tui.c (tui_enable): Update.
1767         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1768         Update.
1769         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1770         Update.
1771         * tui/tui-data.c (win_resized): Now bool.
1772         (tui_win_resized): Return bool.
1773         (tui_set_win_resized_to): Accept a bool.
1774
1775 2019-09-20  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1778         Change type of "refresh_values_only".
1779         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1780         type of "refresh_values_only".
1781
1782 2019-09-20  Tom Tromey  <tom@tromey.com>
1783
1784         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1785         std::string.
1786         (tui_disassemble): Add "pos" parameter.
1787         (tui_disasm_window::set_contents): Simplify.
1788
1789 2019-09-20  Tom Tromey  <tom@tromey.com>
1790
1791         * tui/tui-winsource.h (struct tui_source_window_base)
1792         <show_source_content>: Now private.
1793         * tui/tui-winsource.c
1794         (tui_source_window_base::show_source_content): Don't handle empty
1795         content case.
1796
1797 2019-09-20  Tom Tromey  <tom@tromey.com>
1798
1799         * tui/tui-layout.c (show_source_disasm_command)
1800         (show_source_or_disasm_and_command): Don't call
1801         show_source_content.
1802
1803 2019-09-20  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1806         Declare.
1807         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1808         from tui_make_status_line.
1809         (tui_locator_window::rerender): Update.
1810
1811 2019-09-20  Tom Tromey  <tom@tromey.com>
1812
1813         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1814         (tui_locator_window::rerender): Update.
1815
1816 2019-09-20  Tom Tromey  <tom@tromey.com>
1817
1818         * tui/tui-winsource.h (struct tui_source_window_base)
1819         <~tui_source_window_base>: Don't declare.
1820         <fullname>: Remove.
1821         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1822         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1823         member.
1824         * tui/tui-source.c (tui_source_window::set_contents): Update.
1825         (tui_source_window::location_matches_p)
1826         (tui_source_window::maybe_update): Update.
1827
1828 2019-09-20  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui-winsource.h (~tui_source_element): Remove.
1831         (tui_source_element): Update.
1832         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1833         * tui/tui-winsource.c (tui_show_source_line): Update.
1834         * tui/tui-source.c (tui_source_window::set_contents): Update.
1835         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1836
1837 2019-09-20  Tom Tromey  <tom@tromey.com>
1838
1839         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1840         declare.
1841         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1842         tui_clear_source_windows_detail.
1843         * tui/tui-winsource.h (struct tui_source_window_base)
1844         <clear_detail>: Don't declare.
1845         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1846         Remove.
1847         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1848
1849 2019-09-20  Tom Tromey  <tromey@adacore.com>
1850
1851         PR ada/24919:
1852         * block.c (contained_in): Fix final return value.
1853
1854 2019-09-20  Alan Modra  <amodra@gmail.com>
1855
1856         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1857         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1858         (read_indirect_string_from_dwz): Use bfd accessor.
1859         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1860         * machoread.c (macho_symfile_read_all_oso): Likewise.
1861         * solib.c (solib_bfd_open): Likewise.
1862
1863 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1864
1865         * eval.c: Move declaration of overload_resolution to...
1866         * value.h: ...here.
1867
1868 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1869
1870         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1871         * arm-linux-tdep.c: Likewise.
1872         * arm-nbsd-nat.c: Likewise.
1873         * arm-tdep.h: Declare arm_apcs_32.
1874         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1875
1876 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1877
1878         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1879         * dwarf2read.h: Declare dwarf_always_disassemble.
1880
1881 2019-09-19  Tom de Vries  <tdevries@suse.de>
1882
1883         PR gdb/25009
1884         * source-cache.c (source_cache::ensure): Catch exception thrown during
1885         construction of the highlighter.
1886
1887 2019-09-18  Alan Modra  <amodra@gmail.com>
1888
1889         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1890         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1891         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1892         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1893         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1894         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1895         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1896         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1897         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1898         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1899         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1900         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1901         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1902         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1903         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1904         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1905         * mi/mi-interp.c: Update throughout for bfd section macro and
1906         function changes.
1907         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1908         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1909
1910 2019-09-18  Tom Tromey  <tom@tromey.com>
1911
1912         * NEWS: Add entry.
1913         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1914         call rl_initialize.
1915         (tui_enable): Do not call rl_initialize.
1916
1917 2019-09-18  Christian Groessler  <chris@groessler.org>
1918
1919         * alpha-linux-nat.c: Include gdbarch.h.
1920
1921 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1922
1923         * ui-file.c: Include cli/cli-style.h.
1924         (term_cli_styling): Remove cli_styling declaration.
1925
1926 2019-09-18  Alan Modra  <amodra@gmail.com>
1927
1928         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1929         to bfd_asymbol_section.
1930
1931 2019-09-18  Alan Modra  <amodra@gmail.com>
1932
1933         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1934         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1935         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1936
1937 2019-09-18  Alan Modra  <amodra@gmail.com>
1938
1939         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1940         * spu-linux-nat.c (spu_bfd_open): Likewise.
1941
1942 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1943
1944         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1945         to bool to match definition in dwarf2read.c.
1946
1947 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1948
1949         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1950         (print_signatures): Likewise.
1951         (trust_pad_over_xvs): Likewise.
1952         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1953         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1954         * arm-linux-nat.c (arm_apcs_32): Likewise.
1955         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1956         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1957         * arm-tdep.c (arm_debug): Likewise.
1958         (arm_apcs_32): Likewise.
1959         * auto-load.c (debug_auto_load): Likewise.
1960         (auto_load_gdb_scripts): Likewise.
1961         (global_auto_load): Likewise.
1962         (auto_load_local_gdbinit): Likewise.
1963         (auto_load_local_gdbinit_loaded): Likewise.
1964         * auto-load.h (global_auto_load): Likewise.
1965         (auto_load_local_gdbinit): Likewise.
1966         (auto_load_local_gdbinit_loaded): Likewise.
1967         * breakpoint.c (disconnected_dprintf): Likewise.
1968         (breakpoint_proceeded): Likewise.
1969         (automatic_hardware_breakpoints): Likewise.
1970         (always_inserted_mode): Likewise.
1971         (target_exact_watchpoints): Likewise.
1972         (_initialize_breakpoint): Update.
1973         * breakpoint.h (target_exact_watchpoints): Change to bool.
1974         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1975         * cli/cli-cmds.c (trace_commands): Likewise.
1976         * cli/cli-cmds.h (trace_commands): Likewise.
1977         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1978         to bool*.
1979         * cli/cli-logging.c (logging_overwrite): Change to bool.
1980         (logging_redirect): Likewise.
1981         (debug_redirect): Likewise.
1982         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1983         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1984         to bool.
1985         <boolean_option_def>: Update.
1986         (struct flag_option_def): Change default type of Context to bool
1987         from int.
1988         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1989         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1990         (get_setshow_command_value_string): Likewise.
1991         * cli/cli-style.c (cli_styling): Change to bool.
1992         (source_styling): Likewise.
1993         * cli/cli-style.h (source_styling): Likewise.
1994         (cli_styling): Likewise.
1995         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1996         to bool.
1997         * command.h (var_types): Update comment.
1998         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1999         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2000         bool.
2001         (debug_compile_cplus_scopes): Likewise.
2002         * compile/compile-internal.h (compile_debug): Likewise.
2003         * compile/compile.c (compile_debug): Likewise.
2004         (struct compile_options) <raw>: Likewise.
2005         * cp-support.c (catch_demangler_crashes): Likewise.
2006         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2007         (usr_cmd_cris_dwarf2_cfi): Likewise.
2008         * csky-tdep.c (csky_debug): Likewise.
2009         * darwin-nat.c (enable_mach_exceptions): Likewise.
2010         * dcache.c (dcache_enabled_p): Likewise.
2011         * defs.h (info_verbose): Likewise.
2012         * demangle.c (demangle): Likewise.
2013         (asm_demangle): Likewise.
2014         * dwarf-index-cache.c (debug_index_cache): Likewise.
2015         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2016         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2017         * dwarf2read.c (check_physname): Likewise.
2018         (use_deprecated_index_sections): Likewise.
2019         (dwarf_always_disassemble): Likewise.
2020         * eval.c (overload_resolution): Likewise.
2021         * event-top.c (set_editing_cmd_var): Likewise.
2022         (exec_done_display_p): Likewise.
2023         * event-top.h (set_editing_cmd_var): Likewise.
2024         (exec_done_display_p): Likewise.
2025         * exec.c (write_files): Likewise.
2026         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2027         (debug_fbsd_nat): Likewise.
2028         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2029         Likewise.
2030         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2031         <backtrace_past_entry> Likewise.
2032         * gdb-demangle.h (demangle): Likewise.
2033         (asm_demangle): Likewise.
2034         * gdb_bfd.c (bfd_sharing): Likewise.
2035         * gdbcore.h (write_files): Likewise.
2036         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2037         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2038         * gdbthread.h (print_thread_events): Likewise.
2039         * gdbtypes.c (opaque_type_resolution): Likewise.
2040         (strict_type_checking): Likewise.
2041         * gnu-nat.c (gnu_debug_flag): Likewise.
2042         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2043         * guile/scm-param.c (pascm_variable): Add boolval.
2044         (add_setshow_generic): Update.
2045         (pascm_param_value): Update.
2046         (pascm_set_param_value_x): Update.
2047         * hppa-tdep.c (hppa_debug): Change to bool..
2048         * infcall.c (may_call_functions_p): Likewise.
2049         (coerce_float_to_double_p): Likewise.
2050         (unwind_on_signal_p): Likewise.
2051         (unwind_on_terminating_exception_p): Likewise.
2052         * infcmd.c (startup_with_shell): Likewise.
2053         * inferior.c (print_inferior_events): Likewise.
2054         * inferior.h (startup_with_shell): Likewise.
2055         (print_inferior_events): Likewise.
2056         * infrun.c (step_stop_if_no_debug): Likewise.
2057         (detach_fork): Likewise.
2058         (debug_displaced): Likewise.
2059         (disable_randomization): Likewise.
2060         (non_stop): Likewise.
2061         (non_stop_1): Likewise.
2062         (observer_mode): Likewise.
2063         (observer_mode_1): Likewise.
2064         (set_observer_mode): Update.
2065         (sched_multi): Change to bool.
2066         * infrun.h (debug_displaced): Likewise.
2067         (sched_multi): Likewise.
2068         (step_stop_if_no_debug): Likewise.
2069         (non_stop): Likewise.
2070         (disable_randomization): Likewise.
2071         * linux-tdep.c (use_coredump_filter): Likewise.
2072         (dump_excluded_mappings): Likewise.
2073         * linux-thread-db.c (auto_load_thread_db): Likewise.
2074         (check_thread_db_on_load): Likewise.
2075         * main.c (captured_main_1): Update.
2076         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2077         xx2_opt, boolean_opt>: Change to bool.
2078         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2079         * maint.c (maintenance_profile_p): Likewise.
2080         (per_command_time): Likewise.
2081         (per_command_space): Likewise.
2082         (per_command_symtab): Likewise.
2083         * memattr.c (inaccessible_by_default): Likewise.
2084         * mi/mi-main.c (mi_async): Likewise.
2085         (mi_async_1): Likewise.
2086         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2087         * nat/fork-inferior.h (startup_with_shell): Likewise.
2088         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2089         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2090         * nios2-tdep.c (nios2_debug): Likewise.
2091         * or1k-tdep.c (or1k_debug): Likewise.
2092         * parse.c (parser_debug): Likewise.
2093         * parser-defs.h (parser_debug): Likewise.
2094         * printcmd.c (print_symbol_filename): Likewise.
2095         * proc-api.c (procfs_trace): Likewise.
2096         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2097         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2098         (set_parameter_value): Update.
2099         (add_setshow_generic): Update.
2100         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2101         to bool*.
2102         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2103         int*.
2104         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2105         * record-btrace.c (record_btrace_target::store_registers): Update.
2106         * record-full.c (record_full_memory_query): Change to bool.
2107         (record_full_stop_at_limit): Likewise.
2108         * record-full.h (record_full_memory_query): Likewise.
2109         * remote-notif.c (notif_debug): Likewise.
2110         * remote-notif.h (notif_debug): Likewise.
2111         * remote.c (use_range_stepping): Likewise.
2112         (interrupt_on_connect): Likewise.
2113         (remote_break): Likewise.
2114         * ser-tcp.c (tcp_auto_retry): Likewise.
2115         * ser-unix.c (serial_hwflow): Likewise.
2116         * skip.c (debug_skip): Likewise.
2117         * solib-aix.c (solib_aix_debug): Likewise.
2118         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2119         (spu_auto_flush_cache_p): Likewise.
2120         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2121         Likewise.
2122         (struct info_print_options) <quiet>: Likewise.
2123         * symfile-debug.c (debug_symfile): Likewise.
2124         * symfile.c (auto_solib_add): Likewise.
2125         (separate_debug_file_debug): Likewise.
2126         * symfile.h (auto_solib_add): Likewise.
2127         (separate_debug_file_debug): Likewise.
2128         * symtab.c (basenames_may_differ): Likewise.
2129         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2130         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2131         (struct info_types_options) <quiet>: Likewise.
2132         * symtab.h (demangle): Likewise.
2133         (basenames_may_differ): Likewise.
2134         * target-dcache.c (stack_cache_enabled_1): Likewise.
2135         (code_cache_enabled_1): Likewise.
2136         * target.c (trust_readonly): Likewise.
2137         (may_write_registers): Likewise.
2138         (may_write_memory): Likewise.
2139         (may_insert_breakpoints): Likewise.
2140         (may_insert_tracepoints): Likewise.
2141         (may_insert_fast_tracepoints): Likewise.
2142         (may_stop): Likewise.
2143         (auto_connect_native_target): Likewise.
2144         (target_stop_and_wait): Update.
2145         (target_async_permitted): Change to bool.
2146         (target_async_permitted_1): Likewise.
2147         (may_write_registers_1): Likewise.
2148         (may_write_memory_1): Likewise.
2149         (may_insert_breakpoints_1): Likewise.
2150         (may_insert_tracepoints_1): Likewise.
2151         (may_insert_fast_tracepoints_1): Likewise.
2152         (may_stop_1): Likewise.
2153         * target.h (target_async_permitted): Likewise.
2154         (may_write_registers): Likewise.
2155         (may_write_memory): Likewise.
2156         (may_insert_breakpoints): Likewise.
2157         (may_insert_tracepoints): Likewise.
2158         (may_insert_fast_tracepoints): Likewise.
2159         (may_stop): Likewise.
2160         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2161         (make_thread_apply_all_options_def_group): Change argument from int*
2162         to bool*.
2163         (thread_apply_all_command): Update.
2164         (print_thread_events): Change to bool.
2165         * top.c (confirm): Likewise.
2166         (command_editing_p): Likewise.
2167         (history_expansion_p): Likewise.
2168         (write_history_p): Likewise.
2169         (info_verbose): Likewise.
2170         * top.h (confirm): Likewise.
2171         (history_expansion_p): Likewise.
2172         * tracepoint.c (disconnected_tracing): Likewise.
2173         (circular_trace_buffer): Likewise.
2174         * typeprint.c (print_methods): Likewise.
2175         (print_typedefs): Likewise.
2176         * utils.c (debug_timestamp): Likewise.
2177         (sevenbit_strings): Likewise.
2178         (pagination_enabled): Likewise.
2179         * utils.h (sevenbit_strings): Likewise.
2180         (pagination_enabled): Likewise.
2181         * valops.c (overload_resolution): Likewise.
2182         * valprint.h (struct value_print_options) <prettyformat_arrays,
2183         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2184         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2185         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2186         Likewise.
2187         * windows-nat.c (new_console): Likewise.
2188         (cygwin_exceptions): Likewise.
2189         (new_group): Likewise.
2190         (debug_exec): Likewise.
2191         (debug_events): Likewise.
2192         (debug_memory): Likewise.
2193         (debug_exceptions): Likewise.
2194         (useshell): Likewise.
2195         * windows-tdep.c (maint_display_all_tib): Likewise.
2196         * xml-support.c (debug_xml): Likewise.
2197
2198 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2199
2200         * source.c (prepare_path_for_appending): New function.
2201         (openp): Make use of new function.
2202         (find_and_open_source): Search for the compilation directory and
2203         source file as a relative path beneath the directory search path.
2204
2205 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2206
2207         * source-cache.c (source_cache::get_line_charpos): Catch
2208         exceptions and return false, this matches the behaviour documented
2209         in the header file.
2210
2211 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2212
2213         * ada-tasks.c (info_task): Remove quoting of the task's name.
2214
2215 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2216
2217         * symfile.c (auto_solib_add): Replace comment with a reference
2218         to the header file.
2219
2220 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2221
2222         * NEWS: Mention that gdb can now be compiled with Python 3
2223         on Windows.
2224
2225 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2226
2227         * maint.c (maint_print_section_data::maint_print_section_data):
2228         Force use of 'float log10 (float)' by casting the argument to
2229         float.
2230
2231 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2232
2233         * maint.c: Add 'cmath' include.
2234         (struct maint_print_section_data): New structure.
2235         (print_section_index): New function.
2236         (print_bfd_section_info): Add header comment, small whitespace
2237         cleanup, and update to call new print_section_index function.
2238         (print_objfile_section_info): Likewise.
2239         (maint_obj_section_from_bfd_section): New function.
2240         (print_bfd_section_info_maybe_relocated): New function.
2241         (maintenance_info_sections): Add header comment, always use
2242         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2243
2244 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2245
2246         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2247         inner scope, add check that the objfile has psymtabs before
2248         checking psymtabs_addrmap.
2249         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2250
2251 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2252
2253         * NEWS: Announce that Ada task names are now shown at more places,
2254         and between quotes (except in info task output).
2255         * gdb/ada-tasks.c (task_to_str): New function.
2256         (display_current_task_id): Call task_to_str.
2257         (task_command_1): Likewise.
2258         (print_ada_task_info): In non-mi mode, Properly align headers and data
2259         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2260
2261 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2262
2263         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2264         prstatus.pr_lwp.pr_info instead of making it up.
2265
2266 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2267
2268         * auto-load.c (auto_load_expand_dir_vars): Update.
2269         * defs.h (gdb_datadir): Change to std::string.
2270         (python_libdir): Likewise.
2271         (relocate_gdb_directory): Change return type to std::string.
2272         * guile/guile.c (gdbscm_data_directory): Update.
2273         (initialize_scheme_side): Update.
2274         * jit.c (jit_reader_dir): Change to std::string.
2275         (jit_reader_load_command): Update.
2276         * main.c (gdb_datadir): Change to std::string.
2277         (python_libdir): Likewise.
2278         (set_gdb_data_directory): Update.
2279         (relocate_path): Change to return std::string.
2280         (relocate_gdb_directory): Change to return std::string.
2281         (relocate_gdbinit_path_maybe_in_datadir): Update.
2282         (captured_main_1): Update.
2283         * python/python.c (do_start_initialization): Update.
2284         * top.c (show_gdb_datadir): Update.
2285         * xml-syscall.c (xml_init_syscalls_info): Update.
2286         (init_syscalls_info): Update.
2287
2288 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2289
2290         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2291         out of get_init_files.
2292         (get_init_files): Update.
2293
2294 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2295
2296         * main.c (get_init_files): Change to use std::string.
2297         (captured_main_1): Update.
2298         (print_gdb_help): Update.
2299
2300 2019-09-11  Ali Tamur  <tamur@google.com>
2301
2302         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2303         implementation.
2304
2305 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2306
2307         * dbxread.c (read_dbx_symtab): Update.
2308         * dwarf2read.c (load_partial_dies): Update.
2309         * mdebugread.c (parse_partial_symbols): Update.
2310         (handle_psymbol_enumerators): Update.
2311         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2312         * psymtab.c (add_psymbol_to_bcache): Likewise.
2313         (add_psymbol_to_list): Likewise.
2314         * symtab.c (symbol_set_names): Likewise.
2315         * symtab.h (symbol_set_names): Likewise.
2316         * xcoffread.c (scan_xcoff_symtab): Update.
2317
2318 2019-09-11  Tom Tromey  <tom@tromey.com>
2319
2320         * symfile-mem.c (symbol_file_add_from_memory): Use
2321         bfd_set_filename.
2322         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2323         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2324
2325 2019-09-10  Tom Tromey  <tromey@adacore.com>
2326
2327         * dwarf-index-write.c (write_psymbols): Extend error message.
2328         (debug_names::insert): Add Ada code.
2329         (debug_names::write_psymbols): Remove Ada check.
2330         (debug_names) <m_string_obstack>: New member.
2331         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2332         (gdb_index_symbol_name_matcher::matches): Remove.
2333         (mapped_index_base::find_name_components_bounds): Add "lang"
2334         parameter.
2335         (mapped_index_base::build_name_components): Also split names
2336         according to Ada syntax.
2337         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2338         type of "match_callback".
2339         (check_match, check_find_bounds_finds)
2340         (dw2_expand_symtabs_matching): Update.
2341         (dw2_debug_names_iterator): Add new constructor.
2342         (dw2_debug_names_map_matching_symbols): New function.
2343         (dw2_debug_names_expand_symtabs_matching): Update.
2344         (dwarf2_debug_names_functions): Use
2345         dw2_debug_names_map_matching_symbols.
2346
2347 2019-09-10  Tom Tromey  <tromey@adacore.com>
2348
2349         * dwarf2read.c (dw2_get_file_names_reader): Add the
2350         CU's file name to the results.
2351
2352 2019-09-10  Tom Tromey  <tromey@adacore.com>
2353
2354         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2355         map_matching_symbols.  Update.
2356         * dwarf2read.c (dw2_map_matching_symbols): Update.
2357         * psymtab.c (match_partial_symbol): Change type; update.
2358         (psym_map_matching_symbols): Likewise.
2359         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2360         type; update.
2361         * symfile.h (struct quick_symbol_functions)
2362         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2363         Remove "match".
2364
2365 2019-09-10  Tom Tromey  <tromey@adacore.com>
2366
2367         * psymtab.c (map_block): Remove.
2368         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2369         * symtab.c (iterate_over_symbols_terminated): New function.
2370         * symtab.c (iterate_over_symbols_terminated): Declare.
2371
2372 2019-09-10  Tom Tromey  <tromey@adacore.com>
2373
2374         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2375         * language.h (struct language_defn) <la_iterate_over_symbols>:
2376         Return bool.
2377         * symtab.c (iterate_over_symbols): Return bool.
2378         * symtab.h (iterate_over_symbols): Return bool.
2379
2380 2019-09-10  Tom Tromey  <tromey@adacore.com>
2381
2382         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2383         (add_nonlocal_symbols): Update.
2384         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2385         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2386         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2387         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2388         Change type of "callback".  Remove "data".
2389
2390
2391 2019-09-09  Ali Tamur  <tamur@google.com>
2392
2393         * dwarf2read.c (comp_unit_head): Update comment.
2394         (dwarf2_dwo_name): New function declaration.
2395         (dwarf_unit_type_name): New function declaration.
2396         (read_comp_unit_head): Add support for new compilation units,
2397         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2398         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2399         (currently named as "signature") in their header. Also clarify error
2400         messages.
2401         (lookup_dwo_id): New function. Returns the dwo id of the given
2402         compile unit.
2403         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2404         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2405         functions.
2406         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2407         (dwarf2_dwo_name): Get the dwo name if present.
2408         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2409         purposes.
2410
2411 2019-09-09  Tom Tromey  <tom@tromey.com>
2412
2413         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2414
2415 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2416
2417         * python/python.c (do_start_initialization): Make progname_copy static,
2418         to avoid a leak report.
2419
2420 2019-09-08  Tom Tromey  <tom@tromey.com>
2421
2422         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2423
2424 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2425
2426         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2427         Change type to gdb::optional<block_enum>.
2428         (dw2_symtab_iter_init): Change block_index parameter type
2429         to gdb::optional<block_enum>.
2430         (dw2_lookup_symbol): Change block_index parameter
2431         type to block_enum.c
2432         (dw2_debug_names_lookup_symbol): Likewise.
2433         * psymtab.c (psym_lookup_symbol): Likewise.
2434         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2435         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2436         Likewise.
2437
2438 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2439
2440         * defs.h (relocate_gdb_directory): Change int to bool in
2441         signature and rename flag to relocatable.
2442         * main.c (relocate_path): Likewise.
2443         (relocate_gdb_directory): Likewise.
2444
2445 2019-09-06  Alan Modra  <amodra@gmail.com>
2446
2447         * coffread.c (coff_symfile_read): Constify filename variable.
2448         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2449         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2450         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2451         * solib.c (reload_shared_libraries_1): Likewise.
2452         * symfile.c (reread_symbols): Likewise.
2453         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2454         * solib-darwin.c (darwin_bfd_open): Likewise.
2455         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2456
2457 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2458
2459         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2460         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2461
2462 2019-09-03  Tom Tromey  <tromey@adacore.com>
2463
2464         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2465         types.
2466         (has_negatives): Unbias a range type bound.
2467         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2468         * gdbtypes.c (operator==): Handle new field.
2469         (create_range_type): Add "bias" parameter.
2470         (create_static_range_type, resolve_dynamic_range): Update.
2471         * gdbtypes.h (struct range_bounds) <bias>: New member.
2472         (create_range_type): Add bias parameter.
2473         * printcmd.c (print_scalar_formatted): Unbias range types.
2474         * value.c (unpack_long): Unbias range types.
2475         (pack_long): Bias range types.
2476
2477 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2478
2479         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2480         probe arguments.
2481
2482 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2483
2484         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2485         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2486         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2487         (compile_probe_arg): Likewise.
2488         * probe.h (get_argument_count): Likewise.
2489         * solib-svr4.c (solib_event_probe_action): Likewise.
2490         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2491
2492 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2493
2494         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2495         code to here...
2496         (svr4_create_solib_event_breakpoints): ...from here.
2497
2498 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2499
2500         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2501         suffix from warning message.
2502
2503 2019-08-30  Tom Tromey  <tom@tromey.com>
2504
2505         * tui/tui-winsource.h (struct tui_source_window_base)
2506         <refresh_all>: Don't declare.
2507         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2508         Remove.
2509         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2510         tui_show_locator_content.
2511         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2512         declare.
2513         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2514         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2515         declare.
2516
2517 2019-08-30  Tom Tromey  <tom@tromey.com>
2518
2519         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2520
2521 2019-08-30  Tom Tromey  <tom@tromey.com>
2522
2523         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2524         Remove unnecessary forward declarations.
2525
2526 2019-08-30  Tom Tromey  <tom@tromey.com>
2527
2528         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2529         rerender.
2530         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2531         tui_show_locator_content.
2532
2533 2019-08-30  Tom Tromey  <tom@tromey.com>
2534
2535         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2536         (tui_locator_window::rerender): Rewrite using body of previous
2537         tui_show_locator_content.
2538
2539 2019-08-30  Tom Tromey  <tom@tromey.com>
2540
2541         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2542         set_locator_fullname>: New methods.
2543         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2544         Rename from tui_set_locator_fullname.
2545         (tui_locator_window::set_locator_info): Rename from
2546         tui_set_locator_info.  Return bool.
2547         (tui_update_locator_fullname, tui_show_frame_info): Update.
2548
2549 2019-08-30  Tom Tromey  <tom@tromey.com>
2550
2551         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2552
2553 2019-08-30  Tom Tromey  <tom@tromey.com>
2554
2555         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2556         call touchwin.
2557
2558 2019-08-30  Tom Tromey  <tom@tromey.com>
2559
2560         * tui/tui-wingeneral.c (box_win): Assume win_info and
2561         win_info->handle cannot be NULL.
2562
2563 2019-08-30  Tom Tromey  <tom@tromey.com>
2564
2565         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2566         refresh_window>: Declare.
2567         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2568         resize.
2569         (tui_data_item_window::rerender): Rename from
2570         tui_display_register.
2571         (tui_data_item_window::refresh_window): New method.
2572         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2573         no-op.
2574
2575 2019-08-30  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2578         regs_column_count, current_group>: Move later.  Now private.
2579         <get_current_group>: New method.
2580         * tui/tui-regs.c (tui_reg_command): Update.
2581         * tui/tui-layout.c (tui_set_layout): Update.
2582
2583 2019-08-30  Tom Tromey  <tom@tromey.com>
2584
2585         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2586         (tui_data_window::rerender): Don't call
2587         check_and_display_highlight_if_needed.
2588         (tui_data_window::refresh_all): Remove call to
2589         erase_data_content.
2590
2591 2019-08-30  Tom Tromey  <tom@tromey.com>
2592
2593         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2594         (tui_data_window::display_registers_from)
2595         (tui_data_window::display_reg_element_at_line)
2596         (tui_data_window::display_registers_from_line): Remove checks of
2597         "empty".
2598
2599 2019-08-30  Tom Tromey  <tom@tromey.com>
2600
2601         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2602         Don't declare.
2603         * tui/tui-regs.c (tui_data_window::show_registers): Call
2604         rerender.
2605         (tui_data_window::rerender): Rename from display_all_data.
2606         (tui_data_window::rerender): Remove old implementation.
2607
2608 2019-08-30  Tom Tromey  <tom@tromey.com>
2609
2610         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2611         text.
2612         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2613
2614 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2615             Sergio Durigan Junior  <sergiodj@redhat.com>
2616
2617         PR win32/24284
2618         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2619
2620 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2621
2622         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2623         when searching for types.
2624
2625 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2626
2627         * f-lang.c (f_language_defn): Use f_print_typedef.
2628         * f-lang.h (f_print_typedef): Declare.
2629         * f-typeprint.c (f_print_typedef): Define.
2630
2631 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2632
2633         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2634
2635 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2636
2637         * cli/cli-utils.c (info_print_options_defs): Delete.
2638         (make_info_print_options_def_group): Delete.
2639         (extract_info_print_options): Delete.
2640         (info_print_command_completer): Delete.
2641         (info_print_args_help): Add extra parameter, and optionally
2642         include text about -n flag.
2643         * cli/cli-utils.h (struct info_print_options): Delete.
2644         (extract_info_print_options): Delete declaration.
2645         (info_print_command_completer): Delete declaration.
2646         (info_print_args_help): Add extra parameter, extend header
2647         comment.
2648         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2649         search_symbols.
2650         * stack.c (struct info_print_options): New type.
2651         (info_print_options_defs): New file scoped variable.
2652         (make_info_print_options_def_group): New static function.
2653         (info_print_command_completer): New static function.
2654         (info_locals_command): Update to use new local functions.
2655         (info_args_command): Likewise.
2656         (_initialize_stack): Add extra parameter to calls to
2657         info_print_args_help.
2658         * symtab.c (search_symbols): Add extra parameter, use this to
2659         possibly excluse non-debug symbols.
2660         (symtab_symbol_info): Add extra parameter, which is passed on to
2661         search_symbols.
2662         (struct info_print_options): New type.
2663         (info_print_options_defs): New file scoped variable.
2664         (make_info_print_options_def_group): New static function.
2665         (info_print_command_completer): New static function.
2666         (info_variables_command): Update to use local functions, and pass
2667         extra parameter through to symtab_symbol_info.
2668         (info_functions_command): Likewise.
2669         (info_types_command): Pass additional argument through to
2670         symtab_symbol_info.
2671         (rbreak_command): Pass extra argument to search_symbols.
2672         (_initialize_symtab): Add extra arguments for calls to
2673         info_print_args_help, and update help text for 'info variables',
2674         'whereis', and 'info functions' commands.
2675         * symtab.h (search_symbols): Add extra argument to declaration.
2676         * NEWS: Mention new flags.
2677
2678 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2679
2680         * symtab.c (lookup_static_symbol): Call the new function (and move
2681         it down to be next to lookup_global_symbol).
2682         (struct global_sym_lookup_data): Add block_enum member and rename to...
2683         (struct global_or_static_sym_lookup_data): ...this.
2684         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2685         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2686         (lookup_symbol_global_or_static_iterator_cb): ...this.
2687         (lookup_global_or_static_symbol): New function.
2688         (lookup_global_symbol): Call new function.
2689
2690 2019-08-26  Tom de Vries  <tdevries@suse.de>
2691
2692         PR c++/24852
2693         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2694         when pc_probe.prob == NULL.
2695
2696 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2697
2698         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2699         variable symbol_linkage to symbol_linkage_.
2700
2701 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2702
2703         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2704         represent whether the symbol is static, dynamic, or we don't
2705         know.
2706
2707 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2708
2709         * gdb/rx-tdep.c (rx_register_names): New.
2710         (rx_register_name): Delete.
2711         (rx_psw_type): Delete.
2712         (rx_fpsw_type): Delete.
2713         (rx_register_type): Delete.
2714         (rx_gdbarch_init): Convert target-descriptions.
2715         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2716         * gdb/features/Makefile: Add rx.xml.
2717         * gdb/features/rx.xml: New.
2718         * gdb/features/rx.c: Generated.
2719         * gdb/NEWS: Mention target description support.
2720
2721 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2722
2723         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2724         *slot_ptr.
2725
2726 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2727
2728         * configure.ac: Don't check for 'dlfcn.h' (moved to
2729         gdbsupport/common.m4).
2730         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2731         'gdbsupport/'.
2732         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2733         * compile/compile-c-support.c: Include
2734         'gdbsupport/gdb-dlfcn.h'.
2735         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2736         * gdb-dlfcn.c: Move to...
2737         * gdbsupport/gdb-dlfcn.c: ... here.
2738         * gdb-dlfcn.h: Move to...
2739         * gdbsupport/gdb-dlfcn.h: ... here.
2740
2741 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2742
2743         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2744         the offset field signed.
2745
2746 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2747
2748         * python/lib/gdb/__init__.py (_execute_file): New function.
2749         * python/python.c (python_run_simple_file): Call gdb._execute_file
2750         on Windows.
2751
2752 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2753
2754         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2755         all uses as this was never set to anything but a zero value.
2756
2757 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2758
2759         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2760
2761 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2762
2763         * tui/tui-data.h (tui_gen_win_info): Add an =default
2764         move constructor, required by some GCC versions.
2765
2766 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2767
2768         * go32-nat.c (go32_sysinfo): Add hygon_p.
2769
2770 2019-08-20  Tom Tromey  <tom@tromey.com>
2771
2772         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2773         line_from_reg_element_no, first_reg_element_no_inline,
2774         display_all_data, delete_data_content_windows,
2775         erase_data_content>: Now private.
2776
2777 2019-08-20  Tom Tromey  <tom@tromey.com>
2778
2779         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2780         (tui_unhighlight_win, tui_highlight_win)
2781         (tui_win_info::make_window): Update.
2782         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2783
2784 2019-08-20  Tom Tromey  <tom@tromey.com>
2785
2786         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2787         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2788         (MAX_PID_WIDTH): Move to tui-stack.c.
2789         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2790         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2791         (MAX_PID_WIDTH): Move from tui-data.h.
2792
2793 2019-08-20  Tom Tromey  <tom@tromey.com>
2794
2795         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2796         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2797         (box_win): Update.
2798         (tui_gen_win_info::make_window): Rename from tui_make_window.
2799         (tui_win_info::make_window): New method.
2800         (tui_gen_win_info::make_visible): Update.
2801         * tui/tui-source.c (tui_source_window::set_contents): Update.
2802         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2803         (tui_data_window::display_registers_from): Update.
2804         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2805         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2806         Declare.
2807         <can_box>: Remove.
2808         <title>: Remove.
2809         (struct tui_win_info) <make_window>: Declare.
2810         <can_box>: Now virtual.
2811         <title>: New member.
2812         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2813         * tui/tui-command.c (tui_cmd_window::resize): Update.
2814
2815 2019-08-20  Tom Tromey  <tom@tromey.com>
2816
2817         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2818         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2819         (tui_data_window::check_register_values): Update.
2820
2821 2019-08-20  Tom Tromey  <tom@tromey.com>
2822
2823         * tui/tui-regs.h (struct tui_data_window): Use
2824         DISABLE_COPY_AND_ASSIGN.
2825         <regs_content>: Change type, removing unique_ptr.
2826         <tui_data_window>: Add move constructor.
2827         * tui/tui-regs.c (tui_data_window::show_registers)
2828         (tui_data_window::show_register_group)
2829         (tui_data_window::display_registers_from)
2830         (tui_data_window::display_registers_from)
2831         (tui_data_window::first_data_item_displayed)
2832         (tui_data_window::delete_data_content_windows)
2833         (tui_data_window::rerender, tui_data_window::refresh_window)
2834         (tui_data_window::check_register_values): Update.
2835
2836 2019-08-20  Tom Tromey  <tom@tromey.com>
2837
2838         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2839         show_register_group>: Declare.
2840         (tui_show_register_group): Don't declare.
2841         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2842         tui_show_registers.
2843         (tui_data_window::show_register_group): Rename from
2844         tui_show_register_group.
2845         (tui_data_window::check_register_values, tui_reg_command):
2846         Update.
2847         * tui/tui-layout.c (tui_set_layout): Update.
2848
2849 2019-08-20  Tom Tromey  <tom@tromey.com>
2850
2851         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2852         Declare.
2853         (tui_check_register_values): Don't declare.
2854         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2855         from tui_check_register_values.
2856         * tui/tui-hooks.c (tui_register_changed): Update.
2857
2858 2019-08-20  Tom Tromey  <tom@tromey.com>
2859
2860         * tui/tui-regs.c (tui_reg_layout): Move later.
2861         (tui_show_registers): Don't enable TUI mode or change layout.
2862
2863 2019-08-20  Tom Tromey  <tom@tromey.com>
2864
2865         * tui/tui-regs.h (struct tui_data_item_window)
2866         <~tui_data_item_window>: Remove.
2867         <content>: Now a unique_xmalloc_ptr.
2868         * tui/tui-regs.c (tui_register_format): Return a
2869         unique_xmalloc_ptr.
2870         (tui_get_register): Update.
2871         (~tui_data_item_window): Remove.
2872         (tui_data_window::display_registers_from, tui_display_register):
2873         Update.
2874         * tui/tui-io.h (tui_expand_tabs): Update.
2875         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2876         Remove "col" parameter.
2877
2878 2019-08-20  Tom Tromey  <tom@tromey.com>
2879
2880         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2881         field.
2882         * tui/tui-regs.c (~tui_data_item_window): Update.
2883
2884 2019-08-20  Tom Tromey  <tom@tromey.com>
2885
2886         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2887         earlier.
2888
2889 2019-08-20  Tom Tromey  <tom@tromey.com>
2890
2891         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2892
2893 2019-08-20  Tom Tromey  <tom@tromey.com>
2894
2895         * tui/tui-source.h (struct tui_source_window): Update.
2896         * tui/tui-regs.c (tui_show_registers): Update.
2897         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2898         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2899         (NO_REGS_STRING): Remove defines.
2900
2901 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2902
2903         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2904         unnecessary thread walk if remote doesn't support the packet.
2905
2906 2019-08-19  Tom Tromey  <tromey@adacore.com>
2907
2908         * python/py-value.c (value_has_field): Fix indentation.
2909
2910 2019-08-19  Tom Tromey  <tromey@adacore.com>
2911
2912         * printcmd.c (do_one_display, info_display_command): Update.
2913         * block.h (contained_in): Return bool.  Add allow_nested
2914         parameter.
2915         * block.c (contained_in): Return bool.  Add allow_nested
2916         parameter.
2917
2918 2019-08-19  Tom Tromey  <tom@tromey.com>
2919
2920         * configure: Rebuild.
2921         * configure.ac: Disallow the combination of -static-libstdc++ and
2922         source highlight.
2923         * source-cache.c (get_language_name): Handle rust.
2924         (source_cache::get_source_lines): Ignore highlighting exceptions.
2925
2926 2019-08-16  Tom Tromey  <tom@tromey.com>
2927
2928         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2929         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2930         (struct tui_source_window_base) <make_visible, refresh_window,
2931         resize>: Remove methods.
2932         <execution_info>: Remove field.
2933         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2934         (tui_show_source_line, tui_source_window_base)
2935         (~tui_source_window_base): Update.
2936         (tui_source_window_base::resize)
2937         (tui_source_window_base::make_visible)
2938         (tui_source_window_base::refresh_window): Remove.
2939         (tui_source_window_base::update_exec_info): Update.
2940         * tui/tui-source.c (tui_source_window::set_contents): Update.
2941         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2942
2943 2019-08-16  Tom Tromey  <tom@tromey.com>
2944
2945         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2946         deprecated_query_hook.
2947
2948 2019-08-16  Tom Tromey  <tom@tromey.com>
2949
2950         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2951         (tui_update_source_windows_with_line): Update.
2952         * tui/tui-source.h (struct tui_source_window)
2953         <show_symtab_source>: Declare.
2954         (tui_show_symtab_source): Don't declare.
2955         * tui/tui-source.c (tui_show_symtab_source): Rename from
2956         tui_show_symtab_source.
2957
2958 2019-08-16  Tom Tromey  <tom@tromey.com>
2959
2960         * tui/tui-winsource.h (struct tui_source_window_base)
2961         <set_contents>: Declare.
2962         * tui/tui-winsource.c
2963         (tui_source_window_base::update_source_window_as_is): Update.
2964         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2965         Declare.
2966         (tui_set_source_content): Don't declare.
2967         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2968         tui_set_source_content.
2969         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2970         Declare.
2971         (tui_set_disassem_content): Don't declare.
2972         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2973         tui_set_disassem_content.
2974
2975 2019-08-16  Tom Tromey  <tom@tromey.com>
2976
2977         * tui/tui-winsource.h (struct tui_source_window_base)
2978         <update_breakpoint_info>: Declare.
2979         (tui_update_breakpoint_info): Don't declare.
2980         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2981         (tui_update_all_breakpoint_info): Update.
2982         (tui_source_window_base::update_breakpoint_info): Rename from
2983         tui_update_breakpoint_info.
2984         (tui_source_window_base::update_exec_info): Update.
2985
2986 2019-08-16  Tom Tromey  <tom@tromey.com>
2987
2988         * tui/tui-winsource.h (struct tui_source_window_base)
2989         <update_source_window>: Declare.
2990         (tui_update_source_window): Don't declare.
2991         * tui/tui-winsource.c
2992         (tui_source_window_base::update_source_window): Rename from
2993         tui_update_source_window.
2994         (tui_source_window_base::rerender): Update.
2995         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2996         * tui/tui-disasm.c (tui_show_disassem)
2997         (tui_show_disassem_and_update_source)
2998         (tui_disasm_window::maybe_update): Update.
2999
3000 2019-08-16  Tom Tromey  <tom@tromey.com>
3001
3002         * tui/tui-winsource.h (struct tui_source_window_base)
3003         <update_source_window_as_is>: Declare.
3004         (tui_update_source_window_as_is): Don't declare.
3005         * tui/tui-winsource.c (tui_update_source_window): Update
3006         (tui_source_window_base::update_source_window_as_is): Rename from
3007         tui_update_source_window_as_is.
3008         (tui_source_window_base::refill): Update.
3009         * tui/tui-source.c (tui_show_symtab_source): Update.
3010         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3011         Update.
3012
3013 2019-08-16  Tom Tromey  <tom@tromey.com>
3014
3015         * tui/tui-winsource.h (tui_update_source_window)
3016         (tui_update_source_window_as_is): Remove "noerror" parameter.
3017         * tui/tui-winsource.c (tui_update_source_window)
3018         (tui_update_source_window_as_is): Remove "noerror" parameter.
3019         (tui_update_source_windows_with_addr)
3020         (tui_update_source_windows_with_line)
3021         (tui_source_window_base::rerender)
3022         (tui_source_window_base::refill): Update.
3023         * tui/tui-source.h (tui_set_source_content)
3024         (tui_show_symtab_source): Remove "noerror" parameter.
3025         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3026         parameter.
3027         (tui_show_symtab_source): Likewise.
3028         (tui_source_window::maybe_update): Update.
3029         * tui/tui-disasm.c (tui_show_disassem)
3030         (tui_show_disassem_and_update_source)
3031         (tui_disasm_window::do_scroll_vertical)
3032         (tui_disasm_window::maybe_update): Update.
3033
3034 2019-08-16  Tom Tromey  <tom@tromey.com>
3035
3036         * tui/tui.c (tui_is_window_visible): Update.
3037         * tui/tui-wingeneral.c (tui_make_window)
3038         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3039         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3040         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3041         (tui_set_win_height_command, parse_scrolling_args): Update.
3042         * tui/tui-source.c (tui_source_window::style_changed): Update.
3043         * tui/tui-regs.c (tui_show_registers)
3044         (tui_data_window::first_data_item_displayed)
3045         (tui_data_window::delete_data_content_windows)
3046         (tui_check_register_values, tui_reg_command): Update.
3047         * tui/tui-disasm.c (tui_show_disassem): Update.
3048         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3049         method.
3050         <is_visible>: Remove field.
3051         * tui/tui-data.c (tui_next_win, tui_prev_win)
3052         (tui_delete_invisible_windows): Update.
3053
3054 2019-08-16  Tom Tromey  <tom@tromey.com>
3055
3056         * tui/tui-winsource.h (struct tui_source_window_base)
3057         <m_has_locator>: Remove.
3058         * tui/tui-layout.c (show_source_disasm_command, show_data)
3059         (show_source_or_disasm_and_command): Update.
3060
3061 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3062
3063         * NEWS (Other MI changes): New subsection.
3064         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3065         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3066         * arch-utils.c (default_get_pc_address_flags): New function.
3067         * arch-utils.h (default_get_pc_address_flags): New declaration.
3068         * gdbarch.sh: Add get_pc_address_flags.
3069         * gdbarch.c: Regenerate.
3070         * gdbarch.h: Likewise.
3071         * stack.c (print_pc): New function.
3072         (print_frame_info) (print_frame): Call print_pc.
3073
3074 2019-08-16  Tom de Vries  <tdevries@suse.de>
3075
3076         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3077         print_objfile_section_info.
3078
3079 2019-08-15  Tom Tromey  <tom@tromey.com>
3080
3081         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3082         calling update_cmdwin_start_line.
3083         * tui/tui-winsource.h (struct tui_source_window_base)
3084         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3085         <rerender>: Declare.
3086         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3087         Call rerender.
3088         (tui_source_window_base::set_new_height): Remove.
3089         (tui_source_window_base::rerender): Rename from
3090         do_make_visible_with_new_height.
3091         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3092         resize method.
3093         (tui_win_info::make_invisible_and_set_new_height)
3094         (tui_win_info::make_visible_with_new_height): Remove.
3095         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3096         Declare.
3097         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3098         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3099         do_make_visible_with_new_height>: Don't declare.
3100         <rerender>: Declare.
3101         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3102         set_new_height.
3103         (tui_data_window::do_make_visible_with_new_height): Remove.
3104         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3105         call tui_show_locator_content.
3106         (tui_gen_win_info::resize): Call rerender.
3107         (show_source_or_disasm_and_command): Don't call
3108         tui_show_locator_content.
3109         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3110         method.
3111         (struct tui_win_info) <rerender>: Declare.
3112         <set_new_height, make_invisible_and_set_new_height,
3113         make_visible_with_new_height>: Don't declare.
3114         * tui/tui-data.c (tui_win_list::rerender): New method.
3115         * tui/tui-command.h (struct tui_cmd_window)
3116         <do_make_visible_with_new_height>: Don't declare.
3117         * tui/tui-command.c
3118         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3119
3120 2019-08-15  Tom Tromey  <tromey@adacore.com>
3121
3122         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3123         * ada-lang.c (ada_enum_name): Likewise.
3124
3125 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3126
3127         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3128         leading underscore.
3129         (GdbOutputErrorFile): Likewise.
3130         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3131         accordingly.
3132         (execute_unwinders): Rename to have a leading underscore.
3133         (auto_load_packages): Likewise.
3134         (global scope): Adjust call to auto_load_packages accordingly.
3135         (GdbSetPythonDirectory): Likewise.
3136         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3137         instead of execute_unwinders.
3138
3139 2019-08-15  Tom Tromey  <tom@tromey.com>
3140
3141         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3142         (show_data): Don't change window visibility.
3143         (tui_gen_win_info::resize): Remove special case for command
3144         window.  Use wresize, when available.
3145         (show_source_or_disasm_and_command): Don't change window
3146         visibility.
3147         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3148         <make_visible>: New method.
3149         * tui/tui-command.c (tui_cmd_window::resize): New method.
3150
3151 2019-08-15  Tom Tromey  <tom@tromey.com>
3152
3153         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3154         (struct tui_source_windows): New.
3155         * tui/tui-winsource.c (tui_display_main): Update.
3156         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3157         (new_height_ok, parse_scrolling_args): Update.
3158         * tui/tui-layout.c (show_layout, show_data): Update.
3159         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3160         (tui_add_to_source_windows): Don't declare.
3161         * tui/tui-data.c (source_windows, tui_source_windows)
3162         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3163
3164 2019-08-15  Tom Tromey  <tom@tromey.com>
3165
3166         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3167         Rename from reset.
3168         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3169         * tui/tui-layout.c (show_source_disasm_command, show_data):
3170         Update.
3171         (tui_gen_win_info::resize): Rename.
3172         (show_source_or_disasm_and_command): Update.
3173         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3174         reset.
3175
3176 2019-08-15  Tom Tromey  <tom@tromey.com>
3177
3178         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3179         * tui/tui-interp.c (tui_interp::init): Don't call
3180         tui_initialize_static_data.
3181         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3182
3183 2019-08-15  Tom Tromey  <tom@tromey.com>
3184
3185         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3186         examine tui_win_list.
3187
3188 2019-08-15  Tom Tromey  <tom@tromey.com>
3189
3190         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3191         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3192         tui_clear_source_content.
3193         (tui_clear_source_content): Remove.
3194         (tui_source_window_base::do_erase_source_content): Hoist call to
3195         content.clear().
3196         * tui/tui-stack.c (tui_show_frame_info): Don't call
3197         tui_clear_source_content.
3198
3199 2019-08-15  Tom Tromey  <tom@tromey.com>
3200
3201         * tui/tui-winsource.h (struct tui_source_window_base)
3202         <do_erase_source_content>: New method.
3203         <erase_source_content>: New method.
3204         (tui_erase_source_content): Don't declare.
3205         * tui/tui-winsource.c (tui_clear_source_content): Update.
3206         (tui_source_window_base::do_erase_source_content): Rename from
3207         tui_erase_source_content.
3208         (tui_source_window_base::show_source_content): Update.
3209         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3210         * tui/tui-source.h (struct tui_source_window)
3211         <erase_source_content>: New method.
3212         * tui/tui-disasm.h (struct tui_disasm_window)
3213         <erase_source_content>: New method.
3214
3215 2019-08-15  Tom Tromey  <tom@tromey.com>
3216
3217         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3218         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3219         constructor.
3220         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3221         * tui/tui-source.c (tui_set_source_content): Update.
3222         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3223
3224 2019-08-15  Tom Tromey  <tom@tromey.com>
3225
3226         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3227         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3228         tui-source.c.
3229         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3230         Declare.
3231         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3232         method.
3233         (tui_source_window::maybe_update): Update.
3234
3235 2019-08-15  Tom Tromey  <tom@tromey.com>
3236
3237         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3238         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3239         tui-disasm.c.
3240         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3241         Declare.
3242         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3243         method.
3244         (tui_disasm_window::maybe_update): Update.
3245
3246 2019-08-15  Tom Tromey  <tom@tromey.com>
3247
3248         * tui/tui-winsource.h (struct tui_source_window_base)
3249         <maybe_update>: Declare.
3250         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3251         method.
3252         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3253         Declare.
3254         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3255         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3256         Declare.
3257         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3258
3259 2019-08-15  Tom Tromey  <tom@tromey.com>
3260
3261         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3262
3263 2019-08-15  Tom Tromey  <tom@tromey.com>
3264
3265         * tui/tui-wingeneral.c: Include tui-stack.h.
3266         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3267         (struct tui_locator_window): Move from tui-data.h.
3268         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3269         (tui_initialize_static_data): Move from tui-data.c.
3270         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3271         (struct tui_locator_window): Move to tui-stack.c.
3272         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3273         (tui_initialize_static_data): Move to tui-stack.c.
3274
3275 2019-08-15  Tom Tromey  <tom@tromey.com>
3276
3277         * tui/tui-layout.c (show_source_disasm_command)
3278         (show_source_or_disasm_and_command): Use make_visible method, not
3279         tui_make_window.
3280         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3281         Remove.
3282
3283 2019-08-15  Tom Tromey  <tom@tromey.com>
3284
3285         * tui/tui-wingeneral.h (tui_make_window): Update.
3286         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3287         parameter.
3288         (tui_gen_win_info::make_visible): Update.
3289         * tui/tui-regs.c (tui_data_window::display_registers_from):
3290         Update.
3291         * tui/tui-layout.c (show_source_disasm_command)
3292         (show_source_or_disasm_and_command): Update.
3293         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3294         (enum tui_box): Remove.
3295         (struct tui_win_info) <can_box>: New method.
3296         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3297         method.
3298
3299 2019-08-15  Tom de Vries  <tdevries@suse.de>
3300
3301         * linux-nat-trad.c: Include gdbarch.h.
3302
3303 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3304
3305         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3306         register sizes.
3307
3308 2019-08-14  Tom Tromey  <tromey@adacore.com>
3309
3310         * darwin-nat.c: Include gdbarch.h.
3311         * darwin-nat-info.c: Include gdbarch.h.
3312
3313 2019-08-13  Tom Tromey  <tom@tromey.com>
3314
3315         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3316         Remove.
3317         * tui/tui-data.c (tui_initialize_static_data): Update.
3318
3319 2019-08-13  Tom Tromey  <tom@tromey.com>
3320
3321         * tui/tui-winsource.h (struct tui_exec_info_window)
3322         <~tui_exec_info_window, maybe_allocate_content, get_content,
3323         m_content>: Remove.
3324         (struct tui_source_window_base) <set_exec_info_content,
3325         show_exec_info_content>: Don't declare.
3326         * tui/tui-winsource.c
3327         (tui_exec_info_window::maybe_allocate_content): Remove.
3328         (tui_source_window_base::update_exec_info): Rename from
3329         set_exec_info_content.
3330         (tui_source_window_base::show_exec_info_content)
3331         (tui_source_window_base::update_exec_info): Remove.
3332
3333 2019-08-13  Tom Tromey  <tom@tromey.com>
3334
3335         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3336         declare.
3337         * tui/tui-winsource.c (tui_update_source_window_as_is)
3338         (tui_update_source_windows_with_addr, tui_erase_source_content):
3339         Update.
3340         (tui_clear_exec_info_content): Remove.
3341
3342 2019-08-13  Tom Tromey  <tom@tromey.com>
3343
3344         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3345         declare.
3346         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3347         call tui_erase_exec_info_content.
3348         (tui_clear_exec_info_content): Rename from
3349         tui_erase_exec_info_content.
3350         (tui_clear_exec_info_content): Delete.
3351
3352 2019-08-13  Tom Tromey  <tom@tromey.com>
3353
3354         * tui/tui-winsource.h (struct tui_source_window_base)
3355         <show_exec_info_content>: Declare.
3356         (tui_show_exec_info_content): Don't declare.
3357         * tui/tui-winsource.c
3358         (tui_source_window_base::show_exec_info_content): Rename from
3359         tui_show_exec_info_content.
3360         (tui_source_window_base::update_exec_info): Update.
3361
3362 2019-08-13  Tom Tromey  <tom@tromey.com>
3363
3364         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3365         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3366         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3367         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3368         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3369         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3370         ... here.
3371
3372 2019-08-13  Tom Tromey  <tom@tromey.com>
3373
3374         * tui/tui-winsource.h (struct tui_source_window_base)
3375         <update_exec_info>: Declare.
3376         (tui_update_exec_info): Don't declare.
3377         * tui/tui-winsource.c (tui_update_source_window_as_is)
3378         (tui_source_window_base::refresh_all)
3379         (tui_update_all_breakpoint_info): Update.
3380         (tui_source_window_base::update_exec_info): Rename from
3381         tui_update_exec_info.
3382         * tui/tui-stack.c (tui_show_frame_info): Update.
3383
3384 2019-08-13  Tom Tromey  <tom@tromey.com>
3385
3386         * tui/tui-winsource.h (struct tui_source_window_base)
3387         <set_exec_info_content>: Declare.
3388         (tui_set_exec_info_content): Don't declare.
3389         * tui/tui-winsource.c
3390         (tui_source_window_base::set_exec_info_content): Rename from
3391         tui_set_exec_info_content.
3392         (tui_update_exec_info): Update.
3393
3394 2019-08-13  Tom Tromey  <tom@tromey.com>
3395
3396         * tui/tui-winsource.h (struct tui_source_window_base)
3397         <show_source_content>: Declare.
3398         (tui_show_source_content): Don't declare.
3399         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3400         (tui_source_window_base::show_source_content): Rename from
3401         tui_show_source_content.
3402         (tui_source_window_base::refresh_all): Update.
3403         * tui/tui-layout.c (show_source_disasm_command)
3404         (show_source_or_disasm_and_command): Update.
3405
3406 2019-08-13  Tom Tromey  <tom@tromey.com>
3407
3408         * tui/tui-winsource.c (tui_erase_source_content)
3409         (tui_show_source_content, tui_source_window_base::refresh_all):
3410         Update.
3411         * tui/tui-wingeneral.h
3412         (tui_check_and_display_highlight_if_needed): Don't declare.
3413         * tui/tui-wingeneral.c
3414         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3415         check_and_display_highlight_if_needed.
3416         * tui/tui-win.c (tui_rehighlight_all)
3417         (tui_win_info::make_visible_with_new_height): Update.
3418         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3419         (tui_data_window::erase_data_content)
3420         (tui_data_window::display_all_data): Update.
3421         * tui/tui-data.h (struct tui_win_info)
3422         <check_and_display_highlight_if_needed>: Declare.
3423
3424 2019-08-13  Tom Tromey  <tom@tromey.com>
3425
3426         * tui/tui-win.c (tui_resize_all): Call
3427         tui_delete_invisible_windows.
3428         * tui/tui-layout.c (show_layout): Call
3429         tui_delete_invisible_windows.
3430         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3431         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3432
3433 2019-08-13  Tom Tromey  <tom@tromey.com>
3434
3435         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3436         tui_add_win_to_layout.
3437
3438 2019-08-13  Tom Tromey  <tom@tromey.com>
3439
3440         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3441         * tui/tui-layout.c (tui_default_win_height): Now static.
3442
3443 2019-08-13  Tom Tromey  <tom@tromey.com>
3444
3445         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3446         single switch.
3447         (show_source_disasm_command, show_source_or_disasm_and_command):
3448         Don't check current layout.
3449
3450 2019-08-13  Tom Tromey  <tom@tromey.com>
3451
3452         * tui/tui-wingeneral.c (make_all_visible): Remove.
3453         (tui_make_all_invisible): Simplify.
3454         * tui/tui-layout.c (tui_make_all_invisible): Move from
3455         tui-wingeneral.c; simplify.
3456         (show_layout): Hoist call to tui_make_all_invisible.
3457         (show_data): Don't call tui_make_all_invisible.
3458
3459 2019-08-13  Tom Tromey  <tom@tromey.com>
3460
3461         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3462         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3463
3464 2019-08-13  Tom Tromey  <tom@tromey.com>
3465
3466         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3467         tui-data.c.
3468         (show_source_disasm_command, show_data)
3469         (show_source_or_disasm_and_command): Don't use
3470         tui_set_current_layout_to.
3471         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3472         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3473         tui-layout.c.
3474         (tui_set_current_layout_to): Remove.
3475
3476 2019-08-13  Tom Tromey  <tom@tromey.com>
3477
3478         * tui/tui-layout.c (tui_set_layout): Update.
3479         * tui/tui-data.h (struct tui_layout_def): Remove.
3480         (tui_layout_def): Don't declare.
3481         * tui/tui-data.c (layout_def): Remove.
3482         (tui_layout_def): Remove.
3483
3484 2019-08-13  Tom Tromey  <tom@tromey.com>
3485
3486         * tui/tui-winsource.h (struct tui_source_window_base)
3487         <clear_detail>: No longer "override".
3488         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3489         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3490         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3491         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3492         Remove.
3493         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3494
3495 2019-08-13  Tom Tromey  <tromey@adacore.com>
3496
3497         * tracepoint.c: Don't include readline.h or history.h.
3498
3499 2019-08-12  Tom Tromey  <tom@tromey.com>
3500
3501         * configure: Rebuild.
3502         * configure.ac: Check for readline 7.
3503         * NEWS: Mention readline 7 requirement.
3504         * README: Update.
3505
3506 2019-08-12  Tom Tromey  <tom@tromey.com>
3507
3508         * mingw-hdep.c (gdb_select): Remove readline hack.
3509
3510 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3511
3512         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3513         when the function fails.
3514
3515 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3516
3517         * s390-tdep.c (s390_type_align): New function.
3518         (s390_gdbarch_init): Set it as type_align gdbarch method.
3519
3520 2019-08-09  Tom de Vries  <tdevries@suse.de>
3521
3522         PR gdb/24591
3523         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3524         pc_low with relocation offset.
3525
3526 2019-08-07  Tom Tromey  <tromey@adacore.com>
3527
3528         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3529         (print_frame_args): Update.
3530         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3531         Update.
3532         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3533         * frame.h (struct frame_arg): Add initializers.
3534         <error>: Now a unique_xmalloc_ptr.
3535
3536 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3537
3538         * NEWS: Expand the Pointer Authentication entry.
3539         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3540         (aarch64_frame_unmask_lr): ... to this.
3541         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3542         Call aarch64_frame_unmask_lr.
3543         * frame.c (struct frame_info): Add "masked" variable.
3544         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3545         (fprint_frame): Check for masked pc.
3546         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3547         declarations.
3548         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3549         * stack.c (print_frame): Check for masked pc.
3550
3551 2019-08-06  Tom Tromey  <tom@tromey.com>
3552
3553         * stabsread.c (patch_block_stabs, read_one_struct_field)
3554         (read_enum_type): Use obstack_strndup.
3555         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3556         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3557         * dwarf2read.c (guess_full_die_structure_name)
3558         (anonymous_struct_prefix): Use obstack_strndup.
3559         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3560         * c-exp.y (yylex): Use obstack_strndup.
3561         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3562         (write_var_or_type): Use obstack_strndup.
3563
3564 2019-08-06  Tom Tromey  <tom@tromey.com>
3565
3566         * symfile.c (reread_symbols): Use obstack_strdup.
3567         * stabsread.c (read_type): Use obstack_strdup.
3568         * gdb_obstack.h (obstack_strdup): New overload.
3569         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3570         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3571         (dwarf2_canonicalize_name): Use obstack_strdup.
3572         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3573         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3574         Use obstack_strdup.
3575
3576 2019-08-06  Tom Tromey  <tom@tromey.com>
3577
3578         * gdb_obstack.h (obstack_strdup): Define.
3579         * gdb_obstack.c (obstack_strdup): Don't define.
3580
3581 2019-08-06  Tom Tromey  <tom@tromey.com>
3582
3583         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3584         obstack_strdup.
3585         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3586         obstack_strdup.
3587         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3588         * stabsread.c (common_block_start): Use obstack_strdup.
3589         * objfiles.c (set_objfile_main_name, objfile): Use
3590         obstack_strdup.
3591         * namespace.c (add_using_directive): Use obstack_strdup.
3592         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3593         * jit.c (finalize_symtab): Use obstack_strdup.
3594         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3595         (guess_partial_die_structure_name, partial_die_info::fixup)
3596         (dwarf2_name): Use obstack_strdup.
3597         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3598         obstack_strdup.
3599         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3600         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3601         obstack_strdup.
3602         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3603
3604 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3605
3606         * unittests/help-doc-selftests.c: New file.
3607         * Makefile.in: Add the new file.
3608
3609 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3610
3611         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3612         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3613         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3614         the trailing '.' is not output, and the first character is uppercased.
3615         (print_help_for_command): Update call to print_doc_line.
3616         (print_doc_of_command): Likewise.
3617         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3618         * cli/cli-option.c (append_indented_doc): Do not append newline.
3619         (build_help_option): Append newline after first appended_indented_doc
3620         only if a second call is done.
3621         (build_help): Append 2 new lines before each option, except the first
3622         one.
3623         * compile/compile.c (_initialize_compile): Add new lines after
3624         %OPTIONS%, when not at the end of the help.
3625         Change help doc or code
3626         producing the help doc to respect the invariants.
3627         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3628         Also removed the new line after 'Options:', as all other commands
3629         do not put an empty line between 'Options:' and the first option.
3630         * printcmd.c (_initialize_printcmd): Likewise.
3631         * stack.c (_initialize_stack): Likewise.
3632         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3633         incorrectly telling COMMAND is optional.
3634         * ada-lang.c (_initialize_ada_language): Change help doc or code
3635         producing the help doc to respect the invariants.
3636         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3637         * breakpoint.c (_initialize_breakpoint): Likewise.
3638         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3639         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3640         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3641         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3642         _initialize_cli_style): Likewise.
3643         * corelow.c (core_target_info): Likewise.
3644         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3645         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3646         * filesystem.c (_initialize_filesystem): Likewise.
3647         * frame.c (_initialize_frame): Likewise.
3648         * gnu-nat.c (add_task_commands): Likewise.
3649         * infcall.c (_initialize_infcall): Likewise.
3650         * infcmd.c (_initialize_infcmd): Likewise.
3651         * interps.c (_initialize_interpreter): Likewise.
3652         * language.c (_initialize_language): Likewise.
3653         * linux-fork.c (_initialize_linux_fork): Likewise.
3654         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3655         * maint.c (_initialize_maint_cmds): Likewise.
3656         * memattr.c (_initialize_mem): Likewise.
3657         * printcmd.c (_initialize_printcmd): Likewise.
3658         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3659         _RegEx): Likewise.
3660         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3661         * record-btrace.c (_initialize_record_btrace): Likewise.
3662         * record-full.c (_initialize_record_full): Likewise.
3663         * record.c (_initialize_record): Likewise.
3664         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3665         * regcache.c (_initialize_regcache): Likewise.
3666         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3667         _initialize_remote): Likewise.
3668         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3669         * serial.c (_initialize_serial): Likewise.
3670         * skip.c (_initialize_step_skip): Likewise.
3671         * source.c (_initialize_source): Likewise.
3672         * stack.c (_initialize_stack): Likewise.
3673         * symfile.c (_initialize_symfile): Likewise.
3674         * symtab.c (_initialize_symtab): Likewise.
3675         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3676         * top.c (init_main): Likewise.
3677         * tracefile-tfile.c (tfile_target_info): Likewise.
3678         * tracepoint.c (_initialize_tracepoint): Likewise.
3679         * tui/tui-win.c (_initialize_tui_win): Likewise.
3680         * utils.c (add_internal_problem_command): Likewise.
3681         * valprint.c (value_print_option_defs): Likewise.
3682
3683 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3684
3685         PR build/24886
3686         * configure.ac: Drop enable-libmcheck support.
3687         * configure, config.in: Rebuild.
3688         * libmcheck.m4: Remove.
3689         * acinclude.m4: Don't include it.
3690         * Makefile.in: Don't distribute it.
3691         * top.c (print_gdb_configuration): Don't mention it.
3692
3693 2019-08-06  Tom Tromey  <tom@tromey.com>
3694
3695         * utils.c (set_output_style): Sometimes pass stream to
3696         emit_style_escape.
3697         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3698         * record-btrace.c (btrace_insn_history): Update.
3699         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3700         method.
3701         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3702         Update initializers.
3703         <m_uiout>: New field.
3704         <m_di>: Move lower.
3705         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3706         Remove "uiout" parameter.
3707         (dump_insns): Update.
3708         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3709         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3710
3711 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3712
3713         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3714         (error_in_psymtab_expansion): Likewise.
3715         (lookup_symbol_via_quick_fns): Likewise.
3716         (basic_lookup_transparent_type_quick): Likewise.
3717         (basic_lookup_transparent_type_1): Likewise.
3718
3719 2019-08-06  Tom Tromey  <tromey@adacore.com>
3720
3721         * source.c (last_source_error): Now bool.
3722         (print_source_lines_base): Make "noprint" bool.  Only open
3723         source file when last_source_visited changes.
3724
3725 2019-08-06  Tom Tromey  <tromey@adacore.com>
3726
3727         * annotate.c (annotate_source_line): Use g_source_cache.
3728         * source-cache.c (source_cache::get_plain_source_lines): Change
3729         parameters.  Populate m_offset_cache.
3730         (source_cache::ensure): New method.
3731         (source_cache::get_line_charpos): New method.
3732         (extract_lines): Move lower.  Change parameters.
3733         (source_cache::get_source_lines): Move lower.
3734         * source-cache.h (class source_cache): Update comment.
3735         <get_line_charpos>: New method.
3736         <get_source_lines>: Update comment.
3737         <clear>: Clear m_offset_cache.
3738         <get_plain_source_lines>: Change parameters.
3739         <ensure>: New method
3740         <m_offset_cache>: New member.
3741         * source.c (forget_cached_source_info_for_objfile): Update.
3742         (info_source_command): Use g_source_cache.
3743         (find_source_lines, open_source_file_with_line_charpos): Remove.
3744         (print_source_lines_base, search_command_helper): Use g_source_cache.
3745         * source.h (open_source_file_with_line_charpos): Don't declare.
3746         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3747         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3748         Use g_source_cache.
3749
3750 2019-08-06  Tom Tromey  <tromey@adacore.com>
3751
3752         * source-cache.c (source_cache::get_plain_source_lines):
3753         Remove "first_line" and "last_line" parameters.
3754         (source_cache::get_source_lines): Cache plain text.
3755         * source-cache.h (class source_cache)
3756         <get_plain_source_lines>: Update.
3757
3758 2019-08-06  Tom Tromey  <tromey@adacore.com>
3759
3760         * source-cache.c (extract_lines): No longer a method.
3761         Changed type of parameter.  Include final newline.
3762         (selftests::extract_lines_test): New function.
3763         (_initialize_source_cache): Likewise.
3764         * source-cache.h (class source_cache)
3765         <extract_lines>: Don't declare.
3766
3767 2019-08-06  Tom Tromey  <tromey@adacore.com>
3768
3769         * breakpoint.c (init_breakpoint_sal): Update.
3770         (breakpoint): Update.
3771         * breakpoint.h (struct breakpoint) <filter>: Now a
3772         unique_xmalloc_ptr.
3773
3774 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3775
3776         * NEWS: Mention dictionary access on blocks.
3777         * python/py-block.c (blpy_getitem): New function.
3778         (block_object_as_mapping): New struct.
3779         (block_object_type): Use new struct for tp_as_mapping field.
3780
3781 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3782
3783         * objfiles.h (objfile): Add a comment describing partial symbols.
3784
3785 2019-08-05  Tom Tromey  <tromey@adacore.com>
3786
3787         * compile/compile.c (_initialize_compile): Use _(), not N_().
3788         * thread.c (_initialize_thread): Use _(), not N_().
3789         * stack.c (_initialize_stack): Use _(), not N_().
3790         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3791
3792 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3793
3794         * dwarf2read.c (struct dw2_symtab_iterator):
3795         <want_specific_block>: Remove.
3796         <block_index>: Change type to gdb::optional.
3797         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3798         change type of BLOCK_INDEX parameter to gdb::optional.
3799         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3800         (dw2_lookup_symbol): Don't pass argument for
3801         WANT_SPECIFIC_BLOCK.
3802         (dw2_expand_symtabs_for_function): Don't pass argument for
3803         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3804         (class dw2_debug_names_iterator)
3805         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3806         parameter, change BLOCK_INDEX type to gdb::optional.
3807         <m_want_specific_block>: Remove.
3808         <m_block_index>: Change type to gdb::optional.
3809         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3810         gdb::optional.  Re-write in function of gdb::optional.
3811         (dw2_debug_names_lookup_symbol): Don't pass argument for
3812         WANT_SPECIFIC_BLOCK.
3813         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3814         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3815         BLOCK_INDEX.
3816
3817 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3818
3819         * NEWS: Mention changes to "info sources" command.
3820
3821 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3822
3823         * symtab.c (filename_partial_match_opts): New struct type.
3824         (struct output_source_filename_data): New members
3825         regexp, c_regexp, partial_match.
3826         (output_source_filename): Use new members to decide to print file.
3827         (info_sources_option_defs): New variable.
3828         (make_info_sources_options_def_group, print_info_sources_header,
3829         info_sources_command_completer):
3830         New functions.
3831         (info_sources_command): Read new optional arguments.
3832         (_initialize_symtab): Update info sources help.
3833
3834 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3835
3836         * ada-lang.c (exception_support_info_v0): Renamed from...
3837         (default_exception_support_info): ... this.  Create new
3838         definition for v1.
3839         (ada_has_this_exception_support): Look up catch_handlers_sym.
3840         (ada_exception_support_info_sniffer): Try v0 after default.
3841
3842 2019-08-01  Tom Tromey  <tromey@adacore.com>
3843
3844         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3845         gdbarch.h.
3846
3847 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3848
3849         * s12z-tdep.c: Fix include path for s12z-opc.h.
3850
3851 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3852
3853         * NEWS: Require GNU make 3.82.
3854
3855 2019-07-16  Tom Tromey  <tom@tromey.com>
3856
3857         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3858         declare.
3859
3860 2019-07-30  Tom Tromey  <tromey@adacore.com>
3861
3862         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3863
3864 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3865
3866         * printcmd.c (print_address_symbolic): Print negative offsets.
3867         (build_address_symbolic): Force signed arithmetic when computing
3868         offset.
3869
3870 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3871
3872         PR/24474: Add a function to lookup static variables.
3873         * NEWS: Mention this new function.
3874         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3875         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3876         * python/python.c (python_GdbMethods): Add new function.
3877
3878 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3879
3880         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3881         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3882         (objfpy_lookup_static_symbol): New function.
3883         (objfile_object_methods): Add new functions.
3884
3885 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3886
3887         * NEWS: Mention 'set|show print frame-info'.  Mention new
3888         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3889         backtrace argument.  Mention that python frame filtering code
3890         is now consistent with what 'backtrace' command prints.
3891
3892 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3893
3894         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3895         comments.
3896         (print_frame_info_auto, print_frame_info_source_line,
3897         print_frame_info_location, print_frame_info_source_and_location,
3898         print_frame_info_location_and_address, print_frame_info_short_location):
3899         New declarations.
3900         (struct frame_print_options): New member print_frame_info.
3901         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3902         * stack.h (get_user_print_what_frame_info): New declaration.
3903         (frame_show_address): New declaration.
3904         * stack.c (print_frame_arguments_choices): New value 'presence'.
3905         (print_frame_info_auto, print_frame_info_source_line,
3906         print_frame_info_location, print_frame_info_source_and_location,
3907         print_frame_info_location_and_address, print_frame_info_short_location,
3908         print_frame_info_choices, print_frame_info_print_what): New definitions.
3909         (print_frame_args): Only print dots for args if print frame-arguments
3910         is 'presence'.
3911         (frame_print_option_defs): New element for "frame-info".
3912         (get_user_print_what_frame_info): New function.
3913         (frame_show_address): Make non static.  Move comment to stack.h.
3914         (print_frame_info_to_print_what): New function.
3915         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3916         to decide what to print.
3917         (backtrace_command_1): Handle the new print_frame_arguments_presence
3918         value.
3919         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3920         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3921         (py_print_frame): In non-mi mode, use LOCATION as default for
3922         print_what, similarly to frame information printed directly by
3923         backtrace command. Handle frame-info user option in non MI mode.
3924
3925 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3926
3927         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3928         Add case for debugging 32-bit target on 64-bit host.  Revise
3929         comment.
3930
3931 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3932
3933         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3934         instead of find_function_entry_range_from_pc.
3935
3936 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3937
3938         * stack.c (find_frame_funname): Remove code which preferred
3939         minsym over symtab sym in "certain pathological cases".
3940
3941         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3942         parameter.  Change type of "do_demangle" to bool.
3943         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3944         Pass suitable "prefer_sym_over_minsym" flag to
3945         build_address_symbolic().  Don't output "+" for negative offsets.
3946         * printcmd.c (print_address_symbolic): Update invocation of
3947         build_address_symbolic to include a "prefer_sym_over_minsym"
3948         flag.
3949         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3950         Restrict cases in which use of minimal symbol is preferred to that
3951         of a found symbol.  Update comments.
3952
3953         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3954         for entry pc when entry pc is out of range for that FDE.
3955
3956 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3957
3958         PR gdb/24839:
3959         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3960         type.
3961
3962 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3963
3964         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3965         this function's Python signature.
3966
3967
3968 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3969
3970         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3971         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3972         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3973         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3974         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3975
3976
3977 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3978
3979         * h8300-tdep.c (h8300_register_name_common): New.
3980         h8300_register_name): Use h8300_register_name_common.
3981         (h8300s_register_name): Likewise.
3982         (h8300sx_register_name): Likewise.
3983         (h8300h_register_nam): New.
3984         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3985
3986
3987 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3988
3989         * arm-tdep.c (arm_skip_cmse_entry): New function.
3990         (arm_is_sgstubs_section): New function.
3991         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3992
3993 2019-07-22  Tom Tromey  <tom@tromey.com>
3994
3995         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3996         Don't self-assign.
3997
3998 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3999
4000         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4001         type_print.
4002
4003 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4004
4005         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4006         so that GDB doesn't match any msymbols when searching in the
4007         TYPES_DOMAIN.
4008         (print_symbol_info): Print using typedef_print or type_print based
4009         on the type of the symbol.  Add updated FIXME comment moved from...
4010         (_initialize_symtab): ... move and update FIXME comment to above.
4011
4012 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4013
4014         * NEWS: Mention adding -q option to "info types".
4015         * symtab.c (struct info_types_options): New struct.
4016         (info_types_options_defs): New variable.
4017         (make_info_types_options_def_group): New function.
4018         (info_types_command): Use gdb::option framework to parse options.
4019         (info_types_command_completer): New function.
4020         (_initialize_symtab): Extend the help text on "info types" and
4021         register command completer.
4022
4023 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4024
4025         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4026         (lookup_symbol_in_objfile): Change int to block_enum and add a
4027         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4028
4029 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4030
4031         * MAINTAINERS (Write After Approval): Add self.
4032
4033 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4034
4035         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4036         instruction to the dummy code region.
4037
4038 2019-07-19  Tom Tromey  <tromey@adacore.com>
4039
4040         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4041         (ARGSUSED, PARAMS, __func__): Remove rules.
4042
4043 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4044
4045         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4046         * features/arm/arm-with-iwmmxt.c: Remove.
4047         * features/arm/arm-with-iwmmxt.xml: Remove.
4048         * features/arm/arm-with-m-fpa-layout.c: Remove.
4049         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4050         * features/arm/arm-with-m-vfp-d16.c: Remove.
4051         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4052         * features/arm/arm-with-m.c: Remove.
4053         * features/arm/arm-with-m.xml: Remove.
4054         * features/arm/arm-with-neon.c: Remove.
4055         * features/arm/arm-with-neon.xml: Remove.
4056         * features/arm/arm-with-vfpv2.c: Remove.
4057         * features/arm/arm-with-vfpv2.xml: Remove.
4058         * features/arm/arm-with-vfpv3.c: Remove.
4059         * features/arm/arm-with-vfpv3.xml: Remove.
4060
4061 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4062
4063         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4064
4065 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4066
4067         * arch/aarch32.c (aarch32_create_target_description): Create
4068         target descriptions using features.
4069         * arch/arm.c (arm_create_target_description)
4070         (arm_create_mprofile_target_description): Likewise.
4071         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4072
4073 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4074
4075         * Makefile.in: Add new files.
4076         * aarch32-tdep.c: New file.
4077         * aarch32-tdep.h: New file.
4078         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4079         Call aarch32_read_description.
4080         * arch/aarch32.c: New file.
4081         * arch/aarch32.h: New file.
4082         * arch/arm.c (arm_create_target_description)
4083         (arm_create_mprofile_target_description): New function.
4084         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4085         (arm_create_target_description)
4086         (arm_create_mprofile_target_description): New declaration.
4087         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4088         read_description functions.
4089         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4090         Likewise.
4091         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4092         * arm-tdep.c (tdesc_arm_list): New variable.
4093         (arm_register_g_packet_guesses): Call create description functions.
4094         (arm_read_description) (arm_read_mprofile_description): New
4095         function.
4096         * arm-tdep.h (arm_read_description)
4097         (arm_read_mprofile_description): Add declaration.
4098         * configure.tgt: Add new files.
4099
4100 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4101
4102         * top.c (new_ui_command): Open specified terminal just once.
4103
4104 2019-07-18  Tom Tromey  <tromey@adacore.com>
4105
4106         * symtab.c (main_name): Constify return type.
4107         * symfile.c (set_initial_language): Update.
4108         * symtab.h (main_name): Constify return type.
4109
4110 2019-07-17  Tom Tromey  <tom@tromey.com>
4111
4112         * tui/tui-winsource.c (tui_update_source_window)
4113         (tui_update_source_window_as_is)
4114         (tui_update_source_windows_with_line): Remove return.
4115         * tui/tui-disasm.c (tui_show_disassem)
4116         (tui_show_disassem_and_update_source): Remove return.
4117         * tui/tui.c (tui_reset): Remove return.
4118         * tui/tui-wingeneral.c
4119         (tui_check_and_display_highlight_if_needed): Remove return.
4120
4121 2019-07-17  Tom Tromey  <tom@tromey.com>
4122
4123         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4124
4125 2019-07-17  Tom Tromey  <tom@tromey.com>
4126
4127         * tui/tui-winsource.h (struct tui_exec_info_window)
4128         (struct tui_source_window_base): Move from tui-data.h.
4129         * tui/tui-winsource.c: Move many method definitions from
4130         elsewhere.  Remove "structuring" comments.
4131         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4132         (tui_source_window_base::refresh_window): Move to
4133         tui-winsource.c.
4134         * tui/tui-win.c (tui_source_window_base::refresh_all)
4135         (tui_source_window_base::update_tab_width)
4136         (tui_source_window_base::set_new_height)
4137         (tui_source_window_base::do_make_visible_with_new_height): Move to
4138         tui-winsource.c.
4139         * tui/tui-source.h: Update.
4140         * tui/tui-source.c (tui_source_window_base::reset): Move to
4141         tui-winsource.c.
4142         * tui/tui-disasm.h: Update.
4143         * tui/tui-data.h (struct tui_exec_info_window): Move to
4144         tui-winsource.h.
4145         (struct tui_source_window_base): Likewise.
4146         * tui/tui-data.c (tui_source_window_base::clear_detail)
4147         (tui_source_window_base, ~tui_source_window_base): Move to
4148         tui-winsource.c.
4149
4150 2019-07-17  Tom Tromey  <tom@tromey.com>
4151
4152         * tui/tui-win.c (tui_resize_all)
4153         (tui_source_window_base::update_tab_width)
4154         (tui_adjust_win_heights): Update.
4155         (tui_win_info::make_invisible_and_set_new_height): Rename from
4156         make_invisible_and_set_new_height.
4157         * tui/tui-data.h (struct tui_win_info)
4158         <make_invisible_and_set_new_height>: New method.
4159
4160 2019-07-17  Tom Tromey  <tom@tromey.com>
4161
4162         * tui/tui.c: Update.
4163         * tui/tui-source.h (struct tui_source_window): Move from
4164         tui-data.h.
4165         * tui/tui-layout.c: Update.
4166         * tui/tui-disasm.c: Update.
4167         * tui/tui-data.h (struct tui_source_window): Move to
4168         tui-source.h.
4169
4170 2019-07-17  Tom Tromey  <tom@tromey.com>
4171
4172         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4173         tui-data.h.
4174         * tui/tui-data.h (struct tui_disasm_window): Move to
4175         tui-disasm.h.
4176
4177 2019-07-17  Tom Tromey  <tom@tromey.com>
4178
4179         * tui/tui-regs.h (struct tui_data_item_window): Move from
4180         tui-data.h.
4181         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4182         * tui/tui-data.h (struct tui_data_item_window): Move to
4183         tui-regs.h.
4184         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4185
4186 2019-07-17  Tom Tromey  <tom@tromey.com>
4187
4188         * tui/tui.c: Update.
4189         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4190         (tui_cmd_window::max_height): Move to tui-command.c.
4191         * tui/tui-layout.c: Update.
4192         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4193         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4194         tui-command.c.
4195         * tui/tui-command.h (struct tui_cmd_window): Move from
4196         tui-data.h.
4197         * tui/tui-command.c: Remove "structuring" comments.
4198         (tui_cmd_window::clear_detail)
4199         (tui_cmd_window::do_make_visible_with_new_height)
4200         (tui_cmd_window::max_height): Move from elsewhere.
4201
4202 2019-07-17  Tom Tromey  <tom@tromey.com>
4203
4204         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4205         Now static.
4206         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4207         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4208
4209 2019-07-17  Tom Tromey  <tom@tromey.com>
4210
4211         * tui/tui.c: Update.
4212         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4213         tui-regs.c.
4214         * tui/tui-windata.h: Remove file.
4215         * tui/tui-windata.c: Remove file.
4216         * tui/tui-win.c (tui_data_window::set_new_height)
4217         (tui_data_window::do_make_visible_with_new_height): Move to
4218         tui-regs.c.
4219         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4220         * tui/tui-regs.c: Remove "structuring" comments.
4221         (tui_data_window::first_data_item_displayed)
4222         (tui_data_window::delete_data_content_windows)
4223         (tui_data_window::erase_data_content)
4224         (tui_data_window::display_all_data)
4225         (tui_data_window::refresh_all)
4226         (tui_data_window::do_scroll_vertical)
4227         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4228         (tui_data_window::do_make_visible_with_new_height)
4229         (tui_data_window::refresh_window): Move from elsewhere.
4230         (_initialize_tui_regs): Move to end of file.
4231         * tui/tui-layout.c: Update.
4232         * tui/tui-hooks.c: Update.
4233         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4234         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4235         tui-regs.c.
4236         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4237
4238 2019-07-17  Tom Tromey  <tom@tromey.com>
4239
4240         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4241         seen.
4242
4243 2019-07-17  Tom Tromey  <tom@tromey.com>
4244
4245         * tui/tui-win.c (tui_source_window_base::set_new_height)
4246         (tui_source_window_base::do_make_visible_with_new_height): Use
4247         m_has_locator field directly.
4248         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4249         method.
4250         (struct tui_source_window_base) <has_locator>: Likewise.
4251
4252 2019-07-17  Tom Tromey  <tom@tromey.com>
4253
4254         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4255         Don't declare.
4256         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4257         Remove.
4258         * tui/tui-win.c (tui_source_window_base::set_new_height)
4259         (tui_source_window_base::set_new_height)
4260         (make_invisible_and_set_new_height)
4261         (tui_source_window_base::do_make_visible_with_new_height)
4262         (tui_source_window_base::do_make_visible_with_new_height):
4263         Update.
4264         * tui/tui-layout.c (show_source_disasm_command, show_data)
4265         (show_source_or_disasm_and_command): Update.
4266         * tui/tui-layout.c (show_layout): Update.
4267
4268 2019-07-17  Tom Tromey  <tom@tromey.com>
4269
4270         * tui/tui-layout.c (make_data_window): Remove.
4271         (show_data): Unify creation and re-initialization cases.
4272
4273 2019-07-17  Tom Tromey  <tom@tromey.com>
4274
4275         * tui/tui-layout.c (make_source_window, make_disasm_window):
4276         Remove.
4277         (show_data): Unify creation and re-initialization cases.
4278
4279 2019-07-17  Tom Tromey  <tom@tromey.com>
4280
4281         * tui/tui-layout.c (make_command_window): Remove.
4282         (show_source_disasm_command, show_source_or_disasm_and_command):
4283         Unify creation and re-initialization cases.
4284
4285 2019-07-17  Tom Tromey  <tom@tromey.com>
4286
4287         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4288         creation and re-initialization cases.
4289
4290 2019-07-17  Tom Tromey  <tom@tromey.com>
4291
4292         * tui/tui-regs.c (tui_get_register): Return void.
4293
4294 2019-07-17  Tom Tromey  <tom@tromey.com>
4295
4296         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4297         Simplify.
4298
4299 2019-07-17  Tom Tromey  <tom@tromey.com>
4300
4301         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4302         resetting.
4303
4304 2019-07-17  Tom Tromey  <tom@tromey.com>
4305
4306         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4307         * tui/tui-regs.c (tui_reg_layout): New function.
4308         (tui_show_registers, tui_reg_command): Use it.
4309         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4310         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4311         parameters.
4312         (tui_layout_command): Remove.
4313
4314 2019-07-17  Tom Tromey  <tom@tromey.com>
4315
4316         * tui/tui-layout.h (tui/tui-layout): Return void.
4317         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4318
4319 2019-07-17  Tom Tromey  <tom@tromey.com>
4320
4321         * tui/tui-layout.c (show_source_disasm_command, show_data):
4322         Update.
4323         (reset_locator): Remove.
4324         (show_source_or_disasm_and_command): Update.
4325
4326 2019-07-17  Tom Tromey  <tom@tromey.com>
4327
4328         * tui/tui-source.c (tui_source_window_base::reset): Remove
4329         win_type parameter.
4330         * tui/tui-layout.c (make_command_window, make_source_window)
4331         (make_disasm_window, make_data_window)
4332         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4333         (reset_locator, show_source_or_disasm_and_command): Update.
4334         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4335         win_type parameter.
4336         (struct tui_source_window_base) <reset>: Likewise.
4337
4338 2019-07-17  Tom Tromey  <tom@tromey.com>
4339
4340         * tui/tui-layout.c (show_source_disasm_command): Use
4341         reset_locator.
4342         (reset_locator): New function.
4343         (init_and_make_win): Remove.
4344         (show_source_or_disasm_and_command): Use reset_locator.
4345
4346 2019-07-17  Tom Tromey  <tom@tromey.com>
4347
4348         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4349         condition.
4350         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4351         Remove condition.
4352         * tui/tui-source.c (tui_source_window_base::reset): New method.
4353         * tui/tui-layout.c (make_command_window): Don't call
4354         init_and_make_win.
4355         (make_source_window, make_disasm_window): Don't call
4356         make_source_or_disasm_window.
4357         (make_data_window): Don't call init_and_make_win.  Change calling
4358         convention.
4359         (show_source_disasm_command, show_data): Simplify.
4360         (make_source_or_disasm_window): Remove.
4361         (show_source_or_disasm_and_command): Simplify.
4362         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4363         (struct tui_source_window_base) <reset>: Likewise.
4364         <execution_info>: Remove initializer.
4365         * tui/tui-data.c (tui_source_window_base): Initialize
4366         execution_info.
4367
4368 2019-07-17  Tom Tromey  <tom@tromey.com>
4369
4370         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4371         variable.
4372
4373 2019-07-17  Tom Tromey  <tom@tromey.com>
4374
4375         * tui/tui.c (tui_rl_other_window): Update.
4376         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4377         superclass method first.  Always iterate over regs_content.
4378         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4379         method.
4380         * tui/tui-win.c (tui_set_focus_command): Update.
4381
4382 2019-07-17  Tom Tromey  <tom@tromey.com>
4383
4384         * tui/tui-win.c (tui_set_focus_command): Rename from
4385         tui_set_focus.  Call tui_enable.
4386         (tui_set_focus_command): Remove.
4387
4388 2019-07-17  Tom Tromey  <tom@tromey.com>
4389
4390         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4391         refresh_window.
4392         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4393         touchwin.
4394         (tui_data_window::refresh_window): Call refresh_window on data
4395         items.  Always call superclass refresh_window.
4396         (tui_win_info::refresh): Remove.
4397         (tui_source_window_base::refresh_window): Update.
4398         (tui_refresh_all): Update.
4399         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4400         refresh_window.
4401         (show_source_or_disasm_and_command): Likewise.
4402         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4403         (struct tui_source_window_base) <refresh>: Likewise.
4404
4405 2019-07-17  Tom Tromey  <tom@tromey.com>
4406
4407         * tui/tui-winsource.c (tui_clear_source_content)
4408         (tui_show_source_content): Update.
4409         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4410         whether content is empty.
4411         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4412         Remove.
4413
4414 2019-07-17  Tom Tromey  <tom@tromey.com>
4415
4416         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4417         window's contents.
4418         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4419         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4420
4421 2019-07-17  Tom Tromey  <tom@tromey.com>
4422
4423         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4424         (struct tui_data_item_window): Update.
4425
4426 2019-07-17  Tom Tromey  <tom@tromey.com>
4427
4428         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4429         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4430         defines.
4431
4432 2019-07-17  Tom Tromey  <tom@tromey.com>
4433
4434         * tui/tui-winsource.h (tui_erase_source_content)
4435         (tui_clear_source_content): Remove "display_prompt" parameter.
4436         * tui/tui-winsource.c (tui_update_source_window_as_is)
4437         (tui_update_source_windows_with_addr): Update.
4438         (tui_clear_source_content): Remove "display_prompt" parameter.
4439         (tui_erase_source_content): Likewise.  Simplify.
4440         (tui_show_source_content): Update.
4441         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4442         * tui/tui-stack.c (tui_show_frame_info): Update.
4443         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4444         Remove defines.
4445
4446 2019-07-17  Tom Tromey  <tom@tromey.com>
4447
4448         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4449         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4450         parameter.
4451         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4452         parameter.
4453
4454 2019-07-17  Tom Tromey  <tom@tromey.com>
4455
4456         * tui/tui-winsource.c (tui_clear_source_content)
4457         (tui_show_source_content, tui_show_exec_info_content)
4458         (tui_clear_exec_info_content): Update.
4459         * tui/tui-stack.c (tui_show_locator_content): Update.
4460         (tui_show_frame_info): Update.
4461         * tui/tui-source.h (tui_source_window): Don't declare.
4462         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4463         from tui_source_is_displayed.
4464         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4465         Remove field.
4466         (struct tui_source_window_base) <content_in_use>: New field.  Now
4467         bool.
4468         (struct tui_source_window) <showing_source_p>: New method.
4469         (TUI_SRC_WIN): Change cast.
4470         * tui/tui-data.c (tui_initialize_static_data): Update.
4471
4472 2019-07-17  Tom Tromey  <tom@tromey.com>
4473
4474         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4475         location_matches_p.
4476         * tui/tui-source.c (tui_source_window::location_matches_p): New
4477         method.
4478         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4479         method.
4480         * tui/tui-data.h (struct tui_source_window_base)
4481         <location_matches_p>: New method.
4482         (struct tui_source_window, struct tui_disasm_window)
4483         <location_matches_p>: Likewise.
4484
4485 2019-07-17  Tom Tromey  <tom@tromey.com>
4486
4487         * tui/tui-win.c (tui_set_win_height_command): Rename from
4488         tui_set_win_height.
4489         (tui_set_win_height_command): Remove.
4490
4491 2019-07-17  Tom Tromey  <tom@tromey.com>
4492
4493         * tui/tui-source.c (tui_source_window): New constructor.  Add
4494         observer.
4495         (~tui_source_window): New destructor.
4496         (tui_source_window::style_changed): New method.
4497         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4498         (tui_attach_detach_observers): Update.
4499         * tui/tui-data.h (struct tui_source_window): Make constructor not
4500         inline.  Add destructor.
4501         (struct tui_source_window) <style_changed>: New method.
4502         <m_observable>: New member.
4503
4504 2019-07-17  Tom Tromey  <tom@tromey.com>
4505
4506         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4507         * tui/tui-win.c (tui_resize_all): Fix typo.
4508
4509 2019-07-17  Tom Tromey  <tom@tromey.com>
4510
4511         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4512         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4513         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4514         * tui/tui-win.c (window_name_completer): Use foreach.
4515         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4516         (update_tab_width): Likewise.
4517         * tui/tui-layout.c (show_layout): Update.
4518         * tui/tui-data.h (class tui_window_iterator): New.
4519         (struct all_tui_windows): New.
4520         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4521
4522 2019-07-17  Tom Tromey  <tom@tromey.com>
4523
4524         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4525         parameter.  Don't reference globals.
4526         (tui_reg_command): Update.
4527
4528 2019-07-17  Tom Tromey  <tom@tromey.com>
4529
4530         * tui/tui-regs.c (tui_show_registers): Simplify.
4531
4532 2019-07-17  Tom Tromey  <tom@tromey.com>
4533
4534         * tui/tui-regs.c (tui_show_registers): Update.
4535         (tui_show_register_group): Add win_info parameter.
4536
4537 2019-07-17  Tom Tromey  <tom@tromey.com>
4538
4539         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4540         Rename from tui_display_reg_element_at_line.
4541         (tui_data_window::display_registers_from_line): Update.
4542         * tui/tui-data.h (struct tui_data_window)
4543         <display_reg_element_at_line>: New method.
4544
4545 2019-07-17  Tom Tromey  <tom@tromey.com>
4546
4547         * tui/tui-regs.h (tui_display_registers_from)
4548         (tui_display_registers_from_line): Don't declare.
4549         * tui/tui-windata.c (tui_data_window::display_all_data)
4550         (tui_data_window::refresh_all)
4551         (tui_data_window::do_scroll_vertical): Update.
4552         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4553         from tui_display_registers_from.
4554         (tui_display_reg_element_at_line): Update.
4555         (tui_data_window::display_registers_from_line): Rename from
4556         tui_display_registers_from_line.
4557         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4558         display_registers_from_line>: New methods.
4559
4560 2019-07-17  Tom Tromey  <tom@tromey.com>
4561
4562         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4563         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4564         from tui_erase_data_content.
4565         (tui_data_window::display_all_data)
4566         (tui_data_window::refresh_all)
4567         (tui_data_window::do_scroll_vertical): Update.
4568         * tui/tui-regs.c (tui_show_registers): Update.
4569         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4570         New method.
4571
4572 2019-07-17  Tom Tromey  <tom@tromey.com>
4573
4574         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4575         declare.
4576         * tui/tui-windata.c
4577         (tui_data_window::delete_data_content_windows): Rename from
4578         tui_delete_data_content_windows.
4579         (tui_data_window::display_all_data)
4580         (tui_data_window::do_scroll_vertical): Update.
4581         * tui/tui-data.h (struct tui_data_window)
4582         <delete_data_content_windows>: New method.
4583
4584 2019-07-17  Tom Tromey  <tom@tromey.com>
4585
4586         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4587         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4588
4589 2019-07-17  Tom Tromey  <tom@tromey.com>
4590
4591         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4592         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4593         from tui_display_all_data.
4594         * tui/tui-win.c
4595         (tui_data_window::do_make_visible_with_new_height): Update.
4596         * tui/tui-regs.c (tui_show_registers): Update.
4597         * tui/tui-layout.c (tui_set_layout): Update.
4598         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4599         method.
4600
4601 2019-07-17  Tom Tromey  <tom@tromey.com>
4602
4603         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4604         * tui/tui-windata.c (tui_display_data_from): Remove.
4605         (tui_data_window::refresh_all): Update.
4606
4607 2019-07-17  Tom Tromey  <tom@tromey.com>
4608
4609         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4610         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4611         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4612         tui_display_registers_from_line.
4613         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4614         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4615         "force_display" parameter.
4616
4617 2019-07-17  Tom Tromey  <tom@tromey.com>
4618
4619         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4620         declare.
4621         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4622         Rename from tui_first_reg_element_no_inline.
4623         (tui_display_reg_element_at_line)
4624         (tui_display_registers_from_line): Update.
4625         * tui/tui-data.h (struct tui_data_window)
4626         <first_reg_element_no_inline>: New method.
4627
4628 2019-07-17  Tom Tromey  <tom@tromey.com>
4629
4630         * tui/tui-windata.c (tui_display_data_from)
4631         (tui_data_window::do_scroll_vertical): Update.
4632         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4633         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4634         Rename from tui_line_from_reg_element_no.
4635         (tui_display_registers_from_line): Update.
4636         * tui/tui-data.h (struct tui_data_window)
4637         <line_from_reg_element_no>: New method.
4638
4639 2019-07-17  Tom Tromey  <tom@tromey.com>
4640
4641         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4642         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4643         tui_last_regs_line_no.
4644         (tui_display_reg_element_at_line)
4645         (tui_display_registers_from_line): Update.
4646         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4647         method.
4648
4649 2019-07-17  Tom Tromey  <tom@tromey.com>
4650
4651         PR tui/24722:
4652         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4653         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4654         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4655         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4656         (tui_update_breakpoint_info): Likewise.
4657         * tui/tui-hooks.c (tui_event_create_breakpoint)
4658         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4659         Update.
4660
4661 2019-07-17  Tom Tromey  <tom@tromey.com>
4662
4663         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4664
4665 2019-07-17  Tom Tromey  <tom@tromey.com>
4666
4667         * tui/tui-winsource.c (tui_update_source_window_as_is)
4668         (tui_update_source_windows_with_addr): Update.
4669         * tui/tui-source.h (tui_set_source_content)
4670         (tui_show_symtab_source): Add "win_info" parameter.
4671         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4672         parameter.
4673         (tui_show_symtab_source): Likewise.
4674
4675 2019-07-17  Tom Tromey  <tom@tromey.com>
4676
4677         * tui/tui-wingeneral.c
4678         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4679
4680 2019-07-17  Tom Tromey  <tom@tromey.com>
4681
4682         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4683         (struct tui_cmd_window) <can_scroll>: New method.
4684         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4685         method.
4686
4687 2019-07-17  Tom Tromey  <tromey@adacore.com>
4688
4689         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4690         do_field_signed>: Rename.  Change type of "value".
4691         * ui-out.c (ui_out::field_signed): Rename from field_int.
4692         Change type of "value".
4693         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4694         type of "value".
4695         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4696         do_field_int.  Change type of "value".
4697         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4698         do_field_int.  Change type of "value".
4699         * tracepoint.c (trace_status_mi, tfind_1)
4700         (print_one_static_tracepoint_marker): Update.
4701         * thread.c (print_thread_info_1, print_selected_thread_frame):
4702         Update.
4703         * stack.c (print_frame, print_frame_info): Update.
4704         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4705         Update.
4706         * source.c (print_source_lines_base): Update.
4707         * skip.c (info_skip_command): Update.
4708         * record-btrace.c (btrace_ui_out_decode_error)
4709         (btrace_call_history_src_line): Update.
4710         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4711         Update.
4712         * progspace.c (print_program_space): Update.
4713         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4714         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4715         do_field_int.  Change type of "value".
4716         * mi/mi-out.c (mi_ui_out::do_table_begin)
4717         (mi_ui_out::do_table_header): Update.
4718         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4719         type of "value".
4720         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4721         (mi_cmd_data_list_changed_registers, output_register)
4722         (mi_cmd_data_read_memory, mi_load_progress)
4723         (mi_cmd_trace_frame_collected): Update.
4724         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4725         Update.
4726         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4727         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4728         (mi_cmd_var_list_children, varobj_update_one): Update.
4729         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4730         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4731         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4732         * inferior.c (print_inferior): Update.
4733         * gdb_bfd.c (print_one_bfd): Update.
4734         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4735         Update.
4736         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4737         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4738         do_field_int.  Change type of "value".
4739         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4740         do_field_int.  Change type of "value".
4741         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4742         (print_one_breakpoint_location, print_it_catch_fork)
4743         (print_one_catch_fork, print_it_catch_vfork)
4744         (print_one_catch_vfork, print_it_catch_solib)
4745         (print_it_catch_exec, print_it_ranged_breakpoint)
4746         (print_mention_watchpoint, print_mention_masked_watchpoint)
4747         (bkpt_print_it, update_static_tracepoint): Update.
4748         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4749         * break-catch-syscall.c (print_it_catch_syscall): Update.
4750         * ada-tasks.c (print_ada_task_info): Update.
4751         * ada-lang.c (print_it_exception, print_mention_exception):
4752         Update.
4753
4754 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4755
4756         PR breakpoints/24541
4757         * gdbarch.c: Regenerate.
4758         * gdbarch.h: Regenerate.
4759         * gdbarch.sh: Adjust return type and parameter types for
4760         'stap_adjust_register'.
4761         (i386_stap_adjust_register): Adjust signature and return new
4762         register name.
4763         * stap-probe.c (stap_parse_register_operand): Adjust use of
4764         'gdbarch_stap_adjust_register'.
4765
4766 2019-07-17  Tom Tromey  <tromey@adacore.com>
4767
4768         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4769         declare VEC.
4770         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4771         std::vector.
4772         (struct s390_process_info): Add initializers.
4773         (s390_add_process): Use new.
4774         (s390_linux_nat_target::low_forget_process): Use delete.
4775         (s390_linux_nat_target::low_new_fork)
4776         (s390_linux_nat_target::stopped_by_watchpoint)
4777         (s390_linux_nat_target::low_prepare_to_resume)
4778         (s390_linux_nat_target::insert_watchpoint)
4779         (s390_linux_nat_target::insert_hw_breakpoint)
4780         (s390_linux_nat_target::remove_watchpoint)
4781         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4782
4783 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4784
4785         * aarch64-fbsd-nat.c: Include regcache.h.
4786         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4787         argument.
4788         (aarch64_fbsd_nat_target::fetch_registers)
4789         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4790         variable.
4791         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4792
4793 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4794
4795         * fbsd-nat.c: Include gdbarch.h.
4796
4797 2019-07-15  Tom Tromey  <tromey@adacore.com>
4798
4799         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4800
4801 2019-07-15  Tom Tromey  <tromey@adacore.com>
4802
4803         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4804         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4805         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4806         * cli-out.c (cli_ui_out::do_field_int): New method.
4807         * ui-out.c (ui_out::field_unsigned): New method.
4808         * symfile.c (generic_load): Use field_unsigned.
4809         (print_transfer_performance): Likewise.
4810         * record-btrace.c (ui_out_field_uint): Remove.
4811         (btrace_call_history_insn_range, btrace_call_history): Use
4812         field_unsigned.
4813         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4814         field_unsigned.
4815         * ui-out.h (class ui_out) <field_unsigned>: New method.
4816         <do_field_unsigned>: Likewise.
4817
4818 2019-07-15  Tom Tromey  <tromey@adacore.com>
4819
4820         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4821         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4822         * target.c (flash_erase_command): Use field_string.
4823         * infrun.c (print_signal_received_reason): Use field_string.
4824         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4825         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4826         field_string.
4827         * ada-tasks.c (print_ada_task_info): Use field_string.
4828
4829 2019-07-15  Tom Tromey  <tromey@adacore.com>
4830
4831         * target.c (flash_erase_command): Use field_core_addr.
4832         * symfile.c (generic_load): Use field_core_addr.
4833         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4834         Use field_core_addr.
4835         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4836         field_core_addr.
4837
4838 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4839
4840         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4841         value if its desired type is smaller than a CORE_ADDR and signed.
4842
4843 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4844
4845         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4846         of changes to field names, and use new is_reference field to
4847         decide if a property is a reference or not.
4848         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4849         field.
4850         (struct dwarf2_property_baton): Update header comment, rename
4851         'referenced_type' to 'property_type' and update comments.
4852         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4853         default property type, store in property baton, update to take
4854         accound of renamed field.
4855         (read_func_scope): Update call to attr_to_dynamic_prop.
4856         (read_array_type): Likewise.
4857         (dwarf2_per_cu_addr_sized_int_type): New function.
4858         (read_subrange_index_type): Move type finding code to
4859         dwarf2_per_cu_addr_sized_int_type.
4860         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4861         (dwarf2_per_cu_addr_type): New function.
4862         (set_die_type): Update calls to attr_to_dynamic_prop.
4863
4864 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4865
4866         * dwarf2read.c (read_subrange_index_type): New function.
4867         (read_subrange_type): Move code into new function and call it.
4868         * gdbtypes.c (create_range_type): Add some asserts.
4869
4870 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4871
4872         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4873         update return statements.
4874         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4875         declaration, and update comment to match.
4876         * gdbtypes.c (resolve_dynamic_array): Update call to
4877         dwarf2_evaluate_property to match new return type.
4878
4879 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4880
4881         * valarith.c (value_subscripted_rvalue): Change lowerbound
4882         parameter type from int to LONGEST.
4883         * value.h (value_subscripted_rvalue): Likewise in declaration.
4884
4885 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4886
4887         * cli/cli-utils.c (info_print_command_completer): New function.
4888         * cli/cli-utils.h: Add 'completer.h' include, and forward
4889         declaration for 'struct cmd_list_element'.
4890         (info_print_command_completer): Declare.
4891         * stack.c (_initialize_stack): Add completer for 'info locals' and
4892         'info args'.
4893         * symtab.c (_initialize_symtab): Add completer for 'info
4894         variables' and 'info functions'.
4895         * NEWS: Mention completion for additional info commands.
4896
4897 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4898
4899         * cli/cli-utils.c (extract_info_print_args): Delete.
4900         (extract_arg_maybe_quoted): Delete.
4901         (info_print_options_defs): New variable.
4902         (make_info_print_options_def_group): New function.
4903         (extract_info_print_options): Define new function.
4904         * cli/cli-utils.h (extract_info_print_args): Delete.
4905         (struct info_print_options): New structure.
4906         (extract_info_print_options): Declare new function.
4907         * stack.c (info_locals_command): Update to use new
4908         extract_info_print_options, also add a header comment.
4909         (info_args_command): Likewise.
4910         * symtab.c (info_variables_command): Likewise.
4911         (info_functions_command): Likewise.
4912
4913 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4914
4915         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4916         to extract string arguments.
4917         * common/common-utils.c (extract_string_maybe_quoted): New function.
4918         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4919
4920 2019-07-11  Tom Tromey  <tromey@adacore.com>
4921
4922         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4923         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4924         * top.h (gdbinit): Don't declare.
4925         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4926         into...
4927         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4928         * top.c (gdb_init): Don't call init_cli_cmds.
4929         (gdbinit): Remove.
4930         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4931
4932 2019-07-11  Tom Tromey  <tromey@adacore.com>
4933
4934         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4935         after it has been moved.
4936
4937 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4938
4939         * valops.c (value_must_coerce_to_target): Change return type to
4940         bool.
4941         * value.h (value_must_coerce_to_target): Likewise.
4942
4943 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4944
4945         * breakpoint.c (is_hardware_watchpoint): Remove
4946         forward-declaration.
4947         (is_masked_watchpoint): Change return type to bool.
4948         (is_tracepoint): Likewise.
4949         (is_breakpoint): Likewise.
4950         (is_hardware_watchpoint): Likewise.
4951         (is_watchpoint): Likewise.
4952         (is_no_memory_software_watchpoint): Likewise.
4953         (is_catchpoint): Likewise.
4954         (breakpoint_1): Make FILTER parameter's return type bool.
4955         is_masked_watchpoint): Change return type to bool.
4956         (save_breakpoints): Make FILTER parameter's return type bool.
4957         * breakpoint.h (is_breakpoint): Change return type to bool.
4958         (is_watchpoint): Likewise.
4959         (is_catchpoint): Likewise.
4960         (is_tracepoint): Likewise.
4961
4962 2019-07-10  Tom Tromey  <tom@tromey.com>
4963
4964         * defs.h: Don't include gdbarch.h.
4965         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4966         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4967         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4968         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4969         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4970         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4971         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4972         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4973         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4974         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4975         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4976         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4977         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4978         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4979         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4980         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4981         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4982         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4983         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4984         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4985         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4986         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4987         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4988         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4989         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4990         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4991         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4992
4993 2019-07-10  Tom Tromey  <tromey@adacore.com>
4994
4995         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4996         * breakpoint.c (init_ada_exception_breakpoint): Register as
4997         bp_catchpoint.
4998         (print_one_breakpoint_location, print_one_breakpoint): Use
4999         is_ada_exception_catchpoint.
5000         * ada-lang.c (class ada_catchpoint_location): Pass
5001         bp_loc_software_breakpoint to bp_location constructor.
5002         (is_ada_exception_catchpoint): New function.
5003
5004 2019-07-10  Tom Tromey  <tromey@adacore.com>
5005
5006         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5007         VEC.
5008         (struct arm_exidx_entry): New method operator<.
5009         (struct arm_exidx_data) <section_maps>: Change type.
5010         (arm_exidx_data_free): Remove.
5011         (arm_exidx_data_key): Change type.  Move lower.
5012         (arm_exidx_new_objfile): Update.
5013         (arm_compare_exidx_entries): Remove.
5014         (arm_find_exidx_entry, _initialize_arm_tdep)
5015
5016 2019-07-10  Tom Tromey  <tromey@adacore.com>
5017
5018         * solib-spu.c (ocl_program_data_key): Change type.
5019         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5020         Update.
5021
5022 2019-07-10  Tom Tromey  <tromey@adacore.com>
5023
5024         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5025         (struct solib_aix_inferior_data) <library_list>: Change type.
5026         (solib_aix_inferior_data_handle): Change type.
5027         (get_solib_aix_inferior_data): Update.
5028         (solib_aix_free_library_list): Remove.
5029         (library_list_start_library): Update.
5030         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5031         return type.
5032         (solib_aix_get_library_list)
5033         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5034         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5035
5036 2019-07-10  Tom Tromey  <tromey@adacore.com>
5037
5038         * solib-dsbt.c (struct dsbt_info): Add initializers.
5039         (solib_dsbt_pspace_data): Change type.
5040         (dsbt_pspace_data_cleanup): Remove.
5041         (get_dsbt_info, _initialize_dsbt_solib): Update.
5042
5043 2019-07-10  Tom Tromey  <tromey@adacore.com>
5044
5045         * spu-tdep.c (spu_overlay_data): Change type.
5046         (spu_get_overlay_table, spu_overlay_new_objfile)
5047         (_initialize_spu_tdep): Update.
5048
5049 2019-07-10  Tom Tromey  <tromey@adacore.com>
5050
5051         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5052         destructor.
5053         (dbx_objfile_data_key): Change type and declare later.
5054         (DBX_SYMFILE_INFO): Rewrite.
5055         * dbxread.c (dbx_objfile_data_key): Change type.
5056         (dbx_symfile_init): Update.
5057         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5058         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5059         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5060
5061 2019-07-10  Tom Tromey  <tromey@adacore.com>
5062
5063         * jit.c (jit_program_space_key): Change type.  Move lower.
5064         (get_jit_program_space_data): Update.
5065         (jit_program_space_data_cleanup): Remove.
5066         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5067         Update.
5068         (struct jit_program_space_data): Add initializers.
5069
5070 2019-07-10  Tom Tromey  <tromey@adacore.com>
5071
5072         * solib-darwin.c (struct darwin_info): Add initializers.
5073         (solib_darwin_pspace_data): Change type.
5074         (darwin_pspace_data_cleanup): Remove.
5075         (get_darwin_info, _initialize_darwin_solib): Update.
5076
5077 2019-07-10  Tom Tromey  <tromey@adacore.com>
5078
5079         * remote-sim.c (struct sim_inferior_data): Add initializers,
5080         constructor, and destructor.
5081         (sim_inferior_data_key): Change type.  Move lower.
5082         (check_for_duplicate_sim_descriptor): Update.
5083         (get_sim_inferior_data): Use new.  Update.
5084         (~sim_inferior_data_cleanup): Rename from
5085         sim_inferior_data_cleanup.  Simplify.
5086         (gdbsim_close_inferior, simulator_command)
5087         (sim_command_completer, _initialize_remote_sim): Update.
5088         (next_pid, INITIAL_PID): Move earlier.
5089
5090 2019-07-10  Tom Tromey  <tromey@adacore.com>
5091
5092         * python/python-internal.h (create_thread_object): Return
5093         gdbpy_ref.
5094         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5095         * python/py-inferior.c (struct threadlist_entry): Add
5096         constructor.
5097         <thread_obj>: Now a gdbpy_ref.
5098         (thread_to_thread_object): Update.
5099         (add_thread_object): Use new.
5100         (delete_thread_object): Use delete.
5101         (infpy_threads): Update.
5102         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5103         GIL.
5104
5105 2019-07-10  Tom Tromey  <tromey@adacore.com>
5106
5107         * valops.c (value_cast): Specialize error message for Ada.
5108
5109 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5110
5111         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5112
5113 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5114
5115         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5116         bpstat_should_step): Return bool, adjust comments.
5117         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5118         bpstat_should_step): Likewise.
5119
5120 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5121
5122         * features/Makefile: Use feature target descriptions for Arm.
5123         * features/arm/arm-core.c: Generate new file.
5124         * features/arm/arm-fpa.c: Likewise.
5125         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5126         * features/arm/arm-m-profile.c: Likewise.
5127         * features/arm/arm-vfpv2.c: Likewise.
5128         * features/arm/arm-vfpv3.c: Likewise.
5129         * features/arm/xscale-iwmmxt.c: Likewise.
5130         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5131
5132 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5133
5134         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5135         ptrace earlier.
5136
5137 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5138
5139         * features/aarch64-pauth.c: Regenerate.
5140
5141 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5142
5143         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5144         bool.
5145         (bpstat_what): Use false instead of 0.
5146
5147 2019-07-09  Pedro Alves  <palves@redhat.com>
5148
5149         * break-catch-throw.c (is_exception_catchpoint): New.
5150         * breakpoint.c (print_one_breakpoint_location): New parameter
5151         'raw_loc'.  Handle it.  Use
5152         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5153         looking at the breakpoint's type.
5154         (print_one_breakpoint): If handling "maint info breakpoints", also
5155         print locations of exception catchpoints.
5156         * breakpoint.h (is_exception_catchpoint): Declare.
5157
5158 2019-07-09  Pedro Alves  <palves@redhat.com>
5159
5160         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5161         "addr" field.
5162         (allocate_location_exception_catchpoint): New.
5163         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5164         (initialize_throw_catchpoint_ops): Install
5165         allocate_location_exception_catchpoint as allocate_location
5166         method.
5167         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5168         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5169         bp_loc_other.
5170         (breakpoint_address_is_meaningful): Delete.
5171         (bl_address_is_meaningful): New.
5172         (breakpoint_locations_match): Adjust comment.
5173         (bp_location_from_bp_type): New, factored out of...
5174         (bp_location::bp_location(breakpoint *)): ... this.
5175         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5176         factored out of...
5177         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5178         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5179         breakpoint_address_is_meaningful.
5180         (bp_locations_compare): Adjust comment.
5181         (update_global_location_list): Use bl_address_is_meaningful
5182         instead of breakpoint_address_is_meaningful.
5183         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5184         explicit.
5185         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5186         * python/py-breakpoint.c (bppy_get_location): No longer check
5187         whether location is null.
5188
5189 2019-07-09  Pedro Alves  <palves@redhat.com>
5190
5191         PR c++/15468
5192         * breakpoint.c (print_one_breakpoint_location): Remove
5193         single-location assert.
5194
5195 2019-07-09  Tom Tromey  <tom@tromey.com>
5196
5197         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5198         * configure: Rebuild.
5199         * configure.ac: Change common to gdbsupport.
5200         * gdbsupport: Rename from common.
5201         * acinclude.m4: Change common to gdbsupport.
5202         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5203         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5204         gdbsupport.
5205         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5206         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5207         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5208         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5209         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5210         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5211         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5212         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5213         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5214         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5215         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5216         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5217         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5218         coff-pe-read.c, command.h, compile/compile-c-support.c,
5219         compile/compile-c.h, compile/compile-cplus-symbols.c,
5220         compile/compile-cplus-types.c, compile/compile-cplus.h,
5221         compile/compile-loc2c.c, compile/compile.c, completer.c,
5222         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5223         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5224         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5225         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5226         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5227         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5228         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5229         features/aarch64-core.c, features/aarch64-fpu.c,
5230         features/aarch64-pauth.c, features/aarch64-sve.c,
5231         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5232         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5233         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5234         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5235         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5236         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5237         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5238         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5239         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5240         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5241         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5242         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5243         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5244         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5245         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5246         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5247         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5248         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5249         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5250         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5251         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5252         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5253         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5254         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5255         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5256         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5257         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5258         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5259         minsyms.c, mips-linux-tdep.c, namespace.h,
5260         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5261         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5262         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5263         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5264         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5265         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5266         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5267         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5268         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5269         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5270         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5271         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5272         procfs.c, producer.c, progspace.h, psymtab.h,
5273         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5274         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5275         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5276         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5277         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5278         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5279         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5280         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5281         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5282         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5283         target-memory.c, target.c, target.h, target/waitstatus.c,
5284         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5285         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5286         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5287         unittests/array-view-selftests.c,
5288         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5289         unittests/common-utils-selftests.c,
5290         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5291         unittests/format_pieces-selftests.c,
5292         unittests/function-view-selftests.c,
5293         unittests/lookup_name_info-selftests.c,
5294         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5295         unittests/mkdir-recursive-selftests.c,
5296         unittests/observable-selftests.c,
5297         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5298         unittests/parse-connection-spec-selftests.c,
5299         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5300         unittests/scoped_fd-selftests.c,
5301         unittests/scoped_mmap-selftests.c,
5302         unittests/scoped_restore-selftests.c,
5303         unittests/string_view-selftests.c, unittests/style-selftests.c,
5304         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5305         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5306         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5307         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5308         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5309         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5310
5311 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5312
5313         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5314         bool value.
5315         (decode_digits_ordinary): Set explicit_line field in sal.
5316         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5317         symtab_and_line that was set on an explicit line number in
5318         assembler code.  Do always update the recorded symtab and line if
5319         we do skip the prologue.
5320
5321 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5322
5323         * breakpoint.c (set_breakpoint_location_function): Remove
5324         explicit_loc parameter.
5325         (momentary_breakpoint_from_master): Update call to
5326         set_breakpoint_location_function.
5327         (add_location_to_breakpoint): Likewise.
5328
5329 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5330
5331         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5332         required features based on default bfd type when no specific bfd
5333         is present.
5334
5335 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5336
5337         * NEWS: Mention that GDB printf and eval commands can now print
5338         C-style and Ada-style convenience var strings without
5339         calling the inferior.
5340         * printcmd.c (printf_c_string): Locally print GDB internal var
5341         instead of transiting via the inferior.
5342         (printf_wide_c_string): Likewise.
5343
5344 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5345
5346         PR breakpoints/25011
5347         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5348
5349 2019-07-04  Tom Tromey  <tom@tromey.com>
5350
5351         PR tui/24724:
5352         * tui/tui-winsource.c (tui_clear_source_content): Update.
5353         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5354         (tui_update_breakpoint_info): Update.
5355         (tui_set_exec_info_content): Update.
5356         * tui/tui-source.c (tui_set_source_content_nil): Update.
5357         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5358         has_break.
5359         * tui/tui-data.h (enum tui_bp_flag): New.
5360         (tui_bp_flags): New enum flags type.
5361         (struct tui_source_element) <break_mode>: Change type.  Rename
5362         from has_break.
5363         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5364         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5365         constants.
5366         * tui/tui-winsource.h: Fix comment.
5367
5368 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5369
5370         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5371         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5372         (store_fpregs_to_thread)
5373         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5374         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5375         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5376         (IWMMXT_REGS_SIZE): Add define.
5377         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5378         (fetch_vfp_regs, store_vfp_regs)
5379         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5380         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5381
5382 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5383
5384         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5385         defines.
5386         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5387         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5388         (ARM_INT_REGISTER_SIZE): ...to this.
5389         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5390         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5391         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5392         (arm_linux_collect_gregset, supply_nwfpe_register)
5393         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5394         defines.
5395         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5396         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5397         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5398         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5399         (arm_return_in_memory, arm_store_return_value)
5400         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5401         (arm_record_ld_st_multiple): Likewise.
5402         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5403         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5404
5405 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5406
5407         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5408         AARCH64_DISPLACED_MODIFIED_INSNS.
5409         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5410         (aarch64_displaced_step_copy_insn): Likewise.
5411         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5412         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5413         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5414         ARM_DISPLACED_MODIFIED_INSNS.
5415         * arm-tdep.c (arm_gdbarch_init): Likewise.
5416         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5417         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5418         (struct arm_displaced_step_closure): Use
5419         ARM_DISPLACED_MODIFIED_INSNS.
5420
5421 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5422
5423         * features/Makefile: Remove unused xml files.
5424         * features/aarch64.xml: Remove.
5425         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5426         * features/i386/amd64-avx-avx512.xml: Remove.
5427         * features/i386/amd64-avx-linux.xml: Remove.
5428         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5429         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5430         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5431         * features/i386/amd64-avx-mpx.xml: Remove.
5432         * features/i386/amd64-avx.xml: Remove.
5433         * features/i386/amd64-linux.xml: Remove.
5434         * features/i386/amd64-mpx-linux.xml: Remove.
5435         * features/i386/amd64-mpx.xml: Remove.
5436         * features/i386/amd64.xml: Remove.
5437         * features/i386/i386-avx-avx512-linux.xml: Remove.
5438         * features/i386/i386-avx-avx512.xml: Remove.
5439         * features/i386/i386-avx-linux.xml: Remove.
5440         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5441         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5442         * features/i386/i386-avx-mpx-linux.xml: Remove.
5443         * features/i386/i386-avx-mpx.xml: Remove.
5444         * features/i386/i386-avx.xml: Remove.
5445         * features/i386/i386-linux.xml: Remove.
5446         * features/i386/i386-mmx-linux.xml: Remove.
5447         * features/i386/i386-mmx.xml: Remove.
5448         * features/i386/i386-mpx-linux.xml: Remove.
5449         * features/i386/i386-mpx.xml: Remove.
5450         * features/i386/i386.xml: Remove.
5451         * features/i386/x32-avx-avx512-linux.xml: Remove.
5452         * features/i386/x32-avx-linux.xml: Remove.
5453         * features/i386/x32-linux.xml: Remove.
5454
5455 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5456
5457         * regformats/aarch64.dat: Remove.
5458         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5459         * regformats/i386/amd64-avx-linux.dat: Remove.
5460         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5461         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5462         * regformats/i386/amd64-linux.dat: Remove.
5463         * regformats/i386/amd64-mpx-linux.dat: Remove.
5464         * regformats/i386/amd64.dat: Remove.
5465         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5466         * regformats/i386/i386-avx-linux.dat: Remove.
5467         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5468         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5469         * regformats/i386/i386-linux.dat: Remove.
5470         * regformats/i386/i386-mmx-linux.dat: Remove.
5471         * regformats/i386/i386-mpx-linux.dat: Remove.
5472         * regformats/i386/i386.dat: Remove.
5473         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5474         * regformats/i386/x32-avx-linux.dat: Remove.
5475         * regformats/i386/x32-linux.dat: Remove.
5476
5477 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5478
5479         * aarch64-tdep.c: Remove xml self tests.
5480         * amd64-linux-tdep.c: Likewise.
5481         * amd64-tdep.c: Likewise.
5482         * i386-linux-tdep.c: Likewise.
5483         * i386-tdep.c: Likewise.
5484
5485 2019-07-03  Pedro Alves  <palves@redhat.com>
5486
5487         PR cli/24732
5488         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5489         (pipe_cmd_option_defs): New.
5490         (make_pipe_cmd_options_def_group): New.
5491         (pipe_command): Use gdb::option::process_options.
5492         (pipe_command_completer): New function.
5493         (_initialize_cli_cmds): Install completer for "pipe" command.
5494
5495 2019-07-03  Pedro Alves  <palves@redhat.com>
5496
5497         * cli/cli-option.c (union option_value) <string>: New field.
5498         (struct option_def_and_value): Add ctor, move ctor, dtor and
5499         use DISABLE_COPY_AND_ASSIGN.
5500         (option_def_and_value::clear_value): New.
5501         (parse_option, save_option_value_in_ctx, get_val_type_str)
5502         (add_setshow_cmds_for_options): Handle var_string.
5503         * cli-option.h (union option_def::var_address) <string>: New
5504         field.
5505         (struct string_option_def): New.
5506         * maint-test-options.c (struct test_options_opts): Add default
5507         ctor and use DISABLE_COPY_AND_ASSIGN.
5508         <string_opt>: New field.
5509         (test_options_opts::~test_options_opts): New.
5510         (test_options_opts::dump): Also dump "-string".
5511         (test_options_option_defs): Install "string.
5512
5513 2019-07-03  Pedro Alves  <palves@redhat.com>
5514
5515         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5516         option_value with a null enumeration.
5517         (complete_options): Save the option values in the context.
5518         (save_option_value_in_ctx): New, factored out from ...
5519         (process_options): ... here.
5520         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5521         of the function.
5522         * maint-test-options.c (test_options_opts::dump): New, factored
5523         out from ...
5524         (maintenance_test_options_command_mode): ... here.
5525         (maintenance_test_options_command_completion_result): Delete.
5526         (maintenance_test_options_command_completion_text): Update
5527         comment.
5528         (maintenance_show_test_options_completion_result): Change
5529         prototype.  Just print
5530         maintenance_test_options_command_completion_text.
5531         (save_completion_result): New.
5532         (maintenance_test_options_completer_mode): Pass options context to
5533         complete_options, and then save a dump.
5534         (_initialize_maint_test_options): Use add_cmd to install "maint
5535         show test-options-completion-result".
5536
5537 2019-07-03  Pedro Alves  <palves@redhat.com>
5538
5539         * NEWS (New commands): Mention "with" and "maint with".
5540         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5541         (with_command, with_command_completer): New.
5542         (pipe_command): Adjust to new repeat_previous
5543         interface.
5544         (_initialize_cli_cmds): Install the "with" command and its "w"
5545         alias.
5546         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5547         declarations.
5548         * cli/cli-setshow.c (parse_cli_var_uinteger)
5549         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5550         argument strings for all var_types.
5551         (get_setshow_command_value_string): New, factored out from ...
5552         (do_show_command): ... this.
5553         * cli/cli-setshow.h: Include <string>.
5554         (get_setshow_command_value_string): Declare.
5555         * command.h (repeat_previous): Now returns const char *.  Adjust
5556         comment.
5557         * maint.c: Include "cli/cli-cmds.h".
5558         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5559         (_initialize_maint_cmds): Register the "maintenance with" command.
5560         * top.c (repeat_previous): Move bits from pipe_command here:
5561         Return the saved command line, if any; error out if there's no
5562         command to relaunch.
5563
5564 2019-07-03  Pedro Alves  <palves@redhat.com>
5565
5566         * NEWS (New commands): Mention "maint set/show test-settings"
5567         instead of "maint test-settings".
5568         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5569         (maintenance_test_settings_set_list): Rename to ...
5570         (maintenance_set_test_settings_list): ... this.
5571         (maintenance_test_settings_show_list): Rename to  ...
5572         (maintenance_show_test_settings_list): ... this.
5573         (maintenance_test_settings_cmd): Delete.
5574         (maintenance_test_settings_set_cmd): ...
5575         (maintenance_set_test_settings_cmd): ... this.
5576         (maintenance_test_settings_show_cmd): ...
5577         (maintenance_show_test_settings_cmd): ... this.
5578         (maintenance_test_settings_show_value_cmd):
5579         (maintenance_show_test_settings_value_cmd): ... this.
5580         (_initialize_maint_test_settings): No longer install the "maint
5581         test-settings" prefix command.  Rename "maint test-settings set"
5582         to "maint set test-settings", and "maint test-settings show" to
5583         "maint show test-settings".  Adjust all subcommands.
5584
5585 2019-07-03  Pedro Alves  <palves@redhat.com>
5586
5587         * maint-test-settings.c: Fix file's intro comment.  Replace all
5588         references to "test-options" with references to "test-settings",
5589         in comments.
5590
5591 2019-07-03  Pedro Alves  <palves@redhat.com>
5592
5593         * maint-test-settings.c (maintenance_test_settings_xxx)
5594         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5595         New.
5596         (maintenance_test_settings_enums): Use them.
5597         (maintenance_test_settings_enum): Default to
5598         maintenance_test_settings_xxx.
5599         (_initialize_maint_test_settings): Initialize
5600         MAINTENANCE_TEST_SETTINGS_FILENAME.
5601
5602 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5603
5604         * breakpoint.h (remove_breakpoints_inf): Change return type to
5605         void, move function documentation here.
5606         * breakpoint.c (remove_breakpoints_inf): Change return type to
5607         void, move function documentation to header.
5608
5609 2019-07-02  Pedro Alves  <palves@redhat.com>
5610
5611         * NEWS (Completion improvements): Mention "info threads".
5612         * thread.c (struct info_threads_opts, info_threads_option_defs)
5613         (make_info_threads_options_def_group): New.
5614         (info_threads_command): Use gdb::option::process_options.
5615         (info_threads_command_completer): New.
5616         (_initialize_thread): Use gdb::option::build_help to build the
5617         help text for "info threads".
5618
5619 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5620
5621         * defs.h (generic_load): Move from here...
5622         * symfile.h (generic_load): ... to here.  Rename name parameter
5623         to args.
5624         * symfile.c (generic_load): Add comment.
5625
5626 2019-07-01  Tom Tromey  <tromey@adacore.com>
5627
5628         * dwarf2read.c
5629         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5630         declaration of without_params.  Fix formatting.
5631
5632 2019-07-01  Tom Tromey  <tromey@adacore.com>
5633
5634         * ada-exp.y (find_primitive_type): Update.
5635         * ada-lang.h (ada_lookup_symbol): Update.
5636         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5637         parameter.
5638         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5639
5640 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5641
5642         PR breakpoints/24541
5643         * gdbarch.c: Regenerate.
5644         * gdbarch.h: Regenerate.
5645         * gdbarch.sh: Add 'stap_adjust_register'.
5646         * i386-tdep.c: Include '<unordered_set>'.
5647         (i386_stap_adjust_register): New function.
5648         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5649         * stap-probe.c (stap_parse_register_operand): Call
5650         'gdbarch_stap_adjust_register'.
5651
5652 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5653
5654         PR python/24742
5655         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5656         * python/python.c (do_start_initialization): Use 'xmalloc'
5657         instead of 'PyMem_Malloc'.
5658
5659 2019-06-28  Tom Tromey  <tromey@adacore.com>
5660
5661         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5662         for Ada.
5663
5664 2019-06-27  Tom Tromey  <tromey@adacore.com>
5665
5666         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5667         objfile_key.
5668         (arm_find_mapping_symbol, arm_record_special_symbol)
5669         (_initialize_arm_tdep): Update.
5670         (arm_objfile_data_free): Remove.
5671
5672 2019-06-27  Tom Tromey  <tromey@adacore.com>
5673
5674         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5675         to cp_print_static_field.
5676
5677 2019-06-26  Tom Tromey  <tromey@adacore.com>
5678
5679         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5680         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5681         declare.
5682
5683 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5684
5685         * features/aarch64-core.c (create_feature_aarch64_core):
5686         Regenerate.
5687         * features/aarch64-core.xml: Add cpsr flags.
5688
5689 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5690
5691         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5692         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5693
5694 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5695
5696         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5697         field.
5698         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5699         use.
5700         (arm_record_special_symbol): Don't insert new symbol in sorted
5701         position, push it at the end.
5702
5703 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5704
5705         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5706         (arm_mapping_symbol_s): Remove.
5707         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5708         (arm_mapping_symbol_vec): New typedef.
5709         (struct arm_per_objfile): Add constructor.
5710         <section_maps>: Change type to
5711         std::unique_ptr<arm_mapping_symbol_vec[]>.
5712         (arm_compare_mapping_symbols): Remove.
5713         (arm_find_mapping_symbol): Adjust to section_maps type change.
5714         (arm_objfile_data_free): Call delete on arm_per_objfile.
5715         (arm_record_special_symbol): Adjust to section_maps type change.
5716         Allocate arm_per_objfile with new.
5717
5718 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5719
5720         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5721         with the command prefix.
5722
5723 2019-06-25  Tom Tromey  <tom@tromey.com>
5724
5725         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5726         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5727
5728 2019-06-25  Tom Tromey  <tom@tromey.com>
5729
5730         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5731         type.
5732         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5733         protected.
5734
5735 2019-06-25  Tom Tromey  <tom@tromey.com>
5736
5737         * tui/tui-winsource.c
5738         (tui_source_window_base::set_is_exec_point_at): Add check against
5739         LOA_ADDRESS.
5740
5741 2019-06-25  Tom Tromey  <tom@tromey.com>
5742
5743         * tui/tui-source.c (tui_set_source_content): Don't check before
5744         xfree.
5745         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5746
5747 2019-06-25  Tom Tromey  <tom@tromey.com>
5748
5749         * tui/tui-winsource.h (tui_update_source_window_as_is)
5750         (tui_alloc_source_buffer, tui_line_is_displayed)
5751         (tui_addr_is_displayed): Change type of win_info.
5752         * tui/tui-winsource.c (tui_update_source_window_as_is)
5753         (tui_clear_source_content, tui_show_source_line)
5754         (tui_show_source_content, tui_source_window_base::refill)
5755         (tui_source_window_base::set_is_exec_point_at)
5756         (tui_source_window_base::set_is_exec_point_at)
5757         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5758         (tui_alloc_source_buffer, tui_line_is_displayed)
5759         (tui_addr_is_displayed): Change type of win_info.  Update.
5760         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5761         (tui_source_window_base::do_make_visible_with_new_height):
5762         Update.
5763         * tui/tui-source.c (tui_set_source_content)
5764         (tui_set_source_content_nil)
5765         (tui_source_window::do_scroll_vertical): Update.
5766         * tui/tui-layout.c (show_layout): Update.
5767         * tui/tui-disasm.c (tui_set_disassem_content)
5768         (tui_disasm_window::do_scroll_vertical): Update.
5769         * tui/tui-data.h (tui_win_content): Remove.
5770         (struct tui_gen_win_info) <content, content_size>: Remove.
5771         (struct tui_source_element): Add initializers and destructor.
5772         (union tui_which_element, struct tui_win_element): Remove.
5773         (struct tui_source_window_base) <content>: New field.
5774         (struct tui_data_window): Remove destructor.
5775         (tui_alloc_content, tui_free_win_content)
5776         (tui_free_all_source_wins_content): Don't declare.
5777         * tui/tui-data.c (tui_initialize_static_data): Update.
5778         (init_content_element, tui_alloc_content): Remove.
5779         (~tui_gen_win_info): Update.
5780         (~tui_data_window, tui_free_all_source_wins_content)
5781         (tui_free_win_content, free_content, free_content_elements):
5782         Remove.
5783
5784 2019-06-25  Tom Tromey  <tom@tromey.com>
5785
5786         * tui/tui-winsource.h (tui_clear_source_content)
5787         (tui_erase_source_content, tui_show_source_content): Change type
5788         of win_info.
5789         * tui/tui-winsource.c (tui_clear_source_content)
5790         (tui_erase_source_content, tui_show_source_content): Change type
5791         of win_info.
5792         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5793         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5794         win_info.
5795         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5796         win_info.
5797         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5798
5799 2019-06-25  Tom Tromey  <tom@tromey.com>
5800
5801         * tui/tui-winsource.c (tui_clear_source_content)
5802         (tui_source_window_base::set_is_exec_point_at): Update.
5803         * tui/tui-source.c (tui_set_source_content_nil): Update.
5804         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5805         a bool.
5806         * tui/tui-data.c (init_content_element): Update.
5807
5808 2019-06-25  Tom Tromey  <tom@tromey.com>
5809
5810         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5811         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5812         * tui/tui-layout.c (init_and_make_win): Update.
5813         * tui/tui.h (enum tui_win_type): Update.
5814         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5815         tui_win_is_auxillary.
5816         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5817         tui_win_is_auxillary.
5818
5819 2019-06-25  Tom Tromey  <tom@tromey.com>
5820
5821         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5822         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5823         (tui_delete_data_content_windows, tui_display_all_data)
5824         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5825         Update.
5826         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5827         * tui/tui-regs.c (tui_last_regs_line_no)
5828         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5829         (tui_show_registers): Update.
5830         (tui_show_register_group): Return void.  Update.
5831         (tui_display_registers_from, tui_display_reg_element_at_line)
5832         (tui_display_registers_from_line, tui_check_register_values):
5833         Update.
5834         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5835         member.
5836         (struct tui_data_window) <regs_content>: Now a std::vector.
5837         <regs_content_count>: Remove.
5838         (tui_add_content_elements, tui_free_data_content): Don't declare.
5839         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5840         (init_content_element): Remove DATA_WIN case.  Add assert.
5841         (tui_add_content_elements): Remove.
5842         (tui_data_window): Update.
5843         (tui_free_data_content): Remove.
5844         (free_content_elements): Remove DATA_WIN case.
5845
5846 2019-06-25  Tom Tromey  <tom@tromey.com>
5847
5848         * tui/tui-data.c (tui_data_item_window): Update.
5849         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5850         * tui/tui-windata.c (tui_display_all_data)
5851         (tui_display_data_from_line): Update.
5852         (tui_check_data_values): Remove.
5853         * tui/tui-regs.c (tui_show_register_group)
5854         (tui_display_reg_element_at_line): Update.
5855         * tui/tui-hooks.c (tui_register_changed)
5856         (tui_refresh_frame_and_register_information): Call
5857         tui_check_register_values.
5858         * tui/tui-data.h (struct tui_data_window) <data_content,
5859         data_content_count, data_type>: Remove.
5860         (enum tui_data_type): Remove.
5861
5862         * tui/tui-data.c (tui_data_window::clear_detail)
5863         (~tui_data_window): Update.
5864
5865 2019-06-25  Tom Tromey  <tom@tromey.com>
5866
5867         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5868         declare.
5869         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5870         Rename from tui_first_data_item_displayed.  Update.
5871         (tui_data_window::refresh_all)
5872         (tui_data_window::do_scroll_vertical): Update.
5873         * tui/tui-data.h (struct tui_data_window)
5874         <first_data_item_displayed>: Declare new method.
5875
5876 2019-06-25  Tom Tromey  <tom@tromey.com>
5877
5878         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5879         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5880         contents...
5881         (tui_initialize_static_data): ...here.
5882
5883 2019-06-25  Tom Tromey  <tom@tromey.com>
5884
5885         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5886         (tui_display_registers_from, tui_check_register_values): Update.
5887         (tui_display_register): Remove win_info parameter; update.
5888         (tui_get_register): Change type of parameters.
5889         * tui/tui-data.h (struct tui_data_element): Remove.
5890         (union tui_which_element) <data>: Remove.
5891         <data_window>: Change type.
5892         (struct tui_data_item_window): New.
5893         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5894         case.  Add assert.
5895         (~tui_data_item_window): New destructor.
5896         (free_content_elements): Remove DATA_ITEM_WIN case.
5897
5898 2019-06-25  Tom Tromey  <tom@tromey.com>
5899
5900         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5901         Remove.
5902
5903 2019-06-25  Tom Tromey  <tom@tromey.com>
5904
5905         * tui/tui-data.h (struct tui_command_element): Remove.
5906         (union tui_which_element) <command>: Remove.
5907         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5908         assert.
5909         (free_content_elements): Remove CMD_WIN case.
5910
5911 2019-06-25  Tom Tromey  <tom@tromey.com>
5912
5913         * tui/tui-layout.c (tui_set_layout): Update.
5914         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5915         * tui/tui-data.c (layout_def): Update.
5916
5917 2019-06-25  Tom Tromey  <tom@tromey.com>
5918
5919         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5920         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5921         (tui_source_window_base::set_new_height): Update.
5922         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5923         Update.
5924         (tui_set_locator_fullname, tui_set_locator_info)
5925         (tui_show_frame_info): Update.
5926         * tui/tui-source.c (tui_set_source_content)
5927         (tui_source_is_displayed): Update.
5928         * tui/tui-layout.c (show_source_disasm_command, show_data)
5929         (show_source_or_disasm_and_command): Update.
5930         * tui/tui-disasm.c (tui_set_disassem_content)
5931         (tui_get_begin_asm_address): Update.
5932         * tui/tui-data.h (struct tui_locator_element): Remove.
5933         (union tui_which_element) <locator>: Remove.
5934         (struct tui_locator_window): New.
5935         (tui_locator_win_info_ptr): Change return type.
5936         * tui/tui-data.c (_locator): Change type.
5937         (tui_locator_win_info_ptr): Change return type.
5938         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5939         (tui_alloc_content): Add assert.
5940
5941 2019-06-25  Tom Tromey  <tom@tromey.com>
5942
5943         * tui/tui-winsource.c
5944         (tui_exec_info_window::maybe_allocate_content): New method.
5945         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5946         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5947         (make_source_or_disasm_window): Add cast.
5948         * tui/tui-data.h (union tui_which_element) <simple_string>:
5949         Remove.
5950         (struct tui_source_info): New.
5951         (struct tui_source_window_base) <execution_info>: Change type.
5952         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5953         case, and add assert.
5954         (tui_alloc_content): Add assert.
5955
5956 2019-06-25  Tom Tromey  <tom@tromey.com>
5957
5958         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5959         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5960         * tui/tui-data.c (tui_alloc_win_info): Remove.
5961
5962 2019-06-25  Tom Tromey  <tom@tromey.com>
5963
5964         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5965         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5966         can_highlight.
5967
5968 2019-06-25  Tom Tromey  <tom@tromey.com>
5969
5970         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5971         make_visible_with_new_height method.
5972         (tui_win_info::make_visible_with_new_height): New method.
5973         (tui_source_window_base::do_make_visible_with_new_height)
5974         (tui_data_window::do_make_visible_with_new_height)
5975         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5976         (make_visible_with_new_height): Remove.
5977         (tui_resize_all, tui_adjust_win_heights): Use
5978         make_visible_with_new_height method.
5979         * tui/tui-data.h (struct tui_win_info)
5980         <do_make_visible_with_new_height, make_visible_with_new_height>:
5981         New methods.
5982         (struct tui_source_window_base, struct tui_data_window)
5983         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5984         methods.
5985
5986 2019-06-25  Tom Tromey  <tom@tromey.com>
5987
5988         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5989         method.
5990         (update_tab_width): Call update_tab_width method.
5991         * tui/tui-data.h (struct tui_win_info)
5992         (struct tui_source_window_base) <update_tab_width>: New methods.
5993
5994 2019-06-25  Tom Tromey  <tom@tromey.com>
5995
5996         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5997         parameter.
5998         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5999         parameter.
6000         (tui_gen_win_info::make_visible): Update.
6001         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6002         parameter.
6003         * tui/tui-data.h (enum tui_box): New enum.
6004         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6005
6006 2019-06-25  Tom Tromey  <tom@tromey.com>
6007
6008         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6009         init_and_make_win for EXEC_INFO_WIN.
6010         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6011         longer inline.
6012         (struct tui_win_info) <~tui_win_info>: Inline.
6013         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6014         Don't declare.
6015         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6016         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6017         Remove.
6018         (tui_initialize_static_data): Update.
6019         (~tui_gen_win_info): Handle more cleanup here.
6020         (~tui_source_window_base): Delete "execution_info".
6021         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6022
6023 2019-06-25  Tom Tromey  <tom@tromey.com>
6024
6025         * tui/tui-layout.c (make_command_window): Don't set
6026         can_highlight.
6027         (show_source_disasm_command): Call the reset method.
6028         (show_data): Don't set can_highlight.  Call the reset method.
6029         (tui_gen_win_info::reset): Rename from init_gen_win_info
6030         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6031         (show_source_or_disasm_and_command): Call the reset method.
6032         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6033         (struct tui_cmd_window): Set can_highlight.
6034
6035 2019-06-25  Tom Tromey  <tom@tromey.com>
6036
6037         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6038         from make_visible.
6039         (tui_make_visible, tui_make_invisible): Rewrite.
6040         (tui_win_info::make_visible): Remove.
6041         (tui_source_window_base::make_visible): Update.
6042         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6043         method.  Moved from...
6044         (struct tui_win_info) <make_visible>: ...here.
6045
6046 2019-06-25  Tom Tromey  <tom@tromey.com>
6047
6048         * tui/tui-winsource.c
6049         (tui_source_window_base::do_scroll_horizontal): Remove direction
6050         parameter.
6051         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6052         direction parameter.
6053         * tui/tui-win.c (tui_win_info::forward_scroll)
6054         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6055         (tui_win_info::right_scroll): Update.
6056         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6057         direction parameter.
6058         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6059         direction parameter.
6060         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6061         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6062         Remove direction parameter.
6063         (struct tui_source_window_base, struct tui_source_window)
6064         (struct tui_disasm_window, struct tui_data_window)
6065         (struct tui_cmd_window): Update.
6066
6067 2019-06-25  Tom Tromey  <tom@tromey.com>
6068
6069         * tui/tui-winsource.h (tui_set_exec_info_content)
6070         (tui_show_exec_info_content, tui_erase_exec_info_content)
6071         (tui_clear_exec_info_content, tui_update_exec_info): Change
6072         argument to tui_source_window_base.
6073         * tui/tui-winsource.c (tui_set_exec_info_content)
6074         (tui_show_exec_info_content, tui_erase_exec_info_content)
6075         (tui_clear_exec_info_content, tui_update_exec_info): Change
6076         argument to tui_source_window_base.
6077
6078 2019-06-25  Tom Tromey  <tom@tromey.com>
6079
6080         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6081         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6082
6083 2019-06-25  Tom Tromey  <tom@tromey.com>
6084
6085         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6086         check.
6087
6088 2019-06-25  Tom Tromey  <tom@tromey.com>
6089
6090         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6091         type to void.
6092         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6093         type to void.
6094         * tui/tui-source.c (tui_set_source_content): Update.
6095         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6096
6097 2019-06-25  Tom Tromey  <tom@tromey.com>
6098
6099         * tui/tui-win.c (window_name_completer, tui_set_focus)
6100         (tui_all_windows_info): Use name method.
6101         * tui/tui-data.h (struct tui_gen_win_info)
6102         (struct tui_source_window, struct tui_disasm_window)
6103         (struct tui_data_window, struct tui_cmd_window) <name>: New
6104         method.
6105         (tui_win_name): Don't declare.
6106         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6107         (tui_win_name): Remove.
6108
6109 2019-06-25  Tom Tromey  <tom@tromey.com>
6110
6111         * tui/tui-winsource.h (tui_update_source_window)
6112         (tui_update_source_window_as_is): Change parameter type.
6113         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6114         to be a tui_source_window_base.
6115         (tui_update_source_window_as_is): Likewise.
6116         * tui/tui-win.c (make_visible_with_new_height): Update.
6117
6118 2019-06-25  Tom Tromey  <tom@tromey.com>
6119
6120         * tui/tui-winsource.c (tui_erase_source_content)
6121         (tui_show_source_content, tui_show_exec_info_content)
6122         (tui_erase_exec_info_content): Use refresh_window method.
6123         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6124         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6125         from tui_refresh_win.
6126         (tui_data_window::refresh_window): New method.
6127         (tui_win_info::refresh, tui_source_window_base::refresh)
6128         (tui_refresh_all): Use refresh_window method.
6129         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6130         method.
6131         * tui/tui-regs.c (tui_display_register): Call refresh_window
6132         method.
6133         * tui/tui-layout.c (show_source_disasm_command)
6134         (show_source_or_disasm_and_command): Call refresh_window method.
6135         * tui/tui-data.h (struct tui_gen_win_info)
6136         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6137         New method.
6138
6139 2019-06-25  Tom Tromey  <tom@tromey.com>
6140
6141         * tui/tui.c (tui_rl_other_window, tui_enable)
6142         (tui_is_window_visible, tui_get_command_dimension): Update.
6143         * tui/tui-winsource.c (tui_update_source_window_as_is)
6144         (tui_clear_source_content, tui_erase_source_content)
6145         (tui_show_source_line, tui_source_window_base::refill)
6146         (tui_source_window_base::do_scroll_horizontal)
6147         (tui_source_window_base::set_is_exec_point_at)
6148         (tui_update_breakpoint_info, tui_set_exec_info_content)
6149         (tui_alloc_source_buffer, tui_line_is_displayed)
6150         (tui_addr_is_displayed): Update.
6151         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6152         (tui_check_and_display_highlight_if_needed)
6153         (tui_win_info::make_visible, tui_win_info::refresh)
6154         (tui_refresh_all): Update.
6155         * tui/tui-windata.c (tui_first_data_item_displayed)
6156         (tui_delete_data_content_windows, tui_erase_data_content)
6157         (tui_display_all_data, tui_data_window::refresh_all)
6158         (tui_check_data_values): Update.
6159         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6160         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6161         (tui_win_info::backward_scroll, tui_refresh_all_win)
6162         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6163         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6164         (tui_source_window_base::set_new_height)
6165         (tui_data_window::set_new_height)
6166         (make_invisible_and_set_new_height)
6167         (make_visible_with_new_height, new_height_ok)
6168         (parse_scrolling_args): Update.
6169         * tui/tui-stack.c (tui_show_frame_info): Update.
6170         * tui/tui-source.c (tui_set_source_content)
6171         (tui_set_source_content_nil, tui_source_is_displayed)
6172         (tui_source_window::do_scroll_vertical): Update.
6173         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6174         (tui_display_registers_from, tui_display_reg_element_at_line)
6175         (tui_check_register_values, tui_reg_command): Update.
6176         * tui/tui-layout.c (tui_default_win_height)
6177         (show_source_disasm_command, show_data, init_and_make_win)
6178         (show_source_or_disasm_and_command): Update.
6179         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6180         (tui_redisplay_readline, tui_mld_flush)
6181         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6182         (tui_getc): Update.
6183         * tui/tui-disasm.c (tui_set_disassem_content)
6184         (tui_disasm_window::do_scroll_vertical): Update.
6185         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6186         Now virtual.
6187         (struct tui_win_info): Derive from tui_gen_win_info.
6188         <~tui_win_info>: Mark as override.
6189         <generic>: Remove member.
6190         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6191         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6192         (~tui_data_window, ~tui_win_info)
6193         (tui_free_all_source_wins_content): Update.
6194         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6195
6196 2019-06-25  Tom Tromey  <tom@tromey.com>
6197
6198         * tui/tui-layout.c (init_and_make_win): Use new.
6199         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6200         destructor, initializers.
6201         (tui_alloc_generic_win_info): Don't declare.
6202         * tui/tui-data.c (_locator): Add argument to constructor.
6203         (source_win, disasm_win): New globals.
6204         (exec_info): Remove.
6205         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6206         Update.
6207         (tui_alloc_generic_win_info): Remove.
6208         (init_content_element): Use new.
6209         (tui_win_info::tui_win_info): Update.
6210         (free_content_elements) <case DATA_WIN>: Use delete.
6211
6212 2019-06-25  Tom Tromey  <tom@tromey.com>
6213
6214         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6215         * tui/tui-windata.c (tui_first_data_item_displayed)
6216         (tui_delete_data_content_windows): Update.
6217         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6218         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6219         (tui_display_registers_from, tui_check_register_values): Update.
6220         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6221         pointer.
6222         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6223         window.
6224         (tui_free_data_content): Update.
6225         (free_content_elements) <case DATA_WIN>: Free the window.
6226
6227 2019-06-25  Tom Tromey  <tom@tromey.com>
6228
6229         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6230         Update.
6231         * tui/tui-layout.c (make_command_window)
6232         (show_source_disasm_command, show_data, init_and_make_win)
6233         (show_source_or_disasm_and_command): Update.
6234         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6235         method.
6236         <can_highight, is_highlighted>: Now bool.
6237         (tui_set_win_highlight): Don't declare.
6238         * tui/tui-data.c (tui_set_win_highlight): Remove.
6239
6240 2019-06-25  Tom Tromey  <tom@tromey.com>
6241
6242         * tui/tui-wingeneral.c (make_visible): Remove check of window
6243         type.
6244
6245 2019-06-25  Tom Tromey  <tom@tromey.com>
6246
6247         * tui/tui-win.c (tui_win_info::max_height)
6248         (tui_cmd_window::max_height): New methods.
6249         (new_height_ok): Call max_height.
6250         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6251         <max_height>: New method.
6252
6253 2019-06-25  Tom Tromey  <tom@tromey.com>
6254
6255         * tui/tui-win.c (tui_source_window_base::set_new_height)
6256         (tui_data_window::set_new_height): New methods.
6257         (make_invisible_and_set_new_height): Call set_new_height method.
6258         * tui/tui-data.h (struct tui_win_info)
6259         (struct tui_source_window_base, struct tui_data_window)
6260         <set_new_height>: New method.
6261
6262 2019-06-25  Tom Tromey  <tom@tromey.com>
6263
6264         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6265         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6266         tui_refresh_data_win.
6267         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6268         method.
6269         (tui_refresh_all_win): Call the refresh_all method.
6270         (tui_set_focus): Likewise.
6271         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6272         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6273         Likewise.
6274
6275 2019-06-25  Tom Tromey  <tom@tromey.com>
6276
6277         * tui/tui-winsource.h (tui_refill_source_window)
6278         (tui_set_is_exec_point_at): Don't declare.
6279         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6280         (tui_source_window_base::refill): Rename from
6281         tui_refill_source_window.
6282         (tui_source_window_base::do_scroll_horizontal): Update.
6283         (tui_source_window_base::set_is_exec_point_at): Rename from
6284         tui_set_is_exec_point_at.
6285         (tui_update_all_breakpoint_info): Update.
6286         * tui/tui-stack.c (tui_show_frame_info): Update.
6287         * tui/tui-layout.c (show_data): Add cast.
6288         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6289         * tui/tui-data.h (struct tui_source_window_base) <refill,
6290         set_is_exec_point_at>: New methods.
6291         (tui_source_windows, tui_add_to_source_windows): Update types.
6292         (tui_add_to_source_windows): Remove redundant declaration.
6293         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6294         (tui_source_windows): Change return type.
6295         (tui_clear_source_windows_detail): Update.
6296         (tui_add_to_source_windows): Change type of parameter.
6297         (tui_free_all_source_wins_content): Update.
6298
6299 2019-06-25  Tom Tromey  <tom@tromey.com>
6300
6301         * tui/tui-wingeneral.c (tui_win_info::refresh)
6302         (tui_source_window_base::refresh): New methods.
6303         (tui_refresh_all): Call the refresh method.
6304         * tui/tui-data.h (struct tui_win_info)
6305         (struct tui_source_window_base) <refresh>: New method.
6306
6307 2019-06-25  Tom Tromey  <tom@tromey.com>
6308
6309         * tui/tui.h (tui_is_window_visible): Return bool.
6310         * tui/tui.c (tui_is_window_visible): Return bool.
6311         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6312         (tui_make_visible, tui_make_invisible)
6313         (tui_win_info::make_visible)
6314         (tui_source_window_base::make_visible, make_all_visible)
6315         (tui_make_all_visible, tui_make_all_invisible): Update.
6316         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6317         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6318         bool.
6319         (struct tui_win_info, struct tui_source_window_base)
6320         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6321         * tui/tui-data.c (tui_init_generic_part): Update.
6322
6323 2019-06-25  Tom Tromey  <tom@tromey.com>
6324
6325         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6326         (tui_source_window_base::make_visible): New methods.
6327         (make_all_visible): Make method call.
6328         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6329         (struct tui_source_window_base, struct tui_cmd_window): Override
6330         make_visible.
6331         (tui_win_is_source_type): Don't declare.
6332         * tui/tui-data.c (tui_win_is_source_type): Remove.
6333
6334 2019-06-25  Tom Tromey  <tom@tromey.com>
6335
6336         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6337         NULL check.
6338
6339 2019-06-25  Tom Tromey  <tom@tromey.com>
6340
6341         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6342         Inline constructor.  Add initializers for members.
6343         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6344         constructors; now inline in class.
6345
6346 2019-06-25  Tom Tromey  <tom@tromey.com>
6347
6348         * tui/tui-regs.c (tui_show_registers): Update.
6349         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6350         bool.
6351         * tui/tui-data.c (tui_data_window::clear_detail)
6352         (tui_data_window): Update.
6353
6354 2019-06-25  Tom Tromey  <tom@tromey.com>
6355
6356         * tui/tui-windata.c (tui_display_all_data)
6357         (tui_display_data_from_line, tui_display_data_from)
6358         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6359         Update.
6360         * tui/tui-regs.c (tui_last_regs_line_no)
6361         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6362         (tui_show_registers, tui_show_register_group)
6363         (tui_display_registers_from, tui_display_reg_element_at_line)
6364         (tui_display_registers_from_line, tui_check_register_values)
6365         (tui_reg_next, tui_reg_prev): Update.
6366         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6367         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6368         tui_data_window.
6369         (struct tui_win_info) <detail>: Remove.  Add new fields from
6370         tui_data_info.
6371         (TUI_DATA_WIN): Add cast.
6372         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6373         (~tui_data_window): Simplify.
6374
6375 2019-06-25  Tom Tromey  <tom@tromey.com>
6376
6377         * tui/tui-layout.c (show_source_disasm_command)
6378         (show_source_or_disasm_and_command): Update.
6379         * tui/tui-io.c (update_cmdwin_start_line)
6380         (tui_redisplay_readline): Update.
6381         * tui/tui-data.h (struct tui_command_info): Remove.
6382         (struct tui_win_info) <detail>: Remove command_info member.
6383         (struct tui_data_window) <start_line>: New member, from
6384         tui_command_info.
6385         (TUI_CMD_WIN): Add casts.
6386
6387 2019-06-25  Tom Tromey  <tom@tromey.com>
6388
6389         * tui/tui-winsource.c (tui_update_source_window)
6390         (tui_refill_source_window)
6391         (tui_source_window_base::do_scroll_horizontal)
6392         (tui_update_breakpoint_info, tui_set_exec_info_content)
6393         (tui_show_exec_info_content, tui_erase_exec_info_content)
6394         (tui_clear_exec_info_content): Update.
6395         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6396         Update.
6397         * tui/tui-win.c (make_invisible_and_set_new_height)
6398         (make_visible_with_new_height): Update.
6399         * tui/tui-source.c (tui_set_source_content)
6400         (tui_show_symtab_source): Update.
6401         * tui/tui-layout.c (extract_display_start_addr)
6402         (show_source_disasm_command, show_data)
6403         (make_source_or_disasm_window)
6404         (show_source_or_disasm_and_command): Update.
6405         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6406         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6407         "gdbarch".
6408         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6409         to tui_source_window_base.
6410         (struct tui_win_info) <detail>: Remove source_info member.
6411         (struct tui_source_window_base) <has_locator>: Inline.
6412         Move contents from tui_source_info; rename has_locator member to
6413         m_has_locator.
6414         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6415         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6416         header file.
6417         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6418         Simplify.
6419         (tui_free_all_source_wins_content): Cast to
6420         tui_source_window_base.
6421
6422 2019-06-25  Tom Tromey  <tom@tromey.com>
6423
6424         * tui/tui-win.c (make_invisible_and_set_new_height)
6425         (make_visible_with_new_height): Call has_locator method.
6426         * tui/tui-layout.c (show_source_disasm_command, show_data)
6427         (show_source_or_disasm_and_command): Update for bool change.
6428         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6429         (tui_win_info) <has_locator>: New method.
6430         (struct tui_source_window_base) <has_locator>: New method.
6431         (tui_win_has_locator): Don't declare.
6432         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6433         from tui_win_has_locator.
6434         (tui_source_window_base): Use false, not FALSE.
6435
6436 2019-06-25  Tom Tromey  <tom@tromey.com>
6437
6438         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6439         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6440         clear_detail method directly.
6441         (tui_clear_win_detail): Remove.
6442
6443 2019-06-25  Tom Tromey  <tom@tromey.com>
6444
6445         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6446         "this", not TUI_DISASM_WIN.
6447
6448 2019-06-25  Tom Tromey  <tom@tromey.com>
6449
6450         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6451         declare.
6452         * tui/tui-winsource.c
6453         (tui_source_window_base::do_scroll_horizontal): Rename from
6454         tui_horizontal_source_scroll.
6455         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6456         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6457         from tui_vertical_data_scroll.
6458         * tui/tui-win.h (tui_scroll): Don't declare.
6459         * tui/tui-win.c (tui_win_info::forward_scroll)
6460         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6461         (tui_win_info::right_scroll): Rename and update.
6462         (tui_scroll_forward_command, tui_scroll_backward_command)
6463         (tui_scroll_left_command, tui_scroll_right_command): Update.
6464         (tui_scroll): Remove.
6465         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6466         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6467         from tui_vertical_source_scroll.
6468         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6469         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6470         from tui_vertical_disassem_scroll.
6471         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6472         do_scroll_horizontal>: New methods.
6473         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6474         Likewise.
6475         (struct tui_source_window_base): Add do_scroll_horizontal.
6476         (struct tui_source_window, struct tui_disasm_window): Add
6477         do_scroll_vertical.
6478         (struct tui_data_window, struct tui_cmd_window): Add
6479         do_scroll_horizontal and do_scroll_vertical.
6480         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6481
6482 2019-06-25  Tom Tromey  <tom@tromey.com>
6483
6484         * tui/tui-data.h (struct tui_source_window_base): New struct.
6485         (struct tui_source_window): Derive from tui_source_window_base.
6486         (struct tui_disasm_window): New struct.
6487         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6488         from tui_source_window::clear_detail.
6489         (tui_source_window_base): Rename from tui_source_window.
6490         (~tui_source_window_base): Rename from ~tui_source_window.
6491         (tui_alloc_win_info): Create a tui_disasm_window.
6492
6493 2019-06-25  Tom Tromey  <tom@tromey.com>
6494
6495         * tui/tui-data.h (struct tui_source_window)
6496         (struct tui_data_window): Declare destructors.
6497         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6498         destructors.
6499         (tui_win_info): Simplify.
6500
6501 2019-06-25  Tom Tromey  <tom@tromey.com>
6502
6503         * tui/tui-winsource.c (tui_display_main)
6504         (tui_update_source_windows_with_addr)
6505         (tui_update_all_breakpoint_info): Update.
6506         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6507         (new_height_ok, parse_scrolling_args): Update.
6508         * tui/tui-stack.c (tui_show_frame_info): Update.
6509         * tui/tui-data.h (struct tui_list): Remove.
6510         (tui_source_windows): Return a reference to a std::vector.
6511         * tui/tui-data.c (source_windows): Now a std::vector.
6512         (tui_source_windows): Change return type.
6513         (tui_clear_source_windows): Rewrite.
6514         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6515         (tui_free_all_source_wins_content): Rewrite.
6516
6517 2019-06-25  Tom Tromey  <tom@tromey.com>
6518
6519         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6520         (struct tui_data_window, struct tui_cmd_window): Declare
6521         clear_detail method.
6522         * tui/tui-data.c (tui_source_window::clear_detail)
6523         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6524         methods.
6525         (tui_clear_win_detail): Simplify.
6526
6527 2019-06-25  Tom Tromey  <tom@tromey.com>
6528
6529         * tui/tui-layout.c (make_source_window, make_disasm_window)
6530         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6531         Return the new window.
6532         (show_source_disasm_command, show_data)
6533         (show_source_or_disasm_and_command): Update.
6534
6535 2019-06-25  Tom Tromey  <tom@tromey.com>
6536
6537         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6538         parameter.  Return the new window.
6539         (show_source_disasm_command): Update and remove NULL check.
6540         (show_source_or_disasm_and_command): Update.
6541
6542 2019-06-25  Tom Tromey  <tom@tromey.com>
6543
6544         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6545
6546 2019-06-25  Tom Tromey  <tom@tromey.com>
6547
6548         * tui/tui-data.h (struct tui_win_info): Make constructor
6549         protected.  Make destructor virtual.  Add initializers.
6550         (tui_source_window, tui_data_window, tui_cmd_window): New
6551         classes.
6552         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6553         constructor.  Add "type" parameter.
6554         (tui_source_window, tui_data_window, tui_cmd_window): New
6555         constructors.
6556         (tui_alloc_win_info): Instantiate the appropriate subclass.
6557
6558 2019-06-25  Tom Tromey  <tom@tromey.com>
6559
6560         * tui/tui-win.c (tui_resize_all): Use delete.
6561         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6562         destructor.
6563         (tui_free_window): Don't declare.
6564         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6565         Update.
6566
6567 2019-06-25  Tom Tromey  <tom@tromey.com>
6568
6569         * tui/tui-data.h (struct tui_win_info): Add constructor.
6570         * tui/tui-data.c (tui_alloc_win_info): Use new.
6571         (tui_free_window): Use delete.
6572
6573 2019-06-22  Tom Tromey  <tom@tromey.com>
6574
6575         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6576         declare.
6577         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6578
6579 2019-06-22  Tom Tromey  <tom@tromey.com>
6580
6581         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6582         declare.
6583         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6584
6585 2019-06-22  Tom de Vries  <tdevries@suse.de>
6586
6587         * dwarf2read.c (create_addrmap_from_aranges)
6588         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6589         instead of '%zu'.
6590
6591 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6592
6593         * dwarf2read.h (dwarf2_section_info_def): Remove.
6594         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6595         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6596         std::vector<dwarf2_section_info>.
6597         (struct dwo_file) <~dwo_file>: Remove.
6598         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6599         types field.
6600         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6601         (dwarf2_read_debug_names): Likewise.
6602         (create_debug_types_hash_table): Change parameter type to
6603         array_view, adjust code accordingly.
6604         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6605         (partial_die_info::fixup): Likewise.
6606         (determine_prefix): Likewise.
6607         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6608
6609 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6610
6611         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6612         gdb_bfd_ref_ptr.
6613         <~dwo_file>: Remove call to gdb_bfd_unref.
6614         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6615         gdb_bfd_ref_ptr::get.
6616
6617 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6618
6619         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6620         type to htab_up.
6621         * dwarf2read.c (struct dwo_file): Initialize fields.
6622         <~dwo_file>: New.
6623         (free_dwo_file): Remove, move content to ~dwo_file.
6624         (struct dwo_file_deleter): Remove.
6625         (dwo_file_up>: Remove custom deleter.
6626         (free_dwo_files): Remove.
6627         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6628         dwo_files.
6629         (process_skeletonless_type_units): Call unique_ptr::get.
6630         (allocate_dwo_file_hash_table): Add deleter to created hash
6631         table.  Change return type to htab_up.
6632         (lookup_dwo_file_slot): Don't memset dwo_file, call
6633         unique_ptr::get.
6634         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6635         (create_dwo_unit_in_dwp_v2): Likewise.
6636         (open_and_init_dwo_file): Likewise.
6637         (free_dwo_file_from_slot): Remove.
6638
6639 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6640
6641         * dwarf2read.h (struct dwarf2_section_info) <readin,
6642         is_virtual>: Change type to bool.
6643         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6644         true instead of 1.
6645
6646 2019-06-19  Tom Tromey  <tom@tromey.com>
6647
6648         * tui/tui-data.h (tui_init_content_element): Don't declare.
6649
6650 2019-06-19  Tom Tromey  <tom@tromey.com>
6651
6652         * tui/tui-data.h (tui_init_win_info): Don't declare.
6653
6654 2019-06-19  Tom de Vries  <tdevries@suse.de>
6655
6656         * dwarf2read.h (abstract_to_concrete): Change type to
6657         std::unordered_map<sect_offset, std::vector<sect_offset>,
6658         gdb::hash_enum<sect_offset>>.
6659
6660 2019-06-19  Tom Tromey  <tromey@adacore.com>
6661
6662         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6663         EVAL_AVOID_SIDE_EFFECTS specially.
6664
6665 2019-06-19  Tom Tromey  <tromey@adacore.com>
6666
6667         * source-cache.c (highlighter): New global.
6668         (source_cache::get_source_lines): Create a highlighter on demand.
6669
6670 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6671
6672         * defs.h (deprecated_interactive_hook): Delete declaration.
6673         * interps.c (clear_interpreter_hooks): Remove use of
6674         deprecated_interactive_hook.
6675         * top.c (deprecated_interactive_hook): Delete definition.
6676         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6677
6678 2019-06-18  Tom de Vries  <tdevries@suse.de>
6679
6680         PR gdb/24515
6681         * dwarf2read.h (abstract_to_concrete): Change type from
6682         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6683         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6684         * dwarf2read.c (read_variable): Update.
6685         (dwarf2_fetch_die_loc_sect_off): Update.
6686
6687 2019-06-17  Tom de Vries  <tdevries@suse.de>
6688
6689         PR gdb/24617
6690         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6691         accessing parent[parent_len - 1].
6692
6693 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6694
6695         PR gdb/24364
6696         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6697         call dtrace_process_dof with NULL dof.
6698
6699 2019-06-16  Tom de Vries  <tdevries@suse.de>
6700
6701         PR gdb/24445
6702         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6703
6704 2019-06-16  Tom Tromey  <tom@tromey.com>
6705
6706         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6707         (make_all_visible): Use address of member.
6708
6709 2019-06-16  Tom Tromey  <tom@tromey.com>
6710
6711         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6712         (tui_free_window, free_content, free_content_elements): Remove
6713         unnecessary cast.
6714         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6715         cast.
6716         * tui/tui-regs.c (tui_show_register_group)
6717         (tui_display_registers_from, tui_display_reg_element_at_line):
6718         Remove unnecessary cast.
6719
6720 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6721
6722         * linux-nat.c (normal_mask): Delete.
6723         (_initialize_linux_nat): Don't initialise normal_mask.
6724
6725 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6726
6727         PR gdb/24445
6728         * dwarf-index-write.h (write_psymtabs_to_index): Add
6729         dwz_basename parameter.
6730         * dwarf-index-write.c (write_gdbindex): Move file writing to
6731         write_gdbindex_1.  Change return type void.
6732         (assert_file_size): Move up, remove filename parameter.
6733         (write_gdbindex_1): New function.
6734         (write_debug_names): Change return type to void, call
6735         assert_file_size.
6736         (struct index_wip_file): New struct.
6737         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6738         file logic to index_wip_file.  Write index for dwz file if
6739         needed.
6740         (save_gdb_index_command): Pass basename of dwz file, if present.
6741         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6742         build-id of dwz file, if present.
6743         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6744         (dwarf2_get_dwz_file): Likewise.
6745         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6746         (dwarf2_get_dwz_file): Likewise.
6747
6748 2019-06-16  Tom Tromey  <tom@tromey.com>
6749
6750         * coffread.c (process_coff_symbol): Use xstrdup.
6751         * value.c (create_internalvar): Use xstrdup.
6752
6753 2019-06-16  Tom Tromey  <tom@tromey.com>
6754
6755         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6756         * breakpoint.c (stopin_command, stopat_command)
6757         (until_break_command, decode_location_default): Remove unnecessary
6758         cast.
6759         * utils.c (subset_compare): Remove unnecessary cast.
6760         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6761         cast.
6762         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6763         cast.
6764         * infcmd.c (path_command): Remove unnecessary cast.
6765         * coffread.c (decode_type): Remove unnecessary cast.
6766         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6767         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6768         * tui/tui-stack.c (tui_show_locator_content)
6769         (tui_show_frame_info): Remove unnecessary cast.
6770         * tui/tui-win.c (tui_scroll_forward_command)
6771         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6772         (parse_scrolling_args): Remove unnecessary cast.
6773         * tui/tui-data.c (init_win_info, tui_del_window)
6774         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6775         (free_content_elements): Remove unnecessary cast.
6776         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6777         unnecessary cast.
6778         * tui/tui-source.c (tui_set_source_content)
6779         (tui_vertical_source_scroll): Remove unnecessary cast.
6780         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6781         cast.
6782         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6783         * tui/tui-regs.c (tui_display_registers_from)
6784         (tui_display_register): Remove unnecessary cast.
6785         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6786         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6787         (make_visible): Remove unnecessary cast.
6788         * tui/tui-winsource.c (tui_erase_source_content)
6789         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6790         unnecessary cast.
6791         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6792         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6793         * stabsread.c (read_type, read_array_type, read_range_type):
6794         Remove unnecessary cast.
6795         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6796         (parse_symbol, parse_type, upgrade_type, parse_external)
6797         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6798         unnecessary cast.
6799         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6800
6801 2019-06-16  Tom Tromey  <tom@tromey.com>
6802
6803         * tui/tui-data.c (tui_alloc_generic_win_info)
6804         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6805         checks.
6806
6807 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6808             Andrew Burgess  <andrew.burgess@embecosm.com>
6809
6810         * f-typeprint.c (f_print_type): Don't return early for not
6811         associated or not allocated types.
6812         (f_type_print_varspec_suffix): Add print_rank parameter and print
6813         ranks of array types in case they dangling.
6814         (f_type_print_base): Add print_rank parameter.
6815
6816 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6817
6818         * NEWS: Mention new MI commands.
6819         * break-catch-throw.c (enum exception_event_kind): Move to
6820         breakpoint.h.
6821         (print_mention_exception_catchpoint): Output text as a single
6822         message.
6823         (catch_exception_command_1): Rename to...
6824         (catch_exception_event): ...this, make non-static, update header
6825         command, and change some parameter types.
6826         (catch_catch_command): Update for changes to
6827         catch_exception_command_1.
6828         (catch_throw_command): Likewise.
6829         (catch_rethrow_command): Likewise.
6830         * breakpoint.c (enum exception_event_kind): Delete.
6831         * breakpoint.h (enum exception_event_kind): Moved here from
6832         break-catch-throw.c.
6833         (catch_exception_event): Declare.
6834         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6835         (mi_cmd_catch_throw): New function.
6836         (mi_cmd_catch_rethrow): New function.
6837         (mi_cmd_catch_catch): New function.
6838         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6839         'catch-catch' entries.
6840         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6841         (mi_cmd_catch_rethrow): Declare.
6842         (mi_cmd_catch_catch): Declare.
6843
6844 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6845
6846         * annotate.c (annotate_source_line): Change return type to void,
6847         update implementation to match.
6848         * annotate.h (annotate_source_line): Change return type to void,
6849         update header comment.
6850         * stack.c (print_frame_info): Don't change what frame information
6851         is printed based on whether annotations are on or not.
6852
6853 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6854
6855         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6856         (annotate_source): Make static.
6857         (annotate_source_line): Moved from source.c and renamed from
6858         identify_source_line.  Update the return type.
6859         * annotate.h (annotate_source): Delete declaration.
6860         (annotate_source_line): Declaration moved from source.h, and
6861         renamed from identify_source_line.  Return type updated.
6862         * source.c (identify_source_line): Moved to annotate.c and renamed
6863         to annotate_source_line.
6864         (info_line_command): Remove check of annotation_level.
6865         * source.h (identify_source_line): Move declaration to annotate.h
6866         and rename to annotate_source_line.
6867         * stack.c: Add 'annotate.h' include.
6868         (print_frame_info): Remove check of annotation_level before
6869         calling annotate_source_line.
6870
6871 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6872
6873         * source-cache.c (source_cache::get_plain_source_lines): Use
6874         open_source_file_with_line_charpos instead of just
6875         open_source_file, remove call to find_source_lines.
6876         (source_cache::get_source_lines): Likewise.
6877         * source.c (find_source_lines): Make static.
6878         (get_filename_and_charpos): Renamed into...
6879         (open_source_file_with_line_charpos): ..this along with changes to
6880         return a scoped_fd, and some other minor clean ups.
6881         (identify_source_line): Use open_source_file_with_line_charpos.
6882         (search_command_helper): Use open_source_file_with_line_charpos
6883         instead of just open_source_file, remove call to
6884         find_source_lines.
6885         * source.h (open_source_file_with_line_charpos): Declare new
6886         function.
6887         (find_source_lines): Delete declaration.
6888
6889 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6890
6891         * source.c (get_filename_and_charpos): Remove fullname
6892         parameter.
6893         (identify_source_line): Update call to get_filename_and_charpos.
6894
6895 2019-06-14  Tom Tromey  <tromey@adacore.com>
6896
6897         PR gdb/24502:
6898         * ui-style.h (skip_ansi_escape): Update comment.
6899         * ui-file.h (class no_terminal_escape_file): New class.
6900         * ui-file.c (no_terminal_escape_file::write)
6901         (no_terminal_escape_file::puts): New methods.
6902         * cli/cli-logging.c (handle_redirections): Use
6903         no_terminal_escape_file.
6904
6905 2019-06-14  Tom Tromey  <tromey@adacore.com>
6906
6907         * NEWS: Move convenience variable news above Python news.
6908
6909 2019-06-14  Tom Tromey  <tom@tromey.com>
6910
6911         * gnulib: Move directory to top-level.
6912         * configure.ac: Don't configure gnulib.
6913         * configure: Rebuild.
6914         * common/common-defs.h: Use new path to gnulib.
6915         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6916         (GNULIB_H): Remove.
6917         (INCGNU): Look in new gnulib location.
6918         (HFILES_NO_SRCDIR): Remove gnulib files.
6919         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6920         (generated_files): Remove GNULIB_H.
6921         ($(LIBGNU), all-lib): Remove targets.
6922         (distclean): Don't mention GNULIB_BUILDDIR.
6923         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6924
6925 2019-06-14  Tom Tromey  <tromey@adacore.com>
6926
6927         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6928         Warn if symbol file does not provide any symbols.
6929
6930 2019-06-14  Tom Tromey  <tromey@adacore.com>
6931
6932         * source.c (find_and_open_source): Respect basenames_may_differ.
6933
6934 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6935
6936         * annotate.c (annotate_breakpoints_invalid): Make use of
6937         scoped_restore_terminal_state.
6938         (annotate_frames_invalid): Likewise.
6939
6940 2019-06-14  Tom Tromey  <tromey@adacore.com>
6941
6942         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6943         allow assignment to an internalvar.
6944
6945 2019-06-14  Tom Tromey  <tromey@adacore.com>
6946
6947         * ada-lex.l: Allow "_" in attribute names.
6948
6949 2019-06-14  Tom Tromey  <tromey@adacore.com>
6950
6951         PR gdb/24653:
6952         * regcache.c (registers_changed): Don't call alloca.
6953         * top.c (execute_command): Don't call alloca.
6954
6955 2019-06-13  Pedro Alves  <palves@redhat.com>
6956
6957         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6958         'expression'.  When parsing an expression, error out if there's
6959         junk after "unlimited".
6960         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6961         (do_set_command): Adjust calls to is_unlimited_literal.
6962
6963 2019-06-13  Pedro Alves  <palves@redhat.com>
6964
6965         * compile/compile.c (make_compile_options_def_group): Add braces
6966         around array_view initializer.
6967         * thread.c (make_thread_apply_all_options_def_group)
6968         (make_thread_apply_all_options_def_group): Likewise.
6969
6970 2019-06-13  Pedro Alves  <palves@redhat.com>
6971
6972         * NEWS (New commands): Mention "maint test-options
6973         require-delimiter", "maint test-options unknown-is-error", "maint
6974         test-options unknown-is-operand" and "maint show
6975         test-options-completion-result".
6976         (New command options, command completion): New section.
6977         (Completion improvements): New section.
6978         Mention that you can abbreviate "unlimited".
6979
6980 2019-06-13  Pedro Alves  <palves@redhat.com>
6981
6982         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6983         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6984         * unittests/cli-utils-selftests.c (test_parse_flags)
6985         (test_parse_flags_qcs): Delete.
6986         (test_cli_utils): Don't call deleted functions.
6987
6988 2019-06-13  Pedro Alves  <palves@redhat.com>
6989
6990         * thread.c: Include "cli/cli-option.h".
6991         (tp_array_compar_ascending): Global.
6992         (tp_array_compar): Delete function.
6993         (tp_array_compar_ascending, tp_array_compar_descending): New
6994         functions.
6995         (ascending_option_def, qcs_flag_option_def)
6996         (thr_qcs_flags_option_defs)
6997         (make_thread_apply_all_options_def_group)
6998         (make_thread_apply_options_def_group): New.
6999         (thread_apply_all_command): Use gdb::option::process_options.
7000         (thread_apply_command_completer)
7001         (thread_apply_all_command_completer): New.
7002         (thread_apply_command): Use gdb::option::process_options.
7003         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7004         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7005         to generate help text of "thread apply".  Adjust "taas"'s help.
7006         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7007         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7008
7009 2019-06-13  Pedro Alves  <palves@redhat.com>
7010
7011         * thread.c (thread_apply_command): Check for invalid TID with
7012         isdigit instead of !isalpha.
7013
7014 2019-06-13  Pedro Alves  <palves@redhat.com>
7015
7016         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7017         (validate_flags_qcs): New.
7018         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7019         (validate_flags_qcs): Declare.
7020         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7021         (make_frame_apply_options_def_group): New.
7022         (frame_apply_command_count): Process options with
7023         gdb::option::process_options.
7024         (frame_apply_completer): New.
7025         (frame_apply_level_completer, frame_apply_all_completer)
7026         (frame_apply_completer): New.
7027         (_initialize_stack): Update help of "frame apply", "frame apply
7028         level", "frame apply all" and "faas" to mention supported options
7029         and install command completers.
7030         * stack.h (frame_apply_all_completer): Declare.
7031         * thread.c: Include "stack.h".
7032         (tfaas_command): Add "--".
7033         (_initialize_thread): Update help "tfaas" to mention supported
7034         options and install command completer.
7035
7036 2019-06-13  Pedro Alves  <palves@redhat.com>
7037
7038         * completer.c (complete_nested_command_line): New.
7039         (gdb_completion_word_break_characters_throw): Add assertion.
7040         * completer.h (complete_nested_command_line): Declare.
7041
7042 2019-06-13  Pedro Alves  <palves@redhat.com>
7043
7044         * stack.c (parse_backtrace_qualifiers): New.
7045         (backtrace_command): Use it.
7046         (backtrace_command_completer): Complete on qualifiers.
7047
7048 2019-06-13  Pedro Alves  <palves@redhat.com>
7049
7050         * frame.c: Include "cli/cli-option.h.
7051         (user_set_backtrace_options): New.
7052         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7053         Delete.
7054         (get_prev_frame): Adjust.
7055         (boolean_option_def, uinteger_option_def)
7056         (set_backtrace_option_defs): New.
7057         (_initialize_frame): Adjust and use
7058         gdb::option::add_setshow_cmds_for_options to install "set
7059         backtrace past-main" and "set backtrace past-entry".
7060         * frame.h: Include "cli/cli-option.h".
7061         (struct frame_print_options): Forward declare.
7062         (print_frame_arguments_all, print_frame_arguments_scalars)
7063         (print_frame_arguments_none): Declare.
7064         (print_entry_values): Delete declaration.
7065         (struct frame_print_options, user_frame_print_options): New.
7066         (struct set_backtrace_options): New.
7067         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7068         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7069         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7070         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7071         (list_args_or_locals): Add frame_print_options parameter.
7072         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7073         * python/py-framefilter.c (enumerate_args): Pass down
7074         USER_FRAME_PRINT_OPTIONS.
7075         * stack.c: Include "cli/cli-option.h".
7076         (print_frame_arguments_all, print_frame_arguments_scalars)
7077         (print_frame_arguments_none): Declare.
7078         (print_raw_frame_arguments, print_entry_values): Delete.
7079         (user_frame_print_options): New.
7080         (boolean_option_def, enum_option_def, frame_print_option_defs):
7081         New.
7082         (struct backtrace_cmd_options): New.
7083         (bt_flag_option_def): New.
7084         (backtrace_command_option_defs): New.
7085         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7086         (print_frame_arg, read_frame_arg, print_frame_args)
7087         (print_frame_info, print_frame): Add frame_print_options parameter
7088         and use it.
7089         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7090         (backtrace_command_1): Add frame_print_options and
7091         backtrace_cmd_options parameters and use them.
7092         (make_backtrace_options_def_group): New.
7093         (backtrace_command): Process command options with
7094         gdb::option::process_options.
7095         (backtrace_command_completer): New.
7096         (_initialize_stack): Extend "backtrace"'s help to mention
7097         supported options.  Install completer for "backtrace".
7098         Install some settings commands with add_setshow_cmds_for_options.
7099
7100 2019-06-13  Pedro Alves  <palves@redhat.com>
7101
7102         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7103         and that "set/show print raw frame-arguments" are now deprecated.
7104
7105         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7106         command.
7107         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7108         * stack.c (_initialize_stack): Install "set/show print
7109         raw-frame-arguments", and deprecate "set/show print raw
7110         frame-arguments".
7111         * valprint.c (_initialize_valprint): Deprecate "set/show print
7112         raw".
7113
7114 2019-06-13  Pedro Alves  <palves@redhat.com>
7115
7116         * compile/compile.c (struct compile_options): New.
7117         (compile_flag_option_def, compile_command_option_defs)
7118         (make_compile_options_def_group): New.
7119         (compile_file_command): Handle options with
7120         gdb::option::process_options.
7121         (compile_file_command_completer): New function.
7122         (compile_code_command): Handle options with
7123         gdb::option::process_options.
7124         (compile_code_command_completer): New function.
7125         (_initialize_compiler): Install completers for "compile code" and
7126         "compile file".  Mention available options in "compile code" and
7127         "compile code"'s help.
7128         * completer.c (advance_to_completion_word): New, factored out from
7129         ...
7130         (advance_to_expression_complete_word_point): ... this.
7131         (advance_to_filename_complete_word_point): New.
7132         * completer.h (advance_to_filename_complete_word_point): New
7133         declaration.
7134
7135 2019-06-13  Pedro Alves  <palves@redhat.com>
7136
7137         * compile/compile.c: Include "cli/cli-option.h".
7138         (compile_print_value): Scope data pointer is now a
7139         value_print_options pointer; adjust.
7140         (compile_print_command): Process options.  Scope data pointer is
7141         now a value_print_options pointer; adjust.
7142         (_initialize_compile): Update "compile print"'s help to include
7143         supported options.  Install a completer for "compile print".
7144         * cp-valprint.c (show_vtblprint, show_objectprint)
7145         (show_static_field_print): Delete.
7146         (_initialize_cp_valprint): Don't install "set print
7147         static-members", "set print vtbl", "set print object" here.
7148         * printcmd.c: Include "cli/cli-option.h" and
7149         "common/gdb_optional.h".
7150         (print_command_parse_format): Rework to fill in a
7151         value_print_options instead of a format_data.
7152         (print_value): Change parameter type from format_data pointer to
7153         value_print_options reference.  Adjust.
7154         (print_command_1): Process options.  Adjust to pass down a
7155         value_print_options.
7156         (print_command_completer): New.
7157         (_initialize_printcmd): Install print_command_completer as
7158         handle_brkchars completer for the "print" command.  Update
7159         "print"'s help to include supported options.
7160         * valprint.c: Include "cli/cli-option.h".
7161         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7162         here from cp-valprint.c.
7163         (boolean_option_def, uinteger_option_def)
7164         (value_print_option_defs, make_value_print_options_def_group):
7165         New.  Use gdb::option::add_setshow_cmds_for_options to install
7166         "set print elements", "set print null-stop", "set print repeats",
7167         "set print pretty", "set print union", "set print array", "set
7168         print address", "set print symbol", "set print array-indexes".
7169         * valprint.h: Include <string> and "cli/cli-option.h".
7170         (make_value_print_options_def_group): Declare.
7171         (print_value): Change parameter type from format_data pointer to
7172         value_print_options reference.
7173         (print_command_completer): Declare.
7174
7175 2019-06-13  Pedro Alves  <palves@redhat.com>
7176
7177         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7178         (COMMON_SFILES): Add maint-test-settings.c.
7179         * cli/cli-decode.c (boolean_enums): New global, factored out from
7180         ...
7181         (add_setshow_boolean_cmd): ... here.
7182         * cli/cli-decode.h (boolean_enums): Declare.
7183         * cli/cli-option.c: New file.
7184         * cli/cli-option.h: New file.
7185         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7186         factored out from ...
7187         (parse_cli_boolean_value(const char *)): ... this.
7188         (is_unlimited_literal): Change parameter type to pointer to
7189         pointer.  Adjust and advance ARG pointer.
7190         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7191         (parse_cli_var_enum): New, factored out from ...
7192         (do_set_command): ... this.  Adjust.
7193         * cli/cli-setshow.h (parse_cli_boolean_value)
7194         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7195         (parse_cli_var_enum): Declare.
7196         * cli/cli-utils.c: Include "cli/cli-option.h".
7197         (get_ulongest): New.
7198         * cli/cli-utils.h (get_ulongest): Declare.
7199         (check_for_argument): New overloads.
7200         * maint-test-options.c: New file.
7201
7202 2019-06-13  Pedro Alves  <palves@redhat.com>
7203
7204         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7205         parse a range if "-" is at the end of the string.
7206
7207 2019-06-13  Pedro Alves  <palves@redhat.com>
7208
7209         * cli/cli-setshow.c (parse_auto_binary_operation)
7210         (parse_cli_boolean_value): Don't allow "o".
7211
7212 2019-06-13  Pedro Alves  <palves@redhat.com>
7213
7214         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7215         * NEWS: Mention maint test-settings KIND.
7216         * maint-test-settings.c: New file.
7217
7218 2019-06-13  Pedro Alves  <palves@redhat.com>
7219
7220         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7221         completer.
7222         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7223         "set" completers.
7224
7225 2019-06-13  Pedro Alves  <palves@redhat.com>
7226
7227         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7228         after item.
7229
7230 2019-06-13  Pedro Alves  <palves@redhat.com>
7231
7232         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7233
7234 2019-06-13  Pedro Alves <palves@redhat.com>
7235
7236         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7237         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7238         call.
7239         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7240         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7241         calls.
7242         (check_for_argument): Skip spaces after argument.
7243
7244 2019-06-13  Pedro Alves  <palves@redhat.com>
7245
7246         * thread.c (thread_apply_command): Adjust TID parsing.
7247         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7248         detected before end of string.
7249         (tid_is_in_list): Error out if LIST is invalid.
7250
7251 2019-06-13  Pedro Alves  <palves@redhat.com>
7252
7253         * completer.c (complete_line_internal_1): Rewind completion word
7254         point.
7255         (completion_tracker::advance_custom_word_point_by): Change
7256         parameter type to int.
7257         * completer.h (completion_tracker::advance_custom_word_point_by):
7258         Likewise.
7259
7260 2019-06-13  Pedro Alves  <palves@redhat.com>
7261
7262         * completer.c (advance_to_completion_word): Handle delimiters.
7263
7264 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7265
7266         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7267
7268 2019-06-11  Tom Tromey  <tom@tromey.com>
7269
7270         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7271         (xmalloc_failed): Move to alloc.c.
7272         * alloc.c: New file.
7273         * Makefile.in (COMMON_SFILES): Add alloc.c.
7274
7275 2019-06-11  Tom Tromey  <tom@tromey.com>
7276
7277         * nat/linux-waitpid.c: Don't include server.h.
7278         (linux_debug): Remove.
7279         (my_waitpid): Update.
7280
7281 2019-06-11  Tom Tromey  <tromey@adacore.com>
7282
7283         * infcall.c (_initialize_infcall): Remove trailing newline from
7284         help.
7285         * user-regs.c (_initialize_user_regs): Remove trailing newline
7286         from help.
7287         * typeprint.c (_initialize_typeprint): Remove trailing newline
7288         from help.
7289         * reverse.c (_initialize_reverse): Remove trailing newlines from
7290         help.
7291         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7292         from help.
7293         * language.c (add_set_language_command): Remove trailing newline
7294         from help.
7295         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7296         help.
7297         * disasm.c (_initialize_disasm): Remove trailing newline from
7298         help.
7299         * top.c (init_main): Remove trailing newline from help.
7300         * interps.c (_initialize_interpreter): Remove trailing newline
7301         from help.
7302         * btrace.c (_initialize_btrace): Remove trailing newlines from
7303         help.
7304         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7305         from help.
7306         * python/python.c (_initialize_python): Remove trailing newline
7307         from help.
7308         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7309         help.
7310         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7311         from help.  Reformat some text.
7312         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7313         from help.
7314         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7315         newline from help.
7316
7317 2019-06-11  Tom Tromey  <tromey@adacore.com>
7318
7319         * darwin-nat.c (darwin_decode_exception_message)
7320         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7321
7322 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7323
7324         * valops.c (value_slice): Check for not allocated or not
7325         associated values.
7326
7327 2019-06-10  Tom de Vries  <tdevries@suse.de>
7328
7329         PR gdb/24618
7330         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7331         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7332         invalid.
7333
7334 2019-06-10  Tom de Vries  <tdevries@suse.de>
7335
7336         PR gdb/24611
7337         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7338         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7339
7340 2019-06-10  Tom de Vries  <tdevries@suse.de>
7341
7342         PR symtab/24545
7343         * symtab.c (struct demangled_name_entry): Add language field.
7344         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7345         static minimal symbol".  Set and use language field.
7346
7347 2019-06-10  Tom Tromey  <tromey@adacore.com>
7348
7349         * ada-lang.c (_initialize_ada_language): Update help text.
7350
7351 2019-06-10  Tom Tromey  <tromey@adacore.com>
7352
7353         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7354         with a newline.
7355         * guile/guile.c (handle_boot_error): Don't end warning with a
7356         newline.
7357         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7358         warning with a newline.
7359         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7360         newline.
7361         (s12z_frame_cache): Likewise.
7362         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7363         a newline.
7364         * solib-svr4.c (disable_probes_interface): Don't end warning with
7365         a newline.
7366         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7367         newline.
7368         * python/python.c (do_finish_initialization): Don't end warning
7369         with a newline.
7370
7371 2019-06-10  Tom Tromey  <tom@tromey.com>
7372
7373         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7374         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7375         gdbpy_enter.
7376
7377 2019-06-10  Tom Tromey  <tromey@adacore.com>
7378
7379         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7380         data.
7381         (elf_new_init): Don't call stabsread_new_init.
7382         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7383         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7384         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7385
7386 2019-06-10  Tom de Vries  <tdevries@suse.de>
7387
7388         PR symtab/16264
7389         PR symtab/24517
7390         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7391
7392 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7393
7394         * source.c (find_and_open_source): Also rewrite relative file
7395         names.
7396
7397 2019-04-26  Amos Bird  <amosbird@gmail.com>
7398
7399         * annotate.c (annotate_thread_exited): Add "thread-exited"
7400         annotation.
7401
7402 2019-06-06  Tom Tromey  <tromey@adacore.com>
7403
7404         * maint.h (class scoped_command_stats): Use
7405         DISABLE_COPY_AND_ASSIGN.
7406         <print_time>: New method.
7407         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7408         print_time.
7409         (scoped_command_stats::print_time): New method.
7410
7411 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7412
7413         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7414         instructions of lengths 6 or 8 bytes.
7415
7416 2019-06-04  Pedro Alves  <palves@redhat.com>
7417
7418         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7419
7420         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7421         * breakpoint.c (condition_completer): Likewise.
7422         * cli/cli-dump.c (scan_expression): Likewise.
7423         * common/filestuff.c (mkdir_recursive): Likewise.
7424         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7425         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7426         (gdb_abspath): Likewise.
7427         * compile/compile-cplus-types.c
7428         (compile_cplus_instance::decl_name): Likewise.
7429         * completer.c (complete_explicit_location):
7430         (signal_completer, reg_or_group_completer_1): Likewise.
7431         * cp-support.c (cp_remove_params_if_any): Likewise.
7432         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7433         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7434         * infcmd.c (strip_bg_char): Likewise.
7435         * linespec.c (copy_token_string): Likewise.
7436         * mi/mi-main.c (output_cores): Likewise.
7437         * psymtab.c (psymtab_search_name):
7438         * symfile.c (test_set_ext_lang_command): Likewise.
7439         * target.c (target_fileio_read_stralloc): Likewise.
7440         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7441         * value.c (complete_internalvar): Likewise.
7442
7443 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7444
7445         Add objfile property to gdb.Type.
7446         * NEWS: Mention Python API addition.
7447         * python/py-type.c (typy_get_objfile): New method.
7448
7449 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7450
7451         * NEWS: Mention the new set|show style [title|highlight].
7452         Mention changes to "show style", "help" and "apropos".
7453
7454 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7455
7456         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7457         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7458         instead of print_help_for_command.
7459         (print_doc_of_command): New function.
7460         (help_list): Add 'apropos -v word' suggestion.
7461         (print_help_for_command): Style the command name using title style.
7462         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7463         (_initialize_cli_cmds): Describe -v in apropos_command help.
7464
7465 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7466
7467         * cli/cli-style.h (cli_style_option): Add name in constructor,
7468         add m_name class member, add constructor with intensity,
7469         add name class function.
7470         (cli_style_option::add_setshow_commands): Remove name argument.
7471         (highlight_style, title_style): New styles.
7472         * cli/cli-style.c (do_show): New function that shows a style
7473         characteristic styling the style name with itself.
7474         (set_style_name): New function.
7475         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7476         Update all callers according to the changes in cli/cli-style.h.
7477         * utils.h (fputs_highlighted): New function.
7478         * utils.c (fputs_highlighted): Likewise.
7479
7480 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7481
7482         * NEWS: Mention new pipe command and new convenience variables.
7483
7484 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7485
7486         * cli/cli-cmds.c (pipe_command): New function.
7487         (_initialize_cli_cmds): Call add_com for pipe_command.
7488         Define | as an alias for pipe.
7489         (exit_status_set_internal_vars): New function.
7490         (shell_escape): Call exit_status_set_internal_vars.
7491         cli/cli-decode.c (find_command_name_length): Recognize | as
7492         a single character command.
7493
7494 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7495
7496         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7497         top.c (execute_command_to_ui_file): New function, mostly a copy
7498         of execute_command_to_string.
7499         (execute_command_to_string): Implement by calling
7500         execute_command_to_ui_file.
7501
7502 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7503
7504         * top.h (saved_command_line): Remove declaration.
7505         * top.c (previous_saved_command_line, previous_repeat_arguments):
7506         New variables.
7507         (saved_command_line): Make static, define together with other
7508         'repeat variables'.
7509         (dont_repeat): Clear repeat_arguments.
7510         (repeat_previous, get_saved_command_line, save_command_line):
7511         New functions.
7512         (gdb_init): Initialize saved_command_line
7513         and previous_saved_command_line.
7514         * main.c (captured_main_1): Remove saved_command_line initialization.
7515         * event-top.c (handle_line_of_input): Update to use
7516         the new 'repeat' related functions instead of direct access to
7517         saved_command_line.
7518         * command.h (repeat_previous, get_saved_command_line,
7519         save_command_line): New declarations.
7520         (dont_repeat): Add comment.
7521
7522 2019-05-30  Tom Tromey  <tromey@adacore.com>
7523
7524         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7525         Fix comment.
7526         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7527
7528 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7529
7530         PR cli/24587
7531         * completer.c (complete): Initialize variable word.
7532
7533 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7534
7535         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7536         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7537         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7538         'body' is NULL to the outter 'if', protecting the '!is_define'
7539         situation as well.
7540
7541 2019-05-29  Tom Tromey  <tromey@adacore.com>
7542
7543         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7544         (dwarf_unknown): New function.
7545         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7546         (dwarf_type_encoding_name): Use dwarf_unknown.
7547
7548 2019-05-29  Tom Tromey  <tromey@adacore.com>
7549
7550         PR c++/20020:
7551         * cp-valprint.c (cp_print_value_fields): Call
7552         cp_print_static_field inside "try".
7553
7554 2019-05-29  Tom Tromey  <tromey@adacore.com>
7555
7556         * inflow.c (struct terminal_info): Add default operator=.
7557         * configure: Rebuild.
7558         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7559         -Wdeprecated-copy-dtor, -Wredundant-move.
7560
7561 2019-05-29  Tom Tromey  <tromey@adacore.com>
7562
7563         * NEWS: Add entry.
7564         * infcmd.c (print_return_value_1): Handle finish_print
7565         option.
7566         (show_print_finish): New function.
7567         (_initialize_infcmd): Add "set/show print finish" commands.
7568         * valprint.c (user_print_options): Initialize new member.
7569         * valprint.h (struct value_print_options) <finish_print>: New
7570         member.
7571
7572 2019-05-28  Tom Tromey  <tromey@adacore.com>
7573
7574         * ada-lang.c (ada_remove_Xbn_suffix)
7575         (find_old_style_renaming_symbol)
7576         (parse_old_style_renaming): Remove.
7577         (ada_find_renaming_symbol): Don't call
7578         find_old_style_renaming_symbol.
7579         (ada_is_renaming_symbol): Rename from
7580         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7581         bool.  Now static.
7582         (ada_read_var_value): Update and simplify.
7583         * ada-exp.y (write_var_or_type): Remove old code.
7584
7585 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7586
7587         PR gdb/25010
7588         * event-top.c: Remove include comment.
7589         * inflow.c (class scoped_ignore_sigttou): Move from here...
7590         * inflow.h (class scoped_ignore_sigttou): ...to here.
7591         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7592         * top.c:  Remove include comment.
7593
7594 2019-05-27  Tom Tromey  <tom@tromey.com>
7595
7596         * NEWS: Fix typo.
7597
7598 2019-05-22  Tom Tromey  <tromey@adacore.com>
7599
7600         * target.c (target_follow_exec): Constify parameter.
7601         * target-delegates.c: Rebuild.
7602         * remote.c (remote_target::follow_exec): Constify parameter.
7603         * infrun.c (follow_exec): Constify parameter.
7604         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7605         (target_follow_exec): Likewise.
7606
7607 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7608
7609         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7610         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7611
7612 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7613
7614         * NEWS: Add debugredirect and testsuite sections.
7615
7616 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7617
7618         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7619         target descriptions using exclusively floating point register name
7620         aliases.
7621
7622 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7623
7624         PR gdb/18644:
7625         * f-lang.c (build_fortran_types): Handle the case where
7626         gdbarch_floatformat_for_type returns a nullptr.
7627
7628 2019-05-21  Tom de Vries  <tdevries@suse.de>
7629
7630         PR cli/24587
7631         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7632
7633 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7634
7635         PR gdb/18644:
7636         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7637         16-byte floats.
7638         * i386-tdep.c (i386_floatformat_for_type): Use
7639         floatformats_ia64_quad for the 16-byte floating point component
7640         within a fortran 32-byte complex number.
7641
7642 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7643
7644         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7645         delete default constructor.
7646         (find_partial_die): Update to return const struct.
7647         (partial_die_parent_scope): Move variable declaration into scope
7648         of its use and change its type to auto.
7649         (guess_partial_die_structure_name): Likewise.
7650         (partial_die_info::fixup): Likewise.
7651
7652 2019-05-17  Tom Tromey  <tromey@adacore.com>
7653
7654         * source.c (find_and_open_source): Remove cast.
7655
7656 2019-05-17  Tom Tromey  <tromey@adacore.com>
7657
7658         * annotate.c (annotate_source): Make "filename" const.
7659         * annotate.h (annotate_source): Use const.
7660
7661 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7662
7663         * disasm.c (set_disassembler_options): Send errors to stderr.
7664
7665 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7666
7667         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7668         (cli_interp_base::set_logging): Check debug_redirect.
7669         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7670         * cli/cli-logging.c (debug_redirect): Add static variable.
7671         (pop_output_files): Add default param.
7672         (handle_redirections): Print debug setting.
7673         (show_logging_command): Likewise.
7674         (_initialize_cli_logging): Add debugredirect command.
7675         * interps.c (current_interp_set_logging): Add debug_redirect
7676         parameter.
7677         * interps.h (set_logging): Add debug_redirect parameter.
7678         (current_interp_set_logging): Likewise.
7679         * mi/mi-common.h: Likewise.
7680         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7681
7682 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7683             Tom Tromey  <tromey@adacore.com>
7684
7685         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7686         directly.
7687         * cli/cli-interp.h (make_logging_output): Remove declaration.
7688         * cli/cli-logging.c (make_logging_output): Remove function.
7689         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7690         directly.
7691         * ui-file.c (tee_file::tee_file): Remove bools.
7692         (tee_file::~tee_file): Remove deletes.
7693         * ui-file.h (tee_file): Remove bools.
7694
7695 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7696
7697         * mi/mi-cmds.h (mi_cmd_complete): New function.
7698         * mi/mi-main.c (mi_cmd_complete): Likewise.
7699         * mi/mi-cmds.c: Define new MI command -complete.
7700         * NEWS: Mention new -complete command.
7701
7702 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7703
7704         * completer.h (complete): New function.
7705         * completer.c (complete): Likewise.
7706         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7707         function defined in completer.h.
7708
7709 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7710
7711         * MAINTAINERS (Write After Approval): Add myself.
7712
7713 2019-05-17  Tom de Vries  <tdevries@suse.de>
7714
7715         PR gdb/24094
7716         * dwarf2read.c (struct cu_partial_die_info): New struct.
7717         (find_partial_die): Return cu_partial_die_info.
7718         (partial_die_parent_scope, guess_partial_die_structure_name)
7719         (partial_die_info::fixup): Handle new return type of find_partial_die.
7720
7721 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7722
7723         PR breakpoints/24541
7724         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7725         "std::string", simplifying the algorithm.
7726
7727 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7728
7729         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7730         (stap_static_probe_ops::get_probes): Likewise.
7731
7732 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7733
7734         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7735         '-')" and "else if".
7736         (stap_parse_single_operand): Join checks for
7737         "gdbarch_stap_parse_special_token_p" and
7738         "gdbarch_stap_parse_special_token" in the same "if" statement.
7739         Invert check when verifying for operation on register
7740         displacement.
7741
7742 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7743
7744         * stap-probe.c (stap_get_opcode): Update comment.
7745         (stap_get_expected_argument_type): Likewise.
7746         (handle_stap_probe): Likewise.
7747
7748 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7749
7750         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7751         return type to 'bool'.  Adjust comment.  Use 'bool' when
7752         appropriate.
7753         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7754         * stap-probe.c (stap_parse_argument_1): Likewise.
7755         (stap_is_operator): Likewise.
7756         (stap_is_generic_prefix): Likewise.
7757         (stap_is_register_prefix): Likewise.
7758         (stap_is_register_indirection_prefix): Likewise.
7759         (stap_is_integer_prefix): Likewise.
7760         (stap_generic_check_suffix): Likewise.
7761         (stap_check_integer_suffix): Likewise.
7762         (stap_check_register_suffix): Likewise.
7763         (stap_check_register_indirection_suffix): Likewise.
7764         (stap_parse_register_operand): Likewise.
7765         (stap_parse_single_operand): Likewise.
7766         (stap_parse_argument_1): Likewise.
7767         (stap_probe::get_argument_count): Likewise.
7768         (stap_is_operator): Likewise.
7769
7770 2019-05-16  Tom Tromey  <tromey@adacore.com>
7771
7772         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7773         keyword to foreach.
7774
7775 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7776
7777         * linux-thread-db.c (try_thread_db_load_1): Change return type
7778         to bool.
7779         (try_thread_db_load): Likewise.
7780         (try_thread_db_load_from_pdir_1): Likewise.
7781         (try_thread_db_load_from_pdir): Likewise.
7782         (try_thread_db_load_from_sdir): Likewise.
7783         (try_thread_db_load_from_dir): Likewise.
7784         (thread_db_load_search): Likewise.
7785         (has_libpthread): Likewise.
7786         (thread_db_load): Likewise.
7787
7788 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7789
7790         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7791         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7792         NULL, and complain/return if that's the case.
7793
7794 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7795
7796         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7797         (advance, posn, abstract_read_memory): New functions.
7798         [struct mem_read_abstraction]: New struct.
7799         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7800
7801 2019-05-14  Tom Tromey  <tromey@adacore.com>
7802
7803         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7804         value is not lval_memory.
7805
7806 2019-05-14  Tom Tromey  <tromey@adacore.com>
7807
7808         * solib.c (info_sharedlibrary_command): Style the file name.
7809
7810 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7811
7812         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7813         (aarch64_vnv_type): Likewise.
7814         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7815         * common/tdesc.c: Likewise.
7816         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7817         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7818         * features/aarch64-fpu.xml: Add ieee half view.
7819         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7820         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7821         * gdbtypes.h (struct builtin_type): Likewise.
7822         (struct objfile_type): Likewise.
7823
7824 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7825
7826         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7827         typo.
7828         * location.h (string_to_event_location): Likewise.
7829
7830 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7831
7832         GDB 8.3 released.
7833
7834 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7835
7836         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7837         New variable declaration.
7838         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7839         New variable.
7840         (print_one_breakpoint): Use ui_out::test_flags and new global
7841         variable to compute use_fixed_output.
7842         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7843         Remove.
7844         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7845         (mi_multi_location_breakpoint_output_fixed): Remove.
7846         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7847         new variable.
7848         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7849         fix_multi_location_breakpoint_output flag if version >= 3.
7850         * ui-out.h (enum ui_out_flag)
7851         <fix_multi_location_breakpoint_output>: New enumerator.
7852
7853 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7854
7855         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7856
7857 2019-05-10  Tom Tromey  <tromey@adacore.com>
7858
7859         * ada-lang.c (catch_ada_completer): New function.
7860         (_initialize_ada_language): Use it.
7861
7862 2019-05-10  Tom Tromey  <tromey@adacore.com>
7863
7864         * thread.c (print_thread_info): Make "requested_threads" const.
7865         * gdbthread.h (print_thread_info): Make "requested_threads"
7866         const.
7867         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7868         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7869
7870 2019-05-08  Tom Tromey  <tom@tromey.com>
7871
7872         * gdbtypes.c (objfile_type_data): Change type.
7873         (objfile_type, _initialize_gdbtypes): Update.
7874
7875 2019-05-08  Tom Tromey  <tom@tromey.com>
7876
7877         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7878         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7879         (_initialize_dwarf2_frame): Update.
7880
7881 2019-05-08  Tom Tromey  <tom@tromey.com>
7882
7883         * objc-lang.c (objc_objfile_data): Change type.
7884         (find_methods): Update.
7885         (_initialize_objc_lang): Remove.
7886
7887 2019-05-08  Tom Tromey  <tom@tromey.com>
7888
7889         * stabsread.c (rs6000_builtin_type_data): Change type.
7890         (rs6000_builtin_type, _initialize_stabsread): Update.
7891
7892 2019-05-08  Tom Tromey  <tom@tromey.com>
7893
7894         * mips-tdep.c (mips_pdr_data): Remove.
7895         (_initialize_mips_tdep): Update.
7896
7897 2019-05-08  Tom Tromey  <tom@tromey.com>
7898
7899         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7900         (hppa_init_objfile_priv_data, read_unwind_info)
7901         (find_unwind_entry, _initialize_hppa_tdep): Update.
7902
7903 2019-05-08  Tom Tromey  <tom@tromey.com>
7904
7905         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7906         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7907         on obstack.
7908         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7909
7910 2019-05-08  Tom Tromey  <tom@tromey.com>
7911
7912         * mdebugread.c (basic_type_data): Change type.
7913         (basic_type, _initialize_mdebugread): Update.
7914
7915 2019-05-08  Tom Tromey  <tom@tromey.com>
7916
7917         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7918
7919 2019-05-08  Tom Tromey  <tom@tromey.com>
7920
7921         * nto-tdep.c (nto_inferior_data_reg): Change type.
7922         (nto_inferior_data): Update.
7923         (nto_inferior_data_cleanup, nto_new_inferior_data)
7924         (_initialize_nto_tdep): Remove.
7925         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7926
7927 2019-05-08  Tom Tromey  <tom@tromey.com>
7928
7929         * ada-lang.c (struct ada_inferior_data): Add initializers.
7930         (ada_inferior_data): Change type.
7931         (ada_inferior_data_cleanup): Remove.
7932         (get_ada_inferior_data, ada_inferior_exit)
7933         (struct ada_pspace_data): Add initializers, destructor.
7934         (ada_pspace_data_handle): Change type.
7935         (get_ada_pspace_data): Update.
7936         (ada_pspace_data_cleanup): Remove.
7937
7938 2019-05-08  Tom Tromey  <tom@tromey.com>
7939
7940         * coffread.c (struct coff_symfile_info): Add initializers.
7941         (coff_objfile_data_key): Move lower.  Change type.
7942         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7943         Update.
7944         (coff_free_info): Remove.
7945
7946 2019-05-08  Tom Tromey  <tom@tromey.com>
7947
7948         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7949         (fbsd_pspace_data_handle): Move lower.  Change type.
7950         (get_fbsd_pspace_data): Update.
7951         (fbsd_pspace_data_cleanup): Remove.
7952         (_initialize_fbsd_tdep): Update.
7953
7954 2019-05-08  Tom Tromey  <tom@tromey.com>
7955
7956         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7957         (get_ada_tasks_pspace_data): Update.
7958         (ada_tasks_pspace_data_cleanup): Remove.
7959         (_initialize_tasks): Update.
7960         (ada_tasks_inferior_data_handle): Change type.
7961         (get_ada_tasks_inferior_data): Update.
7962         (ada_tasks_inferior_data_cleanup): Remove.
7963         (struct ada_tasks_pspace_data): Add initializers.
7964
7965 2019-05-08  Tom Tromey  <tom@tromey.com>
7966
7967         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7968         * symfile-debug.c (debug_sym_get_probes): Change type.
7969         * stap-probe.c (handle_stap_probe):
7970         (stap_static_probe_ops::get_probes): Change type.
7971         * probe.h (class static_probe_ops) <get_probes>: Change type.
7972         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7973         (parse_probes_in_pspace): Update.
7974         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7975         Update.
7976         (any_static_probe_ops::get_probes): Change type.
7977         * elfread.c (elfread_data): New typedef.
7978         (probe_key): Change type.
7979         (elf_get_probes): Likewise.  Update.
7980         (probe_key_free): Remove.
7981         (_initialize_elfread): Update.
7982         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7983         Change type.
7984         (dtrace_process_dof_probe, dtrace_process_dof)
7985         (dtrace_static_probe_ops::get_probe): Change type.
7986
7987 2019-05-08  Tom Tromey  <tom@tromey.com>
7988
7989         * xcoffread.c (struct xcoff_symfile_info): Rename from
7990         coff_symfile_info.  Add initializers.
7991         (xcoff_objfile_data_key): Move lower.  Change type.
7992         (XCOFF_DATA): Rewrite.
7993         (xcoff_free_info): Remove.
7994         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7995         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7996         (xcoff_initial_scan): Update.
7997
7998 2019-05-08  Tom Tromey  <tom@tromey.com>
7999
8000         * solib-svr4.c (struct svr4_info): Add initializers and
8001         destructor.
8002         <probes_table>: Now an htab_up.
8003         (solib_svr4_pspace_data): Change type.
8004         (free_probes_table): Simplify.
8005         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8006         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8007         (probes_table_remove_objfile_probes, register_solib_event_probe)
8008         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8009         (_initialize_svr4_solib): Update.
8010
8011 2019-05-08  Tom Tromey  <tom@tromey.com>
8012
8013         * remote.c (remote_pspace_data): Change type.
8014         (remote_pspace_data_cleanup): Remove.
8015         (get_remote_exec_file, set_pspace_remote_exec_file)
8016         (_initialize_remote): Update.
8017
8018 2019-05-08  Tom Tromey  <tom@tromey.com>
8019
8020         * breakpoint.c (breakpoint_objfile_key): Change type.
8021         (get_breakpoint_objfile_data): Update.
8022         (free_breakpoint_objfile_data): Remove.
8023         (_initialize_breakpoint): Update.
8024
8025 2019-05-08  Tom Tromey  <tom@tromey.com>
8026
8027         * linux-tdep.c (struct linux_info): Add initializers.
8028         (linux_inferior_data): Move.  Change type.
8029         (invalidate_linux_cache_inf): Update.
8030         (linux_inferior_data_cleanup): Remove.
8031         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8032
8033 2019-05-08  Tom Tromey  <tom@tromey.com>
8034
8035         * auxv.c (auxv_inferior_data): Move.  Change type.
8036         (auxv_inferior_data_cleanup): Remove.
8037         (invalidate_auxv_cache_inf): Rewrite.
8038         (get_auxv_inferior_data, _initialize_auxv): Update.
8039
8040 2019-05-08  Tom Tromey  <tom@tromey.com>
8041
8042         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8043         (symfile_debug_objfile_data_key): Change type.
8044         (symfile_debug_installed, debug_qf_has_symbols)
8045         (debug_qf_find_last_source_symtab)
8046         (debug_qf_forget_cached_source_info)
8047         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8048         (debug_qf_print_stats, debug_qf_dump)
8049         (debug_qf_expand_symtabs_for_function)
8050         (debug_qf_expand_all_symtabs)
8051         (debug_qf_expand_symtabs_with_fullname)
8052         (debug_qf_map_matching_symbols)
8053         (debug_qf_expand_symtabs_matching)
8054         (debug_qf_find_pc_sect_compunit_symtab)
8055         (debug_qf_map_symbol_filenames)
8056         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8057         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8058         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8059         (debug_sym_read_linetable, debug_sym_relocate): Update.
8060         (symfile_debug_free_objfile): Remove.
8061         (install_symfile_debug_logging, _initialize_symfile_debug):
8062         Update.
8063
8064 2019-05-08  Tom Tromey  <tom@tromey.com>
8065
8066         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8067         allocate_on_obstack.
8068         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8069         (get_dwarf2_per_objfile): Update.
8070         (set_dwarf2_per_objfile): Remove.
8071         (dwarf2_has_info, dwarf2_get_section_info): Update.
8072         (dwarf2_free_objfile): Remove.
8073         (_initialize_dwarf2_read): Update.
8074
8075 2019-05-08  Tom Tromey  <tom@tromey.com>
8076
8077         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8078         initializers.
8079         <unsupported_script_warning_printed,
8080         script_not_found_warning_printed>: Now bool.
8081         (auto_load_pspace_data): Change type.
8082         (~auto_load_pspace_info): Rename from
8083         auto_load_pspace_data_cleanup.
8084         (get_auto_load_pspace_data, init_loaded_scripts_info)
8085         (clear_section_scripts, maybe_print_unsupported_script_warning)
8086         (maybe_print_script_not_found_warning, _initialize_auto_load):
8087         Update.
8088
8089 2019-05-08  Tom Tromey  <tom@tromey.com>
8090
8091         * objfiles.c (objfile_pspace_info): Add destructor and
8092         initializers.
8093         (objfiles_pspace_data): Change type.
8094         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8095         (get_objfile_pspace_data): Update.
8096         (objfiles_bfd_data): Change type.
8097         (get_objfile_bfd_data): Update.
8098         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8099
8100 2019-05-08  Tom Tromey  <tom@tromey.com>
8101
8102         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8103         Change type.
8104         (get_catch_syscall_inferior_data): Update.
8105         (catch_syscall_inferior_data_cleanup): Remove.
8106         (_initialize_break_catch_syscall): Update.
8107
8108 2019-05-08  Tom Tromey  <tom@tromey.com>
8109
8110         * inflow.c (struct terminal_info): Add destructor and
8111         initializers.
8112         (inflow_inferior_data): Change type.
8113         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8114         (get_inflow_inferior_data, inflow_inferior_exit)
8115         (swap_terminal_info, _initialize_inflow): Update.
8116
8117 2019-05-08  Tom Tromey  <tom@tromey.com>
8118
8119         * target-dcache.c (target_dcache_cleanup): Remove.
8120         (target_dcache_aspace_key): Change type.
8121         (target_dcache_init_p, target_dcache_invalidate)
8122         (target_dcache_get, target_dcache_get_or_init)
8123         (_initialize_target_dcache): Update.
8124         * dcache.h (struct dcache_deleter): New.
8125
8126 2019-05-08  Tom Tromey  <tom@tromey.com>
8127
8128         * symtab.c (struct symbol_cache): Add destructor and
8129         initializers.
8130         (symbol_cache_key): Move.  Change type.
8131         (make_symbol_cache, free_symbol_cache): Remove.
8132         (get_symbol_cache): Update.
8133         (symbol_cache_cleanup): Remove.
8134         (ALL_PSPACES, symbol_cache_flush)
8135         (maintenance_print_symbol_cache)
8136         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8137         Update.
8138
8139 2019-05-08  Tom Tromey  <tom@tromey.com>
8140
8141         * symtab.c (struct main_info): Add destructor and initializers.
8142         (main_progspace_key): Move.  Change type.
8143         (get_main_info): Update.
8144         (main_info_cleanup): Remove.
8145         (_initialize_symtab): Update.
8146
8147 2019-05-08  Tom Tromey  <tom@tromey.com>
8148
8149         * registry.h (DECLARE_REGISTRY): Define the _key class.
8150
8151 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8152
8153         * NEWS: Merge two 'New commands' sections.
8154
8155 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8156
8157         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8158         parameter and use Ada language definition instead.
8159         (ada_val_print_ptr): Remove unused language parameter.
8160         (ada_val_print_num): Remove language parameter and use Ada language
8161         definition instead.
8162         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8163         parameter.
8164         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8165         parameter and use Ada language definition instead.
8166         (ada_val_print_1): Update all ada_val_print_xxx calls.
8167         Remove language parameter.
8168         (ada_val_print): Update ada_val_print_1 call.
8169
8170 2019-05-08  Tom Tromey  <tromey@adacore.com>
8171
8172         * remote.c (remote_hw_watchpoint_limit)
8173         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8174         Now static.
8175
8176 2019-05-08  Tom Tromey  <tromey@adacore.com>
8177
8178         * maint.c (_initialize_maint_cmds): Move initialization code to
8179         remote.c.
8180         (watchdog, show_watchdog): Move to remote.c.
8181         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8182         "watchdog" static.
8183         (_initialize_remote): Move initialization code from maint.c.
8184         * defs.h (watchdog): Don't declare.
8185
8186 2019-05-08  Tom Tromey  <tromey@adacore.com>
8187
8188         * tui/tui-interp.c: Include main.h.
8189         * interps.c: Include main.h.
8190         * main.h (interpreter_p): Declare.
8191         * defs.h (interpreter_p): Don't declare.
8192
8193 2019-05-08  Tom Tromey  <tromey@adacore.com>
8194
8195         * dwarf2loc.c: Include dwarf2read.h.
8196         * defs.h (read_unsigned_leb128): Don't declare.
8197         * dwarf2read.h (read_unsigned_leb128): Declare.
8198
8199 2019-05-08  Tom Tromey  <tromey@adacore.com>
8200
8201         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8202         method.
8203
8204 2019-05-08  Tom Tromey  <tromey@adacore.com>
8205
8206         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8207         when no wrap column is set.
8208
8209 2019-05-08  Tom Tromey  <tromey@adacore.com>
8210
8211         * c-lang.c (c_get_string): Handle non-C-style arrays.
8212
8213 2019-05-08  Tom Tromey  <tromey@adacore.com>
8214
8215         * typeprint.c (print_offset_data::update): Print the bit offset,
8216         not the number of bits remaining.
8217
8218 2019-05-08  Tom Tromey  <tromey@adacore.com>
8219
8220         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8221         padding at end of comment.
8222
8223 2019-05-08  Tom Tromey  <tromey@adacore.com>
8224
8225         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8226         Compare main types.
8227
8228 2019-05-06  Tom Tromey  <tom@tromey.com>
8229
8230         * common/scoped_mmap.c: Include common-defs.h.
8231         * common/scoped_mmap.h: Don't include config.h.
8232
8233 2019-05-04  Tom Tromey  <tom@tromey.com>
8234
8235         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8236         (struct aarch64_call_info): Add initializers.
8237         <si>: Now a std::vector.
8238         (pass_on_stack, aarch64_push_dummy_call): Update.
8239
8240 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8241             Tom Tromey  <tom@tromey.com>
8242
8243         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8244         (ppc_threads): Now a std::vector.  Now static.
8245         (hwdebug_find_thread_points_by_tid)
8246         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8247         Update.
8248
8249 2019-05-04  Tom Tromey  <tom@tromey.com>
8250
8251         * arc-tdep.c (arc_tdesc_init): Return bool.
8252
8253 2019-05-04  Tom Tromey  <tom@tromey.com>
8254
8255         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8256         Use gdb_assert_not_reached.
8257
8258 2019-05-04  Tom Tromey  <tom@tromey.com>
8259
8260         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8261         "false".
8262
8263 2019-05-04  Tom Tromey  <tom@tromey.com>
8264
8265         * arc-tdep.c (arc_tdesc_init): Use bool.
8266
8267 2019-05-04  Tom Tromey  <tom@tromey.com>
8268
8269         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8270
8271 2019-05-04  Tom Tromey  <tom@tromey.com>
8272
8273         * cli/cli-cmds.c (valid_command_p): Return bool.
8274
8275 2019-05-04  Tom Tromey  <tom@tromey.com>
8276
8277         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8278         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8279
8280 2019-05-04  Raul Tambre  <raul@tambre.ee>
8281
8282         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8283         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8284         operator for comparison.
8285
8286 2019-05-04  Tom Tromey  <tom@tromey.com>
8287
8288         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8289         (lookup_partial_symbol, print_partial_symbols)
8290         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8291         (psymbol_compare): Update.
8292         (add_psymbol_to_bcache): Clear the entire psymbol.
8293         (maintenance_check_psymtabs): Update.
8294         * psympriv.h (struct partial_symbol): Don't derive from
8295         general_symbol_info.
8296         <obj_section, unrelocated_address, address,
8297         set_unrelocated_address>: Update.
8298         <ginfo>: New member.
8299         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8300         (debug_names::write_psymbols): Update.
8301
8302 2019-05-04  Tom de Vries  <tdevries@suse.de>
8303
8304         * contrib/cc-with-tweaks.sh: Support -n arg.
8305
8306 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8307
8308         * corelow.c (core_target::detach): Ensure frame cache and
8309         register caches are cleared.
8310         inferior.c (exit_inferior_1): Likewise.
8311
8312 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8313             Tom Tromey  <tom@tromey.com>
8314
8315         * dictionary.c (collate_pending_symbols_by_language): Remove
8316         "struct" from foreach.
8317         * symtab.c (lookup_global_symbol_from_objfile)
8318         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8319         foreach.
8320         * ser-tcp.c (net_open): Remove "struct" from foreach.
8321         * objfiles.c (objfile_relocate, objfile_rebase)
8322         (objfile_has_symbols): Remove "struct" from foreach.
8323         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8324         from foreach.
8325         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8326         foreach.
8327         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8328         "struct" from foreach.
8329         * ada-lang.c (create_excep_cond_exprs)
8330         (ada_exception_catchpoint_cond_string): Remove "struct" from
8331         foreach.
8332
8333 2019-05-03  Tom Tromey  <tromey@adacore.com>
8334
8335         * ada-exp.y (convert_char_literal): Check suffix of each
8336         enumerator.
8337
8338 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8339
8340         PR ada/21406:
8341         * ada-exp.y (yywrap): Don't define.
8342         * ada-lex.l (%option): Add noyywrap
8343         (yywrap): Remove.
8344
8345 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8346
8347         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8348         _WIN32_WINNT to the XP level, unless already defined to a higher
8349         level.
8350
8351         * unittests/parse-connection-spec-selftests.c:
8352         * ser-tcp.c:
8353         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8354         override.
8355
8356         * symfile.c (find_separate_debug_file): Remove colon from the
8357         drive spec of DOS/Windows file names of the target, so that the
8358         file name produced from DEBUGDIR and the target's directory will
8359         be valid on DOS/Windows systems.
8360
8361 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8362
8363         * rust-lang.c (val_print_struct): Handle printing structures
8364         containing strings.
8365
8366 2019-05-02  Tom Tromey  <tromey@adacore.com>
8367
8368         * valarith.c (_initialize_valarith): Remove.
8369
8370 2019-05-01  Tom Tromey  <tromey@adacore.com>
8371
8372         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8373         bitfields.
8374
8375 2019-05-01  Tom Tromey  <tromey@adacore.com>
8376
8377         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8378         for big-endian copies.
8379
8380 2019-04-30  Ali Tamur  <tamur@google.com>
8381         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8382         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8383         (read_3_bytes): New function.
8384
8385 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8386
8387         * windows-nat.c (main_thread_id): Delete.
8388         (handle_output_debug_string): Replace main_thread_id by
8389         current_event.dwThreadId.
8390         (fake_create_process): Likewise.
8391         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8392         Do not set main_thread_id.
8393         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8394         current_event.dwThreadId.
8395         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8396
8397 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8398
8399         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8400         Use current_event.dwThreadId instead of main_thread_id.
8401
8402 2019-04-30  Tom Tromey  <tromey@adacore.com>
8403
8404         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8405         (create_excep_cond_exprs): Iterate over program spaces.
8406         (ada_exception_catchpoint_cond_string): Examine all minimal
8407         symbols for exception types.
8408
8409 2019-04-30  Tom Tromey  <tromey@adacore.com>
8410
8411         PR c++/24470:
8412         * dwarf2read.c (process_structure_scope): Handle case where type
8413         has template parameters but no symbol was created.
8414
8415 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8416             Chris January  <chris.january@arm.com>
8417
8418         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8419         qualifier.
8420         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8421
8422 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8423
8424         * f-typeprint.c (f_print_type): Update rules for printing
8425         whitespace.
8426         (f_type_print_varspec_suffix): Likewise.
8427
8428 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8429             Chris January  <chris.january@arm.com>
8430
8431         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8432         function arguments.
8433
8434 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8435
8436         * f-lang.c (build_fortran_types): Change name of void type to
8437         lower case.
8438         * f-typeprint.c (f_type_print_base): Print the name of the void
8439         type, rather than a fixed string.
8440         * f-valprint.c (f_decorations): Use lower case void string.
8441
8442 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8443             Chris January  <chris.january@arm.com>
8444
8445         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8446         types for Fortran.
8447
8448 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8449             Chris January  <chris.january@arm.com>
8450             David Lecomber  <david.lecomber@arm.com>
8451
8452         * f-exp.y (BINOP_INTRINSIC): New token.
8453         (exp): New parser rule handling BINOP_INTRINSIC.
8454         (f77_keywords): Add new builtin procedures.
8455         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8456         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8457         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8458         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8459         (print_unop_subexp_f): New function.
8460         (print_binop_subexp_f): New function.
8461         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8462         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8463         (dump_subexp_body_f): Likewise.
8464         (operator_check_f): Likewise.
8465         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8466         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8467
8468 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8469
8470         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8471         UNOP_KIND.
8472         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8473         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8474         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8475         (operator_length_f): New fuction.
8476         (print_subexp_f): New function.
8477         (op_name_f): New function.
8478         (dump_subexp_body_f): New function.
8479         (operator_check_f): New function.
8480         (exp_descriptor_f): Replace standard expression handling functions
8481         with new functions.
8482         * gdb/fortran-operator.def: New file.
8483         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8484         * gdb/std-operator.def: Remove UNOP_KIND.
8485
8486 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8487
8488         * std-operator.def: Remove unbalanced, stray double quote
8489         character.
8490
8491 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8492             Chris January  <chris.january@arm.com>
8493             Daniel Everett  <daniel.everett@arm.com>
8494             Nick Forrington  <nick.forrington@arm.com>
8495             Richard Bunt  <richard.bunt@arm.com>
8496
8497         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8498         of depth when printing anonymous structs or unions.
8499         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8500         Don't print either the top-level value, or the children if the
8501         max-depth is exceeded.
8502         (ppscm_print_children): When printing the key of a map, allow one
8503         extra level of depth.
8504         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8505         print either the top-level value, or the children if the max-depth
8506         is exceeded.
8507         (print_children): When printing the key of a map, allow one extra
8508         level of depth.
8509         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8510         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8511         (user_print_options): Initialise max_depth field.
8512         (val_print_scalar_or_string_type_p): New function.
8513         (val_print): Check to see if the max depth has been reached.
8514         (val_print_check_max_depth): Define new function.
8515         (show_print_max_depth): New function.
8516         (_initialize_valprint): Add 'print max-depth' option.
8517         * valprint.h (struct value_print_options) <max_depth>: New field.
8518         (val_print_check_max_depth): Declare new function.
8519         * NEWS: Document new feature.
8520
8521 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8522
8523         * ada-lang.c (ada_language_defn): Initialise new field.
8524         * c-lang.c (c_is_string_type_p): New function.
8525         (c_language_defn): Initialise new field.
8526         (cplus_language_defn): Initialise new field.
8527         (asm_language_defn): Initialise new field.
8528         (minimal_language_defn): Initialise new field.
8529         * c-lang.h (c_is_string_type_p): Declare new function.
8530         * d-lang.c (d_language_defn): Initialise new field.
8531         * f-lang.c (f_is_string_type_p): New function.
8532         (f_language_defn): Initialise new field.
8533         * go-lang.c (go_is_string_type_p): New function.
8534         (go_language_defn): Initialise new field.
8535         * language.c (default_is_string_type_p): New function.
8536         (unknown_language_defn): Initialise new field.
8537         (auto_language_defn): Initialise new field.
8538         * language.h (struct language_defn) <la_is_string_type_p>: New
8539         member variable.
8540         (default_is_string_type_p): Declare new function.
8541         * m2-lang.c (m2_language_defn): Initialise new field.
8542         * objc-lang.c (objc_language_defn): Initialise new field.
8543         * opencl-lang.c (opencl_language_defn): Initialise new field.
8544         * p-lang.c (pascal_is_string_type_p): New function.
8545         (pascal_language_defn): Initialise new field.
8546         * rust-lang.c (rust_is_string_type_p): New function.
8547         (rust_language_defn): Initialise new field.
8548
8549 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8550
8551         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8552         New field.
8553         * ada-lang.c (ada_language_defn): Initialise new field.
8554         * c-lang.c (c_language_defn): Likewise.
8555         (cplus_language_defn): Likewise.
8556         (asm_language_defn): Likewise.
8557         (minimal_language_defn): Likewise.
8558         * d-lang.c (d_language_defn): Likewise.
8559         * f-lang.c (f_language_defn): Likewise.
8560         * go-lang.c (go_language_defn): Likewise.
8561         * language.c (unknown_language_defn): Likewise.
8562         (auto_language_defn): Likewise.
8563         * m2-lang.c (m2_language_defn): Likewise.
8564         * objc-lang.c (objc_language_defn): Likewise.
8565         * opencl-lang.c (opencl_language_defn): Likewise.
8566         * p-lang.c (pascal_language_defn): Likewise.
8567         * rust-lang.c (rust_language_defn): Likewise.
8568
8569 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8570
8571         * ada-lang.c (ada_is_character_type): Change return type to bool.
8572         (ada_is_string_type): Likewise.
8573         * ada-lang.h (ada_is_character_type): Update declaration
8574         (ada_is_string_type): Likewise.
8575
8576 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8577
8578         Support style in 'frame|thread apply'
8579
8580         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8581         * record.c (record_start, record_stop): Update callers of
8582         execute_command_to_string with false.
8583         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8584         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8585         methods.
8586         (class string_file): New constructor with term_out parameter.
8587         Override methods term_out and can_emit_style_escape.  New member
8588         term_out.
8589         (class stdio_file): Override can_emit_style_escape.
8590         (class tee_file): Override term_out and can_emit_style_escape.
8591         * utils.h (can_emit_style_escape): Remove.
8592         * utils.c (can_emit_style_escape): Likewise.
8593         Update all callers of can_emit_style_escape (SOMESTREAM) to
8594         SOMESTREAM->can_emit_style_escape.
8595         * source-cache.c (source_cache::get_source_lines): Likewise.
8596         * stack.c (frame_apply_command_count): Call execute_command_to_string
8597         passing the term_out characteristic of the current gdb_stdout.
8598         * thread.c (thr_try_catch_cmd): Likewise.
8599         * top.c (execute_command_to_string): pass term_out parameter
8600         to construct the string_file for the command output.
8601         * ui-file.c (term_cli_styling): New function (most code moved
8602         from utils.c can_emit_style_escape).
8603         (string_file::string_file, string_file::can_emit_style_escape,
8604         stdio_file::can_emit_style_escape, tee_file::term_out,
8605         tee_file::can_emit_style_escape): New functions.
8606
8607 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8608
8609         * NEWS: Mention the new set|show may-call-functions.
8610         * infcall.c (may_call_functions_p): New variable.
8611         (show_may_call_functions_p): New function.
8612         (call_function_by_hand_dummy): Throws an error if not
8613         may-call-functions.
8614         (_initialize_infcall): Call add_setshow_boolean_cmd for
8615         may-call-functions.
8616
8617 2019-04-25  Keith Seitz  <keiths@redhat.com>
8618
8619         PR c++/24367
8620         * cp-support.c (inspect_type): Don't attempt substitutions
8621         of symbol with the same name.
8622
8623 2019-04-25  Tom Tromey  <tromey@adacore.com>
8624
8625         PR gdb/24475:
8626         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8627         static.
8628
8629 2019-04-25  Tom Tromey  <tromey@adacore.com>
8630
8631         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8632         rvalue reference.
8633         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8634         (gdb_xml_parser::parse): Use std::move.
8635         * python/python-internal.h (gdbpy_convert_exception): Take a const
8636         reference.
8637         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8638         std::move.
8639         * python/py-utils.c (gdbpy_convert_exception): Take a const
8640         reference.
8641         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8642         Use std::move.
8643         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8644         Use std::move.
8645         * mi/mi-main.c (mi_print_exception): Take a const reference.
8646         * main.c (handle_command_errors): Take a const reference.
8647         * linespec.c (parse_linespec): Use std::move.
8648         * infcall.c (run_inferior_call): Use std::move.
8649         (call_function_by_hand_dummy): Use std::move.
8650         * exec.c (try_open_exec_file): Use std::move.
8651         * exceptions.h (exception_print, exception_fprintf)
8652         (exception_print_same): Update.
8653         * exceptions.c (print_exception, exception_print)
8654         (exception_fprintf, exception_print_same): Change parameters to
8655         const reference.
8656         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8657         * common/new-op.c: Use std::move.
8658         * common/common-exceptions.h (struct gdb_exception): Add move
8659         constructor.
8660         (struct gdb_exception_error, struct gdb_exception_quit, struct
8661         gdb_quit_bad_alloc): Change constructor to move constructor.
8662         (throw_exception): Change parameter to rvalue reference.
8663         * common/common-exceptions.c (throw_exception): Take rvalue
8664         reference.
8665         * cli/cli-interp.c (safe_execute_command): Use std::move.
8666         * breakpoint.c (insert_bp_location, location_to_sals): Use
8667         std::move.
8668
8669 2019-04-25  Tom Tromey  <tromey@adacore.com>
8670
8671         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8672         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8673         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8674         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8675         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8676         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8677         guile/scm-value.c: Use unpack.
8678         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8679         gdbscm_gdb_exception.
8680         (gdbscm_throw_gdb_exception): Likewise.
8681         (struct gdbscm_gdb_exception): New.
8682         (unpack): New function.
8683         (gdbscm_wrap): Use unpack.
8684
8685 2019-04-25  Tom Tromey  <tromey@adacore.com>
8686
8687         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8688         (gdb_rl_callback_handler): Use std::move.
8689         * common/common-exceptions.h (struct gdb_exception): Add move
8690         assignment operator.
8691         (throw_exception_sjlj): Change "exception" to const reference.
8692         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8693         (throw_exception_sjlj): Change "exception" to const reference.
8694
8695 2019-04-25  Tom Tromey  <tromey@adacore.com>
8696
8697         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8698         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8699         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8700         Update.
8701         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8702         Update.
8703         * mi/mi-interp.c (mi_interp::exec): Update.
8704         * linespec.c (parse_linespec): Update.
8705         * infcall.c (run_inferior_call): Update.
8706         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8707         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8708         (gdbscm_lookup_global_symbol): Update.
8709         * guile/scm-param.c (gdbscm_parameter_value): Update.
8710         * guile/scm-frame.c (gdbscm_frame_read_register)
8711         (gdbscm_frame_read_var): Update.
8712         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8713         * exec.c (try_open_exec_file): Update.
8714         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8715         (gdb_rl_callback_handler): Update.
8716         * common/common-exceptions.h (exception_none): Don't declare.
8717         * common/common-exceptions.c (exception_none): Don't define.
8718         (struct catcher) <exception>: Update.
8719         * cli/cli-interp.c (safe_execute_command): Update.
8720         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8721
8722 2019-04-25  Ali Tamur  <tamur@google.com>
8723
8724         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8725         (read_attribute_value): Likewise.
8726         (dwarf2_read_addr_index): Update comment.
8727         (read_str_index): Add DW_FORM_strx.
8728         (dwarf2_string_attr): Likewise.
8729         (dwarf2_const_value_attr): Likewise.
8730         (dump_die_shallow): Likewise.
8731         (dwarf2_fetch_constant_bytes): Likewise.
8732         (skip_form_bytes): Likewise.
8733         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8734
8735 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8736
8737         PR corefiles/11608
8738         PR corefiles/18187
8739         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8740         OFFSET.  Verify if current mapping contains an ELF header.
8741         (linux_find_memory_regions_full): Adjust call to
8742         dump_mapping_p.
8743
8744 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8745             Kang Li <kanglictf@gmail.com>
8746
8747         PR gdb/21600
8748
8749         * dwarf2-frame.c (read_initial_length): Be consistent about using
8750         unsigned representation of length.
8751         (decode_frame_entry_1): Likewise.  Check for wraparound of
8752         end pointer as well as buffer overflow.
8753
8754 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8755
8756         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8757         "vq".
8758
8759 2019-04-24  Tom Tromey  <tromey@adacore.com>
8760
8761         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8762
8763 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8764
8765         * s12z-tdep.c (s12z_unwind_pc): Delete.
8766         (s12z_unwind_sp): Delete.
8767         (s12z_gdbarch_init): Don't register deleted functions with
8768         gdbarch.
8769
8770 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8771
8772         * rl78-tdep.c (rl78_unwind_sp): Delete.
8773         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8774
8775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8776
8777         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8778         (xstormy16_unwind_pc): Delete.
8779         (xstormy16_dummy_id): Delete.
8780         (xstormy16_gdbarch_init): Don't register deleted functions with
8781         gdbarch.
8782
8783 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8784
8785         * vax-tdep.c (vax_unwind_pc): Delete.
8786         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8787
8788 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8789
8790         * v850-tdep.c (v850_unwind_sp): Delete.
8791         (v850_unwind_pc): Delete.
8792         (v850_dummy_id): Delete.
8793         (v850_gdbarch_init): Don't register deleted functions with
8794         gdbarch.
8795
8796 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8797
8798         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8799         (tilegx_unwind_pc): Delete.
8800         (tilegx_unwind_dummy_id): Delete.
8801         (tilegx_gdbarch_init): Don't register deleted functions with
8802         gdbarch.
8803
8804 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8805
8806         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8807         (tic6x_dummy_id): Delete.
8808         (tic6x_gdbarch_init): Don't register deleted functions with
8809         gdbarch.
8810
8811 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8812
8813         * sparc-tdep.c (sparc_unwind_pc): Delete.
8814         (sparc32_gdbarch_init): Don't register deleted function with
8815         gdbarch.
8816
8817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8818
8819         * sh-tdep.c (sh_unwind_sp): Delete.
8820         (sh_unwind_pc): Delete.
8821         (sh_dummy_id): Delete.
8822         (sh_gdbarch_init): Don't register deleted functions with
8823         gdbarch.
8824
8825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8826
8827         * score-tdep.c (score_unwind_sp): Delete.
8828         (score_unwind_pc): Delete.
8829         (score_dummy_id): Delete.
8830         (score_gdbarch_init): Don't register deleted functions with
8831         gdbarch.
8832
8833 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8834
8835         * rx-tdep.c (rx_unwind_pc): Delete.
8836         (rx_unwind_sp): Delete.
8837         (rx_dummy_id): Delete.
8838         (rx_gdbarch_init): Don't register deleted functions with
8839         gdbarch.  Update comment.
8840
8841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8842
8843         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8844         (rs6000_dummy_id): Delete.
8845         (rs6000_gdbarch_init): Don't register deleted functions with
8846         gdbarch.
8847
8848 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8849
8850         * or1k-tdep.c (or1k_dummy_id): Delete.
8851         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8852
8853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8854
8855         * nios2-tdep.c (nios2_dummy_id): Delete.
8856         (nios2_unwind_sp): Delete.
8857         (nios2_gdbarch_init): Don't register deleted functions with
8858         gdbarch.
8859
8860 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8861
8862         * nds32-tdep.c (nds32_dummy_id): Delete.
8863         (nds32_unwind_pc): Delete.
8864         (nds32_unwind_sp): Delete.
8865         (nds32_gdbarch_init): Don't register deleted functions with
8866         gdbarch.
8867
8868 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8869
8870         * msp430-tdep.c (msp430_unwind_pc): Delete.
8871         (msp430_unwind_sp): Delete.
8872         (msp430_dummy_id): Delete.
8873         (msp430_gdbarch_init): Don't register deleted functions with
8874         gdbarch.
8875
8876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8877
8878         * moxie-tdep.c (moxie_unwind_sp): Delete.
8879         (moxie_unwind_pc): Delete.
8880         (moxie_dummy_id): Delete.
8881         (moxie_gdbarch_init): Don't register deleted functions with
8882         gdbarch.
8883
8884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8885
8886         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8887         (mn10300_unwind_pc): Delete.
8888         (mn10300_unwind_sp): Delete.
8889         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8890         mn10300_unwind_sp.
8891         (mn10300_frame_unwind_init): Don't register deleted functions with
8892         gdbarch.
8893
8894 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8895
8896         * mep-tdep.c (mep_unwind_pc): Delete.
8897         (mep_unwind_sp): Delete.
8898         (mep_dummy_id): Delete.
8899         (mep_gdbarch_init): Don't register deleted functions with
8900         gdbarch.
8901
8902 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8903
8904         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8905         (m68hc11_unwind_sp): Delete.
8906         (m68hc11_gdbarch_init): Don't register deleted functions with
8907         gdbarch.
8908
8909 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8910
8911         * m32r-tdep.c (m32r_unwind_sp): Delete.
8912         (m32r_unwind_pc): Delete.
8913         (m32r_dummy_id): Delete.
8914         (m32r_gdbarch_init): Don't register deleted functions with
8915         gdbarch.
8916
8917 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8918
8919         * m32c-tdep.c (m32c_unwind_pc): Delete.
8920         (m32c_unwind_sp): Delete.
8921         (m32c_dummy_id): Delete.
8922         (m32c_gdbarch_init): Don't register deleted functions with
8923         gdbarch.
8924
8925 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8926
8927         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8928         (lm32_unwind_pc): Delete.
8929         (lm32_dummy_id): Delete.
8930         (lm32_gdbarch_init): Don't register deleted functions with
8931         gdbarch.
8932
8933 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8934
8935         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8936         (iq2000_unwind_pc): Delete.
8937         (iq2000_dummy_id): Delete.
8938         (iq2000_gdbarch_init): Don't register deleted functions with
8939         gdbarch.
8940
8941 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8942
8943         * nds32-tdep.c (nds32_type_align): Delete.
8944         (nds32_push_dummy_call): Use type_align instead.
8945
8946 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8947
8948         * arm-tdep.c (arm_type_align): Only handle vector override case.
8949         (arm_push_dummy_call): Use type_align.
8950         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8951
8952 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8953
8954         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8955         case.
8956         (pass_on_stack): Use type_align.
8957         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8958         function.
8959
8960 2019-04-23  Tom Tromey  <tromey@adacore.com>
8961
8962         * dwarf2read.c (line_header::file_name_at): Remove unused
8963         overload.
8964
8965 2019-04-23  Tom de Vries  <tdevries@suse.de>
8966
8967         PR gdb/24438
8968         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8969         invocation.
8970
8971
8972 2019-03-27  Ali Tamur  <tamur@google.com>
8973
8974         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8975         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8976         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8977         (dwarf_expr_context::get_addr_index): Likewise
8978         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8979         (symbol_needs_eval_context::get_addr_index): Likewise
8980         (disassemble_dwarf_expression): Add DW_OP_addrx
8981         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8982         (read_cutu_die_from_dwo): Update comment
8983         (skip_one_die): Add DW_FORM_addrx
8984         (read_attribute_value): Likewise
8985         (var_decode_location): Add DW_OP_addrx
8986         (dwarf2_const_value_attr): Add DW_FORM_addrx
8987         (dump_die_shallow): Likewise
8988         (dwarf2_fetch_constant_bytes): Likewise
8989         (decode_locdesc): Add DW_OP_addrx
8990         (skip_form_bytes): Add DW_FORM_addrx
8991
8992 2019-04-22  Ali Tamur  <tamur@google.com>
8993
8994         * MAINTAINERS (Write After Approval): Add self.
8995
8996 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8997
8998         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8999         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9000         (open_symbol_file_object): Likewise.
9001         (svr4_default_sos): Add info parameter.
9002         (svr4_read_so_list): Likewise.
9003         (svr4_current_sos_direct): Adjust functions calls to pass down
9004         info.
9005         (svr4_current_sos_1): Add info parameter.
9006         (svr4_current_sos): Call get_svr4_info, pass info down to
9007         svr4_current_sos_1.
9008         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9009         get_svr4_info.
9010         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9011         get_svr4_info.
9012         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9013         to get_svr4_info.
9014         (probes_table_remove_objfile_probes): Likewise.
9015         (register_solib_event_probe): Add info parameter.
9016         (solist_update_incremental): Pass info parameter down to
9017         svr4_read_so_list.
9018         (disable_probes_interface): Add info parameter.
9019         (svr4_handle_solib_event): Pass current_program_space to
9020         get_svr4_info.  Adjust disable_probes_interface cleanup.
9021         (svr4_create_probe_breakpoints): Add info parameter, pass it
9022         down to register_solib_event_probe.
9023         (svr4_create_solib_event_breakpoints): Add info parameter,
9024         pass it down to svr4_create_probe_breakpoints.
9025         (enable_break): Pass info down to
9026         svr4_create_solib_event_breakpoints.
9027         (svr4_solib_create_inferior_hook): Pass current_program_space to
9028         get_svr4_info.
9029         (svr4_clear_solib): Likewise.
9030
9031 2019-04-22  Pedro Alves  <palves@redhat.com>
9032
9033         * solib-svr4.c (svr4_free_objfile_observer): New.
9034         (probe_and_action::objfile): New field.
9035         (probes_table_htab_remove_objfile_probes)
9036         (probes_table_remove_objfile_probes): New functions.
9037         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9038         in the new probe_and_action.  Don't store the probe in 'lookup'.
9039         (svr4_create_probe_breakpoints): Pass objfile to
9040         register_solib_event_probe.
9041         (_initialize_svr4_solib): Register a free_objfile observer.
9042
9043 2019-04-19  Tom Tromey  <tom@tromey.com>
9044
9045         * common/queue.h: Remove.
9046
9047 2019-04-19  Tom Tromey  <tom@tromey.com>
9048
9049         * event-loop.c: Don't include "common/queue.h".
9050
9051 2019-04-19  Tom Tromey  <tom@tromey.com>
9052
9053         * remote.c (remote_target): Use delete.
9054         * remote-notif.h: Include <list>, not "common/queue.h".
9055         (notif_client_p): Remove typedef.
9056         (remote_notif_state): Add constructor, destructor, initializer.
9057         <notif_queue>: Now a std::list.
9058         (remote_notif_state_xfree): Don't declare.
9059         * remote-notif.c (remote_notif_process, handle_notification)
9060         (remote_notif_state_allocate): Update.
9061         (~remote_notif_state): Rename from remote_notif_state_xfree.
9062
9063 2019-04-19  Tom Tromey  <tom@tromey.com>
9064
9065         * symfile.c (reread_symbols): Update.
9066         * objfiles.c (objfile_register_static_link)
9067         (objfile_lookup_static_link): Update
9068         (~objfile) Don't delete static_links.
9069         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9070
9071 2019-04-19  Tom Tromey  <tom@tromey.com>
9072
9073         * type-stack.h (struct type_stack) <insert>: Constify string.
9074         * type-stack.c (type_stack::insert): Constify string.
9075         * gdbtypes.h (lookup_template_type): Update.
9076         (address_space_name_to_int): Update.
9077         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9078         const.
9079         (lookup_template_type): Make name const.
9080         * c-exp.y: Update rules.
9081         (lex_one_token, classify_name, classify_inner_name)
9082         (c_print_token): Update.
9083         * p-exp.y: Update rules.
9084         (yylex): Update.
9085         * f-exp.y: Update rules.
9086         (yylex): Update.
9087         * d-exp.y: Update rules.
9088         (lex_one_token, classify_name, classify_inner_name): Update.
9089         * parse.c (write_dollar_variable, copy_name): Return std::string.
9090         * parser-defs.h (copy_name): Change return type.
9091         * m2-exp.y: Update rules.
9092         (yylex): Update.
9093         * go-exp.y (lex_one_token): Update.
9094         Update rules.
9095         (classify_unsafe_function, classify_packaged_name)
9096         (classify_name, yylex): Update.
9097
9098 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9099
9100         * configure.ac: add --enable-source-highlight switch.
9101         * configure: Regenerate.
9102         * top.c (print_gdb_version): plumb --enable-source-highlight
9103         status to "show configuration".
9104
9105 2019-04-19  Tom Tromey  <tromey@adacore.com>
9106
9107         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9108         Check ADA_TYPE_P.
9109         (empty_record, ada_template_to_fixed_record_type_1)
9110         (template_to_static_fixed_type)
9111         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9112         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9113         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9114         macros.
9115
9116 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9117
9118         PR symtab/24423:
9119         * source.c (print_source_lines_base): Advance "iter" when a
9120         control character is seen.
9121
9122 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9123
9124         * inferior.h (struct infcall_suspend_state_deleter):
9125         Catch exception in destructor to avoid crash.
9126
9127 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9128
9129         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9130         close to the add_com "shell".
9131
9132 2019-04-18  Tom Tromey  <tromey@adacore.com>
9133
9134         * process-stratum-target.h (class process_stratum_target)
9135         <stratum>: Add "final".
9136
9137 2019-04-17  Tom Tromey  <tromey@adacore.com>
9138
9139         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9140         against nullptr before use.
9141
9142 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9143
9144         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9145
9146 2019-04-17  Jim Wilson  <jimw@sifive.com>
9147             Andrew Burgess  <andrew.burgess@embecosm.com>
9148
9149         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9150         code read might fail, assume 4-byte breakpoint in that case.
9151
9152 2019-04-15  Leszek Swirski  <leszeks@google.com>
9153
9154         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9155         rather than a hand-rolled POD check when checking for forced MEMORY
9156         classification.
9157
9158 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9159
9160         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9161         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9162         function.
9163         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9164         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9165         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9166         declaration.
9167
9168 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9169
9170         * aarch64-linux-nat.c
9171         (aarch64_linux_nat_target::thread_architecture): Add override.
9172         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9173         each VQ.
9174
9175 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9176
9177         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9178
9179 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9180
9181         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9182         target types of size 96-bits, add some additional comments, and
9183         check that the builtin type we found was the correct size.
9184
9185 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9186
9187         * utils.c (prompt_for_continue): Don't restore the styling at the
9188         end, as applied_style has the wrong value.  This fixes styling in
9189         long lists of file names that are interrupted by the "Continue?"
9190         prompt.
9191
9192 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9193
9194         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9195         * c-lang.c (c_language_defn): Likewise.
9196         (cplus_language_defn): Likewise.
9197         (asm_language_defn): Likewise.
9198         (minimal_language_defn): Likewise.
9199         * d-lang.c (d_language_defn): Likewise.
9200         * f-lang.c (f_language_defn): Likewise.
9201         * go-lang.c (go_language_defn): Likewise.
9202         * language.c (unknown_language_defn): Likewise.
9203         (auto_language_defn): Likewise.
9204         * language.h (struct language_defn): Remove la_magic field.
9205         (LANG_MAGIC): Delete.
9206         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9207         * objc-lang.c (objc_language_defn): Likewise.
9208         * opencl-lang.c (opencl_language_defn): Likewise.
9209         * p-lang.c (pascal_language_defn): Likewise.
9210         * rust-lang.c (rust_language_defn): Likewise.
9211
9212 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9213
9214         * riscv-tdep.c (riscv_type_align): New function.
9215         (riscv_type_alignment): Delete.
9216         (riscv_arg_location): Use 'type_align'.
9217         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9218
9219 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9220
9221         * gdbtypes.c (type_align): A struct with no non-static fields also
9222         has alignment of 1.
9223
9224 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9225
9226         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9227         component to 0.
9228         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9229         member.
9230         (riscv_struct_info::analyse): New implementation using new
9231         analyse_inner member function.
9232         (riscv_struct_info::field_offset): New member function.
9233         (riscv_struct_info::m_offsets): New member variable.
9234         (riscv_struct_info::analyse_inner): New private member function,
9235         takes the old implementation of riscv_struct_info::analyse but
9236         extended to track field offsets.
9237         (riscv_call_arg_struct): Update the struct folding special cases
9238         to handle cases where empty C++ structs, which are non-zero
9239         length, are found.
9240         (riscv_arg_location): Initialise the length of each location, a
9241         non-zero length now indicates the location is in use.
9242         (riscv_push_dummy_call): Allow for the first location having a
9243         non-zero offset when setting up arguments.
9244         (riscv_return_value): Likewise, but for return values.
9245
9246 2019-04-11  Tom Tromey  <tromey@adacore.com>
9247
9248         * utils.c (internal_vproblem): Make "msg" const.
9249
9250 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9251
9252         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9253         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9254         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9255         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9256
9257 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9258
9259         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9260         function.
9261         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9262         of amd64_collect_native_gregset.
9263         (amd64_linux_nat_target::store_registers): Likewise.
9264
9265 2019-04-10  Tom Tromey  <tom@tromey.com>
9266
9267         * symtab.c (lookup_global_symbol_from_objfile)
9268         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9269         * objfiles.h (class separate_debug_iterator): New.
9270         (class separate_debug_range): New.
9271         (struct objfile) <separate_debug_objfiles>: New method.
9272         (objfile_separate_debug_iterate): Don't declare.
9273         * objfiles.c (separate_debug_iterator::operator++): Rename from
9274         objfile_separate_debug_iterate.
9275         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9276         iterator.
9277         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9278         iterator.
9279
9280 2019-04-10  Tom Tromey  <tom@tromey.com>
9281
9282         * symfile.c (reread_symbols): Remove old comment.
9283         * objfiles.c (free_all_objfiles): Fix a typo.
9284
9285 2019-04-10  Tom Tromey  <tom@tromey.com>
9286
9287         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9288         * minsyms.c (lookup_minimal_symbol): Use foreach.
9289         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9290         (lookup_minimal_symbol_solib_trampoline): Likewise.
9291         * symfile.c (reread_symbols): Use foreach.
9292
9293 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9294             Tom Tromey  <tromey@adacore.com>
9295
9296         PR rust/24414:
9297         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9298         (rust_lex_int_test): Change "value" to be LONGEST.
9299         (rust_lex_tests): Add test for long integer literal.
9300
9301 2019-04-09  Tom Tromey  <tromey@adacore.com>
9302
9303         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9304         to bool.
9305         (extended_remote_target::attach): Update.
9306         (remote_target::remote_notice_new_inferior): Update.
9307         (remote_target::add_current_inferior_and_thread): Update.
9308         * inferior.c (exit_inferior_1): Use "false".
9309         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9310
9311 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9312
9313         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9314         the "start" command.
9315
9316 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9317
9318         * python/py-inferior.c (infpy_thread_from_thread_handle):
9319         Adjust comments to reflect renaming of thread_from_thread_handle
9320         to thread_from_handle.  Adjust keywords.  Fix type error message.
9321         (inferior_object_methods): Add thread_from_handle.  Retain
9322         thread_from_thread_handle, but mark it as deprecated.
9323
9324 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9325
9326         * gdbthread.h (find_thread_by_handle): Revise declaration.
9327         * thread.c (find_thread_by_handle): Likewise.  Adjust
9328         implementation too.
9329         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9330         support for buffer objects as handles.
9331
9332 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9333
9334         * python/py-infthread.c (thpy_thread_handle): New function.
9335         (thread_object_methods): Register thpy_thread_handle.
9336
9337 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9338
9339         * gdbthread.h (thread_to_thread_handle): Declare.
9340         * thread.c (gdbtypes.h): Include.
9341         (thread_to_thread_handle): New function.
9342
9343         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9344         (target_thread_info_to_thread_handle): Declare.
9345         * target.c (target_thread_info_to_thread_handle): New function.
9346         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9347         * target-delegates.c: Regenerate.
9348
9349         * linux-thread-db.c (class thread_db_target): Add method
9350         thread_info_to_thread_handle.
9351         (thread_db_target::thread_info_to_thread_handle): Define.
9352         * remote.c (class remote_target): Add new method
9353         thread_info_to_thread_handle.
9354         (remote_target::thread_info_to_thread_handle): Define.
9355
9356 2019-04-08  Pedro Alves  <palves@redhat.com>
9357
9358         * common/common-exceptions.c (throw_exception): Don't create
9359         named object to throw; throw directly.
9360         (throw_it): Likewise.  Don't initialize gdb_exception::message
9361         here, with new; pass FMT and AP to the ctor instead.
9362         * common/common-exceptions.h: Include <string>.
9363         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9364         const char *, va_list)): New ctor.  Use std::make_shared.
9365         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9366         errors)): Delete.
9367         (gdb_exception_error::gdb_exception_error(enum errors, const char
9368         *, va_list)): New.
9369         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9370         Add assertion.
9371         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9372         errors)): Delete.
9373         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9374         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9375         Add assertion.
9376
9377 2019-04-08  Tom Tromey  <tom@tromey.com>
9378
9379         * valops.c (value_rtti_indirect_type): Replace throw_exception
9380         with throw.
9381         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9382         with throw.
9383         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9384         throw.
9385         * target.c (target_translate_tls_address): Replace throw_exception
9386         with throw.
9387         * stack.c (frame_apply_command_count): Replace throw_exception
9388         with throw.
9389         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9390         throw.
9391         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9392         with throw.
9393         * rs6000-tdep.c (rs6000_frame_cache)
9394         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9395         * remote.c: Replace throw_exception with throw.
9396         * record-full.c (record_full_message, record_full_wait_1)
9397         (record_full_restore): Replace throw_exception with throw.
9398         * record-btrace.c:
9399         (get_thread_current_frame_id, record_btrace_start_replaying)
9400         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9401         (cmd_record_btrace_start): Replace throw_exception with throw.
9402         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9403         throw.
9404         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9405         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9406         * linespec.c:
9407         (find_linespec_symbols): Replace throw_exception with throw.
9408         * infrun.c (displaced_step_prepare, resume): Replace
9409         throw_exception with throw.
9410         * infcmd.c (post_create_inferior): Replace throw_exception with
9411         throw.
9412         * inf-loop.c (inferior_event_handler): Replace throw_exception
9413         with throw.
9414         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9415         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9416         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9417         (get_prev_frame_always, get_frame_pc_if_available)
9418         (get_frame_address_in_block_if_available, get_frame_language):
9419         Replace throw_exception with throw.
9420         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9421         throw_exception with throw.
9422         * eval.c (fetch_subexp_value, evaluate_var_value)
9423         (evaluate_funcall, evaluate_subexp_standard): Replace
9424         throw_exception with throw.
9425         * dwarf2loc.c (call_site_find_chain)
9426         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9427         Replace throw_exception with throw.
9428         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9429         with throw.
9430         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9431         throw.
9432         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9433         * completer.c (complete_line_internal): Replace throw_exception
9434         with throw.
9435         * compile/compile-object-run.c (compile_object_run): Replace
9436         throw_exception with throw.
9437         * cli/cli-script.c (process_next_line): Replace throw_exception
9438         with throw.
9439         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9440         (btrace_enable, btrace_maint_update_pt_packets): Replace
9441         throw_exception with throw.
9442         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9443         throw_exception with throw.
9444         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9445         throw_exception with throw.
9446         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9447         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9448         * aarch64-tdep.c (aarch64_make_prologue_cache)
9449         (aarch64_make_stub_cache): Replace throw_exception with throw.
9450
9451 2019-04-08  Tom Tromey  <tom@tromey.com>
9452
9453         * common/common-exceptions.c (throw_exception): Rename from
9454         throw_exception_cxx.  Remove old copy.  Make argument const.
9455         (throw_it): Create and throw exception objects directly.
9456         * common/common-exceptions.h (throw_exception): Make argument
9457         const.
9458         (struct gdb_exception_error): Add constructor.
9459         (struct gdb_exception_quit): Add constructor.
9460
9461 2019-04-08  Tom Tromey  <tom@tromey.com>
9462
9463         * common/common-exceptions.h (exception_rethrow): Don't declare.
9464         (TRY_SJLJ): Update comment.
9465         (TRY, CATCH, END_CATCH): Remove.
9466         * common/common-exceptions.c (exception_rethrow): Remove.
9467
9468 2019-04-08  Tom Tromey  <tom@tromey.com>
9469
9470         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9471         Remove.
9472         (gdb_exception_error): Rename from
9473         gdb_exception_RETURN_MASK_ERROR.
9474         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9475         (gdb_quit_bad_alloc): Update.
9476         * aarch64-tdep.c: Update.
9477         * ada-lang.c: Update.
9478         * ada-typeprint.c: Update.
9479         * ada-valprint.c: Update.
9480         * amd64-tdep.c: Update.
9481         * arch-utils.c: Update.
9482         * break-catch-throw.c: Update.
9483         * breakpoint.c: Update.
9484         * btrace.c: Update.
9485         * c-varobj.c: Update.
9486         * cli/cli-cmds.c: Update.
9487         * cli/cli-interp.c: Update.
9488         * cli/cli-script.c: Update.
9489         * common/common-exceptions.c: Update.
9490         * common/new-op.c: Update.
9491         * common/selftest.c: Update.
9492         * compile/compile-c-symbols.c: Update.
9493         * compile/compile-cplus-symbols.c: Update.
9494         * compile/compile-object-load.c: Update.
9495         * compile/compile-object-run.c: Update.
9496         * completer.c: Update.
9497         * corelow.c: Update.
9498         * cp-abi.c: Update.
9499         * cp-support.c: Update.
9500         * cp-valprint.c: Update.
9501         * darwin-nat.c: Update.
9502         * disasm-selftests.c: Update.
9503         * dtrace-probe.c: Update.
9504         * dwarf-index-cache.c: Update.
9505         * dwarf-index-write.c: Update.
9506         * dwarf2-frame-tailcall.c: Update.
9507         * dwarf2-frame.c: Update.
9508         * dwarf2loc.c: Update.
9509         * dwarf2read.c: Update.
9510         * eval.c: Update.
9511         * event-loop.c: Update.
9512         * event-top.c: Update.
9513         * exec.c: Update.
9514         * f-valprint.c: Update.
9515         * fbsd-tdep.c: Update.
9516         * frame-unwind.c: Update.
9517         * frame.c: Update.
9518         * gdbtypes.c: Update.
9519         * gnu-v3-abi.c: Update.
9520         * guile/guile-internal.h: Update.
9521         * guile/scm-block.c: Update.
9522         * guile/scm-breakpoint.c: Update.
9523         * guile/scm-cmd.c: Update.
9524         * guile/scm-disasm.c: Update.
9525         * guile/scm-frame.c: Update.
9526         * guile/scm-lazy-string.c: Update.
9527         * guile/scm-math.c: Update.
9528         * guile/scm-param.c: Update.
9529         * guile/scm-ports.c: Update.
9530         * guile/scm-pretty-print.c: Update.
9531         * guile/scm-symbol.c: Update.
9532         * guile/scm-symtab.c: Update.
9533         * guile/scm-type.c: Update.
9534         * guile/scm-value.c: Update.
9535         * i386-linux-tdep.c: Update.
9536         * i386-tdep.c: Update.
9537         * inf-loop.c: Update.
9538         * infcall.c: Update.
9539         * infcmd.c: Update.
9540         * infrun.c: Update.
9541         * jit.c: Update.
9542         * language.c: Update.
9543         * linespec.c: Update.
9544         * linux-fork.c: Update.
9545         * linux-nat.c: Update.
9546         * linux-tdep.c: Update.
9547         * linux-thread-db.c: Update.
9548         * main.c: Update.
9549         * mi/mi-cmd-break.c: Update.
9550         * mi/mi-cmd-stack.c: Update.
9551         * mi/mi-interp.c: Update.
9552         * mi/mi-main.c: Update.
9553         * objc-lang.c: Update.
9554         * p-valprint.c: Update.
9555         * parse.c: Update.
9556         * ppc-linux-tdep.c: Update.
9557         * printcmd.c: Update.
9558         * python/py-arch.c: Update.
9559         * python/py-breakpoint.c: Update.
9560         * python/py-cmd.c: Update.
9561         * python/py-finishbreakpoint.c: Update.
9562         * python/py-frame.c: Update.
9563         * python/py-framefilter.c: Update.
9564         * python/py-gdb-readline.c: Update.
9565         * python/py-inferior.c: Update.
9566         * python/py-infthread.c: Update.
9567         * python/py-lazy-string.c: Update.
9568         * python/py-linetable.c: Update.
9569         * python/py-objfile.c: Update.
9570         * python/py-param.c: Update.
9571         * python/py-prettyprint.c: Update.
9572         * python/py-progspace.c: Update.
9573         * python/py-record-btrace.c: Update.
9574         * python/py-record.c: Update.
9575         * python/py-symbol.c: Update.
9576         * python/py-type.c: Update.
9577         * python/py-unwind.c: Update.
9578         * python/py-utils.c: Update.
9579         * python/py-value.c: Update.
9580         * python/python.c: Update.
9581         * record-btrace.c: Update.
9582         * record-full.c: Update.
9583         * remote-fileio.c: Update.
9584         * remote.c: Update.
9585         * riscv-tdep.c: Update.
9586         * rs6000-aix-tdep.c: Update.
9587         * rs6000-tdep.c: Update.
9588         * rust-exp.y: Update.
9589         * rust-lang.c: Update.
9590         * s390-tdep.c: Update.
9591         * selftest-arch.c: Update.
9592         * solib-dsbt.c: Update.
9593         * solib-frv.c: Update.
9594         * solib-spu.c: Update.
9595         * solib-svr4.c: Update.
9596         * solib.c: Update.
9597         * sparc64-linux-tdep.c: Update.
9598         * stack.c: Update.
9599         * symfile-mem.c: Update.
9600         * symmisc.c: Update.
9601         * target.c: Update.
9602         * thread.c: Update.
9603         * top.c: Update.
9604         * tracefile-tfile.c: Update.
9605         * tui/tui.c: Update.
9606         * typeprint.c: Update.
9607         * unittests/cli-utils-selftests.c: Update.
9608         * unittests/parse-connection-spec-selftests.c: Update.
9609         * valops.c: Update.
9610         * valprint.c: Update.
9611         * value.c: Update.
9612         * varobj.c: Update.
9613         * windows-nat.c: Update.
9614         * x86-linux-nat.c: Update.
9615         * xml-support.c: Update.
9616
9617 2019-04-08  Tom Tromey  <tom@tromey.com>
9618
9619         * xml-support.c: Use C++ exception handling.
9620         * x86-linux-nat.c: Use C++ exception handling.
9621         * windows-nat.c: Use C++ exception handling.
9622         * varobj.c: Use C++ exception handling.
9623         * value.c: Use C++ exception handling.
9624         * valprint.c: Use C++ exception handling.
9625         * valops.c: Use C++ exception handling.
9626         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9627         handling.
9628         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9629         * typeprint.c: Use C++ exception handling.
9630         * tui/tui.c: Use C++ exception handling.
9631         * tracefile-tfile.c: Use C++ exception handling.
9632         * top.c: Use C++ exception handling.
9633         * thread.c: Use C++ exception handling.
9634         * target.c: Use C++ exception handling.
9635         * symmisc.c: Use C++ exception handling.
9636         * symfile-mem.c: Use C++ exception handling.
9637         * stack.c: Use C++ exception handling.
9638         * sparc64-linux-tdep.c: Use C++ exception handling.
9639         * solib.c: Use C++ exception handling.
9640         * solib-svr4.c: Use C++ exception handling.
9641         * solib-spu.c: Use C++ exception handling.
9642         * solib-frv.c: Use C++ exception handling.
9643         * solib-dsbt.c: Use C++ exception handling.
9644         * selftest-arch.c: Use C++ exception handling.
9645         * s390-tdep.c: Use C++ exception handling.
9646         * rust-lang.c: Use C++ exception handling.
9647         * rust-exp.y: Use C++ exception handling.
9648         * rs6000-tdep.c: Use C++ exception handling.
9649         * rs6000-aix-tdep.c: Use C++ exception handling.
9650         * riscv-tdep.c: Use C++ exception handling.
9651         * remote.c: Use C++ exception handling.
9652         * remote-fileio.c: Use C++ exception handling.
9653         * record-full.c: Use C++ exception handling.
9654         * record-btrace.c: Use C++ exception handling.
9655         * python/python.c: Use C++ exception handling.
9656         * python/py-value.c: Use C++ exception handling.
9657         * python/py-utils.c: Use C++ exception handling.
9658         * python/py-unwind.c: Use C++ exception handling.
9659         * python/py-type.c: Use C++ exception handling.
9660         * python/py-symbol.c: Use C++ exception handling.
9661         * python/py-record.c: Use C++ exception handling.
9662         * python/py-record-btrace.c: Use C++ exception handling.
9663         * python/py-progspace.c: Use C++ exception handling.
9664         * python/py-prettyprint.c: Use C++ exception handling.
9665         * python/py-param.c: Use C++ exception handling.
9666         * python/py-objfile.c: Use C++ exception handling.
9667         * python/py-linetable.c: Use C++ exception handling.
9668         * python/py-lazy-string.c: Use C++ exception handling.
9669         * python/py-infthread.c: Use C++ exception handling.
9670         * python/py-inferior.c: Use C++ exception handling.
9671         * python/py-gdb-readline.c: Use C++ exception handling.
9672         * python/py-framefilter.c: Use C++ exception handling.
9673         * python/py-frame.c: Use C++ exception handling.
9674         * python/py-finishbreakpoint.c: Use C++ exception handling.
9675         * python/py-cmd.c: Use C++ exception handling.
9676         * python/py-breakpoint.c: Use C++ exception handling.
9677         * python/py-arch.c: Use C++ exception handling.
9678         * printcmd.c: Use C++ exception handling.
9679         * ppc-linux-tdep.c: Use C++ exception handling.
9680         * parse.c: Use C++ exception handling.
9681         * p-valprint.c: Use C++ exception handling.
9682         * objc-lang.c: Use C++ exception handling.
9683         * mi/mi-main.c: Use C++ exception handling.
9684         * mi/mi-interp.c: Use C++ exception handling.
9685         * mi/mi-cmd-stack.c: Use C++ exception handling.
9686         * mi/mi-cmd-break.c: Use C++ exception handling.
9687         * main.c: Use C++ exception handling.
9688         * linux-thread-db.c: Use C++ exception handling.
9689         * linux-tdep.c: Use C++ exception handling.
9690         * linux-nat.c: Use C++ exception handling.
9691         * linux-fork.c: Use C++ exception handling.
9692         * linespec.c: Use C++ exception handling.
9693         * language.c: Use C++ exception handling.
9694         * jit.c: Use C++ exception handling.
9695         * infrun.c: Use C++ exception handling.
9696         * infcmd.c: Use C++ exception handling.
9697         * infcall.c: Use C++ exception handling.
9698         * inf-loop.c: Use C++ exception handling.
9699         * i386-tdep.c: Use C++ exception handling.
9700         * i386-linux-tdep.c: Use C++ exception handling.
9701         * guile/scm-value.c: Use C++ exception handling.
9702         * guile/scm-type.c: Use C++ exception handling.
9703         * guile/scm-symtab.c: Use C++ exception handling.
9704         * guile/scm-symbol.c: Use C++ exception handling.
9705         * guile/scm-pretty-print.c: Use C++ exception handling.
9706         * guile/scm-ports.c: Use C++ exception handling.
9707         * guile/scm-param.c: Use C++ exception handling.
9708         * guile/scm-math.c: Use C++ exception handling.
9709         * guile/scm-lazy-string.c: Use C++ exception handling.
9710         * guile/scm-frame.c: Use C++ exception handling.
9711         * guile/scm-disasm.c: Use C++ exception handling.
9712         * guile/scm-cmd.c: Use C++ exception handling.
9713         * guile/scm-breakpoint.c: Use C++ exception handling.
9714         * guile/scm-block.c: Use C++ exception handling.
9715         * guile/guile-internal.h: Use C++ exception handling.
9716         * gnu-v3-abi.c: Use C++ exception handling.
9717         * gdbtypes.c: Use C++ exception handling.
9718         * frame.c: Use C++ exception handling.
9719         * frame-unwind.c: Use C++ exception handling.
9720         * fbsd-tdep.c: Use C++ exception handling.
9721         * f-valprint.c: Use C++ exception handling.
9722         * exec.c: Use C++ exception handling.
9723         * event-top.c: Use C++ exception handling.
9724         * event-loop.c: Use C++ exception handling.
9725         * eval.c: Use C++ exception handling.
9726         * dwarf2read.c: Use C++ exception handling.
9727         * dwarf2loc.c: Use C++ exception handling.
9728         * dwarf2-frame.c: Use C++ exception handling.
9729         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9730         * dwarf-index-write.c: Use C++ exception handling.
9731         * dwarf-index-cache.c: Use C++ exception handling.
9732         * dtrace-probe.c: Use C++ exception handling.
9733         * disasm-selftests.c: Use C++ exception handling.
9734         * darwin-nat.c: Use C++ exception handling.
9735         * cp-valprint.c: Use C++ exception handling.
9736         * cp-support.c: Use C++ exception handling.
9737         * cp-abi.c: Use C++ exception handling.
9738         * corelow.c: Use C++ exception handling.
9739         * completer.c: Use C++ exception handling.
9740         * compile/compile-object-run.c: Use C++ exception handling.
9741         * compile/compile-object-load.c: Use C++ exception handling.
9742         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9743         * compile/compile-c-symbols.c: Use C++ exception handling.
9744         * common/selftest.c: Use C++ exception handling.
9745         * common/new-op.c: Use C++ exception handling.
9746         * cli/cli-script.c: Use C++ exception handling.
9747         * cli/cli-interp.c: Use C++ exception handling.
9748         * cli/cli-cmds.c: Use C++ exception handling.
9749         * c-varobj.c: Use C++ exception handling.
9750         * btrace.c: Use C++ exception handling.
9751         * breakpoint.c: Use C++ exception handling.
9752         * break-catch-throw.c: Use C++ exception handling.
9753         * arch-utils.c: Use C++ exception handling.
9754         * amd64-tdep.c: Use C++ exception handling.
9755         * ada-valprint.c: Use C++ exception handling.
9756         * ada-typeprint.c: Use C++ exception handling.
9757         * ada-lang.c: Use C++ exception handling.
9758         * aarch64-tdep.c: Use C++ exception handling.
9759
9760 2019-04-08  Tom Tromey  <tom@tromey.com>
9761
9762         * xml-support.c (gdb_xml_parser::parse): Update.
9763         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9764         * value.c (show_convenience): Update.
9765         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9766         (test_parse_flags_qcs): Update.
9767         * thread.c (thr_try_catch_cmd): Update.
9768         * target.c (target_translate_tls_address): Update.
9769         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9770         (info_frame_command_core, frame_apply_command_count): Update.
9771         * rust-exp.y (rust_lex_exception_test): Update.
9772         * riscv-tdep.c (riscv_print_one_register_info): Update.
9773         * remote.c (remote_target::enable_btrace): Update.
9774         * record-btrace.c (record_btrace_enable_warn): Update.
9775         * python/py-utils.c (gdbpy_convert_exception): Update.
9776         * printcmd.c (do_one_display, print_variable_and_value): Update.
9777         * mi/mi-main.c (mi_print_exception): Update.
9778         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9779         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9780         * linux-nat.c (linux_nat_target::attach): Update.
9781         * linux-fork.c (class scoped_switch_fork_info): Update.
9782         * infrun.c (displaced_step_prepare): Update.
9783         * infcall.c (call_function_by_hand_dummy): Update.
9784         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9785         * gnu-v3-abi.c (print_one_vtable): Update.
9786         * frame.c (get_prev_frame_always): Update.
9787         * f-valprint.c (info_common_command_for_block): Update.
9788         * exec.c (try_open_exec_file): Update.
9789         * exceptions.c (print_exception, exception_print)
9790         (exception_fprintf, exception_print_same): Update.
9791         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9792         * dwarf-index-cache.c (index_cache::store)
9793         (index_cache::lookup_gdb_index): Update.
9794         * darwin-nat.c (maybe_cache_shell): Update.
9795         * cp-valprint.c (cp_print_value_fields): Update.
9796         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9797         (gcc_cplus_symbol_address): Update.
9798         * compile/compile-c-symbols.c (gcc_convert_symbol)
9799         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9800         * common/selftest.c: Update.
9801         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9802         a std::string.
9803         (exception_try_scope_entry, exception_try_scope_exit): Don't
9804         declare.
9805         (struct exception_try_scope): Remove.
9806         (TRY): Don't use exception_try_scope.
9807         (struct gdb_exception): Add constructor, operator=.
9808         <what>: New method.
9809         (struct gdb_exception_RETURN_MASK_ALL)
9810         (struct gdb_exception_RETURN_MASK_ERROR)
9811         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9812         (struct gdb_quit_bad_alloc): Update.
9813         * common/common-exceptions.c (exception_none): Change
9814         initializer.
9815         (struct catcher) <state, exception>: Initialize inline.
9816         <prev>: Remove member.
9817         (current_catcher): Remove.
9818         (catchers): New global.
9819         (exceptions_state_mc_init): Simplify.
9820         (catcher_pop): Remove.
9821         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9822         (try_scope_depth, exception_try_scope_entry)
9823         (exception_try_scope_exit): Remove.
9824         (throw_exception_sjlj): Update.
9825         (exception_messages, exception_messages_size): Remove.
9826         (throw_it): Simplify.
9827         (gdb_exception_sliced_copy): Remove.
9828         (throw_exception_cxx): Update.
9829         * cli/cli-script.c (script_from_file): Update.
9830         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9831         Update.
9832         * ada-valprint.c (ada_val_print): Update.
9833         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9834         (create_excep_cond_exprs): Update.
9835
9836 2019-04-08  Tom Tromey  <tom@tromey.com>
9837
9838         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9839         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9840         (TRY, CATCH, END_CATCH): Remove some definitions.
9841         * common/common-exceptions.c: Don't use GDB_XCPT.
9842         (catcher_list_size): Remove.
9843         (throw_exception, throw_it): Simplify.
9844
9845 2019-04-05  Tom Tromey  <tom@tromey.com>
9846
9847         Revert the header-sorting patch.
9848         * ft32-tdep.c: Revert.
9849         * frv-tdep.c: Revert.
9850         * frv-linux-tdep.c: Revert.
9851         * frame.c: Revert.
9852         * frame-unwind.c: Revert.
9853         * frame-base.c: Revert.
9854         * fork-child.c: Revert.
9855         * findvar.c: Revert.
9856         * findcmd.c: Revert.
9857         * filesystem.c: Revert.
9858         * filename-seen-cache.h: Revert.
9859         * filename-seen-cache.c: Revert.
9860         * fbsd-tdep.c: Revert.
9861         * fbsd-nat.h: Revert.
9862         * fbsd-nat.c: Revert.
9863         * f-valprint.c: Revert.
9864         * f-typeprint.c: Revert.
9865         * f-lang.c: Revert.
9866         * extension.h: Revert.
9867         * extension.c: Revert.
9868         * extension-priv.h: Revert.
9869         * expprint.c: Revert.
9870         * exec.h: Revert.
9871         * exec.c: Revert.
9872         * exceptions.c: Revert.
9873         * event-top.c: Revert.
9874         * event-loop.c: Revert.
9875         * eval.c: Revert.
9876         * elfread.c: Revert.
9877         * dwarf2read.h: Revert.
9878         * dwarf2read.c: Revert.
9879         * dwarf2loc.c: Revert.
9880         * dwarf2expr.h: Revert.
9881         * dwarf2expr.c: Revert.
9882         * dwarf2-frame.c: Revert.
9883         * dwarf2-frame-tailcall.c: Revert.
9884         * dwarf-index-write.h: Revert.
9885         * dwarf-index-write.c: Revert.
9886         * dwarf-index-common.c: Revert.
9887         * dwarf-index-cache.h: Revert.
9888         * dwarf-index-cache.c: Revert.
9889         * dummy-frame.c: Revert.
9890         * dtrace-probe.c: Revert.
9891         * disasm.h: Revert.
9892         * disasm.c: Revert.
9893         * disasm-selftests.c: Revert.
9894         * dictionary.c: Revert.
9895         * dicos-tdep.c: Revert.
9896         * demangle.c: Revert.
9897         * dcache.h: Revert.
9898         * dcache.c: Revert.
9899         * darwin-nat.h: Revert.
9900         * darwin-nat.c: Revert.
9901         * darwin-nat-info.c: Revert.
9902         * d-valprint.c: Revert.
9903         * d-namespace.c: Revert.
9904         * d-lang.c: Revert.
9905         * ctf.c: Revert.
9906         * csky-tdep.c: Revert.
9907         * csky-linux-tdep.c: Revert.
9908         * cris-tdep.c: Revert.
9909         * cris-linux-tdep.c: Revert.
9910         * cp-valprint.c: Revert.
9911         * cp-support.c: Revert.
9912         * cp-namespace.c: Revert.
9913         * cp-abi.c: Revert.
9914         * corelow.c: Revert.
9915         * corefile.c: Revert.
9916         * continuations.c: Revert.
9917         * completer.h: Revert.
9918         * completer.c: Revert.
9919         * complaints.c: Revert.
9920         * coffread.c: Revert.
9921         * coff-pe-read.c: Revert.
9922         * cli-out.h: Revert.
9923         * cli-out.c: Revert.
9924         * charset.c: Revert.
9925         * c-varobj.c: Revert.
9926         * c-valprint.c: Revert.
9927         * c-typeprint.c: Revert.
9928         * c-lang.c: Revert.
9929         * buildsym.c: Revert.
9930         * buildsym-legacy.c: Revert.
9931         * build-id.h: Revert.
9932         * build-id.c: Revert.
9933         * btrace.c: Revert.
9934         * bsd-uthread.c: Revert.
9935         * breakpoint.h: Revert.
9936         * breakpoint.c: Revert.
9937         * break-catch-throw.c: Revert.
9938         * break-catch-syscall.c: Revert.
9939         * break-catch-sig.c: Revert.
9940         * blockframe.c: Revert.
9941         * block.c: Revert.
9942         * bfin-tdep.c: Revert.
9943         * bfin-linux-tdep.c: Revert.
9944         * bfd-target.c: Revert.
9945         * bcache.c: Revert.
9946         * ax-general.c: Revert.
9947         * ax-gdb.h: Revert.
9948         * ax-gdb.c: Revert.
9949         * avr-tdep.c: Revert.
9950         * auxv.c: Revert.
9951         * auto-load.c: Revert.
9952         * arm-wince-tdep.c: Revert.
9953         * arm-tdep.c: Revert.
9954         * arm-symbian-tdep.c: Revert.
9955         * arm-pikeos-tdep.c: Revert.
9956         * arm-obsd-tdep.c: Revert.
9957         * arm-nbsd-tdep.c: Revert.
9958         * arm-nbsd-nat.c: Revert.
9959         * arm-linux-tdep.c: Revert.
9960         * arm-linux-nat.c: Revert.
9961         * arm-fbsd-tdep.c: Revert.
9962         * arm-fbsd-nat.c: Revert.
9963         * arm-bsd-tdep.c: Revert.
9964         * arch-utils.c: Revert.
9965         * arc-tdep.c: Revert.
9966         * arc-newlib-tdep.c: Revert.
9967         * annotate.h: Revert.
9968         * annotate.c: Revert.
9969         * amd64-windows-tdep.c: Revert.
9970         * amd64-windows-nat.c: Revert.
9971         * amd64-tdep.c: Revert.
9972         * amd64-sol2-tdep.c: Revert.
9973         * amd64-obsd-tdep.c: Revert.
9974         * amd64-obsd-nat.c: Revert.
9975         * amd64-nbsd-tdep.c: Revert.
9976         * amd64-nbsd-nat.c: Revert.
9977         * amd64-nat.c: Revert.
9978         * amd64-linux-tdep.c: Revert.
9979         * amd64-linux-nat.c: Revert.
9980         * amd64-fbsd-tdep.c: Revert.
9981         * amd64-fbsd-nat.c: Revert.
9982         * amd64-dicos-tdep.c: Revert.
9983         * amd64-darwin-tdep.c: Revert.
9984         * amd64-bsd-nat.c: Revert.
9985         * alpha-tdep.c: Revert.
9986         * alpha-obsd-tdep.c: Revert.
9987         * alpha-nbsd-tdep.c: Revert.
9988         * alpha-mdebug-tdep.c: Revert.
9989         * alpha-linux-tdep.c: Revert.
9990         * alpha-linux-nat.c: Revert.
9991         * alpha-bsd-tdep.c: Revert.
9992         * alpha-bsd-nat.c: Revert.
9993         * aix-thread.c: Revert.
9994         * agent.c: Revert.
9995         * addrmap.c: Revert.
9996         * ada-varobj.c: Revert.
9997         * ada-valprint.c: Revert.
9998         * ada-typeprint.c: Revert.
9999         * ada-tasks.c: Revert.
10000         * ada-lang.c: Revert.
10001         * aarch64-tdep.c: Revert.
10002         * aarch64-ravenscar-thread.c: Revert.
10003         * aarch64-newlib-tdep.c: Revert.
10004         * aarch64-linux-tdep.c: Revert.
10005         * aarch64-linux-nat.c: Revert.
10006         * aarch64-fbsd-tdep.c: Revert.
10007         * aarch64-fbsd-nat.c: Revert.
10008         * aarch32-linux-nat.c: Revert.
10009
10010 2019-04-05  Tom Tromey  <tom@tromey.com>
10011
10012         * ft32-tdep.c: Sort headers.
10013         * frv-tdep.c: Sort headers.
10014         * frv-linux-tdep.c: Sort headers.
10015         * frame.c: Sort headers.
10016         * frame-unwind.c: Sort headers.
10017         * frame-base.c: Sort headers.
10018         * fork-child.c: Sort headers.
10019         * findvar.c: Sort headers.
10020         * findcmd.c: Sort headers.
10021         * filesystem.c: Sort headers.
10022         * filename-seen-cache.h: Sort headers.
10023         * filename-seen-cache.c: Sort headers.
10024         * fbsd-tdep.c: Sort headers.
10025         * fbsd-nat.h: Sort headers.
10026         * fbsd-nat.c: Sort headers.
10027         * f-valprint.c: Sort headers.
10028         * f-typeprint.c: Sort headers.
10029         * f-lang.c: Sort headers.
10030         * extension.h: Sort headers.
10031         * extension.c: Sort headers.
10032         * extension-priv.h: Sort headers.
10033         * expprint.c: Sort headers.
10034         * exec.h: Sort headers.
10035         * exec.c: Sort headers.
10036         * exceptions.c: Sort headers.
10037         * event-top.c: Sort headers.
10038         * event-loop.c: Sort headers.
10039         * eval.c: Sort headers.
10040         * elfread.c: Sort headers.
10041         * dwarf2read.h: Sort headers.
10042         * dwarf2read.c: Sort headers.
10043         * dwarf2loc.c: Sort headers.
10044         * dwarf2expr.h: Sort headers.
10045         * dwarf2expr.c: Sort headers.
10046         * dwarf2-frame.c: Sort headers.
10047         * dwarf2-frame-tailcall.c: Sort headers.
10048         * dwarf-index-write.h: Sort headers.
10049         * dwarf-index-write.c: Sort headers.
10050         * dwarf-index-common.c: Sort headers.
10051         * dwarf-index-cache.h: Sort headers.
10052         * dwarf-index-cache.c: Sort headers.
10053         * dummy-frame.c: Sort headers.
10054         * dtrace-probe.c: Sort headers.
10055         * disasm.h: Sort headers.
10056         * disasm.c: Sort headers.
10057         * disasm-selftests.c: Sort headers.
10058         * dictionary.c: Sort headers.
10059         * dicos-tdep.c: Sort headers.
10060         * demangle.c: Sort headers.
10061         * dcache.h: Sort headers.
10062         * dcache.c: Sort headers.
10063         * darwin-nat.h: Sort headers.
10064         * darwin-nat.c: Sort headers.
10065         * darwin-nat-info.c: Sort headers.
10066         * d-valprint.c: Sort headers.
10067         * d-namespace.c: Sort headers.
10068         * d-lang.c: Sort headers.
10069         * ctf.c: Sort headers.
10070         * csky-tdep.c: Sort headers.
10071         * csky-linux-tdep.c: Sort headers.
10072         * cris-tdep.c: Sort headers.
10073         * cris-linux-tdep.c: Sort headers.
10074         * cp-valprint.c: Sort headers.
10075         * cp-support.c: Sort headers.
10076         * cp-namespace.c: Sort headers.
10077         * cp-abi.c: Sort headers.
10078         * corelow.c: Sort headers.
10079         * corefile.c: Sort headers.
10080         * continuations.c: Sort headers.
10081         * completer.h: Sort headers.
10082         * completer.c: Sort headers.
10083         * complaints.c: Sort headers.
10084         * coffread.c: Sort headers.
10085         * coff-pe-read.c: Sort headers.
10086         * cli-out.h: Sort headers.
10087         * cli-out.c: Sort headers.
10088         * charset.c: Sort headers.
10089         * c-varobj.c: Sort headers.
10090         * c-valprint.c: Sort headers.
10091         * c-typeprint.c: Sort headers.
10092         * c-lang.c: Sort headers.
10093         * buildsym.c: Sort headers.
10094         * buildsym-legacy.c: Sort headers.
10095         * build-id.h: Sort headers.
10096         * build-id.c: Sort headers.
10097         * btrace.c: Sort headers.
10098         * bsd-uthread.c: Sort headers.
10099         * breakpoint.h: Sort headers.
10100         * breakpoint.c: Sort headers.
10101         * break-catch-throw.c: Sort headers.
10102         * break-catch-syscall.c: Sort headers.
10103         * break-catch-sig.c: Sort headers.
10104         * blockframe.c: Sort headers.
10105         * block.c: Sort headers.
10106         * bfin-tdep.c: Sort headers.
10107         * bfin-linux-tdep.c: Sort headers.
10108         * bfd-target.c: Sort headers.
10109         * bcache.c: Sort headers.
10110         * ax-general.c: Sort headers.
10111         * ax-gdb.h: Sort headers.
10112         * ax-gdb.c: Sort headers.
10113         * avr-tdep.c: Sort headers.
10114         * auxv.c: Sort headers.
10115         * auto-load.c: Sort headers.
10116         * arm-wince-tdep.c: Sort headers.
10117         * arm-tdep.c: Sort headers.
10118         * arm-symbian-tdep.c: Sort headers.
10119         * arm-pikeos-tdep.c: Sort headers.
10120         * arm-obsd-tdep.c: Sort headers.
10121         * arm-nbsd-tdep.c: Sort headers.
10122         * arm-nbsd-nat.c: Sort headers.
10123         * arm-linux-tdep.c: Sort headers.
10124         * arm-linux-nat.c: Sort headers.
10125         * arm-fbsd-tdep.c: Sort headers.
10126         * arm-fbsd-nat.c: Sort headers.
10127         * arm-bsd-tdep.c: Sort headers.
10128         * arch-utils.c: Sort headers.
10129         * arc-tdep.c: Sort headers.
10130         * arc-newlib-tdep.c: Sort headers.
10131         * annotate.h: Sort headers.
10132         * annotate.c: Sort headers.
10133         * amd64-windows-tdep.c: Sort headers.
10134         * amd64-windows-nat.c: Sort headers.
10135         * amd64-tdep.c: Sort headers.
10136         * amd64-sol2-tdep.c: Sort headers.
10137         * amd64-obsd-tdep.c: Sort headers.
10138         * amd64-obsd-nat.c: Sort headers.
10139         * amd64-nbsd-tdep.c: Sort headers.
10140         * amd64-nbsd-nat.c: Sort headers.
10141         * amd64-nat.c: Sort headers.
10142         * amd64-linux-tdep.c: Sort headers.
10143         * amd64-linux-nat.c: Sort headers.
10144         * amd64-fbsd-tdep.c: Sort headers.
10145         * amd64-fbsd-nat.c: Sort headers.
10146         * amd64-dicos-tdep.c: Sort headers.
10147         * amd64-darwin-tdep.c: Sort headers.
10148         * amd64-bsd-nat.c: Sort headers.
10149         * alpha-tdep.c: Sort headers.
10150         * alpha-obsd-tdep.c: Sort headers.
10151         * alpha-nbsd-tdep.c: Sort headers.
10152         * alpha-mdebug-tdep.c: Sort headers.
10153         * alpha-linux-tdep.c: Sort headers.
10154         * alpha-linux-nat.c: Sort headers.
10155         * alpha-bsd-tdep.c: Sort headers.
10156         * alpha-bsd-nat.c: Sort headers.
10157         * aix-thread.c: Sort headers.
10158         * agent.c: Sort headers.
10159         * addrmap.c: Sort headers.
10160         * ada-varobj.c: Sort headers.
10161         * ada-valprint.c: Sort headers.
10162         * ada-typeprint.c: Sort headers.
10163         * ada-tasks.c: Sort headers.
10164         * ada-lang.c: Sort headers.
10165         * aarch64-tdep.c: Sort headers.
10166         * aarch64-ravenscar-thread.c: Sort headers.
10167         * aarch64-newlib-tdep.c: Sort headers.
10168         * aarch64-linux-tdep.c: Sort headers.
10169         * aarch64-linux-nat.c: Sort headers.
10170         * aarch64-fbsd-tdep.c: Sort headers.
10171         * aarch64-fbsd-nat.c: Sort headers.
10172         * aarch32-linux-nat.c: Sort headers.
10173
10174 2019-04-04  Tom Tromey  <tom@tromey.com>
10175
10176         * varobj.c (varobj_create): Update.
10177         * rust-exp.y (struct rust_parser) <update_innermost_block,
10178         lookup_symbol>: New methods.
10179         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10180         Rename.
10181         (rust_parser::rust_lookup_type)
10182         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10183         * printcmd.c (display_command, do_one_display): Update.
10184         * parser-defs.h (struct parser_state) <parser_state>: Add
10185         "tracker" parameter.
10186         (block_tracker): New member.
10187         (class innermost_block_tracker) <innermost_block_tracker>: Add
10188         "types" parameter.
10189         <reset>: Remove method.
10190         (innermost_block): Don't declare.
10191         (null_post_parser): Update.
10192         * parse.c (innermost_block): Remove global.
10193         (write_dollar_variable): Update.
10194         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10195         Remove "tracker_types" parameter.
10196         (parse_expression): Add "tracker" parameter.
10197         (parse_expression_for_completion): Update.
10198         (null_post_parser): Add "tracker" parameter.
10199         * p-exp.y: Update rules.
10200         * m2-exp.y: Update rules.
10201         * language.h (struct language_defn) <la_post_parser>: Add
10202         "tracker" parameter.
10203         * go-exp.y: Update rules.
10204         * f-exp.y: Update rules.
10205         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10206         parameter.
10207         * d-exp.y: Update rules.
10208         * c-exp.y: Update rules.
10209         * breakpoint.c (set_breakpoint_condition): Create an
10210         innermost_block_tracker.
10211         (watch_command_1): Likewise.
10212         * ada-lang.c (resolve): Add "tracker" parameter.
10213         (resolve_subexp): Likewise.
10214         * ada-exp.y (write_var_from_sym): Update.
10215
10216 2019-04-04  Tom Tromey  <tom@tromey.com>
10217
10218         * type-stack.h: New file.
10219         * type-stack.c: New file.
10220         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10221         type-stack.h.
10222         (insert_into_type_stack, insert_type, push_type, push_type_int)
10223         (insert_type_address_space, pop_type, pop_type_int)
10224         (pop_typelist, pop_type_stack, append_type_stack)
10225         (push_type_stack, get_type_stack, push_typelist)
10226         (follow_type_instance_flags, follow_types): Don't declare.
10227         * parse.c (type_stack): Remove global.
10228         (parse_exp_in_context): Update.
10229         (insert_into_type_stack, insert_type, push_type, push_type_int)
10230         (insert_type_address_space, pop_type, pop_type_int)
10231         (pop_typelist, pop_type_stack, append_type_stack)
10232         (push_type_stack, get_type_stack, push_typelist)
10233         (follow_type_instance_flags, follow_types): Remove (moved to
10234         type-stack.c).
10235         * f-exp.y (type_stack): New global.
10236         Update rules.
10237         (push_kind_type, f_parse): Update.
10238         * d-exp.y (type_stack): New global.
10239         Update rules.
10240         (d_parse): Update.
10241         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10242         Update rules.
10243         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10244         (HFILES_NO_SRCDIR): Add type-stack.h.
10245
10246 2019-04-04  Tom Tromey  <tom@tromey.com>
10247
10248         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10249         (rust_parser::convert_ast_to_expression, rust_parse)
10250         (rust_lex_test_completion, rust_lex_tests): Update.
10251         * parser-defs.h (struct expr_completion_state): New.
10252         (struct parser_state) <parser_state>: Add completion parameter.
10253         <mark_struct_expression, mark_completion_tag>: New methods.
10254         <parse_completion, m_completion_state>: New members.
10255         (prefixify_expression, null_post_parser): Update.
10256         (mark_struct_expression, mark_completion_tag): Don't declare.
10257         * parse.c (parse_completion, expout_last_struct)
10258         (expout_tag_completion_type, expout_completion_name): Remove
10259         globals.
10260         (parser_state::mark_struct_expression)
10261         (parser_state::mark_completion_tag): Now methods.
10262         (prefixify_expression): Add last_struct parameter.
10263         (prefixify_subexp): Likewise.
10264         (parse_exp_1): Update.
10265         (parse_exp_in_context): Add cstate parameter.  Update.
10266         (parse_expression_for_completion): Create an
10267         expr_completion_state.
10268         (null_post_parser): Add "completion" parameter.
10269         * p-exp.y: Update rules.
10270         (yylex): Update.
10271         * language.h (struct language_defn) <la_post_parser>: Add
10272         "completing" parameter.
10273         * go-exp.y: Update rules.
10274         (lex_one_token): Update.
10275         * expression.h (parse_completion): Don't declare.
10276         * d-exp.y: Update rules.
10277         (lex_one_token): Update rules.
10278         * c-exp.y: Update rules.
10279         (lex_one_token): Update.
10280         * ada-lang.c (resolve): Add "parse_completion" parameter.
10281         (resolve_subexp): Likewise.
10282         (ada_resolve_function): Likewise.
10283
10284 2019-04-04  Tom Tromey  <tom@tromey.com>
10285
10286         * parser-defs.h (struct parser_state) <start_arglist,
10287         end_arglist>: New methods.
10288         <arglist_len, m_funcall_chain>: New members.
10289         (arglist_len, start_arglist, end_arglist): Don't declare.
10290         * parse.c (arglist_len, funcall_chain): Remove global.
10291         (start_arglist, end_arglist): Remove functions.
10292         (parse_exp_in_context): Update.
10293         * p-exp.y: Update rules.
10294         * m2-exp.y: Update rules.
10295         * go-exp.y: Update rules.
10296         * f-exp.y: Update rules.
10297         * d-exp.y: Update rules.
10298         * c-exp.y: Update rules.
10299
10300 2019-04-04  Tom Tromey  <tom@tromey.com>
10301
10302         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10303         lex_operator, push_back>: New methods.
10304         Update all rules.
10305         (rust_parser::lex_hex, lex_escape): Rename and update.
10306         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10307         (rust_parser::lex_operator): Rename and update.
10308         (rust_parser::lex_number, rustyylex, rustyyerror)
10309         (rust_lex_test_init, rust_lex_test_sequence)
10310         (rust_lex_test_push_back, rust_lex_tests): Update.
10311         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10312         parameter.
10313         <lexptr, prev_lexptr>: New members.
10314         (lexptr, prev_lexptr): Don't declare.
10315         * parse.c (lexptr, prev_lexptr): Remove globals.
10316         (parse_exp_in_context): Update.
10317         * p-exp.y (yylex, yyerror): Update.
10318         * m2-exp.y (parse_number, yylex, yyerror): Update.
10319         * go-exp.y (lex_one_token, yyerror): Update.
10320         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10321         * d-exp.y (lex_one_token, yyerror): Update.
10322         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10323         (lex_one_token, yyerror): Update.
10324         * ada-lex.l (YY_INPUT): Update.
10325         (rewind_to_char): Update.
10326         * ada-exp.y (yyerror): Update.
10327
10328 2019-04-04  Tom Tromey  <tom@tromey.com>
10329
10330         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10331         * parser-defs.h (struct parser_state) <parser_state>: Add new
10332         parameter.
10333         <comma_terminates>: New member.
10334         (comma_terminates): Don't declare global.
10335         * parse.c (comma_terminates): Remove global.
10336         (parse_exp_in_context): Update.
10337         * p-exp.y (yylex): Update.
10338         * m2-exp.y (yylex): Update.
10339         * go-exp.y (lex_one_token): Update.
10340         * f-exp.y (yylex): Update.
10341         * d-exp.y (lex_one_token): Update.
10342         * c-exp.y (lex_one_token): Update.
10343         * ada-lex.l: Update.
10344
10345 2019-04-04  Tom Tromey  <tom@tromey.com>
10346
10347         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10348         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10349         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10350         * parser-defs.h (paren_depth): Don't declare.
10351         * parse.c (paren_depth): Remove global.
10352         (parse_exp_in_context): Update.
10353         * p-exp.y (paren_depth): New global.
10354         (pascal_parse): Initialize it.
10355         * m2-exp.y (paren_depth): New global.
10356         (m2_parse): Initialize it.
10357         * go-exp.y (paren_depth): New global.
10358         (go_parse): Initialize it.
10359         * f-exp.y (paren_depth): New global.
10360         (f_parse): Initialize it.
10361         * d-exp.y (paren_depth): New global.
10362         (d_parse): Initialize it.
10363         * c-exp.y (paren_depth): New global.
10364         (c_parse): Initialize it.
10365         * ada-lex.l (paren_depth): New global.
10366         (lexer_init): Initialize it.
10367
10368 2019-04-04  Tom Tromey  <tom@tromey.com>
10369
10370         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10371         (rust_parser::convert_ast_to_type)
10372         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10373         * parser-defs.h (struct parser_state) <parser_state>: Add
10374         parameters.  Initialize new members.
10375         <expression_context_block, expression_context_pc>: New members.
10376         * parse.c (expression_context_block, expression_context_pc):
10377         Remove globals.
10378         (parse_exp_in_context): Update.
10379         * p-exp.y: Update all rules.
10380         (yylex): Update.
10381         * m2-exp.y: Update all rules.
10382         (yylex): Update.
10383         * go-exp.y (yylex): Update.
10384         * f-exp.y (yylex): Update.
10385         * d-exp.y: Update all rules.
10386         (yylex): Update.
10387         * c-exp.y: Update all rules.
10388         (lex_one_token, classify_name, yylex, c_parse): Update.
10389         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10390
10391 2019-04-04  Tom Tromey  <tom@tromey.com>
10392
10393         * gdbarch.h, gdbarch.c: Rebuild.
10394         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10395         * stap-probe.h:
10396         (struct stap_parse_info): Replace "parser_state" with
10397         "expr_builder".
10398         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10399         (parser_state): New class.
10400         * parse.c (expr_builder): Rename.
10401         (expr_builder::release): Rename.
10402         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10403         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10404         (write_exp_elt_longcst, write_exp_elt_floatcst)
10405         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10406         (write_exp_string_vector, write_exp_bitstring)
10407         (write_exp_msymbol, mark_struct_expression)
10408         (write_dollar_variable)
10409         (insert_type_address_space, increase_expout_size): Replace
10410         "parser_state" with "expr_builder".
10411         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10412         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10413         "parser_state" with "expr_builder".
10414
10415 2019-04-04  Tom Tromey  <tom@tromey.com>
10416
10417         * rust-exp.y: Replace "parse_language" with method call.
10418         * p-exp.y:
10419         (yylex): Replace "parse_language" with method call.
10420         * m2-exp.y:
10421         (yylex): Replace "parse_language" with method call.
10422         * go-exp.y (classify_name): Replace "parse_language" with method
10423         call.
10424         * f-exp.y (yylex): Replace "parse_language" with method call.
10425         * d-exp.y (lex_one_token): Replace "parse_language" with method
10426         call.
10427         * c-exp.y:
10428         (lex_one_token, classify_name, yylex): Replace "parse_language"
10429         with method call.
10430         * ada-exp.y (find_primitive_type, type_char)
10431         (type_system_address): Replace "parse_language" with method call.
10432
10433 2019-04-04  Tom Tromey  <tom@tromey.com>
10434
10435         * rust-exp.y: Replace "parse_gdbarch" with method call.
10436         * parse.c (write_dollar_variable, insert_type_address_space):
10437         Replace "parse_gdbarch" with method call.
10438         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10439         call.
10440         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10441         call.
10442         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10443         "parse_gdbarch" with method call.
10444         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10445         with method call.
10446         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10447         "parse_gdbarch" with method call.
10448         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10449         "parse_gdbarch" with method call.
10450         * c-exp.y (parse_type, parse_number, classify_name): Replace
10451         "parse_gdbarch" with method call.
10452         * ada-lex.l: Replace "parse_gdbarch" with method call.
10453         * ada-exp.y (parse_type, find_primitive_type, type_char)
10454         (type_system_address): Replace "parse_gdbarch" with method call.
10455
10456 2019-04-04  Tom Tromey  <tom@tromey.com>
10457
10458         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10459         * stap-probe.c (stap_parse_argument): Update.
10460         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10461         initial_size parameter.
10462         * rust-exp.y (rust_lex_tests): Update.
10463         * parse.c (parser_state): Update.
10464         (parse_exp_in_context): Update.
10465         * parser-defs.h (struct parser_state) <parser_state>: Remove
10466         "initial_size" parameter.
10467
10468 2019-04-04  Tom Tromey  <tom@tromey.com>
10469
10470         * parser-defs.h (increase_expout_size): Don't declare.
10471         * parse.c (increase_expout_size): Now static.
10472
10473 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10474
10475         * gnu-nat.c (gnu_nat_target::wait): Fix
10476         target_waitstatus_to_string call.
10477
10478 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10479
10480         * eval.c (evaluate_subexp_standard): Handle internal functions
10481         during Fortran function call handling.
10482
10483 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10484
10485         * NEWS: Mention new internal functions.
10486         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10487         (read_base_type): Use dwarf2_init_complex_target_type.
10488         * value.c (creal_internal_fn): New function.
10489         (cimag_internal_fn): New function.
10490         (_initialize_values): Register new internal functions.
10491
10492 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10493
10494         * infrun.c (stop_all_threads): If debug_infrun, always
10495         trace the wait status after wait_one, using
10496         target_waitstatus_to_string and target_pid_to_str.
10497         (handle_inferior_event): Replace various trace of
10498         wait status kind by a single trace.
10499         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10500         wait status kind image by target_waitstatus_to_string.
10501         * target/waitstatus.c (target_waitstatus_to_string): Fix
10502         obsolete comment.
10503
10504 2019-04-01  Tom Tromey  <tromey@adacore.com>
10505
10506         PR symtab/23331:
10507         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10508
10509 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10510             Pedro Alves  <palves@redhat.com>
10511
10512         * top.c (quit_force): Call 'finalize_values'.
10513         * value.c (finalize_values): New function.
10514         * value.h (finalize_values): Declare.
10515
10516 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10517
10518         * NEWS: Announce $_gdb_major and $_gdb_minor.
10519
10520         * top.c (init_gdb_version_vars): New function.
10521         (gdb_init): Call init_gdb_version_vars.
10522
10523 2019-03-29  Tom Tromey  <tromey@adacore.com>
10524
10525         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10526         help text.  Remove dead code.
10527
10528 2019-03-29  Keith Seitz  <keiths@redhat.com>
10529
10530         From Siddhesh Poyarekar:
10531         * f-lang.h (f77_get_upperbound): Return LONGEST.
10532         (f77_get_lowerbound): Likewise.
10533         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10534         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10535         print them.
10536         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10537         plongest to format print it.
10538         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10539         (f77_get_upperbound): Likewise.
10540         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10541         LOWER_BOUND to LONGEST.
10542         (f77_create_arrayprint_offset_tbl): Likewise.
10543
10544 2019-03-29  Keith Seitz  <keiths@redhat.com>
10545
10546         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10547         %s/pulongest for TYPE_LENGTH instead of %d in format
10548         strings.
10549         * ada-typerint.c (ada_print_type): Likewise.
10550         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10551         * compile/compile-c-support.c (generate_register_struct): Likewise.
10552         * gdbtypes.c (recursive_dump_type): Likewise.
10553         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10554         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10555         instead of %d in format strings.
10556         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10557         to std::min to ULONGEST.
10558         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10559         instead of %d in format strings.
10560         * tracepoint.c (info_scope_command): Likewise.
10561         * typeprint.c (print_offset_data::update)
10562         (print_offset_data::finish): Likewise.
10563         * xtensa-tdep.c (xtensa_store_return_value)
10564         (xtensa_push_dummy_call): Likewise.
10565
10566 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10567
10568         * windows-nat.c (display_selector): Fixed format specifications
10569         for 64-bit Cygwin.
10570
10571 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10572
10573         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10574
10575 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10576
10577         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10578         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10579         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10580         (nios2_linux_init_abi): Install it.
10581
10582 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10583
10584         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10585
10586 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10587
10588         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10589
10590 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10591             Tom Tromey  <tromey@adacore.com>
10592
10593         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10594
10595 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10596
10597         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10598         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10599         method to compute the bounds of range types. Also print "[evaluated]"
10600         if the bounds' values come from a dynamic evaluation.
10601
10602 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10603
10604         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10605         whitespace when pretty printing is on.
10606
10607 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10608
10609         * ppc-linux-nat.c: Add include.
10610
10611 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10612
10613         * NEWS: Mention AArch64 Pointer Authentication.
10614
10615 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10616
10617         * arm-linux-nat.c: Add include.
10618
10619 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10620
10621         * source-cache.c (source_cache::get_source_lines): Re-read
10622         fullname after calling open_source_file.
10623
10624 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10625
10626         * NEWS: Mention TLS support for FreeBSD.
10627
10628 2019-03-25  Tom Tromey  <tromey@adacore.com>
10629
10630         * minsyms.c (BUNCH_SIZE): Update comment.
10631         (~minimal_symbol_reader): Remove old comment.
10632         (compact_minimal_symbols): Update comment.
10633         (minimal_symbol_reader::install): Remove old comment.  Update
10634         other comments.
10635
10636 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10637
10638         * s390-linux-nat.c: Add include.
10639
10640 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10641
10642         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10643         Call linux_get_hwcap.
10644         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10645         Likewise.
10646         (aarch64_linux_get_hwcap): Remove function.
10647         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10648         declaration.
10649         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10650         linux_get_hwcap.
10651         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10652         * linux-tdep.c (linux_get_hwcap): Add function.
10653         (linux_get_hwcap2): Likewise.
10654         * linux-tdep.h (linux_get_hwcap): Add declaration.
10655         (linux_get_hwcap2): Likewise.
10656         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10657         (ppc_linux_get_hwcap2): Likewise.
10658         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10659         linux_get_hwcap.
10660         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10661         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10662         (ppc_linux_nat_target::read_description): Likewise.
10663         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10664         * s390-linux-nat.c: Likewise.
10665         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10666
10667 2019-03-24  Tom Tromey  <tom@tromey.com>
10668
10669         * ada-lang.c (standard_lookup): Simplify initialization.
10670         (ada_lookup_symbol_nonlocal): Simplify return.
10671         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10672         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10673         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10674         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10675         initialization.
10676         * solib.c (solib_global_lookup): Simplify.
10677         * symtab.c (null_block_symbol): Remove.
10678         (symbol_cache_lookup): Simplify returns.
10679         (lookup_language_this): Simplify returns.
10680         (lookup_symbol_aux): Simplify return.
10681         (lookup_local_symbol): Simplify returns.
10682         (lookup_global_symbol_from_objfile): Simplify return.
10683         (lookup_symbol_in_objfile_symtabs)
10684         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10685         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10686         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10687         * cp-namespace.c (cp_lookup_bare_symbol)
10688         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10689         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10690         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10691         (cp_lookup_symbol_via_imports): Simplify initialization.
10692         (find_symbol_in_baseclass): Likewise.
10693         * symtab.h (null_block_symbol): Remove.
10694         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10695         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10696         (d_lookup_symbol_module): Likewise.
10697         (find_symbol_in_baseclass): Simplify initialization.
10698
10699 2019-03-24  Tom Tromey  <tom@tromey.com>
10700
10701         * expression.h: Don't include symtab.h.
10702         (struct block): Forward declare.
10703
10704 2019-03-24  Tom Tromey  <tom@tromey.com>
10705
10706         * c-exp.y (typebase): Remove casts.
10707         * gdbtypes.c (lookup_unsigned_typename, )
10708         (lookup_signed_typename): Remove cast.
10709         * eval.c (parse_to_comma_and_eval): Remove cast.
10710         * parse.c (write_dollar_variable): Remove cast.
10711         * block.h (struct block) <superblock>: Now const.
10712         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10713         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10714         (map_block): Make "block" const.
10715         * symfile.h (struct quick_symbol_functions)
10716         <map_matching_symbols>: Constify block argument to "callback".
10717         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10718         const.
10719         (find_pc_sect_compunit_symtab): Make "b" const.
10720         (find_symbol_at_address): Likewise.
10721         (search_symbols): Likewise.
10722         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10723         (dw2_debug_names_lookup_symbol): Likewise.
10724         (dw2_map_matching_symbols): Update.
10725         * p-valprint.c (pascal_val_print): Remove "block".
10726         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10727         (aux_add_nonlocal_symbols): Make "block" const.
10728         (resolve_subexp): Remove cast.
10729         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10730         const.
10731         (iterate_over_file_blocks): Likewise.
10732         * f-exp.y (%union) <bval>: Remove.
10733         * coffread.c (patch_opaque_types): Make "b" const.
10734         * spu-tdep.c (spu_catch_start): Make "block" const.
10735         * c-valprint.c (print_unpacked_pointer): Remove "block".
10736         * symmisc.c (dump_symtab_1): Make "b" const.
10737         (block_depth): Make "block" const.
10738         * d-exp.y (%union) <bval>: Remove.
10739         * cp-support.h (cp_lookup_rtti_type): Update.
10740         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10741         * psymtab.c (psym_lookup_symbol): Make "block" const.
10742         (maintenance_check_psymtabs): Make "b" const.
10743         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10744         (enumerate_locals, enumerate_args): Update.
10745         * python/py-symtab.c (stpy_global_block): Make "block" const.
10746         (stpy_static_block): Likewise.
10747         * inline-frame.c (block_starting_point_at): Make "new_block"
10748         const.
10749         * block.c (find_block_in_blockvector): Make return type const.
10750         (blockvector_for_pc_sect): Make "b" const.
10751         (find_block_in_blockvector): Make "b" const.
10752
10753 2019-03-23  Tom Tromey  <tom@tromey.com>
10754
10755         * varobj.c (varobj_create): Update.
10756         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10757         * printcmd.c (display_command, do_one_display): Don't reset
10758         innermost_block.
10759         * parser-defs.h (enum innermost_block_tracker_type): Move to
10760         expression.h.
10761         (innermost_block): Update comment.
10762         * parse.c (parse_exp_1): Add tracker_types parameter.
10763         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10764         tracker_types parameter.  Reset innermost_block.
10765         (parse_exp_in_context): Remove.
10766         (parse_expression_for_completion): Update.
10767         * objfiles.c (~objfile): Don't reset expression_context_block or
10768         innermost_block.
10769         * expression.h (enum innermost_block_tracker_type): Move from
10770         parser-defs.h.
10771         (parse_exp_1): Add tracker_types parameter.
10772         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10773         reset innermost_block.
10774
10775 2019-03-23  Tom Tromey  <tom@tromey.com>
10776
10777         * objfiles.h: Include bcache.h.
10778
10779 2019-03-23  Tom Tromey  <tom@tromey.com>
10780
10781         * linespec.c (get_current_search_block): Use
10782         scoped_restore_current_language.
10783         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10784
10785 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10786             Jiong Wang  <jiong.wang@arm.com>
10787
10788         * aarch64-linux-tdep.c
10789         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10790         section.
10791         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10792
10793 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10794             Jiong Wang  <jiong.wang@arm.com>
10795
10796         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10797         instructions.
10798         (aarch64_analyze_prologue_test): Add PACIASP test.
10799         (aarch64_prologue_prev_register): Unmask PC value.
10800
10801 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10802             Jiong Wang  <jiong.wang@arm.com>
10803
10804         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10805         (aarch64_dwarf2_prev_register): Unmask PC value.
10806         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10807         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10808         DW_CFA_AARCH64_negate_ra_state.
10809         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10810
10811 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10812             Jiong Wang  <jiong.wang@arm.com>
10813
10814         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10815         registers.
10816         (aarch64_pseudo_register_name): Likewise.
10817         (aarch64_pseudo_register_type): Likewise.
10818         (aarch64_pseudo_register_reggroup_p): Likewise.
10819         (aarch64_gdbarch_init): Add pauth registers.
10820         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10821         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10822         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10823         (struct gdbarch_tdep): Add regnum for ra_state.
10824
10825 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10826             Jiong Wang  <jiong.wang@arm.com>
10827
10828         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10829
10830 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10831             Jiong Wang  <jiong.wang@arm.com>
10832
10833         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10834         function.
10835         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10836         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10837         (aarch64_gdbarch_init): Add puth registers.
10838         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10839         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10840         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10841
10842 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10843             Jiong Wang  <jiong.wang@arm.com>
10844
10845         * aarch64-linux-nat.c
10846         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10847         * aarch64-linux-tdep.c
10848         (aarch64_linux_core_read_description): Likewise.
10849         (aarch64_linux_get_hwcap): New function.
10850         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10851         (aarch64_linux_get_hwcap): New declaration.
10852
10853 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10854             Jiong Wang  <jiong.wang@arm.com>
10855
10856         * aarch64-linux-nat.c
10857         (aarch64_linux_nat_target::read_description): Add pauth param.
10858         * aarch64-linux-tdep.c
10859         (aarch64_linux_core_read_description): Likewise.
10860         * aarch64-tdep.c (struct target_desc): Add in pauth.
10861         (aarch64_read_description): Add pauth param.
10862         (aarch64_gdbarch_init): Likewise.
10863         * aarch64-tdep.h (aarch64_read_description): Likewise.
10864         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10865         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10866         * features/Makefile: Add new files.
10867         * features/aarch64-pauth.c: New file.
10868         * features/aarch64-pauth.xml: New file.
10869
10870 2019-03-20  Tom Tromey  <tromey@adacore.com>
10871
10872         * infrun.c (handle_inferior_event): Rename from
10873         handle_inferior_event_1.  Create a scoped_value_mark.
10874         (handle_inferior_event): Remove.
10875
10876 2019-03-19  Tom Tromey  <tromey@adacore.com>
10877
10878         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10879         * infrun.h (print_stop_event): Add "displays" parameter.
10880         * infrun.c (print_stop_event): Add "displays" parameter.
10881
10882 2019-03-19  Pedro Alves  <palves@redhat.com>
10883
10884         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10885         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10886         to -1.  Fix TABs vs spaces.
10887         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10888         * tui/tui-out.h (tui_ui_out) Add intro comments.
10889         <m_line, m_start_of_line>: In-class initialize, and add describing
10890         comment.
10891
10892 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10893
10894         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10895         variable names.
10896         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10897
10898 2019-03-18  Pedro Alves  <palves@redhat.com>
10899             Eli Zaretskii <eliz@gnu.org>
10900
10901         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10902         m_line and m_start_of_line.
10903
10904 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10905
10906         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10907         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10908         it returns a newline.  This fixes a regression in TU mode, whereby
10909         the next line is output on the same screen line as the user input.
10910
10911 2019-03-18  Tom Tromey  <tromey@adacore.com>
10912
10913         * minsyms.c (minimal_symbol_reader::install): Remove call to
10914         obstack_blank.
10915
10916 2019-03-18  Pedro Alves  <palves@redhat.com>
10917
10918         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10919         New globals.
10920         (apply_style): New, factored out from ...
10921         (apply_ansi_escape): ... this.  Handle reverse video mode.
10922         (tui_set_reverse_mode): New function.
10923         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10924         * tui/tui-winsource.c (tui_show_source_line): Use
10925         tui_set_reverse_mode instead of setting A_STANDOUT.
10926         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10927         New setter methods.
10928
10929 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10930
10931         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10932         Handle tabs.
10933
10934 2019-03-18  Tom Tromey  <tromey@adacore.com>
10935
10936         * ada-lang.c (empty_array): Add "high" parameter.
10937         (ada_evaluate_subexp): Update.
10938
10939 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10940
10941         * unittests/string_view-selftests.c: Define
10942         _initialize_string_view_selftests unconditionally.
10943
10944 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10945
10946         PR gdb/24350
10947         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10948
10949 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10950
10951         PR gdb/24351
10952         * windows-nat.c (display_selector): Fix format specifiers.
10953
10954 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10955
10956         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10957         tui_refill_source_window instead of tui_refresh_win, to update the
10958         current execution line.  This fixes redisplay of the current line
10959         when stepping through the code with "next" or "step".
10960
10961 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10962
10963         * source-cache.c (source_cache::get_source_lines): Call
10964         find_source_lines to initialize s->nlines.  This fixes vertical
10965         scrolling of TUI source window when the DOWN arrow is pressed.
10966
10967 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10968
10969         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10970         linux-thread-db.c (_initialize_thread_db): Likewise.
10971
10972 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10973
10974         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10975         wclrtoeol in tui_show_source_line".  This reverts changes made in
10976         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10977
10978 2019-03-15  Tom Tromey  <tom@tromey.com>
10979
10980         * symtab.h (struct minimal_symbol): Derive from
10981         general_symbol_info.
10982         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10983         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10984         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10985         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10986         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10987         (MSYMBOL_SEARCH_NAME): Update.
10988         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10989         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10990         * minsyms.c (minimal_symbol_reader::record_full): Update.
10991
10992 2019-03-15  Tom Tromey  <tom@tromey.com>
10993
10994         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10995
10996 2019-03-15  Tom Tromey  <tom@tromey.com>
10997
10998         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10999         unique_xmalloc_ptr.
11000         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11001         Update.
11002         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11003         (build_minimal_symbol_hash_tables)
11004         (minimal_symbol_reader::install): Update.
11005
11006 2019-03-15  Tom Tromey  <tom@tromey.com>
11007
11008         * symtab.c (create_demangled_names_hash): Update.
11009         (symbol_set_names): Update.
11010         * objfiles.h (struct objfile_per_bfd_storage)
11011         <demangled_names_hash>: Now an htab_up.
11012         * objfiles.c (objfile_per_bfd_storage): Simplify.
11013
11014 2019-03-15  Tom Tromey  <tom@tromey.com>
11015
11016         * objfiles.h (struct objfile_per_bfd_storage): Declare
11017         destructor.
11018         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11019         New.
11020         (get_objfile_bfd_data): Use new.  Don't initialize
11021         language_of_main.
11022         (free_objfile_per_bfd_storage): Remove.
11023         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11024
11025 2019-03-15  Tom Tromey  <tom@tromey.com>
11026
11027         * symfile.c (reread_symbols): Update.
11028         * objfiles.c (objfile::objfile): Update.
11029         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11030         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11031         comment.
11032         (minimal_symbol_reader::install): Update.
11033         (terminate_minimal_symbol_table): Remove.
11034         * jit.c (jit_object_close_impl): Update.
11035
11036 2019-03-15  Tom Tromey  <tom@tromey.com>
11037
11038         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11039         initializations.
11040
11041 2019-03-15  Tom Tromey  <tom@tromey.com>
11042
11043         * objfiles.h (struct objfile_per_bfd_storage)
11044         <demangled_hash_languages>: Now a bitset.
11045         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11046         (lookup_minimal_symbol): Update.
11047
11048 2019-03-15  Tom Tromey  <tom@tromey.com>
11049
11050         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11051         Don't return the symbol.
11052         * coffread.c (record_minimal_symbol): Use record_full.
11053
11054 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11055
11056         The MS-Windows port of ncurses fails to switch to a color pair if
11057         one or both of the colors are the implicit default colors.  This
11058         change records the default colors when TUI is initialized, and
11059         then specifies them explicitly when a color pair uses the default
11060         colors.  This allows color styling in TUI mode on MS-Windows.
11061
11062         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11063         ncurses_norm_attr.
11064         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11065         colors in ncurses_norm_attr.
11066         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11067         "none", replace it with the default color recorded in
11068         ncurses_norm_attr.
11069
11070 2019-03-14  Tom Tromey  <tromey@adacore.com>
11071
11072         * source-cache.h (class source_cache) <get_source_lines>: Return
11073         std::string.
11074         * source-cache.c (source_cache::extract_lines): Handle case where
11075         first_pos==npos.  Return std::string.
11076         (source_cache::get_source_lines): Update.
11077
11078 2019-03-14  Tom Tromey  <tromey@adacore.com>
11079
11080         * NEWS: Add item for "style sources" commands.
11081         * source-cache.c (source_cache::get_source_lines): Check
11082         source_styling.
11083         * cli/cli-style.c (source_styling): New global.
11084         (_initialize_cli_style): Add "style sources" commands.
11085         (show_style_sources): New function.
11086         * cli/cli-style.h (source_styling): Declare.
11087
11088 2019-03-14  Pedro Alves  <palves@redhat.com>
11089             Tom Tromey  <tromey@adacore.com>
11090
11091         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11092         * tui/tui-winsource.c (tui_refill_source_window): New function,
11093         from...
11094         (tui_horizontal_source_scroll): ... here.  Move some logic.
11095         * cli/cli-style.c (set_style_enabled): Notify new observable.
11096         * tui/tui-hooks.c (tui_redisplay_source): New function.
11097         (tui_attach_detach_observers): Attach or detach
11098         tui_redisplay_source.
11099         * observable.h (source_styling_changed): New observable.
11100         * observable.c: Define source_styling_changed observable.
11101
11102 2019-03-13  Tom Tromey  <tromey@adacore.com>
11103
11104         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11105         (i386_gnu_nat_target::store_registers): Update.
11106         * target-debug.h (target_debug_print_std_string): New macro.
11107         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11108         * windows-tdep.c (display_one_tib): Update.
11109         * tui/tui-stack.c (tui_make_status_line): Update.
11110         * top.c (print_inferior_quit_action): Update.
11111         * thread.c (thr_try_catch_cmd): Update.
11112         (add_thread_with_info): Update.
11113         (thread_target_id_str): Update.
11114         (thr_try_catch_cmd): Update.
11115         (thread_command): Update.
11116         (thread_find_command): Update.
11117         * record-btrace.c (record_btrace_target::info_record)
11118         (record_btrace_resume_thread, record_btrace_target::resume)
11119         (record_btrace_cancel_resume, record_btrace_step_thread)
11120         (record_btrace_target::wait, record_btrace_target::wait)
11121         (record_btrace_target::wait, record_btrace_target::stop): Update.
11122         * progspace.c (print_program_space): Update.
11123         * process-stratum-target.c
11124         (process_stratum_target::thread_address_space): Update.
11125         * linux-fork.c (linux_fork_mourn_inferior)
11126         (detach_checkpoint_command, info_checkpoints_command)
11127         (linux_fork_context): Update.
11128         (linux_fork_detach): Update.
11129         (class scoped_switch_fork_info): Update.
11130         (delete_checkpoint_command): Update.
11131         * infrun.c (follow_fork_inferior): Update.
11132         (follow_fork_inferior): Update.
11133         (proceed_after_vfork_done): Update.
11134         (handle_vfork_child_exec_or_exit): Update.
11135         (follow_exec): Update.
11136         (displaced_step_prepare_throw): Update.
11137         (displaced_step_restore): Update.
11138         (start_step_over): Update.
11139         (resume_1): Update.
11140         (clear_proceed_status_thread): Update.
11141         (proceed): Update.
11142         (print_target_wait_results): Update.
11143         (do_target_wait): Update.
11144         (context_switch): Update.
11145         (stop_all_threads): Update.
11146         (restart_threads): Update.
11147         (finish_step_over): Update.
11148         (handle_signal_stop): Update.
11149         (switch_back_to_stepped_thread): Update.
11150         (keep_going_pass_signal): Update.
11151         (print_exited_reason): Update.
11152         (normal_stop): Update.
11153         * inferior.c (inferior_pid_to_str): Change return type.
11154         (print_selected_inferior): Update.
11155         (add_inferior): Update.
11156         (detach_inferior): Update.
11157         * dummy-frame.c (fprint_dummy_frames): Update.
11158         * dcache.c (dcache_info_1): Update.
11159         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11160         (btrace_fetch, btrace_clear): Update.
11161         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11162         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11163         type.
11164         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11165         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11166         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11167         * gdbarch.c, gdbarch.h: Rebuild.
11168         * gdbarch.sh (core_pid_to_str): Change return type.
11169         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11170         return type.
11171         (windows_nat_target::pid_to_str): Change return type.
11172         (windows_delete_thread): Update.
11173         (windows_nat_target::attach): Update.
11174         (windows_nat_target::files_info): Update.
11175         * target-delegates.c: Rebuild.
11176         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11177         return type.
11178         (sol_thread_target::pid_to_str): Change return type.
11179         * remote.c (class remote_target) <pid_to_str>: Change return
11180         type.
11181         (remote_target::pid_to_str): Change return type.
11182         (extended_remote_target::attach, remote_target::remote_stop_ns)
11183         (remote_target::remote_notif_remove_queued_reply)
11184         (remote_target::push_stop_reply, remote_target::disable_btrace):
11185         Update.
11186         (extended_remote_target::attach): Update.
11187         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11188         type.
11189         (gdbsim_target::pid_to_str): Change return type.
11190         * ravenscar-thread.c (struct ravenscar_thread_target)
11191         <pid_to_str>: Change return type.
11192         (ravenscar_thread_target::pid_to_str): Change return type.
11193         * procfs.c (class procfs_target) <pid_to_str>: Change return
11194         type.
11195         (procfs_target::pid_to_str): Change return type.
11196         (procfs_target::attach): Update.
11197         (procfs_target::detach): Update.
11198         (procfs_target::fetch_registers): Update.
11199         (procfs_target::store_registers): Update.
11200         (procfs_target::wait): Update.
11201         (procfs_target::files_info): Update.
11202         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11203         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11204         return type.
11205         (nto_procfs_target::pid_to_str): Change return type.
11206         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11207         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11208         return type.
11209         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11210         (exit_lwp): Update.
11211         (attach_proc_task_lwp_callback, get_detach_signal)
11212         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11213         (linux_nat_target::resume, wait_lwp, stop_callback)
11214         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11215         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11216         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11217         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11218         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11219         type.
11220         (inf_ptrace_target::attach): Update.
11221         (inf_ptrace_target::files_info): Update.
11222         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11223         type.
11224         (go32_nat_target::pid_to_str): Change return type.
11225         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11226         (gnu_nat_target::wait): Update.
11227         (gnu_nat_target::wait): Update.
11228         (gnu_nat_target::resume): Update.
11229         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11230         (fbsd_nat_target::wait): Update.
11231         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11232         type.
11233         (darwin_nat_target::attach): Update.
11234         * corelow.c (class core_target) <pid_to_str>: Change return type.
11235         (core_target::pid_to_str): Change return type.
11236         * target.c (normal_pid_to_str): Change return type.
11237         (default_pid_to_str): Likewise.
11238         (target_pid_to_str): Change return type.
11239         (target_translate_tls_address): Update.
11240         (target_announce_detach): Update.
11241         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11242         return type.
11243         (bsd_uthread_target::pid_to_str): Change return type.
11244         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11245         type.
11246         (bsd_kvm_target::pid_to_str): Change return type.
11247         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11248         return type.
11249         (aix_thread_target::pid_to_str): Change return type.
11250         * target.h (struct target_ops) <pid_to_str>: Change return type.
11251         (target_pid_to_str, normal_pid_to_str): Likewise.
11252         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11253         type.
11254         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11255         type.
11256         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11257         return type.
11258         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11259         type.
11260         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11261         type.
11262         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11263         return type.
11264
11265 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11266
11267         * NEWS: Mention that the new default MI version is 3.  Mention
11268         changes to the output of commands and events that deal with
11269         multi-location breakpoints.
11270         * breakpoint.c: Include "mi/mi-out.h".
11271         (print_one_breakpoint): Change output syntax if using MI version
11272         >= 3.
11273         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11274         New.
11275         (mi_multi_location_breakpoint_output_fixed): New.
11276         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11277         (mi_cmd_fix_multi_location_breakpoint_output): New.
11278         (mi_multi_location_breakpoint_output_fixed): New.
11279         * mi/mi-cmds.c (mi_cmds): Register command
11280         -fix-multi-location-breakpoint-output.
11281         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11282         interpreter "mi".
11283
11284 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11285
11286         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11287         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11288         instantiate mi_ui_out based on interpreter name.
11289         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11290         * mi/mi-main.c (mi_load_progress): Likewise.
11291
11292 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11293
11294         * NEWS: Combine separate "New targets" sections for 8.3.
11295
11296 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11297
11298         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11299         (ppcfbsd_init_abi): Install gdbarch
11300         "fetch_tls_load_module_address" and "get_thread_local_address"
11301         methods.
11302
11303 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11304
11305         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11306         (riscv_fbsd_init_abi): Install gdbarch
11307         "fetch_tls_load_module_address" and "get_thread_local_address"
11308         methods.
11309
11310 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11311
11312         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11313         (i386fbsd_init_abi): Install gdbarch
11314         "fetch_tls_load_module_address" and "get_thread_local_address"
11315         methods.
11316
11317 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11318
11319         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11320         (amd64fbsd_init_abi): Install gdbarch
11321         "fetch_tls_load_module_address" and "get_thread_local_address"
11322         methods.
11323
11324 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11325
11326         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11327         (struct fbsd_pspace_data): New type.
11328         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11329         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11330         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11331         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11332         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11333
11334 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11335
11336         * gdbtypes.c (lookup_struct_elt): New function.
11337         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11338         * gdbtypes.h (struct struct_elt): New type.
11339         (lookup_struct_elt): New prototype.
11340
11341 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11342
11343         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11344         remove disabled code block.
11345
11346 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11347
11348         * gdbarch.sh (get_thread_local_address): New method.
11349         * gdbarch.h, gdbarch.c: Regenerate.
11350         * target.c (target_translate_tls_address): Use
11351         gdbarch_get_thread_local_address if present instead of
11352         target::get_thread_local_address.
11353
11354 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11355
11356         * target.h (target::get_thread_local_address): Update comment.
11357
11358 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11359
11360         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11361         objfile->separate_debug_objfile_backlink if not NULL.
11362
11363 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11364
11365         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11366         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11367         (amd64bsd_store_inferior_registers): Likewise.
11368         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11369         Enable segment base registers.
11370         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11371         PT_GETFSBASE and PT_GETGSBASE.
11372         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11373         PT_SETGSBASE.
11374         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11375         segment base registers.
11376         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11377
11378 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11379
11380         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11381         Update calls to i386_target_description to add 'segments'
11382         parameter.
11383         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11384         add segment base registers.
11385         * arch/i386.c (i386_create_target_description): Add 'segments'
11386         parameter to enable segment base registers.
11387         * arch/i386.h (i386_create_target_description): Likewise.
11388         * features/i386/32bit-segments.xml: New file.
11389         * features/i386/32bit-segments.c: Generate.
11390         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11391         call to i386_target_description to add 'segments' parameter.
11392         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11393         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11394         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11395         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11396         if feature is present.
11397         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11398         Add 'segments' parameter to call to i386_target_description.
11399         (i386_target_description): Add 'segments' parameter to enable
11400         segment base registers.
11401         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11402         to call to i386_target_description.
11403         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11404         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11405         Define I386_NUM_REGS.
11406         (i386_target_description): Add 'segments' parameter to enable
11407         segment base registers.
11408
11409 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11410
11411         PR/24325
11412         * source-cache.c: #undef open and close, to avoid unresolved
11413         externals during linking.
11414
11415 2019-03-12  Tom Tromey  <tromey@adacore.com>
11416
11417         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11418         const.  Add initializers.
11419         (_initialize_remote): Don't initialize ptid globals.
11420
11421 2019-03-12  Pedro Alves  <palves@redhat.com>
11422
11423         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11424
11425 2019-03-12  Pedro Alves  <palves@redhat.com>
11426
11427         * cp-name-parser.y (main): Remove unused 'len' variable.
11428
11429 2019-03-12  Tom Tromey  <tromey@adacore.com>
11430
11431         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11432         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11433
11434 2019-03-12  Tom Tromey  <tromey@adacore.com>
11435
11436         * linux-nat.c (iterate_over_lwps): Update.
11437         (stop_callback): Remove parameter.
11438         (stop_wait_callback, detach_callback, resume_set_callback)
11439         (select_singlestep_lwp_callback, set_ignore_sigint)
11440         (status_callback, resumed_callback, resume_clear_callback)
11441         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11442         data parameter.
11443         (linux_nat_target::detach, linux_nat_target::resume)
11444         (linux_stop_and_wait_all_lwps, select_event_lwp)
11445         (linux_nat_filter_event, linux_nat_wait_1)
11446         (linux_nat_target::kill, linux_nat_target::stop)
11447         (linux_nat_target::stop): Update.
11448         (linux_nat_resume_callback): Change type.
11449         (resume_stopped_resumed_lwps, count_events_callback)
11450         (select_event_lwp_callback): Likewise.
11451         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11452         * arm-linux-nat.c (struct update_registers_data): Remove.
11453         (update_registers_callback): Change type.
11454         (arm_linux_insert_hw_breakpoint1): Update.
11455         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11456         parameter.
11457         (x86_linux_dr_set_addr): Update.
11458         (x86_linux_dr_set_control): Update.
11459         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11460         (iterate_over_lwps): Use gdb::function_view.
11461         * nat/aarch64-linux-hw-point.c (struct
11462         aarch64_dr_update_callback_param): Remove.
11463         (debug_reg_change_callback): Change type.
11464         (aarch64_notify_debug_reg_change): Update.
11465         * s390-linux-nat.c (s390_refresh_per_info): Update.
11466
11467 2019-03-11  Tom Tromey  <tromey@adacore.com>
11468
11469         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11470         redundant assignment to "this_cu".
11471
11472 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11473
11474         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11475
11476 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11477
11478         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11479         from...
11480         (rank_one_type): ... this.
11481
11482 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11483
11484         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11485         from...
11486         (rank_one_type): ... this.
11487
11488 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11489
11490         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11491         from...
11492         (rank_one_type): ... this.
11493
11494 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11495
11496         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11497         from...
11498         (rank_one_type): ... this.
11499
11500 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11501
11502         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11503         from...
11504         (rank_one_type): ... this.
11505
11506 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11507
11508         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11509         from...
11510         (rank_one_type): ... this.
11511
11512 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11513
11514         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11515         from...
11516         (rank_one_type): ... this.
11517
11518 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11519
11520         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11521         from...
11522         (rank_one_type): ... this.
11523
11524 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11525
11526         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11527         from...
11528         (rank_one_type): ... this.
11529
11530 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11531
11532         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11533         from...
11534         (rank_one_type): ... this.
11535
11536 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11537
11538         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11539         from...
11540         (rank_one_type): ... this.
11541
11542 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11543
11544         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11545         from...
11546         (rank_one_type): ... this.
11547
11548 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11549
11550         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11551         inferior-events' shows the example events.
11552
11553 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11554
11555         Support styling on native MS-Windows console
11556
11557         PR/24315
11558         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11559         on MS-Windows if $TERM is not defined.
11560
11561         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11562
11563         * posix-hdep.c (gdb_console_fputs):
11564         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11565         functions.
11566         * ui-file.h (gdb_console_fputs): Add prototype.
11567
11568         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11569         back to fputs only if the former returns zero.
11570
11571 2019-03-07  Tom Tromey  <tom@tromey.com>
11572
11573         * symmisc.c (print_symbol_bcache_statistics): Update.
11574         (print_objfile_statistics): Update.
11575         * symfile.c (allocate_symtab): Update.
11576         * stabsread.c: Don't include bcache.h.
11577         * psymtab.h (struct psymbol_bcache): Don't declare.
11578         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11579         (psymbol_bcache_init, psymbol_bcache_free)
11580         (psymbol_bcache_get_bcache): Don't declare.
11581         * psymtab.c (struct psymbol_bcache): Remove.
11582         (psymtab_storage::psymtab_storage): Update.
11583         (psymtab_storage::~psymtab_storage): Update.
11584         (psymbol_bcache_init, psymbol_bcache_free)
11585         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11586         (add_psymbol_to_bcache): Update.
11587         (allocate_psymtab): Update.
11588         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11589         macro_cache>: No longer pointers.
11590         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11591         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11592         * macrotab.c (macro_bcache): Update.
11593         * macroexp.c: Don't include bcache.h.
11594         * gdbtypes.c (check_types_worklist): Update.
11595         (types_deeply_equal): Remove TRY/CATCH.  Update.
11596         * elfread.c (elf_symtab_read): Update.
11597         * dwarf2read.c: Don't include bcache.h.
11598         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11599         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11600         (print_bcache_statistics, bcache_memory_used): Don't declare.
11601         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11602         methods.  Rename all data members.
11603         * bcache.c (struct bcache): Move to bcache.h.
11604         (bcache::expand_hash_table): Rename from expand_hash_table.
11605         (bcache): Remove.
11606         (bcache::insert): Rename from bcache_full.
11607         (bcache::compare): Rename from bcache_compare.
11608         (bcache_xmalloc): Remove.
11609         (bcache::~bcache): Rename from bcache_xfree.
11610         (bcache::print_statistics): Rename from print_bcache_statistics.
11611         (bcache::memory_used): Rename from bcache_memory_used.
11612
11613 2019-03-07  Pedro Alves  <palves@redhat.com>
11614
11615         * infrun.c (normal_stop): Also check for
11616         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11617
11618 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11619
11620         * f-lang.c (value_from_host_double): Moved to...
11621         * value.c (value_from_host_double): ...here.
11622         * value.h (value_from_host_double): Declare.
11623         * guile/scm-math.c (vlscm_convert_typed_number): Use
11624         value_from_host_double.
11625         (vlscm_convert_number): Likewise.
11626         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11627         * python/py-value.c (convert_value_from_python): Likewise.
11628
11629 2019-03-06  Tom Tromey  <tom@tromey.com>
11630
11631         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11632
11633 2019-03-06  Tom Tromey  <tom@tromey.com>
11634
11635         * utils.h (free_current_contents): Don't declare.
11636         * utils.c (free_current_contents): Remove.
11637
11638 2019-03-06  Tom Tromey  <tom@tromey.com>
11639
11640         * top.c (quit_force): Update.
11641         * main.c (captured_command_loop): Update.
11642         * common/new-op.c (operator new): Update.
11643         * common/common-exceptions.c (struct catcher)
11644         <save_cleanup_chain>: Remove member.
11645         (exceptions_state_mc_init): Update.
11646         (exception_try_scope_entry): Return nullptr.
11647         (exception_try_scope_exit, exception_rethrow)
11648         (throw_exception_sjlj, throw_exception_cxx): Update.
11649         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11650         (all_cleanups, do_cleanups, discard_cleanups)
11651         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11652         (restore_cleanups, restore_final_cleanups): Don't declare.
11653         (do_final_cleanups): Remove parameter.
11654         * common/cleanups.c (cleanup_chain, make_cleanup)
11655         (make_cleanup_dtor, all_cleanups, do_cleanups)
11656         (discard_my_cleanups, discard_cleanups)
11657         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11658         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11659         (null_cleanup): Remove.
11660         (do_final_cleanups): Remove parameter.
11661
11662 2019-03-06  Tom Tromey  <tom@tromey.com>
11663
11664         * remote.c (remote_target::remote_parse_stop_reply): Use
11665         unique_xmalloc_ptr.
11666
11667 2019-03-06  Tom Tromey  <tom@tromey.com>
11668
11669         * stabsread.c (struct stabs_field_info): Rename from field_info.
11670         <list, fnlist>: Add initializers.
11671         <obstack>: New member.
11672         (read_member_functions, read_struct_fields, read_baseclasses):
11673         Allocate on obstack.  Don't use cleanups.
11674         (read_one_struct_field, read_member_functions, read_struct_fields)
11675         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11676         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11677         (read_struct_type): Update.
11678
11679 2019-03-06  Tom Tromey  <tom@tromey.com>
11680
11681         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11682         * common/filestuff.h (make_cleanup_close): Don't declare.
11683         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11684         Remove.
11685
11686 2019-03-06  Tom Tromey  <tom@tromey.com>
11687
11688         * solib-aix.c: Use make_scope_exit.
11689
11690 2019-03-06  Tom Tromey  <tom@tromey.com>
11691
11692         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11693         Use make_scope_exit.
11694
11695 2019-03-06  Tom Tromey  <tom@tromey.com>
11696
11697         * solib-svr4.c (disable_probes_interface): Remove parameter.
11698         (svr4_handle_solib_event): Use make_scope_exit.
11699
11700 2019-03-06  Tom Tromey  <tom@tromey.com>
11701
11702         * remote.c (struct stop_reply_deleter): Remove.
11703         (stop_reply_up): Update.
11704         (struct stop_reply): Derive from notif_event.  Don't typedef.
11705         <regcache>: Now a std::vector.
11706         (stop_reply_xfree): Remove.
11707         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11708         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11709         (remote_target::discard_pending_stop_replies): Use delete.
11710         (remote_target::remote_parse_stop_reply): Update.
11711         (remote_target::process_stop_reply): Update.
11712         * remote-notif.h (struct notif_event): Add virtual destructor.
11713         Remove "dtr" member.
11714         (struct notif_client) <alloc_event>: Return a unique_ptr.
11715         (notif_event_xfree): Don't declare.
11716         (notif_event_up): New typedef.
11717         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11718         (notif_event_xfree, do_notif_event_xfree): Remove.
11719         (remote_notif_state_xfree): Update.
11720
11721 2019-03-06  Tom Tromey  <tom@tromey.com>
11722
11723         * infrun.c (displaced_step_clear_cleanup): Now a
11724         forward_scope_exit type.
11725         (displaced_step_prepare_throw): Update.
11726         (displaced_step_fixup): Update.
11727
11728 2019-03-06  Tom Tromey  <tom@tromey.com>
11729
11730         * inferior.h (class inferior): Update comment.
11731         * gdbthread.h (class thread_info): Update comment.
11732
11733 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11734             Tom Tromey  <tom@tromey.com>
11735
11736         * stabsread.h (struct stab_section_list): Remove.
11737         (coffstab_build_psymtabs): Update.
11738         * dbxread.c (symbuf_sections): Now a std::vector.
11739         (sect_idx): New global.
11740         (fill_symbuf): Update.
11741         (coffstab_build_psymtabs): Change type of stabsects parameter.
11742         Update.
11743         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11744         std::vector.
11745         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11746         (coff_locate_sections): Update.
11747         (coff_symfile_read): Remove cleanups.  Update.
11748         (init_stringtab): Add storage parameter.
11749         (free_stringtab, free_stringtab_cleanup): Remove.
11750         (init_lineno): Add storage parameter.
11751         (free_linetab, free_linetab_cleanup): Remove.
11752
11753 2019-03-06  Pedro Alves  <palves@redhat.com>
11754
11755         * linux-fork.c (fork_info::clobber_regs): Delete.
11756         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11757         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11758         comment.  Adjust.
11759         (scoped_switch_fork_info::scoped_switch_fork_info)
11760         (checkpoint_command, linux_fork_context): Adjust
11761         fork_save_infrun_state calls.
11762
11763 2019-03-06  Pedro Alves  <palves@redhat.com>
11764
11765         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11766         (inf_has_multiple_threads): Return 'bool' and rewrite using
11767         inferior_info::threads().
11768
11769 2019-03-06  Pedro Alves  <palves@redhat.com>
11770
11771         * linux-fork.c: Include <list>.
11772         (fork_list): Now a std::list instance.
11773         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11774         (forks_exist_p, find_last_fork): Adjust.
11775         (new_fork): Delete.
11776         (one_fork_p): New.
11777         (add_fork): Adjust.
11778         (free_fork): Delete, folded into fork_info::~fork_info().
11779         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11780         Adjust.
11781         (init_fork_list): Delete.
11782         (linux_fork_killall, linux_fork_mourn_inferior)
11783         (linux_fork_detach, info_checkpoints_command): Adjust.
11784         (_initialize_linux_fork): No longer call init_fork_list.
11785
11786 2019-03-06  Pedro Alves  <palves@redhat.com>
11787
11788         * linux-fork.c (new_fork): New, split out of ...
11789         (add_fork): ... this.  Return void.  Move "first fork" special
11790         case from here, to ...
11791         (checkpoint_command): ... here.
11792         * linux-linux.h (add_fork): Return void.
11793
11794 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11795
11796         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11797
11798 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11799             Chris January  <chris.january@arm.com>
11800             David Lecomber  <david.lecomber@arm.com>
11801
11802         * f-exp.y: New token, UNOP_INTRINSIC.
11803         (exp): New pattern using UNOP_INTRINSIC token.
11804         (f77_keywords): Add 'abs' keyword.
11805         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11806         (value_from_host_double): New function.
11807         (evaluate_subexp_f): Support UNOP_ABS.
11808
11809 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11810
11811         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11812         types.
11813
11814 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11815
11816         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11817         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11818         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11819
11820 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11821
11822         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11823
11824 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11825             Chris January  <chris.january@arm.com>
11826
11827         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11828         * f-exp.y: Define 'KIND' token.
11829         (exp): New pattern for KIND expressions.
11830         (ptype): Handle types with a kind extension.
11831         (direct_abs_decl): Extend to spot kind extensions.
11832         (f77_keywords): Add 'kind' to the list.
11833         (push_kind_type): New function.
11834         (convert_to_kind_type): New function.
11835         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11836         * parse.c (operator_length_standard): Likewise.
11837         * parser-defs.h (enum type_pieces): Add tp_kind.
11838         * std-operator.def: Add UNOP_KIND.
11839
11840 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11841
11842         * f-exp.y (f_parse): Set yydebug.
11843
11844 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11845
11846         * f-lang.c (evaluate_subexp_f): New function.
11847         (exp_descriptor_f): New global.
11848         (f_language_defn): Use exp_descriptor_f instead of
11849         exp_descriptor_standard.
11850
11851 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11852
11853         * f-exp.y (struct token): Add comments.
11854         (dot_ops): Remove uppercase versions and the end marker.
11855         (f77_keywords): Likewise.
11856         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11857         entries in the dot_ops array are case insensitive, and use
11858         strncasecmp to compare strings.  Also some whitespace cleanup in
11859         this area.  Similar for the f77_keywords array, except entries in
11860         this list might be case sensitive.
11861
11862 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11863
11864         * f-exp.y (struct f77_boolean_val): Add comments.
11865         (boolean_values): Remove uppercase versions, and end marker.
11866         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11867         and use strncasecmp to achieve case insensitivity.  Additionally,
11868         perform whitespace cleanup around this code.
11869
11870 2019-03-06  Tom Tromey  <tromey@adacore.com>
11871
11872         * remote-sim.c (gdbsim_target_open): Use result of
11873         gdb_argv::release.
11874
11875 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11876         Dirk Schubert  <dirk.schubert@arm.com>
11877         Chris January  <chris.january@arm.com>
11878
11879         * eval.c (evaluate_subexp_standard): Call Fortran argument
11880         wrapping logic.
11881         * f-lang.c (struct value): A value which can be passed into a
11882         Fortran function call.
11883         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11884         where appropriate.
11885         (struct type): Value ready for a Fortran function call.
11886         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11887         is needed.
11888         * f-lang.h (fortran_argument_convert): Declaration.
11889         (fortran_preserve_arg_pointer): Declaration.
11890         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11891
11892 2019-03-05  Tom Tromey  <tromey@adacore.com>
11893
11894         * python/py-prettyprint.c (print_string_repr): Remove #if.
11895         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11896
11897 2019-03-05  Tom Tromey  <tromey@adacore.com>
11898
11899         * target.c (the_dummy_target): Move later.  Change type to
11900         "dummy_target".
11901         (initialize_targets): Don't initialize the_dummy_target.
11902
11903 2019-03-05  Tom Tromey  <tromey@adacore.com>
11904
11905         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11906         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11907
11908 2019-03-05  Tom Tromey  <tromey@adacore.com>
11909
11910         * windows-nat.c (windows_nat_target::attach)
11911         (windows_nat_target::detach): Don't call gdb_flush.
11912         * valprint.c (generic_val_print, val_print, val_print_string):
11913         Don't call gdb_flush.
11914         * utils.c (defaulted_query): Don't call gdb_flush.
11915         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11916         * target.c (target_announce_detach): Don't call gdb_flush.
11917         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11918         * remote.c (extended_remote_target::attach): Don't call
11919         gdb_flush.
11920         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11921         * printcmd.c (do_examine): Don't call gdb_flush.
11922         (info_display_command): Don't call gdb_flush.
11923         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11924         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11925         * memattr.c (info_mem_command): Don't call gdb_flush.
11926         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11927         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11928         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11929         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11930         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11931         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11932         (gnu_nat_target::detach): Don't call gdb_flush.
11933         * f-valprint.c (f_val_print): Don't call gdb_flush.
11934         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11935         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11936         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11937         gdb_flush.
11938         * c-valprint.c (c_val_print): Don't call gdb_flush.
11939         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11940
11941 2019-03-05  Tom Tromey  <tromey@adacore.com>
11942
11943         * varobj.c (update_dynamic_varobj_children): Update.
11944         (install_default_visualizer): Use reset, not release.
11945         * value.c (set_internalvar): Update.
11946         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11947         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11948         ATTRIBUTE_UNUSED_RESULT.
11949
11950 2019-03-05  Tom Tromey  <tromey@adacore.com>
11951
11952         * remote.c (class scoped_remote_fd) <release>: Add
11953         ATTRIBUTE_UNUSED_RESULT.
11954
11955 2019-03-05  Tom Tromey  <tromey@adacore.com>
11956
11957         * macroexp.c (struct macro_buffer) <release>: Add
11958         ATTRIBUTE_UNUSED_RESULT.
11959
11960 2019-03-05  Tom Tromey  <tromey@adacore.com>
11961
11962         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11963         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11964         ATTRIBUTE_UNUSED_RESULT.
11965
11966 2019-03-05  Tom Tromey  <tromey@adacore.com>
11967
11968         * common/scoped_fd.h (class scoped_fd) <release>: Add
11969         ATTRIBUTE_UNUSED_RESULT.
11970
11971 2019-03-05  Tom Tromey  <tromey@adacore.com>
11972
11973         * parser-defs.h (struct parser_state) <release>: Add
11974         ATTRIBUTE_UNUSED_RESULT.
11975
11976 2019-03-05  Tom Tromey  <tromey@adacore.com>
11977
11978         * utils.h (class gdb_argv) <release>: Add
11979         ATTRIBUTE_UNUSED_RESULT.
11980         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11981
11982 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11983
11984         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11985         for-loop range, to avoid compiler warnings.
11986
11987         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11988         avoid compiler warnings about unused variables.
11989
11990         * NEWS: Mention end of support for native debugging on MS-Windows
11991         before XP.
11992
11993         PR gdb/24292
11994         * common/netstuff.c:
11995         * gdbserver/gdbreplay.c
11996         * gdbserver/remote-utils.c:
11997         * ser-tcp.c:
11998         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11999         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12000         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12001         'getaddrinfo' and 'freeaddrinfo' were not available before
12002         Windows XP, and mingw.org's MinGW headers by default define
12003         _WIN32_WINNT to 0x500.
12004
12005 2019-03-01  Gary Benson <gbenson@redhat.com>
12006
12007         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12008
12009 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12010             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12011
12012         PR gdb/8527
12013         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12014         set_sigint_trap, clear_sigint_trap.
12015
12016 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12017
12018         * target.c (target_detach): Clear the regcache and the
12019         frame cache.
12020
12021 2019-02-27  Pedro Alves  <palves@redhat.com>
12022
12023         * utils.c (set_screen_size): When we cap the height/width sizes,
12024         tweak the corresponding command variable to show "unlimited":
12025
12026 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12027             Pedro Alves  <palves@redhat.com>
12028
12029         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12030         before calling rl_set_screen_size.
12031
12032 2019-02-27  Tom Tromey  <tromey@adacore.com>
12033
12034         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12035         define.
12036         * python/py-value.c: Remove Python 2.4 workaround.
12037         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12038         workaround.
12039         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12040         Python 2.4 workaround.
12041         * python/python-internal.h: Remove Python 2.4 comment.
12042         (Py_ssize_t): Don't define.
12043         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12044         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12045         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12046         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12047         * python/python.c (do_start_initialization): Remove Python 2.4
12048         workaround.
12049         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12050         (print_children): Remove Python 2.4 workaround.
12051         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12052         workaround.
12053         (CHARBUFFERPROC_NAME): Remove.
12054         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12055         Python 2.4 workaround.
12056
12057 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12058
12059         * NEWS: Note minimum Python version.
12060
12061 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12062
12063         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12064         code from these functions.  Remove corresponding ifdefs.  Use
12065         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12066         Remove gotos and target of gotos.
12067         (infpy_search_memory): Likewise.
12068
12069 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12070
12071         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12072         (hppa_gdbarch_init): Don't register deleted functions with
12073         gdbarch.
12074
12075 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12076
12077         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12078         (h8300_unwind_sp): Delete.
12079         (h8300_dummy_id): Delete.
12080         (h8300_gdbarch_init): Don't register deleted functions with
12081         gdbarch.
12082
12083 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12084
12085         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12086         (ft32_unwind_pc): Delete.
12087         (ft32_unwind_sp): Delete.
12088         (ft32_gdbarch_init): Don't register deleted functions with
12089         gdbarch.
12090
12091 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12092
12093         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12094         (frv_unwind_pc): Delete.
12095         (frv_unwind_sp): Delete.
12096         (frv_gdbarch_init): Don't register deleted functions with
12097         gdbarch.
12098
12099 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12100
12101         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12102         (riscv_unwind_pc): Delete.
12103         (riscv_unwind_sp): Delete.
12104         (riscv_gdbarch_init): Don't register deleted functions with
12105         gdbarch.
12106
12107 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12108
12109         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12110         (csky_unwind_pc): Delete.
12111         (csky_unwind_sp): Delete.
12112         (csky_gdbarch_init): Don't register deleted functions with
12113         gdbarch.
12114
12115 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12116
12117         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12118         (cris_unwind_pc): Delete.
12119         (cris_unwind_sp): Delete.
12120         (cris_gdbarch_init): Don't register deleted functions with
12121         gdbarch.
12122
12123 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12124
12125         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12126         (bfin_unwind_pc): Delete.
12127         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12128
12129 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12130
12131         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12132         (arm_unwind_pc): Delete.
12133         (arm_unwind_sp): Delete.
12134         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12135
12136 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12137
12138         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12139         (arc_unwind_pc): Delete.
12140         (arc_unwind_sp): Delete.
12141         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12142
12143 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12144
12145         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12146         (alpha_unwind_pc): Delete.
12147         (alpha_gdbarch_init): Don't register deleted functions with
12148         gdbarch.
12149
12150 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12151
12152         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12153         (aarch64_unwind_pc): Delete.
12154         (aarch64_unwind_sp): Delete.
12155         (aarch64_gdbarch_init): Don't register deleted functions with
12156         gdbarch.
12157
12158 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12159
12160         * gdbtypes.c (type_align): Don't consider static members when
12161         computing structure alignment.
12162
12163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12164
12165         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12166         return 0 for other types.
12167         * arch-utils.c (default_type_align): Always return 0.
12168         * gdbarch.h: Regenerate.
12169         * gdbarch.sh (type_align): Extend comment.
12170         * gdbtypes.c (type_align): Add additional comments, always call
12171         gdbarch_type_align before applying the default rules.
12172         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12173         generic code will then apply a suitable default.
12174         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12175         types, return 0 for other types.
12176
12177 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12178
12179         * NEWS: Create a new section for the next release branch.
12180         Rename the section of the current branch, now that it has
12181         been cut.
12182
12183 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12184
12185         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12186         * version.in: Bump version to 8.3.50.DATE-git.
12187
12188 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12189
12190         * aix-thread.c (ptid_cmp): Remove unused variable.
12191         (get_signaled_thread): Likewise.
12192         (store_regs_user_thread): Likewise.
12193         (store_regs_kernel_thread): Likewise.
12194         (fetch_regs_kernel_thread): Remove shadowed variable.
12195
12196 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12197
12198         * features/riscv/32bit-cpu.xml: Add register numbers.
12199         * features/riscv/32bit-fpu.c: Regenerate.
12200         * features/riscv/32bit-fpu.xml: Add register numbers.
12201         * features/riscv/64bit-cpu.xml: Add register numbers.
12202         * features/riscv/64bit-fpu.c: Regenerate.
12203         * features/riscv/64bit-fpu.xml: Add register numbers.
12204
12205 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12206
12207         * NEWS: Mention two argument form of gdb.Value constructor.
12208         * python/py-value.c (convert_buffer_and_type_to_value): New
12209         function.
12210         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12211         Add support for handling an optional second argument.  Call
12212         convert_buffer_and_type_to_value as appropriate.
12213         * python/python-internal.h (Py_buffer_deleter): New struct.
12214         (Py_buffer_up): New typedef.
12215
12216 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12217
12218         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12219         instead of releasing ownership.
12220
12221 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12222
12223         * dwarf2read.c (open_and_init_dwp_file): Call
12224         elf_numsections instead of bfd_count_sections to initialize
12225         dwp_file->num_sections.
12226
12227 2019-02-25  Tom Tromey  <tromey@adacore.com>
12228
12229         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12230
12231 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12232
12233         * gcore.in: Add '--readnever' option when invoking GDB.
12234
12235 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12236
12237         * MAINTAINERS: Update my email address.
12238
12239 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12240
12241         * build-id.c (build_id_to_debug_bfd_1): New function.
12242         (build_id_to_debug_bfd): Look for separate debug file in
12243         sysroot.
12244
12245 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12246
12247         * gdbarch.sh: Update the copyright year range that is placed into
12248         generated files.
12249
12250 2019-02-22  Keith Seitz  <keiths@redhat.com>
12251
12252         PR symtab/23853
12253         * linespec.c (create_sals_line_offset): Search for the default
12254         symtab's filename instead of its fullname.
12255
12256 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12257
12258         * NEWS: Update style defaults.
12259
12260 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12261
12262         * main.c (captured_main_1): Disable styling in batch mode.
12263
12264 2019-02-20  Tom Tromey  <tom@tromey.com>
12265
12266         * symtab.c (symtab_symbol_info): Fix typos.
12267
12268 2019-02-20  Tom Tromey  <tromey@adacore.com>
12269
12270         * findcmd.c (_initialize_mem_search): Use upper case for
12271         metasyntactic variables.
12272
12273 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12274
12275         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12276         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12277
12278 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12279
12280         * top.h (source_file_name): Change to std::string.
12281         * top.c (source_file_name): Likewise.
12282         (command_line_input): Adjust.
12283         * cli/cli-script.c (script_from_file): Adjust.
12284
12285 2019-02-19  Tom Tromey  <tromey@adacore.com>
12286
12287         * ravenscar-thread.c
12288         (ravenscar_thread_target::update_thread_list): Don't call
12289         ada_build_task_list.
12290         * ada-lang.h (ada_build_task_list): Don't declare.
12291         * ada-tasks.c (struct ada_tasks_inferior_data)
12292         <task_list_valid_p>: Now bool.
12293         (read_known_tasks, ada_task_list_changed)
12294         (ada_tasks_invalidate_inferior_data): Update.
12295         (read_known_tasks_array): Return bool.
12296         (read_known_tasks_list): Likewise.
12297         (read_known_tasks): Return void.
12298         (ada_build_task_list): Now static.
12299
12300 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12301
12302         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12303         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12304
12305 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12306
12307         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12308         variant for ada_tasks_pspace_data_handle and
12309         ada_tasks_inferior_data_handle.
12310         (ada_tasks_pspace_data_cleanup): New function.
12311         (ada_tasks_inferior_data_cleanup): New function.
12312
12313 2019-02-17  Tom Tromey  <tom@tromey.com>
12314
12315         * macrotab.h (macro_source_fullname): Return a std::string.
12316         * macrotab.c (macro_include, check_for_redefinition)
12317         (macro_undef, macro_lookup_definition, foreach_macro)
12318         (foreach_macro_in_scope): Update.
12319         (macro_source_fullname): Return a std::string.
12320         * macrocmd.c (show_pp_source_pos): Update.
12321
12322 2019-02-17  Tom Tromey  <tom@tromey.com>
12323
12324         * macrocmd.c (show_pp_source_pos): Style the file names.
12325
12326 2019-02-17  Tom Tromey  <tom@tromey.com>
12327
12328         PR tui/24197:
12329         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12330
12331 2019-02-17  Tom Tromey  <tom@tromey.com>
12332
12333         * ada-lang.c (user_select_syms): Use filtered printing.
12334         * utils.c (wrap_style): New global.
12335         (desired_style): Remove.
12336         (emit_style_escape): Add stream parameter.
12337         (set_output_style, reset_terminal_style, prompt_for_continue):
12338         Update.
12339         (flush_wrap_buffer): Only flush gdb_stdout.
12340         (wrap_here): Set wrap_style.
12341         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12342         treat escape sequences as a character.  Change when wrap buffer is
12343         flushed.
12344         (fputs_styled): Do not set the output style when the default is
12345         requested.
12346         * ui-style.h (struct ui_file_style) <is_default>: New method.
12347         * source.c (print_source_lines_base): Emit escape sequences in one
12348         piece.
12349
12350 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12351
12352         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12353         integers and enumeration types.
12354
12355 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12356
12357         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12358         instead of lookup_symbol_in_language
12359         (do_exact_match): New function.
12360         (ada_get_symbol_name_matcher): Return do_exact_match when
12361         doing a verbatim match.
12362
12363 2019-02-15  Tom Tromey  <tromey@adacore.com>
12364
12365         * ravenscar-thread.c (ravenscar_thread_target::resume)
12366         (ravenscar_thread_target::wait): Special case wildcard requests.
12367
12368 2019-02-15  Tom Tromey  <tromey@adacore.com>
12369
12370         * ravenscar-thread.c (base_ptid): Remove.
12371         (struct ravenscar_thread_target) <close>: New method.
12372         <m_base_ptid>: New member.
12373         <update_inferior_ptid, active_task, task_is_currently_active,
12374         runtime_initialized>: Declare methods.
12375         <ravenscar_thread_target>: Add constructor.
12376         (ravenscar_thread_target::task_is_currently_active)
12377         (ravenscar_thread_target::update_inferior_ptid)
12378         (ravenscar_runtime_initialized): Rename.  Now methods.
12379         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12380         (ravenscar_thread_target::update_thread_list): Update.
12381         (ravenscar_thread_target::active_task): Now method.
12382         (ravenscar_thread_target::store_registers)
12383         (ravenscar_thread_target::prepare_to_store)
12384         (ravenscar_thread_target::prepare_to_store)
12385         (ravenscar_thread_target::mourn_inferior): Update.
12386         (ravenscar_inferior_created): Use "new" to create target.
12387         (ravenscar_thread_target::get_ada_task_ptid): Update.
12388         (_initialize_ravenscar): Don't initialize base_ptid.
12389         (ravenscar_ops): Remove global.
12390
12391 2019-02-15  Tom Tromey  <tromey@adacore.com>
12392
12393         * target.h (push_target): Declare new overload.
12394         * target.c (push_target): New overload, taking an rvalue reference.
12395         * remote.c (remote_target::open_1): Use push_target overload.
12396         * corelow.c (core_target_open): Use push_target overload.
12397
12398 2019-02-15  Tom Tromey  <tromey@adacore.com>
12399
12400         * ravenscar-thread.c (is_ravenscar_task)
12401         (ravenscar_task_is_currently_active): Return bool.
12402         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12403         (_initialize_ravenscar): Remove "(void)".
12404         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12405         Return bool.
12406
12407 2019-02-15  Tom Tromey  <tromey@adacore.com>
12408
12409         * ravenscar-thread.c (ravenscar_runtime_initializer)
12410         (has_ravenscar_runtime, get_running_thread_id)
12411         (ravenscar_thread_target::resume): Fix indentation.
12412
12413 2019-02-15  Tom Tromey  <tromey@adacore.com>
12414
12415         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12416         from ravenscar_arch_ops.
12417         (sparc_ravenscar_ops::fetch_registers)
12418         (sparc_ravenscar_ops::store_registers): Now methods.
12419         (sparc_ravenscar_prepare_to_store): Remove.
12420         (sparc_ravenscar_ops): Redefine.
12421         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12422         methods and destructor.  Remove members.
12423         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12424         (ravenscar_thread_target::store_registers)
12425         (ravenscar_thread_target::prepare_to_store): Update.
12426         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12427         Remove.
12428         (struct ppc_ravenscar_powerpc_ops): Derive from
12429         ravenscar_arch_ops.
12430         (ppc_ravenscar_powerpc_ops::fetch_registers)
12431         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12432         (ppc_ravenscar_powerpc_ops): Redefine.
12433         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12434         (ppc_ravenscar_e500_ops::fetch_registers)
12435         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12436         (ppc_ravenscar_e500_ops): Redefine.
12437         * aarch64-ravenscar-thread.c
12438         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12439         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12440         (aarch64_ravenscar_fetch_registers)
12441         (aarch64_ravenscar_store_registers): Now methods.
12442         (aarch64_ravenscar_ops): Redefine.
12443
12444 2019-02-15  Tom Tromey  <tromey@adacore.com>
12445
12446         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12447         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12448         (ravenscar_thread_target::stopped_by_watchpoint)
12449         (ravenscar_thread_target::stopped_data_address)
12450         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12451
12452 2019-02-15  Tom Tromey  <tromey@adacore.com>
12453
12454         * ravenscar-thread.c: Fix some typos.
12455
12456 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12457             Tom Tromey  <tromey@adacore.com>
12458
12459         * ada-lang.c (ada_exception_sal): Change addr_string to a
12460         std::string.
12461         (create_ada_exception_catchpoint): Update.
12462
12463 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12464             Tom Tromey  <tromey@adacore.com>
12465
12466         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12467         (bp_location_ops): Remove.
12468         (base_breakpoint_allocate_location): Update.
12469         (free_bp_location): Update.
12470         * ada-lang.c (class ada_catchpoint_location)
12471         <ada_catchpoint_location>: Remove ops parameter.
12472         (ada_catchpoint_location_dtor): Remove.
12473         (ada_catchpoint_location_ops): Remove.
12474         (allocate_location_exception): Update.
12475         * breakpoint.h (struct bp_location_ops): Remove.
12476         (class bp_location) <bp_location>: Remove bp_location_ops
12477         parameter.
12478         <~bp_location>: Add destructor.
12479         <ops>: Remove.
12480
12481 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12482             Pedro Alves  <palves@redhat.com>
12483
12484         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12485         'PATH_MAX'.
12486
12487 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12488             Samuel Thibault  <samuel.thibault@gnu.org>
12489             Thomas Schwinge  <thomas@codesourcery.com>
12490
12491         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12492         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12493
12494 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12495
12496         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12497         (check_empty): Use "const char *".
12498
12499         * gnu-nat.c (gnu_nat_target::detach): Instead of
12500         'detach_inferior (pid)' call
12501         'detach_inferior (find_inferior_pid (pid))'.
12502
12503         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12504         'nat/fork-inferior.o'.
12505         * gnu-nat.c: #include "nat/fork-inferior.h".
12506
12507         * gnu-nat.c (gnu_nat_target::detach): Instead of
12508         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12509         * gnu-nat.h: #include "inf-child.h".
12510         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12511         'i386_gnu_nat_target::fetch_registers'.
12512         (gnu_store_registers): Rename/move to
12513         'i386_gnu_nat_target::store_registers'.
12514
12515         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12516         * gnu-nat.h (mach_thread_info): New function.
12517         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12518
12519         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12520
12521 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12522
12523         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12524
12525 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12526
12527         * windows-nat.c (windows_add_thread): Add new parameter
12528         "main_thread_p" with default value set to false.  Update
12529         function documentation as well as all callers.
12530         (windows_delete_thread): Likewise.
12531         (fake_create_process): Update call to windows_add_thread.
12532         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12533         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12534         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12535         call to windows_delete_thread.
12536
12537 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12538
12539         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12540
12541 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12542
12543         * symfile.c (find_separate_debug_file): Use canonical path of
12544         sysroot with child_path instead of gdb_sysroot if it is valid.
12545
12546 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12547
12548         * symfile.c (find_separate_debug_file): Use child_path to
12549         determine if an object file is under a sysroot.
12550
12551 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12552
12553         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12554         unittests/child-path-selftests.c.
12555         * common/pathstuff.c (child_path): New function.
12556         * common/pathstuff.h (child_path): New prototype.
12557         * unittests/child-path-selftests.c: New file.
12558
12559 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12560
12561         * symfile.c (find_separate_debug_file): Look for separate debug
12562         files in debug directories under the sysroot.
12563
12564 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12565
12566         * symtab.h (struct minimal_symbol data_p): New const method.
12567         (struct minimal_symbol text_p): Likewise.
12568         * symtab.c (output_source_filename): Use file name style
12569         to print file name.
12570         (print_symbol_info): Likewise.
12571         (print_msymbol_info): Use address style to print addresses.
12572         Use function name style to print executable text symbols.
12573         (expand_symtab_containing_pc): Use data_p.
12574         (find_pc_sect_compunit_symtab): Likewise.
12575
12576 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12577
12578         * breakpoint.c (describe_other_breakpoints): Use address style
12579         to print addresses.
12580         (say_where): Likewise.
12581
12582 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12583
12584         * ada-typeprint.c (print_func_type): Print function name
12585         style to print function name.
12586         * c-typeprint.c (c_print_type_1): Likewise.
12587
12588 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12589
12590         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12591         for execve.
12592
12593 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12594
12595         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12596         type_stack.
12597
12598 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12599
12600         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12601         TYPE_CODE_REF types.
12602
12603 2019-02-08  Jim Wilson  <jimw@sifive.com>
12604
12605         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12606         (riscv_linux_fregset): New.
12607         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12608
12609 2019-02-07  Tom Tromey  <tom@tromey.com>
12610
12611         * thread.c (thread_cancel_execution_command): Update.
12612         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12613         methods.
12614         (struct thread_fsm_ops): Remove.
12615         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12616         (thread_fsm_should_stop, thread_fsm_return_value)
12617         (thread_fsm_set_finished, thread_fsm_finished_p)
12618         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12619         Don't declare.
12620         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12621         * infrun.c (clear_proceed_status_thread)
12622         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12623         (print_stop_event): Update.
12624         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12625         Add constructor.
12626         (step_command_fsm_ops): Remove.
12627         (new_step_command_fsm): Remove.
12628         (step_1): Update.
12629         (step_command_fsm::should_stop): Rename from
12630         step_command_fsm_should_stop.
12631         (step_command_fsm::clean_up): Rename from
12632         step_command_fsm_clean_up.
12633         (step_command_fsm::do_async_reply_reason): Rename from
12634         step_command_fsm_async_reply_reason.
12635         (struct until_next_fsm): Inherit from thread_fsm.  Add
12636         constructor.
12637         (until_next_fsm_ops): Remove.
12638         (new_until_next_fsm): Remove.
12639         (until_next_fsm::should_stop): Rename from
12640         until_next_fsm_should_stop.
12641         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12642         (until_next_fsm::do_async_reply_reason): Rename from
12643         until_next_fsm_async_reply_reason.
12644         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12645         constructor.  Change type of breakpoint.
12646         (finish_command_fsm_ops): Remove.
12647         (new_finish_command_fsm): Remove.
12648         (finish_command_fsm::should_stop): Rename from
12649         finish_command_fsm_should_stop.
12650         (finish_command_fsm::clean_up): Rename from
12651         finish_command_fsm_clean_up.
12652         (finish_command_fsm::return_value): Rename from
12653         finish_command_fsm_return_value.
12654         (finish_command_fsm::do_async_reply_reason): Rename from
12655         finish_command_fsm_async_reply_reason.
12656         (finish_command): Update.
12657         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12658         Add constructor.
12659         (call_thread_fsm_ops): Remove.
12660         (call_thread_fsm::call_thread_fsm): Rename from
12661         new_call_thread_fsm.
12662         (call_thread_fsm::should_stop): Rename from
12663         call_thread_fsm_should_stop.
12664         (call_thread_fsm::should_notify_stop): Rename from
12665         call_thread_fsm_should_notify_stop.
12666         (run_inferior_call, call_function_by_hand_dummy): Update.
12667         * cli/cli-interp.c (should_print_stop_to_console): Update.
12668         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12669         Add constructor.  Change type of location_breakpoint,
12670         caller_breakpoint.
12671         (until_break_fsm_ops): Remove.
12672         (new_until_break_fsm): Remove.
12673         (until_break_fsm::should_stop): Rename from
12674         until_break_fsm_should_stop.
12675         (until_break_fsm::clean_up): Rename from
12676         until_break_fsm_clean_up.
12677         (until_break_fsm::do_async_reply_reason): Rename from
12678         until_break_fsm_async_reply_reason.
12679         (until_break_command): Update.
12680         * thread-fsm.c: Remove.
12681         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12682
12683 2019-02-07  Tom Tromey  <tom@tromey.com>
12684
12685         * yy-remap.h: Add include guard.
12686         * xtensa-tdep.h: Add include guard.
12687         * xcoffread.h: Rename include guard.
12688         * varobj-iter.h: Add include guard.
12689         * tui/tui.h: Rename include guard.
12690         * tui/tui-winsource.h: Rename include guard.
12691         * tui/tui-wingeneral.h: Rename include guard.
12692         * tui/tui-windata.h: Rename include guard.
12693         * tui/tui-win.h: Rename include guard.
12694         * tui/tui-stack.h: Rename include guard.
12695         * tui/tui-source.h: Rename include guard.
12696         * tui/tui-regs.h: Rename include guard.
12697         * tui/tui-out.h: Rename include guard.
12698         * tui/tui-layout.h: Rename include guard.
12699         * tui/tui-io.h: Rename include guard.
12700         * tui/tui-hooks.h: Rename include guard.
12701         * tui/tui-file.h: Rename include guard.
12702         * tui/tui-disasm.h: Rename include guard.
12703         * tui/tui-data.h: Rename include guard.
12704         * tui/tui-command.h: Rename include guard.
12705         * tic6x-tdep.h: Add include guard.
12706         * target/waitstatus.h: Rename include guard.
12707         * target/wait.h: Rename include guard.
12708         * target/target.h: Rename include guard.
12709         * target/resume.h: Rename include guard.
12710         * target-float.h: Rename include guard.
12711         * stabsread.h: Add include guard.
12712         * rs6000-tdep.h: Add include guard.
12713         * riscv-fbsd-tdep.h: Add include guard.
12714         * regformats/regdef.h: Rename include guard.
12715         * record.h: Rename include guard.
12716         * python/python.h: Rename include guard.
12717         * python/python-internal.h: Rename include guard.
12718         * python/py-stopevent.h: Rename include guard.
12719         * python/py-ref.h: Rename include guard.
12720         * python/py-record.h: Rename include guard.
12721         * python/py-record-full.h: Rename include guard.
12722         * python/py-record-btrace.h: Rename include guard.
12723         * python/py-instruction.h: Rename include guard.
12724         * python/py-events.h: Rename include guard.
12725         * python/py-event.h: Rename include guard.
12726         * procfs.h: Add include guard.
12727         * proc-utils.h: Add include guard.
12728         * p-lang.h: Add include guard.
12729         * or1k-tdep.h: Rename include guard.
12730         * observable.h: Rename include guard.
12731         * nto-tdep.h: Rename include guard.
12732         * nat/x86-linux.h: Rename include guard.
12733         * nat/x86-linux-dregs.h: Rename include guard.
12734         * nat/x86-gcc-cpuid.h: Add include guard.
12735         * nat/x86-dregs.h: Rename include guard.
12736         * nat/x86-cpuid.h: Rename include guard.
12737         * nat/ppc-linux.h: Rename include guard.
12738         * nat/mips-linux-watch.h: Rename include guard.
12739         * nat/linux-waitpid.h: Rename include guard.
12740         * nat/linux-ptrace.h: Rename include guard.
12741         * nat/linux-procfs.h: Rename include guard.
12742         * nat/linux-osdata.h: Rename include guard.
12743         * nat/linux-nat.h: Rename include guard.
12744         * nat/linux-namespaces.h: Rename include guard.
12745         * nat/linux-btrace.h: Rename include guard.
12746         * nat/glibc_thread_db.h: Rename include guard.
12747         * nat/gdb_thread_db.h: Rename include guard.
12748         * nat/gdb_ptrace.h: Rename include guard.
12749         * nat/fork-inferior.h: Rename include guard.
12750         * nat/amd64-linux-siginfo.h: Rename include guard.
12751         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12752         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12753         * nat/aarch64-linux.h: Rename include guard.
12754         * nat/aarch64-linux-hw-point.h: Rename include guard.
12755         * mn10300-tdep.h: Add include guard.
12756         * mips-linux-tdep.h: Add include guard.
12757         * mi/mi-parse.h: Rename include guard.
12758         * mi/mi-out.h: Rename include guard.
12759         * mi/mi-main.h: Rename include guard.
12760         * mi/mi-interp.h: Rename include guard.
12761         * mi/mi-getopt.h: Rename include guard.
12762         * mi/mi-console.h: Rename include guard.
12763         * mi/mi-common.h: Rename include guard.
12764         * mi/mi-cmds.h: Rename include guard.
12765         * mi/mi-cmd-break.h: Rename include guard.
12766         * m2-lang.h: Add include guard.
12767         * location.h: Rename include guard.
12768         * linux-record.h: Rename include guard.
12769         * linux-nat.h: Add include guard.
12770         * linux-fork.h: Add include guard.
12771         * i386-darwin-tdep.h: Rename include guard.
12772         * hppa-linux-offsets.h: Add include guard.
12773         * guile/guile.h: Rename include guard.
12774         * guile/guile-internal.h: Rename include guard.
12775         * gnu-nat.h: Rename include guard.
12776         * gdb-stabs.h: Rename include guard.
12777         * frv-tdep.h: Add include guard.
12778         * f-lang.h: Add include guard.
12779         * event-loop.h: Add include guard.
12780         * darwin-nat.h: Rename include guard.
12781         * cp-abi.h: Rename include guard.
12782         * config/sparc/nm-sol2.h: Rename include guard.
12783         * config/nm-nto.h: Rename include guard.
12784         * config/nm-linux.h: Add include guard.
12785         * config/i386/nm-i386gnu.h: Rename include guard.
12786         * config/djgpp/nl_types.h: Rename include guard.
12787         * config/djgpp/langinfo.h: Rename include guard.
12788         * compile/gcc-cp-plugin.h: Add include guard.
12789         * compile/gcc-c-plugin.h: Add include guard.
12790         * compile/compile.h: Rename include guard.
12791         * compile/compile-object-run.h: Rename include guard.
12792         * compile/compile-object-load.h: Rename include guard.
12793         * compile/compile-internal.h: Rename include guard.
12794         * compile/compile-cplus.h: Rename include guard.
12795         * compile/compile-c.h: Rename include guard.
12796         * common/xml-utils.h: Rename include guard.
12797         * common/x86-xstate.h: Rename include guard.
12798         * common/version.h: Rename include guard.
12799         * common/vec.h: Rename include guard.
12800         * common/tdesc.h: Rename include guard.
12801         * common/selftest.h: Rename include guard.
12802         * common/scoped_restore.h: Rename include guard.
12803         * common/scoped_mmap.h: Rename include guard.
12804         * common/scoped_fd.h: Rename include guard.
12805         * common/safe-iterator.h: Rename include guard.
12806         * common/run-time-clock.h: Rename include guard.
12807         * common/refcounted-object.h: Rename include guard.
12808         * common/queue.h: Rename include guard.
12809         * common/ptid.h: Rename include guard.
12810         * common/print-utils.h: Rename include guard.
12811         * common/preprocessor.h: Rename include guard.
12812         * common/pathstuff.h: Rename include guard.
12813         * common/observable.h: Rename include guard.
12814         * common/netstuff.h: Rename include guard.
12815         * common/job-control.h: Rename include guard.
12816         * common/host-defs.h: Rename include guard.
12817         * common/gdb_wait.h: Rename include guard.
12818         * common/gdb_vecs.h: Rename include guard.
12819         * common/gdb_unlinker.h: Rename include guard.
12820         * common/gdb_unique_ptr.h: Rename include guard.
12821         * common/gdb_tilde_expand.h: Rename include guard.
12822         * common/gdb_sys_time.h: Rename include guard.
12823         * common/gdb_string_view.h: Rename include guard.
12824         * common/gdb_splay_tree.h: Rename include guard.
12825         * common/gdb_setjmp.h: Rename include guard.
12826         * common/gdb_ref_ptr.h: Rename include guard.
12827         * common/gdb_optional.h: Rename include guard.
12828         * common/gdb_locale.h: Rename include guard.
12829         * common/gdb_assert.h: Rename include guard.
12830         * common/filtered-iterator.h: Rename include guard.
12831         * common/filestuff.h: Rename include guard.
12832         * common/fileio.h: Rename include guard.
12833         * common/environ.h: Rename include guard.
12834         * common/common-utils.h: Rename include guard.
12835         * common/common-types.h: Rename include guard.
12836         * common/common-regcache.h: Rename include guard.
12837         * common/common-inferior.h: Rename include guard.
12838         * common/common-gdbthread.h: Rename include guard.
12839         * common/common-exceptions.h: Rename include guard.
12840         * common/common-defs.h: Rename include guard.
12841         * common/common-debug.h: Rename include guard.
12842         * common/cleanups.h: Rename include guard.
12843         * common/buffer.h: Rename include guard.
12844         * common/btrace-common.h: Rename include guard.
12845         * common/break-common.h: Rename include guard.
12846         * cli/cli-utils.h: Rename include guard.
12847         * cli/cli-style.h: Rename include guard.
12848         * cli/cli-setshow.h: Rename include guard.
12849         * cli/cli-script.h: Rename include guard.
12850         * cli/cli-interp.h: Rename include guard.
12851         * cli/cli-decode.h: Rename include guard.
12852         * cli/cli-cmds.h: Rename include guard.
12853         * charset-list.h: Add include guard.
12854         * buildsym-legacy.h: Rename include guard.
12855         * bfin-tdep.h: Add include guard.
12856         * ax.h: Rename include guard.
12857         * arm-linux-tdep.h: Add include guard.
12858         * arm-fbsd-tdep.h: Add include guard.
12859         * arch/xtensa.h: Rename include guard.
12860         * arch/tic6x.h: Add include guard.
12861         * arch/i386.h: Add include guard.
12862         * arch/arm.h: Rename include guard.
12863         * arch/arm-linux.h: Rename include guard.
12864         * arch/arm-get-next-pcs.h: Rename include guard.
12865         * arch/amd64.h: Add include guard.
12866         * arch/aarch64-insn.h: Rename include guard.
12867         * arch-utils.h: Rename include guard.
12868         * annotate.h: Add include guard.
12869         * amd64-darwin-tdep.h: Rename include guard.
12870         * aarch64-linux-tdep.h: Add include guard.
12871         * aarch64-fbsd-tdep.h: Add include guard.
12872         * aarch32-linux-nat.h: Add include guard.
12873
12874 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12875
12876         * macrotab.c (macro_define_internal): New function that
12877         factorizes macro_define_object_internal and macro_define_function
12878         code.
12879         (macro_define_object_internal): Use macro_define_internal.
12880         (macro_define_function): Likewise.
12881
12882 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12883
12884         * macrocmd.c (extract_identifier): Return
12885         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12886         callers.
12887
12888 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12889
12890         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12891
12892 2019-02-05  Tom Tromey  <tom@tromey.com>
12893
12894         * target.c (target_stack::unpush): Move assertion earlier.
12895
12896 2019-01-30  Tom Tromey  <tom@tromey.com>
12897
12898         PR python/23615:
12899         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12900         (gdbpy_parse_and_eval): Likewise.
12901         * python/python-internal.h (gdbpy_allow_threads): New class.
12902
12903 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12904
12905         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12906         (aarch64_fbsd_fpregmap): Move earlier.
12907         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12908         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12909         instead of individual calls to trad_frame_set_reg_addr.
12910         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12911         earlier.
12912         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12913         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12914         instead of individual calls to trad_frame_set_reg_addr.
12915
12916 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12917
12918         * CONTRIBUTE: Replace contribution list with wiki link.
12919
12920 2019-01-25  Tom Tromey  <tom@tromey.com>
12921
12922         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12923
12924 2019-01-25  Tom Tromey  <tom@tromey.com>
12925
12926         * xtensa-linux-nat.c: Fix common/ includes.
12927         * xml-support.h: Fix common/ includes.
12928         * xml-support.c: Fix common/ includes.
12929         * x86-linux-nat.c: Fix common/ includes.
12930         * windows-nat.c: Fix common/ includes.
12931         * varobj.h: Fix common/ includes.
12932         * varobj.c: Fix common/ includes.
12933         * value.c: Fix common/ includes.
12934         * valops.c: Fix common/ includes.
12935         * utils.c: Fix common/ includes.
12936         * unittests/xml-utils-selftests.c: Fix common/ includes.
12937         * unittests/utils-selftests.c: Fix common/ includes.
12938         * unittests/unpack-selftests.c: Fix common/ includes.
12939         * unittests/tracepoint-selftests.c: Fix common/ includes.
12940         * unittests/style-selftests.c: Fix common/ includes.
12941         * unittests/string_view-selftests.c: Fix common/ includes.
12942         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12943         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12944         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12945         * unittests/rsp-low-selftests.c: Fix common/ includes.
12946         * unittests/parse-connection-spec-selftests.c: Fix common/
12947         includes.
12948         * unittests/optional-selftests.c: Fix common/ includes.
12949         * unittests/offset-type-selftests.c: Fix common/ includes.
12950         * unittests/observable-selftests.c: Fix common/ includes.
12951         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12952         * unittests/memrange-selftests.c: Fix common/ includes.
12953         * unittests/memory-map-selftests.c: Fix common/ includes.
12954         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12955         * unittests/function-view-selftests.c: Fix common/ includes.
12956         * unittests/environ-selftests.c: Fix common/ includes.
12957         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12958         * unittests/common-utils-selftests.c: Fix common/ includes.
12959         * unittests/cli-utils-selftests.c: Fix common/ includes.
12960         * unittests/array-view-selftests.c: Fix common/ includes.
12961         * ui-file.c: Fix common/ includes.
12962         * tui/tui-io.c: Fix common/ includes.
12963         * tracepoint.h: Fix common/ includes.
12964         * tracepoint.c: Fix common/ includes.
12965         * tracefile-tfile.c: Fix common/ includes.
12966         * top.h: Fix common/ includes.
12967         * top.c: Fix common/ includes.
12968         * thread.c: Fix common/ includes.
12969         * target/waitstatus.h: Fix common/ includes.
12970         * target/waitstatus.c: Fix common/ includes.
12971         * target.h: Fix common/ includes.
12972         * target.c: Fix common/ includes.
12973         * target-memory.c: Fix common/ includes.
12974         * target-descriptions.c: Fix common/ includes.
12975         * symtab.h: Fix common/ includes.
12976         * symfile.c: Fix common/ includes.
12977         * stap-probe.c: Fix common/ includes.
12978         * spu-linux-nat.c: Fix common/ includes.
12979         * sparc-nat.c: Fix common/ includes.
12980         * source.c: Fix common/ includes.
12981         * solib.c: Fix common/ includes.
12982         * solib-target.c: Fix common/ includes.
12983         * ser-unix.c: Fix common/ includes.
12984         * ser-tcp.c: Fix common/ includes.
12985         * ser-pipe.c: Fix common/ includes.
12986         * ser-base.c: Fix common/ includes.
12987         * selftest-arch.c: Fix common/ includes.
12988         * s12z-tdep.c: Fix common/ includes.
12989         * rust-exp.y: Fix common/ includes.
12990         * rs6000-aix-tdep.c: Fix common/ includes.
12991         * riscv-tdep.c: Fix common/ includes.
12992         * remote.c: Fix common/ includes.
12993         * remote-notif.h: Fix common/ includes.
12994         * remote-fileio.h: Fix common/ includes.
12995         * remote-fileio.c: Fix common/ includes.
12996         * regcache.h: Fix common/ includes.
12997         * regcache.c: Fix common/ includes.
12998         * record-btrace.c: Fix common/ includes.
12999         * python/python.c: Fix common/ includes.
13000         * python/py-type.c: Fix common/ includes.
13001         * python/py-inferior.c: Fix common/ includes.
13002         * progspace.h: Fix common/ includes.
13003         * producer.c: Fix common/ includes.
13004         * procfs.c: Fix common/ includes.
13005         * proc-api.c: Fix common/ includes.
13006         * printcmd.c: Fix common/ includes.
13007         * ppc-linux-nat.c: Fix common/ includes.
13008         * parser-defs.h: Fix common/ includes.
13009         * osdata.c: Fix common/ includes.
13010         * obsd-nat.c: Fix common/ includes.
13011         * nat/x86-linux.c: Fix common/ includes.
13012         * nat/x86-linux-dregs.c: Fix common/ includes.
13013         * nat/x86-dregs.h: Fix common/ includes.
13014         * nat/x86-dregs.c: Fix common/ includes.
13015         * nat/ppc-linux.c: Fix common/ includes.
13016         * nat/mips-linux-watch.h: Fix common/ includes.
13017         * nat/mips-linux-watch.c: Fix common/ includes.
13018         * nat/linux-waitpid.c: Fix common/ includes.
13019         * nat/linux-ptrace.h: Fix common/ includes.
13020         * nat/linux-ptrace.c: Fix common/ includes.
13021         * nat/linux-procfs.c: Fix common/ includes.
13022         * nat/linux-personality.c: Fix common/ includes.
13023         * nat/linux-osdata.c: Fix common/ includes.
13024         * nat/linux-namespaces.c: Fix common/ includes.
13025         * nat/linux-btrace.h: Fix common/ includes.
13026         * nat/linux-btrace.c: Fix common/ includes.
13027         * nat/fork-inferior.c: Fix common/ includes.
13028         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13029         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13030         * nat/aarch64-linux.c: Fix common/ includes.
13031         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13032         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13033         * namespace.h: Fix common/ includes.
13034         * mips-linux-tdep.c: Fix common/ includes.
13035         * minsyms.c: Fix common/ includes.
13036         * mi/mi-parse.h: Fix common/ includes.
13037         * mi/mi-main.c: Fix common/ includes.
13038         * mi/mi-cmd-env.c: Fix common/ includes.
13039         * memrange.h: Fix common/ includes.
13040         * memattr.c: Fix common/ includes.
13041         * maint.h: Fix common/ includes.
13042         * maint.c: Fix common/ includes.
13043         * main.c: Fix common/ includes.
13044         * machoread.c: Fix common/ includes.
13045         * location.c: Fix common/ includes.
13046         * linux-thread-db.c: Fix common/ includes.
13047         * linux-nat.c: Fix common/ includes.
13048         * linux-fork.c: Fix common/ includes.
13049         * inline-frame.c: Fix common/ includes.
13050         * infrun.c: Fix common/ includes.
13051         * inflow.c: Fix common/ includes.
13052         * inferior.h: Fix common/ includes.
13053         * inferior.c: Fix common/ includes.
13054         * infcmd.c: Fix common/ includes.
13055         * inf-ptrace.c: Fix common/ includes.
13056         * inf-child.c: Fix common/ includes.
13057         * ia64-linux-nat.c: Fix common/ includes.
13058         * i387-tdep.c: Fix common/ includes.
13059         * i386-tdep.c: Fix common/ includes.
13060         * i386-linux-tdep.c: Fix common/ includes.
13061         * i386-linux-nat.c: Fix common/ includes.
13062         * i386-go32-tdep.c: Fix common/ includes.
13063         * i386-fbsd-tdep.c: Fix common/ includes.
13064         * i386-fbsd-nat.c: Fix common/ includes.
13065         * guile/scm-type.c: Fix common/ includes.
13066         * guile/guile.c: Fix common/ includes.
13067         * go32-nat.c: Fix common/ includes.
13068         * gnu-nat.c: Fix common/ includes.
13069         * gdbthread.h: Fix common/ includes.
13070         * gdbarch-selftests.c: Fix common/ includes.
13071         * gdb_usleep.c: Fix common/ includes.
13072         * gdb_select.h: Fix common/ includes.
13073         * gdb_bfd.c: Fix common/ includes.
13074         * gcore.c: Fix common/ includes.
13075         * fork-child.c: Fix common/ includes.
13076         * findvar.c: Fix common/ includes.
13077         * fbsd-nat.c: Fix common/ includes.
13078         * event-top.c: Fix common/ includes.
13079         * event-loop.c: Fix common/ includes.
13080         * dwarf2read.c: Fix common/ includes.
13081         * dwarf2loc.c: Fix common/ includes.
13082         * dwarf2-frame.c: Fix common/ includes.
13083         * dwarf-index-cache.c: Fix common/ includes.
13084         * dtrace-probe.c: Fix common/ includes.
13085         * disasm-selftests.c: Fix common/ includes.
13086         * defs.h: Fix common/ includes.
13087         * csky-tdep.c: Fix common/ includes.
13088         * cp-valprint.c: Fix common/ includes.
13089         * cp-support.h: Fix common/ includes.
13090         * cp-support.c: Fix common/ includes.
13091         * corelow.c: Fix common/ includes.
13092         * completer.h: Fix common/ includes.
13093         * completer.c: Fix common/ includes.
13094         * compile/compile.c: Fix common/ includes.
13095         * compile/compile-loc2c.c: Fix common/ includes.
13096         * compile/compile-cplus-types.c: Fix common/ includes.
13097         * compile/compile-cplus-symbols.c: Fix common/ includes.
13098         * command.h: Fix common/ includes.
13099         * cli/cli-dump.c: Fix common/ includes.
13100         * cli/cli-cmds.c: Fix common/ includes.
13101         * charset.c: Fix common/ includes.
13102         * build-id.c: Fix common/ includes.
13103         * btrace.h: Fix common/ includes.
13104         * btrace.c: Fix common/ includes.
13105         * breakpoint.h: Fix common/ includes.
13106         * breakpoint.c: Fix common/ includes.
13107         * ax.h:
13108         (enum agent_op): Fix common/ includes.
13109         * ax-general.c (struct aop_map): Fix common/ includes.
13110         * ax-gdb.c: Fix common/ includes.
13111         * auxv.c: Fix common/ includes.
13112         * auto-load.c: Fix common/ includes.
13113         * arm-tdep.c: Fix common/ includes.
13114         * arch/riscv.c: Fix common/ includes.
13115         * arch/ppc-linux-common.c: Fix common/ includes.
13116         * arch/i386.c: Fix common/ includes.
13117         * arch/arm.c: Fix common/ includes.
13118         * arch/arm-linux.c: Fix common/ includes.
13119         * arch/arm-get-next-pcs.c: Fix common/ includes.
13120         * arch/amd64.c: Fix common/ includes.
13121         * arch/aarch64.c: Fix common/ includes.
13122         * arch/aarch64-insn.c: Fix common/ includes.
13123         * arch-utils.c: Fix common/ includes.
13124         * amd64-windows-tdep.c: Fix common/ includes.
13125         * amd64-tdep.c: Fix common/ includes.
13126         * amd64-sol2-tdep.c: Fix common/ includes.
13127         * amd64-obsd-tdep.c: Fix common/ includes.
13128         * amd64-nbsd-tdep.c: Fix common/ includes.
13129         * amd64-linux-tdep.c: Fix common/ includes.
13130         * amd64-linux-nat.c: Fix common/ includes.
13131         * amd64-fbsd-tdep.c: Fix common/ includes.
13132         * amd64-fbsd-nat.c: Fix common/ includes.
13133         * amd64-dicos-tdep.c: Fix common/ includes.
13134         * amd64-darwin-tdep.c: Fix common/ includes.
13135         * agent.c: Fix common/ includes.
13136         * ada-lang.h: Fix common/ includes.
13137         * ada-lang.c: Fix common/ includes.
13138         * aarch64-tdep.c: Fix common/ includes.
13139
13140 2019-01-25  Tom Tromey  <tom@tromey.com>
13141
13142         * common/create-version.sh: Use common/version.h.
13143
13144 2019-01-24  Pedro Alves  <palves@redhat.com>
13145
13146         * infrun.c (signal_stop, signal_print, signal_program)
13147         (signal_catch, signal_pass): Now arrays instead of pointers.
13148         (update_signals_program_target, do_target_resume)
13149         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13150         * linux-nat.c (linux_nat_target::pass_signals)
13151         (linux_nat_target::create_inferior, linux_nat_target::attach):
13152         Adjust.
13153         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13154         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13155         * procfs.c (procfs_target::pass_signals): Adjust.
13156         * record-full.c (record_full_target::resume): Adjust.
13157         * remote.c (remote_target::pass_signals)
13158         (remote_target::program_signals): Adjust.
13159         * target-debug.h (target_debug_print_signals): Now takes a
13160         gdb::array_view as parameter.  Adjust.
13161         * target.h (target_ops) <pass_signals, program_signals>: Replace
13162         pointer and length parameters with gdb::array_view.
13163         (target_pass_signals, target_program_signals): Likewise.
13164         * target-delegates.c: Regenerate.
13165
13166 2019-01-24  Pedro Alves  <palves@redhat.com>
13167
13168         * common/forward-scope-exit.h
13169         (forward_scope_exit::forward_scope_exit): Pass arguments to
13170         m_bind_function directly, instead of creating a std::bind and
13171         copying that.
13172
13173 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13174
13175         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13176         for static members.
13177         (pass_in_v_vfp_candidate): Likewise.
13178
13179 2019-01-23  Tom Tromey  <tom@tromey.com>
13180             Pedro Alves  <palves@redhat.com>
13181
13182         * regcache.c (class regcache_invalidator): Remove.
13183         (regcache::raw_write): Use make_scope_exit.
13184
13185 2019-01-23  Tom Tromey  <tom@tromey.com>
13186
13187         * ui-out.h (class ui_out_emit_type): Update comment.
13188
13189 2019-01-23  Tom Tromey  <tom@tromey.com>
13190
13191         * infrun.c (fetch_inferior_event): Update comment.
13192
13193 2019-01-23  Tom Tromey  <tom@tromey.com>
13194             Pedro Alves  <palves@redhat.com>
13195
13196         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13197         parameter.
13198         (fetch_inferior_event): Use SCOPE_EXIT.
13199
13200
13201 2019-01-23  Tom Tromey  <tom@tromey.com>
13202             Pedro Alves  <palves@redhat.com>
13203
13204         * infrun.c (disable_thread_events): Delete.
13205         (stop_all_threads): Use SCOPE_EXIT.
13206
13207 2019-01-23  Tom Tromey  <tom@tromey.com>
13208             Pedro Alves  <palves@redhat.com>
13209
13210         * symfile.c: Include forward-scope-exit.h.
13211         (clear_symtab_users_cleanup): Replace forward declaration with
13212         a FORWARD_SCOPE_EXIT.
13213         (syms_from_objfile_1): Use the forward_scope_exit and
13214         gdb::optional instead of cleanup_function.
13215         (reread_symbols): Use the forward_scope_exit instead of
13216         cleanup_function.
13217         (clear_symtab_users_cleanup): Remove function.
13218
13219 2019-01-23  Tom Tromey  <tom@tromey.com>
13220             Pedro Alves  <palves@redhat.com>
13221
13222         * linux-nat.c: Include scope-exit.h.
13223         (cleanup_target_stop): Remove.
13224         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13225         SCOPE_EXIT.
13226
13227 2019-01-23  Tom Tromey  <tom@tromey.com>
13228             Pedro Alves  <palves@redhat.com>
13229
13230         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13231         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13232
13233 2019-01-23  Tom Tromey  <tom@tromey.com>
13234             Andrew Burgess  <andrew.burgess@embecosm.com>
13235             Pedro Alves  <palves@redhat.com>
13236
13237         * infrun.c (fetch_inferior_event): Use scope_exit.
13238         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13239         * top.c (execute_command): Use scope_exit.
13240         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13241         * utils.c (do_bpstat_clear_actions_cleanup)
13242         (make_bpstat_clear_actions_cleanup): Remove.
13243
13244 2019-01-23  Tom Tromey  <tom@tromey.com>
13245             Pedro Alves  <palves@redhat.com>
13246
13247         * infrun.c: Include "common/scope-exit.h"
13248         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13249         (wait_for_inferior): Use SCOPE_EXIT.
13250         (fetch_inferior_event): Use scope_exit.
13251
13252 2019-01-23  Tom Tromey  <tom@tromey.com>
13253             Pedro Alves  <palves@redhat.com>
13254
13255         * breakpoint.c (create_breakpoint): Remove cleanup.
13256
13257 2019-01-23  Tom Tromey  <tom@tromey.com>
13258             Andrew Burgess  <andrew.burgess@embecosm.com>
13259             Pedro Alves  <palves@redhat.com>
13260
13261 2019-01-23  Pedro Alves  <palves@redhat.com>
13262
13263         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13264
13265 2019-01-23  Pedro Alves  <palves@redhat.com>
13266             Andrew Burgess  <andrew.burgess@embecosm.com>
13267
13268         * gdbthread.h: Include "common/forward-scope-exit.h".
13269         (scoped_finish_thread_state): Redefine custom class in terms of
13270         forward_scope_exit.
13271
13272 2019-01-23  Pedro Alves  <palves@redhat.com>
13273             Andrew Burgess  <andrew.burgess@embecosm.com>
13274
13275         * common/forward-scope-exit.h: New file.
13276
13277 2019-01-23  Pedro Alves  <palves@redhat.com>
13278             Andrew Burgess  <andrew.burgess@embecosm.com>
13279             Tom Tromey  <tom@tromey.com>
13280
13281         * common/scope-exit.h: New file.
13282
13283 2019-01-23  Pedro Alves  <palves@redhat.com>
13284
13285         * common/preprocessor.h (ESC): Rename to ...
13286         (ESC_PARENS): ... this.
13287         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13288         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13289
13290 2019-01-23  Tom Tromey  <tom@tromey.com>
13291
13292         * language.h (class scoped_switch_to_sym_language_if_auto):
13293         Initialize m_lang in both cases.
13294
13295 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13296
13297         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13298         with XCNEW.
13299
13300 2019-01-22  Tom Tromey  <tom@tromey.com>
13301
13302         * corelow.c: Do not include sys/file.h.
13303
13304 2019-01-22  Tom Tromey  <tom@tromey.com>
13305
13306         * tui/tui-wingeneral.h: Include gdb_curses.h.
13307
13308 2019-01-22  Tom Tromey  <tom@tromey.com>
13309
13310         * source-cache.h (class source_cache) <get_source_lines,
13311         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13312
13313 2019-01-22  Tom Tromey  <tom@tromey.com>
13314
13315         * remote-fileio.h (struct remote_target): Declare.
13316
13317 2019-01-22  Tom Tromey  <tom@tromey.com>
13318
13319         * python/py-arch.c: Do not include py-ref.h.
13320         * python/py-bpevent.c: Do not include py-ref.h.
13321         * python/py-cmd.c: Do not include py-ref.h.
13322         * python/py-continueevent.c: Do not include py-ref.h.
13323         * python/py-event.h: Do not include py-ref.h.
13324         * python/py-evtregistry.c: Do not include py-ref.h.
13325         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13326         * python/py-frame.c: Do not include py-ref.h.
13327         * python/py-framefilter.c: Do not include py-ref.h.
13328         * python/py-function.c: Do not include py-ref.h.
13329         * python/py-infevents.c: Do not include py-ref.h.
13330         * python/py-linetable.c: Do not include py-ref.h.
13331         * python/py-objfile.c: Do not include py-ref.h.
13332         * python/py-param.c: Do not include py-ref.h.
13333         * python/py-prettyprint.c: Do not include py-ref.h.
13334         * python/py-progspace.c: Do not include py-ref.h.
13335         * python/py-symbol.c: Do not include py-ref.h.
13336         * python/py-symtab.c: Do not include py-ref.h.
13337         * python/py-type.c: Do not include py-ref.h.
13338         * python/py-unwind.c: Do not include py-ref.h.
13339         * python/py-utils.c: Do not include py-ref.h.
13340         * python/py-value.c: Do not include py-ref.h.
13341         * python/py-varobj.c: Do not include py-ref.h.
13342         * python/py-xmethods.c: Do not include py-ref.h.
13343         * python/python.c: Do not include py-ref.h.
13344         * varobj.c: Do not include py-ref.h.
13345
13346 2019-01-22  Tom Tromey  <tom@tromey.com>
13347
13348         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13349         keyword for bcache.
13350
13351 2019-01-22  Tom Tromey  <tom@tromey.com>
13352
13353         * compile/compile-cplus-types.c: Remove a comment by #include.
13354
13355 2019-01-22  Tom Tromey  <tom@tromey.com>
13356
13357         * compile/gcc-c-plugin.h: Include compile-internal.h.
13358
13359 2019-01-22  Tom Tromey  <tom@tromey.com>
13360
13361         * stabsread.c (EXTERN): Do not define.
13362         (symnum, next_symbol_text_func, processing_gcc_compilation)
13363         (within_function, global_sym_chain, global_stabs)
13364         (previous_stab_code, this_object_header_files)
13365         (n_this_object_header_files)
13366         (n_allocated_this_object_header_files): Define.
13367         * stabsread.h (EXTERN): Never define.  Use "extern".
13368
13369 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13370
13371         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13372         history_value.
13373
13374 2019-01-21  Tom Tromey  <tom@tromey.com>
13375
13376         * ui-out.c: Fix includes.
13377         * tui/tui-source.c: Fix includes.
13378         * target.c: Fix includes.
13379         * remote.c: Fix includes.
13380         * regcache.c: Fix includes.
13381         * python/py-block.c: Fix includes.
13382         * printcmd.c: Fix includes.
13383         * or1k-tdep.c: Fix includes.
13384         * mi/mi-main.c: Fix includes.
13385         * m32r-tdep.c: Fix includes.
13386         * csky-tdep.c: Fix includes.
13387         * compile/compile-cplus-types.c: Fix includes.
13388         * cli/cli-interp.c: Fix includes.
13389
13390 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13391
13392         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13393         for padding.
13394
13395 2019-01-16  Tom Tromey  <tom@tromey.com>
13396
13397         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13398         earlier.
13399         (struct objfile) <msymbols_range>: Move from top level.
13400         <msymbols>: New method.
13401         (class objfile_msymbols): Remove.
13402         * symtab.c (default_collect_symbol_completion_matches_break_on):
13403         Update.
13404         * symmisc.c (dump_msymbols): Update.
13405         * stabsread.c (scan_file_globals): Update.
13406         * objc-lang.c (info_selectors_command, info_classes_command)
13407         (find_methods): Update.
13408         * minsyms.c (find_solib_trampoline_target): Update.
13409         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13410         * coffread.c (coff_symfile_read): Update.
13411         * ada-lang.c (ada_lookup_simple_minsym)
13412         (ada_collect_symbol_completion_matches): Update.
13413
13414 2019-01-16  Tom Tromey  <tom@tromey.com>
13415
13416         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13417         type.  Remove no-argument constructor.
13418         <iterator::operator++>: Simplify.
13419         <begin>: Update.
13420         <end>: Use minimal_symbol_count.
13421
13422 2019-01-16  Tom Tromey  <tom@tromey.com>
13423
13424         * objfiles.h (struct objfile) <psymtabs>: New method.
13425         (class objfile_psymtabs): Remove.
13426         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13427         typedef.
13428         <range>: New method.
13429         (require_partial_symbols): Change return type.
13430         * psymtab.c (require_partial_symbols)
13431         (psym_expand_symtabs_matching): Update.
13432         * mdebugread.c (parse_partial_symbols): Update.
13433         * dbxread.c (dbx_end_psymtab): Update.
13434
13435 2019-01-15  Tom Tromey  <tom@tromey.com>
13436
13437         * symtab.c (lookup_objfile_from_block)
13438         (lookup_symbol_in_objfile_symtabs)
13439         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13440         (find_line_symtab, info_sources_command)
13441         (default_collect_symbol_completion_matches_break_on)
13442         (make_source_files_completion_list): Update.
13443         * symmisc.c (print_objfile_statistics, dump_objfile)
13444         (maintenance_print_symbols, maintenance_info_symtabs)
13445         (maintenance_check_symtabs, maintenance_info_line_tables):
13446         Update.
13447         * source.c (select_source_symtab)
13448         (forget_cached_source_info_for_objfile): Update.
13449         * objfiles.h (class objfile_compunits): Remove.
13450         (struct objfile) <compunits_range>: New typedef.
13451         (compunits): New method.
13452         * objfiles.c (objfile_relocate1): Update.
13453         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13454         * maint.c (count_symtabs_and_blocks): Update.
13455         * linespec.c (iterate_over_all_matching_symtabs): Update.
13456         * cp-support.c (add_symbol_overload_list_qualified): Update.
13457         * coffread.c (coff_symtab_read): Update.
13458         * ada-lang.c (add_nonlocal_symbols)
13459         (ada_collect_symbol_completion_matches)
13460         (ada_add_global_exceptions): Update.
13461
13462 2019-01-15  Tom Tromey  <tom@tromey.com>
13463
13464         * progspace.h (program_space) <objfiles_safe_range>: New
13465         typedef.
13466         <objfiles_safe>: New method.
13467         * objfiles.h (class all_objfiles_safe): Remove.
13468         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13469         * jit.c (jit_inferior_exit_hook): Update.
13470
13471 2019-01-17  Tom Tromey  <tom@tromey.com>
13472
13473         * progspace.h (program_space) <objfiles_range>: New typedef.
13474         <objfiles>: New method.
13475         <objfiles_head>: Rename from objfiles.
13476         (object_files): Update.
13477         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13478         * guile/scm-pretty-print.c
13479         (ppscm_find_pretty_printer_from_objfiles): Update.
13480         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13481         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13482         Update.
13483         * python/py-progspace.c (pspy_get_objfiles): Update.
13484         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13485         Update.
13486         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13487         (objfpy_lookup_objfile_by_build_id): Update.
13488         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13489         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13490         Update.
13491         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13492         (expand_symtab_containing_pc, lookup_objfile_from_block)
13493         (lookup_static_symbol, basic_lookup_transparent_type)
13494         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13495         (find_line_symtab, info_sources_command)
13496         (default_collect_symbol_completion_matches_break_on)
13497         (make_source_files_completion_list, find_main_name): Update.
13498         * symmisc.c (print_symbol_bcache_statistics)
13499         (print_objfile_statistics, maintenance_print_symbols)
13500         (maintenance_print_msymbols, maintenance_print_objfiles)
13501         (maintenance_info_symtabs, maintenance_check_symtabs)
13502         (maintenance_expand_symtabs, maintenance_info_line_tables):
13503         Update.
13504         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13505         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13506         (map_overlay_command, unmap_overlay_command)
13507         (simple_overlay_update, expand_symtabs_matching)
13508         (map_symbol_filenames): Update.
13509         * symfile-debug.c (set_debug_symfile): Update.
13510         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13511         Update.
13512         * source.c (select_source_symtab, forget_cached_source_info):
13513         Update.
13514         * solib.c (solib_read_symbols): Update.
13515         * solib-spu.c (append_ocl_sos): Update.
13516         * psymtab.c (maintenance_print_psymbols)
13517         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13518         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13519         * printcmd.c (info_symbol_command): Update.
13520         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13521         Update.
13522         * objfiles.h (class all_objfiles): Remove.
13523         * objfiles.c (have_partial_symbols, have_full_symbols)
13524         (have_minimal_symbols, qsort_cmp, update_section_map)
13525         (shared_objfile_contains_address_p)
13526         (default_iterate_over_objfiles_in_search_order): Update.
13527         * objc-lang.c (info_selectors_command, info_classes_command)
13528         (find_methods): Update.
13529         * minsyms.c (find_solib_trampoline_target): Update.
13530         * maint.c (maintenance_info_sections)
13531         (maintenance_translate_address, count_symtabs_and_blocks):
13532         Update.
13533         * main.c (captured_main_1): Update.
13534         * linux-thread-db.c (try_thread_db_load_from_pdir)
13535         (has_libpthread): Update.
13536         * linespec.c (iterate_over_all_matching_symtabs)
13537         (search_minsyms_for_name): Update.
13538         * jit.c (jit_find_objf_with_entry_addr): Update.
13539         * hppa-tdep.c (find_unwind_entry)
13540         (hppa_lookup_stub_minimal_symbol): Update.
13541         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13542         Update.
13543         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13544         (elf_gnu_ifunc_resolve_by_got): Update.
13545         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13546         * dwarf-index-write.c (save_gdb_index_command): Update.
13547         * cp-support.c (add_symbol_overload_list_qualified): Update.
13548         * breakpoint.c (create_overlay_event_breakpoint)
13549         (create_longjmp_master_breakpoint)
13550         (create_std_terminate_master_breakpoint)
13551         (create_exception_master_breakpoint): Update.
13552         * blockframe.c (find_pc_partial_function): Update.
13553         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13554         (ada_collect_symbol_completion_matches)
13555         (ada_add_global_exceptions): Update.
13556
13557 2019-01-17  Tom Tromey  <tom@tromey.com>
13558
13559         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13560         declare VEC.
13561         (solib_target_parse_libraries): Change return type.
13562         (library_list_start_segment, library_list_start_section)
13563         (library_list_end_library, library_list_start_library); Update.
13564         (solib_target_free_library_list): Remove.
13565         (solib_target_parse_libraries): Remove cleanup.  Change return
13566         type.
13567         (solib_target_current_sos): Update.
13568
13569 2019-01-17  Tom Tromey  <tromey@bapiya>
13570
13571         * valprint.c: Replace "the the" with "the".
13572         * symtab.c: Replace "the the" with "the".
13573         * solib.c: Replace "the the" with "the".
13574         * solib-dsbt.c: Replace "the the" with "the".
13575         * linespec.c: Replace "the the" with "the".
13576         * dwarf2loc.h: Replace "the the" with "the".
13577         * amd64-windows-tdep.c: Replace "the the" with "the".
13578         * aarch64-tdep.c: Replace "the the" with "the".
13579
13580 2019-01-16  Keith Seitz  <keiths@redhat.com>
13581
13582         PR gdb/23773
13583         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13584         <builder>: Rename to ..
13585         <m_builder>: ... this and make private.
13586         (dwarf2_cu::get_builder): New method.  Change all users of
13587         `builder' to use this method.
13588         (dwarf2_start_symtab): Move to ...
13589         (dwarf2_cu::start_symtab): ... here.  Update all callers
13590         (setup_type_unit_groups): Move to ...
13591         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13592         callers.
13593         (dwarf2_cu::reset_builder): New method.
13594         (process_full_compunit, process_full_type_unit): Use
13595         dwarf2_cu::reset_builder.
13596         (follow_die_offset): Record the ancestor CU if it is different
13597         from the followed DIE's CU.
13598         (follow_die_sig_1): Likewise.
13599
13600 2019-01-15  Tom Tromey  <tom@tromey.com>
13601
13602         * remote.c (class remote_state) <buf>: Now a char_vector.
13603         <buf_size>: Remove.
13604         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13605         parameter.
13606         (remote_target::getpkt_or_notif_sane_1)
13607         (remote_target::getpkt_sane)
13608         (remote_target::getpkt_or_notif_sane): Likewise.
13609         (class remote_target) <putpkt>: New overload.
13610         (remote_target::read_frame): Change type of "buf_p".  Remove
13611         sizeof_p parameter.
13612         (packet_ok): New overload.
13613         (packet_check_result): New overload.
13614         Update all uses.
13615
13616 2019-01-14  Tom Tromey  <tom@tromey.com>
13617
13618         * remote-notif.c (handle_notification, remote_notif_ack)
13619         (remote_notif_parse): Make "buf" const.
13620         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13621         const.
13622         (remote_notif_parse, remote_notif_ack, handle_notification):
13623         Likewise.
13624         * remote.c (remote_notif_stop_parse): Make "buf" const.
13625         (remote_target::remote_parse_stop_reply): Make "buf" const.
13626         (remote_notif_stop_ack): Make "buf" const.
13627
13628 2019-01-14  Tom Tromey  <tom@tromey.com>
13629
13630         * remote.c (remote_console_output): Make parameter const.
13631
13632 2019-01-14  Tom Tromey  <tom@tromey.com>
13633
13634         * target-debug.h (target_debug_print_signals): Constify.
13635         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13636         * procfs.c (procfs_target::pass_signals): Update.
13637         * linux-nat.c (linux_nat_target::pass_signals): Update.
13638         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13639         * target-delegates.c: Rebuild.
13640         * remote.c (remote_target::program_signals): Update.
13641         (remote_target::pass_signals): Update.
13642         * target.c (target_pass_signals): Constify argument.
13643         (target_program_signals): Likewise.
13644         * target.h (struct target_ops) <pass_signals, program_signals>:
13645         Constify argument.
13646         (target_pass_signals, target_program_signals): Constify argument.
13647
13648 2019-01-14  Tom Tromey  <tom@tromey.com>
13649
13650         PR tui/28819:
13651         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13652
13653 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13654
13655         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13656         field.
13657         * rs6000-tdep.c: Include reggroups.h.
13658         (IS_V_ALIAS_PSEUDOREG): Define.
13659         (rs6000_register_name): Return names for the "vX" aliases.
13660         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13661         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13662         aliases.  Call default_register_reggroup_p for all other
13663         pseudo-registers.
13664         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13665         New functions.
13666         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13667         Handle "vX" aliases.
13668         (v_alias_pseudo_register_collect): New function.
13669         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13670         (rs6000_gdbarch_init): Initialize "vX" aliases as
13671         pseudo-registers.  Restore registration of
13672         rs6000_pseudo_register_reggroup_p with
13673         set_tdesc_pseudo_register_reggroup_p.
13674
13675 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13676
13677         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13678         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13679         set_gdbarch_num_pseudo_regs.
13680
13681 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13682
13683         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13684         Remove arg prefixname, add do_set and do_show.
13685         Add member functions set_list and show_list.
13686         * cli/cli-style.c (class cli_style_option): Update accordingly.
13687         (style_set_list): Move to file scope.
13688         (style_show_list): Likewise.
13689         (set_style): Call help_list.
13690         (show_style): Call cmd_show_list.
13691         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13692         Update to use the new macro.
13693
13694 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13695
13696         * ada-lang.c (_initialize_ada_language): Expand the help text
13697         for the "catch exception" command.
13698
13699 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13700
13701         * symtab.c (matching_obj_sections): Initialize obj,
13702         declare it closer to its usage.
13703
13704 2019-01-10  Tom Tromey  <tom@tromey.com>
13705
13706         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13707         (basic_inf_threads_range): Remove.
13708         (inf_threads_range, inf_non_exited_threads_range)
13709         (safe_inf_threads_range): Use next_adapter.
13710
13711 2019-01-10  Keith Seitz  <keiths@redhat.com>
13712
13713         PR gdb/23712
13714         PR symtab/23010
13715         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13716         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13717
13718 2019-01-10  Keith Seitz  <keiths@redhat.com>
13719
13720         PR gdb/23712
13721         PR symtab/23010
13722         * dictionary.c (pending_to_vector): Remove.
13723         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13724         Remove _1 suffix, replacing functions of the same name.  Update
13725         all callers.
13726         (dict_create_hashed, dict_create_hashed_expandable)
13727         (dict_create_linear, dict_create_linear_expandable, dict_free)
13728         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13729         Make functions static.
13730
13731 2019-01-10  Keith Seitz  <keiths@redhat.com>
13732
13733         PR gdb/23712
13734         PR symtab/23010
13735         * dictionary.h (struct dictionary): Replace declaration with
13736         multidictionary.
13737         (dict_create_hashed, dict_create_hashed_expandable)
13738         (dict_create_linear, dict_create_linear_expandable)
13739         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13740         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13741         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13742         taking multidictionary argument.
13743         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13744         * block.h (struct block) <dict>: Change to multidictionary
13745         and rename `multidict'.
13746         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13747         symmisc.c: Update all dictionary references to multidictionary.
13748
13749 2019-01-10  Keith Seitz  <keiths@redhat.com>
13750
13751         PR gdb/23712
13752         PR symtab/23010
13753         * dictionary.c: Include unordered_map.
13754         (pending_to_vector): New function.
13755         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13756         Rewrite the non-"_1" functions to take vector instead
13757         of linked list.
13758         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13759         "new" _1 versions of the same name.
13760         (multidictionary): Define.
13761         (std::hash<enum language): New definition.
13762         (collate_pending_symbols_by_language, mdict_create_hashed)
13763         (mdict_create_hashed_expandable, mdict_create_linear)
13764         (mdict_create_linear_expandable, mdict_free)
13765         (find_language_dictionary, create_new_language_dictionary)
13766         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13767         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13768         (mdict_size, mdict_empty): New functions.
13769         * dictionary.h (mdict_iterator): Define.
13770
13771 2019-01-10  Pedro Alves  <palves@redhat.com>
13772
13773         * breakpoint.c (read_uploaded_action)
13774         (create_tracepoint_from_upload): Adjust to use
13775         gdb::unique_xmalloc_ptr.
13776         * ctf.c (ctf_write_uploaded_tp):
13777         (SET_ARRAY_FIELD): Use emplace_back.
13778         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13779         * tracefile-tfile.c (tfile_write_uploaded_tp):
13780         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13781         gdb::unique_xmalloc_ptr.
13782         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13783         at_string, cond_string, cmd_strings>: Replace char pointers
13784         with gdb::unique_xmalloc_ptr.
13785
13786 2019-01-10  Pedro Alves  <palves@redhat.com>
13787
13788         * solib-target.c (library_list_start_library): Don't xstrdup name.
13789
13790 2019-01-10  Pedro Alves  <palves@redhat.com>
13791
13792         * mdebugread.c (parse_partial_symbols): Use
13793         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13794
13795 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13796
13797         * linux-fork.c (scoped_switch_fork_info)
13798         <~scoped_switch_fork_info>: Fix incorrect variable name.
13799
13800 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13801
13802         * linux-fork.c (scoped_switch_fork_info)
13803         <scoped_switch_fork_info>: Make explicit.
13804         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13805
13806 2019-01-10  Tom Tromey  <tom@tromey.com>
13807
13808         * objfiles.h (objfile::reset_psymtabs): Update.
13809         * objfiles.c (objfile::objfile): Update.
13810         * psymtab.h (psymtab_storage::obstack): Update.
13811         (psymtab_storage::m_obstack): Use gdb::optional.
13812         (class psymtab_storage): Update comment.  Remove objfile
13813         parameter.
13814         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13815
13816 2019-01-10  Tom Tromey  <tom@tromey.com>
13817
13818         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13819         <free_psymtabs>: Now private.
13820         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13821         (allocate_psymtab): Use new method.
13822
13823 2019-01-10  Tom Tromey  <tom@tromey.com>
13824
13825         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13826         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13827         * mdebugread.c (parse_partial_symbols): Use
13828         allocate_dependencies.
13829         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13830         allocate_dependencies.
13831         (process_psymtab_comp_unit_reader)
13832         (build_type_psymtab_dependencies): Likewise.
13833         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13834
13835 2019-01-10  Tom Tromey  <tom@tromey.com>
13836
13837         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13838         PSYMBOL_SET_LANGUAGE.
13839         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13840
13841 2019-01-10  Tom Tromey  <tom@tromey.com>
13842
13843         * psymtab.h (psymtab_storage::obstack): New method.
13844         <m_obstack>: Rename from obstack; now private.
13845         * psymtab.c (psymtab_storage): Update.
13846         * dwarf2read.c (create_addrmap_from_index)
13847         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13848         Update.
13849
13850 2019-01-10  Tom Tromey  <tom@tromey.com>
13851
13852         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13853         * objfiles.h (objfile::reset_psymtabs): New method.
13854
13855 2019-01-10  Tom Tromey  <tom@tromey.com>
13856
13857         * symmisc.c (print_symbol_bcache_statistics): Update.
13858         (print_objfile_statistics): Update.
13859         * symfile.c (reread_symbols): Update.
13860         * psymtab.h (class psymtab_storage): New.
13861         * psymtab.c (psymtab_storage): New constructor.
13862         (~psymtab_storage): New destructor.
13863         (require_partial_symbols): Update.
13864         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13865         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13866         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13867         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13868         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13869         (start_psymtab_common, end_psymtab_common)
13870         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13871         (allocate_psymtab): Update.
13872         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13873         Update.
13874         (dump_psymtab_addrmap, maintenance_print_psymbols)
13875         (maintenance_check_psymtabs): Update.
13876         (class objfile_psymtabs): Move to objfiles.h.
13877         * psympriv.h (discard_psymtab): Now inline.
13878         (psymtab_discarder::psymtab_discarder): Update.
13879         (psymtab_discarder::~psymtab_discarder): Update.
13880         (ALL_OBJFILE_PSYMTABS): Rewrite.
13881         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13882         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13883         Remove fields.
13884         <partial_symtabs>: New field.
13885         (class objfile_psymtabs): Move from psymtab.h.  Update.
13886         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13887         psymbol_cache.
13888         (objfile::~objfile): Don't destroy psymbol_cache.
13889         * mdebugread.c (parse_partial_symbols): Update.
13890         * dwarf2read.c (create_addrmap_from_index)
13891         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13892         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13893         (add_partial_subprogram, dwarf2_ranges_read): Update.
13894         * dwarf-index-write.c (write_address_map)
13895         (write_one_signatured_type, recursively_write_psymbols)
13896         (class debug_names, class debug_names, write_psymtabs_to_index):
13897         Update.
13898
13899 2019-01-10  Tom Tromey  <tom@tromey.com>
13900
13901         * symtab.h (SYMBOL_SET_NAMES): Update.
13902         (symbol_set_names): Update.
13903         (MSYMBOL_SET_NAMES): Update.
13904         * symtab.c (symbol_set_names): Change argument to be an
13905         objfile_per_bfd_storage.
13906         * psymtab.c (add_psymbol_to_bcache): Update.
13907         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13908
13909 2019-01-10  Tom Tromey  <tom@tromey.com>
13910
13911         * symtab.c (create_demangled_names_hash): Change argument to be an
13912         objfile_per_bfd_storage.
13913         (symbol_set_names): Update.
13914
13915 2019-01-10  Tom Tromey  <tom@tromey.com>
13916
13917         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13918         init_psymbol_list.
13919         * psymtab.c (init_psymbol_list): Do nothing if already called.
13920         * psympriv.h (init_psymbol_list): Add comment.
13921         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13922         init_psymbol_list.
13923         * dbxread.c (dbx_symfile_read): Unconditionally call
13924         init_psymbol_list.
13925
13926 2019-01-10  Tom Tromey  <tom@tromey.com>
13927
13928         * xcoffread.c (scan_xcoff_symtab): Update.
13929         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13930         "where".
13931         * mdebugread.c (parse_partial_symbols)
13932         (handle_psymbol_enumerators): Update.
13933         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13934         * dbxread.c (read_dbx_symtab): Update.
13935         * psympriv.h (psymbol_placement): New enum.
13936         (add_psymbol_to_list): Update.
13937
13938 2019-01-10  Tom Tromey  <tom@tromey.com>
13939
13940         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13941         static_psymbols parameters.
13942         (scan_xcoff_symtab): Update.
13943         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13944         static_psymbols parameters.
13945         * psympriv.h (start_psymtab_common): Update.
13946         * mdebugread.c (parse_partial_symbols): Update.
13947         * dwarf2read.c (create_partial_symtab): Update.
13948         * dbxread.c (read_dbx_symtab): Update.
13949         (start_psymtab): Remove global_psymbols and static_psymbols
13950         parameters.
13951
13952 2019-01-10  Tom Tromey  <tom@tromey.com>
13953
13954         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13955         * psymtab.c (allocate_psymtab): Add comment.
13956         * psympriv.h (allocate_psymtab): Add comment.
13957         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13958         initializations.
13959         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13960
13961 2019-01-10  Tom Tromey  <tom@tromey.com>
13962
13963         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13964         Don't declare.
13965         * mipsread.c: Include mdebugread.h.
13966         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13967         Declare.
13968         * elfread.c: Include mdebugread.h.
13969
13970 2019-01-09  Tom Tromey  <tom@tromey.com>
13971
13972         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13973         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13974         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13975         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13976         (psym_lookup_symbol, psym_find_last_source_symtab)
13977         (psym_forget_cached_source_info, psym_print_stats)
13978         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13979         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13980         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13981         (psym_find_compunit_symtab_by_address)
13982         (maintenance_print_psymbols, maintenance_info_psymtabs)
13983         (maintenance_check_psymtabs): Use ranged for.
13984         * psymtab.h (class objfile_psymtabs): New.
13985         (require_partial_symbols): Return objfile_psymtabs.
13986         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13987
13988 2019-01-09  Tom Tromey  <tom@tromey.com>
13989
13990         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13991         (find_pc_mapped_section, list_overlays_command)
13992         (map_overlay_command, unmap_overlay_command)
13993         (simple_overlay_update): Use all_objfiles.
13994         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13995         * printcmd.c (info_symbol_command): Use all_objfiles.
13996         * objfiles.h (ALL_OBJSECTIONS): Remove.
13997         * maint.c (maintenance_translate_address): Use all_objfiles.
13998         * gcore.c (gcore_create_callback): Use all_objfiles.
13999         (objfile_find_memory_regions): Likewise.
14000
14001 2019-01-09  Tom Tromey  <tom@tromey.com>
14002
14003         * symtab.c (find_line_symtab, info_sources_command)
14004         (make_source_files_completion_list): Use objfile_compunits.
14005         * source.c (select_source_symtab): Use objfile_compunits.
14006         * objfiles.h (struct objfile): Update comment.
14007         (ALL_OBJFILES): Remove.
14008         (ALL_FILETABS): Remove.
14009         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14010         objfile_compunits.
14011
14012 2019-01-09  Tom Tromey  <tom@tromey.com>
14013
14014         * symmisc.c (print_objfile_statistics, dump_objfile)
14015         (maintenance_print_symbols): Use compunit_filetabs.
14016         * source.c (forget_cached_source_info_for_objfile): Use
14017         compunit_filetabs.
14018         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14019         (ALL_FILETABS): Use compunit_filetabs.
14020         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14021         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14022
14023 2019-01-09  Tom Tromey  <tom@tromey.com>
14024
14025         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14026         (compunit_filetabs): New.
14027         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14028         compunit_filetabs.
14029         (info_sources_command, make_source_files_completion_list): Remove
14030         declaration.
14031         * symmisc.c (print_objfile_statistics, dump_objfile)
14032         (maintenance_print_symbols): Remove declaration.
14033         (maintenance_info_symtabs): Use compunit_filetabs.
14034         (maintenance_info_line_tables): Likewise.
14035         * source.c (select_source_symtab): Change local variable name.
14036         (forget_cached_source_info_for_objfile): Remove declaration.
14037         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14038         * objfiles.c (objfile_relocate1): Remove declaration.
14039         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14040         declaration.
14041         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14042         * coffread.c (coff_symtab_read): Remove declaration.
14043         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14044         compunit_filetabs.
14045
14046 2019-01-09  Tom Tromey  <tom@tromey.com>
14047
14048         * symtab.c (lookup_objfile_from_block)
14049         (find_pc_sect_compunit_symtab, search_symbols)
14050         (default_collect_symbol_completion_matches_break_on): Use
14051         objfile_compunits.
14052         * objfiles.h (ALL_COMPUNITS): Remove.
14053         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14054         * cp-support.c (add_symbol_overload_list_qualified): Use
14055         objfile_compunits.
14056         * ada-lang.c (ada_collect_symbol_completion_matches)
14057         (ada_add_global_exceptions): Use objfile_compunits.
14058
14059 2019-01-09  Tom Tromey  <tom@tromey.com>
14060
14061         * source.c (select_source_symtab)
14062         (forget_cached_source_info_for_objfile): Remove declaration.
14063         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14064         declaration.
14065         * maint.c (count_symtabs_and_blocks): Remove declaration.
14066         * cp-support.c (add_symbol_overload_list_qualified): Remove
14067         declaration.
14068         * coffread.c (coff_symtab_read): Remove declaration.
14069         * symtab.c (lookup_symbol_in_objfile_symtabs)
14070         (basic_lookup_transparent_type_1): Use objfile_compunits.
14071         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14072         (info_sources_command, search_symbols)
14073         (default_collect_symbol_completion_matches_break_on)
14074         (make_source_files_completion_list): Remove declaration.
14075         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14076         (ada_collect_symbol_completion_matches)
14077         (ada_add_global_exceptions): Remove declaration.
14078         * linespec.c (iterate_over_all_matching_symtabs): Use
14079         objfile_compunits.
14080         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14081         (class objfile_compunits): New.
14082         (ALL_COMPUNITS): Use objfile_compunits.
14083         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14084         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14085         objfile_compunits.
14086         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14087
14088 2019-01-09  Tom Tromey  <tom@tromey.com>
14089
14090         * symtab.c (search_symbols)
14091         (default_collect_symbol_completion_matches_break_on): Use
14092         objfile_msymbols.
14093         * ada-lang.c (ada_lookup_simple_minsym)
14094         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14095         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14096         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14097         objfile_msymbols.
14098         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14099         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14100         * objc-lang.c (find_methods): Use objfile_msymbols.
14101         (info_selectors_command, info_classes_command): Likewise.
14102         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14103         * objfiles.h (class objfile_msymbols): New.
14104         (ALL_OBJFILE_MSYMBOLS): Remove.
14105         (ALL_MSYMBOLS): Remove.
14106
14107 2019-01-09  Tom Tromey  <tom@tromey.com>
14108
14109         * common/next-iterator.h (next_adapter): Add Iterator template
14110         parameter.
14111         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14112         (class all_objfiles_safe): New.
14113         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14114         * objfiles.c (put_objfile_before): Update comment.
14115         (add_separate_debug_objfile): Likewise.
14116         (free_all_objfiles): Use all_objfiles_safe.
14117         (objfile_purge_solibs): Likewise.
14118
14119 2019-01-09  Tom Tromey  <tom@tromey.com>
14120
14121         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14122         (expand_symtab_containing_pc, lookup_static_symbol)
14123         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14124         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14125         all_objfiles.
14126         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14127         * breakpoint.c (create_overlay_event_breakpoint)
14128         (create_longjmp_master_breakpoint)
14129         (create_std_terminate_master_breakpoint)
14130         (create_exception_master_breakpoint): Use all_objfiles.
14131         * linux-thread-db.c (try_thread_db_load_from_pdir)
14132         (has_libpthread): Use all_objfiles.
14133         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14134         * linespec.c (iterate_over_all_matching_symtabs)
14135         (search_minsyms_for_name): Use all_objfiles.
14136         * maint.c (maintenance_info_sections): Use all_objfiles.
14137         * main.c (captured_main_1): Use all_objfiles.
14138         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14139         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14140         * guile/scm-pretty-print.c
14141         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14142         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14143         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14144         (maintenance_print_msymbols): Use all_objfiles.
14145         * source.c (select_source_symtab): Use all_objfiles.
14146         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14147         * symfile.c (remove_symbol_file_command)
14148         (expand_symtabs_matching, map_symbol_filenames): Use
14149         all_objfiles.
14150         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14151         all_objfiles.
14152         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14153         * objc-lang.c (find_methods): Use all_objfiles.
14154         * objfiles.c (have_partial_symbols, have_full_symbols)
14155         (have_minimal_symbols, qsort_cmp)
14156         (default_iterate_over_objfiles_in_search_order): Use
14157         all_objfiles.
14158         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14159         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14160         (maintenance_check_psymtabs): Use all_objfiles.
14161         (ALL_PSYMTABS): Remove.
14162         * compile/compile-object-run.c (do_module_cleanup): Use
14163         all_objfiles.
14164         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14165         * cp-support.c (add_symbol_overload_list_qualified): Use
14166         all_objfiles.
14167         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14168         Use all_objfiles.
14169         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14170         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14171         all_objfiles.
14172         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14173         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14174         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14175         Uses all_objfiles.
14176         * solib.c (solib_read_symbols): Use all_objfiles
14177
14178 2019-01-09  Tom Tromey  <tom@tromey.com>
14179
14180         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14181         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14182         all_objfiles.
14183         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14184         * symmisc.c (print_symbol_bcache_statistics)
14185         (print_objfile_statistics, maintenance_print_objfiles)
14186         (maintenance_info_symtabs, maintenance_check_symtabs)
14187         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14188         all_objfiles.
14189         * source.c (forget_cached_source_info): Use all_objfiles.
14190         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14191         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14192         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14193         * objfiles.c (update_section_map): Use all_objfiles.
14194         (shared_objfile_contains_address_p): Likewise.
14195         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14196         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14197
14198 2019-01-09  Tom Tromey  <tom@tromey.com>
14199
14200         * common/next-iterator.h: New file.
14201         * objfiles.h (class all_objfiles): New.
14202         (struct objfile_iterator): New.
14203
14204 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14205
14206         * NEWS: Move the description of the changed "frame", "select-frame",
14207          and "info frame" commands to the Changed commands section.
14208
14209 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14210
14211         * gdbtypes.c (check_stub_method_group): Remove handling of old
14212         mangling schemes.
14213         * linespec.c (find_methods): Likewise.
14214         * stabsread.c (read_member_functions): Likewise.
14215         * valops.c (search_struct_method): Likewise.
14216         (value_struct_elt_for_reference): Likewise.
14217         * NEWS: Mention this change.
14218
14219 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14220
14221         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14222         print_source_lines.
14223         * source.c (print_source_lines_base): Update line number check.
14224         (print_source_lines): New function.
14225         (source_lines_range::source_lines_range): New function.
14226         * source.h (class source_lines_range): New class.
14227         (print_source_lines): New declaration.
14228
14229 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14230
14231         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14232
14233 2019-01-08  Tom Tromey  <tom@tromey.com>
14234             Simon Marchi  <simon.marchi@ericsson.com>
14235
14236         PR gdb/24060
14237         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14238         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14239         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14240         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14241         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14242         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14243
14244 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14245
14246         * source.c (select_source_symtab): Move header comment to
14247         declaration in source.h.
14248         (forget_cached_source_info_for_objfile): Likewise.
14249         (forget_cached_source_info): Likewise.
14250         (identify_source_line): Likewise.
14251         * source.h (identify_source_line): Move declaration from symtab.h
14252         and add comment from source.c
14253         (print_source_lines): Likewise.
14254         (forget_cached_source_info_for_objfile): Likewise.
14255         (forget_cached_source_info): Likewise.
14256         (select_source_symtab): Likewise.
14257         (enum print_source_lines_flag): Move definition from symtab.h.
14258         * symtab.h (identify_source_line): Move declaration to source.h.
14259         (print_source_lines): Likewise.
14260         (forget_cached_source_info_for_objfile): Likewise.
14261         (forget_cached_source_info): Likewise.
14262         (select_source_symtab): Likewise.
14263         (enum print_source_lines_flag): Move definition to source.h.
14264         * tui/tui-hooks.c: Add 'source.h' include.
14265
14266 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14267
14268         * source.c (print_source_lines_base): Handle requests to print
14269         reverse line number sequences, and guard against empty lines
14270         string.
14271
14272 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14273
14274         * source.c (print_source_lines_base): Fix skip of '\r' if next
14275         character is '\n'.
14276
14277 2019-01-06  Tom Tromey  <tom@tromey.com>
14278
14279         * c-exp.y (struct c_parse_state) <macro_original_text,
14280         expansion_obstack>: New member.
14281         (macro_original_text, expansion_obstack): Remove globals.
14282         (scan_macro_expansion, scanning_macro_expansion)
14283         (finished_macro_expansion): Update.
14284         (scan_macro_cleanup): Remove.
14285         (yylex, c_parse): Update.
14286
14287 2019-01-06  Tom Tromey  <tom@tromey.com>
14288
14289         * c-exp.y (struct c_parse_state) <strings>: New member.
14290         (operator_stoken): Update.
14291
14292 2019-01-06  Tom Tromey  <tom@tromey.com>
14293
14294         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14295         (union type_stack_elt) <typelist_val>: Now a pointer to
14296         std::vector.
14297         (type_stack_cleanup): Don't declare.
14298         (push_typelist): Update.
14299         * parse.c (pop_typelist): Return a std::vector.
14300         (push_typelist): Take a std::vector.
14301         (follow_types): Update.  Do not free args.
14302         (type_stack_cleanup): Remove.
14303         * c-exp.y (struct c_parse_state): New.
14304         (cpstate): New global.
14305         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14306         (nonempty_typelist): Update.
14307         (func_mod): Create a new vector.
14308         (c_parse): Create a c_parse_state.
14309         (check_parameter_typelist): Do not delete params.
14310         (function_method): Update.  Do not delete type_list.
14311
14312 2019-01-06  Tom Tromey  <tom@tromey.com>
14313
14314         PR gdb/28155:
14315         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14316         check_typedef.
14317         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14318         (print_return_value): Likewise.
14319
14320 2019-01-05  Tom Tromey  <tom@tromey.com>
14321
14322         * contrib/cleanup_check.py: Remove.
14323         * contrib/gcc-with-excheck: Remove.
14324         * contrib/exsummary.py: Remove.
14325         * contrib/excheck.py: Remove.
14326
14327 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14328
14329         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14330         NULL. Initialize tpprev to NULL instead of assigning it
14331         to NULL on the next statement.
14332         * windows-nat.c (windows_delete_thread): Remove check for
14333         main_thread_id before printing thread exit notifications.
14334         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14335         Remove thread ID check against main_thread_id.
14336         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14337         windows_delete_thread.
14338         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14339
14340 2019-01-04  Tom Tromey  <tom@tromey.com>
14341
14342         * compile/compile.c (_initialize_compile): Use upper case for
14343         metasyntactic variables.
14344         * symmisc.c (_initialize_symmisc): Use upper case for
14345         metasyntactic variables.
14346         * psymtab.c (_initialize_psymtab): Use upper case for
14347         metasyntactic variables.
14348         * demangle.c (demangle_command): Use upper case for metasyntactic
14349         variables.
14350         (_initialize_demangler): Likewise.
14351         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14352         variables.
14353
14354 2019-01-03  Tom Tromey  <tom@tromey.com>
14355
14356         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14357
14358 2019-01-03  Tom Tromey  <tom@tromey.com>
14359
14360         * python/py-symtab.c (salpy_str): Update.
14361         (struct salpy_sal_object) <symtab>: Now a PyObject.
14362         (salpy_dealloc): Update.
14363         (del_objfile_sal): Use gdbpy_ref.
14364
14365 2019-01-03  Tom Tromey  <tom@tromey.com>
14366
14367         * python/py-type.c (convert_field): Use new_reference.  Return
14368         gdbpy_ref.
14369         (make_fielditem): Return gdbpy_ref.
14370         (typy_fields): Update.
14371         (typy_getitem): Update.
14372         (field_name): Return gdbpy_ref.  Use new_reference.
14373         (typy_iterator_iternext): Update.
14374
14375 2019-01-03  Tom Tromey  <tom@tromey.com>
14376
14377         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14378
14379 2019-01-03  Tom Tromey  <tom@tromey.com>
14380
14381         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14382         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14383         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14384         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14385         (pspy_set_type_printers): Likewise.
14386         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14387         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14388         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14389         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14390         (objfpy_set_type_printers): Likewise.
14391
14392 2019-01-03  Tom Tromey  <tom@tromey.com>
14393
14394         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14395         (gdbpy_print_stack): Use gdbpy_err_fetch.
14396         * python/python-internal.h (class gdbpy_err_fetch): New class.
14397         (class gdbpy_enter) <m_error_type, m_error_value,
14398         m_error_traceback>: Remove.
14399         <m_error>: New member.
14400         (gdbpy_exception_to_string): Don't declare.
14401         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14402         * python/py-value.c (convert_value_from_python): Use
14403         gdbpy_err_fetch.
14404         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14405         gdbpy_exception_to_string.
14406         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14407         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14408         gdbpy_err_fetch.
14409
14410 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14411
14412         * linux-nat.c (delete_lwp_cleanup): Delete.
14413         (struct lwp_deleter): New struct.
14414         (lwp_info_up): New typedef.
14415         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14416         lwp_info_up.
14417
14418 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14419
14420         * linux-fork.c (class scoped_switch_fork_info): New class.
14421         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14422
14423 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14424
14425         * valops.c (find_overload_match): Remove use of null_cleanup, and
14426         calls to do_cleanups.
14427
14428 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14429
14430         * compile/compile-cplus-types.c
14431         (compile_cplus_instance::decl_name): Handle changes to
14432         cp_func_name.
14433         * cp-support.c (cp_func_name): Update header comment, update
14434         return type.
14435         * cp-support.h (cp_func_name): Update return type in declaration.
14436         * valops.c (find_overload_match): Move temp_func local to top
14437         level of function and change its type.  Use temp_func to hold and
14438         delete temporary string obtained from cp_func_name.
14439
14440 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14441
14442         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14443         gdb::char_vector, remove cleanup, and update uses of `msg`.
14444
14445 2019-01-03  Jim Wilson  <jimw@sifive.com>
14446
14447         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14448
14449 2019-01-02  Tom Tromey  <tom@tromey.com>
14450
14451         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14452         (tdesc_parse_xml): Remove cleanups.
14453         * target-descriptions.h (make_cleanup_free_target_description):
14454         Don't declare.
14455         (target_desc_deleter): New struct.
14456         (target_desc_up): New typedef.
14457         * target-descriptions.c (target_desc_deleter::operator()): Rename
14458         from free_target_description.
14459         (make_cleanup_free_target_description): Remove.
14460
14461 2019-01-02  Tom Tromey  <tom@tromey.com>
14462
14463         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14464         constructor, destructor.
14465         (linespec_parser): Remove typedef.
14466         (~linespec_parser): Rename from linespec_parser_delete.
14467         (linespec_lex_to_end, linespec_complete_label)
14468         (linespec_complete): Update.
14469         (decode_line_full): Remove cleanups.
14470         (decode_line_1): Update.
14471
14472 2019-01-02  Tom Tromey  <tom@tromey.com>
14473
14474         * python/python-internal.h (inferior_to_inferior_object): Change
14475         return type.
14476         * python/py-exitedevent.c (create_exited_event_object): Update.
14477         * python/py-inferior.c (inferior_to_inferior_object): Return
14478         gdbpy_ref.
14479         (python_new_inferior, python_inferior_deleted)
14480         (thread_to_thread_object, delete_thread_object)
14481         (build_inferior_list, gdbpy_selected_inferior): Update.
14482         * python/py-infthread.c (create_thread_object): Update.  Also fail
14483         if inferior_to_inferior_object fails.
14484
14485 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14486
14487         * inferior.h (class inferior) <displaced_step_state>: New field.
14488         * infrun.h (struct displaced_step_state): Move here from
14489         infrun.c.  Initialize fields, add constructor.
14490         <inf>: Remove field.
14491         <reset>: New method.
14492         * infrun.c (struct displaced_step_inferior_state): Move to
14493         infrun.h.
14494         (displaced_step_inferior_states): Remove.
14495         (get_displaced_stepping_state): Adust.
14496         (displaced_step_in_progress_any_inferior): Adjust.
14497         (displaced_step_in_progress_thread): Adjust.
14498         (displaced_step_in_progress): Adjust.
14499         (add_displaced_stepping_state): Remove.
14500         (get_displaced_step_closure_by_addr): Adjust.
14501         (remove_displaced_stepping_state): Remove.
14502         (infrun_inferior_exit): Call displaced_step_state.reset.
14503         (use_displaced_stepping): Don't check for NULL.
14504         (displaced_step_prepare_throw): Call
14505         get_displaced_stepping_state.
14506         (displaced_step_fixup): Don't check for NULL.
14507         (prepare_for_detach): Don't check for NULL.
14508
14509 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14510
14511         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14512          in case of call that did not complete.
14513
14514 2019-01-02  Andrey Utkin  <autkin@undo.io>
14515
14516         * symfile.c (find_separate_debug_file): Fix search of debug files for
14517         remote debuggee.
14518
14519 2019-01-02  Tom Tromey  <tom@tromey.com>
14520
14521         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14522         indentation.
14523         * python/py-frame.c (frapy_older): Remove cast.
14524         (frapy_newer): Likewise.
14525         * python/py-breakpoint.c (local_setattro): Remove cast.
14526         * python/py-arch.c (archpy_name): Remove local variable.
14527         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14528
14529 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14530
14531         * unittests/basic_string_view/element_access/char/empty.cc:
14532         Fix year range in copyright header.
14533
14534 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14535
14536         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14537         Delete.
14538         <operator==>: Update with for removed field.
14539         <hash>: Likewise.
14540         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14541         <isa_features>: ...this.
14542         <abi_features>: New field.
14543         (riscv_isa_flen): Update comment.
14544         (riscv_abi_xlen): New declaration.
14545         (riscv_abi_flen): New declaration.
14546         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14547         isa_features.
14548         (riscv_abi_xlen): New function.
14549         (riscv_isa_flen): Update to get answer from isa_features.
14550         (riscv_abi_flen): New function.
14551         (riscv_has_fp_abi): Update to get answer from abi_features.
14552         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14553         xlen and flen.
14554         (riscv_call_info) <xlen, flen>: Update comment.
14555         (riscv_call_arg_struct): Remove invalid assertions
14556         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14557         is removed.
14558         (riscv_gdbarch_init): Gather isa features and abi features
14559         separately, ensure both match on the gdbarch when reusing an old
14560         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14561         a target with 64-bit float hardware.
14562
14563 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14564
14565         * source.c (search_command_helper): Stop reverse search
14566         when line 1 has been searched.
14567
14568 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14569
14570         * record-full.c (record_full_base_target::close): Rewrite
14571         record_full_core_buf_list free logic.
14572
14573 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14574
14575         * break-catch-syscall.c (print_one_catch_syscall): xfree
14576         the last text.
14577
14578 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14579
14580         * top.c (print_gdb_version): Update Copyright year in version
14581         message.
14582
14583 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14584
14585         Update copyright year range in all GDB files.
14586
14587 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14588
14589         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14590
14591 For older changes see ChangeLog-2018.
14592 \f
14593 Local Variables:
14594 mode: change-log
14595 left-margin: 8
14596 fill-column: 74
14597 version-control: never
14598 coding: utf-8
14599 End:
14600