Don't call erase_data_content from tui_data_window::show_registers
[deliverable/binutils-gdb.git] / gdb / ChangeLog
1 2019-10-09 Tom Tromey <tom@tromey.com>
2
3 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
4 erase_data_content.
5
6 2019-10-09 Tom Tromey <tom@tromey.com>
7
8 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
9 * tui/tui-stack.c (tui_locator_window::rerender): Update.
10 * tui/tui-command.c (tui_cmd_window::resize)
11 (tui_refresh_cmd_win): Update.
12 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
13 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
14 * tui/tui-data.c (~tui_gen_win_info): Remove.
15 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
16 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
17 (tui_redisplay_readline, tui_mld_flush)
18 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
19 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
20 (tui_data_window::erase_data_content)
21 (tui_data_item_window::rerender)
22 (tui_data_item_window::refresh_window): Update.
23 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
24 (box_win, tui_gen_win_info::make_window)
25 (tui_gen_win_info::make_visible): Update.
26 (tui_delete_win): Remove.
27 * tui/tui-winsource.c
28 (tui_source_window_base::do_erase_source_content): Update.
29 (tui_show_source_line, tui_source_window_base::update_tab_width)
30 (tui_source_window_base::update_exec_info): Update.
31 * tui/tui-data.h (struct curses_deleter): New.
32 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
33 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
34
35 2019-10-09 Tom Tromey <tom@tromey.com>
36
37 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
38
39 2019-10-09 Tom Tromey <tom@tromey.com>
40
41 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
42 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
43
44 2019-10-09 Tom Tromey <tom@tromey.com>
45
46 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
47 window height directly.
48 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
49 declare.
50 * tui/tui-layout.c (tui_default_win_height): Remove.
51 (tui_default_win_viewport_height): Remove.
52
53 2019-10-09 Tom Tromey <tom@tromey.com>
54
55 * tui/tui.h: Remove comments.
56
57 2019-10-09 Tom de Vries <tdevries@suse.de>
58
59 * python/lib/gdb/printer/bound_registers.py: Use
60 '^builtin_type_bound128' as regexp argument for
61 add_builtin_pretty_printer.
62
63 2019-10-09 Christian Biesinger <cbiesinger@google.com>
64
65 * guile/guile.c (guile_extension_script_ops): Remove forward
66 declaration and mark as static.
67 (guile_script_ops): Likewise.
68 (extension_language_guile): Move further down in the file so
69 it can reference the definitions for guile_{extension_,}script_ops.
70
71 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
72
73 * s390-tdep.c (390_process_record): Handle new arch13 instructions
74 except SORTL, DFLTCC, and KDSA.
75
76 2019-10-08 Tom Tromey <tromey@adacore.com>
77
78 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
79 (struct safe_symbol_file_add_args): Remove.
80
81 2019-10-08 Tom Tromey <tromey@adacore.com>
82
83 * windows-nat.c: Don't include buildsym-legacy.h.
84
85 2019-10-08 Tom Tromey <tromey@adacore.com>
86
87 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
88
89 2019-10-08 Christian Biesinger <cbiesinger@google.com>
90
91 * gdbtypes.c (overload_debug): Move comment to header.
92 * gdbtypes.h (overload_debug): Declare.
93 * valops.c: Remove declaration of overload_debug, instead
94 include gdbtypes.h.
95
96 2019-10-08 Christian Biesinger <cbiesinger@google.com>
97
98 * language.c (show_language_command): Pass lang_frame_mismatch_warn
99 through _().
100 (lang_frame_mismatch_warn): Make const, mark with N_(), and
101 move comment...
102 * language.h (lang_frame_mismatch_warn): ... here. Also add
103 declaration.
104 * top.c (lang_frame_mismatch_warn): Remove declaration.
105 (check_frame_language_change): Pass lang_frame_mismatch_warn
106 through _().
107
108 2019-10-07 Christian Biesinger <cbiesinger@google.com>
109
110 * c-lang.h (vtbl_ptr_name): Declare.
111 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
112 it from the header.
113 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
114
115 2019-10-07 Christian Biesinger <cbiesinger@google.com>
116
117 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
118 gdb_static_assert.
119
120 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
121
122 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
123 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
124 * ctfread.c: New file.
125 * ctfread.h: New file.
126 * elfread.c: Include ctfread.h.
127 (struct elfinfo text_p): New member ctfsect.
128 (elf_locate_sections): Mark CTF section.
129 (elf_symfile_read): Call elfctf_build_psymtabs.
130 * Makefile.in (LIBCTF): Add.
131 (CLIBS): Use it.
132 (CDEPS): Likewise.
133 (DIST): Add ctfread.c.
134
135 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
136
137 * ctfread.c (struct nextfield): Renamed to ...
138 (struct ctf_nextfield): ... this.
139 (struct field_info): Renamed to ...
140 (strut ctf_field_info): ... this.
141 (attach_fields_to_type): Update for renamed structures.
142 (ctf_add_member_cb): Likewise.
143 (ctf_add_enum_member_cb): Likewise.
144 (process_struct_members): Likewise.
145 (process_enum_type): Likewise.
146
147 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
148
149 * tracectf.h: Rename, was ctf.h.
150 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
151 * tracefile.c: Likewise.
152 * tracepoint.c: Remove unused include ctf.h.
153 * mi/mi-main.c: Likewise.
154 * Makefile.in Replace ctf.c with tracectf.c.
155
156 2019-10-06 Joel Brobecker <brobecker@adacore.com>
157
158 * version.in: Change version number to "9.0.50.DATE-git".
159
160 2019-10-03 Tom Tromey <tom@tromey.com>
161
162 PR rust/24976:
163 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
164
165 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
166
167 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
168 cp_search_name_hash.
169 * NEWS: Add entry about nested function support.
170
171 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
172 Andrew Burgess <andrew.burgess@embecosm.com>
173
174 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
175 for nested static variables when searchin VAR_DOMAIN.
176 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
177 global scope, update comment.
178 (add_partial_subprogram): Call add_partial_subprogram recursively
179 for nested subroutines when processinng Fortran.
180 (load_partial_dies): Process the child entities of a subprogram
181 when processing Fortran.
182 (partial_die_parent_scope): Handle building scope
183 for Fortran nested functions.
184 (process_die): Record that nested functions have a scope.
185 (new_symbol): Always record Fortran subprograms on the global
186 symbol list.
187 (determine_prefix): How to build the prefix for Fortran
188 subprograms.
189
190 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
191
192 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
193 have just sent the thread a SIGSTOP and are waiting for it to
194 arrive.
195
196 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
197
198 * btrace.c (btrace_add_pc): Remove whitespace before the template
199 parameter in 'std::vector <...>'.
200 (parse_xml_btrace_block): Likewise.
201 (btrace_maint_decode_pt): Likewise.
202 (btrace_maint_update_packets): Likewise.
203 (btrace_maint_print_packets): Likewise.
204 * btrace.h (struct btrace_maint_info): Likewise.
205 * dwarf2read.c (struct type_unit_group): Likewise.
206 (build_type_psymtabs_reader): Likewise.
207 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
208 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
209 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
210
211 2019-10-03 Tom de Vries <tdevries@suse.de>
212
213 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
214 the first line of the help text for set/show style metadata.
215
216 2019-10-02 Tom Tromey <tromey@adacore.com>
217
218 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
219 * gdbsupport/common-inferior.c: New file.
220 * infcmd.c (startup_with_shell): Don't define.
221 * nat/fork-inferior.h (startup_with_shell): Don't declare.
222 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
223 * inferior.h (startup_with_shell): Don't declare.
224
225 2019-10-02 Christian Biesinger <cbiesinger@google.com>
226
227 * gdbsupport/gdb_assert.h: Include errors.h.
228 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
229
230 2019-10-02 Tom Tromey <tromey@adacore.com>
231
232 * NEWS: Add $_ada_exception entry.
233 * ada-lang.c (struct ada_catchpoint): Add constructor.
234 <m_kind>: New member.
235 (allocate_location_exception, re_set_exception): Remove
236 "ex" parameter.
237 (should_stop_exception): Compute $_ada_exception.
238 (check_status_exception, print_it_exception)
239 (print_one_exception, print_mention_exception): Remove
240 "ex" parameter.
241 (allocate_location_catch_exception, re_set_catch_exception)
242 (check_status_exception, print_it_catch_exception)
243 (print_one_catch_exception, print_mention_catch_exception)
244 (print_recreate_catch_exception)
245 (allocate_location_catch_exception_unhandled)
246 (re_set_catch_exception_unhandled)
247 (check_status_exception, print_it_catch_exception_unhandled)
248 (print_one_catch_exception_unhandled)
249 (print_mention_catch_exception_unhandled)
250 (print_recreate_catch_exception_unhandled)
251 (allocate_location_catch_assert, re_set_catch_assert)
252 (check_status_assert, print_it_catch_assert)
253 (print_one_catch_assert, print_mention_catch_assert)
254 (print_recreate_catch_assert)
255 (allocate_location_catch_handlers, re_set_catch_handlers)
256 (check_status_handlers, print_it_catch_handlers)
257 (print_one_catch_handlers, print_mention_catch_handlers)
258 (print_recreate_catch_handlers): Remove.
259 (create_ada_exception_catchpoint): Update.
260 (initialize_ada_catchpoint_ops): Update.
261
262 2019-10-02 Tom Tromey <tromey@adacore.com>
263
264 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
265 (create_excep_cond_exprs): Simplify exception string computation.
266 (ada_exception_catchpoint_cond_string): Likewise.
267
268 2019-10-02 Tom Tromey <tromey@adacore.com>
269
270 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
271 * ada-lang.c (lesseq_defined_than): Handle
272 LOC_STATIC.
273 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
274 parameter.
275 (dwarf2_has_info): Likewise.
276 (new_symbol): Set maybe_copied on symbol when
277 appropriate.
278 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
279 parameter.
280 <can_copy>: New member.
281 * elfread.c (record_minimal_symbol): Set maybe_copied
282 on symbol when appropriate.
283 (elf_symfile_read): Update call to dwarf2_has_info.
284 * minsyms.c (lookup_minimal_symbol_linkage): New
285 function.
286 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
287 * symtab.c (get_symbol_address, get_msymbol_address):
288 New functions.
289 * symtab.h (get_symbol_address, get_msymbol_address):
290 Declare.
291 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
292 maybe_copied.
293 (struct symbol, struct minimal_symbol) <maybe_copied>:
294 New member.
295
296 2019-10-02 Tom Tromey <tromey@adacore.com>
297
298 * source.c (struct current_source_location): New.
299 (current_source_key): New global.
300 (current_source_symtab, current_source_line)
301 (current_source_pspace): Remove.
302 (get_source_location): New function.
303 (get_current_source_symtab_and_line)
304 (set_default_source_symtab_and_line)
305 (set_current_source_symtab_and_line)
306 (clear_current_source_symtab_and_line, select_source_symtab)
307 (info_source_command, print_source_lines_base)
308 (info_line_command, search_command_helper, _initialize_source):
309 Update.
310
311 2019-10-02 Tom Tromey <tromey@adacore.com>
312
313 * source.c (select_source_symtab): Don't call
314 decode_line_with_current_source.
315
316 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
317
318 * symtab.c (lookup_global_symbol): Search global block.
319
320 2019-10-02 Tom Tromey <tromey@adacore.com>
321
322 * coffread.c (process_coff_symbol): Update.
323 * dwarf2read.c (var_decode_location, new_symbol): Update.
324 * mdebugread.c (parse_symbol): Update.
325 * objfiles.c (relocate_one_symbol): Update.
326 * stabsread.c (define_symbol, fix_common_block)
327 (scan_file_globals): Update.
328 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
329 (SET_SYMBOL_VALUE_ADDRESS): New macro.
330 * xcoffread.c (process_xcoff_symbol): Update.
331
332 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
333
334 * MAINTAINERS: Update my email address.
335
336 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
337
338 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
339 std::vector.
340 (build_type_psymtabs_reader): Update for std::vector.
341 (build_type_psymtab_dependencies): Likewise.
342 * dwarf2read.h: Remove use of DEF_VEC_P.
343 (typedef sig_type_ptr): Delete.
344
345 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
346
347 * btrace.c (btrace_maint_clear): Update to handle change from VEC
348 to std::vector.
349 (btrace_maint_decode_pt): Likewise, and move allocation of the
350 vector outside of the loop.
351 (btrace_maint_update_packets): Update to handle change from VEC to
352 std::vector.
353 (btrace_maint_print_packets): Likewise.
354 (maint_info_btrace_cmd): Likewise.
355 * btrace.h: Remove use of DEF_VEC_O.
356 (typedef btrace_pt_packet_s): Delete.
357 (struct btrace_maint_info) <packets>: Change fromm VEC to
358 std::vector.
359 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
360
361 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
362
363 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
364 make accesses into the vector constant references.
365 (btrace_add_pc): Update for std::vector.
366 (btrace_stitch_bts): Likewise.
367 (parse_xml_btrace_block): Likewise.
368 (btrace_maint_update_packets): Likewise.
369 (btrace_maint_print_packets): Likewise.
370 (maint_info_btrace_cmd): Likewise.
371 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
372 std::vector.
373 (btrace_data::empty): Likewise.
374 (btrace_data_append): Likewise.
375 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
376 (typedef btrace_block_s): Delete.
377 (struct btrace_block): Add constructor.
378 (struct btrace_data_bts) <blocks>: Change to std::vector.
379 * nat/linux-btrace.c (perf_event_read_bts): Update for
380 std::vector.
381 (linux_read_bts): Likewise.
382
383 2019-10-01 Tom Tromey <tom@tromey.com>
384
385 * cli/cli-logging.c (show_logging_filename): Use styled_string.
386
387 2019-10-01 Tom Tromey <tom@tromey.com>
388
389 * stack.c (print_frame, info_frame_command_core): Use
390 styled_string.
391 * linux-thread-db.c (try_thread_db_load_1)
392 (try_thread_db_load_from_pdir_1): Use styled_string.
393 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
394 (auto_load_section_scripts, info_auto_load_local_gdbinit)
395 (maybe_print_unsupported_script_warning)
396 (maybe_print_script_not_found_warning): Use styled_string.
397 * ada-lang.c (user_select_syms): Use styled_string.
398
399 2019-10-01 Tom Tromey <tom@tromey.com>
400
401 * p-lang.c (pascal_printstr): Use metadata style.
402 * value.c (show_convenience): Use metadata style.
403 * valprint.c (valprint_check_validity, val_print_optimized_out)
404 (val_print_not_saved, val_print_unavailable)
405 (val_print_invalid_address, generic_val_print, val_print)
406 (value_check_printable, val_print_array_elements): Use metadata
407 style.
408 * ui-out.h (class ui_out) <field_fmt>: New overload.
409 <do_field_fmt>: Add style parameter.
410 * ui-out.c (ui_out::field_fmt): New overload.
411 * typeprint.c (type_print_unknown_return_type)
412 (val_print_not_allocated, val_print_not_associated): Use metadata
413 style.
414 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
415 parameter.
416 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
417 * tracepoint.c (tvariables_info_1): Use metadata style.
418 * stack.c (print_frame_arg, print_frame_info, print_frame)
419 (info_frame_command_core): Use metadata style.
420 * skip.c (info_skip_command): Use metadata style.
421 * rust-lang.c (rust_print_enum): Use metadata style.
422 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
423 metadata style.
424 * python/py-framefilter.c (py_print_single_arg): Use metadata
425 style.
426 * printcmd.c (do_one_display, print_variable_and_value): Use
427 metadata style.
428 * p-valprint.c (pascal_val_print)
429 (pascal_object_print_value_fields): Use metadata style.
430 * p-typeprint.c (pascal_type_print_base): Use metadata style.
431 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
432 parameter.
433 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
434 * m2-valprint.c (m2_print_long_set): Use metadata style.
435 * m2-typeprint.c (m2_print_type): Use metadata style.
436 * infcmd.c (print_return_value_1): Use metadata style.
437 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
438 * f-valprint.c (info_common_command_for_block): Use metadata
439 style.
440 * f-typeprint.c (f_type_print_base): Use metadata style.
441 * expprint.c (print_subexp_standard): Use metadata style.
442 * cp-valprint.c (cp_print_value_fields): Use metadata style.
443 * cli/cli-style.h (class cli_style_option): Add constructor.
444 (metadata_style): Declare.
445 * cli/cli-style.c (metadata_style): New global.
446 (_initialize_cli_style): Register metadata style.
447 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
448 parameter.
449 * cli-out.c (cli_ui_out::do_field_fmt): Update.
450 * c-typeprint.c (c_type_print_base_struct_union)
451 (c_type_print_base_1): Use metadata style.
452 * breakpoint.c (watchpoint_value_print)
453 (print_one_breakpoint_location): Use metadata style.
454 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
455 style.
456 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
457 style.
458 * ada-valprint.c (val_print_packed_array_elements, printstr)
459 (print_field_values, ada_val_print_ref, ada_val_print): Use
460 metadata style.
461 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
462 style.
463 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
464 style.
465 * ada-lang.c (user_select_syms): Use metadata style.
466
467 2019-10-01 Tom Tromey <tom@tromey.com>
468
469 * cli/cli-cmds.c (pwd_command): Style output.
470
471 2019-10-01 Pedro Alves <palves@redhat.com>
472 Tom Tromey <tom@tromey.com>
473
474 * symtab.c (print_symbol_info): Use %ps.
475 (print_msymbol_info): Use %ps.
476 * symfile.c (symbol_file_add_with_addrs): Use %ps.
477 * printcmd.c (print_variable_and_value): Use %ps.
478 * macrocmd.c (show_pp_source_pos): Use %ps.
479 * infrun.c (print_exited_reason): Use ui_out::message.
480 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
481 (describe_other_breakpoints): Use ui_out::message and new
482 formats.
483 (say_where): Use new formats.
484 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
485 and new formats.
486
487 2019-10-01 Pedro Alves <palves@redhat.com>
488 Tom Tromey <tom@tromey.com>
489
490 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
491 (test_gdb_formats): New function.
492 (run_tests): Call it.
493 (test_format_specifier): Update.
494 * utils.h (fputs_filtered): Update comment.
495 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
496 (fputs_styled_unfiltered): Declare.
497 * utils.c (fputs_styled_unfiltered): New function.
498 (vfprintf_maybe_filtered): Add gdbfmt parameter.
499 (vfprintf_filtered): Update.
500 (vfprintf_unfiltered, vprintf_filtered): Update.
501 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
502 * ui-out.h (enum ui_out_flag) <unfiltered_output,
503 disallow_ui_out_field>: New constants.
504 (enum class field_kind): New.
505 (struct base_field_s, struct signed_field_s): New.
506 (signed_field): New function.
507 (struct string_field_s): New.
508 (string_field): New function.
509 (struct styled_string_s): New.
510 (styled_string): New function.
511 (class ui_out) <message>: Add comment.
512 <vmessage, call_do_message>: New methods.
513 <do_message>: Add style parameter.
514 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
515 methods.
516 (ui_out::message): Rewrite.
517 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
518 parameter.
519 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
520 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
521 gdb_extensions parameter.
522 (class format_piece): Add parameter to constructor.
523 (n_int_args): New field.
524 * gdbsupport/format.c (format_pieces::format_pieces): Add
525 gdb_extensions parameter. Handle '*'.
526 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
527 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
528 vfprintf_styled_no_gdbfmt.
529 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
530 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
531 unfiltered output.
532 * ui-style.h (struct ui_file_style) <ptr>: New method.
533
534 2019-10-01 Tom Tromey <tom@tromey.com>
535
536 * unittests/format_pieces-selftests.c: Update. Add final format.
537 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
538 empty literal pieces.
539
540 2019-10-01 Tom Tromey <tom@tromey.com>
541
542 * ui-out.h (enum class ui_out_style_kind): Remove.
543 (class ui_out) <field_string, field_stsream, do_field_string>:
544 Change type of "style".
545 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
546 (ui_out::field_string): Update.
547 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
548 of "style".
549 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
550 * tracepoint.c (print_one_static_tracepoint_marker): Update.
551 * stack.c (print_frame_arg, print_frame_info, print_frame):
552 Update.
553 * source.c (print_source_lines_base): Update.
554 * solib.c (info_sharedlibrary_command): Update.
555 * skip.c (info_skip_command): Update.
556 * record-btrace.c (btrace_call_history_src_line)
557 (btrace_call_history): Update.
558 * python/py-framefilter.c (py_print_frame): Update.
559 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
560 "style".
561 * mi/mi-out.c (mi_ui_out::do_table_header)
562 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
563 (mi_ui_out::do_field_string): Update.
564 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
565 Update.
566 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
567 "style".
568 * cli-out.c (cli_ui_out::do_table_header)
569 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
570 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
571 (cli_ui_out::do_field_fmt): Update.
572 * breakpoint.c (print_breakpoint_location): Update.
573 (update_static_tracepoint): Update.
574
575 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
576
577 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
578 conversion of gdb_datadir.
579 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
580 remove not needed c_str ().
581
582 2019-09-30 Ali Tamur <tamur@google.com>
583
584 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
585 (dwarf2_string_attr): Likewise.
586
587 2019-09-30 Ali Tamur <tamur@google.com>
588
589 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
590 (process_full_type_unit): Likewise.
591 (dump_die_shallow): Likewise.
592 (cu_debug_loc_section): Likewise.
593
594 2019-09-28 Christian Biesinger <cbiesinger@google.com>
595
596 * minsyms.c (compare_minimal_symbols): Rename to...
597 (minimal_symbol_is_less_than): ...this, and adjust to STL
598 conventions (return bool, take arguments as references)
599 (minimal_symbol_reader::install): Call std::sort instead
600 of qsort.
601
602 2019-09-29 Christian Biesinger <cbiesinger@google.com>
603
604 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
605 hash and why.
606 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
607 msymbol_hash, msymbol_demangled_hash>: Improve comments.
608
609 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
610
611 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
612 * psympriv.h (add_psymbol_to_list): Move comment here and update
613 it.
614
615 2019-09-29 Tom de Vries <tdevries@suse.de>
616
617 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
618 Use $tmpdir/$(basename "$output_file").dwz instead of
619 "${output_file}.dwz".
620
621 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
622
623 PR gdb/25045
624 * hppa-linux-nat.c: Include gdbarch.h.
625
626 2019-09-26 Christian Biesinger <cbiesinger@google.com>
627
628 * blockframe.c (find_pc_partial_function): Change return type to bool.
629 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
630 * minsyms.c (in_gnu_ifunc_stub): Likewise.
631 (stub_gnu_ifunc_resolve_name): Likewise.
632 * symtab.c (compare_filenames_for_search): Likewise.
633 (compare_glob_filenames_for_search): Likewise.
634 (matching_obj_sections): Likewise.
635 (symbol_matches_domain): Likewise.
636 (find_line_symtab): Change out param EXACT_MATCH to bool *.
637 (find_line_pc): Change return type to bool.
638 (find_line_pc_range): Likewise.
639 (producer_is_realview): Likewise.
640 * symtab.h (symbol_matches_domain): Likewise.
641 (find_pc_partial_function): Likewise.
642 (find_pc_line_pc_range): Likewise.
643 (in_gnu_ifunc_stub): Likewise.
644 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
645 (find_line_pc): Likewise.
646 (find_line_pc_range): Likewise.
647 (matching_obj_sections): Likewise.
648 (find_line_symtab): Change out parameter to bool.
649 (producer_is_realview): Change return type to bool.
650 (compare_filenames_for_search): Likewise.
651 (compare_glob_filenames_for_search): Likewise.
652
653 2019-09-26 Tom Tromey <tom@tromey.com>
654
655 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
656 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
657 * gdb_usleep.h: Remove.
658 * gdb_usleep.c: Remove.
659 * utils.c: Don't include gdb_usleep.h.
660
661 2019-09-26 Tom Tromey <tromey@adacore.com>
662
663 * python/py-type.c (type_to_type_object): Call check_typedef
664 for stub types.
665
666 2019-09-26 Tom Tromey <tom@tromey.com>
667
668 * utils.h (initialize_utils): Don't declare.
669 * top.c (gdb_init): Don't call initialize_utils.
670 * utils.c (initialize_utils): Remove. Move contents...
671 (_initialize_utils): ... here.
672
673 2019-09-25 Tom Tromey <tom@tromey.com>
674
675 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
676 * utils.h (make_hex_string): Don't declare.
677 * utils.c (make_hex_string): Remove.
678
679 2019-09-24 Tom de Vries <tdevries@suse.de>
680
681 PR gdb/23815
682 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
683 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
684
685 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
686
687 * NEWS: Mention new simulator port for PRU.
688
689 2019-09-23 Christian Biesinger <cbiesinger@google.com>
690
691 * ada-exp.y (write_object_remaining): Update.
692 * ada-lang.c (ada_decode): Return a std::string instead of a char*
693 and eliminate the static buffer.
694 (ada_decode_symbol): Update.
695 (ada_la_decode): Update.
696 (ada_sniff_from_mangled_name): Update.
697 (is_valid_name_for_wild_match): Update.
698 (ada_lookup_name_info::matches): Update and simplify.
699 (name_matches_regex): Update.
700 (ada_add_global_exceptions): Update.
701 * ada-lang.h (ada_decode): Update signature.
702 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
703 * dwarf-index-write.c (debug_names::insert): Update.
704
705 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
706
707 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
708 formatting.
709
710 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
711
712 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
713 Change "nonzero" to "true" in documentation.
714
715 2019-09-20 Christian Biesinger <cbiesinger@google.com>
716
717 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
718 (_initialize_darwin_solib): Don't set
719 darwin_so_ops.lookup_lib_global_symbol.
720 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
721 set_gdbarch_iterate_over_objfiles_in_search_order.
722 (elf_lookup_lib_symbol): Rename to...
723 (svr4_iterate_over_objfiles_in_search_order): this, and update
724 to iterate semantics.
725 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
726 * solib.c (solib_global_lookup): Remove.
727 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
728 (solib_global_lookup): Remove.
729 * symtab.c (lookup_global_or_static_symbol): Remove call to
730 solib_global_lookup.
731
732 2019-09-20 Joel Brobecker <brobecker@adacore.com>
733
734 * NEWS: Move entries about default MI version now being
735 version 3, and about the GDB/MI fix for multi-location
736 breakpoints to the "since GDB 8.3" section.
737
738 2019-09-20 Joel Brobecker <brobecker@adacore.com>
739
740 GDB 8.3.1 released.
741
742 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
743
744 * NEWS: Mention that Cell/B.E. debugging support was removed.
745 * MAINTAINERS: Remove spu target.
746
747 * config/djgpp/fnchange.lst: Remove entries for removed files.
748
749 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
750 spu-multiarch.o, and spu-tdep.o.
751 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
752 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
753 spu-multiarch.c, and spu-tdep.c.
754 * spu-linux-nat.c: Remove file.
755 * spu-multiarch.c: Remove file.
756 * spu-tdep.c: Remove file.
757 * spu-tdep.h: Remove file.
758 * solib-spu.c: Remove file.
759 * solib-spu.h: Remove file.
760
761 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
762 * configure.nat (spu-linux): Remove.
763 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
764 solib-multiarch.o from gdb_target_obs.
765 (spu*-*-*): Remove.
766
767 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
768 feature flag.
769 (ppc_linux_no_features): Update.
770 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
771 Cell/B.E. support.
772 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
773 (tdesc_powerpc_cell64l): Likewise.
774 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
775 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
776 Cell/B.E. support.
777 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
778 Do not include "features/rs6000/powerpc-cell32l.c" or
779 "features/rs6000/powerpc-cell64l.c".
780 (ppc_linux_spu_section): Remove.
781 (ppc_linux_core_read_description): Remove Cell/B.E. support.
782 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
783 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
784 (ppc_linux_spe_context_lookup): Remove.
785 (ppc_linux_spe_context_inferior_created): Remove.
786 (ppc_linux_spe_context_solib_loaded): Remove.
787 (ppc_linux_spe_context_solib_unloaded): Remove.
788 (ppc_linux_spe_context): Remove.
789 (struct ppu2spu_cache): Remove.
790 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
791 (struct ppu2spu_data): Remove.
792 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
793 ppu2spu_unwind): Remove.
794 (ppc_linux_init_abi): Remove Cell/B.E. support.
795 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
796
797 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
798 (rs6000/powerpc-cell64l-expedite): Likewise
799 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
800 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
801 rs6000/powerpc-cell64l.xml.
802 * features/rs6000/powerpc-cell32l.xml: Remove.
803 * features/rs6000/powerpc-cell64l.xml: Likewise.
804 * features/rs6000/powerpc-cell32l.c: Remove generated file.
805 * features/rs6000/powerpc-cell64l.c: Likewise.
806 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
807 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
808 * regformats/reg-spu.dat: Remove.
809
810 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
811 * corelow.c (struct spuid_list): Remove.
812 (add_to_spuid_list): Remove.
813 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
814 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
815 (remote_protocol_features): Remove associated entries.
816 (_initialize_remote): No longer initialize them.
817 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
818 * linux-nat.c (SPUFS_MAGIC): Remove.
819 (linux_proc_xfer_spu): Remove.
820 (spu_enumerate_spu_ids): Remove.
821 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
822 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
823 (linux_make_corefile_notes): No longer call it.
824
825 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
826 (cooked_write_test): Likewise.
827
828 2019-09-20 Tom Tromey <tom@tromey.com>
829
830 * NEWS: Mention case-sensitivity of TUI commands.
831 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
832 (tui_set_win_height_command, parse_scrolling_args): Likewise.
833 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
834
835 2019-09-20 Tom Tromey <tom@tromey.com>
836
837 * tui/tui-source.c (tui_source_window::set_contents): Use
838 make_unique_xstrdup.
839 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
840 make_unique_xstrdup.
841
842 2019-09-20 Tom Tromey <tom@tromey.com>
843
844 * tui/tui-data.c: Remove separator comments.
845 * tui/tui-layout.c: Remove separator comments.
846 * tui/tui-win.c: Remove separator comments.
847 * tui/tui-wingeneral.c: Remove separator comments.
848
849 2019-09-20 Tom Tromey <tom@tromey.com>
850
851 * tui/tui.h (strcat_to_buf): Don't declare.
852 * tui/tui.c (strcat_to_buf): Remove.
853
854 2019-09-20 Tom Tromey <tom@tromey.com>
855
856 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
857 from "fullname".
858 * tui/tui-source.c (tui_source_window::set_contents)
859 (tui_source_window::location_matches_p)
860 (tui_source_window::maybe_update): Update.
861
862 2019-09-20 Tom Tromey <tom@tromey.com>
863
864 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
865 Update.
866 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
867 prefix.
868 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
869 (tui_data_window::line_from_reg_element_no)
870 (tui_data_window::first_reg_element_no_inline)
871 (tui_data_window::show_registers)
872 (tui_data_window::show_register_group)
873 (tui_data_window::display_registers_from)
874 (tui_data_window::display_registers_from_line)
875 (tui_data_window::first_data_item_displayed)
876 (tui_data_window::delete_data_content_windows)
877 (tui_data_window::erase_data_content)
878 (tui_data_window::do_scroll_vertical)
879 (tui_data_window::refresh_window)
880 (tui_data_window::check_register_values): Update.
881
882 2019-09-20 Tom Tromey <tom@tromey.com>
883
884 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
885 (struct tui_locator_window) <full_name, proc_name>: Now
886 std::string.
887 * tui/tui-stack.c (tui_locator_window::make_status_line)
888 (tui_locator_window::set_locator_fullname)
889 (tui_locator_window::set_locator_info): Update.
890 * tui/tui-source.c (tui_source_window::set_contents)
891 (tui_source_window::showing_source_p): Update.
892
893 2019-09-20 Tom Tromey <tom@tromey.com>
894
895 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
896 Don't call tui_locator_win_info_ptr.
897
898 2019-09-20 Tom Tromey <tom@tromey.com>
899
900 * tui/tui-win.c (tui_resize_all): Don't call refresh.
901
902 2019-09-20 Tom Tromey <tom@tromey.com>
903
904 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
905 height for locator.
906 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
907 * tui/tui-layout.c (show_source_disasm_command, show_data)
908 (show_source_or_disasm_and_command): Use 1 as height for locator.
909
910 2019-09-20 Tom Tromey <tom@tromey.com>
911
912 * tui/tui.c (tui_enable): Update.
913 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
914 Update.
915 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
916 Update.
917 * tui/tui-data.c (win_resized): Now bool.
918 (tui_win_resized): Return bool.
919 (tui_set_win_resized_to): Accept a bool.
920
921 2019-09-20 Tom Tromey <tom@tromey.com>
922
923 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
924 Change type of "refresh_values_only".
925 * tui/tui-regs.c (tui_data_window::show_register_group): Change
926 type of "refresh_values_only".
927
928 2019-09-20 Tom Tromey <tom@tromey.com>
929
930 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
931 std::string.
932 (tui_disassemble): Add "pos" parameter.
933 (tui_disasm_window::set_contents): Simplify.
934
935 2019-09-20 Tom Tromey <tom@tromey.com>
936
937 * tui/tui-winsource.h (struct tui_source_window_base)
938 <show_source_content>: Now private.
939 * tui/tui-winsource.c
940 (tui_source_window_base::show_source_content): Don't handle empty
941 content case.
942
943 2019-09-20 Tom Tromey <tom@tromey.com>
944
945 * tui/tui-layout.c (show_source_disasm_command)
946 (show_source_or_disasm_and_command): Don't call
947 show_source_content.
948
949 2019-09-20 Tom Tromey <tom@tromey.com>
950
951 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
952 Declare.
953 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
954 from tui_make_status_line.
955 (tui_locator_window::rerender): Update.
956
957 2019-09-20 Tom Tromey <tom@tromey.com>
958
959 * tui/tui-stack.c (tui_make_status_line): Return std::string.
960 (tui_locator_window::rerender): Update.
961
962 2019-09-20 Tom Tromey <tom@tromey.com>
963
964 * tui/tui-winsource.h (struct tui_source_window_base)
965 <~tui_source_window_base>: Don't declare.
966 <fullname>: Remove.
967 * tui/tui-winsource.c (~tui_source_window_base): Remove.
968 * tui/tui-source.h (struct tui_source_window) <fullname>: New
969 member.
970 * tui/tui-source.c (tui_source_window::set_contents): Update.
971 (tui_source_window::location_matches_p)
972 (tui_source_window::maybe_update): Update.
973
974 2019-09-20 Tom Tromey <tom@tromey.com>
975
976 * tui/tui-winsource.h (~tui_source_element): Remove.
977 (tui_source_element): Update.
978 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
979 * tui/tui-winsource.c (tui_show_source_line): Update.
980 * tui/tui-source.c (tui_source_window::set_contents): Update.
981 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
982
983 2019-09-20 Tom Tromey <tom@tromey.com>
984
985 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
986 declare.
987 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
988 tui_clear_source_windows_detail.
989 * tui/tui-winsource.h (struct tui_source_window_base)
990 <clear_detail>: Don't declare.
991 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
992 Remove.
993 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
994
995 2019-09-20 Tom Tromey <tromey@adacore.com>
996
997 PR ada/24919:
998 * block.c (contained_in): Fix final return value.
999
1000 2019-09-20 Alan Modra <amodra@gmail.com>
1001
1002 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1003 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1004 (read_indirect_string_from_dwz): Use bfd accessor.
1005 * dwarf2read.h (struct dwz_file <filename>): Likewise.
1006 * machoread.c (macho_symfile_read_all_oso): Likewise.
1007 * solib.c (solib_bfd_open): Likewise.
1008
1009 2019-09-19 Christian Biesinger <cbiesinger@google.com>
1010
1011 * eval.c: Move declaration of overload_resolution to...
1012 * value.h: ...here.
1013
1014 2019-09-19 Christian Biesinger <cbiesinger@google.com>
1015
1016 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1017 * arm-linux-tdep.c: Likewise.
1018 * arm-nbsd-nat.c: Likewise.
1019 * arm-tdep.h: Declare arm_apcs_32.
1020 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1021
1022 2019-09-19 Christian Biesinger <cbiesinger@google.com>
1023
1024 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1025 * dwarf2read.h: Declare dwarf_always_disassemble.
1026
1027 2019-09-19 Tom de Vries <tdevries@suse.de>
1028
1029 PR gdb/25009
1030 * source-cache.c (source_cache::ensure): Catch exception thrown during
1031 construction of the highlighter.
1032
1033 2019-09-18 Alan Modra <amodra@gmail.com>
1034
1035 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1036 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1037 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1038 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1039 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1040 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1041 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1042 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1043 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1044 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1045 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1046 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1047 * solib-spu.c, * solib-svr4.c, * solib-target.c,
1048 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1049 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1050 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1051 * mi/mi-interp.c: Update throughout for bfd section macro and
1052 function changes.
1053 * gcore (gcore_create_callback): Use bfd_set_section_lma.
1054 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1055
1056 2019-09-18 Tom Tromey <tom@tromey.com>
1057
1058 * NEWS: Add entry.
1059 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
1060 call rl_initialize.
1061 (tui_enable): Do not call rl_initialize.
1062
1063 2019-09-18 Christian Groessler <chris@groessler.org>
1064
1065 * alpha-linux-nat.c: Include gdbarch.h.
1066
1067 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
1068
1069 * ui-file.c: Include cli/cli-style.h.
1070 (term_cli_styling): Remove cli_styling declaration.
1071
1072 2019-09-18 Alan Modra <amodra@gmail.com>
1073
1074 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1075 to bfd_asymbol_section.
1076
1077 2019-09-18 Alan Modra <amodra@gmail.com>
1078
1079 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1080 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1081 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1082
1083 2019-09-18 Alan Modra <amodra@gmail.com>
1084
1085 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1086 * spu-linux-nat.c (spu_bfd_open): Likewise.
1087
1088 2019-09-18 Christian Biesinger <cbiesinger@google.com>
1089
1090 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1091 to bool to match definition in dwarf2read.c.
1092
1093 2019-09-17 Christian Biesinger <cbiesinger@google.com>
1094
1095 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1096 (print_signatures): Likewise.
1097 (trust_pad_over_xvs): Likewise.
1098 * arch/aarch64-insn.c (aarch64_debug): Likewise.
1099 * arch/aarch64-insn.h (aarch64_debug): Likewise.
1100 * arm-linux-nat.c (arm_apcs_32): Likewise.
1101 * arm-linux-tdep.c (arm_apcs_32): Likewise.
1102 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1103 * arm-tdep.c (arm_debug): Likewise.
1104 (arm_apcs_32): Likewise.
1105 * auto-load.c (debug_auto_load): Likewise.
1106 (auto_load_gdb_scripts): Likewise.
1107 (global_auto_load): Likewise.
1108 (auto_load_local_gdbinit): Likewise.
1109 (auto_load_local_gdbinit_loaded): Likewise.
1110 * auto-load.h (global_auto_load): Likewise.
1111 (auto_load_local_gdbinit): Likewise.
1112 (auto_load_local_gdbinit_loaded): Likewise.
1113 * breakpoint.c (disconnected_dprintf): Likewise.
1114 (breakpoint_proceeded): Likewise.
1115 (automatic_hardware_breakpoints): Likewise.
1116 (always_inserted_mode): Likewise.
1117 (target_exact_watchpoints): Likewise.
1118 (_initialize_breakpoint): Update.
1119 * breakpoint.h (target_exact_watchpoints): Change to bool.
1120 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1121 * cli/cli-cmds.c (trace_commands): Likewise.
1122 * cli/cli-cmds.h (trace_commands): Likewise.
1123 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1124 to bool*.
1125 * cli/cli-logging.c (logging_overwrite): Change to bool.
1126 (logging_redirect): Likewise.
1127 (debug_redirect): Likewise.
1128 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1129 (struct boolean_option_def) <get_var_address_cb_>: Change return type
1130 to bool.
1131 <boolean_option_def>: Update.
1132 (struct flag_option_def): Change default type of Context to bool
1133 from int.
1134 <flag_option_def>: Change return type of var_address_cb_ to bool*.
1135 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1136 (get_setshow_command_value_string): Likewise.
1137 * cli/cli-style.c (cli_styling): Change to bool.
1138 (source_styling): Likewise.
1139 * cli/cli-style.h (source_styling): Likewise.
1140 (cli_styling): Likewise.
1141 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1142 to bool.
1143 * command.h (var_types): Update comment.
1144 (add_setshow_boolean_cmd): Change int* var argument to bool*.
1145 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1146 bool.
1147 (debug_compile_cplus_scopes): Likewise.
1148 * compile/compile-internal.h (compile_debug): Likewise.
1149 * compile/compile.c (compile_debug): Likewise.
1150 (struct compile_options) <raw>: Likewise.
1151 * cp-support.c (catch_demangler_crashes): Likewise.
1152 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1153 (usr_cmd_cris_dwarf2_cfi): Likewise.
1154 * csky-tdep.c (csky_debug): Likewise.
1155 * darwin-nat.c (enable_mach_exceptions): Likewise.
1156 * dcache.c (dcache_enabled_p): Likewise.
1157 * defs.h (info_verbose): Likewise.
1158 * demangle.c (demangle): Likewise.
1159 (asm_demangle): Likewise.
1160 * dwarf-index-cache.c (debug_index_cache): Likewise.
1161 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1162 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1163 * dwarf2read.c (check_physname): Likewise.
1164 (use_deprecated_index_sections): Likewise.
1165 (dwarf_always_disassemble): Likewise.
1166 * eval.c (overload_resolution): Likewise.
1167 * event-top.c (set_editing_cmd_var): Likewise.
1168 (exec_done_display_p): Likewise.
1169 * event-top.h (set_editing_cmd_var): Likewise.
1170 (exec_done_display_p): Likewise.
1171 * exec.c (write_files): Likewise.
1172 * fbsd-nat.c (debug_fbsd_lwp): Likewise
1173 (debug_fbsd_nat): Likewise.
1174 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1175 Likewise.
1176 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1177 <backtrace_past_entry> Likewise.
1178 * gdb-demangle.h (demangle): Likewise.
1179 (asm_demangle): Likewise.
1180 * gdb_bfd.c (bfd_sharing): Likewise.
1181 * gdbcore.h (write_files): Likewise.
1182 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1183 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1184 * gdbthread.h (print_thread_events): Likewise.
1185 * gdbtypes.c (opaque_type_resolution): Likewise.
1186 (strict_type_checking): Likewise.
1187 * gnu-nat.c (gnu_debug_flag): Likewise.
1188 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1189 * guile/scm-param.c (pascm_variable): Add boolval.
1190 (add_setshow_generic): Update.
1191 (pascm_param_value): Update.
1192 (pascm_set_param_value_x): Update.
1193 * hppa-tdep.c (hppa_debug): Change to bool..
1194 * infcall.c (may_call_functions_p): Likewise.
1195 (coerce_float_to_double_p): Likewise.
1196 (unwind_on_signal_p): Likewise.
1197 (unwind_on_terminating_exception_p): Likewise.
1198 * infcmd.c (startup_with_shell): Likewise.
1199 * inferior.c (print_inferior_events): Likewise.
1200 * inferior.h (startup_with_shell): Likewise.
1201 (print_inferior_events): Likewise.
1202 * infrun.c (step_stop_if_no_debug): Likewise.
1203 (detach_fork): Likewise.
1204 (debug_displaced): Likewise.
1205 (disable_randomization): Likewise.
1206 (non_stop): Likewise.
1207 (non_stop_1): Likewise.
1208 (observer_mode): Likewise.
1209 (observer_mode_1): Likewise.
1210 (set_observer_mode): Update.
1211 (sched_multi): Change to bool.
1212 * infrun.h (debug_displaced): Likewise.
1213 (sched_multi): Likewise.
1214 (step_stop_if_no_debug): Likewise.
1215 (non_stop): Likewise.
1216 (disable_randomization): Likewise.
1217 * linux-tdep.c (use_coredump_filter): Likewise.
1218 (dump_excluded_mappings): Likewise.
1219 * linux-thread-db.c (auto_load_thread_db): Likewise.
1220 (check_thread_db_on_load): Likewise.
1221 * main.c (captured_main_1): Update.
1222 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1223 xx2_opt, boolean_opt>: Change to bool.
1224 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1225 * maint.c (maintenance_profile_p): Likewise.
1226 (per_command_time): Likewise.
1227 (per_command_space): Likewise.
1228 (per_command_symtab): Likewise.
1229 * memattr.c (inaccessible_by_default): Likewise.
1230 * mi/mi-main.c (mi_async): Likewise.
1231 (mi_async_1): Likewise.
1232 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1233 * nat/fork-inferior.h (startup_with_shell): Likewise.
1234 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1235 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1236 * nios2-tdep.c (nios2_debug): Likewise.
1237 * or1k-tdep.c (or1k_debug): Likewise.
1238 * parse.c (parser_debug): Likewise.
1239 * parser-defs.h (parser_debug): Likewise.
1240 * printcmd.c (print_symbol_filename): Likewise.
1241 * proc-api.c (procfs_trace): Likewise.
1242 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1243 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1244 (set_parameter_value): Update.
1245 (add_setshow_generic): Update.
1246 * python/py-value.c (copy_py_bool_obj): Change argument from int*
1247 to bool*.
1248 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1249 int*.
1250 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1251 * record-btrace.c (record_btrace_target::store_registers): Update.
1252 * record-full.c (record_full_memory_query): Change to bool.
1253 (record_full_stop_at_limit): Likewise.
1254 * record-full.h (record_full_memory_query): Likewise.
1255 * remote-notif.c (notif_debug): Likewise.
1256 * remote-notif.h (notif_debug): Likewise.
1257 * remote.c (use_range_stepping): Likewise.
1258 (interrupt_on_connect): Likewise.
1259 (remote_break): Likewise.
1260 * ser-tcp.c (tcp_auto_retry): Likewise.
1261 * ser-unix.c (serial_hwflow): Likewise.
1262 * skip.c (debug_skip): Likewise.
1263 * solib-aix.c (solib_aix_debug): Likewise.
1264 * spu-tdep.c (spu_stop_on_load_p): Likewise.
1265 (spu_auto_flush_cache_p): Likewise.
1266 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1267 Likewise.
1268 (struct info_print_options) <quiet>: Likewise.
1269 * symfile-debug.c (debug_symfile): Likewise.
1270 * symfile.c (auto_solib_add): Likewise.
1271 (separate_debug_file_debug): Likewise.
1272 * symfile.h (auto_solib_add): Likewise.
1273 (separate_debug_file_debug): Likewise.
1274 * symtab.c (basenames_may_differ): Likewise.
1275 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1276 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1277 (struct info_types_options) <quiet>: Likewise.
1278 * symtab.h (demangle): Likewise.
1279 (basenames_may_differ): Likewise.
1280 * target-dcache.c (stack_cache_enabled_1): Likewise.
1281 (code_cache_enabled_1): Likewise.
1282 * target.c (trust_readonly): Likewise.
1283 (may_write_registers): Likewise.
1284 (may_write_memory): Likewise.
1285 (may_insert_breakpoints): Likewise.
1286 (may_insert_tracepoints): Likewise.
1287 (may_insert_fast_tracepoints): Likewise.
1288 (may_stop): Likewise.
1289 (auto_connect_native_target): Likewise.
1290 (target_stop_and_wait): Update.
1291 (target_async_permitted): Change to bool.
1292 (target_async_permitted_1): Likewise.
1293 (may_write_registers_1): Likewise.
1294 (may_write_memory_1): Likewise.
1295 (may_insert_breakpoints_1): Likewise.
1296 (may_insert_tracepoints_1): Likewise.
1297 (may_insert_fast_tracepoints_1): Likewise.
1298 (may_stop_1): Likewise.
1299 * target.h (target_async_permitted): Likewise.
1300 (may_write_registers): Likewise.
1301 (may_write_memory): Likewise.
1302 (may_insert_breakpoints): Likewise.
1303 (may_insert_tracepoints): Likewise.
1304 (may_insert_fast_tracepoints): Likewise.
1305 (may_stop): Likewise.
1306 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1307 (make_thread_apply_all_options_def_group): Change argument from int*
1308 to bool*.
1309 (thread_apply_all_command): Update.
1310 (print_thread_events): Change to bool.
1311 * top.c (confirm): Likewise.
1312 (command_editing_p): Likewise.
1313 (history_expansion_p): Likewise.
1314 (write_history_p): Likewise.
1315 (info_verbose): Likewise.
1316 * top.h (confirm): Likewise.
1317 (history_expansion_p): Likewise.
1318 * tracepoint.c (disconnected_tracing): Likewise.
1319 (circular_trace_buffer): Likewise.
1320 * typeprint.c (print_methods): Likewise.
1321 (print_typedefs): Likewise.
1322 * utils.c (debug_timestamp): Likewise.
1323 (sevenbit_strings): Likewise.
1324 (pagination_enabled): Likewise.
1325 * utils.h (sevenbit_strings): Likewise.
1326 (pagination_enabled): Likewise.
1327 * valops.c (overload_resolution): Likewise.
1328 * valprint.h (struct value_print_options) <prettyformat_arrays,
1329 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1330 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1331 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1332 Likewise.
1333 * windows-nat.c (new_console): Likewise.
1334 (cygwin_exceptions): Likewise.
1335 (new_group): Likewise.
1336 (debug_exec): Likewise.
1337 (debug_events): Likewise.
1338 (debug_memory): Likewise.
1339 (debug_exceptions): Likewise.
1340 (useshell): Likewise.
1341 * windows-tdep.c (maint_display_all_tib): Likewise.
1342 * xml-support.c (debug_xml): Likewise.
1343
1344 2019-09-17 Mike Gulick <mgulick@mathworks.com>
1345
1346 * source.c (prepare_path_for_appending): New function.
1347 (openp): Make use of new function.
1348 (find_and_open_source): Search for the compilation directory and
1349 source file as a relative path beneath the directory search path.
1350
1351 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
1352
1353 * source-cache.c (source_cache::get_line_charpos): Catch
1354 exceptions and return false, this matches the behaviour documented
1355 in the header file.
1356
1357 2019-09-17 Joel Brobecker <brobecker@adacore.com>
1358
1359 * ada-tasks.c (info_task): Remove quoting of the task's name.
1360
1361 2019-09-16 Christian Biesinger <cbiesinger@google.com>
1362
1363 * symfile.c (auto_solib_add): Replace comment with a reference
1364 to the header file.
1365
1366 2019-09-14 Christian Biesinger <cbiesinger@google.com>
1367
1368 * NEWS: Mention that gdb can now be compiled with Python 3
1369 on Windows.
1370
1371 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1372
1373 * maint.c (maint_print_section_data::maint_print_section_data):
1374 Force use of 'float log10 (float)' by casting the argument to
1375 float.
1376
1377 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1378
1379 * maint.c: Add 'cmath' include.
1380 (struct maint_print_section_data): New structure.
1381 (print_section_index): New function.
1382 (print_bfd_section_info): Add header comment, small whitespace
1383 cleanup, and update to call new print_section_index function.
1384 (print_objfile_section_info): Likewise.
1385 (maint_obj_section_from_bfd_section): New function.
1386 (print_bfd_section_info_maybe_relocated): New function.
1387 (maintenance_info_sections): Add header comment, always use
1388 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1389
1390 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1391
1392 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1393 inner scope, add check that the objfile has psymtabs before
1394 checking psymtabs_addrmap.
1395 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1396
1397 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1398
1399 * NEWS: Announce that Ada task names are now shown at more places,
1400 and between quotes (except in info task output).
1401 * gdb/ada-tasks.c (task_to_str): New function.
1402 (display_current_task_id): Call task_to_str.
1403 (task_command_1): Likewise.
1404 (print_ada_task_info): In non-mi mode, Properly align headers and data
1405 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1406
1407 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1408
1409 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1410 prstatus.pr_lwp.pr_info instead of making it up.
1411
1412 2019-09-11 Christian Biesinger <cbiesinger@google.com>
1413
1414 * auto-load.c (auto_load_expand_dir_vars): Update.
1415 * defs.h (gdb_datadir): Change to std::string.
1416 (python_libdir): Likewise.
1417 (relocate_gdb_directory): Change return type to std::string.
1418 * guile/guile.c (gdbscm_data_directory): Update.
1419 (initialize_scheme_side): Update.
1420 * jit.c (jit_reader_dir): Change to std::string.
1421 (jit_reader_load_command): Update.
1422 * main.c (gdb_datadir): Change to std::string.
1423 (python_libdir): Likewise.
1424 (set_gdb_data_directory): Update.
1425 (relocate_path): Change to return std::string.
1426 (relocate_gdb_directory): Change to return std::string.
1427 (relocate_gdbinit_path_maybe_in_datadir): Update.
1428 (captured_main_1): Update.
1429 * python/python.c (do_start_initialization): Update.
1430 * top.c (show_gdb_datadir): Update.
1431 * xml-syscall.c (xml_init_syscalls_info): Update.
1432 (init_syscalls_info): Update.
1433
1434 2019-09-11 Christian Biesinger <cbiesinger@google.com>
1435
1436 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1437 out of get_init_files.
1438 (get_init_files): Update.
1439
1440 2019-09-11 Christian Biesinger <cbiesinger@google.com>
1441
1442 * main.c (get_init_files): Change to use std::string.
1443 (captured_main_1): Update.
1444 (print_gdb_help): Update.
1445
1446 2019-09-11 Ali Tamur <tamur@google.com>
1447
1448 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1449 implementation.
1450
1451 2019-09-11 Christian Biesinger <cbiesinger@google.com>
1452
1453 * dbxread.c (read_dbx_symtab): Update.
1454 * dwarf2read.c (load_partial_dies): Update.
1455 * mdebugread.c (parse_partial_symbols): Update.
1456 (handle_psymbol_enumerators): Update.
1457 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1458 * psymtab.c (add_psymbol_to_bcache): Likewise.
1459 (add_psymbol_to_list): Likewise.
1460 * symtab.c (symbol_set_names): Likewise.
1461 * symtab.h (symbol_set_names): Likewise.
1462 * xcoffread.c (scan_xcoff_symtab): Update.
1463
1464 2019-09-11 Tom Tromey <tom@tromey.com>
1465
1466 * symfile-mem.c (symbol_file_add_from_memory): Use
1467 bfd_set_filename.
1468 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1469 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1470
1471 2019-09-10 Tom Tromey <tromey@adacore.com>
1472
1473 * dwarf-index-write.c (write_psymbols): Extend error message.
1474 (debug_names::insert): Add Ada code.
1475 (debug_names::write_psymbols): Remove Ada check.
1476 (debug_names) <m_string_obstack>: New member.
1477 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1478 (gdb_index_symbol_name_matcher::matches): Remove.
1479 (mapped_index_base::find_name_components_bounds): Add "lang"
1480 parameter.
1481 (mapped_index_base::build_name_components): Also split names
1482 according to Ada syntax.
1483 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
1484 type of "match_callback".
1485 (check_match, check_find_bounds_finds)
1486 (dw2_expand_symtabs_matching): Update.
1487 (dw2_debug_names_iterator): Add new constructor.
1488 (dw2_debug_names_map_matching_symbols): New function.
1489 (dw2_debug_names_expand_symtabs_matching): Update.
1490 (dwarf2_debug_names_functions): Use
1491 dw2_debug_names_map_matching_symbols.
1492
1493 2019-09-10 Tom Tromey <tromey@adacore.com>
1494
1495 * dwarf2read.c (dw2_get_file_names_reader): Add the
1496 CU's file name to the results.
1497
1498 2019-09-10 Tom Tromey <tromey@adacore.com>
1499
1500 * ada-lang.c (add_nonlocal_symbols): Combine calls to
1501 map_matching_symbols. Update.
1502 * dwarf2read.c (dw2_map_matching_symbols): Update.
1503 * psymtab.c (match_partial_symbol): Change type; update.
1504 (psym_map_matching_symbols): Likewise.
1505 * symfile-debug.c (debug_qf_map_matching_symbols): Change
1506 type; update.
1507 * symfile.h (struct quick_symbol_functions)
1508 <map_matching_symbols>: Change "name" to be a lookup_name_info.
1509 Remove "match".
1510
1511 2019-09-10 Tom Tromey <tromey@adacore.com>
1512
1513 * psymtab.c (map_block): Remove.
1514 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1515 * symtab.c (iterate_over_symbols_terminated): New function.
1516 * symtab.c (iterate_over_symbols_terminated): Declare.
1517
1518 2019-09-10 Tom Tromey <tromey@adacore.com>
1519
1520 * ada-lang.c (ada_iterate_over_symbols): Return bool.
1521 * language.h (struct language_defn) <la_iterate_over_symbols>:
1522 Return bool.
1523 * symtab.c (iterate_over_symbols): Return bool.
1524 * symtab.h (iterate_over_symbols): Return bool.
1525
1526 2019-09-10 Tom Tromey <tromey@adacore.com>
1527
1528 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1529 (add_nonlocal_symbols): Update.
1530 * dwarf2read.c (dw2_map_matching_symbols): Change type.
1531 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1532 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1533 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1534 Change type of "callback". Remove "data".
1535
1536
1537 2019-09-09 Ali Tamur <tamur@google.com>
1538
1539 * dwarf2read.c (comp_unit_head): Update comment.
1540 (dwarf2_dwo_name): New function declaration.
1541 (dwarf_unit_type_name): New function declaration.
1542 (read_comp_unit_head): Add support for new compilation units,
1543 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1544 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1545 (currently named as "signature") in their header. Also clarify error
1546 messages.
1547 (lookup_dwo_id): New function. Returns the dwo id of the given
1548 compile unit.
1549 (lookup_dwo_unit): Use the new lookup_dwo_id function.
1550 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1551 functions.
1552 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1553 (dwarf2_dwo_name): Get the dwo name if present.
1554 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1555 purposes.
1556
1557 2019-09-09 Tom Tromey <tom@tromey.com>
1558
1559 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1560
1561 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1562
1563 * python/python.c (do_start_initialization): Make progname_copy static,
1564 to avoid a leak report.
1565
1566 2019-09-08 Tom Tromey <tom@tromey.com>
1567
1568 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1569
1570 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
1571
1572 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1573 Change type to gdb::optional<block_enum>.
1574 (dw2_symtab_iter_init): Change block_index parameter type
1575 to gdb::optional<block_enum>.
1576 (dw2_lookup_symbol): Change block_index parameter
1577 type to block_enum.c
1578 (dw2_debug_names_lookup_symbol): Likewise.
1579 * psymtab.c (psym_lookup_symbol): Likewise.
1580 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1581 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1582 Likewise.
1583
1584 2019-09-06 Christian Biesinger <cbiesinger@google.com>
1585
1586 * defs.h (relocate_gdb_directory): Change int to bool in
1587 signature and rename flag to relocatable.
1588 * main.c (relocate_path): Likewise.
1589 (relocate_gdb_directory): Likewise.
1590
1591 2019-09-06 Alan Modra <amodra@gmail.com>
1592
1593 * coffread.c (coff_symfile_read): Constify filename variable.
1594 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1595 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1596 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1597 * solib.c (reload_shared_libraries_1): Likewise.
1598 * symfile.c (reread_symbols): Likewise.
1599 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1600 * solib-darwin.c (darwin_bfd_open): Likewise.
1601 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1602
1603 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
1604
1605 * psymtab.c (print_partial_symbols): Handle missing domain_enum
1606 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1607
1608 2019-09-03 Tom Tromey <tromey@adacore.com>
1609
1610 * ada-valprint.c (ada_val_print_num): Don't recurse for range
1611 types.
1612 (has_negatives): Unbias a range type bound.
1613 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1614 * gdbtypes.c (operator==): Handle new field.
1615 (create_range_type): Add "bias" parameter.
1616 (create_static_range_type, resolve_dynamic_range): Update.
1617 * gdbtypes.h (struct range_bounds) <bias>: New member.
1618 (create_range_type): Add bias parameter.
1619 * printcmd.c (print_scalar_formatted): Unbias range types.
1620 * value.c (unpack_long): Unbias range types.
1621 (pack_long): Bias range types.
1622
1623 2019-09-02 Alan Hayward <alan.hayward@arm.com>
1624
1625 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1626 probe arguments.
1627
1628 2019-09-02 Alan Hayward <alan.hayward@arm.com>
1629
1630 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1631 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1632 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1633 (compile_probe_arg): Likewise.
1634 * probe.h (get_argument_count): Likewise.
1635 * solib-svr4.c (solib_event_probe_action): Likewise.
1636 * stap-probe.c (stap_probe::get_argument_count): Likewise.
1637
1638 2019-09-02 Alan Hayward <alan.hayward@arm.com>
1639
1640 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1641 code to here...
1642 (svr4_create_solib_event_breakpoints): ...from here.
1643
1644 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
1645
1646 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1647 suffix from warning message.
1648
1649 2019-08-30 Tom Tromey <tom@tromey.com>
1650
1651 * tui/tui-winsource.h (struct tui_source_window_base)
1652 <refresh_all>: Don't declare.
1653 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1654 Remove.
1655 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1656 tui_show_locator_content.
1657 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1658 declare.
1659 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1660 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1661 declare.
1662
1663 2019-08-30 Tom Tromey <tom@tromey.com>
1664
1665 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1666
1667 2019-08-30 Tom Tromey <tom@tromey.com>
1668
1669 * tui/tui-stack.c (_initialize_tui_stack): Move later.
1670 Remove unnecessary forward declarations.
1671
1672 2019-08-30 Tom Tromey <tom@tromey.com>
1673
1674 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1675 rerender.
1676 (tui_update_locator_fullname, tui_show_frame_info): Don't call
1677 tui_show_locator_content.
1678
1679 2019-08-30 Tom Tromey <tom@tromey.com>
1680
1681 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
1682 (tui_locator_window::rerender): Rewrite using body of previous
1683 tui_show_locator_content.
1684
1685 2019-08-30 Tom Tromey <tom@tromey.com>
1686
1687 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1688 set_locator_fullname>: New methods.
1689 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1690 Rename from tui_set_locator_fullname.
1691 (tui_locator_window::set_locator_info): Rename from
1692 tui_set_locator_info. Return bool.
1693 (tui_update_locator_fullname, tui_show_frame_info): Update.
1694
1695 2019-08-30 Tom Tromey <tom@tromey.com>
1696
1697 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1698
1699 2019-08-30 Tom Tromey <tom@tromey.com>
1700
1701 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1702 call touchwin.
1703
1704 2019-08-30 Tom Tromey <tom@tromey.com>
1705
1706 * tui/tui-wingeneral.c (box_win): Assume win_info and
1707 win_info->handle cannot be NULL.
1708
1709 2019-08-30 Tom Tromey <tom@tromey.com>
1710
1711 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1712 refresh_window>: Declare.
1713 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1714 resize.
1715 (tui_data_item_window::rerender): Rename from
1716 tui_display_register.
1717 (tui_data_item_window::refresh_window): New method.
1718 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1719 no-op.
1720
1721 2019-08-30 Tom Tromey <tom@tromey.com>
1722
1723 * tui/tui-regs.h (struct tui_data_window) <regs_content,
1724 regs_column_count, current_group>: Move later. Now private.
1725 <get_current_group>: New method.
1726 * tui/tui-regs.c (tui_reg_command): Update.
1727 * tui/tui-layout.c (tui_set_layout): Update.
1728
1729 2019-08-30 Tom Tromey <tom@tromey.com>
1730
1731 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1732 (tui_data_window::rerender): Don't call
1733 check_and_display_highlight_if_needed.
1734 (tui_data_window::refresh_all): Remove call to
1735 erase_data_content.
1736
1737 2019-08-30 Tom Tromey <tom@tromey.com>
1738
1739 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1740 (tui_data_window::display_registers_from)
1741 (tui_data_window::display_reg_element_at_line)
1742 (tui_data_window::display_registers_from_line): Remove checks of
1743 "empty".
1744
1745 2019-08-30 Tom Tromey <tom@tromey.com>
1746
1747 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1748 Don't declare.
1749 * tui/tui-regs.c (tui_data_window::show_registers): Call
1750 rerender.
1751 (tui_data_window::rerender): Rename from display_all_data.
1752 (tui_data_window::rerender): Remove old implementation.
1753
1754 2019-08-30 Tom Tromey <tom@tromey.com>
1755
1756 * tui/tui-regs.c (tui_data_window::display_all_data): Change
1757 text.
1758 * tui/tui-data.h (NO_DATA_STRING): Remove define.
1759
1760 2019-08-29 Bernhard Wodok <barto@gmx.net>
1761 Sergio Durigan Junior <sergiodj@redhat.com>
1762
1763 PR win32/24284
1764 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1765
1766 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
1767
1768 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1769 when searching for types.
1770
1771 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
1772
1773 * f-lang.c (f_language_defn): Use f_print_typedef.
1774 * f-lang.h (f_print_typedef): Declare.
1775 * f-typeprint.c (f_print_typedef): Define.
1776
1777 2019-08-27 Christian Biesinger <cbiesinger@google.com>
1778
1779 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1780
1781 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
1782
1783 * cli/cli-utils.c (info_print_options_defs): Delete.
1784 (make_info_print_options_def_group): Delete.
1785 (extract_info_print_options): Delete.
1786 (info_print_command_completer): Delete.
1787 (info_print_args_help): Add extra parameter, and optionally
1788 include text about -n flag.
1789 * cli/cli-utils.h (struct info_print_options): Delete.
1790 (extract_info_print_options): Delete declaration.
1791 (info_print_command_completer): Delete declaration.
1792 (info_print_args_help): Add extra parameter, extend header
1793 comment.
1794 * python/python.c (gdbpy_rbreak): Pass additional parameter to
1795 search_symbols.
1796 * stack.c (struct info_print_options): New type.
1797 (info_print_options_defs): New file scoped variable.
1798 (make_info_print_options_def_group): New static function.
1799 (info_print_command_completer): New static function.
1800 (info_locals_command): Update to use new local functions.
1801 (info_args_command): Likewise.
1802 (_initialize_stack): Add extra parameter to calls to
1803 info_print_args_help.
1804 * symtab.c (search_symbols): Add extra parameter, use this to
1805 possibly excluse non-debug symbols.
1806 (symtab_symbol_info): Add extra parameter, which is passed on to
1807 search_symbols.
1808 (struct info_print_options): New type.
1809 (info_print_options_defs): New file scoped variable.
1810 (make_info_print_options_def_group): New static function.
1811 (info_print_command_completer): New static function.
1812 (info_variables_command): Update to use local functions, and pass
1813 extra parameter through to symtab_symbol_info.
1814 (info_functions_command): Likewise.
1815 (info_types_command): Pass additional argument through to
1816 symtab_symbol_info.
1817 (rbreak_command): Pass extra argument to search_symbols.
1818 (_initialize_symtab): Add extra arguments for calls to
1819 info_print_args_help, and update help text for 'info variables',
1820 'whereis', and 'info functions' commands.
1821 * symtab.h (search_symbols): Add extra argument to declaration.
1822 * NEWS: Mention new flags.
1823
1824 2019-08-26 Christian Biesinger <cbiesinger@google.com>
1825
1826 * symtab.c (lookup_static_symbol): Call the new function (and move
1827 it down to be next to lookup_global_symbol).
1828 (struct global_sym_lookup_data): Add block_enum member and rename to...
1829 (struct global_or_static_sym_lookup_data): ...this.
1830 (lookup_symbol_global_iterator_cb): Pass block_index instead of
1831 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1832 (lookup_symbol_global_or_static_iterator_cb): ...this.
1833 (lookup_global_or_static_symbol): New function.
1834 (lookup_global_symbol): Call new function.
1835
1836 2019-08-26 Tom de Vries <tdevries@suse.de>
1837
1838 PR c++/24852
1839 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1840 when pc_probe.prob == NULL.
1841
1842 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
1843
1844 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1845 variable symbol_linkage to symbol_linkage_.
1846
1847 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
1848
1849 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1850 represent whether the symbol is static, dynamic, or we don't
1851 know.
1852
1853 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
1854
1855 * gdb/rx-tdep.c (rx_register_names): New.
1856 (rx_register_name): Delete.
1857 (rx_psw_type): Delete.
1858 (rx_fpsw_type): Delete.
1859 (rx_register_type): Delete.
1860 (rx_gdbarch_init): Convert target-descriptions.
1861 (_initialize_rx_tdep): Add initialize_tdesc_rx.
1862 * gdb/features/Makefile: Add rx.xml.
1863 * gdb/features/rx.xml: New.
1864 * gdb/features/rx.c: Generated.
1865 * gdb/NEWS: Mention target description support.
1866
1867 2019-08-22 Christian Biesinger <cbiesinger@google.com>
1868
1869 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1870 *slot_ptr.
1871
1872 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
1873
1874 * configure.ac: Don't check for 'dlfcn.h' (moved to
1875 gdbsupport/common.m4).
1876 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1877 'gdbsupport/'.
1878 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1879 * compile/compile-c-support.c: Include
1880 'gdbsupport/gdb-dlfcn.h'.
1881 * gdbsupport/common.m4: Check for 'dlfcn.h'.
1882 * gdb-dlfcn.c: Move to...
1883 * gdbsupport/gdb-dlfcn.c: ... here.
1884 * gdb-dlfcn.h: Move to...
1885 * gdbsupport/gdb-dlfcn.h: ... here.
1886
1887 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
1888
1889 * nios2-tdep.c (struct reg_value): Improve comments. Make
1890 the offset field signed.
1891
1892 2019-08-22 Christian Biesinger <cbiesinger@google.com>
1893
1894 * python/lib/gdb/__init__.py (_execute_file): New function.
1895 * python/python.c (python_run_simple_file): Call gdb._execute_file
1896 on Windows.
1897
1898 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
1899
1900 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1901 all uses as this was never set to anything but a zero value.
1902
1903 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
1904
1905 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1906
1907 2019-08-21 Christian Biesinger <cbiesinger@google.com>
1908
1909 * tui/tui-data.h (tui_gen_win_info): Add an =default
1910 move constructor, required by some GCC versions.
1911
1912 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
1913
1914 * go32-nat.c (go32_sysinfo): Add hygon_p.
1915
1916 2019-08-20 Tom Tromey <tom@tromey.com>
1917
1918 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1919 line_from_reg_element_no, first_reg_element_no_inline,
1920 display_all_data, delete_data_content_windows,
1921 erase_data_content>: Now private.
1922
1923 2019-08-20 Tom Tromey <tom@tromey.com>
1924
1925 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1926 (tui_unhighlight_win, tui_highlight_win)
1927 (tui_win_info::make_window): Update.
1928 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1929
1930 2019-08-20 Tom Tromey <tom@tromey.com>
1931
1932 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1933 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1934 (MAX_PID_WIDTH): Move to tui-stack.c.
1935 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1936 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1937 (MAX_PID_WIDTH): Move from tui-data.h.
1938
1939 2019-08-20 Tom Tromey <tom@tromey.com>
1940
1941 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1942 * tui/tui-wingeneral.c (box_win): Change type of win_info.
1943 (box_win): Update.
1944 (tui_gen_win_info::make_window): Rename from tui_make_window.
1945 (tui_win_info::make_window): New method.
1946 (tui_gen_win_info::make_visible): Update.
1947 * tui/tui-source.c (tui_source_window::set_contents): Update.
1948 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1949 (tui_data_window::display_registers_from): Update.
1950 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1951 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1952 Declare.
1953 <can_box>: Remove.
1954 <title>: Remove.
1955 (struct tui_win_info) <make_window>: Declare.
1956 <can_box>: Now virtual.
1957 <title>: New member.
1958 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1959 * tui/tui-command.c (tui_cmd_window::resize): Update.
1960
1961 2019-08-20 Tom Tromey <tom@tromey.com>
1962
1963 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1964 * tui/tui-regs.c (tui_data_window::show_registers): Update.
1965 (tui_data_window::check_register_values): Update.
1966
1967 2019-08-20 Tom Tromey <tom@tromey.com>
1968
1969 * tui/tui-regs.h (struct tui_data_window): Use
1970 DISABLE_COPY_AND_ASSIGN.
1971 <regs_content>: Change type, removing unique_ptr.
1972 <tui_data_window>: Add move constructor.
1973 * tui/tui-regs.c (tui_data_window::show_registers)
1974 (tui_data_window::show_register_group)
1975 (tui_data_window::display_registers_from)
1976 (tui_data_window::display_registers_from)
1977 (tui_data_window::first_data_item_displayed)
1978 (tui_data_window::delete_data_content_windows)
1979 (tui_data_window::rerender, tui_data_window::refresh_window)
1980 (tui_data_window::check_register_values): Update.
1981
1982 2019-08-20 Tom Tromey <tom@tromey.com>
1983
1984 * tui/tui-regs.h (struct tui_data_window) <show_registers,
1985 show_register_group>: Declare.
1986 (tui_show_register_group): Don't declare.
1987 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1988 tui_show_registers.
1989 (tui_data_window::show_register_group): Rename from
1990 tui_show_register_group.
1991 (tui_data_window::check_register_values, tui_reg_command):
1992 Update.
1993 * tui/tui-layout.c (tui_set_layout): Update.
1994
1995 2019-08-20 Tom Tromey <tom@tromey.com>
1996
1997 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1998 Declare.
1999 (tui_check_register_values): Don't declare.
2000 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2001 from tui_check_register_values.
2002 * tui/tui-hooks.c (tui_register_changed): Update.
2003
2004 2019-08-20 Tom Tromey <tom@tromey.com>
2005
2006 * tui/tui-regs.c (tui_reg_layout): Move later.
2007 (tui_show_registers): Don't enable TUI mode or change layout.
2008
2009 2019-08-20 Tom Tromey <tom@tromey.com>
2010
2011 * tui/tui-regs.h (struct tui_data_item_window)
2012 <~tui_data_item_window>: Remove.
2013 <content>: Now a unique_xmalloc_ptr.
2014 * tui/tui-regs.c (tui_register_format): Return a
2015 unique_xmalloc_ptr.
2016 (tui_get_register): Update.
2017 (~tui_data_item_window): Remove.
2018 (tui_data_window::display_registers_from, tui_display_register):
2019 Update.
2020 * tui/tui-io.h (tui_expand_tabs): Update.
2021 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2022 Remove "col" parameter.
2023
2024 2019-08-20 Tom Tromey <tom@tromey.com>
2025
2026 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2027 field.
2028 * tui/tui-regs.c (~tui_data_item_window): Update.
2029
2030 2019-08-20 Tom Tromey <tom@tromey.com>
2031
2032 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2033 earlier.
2034
2035 2019-08-20 Tom Tromey <tom@tromey.com>
2036
2037 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2038
2039 2019-08-20 Tom Tromey <tom@tromey.com>
2040
2041 * tui/tui-source.h (struct tui_source_window): Update.
2042 * tui/tui-regs.c (tui_show_registers): Update.
2043 * tui/tui-disasm.h (struct tui_disasm_window): Update.
2044 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2045 (NO_REGS_STRING): Remove defines.
2046
2047 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
2048
2049 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2050 unnecessary thread walk if remote doesn't support the packet.
2051
2052 2019-08-19 Tom Tromey <tromey@adacore.com>
2053
2054 * python/py-value.c (value_has_field): Fix indentation.
2055
2056 2019-08-19 Tom Tromey <tromey@adacore.com>
2057
2058 * printcmd.c (do_one_display, info_display_command): Update.
2059 * block.h (contained_in): Return bool. Add allow_nested
2060 parameter.
2061 * block.c (contained_in): Return bool. Add allow_nested
2062 parameter.
2063
2064 2019-08-19 Tom Tromey <tom@tromey.com>
2065
2066 * configure: Rebuild.
2067 * configure.ac: Disallow the combination of -static-libstdc++ and
2068 source highlight.
2069 * source-cache.c (get_language_name): Handle rust.
2070 (source_cache::get_source_lines): Ignore highlighting exceptions.
2071
2072 2019-08-16 Tom Tromey <tom@tromey.com>
2073
2074 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2075 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2076 (struct tui_source_window_base) <make_visible, refresh_window,
2077 resize>: Remove methods.
2078 <execution_info>: Remove field.
2079 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2080 (tui_show_source_line, tui_source_window_base)
2081 (~tui_source_window_base): Update.
2082 (tui_source_window_base::resize)
2083 (tui_source_window_base::make_visible)
2084 (tui_source_window_base::refresh_window): Remove.
2085 (tui_source_window_base::update_exec_info): Update.
2086 * tui/tui-source.c (tui_source_window::set_contents): Update.
2087 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2088
2089 2019-08-16 Tom Tromey <tom@tromey.com>
2090
2091 * tui/tui-hooks.c (tui_remove_hooks): Don't set
2092 deprecated_query_hook.
2093
2094 2019-08-16 Tom Tromey <tom@tromey.com>
2095
2096 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2097 (tui_update_source_windows_with_line): Update.
2098 * tui/tui-source.h (struct tui_source_window)
2099 <show_symtab_source>: Declare.
2100 (tui_show_symtab_source): Don't declare.
2101 * tui/tui-source.c (tui_show_symtab_source): Rename from
2102 tui_show_symtab_source.
2103
2104 2019-08-16 Tom Tromey <tom@tromey.com>
2105
2106 * tui/tui-winsource.h (struct tui_source_window_base)
2107 <set_contents>: Declare.
2108 * tui/tui-winsource.c
2109 (tui_source_window_base::update_source_window_as_is): Update.
2110 * tui/tui-source.h (struct tui_source_window) <set_contents>:
2111 Declare.
2112 (tui_set_source_content): Don't declare.
2113 * tui/tui-source.c (tui_source_window::set_contents): Rename from
2114 tui_set_source_content.
2115 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2116 Declare.
2117 (tui_set_disassem_content): Don't declare.
2118 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2119 tui_set_disassem_content.
2120
2121 2019-08-16 Tom Tromey <tom@tromey.com>
2122
2123 * tui/tui-winsource.h (struct tui_source_window_base)
2124 <update_breakpoint_info>: Declare.
2125 (tui_update_breakpoint_info): Don't declare.
2126 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2127 (tui_update_all_breakpoint_info): Update.
2128 (tui_source_window_base::update_breakpoint_info): Rename from
2129 tui_update_breakpoint_info.
2130 (tui_source_window_base::update_exec_info): Update.
2131
2132 2019-08-16 Tom Tromey <tom@tromey.com>
2133
2134 * tui/tui-winsource.h (struct tui_source_window_base)
2135 <update_source_window>: Declare.
2136 (tui_update_source_window): Don't declare.
2137 * tui/tui-winsource.c
2138 (tui_source_window_base::update_source_window): Rename from
2139 tui_update_source_window.
2140 (tui_source_window_base::rerender): Update.
2141 * tui/tui-source.c (tui_source_window::maybe_update): Update.
2142 * tui/tui-disasm.c (tui_show_disassem)
2143 (tui_show_disassem_and_update_source)
2144 (tui_disasm_window::maybe_update): Update.
2145
2146 2019-08-16 Tom Tromey <tom@tromey.com>
2147
2148 * tui/tui-winsource.h (struct tui_source_window_base)
2149 <update_source_window_as_is>: Declare.
2150 (tui_update_source_window_as_is): Don't declare.
2151 * tui/tui-winsource.c (tui_update_source_window): Update
2152 (tui_source_window_base::update_source_window_as_is): Rename from
2153 tui_update_source_window_as_is.
2154 (tui_source_window_base::refill): Update.
2155 * tui/tui-source.c (tui_show_symtab_source): Update.
2156 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2157 Update.
2158
2159 2019-08-16 Tom Tromey <tom@tromey.com>
2160
2161 * tui/tui-winsource.h (tui_update_source_window)
2162 (tui_update_source_window_as_is): Remove "noerror" parameter.
2163 * tui/tui-winsource.c (tui_update_source_window)
2164 (tui_update_source_window_as_is): Remove "noerror" parameter.
2165 (tui_update_source_windows_with_addr)
2166 (tui_update_source_windows_with_line)
2167 (tui_source_window_base::rerender)
2168 (tui_source_window_base::refill): Update.
2169 * tui/tui-source.h (tui_set_source_content)
2170 (tui_show_symtab_source): Remove "noerror" parameter.
2171 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2172 parameter.
2173 (tui_show_symtab_source): Likewise.
2174 (tui_source_window::maybe_update): Update.
2175 * tui/tui-disasm.c (tui_show_disassem)
2176 (tui_show_disassem_and_update_source)
2177 (tui_disasm_window::do_scroll_vertical)
2178 (tui_disasm_window::maybe_update): Update.
2179
2180 2019-08-16 Tom Tromey <tom@tromey.com>
2181
2182 * tui/tui.c (tui_is_window_visible): Update.
2183 * tui/tui-wingeneral.c (tui_make_window)
2184 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2185 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2186 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2187 (tui_set_win_height_command, parse_scrolling_args): Update.
2188 * tui/tui-source.c (tui_source_window::style_changed): Update.
2189 * tui/tui-regs.c (tui_show_registers)
2190 (tui_data_window::first_data_item_displayed)
2191 (tui_data_window::delete_data_content_windows)
2192 (tui_check_register_values, tui_reg_command): Update.
2193 * tui/tui-disasm.c (tui_show_disassem): Update.
2194 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2195 method.
2196 <is_visible>: Remove field.
2197 * tui/tui-data.c (tui_next_win, tui_prev_win)
2198 (tui_delete_invisible_windows): Update.
2199
2200 2019-08-16 Tom Tromey <tom@tromey.com>
2201
2202 * tui/tui-winsource.h (struct tui_source_window_base)
2203 <m_has_locator>: Remove.
2204 * tui/tui-layout.c (show_source_disasm_command, show_data)
2205 (show_source_or_disasm_and_command): Update.
2206
2207 2019-08-16 Alan Hayward <alan.hayward@arm.com>
2208
2209 * NEWS (Other MI changes): New subsection.
2210 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2211 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2212 * arch-utils.c (default_get_pc_address_flags): New function.
2213 * arch-utils.h (default_get_pc_address_flags): New declaration.
2214 * gdbarch.sh: Add get_pc_address_flags.
2215 * gdbarch.c: Regenerate.
2216 * gdbarch.h: Likewise.
2217 * stack.c (print_pc): New function.
2218 (print_frame_info) (print_frame): Call print_pc.
2219
2220 2019-08-16 Tom de Vries <tdevries@suse.de>
2221
2222 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2223 print_objfile_section_info.
2224
2225 2019-08-15 Tom Tromey <tom@tromey.com>
2226
2227 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2228 calling update_cmdwin_start_line.
2229 * tui/tui-winsource.h (struct tui_source_window_base)
2230 <do_make_visible_with_new_height, set_new_height>: Don't declare.
2231 <rerender>: Declare.
2232 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2233 Call rerender.
2234 (tui_source_window_base::set_new_height): Remove.
2235 (tui_source_window_base::rerender): Rename from
2236 do_make_visible_with_new_height.
2237 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2238 resize method.
2239 (tui_win_info::make_invisible_and_set_new_height)
2240 (tui_win_info::make_visible_with_new_height): Remove.
2241 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2242 Declare.
2243 * tui/tui-stack.c (tui_locator_window::rerender): New method.
2244 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2245 do_make_visible_with_new_height>: Don't declare.
2246 <rerender>: Declare.
2247 * tui/tui-regs.c (tui_data_window::rerender): Rename from
2248 set_new_height.
2249 (tui_data_window::do_make_visible_with_new_height): Remove.
2250 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2251 call tui_show_locator_content.
2252 (tui_gen_win_info::resize): Call rerender.
2253 (show_source_or_disasm_and_command): Don't call
2254 tui_show_locator_content.
2255 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2256 method.
2257 (struct tui_win_info) <rerender>: Declare.
2258 <set_new_height, make_invisible_and_set_new_height,
2259 make_visible_with_new_height>: Don't declare.
2260 * tui/tui-data.c (tui_win_list::rerender): New method.
2261 * tui/tui-command.h (struct tui_cmd_window)
2262 <do_make_visible_with_new_height>: Don't declare.
2263 * tui/tui-command.c
2264 (tui_cmd_window::do_make_visible_with_new_height): Remove.
2265
2266 2019-08-15 Tom Tromey <tromey@adacore.com>
2267
2268 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2269 * ada-lang.c (ada_enum_name): Likewise.
2270
2271 2019-08-15 Christian Biesinger <cbiesinger@google.com>
2272
2273 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2274 leading underscore.
2275 (GdbOutputErrorFile): Likewise.
2276 (global scope): Adjust constructor calls to GdbOutput{,Error}File
2277 accordingly.
2278 (execute_unwinders): Rename to have a leading underscore.
2279 (auto_load_packages): Likewise.
2280 (global scope): Adjust call to auto_load_packages accordingly.
2281 (GdbSetPythonDirectory): Likewise.
2282 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2283 instead of execute_unwinders.
2284
2285 2019-08-15 Tom Tromey <tom@tromey.com>
2286
2287 * tui/tui-layout.c (show_layout, show_source_disasm_command)
2288 (show_data): Don't change window visibility.
2289 (tui_gen_win_info::resize): Remove special case for command
2290 window. Use wresize, when available.
2291 (show_source_or_disasm_and_command): Don't change window
2292 visibility.
2293 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2294 <make_visible>: New method.
2295 * tui/tui-command.c (tui_cmd_window::resize): New method.
2296
2297 2019-08-15 Tom Tromey <tom@tromey.com>
2298
2299 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2300 (struct tui_source_windows): New.
2301 * tui/tui-winsource.c (tui_display_main): Update.
2302 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2303 (new_height_ok, parse_scrolling_args): Update.
2304 * tui/tui-layout.c (show_layout, show_data): Update.
2305 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2306 (tui_add_to_source_windows): Don't declare.
2307 * tui/tui-data.c (source_windows, tui_source_windows)
2308 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2309
2310 2019-08-15 Tom Tromey <tom@tromey.com>
2311
2312 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2313 Rename from reset.
2314 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2315 * tui/tui-layout.c (show_source_disasm_command, show_data):
2316 Update.
2317 (tui_gen_win_info::resize): Rename.
2318 (show_source_or_disasm_and_command): Update.
2319 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2320 reset.
2321
2322 2019-08-15 Tom Tromey <tom@tromey.com>
2323
2324 * tui/tui-stack.c (tui_initialize_static_data): Remove.
2325 * tui/tui-interp.c (tui_interp::init): Don't call
2326 tui_initialize_static_data.
2327 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2328
2329 2019-08-15 Tom Tromey <tom@tromey.com>
2330
2331 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2332 examine tui_win_list.
2333
2334 2019-08-15 Tom Tromey <tom@tromey.com>
2335
2336 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2337 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2338 tui_clear_source_content.
2339 (tui_clear_source_content): Remove.
2340 (tui_source_window_base::do_erase_source_content): Hoist call to
2341 content.clear().
2342 * tui/tui-stack.c (tui_show_frame_info): Don't call
2343 tui_clear_source_content.
2344
2345 2019-08-15 Tom Tromey <tom@tromey.com>
2346
2347 * tui/tui-winsource.h (struct tui_source_window_base)
2348 <do_erase_source_content>: New method.
2349 <erase_source_content>: New method.
2350 (tui_erase_source_content): Don't declare.
2351 * tui/tui-winsource.c (tui_clear_source_content): Update.
2352 (tui_source_window_base::do_erase_source_content): Rename from
2353 tui_erase_source_content.
2354 (tui_source_window_base::show_source_content): Update.
2355 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2356 * tui/tui-source.h (struct tui_source_window)
2357 <erase_source_content>: New method.
2358 * tui/tui-disasm.h (struct tui_disasm_window)
2359 <erase_source_content>: New method.
2360
2361 2019-08-15 Tom Tromey <tom@tromey.com>
2362
2363 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2364 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2365 constructor.
2366 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2367 * tui/tui-source.c (tui_set_source_content): Update.
2368 * tui/tui-disasm.c (tui_set_disassem_content): Update.
2369
2370 2019-08-15 Tom Tromey <tom@tromey.com>
2371
2372 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2373 * tui/tui-winsource.c (tui_line_is_displayed): Move to
2374 tui-source.c.
2375 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2376 Declare.
2377 * tui/tui-source.c (tui_source_window::line_is_displayed): New
2378 method.
2379 (tui_source_window::maybe_update): Update.
2380
2381 2019-08-15 Tom Tromey <tom@tromey.com>
2382
2383 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2384 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2385 tui-disasm.c.
2386 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2387 Declare.
2388 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2389 method.
2390 (tui_disasm_window::maybe_update): Update.
2391
2392 2019-08-15 Tom Tromey <tom@tromey.com>
2393
2394 * tui/tui-winsource.h (struct tui_source_window_base)
2395 <maybe_update>: Declare.
2396 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2397 method.
2398 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2399 Declare.
2400 * tui/tui-source.c (tui_source_window::maybe_update): New method.
2401 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2402 Declare.
2403 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2404
2405 2019-08-15 Tom Tromey <tom@tromey.com>
2406
2407 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2408
2409 2019-08-15 Tom Tromey <tom@tromey.com>
2410
2411 * tui/tui-wingeneral.c: Include tui-stack.h.
2412 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2413 (struct tui_locator_window): Move from tui-data.h.
2414 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2415 (tui_initialize_static_data): Move from tui-data.c.
2416 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2417 (struct tui_locator_window): Move to tui-stack.c.
2418 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2419 (tui_initialize_static_data): Move to tui-stack.c.
2420
2421 2019-08-15 Tom Tromey <tom@tromey.com>
2422
2423 * tui/tui-layout.c (show_source_disasm_command)
2424 (show_source_or_disasm_and_command): Use make_visible method, not
2425 tui_make_window.
2426 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2427 Remove.
2428
2429 2019-08-15 Tom Tromey <tom@tromey.com>
2430
2431 * tui/tui-wingeneral.h (tui_make_window): Update.
2432 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2433 parameter.
2434 (tui_gen_win_info::make_visible): Update.
2435 * tui/tui-regs.c (tui_data_window::display_registers_from):
2436 Update.
2437 * tui/tui-layout.c (show_source_disasm_command)
2438 (show_source_or_disasm_and_command): Update.
2439 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2440 (enum tui_box): Remove.
2441 (struct tui_win_info) <can_box>: New method.
2442 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2443 method.
2444
2445 2019-08-15 Tom de Vries <tdevries@suse.de>
2446
2447 * linux-nat-trad.c: Include gdbarch.h.
2448
2449 2019-08-14 Alan Hayward <alan.hayward@arm.com>
2450
2451 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2452 register sizes.
2453
2454 2019-08-14 Tom Tromey <tromey@adacore.com>
2455
2456 * darwin-nat.c: Include gdbarch.h.
2457 * darwin-nat-info.c: Include gdbarch.h.
2458
2459 2019-08-13 Tom Tromey <tom@tromey.com>
2460
2461 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2462 Remove.
2463 * tui/tui-data.c (tui_initialize_static_data): Update.
2464
2465 2019-08-13 Tom Tromey <tom@tromey.com>
2466
2467 * tui/tui-winsource.h (struct tui_exec_info_window)
2468 <~tui_exec_info_window, maybe_allocate_content, get_content,
2469 m_content>: Remove.
2470 (struct tui_source_window_base) <set_exec_info_content,
2471 show_exec_info_content>: Don't declare.
2472 * tui/tui-winsource.c
2473 (tui_exec_info_window::maybe_allocate_content): Remove.
2474 (tui_source_window_base::update_exec_info): Rename from
2475 set_exec_info_content.
2476 (tui_source_window_base::show_exec_info_content)
2477 (tui_source_window_base::update_exec_info): Remove.
2478
2479 2019-08-13 Tom Tromey <tom@tromey.com>
2480
2481 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2482 declare.
2483 * tui/tui-winsource.c (tui_update_source_window_as_is)
2484 (tui_update_source_windows_with_addr, tui_erase_source_content):
2485 Update.
2486 (tui_clear_exec_info_content): Remove.
2487
2488 2019-08-13 Tom Tromey <tom@tromey.com>
2489
2490 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2491 declare.
2492 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2493 call tui_erase_exec_info_content.
2494 (tui_clear_exec_info_content): Rename from
2495 tui_erase_exec_info_content.
2496 (tui_clear_exec_info_content): Delete.
2497
2498 2019-08-13 Tom Tromey <tom@tromey.com>
2499
2500 * tui/tui-winsource.h (struct tui_source_window_base)
2501 <show_exec_info_content>: Declare.
2502 (tui_show_exec_info_content): Don't declare.
2503 * tui/tui-winsource.c
2504 (tui_source_window_base::show_exec_info_content): Rename from
2505 tui_show_exec_info_content.
2506 (tui_source_window_base::update_exec_info): Update.
2507
2508 2019-08-13 Tom Tromey <tom@tromey.com>
2509
2510 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2511 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2512 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2513 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2514 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2515 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2516 ... here.
2517
2518 2019-08-13 Tom Tromey <tom@tromey.com>
2519
2520 * tui/tui-winsource.h (struct tui_source_window_base)
2521 <update_exec_info>: Declare.
2522 (tui_update_exec_info): Don't declare.
2523 * tui/tui-winsource.c (tui_update_source_window_as_is)
2524 (tui_source_window_base::refresh_all)
2525 (tui_update_all_breakpoint_info): Update.
2526 (tui_source_window_base::update_exec_info): Rename from
2527 tui_update_exec_info.
2528 * tui/tui-stack.c (tui_show_frame_info): Update.
2529
2530 2019-08-13 Tom Tromey <tom@tromey.com>
2531
2532 * tui/tui-winsource.h (struct tui_source_window_base)
2533 <set_exec_info_content>: Declare.
2534 (tui_set_exec_info_content): Don't declare.
2535 * tui/tui-winsource.c
2536 (tui_source_window_base::set_exec_info_content): Rename from
2537 tui_set_exec_info_content.
2538 (tui_update_exec_info): Update.
2539
2540 2019-08-13 Tom Tromey <tom@tromey.com>
2541
2542 * tui/tui-winsource.h (struct tui_source_window_base)
2543 <show_source_content>: Declare.
2544 (tui_show_source_content): Don't declare.
2545 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2546 (tui_source_window_base::show_source_content): Rename from
2547 tui_show_source_content.
2548 (tui_source_window_base::refresh_all): Update.
2549 * tui/tui-layout.c (show_source_disasm_command)
2550 (show_source_or_disasm_and_command): Update.
2551
2552 2019-08-13 Tom Tromey <tom@tromey.com>
2553
2554 * tui/tui-winsource.c (tui_erase_source_content)
2555 (tui_show_source_content, tui_source_window_base::refresh_all):
2556 Update.
2557 * tui/tui-wingeneral.h
2558 (tui_check_and_display_highlight_if_needed): Don't declare.
2559 * tui/tui-wingeneral.c
2560 (tui_win_info::check_and_display_highlight_if_needed): Rename from
2561 check_and_display_highlight_if_needed.
2562 * tui/tui-win.c (tui_rehighlight_all)
2563 (tui_win_info::make_visible_with_new_height): Update.
2564 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2565 (tui_data_window::erase_data_content)
2566 (tui_data_window::display_all_data): Update.
2567 * tui/tui-data.h (struct tui_win_info)
2568 <check_and_display_highlight_if_needed>: Declare.
2569
2570 2019-08-13 Tom Tromey <tom@tromey.com>
2571
2572 * tui/tui-win.c (tui_resize_all): Call
2573 tui_delete_invisible_windows.
2574 * tui/tui-layout.c (show_layout): Call
2575 tui_delete_invisible_windows.
2576 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2577 * tui/tui-data.c (tui_delete_invisible_windows): New function.
2578
2579 2019-08-13 Tom Tromey <tom@tromey.com>
2580
2581 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
2582 tui_add_win_to_layout.
2583
2584 2019-08-13 Tom Tromey <tom@tromey.com>
2585
2586 * tui/tui-layout.h (tui_default_win_height): Don't declare.
2587 * tui/tui-layout.c (tui_default_win_height): Now static.
2588
2589 2019-08-13 Tom Tromey <tom@tromey.com>
2590
2591 * tui/tui-layout.c (show_layout): Unify all layout cases into a
2592 single switch.
2593 (show_source_disasm_command, show_source_or_disasm_and_command):
2594 Don't check current layout.
2595
2596 2019-08-13 Tom Tromey <tom@tromey.com>
2597
2598 * tui/tui-wingeneral.c (make_all_visible): Remove.
2599 (tui_make_all_invisible): Simplify.
2600 * tui/tui-layout.c (tui_make_all_invisible): Move from
2601 tui-wingeneral.c; simplify.
2602 (show_layout): Hoist call to tui_make_all_invisible.
2603 (show_data): Don't call tui_make_all_invisible.
2604
2605 2019-08-13 Tom Tromey <tom@tromey.com>
2606
2607 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2608 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2609
2610 2019-08-13 Tom Tromey <tom@tromey.com>
2611
2612 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2613 tui-data.c.
2614 (show_source_disasm_command, show_data)
2615 (show_source_or_disasm_and_command): Don't use
2616 tui_set_current_layout_to.
2617 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2618 * tui/tui-data.c (current_layout, tui_current_layout): Move to
2619 tui-layout.c.
2620 (tui_set_current_layout_to): Remove.
2621
2622 2019-08-13 Tom Tromey <tom@tromey.com>
2623
2624 * tui/tui-layout.c (tui_set_layout): Update.
2625 * tui/tui-data.h (struct tui_layout_def): Remove.
2626 (tui_layout_def): Don't declare.
2627 * tui/tui-data.c (layout_def): Remove.
2628 (tui_layout_def): Remove.
2629
2630 2019-08-13 Tom Tromey <tom@tromey.com>
2631
2632 * tui/tui-winsource.h (struct tui_source_window_base)
2633 <clear_detail>: No longer "override".
2634 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2635 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2636 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2637 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2638 Remove.
2639 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2640
2641 2019-08-13 Tom Tromey <tromey@adacore.com>
2642
2643 * tracepoint.c: Don't include readline.h or history.h.
2644
2645 2019-08-12 Tom Tromey <tom@tromey.com>
2646
2647 * configure: Rebuild.
2648 * configure.ac: Check for readline 7.
2649 * NEWS: Mention readline 7 requirement.
2650 * README: Update.
2651
2652 2019-08-12 Tom Tromey <tom@tromey.com>
2653
2654 * mingw-hdep.c (gdb_select): Remove readline hack.
2655
2656 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
2657
2658 * blockframe.c (find_pc_partial_function): Set *block to nullptr
2659 when the function fails.
2660
2661 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
2662
2663 * s390-tdep.c (s390_type_align): New function.
2664 (s390_gdbarch_init): Set it as type_align gdbarch method.
2665
2666 2019-08-09 Tom de Vries <tdevries@suse.de>
2667
2668 PR gdb/24591
2669 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2670 pc_low with relocation offset.
2671
2672 2019-08-07 Tom Tromey <tromey@adacore.com>
2673
2674 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2675 (print_frame_args): Update.
2676 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2677 Update.
2678 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2679 * frame.h (struct frame_arg): Add initializers.
2680 <error>: Now a unique_xmalloc_ptr.
2681
2682 2019-08-07 Alan Hayward <alan.hayward@arm.com>
2683
2684 * NEWS: Expand the Pointer Authentication entry.
2685 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2686 (aarch64_frame_unmask_lr): ... to this.
2687 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2688 Call aarch64_frame_unmask_lr.
2689 * frame.c (struct frame_info): Add "masked" variable.
2690 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2691 (fprint_frame): Check for masked pc.
2692 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2693 declarations.
2694 * python/py-framefilter.c (py_print_frame): Check for masked pc.
2695 * stack.c (print_frame): Check for masked pc.
2696
2697 2019-08-06 Tom Tromey <tom@tromey.com>
2698
2699 * stabsread.c (patch_block_stabs, read_one_struct_field)
2700 (read_enum_type): Use obstack_strndup.
2701 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2702 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2703 * dwarf2read.c (guess_full_die_structure_name)
2704 (anonymous_struct_prefix): Use obstack_strndup.
2705 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2706 * c-exp.y (yylex): Use obstack_strndup.
2707 * ada-exp.y (write_object_renaming, write_ambiguous_var)
2708 (write_var_or_type): Use obstack_strndup.
2709
2710 2019-08-06 Tom Tromey <tom@tromey.com>
2711
2712 * symfile.c (reread_symbols): Use obstack_strdup.
2713 * stabsread.c (read_type): Use obstack_strdup.
2714 * gdb_obstack.h (obstack_strdup): New overload.
2715 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2716 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2717 (dwarf2_canonicalize_name): Use obstack_strdup.
2718 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2719 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2720 Use obstack_strdup.
2721
2722 2019-08-06 Tom Tromey <tom@tromey.com>
2723
2724 * gdb_obstack.h (obstack_strdup): Define.
2725 * gdb_obstack.c (obstack_strdup): Don't define.
2726
2727 2019-08-06 Tom Tromey <tom@tromey.com>
2728
2729 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2730 obstack_strdup.
2731 * typeprint.c (typedef_hash_table::find_global_typedef): Use
2732 obstack_strdup.
2733 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2734 * stabsread.c (common_block_start): Use obstack_strdup.
2735 * objfiles.c (set_objfile_main_name, objfile): Use
2736 obstack_strdup.
2737 * namespace.c (add_using_directive): Use obstack_strdup.
2738 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2739 * jit.c (finalize_symtab): Use obstack_strdup.
2740 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2741 (guess_partial_die_structure_name, partial_die_info::fixup)
2742 (dwarf2_name): Use obstack_strdup.
2743 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2744 obstack_strdup.
2745 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2746 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2747 obstack_strdup.
2748 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2749
2750 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2751
2752 * unittests/help-doc-selftests.c: New file.
2753 * Makefile.in: Add the new file.
2754
2755 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2756
2757 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2758 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
2759 the full first line, except when FOR_VALUE_PREFIX. In this case,
2760 the trailing '.' is not output, and the first character is uppercased.
2761 (print_help_for_command): Update call to print_doc_line.
2762 (print_doc_of_command): Likewise.
2763 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2764 * cli/cli-option.c (append_indented_doc): Do not append newline.
2765 (build_help_option): Append newline after first appended_indented_doc
2766 only if a second call is done.
2767 (build_help): Append 2 new lines before each option, except the first
2768 one.
2769 * compile/compile.c (_initialize_compile): Add new lines after
2770 %OPTIONS%, when not at the end of the help.
2771 Change help doc or code
2772 producing the help doc to respect the invariants.
2773 * maint-test-options.c (_initialize_maint_test_options): Likewise.
2774 Also removed the new line after 'Options:', as all other commands
2775 do not put an empty line between 'Options:' and the first option.
2776 * printcmd.c (_initialize_printcmd): Likewise.
2777 * stack.c (_initialize_stack): Likewise.
2778 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2779 incorrectly telling COMMAND is optional.
2780 * ada-lang.c (_initialize_ada_language): Change help doc or code
2781 producing the help doc to respect the invariants.
2782 * ada-tasks.c (_initialize_ada_tasks): Likewise.
2783 * breakpoint.c (_initialize_breakpoint): Likewise.
2784 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2785 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2786 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2787 * cli/cli-style.c (cli_style_option::add_setshow_commands,
2788 _initialize_cli_style): Likewise.
2789 * corelow.c (core_target_info): Likewise.
2790 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2791 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2792 * filesystem.c (_initialize_filesystem): Likewise.
2793 * frame.c (_initialize_frame): Likewise.
2794 * gnu-nat.c (add_task_commands): Likewise.
2795 * infcall.c (_initialize_infcall): Likewise.
2796 * infcmd.c (_initialize_infcmd): Likewise.
2797 * interps.c (_initialize_interpreter): Likewise.
2798 * language.c (_initialize_language): Likewise.
2799 * linux-fork.c (_initialize_linux_fork): Likewise.
2800 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2801 * maint.c (_initialize_maint_cmds): Likewise.
2802 * memattr.c (_initialize_mem): Likewise.
2803 * printcmd.c (_initialize_printcmd): Likewise.
2804 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2805 _RegEx): Likewise.
2806 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2807 * record-btrace.c (_initialize_record_btrace): Likewise.
2808 * record-full.c (_initialize_record_full): Likewise.
2809 * record.c (_initialize_record): Likewise.
2810 * regcache-dump.c (_initialize_regcache_dump): Likewise.
2811 * regcache.c (_initialize_regcache): Likewise.
2812 * remote.c (add_packet_config_cmd, init_remote_threadtests,
2813 _initialize_remote): Likewise.
2814 * ser-tcp.c (_initialize_ser_tcp): Likewise.
2815 * serial.c (_initialize_serial): Likewise.
2816 * skip.c (_initialize_step_skip): Likewise.
2817 * source.c (_initialize_source): Likewise.
2818 * stack.c (_initialize_stack): Likewise.
2819 * symfile.c (_initialize_symfile): Likewise.
2820 * symtab.c (_initialize_symtab): Likewise.
2821 * target-descriptions.c (_initialize_target_descriptions): Likewise.
2822 * top.c (init_main): Likewise.
2823 * tracefile-tfile.c (tfile_target_info): Likewise.
2824 * tracepoint.c (_initialize_tracepoint): Likewise.
2825 * tui/tui-win.c (_initialize_tui_win): Likewise.
2826 * utils.c (add_internal_problem_command): Likewise.
2827 * valprint.c (value_print_option_defs): Likewise.
2828
2829 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
2830
2831 PR build/24886
2832 * configure.ac: Drop enable-libmcheck support.
2833 * configure, config.in: Rebuild.
2834 * libmcheck.m4: Remove.
2835 * acinclude.m4: Don't include it.
2836 * Makefile.in: Don't distribute it.
2837 * top.c (print_gdb_configuration): Don't mention it.
2838
2839 2019-08-06 Tom Tromey <tom@tromey.com>
2840
2841 * utils.c (set_output_style): Sometimes pass stream to
2842 emit_style_escape.
2843 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2844 * record-btrace.c (btrace_insn_history): Update.
2845 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2846 method.
2847 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2848 Update initializers.
2849 <m_uiout>: New field.
2850 <m_di>: Move lower.
2851 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2852 Remove "uiout" parameter.
2853 (dump_insns): Update.
2854 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2855 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2856
2857 2019-08-06 Christian Biesinger <cbiesinger@google.com>
2858
2859 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2860 (error_in_psymtab_expansion): Likewise.
2861 (lookup_symbol_via_quick_fns): Likewise.
2862 (basic_lookup_transparent_type_quick): Likewise.
2863 (basic_lookup_transparent_type_1): Likewise.
2864
2865 2019-08-06 Tom Tromey <tromey@adacore.com>
2866
2867 * source.c (last_source_error): Now bool.
2868 (print_source_lines_base): Make "noprint" bool. Only open
2869 source file when last_source_visited changes.
2870
2871 2019-08-06 Tom Tromey <tromey@adacore.com>
2872
2873 * annotate.c (annotate_source_line): Use g_source_cache.
2874 * source-cache.c (source_cache::get_plain_source_lines): Change
2875 parameters. Populate m_offset_cache.
2876 (source_cache::ensure): New method.
2877 (source_cache::get_line_charpos): New method.
2878 (extract_lines): Move lower. Change parameters.
2879 (source_cache::get_source_lines): Move lower.
2880 * source-cache.h (class source_cache): Update comment.
2881 <get_line_charpos>: New method.
2882 <get_source_lines>: Update comment.
2883 <clear>: Clear m_offset_cache.
2884 <get_plain_source_lines>: Change parameters.
2885 <ensure>: New method
2886 <m_offset_cache>: New member.
2887 * source.c (forget_cached_source_info_for_objfile): Update.
2888 (info_source_command): Use g_source_cache.
2889 (find_source_lines, open_source_file_with_line_charpos): Remove.
2890 (print_source_lines_base, search_command_helper): Use g_source_cache.
2891 * source.h (open_source_file_with_line_charpos): Don't declare.
2892 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2893 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2894 Use g_source_cache.
2895
2896 2019-08-06 Tom Tromey <tromey@adacore.com>
2897
2898 * source-cache.c (source_cache::get_plain_source_lines):
2899 Remove "first_line" and "last_line" parameters.
2900 (source_cache::get_source_lines): Cache plain text.
2901 * source-cache.h (class source_cache)
2902 <get_plain_source_lines>: Update.
2903
2904 2019-08-06 Tom Tromey <tromey@adacore.com>
2905
2906 * source-cache.c (extract_lines): No longer a method.
2907 Changed type of parameter. Include final newline.
2908 (selftests::extract_lines_test): New function.
2909 (_initialize_source_cache): Likewise.
2910 * source-cache.h (class source_cache)
2911 <extract_lines>: Don't declare.
2912
2913 2019-08-06 Tom Tromey <tromey@adacore.com>
2914
2915 * breakpoint.c (init_breakpoint_sal): Update.
2916 (breakpoint): Update.
2917 * breakpoint.h (struct breakpoint) <filter>: Now a
2918 unique_xmalloc_ptr.
2919
2920 2019-08-05 Christian Biesinger <cbiesinger@google.com>
2921
2922 * NEWS: Mention dictionary access on blocks.
2923 * python/py-block.c (blpy_getitem): New function.
2924 (block_object_as_mapping): New struct.
2925 (block_object_type): Use new struct for tp_as_mapping field.
2926
2927 2019-08-05 Christian Biesinger <cbiesinger@google.com>
2928
2929 * objfiles.h (objfile): Add a comment describing partial symbols.
2930
2931 2019-08-05 Tom Tromey <tromey@adacore.com>
2932
2933 * compile/compile.c (_initialize_compile): Use _(), not N_().
2934 * thread.c (_initialize_thread): Use _(), not N_().
2935 * stack.c (_initialize_stack): Use _(), not N_().
2936 * printcmd.c (_initialize_printcmd): Use _(), not N_().
2937
2938 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
2939
2940 * dwarf2read.c (struct dw2_symtab_iterator):
2941 <want_specific_block>: Remove.
2942 <block_index>: Change type to gdb::optional.
2943 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2944 change type of BLOCK_INDEX parameter to gdb::optional.
2945 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2946 (dw2_lookup_symbol): Don't pass argument for
2947 WANT_SPECIFIC_BLOCK.
2948 (dw2_expand_symtabs_for_function): Don't pass argument for
2949 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2950 (class dw2_debug_names_iterator)
2951 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2952 parameter, change BLOCK_INDEX type to gdb::optional.
2953 <m_want_specific_block>: Remove.
2954 <m_block_index>: Change type to gdb::optional.
2955 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2956 gdb::optional. Re-write in function of gdb::optional.
2957 (dw2_debug_names_lookup_symbol): Don't pass argument for
2958 WANT_SPECIFIC_BLOCK.
2959 (dw2_debug_names_expand_symtabs_for_function): Don't pass
2960 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2961 BLOCK_INDEX.
2962
2963 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2964
2965 * NEWS: Mention changes to "info sources" command.
2966
2967 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2968
2969 * symtab.c (filename_partial_match_opts): New struct type.
2970 (struct output_source_filename_data): New members
2971 regexp, c_regexp, partial_match.
2972 (output_source_filename): Use new members to decide to print file.
2973 (info_sources_option_defs): New variable.
2974 (make_info_sources_options_def_group, print_info_sources_header,
2975 info_sources_command_completer):
2976 New functions.
2977 (info_sources_command): Read new optional arguments.
2978 (_initialize_symtab): Update info sources help.
2979
2980 2019-08-02 Alexandre Oliva <oliva@adacore.com>
2981
2982 * ada-lang.c (exception_support_info_v0): Renamed from...
2983 (default_exception_support_info): ... this. Create new
2984 definition for v1.
2985 (ada_has_this_exception_support): Look up catch_handlers_sym.
2986 (ada_exception_support_info_sniffer): Try v0 after default.
2987
2988 2019-08-01 Tom Tromey <tromey@adacore.com>
2989
2990 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2991 gdbarch.h.
2992
2993 2019-08-01 Christian Biesinger <cbiesinger@google.com>
2994
2995 * s12z-tdep.c: Fix include path for s12z-opc.h.
2996
2997 2019-08-01 Alan Hayward <alan.hayward@arm.com>
2998
2999 * NEWS: Require GNU make 3.82.
3000
3001 2019-07-16 Tom Tromey <tom@tromey.com>
3002
3003 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3004 declare.
3005
3006 2019-07-30 Tom Tromey <tromey@adacore.com>
3007
3008 * block.c (contained_in): Remove BLOCK_FUNCTION check.
3009
3010 2019-07-30 Kevin Buettner <kevinb@redhat.com>
3011
3012 * printcmd.c (print_address_symbolic): Print negative offsets.
3013 (build_address_symbolic): Force signed arithmetic when computing
3014 offset.
3015
3016 2019-07-30 Christian Biesinger <cbiesinger@google.com>
3017
3018 PR/24474: Add a function to lookup static variables.
3019 * NEWS: Mention this new function.
3020 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3021 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3022 * python/python.c (python_GdbMethods): Add new function.
3023
3024 2019-07-29 Christian Biesinger <cbiesinger@google.com>
3025
3026 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3027 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3028 (objfpy_lookup_static_symbol): New function.
3029 (objfile_object_methods): Add new functions.
3030
3031 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3032
3033 * NEWS: Mention 'set|show print frame-info'. Mention new
3034 'presence' value for 'frame-arguments'. Mention new '-frame-info'
3035 backtrace argument. Mention that python frame filtering code
3036 is now consistent with what 'backtrace' command prints.
3037
3038 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3039
3040 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3041 comments.
3042 (print_frame_info_auto, print_frame_info_source_line,
3043 print_frame_info_location, print_frame_info_source_and_location,
3044 print_frame_info_location_and_address, print_frame_info_short_location):
3045 New declarations.
3046 (struct frame_print_options): New member print_frame_info.
3047 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3048 * stack.h (get_user_print_what_frame_info): New declaration.
3049 (frame_show_address): New declaration.
3050 * stack.c (print_frame_arguments_choices): New value 'presence'.
3051 (print_frame_info_auto, print_frame_info_source_line,
3052 print_frame_info_location, print_frame_info_source_and_location,
3053 print_frame_info_location_and_address, print_frame_info_short_location,
3054 print_frame_info_choices, print_frame_info_print_what): New definitions.
3055 (print_frame_args): Only print dots for args if print frame-arguments
3056 is 'presence'.
3057 (frame_print_option_defs): New element for "frame-info".
3058 (get_user_print_what_frame_info): New function.
3059 (frame_show_address): Make non static. Move comment to stack.h.
3060 (print_frame_info_to_print_what): New function.
3061 (print_frame_info): Update comment. Use fp_opts.print_frame_info
3062 to decide what to print.
3063 (backtrace_command_1): Handle the new print_frame_arguments_presence
3064 value.
3065 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3066 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3067 (py_print_frame): In non-mi mode, use LOCATION as default for
3068 print_what, similarly to frame information printed directly by
3069 backtrace command. Handle frame-info user option in non MI mode.
3070
3071 2019-07-27 Kevin Buettner <kevinb@redhat.com>
3072
3073 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3074 Add case for debugging 32-bit target on 64-bit host. Revise
3075 comment.
3076
3077 2019-07-27 Kevin Buettner <kevinb@redhat.com>
3078
3079 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3080 instead of find_function_entry_range_from_pc.
3081
3082 2019-07-27 Kevin Buettner <kevinb@redhat.com>
3083
3084 * stack.c (find_frame_funname): Remove code which preferred
3085 minsym over symtab sym in "certain pathological cases".
3086
3087 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3088 parameter. Change type of "do_demangle" to bool.
3089 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3090 Pass suitable "prefer_sym_over_minsym" flag to
3091 build_address_symbolic(). Don't output "+" for negative offsets.
3092 * printcmd.c (print_address_symbolic): Update invocation of
3093 build_address_symbolic to include a "prefer_sym_over_minsym"
3094 flag.
3095 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3096 Restrict cases in which use of minimal symbol is preferred to that
3097 of a found symbol. Update comments.
3098
3099 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3100 for entry pc when entry pc is out of range for that FDE.
3101
3102 2019-07-26 Brian Callahan <bcallah@openbsd.org>
3103
3104 PR gdb/24839:
3105 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3106 type.
3107
3108 2019-07-25 Christian Biesinger <cbiesinger@google.com>
3109
3110 * python/py-objfile.c (add_separate_debug_file): Fix comment about
3111 this function's Python signature.
3112
3113
3114 2019-07-24 Christian Biesinger <cbiesinger@google.com>
3115
3116 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3117 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3118 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3119 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3120 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3121
3122
3123 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
3124
3125 * h8300-tdep.c (h8300_register_name_common): New.
3126 h8300_register_name): Use h8300_register_name_common.
3127 (h8300s_register_name): Likewise.
3128 (h8300sx_register_name): Likewise.
3129 (h8300h_register_nam): New.
3130 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3131
3132
3133 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
3134
3135 * arm-tdep.c (arm_skip_cmse_entry): New function.
3136 (arm_is_sgstubs_section): New function.
3137 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3138
3139 2019-07-22 Tom Tromey <tom@tromey.com>
3140
3141 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3142 Don't self-assign.
3143
3144 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3145
3146 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3147 type_print.
3148
3149 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3150
3151 * symtab.c (search_symbols): Adjust msymbol matching type arrays
3152 so that GDB doesn't match any msymbols when searching in the
3153 TYPES_DOMAIN.
3154 (print_symbol_info): Print using typedef_print or type_print based
3155 on the type of the symbol. Add updated FIXME comment moved from...
3156 (_initialize_symtab): ... move and update FIXME comment to above.
3157
3158 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3159
3160 * NEWS: Mention adding -q option to "info types".
3161 * symtab.c (struct info_types_options): New struct.
3162 (info_types_options_defs): New variable.
3163 (make_info_types_options_def_group): New function.
3164 (info_types_command): Use gdb::option framework to parse options.
3165 (info_types_command_completer): New function.
3166 (_initialize_symtab): Extend the help text on "info types" and
3167 register command completer.
3168
3169 2019-07-21 Christian Biesinger <cbiesinger@google.com>
3170
3171 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3172 (lookup_symbol_in_objfile): Change int to block_enum and add a
3173 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3174
3175 2019-07-20 Christian Biesinger <cbiesinger@google.com>
3176
3177 * MAINTAINERS (Write After Approval): Add self.
3178
3179 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
3180
3181 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3182 instruction to the dummy code region.
3183
3184 2019-07-19 Tom Tromey <tromey@adacore.com>
3185
3186 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3187 (ARGSUSED, PARAMS, __func__): Remove rules.
3188
3189 2019-07-19 Alan Hayward <alan.hayward@arm.com>
3190
3191 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3192 * features/arm/arm-with-iwmmxt.c: Remove.
3193 * features/arm/arm-with-iwmmxt.xml: Remove.
3194 * features/arm/arm-with-m-fpa-layout.c: Remove.
3195 * features/arm/arm-with-m-fpa-layout.xml: Remove.
3196 * features/arm/arm-with-m-vfp-d16.c: Remove.
3197 * features/arm/arm-with-m-vfp-d16.xml: Remove.
3198 * features/arm/arm-with-m.c: Remove.
3199 * features/arm/arm-with-m.xml: Remove.
3200 * features/arm/arm-with-neon.c: Remove.
3201 * features/arm/arm-with-neon.xml: Remove.
3202 * features/arm/arm-with-vfpv2.c: Remove.
3203 * features/arm/arm-with-vfpv2.xml: Remove.
3204 * features/arm/arm-with-vfpv3.c: Remove.
3205 * features/arm/arm-with-vfpv3.xml: Remove.
3206
3207 2019-07-19 Alan Hayward <alan.hayward@arm.com>
3208
3209 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3210
3211 2019-07-19 Alan Hayward <alan.hayward@arm.com>
3212
3213 * arch/aarch32.c (aarch32_create_target_description): Create
3214 target descriptions using features.
3215 * arch/arm.c (arm_create_target_description)
3216 (arm_create_mprofile_target_description): Likewise.
3217 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3218
3219 2019-07-19 Alan Hayward <alan.hayward@arm.com>
3220
3221 * Makefile.in: Add new files.
3222 * aarch32-tdep.c: New file.
3223 * aarch32-tdep.h: New file.
3224 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3225 Call aarch32_read_description.
3226 * arch/aarch32.c: New file.
3227 * arch/aarch32.h: New file.
3228 * arch/arm.c (arm_create_target_description)
3229 (arm_create_mprofile_target_description): New function.
3230 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3231 (arm_create_target_description)
3232 (arm_create_mprofile_target_description): New declaration.
3233 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3234 read_description functions.
3235 * arm-linux-nat.c (arm_linux_nat_target::read_description):
3236 Likewise.
3237 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3238 * arm-tdep.c (tdesc_arm_list): New variable.
3239 (arm_register_g_packet_guesses): Call create description functions.
3240 (arm_read_description) (arm_read_mprofile_description): New
3241 function.
3242 * arm-tdep.h (arm_read_description)
3243 (arm_read_mprofile_description): Add declaration.
3244 * configure.tgt: Add new files.
3245
3246 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
3247
3248 * top.c (new_ui_command): Open specified terminal just once.
3249
3250 2019-07-18 Tom Tromey <tromey@adacore.com>
3251
3252 * symtab.c (main_name): Constify return type.
3253 * symfile.c (set_initial_language): Update.
3254 * symtab.h (main_name): Constify return type.
3255
3256 2019-07-17 Tom Tromey <tom@tromey.com>
3257
3258 * tui/tui-winsource.c (tui_update_source_window)
3259 (tui_update_source_window_as_is)
3260 (tui_update_source_windows_with_line): Remove return.
3261 * tui/tui-disasm.c (tui_show_disassem)
3262 (tui_show_disassem_and_update_source): Remove return.
3263 * tui/tui.c (tui_reset): Remove return.
3264 * tui/tui-wingeneral.c
3265 (tui_check_and_display_highlight_if_needed): Remove return.
3266
3267 2019-07-17 Tom Tromey <tom@tromey.com>
3268
3269 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3270
3271 2019-07-17 Tom Tromey <tom@tromey.com>
3272
3273 * tui/tui-winsource.h (struct tui_exec_info_window)
3274 (struct tui_source_window_base): Move from tui-data.h.
3275 * tui/tui-winsource.c: Move many method definitions from
3276 elsewhere. Remove "structuring" comments.
3277 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3278 (tui_source_window_base::refresh_window): Move to
3279 tui-winsource.c.
3280 * tui/tui-win.c (tui_source_window_base::refresh_all)
3281 (tui_source_window_base::update_tab_width)
3282 (tui_source_window_base::set_new_height)
3283 (tui_source_window_base::do_make_visible_with_new_height): Move to
3284 tui-winsource.c.
3285 * tui/tui-source.h: Update.
3286 * tui/tui-source.c (tui_source_window_base::reset): Move to
3287 tui-winsource.c.
3288 * tui/tui-disasm.h: Update.
3289 * tui/tui-data.h (struct tui_exec_info_window): Move to
3290 tui-winsource.h.
3291 (struct tui_source_window_base): Likewise.
3292 * tui/tui-data.c (tui_source_window_base::clear_detail)
3293 (tui_source_window_base, ~tui_source_window_base): Move to
3294 tui-winsource.c.
3295
3296 2019-07-17 Tom Tromey <tom@tromey.com>
3297
3298 * tui/tui-win.c (tui_resize_all)
3299 (tui_source_window_base::update_tab_width)
3300 (tui_adjust_win_heights): Update.
3301 (tui_win_info::make_invisible_and_set_new_height): Rename from
3302 make_invisible_and_set_new_height.
3303 * tui/tui-data.h (struct tui_win_info)
3304 <make_invisible_and_set_new_height>: New method.
3305
3306 2019-07-17 Tom Tromey <tom@tromey.com>
3307
3308 * tui/tui.c: Update.
3309 * tui/tui-source.h (struct tui_source_window): Move from
3310 tui-data.h.
3311 * tui/tui-layout.c: Update.
3312 * tui/tui-disasm.c: Update.
3313 * tui/tui-data.h (struct tui_source_window): Move to
3314 tui-source.h.
3315
3316 2019-07-17 Tom Tromey <tom@tromey.com>
3317
3318 * tui/tui-disasm.h (struct tui_disasm_window): Move from
3319 tui-data.h.
3320 * tui/tui-data.h (struct tui_disasm_window): Move to
3321 tui-disasm.h.
3322
3323 2019-07-17 Tom Tromey <tom@tromey.com>
3324
3325 * tui/tui-regs.h (struct tui_data_item_window): Move from
3326 tui-data.h.
3327 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3328 * tui/tui-data.h (struct tui_data_item_window): Move to
3329 tui-regs.h.
3330 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3331
3332 2019-07-17 Tom Tromey <tom@tromey.com>
3333
3334 * tui/tui.c: Update.
3335 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3336 (tui_cmd_window::max_height): Move to tui-command.c.
3337 * tui/tui-layout.c: Update.
3338 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3339 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3340 tui-command.c.
3341 * tui/tui-command.h (struct tui_cmd_window): Move from
3342 tui-data.h.
3343 * tui/tui-command.c: Remove "structuring" comments.
3344 (tui_cmd_window::clear_detail)
3345 (tui_cmd_window::do_make_visible_with_new_height)
3346 (tui_cmd_window::max_height): Move from elsewhere.
3347
3348 2019-07-17 Tom Tromey <tom@tromey.com>
3349
3350 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3351 Now static.
3352 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3353 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3354
3355 2019-07-17 Tom Tromey <tom@tromey.com>
3356
3357 * tui/tui.c: Update.
3358 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3359 tui-regs.c.
3360 * tui/tui-windata.h: Remove file.
3361 * tui/tui-windata.c: Remove file.
3362 * tui/tui-win.c (tui_data_window::set_new_height)
3363 (tui_data_window::do_make_visible_with_new_height): Move to
3364 tui-regs.c.
3365 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3366 * tui/tui-regs.c: Remove "structuring" comments.
3367 (tui_data_window::first_data_item_displayed)
3368 (tui_data_window::delete_data_content_windows)
3369 (tui_data_window::erase_data_content)
3370 (tui_data_window::display_all_data)
3371 (tui_data_window::refresh_all)
3372 (tui_data_window::do_scroll_vertical)
3373 (tui_data_window::clear_detail, tui_data_window::set_new_height)
3374 (tui_data_window::do_make_visible_with_new_height)
3375 (tui_data_window::refresh_window): Move from elsewhere.
3376 (_initialize_tui_regs): Move to end of file.
3377 * tui/tui-layout.c: Update.
3378 * tui/tui-hooks.c: Update.
3379 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3380 * tui/tui-data.c (tui_data_window::clear_detail): Move to
3381 tui-regs.c.
3382 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3383
3384 2019-07-17 Tom Tromey <tom@tromey.com>
3385
3386 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3387 seen.
3388
3389 2019-07-17 Tom Tromey <tom@tromey.com>
3390
3391 * tui/tui-win.c (tui_source_window_base::set_new_height)
3392 (tui_source_window_base::do_make_visible_with_new_height): Use
3393 m_has_locator field directly.
3394 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3395 method.
3396 (struct tui_source_window_base) <has_locator>: Likewise.
3397
3398 2019-07-17 Tom Tromey <tom@tromey.com>
3399
3400 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3401 Don't declare.
3402 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3403 Remove.
3404 * tui/tui-win.c (tui_source_window_base::set_new_height)
3405 (tui_source_window_base::set_new_height)
3406 (make_invisible_and_set_new_height)
3407 (tui_source_window_base::do_make_visible_with_new_height)
3408 (tui_source_window_base::do_make_visible_with_new_height):
3409 Update.
3410 * tui/tui-layout.c (show_source_disasm_command, show_data)
3411 (show_source_or_disasm_and_command): Update.
3412 * tui/tui-layout.c (show_layout): Update.
3413
3414 2019-07-17 Tom Tromey <tom@tromey.com>
3415
3416 * tui/tui-layout.c (make_data_window): Remove.
3417 (show_data): Unify creation and re-initialization cases.
3418
3419 2019-07-17 Tom Tromey <tom@tromey.com>
3420
3421 * tui/tui-layout.c (make_source_window, make_disasm_window):
3422 Remove.
3423 (show_data): Unify creation and re-initialization cases.
3424
3425 2019-07-17 Tom Tromey <tom@tromey.com>
3426
3427 * tui/tui-layout.c (make_command_window): Remove.
3428 (show_source_disasm_command, show_source_or_disasm_and_command):
3429 Unify creation and re-initialization cases.
3430
3431 2019-07-17 Tom Tromey <tom@tromey.com>
3432
3433 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3434 creation and re-initialization cases.
3435
3436 2019-07-17 Tom Tromey <tom@tromey.com>
3437
3438 * tui/tui-regs.c (tui_get_register): Return void.
3439
3440 2019-07-17 Tom Tromey <tom@tromey.com>
3441
3442 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3443 Simplify.
3444
3445 2019-07-17 Tom Tromey <tom@tromey.com>
3446
3447 * tui/tui-layout.c (show_source_disasm_command): Simplify window
3448 resetting.
3449
3450 2019-07-17 Tom Tromey <tom@tromey.com>
3451
3452 * tui/tui.h (tui_set_layout_by_name): Don't declare.
3453 * tui/tui-regs.c (tui_reg_layout): New function.
3454 (tui_show_registers, tui_reg_command): Use it.
3455 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3456 (tui_layout_command): Rename from tui_set_layout_by_name. Change
3457 parameters.
3458 (tui_layout_command): Remove.
3459
3460 2019-07-17 Tom Tromey <tom@tromey.com>
3461
3462 * tui/tui-layout.h (tui/tui-layout): Return void.
3463 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
3464
3465 2019-07-17 Tom Tromey <tom@tromey.com>
3466
3467 * tui/tui-layout.c (show_source_disasm_command, show_data):
3468 Update.
3469 (reset_locator): Remove.
3470 (show_source_or_disasm_and_command): Update.
3471
3472 2019-07-17 Tom Tromey <tom@tromey.com>
3473
3474 * tui/tui-source.c (tui_source_window_base::reset): Remove
3475 win_type parameter.
3476 * tui/tui-layout.c (make_command_window, make_source_window)
3477 (make_disasm_window, make_data_window)
3478 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3479 (reset_locator, show_source_or_disasm_and_command): Update.
3480 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3481 win_type parameter.
3482 (struct tui_source_window_base) <reset>: Likewise.
3483
3484 2019-07-17 Tom Tromey <tom@tromey.com>
3485
3486 * tui/tui-layout.c (show_source_disasm_command): Use
3487 reset_locator.
3488 (reset_locator): New function.
3489 (init_and_make_win): Remove.
3490 (show_source_or_disasm_and_command): Use reset_locator.
3491
3492 2019-07-17 Tom Tromey <tom@tromey.com>
3493
3494 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3495 condition.
3496 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3497 Remove condition.
3498 * tui/tui-source.c (tui_source_window_base::reset): New method.
3499 * tui/tui-layout.c (make_command_window): Don't call
3500 init_and_make_win.
3501 (make_source_window, make_disasm_window): Don't call
3502 make_source_or_disasm_window.
3503 (make_data_window): Don't call init_and_make_win. Change calling
3504 convention.
3505 (show_source_disasm_command, show_data): Simplify.
3506 (make_source_or_disasm_window): Remove.
3507 (show_source_or_disasm_and_command): Simplify.
3508 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3509 (struct tui_source_window_base) <reset>: Likewise.
3510 <execution_info>: Remove initializer.
3511 * tui/tui-data.c (tui_source_window_base): Initialize
3512 execution_info.
3513
3514 2019-07-17 Tom Tromey <tom@tromey.com>
3515
3516 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3517 variable.
3518
3519 2019-07-17 Tom Tromey <tom@tromey.com>
3520
3521 * tui/tui.c (tui_rl_other_window): Update.
3522 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3523 superclass method first. Always iterate over regs_content.
3524 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3525 method.
3526 * tui/tui-win.c (tui_set_focus_command): Update.
3527
3528 2019-07-17 Tom Tromey <tom@tromey.com>
3529
3530 * tui/tui-win.c (tui_set_focus_command): Rename from
3531 tui_set_focus. Call tui_enable.
3532 (tui_set_focus_command): Remove.
3533
3534 2019-07-17 Tom Tromey <tom@tromey.com>
3535
3536 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3537 refresh_window.
3538 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3539 touchwin.
3540 (tui_data_window::refresh_window): Call refresh_window on data
3541 items. Always call superclass refresh_window.
3542 (tui_win_info::refresh): Remove.
3543 (tui_source_window_base::refresh_window): Update.
3544 (tui_refresh_all): Update.
3545 * tui/tui-layout.c (show_source_disasm_command): Remove call to
3546 refresh_window.
3547 (show_source_or_disasm_and_command): Likewise.
3548 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3549 (struct tui_source_window_base) <refresh>: Likewise.
3550
3551 2019-07-17 Tom Tromey <tom@tromey.com>
3552
3553 * tui/tui-winsource.c (tui_clear_source_content)
3554 (tui_show_source_content): Update.
3555 * tui/tui-source.c (tui_source_window::showing_source_p): Check
3556 whether content is empty.
3557 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3558 Remove.
3559
3560 2019-07-17 Tom Tromey <tom@tromey.com>
3561
3562 * tui/tui-winsource.c (tui_erase_source_content): Clear the
3563 window's contents.
3564 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3565 * tui/tui-source.c (tui_set_source_content_nil): Remove.
3566
3567 2019-07-17 Tom Tromey <tom@tromey.com>
3568
3569 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3570 (struct tui_data_item_window): Update.
3571
3572 2019-07-17 Tom Tromey <tom@tromey.com>
3573
3574 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3575 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3576 defines.
3577
3578 2019-07-17 Tom Tromey <tom@tromey.com>
3579
3580 * tui/tui-winsource.h (tui_erase_source_content)
3581 (tui_clear_source_content): Remove "display_prompt" parameter.
3582 * tui/tui-winsource.c (tui_update_source_window_as_is)
3583 (tui_update_source_windows_with_addr): Update.
3584 (tui_clear_source_content): Remove "display_prompt" parameter.
3585 (tui_erase_source_content): Likewise. Simplify.
3586 (tui_show_source_content): Update.
3587 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3588 * tui/tui-stack.c (tui_show_frame_info): Update.
3589 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3590 Remove defines.
3591
3592 2019-07-17 Tom Tromey <tom@tromey.com>
3593
3594 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3595 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3596 parameter.
3597 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3598 parameter.
3599
3600 2019-07-17 Tom Tromey <tom@tromey.com>
3601
3602 * tui/tui-winsource.c (tui_clear_source_content)
3603 (tui_show_source_content, tui_show_exec_info_content)
3604 (tui_clear_exec_info_content): Update.
3605 * tui/tui-stack.c (tui_show_locator_content): Update.
3606 (tui_show_frame_info): Update.
3607 * tui/tui-source.h (tui_source_window): Don't declare.
3608 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3609 from tui_source_is_displayed.
3610 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3611 Remove field.
3612 (struct tui_source_window_base) <content_in_use>: New field. Now
3613 bool.
3614 (struct tui_source_window) <showing_source_p>: New method.
3615 (TUI_SRC_WIN): Change cast.
3616 * tui/tui-data.c (tui_initialize_static_data): Update.
3617
3618 2019-07-17 Tom Tromey <tom@tromey.com>
3619
3620 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3621 location_matches_p.
3622 * tui/tui-source.c (tui_source_window::location_matches_p): New
3623 method.
3624 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3625 method.
3626 * tui/tui-data.h (struct tui_source_window_base)
3627 <location_matches_p>: New method.
3628 (struct tui_source_window, struct tui_disasm_window)
3629 <location_matches_p>: Likewise.
3630
3631 2019-07-17 Tom Tromey <tom@tromey.com>
3632
3633 * tui/tui-win.c (tui_set_win_height_command): Rename from
3634 tui_set_win_height.
3635 (tui_set_win_height_command): Remove.
3636
3637 2019-07-17 Tom Tromey <tom@tromey.com>
3638
3639 * tui/tui-source.c (tui_source_window): New constructor. Add
3640 observer.
3641 (~tui_source_window): New destructor.
3642 (tui_source_window::style_changed): New method.
3643 * tui/tui-hooks.c (tui_redisplay_source): Remove.
3644 (tui_attach_detach_observers): Update.
3645 * tui/tui-data.h (struct tui_source_window): Make constructor not
3646 inline. Add destructor.
3647 (struct tui_source_window) <style_changed>: New method.
3648 <m_observable>: New member.
3649
3650 2019-07-17 Tom Tromey <tom@tromey.com>
3651
3652 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3653 * tui/tui-win.c (tui_resize_all): Fix typo.
3654
3655 2019-07-17 Tom Tromey <tom@tromey.com>
3656
3657 * tui/tui-wingeneral.h (tui_refresh_all): Update.
3658 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3659 (tui_refresh_all): Remove "list" parameter. Use foreach.
3660 * tui/tui-win.c (window_name_completer): Use foreach.
3661 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3662 (update_tab_width): Likewise.
3663 * tui/tui-layout.c (show_layout): Update.
3664 * tui/tui-data.h (class tui_window_iterator): New.
3665 (struct all_tui_windows): New.
3666 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3667
3668 2019-07-17 Tom Tromey <tom@tromey.com>
3669
3670 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3671 parameter. Don't reference globals.
3672 (tui_reg_command): Update.
3673
3674 2019-07-17 Tom Tromey <tom@tromey.com>
3675
3676 * tui/tui-regs.c (tui_show_registers): Simplify.
3677
3678 2019-07-17 Tom Tromey <tom@tromey.com>
3679
3680 * tui/tui-regs.c (tui_show_registers): Update.
3681 (tui_show_register_group): Add win_info parameter.
3682
3683 2019-07-17 Tom Tromey <tom@tromey.com>
3684
3685 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3686 Rename from tui_display_reg_element_at_line.
3687 (tui_data_window::display_registers_from_line): Update.
3688 * tui/tui-data.h (struct tui_data_window)
3689 <display_reg_element_at_line>: New method.
3690
3691 2019-07-17 Tom Tromey <tom@tromey.com>
3692
3693 * tui/tui-regs.h (tui_display_registers_from)
3694 (tui_display_registers_from_line): Don't declare.
3695 * tui/tui-windata.c (tui_data_window::display_all_data)
3696 (tui_data_window::refresh_all)
3697 (tui_data_window::do_scroll_vertical): Update.
3698 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3699 from tui_display_registers_from.
3700 (tui_display_reg_element_at_line): Update.
3701 (tui_data_window::display_registers_from_line): Rename from
3702 tui_display_registers_from_line.
3703 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3704 display_registers_from_line>: New methods.
3705
3706 2019-07-17 Tom Tromey <tom@tromey.com>
3707
3708 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3709 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3710 from tui_erase_data_content.
3711 (tui_data_window::display_all_data)
3712 (tui_data_window::refresh_all)
3713 (tui_data_window::do_scroll_vertical): Update.
3714 * tui/tui-regs.c (tui_show_registers): Update.
3715 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3716 New method.
3717
3718 2019-07-17 Tom Tromey <tom@tromey.com>
3719
3720 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3721 declare.
3722 * tui/tui-windata.c
3723 (tui_data_window::delete_data_content_windows): Rename from
3724 tui_delete_data_content_windows.
3725 (tui_data_window::display_all_data)
3726 (tui_data_window::do_scroll_vertical): Update.
3727 * tui/tui-data.h (struct tui_data_window)
3728 <delete_data_content_windows>: New method.
3729
3730 2019-07-17 Tom Tromey <tom@tromey.com>
3731
3732 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3733 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3734
3735 2019-07-17 Tom Tromey <tom@tromey.com>
3736
3737 * tui/tui-windata.h (tui_display_all_data): Don't declare.
3738 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3739 from tui_display_all_data.
3740 * tui/tui-win.c
3741 (tui_data_window::do_make_visible_with_new_height): Update.
3742 * tui/tui-regs.c (tui_show_registers): Update.
3743 * tui/tui-layout.c (tui_set_layout): Update.
3744 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3745 method.
3746
3747 2019-07-17 Tom Tromey <tom@tromey.com>
3748
3749 * tui/tui-windata.h (tui_display_data_from): Don't declare.
3750 * tui/tui-windata.c (tui_display_data_from): Remove.
3751 (tui_data_window::refresh_all): Update.
3752
3753 2019-07-17 Tom Tromey <tom@tromey.com>
3754
3755 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3756 * tui/tui-windata.c (tui_display_data_from_line): Remove.
3757 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3758 tui_display_registers_from_line.
3759 * tui/tui-regs.h (tui_display_registers_from_line): Update.
3760 * tui/tui-regs.c (tui_display_registers_from_line): Remove
3761 "force_display" parameter.
3762
3763 2019-07-17 Tom Tromey <tom@tromey.com>
3764
3765 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3766 declare.
3767 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3768 Rename from tui_first_reg_element_no_inline.
3769 (tui_display_reg_element_at_line)
3770 (tui_display_registers_from_line): Update.
3771 * tui/tui-data.h (struct tui_data_window)
3772 <first_reg_element_no_inline>: New method.
3773
3774 2019-07-17 Tom Tromey <tom@tromey.com>
3775
3776 * tui/tui-windata.c (tui_display_data_from)
3777 (tui_data_window::do_scroll_vertical): Update.
3778 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3779 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3780 Rename from tui_line_from_reg_element_no.
3781 (tui_display_registers_from_line): Update.
3782 * tui/tui-data.h (struct tui_data_window)
3783 <line_from_reg_element_no>: New method.
3784
3785 2019-07-17 Tom Tromey <tom@tromey.com>
3786
3787 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3788 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3789 tui_last_regs_line_no.
3790 (tui_display_reg_element_at_line)
3791 (tui_display_registers_from_line): Update.
3792 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3793 method.
3794
3795 2019-07-17 Tom Tromey <tom@tromey.com>
3796
3797 PR tui/24722:
3798 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3799 (tui_update_breakpoint_info): Add "being_deleted" parameter.
3800 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3801 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3802 (tui_update_breakpoint_info): Likewise.
3803 * tui/tui-hooks.c (tui_event_create_breakpoint)
3804 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3805 Update.
3806
3807 2019-07-17 Tom Tromey <tom@tromey.com>
3808
3809 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3810
3811 2019-07-17 Tom Tromey <tom@tromey.com>
3812
3813 * tui/tui-winsource.c (tui_update_source_window_as_is)
3814 (tui_update_source_windows_with_addr): Update.
3815 * tui/tui-source.h (tui_set_source_content)
3816 (tui_show_symtab_source): Add "win_info" parameter.
3817 * tui/tui-source.c (tui_set_source_content): Add "win_info"
3818 parameter.
3819 (tui_show_symtab_source): Likewise.
3820
3821 2019-07-17 Tom Tromey <tom@tromey.com>
3822
3823 * tui/tui-wingeneral.c
3824 (tui_check_and_display_highlight_if_needed): Check can_highlight.
3825
3826 2019-07-17 Tom Tromey <tom@tromey.com>
3827
3828 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3829 (struct tui_cmd_window) <can_scroll>: New method.
3830 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3831 method.
3832
3833 2019-07-17 Tom Tromey <tromey@adacore.com>
3834
3835 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3836 do_field_signed>: Rename. Change type of "value".
3837 * ui-out.c (ui_out::field_signed): Rename from field_int.
3838 Change type of "value".
3839 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
3840 type of "value".
3841 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3842 do_field_int. Change type of "value".
3843 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3844 do_field_int. Change type of "value".
3845 * tracepoint.c (trace_status_mi, tfind_1)
3846 (print_one_static_tracepoint_marker): Update.
3847 * thread.c (print_thread_info_1, print_selected_thread_frame):
3848 Update.
3849 * stack.c (print_frame, print_frame_info): Update.
3850 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3851 Update.
3852 * source.c (print_source_lines_base): Update.
3853 * skip.c (info_skip_command): Update.
3854 * record-btrace.c (btrace_ui_out_decode_error)
3855 (btrace_call_history_src_line): Update.
3856 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3857 Update.
3858 * progspace.c (print_program_space): Update.
3859 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3860 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3861 do_field_int. Change type of "value".
3862 * mi/mi-out.c (mi_ui_out::do_table_begin)
3863 (mi_ui_out::do_table_header): Update.
3864 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
3865 type of "value".
3866 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3867 (mi_cmd_data_list_changed_registers, output_register)
3868 (mi_cmd_data_read_memory, mi_load_progress)
3869 (mi_cmd_trace_frame_collected): Update.
3870 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3871 Update.
3872 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3873 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3874 (mi_cmd_var_list_children, varobj_update_one): Update.
3875 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3876 (mi_cmd_stack_list_args, list_arg_or_local): Update.
3877 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3878 * inferior.c (print_inferior): Update.
3879 * gdb_bfd.c (print_one_bfd): Update.
3880 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3881 Update.
3882 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3883 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3884 do_field_int. Change type of "value".
3885 * cli-out.c (cli_ui_out::do_field_signed): Rename from
3886 do_field_int. Change type of "value".
3887 * breakpoint.c (watchpoint_check, print_breakpoint_location)
3888 (print_one_breakpoint_location, print_it_catch_fork)
3889 (print_one_catch_fork, print_it_catch_vfork)
3890 (print_one_catch_vfork, print_it_catch_solib)
3891 (print_it_catch_exec, print_it_ranged_breakpoint)
3892 (print_mention_watchpoint, print_mention_masked_watchpoint)
3893 (bkpt_print_it, update_static_tracepoint): Update.
3894 * break-catch-throw.c (print_it_exception_catchpoint): Update.
3895 * break-catch-syscall.c (print_it_catch_syscall): Update.
3896 * ada-tasks.c (print_ada_task_info): Update.
3897 * ada-lang.c (print_it_exception, print_mention_exception):
3898 Update.
3899
3900 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
3901
3902 PR breakpoints/24541
3903 * gdbarch.c: Regenerate.
3904 * gdbarch.h: Regenerate.
3905 * gdbarch.sh: Adjust return type and parameter types for
3906 'stap_adjust_register'.
3907 (i386_stap_adjust_register): Adjust signature and return new
3908 register name.
3909 * stap-probe.c (stap_parse_register_operand): Adjust use of
3910 'gdbarch_stap_adjust_register'.
3911
3912 2019-07-17 Tom Tromey <tromey@adacore.com>
3913
3914 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
3915 declare VEC.
3916 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3917 std::vector.
3918 (struct s390_process_info): Add initializers.
3919 (s390_add_process): Use new.
3920 (s390_linux_nat_target::low_forget_process): Use delete.
3921 (s390_linux_nat_target::low_new_fork)
3922 (s390_linux_nat_target::stopped_by_watchpoint)
3923 (s390_linux_nat_target::low_prepare_to_resume)
3924 (s390_linux_nat_target::insert_watchpoint)
3925 (s390_linux_nat_target::insert_hw_breakpoint)
3926 (s390_linux_nat_target::remove_watchpoint)
3927 (s390_linux_nat_target::remove_hw_breakpoint): Update.
3928
3929 2019-07-16 John Baldwin <jhb@FreeBSD.org>
3930
3931 * aarch64-fbsd-nat.c: Include regcache.h.
3932 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3933 argument.
3934 (aarch64_fbsd_nat_target::fetch_registers)
3935 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3936 variable.
3937 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3938
3939 2019-07-16 John Baldwin <jhb@FreeBSD.org>
3940
3941 * fbsd-nat.c: Include gdbarch.h.
3942
3943 2019-07-15 Tom Tromey <tromey@adacore.com>
3944
3945 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3946
3947 2019-07-15 Tom Tromey <tromey@adacore.com>
3948
3949 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3950 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3951 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3952 * cli-out.c (cli_ui_out::do_field_int): New method.
3953 * ui-out.c (ui_out::field_unsigned): New method.
3954 * symfile.c (generic_load): Use field_unsigned.
3955 (print_transfer_performance): Likewise.
3956 * record-btrace.c (ui_out_field_uint): Remove.
3957 (btrace_call_history_insn_range, btrace_call_history): Use
3958 field_unsigned.
3959 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3960 field_unsigned.
3961 * ui-out.h (class ui_out) <field_unsigned>: New method.
3962 <do_field_unsigned>: Likewise.
3963
3964 2019-07-15 Tom Tromey <tromey@adacore.com>
3965
3966 * mi/mi-main.c (list_available_thread_groups): Use field_string.
3967 * mi/mi-interp.c (mi_memory_changed): Use field_string.
3968 * target.c (flash_erase_command): Use field_string.
3969 * infrun.c (print_signal_received_reason): Use field_string.
3970 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3971 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3972 field_string.
3973 * ada-tasks.c (print_ada_task_info): Use field_string.
3974
3975 2019-07-15 Tom Tromey <tromey@adacore.com>
3976
3977 * target.c (flash_erase_command): Use field_core_addr.
3978 * symfile.c (generic_load): Use field_core_addr.
3979 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3980 Use field_core_addr.
3981 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3982 field_core_addr.
3983
3984 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3985
3986 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3987 value if its desired type is smaller than a CORE_ADDR and signed.
3988
3989 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3990
3991 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3992 of changes to field names, and use new is_reference field to
3993 decide if a property is a reference or not.
3994 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3995 field.
3996 (struct dwarf2_property_baton): Update header comment, rename
3997 'referenced_type' to 'property_type' and update comments.
3998 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3999 default property type, store in property baton, update to take
4000 accound of renamed field.
4001 (read_func_scope): Update call to attr_to_dynamic_prop.
4002 (read_array_type): Likewise.
4003 (dwarf2_per_cu_addr_sized_int_type): New function.
4004 (read_subrange_index_type): Move type finding code to
4005 dwarf2_per_cu_addr_sized_int_type.
4006 (read_subrange_type): Update calls to attr_to_dynamic_prop.
4007 (dwarf2_per_cu_addr_type): New function.
4008 (set_die_type): Update calls to attr_to_dynamic_prop.
4009
4010 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4011
4012 * dwarf2read.c (read_subrange_index_type): New function.
4013 (read_subrange_type): Move code into new function and call it.
4014 * gdbtypes.c (create_range_type): Add some asserts.
4015
4016 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4017
4018 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4019 update return statements.
4020 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4021 declaration, and update comment to match.
4022 * gdbtypes.c (resolve_dynamic_array): Update call to
4023 dwarf2_evaluate_property to match new return type.
4024
4025 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4026
4027 * valarith.c (value_subscripted_rvalue): Change lowerbound
4028 parameter type from int to LONGEST.
4029 * value.h (value_subscripted_rvalue): Likewise in declaration.
4030
4031 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4032
4033 * cli/cli-utils.c (info_print_command_completer): New function.
4034 * cli/cli-utils.h: Add 'completer.h' include, and forward
4035 declaration for 'struct cmd_list_element'.
4036 (info_print_command_completer): Declare.
4037 * stack.c (_initialize_stack): Add completer for 'info locals' and
4038 'info args'.
4039 * symtab.c (_initialize_symtab): Add completer for 'info
4040 variables' and 'info functions'.
4041 * NEWS: Mention completion for additional info commands.
4042
4043 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4044
4045 * cli/cli-utils.c (extract_info_print_args): Delete.
4046 (extract_arg_maybe_quoted): Delete.
4047 (info_print_options_defs): New variable.
4048 (make_info_print_options_def_group): New function.
4049 (extract_info_print_options): Define new function.
4050 * cli/cli-utils.h (extract_info_print_args): Delete.
4051 (struct info_print_options): New structure.
4052 (extract_info_print_options): Declare new function.
4053 * stack.c (info_locals_command): Update to use new
4054 extract_info_print_options, also add a header comment.
4055 (info_args_command): Likewise.
4056 * symtab.c (info_variables_command): Likewise.
4057 (info_functions_command): Likewise.
4058
4059 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4060
4061 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4062 to extract string arguments.
4063 * common/common-utils.c (extract_string_maybe_quoted): New function.
4064 * common/common-utils.h (extract_string_maybe_quoted): Declare.
4065
4066 2019-07-11 Tom Tromey <tromey@adacore.com>
4067
4068 * main.c (get_init_files): Use GDBINIT, not gdbinit.
4069 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4070 * top.h (gdbinit): Don't declare.
4071 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4072 into...
4073 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
4074 * top.c (gdb_init): Don't call init_cli_cmds.
4075 (gdbinit): Remove.
4076 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4077
4078 2019-07-11 Tom Tromey <tromey@adacore.com>
4079
4080 * python/py-inferior.c (add_thread_object): Don't use thread_obj
4081 after it has been moved.
4082
4083 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4084
4085 * valops.c (value_must_coerce_to_target): Change return type to
4086 bool.
4087 * value.h (value_must_coerce_to_target): Likewise.
4088
4089 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
4090
4091 * breakpoint.c (is_hardware_watchpoint): Remove
4092 forward-declaration.
4093 (is_masked_watchpoint): Change return type to bool.
4094 (is_tracepoint): Likewise.
4095 (is_breakpoint): Likewise.
4096 (is_hardware_watchpoint): Likewise.
4097 (is_watchpoint): Likewise.
4098 (is_no_memory_software_watchpoint): Likewise.
4099 (is_catchpoint): Likewise.
4100 (breakpoint_1): Make FILTER parameter's return type bool.
4101 is_masked_watchpoint): Change return type to bool.
4102 (save_breakpoints): Make FILTER parameter's return type bool.
4103 * breakpoint.h (is_breakpoint): Change return type to bool.
4104 (is_watchpoint): Likewise.
4105 (is_catchpoint): Likewise.
4106 (is_tracepoint): Likewise.
4107
4108 2019-07-10 Tom Tromey <tom@tromey.com>
4109
4110 * defs.h: Don't include gdbarch.h.
4111 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4112 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4113 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4114 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4115 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4116 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4117 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4118 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4119 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4120 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4121 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4122 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4123 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4124 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4125 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4126 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4127 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4128 record-btrace.c, record.h, regcache-dump.c, regcache.h,
4129 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4130 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4131 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4132 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4133 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4134 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4135 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4136 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4137 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4138
4139 2019-07-10 Tom Tromey <tromey@adacore.com>
4140
4141 * ada-lang.h (is_ada_exception_catchpoint): Declare.
4142 * breakpoint.c (init_ada_exception_breakpoint): Register as
4143 bp_catchpoint.
4144 (print_one_breakpoint_location, print_one_breakpoint): Use
4145 is_ada_exception_catchpoint.
4146 * ada-lang.c (class ada_catchpoint_location): Pass
4147 bp_loc_software_breakpoint to bp_location constructor.
4148 (is_ada_exception_catchpoint): New function.
4149
4150 2019-07-10 Tom Tromey <tromey@adacore.com>
4151
4152 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
4153 VEC.
4154 (struct arm_exidx_entry): New method operator<.
4155 (struct arm_exidx_data) <section_maps>: Change type.
4156 (arm_exidx_data_free): Remove.
4157 (arm_exidx_data_key): Change type. Move lower.
4158 (arm_exidx_new_objfile): Update.
4159 (arm_compare_exidx_entries): Remove.
4160 (arm_find_exidx_entry, _initialize_arm_tdep)
4161
4162 2019-07-10 Tom Tromey <tromey@adacore.com>
4163
4164 * solib-spu.c (ocl_program_data_key): Change type.
4165 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4166 Update.
4167
4168 2019-07-10 Tom Tromey <tromey@adacore.com>
4169
4170 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
4171 (struct solib_aix_inferior_data) <library_list>: Change type.
4172 (solib_aix_inferior_data_handle): Change type.
4173 (get_solib_aix_inferior_data): Update.
4174 (solib_aix_free_library_list): Remove.
4175 (library_list_start_library): Update.
4176 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4177 return type.
4178 (solib_aix_get_library_list)
4179 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4180 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4181
4182 2019-07-10 Tom Tromey <tromey@adacore.com>
4183
4184 * solib-dsbt.c (struct dsbt_info): Add initializers.
4185 (solib_dsbt_pspace_data): Change type.
4186 (dsbt_pspace_data_cleanup): Remove.
4187 (get_dsbt_info, _initialize_dsbt_solib): Update.
4188
4189 2019-07-10 Tom Tromey <tromey@adacore.com>
4190
4191 * spu-tdep.c (spu_overlay_data): Change type.
4192 (spu_get_overlay_table, spu_overlay_new_objfile)
4193 (_initialize_spu_tdep): Update.
4194
4195 2019-07-10 Tom Tromey <tromey@adacore.com>
4196
4197 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4198 destructor.
4199 (dbx_objfile_data_key): Change type and declare later.
4200 (DBX_SYMFILE_INFO): Rewrite.
4201 * dbxread.c (dbx_objfile_data_key): Change type.
4202 (dbx_symfile_init): Update.
4203 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
4204 (coffstab_build_psymtabs, elfstab_build_psymtabs)
4205 (stabsect_build_psymtabs, _initialize_dbxread): Update.
4206
4207 2019-07-10 Tom Tromey <tromey@adacore.com>
4208
4209 * jit.c (jit_program_space_key): Change type. Move lower.
4210 (get_jit_program_space_data): Update.
4211 (jit_program_space_data_cleanup): Remove.
4212 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4213 Update.
4214 (struct jit_program_space_data): Add initializers.
4215
4216 2019-07-10 Tom Tromey <tromey@adacore.com>
4217
4218 * solib-darwin.c (struct darwin_info): Add initializers.
4219 (solib_darwin_pspace_data): Change type.
4220 (darwin_pspace_data_cleanup): Remove.
4221 (get_darwin_info, _initialize_darwin_solib): Update.
4222
4223 2019-07-10 Tom Tromey <tromey@adacore.com>
4224
4225 * remote-sim.c (struct sim_inferior_data): Add initializers,
4226 constructor, and destructor.
4227 (sim_inferior_data_key): Change type. Move lower.
4228 (check_for_duplicate_sim_descriptor): Update.
4229 (get_sim_inferior_data): Use new. Update.
4230 (~sim_inferior_data_cleanup): Rename from
4231 sim_inferior_data_cleanup. Simplify.
4232 (gdbsim_close_inferior, simulator_command)
4233 (sim_command_completer, _initialize_remote_sim): Update.
4234 (next_pid, INITIAL_PID): Move earlier.
4235
4236 2019-07-10 Tom Tromey <tromey@adacore.com>
4237
4238 * python/python-internal.h (create_thread_object): Return
4239 gdbpy_ref.
4240 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4241 * python/py-inferior.c (struct threadlist_entry): Add
4242 constructor.
4243 <thread_obj>: Now a gdbpy_ref.
4244 (thread_to_thread_object): Update.
4245 (add_thread_object): Use new.
4246 (delete_thread_object): Use delete.
4247 (infpy_threads): Update.
4248 (py_free_inferior): Update. Construct "inf_obj" after acquiring
4249 GIL.
4250
4251 2019-07-10 Tom Tromey <tromey@adacore.com>
4252
4253 * valops.c (value_cast): Specialize error message for Ada.
4254
4255 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4256
4257 * breakpoint.c (breakpoint_1): Update doc and parameter names.
4258
4259 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4260
4261 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4262 bpstat_should_step): Return bool, adjust comments.
4263 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4264 bpstat_should_step): Likewise.
4265
4266 2019-07-10 Alan Hayward <alan.hayward@arm.com>
4267
4268 * features/Makefile: Use feature target descriptions for Arm.
4269 * features/arm/arm-core.c: Generate new file.
4270 * features/arm/arm-fpa.c: Likewise.
4271 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4272 * features/arm/arm-m-profile.c: Likewise.
4273 * features/arm/arm-vfpv2.c: Likewise.
4274 * features/arm/arm-vfpv3.c: Likewise.
4275 * features/arm/xscale-iwmmxt.c: Likewise.
4276 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4277
4278 2019-07-10 Alan Hayward <alan.hayward@arm.com>
4279
4280 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4281 ptrace earlier.
4282
4283 2019-07-10 Alan Hayward <alan.hayward@arm.com>
4284
4285 * features/aarch64-pauth.c: Regenerate.
4286
4287 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
4288
4289 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4290 bool.
4291 (bpstat_what): Use false instead of 0.
4292
4293 2019-07-09 Pedro Alves <palves@redhat.com>
4294
4295 * break-catch-throw.c (is_exception_catchpoint): New.
4296 * breakpoint.c (print_one_breakpoint_location): New parameter
4297 'raw_loc'. Handle it. Use
4298 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4299 looking at the breakpoint's type.
4300 (print_one_breakpoint): If handling "maint info breakpoints", also
4301 print locations of exception catchpoints.
4302 * breakpoint.h (is_exception_catchpoint): Declare.
4303
4304 2019-07-09 Pedro Alves <palves@redhat.com>
4305
4306 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4307 "addr" field.
4308 (allocate_location_exception_catchpoint): New.
4309 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4310 (initialize_throw_catchpoint_ops): Install
4311 allocate_location_exception_catchpoint as allocate_location
4312 method.
4313 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4314 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4315 bp_loc_other.
4316 (breakpoint_address_is_meaningful): Delete.
4317 (bl_address_is_meaningful): New.
4318 (breakpoint_locations_match): Adjust comment.
4319 (bp_location_from_bp_type): New, factored out of...
4320 (bp_location::bp_location(breakpoint *)): ... this.
4321 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4322 factored out of...
4323 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
4324 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4325 breakpoint_address_is_meaningful.
4326 (bp_locations_compare): Adjust comment.
4327 (update_global_location_list): Use bl_address_is_meaningful
4328 instead of breakpoint_address_is_meaningful.
4329 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4330 explicit.
4331 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4332 * python/py-breakpoint.c (bppy_get_location): No longer check
4333 whether location is null.
4334
4335 2019-07-09 Pedro Alves <palves@redhat.com>
4336
4337 PR c++/15468
4338 * breakpoint.c (print_one_breakpoint_location): Remove
4339 single-location assert.
4340
4341 2019-07-09 Tom Tromey <tom@tromey.com>
4342
4343 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4344 * configure: Rebuild.
4345 * configure.ac: Change common to gdbsupport.
4346 * gdbsupport: Rename from common.
4347 * acinclude.m4: Change common to gdbsupport.
4348 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4349 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4350 gdbsupport.
4351 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4352 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4353 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4354 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4355 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4356 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4357 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4358 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4359 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4360 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4361 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4362 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4363 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4364 coff-pe-read.c, command.h, compile/compile-c-support.c,
4365 compile/compile-c.h, compile/compile-cplus-symbols.c,
4366 compile/compile-cplus-types.c, compile/compile-cplus.h,
4367 compile/compile-loc2c.c, compile/compile.c, completer.c,
4368 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4369 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4370 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4371 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4372 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4373 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4374 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4375 features/aarch64-core.c, features/aarch64-fpu.c,
4376 features/aarch64-pauth.c, features/aarch64-sve.c,
4377 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4378 features/i386/32bit-core.c, features/i386/32bit-linux.c,
4379 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4380 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4381 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4382 features/i386/64bit-core.c, features/i386/64bit-linux.c,
4383 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4384 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4385 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4386 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4387 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4388 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4389 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4390 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4391 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4392 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4393 go32-nat.c, guile/guile.c, guile/scm-ports.c,
4394 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4395 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4396 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4397 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4398 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4399 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4400 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4401 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4402 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4403 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4404 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4405 minsyms.c, mips-linux-tdep.c, namespace.h,
4406 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4407 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4408 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4409 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4410 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4411 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4412 nat/linux-waitpid.c, nat/mips-linux-watch.c,
4413 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4414 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4415 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4416 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4417 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4418 procfs.c, producer.c, progspace.h, psymtab.h,
4419 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4420 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4421 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4422 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4423 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4424 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4425 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4426 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4427 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4428 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4429 target-memory.c, target.c, target.h, target/waitstatus.c,
4430 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4431 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4432 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4433 unittests/array-view-selftests.c,
4434 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4435 unittests/common-utils-selftests.c,
4436 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4437 unittests/format_pieces-selftests.c,
4438 unittests/function-view-selftests.c,
4439 unittests/lookup_name_info-selftests.c,
4440 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4441 unittests/mkdir-recursive-selftests.c,
4442 unittests/observable-selftests.c,
4443 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4444 unittests/parse-connection-spec-selftests.c,
4445 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4446 unittests/scoped_fd-selftests.c,
4447 unittests/scoped_mmap-selftests.c,
4448 unittests/scoped_restore-selftests.c,
4449 unittests/string_view-selftests.c, unittests/style-selftests.c,
4450 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4451 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4452 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4453 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4454 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4455 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4456
4457 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4458
4459 * linespec.c (decode_digits_list_mode): Set explicit_line to a
4460 bool value.
4461 (decode_digits_ordinary): Set explicit_line field in sal.
4462 * symtab.c (skip_prologue_sal): Don't skip prologue for a
4463 symtab_and_line that was set on an explicit line number in
4464 assembler code. Do always update the recorded symtab and line if
4465 we do skip the prologue.
4466
4467 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4468
4469 * breakpoint.c (set_breakpoint_location_function): Remove
4470 explicit_loc parameter.
4471 (momentary_breakpoint_from_master): Update call to
4472 set_breakpoint_location_function.
4473 (add_location_to_breakpoint): Likewise.
4474
4475 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4476
4477 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4478 required features based on default bfd type when no specific bfd
4479 is present.
4480
4481 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4482
4483 * NEWS: Mention that GDB printf and eval commands can now print
4484 C-style and Ada-style convenience var strings without
4485 calling the inferior.
4486 * printcmd.c (printf_c_string): Locally print GDB internal var
4487 instead of transiting via the inferior.
4488 (printf_wide_c_string): Likewise.
4489
4490 2019-07-04 Alan Hayward <alan.hayward@arm.com>
4491
4492 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4493
4494 2019-07-04 Tom Tromey <tom@tromey.com>
4495
4496 PR tui/24724:
4497 * tui/tui-winsource.c (tui_clear_source_content): Update.
4498 (tui_source_window_base::set_is_exec_point_at): Fix comment.
4499 (tui_update_breakpoint_info): Update.
4500 (tui_set_exec_info_content): Update.
4501 * tui/tui-source.c (tui_set_source_content_nil): Update.
4502 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4503 has_break.
4504 * tui/tui-data.h (enum tui_bp_flag): New.
4505 (tui_bp_flags): New enum flags type.
4506 (struct tui_source_element) <break_mode>: Change type. Rename
4507 from has_break.
4508 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4509 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
4510 constants.
4511 * tui/tui-winsource.h: Fix comment.
4512
4513 2019-07-04 Alan Hayward <alan.hayward@arm.com>
4514
4515 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4516 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4517 (store_fpregs_to_thread)
4518 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4519 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4520 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4521 (IWMMXT_REGS_SIZE): Add define.
4522 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4523 (fetch_vfp_regs, store_vfp_regs)
4524 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4525 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4526
4527 2019-07-04 Alan Hayward <alan.hayward@arm.com>
4528
4529 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4530 defines.
4531 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4532 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4533 (ARM_INT_REGISTER_SIZE): ...to this.
4534 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4535 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4536 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4537 (arm_linux_collect_gregset, supply_nwfpe_register)
4538 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4539 defines.
4540 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4541 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4542 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4543 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4544 (arm_return_in_memory, arm_store_return_value)
4545 (arm_get_longjmp_target, arm_register_g_packet_guesses)
4546 (arm_record_ld_st_multiple): Likewise.
4547 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4548 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4549
4550 2019-07-04 Alan Hayward <alan.hayward@arm.com>
4551
4552 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4553 AARCH64_DISPLACED_MODIFIED_INSNS.
4554 * aarch64-tdep.c (struct aarch64_displaced_step_data)
4555 (aarch64_displaced_step_copy_insn): Likewise.
4556 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4557 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4558 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4559 ARM_DISPLACED_MODIFIED_INSNS.
4560 * arm-tdep.c (arm_gdbarch_init): Likewise.
4561 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4562 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4563 (struct arm_displaced_step_closure): Use
4564 ARM_DISPLACED_MODIFIED_INSNS.
4565
4566 2019-07-04 Alan Hayward <alan.hayward@arm.com>
4567
4568 * features/Makefile: Remove unused xml files.
4569 * features/aarch64.xml: Remove.
4570 * features/i386/amd64-avx-avx512-linux.xml: Remove.
4571 * features/i386/amd64-avx-avx512.xml: Remove.
4572 * features/i386/amd64-avx-linux.xml: Remove.
4573 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4574 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4575 * features/i386/amd64-avx-mpx-linux.xml: Remove.
4576 * features/i386/amd64-avx-mpx.xml: Remove.
4577 * features/i386/amd64-avx.xml: Remove.
4578 * features/i386/amd64-linux.xml: Remove.
4579 * features/i386/amd64-mpx-linux.xml: Remove.
4580 * features/i386/amd64-mpx.xml: Remove.
4581 * features/i386/amd64.xml: Remove.
4582 * features/i386/i386-avx-avx512-linux.xml: Remove.
4583 * features/i386/i386-avx-avx512.xml: Remove.
4584 * features/i386/i386-avx-linux.xml: Remove.
4585 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4586 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4587 * features/i386/i386-avx-mpx-linux.xml: Remove.
4588 * features/i386/i386-avx-mpx.xml: Remove.
4589 * features/i386/i386-avx.xml: Remove.
4590 * features/i386/i386-linux.xml: Remove.
4591 * features/i386/i386-mmx-linux.xml: Remove.
4592 * features/i386/i386-mmx.xml: Remove.
4593 * features/i386/i386-mpx-linux.xml: Remove.
4594 * features/i386/i386-mpx.xml: Remove.
4595 * features/i386/i386.xml: Remove.
4596 * features/i386/x32-avx-avx512-linux.xml: Remove.
4597 * features/i386/x32-avx-linux.xml: Remove.
4598 * features/i386/x32-linux.xml: Remove.
4599
4600 2019-07-04 Alan Hayward <alan.hayward@arm.com>
4601
4602 * regformats/aarch64.dat: Remove.
4603 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4604 * regformats/i386/amd64-avx-linux.dat: Remove.
4605 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4606 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4607 * regformats/i386/amd64-linux.dat: Remove.
4608 * regformats/i386/amd64-mpx-linux.dat: Remove.
4609 * regformats/i386/amd64.dat: Remove.
4610 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4611 * regformats/i386/i386-avx-linux.dat: Remove.
4612 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4613 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4614 * regformats/i386/i386-linux.dat: Remove.
4615 * regformats/i386/i386-mmx-linux.dat: Remove.
4616 * regformats/i386/i386-mpx-linux.dat: Remove.
4617 * regformats/i386/i386.dat: Remove.
4618 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4619 * regformats/i386/x32-avx-linux.dat: Remove.
4620 * regformats/i386/x32-linux.dat: Remove.
4621
4622 2019-07-04 Alan Hayward <alan.hayward@arm.com>
4623
4624 * aarch64-tdep.c: Remove xml self tests.
4625 * amd64-linux-tdep.c: Likewise.
4626 * amd64-tdep.c: Likewise.
4627 * i386-linux-tdep.c: Likewise.
4628 * i386-tdep.c: Likewise.
4629
4630 2019-07-03 Pedro Alves <palves@redhat.com>
4631
4632 PR cli/24732
4633 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4634 (pipe_cmd_option_defs): New.
4635 (make_pipe_cmd_options_def_group): New.
4636 (pipe_command): Use gdb::option::process_options.
4637 (pipe_command_completer): New function.
4638 (_initialize_cli_cmds): Install completer for "pipe" command.
4639
4640 2019-07-03 Pedro Alves <palves@redhat.com>
4641
4642 * cli/cli-option.c (union option_value) <string>: New field.
4643 (struct option_def_and_value): Add ctor, move ctor, dtor and
4644 use DISABLE_COPY_AND_ASSIGN.
4645 (option_def_and_value::clear_value): New.
4646 (parse_option, save_option_value_in_ctx, get_val_type_str)
4647 (add_setshow_cmds_for_options): Handle var_string.
4648 * cli-option.h (union option_def::var_address) <string>: New
4649 field.
4650 (struct string_option_def): New.
4651 * maint-test-options.c (struct test_options_opts): Add default
4652 ctor and use DISABLE_COPY_AND_ASSIGN.
4653 <string_opt>: New field.
4654 (test_options_opts::~test_options_opts): New.
4655 (test_options_opts::dump): Also dump "-string".
4656 (test_options_option_defs): Install "string.
4657
4658 2019-07-03 Pedro Alves <palves@redhat.com>
4659
4660 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4661 option_value with a null enumeration.
4662 (complete_options): Save the option values in the context.
4663 (save_option_value_in_ctx): New, factored out from ...
4664 (process_options): ... here.
4665 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4666 of the function.
4667 * maint-test-options.c (test_options_opts::dump): New, factored
4668 out from ...
4669 (maintenance_test_options_command_mode): ... here.
4670 (maintenance_test_options_command_completion_result): Delete.
4671 (maintenance_test_options_command_completion_text): Update
4672 comment.
4673 (maintenance_show_test_options_completion_result): Change
4674 prototype. Just print
4675 maintenance_test_options_command_completion_text.
4676 (save_completion_result): New.
4677 (maintenance_test_options_completer_mode): Pass options context to
4678 complete_options, and then save a dump.
4679 (_initialize_maint_test_options): Use add_cmd to install "maint
4680 show test-options-completion-result".
4681
4682 2019-07-03 Pedro Alves <palves@redhat.com>
4683
4684 * NEWS (New commands): Mention "with" and "maint with".
4685 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4686 (with_command, with_command_completer): New.
4687 (pipe_command): Adjust to new repeat_previous
4688 interface.
4689 (_initialize_cli_cmds): Install the "with" command and its "w"
4690 alias.
4691 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4692 declarations.
4693 * cli/cli-setshow.c (parse_cli_var_uinteger)
4694 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4695 argument strings for all var_types.
4696 (get_setshow_command_value_string): New, factored out from ...
4697 (do_show_command): ... this.
4698 * cli/cli-setshow.h: Include <string>.
4699 (get_setshow_command_value_string): Declare.
4700 * command.h (repeat_previous): Now returns const char *. Adjust
4701 comment.
4702 * maint.c: Include "cli/cli-cmds.h".
4703 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4704 (_initialize_maint_cmds): Register the "maintenance with" command.
4705 * top.c (repeat_previous): Move bits from pipe_command here:
4706 Return the saved command line, if any; error out if there's no
4707 command to relaunch.
4708
4709 2019-07-03 Pedro Alves <palves@redhat.com>
4710
4711 * NEWS (New commands): Mention "maint set/show test-settings"
4712 instead of "maint test-settings".
4713 * maint-test-settings.c (maintenance_test_settings_list): Delete.
4714 (maintenance_test_settings_set_list): Rename to ...
4715 (maintenance_set_test_settings_list): ... this.
4716 (maintenance_test_settings_show_list): Rename to ...
4717 (maintenance_show_test_settings_list): ... this.
4718 (maintenance_test_settings_cmd): Delete.
4719 (maintenance_test_settings_set_cmd): ...
4720 (maintenance_set_test_settings_cmd): ... this.
4721 (maintenance_test_settings_show_cmd): ...
4722 (maintenance_show_test_settings_cmd): ... this.
4723 (maintenance_test_settings_show_value_cmd):
4724 (maintenance_show_test_settings_value_cmd): ... this.
4725 (_initialize_maint_test_settings): No longer install the "maint
4726 test-settings" prefix command. Rename "maint test-settings set"
4727 to "maint set test-settings", and "maint test-settings show" to
4728 "maint show test-settings". Adjust all subcommands.
4729
4730 2019-07-03 Pedro Alves <palves@redhat.com>
4731
4732 * maint-test-settings.c: Fix file's intro comment. Replace all
4733 references to "test-options" with references to "test-settings",
4734 in comments.
4735
4736 2019-07-03 Pedro Alves <palves@redhat.com>
4737
4738 * maint-test-settings.c (maintenance_test_settings_xxx)
4739 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4740 New.
4741 (maintenance_test_settings_enums): Use them.
4742 (maintenance_test_settings_enum): Default to
4743 maintenance_test_settings_xxx.
4744 (_initialize_maint_test_settings): Initialize
4745 MAINTENANCE_TEST_SETTINGS_FILENAME.
4746
4747 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
4748
4749 * breakpoint.h (remove_breakpoints_inf): Change return type to
4750 void, move function documentation here.
4751 * breakpoint.c (remove_breakpoints_inf): Change return type to
4752 void, move function documentation to header.
4753
4754 2019-07-02 Pedro Alves <palves@redhat.com>
4755
4756 * NEWS (Completion improvements): Mention "info threads".
4757 * thread.c (struct info_threads_opts, info_threads_option_defs)
4758 (make_info_threads_options_def_group): New.
4759 (info_threads_command): Use gdb::option::process_options.
4760 (info_threads_command_completer): New.
4761 (_initialize_thread): Use gdb::option::build_help to build the
4762 help text for "info threads".
4763
4764 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
4765
4766 * defs.h (generic_load): Move from here...
4767 * symfile.h (generic_load): ... to here. Rename name parameter
4768 to args.
4769 * symfile.c (generic_load): Add comment.
4770
4771 2019-07-01 Tom Tromey <tromey@adacore.com>
4772
4773 * dwarf2read.c
4774 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4775 declaration of without_params. Fix formatting.
4776
4777 2019-07-01 Tom Tromey <tromey@adacore.com>
4778
4779 * ada-exp.y (find_primitive_type): Update.
4780 * ada-lang.h (ada_lookup_symbol): Update.
4781 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4782 parameter.
4783 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4784
4785 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
4786
4787 PR breakpoints/24541
4788 * gdbarch.c: Regenerate.
4789 * gdbarch.h: Regenerate.
4790 * gdbarch.sh: Add 'stap_adjust_register'.
4791 * i386-tdep.c: Include '<unordered_set>'.
4792 (i386_stap_adjust_register): New function.
4793 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4794 * stap-probe.c (stap_parse_register_operand): Call
4795 'gdbarch_stap_adjust_register'.
4796
4797 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
4798
4799 PR python/24742
4800 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4801 * python/python.c (do_start_initialization): Use 'xmalloc'
4802 instead of 'PyMem_Malloc'.
4803
4804 2019-06-28 Tom Tromey <tromey@adacore.com>
4805
4806 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4807 for Ada.
4808
4809 2019-06-27 Tom Tromey <tromey@adacore.com>
4810
4811 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
4812 objfile_key.
4813 (arm_find_mapping_symbol, arm_record_special_symbol)
4814 (_initialize_arm_tdep): Update.
4815 (arm_objfile_data_free): Remove.
4816
4817 2019-06-27 Tom Tromey <tromey@adacore.com>
4818
4819 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4820 to cp_print_static_field.
4821
4822 2019-06-26 Tom Tromey <tromey@adacore.com>
4823
4824 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4825 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4826 declare.
4827
4828 2019-06-26 Alan Hayward <alan.hayward@arm.com>
4829
4830 * features/aarch64-core.c (create_feature_aarch64_core):
4831 Regenerate.
4832 * features/aarch64-core.xml: Add cpsr flags.
4833
4834 2019-06-26 Alan Hayward <alan.hayward@arm.com>
4835
4836 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4837 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4838
4839 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4840
4841 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4842 field.
4843 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4844 use.
4845 (arm_record_special_symbol): Don't insert new symbol in sorted
4846 position, push it at the end.
4847
4848 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4849
4850 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4851 (arm_mapping_symbol_s): Remove.
4852 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4853 (arm_mapping_symbol_vec): New typedef.
4854 (struct arm_per_objfile): Add constructor.
4855 <section_maps>: Change type to
4856 std::unique_ptr<arm_mapping_symbol_vec[]>.
4857 (arm_compare_mapping_symbols): Remove.
4858 (arm_find_mapping_symbol): Adjust to section_maps type change.
4859 (arm_objfile_data_free): Call delete on arm_per_objfile.
4860 (arm_record_special_symbol): Adjust to section_maps type change.
4861 Allocate arm_per_objfile with new.
4862
4863 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4864
4865 * cli/cli-cmds.c (alias_command): Compare the alias prefix
4866 with the command prefix.
4867
4868 2019-06-25 Tom Tromey <tom@tromey.com>
4869
4870 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4871 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4872
4873 2019-06-25 Tom Tromey <tom@tromey.com>
4874
4875 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4876 type.
4877 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4878 protected.
4879
4880 2019-06-25 Tom Tromey <tom@tromey.com>
4881
4882 * tui/tui-winsource.c
4883 (tui_source_window_base::set_is_exec_point_at): Add check against
4884 LOA_ADDRESS.
4885
4886 2019-06-25 Tom Tromey <tom@tromey.com>
4887
4888 * tui/tui-source.c (tui_set_source_content): Don't check before
4889 xfree.
4890 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4891
4892 2019-06-25 Tom Tromey <tom@tromey.com>
4893
4894 * tui/tui-winsource.h (tui_update_source_window_as_is)
4895 (tui_alloc_source_buffer, tui_line_is_displayed)
4896 (tui_addr_is_displayed): Change type of win_info.
4897 * tui/tui-winsource.c (tui_update_source_window_as_is)
4898 (tui_clear_source_content, tui_show_source_line)
4899 (tui_show_source_content, tui_source_window_base::refill)
4900 (tui_source_window_base::set_is_exec_point_at)
4901 (tui_source_window_base::set_is_exec_point_at)
4902 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4903 (tui_alloc_source_buffer, tui_line_is_displayed)
4904 (tui_addr_is_displayed): Change type of win_info. Update.
4905 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4906 (tui_source_window_base::do_make_visible_with_new_height):
4907 Update.
4908 * tui/tui-source.c (tui_set_source_content)
4909 (tui_set_source_content_nil)
4910 (tui_source_window::do_scroll_vertical): Update.
4911 * tui/tui-layout.c (show_layout): Update.
4912 * tui/tui-disasm.c (tui_set_disassem_content)
4913 (tui_disasm_window::do_scroll_vertical): Update.
4914 * tui/tui-data.h (tui_win_content): Remove.
4915 (struct tui_gen_win_info) <content, content_size>: Remove.
4916 (struct tui_source_element): Add initializers and destructor.
4917 (union tui_which_element, struct tui_win_element): Remove.
4918 (struct tui_source_window_base) <content>: New field.
4919 (struct tui_data_window): Remove destructor.
4920 (tui_alloc_content, tui_free_win_content)
4921 (tui_free_all_source_wins_content): Don't declare.
4922 * tui/tui-data.c (tui_initialize_static_data): Update.
4923 (init_content_element, tui_alloc_content): Remove.
4924 (~tui_gen_win_info): Update.
4925 (~tui_data_window, tui_free_all_source_wins_content)
4926 (tui_free_win_content, free_content, free_content_elements):
4927 Remove.
4928
4929 2019-06-25 Tom Tromey <tom@tromey.com>
4930
4931 * tui/tui-winsource.h (tui_clear_source_content)
4932 (tui_erase_source_content, tui_show_source_content): Change type
4933 of win_info.
4934 * tui/tui-winsource.c (tui_clear_source_content)
4935 (tui_erase_source_content, tui_show_source_content): Change type
4936 of win_info.
4937 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4938 * tui/tui-source.h (tui_set_source_content_nil): Change type of
4939 win_info.
4940 * tui/tui-source.c (tui_set_source_content_nil): Change type of
4941 win_info.
4942 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4943
4944 2019-06-25 Tom Tromey <tom@tromey.com>
4945
4946 * tui/tui-winsource.c (tui_clear_source_content)
4947 (tui_source_window_base::set_is_exec_point_at): Update.
4948 * tui/tui-source.c (tui_set_source_content_nil): Update.
4949 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4950 a bool.
4951 * tui/tui-data.c (init_content_element): Update.
4952
4953 2019-06-25 Tom Tromey <tom@tromey.com>
4954
4955 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4956 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4957 * tui/tui-layout.c (init_and_make_win): Update.
4958 * tui/tui.h (enum tui_win_type): Update.
4959 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4960 tui_win_is_auxillary.
4961 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4962 tui_win_is_auxillary.
4963
4964 2019-06-25 Tom Tromey <tom@tromey.com>
4965
4966 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4967 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4968 (tui_delete_data_content_windows, tui_display_all_data)
4969 (tui_data_window::do_scroll_vertical, tui_display_data_from):
4970 Update.
4971 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4972 * tui/tui-regs.c (tui_last_regs_line_no)
4973 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4974 (tui_show_registers): Update.
4975 (tui_show_register_group): Return void. Update.
4976 (tui_display_registers_from, tui_display_reg_element_at_line)
4977 (tui_display_registers_from_line, tui_check_register_values):
4978 Update.
4979 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4980 member.
4981 (struct tui_data_window) <regs_content>: Now a std::vector.
4982 <regs_content_count>: Remove.
4983 (tui_add_content_elements, tui_free_data_content): Don't declare.
4984 * tui/tui-data.c (tui_data_window::clear_detail): Update.
4985 (init_content_element): Remove DATA_WIN case. Add assert.
4986 (tui_add_content_elements): Remove.
4987 (tui_data_window): Update.
4988 (tui_free_data_content): Remove.
4989 (free_content_elements): Remove DATA_WIN case.
4990
4991 2019-06-25 Tom Tromey <tom@tromey.com>
4992
4993 * tui/tui-data.c (tui_data_item_window): Update.
4994 * tui/tui-windata.h (tui_check_data_values): Don't declare.
4995 * tui/tui-windata.c (tui_display_all_data)
4996 (tui_display_data_from_line): Update.
4997 (tui_check_data_values): Remove.
4998 * tui/tui-regs.c (tui_show_register_group)
4999 (tui_display_reg_element_at_line): Update.
5000 * tui/tui-hooks.c (tui_register_changed)
5001 (tui_refresh_frame_and_register_information): Call
5002 tui_check_register_values.
5003 * tui/tui-data.h (struct tui_data_window) <data_content,
5004 data_content_count, data_type>: Remove.
5005 (enum tui_data_type): Remove.
5006
5007 * tui/tui-data.c (tui_data_window::clear_detail)
5008 (~tui_data_window): Update.
5009
5010 2019-06-25 Tom Tromey <tom@tromey.com>
5011
5012 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5013 declare.
5014 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5015 Rename from tui_first_data_item_displayed. Update.
5016 (tui_data_window::refresh_all)
5017 (tui_data_window::do_scroll_vertical): Update.
5018 * tui/tui-data.h (struct tui_data_window)
5019 <first_data_item_displayed>: Declare new method.
5020
5021 2019-06-25 Tom Tromey <tom@tromey.com>
5022
5023 * tui/tui-data.h (tui_init_generic_part): Don't declare.
5024 * tui/tui-data.c (tui_init_generic_part): Remove, moving
5025 contents...
5026 (tui_initialize_static_data): ...here.
5027
5028 2019-06-25 Tom Tromey <tom@tromey.com>
5029
5030 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5031 (tui_display_registers_from, tui_check_register_values): Update.
5032 (tui_display_register): Remove win_info parameter; update.
5033 (tui_get_register): Change type of parameters.
5034 * tui/tui-data.h (struct tui_data_element): Remove.
5035 (union tui_which_element) <data>: Remove.
5036 <data_window>: Change type.
5037 (struct tui_data_item_window): New.
5038 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5039 case. Add assert.
5040 (~tui_data_item_window): New destructor.
5041 (free_content_elements): Remove DATA_ITEM_WIN case.
5042
5043 2019-06-25 Tom Tromey <tom@tromey.com>
5044
5045 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5046 Remove.
5047
5048 2019-06-25 Tom Tromey <tom@tromey.com>
5049
5050 * tui/tui-data.h (struct tui_command_element): Remove.
5051 (union tui_which_element) <command>: Remove.
5052 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
5053 assert.
5054 (free_content_elements): Remove CMD_WIN case.
5055
5056 2019-06-25 Tom Tromey <tom@tromey.com>
5057
5058 * tui/tui-layout.c (tui_set_layout): Update.
5059 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5060 * tui/tui-data.c (layout_def): Update.
5061
5062 2019-06-25 Tom Tromey <tom@tromey.com>
5063
5064 * tui/tui-wingeneral.c (tui_refresh_all): Update.
5065 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5066 (tui_source_window_base::set_new_height): Update.
5067 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5068 Update.
5069 (tui_set_locator_fullname, tui_set_locator_info)
5070 (tui_show_frame_info): Update.
5071 * tui/tui-source.c (tui_set_source_content)
5072 (tui_source_is_displayed): Update.
5073 * tui/tui-layout.c (show_source_disasm_command, show_data)
5074 (show_source_or_disasm_and_command): Update.
5075 * tui/tui-disasm.c (tui_set_disassem_content)
5076 (tui_get_begin_asm_address): Update.
5077 * tui/tui-data.h (struct tui_locator_element): Remove.
5078 (union tui_which_element) <locator>: Remove.
5079 (struct tui_locator_window): New.
5080 (tui_locator_win_info_ptr): Change return type.
5081 * tui/tui-data.c (_locator): Change type.
5082 (tui_locator_win_info_ptr): Change return type.
5083 (init_content_element): Remove LOCATOR_WIN case. Add assert.
5084 (tui_alloc_content): Add assert.
5085
5086 2019-06-25 Tom Tromey <tom@tromey.com>
5087
5088 * tui/tui-winsource.c
5089 (tui_exec_info_window::maybe_allocate_content): New method.
5090 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5091 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5092 (make_source_or_disasm_window): Add cast.
5093 * tui/tui-data.h (union tui_which_element) <simple_string>:
5094 Remove.
5095 (struct tui_source_info): New.
5096 (struct tui_source_window_base) <execution_info>: Change type.
5097 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5098 case, and add assert.
5099 (tui_alloc_content): Add assert.
5100
5101 2019-06-25 Tom Tromey <tom@tromey.com>
5102
5103 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5104 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5105 * tui/tui-data.c (tui_alloc_win_info): Remove.
5106
5107 2019-06-25 Tom Tromey <tom@tromey.com>
5108
5109 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5110 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5111 can_highlight.
5112
5113 2019-06-25 Tom Tromey <tom@tromey.com>
5114
5115 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5116 make_visible_with_new_height method.
5117 (tui_win_info::make_visible_with_new_height): New method.
5118 (tui_source_window_base::do_make_visible_with_new_height)
5119 (tui_data_window::do_make_visible_with_new_height)
5120 (tui_cmd_window::do_make_visible_with_new_height): New methods.
5121 (make_visible_with_new_height): Remove.
5122 (tui_resize_all, tui_adjust_win_heights): Use
5123 make_visible_with_new_height method.
5124 * tui/tui-data.h (struct tui_win_info)
5125 <do_make_visible_with_new_height, make_visible_with_new_height>:
5126 New methods.
5127 (struct tui_source_window_base, struct tui_data_window)
5128 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5129 methods.
5130
5131 2019-06-25 Tom Tromey <tom@tromey.com>
5132
5133 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5134 method.
5135 (update_tab_width): Call update_tab_width method.
5136 * tui/tui-data.h (struct tui_win_info)
5137 (struct tui_source_window_base) <update_tab_width>: New methods.
5138
5139 2019-06-25 Tom Tromey <tom@tromey.com>
5140
5141 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5142 parameter.
5143 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5144 parameter.
5145 (tui_gen_win_info::make_visible): Update.
5146 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5147 parameter.
5148 * tui/tui-data.h (enum tui_box): New enum.
5149 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5150
5151 2019-06-25 Tom Tromey <tom@tromey.com>
5152
5153 * tui/tui-layout.c (make_source_or_disasm_window): Always use
5154 init_and_make_win for EXEC_INFO_WIN.
5155 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5156 longer inline.
5157 (struct tui_win_info) <~tui_win_info>: Inline.
5158 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5159 Don't declare.
5160 * tui/tui-data.c (source_win, disasm_win): Remove globals.
5161 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5162 Remove.
5163 (tui_initialize_static_data): Update.
5164 (~tui_gen_win_info): Handle more cleanup here.
5165 (~tui_source_window_base): Delete "execution_info".
5166 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5167
5168 2019-06-25 Tom Tromey <tom@tromey.com>
5169
5170 * tui/tui-layout.c (make_command_window): Don't set
5171 can_highlight.
5172 (show_source_disasm_command): Call the reset method.
5173 (show_data): Don't set can_highlight. Call the reset method.
5174 (tui_gen_win_info::reset): Rename from init_gen_win_info
5175 (init_and_make_win): Simplify. Return tui_gen_win_info.
5176 (show_source_or_disasm_and_command): Call the reset method.
5177 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5178 (struct tui_cmd_window): Set can_highlight.
5179
5180 2019-06-25 Tom Tromey <tom@tromey.com>
5181
5182 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5183 from make_visible.
5184 (tui_make_visible, tui_make_invisible): Rewrite.
5185 (tui_win_info::make_visible): Remove.
5186 (tui_source_window_base::make_visible): Update.
5187 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5188 method. Moved from...
5189 (struct tui_win_info) <make_visible>: ...here.
5190
5191 2019-06-25 Tom Tromey <tom@tromey.com>
5192
5193 * tui/tui-winsource.c
5194 (tui_source_window_base::do_scroll_horizontal): Remove direction
5195 parameter.
5196 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5197 direction parameter.
5198 * tui/tui-win.c (tui_win_info::forward_scroll)
5199 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5200 (tui_win_info::right_scroll): Update.
5201 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5202 direction parameter.
5203 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5204 direction parameter.
5205 * tui/tui-data.h (enum tui_scroll_direction): Remove.
5206 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5207 Remove direction parameter.
5208 (struct tui_source_window_base, struct tui_source_window)
5209 (struct tui_disasm_window, struct tui_data_window)
5210 (struct tui_cmd_window): Update.
5211
5212 2019-06-25 Tom Tromey <tom@tromey.com>
5213
5214 * tui/tui-winsource.h (tui_set_exec_info_content)
5215 (tui_show_exec_info_content, tui_erase_exec_info_content)
5216 (tui_clear_exec_info_content, tui_update_exec_info): Change
5217 argument to tui_source_window_base.
5218 * tui/tui-winsource.c (tui_set_exec_info_content)
5219 (tui_show_exec_info_content, tui_erase_exec_info_content)
5220 (tui_clear_exec_info_content, tui_update_exec_info): Change
5221 argument to tui_source_window_base.
5222
5223 2019-06-25 Tom Tromey <tom@tromey.com>
5224
5225 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5226 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5227
5228 2019-06-25 Tom Tromey <tom@tromey.com>
5229
5230 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5231 check.
5232
5233 2019-06-25 Tom Tromey <tom@tromey.com>
5234
5235 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5236 type to void.
5237 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5238 type to void.
5239 * tui/tui-source.c (tui_set_source_content): Update.
5240 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5241
5242 2019-06-25 Tom Tromey <tom@tromey.com>
5243
5244 * tui/tui-win.c (window_name_completer, tui_set_focus)
5245 (tui_all_windows_info): Use name method.
5246 * tui/tui-data.h (struct tui_gen_win_info)
5247 (struct tui_source_window, struct tui_disasm_window)
5248 (struct tui_data_window, struct tui_cmd_window) <name>: New
5249 method.
5250 (tui_win_name): Don't declare.
5251 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5252 (tui_win_name): Remove.
5253
5254 2019-06-25 Tom Tromey <tom@tromey.com>
5255
5256 * tui/tui-winsource.h (tui_update_source_window)
5257 (tui_update_source_window_as_is): Change parameter type.
5258 * tui/tui-winsource.c (tui_update_source_window): Change win_info
5259 to be a tui_source_window_base.
5260 (tui_update_source_window_as_is): Likewise.
5261 * tui/tui-win.c (make_visible_with_new_height): Update.
5262
5263 2019-06-25 Tom Tromey <tom@tromey.com>
5264
5265 * tui/tui-winsource.c (tui_erase_source_content)
5266 (tui_show_source_content, tui_show_exec_info_content)
5267 (tui_erase_exec_info_content): Use refresh_window method.
5268 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5269 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5270 from tui_refresh_win.
5271 (tui_data_window::refresh_window): New method.
5272 (tui_win_info::refresh, tui_source_window_base::refresh)
5273 (tui_refresh_all): Use refresh_window method.
5274 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5275 method.
5276 * tui/tui-regs.c (tui_display_register): Call refresh_window
5277 method.
5278 * tui/tui-layout.c (show_source_disasm_command)
5279 (show_source_or_disasm_and_command): Call refresh_window method.
5280 * tui/tui-data.h (struct tui_gen_win_info)
5281 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5282 New method.
5283
5284 2019-06-25 Tom Tromey <tom@tromey.com>
5285
5286 * tui/tui.c (tui_rl_other_window, tui_enable)
5287 (tui_is_window_visible, tui_get_command_dimension): Update.
5288 * tui/tui-winsource.c (tui_update_source_window_as_is)
5289 (tui_clear_source_content, tui_erase_source_content)
5290 (tui_show_source_line, tui_source_window_base::refill)
5291 (tui_source_window_base::do_scroll_horizontal)
5292 (tui_source_window_base::set_is_exec_point_at)
5293 (tui_update_breakpoint_info, tui_set_exec_info_content)
5294 (tui_alloc_source_buffer, tui_line_is_displayed)
5295 (tui_addr_is_displayed): Update.
5296 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5297 (tui_check_and_display_highlight_if_needed)
5298 (tui_win_info::make_visible, tui_win_info::refresh)
5299 (tui_refresh_all): Update.
5300 * tui/tui-windata.c (tui_first_data_item_displayed)
5301 (tui_delete_data_content_windows, tui_erase_data_content)
5302 (tui_display_all_data, tui_data_window::refresh_all)
5303 (tui_check_data_values): Update.
5304 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5305 (tui_set_win_focus_to, tui_win_info::forward_scroll)
5306 (tui_win_info::backward_scroll, tui_refresh_all_win)
5307 (tui_resize_all, tui_set_focus, tui_all_windows_info)
5308 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5309 (tui_source_window_base::set_new_height)
5310 (tui_data_window::set_new_height)
5311 (make_invisible_and_set_new_height)
5312 (make_visible_with_new_height, new_height_ok)
5313 (parse_scrolling_args): Update.
5314 * tui/tui-stack.c (tui_show_frame_info): Update.
5315 * tui/tui-source.c (tui_set_source_content)
5316 (tui_set_source_content_nil, tui_source_is_displayed)
5317 (tui_source_window::do_scroll_vertical): Update.
5318 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5319 (tui_display_registers_from, tui_display_reg_element_at_line)
5320 (tui_check_register_values, tui_reg_command): Update.
5321 * tui/tui-layout.c (tui_default_win_height)
5322 (show_source_disasm_command, show_data, init_and_make_win)
5323 (show_source_or_disasm_and_command): Update.
5324 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5325 (tui_redisplay_readline, tui_mld_flush)
5326 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5327 (tui_getc): Update.
5328 * tui/tui-disasm.c (tui_set_disassem_content)
5329 (tui_disasm_window::do_scroll_vertical): Update.
5330 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5331 Now virtual.
5332 (struct tui_win_info): Derive from tui_gen_win_info.
5333 <~tui_win_info>: Mark as override.
5334 <generic>: Remove member.
5335 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5336 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5337 (~tui_data_window, ~tui_win_info)
5338 (tui_free_all_source_wins_content): Update.
5339 * tui/tui-command.c (tui_refresh_cmd_win): Update.
5340
5341 2019-06-25 Tom Tromey <tom@tromey.com>
5342
5343 * tui/tui-layout.c (init_and_make_win): Use new.
5344 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5345 destructor, initializers.
5346 (tui_alloc_generic_win_info): Don't declare.
5347 * tui/tui-data.c (_locator): Add argument to constructor.
5348 (source_win, disasm_win): New globals.
5349 (exec_info): Remove.
5350 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5351 Update.
5352 (tui_alloc_generic_win_info): Remove.
5353 (init_content_element): Use new.
5354 (tui_win_info::tui_win_info): Update.
5355 (free_content_elements) <case DATA_WIN>: Use delete.
5356
5357 2019-06-25 Tom Tromey <tom@tromey.com>
5358
5359 * tui/tui-wingeneral.c (tui_refresh_win): Update.
5360 * tui/tui-windata.c (tui_first_data_item_displayed)
5361 (tui_delete_data_content_windows): Update.
5362 * tui/tui-win.c (tui_data_window::set_new_height): Update.
5363 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5364 (tui_display_registers_from, tui_check_register_values): Update.
5365 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5366 pointer.
5367 * tui/tui-data.c (init_content_element): Update. Allocate the new
5368 window.
5369 (tui_free_data_content): Update.
5370 (free_content_elements) <case DATA_WIN>: Free the window.
5371
5372 2019-06-25 Tom Tromey <tom@tromey.com>
5373
5374 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5375 Update.
5376 * tui/tui-layout.c (make_command_window)
5377 (show_source_disasm_command, show_data, init_and_make_win)
5378 (show_source_or_disasm_and_command): Update.
5379 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5380 method.
5381 <can_highight, is_highlighted>: Now bool.
5382 (tui_set_win_highlight): Don't declare.
5383 * tui/tui-data.c (tui_set_win_highlight): Remove.
5384
5385 2019-06-25 Tom Tromey <tom@tromey.com>
5386
5387 * tui/tui-wingeneral.c (make_visible): Remove check of window
5388 type.
5389
5390 2019-06-25 Tom Tromey <tom@tromey.com>
5391
5392 * tui/tui-win.c (tui_win_info::max_height)
5393 (tui_cmd_window::max_height): New methods.
5394 (new_height_ok): Call max_height.
5395 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5396 <max_height>: New method.
5397
5398 2019-06-25 Tom Tromey <tom@tromey.com>
5399
5400 * tui/tui-win.c (tui_source_window_base::set_new_height)
5401 (tui_data_window::set_new_height): New methods.
5402 (make_invisible_and_set_new_height): Call set_new_height method.
5403 * tui/tui-data.h (struct tui_win_info)
5404 (struct tui_source_window_base, struct tui_data_window)
5405 <set_new_height>: New method.
5406
5407 2019-06-25 Tom Tromey <tom@tromey.com>
5408
5409 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5410 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5411 tui_refresh_data_win.
5412 * tui/tui-win.c (tui_source_window_base::refresh_all): New
5413 method.
5414 (tui_refresh_all_win): Call the refresh_all method.
5415 (tui_set_focus): Likewise.
5416 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5417 (struct tui_source_window_base, struct tui_data_window) <refresh>:
5418 Likewise.
5419
5420 2019-06-25 Tom Tromey <tom@tromey.com>
5421
5422 * tui/tui-winsource.h (tui_refill_source_window)
5423 (tui_set_is_exec_point_at): Don't declare.
5424 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5425 (tui_source_window_base::refill): Rename from
5426 tui_refill_source_window.
5427 (tui_source_window_base::do_scroll_horizontal): Update.
5428 (tui_source_window_base::set_is_exec_point_at): Rename from
5429 tui_set_is_exec_point_at.
5430 (tui_update_all_breakpoint_info): Update.
5431 * tui/tui-stack.c (tui_show_frame_info): Update.
5432 * tui/tui-layout.c (show_data): Add cast.
5433 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5434 * tui/tui-data.h (struct tui_source_window_base) <refill,
5435 set_is_exec_point_at>: New methods.
5436 (tui_source_windows, tui_add_to_source_windows): Update types.
5437 (tui_add_to_source_windows): Remove redundant declaration.
5438 * tui/tui-data.c (source_windows): Store tui_source_window_base.
5439 (tui_source_windows): Change return type.
5440 (tui_clear_source_windows_detail): Update.
5441 (tui_add_to_source_windows): Change type of parameter.
5442 (tui_free_all_source_wins_content): Update.
5443
5444 2019-06-25 Tom Tromey <tom@tromey.com>
5445
5446 * tui/tui-wingeneral.c (tui_win_info::refresh)
5447 (tui_source_window_base::refresh): New methods.
5448 (tui_refresh_all): Call the refresh method.
5449 * tui/tui-data.h (struct tui_win_info)
5450 (struct tui_source_window_base) <refresh>: New method.
5451
5452 2019-06-25 Tom Tromey <tom@tromey.com>
5453
5454 * tui/tui.h (tui_is_window_visible): Return bool.
5455 * tui/tui.c (tui_is_window_visible): Return bool.
5456 * tui/tui-wingeneral.c (tui_make_window, make_visible)
5457 (tui_make_visible, tui_make_invisible)
5458 (tui_win_info::make_visible)
5459 (tui_source_window_base::make_visible, make_all_visible)
5460 (tui_make_all_visible, tui_make_all_invisible): Update.
5461 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5462 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5463 bool.
5464 (struct tui_win_info, struct tui_source_window_base)
5465 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5466 * tui/tui-data.c (tui_init_generic_part): Update.
5467
5468 2019-06-25 Tom Tromey <tom@tromey.com>
5469
5470 * tui/tui-wingeneral.c (tui_win_info::make_visible)
5471 (tui_source_window_base::make_visible): New methods.
5472 (make_all_visible): Make method call.
5473 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5474 (struct tui_source_window_base, struct tui_cmd_window): Override
5475 make_visible.
5476 (tui_win_is_source_type): Don't declare.
5477 * tui/tui-data.c (tui_win_is_source_type): Remove.
5478
5479 2019-06-25 Tom Tromey <tom@tromey.com>
5480
5481 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5482 NULL check.
5483
5484 2019-06-25 Tom Tromey <tom@tromey.com>
5485
5486 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5487 Inline constructor. Add initializers for members.
5488 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5489 constructors; now inline in class.
5490
5491 2019-06-25 Tom Tromey <tom@tromey.com>
5492
5493 * tui/tui-regs.c (tui_show_registers): Update.
5494 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5495 bool.
5496 * tui/tui-data.c (tui_data_window::clear_detail)
5497 (tui_data_window): Update.
5498
5499 2019-06-25 Tom Tromey <tom@tromey.com>
5500
5501 * tui/tui-windata.c (tui_display_all_data)
5502 (tui_display_data_from_line, tui_display_data_from)
5503 (tui_check_data_values, tui_data_window::do_scroll_vertical):
5504 Update.
5505 * tui/tui-regs.c (tui_last_regs_line_no)
5506 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5507 (tui_show_registers, tui_show_register_group)
5508 (tui_display_registers_from, tui_display_reg_element_at_line)
5509 (tui_display_registers_from_line, tui_check_register_values)
5510 (tui_reg_next, tui_reg_prev): Update.
5511 * tui/tui-layout.c (tui_set_layout, show_data): Update.
5512 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
5513 tui_data_window.
5514 (struct tui_win_info) <detail>: Remove. Add new fields from
5515 tui_data_info.
5516 (TUI_DATA_WIN): Add cast.
5517 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5518 (~tui_data_window): Simplify.
5519
5520 2019-06-25 Tom Tromey <tom@tromey.com>
5521
5522 * tui/tui-layout.c (show_source_disasm_command)
5523 (show_source_or_disasm_and_command): Update.
5524 * tui/tui-io.c (update_cmdwin_start_line)
5525 (tui_redisplay_readline): Update.
5526 * tui/tui-data.h (struct tui_command_info): Remove.
5527 (struct tui_win_info) <detail>: Remove command_info member.
5528 (struct tui_data_window) <start_line>: New member, from
5529 tui_command_info.
5530 (TUI_CMD_WIN): Add casts.
5531
5532 2019-06-25 Tom Tromey <tom@tromey.com>
5533
5534 * tui/tui-winsource.c (tui_update_source_window)
5535 (tui_refill_source_window)
5536 (tui_source_window_base::do_scroll_horizontal)
5537 (tui_update_breakpoint_info, tui_set_exec_info_content)
5538 (tui_show_exec_info_content, tui_erase_exec_info_content)
5539 (tui_clear_exec_info_content): Update.
5540 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5541 Update.
5542 * tui/tui-win.c (make_invisible_and_set_new_height)
5543 (make_visible_with_new_height): Update.
5544 * tui/tui-source.c (tui_set_source_content)
5545 (tui_show_symtab_source): Update.
5546 * tui/tui-layout.c (extract_display_start_addr)
5547 (show_source_disasm_command, show_data)
5548 (make_source_or_disasm_window)
5549 (show_source_or_disasm_and_command): Update.
5550 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5551 (tui_disasm_window::do_scroll_vertical): Remove shadowing
5552 "gdbarch".
5553 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
5554 to tui_source_window_base.
5555 (struct tui_win_info) <detail>: Remove source_info member.
5556 (struct tui_source_window_base) <has_locator>: Inline.
5557 Move contents from tui_source_info; rename has_locator member to
5558 m_has_locator.
5559 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5560 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5561 header file.
5562 (tui_source_window_base::clear_detail, ~tui_source_window_base):
5563 Simplify.
5564 (tui_free_all_source_wins_content): Cast to
5565 tui_source_window_base.
5566
5567 2019-06-25 Tom Tromey <tom@tromey.com>
5568
5569 * tui/tui-win.c (make_invisible_and_set_new_height)
5570 (make_visible_with_new_height): Call has_locator method.
5571 * tui/tui-layout.c (show_source_disasm_command, show_data)
5572 (show_source_or_disasm_and_command): Update for bool change.
5573 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5574 (tui_win_info) <has_locator>: New method.
5575 (struct tui_source_window_base) <has_locator>: New method.
5576 (tui_win_has_locator): Don't declare.
5577 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5578 from tui_win_has_locator.
5579 (tui_source_window_base): Use false, not FALSE.
5580
5581 2019-06-25 Tom Tromey <tom@tromey.com>
5582
5583 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5584 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5585 clear_detail method directly.
5586 (tui_clear_win_detail): Remove.
5587
5588 2019-06-25 Tom Tromey <tom@tromey.com>
5589
5590 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5591 "this", not TUI_DISASM_WIN.
5592
5593 2019-06-25 Tom Tromey <tom@tromey.com>
5594
5595 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
5596 declare.
5597 * tui/tui-winsource.c
5598 (tui_source_window_base::do_scroll_horizontal): Rename from
5599 tui_horizontal_source_scroll.
5600 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5601 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5602 from tui_vertical_data_scroll.
5603 * tui/tui-win.h (tui_scroll): Don't declare.
5604 * tui/tui-win.c (tui_win_info::forward_scroll)
5605 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5606 (tui_win_info::right_scroll): Rename and update.
5607 (tui_scroll_forward_command, tui_scroll_backward_command)
5608 (tui_scroll_left_command, tui_scroll_right_command): Update.
5609 (tui_scroll): Remove.
5610 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5611 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5612 from tui_vertical_source_scroll.
5613 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5614 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5615 from tui_vertical_disassem_scroll.
5616 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5617 do_scroll_horizontal>: New methods.
5618 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5619 Likewise.
5620 (struct tui_source_window_base): Add do_scroll_horizontal.
5621 (struct tui_source_window, struct tui_disasm_window): Add
5622 do_scroll_vertical.
5623 (struct tui_data_window, struct tui_cmd_window): Add
5624 do_scroll_horizontal and do_scroll_vertical.
5625 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5626
5627 2019-06-25 Tom Tromey <tom@tromey.com>
5628
5629 * tui/tui-data.h (struct tui_source_window_base): New struct.
5630 (struct tui_source_window): Derive from tui_source_window_base.
5631 (struct tui_disasm_window): New struct.
5632 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5633 from tui_source_window::clear_detail.
5634 (tui_source_window_base): Rename from tui_source_window.
5635 (~tui_source_window_base): Rename from ~tui_source_window.
5636 (tui_alloc_win_info): Create a tui_disasm_window.
5637
5638 2019-06-25 Tom Tromey <tom@tromey.com>
5639
5640 * tui/tui-data.h (struct tui_source_window)
5641 (struct tui_data_window): Declare destructors.
5642 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5643 destructors.
5644 (tui_win_info): Simplify.
5645
5646 2019-06-25 Tom Tromey <tom@tromey.com>
5647
5648 * tui/tui-winsource.c (tui_display_main)
5649 (tui_update_source_windows_with_addr)
5650 (tui_update_all_breakpoint_info): Update.
5651 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5652 (new_height_ok, parse_scrolling_args): Update.
5653 * tui/tui-stack.c (tui_show_frame_info): Update.
5654 * tui/tui-data.h (struct tui_list): Remove.
5655 (tui_source_windows): Return a reference to a std::vector.
5656 * tui/tui-data.c (source_windows): Now a std::vector.
5657 (tui_source_windows): Change return type.
5658 (tui_clear_source_windows): Rewrite.
5659 (tui_clear_source_windows_detail, tui_add_to_source_windows)
5660 (tui_free_all_source_wins_content): Rewrite.
5661
5662 2019-06-25 Tom Tromey <tom@tromey.com>
5663
5664 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5665 (struct tui_data_window, struct tui_cmd_window): Declare
5666 clear_detail method.
5667 * tui/tui-data.c (tui_source_window::clear_detail)
5668 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5669 methods.
5670 (tui_clear_win_detail): Simplify.
5671
5672 2019-06-25 Tom Tromey <tom@tromey.com>
5673
5674 * tui/tui-layout.c (make_source_window, make_disasm_window)
5675 (make_source_or_disasm_window): Remove win_info_ptr parameter.
5676 Return the new window.
5677 (show_source_disasm_command, show_data)
5678 (show_source_or_disasm_and_command): Update.
5679
5680 2019-06-25 Tom Tromey <tom@tromey.com>
5681
5682 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5683 parameter. Return the new window.
5684 (show_source_disasm_command): Update and remove NULL check.
5685 (show_source_or_disasm_and_command): Update.
5686
5687 2019-06-25 Tom Tromey <tom@tromey.com>
5688
5689 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5690
5691 2019-06-25 Tom Tromey <tom@tromey.com>
5692
5693 * tui/tui-data.h (struct tui_win_info): Make constructor
5694 protected. Make destructor virtual. Add initializers.
5695 (tui_source_window, tui_data_window, tui_cmd_window): New
5696 classes.
5697 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
5698 constructor. Add "type" parameter.
5699 (tui_source_window, tui_data_window, tui_cmd_window): New
5700 constructors.
5701 (tui_alloc_win_info): Instantiate the appropriate subclass.
5702
5703 2019-06-25 Tom Tromey <tom@tromey.com>
5704
5705 * tui/tui-win.c (tui_resize_all): Use delete.
5706 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5707 destructor.
5708 (tui_free_window): Don't declare.
5709 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5710 Update.
5711
5712 2019-06-25 Tom Tromey <tom@tromey.com>
5713
5714 * tui/tui-data.h (struct tui_win_info): Add constructor.
5715 * tui/tui-data.c (tui_alloc_win_info): Use new.
5716 (tui_free_window): Use delete.
5717
5718 2019-06-22 Tom Tromey <tom@tromey.com>
5719
5720 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5721 declare.
5722 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5723
5724 2019-06-22 Tom Tromey <tom@tromey.com>
5725
5726 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5727 declare.
5728 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5729
5730 2019-06-22 Tom de Vries <tdevries@suse.de>
5731
5732 * dwarf2read.c (create_addrmap_from_aranges)
5733 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5734 instead of '%zu'.
5735
5736 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
5737
5738 * dwarf2read.h (dwarf2_section_info_def): Remove.
5739 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5740 * dwarf2read.c (struct dwo_sections) <types>: Change type to
5741 std::vector<dwarf2_section_info>.
5742 (struct dwo_file) <~dwo_file>: Remove.
5743 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5744 types field.
5745 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5746 (dwarf2_read_debug_names): Likewise.
5747 (create_debug_types_hash_table): Change parameter type to
5748 array_view, adjust code accordingly.
5749 (dwarf2_locate_dwo_sections): Adjust to std::vector.
5750 (partial_die_info::fixup): Likewise.
5751 (determine_prefix): Likewise.
5752 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5753
5754 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5755
5756 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5757 gdb_bfd_ref_ptr.
5758 <~dwo_file>: Remove call to gdb_bfd_unref.
5759 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5760 gdb_bfd_ref_ptr::get.
5761
5762 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5763
5764 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5765 type to htab_up.
5766 * dwarf2read.c (struct dwo_file): Initialize fields.
5767 <~dwo_file>: New.
5768 (free_dwo_file): Remove, move content to ~dwo_file.
5769 (struct dwo_file_deleter): Remove.
5770 (dwo_file_up>: Remove custom deleter.
5771 (free_dwo_files): Remove.
5772 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5773 dwo_files.
5774 (process_skeletonless_type_units): Call unique_ptr::get.
5775 (allocate_dwo_file_hash_table): Add deleter to created hash
5776 table. Change return type to htab_up.
5777 (lookup_dwo_file_slot): Don't memset dwo_file, call
5778 unique_ptr::get.
5779 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5780 (create_dwo_unit_in_dwp_v2): Likewise.
5781 (open_and_init_dwo_file): Likewise.
5782 (free_dwo_file_from_slot): Remove.
5783
5784 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5785
5786 * dwarf2read.h (struct dwarf2_section_info) <readin,
5787 is_virtual>: Change type to bool.
5788 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5789 true instead of 1.
5790
5791 2019-06-19 Tom Tromey <tom@tromey.com>
5792
5793 * tui/tui-data.h (tui_init_content_element): Don't declare.
5794
5795 2019-06-19 Tom Tromey <tom@tromey.com>
5796
5797 * tui/tui-data.h (tui_init_win_info): Don't declare.
5798
5799 2019-06-19 Tom de Vries <tdevries@suse.de>
5800
5801 * dwarf2read.h (abstract_to_concrete): Change type to
5802 std::unordered_map<sect_offset, std::vector<sect_offset>,
5803 gdb::hash_enum<sect_offset>>.
5804
5805 2019-06-19 Tom Tromey <tromey@adacore.com>
5806
5807 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5808 EVAL_AVOID_SIDE_EFFECTS specially.
5809
5810 2019-06-19 Tom Tromey <tromey@adacore.com>
5811
5812 * source-cache.c (highlighter): New global.
5813 (source_cache::get_source_lines): Create a highlighter on demand.
5814
5815 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
5816
5817 * defs.h (deprecated_interactive_hook): Delete declaration.
5818 * interps.c (clear_interpreter_hooks): Remove use of
5819 deprecated_interactive_hook.
5820 * top.c (deprecated_interactive_hook): Delete definition.
5821 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5822
5823 2019-06-18 Tom de Vries <tdevries@suse.de>
5824
5825 PR gdb/24515
5826 * dwarf2read.h (abstract_to_concrete): Change type from
5827 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5828 std::unordered_map<sect_offset, std::vector<sect_offset>>.
5829 * dwarf2read.c (read_variable): Update.
5830 (dwarf2_fetch_die_loc_sect_off): Update.
5831
5832 2019-06-17 Tom de Vries <tdevries@suse.de>
5833
5834 PR gdb/24617
5835 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5836 accessing parent[parent_len - 1].
5837
5838 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
5839
5840 PR gdb/24364
5841 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5842 call dtrace_process_dof with NULL dof.
5843
5844 2019-06-16 Tom de Vries <tdevries@suse.de>
5845
5846 PR gdb/24445
5847 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5848
5849 2019-06-16 Tom Tromey <tom@tromey.com>
5850
5851 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5852 (make_all_visible): Use address of member.
5853
5854 2019-06-16 Tom Tromey <tom@tromey.com>
5855
5856 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5857 (tui_free_window, free_content, free_content_elements): Remove
5858 unnecessary cast.
5859 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5860 cast.
5861 * tui/tui-regs.c (tui_show_register_group)
5862 (tui_display_registers_from, tui_display_reg_element_at_line):
5863 Remove unnecessary cast.
5864
5865 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
5866
5867 * linux-nat.c (normal_mask): Delete.
5868 (_initialize_linux_nat): Don't initialise normal_mask.
5869
5870 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
5871
5872 PR gdb/24445
5873 * dwarf-index-write.h (write_psymtabs_to_index): Add
5874 dwz_basename parameter.
5875 * dwarf-index-write.c (write_gdbindex): Move file writing to
5876 write_gdbindex_1. Change return type void.
5877 (assert_file_size): Move up, remove filename parameter.
5878 (write_gdbindex_1): New function.
5879 (write_debug_names): Change return type to void, call
5880 assert_file_size.
5881 (struct index_wip_file): New struct.
5882 (write_psymtabs_to_index): Add dwz_basename parameter. Move
5883 file logic to index_wip_file. Write index for dwz file if
5884 needed.
5885 (save_gdb_index_command): Pass basename of dwz file, if present.
5886 * dwarf-index-cache.c (index_cache::store): Obtain and pass
5887 build-id of dwz file, if present.
5888 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5889 (dwarf2_get_dwz_file): Likewise.
5890 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5891 (dwarf2_get_dwz_file): Likewise.
5892
5893 2019-06-16 Tom Tromey <tom@tromey.com>
5894
5895 * coffread.c (process_coff_symbol): Use xstrdup.
5896 * value.c (create_internalvar): Use xstrdup.
5897
5898 2019-06-16 Tom Tromey <tom@tromey.com>
5899
5900 * valops.c (value_cast, value_slice): Remove unnecessary cast.
5901 * breakpoint.c (stopin_command, stopat_command)
5902 (until_break_command, decode_location_default): Remove unnecessary
5903 cast.
5904 * utils.c (subset_compare): Remove unnecessary cast.
5905 * ada-lang.c (ada_update_initial_language): Remove unnecessary
5906 cast.
5907 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5908 cast.
5909 * infcmd.c (path_command): Remove unnecessary cast.
5910 * coffread.c (decode_type): Remove unnecessary cast.
5911 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5912 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5913 * tui/tui-stack.c (tui_show_locator_content)
5914 (tui_show_frame_info): Remove unnecessary cast.
5915 * tui/tui-win.c (tui_scroll_forward_command)
5916 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5917 (parse_scrolling_args): Remove unnecessary cast.
5918 * tui/tui-data.c (init_win_info, tui_del_window)
5919 (tui_free_window, tui_del_data_windows, tui_free_data_content)
5920 (free_content_elements): Remove unnecessary cast.
5921 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5922 unnecessary cast.
5923 * tui/tui-source.c (tui_set_source_content)
5924 (tui_vertical_source_scroll): Remove unnecessary cast.
5925 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5926 cast.
5927 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5928 * tui/tui-regs.c (tui_display_registers_from)
5929 (tui_display_register): Remove unnecessary cast.
5930 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5931 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5932 (make_visible): Remove unnecessary cast.
5933 * tui/tui-winsource.c (tui_erase_source_content)
5934 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5935 unnecessary cast.
5936 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5937 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5938 * stabsread.c (read_type, read_array_type, read_range_type):
5939 Remove unnecessary cast.
5940 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5941 (parse_symbol, parse_type, upgrade_type, parse_external)
5942 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5943 unnecessary cast.
5944 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5945
5946 2019-06-16 Tom Tromey <tom@tromey.com>
5947
5948 * tui/tui-data.c (tui_alloc_generic_win_info)
5949 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5950 checks.
5951
5952 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
5953 Andrew Burgess <andrew.burgess@embecosm.com>
5954
5955 * f-typeprint.c (f_print_type): Don't return early for not
5956 associated or not allocated types.
5957 (f_type_print_varspec_suffix): Add print_rank parameter and print
5958 ranks of array types in case they dangling.
5959 (f_type_print_base): Add print_rank parameter.
5960
5961 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5962
5963 * NEWS: Mention new MI commands.
5964 * break-catch-throw.c (enum exception_event_kind): Move to
5965 breakpoint.h.
5966 (print_mention_exception_catchpoint): Output text as a single
5967 message.
5968 (catch_exception_command_1): Rename to...
5969 (catch_exception_event): ...this, make non-static, update header
5970 command, and change some parameter types.
5971 (catch_catch_command): Update for changes to
5972 catch_exception_command_1.
5973 (catch_throw_command): Likewise.
5974 (catch_rethrow_command): Likewise.
5975 * breakpoint.c (enum exception_event_kind): Delete.
5976 * breakpoint.h (enum exception_event_kind): Moved here from
5977 break-catch-throw.c.
5978 (catch_exception_event): Declare.
5979 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5980 (mi_cmd_catch_throw): New function.
5981 (mi_cmd_catch_rethrow): New function.
5982 (mi_cmd_catch_catch): New function.
5983 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5984 'catch-catch' entries.
5985 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5986 (mi_cmd_catch_rethrow): Declare.
5987 (mi_cmd_catch_catch): Declare.
5988
5989 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5990
5991 * annotate.c (annotate_source_line): Change return type to void,
5992 update implementation to match.
5993 * annotate.h (annotate_source_line): Change return type to void,
5994 update header comment.
5995 * stack.c (print_frame_info): Don't change what frame information
5996 is printed based on whether annotations are on or not.
5997
5998 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5999
6000 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6001 (annotate_source): Make static.
6002 (annotate_source_line): Moved from source.c and renamed from
6003 identify_source_line. Update the return type.
6004 * annotate.h (annotate_source): Delete declaration.
6005 (annotate_source_line): Declaration moved from source.h, and
6006 renamed from identify_source_line. Return type updated.
6007 * source.c (identify_source_line): Moved to annotate.c and renamed
6008 to annotate_source_line.
6009 (info_line_command): Remove check of annotation_level.
6010 * source.h (identify_source_line): Move declaration to annotate.h
6011 and rename to annotate_source_line.
6012 * stack.c: Add 'annotate.h' include.
6013 (print_frame_info): Remove check of annotation_level before
6014 calling annotate_source_line.
6015
6016 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6017
6018 * source-cache.c (source_cache::get_plain_source_lines): Use
6019 open_source_file_with_line_charpos instead of just
6020 open_source_file, remove call to find_source_lines.
6021 (source_cache::get_source_lines): Likewise.
6022 * source.c (find_source_lines): Make static.
6023 (get_filename_and_charpos): Renamed into...
6024 (open_source_file_with_line_charpos): ..this along with changes to
6025 return a scoped_fd, and some other minor clean ups.
6026 (identify_source_line): Use open_source_file_with_line_charpos.
6027 (search_command_helper): Use open_source_file_with_line_charpos
6028 instead of just open_source_file, remove call to
6029 find_source_lines.
6030 * source.h (open_source_file_with_line_charpos): Declare new
6031 function.
6032 (find_source_lines): Delete declaration.
6033
6034 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6035
6036 * source.c (get_filename_and_charpos): Remove fullname
6037 parameter.
6038 (identify_source_line): Update call to get_filename_and_charpos.
6039
6040 2019-06-14 Tom Tromey <tromey@adacore.com>
6041
6042 PR gdb/24502:
6043 * ui-style.h (skip_ansi_escape): Update comment.
6044 * ui-file.h (class no_terminal_escape_file): New class.
6045 * ui-file.c (no_terminal_escape_file::write)
6046 (no_terminal_escape_file::puts): New methods.
6047 * cli/cli-logging.c (handle_redirections): Use
6048 no_terminal_escape_file.
6049
6050 2019-06-14 Tom Tromey <tromey@adacore.com>
6051
6052 * NEWS: Move convenience variable news above Python news.
6053
6054 2019-06-14 Tom Tromey <tom@tromey.com>
6055
6056 * gnulib: Move directory to top-level.
6057 * configure.ac: Don't configure gnulib.
6058 * configure: Rebuild.
6059 * common/common-defs.h: Use new path to gnulib.
6060 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6061 (GNULIB_H): Remove.
6062 (INCGNU): Look in new gnulib location.
6063 (HFILES_NO_SRCDIR): Remove gnulib files.
6064 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6065 (generated_files): Remove GNULIB_H.
6066 ($(LIBGNU), all-lib): Remove targets.
6067 (distclean): Don't mention GNULIB_BUILDDIR.
6068 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6069
6070 2019-06-14 Tom Tromey <tromey@adacore.com>
6071
6072 * symfile.c (add_symbol_file_command): Remove obsolete comment.
6073 Warn if symbol file does not provide any symbols.
6074
6075 2019-06-14 Tom Tromey <tromey@adacore.com>
6076
6077 * source.c (find_and_open_source): Respect basenames_may_differ.
6078
6079 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
6080
6081 * annotate.c (annotate_breakpoints_invalid): Make use of
6082 scoped_restore_terminal_state.
6083 (annotate_frames_invalid): Likewise.
6084
6085 2019-06-14 Tom Tromey <tromey@adacore.com>
6086
6087 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6088 allow assignment to an internalvar.
6089
6090 2019-06-14 Tom Tromey <tromey@adacore.com>
6091
6092 * ada-lex.l: Allow "_" in attribute names.
6093
6094 2019-06-14 Tom Tromey <tromey@adacore.com>
6095
6096 PR gdb/24653:
6097 * regcache.c (registers_changed): Don't call alloca.
6098 * top.c (execute_command): Don't call alloca.
6099
6100 2019-06-13 Pedro Alves <palves@redhat.com>
6101
6102 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6103 'expression'. When parsing an expression, error out if there's
6104 junk after "unlimited".
6105 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6106 (do_set_command): Adjust calls to is_unlimited_literal.
6107
6108 2019-06-13 Pedro Alves <palves@redhat.com>
6109
6110 * compile/compile.c (make_compile_options_def_group): Add braces
6111 around array_view initializer.
6112 * thread.c (make_thread_apply_all_options_def_group)
6113 (make_thread_apply_all_options_def_group): Likewise.
6114
6115 2019-06-13 Pedro Alves <palves@redhat.com>
6116
6117 * NEWS (New commands): Mention "maint test-options
6118 require-delimiter", "maint test-options unknown-is-error", "maint
6119 test-options unknown-is-operand" and "maint show
6120 test-options-completion-result".
6121 (New command options, command completion): New section.
6122 (Completion improvements): New section.
6123 Mention that you can abbreviate "unlimited".
6124
6125 2019-06-13 Pedro Alves <palves@redhat.com>
6126
6127 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6128 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6129 * unittests/cli-utils-selftests.c (test_parse_flags)
6130 (test_parse_flags_qcs): Delete.
6131 (test_cli_utils): Don't call deleted functions.
6132
6133 2019-06-13 Pedro Alves <palves@redhat.com>
6134
6135 * thread.c: Include "cli/cli-option.h".
6136 (tp_array_compar_ascending): Global.
6137 (tp_array_compar): Delete function.
6138 (tp_array_compar_ascending, tp_array_compar_descending): New
6139 functions.
6140 (ascending_option_def, qcs_flag_option_def)
6141 (thr_qcs_flags_option_defs)
6142 (make_thread_apply_all_options_def_group)
6143 (make_thread_apply_options_def_group): New.
6144 (thread_apply_all_command): Use gdb::option::process_options.
6145 (thread_apply_command_completer)
6146 (thread_apply_all_command_completer): New.
6147 (thread_apply_command): Use gdb::option::process_options.
6148 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6149 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
6150 to generate help text of "thread apply". Adjust "taas"'s help.
6151 * tid-parse.c (tid_range_parser::in_thread_range): New method.
6152 * tid-parse.h (tid_range_parser::in_thread_range): New method.
6153
6154 2019-06-13 Pedro Alves <palves@redhat.com>
6155
6156 * thread.c (thread_apply_command): Check for invalid TID with
6157 isdigit instead of !isalpha.
6158
6159 2019-06-13 Pedro Alves <palves@redhat.com>
6160
6161 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6162 (validate_flags_qcs): New.
6163 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6164 (validate_flags_qcs): Declare.
6165 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6166 (make_frame_apply_options_def_group): New.
6167 (frame_apply_command_count): Process options with
6168 gdb::option::process_options.
6169 (frame_apply_completer): New.
6170 (frame_apply_level_completer, frame_apply_all_completer)
6171 (frame_apply_completer): New.
6172 (_initialize_stack): Update help of "frame apply", "frame apply
6173 level", "frame apply all" and "faas" to mention supported options
6174 and install command completers.
6175 * stack.h (frame_apply_all_completer): Declare.
6176 * thread.c: Include "stack.h".
6177 (tfaas_command): Add "--".
6178 (_initialize_thread): Update help "tfaas" to mention supported
6179 options and install command completer.
6180
6181 2019-06-13 Pedro Alves <palves@redhat.com>
6182
6183 * completer.c (complete_nested_command_line): New.
6184 (gdb_completion_word_break_characters_throw): Add assertion.
6185 * completer.h (complete_nested_command_line): Declare.
6186
6187 2019-06-13 Pedro Alves <palves@redhat.com>
6188
6189 * stack.c (parse_backtrace_qualifiers): New.
6190 (backtrace_command): Use it.
6191 (backtrace_command_completer): Complete on qualifiers.
6192
6193 2019-06-13 Pedro Alves <palves@redhat.com>
6194
6195 * frame.c: Include "cli/cli-option.h.
6196 (user_set_backtrace_options): New.
6197 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6198 Delete.
6199 (get_prev_frame): Adjust.
6200 (boolean_option_def, uinteger_option_def)
6201 (set_backtrace_option_defs): New.
6202 (_initialize_frame): Adjust and use
6203 gdb::option::add_setshow_cmds_for_options to install "set
6204 backtrace past-main" and "set backtrace past-entry".
6205 * frame.h: Include "cli/cli-option.h".
6206 (struct frame_print_options): Forward declare.
6207 (print_frame_arguments_all, print_frame_arguments_scalars)
6208 (print_frame_arguments_none): Declare.
6209 (print_entry_values): Delete declaration.
6210 (struct frame_print_options, user_frame_print_options): New.
6211 (struct set_backtrace_options): New.
6212 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6213 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6214 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6215 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6216 (list_args_or_locals): Add frame_print_options parameter.
6217 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6218 * python/py-framefilter.c (enumerate_args): Pass down
6219 USER_FRAME_PRINT_OPTIONS.
6220 * stack.c: Include "cli/cli-option.h".
6221 (print_frame_arguments_all, print_frame_arguments_scalars)
6222 (print_frame_arguments_none): Declare.
6223 (print_raw_frame_arguments, print_entry_values): Delete.
6224 (user_frame_print_options): New.
6225 (boolean_option_def, enum_option_def, frame_print_option_defs):
6226 New.
6227 (struct backtrace_cmd_options): New.
6228 (bt_flag_option_def): New.
6229 (backtrace_command_option_defs): New.
6230 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6231 (print_frame_arg, read_frame_arg, print_frame_args)
6232 (print_frame_info, print_frame): Add frame_print_options parameter
6233 and use it.
6234 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6235 (backtrace_command_1): Add frame_print_options and
6236 backtrace_cmd_options parameters and use them.
6237 (make_backtrace_options_def_group): New.
6238 (backtrace_command): Process command options with
6239 gdb::option::process_options.
6240 (backtrace_command_completer): New.
6241 (_initialize_stack): Extend "backtrace"'s help to mention
6242 supported options. Install completer for "backtrace".
6243 Install some settings commands with add_setshow_cmds_for_options.
6244
6245 2019-06-13 Pedro Alves <palves@redhat.com>
6246
6247 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6248 and that "set/show print raw frame-arguments" are now deprecated.
6249
6250 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6251 command.
6252 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6253 * stack.c (_initialize_stack): Install "set/show print
6254 raw-frame-arguments", and deprecate "set/show print raw
6255 frame-arguments".
6256 * valprint.c (_initialize_valprint): Deprecate "set/show print
6257 raw".
6258
6259 2019-06-13 Pedro Alves <palves@redhat.com>
6260
6261 * compile/compile.c (struct compile_options): New.
6262 (compile_flag_option_def, compile_command_option_defs)
6263 (make_compile_options_def_group): New.
6264 (compile_file_command): Handle options with
6265 gdb::option::process_options.
6266 (compile_file_command_completer): New function.
6267 (compile_code_command): Handle options with
6268 gdb::option::process_options.
6269 (compile_code_command_completer): New function.
6270 (_initialize_compiler): Install completers for "compile code" and
6271 "compile file". Mention available options in "compile code" and
6272 "compile code"'s help.
6273 * completer.c (advance_to_completion_word): New, factored out from
6274 ...
6275 (advance_to_expression_complete_word_point): ... this.
6276 (advance_to_filename_complete_word_point): New.
6277 * completer.h (advance_to_filename_complete_word_point): New
6278 declaration.
6279
6280 2019-06-13 Pedro Alves <palves@redhat.com>
6281
6282 * compile/compile.c: Include "cli/cli-option.h".
6283 (compile_print_value): Scope data pointer is now a
6284 value_print_options pointer; adjust.
6285 (compile_print_command): Process options. Scope data pointer is
6286 now a value_print_options pointer; adjust.
6287 (_initialize_compile): Update "compile print"'s help to include
6288 supported options. Install a completer for "compile print".
6289 * cp-valprint.c (show_vtblprint, show_objectprint)
6290 (show_static_field_print): Delete.
6291 (_initialize_cp_valprint): Don't install "set print
6292 static-members", "set print vtbl", "set print object" here.
6293 * printcmd.c: Include "cli/cli-option.h" and
6294 "common/gdb_optional.h".
6295 (print_command_parse_format): Rework to fill in a
6296 value_print_options instead of a format_data.
6297 (print_value): Change parameter type from format_data pointer to
6298 value_print_options reference. Adjust.
6299 (print_command_1): Process options. Adjust to pass down a
6300 value_print_options.
6301 (print_command_completer): New.
6302 (_initialize_printcmd): Install print_command_completer as
6303 handle_brkchars completer for the "print" command. Update
6304 "print"'s help to include supported options.
6305 * valprint.c: Include "cli/cli-option.h".
6306 (show_vtblprint, show_objectprint, show_static_field_print): Moved
6307 here from cp-valprint.c.
6308 (boolean_option_def, uinteger_option_def)
6309 (value_print_option_defs, make_value_print_options_def_group):
6310 New. Use gdb::option::add_setshow_cmds_for_options to install
6311 "set print elements", "set print null-stop", "set print repeats",
6312 "set print pretty", "set print union", "set print array", "set
6313 print address", "set print symbol", "set print array-indexes".
6314 * valprint.h: Include <string> and "cli/cli-option.h".
6315 (make_value_print_options_def_group): Declare.
6316 (print_value): Change parameter type from format_data pointer to
6317 value_print_options reference.
6318 (print_command_completer): Declare.
6319
6320 2019-06-13 Pedro Alves <palves@redhat.com>
6321
6322 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6323 (COMMON_SFILES): Add maint-test-settings.c.
6324 * cli/cli-decode.c (boolean_enums): New global, factored out from
6325 ...
6326 (add_setshow_boolean_cmd): ... here.
6327 * cli/cli-decode.h (boolean_enums): Declare.
6328 * cli/cli-option.c: New file.
6329 * cli/cli-option.h: New file.
6330 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6331 factored out from ...
6332 (parse_cli_boolean_value(const char *)): ... this.
6333 (is_unlimited_literal): Change parameter type to pointer to
6334 pointer. Adjust and advance ARG pointer.
6335 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6336 (parse_cli_var_enum): New, factored out from ...
6337 (do_set_command): ... this. Adjust.
6338 * cli/cli-setshow.h (parse_cli_boolean_value)
6339 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6340 (parse_cli_var_enum): Declare.
6341 * cli/cli-utils.c: Include "cli/cli-option.h".
6342 (get_ulongest): New.
6343 * cli/cli-utils.h (get_ulongest): Declare.
6344 (check_for_argument): New overloads.
6345 * maint-test-options.c: New file.
6346
6347 2019-06-13 Pedro Alves <palves@redhat.com>
6348
6349 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6350 parse a range if "-" is at the end of the string.
6351
6352 2019-06-13 Pedro Alves <palves@redhat.com>
6353
6354 * cli/cli-setshow.c (parse_auto_binary_operation)
6355 (parse_cli_boolean_value): Don't allow "o".
6356
6357 2019-06-13 Pedro Alves <palves@redhat.com>
6358
6359 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6360 * NEWS: Mention maint test-settings KIND.
6361 * maint-test-settings.c: New file.
6362
6363 2019-06-13 Pedro Alves <palves@redhat.com>
6364
6365 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6366 completer.
6367 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6368 "set" completers.
6369
6370 2019-06-13 Pedro Alves <palves@redhat.com>
6371
6372 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6373 after item.
6374
6375 2019-06-13 Pedro Alves <palves@redhat.com>
6376
6377 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6378
6379 2019-06-13 Pedro Alves <palves@redhat.com>
6380
6381 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6382 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6383 call.
6384 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6385 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6386 calls.
6387 (check_for_argument): Skip spaces after argument.
6388
6389 2019-06-13 Pedro Alves <palves@redhat.com>
6390
6391 * thread.c (thread_apply_command): Adjust TID parsing.
6392 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6393 detected before end of string.
6394 (tid_is_in_list): Error out if LIST is invalid.
6395
6396 2019-06-13 Pedro Alves <palves@redhat.com>
6397
6398 * completer.c (complete_line_internal_1): Rewind completion word
6399 point.
6400 (completion_tracker::advance_custom_word_point_by): Change
6401 parameter type to int.
6402 * completer.h (completion_tracker::advance_custom_word_point_by):
6403 Likewise.
6404
6405 2019-06-13 Pedro Alves <palves@redhat.com>
6406
6407 * completer.c (advance_to_completion_word): Handle delimiters.
6408
6409 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
6410
6411 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6412
6413 2019-06-11 Tom Tromey <tom@tromey.com>
6414
6415 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6416 (xmalloc_failed): Move to alloc.c.
6417 * alloc.c: New file.
6418 * Makefile.in (COMMON_SFILES): Add alloc.c.
6419
6420 2019-06-11 Tom Tromey <tom@tromey.com>
6421
6422 * nat/linux-waitpid.c: Don't include server.h.
6423 (linux_debug): Remove.
6424 (my_waitpid): Update.
6425
6426 2019-06-11 Tom Tromey <tromey@adacore.com>
6427
6428 * infcall.c (_initialize_infcall): Remove trailing newline from
6429 help.
6430 * user-regs.c (_initialize_user_regs): Remove trailing newline
6431 from help.
6432 * typeprint.c (_initialize_typeprint): Remove trailing newline
6433 from help.
6434 * reverse.c (_initialize_reverse): Remove trailing newlines from
6435 help.
6436 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6437 from help.
6438 * language.c (add_set_language_command): Remove trailing newline
6439 from help.
6440 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6441 help.
6442 * disasm.c (_initialize_disasm): Remove trailing newline from
6443 help.
6444 * top.c (init_main): Remove trailing newline from help.
6445 * interps.c (_initialize_interpreter): Remove trailing newline
6446 from help.
6447 * btrace.c (_initialize_btrace): Remove trailing newlines from
6448 help.
6449 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6450 from help.
6451 * python/python.c (_initialize_python): Remove trailing newline
6452 from help.
6453 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6454 help.
6455 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6456 from help. Reformat some text.
6457 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6458 from help.
6459 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6460 newline from help.
6461
6462 2019-06-11 Tom Tromey <tromey@adacore.com>
6463
6464 * darwin-nat.c (darwin_decode_exception_message)
6465 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6466
6467 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
6468
6469 * valops.c (value_slice): Check for not allocated or not
6470 associated values.
6471
6472 2019-06-10 Tom de Vries <tdevries@suse.de>
6473
6474 PR gdb/24618
6475 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6476 sure an empty slot (defined by a 32-bit zero pair) is recognized as
6477 invalid.
6478
6479 2019-06-10 Tom de Vries <tdevries@suse.de>
6480
6481 PR gdb/24611
6482 * linespec.c (linespec_lexer_lex_string): Remove incorrect
6483 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
6484
6485 2019-06-10 Tom de Vries <tdevries@suse.de>
6486
6487 PR symtab/24545
6488 * symtab.c (struct demangled_name_entry): Add language field.
6489 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
6490 static minimal symbol". Set and use language field.
6491
6492 2019-06-10 Tom Tromey <tromey@adacore.com>
6493
6494 * ada-lang.c (_initialize_ada_language): Update help text.
6495
6496 2019-06-10 Tom Tromey <tromey@adacore.com>
6497
6498 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6499 with a newline.
6500 * guile/guile.c (handle_boot_error): Don't end warning with a
6501 newline.
6502 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6503 warning with a newline.
6504 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6505 newline.
6506 (s12z_frame_cache): Likewise.
6507 * dwarf-index-cache.c (index_cache::store): Don't end warning with
6508 a newline.
6509 * solib-svr4.c (disable_probes_interface): Don't end warning with
6510 a newline.
6511 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6512 newline.
6513 * python/python.c (do_finish_initialization): Don't end warning
6514 with a newline.
6515
6516 2019-06-10 Tom Tromey <tom@tromey.com>
6517
6518 * python/py-breakpoint.c (gdbpy_breakpoint_created)
6519 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6520 gdbpy_enter.
6521
6522 2019-06-10 Tom Tromey <tromey@adacore.com>
6523
6524 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6525 data.
6526 (elf_new_init): Don't call stabsread_new_init.
6527 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6528 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
6529 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6530
6531 2019-06-10 Tom de Vries <tdevries@suse.de>
6532
6533 PR symtab/16264
6534 PR symtab/24517
6535 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6536
6537 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
6538
6539 * source.c (find_and_open_source): Also rewrite relative file
6540 names.
6541
6542 2019-04-26 Amos Bird <amosbird@gmail.com>
6543
6544 * annotate.c (annotate_thread_exited): Add "thread-exited"
6545 annotation.
6546
6547 2019-06-06 Tom Tromey <tromey@adacore.com>
6548
6549 * maint.h (class scoped_command_stats): Use
6550 DISABLE_COPY_AND_ASSIGN.
6551 <print_time>: New method.
6552 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6553 print_time.
6554 (scoped_command_stats::print_time): New method.
6555
6556 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
6557
6558 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6559 instructions of lengths 6 or 8 bytes.
6560
6561 2019-06-04 Pedro Alves <palves@redhat.com>
6562
6563 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6564
6565 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6566 * breakpoint.c (condition_completer): Likewise.
6567 * cli/cli-dump.c (scan_expression): Likewise.
6568 * common/filestuff.c (mkdir_recursive): Likewise.
6569 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6570 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6571 (gdb_abspath): Likewise.
6572 * compile/compile-cplus-types.c
6573 (compile_cplus_instance::decl_name): Likewise.
6574 * completer.c (complete_explicit_location):
6575 (signal_completer, reg_or_group_completer_1): Likewise.
6576 * cp-support.c (cp_remove_params_if_any): Likewise.
6577 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6578 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6579 * infcmd.c (strip_bg_char): Likewise.
6580 * linespec.c (copy_token_string): Likewise.
6581 * mi/mi-main.c (output_cores): Likewise.
6582 * psymtab.c (psymtab_search_name):
6583 * symfile.c (test_set_ext_lang_command): Likewise.
6584 * target.c (target_fileio_read_stralloc): Likewise.
6585 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6586 * value.c (complete_internalvar): Likewise.
6587
6588 2019-06-04 Christian Biesinger <cbiesinger@google.com>
6589
6590 Add objfile property to gdb.Type.
6591 * NEWS: Mention Python API addition.
6592 * python/py-type.c (typy_get_objfile): New method.
6593
6594 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6595
6596 * NEWS: Mention the new set|show style [title|highlight].
6597 Mention changes to "show style", "help" and "apropos".
6598
6599 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6600
6601 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6602 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
6603 instead of print_help_for_command.
6604 (print_doc_of_command): New function.
6605 (help_list): Add 'apropos -v word' suggestion.
6606 (print_help_for_command): Style the command name using title style.
6607 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6608 (_initialize_cli_cmds): Describe -v in apropos_command help.
6609
6610 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6611
6612 * cli/cli-style.h (cli_style_option): Add name in constructor,
6613 add m_name class member, add constructor with intensity,
6614 add name class function.
6615 (cli_style_option::add_setshow_commands): Remove name argument.
6616 (highlight_style, title_style): New styles.
6617 * cli/cli-style.c (do_show): New function that shows a style
6618 characteristic styling the style name with itself.
6619 (set_style_name): New function.
6620 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6621 Update all callers according to the changes in cli/cli-style.h.
6622 * utils.h (fputs_highlighted): New function.
6623 * utils.c (fputs_highlighted): Likewise.
6624
6625 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6626
6627 * NEWS: Mention new pipe command and new convenience variables.
6628
6629 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6630
6631 * cli/cli-cmds.c (pipe_command): New function.
6632 (_initialize_cli_cmds): Call add_com for pipe_command.
6633 Define | as an alias for pipe.
6634 (exit_status_set_internal_vars): New function.
6635 (shell_escape): Call exit_status_set_internal_vars.
6636 cli/cli-decode.c (find_command_name_length): Recognize | as
6637 a single character command.
6638
6639 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6640
6641 * gdbcmd.h (execute_command_to_ui_file): New declaration.
6642 top.c (execute_command_to_ui_file): New function, mostly a copy
6643 of execute_command_to_string.
6644 (execute_command_to_string): Implement by calling
6645 execute_command_to_ui_file.
6646
6647 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6648
6649 * top.h (saved_command_line): Remove declaration.
6650 * top.c (previous_saved_command_line, previous_repeat_arguments):
6651 New variables.
6652 (saved_command_line): Make static, define together with other
6653 'repeat variables'.
6654 (dont_repeat): Clear repeat_arguments.
6655 (repeat_previous, get_saved_command_line, save_command_line):
6656 New functions.
6657 (gdb_init): Initialize saved_command_line
6658 and previous_saved_command_line.
6659 * main.c (captured_main_1): Remove saved_command_line initialization.
6660 * event-top.c (handle_line_of_input): Update to use
6661 the new 'repeat' related functions instead of direct access to
6662 saved_command_line.
6663 * command.h (repeat_previous, get_saved_command_line,
6664 save_command_line): New declarations.
6665 (dont_repeat): Add comment.
6666
6667 2019-05-30 Tom Tromey <tromey@adacore.com>
6668
6669 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6670 Fix comment.
6671 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6672
6673 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
6674
6675 PR cli/24587
6676 * completer.c (complete): Initialize variable word.
6677
6678 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
6679
6680 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6681 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6682 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6683 'body' is NULL to the outter 'if', protecting the '!is_define'
6684 situation as well.
6685
6686 2019-05-29 Tom Tromey <tromey@adacore.com>
6687
6688 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6689 (dwarf_unknown): New function.
6690 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6691 (dwarf_type_encoding_name): Use dwarf_unknown.
6692
6693 2019-05-29 Tom Tromey <tromey@adacore.com>
6694
6695 PR c++/20020:
6696 * cp-valprint.c (cp_print_value_fields): Call
6697 cp_print_static_field inside "try".
6698
6699 2019-05-29 Tom Tromey <tromey@adacore.com>
6700
6701 * inflow.c (struct terminal_info): Add default operator=.
6702 * configure: Rebuild.
6703 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6704 -Wdeprecated-copy-dtor, -Wredundant-move.
6705
6706 2019-05-29 Tom Tromey <tromey@adacore.com>
6707
6708 * NEWS: Add entry.
6709 * infcmd.c (print_return_value_1): Handle finish_print
6710 option.
6711 (show_print_finish): New function.
6712 (_initialize_infcmd): Add "set/show print finish" commands.
6713 * valprint.c (user_print_options): Initialize new member.
6714 * valprint.h (struct value_print_options) <finish_print>: New
6715 member.
6716
6717 2019-05-28 Tom Tromey <tromey@adacore.com>
6718
6719 * ada-lang.c (ada_remove_Xbn_suffix)
6720 (find_old_style_renaming_symbol)
6721 (parse_old_style_renaming): Remove.
6722 (ada_find_renaming_symbol): Don't call
6723 find_old_style_renaming_symbol.
6724 (ada_is_renaming_symbol): Rename from
6725 ada_find_renaming_symbol. Remove "block" parameter. Return
6726 bool. Now static.
6727 (ada_read_var_value): Update and simplify.
6728 * ada-exp.y (write_var_or_type): Remove old code.
6729
6730 2019-05-28 Alan Hayward <alan.hayward@arm.com>
6731
6732 * event-top.c: Remove include comment.
6733 * inflow.c (class scoped_ignore_sigttou): Move from here...
6734 * inflow.h (class scoped_ignore_sigttou): ...to here.
6735 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6736 * top.c: Remove include comment.
6737
6738 2019-05-27 Tom Tromey <tom@tromey.com>
6739
6740 * NEWS: Fix typo.
6741
6742 2019-05-22 Tom Tromey <tromey@adacore.com>
6743
6744 * target.c (target_follow_exec): Constify parameter.
6745 * target-delegates.c: Rebuild.
6746 * remote.c (remote_target::follow_exec): Constify parameter.
6747 * infrun.c (follow_exec): Constify parameter.
6748 * target.h (struct target_ops) <follow_exec>: Constify parameter.
6749 (target_follow_exec): Likewise.
6750
6751 2019-05-22 Alan Hayward <alan.hayward@arm.com>
6752
6753 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6754 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6755
6756 2019-05-22 Alan Hayward <alan.hayward@arm.com>
6757
6758 * NEWS: Add debugredirect and testsuite sections.
6759
6760 2019-05-22 Simon Cook <simon.cook@embecosm.com>
6761
6762 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6763 target descriptions using exclusively floating point register name
6764 aliases.
6765
6766 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
6767
6768 PR gdb/18644:
6769 * f-lang.c (build_fortran_types): Handle the case where
6770 gdbarch_floatformat_for_type returns a nullptr.
6771
6772 2019-05-21 Tom de Vries <tdevries@suse.de>
6773
6774 PR cli/24587
6775 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6776
6777 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
6778
6779 PR gdb/18644:
6780 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6781 16-byte floats.
6782 * i386-tdep.c (i386_floatformat_for_type): Use
6783 floatformats_ia64_quad for the 16-byte floating point component
6784 within a fortran 32-byte complex number.
6785
6786 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
6787
6788 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6789 delete default constructor.
6790 (find_partial_die): Update to return const struct.
6791 (partial_die_parent_scope): Move variable declaration into scope
6792 of its use and change its type to auto.
6793 (guess_partial_die_structure_name): Likewise.
6794 (partial_die_info::fixup): Likewise.
6795
6796 2019-05-17 Tom Tromey <tromey@adacore.com>
6797
6798 * source.c (find_and_open_source): Remove cast.
6799
6800 2019-05-17 Tom Tromey <tromey@adacore.com>
6801
6802 * annotate.c (annotate_source): Make "filename" const.
6803 * annotate.h (annotate_source): Use const.
6804
6805 2019-05-17 Alan Hayward <alan.hayward@arm.com>
6806
6807 * disasm.c (set_disassembler_options): Send errors to stderr.
6808
6809 2019-05-17 Alan Hayward <alan.hayward@arm.com>
6810
6811 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6812 (cli_interp_base::set_logging): Check debug_redirect.
6813 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6814 * cli/cli-logging.c (debug_redirect): Add static variable.
6815 (pop_output_files): Add default param.
6816 (handle_redirections): Print debug setting.
6817 (show_logging_command): Likewise.
6818 (_initialize_cli_logging): Add debugredirect command.
6819 * interps.c (current_interp_set_logging): Add debug_redirect
6820 parameter.
6821 * interps.h (set_logging): Add debug_redirect parameter.
6822 (current_interp_set_logging): Likewise.
6823 * mi/mi-common.h: Likewise.
6824 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6825
6826 2019-05-17 Alan Hayward <alan.hayward@arm.com>
6827 Tom Tromey <tromey@adacore.com>
6828
6829 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6830 directly.
6831 * cli/cli-interp.h (make_logging_output): Remove declaration.
6832 * cli/cli-logging.c (make_logging_output): Remove function.
6833 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6834 directly.
6835 * ui-file.c (tee_file::tee_file): Remove bools.
6836 (tee_file::~tee_file): Remove deletes.
6837 * ui-file.h (tee_file): Remove bools.
6838
6839 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
6840
6841 * mi/mi-cmds.h (mi_cmd_complete): New function.
6842 * mi/mi-main.c (mi_cmd_complete): Likewise.
6843 * mi/mi-cmds.c: Define new MI command -complete.
6844 * NEWS: Mention new -complete command.
6845
6846 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
6847
6848 * completer.h (complete): New function.
6849 * completer.c (complete): Likewise.
6850 * cli/cli-cmds.c: (complete_command): Update to use new complete()
6851 function defined in completer.h.
6852
6853 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
6854
6855 * MAINTAINERS (Write After Approval): Add myself.
6856
6857 2019-05-17 Tom de Vries <tdevries@suse.de>
6858
6859 PR gdb/24094
6860 * dwarf2read.c (struct cu_partial_die_info): New struct.
6861 (find_partial_die): Return cu_partial_die_info.
6862 (partial_die_parent_scope, guess_partial_die_structure_name)
6863 (partial_die_info::fixup): Handle new return type of find_partial_die.
6864
6865 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6866
6867 PR breakpoints/24541
6868 * stap-probe.c (stap_parse_register_operand): Make "regname" an
6869 "std::string", simplifying the algorithm.
6870
6871 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6872
6873 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6874 (stap_static_probe_ops::get_probes): Likewise.
6875
6876 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6877
6878 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6879 '-')" and "else if".
6880 (stap_parse_single_operand): Join checks for
6881 "gdbarch_stap_parse_special_token_p" and
6882 "gdbarch_stap_parse_special_token" in the same "if" statement.
6883 Invert check when verifying for operation on register
6884 displacement.
6885
6886 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6887
6888 * stap-probe.c (stap_get_opcode): Update comment.
6889 (stap_get_expected_argument_type): Likewise.
6890 (handle_stap_probe): Likewise.
6891
6892 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6893
6894 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6895 return type to 'bool'. Adjust comment. Use 'bool' when
6896 appropriate.
6897 (i386_stap_parse_special_token_three_arg_disp): Likewise.
6898 * stap-probe.c (stap_parse_argument_1): Likewise.
6899 (stap_is_operator): Likewise.
6900 (stap_is_generic_prefix): Likewise.
6901 (stap_is_register_prefix): Likewise.
6902 (stap_is_register_indirection_prefix): Likewise.
6903 (stap_is_integer_prefix): Likewise.
6904 (stap_generic_check_suffix): Likewise.
6905 (stap_check_integer_suffix): Likewise.
6906 (stap_check_register_suffix): Likewise.
6907 (stap_check_register_indirection_suffix): Likewise.
6908 (stap_parse_register_operand): Likewise.
6909 (stap_parse_single_operand): Likewise.
6910 (stap_parse_argument_1): Likewise.
6911 (stap_probe::get_argument_count): Likewise.
6912 (stap_is_operator): Likewise.
6913
6914 2019-05-16 Tom Tromey <tromey@adacore.com>
6915
6916 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6917 keyword to foreach.
6918
6919 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
6920
6921 * linux-thread-db.c (try_thread_db_load_1): Change return type
6922 to bool.
6923 (try_thread_db_load): Likewise.
6924 (try_thread_db_load_from_pdir_1): Likewise.
6925 (try_thread_db_load_from_pdir): Likewise.
6926 (try_thread_db_load_from_sdir): Likewise.
6927 (try_thread_db_load_from_dir): Likewise.
6928 (thread_db_load_search): Likewise.
6929 (has_libpthread): Likewise.
6930 (thread_db_load): Likewise.
6931
6932 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
6933
6934 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6935 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6936 NULL, and complain/return if that's the case.
6937
6938 2019-05-15 John Darrington <john@darrington.wattle.id.au>
6939
6940 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6941 (advance, posn, abstract_read_memory): New functions.
6942 [struct mem_read_abstraction]: New struct.
6943 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6944
6945 2019-05-14 Tom Tromey <tromey@adacore.com>
6946
6947 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6948 value is not lval_memory.
6949
6950 2019-05-14 Tom Tromey <tromey@adacore.com>
6951
6952 * solib.c (info_sharedlibrary_command): Style the file name.
6953
6954 2019-05-14 Alan Hayward <alan.hayward@arm.com>
6955
6956 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6957 (aarch64_vnv_type): Likewise.
6958 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6959 * common/tdesc.c: Likewise.
6960 * common/tdesc.h (enum tdesc_type_kind): Likewise.
6961 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6962 * features/aarch64-fpu.xml: Add ieee half view.
6963 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6964 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6965 * gdbtypes.h (struct builtin_type): Likewise.
6966 (struct objfile_type): Likewise.
6967
6968 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
6969
6970 * language.c (language_sniff_from_mangled_name): Fix "langauge"
6971 typo.
6972 * location.h (string_to_event_location): Likewise.
6973
6974 2019-05-11 Joel Brobecker <brobecker@adacore.com>
6975
6976 GDB 8.3 released.
6977
6978 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
6979
6980 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6981 New variable declaration.
6982 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6983 New variable.
6984 (print_one_breakpoint): Use ui_out::test_flags and new global
6985 variable to compute use_fixed_output.
6986 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6987 Remove.
6988 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6989 (mi_multi_location_breakpoint_output_fixed): Remove.
6990 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6991 new variable.
6992 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6993 fix_multi_location_breakpoint_output flag if version >= 3.
6994 * ui-out.h (enum ui_out_flag)
6995 <fix_multi_location_breakpoint_output>: New enumerator.
6996
6997 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
6998
6999 * contrib/cc-with-tweaks.sh: Validate dwz's work.
7000
7001 2019-05-10 Tom Tromey <tromey@adacore.com>
7002
7003 * ada-lang.c (catch_ada_completer): New function.
7004 (_initialize_ada_language): Use it.
7005
7006 2019-05-10 Tom Tromey <tromey@adacore.com>
7007
7008 * thread.c (print_thread_info): Make "requested_threads" const.
7009 * gdbthread.h (print_thread_info): Make "requested_threads"
7010 const.
7011 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7012 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7013
7014 2019-05-08 Tom Tromey <tom@tromey.com>
7015
7016 * gdbtypes.c (objfile_type_data): Change type.
7017 (objfile_type, _initialize_gdbtypes): Update.
7018
7019 2019-05-08 Tom Tromey <tom@tromey.com>
7020
7021 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7022 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7023 (_initialize_dwarf2_frame): Update.
7024
7025 2019-05-08 Tom Tromey <tom@tromey.com>
7026
7027 * objc-lang.c (objc_objfile_data): Change type.
7028 (find_methods): Update.
7029 (_initialize_objc_lang): Remove.
7030
7031 2019-05-08 Tom Tromey <tom@tromey.com>
7032
7033 * stabsread.c (rs6000_builtin_type_data): Change type.
7034 (rs6000_builtin_type, _initialize_stabsread): Update.
7035
7036 2019-05-08 Tom Tromey <tom@tromey.com>
7037
7038 * mips-tdep.c (mips_pdr_data): Remove.
7039 (_initialize_mips_tdep): Update.
7040
7041 2019-05-08 Tom Tromey <tom@tromey.com>
7042
7043 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7044 (hppa_init_objfile_priv_data, read_unwind_info)
7045 (find_unwind_entry, _initialize_hppa_tdep): Update.
7046
7047 2019-05-08 Tom Tromey <tom@tromey.com>
7048
7049 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7050 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
7051 on obstack.
7052 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7053
7054 2019-05-08 Tom Tromey <tom@tromey.com>
7055
7056 * mdebugread.c (basic_type_data): Change type.
7057 (basic_type, _initialize_mdebugread): Update.
7058
7059 2019-05-08 Tom Tromey <tom@tromey.com>
7060
7061 * common/gdb_unique_ptr.h (struct noop_deleter): New.
7062
7063 2019-05-08 Tom Tromey <tom@tromey.com>
7064
7065 * nto-tdep.c (nto_inferior_data_reg): Change type.
7066 (nto_inferior_data): Update.
7067 (nto_inferior_data_cleanup, nto_new_inferior_data)
7068 (_initialize_nto_tdep): Remove.
7069 * nto-tdep.h (struct nto_inferior_data): Add initializers.
7070
7071 2019-05-08 Tom Tromey <tom@tromey.com>
7072
7073 * ada-lang.c (struct ada_inferior_data): Add initializers.
7074 (ada_inferior_data): Change type.
7075 (ada_inferior_data_cleanup): Remove.
7076 (get_ada_inferior_data, ada_inferior_exit)
7077 (struct ada_pspace_data): Add initializers, destructor.
7078 (ada_pspace_data_handle): Change type.
7079 (get_ada_pspace_data): Update.
7080 (ada_pspace_data_cleanup): Remove.
7081
7082 2019-05-08 Tom Tromey <tom@tromey.com>
7083
7084 * coffread.c (struct coff_symfile_info): Add initializers.
7085 (coff_objfile_data_key): Move lower. Change type.
7086 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7087 Update.
7088 (coff_free_info): Remove.
7089
7090 2019-05-08 Tom Tromey <tom@tromey.com>
7091
7092 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7093 (fbsd_pspace_data_handle): Move lower. Change type.
7094 (get_fbsd_pspace_data): Update.
7095 (fbsd_pspace_data_cleanup): Remove.
7096 (_initialize_fbsd_tdep): Update.
7097
7098 2019-05-08 Tom Tromey <tom@tromey.com>
7099
7100 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7101 (get_ada_tasks_pspace_data): Update.
7102 (ada_tasks_pspace_data_cleanup): Remove.
7103 (_initialize_tasks): Update.
7104 (ada_tasks_inferior_data_handle): Change type.
7105 (get_ada_tasks_inferior_data): Update.
7106 (ada_tasks_inferior_data_cleanup): Remove.
7107 (struct ada_tasks_pspace_data): Add initializers.
7108
7109 2019-05-08 Tom Tromey <tom@tromey.com>
7110
7111 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7112 * symfile-debug.c (debug_sym_get_probes): Change type.
7113 * stap-probe.c (handle_stap_probe):
7114 (stap_static_probe_ops::get_probes): Change type.
7115 * probe.h (class static_probe_ops) <get_probes>: Change type.
7116 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7117 (parse_probes_in_pspace): Update.
7118 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7119 Update.
7120 (any_static_probe_ops::get_probes): Change type.
7121 * elfread.c (elfread_data): New typedef.
7122 (probe_key): Change type.
7123 (elf_get_probes): Likewise. Update.
7124 (probe_key_free): Remove.
7125 (_initialize_elfread): Update.
7126 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7127 Change type.
7128 (dtrace_process_dof_probe, dtrace_process_dof)
7129 (dtrace_static_probe_ops::get_probe): Change type.
7130
7131 2019-05-08 Tom Tromey <tom@tromey.com>
7132
7133 * xcoffread.c (struct xcoff_symfile_info): Rename from
7134 coff_symfile_info. Add initializers.
7135 (xcoff_objfile_data_key): Move lower. Change type.
7136 (XCOFF_DATA): Rewrite.
7137 (xcoff_free_info): Remove.
7138 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7139 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7140 (xcoff_initial_scan): Update.
7141
7142 2019-05-08 Tom Tromey <tom@tromey.com>
7143
7144 * solib-svr4.c (struct svr4_info): Add initializers and
7145 destructor.
7146 <probes_table>: Now an htab_up.
7147 (solib_svr4_pspace_data): Change type.
7148 (free_probes_table): Simplify.
7149 (~svr4_info): Rename from svr4_pspace_data_cleanup.
7150 (get_svr4_info, probes_table_htab_remove_objfile_probes)
7151 (probes_table_remove_objfile_probes, register_solib_event_probe)
7152 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7153 (_initialize_svr4_solib): Update.
7154
7155 2019-05-08 Tom Tromey <tom@tromey.com>
7156
7157 * remote.c (remote_pspace_data): Change type.
7158 (remote_pspace_data_cleanup): Remove.
7159 (get_remote_exec_file, set_pspace_remote_exec_file)
7160 (_initialize_remote): Update.
7161
7162 2019-05-08 Tom Tromey <tom@tromey.com>
7163
7164 * breakpoint.c (breakpoint_objfile_key): Change type.
7165 (get_breakpoint_objfile_data): Update.
7166 (free_breakpoint_objfile_data): Remove.
7167 (_initialize_breakpoint): Update.
7168
7169 2019-05-08 Tom Tromey <tom@tromey.com>
7170
7171 * linux-tdep.c (struct linux_info): Add initializers.
7172 (linux_inferior_data): Move. Change type.
7173 (invalidate_linux_cache_inf): Update.
7174 (linux_inferior_data_cleanup): Remove.
7175 (get_linux_inferior_data, _initialize_linux_tdep): Update.
7176
7177 2019-05-08 Tom Tromey <tom@tromey.com>
7178
7179 * auxv.c (auxv_inferior_data): Move. Change type.
7180 (auxv_inferior_data_cleanup): Remove.
7181 (invalidate_auxv_cache_inf): Rewrite.
7182 (get_auxv_inferior_data, _initialize_auxv): Update.
7183
7184 2019-05-08 Tom Tromey <tom@tromey.com>
7185
7186 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7187 (symfile_debug_objfile_data_key): Change type.
7188 (symfile_debug_installed, debug_qf_has_symbols)
7189 (debug_qf_find_last_source_symtab)
7190 (debug_qf_forget_cached_source_info)
7191 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7192 (debug_qf_print_stats, debug_qf_dump)
7193 (debug_qf_expand_symtabs_for_function)
7194 (debug_qf_expand_all_symtabs)
7195 (debug_qf_expand_symtabs_with_fullname)
7196 (debug_qf_map_matching_symbols)
7197 (debug_qf_expand_symtabs_matching)
7198 (debug_qf_find_pc_sect_compunit_symtab)
7199 (debug_qf_map_symbol_filenames)
7200 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7201 (debug_sym_new_init, debug_sym_init, debug_sym_read)
7202 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7203 (debug_sym_read_linetable, debug_sym_relocate): Update.
7204 (symfile_debug_free_objfile): Remove.
7205 (install_symfile_debug_logging, _initialize_symfile_debug):
7206 Update.
7207
7208 2019-05-08 Tom Tromey <tom@tromey.com>
7209
7210 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7211 allocate_on_obstack.
7212 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7213 (get_dwarf2_per_objfile): Update.
7214 (set_dwarf2_per_objfile): Remove.
7215 (dwarf2_has_info, dwarf2_get_section_info): Update.
7216 (dwarf2_free_objfile): Remove.
7217 (_initialize_dwarf2_read): Update.
7218
7219 2019-05-08 Tom Tromey <tom@tromey.com>
7220
7221 * auto-load.c (struct auto_load_pspace_info): Add destructor and
7222 initializers.
7223 <unsupported_script_warning_printed,
7224 script_not_found_warning_printed>: Now bool.
7225 (auto_load_pspace_data): Change type.
7226 (~auto_load_pspace_info): Rename from
7227 auto_load_pspace_data_cleanup.
7228 (get_auto_load_pspace_data, init_loaded_scripts_info)
7229 (clear_section_scripts, maybe_print_unsupported_script_warning)
7230 (maybe_print_script_not_found_warning, _initialize_auto_load):
7231 Update.
7232
7233 2019-05-08 Tom Tromey <tom@tromey.com>
7234
7235 * objfiles.c (objfile_pspace_info): Add destructor and
7236 initializers.
7237 (objfiles_pspace_data): Change type.
7238 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7239 (get_objfile_pspace_data): Update.
7240 (objfiles_bfd_data): Change type.
7241 (get_objfile_bfd_data): Update.
7242 (objfile_bfd_data_free, _initialize_objfiles): Remove.
7243
7244 2019-05-08 Tom Tromey <tom@tromey.com>
7245
7246 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7247 Change type.
7248 (get_catch_syscall_inferior_data): Update.
7249 (catch_syscall_inferior_data_cleanup): Remove.
7250 (_initialize_break_catch_syscall): Update.
7251
7252 2019-05-08 Tom Tromey <tom@tromey.com>
7253
7254 * inflow.c (struct terminal_info): Add destructor and
7255 initializers.
7256 (inflow_inferior_data): Change type.
7257 (~terminal_info): Rename from inflow_inferior_data_cleanup.
7258 (get_inflow_inferior_data, inflow_inferior_exit)
7259 (swap_terminal_info, _initialize_inflow): Update.
7260
7261 2019-05-08 Tom Tromey <tom@tromey.com>
7262
7263 * target-dcache.c (target_dcache_cleanup): Remove.
7264 (target_dcache_aspace_key): Change type.
7265 (target_dcache_init_p, target_dcache_invalidate)
7266 (target_dcache_get, target_dcache_get_or_init)
7267 (_initialize_target_dcache): Update.
7268 * dcache.h (struct dcache_deleter): New.
7269
7270 2019-05-08 Tom Tromey <tom@tromey.com>
7271
7272 * symtab.c (struct symbol_cache): Add destructor and
7273 initializers.
7274 (symbol_cache_key): Move. Change type.
7275 (make_symbol_cache, free_symbol_cache): Remove.
7276 (get_symbol_cache): Update.
7277 (symbol_cache_cleanup): Remove.
7278 (ALL_PSPACES, symbol_cache_flush)
7279 (maintenance_print_symbol_cache)
7280 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7281 Update.
7282
7283 2019-05-08 Tom Tromey <tom@tromey.com>
7284
7285 * symtab.c (struct main_info): Add destructor and initializers.
7286 (main_progspace_key): Move. Change type.
7287 (get_main_info): Update.
7288 (main_info_cleanup): Remove.
7289 (_initialize_symtab): Update.
7290
7291 2019-05-08 Tom Tromey <tom@tromey.com>
7292
7293 * registry.h (DECLARE_REGISTRY): Define the _key class.
7294
7295 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
7296
7297 * NEWS: Merge two 'New commands' sections.
7298
7299 2019-05-08 Joel Brobecker <brobecker@adacore.com>
7300
7301 * ada-valprint.c (ada_val_print_gnat_array): Remove language
7302 parameter and use Ada language definition instead.
7303 (ada_val_print_ptr): Remove unused language parameter.
7304 (ada_val_print_num): Remove language parameter and use Ada language
7305 definition instead.
7306 (ada_val_print_enum, ada_val_print_flt): Remove unused language
7307 parameter.
7308 (ada_val_print_struct_union, ada_val_print_ref): Remove language
7309 parameter and use Ada language definition instead.
7310 (ada_val_print_1): Update all ada_val_print_xxx calls.
7311 Remove language parameter.
7312 (ada_val_print): Update ada_val_print_1 call.
7313
7314 2019-05-08 Tom Tromey <tromey@adacore.com>
7315
7316 * remote.c (remote_hw_watchpoint_limit)
7317 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7318 Now static.
7319
7320 2019-05-08 Tom Tromey <tromey@adacore.com>
7321
7322 * maint.c (_initialize_maint_cmds): Move initialization code to
7323 remote.c.
7324 (watchdog, show_watchdog): Move to remote.c.
7325 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
7326 "watchdog" static.
7327 (_initialize_remote): Move initialization code from maint.c.
7328 * defs.h (watchdog): Don't declare.
7329
7330 2019-05-08 Tom Tromey <tromey@adacore.com>
7331
7332 * tui/tui-interp.c: Include main.h.
7333 * interps.c: Include main.h.
7334 * main.h (interpreter_p): Declare.
7335 * defs.h (interpreter_p): Don't declare.
7336
7337 2019-05-08 Tom Tromey <tromey@adacore.com>
7338
7339 * dwarf2loc.c: Include dwarf2read.h.
7340 * defs.h (read_unsigned_leb128): Don't declare.
7341 * dwarf2read.h (read_unsigned_leb128): Declare.
7342
7343 2019-05-08 Tom Tromey <tromey@adacore.com>
7344
7345 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7346 method.
7347
7348 2019-05-08 Tom Tromey <tromey@adacore.com>
7349
7350 * utils.c (fputs_maybe_filtered): Reset style after paging, even
7351 when no wrap column is set.
7352
7353 2019-05-08 Tom Tromey <tromey@adacore.com>
7354
7355 * c-lang.c (c_get_string): Handle non-C-style arrays.
7356
7357 2019-05-08 Tom Tromey <tromey@adacore.com>
7358
7359 * typeprint.c (print_offset_data::update): Print the bit offset,
7360 not the number of bits remaining.
7361
7362 2019-05-08 Tom Tromey <tromey@adacore.com>
7363
7364 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7365 padding at end of comment.
7366
7367 2019-05-08 Tom Tromey <tromey@adacore.com>
7368
7369 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7370 Compare main types.
7371
7372 2019-05-06 Tom Tromey <tom@tromey.com>
7373
7374 * common/scoped_mmap.c: Include common-defs.h.
7375 * common/scoped_mmap.h: Don't include config.h.
7376
7377 2019-05-04 Tom Tromey <tom@tromey.com>
7378
7379 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7380 (struct aarch64_call_info): Add initializers.
7381 <si>: Now a std::vector.
7382 (pass_on_stack, aarch64_push_dummy_call): Update.
7383
7384 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
7385 Tom Tromey <tom@tromey.com>
7386
7387 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7388 (ppc_threads): Now a std::vector. Now static.
7389 (hwdebug_find_thread_points_by_tid)
7390 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7391 Update.
7392
7393 2019-05-04 Tom Tromey <tom@tromey.com>
7394
7395 * arc-tdep.c (arc_tdesc_init): Return bool.
7396
7397 2019-05-04 Tom Tromey <tom@tromey.com>
7398
7399 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7400 Use gdb_assert_not_reached.
7401
7402 2019-05-04 Tom Tromey <tom@tromey.com>
7403
7404 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7405 "false".
7406
7407 2019-05-04 Tom Tromey <tom@tromey.com>
7408
7409 * arc-tdep.c (arc_tdesc_init): Use bool.
7410
7411 2019-05-04 Tom Tromey <tom@tromey.com>
7412
7413 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7414
7415 2019-05-04 Tom Tromey <tom@tromey.com>
7416
7417 * cli/cli-cmds.c (valid_command_p): Return bool.
7418
7419 2019-05-04 Tom Tromey <tom@tromey.com>
7420
7421 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7422 * command.h (valid_user_defined_cmd_name_p): Channge return type.
7423
7424 2019-05-04 Raul Tambre <raul@tambre.ee>
7425
7426 * python/lib/gdb/prompt.py (_ExtendedPrompt)
7427 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7428 operator for comparison.
7429
7430 2019-05-04 Tom Tromey <tom@tromey.com>
7431
7432 * psymtab.c (psymbol_name_matches, match_partial_symbol)
7433 (lookup_partial_symbol, print_partial_symbols)
7434 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7435 (psymbol_compare): Update.
7436 (add_psymbol_to_bcache): Clear the entire psymbol.
7437 (maintenance_check_psymtabs): Update.
7438 * psympriv.h (struct partial_symbol): Don't derive from
7439 general_symbol_info.
7440 <obj_section, unrelocated_address, address,
7441 set_unrelocated_address>: Update.
7442 <ginfo>: New member.
7443 * dwarf-index-write.c (write_psymbols, debug_names::insert)
7444 (debug_names::write_psymbols): Update.
7445
7446 2019-05-04 Tom de Vries <tdevries@suse.de>
7447
7448 * contrib/cc-with-tweaks.sh: Support -n arg.
7449
7450 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7451
7452 * corelow.c (core_target::detach): Ensure frame cache and
7453 register caches are cleared.
7454 inferior.c (exit_inferior_1): Likewise.
7455
7456 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
7457 Tom Tromey <tom@tromey.com>
7458
7459 * dictionary.c (collate_pending_symbols_by_language): Remove
7460 "struct" from foreach.
7461 * symtab.c (lookup_global_symbol_from_objfile)
7462 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7463 foreach.
7464 * ser-tcp.c (net_open): Remove "struct" from foreach.
7465 * objfiles.c (objfile_relocate, objfile_rebase)
7466 (objfile_has_symbols): Remove "struct" from foreach.
7467 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7468 from foreach.
7469 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7470 foreach.
7471 * darwin-nat.c (thread_info_from_private_thread_info): Remove
7472 "struct" from foreach.
7473 * ada-lang.c (create_excep_cond_exprs)
7474 (ada_exception_catchpoint_cond_string): Remove "struct" from
7475 foreach.
7476
7477 2019-05-03 Tom Tromey <tromey@adacore.com>
7478
7479 * ada-exp.y (convert_char_literal): Check suffix of each
7480 enumerator.
7481
7482 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
7483
7484 PR ada/21406:
7485 * ada-exp.y (yywrap): Don't define.
7486 * ada-lex.l (%option): Add noyywrap
7487 (yywrap): Remove.
7488
7489 2019-05-03 Eli Zaretskii <eliz@gnu.org>
7490
7491 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7492 _WIN32_WINNT to the XP level, unless already defined to a higher
7493 level.
7494
7495 * unittests/parse-connection-spec-selftests.c:
7496 * ser-tcp.c:
7497 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
7498 override.
7499
7500 * symfile.c (find_separate_debug_file): Remove colon from the
7501 drive spec of DOS/Windows file names of the target, so that the
7502 file name produced from DEBUGDIR and the target's directory will
7503 be valid on DOS/Windows systems.
7504
7505 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
7506
7507 * rust-lang.c (val_print_struct): Handle printing structures
7508 containing strings.
7509
7510 2019-05-02 Tom Tromey <tromey@adacore.com>
7511
7512 * valarith.c (_initialize_valarith): Remove.
7513
7514 2019-05-01 Tom Tromey <tromey@adacore.com>
7515
7516 * ada-lang.c (ada_value_primitive_field): Treat more fields as
7517 bitfields.
7518
7519 2019-05-01 Tom Tromey <tromey@adacore.com>
7520
7521 * ada-lang.c (ada_value_assign): Correctly compute starting offset
7522 for big-endian copies.
7523
7524 2019-04-30 Ali Tamur <tamur@google.com>
7525 * gdb/dwarf2read.c (read_3_bytes): New declaration.
7526 (read_attribute_value): Added DW_FORM_strx1-4 cases.
7527 (read_3_bytes): New function.
7528
7529 2019-04-30 Joel Brobecker <brobecker@adacore.com>
7530
7531 * windows-nat.c (main_thread_id): Delete.
7532 (handle_output_debug_string): Replace main_thread_id by
7533 current_event.dwThreadId.
7534 (fake_create_process): Likewise.
7535 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7536 Do not set main_thread_id.
7537 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7538 current_event.dwThreadId.
7539 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7540
7541 2019-04-30 Joel Brobecker <brobecker@adacore.com>
7542
7543 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7544 Use current_event.dwThreadId instead of main_thread_id.
7545
7546 2019-04-30 Tom Tromey <tromey@adacore.com>
7547
7548 * ada-lang.c (ada_lookup_simple_minsyms): New function.
7549 (create_excep_cond_exprs): Iterate over program spaces.
7550 (ada_exception_catchpoint_cond_string): Examine all minimal
7551 symbols for exception types.
7552
7553 2019-04-30 Tom Tromey <tromey@adacore.com>
7554
7555 PR c++/24470:
7556 * dwarf2read.c (process_structure_scope): Handle case where type
7557 has template parameters but no symbol was created.
7558
7559 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7560 Chris January <chris.january@arm.com>
7561
7562 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7563 qualifier.
7564 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7565
7566 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7567
7568 * f-typeprint.c (f_print_type): Update rules for printing
7569 whitespace.
7570 (f_type_print_varspec_suffix): Likewise.
7571
7572 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7573 Chris January <chris.january@arm.com>
7574
7575 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7576 function arguments.
7577
7578 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7579
7580 * f-lang.c (build_fortran_types): Change name of void type to
7581 lower case.
7582 * f-typeprint.c (f_type_print_base): Print the name of the void
7583 type, rather than a fixed string.
7584 * f-valprint.c (f_decorations): Use lower case void string.
7585
7586 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7587 Chris January <chris.january@arm.com>
7588
7589 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7590 types for Fortran.
7591
7592 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7593 Chris January <chris.january@arm.com>
7594 David Lecomber <david.lecomber@arm.com>
7595
7596 * f-exp.y (BINOP_INTRINSIC): New token.
7597 (exp): New parser rule handling BINOP_INTRINSIC.
7598 (f77_keywords): Add new builtin procedures.
7599 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7600 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7601 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7602 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7603 (print_unop_subexp_f): New function.
7604 (print_binop_subexp_f): New function.
7605 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7606 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7607 (dump_subexp_body_f): Likewise.
7608 (operator_check_f): Likewise.
7609 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7610 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7611
7612 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7613
7614 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7615 UNOP_KIND.
7616 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7617 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7618 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7619 (operator_length_f): New fuction.
7620 (print_subexp_f): New function.
7621 (op_name_f): New function.
7622 (dump_subexp_body_f): New function.
7623 (operator_check_f): New function.
7624 (exp_descriptor_f): Replace standard expression handling functions
7625 with new functions.
7626 * gdb/fortran-operator.def: New file.
7627 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7628 * gdb/std-operator.def: Remove UNOP_KIND.
7629
7630 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7631
7632 * std-operator.def: Remove unbalanced, stray double quote
7633 character.
7634
7635 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7636 Chris January <chris.january@arm.com>
7637 Daniel Everett <daniel.everett@arm.com>
7638 Nick Forrington <nick.forrington@arm.com>
7639 Richard Bunt <richard.bunt@arm.com>
7640
7641 * cp-valprint.c (cp_print_value_fields): Allow an additional level
7642 of depth when printing anonymous structs or unions.
7643 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7644 Don't print either the top-level value, or the children if the
7645 max-depth is exceeded.
7646 (ppscm_print_children): When printing the key of a map, allow one
7647 extra level of depth.
7648 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7649 print either the top-level value, or the children if the max-depth
7650 is exceeded.
7651 (print_children): When printing the key of a map, allow one extra
7652 level of depth.
7653 * python/py-value.c (valpy_format_string): Add max_depth keyword.
7654 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7655 (user_print_options): Initialise max_depth field.
7656 (val_print_scalar_or_string_type_p): New function.
7657 (val_print): Check to see if the max depth has been reached.
7658 (val_print_check_max_depth): Define new function.
7659 (show_print_max_depth): New function.
7660 (_initialize_valprint): Add 'print max-depth' option.
7661 * valprint.h (struct value_print_options) <max_depth>: New field.
7662 (val_print_check_max_depth): Declare new function.
7663 * NEWS: Document new feature.
7664
7665 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7666
7667 * ada-lang.c (ada_language_defn): Initialise new field.
7668 * c-lang.c (c_is_string_type_p): New function.
7669 (c_language_defn): Initialise new field.
7670 (cplus_language_defn): Initialise new field.
7671 (asm_language_defn): Initialise new field.
7672 (minimal_language_defn): Initialise new field.
7673 * c-lang.h (c_is_string_type_p): Declare new function.
7674 * d-lang.c (d_language_defn): Initialise new field.
7675 * f-lang.c (f_is_string_type_p): New function.
7676 (f_language_defn): Initialise new field.
7677 * go-lang.c (go_is_string_type_p): New function.
7678 (go_language_defn): Initialise new field.
7679 * language.c (default_is_string_type_p): New function.
7680 (unknown_language_defn): Initialise new field.
7681 (auto_language_defn): Initialise new field.
7682 * language.h (struct language_defn) <la_is_string_type_p>: New
7683 member variable.
7684 (default_is_string_type_p): Declare new function.
7685 * m2-lang.c (m2_language_defn): Initialise new field.
7686 * objc-lang.c (objc_language_defn): Initialise new field.
7687 * opencl-lang.c (opencl_language_defn): Initialise new field.
7688 * p-lang.c (pascal_is_string_type_p): New function.
7689 (pascal_language_defn): Initialise new field.
7690 * rust-lang.c (rust_is_string_type_p): New function.
7691 (rust_language_defn): Initialise new field.
7692
7693 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7694
7695 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7696 New field.
7697 * ada-lang.c (ada_language_defn): Initialise new field.
7698 * c-lang.c (c_language_defn): Likewise.
7699 (cplus_language_defn): Likewise.
7700 (asm_language_defn): Likewise.
7701 (minimal_language_defn): Likewise.
7702 * d-lang.c (d_language_defn): Likewise.
7703 * f-lang.c (f_language_defn): Likewise.
7704 * go-lang.c (go_language_defn): Likewise.
7705 * language.c (unknown_language_defn): Likewise.
7706 (auto_language_defn): Likewise.
7707 * m2-lang.c (m2_language_defn): Likewise.
7708 * objc-lang.c (objc_language_defn): Likewise.
7709 * opencl-lang.c (opencl_language_defn): Likewise.
7710 * p-lang.c (pascal_language_defn): Likewise.
7711 * rust-lang.c (rust_language_defn): Likewise.
7712
7713 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7714
7715 * ada-lang.c (ada_is_character_type): Change return type to bool.
7716 (ada_is_string_type): Likewise.
7717 * ada-lang.h (ada_is_character_type): Update declaration
7718 (ada_is_string_type): Likewise.
7719
7720 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7721
7722 Support style in 'frame|thread apply'
7723
7724 * gdbcmd.h (execute_command_to_string): New term_out parameter.
7725 * record.c (record_start, record_stop): Update callers of
7726 execute_command_to_string with false.
7727 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7728 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7729 methods.
7730 (class string_file): New constructor with term_out parameter.
7731 Override methods term_out and can_emit_style_escape. New member
7732 term_out.
7733 (class stdio_file): Override can_emit_style_escape.
7734 (class tee_file): Override term_out and can_emit_style_escape.
7735 * utils.h (can_emit_style_escape): Remove.
7736 * utils.c (can_emit_style_escape): Likewise.
7737 Update all callers of can_emit_style_escape (SOMESTREAM) to
7738 SOMESTREAM->can_emit_style_escape.
7739 * source-cache.c (source_cache::get_source_lines): Likewise.
7740 * stack.c (frame_apply_command_count): Call execute_command_to_string
7741 passing the term_out characteristic of the current gdb_stdout.
7742 * thread.c (thr_try_catch_cmd): Likewise.
7743 * top.c (execute_command_to_string): pass term_out parameter
7744 to construct the string_file for the command output.
7745 * ui-file.c (term_cli_styling): New function (most code moved
7746 from utils.c can_emit_style_escape).
7747 (string_file::string_file, string_file::can_emit_style_escape,
7748 stdio_file::can_emit_style_escape, tee_file::term_out,
7749 tee_file::can_emit_style_escape): New functions.
7750
7751 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7752
7753 * NEWS: Mention the new set|show may-call-functions.
7754 * infcall.c (may_call_functions_p): New variable.
7755 (show_may_call_functions_p): New function.
7756 (call_function_by_hand_dummy): Throws an error if not
7757 may-call-functions.
7758 (_initialize_infcall): Call add_setshow_boolean_cmd for
7759 may-call-functions.
7760
7761 2019-04-25 Keith Seitz <keiths@redhat.com>
7762
7763 PR c++/24367
7764 * cp-support.c (inspect_type): Don't attempt substitutions
7765 of symbol with the same name.
7766
7767 2019-04-25 Tom Tromey <tromey@adacore.com>
7768
7769 PR gdb/24475:
7770 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7771 static.
7772
7773 2019-04-25 Tom Tromey <tromey@adacore.com>
7774
7775 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7776 rvalue reference.
7777 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7778 (gdb_xml_parser::parse): Use std::move.
7779 * python/python-internal.h (gdbpy_convert_exception): Take a const
7780 reference.
7781 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7782 std::move.
7783 * python/py-utils.c (gdbpy_convert_exception): Take a const
7784 reference.
7785 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7786 Use std::move.
7787 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7788 Use std::move.
7789 * mi/mi-main.c (mi_print_exception): Take a const reference.
7790 * main.c (handle_command_errors): Take a const reference.
7791 * linespec.c (parse_linespec): Use std::move.
7792 * infcall.c (run_inferior_call): Use std::move.
7793 (call_function_by_hand_dummy): Use std::move.
7794 * exec.c (try_open_exec_file): Use std::move.
7795 * exceptions.h (exception_print, exception_fprintf)
7796 (exception_print_same): Update.
7797 * exceptions.c (print_exception, exception_print)
7798 (exception_fprintf, exception_print_same): Change parameters to
7799 const reference.
7800 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7801 * common/new-op.c: Use std::move.
7802 * common/common-exceptions.h (struct gdb_exception): Add move
7803 constructor.
7804 (struct gdb_exception_error, struct gdb_exception_quit, struct
7805 gdb_quit_bad_alloc): Change constructor to move constructor.
7806 (throw_exception): Change parameter to rvalue reference.
7807 * common/common-exceptions.c (throw_exception): Take rvalue
7808 reference.
7809 * cli/cli-interp.c (safe_execute_command): Use std::move.
7810 * breakpoint.c (insert_bp_location, location_to_sals): Use
7811 std::move.
7812
7813 2019-04-25 Tom Tromey <tromey@adacore.com>
7814
7815 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7816 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7817 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7818 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7819 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7820 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7821 guile/scm-value.c: Use unpack.
7822 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7823 gdbscm_gdb_exception.
7824 (gdbscm_throw_gdb_exception): Likewise.
7825 (struct gdbscm_gdb_exception): New.
7826 (unpack): New function.
7827 (gdbscm_wrap): Use unpack.
7828
7829 2019-04-25 Tom Tromey <tromey@adacore.com>
7830
7831 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7832 (gdb_rl_callback_handler): Use std::move.
7833 * common/common-exceptions.h (struct gdb_exception): Add move
7834 assignment operator.
7835 (throw_exception_sjlj): Change "exception" to const reference.
7836 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7837 (throw_exception_sjlj): Change "exception" to const reference.
7838
7839 2019-04-25 Tom Tromey <tromey@adacore.com>
7840
7841 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7842 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7843 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7844 Update.
7845 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7846 Update.
7847 * mi/mi-interp.c (mi_interp::exec): Update.
7848 * linespec.c (parse_linespec): Update.
7849 * infcall.c (run_inferior_call): Update.
7850 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7851 * guile/scm-symbol.c (gdbscm_lookup_symbol)
7852 (gdbscm_lookup_global_symbol): Update.
7853 * guile/scm-param.c (gdbscm_parameter_value): Update.
7854 * guile/scm-frame.c (gdbscm_frame_read_register)
7855 (gdbscm_frame_read_var): Update.
7856 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7857 * exec.c (try_open_exec_file): Update.
7858 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7859 (gdb_rl_callback_handler): Update.
7860 * common/common-exceptions.h (exception_none): Don't declare.
7861 * common/common-exceptions.c (exception_none): Don't define.
7862 (struct catcher) <exception>: Update.
7863 * cli/cli-interp.c (safe_execute_command): Update.
7864 * breakpoint.c (insert_bp_location, location_to_sals): Update.
7865
7866 2019-04-25 Ali Tamur <tamur@google.com>
7867
7868 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7869 (read_attribute_value): Likewise.
7870 (dwarf2_read_addr_index): Update comment.
7871 (read_str_index): Add DW_FORM_strx.
7872 (dwarf2_string_attr): Likewise.
7873 (dwarf2_const_value_attr): Likewise.
7874 (dump_die_shallow): Likewise.
7875 (dwarf2_fetch_constant_bytes): Likewise.
7876 (skip_form_bytes): Likewise.
7877 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7878
7879 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
7880
7881 PR corefiles/11608
7882 PR corefiles/18187
7883 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7884 OFFSET. Verify if current mapping contains an ELF header.
7885 (linux_find_memory_regions_full): Adjust call to
7886 dump_mapping_p.
7887
7888 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
7889 Kang Li <kanglictf@gmail.com>
7890
7891 PR gdb/21600
7892
7893 * dwarf2-frame.c (read_initial_length): Be consistent about using
7894 unsigned representation of length.
7895 (decode_frame_entry_1): Likewise. Check for wraparound of
7896 end pointer as well as buffer overflow.
7897
7898 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
7899
7900 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7901 "vq".
7902
7903 2019-04-24 Tom Tromey <tromey@adacore.com>
7904
7905 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7906
7907 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7908
7909 * s12z-tdep.c (s12z_unwind_pc): Delete.
7910 (s12z_unwind_sp): Delete.
7911 (s12z_gdbarch_init): Don't register deleted functions with
7912 gdbarch.
7913
7914 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7915
7916 * rl78-tdep.c (rl78_unwind_sp): Delete.
7917 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7918
7919 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7920
7921 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7922 (xstormy16_unwind_pc): Delete.
7923 (xstormy16_dummy_id): Delete.
7924 (xstormy16_gdbarch_init): Don't register deleted functions with
7925 gdbarch.
7926
7927 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7928
7929 * vax-tdep.c (vax_unwind_pc): Delete.
7930 (vax_gdbarch_init): Don't register deleted function with gdbarch.
7931
7932 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7933
7934 * v850-tdep.c (v850_unwind_sp): Delete.
7935 (v850_unwind_pc): Delete.
7936 (v850_dummy_id): Delete.
7937 (v850_gdbarch_init): Don't register deleted functions with
7938 gdbarch.
7939
7940 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7941
7942 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7943 (tilegx_unwind_pc): Delete.
7944 (tilegx_unwind_dummy_id): Delete.
7945 (tilegx_gdbarch_init): Don't register deleted functions with
7946 gdbarch.
7947
7948 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7949
7950 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7951 (tic6x_dummy_id): Delete.
7952 (tic6x_gdbarch_init): Don't register deleted functions with
7953 gdbarch.
7954
7955 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7956
7957 * sparc-tdep.c (sparc_unwind_pc): Delete.
7958 (sparc32_gdbarch_init): Don't register deleted function with
7959 gdbarch.
7960
7961 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7962
7963 * sh-tdep.c (sh_unwind_sp): Delete.
7964 (sh_unwind_pc): Delete.
7965 (sh_dummy_id): Delete.
7966 (sh_gdbarch_init): Don't register deleted functions with
7967 gdbarch.
7968
7969 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7970
7971 * score-tdep.c (score_unwind_sp): Delete.
7972 (score_unwind_pc): Delete.
7973 (score_dummy_id): Delete.
7974 (score_gdbarch_init): Don't register deleted functions with
7975 gdbarch.
7976
7977 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7978
7979 * rx-tdep.c (rx_unwind_pc): Delete.
7980 (rx_unwind_sp): Delete.
7981 (rx_dummy_id): Delete.
7982 (rx_gdbarch_init): Don't register deleted functions with
7983 gdbarch. Update comment.
7984
7985 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7986
7987 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7988 (rs6000_dummy_id): Delete.
7989 (rs6000_gdbarch_init): Don't register deleted functions with
7990 gdbarch.
7991
7992 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7993
7994 * or1k-tdep.c (or1k_dummy_id): Delete.
7995 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7996
7997 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7998
7999 * nios2-tdep.c (nios2_dummy_id): Delete.
8000 (nios2_unwind_sp): Delete.
8001 (nios2_gdbarch_init): Don't register deleted functions with
8002 gdbarch.
8003
8004 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8005
8006 * nds32-tdep.c (nds32_dummy_id): Delete.
8007 (nds32_unwind_pc): Delete.
8008 (nds32_unwind_sp): Delete.
8009 (nds32_gdbarch_init): Don't register deleted functions with
8010 gdbarch.
8011
8012 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8013
8014 * msp430-tdep.c (msp430_unwind_pc): Delete.
8015 (msp430_unwind_sp): Delete.
8016 (msp430_dummy_id): Delete.
8017 (msp430_gdbarch_init): Don't register deleted functions with
8018 gdbarch.
8019
8020 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8021
8022 * moxie-tdep.c (moxie_unwind_sp): Delete.
8023 (moxie_unwind_pc): Delete.
8024 (moxie_dummy_id): Delete.
8025 (moxie_gdbarch_init): Don't register deleted functions with
8026 gdbarch.
8027
8028 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8029
8030 * mn10300-tdep.c (mn10300_dummy_id): Delete.
8031 (mn10300_unwind_pc): Delete.
8032 (mn10300_unwind_sp): Delete.
8033 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8034 mn10300_unwind_sp.
8035 (mn10300_frame_unwind_init): Don't register deleted functions with
8036 gdbarch.
8037
8038 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8039
8040 * mep-tdep.c (mep_unwind_pc): Delete.
8041 (mep_unwind_sp): Delete.
8042 (mep_dummy_id): Delete.
8043 (mep_gdbarch_init): Don't register deleted functions with
8044 gdbarch.
8045
8046 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8047
8048 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8049 (m68hc11_unwind_sp): Delete.
8050 (m68hc11_gdbarch_init): Don't register deleted functions with
8051 gdbarch.
8052
8053 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8054
8055 * m32r-tdep.c (m32r_unwind_sp): Delete.
8056 (m32r_unwind_pc): Delete.
8057 (m32r_dummy_id): Delete.
8058 (m32r_gdbarch_init): Don't register deleted functions with
8059 gdbarch.
8060
8061 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8062
8063 * m32c-tdep.c (m32c_unwind_pc): Delete.
8064 (m32c_unwind_sp): Delete.
8065 (m32c_dummy_id): Delete.
8066 (m32c_gdbarch_init): Don't register deleted functions with
8067 gdbarch.
8068
8069 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8070
8071 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8072 (lm32_unwind_pc): Delete.
8073 (lm32_dummy_id): Delete.
8074 (lm32_gdbarch_init): Don't register deleted functions with
8075 gdbarch.
8076
8077 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8078
8079 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8080 (iq2000_unwind_pc): Delete.
8081 (iq2000_dummy_id): Delete.
8082 (iq2000_gdbarch_init): Don't register deleted functions with
8083 gdbarch.
8084
8085 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8086
8087 * nds32-tdep.c (nds32_type_align): Delete.
8088 (nds32_push_dummy_call): Use type_align instead.
8089
8090 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8091
8092 * arm-tdep.c (arm_type_align): Only handle vector override case.
8093 (arm_push_dummy_call): Use type_align.
8094 (arm_gdbarch_init): Register arm_type_align gdbarch function.
8095
8096 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8097
8098 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8099 case.
8100 (pass_on_stack): Use type_align.
8101 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8102 function.
8103
8104 2019-04-23 Tom Tromey <tromey@adacore.com>
8105
8106 * dwarf2read.c (line_header::file_name_at): Remove unused
8107 overload.
8108
8109 2019-04-23 Tom de Vries <tdevries@suse.de>
8110
8111 PR gdb/24438
8112 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8113 invocation.
8114
8115
8116 2019-03-27 Ali Tamur <tamur@google.com>
8117
8118 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8119 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8120 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8121 (dwarf_expr_context::get_addr_index): Likewise
8122 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8123 (symbol_needs_eval_context::get_addr_index): Likewise
8124 (disassemble_dwarf_expression): Add DW_OP_addrx
8125 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8126 (read_cutu_die_from_dwo): Update comment
8127 (skip_one_die): Add DW_FORM_addrx
8128 (read_attribute_value): Likewise
8129 (var_decode_location): Add DW_OP_addrx
8130 (dwarf2_const_value_attr): Add DW_FORM_addrx
8131 (dump_die_shallow): Likewise
8132 (dwarf2_fetch_constant_bytes): Likewise
8133 (decode_locdesc): Add DW_OP_addrx
8134 (skip_form_bytes): Add DW_FORM_addrx
8135
8136 2019-04-22 Ali Tamur <tamur@google.com>
8137
8138 * MAINTAINERS (Write After Approval): Add self.
8139
8140 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
8141
8142 * solib-svr4.c (get_svr4_info): Add pspace parameter.
8143 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8144 (open_symbol_file_object): Likewise.
8145 (svr4_default_sos): Add info parameter.
8146 (svr4_read_so_list): Likewise.
8147 (svr4_current_sos_direct): Adjust functions calls to pass down
8148 info.
8149 (svr4_current_sos_1): Add info parameter.
8150 (svr4_current_sos): Call get_svr4_info, pass info down to
8151 svr4_current_sos_1.
8152 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8153 get_svr4_info.
8154 (svr4_in_dynsym_resolve_code): Pass current_program_space to
8155 get_svr4_info.
8156 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8157 to get_svr4_info.
8158 (probes_table_remove_objfile_probes): Likewise.
8159 (register_solib_event_probe): Add info parameter.
8160 (solist_update_incremental): Pass info parameter down to
8161 svr4_read_so_list.
8162 (disable_probes_interface): Add info parameter.
8163 (svr4_handle_solib_event): Pass current_program_space to
8164 get_svr4_info. Adjust disable_probes_interface cleanup.
8165 (svr4_create_probe_breakpoints): Add info parameter, pass it
8166 down to register_solib_event_probe.
8167 (svr4_create_solib_event_breakpoints): Add info parameter,
8168 pass it down to svr4_create_probe_breakpoints.
8169 (enable_break): Pass info down to
8170 svr4_create_solib_event_breakpoints.
8171 (svr4_solib_create_inferior_hook): Pass current_program_space to
8172 get_svr4_info.
8173 (svr4_clear_solib): Likewise.
8174
8175 2019-04-22 Pedro Alves <palves@redhat.com>
8176
8177 * solib-svr4.c (svr4_free_objfile_observer): New.
8178 (probe_and_action::objfile): New field.
8179 (probes_table_htab_remove_objfile_probes)
8180 (probes_table_remove_objfile_probes): New functions.
8181 (register_solib_event_probe): Add 'objfile' parameter. Store it
8182 in the new probe_and_action. Don't store the probe in 'lookup'.
8183 (svr4_create_probe_breakpoints): Pass objfile to
8184 register_solib_event_probe.
8185 (_initialize_svr4_solib): Register a free_objfile observer.
8186
8187 2019-04-19 Tom Tromey <tom@tromey.com>
8188
8189 * common/queue.h: Remove.
8190
8191 2019-04-19 Tom Tromey <tom@tromey.com>
8192
8193 * event-loop.c: Don't include "common/queue.h".
8194
8195 2019-04-19 Tom Tromey <tom@tromey.com>
8196
8197 * remote.c (remote_target): Use delete.
8198 * remote-notif.h: Include <list>, not "common/queue.h".
8199 (notif_client_p): Remove typedef.
8200 (remote_notif_state): Add constructor, destructor, initializer.
8201 <notif_queue>: Now a std::list.
8202 (remote_notif_state_xfree): Don't declare.
8203 * remote-notif.c (remote_notif_process, handle_notification)
8204 (remote_notif_state_allocate): Update.
8205 (~remote_notif_state): Rename from remote_notif_state_xfree.
8206
8207 2019-04-19 Tom Tromey <tom@tromey.com>
8208
8209 * symfile.c (reread_symbols): Update.
8210 * objfiles.c (objfile_register_static_link)
8211 (objfile_lookup_static_link): Update
8212 (~objfile) Don't delete static_links.
8213 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8214
8215 2019-04-19 Tom Tromey <tom@tromey.com>
8216
8217 * type-stack.h (struct type_stack) <insert>: Constify string.
8218 * type-stack.c (type_stack::insert): Constify string.
8219 * gdbtypes.h (lookup_template_type): Update.
8220 (address_space_name_to_int): Update.
8221 * gdbtypes.c (address_space_name_to_int): Make space_identifier
8222 const.
8223 (lookup_template_type): Make name const.
8224 * c-exp.y: Update rules.
8225 (lex_one_token, classify_name, classify_inner_name)
8226 (c_print_token): Update.
8227 * p-exp.y: Update rules.
8228 (yylex): Update.
8229 * f-exp.y: Update rules.
8230 (yylex): Update.
8231 * d-exp.y: Update rules.
8232 (lex_one_token, classify_name, classify_inner_name): Update.
8233 * parse.c (write_dollar_variable, copy_name): Return std::string.
8234 * parser-defs.h (copy_name): Change return type.
8235 * m2-exp.y: Update rules.
8236 (yylex): Update.
8237 * go-exp.y (lex_one_token): Update.
8238 Update rules.
8239 (classify_unsafe_function, classify_packaged_name)
8240 (classify_name, yylex): Update.
8241
8242 2019-04-19 Sergei Trofimovich <siarheit@google.com>
8243
8244 * configure.ac: add --enable-source-highlight switch.
8245 * configure: Regenerate.
8246 * top.c (print_gdb_version): plumb --enable-source-highlight
8247 status to "show configuration".
8248
8249 2019-04-19 Tom Tromey <tromey@adacore.com>
8250
8251 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8252 Check ADA_TYPE_P.
8253 (empty_record, ada_template_to_fixed_record_type_1)
8254 (template_to_static_fixed_type)
8255 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8256 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8257 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8258 macros.
8259
8260 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
8261
8262 PR symtab/24423:
8263 * source.c (print_source_lines_base): Advance "iter" when a
8264 control character is seen.
8265
8266 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8267
8268 * inferior.h (struct infcall_suspend_state_deleter):
8269 Catch exception in destructor to avoid crash.
8270
8271 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8272
8273 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8274 close to the add_com "shell".
8275
8276 2019-04-18 Tom Tromey <tromey@adacore.com>
8277
8278 * process-stratum-target.h (class process_stratum_target)
8279 <stratum>: Add "final".
8280
8281 2019-04-17 Tom Tromey <tromey@adacore.com>
8282
8283 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8284 against nullptr before use.
8285
8286 2019-04-17 Alan Hayward <alan.hayward@arm.com>
8287
8288 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8289
8290 2019-04-17 Jim Wilson <jimw@sifive.com>
8291 Andrew Burgess <andrew.burgess@embecosm.com>
8292
8293 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8294 code read might fail, assume 4-byte breakpoint in that case.
8295
8296 2019-04-15 Leszek Swirski <leszeks@google.com>
8297
8298 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8299 rather than a hand-rolled POD check when checking for forced MEMORY
8300 classification.
8301
8302 2019-04-15 Alan Hayward <alan.hayward@arm.com>
8303
8304 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8305 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8306 function.
8307 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8308 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8309 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8310 declaration.
8311
8312 2019-04-15 Alan Hayward <alan.hayward@arm.com>
8313
8314 * aarch64-linux-nat.c
8315 (aarch64_linux_nat_target::thread_architecture): Add override.
8316 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8317 each VQ.
8318
8319 2019-04-15 Alan Hayward <alan.hayward@arm.com>
8320
8321 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8322
8323 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
8324
8325 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8326 target types of size 96-bits, add some additional comments, and
8327 check that the builtin type we found was the correct size.
8328
8329 2019-04-12 Eli Zaretskii <eliz@gnu.org>
8330
8331 * utils.c (prompt_for_continue): Don't restore the styling at the
8332 end, as applied_style has the wrong value. This fixes styling in
8333 long lists of file names that are interrupted by the "Continue?"
8334 prompt.
8335
8336 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
8337
8338 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8339 * c-lang.c (c_language_defn): Likewise.
8340 (cplus_language_defn): Likewise.
8341 (asm_language_defn): Likewise.
8342 (minimal_language_defn): Likewise.
8343 * d-lang.c (d_language_defn): Likewise.
8344 * f-lang.c (f_language_defn): Likewise.
8345 * go-lang.c (go_language_defn): Likewise.
8346 * language.c (unknown_language_defn): Likewise.
8347 (auto_language_defn): Likewise.
8348 * language.h (struct language_defn): Remove la_magic field.
8349 (LANG_MAGIC): Delete.
8350 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8351 * objc-lang.c (objc_language_defn): Likewise.
8352 * opencl-lang.c (opencl_language_defn): Likewise.
8353 * p-lang.c (pascal_language_defn): Likewise.
8354 * rust-lang.c (rust_language_defn): Likewise.
8355
8356 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8357
8358 * riscv-tdep.c (riscv_type_align): New function.
8359 (riscv_type_alignment): Delete.
8360 (riscv_arg_location): Use 'type_align'.
8361 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8362
8363 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8364
8365 * gdbtypes.c (type_align): A struct with no non-static fields also
8366 has alignment of 1.
8367
8368 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8369
8370 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8371 component to 0.
8372 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8373 member.
8374 (riscv_struct_info::analyse): New implementation using new
8375 analyse_inner member function.
8376 (riscv_struct_info::field_offset): New member function.
8377 (riscv_struct_info::m_offsets): New member variable.
8378 (riscv_struct_info::analyse_inner): New private member function,
8379 takes the old implementation of riscv_struct_info::analyse but
8380 extended to track field offsets.
8381 (riscv_call_arg_struct): Update the struct folding special cases
8382 to handle cases where empty C++ structs, which are non-zero
8383 length, are found.
8384 (riscv_arg_location): Initialise the length of each location, a
8385 non-zero length now indicates the location is in use.
8386 (riscv_push_dummy_call): Allow for the first location having a
8387 non-zero offset when setting up arguments.
8388 (riscv_return_value): Likewise, but for return values.
8389
8390 2019-04-11 Tom Tromey <tromey@adacore.com>
8391
8392 * utils.c (internal_vproblem): Make "msg" const.
8393
8394 2019-04-11 Alan Hayward <alan.hayward@arm.com>
8395
8396 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8397 * trad-frame.c (trad_frame_reset_saved_regs): New function.
8398 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8399 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8400
8401 2019-04-10 Kevin Buettner <kevinb@redhat.com>
8402
8403 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8404 function.
8405 (fill_gregset): Call amd64_linux_collect_native_gregset instead
8406 of amd64_collect_native_gregset.
8407 (amd64_linux_nat_target::store_registers): Likewise.
8408
8409 2019-04-10 Tom Tromey <tom@tromey.com>
8410
8411 * symtab.c (lookup_global_symbol_from_objfile)
8412 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8413 * objfiles.h (class separate_debug_iterator): New.
8414 (class separate_debug_range): New.
8415 (struct objfile) <separate_debug_objfiles>: New method.
8416 (objfile_separate_debug_iterate): Don't declare.
8417 * objfiles.c (separate_debug_iterator::operator++): Rename from
8418 objfile_separate_debug_iterate.
8419 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8420 iterator.
8421 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8422 iterator.
8423
8424 2019-04-10 Tom Tromey <tom@tromey.com>
8425
8426 * symfile.c (reread_symbols): Remove old comment.
8427 * objfiles.c (free_all_objfiles): Fix a typo.
8428
8429 2019-04-10 Tom Tromey <tom@tromey.com>
8430
8431 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8432 * minsyms.c (lookup_minimal_symbol): Use foreach.
8433 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8434 (lookup_minimal_symbol_solib_trampoline): Likewise.
8435 * symfile.c (reread_symbols): Use foreach.
8436
8437 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
8438 Tom Tromey <tromey@adacore.com>
8439
8440 PR rust/24414:
8441 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8442 (rust_lex_int_test): Change "value" to be LONGEST.
8443 (rust_lex_tests): Add test for long integer literal.
8444
8445 2019-04-09 Tom Tromey <tromey@adacore.com>
8446
8447 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8448 to bool.
8449 (extended_remote_target::attach): Update.
8450 (remote_target::remote_notice_new_inferior): Update.
8451 (remote_target::add_current_inferior_and_thread): Update.
8452 * inferior.c (exit_inferior_1): Use "false".
8453 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8454
8455 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
8456
8457 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8458 the "start" command.
8459
8460 2019-04-08 Kevin Buettner <kevinb@redhat.com>
8461
8462 * python/py-inferior.c (infpy_thread_from_thread_handle):
8463 Adjust comments to reflect renaming of thread_from_thread_handle
8464 to thread_from_handle. Adjust keywords. Fix type error message.
8465 (inferior_object_methods): Add thread_from_handle. Retain
8466 thread_from_thread_handle, but mark it as deprecated.
8467
8468 2019-04-08 Kevin Buettner <kevinb@redhat.com>
8469
8470 * gdbthread.h (find_thread_by_handle): Revise declaration.
8471 * thread.c (find_thread_by_handle): Likewise. Adjust
8472 implementation too.
8473 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8474 support for buffer objects as handles.
8475
8476 2019-04-08 Kevin Buettner <kevinb@redhat.com>
8477
8478 * python/py-infthread.c (thpy_thread_handle): New function.
8479 (thread_object_methods): Register thpy_thread_handle.
8480
8481 2019-04-08 Kevin Buettner <kevinb@redhat.com>
8482
8483 * gdbthread.h (thread_to_thread_handle): Declare.
8484 * thread.c (gdbtypes.h): Include.
8485 (thread_to_thread_handle): New function.
8486
8487 * target.h (struct target_ops): Add thread_info_to_thread_handle.
8488 (target_thread_info_to_thread_handle): Declare.
8489 * target.c (target_thread_info_to_thread_handle): New function.
8490 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8491 * target-delegates.c: Regenerate.
8492
8493 * linux-thread-db.c (class thread_db_target): Add method
8494 thread_info_to_thread_handle.
8495 (thread_db_target::thread_info_to_thread_handle): Define.
8496 * remote.c (class remote_target): Add new method
8497 thread_info_to_thread_handle.
8498 (remote_target::thread_info_to_thread_handle): Define.
8499
8500 2019-04-08 Pedro Alves <palves@redhat.com>
8501
8502 * common/common-exceptions.c (throw_exception): Don't create
8503 named object to throw; throw directly.
8504 (throw_it): Likewise. Don't initialize gdb_exception::message
8505 here, with new; pass FMT and AP to the ctor instead.
8506 * common/common-exceptions.h: Include <string>.
8507 (gdb_exception::gdb_exception(enum return_reason, enum errors,
8508 const char *, va_list)): New ctor. Use std::make_shared.
8509 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8510 errors)): Delete.
8511 (gdb_exception_error::gdb_exception_error(enum errors, const char
8512 *, va_list)): New.
8513 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8514 Add assertion.
8515 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8516 errors)): Delete.
8517 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8518 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8519 Add assertion.
8520
8521 2019-04-08 Tom Tromey <tom@tromey.com>
8522
8523 * valops.c (value_rtti_indirect_type): Replace throw_exception
8524 with throw.
8525 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8526 with throw.
8527 * thread.c (thr_try_catch_cmd): Replace throw_exception with
8528 throw.
8529 * target.c (target_translate_tls_address): Replace throw_exception
8530 with throw.
8531 * stack.c (frame_apply_command_count): Replace throw_exception
8532 with throw.
8533 * solib-spu.c (append_ocl_sos): Replace throw_exception with
8534 throw.
8535 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8536 with throw.
8537 * rs6000-tdep.c (rs6000_frame_cache)
8538 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8539 * remote.c: Replace throw_exception with throw.
8540 * record-full.c (record_full_message, record_full_wait_1)
8541 (record_full_restore): Replace throw_exception with throw.
8542 * record-btrace.c:
8543 (get_thread_current_frame_id, record_btrace_start_replaying)
8544 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8545 (cmd_record_btrace_start): Replace throw_exception with throw.
8546 * parse.c (parse_exp_in_context_1): Replace throw_exception with
8547 throw.
8548 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8549 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8550 * linespec.c:
8551 (find_linespec_symbols): Replace throw_exception with throw.
8552 * infrun.c (displaced_step_prepare, resume): Replace
8553 throw_exception with throw.
8554 * infcmd.c (post_create_inferior): Replace throw_exception with
8555 throw.
8556 * inf-loop.c (inferior_event_handler): Replace throw_exception
8557 with throw.
8558 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8559 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8560 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8561 (get_prev_frame_always, get_frame_pc_if_available)
8562 (get_frame_address_in_block_if_available, get_frame_language):
8563 Replace throw_exception with throw.
8564 * frame-unwind.c (frame_unwind_try_unwinder): Replace
8565 throw_exception with throw.
8566 * eval.c (fetch_subexp_value, evaluate_var_value)
8567 (evaluate_funcall, evaluate_subexp_standard): Replace
8568 throw_exception with throw.
8569 * dwarf2loc.c (call_site_find_chain)
8570 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8571 Replace throw_exception with throw.
8572 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8573 with throw.
8574 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8575 throw.
8576 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8577 * completer.c (complete_line_internal): Replace throw_exception
8578 with throw.
8579 * compile/compile-object-run.c (compile_object_run): Replace
8580 throw_exception with throw.
8581 * cli/cli-script.c (process_next_line): Replace throw_exception
8582 with throw.
8583 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8584 (btrace_enable, btrace_maint_update_pt_packets): Replace
8585 throw_exception with throw.
8586 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8587 throw_exception with throw.
8588 * break-catch-throw.c (re_set_exception_catchpoint): Replace
8589 throw_exception with throw.
8590 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8591 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8592 * aarch64-tdep.c (aarch64_make_prologue_cache)
8593 (aarch64_make_stub_cache): Replace throw_exception with throw.
8594
8595 2019-04-08 Tom Tromey <tom@tromey.com>
8596
8597 * common/common-exceptions.c (throw_exception): Rename from
8598 throw_exception_cxx. Remove old copy. Make argument const.
8599 (throw_it): Create and throw exception objects directly.
8600 * common/common-exceptions.h (throw_exception): Make argument
8601 const.
8602 (struct gdb_exception_error): Add constructor.
8603 (struct gdb_exception_quit): Add constructor.
8604
8605 2019-04-08 Tom Tromey <tom@tromey.com>
8606
8607 * common/common-exceptions.h (exception_rethrow): Don't declare.
8608 (TRY_SJLJ): Update comment.
8609 (TRY, CATCH, END_CATCH): Remove.
8610 * common/common-exceptions.c (exception_rethrow): Remove.
8611
8612 2019-04-08 Tom Tromey <tom@tromey.com>
8613
8614 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8615 Remove.
8616 (gdb_exception_error): Rename from
8617 gdb_exception_RETURN_MASK_ERROR.
8618 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8619 (gdb_quit_bad_alloc): Update.
8620 * aarch64-tdep.c: Update.
8621 * ada-lang.c: Update.
8622 * ada-typeprint.c: Update.
8623 * ada-valprint.c: Update.
8624 * amd64-tdep.c: Update.
8625 * arch-utils.c: Update.
8626 * break-catch-throw.c: Update.
8627 * breakpoint.c: Update.
8628 * btrace.c: Update.
8629 * c-varobj.c: Update.
8630 * cli/cli-cmds.c: Update.
8631 * cli/cli-interp.c: Update.
8632 * cli/cli-script.c: Update.
8633 * common/common-exceptions.c: Update.
8634 * common/new-op.c: Update.
8635 * common/selftest.c: Update.
8636 * compile/compile-c-symbols.c: Update.
8637 * compile/compile-cplus-symbols.c: Update.
8638 * compile/compile-object-load.c: Update.
8639 * compile/compile-object-run.c: Update.
8640 * completer.c: Update.
8641 * corelow.c: Update.
8642 * cp-abi.c: Update.
8643 * cp-support.c: Update.
8644 * cp-valprint.c: Update.
8645 * darwin-nat.c: Update.
8646 * disasm-selftests.c: Update.
8647 * dtrace-probe.c: Update.
8648 * dwarf-index-cache.c: Update.
8649 * dwarf-index-write.c: Update.
8650 * dwarf2-frame-tailcall.c: Update.
8651 * dwarf2-frame.c: Update.
8652 * dwarf2loc.c: Update.
8653 * dwarf2read.c: Update.
8654 * eval.c: Update.
8655 * event-loop.c: Update.
8656 * event-top.c: Update.
8657 * exec.c: Update.
8658 * f-valprint.c: Update.
8659 * fbsd-tdep.c: Update.
8660 * frame-unwind.c: Update.
8661 * frame.c: Update.
8662 * gdbtypes.c: Update.
8663 * gnu-v3-abi.c: Update.
8664 * guile/guile-internal.h: Update.
8665 * guile/scm-block.c: Update.
8666 * guile/scm-breakpoint.c: Update.
8667 * guile/scm-cmd.c: Update.
8668 * guile/scm-disasm.c: Update.
8669 * guile/scm-frame.c: Update.
8670 * guile/scm-lazy-string.c: Update.
8671 * guile/scm-math.c: Update.
8672 * guile/scm-param.c: Update.
8673 * guile/scm-ports.c: Update.
8674 * guile/scm-pretty-print.c: Update.
8675 * guile/scm-symbol.c: Update.
8676 * guile/scm-symtab.c: Update.
8677 * guile/scm-type.c: Update.
8678 * guile/scm-value.c: Update.
8679 * i386-linux-tdep.c: Update.
8680 * i386-tdep.c: Update.
8681 * inf-loop.c: Update.
8682 * infcall.c: Update.
8683 * infcmd.c: Update.
8684 * infrun.c: Update.
8685 * jit.c: Update.
8686 * language.c: Update.
8687 * linespec.c: Update.
8688 * linux-fork.c: Update.
8689 * linux-nat.c: Update.
8690 * linux-tdep.c: Update.
8691 * linux-thread-db.c: Update.
8692 * main.c: Update.
8693 * mi/mi-cmd-break.c: Update.
8694 * mi/mi-cmd-stack.c: Update.
8695 * mi/mi-interp.c: Update.
8696 * mi/mi-main.c: Update.
8697 * objc-lang.c: Update.
8698 * p-valprint.c: Update.
8699 * parse.c: Update.
8700 * ppc-linux-tdep.c: Update.
8701 * printcmd.c: Update.
8702 * python/py-arch.c: Update.
8703 * python/py-breakpoint.c: Update.
8704 * python/py-cmd.c: Update.
8705 * python/py-finishbreakpoint.c: Update.
8706 * python/py-frame.c: Update.
8707 * python/py-framefilter.c: Update.
8708 * python/py-gdb-readline.c: Update.
8709 * python/py-inferior.c: Update.
8710 * python/py-infthread.c: Update.
8711 * python/py-lazy-string.c: Update.
8712 * python/py-linetable.c: Update.
8713 * python/py-objfile.c: Update.
8714 * python/py-param.c: Update.
8715 * python/py-prettyprint.c: Update.
8716 * python/py-progspace.c: Update.
8717 * python/py-record-btrace.c: Update.
8718 * python/py-record.c: Update.
8719 * python/py-symbol.c: Update.
8720 * python/py-type.c: Update.
8721 * python/py-unwind.c: Update.
8722 * python/py-utils.c: Update.
8723 * python/py-value.c: Update.
8724 * python/python.c: Update.
8725 * record-btrace.c: Update.
8726 * record-full.c: Update.
8727 * remote-fileio.c: Update.
8728 * remote.c: Update.
8729 * riscv-tdep.c: Update.
8730 * rs6000-aix-tdep.c: Update.
8731 * rs6000-tdep.c: Update.
8732 * rust-exp.y: Update.
8733 * rust-lang.c: Update.
8734 * s390-tdep.c: Update.
8735 * selftest-arch.c: Update.
8736 * solib-dsbt.c: Update.
8737 * solib-frv.c: Update.
8738 * solib-spu.c: Update.
8739 * solib-svr4.c: Update.
8740 * solib.c: Update.
8741 * sparc64-linux-tdep.c: Update.
8742 * stack.c: Update.
8743 * symfile-mem.c: Update.
8744 * symmisc.c: Update.
8745 * target.c: Update.
8746 * thread.c: Update.
8747 * top.c: Update.
8748 * tracefile-tfile.c: Update.
8749 * tui/tui.c: Update.
8750 * typeprint.c: Update.
8751 * unittests/cli-utils-selftests.c: Update.
8752 * unittests/parse-connection-spec-selftests.c: Update.
8753 * valops.c: Update.
8754 * valprint.c: Update.
8755 * value.c: Update.
8756 * varobj.c: Update.
8757 * windows-nat.c: Update.
8758 * x86-linux-nat.c: Update.
8759 * xml-support.c: Update.
8760
8761 2019-04-08 Tom Tromey <tom@tromey.com>
8762
8763 * xml-support.c: Use C++ exception handling.
8764 * x86-linux-nat.c: Use C++ exception handling.
8765 * windows-nat.c: Use C++ exception handling.
8766 * varobj.c: Use C++ exception handling.
8767 * value.c: Use C++ exception handling.
8768 * valprint.c: Use C++ exception handling.
8769 * valops.c: Use C++ exception handling.
8770 * unittests/parse-connection-spec-selftests.c: Use C++ exception
8771 handling.
8772 * unittests/cli-utils-selftests.c: Use C++ exception handling.
8773 * typeprint.c: Use C++ exception handling.
8774 * tui/tui.c: Use C++ exception handling.
8775 * tracefile-tfile.c: Use C++ exception handling.
8776 * top.c: Use C++ exception handling.
8777 * thread.c: Use C++ exception handling.
8778 * target.c: Use C++ exception handling.
8779 * symmisc.c: Use C++ exception handling.
8780 * symfile-mem.c: Use C++ exception handling.
8781 * stack.c: Use C++ exception handling.
8782 * sparc64-linux-tdep.c: Use C++ exception handling.
8783 * solib.c: Use C++ exception handling.
8784 * solib-svr4.c: Use C++ exception handling.
8785 * solib-spu.c: Use C++ exception handling.
8786 * solib-frv.c: Use C++ exception handling.
8787 * solib-dsbt.c: Use C++ exception handling.
8788 * selftest-arch.c: Use C++ exception handling.
8789 * s390-tdep.c: Use C++ exception handling.
8790 * rust-lang.c: Use C++ exception handling.
8791 * rust-exp.y: Use C++ exception handling.
8792 * rs6000-tdep.c: Use C++ exception handling.
8793 * rs6000-aix-tdep.c: Use C++ exception handling.
8794 * riscv-tdep.c: Use C++ exception handling.
8795 * remote.c: Use C++ exception handling.
8796 * remote-fileio.c: Use C++ exception handling.
8797 * record-full.c: Use C++ exception handling.
8798 * record-btrace.c: Use C++ exception handling.
8799 * python/python.c: Use C++ exception handling.
8800 * python/py-value.c: Use C++ exception handling.
8801 * python/py-utils.c: Use C++ exception handling.
8802 * python/py-unwind.c: Use C++ exception handling.
8803 * python/py-type.c: Use C++ exception handling.
8804 * python/py-symbol.c: Use C++ exception handling.
8805 * python/py-record.c: Use C++ exception handling.
8806 * python/py-record-btrace.c: Use C++ exception handling.
8807 * python/py-progspace.c: Use C++ exception handling.
8808 * python/py-prettyprint.c: Use C++ exception handling.
8809 * python/py-param.c: Use C++ exception handling.
8810 * python/py-objfile.c: Use C++ exception handling.
8811 * python/py-linetable.c: Use C++ exception handling.
8812 * python/py-lazy-string.c: Use C++ exception handling.
8813 * python/py-infthread.c: Use C++ exception handling.
8814 * python/py-inferior.c: Use C++ exception handling.
8815 * python/py-gdb-readline.c: Use C++ exception handling.
8816 * python/py-framefilter.c: Use C++ exception handling.
8817 * python/py-frame.c: Use C++ exception handling.
8818 * python/py-finishbreakpoint.c: Use C++ exception handling.
8819 * python/py-cmd.c: Use C++ exception handling.
8820 * python/py-breakpoint.c: Use C++ exception handling.
8821 * python/py-arch.c: Use C++ exception handling.
8822 * printcmd.c: Use C++ exception handling.
8823 * ppc-linux-tdep.c: Use C++ exception handling.
8824 * parse.c: Use C++ exception handling.
8825 * p-valprint.c: Use C++ exception handling.
8826 * objc-lang.c: Use C++ exception handling.
8827 * mi/mi-main.c: Use C++ exception handling.
8828 * mi/mi-interp.c: Use C++ exception handling.
8829 * mi/mi-cmd-stack.c: Use C++ exception handling.
8830 * mi/mi-cmd-break.c: Use C++ exception handling.
8831 * main.c: Use C++ exception handling.
8832 * linux-thread-db.c: Use C++ exception handling.
8833 * linux-tdep.c: Use C++ exception handling.
8834 * linux-nat.c: Use C++ exception handling.
8835 * linux-fork.c: Use C++ exception handling.
8836 * linespec.c: Use C++ exception handling.
8837 * language.c: Use C++ exception handling.
8838 * jit.c: Use C++ exception handling.
8839 * infrun.c: Use C++ exception handling.
8840 * infcmd.c: Use C++ exception handling.
8841 * infcall.c: Use C++ exception handling.
8842 * inf-loop.c: Use C++ exception handling.
8843 * i386-tdep.c: Use C++ exception handling.
8844 * i386-linux-tdep.c: Use C++ exception handling.
8845 * guile/scm-value.c: Use C++ exception handling.
8846 * guile/scm-type.c: Use C++ exception handling.
8847 * guile/scm-symtab.c: Use C++ exception handling.
8848 * guile/scm-symbol.c: Use C++ exception handling.
8849 * guile/scm-pretty-print.c: Use C++ exception handling.
8850 * guile/scm-ports.c: Use C++ exception handling.
8851 * guile/scm-param.c: Use C++ exception handling.
8852 * guile/scm-math.c: Use C++ exception handling.
8853 * guile/scm-lazy-string.c: Use C++ exception handling.
8854 * guile/scm-frame.c: Use C++ exception handling.
8855 * guile/scm-disasm.c: Use C++ exception handling.
8856 * guile/scm-cmd.c: Use C++ exception handling.
8857 * guile/scm-breakpoint.c: Use C++ exception handling.
8858 * guile/scm-block.c: Use C++ exception handling.
8859 * guile/guile-internal.h: Use C++ exception handling.
8860 * gnu-v3-abi.c: Use C++ exception handling.
8861 * gdbtypes.c: Use C++ exception handling.
8862 * frame.c: Use C++ exception handling.
8863 * frame-unwind.c: Use C++ exception handling.
8864 * fbsd-tdep.c: Use C++ exception handling.
8865 * f-valprint.c: Use C++ exception handling.
8866 * exec.c: Use C++ exception handling.
8867 * event-top.c: Use C++ exception handling.
8868 * event-loop.c: Use C++ exception handling.
8869 * eval.c: Use C++ exception handling.
8870 * dwarf2read.c: Use C++ exception handling.
8871 * dwarf2loc.c: Use C++ exception handling.
8872 * dwarf2-frame.c: Use C++ exception handling.
8873 * dwarf2-frame-tailcall.c: Use C++ exception handling.
8874 * dwarf-index-write.c: Use C++ exception handling.
8875 * dwarf-index-cache.c: Use C++ exception handling.
8876 * dtrace-probe.c: Use C++ exception handling.
8877 * disasm-selftests.c: Use C++ exception handling.
8878 * darwin-nat.c: Use C++ exception handling.
8879 * cp-valprint.c: Use C++ exception handling.
8880 * cp-support.c: Use C++ exception handling.
8881 * cp-abi.c: Use C++ exception handling.
8882 * corelow.c: Use C++ exception handling.
8883 * completer.c: Use C++ exception handling.
8884 * compile/compile-object-run.c: Use C++ exception handling.
8885 * compile/compile-object-load.c: Use C++ exception handling.
8886 * compile/compile-cplus-symbols.c: Use C++ exception handling.
8887 * compile/compile-c-symbols.c: Use C++ exception handling.
8888 * common/selftest.c: Use C++ exception handling.
8889 * common/new-op.c: Use C++ exception handling.
8890 * cli/cli-script.c: Use C++ exception handling.
8891 * cli/cli-interp.c: Use C++ exception handling.
8892 * cli/cli-cmds.c: Use C++ exception handling.
8893 * c-varobj.c: Use C++ exception handling.
8894 * btrace.c: Use C++ exception handling.
8895 * breakpoint.c: Use C++ exception handling.
8896 * break-catch-throw.c: Use C++ exception handling.
8897 * arch-utils.c: Use C++ exception handling.
8898 * amd64-tdep.c: Use C++ exception handling.
8899 * ada-valprint.c: Use C++ exception handling.
8900 * ada-typeprint.c: Use C++ exception handling.
8901 * ada-lang.c: Use C++ exception handling.
8902 * aarch64-tdep.c: Use C++ exception handling.
8903
8904 2019-04-08 Tom Tromey <tom@tromey.com>
8905
8906 * xml-support.c (gdb_xml_parser::parse): Update.
8907 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8908 * value.c (show_convenience): Update.
8909 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8910 (test_parse_flags_qcs): Update.
8911 * thread.c (thr_try_catch_cmd): Update.
8912 * target.c (target_translate_tls_address): Update.
8913 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8914 (info_frame_command_core, frame_apply_command_count): Update.
8915 * rust-exp.y (rust_lex_exception_test): Update.
8916 * riscv-tdep.c (riscv_print_one_register_info): Update.
8917 * remote.c (remote_target::enable_btrace): Update.
8918 * record-btrace.c (record_btrace_enable_warn): Update.
8919 * python/py-utils.c (gdbpy_convert_exception): Update.
8920 * printcmd.c (do_one_display, print_variable_and_value): Update.
8921 * mi/mi-main.c (mi_print_exception): Update.
8922 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8923 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8924 * linux-nat.c (linux_nat_target::attach): Update.
8925 * linux-fork.c (class scoped_switch_fork_info): Update.
8926 * infrun.c (displaced_step_prepare): Update.
8927 * infcall.c (call_function_by_hand_dummy): Update.
8928 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8929 * gnu-v3-abi.c (print_one_vtable): Update.
8930 * frame.c (get_prev_frame_always): Update.
8931 * f-valprint.c (info_common_command_for_block): Update.
8932 * exec.c (try_open_exec_file): Update.
8933 * exceptions.c (print_exception, exception_print)
8934 (exception_fprintf, exception_print_same): Update.
8935 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8936 * dwarf-index-cache.c (index_cache::store)
8937 (index_cache::lookup_gdb_index): Update.
8938 * darwin-nat.c (maybe_cache_shell): Update.
8939 * cp-valprint.c (cp_print_value_fields): Update.
8940 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8941 (gcc_cplus_symbol_address): Update.
8942 * compile/compile-c-symbols.c (gcc_convert_symbol)
8943 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8944 * common/selftest.c: Update.
8945 * common/common-exceptions.h (struct gdb_exception) <message>: Now
8946 a std::string.
8947 (exception_try_scope_entry, exception_try_scope_exit): Don't
8948 declare.
8949 (struct exception_try_scope): Remove.
8950 (TRY): Don't use exception_try_scope.
8951 (struct gdb_exception): Add constructor, operator=.
8952 <what>: New method.
8953 (struct gdb_exception_RETURN_MASK_ALL)
8954 (struct gdb_exception_RETURN_MASK_ERROR)
8955 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8956 (struct gdb_quit_bad_alloc): Update.
8957 * common/common-exceptions.c (exception_none): Change
8958 initializer.
8959 (struct catcher) <state, exception>: Initialize inline.
8960 <prev>: Remove member.
8961 (current_catcher): Remove.
8962 (catchers): New global.
8963 (exceptions_state_mc_init): Simplify.
8964 (catcher_pop): Remove.
8965 (exceptions_state_mc, exceptions_state_mc_catch): Update.
8966 (try_scope_depth, exception_try_scope_entry)
8967 (exception_try_scope_exit): Remove.
8968 (throw_exception_sjlj): Update.
8969 (exception_messages, exception_messages_size): Remove.
8970 (throw_it): Simplify.
8971 (gdb_exception_sliced_copy): Remove.
8972 (throw_exception_cxx): Update.
8973 * cli/cli-script.c (script_from_file): Update.
8974 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8975 Update.
8976 * ada-valprint.c (ada_val_print): Update.
8977 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8978 (create_excep_cond_exprs): Update.
8979
8980 2019-04-08 Tom Tromey <tom@tromey.com>
8981
8982 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8983 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8984 (TRY, CATCH, END_CATCH): Remove some definitions.
8985 * common/common-exceptions.c: Don't use GDB_XCPT.
8986 (catcher_list_size): Remove.
8987 (throw_exception, throw_it): Simplify.
8988
8989 2019-04-05 Tom Tromey <tom@tromey.com>
8990
8991 Revert the header-sorting patch.
8992 * ft32-tdep.c: Revert.
8993 * frv-tdep.c: Revert.
8994 * frv-linux-tdep.c: Revert.
8995 * frame.c: Revert.
8996 * frame-unwind.c: Revert.
8997 * frame-base.c: Revert.
8998 * fork-child.c: Revert.
8999 * findvar.c: Revert.
9000 * findcmd.c: Revert.
9001 * filesystem.c: Revert.
9002 * filename-seen-cache.h: Revert.
9003 * filename-seen-cache.c: Revert.
9004 * fbsd-tdep.c: Revert.
9005 * fbsd-nat.h: Revert.
9006 * fbsd-nat.c: Revert.
9007 * f-valprint.c: Revert.
9008 * f-typeprint.c: Revert.
9009 * f-lang.c: Revert.
9010 * extension.h: Revert.
9011 * extension.c: Revert.
9012 * extension-priv.h: Revert.
9013 * expprint.c: Revert.
9014 * exec.h: Revert.
9015 * exec.c: Revert.
9016 * exceptions.c: Revert.
9017 * event-top.c: Revert.
9018 * event-loop.c: Revert.
9019 * eval.c: Revert.
9020 * elfread.c: Revert.
9021 * dwarf2read.h: Revert.
9022 * dwarf2read.c: Revert.
9023 * dwarf2loc.c: Revert.
9024 * dwarf2expr.h: Revert.
9025 * dwarf2expr.c: Revert.
9026 * dwarf2-frame.c: Revert.
9027 * dwarf2-frame-tailcall.c: Revert.
9028 * dwarf-index-write.h: Revert.
9029 * dwarf-index-write.c: Revert.
9030 * dwarf-index-common.c: Revert.
9031 * dwarf-index-cache.h: Revert.
9032 * dwarf-index-cache.c: Revert.
9033 * dummy-frame.c: Revert.
9034 * dtrace-probe.c: Revert.
9035 * disasm.h: Revert.
9036 * disasm.c: Revert.
9037 * disasm-selftests.c: Revert.
9038 * dictionary.c: Revert.
9039 * dicos-tdep.c: Revert.
9040 * demangle.c: Revert.
9041 * dcache.h: Revert.
9042 * dcache.c: Revert.
9043 * darwin-nat.h: Revert.
9044 * darwin-nat.c: Revert.
9045 * darwin-nat-info.c: Revert.
9046 * d-valprint.c: Revert.
9047 * d-namespace.c: Revert.
9048 * d-lang.c: Revert.
9049 * ctf.c: Revert.
9050 * csky-tdep.c: Revert.
9051 * csky-linux-tdep.c: Revert.
9052 * cris-tdep.c: Revert.
9053 * cris-linux-tdep.c: Revert.
9054 * cp-valprint.c: Revert.
9055 * cp-support.c: Revert.
9056 * cp-namespace.c: Revert.
9057 * cp-abi.c: Revert.
9058 * corelow.c: Revert.
9059 * corefile.c: Revert.
9060 * continuations.c: Revert.
9061 * completer.h: Revert.
9062 * completer.c: Revert.
9063 * complaints.c: Revert.
9064 * coffread.c: Revert.
9065 * coff-pe-read.c: Revert.
9066 * cli-out.h: Revert.
9067 * cli-out.c: Revert.
9068 * charset.c: Revert.
9069 * c-varobj.c: Revert.
9070 * c-valprint.c: Revert.
9071 * c-typeprint.c: Revert.
9072 * c-lang.c: Revert.
9073 * buildsym.c: Revert.
9074 * buildsym-legacy.c: Revert.
9075 * build-id.h: Revert.
9076 * build-id.c: Revert.
9077 * btrace.c: Revert.
9078 * bsd-uthread.c: Revert.
9079 * breakpoint.h: Revert.
9080 * breakpoint.c: Revert.
9081 * break-catch-throw.c: Revert.
9082 * break-catch-syscall.c: Revert.
9083 * break-catch-sig.c: Revert.
9084 * blockframe.c: Revert.
9085 * block.c: Revert.
9086 * bfin-tdep.c: Revert.
9087 * bfin-linux-tdep.c: Revert.
9088 * bfd-target.c: Revert.
9089 * bcache.c: Revert.
9090 * ax-general.c: Revert.
9091 * ax-gdb.h: Revert.
9092 * ax-gdb.c: Revert.
9093 * avr-tdep.c: Revert.
9094 * auxv.c: Revert.
9095 * auto-load.c: Revert.
9096 * arm-wince-tdep.c: Revert.
9097 * arm-tdep.c: Revert.
9098 * arm-symbian-tdep.c: Revert.
9099 * arm-pikeos-tdep.c: Revert.
9100 * arm-obsd-tdep.c: Revert.
9101 * arm-nbsd-tdep.c: Revert.
9102 * arm-nbsd-nat.c: Revert.
9103 * arm-linux-tdep.c: Revert.
9104 * arm-linux-nat.c: Revert.
9105 * arm-fbsd-tdep.c: Revert.
9106 * arm-fbsd-nat.c: Revert.
9107 * arm-bsd-tdep.c: Revert.
9108 * arch-utils.c: Revert.
9109 * arc-tdep.c: Revert.
9110 * arc-newlib-tdep.c: Revert.
9111 * annotate.h: Revert.
9112 * annotate.c: Revert.
9113 * amd64-windows-tdep.c: Revert.
9114 * amd64-windows-nat.c: Revert.
9115 * amd64-tdep.c: Revert.
9116 * amd64-sol2-tdep.c: Revert.
9117 * amd64-obsd-tdep.c: Revert.
9118 * amd64-obsd-nat.c: Revert.
9119 * amd64-nbsd-tdep.c: Revert.
9120 * amd64-nbsd-nat.c: Revert.
9121 * amd64-nat.c: Revert.
9122 * amd64-linux-tdep.c: Revert.
9123 * amd64-linux-nat.c: Revert.
9124 * amd64-fbsd-tdep.c: Revert.
9125 * amd64-fbsd-nat.c: Revert.
9126 * amd64-dicos-tdep.c: Revert.
9127 * amd64-darwin-tdep.c: Revert.
9128 * amd64-bsd-nat.c: Revert.
9129 * alpha-tdep.c: Revert.
9130 * alpha-obsd-tdep.c: Revert.
9131 * alpha-nbsd-tdep.c: Revert.
9132 * alpha-mdebug-tdep.c: Revert.
9133 * alpha-linux-tdep.c: Revert.
9134 * alpha-linux-nat.c: Revert.
9135 * alpha-bsd-tdep.c: Revert.
9136 * alpha-bsd-nat.c: Revert.
9137 * aix-thread.c: Revert.
9138 * agent.c: Revert.
9139 * addrmap.c: Revert.
9140 * ada-varobj.c: Revert.
9141 * ada-valprint.c: Revert.
9142 * ada-typeprint.c: Revert.
9143 * ada-tasks.c: Revert.
9144 * ada-lang.c: Revert.
9145 * aarch64-tdep.c: Revert.
9146 * aarch64-ravenscar-thread.c: Revert.
9147 * aarch64-newlib-tdep.c: Revert.
9148 * aarch64-linux-tdep.c: Revert.
9149 * aarch64-linux-nat.c: Revert.
9150 * aarch64-fbsd-tdep.c: Revert.
9151 * aarch64-fbsd-nat.c: Revert.
9152 * aarch32-linux-nat.c: Revert.
9153
9154 2019-04-05 Tom Tromey <tom@tromey.com>
9155
9156 * ft32-tdep.c: Sort headers.
9157 * frv-tdep.c: Sort headers.
9158 * frv-linux-tdep.c: Sort headers.
9159 * frame.c: Sort headers.
9160 * frame-unwind.c: Sort headers.
9161 * frame-base.c: Sort headers.
9162 * fork-child.c: Sort headers.
9163 * findvar.c: Sort headers.
9164 * findcmd.c: Sort headers.
9165 * filesystem.c: Sort headers.
9166 * filename-seen-cache.h: Sort headers.
9167 * filename-seen-cache.c: Sort headers.
9168 * fbsd-tdep.c: Sort headers.
9169 * fbsd-nat.h: Sort headers.
9170 * fbsd-nat.c: Sort headers.
9171 * f-valprint.c: Sort headers.
9172 * f-typeprint.c: Sort headers.
9173 * f-lang.c: Sort headers.
9174 * extension.h: Sort headers.
9175 * extension.c: Sort headers.
9176 * extension-priv.h: Sort headers.
9177 * expprint.c: Sort headers.
9178 * exec.h: Sort headers.
9179 * exec.c: Sort headers.
9180 * exceptions.c: Sort headers.
9181 * event-top.c: Sort headers.
9182 * event-loop.c: Sort headers.
9183 * eval.c: Sort headers.
9184 * elfread.c: Sort headers.
9185 * dwarf2read.h: Sort headers.
9186 * dwarf2read.c: Sort headers.
9187 * dwarf2loc.c: Sort headers.
9188 * dwarf2expr.h: Sort headers.
9189 * dwarf2expr.c: Sort headers.
9190 * dwarf2-frame.c: Sort headers.
9191 * dwarf2-frame-tailcall.c: Sort headers.
9192 * dwarf-index-write.h: Sort headers.
9193 * dwarf-index-write.c: Sort headers.
9194 * dwarf-index-common.c: Sort headers.
9195 * dwarf-index-cache.h: Sort headers.
9196 * dwarf-index-cache.c: Sort headers.
9197 * dummy-frame.c: Sort headers.
9198 * dtrace-probe.c: Sort headers.
9199 * disasm.h: Sort headers.
9200 * disasm.c: Sort headers.
9201 * disasm-selftests.c: Sort headers.
9202 * dictionary.c: Sort headers.
9203 * dicos-tdep.c: Sort headers.
9204 * demangle.c: Sort headers.
9205 * dcache.h: Sort headers.
9206 * dcache.c: Sort headers.
9207 * darwin-nat.h: Sort headers.
9208 * darwin-nat.c: Sort headers.
9209 * darwin-nat-info.c: Sort headers.
9210 * d-valprint.c: Sort headers.
9211 * d-namespace.c: Sort headers.
9212 * d-lang.c: Sort headers.
9213 * ctf.c: Sort headers.
9214 * csky-tdep.c: Sort headers.
9215 * csky-linux-tdep.c: Sort headers.
9216 * cris-tdep.c: Sort headers.
9217 * cris-linux-tdep.c: Sort headers.
9218 * cp-valprint.c: Sort headers.
9219 * cp-support.c: Sort headers.
9220 * cp-namespace.c: Sort headers.
9221 * cp-abi.c: Sort headers.
9222 * corelow.c: Sort headers.
9223 * corefile.c: Sort headers.
9224 * continuations.c: Sort headers.
9225 * completer.h: Sort headers.
9226 * completer.c: Sort headers.
9227 * complaints.c: Sort headers.
9228 * coffread.c: Sort headers.
9229 * coff-pe-read.c: Sort headers.
9230 * cli-out.h: Sort headers.
9231 * cli-out.c: Sort headers.
9232 * charset.c: Sort headers.
9233 * c-varobj.c: Sort headers.
9234 * c-valprint.c: Sort headers.
9235 * c-typeprint.c: Sort headers.
9236 * c-lang.c: Sort headers.
9237 * buildsym.c: Sort headers.
9238 * buildsym-legacy.c: Sort headers.
9239 * build-id.h: Sort headers.
9240 * build-id.c: Sort headers.
9241 * btrace.c: Sort headers.
9242 * bsd-uthread.c: Sort headers.
9243 * breakpoint.h: Sort headers.
9244 * breakpoint.c: Sort headers.
9245 * break-catch-throw.c: Sort headers.
9246 * break-catch-syscall.c: Sort headers.
9247 * break-catch-sig.c: Sort headers.
9248 * blockframe.c: Sort headers.
9249 * block.c: Sort headers.
9250 * bfin-tdep.c: Sort headers.
9251 * bfin-linux-tdep.c: Sort headers.
9252 * bfd-target.c: Sort headers.
9253 * bcache.c: Sort headers.
9254 * ax-general.c: Sort headers.
9255 * ax-gdb.h: Sort headers.
9256 * ax-gdb.c: Sort headers.
9257 * avr-tdep.c: Sort headers.
9258 * auxv.c: Sort headers.
9259 * auto-load.c: Sort headers.
9260 * arm-wince-tdep.c: Sort headers.
9261 * arm-tdep.c: Sort headers.
9262 * arm-symbian-tdep.c: Sort headers.
9263 * arm-pikeos-tdep.c: Sort headers.
9264 * arm-obsd-tdep.c: Sort headers.
9265 * arm-nbsd-tdep.c: Sort headers.
9266 * arm-nbsd-nat.c: Sort headers.
9267 * arm-linux-tdep.c: Sort headers.
9268 * arm-linux-nat.c: Sort headers.
9269 * arm-fbsd-tdep.c: Sort headers.
9270 * arm-fbsd-nat.c: Sort headers.
9271 * arm-bsd-tdep.c: Sort headers.
9272 * arch-utils.c: Sort headers.
9273 * arc-tdep.c: Sort headers.
9274 * arc-newlib-tdep.c: Sort headers.
9275 * annotate.h: Sort headers.
9276 * annotate.c: Sort headers.
9277 * amd64-windows-tdep.c: Sort headers.
9278 * amd64-windows-nat.c: Sort headers.
9279 * amd64-tdep.c: Sort headers.
9280 * amd64-sol2-tdep.c: Sort headers.
9281 * amd64-obsd-tdep.c: Sort headers.
9282 * amd64-obsd-nat.c: Sort headers.
9283 * amd64-nbsd-tdep.c: Sort headers.
9284 * amd64-nbsd-nat.c: Sort headers.
9285 * amd64-nat.c: Sort headers.
9286 * amd64-linux-tdep.c: Sort headers.
9287 * amd64-linux-nat.c: Sort headers.
9288 * amd64-fbsd-tdep.c: Sort headers.
9289 * amd64-fbsd-nat.c: Sort headers.
9290 * amd64-dicos-tdep.c: Sort headers.
9291 * amd64-darwin-tdep.c: Sort headers.
9292 * amd64-bsd-nat.c: Sort headers.
9293 * alpha-tdep.c: Sort headers.
9294 * alpha-obsd-tdep.c: Sort headers.
9295 * alpha-nbsd-tdep.c: Sort headers.
9296 * alpha-mdebug-tdep.c: Sort headers.
9297 * alpha-linux-tdep.c: Sort headers.
9298 * alpha-linux-nat.c: Sort headers.
9299 * alpha-bsd-tdep.c: Sort headers.
9300 * alpha-bsd-nat.c: Sort headers.
9301 * aix-thread.c: Sort headers.
9302 * agent.c: Sort headers.
9303 * addrmap.c: Sort headers.
9304 * ada-varobj.c: Sort headers.
9305 * ada-valprint.c: Sort headers.
9306 * ada-typeprint.c: Sort headers.
9307 * ada-tasks.c: Sort headers.
9308 * ada-lang.c: Sort headers.
9309 * aarch64-tdep.c: Sort headers.
9310 * aarch64-ravenscar-thread.c: Sort headers.
9311 * aarch64-newlib-tdep.c: Sort headers.
9312 * aarch64-linux-tdep.c: Sort headers.
9313 * aarch64-linux-nat.c: Sort headers.
9314 * aarch64-fbsd-tdep.c: Sort headers.
9315 * aarch64-fbsd-nat.c: Sort headers.
9316 * aarch32-linux-nat.c: Sort headers.
9317
9318 2019-04-04 Tom Tromey <tom@tromey.com>
9319
9320 * varobj.c (varobj_create): Update.
9321 * rust-exp.y (struct rust_parser) <update_innermost_block,
9322 lookup_symbol>: New methods.
9323 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9324 Rename.
9325 (rust_parser::rust_lookup_type)
9326 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9327 * printcmd.c (display_command, do_one_display): Update.
9328 * parser-defs.h (struct parser_state) <parser_state>: Add
9329 "tracker" parameter.
9330 (block_tracker): New member.
9331 (class innermost_block_tracker) <innermost_block_tracker>: Add
9332 "types" parameter.
9333 <reset>: Remove method.
9334 (innermost_block): Don't declare.
9335 (null_post_parser): Update.
9336 * parse.c (innermost_block): Remove global.
9337 (write_dollar_variable): Update.
9338 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9339 Remove "tracker_types" parameter.
9340 (parse_expression): Add "tracker" parameter.
9341 (parse_expression_for_completion): Update.
9342 (null_post_parser): Add "tracker" parameter.
9343 * p-exp.y: Update rules.
9344 * m2-exp.y: Update rules.
9345 * language.h (struct language_defn) <la_post_parser>: Add
9346 "tracker" parameter.
9347 * go-exp.y: Update rules.
9348 * f-exp.y: Update rules.
9349 * expression.h (parse_expression, parse_exp_1): Add "tracker"
9350 parameter.
9351 * d-exp.y: Update rules.
9352 * c-exp.y: Update rules.
9353 * breakpoint.c (set_breakpoint_condition): Create an
9354 innermost_block_tracker.
9355 (watch_command_1): Likewise.
9356 * ada-lang.c (resolve): Add "tracker" parameter.
9357 (resolve_subexp): Likewise.
9358 * ada-exp.y (write_var_from_sym): Update.
9359
9360 2019-04-04 Tom Tromey <tom@tromey.com>
9361
9362 * type-stack.h: New file.
9363 * type-stack.c: New file.
9364 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9365 type-stack.h.
9366 (insert_into_type_stack, insert_type, push_type, push_type_int)
9367 (insert_type_address_space, pop_type, pop_type_int)
9368 (pop_typelist, pop_type_stack, append_type_stack)
9369 (push_type_stack, get_type_stack, push_typelist)
9370 (follow_type_instance_flags, follow_types): Don't declare.
9371 * parse.c (type_stack): Remove global.
9372 (parse_exp_in_context): Update.
9373 (insert_into_type_stack, insert_type, push_type, push_type_int)
9374 (insert_type_address_space, pop_type, pop_type_int)
9375 (pop_typelist, pop_type_stack, append_type_stack)
9376 (push_type_stack, get_type_stack, push_typelist)
9377 (follow_type_instance_flags, follow_types): Remove (moved to
9378 type-stack.c).
9379 * f-exp.y (type_stack): New global.
9380 Update rules.
9381 (push_kind_type, f_parse): Update.
9382 * d-exp.y (type_stack): New global.
9383 Update rules.
9384 (d_parse): Update.
9385 * c-exp.y (struct c_parse_state) <type_stack>: New member.
9386 Update rules.
9387 * Makefile.in (COMMON_SFILES): Add type-stack.c.
9388 (HFILES_NO_SRCDIR): Add type-stack.h.
9389
9390 2019-04-04 Tom Tromey <tom@tromey.com>
9391
9392 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9393 (rust_parser::convert_ast_to_expression, rust_parse)
9394 (rust_lex_test_completion, rust_lex_tests): Update.
9395 * parser-defs.h (struct expr_completion_state): New.
9396 (struct parser_state) <parser_state>: Add completion parameter.
9397 <mark_struct_expression, mark_completion_tag>: New methods.
9398 <parse_completion, m_completion_state>: New members.
9399 (prefixify_expression, null_post_parser): Update.
9400 (mark_struct_expression, mark_completion_tag): Don't declare.
9401 * parse.c (parse_completion, expout_last_struct)
9402 (expout_tag_completion_type, expout_completion_name): Remove
9403 globals.
9404 (parser_state::mark_struct_expression)
9405 (parser_state::mark_completion_tag): Now methods.
9406 (prefixify_expression): Add last_struct parameter.
9407 (prefixify_subexp): Likewise.
9408 (parse_exp_1): Update.
9409 (parse_exp_in_context): Add cstate parameter. Update.
9410 (parse_expression_for_completion): Create an
9411 expr_completion_state.
9412 (null_post_parser): Add "completion" parameter.
9413 * p-exp.y: Update rules.
9414 (yylex): Update.
9415 * language.h (struct language_defn) <la_post_parser>: Add
9416 "completing" parameter.
9417 * go-exp.y: Update rules.
9418 (lex_one_token): Update.
9419 * expression.h (parse_completion): Don't declare.
9420 * d-exp.y: Update rules.
9421 (lex_one_token): Update rules.
9422 * c-exp.y: Update rules.
9423 (lex_one_token): Update.
9424 * ada-lang.c (resolve): Add "parse_completion" parameter.
9425 (resolve_subexp): Likewise.
9426 (ada_resolve_function): Likewise.
9427
9428 2019-04-04 Tom Tromey <tom@tromey.com>
9429
9430 * parser-defs.h (struct parser_state) <start_arglist,
9431 end_arglist>: New methods.
9432 <arglist_len, m_funcall_chain>: New members.
9433 (arglist_len, start_arglist, end_arglist): Don't declare.
9434 * parse.c (arglist_len, funcall_chain): Remove global.
9435 (start_arglist, end_arglist): Remove functions.
9436 (parse_exp_in_context): Update.
9437 * p-exp.y: Update rules.
9438 * m2-exp.y: Update rules.
9439 * go-exp.y: Update rules.
9440 * f-exp.y: Update rules.
9441 * d-exp.y: Update rules.
9442 * c-exp.y: Update rules.
9443
9444 2019-04-04 Tom Tromey <tom@tromey.com>
9445
9446 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9447 lex_operator, push_back>: New methods.
9448 Update all rules.
9449 (rust_parser::lex_hex, lex_escape): Rename and update.
9450 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9451 (rust_parser::lex_operator): Rename and update.
9452 (rust_parser::lex_number, rustyylex, rustyyerror)
9453 (rust_lex_test_init, rust_lex_test_sequence)
9454 (rust_lex_test_push_back, rust_lex_tests): Update.
9455 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9456 parameter.
9457 <lexptr, prev_lexptr>: New members.
9458 (lexptr, prev_lexptr): Don't declare.
9459 * parse.c (lexptr, prev_lexptr): Remove globals.
9460 (parse_exp_in_context): Update.
9461 * p-exp.y (yylex, yyerror): Update.
9462 * m2-exp.y (parse_number, yylex, yyerror): Update.
9463 * go-exp.y (lex_one_token, yyerror): Update.
9464 * f-exp.y (match_string_literal, yylex, yyerror): Update.
9465 * d-exp.y (lex_one_token, yyerror): Update.
9466 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9467 (lex_one_token, yyerror): Update.
9468 * ada-lex.l (YY_INPUT): Update.
9469 (rewind_to_char): Update.
9470 * ada-exp.y (yyerror): Update.
9471
9472 2019-04-04 Tom Tromey <tom@tromey.com>
9473
9474 * rust-exp.y (rustyylex, rust_lex_tests): Update.
9475 * parser-defs.h (struct parser_state) <parser_state>: Add new
9476 parameter.
9477 <comma_terminates>: New member.
9478 (comma_terminates): Don't declare global.
9479 * parse.c (comma_terminates): Remove global.
9480 (parse_exp_in_context): Update.
9481 * p-exp.y (yylex): Update.
9482 * m2-exp.y (yylex): Update.
9483 * go-exp.y (lex_one_token): Update.
9484 * f-exp.y (yylex): Update.
9485 * d-exp.y (lex_one_token): Update.
9486 * c-exp.y (lex_one_token): Update.
9487 * ada-lex.l: Update.
9488
9489 2019-04-04 Tom Tromey <tom@tromey.com>
9490
9491 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9492 (rustyylex, rust_lex_test_init, rust_lex_test_one)
9493 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9494 * parser-defs.h (paren_depth): Don't declare.
9495 * parse.c (paren_depth): Remove global.
9496 (parse_exp_in_context): Update.
9497 * p-exp.y (paren_depth): New global.
9498 (pascal_parse): Initialize it.
9499 * m2-exp.y (paren_depth): New global.
9500 (m2_parse): Initialize it.
9501 * go-exp.y (paren_depth): New global.
9502 (go_parse): Initialize it.
9503 * f-exp.y (paren_depth): New global.
9504 (f_parse): Initialize it.
9505 * d-exp.y (paren_depth): New global.
9506 (d_parse): Initialize it.
9507 * c-exp.y (paren_depth): New global.
9508 (c_parse): Initialize it.
9509 * ada-lex.l (paren_depth): New global.
9510 (lexer_init): Initialize it.
9511
9512 2019-04-04 Tom Tromey <tom@tromey.com>
9513
9514 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9515 (rust_parser::convert_ast_to_type)
9516 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9517 * parser-defs.h (struct parser_state) <parser_state>: Add
9518 parameters. Initialize new members.
9519 <expression_context_block, expression_context_pc>: New members.
9520 * parse.c (expression_context_block, expression_context_pc):
9521 Remove globals.
9522 (parse_exp_in_context): Update.
9523 * p-exp.y: Update all rules.
9524 (yylex): Update.
9525 * m2-exp.y: Update all rules.
9526 (yylex): Update.
9527 * go-exp.y (yylex): Update.
9528 * f-exp.y (yylex): Update.
9529 * d-exp.y: Update all rules.
9530 (yylex): Update.
9531 * c-exp.y: Update all rules.
9532 (lex_one_token, classify_name, yylex, c_parse): Update.
9533 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9534
9535 2019-04-04 Tom Tromey <tom@tromey.com>
9536
9537 * gdbarch.h, gdbarch.c: Rebuild.
9538 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9539 * stap-probe.h:
9540 (struct stap_parse_info): Replace "parser_state" with
9541 "expr_builder".
9542 * parser-defs.h (struct expr_builder): Rename from "parser_state".
9543 (parser_state): New class.
9544 * parse.c (expr_builder): Rename.
9545 (expr_builder::release): Rename.
9546 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9547 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9548 (write_exp_elt_longcst, write_exp_elt_floatcst)
9549 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9550 (write_exp_string_vector, write_exp_bitstring)
9551 (write_exp_msymbol, mark_struct_expression)
9552 (write_dollar_variable)
9553 (insert_type_address_space, increase_expout_size): Replace
9554 "parser_state" with "expr_builder".
9555 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9556 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9557 "parser_state" with "expr_builder".
9558
9559 2019-04-04 Tom Tromey <tom@tromey.com>
9560
9561 * rust-exp.y: Replace "parse_language" with method call.
9562 * p-exp.y:
9563 (yylex): Replace "parse_language" with method call.
9564 * m2-exp.y:
9565 (yylex): Replace "parse_language" with method call.
9566 * go-exp.y (classify_name): Replace "parse_language" with method
9567 call.
9568 * f-exp.y (yylex): Replace "parse_language" with method call.
9569 * d-exp.y (lex_one_token): Replace "parse_language" with method
9570 call.
9571 * c-exp.y:
9572 (lex_one_token, classify_name, yylex): Replace "parse_language"
9573 with method call.
9574 * ada-exp.y (find_primitive_type, type_char)
9575 (type_system_address): Replace "parse_language" with method call.
9576
9577 2019-04-04 Tom Tromey <tom@tromey.com>
9578
9579 * rust-exp.y: Replace "parse_gdbarch" with method call.
9580 * parse.c (write_dollar_variable, insert_type_address_space):
9581 Replace "parse_gdbarch" with method call.
9582 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9583 call.
9584 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9585 call.
9586 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9587 "parse_gdbarch" with method call.
9588 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9589 with method call.
9590 * f-exp.y (parse_type, parse_f_type, yylex): Replace
9591 "parse_gdbarch" with method call.
9592 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9593 "parse_gdbarch" with method call.
9594 * c-exp.y (parse_type, parse_number, classify_name): Replace
9595 "parse_gdbarch" with method call.
9596 * ada-lex.l: Replace "parse_gdbarch" with method call.
9597 * ada-exp.y (parse_type, find_primitive_type, type_char)
9598 (type_system_address): Replace "parse_gdbarch" with method call.
9599
9600 2019-04-04 Tom Tromey <tom@tromey.com>
9601
9602 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9603 * stap-probe.c (stap_parse_argument): Update.
9604 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9605 initial_size parameter.
9606 * rust-exp.y (rust_lex_tests): Update.
9607 * parse.c (parser_state): Update.
9608 (parse_exp_in_context): Update.
9609 * parser-defs.h (struct parser_state) <parser_state>: Remove
9610 "initial_size" parameter.
9611
9612 2019-04-04 Tom Tromey <tom@tromey.com>
9613
9614 * parser-defs.h (increase_expout_size): Don't declare.
9615 * parse.c (increase_expout_size): Now static.
9616
9617 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
9618
9619 * gnu-nat.c (gnu_nat_target::wait): Fix
9620 target_waitstatus_to_string call.
9621
9622 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
9623
9624 * eval.c (evaluate_subexp_standard): Handle internal functions
9625 during Fortran function call handling.
9626
9627 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
9628
9629 * NEWS: Mention new internal functions.
9630 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9631 (read_base_type): Use dwarf2_init_complex_target_type.
9632 * value.c (creal_internal_fn): New function.
9633 (cimag_internal_fn): New function.
9634 (_initialize_values): Register new internal functions.
9635
9636 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9637
9638 * infrun.c (stop_all_threads): If debug_infrun, always
9639 trace the wait status after wait_one, using
9640 target_waitstatus_to_string and target_pid_to_str.
9641 (handle_inferior_event): Replace various trace of
9642 wait status kind by a single trace.
9643 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9644 wait status kind image by target_waitstatus_to_string.
9645 * target/waitstatus.c (target_waitstatus_to_string): Fix
9646 obsolete comment.
9647
9648 2019-04-01 Tom Tromey <tromey@adacore.com>
9649
9650 PR symtab/23331:
9651 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9652
9653 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
9654 Pedro Alves <palves@redhat.com>
9655
9656 * top.c (quit_force): Call 'finalize_values'.
9657 * value.c (finalize_values): New function.
9658 * value.h (finalize_values): Declare.
9659
9660 2019-03-30 Eli Zaretskii <eliz@gnu.org>
9661
9662 * NEWS: Announce $_gdb_major and $_gdb_minor.
9663
9664 * top.c (init_gdb_version_vars): New function.
9665 (gdb_init): Call init_gdb_version_vars.
9666
9667 2019-03-29 Tom Tromey <tromey@adacore.com>
9668
9669 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
9670 help text. Remove dead code.
9671
9672 2019-03-29 Keith Seitz <keiths@redhat.com>
9673
9674 From Siddhesh Poyarekar:
9675 * f-lang.h (f77_get_upperbound): Return LONGEST.
9676 (f77_get_lowerbound): Likewise.
9677 * f-typeprint.c (f_type_print_varspec_suffix): Expand
9678 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
9679 print them.
9680 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
9681 plongest to format print it.
9682 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9683 (f77_get_upperbound): Likewise.
9684 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9685 LOWER_BOUND to LONGEST.
9686 (f77_create_arrayprint_offset_tbl): Likewise.
9687
9688 2019-03-29 Keith Seitz <keiths@redhat.com>
9689
9690 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9691 %s/pulongest for TYPE_LENGTH instead of %d in format
9692 strings.
9693 * ada-typerint.c (ada_print_type): Likewise.
9694 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9695 * compile/compile-c-support.c (generate_register_struct): Likewise.
9696 * gdbtypes.c (recursive_dump_type): Likewise.
9697 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9698 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
9699 instead of %d in format strings.
9700 * riscv-tdep.c (riscv_type_alignment): Cast second argument
9701 to std::min to ULONGEST.
9702 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9703 instead of %d in format strings.
9704 * tracepoint.c (info_scope_command): Likewise.
9705 * typeprint.c (print_offset_data::update)
9706 (print_offset_data::finish): Likewise.
9707 * xtensa-tdep.c (xtensa_store_return_value)
9708 (xtensa_push_dummy_call): Likewise.
9709
9710 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
9711
9712 * windows-nat.c (display_selector): Fixed format specifications
9713 for 64-bit Cygwin.
9714
9715 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9716
9717 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9718
9719 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
9720
9721 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9722 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9723 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9724 (nios2_linux_init_abi): Install it.
9725
9726 2019-03-28 Alan Hayward <alan.hayward@arm.com>
9727
9728 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9729
9730 2019-03-28 Alan Hayward <alan.hayward@arm.com>
9731
9732 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9733
9734 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9735 Tom Tromey <tromey@adacore.com>
9736
9737 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9738
9739 2019-03-26 Joel Brobecker <brobecker@adacore.com>
9740
9741 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9742 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9743 method to compute the bounds of range types. Also print "[evaluated]"
9744 if the bounds' values come from a dynamic evaluation.
9745
9746 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
9747
9748 * cp-valprint.c (cp_print_value_fields): Don't print trailing
9749 whitespace when pretty printing is on.
9750
9751 2019-03-26 Alan Hayward <alan.hayward@arm.com>
9752
9753 * ppc-linux-nat.c: Add include.
9754
9755 2019-03-26 Alan Hayward <alan.hayward@arm.com>
9756
9757 * NEWS: Mention AArch64 Pointer Authentication.
9758
9759 2019-03-26 Alan Hayward <alan.hayward@arm.com>
9760
9761 * arm-linux-nat.c: Add include.
9762
9763 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
9764
9765 * source-cache.c (source_cache::get_source_lines): Re-read
9766 fullname after calling open_source_file.
9767
9768 2019-03-25 John Baldwin <jhb@FreeBSD.org>
9769
9770 * NEWS: Mention TLS support for FreeBSD.
9771
9772 2019-03-25 Tom Tromey <tromey@adacore.com>
9773
9774 * minsyms.c (BUNCH_SIZE): Update comment.
9775 (~minimal_symbol_reader): Remove old comment.
9776 (compact_minimal_symbols): Update comment.
9777 (minimal_symbol_reader::install): Remove old comment. Update
9778 other comments.
9779
9780 2019-03-25 Alan Hayward <alan.hayward@arm.com>
9781
9782 * s390-linux-nat.c: Add include.
9783
9784 2019-03-25 Alan Hayward <alan.hayward@arm.com>
9785
9786 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9787 Call linux_get_hwcap.
9788 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9789 Likewise.
9790 (aarch64_linux_get_hwcap): Remove function.
9791 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9792 declaration.
9793 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9794 linux_get_hwcap.
9795 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9796 * linux-tdep.c (linux_get_hwcap): Add function.
9797 (linux_get_hwcap2): Likewise.
9798 * linux-tdep.h (linux_get_hwcap): Add declaration.
9799 (linux_get_hwcap2): Likewise.
9800 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9801 (ppc_linux_get_hwcap2): Likewise.
9802 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9803 linux_get_hwcap.
9804 (ppc_linux_nat_target::insert_watchpoint): Likewise.
9805 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9806 (ppc_linux_nat_target::read_description): Likewise.
9807 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9808 * s390-linux-nat.c: Likewise.
9809 * s390-linux-tdep.c (s390_core_read_description): Likewise.
9810
9811 2019-03-24 Tom Tromey <tom@tromey.com>
9812
9813 * ada-lang.c (standard_lookup): Simplify initialization.
9814 (ada_lookup_symbol_nonlocal): Simplify return.
9815 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9816 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9817 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9818 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9819 initialization.
9820 * solib.c (solib_global_lookup): Simplify.
9821 * symtab.c (null_block_symbol): Remove.
9822 (symbol_cache_lookup): Simplify returns.
9823 (lookup_language_this): Simplify returns.
9824 (lookup_symbol_aux): Simplify return.
9825 (lookup_local_symbol): Simplify returns.
9826 (lookup_global_symbol_from_objfile): Simplify return.
9827 (lookup_symbol_in_objfile_symtabs)
9828 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9829 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9830 (lookup_static_symbol, lookup_global_symbol): Simplify return.
9831 * cp-namespace.c (cp_lookup_bare_symbol)
9832 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9833 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9834 (cp_lookup_nested_symbol): Don't use null_block_symbol.
9835 (cp_lookup_symbol_via_imports): Simplify initialization.
9836 (find_symbol_in_baseclass): Likewise.
9837 * symtab.h (null_block_symbol): Remove.
9838 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9839 (d_lookup_nested_symbol, d_lookup_symbol_imports)
9840 (d_lookup_symbol_module): Likewise.
9841 (find_symbol_in_baseclass): Simplify initialization.
9842
9843 2019-03-24 Tom Tromey <tom@tromey.com>
9844
9845 * expression.h: Don't include symtab.h.
9846 (struct block): Forward declare.
9847
9848 2019-03-24 Tom Tromey <tom@tromey.com>
9849
9850 * c-exp.y (typebase): Remove casts.
9851 * gdbtypes.c (lookup_unsigned_typename, )
9852 (lookup_signed_typename): Remove cast.
9853 * eval.c (parse_to_comma_and_eval): Remove cast.
9854 * parse.c (write_dollar_variable): Remove cast.
9855 * block.h (struct block) <superblock>: Now const.
9856 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9857 * psymtab.c (psym_map_matching_symbols): Make "block" const.
9858 (map_block): Make "block" const.
9859 * symfile.h (struct quick_symbol_functions)
9860 <map_matching_symbols>: Constify block argument to "callback".
9861 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9862 const.
9863 (find_pc_sect_compunit_symtab): Make "b" const.
9864 (find_symbol_at_address): Likewise.
9865 (search_symbols): Likewise.
9866 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9867 (dw2_debug_names_lookup_symbol): Likewise.
9868 (dw2_map_matching_symbols): Update.
9869 * p-valprint.c (pascal_val_print): Remove "block".
9870 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9871 (aux_add_nonlocal_symbols): Make "block" const.
9872 (resolve_subexp): Remove cast.
9873 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9874 const.
9875 (iterate_over_file_blocks): Likewise.
9876 * f-exp.y (%union) <bval>: Remove.
9877 * coffread.c (patch_opaque_types): Make "b" const.
9878 * spu-tdep.c (spu_catch_start): Make "block" const.
9879 * c-valprint.c (print_unpacked_pointer): Remove "block".
9880 * symmisc.c (dump_symtab_1): Make "b" const.
9881 (block_depth): Make "block" const.
9882 * d-exp.y (%union) <bval>: Remove.
9883 * cp-support.h (cp_lookup_rtti_type): Update.
9884 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9885 * psymtab.c (psym_lookup_symbol): Make "block" const.
9886 (maintenance_check_psymtabs): Make "b" const.
9887 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9888 (enumerate_locals, enumerate_args): Update.
9889 * python/py-symtab.c (stpy_global_block): Make "block" const.
9890 (stpy_static_block): Likewise.
9891 * inline-frame.c (block_starting_point_at): Make "new_block"
9892 const.
9893 * block.c (find_block_in_blockvector): Make return type const.
9894 (blockvector_for_pc_sect): Make "b" const.
9895 (find_block_in_blockvector): Make "b" const.
9896
9897 2019-03-23 Tom Tromey <tom@tromey.com>
9898
9899 * varobj.c (varobj_create): Update.
9900 * symfile.c (clear_symtab_users): Don't reset innermost_block.
9901 * printcmd.c (display_command, do_one_display): Don't reset
9902 innermost_block.
9903 * parser-defs.h (enum innermost_block_tracker_type): Move to
9904 expression.h.
9905 (innermost_block): Update comment.
9906 * parse.c (parse_exp_1): Add tracker_types parameter.
9907 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
9908 tracker_types parameter. Reset innermost_block.
9909 (parse_exp_in_context): Remove.
9910 (parse_expression_for_completion): Update.
9911 * objfiles.c (~objfile): Don't reset expression_context_block or
9912 innermost_block.
9913 * expression.h (enum innermost_block_tracker_type): Move from
9914 parser-defs.h.
9915 (parse_exp_1): Add tracker_types parameter.
9916 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9917 reset innermost_block.
9918
9919 2019-03-23 Tom Tromey <tom@tromey.com>
9920
9921 * objfiles.h: Include bcache.h.
9922
9923 2019-03-23 Tom Tromey <tom@tromey.com>
9924
9925 * linespec.c (get_current_search_block): Use
9926 scoped_restore_current_language.
9927 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9928
9929 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9930 Jiong Wang <jiong.wang@arm.com>
9931
9932 * aarch64-linux-tdep.c
9933 (aarch64_linux_iterate_over_regset_sections): Check for pauth
9934 section.
9935 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9936
9937 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9938 Jiong Wang <jiong.wang@arm.com>
9939
9940 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9941 instructions.
9942 (aarch64_analyze_prologue_test): Add PACIASP test.
9943 (aarch64_prologue_prev_register): Unmask PC value.
9944
9945 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9946 Jiong Wang <jiong.wang@arm.com>
9947
9948 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9949 (aarch64_dwarf2_prev_register): Unmask PC value.
9950 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9951 (aarch64_execute_dwarf_cfa_vendor_op): Check for
9952 DW_CFA_AARCH64_negate_ra_state.
9953 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9954
9955 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9956 Jiong Wang <jiong.wang@arm.com>
9957
9958 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9959 registers.
9960 (aarch64_pseudo_register_name): Likewise.
9961 (aarch64_pseudo_register_type): Likewise.
9962 (aarch64_pseudo_register_reggroup_p): Likewise.
9963 (aarch64_gdbarch_init): Add pauth registers.
9964 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9965 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9966 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9967 (struct gdbarch_tdep): Add regnum for ra_state.
9968
9969 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9970 Jiong Wang <jiong.wang@arm.com>
9971
9972 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9973
9974 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9975 Jiong Wang <jiong.wang@arm.com>
9976
9977 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9978 function.
9979 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9980 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9981 (aarch64_gdbarch_init): Add puth registers.
9982 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9983 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9984 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9985
9986 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9987 Jiong Wang <jiong.wang@arm.com>
9988
9989 * aarch64-linux-nat.c
9990 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9991 * aarch64-linux-tdep.c
9992 (aarch64_linux_core_read_description): Likewise.
9993 (aarch64_linux_get_hwcap): New function.
9994 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9995 (aarch64_linux_get_hwcap): New declaration.
9996
9997 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9998 Jiong Wang <jiong.wang@arm.com>
9999
10000 * aarch64-linux-nat.c
10001 (aarch64_linux_nat_target::read_description): Add pauth param.
10002 * aarch64-linux-tdep.c
10003 (aarch64_linux_core_read_description): Likewise.
10004 * aarch64-tdep.c (struct target_desc): Add in pauth.
10005 (aarch64_read_description): Add pauth param.
10006 (aarch64_gdbarch_init): Likewise.
10007 * aarch64-tdep.h (aarch64_read_description): Likewise.
10008 * arch/aarch64.c (aarch64_create_target_description): Likewise.
10009 * arch/aarch64.h (aarch64_create_target_description): Likewise.
10010 * features/Makefile: Add new files.
10011 * features/aarch64-pauth.c: New file.
10012 * features/aarch64-pauth.xml: New file.
10013
10014 2019-03-20 Tom Tromey <tromey@adacore.com>
10015
10016 * infrun.c (handle_inferior_event): Rename from
10017 handle_inferior_event_1. Create a scoped_value_mark.
10018 (handle_inferior_event): Remove.
10019
10020 2019-03-19 Tom Tromey <tromey@adacore.com>
10021
10022 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10023 * infrun.h (print_stop_event): Add "displays" parameter.
10024 * infrun.c (print_stop_event): Add "displays" parameter.
10025
10026 2019-03-19 Pedro Alves <palves@redhat.com>
10027
10028 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10029 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
10030 to -1. Fix TABs vs spaces.
10031 (tui_ui_out::tui_ui_out): Don't initialize fields here.
10032 * tui/tui-out.h (tui_ui_out) Add intro comments.
10033 <m_line, m_start_of_line>: In-class initialize, and add describing
10034 comment.
10035
10036 2019-03-18 Alan Hayward <alan.hayward@arm.com>
10037
10038 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10039 variable names.
10040 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10041
10042 2019-03-18 Pedro Alves <palves@redhat.com>
10043 Eli Zaretskii <eliz@gnu.org>
10044
10045 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10046 m_line and m_start_of_line.
10047
10048 2019-03-18 Eli Zaretskii <eliz@gnu.org>
10049
10050 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10051 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10052 it returns a newline. This fixes a regression in TU mode, whereby
10053 the next line is output on the same screen line as the user input.
10054
10055 2019-03-18 Tom Tromey <tromey@adacore.com>
10056
10057 * minsyms.c (minimal_symbol_reader::install): Remove call to
10058 obstack_blank.
10059
10060 2019-03-18 Pedro Alves <palves@redhat.com>
10061
10062 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10063 New globals.
10064 (apply_style): New, factored out from ...
10065 (apply_ansi_escape): ... this. Handle reverse video mode.
10066 (tui_set_reverse_mode): New function.
10067 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10068 * tui/tui-winsource.c (tui_show_source_line): Use
10069 tui_set_reverse_mode instead of setting A_STANDOUT.
10070 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10071 New setter methods.
10072
10073 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
10074
10075 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10076 Handle tabs.
10077
10078 2019-03-18 Tom Tromey <tromey@adacore.com>
10079
10080 * ada-lang.c (empty_array): Add "high" parameter.
10081 (ada_evaluate_subexp): Update.
10082
10083 2019-03-17 Sergei Trofimovich <siarheit@google.com>
10084
10085 * unittests/string_view-selftests.c: Define
10086 _initialize_string_view_selftests unconditionally.
10087
10088 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
10089
10090 PR gdb/24350
10091 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10092
10093 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
10094
10095 PR gdb/24351
10096 * windows-nat.c (display_selector): Fix format specifiers.
10097
10098 2019-03-17 Eli Zaretskii <eliz@gnu.org>
10099
10100 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10101 tui_refill_source_window instead of tui_refresh_win, to update the
10102 current execution line. This fixes redisplay of the current line
10103 when stepping through the code with "next" or "step".
10104
10105 2019-03-16 Eli Zaretskii <eliz@gnu.org>
10106
10107 * source-cache.c (source_cache::get_source_lines): Call
10108 find_source_lines to initialize s->nlines. This fixes vertical
10109 scrolling of TUI source window when the DOWN arrow is pressed.
10110
10111 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10112
10113 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10114 linux-thread-db.c (_initialize_thread_db): Likewise.
10115
10116 2019-03-16 Eli Zaretskii <eliz@gnu.org>
10117
10118 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10119 wclrtoeol in tui_show_source_line". This reverts changes made in
10120 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10121
10122 2019-03-15 Tom Tromey <tom@tromey.com>
10123
10124 * symtab.h (struct minimal_symbol): Derive from
10125 general_symbol_info.
10126 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10127 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10128 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10129 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10130 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10131 (MSYMBOL_SEARCH_NAME): Update.
10132 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10133 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10134 * minsyms.c (minimal_symbol_reader::record_full): Update.
10135
10136 2019-03-15 Tom Tromey <tom@tromey.com>
10137
10138 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10139
10140 2019-03-15 Tom Tromey <tom@tromey.com>
10141
10142 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10143 unique_xmalloc_ptr.
10144 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10145 Update.
10146 * minsyms.c (lookup_minimal_symbol_by_pc_section)
10147 (build_minimal_symbol_hash_tables)
10148 (minimal_symbol_reader::install): Update.
10149
10150 2019-03-15 Tom Tromey <tom@tromey.com>
10151
10152 * symtab.c (create_demangled_names_hash): Update.
10153 (symbol_set_names): Update.
10154 * objfiles.h (struct objfile_per_bfd_storage)
10155 <demangled_names_hash>: Now an htab_up.
10156 * objfiles.c (objfile_per_bfd_storage): Simplify.
10157
10158 2019-03-15 Tom Tromey <tom@tromey.com>
10159
10160 * objfiles.h (struct objfile_per_bfd_storage): Declare
10161 destructor.
10162 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10163 New.
10164 (get_objfile_bfd_data): Use new. Don't initialize
10165 language_of_main.
10166 (free_objfile_per_bfd_storage): Remove.
10167 (objfile_bfd_data_free, objfile::~objfile): Use delete.
10168
10169 2019-03-15 Tom Tromey <tom@tromey.com>
10170
10171 * symfile.c (reread_symbols): Update.
10172 * objfiles.c (objfile::objfile): Update.
10173 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10174 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10175 comment.
10176 (minimal_symbol_reader::install): Update.
10177 (terminate_minimal_symbol_table): Remove.
10178 * jit.c (jit_object_close_impl): Update.
10179
10180 2019-03-15 Tom Tromey <tom@tromey.com>
10181
10182 * minsyms.c (minimal_symbol_reader::record_full): Remove some
10183 initializations.
10184
10185 2019-03-15 Tom Tromey <tom@tromey.com>
10186
10187 * objfiles.h (struct objfile_per_bfd_storage)
10188 <demangled_hash_languages>: Now a bitset.
10189 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10190 (lookup_minimal_symbol): Update.
10191
10192 2019-03-15 Tom Tromey <tom@tromey.com>
10193
10194 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10195 Don't return the symbol.
10196 * coffread.c (record_minimal_symbol): Use record_full.
10197
10198 2019-03-14 Eli Zaretskii <eliz@gnu.org>
10199
10200 The MS-Windows port of ncurses fails to switch to a color pair if
10201 one or both of the colors are the implicit default colors. This
10202 change records the default colors when TUI is initialized, and
10203 then specifies them explicitly when a color pair uses the default
10204 colors. This allows color styling in TUI mode on MS-Windows.
10205
10206 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
10207 ncurses_norm_attr.
10208 (tui_initialize_io) [__MINGW32__]: Record the default terminal
10209 colors in ncurses_norm_attr.
10210 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10211 "none", replace it with the default color recorded in
10212 ncurses_norm_attr.
10213
10214 2019-03-14 Tom Tromey <tromey@adacore.com>
10215
10216 * source-cache.h (class source_cache) <get_source_lines>: Return
10217 std::string.
10218 * source-cache.c (source_cache::extract_lines): Handle case where
10219 first_pos==npos. Return std::string.
10220 (source_cache::get_source_lines): Update.
10221
10222 2019-03-14 Tom Tromey <tromey@adacore.com>
10223
10224 * NEWS: Add item for "style sources" commands.
10225 * source-cache.c (source_cache::get_source_lines): Check
10226 source_styling.
10227 * cli/cli-style.c (source_styling): New global.
10228 (_initialize_cli_style): Add "style sources" commands.
10229 (show_style_sources): New function.
10230 * cli/cli-style.h (source_styling): Declare.
10231
10232 2019-03-14 Pedro Alves <palves@redhat.com>
10233 Tom Tromey <tromey@adacore.com>
10234
10235 * tui/tui-winsource.h (tui_refill_source_window): Declare.
10236 * tui/tui-winsource.c (tui_refill_source_window): New function,
10237 from...
10238 (tui_horizontal_source_scroll): ... here. Move some logic.
10239 * cli/cli-style.c (set_style_enabled): Notify new observable.
10240 * tui/tui-hooks.c (tui_redisplay_source): New function.
10241 (tui_attach_detach_observers): Attach or detach
10242 tui_redisplay_source.
10243 * observable.h (source_styling_changed): New observable.
10244 * observable.c: Define source_styling_changed observable.
10245
10246 2019-03-13 Tom Tromey <tromey@adacore.com>
10247
10248 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10249 (i386_gnu_nat_target::store_registers): Update.
10250 * target-debug.h (target_debug_print_std_string): New macro.
10251 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10252 * windows-tdep.c (display_one_tib): Update.
10253 * tui/tui-stack.c (tui_make_status_line): Update.
10254 * top.c (print_inferior_quit_action): Update.
10255 * thread.c (thr_try_catch_cmd): Update.
10256 (add_thread_with_info): Update.
10257 (thread_target_id_str): Update.
10258 (thr_try_catch_cmd): Update.
10259 (thread_command): Update.
10260 (thread_find_command): Update.
10261 * record-btrace.c (record_btrace_target::info_record)
10262 (record_btrace_resume_thread, record_btrace_target::resume)
10263 (record_btrace_cancel_resume, record_btrace_step_thread)
10264 (record_btrace_target::wait, record_btrace_target::wait)
10265 (record_btrace_target::wait, record_btrace_target::stop): Update.
10266 * progspace.c (print_program_space): Update.
10267 * process-stratum-target.c
10268 (process_stratum_target::thread_address_space): Update.
10269 * linux-fork.c (linux_fork_mourn_inferior)
10270 (detach_checkpoint_command, info_checkpoints_command)
10271 (linux_fork_context): Update.
10272 (linux_fork_detach): Update.
10273 (class scoped_switch_fork_info): Update.
10274 (delete_checkpoint_command): Update.
10275 * infrun.c (follow_fork_inferior): Update.
10276 (follow_fork_inferior): Update.
10277 (proceed_after_vfork_done): Update.
10278 (handle_vfork_child_exec_or_exit): Update.
10279 (follow_exec): Update.
10280 (displaced_step_prepare_throw): Update.
10281 (displaced_step_restore): Update.
10282 (start_step_over): Update.
10283 (resume_1): Update.
10284 (clear_proceed_status_thread): Update.
10285 (proceed): Update.
10286 (print_target_wait_results): Update.
10287 (do_target_wait): Update.
10288 (context_switch): Update.
10289 (stop_all_threads): Update.
10290 (restart_threads): Update.
10291 (finish_step_over): Update.
10292 (handle_signal_stop): Update.
10293 (switch_back_to_stepped_thread): Update.
10294 (keep_going_pass_signal): Update.
10295 (print_exited_reason): Update.
10296 (normal_stop): Update.
10297 * inferior.c (inferior_pid_to_str): Change return type.
10298 (print_selected_inferior): Update.
10299 (add_inferior): Update.
10300 (detach_inferior): Update.
10301 * dummy-frame.c (fprint_dummy_frames): Update.
10302 * dcache.c (dcache_info_1): Update.
10303 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10304 (btrace_fetch, btrace_clear): Update.
10305 * linux-tdep.c (linux_core_pid_to_str): Change return type.
10306 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10307 type.
10308 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10309 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10310 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10311 * gdbarch.c, gdbarch.h: Rebuild.
10312 * gdbarch.sh (core_pid_to_str): Change return type.
10313 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10314 return type.
10315 (windows_nat_target::pid_to_str): Change return type.
10316 (windows_delete_thread): Update.
10317 (windows_nat_target::attach): Update.
10318 (windows_nat_target::files_info): Update.
10319 * target-delegates.c: Rebuild.
10320 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10321 return type.
10322 (sol_thread_target::pid_to_str): Change return type.
10323 * remote.c (class remote_target) <pid_to_str>: Change return
10324 type.
10325 (remote_target::pid_to_str): Change return type.
10326 (extended_remote_target::attach, remote_target::remote_stop_ns)
10327 (remote_target::remote_notif_remove_queued_reply)
10328 (remote_target::push_stop_reply, remote_target::disable_btrace):
10329 Update.
10330 (extended_remote_target::attach): Update.
10331 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10332 type.
10333 (gdbsim_target::pid_to_str): Change return type.
10334 * ravenscar-thread.c (struct ravenscar_thread_target)
10335 <pid_to_str>: Change return type.
10336 (ravenscar_thread_target::pid_to_str): Change return type.
10337 * procfs.c (class procfs_target) <pid_to_str>: Change return
10338 type.
10339 (procfs_target::pid_to_str): Change return type.
10340 (procfs_target::attach): Update.
10341 (procfs_target::detach): Update.
10342 (procfs_target::fetch_registers): Update.
10343 (procfs_target::store_registers): Update.
10344 (procfs_target::wait): Update.
10345 (procfs_target::files_info): Update.
10346 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10347 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10348 return type.
10349 (nto_procfs_target::pid_to_str): Change return type.
10350 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10351 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10352 return type.
10353 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10354 (exit_lwp): Update.
10355 (attach_proc_task_lwp_callback, get_detach_signal)
10356 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10357 (linux_nat_target::resume, wait_lwp, stop_callback)
10358 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10359 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10360 (linux_nat_wait_1, resume_stopped_resumed_lwps)
10361 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10362 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10363 type.
10364 (inf_ptrace_target::attach): Update.
10365 (inf_ptrace_target::files_info): Update.
10366 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10367 type.
10368 (go32_nat_target::pid_to_str): Change return type.
10369 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10370 (gnu_nat_target::wait): Update.
10371 (gnu_nat_target::wait): Update.
10372 (gnu_nat_target::resume): Update.
10373 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10374 (fbsd_nat_target::wait): Update.
10375 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10376 type.
10377 (darwin_nat_target::attach): Update.
10378 * corelow.c (class core_target) <pid_to_str>: Change return type.
10379 (core_target::pid_to_str): Change return type.
10380 * target.c (normal_pid_to_str): Change return type.
10381 (default_pid_to_str): Likewise.
10382 (target_pid_to_str): Change return type.
10383 (target_translate_tls_address): Update.
10384 (target_announce_detach): Update.
10385 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10386 return type.
10387 (bsd_uthread_target::pid_to_str): Change return type.
10388 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10389 type.
10390 (bsd_kvm_target::pid_to_str): Change return type.
10391 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10392 return type.
10393 (aix_thread_target::pid_to_str): Change return type.
10394 * target.h (struct target_ops) <pid_to_str>: Change return type.
10395 (target_pid_to_str, normal_pid_to_str): Likewise.
10396 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10397 type.
10398 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10399 type.
10400 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10401 return type.
10402 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10403 type.
10404 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10405 type.
10406 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10407 return type.
10408
10409 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
10410
10411 * NEWS: Mention that the new default MI version is 3. Mention
10412 changes to the output of commands and events that deal with
10413 multi-location breakpoints.
10414 * breakpoint.c: Include "mi/mi-out.h".
10415 (print_one_breakpoint): Change output syntax if using MI version
10416 >= 3.
10417 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10418 New.
10419 (mi_multi_location_breakpoint_output_fixed): New.
10420 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10421 (mi_cmd_fix_multi_location_breakpoint_output): New.
10422 (mi_multi_location_breakpoint_output_fixed): New.
10423 * mi/mi-cmds.c (mi_cmds): Register command
10424 -fix-multi-location-breakpoint-output.
10425 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10426 interpreter "mi".
10427
10428 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
10429
10430 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10431 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10432 instantiate mi_ui_out based on interpreter name.
10433 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10434 * mi/mi-main.c (mi_load_progress): Likewise.
10435
10436 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10437
10438 * NEWS: Combine separate "New targets" sections for 8.3.
10439
10440 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10441
10442 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10443 (ppcfbsd_init_abi): Install gdbarch
10444 "fetch_tls_load_module_address" and "get_thread_local_address"
10445 methods.
10446
10447 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10448
10449 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10450 (riscv_fbsd_init_abi): Install gdbarch
10451 "fetch_tls_load_module_address" and "get_thread_local_address"
10452 methods.
10453
10454 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10455
10456 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10457 (i386fbsd_init_abi): Install gdbarch
10458 "fetch_tls_load_module_address" and "get_thread_local_address"
10459 methods.
10460
10461 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10462
10463 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10464 (amd64fbsd_init_abi): Install gdbarch
10465 "fetch_tls_load_module_address" and "get_thread_local_address"
10466 methods.
10467
10468 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10469
10470 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10471 (struct fbsd_pspace_data): New type.
10472 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10473 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10474 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10475 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10476 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10477
10478 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10479
10480 * gdbtypes.c (lookup_struct_elt): New function.
10481 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10482 * gdbtypes.h (struct struct_elt): New type.
10483 (lookup_struct_elt): New prototype.
10484
10485 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10486
10487 * gdbtypes.c (lookup_struct_elt_type): Update comment and
10488 remove disabled code block.
10489
10490 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10491
10492 * gdbarch.sh (get_thread_local_address): New method.
10493 * gdbarch.h, gdbarch.c: Regenerate.
10494 * target.c (target_translate_tls_address): Use
10495 gdbarch_get_thread_local_address if present instead of
10496 target::get_thread_local_address.
10497
10498 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10499
10500 * target.h (target::get_thread_local_address): Update comment.
10501
10502 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10503
10504 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10505 objfile->separate_debug_objfile_backlink if not NULL.
10506
10507 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10508
10509 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10510 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10511 (amd64bsd_store_inferior_registers): Likewise.
10512 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10513 Enable segment base registers.
10514 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10515 PT_GETFSBASE and PT_GETGSBASE.
10516 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10517 PT_SETGSBASE.
10518 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10519 segment base registers.
10520 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10521
10522 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10523
10524 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10525 Update calls to i386_target_description to add 'segments'
10526 parameter.
10527 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
10528 add segment base registers.
10529 * arch/i386.c (i386_create_target_description): Add 'segments'
10530 parameter to enable segment base registers.
10531 * arch/i386.h (i386_create_target_description): Likewise.
10532 * features/i386/32bit-segments.xml: New file.
10533 * features/i386/32bit-segments.c: Generate.
10534 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10535 call to i386_target_description to add 'segments' parameter.
10536 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10537 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10538 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10539 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10540 if feature is present.
10541 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10542 Add 'segments' parameter to call to i386_target_description.
10543 (i386_target_description): Add 'segments' parameter to enable
10544 segment base registers.
10545 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10546 to call to i386_target_description.
10547 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10548 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10549 Define I386_NUM_REGS.
10550 (i386_target_description): Add 'segments' parameter to enable
10551 segment base registers.
10552
10553 2019-03-12 Eli Zaretskii <eliz@gnu.org>
10554
10555 PR/24325
10556 * source-cache.c: #undef open and close, to avoid unresolved
10557 externals during linking.
10558
10559 2019-03-12 Tom Tromey <tromey@adacore.com>
10560
10561 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10562 const. Add initializers.
10563 (_initialize_remote): Don't initialize ptid globals.
10564
10565 2019-03-12 Pedro Alves <palves@redhat.com>
10566
10567 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10568
10569 2019-03-12 Pedro Alves <palves@redhat.com>
10570
10571 * cp-name-parser.y (main): Remove unused 'len' variable.
10572
10573 2019-03-12 Tom Tromey <tromey@adacore.com>
10574
10575 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10576 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10577
10578 2019-03-12 Tom Tromey <tromey@adacore.com>
10579
10580 * linux-nat.c (iterate_over_lwps): Update.
10581 (stop_callback): Remove parameter.
10582 (stop_wait_callback, detach_callback, resume_set_callback)
10583 (select_singlestep_lwp_callback, set_ignore_sigint)
10584 (status_callback, resumed_callback, resume_clear_callback)
10585 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10586 data parameter.
10587 (linux_nat_target::detach, linux_nat_target::resume)
10588 (linux_stop_and_wait_all_lwps, select_event_lwp)
10589 (linux_nat_filter_event, linux_nat_wait_1)
10590 (linux_nat_target::kill, linux_nat_target::stop)
10591 (linux_nat_target::stop): Update.
10592 (linux_nat_resume_callback): Change type.
10593 (resume_stopped_resumed_lwps, count_events_callback)
10594 (select_event_lwp_callback): Likewise.
10595 (linux_stop_lwp, linux_nat_stop_lwp): Update.
10596 * arm-linux-nat.c (struct update_registers_data): Remove.
10597 (update_registers_callback): Change type.
10598 (arm_linux_insert_hw_breakpoint1): Update.
10599 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10600 parameter.
10601 (x86_linux_dr_set_addr): Update.
10602 (x86_linux_dr_set_control): Update.
10603 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10604 (iterate_over_lwps): Use gdb::function_view.
10605 * nat/aarch64-linux-hw-point.c (struct
10606 aarch64_dr_update_callback_param): Remove.
10607 (debug_reg_change_callback): Change type.
10608 (aarch64_notify_debug_reg_change): Update.
10609 * s390-linux-nat.c (s390_refresh_per_info): Update.
10610
10611 2019-03-11 Tom Tromey <tromey@adacore.com>
10612
10613 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10614 redundant assignment to "this_cu".
10615
10616 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10617
10618 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10619
10620 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10621
10622 * gdbtypes.c (rank_one_type_parm_set): New function extracted
10623 from...
10624 (rank_one_type): ... this.
10625
10626 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10627
10628 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10629 from...
10630 (rank_one_type): ... this.
10631
10632 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10633
10634 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10635 from...
10636 (rank_one_type): ... this.
10637
10638 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10639
10640 * gdbtypes.c (rank_one_type_parm_float): New function extracted
10641 from...
10642 (rank_one_type): ... this.
10643
10644 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10645
10646 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10647 from...
10648 (rank_one_type): ... this.
10649
10650 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10651
10652 * gdbtypes.c (rank_one_type_parm_range): New function extracted
10653 from...
10654 (rank_one_type): ... this.
10655
10656 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10657
10658 * gdbtypes.c (rank_one_type_parm_char): New function extracted
10659 from...
10660 (rank_one_type): ... this.
10661
10662 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10663
10664 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10665 from...
10666 (rank_one_type): ... this.
10667
10668 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10669
10670 * gdbtypes.c (rank_one_type_parm_int): New function extracted
10671 from...
10672 (rank_one_type): ... this.
10673
10674 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10675
10676 * gdbtypes.c (rank_one_type_parm_func): New function extracted
10677 from...
10678 (rank_one_type): ... this.
10679
10680 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10681
10682 * gdbtypes.c (rank_one_type_parm_array): New function extracted
10683 from...
10684 (rank_one_type): ... this.
10685
10686 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10687
10688 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10689 from...
10690 (rank_one_type): ... this.
10691
10692 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10693
10694 * inferior.c (initialize_inferiors): Ensure 'help set/show print
10695 inferior-events' shows the example events.
10696
10697 2019-03-08 Eli Zaretskii <eliz@gnu.org>
10698
10699 Support styling on native MS-Windows console
10700
10701 PR/24315
10702 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10703 on MS-Windows if $TERM is not defined.
10704
10705 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10706
10707 * posix-hdep.c (gdb_console_fputs):
10708 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10709 functions.
10710 * ui-file.h (gdb_console_fputs): Add prototype.
10711
10712 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10713 back to fputs only if the former returns zero.
10714
10715 2019-03-07 Tom Tromey <tom@tromey.com>
10716
10717 * symmisc.c (print_symbol_bcache_statistics): Update.
10718 (print_objfile_statistics): Update.
10719 * symfile.c (allocate_symtab): Update.
10720 * stabsread.c: Don't include bcache.h.
10721 * psymtab.h (struct psymbol_bcache): Don't declare.
10722 (class psymtab_storage) <psymbol_cache>: Now a bcache.
10723 (psymbol_bcache_init, psymbol_bcache_free)
10724 (psymbol_bcache_get_bcache): Don't declare.
10725 * psymtab.c (struct psymbol_bcache): Remove.
10726 (psymtab_storage::psymtab_storage): Update.
10727 (psymtab_storage::~psymtab_storage): Update.
10728 (psymbol_bcache_init, psymbol_bcache_free)
10729 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10730 (add_psymbol_to_bcache): Update.
10731 (allocate_psymtab): Update.
10732 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10733 macro_cache>: No longer pointers.
10734 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10735 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10736 * macrotab.c (macro_bcache): Update.
10737 * macroexp.c: Don't include bcache.h.
10738 * gdbtypes.c (check_types_worklist): Update.
10739 (types_deeply_equal): Remove TRY/CATCH. Update.
10740 * elfread.c (elf_symtab_read): Update.
10741 * dwarf2read.c: Don't include bcache.h.
10742 * buildsym.c (buildsym_compunit::get_macro_table): Update.
10743 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10744 (print_bcache_statistics, bcache_memory_used): Don't declare.
10745 (struct bcache): Move from bcache.c. Add constructor, destructor,
10746 methods. Rename all data members.
10747 * bcache.c (struct bcache): Move to bcache.h.
10748 (bcache::expand_hash_table): Rename from expand_hash_table.
10749 (bcache): Remove.
10750 (bcache::insert): Rename from bcache_full.
10751 (bcache::compare): Rename from bcache_compare.
10752 (bcache_xmalloc): Remove.
10753 (bcache::~bcache): Rename from bcache_xfree.
10754 (bcache::print_statistics): Rename from print_bcache_statistics.
10755 (bcache::memory_used): Rename from bcache_memory_used.
10756
10757 2019-03-07 Pedro Alves <palves@redhat.com>
10758
10759 * infrun.c (normal_stop): Also check for
10760 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10761
10762 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
10763
10764 * f-lang.c (value_from_host_double): Moved to...
10765 * value.c (value_from_host_double): ...here.
10766 * value.h (value_from_host_double): Declare.
10767 * guile/scm-math.c (vlscm_convert_typed_number): Use
10768 value_from_host_double.
10769 (vlscm_convert_number): Likewise.
10770 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10771 * python/py-value.c (convert_value_from_python): Likewise.
10772
10773 2019-03-06 Tom Tromey <tom@tromey.com>
10774
10775 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10776
10777 2019-03-06 Tom Tromey <tom@tromey.com>
10778
10779 * utils.h (free_current_contents): Don't declare.
10780 * utils.c (free_current_contents): Remove.
10781
10782 2019-03-06 Tom Tromey <tom@tromey.com>
10783
10784 * top.c (quit_force): Update.
10785 * main.c (captured_command_loop): Update.
10786 * common/new-op.c (operator new): Update.
10787 * common/common-exceptions.c (struct catcher)
10788 <save_cleanup_chain>: Remove member.
10789 (exceptions_state_mc_init): Update.
10790 (exception_try_scope_entry): Return nullptr.
10791 (exception_try_scope_exit, exception_rethrow)
10792 (throw_exception_sjlj, throw_exception_cxx): Update.
10793 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10794 (all_cleanups, do_cleanups, discard_cleanups)
10795 (discard_final_cleanups, save_cleanups, save_final_cleanups)
10796 (restore_cleanups, restore_final_cleanups): Don't declare.
10797 (do_final_cleanups): Remove parameter.
10798 * common/cleanups.c (cleanup_chain, make_cleanup)
10799 (make_cleanup_dtor, all_cleanups, do_cleanups)
10800 (discard_my_cleanups, discard_cleanups)
10801 (discard_final_cleanups, save_my_cleanups, save_cleanups)
10802 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10803 (null_cleanup): Remove.
10804 (do_final_cleanups): Remove parameter.
10805
10806 2019-03-06 Tom Tromey <tom@tromey.com>
10807
10808 * remote.c (remote_target::remote_parse_stop_reply): Use
10809 unique_xmalloc_ptr.
10810
10811 2019-03-06 Tom Tromey <tom@tromey.com>
10812
10813 * stabsread.c (struct stabs_field_info): Rename from field_info.
10814 <list, fnlist>: Add initializers.
10815 <obstack>: New member.
10816 (read_member_functions, read_struct_fields, read_baseclasses):
10817 Allocate on obstack. Don't use cleanups.
10818 (read_one_struct_field, read_member_functions, read_struct_fields)
10819 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10820 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10821 (read_struct_type): Update.
10822
10823 2019-03-06 Tom Tromey <tom@tromey.com>
10824
10825 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10826 * common/filestuff.h (make_cleanup_close): Don't declare.
10827 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10828 Remove.
10829
10830 2019-03-06 Tom Tromey <tom@tromey.com>
10831
10832 * solib-aix.c: Use make_scope_exit.
10833
10834 2019-03-06 Tom Tromey <tom@tromey.com>
10835
10836 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10837 Use make_scope_exit.
10838
10839 2019-03-06 Tom Tromey <tom@tromey.com>
10840
10841 * solib-svr4.c (disable_probes_interface): Remove parameter.
10842 (svr4_handle_solib_event): Use make_scope_exit.
10843
10844 2019-03-06 Tom Tromey <tom@tromey.com>
10845
10846 * remote.c (struct stop_reply_deleter): Remove.
10847 (stop_reply_up): Update.
10848 (struct stop_reply): Derive from notif_event. Don't typedef.
10849 <regcache>: Now a std::vector.
10850 (stop_reply_xfree): Remove.
10851 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10852 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
10853 (remote_target::discard_pending_stop_replies): Use delete.
10854 (remote_target::remote_parse_stop_reply): Update.
10855 (remote_target::process_stop_reply): Update.
10856 * remote-notif.h (struct notif_event): Add virtual destructor.
10857 Remove "dtr" member.
10858 (struct notif_client) <alloc_event>: Return a unique_ptr.
10859 (notif_event_xfree): Don't declare.
10860 (notif_event_up): New typedef.
10861 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10862 (notif_event_xfree, do_notif_event_xfree): Remove.
10863 (remote_notif_state_xfree): Update.
10864
10865 2019-03-06 Tom Tromey <tom@tromey.com>
10866
10867 * infrun.c (displaced_step_clear_cleanup): Now a
10868 forward_scope_exit type.
10869 (displaced_step_prepare_throw): Update.
10870 (displaced_step_fixup): Update.
10871
10872 2019-03-06 Tom Tromey <tom@tromey.com>
10873
10874 * inferior.h (class inferior): Update comment.
10875 * gdbthread.h (class thread_info): Update comment.
10876
10877 2019-03-06 Joel Brobecker <brobecker@adacore.com>
10878 Tom Tromey <tom@tromey.com>
10879
10880 * stabsread.h (struct stab_section_list): Remove.
10881 (coffstab_build_psymtabs): Update.
10882 * dbxread.c (symbuf_sections): Now a std::vector.
10883 (sect_idx): New global.
10884 (fill_symbuf): Update.
10885 (coffstab_build_psymtabs): Change type of stabsects parameter.
10886 Update.
10887 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10888 std::vector.
10889 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10890 (coff_locate_sections): Update.
10891 (coff_symfile_read): Remove cleanups. Update.
10892 (init_stringtab): Add storage parameter.
10893 (free_stringtab, free_stringtab_cleanup): Remove.
10894 (init_lineno): Add storage parameter.
10895 (free_linetab, free_linetab_cleanup): Remove.
10896
10897 2019-03-06 Pedro Alves <palves@redhat.com>
10898
10899 * linux-fork.c (fork_info::clobber_regs): Delete.
10900 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10901 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
10902 comment. Adjust.
10903 (scoped_switch_fork_info::scoped_switch_fork_info)
10904 (checkpoint_command, linux_fork_context): Adjust
10905 fork_save_infrun_state calls.
10906
10907 2019-03-06 Pedro Alves <palves@redhat.com>
10908
10909 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10910 (inf_has_multiple_threads): Return 'bool' and rewrite using
10911 inferior_info::threads().
10912
10913 2019-03-06 Pedro Alves <palves@redhat.com>
10914
10915 * linux-fork.c: Include <list>.
10916 (fork_list): Now a std::list instance.
10917 (fork_info): Add ctor, dtor, and in-class initialize all fields.
10918 (forks_exist_p, find_last_fork): Adjust.
10919 (new_fork): Delete.
10920 (one_fork_p): New.
10921 (add_fork): Adjust.
10922 (free_fork): Delete, folded into fork_info::~fork_info().
10923 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10924 Adjust.
10925 (init_fork_list): Delete.
10926 (linux_fork_killall, linux_fork_mourn_inferior)
10927 (linux_fork_detach, info_checkpoints_command): Adjust.
10928 (_initialize_linux_fork): No longer call init_fork_list.
10929
10930 2019-03-06 Pedro Alves <palves@redhat.com>
10931
10932 * linux-fork.c (new_fork): New, split out of ...
10933 (add_fork): ... this. Return void. Move "first fork" special
10934 case from here, to ...
10935 (checkpoint_command): ... here.
10936 * linux-linux.h (add_fork): Return void.
10937
10938 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10939
10940 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10941
10942 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10943 Chris January <chris.january@arm.com>
10944 David Lecomber <david.lecomber@arm.com>
10945
10946 * f-exp.y: New token, UNOP_INTRINSIC.
10947 (exp): New pattern using UNOP_INTRINSIC token.
10948 (f77_keywords): Add 'abs' keyword.
10949 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10950 (value_from_host_double): New function.
10951 (evaluate_subexp_f): Support UNOP_ABS.
10952
10953 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10954
10955 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10956 types.
10957
10958 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10959
10960 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10961 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10962 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10963
10964 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10965
10966 * f-exp.y (convert_to_kind_type): Handle more type kinds.
10967
10968 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10969 Chris January <chris.january@arm.com>
10970
10971 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10972 * f-exp.y: Define 'KIND' token.
10973 (exp): New pattern for KIND expressions.
10974 (ptype): Handle types with a kind extension.
10975 (direct_abs_decl): Extend to spot kind extensions.
10976 (f77_keywords): Add 'kind' to the list.
10977 (push_kind_type): New function.
10978 (convert_to_kind_type): New function.
10979 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10980 * parse.c (operator_length_standard): Likewise.
10981 * parser-defs.h (enum type_pieces): Add tp_kind.
10982 * std-operator.def: Add UNOP_KIND.
10983
10984 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10985
10986 * f-exp.y (f_parse): Set yydebug.
10987
10988 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10989
10990 * f-lang.c (evaluate_subexp_f): New function.
10991 (exp_descriptor_f): New global.
10992 (f_language_defn): Use exp_descriptor_f instead of
10993 exp_descriptor_standard.
10994
10995 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10996
10997 * f-exp.y (struct token): Add comments.
10998 (dot_ops): Remove uppercase versions and the end marker.
10999 (f77_keywords): Likewise.
11000 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11001 entries in the dot_ops array are case insensitive, and use
11002 strncasecmp to compare strings. Also some whitespace cleanup in
11003 this area. Similar for the f77_keywords array, except entries in
11004 this list might be case sensitive.
11005
11006 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11007
11008 * f-exp.y (struct f77_boolean_val): Add comments.
11009 (boolean_values): Remove uppercase versions, and end marker.
11010 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11011 and use strncasecmp to achieve case insensitivity. Additionally,
11012 perform whitespace cleanup around this code.
11013
11014 2019-03-06 Tom Tromey <tromey@adacore.com>
11015
11016 * remote-sim.c (gdbsim_target_open): Use result of
11017 gdb_argv::release.
11018
11019 2019-03-06 Richard Bunt <richard.bunt@arm.com>
11020 Dirk Schubert <dirk.schubert@arm.com>
11021 Chris January <chris.january@arm.com>
11022
11023 * eval.c (evaluate_subexp_standard): Call Fortran argument
11024 wrapping logic.
11025 * f-lang.c (struct value): A value which can be passed into a
11026 Fortran function call.
11027 (fortran_argument_convert): Wrap Fortran arguments in a pointer
11028 where appropriate.
11029 (struct type): Value ready for a Fortran function call.
11030 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11031 is needed.
11032 * f-lang.h (fortran_argument_convert): Declaration.
11033 (fortran_preserve_arg_pointer): Declaration.
11034 * infcall.c (value_arg_coerce): Call Fortran argument logic.
11035
11036 2019-03-05 Tom Tromey <tromey@adacore.com>
11037
11038 * python/py-prettyprint.c (print_string_repr): Remove #if.
11039 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11040
11041 2019-03-05 Tom Tromey <tromey@adacore.com>
11042
11043 * target.c (the_dummy_target): Move later. Change type to
11044 "dummy_target".
11045 (initialize_targets): Don't initialize the_dummy_target.
11046
11047 2019-03-05 Tom Tromey <tromey@adacore.com>
11048
11049 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11050 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11051
11052 2019-03-05 Tom Tromey <tromey@adacore.com>
11053
11054 * windows-nat.c (windows_nat_target::attach)
11055 (windows_nat_target::detach): Don't call gdb_flush.
11056 * valprint.c (generic_val_print, val_print, val_print_string):
11057 Don't call gdb_flush.
11058 * utils.c (defaulted_query): Don't call gdb_flush.
11059 * typeprint.c (print_type_scalar): Don't call gdb_flush.
11060 * target.c (target_announce_detach): Don't call gdb_flush.
11061 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11062 * remote.c (extended_remote_target::attach): Don't call
11063 gdb_flush.
11064 * procfs.c (procfs_target::detach): Don't call gdb_flush.
11065 * printcmd.c (do_examine): Don't call gdb_flush.
11066 (info_display_command): Don't call gdb_flush.
11067 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11068 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11069 * memattr.c (info_mem_command): Don't call gdb_flush.
11070 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11071 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11072 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11073 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11074 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11075 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11076 (gnu_nat_target::detach): Don't call gdb_flush.
11077 * f-valprint.c (f_val_print): Don't call gdb_flush.
11078 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11079 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11080 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11081 gdb_flush.
11082 * c-valprint.c (c_val_print): Don't call gdb_flush.
11083 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11084
11085 2019-03-05 Tom Tromey <tromey@adacore.com>
11086
11087 * varobj.c (update_dynamic_varobj_children): Update.
11088 (install_default_visualizer): Use reset, not release.
11089 * value.c (set_internalvar): Update.
11090 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11091 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11092 ATTRIBUTE_UNUSED_RESULT.
11093
11094 2019-03-05 Tom Tromey <tromey@adacore.com>
11095
11096 * remote.c (class scoped_remote_fd) <release>: Add
11097 ATTRIBUTE_UNUSED_RESULT.
11098
11099 2019-03-05 Tom Tromey <tromey@adacore.com>
11100
11101 * macroexp.c (struct macro_buffer) <release>: Add
11102 ATTRIBUTE_UNUSED_RESULT.
11103
11104 2019-03-05 Tom Tromey <tromey@adacore.com>
11105
11106 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11107 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11108 ATTRIBUTE_UNUSED_RESULT.
11109
11110 2019-03-05 Tom Tromey <tromey@adacore.com>
11111
11112 * common/scoped_fd.h (class scoped_fd) <release>: Add
11113 ATTRIBUTE_UNUSED_RESULT.
11114
11115 2019-03-05 Tom Tromey <tromey@adacore.com>
11116
11117 * parser-defs.h (struct parser_state) <release>: Add
11118 ATTRIBUTE_UNUSED_RESULT.
11119
11120 2019-03-05 Tom Tromey <tromey@adacore.com>
11121
11122 * utils.h (class gdb_argv) <release>: Add
11123 ATTRIBUTE_UNUSED_RESULT.
11124 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11125
11126 2019-03-02 Eli Zaretskii <eliz@gnu.org>
11127
11128 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11129 for-loop range, to avoid compiler warnings.
11130
11131 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11132 avoid compiler warnings about unused variables.
11133
11134 * NEWS: Mention end of support for native debugging on MS-Windows
11135 before XP.
11136
11137 PR gdb/24292
11138 * common/netstuff.c:
11139 * gdbserver/gdbreplay.c
11140 * gdbserver/remote-utils.c:
11141 * ser-tcp.c:
11142 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11143 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
11144 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11145 'getaddrinfo' and 'freeaddrinfo' were not available before
11146 Windows XP, and mingw.org's MinGW headers by default define
11147 _WIN32_WINNT to 0x500.
11148
11149 2019-03-01 Gary Benson <gbenson@redhat.com>
11150
11151 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11152
11153 2019-02-28 Brian Vandenberg <phantall@gmail.com>
11154 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
11155
11156 PR gdb/8527
11157 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11158 set_sigint_trap, clear_sigint_trap.
11159
11160 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11161
11162 * target.c (target_detach): Clear the regcache and the
11163 frame cache.
11164
11165 2019-02-27 Pedro Alves <palves@redhat.com>
11166
11167 * utils.c (set_screen_size): When we cap the height/width sizes,
11168 tweak the corresponding command variable to show "unlimited":
11169
11170 2019-02-27 Saagar Jha <saagar@saagarjha.com>
11171 Pedro Alves <palves@redhat.com>
11172
11173 * utils.c (set_screen_size): Reduce "infinite" rows and columns
11174 before calling rl_set_screen_size.
11175
11176 2019-02-27 Tom Tromey <tromey@adacore.com>
11177
11178 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11179 define.
11180 * python/py-value.c: Remove Python 2.4 workaround.
11181 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11182 workaround.
11183 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11184 Python 2.4 workaround.
11185 * python/python-internal.h: Remove Python 2.4 comment.
11186 (Py_ssize_t): Don't define.
11187 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11188 (gdb_Py_DECREF): Remove Python 2.4 workaround.
11189 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11190 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11191 * python/python.c (do_start_initialization): Remove Python 2.4
11192 workaround.
11193 * python/py-prettyprint.c (class dummy_python_frame): Remove.
11194 (print_children): Remove Python 2.4 workaround.
11195 * python/py-inferior.c (buffer_procs): Remove Python 2.4
11196 workaround.
11197 (CHARBUFFERPROC_NAME): Remove.
11198 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11199 Python 2.4 workaround.
11200
11201 2019-02-27 Kevin Buettner <kevinb@redhat.com>
11202
11203 * NEWS: Note minimum Python version.
11204
11205 2019-02-27 Kevin Buettner <kevinb@redhat.com>
11206
11207 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11208 code from these functions. Remove corresponding ifdefs. Use
11209 Py_buffer_up instead of explicit calls to PyBuffer_Release.
11210 Remove gotos and target of gotos.
11211 (infpy_search_memory): Likewise.
11212
11213 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11214
11215 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11216 (hppa_gdbarch_init): Don't register deleted functions with
11217 gdbarch.
11218
11219 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11220
11221 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11222 (h8300_unwind_sp): Delete.
11223 (h8300_dummy_id): Delete.
11224 (h8300_gdbarch_init): Don't register deleted functions with
11225 gdbarch.
11226
11227 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11228
11229 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11230 (ft32_unwind_pc): Delete.
11231 (ft32_unwind_sp): Delete.
11232 (ft32_gdbarch_init): Don't register deleted functions with
11233 gdbarch.
11234
11235 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11236
11237 * gdb/frv-tdep.c (frv_dummy_id): Delete.
11238 (frv_unwind_pc): Delete.
11239 (frv_unwind_sp): Delete.
11240 (frv_gdbarch_init): Don't register deleted functions with
11241 gdbarch.
11242
11243 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11244
11245 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11246 (riscv_unwind_pc): Delete.
11247 (riscv_unwind_sp): Delete.
11248 (riscv_gdbarch_init): Don't register deleted functions with
11249 gdbarch.
11250
11251 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11252
11253 * gdb/csky-tdep.c (csky_dummy_id): Delete.
11254 (csky_unwind_pc): Delete.
11255 (csky_unwind_sp): Delete.
11256 (csky_gdbarch_init): Don't register deleted functions with
11257 gdbarch.
11258
11259 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11260
11261 * gdb/cris-tdep.c (cris_dummy_id): Delete.
11262 (cris_unwind_pc): Delete.
11263 (cris_unwind_sp): Delete.
11264 (cris_gdbarch_init): Don't register deleted functions with
11265 gdbarch.
11266
11267 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11268
11269 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11270 (bfin_unwind_pc): Delete.
11271 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11272
11273 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11274
11275 * gdb/arm-tdep.c (arm_dummy_id): Delete.
11276 (arm_unwind_pc): Delete.
11277 (arm_unwind_sp): Delete.
11278 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11279
11280 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11281
11282 * gdb/arc-tdep.c (arc_dummy_id): Delete.
11283 (arc_unwind_pc): Delete.
11284 (arc_unwind_sp): Delete.
11285 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11286
11287 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11288
11289 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11290 (alpha_unwind_pc): Delete.
11291 (alpha_gdbarch_init): Don't register deleted functions with
11292 gdbarch.
11293
11294 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11295
11296 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11297 (aarch64_unwind_pc): Delete.
11298 (aarch64_unwind_sp): Delete.
11299 (aarch64_gdbarch_init): Don't register deleted functions with
11300 gdbarch.
11301
11302 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11303
11304 * gdbtypes.c (type_align): Don't consider static members when
11305 computing structure alignment.
11306
11307 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11308
11309 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11310 return 0 for other types.
11311 * arch-utils.c (default_type_align): Always return 0.
11312 * gdbarch.h: Regenerate.
11313 * gdbarch.sh (type_align): Extend comment.
11314 * gdbtypes.c (type_align): Add additional comments, always call
11315 gdbarch_type_align before applying the default rules.
11316 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11317 generic code will then apply a suitable default.
11318 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11319 types, return 0 for other types.
11320
11321 2019-02-27 Joel Brobecker <brobecker@adacore.com>
11322
11323 * NEWS: Create a new section for the next release branch.
11324 Rename the section of the current branch, now that it has
11325 been cut.
11326
11327 2019-02-27 Joel Brobecker <brobecker@adacore.com>
11328
11329 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11330 * version.in: Bump version to 8.3.50.DATE-git.
11331
11332 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
11333
11334 * aix-thread.c (ptid_cmp): Remove unused variable.
11335 (get_signaled_thread): Likewise.
11336 (store_regs_user_thread): Likewise.
11337 (store_regs_kernel_thread): Likewise.
11338 (fetch_regs_kernel_thread): Remove shadowed variable.
11339
11340 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
11341
11342 * features/riscv/32bit-cpu.xml: Add register numbers.
11343 * features/riscv/32bit-fpu.c: Regenerate.
11344 * features/riscv/32bit-fpu.xml: Add register numbers.
11345 * features/riscv/64bit-cpu.xml: Add register numbers.
11346 * features/riscv/64bit-fpu.c: Regenerate.
11347 * features/riscv/64bit-fpu.xml: Add register numbers.
11348
11349 2019-02-26 Kevin Buettner <kevinb@redhat.com>
11350
11351 * NEWS: Mention two argument form of gdb.Value constructor.
11352 * python/py-value.c (convert_buffer_and_type_to_value): New
11353 function.
11354 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11355 Add support for handling an optional second argument. Call
11356 convert_buffer_and_type_to_value as appropriate.
11357 * python/python-internal.h (Py_buffer_deleter): New struct.
11358 (Py_buffer_up): New typedef.
11359
11360 2019-02-25 John Baldwin <jhb@FreeBSD.org>
11361
11362 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11363 instead of releasing ownership.
11364
11365 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
11366
11367 * dwarf2read.c (open_and_init_dwp_file): Call
11368 elf_numsections instead of bfd_count_sections to initialize
11369 dwp_file->num_sections.
11370
11371 2019-02-25 Tom Tromey <tromey@adacore.com>
11372
11373 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11374
11375 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
11376
11377 * gcore.in: Add '--readnever' option when invoking GDB.
11378
11379 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
11380
11381 * MAINTAINERS: Update my email address.
11382
11383 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
11384
11385 * build-id.c (build_id_to_debug_bfd_1): New function.
11386 (build_id_to_debug_bfd): Look for separate debug file in
11387 sysroot.
11388
11389 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
11390
11391 * gdbarch.sh: Update the copyright year range that is placed into
11392 generated files.
11393
11394 2019-02-22 Keith Seitz <keiths@redhat.com>
11395
11396 PR symtab/23853
11397 * linespec.c (create_sals_line_offset): Search for the default
11398 symtab's filename instead of its fullname.
11399
11400 2019-02-21 Alan Hayward <alan.hayward@arm.com>
11401
11402 * NEWS: Update style defaults.
11403
11404 2019-02-21 Alan Hayward <alan.hayward@arm.com>
11405
11406 * main.c (captured_main_1): Disable styling in batch mode.
11407
11408 2019-02-20 Tom Tromey <tom@tromey.com>
11409
11410 * symtab.c (symtab_symbol_info): Fix typos.
11411
11412 2019-02-20 Tom Tromey <tromey@adacore.com>
11413
11414 * findcmd.c (_initialize_mem_search): Use upper case for
11415 metasyntactic variables.
11416
11417 2019-02-20 Alan Hayward <alan.hayward@arm.com>
11418
11419 * aarch64-tdep.c (aarch64_add_reggroups): New function.
11420 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11421
11422 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
11423
11424 * top.h (source_file_name): Change to std::string.
11425 * top.c (source_file_name): Likewise.
11426 (command_line_input): Adjust.
11427 * cli/cli-script.c (script_from_file): Adjust.
11428
11429 2019-02-19 Tom Tromey <tromey@adacore.com>
11430
11431 * ravenscar-thread.c
11432 (ravenscar_thread_target::update_thread_list): Don't call
11433 ada_build_task_list.
11434 * ada-lang.h (ada_build_task_list): Don't declare.
11435 * ada-tasks.c (struct ada_tasks_inferior_data)
11436 <task_list_valid_p>: Now bool.
11437 (read_known_tasks, ada_task_list_changed)
11438 (ada_tasks_invalidate_inferior_data): Update.
11439 (read_known_tasks_array): Return bool.
11440 (read_known_tasks_list): Likewise.
11441 (read_known_tasks): Return void.
11442 (ada_build_task_list): Now static.
11443
11444 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
11445
11446 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11447 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11448
11449 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11450
11451 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11452 variant for ada_tasks_pspace_data_handle and
11453 ada_tasks_inferior_data_handle.
11454 (ada_tasks_pspace_data_cleanup): New function.
11455 (ada_tasks_inferior_data_cleanup): New function.
11456
11457 2019-02-17 Tom Tromey <tom@tromey.com>
11458
11459 * macrotab.h (macro_source_fullname): Return a std::string.
11460 * macrotab.c (macro_include, check_for_redefinition)
11461 (macro_undef, macro_lookup_definition, foreach_macro)
11462 (foreach_macro_in_scope): Update.
11463 (macro_source_fullname): Return a std::string.
11464 * macrocmd.c (show_pp_source_pos): Update.
11465
11466 2019-02-17 Tom Tromey <tom@tromey.com>
11467
11468 * macrocmd.c (show_pp_source_pos): Style the file names.
11469
11470 2019-02-17 Tom Tromey <tom@tromey.com>
11471
11472 PR tui/24197:
11473 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11474
11475 2019-02-17 Tom Tromey <tom@tromey.com>
11476
11477 * ada-lang.c (user_select_syms): Use filtered printing.
11478 * utils.c (wrap_style): New global.
11479 (desired_style): Remove.
11480 (emit_style_escape): Add stream parameter.
11481 (set_output_style, reset_terminal_style, prompt_for_continue):
11482 Update.
11483 (flush_wrap_buffer): Only flush gdb_stdout.
11484 (wrap_here): Set wrap_style.
11485 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
11486 treat escape sequences as a character. Change when wrap buffer is
11487 flushed.
11488 (fputs_styled): Do not set the output style when the default is
11489 requested.
11490 * ui-style.h (struct ui_file_style) <is_default>: New method.
11491 * source.c (print_source_lines_base): Emit escape sequences in one
11492 piece.
11493
11494 2019-02-17 Joel Brobecker <brobecker@adacore.com>
11495
11496 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11497 integers and enumeration types.
11498
11499 2019-02-17 Joel Brobecker <brobecker@adacore.com>
11500
11501 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11502 instead of lookup_symbol_in_language
11503 (do_exact_match): New function.
11504 (ada_get_symbol_name_matcher): Return do_exact_match when
11505 doing a verbatim match.
11506
11507 2019-02-15 Tom Tromey <tromey@adacore.com>
11508
11509 * ravenscar-thread.c (ravenscar_thread_target::resume)
11510 (ravenscar_thread_target::wait): Special case wildcard requests.
11511
11512 2019-02-15 Tom Tromey <tromey@adacore.com>
11513
11514 * ravenscar-thread.c (base_ptid): Remove.
11515 (struct ravenscar_thread_target) <close>: New method.
11516 <m_base_ptid>: New member.
11517 <update_inferior_ptid, active_task, task_is_currently_active,
11518 runtime_initialized>: Declare methods.
11519 <ravenscar_thread_target>: Add constructor.
11520 (ravenscar_thread_target::task_is_currently_active)
11521 (ravenscar_thread_target::update_inferior_ptid)
11522 (ravenscar_runtime_initialized): Rename. Now methods.
11523 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11524 (ravenscar_thread_target::update_thread_list): Update.
11525 (ravenscar_thread_target::active_task): Now method.
11526 (ravenscar_thread_target::store_registers)
11527 (ravenscar_thread_target::prepare_to_store)
11528 (ravenscar_thread_target::prepare_to_store)
11529 (ravenscar_thread_target::mourn_inferior): Update.
11530 (ravenscar_inferior_created): Use "new" to create target.
11531 (ravenscar_thread_target::get_ada_task_ptid): Update.
11532 (_initialize_ravenscar): Don't initialize base_ptid.
11533 (ravenscar_ops): Remove global.
11534
11535 2019-02-15 Tom Tromey <tromey@adacore.com>
11536
11537 * target.h (push_target): Declare new overload.
11538 * target.c (push_target): New overload, taking an rvalue reference.
11539 * remote.c (remote_target::open_1): Use push_target overload.
11540 * corelow.c (core_target_open): Use push_target overload.
11541
11542 2019-02-15 Tom Tromey <tromey@adacore.com>
11543
11544 * ravenscar-thread.c (is_ravenscar_task)
11545 (ravenscar_task_is_currently_active): Return bool.
11546 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11547 (_initialize_ravenscar): Remove "(void)".
11548 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11549 Return bool.
11550
11551 2019-02-15 Tom Tromey <tromey@adacore.com>
11552
11553 * ravenscar-thread.c (ravenscar_runtime_initializer)
11554 (has_ravenscar_runtime, get_running_thread_id)
11555 (ravenscar_thread_target::resume): Fix indentation.
11556
11557 2019-02-15 Tom Tromey <tromey@adacore.com>
11558
11559 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11560 from ravenscar_arch_ops.
11561 (sparc_ravenscar_ops::fetch_registers)
11562 (sparc_ravenscar_ops::store_registers): Now methods.
11563 (sparc_ravenscar_prepare_to_store): Remove.
11564 (sparc_ravenscar_ops): Redefine.
11565 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11566 methods and destructor. Remove members.
11567 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11568 (ravenscar_thread_target::store_registers)
11569 (ravenscar_thread_target::prepare_to_store): Update.
11570 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11571 Remove.
11572 (struct ppc_ravenscar_powerpc_ops): Derive from
11573 ravenscar_arch_ops.
11574 (ppc_ravenscar_powerpc_ops::fetch_registers)
11575 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11576 (ppc_ravenscar_powerpc_ops): Redefine.
11577 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11578 (ppc_ravenscar_e500_ops::fetch_registers)
11579 (ppc_ravenscar_e500_ops::store_registers): Now methods.
11580 (ppc_ravenscar_e500_ops): Redefine.
11581 * aarch64-ravenscar-thread.c
11582 (aarch64_ravenscar_generic_prepare_to_store): Remove.
11583 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11584 (aarch64_ravenscar_fetch_registers)
11585 (aarch64_ravenscar_store_registers): Now methods.
11586 (aarch64_ravenscar_ops): Redefine.
11587
11588 2019-02-15 Tom Tromey <tromey@adacore.com>
11589
11590 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11591 (ravenscar_thread_target::stopped_by_hw_breakpoint)
11592 (ravenscar_thread_target::stopped_by_watchpoint)
11593 (ravenscar_thread_target::stopped_data_address)
11594 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11595
11596 2019-02-15 Tom Tromey <tromey@adacore.com>
11597
11598 * ravenscar-thread.c: Fix some typos.
11599
11600 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11601 Tom Tromey <tromey@adacore.com>
11602
11603 * ada-lang.c (ada_exception_sal): Change addr_string to a
11604 std::string.
11605 (create_ada_exception_catchpoint): Update.
11606
11607 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11608 Tom Tromey <tromey@adacore.com>
11609
11610 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11611 (bp_location_ops): Remove.
11612 (base_breakpoint_allocate_location): Update.
11613 (free_bp_location): Update.
11614 * ada-lang.c (class ada_catchpoint_location)
11615 <ada_catchpoint_location>: Remove ops parameter.
11616 (ada_catchpoint_location_dtor): Remove.
11617 (ada_catchpoint_location_ops): Remove.
11618 (allocate_location_exception): Update.
11619 * breakpoint.h (struct bp_location_ops): Remove.
11620 (class bp_location) <bp_location>: Remove bp_location_ops
11621 parameter.
11622 <~bp_location>: Add destructor.
11623 <ops>: Remove.
11624
11625 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
11626 Pedro Alves <palves@redhat.com>
11627
11628 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11629 'PATH_MAX'.
11630
11631 2019-02-14 David Michael <fedora.dm0@gmail.com>
11632 Samuel Thibault <samuel.thibault@gnu.org>
11633 Thomas Schwinge <thomas@codesourcery.com>
11634
11635 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11636 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11637
11638 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
11639
11640 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11641 (check_empty): Use "const char *".
11642
11643 * gnu-nat.c (gnu_nat_target::detach): Instead of
11644 'detach_inferior (pid)' call
11645 'detach_inferior (find_inferior_pid (pid))'.
11646
11647 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11648 'nat/fork-inferior.o'.
11649 * gnu-nat.c: #include "nat/fork-inferior.h".
11650
11651 * gnu-nat.c (gnu_nat_target::detach): Instead of
11652 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11653 * gnu-nat.h: #include "inf-child.h".
11654 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11655 'i386_gnu_nat_target::fetch_registers'.
11656 (gnu_store_registers): Rename/move to
11657 'i386_gnu_nat_target::store_registers'.
11658
11659 * config/i386/nm-i386gnu.h: Don't "#include" any files.
11660 * gnu-nat.h (mach_thread_info): New function.
11661 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11662
11663 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11664
11665 2019-02-14 Frederic Konrad <konrad@adacore.com>
11666
11667 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11668
11669 2019-02-14 Joel Brobecker <brobecker@adacore.com>
11670
11671 * windows-nat.c (windows_add_thread): Add new parameter
11672 "main_thread_p" with default value set to false. Update
11673 function documentation as well as all callers.
11674 (windows_delete_thread): Likewise.
11675 (fake_create_process): Update call to windows_add_thread.
11676 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11677 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11678 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11679 call to windows_delete_thread.
11680
11681 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
11682
11683 * MAINTAINERS: Add Andrew Burgess as global maintainer.
11684
11685 2019-02-12 John Baldwin <jhb@FreeBSD.org>
11686
11687 * symfile.c (find_separate_debug_file): Use canonical path of
11688 sysroot with child_path instead of gdb_sysroot if it is valid.
11689
11690 2019-02-12 John Baldwin <jhb@FreeBSD.org>
11691
11692 * symfile.c (find_separate_debug_file): Use child_path to
11693 determine if an object file is under a sysroot.
11694
11695 2019-02-12 John Baldwin <jhb@FreeBSD.org>
11696
11697 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11698 unittests/child-path-selftests.c.
11699 * common/pathstuff.c (child_path): New function.
11700 * common/pathstuff.h (child_path): New prototype.
11701 * unittests/child-path-selftests.c: New file.
11702
11703 2019-02-12 John Baldwin <jhb@FreeBSD.org>
11704
11705 * symfile.c (find_separate_debug_file): Look for separate debug
11706 files in debug directories under the sysroot.
11707
11708 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11709
11710 * symtab.h (struct minimal_symbol data_p): New const method.
11711 (struct minimal_symbol text_p): Likewise.
11712 * symtab.c (output_source_filename): Use file name style
11713 to print file name.
11714 (print_symbol_info): Likewise.
11715 (print_msymbol_info): Use address style to print addresses.
11716 Use function name style to print executable text symbols.
11717 (expand_symtab_containing_pc): Use data_p.
11718 (find_pc_sect_compunit_symtab): Likewise.
11719
11720 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11721
11722 * breakpoint.c (describe_other_breakpoints): Use address style
11723 to print addresses.
11724 (say_where): Likewise.
11725
11726 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11727
11728 * ada-typeprint.c (print_func_type): Print function name
11729 style to print function name.
11730 * c-typeprint.c (c_print_type_1): Likewise.
11731
11732 2019-02-11 Alan Hayward <alan.hayward@arm.com>
11733
11734 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11735 for execve.
11736
11737 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11738
11739 * c-exp.y (direct_abs_decl): Use emplace_back to record the
11740 type_stack.
11741
11742 2019-02-10 Joel Brobecker <brobecker@adacore.com>
11743
11744 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11745 TYPE_CODE_REF types.
11746
11747 2019-02-08 Jim Wilson <jimw@sifive.com>
11748
11749 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11750 (riscv_linux_fregset): New.
11751 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11752
11753 2019-02-07 Tom Tromey <tom@tromey.com>
11754
11755 * thread.c (thread_cancel_execution_command): Update.
11756 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11757 methods.
11758 (struct thread_fsm_ops): Remove.
11759 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11760 (thread_fsm_should_stop, thread_fsm_return_value)
11761 (thread_fsm_set_finished, thread_fsm_finished_p)
11762 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11763 Don't declare.
11764 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11765 * infrun.c (clear_proceed_status_thread)
11766 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11767 (print_stop_event): Update.
11768 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11769 Add constructor.
11770 (step_command_fsm_ops): Remove.
11771 (new_step_command_fsm): Remove.
11772 (step_1): Update.
11773 (step_command_fsm::should_stop): Rename from
11774 step_command_fsm_should_stop.
11775 (step_command_fsm::clean_up): Rename from
11776 step_command_fsm_clean_up.
11777 (step_command_fsm::do_async_reply_reason): Rename from
11778 step_command_fsm_async_reply_reason.
11779 (struct until_next_fsm): Inherit from thread_fsm. Add
11780 constructor.
11781 (until_next_fsm_ops): Remove.
11782 (new_until_next_fsm): Remove.
11783 (until_next_fsm::should_stop): Rename from
11784 until_next_fsm_should_stop.
11785 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11786 (until_next_fsm::do_async_reply_reason): Rename from
11787 until_next_fsm_async_reply_reason.
11788 (struct finish_command_fsm): Inherit from thread_fsm. Add
11789 constructor. Change type of breakpoint.
11790 (finish_command_fsm_ops): Remove.
11791 (new_finish_command_fsm): Remove.
11792 (finish_command_fsm::should_stop): Rename from
11793 finish_command_fsm_should_stop.
11794 (finish_command_fsm::clean_up): Rename from
11795 finish_command_fsm_clean_up.
11796 (finish_command_fsm::return_value): Rename from
11797 finish_command_fsm_return_value.
11798 (finish_command_fsm::do_async_reply_reason): Rename from
11799 finish_command_fsm_async_reply_reason.
11800 (finish_command): Update.
11801 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11802 Add constructor.
11803 (call_thread_fsm_ops): Remove.
11804 (call_thread_fsm::call_thread_fsm): Rename from
11805 new_call_thread_fsm.
11806 (call_thread_fsm::should_stop): Rename from
11807 call_thread_fsm_should_stop.
11808 (call_thread_fsm::should_notify_stop): Rename from
11809 call_thread_fsm_should_notify_stop.
11810 (run_inferior_call, call_function_by_hand_dummy): Update.
11811 * cli/cli-interp.c (should_print_stop_to_console): Update.
11812 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11813 Add constructor. Change type of location_breakpoint,
11814 caller_breakpoint.
11815 (until_break_fsm_ops): Remove.
11816 (new_until_break_fsm): Remove.
11817 (until_break_fsm::should_stop): Rename from
11818 until_break_fsm_should_stop.
11819 (until_break_fsm::clean_up): Rename from
11820 until_break_fsm_clean_up.
11821 (until_break_fsm::do_async_reply_reason): Rename from
11822 until_break_fsm_async_reply_reason.
11823 (until_break_command): Update.
11824 * thread-fsm.c: Remove.
11825 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11826
11827 2019-02-07 Tom Tromey <tom@tromey.com>
11828
11829 * yy-remap.h: Add include guard.
11830 * xtensa-tdep.h: Add include guard.
11831 * xcoffread.h: Rename include guard.
11832 * varobj-iter.h: Add include guard.
11833 * tui/tui.h: Rename include guard.
11834 * tui/tui-winsource.h: Rename include guard.
11835 * tui/tui-wingeneral.h: Rename include guard.
11836 * tui/tui-windata.h: Rename include guard.
11837 * tui/tui-win.h: Rename include guard.
11838 * tui/tui-stack.h: Rename include guard.
11839 * tui/tui-source.h: Rename include guard.
11840 * tui/tui-regs.h: Rename include guard.
11841 * tui/tui-out.h: Rename include guard.
11842 * tui/tui-layout.h: Rename include guard.
11843 * tui/tui-io.h: Rename include guard.
11844 * tui/tui-hooks.h: Rename include guard.
11845 * tui/tui-file.h: Rename include guard.
11846 * tui/tui-disasm.h: Rename include guard.
11847 * tui/tui-data.h: Rename include guard.
11848 * tui/tui-command.h: Rename include guard.
11849 * tic6x-tdep.h: Add include guard.
11850 * target/waitstatus.h: Rename include guard.
11851 * target/wait.h: Rename include guard.
11852 * target/target.h: Rename include guard.
11853 * target/resume.h: Rename include guard.
11854 * target-float.h: Rename include guard.
11855 * stabsread.h: Add include guard.
11856 * rs6000-tdep.h: Add include guard.
11857 * riscv-fbsd-tdep.h: Add include guard.
11858 * regformats/regdef.h: Rename include guard.
11859 * record.h: Rename include guard.
11860 * python/python.h: Rename include guard.
11861 * python/python-internal.h: Rename include guard.
11862 * python/py-stopevent.h: Rename include guard.
11863 * python/py-ref.h: Rename include guard.
11864 * python/py-record.h: Rename include guard.
11865 * python/py-record-full.h: Rename include guard.
11866 * python/py-record-btrace.h: Rename include guard.
11867 * python/py-instruction.h: Rename include guard.
11868 * python/py-events.h: Rename include guard.
11869 * python/py-event.h: Rename include guard.
11870 * procfs.h: Add include guard.
11871 * proc-utils.h: Add include guard.
11872 * p-lang.h: Add include guard.
11873 * or1k-tdep.h: Rename include guard.
11874 * observable.h: Rename include guard.
11875 * nto-tdep.h: Rename include guard.
11876 * nat/x86-linux.h: Rename include guard.
11877 * nat/x86-linux-dregs.h: Rename include guard.
11878 * nat/x86-gcc-cpuid.h: Add include guard.
11879 * nat/x86-dregs.h: Rename include guard.
11880 * nat/x86-cpuid.h: Rename include guard.
11881 * nat/ppc-linux.h: Rename include guard.
11882 * nat/mips-linux-watch.h: Rename include guard.
11883 * nat/linux-waitpid.h: Rename include guard.
11884 * nat/linux-ptrace.h: Rename include guard.
11885 * nat/linux-procfs.h: Rename include guard.
11886 * nat/linux-osdata.h: Rename include guard.
11887 * nat/linux-nat.h: Rename include guard.
11888 * nat/linux-namespaces.h: Rename include guard.
11889 * nat/linux-btrace.h: Rename include guard.
11890 * nat/glibc_thread_db.h: Rename include guard.
11891 * nat/gdb_thread_db.h: Rename include guard.
11892 * nat/gdb_ptrace.h: Rename include guard.
11893 * nat/fork-inferior.h: Rename include guard.
11894 * nat/amd64-linux-siginfo.h: Rename include guard.
11895 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11896 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11897 * nat/aarch64-linux.h: Rename include guard.
11898 * nat/aarch64-linux-hw-point.h: Rename include guard.
11899 * mn10300-tdep.h: Add include guard.
11900 * mips-linux-tdep.h: Add include guard.
11901 * mi/mi-parse.h: Rename include guard.
11902 * mi/mi-out.h: Rename include guard.
11903 * mi/mi-main.h: Rename include guard.
11904 * mi/mi-interp.h: Rename include guard.
11905 * mi/mi-getopt.h: Rename include guard.
11906 * mi/mi-console.h: Rename include guard.
11907 * mi/mi-common.h: Rename include guard.
11908 * mi/mi-cmds.h: Rename include guard.
11909 * mi/mi-cmd-break.h: Rename include guard.
11910 * m2-lang.h: Add include guard.
11911 * location.h: Rename include guard.
11912 * linux-record.h: Rename include guard.
11913 * linux-nat.h: Add include guard.
11914 * linux-fork.h: Add include guard.
11915 * i386-darwin-tdep.h: Rename include guard.
11916 * hppa-linux-offsets.h: Add include guard.
11917 * guile/guile.h: Rename include guard.
11918 * guile/guile-internal.h: Rename include guard.
11919 * gnu-nat.h: Rename include guard.
11920 * gdb-stabs.h: Rename include guard.
11921 * frv-tdep.h: Add include guard.
11922 * f-lang.h: Add include guard.
11923 * event-loop.h: Add include guard.
11924 * darwin-nat.h: Rename include guard.
11925 * cp-abi.h: Rename include guard.
11926 * config/sparc/nm-sol2.h: Rename include guard.
11927 * config/nm-nto.h: Rename include guard.
11928 * config/nm-linux.h: Add include guard.
11929 * config/i386/nm-i386gnu.h: Rename include guard.
11930 * config/djgpp/nl_types.h: Rename include guard.
11931 * config/djgpp/langinfo.h: Rename include guard.
11932 * compile/gcc-cp-plugin.h: Add include guard.
11933 * compile/gcc-c-plugin.h: Add include guard.
11934 * compile/compile.h: Rename include guard.
11935 * compile/compile-object-run.h: Rename include guard.
11936 * compile/compile-object-load.h: Rename include guard.
11937 * compile/compile-internal.h: Rename include guard.
11938 * compile/compile-cplus.h: Rename include guard.
11939 * compile/compile-c.h: Rename include guard.
11940 * common/xml-utils.h: Rename include guard.
11941 * common/x86-xstate.h: Rename include guard.
11942 * common/version.h: Rename include guard.
11943 * common/vec.h: Rename include guard.
11944 * common/tdesc.h: Rename include guard.
11945 * common/selftest.h: Rename include guard.
11946 * common/scoped_restore.h: Rename include guard.
11947 * common/scoped_mmap.h: Rename include guard.
11948 * common/scoped_fd.h: Rename include guard.
11949 * common/safe-iterator.h: Rename include guard.
11950 * common/run-time-clock.h: Rename include guard.
11951 * common/refcounted-object.h: Rename include guard.
11952 * common/queue.h: Rename include guard.
11953 * common/ptid.h: Rename include guard.
11954 * common/print-utils.h: Rename include guard.
11955 * common/preprocessor.h: Rename include guard.
11956 * common/pathstuff.h: Rename include guard.
11957 * common/observable.h: Rename include guard.
11958 * common/netstuff.h: Rename include guard.
11959 * common/job-control.h: Rename include guard.
11960 * common/host-defs.h: Rename include guard.
11961 * common/gdb_wait.h: Rename include guard.
11962 * common/gdb_vecs.h: Rename include guard.
11963 * common/gdb_unlinker.h: Rename include guard.
11964 * common/gdb_unique_ptr.h: Rename include guard.
11965 * common/gdb_tilde_expand.h: Rename include guard.
11966 * common/gdb_sys_time.h: Rename include guard.
11967 * common/gdb_string_view.h: Rename include guard.
11968 * common/gdb_splay_tree.h: Rename include guard.
11969 * common/gdb_setjmp.h: Rename include guard.
11970 * common/gdb_ref_ptr.h: Rename include guard.
11971 * common/gdb_optional.h: Rename include guard.
11972 * common/gdb_locale.h: Rename include guard.
11973 * common/gdb_assert.h: Rename include guard.
11974 * common/filtered-iterator.h: Rename include guard.
11975 * common/filestuff.h: Rename include guard.
11976 * common/fileio.h: Rename include guard.
11977 * common/environ.h: Rename include guard.
11978 * common/common-utils.h: Rename include guard.
11979 * common/common-types.h: Rename include guard.
11980 * common/common-regcache.h: Rename include guard.
11981 * common/common-inferior.h: Rename include guard.
11982 * common/common-gdbthread.h: Rename include guard.
11983 * common/common-exceptions.h: Rename include guard.
11984 * common/common-defs.h: Rename include guard.
11985 * common/common-debug.h: Rename include guard.
11986 * common/cleanups.h: Rename include guard.
11987 * common/buffer.h: Rename include guard.
11988 * common/btrace-common.h: Rename include guard.
11989 * common/break-common.h: Rename include guard.
11990 * cli/cli-utils.h: Rename include guard.
11991 * cli/cli-style.h: Rename include guard.
11992 * cli/cli-setshow.h: Rename include guard.
11993 * cli/cli-script.h: Rename include guard.
11994 * cli/cli-interp.h: Rename include guard.
11995 * cli/cli-decode.h: Rename include guard.
11996 * cli/cli-cmds.h: Rename include guard.
11997 * charset-list.h: Add include guard.
11998 * buildsym-legacy.h: Rename include guard.
11999 * bfin-tdep.h: Add include guard.
12000 * ax.h: Rename include guard.
12001 * arm-linux-tdep.h: Add include guard.
12002 * arm-fbsd-tdep.h: Add include guard.
12003 * arch/xtensa.h: Rename include guard.
12004 * arch/tic6x.h: Add include guard.
12005 * arch/i386.h: Add include guard.
12006 * arch/arm.h: Rename include guard.
12007 * arch/arm-linux.h: Rename include guard.
12008 * arch/arm-get-next-pcs.h: Rename include guard.
12009 * arch/amd64.h: Add include guard.
12010 * arch/aarch64-insn.h: Rename include guard.
12011 * arch-utils.h: Rename include guard.
12012 * annotate.h: Add include guard.
12013 * amd64-darwin-tdep.h: Rename include guard.
12014 * aarch64-linux-tdep.h: Add include guard.
12015 * aarch64-fbsd-tdep.h: Add include guard.
12016 * aarch32-linux-nat.h: Add include guard.
12017
12018 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12019
12020 * macrotab.c (macro_define_internal): New function that
12021 factorizes macro_define_object_internal and macro_define_function
12022 code.
12023 (macro_define_object_internal): Use macro_define_internal.
12024 (macro_define_function): Likewise.
12025
12026 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12027
12028 * macrocmd.c (extract_identifier): Return
12029 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12030 callers.
12031
12032 2019-02-06 John Baldwin <jhb@FreeBSD.org>
12033
12034 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12035
12036 2019-02-05 Tom Tromey <tom@tromey.com>
12037
12038 * target.c (target_stack::unpush): Move assertion earlier.
12039
12040 2019-01-30 Tom Tromey <tom@tromey.com>
12041
12042 PR python/23615:
12043 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12044 (gdbpy_parse_and_eval): Likewise.
12045 * python/python-internal.h (gdbpy_allow_threads): New class.
12046
12047 2019-01-28 John Baldwin <jhb@FreeBSD.org>
12048
12049 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12050 (aarch64_fbsd_fpregmap): Move earlier.
12051 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12052 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12053 instead of individual calls to trad_frame_set_reg_addr.
12054 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12055 earlier.
12056 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12057 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12058 instead of individual calls to trad_frame_set_reg_addr.
12059
12060 2019-01-28 Alan Hayward <alan.hayward@arm.com>
12061
12062 * CONTRIBUTE: Replace contribution list with wiki link.
12063
12064 2019-01-25 Tom Tromey <tom@tromey.com>
12065
12066 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12067
12068 2019-01-25 Tom Tromey <tom@tromey.com>
12069
12070 * xtensa-linux-nat.c: Fix common/ includes.
12071 * xml-support.h: Fix common/ includes.
12072 * xml-support.c: Fix common/ includes.
12073 * x86-linux-nat.c: Fix common/ includes.
12074 * windows-nat.c: Fix common/ includes.
12075 * varobj.h: Fix common/ includes.
12076 * varobj.c: Fix common/ includes.
12077 * value.c: Fix common/ includes.
12078 * valops.c: Fix common/ includes.
12079 * utils.c: Fix common/ includes.
12080 * unittests/xml-utils-selftests.c: Fix common/ includes.
12081 * unittests/utils-selftests.c: Fix common/ includes.
12082 * unittests/unpack-selftests.c: Fix common/ includes.
12083 * unittests/tracepoint-selftests.c: Fix common/ includes.
12084 * unittests/style-selftests.c: Fix common/ includes.
12085 * unittests/string_view-selftests.c: Fix common/ includes.
12086 * unittests/scoped_restore-selftests.c: Fix common/ includes.
12087 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12088 * unittests/scoped_fd-selftests.c: Fix common/ includes.
12089 * unittests/rsp-low-selftests.c: Fix common/ includes.
12090 * unittests/parse-connection-spec-selftests.c: Fix common/
12091 includes.
12092 * unittests/optional-selftests.c: Fix common/ includes.
12093 * unittests/offset-type-selftests.c: Fix common/ includes.
12094 * unittests/observable-selftests.c: Fix common/ includes.
12095 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12096 * unittests/memrange-selftests.c: Fix common/ includes.
12097 * unittests/memory-map-selftests.c: Fix common/ includes.
12098 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12099 * unittests/function-view-selftests.c: Fix common/ includes.
12100 * unittests/environ-selftests.c: Fix common/ includes.
12101 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12102 * unittests/common-utils-selftests.c: Fix common/ includes.
12103 * unittests/cli-utils-selftests.c: Fix common/ includes.
12104 * unittests/array-view-selftests.c: Fix common/ includes.
12105 * ui-file.c: Fix common/ includes.
12106 * tui/tui-io.c: Fix common/ includes.
12107 * tracepoint.h: Fix common/ includes.
12108 * tracepoint.c: Fix common/ includes.
12109 * tracefile-tfile.c: Fix common/ includes.
12110 * top.h: Fix common/ includes.
12111 * top.c: Fix common/ includes.
12112 * thread.c: Fix common/ includes.
12113 * target/waitstatus.h: Fix common/ includes.
12114 * target/waitstatus.c: Fix common/ includes.
12115 * target.h: Fix common/ includes.
12116 * target.c: Fix common/ includes.
12117 * target-memory.c: Fix common/ includes.
12118 * target-descriptions.c: Fix common/ includes.
12119 * symtab.h: Fix common/ includes.
12120 * symfile.c: Fix common/ includes.
12121 * stap-probe.c: Fix common/ includes.
12122 * spu-linux-nat.c: Fix common/ includes.
12123 * sparc-nat.c: Fix common/ includes.
12124 * source.c: Fix common/ includes.
12125 * solib.c: Fix common/ includes.
12126 * solib-target.c: Fix common/ includes.
12127 * ser-unix.c: Fix common/ includes.
12128 * ser-tcp.c: Fix common/ includes.
12129 * ser-pipe.c: Fix common/ includes.
12130 * ser-base.c: Fix common/ includes.
12131 * selftest-arch.c: Fix common/ includes.
12132 * s12z-tdep.c: Fix common/ includes.
12133 * rust-exp.y: Fix common/ includes.
12134 * rs6000-aix-tdep.c: Fix common/ includes.
12135 * riscv-tdep.c: Fix common/ includes.
12136 * remote.c: Fix common/ includes.
12137 * remote-notif.h: Fix common/ includes.
12138 * remote-fileio.h: Fix common/ includes.
12139 * remote-fileio.c: Fix common/ includes.
12140 * regcache.h: Fix common/ includes.
12141 * regcache.c: Fix common/ includes.
12142 * record-btrace.c: Fix common/ includes.
12143 * python/python.c: Fix common/ includes.
12144 * python/py-type.c: Fix common/ includes.
12145 * python/py-inferior.c: Fix common/ includes.
12146 * progspace.h: Fix common/ includes.
12147 * producer.c: Fix common/ includes.
12148 * procfs.c: Fix common/ includes.
12149 * proc-api.c: Fix common/ includes.
12150 * printcmd.c: Fix common/ includes.
12151 * ppc-linux-nat.c: Fix common/ includes.
12152 * parser-defs.h: Fix common/ includes.
12153 * osdata.c: Fix common/ includes.
12154 * obsd-nat.c: Fix common/ includes.
12155 * nat/x86-linux.c: Fix common/ includes.
12156 * nat/x86-linux-dregs.c: Fix common/ includes.
12157 * nat/x86-dregs.h: Fix common/ includes.
12158 * nat/x86-dregs.c: Fix common/ includes.
12159 * nat/ppc-linux.c: Fix common/ includes.
12160 * nat/mips-linux-watch.h: Fix common/ includes.
12161 * nat/mips-linux-watch.c: Fix common/ includes.
12162 * nat/linux-waitpid.c: Fix common/ includes.
12163 * nat/linux-ptrace.h: Fix common/ includes.
12164 * nat/linux-ptrace.c: Fix common/ includes.
12165 * nat/linux-procfs.c: Fix common/ includes.
12166 * nat/linux-personality.c: Fix common/ includes.
12167 * nat/linux-osdata.c: Fix common/ includes.
12168 * nat/linux-namespaces.c: Fix common/ includes.
12169 * nat/linux-btrace.h: Fix common/ includes.
12170 * nat/linux-btrace.c: Fix common/ includes.
12171 * nat/fork-inferior.c: Fix common/ includes.
12172 * nat/amd64-linux-siginfo.c: Fix common/ includes.
12173 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12174 * nat/aarch64-linux.c: Fix common/ includes.
12175 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12176 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12177 * namespace.h: Fix common/ includes.
12178 * mips-linux-tdep.c: Fix common/ includes.
12179 * minsyms.c: Fix common/ includes.
12180 * mi/mi-parse.h: Fix common/ includes.
12181 * mi/mi-main.c: Fix common/ includes.
12182 * mi/mi-cmd-env.c: Fix common/ includes.
12183 * memrange.h: Fix common/ includes.
12184 * memattr.c: Fix common/ includes.
12185 * maint.h: Fix common/ includes.
12186 * maint.c: Fix common/ includes.
12187 * main.c: Fix common/ includes.
12188 * machoread.c: Fix common/ includes.
12189 * location.c: Fix common/ includes.
12190 * linux-thread-db.c: Fix common/ includes.
12191 * linux-nat.c: Fix common/ includes.
12192 * linux-fork.c: Fix common/ includes.
12193 * inline-frame.c: Fix common/ includes.
12194 * infrun.c: Fix common/ includes.
12195 * inflow.c: Fix common/ includes.
12196 * inferior.h: Fix common/ includes.
12197 * inferior.c: Fix common/ includes.
12198 * infcmd.c: Fix common/ includes.
12199 * inf-ptrace.c: Fix common/ includes.
12200 * inf-child.c: Fix common/ includes.
12201 * ia64-linux-nat.c: Fix common/ includes.
12202 * i387-tdep.c: Fix common/ includes.
12203 * i386-tdep.c: Fix common/ includes.
12204 * i386-linux-tdep.c: Fix common/ includes.
12205 * i386-linux-nat.c: Fix common/ includes.
12206 * i386-go32-tdep.c: Fix common/ includes.
12207 * i386-fbsd-tdep.c: Fix common/ includes.
12208 * i386-fbsd-nat.c: Fix common/ includes.
12209 * guile/scm-type.c: Fix common/ includes.
12210 * guile/guile.c: Fix common/ includes.
12211 * go32-nat.c: Fix common/ includes.
12212 * gnu-nat.c: Fix common/ includes.
12213 * gdbthread.h: Fix common/ includes.
12214 * gdbarch-selftests.c: Fix common/ includes.
12215 * gdb_usleep.c: Fix common/ includes.
12216 * gdb_select.h: Fix common/ includes.
12217 * gdb_bfd.c: Fix common/ includes.
12218 * gcore.c: Fix common/ includes.
12219 * fork-child.c: Fix common/ includes.
12220 * findvar.c: Fix common/ includes.
12221 * fbsd-nat.c: Fix common/ includes.
12222 * event-top.c: Fix common/ includes.
12223 * event-loop.c: Fix common/ includes.
12224 * dwarf2read.c: Fix common/ includes.
12225 * dwarf2loc.c: Fix common/ includes.
12226 * dwarf2-frame.c: Fix common/ includes.
12227 * dwarf-index-cache.c: Fix common/ includes.
12228 * dtrace-probe.c: Fix common/ includes.
12229 * disasm-selftests.c: Fix common/ includes.
12230 * defs.h: Fix common/ includes.
12231 * csky-tdep.c: Fix common/ includes.
12232 * cp-valprint.c: Fix common/ includes.
12233 * cp-support.h: Fix common/ includes.
12234 * cp-support.c: Fix common/ includes.
12235 * corelow.c: Fix common/ includes.
12236 * completer.h: Fix common/ includes.
12237 * completer.c: Fix common/ includes.
12238 * compile/compile.c: Fix common/ includes.
12239 * compile/compile-loc2c.c: Fix common/ includes.
12240 * compile/compile-cplus-types.c: Fix common/ includes.
12241 * compile/compile-cplus-symbols.c: Fix common/ includes.
12242 * command.h: Fix common/ includes.
12243 * cli/cli-dump.c: Fix common/ includes.
12244 * cli/cli-cmds.c: Fix common/ includes.
12245 * charset.c: Fix common/ includes.
12246 * build-id.c: Fix common/ includes.
12247 * btrace.h: Fix common/ includes.
12248 * btrace.c: Fix common/ includes.
12249 * breakpoint.h: Fix common/ includes.
12250 * breakpoint.c: Fix common/ includes.
12251 * ax.h:
12252 (enum agent_op): Fix common/ includes.
12253 * ax-general.c (struct aop_map): Fix common/ includes.
12254 * ax-gdb.c: Fix common/ includes.
12255 * auxv.c: Fix common/ includes.
12256 * auto-load.c: Fix common/ includes.
12257 * arm-tdep.c: Fix common/ includes.
12258 * arch/riscv.c: Fix common/ includes.
12259 * arch/ppc-linux-common.c: Fix common/ includes.
12260 * arch/i386.c: Fix common/ includes.
12261 * arch/arm.c: Fix common/ includes.
12262 * arch/arm-linux.c: Fix common/ includes.
12263 * arch/arm-get-next-pcs.c: Fix common/ includes.
12264 * arch/amd64.c: Fix common/ includes.
12265 * arch/aarch64.c: Fix common/ includes.
12266 * arch/aarch64-insn.c: Fix common/ includes.
12267 * arch-utils.c: Fix common/ includes.
12268 * amd64-windows-tdep.c: Fix common/ includes.
12269 * amd64-tdep.c: Fix common/ includes.
12270 * amd64-sol2-tdep.c: Fix common/ includes.
12271 * amd64-obsd-tdep.c: Fix common/ includes.
12272 * amd64-nbsd-tdep.c: Fix common/ includes.
12273 * amd64-linux-tdep.c: Fix common/ includes.
12274 * amd64-linux-nat.c: Fix common/ includes.
12275 * amd64-fbsd-tdep.c: Fix common/ includes.
12276 * amd64-fbsd-nat.c: Fix common/ includes.
12277 * amd64-dicos-tdep.c: Fix common/ includes.
12278 * amd64-darwin-tdep.c: Fix common/ includes.
12279 * agent.c: Fix common/ includes.
12280 * ada-lang.h: Fix common/ includes.
12281 * ada-lang.c: Fix common/ includes.
12282 * aarch64-tdep.c: Fix common/ includes.
12283
12284 2019-01-25 Tom Tromey <tom@tromey.com>
12285
12286 * common/create-version.sh: Use common/version.h.
12287
12288 2019-01-24 Pedro Alves <palves@redhat.com>
12289
12290 * infrun.c (signal_stop, signal_print, signal_program)
12291 (signal_catch, signal_pass): Now arrays instead of pointers.
12292 (update_signals_program_target, do_target_resume)
12293 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12294 * linux-nat.c (linux_nat_target::pass_signals)
12295 (linux_nat_target::create_inferior, linux_nat_target::attach):
12296 Adjust.
12297 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12298 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12299 * procfs.c (procfs_target::pass_signals): Adjust.
12300 * record-full.c (record_full_target::resume): Adjust.
12301 * remote.c (remote_target::pass_signals)
12302 (remote_target::program_signals): Adjust.
12303 * target-debug.h (target_debug_print_signals): Now takes a
12304 gdb::array_view as parameter. Adjust.
12305 * target.h (target_ops) <pass_signals, program_signals>: Replace
12306 pointer and length parameters with gdb::array_view.
12307 (target_pass_signals, target_program_signals): Likewise.
12308 * target-delegates.c: Regenerate.
12309
12310 2019-01-24 Pedro Alves <palves@redhat.com>
12311
12312 * common/forward-scope-exit.h
12313 (forward_scope_exit::forward_scope_exit): Pass arguments to
12314 m_bind_function directly, instead of creating a std::bind and
12315 copying that.
12316
12317 2019-01-24 Alan Hayward <alan.hayward@arm.com>
12318
12319 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12320 for static members.
12321 (pass_in_v_vfp_candidate): Likewise.
12322
12323 2019-01-23 Tom Tromey <tom@tromey.com>
12324 Pedro Alves <palves@redhat.com>
12325
12326 * regcache.c (class regcache_invalidator): Remove.
12327 (regcache::raw_write): Use make_scope_exit.
12328
12329 2019-01-23 Tom Tromey <tom@tromey.com>
12330
12331 * ui-out.h (class ui_out_emit_type): Update comment.
12332
12333 2019-01-23 Tom Tromey <tom@tromey.com>
12334
12335 * infrun.c (fetch_inferior_event): Update comment.
12336
12337 2019-01-23 Tom Tromey <tom@tromey.com>
12338 Pedro Alves <palves@redhat.com>
12339
12340 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12341 parameter.
12342 (fetch_inferior_event): Use SCOPE_EXIT.
12343
12344
12345 2019-01-23 Tom Tromey <tom@tromey.com>
12346 Pedro Alves <palves@redhat.com>
12347
12348 * infrun.c (disable_thread_events): Delete.
12349 (stop_all_threads): Use SCOPE_EXIT.
12350
12351 2019-01-23 Tom Tromey <tom@tromey.com>
12352 Pedro Alves <palves@redhat.com>
12353
12354 * symfile.c: Include forward-scope-exit.h.
12355 (clear_symtab_users_cleanup): Replace forward declaration with
12356 a FORWARD_SCOPE_EXIT.
12357 (syms_from_objfile_1): Use the forward_scope_exit and
12358 gdb::optional instead of cleanup_function.
12359 (reread_symbols): Use the forward_scope_exit instead of
12360 cleanup_function.
12361 (clear_symtab_users_cleanup): Remove function.
12362
12363 2019-01-23 Tom Tromey <tom@tromey.com>
12364 Pedro Alves <palves@redhat.com>
12365
12366 * linux-nat.c: Include scope-exit.h.
12367 (cleanup_target_stop): Remove.
12368 (linux_nat_target::static_tracepoint_markers_by_strid): Use
12369 SCOPE_EXIT.
12370
12371 2019-01-23 Tom Tromey <tom@tromey.com>
12372 Pedro Alves <palves@redhat.com>
12373
12374 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12375 (call_function_by_hand_dummy): Use SCOPE_EXIT.
12376
12377 2019-01-23 Tom Tromey <tom@tromey.com>
12378 Andrew Burgess <andrew.burgess@embecosm.com>
12379 Pedro Alves <palves@redhat.com>
12380
12381 * infrun.c (fetch_inferior_event): Use scope_exit.
12382 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12383 * top.c (execute_command): Use scope_exit.
12384 * breakpoint.c (bpstat_do_actions): Use scope_exit.
12385 * utils.c (do_bpstat_clear_actions_cleanup)
12386 (make_bpstat_clear_actions_cleanup): Remove.
12387
12388 2019-01-23 Tom Tromey <tom@tromey.com>
12389 Pedro Alves <palves@redhat.com>
12390
12391 * infrun.c: Include "common/scope-exit.h"
12392 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12393 (wait_for_inferior): Use SCOPE_EXIT.
12394 (fetch_inferior_event): Use scope_exit.
12395
12396 2019-01-23 Tom Tromey <tom@tromey.com>
12397 Pedro Alves <palves@redhat.com>
12398
12399 * breakpoint.c (create_breakpoint): Remove cleanup.
12400
12401 2019-01-23 Tom Tromey <tom@tromey.com>
12402 Andrew Burgess <andrew.burgess@embecosm.com>
12403 Pedro Alves <palves@redhat.com>
12404
12405 2019-01-23 Pedro Alves <palves@redhat.com>
12406
12407 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12408
12409 2019-01-23 Pedro Alves <palves@redhat.com>
12410 Andrew Burgess <andrew.burgess@embecosm.com>
12411
12412 * gdbthread.h: Include "common/forward-scope-exit.h".
12413 (scoped_finish_thread_state): Redefine custom class in terms of
12414 forward_scope_exit.
12415
12416 2019-01-23 Pedro Alves <palves@redhat.com>
12417 Andrew Burgess <andrew.burgess@embecosm.com>
12418
12419 * common/forward-scope-exit.h: New file.
12420
12421 2019-01-23 Pedro Alves <palves@redhat.com>
12422 Andrew Burgess <andrew.burgess@embecosm.com>
12423 Tom Tromey <tom@tromey.com>
12424
12425 * common/scope-exit.h: New file.
12426
12427 2019-01-23 Pedro Alves <palves@redhat.com>
12428
12429 * common/preprocessor.h (ESC): Rename to ...
12430 (ESC_PARENS): ... this.
12431 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12432 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12433
12434 2019-01-23 Tom Tromey <tom@tromey.com>
12435
12436 * language.h (class scoped_switch_to_sym_language_if_auto):
12437 Initialize m_lang in both cases.
12438
12439 2019-01-23 Alan Hayward <alan.hayward@arm.com>
12440
12441 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12442 with XCNEW.
12443
12444 2019-01-22 Tom Tromey <tom@tromey.com>
12445
12446 * corelow.c: Do not include sys/file.h.
12447
12448 2019-01-22 Tom Tromey <tom@tromey.com>
12449
12450 * tui/tui-wingeneral.h: Include gdb_curses.h.
12451
12452 2019-01-22 Tom Tromey <tom@tromey.com>
12453
12454 * source-cache.h (class source_cache) <get_source_lines,
12455 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12456
12457 2019-01-22 Tom Tromey <tom@tromey.com>
12458
12459 * remote-fileio.h (struct remote_target): Declare.
12460
12461 2019-01-22 Tom Tromey <tom@tromey.com>
12462
12463 * python/py-arch.c: Do not include py-ref.h.
12464 * python/py-bpevent.c: Do not include py-ref.h.
12465 * python/py-cmd.c: Do not include py-ref.h.
12466 * python/py-continueevent.c: Do not include py-ref.h.
12467 * python/py-event.h: Do not include py-ref.h.
12468 * python/py-evtregistry.c: Do not include py-ref.h.
12469 * python/py-finishbreakpoint.c: Do not include py-ref.h.
12470 * python/py-frame.c: Do not include py-ref.h.
12471 * python/py-framefilter.c: Do not include py-ref.h.
12472 * python/py-function.c: Do not include py-ref.h.
12473 * python/py-infevents.c: Do not include py-ref.h.
12474 * python/py-linetable.c: Do not include py-ref.h.
12475 * python/py-objfile.c: Do not include py-ref.h.
12476 * python/py-param.c: Do not include py-ref.h.
12477 * python/py-prettyprint.c: Do not include py-ref.h.
12478 * python/py-progspace.c: Do not include py-ref.h.
12479 * python/py-symbol.c: Do not include py-ref.h.
12480 * python/py-symtab.c: Do not include py-ref.h.
12481 * python/py-type.c: Do not include py-ref.h.
12482 * python/py-unwind.c: Do not include py-ref.h.
12483 * python/py-utils.c: Do not include py-ref.h.
12484 * python/py-value.c: Do not include py-ref.h.
12485 * python/py-varobj.c: Do not include py-ref.h.
12486 * python/py-xmethods.c: Do not include py-ref.h.
12487 * python/python.c: Do not include py-ref.h.
12488 * varobj.c: Do not include py-ref.h.
12489
12490 2019-01-22 Tom Tromey <tom@tromey.com>
12491
12492 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12493 keyword for bcache.
12494
12495 2019-01-22 Tom Tromey <tom@tromey.com>
12496
12497 * compile/compile-cplus-types.c: Remove a comment by #include.
12498
12499 2019-01-22 Tom Tromey <tom@tromey.com>
12500
12501 * compile/gcc-c-plugin.h: Include compile-internal.h.
12502
12503 2019-01-22 Tom Tromey <tom@tromey.com>
12504
12505 * stabsread.c (EXTERN): Do not define.
12506 (symnum, next_symbol_text_func, processing_gcc_compilation)
12507 (within_function, global_sym_chain, global_stabs)
12508 (previous_stab_code, this_object_header_files)
12509 (n_this_object_header_files)
12510 (n_allocated_this_object_header_files): Define.
12511 * stabsread.h (EXTERN): Never define. Use "extern".
12512
12513 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12514
12515 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12516 history_value.
12517
12518 2019-01-21 Tom Tromey <tom@tromey.com>
12519
12520 * ui-out.c: Fix includes.
12521 * tui/tui-source.c: Fix includes.
12522 * target.c: Fix includes.
12523 * remote.c: Fix includes.
12524 * regcache.c: Fix includes.
12525 * python/py-block.c: Fix includes.
12526 * printcmd.c: Fix includes.
12527 * or1k-tdep.c: Fix includes.
12528 * mi/mi-main.c: Fix includes.
12529 * m32r-tdep.c: Fix includes.
12530 * csky-tdep.c: Fix includes.
12531 * compile/compile-cplus-types.c: Fix includes.
12532 * cli/cli-interp.c: Fix includes.
12533
12534 2019-01-21 Alan Hayward <alan.hayward@arm.com>
12535
12536 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12537 for padding.
12538
12539 2019-01-16 Tom Tromey <tom@tromey.com>
12540
12541 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
12542 earlier.
12543 (struct objfile) <msymbols_range>: Move from top level.
12544 <msymbols>: New method.
12545 (class objfile_msymbols): Remove.
12546 * symtab.c (default_collect_symbol_completion_matches_break_on):
12547 Update.
12548 * symmisc.c (dump_msymbols): Update.
12549 * stabsread.c (scan_file_globals): Update.
12550 * objc-lang.c (info_selectors_command, info_classes_command)
12551 (find_methods): Update.
12552 * minsyms.c (find_solib_trampoline_target): Update.
12553 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12554 * coffread.c (coff_symfile_read): Update.
12555 * ada-lang.c (ada_lookup_simple_minsym)
12556 (ada_collect_symbol_completion_matches): Update.
12557
12558 2019-01-16 Tom Tromey <tom@tromey.com>
12559
12560 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12561 type. Remove no-argument constructor.
12562 <iterator::operator++>: Simplify.
12563 <begin>: Update.
12564 <end>: Use minimal_symbol_count.
12565
12566 2019-01-16 Tom Tromey <tom@tromey.com>
12567
12568 * objfiles.h (struct objfile) <psymtabs>: New method.
12569 (class objfile_psymtabs): Remove.
12570 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12571 typedef.
12572 <range>: New method.
12573 (require_partial_symbols): Change return type.
12574 * psymtab.c (require_partial_symbols)
12575 (psym_expand_symtabs_matching): Update.
12576 * mdebugread.c (parse_partial_symbols): Update.
12577 * dbxread.c (dbx_end_psymtab): Update.
12578
12579 2019-01-15 Tom Tromey <tom@tromey.com>
12580
12581 * symtab.c (lookup_objfile_from_block)
12582 (lookup_symbol_in_objfile_symtabs)
12583 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12584 (find_line_symtab, info_sources_command)
12585 (default_collect_symbol_completion_matches_break_on)
12586 (make_source_files_completion_list): Update.
12587 * symmisc.c (print_objfile_statistics, dump_objfile)
12588 (maintenance_print_symbols, maintenance_info_symtabs)
12589 (maintenance_check_symtabs, maintenance_info_line_tables):
12590 Update.
12591 * source.c (select_source_symtab)
12592 (forget_cached_source_info_for_objfile): Update.
12593 * objfiles.h (class objfile_compunits): Remove.
12594 (struct objfile) <compunits_range>: New typedef.
12595 (compunits): New method.
12596 * objfiles.c (objfile_relocate1): Update.
12597 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12598 * maint.c (count_symtabs_and_blocks): Update.
12599 * linespec.c (iterate_over_all_matching_symtabs): Update.
12600 * cp-support.c (add_symbol_overload_list_qualified): Update.
12601 * coffread.c (coff_symtab_read): Update.
12602 * ada-lang.c (add_nonlocal_symbols)
12603 (ada_collect_symbol_completion_matches)
12604 (ada_add_global_exceptions): Update.
12605
12606 2019-01-15 Tom Tromey <tom@tromey.com>
12607
12608 * progspace.h (program_space) <objfiles_safe_range>: New
12609 typedef.
12610 <objfiles_safe>: New method.
12611 * objfiles.h (class all_objfiles_safe): Remove.
12612 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12613 * jit.c (jit_inferior_exit_hook): Update.
12614
12615 2019-01-17 Tom Tromey <tom@tromey.com>
12616
12617 * progspace.h (program_space) <objfiles_range>: New typedef.
12618 <objfiles>: New method.
12619 <objfiles_head>: Rename from objfiles.
12620 (object_files): Update.
12621 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12622 * guile/scm-pretty-print.c
12623 (ppscm_find_pretty_printer_from_objfiles): Update.
12624 * guile/scm-objfile.c (gdbscm_objfiles): Update.
12625 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12626 Update.
12627 * python/py-progspace.c (pspy_get_objfiles): Update.
12628 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12629 Update.
12630 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12631 (objfpy_lookup_objfile_by_build_id): Update.
12632 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12633 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12634 Update.
12635 * symtab.c (iterate_over_symtabs, matching_obj_sections)
12636 (expand_symtab_containing_pc, lookup_objfile_from_block)
12637 (lookup_static_symbol, basic_lookup_transparent_type)
12638 (find_pc_sect_compunit_symtab, find_symbol_at_address)
12639 (find_line_symtab, info_sources_command)
12640 (default_collect_symbol_completion_matches_break_on)
12641 (make_source_files_completion_list, find_main_name): Update.
12642 * symmisc.c (print_symbol_bcache_statistics)
12643 (print_objfile_statistics, maintenance_print_symbols)
12644 (maintenance_print_msymbols, maintenance_print_objfiles)
12645 (maintenance_info_symtabs, maintenance_check_symtabs)
12646 (maintenance_expand_symtabs, maintenance_info_line_tables):
12647 Update.
12648 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12649 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12650 (map_overlay_command, unmap_overlay_command)
12651 (simple_overlay_update, expand_symtabs_matching)
12652 (map_symbol_filenames): Update.
12653 * symfile-debug.c (set_debug_symfile): Update.
12654 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12655 Update.
12656 * source.c (select_source_symtab, forget_cached_source_info):
12657 Update.
12658 * solib.c (solib_read_symbols): Update.
12659 * solib-spu.c (append_ocl_sos): Update.
12660 * psymtab.c (maintenance_print_psymbols)
12661 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12662 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12663 * printcmd.c (info_symbol_command): Update.
12664 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12665 Update.
12666 * objfiles.h (class all_objfiles): Remove.
12667 * objfiles.c (have_partial_symbols, have_full_symbols)
12668 (have_minimal_symbols, qsort_cmp, update_section_map)
12669 (shared_objfile_contains_address_p)
12670 (default_iterate_over_objfiles_in_search_order): Update.
12671 * objc-lang.c (info_selectors_command, info_classes_command)
12672 (find_methods): Update.
12673 * minsyms.c (find_solib_trampoline_target): Update.
12674 * maint.c (maintenance_info_sections)
12675 (maintenance_translate_address, count_symtabs_and_blocks):
12676 Update.
12677 * main.c (captured_main_1): Update.
12678 * linux-thread-db.c (try_thread_db_load_from_pdir)
12679 (has_libpthread): Update.
12680 * linespec.c (iterate_over_all_matching_symtabs)
12681 (search_minsyms_for_name): Update.
12682 * jit.c (jit_find_objf_with_entry_addr): Update.
12683 * hppa-tdep.c (find_unwind_entry)
12684 (hppa_lookup_stub_minimal_symbol): Update.
12685 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12686 Update.
12687 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12688 (elf_gnu_ifunc_resolve_by_got): Update.
12689 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12690 * dwarf-index-write.c (save_gdb_index_command): Update.
12691 * cp-support.c (add_symbol_overload_list_qualified): Update.
12692 * breakpoint.c (create_overlay_event_breakpoint)
12693 (create_longjmp_master_breakpoint)
12694 (create_std_terminate_master_breakpoint)
12695 (create_exception_master_breakpoint): Update.
12696 * blockframe.c (find_pc_partial_function): Update.
12697 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12698 (ada_collect_symbol_completion_matches)
12699 (ada_add_global_exceptions): Update.
12700
12701 2019-01-17 Tom Tromey <tom@tromey.com>
12702
12703 * solib-target.c (lm_info_target_p): Remove typedef. Don't
12704 declare VEC.
12705 (solib_target_parse_libraries): Change return type.
12706 (library_list_start_segment, library_list_start_section)
12707 (library_list_end_library, library_list_start_library); Update.
12708 (solib_target_free_library_list): Remove.
12709 (solib_target_parse_libraries): Remove cleanup. Change return
12710 type.
12711 (solib_target_current_sos): Update.
12712
12713 2019-01-17 Tom Tromey <tromey@bapiya>
12714
12715 * valprint.c: Replace "the the" with "the".
12716 * symtab.c: Replace "the the" with "the".
12717 * solib.c: Replace "the the" with "the".
12718 * solib-dsbt.c: Replace "the the" with "the".
12719 * linespec.c: Replace "the the" with "the".
12720 * dwarf2loc.h: Replace "the the" with "the".
12721 * amd64-windows-tdep.c: Replace "the the" with "the".
12722 * aarch64-tdep.c: Replace "the the" with "the".
12723
12724 2019-01-16 Keith Seitz <keiths@redhat.com>
12725
12726 PR gdb/23773
12727 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12728 <builder>: Rename to ..
12729 <m_builder>: ... this and make private.
12730 (dwarf2_cu::get_builder): New method. Change all users of
12731 `builder' to use this method.
12732 (dwarf2_start_symtab): Move to ...
12733 (dwarf2_cu::start_symtab): ... here. Update all callers
12734 (setup_type_unit_groups): Move to ...
12735 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
12736 callers.
12737 (dwarf2_cu::reset_builder): New method.
12738 (process_full_compunit, process_full_type_unit): Use
12739 dwarf2_cu::reset_builder.
12740 (follow_die_offset): Record the ancestor CU if it is different
12741 from the followed DIE's CU.
12742 (follow_die_sig_1): Likewise.
12743
12744 2019-01-15 Tom Tromey <tom@tromey.com>
12745
12746 * remote.c (class remote_state) <buf>: Now a char_vector.
12747 <buf_size>: Remove.
12748 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
12749 parameter.
12750 (remote_target::getpkt_or_notif_sane_1)
12751 (remote_target::getpkt_sane)
12752 (remote_target::getpkt_or_notif_sane): Likewise.
12753 (class remote_target) <putpkt>: New overload.
12754 (remote_target::read_frame): Change type of "buf_p". Remove
12755 sizeof_p parameter.
12756 (packet_ok): New overload.
12757 (packet_check_result): New overload.
12758 Update all uses.
12759
12760 2019-01-14 Tom Tromey <tom@tromey.com>
12761
12762 * remote-notif.c (handle_notification, remote_notif_ack)
12763 (remote_notif_parse): Make "buf" const.
12764 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12765 const.
12766 (remote_notif_parse, remote_notif_ack, handle_notification):
12767 Likewise.
12768 * remote.c (remote_notif_stop_parse): Make "buf" const.
12769 (remote_target::remote_parse_stop_reply): Make "buf" const.
12770 (remote_notif_stop_ack): Make "buf" const.
12771
12772 2019-01-14 Tom Tromey <tom@tromey.com>
12773
12774 * remote.c (remote_console_output): Make parameter const.
12775
12776 2019-01-14 Tom Tromey <tom@tromey.com>
12777
12778 * target-debug.h (target_debug_print_signals): Constify.
12779 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12780 * procfs.c (procfs_target::pass_signals): Update.
12781 * linux-nat.c (linux_nat_target::pass_signals): Update.
12782 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12783 * target-delegates.c: Rebuild.
12784 * remote.c (remote_target::program_signals): Update.
12785 (remote_target::pass_signals): Update.
12786 * target.c (target_pass_signals): Constify argument.
12787 (target_program_signals): Likewise.
12788 * target.h (struct target_ops) <pass_signals, program_signals>:
12789 Constify argument.
12790 (target_pass_signals, target_program_signals): Constify argument.
12791
12792 2019-01-14 Tom Tromey <tom@tromey.com>
12793
12794 PR tui/28819:
12795 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12796
12797 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
12798
12799 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12800 field.
12801 * rs6000-tdep.c: Include reggroups.h.
12802 (IS_V_ALIAS_PSEUDOREG): Define.
12803 (rs6000_register_name): Return names for the "vX" aliases.
12804 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12805 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
12806 aliases. Call default_register_reggroup_p for all other
12807 pseudo-registers.
12808 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12809 New functions.
12810 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12811 Handle "vX" aliases.
12812 (v_alias_pseudo_register_collect): New function.
12813 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12814 (rs6000_gdbarch_init): Initialize "vX" aliases as
12815 pseudo-registers. Restore registration of
12816 rs6000_pseudo_register_reggroup_p with
12817 set_tdesc_pseudo_register_reggroup_p.
12818
12819 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
12820
12821 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12822 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12823 set_gdbarch_num_pseudo_regs.
12824
12825 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12826
12827 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12828 Remove arg prefixname, add do_set and do_show.
12829 Add member functions set_list and show_list.
12830 * cli/cli-style.c (class cli_style_option): Update accordingly.
12831 (style_set_list): Move to file scope.
12832 (style_show_list): Likewise.
12833 (set_style): Call help_list.
12834 (show_style): Call cmd_show_list.
12835 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12836 Update to use the new macro.
12837
12838 2019-10-12 Joel Brobecker <brobecker@adacore.com>
12839
12840 * ada-lang.c (_initialize_ada_language): Expand the help text
12841 for the "catch exception" command.
12842
12843 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12844
12845 * symtab.c (matching_obj_sections): Initialize obj,
12846 declare it closer to its usage.
12847
12848 2019-01-10 Tom Tromey <tom@tromey.com>
12849
12850 * thread-iter.h (inf_threads_iterator): Use next_iterator.
12851 (basic_inf_threads_range): Remove.
12852 (inf_threads_range, inf_non_exited_threads_range)
12853 (safe_inf_threads_range): Use next_adapter.
12854
12855 2019-01-10 Keith Seitz <keiths@redhat.com>
12856
12857 PR gdb/23712
12858 PR symtab/23010
12859 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12860 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12861
12862 2019-01-10 Keith Seitz <keiths@redhat.com>
12863
12864 PR gdb/23712
12865 PR symtab/23010
12866 * dictionary.c (pending_to_vector): Remove.
12867 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12868 Remove _1 suffix, replacing functions of the same name. Update
12869 all callers.
12870 (dict_create_hashed, dict_create_hashed_expandable)
12871 (dict_create_linear, dict_create_linear_expandable, dict_free)
12872 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12873 Make functions static.
12874
12875 2019-01-10 Keith Seitz <keiths@redhat.com>
12876
12877 PR gdb/23712
12878 PR symtab/23010
12879 * dictionary.h (struct dictionary): Replace declaration with
12880 multidictionary.
12881 (dict_create_hashed, dict_create_hashed_expandable)
12882 (dict_create_linear, dict_create_linear_expandable)
12883 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12884 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12885 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12886 taking multidictionary argument.
12887 [ALL_DICT_SYMBOLS]: Update for multidictionary.
12888 * block.h (struct block) <dict>: Change to multidictionary
12889 and rename `multidict'.
12890 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12891 symmisc.c: Update all dictionary references to multidictionary.
12892
12893 2019-01-10 Keith Seitz <keiths@redhat.com>
12894
12895 PR gdb/23712
12896 PR symtab/23010
12897 * dictionary.c: Include unordered_map.
12898 (pending_to_vector): New function.
12899 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12900 Rewrite the non-"_1" functions to take vector instead
12901 of linked list.
12902 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12903 "new" _1 versions of the same name.
12904 (multidictionary): Define.
12905 (std::hash<enum language): New definition.
12906 (collate_pending_symbols_by_language, mdict_create_hashed)
12907 (mdict_create_hashed_expandable, mdict_create_linear)
12908 (mdict_create_linear_expandable, mdict_free)
12909 (find_language_dictionary, create_new_language_dictionary)
12910 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12911 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12912 (mdict_size, mdict_empty): New functions.
12913 * dictionary.h (mdict_iterator): Define.
12914
12915 2019-01-10 Pedro Alves <palves@redhat.com>
12916
12917 * breakpoint.c (read_uploaded_action)
12918 (create_tracepoint_from_upload): Adjust to use
12919 gdb::unique_xmalloc_ptr.
12920 * ctf.c (ctf_write_uploaded_tp):
12921 (SET_ARRAY_FIELD): Use emplace_back.
12922 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12923 * tracefile-tfile.c (tfile_write_uploaded_tp):
12924 * tracepoint.c (parse_tracepoint_definition): Adjust to use
12925 gdb::unique_xmalloc_ptr.
12926 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12927 at_string, cond_string, cmd_strings>: Replace char pointers
12928 with gdb::unique_xmalloc_ptr.
12929
12930 2019-01-10 Pedro Alves <palves@redhat.com>
12931
12932 * solib-target.c (library_list_start_library): Don't xstrdup name.
12933
12934 2019-01-10 Pedro Alves <palves@redhat.com>
12935
12936 * mdebugread.c (parse_partial_symbols): Use
12937 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12938
12939 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12940
12941 * linux-fork.c (scoped_switch_fork_info)
12942 <~scoped_switch_fork_info>: Fix incorrect variable name.
12943
12944 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12945
12946 * linux-fork.c (scoped_switch_fork_info)
12947 <scoped_switch_fork_info>: Make explicit.
12948 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12949
12950 2019-01-10 Tom Tromey <tom@tromey.com>
12951
12952 * objfiles.h (objfile::reset_psymtabs): Update.
12953 * objfiles.c (objfile::objfile): Update.
12954 * psymtab.h (psymtab_storage::obstack): Update.
12955 (psymtab_storage::m_obstack): Use gdb::optional.
12956 (class psymtab_storage): Update comment. Remove objfile
12957 parameter.
12958 * psymtab.c (psymtab_storage::psymtab_storage): Update.
12959
12960 2019-01-10 Tom Tromey <tom@tromey.com>
12961
12962 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12963 <free_psymtabs>: Now private.
12964 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12965 (allocate_psymtab): Use new method.
12966
12967 2019-01-10 Tom Tromey <tom@tromey.com>
12968
12969 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12970 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12971 * mdebugread.c (parse_partial_symbols): Use
12972 allocate_dependencies.
12973 * dwarf2read.c (dwarf2_create_include_psymtab): Use
12974 allocate_dependencies.
12975 (process_psymtab_comp_unit_reader)
12976 (build_type_psymtab_dependencies): Likewise.
12977 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12978
12979 2019-01-10 Tom Tromey <tom@tromey.com>
12980
12981 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12982 PSYMBOL_SET_LANGUAGE.
12983 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12984
12985 2019-01-10 Tom Tromey <tom@tromey.com>
12986
12987 * psymtab.h (psymtab_storage::obstack): New method.
12988 <m_obstack>: Rename from obstack; now private.
12989 * psymtab.c (psymtab_storage): Update.
12990 * dwarf2read.c (create_addrmap_from_index)
12991 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12992 Update.
12993
12994 2019-01-10 Tom Tromey <tom@tromey.com>
12995
12996 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12997 * objfiles.h (objfile::reset_psymtabs): New method.
12998
12999 2019-01-10 Tom Tromey <tom@tromey.com>
13000
13001 * symmisc.c (print_symbol_bcache_statistics): Update.
13002 (print_objfile_statistics): Update.
13003 * symfile.c (reread_symbols): Update.
13004 * psymtab.h (class psymtab_storage): New.
13005 * psymtab.c (psymtab_storage): New constructor.
13006 (~psymtab_storage): New destructor.
13007 (require_partial_symbols): Update.
13008 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13009 (find_pc_sect_psymtab, find_pc_sect_psymbol)
13010 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13011 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13012 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13013 (start_psymtab_common, end_psymtab_common)
13014 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13015 (allocate_psymtab): Update.
13016 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13017 Update.
13018 (dump_psymtab_addrmap, maintenance_print_psymbols)
13019 (maintenance_check_psymtabs): Update.
13020 (class objfile_psymtabs): Move to objfiles.h.
13021 * psympriv.h (discard_psymtab): Now inline.
13022 (psymtab_discarder::psymtab_discarder): Update.
13023 (psymtab_discarder::~psymtab_discarder): Update.
13024 (ALL_OBJFILE_PSYMTABS): Rewrite.
13025 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13026 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13027 Remove fields.
13028 <partial_symtabs>: New field.
13029 (class objfile_psymtabs): Move from psymtab.h. Update.
13030 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13031 psymbol_cache.
13032 (objfile::~objfile): Don't destroy psymbol_cache.
13033 * mdebugread.c (parse_partial_symbols): Update.
13034 * dwarf2read.c (create_addrmap_from_index)
13035 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13036 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13037 (add_partial_subprogram, dwarf2_ranges_read): Update.
13038 * dwarf-index-write.c (write_address_map)
13039 (write_one_signatured_type, recursively_write_psymbols)
13040 (class debug_names, class debug_names, write_psymtabs_to_index):
13041 Update.
13042
13043 2019-01-10 Tom Tromey <tom@tromey.com>
13044
13045 * symtab.h (SYMBOL_SET_NAMES): Update.
13046 (symbol_set_names): Update.
13047 (MSYMBOL_SET_NAMES): Update.
13048 * symtab.c (symbol_set_names): Change argument to be an
13049 objfile_per_bfd_storage.
13050 * psymtab.c (add_psymbol_to_bcache): Update.
13051 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13052
13053 2019-01-10 Tom Tromey <tom@tromey.com>
13054
13055 * symtab.c (create_demangled_names_hash): Change argument to be an
13056 objfile_per_bfd_storage.
13057 (symbol_set_names): Update.
13058
13059 2019-01-10 Tom Tromey <tom@tromey.com>
13060
13061 * xcoffread.c (xcoff_initial_scan): Unconditionally call
13062 init_psymbol_list.
13063 * psymtab.c (init_psymbol_list): Do nothing if already called.
13064 * psympriv.h (init_psymbol_list): Add comment.
13065 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13066 init_psymbol_list.
13067 * dbxread.c (dbx_symfile_read): Unconditionally call
13068 init_psymbol_list.
13069
13070 2019-01-10 Tom Tromey <tom@tromey.com>
13071
13072 * xcoffread.c (scan_xcoff_symtab): Update.
13073 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13074 "where".
13075 * mdebugread.c (parse_partial_symbols)
13076 (handle_psymbol_enumerators): Update.
13077 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13078 * dbxread.c (read_dbx_symtab): Update.
13079 * psympriv.h (psymbol_placement): New enum.
13080 (add_psymbol_to_list): Update.
13081
13082 2019-01-10 Tom Tromey <tom@tromey.com>
13083
13084 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13085 static_psymbols parameters.
13086 (scan_xcoff_symtab): Update.
13087 * psymtab.c (start_psymtab_common): Remove global_psymbols and
13088 static_psymbols parameters.
13089 * psympriv.h (start_psymtab_common): Update.
13090 * mdebugread.c (parse_partial_symbols): Update.
13091 * dwarf2read.c (create_partial_symtab): Update.
13092 * dbxread.c (read_dbx_symtab): Update.
13093 (start_psymtab): Remove global_psymbols and static_psymbols
13094 parameters.
13095
13096 2019-01-10 Tom Tromey <tom@tromey.com>
13097
13098 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13099 * psymtab.c (allocate_psymtab): Add comment.
13100 * psympriv.h (allocate_psymtab): Add comment.
13101 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13102 initializations.
13103 * dbxread.c (dbx_end_psymtab): Remove some initializations.
13104
13105 2019-01-10 Tom Tromey <tom@tromey.com>
13106
13107 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13108 Don't declare.
13109 * mipsread.c: Include mdebugread.h.
13110 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13111 Declare.
13112 * elfread.c: Include mdebugread.h.
13113
13114 2019-01-09 Tom Tromey <tom@tromey.com>
13115
13116 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13117 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13118 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13119 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13120 (psym_lookup_symbol, psym_find_last_source_symtab)
13121 (psym_forget_cached_source_info, psym_print_stats)
13122 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13123 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13124 (psym_map_matching_symbols, psym_expand_symtabs_matching)
13125 (psym_find_compunit_symtab_by_address)
13126 (maintenance_print_psymbols, maintenance_info_psymtabs)
13127 (maintenance_check_psymtabs): Use ranged for.
13128 * psymtab.h (class objfile_psymtabs): New.
13129 (require_partial_symbols): Return objfile_psymtabs.
13130 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13131
13132 2019-01-09 Tom Tromey <tom@tromey.com>
13133
13134 * symfile.c (overlay_invalidate_all, find_pc_overlay)
13135 (find_pc_mapped_section, list_overlays_command)
13136 (map_overlay_command, unmap_overlay_command)
13137 (simple_overlay_update): Use all_objfiles.
13138 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13139 * printcmd.c (info_symbol_command): Use all_objfiles.
13140 * objfiles.h (ALL_OBJSECTIONS): Remove.
13141 * maint.c (maintenance_translate_address): Use all_objfiles.
13142 * gcore.c (gcore_create_callback): Use all_objfiles.
13143 (objfile_find_memory_regions): Likewise.
13144
13145 2019-01-09 Tom Tromey <tom@tromey.com>
13146
13147 * symtab.c (find_line_symtab, info_sources_command)
13148 (make_source_files_completion_list): Use objfile_compunits.
13149 * source.c (select_source_symtab): Use objfile_compunits.
13150 * objfiles.h (struct objfile): Update comment.
13151 (ALL_OBJFILES): Remove.
13152 (ALL_FILETABS): Remove.
13153 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13154 objfile_compunits.
13155
13156 2019-01-09 Tom Tromey <tom@tromey.com>
13157
13158 * symmisc.c (print_objfile_statistics, dump_objfile)
13159 (maintenance_print_symbols): Use compunit_filetabs.
13160 * source.c (forget_cached_source_info_for_objfile): Use
13161 compunit_filetabs.
13162 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13163 (ALL_FILETABS): Use compunit_filetabs.
13164 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13165 * coffread.c (coff_symtab_read): Use compunit_filetabs.
13166
13167 2019-01-09 Tom Tromey <tom@tromey.com>
13168
13169 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13170 (compunit_filetabs): New.
13171 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13172 compunit_filetabs.
13173 (info_sources_command, make_source_files_completion_list): Remove
13174 declaration.
13175 * symmisc.c (print_objfile_statistics, dump_objfile)
13176 (maintenance_print_symbols): Remove declaration.
13177 (maintenance_info_symtabs): Use compunit_filetabs.
13178 (maintenance_info_line_tables): Likewise.
13179 * source.c (select_source_symtab): Change local variable name.
13180 (forget_cached_source_info_for_objfile): Remove declaration.
13181 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13182 * objfiles.c (objfile_relocate1): Remove declaration.
13183 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13184 declaration.
13185 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13186 * coffread.c (coff_symtab_read): Remove declaration.
13187 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13188 compunit_filetabs.
13189
13190 2019-01-09 Tom Tromey <tom@tromey.com>
13191
13192 * symtab.c (lookup_objfile_from_block)
13193 (find_pc_sect_compunit_symtab, search_symbols)
13194 (default_collect_symbol_completion_matches_break_on): Use
13195 objfile_compunits.
13196 * objfiles.h (ALL_COMPUNITS): Remove.
13197 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13198 * cp-support.c (add_symbol_overload_list_qualified): Use
13199 objfile_compunits.
13200 * ada-lang.c (ada_collect_symbol_completion_matches)
13201 (ada_add_global_exceptions): Use objfile_compunits.
13202
13203 2019-01-09 Tom Tromey <tom@tromey.com>
13204
13205 * source.c (select_source_symtab)
13206 (forget_cached_source_info_for_objfile): Remove declaration.
13207 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13208 declaration.
13209 * maint.c (count_symtabs_and_blocks): Remove declaration.
13210 * cp-support.c (add_symbol_overload_list_qualified): Remove
13211 declaration.
13212 * coffread.c (coff_symtab_read): Remove declaration.
13213 * symtab.c (lookup_symbol_in_objfile_symtabs)
13214 (basic_lookup_transparent_type_1): Use objfile_compunits.
13215 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13216 (info_sources_command, search_symbols)
13217 (default_collect_symbol_completion_matches_break_on)
13218 (make_source_files_completion_list): Remove declaration.
13219 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13220 (ada_collect_symbol_completion_matches)
13221 (ada_add_global_exceptions): Remove declaration.
13222 * linespec.c (iterate_over_all_matching_symtabs): Use
13223 objfile_compunits.
13224 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13225 (class objfile_compunits): New.
13226 (ALL_COMPUNITS): Use objfile_compunits.
13227 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13228 (maintenance_check_symtabs, maintenance_info_line_tables): Use
13229 objfile_compunits.
13230 * objfiles.c (objfile_relocate1): Use objfile_compunits.
13231
13232 2019-01-09 Tom Tromey <tom@tromey.com>
13233
13234 * symtab.c (search_symbols)
13235 (default_collect_symbol_completion_matches_break_on): Use
13236 objfile_msymbols.
13237 * ada-lang.c (ada_lookup_simple_minsym)
13238 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13239 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13240 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13241 objfile_msymbols.
13242 * coffread.c (coff_symfile_read): Use objfile_msymbols.
13243 * symmisc.c (dump_msymbols): Use objfile_msymbols.
13244 * objc-lang.c (find_methods): Use objfile_msymbols.
13245 (info_selectors_command, info_classes_command): Likewise.
13246 * stabsread.c (scan_file_globals): Use objfile_msymbols.
13247 * objfiles.h (class objfile_msymbols): New.
13248 (ALL_OBJFILE_MSYMBOLS): Remove.
13249 (ALL_MSYMBOLS): Remove.
13250
13251 2019-01-09 Tom Tromey <tom@tromey.com>
13252
13253 * common/next-iterator.h (next_adapter): Add Iterator template
13254 parameter.
13255 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13256 (class all_objfiles_safe): New.
13257 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13258 * objfiles.c (put_objfile_before): Update comment.
13259 (add_separate_debug_objfile): Likewise.
13260 (free_all_objfiles): Use all_objfiles_safe.
13261 (objfile_purge_solibs): Likewise.
13262
13263 2019-01-09 Tom Tromey <tom@tromey.com>
13264
13265 * symtab.c (iterate_over_symtabs, matching_obj_sections)
13266 (expand_symtab_containing_pc, lookup_static_symbol)
13267 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13268 (find_symbol_at_address, find_line_symtab, find_main_name): Use
13269 all_objfiles.
13270 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13271 * breakpoint.c (create_overlay_event_breakpoint)
13272 (create_longjmp_master_breakpoint)
13273 (create_std_terminate_master_breakpoint)
13274 (create_exception_master_breakpoint): Use all_objfiles.
13275 * linux-thread-db.c (try_thread_db_load_from_pdir)
13276 (has_libpthread): Use all_objfiles.
13277 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13278 * linespec.c (iterate_over_all_matching_symtabs)
13279 (search_minsyms_for_name): Use all_objfiles.
13280 * maint.c (maintenance_info_sections): Use all_objfiles.
13281 * main.c (captured_main_1): Use all_objfiles.
13282 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13283 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13284 * guile/scm-pretty-print.c
13285 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13286 * solib-spu.c (append_ocl_sos): Use all_objfiles.
13287 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13288 (maintenance_print_msymbols): Use all_objfiles.
13289 * source.c (select_source_symtab): Use all_objfiles.
13290 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13291 * symfile.c (remove_symbol_file_command)
13292 (expand_symtabs_matching, map_symbol_filenames): Use
13293 all_objfiles.
13294 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13295 all_objfiles.
13296 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13297 * objc-lang.c (find_methods): Use all_objfiles.
13298 * objfiles.c (have_partial_symbols, have_full_symbols)
13299 (have_minimal_symbols, qsort_cmp)
13300 (default_iterate_over_objfiles_in_search_order): Use
13301 all_objfiles.
13302 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13303 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13304 (maintenance_check_psymtabs): Use all_objfiles.
13305 (ALL_PSYMTABS): Remove.
13306 * compile/compile-object-run.c (do_module_cleanup): Use
13307 all_objfiles.
13308 * blockframe.c (find_pc_partial_function): Use all_objfiles.
13309 * cp-support.c (add_symbol_overload_list_qualified): Use
13310 all_objfiles.
13311 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13312 Use all_objfiles.
13313 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13314 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13315 all_objfiles.
13316 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13317 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13318 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13319 Uses all_objfiles.
13320 * solib.c (solib_read_symbols): Use all_objfiles
13321
13322 2019-01-09 Tom Tromey <tom@tromey.com>
13323
13324 * probe.c (parse_probes_in_pspace): Use all_objfiles.
13325 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13326 all_objfiles.
13327 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13328 * symmisc.c (print_symbol_bcache_statistics)
13329 (print_objfile_statistics, maintenance_print_objfiles)
13330 (maintenance_info_symtabs, maintenance_check_symtabs)
13331 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13332 all_objfiles.
13333 * source.c (forget_cached_source_info): Use all_objfiles.
13334 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13335 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13336 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13337 * objfiles.c (update_section_map): Use all_objfiles.
13338 (shared_objfile_contains_address_p): Likewise.
13339 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13340 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13341
13342 2019-01-09 Tom Tromey <tom@tromey.com>
13343
13344 * common/next-iterator.h: New file.
13345 * objfiles.h (class all_objfiles): New.
13346 (struct objfile_iterator): New.
13347
13348 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13349
13350 * NEWS: Move the description of the changed "frame", "select-frame",
13351 and "info frame" commands to the Changed commands section.
13352
13353 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
13354
13355 * gdbtypes.c (check_stub_method_group): Remove handling of old
13356 mangling schemes.
13357 * linespec.c (find_methods): Likewise.
13358 * stabsread.c (read_member_functions): Likewise.
13359 * valops.c (search_struct_method): Likewise.
13360 (value_struct_elt_for_reference): Likewise.
13361 * NEWS: Mention this change.
13362
13363 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
13364
13365 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13366 print_source_lines.
13367 * source.c (print_source_lines_base): Update line number check.
13368 (print_source_lines): New function.
13369 (source_lines_range::source_lines_range): New function.
13370 * source.h (class source_lines_range): New class.
13371 (print_source_lines): New declaration.
13372
13373 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13374
13375 * linespec.c (linespec_state_destructor): Free self->canonical_names.
13376
13377 2019-01-08 Tom Tromey <tom@tromey.com>
13378 Simon Marchi <simon.marchi@ericsson.com>
13379
13380 PR gdb/24060
13381 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13382 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13383 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13384 * f-exp.y (DOLLAR_VARIABLE): Likewise.
13385 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13386 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13387
13388 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13389
13390 * source.c (select_source_symtab): Move header comment to
13391 declaration in source.h.
13392 (forget_cached_source_info_for_objfile): Likewise.
13393 (forget_cached_source_info): Likewise.
13394 (identify_source_line): Likewise.
13395 * source.h (identify_source_line): Move declaration from symtab.h
13396 and add comment from source.c
13397 (print_source_lines): Likewise.
13398 (forget_cached_source_info_for_objfile): Likewise.
13399 (forget_cached_source_info): Likewise.
13400 (select_source_symtab): Likewise.
13401 (enum print_source_lines_flag): Move definition from symtab.h.
13402 * symtab.h (identify_source_line): Move declaration to source.h.
13403 (print_source_lines): Likewise.
13404 (forget_cached_source_info_for_objfile): Likewise.
13405 (forget_cached_source_info): Likewise.
13406 (select_source_symtab): Likewise.
13407 (enum print_source_lines_flag): Move definition to source.h.
13408 * tui/tui-hooks.c: Add 'source.h' include.
13409
13410 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13411
13412 * source.c (print_source_lines_base): Handle requests to print
13413 reverse line number sequences, and guard against empty lines
13414 string.
13415
13416 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13417
13418 * source.c (print_source_lines_base): Fix skip of '\r' if next
13419 character is '\n'.
13420
13421 2019-01-06 Tom Tromey <tom@tromey.com>
13422
13423 * c-exp.y (struct c_parse_state) <macro_original_text,
13424 expansion_obstack>: New member.
13425 (macro_original_text, expansion_obstack): Remove globals.
13426 (scan_macro_expansion, scanning_macro_expansion)
13427 (finished_macro_expansion): Update.
13428 (scan_macro_cleanup): Remove.
13429 (yylex, c_parse): Update.
13430
13431 2019-01-06 Tom Tromey <tom@tromey.com>
13432
13433 * c-exp.y (struct c_parse_state) <strings>: New member.
13434 (operator_stoken): Update.
13435
13436 2019-01-06 Tom Tromey <tom@tromey.com>
13437
13438 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
13439 (union type_stack_elt) <typelist_val>: Now a pointer to
13440 std::vector.
13441 (type_stack_cleanup): Don't declare.
13442 (push_typelist): Update.
13443 * parse.c (pop_typelist): Return a std::vector.
13444 (push_typelist): Take a std::vector.
13445 (follow_types): Update. Do not free args.
13446 (type_stack_cleanup): Remove.
13447 * c-exp.y (struct c_parse_state): New.
13448 (cpstate): New global.
13449 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13450 (nonempty_typelist): Update.
13451 (func_mod): Create a new vector.
13452 (c_parse): Create a c_parse_state.
13453 (check_parameter_typelist): Do not delete params.
13454 (function_method): Update. Do not delete type_list.
13455
13456 2019-01-06 Tom Tromey <tom@tromey.com>
13457
13458 PR gdb/28155:
13459 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13460 check_typedef.
13461 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13462 (print_return_value): Likewise.
13463
13464 2019-01-05 Tom Tromey <tom@tromey.com>
13465
13466 * contrib/cleanup_check.py: Remove.
13467 * contrib/gcc-with-excheck: Remove.
13468 * contrib/exsummary.py: Remove.
13469 * contrib/excheck.py: Remove.
13470
13471 2019-01-05 Joel Brobecker <brobecker@adacore.com>
13472
13473 * thread.c (delete_thread_1): Add gdb_assert that THR is not
13474 NULL. Initialize tpprev to NULL instead of assigning it
13475 to NULL on the next statement.
13476 * windows-nat.c (windows_delete_thread): Remove check for
13477 main_thread_id before printing thread exit notifications.
13478 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13479 Remove thread ID check against main_thread_id.
13480 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13481 windows_delete_thread.
13482 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13483
13484 2019-01-04 Tom Tromey <tom@tromey.com>
13485
13486 * compile/compile.c (_initialize_compile): Use upper case for
13487 metasyntactic variables.
13488 * symmisc.c (_initialize_symmisc): Use upper case for
13489 metasyntactic variables.
13490 * psymtab.c (_initialize_psymtab): Use upper case for
13491 metasyntactic variables.
13492 * demangle.c (demangle_command): Use upper case for metasyntactic
13493 variables.
13494 (_initialize_demangler): Likewise.
13495 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13496 variables.
13497
13498 2019-01-03 Tom Tromey <tom@tromey.com>
13499
13500 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13501
13502 2019-01-03 Tom Tromey <tom@tromey.com>
13503
13504 * python/py-symtab.c (salpy_str): Update.
13505 (struct salpy_sal_object) <symtab>: Now a PyObject.
13506 (salpy_dealloc): Update.
13507 (del_objfile_sal): Use gdbpy_ref.
13508
13509 2019-01-03 Tom Tromey <tom@tromey.com>
13510
13511 * python/py-type.c (convert_field): Use new_reference. Return
13512 gdbpy_ref.
13513 (make_fielditem): Return gdbpy_ref.
13514 (typy_fields): Update.
13515 (typy_getitem): Update.
13516 (field_name): Return gdbpy_ref. Use new_reference.
13517 (typy_iterator_iternext): Update.
13518
13519 2019-01-03 Tom Tromey <tom@tromey.com>
13520
13521 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13522
13523 2019-01-03 Tom Tromey <tom@tromey.com>
13524
13525 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13526 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13527 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13528 (pspy_set_frame_filters, pspy_set_frame_unwinders)
13529 (pspy_set_type_printers): Likewise.
13530 * python/py-function.c (fnpy_init): Use gdbpy_ref.
13531 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13532 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13533 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13534 (objfpy_set_type_printers): Likewise.
13535
13536 2019-01-03 Tom Tromey <tom@tromey.com>
13537
13538 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13539 (gdbpy_print_stack): Use gdbpy_err_fetch.
13540 * python/python-internal.h (class gdbpy_err_fetch): New class.
13541 (class gdbpy_enter) <m_error_type, m_error_value,
13542 m_error_traceback>: Remove.
13543 <m_error>: New member.
13544 (gdbpy_exception_to_string): Don't declare.
13545 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13546 * python/py-value.c (convert_value_from_python): Use
13547 gdbpy_err_fetch.
13548 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13549 gdbpy_exception_to_string.
13550 (gdbpy_handle_exception): Use gdbpy_err_fetch.
13551 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13552 gdbpy_err_fetch.
13553
13554 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13555
13556 * linux-nat.c (delete_lwp_cleanup): Delete.
13557 (struct lwp_deleter): New struct.
13558 (lwp_info_up): New typedef.
13559 (linux_nat_target::follow_fork): Delete cleanup, and make use of
13560 lwp_info_up.
13561
13562 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13563
13564 * linux-fork.c (class scoped_switch_fork_info): New class.
13565 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13566
13567 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13568
13569 * valops.c (find_overload_match): Remove use of null_cleanup, and
13570 calls to do_cleanups.
13571
13572 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13573
13574 * compile/compile-cplus-types.c
13575 (compile_cplus_instance::decl_name): Handle changes to
13576 cp_func_name.
13577 * cp-support.c (cp_func_name): Update header comment, update
13578 return type.
13579 * cp-support.h (cp_func_name): Update return type in declaration.
13580 * valops.c (find_overload_match): Move temp_func local to top
13581 level of function and change its type. Use temp_func to hold and
13582 delete temporary string obtained from cp_func_name.
13583
13584 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13585
13586 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13587 gdb::char_vector, remove cleanup, and update uses of `msg`.
13588
13589 2019-01-03 Jim Wilson <jimw@sifive.com>
13590
13591 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13592
13593 2019-01-02 Tom Tromey <tom@tromey.com>
13594
13595 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13596 (tdesc_parse_xml): Remove cleanups.
13597 * target-descriptions.h (make_cleanup_free_target_description):
13598 Don't declare.
13599 (target_desc_deleter): New struct.
13600 (target_desc_up): New typedef.
13601 * target-descriptions.c (target_desc_deleter::operator()): Rename
13602 from free_target_description.
13603 (make_cleanup_free_target_description): Remove.
13604
13605 2019-01-02 Tom Tromey <tom@tromey.com>
13606
13607 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
13608 constructor, destructor.
13609 (linespec_parser): Remove typedef.
13610 (~linespec_parser): Rename from linespec_parser_delete.
13611 (linespec_lex_to_end, linespec_complete_label)
13612 (linespec_complete): Update.
13613 (decode_line_full): Remove cleanups.
13614 (decode_line_1): Update.
13615
13616 2019-01-02 Tom Tromey <tom@tromey.com>
13617
13618 * python/python-internal.h (inferior_to_inferior_object): Change
13619 return type.
13620 * python/py-exitedevent.c (create_exited_event_object): Update.
13621 * python/py-inferior.c (inferior_to_inferior_object): Return
13622 gdbpy_ref.
13623 (python_new_inferior, python_inferior_deleted)
13624 (thread_to_thread_object, delete_thread_object)
13625 (build_inferior_list, gdbpy_selected_inferior): Update.
13626 * python/py-infthread.c (create_thread_object): Update. Also fail
13627 if inferior_to_inferior_object fails.
13628
13629 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
13630
13631 * inferior.h (class inferior) <displaced_step_state>: New field.
13632 * infrun.h (struct displaced_step_state): Move here from
13633 infrun.c. Initialize fields, add constructor.
13634 <inf>: Remove field.
13635 <reset>: New method.
13636 * infrun.c (struct displaced_step_inferior_state): Move to
13637 infrun.h.
13638 (displaced_step_inferior_states): Remove.
13639 (get_displaced_stepping_state): Adust.
13640 (displaced_step_in_progress_any_inferior): Adjust.
13641 (displaced_step_in_progress_thread): Adjust.
13642 (displaced_step_in_progress): Adjust.
13643 (add_displaced_stepping_state): Remove.
13644 (get_displaced_step_closure_by_addr): Adjust.
13645 (remove_displaced_stepping_state): Remove.
13646 (infrun_inferior_exit): Call displaced_step_state.reset.
13647 (use_displaced_stepping): Don't check for NULL.
13648 (displaced_step_prepare_throw): Call
13649 get_displaced_stepping_state.
13650 (displaced_step_fixup): Don't check for NULL.
13651 (prepare_for_detach): Don't check for NULL.
13652
13653 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13654
13655 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13656 in case of call that did not complete.
13657
13658 2019-01-02 Andrey Utkin <autkin@undo.io>
13659
13660 * symfile.c (find_separate_debug_file): Fix search of debug files for
13661 remote debuggee.
13662
13663 2019-01-02 Tom Tromey <tom@tromey.com>
13664
13665 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13666 indentation.
13667 * python/py-frame.c (frapy_older): Remove cast.
13668 (frapy_newer): Likewise.
13669 * python/py-breakpoint.c (local_setattro): Remove cast.
13670 * python/py-arch.c (archpy_name): Remove local variable.
13671 * python/py-type.c (gdbpy_lookup_type): Remove cast.
13672
13673 2019-01-02 Joel Brobecker <brobecker@adacore.com>
13674
13675 * unittests/basic_string_view/element_access/char/empty.cc:
13676 Fix year range in copyright header.
13677
13678 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
13679
13680 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13681 Delete.
13682 <operator==>: Update with for removed field.
13683 <hash>: Likewise.
13684 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13685 <isa_features>: ...this.
13686 <abi_features>: New field.
13687 (riscv_isa_flen): Update comment.
13688 (riscv_abi_xlen): New declaration.
13689 (riscv_abi_flen): New declaration.
13690 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13691 isa_features.
13692 (riscv_abi_xlen): New function.
13693 (riscv_isa_flen): Update to get answer from isa_features.
13694 (riscv_abi_flen): New function.
13695 (riscv_has_fp_abi): Update to get answer from abi_features.
13696 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13697 xlen and flen.
13698 (riscv_call_info) <xlen, flen>: Update comment.
13699 (riscv_call_arg_struct): Remove invalid assertions
13700 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13701 is removed.
13702 (riscv_gdbarch_init): Gather isa features and abi features
13703 separately, ensure both match on the gdbarch when reusing an old
13704 gdbarch. Relax an error check to allow 32-bit abi float to run on
13705 a target with 64-bit float hardware.
13706
13707 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13708
13709 * source.c (search_command_helper): Stop reverse search
13710 when line 1 has been searched.
13711
13712 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13713
13714 * record-full.c (record_full_base_target::close): Rewrite
13715 record_full_core_buf_list free logic.
13716
13717 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13718
13719 * break-catch-syscall.c (print_one_catch_syscall): xfree
13720 the last text.
13721
13722 2019-01-01 Joel Brobecker <brobecker@adacore.com>
13723
13724 * top.c (print_gdb_version): Update Copyright year in version
13725 message.
13726
13727 2019-01-01 Joel Brobecker <brobecker@adacore.com>
13728
13729 Update copyright year range in all GDB files.
13730
13731 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
13732
13733 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13734
13735 For older changes see ChangeLog-2018.
13736 \f
13737 Local Variables:
13738 mode: change-log
13739 left-margin: 8
13740 fill-column: 74
13741 version-control: never
13742 coding: utf-8
13743 End:
13744
This page took 0.286455 seconds and 5 git commands to generate.