gdb/ChangeLog

   1 2019-08-13  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (struct tui_source_window_base)
   4         <clear_detail>: No longer "override".
   5         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
   6         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
   7         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
   8         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
   9         Remove.
  10         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
  11
  12 2019-08-13  Tom Tromey  <tromey@adacore.com>
  13
  14         * tracepoint.c: Don't include readline.h or history.h.
  15
  16 2019-08-12  Tom Tromey  <tom@tromey.com>
  17
  18         * configure: Rebuild.
  19         * configure.ac: Check for readline 7.
  20         * NEWS: Mention readline 7 requirement.
  21         * README: Update.
  22
  23 2019-08-12  Tom Tromey  <tom@tromey.com>
  24
  25         * mingw-hdep.c (gdb_select): Remove readline hack.
  26
  27 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
  28
  29         * blockframe.c (find_pc_partial_function): Set *block to nullptr
  30         when the function fails.
  31
  32 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
  33
  34         * s390-tdep.c (s390_type_align): New function.
  35         (s390_gdbarch_init): Set it as type_align gdbarch method.
  36
  37 2019-08-09  Tom de Vries  <tdevries@suse.de>
  38
  39         PR gdb/24591
  40         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
  41         pc_low with relocation offset.
  42
  43 2019-08-07  Tom Tromey  <tromey@adacore.com>
  44
  45         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
  46         (print_frame_args): Update.
  47         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
  48         Update.
  49         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
  50         * frame.h (struct frame_arg): Add initializers.
  51         <error>: Now a unique_xmalloc_ptr.
  52
  53 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
  54
  55         * NEWS: Expand the Pointer Authentication entry.
  56         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
  57         (aarch64_frame_unmask_lr): ... to this.
  58         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
  59         Call aarch64_frame_unmask_lr.
  60         * frame.c (struct frame_info): Add "masked" variable.
  61         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
  62         (fprint_frame): Check for masked pc.
  63         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
  64         declarations.
  65         * python/py-framefilter.c (py_print_frame): Check for masked pc.
  66         * stack.c (print_frame): Check for masked pc.
  67
  68 2019-08-06  Tom Tromey  <tom@tromey.com>
  69
  70         * stabsread.c (patch_block_stabs, read_one_struct_field)
  71         (read_enum_type): Use obstack_strndup.
  72         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
  73         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
  74         * dwarf2read.c (guess_full_die_structure_name)
  75         (anonymous_struct_prefix): Use obstack_strndup.
  76         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
  77         * c-exp.y (yylex): Use obstack_strndup.
  78         * ada-exp.y (write_object_renaming, write_ambiguous_var)
  79         (write_var_or_type): Use obstack_strndup.
  80
  81 2019-08-06  Tom Tromey  <tom@tromey.com>
  82
  83         * symfile.c (reread_symbols): Use obstack_strdup.
  84         * stabsread.c (read_type): Use obstack_strdup.
  85         * gdb_obstack.h (obstack_strdup): New overload.
  86         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
  87         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
  88         (dwarf2_canonicalize_name): Use obstack_strdup.
  89         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
  90         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
  91         Use obstack_strdup.
  92
  93 2019-08-06  Tom Tromey  <tom@tromey.com>
  94
  95         * gdb_obstack.h (obstack_strdup): Define.
  96         * gdb_obstack.c (obstack_strdup): Don't define.
  97
  98 2019-08-06  Tom Tromey  <tom@tromey.com>
  99
 100         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 101         obstack_strdup.
 102         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 103         obstack_strdup.
 104         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 105         * stabsread.c (common_block_start): Use obstack_strdup.
 106         * objfiles.c (set_objfile_main_name, objfile): Use
 107         obstack_strdup.
 108         * namespace.c (add_using_directive): Use obstack_strdup.
 109         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 110         * jit.c (finalize_symtab): Use obstack_strdup.
 111         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 112         (guess_partial_die_structure_name, partial_die_info::fixup)
 113         (dwarf2_name): Use obstack_strdup.
 114         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 115         obstack_strdup.
 116         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 117         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 118         obstack_strdup.
 119         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 120
 121 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 122
 123         * unittests/help-doc-selftests.c: New file.
 124         * Makefile.in: Add the new file.
 125
 126 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 127
 128         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 129         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 130         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 131         the trailing '.' is not output, and the first character is uppercased.
 132         (print_help_for_command): Update call to print_doc_line.
 133         (print_doc_of_command): Likewise.
 134         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 135         * cli/cli-option.c (append_indented_doc): Do not append newline.
 136         (build_help_option): Append newline after first appended_indented_doc
 137         only if a second call is done.
 138         (build_help): Append 2 new lines before each option, except the first
 139         one.
 140         * compile/compile.c (_initialize_compile): Add new lines after
 141         %OPTIONS%, when not at the end of the help.
 142         Change help doc or code
 143         producing the help doc to respect the invariants.
 144         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 145         Also removed the new line after 'Options:', as all other commands
 146         do not put an empty line between 'Options:' and the first option.
 147         * printcmd.c (_initialize_printcmd): Likewise.
 148         * stack.c (_initialize_stack): Likewise.
 149         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 150         incorrectly telling COMMAND is optional.
 151         * ada-lang.c (_initialize_ada_language): Change help doc or code
 152         producing the help doc to respect the invariants.
 153         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 154         * breakpoint.c (_initialize_breakpoint): Likewise.
 155         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 156         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 157         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 158         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 159         _initialize_cli_style): Likewise.
 160         * corelow.c (core_target_info): Likewise.
 161         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 162         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 163         * filesystem.c (_initialize_filesystem): Likewise.
 164         * frame.c (_initialize_frame): Likewise.
 165         * gnu-nat.c (add_task_commands): Likewise.
 166         * infcall.c (_initialize_infcall): Likewise.
 167         * infcmd.c (_initialize_infcmd): Likewise.
 168         * interps.c (_initialize_interpreter): Likewise.
 169         * language.c (_initialize_language): Likewise.
 170         * linux-fork.c (_initialize_linux_fork): Likewise.
 171         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 172         * maint.c (_initialize_maint_cmds): Likewise.
 173         * memattr.c (_initialize_mem): Likewise.
 174         * printcmd.c (_initialize_printcmd): Likewise.
 175         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 176         _RegEx): Likewise.
 177         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 178         * record-btrace.c (_initialize_record_btrace): Likewise.
 179         * record-full.c (_initialize_record_full): Likewise.
 180         * record.c (_initialize_record): Likewise.
 181         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 182         * regcache.c (_initialize_regcache): Likewise.
 183         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 184         _initialize_remote): Likewise.
 185         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 186         * serial.c (_initialize_serial): Likewise.
 187         * skip.c (_initialize_step_skip): Likewise.
 188         * source.c (_initialize_source): Likewise.
 189         * stack.c (_initialize_stack): Likewise.
 190         * symfile.c (_initialize_symfile): Likewise.
 191         * symtab.c (_initialize_symtab): Likewise.
 192         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 193         * top.c (init_main): Likewise.
 194         * tracefile-tfile.c (tfile_target_info): Likewise.
 195         * tracepoint.c (_initialize_tracepoint): Likewise.
 196         * tui/tui-win.c (_initialize_tui_win): Likewise.
 197         * utils.c (add_internal_problem_command): Likewise.
 198         * valprint.c (value_print_option_defs): Likewise.
 199
 200 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 201
 202         PR build/24886
 203         * configure.ac: Drop enable-libmcheck support.
 204         * configure, config.in: Rebuild.
 205         * libmcheck.m4: Remove.
 206         * acinclude.m4: Don't include it.
 207         * Makefile.in: Don't distribute it.
 208         * top.c (print_gdb_configuration): Don't mention it.
 209
 210 2019-08-06  Tom Tromey  <tom@tromey.com>
 211
 212         * utils.c (set_output_style): Sometimes pass stream to
 213         emit_style_escape.
 214         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 215         * record-btrace.c (btrace_insn_history): Update.
 216         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 217         method.
 218         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 219         Update initializers.
 220         <m_uiout>: New field.
 221         <m_di>: Move lower.
 222         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 223         Remove "uiout" parameter.
 224         (dump_insns): Update.
 225         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 226         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 227
 228 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 229
 230         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 231         (error_in_psymtab_expansion): Likewise.
 232         (lookup_symbol_via_quick_fns): Likewise.
 233         (basic_lookup_transparent_type_quick): Likewise.
 234         (basic_lookup_transparent_type_1): Likewise.
 235
 236 2019-08-06  Tom Tromey  <tromey@adacore.com>
 237
 238         * source.c (last_source_error): Now bool.
 239         (print_source_lines_base): Make "noprint" bool.  Only open
 240         source file when last_source_visited changes.
 241
 242 2019-08-06  Tom Tromey  <tromey@adacore.com>
 243
 244         * annotate.c (annotate_source_line): Use g_source_cache.
 245         * source-cache.c (source_cache::get_plain_source_lines): Change
 246         parameters.  Populate m_offset_cache.
 247         (source_cache::ensure): New method.
 248         (source_cache::get_line_charpos): New method.
 249         (extract_lines): Move lower.  Change parameters.
 250         (source_cache::get_source_lines): Move lower.
 251         * source-cache.h (class source_cache): Update comment.
 252         <get_line_charpos>: New method.
 253         <get_source_lines>: Update comment.
 254         <clear>: Clear m_offset_cache.
 255         <get_plain_source_lines>: Change parameters.
 256         <ensure>: New method
 257         <m_offset_cache>: New member.
 258         * source.c (forget_cached_source_info_for_objfile): Update.
 259         (info_source_command): Use g_source_cache.
 260         (find_source_lines, open_source_file_with_line_charpos): Remove.
 261         (print_source_lines_base, search_command_helper): Use g_source_cache.
 262         * source.h (open_source_file_with_line_charpos): Don't declare.
 263         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 264         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 265         Use g_source_cache.
 266
 267 2019-08-06  Tom Tromey  <tromey@adacore.com>
 268
 269         * source-cache.c (source_cache::get_plain_source_lines):
 270         Remove "first_line" and "last_line" parameters.
 271         (source_cache::get_source_lines): Cache plain text.
 272         * source-cache.h (class source_cache)
 273         <get_plain_source_lines>: Update.
 274
 275 2019-08-06  Tom Tromey  <tromey@adacore.com>
 276
 277         * source-cache.c (extract_lines): No longer a method.
 278         Changed type of parameter.  Include final newline.
 279         (selftests::extract_lines_test): New function.
 280         (_initialize_source_cache): Likewise.
 281         * source-cache.h (class source_cache)
 282         <extract_lines>: Don't declare.
 283
 284 2019-08-06  Tom Tromey  <tromey@adacore.com>
 285
 286         * breakpoint.c (init_breakpoint_sal): Update.
 287         (breakpoint): Update.
 288         * breakpoint.h (struct breakpoint) <filter>: Now a
 289         unique_xmalloc_ptr.
 290
 291 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 292
 293         * NEWS: Mention dictionary access on blocks.
 294         * python/py-block.c (blpy_getitem): New function.
 295         (block_object_as_mapping): New struct.
 296         (block_object_type): Use new struct for tp_as_mapping field.
 297
 298 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 299
 300         * objfiles.h (objfile): Add a comment describing partial symbols.
 301
 302 2019-08-05  Tom Tromey  <tromey@adacore.com>
 303
 304         * compile/compile.c (_initialize_compile): Use _(), not N_().
 305         * thread.c (_initialize_thread): Use _(), not N_().
 306         * stack.c (_initialize_stack): Use _(), not N_().
 307         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 308
 309 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 310
 311         * dwarf2read.c (struct dw2_symtab_iterator):
 312         <want_specific_block>: Remove.
 313         <block_index>: Change type to gdb::optional.
 314         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 315         change type of BLOCK_INDEX parameter to gdb::optional.
 316         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 317         (dw2_lookup_symbol): Don't pass argument for
 318         WANT_SPECIFIC_BLOCK.
 319         (dw2_expand_symtabs_for_function): Don't pass argument for
 320         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 321         (class dw2_debug_names_iterator)
 322         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 323         parameter, change BLOCK_INDEX type to gdb::optional.
 324         <m_want_specific_block>: Remove.
 325         <m_block_index>: Change type to gdb::optional.
 326         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 327         gdb::optional.  Re-write in function of gdb::optional.
 328         (dw2_debug_names_lookup_symbol): Don't pass argument for
 329         WANT_SPECIFIC_BLOCK.
 330         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 331         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 332         BLOCK_INDEX.
 333
 334 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 335
 336         * NEWS: Mention changes to "info sources" command.
 337
 338 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 339
 340         * symtab.c (filename_partial_match_opts): New struct type.
 341         (struct output_source_filename_data): New members
 342         regexp, c_regexp, partial_match.
 343         (output_source_filename): Use new members to decide to print file.
 344         (info_sources_option_defs): New variable.
 345         (make_info_sources_options_def_group, print_info_sources_header,
 346         info_sources_command_completer):
 347         New functions.
 348         (info_sources_command): Read new optional arguments.
 349         (_initialize_symtab): Update info sources help.
 350
 351 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 352
 353         * ada-lang.c (exception_support_info_v0): Renamed from...
 354         (default_exception_support_info): ... this.  Create new
 355         definition for v1.
 356         (ada_has_this_exception_support): Look up catch_handlers_sym.
 357         (ada_exception_support_info_sniffer): Try v0 after default.
 358
 359 2019-08-01  Tom Tromey  <tromey@adacore.com>
 360
 361         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 362         gdbarch.h.
 363
 364 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 365
 366         * s12z-tdep.c: Fix include path for s12z-opc.h.
 367
 368 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 369
 370         * NEWS: Require GNU make 3.82.
 371
 372 2019-07-16  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 375         declare.
 376
 377 2019-07-30  Tom Tromey  <tromey@adacore.com>
 378
 379         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 380
 381 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 382
 383         * printcmd.c (print_address_symbolic): Print negative offsets.
 384         (build_address_symbolic): Force signed arithmetic when computing
 385         offset.
 386
 387 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 388
 389         PR/24474: Add a function to lookup static variables.
 390         * NEWS: Mention this new function.
 391         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 392         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 393         * python/python.c (python_GdbMethods): Add new function.
 394
 395 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 396
 397         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 398         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 399         (objfpy_lookup_static_symbol): New function.
 400         (objfile_object_methods): Add new functions.
 401
 402 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 403
 404         * NEWS: Mention 'set|show print frame-info'.  Mention new
 405         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 406         backtrace argument.  Mention that python frame filtering code
 407         is now consistent with what 'backtrace' command prints.
 408
 409 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 410
 411         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 412         comments.
 413         (print_frame_info_auto, print_frame_info_source_line,
 414         print_frame_info_location, print_frame_info_source_and_location,
 415         print_frame_info_location_and_address, print_frame_info_short_location):
 416         New declarations.
 417         (struct frame_print_options): New member print_frame_info.
 418         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 419         * stack.h (get_user_print_what_frame_info): New declaration.
 420         (frame_show_address): New declaration.
 421         * stack.c (print_frame_arguments_choices): New value 'presence'.
 422         (print_frame_info_auto, print_frame_info_source_line,
 423         print_frame_info_location, print_frame_info_source_and_location,
 424         print_frame_info_location_and_address, print_frame_info_short_location,
 425         print_frame_info_choices, print_frame_info_print_what): New definitions.
 426         (print_frame_args): Only print dots for args if print frame-arguments
 427         is 'presence'.
 428         (frame_print_option_defs): New element for "frame-info".
 429         (get_user_print_what_frame_info): New function.
 430         (frame_show_address): Make non static.  Move comment to stack.h.
 431         (print_frame_info_to_print_what): New function.
 432         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 433         to decide what to print.
 434         (backtrace_command_1): Handle the new print_frame_arguments_presence
 435         value.
 436         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 437         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 438         (py_print_frame): In non-mi mode, use LOCATION as default for
 439         print_what, similarly to frame information printed directly by
 440         backtrace command. Handle frame-info user option in non MI mode.
 441
 442 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 443
 444         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 445         Add case for debugging 32-bit target on 64-bit host.  Revise
 446         comment.
 447
 448 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 449
 450         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 451         instead of find_function_entry_range_from_pc.
 452
 453 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 454
 455         * stack.c (find_frame_funname): Remove code which preferred
 456         minsym over symtab sym in "certain pathological cases".
 457
 458         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 459         parameter.  Change type of "do_demangle" to bool.
 460         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 461         Pass suitable "prefer_sym_over_minsym" flag to
 462         build_address_symbolic().  Don't output "+" for negative offsets.
 463         * printcmd.c (print_address_symbolic): Update invocation of
 464         build_address_symbolic to include a "prefer_sym_over_minsym"
 465         flag.
 466         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 467         Restrict cases in which use of minimal symbol is preferred to that
 468         of a found symbol.  Update comments.
 469
 470         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 471         for entry pc when entry pc is out of range for that FDE.
 472
 473 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 474
 475         PR gdb/24839:
 476         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 477         type.
 478
 479 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 480
 481         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 482         this function's Python signature.
 483
 484
 485 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 486
 487         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 488         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 489         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 490         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 491         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 492
 493
 494 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 495
 496         * h8300-tdep.c (h8300_register_name_common): New.
 497         h8300_register_name): Use h8300_register_name_common.
 498         (h8300s_register_name): Likewise.
 499         (h8300sx_register_name): Likewise.
 500         (h8300h_register_nam): New.
 501         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 502
 503
 504 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 505
 506         * arm-tdep.c (arm_skip_cmse_entry): New function.
 507         (arm_is_sgstubs_section): New function.
 508         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 509
 510 2019-07-22  Tom Tromey  <tom@tromey.com>
 511
 512         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 513         Don't self-assign.
 514
 515 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 516
 517         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 518         type_print.
 519
 520 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 521
 522         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 523         so that GDB doesn't match any msymbols when searching in the
 524         TYPES_DOMAIN.
 525         (print_symbol_info): Print using typedef_print or type_print based
 526         on the type of the symbol.  Add updated FIXME comment moved from...
 527         (_initialize_symtab): ... move and update FIXME comment to above.
 528
 529 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 530
 531         * NEWS: Mention adding -q option to "info types".
 532         * symtab.c (struct info_types_options): New struct.
 533         (info_types_options_defs): New variable.
 534         (make_info_types_options_def_group): New function.
 535         (info_types_command): Use gdb::option framework to parse options.
 536         (info_types_command_completer): New function.
 537         (_initialize_symtab): Extend the help text on "info types" and
 538         register command completer.
 539
 540 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 541
 542         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 543         (lookup_symbol_in_objfile): Change int to block_enum and add a
 544         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 545
 546 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 547
 548         * MAINTAINERS (Write After Approval): Add self.
 549
 550 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 551
 552         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 553         instruction to the dummy code region.
 554
 555 2019-07-19  Tom Tromey  <tromey@adacore.com>
 556
 557         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 558         (ARGSUSED, PARAMS, __func__): Remove rules.
 559
 560 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 561
 562         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 563         * features/arm/arm-with-iwmmxt.c: Remove.
 564         * features/arm/arm-with-iwmmxt.xml: Remove.
 565         * features/arm/arm-with-m-fpa-layout.c: Remove.
 566         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 567         * features/arm/arm-with-m-vfp-d16.c: Remove.
 568         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 569         * features/arm/arm-with-m.c: Remove.
 570         * features/arm/arm-with-m.xml: Remove.
 571         * features/arm/arm-with-neon.c: Remove.
 572         * features/arm/arm-with-neon.xml: Remove.
 573         * features/arm/arm-with-vfpv2.c: Remove.
 574         * features/arm/arm-with-vfpv2.xml: Remove.
 575         * features/arm/arm-with-vfpv3.c: Remove.
 576         * features/arm/arm-with-vfpv3.xml: Remove.
 577
 578 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 579
 580         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 581
 582 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 583
 584         * arch/aarch32.c (aarch32_create_target_description): Create
 585         target descriptions using features.
 586         * arch/arm.c (arm_create_target_description)
 587         (arm_create_mprofile_target_description): Likewise.
 588         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 589
 590 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 591
 592         * Makefile.in: Add new files.
 593         * aarch32-tdep.c: New file.
 594         * aarch32-tdep.h: New file.
 595         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 596         Call aarch32_read_description.
 597         * arch/aarch32.c: New file.
 598         * arch/aarch32.h: New file.
 599         * arch/arm.c (arm_create_target_description)
 600         (arm_create_mprofile_target_description): New function.
 601         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 602         (arm_create_target_description)
 603         (arm_create_mprofile_target_description): New declaration.
 604         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 605         read_description functions.
 606         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 607         Likewise.
 608         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 609         * arm-tdep.c (tdesc_arm_list): New variable.
 610         (arm_register_g_packet_guesses): Call create description functions.
 611         (arm_read_description) (arm_read_mprofile_description): New
 612         function.
 613         * arm-tdep.h (arm_read_description)
 614         (arm_read_mprofile_description): Add declaration.
 615         * configure.tgt: Add new files.
 616
 617 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 618
 619         * top.c (new_ui_command): Open specified terminal just once.
 620
 621 2019-07-18  Tom Tromey  <tromey@adacore.com>
 622
 623         * symtab.c (main_name): Constify return type.
 624         * symfile.c (set_initial_language): Update.
 625         * symtab.h (main_name): Constify return type.
 626
 627 2019-07-17  Tom Tromey  <tom@tromey.com>
 628
 629         * tui/tui-winsource.c (tui_update_source_window)
 630         (tui_update_source_window_as_is)
 631         (tui_update_source_windows_with_line): Remove return.
 632         * tui/tui-disasm.c (tui_show_disassem)
 633         (tui_show_disassem_and_update_source): Remove return.
 634         * tui/tui.c (tui_reset): Remove return.
 635         * tui/tui-wingeneral.c
 636         (tui_check_and_display_highlight_if_needed): Remove return.
 637
 638 2019-07-17  Tom Tromey  <tom@tromey.com>
 639
 640         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 641
 642 2019-07-17  Tom Tromey  <tom@tromey.com>
 643
 644         * tui/tui-winsource.h (struct tui_exec_info_window)
 645         (struct tui_source_window_base): Move from tui-data.h.
 646         * tui/tui-winsource.c: Move many method definitions from
 647         elsewhere.  Remove "structuring" comments.
 648         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 649         (tui_source_window_base::refresh_window): Move to
 650         tui-winsource.c.
 651         * tui/tui-win.c (tui_source_window_base::refresh_all)
 652         (tui_source_window_base::update_tab_width)
 653         (tui_source_window_base::set_new_height)
 654         (tui_source_window_base::do_make_visible_with_new_height): Move to
 655         tui-winsource.c.
 656         * tui/tui-source.h: Update.
 657         * tui/tui-source.c (tui_source_window_base::reset): Move to
 658         tui-winsource.c.
 659         * tui/tui-disasm.h: Update.
 660         * tui/tui-data.h (struct tui_exec_info_window): Move to
 661         tui-winsource.h.
 662         (struct tui_source_window_base): Likewise.
 663         * tui/tui-data.c (tui_source_window_base::clear_detail)
 664         (tui_source_window_base, ~tui_source_window_base): Move to
 665         tui-winsource.c.
 666
 667 2019-07-17  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-win.c (tui_resize_all)
 670         (tui_source_window_base::update_tab_width)
 671         (tui_adjust_win_heights): Update.
 672         (tui_win_info::make_invisible_and_set_new_height): Rename from
 673         make_invisible_and_set_new_height.
 674         * tui/tui-data.h (struct tui_win_info)
 675         <make_invisible_and_set_new_height>: New method.
 676
 677 2019-07-17  Tom Tromey  <tom@tromey.com>
 678
 679         * tui/tui.c: Update.
 680         * tui/tui-source.h (struct tui_source_window): Move from
 681         tui-data.h.
 682         * tui/tui-layout.c: Update.
 683         * tui/tui-disasm.c: Update.
 684         * tui/tui-data.h (struct tui_source_window): Move to
 685         tui-source.h.
 686
 687 2019-07-17  Tom Tromey  <tom@tromey.com>
 688
 689         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 690         tui-data.h.
 691         * tui/tui-data.h (struct tui_disasm_window): Move to
 692         tui-disasm.h.
 693
 694 2019-07-17  Tom Tromey  <tom@tromey.com>
 695
 696         * tui/tui-regs.h (struct tui_data_item_window): Move from
 697         tui-data.h.
 698         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 699         * tui/tui-data.h (struct tui_data_item_window): Move to
 700         tui-regs.h.
 701         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 702
 703 2019-07-17  Tom Tromey  <tom@tromey.com>
 704
 705         * tui/tui.c: Update.
 706         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 707         (tui_cmd_window::max_height): Move to tui-command.c.
 708         * tui/tui-layout.c: Update.
 709         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 710         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 711         tui-command.c.
 712         * tui/tui-command.h (struct tui_cmd_window): Move from
 713         tui-data.h.
 714         * tui/tui-command.c: Remove "structuring" comments.
 715         (tui_cmd_window::clear_detail)
 716         (tui_cmd_window::do_make_visible_with_new_height)
 717         (tui_cmd_window::max_height): Move from elsewhere.
 718
 719 2019-07-17  Tom Tromey  <tom@tromey.com>
 720
 721         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 722         Now static.
 723         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 724         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 725
 726 2019-07-17  Tom Tromey  <tom@tromey.com>
 727
 728         * tui/tui.c: Update.
 729         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 730         tui-regs.c.
 731         * tui/tui-windata.h: Remove file.
 732         * tui/tui-windata.c: Remove file.
 733         * tui/tui-win.c (tui_data_window::set_new_height)
 734         (tui_data_window::do_make_visible_with_new_height): Move to
 735         tui-regs.c.
 736         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 737         * tui/tui-regs.c: Remove "structuring" comments.
 738         (tui_data_window::first_data_item_displayed)
 739         (tui_data_window::delete_data_content_windows)
 740         (tui_data_window::erase_data_content)
 741         (tui_data_window::display_all_data)
 742         (tui_data_window::refresh_all)
 743         (tui_data_window::do_scroll_vertical)
 744         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 745         (tui_data_window::do_make_visible_with_new_height)
 746         (tui_data_window::refresh_window): Move from elsewhere.
 747         (_initialize_tui_regs): Move to end of file.
 748         * tui/tui-layout.c: Update.
 749         * tui/tui-hooks.c: Update.
 750         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 751         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 752         tui-regs.c.
 753         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 754
 755 2019-07-17  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 758         seen.
 759
 760 2019-07-17  Tom Tromey  <tom@tromey.com>
 761
 762         * tui/tui-win.c (tui_source_window_base::set_new_height)
 763         (tui_source_window_base::do_make_visible_with_new_height): Use
 764         m_has_locator field directly.
 765         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 766         method.
 767         (struct tui_source_window_base) <has_locator>: Likewise.
 768
 769 2019-07-17  Tom Tromey  <tom@tromey.com>
 770
 771         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 772         Don't declare.
 773         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 774         Remove.
 775         * tui/tui-win.c (tui_source_window_base::set_new_height)
 776         (tui_source_window_base::set_new_height)
 777         (make_invisible_and_set_new_height)
 778         (tui_source_window_base::do_make_visible_with_new_height)
 779         (tui_source_window_base::do_make_visible_with_new_height):
 780         Update.
 781         * tui/tui-layout.c (show_source_disasm_command, show_data)
 782         (show_source_or_disasm_and_command): Update.
 783         * tui/tui-layout.c (show_layout): Update.
 784
 785 2019-07-17  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-layout.c (make_data_window): Remove.
 788         (show_data): Unify creation and re-initialization cases.
 789
 790 2019-07-17  Tom Tromey  <tom@tromey.com>
 791
 792         * tui/tui-layout.c (make_source_window, make_disasm_window):
 793         Remove.
 794         (show_data): Unify creation and re-initialization cases.
 795
 796 2019-07-17  Tom Tromey  <tom@tromey.com>
 797
 798         * tui/tui-layout.c (make_command_window): Remove.
 799         (show_source_disasm_command, show_source_or_disasm_and_command):
 800         Unify creation and re-initialization cases.
 801
 802 2019-07-17  Tom Tromey  <tom@tromey.com>
 803
 804         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 805         creation and re-initialization cases.
 806
 807 2019-07-17  Tom Tromey  <tom@tromey.com>
 808
 809         * tui/tui-regs.c (tui_get_register): Return void.
 810
 811 2019-07-17  Tom Tromey  <tom@tromey.com>
 812
 813         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 814         Simplify.
 815
 816 2019-07-17  Tom Tromey  <tom@tromey.com>
 817
 818         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 819         resetting.
 820
 821 2019-07-17  Tom Tromey  <tom@tromey.com>
 822
 823         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 824         * tui/tui-regs.c (tui_reg_layout): New function.
 825         (tui_show_registers, tui_reg_command): Use it.
 826         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 827         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 828         parameters.
 829         (tui_layout_command): Remove.
 830
 831 2019-07-17  Tom Tromey  <tom@tromey.com>
 832
 833         * tui/tui-layout.h (tui/tui-layout): Return void.
 834         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 835
 836 2019-07-17  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-layout.c (show_source_disasm_command, show_data):
 839         Update.
 840         (reset_locator): Remove.
 841         (show_source_or_disasm_and_command): Update.
 842
 843 2019-07-17  Tom Tromey  <tom@tromey.com>
 844
 845         * tui/tui-source.c (tui_source_window_base::reset): Remove
 846         win_type parameter.
 847         * tui/tui-layout.c (make_command_window, make_source_window)
 848         (make_disasm_window, make_data_window)
 849         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 850         (reset_locator, show_source_or_disasm_and_command): Update.
 851         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 852         win_type parameter.
 853         (struct tui_source_window_base) <reset>: Likewise.
 854
 855 2019-07-17  Tom Tromey  <tom@tromey.com>
 856
 857         * tui/tui-layout.c (show_source_disasm_command): Use
 858         reset_locator.
 859         (reset_locator): New function.
 860         (init_and_make_win): Remove.
 861         (show_source_or_disasm_and_command): Use reset_locator.
 862
 863 2019-07-17  Tom Tromey  <tom@tromey.com>
 864
 865         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 866         condition.
 867         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 868         Remove condition.
 869         * tui/tui-source.c (tui_source_window_base::reset): New method.
 870         * tui/tui-layout.c (make_command_window): Don't call
 871         init_and_make_win.
 872         (make_source_window, make_disasm_window): Don't call
 873         make_source_or_disasm_window.
 874         (make_data_window): Don't call init_and_make_win.  Change calling
 875         convention.
 876         (show_source_disasm_command, show_data): Simplify.
 877         (make_source_or_disasm_window): Remove.
 878         (show_source_or_disasm_and_command): Simplify.
 879         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 880         (struct tui_source_window_base) <reset>: Likewise.
 881         <execution_info>: Remove initializer.
 882         * tui/tui-data.c (tui_source_window_base): Initialize
 883         execution_info.
 884
 885 2019-07-17  Tom Tromey  <tom@tromey.com>
 886
 887         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 888         variable.
 889
 890 2019-07-17  Tom Tromey  <tom@tromey.com>
 891
 892         * tui/tui.c (tui_rl_other_window): Update.
 893         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 894         superclass method first.  Always iterate over regs_content.
 895         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 896         method.
 897         * tui/tui-win.c (tui_set_focus_command): Update.
 898
 899 2019-07-17  Tom Tromey  <tom@tromey.com>
 900
 901         * tui/tui-win.c (tui_set_focus_command): Rename from
 902         tui_set_focus.  Call tui_enable.
 903         (tui_set_focus_command): Remove.
 904
 905 2019-07-17  Tom Tromey  <tom@tromey.com>
 906
 907         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 908         refresh_window.
 909         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 910         touchwin.
 911         (tui_data_window::refresh_window): Call refresh_window on data
 912         items.  Always call superclass refresh_window.
 913         (tui_win_info::refresh): Remove.
 914         (tui_source_window_base::refresh_window): Update.
 915         (tui_refresh_all): Update.
 916         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 917         refresh_window.
 918         (show_source_or_disasm_and_command): Likewise.
 919         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 920         (struct tui_source_window_base) <refresh>: Likewise.
 921
 922 2019-07-17  Tom Tromey  <tom@tromey.com>
 923
 924         * tui/tui-winsource.c (tui_clear_source_content)
 925         (tui_show_source_content): Update.
 926         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 927         whether content is empty.
 928         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 929         Remove.
 930
 931 2019-07-17  Tom Tromey  <tom@tromey.com>
 932
 933         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 934         window's contents.
 935         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 936         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 937
 938 2019-07-17  Tom Tromey  <tom@tromey.com>
 939
 940         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 941         (struct tui_data_item_window): Update.
 942
 943 2019-07-17  Tom Tromey  <tom@tromey.com>
 944
 945         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 946         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 947         defines.
 948
 949 2019-07-17  Tom Tromey  <tom@tromey.com>
 950
 951         * tui/tui-winsource.h (tui_erase_source_content)
 952         (tui_clear_source_content): Remove "display_prompt" parameter.
 953         * tui/tui-winsource.c (tui_update_source_window_as_is)
 954         (tui_update_source_windows_with_addr): Update.
 955         (tui_clear_source_content): Remove "display_prompt" parameter.
 956         (tui_erase_source_content): Likewise.  Simplify.
 957         (tui_show_source_content): Update.
 958         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 959         * tui/tui-stack.c (tui_show_frame_info): Update.
 960         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 961         Remove defines.
 962
 963 2019-07-17  Tom Tromey  <tom@tromey.com>
 964
 965         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 966         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 967         parameter.
 968         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 969         parameter.
 970
 971 2019-07-17  Tom Tromey  <tom@tromey.com>
 972
 973         * tui/tui-winsource.c (tui_clear_source_content)
 974         (tui_show_source_content, tui_show_exec_info_content)
 975         (tui_clear_exec_info_content): Update.
 976         * tui/tui-stack.c (tui_show_locator_content): Update.
 977         (tui_show_frame_info): Update.
 978         * tui/tui-source.h (tui_source_window): Don't declare.
 979         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 980         from tui_source_is_displayed.
 981         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 982         Remove field.
 983         (struct tui_source_window_base) <content_in_use>: New field.  Now
 984         bool.
 985         (struct tui_source_window) <showing_source_p>: New method.
 986         (TUI_SRC_WIN): Change cast.
 987         * tui/tui-data.c (tui_initialize_static_data): Update.
 988
 989 2019-07-17  Tom Tromey  <tom@tromey.com>
 990
 991         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 992         location_matches_p.
 993         * tui/tui-source.c (tui_source_window::location_matches_p): New
 994         method.
 995         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 996         method.
 997         * tui/tui-data.h (struct tui_source_window_base)
 998         <location_matches_p>: New method.
 999         (struct tui_source_window, struct tui_disasm_window)
1000         <location_matches_p>: Likewise.
1001
1002 2019-07-17  Tom Tromey  <tom@tromey.com>
1003
1004         * tui/tui-win.c (tui_set_win_height_command): Rename from
1005         tui_set_win_height.
1006         (tui_set_win_height_command): Remove.
1007
1008 2019-07-17  Tom Tromey  <tom@tromey.com>
1009
1010         * tui/tui-source.c (tui_source_window): New constructor.  Add
1011         observer.
1012         (~tui_source_window): New destructor.
1013         (tui_source_window::style_changed): New method.
1014         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1015         (tui_attach_detach_observers): Update.
1016         * tui/tui-data.h (struct tui_source_window): Make constructor not
1017         inline.  Add destructor.
1018         (struct tui_source_window) <style_changed>: New method.
1019         <m_observable>: New member.
1020
1021 2019-07-17  Tom Tromey  <tom@tromey.com>
1022
1023         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1024         * tui/tui-win.c (tui_resize_all): Fix typo.
1025
1026 2019-07-17  Tom Tromey  <tom@tromey.com>
1027
1028         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1029         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1030         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1031         * tui/tui-win.c (window_name_completer): Use foreach.
1032         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1033         (update_tab_width): Likewise.
1034         * tui/tui-layout.c (show_layout): Update.
1035         * tui/tui-data.h (class tui_window_iterator): New.
1036         (struct all_tui_windows): New.
1037         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1038
1039 2019-07-17  Tom Tromey  <tom@tromey.com>
1040
1041         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1042         parameter.  Don't reference globals.
1043         (tui_reg_command): Update.
1044
1045 2019-07-17  Tom Tromey  <tom@tromey.com>
1046
1047         * tui/tui-regs.c (tui_show_registers): Simplify.
1048
1049 2019-07-17  Tom Tromey  <tom@tromey.com>
1050
1051         * tui/tui-regs.c (tui_show_registers): Update.
1052         (tui_show_register_group): Add win_info parameter.
1053
1054 2019-07-17  Tom Tromey  <tom@tromey.com>
1055
1056         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1057         Rename from tui_display_reg_element_at_line.
1058         (tui_data_window::display_registers_from_line): Update.
1059         * tui/tui-data.h (struct tui_data_window)
1060         <display_reg_element_at_line>: New method.
1061
1062 2019-07-17  Tom Tromey  <tom@tromey.com>
1063
1064         * tui/tui-regs.h (tui_display_registers_from)
1065         (tui_display_registers_from_line): Don't declare.
1066         * tui/tui-windata.c (tui_data_window::display_all_data)
1067         (tui_data_window::refresh_all)
1068         (tui_data_window::do_scroll_vertical): Update.
1069         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1070         from tui_display_registers_from.
1071         (tui_display_reg_element_at_line): Update.
1072         (tui_data_window::display_registers_from_line): Rename from
1073         tui_display_registers_from_line.
1074         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1075         display_registers_from_line>: New methods.
1076
1077 2019-07-17  Tom Tromey  <tom@tromey.com>
1078
1079         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1080         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1081         from tui_erase_data_content.
1082         (tui_data_window::display_all_data)
1083         (tui_data_window::refresh_all)
1084         (tui_data_window::do_scroll_vertical): Update.
1085         * tui/tui-regs.c (tui_show_registers): Update.
1086         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1087         New method.
1088
1089 2019-07-17  Tom Tromey  <tom@tromey.com>
1090
1091         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1092         declare.
1093         * tui/tui-windata.c
1094         (tui_data_window::delete_data_content_windows): Rename from
1095         tui_delete_data_content_windows.
1096         (tui_data_window::display_all_data)
1097         (tui_data_window::do_scroll_vertical): Update.
1098         * tui/tui-data.h (struct tui_data_window)
1099         <delete_data_content_windows>: New method.
1100
1101 2019-07-17  Tom Tromey  <tom@tromey.com>
1102
1103         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1104         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1105
1106 2019-07-17  Tom Tromey  <tom@tromey.com>
1107
1108         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1109         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1110         from tui_display_all_data.
1111         * tui/tui-win.c
1112         (tui_data_window::do_make_visible_with_new_height): Update.
1113         * tui/tui-regs.c (tui_show_registers): Update.
1114         * tui/tui-layout.c (tui_set_layout): Update.
1115         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1116         method.
1117
1118 2019-07-17  Tom Tromey  <tom@tromey.com>
1119
1120         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1121         * tui/tui-windata.c (tui_display_data_from): Remove.
1122         (tui_data_window::refresh_all): Update.
1123
1124 2019-07-17  Tom Tromey  <tom@tromey.com>
1125
1126         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1127         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1128         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1129         tui_display_registers_from_line.
1130         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1131         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1132         "force_display" parameter.
1133
1134 2019-07-17  Tom Tromey  <tom@tromey.com>
1135
1136         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1137         declare.
1138         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1139         Rename from tui_first_reg_element_no_inline.
1140         (tui_display_reg_element_at_line)
1141         (tui_display_registers_from_line): Update.
1142         * tui/tui-data.h (struct tui_data_window)
1143         <first_reg_element_no_inline>: New method.
1144
1145 2019-07-17  Tom Tromey  <tom@tromey.com>
1146
1147         * tui/tui-windata.c (tui_display_data_from)
1148         (tui_data_window::do_scroll_vertical): Update.
1149         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1150         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1151         Rename from tui_line_from_reg_element_no.
1152         (tui_display_registers_from_line): Update.
1153         * tui/tui-data.h (struct tui_data_window)
1154         <line_from_reg_element_no>: New method.
1155
1156 2019-07-17  Tom Tromey  <tom@tromey.com>
1157
1158         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1159         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1160         tui_last_regs_line_no.
1161         (tui_display_reg_element_at_line)
1162         (tui_display_registers_from_line): Update.
1163         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1164         method.
1165
1166 2019-07-17  Tom Tromey  <tom@tromey.com>
1167
1168         PR tui/24722:
1169         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1170         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1171         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1172         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1173         (tui_update_breakpoint_info): Likewise.
1174         * tui/tui-hooks.c (tui_event_create_breakpoint)
1175         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1176         Update.
1177
1178 2019-07-17  Tom Tromey  <tom@tromey.com>
1179
1180         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1181
1182 2019-07-17  Tom Tromey  <tom@tromey.com>
1183
1184         * tui/tui-winsource.c (tui_update_source_window_as_is)
1185         (tui_update_source_windows_with_addr): Update.
1186         * tui/tui-source.h (tui_set_source_content)
1187         (tui_show_symtab_source): Add "win_info" parameter.
1188         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1189         parameter.
1190         (tui_show_symtab_source): Likewise.
1191
1192 2019-07-17  Tom Tromey  <tom@tromey.com>
1193
1194         * tui/tui-wingeneral.c
1195         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1196
1197 2019-07-17  Tom Tromey  <tom@tromey.com>
1198
1199         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1200         (struct tui_cmd_window) <can_scroll>: New method.
1201         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1202         method.
1203
1204 2019-07-17  Tom Tromey  <tromey@adacore.com>
1205
1206         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1207         do_field_signed>: Rename.  Change type of "value".
1208         * ui-out.c (ui_out::field_signed): Rename from field_int.
1209         Change type of "value".
1210         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1211         type of "value".
1212         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1213         do_field_int.  Change type of "value".
1214         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1215         do_field_int.  Change type of "value".
1216         * tracepoint.c (trace_status_mi, tfind_1)
1217         (print_one_static_tracepoint_marker): Update.
1218         * thread.c (print_thread_info_1, print_selected_thread_frame):
1219         Update.
1220         * stack.c (print_frame, print_frame_info): Update.
1221         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1222         Update.
1223         * source.c (print_source_lines_base): Update.
1224         * skip.c (info_skip_command): Update.
1225         * record-btrace.c (btrace_ui_out_decode_error)
1226         (btrace_call_history_src_line): Update.
1227         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1228         Update.
1229         * progspace.c (print_program_space): Update.
1230         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1231         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1232         do_field_int.  Change type of "value".
1233         * mi/mi-out.c (mi_ui_out::do_table_begin)
1234         (mi_ui_out::do_table_header): Update.
1235         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1236         type of "value".
1237         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1238         (mi_cmd_data_list_changed_registers, output_register)
1239         (mi_cmd_data_read_memory, mi_load_progress)
1240         (mi_cmd_trace_frame_collected): Update.
1241         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1242         Update.
1243         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1244         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1245         (mi_cmd_var_list_children, varobj_update_one): Update.
1246         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1247         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1248         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1249         * inferior.c (print_inferior): Update.
1250         * gdb_bfd.c (print_one_bfd): Update.
1251         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1252         Update.
1253         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1254         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1255         do_field_int.  Change type of "value".
1256         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1257         do_field_int.  Change type of "value".
1258         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1259         (print_one_breakpoint_location, print_it_catch_fork)
1260         (print_one_catch_fork, print_it_catch_vfork)
1261         (print_one_catch_vfork, print_it_catch_solib)
1262         (print_it_catch_exec, print_it_ranged_breakpoint)
1263         (print_mention_watchpoint, print_mention_masked_watchpoint)
1264         (bkpt_print_it, update_static_tracepoint): Update.
1265         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1266         * break-catch-syscall.c (print_it_catch_syscall): Update.
1267         * ada-tasks.c (print_ada_task_info): Update.
1268         * ada-lang.c (print_it_exception, print_mention_exception):
1269         Update.
1270
1271 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1272
1273         PR breakpoints/24541
1274         * gdbarch.c: Regenerate.
1275         * gdbarch.h: Regenerate.
1276         * gdbarch.sh: Adjust return type and parameter types for
1277         'stap_adjust_register'.
1278         (i386_stap_adjust_register): Adjust signature and return new
1279         register name.
1280         * stap-probe.c (stap_parse_register_operand): Adjust use of
1281         'gdbarch_stap_adjust_register'.
1282
1283 2019-07-17  Tom Tromey  <tromey@adacore.com>
1284
1285         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1286         declare VEC.
1287         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1288         std::vector.
1289         (struct s390_process_info): Add initializers.
1290         (s390_add_process): Use new.
1291         (s390_linux_nat_target::low_forget_process): Use delete.
1292         (s390_linux_nat_target::low_new_fork)
1293         (s390_linux_nat_target::stopped_by_watchpoint)
1294         (s390_linux_nat_target::low_prepare_to_resume)
1295         (s390_linux_nat_target::insert_watchpoint)
1296         (s390_linux_nat_target::insert_hw_breakpoint)
1297         (s390_linux_nat_target::remove_watchpoint)
1298         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1299
1300 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1301
1302         * aarch64-fbsd-nat.c: Include regcache.h.
1303         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1304         argument.
1305         (aarch64_fbsd_nat_target::fetch_registers)
1306         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1307         variable.
1308         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1309
1310 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1311
1312         * fbsd-nat.c: Include gdbarch.h.
1313
1314 2019-07-15  Tom Tromey  <tromey@adacore.com>
1315
1316         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1317
1318 2019-07-15  Tom Tromey  <tromey@adacore.com>
1319
1320         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1321         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1322         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1323         * cli-out.c (cli_ui_out::do_field_int): New method.
1324         * ui-out.c (ui_out::field_unsigned): New method.
1325         * symfile.c (generic_load): Use field_unsigned.
1326         (print_transfer_performance): Likewise.
1327         * record-btrace.c (ui_out_field_uint): Remove.
1328         (btrace_call_history_insn_range, btrace_call_history): Use
1329         field_unsigned.
1330         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1331         field_unsigned.
1332         * ui-out.h (class ui_out) <field_unsigned>: New method.
1333         <do_field_unsigned>: Likewise.
1334
1335 2019-07-15  Tom Tromey  <tromey@adacore.com>
1336
1337         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1338         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1339         * target.c (flash_erase_command): Use field_string.
1340         * infrun.c (print_signal_received_reason): Use field_string.
1341         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1342         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1343         field_string.
1344         * ada-tasks.c (print_ada_task_info): Use field_string.
1345
1346 2019-07-15  Tom Tromey  <tromey@adacore.com>
1347
1348         * target.c (flash_erase_command): Use field_core_addr.
1349         * symfile.c (generic_load): Use field_core_addr.
1350         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1351         Use field_core_addr.
1352         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1353         field_core_addr.
1354
1355 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1356
1357         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1358         value if its desired type is smaller than a CORE_ADDR and signed.
1359
1360 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1361
1362         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1363         of changes to field names, and use new is_reference field to
1364         decide if a property is a reference or not.
1365         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1366         field.
1367         (struct dwarf2_property_baton): Update header comment, rename
1368         'referenced_type' to 'property_type' and update comments.
1369         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1370         default property type, store in property baton, update to take
1371         accound of renamed field.
1372         (read_func_scope): Update call to attr_to_dynamic_prop.
1373         (read_array_type): Likewise.
1374         (dwarf2_per_cu_addr_sized_int_type): New function.
1375         (read_subrange_index_type): Move type finding code to
1376         dwarf2_per_cu_addr_sized_int_type.
1377         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1378         (dwarf2_per_cu_addr_type): New function.
1379         (set_die_type): Update calls to attr_to_dynamic_prop.
1380
1381 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1382
1383         * dwarf2read.c (read_subrange_index_type): New function.
1384         (read_subrange_type): Move code into new function and call it.
1385         * gdbtypes.c (create_range_type): Add some asserts.
1386
1387 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1388
1389         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1390         update return statements.
1391         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1392         declaration, and update comment to match.
1393         * gdbtypes.c (resolve_dynamic_array): Update call to
1394         dwarf2_evaluate_property to match new return type.
1395
1396 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1397
1398         * valarith.c (value_subscripted_rvalue): Change lowerbound
1399         parameter type from int to LONGEST.
1400         * value.h (value_subscripted_rvalue): Likewise in declaration.
1401
1402 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1403
1404         * cli/cli-utils.c (info_print_command_completer): New function.
1405         * cli/cli-utils.h: Add 'completer.h' include, and forward
1406         declaration for 'struct cmd_list_element'.
1407         (info_print_command_completer): Declare.
1408         * stack.c (_initialize_stack): Add completer for 'info locals' and
1409         'info args'.
1410         * symtab.c (_initialize_symtab): Add completer for 'info
1411         variables' and 'info functions'.
1412         * NEWS: Mention completion for additional info commands.
1413
1414 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1415
1416         * cli/cli-utils.c (extract_info_print_args): Delete.
1417         (extract_arg_maybe_quoted): Delete.
1418         (info_print_options_defs): New variable.
1419         (make_info_print_options_def_group): New function.
1420         (extract_info_print_options): Define new function.
1421         * cli/cli-utils.h (extract_info_print_args): Delete.
1422         (struct info_print_options): New structure.
1423         (extract_info_print_options): Declare new function.
1424         * stack.c (info_locals_command): Update to use new
1425         extract_info_print_options, also add a header comment.
1426         (info_args_command): Likewise.
1427         * symtab.c (info_variables_command): Likewise.
1428         (info_functions_command): Likewise.
1429
1430 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1431
1432         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1433         to extract string arguments.
1434         * common/common-utils.c (extract_string_maybe_quoted): New function.
1435         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1436
1437 2019-07-11  Tom Tromey  <tromey@adacore.com>
1438
1439         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1440         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1441         * top.h (gdbinit): Don't declare.
1442         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1443         into...
1444         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1445         * top.c (gdb_init): Don't call init_cli_cmds.
1446         (gdbinit): Remove.
1447         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1448
1449 2019-07-11  Tom Tromey  <tromey@adacore.com>
1450
1451         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1452         after it has been moved.
1453
1454 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1455
1456         * valops.c (value_must_coerce_to_target): Change return type to
1457         bool.
1458         * value.h (value_must_coerce_to_target): Likewise.
1459
1460 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1461
1462         * breakpoint.c (is_hardware_watchpoint): Remove
1463         forward-declaration.
1464         (is_masked_watchpoint): Change return type to bool.
1465         (is_tracepoint): Likewise.
1466         (is_breakpoint): Likewise.
1467         (is_hardware_watchpoint): Likewise.
1468         (is_watchpoint): Likewise.
1469         (is_no_memory_software_watchpoint): Likewise.
1470         (is_catchpoint): Likewise.
1471         (breakpoint_1): Make FILTER parameter's return type bool.
1472         is_masked_watchpoint): Change return type to bool.
1473         (save_breakpoints): Make FILTER parameter's return type bool.
1474         * breakpoint.h (is_breakpoint): Change return type to bool.
1475         (is_watchpoint): Likewise.
1476         (is_catchpoint): Likewise.
1477         (is_tracepoint): Likewise.
1478
1479 2019-07-10  Tom Tromey  <tom@tromey.com>
1480
1481         * defs.h: Don't include gdbarch.h.
1482         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1483         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1484         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1485         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1486         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1487         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1488         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1489         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1490         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1491         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1492         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1493         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1494         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1495         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1496         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1497         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1498         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1499         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1500         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1501         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1502         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1503         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1504         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1505         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1506         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1507         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1508         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1509
1510 2019-07-10  Tom Tromey  <tromey@adacore.com>
1511
1512         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1513         * breakpoint.c (init_ada_exception_breakpoint): Register as
1514         bp_catchpoint.
1515         (print_one_breakpoint_location, print_one_breakpoint): Use
1516         is_ada_exception_catchpoint.
1517         * ada-lang.c (class ada_catchpoint_location): Pass
1518         bp_loc_software_breakpoint to bp_location constructor.
1519         (is_ada_exception_catchpoint): New function.
1520
1521 2019-07-10  Tom Tromey  <tromey@adacore.com>
1522
1523         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1524         VEC.
1525         (struct arm_exidx_entry): New method operator<.
1526         (struct arm_exidx_data) <section_maps>: Change type.
1527         (arm_exidx_data_free): Remove.
1528         (arm_exidx_data_key): Change type.  Move lower.
1529         (arm_exidx_new_objfile): Update.
1530         (arm_compare_exidx_entries): Remove.
1531         (arm_find_exidx_entry, _initialize_arm_tdep)
1532
1533 2019-07-10  Tom Tromey  <tromey@adacore.com>
1534
1535         * solib-spu.c (ocl_program_data_key): Change type.
1536         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1537         Update.
1538
1539 2019-07-10  Tom Tromey  <tromey@adacore.com>
1540
1541         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1542         (struct solib_aix_inferior_data) <library_list>: Change type.
1543         (solib_aix_inferior_data_handle): Change type.
1544         (get_solib_aix_inferior_data): Update.
1545         (solib_aix_free_library_list): Remove.
1546         (library_list_start_library): Update.
1547         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1548         return type.
1549         (solib_aix_get_library_list)
1550         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1551         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1552
1553 2019-07-10  Tom Tromey  <tromey@adacore.com>
1554
1555         * solib-dsbt.c (struct dsbt_info): Add initializers.
1556         (solib_dsbt_pspace_data): Change type.
1557         (dsbt_pspace_data_cleanup): Remove.
1558         (get_dsbt_info, _initialize_dsbt_solib): Update.
1559
1560 2019-07-10  Tom Tromey  <tromey@adacore.com>
1561
1562         * spu-tdep.c (spu_overlay_data): Change type.
1563         (spu_get_overlay_table, spu_overlay_new_objfile)
1564         (_initialize_spu_tdep): Update.
1565
1566 2019-07-10  Tom Tromey  <tromey@adacore.com>
1567
1568         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1569         destructor.
1570         (dbx_objfile_data_key): Change type and declare later.
1571         (DBX_SYMFILE_INFO): Rewrite.
1572         * dbxread.c (dbx_objfile_data_key): Change type.
1573         (dbx_symfile_init): Update.
1574         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1575         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1576         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1577
1578 2019-07-10  Tom Tromey  <tromey@adacore.com>
1579
1580         * jit.c (jit_program_space_key): Change type.  Move lower.
1581         (get_jit_program_space_data): Update.
1582         (jit_program_space_data_cleanup): Remove.
1583         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1584         Update.
1585         (struct jit_program_space_data): Add initializers.
1586
1587 2019-07-10  Tom Tromey  <tromey@adacore.com>
1588
1589         * solib-darwin.c (struct darwin_info): Add initializers.
1590         (solib_darwin_pspace_data): Change type.
1591         (darwin_pspace_data_cleanup): Remove.
1592         (get_darwin_info, _initialize_darwin_solib): Update.
1593
1594 2019-07-10  Tom Tromey  <tromey@adacore.com>
1595
1596         * remote-sim.c (struct sim_inferior_data): Add initializers,
1597         constructor, and destructor.
1598         (sim_inferior_data_key): Change type.  Move lower.
1599         (check_for_duplicate_sim_descriptor): Update.
1600         (get_sim_inferior_data): Use new.  Update.
1601         (~sim_inferior_data_cleanup): Rename from
1602         sim_inferior_data_cleanup.  Simplify.
1603         (gdbsim_close_inferior, simulator_command)
1604         (sim_command_completer, _initialize_remote_sim): Update.
1605         (next_pid, INITIAL_PID): Move earlier.
1606
1607 2019-07-10  Tom Tromey  <tromey@adacore.com>
1608
1609         * python/python-internal.h (create_thread_object): Return
1610         gdbpy_ref.
1611         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1612         * python/py-inferior.c (struct threadlist_entry): Add
1613         constructor.
1614         <thread_obj>: Now a gdbpy_ref.
1615         (thread_to_thread_object): Update.
1616         (add_thread_object): Use new.
1617         (delete_thread_object): Use delete.
1618         (infpy_threads): Update.
1619         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1620         GIL.
1621
1622 2019-07-10  Tom Tromey  <tromey@adacore.com>
1623
1624         * valops.c (value_cast): Specialize error message for Ada.
1625
1626 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1627
1628         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1629
1630 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1631
1632         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1633         bpstat_should_step): Return bool, adjust comments.
1634         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1635         bpstat_should_step): Likewise.
1636
1637 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1638
1639         * features/Makefile: Use feature target descriptions for Arm.
1640         * features/arm/arm-core.c: Generate new file.
1641         * features/arm/arm-fpa.c: Likewise.
1642         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1643         * features/arm/arm-m-profile.c: Likewise.
1644         * features/arm/arm-vfpv2.c: Likewise.
1645         * features/arm/arm-vfpv3.c: Likewise.
1646         * features/arm/xscale-iwmmxt.c: Likewise.
1647         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1648
1649 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1650
1651         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1652         ptrace earlier.
1653
1654 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1655
1656         * features/aarch64-pauth.c: Regenerate.
1657
1658 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1659
1660         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1661         bool.
1662         (bpstat_what): Use false instead of 0.
1663
1664 2019-07-09  Pedro Alves  <palves@redhat.com>
1665
1666         * break-catch-throw.c (is_exception_catchpoint): New.
1667         * breakpoint.c (print_one_breakpoint_location): New parameter
1668         'raw_loc'.  Handle it.  Use
1669         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1670         looking at the breakpoint's type.
1671         (print_one_breakpoint): If handling "maint info breakpoints", also
1672         print locations of exception catchpoints.
1673         * breakpoint.h (is_exception_catchpoint): Declare.
1674
1675 2019-07-09  Pedro Alves  <palves@redhat.com>
1676
1677         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1678         "addr" field.
1679         (allocate_location_exception_catchpoint): New.
1680         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1681         (initialize_throw_catchpoint_ops): Install
1682         allocate_location_exception_catchpoint as allocate_location
1683         method.
1684         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1685         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1686         bp_loc_other.
1687         (breakpoint_address_is_meaningful): Delete.
1688         (bl_address_is_meaningful): New.
1689         (breakpoint_locations_match): Adjust comment.
1690         (bp_location_from_bp_type): New, factored out of...
1691         (bp_location::bp_location(breakpoint *)): ... this.
1692         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1693         factored out of...
1694         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1695         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1696         breakpoint_address_is_meaningful.
1697         (bp_locations_compare): Adjust comment.
1698         (update_global_location_list): Use bl_address_is_meaningful
1699         instead of breakpoint_address_is_meaningful.
1700         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1701         explicit.
1702         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1703         * python/py-breakpoint.c (bppy_get_location): No longer check
1704         whether location is null.
1705
1706 2019-07-09  Pedro Alves  <palves@redhat.com>
1707
1708         PR c++/15468
1709         * breakpoint.c (print_one_breakpoint_location): Remove
1710         single-location assert.
1711
1712 2019-07-09  Tom Tromey  <tom@tromey.com>
1713
1714         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1715         * configure: Rebuild.
1716         * configure.ac: Change common to gdbsupport.
1717         * gdbsupport: Rename from common.
1718         * acinclude.m4: Change common to gdbsupport.
1719         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1720         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1721         gdbsupport.
1722         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1723         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1724         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1725         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1726         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1727         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1728         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1729         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1730         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1731         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1732         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1733         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1734         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1735         coff-pe-read.c, command.h, compile/compile-c-support.c,
1736         compile/compile-c.h, compile/compile-cplus-symbols.c,
1737         compile/compile-cplus-types.c, compile/compile-cplus.h,
1738         compile/compile-loc2c.c, compile/compile.c, completer.c,
1739         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1740         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1741         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1742         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1743         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1744         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1745         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1746         features/aarch64-core.c, features/aarch64-fpu.c,
1747         features/aarch64-pauth.c, features/aarch64-sve.c,
1748         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1749         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1750         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1751         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1752         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1753         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1754         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1755         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1756         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1757         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1758         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1759         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1760         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1761         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1762         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1763         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1764         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1765         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1766         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1767         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1768         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1769         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1770         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1771         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1772         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1773         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1774         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1775         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1776         minsyms.c, mips-linux-tdep.c, namespace.h,
1777         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1778         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1779         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1780         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1781         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1782         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1783         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1784         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1785         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1786         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1787         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1788         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1789         procfs.c, producer.c, progspace.h, psymtab.h,
1790         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1791         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1792         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1793         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1794         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1795         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1796         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1797         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1798         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1799         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1800         target-memory.c, target.c, target.h, target/waitstatus.c,
1801         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1802         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1803         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1804         unittests/array-view-selftests.c,
1805         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1806         unittests/common-utils-selftests.c,
1807         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1808         unittests/format_pieces-selftests.c,
1809         unittests/function-view-selftests.c,
1810         unittests/lookup_name_info-selftests.c,
1811         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1812         unittests/mkdir-recursive-selftests.c,
1813         unittests/observable-selftests.c,
1814         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1815         unittests/parse-connection-spec-selftests.c,
1816         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1817         unittests/scoped_fd-selftests.c,
1818         unittests/scoped_mmap-selftests.c,
1819         unittests/scoped_restore-selftests.c,
1820         unittests/string_view-selftests.c, unittests/style-selftests.c,
1821         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1822         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1823         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1824         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1825         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1826         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1827
1828 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1829
1830         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1831         bool value.
1832         (decode_digits_ordinary): Set explicit_line field in sal.
1833         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1834         symtab_and_line that was set on an explicit line number in
1835         assembler code.  Do always update the recorded symtab and line if
1836         we do skip the prologue.
1837
1838 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1839
1840         * breakpoint.c (set_breakpoint_location_function): Remove
1841         explicit_loc parameter.
1842         (momentary_breakpoint_from_master): Update call to
1843         set_breakpoint_location_function.
1844         (add_location_to_breakpoint): Likewise.
1845
1846 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1847
1848         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1849         required features based on default bfd type when no specific bfd
1850         is present.
1851
1852 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1853
1854         * NEWS: Mention that GDB printf and eval commands can now print
1855         C-style and Ada-style convenience var strings without
1856         calling the inferior.
1857         * printcmd.c (printf_c_string): Locally print GDB internal var
1858         instead of transiting via the inferior.
1859         (printf_wide_c_string): Likewise.
1860
1861 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1862
1863         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1864
1865 2019-07-04  Tom Tromey  <tom@tromey.com>
1866
1867         PR tui/24724:
1868         * tui/tui-winsource.c (tui_clear_source_content): Update.
1869         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1870         (tui_update_breakpoint_info): Update.
1871         (tui_set_exec_info_content): Update.
1872         * tui/tui-source.c (tui_set_source_content_nil): Update.
1873         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1874         has_break.
1875         * tui/tui-data.h (enum tui_bp_flag): New.
1876         (tui_bp_flags): New enum flags type.
1877         (struct tui_source_element) <break_mode>: Change type.  Rename
1878         from has_break.
1879         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1880         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1881         constants.
1882         * tui/tui-winsource.h: Fix comment.
1883
1884 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1885
1886         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1887         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1888         (store_fpregs_to_thread)
1889         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1890         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1891         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1892         (IWMMXT_REGS_SIZE): Add define.
1893         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1894         (fetch_vfp_regs, store_vfp_regs)
1895         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1896         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1897
1898 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1899
1900         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1901         defines.
1902         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1903         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1904         (ARM_INT_REGISTER_SIZE): ...to this.
1905         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1906         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1907         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1908         (arm_linux_collect_gregset, supply_nwfpe_register)
1909         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1910         defines.
1911         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1912         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1913         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1914         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1915         (arm_return_in_memory, arm_store_return_value)
1916         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1917         (arm_record_ld_st_multiple): Likewise.
1918         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1919         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1920
1921 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1922
1923         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1924         AARCH64_DISPLACED_MODIFIED_INSNS.
1925         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1926         (aarch64_displaced_step_copy_insn): Likewise.
1927         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1928         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1929         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1930         ARM_DISPLACED_MODIFIED_INSNS.
1931         * arm-tdep.c (arm_gdbarch_init): Likewise.
1932         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1933         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1934         (struct arm_displaced_step_closure): Use
1935         ARM_DISPLACED_MODIFIED_INSNS.
1936
1937 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1938
1939         * features/Makefile: Remove unused xml files.
1940         * features/aarch64.xml: Remove.
1941         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1942         * features/i386/amd64-avx-avx512.xml: Remove.
1943         * features/i386/amd64-avx-linux.xml: Remove.
1944         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1945         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1946         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1947         * features/i386/amd64-avx-mpx.xml: Remove.
1948         * features/i386/amd64-avx.xml: Remove.
1949         * features/i386/amd64-linux.xml: Remove.
1950         * features/i386/amd64-mpx-linux.xml: Remove.
1951         * features/i386/amd64-mpx.xml: Remove.
1952         * features/i386/amd64.xml: Remove.
1953         * features/i386/i386-avx-avx512-linux.xml: Remove.
1954         * features/i386/i386-avx-avx512.xml: Remove.
1955         * features/i386/i386-avx-linux.xml: Remove.
1956         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1957         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1958         * features/i386/i386-avx-mpx-linux.xml: Remove.
1959         * features/i386/i386-avx-mpx.xml: Remove.
1960         * features/i386/i386-avx.xml: Remove.
1961         * features/i386/i386-linux.xml: Remove.
1962         * features/i386/i386-mmx-linux.xml: Remove.
1963         * features/i386/i386-mmx.xml: Remove.
1964         * features/i386/i386-mpx-linux.xml: Remove.
1965         * features/i386/i386-mpx.xml: Remove.
1966         * features/i386/i386.xml: Remove.
1967         * features/i386/x32-avx-avx512-linux.xml: Remove.
1968         * features/i386/x32-avx-linux.xml: Remove.
1969         * features/i386/x32-linux.xml: Remove.
1970
1971 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1972
1973         * regformats/aarch64.dat: Remove.
1974         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1975         * regformats/i386/amd64-avx-linux.dat: Remove.
1976         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1977         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1978         * regformats/i386/amd64-linux.dat: Remove.
1979         * regformats/i386/amd64-mpx-linux.dat: Remove.
1980         * regformats/i386/amd64.dat: Remove.
1981         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1982         * regformats/i386/i386-avx-linux.dat: Remove.
1983         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1984         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1985         * regformats/i386/i386-linux.dat: Remove.
1986         * regformats/i386/i386-mmx-linux.dat: Remove.
1987         * regformats/i386/i386-mpx-linux.dat: Remove.
1988         * regformats/i386/i386.dat: Remove.
1989         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1990         * regformats/i386/x32-avx-linux.dat: Remove.
1991         * regformats/i386/x32-linux.dat: Remove.
1992
1993 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1994
1995         * aarch64-tdep.c: Remove xml self tests.
1996         * amd64-linux-tdep.c: Likewise.
1997         * amd64-tdep.c: Likewise.
1998         * i386-linux-tdep.c: Likewise.
1999         * i386-tdep.c: Likewise.
2000
2001 2019-07-03  Pedro Alves  <palves@redhat.com>
2002
2003         PR cli/24732
2004         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2005         (pipe_cmd_option_defs): New.
2006         (make_pipe_cmd_options_def_group): New.
2007         (pipe_command): Use gdb::option::process_options.
2008         (pipe_command_completer): New function.
2009         (_initialize_cli_cmds): Install completer for "pipe" command.
2010
2011 2019-07-03  Pedro Alves  <palves@redhat.com>
2012
2013         * cli/cli-option.c (union option_value) <string>: New field.
2014         (struct option_def_and_value): Add ctor, move ctor, dtor and
2015         use DISABLE_COPY_AND_ASSIGN.
2016         (option_def_and_value::clear_value): New.
2017         (parse_option, save_option_value_in_ctx, get_val_type_str)
2018         (add_setshow_cmds_for_options): Handle var_string.
2019         * cli-option.h (union option_def::var_address) <string>: New
2020         field.
2021         (struct string_option_def): New.
2022         * maint-test-options.c (struct test_options_opts): Add default
2023         ctor and use DISABLE_COPY_AND_ASSIGN.
2024         <string_opt>: New field.
2025         (test_options_opts::~test_options_opts): New.
2026         (test_options_opts::dump): Also dump "-string".
2027         (test_options_option_defs): Install "string.
2028
2029 2019-07-03  Pedro Alves  <palves@redhat.com>
2030
2031         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2032         option_value with a null enumeration.
2033         (complete_options): Save the option values in the context.
2034         (save_option_value_in_ctx): New, factored out from ...
2035         (process_options): ... here.
2036         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2037         of the function.
2038         * maint-test-options.c (test_options_opts::dump): New, factored
2039         out from ...
2040         (maintenance_test_options_command_mode): ... here.
2041         (maintenance_test_options_command_completion_result): Delete.
2042         (maintenance_test_options_command_completion_text): Update
2043         comment.
2044         (maintenance_show_test_options_completion_result): Change
2045         prototype.  Just print
2046         maintenance_test_options_command_completion_text.
2047         (save_completion_result): New.
2048         (maintenance_test_options_completer_mode): Pass options context to
2049         complete_options, and then save a dump.
2050         (_initialize_maint_test_options): Use add_cmd to install "maint
2051         show test-options-completion-result".
2052
2053 2019-07-03  Pedro Alves  <palves@redhat.com>
2054
2055         * NEWS (New commands): Mention "with" and "maint with".
2056         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2057         (with_command, with_command_completer): New.
2058         (pipe_command): Adjust to new repeat_previous
2059         interface.
2060         (_initialize_cli_cmds): Install the "with" command and its "w"
2061         alias.
2062         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2063         declarations.
2064         * cli/cli-setshow.c (parse_cli_var_uinteger)
2065         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2066         argument strings for all var_types.
2067         (get_setshow_command_value_string): New, factored out from ...
2068         (do_show_command): ... this.
2069         * cli/cli-setshow.h: Include <string>.
2070         (get_setshow_command_value_string): Declare.
2071         * command.h (repeat_previous): Now returns const char *.  Adjust
2072         comment.
2073         * maint.c: Include "cli/cli-cmds.h".
2074         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2075         (_initialize_maint_cmds): Register the "maintenance with" command.
2076         * top.c (repeat_previous): Move bits from pipe_command here:
2077         Return the saved command line, if any; error out if there's no
2078         command to relaunch.
2079
2080 2019-07-03  Pedro Alves  <palves@redhat.com>
2081
2082         * NEWS (New commands): Mention "maint set/show test-settings"
2083         instead of "maint test-settings".
2084         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2085         (maintenance_test_settings_set_list): Rename to ...
2086         (maintenance_set_test_settings_list): ... this.
2087         (maintenance_test_settings_show_list): Rename to  ...
2088         (maintenance_show_test_settings_list): ... this.
2089         (maintenance_test_settings_cmd): Delete.
2090         (maintenance_test_settings_set_cmd): ...
2091         (maintenance_set_test_settings_cmd): ... this.
2092         (maintenance_test_settings_show_cmd): ...
2093         (maintenance_show_test_settings_cmd): ... this.
2094         (maintenance_test_settings_show_value_cmd):
2095         (maintenance_show_test_settings_value_cmd): ... this.
2096         (_initialize_maint_test_settings): No longer install the "maint
2097         test-settings" prefix command.  Rename "maint test-settings set"
2098         to "maint set test-settings", and "maint test-settings show" to
2099         "maint show test-settings".  Adjust all subcommands.
2100
2101 2019-07-03  Pedro Alves  <palves@redhat.com>
2102
2103         * maint-test-settings.c: Fix file's intro comment.  Replace all
2104         references to "test-options" with references to "test-settings",
2105         in comments.
2106
2107 2019-07-03  Pedro Alves  <palves@redhat.com>
2108
2109         * maint-test-settings.c (maintenance_test_settings_xxx)
2110         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2111         New.
2112         (maintenance_test_settings_enums): Use them.
2113         (maintenance_test_settings_enum): Default to
2114         maintenance_test_settings_xxx.
2115         (_initialize_maint_test_settings): Initialize
2116         MAINTENANCE_TEST_SETTINGS_FILENAME.
2117
2118 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2119
2120         * breakpoint.h (remove_breakpoints_inf): Change return type to
2121         void, move function documentation here.
2122         * breakpoint.c (remove_breakpoints_inf): Change return type to
2123         void, move function documentation to header.
2124
2125 2019-07-02  Pedro Alves  <palves@redhat.com>
2126
2127         * NEWS (Completion improvements): Mention "info threads".
2128         * thread.c (struct info_threads_opts, info_threads_option_defs)
2129         (make_info_threads_options_def_group): New.
2130         (info_threads_command): Use gdb::option::process_options.
2131         (info_threads_command_completer): New.
2132         (_initialize_thread): Use gdb::option::build_help to build the
2133         help text for "info threads".
2134
2135 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2136
2137         * defs.h (generic_load): Move from here...
2138         * symfile.h (generic_load): ... to here.  Rename name parameter
2139         to args.
2140         * symfile.c (generic_load): Add comment.
2141
2142 2019-07-01  Tom Tromey  <tromey@adacore.com>
2143
2144         * dwarf2read.c
2145         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2146         declaration of without_params.  Fix formatting.
2147
2148 2019-07-01  Tom Tromey  <tromey@adacore.com>
2149
2150         * ada-exp.y (find_primitive_type): Update.
2151         * ada-lang.h (ada_lookup_symbol): Update.
2152         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2153         parameter.
2154         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2155
2156 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2157
2158         PR breakpoints/24541
2159         * gdbarch.c: Regenerate.
2160         * gdbarch.h: Regenerate.
2161         * gdbarch.sh: Add 'stap_adjust_register'.
2162         * i386-tdep.c: Include '<unordered_set>'.
2163         (i386_stap_adjust_register): New function.
2164         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2165         * stap-probe.c (stap_parse_register_operand): Call
2166         'gdbarch_stap_adjust_register'.
2167
2168 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2169
2170         PR python/24742
2171         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2172         * python/python.c (do_start_initialization): Use 'xmalloc'
2173         instead of 'PyMem_Malloc'.
2174
2175 2019-06-28  Tom Tromey  <tromey@adacore.com>
2176
2177         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2178         for Ada.
2179
2180 2019-06-27  Tom Tromey  <tromey@adacore.com>
2181
2182         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2183         objfile_key.
2184         (arm_find_mapping_symbol, arm_record_special_symbol)
2185         (_initialize_arm_tdep): Update.
2186         (arm_objfile_data_free): Remove.
2187
2188 2019-06-27  Tom Tromey  <tromey@adacore.com>
2189
2190         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2191         to cp_print_static_field.
2192
2193 2019-06-26  Tom Tromey  <tromey@adacore.com>
2194
2195         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2196         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2197         declare.
2198
2199 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2200
2201         * features/aarch64-core.c (create_feature_aarch64_core):
2202         Regenerate.
2203         * features/aarch64-core.xml: Add cpsr flags.
2204
2205 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2206
2207         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2208         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2209
2210 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2211
2212         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2213         field.
2214         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2215         use.
2216         (arm_record_special_symbol): Don't insert new symbol in sorted
2217         position, push it at the end.
2218
2219 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2220
2221         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2222         (arm_mapping_symbol_s): Remove.
2223         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2224         (arm_mapping_symbol_vec): New typedef.
2225         (struct arm_per_objfile): Add constructor.
2226         <section_maps>: Change type to
2227         std::unique_ptr<arm_mapping_symbol_vec[]>.
2228         (arm_compare_mapping_symbols): Remove.
2229         (arm_find_mapping_symbol): Adjust to section_maps type change.
2230         (arm_objfile_data_free): Call delete on arm_per_objfile.
2231         (arm_record_special_symbol): Adjust to section_maps type change.
2232         Allocate arm_per_objfile with new.
2233
2234 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2235
2236         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2237         with the command prefix.
2238
2239 2019-06-25  Tom Tromey  <tom@tromey.com>
2240
2241         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2242         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2243
2244 2019-06-25  Tom Tromey  <tom@tromey.com>
2245
2246         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2247         type.
2248         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2249         protected.
2250
2251 2019-06-25  Tom Tromey  <tom@tromey.com>
2252
2253         * tui/tui-winsource.c
2254         (tui_source_window_base::set_is_exec_point_at): Add check against
2255         LOA_ADDRESS.
2256
2257 2019-06-25  Tom Tromey  <tom@tromey.com>
2258
2259         * tui/tui-source.c (tui_set_source_content): Don't check before
2260         xfree.
2261         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2262
2263 2019-06-25  Tom Tromey  <tom@tromey.com>
2264
2265         * tui/tui-winsource.h (tui_update_source_window_as_is)
2266         (tui_alloc_source_buffer, tui_line_is_displayed)
2267         (tui_addr_is_displayed): Change type of win_info.
2268         * tui/tui-winsource.c (tui_update_source_window_as_is)
2269         (tui_clear_source_content, tui_show_source_line)
2270         (tui_show_source_content, tui_source_window_base::refill)
2271         (tui_source_window_base::set_is_exec_point_at)
2272         (tui_source_window_base::set_is_exec_point_at)
2273         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2274         (tui_alloc_source_buffer, tui_line_is_displayed)
2275         (tui_addr_is_displayed): Change type of win_info.  Update.
2276         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2277         (tui_source_window_base::do_make_visible_with_new_height):
2278         Update.
2279         * tui/tui-source.c (tui_set_source_content)
2280         (tui_set_source_content_nil)
2281         (tui_source_window::do_scroll_vertical): Update.
2282         * tui/tui-layout.c (show_layout): Update.
2283         * tui/tui-disasm.c (tui_set_disassem_content)
2284         (tui_disasm_window::do_scroll_vertical): Update.
2285         * tui/tui-data.h (tui_win_content): Remove.
2286         (struct tui_gen_win_info) <content, content_size>: Remove.
2287         (struct tui_source_element): Add initializers and destructor.
2288         (union tui_which_element, struct tui_win_element): Remove.
2289         (struct tui_source_window_base) <content>: New field.
2290         (struct tui_data_window): Remove destructor.
2291         (tui_alloc_content, tui_free_win_content)
2292         (tui_free_all_source_wins_content): Don't declare.
2293         * tui/tui-data.c (tui_initialize_static_data): Update.
2294         (init_content_element, tui_alloc_content): Remove.
2295         (~tui_gen_win_info): Update.
2296         (~tui_data_window, tui_free_all_source_wins_content)
2297         (tui_free_win_content, free_content, free_content_elements):
2298         Remove.
2299
2300 2019-06-25  Tom Tromey  <tom@tromey.com>
2301
2302         * tui/tui-winsource.h (tui_clear_source_content)
2303         (tui_erase_source_content, tui_show_source_content): Change type
2304         of win_info.
2305         * tui/tui-winsource.c (tui_clear_source_content)
2306         (tui_erase_source_content, tui_show_source_content): Change type
2307         of win_info.
2308         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2309         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2310         win_info.
2311         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2312         win_info.
2313         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2314
2315 2019-06-25  Tom Tromey  <tom@tromey.com>
2316
2317         * tui/tui-winsource.c (tui_clear_source_content)
2318         (tui_source_window_base::set_is_exec_point_at): Update.
2319         * tui/tui-source.c (tui_set_source_content_nil): Update.
2320         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2321         a bool.
2322         * tui/tui-data.c (init_content_element): Update.
2323
2324 2019-06-25  Tom Tromey  <tom@tromey.com>
2325
2326         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2327         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2328         * tui/tui-layout.c (init_and_make_win): Update.
2329         * tui/tui.h (enum tui_win_type): Update.
2330         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2331         tui_win_is_auxillary.
2332         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2333         tui_win_is_auxillary.
2334
2335 2019-06-25  Tom Tromey  <tom@tromey.com>
2336
2337         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2338         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2339         (tui_delete_data_content_windows, tui_display_all_data)
2340         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2341         Update.
2342         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2343         * tui/tui-regs.c (tui_last_regs_line_no)
2344         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2345         (tui_show_registers): Update.
2346         (tui_show_register_group): Return void.  Update.
2347         (tui_display_registers_from, tui_display_reg_element_at_line)
2348         (tui_display_registers_from_line, tui_check_register_values):
2349         Update.
2350         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2351         member.
2352         (struct tui_data_window) <regs_content>: Now a std::vector.
2353         <regs_content_count>: Remove.
2354         (tui_add_content_elements, tui_free_data_content): Don't declare.
2355         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2356         (init_content_element): Remove DATA_WIN case.  Add assert.
2357         (tui_add_content_elements): Remove.
2358         (tui_data_window): Update.
2359         (tui_free_data_content): Remove.
2360         (free_content_elements): Remove DATA_WIN case.
2361
2362 2019-06-25  Tom Tromey  <tom@tromey.com>
2363
2364         * tui/tui-data.c (tui_data_item_window): Update.
2365         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2366         * tui/tui-windata.c (tui_display_all_data)
2367         (tui_display_data_from_line): Update.
2368         (tui_check_data_values): Remove.
2369         * tui/tui-regs.c (tui_show_register_group)
2370         (tui_display_reg_element_at_line): Update.
2371         * tui/tui-hooks.c (tui_register_changed)
2372         (tui_refresh_frame_and_register_information): Call
2373         tui_check_register_values.
2374         * tui/tui-data.h (struct tui_data_window) <data_content,
2375         data_content_count, data_type>: Remove.
2376         (enum tui_data_type): Remove.
2377
2378         * tui/tui-data.c (tui_data_window::clear_detail)
2379         (~tui_data_window): Update.
2380
2381 2019-06-25  Tom Tromey  <tom@tromey.com>
2382
2383         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2384         declare.
2385         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2386         Rename from tui_first_data_item_displayed.  Update.
2387         (tui_data_window::refresh_all)
2388         (tui_data_window::do_scroll_vertical): Update.
2389         * tui/tui-data.h (struct tui_data_window)
2390         <first_data_item_displayed>: Declare new method.
2391
2392 2019-06-25  Tom Tromey  <tom@tromey.com>
2393
2394         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2395         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2396         contents...
2397         (tui_initialize_static_data): ...here.
2398
2399 2019-06-25  Tom Tromey  <tom@tromey.com>
2400
2401         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2402         (tui_display_registers_from, tui_check_register_values): Update.
2403         (tui_display_register): Remove win_info parameter; update.
2404         (tui_get_register): Change type of parameters.
2405         * tui/tui-data.h (struct tui_data_element): Remove.
2406         (union tui_which_element) <data>: Remove.
2407         <data_window>: Change type.
2408         (struct tui_data_item_window): New.
2409         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2410         case.  Add assert.
2411         (~tui_data_item_window): New destructor.
2412         (free_content_elements): Remove DATA_ITEM_WIN case.
2413
2414 2019-06-25  Tom Tromey  <tom@tromey.com>
2415
2416         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2417         Remove.
2418
2419 2019-06-25  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui-data.h (struct tui_command_element): Remove.
2422         (union tui_which_element) <command>: Remove.
2423         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2424         assert.
2425         (free_content_elements): Remove CMD_WIN case.
2426
2427 2019-06-25  Tom Tromey  <tom@tromey.com>
2428
2429         * tui/tui-layout.c (tui_set_layout): Update.
2430         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2431         * tui/tui-data.c (layout_def): Update.
2432
2433 2019-06-25  Tom Tromey  <tom@tromey.com>
2434
2435         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2436         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2437         (tui_source_window_base::set_new_height): Update.
2438         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2439         Update.
2440         (tui_set_locator_fullname, tui_set_locator_info)
2441         (tui_show_frame_info): Update.
2442         * tui/tui-source.c (tui_set_source_content)
2443         (tui_source_is_displayed): Update.
2444         * tui/tui-layout.c (show_source_disasm_command, show_data)
2445         (show_source_or_disasm_and_command): Update.
2446         * tui/tui-disasm.c (tui_set_disassem_content)
2447         (tui_get_begin_asm_address): Update.
2448         * tui/tui-data.h (struct tui_locator_element): Remove.
2449         (union tui_which_element) <locator>: Remove.
2450         (struct tui_locator_window): New.
2451         (tui_locator_win_info_ptr): Change return type.
2452         * tui/tui-data.c (_locator): Change type.
2453         (tui_locator_win_info_ptr): Change return type.
2454         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2455         (tui_alloc_content): Add assert.
2456
2457 2019-06-25  Tom Tromey  <tom@tromey.com>
2458
2459         * tui/tui-winsource.c
2460         (tui_exec_info_window::maybe_allocate_content): New method.
2461         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2462         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2463         (make_source_or_disasm_window): Add cast.
2464         * tui/tui-data.h (union tui_which_element) <simple_string>:
2465         Remove.
2466         (struct tui_source_info): New.
2467         (struct tui_source_window_base) <execution_info>: Change type.
2468         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2469         case, and add assert.
2470         (tui_alloc_content): Add assert.
2471
2472 2019-06-25  Tom Tromey  <tom@tromey.com>
2473
2474         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2475         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2476         * tui/tui-data.c (tui_alloc_win_info): Remove.
2477
2478 2019-06-25  Tom Tromey  <tom@tromey.com>
2479
2480         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2481         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2482         can_highlight.
2483
2484 2019-06-25  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2487         make_visible_with_new_height method.
2488         (tui_win_info::make_visible_with_new_height): New method.
2489         (tui_source_window_base::do_make_visible_with_new_height)
2490         (tui_data_window::do_make_visible_with_new_height)
2491         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2492         (make_visible_with_new_height): Remove.
2493         (tui_resize_all, tui_adjust_win_heights): Use
2494         make_visible_with_new_height method.
2495         * tui/tui-data.h (struct tui_win_info)
2496         <do_make_visible_with_new_height, make_visible_with_new_height>:
2497         New methods.
2498         (struct tui_source_window_base, struct tui_data_window)
2499         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2500         methods.
2501
2502 2019-06-25  Tom Tromey  <tom@tromey.com>
2503
2504         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2505         method.
2506         (update_tab_width): Call update_tab_width method.
2507         * tui/tui-data.h (struct tui_win_info)
2508         (struct tui_source_window_base) <update_tab_width>: New methods.
2509
2510 2019-06-25  Tom Tromey  <tom@tromey.com>
2511
2512         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2513         parameter.
2514         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2515         parameter.
2516         (tui_gen_win_info::make_visible): Update.
2517         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2518         parameter.
2519         * tui/tui-data.h (enum tui_box): New enum.
2520         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2521
2522 2019-06-25  Tom Tromey  <tom@tromey.com>
2523
2524         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2525         init_and_make_win for EXEC_INFO_WIN.
2526         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2527         longer inline.
2528         (struct tui_win_info) <~tui_win_info>: Inline.
2529         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2530         Don't declare.
2531         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2532         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2533         Remove.
2534         (tui_initialize_static_data): Update.
2535         (~tui_gen_win_info): Handle more cleanup here.
2536         (~tui_source_window_base): Delete "execution_info".
2537         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2538
2539 2019-06-25  Tom Tromey  <tom@tromey.com>
2540
2541         * tui/tui-layout.c (make_command_window): Don't set
2542         can_highlight.
2543         (show_source_disasm_command): Call the reset method.
2544         (show_data): Don't set can_highlight.  Call the reset method.
2545         (tui_gen_win_info::reset): Rename from init_gen_win_info
2546         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2547         (show_source_or_disasm_and_command): Call the reset method.
2548         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2549         (struct tui_cmd_window): Set can_highlight.
2550
2551 2019-06-25  Tom Tromey  <tom@tromey.com>
2552
2553         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2554         from make_visible.
2555         (tui_make_visible, tui_make_invisible): Rewrite.
2556         (tui_win_info::make_visible): Remove.
2557         (tui_source_window_base::make_visible): Update.
2558         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2559         method.  Moved from...
2560         (struct tui_win_info) <make_visible>: ...here.
2561
2562 2019-06-25  Tom Tromey  <tom@tromey.com>
2563
2564         * tui/tui-winsource.c
2565         (tui_source_window_base::do_scroll_horizontal): Remove direction
2566         parameter.
2567         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2568         direction parameter.
2569         * tui/tui-win.c (tui_win_info::forward_scroll)
2570         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2571         (tui_win_info::right_scroll): Update.
2572         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2573         direction parameter.
2574         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2575         direction parameter.
2576         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2577         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2578         Remove direction parameter.
2579         (struct tui_source_window_base, struct tui_source_window)
2580         (struct tui_disasm_window, struct tui_data_window)
2581         (struct tui_cmd_window): Update.
2582
2583 2019-06-25  Tom Tromey  <tom@tromey.com>
2584
2585         * tui/tui-winsource.h (tui_set_exec_info_content)
2586         (tui_show_exec_info_content, tui_erase_exec_info_content)
2587         (tui_clear_exec_info_content, tui_update_exec_info): Change
2588         argument to tui_source_window_base.
2589         * tui/tui-winsource.c (tui_set_exec_info_content)
2590         (tui_show_exec_info_content, tui_erase_exec_info_content)
2591         (tui_clear_exec_info_content, tui_update_exec_info): Change
2592         argument to tui_source_window_base.
2593
2594 2019-06-25  Tom Tromey  <tom@tromey.com>
2595
2596         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2597         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2598
2599 2019-06-25  Tom Tromey  <tom@tromey.com>
2600
2601         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2602         check.
2603
2604 2019-06-25  Tom Tromey  <tom@tromey.com>
2605
2606         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2607         type to void.
2608         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2609         type to void.
2610         * tui/tui-source.c (tui_set_source_content): Update.
2611         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2612
2613 2019-06-25  Tom Tromey  <tom@tromey.com>
2614
2615         * tui/tui-win.c (window_name_completer, tui_set_focus)
2616         (tui_all_windows_info): Use name method.
2617         * tui/tui-data.h (struct tui_gen_win_info)
2618         (struct tui_source_window, struct tui_disasm_window)
2619         (struct tui_data_window, struct tui_cmd_window) <name>: New
2620         method.
2621         (tui_win_name): Don't declare.
2622         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2623         (tui_win_name): Remove.
2624
2625 2019-06-25  Tom Tromey  <tom@tromey.com>
2626
2627         * tui/tui-winsource.h (tui_update_source_window)
2628         (tui_update_source_window_as_is): Change parameter type.
2629         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2630         to be a tui_source_window_base.
2631         (tui_update_source_window_as_is): Likewise.
2632         * tui/tui-win.c (make_visible_with_new_height): Update.
2633
2634 2019-06-25  Tom Tromey  <tom@tromey.com>
2635
2636         * tui/tui-winsource.c (tui_erase_source_content)
2637         (tui_show_source_content, tui_show_exec_info_content)
2638         (tui_erase_exec_info_content): Use refresh_window method.
2639         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2640         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2641         from tui_refresh_win.
2642         (tui_data_window::refresh_window): New method.
2643         (tui_win_info::refresh, tui_source_window_base::refresh)
2644         (tui_refresh_all): Use refresh_window method.
2645         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2646         method.
2647         * tui/tui-regs.c (tui_display_register): Call refresh_window
2648         method.
2649         * tui/tui-layout.c (show_source_disasm_command)
2650         (show_source_or_disasm_and_command): Call refresh_window method.
2651         * tui/tui-data.h (struct tui_gen_win_info)
2652         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2653         New method.
2654
2655 2019-06-25  Tom Tromey  <tom@tromey.com>
2656
2657         * tui/tui.c (tui_rl_other_window, tui_enable)
2658         (tui_is_window_visible, tui_get_command_dimension): Update.
2659         * tui/tui-winsource.c (tui_update_source_window_as_is)
2660         (tui_clear_source_content, tui_erase_source_content)
2661         (tui_show_source_line, tui_source_window_base::refill)
2662         (tui_source_window_base::do_scroll_horizontal)
2663         (tui_source_window_base::set_is_exec_point_at)
2664         (tui_update_breakpoint_info, tui_set_exec_info_content)
2665         (tui_alloc_source_buffer, tui_line_is_displayed)
2666         (tui_addr_is_displayed): Update.
2667         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2668         (tui_check_and_display_highlight_if_needed)
2669         (tui_win_info::make_visible, tui_win_info::refresh)
2670         (tui_refresh_all): Update.
2671         * tui/tui-windata.c (tui_first_data_item_displayed)
2672         (tui_delete_data_content_windows, tui_erase_data_content)
2673         (tui_display_all_data, tui_data_window::refresh_all)
2674         (tui_check_data_values): Update.
2675         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2676         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2677         (tui_win_info::backward_scroll, tui_refresh_all_win)
2678         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2679         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2680         (tui_source_window_base::set_new_height)
2681         (tui_data_window::set_new_height)
2682         (make_invisible_and_set_new_height)
2683         (make_visible_with_new_height, new_height_ok)
2684         (parse_scrolling_args): Update.
2685         * tui/tui-stack.c (tui_show_frame_info): Update.
2686         * tui/tui-source.c (tui_set_source_content)
2687         (tui_set_source_content_nil, tui_source_is_displayed)
2688         (tui_source_window::do_scroll_vertical): Update.
2689         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2690         (tui_display_registers_from, tui_display_reg_element_at_line)
2691         (tui_check_register_values, tui_reg_command): Update.
2692         * tui/tui-layout.c (tui_default_win_height)
2693         (show_source_disasm_command, show_data, init_and_make_win)
2694         (show_source_or_disasm_and_command): Update.
2695         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2696         (tui_redisplay_readline, tui_mld_flush)
2697         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2698         (tui_getc): Update.
2699         * tui/tui-disasm.c (tui_set_disassem_content)
2700         (tui_disasm_window::do_scroll_vertical): Update.
2701         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2702         Now virtual.
2703         (struct tui_win_info): Derive from tui_gen_win_info.
2704         <~tui_win_info>: Mark as override.
2705         <generic>: Remove member.
2706         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2707         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2708         (~tui_data_window, ~tui_win_info)
2709         (tui_free_all_source_wins_content): Update.
2710         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2711
2712 2019-06-25  Tom Tromey  <tom@tromey.com>
2713
2714         * tui/tui-layout.c (init_and_make_win): Use new.
2715         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2716         destructor, initializers.
2717         (tui_alloc_generic_win_info): Don't declare.
2718         * tui/tui-data.c (_locator): Add argument to constructor.
2719         (source_win, disasm_win): New globals.
2720         (exec_info): Remove.
2721         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2722         Update.
2723         (tui_alloc_generic_win_info): Remove.
2724         (init_content_element): Use new.
2725         (tui_win_info::tui_win_info): Update.
2726         (free_content_elements) <case DATA_WIN>: Use delete.
2727
2728 2019-06-25  Tom Tromey  <tom@tromey.com>
2729
2730         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2731         * tui/tui-windata.c (tui_first_data_item_displayed)
2732         (tui_delete_data_content_windows): Update.
2733         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2734         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2735         (tui_display_registers_from, tui_check_register_values): Update.
2736         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2737         pointer.
2738         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2739         window.
2740         (tui_free_data_content): Update.
2741         (free_content_elements) <case DATA_WIN>: Free the window.
2742
2743 2019-06-25  Tom Tromey  <tom@tromey.com>
2744
2745         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2746         Update.
2747         * tui/tui-layout.c (make_command_window)
2748         (show_source_disasm_command, show_data, init_and_make_win)
2749         (show_source_or_disasm_and_command): Update.
2750         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2751         method.
2752         <can_highight, is_highlighted>: Now bool.
2753         (tui_set_win_highlight): Don't declare.
2754         * tui/tui-data.c (tui_set_win_highlight): Remove.
2755
2756 2019-06-25  Tom Tromey  <tom@tromey.com>
2757
2758         * tui/tui-wingeneral.c (make_visible): Remove check of window
2759         type.
2760
2761 2019-06-25  Tom Tromey  <tom@tromey.com>
2762
2763         * tui/tui-win.c (tui_win_info::max_height)
2764         (tui_cmd_window::max_height): New methods.
2765         (new_height_ok): Call max_height.
2766         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2767         <max_height>: New method.
2768
2769 2019-06-25  Tom Tromey  <tom@tromey.com>
2770
2771         * tui/tui-win.c (tui_source_window_base::set_new_height)
2772         (tui_data_window::set_new_height): New methods.
2773         (make_invisible_and_set_new_height): Call set_new_height method.
2774         * tui/tui-data.h (struct tui_win_info)
2775         (struct tui_source_window_base, struct tui_data_window)
2776         <set_new_height>: New method.
2777
2778 2019-06-25  Tom Tromey  <tom@tromey.com>
2779
2780         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2781         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2782         tui_refresh_data_win.
2783         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2784         method.
2785         (tui_refresh_all_win): Call the refresh_all method.
2786         (tui_set_focus): Likewise.
2787         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2788         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2789         Likewise.
2790
2791 2019-06-25  Tom Tromey  <tom@tromey.com>
2792
2793         * tui/tui-winsource.h (tui_refill_source_window)
2794         (tui_set_is_exec_point_at): Don't declare.
2795         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2796         (tui_source_window_base::refill): Rename from
2797         tui_refill_source_window.
2798         (tui_source_window_base::do_scroll_horizontal): Update.
2799         (tui_source_window_base::set_is_exec_point_at): Rename from
2800         tui_set_is_exec_point_at.
2801         (tui_update_all_breakpoint_info): Update.
2802         * tui/tui-stack.c (tui_show_frame_info): Update.
2803         * tui/tui-layout.c (show_data): Add cast.
2804         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2805         * tui/tui-data.h (struct tui_source_window_base) <refill,
2806         set_is_exec_point_at>: New methods.
2807         (tui_source_windows, tui_add_to_source_windows): Update types.
2808         (tui_add_to_source_windows): Remove redundant declaration.
2809         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2810         (tui_source_windows): Change return type.
2811         (tui_clear_source_windows_detail): Update.
2812         (tui_add_to_source_windows): Change type of parameter.
2813         (tui_free_all_source_wins_content): Update.
2814
2815 2019-06-25  Tom Tromey  <tom@tromey.com>
2816
2817         * tui/tui-wingeneral.c (tui_win_info::refresh)
2818         (tui_source_window_base::refresh): New methods.
2819         (tui_refresh_all): Call the refresh method.
2820         * tui/tui-data.h (struct tui_win_info)
2821         (struct tui_source_window_base) <refresh>: New method.
2822
2823 2019-06-25  Tom Tromey  <tom@tromey.com>
2824
2825         * tui/tui.h (tui_is_window_visible): Return bool.
2826         * tui/tui.c (tui_is_window_visible): Return bool.
2827         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2828         (tui_make_visible, tui_make_invisible)
2829         (tui_win_info::make_visible)
2830         (tui_source_window_base::make_visible, make_all_visible)
2831         (tui_make_all_visible, tui_make_all_invisible): Update.
2832         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2833         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2834         bool.
2835         (struct tui_win_info, struct tui_source_window_base)
2836         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2837         * tui/tui-data.c (tui_init_generic_part): Update.
2838
2839 2019-06-25  Tom Tromey  <tom@tromey.com>
2840
2841         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2842         (tui_source_window_base::make_visible): New methods.
2843         (make_all_visible): Make method call.
2844         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2845         (struct tui_source_window_base, struct tui_cmd_window): Override
2846         make_visible.
2847         (tui_win_is_source_type): Don't declare.
2848         * tui/tui-data.c (tui_win_is_source_type): Remove.
2849
2850 2019-06-25  Tom Tromey  <tom@tromey.com>
2851
2852         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2853         NULL check.
2854
2855 2019-06-25  Tom Tromey  <tom@tromey.com>
2856
2857         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2858         Inline constructor.  Add initializers for members.
2859         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2860         constructors; now inline in class.
2861
2862 2019-06-25  Tom Tromey  <tom@tromey.com>
2863
2864         * tui/tui-regs.c (tui_show_registers): Update.
2865         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2866         bool.
2867         * tui/tui-data.c (tui_data_window::clear_detail)
2868         (tui_data_window): Update.
2869
2870 2019-06-25  Tom Tromey  <tom@tromey.com>
2871
2872         * tui/tui-windata.c (tui_display_all_data)
2873         (tui_display_data_from_line, tui_display_data_from)
2874         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2875         Update.
2876         * tui/tui-regs.c (tui_last_regs_line_no)
2877         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2878         (tui_show_registers, tui_show_register_group)
2879         (tui_display_registers_from, tui_display_reg_element_at_line)
2880         (tui_display_registers_from_line, tui_check_register_values)
2881         (tui_reg_next, tui_reg_prev): Update.
2882         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2883         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2884         tui_data_window.
2885         (struct tui_win_info) <detail>: Remove.  Add new fields from
2886         tui_data_info.
2887         (TUI_DATA_WIN): Add cast.
2888         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2889         (~tui_data_window): Simplify.
2890
2891 2019-06-25  Tom Tromey  <tom@tromey.com>
2892
2893         * tui/tui-layout.c (show_source_disasm_command)
2894         (show_source_or_disasm_and_command): Update.
2895         * tui/tui-io.c (update_cmdwin_start_line)
2896         (tui_redisplay_readline): Update.
2897         * tui/tui-data.h (struct tui_command_info): Remove.
2898         (struct tui_win_info) <detail>: Remove command_info member.
2899         (struct tui_data_window) <start_line>: New member, from
2900         tui_command_info.
2901         (TUI_CMD_WIN): Add casts.
2902
2903 2019-06-25  Tom Tromey  <tom@tromey.com>
2904
2905         * tui/tui-winsource.c (tui_update_source_window)
2906         (tui_refill_source_window)
2907         (tui_source_window_base::do_scroll_horizontal)
2908         (tui_update_breakpoint_info, tui_set_exec_info_content)
2909         (tui_show_exec_info_content, tui_erase_exec_info_content)
2910         (tui_clear_exec_info_content): Update.
2911         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2912         Update.
2913         * tui/tui-win.c (make_invisible_and_set_new_height)
2914         (make_visible_with_new_height): Update.
2915         * tui/tui-source.c (tui_set_source_content)
2916         (tui_show_symtab_source): Update.
2917         * tui/tui-layout.c (extract_display_start_addr)
2918         (show_source_disasm_command, show_data)
2919         (make_source_or_disasm_window)
2920         (show_source_or_disasm_and_command): Update.
2921         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2922         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2923         "gdbarch".
2924         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2925         to tui_source_window_base.
2926         (struct tui_win_info) <detail>: Remove source_info member.
2927         (struct tui_source_window_base) <has_locator>: Inline.
2928         Move contents from tui_source_info; rename has_locator member to
2929         m_has_locator.
2930         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2931         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2932         header file.
2933         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2934         Simplify.
2935         (tui_free_all_source_wins_content): Cast to
2936         tui_source_window_base.
2937
2938 2019-06-25  Tom Tromey  <tom@tromey.com>
2939
2940         * tui/tui-win.c (make_invisible_and_set_new_height)
2941         (make_visible_with_new_height): Call has_locator method.
2942         * tui/tui-layout.c (show_source_disasm_command, show_data)
2943         (show_source_or_disasm_and_command): Update for bool change.
2944         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2945         (tui_win_info) <has_locator>: New method.
2946         (struct tui_source_window_base) <has_locator>: New method.
2947         (tui_win_has_locator): Don't declare.
2948         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2949         from tui_win_has_locator.
2950         (tui_source_window_base): Use false, not FALSE.
2951
2952 2019-06-25  Tom Tromey  <tom@tromey.com>
2953
2954         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2955         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2956         clear_detail method directly.
2957         (tui_clear_win_detail): Remove.
2958
2959 2019-06-25  Tom Tromey  <tom@tromey.com>
2960
2961         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2962         "this", not TUI_DISASM_WIN.
2963
2964 2019-06-25  Tom Tromey  <tom@tromey.com>
2965
2966         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2967         declare.
2968         * tui/tui-winsource.c
2969         (tui_source_window_base::do_scroll_horizontal): Rename from
2970         tui_horizontal_source_scroll.
2971         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2972         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2973         from tui_vertical_data_scroll.
2974         * tui/tui-win.h (tui_scroll): Don't declare.
2975         * tui/tui-win.c (tui_win_info::forward_scroll)
2976         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2977         (tui_win_info::right_scroll): Rename and update.
2978         (tui_scroll_forward_command, tui_scroll_backward_command)
2979         (tui_scroll_left_command, tui_scroll_right_command): Update.
2980         (tui_scroll): Remove.
2981         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2982         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2983         from tui_vertical_source_scroll.
2984         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2985         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2986         from tui_vertical_disassem_scroll.
2987         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2988         do_scroll_horizontal>: New methods.
2989         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2990         Likewise.
2991         (struct tui_source_window_base): Add do_scroll_horizontal.
2992         (struct tui_source_window, struct tui_disasm_window): Add
2993         do_scroll_vertical.
2994         (struct tui_data_window, struct tui_cmd_window): Add
2995         do_scroll_horizontal and do_scroll_vertical.
2996         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2997
2998 2019-06-25  Tom Tromey  <tom@tromey.com>
2999
3000         * tui/tui-data.h (struct tui_source_window_base): New struct.
3001         (struct tui_source_window): Derive from tui_source_window_base.
3002         (struct tui_disasm_window): New struct.
3003         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3004         from tui_source_window::clear_detail.
3005         (tui_source_window_base): Rename from tui_source_window.
3006         (~tui_source_window_base): Rename from ~tui_source_window.
3007         (tui_alloc_win_info): Create a tui_disasm_window.
3008
3009 2019-06-25  Tom Tromey  <tom@tromey.com>
3010
3011         * tui/tui-data.h (struct tui_source_window)
3012         (struct tui_data_window): Declare destructors.
3013         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3014         destructors.
3015         (tui_win_info): Simplify.
3016
3017 2019-06-25  Tom Tromey  <tom@tromey.com>
3018
3019         * tui/tui-winsource.c (tui_display_main)
3020         (tui_update_source_windows_with_addr)
3021         (tui_update_all_breakpoint_info): Update.
3022         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3023         (new_height_ok, parse_scrolling_args): Update.
3024         * tui/tui-stack.c (tui_show_frame_info): Update.
3025         * tui/tui-data.h (struct tui_list): Remove.
3026         (tui_source_windows): Return a reference to a std::vector.
3027         * tui/tui-data.c (source_windows): Now a std::vector.
3028         (tui_source_windows): Change return type.
3029         (tui_clear_source_windows): Rewrite.
3030         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3031         (tui_free_all_source_wins_content): Rewrite.
3032
3033 2019-06-25  Tom Tromey  <tom@tromey.com>
3034
3035         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3036         (struct tui_data_window, struct tui_cmd_window): Declare
3037         clear_detail method.
3038         * tui/tui-data.c (tui_source_window::clear_detail)
3039         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3040         methods.
3041         (tui_clear_win_detail): Simplify.
3042
3043 2019-06-25  Tom Tromey  <tom@tromey.com>
3044
3045         * tui/tui-layout.c (make_source_window, make_disasm_window)
3046         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3047         Return the new window.
3048         (show_source_disasm_command, show_data)
3049         (show_source_or_disasm_and_command): Update.
3050
3051 2019-06-25  Tom Tromey  <tom@tromey.com>
3052
3053         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3054         parameter.  Return the new window.
3055         (show_source_disasm_command): Update and remove NULL check.
3056         (show_source_or_disasm_and_command): Update.
3057
3058 2019-06-25  Tom Tromey  <tom@tromey.com>
3059
3060         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3061
3062 2019-06-25  Tom Tromey  <tom@tromey.com>
3063
3064         * tui/tui-data.h (struct tui_win_info): Make constructor
3065         protected.  Make destructor virtual.  Add initializers.
3066         (tui_source_window, tui_data_window, tui_cmd_window): New
3067         classes.
3068         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3069         constructor.  Add "type" parameter.
3070         (tui_source_window, tui_data_window, tui_cmd_window): New
3071         constructors.
3072         (tui_alloc_win_info): Instantiate the appropriate subclass.
3073
3074 2019-06-25  Tom Tromey  <tom@tromey.com>
3075
3076         * tui/tui-win.c (tui_resize_all): Use delete.
3077         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3078         destructor.
3079         (tui_free_window): Don't declare.
3080         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3081         Update.
3082
3083 2019-06-25  Tom Tromey  <tom@tromey.com>
3084
3085         * tui/tui-data.h (struct tui_win_info): Add constructor.
3086         * tui/tui-data.c (tui_alloc_win_info): Use new.
3087         (tui_free_window): Use delete.
3088
3089 2019-06-22  Tom Tromey  <tom@tromey.com>
3090
3091         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3092         declare.
3093         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3094
3095 2019-06-22  Tom Tromey  <tom@tromey.com>
3096
3097         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3098         declare.
3099         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3100
3101 2019-06-22  Tom de Vries  <tdevries@suse.de>
3102
3103         * dwarf2read.c (create_addrmap_from_aranges)
3104         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3105         instead of '%zu'.
3106
3107 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3108
3109         * dwarf2read.h (dwarf2_section_info_def): Remove.
3110         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3111         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3112         std::vector<dwarf2_section_info>.
3113         (struct dwo_file) <~dwo_file>: Remove.
3114         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3115         types field.
3116         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3117         (dwarf2_read_debug_names): Likewise.
3118         (create_debug_types_hash_table): Change parameter type to
3119         array_view, adjust code accordingly.
3120         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3121         (partial_die_info::fixup): Likewise.
3122         (determine_prefix): Likewise.
3123         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3124
3125 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3126
3127         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3128         gdb_bfd_ref_ptr.
3129         <~dwo_file>: Remove call to gdb_bfd_unref.
3130         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3131         gdb_bfd_ref_ptr::get.
3132
3133 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3134
3135         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3136         type to htab_up.
3137         * dwarf2read.c (struct dwo_file): Initialize fields.
3138         <~dwo_file>: New.
3139         (free_dwo_file): Remove, move content to ~dwo_file.
3140         (struct dwo_file_deleter): Remove.
3141         (dwo_file_up>: Remove custom deleter.
3142         (free_dwo_files): Remove.
3143         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3144         dwo_files.
3145         (process_skeletonless_type_units): Call unique_ptr::get.
3146         (allocate_dwo_file_hash_table): Add deleter to created hash
3147         table.  Change return type to htab_up.
3148         (lookup_dwo_file_slot): Don't memset dwo_file, call
3149         unique_ptr::get.
3150         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3151         (create_dwo_unit_in_dwp_v2): Likewise.
3152         (open_and_init_dwo_file): Likewise.
3153         (free_dwo_file_from_slot): Remove.
3154
3155 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3156
3157         * dwarf2read.h (struct dwarf2_section_info) <readin,
3158         is_virtual>: Change type to bool.
3159         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3160         true instead of 1.
3161
3162 2019-06-19  Tom Tromey  <tom@tromey.com>
3163
3164         * tui/tui-data.h (tui_init_content_element): Don't declare.
3165
3166 2019-06-19  Tom Tromey  <tom@tromey.com>
3167
3168         * tui/tui-data.h (tui_init_win_info): Don't declare.
3169
3170 2019-06-19  Tom de Vries  <tdevries@suse.de>
3171
3172         * dwarf2read.h (abstract_to_concrete): Change type to
3173         std::unordered_map<sect_offset, std::vector<sect_offset>,
3174         gdb::hash_enum<sect_offset>>.
3175
3176 2019-06-19  Tom Tromey  <tromey@adacore.com>
3177
3178         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3179         EVAL_AVOID_SIDE_EFFECTS specially.
3180
3181 2019-06-19  Tom Tromey  <tromey@adacore.com>
3182
3183         * source-cache.c (highlighter): New global.
3184         (source_cache::get_source_lines): Create a highlighter on demand.
3185
3186 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3187
3188         * defs.h (deprecated_interactive_hook): Delete declaration.
3189         * interps.c (clear_interpreter_hooks): Remove use of
3190         deprecated_interactive_hook.
3191         * top.c (deprecated_interactive_hook): Delete definition.
3192         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3193
3194 2019-06-18  Tom de Vries  <tdevries@suse.de>
3195
3196         PR gdb/24515
3197         * dwarf2read.h (abstract_to_concrete): Change type from
3198         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3199         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3200         * dwarf2read.c (read_variable): Update.
3201         (dwarf2_fetch_die_loc_sect_off): Update.
3202
3203 2019-06-17  Tom de Vries  <tdevries@suse.de>
3204
3205         PR gdb/24617
3206         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3207         accessing parent[parent_len - 1].
3208
3209 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3210
3211         PR gdb/24364
3212         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3213         call dtrace_process_dof with NULL dof.
3214
3215 2019-06-16  Tom de Vries  <tdevries@suse.de>
3216
3217         PR gdb/24445
3218         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3219
3220 2019-06-16  Tom Tromey  <tom@tromey.com>
3221
3222         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3223         (make_all_visible): Use address of member.
3224
3225 2019-06-16  Tom Tromey  <tom@tromey.com>
3226
3227         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3228         (tui_free_window, free_content, free_content_elements): Remove
3229         unnecessary cast.
3230         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3231         cast.
3232         * tui/tui-regs.c (tui_show_register_group)
3233         (tui_display_registers_from, tui_display_reg_element_at_line):
3234         Remove unnecessary cast.
3235
3236 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3237
3238         * linux-nat.c (normal_mask): Delete.
3239         (_initialize_linux_nat): Don't initialise normal_mask.
3240
3241 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3242
3243         PR gdb/24445
3244         * dwarf-index-write.h (write_psymtabs_to_index): Add
3245         dwz_basename parameter.
3246         * dwarf-index-write.c (write_gdbindex): Move file writing to
3247         write_gdbindex_1.  Change return type void.
3248         (assert_file_size): Move up, remove filename parameter.
3249         (write_gdbindex_1): New function.
3250         (write_debug_names): Change return type to void, call
3251         assert_file_size.
3252         (struct index_wip_file): New struct.
3253         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3254         file logic to index_wip_file.  Write index for dwz file if
3255         needed.
3256         (save_gdb_index_command): Pass basename of dwz file, if present.
3257         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3258         build-id of dwz file, if present.
3259         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3260         (dwarf2_get_dwz_file): Likewise.
3261         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3262         (dwarf2_get_dwz_file): Likewise.
3263
3264 2019-06-16  Tom Tromey  <tom@tromey.com>
3265
3266         * coffread.c (process_coff_symbol): Use xstrdup.
3267         * value.c (create_internalvar): Use xstrdup.
3268
3269 2019-06-16  Tom Tromey  <tom@tromey.com>
3270
3271         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3272         * breakpoint.c (stopin_command, stopat_command)
3273         (until_break_command, decode_location_default): Remove unnecessary
3274         cast.
3275         * utils.c (subset_compare): Remove unnecessary cast.
3276         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3277         cast.
3278         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3279         cast.
3280         * infcmd.c (path_command): Remove unnecessary cast.
3281         * coffread.c (decode_type): Remove unnecessary cast.
3282         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3283         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3284         * tui/tui-stack.c (tui_show_locator_content)
3285         (tui_show_frame_info): Remove unnecessary cast.
3286         * tui/tui-win.c (tui_scroll_forward_command)
3287         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3288         (parse_scrolling_args): Remove unnecessary cast.
3289         * tui/tui-data.c (init_win_info, tui_del_window)
3290         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3291         (free_content_elements): Remove unnecessary cast.
3292         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3293         unnecessary cast.
3294         * tui/tui-source.c (tui_set_source_content)
3295         (tui_vertical_source_scroll): Remove unnecessary cast.
3296         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3297         cast.
3298         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3299         * tui/tui-regs.c (tui_display_registers_from)
3300         (tui_display_register): Remove unnecessary cast.
3301         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3302         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3303         (make_visible): Remove unnecessary cast.
3304         * tui/tui-winsource.c (tui_erase_source_content)
3305         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3306         unnecessary cast.
3307         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3308         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3309         * stabsread.c (read_type, read_array_type, read_range_type):
3310         Remove unnecessary cast.
3311         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3312         (parse_symbol, parse_type, upgrade_type, parse_external)
3313         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3314         unnecessary cast.
3315         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3316
3317 2019-06-16  Tom Tromey  <tom@tromey.com>
3318
3319         * tui/tui-data.c (tui_alloc_generic_win_info)
3320         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3321         checks.
3322
3323 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3324             Andrew Burgess  <andrew.burgess@embecosm.com>
3325
3326         * f-typeprint.c (f_print_type): Don't return early for not
3327         associated or not allocated types.
3328         (f_type_print_varspec_suffix): Add print_rank parameter and print
3329         ranks of array types in case they dangling.
3330         (f_type_print_base): Add print_rank parameter.
3331
3332 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3333
3334         * NEWS: Mention new MI commands.
3335         * break-catch-throw.c (enum exception_event_kind): Move to
3336         breakpoint.h.
3337         (print_mention_exception_catchpoint): Output text as a single
3338         message.
3339         (catch_exception_command_1): Rename to...
3340         (catch_exception_event): ...this, make non-static, update header
3341         command, and change some parameter types.
3342         (catch_catch_command): Update for changes to
3343         catch_exception_command_1.
3344         (catch_throw_command): Likewise.
3345         (catch_rethrow_command): Likewise.
3346         * breakpoint.c (enum exception_event_kind): Delete.
3347         * breakpoint.h (enum exception_event_kind): Moved here from
3348         break-catch-throw.c.
3349         (catch_exception_event): Declare.
3350         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3351         (mi_cmd_catch_throw): New function.
3352         (mi_cmd_catch_rethrow): New function.
3353         (mi_cmd_catch_catch): New function.
3354         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3355         'catch-catch' entries.
3356         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3357         (mi_cmd_catch_rethrow): Declare.
3358         (mi_cmd_catch_catch): Declare.
3359
3360 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3361
3362         * annotate.c (annotate_source_line): Change return type to void,
3363         update implementation to match.
3364         * annotate.h (annotate_source_line): Change return type to void,
3365         update header comment.
3366         * stack.c (print_frame_info): Don't change what frame information
3367         is printed based on whether annotations are on or not.
3368
3369 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3370
3371         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3372         (annotate_source): Make static.
3373         (annotate_source_line): Moved from source.c and renamed from
3374         identify_source_line.  Update the return type.
3375         * annotate.h (annotate_source): Delete declaration.
3376         (annotate_source_line): Declaration moved from source.h, and
3377         renamed from identify_source_line.  Return type updated.
3378         * source.c (identify_source_line): Moved to annotate.c and renamed
3379         to annotate_source_line.
3380         (info_line_command): Remove check of annotation_level.
3381         * source.h (identify_source_line): Move declaration to annotate.h
3382         and rename to annotate_source_line.
3383         * stack.c: Add 'annotate.h' include.
3384         (print_frame_info): Remove check of annotation_level before
3385         calling annotate_source_line.
3386
3387 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3388
3389         * source-cache.c (source_cache::get_plain_source_lines): Use
3390         open_source_file_with_line_charpos instead of just
3391         open_source_file, remove call to find_source_lines.
3392         (source_cache::get_source_lines): Likewise.
3393         * source.c (find_source_lines): Make static.
3394         (get_filename_and_charpos): Renamed into...
3395         (open_source_file_with_line_charpos): ..this along with changes to
3396         return a scoped_fd, and some other minor clean ups.
3397         (identify_source_line): Use open_source_file_with_line_charpos.
3398         (search_command_helper): Use open_source_file_with_line_charpos
3399         instead of just open_source_file, remove call to
3400         find_source_lines.
3401         * source.h (open_source_file_with_line_charpos): Declare new
3402         function.
3403         (find_source_lines): Delete declaration.
3404
3405 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3406
3407         * source.c (get_filename_and_charpos): Remove fullname
3408         parameter.
3409         (identify_source_line): Update call to get_filename_and_charpos.
3410
3411 2019-06-14  Tom Tromey  <tromey@adacore.com>
3412
3413         PR gdb/24502:
3414         * ui-style.h (skip_ansi_escape): Update comment.
3415         * ui-file.h (class no_terminal_escape_file): New class.
3416         * ui-file.c (no_terminal_escape_file::write)
3417         (no_terminal_escape_file::puts): New methods.
3418         * cli/cli-logging.c (handle_redirections): Use
3419         no_terminal_escape_file.
3420
3421 2019-06-14  Tom Tromey  <tromey@adacore.com>
3422
3423         * NEWS: Move convenience variable news above Python news.
3424
3425 2019-06-14  Tom Tromey  <tom@tromey.com>
3426
3427         * gnulib: Move directory to top-level.
3428         * configure.ac: Don't configure gnulib.
3429         * configure: Rebuild.
3430         * common/common-defs.h: Use new path to gnulib.
3431         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3432         (GNULIB_H): Remove.
3433         (INCGNU): Look in new gnulib location.
3434         (HFILES_NO_SRCDIR): Remove gnulib files.
3435         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3436         (generated_files): Remove GNULIB_H.
3437         ($(LIBGNU), all-lib): Remove targets.
3438         (distclean): Don't mention GNULIB_BUILDDIR.
3439         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3440
3441 2019-06-14  Tom Tromey  <tromey@adacore.com>
3442
3443         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3444         Warn if symbol file does not provide any symbols.
3445
3446 2019-06-14  Tom Tromey  <tromey@adacore.com>
3447
3448         * source.c (find_and_open_source): Respect basenames_may_differ.
3449
3450 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3451
3452         * annotate.c (annotate_breakpoints_invalid): Make use of
3453         scoped_restore_terminal_state.
3454         (annotate_frames_invalid): Likewise.
3455
3456 2019-06-14  Tom Tromey  <tromey@adacore.com>
3457
3458         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3459         allow assignment to an internalvar.
3460
3461 2019-06-14  Tom Tromey  <tromey@adacore.com>
3462
3463         * ada-lex.l: Allow "_" in attribute names.
3464
3465 2019-06-14  Tom Tromey  <tromey@adacore.com>
3466
3467         PR gdb/24653:
3468         * regcache.c (registers_changed): Don't call alloca.
3469         * top.c (execute_command): Don't call alloca.
3470
3471 2019-06-13  Pedro Alves  <palves@redhat.com>
3472
3473         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3474         'expression'.  When parsing an expression, error out if there's
3475         junk after "unlimited".
3476         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3477         (do_set_command): Adjust calls to is_unlimited_literal.
3478
3479 2019-06-13  Pedro Alves  <palves@redhat.com>
3480
3481         * compile/compile.c (make_compile_options_def_group): Add braces
3482         around array_view initializer.
3483         * thread.c (make_thread_apply_all_options_def_group)
3484         (make_thread_apply_all_options_def_group): Likewise.
3485
3486 2019-06-13  Pedro Alves  <palves@redhat.com>
3487
3488         * NEWS (New commands): Mention "maint test-options
3489         require-delimiter", "maint test-options unknown-is-error", "maint
3490         test-options unknown-is-operand" and "maint show
3491         test-options-completion-result".
3492         (New command options, command completion): New section.
3493         (Completion improvements): New section.
3494         Mention that you can abbreviate "unlimited".
3495
3496 2019-06-13  Pedro Alves  <palves@redhat.com>
3497
3498         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3499         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3500         * unittests/cli-utils-selftests.c (test_parse_flags)
3501         (test_parse_flags_qcs): Delete.
3502         (test_cli_utils): Don't call deleted functions.
3503
3504 2019-06-13  Pedro Alves  <palves@redhat.com>
3505
3506         * thread.c: Include "cli/cli-option.h".
3507         (tp_array_compar_ascending): Global.
3508         (tp_array_compar): Delete function.
3509         (tp_array_compar_ascending, tp_array_compar_descending): New
3510         functions.
3511         (ascending_option_def, qcs_flag_option_def)
3512         (thr_qcs_flags_option_defs)
3513         (make_thread_apply_all_options_def_group)
3514         (make_thread_apply_options_def_group): New.
3515         (thread_apply_all_command): Use gdb::option::process_options.
3516         (thread_apply_command_completer)
3517         (thread_apply_all_command_completer): New.
3518         (thread_apply_command): Use gdb::option::process_options.
3519         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3520         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3521         to generate help text of "thread apply".  Adjust "taas"'s help.
3522         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3523         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3524
3525 2019-06-13  Pedro Alves  <palves@redhat.com>
3526
3527         * thread.c (thread_apply_command): Check for invalid TID with
3528         isdigit instead of !isalpha.
3529
3530 2019-06-13  Pedro Alves  <palves@redhat.com>
3531
3532         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3533         (validate_flags_qcs): New.
3534         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3535         (validate_flags_qcs): Declare.
3536         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3537         (make_frame_apply_options_def_group): New.
3538         (frame_apply_command_count): Process options with
3539         gdb::option::process_options.
3540         (frame_apply_completer): New.
3541         (frame_apply_level_completer, frame_apply_all_completer)
3542         (frame_apply_completer): New.
3543         (_initialize_stack): Update help of "frame apply", "frame apply
3544         level", "frame apply all" and "faas" to mention supported options
3545         and install command completers.
3546         * stack.h (frame_apply_all_completer): Declare.
3547         * thread.c: Include "stack.h".
3548         (tfaas_command): Add "--".
3549         (_initialize_thread): Update help "tfaas" to mention supported
3550         options and install command completer.
3551
3552 2019-06-13  Pedro Alves  <palves@redhat.com>
3553
3554         * completer.c (complete_nested_command_line): New.
3555         (gdb_completion_word_break_characters_throw): Add assertion.
3556         * completer.h (complete_nested_command_line): Declare.
3557
3558 2019-06-13  Pedro Alves  <palves@redhat.com>
3559
3560         * stack.c (parse_backtrace_qualifiers): New.
3561         (backtrace_command): Use it.
3562         (backtrace_command_completer): Complete on qualifiers.
3563
3564 2019-06-13  Pedro Alves  <palves@redhat.com>
3565
3566         * frame.c: Include "cli/cli-option.h.
3567         (user_set_backtrace_options): New.
3568         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3569         Delete.
3570         (get_prev_frame): Adjust.
3571         (boolean_option_def, uinteger_option_def)
3572         (set_backtrace_option_defs): New.
3573         (_initialize_frame): Adjust and use
3574         gdb::option::add_setshow_cmds_for_options to install "set
3575         backtrace past-main" and "set backtrace past-entry".
3576         * frame.h: Include "cli/cli-option.h".
3577         (struct frame_print_options): Forward declare.
3578         (print_frame_arguments_all, print_frame_arguments_scalars)
3579         (print_frame_arguments_none): Declare.
3580         (print_entry_values): Delete declaration.
3581         (struct frame_print_options, user_frame_print_options): New.
3582         (struct set_backtrace_options): New.
3583         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3584         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3585         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3586         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3587         (list_args_or_locals): Add frame_print_options parameter.
3588         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3589         * python/py-framefilter.c (enumerate_args): Pass down
3590         USER_FRAME_PRINT_OPTIONS.
3591         * stack.c: Include "cli/cli-option.h".
3592         (print_frame_arguments_all, print_frame_arguments_scalars)
3593         (print_frame_arguments_none): Declare.
3594         (print_raw_frame_arguments, print_entry_values): Delete.
3595         (user_frame_print_options): New.
3596         (boolean_option_def, enum_option_def, frame_print_option_defs):
3597         New.
3598         (struct backtrace_cmd_options): New.
3599         (bt_flag_option_def): New.
3600         (backtrace_command_option_defs): New.
3601         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3602         (print_frame_arg, read_frame_arg, print_frame_args)
3603         (print_frame_info, print_frame): Add frame_print_options parameter
3604         and use it.
3605         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3606         (backtrace_command_1): Add frame_print_options and
3607         backtrace_cmd_options parameters and use them.
3608         (make_backtrace_options_def_group): New.
3609         (backtrace_command): Process command options with
3610         gdb::option::process_options.
3611         (backtrace_command_completer): New.
3612         (_initialize_stack): Extend "backtrace"'s help to mention
3613         supported options.  Install completer for "backtrace".
3614         Install some settings commands with add_setshow_cmds_for_options.
3615
3616 2019-06-13  Pedro Alves  <palves@redhat.com>
3617
3618         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3619         and that "set/show print raw frame-arguments" are now deprecated.
3620
3621         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3622         command.
3623         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3624         * stack.c (_initialize_stack): Install "set/show print
3625         raw-frame-arguments", and deprecate "set/show print raw
3626         frame-arguments".
3627         * valprint.c (_initialize_valprint): Deprecate "set/show print
3628         raw".
3629
3630 2019-06-13  Pedro Alves  <palves@redhat.com>
3631
3632         * compile/compile.c (struct compile_options): New.
3633         (compile_flag_option_def, compile_command_option_defs)
3634         (make_compile_options_def_group): New.
3635         (compile_file_command): Handle options with
3636         gdb::option::process_options.
3637         (compile_file_command_completer): New function.
3638         (compile_code_command): Handle options with
3639         gdb::option::process_options.
3640         (compile_code_command_completer): New function.
3641         (_initialize_compiler): Install completers for "compile code" and
3642         "compile file".  Mention available options in "compile code" and
3643         "compile code"'s help.
3644         * completer.c (advance_to_completion_word): New, factored out from
3645         ...
3646         (advance_to_expression_complete_word_point): ... this.
3647         (advance_to_filename_complete_word_point): New.
3648         * completer.h (advance_to_filename_complete_word_point): New
3649         declaration.
3650
3651 2019-06-13  Pedro Alves  <palves@redhat.com>
3652
3653         * compile/compile.c: Include "cli/cli-option.h".
3654         (compile_print_value): Scope data pointer is now a
3655         value_print_options pointer; adjust.
3656         (compile_print_command): Process options.  Scope data pointer is
3657         now a value_print_options pointer; adjust.
3658         (_initialize_compile): Update "compile print"'s help to include
3659         supported options.  Install a completer for "compile print".
3660         * cp-valprint.c (show_vtblprint, show_objectprint)
3661         (show_static_field_print): Delete.
3662         (_initialize_cp_valprint): Don't install "set print
3663         static-members", "set print vtbl", "set print object" here.
3664         * printcmd.c: Include "cli/cli-option.h" and
3665         "common/gdb_optional.h".
3666         (print_command_parse_format): Rework to fill in a
3667         value_print_options instead of a format_data.
3668         (print_value): Change parameter type from format_data pointer to
3669         value_print_options reference.  Adjust.
3670         (print_command_1): Process options.  Adjust to pass down a
3671         value_print_options.
3672         (print_command_completer): New.
3673         (_initialize_printcmd): Install print_command_completer as
3674         handle_brkchars completer for the "print" command.  Update
3675         "print"'s help to include supported options.
3676         * valprint.c: Include "cli/cli-option.h".
3677         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3678         here from cp-valprint.c.
3679         (boolean_option_def, uinteger_option_def)
3680         (value_print_option_defs, make_value_print_options_def_group):
3681         New.  Use gdb::option::add_setshow_cmds_for_options to install
3682         "set print elements", "set print null-stop", "set print repeats",
3683         "set print pretty", "set print union", "set print array", "set
3684         print address", "set print symbol", "set print array-indexes".
3685         * valprint.h: Include <string> and "cli/cli-option.h".
3686         (make_value_print_options_def_group): Declare.
3687         (print_value): Change parameter type from format_data pointer to
3688         value_print_options reference.
3689         (print_command_completer): Declare.
3690
3691 2019-06-13  Pedro Alves  <palves@redhat.com>
3692
3693         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3694         (COMMON_SFILES): Add maint-test-settings.c.
3695         * cli/cli-decode.c (boolean_enums): New global, factored out from
3696         ...
3697         (add_setshow_boolean_cmd): ... here.
3698         * cli/cli-decode.h (boolean_enums): Declare.
3699         * cli/cli-option.c: New file.
3700         * cli/cli-option.h: New file.
3701         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3702         factored out from ...
3703         (parse_cli_boolean_value(const char *)): ... this.
3704         (is_unlimited_literal): Change parameter type to pointer to
3705         pointer.  Adjust and advance ARG pointer.
3706         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3707         (parse_cli_var_enum): New, factored out from ...
3708         (do_set_command): ... this.  Adjust.
3709         * cli/cli-setshow.h (parse_cli_boolean_value)
3710         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3711         (parse_cli_var_enum): Declare.
3712         * cli/cli-utils.c: Include "cli/cli-option.h".
3713         (get_ulongest): New.
3714         * cli/cli-utils.h (get_ulongest): Declare.
3715         (check_for_argument): New overloads.
3716         * maint-test-options.c: New file.
3717
3718 2019-06-13  Pedro Alves  <palves@redhat.com>
3719
3720         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3721         parse a range if "-" is at the end of the string.
3722
3723 2019-06-13  Pedro Alves  <palves@redhat.com>
3724
3725         * cli/cli-setshow.c (parse_auto_binary_operation)
3726         (parse_cli_boolean_value): Don't allow "o".
3727
3728 2019-06-13  Pedro Alves  <palves@redhat.com>
3729
3730         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3731         * NEWS: Mention maint test-settings KIND.
3732         * maint-test-settings.c: New file.
3733
3734 2019-06-13  Pedro Alves  <palves@redhat.com>
3735
3736         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3737         completer.
3738         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3739         "set" completers.
3740
3741 2019-06-13  Pedro Alves  <palves@redhat.com>
3742
3743         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3744         after item.
3745
3746 2019-06-13  Pedro Alves  <palves@redhat.com>
3747
3748         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3749
3750 2019-06-13  Pedro Alves <palves@redhat.com>
3751
3752         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3753         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3754         call.
3755         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3756         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3757         calls.
3758         (check_for_argument): Skip spaces after argument.
3759
3760 2019-06-13  Pedro Alves  <palves@redhat.com>
3761
3762         * thread.c (thread_apply_command): Adjust TID parsing.
3763         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3764         detected before end of string.
3765         (tid_is_in_list): Error out if LIST is invalid.
3766
3767 2019-06-13  Pedro Alves  <palves@redhat.com>
3768
3769         * completer.c (complete_line_internal_1): Rewind completion word
3770         point.
3771         (completion_tracker::advance_custom_word_point_by): Change
3772         parameter type to int.
3773         * completer.h (completion_tracker::advance_custom_word_point_by):
3774         Likewise.
3775
3776 2019-06-13  Pedro Alves  <palves@redhat.com>
3777
3778         * completer.c (advance_to_completion_word): Handle delimiters.
3779
3780 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3781
3782         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3783
3784 2019-06-11  Tom Tromey  <tom@tromey.com>
3785
3786         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3787         (xmalloc_failed): Move to alloc.c.
3788         * alloc.c: New file.
3789         * Makefile.in (COMMON_SFILES): Add alloc.c.
3790
3791 2019-06-11  Tom Tromey  <tom@tromey.com>
3792
3793         * nat/linux-waitpid.c: Don't include server.h.
3794         (linux_debug): Remove.
3795         (my_waitpid): Update.
3796
3797 2019-06-11  Tom Tromey  <tromey@adacore.com>
3798
3799         * infcall.c (_initialize_infcall): Remove trailing newline from
3800         help.
3801         * user-regs.c (_initialize_user_regs): Remove trailing newline
3802         from help.
3803         * typeprint.c (_initialize_typeprint): Remove trailing newline
3804         from help.
3805         * reverse.c (_initialize_reverse): Remove trailing newlines from
3806         help.
3807         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3808         from help.
3809         * language.c (add_set_language_command): Remove trailing newline
3810         from help.
3811         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3812         help.
3813         * disasm.c (_initialize_disasm): Remove trailing newline from
3814         help.
3815         * top.c (init_main): Remove trailing newline from help.
3816         * interps.c (_initialize_interpreter): Remove trailing newline
3817         from help.
3818         * btrace.c (_initialize_btrace): Remove trailing newlines from
3819         help.
3820         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3821         from help.
3822         * python/python.c (_initialize_python): Remove trailing newline
3823         from help.
3824         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3825         help.
3826         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3827         from help.  Reformat some text.
3828         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3829         from help.
3830         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3831         newline from help.
3832
3833 2019-06-11  Tom Tromey  <tromey@adacore.com>
3834
3835         * darwin-nat.c (darwin_decode_exception_message)
3836         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3837
3838 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3839
3840         * valops.c (value_slice): Check for not allocated or not
3841         associated values.
3842
3843 2019-06-10  Tom de Vries  <tdevries@suse.de>
3844
3845         PR gdb/24618
3846         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3847         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3848         invalid.
3849
3850 2019-06-10  Tom de Vries  <tdevries@suse.de>
3851
3852         PR gdb/24611
3853         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3854         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3855
3856 2019-06-10  Tom de Vries  <tdevries@suse.de>
3857
3858         PR symtab/24545
3859         * symtab.c (struct demangled_name_entry): Add language field.
3860         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3861         static minimal symbol".  Set and use language field.
3862
3863 2019-06-10  Tom Tromey  <tromey@adacore.com>
3864
3865         * ada-lang.c (_initialize_ada_language): Update help text.
3866
3867 2019-06-10  Tom Tromey  <tromey@adacore.com>
3868
3869         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3870         with a newline.
3871         * guile/guile.c (handle_boot_error): Don't end warning with a
3872         newline.
3873         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3874         warning with a newline.
3875         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3876         newline.
3877         (s12z_frame_cache): Likewise.
3878         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3879         a newline.
3880         * solib-svr4.c (disable_probes_interface): Don't end warning with
3881         a newline.
3882         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3883         newline.
3884         * python/python.c (do_finish_initialization): Don't end warning
3885         with a newline.
3886
3887 2019-06-10  Tom Tromey  <tom@tromey.com>
3888
3889         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3890         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3891         gdbpy_enter.
3892
3893 2019-06-10  Tom Tromey  <tromey@adacore.com>
3894
3895         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3896         data.
3897         (elf_new_init): Don't call stabsread_new_init.
3898         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3899         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3900         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3901
3902 2019-06-10  Tom de Vries  <tdevries@suse.de>
3903
3904         PR symtab/16264
3905         PR symtab/24517
3906         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3907
3908 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3909
3910         * source.c (find_and_open_source): Also rewrite relative file
3911         names.
3912
3913 2019-04-26  Amos Bird  <amosbird@gmail.com>
3914
3915         * annotate.c (annotate_thread_exited): Add "thread-exited"
3916         annotation.
3917
3918 2019-06-06  Tom Tromey  <tromey@adacore.com>
3919
3920         * maint.h (class scoped_command_stats): Use
3921         DISABLE_COPY_AND_ASSIGN.
3922         <print_time>: New method.
3923         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3924         print_time.
3925         (scoped_command_stats::print_time): New method.
3926
3927 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3928
3929         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3930         instructions of lengths 6 or 8 bytes.
3931
3932 2019-06-04  Pedro Alves  <palves@redhat.com>
3933
3934         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3935
3936         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3937         * breakpoint.c (condition_completer): Likewise.
3938         * cli/cli-dump.c (scan_expression): Likewise.
3939         * common/filestuff.c (mkdir_recursive): Likewise.
3940         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3941         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3942         (gdb_abspath): Likewise.
3943         * compile/compile-cplus-types.c
3944         (compile_cplus_instance::decl_name): Likewise.
3945         * completer.c (complete_explicit_location):
3946         (signal_completer, reg_or_group_completer_1): Likewise.
3947         * cp-support.c (cp_remove_params_if_any): Likewise.
3948         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3949         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3950         * infcmd.c (strip_bg_char): Likewise.
3951         * linespec.c (copy_token_string): Likewise.
3952         * mi/mi-main.c (output_cores): Likewise.
3953         * psymtab.c (psymtab_search_name):
3954         * symfile.c (test_set_ext_lang_command): Likewise.
3955         * target.c (target_fileio_read_stralloc): Likewise.
3956         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3957         * value.c (complete_internalvar): Likewise.
3958
3959 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3960
3961         Add objfile property to gdb.Type.
3962         * NEWS: Mention Python API addition.
3963         * python/py-type.c (typy_get_objfile): New method.
3964
3965 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3966
3967         * NEWS: Mention the new set|show style [title|highlight].
3968         Mention changes to "show style", "help" and "apropos".
3969
3970 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3971
3972         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3973         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3974         instead of print_help_for_command.
3975         (print_doc_of_command): New function.
3976         (help_list): Add 'apropos -v word' suggestion.
3977         (print_help_for_command): Style the command name using title style.
3978         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3979         (_initialize_cli_cmds): Describe -v in apropos_command help.
3980
3981 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3982
3983         * cli/cli-style.h (cli_style_option): Add name in constructor,
3984         add m_name class member, add constructor with intensity,
3985         add name class function.
3986         (cli_style_option::add_setshow_commands): Remove name argument.
3987         (highlight_style, title_style): New styles.
3988         * cli/cli-style.c (do_show): New function that shows a style
3989         characteristic styling the style name with itself.
3990         (set_style_name): New function.
3991         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3992         Update all callers according to the changes in cli/cli-style.h.
3993         * utils.h (fputs_highlighted): New function.
3994         * utils.c (fputs_highlighted): Likewise.
3995
3996 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3997
3998         * NEWS: Mention new pipe command and new convenience variables.
3999
4000 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4001
4002         * cli/cli-cmds.c (pipe_command): New function.
4003         (_initialize_cli_cmds): Call add_com for pipe_command.
4004         Define | as an alias for pipe.
4005         (exit_status_set_internal_vars): New function.
4006         (shell_escape): Call exit_status_set_internal_vars.
4007         cli/cli-decode.c (find_command_name_length): Recognize | as
4008         a single character command.
4009
4010 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4011
4012         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4013         top.c (execute_command_to_ui_file): New function, mostly a copy
4014         of execute_command_to_string.
4015         (execute_command_to_string): Implement by calling
4016         execute_command_to_ui_file.
4017
4018 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4019
4020         * top.h (saved_command_line): Remove declaration.
4021         * top.c (previous_saved_command_line, previous_repeat_arguments):
4022         New variables.
4023         (saved_command_line): Make static, define together with other
4024         'repeat variables'.
4025         (dont_repeat): Clear repeat_arguments.
4026         (repeat_previous, get_saved_command_line, save_command_line):
4027         New functions.
4028         (gdb_init): Initialize saved_command_line
4029         and previous_saved_command_line.
4030         * main.c (captured_main_1): Remove saved_command_line initialization.
4031         * event-top.c (handle_line_of_input): Update to use
4032         the new 'repeat' related functions instead of direct access to
4033         saved_command_line.
4034         * command.h (repeat_previous, get_saved_command_line,
4035         save_command_line): New declarations.
4036         (dont_repeat): Add comment.
4037
4038 2019-05-30  Tom Tromey  <tromey@adacore.com>
4039
4040         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4041         Fix comment.
4042         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4043
4044 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4045
4046         PR cli/24587
4047         * completer.c (complete): Initialize variable word.
4048
4049 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4050
4051         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4052         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4053         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4054         'body' is NULL to the outter 'if', protecting the '!is_define'
4055         situation as well.
4056
4057 2019-05-29  Tom Tromey  <tromey@adacore.com>
4058
4059         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4060         (dwarf_unknown): New function.
4061         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4062         (dwarf_type_encoding_name): Use dwarf_unknown.
4063
4064 2019-05-29  Tom Tromey  <tromey@adacore.com>
4065
4066         PR c++/20020:
4067         * cp-valprint.c (cp_print_value_fields): Call
4068         cp_print_static_field inside "try".
4069
4070 2019-05-29  Tom Tromey  <tromey@adacore.com>
4071
4072         * inflow.c (struct terminal_info): Add default operator=.
4073         * configure: Rebuild.
4074         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4075         -Wdeprecated-copy-dtor, -Wredundant-move.
4076
4077 2019-05-29  Tom Tromey  <tromey@adacore.com>
4078
4079         * NEWS: Add entry.
4080         * infcmd.c (print_return_value_1): Handle finish_print
4081         option.
4082         (show_print_finish): New function.
4083         (_initialize_infcmd): Add "set/show print finish" commands.
4084         * valprint.c (user_print_options): Initialize new member.
4085         * valprint.h (struct value_print_options) <finish_print>: New
4086         member.
4087
4088 2019-05-28  Tom Tromey  <tromey@adacore.com>
4089
4090         * ada-lang.c (ada_remove_Xbn_suffix)
4091         (find_old_style_renaming_symbol)
4092         (parse_old_style_renaming): Remove.
4093         (ada_find_renaming_symbol): Don't call
4094         find_old_style_renaming_symbol.
4095         (ada_is_renaming_symbol): Rename from
4096         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4097         bool.  Now static.
4098         (ada_read_var_value): Update and simplify.
4099         * ada-exp.y (write_var_or_type): Remove old code.
4100
4101 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4102
4103         * event-top.c: Remove include comment.
4104         * inflow.c (class scoped_ignore_sigttou): Move from here...
4105         * inflow.h (class scoped_ignore_sigttou): ...to here.
4106         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4107         * top.c:  Remove include comment.
4108
4109 2019-05-27  Tom Tromey  <tom@tromey.com>
4110
4111         * NEWS: Fix typo.
4112
4113 2019-05-22  Tom Tromey  <tromey@adacore.com>
4114
4115         * target.c (target_follow_exec): Constify parameter.
4116         * target-delegates.c: Rebuild.
4117         * remote.c (remote_target::follow_exec): Constify parameter.
4118         * infrun.c (follow_exec): Constify parameter.
4119         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4120         (target_follow_exec): Likewise.
4121
4122 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4123
4124         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4125         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4126
4127 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4128
4129         * NEWS: Add debugredirect and testsuite sections.
4130
4131 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4132
4133         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4134         target descriptions using exclusively floating point register name
4135         aliases.
4136
4137 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4138
4139         PR gdb/18644:
4140         * f-lang.c (build_fortran_types): Handle the case where
4141         gdbarch_floatformat_for_type returns a nullptr.
4142
4143 2019-05-21  Tom de Vries  <tdevries@suse.de>
4144
4145         PR cli/24587
4146         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4147
4148 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4149
4150         PR gdb/18644:
4151         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4152         16-byte floats.
4153         * i386-tdep.c (i386_floatformat_for_type): Use
4154         floatformats_ia64_quad for the 16-byte floating point component
4155         within a fortran 32-byte complex number.
4156
4157 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4158
4159         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4160         delete default constructor.
4161         (find_partial_die): Update to return const struct.
4162         (partial_die_parent_scope): Move variable declaration into scope
4163         of its use and change its type to auto.
4164         (guess_partial_die_structure_name): Likewise.
4165         (partial_die_info::fixup): Likewise.
4166
4167 2019-05-17  Tom Tromey  <tromey@adacore.com>
4168
4169         * source.c (find_and_open_source): Remove cast.
4170
4171 2019-05-17  Tom Tromey  <tromey@adacore.com>
4172
4173         * annotate.c (annotate_source): Make "filename" const.
4174         * annotate.h (annotate_source): Use const.
4175
4176 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4177
4178         * disasm.c (set_disassembler_options): Send errors to stderr.
4179
4180 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4181
4182         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4183         (cli_interp_base::set_logging): Check debug_redirect.
4184         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4185         * cli/cli-logging.c (debug_redirect): Add static variable.
4186         (pop_output_files): Add default param.
4187         (handle_redirections): Print debug setting.
4188         (show_logging_command): Likewise.
4189         (_initialize_cli_logging): Add debugredirect command.
4190         * interps.c (current_interp_set_logging): Add debug_redirect
4191         parameter.
4192         * interps.h (set_logging): Add debug_redirect parameter.
4193         (current_interp_set_logging): Likewise.
4194         * mi/mi-common.h: Likewise.
4195         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4196
4197 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4198             Tom Tromey  <tromey@adacore.com>
4199
4200         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4201         directly.
4202         * cli/cli-interp.h (make_logging_output): Remove declaration.
4203         * cli/cli-logging.c (make_logging_output): Remove function.
4204         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4205         directly.
4206         * ui-file.c (tee_file::tee_file): Remove bools.
4207         (tee_file::~tee_file): Remove deletes.
4208         * ui-file.h (tee_file): Remove bools.
4209
4210 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4211
4212         * mi/mi-cmds.h (mi_cmd_complete): New function.
4213         * mi/mi-main.c (mi_cmd_complete): Likewise.
4214         * mi/mi-cmds.c: Define new MI command -complete.
4215         * NEWS: Mention new -complete command.
4216
4217 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4218
4219         * completer.h (complete): New function.
4220         * completer.c (complete): Likewise.
4221         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4222         function defined in completer.h.
4223
4224 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4225
4226         * MAINTAINERS (Write After Approval): Add myself.
4227
4228 2019-05-17  Tom de Vries  <tdevries@suse.de>
4229
4230         PR gdb/24094
4231         * dwarf2read.c (struct cu_partial_die_info): New struct.
4232         (find_partial_die): Return cu_partial_die_info.
4233         (partial_die_parent_scope, guess_partial_die_structure_name)
4234         (partial_die_info::fixup): Handle new return type of find_partial_die.
4235
4236 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4237
4238         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4239         "std::string", simplifying the algorithm.
4240
4241 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4242
4243         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4244         (stap_static_probe_ops::get_probes): Likewise.
4245
4246 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4247
4248         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4249         '-')" and "else if".
4250         (stap_parse_single_operand): Join checks for
4251         "gdbarch_stap_parse_special_token_p" and
4252         "gdbarch_stap_parse_special_token" in the same "if" statement.
4253         Invert check when verifying for operation on register
4254         displacement.
4255
4256 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4257
4258         * stap-probe.c (stap_get_opcode): Update comment.
4259         (stap_get_expected_argument_type): Likewise.
4260         (handle_stap_probe): Likewise.
4261
4262 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4263
4264         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4265         return type to 'bool'.  Adjust comment.  Use 'bool' when
4266         appropriate.
4267         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4268         * stap-probe.c (stap_parse_argument_1): Likewise.
4269         (stap_is_operator): Likewise.
4270         (stap_is_generic_prefix): Likewise.
4271         (stap_is_register_prefix): Likewise.
4272         (stap_is_register_indirection_prefix): Likewise.
4273         (stap_is_integer_prefix): Likewise.
4274         (stap_generic_check_suffix): Likewise.
4275         (stap_check_integer_suffix): Likewise.
4276         (stap_check_register_suffix): Likewise.
4277         (stap_check_register_indirection_suffix): Likewise.
4278         (stap_parse_register_operand): Likewise.
4279         (stap_parse_single_operand): Likewise.
4280         (stap_parse_argument_1): Likewise.
4281         (stap_probe::get_argument_count): Likewise.
4282         (stap_is_operator): Likewise.
4283
4284 2019-05-16  Tom Tromey  <tromey@adacore.com>
4285
4286         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4287         keyword to foreach.
4288
4289 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4290
4291         * linux-thread-db.c (try_thread_db_load_1): Change return type
4292         to bool.
4293         (try_thread_db_load): Likewise.
4294         (try_thread_db_load_from_pdir_1): Likewise.
4295         (try_thread_db_load_from_pdir): Likewise.
4296         (try_thread_db_load_from_sdir): Likewise.
4297         (try_thread_db_load_from_dir): Likewise.
4298         (thread_db_load_search): Likewise.
4299         (has_libpthread): Likewise.
4300         (thread_db_load): Likewise.
4301
4302 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4303
4304         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4305         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4306         NULL, and complain/return if that's the case.
4307
4308 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4309
4310         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4311         (advance, posn, abstract_read_memory): New functions.
4312         [struct mem_read_abstraction]: New struct.
4313         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4314
4315 2019-05-14  Tom Tromey  <tromey@adacore.com>
4316
4317         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4318         value is not lval_memory.
4319
4320 2019-05-14  Tom Tromey  <tromey@adacore.com>
4321
4322         * solib.c (info_sharedlibrary_command): Style the file name.
4323
4324 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4325
4326         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4327         (aarch64_vnv_type): Likewise.
4328         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4329         * common/tdesc.c: Likewise.
4330         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4331         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4332         * features/aarch64-fpu.xml: Add ieee half view.
4333         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4334         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4335         * gdbtypes.h (struct builtin_type): Likewise.
4336         (struct objfile_type): Likewise.
4337
4338 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4339
4340         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4341         typo.
4342         * location.h (string_to_event_location): Likewise.
4343
4344 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4345
4346         GDB 8.3 released.
4347
4348 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4349
4350         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4351         New variable declaration.
4352         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4353         New variable.
4354         (print_one_breakpoint): Use ui_out::test_flags and new global
4355         variable to compute use_fixed_output.
4356         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4357         Remove.
4358         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4359         (mi_multi_location_breakpoint_output_fixed): Remove.
4360         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4361         new variable.
4362         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4363         fix_multi_location_breakpoint_output flag if version >= 3.
4364         * ui-out.h (enum ui_out_flag)
4365         <fix_multi_location_breakpoint_output>: New enumerator.
4366
4367 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4368
4369         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4370
4371 2019-05-10  Tom Tromey  <tromey@adacore.com>
4372
4373         * ada-lang.c (catch_ada_completer): New function.
4374         (_initialize_ada_language): Use it.
4375
4376 2019-05-10  Tom Tromey  <tromey@adacore.com>
4377
4378         * thread.c (print_thread_info): Make "requested_threads" const.
4379         * gdbthread.h (print_thread_info): Make "requested_threads"
4380         const.
4381         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4382         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4383
4384 2019-05-08  Tom Tromey  <tom@tromey.com>
4385
4386         * gdbtypes.c (objfile_type_data): Change type.
4387         (objfile_type, _initialize_gdbtypes): Update.
4388
4389 2019-05-08  Tom Tromey  <tom@tromey.com>
4390
4391         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4392         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4393         (_initialize_dwarf2_frame): Update.
4394
4395 2019-05-08  Tom Tromey  <tom@tromey.com>
4396
4397         * objc-lang.c (objc_objfile_data): Change type.
4398         (find_methods): Update.
4399         (_initialize_objc_lang): Remove.
4400
4401 2019-05-08  Tom Tromey  <tom@tromey.com>
4402
4403         * stabsread.c (rs6000_builtin_type_data): Change type.
4404         (rs6000_builtin_type, _initialize_stabsread): Update.
4405
4406 2019-05-08  Tom Tromey  <tom@tromey.com>
4407
4408         * mips-tdep.c (mips_pdr_data): Remove.
4409         (_initialize_mips_tdep): Update.
4410
4411 2019-05-08  Tom Tromey  <tom@tromey.com>
4412
4413         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4414         (hppa_init_objfile_priv_data, read_unwind_info)
4415         (find_unwind_entry, _initialize_hppa_tdep): Update.
4416
4417 2019-05-08  Tom Tromey  <tom@tromey.com>
4418
4419         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4420         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4421         on obstack.
4422         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4423
4424 2019-05-08  Tom Tromey  <tom@tromey.com>
4425
4426         * mdebugread.c (basic_type_data): Change type.
4427         (basic_type, _initialize_mdebugread): Update.
4428
4429 2019-05-08  Tom Tromey  <tom@tromey.com>
4430
4431         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4432
4433 2019-05-08  Tom Tromey  <tom@tromey.com>
4434
4435         * nto-tdep.c (nto_inferior_data_reg): Change type.
4436         (nto_inferior_data): Update.
4437         (nto_inferior_data_cleanup, nto_new_inferior_data)
4438         (_initialize_nto_tdep): Remove.
4439         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4440
4441 2019-05-08  Tom Tromey  <tom@tromey.com>
4442
4443         * ada-lang.c (struct ada_inferior_data): Add initializers.
4444         (ada_inferior_data): Change type.
4445         (ada_inferior_data_cleanup): Remove.
4446         (get_ada_inferior_data, ada_inferior_exit)
4447         (struct ada_pspace_data): Add initializers, destructor.
4448         (ada_pspace_data_handle): Change type.
4449         (get_ada_pspace_data): Update.
4450         (ada_pspace_data_cleanup): Remove.
4451
4452 2019-05-08  Tom Tromey  <tom@tromey.com>
4453
4454         * coffread.c (struct coff_symfile_info): Add initializers.
4455         (coff_objfile_data_key): Move lower.  Change type.
4456         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4457         Update.
4458         (coff_free_info): Remove.
4459
4460 2019-05-08  Tom Tromey  <tom@tromey.com>
4461
4462         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4463         (fbsd_pspace_data_handle): Move lower.  Change type.
4464         (get_fbsd_pspace_data): Update.
4465         (fbsd_pspace_data_cleanup): Remove.
4466         (_initialize_fbsd_tdep): Update.
4467
4468 2019-05-08  Tom Tromey  <tom@tromey.com>
4469
4470         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4471         (get_ada_tasks_pspace_data): Update.
4472         (ada_tasks_pspace_data_cleanup): Remove.
4473         (_initialize_tasks): Update.
4474         (ada_tasks_inferior_data_handle): Change type.
4475         (get_ada_tasks_inferior_data): Update.
4476         (ada_tasks_inferior_data_cleanup): Remove.
4477         (struct ada_tasks_pspace_data): Add initializers.
4478
4479 2019-05-08  Tom Tromey  <tom@tromey.com>
4480
4481         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4482         * symfile-debug.c (debug_sym_get_probes): Change type.
4483         * stap-probe.c (handle_stap_probe):
4484         (stap_static_probe_ops::get_probes): Change type.
4485         * probe.h (class static_probe_ops) <get_probes>: Change type.
4486         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4487         (parse_probes_in_pspace): Update.
4488         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4489         Update.
4490         (any_static_probe_ops::get_probes): Change type.
4491         * elfread.c (elfread_data): New typedef.
4492         (probe_key): Change type.
4493         (elf_get_probes): Likewise.  Update.
4494         (probe_key_free): Remove.
4495         (_initialize_elfread): Update.
4496         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4497         Change type.
4498         (dtrace_process_dof_probe, dtrace_process_dof)
4499         (dtrace_static_probe_ops::get_probe): Change type.
4500
4501 2019-05-08  Tom Tromey  <tom@tromey.com>
4502
4503         * xcoffread.c (struct xcoff_symfile_info): Rename from
4504         coff_symfile_info.  Add initializers.
4505         (xcoff_objfile_data_key): Move lower.  Change type.
4506         (XCOFF_DATA): Rewrite.
4507         (xcoff_free_info): Remove.
4508         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4509         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4510         (xcoff_initial_scan): Update.
4511
4512 2019-05-08  Tom Tromey  <tom@tromey.com>
4513
4514         * solib-svr4.c (struct svr4_info): Add initializers and
4515         destructor.
4516         <probes_table>: Now an htab_up.
4517         (solib_svr4_pspace_data): Change type.
4518         (free_probes_table): Simplify.
4519         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4520         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4521         (probes_table_remove_objfile_probes, register_solib_event_probe)
4522         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4523         (_initialize_svr4_solib): Update.
4524
4525 2019-05-08  Tom Tromey  <tom@tromey.com>
4526
4527         * remote.c (remote_pspace_data): Change type.
4528         (remote_pspace_data_cleanup): Remove.
4529         (get_remote_exec_file, set_pspace_remote_exec_file)
4530         (_initialize_remote): Update.
4531
4532 2019-05-08  Tom Tromey  <tom@tromey.com>
4533
4534         * breakpoint.c (breakpoint_objfile_key): Change type.
4535         (get_breakpoint_objfile_data): Update.
4536         (free_breakpoint_objfile_data): Remove.
4537         (_initialize_breakpoint): Update.
4538
4539 2019-05-08  Tom Tromey  <tom@tromey.com>
4540
4541         * linux-tdep.c (struct linux_info): Add initializers.
4542         (linux_inferior_data): Move.  Change type.
4543         (invalidate_linux_cache_inf): Update.
4544         (linux_inferior_data_cleanup): Remove.
4545         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4546
4547 2019-05-08  Tom Tromey  <tom@tromey.com>
4548
4549         * auxv.c (auxv_inferior_data): Move.  Change type.
4550         (auxv_inferior_data_cleanup): Remove.
4551         (invalidate_auxv_cache_inf): Rewrite.
4552         (get_auxv_inferior_data, _initialize_auxv): Update.
4553
4554 2019-05-08  Tom Tromey  <tom@tromey.com>
4555
4556         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4557         (symfile_debug_objfile_data_key): Change type.
4558         (symfile_debug_installed, debug_qf_has_symbols)
4559         (debug_qf_find_last_source_symtab)
4560         (debug_qf_forget_cached_source_info)
4561         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4562         (debug_qf_print_stats, debug_qf_dump)
4563         (debug_qf_expand_symtabs_for_function)
4564         (debug_qf_expand_all_symtabs)
4565         (debug_qf_expand_symtabs_with_fullname)
4566         (debug_qf_map_matching_symbols)
4567         (debug_qf_expand_symtabs_matching)
4568         (debug_qf_find_pc_sect_compunit_symtab)
4569         (debug_qf_map_symbol_filenames)
4570         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4571         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4572         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4573         (debug_sym_read_linetable, debug_sym_relocate): Update.
4574         (symfile_debug_free_objfile): Remove.
4575         (install_symfile_debug_logging, _initialize_symfile_debug):
4576         Update.
4577
4578 2019-05-08  Tom Tromey  <tom@tromey.com>
4579
4580         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4581         allocate_on_obstack.
4582         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4583         (get_dwarf2_per_objfile): Update.
4584         (set_dwarf2_per_objfile): Remove.
4585         (dwarf2_has_info, dwarf2_get_section_info): Update.
4586         (dwarf2_free_objfile): Remove.
4587         (_initialize_dwarf2_read): Update.
4588
4589 2019-05-08  Tom Tromey  <tom@tromey.com>
4590
4591         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4592         initializers.
4593         <unsupported_script_warning_printed,
4594         script_not_found_warning_printed>: Now bool.
4595         (auto_load_pspace_data): Change type.
4596         (~auto_load_pspace_info): Rename from
4597         auto_load_pspace_data_cleanup.
4598         (get_auto_load_pspace_data, init_loaded_scripts_info)
4599         (clear_section_scripts, maybe_print_unsupported_script_warning)
4600         (maybe_print_script_not_found_warning, _initialize_auto_load):
4601         Update.
4602
4603 2019-05-08  Tom Tromey  <tom@tromey.com>
4604
4605         * objfiles.c (objfile_pspace_info): Add destructor and
4606         initializers.
4607         (objfiles_pspace_data): Change type.
4608         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4609         (get_objfile_pspace_data): Update.
4610         (objfiles_bfd_data): Change type.
4611         (get_objfile_bfd_data): Update.
4612         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4613
4614 2019-05-08  Tom Tromey  <tom@tromey.com>
4615
4616         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4617         Change type.
4618         (get_catch_syscall_inferior_data): Update.
4619         (catch_syscall_inferior_data_cleanup): Remove.
4620         (_initialize_break_catch_syscall): Update.
4621
4622 2019-05-08  Tom Tromey  <tom@tromey.com>
4623
4624         * inflow.c (struct terminal_info): Add destructor and
4625         initializers.
4626         (inflow_inferior_data): Change type.
4627         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4628         (get_inflow_inferior_data, inflow_inferior_exit)
4629         (swap_terminal_info, _initialize_inflow): Update.
4630
4631 2019-05-08  Tom Tromey  <tom@tromey.com>
4632
4633         * target-dcache.c (target_dcache_cleanup): Remove.
4634         (target_dcache_aspace_key): Change type.
4635         (target_dcache_init_p, target_dcache_invalidate)
4636         (target_dcache_get, target_dcache_get_or_init)
4637         (_initialize_target_dcache): Update.
4638         * dcache.h (struct dcache_deleter): New.
4639
4640 2019-05-08  Tom Tromey  <tom@tromey.com>
4641
4642         * symtab.c (struct symbol_cache): Add destructor and
4643         initializers.
4644         (symbol_cache_key): Move.  Change type.
4645         (make_symbol_cache, free_symbol_cache): Remove.
4646         (get_symbol_cache): Update.
4647         (symbol_cache_cleanup): Remove.
4648         (ALL_PSPACES, symbol_cache_flush)
4649         (maintenance_print_symbol_cache)
4650         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4651         Update.
4652
4653 2019-05-08  Tom Tromey  <tom@tromey.com>
4654
4655         * symtab.c (struct main_info): Add destructor and initializers.
4656         (main_progspace_key): Move.  Change type.
4657         (get_main_info): Update.
4658         (main_info_cleanup): Remove.
4659         (_initialize_symtab): Update.
4660
4661 2019-05-08  Tom Tromey  <tom@tromey.com>
4662
4663         * registry.h (DECLARE_REGISTRY): Define the _key class.
4664
4665 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4666
4667         * NEWS: Merge two 'New commands' sections.
4668
4669 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4670
4671         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4672         parameter and use Ada language definition instead.
4673         (ada_val_print_ptr): Remove unused language parameter.
4674         (ada_val_print_num): Remove language parameter and use Ada language
4675         definition instead.
4676         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4677         parameter.
4678         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4679         parameter and use Ada language definition instead.
4680         (ada_val_print_1): Update all ada_val_print_xxx calls.
4681         Remove language parameter.
4682         (ada_val_print): Update ada_val_print_1 call.
4683
4684 2019-05-08  Tom Tromey  <tromey@adacore.com>
4685
4686         * remote.c (remote_hw_watchpoint_limit)
4687         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4688         Now static.
4689
4690 2019-05-08  Tom Tromey  <tromey@adacore.com>
4691
4692         * maint.c (_initialize_maint_cmds): Move initialization code to
4693         remote.c.
4694         (watchdog, show_watchdog): Move to remote.c.
4695         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4696         "watchdog" static.
4697         (_initialize_remote): Move initialization code from maint.c.
4698         * defs.h (watchdog): Don't declare.
4699
4700 2019-05-08  Tom Tromey  <tromey@adacore.com>
4701
4702         * tui/tui-interp.c: Include main.h.
4703         * interps.c: Include main.h.
4704         * main.h (interpreter_p): Declare.
4705         * defs.h (interpreter_p): Don't declare.
4706
4707 2019-05-08  Tom Tromey  <tromey@adacore.com>
4708
4709         * dwarf2loc.c: Include dwarf2read.h.
4710         * defs.h (read_unsigned_leb128): Don't declare.
4711         * dwarf2read.h (read_unsigned_leb128): Declare.
4712
4713 2019-05-08  Tom Tromey  <tromey@adacore.com>
4714
4715         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4716         method.
4717
4718 2019-05-08  Tom Tromey  <tromey@adacore.com>
4719
4720         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4721         when no wrap column is set.
4722
4723 2019-05-08  Tom Tromey  <tromey@adacore.com>
4724
4725         * c-lang.c (c_get_string): Handle non-C-style arrays.
4726
4727 2019-05-08  Tom Tromey  <tromey@adacore.com>
4728
4729         * typeprint.c (print_offset_data::update): Print the bit offset,
4730         not the number of bits remaining.
4731
4732 2019-05-08  Tom Tromey  <tromey@adacore.com>
4733
4734         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4735         padding at end of comment.
4736
4737 2019-05-08  Tom Tromey  <tromey@adacore.com>
4738
4739         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4740         Compare main types.
4741
4742 2019-05-06  Tom Tromey  <tom@tromey.com>
4743
4744         * common/scoped_mmap.c: Include common-defs.h.
4745         * common/scoped_mmap.h: Don't include config.h.
4746
4747 2019-05-04  Tom Tromey  <tom@tromey.com>
4748
4749         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4750         (struct aarch64_call_info): Add initializers.
4751         <si>: Now a std::vector.
4752         (pass_on_stack, aarch64_push_dummy_call): Update.
4753
4754 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4755             Tom Tromey  <tom@tromey.com>
4756
4757         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4758         (ppc_threads): Now a std::vector.  Now static.
4759         (hwdebug_find_thread_points_by_tid)
4760         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4761         Update.
4762
4763 2019-05-04  Tom Tromey  <tom@tromey.com>
4764
4765         * arc-tdep.c (arc_tdesc_init): Return bool.
4766
4767 2019-05-04  Tom Tromey  <tom@tromey.com>
4768
4769         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4770         Use gdb_assert_not_reached.
4771
4772 2019-05-04  Tom Tromey  <tom@tromey.com>
4773
4774         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4775         "false".
4776
4777 2019-05-04  Tom Tromey  <tom@tromey.com>
4778
4779         * arc-tdep.c (arc_tdesc_init): Use bool.
4780
4781 2019-05-04  Tom Tromey  <tom@tromey.com>
4782
4783         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4784
4785 2019-05-04  Tom Tromey  <tom@tromey.com>
4786
4787         * cli/cli-cmds.c (valid_command_p): Return bool.
4788
4789 2019-05-04  Tom Tromey  <tom@tromey.com>
4790
4791         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4792         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4793
4794 2019-05-04  Raul Tambre  <raul@tambre.ee>
4795
4796         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4797         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4798         operator for comparison.
4799
4800 2019-05-04  Tom Tromey  <tom@tromey.com>
4801
4802         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4803         (lookup_partial_symbol, print_partial_symbols)
4804         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4805         (psymbol_compare): Update.
4806         (add_psymbol_to_bcache): Clear the entire psymbol.
4807         (maintenance_check_psymtabs): Update.
4808         * psympriv.h (struct partial_symbol): Don't derive from
4809         general_symbol_info.
4810         <obj_section, unrelocated_address, address,
4811         set_unrelocated_address>: Update.
4812         <ginfo>: New member.
4813         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4814         (debug_names::write_psymbols): Update.
4815
4816 2019-05-04  Tom de Vries  <tdevries@suse.de>
4817
4818         * contrib/cc-with-tweaks.sh: Support -n arg.
4819
4820 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4821
4822         * corelow.c (core_target::detach): Ensure frame cache and
4823         register caches are cleared.
4824         inferior.c (exit_inferior_1): Likewise.
4825
4826 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4827             Tom Tromey  <tom@tromey.com>
4828
4829         * dictionary.c (collate_pending_symbols_by_language): Remove
4830         "struct" from foreach.
4831         * symtab.c (lookup_global_symbol_from_objfile)
4832         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4833         foreach.
4834         * ser-tcp.c (net_open): Remove "struct" from foreach.
4835         * objfiles.c (objfile_relocate, objfile_rebase)
4836         (objfile_has_symbols): Remove "struct" from foreach.
4837         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4838         from foreach.
4839         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4840         foreach.
4841         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4842         "struct" from foreach.
4843         * ada-lang.c (create_excep_cond_exprs)
4844         (ada_exception_catchpoint_cond_string): Remove "struct" from
4845         foreach.
4846
4847 2019-05-03  Tom Tromey  <tromey@adacore.com>
4848
4849         * ada-exp.y (convert_char_literal): Check suffix of each
4850         enumerator.
4851
4852 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4853
4854         PR ada/21406:
4855         * ada-exp.y (yywrap): Don't define.
4856         * ada-lex.l (%option): Add noyywrap
4857         (yywrap): Remove.
4858
4859 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4860
4861         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4862         _WIN32_WINNT to the XP level, unless already defined to a higher
4863         level.
4864
4865         * unittests/parse-connection-spec-selftests.c:
4866         * ser-tcp.c:
4867         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4868         override.
4869
4870         * symfile.c (find_separate_debug_file): Remove colon from the
4871         drive spec of DOS/Windows file names of the target, so that the
4872         file name produced from DEBUGDIR and the target's directory will
4873         be valid on DOS/Windows systems.
4874
4875 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4876
4877         * rust-lang.c (val_print_struct): Handle printing structures
4878         containing strings.
4879
4880 2019-05-02  Tom Tromey  <tromey@adacore.com>
4881
4882         * valarith.c (_initialize_valarith): Remove.
4883
4884 2019-05-01  Tom Tromey  <tromey@adacore.com>
4885
4886         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4887         bitfields.
4888
4889 2019-05-01  Tom Tromey  <tromey@adacore.com>
4890
4891         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4892         for big-endian copies.
4893
4894 2019-04-30  Ali Tamur  <tamur@google.com>
4895         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4896         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4897         (read_3_bytes): New function.
4898
4899 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4900
4901         * windows-nat.c (main_thread_id): Delete.
4902         (handle_output_debug_string): Replace main_thread_id by
4903         current_event.dwThreadId.
4904         (fake_create_process): Likewise.
4905         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4906         Do not set main_thread_id.
4907         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4908         current_event.dwThreadId.
4909         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4910
4911 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4912
4913         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4914         Use current_event.dwThreadId instead of main_thread_id.
4915
4916 2019-04-30  Tom Tromey  <tromey@adacore.com>
4917
4918         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4919         (create_excep_cond_exprs): Iterate over program spaces.
4920         (ada_exception_catchpoint_cond_string): Examine all minimal
4921         symbols for exception types.
4922
4923 2019-04-30  Tom Tromey  <tromey@adacore.com>
4924
4925         PR c++/24470:
4926         * dwarf2read.c (process_structure_scope): Handle case where type
4927         has template parameters but no symbol was created.
4928
4929 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4930             Chris January  <chris.january@arm.com>
4931
4932         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4933         qualifier.
4934         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4935
4936 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4937
4938         * f-typeprint.c (f_print_type): Update rules for printing
4939         whitespace.
4940         (f_type_print_varspec_suffix): Likewise.
4941
4942 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4943             Chris January  <chris.january@arm.com>
4944
4945         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4946         function arguments.
4947
4948 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4949
4950         * f-lang.c (build_fortran_types): Change name of void type to
4951         lower case.
4952         * f-typeprint.c (f_type_print_base): Print the name of the void
4953         type, rather than a fixed string.
4954         * f-valprint.c (f_decorations): Use lower case void string.
4955
4956 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4957             Chris January  <chris.january@arm.com>
4958
4959         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4960         types for Fortran.
4961
4962 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4963             Chris January  <chris.january@arm.com>
4964             David Lecomber  <david.lecomber@arm.com>
4965
4966         * f-exp.y (BINOP_INTRINSIC): New token.
4967         (exp): New parser rule handling BINOP_INTRINSIC.
4968         (f77_keywords): Add new builtin procedures.
4969         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4970         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4971         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4972         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4973         (print_unop_subexp_f): New function.
4974         (print_binop_subexp_f): New function.
4975         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4976         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4977         (dump_subexp_body_f): Likewise.
4978         (operator_check_f): Likewise.
4979         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4980         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4981
4982 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4983
4984         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4985         UNOP_KIND.
4986         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4987         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4988         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4989         (operator_length_f): New fuction.
4990         (print_subexp_f): New function.
4991         (op_name_f): New function.
4992         (dump_subexp_body_f): New function.
4993         (operator_check_f): New function.
4994         (exp_descriptor_f): Replace standard expression handling functions
4995         with new functions.
4996         * gdb/fortran-operator.def: New file.
4997         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4998         * gdb/std-operator.def: Remove UNOP_KIND.
4999
5000 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5001
5002         * std-operator.def: Remove unbalanced, stray double quote
5003         character.
5004
5005 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5006             Chris January  <chris.january@arm.com>
5007             Daniel Everett  <daniel.everett@arm.com>
5008             Nick Forrington  <nick.forrington@arm.com>
5009             Richard Bunt  <richard.bunt@arm.com>
5010
5011         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5012         of depth when printing anonymous structs or unions.
5013         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5014         Don't print either the top-level value, or the children if the
5015         max-depth is exceeded.
5016         (ppscm_print_children): When printing the key of a map, allow one
5017         extra level of depth.
5018         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5019         print either the top-level value, or the children if the max-depth
5020         is exceeded.
5021         (print_children): When printing the key of a map, allow one extra
5022         level of depth.
5023         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5024         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5025         (user_print_options): Initialise max_depth field.
5026         (val_print_scalar_or_string_type_p): New function.
5027         (val_print): Check to see if the max depth has been reached.
5028         (val_print_check_max_depth): Define new function.
5029         (show_print_max_depth): New function.
5030         (_initialize_valprint): Add 'print max-depth' option.
5031         * valprint.h (struct value_print_options) <max_depth>: New field.
5032         (val_print_check_max_depth): Declare new function.
5033         * NEWS: Document new feature.
5034
5035 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5036
5037         * ada-lang.c (ada_language_defn): Initialise new field.
5038         * c-lang.c (c_is_string_type_p): New function.
5039         (c_language_defn): Initialise new field.
5040         (cplus_language_defn): Initialise new field.
5041         (asm_language_defn): Initialise new field.
5042         (minimal_language_defn): Initialise new field.
5043         * c-lang.h (c_is_string_type_p): Declare new function.
5044         * d-lang.c (d_language_defn): Initialise new field.
5045         * f-lang.c (f_is_string_type_p): New function.
5046         (f_language_defn): Initialise new field.
5047         * go-lang.c (go_is_string_type_p): New function.
5048         (go_language_defn): Initialise new field.
5049         * language.c (default_is_string_type_p): New function.
5050         (unknown_language_defn): Initialise new field.
5051         (auto_language_defn): Initialise new field.
5052         * language.h (struct language_defn) <la_is_string_type_p>: New
5053         member variable.
5054         (default_is_string_type_p): Declare new function.
5055         * m2-lang.c (m2_language_defn): Initialise new field.
5056         * objc-lang.c (objc_language_defn): Initialise new field.
5057         * opencl-lang.c (opencl_language_defn): Initialise new field.
5058         * p-lang.c (pascal_is_string_type_p): New function.
5059         (pascal_language_defn): Initialise new field.
5060         * rust-lang.c (rust_is_string_type_p): New function.
5061         (rust_language_defn): Initialise new field.
5062
5063 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5064
5065         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5066         New field.
5067         * ada-lang.c (ada_language_defn): Initialise new field.
5068         * c-lang.c (c_language_defn): Likewise.
5069         (cplus_language_defn): Likewise.
5070         (asm_language_defn): Likewise.
5071         (minimal_language_defn): Likewise.
5072         * d-lang.c (d_language_defn): Likewise.
5073         * f-lang.c (f_language_defn): Likewise.
5074         * go-lang.c (go_language_defn): Likewise.
5075         * language.c (unknown_language_defn): Likewise.
5076         (auto_language_defn): Likewise.
5077         * m2-lang.c (m2_language_defn): Likewise.
5078         * objc-lang.c (objc_language_defn): Likewise.
5079         * opencl-lang.c (opencl_language_defn): Likewise.
5080         * p-lang.c (pascal_language_defn): Likewise.
5081         * rust-lang.c (rust_language_defn): Likewise.
5082
5083 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5084
5085         * ada-lang.c (ada_is_character_type): Change return type to bool.
5086         (ada_is_string_type): Likewise.
5087         * ada-lang.h (ada_is_character_type): Update declaration
5088         (ada_is_string_type): Likewise.
5089
5090 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5091
5092         Support style in 'frame|thread apply'
5093
5094         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5095         * record.c (record_start, record_stop): Update callers of
5096         execute_command_to_string with false.
5097         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5098         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5099         methods.
5100         (class string_file): New constructor with term_out parameter.
5101         Override methods term_out and can_emit_style_escape.  New member
5102         term_out.
5103         (class stdio_file): Override can_emit_style_escape.
5104         (class tee_file): Override term_out and can_emit_style_escape.
5105         * utils.h (can_emit_style_escape): Remove.
5106         * utils.c (can_emit_style_escape): Likewise.
5107         Update all callers of can_emit_style_escape (SOMESTREAM) to
5108         SOMESTREAM->can_emit_style_escape.
5109         * source-cache.c (source_cache::get_source_lines): Likewise.
5110         * stack.c (frame_apply_command_count): Call execute_command_to_string
5111         passing the term_out characteristic of the current gdb_stdout.
5112         * thread.c (thr_try_catch_cmd): Likewise.
5113         * top.c (execute_command_to_string): pass term_out parameter
5114         to construct the string_file for the command output.
5115         * ui-file.c (term_cli_styling): New function (most code moved
5116         from utils.c can_emit_style_escape).
5117         (string_file::string_file, string_file::can_emit_style_escape,
5118         stdio_file::can_emit_style_escape, tee_file::term_out,
5119         tee_file::can_emit_style_escape): New functions.
5120
5121 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5122
5123         * NEWS: Mention the new set|show may-call-functions.
5124         * infcall.c (may_call_functions_p): New variable.
5125         (show_may_call_functions_p): New function.
5126         (call_function_by_hand_dummy): Throws an error if not
5127         may-call-functions.
5128         (_initialize_infcall): Call add_setshow_boolean_cmd for
5129         may-call-functions.
5130
5131 2019-04-25  Keith Seitz  <keiths@redhat.com>
5132
5133         PR c++/24367
5134         * cp-support.c (inspect_type): Don't attempt substitutions
5135         of symbol with the same name.
5136
5137 2019-04-25  Tom Tromey  <tromey@adacore.com>
5138
5139         PR gdb/24475:
5140         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5141         static.
5142
5143 2019-04-25  Tom Tromey  <tromey@adacore.com>
5144
5145         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5146         rvalue reference.
5147         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5148         (gdb_xml_parser::parse): Use std::move.
5149         * python/python-internal.h (gdbpy_convert_exception): Take a const
5150         reference.
5151         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5152         std::move.
5153         * python/py-utils.c (gdbpy_convert_exception): Take a const
5154         reference.
5155         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5156         Use std::move.
5157         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5158         Use std::move.
5159         * mi/mi-main.c (mi_print_exception): Take a const reference.
5160         * main.c (handle_command_errors): Take a const reference.
5161         * linespec.c (parse_linespec): Use std::move.
5162         * infcall.c (run_inferior_call): Use std::move.
5163         (call_function_by_hand_dummy): Use std::move.
5164         * exec.c (try_open_exec_file): Use std::move.
5165         * exceptions.h (exception_print, exception_fprintf)
5166         (exception_print_same): Update.
5167         * exceptions.c (print_exception, exception_print)
5168         (exception_fprintf, exception_print_same): Change parameters to
5169         const reference.
5170         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5171         * common/new-op.c: Use std::move.
5172         * common/common-exceptions.h (struct gdb_exception): Add move
5173         constructor.
5174         (struct gdb_exception_error, struct gdb_exception_quit, struct
5175         gdb_quit_bad_alloc): Change constructor to move constructor.
5176         (throw_exception): Change parameter to rvalue reference.
5177         * common/common-exceptions.c (throw_exception): Take rvalue
5178         reference.
5179         * cli/cli-interp.c (safe_execute_command): Use std::move.
5180         * breakpoint.c (insert_bp_location, location_to_sals): Use
5181         std::move.
5182
5183 2019-04-25  Tom Tromey  <tromey@adacore.com>
5184
5185         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5186         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5187         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5188         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5189         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5190         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5191         guile/scm-value.c: Use unpack.
5192         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5193         gdbscm_gdb_exception.
5194         (gdbscm_throw_gdb_exception): Likewise.
5195         (struct gdbscm_gdb_exception): New.
5196         (unpack): New function.
5197         (gdbscm_wrap): Use unpack.
5198
5199 2019-04-25  Tom Tromey  <tromey@adacore.com>
5200
5201         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5202         (gdb_rl_callback_handler): Use std::move.
5203         * common/common-exceptions.h (struct gdb_exception): Add move
5204         assignment operator.
5205         (throw_exception_sjlj): Change "exception" to const reference.
5206         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5207         (throw_exception_sjlj): Change "exception" to const reference.
5208
5209 2019-04-25  Tom Tromey  <tromey@adacore.com>
5210
5211         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5212         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5213         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5214         Update.
5215         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5216         Update.
5217         * mi/mi-interp.c (mi_interp::exec): Update.
5218         * linespec.c (parse_linespec): Update.
5219         * infcall.c (run_inferior_call): Update.
5220         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5221         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5222         (gdbscm_lookup_global_symbol): Update.
5223         * guile/scm-param.c (gdbscm_parameter_value): Update.
5224         * guile/scm-frame.c (gdbscm_frame_read_register)
5225         (gdbscm_frame_read_var): Update.
5226         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5227         * exec.c (try_open_exec_file): Update.
5228         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5229         (gdb_rl_callback_handler): Update.
5230         * common/common-exceptions.h (exception_none): Don't declare.
5231         * common/common-exceptions.c (exception_none): Don't define.
5232         (struct catcher) <exception>: Update.
5233         * cli/cli-interp.c (safe_execute_command): Update.
5234         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5235
5236 2019-04-25  Ali Tamur  <tamur@google.com>
5237
5238         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5239         (read_attribute_value): Likewise.
5240         (dwarf2_read_addr_index): Update comment.
5241         (read_str_index): Add DW_FORM_strx.
5242         (dwarf2_string_attr): Likewise.
5243         (dwarf2_const_value_attr): Likewise.
5244         (dump_die_shallow): Likewise.
5245         (dwarf2_fetch_constant_bytes): Likewise.
5246         (skip_form_bytes): Likewise.
5247         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5248
5249 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5250
5251         PR corefiles/11608
5252         PR corefiles/18187
5253         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5254         OFFSET.  Verify if current mapping contains an ELF header.
5255         (linux_find_memory_regions_full): Adjust call to
5256         dump_mapping_p.
5257
5258 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5259             Kang Li <kanglictf@gmail.com>
5260
5261         PR gdb/21600
5262
5263         * dwarf2-frame.c (read_initial_length): Be consistent about using
5264         unsigned representation of length.
5265         (decode_frame_entry_1): Likewise.  Check for wraparound of
5266         end pointer as well as buffer overflow.
5267
5268 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5269
5270         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5271         "vq".
5272
5273 2019-04-24  Tom Tromey  <tromey@adacore.com>
5274
5275         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5276
5277 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5278
5279         * s12z-tdep.c (s12z_unwind_pc): Delete.
5280         (s12z_unwind_sp): Delete.
5281         (s12z_gdbarch_init): Don't register deleted functions with
5282         gdbarch.
5283
5284 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5285
5286         * rl78-tdep.c (rl78_unwind_sp): Delete.
5287         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5288
5289 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5290
5291         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5292         (xstormy16_unwind_pc): Delete.
5293         (xstormy16_dummy_id): Delete.
5294         (xstormy16_gdbarch_init): Don't register deleted functions with
5295         gdbarch.
5296
5297 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5298
5299         * vax-tdep.c (vax_unwind_pc): Delete.
5300         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5301
5302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5303
5304         * v850-tdep.c (v850_unwind_sp): Delete.
5305         (v850_unwind_pc): Delete.
5306         (v850_dummy_id): Delete.
5307         (v850_gdbarch_init): Don't register deleted functions with
5308         gdbarch.
5309
5310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5311
5312         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5313         (tilegx_unwind_pc): Delete.
5314         (tilegx_unwind_dummy_id): Delete.
5315         (tilegx_gdbarch_init): Don't register deleted functions with
5316         gdbarch.
5317
5318 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5319
5320         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5321         (tic6x_dummy_id): Delete.
5322         (tic6x_gdbarch_init): Don't register deleted functions with
5323         gdbarch.
5324
5325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5326
5327         * sparc-tdep.c (sparc_unwind_pc): Delete.
5328         (sparc32_gdbarch_init): Don't register deleted function with
5329         gdbarch.
5330
5331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5332
5333         * sh-tdep.c (sh_unwind_sp): Delete.
5334         (sh_unwind_pc): Delete.
5335         (sh_dummy_id): Delete.
5336         (sh_gdbarch_init): Don't register deleted functions with
5337         gdbarch.
5338
5339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5340
5341         * score-tdep.c (score_unwind_sp): Delete.
5342         (score_unwind_pc): Delete.
5343         (score_dummy_id): Delete.
5344         (score_gdbarch_init): Don't register deleted functions with
5345         gdbarch.
5346
5347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5348
5349         * rx-tdep.c (rx_unwind_pc): Delete.
5350         (rx_unwind_sp): Delete.
5351         (rx_dummy_id): Delete.
5352         (rx_gdbarch_init): Don't register deleted functions with
5353         gdbarch.  Update comment.
5354
5355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5356
5357         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5358         (rs6000_dummy_id): Delete.
5359         (rs6000_gdbarch_init): Don't register deleted functions with
5360         gdbarch.
5361
5362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5363
5364         * or1k-tdep.c (or1k_dummy_id): Delete.
5365         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5366
5367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5368
5369         * nios2-tdep.c (nios2_dummy_id): Delete.
5370         (nios2_unwind_sp): Delete.
5371         (nios2_gdbarch_init): Don't register deleted functions with
5372         gdbarch.
5373
5374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5375
5376         * nds32-tdep.c (nds32_dummy_id): Delete.
5377         (nds32_unwind_pc): Delete.
5378         (nds32_unwind_sp): Delete.
5379         (nds32_gdbarch_init): Don't register deleted functions with
5380         gdbarch.
5381
5382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5383
5384         * msp430-tdep.c (msp430_unwind_pc): Delete.
5385         (msp430_unwind_sp): Delete.
5386         (msp430_dummy_id): Delete.
5387         (msp430_gdbarch_init): Don't register deleted functions with
5388         gdbarch.
5389
5390 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5391
5392         * moxie-tdep.c (moxie_unwind_sp): Delete.
5393         (moxie_unwind_pc): Delete.
5394         (moxie_dummy_id): Delete.
5395         (moxie_gdbarch_init): Don't register deleted functions with
5396         gdbarch.
5397
5398 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5399
5400         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5401         (mn10300_unwind_pc): Delete.
5402         (mn10300_unwind_sp): Delete.
5403         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5404         mn10300_unwind_sp.
5405         (mn10300_frame_unwind_init): Don't register deleted functions with
5406         gdbarch.
5407
5408 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5409
5410         * mep-tdep.c (mep_unwind_pc): Delete.
5411         (mep_unwind_sp): Delete.
5412         (mep_dummy_id): Delete.
5413         (mep_gdbarch_init): Don't register deleted functions with
5414         gdbarch.
5415
5416 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5417
5418         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5419         (m68hc11_unwind_sp): Delete.
5420         (m68hc11_gdbarch_init): Don't register deleted functions with
5421         gdbarch.
5422
5423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5424
5425         * m32r-tdep.c (m32r_unwind_sp): Delete.
5426         (m32r_unwind_pc): Delete.
5427         (m32r_dummy_id): Delete.
5428         (m32r_gdbarch_init): Don't register deleted functions with
5429         gdbarch.
5430
5431 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5432
5433         * m32c-tdep.c (m32c_unwind_pc): Delete.
5434         (m32c_unwind_sp): Delete.
5435         (m32c_dummy_id): Delete.
5436         (m32c_gdbarch_init): Don't register deleted functions with
5437         gdbarch.
5438
5439 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5440
5441         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5442         (lm32_unwind_pc): Delete.
5443         (lm32_dummy_id): Delete.
5444         (lm32_gdbarch_init): Don't register deleted functions with
5445         gdbarch.
5446
5447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5448
5449         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5450         (iq2000_unwind_pc): Delete.
5451         (iq2000_dummy_id): Delete.
5452         (iq2000_gdbarch_init): Don't register deleted functions with
5453         gdbarch.
5454
5455 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5456
5457         * nds32-tdep.c (nds32_type_align): Delete.
5458         (nds32_push_dummy_call): Use type_align instead.
5459
5460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5461
5462         * arm-tdep.c (arm_type_align): Only handle vector override case.
5463         (arm_push_dummy_call): Use type_align.
5464         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5465
5466 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5467
5468         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5469         case.
5470         (pass_on_stack): Use type_align.
5471         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5472         function.
5473
5474 2019-04-23  Tom Tromey  <tromey@adacore.com>
5475
5476         * dwarf2read.c (line_header::file_name_at): Remove unused
5477         overload.
5478
5479 2019-04-23  Tom de Vries  <tdevries@suse.de>
5480
5481         PR gdb/24438
5482         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5483         invocation.
5484
5485
5486 2019-03-27  Ali Tamur  <tamur@google.com>
5487
5488         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5489         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5490         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5491         (dwarf_expr_context::get_addr_index): Likewise
5492         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5493         (symbol_needs_eval_context::get_addr_index): Likewise
5494         (disassemble_dwarf_expression): Add DW_OP_addrx
5495         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5496         (read_cutu_die_from_dwo): Update comment
5497         (skip_one_die): Add DW_FORM_addrx
5498         (read_attribute_value): Likewise
5499         (var_decode_location): Add DW_OP_addrx
5500         (dwarf2_const_value_attr): Add DW_FORM_addrx
5501         (dump_die_shallow): Likewise
5502         (dwarf2_fetch_constant_bytes): Likewise
5503         (decode_locdesc): Add DW_OP_addrx
5504         (skip_form_bytes): Add DW_FORM_addrx
5505
5506 2019-04-22  Ali Tamur  <tamur@google.com>
5507
5508         * MAINTAINERS (Write After Approval): Add self.
5509
5510 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5511
5512         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5513         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5514         (open_symbol_file_object): Likewise.
5515         (svr4_default_sos): Add info parameter.
5516         (svr4_read_so_list): Likewise.
5517         (svr4_current_sos_direct): Adjust functions calls to pass down
5518         info.
5519         (svr4_current_sos_1): Add info parameter.
5520         (svr4_current_sos): Call get_svr4_info, pass info down to
5521         svr4_current_sos_1.
5522         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5523         get_svr4_info.
5524         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5525         get_svr4_info.
5526         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5527         to get_svr4_info.
5528         (probes_table_remove_objfile_probes): Likewise.
5529         (register_solib_event_probe): Add info parameter.
5530         (solist_update_incremental): Pass info parameter down to
5531         svr4_read_so_list.
5532         (disable_probes_interface): Add info parameter.
5533         (svr4_handle_solib_event): Pass current_program_space to
5534         get_svr4_info.  Adjust disable_probes_interface cleanup.
5535         (svr4_create_probe_breakpoints): Add info parameter, pass it
5536         down to register_solib_event_probe.
5537         (svr4_create_solib_event_breakpoints): Add info parameter,
5538         pass it down to svr4_create_probe_breakpoints.
5539         (enable_break): Pass info down to
5540         svr4_create_solib_event_breakpoints.
5541         (svr4_solib_create_inferior_hook): Pass current_program_space to
5542         get_svr4_info.
5543         (svr4_clear_solib): Likewise.
5544
5545 2019-04-22  Pedro Alves  <palves@redhat.com>
5546
5547         * solib-svr4.c (svr4_free_objfile_observer): New.
5548         (probe_and_action::objfile): New field.
5549         (probes_table_htab_remove_objfile_probes)
5550         (probes_table_remove_objfile_probes): New functions.
5551         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5552         in the new probe_and_action.  Don't store the probe in 'lookup'.
5553         (svr4_create_probe_breakpoints): Pass objfile to
5554         register_solib_event_probe.
5555         (_initialize_svr4_solib): Register a free_objfile observer.
5556
5557 2019-04-19  Tom Tromey  <tom@tromey.com>
5558
5559         * common/queue.h: Remove.
5560
5561 2019-04-19  Tom Tromey  <tom@tromey.com>
5562
5563         * event-loop.c: Don't include "common/queue.h".
5564
5565 2019-04-19  Tom Tromey  <tom@tromey.com>
5566
5567         * remote.c (remote_target): Use delete.
5568         * remote-notif.h: Include <list>, not "common/queue.h".
5569         (notif_client_p): Remove typedef.
5570         (remote_notif_state): Add constructor, destructor, initializer.
5571         <notif_queue>: Now a std::list.
5572         (remote_notif_state_xfree): Don't declare.
5573         * remote-notif.c (remote_notif_process, handle_notification)
5574         (remote_notif_state_allocate): Update.
5575         (~remote_notif_state): Rename from remote_notif_state_xfree.
5576
5577 2019-04-19  Tom Tromey  <tom@tromey.com>
5578
5579         * symfile.c (reread_symbols): Update.
5580         * objfiles.c (objfile_register_static_link)
5581         (objfile_lookup_static_link): Update
5582         (~objfile) Don't delete static_links.
5583         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5584
5585 2019-04-19  Tom Tromey  <tom@tromey.com>
5586
5587         * type-stack.h (struct type_stack) <insert>: Constify string.
5588         * type-stack.c (type_stack::insert): Constify string.
5589         * gdbtypes.h (lookup_template_type): Update.
5590         (address_space_name_to_int): Update.
5591         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5592         const.
5593         (lookup_template_type): Make name const.
5594         * c-exp.y: Update rules.
5595         (lex_one_token, classify_name, classify_inner_name)
5596         (c_print_token): Update.
5597         * p-exp.y: Update rules.
5598         (yylex): Update.
5599         * f-exp.y: Update rules.
5600         (yylex): Update.
5601         * d-exp.y: Update rules.
5602         (lex_one_token, classify_name, classify_inner_name): Update.
5603         * parse.c (write_dollar_variable, copy_name): Return std::string.
5604         * parser-defs.h (copy_name): Change return type.
5605         * m2-exp.y: Update rules.
5606         (yylex): Update.
5607         * go-exp.y (lex_one_token): Update.
5608         Update rules.
5609         (classify_unsafe_function, classify_packaged_name)
5610         (classify_name, yylex): Update.
5611
5612 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5613
5614         * configure.ac: add --enable-source-highlight switch.
5615         * configure: Regenerate.
5616         * top.c (print_gdb_version): plumb --enable-source-highlight
5617         status to "show configuration".
5618
5619 2019-04-19  Tom Tromey  <tromey@adacore.com>
5620
5621         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5622         Check ADA_TYPE_P.
5623         (empty_record, ada_template_to_fixed_record_type_1)
5624         (template_to_static_fixed_type)
5625         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5626         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5627         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5628         macros.
5629
5630 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5631
5632         PR symtab/24423:
5633         * source.c (print_source_lines_base): Advance "iter" when a
5634         control character is seen.
5635
5636 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5637
5638         * inferior.h (struct infcall_suspend_state_deleter):
5639         Catch exception in destructor to avoid crash.
5640
5641 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5642
5643         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5644         close to the add_com "shell".
5645
5646 2019-04-18  Tom Tromey  <tromey@adacore.com>
5647
5648         * process-stratum-target.h (class process_stratum_target)
5649         <stratum>: Add "final".
5650
5651 2019-04-17  Tom Tromey  <tromey@adacore.com>
5652
5653         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5654         against nullptr before use.
5655
5656 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5657
5658         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5659
5660 2019-04-17  Jim Wilson  <jimw@sifive.com>
5661             Andrew Burgess  <andrew.burgess@embecosm.com>
5662
5663         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5664         code read might fail, assume 4-byte breakpoint in that case.
5665
5666 2019-04-15  Leszek Swirski  <leszeks@google.com>
5667
5668         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5669         rather than a hand-rolled POD check when checking for forced MEMORY
5670         classification.
5671
5672 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5673
5674         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5675         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5676         function.
5677         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5678         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5679         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5680         declaration.
5681
5682 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5683
5684         * aarch64-linux-nat.c
5685         (aarch64_linux_nat_target::thread_architecture): Add override.
5686         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5687         each VQ.
5688
5689 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5690
5691         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5692
5693 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5694
5695         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5696         target types of size 96-bits, add some additional comments, and
5697         check that the builtin type we found was the correct size.
5698
5699 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5700
5701         * utils.c (prompt_for_continue): Don't restore the styling at the
5702         end, as applied_style has the wrong value.  This fixes styling in
5703         long lists of file names that are interrupted by the "Continue?"
5704         prompt.
5705
5706 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5707
5708         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5709         * c-lang.c (c_language_defn): Likewise.
5710         (cplus_language_defn): Likewise.
5711         (asm_language_defn): Likewise.
5712         (minimal_language_defn): Likewise.
5713         * d-lang.c (d_language_defn): Likewise.
5714         * f-lang.c (f_language_defn): Likewise.
5715         * go-lang.c (go_language_defn): Likewise.
5716         * language.c (unknown_language_defn): Likewise.
5717         (auto_language_defn): Likewise.
5718         * language.h (struct language_defn): Remove la_magic field.
5719         (LANG_MAGIC): Delete.
5720         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5721         * objc-lang.c (objc_language_defn): Likewise.
5722         * opencl-lang.c (opencl_language_defn): Likewise.
5723         * p-lang.c (pascal_language_defn): Likewise.
5724         * rust-lang.c (rust_language_defn): Likewise.
5725
5726 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5727
5728         * riscv-tdep.c (riscv_type_align): New function.
5729         (riscv_type_alignment): Delete.
5730         (riscv_arg_location): Use 'type_align'.
5731         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5732
5733 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5734
5735         * gdbtypes.c (type_align): A struct with no non-static fields also
5736         has alignment of 1.
5737
5738 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5739
5740         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5741         component to 0.
5742         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5743         member.
5744         (riscv_struct_info::analyse): New implementation using new
5745         analyse_inner member function.
5746         (riscv_struct_info::field_offset): New member function.
5747         (riscv_struct_info::m_offsets): New member variable.
5748         (riscv_struct_info::analyse_inner): New private member function,
5749         takes the old implementation of riscv_struct_info::analyse but
5750         extended to track field offsets.
5751         (riscv_call_arg_struct): Update the struct folding special cases
5752         to handle cases where empty C++ structs, which are non-zero
5753         length, are found.
5754         (riscv_arg_location): Initialise the length of each location, a
5755         non-zero length now indicates the location is in use.
5756         (riscv_push_dummy_call): Allow for the first location having a
5757         non-zero offset when setting up arguments.
5758         (riscv_return_value): Likewise, but for return values.
5759
5760 2019-04-11  Tom Tromey  <tromey@adacore.com>
5761
5762         * utils.c (internal_vproblem): Make "msg" const.
5763
5764 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5765
5766         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5767         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5768         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5769         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5770
5771 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5772
5773         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5774         function.
5775         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5776         of amd64_collect_native_gregset.
5777         (amd64_linux_nat_target::store_registers): Likewise.
5778
5779 2019-04-10  Tom Tromey  <tom@tromey.com>
5780
5781         * symtab.c (lookup_global_symbol_from_objfile)
5782         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5783         * objfiles.h (class separate_debug_iterator): New.
5784         (class separate_debug_range): New.
5785         (struct objfile) <separate_debug_objfiles>: New method.
5786         (objfile_separate_debug_iterate): Don't declare.
5787         * objfiles.c (separate_debug_iterator::operator++): Rename from
5788         objfile_separate_debug_iterate.
5789         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5790         iterator.
5791         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5792         iterator.
5793
5794 2019-04-10  Tom Tromey  <tom@tromey.com>
5795
5796         * symfile.c (reread_symbols): Remove old comment.
5797         * objfiles.c (free_all_objfiles): Fix a typo.
5798
5799 2019-04-10  Tom Tromey  <tom@tromey.com>
5800
5801         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5802         * minsyms.c (lookup_minimal_symbol): Use foreach.
5803         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5804         (lookup_minimal_symbol_solib_trampoline): Likewise.
5805         * symfile.c (reread_symbols): Use foreach.
5806
5807 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5808             Tom Tromey  <tromey@adacore.com>
5809
5810         PR rust/24414:
5811         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5812         (rust_lex_int_test): Change "value" to be LONGEST.
5813         (rust_lex_tests): Add test for long integer literal.
5814
5815 2019-04-09  Tom Tromey  <tromey@adacore.com>
5816
5817         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5818         to bool.
5819         (extended_remote_target::attach): Update.
5820         (remote_target::remote_notice_new_inferior): Update.
5821         (remote_target::add_current_inferior_and_thread): Update.
5822         * inferior.c (exit_inferior_1): Use "false".
5823         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5824
5825 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5826
5827         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5828         the "start" command.
5829
5830 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5831
5832         * python/py-inferior.c (infpy_thread_from_thread_handle):
5833         Adjust comments to reflect renaming of thread_from_thread_handle
5834         to thread_from_handle.  Adjust keywords.  Fix type error message.
5835         (inferior_object_methods): Add thread_from_handle.  Retain
5836         thread_from_thread_handle, but mark it as deprecated.
5837
5838 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5839
5840         * gdbthread.h (find_thread_by_handle): Revise declaration.
5841         * thread.c (find_thread_by_handle): Likewise.  Adjust
5842         implementation too.
5843         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5844         support for buffer objects as handles.
5845
5846 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5847
5848         * python/py-infthread.c (thpy_thread_handle): New function.
5849         (thread_object_methods): Register thpy_thread_handle.
5850
5851 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5852
5853         * gdbthread.h (thread_to_thread_handle): Declare.
5854         * thread.c (gdbtypes.h): Include.
5855         (thread_to_thread_handle): New function.
5856
5857         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5858         (target_thread_info_to_thread_handle): Declare.
5859         * target.c (target_thread_info_to_thread_handle): New function.
5860         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5861         * target-delegates.c: Regenerate.
5862
5863         * linux-thread-db.c (class thread_db_target): Add method
5864         thread_info_to_thread_handle.
5865         (thread_db_target::thread_info_to_thread_handle): Define.
5866         * remote.c (class remote_target): Add new method
5867         thread_info_to_thread_handle.
5868         (remote_target::thread_info_to_thread_handle): Define.
5869
5870 2019-04-08  Pedro Alves  <palves@redhat.com>
5871
5872         * common/common-exceptions.c (throw_exception): Don't create
5873         named object to throw; throw directly.
5874         (throw_it): Likewise.  Don't initialize gdb_exception::message
5875         here, with new; pass FMT and AP to the ctor instead.
5876         * common/common-exceptions.h: Include <string>.
5877         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5878         const char *, va_list)): New ctor.  Use std::make_shared.
5879         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5880         errors)): Delete.
5881         (gdb_exception_error::gdb_exception_error(enum errors, const char
5882         *, va_list)): New.
5883         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5884         Add assertion.
5885         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5886         errors)): Delete.
5887         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5888         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5889         Add assertion.
5890
5891 2019-04-08  Tom Tromey  <tom@tromey.com>
5892
5893         * valops.c (value_rtti_indirect_type): Replace throw_exception
5894         with throw.
5895         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5896         with throw.
5897         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5898         throw.
5899         * target.c (target_translate_tls_address): Replace throw_exception
5900         with throw.
5901         * stack.c (frame_apply_command_count): Replace throw_exception
5902         with throw.
5903         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5904         throw.
5905         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5906         with throw.
5907         * rs6000-tdep.c (rs6000_frame_cache)
5908         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5909         * remote.c: Replace throw_exception with throw.
5910         * record-full.c (record_full_message, record_full_wait_1)
5911         (record_full_restore): Replace throw_exception with throw.
5912         * record-btrace.c:
5913         (get_thread_current_frame_id, record_btrace_start_replaying)
5914         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5915         (cmd_record_btrace_start): Replace throw_exception with throw.
5916         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5917         throw.
5918         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5919         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5920         * linespec.c:
5921         (find_linespec_symbols): Replace throw_exception with throw.
5922         * infrun.c (displaced_step_prepare, resume): Replace
5923         throw_exception with throw.
5924         * infcmd.c (post_create_inferior): Replace throw_exception with
5925         throw.
5926         * inf-loop.c (inferior_event_handler): Replace throw_exception
5927         with throw.
5928         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5929         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5930         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5931         (get_prev_frame_always, get_frame_pc_if_available)
5932         (get_frame_address_in_block_if_available, get_frame_language):
5933         Replace throw_exception with throw.
5934         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5935         throw_exception with throw.
5936         * eval.c (fetch_subexp_value, evaluate_var_value)
5937         (evaluate_funcall, evaluate_subexp_standard): Replace
5938         throw_exception with throw.
5939         * dwarf2loc.c (call_site_find_chain)
5940         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5941         Replace throw_exception with throw.
5942         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5943         with throw.
5944         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5945         throw.
5946         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5947         * completer.c (complete_line_internal): Replace throw_exception
5948         with throw.
5949         * compile/compile-object-run.c (compile_object_run): Replace
5950         throw_exception with throw.
5951         * cli/cli-script.c (process_next_line): Replace throw_exception
5952         with throw.
5953         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5954         (btrace_enable, btrace_maint_update_pt_packets): Replace
5955         throw_exception with throw.
5956         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5957         throw_exception with throw.
5958         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5959         throw_exception with throw.
5960         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5961         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5962         * aarch64-tdep.c (aarch64_make_prologue_cache)
5963         (aarch64_make_stub_cache): Replace throw_exception with throw.
5964
5965 2019-04-08  Tom Tromey  <tom@tromey.com>
5966
5967         * common/common-exceptions.c (throw_exception): Rename from
5968         throw_exception_cxx.  Remove old copy.  Make argument const.
5969         (throw_it): Create and throw exception objects directly.
5970         * common/common-exceptions.h (throw_exception): Make argument
5971         const.
5972         (struct gdb_exception_error): Add constructor.
5973         (struct gdb_exception_quit): Add constructor.
5974
5975 2019-04-08  Tom Tromey  <tom@tromey.com>
5976
5977         * common/common-exceptions.h (exception_rethrow): Don't declare.
5978         (TRY_SJLJ): Update comment.
5979         (TRY, CATCH, END_CATCH): Remove.
5980         * common/common-exceptions.c (exception_rethrow): Remove.
5981
5982 2019-04-08  Tom Tromey  <tom@tromey.com>
5983
5984         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5985         Remove.
5986         (gdb_exception_error): Rename from
5987         gdb_exception_RETURN_MASK_ERROR.
5988         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5989         (gdb_quit_bad_alloc): Update.
5990         * aarch64-tdep.c: Update.
5991         * ada-lang.c: Update.
5992         * ada-typeprint.c: Update.
5993         * ada-valprint.c: Update.
5994         * amd64-tdep.c: Update.
5995         * arch-utils.c: Update.
5996         * break-catch-throw.c: Update.
5997         * breakpoint.c: Update.
5998         * btrace.c: Update.
5999         * c-varobj.c: Update.
6000         * cli/cli-cmds.c: Update.
6001         * cli/cli-interp.c: Update.
6002         * cli/cli-script.c: Update.
6003         * common/common-exceptions.c: Update.
6004         * common/new-op.c: Update.
6005         * common/selftest.c: Update.
6006         * compile/compile-c-symbols.c: Update.
6007         * compile/compile-cplus-symbols.c: Update.
6008         * compile/compile-object-load.c: Update.
6009         * compile/compile-object-run.c: Update.
6010         * completer.c: Update.
6011         * corelow.c: Update.
6012         * cp-abi.c: Update.
6013         * cp-support.c: Update.
6014         * cp-valprint.c: Update.
6015         * darwin-nat.c: Update.
6016         * disasm-selftests.c: Update.
6017         * dtrace-probe.c: Update.
6018         * dwarf-index-cache.c: Update.
6019         * dwarf-index-write.c: Update.
6020         * dwarf2-frame-tailcall.c: Update.
6021         * dwarf2-frame.c: Update.
6022         * dwarf2loc.c: Update.
6023         * dwarf2read.c: Update.
6024         * eval.c: Update.
6025         * event-loop.c: Update.
6026         * event-top.c: Update.
6027         * exec.c: Update.
6028         * f-valprint.c: Update.
6029         * fbsd-tdep.c: Update.
6030         * frame-unwind.c: Update.
6031         * frame.c: Update.
6032         * gdbtypes.c: Update.
6033         * gnu-v3-abi.c: Update.
6034         * guile/guile-internal.h: Update.
6035         * guile/scm-block.c: Update.
6036         * guile/scm-breakpoint.c: Update.
6037         * guile/scm-cmd.c: Update.
6038         * guile/scm-disasm.c: Update.
6039         * guile/scm-frame.c: Update.
6040         * guile/scm-lazy-string.c: Update.
6041         * guile/scm-math.c: Update.
6042         * guile/scm-param.c: Update.
6043         * guile/scm-ports.c: Update.
6044         * guile/scm-pretty-print.c: Update.
6045         * guile/scm-symbol.c: Update.
6046         * guile/scm-symtab.c: Update.
6047         * guile/scm-type.c: Update.
6048         * guile/scm-value.c: Update.
6049         * i386-linux-tdep.c: Update.
6050         * i386-tdep.c: Update.
6051         * inf-loop.c: Update.
6052         * infcall.c: Update.
6053         * infcmd.c: Update.
6054         * infrun.c: Update.
6055         * jit.c: Update.
6056         * language.c: Update.
6057         * linespec.c: Update.
6058         * linux-fork.c: Update.
6059         * linux-nat.c: Update.
6060         * linux-tdep.c: Update.
6061         * linux-thread-db.c: Update.
6062         * main.c: Update.
6063         * mi/mi-cmd-break.c: Update.
6064         * mi/mi-cmd-stack.c: Update.
6065         * mi/mi-interp.c: Update.
6066         * mi/mi-main.c: Update.
6067         * objc-lang.c: Update.
6068         * p-valprint.c: Update.
6069         * parse.c: Update.
6070         * ppc-linux-tdep.c: Update.
6071         * printcmd.c: Update.
6072         * python/py-arch.c: Update.
6073         * python/py-breakpoint.c: Update.
6074         * python/py-cmd.c: Update.
6075         * python/py-finishbreakpoint.c: Update.
6076         * python/py-frame.c: Update.
6077         * python/py-framefilter.c: Update.
6078         * python/py-gdb-readline.c: Update.
6079         * python/py-inferior.c: Update.
6080         * python/py-infthread.c: Update.
6081         * python/py-lazy-string.c: Update.
6082         * python/py-linetable.c: Update.
6083         * python/py-objfile.c: Update.
6084         * python/py-param.c: Update.
6085         * python/py-prettyprint.c: Update.
6086         * python/py-progspace.c: Update.
6087         * python/py-record-btrace.c: Update.
6088         * python/py-record.c: Update.
6089         * python/py-symbol.c: Update.
6090         * python/py-type.c: Update.
6091         * python/py-unwind.c: Update.
6092         * python/py-utils.c: Update.
6093         * python/py-value.c: Update.
6094         * python/python.c: Update.
6095         * record-btrace.c: Update.
6096         * record-full.c: Update.
6097         * remote-fileio.c: Update.
6098         * remote.c: Update.
6099         * riscv-tdep.c: Update.
6100         * rs6000-aix-tdep.c: Update.
6101         * rs6000-tdep.c: Update.
6102         * rust-exp.y: Update.
6103         * rust-lang.c: Update.
6104         * s390-tdep.c: Update.
6105         * selftest-arch.c: Update.
6106         * solib-dsbt.c: Update.
6107         * solib-frv.c: Update.
6108         * solib-spu.c: Update.
6109         * solib-svr4.c: Update.
6110         * solib.c: Update.
6111         * sparc64-linux-tdep.c: Update.
6112         * stack.c: Update.
6113         * symfile-mem.c: Update.
6114         * symmisc.c: Update.
6115         * target.c: Update.
6116         * thread.c: Update.
6117         * top.c: Update.
6118         * tracefile-tfile.c: Update.
6119         * tui/tui.c: Update.
6120         * typeprint.c: Update.
6121         * unittests/cli-utils-selftests.c: Update.
6122         * unittests/parse-connection-spec-selftests.c: Update.
6123         * valops.c: Update.
6124         * valprint.c: Update.
6125         * value.c: Update.
6126         * varobj.c: Update.
6127         * windows-nat.c: Update.
6128         * x86-linux-nat.c: Update.
6129         * xml-support.c: Update.
6130
6131 2019-04-08  Tom Tromey  <tom@tromey.com>
6132
6133         * xml-support.c: Use C++ exception handling.
6134         * x86-linux-nat.c: Use C++ exception handling.
6135         * windows-nat.c: Use C++ exception handling.
6136         * varobj.c: Use C++ exception handling.
6137         * value.c: Use C++ exception handling.
6138         * valprint.c: Use C++ exception handling.
6139         * valops.c: Use C++ exception handling.
6140         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6141         handling.
6142         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6143         * typeprint.c: Use C++ exception handling.
6144         * tui/tui.c: Use C++ exception handling.
6145         * tracefile-tfile.c: Use C++ exception handling.
6146         * top.c: Use C++ exception handling.
6147         * thread.c: Use C++ exception handling.
6148         * target.c: Use C++ exception handling.
6149         * symmisc.c: Use C++ exception handling.
6150         * symfile-mem.c: Use C++ exception handling.
6151         * stack.c: Use C++ exception handling.
6152         * sparc64-linux-tdep.c: Use C++ exception handling.
6153         * solib.c: Use C++ exception handling.
6154         * solib-svr4.c: Use C++ exception handling.
6155         * solib-spu.c: Use C++ exception handling.
6156         * solib-frv.c: Use C++ exception handling.
6157         * solib-dsbt.c: Use C++ exception handling.
6158         * selftest-arch.c: Use C++ exception handling.
6159         * s390-tdep.c: Use C++ exception handling.
6160         * rust-lang.c: Use C++ exception handling.
6161         * rust-exp.y: Use C++ exception handling.
6162         * rs6000-tdep.c: Use C++ exception handling.
6163         * rs6000-aix-tdep.c: Use C++ exception handling.
6164         * riscv-tdep.c: Use C++ exception handling.
6165         * remote.c: Use C++ exception handling.
6166         * remote-fileio.c: Use C++ exception handling.
6167         * record-full.c: Use C++ exception handling.
6168         * record-btrace.c: Use C++ exception handling.
6169         * python/python.c: Use C++ exception handling.
6170         * python/py-value.c: Use C++ exception handling.
6171         * python/py-utils.c: Use C++ exception handling.
6172         * python/py-unwind.c: Use C++ exception handling.
6173         * python/py-type.c: Use C++ exception handling.
6174         * python/py-symbol.c: Use C++ exception handling.
6175         * python/py-record.c: Use C++ exception handling.
6176         * python/py-record-btrace.c: Use C++ exception handling.
6177         * python/py-progspace.c: Use C++ exception handling.
6178         * python/py-prettyprint.c: Use C++ exception handling.
6179         * python/py-param.c: Use C++ exception handling.
6180         * python/py-objfile.c: Use C++ exception handling.
6181         * python/py-linetable.c: Use C++ exception handling.
6182         * python/py-lazy-string.c: Use C++ exception handling.
6183         * python/py-infthread.c: Use C++ exception handling.
6184         * python/py-inferior.c: Use C++ exception handling.
6185         * python/py-gdb-readline.c: Use C++ exception handling.
6186         * python/py-framefilter.c: Use C++ exception handling.
6187         * python/py-frame.c: Use C++ exception handling.
6188         * python/py-finishbreakpoint.c: Use C++ exception handling.
6189         * python/py-cmd.c: Use C++ exception handling.
6190         * python/py-breakpoint.c: Use C++ exception handling.
6191         * python/py-arch.c: Use C++ exception handling.
6192         * printcmd.c: Use C++ exception handling.
6193         * ppc-linux-tdep.c: Use C++ exception handling.
6194         * parse.c: Use C++ exception handling.
6195         * p-valprint.c: Use C++ exception handling.
6196         * objc-lang.c: Use C++ exception handling.
6197         * mi/mi-main.c: Use C++ exception handling.
6198         * mi/mi-interp.c: Use C++ exception handling.
6199         * mi/mi-cmd-stack.c: Use C++ exception handling.
6200         * mi/mi-cmd-break.c: Use C++ exception handling.
6201         * main.c: Use C++ exception handling.
6202         * linux-thread-db.c: Use C++ exception handling.
6203         * linux-tdep.c: Use C++ exception handling.
6204         * linux-nat.c: Use C++ exception handling.
6205         * linux-fork.c: Use C++ exception handling.
6206         * linespec.c: Use C++ exception handling.
6207         * language.c: Use C++ exception handling.
6208         * jit.c: Use C++ exception handling.
6209         * infrun.c: Use C++ exception handling.
6210         * infcmd.c: Use C++ exception handling.
6211         * infcall.c: Use C++ exception handling.
6212         * inf-loop.c: Use C++ exception handling.
6213         * i386-tdep.c: Use C++ exception handling.
6214         * i386-linux-tdep.c: Use C++ exception handling.
6215         * guile/scm-value.c: Use C++ exception handling.
6216         * guile/scm-type.c: Use C++ exception handling.
6217         * guile/scm-symtab.c: Use C++ exception handling.
6218         * guile/scm-symbol.c: Use C++ exception handling.
6219         * guile/scm-pretty-print.c: Use C++ exception handling.
6220         * guile/scm-ports.c: Use C++ exception handling.
6221         * guile/scm-param.c: Use C++ exception handling.
6222         * guile/scm-math.c: Use C++ exception handling.
6223         * guile/scm-lazy-string.c: Use C++ exception handling.
6224         * guile/scm-frame.c: Use C++ exception handling.
6225         * guile/scm-disasm.c: Use C++ exception handling.
6226         * guile/scm-cmd.c: Use C++ exception handling.
6227         * guile/scm-breakpoint.c: Use C++ exception handling.
6228         * guile/scm-block.c: Use C++ exception handling.
6229         * guile/guile-internal.h: Use C++ exception handling.
6230         * gnu-v3-abi.c: Use C++ exception handling.
6231         * gdbtypes.c: Use C++ exception handling.
6232         * frame.c: Use C++ exception handling.
6233         * frame-unwind.c: Use C++ exception handling.
6234         * fbsd-tdep.c: Use C++ exception handling.
6235         * f-valprint.c: Use C++ exception handling.
6236         * exec.c: Use C++ exception handling.
6237         * event-top.c: Use C++ exception handling.
6238         * event-loop.c: Use C++ exception handling.
6239         * eval.c: Use C++ exception handling.
6240         * dwarf2read.c: Use C++ exception handling.
6241         * dwarf2loc.c: Use C++ exception handling.
6242         * dwarf2-frame.c: Use C++ exception handling.
6243         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6244         * dwarf-index-write.c: Use C++ exception handling.
6245         * dwarf-index-cache.c: Use C++ exception handling.
6246         * dtrace-probe.c: Use C++ exception handling.
6247         * disasm-selftests.c: Use C++ exception handling.
6248         * darwin-nat.c: Use C++ exception handling.
6249         * cp-valprint.c: Use C++ exception handling.
6250         * cp-support.c: Use C++ exception handling.
6251         * cp-abi.c: Use C++ exception handling.
6252         * corelow.c: Use C++ exception handling.
6253         * completer.c: Use C++ exception handling.
6254         * compile/compile-object-run.c: Use C++ exception handling.
6255         * compile/compile-object-load.c: Use C++ exception handling.
6256         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6257         * compile/compile-c-symbols.c: Use C++ exception handling.
6258         * common/selftest.c: Use C++ exception handling.
6259         * common/new-op.c: Use C++ exception handling.
6260         * cli/cli-script.c: Use C++ exception handling.
6261         * cli/cli-interp.c: Use C++ exception handling.
6262         * cli/cli-cmds.c: Use C++ exception handling.
6263         * c-varobj.c: Use C++ exception handling.
6264         * btrace.c: Use C++ exception handling.
6265         * breakpoint.c: Use C++ exception handling.
6266         * break-catch-throw.c: Use C++ exception handling.
6267         * arch-utils.c: Use C++ exception handling.
6268         * amd64-tdep.c: Use C++ exception handling.
6269         * ada-valprint.c: Use C++ exception handling.
6270         * ada-typeprint.c: Use C++ exception handling.
6271         * ada-lang.c: Use C++ exception handling.
6272         * aarch64-tdep.c: Use C++ exception handling.
6273
6274 2019-04-08  Tom Tromey  <tom@tromey.com>
6275
6276         * xml-support.c (gdb_xml_parser::parse): Update.
6277         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6278         * value.c (show_convenience): Update.
6279         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6280         (test_parse_flags_qcs): Update.
6281         * thread.c (thr_try_catch_cmd): Update.
6282         * target.c (target_translate_tls_address): Update.
6283         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6284         (info_frame_command_core, frame_apply_command_count): Update.
6285         * rust-exp.y (rust_lex_exception_test): Update.
6286         * riscv-tdep.c (riscv_print_one_register_info): Update.
6287         * remote.c (remote_target::enable_btrace): Update.
6288         * record-btrace.c (record_btrace_enable_warn): Update.
6289         * python/py-utils.c (gdbpy_convert_exception): Update.
6290         * printcmd.c (do_one_display, print_variable_and_value): Update.
6291         * mi/mi-main.c (mi_print_exception): Update.
6292         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6293         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6294         * linux-nat.c (linux_nat_target::attach): Update.
6295         * linux-fork.c (class scoped_switch_fork_info): Update.
6296         * infrun.c (displaced_step_prepare): Update.
6297         * infcall.c (call_function_by_hand_dummy): Update.
6298         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6299         * gnu-v3-abi.c (print_one_vtable): Update.
6300         * frame.c (get_prev_frame_always): Update.
6301         * f-valprint.c (info_common_command_for_block): Update.
6302         * exec.c (try_open_exec_file): Update.
6303         * exceptions.c (print_exception, exception_print)
6304         (exception_fprintf, exception_print_same): Update.
6305         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6306         * dwarf-index-cache.c (index_cache::store)
6307         (index_cache::lookup_gdb_index): Update.
6308         * darwin-nat.c (maybe_cache_shell): Update.
6309         * cp-valprint.c (cp_print_value_fields): Update.
6310         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6311         (gcc_cplus_symbol_address): Update.
6312         * compile/compile-c-symbols.c (gcc_convert_symbol)
6313         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6314         * common/selftest.c: Update.
6315         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6316         a std::string.
6317         (exception_try_scope_entry, exception_try_scope_exit): Don't
6318         declare.
6319         (struct exception_try_scope): Remove.
6320         (TRY): Don't use exception_try_scope.
6321         (struct gdb_exception): Add constructor, operator=.
6322         <what>: New method.
6323         (struct gdb_exception_RETURN_MASK_ALL)
6324         (struct gdb_exception_RETURN_MASK_ERROR)
6325         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6326         (struct gdb_quit_bad_alloc): Update.
6327         * common/common-exceptions.c (exception_none): Change
6328         initializer.
6329         (struct catcher) <state, exception>: Initialize inline.
6330         <prev>: Remove member.
6331         (current_catcher): Remove.
6332         (catchers): New global.
6333         (exceptions_state_mc_init): Simplify.
6334         (catcher_pop): Remove.
6335         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6336         (try_scope_depth, exception_try_scope_entry)
6337         (exception_try_scope_exit): Remove.
6338         (throw_exception_sjlj): Update.
6339         (exception_messages, exception_messages_size): Remove.
6340         (throw_it): Simplify.
6341         (gdb_exception_sliced_copy): Remove.
6342         (throw_exception_cxx): Update.
6343         * cli/cli-script.c (script_from_file): Update.
6344         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6345         Update.
6346         * ada-valprint.c (ada_val_print): Update.
6347         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6348         (create_excep_cond_exprs): Update.
6349
6350 2019-04-08  Tom Tromey  <tom@tromey.com>
6351
6352         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6353         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6354         (TRY, CATCH, END_CATCH): Remove some definitions.
6355         * common/common-exceptions.c: Don't use GDB_XCPT.
6356         (catcher_list_size): Remove.
6357         (throw_exception, throw_it): Simplify.
6358
6359 2019-04-05  Tom Tromey  <tom@tromey.com>
6360
6361         Revert the header-sorting patch.
6362         * ft32-tdep.c: Revert.
6363         * frv-tdep.c: Revert.
6364         * frv-linux-tdep.c: Revert.
6365         * frame.c: Revert.
6366         * frame-unwind.c: Revert.
6367         * frame-base.c: Revert.
6368         * fork-child.c: Revert.
6369         * findvar.c: Revert.
6370         * findcmd.c: Revert.
6371         * filesystem.c: Revert.
6372         * filename-seen-cache.h: Revert.
6373         * filename-seen-cache.c: Revert.
6374         * fbsd-tdep.c: Revert.
6375         * fbsd-nat.h: Revert.
6376         * fbsd-nat.c: Revert.
6377         * f-valprint.c: Revert.
6378         * f-typeprint.c: Revert.
6379         * f-lang.c: Revert.
6380         * extension.h: Revert.
6381         * extension.c: Revert.
6382         * extension-priv.h: Revert.
6383         * expprint.c: Revert.
6384         * exec.h: Revert.
6385         * exec.c: Revert.
6386         * exceptions.c: Revert.
6387         * event-top.c: Revert.
6388         * event-loop.c: Revert.
6389         * eval.c: Revert.
6390         * elfread.c: Revert.
6391         * dwarf2read.h: Revert.
6392         * dwarf2read.c: Revert.
6393         * dwarf2loc.c: Revert.
6394         * dwarf2expr.h: Revert.
6395         * dwarf2expr.c: Revert.
6396         * dwarf2-frame.c: Revert.
6397         * dwarf2-frame-tailcall.c: Revert.
6398         * dwarf-index-write.h: Revert.
6399         * dwarf-index-write.c: Revert.
6400         * dwarf-index-common.c: Revert.
6401         * dwarf-index-cache.h: Revert.
6402         * dwarf-index-cache.c: Revert.
6403         * dummy-frame.c: Revert.
6404         * dtrace-probe.c: Revert.
6405         * disasm.h: Revert.
6406         * disasm.c: Revert.
6407         * disasm-selftests.c: Revert.
6408         * dictionary.c: Revert.
6409         * dicos-tdep.c: Revert.
6410         * demangle.c: Revert.
6411         * dcache.h: Revert.
6412         * dcache.c: Revert.
6413         * darwin-nat.h: Revert.
6414         * darwin-nat.c: Revert.
6415         * darwin-nat-info.c: Revert.
6416         * d-valprint.c: Revert.
6417         * d-namespace.c: Revert.
6418         * d-lang.c: Revert.
6419         * ctf.c: Revert.
6420         * csky-tdep.c: Revert.
6421         * csky-linux-tdep.c: Revert.
6422         * cris-tdep.c: Revert.
6423         * cris-linux-tdep.c: Revert.
6424         * cp-valprint.c: Revert.
6425         * cp-support.c: Revert.
6426         * cp-namespace.c: Revert.
6427         * cp-abi.c: Revert.
6428         * corelow.c: Revert.
6429         * corefile.c: Revert.
6430         * continuations.c: Revert.
6431         * completer.h: Revert.
6432         * completer.c: Revert.
6433         * complaints.c: Revert.
6434         * coffread.c: Revert.
6435         * coff-pe-read.c: Revert.
6436         * cli-out.h: Revert.
6437         * cli-out.c: Revert.
6438         * charset.c: Revert.
6439         * c-varobj.c: Revert.
6440         * c-valprint.c: Revert.
6441         * c-typeprint.c: Revert.
6442         * c-lang.c: Revert.
6443         * buildsym.c: Revert.
6444         * buildsym-legacy.c: Revert.
6445         * build-id.h: Revert.
6446         * build-id.c: Revert.
6447         * btrace.c: Revert.
6448         * bsd-uthread.c: Revert.
6449         * breakpoint.h: Revert.
6450         * breakpoint.c: Revert.
6451         * break-catch-throw.c: Revert.
6452         * break-catch-syscall.c: Revert.
6453         * break-catch-sig.c: Revert.
6454         * blockframe.c: Revert.
6455         * block.c: Revert.
6456         * bfin-tdep.c: Revert.
6457         * bfin-linux-tdep.c: Revert.
6458         * bfd-target.c: Revert.
6459         * bcache.c: Revert.
6460         * ax-general.c: Revert.
6461         * ax-gdb.h: Revert.
6462         * ax-gdb.c: Revert.
6463         * avr-tdep.c: Revert.
6464         * auxv.c: Revert.
6465         * auto-load.c: Revert.
6466         * arm-wince-tdep.c: Revert.
6467         * arm-tdep.c: Revert.
6468         * arm-symbian-tdep.c: Revert.
6469         * arm-pikeos-tdep.c: Revert.
6470         * arm-obsd-tdep.c: Revert.
6471         * arm-nbsd-tdep.c: Revert.
6472         * arm-nbsd-nat.c: Revert.
6473         * arm-linux-tdep.c: Revert.
6474         * arm-linux-nat.c: Revert.
6475         * arm-fbsd-tdep.c: Revert.
6476         * arm-fbsd-nat.c: Revert.
6477         * arm-bsd-tdep.c: Revert.
6478         * arch-utils.c: Revert.
6479         * arc-tdep.c: Revert.
6480         * arc-newlib-tdep.c: Revert.
6481         * annotate.h: Revert.
6482         * annotate.c: Revert.
6483         * amd64-windows-tdep.c: Revert.
6484         * amd64-windows-nat.c: Revert.
6485         * amd64-tdep.c: Revert.
6486         * amd64-sol2-tdep.c: Revert.
6487         * amd64-obsd-tdep.c: Revert.
6488         * amd64-obsd-nat.c: Revert.
6489         * amd64-nbsd-tdep.c: Revert.
6490         * amd64-nbsd-nat.c: Revert.
6491         * amd64-nat.c: Revert.
6492         * amd64-linux-tdep.c: Revert.
6493         * amd64-linux-nat.c: Revert.
6494         * amd64-fbsd-tdep.c: Revert.
6495         * amd64-fbsd-nat.c: Revert.
6496         * amd64-dicos-tdep.c: Revert.
6497         * amd64-darwin-tdep.c: Revert.
6498         * amd64-bsd-nat.c: Revert.
6499         * alpha-tdep.c: Revert.
6500         * alpha-obsd-tdep.c: Revert.
6501         * alpha-nbsd-tdep.c: Revert.
6502         * alpha-mdebug-tdep.c: Revert.
6503         * alpha-linux-tdep.c: Revert.
6504         * alpha-linux-nat.c: Revert.
6505         * alpha-bsd-tdep.c: Revert.
6506         * alpha-bsd-nat.c: Revert.
6507         * aix-thread.c: Revert.
6508         * agent.c: Revert.
6509         * addrmap.c: Revert.
6510         * ada-varobj.c: Revert.
6511         * ada-valprint.c: Revert.
6512         * ada-typeprint.c: Revert.
6513         * ada-tasks.c: Revert.
6514         * ada-lang.c: Revert.
6515         * aarch64-tdep.c: Revert.
6516         * aarch64-ravenscar-thread.c: Revert.
6517         * aarch64-newlib-tdep.c: Revert.
6518         * aarch64-linux-tdep.c: Revert.
6519         * aarch64-linux-nat.c: Revert.
6520         * aarch64-fbsd-tdep.c: Revert.
6521         * aarch64-fbsd-nat.c: Revert.
6522         * aarch32-linux-nat.c: Revert.
6523
6524 2019-04-05  Tom Tromey  <tom@tromey.com>
6525
6526         * ft32-tdep.c: Sort headers.
6527         * frv-tdep.c: Sort headers.
6528         * frv-linux-tdep.c: Sort headers.
6529         * frame.c: Sort headers.
6530         * frame-unwind.c: Sort headers.
6531         * frame-base.c: Sort headers.
6532         * fork-child.c: Sort headers.
6533         * findvar.c: Sort headers.
6534         * findcmd.c: Sort headers.
6535         * filesystem.c: Sort headers.
6536         * filename-seen-cache.h: Sort headers.
6537         * filename-seen-cache.c: Sort headers.
6538         * fbsd-tdep.c: Sort headers.
6539         * fbsd-nat.h: Sort headers.
6540         * fbsd-nat.c: Sort headers.
6541         * f-valprint.c: Sort headers.
6542         * f-typeprint.c: Sort headers.
6543         * f-lang.c: Sort headers.
6544         * extension.h: Sort headers.
6545         * extension.c: Sort headers.
6546         * extension-priv.h: Sort headers.
6547         * expprint.c: Sort headers.
6548         * exec.h: Sort headers.
6549         * exec.c: Sort headers.
6550         * exceptions.c: Sort headers.
6551         * event-top.c: Sort headers.
6552         * event-loop.c: Sort headers.
6553         * eval.c: Sort headers.
6554         * elfread.c: Sort headers.
6555         * dwarf2read.h: Sort headers.
6556         * dwarf2read.c: Sort headers.
6557         * dwarf2loc.c: Sort headers.
6558         * dwarf2expr.h: Sort headers.
6559         * dwarf2expr.c: Sort headers.
6560         * dwarf2-frame.c: Sort headers.
6561         * dwarf2-frame-tailcall.c: Sort headers.
6562         * dwarf-index-write.h: Sort headers.
6563         * dwarf-index-write.c: Sort headers.
6564         * dwarf-index-common.c: Sort headers.
6565         * dwarf-index-cache.h: Sort headers.
6566         * dwarf-index-cache.c: Sort headers.
6567         * dummy-frame.c: Sort headers.
6568         * dtrace-probe.c: Sort headers.
6569         * disasm.h: Sort headers.
6570         * disasm.c: Sort headers.
6571         * disasm-selftests.c: Sort headers.
6572         * dictionary.c: Sort headers.
6573         * dicos-tdep.c: Sort headers.
6574         * demangle.c: Sort headers.
6575         * dcache.h: Sort headers.
6576         * dcache.c: Sort headers.
6577         * darwin-nat.h: Sort headers.
6578         * darwin-nat.c: Sort headers.
6579         * darwin-nat-info.c: Sort headers.
6580         * d-valprint.c: Sort headers.
6581         * d-namespace.c: Sort headers.
6582         * d-lang.c: Sort headers.
6583         * ctf.c: Sort headers.
6584         * csky-tdep.c: Sort headers.
6585         * csky-linux-tdep.c: Sort headers.
6586         * cris-tdep.c: Sort headers.
6587         * cris-linux-tdep.c: Sort headers.
6588         * cp-valprint.c: Sort headers.
6589         * cp-support.c: Sort headers.
6590         * cp-namespace.c: Sort headers.
6591         * cp-abi.c: Sort headers.
6592         * corelow.c: Sort headers.
6593         * corefile.c: Sort headers.
6594         * continuations.c: Sort headers.
6595         * completer.h: Sort headers.
6596         * completer.c: Sort headers.
6597         * complaints.c: Sort headers.
6598         * coffread.c: Sort headers.
6599         * coff-pe-read.c: Sort headers.
6600         * cli-out.h: Sort headers.
6601         * cli-out.c: Sort headers.
6602         * charset.c: Sort headers.
6603         * c-varobj.c: Sort headers.
6604         * c-valprint.c: Sort headers.
6605         * c-typeprint.c: Sort headers.
6606         * c-lang.c: Sort headers.
6607         * buildsym.c: Sort headers.
6608         * buildsym-legacy.c: Sort headers.
6609         * build-id.h: Sort headers.
6610         * build-id.c: Sort headers.
6611         * btrace.c: Sort headers.
6612         * bsd-uthread.c: Sort headers.
6613         * breakpoint.h: Sort headers.
6614         * breakpoint.c: Sort headers.
6615         * break-catch-throw.c: Sort headers.
6616         * break-catch-syscall.c: Sort headers.
6617         * break-catch-sig.c: Sort headers.
6618         * blockframe.c: Sort headers.
6619         * block.c: Sort headers.
6620         * bfin-tdep.c: Sort headers.
6621         * bfin-linux-tdep.c: Sort headers.
6622         * bfd-target.c: Sort headers.
6623         * bcache.c: Sort headers.
6624         * ax-general.c: Sort headers.
6625         * ax-gdb.h: Sort headers.
6626         * ax-gdb.c: Sort headers.
6627         * avr-tdep.c: Sort headers.
6628         * auxv.c: Sort headers.
6629         * auto-load.c: Sort headers.
6630         * arm-wince-tdep.c: Sort headers.
6631         * arm-tdep.c: Sort headers.
6632         * arm-symbian-tdep.c: Sort headers.
6633         * arm-pikeos-tdep.c: Sort headers.
6634         * arm-obsd-tdep.c: Sort headers.
6635         * arm-nbsd-tdep.c: Sort headers.
6636         * arm-nbsd-nat.c: Sort headers.
6637         * arm-linux-tdep.c: Sort headers.
6638         * arm-linux-nat.c: Sort headers.
6639         * arm-fbsd-tdep.c: Sort headers.
6640         * arm-fbsd-nat.c: Sort headers.
6641         * arm-bsd-tdep.c: Sort headers.
6642         * arch-utils.c: Sort headers.
6643         * arc-tdep.c: Sort headers.
6644         * arc-newlib-tdep.c: Sort headers.
6645         * annotate.h: Sort headers.
6646         * annotate.c: Sort headers.
6647         * amd64-windows-tdep.c: Sort headers.
6648         * amd64-windows-nat.c: Sort headers.
6649         * amd64-tdep.c: Sort headers.
6650         * amd64-sol2-tdep.c: Sort headers.
6651         * amd64-obsd-tdep.c: Sort headers.
6652         * amd64-obsd-nat.c: Sort headers.
6653         * amd64-nbsd-tdep.c: Sort headers.
6654         * amd64-nbsd-nat.c: Sort headers.
6655         * amd64-nat.c: Sort headers.
6656         * amd64-linux-tdep.c: Sort headers.
6657         * amd64-linux-nat.c: Sort headers.
6658         * amd64-fbsd-tdep.c: Sort headers.
6659         * amd64-fbsd-nat.c: Sort headers.
6660         * amd64-dicos-tdep.c: Sort headers.
6661         * amd64-darwin-tdep.c: Sort headers.
6662         * amd64-bsd-nat.c: Sort headers.
6663         * alpha-tdep.c: Sort headers.
6664         * alpha-obsd-tdep.c: Sort headers.
6665         * alpha-nbsd-tdep.c: Sort headers.
6666         * alpha-mdebug-tdep.c: Sort headers.
6667         * alpha-linux-tdep.c: Sort headers.
6668         * alpha-linux-nat.c: Sort headers.
6669         * alpha-bsd-tdep.c: Sort headers.
6670         * alpha-bsd-nat.c: Sort headers.
6671         * aix-thread.c: Sort headers.
6672         * agent.c: Sort headers.
6673         * addrmap.c: Sort headers.
6674         * ada-varobj.c: Sort headers.
6675         * ada-valprint.c: Sort headers.
6676         * ada-typeprint.c: Sort headers.
6677         * ada-tasks.c: Sort headers.
6678         * ada-lang.c: Sort headers.
6679         * aarch64-tdep.c: Sort headers.
6680         * aarch64-ravenscar-thread.c: Sort headers.
6681         * aarch64-newlib-tdep.c: Sort headers.
6682         * aarch64-linux-tdep.c: Sort headers.
6683         * aarch64-linux-nat.c: Sort headers.
6684         * aarch64-fbsd-tdep.c: Sort headers.
6685         * aarch64-fbsd-nat.c: Sort headers.
6686         * aarch32-linux-nat.c: Sort headers.
6687
6688 2019-04-04  Tom Tromey  <tom@tromey.com>
6689
6690         * varobj.c (varobj_create): Update.
6691         * rust-exp.y (struct rust_parser) <update_innermost_block,
6692         lookup_symbol>: New methods.
6693         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6694         Rename.
6695         (rust_parser::rust_lookup_type)
6696         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6697         * printcmd.c (display_command, do_one_display): Update.
6698         * parser-defs.h (struct parser_state) <parser_state>: Add
6699         "tracker" parameter.
6700         (block_tracker): New member.
6701         (class innermost_block_tracker) <innermost_block_tracker>: Add
6702         "types" parameter.
6703         <reset>: Remove method.
6704         (innermost_block): Don't declare.
6705         (null_post_parser): Update.
6706         * parse.c (innermost_block): Remove global.
6707         (write_dollar_variable): Update.
6708         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6709         Remove "tracker_types" parameter.
6710         (parse_expression): Add "tracker" parameter.
6711         (parse_expression_for_completion): Update.
6712         (null_post_parser): Add "tracker" parameter.
6713         * p-exp.y: Update rules.
6714         * m2-exp.y: Update rules.
6715         * language.h (struct language_defn) <la_post_parser>: Add
6716         "tracker" parameter.
6717         * go-exp.y: Update rules.
6718         * f-exp.y: Update rules.
6719         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6720         parameter.
6721         * d-exp.y: Update rules.
6722         * c-exp.y: Update rules.
6723         * breakpoint.c (set_breakpoint_condition): Create an
6724         innermost_block_tracker.
6725         (watch_command_1): Likewise.
6726         * ada-lang.c (resolve): Add "tracker" parameter.
6727         (resolve_subexp): Likewise.
6728         * ada-exp.y (write_var_from_sym): Update.
6729
6730 2019-04-04  Tom Tromey  <tom@tromey.com>
6731
6732         * type-stack.h: New file.
6733         * type-stack.c: New file.
6734         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6735         type-stack.h.
6736         (insert_into_type_stack, insert_type, push_type, push_type_int)
6737         (insert_type_address_space, pop_type, pop_type_int)
6738         (pop_typelist, pop_type_stack, append_type_stack)
6739         (push_type_stack, get_type_stack, push_typelist)
6740         (follow_type_instance_flags, follow_types): Don't declare.
6741         * parse.c (type_stack): Remove global.
6742         (parse_exp_in_context): Update.
6743         (insert_into_type_stack, insert_type, push_type, push_type_int)
6744         (insert_type_address_space, pop_type, pop_type_int)
6745         (pop_typelist, pop_type_stack, append_type_stack)
6746         (push_type_stack, get_type_stack, push_typelist)
6747         (follow_type_instance_flags, follow_types): Remove (moved to
6748         type-stack.c).
6749         * f-exp.y (type_stack): New global.
6750         Update rules.
6751         (push_kind_type, f_parse): Update.
6752         * d-exp.y (type_stack): New global.
6753         Update rules.
6754         (d_parse): Update.
6755         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6756         Update rules.
6757         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6758         (HFILES_NO_SRCDIR): Add type-stack.h.
6759
6760 2019-04-04  Tom Tromey  <tom@tromey.com>
6761
6762         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6763         (rust_parser::convert_ast_to_expression, rust_parse)
6764         (rust_lex_test_completion, rust_lex_tests): Update.
6765         * parser-defs.h (struct expr_completion_state): New.
6766         (struct parser_state) <parser_state>: Add completion parameter.
6767         <mark_struct_expression, mark_completion_tag>: New methods.
6768         <parse_completion, m_completion_state>: New members.
6769         (prefixify_expression, null_post_parser): Update.
6770         (mark_struct_expression, mark_completion_tag): Don't declare.
6771         * parse.c (parse_completion, expout_last_struct)
6772         (expout_tag_completion_type, expout_completion_name): Remove
6773         globals.
6774         (parser_state::mark_struct_expression)
6775         (parser_state::mark_completion_tag): Now methods.
6776         (prefixify_expression): Add last_struct parameter.
6777         (prefixify_subexp): Likewise.
6778         (parse_exp_1): Update.
6779         (parse_exp_in_context): Add cstate parameter.  Update.
6780         (parse_expression_for_completion): Create an
6781         expr_completion_state.
6782         (null_post_parser): Add "completion" parameter.
6783         * p-exp.y: Update rules.
6784         (yylex): Update.
6785         * language.h (struct language_defn) <la_post_parser>: Add
6786         "completing" parameter.
6787         * go-exp.y: Update rules.
6788         (lex_one_token): Update.
6789         * expression.h (parse_completion): Don't declare.
6790         * d-exp.y: Update rules.
6791         (lex_one_token): Update rules.
6792         * c-exp.y: Update rules.
6793         (lex_one_token): Update.
6794         * ada-lang.c (resolve): Add "parse_completion" parameter.
6795         (resolve_subexp): Likewise.
6796         (ada_resolve_function): Likewise.
6797
6798 2019-04-04  Tom Tromey  <tom@tromey.com>
6799
6800         * parser-defs.h (struct parser_state) <start_arglist,
6801         end_arglist>: New methods.
6802         <arglist_len, m_funcall_chain>: New members.
6803         (arglist_len, start_arglist, end_arglist): Don't declare.
6804         * parse.c (arglist_len, funcall_chain): Remove global.
6805         (start_arglist, end_arglist): Remove functions.
6806         (parse_exp_in_context): Update.
6807         * p-exp.y: Update rules.
6808         * m2-exp.y: Update rules.
6809         * go-exp.y: Update rules.
6810         * f-exp.y: Update rules.
6811         * d-exp.y: Update rules.
6812         * c-exp.y: Update rules.
6813
6814 2019-04-04  Tom Tromey  <tom@tromey.com>
6815
6816         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6817         lex_operator, push_back>: New methods.
6818         Update all rules.
6819         (rust_parser::lex_hex, lex_escape): Rename and update.
6820         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6821         (rust_parser::lex_operator): Rename and update.
6822         (rust_parser::lex_number, rustyylex, rustyyerror)
6823         (rust_lex_test_init, rust_lex_test_sequence)
6824         (rust_lex_test_push_back, rust_lex_tests): Update.
6825         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6826         parameter.
6827         <lexptr, prev_lexptr>: New members.
6828         (lexptr, prev_lexptr): Don't declare.
6829         * parse.c (lexptr, prev_lexptr): Remove globals.
6830         (parse_exp_in_context): Update.
6831         * p-exp.y (yylex, yyerror): Update.
6832         * m2-exp.y (parse_number, yylex, yyerror): Update.
6833         * go-exp.y (lex_one_token, yyerror): Update.
6834         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6835         * d-exp.y (lex_one_token, yyerror): Update.
6836         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6837         (lex_one_token, yyerror): Update.
6838         * ada-lex.l (YY_INPUT): Update.
6839         (rewind_to_char): Update.
6840         * ada-exp.y (yyerror): Update.
6841
6842 2019-04-04  Tom Tromey  <tom@tromey.com>
6843
6844         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6845         * parser-defs.h (struct parser_state) <parser_state>: Add new
6846         parameter.
6847         <comma_terminates>: New member.
6848         (comma_terminates): Don't declare global.
6849         * parse.c (comma_terminates): Remove global.
6850         (parse_exp_in_context): Update.
6851         * p-exp.y (yylex): Update.
6852         * m2-exp.y (yylex): Update.
6853         * go-exp.y (lex_one_token): Update.
6854         * f-exp.y (yylex): Update.
6855         * d-exp.y (lex_one_token): Update.
6856         * c-exp.y (lex_one_token): Update.
6857         * ada-lex.l: Update.
6858
6859 2019-04-04  Tom Tromey  <tom@tromey.com>
6860
6861         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6862         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6863         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6864         * parser-defs.h (paren_depth): Don't declare.
6865         * parse.c (paren_depth): Remove global.
6866         (parse_exp_in_context): Update.
6867         * p-exp.y (paren_depth): New global.
6868         (pascal_parse): Initialize it.
6869         * m2-exp.y (paren_depth): New global.
6870         (m2_parse): Initialize it.
6871         * go-exp.y (paren_depth): New global.
6872         (go_parse): Initialize it.
6873         * f-exp.y (paren_depth): New global.
6874         (f_parse): Initialize it.
6875         * d-exp.y (paren_depth): New global.
6876         (d_parse): Initialize it.
6877         * c-exp.y (paren_depth): New global.
6878         (c_parse): Initialize it.
6879         * ada-lex.l (paren_depth): New global.
6880         (lexer_init): Initialize it.
6881
6882 2019-04-04  Tom Tromey  <tom@tromey.com>
6883
6884         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6885         (rust_parser::convert_ast_to_type)
6886         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6887         * parser-defs.h (struct parser_state) <parser_state>: Add
6888         parameters.  Initialize new members.
6889         <expression_context_block, expression_context_pc>: New members.
6890         * parse.c (expression_context_block, expression_context_pc):
6891         Remove globals.
6892         (parse_exp_in_context): Update.
6893         * p-exp.y: Update all rules.
6894         (yylex): Update.
6895         * m2-exp.y: Update all rules.
6896         (yylex): Update.
6897         * go-exp.y (yylex): Update.
6898         * f-exp.y (yylex): Update.
6899         * d-exp.y: Update all rules.
6900         (yylex): Update.
6901         * c-exp.y: Update all rules.
6902         (lex_one_token, classify_name, yylex, c_parse): Update.
6903         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6904
6905 2019-04-04  Tom Tromey  <tom@tromey.com>
6906
6907         * gdbarch.h, gdbarch.c: Rebuild.
6908         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6909         * stap-probe.h:
6910         (struct stap_parse_info): Replace "parser_state" with
6911         "expr_builder".
6912         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6913         (parser_state): New class.
6914         * parse.c (expr_builder): Rename.
6915         (expr_builder::release): Rename.
6916         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6917         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6918         (write_exp_elt_longcst, write_exp_elt_floatcst)
6919         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6920         (write_exp_string_vector, write_exp_bitstring)
6921         (write_exp_msymbol, mark_struct_expression)
6922         (write_dollar_variable)
6923         (insert_type_address_space, increase_expout_size): Replace
6924         "parser_state" with "expr_builder".
6925         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6926         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6927         "parser_state" with "expr_builder".
6928
6929 2019-04-04  Tom Tromey  <tom@tromey.com>
6930
6931         * rust-exp.y: Replace "parse_language" with method call.
6932         * p-exp.y:
6933         (yylex): Replace "parse_language" with method call.
6934         * m2-exp.y:
6935         (yylex): Replace "parse_language" with method call.
6936         * go-exp.y (classify_name): Replace "parse_language" with method
6937         call.
6938         * f-exp.y (yylex): Replace "parse_language" with method call.
6939         * d-exp.y (lex_one_token): Replace "parse_language" with method
6940         call.
6941         * c-exp.y:
6942         (lex_one_token, classify_name, yylex): Replace "parse_language"
6943         with method call.
6944         * ada-exp.y (find_primitive_type, type_char)
6945         (type_system_address): Replace "parse_language" with method call.
6946
6947 2019-04-04  Tom Tromey  <tom@tromey.com>
6948
6949         * rust-exp.y: Replace "parse_gdbarch" with method call.
6950         * parse.c (write_dollar_variable, insert_type_address_space):
6951         Replace "parse_gdbarch" with method call.
6952         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6953         call.
6954         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6955         call.
6956         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6957         "parse_gdbarch" with method call.
6958         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6959         with method call.
6960         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6961         "parse_gdbarch" with method call.
6962         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6963         "parse_gdbarch" with method call.
6964         * c-exp.y (parse_type, parse_number, classify_name): Replace
6965         "parse_gdbarch" with method call.
6966         * ada-lex.l: Replace "parse_gdbarch" with method call.
6967         * ada-exp.y (parse_type, find_primitive_type, type_char)
6968         (type_system_address): Replace "parse_gdbarch" with method call.
6969
6970 2019-04-04  Tom Tromey  <tom@tromey.com>
6971
6972         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6973         * stap-probe.c (stap_parse_argument): Update.
6974         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6975         initial_size parameter.
6976         * rust-exp.y (rust_lex_tests): Update.
6977         * parse.c (parser_state): Update.
6978         (parse_exp_in_context): Update.
6979         * parser-defs.h (struct parser_state) <parser_state>: Remove
6980         "initial_size" parameter.
6981
6982 2019-04-04  Tom Tromey  <tom@tromey.com>
6983
6984         * parser-defs.h (increase_expout_size): Don't declare.
6985         * parse.c (increase_expout_size): Now static.
6986
6987 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6988
6989         * gnu-nat.c (gnu_nat_target::wait): Fix
6990         target_waitstatus_to_string call.
6991
6992 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6993
6994         * eval.c (evaluate_subexp_standard): Handle internal functions
6995         during Fortran function call handling.
6996
6997 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6998
6999         * NEWS: Mention new internal functions.
7000         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7001         (read_base_type): Use dwarf2_init_complex_target_type.
7002         * value.c (creal_internal_fn): New function.
7003         (cimag_internal_fn): New function.
7004         (_initialize_values): Register new internal functions.
7005
7006 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7007
7008         * infrun.c (stop_all_threads): If debug_infrun, always
7009         trace the wait status after wait_one, using
7010         target_waitstatus_to_string and target_pid_to_str.
7011         (handle_inferior_event): Replace various trace of
7012         wait status kind by a single trace.
7013         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7014         wait status kind image by target_waitstatus_to_string.
7015         * target/waitstatus.c (target_waitstatus_to_string): Fix
7016         obsolete comment.
7017
7018 2019-04-01  Tom Tromey  <tromey@adacore.com>
7019
7020         PR symtab/23331:
7021         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7022
7023 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7024             Pedro Alves  <palves@redhat.com>
7025
7026         * top.c (quit_force): Call 'finalize_values'.
7027         * value.c (finalize_values): New function.
7028         * value.h (finalize_values): Declare.
7029
7030 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7031
7032         * NEWS: Announce $_gdb_major and $_gdb_minor.
7033
7034         * top.c (init_gdb_version_vars): New function.
7035         (gdb_init): Call init_gdb_version_vars.
7036
7037 2019-03-29  Tom Tromey  <tromey@adacore.com>
7038
7039         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7040         help text.  Remove dead code.
7041
7042 2019-03-29  Keith Seitz  <keiths@redhat.com>
7043
7044         From Siddhesh Poyarekar:
7045         * f-lang.h (f77_get_upperbound): Return LONGEST.
7046         (f77_get_lowerbound): Likewise.
7047         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7048         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7049         print them.
7050         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7051         plongest to format print it.
7052         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7053         (f77_get_upperbound): Likewise.
7054         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7055         LOWER_BOUND to LONGEST.
7056         (f77_create_arrayprint_offset_tbl): Likewise.
7057
7058 2019-03-29  Keith Seitz  <keiths@redhat.com>
7059
7060         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7061         %s/pulongest for TYPE_LENGTH instead of %d in format
7062         strings.
7063         * ada-typerint.c (ada_print_type): Likewise.
7064         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7065         * compile/compile-c-support.c (generate_register_struct): Likewise.
7066         * gdbtypes.c (recursive_dump_type): Likewise.
7067         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7068         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7069         instead of %d in format strings.
7070         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7071         to std::min to ULONGEST.
7072         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7073         instead of %d in format strings.
7074         * tracepoint.c (info_scope_command): Likewise.
7075         * typeprint.c (print_offset_data::update)
7076         (print_offset_data::finish): Likewise.
7077         * xtensa-tdep.c (xtensa_store_return_value)
7078         (xtensa_push_dummy_call): Likewise.
7079
7080 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7081
7082         * windows-nat.c (display_selector): Fixed format specifications
7083         for 64-bit Cygwin.
7084
7085 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7086
7087         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7088
7089 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7090
7091         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7092         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7093         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7094         (nios2_linux_init_abi): Install it.
7095
7096 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7097
7098         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7099
7100 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7101
7102         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7103
7104 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7105             Tom Tromey  <tromey@adacore.com>
7106
7107         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7108
7109 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7110
7111         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7112         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7113         method to compute the bounds of range types. Also print "[evaluated]"
7114         if the bounds' values come from a dynamic evaluation.
7115
7116 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7117
7118         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7119         whitespace when pretty printing is on.
7120
7121 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7122
7123         * ppc-linux-nat.c: Add include.
7124
7125 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7126
7127         * NEWS: Mention AArch64 Pointer Authentication.
7128
7129 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7130
7131         * arm-linux-nat.c: Add include.
7132
7133 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7134
7135         * source-cache.c (source_cache::get_source_lines): Re-read
7136         fullname after calling open_source_file.
7137
7138 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7139
7140         * NEWS: Mention TLS support for FreeBSD.
7141
7142 2019-03-25  Tom Tromey  <tromey@adacore.com>
7143
7144         * minsyms.c (BUNCH_SIZE): Update comment.
7145         (~minimal_symbol_reader): Remove old comment.
7146         (compact_minimal_symbols): Update comment.
7147         (minimal_symbol_reader::install): Remove old comment.  Update
7148         other comments.
7149
7150 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7151
7152         * s390-linux-nat.c: Add include.
7153
7154 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7155
7156         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7157         Call linux_get_hwcap.
7158         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7159         Likewise.
7160         (aarch64_linux_get_hwcap): Remove function.
7161         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7162         declaration.
7163         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7164         linux_get_hwcap.
7165         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7166         * linux-tdep.c (linux_get_hwcap): Add function.
7167         (linux_get_hwcap2): Likewise.
7168         * linux-tdep.h (linux_get_hwcap): Add declaration.
7169         (linux_get_hwcap2): Likewise.
7170         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7171         (ppc_linux_get_hwcap2): Likewise.
7172         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7173         linux_get_hwcap.
7174         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7175         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7176         (ppc_linux_nat_target::read_description): Likewise.
7177         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7178         * s390-linux-nat.c: Likewise.
7179         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7180
7181 2019-03-24  Tom Tromey  <tom@tromey.com>
7182
7183         * ada-lang.c (standard_lookup): Simplify initialization.
7184         (ada_lookup_symbol_nonlocal): Simplify return.
7185         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7186         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7187         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7188         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7189         initialization.
7190         * solib.c (solib_global_lookup): Simplify.
7191         * symtab.c (null_block_symbol): Remove.
7192         (symbol_cache_lookup): Simplify returns.
7193         (lookup_language_this): Simplify returns.
7194         (lookup_symbol_aux): Simplify return.
7195         (lookup_local_symbol): Simplify returns.
7196         (lookup_global_symbol_from_objfile): Simplify return.
7197         (lookup_symbol_in_objfile_symtabs)
7198         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7199         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7200         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7201         * cp-namespace.c (cp_lookup_bare_symbol)
7202         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7203         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7204         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7205         (cp_lookup_symbol_via_imports): Simplify initialization.
7206         (find_symbol_in_baseclass): Likewise.
7207         * symtab.h (null_block_symbol): Remove.
7208         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7209         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7210         (d_lookup_symbol_module): Likewise.
7211         (find_symbol_in_baseclass): Simplify initialization.
7212
7213 2019-03-24  Tom Tromey  <tom@tromey.com>
7214
7215         * expression.h: Don't include symtab.h.
7216         (struct block): Forward declare.
7217
7218 2019-03-24  Tom Tromey  <tom@tromey.com>
7219
7220         * c-exp.y (typebase): Remove casts.
7221         * gdbtypes.c (lookup_unsigned_typename, )
7222         (lookup_signed_typename): Remove cast.
7223         * eval.c (parse_to_comma_and_eval): Remove cast.
7224         * parse.c (write_dollar_variable): Remove cast.
7225         * block.h (struct block) <superblock>: Now const.
7226         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7227         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7228         (map_block): Make "block" const.
7229         * symfile.h (struct quick_symbol_functions)
7230         <map_matching_symbols>: Constify block argument to "callback".
7231         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7232         const.
7233         (find_pc_sect_compunit_symtab): Make "b" const.
7234         (find_symbol_at_address): Likewise.
7235         (search_symbols): Likewise.
7236         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7237         (dw2_debug_names_lookup_symbol): Likewise.
7238         (dw2_map_matching_symbols): Update.
7239         * p-valprint.c (pascal_val_print): Remove "block".
7240         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7241         (aux_add_nonlocal_symbols): Make "block" const.
7242         (resolve_subexp): Remove cast.
7243         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7244         const.
7245         (iterate_over_file_blocks): Likewise.
7246         * f-exp.y (%union) <bval>: Remove.
7247         * coffread.c (patch_opaque_types): Make "b" const.
7248         * spu-tdep.c (spu_catch_start): Make "block" const.
7249         * c-valprint.c (print_unpacked_pointer): Remove "block".
7250         * symmisc.c (dump_symtab_1): Make "b" const.
7251         (block_depth): Make "block" const.
7252         * d-exp.y (%union) <bval>: Remove.
7253         * cp-support.h (cp_lookup_rtti_type): Update.
7254         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7255         * psymtab.c (psym_lookup_symbol): Make "block" const.
7256         (maintenance_check_psymtabs): Make "b" const.
7257         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7258         (enumerate_locals, enumerate_args): Update.
7259         * python/py-symtab.c (stpy_global_block): Make "block" const.
7260         (stpy_static_block): Likewise.
7261         * inline-frame.c (block_starting_point_at): Make "new_block"
7262         const.
7263         * block.c (find_block_in_blockvector): Make return type const.
7264         (blockvector_for_pc_sect): Make "b" const.
7265         (find_block_in_blockvector): Make "b" const.
7266
7267 2019-03-23  Tom Tromey  <tom@tromey.com>
7268
7269         * varobj.c (varobj_create): Update.
7270         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7271         * printcmd.c (display_command, do_one_display): Don't reset
7272         innermost_block.
7273         * parser-defs.h (enum innermost_block_tracker_type): Move to
7274         expression.h.
7275         (innermost_block): Update comment.
7276         * parse.c (parse_exp_1): Add tracker_types parameter.
7277         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7278         tracker_types parameter.  Reset innermost_block.
7279         (parse_exp_in_context): Remove.
7280         (parse_expression_for_completion): Update.
7281         * objfiles.c (~objfile): Don't reset expression_context_block or
7282         innermost_block.
7283         * expression.h (enum innermost_block_tracker_type): Move from
7284         parser-defs.h.
7285         (parse_exp_1): Add tracker_types parameter.
7286         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7287         reset innermost_block.
7288
7289 2019-03-23  Tom Tromey  <tom@tromey.com>
7290
7291         * objfiles.h: Include bcache.h.
7292
7293 2019-03-23  Tom Tromey  <tom@tromey.com>
7294
7295         * linespec.c (get_current_search_block): Use
7296         scoped_restore_current_language.
7297         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7298
7299 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7300             Jiong Wang  <jiong.wang@arm.com>
7301
7302         * aarch64-linux-tdep.c
7303         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7304         section.
7305         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7306
7307 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7308             Jiong Wang  <jiong.wang@arm.com>
7309
7310         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7311         instructions.
7312         (aarch64_analyze_prologue_test): Add PACIASP test.
7313         (aarch64_prologue_prev_register): Unmask PC value.
7314
7315 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7316             Jiong Wang  <jiong.wang@arm.com>
7317
7318         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7319         (aarch64_dwarf2_prev_register): Unmask PC value.
7320         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7321         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7322         DW_CFA_AARCH64_negate_ra_state.
7323         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7324
7325 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7326             Jiong Wang  <jiong.wang@arm.com>
7327
7328         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7329         registers.
7330         (aarch64_pseudo_register_name): Likewise.
7331         (aarch64_pseudo_register_type): Likewise.
7332         (aarch64_pseudo_register_reggroup_p): Likewise.
7333         (aarch64_gdbarch_init): Add pauth registers.
7334         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7335         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7336         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7337         (struct gdbarch_tdep): Add regnum for ra_state.
7338
7339 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7340             Jiong Wang  <jiong.wang@arm.com>
7341
7342         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7343
7344 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7345             Jiong Wang  <jiong.wang@arm.com>
7346
7347         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7348         function.
7349         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7350         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7351         (aarch64_gdbarch_init): Add puth registers.
7352         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7353         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7354         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7355
7356 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7357             Jiong Wang  <jiong.wang@arm.com>
7358
7359         * aarch64-linux-nat.c
7360         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7361         * aarch64-linux-tdep.c
7362         (aarch64_linux_core_read_description): Likewise.
7363         (aarch64_linux_get_hwcap): New function.
7364         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7365         (aarch64_linux_get_hwcap): New declaration.
7366
7367 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7368             Jiong Wang  <jiong.wang@arm.com>
7369
7370         * aarch64-linux-nat.c
7371         (aarch64_linux_nat_target::read_description): Add pauth param.
7372         * aarch64-linux-tdep.c
7373         (aarch64_linux_core_read_description): Likewise.
7374         * aarch64-tdep.c (struct target_desc): Add in pauth.
7375         (aarch64_read_description): Add pauth param.
7376         (aarch64_gdbarch_init): Likewise.
7377         * aarch64-tdep.h (aarch64_read_description): Likewise.
7378         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7379         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7380         * features/Makefile: Add new files.
7381         * features/aarch64-pauth.c: New file.
7382         * features/aarch64-pauth.xml: New file.
7383
7384 2019-03-20  Tom Tromey  <tromey@adacore.com>
7385
7386         * infrun.c (handle_inferior_event): Rename from
7387         handle_inferior_event_1.  Create a scoped_value_mark.
7388         (handle_inferior_event): Remove.
7389
7390 2019-03-19  Tom Tromey  <tromey@adacore.com>
7391
7392         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7393         * infrun.h (print_stop_event): Add "displays" parameter.
7394         * infrun.c (print_stop_event): Add "displays" parameter.
7395
7396 2019-03-19  Pedro Alves  <palves@redhat.com>
7397
7398         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7399         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7400         to -1.  Fix TABs vs spaces.
7401         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7402         * tui/tui-out.h (tui_ui_out) Add intro comments.
7403         <m_line, m_start_of_line>: In-class initialize, and add describing
7404         comment.
7405
7406 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7407
7408         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7409         variable names.
7410         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7411
7412 2019-03-18  Pedro Alves  <palves@redhat.com>
7413             Eli Zaretskii <eliz@gnu.org>
7414
7415         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7416         m_line and m_start_of_line.
7417
7418 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7419
7420         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7421         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7422         it returns a newline.  This fixes a regression in TU mode, whereby
7423         the next line is output on the same screen line as the user input.
7424
7425 2019-03-18  Tom Tromey  <tromey@adacore.com>
7426
7427         * minsyms.c (minimal_symbol_reader::install): Remove call to
7428         obstack_blank.
7429
7430 2019-03-18  Pedro Alves  <palves@redhat.com>
7431
7432         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7433         New globals.
7434         (apply_style): New, factored out from ...
7435         (apply_ansi_escape): ... this.  Handle reverse video mode.
7436         (tui_set_reverse_mode): New function.
7437         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7438         * tui/tui-winsource.c (tui_show_source_line): Use
7439         tui_set_reverse_mode instead of setting A_STANDOUT.
7440         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7441         New setter methods.
7442
7443 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7444
7445         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7446         Handle tabs.
7447
7448 2019-03-18  Tom Tromey  <tromey@adacore.com>
7449
7450         * ada-lang.c (empty_array): Add "high" parameter.
7451         (ada_evaluate_subexp): Update.
7452
7453 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7454
7455         * unittests/string_view-selftests.c: Define
7456         _initialize_string_view_selftests unconditionally.
7457
7458 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7459
7460         PR gdb/24350
7461         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7462
7463 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7464
7465         PR gdb/24351
7466         * windows-nat.c (display_selector): Fix format specifiers.
7467
7468 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7469
7470         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7471         tui_refill_source_window instead of tui_refresh_win, to update the
7472         current execution line.  This fixes redisplay of the current line
7473         when stepping through the code with "next" or "step".
7474
7475 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7476
7477         * source-cache.c (source_cache::get_source_lines): Call
7478         find_source_lines to initialize s->nlines.  This fixes vertical
7479         scrolling of TUI source window when the DOWN arrow is pressed.
7480
7481 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7482
7483         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7484         linux-thread-db.c (_initialize_thread_db): Likewise.
7485
7486 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7487
7488         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7489         wclrtoeol in tui_show_source_line".  This reverts changes made in
7490         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7491
7492 2019-03-15  Tom Tromey  <tom@tromey.com>
7493
7494         * symtab.h (struct minimal_symbol): Derive from
7495         general_symbol_info.
7496         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7497         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7498         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7499         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7500         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7501         (MSYMBOL_SEARCH_NAME): Update.
7502         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7503         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7504         * minsyms.c (minimal_symbol_reader::record_full): Update.
7505
7506 2019-03-15  Tom Tromey  <tom@tromey.com>
7507
7508         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7509
7510 2019-03-15  Tom Tromey  <tom@tromey.com>
7511
7512         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7513         unique_xmalloc_ptr.
7514         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7515         Update.
7516         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7517         (build_minimal_symbol_hash_tables)
7518         (minimal_symbol_reader::install): Update.
7519
7520 2019-03-15  Tom Tromey  <tom@tromey.com>
7521
7522         * symtab.c (create_demangled_names_hash): Update.
7523         (symbol_set_names): Update.
7524         * objfiles.h (struct objfile_per_bfd_storage)
7525         <demangled_names_hash>: Now an htab_up.
7526         * objfiles.c (objfile_per_bfd_storage): Simplify.
7527
7528 2019-03-15  Tom Tromey  <tom@tromey.com>
7529
7530         * objfiles.h (struct objfile_per_bfd_storage): Declare
7531         destructor.
7532         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7533         New.
7534         (get_objfile_bfd_data): Use new.  Don't initialize
7535         language_of_main.
7536         (free_objfile_per_bfd_storage): Remove.
7537         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7538
7539 2019-03-15  Tom Tromey  <tom@tromey.com>
7540
7541         * symfile.c (reread_symbols): Update.
7542         * objfiles.c (objfile::objfile): Update.
7543         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7544         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7545         comment.
7546         (minimal_symbol_reader::install): Update.
7547         (terminate_minimal_symbol_table): Remove.
7548         * jit.c (jit_object_close_impl): Update.
7549
7550 2019-03-15  Tom Tromey  <tom@tromey.com>
7551
7552         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7553         initializations.
7554
7555 2019-03-15  Tom Tromey  <tom@tromey.com>
7556
7557         * objfiles.h (struct objfile_per_bfd_storage)
7558         <demangled_hash_languages>: Now a bitset.
7559         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7560         (lookup_minimal_symbol): Update.
7561
7562 2019-03-15  Tom Tromey  <tom@tromey.com>
7563
7564         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7565         Don't return the symbol.
7566         * coffread.c (record_minimal_symbol): Use record_full.
7567
7568 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7569
7570         The MS-Windows port of ncurses fails to switch to a color pair if
7571         one or both of the colors are the implicit default colors.  This
7572         change records the default colors when TUI is initialized, and
7573         then specifies them explicitly when a color pair uses the default
7574         colors.  This allows color styling in TUI mode on MS-Windows.
7575
7576         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7577         ncurses_norm_attr.
7578         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7579         colors in ncurses_norm_attr.
7580         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7581         "none", replace it with the default color recorded in
7582         ncurses_norm_attr.
7583
7584 2019-03-14  Tom Tromey  <tromey@adacore.com>
7585
7586         * source-cache.h (class source_cache) <get_source_lines>: Return
7587         std::string.
7588         * source-cache.c (source_cache::extract_lines): Handle case where
7589         first_pos==npos.  Return std::string.
7590         (source_cache::get_source_lines): Update.
7591
7592 2019-03-14  Tom Tromey  <tromey@adacore.com>
7593
7594         * NEWS: Add item for "style sources" commands.
7595         * source-cache.c (source_cache::get_source_lines): Check
7596         source_styling.
7597         * cli/cli-style.c (source_styling): New global.
7598         (_initialize_cli_style): Add "style sources" commands.
7599         (show_style_sources): New function.
7600         * cli/cli-style.h (source_styling): Declare.
7601
7602 2019-03-14  Pedro Alves  <palves@redhat.com>
7603             Tom Tromey  <tromey@adacore.com>
7604
7605         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7606         * tui/tui-winsource.c (tui_refill_source_window): New function,
7607         from...
7608         (tui_horizontal_source_scroll): ... here.  Move some logic.
7609         * cli/cli-style.c (set_style_enabled): Notify new observable.
7610         * tui/tui-hooks.c (tui_redisplay_source): New function.
7611         (tui_attach_detach_observers): Attach or detach
7612         tui_redisplay_source.
7613         * observable.h (source_styling_changed): New observable.
7614         * observable.c: Define source_styling_changed observable.
7615
7616 2019-03-13  Tom Tromey  <tromey@adacore.com>
7617
7618         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7619         (i386_gnu_nat_target::store_registers): Update.
7620         * target-debug.h (target_debug_print_std_string): New macro.
7621         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7622         * windows-tdep.c (display_one_tib): Update.
7623         * tui/tui-stack.c (tui_make_status_line): Update.
7624         * top.c (print_inferior_quit_action): Update.
7625         * thread.c (thr_try_catch_cmd): Update.
7626         (add_thread_with_info): Update.
7627         (thread_target_id_str): Update.
7628         (thr_try_catch_cmd): Update.
7629         (thread_command): Update.
7630         (thread_find_command): Update.
7631         * record-btrace.c (record_btrace_target::info_record)
7632         (record_btrace_resume_thread, record_btrace_target::resume)
7633         (record_btrace_cancel_resume, record_btrace_step_thread)
7634         (record_btrace_target::wait, record_btrace_target::wait)
7635         (record_btrace_target::wait, record_btrace_target::stop): Update.
7636         * progspace.c (print_program_space): Update.
7637         * process-stratum-target.c
7638         (process_stratum_target::thread_address_space): Update.
7639         * linux-fork.c (linux_fork_mourn_inferior)
7640         (detach_checkpoint_command, info_checkpoints_command)
7641         (linux_fork_context): Update.
7642         (linux_fork_detach): Update.
7643         (class scoped_switch_fork_info): Update.
7644         (delete_checkpoint_command): Update.
7645         * infrun.c (follow_fork_inferior): Update.
7646         (follow_fork_inferior): Update.
7647         (proceed_after_vfork_done): Update.
7648         (handle_vfork_child_exec_or_exit): Update.
7649         (follow_exec): Update.
7650         (displaced_step_prepare_throw): Update.
7651         (displaced_step_restore): Update.
7652         (start_step_over): Update.
7653         (resume_1): Update.
7654         (clear_proceed_status_thread): Update.
7655         (proceed): Update.
7656         (print_target_wait_results): Update.
7657         (do_target_wait): Update.
7658         (context_switch): Update.
7659         (stop_all_threads): Update.
7660         (restart_threads): Update.
7661         (finish_step_over): Update.
7662         (handle_signal_stop): Update.
7663         (switch_back_to_stepped_thread): Update.
7664         (keep_going_pass_signal): Update.
7665         (print_exited_reason): Update.
7666         (normal_stop): Update.
7667         * inferior.c (inferior_pid_to_str): Change return type.
7668         (print_selected_inferior): Update.
7669         (add_inferior): Update.
7670         (detach_inferior): Update.
7671         * dummy-frame.c (fprint_dummy_frames): Update.
7672         * dcache.c (dcache_info_1): Update.
7673         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7674         (btrace_fetch, btrace_clear): Update.
7675         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7676         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7677         type.
7678         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7679         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7680         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7681         * gdbarch.c, gdbarch.h: Rebuild.
7682         * gdbarch.sh (core_pid_to_str): Change return type.
7683         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7684         return type.
7685         (windows_nat_target::pid_to_str): Change return type.
7686         (windows_delete_thread): Update.
7687         (windows_nat_target::attach): Update.
7688         (windows_nat_target::files_info): Update.
7689         * target-delegates.c: Rebuild.
7690         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7691         return type.
7692         (sol_thread_target::pid_to_str): Change return type.
7693         * remote.c (class remote_target) <pid_to_str>: Change return
7694         type.
7695         (remote_target::pid_to_str): Change return type.
7696         (extended_remote_target::attach, remote_target::remote_stop_ns)
7697         (remote_target::remote_notif_remove_queued_reply)
7698         (remote_target::push_stop_reply, remote_target::disable_btrace):
7699         Update.
7700         (extended_remote_target::attach): Update.
7701         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7702         type.
7703         (gdbsim_target::pid_to_str): Change return type.
7704         * ravenscar-thread.c (struct ravenscar_thread_target)
7705         <pid_to_str>: Change return type.
7706         (ravenscar_thread_target::pid_to_str): Change return type.
7707         * procfs.c (class procfs_target) <pid_to_str>: Change return
7708         type.
7709         (procfs_target::pid_to_str): Change return type.
7710         (procfs_target::attach): Update.
7711         (procfs_target::detach): Update.
7712         (procfs_target::fetch_registers): Update.
7713         (procfs_target::store_registers): Update.
7714         (procfs_target::wait): Update.
7715         (procfs_target::files_info): Update.
7716         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7717         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7718         return type.
7719         (nto_procfs_target::pid_to_str): Change return type.
7720         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7721         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7722         return type.
7723         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7724         (exit_lwp): Update.
7725         (attach_proc_task_lwp_callback, get_detach_signal)
7726         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7727         (linux_nat_target::resume, wait_lwp, stop_callback)
7728         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7729         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7730         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7731         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7732         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7733         type.
7734         (inf_ptrace_target::attach): Update.
7735         (inf_ptrace_target::files_info): Update.
7736         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7737         type.
7738         (go32_nat_target::pid_to_str): Change return type.
7739         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7740         (gnu_nat_target::wait): Update.
7741         (gnu_nat_target::wait): Update.
7742         (gnu_nat_target::resume): Update.
7743         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7744         (fbsd_nat_target::wait): Update.
7745         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7746         type.
7747         (darwin_nat_target::attach): Update.
7748         * corelow.c (class core_target) <pid_to_str>: Change return type.
7749         (core_target::pid_to_str): Change return type.
7750         * target.c (normal_pid_to_str): Change return type.
7751         (default_pid_to_str): Likewise.
7752         (target_pid_to_str): Change return type.
7753         (target_translate_tls_address): Update.
7754         (target_announce_detach): Update.
7755         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7756         return type.
7757         (bsd_uthread_target::pid_to_str): Change return type.
7758         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7759         type.
7760         (bsd_kvm_target::pid_to_str): Change return type.
7761         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7762         return type.
7763         (aix_thread_target::pid_to_str): Change return type.
7764         * target.h (struct target_ops) <pid_to_str>: Change return type.
7765         (target_pid_to_str, normal_pid_to_str): Likewise.
7766         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7767         type.
7768         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7769         type.
7770         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7771         return type.
7772         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7773         type.
7774         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7775         type.
7776         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7777         return type.
7778
7779 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7780
7781         * NEWS: Mention that the new default MI version is 3.  Mention
7782         changes to the output of commands and events that deal with
7783         multi-location breakpoints.
7784         * breakpoint.c: Include "mi/mi-out.h".
7785         (print_one_breakpoint): Change output syntax if using MI version
7786         >= 3.
7787         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7788         New.
7789         (mi_multi_location_breakpoint_output_fixed): New.
7790         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7791         (mi_cmd_fix_multi_location_breakpoint_output): New.
7792         (mi_multi_location_breakpoint_output_fixed): New.
7793         * mi/mi-cmds.c (mi_cmds): Register command
7794         -fix-multi-location-breakpoint-output.
7795         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7796         interpreter "mi".
7797
7798 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7799
7800         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7801         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7802         instantiate mi_ui_out based on interpreter name.
7803         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7804         * mi/mi-main.c (mi_load_progress): Likewise.
7805
7806 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7807
7808         * NEWS: Combine separate "New targets" sections for 8.3.
7809
7810 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7811
7812         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7813         (ppcfbsd_init_abi): Install gdbarch
7814         "fetch_tls_load_module_address" and "get_thread_local_address"
7815         methods.
7816
7817 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7818
7819         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7820         (riscv_fbsd_init_abi): Install gdbarch
7821         "fetch_tls_load_module_address" and "get_thread_local_address"
7822         methods.
7823
7824 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7825
7826         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7827         (i386fbsd_init_abi): Install gdbarch
7828         "fetch_tls_load_module_address" and "get_thread_local_address"
7829         methods.
7830
7831 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7832
7833         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7834         (amd64fbsd_init_abi): Install gdbarch
7835         "fetch_tls_load_module_address" and "get_thread_local_address"
7836         methods.
7837
7838 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7839
7840         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7841         (struct fbsd_pspace_data): New type.
7842         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7843         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7844         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7845         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7846         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7847
7848 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7849
7850         * gdbtypes.c (lookup_struct_elt): New function.
7851         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7852         * gdbtypes.h (struct struct_elt): New type.
7853         (lookup_struct_elt): New prototype.
7854
7855 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7856
7857         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7858         remove disabled code block.
7859
7860 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7861
7862         * gdbarch.sh (get_thread_local_address): New method.
7863         * gdbarch.h, gdbarch.c: Regenerate.
7864         * target.c (target_translate_tls_address): Use
7865         gdbarch_get_thread_local_address if present instead of
7866         target::get_thread_local_address.
7867
7868 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7869
7870         * target.h (target::get_thread_local_address): Update comment.
7871
7872 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7873
7874         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7875         objfile->separate_debug_objfile_backlink if not NULL.
7876
7877 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7878
7879         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7880         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7881         (amd64bsd_store_inferior_registers): Likewise.
7882         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7883         Enable segment base registers.
7884         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7885         PT_GETFSBASE and PT_GETGSBASE.
7886         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7887         PT_SETGSBASE.
7888         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7889         segment base registers.
7890         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7891
7892 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7893
7894         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7895         Update calls to i386_target_description to add 'segments'
7896         parameter.
7897         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7898         add segment base registers.
7899         * arch/i386.c (i386_create_target_description): Add 'segments'
7900         parameter to enable segment base registers.
7901         * arch/i386.h (i386_create_target_description): Likewise.
7902         * features/i386/32bit-segments.xml: New file.
7903         * features/i386/32bit-segments.c: Generate.
7904         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7905         call to i386_target_description to add 'segments' parameter.
7906         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7907         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7908         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7909         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7910         if feature is present.
7911         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7912         Add 'segments' parameter to call to i386_target_description.
7913         (i386_target_description): Add 'segments' parameter to enable
7914         segment base registers.
7915         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7916         to call to i386_target_description.
7917         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7918         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7919         Define I386_NUM_REGS.
7920         (i386_target_description): Add 'segments' parameter to enable
7921         segment base registers.
7922
7923 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7924
7925         PR/24325
7926         * source-cache.c: #undef open and close, to avoid unresolved
7927         externals during linking.
7928
7929 2019-03-12  Tom Tromey  <tromey@adacore.com>
7930
7931         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7932         const.  Add initializers.
7933         (_initialize_remote): Don't initialize ptid globals.
7934
7935 2019-03-12  Pedro Alves  <palves@redhat.com>
7936
7937         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7938
7939 2019-03-12  Pedro Alves  <palves@redhat.com>
7940
7941         * cp-name-parser.y (main): Remove unused 'len' variable.
7942
7943 2019-03-12  Tom Tromey  <tromey@adacore.com>
7944
7945         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7946         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7947
7948 2019-03-12  Tom Tromey  <tromey@adacore.com>
7949
7950         * linux-nat.c (iterate_over_lwps): Update.
7951         (stop_callback): Remove parameter.
7952         (stop_wait_callback, detach_callback, resume_set_callback)
7953         (select_singlestep_lwp_callback, set_ignore_sigint)
7954         (status_callback, resumed_callback, resume_clear_callback)
7955         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7956         data parameter.
7957         (linux_nat_target::detach, linux_nat_target::resume)
7958         (linux_stop_and_wait_all_lwps, select_event_lwp)
7959         (linux_nat_filter_event, linux_nat_wait_1)
7960         (linux_nat_target::kill, linux_nat_target::stop)
7961         (linux_nat_target::stop): Update.
7962         (linux_nat_resume_callback): Change type.
7963         (resume_stopped_resumed_lwps, count_events_callback)
7964         (select_event_lwp_callback): Likewise.
7965         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7966         * arm-linux-nat.c (struct update_registers_data): Remove.
7967         (update_registers_callback): Change type.
7968         (arm_linux_insert_hw_breakpoint1): Update.
7969         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7970         parameter.
7971         (x86_linux_dr_set_addr): Update.
7972         (x86_linux_dr_set_control): Update.
7973         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7974         (iterate_over_lwps): Use gdb::function_view.
7975         * nat/aarch64-linux-hw-point.c (struct
7976         aarch64_dr_update_callback_param): Remove.
7977         (debug_reg_change_callback): Change type.
7978         (aarch64_notify_debug_reg_change): Update.
7979         * s390-linux-nat.c (s390_refresh_per_info): Update.
7980
7981 2019-03-11  Tom Tromey  <tromey@adacore.com>
7982
7983         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7984         redundant assignment to "this_cu".
7985
7986 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7987
7988         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7989
7990 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7991
7992         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7993         from...
7994         (rank_one_type): ... this.
7995
7996 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7997
7998         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7999         from...
8000         (rank_one_type): ... this.
8001
8002 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8003
8004         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8005         from...
8006         (rank_one_type): ... this.
8007
8008 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8009
8010         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8011         from...
8012         (rank_one_type): ... this.
8013
8014 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8015
8016         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8017         from...
8018         (rank_one_type): ... this.
8019
8020 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8021
8022         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8023         from...
8024         (rank_one_type): ... this.
8025
8026 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8027
8028         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8029         from...
8030         (rank_one_type): ... this.
8031
8032 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8033
8034         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8035         from...
8036         (rank_one_type): ... this.
8037
8038 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8039
8040         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8041         from...
8042         (rank_one_type): ... this.
8043
8044 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8045
8046         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8047         from...
8048         (rank_one_type): ... this.
8049
8050 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8051
8052         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8053         from...
8054         (rank_one_type): ... this.
8055
8056 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8057
8058         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8059         from...
8060         (rank_one_type): ... this.
8061
8062 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8063
8064         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8065         inferior-events' shows the example events.
8066
8067 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8068
8069         Support styling on native MS-Windows console
8070
8071         PR/24315
8072         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8073         on MS-Windows if $TERM is not defined.
8074
8075         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8076
8077         * posix-hdep.c (gdb_console_fputs):
8078         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8079         functions.
8080         * ui-file.h (gdb_console_fputs): Add prototype.
8081
8082         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8083         back to fputs only if the former returns zero.
8084
8085 2019-03-07  Tom Tromey  <tom@tromey.com>
8086
8087         * symmisc.c (print_symbol_bcache_statistics): Update.
8088         (print_objfile_statistics): Update.
8089         * symfile.c (allocate_symtab): Update.
8090         * stabsread.c: Don't include bcache.h.
8091         * psymtab.h (struct psymbol_bcache): Don't declare.
8092         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8093         (psymbol_bcache_init, psymbol_bcache_free)
8094         (psymbol_bcache_get_bcache): Don't declare.
8095         * psymtab.c (struct psymbol_bcache): Remove.
8096         (psymtab_storage::psymtab_storage): Update.
8097         (psymtab_storage::~psymtab_storage): Update.
8098         (psymbol_bcache_init, psymbol_bcache_free)
8099         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8100         (add_psymbol_to_bcache): Update.
8101         (allocate_psymtab): Update.
8102         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8103         macro_cache>: No longer pointers.
8104         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8105         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8106         * macrotab.c (macro_bcache): Update.
8107         * macroexp.c: Don't include bcache.h.
8108         * gdbtypes.c (check_types_worklist): Update.
8109         (types_deeply_equal): Remove TRY/CATCH.  Update.
8110         * elfread.c (elf_symtab_read): Update.
8111         * dwarf2read.c: Don't include bcache.h.
8112         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8113         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8114         (print_bcache_statistics, bcache_memory_used): Don't declare.
8115         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8116         methods.  Rename all data members.
8117         * bcache.c (struct bcache): Move to bcache.h.
8118         (bcache::expand_hash_table): Rename from expand_hash_table.
8119         (bcache): Remove.
8120         (bcache::insert): Rename from bcache_full.
8121         (bcache::compare): Rename from bcache_compare.
8122         (bcache_xmalloc): Remove.
8123         (bcache::~bcache): Rename from bcache_xfree.
8124         (bcache::print_statistics): Rename from print_bcache_statistics.
8125         (bcache::memory_used): Rename from bcache_memory_used.
8126
8127 2019-03-07  Pedro Alves  <palves@redhat.com>
8128
8129         * infrun.c (normal_stop): Also check for
8130         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8131
8132 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8133
8134         * f-lang.c (value_from_host_double): Moved to...
8135         * value.c (value_from_host_double): ...here.
8136         * value.h (value_from_host_double): Declare.
8137         * guile/scm-math.c (vlscm_convert_typed_number): Use
8138         value_from_host_double.
8139         (vlscm_convert_number): Likewise.
8140         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8141         * python/py-value.c (convert_value_from_python): Likewise.
8142
8143 2019-03-06  Tom Tromey  <tom@tromey.com>
8144
8145         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8146
8147 2019-03-06  Tom Tromey  <tom@tromey.com>
8148
8149         * utils.h (free_current_contents): Don't declare.
8150         * utils.c (free_current_contents): Remove.
8151
8152 2019-03-06  Tom Tromey  <tom@tromey.com>
8153
8154         * top.c (quit_force): Update.
8155         * main.c (captured_command_loop): Update.
8156         * common/new-op.c (operator new): Update.
8157         * common/common-exceptions.c (struct catcher)
8158         <save_cleanup_chain>: Remove member.
8159         (exceptions_state_mc_init): Update.
8160         (exception_try_scope_entry): Return nullptr.
8161         (exception_try_scope_exit, exception_rethrow)
8162         (throw_exception_sjlj, throw_exception_cxx): Update.
8163         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8164         (all_cleanups, do_cleanups, discard_cleanups)
8165         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8166         (restore_cleanups, restore_final_cleanups): Don't declare.
8167         (do_final_cleanups): Remove parameter.
8168         * common/cleanups.c (cleanup_chain, make_cleanup)
8169         (make_cleanup_dtor, all_cleanups, do_cleanups)
8170         (discard_my_cleanups, discard_cleanups)
8171         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8172         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8173         (null_cleanup): Remove.
8174         (do_final_cleanups): Remove parameter.
8175
8176 2019-03-06  Tom Tromey  <tom@tromey.com>
8177
8178         * remote.c (remote_target::remote_parse_stop_reply): Use
8179         unique_xmalloc_ptr.
8180
8181 2019-03-06  Tom Tromey  <tom@tromey.com>
8182
8183         * stabsread.c (struct stabs_field_info): Rename from field_info.
8184         <list, fnlist>: Add initializers.
8185         <obstack>: New member.
8186         (read_member_functions, read_struct_fields, read_baseclasses):
8187         Allocate on obstack.  Don't use cleanups.
8188         (read_one_struct_field, read_member_functions, read_struct_fields)
8189         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8190         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8191         (read_struct_type): Update.
8192
8193 2019-03-06  Tom Tromey  <tom@tromey.com>
8194
8195         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8196         * common/filestuff.h (make_cleanup_close): Don't declare.
8197         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8198         Remove.
8199
8200 2019-03-06  Tom Tromey  <tom@tromey.com>
8201
8202         * solib-aix.c: Use make_scope_exit.
8203
8204 2019-03-06  Tom Tromey  <tom@tromey.com>
8205
8206         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8207         Use make_scope_exit.
8208
8209 2019-03-06  Tom Tromey  <tom@tromey.com>
8210
8211         * solib-svr4.c (disable_probes_interface): Remove parameter.
8212         (svr4_handle_solib_event): Use make_scope_exit.
8213
8214 2019-03-06  Tom Tromey  <tom@tromey.com>
8215
8216         * remote.c (struct stop_reply_deleter): Remove.
8217         (stop_reply_up): Update.
8218         (struct stop_reply): Derive from notif_event.  Don't typedef.
8219         <regcache>: Now a std::vector.
8220         (stop_reply_xfree): Remove.
8221         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8222         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8223         (remote_target::discard_pending_stop_replies): Use delete.
8224         (remote_target::remote_parse_stop_reply): Update.
8225         (remote_target::process_stop_reply): Update.
8226         * remote-notif.h (struct notif_event): Add virtual destructor.
8227         Remove "dtr" member.
8228         (struct notif_client) <alloc_event>: Return a unique_ptr.
8229         (notif_event_xfree): Don't declare.
8230         (notif_event_up): New typedef.
8231         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8232         (notif_event_xfree, do_notif_event_xfree): Remove.
8233         (remote_notif_state_xfree): Update.
8234
8235 2019-03-06  Tom Tromey  <tom@tromey.com>
8236
8237         * infrun.c (displaced_step_clear_cleanup): Now a
8238         forward_scope_exit type.
8239         (displaced_step_prepare_throw): Update.
8240         (displaced_step_fixup): Update.
8241
8242 2019-03-06  Tom Tromey  <tom@tromey.com>
8243
8244         * inferior.h (class inferior): Update comment.
8245         * gdbthread.h (class thread_info): Update comment.
8246
8247 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8248             Tom Tromey  <tom@tromey.com>
8249
8250         * stabsread.h (struct stab_section_list): Remove.
8251         (coffstab_build_psymtabs): Update.
8252         * dbxread.c (symbuf_sections): Now a std::vector.
8253         (sect_idx): New global.
8254         (fill_symbuf): Update.
8255         (coffstab_build_psymtabs): Change type of stabsects parameter.
8256         Update.
8257         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8258         std::vector.
8259         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8260         (coff_locate_sections): Update.
8261         (coff_symfile_read): Remove cleanups.  Update.
8262         (init_stringtab): Add storage parameter.
8263         (free_stringtab, free_stringtab_cleanup): Remove.
8264         (init_lineno): Add storage parameter.
8265         (free_linetab, free_linetab_cleanup): Remove.
8266
8267 2019-03-06  Pedro Alves  <palves@redhat.com>
8268
8269         * linux-fork.c (fork_info::clobber_regs): Delete.
8270         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8271         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8272         comment.  Adjust.
8273         (scoped_switch_fork_info::scoped_switch_fork_info)
8274         (checkpoint_command, linux_fork_context): Adjust
8275         fork_save_infrun_state calls.
8276
8277 2019-03-06  Pedro Alves  <palves@redhat.com>
8278
8279         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8280         (inf_has_multiple_threads): Return 'bool' and rewrite using
8281         inferior_info::threads().
8282
8283 2019-03-06  Pedro Alves  <palves@redhat.com>
8284
8285         * linux-fork.c: Include <list>.
8286         (fork_list): Now a std::list instance.
8287         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8288         (forks_exist_p, find_last_fork): Adjust.
8289         (new_fork): Delete.
8290         (one_fork_p): New.
8291         (add_fork): Adjust.
8292         (free_fork): Delete, folded into fork_info::~fork_info().
8293         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8294         Adjust.
8295         (init_fork_list): Delete.
8296         (linux_fork_killall, linux_fork_mourn_inferior)
8297         (linux_fork_detach, info_checkpoints_command): Adjust.
8298         (_initialize_linux_fork): No longer call init_fork_list.
8299
8300 2019-03-06  Pedro Alves  <palves@redhat.com>
8301
8302         * linux-fork.c (new_fork): New, split out of ...
8303         (add_fork): ... this.  Return void.  Move "first fork" special
8304         case from here, to ...
8305         (checkpoint_command): ... here.
8306         * linux-linux.h (add_fork): Return void.
8307
8308 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8309
8310         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8311
8312 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8313             Chris January  <chris.january@arm.com>
8314             David Lecomber  <david.lecomber@arm.com>
8315
8316         * f-exp.y: New token, UNOP_INTRINSIC.
8317         (exp): New pattern using UNOP_INTRINSIC token.
8318         (f77_keywords): Add 'abs' keyword.
8319         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8320         (value_from_host_double): New function.
8321         (evaluate_subexp_f): Support UNOP_ABS.
8322
8323 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8324
8325         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8326         types.
8327
8328 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8329
8330         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8331         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8332         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8333
8334 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8335
8336         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8337
8338 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8339             Chris January  <chris.january@arm.com>
8340
8341         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8342         * f-exp.y: Define 'KIND' token.
8343         (exp): New pattern for KIND expressions.
8344         (ptype): Handle types with a kind extension.
8345         (direct_abs_decl): Extend to spot kind extensions.
8346         (f77_keywords): Add 'kind' to the list.
8347         (push_kind_type): New function.
8348         (convert_to_kind_type): New function.
8349         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8350         * parse.c (operator_length_standard): Likewise.
8351         * parser-defs.h (enum type_pieces): Add tp_kind.
8352         * std-operator.def: Add UNOP_KIND.
8353
8354 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8355
8356         * f-exp.y (f_parse): Set yydebug.
8357
8358 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8359
8360         * f-lang.c (evaluate_subexp_f): New function.
8361         (exp_descriptor_f): New global.
8362         (f_language_defn): Use exp_descriptor_f instead of
8363         exp_descriptor_standard.
8364
8365 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8366
8367         * f-exp.y (struct token): Add comments.
8368         (dot_ops): Remove uppercase versions and the end marker.
8369         (f77_keywords): Likewise.
8370         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8371         entries in the dot_ops array are case insensitive, and use
8372         strncasecmp to compare strings.  Also some whitespace cleanup in
8373         this area.  Similar for the f77_keywords array, except entries in
8374         this list might be case sensitive.
8375
8376 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8377
8378         * f-exp.y (struct f77_boolean_val): Add comments.
8379         (boolean_values): Remove uppercase versions, and end marker.
8380         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8381         and use strncasecmp to achieve case insensitivity.  Additionally,
8382         perform whitespace cleanup around this code.
8383
8384 2019-03-06  Tom Tromey  <tromey@adacore.com>
8385
8386         * remote-sim.c (gdbsim_target_open): Use result of
8387         gdb_argv::release.
8388
8389 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8390         Dirk Schubert  <dirk.schubert@arm.com>
8391         Chris January  <chris.january@arm.com>
8392
8393         * eval.c (evaluate_subexp_standard): Call Fortran argument
8394         wrapping logic.
8395         * f-lang.c (struct value): A value which can be passed into a
8396         Fortran function call.
8397         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8398         where appropriate.
8399         (struct type): Value ready for a Fortran function call.
8400         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8401         is needed.
8402         * f-lang.h (fortran_argument_convert): Declaration.
8403         (fortran_preserve_arg_pointer): Declaration.
8404         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8405
8406 2019-03-05  Tom Tromey  <tromey@adacore.com>
8407
8408         * python/py-prettyprint.c (print_string_repr): Remove #if.
8409         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8410
8411 2019-03-05  Tom Tromey  <tromey@adacore.com>
8412
8413         * target.c (the_dummy_target): Move later.  Change type to
8414         "dummy_target".
8415         (initialize_targets): Don't initialize the_dummy_target.
8416
8417 2019-03-05  Tom Tromey  <tromey@adacore.com>
8418
8419         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8420         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8421
8422 2019-03-05  Tom Tromey  <tromey@adacore.com>
8423
8424         * windows-nat.c (windows_nat_target::attach)
8425         (windows_nat_target::detach): Don't call gdb_flush.
8426         * valprint.c (generic_val_print, val_print, val_print_string):
8427         Don't call gdb_flush.
8428         * utils.c (defaulted_query): Don't call gdb_flush.
8429         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8430         * target.c (target_announce_detach): Don't call gdb_flush.
8431         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8432         * remote.c (extended_remote_target::attach): Don't call
8433         gdb_flush.
8434         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8435         * printcmd.c (do_examine): Don't call gdb_flush.
8436         (info_display_command): Don't call gdb_flush.
8437         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8438         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8439         * memattr.c (info_mem_command): Don't call gdb_flush.
8440         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8441         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8442         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8443         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8444         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8445         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8446         (gnu_nat_target::detach): Don't call gdb_flush.
8447         * f-valprint.c (f_val_print): Don't call gdb_flush.
8448         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8449         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8450         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8451         gdb_flush.
8452         * c-valprint.c (c_val_print): Don't call gdb_flush.
8453         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8454
8455 2019-03-05  Tom Tromey  <tromey@adacore.com>
8456
8457         * varobj.c (update_dynamic_varobj_children): Update.
8458         (install_default_visualizer): Use reset, not release.
8459         * value.c (set_internalvar): Update.
8460         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8461         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8462         ATTRIBUTE_UNUSED_RESULT.
8463
8464 2019-03-05  Tom Tromey  <tromey@adacore.com>
8465
8466         * remote.c (class scoped_remote_fd) <release>: Add
8467         ATTRIBUTE_UNUSED_RESULT.
8468
8469 2019-03-05  Tom Tromey  <tromey@adacore.com>
8470
8471         * macroexp.c (struct macro_buffer) <release>: Add
8472         ATTRIBUTE_UNUSED_RESULT.
8473
8474 2019-03-05  Tom Tromey  <tromey@adacore.com>
8475
8476         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8477         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8478         ATTRIBUTE_UNUSED_RESULT.
8479
8480 2019-03-05  Tom Tromey  <tromey@adacore.com>
8481
8482         * common/scoped_fd.h (class scoped_fd) <release>: Add
8483         ATTRIBUTE_UNUSED_RESULT.
8484
8485 2019-03-05  Tom Tromey  <tromey@adacore.com>
8486
8487         * parser-defs.h (struct parser_state) <release>: Add
8488         ATTRIBUTE_UNUSED_RESULT.
8489
8490 2019-03-05  Tom Tromey  <tromey@adacore.com>
8491
8492         * utils.h (class gdb_argv) <release>: Add
8493         ATTRIBUTE_UNUSED_RESULT.
8494         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8495
8496 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8497
8498         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8499         for-loop range, to avoid compiler warnings.
8500
8501         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8502         avoid compiler warnings about unused variables.
8503
8504         * NEWS: Mention end of support for native debugging on MS-Windows
8505         before XP.
8506
8507         PR gdb/24292
8508         * common/netstuff.c:
8509         * gdbserver/gdbreplay.c
8510         * gdbserver/remote-utils.c:
8511         * ser-tcp.c:
8512         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8513         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8514         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8515         'getaddrinfo' and 'freeaddrinfo' were not available before
8516         Windows XP, and mingw.org's MinGW headers by default define
8517         _WIN32_WINNT to 0x500.
8518
8519 2019-03-01  Gary Benson <gbenson@redhat.com>
8520
8521         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8522
8523 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8524             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8525
8526         PR gdb/8527
8527         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8528         set_sigint_trap, clear_sigint_trap.
8529
8530 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8531
8532         * target.c (target_detach): Clear the regcache and the
8533         frame cache.
8534
8535 2019-02-27  Pedro Alves  <palves@redhat.com>
8536
8537         * utils.c (set_screen_size): When we cap the height/width sizes,
8538         tweak the corresponding command variable to show "unlimited":
8539
8540 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8541             Pedro Alves  <palves@redhat.com>
8542
8543         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8544         before calling rl_set_screen_size.
8545
8546 2019-02-27  Tom Tromey  <tromey@adacore.com>
8547
8548         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8549         define.
8550         * python/py-value.c: Remove Python 2.4 workaround.
8551         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8552         workaround.
8553         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8554         Python 2.4 workaround.
8555         * python/python-internal.h: Remove Python 2.4 comment.
8556         (Py_ssize_t): Don't define.
8557         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8558         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8559         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8560         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8561         * python/python.c (do_start_initialization): Remove Python 2.4
8562         workaround.
8563         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8564         (print_children): Remove Python 2.4 workaround.
8565         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8566         workaround.
8567         (CHARBUFFERPROC_NAME): Remove.
8568         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8569         Python 2.4 workaround.
8570
8571 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8572
8573         * NEWS: Note minimum Python version.
8574
8575 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8576
8577         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8578         code from these functions.  Remove corresponding ifdefs.  Use
8579         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8580         Remove gotos and target of gotos.
8581         (infpy_search_memory): Likewise.
8582
8583 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8584
8585         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8586         (hppa_gdbarch_init): Don't register deleted functions with
8587         gdbarch.
8588
8589 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8590
8591         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8592         (h8300_unwind_sp): Delete.
8593         (h8300_dummy_id): Delete.
8594         (h8300_gdbarch_init): Don't register deleted functions with
8595         gdbarch.
8596
8597 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8598
8599         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8600         (ft32_unwind_pc): Delete.
8601         (ft32_unwind_sp): Delete.
8602         (ft32_gdbarch_init): Don't register deleted functions with
8603         gdbarch.
8604
8605 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8606
8607         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8608         (frv_unwind_pc): Delete.
8609         (frv_unwind_sp): Delete.
8610         (frv_gdbarch_init): Don't register deleted functions with
8611         gdbarch.
8612
8613 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8614
8615         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8616         (riscv_unwind_pc): Delete.
8617         (riscv_unwind_sp): Delete.
8618         (riscv_gdbarch_init): Don't register deleted functions with
8619         gdbarch.
8620
8621 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8622
8623         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8624         (csky_unwind_pc): Delete.
8625         (csky_unwind_sp): Delete.
8626         (csky_gdbarch_init): Don't register deleted functions with
8627         gdbarch.
8628
8629 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8630
8631         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8632         (cris_unwind_pc): Delete.
8633         (cris_unwind_sp): Delete.
8634         (cris_gdbarch_init): Don't register deleted functions with
8635         gdbarch.
8636
8637 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8638
8639         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8640         (bfin_unwind_pc): Delete.
8641         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8642
8643 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8644
8645         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8646         (arm_unwind_pc): Delete.
8647         (arm_unwind_sp): Delete.
8648         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8649
8650 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8651
8652         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8653         (arc_unwind_pc): Delete.
8654         (arc_unwind_sp): Delete.
8655         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8656
8657 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8658
8659         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8660         (alpha_unwind_pc): Delete.
8661         (alpha_gdbarch_init): Don't register deleted functions with
8662         gdbarch.
8663
8664 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8665
8666         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8667         (aarch64_unwind_pc): Delete.
8668         (aarch64_unwind_sp): Delete.
8669         (aarch64_gdbarch_init): Don't register deleted functions with
8670         gdbarch.
8671
8672 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8673
8674         * gdbtypes.c (type_align): Don't consider static members when
8675         computing structure alignment.
8676
8677 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8678
8679         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8680         return 0 for other types.
8681         * arch-utils.c (default_type_align): Always return 0.
8682         * gdbarch.h: Regenerate.
8683         * gdbarch.sh (type_align): Extend comment.
8684         * gdbtypes.c (type_align): Add additional comments, always call
8685         gdbarch_type_align before applying the default rules.
8686         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8687         generic code will then apply a suitable default.
8688         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8689         types, return 0 for other types.
8690
8691 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8692
8693         * NEWS: Create a new section for the next release branch.
8694         Rename the section of the current branch, now that it has
8695         been cut.
8696
8697 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8698
8699         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8700         * version.in: Bump version to 8.3.50.DATE-git.
8701
8702 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8703
8704         * aix-thread.c (ptid_cmp): Remove unused variable.
8705         (get_signaled_thread): Likewise.
8706         (store_regs_user_thread): Likewise.
8707         (store_regs_kernel_thread): Likewise.
8708         (fetch_regs_kernel_thread): Remove shadowed variable.
8709
8710 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8711
8712         * features/riscv/32bit-cpu.xml: Add register numbers.
8713         * features/riscv/32bit-fpu.c: Regenerate.
8714         * features/riscv/32bit-fpu.xml: Add register numbers.
8715         * features/riscv/64bit-cpu.xml: Add register numbers.
8716         * features/riscv/64bit-fpu.c: Regenerate.
8717         * features/riscv/64bit-fpu.xml: Add register numbers.
8718
8719 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8720
8721         * NEWS: Mention two argument form of gdb.Value constructor.
8722         * python/py-value.c (convert_buffer_and_type_to_value): New
8723         function.
8724         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8725         Add support for handling an optional second argument.  Call
8726         convert_buffer_and_type_to_value as appropriate.
8727         * python/python-internal.h (Py_buffer_deleter): New struct.
8728         (Py_buffer_up): New typedef.
8729
8730 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8731
8732         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8733         instead of releasing ownership.
8734
8735 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8736
8737         * dwarf2read.c (open_and_init_dwp_file): Call
8738         elf_numsections instead of bfd_count_sections to initialize
8739         dwp_file->num_sections.
8740
8741 2019-02-25  Tom Tromey  <tromey@adacore.com>
8742
8743         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8744
8745 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8746
8747         * gcore.in: Add '--readnever' option when invoking GDB.
8748
8749 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8750
8751         * MAINTAINERS: Update my email address.
8752
8753 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8754
8755         * build-id.c (build_id_to_debug_bfd_1): New function.
8756         (build_id_to_debug_bfd): Look for separate debug file in
8757         sysroot.
8758
8759 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8760
8761         * gdbarch.sh: Update the copyright year range that is placed into
8762         generated files.
8763
8764 2019-02-22  Keith Seitz  <keiths@redhat.com>
8765
8766         PR symtab/23853
8767         * linespec.c (create_sals_line_offset): Search for the default
8768         symtab's filename instead of its fullname.
8769
8770 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8771
8772         * NEWS: Update style defaults.
8773
8774 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8775
8776         * main.c (captured_main_1): Disable styling in batch mode.
8777
8778 2019-02-20  Tom Tromey  <tom@tromey.com>
8779
8780         * symtab.c (symtab_symbol_info): Fix typos.
8781
8782 2019-02-20  Tom Tromey  <tromey@adacore.com>
8783
8784         * findcmd.c (_initialize_mem_search): Use upper case for
8785         metasyntactic variables.
8786
8787 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8788
8789         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8790         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8791
8792 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8793
8794         * top.h (source_file_name): Change to std::string.
8795         * top.c (source_file_name): Likewise.
8796         (command_line_input): Adjust.
8797         * cli/cli-script.c (script_from_file): Adjust.
8798
8799 2019-02-19  Tom Tromey  <tromey@adacore.com>
8800
8801         * ravenscar-thread.c
8802         (ravenscar_thread_target::update_thread_list): Don't call
8803         ada_build_task_list.
8804         * ada-lang.h (ada_build_task_list): Don't declare.
8805         * ada-tasks.c (struct ada_tasks_inferior_data)
8806         <task_list_valid_p>: Now bool.
8807         (read_known_tasks, ada_task_list_changed)
8808         (ada_tasks_invalidate_inferior_data): Update.
8809         (read_known_tasks_array): Return bool.
8810         (read_known_tasks_list): Likewise.
8811         (read_known_tasks): Return void.
8812         (ada_build_task_list): Now static.
8813
8814 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8815
8816         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8817         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8818
8819 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8820
8821         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8822         variant for ada_tasks_pspace_data_handle and
8823         ada_tasks_inferior_data_handle.
8824         (ada_tasks_pspace_data_cleanup): New function.
8825         (ada_tasks_inferior_data_cleanup): New function.
8826
8827 2019-02-17  Tom Tromey  <tom@tromey.com>
8828
8829         * macrotab.h (macro_source_fullname): Return a std::string.
8830         * macrotab.c (macro_include, check_for_redefinition)
8831         (macro_undef, macro_lookup_definition, foreach_macro)
8832         (foreach_macro_in_scope): Update.
8833         (macro_source_fullname): Return a std::string.
8834         * macrocmd.c (show_pp_source_pos): Update.
8835
8836 2019-02-17  Tom Tromey  <tom@tromey.com>
8837
8838         * macrocmd.c (show_pp_source_pos): Style the file names.
8839
8840 2019-02-17  Tom Tromey  <tom@tromey.com>
8841
8842         PR tui/24197:
8843         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8844
8845 2019-02-17  Tom Tromey  <tom@tromey.com>
8846
8847         * ada-lang.c (user_select_syms): Use filtered printing.
8848         * utils.c (wrap_style): New global.
8849         (desired_style): Remove.
8850         (emit_style_escape): Add stream parameter.
8851         (set_output_style, reset_terminal_style, prompt_for_continue):
8852         Update.
8853         (flush_wrap_buffer): Only flush gdb_stdout.
8854         (wrap_here): Set wrap_style.
8855         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8856         treat escape sequences as a character.  Change when wrap buffer is
8857         flushed.
8858         (fputs_styled): Do not set the output style when the default is
8859         requested.
8860         * ui-style.h (struct ui_file_style) <is_default>: New method.
8861         * source.c (print_source_lines_base): Emit escape sequences in one
8862         piece.
8863
8864 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8865
8866         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8867         integers and enumeration types.
8868
8869 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8870
8871         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8872         instead of lookup_symbol_in_language
8873         (do_exact_match): New function.
8874         (ada_get_symbol_name_matcher): Return do_exact_match when
8875         doing a verbatim match.
8876
8877 2019-02-15  Tom Tromey  <tromey@adacore.com>
8878
8879         * ravenscar-thread.c (ravenscar_thread_target::resume)
8880         (ravenscar_thread_target::wait): Special case wildcard requests.
8881
8882 2019-02-15  Tom Tromey  <tromey@adacore.com>
8883
8884         * ravenscar-thread.c (base_ptid): Remove.
8885         (struct ravenscar_thread_target) <close>: New method.
8886         <m_base_ptid>: New member.
8887         <update_inferior_ptid, active_task, task_is_currently_active,
8888         runtime_initialized>: Declare methods.
8889         <ravenscar_thread_target>: Add constructor.
8890         (ravenscar_thread_target::task_is_currently_active)
8891         (ravenscar_thread_target::update_inferior_ptid)
8892         (ravenscar_runtime_initialized): Rename.  Now methods.
8893         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8894         (ravenscar_thread_target::update_thread_list): Update.
8895         (ravenscar_thread_target::active_task): Now method.
8896         (ravenscar_thread_target::store_registers)
8897         (ravenscar_thread_target::prepare_to_store)
8898         (ravenscar_thread_target::prepare_to_store)
8899         (ravenscar_thread_target::mourn_inferior): Update.
8900         (ravenscar_inferior_created): Use "new" to create target.
8901         (ravenscar_thread_target::get_ada_task_ptid): Update.
8902         (_initialize_ravenscar): Don't initialize base_ptid.
8903         (ravenscar_ops): Remove global.
8904
8905 2019-02-15  Tom Tromey  <tromey@adacore.com>
8906
8907         * target.h (push_target): Declare new overload.
8908         * target.c (push_target): New overload, taking an rvalue reference.
8909         * remote.c (remote_target::open_1): Use push_target overload.
8910         * corelow.c (core_target_open): Use push_target overload.
8911
8912 2019-02-15  Tom Tromey  <tromey@adacore.com>
8913
8914         * ravenscar-thread.c (is_ravenscar_task)
8915         (ravenscar_task_is_currently_active): Return bool.
8916         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8917         (_initialize_ravenscar): Remove "(void)".
8918         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8919         Return bool.
8920
8921 2019-02-15  Tom Tromey  <tromey@adacore.com>
8922
8923         * ravenscar-thread.c (ravenscar_runtime_initializer)
8924         (has_ravenscar_runtime, get_running_thread_id)
8925         (ravenscar_thread_target::resume): Fix indentation.
8926
8927 2019-02-15  Tom Tromey  <tromey@adacore.com>
8928
8929         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8930         from ravenscar_arch_ops.
8931         (sparc_ravenscar_ops::fetch_registers)
8932         (sparc_ravenscar_ops::store_registers): Now methods.
8933         (sparc_ravenscar_prepare_to_store): Remove.
8934         (sparc_ravenscar_ops): Redefine.
8935         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8936         methods and destructor.  Remove members.
8937         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8938         (ravenscar_thread_target::store_registers)
8939         (ravenscar_thread_target::prepare_to_store): Update.
8940         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8941         Remove.
8942         (struct ppc_ravenscar_powerpc_ops): Derive from
8943         ravenscar_arch_ops.
8944         (ppc_ravenscar_powerpc_ops::fetch_registers)
8945         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8946         (ppc_ravenscar_powerpc_ops): Redefine.
8947         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8948         (ppc_ravenscar_e500_ops::fetch_registers)
8949         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8950         (ppc_ravenscar_e500_ops): Redefine.
8951         * aarch64-ravenscar-thread.c
8952         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8953         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8954         (aarch64_ravenscar_fetch_registers)
8955         (aarch64_ravenscar_store_registers): Now methods.
8956         (aarch64_ravenscar_ops): Redefine.
8957
8958 2019-02-15  Tom Tromey  <tromey@adacore.com>
8959
8960         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8961         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8962         (ravenscar_thread_target::stopped_by_watchpoint)
8963         (ravenscar_thread_target::stopped_data_address)
8964         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8965
8966 2019-02-15  Tom Tromey  <tromey@adacore.com>
8967
8968         * ravenscar-thread.c: Fix some typos.
8969
8970 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8971             Tom Tromey  <tromey@adacore.com>
8972
8973         * ada-lang.c (ada_exception_sal): Change addr_string to a
8974         std::string.
8975         (create_ada_exception_catchpoint): Update.
8976
8977 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8978             Tom Tromey  <tromey@adacore.com>
8979
8980         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8981         (bp_location_ops): Remove.
8982         (base_breakpoint_allocate_location): Update.
8983         (free_bp_location): Update.
8984         * ada-lang.c (class ada_catchpoint_location)
8985         <ada_catchpoint_location>: Remove ops parameter.
8986         (ada_catchpoint_location_dtor): Remove.
8987         (ada_catchpoint_location_ops): Remove.
8988         (allocate_location_exception): Update.
8989         * breakpoint.h (struct bp_location_ops): Remove.
8990         (class bp_location) <bp_location>: Remove bp_location_ops
8991         parameter.
8992         <~bp_location>: Add destructor.
8993         <ops>: Remove.
8994
8995 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8996             Pedro Alves  <palves@redhat.com>
8997
8998         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8999         'PATH_MAX'.
9000
9001 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9002             Samuel Thibault  <samuel.thibault@gnu.org>
9003             Thomas Schwinge  <thomas@codesourcery.com>
9004
9005         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9006         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9007
9008 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9009
9010         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9011         (check_empty): Use "const char *".
9012
9013         * gnu-nat.c (gnu_nat_target::detach): Instead of
9014         'detach_inferior (pid)' call
9015         'detach_inferior (find_inferior_pid (pid))'.
9016
9017         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9018         'nat/fork-inferior.o'.
9019         * gnu-nat.c: #include "nat/fork-inferior.h".
9020
9021         * gnu-nat.c (gnu_nat_target::detach): Instead of
9022         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9023         * gnu-nat.h: #include "inf-child.h".
9024         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9025         'i386_gnu_nat_target::fetch_registers'.
9026         (gnu_store_registers): Rename/move to
9027         'i386_gnu_nat_target::store_registers'.
9028
9029         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9030         * gnu-nat.h (mach_thread_info): New function.
9031         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9032
9033         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9034
9035 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9036
9037         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9038
9039 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9040
9041         * windows-nat.c (windows_add_thread): Add new parameter
9042         "main_thread_p" with default value set to false.  Update
9043         function documentation as well as all callers.
9044         (windows_delete_thread): Likewise.
9045         (fake_create_process): Update call to windows_add_thread.
9046         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9047         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9048         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9049         call to windows_delete_thread.
9050
9051 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9052
9053         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9054
9055 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9056
9057         * symfile.c (find_separate_debug_file): Use canonical path of
9058         sysroot with child_path instead of gdb_sysroot if it is valid.
9059
9060 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9061
9062         * symfile.c (find_separate_debug_file): Use child_path to
9063         determine if an object file is under a sysroot.
9064
9065 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9066
9067         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9068         unittests/child-path-selftests.c.
9069         * common/pathstuff.c (child_path): New function.
9070         * common/pathstuff.h (child_path): New prototype.
9071         * unittests/child-path-selftests.c: New file.
9072
9073 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9074
9075         * symfile.c (find_separate_debug_file): Look for separate debug
9076         files in debug directories under the sysroot.
9077
9078 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9079
9080         * symtab.h (struct minimal_symbol data_p): New const method.
9081         (struct minimal_symbol text_p): Likewise.
9082         * symtab.c (output_source_filename): Use file name style
9083         to print file name.
9084         (print_symbol_info): Likewise.
9085         (print_msymbol_info): Use address style to print addresses.
9086         Use function name style to print executable text symbols.
9087         (expand_symtab_containing_pc): Use data_p.
9088         (find_pc_sect_compunit_symtab): Likewise.
9089
9090 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9091
9092         * breakpoint.c (describe_other_breakpoints): Use address style
9093         to print addresses.
9094         (say_where): Likewise.
9095
9096 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9097
9098         * ada-typeprint.c (print_func_type): Print function name
9099         style to print function name.
9100         * c-typeprint.c (c_print_type_1): Likewise.
9101
9102 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9103
9104         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9105         for execve.
9106
9107 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9108
9109         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9110         type_stack.
9111
9112 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9113
9114         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9115         TYPE_CODE_REF types.
9116
9117 2019-02-08  Jim Wilson  <jimw@sifive.com>
9118
9119         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9120         (riscv_linux_fregset): New.
9121         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9122
9123 2019-02-07  Tom Tromey  <tom@tromey.com>
9124
9125         * thread.c (thread_cancel_execution_command): Update.
9126         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9127         methods.
9128         (struct thread_fsm_ops): Remove.
9129         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9130         (thread_fsm_should_stop, thread_fsm_return_value)
9131         (thread_fsm_set_finished, thread_fsm_finished_p)
9132         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9133         Don't declare.
9134         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9135         * infrun.c (clear_proceed_status_thread)
9136         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9137         (print_stop_event): Update.
9138         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9139         Add constructor.
9140         (step_command_fsm_ops): Remove.
9141         (new_step_command_fsm): Remove.
9142         (step_1): Update.
9143         (step_command_fsm::should_stop): Rename from
9144         step_command_fsm_should_stop.
9145         (step_command_fsm::clean_up): Rename from
9146         step_command_fsm_clean_up.
9147         (step_command_fsm::do_async_reply_reason): Rename from
9148         step_command_fsm_async_reply_reason.
9149         (struct until_next_fsm): Inherit from thread_fsm.  Add
9150         constructor.
9151         (until_next_fsm_ops): Remove.
9152         (new_until_next_fsm): Remove.
9153         (until_next_fsm::should_stop): Rename from
9154         until_next_fsm_should_stop.
9155         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9156         (until_next_fsm::do_async_reply_reason): Rename from
9157         until_next_fsm_async_reply_reason.
9158         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9159         constructor.  Change type of breakpoint.
9160         (finish_command_fsm_ops): Remove.
9161         (new_finish_command_fsm): Remove.
9162         (finish_command_fsm::should_stop): Rename from
9163         finish_command_fsm_should_stop.
9164         (finish_command_fsm::clean_up): Rename from
9165         finish_command_fsm_clean_up.
9166         (finish_command_fsm::return_value): Rename from
9167         finish_command_fsm_return_value.
9168         (finish_command_fsm::do_async_reply_reason): Rename from
9169         finish_command_fsm_async_reply_reason.
9170         (finish_command): Update.
9171         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9172         Add constructor.
9173         (call_thread_fsm_ops): Remove.
9174         (call_thread_fsm::call_thread_fsm): Rename from
9175         new_call_thread_fsm.
9176         (call_thread_fsm::should_stop): Rename from
9177         call_thread_fsm_should_stop.
9178         (call_thread_fsm::should_notify_stop): Rename from
9179         call_thread_fsm_should_notify_stop.
9180         (run_inferior_call, call_function_by_hand_dummy): Update.
9181         * cli/cli-interp.c (should_print_stop_to_console): Update.
9182         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9183         Add constructor.  Change type of location_breakpoint,
9184         caller_breakpoint.
9185         (until_break_fsm_ops): Remove.
9186         (new_until_break_fsm): Remove.
9187         (until_break_fsm::should_stop): Rename from
9188         until_break_fsm_should_stop.
9189         (until_break_fsm::clean_up): Rename from
9190         until_break_fsm_clean_up.
9191         (until_break_fsm::do_async_reply_reason): Rename from
9192         until_break_fsm_async_reply_reason.
9193         (until_break_command): Update.
9194         * thread-fsm.c: Remove.
9195         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9196
9197 2019-02-07  Tom Tromey  <tom@tromey.com>
9198
9199         * yy-remap.h: Add include guard.
9200         * xtensa-tdep.h: Add include guard.
9201         * xcoffread.h: Rename include guard.
9202         * varobj-iter.h: Add include guard.
9203         * tui/tui.h: Rename include guard.
9204         * tui/tui-winsource.h: Rename include guard.
9205         * tui/tui-wingeneral.h: Rename include guard.
9206         * tui/tui-windata.h: Rename include guard.
9207         * tui/tui-win.h: Rename include guard.
9208         * tui/tui-stack.h: Rename include guard.
9209         * tui/tui-source.h: Rename include guard.
9210         * tui/tui-regs.h: Rename include guard.
9211         * tui/tui-out.h: Rename include guard.
9212         * tui/tui-layout.h: Rename include guard.
9213         * tui/tui-io.h: Rename include guard.
9214         * tui/tui-hooks.h: Rename include guard.
9215         * tui/tui-file.h: Rename include guard.
9216         * tui/tui-disasm.h: Rename include guard.
9217         * tui/tui-data.h: Rename include guard.
9218         * tui/tui-command.h: Rename include guard.
9219         * tic6x-tdep.h: Add include guard.
9220         * target/waitstatus.h: Rename include guard.
9221         * target/wait.h: Rename include guard.
9222         * target/target.h: Rename include guard.
9223         * target/resume.h: Rename include guard.
9224         * target-float.h: Rename include guard.
9225         * stabsread.h: Add include guard.
9226         * rs6000-tdep.h: Add include guard.
9227         * riscv-fbsd-tdep.h: Add include guard.
9228         * regformats/regdef.h: Rename include guard.
9229         * record.h: Rename include guard.
9230         * python/python.h: Rename include guard.
9231         * python/python-internal.h: Rename include guard.
9232         * python/py-stopevent.h: Rename include guard.
9233         * python/py-ref.h: Rename include guard.
9234         * python/py-record.h: Rename include guard.
9235         * python/py-record-full.h: Rename include guard.
9236         * python/py-record-btrace.h: Rename include guard.
9237         * python/py-instruction.h: Rename include guard.
9238         * python/py-events.h: Rename include guard.
9239         * python/py-event.h: Rename include guard.
9240         * procfs.h: Add include guard.
9241         * proc-utils.h: Add include guard.
9242         * p-lang.h: Add include guard.
9243         * or1k-tdep.h: Rename include guard.
9244         * observable.h: Rename include guard.
9245         * nto-tdep.h: Rename include guard.
9246         * nat/x86-linux.h: Rename include guard.
9247         * nat/x86-linux-dregs.h: Rename include guard.
9248         * nat/x86-gcc-cpuid.h: Add include guard.
9249         * nat/x86-dregs.h: Rename include guard.
9250         * nat/x86-cpuid.h: Rename include guard.
9251         * nat/ppc-linux.h: Rename include guard.
9252         * nat/mips-linux-watch.h: Rename include guard.
9253         * nat/linux-waitpid.h: Rename include guard.
9254         * nat/linux-ptrace.h: Rename include guard.
9255         * nat/linux-procfs.h: Rename include guard.
9256         * nat/linux-osdata.h: Rename include guard.
9257         * nat/linux-nat.h: Rename include guard.
9258         * nat/linux-namespaces.h: Rename include guard.
9259         * nat/linux-btrace.h: Rename include guard.
9260         * nat/glibc_thread_db.h: Rename include guard.
9261         * nat/gdb_thread_db.h: Rename include guard.
9262         * nat/gdb_ptrace.h: Rename include guard.
9263         * nat/fork-inferior.h: Rename include guard.
9264         * nat/amd64-linux-siginfo.h: Rename include guard.
9265         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9266         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9267         * nat/aarch64-linux.h: Rename include guard.
9268         * nat/aarch64-linux-hw-point.h: Rename include guard.
9269         * mn10300-tdep.h: Add include guard.
9270         * mips-linux-tdep.h: Add include guard.
9271         * mi/mi-parse.h: Rename include guard.
9272         * mi/mi-out.h: Rename include guard.
9273         * mi/mi-main.h: Rename include guard.
9274         * mi/mi-interp.h: Rename include guard.
9275         * mi/mi-getopt.h: Rename include guard.
9276         * mi/mi-console.h: Rename include guard.
9277         * mi/mi-common.h: Rename include guard.
9278         * mi/mi-cmds.h: Rename include guard.
9279         * mi/mi-cmd-break.h: Rename include guard.
9280         * m2-lang.h: Add include guard.
9281         * location.h: Rename include guard.
9282         * linux-record.h: Rename include guard.
9283         * linux-nat.h: Add include guard.
9284         * linux-fork.h: Add include guard.
9285         * i386-darwin-tdep.h: Rename include guard.
9286         * hppa-linux-offsets.h: Add include guard.
9287         * guile/guile.h: Rename include guard.
9288         * guile/guile-internal.h: Rename include guard.
9289         * gnu-nat.h: Rename include guard.
9290         * gdb-stabs.h: Rename include guard.
9291         * frv-tdep.h: Add include guard.
9292         * f-lang.h: Add include guard.
9293         * event-loop.h: Add include guard.
9294         * darwin-nat.h: Rename include guard.
9295         * cp-abi.h: Rename include guard.
9296         * config/sparc/nm-sol2.h: Rename include guard.
9297         * config/nm-nto.h: Rename include guard.
9298         * config/nm-linux.h: Add include guard.
9299         * config/i386/nm-i386gnu.h: Rename include guard.
9300         * config/djgpp/nl_types.h: Rename include guard.
9301         * config/djgpp/langinfo.h: Rename include guard.
9302         * compile/gcc-cp-plugin.h: Add include guard.
9303         * compile/gcc-c-plugin.h: Add include guard.
9304         * compile/compile.h: Rename include guard.
9305         * compile/compile-object-run.h: Rename include guard.
9306         * compile/compile-object-load.h: Rename include guard.
9307         * compile/compile-internal.h: Rename include guard.
9308         * compile/compile-cplus.h: Rename include guard.
9309         * compile/compile-c.h: Rename include guard.
9310         * common/xml-utils.h: Rename include guard.
9311         * common/x86-xstate.h: Rename include guard.
9312         * common/version.h: Rename include guard.
9313         * common/vec.h: Rename include guard.
9314         * common/tdesc.h: Rename include guard.
9315         * common/selftest.h: Rename include guard.
9316         * common/scoped_restore.h: Rename include guard.
9317         * common/scoped_mmap.h: Rename include guard.
9318         * common/scoped_fd.h: Rename include guard.
9319         * common/safe-iterator.h: Rename include guard.
9320         * common/run-time-clock.h: Rename include guard.
9321         * common/refcounted-object.h: Rename include guard.
9322         * common/queue.h: Rename include guard.
9323         * common/ptid.h: Rename include guard.
9324         * common/print-utils.h: Rename include guard.
9325         * common/preprocessor.h: Rename include guard.
9326         * common/pathstuff.h: Rename include guard.
9327         * common/observable.h: Rename include guard.
9328         * common/netstuff.h: Rename include guard.
9329         * common/job-control.h: Rename include guard.
9330         * common/host-defs.h: Rename include guard.
9331         * common/gdb_wait.h: Rename include guard.
9332         * common/gdb_vecs.h: Rename include guard.
9333         * common/gdb_unlinker.h: Rename include guard.
9334         * common/gdb_unique_ptr.h: Rename include guard.
9335         * common/gdb_tilde_expand.h: Rename include guard.
9336         * common/gdb_sys_time.h: Rename include guard.
9337         * common/gdb_string_view.h: Rename include guard.
9338         * common/gdb_splay_tree.h: Rename include guard.
9339         * common/gdb_setjmp.h: Rename include guard.
9340         * common/gdb_ref_ptr.h: Rename include guard.
9341         * common/gdb_optional.h: Rename include guard.
9342         * common/gdb_locale.h: Rename include guard.
9343         * common/gdb_assert.h: Rename include guard.
9344         * common/filtered-iterator.h: Rename include guard.
9345         * common/filestuff.h: Rename include guard.
9346         * common/fileio.h: Rename include guard.
9347         * common/environ.h: Rename include guard.
9348         * common/common-utils.h: Rename include guard.
9349         * common/common-types.h: Rename include guard.
9350         * common/common-regcache.h: Rename include guard.
9351         * common/common-inferior.h: Rename include guard.
9352         * common/common-gdbthread.h: Rename include guard.
9353         * common/common-exceptions.h: Rename include guard.
9354         * common/common-defs.h: Rename include guard.
9355         * common/common-debug.h: Rename include guard.
9356         * common/cleanups.h: Rename include guard.
9357         * common/buffer.h: Rename include guard.
9358         * common/btrace-common.h: Rename include guard.
9359         * common/break-common.h: Rename include guard.
9360         * cli/cli-utils.h: Rename include guard.
9361         * cli/cli-style.h: Rename include guard.
9362         * cli/cli-setshow.h: Rename include guard.
9363         * cli/cli-script.h: Rename include guard.
9364         * cli/cli-interp.h: Rename include guard.
9365         * cli/cli-decode.h: Rename include guard.
9366         * cli/cli-cmds.h: Rename include guard.
9367         * charset-list.h: Add include guard.
9368         * buildsym-legacy.h: Rename include guard.
9369         * bfin-tdep.h: Add include guard.
9370         * ax.h: Rename include guard.
9371         * arm-linux-tdep.h: Add include guard.
9372         * arm-fbsd-tdep.h: Add include guard.
9373         * arch/xtensa.h: Rename include guard.
9374         * arch/tic6x.h: Add include guard.
9375         * arch/i386.h: Add include guard.
9376         * arch/arm.h: Rename include guard.
9377         * arch/arm-linux.h: Rename include guard.
9378         * arch/arm-get-next-pcs.h: Rename include guard.
9379         * arch/amd64.h: Add include guard.
9380         * arch/aarch64-insn.h: Rename include guard.
9381         * arch-utils.h: Rename include guard.
9382         * annotate.h: Add include guard.
9383         * amd64-darwin-tdep.h: Rename include guard.
9384         * aarch64-linux-tdep.h: Add include guard.
9385         * aarch64-fbsd-tdep.h: Add include guard.
9386         * aarch32-linux-nat.h: Add include guard.
9387
9388 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9389
9390         * macrotab.c (macro_define_internal): New function that
9391         factorizes macro_define_object_internal and macro_define_function
9392         code.
9393         (macro_define_object_internal): Use macro_define_internal.
9394         (macro_define_function): Likewise.
9395
9396 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9397
9398         * macrocmd.c (extract_identifier): Return
9399         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9400         callers.
9401
9402 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9403
9404         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9405
9406 2019-02-05  Tom Tromey  <tom@tromey.com>
9407
9408         * target.c (target_stack::unpush): Move assertion earlier.
9409
9410 2019-01-30  Tom Tromey  <tom@tromey.com>
9411
9412         PR python/23615:
9413         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9414         (gdbpy_parse_and_eval): Likewise.
9415         * python/python-internal.h (gdbpy_allow_threads): New class.
9416
9417 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9418
9419         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9420         (aarch64_fbsd_fpregmap): Move earlier.
9421         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9422         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9423         instead of individual calls to trad_frame_set_reg_addr.
9424         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9425         earlier.
9426         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9427         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9428         instead of individual calls to trad_frame_set_reg_addr.
9429
9430 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9431
9432         * CONTRIBUTE: Replace contribution list with wiki link.
9433
9434 2019-01-25  Tom Tromey  <tom@tromey.com>
9435
9436         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9437
9438 2019-01-25  Tom Tromey  <tom@tromey.com>
9439
9440         * xtensa-linux-nat.c: Fix common/ includes.
9441         * xml-support.h: Fix common/ includes.
9442         * xml-support.c: Fix common/ includes.
9443         * x86-linux-nat.c: Fix common/ includes.
9444         * windows-nat.c: Fix common/ includes.
9445         * varobj.h: Fix common/ includes.
9446         * varobj.c: Fix common/ includes.
9447         * value.c: Fix common/ includes.
9448         * valops.c: Fix common/ includes.
9449         * utils.c: Fix common/ includes.
9450         * unittests/xml-utils-selftests.c: Fix common/ includes.
9451         * unittests/utils-selftests.c: Fix common/ includes.
9452         * unittests/unpack-selftests.c: Fix common/ includes.
9453         * unittests/tracepoint-selftests.c: Fix common/ includes.
9454         * unittests/style-selftests.c: Fix common/ includes.
9455         * unittests/string_view-selftests.c: Fix common/ includes.
9456         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9457         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9458         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9459         * unittests/rsp-low-selftests.c: Fix common/ includes.
9460         * unittests/parse-connection-spec-selftests.c: Fix common/
9461         includes.
9462         * unittests/optional-selftests.c: Fix common/ includes.
9463         * unittests/offset-type-selftests.c: Fix common/ includes.
9464         * unittests/observable-selftests.c: Fix common/ includes.
9465         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9466         * unittests/memrange-selftests.c: Fix common/ includes.
9467         * unittests/memory-map-selftests.c: Fix common/ includes.
9468         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9469         * unittests/function-view-selftests.c: Fix common/ includes.
9470         * unittests/environ-selftests.c: Fix common/ includes.
9471         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9472         * unittests/common-utils-selftests.c: Fix common/ includes.
9473         * unittests/cli-utils-selftests.c: Fix common/ includes.
9474         * unittests/array-view-selftests.c: Fix common/ includes.
9475         * ui-file.c: Fix common/ includes.
9476         * tui/tui-io.c: Fix common/ includes.
9477         * tracepoint.h: Fix common/ includes.
9478         * tracepoint.c: Fix common/ includes.
9479         * tracefile-tfile.c: Fix common/ includes.
9480         * top.h: Fix common/ includes.
9481         * top.c: Fix common/ includes.
9482         * thread.c: Fix common/ includes.
9483         * target/waitstatus.h: Fix common/ includes.
9484         * target/waitstatus.c: Fix common/ includes.
9485         * target.h: Fix common/ includes.
9486         * target.c: Fix common/ includes.
9487         * target-memory.c: Fix common/ includes.
9488         * target-descriptions.c: Fix common/ includes.
9489         * symtab.h: Fix common/ includes.
9490         * symfile.c: Fix common/ includes.
9491         * stap-probe.c: Fix common/ includes.
9492         * spu-linux-nat.c: Fix common/ includes.
9493         * sparc-nat.c: Fix common/ includes.
9494         * source.c: Fix common/ includes.
9495         * solib.c: Fix common/ includes.
9496         * solib-target.c: Fix common/ includes.
9497         * ser-unix.c: Fix common/ includes.
9498         * ser-tcp.c: Fix common/ includes.
9499         * ser-pipe.c: Fix common/ includes.
9500         * ser-base.c: Fix common/ includes.
9501         * selftest-arch.c: Fix common/ includes.
9502         * s12z-tdep.c: Fix common/ includes.
9503         * rust-exp.y: Fix common/ includes.
9504         * rs6000-aix-tdep.c: Fix common/ includes.
9505         * riscv-tdep.c: Fix common/ includes.
9506         * remote.c: Fix common/ includes.
9507         * remote-notif.h: Fix common/ includes.
9508         * remote-fileio.h: Fix common/ includes.
9509         * remote-fileio.c: Fix common/ includes.
9510         * regcache.h: Fix common/ includes.
9511         * regcache.c: Fix common/ includes.
9512         * record-btrace.c: Fix common/ includes.
9513         * python/python.c: Fix common/ includes.
9514         * python/py-type.c: Fix common/ includes.
9515         * python/py-inferior.c: Fix common/ includes.
9516         * progspace.h: Fix common/ includes.
9517         * producer.c: Fix common/ includes.
9518         * procfs.c: Fix common/ includes.
9519         * proc-api.c: Fix common/ includes.
9520         * printcmd.c: Fix common/ includes.
9521         * ppc-linux-nat.c: Fix common/ includes.
9522         * parser-defs.h: Fix common/ includes.
9523         * osdata.c: Fix common/ includes.
9524         * obsd-nat.c: Fix common/ includes.
9525         * nat/x86-linux.c: Fix common/ includes.
9526         * nat/x86-linux-dregs.c: Fix common/ includes.
9527         * nat/x86-dregs.h: Fix common/ includes.
9528         * nat/x86-dregs.c: Fix common/ includes.
9529         * nat/ppc-linux.c: Fix common/ includes.
9530         * nat/mips-linux-watch.h: Fix common/ includes.
9531         * nat/mips-linux-watch.c: Fix common/ includes.
9532         * nat/linux-waitpid.c: Fix common/ includes.
9533         * nat/linux-ptrace.h: Fix common/ includes.
9534         * nat/linux-ptrace.c: Fix common/ includes.
9535         * nat/linux-procfs.c: Fix common/ includes.
9536         * nat/linux-personality.c: Fix common/ includes.
9537         * nat/linux-osdata.c: Fix common/ includes.
9538         * nat/linux-namespaces.c: Fix common/ includes.
9539         * nat/linux-btrace.h: Fix common/ includes.
9540         * nat/linux-btrace.c: Fix common/ includes.
9541         * nat/fork-inferior.c: Fix common/ includes.
9542         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9543         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9544         * nat/aarch64-linux.c: Fix common/ includes.
9545         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9546         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9547         * namespace.h: Fix common/ includes.
9548         * mips-linux-tdep.c: Fix common/ includes.
9549         * minsyms.c: Fix common/ includes.
9550         * mi/mi-parse.h: Fix common/ includes.
9551         * mi/mi-main.c: Fix common/ includes.
9552         * mi/mi-cmd-env.c: Fix common/ includes.
9553         * memrange.h: Fix common/ includes.
9554         * memattr.c: Fix common/ includes.
9555         * maint.h: Fix common/ includes.
9556         * maint.c: Fix common/ includes.
9557         * main.c: Fix common/ includes.
9558         * machoread.c: Fix common/ includes.
9559         * location.c: Fix common/ includes.
9560         * linux-thread-db.c: Fix common/ includes.
9561         * linux-nat.c: Fix common/ includes.
9562         * linux-fork.c: Fix common/ includes.
9563         * inline-frame.c: Fix common/ includes.
9564         * infrun.c: Fix common/ includes.
9565         * inflow.c: Fix common/ includes.
9566         * inferior.h: Fix common/ includes.
9567         * inferior.c: Fix common/ includes.
9568         * infcmd.c: Fix common/ includes.
9569         * inf-ptrace.c: Fix common/ includes.
9570         * inf-child.c: Fix common/ includes.
9571         * ia64-linux-nat.c: Fix common/ includes.
9572         * i387-tdep.c: Fix common/ includes.
9573         * i386-tdep.c: Fix common/ includes.
9574         * i386-linux-tdep.c: Fix common/ includes.
9575         * i386-linux-nat.c: Fix common/ includes.
9576         * i386-go32-tdep.c: Fix common/ includes.
9577         * i386-fbsd-tdep.c: Fix common/ includes.
9578         * i386-fbsd-nat.c: Fix common/ includes.
9579         * guile/scm-type.c: Fix common/ includes.
9580         * guile/guile.c: Fix common/ includes.
9581         * go32-nat.c: Fix common/ includes.
9582         * gnu-nat.c: Fix common/ includes.
9583         * gdbthread.h: Fix common/ includes.
9584         * gdbarch-selftests.c: Fix common/ includes.
9585         * gdb_usleep.c: Fix common/ includes.
9586         * gdb_select.h: Fix common/ includes.
9587         * gdb_bfd.c: Fix common/ includes.
9588         * gcore.c: Fix common/ includes.
9589         * fork-child.c: Fix common/ includes.
9590         * findvar.c: Fix common/ includes.
9591         * fbsd-nat.c: Fix common/ includes.
9592         * event-top.c: Fix common/ includes.
9593         * event-loop.c: Fix common/ includes.
9594         * dwarf2read.c: Fix common/ includes.
9595         * dwarf2loc.c: Fix common/ includes.
9596         * dwarf2-frame.c: Fix common/ includes.
9597         * dwarf-index-cache.c: Fix common/ includes.
9598         * dtrace-probe.c: Fix common/ includes.
9599         * disasm-selftests.c: Fix common/ includes.
9600         * defs.h: Fix common/ includes.
9601         * csky-tdep.c: Fix common/ includes.
9602         * cp-valprint.c: Fix common/ includes.
9603         * cp-support.h: Fix common/ includes.
9604         * cp-support.c: Fix common/ includes.
9605         * corelow.c: Fix common/ includes.
9606         * completer.h: Fix common/ includes.
9607         * completer.c: Fix common/ includes.
9608         * compile/compile.c: Fix common/ includes.
9609         * compile/compile-loc2c.c: Fix common/ includes.
9610         * compile/compile-cplus-types.c: Fix common/ includes.
9611         * compile/compile-cplus-symbols.c: Fix common/ includes.
9612         * command.h: Fix common/ includes.
9613         * cli/cli-dump.c: Fix common/ includes.
9614         * cli/cli-cmds.c: Fix common/ includes.
9615         * charset.c: Fix common/ includes.
9616         * build-id.c: Fix common/ includes.
9617         * btrace.h: Fix common/ includes.
9618         * btrace.c: Fix common/ includes.
9619         * breakpoint.h: Fix common/ includes.
9620         * breakpoint.c: Fix common/ includes.
9621         * ax.h:
9622         (enum agent_op): Fix common/ includes.
9623         * ax-general.c (struct aop_map): Fix common/ includes.
9624         * ax-gdb.c: Fix common/ includes.
9625         * auxv.c: Fix common/ includes.
9626         * auto-load.c: Fix common/ includes.
9627         * arm-tdep.c: Fix common/ includes.
9628         * arch/riscv.c: Fix common/ includes.
9629         * arch/ppc-linux-common.c: Fix common/ includes.
9630         * arch/i386.c: Fix common/ includes.
9631         * arch/arm.c: Fix common/ includes.
9632         * arch/arm-linux.c: Fix common/ includes.
9633         * arch/arm-get-next-pcs.c: Fix common/ includes.
9634         * arch/amd64.c: Fix common/ includes.
9635         * arch/aarch64.c: Fix common/ includes.
9636         * arch/aarch64-insn.c: Fix common/ includes.
9637         * arch-utils.c: Fix common/ includes.
9638         * amd64-windows-tdep.c: Fix common/ includes.
9639         * amd64-tdep.c: Fix common/ includes.
9640         * amd64-sol2-tdep.c: Fix common/ includes.
9641         * amd64-obsd-tdep.c: Fix common/ includes.
9642         * amd64-nbsd-tdep.c: Fix common/ includes.
9643         * amd64-linux-tdep.c: Fix common/ includes.
9644         * amd64-linux-nat.c: Fix common/ includes.
9645         * amd64-fbsd-tdep.c: Fix common/ includes.
9646         * amd64-fbsd-nat.c: Fix common/ includes.
9647         * amd64-dicos-tdep.c: Fix common/ includes.
9648         * amd64-darwin-tdep.c: Fix common/ includes.
9649         * agent.c: Fix common/ includes.
9650         * ada-lang.h: Fix common/ includes.
9651         * ada-lang.c: Fix common/ includes.
9652         * aarch64-tdep.c: Fix common/ includes.
9653
9654 2019-01-25  Tom Tromey  <tom@tromey.com>
9655
9656         * common/create-version.sh: Use common/version.h.
9657
9658 2019-01-24  Pedro Alves  <palves@redhat.com>
9659
9660         * infrun.c (signal_stop, signal_print, signal_program)
9661         (signal_catch, signal_pass): Now arrays instead of pointers.
9662         (update_signals_program_target, do_target_resume)
9663         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9664         * linux-nat.c (linux_nat_target::pass_signals)
9665         (linux_nat_target::create_inferior, linux_nat_target::attach):
9666         Adjust.
9667         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9668         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9669         * procfs.c (procfs_target::pass_signals): Adjust.
9670         * record-full.c (record_full_target::resume): Adjust.
9671         * remote.c (remote_target::pass_signals)
9672         (remote_target::program_signals): Adjust.
9673         * target-debug.h (target_debug_print_signals): Now takes a
9674         gdb::array_view as parameter.  Adjust.
9675         * target.h (target_ops) <pass_signals, program_signals>: Replace
9676         pointer and length parameters with gdb::array_view.
9677         (target_pass_signals, target_program_signals): Likewise.
9678         * target-delegates.c: Regenerate.
9679
9680 2019-01-24  Pedro Alves  <palves@redhat.com>
9681
9682         * common/forward-scope-exit.h
9683         (forward_scope_exit::forward_scope_exit): Pass arguments to
9684         m_bind_function directly, instead of creating a std::bind and
9685         copying that.
9686
9687 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9688
9689         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9690         for static members.
9691         (pass_in_v_vfp_candidate): Likewise.
9692
9693 2019-01-23  Tom Tromey  <tom@tromey.com>
9694             Pedro Alves  <palves@redhat.com>
9695
9696         * regcache.c (class regcache_invalidator): Remove.
9697         (regcache::raw_write): Use make_scope_exit.
9698
9699 2019-01-23  Tom Tromey  <tom@tromey.com>
9700
9701         * ui-out.h (class ui_out_emit_type): Update comment.
9702
9703 2019-01-23  Tom Tromey  <tom@tromey.com>
9704
9705         * infrun.c (fetch_inferior_event): Update comment.
9706
9707 2019-01-23  Tom Tromey  <tom@tromey.com>
9708             Pedro Alves  <palves@redhat.com>
9709
9710         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9711         parameter.
9712         (fetch_inferior_event): Use SCOPE_EXIT.
9713
9714
9715 2019-01-23  Tom Tromey  <tom@tromey.com>
9716             Pedro Alves  <palves@redhat.com>
9717
9718         * infrun.c (disable_thread_events): Delete.
9719         (stop_all_threads): Use SCOPE_EXIT.
9720
9721 2019-01-23  Tom Tromey  <tom@tromey.com>
9722             Pedro Alves  <palves@redhat.com>
9723
9724         * symfile.c: Include forward-scope-exit.h.
9725         (clear_symtab_users_cleanup): Replace forward declaration with
9726         a FORWARD_SCOPE_EXIT.
9727         (syms_from_objfile_1): Use the forward_scope_exit and
9728         gdb::optional instead of cleanup_function.
9729         (reread_symbols): Use the forward_scope_exit instead of
9730         cleanup_function.
9731         (clear_symtab_users_cleanup): Remove function.
9732
9733 2019-01-23  Tom Tromey  <tom@tromey.com>
9734             Pedro Alves  <palves@redhat.com>
9735
9736         * linux-nat.c: Include scope-exit.h.
9737         (cleanup_target_stop): Remove.
9738         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9739         SCOPE_EXIT.
9740
9741 2019-01-23  Tom Tromey  <tom@tromey.com>
9742             Pedro Alves  <palves@redhat.com>
9743
9744         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9745         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9746
9747 2019-01-23  Tom Tromey  <tom@tromey.com>
9748             Andrew Burgess  <andrew.burgess@embecosm.com>
9749             Pedro Alves  <palves@redhat.com>
9750
9751         * infrun.c (fetch_inferior_event): Use scope_exit.
9752         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9753         * top.c (execute_command): Use scope_exit.
9754         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9755         * utils.c (do_bpstat_clear_actions_cleanup)
9756         (make_bpstat_clear_actions_cleanup): Remove.
9757
9758 2019-01-23  Tom Tromey  <tom@tromey.com>
9759             Pedro Alves  <palves@redhat.com>
9760
9761         * infrun.c: Include "common/scope-exit.h"
9762         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9763         (wait_for_inferior): Use SCOPE_EXIT.
9764         (fetch_inferior_event): Use scope_exit.
9765
9766 2019-01-23  Tom Tromey  <tom@tromey.com>
9767             Pedro Alves  <palves@redhat.com>
9768
9769         * breakpoint.c (create_breakpoint): Remove cleanup.
9770
9771 2019-01-23  Tom Tromey  <tom@tromey.com>
9772             Andrew Burgess  <andrew.burgess@embecosm.com>
9773             Pedro Alves  <palves@redhat.com>
9774
9775 2019-01-23  Pedro Alves  <palves@redhat.com>
9776
9777         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9778
9779 2019-01-23  Pedro Alves  <palves@redhat.com>
9780             Andrew Burgess  <andrew.burgess@embecosm.com>
9781
9782         * gdbthread.h: Include "common/forward-scope-exit.h".
9783         (scoped_finish_thread_state): Redefine custom class in terms of
9784         forward_scope_exit.
9785
9786 2019-01-23  Pedro Alves  <palves@redhat.com>
9787             Andrew Burgess  <andrew.burgess@embecosm.com>
9788
9789         * common/forward-scope-exit.h: New file.
9790
9791 2019-01-23  Pedro Alves  <palves@redhat.com>
9792             Andrew Burgess  <andrew.burgess@embecosm.com>
9793             Tom Tromey  <tom@tromey.com>
9794
9795         * common/scope-exit.h: New file.
9796
9797 2019-01-23  Pedro Alves  <palves@redhat.com>
9798
9799         * common/preprocessor.h (ESC): Rename to ...
9800         (ESC_PARENS): ... this.
9801         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9802         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9803
9804 2019-01-23  Tom Tromey  <tom@tromey.com>
9805
9806         * language.h (class scoped_switch_to_sym_language_if_auto):
9807         Initialize m_lang in both cases.
9808
9809 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9810
9811         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9812         with XCNEW.
9813
9814 2019-01-22  Tom Tromey  <tom@tromey.com>
9815
9816         * corelow.c: Do not include sys/file.h.
9817
9818 2019-01-22  Tom Tromey  <tom@tromey.com>
9819
9820         * tui/tui-wingeneral.h: Include gdb_curses.h.
9821
9822 2019-01-22  Tom Tromey  <tom@tromey.com>
9823
9824         * source-cache.h (class source_cache) <get_source_lines,
9825         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9826
9827 2019-01-22  Tom Tromey  <tom@tromey.com>
9828
9829         * remote-fileio.h (struct remote_target): Declare.
9830
9831 2019-01-22  Tom Tromey  <tom@tromey.com>
9832
9833         * python/py-arch.c: Do not include py-ref.h.
9834         * python/py-bpevent.c: Do not include py-ref.h.
9835         * python/py-cmd.c: Do not include py-ref.h.
9836         * python/py-continueevent.c: Do not include py-ref.h.
9837         * python/py-event.h: Do not include py-ref.h.
9838         * python/py-evtregistry.c: Do not include py-ref.h.
9839         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9840         * python/py-frame.c: Do not include py-ref.h.
9841         * python/py-framefilter.c: Do not include py-ref.h.
9842         * python/py-function.c: Do not include py-ref.h.
9843         * python/py-infevents.c: Do not include py-ref.h.
9844         * python/py-linetable.c: Do not include py-ref.h.
9845         * python/py-objfile.c: Do not include py-ref.h.
9846         * python/py-param.c: Do not include py-ref.h.
9847         * python/py-prettyprint.c: Do not include py-ref.h.
9848         * python/py-progspace.c: Do not include py-ref.h.
9849         * python/py-symbol.c: Do not include py-ref.h.
9850         * python/py-symtab.c: Do not include py-ref.h.
9851         * python/py-type.c: Do not include py-ref.h.
9852         * python/py-unwind.c: Do not include py-ref.h.
9853         * python/py-utils.c: Do not include py-ref.h.
9854         * python/py-value.c: Do not include py-ref.h.
9855         * python/py-varobj.c: Do not include py-ref.h.
9856         * python/py-xmethods.c: Do not include py-ref.h.
9857         * python/python.c: Do not include py-ref.h.
9858         * varobj.c: Do not include py-ref.h.
9859
9860 2019-01-22  Tom Tromey  <tom@tromey.com>
9861
9862         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9863         keyword for bcache.
9864
9865 2019-01-22  Tom Tromey  <tom@tromey.com>
9866
9867         * compile/compile-cplus-types.c: Remove a comment by #include.
9868
9869 2019-01-22  Tom Tromey  <tom@tromey.com>
9870
9871         * compile/gcc-c-plugin.h: Include compile-internal.h.
9872
9873 2019-01-22  Tom Tromey  <tom@tromey.com>
9874
9875         * stabsread.c (EXTERN): Do not define.
9876         (symnum, next_symbol_text_func, processing_gcc_compilation)
9877         (within_function, global_sym_chain, global_stabs)
9878         (previous_stab_code, this_object_header_files)
9879         (n_this_object_header_files)
9880         (n_allocated_this_object_header_files): Define.
9881         * stabsread.h (EXTERN): Never define.  Use "extern".
9882
9883 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9884
9885         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9886         history_value.
9887
9888 2019-01-21  Tom Tromey  <tom@tromey.com>
9889
9890         * ui-out.c: Fix includes.
9891         * tui/tui-source.c: Fix includes.
9892         * target.c: Fix includes.
9893         * remote.c: Fix includes.
9894         * regcache.c: Fix includes.
9895         * python/py-block.c: Fix includes.
9896         * printcmd.c: Fix includes.
9897         * or1k-tdep.c: Fix includes.
9898         * mi/mi-main.c: Fix includes.
9899         * m32r-tdep.c: Fix includes.
9900         * csky-tdep.c: Fix includes.
9901         * compile/compile-cplus-types.c: Fix includes.
9902         * cli/cli-interp.c: Fix includes.
9903
9904 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9905
9906         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9907         for padding.
9908
9909 2019-01-16  Tom Tromey  <tom@tromey.com>
9910
9911         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9912         earlier.
9913         (struct objfile) <msymbols_range>: Move from top level.
9914         <msymbols>: New method.
9915         (class objfile_msymbols): Remove.
9916         * symtab.c (default_collect_symbol_completion_matches_break_on):
9917         Update.
9918         * symmisc.c (dump_msymbols): Update.
9919         * stabsread.c (scan_file_globals): Update.
9920         * objc-lang.c (info_selectors_command, info_classes_command)
9921         (find_methods): Update.
9922         * minsyms.c (find_solib_trampoline_target): Update.
9923         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9924         * coffread.c (coff_symfile_read): Update.
9925         * ada-lang.c (ada_lookup_simple_minsym)
9926         (ada_collect_symbol_completion_matches): Update.
9927
9928 2019-01-16  Tom Tromey  <tom@tromey.com>
9929
9930         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9931         type.  Remove no-argument constructor.
9932         <iterator::operator++>: Simplify.
9933         <begin>: Update.
9934         <end>: Use minimal_symbol_count.
9935
9936 2019-01-16  Tom Tromey  <tom@tromey.com>
9937
9938         * objfiles.h (struct objfile) <psymtabs>: New method.
9939         (class objfile_psymtabs): Remove.
9940         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9941         typedef.
9942         <range>: New method.
9943         (require_partial_symbols): Change return type.
9944         * psymtab.c (require_partial_symbols)
9945         (psym_expand_symtabs_matching): Update.
9946         * mdebugread.c (parse_partial_symbols): Update.
9947         * dbxread.c (dbx_end_psymtab): Update.
9948
9949 2019-01-15  Tom Tromey  <tom@tromey.com>
9950
9951         * symtab.c (lookup_objfile_from_block)
9952         (lookup_symbol_in_objfile_symtabs)
9953         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9954         (find_line_symtab, info_sources_command)
9955         (default_collect_symbol_completion_matches_break_on)
9956         (make_source_files_completion_list): Update.
9957         * symmisc.c (print_objfile_statistics, dump_objfile)
9958         (maintenance_print_symbols, maintenance_info_symtabs)
9959         (maintenance_check_symtabs, maintenance_info_line_tables):
9960         Update.
9961         * source.c (select_source_symtab)
9962         (forget_cached_source_info_for_objfile): Update.
9963         * objfiles.h (class objfile_compunits): Remove.
9964         (struct objfile) <compunits_range>: New typedef.
9965         (compunits): New method.
9966         * objfiles.c (objfile_relocate1): Update.
9967         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9968         * maint.c (count_symtabs_and_blocks): Update.
9969         * linespec.c (iterate_over_all_matching_symtabs): Update.
9970         * cp-support.c (add_symbol_overload_list_qualified): Update.
9971         * coffread.c (coff_symtab_read): Update.
9972         * ada-lang.c (add_nonlocal_symbols)
9973         (ada_collect_symbol_completion_matches)
9974         (ada_add_global_exceptions): Update.
9975
9976 2019-01-15  Tom Tromey  <tom@tromey.com>
9977
9978         * progspace.h (program_space) <objfiles_safe_range>: New
9979         typedef.
9980         <objfiles_safe>: New method.
9981         * objfiles.h (class all_objfiles_safe): Remove.
9982         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9983         * jit.c (jit_inferior_exit_hook): Update.
9984
9985 2019-01-17  Tom Tromey  <tom@tromey.com>
9986
9987         * progspace.h (program_space) <objfiles_range>: New typedef.
9988         <objfiles>: New method.
9989         <objfiles_head>: Rename from objfiles.
9990         (object_files): Update.
9991         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9992         * guile/scm-pretty-print.c
9993         (ppscm_find_pretty_printer_from_objfiles): Update.
9994         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9995         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9996         Update.
9997         * python/py-progspace.c (pspy_get_objfiles): Update.
9998         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9999         Update.
10000         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10001         (objfpy_lookup_objfile_by_build_id): Update.
10002         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10003         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10004         Update.
10005         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10006         (expand_symtab_containing_pc, lookup_objfile_from_block)
10007         (lookup_static_symbol, basic_lookup_transparent_type)
10008         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10009         (find_line_symtab, info_sources_command)
10010         (default_collect_symbol_completion_matches_break_on)
10011         (make_source_files_completion_list, find_main_name): Update.
10012         * symmisc.c (print_symbol_bcache_statistics)
10013         (print_objfile_statistics, maintenance_print_symbols)
10014         (maintenance_print_msymbols, maintenance_print_objfiles)
10015         (maintenance_info_symtabs, maintenance_check_symtabs)
10016         (maintenance_expand_symtabs, maintenance_info_line_tables):
10017         Update.
10018         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10019         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10020         (map_overlay_command, unmap_overlay_command)
10021         (simple_overlay_update, expand_symtabs_matching)
10022         (map_symbol_filenames): Update.
10023         * symfile-debug.c (set_debug_symfile): Update.
10024         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10025         Update.
10026         * source.c (select_source_symtab, forget_cached_source_info):
10027         Update.
10028         * solib.c (solib_read_symbols): Update.
10029         * solib-spu.c (append_ocl_sos): Update.
10030         * psymtab.c (maintenance_print_psymbols)
10031         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10032         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10033         * printcmd.c (info_symbol_command): Update.
10034         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10035         Update.
10036         * objfiles.h (class all_objfiles): Remove.
10037         * objfiles.c (have_partial_symbols, have_full_symbols)
10038         (have_minimal_symbols, qsort_cmp, update_section_map)
10039         (shared_objfile_contains_address_p)
10040         (default_iterate_over_objfiles_in_search_order): Update.
10041         * objc-lang.c (info_selectors_command, info_classes_command)
10042         (find_methods): Update.
10043         * minsyms.c (find_solib_trampoline_target): Update.
10044         * maint.c (maintenance_info_sections)
10045         (maintenance_translate_address, count_symtabs_and_blocks):
10046         Update.
10047         * main.c (captured_main_1): Update.
10048         * linux-thread-db.c (try_thread_db_load_from_pdir)
10049         (has_libpthread): Update.
10050         * linespec.c (iterate_over_all_matching_symtabs)
10051         (search_minsyms_for_name): Update.
10052         * jit.c (jit_find_objf_with_entry_addr): Update.
10053         * hppa-tdep.c (find_unwind_entry)
10054         (hppa_lookup_stub_minimal_symbol): Update.
10055         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10056         Update.
10057         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10058         (elf_gnu_ifunc_resolve_by_got): Update.
10059         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10060         * dwarf-index-write.c (save_gdb_index_command): Update.
10061         * cp-support.c (add_symbol_overload_list_qualified): Update.
10062         * breakpoint.c (create_overlay_event_breakpoint)
10063         (create_longjmp_master_breakpoint)
10064         (create_std_terminate_master_breakpoint)
10065         (create_exception_master_breakpoint): Update.
10066         * blockframe.c (find_pc_partial_function): Update.
10067         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10068         (ada_collect_symbol_completion_matches)
10069         (ada_add_global_exceptions): Update.
10070
10071 2019-01-17  Tom Tromey  <tom@tromey.com>
10072
10073         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10074         declare VEC.
10075         (solib_target_parse_libraries): Change return type.
10076         (library_list_start_segment, library_list_start_section)
10077         (library_list_end_library, library_list_start_library); Update.
10078         (solib_target_free_library_list): Remove.
10079         (solib_target_parse_libraries): Remove cleanup.  Change return
10080         type.
10081         (solib_target_current_sos): Update.
10082
10083 2019-01-17  Tom Tromey  <tromey@bapiya>
10084
10085         * valprint.c: Replace "the the" with "the".
10086         * symtab.c: Replace "the the" with "the".
10087         * solib.c: Replace "the the" with "the".
10088         * solib-dsbt.c: Replace "the the" with "the".
10089         * linespec.c: Replace "the the" with "the".
10090         * dwarf2loc.h: Replace "the the" with "the".
10091         * amd64-windows-tdep.c: Replace "the the" with "the".
10092         * aarch64-tdep.c: Replace "the the" with "the".
10093
10094 2019-01-16  Keith Seitz  <keiths@redhat.com>
10095
10096         PR gdb/23773
10097         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10098         <builder>: Rename to ..
10099         <m_builder>: ... this and make private.
10100         (dwarf2_cu::get_builder): New method.  Change all users of
10101         `builder' to use this method.
10102         (dwarf2_start_symtab): Move to ...
10103         (dwarf2_cu::start_symtab): ... here.  Update all callers
10104         (setup_type_unit_groups): Move to ...
10105         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10106         callers.
10107         (dwarf2_cu::reset_builder): New method.
10108         (process_full_compunit, process_full_type_unit): Use
10109         dwarf2_cu::reset_builder.
10110         (follow_die_offset): Record the ancestor CU if it is different
10111         from the followed DIE's CU.
10112         (follow_die_sig_1): Likewise.
10113
10114 2019-01-15  Tom Tromey  <tom@tromey.com>
10115
10116         * remote.c (class remote_state) <buf>: Now a char_vector.
10117         <buf_size>: Remove.
10118         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10119         parameter.
10120         (remote_target::getpkt_or_notif_sane_1)
10121         (remote_target::getpkt_sane)
10122         (remote_target::getpkt_or_notif_sane): Likewise.
10123         (class remote_target) <putpkt>: New overload.
10124         (remote_target::read_frame): Change type of "buf_p".  Remove
10125         sizeof_p parameter.
10126         (packet_ok): New overload.
10127         (packet_check_result): New overload.
10128         Update all uses.
10129
10130 2019-01-14  Tom Tromey  <tom@tromey.com>
10131
10132         * remote-notif.c (handle_notification, remote_notif_ack)
10133         (remote_notif_parse): Make "buf" const.
10134         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10135         const.
10136         (remote_notif_parse, remote_notif_ack, handle_notification):
10137         Likewise.
10138         * remote.c (remote_notif_stop_parse): Make "buf" const.
10139         (remote_target::remote_parse_stop_reply): Make "buf" const.
10140         (remote_notif_stop_ack): Make "buf" const.
10141
10142 2019-01-14  Tom Tromey  <tom@tromey.com>
10143
10144         * remote.c (remote_console_output): Make parameter const.
10145
10146 2019-01-14  Tom Tromey  <tom@tromey.com>
10147
10148         * target-debug.h (target_debug_print_signals): Constify.
10149         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10150         * procfs.c (procfs_target::pass_signals): Update.
10151         * linux-nat.c (linux_nat_target::pass_signals): Update.
10152         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10153         * target-delegates.c: Rebuild.
10154         * remote.c (remote_target::program_signals): Update.
10155         (remote_target::pass_signals): Update.
10156         * target.c (target_pass_signals): Constify argument.
10157         (target_program_signals): Likewise.
10158         * target.h (struct target_ops) <pass_signals, program_signals>:
10159         Constify argument.
10160         (target_pass_signals, target_program_signals): Constify argument.
10161
10162 2019-01-14  Tom Tromey  <tom@tromey.com>
10163
10164         PR tui/28819:
10165         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10166
10167 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10168
10169         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10170         field.
10171         * rs6000-tdep.c: Include reggroups.h.
10172         (IS_V_ALIAS_PSEUDOREG): Define.
10173         (rs6000_register_name): Return names for the "vX" aliases.
10174         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10175         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10176         aliases.  Call default_register_reggroup_p for all other
10177         pseudo-registers.
10178         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10179         New functions.
10180         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10181         Handle "vX" aliases.
10182         (v_alias_pseudo_register_collect): New function.
10183         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10184         (rs6000_gdbarch_init): Initialize "vX" aliases as
10185         pseudo-registers.  Restore registration of
10186         rs6000_pseudo_register_reggroup_p with
10187         set_tdesc_pseudo_register_reggroup_p.
10188
10189 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10190
10191         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10192         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10193         set_gdbarch_num_pseudo_regs.
10194
10195 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10196
10197         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10198         Remove arg prefixname, add do_set and do_show.
10199         Add member functions set_list and show_list.
10200         * cli/cli-style.c (class cli_style_option): Update accordingly.
10201         (style_set_list): Move to file scope.
10202         (style_show_list): Likewise.
10203         (set_style): Call help_list.
10204         (show_style): Call cmd_show_list.
10205         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10206         Update to use the new macro.
10207
10208 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10209
10210         * ada-lang.c (_initialize_ada_language): Expand the help text
10211         for the "catch exception" command.
10212
10213 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10214
10215         * symtab.c (matching_obj_sections): Initialize obj,
10216         declare it closer to its usage.
10217
10218 2019-01-10  Tom Tromey  <tom@tromey.com>
10219
10220         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10221         (basic_inf_threads_range): Remove.
10222         (inf_threads_range, inf_non_exited_threads_range)
10223         (safe_inf_threads_range): Use next_adapter.
10224
10225 2019-01-10  Keith Seitz  <keiths@redhat.com>
10226
10227         PR gdb/23712
10228         PR symtab/23010
10229         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10230         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10231
10232 2019-01-10  Keith Seitz  <keiths@redhat.com>
10233
10234         PR gdb/23712
10235         PR symtab/23010
10236         * dictionary.c (pending_to_vector): Remove.
10237         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10238         Remove _1 suffix, replacing functions of the same name.  Update
10239         all callers.
10240         (dict_create_hashed, dict_create_hashed_expandable)
10241         (dict_create_linear, dict_create_linear_expandable, dict_free)
10242         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10243         Make functions static.
10244
10245 2019-01-10  Keith Seitz  <keiths@redhat.com>
10246
10247         PR gdb/23712
10248         PR symtab/23010
10249         * dictionary.h (struct dictionary): Replace declaration with
10250         multidictionary.
10251         (dict_create_hashed, dict_create_hashed_expandable)
10252         (dict_create_linear, dict_create_linear_expandable)
10253         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10254         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10255         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10256         taking multidictionary argument.
10257         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10258         * block.h (struct block) <dict>: Change to multidictionary
10259         and rename `multidict'.
10260         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10261         symmisc.c: Update all dictionary references to multidictionary.
10262
10263 2019-01-10  Keith Seitz  <keiths@redhat.com>
10264
10265         PR gdb/23712
10266         PR symtab/23010
10267         * dictionary.c: Include unordered_map.
10268         (pending_to_vector): New function.
10269         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10270         Rewrite the non-"_1" functions to take vector instead
10271         of linked list.
10272         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10273         "new" _1 versions of the same name.
10274         (multidictionary): Define.
10275         (std::hash<enum language): New definition.
10276         (collate_pending_symbols_by_language, mdict_create_hashed)
10277         (mdict_create_hashed_expandable, mdict_create_linear)
10278         (mdict_create_linear_expandable, mdict_free)
10279         (find_language_dictionary, create_new_language_dictionary)
10280         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10281         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10282         (mdict_size, mdict_empty): New functions.
10283         * dictionary.h (mdict_iterator): Define.
10284
10285 2019-01-10  Pedro Alves  <palves@redhat.com>
10286
10287         * breakpoint.c (read_uploaded_action)
10288         (create_tracepoint_from_upload): Adjust to use
10289         gdb::unique_xmalloc_ptr.
10290         * ctf.c (ctf_write_uploaded_tp):
10291         (SET_ARRAY_FIELD): Use emplace_back.
10292         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10293         * tracefile-tfile.c (tfile_write_uploaded_tp):
10294         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10295         gdb::unique_xmalloc_ptr.
10296         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10297         at_string, cond_string, cmd_strings>: Replace char pointers
10298         with gdb::unique_xmalloc_ptr.
10299
10300 2019-01-10  Pedro Alves  <palves@redhat.com>
10301
10302         * solib-target.c (library_list_start_library): Don't xstrdup name.
10303
10304 2019-01-10  Pedro Alves  <palves@redhat.com>
10305
10306         * mdebugread.c (parse_partial_symbols): Use
10307         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10308
10309 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10310
10311         * linux-fork.c (scoped_switch_fork_info)
10312         <~scoped_switch_fork_info>: Fix incorrect variable name.
10313
10314 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10315
10316         * linux-fork.c (scoped_switch_fork_info)
10317         <scoped_switch_fork_info>: Make explicit.
10318         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10319
10320 2019-01-10  Tom Tromey  <tom@tromey.com>
10321
10322         * objfiles.h (objfile::reset_psymtabs): Update.
10323         * objfiles.c (objfile::objfile): Update.
10324         * psymtab.h (psymtab_storage::obstack): Update.
10325         (psymtab_storage::m_obstack): Use gdb::optional.
10326         (class psymtab_storage): Update comment.  Remove objfile
10327         parameter.
10328         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10329
10330 2019-01-10  Tom Tromey  <tom@tromey.com>
10331
10332         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10333         <free_psymtabs>: Now private.
10334         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10335         (allocate_psymtab): Use new method.
10336
10337 2019-01-10  Tom Tromey  <tom@tromey.com>
10338
10339         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10340         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10341         * mdebugread.c (parse_partial_symbols): Use
10342         allocate_dependencies.
10343         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10344         allocate_dependencies.
10345         (process_psymtab_comp_unit_reader)
10346         (build_type_psymtab_dependencies): Likewise.
10347         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10348
10349 2019-01-10  Tom Tromey  <tom@tromey.com>
10350
10351         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10352         PSYMBOL_SET_LANGUAGE.
10353         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10354
10355 2019-01-10  Tom Tromey  <tom@tromey.com>
10356
10357         * psymtab.h (psymtab_storage::obstack): New method.
10358         <m_obstack>: Rename from obstack; now private.
10359         * psymtab.c (psymtab_storage): Update.
10360         * dwarf2read.c (create_addrmap_from_index)
10361         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10362         Update.
10363
10364 2019-01-10  Tom Tromey  <tom@tromey.com>
10365
10366         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10367         * objfiles.h (objfile::reset_psymtabs): New method.
10368
10369 2019-01-10  Tom Tromey  <tom@tromey.com>
10370
10371         * symmisc.c (print_symbol_bcache_statistics): Update.
10372         (print_objfile_statistics): Update.
10373         * symfile.c (reread_symbols): Update.
10374         * psymtab.h (class psymtab_storage): New.
10375         * psymtab.c (psymtab_storage): New constructor.
10376         (~psymtab_storage): New destructor.
10377         (require_partial_symbols): Update.
10378         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10379         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10380         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10381         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10382         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10383         (start_psymtab_common, end_psymtab_common)
10384         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10385         (allocate_psymtab): Update.
10386         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10387         Update.
10388         (dump_psymtab_addrmap, maintenance_print_psymbols)
10389         (maintenance_check_psymtabs): Update.
10390         (class objfile_psymtabs): Move to objfiles.h.
10391         * psympriv.h (discard_psymtab): Now inline.
10392         (psymtab_discarder::psymtab_discarder): Update.
10393         (psymtab_discarder::~psymtab_discarder): Update.
10394         (ALL_OBJFILE_PSYMTABS): Rewrite.
10395         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10396         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10397         Remove fields.
10398         <partial_symtabs>: New field.
10399         (class objfile_psymtabs): Move from psymtab.h.  Update.
10400         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10401         psymbol_cache.
10402         (objfile::~objfile): Don't destroy psymbol_cache.
10403         * mdebugread.c (parse_partial_symbols): Update.
10404         * dwarf2read.c (create_addrmap_from_index)
10405         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10406         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10407         (add_partial_subprogram, dwarf2_ranges_read): Update.
10408         * dwarf-index-write.c (write_address_map)
10409         (write_one_signatured_type, recursively_write_psymbols)
10410         (class debug_names, class debug_names, write_psymtabs_to_index):
10411         Update.
10412
10413 2019-01-10  Tom Tromey  <tom@tromey.com>
10414
10415         * symtab.h (SYMBOL_SET_NAMES): Update.
10416         (symbol_set_names): Update.
10417         (MSYMBOL_SET_NAMES): Update.
10418         * symtab.c (symbol_set_names): Change argument to be an
10419         objfile_per_bfd_storage.
10420         * psymtab.c (add_psymbol_to_bcache): Update.
10421         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10422
10423 2019-01-10  Tom Tromey  <tom@tromey.com>
10424
10425         * symtab.c (create_demangled_names_hash): Change argument to be an
10426         objfile_per_bfd_storage.
10427         (symbol_set_names): Update.
10428
10429 2019-01-10  Tom Tromey  <tom@tromey.com>
10430
10431         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10432         init_psymbol_list.
10433         * psymtab.c (init_psymbol_list): Do nothing if already called.
10434         * psympriv.h (init_psymbol_list): Add comment.
10435         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10436         init_psymbol_list.
10437         * dbxread.c (dbx_symfile_read): Unconditionally call
10438         init_psymbol_list.
10439
10440 2019-01-10  Tom Tromey  <tom@tromey.com>
10441
10442         * xcoffread.c (scan_xcoff_symtab): Update.
10443         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10444         "where".
10445         * mdebugread.c (parse_partial_symbols)
10446         (handle_psymbol_enumerators): Update.
10447         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10448         * dbxread.c (read_dbx_symtab): Update.
10449         * psympriv.h (psymbol_placement): New enum.
10450         (add_psymbol_to_list): Update.
10451
10452 2019-01-10  Tom Tromey  <tom@tromey.com>
10453
10454         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10455         static_psymbols parameters.
10456         (scan_xcoff_symtab): Update.
10457         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10458         static_psymbols parameters.
10459         * psympriv.h (start_psymtab_common): Update.
10460         * mdebugread.c (parse_partial_symbols): Update.
10461         * dwarf2read.c (create_partial_symtab): Update.
10462         * dbxread.c (read_dbx_symtab): Update.
10463         (start_psymtab): Remove global_psymbols and static_psymbols
10464         parameters.
10465
10466 2019-01-10  Tom Tromey  <tom@tromey.com>
10467
10468         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10469         * psymtab.c (allocate_psymtab): Add comment.
10470         * psympriv.h (allocate_psymtab): Add comment.
10471         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10472         initializations.
10473         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10474
10475 2019-01-10  Tom Tromey  <tom@tromey.com>
10476
10477         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10478         Don't declare.
10479         * mipsread.c: Include mdebugread.h.
10480         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10481         Declare.
10482         * elfread.c: Include mdebugread.h.
10483
10484 2019-01-09  Tom Tromey  <tom@tromey.com>
10485
10486         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10487         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10488         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10489         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10490         (psym_lookup_symbol, psym_find_last_source_symtab)
10491         (psym_forget_cached_source_info, psym_print_stats)
10492         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10493         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10494         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10495         (psym_find_compunit_symtab_by_address)
10496         (maintenance_print_psymbols, maintenance_info_psymtabs)
10497         (maintenance_check_psymtabs): Use ranged for.
10498         * psymtab.h (class objfile_psymtabs): New.
10499         (require_partial_symbols): Return objfile_psymtabs.
10500         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10501
10502 2019-01-09  Tom Tromey  <tom@tromey.com>
10503
10504         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10505         (find_pc_mapped_section, list_overlays_command)
10506         (map_overlay_command, unmap_overlay_command)
10507         (simple_overlay_update): Use all_objfiles.
10508         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10509         * printcmd.c (info_symbol_command): Use all_objfiles.
10510         * objfiles.h (ALL_OBJSECTIONS): Remove.
10511         * maint.c (maintenance_translate_address): Use all_objfiles.
10512         * gcore.c (gcore_create_callback): Use all_objfiles.
10513         (objfile_find_memory_regions): Likewise.
10514
10515 2019-01-09  Tom Tromey  <tom@tromey.com>
10516
10517         * symtab.c (find_line_symtab, info_sources_command)
10518         (make_source_files_completion_list): Use objfile_compunits.
10519         * source.c (select_source_symtab): Use objfile_compunits.
10520         * objfiles.h (struct objfile): Update comment.
10521         (ALL_OBJFILES): Remove.
10522         (ALL_FILETABS): Remove.
10523         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10524         objfile_compunits.
10525
10526 2019-01-09  Tom Tromey  <tom@tromey.com>
10527
10528         * symmisc.c (print_objfile_statistics, dump_objfile)
10529         (maintenance_print_symbols): Use compunit_filetabs.
10530         * source.c (forget_cached_source_info_for_objfile): Use
10531         compunit_filetabs.
10532         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10533         (ALL_FILETABS): Use compunit_filetabs.
10534         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10535         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10536
10537 2019-01-09  Tom Tromey  <tom@tromey.com>
10538
10539         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10540         (compunit_filetabs): New.
10541         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10542         compunit_filetabs.
10543         (info_sources_command, make_source_files_completion_list): Remove
10544         declaration.
10545         * symmisc.c (print_objfile_statistics, dump_objfile)
10546         (maintenance_print_symbols): Remove declaration.
10547         (maintenance_info_symtabs): Use compunit_filetabs.
10548         (maintenance_info_line_tables): Likewise.
10549         * source.c (select_source_symtab): Change local variable name.
10550         (forget_cached_source_info_for_objfile): Remove declaration.
10551         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10552         * objfiles.c (objfile_relocate1): Remove declaration.
10553         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10554         declaration.
10555         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10556         * coffread.c (coff_symtab_read): Remove declaration.
10557         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10558         compunit_filetabs.
10559
10560 2019-01-09  Tom Tromey  <tom@tromey.com>
10561
10562         * symtab.c (lookup_objfile_from_block)
10563         (find_pc_sect_compunit_symtab, search_symbols)
10564         (default_collect_symbol_completion_matches_break_on): Use
10565         objfile_compunits.
10566         * objfiles.h (ALL_COMPUNITS): Remove.
10567         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10568         * cp-support.c (add_symbol_overload_list_qualified): Use
10569         objfile_compunits.
10570         * ada-lang.c (ada_collect_symbol_completion_matches)
10571         (ada_add_global_exceptions): Use objfile_compunits.
10572
10573 2019-01-09  Tom Tromey  <tom@tromey.com>
10574
10575         * source.c (select_source_symtab)
10576         (forget_cached_source_info_for_objfile): Remove declaration.
10577         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10578         declaration.
10579         * maint.c (count_symtabs_and_blocks): Remove declaration.
10580         * cp-support.c (add_symbol_overload_list_qualified): Remove
10581         declaration.
10582         * coffread.c (coff_symtab_read): Remove declaration.
10583         * symtab.c (lookup_symbol_in_objfile_symtabs)
10584         (basic_lookup_transparent_type_1): Use objfile_compunits.
10585         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10586         (info_sources_command, search_symbols)
10587         (default_collect_symbol_completion_matches_break_on)
10588         (make_source_files_completion_list): Remove declaration.
10589         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10590         (ada_collect_symbol_completion_matches)
10591         (ada_add_global_exceptions): Remove declaration.
10592         * linespec.c (iterate_over_all_matching_symtabs): Use
10593         objfile_compunits.
10594         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10595         (class objfile_compunits): New.
10596         (ALL_COMPUNITS): Use objfile_compunits.
10597         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10598         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10599         objfile_compunits.
10600         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10601
10602 2019-01-09  Tom Tromey  <tom@tromey.com>
10603
10604         * symtab.c (search_symbols)
10605         (default_collect_symbol_completion_matches_break_on): Use
10606         objfile_msymbols.
10607         * ada-lang.c (ada_lookup_simple_minsym)
10608         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10609         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10610         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10611         objfile_msymbols.
10612         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10613         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10614         * objc-lang.c (find_methods): Use objfile_msymbols.
10615         (info_selectors_command, info_classes_command): Likewise.
10616         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10617         * objfiles.h (class objfile_msymbols): New.
10618         (ALL_OBJFILE_MSYMBOLS): Remove.
10619         (ALL_MSYMBOLS): Remove.
10620
10621 2019-01-09  Tom Tromey  <tom@tromey.com>
10622
10623         * common/next-iterator.h (next_adapter): Add Iterator template
10624         parameter.
10625         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10626         (class all_objfiles_safe): New.
10627         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10628         * objfiles.c (put_objfile_before): Update comment.
10629         (add_separate_debug_objfile): Likewise.
10630         (free_all_objfiles): Use all_objfiles_safe.
10631         (objfile_purge_solibs): Likewise.
10632
10633 2019-01-09  Tom Tromey  <tom@tromey.com>
10634
10635         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10636         (expand_symtab_containing_pc, lookup_static_symbol)
10637         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10638         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10639         all_objfiles.
10640         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10641         * breakpoint.c (create_overlay_event_breakpoint)
10642         (create_longjmp_master_breakpoint)
10643         (create_std_terminate_master_breakpoint)
10644         (create_exception_master_breakpoint): Use all_objfiles.
10645         * linux-thread-db.c (try_thread_db_load_from_pdir)
10646         (has_libpthread): Use all_objfiles.
10647         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10648         * linespec.c (iterate_over_all_matching_symtabs)
10649         (search_minsyms_for_name): Use all_objfiles.
10650         * maint.c (maintenance_info_sections): Use all_objfiles.
10651         * main.c (captured_main_1): Use all_objfiles.
10652         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10653         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10654         * guile/scm-pretty-print.c
10655         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10656         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10657         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10658         (maintenance_print_msymbols): Use all_objfiles.
10659         * source.c (select_source_symtab): Use all_objfiles.
10660         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10661         * symfile.c (remove_symbol_file_command)
10662         (expand_symtabs_matching, map_symbol_filenames): Use
10663         all_objfiles.
10664         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10665         all_objfiles.
10666         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10667         * objc-lang.c (find_methods): Use all_objfiles.
10668         * objfiles.c (have_partial_symbols, have_full_symbols)
10669         (have_minimal_symbols, qsort_cmp)
10670         (default_iterate_over_objfiles_in_search_order): Use
10671         all_objfiles.
10672         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10673         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10674         (maintenance_check_psymtabs): Use all_objfiles.
10675         (ALL_PSYMTABS): Remove.
10676         * compile/compile-object-run.c (do_module_cleanup): Use
10677         all_objfiles.
10678         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10679         * cp-support.c (add_symbol_overload_list_qualified): Use
10680         all_objfiles.
10681         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10682         Use all_objfiles.
10683         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10684         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10685         all_objfiles.
10686         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10687         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10688         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10689         Uses all_objfiles.
10690         * solib.c (solib_read_symbols): Use all_objfiles
10691
10692 2019-01-09  Tom Tromey  <tom@tromey.com>
10693
10694         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10695         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10696         all_objfiles.
10697         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10698         * symmisc.c (print_symbol_bcache_statistics)
10699         (print_objfile_statistics, maintenance_print_objfiles)
10700         (maintenance_info_symtabs, maintenance_check_symtabs)
10701         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10702         all_objfiles.
10703         * source.c (forget_cached_source_info): Use all_objfiles.
10704         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10705         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10706         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10707         * objfiles.c (update_section_map): Use all_objfiles.
10708         (shared_objfile_contains_address_p): Likewise.
10709         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10710         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10711
10712 2019-01-09  Tom Tromey  <tom@tromey.com>
10713
10714         * common/next-iterator.h: New file.
10715         * objfiles.h (class all_objfiles): New.
10716         (struct objfile_iterator): New.
10717
10718 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10719
10720         * NEWS: Move the description of the changed "frame", "select-frame",
10721          and "info frame" commands to the Changed commands section.
10722
10723 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10724
10725         * gdbtypes.c (check_stub_method_group): Remove handling of old
10726         mangling schemes.
10727         * linespec.c (find_methods): Likewise.
10728         * stabsread.c (read_member_functions): Likewise.
10729         * valops.c (search_struct_method): Likewise.
10730         (value_struct_elt_for_reference): Likewise.
10731         * NEWS: Mention this change.
10732
10733 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10734
10735         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10736         print_source_lines.
10737         * source.c (print_source_lines_base): Update line number check.
10738         (print_source_lines): New function.
10739         (source_lines_range::source_lines_range): New function.
10740         * source.h (class source_lines_range): New class.
10741         (print_source_lines): New declaration.
10742
10743 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10744
10745         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10746
10747 2019-01-08  Tom Tromey  <tom@tromey.com>
10748             Simon Marchi  <simon.marchi@ericsson.com>
10749
10750         PR gdb/24060
10751         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10752         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10753         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10754         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10755         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10756         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10757
10758 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10759
10760         * source.c (select_source_symtab): Move header comment to
10761         declaration in source.h.
10762         (forget_cached_source_info_for_objfile): Likewise.
10763         (forget_cached_source_info): Likewise.
10764         (identify_source_line): Likewise.
10765         * source.h (identify_source_line): Move declaration from symtab.h
10766         and add comment from source.c
10767         (print_source_lines): Likewise.
10768         (forget_cached_source_info_for_objfile): Likewise.
10769         (forget_cached_source_info): Likewise.
10770         (select_source_symtab): Likewise.
10771         (enum print_source_lines_flag): Move definition from symtab.h.
10772         * symtab.h (identify_source_line): Move declaration to source.h.
10773         (print_source_lines): Likewise.
10774         (forget_cached_source_info_for_objfile): Likewise.
10775         (forget_cached_source_info): Likewise.
10776         (select_source_symtab): Likewise.
10777         (enum print_source_lines_flag): Move definition to source.h.
10778         * tui/tui-hooks.c: Add 'source.h' include.
10779
10780 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10781
10782         * source.c (print_source_lines_base): Handle requests to print
10783         reverse line number sequences, and guard against empty lines
10784         string.
10785
10786 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10787
10788         * source.c (print_source_lines_base): Fix skip of '\r' if next
10789         character is '\n'.
10790
10791 2019-01-06  Tom Tromey  <tom@tromey.com>
10792
10793         * c-exp.y (struct c_parse_state) <macro_original_text,
10794         expansion_obstack>: New member.
10795         (macro_original_text, expansion_obstack): Remove globals.
10796         (scan_macro_expansion, scanning_macro_expansion)
10797         (finished_macro_expansion): Update.
10798         (scan_macro_cleanup): Remove.
10799         (yylex, c_parse): Update.
10800
10801 2019-01-06  Tom Tromey  <tom@tromey.com>
10802
10803         * c-exp.y (struct c_parse_state) <strings>: New member.
10804         (operator_stoken): Update.
10805
10806 2019-01-06  Tom Tromey  <tom@tromey.com>
10807
10808         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10809         (union type_stack_elt) <typelist_val>: Now a pointer to
10810         std::vector.
10811         (type_stack_cleanup): Don't declare.
10812         (push_typelist): Update.
10813         * parse.c (pop_typelist): Return a std::vector.
10814         (push_typelist): Take a std::vector.
10815         (follow_types): Update.  Do not free args.
10816         (type_stack_cleanup): Remove.
10817         * c-exp.y (struct c_parse_state): New.
10818         (cpstate): New global.
10819         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10820         (nonempty_typelist): Update.
10821         (func_mod): Create a new vector.
10822         (c_parse): Create a c_parse_state.
10823         (check_parameter_typelist): Do not delete params.
10824         (function_method): Update.  Do not delete type_list.
10825
10826 2019-01-06  Tom Tromey  <tom@tromey.com>
10827
10828         PR gdb/28155:
10829         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10830         check_typedef.
10831         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10832         (print_return_value): Likewise.
10833
10834 2019-01-05  Tom Tromey  <tom@tromey.com>
10835
10836         * contrib/cleanup_check.py: Remove.
10837         * contrib/gcc-with-excheck: Remove.
10838         * contrib/exsummary.py: Remove.
10839         * contrib/excheck.py: Remove.
10840
10841 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10842
10843         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10844         NULL. Initialize tpprev to NULL instead of assigning it
10845         to NULL on the next statement.
10846         * windows-nat.c (windows_delete_thread): Remove check for
10847         main_thread_id before printing thread exit notifications.
10848         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10849         Remove thread ID check against main_thread_id.
10850         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10851         windows_delete_thread.
10852         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10853
10854 2019-01-04  Tom Tromey  <tom@tromey.com>
10855
10856         * compile/compile.c (_initialize_compile): Use upper case for
10857         metasyntactic variables.
10858         * symmisc.c (_initialize_symmisc): Use upper case for
10859         metasyntactic variables.
10860         * psymtab.c (_initialize_psymtab): Use upper case for
10861         metasyntactic variables.
10862         * demangle.c (demangle_command): Use upper case for metasyntactic
10863         variables.
10864         (_initialize_demangler): Likewise.
10865         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10866         variables.
10867
10868 2019-01-03  Tom Tromey  <tom@tromey.com>
10869
10870         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10871
10872 2019-01-03  Tom Tromey  <tom@tromey.com>
10873
10874         * python/py-symtab.c (salpy_str): Update.
10875         (struct salpy_sal_object) <symtab>: Now a PyObject.
10876         (salpy_dealloc): Update.
10877         (del_objfile_sal): Use gdbpy_ref.
10878
10879 2019-01-03  Tom Tromey  <tom@tromey.com>
10880
10881         * python/py-type.c (convert_field): Use new_reference.  Return
10882         gdbpy_ref.
10883         (make_fielditem): Return gdbpy_ref.
10884         (typy_fields): Update.
10885         (typy_getitem): Update.
10886         (field_name): Return gdbpy_ref.  Use new_reference.
10887         (typy_iterator_iternext): Update.
10888
10889 2019-01-03  Tom Tromey  <tom@tromey.com>
10890
10891         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10892
10893 2019-01-03  Tom Tromey  <tom@tromey.com>
10894
10895         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10896         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10897         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10898         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10899         (pspy_set_type_printers): Likewise.
10900         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10901         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10902         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10903         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10904         (objfpy_set_type_printers): Likewise.
10905
10906 2019-01-03  Tom Tromey  <tom@tromey.com>
10907
10908         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10909         (gdbpy_print_stack): Use gdbpy_err_fetch.
10910         * python/python-internal.h (class gdbpy_err_fetch): New class.
10911         (class gdbpy_enter) <m_error_type, m_error_value,
10912         m_error_traceback>: Remove.
10913         <m_error>: New member.
10914         (gdbpy_exception_to_string): Don't declare.
10915         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10916         * python/py-value.c (convert_value_from_python): Use
10917         gdbpy_err_fetch.
10918         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10919         gdbpy_exception_to_string.
10920         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10921         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10922         gdbpy_err_fetch.
10923
10924 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10925
10926         * linux-nat.c (delete_lwp_cleanup): Delete.
10927         (struct lwp_deleter): New struct.
10928         (lwp_info_up): New typedef.
10929         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10930         lwp_info_up.
10931
10932 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10933
10934         * linux-fork.c (class scoped_switch_fork_info): New class.
10935         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10936
10937 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10938
10939         * valops.c (find_overload_match): Remove use of null_cleanup, and
10940         calls to do_cleanups.
10941
10942 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10943
10944         * compile/compile-cplus-types.c
10945         (compile_cplus_instance::decl_name): Handle changes to
10946         cp_func_name.
10947         * cp-support.c (cp_func_name): Update header comment, update
10948         return type.
10949         * cp-support.h (cp_func_name): Update return type in declaration.
10950         * valops.c (find_overload_match): Move temp_func local to top
10951         level of function and change its type.  Use temp_func to hold and
10952         delete temporary string obtained from cp_func_name.
10953
10954 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10955
10956         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10957         gdb::char_vector, remove cleanup, and update uses of `msg`.
10958
10959 2019-01-03  Jim Wilson  <jimw@sifive.com>
10960
10961         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10962
10963 2019-01-02  Tom Tromey  <tom@tromey.com>
10964
10965         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10966         (tdesc_parse_xml): Remove cleanups.
10967         * target-descriptions.h (make_cleanup_free_target_description):
10968         Don't declare.
10969         (target_desc_deleter): New struct.
10970         (target_desc_up): New typedef.
10971         * target-descriptions.c (target_desc_deleter::operator()): Rename
10972         from free_target_description.
10973         (make_cleanup_free_target_description): Remove.
10974
10975 2019-01-02  Tom Tromey  <tom@tromey.com>
10976
10977         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10978         constructor, destructor.
10979         (linespec_parser): Remove typedef.
10980         (~linespec_parser): Rename from linespec_parser_delete.
10981         (linespec_lex_to_end, linespec_complete_label)
10982         (linespec_complete): Update.
10983         (decode_line_full): Remove cleanups.
10984         (decode_line_1): Update.
10985
10986 2019-01-02  Tom Tromey  <tom@tromey.com>
10987
10988         * python/python-internal.h (inferior_to_inferior_object): Change
10989         return type.
10990         * python/py-exitedevent.c (create_exited_event_object): Update.
10991         * python/py-inferior.c (inferior_to_inferior_object): Return
10992         gdbpy_ref.
10993         (python_new_inferior, python_inferior_deleted)
10994         (thread_to_thread_object, delete_thread_object)
10995         (build_inferior_list, gdbpy_selected_inferior): Update.
10996         * python/py-infthread.c (create_thread_object): Update.  Also fail
10997         if inferior_to_inferior_object fails.
10998
10999 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11000
11001         * inferior.h (class inferior) <displaced_step_state>: New field.
11002         * infrun.h (struct displaced_step_state): Move here from
11003         infrun.c.  Initialize fields, add constructor.
11004         <inf>: Remove field.
11005         <reset>: New method.
11006         * infrun.c (struct displaced_step_inferior_state): Move to
11007         infrun.h.
11008         (displaced_step_inferior_states): Remove.
11009         (get_displaced_stepping_state): Adust.
11010         (displaced_step_in_progress_any_inferior): Adjust.
11011         (displaced_step_in_progress_thread): Adjust.
11012         (displaced_step_in_progress): Adjust.
11013         (add_displaced_stepping_state): Remove.
11014         (get_displaced_step_closure_by_addr): Adjust.
11015         (remove_displaced_stepping_state): Remove.
11016         (infrun_inferior_exit): Call displaced_step_state.reset.
11017         (use_displaced_stepping): Don't check for NULL.
11018         (displaced_step_prepare_throw): Call
11019         get_displaced_stepping_state.
11020         (displaced_step_fixup): Don't check for NULL.
11021         (prepare_for_detach): Don't check for NULL.
11022
11023 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11024
11025         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11026          in case of call that did not complete.
11027
11028 2019-01-02  Andrey Utkin  <autkin@undo.io>
11029
11030         * symfile.c (find_separate_debug_file): Fix search of debug files for
11031         remote debuggee.
11032
11033 2019-01-02  Tom Tromey  <tom@tromey.com>
11034
11035         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11036         indentation.
11037         * python/py-frame.c (frapy_older): Remove cast.
11038         (frapy_newer): Likewise.
11039         * python/py-breakpoint.c (local_setattro): Remove cast.
11040         * python/py-arch.c (archpy_name): Remove local variable.
11041         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11042
11043 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11044
11045         * unittests/basic_string_view/element_access/char/empty.cc:
11046         Fix year range in copyright header.
11047
11048 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11049
11050         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11051         Delete.
11052         <operator==>: Update with for removed field.
11053         <hash>: Likewise.
11054         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11055         <isa_features>: ...this.
11056         <abi_features>: New field.
11057         (riscv_isa_flen): Update comment.
11058         (riscv_abi_xlen): New declaration.
11059         (riscv_abi_flen): New declaration.
11060         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11061         isa_features.
11062         (riscv_abi_xlen): New function.
11063         (riscv_isa_flen): Update to get answer from isa_features.
11064         (riscv_abi_flen): New function.
11065         (riscv_has_fp_abi): Update to get answer from abi_features.
11066         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11067         xlen and flen.
11068         (riscv_call_info) <xlen, flen>: Update comment.
11069         (riscv_call_arg_struct): Remove invalid assertions
11070         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11071         is removed.
11072         (riscv_gdbarch_init): Gather isa features and abi features
11073         separately, ensure both match on the gdbarch when reusing an old
11074         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11075         a target with 64-bit float hardware.
11076
11077 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11078
11079         * source.c (search_command_helper): Stop reverse search
11080         when line 1 has been searched.
11081
11082 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11083
11084         * record-full.c (record_full_base_target::close): Rewrite
11085         record_full_core_buf_list free logic.
11086
11087 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11088
11089         * break-catch-syscall.c (print_one_catch_syscall): xfree
11090         the last text.
11091
11092 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11093
11094         * top.c (print_gdb_version): Update Copyright year in version
11095         message.
11096
11097 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11098
11099         Update copyright year range in all GDB files.
11100
11101 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11102
11103         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11104
11105 For older changes see ChangeLog-2018.
11106 \f
11107 Local Variables:
11108 mode: change-log
11109 left-margin: 8
11110 fill-column: 74
11111 version-control: never
11112 coding: utf-8
11113 End:
11114