gdb/ChangeLog

   1 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
   4         an alias of 'show'.
   5
   6 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
   7
   8         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
   9         ada_is_fixed_point_type.  Update all callers.
  10         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
  11         all callers.
  12         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
  13         Update all callers.
  14         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
  15         print_fixed_point_type.  Update all callers.
  16         * ada-valprint.c (ada_value_print_num): Replace call to
  17         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
  18
  19 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
  20
  21         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
  22         processors.
  23         (cpu_supports_bts): Add CV_AMD case.
  24
  25 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
  26             Simon Marchi  <simon.marchi@efficios.com>
  27
  28         * infrun.c (stop_all_threads): Collect multiple wait events at
  29         each pass.
  30
  31 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
  32
  33         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
  34         type::code instead.
  35
  36 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
  37
  38         * gdbtypes.h (struct type) <code, set_code>: New methods.
  39         (TYPE_CODE): Use type::code.  Change all call sites used to set
  40         the code to use type::set_code instead.
  41
  42 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  43             Tom de Vries  <tdevries@suse.de>
  44             Pedro Alves  <palves@redhat.com>
  45
  46         PR threads/25478
  47         * infrun.c (stop_all_threads): Do NOT ignore
  48         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
  49         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
  50         received.
  51         (handle_no_resumed): Remove code handling a live inferior with no
  52         threads.
  53         * remote.c (has_single_non_exited_thread): New.
  54         (remote_target::update_thread_list): Do not delete a thread if is
  55         the last thread of the process.
  56         * thread.c (thread_select): Call delete_exited_threads instead of
  57         prune_threads.
  58
  59 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  60
  61         * infrun.c (stop_all_threads): Enable/disable thread events of all
  62         targets.  Move a debug message denoting the end of the function
  63         into the SCOPED_EXIT block.
  64
  65 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  66
  67         * process-stratum-target.h: Include <set>.
  68         (all_non_exited_process_targets, switch_to_target_no_thread): New
  69         function declarations.
  70         * process-stratum-target.c (all_non_exited_process_targets)
  71         (switch_to_target_no_thread): New function implementations.
  72
  73 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  74
  75         * infrun.c (handle_inferior_event): Extract out a piece of code
  76         into...
  77         (mark_non_executing_threads): ...this new function.
  78
  79 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  80
  81         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
  82         use.
  83
  84 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  85
  86         * regcache.c (regcache_read_pc_protected): New function
  87         implementation that returns 0 if the PC cannot read via
  88         'regcache_read_pc'.
  89         * infrun.c (proceed): Call 'regcache_read_pc_protected'
  90         instead of 'regcache_read_pc'.
  91         (keep_going_pass_signal): Ditto.
  92
  93 2020-05-13  Tom Tromey  <tromey@adacore.com>
  94
  95         * ada-lang.c (align_value): Remove.
  96         (ada_template_to_fixed_record_type_1): Use align_up.
  97
  98 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  99
 100         * async-event.c: Update the copyright year.
 101         * async-event.h: Update the copyright year.
 102
 103 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
 104
 105         * objfiles.h (is_addr_in_objfile,
 106         shared_objfile_contains_address_p): Return bool.
 107         * objfile.c (is_addr_in_objfile,
 108         shared_objfile_contains_address_p): Return bool.
 109
 110 2020-05-11  Tom Tromey  <tromey@adacore.com>
 111
 112         * cli/cli-cmds.c (info_command): Restore.
 113         (_initialize_cli_cmds): Use add_prefix_command for "info".
 114         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
 115
 116 2020-05-11  Tom Tromey  <tromey@adacore.com>
 117
 118         * ada-lang.c (ada_value_primitive_field): Now public.
 119         * ada-lang.h (ada_value_primitive_field): Declare.
 120         * ada-valprint.c (print_field_values): Use
 121         ada_value_primitive_field for wrapper fields.
 122
 123 2020-05-11  Tom de Vries  <tdevries@suse.de>
 124
 125         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
 126         MODULE_DOMAIN.
 127
 128 2020-05-11  Tom de Vries  <tdevries@suse.de>
 129
 130         PR symtab/25941
 131         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
 132         with length 0, if not gdb-produced.
 133         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
 134
 135 2020-05-09  Tom de Vries  <tdevries@suse.de>
 136
 137         PR gdb/25955
 138         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
 139         calculation.
 140
 141 2020-05-09  Tom Tromey  <tom@tromey.com>
 142
 143         * top.c (server_command): Now bool.
 144         * top.h (server_command): Now bool.
 145
 146 2020-05-08  Tom Tromey  <tromey@adacore.com>
 147
 148         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
 149         already being processed.
 150
 151 2020-05-08  Tom Tromey  <tom@tromey.com>
 152
 153         * printcmd.c (struct display) <next>: Remove.
 154         <display>: New constructor.
 155         <exp_string>: Now a std::string.
 156         <enabled_p>: Now a bool.
 157         (display_number): Move definition earlier.
 158         (displays): Rename from display_chain.  Now a std::vector.
 159         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
 160         (display_command): Update.
 161         (do_one_display, disable_display)
 162         (enable_disable_display_command, do_enable_disable_display):
 163         Update.
 164         (free_display): Remove.
 165         (clear_displays): Rewrite.
 166         (delete_display): Update.
 167         (map_display_numbers): Use function_view.  Remove "data"
 168         parameter.  Update.
 169         (do_delete_display): Remove.
 170         (undisplay_command): Update.
 171         (do_one_display, do_displays, disable_display)
 172         (info_display_command): Update.
 173         (do_enable_disable_display): Remove.
 174         (enable_disable_display_command)
 175         (clear_dangling_display_expressions): Update.
 176
 177 2020-05-08  Tom Tromey  <tom@tromey.com>
 178
 179         * symtab.c (set_symbol_cache_size)
 180         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
 181         (maintenance_print_symbol_cache_statistics): Update.
 182         * symmisc.c (print_symbol_bcache_statistics)
 183         (print_objfile_statistics, maintenance_print_objfiles)
 184         (maintenance_info_symtabs, maintenance_check_symtabs)
 185         (maintenance_expand_symtabs, maintenance_info_line_tables):
 186         Update.
 187         * symfile-debug.c (set_debug_symfile): Update.
 188         * source.c (forget_cached_source_info): Update.
 189         * python/python.c (gdbpy_progspaces): Update.
 190         * psymtab.c (maintenance_info_psymtabs): Update.
 191         * probe.c (parse_probes): Update.
 192         * linespec.c (iterate_over_all_matching_symtabs)
 193         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
 194         * guile/scm-progspace.c (gdbscm_progspaces): Update.
 195         * exec.c (exec_target::close): Update.
 196         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
 197         * breakpoint.c (print_one_breakpoint_location)
 198         (create_longjmp_master_breakpoint)
 199         (create_std_terminate_master_breakpoint): Update.
 200         * progspace.c (program_spaces): Now a std::vector.
 201         (maybe_new_address_space): Update.
 202         (add_program_space): Remove.
 203         (program_space::program_space): Update.
 204         (remove_program_space): Update.
 205         (number_of_program_spaces): Remove.
 206         (print_program_space, update_address_spaces): Update.
 207         * progspace.h (program_spaces): Change type.
 208         (ALL_PSPACES): Remove.
 209         (number_of_program_spaces): Don't declare.
 210         (struct program_space) <next>: Remove.
 211
 212 2020-05-08  Tom Tromey  <tom@tromey.com>
 213
 214         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
 215         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
 216         (enable_break): Update.
 217         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
 218         (frv_fdpic_find_canonical_descriptor): Update.
 219         (frv_fetch_objfile_link_map): Update.
 220         * progspace.c (program_space::free_all_objfiles): Update.
 221         (program_space::solibs): New method.
 222         * progspace.h (struct program_space) <solibs>: New method.
 223         * solist.h (master_so_list): Don't declare.
 224         (ALL_SO_LIBS): Remove.
 225         * solib.h (so_list_head): Remove.
 226         (update_solib_list): Update comment.
 227         * solib.c (master_so_list): Remove.
 228         (solib_used, update_solib_list, solib_add)
 229         (info_sharedlibrary_command, clear_solib)
 230         (reload_shared_libraries_1, remove_user_added_objfile): Update.
 231
 232 2020-05-08  Tom Tromey  <tom@tromey.com>
 233
 234         * extension.c (extension_languages): Now a std::array.
 235         (ALL_EXTENSION_LANGUAGES): Remove.
 236         (get_ext_lang_defn, get_ext_lang_of_file)
 237         (eval_ext_lang_from_control_command): Update.
 238         (finish_ext_lang_initialization)
 239         (auto_load_ext_lang_scripts_for_objfile)
 240         (ext_lang_type_printers::ext_lang_type_printers)
 241         (apply_ext_lang_type_printers)
 242         (ext_lang_type_printers::~ext_lang_type_printers)
 243         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
 244         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
 245         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
 246         (get_matching_xmethod_workers, ext_lang_colorize)
 247         (ext_lang_before_prompt): Update.
 248         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
 249
 250 2020-05-08  Tom Tromey  <tom@tromey.com>
 251
 252         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
 253         overload.
 254         <swap_string, m_string>: Remove.
 255         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
 256         Update.
 257         * stabsread.c (define_symbol, read_type): Update.
 258         * linespec.c (find_linespec_symbols): Update.
 259         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
 260         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
 261         * dbxread.c (read_dbx_symtab): Update.
 262         * cp-support.h (cp_canonicalize_string_full)
 263         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
 264         Return unique_xmalloc_ptr.
 265         * cp-support.c (inspect_type): Update.
 266         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
 267         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
 268         Likewise.
 269         * c-typeprint.c (print_name_maybe_canonical): Update.
 270         * break-catch-throw.c (check_status_exception_catchpoint):
 271         Update.
 272
 273 2020-05-08  Tom de Vries  <tdevries@suse.de>
 274
 275         * infrun.c (follow_fork): Copy current_line and current_symtab to
 276         child thread.
 277
 278 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 279
 280         * async-event.c (struct async_signal_handler, struct
 281         async_event_handler): Reformat, remove typedef.
 282
 283 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 284
 285         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
 286         access thistype->main_type->dyn_prop_list directly.
 287
 288 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 289
 290         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
 291         (remove_dyn_prop): Remove.  Update all users to use
 292         type::remove_dyn_prop.
 293         * gdbtypes.c (remove_dyn_prop): Rename to...
 294         (type::remove_dyn_prop): ... this.
 295
 296 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
 297
 298         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
 299         (add_dyn_prop): Remove.  Update all users to use
 300         type::add_dyn_prop.
 301         * gdbtypes.c (add_dyn_prop): Rename to...
 302         (type::add_dyn_prop): ... this.
 303
 304 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 305
 306         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
 307         (get_dyn_prop): Remove.  Update all users to use
 308         type::dyn_prop.
 309         * gdbtypes.c (get_dyn_prop): Rename to...
 310         (type::dyn_prop): ... this.
 311
 312 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
 313
 314         * gdbtypes.h (struct main_type) <flag_static>: Remove.
 315
 316 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
 317
 318         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
 319         instruction, skip it if it's there.
 320
 321 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
 322
 323         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
 324
 325 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
 326
 327         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
 328         * gdbtypes.c (recursive_dump_type): Remove use of
 329         TYPE_INCOMPLETE.
 330
 331 2020-05-03  Tom Tromey  <tom@tromey.com>
 332
 333         * breakpoint.c (catch_command, tcatch_command): Remove.
 334         (_initialize_breakpoint): Use add_basic_prefix_cmd,
 335         add_show_prefix_cmd.
 336         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
 337         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
 338         Remove.
 339         (add_internal_problem_command): Use add_basic_prefix_cmd,
 340         add_show_prefix_cmd.
 341         * mips-tdep.c (set_mipsfpu_command): Remove.
 342         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
 343         * dwarf2/index-cache.c (set_index_cache_command): Remove.
 344         (_initialize_index_cache): Use add_basic_prefix_cmd.
 345         * memattr.c (dummy_cmd): Remove.
 346         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
 347         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
 348         (_initialize_tui_win): Use add_basic_prefix_cmd,
 349         add_show_prefix_cmd.
 350         * cli/cli-logging.c (set_logging_command): Remove.
 351         (_initialize_cli_logging): Use add_basic_prefix_cmd,
 352         add_show_prefix_cmd.
 353         (show_logging_command): Remove.
 354         * target.c (target_command): Remove.
 355         (add_target): Use add_basic_prefix_cmd.
 356
 357 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
 358
 359         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
 360
 361 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 362
 363         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
 364         info_command.
 365
 366 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
 367
 368         * nbsd-nat.c (nbsd_enable_proc_events)
 369         (nbsd_nat_target::post_startup_inferior): Add.
 370         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
 371         (nbsd_nat_target::update_thread_list): Rewrite.
 372         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
 373         "PTRACE_LWP_CREATE".
 374         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
 375
 376 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 377
 378         * stack.c (_initialize_stack): Remove duplicated creation
 379         of "frame" command and "f" alias.
 380
 381 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
 382
 383         PR gdb/18706
 384         * gdbtypes.c (check_typedef): Calculate size of array of
 385         stubbed type.
 386
 387 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
 388
 389         PR gdb/15559
 390         * i386-tdep.c (i386_push_dummy_call): Call
 391         i386_thiscall_push_dummy_call.
 392         (i386_thiscall_push_dummy_call): New function.
 393         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
 394         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
 395         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
 396
 397 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 398
 399         * gdbarch.sh (do_read): Add shellcheck disable directive for
 400         warning SC2162.
 401
 402 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 403
 404         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
 405         "referenced but not assigned" warning.
 406
 407 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 408
 409         * gdbarch.sh: Remove code that sets fallbackdefault.
 410
 411 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 412
 413         * gdbarch.sh: Use shell operators && and || instead of
 414         -a and -o.
 415
 416 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 417
 418         * gdbarch.sh: Use $(...) instead of `...`.
 419
 420 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 421
 422         * gdbarch.sh: Use double quotes around variables.
 423
 424 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 425
 426         * gdbarch.sh: Use %s with printf, instead of variables in the
 427         format string.
 428
 429 2020-04-29  Tom Tromey  <tromey@adacore.com>
 430
 431         PR ada/25875:
 432         * dwarf2/read.c (update_enumeration_type_from_children): Compute
 433         type fields here.
 434         (read_enumeration_type): Call
 435         update_enumeration_type_from_children later.  Update comments.
 436         (process_enumeration_scope): Don't create type fields.
 437
 438 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
 439
 440         * nbsd-tdep.c: Include "xml-syscall.h".
 441         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
 442
 443 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
 444
 445         * nbsd-nat.c: Include "sys/wait.h".
 446         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
 447         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
 448         (nbsd_nat_target::remove_exec_catchpoint)
 449         (nbsd_nat_target::set_syscall_catchpoint): Add.
 450         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
 451         (nbsd_nat_target::insert_exec_catchpoint)
 452         (nbsd_nat_target::remove_exec_catchpoint)
 453         (nbsd_nat_target::set_syscall_catchpoint): Add.
 454         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
 455         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
 456         `nbsd_get_syscall_number'.
 457
 458 2020-04-29  Tom Tromey  <tom@tromey.com>
 459
 460         * stack.c (print_block_frame_labels): Remove.
 461
 462 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
 463
 464         PR gdb/17320
 465         * ada-valprint.c (val_print_packed_array_elements): Move array
 466         end bracket to new line.
 467         (ada_val_print_string): Remove extra spaces before first array
 468         element.
 469         * c-valprint.c (c_value_print_array): Likewise.
 470         * m2-valprint.c (m2_print_array_contents): Likewise.
 471         (m2_value_print_inner): Likewise.
 472         * p-valprint.c (pascal_value_print_inner): Likewise.
 473         * valprint.c (generic_val_print_array): Likewise.
 474         (value_print_array_elements): Move first array element and array
 475         end bracket to new line.
 476
 477 2020-04-29  Tom de Vries  <tdevries@suse.de>
 478
 479         PR symtab/25889
 480         * linespec.c (find_method): Fix ix calculation.
 481
 482 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
 483
 484         * syscalls/update-netbsd.sh: New file.
 485         * syscalls/netbsd.xml: Regenerate.
 486         * data-directory/Makefile.in: Register `netbsd.xml' in
 487         `SYSCALLS_FILES'.
 488
 489 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
 490
 491         * syscalls/update-freebsd.sh: Add double quotes.
 492
 493 2020-04-28  Tom Tromey  <tom@tromey.com>
 494
 495         * NEWS: Update.
 496         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
 497         (cmdpy_init): Allow class_tui.
 498
 499 2020-04-28 Mark Williams <mark@myosotissp.com>
 500
 501         PR gdb/24480
 502         * dwarf2read.c: Add missing assingments to list_in_scope when
 503         start_symtab was already called.
 504
 505 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
 506
 507         PR gdb/25881
 508         * dwarf2/read.c (offset_map_type): Use
 509         gdb:hash_enum<sect_offset> as hash function.
 510
 511 2020-04-28  Tom de Vries  <tdevries@suse.de>
 512
 513         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
 514         with DW_AT_signature.
 515
 516 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
 517
 518         * configure.ac: Remove check for fs_base/gs_base in
 519         user_regs_struct.
 520         * configure: Re-generate.
 521         * config.in: Re-generate.
 522         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
 523         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
 524         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
 525
 526 2020-04-27  Luis Machado  <luis.machado@linaro.org>
 527
 528         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
 529         problematic inline frame unwinding situation.
 530         * frame.c (frame_id_computed_p): New function.
 531         * frame.h (frame_id_computed_p): New prototype.
 532
 533 2020-04-26  Tom Tromey  <tom@tromey.com>
 534
 535         * command.h (enum command_class) <class_pseudo>: Remove.
 536
 537 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 538
 539         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
 540         and whitespace.
 541
 542 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
 543
 544        * inf-ptrace.c (inf_ptrace_target::wait): Remove
 545        `PT_GET_PROCESS_STATE' block.
 546
 547 2020-04-24  Tom Tromey  <tom@tromey.com>
 548
 549         * symtab.h (symbol_get_demangled_name): Don't declare.
 550         * symtab.c (symbol_get_demangled_name): Remove.
 551         (general_symbol_info::natural_name)
 552         (general_symbol_info::demangled_name): Update.
 553
 554 2020-04-24  Tom Tromey  <tom@tromey.com>
 555
 556         PR rust/25025:
 557         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
 558
 559 2020-04-24  Tom Tromey  <tom@tromey.com>
 560
 561         PR symtab/12707:
 562         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
 563         exists.
 564         (new_symbol): Likewise.
 565         * compile/compile-object-load.c (get_out_value_type): Use
 566         symbol_matches_search_name.
 567
 568 2020-04-24  Tom Tromey  <tom@tromey.com>
 569
 570         * dwarf2/read.c (add_partial_symbol): Do not call
 571         compute_and_set_names.
 572
 573 2020-04-24  Tom Tromey  <tom@tromey.com>
 574
 575         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
 576         overload.
 577
 578 2020-04-24  Tom Tromey  <tom@tromey.com>
 579
 580         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
 581         (add_psymbol_to_list): New overload.  Make old overload call new
 582         one.
 583         * psympriv.h (add_psymbol_to_list): New overload.
 584
 585 2020-04-24  Tom Tromey  <tom@tromey.com>
 586
 587         * dwarf2/read.c (partial_die_info::read) <case
 588         DW_AT_linkage_name>: Use value_as_string.
 589         (dwarf2_string_attr): Use value_as_string.
 590         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
 591         method.
 592         * dwarf2/attribute.c (attribute::value_as_string): New method.
 593
 594 2020-04-24  Tom Tromey  <tom@tromey.com>
 595
 596         * symtab.c (general_symbol_info::natural_name)
 597         (general_symbol_info::demangled_name): Check for language_rust.
 598
 599 2020-04-24  Tom Tromey  <tom@tromey.com>
 600
 601         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
 602         (dwarf2_physname): ... from here.
 603         (partial_die_info::read): Add Rust "{" hack.
 604
 605 2020-04-24  Tom Tromey  <tom@tromey.com>
 606
 607         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
 608         method.
 609         (symbol_set_demangled_name): Don't declare.
 610         * symtab.c (general_symbol_info::set_demangled_name): Rename from
 611         symbol_set_demangled_name.
 612         (general_symbol_info::set_language)
 613         (general_symbol_info::compute_and_set_names): Update.
 614         * minsyms.c (minimal_symbol_reader::install): Update.
 615         * dwarf2/read.c (new_symbol): Update.
 616
 617 2020-04-24  Tom Tromey  <tromey@adacore.com>
 618
 619         PR python/23662:
 620         * python/py-type.c (convert_field): Handle
 621         FIELD_LOC_KIND_DWARF_BLOCK.
 622         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
 623         (typy_get_dynamic): Nw function.
 624         (type_object_getset): Add "dynamic".
 625         * NEWS: Add entry.
 626
 627 2020-04-24  Tom Tromey  <tromey@adacore.com>
 628
 629         * ada-typeprint.c (print_choices, print_variant_part)
 630         (print_record_field_types_dynamic): New functions.
 631         (print_record_field_types): Use print_record_field_types_dynamic.
 632
 633 2020-04-24  Tom Tromey  <tromey@adacore.com>
 634
 635         * dwarf2/read.c (handle_data_member_location): New overload.
 636         (dwarf2_add_field): Use it.
 637         (decode_locdesc): Add "computed" parameter.  Update comment.
 638         * gdbtypes.c (is_dynamic_type_internal): Also look for
 639         FIELD_LOC_KIND_DWARF_BLOCK.
 640         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
 641         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
 642         virtual base classes.
 643         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
 644         FIELD_LOC_KIND_DWARF_BLOCK.
 645
 646 2020-04-24  Tom Tromey  <tromey@adacore.com>
 647
 648         * dwarf2/read.c (read_structure_type): Handle dynamic length.
 649         * gdbtypes.c (is_dynamic_type_internal): Check
 650         TYPE_HAS_DYNAMIC_LENGTH.
 651         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
 652         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
 653         New macros.
 654         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
 655         constant.
 656
 657 2020-04-24  Tom Tromey  <tromey@adacore.com>
 658
 659         * dwarf2/read.c (struct variant_field): Rewrite.
 660         (struct variant_part_builder): New.
 661         (struct nextfield): Remove "variant" field.  Add "offset".
 662         (struct field_info): Add "current_variant_part" and
 663         "variant_parts".
 664         (alloc_discriminant_info): Remove.
 665         (alloc_rust_variant): New function.
 666         (quirk_rust_enum): Update.
 667         (dwarf2_add_field): Set "offset" member.  Don't handle
 668         DW_TAG_variant_part.
 669         (offset_map_type): New typedef.
 670         (convert_variant_range, create_one_variant)
 671         (create_one_variant_part, create_variant_parts)
 672         (add_variant_property): New functions.
 673         (dwarf2_attach_fields_to_type): Call add_variant_property.
 674         (read_structure_type): Don't handle DW_TAG_variant_part.
 675         (handle_variant_part, handle_variant): New functions.
 676         (handle_struct_member_die): Use them.
 677         (process_structure_scope): Don't handle variant parts.
 678         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
 679         (struct discriminant_info): Remove.
 680         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
 681         (struct main_type) <flag_discriminated_union>: Remove.
 682         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
 683         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
 684         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
 685         Update.
 686         * valops.c (value_union_variant): Remove.
 687         * value.h (value_union_variant): Don't declare.
 688
 689 2020-04-24  Tom Tromey  <tromey@adacore.com>
 690
 691         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
 692         (ada_value_primitive_packed_val): Update.
 693         * ada-valprint.c (ada_value_print_1): Update.
 694         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
 695         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
 696         just an address.  Use evaluate_for_locexpr_baton.
 697         (dwarf2_evaluate_property): Update.
 698         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
 699         array_view.
 700         * findvar.c (default_read_var_value): Update.
 701         * gdbtypes.c (compute_variant_fields_inner)
 702         (resolve_dynamic_type_internal): Update.
 703         (resolve_dynamic_type): Change type of valaddr parameter.
 704         * gdbtypes.h (resolve_dynamic_type): Update.
 705         * valarith.c (value_subscripted_rvalue): Update.
 706         * value.c (value_from_contents_and_address): Update.
 707
 708 2020-04-24  Tom Tromey  <tromey@adacore.com>
 709
 710         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
 711         "push_initial_value" parameter.
 712         (dwarf2_evaluate_property): Likewise.
 713         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
 714
 715 2020-04-24  Tom Tromey  <tromey@adacore.com>
 716
 717         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
 718         (variant::matches, compute_variant_fields_recurse)
 719         (compute_variant_fields_inner, compute_variant_fields): New
 720         functions.
 721         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
 722         Use resolved_type after type is made.
 723         (operator==): Add new cases.
 724         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
 725         (struct discriminant_range, struct variant, struct variant_part):
 726         New.
 727         (union dynamic_prop_data) <variant_parts, original_type>: New
 728         members.
 729         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
 730         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
 731         constants.
 732         * value.c (unpack_bits_as_long): Now public.
 733         * value.h (unpack_bits_as_long): Declare.
 734
 735 2020-04-24  Tom Tromey  <tromey@adacore.com>
 736
 737         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
 738         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
 739
 740 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
 741
 742         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
 743
 744 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
 745
 746         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
 747         (remove_fork_catchpoint, post_startup_inferior)
 748         (post_attach): Move...
 749         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
 750         (remove_fork_catchpoint, post_startup_inferior)
 751         (post_attach): ...here.
 752         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
 753         (remove_fork_catchpoint, post_startup_inferior)
 754         (post_attach): Move...
 755         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
 756         (remove_fork_catchpoint, post_startup_inferior)
 757         (post_attach): ...here.
 758
 759 2020-04-24  Tom Tromey  <tromey@adacore.com>
 760
 761         * nat/windows-nat.h (struct windows_thread_info)
 762         <pc_adjusted>: New member.
 763         * windows-nat.c (windows_fetch_one_register): Check
 764         pc_adjusted.
 765         (windows_nat_target::get_windows_debug_event)
 766         (windows_nat_target::wait): Set pc_adjusted.
 767
 768 2020-04-24  Tom de Vries  <tdevries@suse.de>
 769
 770         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
 771         Run gdb-add-index inside temp dir.
 772
 773 2020-04-23  Tom Tromey  <tromey@adacore.com>
 774
 775         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
 776         in loop.
 777
 778 2020-04-23  Luis Machado  <luis.machado@linaro.org>
 779
 780         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
 781         get_frame_register instead of gdbarch_unwind_pc.
 782
 783 2020-04-23  Tom de Vries  <tdevries@suse.de>
 784
 785         * symtab.c (lookup_global_symbol): Prefer def over decl.
 786
 787 2020-04-23  Tom de Vries  <tdevries@suse.de>
 788
 789         PR symtab/25807
 790         * block.c (best_symbol, better_symbol): Promote to external.
 791         * block.h (best_symbol, better_symbol): Declare.
 792         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
 793         decl.
 794
 795 2020-04-23  Tom Tromey  <tromey@adacore.com>
 796
 797         PR ada/25837:
 798         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
 799         "const char *", not a "const std::string &".
 800         <name_and_matcher::operator==>: Update.
 801         * unittests/lookup_name_info-selftests.c: Change type of
 802         "result".
 803
 804 2020-04-23  Tom Tromey  <tom@tromey.com>
 805
 806         * inferior.h (iterate_over_inferiors): Don't declare.
 807         * inferior.c (iterate_over_inferiors): Remove.
 808         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
 809         Remove.
 810         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
 811         use iterate_over_inferiors.
 812         (darwin_resume_inferior_it)
 813         (struct resume_inferior_threads_param)
 814         (darwin_resume_inferior_threads_it): Remove.
 815         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
 816
 817 2020-04-23  Tom de Vries  <tdevries@suse.de>
 818
 819         * blockframe.c (find_pc_partial_function): Use
 820         find_pc_sect_compunit_symtab rather than
 821         objfile->sf->qf->find_pc_sect_compunit_symtab.
 822
 823 2020-04-22  Tom de Vries  <tdevries@suse.de>
 824
 825         PR symtab/25764
 826         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
 827         in psymtabs.
 828
 829 2020-04-22  Tom de Vries  <tdevries@suse.de>
 830
 831         PR symtab/25801
 832         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
 833         symtabs.
 834
 835 2020-04-22  Tom de Vries  <tdevries@suse.de>
 836
 837         PR symtab/25700
 838         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
 839         CU if already created.
 840
 841 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 842
 843         * infrun.c (displaced_step_fixup): Switch to the event_thread
 844         before calling displaced_step_restore, not after.
 845
 846 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 847
 848         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
 849         its inferior is not recorded by us.
 850         (record_btrace_target_open): Replace call to
 851         all_non_exited_threads () with call to current_inferior
 852         ()->non_exited_threads ().
 853         (record_btrace_target::stop_recording): Likewise.
 854         (record_btrace_target::close): Likewise.
 855         (record_btrace_target::wait): Likewise.
 856         (record_btrace_target::record_stop_replaying): Likewise.
 857
 858 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 859
 860         * btrace.c (btrace_enable): Throw an error on double enables and
 861         when enabling recording fails.
 862         (btrace_disable): Throw an error if the thread is not recorded.
 863
 864 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 865
 866         * record-btrace.c (record_btrace_target::fetch_registers): Forward
 867         request if we do not have a thread_info.
 868
 869 2020-04-21  Tom de Vries  <tdevries@suse.de>
 870
 871         PR gdb/25471
 872         * thread.c
 873         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
 874         exception in get_frame_id.
 875
 876 2020-04-20  Tom Tromey  <tromey@adacore.com>
 877
 878         * python/python.c (struct gdbpy_event): Mark move constructor as
 879         noexcept.
 880         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
 881         constructor as noexcept.
 882         * completer.h (struct completion_result): Mark move constructor as
 883         noexcept.
 884         * completer.c (completion_result::completion_result): Use
 885         initialization style.  Don't call reset_match_list.
 886
 887 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
 888
 889         * MAINTAINERS (Write After Approval): Add myself.
 890
 891 2020-04-18  Tom Tromey  <tom@tromey.com>
 892
 893         * windows-tdep.c (init_w32_command_list)
 894         (w32_prefix_command_valid): Restore.
 895         (_initialize_windows_tdep): Call init_w32_command_list.
 896
 897 2020-04-18  Tom Tromey  <tom@tromey.com>
 898
 899         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
 900         * value.c (value_fn_field): Update.
 901         * valops.c (find_function_in_inferior)
 902         (value_allocate_space_in_inferior): Update.
 903         * tui/tui-winsource.c (tui_update_source_windows_with_line):
 904         Update.
 905         * tui/tui-source.c (tui_source_window::set_contents): Update.
 906         * symtab.c (lookup_global_or_static_symbol)
 907         (find_function_start_sal_1, skip_prologue_sal)
 908         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
 909         * symmisc.c (dump_msymbols, dump_symtab_1)
 910         (maintenance_print_one_line_table): Update.
 911         * symfile.c (init_entry_point_info, section_is_mapped)
 912         (list_overlays_command, simple_read_overlay_table)
 913         (simple_overlay_update_1): Update.
 914         * stap-probe.c (handle_stap_probe): Update.
 915         * stabsread.c (dbx_init_float_type, define_symbol)
 916         (read_one_struct_field, read_enum_type, read_range_type): Update.
 917         * source.c (info_line_command): Update.
 918         * python/python.c (gdbpy_source_objfile_script)
 919         (gdbpy_execute_objfile_script): Update.
 920         * python/py-type.c (save_objfile_types): Update.
 921         * python/py-objfile.c (py_free_objfile): Update.
 922         * python/py-inferior.c (python_new_objfile): Update.
 923         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
 924         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
 925         (maintenance_check_psymtabs): Update.
 926         * printcmd.c (info_address_command): Update.
 927         * objfiles.h (struct objfile) <arch>: New method, from
 928         get_objfile_arch.
 929         (get_objfile_arch): Don't declare.
 930         * objfiles.c (get_objfile_arch): Remove.
 931         (filter_overlapping_sections): Update.
 932         * minsyms.c (msymbol_is_function): Update.
 933         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
 934         (output_nondebug_symbol): Update.
 935         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
 936         (mdebug_expand_psymtab): Update.
 937         * machoread.c (macho_add_oso_symfile): Update.
 938         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
 939         Update.
 940         * linux-fork.c (checkpoint_command): Update.
 941         * linespec.c (convert_linespec_to_sals): Update.
 942         * jit.c (finalize_symtab): Update.
 943         * infrun.c (insert_exception_resume_from_probe): Update.
 944         * ia64-tdep.c (ia64_find_unwind_table): Update.
 945         * hppa-tdep.c (internalize_unwinds): Update.
 946         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
 947         Update.
 948         * gcore.c (call_target_sbrk): Update.
 949         * elfread.c (record_minimal_symbol, elf_symtab_read)
 950         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
 951         (elf_gnu_ifunc_resolve_by_got): Update.
 952         * dwarf2/read.c (create_addrmap_from_index)
 953         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 954         (read_debug_names_from_section)
 955         (process_psymtab_comp_unit_reader, add_partial_symbol)
 956         (add_partial_subprogram, process_full_comp_unit)
 957         (read_file_scope, read_func_scope, read_lexical_block_scope)
 958         (read_call_site_scope, dwarf2_ranges_read)
 959         (dwarf2_record_block_ranges, dwarf2_add_field)
 960         (mark_common_block_symbol_computed, read_tag_pointer_type)
 961         (read_tag_string_type, dwarf2_init_float_type)
 962         (dwarf2_init_complex_target_type, read_base_type)
 963         (partial_die_info::read, partial_die_info::read)
 964         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
 965         (dwarf2_fetch_die_loc_sect_off): Update.
 966         * dwarf2/loc.c (dwarf2_find_location_expression)
 967         (class dwarf_evaluate_loc_desc, rw_pieced_value)
 968         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
 969         (dwarf2_loc_desc_get_symbol_read_needs)
 970         (locexpr_describe_location_piece, locexpr_describe_location_1)
 971         (loclist_describe_location): Update.
 972         * dwarf2/index-write.c (write_debug_names): Update.
 973         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
 974         * dtrace-probe.c (dtrace_process_dof): Update.
 975         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
 976         (process_one_symbol): Update.
 977         * ctfread.c (ctf_init_float_type, read_base_type): Update.
 978         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
 979         (coff_read_enum_type): Update.
 980         * cli/cli-cmds.c (edit_command, list_command): Update.
 981         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
 982         * breakpoint.c (create_overlay_event_breakpoint)
 983         (create_longjmp_master_breakpoint)
 984         (create_std_terminate_master_breakpoint)
 985         (create_exception_master_breakpoint, get_sal_arch): Update.
 986         * block.c (block_gdbarch): Update.
 987         * annotate.c (annotate_source_line): Update.
 988
 989 2020-04-17  Tom Tromey  <tromey@adacore.com>
 990
 991         * auto-load.c (show_auto_load_cmd): Remove.
 992         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
 993         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
 994         (maintenance_print_arc_command): Remove.
 995         * tui/tui-win.c (tui_command): Remove.
 996         (tui_get_cmd_list): Use add_basic_prefix_cmd.
 997         * tui/tui-layout.c (tui_layout_command): Remove.
 998         (_initialize_tui_layout): Use add_basic_prefix_cmd.
 999         * python/python.c (user_set_python, user_show_python): Remove.
1000         (_initialize_python): Use add_basic_prefix_cmd,
1001         add_show_prefix_cmd.
1002         * guile/guile.c (set_guile_command, show_guile_command): Remove.
1003         (install_gdb_commands): Use add_basic_prefix_cmd,
1004         add_show_prefix_cmd.
1005         (info_guile_command): Remove.
1006         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
1007         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
1008         add_show_prefix_cmd.
1009         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1010         Remove do_set and do_show parameters.
1011         * cli/cli-style.c (set_style, show_style): Remove.
1012         (_initialize_cli_style): Use add_basic_prefix_cmd,
1013         add_show_prefix_cmd.
1014         (cli_style_option::add_setshow_commands): Remove do_set and
1015         do_show parameters.
1016         (cli_style_option::add_setshow_commands): Use
1017         add_basic_prefix_cmd, add_show_prefix_cmd.
1018         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
1019         (set_style_name): Remove.
1020         * cli/cli-dump.c (dump_command, append_command): Remove.
1021         (srec_dump_command, ihex_dump_command, verilog_dump_command)
1022         (tekhex_dump_command, binary_dump_command)
1023         (binary_append_command): Remove.
1024         (_initialize_cli_dump): Use add_basic_prefix_cmd.
1025         * windows-tdep.c (w32_prefix_command_valid): Remove global.
1026         (init_w32_command_list): Remove; move into ...
1027         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
1028         * valprint.c (set_print, show_print, set_print_raw)
1029         (show_print_raw): Remove.
1030         (_initialize_valprint): Use add_basic_prefix_cmd,
1031         add_show_prefix_cmd.
1032         * typeprint.c (set_print_type, show_print_type): Remove.
1033         (_initialize_typeprint): Use add_basic_prefix_cmd,
1034         add_show_prefix_cmd.
1035         * record.c (set_record_command, show_record_command): Remove.
1036         (_initialize_record): Use add_basic_prefix_cmd,
1037         add_show_prefix_cmd.
1038         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
1039         add_show_prefix_cmd.
1040         (info_command, show_command, set_debug, show_debug): Remove.
1041         * top.h (set_history, show_history): Don't declare.
1042         * top.c (set_history, show_history): Remove.
1043         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
1044         (unset_tdesc_cmd): Remove.
1045         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
1046         add_show_prefix_cmd.
1047         * symtab.c (info_module_command): Remove.
1048         (_initialize_symtab): Use add_basic_prefix_cmd.
1049         * symfile.c (overlay_command): Remove.
1050         (_initialize_symfile): Use add_basic_prefix_cmd.
1051         * sparc64-tdep.c (info_adi_command): Remove.
1052         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
1053         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
1054         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
1055         add_show_prefix_cmd.
1056         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
1057         (_initialize_serial): Use add_basic_prefix_cmd,
1058         add_show_prefix_cmd.
1059         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
1060         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
1061         add_show_prefix_cmd.
1062         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
1063         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
1064         add_show_prefix_cmd.
1065         * riscv-tdep.c (show_riscv_command, set_riscv_command)
1066         (show_debug_riscv_command, set_debug_riscv_command): Remove.
1067         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
1068         add_show_prefix_cmd.
1069         * remote.c (remote_command, set_remote_cmd): Remove.
1070         (_initialize_remote): Use add_basic_prefix_cmd.
1071         * record-full.c (set_record_full_command)
1072         (show_record_full_command): Remove.
1073         (_initialize_record_full): Use add_basic_prefix_cmd,
1074         add_show_prefix_cmd.
1075         * record-btrace.c (cmd_set_record_btrace)
1076         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
1077         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
1078         (cmd_show_record_btrace_pt): Remove.
1079         (_initialize_record_btrace): Use add_basic_prefix_cmd,
1080         add_show_prefix_cmd.
1081         * ravenscar-thread.c (set_ravenscar_command)
1082         (show_ravenscar_command): Remove.
1083         (_initialize_ravenscar): Use add_basic_prefix_cmd,
1084         add_show_prefix_cmd.
1085         * mips-tdep.c (show_mips_command, set_mips_command)
1086         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
1087         add_show_prefix_cmd.
1088         * maint.c (maintenance_command, maintenance_info_command)
1089         (maintenance_check_command, maintenance_print_command)
1090         (maintenance_set_cmd, maintenance_show_cmd): Remove.
1091         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
1092         add_show_prefix_cmd.
1093         (show_per_command_cmd): Remove.
1094         * maint-test-settings.c (maintenance_set_test_settings_cmd):
1095         Remove.
1096         (maintenance_show_test_settings_cmd): Remove.
1097         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
1098         add_show_prefix_cmd.
1099         * maint-test-options.c (maintenance_test_options_command):
1100         Remove.
1101         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
1102         * macrocmd.c (macro_command): Remove
1103         (_initialize_macrocmd): Use add_basic_prefix_cmd.
1104         * language.c (set_check, show_check): Remove.
1105         (_initialize_language): Use add_basic_prefix_cmd,
1106         add_show_prefix_cmd.
1107         * infcmd.c (unset_command): Remove.
1108         (_initialize_infcmd): Use add_basic_prefix_cmd.
1109         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
1110         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
1111         add_show_prefix_cmd.
1112         * go32-nat.c (go32_info_dos_command): Remove.
1113         (_initialize_go32_nat): Use add_basic_prefix_cmd.
1114         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
1115         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
1116         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
1117         (_initialize_frame): Use add_basic_prefix_cmd,
1118         add_show_prefix_cmd.
1119         * dcache.c (set_dcache_command, show_dcache_command): Remove.
1120         (_initialize_dcache): Use add_basic_prefix_cmd,
1121         add_show_prefix_cmd.
1122         * cp-support.c (maint_cplus_command): Remove.
1123         (_initialize_cp_support): Use add_basic_prefix_cmd.
1124         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
1125         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
1126         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
1127         add_basic_prefix_cmd, add_show_prefix_cmd.
1128         * breakpoint.c (save_command): Remove.
1129         (_initialize_breakpoint): Use add_basic_prefix_cmd.
1130         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
1131         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
1132         add_show_prefix_cmd.
1133         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
1134         (set_ada_command, show_ada_command): Remove.
1135         (_initialize_ada_language): Use add_basic_prefix_cmd,
1136         add_show_prefix_cmd.
1137         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
1138
1139 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
1140
1141         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
1142         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
1143
1144 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
1145
1146         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
1147         warning messages.
1148
1149 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
1150
1151         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
1152         import table is not at beginning of .idata section.
1153
1154 2020-04-16  Pedro Alves  <palves@redhat.com>
1155
1156         * inferior.c (delete_inferior): Use delete operator directly
1157         instead of delete_program_space.
1158         * progspace.c (add_program_space): New, factored out from
1159         program_space::program_space.
1160         (remove_program_space): New, factored out from
1161         delete_program_space.
1162         (program_space::program_space): Remove intro comment.  Rewrite.
1163         (program_space::~program_space): Remove intro comment.  Call
1164         remove_program_space.
1165         (delete_program_space): Delete.
1166         * progspace.h (program_space::program_space): Make explicit.  Move
1167         intro comment here, adjusted.
1168         (program_space::~program_space): Move intro comment here,
1169         adjusted.
1170         (delete_program_space): Remove.
1171
1172 2020-04-16  Tom Tromey  <tromey@adacore.com>
1173
1174         * windows-nat.c (windows_nat::handle_access_violation): New
1175         function.
1176         * nat/windows-nat.h (handle_access_violation): Declare.
1177         * nat/windows-nat.c (handle_exception): Move Cygwin code to
1178         windows-nat.c.  Call handle_access_violation.
1179
1180 2020-04-16  Tom de Vries  <tdevries@suse.de>
1181
1182         PR symtab/25791
1183         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
1184         CUs without psymtab.
1185
1186 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
1187
1188         * python/python.c (do_start_initialization): Don't call
1189         PyEval_InitThreads for Python 3.9 and beyond.
1190
1191 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
1192
1193         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
1194         thread functions.
1195         (obsd_nat_target::wait): Likewise.
1196
1197 2020-04-15  Tom Tromey  <tromey@adacore.com>
1198
1199         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
1200         (DEBUG_EXCEPT): Use debug_printf.
1201
1202 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1203
1204         * completer.c (class completion_tracker::completion_hash_entry)
1205         <hash_name>: New member function.
1206         (completion_tracker::discard_completions): New callback to hash a
1207         completion_hash_entry, pass this to htab_create_alloc.
1208
1209 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
1210
1211         * windows-nat.c (windows_make_so): Warn rather than stopping with
1212         an error if realpath() fails.
1213
1214 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
1215
1216         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
1217         (nbsd_nat_target::info_proc): Add do_status.
1218
1219 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
1220             Tom de Vries  <tdevries@suse.de>
1221
1222         PR symtab/25718
1223         * psympriv.h (struct partial_symtab::read_symtab)
1224         (struct partial_symtab::expand_psymtab)
1225         (struct partial_symtab::read_dependencies): Update comments.
1226         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
1227         read_symtab for includer.
1228         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
1229         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
1230         (struct dwarf2_include_psymtab::m_readin): Remove.
1231         (struct dwarf2_include_psymtab::includer): New member function.
1232         (dwarf2_psymtab::expand_psymtab): Assert !readin.
1233
1234 2020-04-14  Tom de Vries  <tdevries@suse.de>
1235
1236         PR symtab/25720
1237         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
1238         with NULL symbol_matcher and lookup_name.
1239         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
1240         and lookup_name.
1241         * dwarf2/read.c (dw2_expand_symtabs_matching)
1242         (dw2_debug_names_expand_symtabs_matching): Same.
1243         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
1244         Make lookup_name a pointer.  Update comment.
1245         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
1246         lookup_name being a pointer.
1247         * symfile.c (expand_symtabs_matching): Same.
1248         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
1249         * linespec.c (iterate_over_all_matching_symtabs): Same.
1250
1251 2020-04-13  Tom Tromey  <tom@tromey.com>
1252
1253         * run-on-main-thread.c: Update include.
1254         * unittests/main-thread-selftests.c: Update include.
1255         * tui/tui-win.c: Update include.
1256         * tui/tui-io.c: Update include.
1257         * tui/tui-interp.c: Update include.
1258         * tui/tui-hooks.c: Update include.
1259         * top.h: Update include.
1260         * top.c: Update include.
1261         * ser-base.c: Update include.
1262         * remote.c: Update include.
1263         * remote-notif.c: Update include.
1264         * remote-fileio.c: Update include.
1265         * record-full.c: Update include.
1266         * record-btrace.c: Update include.
1267         * python/python.c: Update include.
1268         * posix-hdep.c: Update include.
1269         * mingw-hdep.c: Update include.
1270         * mi/mi-main.c: Update include.
1271         * mi/mi-interp.c: Update include.
1272         * main.c: Update include.
1273         * linux-nat.c: Update include.
1274         * interps.c: Update include.
1275         * infrun.c: Update include.
1276         * inf-loop.c: Update include.
1277         * event-top.c: Update include.
1278         * event-loop.c: Move to ../gdbsupport/.
1279         * event-loop.h: Move to ../gdbsupport/.
1280         * async-event.h: Update include.
1281         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
1282
1283 2020-04-13  Tom Tromey  <tom@tromey.com>
1284
1285         * tui/tui-win.c: Include async-event.h.
1286         * remote.c: Include async-event.h.
1287         * remote-notif.c: Include async-event.h.
1288         * record-full.c: Include async-event.h.
1289         * record-btrace.c: Include async-event.h.
1290         * infrun.c: Include async-event.h.
1291         * event-top.c: Include async-event.h.
1292         * event-loop.h: Move some declarations to async-event.h.
1293         * event-loop.c: Don't include ser-event.h or top.h.  Move some
1294         code to async-event.c.
1295         * async-event.h: New file.
1296         * async-event.c: New file.
1297         * Makefile.in (COMMON_SFILES): Add async-event.c.
1298         (HFILES_NO_SRCDIR): Add async-event.h.
1299
1300 2020-04-13  Tom Tromey  <tom@tromey.com>
1301
1302         * utils.c (flush_streams): New function.
1303         * event-loop.c (gdb_wait_for_event): Call flush_streams.
1304
1305 2020-04-13  Tom Tromey  <tom@tromey.com>
1306
1307         * event-loop.c (handle_file_event): Use warning, not
1308         printf_unfiltered.
1309
1310 2020-04-13  Tom Tromey  <tom@tromey.com>
1311
1312         * event-loop.c: Include <chrono>.
1313
1314 2020-04-13  Tom Tromey  <tom@tromey.com>
1315
1316         * gdb_select.h: Move to ../gdbsupport/.
1317         * event-loop.c: Update include path.
1318         * top.c: Update include path.
1319         * ser-base.c: Update include path.
1320         * ui-file.c: Update include path.
1321         * ser-tcp.c: Update include path.
1322         * guile/scm-ports.c: Update include path.
1323         * posix-hdep.c: Update include path.
1324         * ser-unix.c: Update include path.
1325         * gdb_usleep.c: Update include path.
1326         * mingw-hdep.c: Update include path.
1327         * inflow.c: Update include path.
1328         * infrun.c: Update include path.
1329         * event-top.c: Update include path.
1330
1331 2020-04-13  Tom Tromey  <tom@tromey.com>
1332
1333         * configure: Rebuild.
1334         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
1335
1336 2020-04-13  Tom Tromey  <tom@tromey.com>
1337
1338         * event-loop.h (start_event_loop): Don't declare.
1339         * event-loop.c (start_event_loop): Move...
1340         * main.c (start_event_loop): ...here.  Now static.
1341
1342 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
1343
1344         * MAINTAINERS: Update my email address.
1345
1346 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1347
1348         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
1349         IP_ALL.
1350
1351 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1352
1353         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
1354         (nbsd_nat_target::info_proc): Add do_cmdline.
1355
1356 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1357
1358         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
1359         (nbsd_nat_target::info_proc): Add do_cwd.
1360
1361 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1362
1363         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
1364
1365 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
1366
1367         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
1368         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
1369         (nbsd_nat_target::info_proc): New functions.
1370         * nbsd-nat.c (kinfo_get_vmmap): New function.
1371         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
1372         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
1373         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
1374         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
1375         functions.
1376         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
1377         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
1378         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
1379         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
1380         (KINFO_VME_FLAG_GROWS_DOWN): New.
1381
1382 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
1383
1384         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
1385         bit shift.
1386
1387 2020-04-10  Tom Tromey  <tromey@adacore.com>
1388
1389         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
1390
1391 2020-04-10  Tom Tromey  <tromey@adacore.com>
1392
1393         * symtab.c (get_symbol_address, get_msymbol_address): Skip
1394         separate debug files.
1395
1396 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
1397
1398         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
1399         Move to...
1400         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
1401         ... here.
1402         * windows-nat.c (windows_nat_target::get_windows_debug_event):
1403         Check for STATUS_WX86_BREAKPOINT.
1404         (windows_nat_target::wait): Same.
1405
1406 2020-04-10  Tom de Vries  <tdevries@suse.de>
1407
1408         PR cli/25808
1409         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
1410
1411 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
1412
1413         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
1414         (Write After Approval): Remove Tom de Vries.
1415
1416 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1417
1418         revert partially:
1419         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1420
1421         * buildsym.c (record_line): Fix undefined behavior and preserve
1422         lines at eof.
1423
1424 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
1425
1426         * auxv.h (svr4_auxv_parse): New.
1427         * auxv.c (default_auxv_parse): Split into default_auxv_parse
1428         and generic_auxv_parse.
1429         (svr4_auxv_parse): Add.
1430         * obsd-tdep.c: Include "auxv.h".
1431         (obsd_auxv_parse): Remove.
1432         (obsd_init_abi): Remove comment.
1433         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
1434         from `obsd_auxv_parse' to `svr4_auxv_parse'.
1435         * nbsd-tdep.c: Include "auxv.h".
1436         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
1437
1438 2020-04-08  Tom Tromey  <tromey@adacore.com>
1439
1440         * nat/windows-nat.h (last_wait_event): Don't declare.
1441         (wait_for_debug_event): Update comment.
1442         * nat/windows-nat.c (last_wait_event): Now static.
1443
1444 2020-04-08  Tom Tromey  <tromey@adacore.com>
1445
1446         * windows-nat.c (wait_for_debug_event): Move to
1447         nat/windows-nat.c.
1448         * nat/windows-nat.h (wait_for_debug_event): Declare.
1449         * nat/windows-nat.c (wait_for_debug_event): Move from
1450         windows-nat.c.  No longer static.
1451
1452 2020-04-08  Tom Tromey  <tromey@adacore.com>
1453
1454         * windows-nat.c (get_windows_debug_event): Use
1455         fetch_pending_stop.
1456         * nat/windows-nat.h (fetch_pending_stop): Declare.
1457         * nat/windows-nat.c (fetch_pending_stop): New function.
1458
1459 2020-04-08  Tom Tromey  <tromey@adacore.com>
1460
1461         * windows-nat.c (windows_continue): Use matching_pending_stop and
1462         continue_last_debug_event.
1463         * nat/windows-nat.h (matching_pending_stop)
1464         (continue_last_debug_event): Declare.
1465         * nat/windows-nat.c (DEBUG_EVENTS): New define.
1466         (matching_pending_stop, continue_last_debug_event): New
1467         functions.
1468
1469 2020-04-08  Tom Tromey  <tromey@adacore.com>
1470
1471         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
1472         (handle_exception_result): Move to nat/windows-nat.h.
1473         (DEBUG_EXCEPTION_SIMPLE): Remove.
1474         (windows_nat::handle_ms_vc_exception): New function.
1475         (handle_exception): Move to nat/windows-nat.c.
1476         (get_windows_debug_event): Update.
1477         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
1478         nat/windows-nat.c.
1479         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
1480         (handle_exception_result): Move from windows-nat.c.
1481         (handle_exception): Declare.
1482         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
1483         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
1484         windows-nat.c.
1485
1486 2020-04-08  Tom Tromey  <tromey@adacore.com>
1487
1488         * windows-nat.c (exception_count, event_count): Remove.
1489         (handle_exception, get_windows_debug_event)
1490         (do_initial_windows_stuff): Update.
1491
1492 2020-04-08  Tom Tromey  <tromey@adacore.com>
1493
1494         * windows-nat.c (windows_nat::handle_load_dll)
1495         (windows_nat::handle_unload_dll): Rename.  No longer static.
1496         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
1497         Declare.
1498
1499 2020-04-08  Tom Tromey  <tromey@adacore.com>
1500
1501         * complaints.h (stop_whining): Declare at top-level.
1502         (complaint): Don't declare stop_whining.
1503
1504 2020-04-08  Tom Tromey  <tromey@adacore.com>
1505
1506         * windows-nat.c (windows_nat::handle_output_debug_string):
1507         Rename.  No longer static.
1508         * nat/windows-nat.h (handle_output_debug_string): Declare.
1509
1510 2020-04-08  Tom Tromey  <tromey@adacore.com>
1511
1512         * windows-nat.c (current_process_handle, current_process_id)
1513         (main_thread_id, last_sig, current_event, last_wait_event)
1514         (current_windows_thread, desired_stop_thread_id, pending_stops)
1515         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
1516         (display_selectors, fake_create_process)
1517         (get_windows_debug_event): Update.
1518         * nat/windows-nat.h (current_process_handle, current_process_id)
1519         (main_thread_id, last_sig, current_event, last_wait_event)
1520         (current_windows_thread, desired_stop_thread_id, pending_stops)
1521         (struct pending_stop, siginfo_er): Move from windows-nat.c.
1522         * nat/windows-nat.c (current_process_handle, current_process_id)
1523         (main_thread_id, last_sig, current_event, last_wait_event)
1524         (current_windows_thread, desired_stop_thread_id, pending_stops)
1525         (siginfo_er): New globals.  Move from windows-nat.c.
1526
1527 2020-04-08  Tom Tromey  <tromey@adacore.com>
1528
1529         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
1530         (handle_load_dll): Update.
1531         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
1532
1533 2020-04-08  Tom Tromey  <tromey@adacore.com>
1534
1535         * windows-nat.c (enum thread_disposition_type): Move to
1536         nat/windows-nat.h.
1537         (windows_nat::thread_rec): Rename from thread_rec.  No longer
1538         static.
1539         (windows_add_thread, windows_nat_target::fetch_registers)
1540         (windows_nat_target::store_registers, handle_exception)
1541         (windows_nat_target::resume, get_windows_debug_event)
1542         (windows_nat_target::get_tib_address)
1543         (windows_nat_target::thread_name)
1544         (windows_nat_target::thread_alive): Update.
1545         * nat/windows-nat.h (enum thread_disposition_type): Move from
1546         windows-nat.c.
1547         (thread_rec): Declare.
1548
1549 2020-04-08  Tom Tromey  <tromey@adacore.com>
1550
1551         * windows-nat.c: Add "using namespace".
1552         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
1553         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
1554
1555 2020-04-08  Tom Tromey  <tromey@adacore.com>
1556
1557         * nat/windows-nat.h (struct windows_thread_info): Declare
1558         destructor.
1559         * nat/windows-nat.c (~windows_thread_info): New.
1560
1561 2020-04-08  Tom Tromey  <tromey@adacore.com>
1562
1563         PR gdb/22992
1564         * windows-nat.c (current_event): Update comment.
1565         (last_wait_event, desired_stop_thread_id): New globals.
1566         (struct pending_stop): New.
1567         (pending_stops): New global.
1568         (windows_nat_target) <stopped_by_sw_breakpoint>
1569         <supports_stopped_by_sw_breakpoint>: New methods.
1570         (windows_fetch_one_register): Add assertions.  Adjust PC.
1571         (windows_continue): Handle pending stops.  Suspend other threads
1572         when stepping.  Use last_wait_event
1573         (wait_for_debug_event): New function.
1574         (get_windows_debug_event): Use wait_for_debug_event.  Handle
1575         pending stops.  Queue spurious stops.
1576         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
1577         (windows_nat_target::kill): Use wait_for_debug_event.
1578         * nat/windows-nat.h (struct windows_thread_info)
1579         <stopped_at_software_breakpoint>: New field.
1580         * nat/windows-nat.c (windows_thread_info::resume): Clear
1581         stopped_at_software_breakpoint.
1582
1583 2020-04-08  Tom Tromey  <tromey@adacore.com>
1584
1585         * windows-nat.c (enum thread_disposition_type): New.
1586         (thread_rec): Replace "get_context" parameter with "disposition";
1587         change type.
1588         (windows_add_thread, windows_nat_target::fetch_registers)
1589         (windows_nat_target::store_registers, handle_exception)
1590         (windows_nat_target::resume, get_windows_debug_event)
1591         (windows_nat_target::get_tib_address)
1592         (windows_nat_target::thread_name)
1593         (windows_nat_target::thread_alive): Update.
1594
1595 2020-04-08  Tom Tromey  <tromey@adacore.com>
1596
1597         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
1598         (windows_continue): Use windows_continue::resume.
1599         * nat/windows-nat.h (struct windows_thread_info) <suspend,
1600         resume>: Declare new methods.
1601         * nat/windows-nat.c: New file.
1602         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
1603
1604 2020-04-08  Tom Tromey  <tromey@adacore.com>
1605
1606         * windows-nat.c (windows_add_thread, windows_delete_thread)
1607         (windows_nat_target::fetch_registers)
1608         (windows_nat_target::store_registers, fake_create_process)
1609         (windows_nat_target::resume, windows_nat_target::resume)
1610         (get_windows_debug_event, windows_nat_target::wait)
1611         (windows_nat_target::pid_to_str)
1612         (windows_nat_target::get_tib_address)
1613         (windows_nat_target::get_ada_task_ptid)
1614         (windows_nat_target::thread_name)
1615         (windows_nat_target::thread_alive): Use lwp, not tid.
1616
1617 2020-04-08  Tom Tromey  <tromey@adacore.com>
1618
1619         * windows-nat.c (handle_exception)
1620         (windows_nat_target::thread_name): Update.
1621         * nat/windows-nat.h (windows_thread_info): Remove destructor.
1622         <name>: Now unique_xmalloc_ptr.
1623
1624 2020-04-08  Tom Tromey  <tromey@adacore.com>
1625
1626         * windows-nat.c (thread_rec)
1627         (windows_nat_target::fetch_registers): Update.
1628         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
1629         Update comment.
1630         <debug_registers_changed, reload_context>: Now bool.
1631
1632 2020-04-08  Tom Tromey  <tromey@adacore.com>
1633
1634         * windows-nat.c (windows_add_thread): Use new.
1635         (windows_init_thread_list, windows_delete_thread): Use delete.
1636         (get_windows_debug_event): Update.
1637         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
1638         destructor, and initializers.
1639
1640 2020-04-08  Tom Tromey  <tromey@adacore.com>
1641
1642         * windows-nat.c (struct windows_thread_info): Remove.
1643         * nat/windows-nat.h: New file.
1644
1645 2020-04-08  Tom Tromey  <tromey@adacore.com>
1646
1647         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
1648         (thread_rec, windows_add_thread, windows_delete_thread)
1649         (windows_continue): Update.
1650
1651 2020-04-08  Tom Tromey  <tromey@adacore.com>
1652
1653         * windows-nat.c (struct windows_thread_info): Remove typedef.
1654         (thread_head): Remove.
1655         (thread_list): New global.
1656         (thread_rec, windows_add_thread, windows_init_thread_list)
1657         (windows_delete_thread, windows_continue): Update.
1658
1659 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1660
1661         * windows-tdep.h (windows_init_abi): Add comment.
1662         (cygwin_init_abi): New declaration.
1663         * windows-tdep.c: Split signal enumeration in two, one for
1664         Windows and one for Cygwin.
1665         (windows_gdb_signal_to_target): Only deal with signal of the
1666         Windows OS ABI.
1667         (cygwin_gdb_signal_to_target): New function.
1668         (windows_init_abi): Rename to windows_init_abi_common, don't set
1669         gdb_signal_to_target gdbarch method.  Add new new function with
1670         this name.
1671         (cygwin_init_abi): New function.
1672         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
1673         comment.  Don't call windows_init_abi.
1674         (amd64_windows_init_abi): Add comment, call windows_init_abi.
1675         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
1676         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
1677         i386_windows_init_abi_common, don't call windows_init_abi.  Add
1678         a new function of this name.
1679         (i386_cygwin_init_abi): New function.
1680         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
1681         OS ABI Cygwin.
1682
1683 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1684
1685         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
1686         parameter.c.
1687         (dwarf2_read_gdb_index): Update.
1688
1689 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
1690
1691         * nbsd-tdep.c: Include "objfiles.h".
1692         (nbsd_skip_solib_resolver): New.
1693         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
1694
1695 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1696
1697         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
1698         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
1699         with DW_LLE_base_addressx are being emitted in DWARFv5.
1700         Add the newly added kind DW_LOC_OFFSET_PAIR also.
1701         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
1702         unsigned integer.
1703
1704 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1705
1706         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
1707         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
1708         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
1709         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
1710         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
1711         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
1712         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
1713
1714
1715 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1716
1717         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
1718         (read_loclist_index): New function definition.
1719         (lookup_loclist_base): New function definition.
1720         (read_loclist_header): New function definition.
1721         (dwarf2_cu): Add loclist_base and loclist_header field.
1722         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
1723         (read_full_die_1): Read the value of DW_AT_loclists_base.
1724         (read_attribute_reprocess): Handle DW_FORM_loclistx.
1725         (read_attribute_value): Handle DW_FORM_loclistx.
1726         (skip_one_die): Handle DW_FORM_loclistx.
1727         (loclist_header): New structure declaration.
1728         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
1729
1730 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
1731
1732         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
1733         constructor.  Remove `addr` parameter from other constructor and
1734         add `per_cu` parameter.
1735         * dwarf2/read.c (create_partial_symtab): Update.
1736
1737 2020-04-07  Tom de Vries  <tdevries@suse.de>
1738
1739         PR symtab/25796
1740         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
1741         (partial_die_info::fixup): Inherit has_const_value.
1742
1743 2020-04-07  Tom de Vries  <tdevries@suse.de>
1744
1745         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
1746         symbols without address.
1747
1748 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1749
1750         * nbsd-nat.h (struct thread_info): Add forward declaration.
1751         (nbsd_nat_target::thread_alive): Add.
1752         (nbsd_nat_target::thread_name): Likewise.
1753         (nbsd_nat_target::update_thread_list): Likewise.
1754         (update_thread_list::post_attach): Likewise.
1755         (post_attach::pid_to_str): Likewise.
1756         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
1757         (nbsd_thread_lister): Add.
1758         (nbsd_nat_target::thread_alive): Likewise.
1759         (nbsd_nat_target::thread_name): Likewise.
1760         (nbsd_add_threads): Likewise.
1761         (update_thread_list::post_attach): Likewise.
1762         (nbsd_nat_target::update_thread_list): Likewise.
1763         (post_attach::pid_to_str): Likewise.
1764
1765 2020-04-06  Tom Tromey  <tromey@adacore.com>
1766
1767         * ada-valprint.c (print_variant_part): Extract the variant field.
1768         (print_field_values): Use the field as the outer value when
1769         recursing.
1770
1771 2020-04-06  Tom Tromey  <tromey@adacore.com>
1772
1773         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
1774         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
1775         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
1776         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
1777         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
1778
1779 2020-04-06  Tom Tromey  <tromey@adacore.com>
1780
1781         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
1782         TYPE_CODE_ERROR.
1783
1784 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1785
1786         * nbsd-tdep.c: Include "gdbarch.h".
1787         Define enum with NetBSD signal numbers.
1788         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
1789         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
1790         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
1791         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
1792         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
1793         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
1794         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
1795         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
1796         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
1797         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
1798         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
1799         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
1800
1801 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
1802
1803         PR gdb/25325
1804         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
1805
1806 2020-04-03  Tom Tromey  <tromey@adacore.com>
1807
1808         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
1809         Read constant block.
1810
1811 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
1812
1813         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
1814         (gdb_bfd_get_full_section_contents): New declaration.
1815         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
1816         * windows-tdep.c (is_linked_with_cygwin_dll): Use
1817         gdb_bfd_get_full_section_contents.
1818
1819 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
1820
1821         * exec.c (build_section_table): Replace internal_error with
1822         gdb_assert.
1823         (section_table_xfer_memory_partial): Likewise.
1824         * mdebugread.c (parse_partial_symbols): Likewise.
1825         * psymtab.c (lookup_partial_symbol): Likewise.
1826         * utils.c (wrap_here): Likewise.
1827
1828 2020-04-02  Tom Tromey  <tromey@adacore.com>
1829
1830         * f-lang.c (build_fortran_types): Use arch_type to initialize
1831         builtin_complex_s32 in the TYPE_CODE_ERROR case.
1832
1833 2020-04-02  Tom Tromey  <tromey@adacore.com>
1834
1835         * dwarf2/read.c (partial_die_info::read): Do not create a vector
1836         of attributes.
1837
1838 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1839             Bernd Edlinger <bernd.edlinger@hotmail.de>
1840             Tom Tromey  <tromey@adacore.com>
1841
1842         * buildsym.c (buildsym_compunit::record_line): Remove
1843         deduplication code.
1844
1845 2020-04-02  Tom de Vries  <tdevries@suse.de>
1846
1847         PR ada/24671
1848         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
1849
1850 2020-04-02  Tom de Vries  <tdevries@suse.de>
1851
1852         * dwarf2/read.c (dwarf2_gdb_index_functions,
1853         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
1854         NULL.
1855         * psymtab.c (psym_lookup_global_symbol_language): New function.
1856         (psym_functions): Init psym_lookup_global_symbol_language with
1857         psym_lookup_global_symbol_language.
1858         * symfile-debug.c (debug_sym_quick_functions): Init
1859         lookup_global_symbol_language with NULL.
1860         * symfile.c (set_initial_language): Remove fixme comment.
1861         * symfile.h (struct quick_symbol_functions): Add
1862         lookup_global_symbol_language.
1863         * symtab.c (find_quick_global_symbol_language): New function.
1864         (find_main_name): Use find_quick_global_symbol_language.
1865
1866 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
1867
1868         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
1869
1870 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1871
1872         * buildsym.c (record_line): Fix undefined behavior and preserve
1873         lines at eof.
1874
1875 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1876
1877         * buildsym.c (record_line): Fix the resizing condition.
1878
1879 2020-04-01  Tom Tromey  <tom@tromey.com>
1880
1881         * value.h (value_literal_complex): Add comment.
1882         * valops.c (value_literal_complex): Refer to value.h.
1883
1884 2020-04-01  Tom Tromey  <tom@tromey.com>
1885
1886         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
1887         (scalar_type): New rule, from typebase.
1888         (typebase): Use scalar_type.  Recognize complex types.
1889         (field_name): Handle FLOAT_KEYWORD.
1890         (ident_tokens): Add _Complex and __complex__.
1891
1892 2020-04-01  Tom Tromey  <tom@tromey.com>
1893
1894         PR exp/25299:
1895         * valarith.c (promotion_type, complex_binop): New functions.
1896         (scalar_binop): Handle complex numbers.  Use promotion_type.
1897         (value_pos, value_neg, value_complement): Handle complex numbers.
1898
1899 2020-04-01  Tom Tromey  <tom@tromey.com>
1900
1901         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
1902         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
1903         (parse_number): Handle complex numbers.
1904
1905 2020-04-01  Tom Tromey  <tom@tromey.com>
1906
1907         * c-valprint.c (c_decorations): Change complex suffix to "i".
1908
1909 2020-04-01  Tom Tromey  <tom@tromey.com>
1910
1911         * valprint.c (generic_value_print_complex): Use accessors.
1912         * value.h (value_real_part, value_imaginary_part): Declare.
1913         * valops.c (value_real_part, value_imaginary_part): New
1914         functions.
1915         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
1916
1917 2020-04-01  Tom Tromey  <tom@tromey.com>
1918
1919         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
1920         (read_range_type): Update.
1921         * mdebugread.c (basic_type): Update.
1922         * go-lang.c (build_go_types): Use init_complex_type.
1923         * gdbtypes.h (struct main_type) <complex_type>: New member.
1924         (init_complex_type): Update.
1925         (arch_complex_type): Don't declare.
1926         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
1927         Make name if none given.  Use alloc_type_copy.  Look for cached
1928         complex type.
1929         (arch_complex_type): Remove.
1930         (gdbtypes_post_init): Use init_complex_type.
1931         * f-lang.c (build_fortran_types): Use init_complex_type.
1932         * dwarf2/read.c (read_base_type): Update.
1933         * d-lang.c (build_d_types): Use init_complex_type.
1934         * ctfread.c (read_base_type): Update.
1935
1936 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1937
1938         * infrun.c (stop_all_threads): Update assertion, plus when
1939         stopping threads, take into account that we might be trying
1940         to stop an all-stop target.
1941         (stop_waiting): Call 'stop_all_threads' if there exists a
1942         non-stop target.
1943
1944 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1945
1946         * target.h (exists_non_stop_target): New function declaration.
1947         * target.c (exists_non_stop_target): New function.
1948
1949 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
1950
1951         PR gdb/24789
1952         * eval.c (is_integral_or_integral_reference): New function.
1953         (evaluate_subexp_standard): Allow integer references in
1954         pointer arithmetic.
1955
1956 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1957
1958         * remote.c (remote_target::remote_parse_stop_reply): Remove the
1959         check for no ptid in the stop reply when the target is non-stop.
1960
1961 2020-04-01  Tom Tromey  <tromey@adacore.com>
1962
1963         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
1964         "name" parameter to rvalue reference.  Initialize m_name_holder.
1965         <lookup_name_info>: New overloads.
1966         <name>: Return gdb::string_view.
1967         <c_str>: New method.
1968         <make_ignore_params>: Update.
1969         <search_name_hash>: Update.
1970         <language_lookup_name>: Return const char *.
1971         <m_name>: Change type.
1972         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
1973         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
1974         (lookup_name_info::match_any): Update.
1975         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
1976         Update.
1977         * minsyms.c (linkage_name_str): Update.
1978         * language.c (default_symbol_name_matcher): Update.
1979         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
1980         Update.
1981         * ada-lang.c (ada_fold_name): Change parameter to string_view.
1982         (ada_lookup_name_info::ada_lookup_name_info): Update.
1983         (literal_symbol_name_matcher): Update.
1984
1985 2020-04-01  Tom Tromey  <tromey@adacore.com>
1986
1987         * psymtab.c (psymtab_search_name): Remove function.
1988         (psym_lookup_symbol): Create search name and lookup name here.
1989         (lookup_partial_symbol): Remove "name" parameter; add
1990         lookup_name.
1991         (psym_expand_symtabs_for_function): Update.
1992
1993 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
1994
1995         PR tui/25597:
1996         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
1997
1998 2020-03-31  Tom Tromey  <tromey@adacore.com>
1999
2000         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
2001         memcpy.
2002
2003 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
2004
2005         * features/riscv/32bit-csr.xml: Regenerated.
2006         * features/riscv/64bit-csr.xml: Regenerated.
2007
2008 2020-03-30  Tom Tromey  <tromey@adacore.com>
2009
2010         * ada-valprint.c (print_variant_part): Update.
2011         * ada-lang.h (ada_which_variant_applies): Update.
2012         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
2013         outer_valaddr parameters; replace with "outer" value parameter.
2014         (to_fixed_variant_branch_type): Update.
2015
2016 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2017
2018         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
2019         <list>.  Remove inclusion of observable.h.
2020         (PPC_DEBUG_CURRENT_VERSION): Move up define.
2021         (struct arch_lwp_info): New struct.
2022         (class ppc_linux_dreg_interface): New class.
2023         (struct ppc_linux_process_info): New struct.
2024         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
2025         <low_new_clone, low_forget_process, low_prepare_to_resume>
2026         <copy_thread_dreg_state, mark_thread_stale>
2027         <mark_debug_registers_changed, register_hw_breakpoint>
2028         <clear_hw_breakpoint, register_wp, clear_wp>
2029         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
2030         <num_memory_accesses, get_trigger_type>
2031         <create_watchpoint_request, hwdebug_point_cmp>
2032         <init_arch_lwp_info, get_arch_lwp_info>
2033         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
2034         methods.
2035         <struct ptid_hash>: New inner struct.
2036         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
2037         members.
2038         (saved_dabr_value, hwdebug_info, max_slots_number)
2039         (struct hw_break_tuple, struct thread_points, ppc_threads)
2040         (have_ptrace_hwdebug_interface)
2041         (hwdebug_find_thread_points_by_tid)
2042         (hwdebug_insert_point, hwdebug_remove_point): Remove.
2043         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
2044         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
2045         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
2046         use m_dreg_interface.
2047         (hwdebug_point_cmp): Change to...
2048         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
2049         reference arguments instead of pointers.
2050         (ppc_linux_nat_target::ranged_break_num_registers): Use
2051         m_dreg_interface.
2052         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
2053         m_dreg_interface.  Call register_hw_breakpoint.
2054         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
2055         m_dreg_interface.  Call clear_hw_breakpoint.
2056         (get_trigger_type): Change to...
2057         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
2058         comment.
2059         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
2060         use m_dreg_interface.  Call register_hw_breakpoint.
2061         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
2062         use m_dreg_interface.  Call clear_hw_breakpoint.
2063         (can_use_watchpoint_cond_accel): Change to...
2064         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
2065         method.  Update comment, use m_dreg_interface and
2066         m_process_info.
2067         (calculate_dvc): Change to...
2068         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
2069         m_dreg_interface.
2070         (num_memory_accesses): Change to...
2071         (ppc_linux_nat_target::num_memory_accesses): ...this method.
2072         (check_condition): Change to...
2073         (ppc_linux_nat_target::check_condition): ...this method.
2074         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
2075         comment, use m_dreg_interface.
2076         (create_watchpoint_request): Change to...
2077         (ppc_linux_nat_target::create_watchpoint_request): ...this
2078         method.  Use m_dreg_interface.
2079         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
2080         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
2081         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
2082         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
2083         (ppc_linux_nat_target::low_forget_process)
2084         (ppc_linux_nat_target::low_new_fork)
2085         (ppc_linux_nat_target::low_new_clone)
2086         (ppc_linux_nat_target::low_delete_thread)
2087         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
2088         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
2089         only call mark_thread_stale.
2090         (ppc_linux_thread_exit): Remove.
2091         (ppc_linux_nat_target::stopped_data_address): Change to...
2092         (ppc_linux_nat_target::low_stopped_data_address): This. Add
2093         comment, use m_dreg_interface and m_thread_hw_breakpoints.
2094         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
2095         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
2096         comment.  Call low_stopped_data_address.
2097         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
2098         m_dreg_interface.
2099         (ppc_linux_nat_target::masked_watch_num_registers): Use
2100         m_dreg_interface.
2101         (ppc_linux_nat_target::copy_thread_dreg_state)
2102         (ppc_linux_nat_target::mark_thread_stale)
2103         (ppc_linux_nat_target::mark_debug_registers_changed)
2104         (ppc_linux_nat_target::register_hw_breakpoint)
2105         (ppc_linux_nat_target::clear_hw_breakpoint)
2106         (ppc_linux_nat_target::register_wp)
2107         (ppc_linux_nat_target::clear_wp)
2108         (ppc_linux_nat_target::init_arch_lwp_info)
2109         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
2110         (_initialize_ppc_linux_nat): Remove observer callback.
2111
2112 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2113
2114         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
2115         (ppc_linux_nat_target::auxv_parse)
2116         (ppc_linux_nat_target::read_description)
2117         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
2118         Move up.
2119
2120 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2121
2122         * linux-nat.h (low_new_clone): New method.
2123         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
2124
2125 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
2126
2127         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
2128         (dbx_expand_psymtab): ... this.
2129         (start_psymtab): Update.
2130         * mdebugread.c (psymtab_to_symtab_1): Rename to...
2131         (mdebug_expand_psymtab): ... this.
2132         (parse_partial_symbols): Update.
2133         (new_psymtab): Update.
2134         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
2135         (xcoff_expand_psymtab): ... this.
2136         (xcoff_start_psymtab): Update.
2137
2138 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
2139
2140         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
2141         <expand_dependencies>: ... this.
2142         * psymtab.c (partial_symtab::read_dependencies): Rename to...
2143         (partial_symtab::expand_dependencies): ... this.
2144         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
2145         Update.
2146         (dwarf2_psymtab::expand_psymtab): Update.
2147         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
2148         * mdebugread.c (psymtab_to_symtab_1): Update.
2149         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
2150
2151 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
2152
2153         * psympriv.h (discard_psymtab): Remove.
2154         * dbxread.c (dbx_end_psymtab): Update.
2155         * xcoffread.c (xcoff_end_psymtab): Update.
2156
2157 2020-03-28  Tom Tromey  <tom@tromey.com>
2158
2159         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
2160         comment.
2161
2162 2020-03-28  Tom Tromey  <tom@tromey.com>
2163
2164         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
2165
2166 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
2167
2168         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
2169
2170 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
2171
2172         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
2173
2174 2020-03-26  Tom Tromey  <tom@tromey.com>
2175
2176         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
2177         (mark_common_block_symbol_computed, read_tag_string_type)
2178         (attr_to_dynamic_prop, read_subrange_type): Update.
2179         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
2180         to be methods on struct attribute.
2181         (skip_one_die, process_imported_unit_die, read_namespace_alias)
2182         (read_call_site_scope, partial_die_info::read)
2183         (partial_die_info::read, lookup_die_type, follow_die_ref):
2184         Update.
2185         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
2186         from dwarf2_get_ref_die_offset.
2187         (attribute::constant_value): New method, from
2188         dwarf2_get_attr_constant_value.
2189         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
2190         Declare method.
2191         <constant_value>: New method.
2192
2193 2020-03-26  Tom Tromey  <tom@tromey.com>
2194
2195         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
2196         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
2197         (dwarf_type_encoding_name): Move to stringify.c.
2198         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
2199         * dwarf2/stringify.c: New file.
2200         * dwarf2/stringify.h: New file.
2201
2202 2020-03-26  Tom Tromey  <tom@tromey.com>
2203
2204         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
2205         Rewrite.
2206
2207 2020-03-26  Tom Tromey  <tom@tromey.com>
2208
2209         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
2210         methods.
2211         * dwarf2/read.c (lookup_addr_base): Move to die.h.
2212         (lookup_ranges_base): Likewise.
2213         (read_cutu_die_from_dwo, read_full_die_1): Update.
2214
2215 2020-03-26  Tom Tromey  <tom@tromey.com>
2216
2217         * dwarf2/read.c (read_import_statement, read_file_scope)
2218         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
2219         (read_lexical_block_scope, read_call_site_scope)
2220         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
2221         (handle_struct_member_die, process_structure_scope)
2222         (update_enumeration_type_from_children)
2223         (process_enumeration_scope, read_array_type, read_common_block)
2224         (read_namespace, read_module, read_subroutine_type): Update.
2225         (sibling_die): Remove.
2226
2227 2020-03-26  Tom Tromey  <tom@tromey.com>
2228
2229         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
2230         (build_type_psymtabs_reader, read_structure_type)
2231         (read_enumeration_type, read_full_die_1): Update.
2232         (dwarf2_attr_no_follow): Move to die.h.
2233         * dwarf2/die.h (struct die_info) <attr>: New method.
2234
2235 2020-03-26  Tom Tromey  <tom@tromey.com>
2236
2237         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
2238         <base_address>: Now an optional.
2239         (dwarf2_find_base_address, dwarf2_rnglists_process)
2240         (dwarf2_ranges_process, fill_in_loclist_baton)
2241         (dwarf2_symbol_mark_computed): Update.
2242
2243 2020-03-26  Tom Tromey  <tom@tromey.com>
2244
2245         * dwarf2/read.c (struct die_info): Move to die.h.
2246         * dwarf2/die.h: New file.
2247
2248 2020-03-26  Tom Tromey  <tom@tromey.com>
2249
2250         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
2251         * dwarf2/read.c
2252         (dwarf2_statement_list_fits_in_line_number_section_complaint):
2253         Move to line-header.c.
2254         (read_checked_initial_length_and_offset, read_formatted_entries):
2255         Likewise.
2256         (dwarf_decode_line_header): Split into two.
2257         * dwarf2/line-header.c
2258         (dwarf2_statement_list_fits_in_line_number_section_complaint):
2259         Move from read.c.
2260         (read_checked_initial_length_and_offset, read_formatted_entries):
2261         Likewise.
2262         (dwarf_decode_line_header): New function, split from read.c.
2263
2264 2020-03-26  Tom Tromey  <tom@tromey.com>
2265
2266         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
2267         Declare method.
2268         * dwarf2/read.c (read_attribute_value): Update.
2269         (dwarf2_per_objfile::read_line_string): Rename from
2270         read_indirect_line_string.
2271         (read_formatted_entries): Update.
2272
2273 2020-03-26  Tom Tromey  <tom@tromey.com>
2274
2275         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
2276         variable.
2277
2278 2020-03-26  Tom Tromey  <tom@tromey.com>
2279
2280         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
2281         const.
2282         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
2283         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
2284         parameter const.
2285
2286 2020-03-26  Tom Tromey  <tom@tromey.com>
2287
2288         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
2289         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
2290         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
2291         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
2292
2293 2020-03-26  Tom Tromey  <tom@tromey.com>
2294
2295         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
2296         file_names_size, file_full_name, file_file_name>: Use const.
2297         <file_name_at, file_names>: Add const overload.
2298         * dwarf2/line-header.c (line_header::file_file_name)
2299         (line_header::file_full_name): Update.
2300
2301 2020-03-26  Tom Tromey  <tom@tromey.com>
2302
2303         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
2304         (macro_start_file, consume_improper_spaces)
2305         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
2306         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
2307         (dwarf_decode_macros): Move to macro.c.
2308         * dwarf2/macro.c: New file.
2309         * dwarf2/macro.h: New file.
2310         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
2311
2312 2020-03-26  Tom Tromey  <tom@tromey.com>
2313
2314         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
2315         method.
2316         * dwarf2/section.c: New method.  From
2317         read_indirect_string_at_offset_from.
2318         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
2319         (read_indirect_string_at_offset_from): Move to section.c.
2320         (read_indirect_string_at_offset): Rewrite.
2321         (read_indirect_line_string_at_offset): Remove.
2322         (read_indirect_string, read_indirect_line_string)
2323         (dwarf_decode_macro_bytes): Update.
2324
2325 2020-03-26  Tom Tromey  <tom@tromey.com>
2326
2327         * dwarf2/section.h (struct dwarf2_section_info)
2328         <overload_complaint>: Declare.
2329         (dwarf2_section_buffer_overflow_complaint): Don't declare.
2330         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
2331         Rename from dwarf2_section_buffer_overflow_complaint.
2332         * dwarf2/read.c (skip_one_die, partial_die_info::read)
2333         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
2334
2335 2020-03-26  Tom Tromey  <tom@tromey.com>
2336
2337         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
2338         Declare.
2339         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
2340         Move from read.c.
2341         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
2342         to section.c.
2343
2344 2020-03-26  Tom Tromey  <tom@tromey.com>
2345
2346         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
2347
2348 2020-03-26  Tom Tromey  <tom@tromey.com>
2349
2350         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
2351         "builder".
2352         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
2353         parameter.
2354         (dwarf_decode_macros): Update.
2355
2356 2020-03-26  Tom Tromey  <tom@tromey.com>
2357
2358         * dwarf2/read.c (read_attribute_value): Update.
2359         (read_indirect_string_from_dwz): Move to dwz.c; change into
2360         method.
2361         (dwarf_decode_macro_bytes): Update.
2362         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
2363         * dwarf2/dwz.c: New file.
2364         * Makefile.in (COMMON_SFILES): Add dwz.c.
2365
2366 2020-03-26  Tom Tromey  <tom@tromey.com>
2367
2368         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
2369         * dwarf2/read.c: Add include.
2370         * dwarf2/index-write.c: Add include.
2371         * dwarf2/index-cache.c: Add include.
2372         * dwarf2/dwz.h: New file.
2373
2374 2020-03-25  Tom Tromey  <tom@tromey.com>
2375
2376         * compile/compile-object-load.c (get_out_value_type): Mention
2377         correct symbol name in error message.
2378
2379 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
2380
2381         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
2382
2383 2020-03-25  Tom de Vries  <tdevries@suse.de>
2384
2385         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
2386         * symmisc.c (dump_symtab_1): Print user and includes fields.
2387         (maintenance_info_symtabs): Same.
2388
2389 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2390
2391         PR gdb/25534
2392         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
2393         (riscv_regcache_cooked_write): New function.
2394         (riscv_push_dummy_call): Use new function.
2395         (riscv_return_value): Likewise.
2396
2397 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
2398
2399         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
2400         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
2401         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
2402         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
2403         * infrun.c (follow_fork): Likewise.
2404         (follow_fork_inferior): Likewise.
2405         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
2406         * linux-nat.h (class linux_nat_target): Likewise.
2407         * remote.c (class remote_target) <follow_fork>: Likewise.
2408         (remote_target::follow_fork): Likewise.
2409         * target-delegates.c: Re-generate.
2410         * target.c (default_follow_fork): Likewise.
2411         (target_follow_fork): Likewise.
2412         * target.h (struct target_ops) <follow_fork>: Likewise.
2413         (target_follow_fork): Likewise.
2414
2415 2020-03-24  Tom de Vries  <tdevries@suse.de>
2416
2417         * psymtab.c (maintenance_info_psymtabs): Print user field.
2418
2419 2020-03-20  Tom Tromey  <tromey@adacore.com>
2420
2421         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
2422         const.
2423         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
2424         const.
2425
2426 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
2427
2428         * ptrace.m4: Don't check for ptrace declaration.
2429         * config.in: Re-generate.
2430         * configure: Re-generate.
2431         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
2432         not defined.
2433
2434 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2435
2436         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
2437         `PTRACE_TYPE_RET'.
2438         * i386-bsd-nat.c (gdb_ptrace): Likewise.
2439         * sparc-nat.c (gdb_ptrace): Likewise.
2440         * x86-bsd-nat.c (gdb_ptrace): Likewise.
2441
2442 2020-03-20  Tom Tromey  <tromey@adacore.com>
2443
2444         * c-exp.y (lex_one_token): Fix assert.
2445
2446 2020-03-20  Tom Tromey  <tromey@adacore.com>
2447
2448         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
2449         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
2450         strncpy call.
2451
2452 2020-03-20  Tom Tromey  <tromey@adacore.com>
2453
2454         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
2455
2456 2020-03-20  Tom Tromey  <tromey@adacore.com>
2457
2458         * ada-valprint.c (print_variant_part): Remove parameters; switch
2459         to value-based API.
2460         (print_field_values): Likewise.
2461         (ada_val_print_struct_union): Likewise.
2462         (ada_value_print_1): Update.
2463
2464 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2465
2466         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
2467         nbsd_nat_target instead of inf_ptrace_target.
2468         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2469         nbsd_nat_target.
2470
2471 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2472
2473         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
2474         it to the ptrace call.
2475         * (store_registers): Likewise.
2476
2477 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2478
2479         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
2480         it to the ptrace call.
2481         * (store_registers): Likewise.
2482
2483 2020-03-19  Luis Machado  <luis.machado@linaro.org>
2484
2485         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
2486         valid, fetch vg value from ptrace.
2487
2488 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2489         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
2490         * inf-ptrace.c: Likewise.
2491         * (gdb_ptrace): Add.
2492         * (inf_ptrace_target::resume): Update.
2493         * (inf_ptrace_target::xfer_partial): Likewise.
2494         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
2495         * (inf_ptrace_peek_poke): Update.
2496
2497 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2498
2499         * x86-bsd-nat.c (gdb_ptrace): New.
2500         * (x86bsd_dr_set): Add new argument `ptid'.
2501         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
2502         x86bsd_dr_set_addr): Update.
2503
2504 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2505
2506         * remote.c (remote_target::process_stop_reply): Handle events for
2507         all threads differently.
2508
2509 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2510
2511         * completer.c (completion_tracker::remove_completion): Define new
2512         function.
2513         * completer.h (completion_tracker::remove_completion): Declare new
2514         function.
2515         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
2516         when adding a C++ function symbol.
2517
2518 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2519
2520         * completer.c (completion_tracker::completion_hash_entry): Define
2521         new class.
2522         (advance_to_filename_complete_word_point): Call
2523         recompute_lowest_common_denominator.
2524         (completion_tracker::completion_tracker): Call discard_completions
2525         to setup the hash table.
2526         (completion_tracker::discard_completions): Allow for being called
2527         from the constructor, pass new equal function, and element deleter
2528         when constructing the hash table.  Initialise new class member
2529         variables.
2530         (completion_tracker::maybe_add_completion): Remove use of
2531         m_entries_vec, and store more information into m_entries_hash.
2532         (completion_tracker::recompute_lcd_visitor): New function, most
2533         content taken from...
2534         (completion_tracker::recompute_lowest_common_denominator):
2535         ...here, this now just visits each item in the hash calling the
2536         above visitor.
2537         (completion_tracker::build_completion_result): Remove use of
2538         m_entries_vec, call recompute_lowest_common_denominator.
2539         * completer.h (completion_tracker::have_completions): Remove use
2540         of m_entries_vec.
2541         (completion_tracker::completion_hash_entry): Declare new class.
2542         (completion_tracker::recompute_lowest_common_denominator): Change
2543         function signature.
2544         (completion_tracker::recompute_lcd_visitor): Declare new function.
2545         (completion_tracker::m_entries_vec): Delete.
2546         (completion_tracker::m_entries_hash): Initialize to NULL.
2547         (completion_tracker::m_lowest_common_denominator_valid): New
2548         member variable.
2549         (completion_tracker::m_lowest_common_denominator_max_length): New
2550         member variable.
2551
2552 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2553
2554         * regformats/regdef.h: Put reg in gdb namespace.
2555
2556 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2557
2558         * i386-bsd-nat.c (gdb_ptrace): New.
2559         * (i386bsd_fetch_inferior_registers,
2560         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2561         * (i386bsd_fetch_inferior_registers,
2562         i386bsd_store_inferior_registers) Use gdb_ptrace.
2563
2564 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2565
2566         * amd64-bsd-nat.c (gdb_ptrace): New.
2567         * (amd64bsd_fetch_inferior_registers,
2568         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2569         * (amd64bsd_fetch_inferior_registers,
2570         amd64bsd_store_inferior_registers) Use gdb_ptrace.
2571
2572 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2573
2574         * user-regs.c (user_reg::read): Rename to...
2575         (user_reg::xread): ...this.
2576         * (append_user_reg): Rename argument `read' to `xread'.
2577         * (user_reg_add_builtin): Likewise.
2578         * (user_reg_add): Likewise.
2579         * (value_of_user_reg): Likewise.
2580
2581 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2582
2583         * sparc-nat.c (gdb_ptrace): New.
2584         * sparc-nat.c (sparc_fetch_inferior_registers)
2585         (sparc_store_inferior_registers) Remove obsolete comment.
2586         * sparc-nat.c (sparc_fetch_inferior_registers)
2587         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
2588         * sparc-nat.c (sparc_fetch_inferior_registers)
2589         (sparc_store_inferior_registers) Use gdb_ptrace.
2590
2591 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2592
2593         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
2594         it to the ptrace call.
2595         * sh-nbsd-nat.c (store_registers): Likewise.
2596
2597 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2598
2599         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
2600         nbsd_nat_target instead of inf_ptrace_target.
2601         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2602         nbsd_nat_target.
2603
2604 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2605
2606         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
2607
2608 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2609
2610         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
2611         <sys/sysctl.h>.
2612         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
2613
2614 2020-03-17  Tom de Vries  <tdevries@suse.de>
2615
2616         PR gdb/23710
2617         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
2618         fields.
2619         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
2620         fields.
2621         (process_imported_unit_die): Skip import of c++ CUs.
2622
2623 2020-03-16  Tom Tromey  <tom@tromey.com>
2624
2625         * p-valprint.c (pascal_object_print_value): Initialize
2626         base_value.
2627
2628 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
2629             Shahab Vahedi  <shahab@synopsys.com>
2630
2631         * Makefile.in: Add arch/arc.o
2632         * configure.tgt: Likewise.
2633         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
2634         (_initialize_arc_tdep): Don't initialize old target descriptions.
2635         (arc_read_description): New function to cache target descriptions.
2636         * arc-tdep.h (arc_read_description): Add proto type.
2637         * arch/arc.c: New file.
2638         * arch/arc.h: Likewise.
2639         * features/Makefile: Replace old target descriptions with new.
2640         * features/arc-arcompact.c: Remove.
2641         * features/arc-arcompact.xml: Likewise.
2642         * features/arc-v2.c: Likewise
2643         * features/arc-v2.xml: Likewise
2644         * features/arc/aux-arcompact.xml: New file.
2645         * features/arc/aux-v2.xml: Likewise.
2646         * features/arc/core-arcompact.xml: Likewise.
2647         * features/arc/core-v2.xml: Likewise.
2648         * features/arc/aux-arcompact.c: Generate.
2649         * features/arc/aux-v2.c: Likewise.
2650         * features/arc/core-arcompact.c: Likewise.
2651         * features/arc/core-v2.c: Likewise.
2652         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
2653
2654 2020-03-16  Tom Tromey  <tromey@adacore.com>
2655
2656         PR gdb/25663:
2657         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
2658         putting value into bcache.
2659
2660 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2661
2662         PR gdb/21500
2663         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
2664         to...
2665         (amd64_windows_init_abi_common): ... this.  Don't set size of
2666         long type.
2667         (amd64_windows_init_abi): New function.
2668         (amd64_cygwin_init_abi): New function.
2669         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
2670         the Cygwin OS ABI.
2671         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
2672         comment.
2673
2674 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2675
2676         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
2677         * windows-tdep.c (CYGWIN_DLL_NAME): New.
2678         (pe_import_directory_entry): New struct type.
2679         (is_linked_with_cygwin_dll): New function.
2680         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
2681         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
2682         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
2683
2684 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2685
2686         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
2687         i386_cygwin_core_osabi_sniffer.
2688
2689 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2690
2691         * i386-cygwin-tdep.c: Rename to...
2692         * i386-windows-tdep.c: ... this.
2693         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
2694         i386-windows-tdep.c.
2695         * configure.tgt: Likewise.
2696
2697 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2698
2699         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
2700         * osabi.c (gdb_osabi_names): Add "Windows".
2701         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
2702         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
2703         (i386_cygwin_core_osabi_sniffer): New function, extracted from
2704         i386_cygwin_osabi_sniffer.
2705         (_initialize_i386_cygwin_tdep): Register OS ABI
2706         GDB_OSABI_WINDOWS for i386.
2707         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
2708         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
2709         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
2710         for x86-64.
2711         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
2712         when the target matches '*-*-mingw*'.
2713
2714 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2715
2716         * defs.h (enum gdb_osabi): Move to...
2717         * osabi.h (enum gdb_osabi): ... here.
2718         * gdbarch.sh: Include osabi.h in gdbarch.h.
2719         * gdbarch.h: Re-generate.
2720
2721 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2722
2723         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
2724         function.
2725         (_initialize_amd64_windows_tdep): Register osabi sniffer.
2726
2727 2020-03-14  Tom Tromey  <tom@tromey.com>
2728
2729         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
2730         for C++.
2731         (c_type_print_modifier): Likewise.  Add "language" parameter.
2732         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
2733         (c_type_print_base_1): Update.
2734         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
2735         constants.
2736         * type-stack.c (type_stack::insert): Handle tp_atomic and
2737         tp_restrict.
2738         (type_stack::follow_type_instance_flags): Likewise.
2739         (type_stack::follow_types): Likewise.  Merge type-following code.
2740         * c-exp.y (RESTRICT, ATOMIC): New tokens.
2741         (space_identifier, cv_with_space_id)
2742         (const_or_volatile_or_space_identifier_noopt)
2743         (const_or_volatile_or_space_identifier): Remove.
2744         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
2745         rules.
2746         (ptr_operator, typebase): Update.
2747         (enum token_flag) <FLAG_C>: New constant.
2748         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
2749         "_Atomic".
2750         (lex_one_token): Handle FLAG_C.
2751
2752 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2753
2754         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
2755         it to the ptrace call.
2756         * m68k-bsd-nat.c (store_registers): Likewise.
2757
2758 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2759
2760         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
2761         gdb_byte *.
2762         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
2763         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
2764         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
2765
2766 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2767
2768         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
2769         nbsd_nat_target instead of inf_ptrace_target.
2770         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2771         nbsd_nat_target.
2772
2773 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2774
2775         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
2776         register_t.
2777
2778 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2779
2780         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
2781         it to the ptrace call.
2782         * alpha-bsd-nat.c (store_registers): Likewise.
2783
2784 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2785
2786         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
2787         includes.
2788         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
2789         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
2790         fill_fpregset): Likewise.
2791
2792 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2793
2794         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
2795         nbsd_nat_target instead of inf_ptrace_target.
2796         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2797         nbsd_nat_target.
2798
2799 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2800
2801         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
2802         register_t.
2803
2804 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2805
2806         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
2807         it to the ptrace call.
2808         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
2809         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
2810         * arm-nbsd-nat.c (store_register): Likewise.
2811         * arm-nbsd-nat.c (store_regs): Likewise.
2812         * arm-nbsd-nat.c (store_fp_register): Likewise.
2813         * arm-nbsd-nat.c (store_fp_regs): Likewise.
2814
2815 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2816
2817         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
2818         nbsd_nat_target instead of inf_ptrace_target.
2819         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2820         nbsd_nat_target.
2821
2822 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2823
2824         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
2825         it to the ptrace call.
2826         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
2827
2828 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2829
2830         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
2831         it to the ptrace call.
2832         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
2833
2834 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2835
2836         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
2837         gdb_byte *.
2838         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
2839
2840 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2841
2842         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
2843         instead of inf_ptrace_target.
2844         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2845         nbsd_nat_target.
2846
2847 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2848
2849         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2850         register_t.
2851
2852 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2853
2854         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2855         register_t.
2856
2857 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2858
2859         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
2860         register_t.
2861
2862 2020-03-13  Tom Tromey  <tom@tromey.com>
2863
2864         * value.h (val_print): Don't declare.
2865         * valprint.h (val_print_array_elements)
2866         (val_print_scalar_formatted, generic_val_print): Don't declare.
2867         * valprint.c (generic_val_print_array): Take a struct value.
2868         (generic_val_print_ptr, generic_val_print_memberptr)
2869         (generic_val_print_bool, generic_val_print_int)
2870         (generic_val_print_char, generic_val_print_complex)
2871         (generic_val_print): Remove.
2872         (generic_value_print): Update.
2873         (do_val_print): Remove unused parameters.  Don't call
2874         la_val_print.
2875         (val_print): Remove.
2876         (common_val_print): Update.  Don't call value_check_printable.
2877         (val_print_scalar_formatted, val_print_array_elements): Remove.
2878         * rust-lang.c (rust_val_print): Remove.
2879         (rust_language_defn): Update.
2880         * p-valprint.c (pascal_val_print): Remove.
2881         (pascal_value_print_inner): Update.
2882         (pascal_object_print_val_fields, pascal_object_print_val):
2883         Remove.
2884         (pascal_object_print_static_field): Update.
2885         * p-lang.h (pascal_val_print): Don't declare.
2886         * p-lang.c (pascal_language_defn): Update.
2887         * opencl-lang.c (opencl_language_defn): Update.
2888         * objc-lang.c (objc_language_defn): Update.
2889         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
2890         * m2-lang.h (m2_val_print): Don't declare.
2891         * m2-lang.c (m2_language_defn): Update.
2892         * language.h (struct language_defn) <la_val_print>: Remove.
2893         * language.c (unk_lang_value_print_inner): Rename.  Change
2894         argument types.
2895         (unknown_language_defn, auto_language_defn): Update.
2896         * go-valprint.c (go_val_print): Remove.
2897         * go-lang.h (go_val_print): Don't declare.
2898         * go-lang.c (go_language_defn): Update.
2899         * f-valprint.c (f_val_print): Remove.
2900         * f-lang.h (f_value_print): Don't declare.
2901         * f-lang.c (f_language_defn): Update.
2902         * d-valprint.c (d_val_print): Remove.
2903         * d-lang.h (d_value_print): Don't declare.
2904         * d-lang.c (d_language_defn): Update.
2905         * cp-valprint.c (cp_print_value_fields)
2906         (cp_print_value_fields_rtti, cp_print_value): Remove.
2907         (cp_print_static_field): Update.
2908         * c-valprint.c (c_val_print_array, c_val_print_ptr)
2909         (c_val_print_struct, c_val_print_union, c_val_print_int)
2910         (c_val_print_memberptr, c_val_print): Remove.
2911         * c-lang.h (c_val_print_array, cp_print_value_fields)
2912         (cp_print_value_fields_rtti): Don't declare.
2913         * c-lang.c (c_language_defn, cplus_language_defn)
2914         (asm_language_defn, minimal_language_defn): Update.
2915         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
2916         (ada_val_print_enum): Take a struct value.
2917         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
2918         (ada_val_print): Remove.
2919         (ada_value_print_1): Update.
2920         (printable_val_type): Remove.
2921         * ada-lang.h (ada_val_print): Don't declare.
2922         * ada-lang.c (ada_language_defn): Update.
2923
2924 2020-03-13  Tom Tromey  <tom@tromey.com>
2925
2926         * valprint.c (do_val_print): Update.
2927         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
2928         a struct value.
2929         (value_to_value_object_no_release): Declare.
2930         * python/py-value.c (value_to_value_object_no_release): New
2931         function.
2932         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
2933         struct value.
2934         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
2935         function.
2936         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
2937         a struct value.
2938         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
2939         Declare.
2940         (gdbscm_apply_val_pretty_printer): Take a struct value.
2941         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
2942         value.
2943         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
2944         value.
2945         * extension-priv.h (struct extension_language_ops)
2946         <apply_val_pretty_printer>: Take a struct value.
2947         * cp-valprint.c (cp_print_value): Create a struct value.
2948         (cp_print_value): Update.
2949
2950 2020-03-13  Tom Tromey  <tom@tromey.com>
2951
2952         * ada-valprint.c (print_field_values): Call common_val_print.
2953
2954 2020-03-13  Tom Tromey  <tom@tromey.com>
2955
2956         * ada-valprint.c (val_print_packed_array_elements): Remove
2957         bitoffset and val parameters.  Call common_val_print.
2958         (ada_val_print_string): Remove offset, address, and original_value
2959         parameters.
2960         (ada_val_print_array): Update.
2961         (ada_value_print_array): New function.
2962         (ada_value_print_1): Call it.
2963
2964 2020-03-13  Tom Tromey  <tom@tromey.com>
2965
2966         * ada-valprint.c (ada_value_print): Use common_val_print.
2967
2968 2020-03-13  Tom Tromey  <tom@tromey.com>
2969
2970         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
2971
2972 2020-03-13  Tom Tromey  <tom@tromey.com>
2973
2974         * ada-valprint.c (ada_value_print_num): New function.
2975         (ada_value_print_1): Use it.
2976
2977 2020-03-13  Tom Tromey  <tom@tromey.com>
2978
2979         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
2980
2981 2020-03-13  Tom Tromey  <tom@tromey.com>
2982
2983         * ada-valprint.c (ada_value_print_ptr): New function.
2984         (ada_value_print_1): Use it.
2985
2986 2020-03-13  Tom Tromey  <tom@tromey.com>
2987
2988         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
2989         call common_val_print.
2990         (ada_val_print_1): Update.
2991         (ada_value_print_1): New function.
2992         (ada_value_print_inner): Rewrite.
2993
2994 2020-03-13  Tom Tromey  <tom@tromey.com>
2995
2996         * cp-valprint.c (cp_print_value_fields): Update.
2997         (cp_print_value): New function.
2998
2999 2020-03-13  Tom Tromey  <tom@tromey.com>
3000
3001         * m2-valprint.c (m2_value_print_inner): Use
3002         cp_print_value_fields.
3003         * cp-valprint.c (cp_print_value_fields): New function.
3004         * c-valprint.c (c_value_print_struct): New function.
3005         (c_value_print_inner): Use c_value_print_struct.
3006         * c-lang.h (cp_print_value_fields): Declare.
3007
3008 2020-03-13  Tom Tromey  <tom@tromey.com>
3009
3010         * c-valprint.c (c_value_print_array): New function.
3011         (c_value_print_inner): Use it.
3012
3013 2020-03-13  Tom Tromey  <tom@tromey.com>
3014
3015         * c-valprint.c (c_value_print_memberptr): New function.
3016         (c_value_print_inner): Use it.
3017
3018 2020-03-13  Tom Tromey  <tom@tromey.com>
3019
3020         * c-valprint.c (c_value_print_int): New function.
3021         (c_value_print_inner): Use it.
3022
3023 2020-03-13  Tom Tromey  <tom@tromey.com>
3024
3025         * c-valprint.c (c_value_print_ptr): New function.
3026         (c_value_print_inner): Use it.
3027
3028 2020-03-13  Tom Tromey  <tom@tromey.com>
3029
3030         * c-valprint.c (c_value_print_inner): Rewrite.
3031
3032 2020-03-13  Tom Tromey  <tom@tromey.com>
3033
3034         * valprint.c (generic_value_print_complex): New function.
3035         (generic_value_print): Use it.
3036
3037 2020-03-13  Tom Tromey  <tom@tromey.com>
3038
3039         * valprint.c (generic_val_print_float): Don't call
3040         val_print_scalar_formatted.
3041         (generic_val_print, generic_value_print): Update.
3042
3043 2020-03-13  Tom Tromey  <tom@tromey.com>
3044
3045         * valprint.c (generic_value_print_char): New function
3046         (generic_value_print): Use it.
3047
3048 2020-03-13  Tom Tromey  <tom@tromey.com>
3049
3050         * valprint.c (generic_value_print_int): New function.
3051         (generic_value_print): Use it.
3052
3053 2020-03-13  Tom Tromey  <tom@tromey.com>
3054
3055         * valprint.c (generic_value_print_bool): New function.
3056         (generic_value_print): Use it.
3057
3058 2020-03-13  Tom Tromey  <tom@tromey.com>
3059
3060         * valprint.c (generic_val_print_func): Simplify.
3061         (generic_val_print, generic_value_print): Update.
3062
3063 2020-03-13  Tom Tromey  <tom@tromey.com>
3064
3065         * valprint.c (generic_val_print_flags): Remove.
3066         (generic_val_print, generic_value_print): Update.
3067         (val_print_type_code_flags): Add original_value parameter.
3068
3069 2020-03-13  Tom Tromey  <tom@tromey.com>
3070
3071         * valprint.c (generic_val_print): Update.
3072         (generic_value_print): Update.
3073         * valprint.c (generic_val_print_enum): Don't call
3074         val_print_scalar_formatted.
3075
3076 2020-03-13  Tom Tromey  <tom@tromey.com>
3077
3078         * valprint.c (generic_value_print): Call generic_value_print_ptr.
3079         * valprint.c (generic_value_print_ptr): New function.
3080
3081 2020-03-13  Tom Tromey  <tom@tromey.com>
3082
3083         * valprint.c (generic_value_print): Rewrite.
3084
3085 2020-03-13  Tom Tromey  <tom@tromey.com>
3086
3087         * p-valprint.c (pascal_object_print_value_fields)
3088         (pascal_object_print_value): New functions.
3089
3090 2020-03-13  Tom Tromey  <tom@tromey.com>
3091
3092         * p-valprint.c (pascal_value_print_inner): Rewrite.
3093
3094 2020-03-13  Tom Tromey  <tom@tromey.com>
3095
3096         * f-valprint.c (f_value_print_innner): Rewrite.
3097
3098 2020-03-13  Tom Tromey  <tom@tromey.com>
3099
3100         * m2-valprint.c (m2_print_unbounded_array): New overload.
3101         (m2_print_unbounded_array): Update.
3102         (m2_print_array_contents): Take a struct value.
3103         (m2_value_print_inner): Rewrite.
3104
3105 2020-03-13  Tom Tromey  <tom@tromey.com>
3106
3107         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
3108         (d_value_print_inner): New function.
3109         * d-lang.h (d_value_print_inner): Declare.
3110         * d-lang.c (d_language_defn): Use d_value_print_inner.
3111
3112 2020-03-13  Tom Tromey  <tom@tromey.com>
3113
3114         * go-valprint.c (go_value_print_inner): New function.
3115         * go-lang.h (go_value_print_inner): Declare.
3116         * go-lang.c (go_language_defn): Use go_value_print_inner.
3117
3118 2020-03-13  Tom Tromey  <tom@tromey.com>
3119
3120         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
3121         API.
3122         (rust_val_print): Rewrite.
3123         (rust_value_print_inner): New function, from rust_val_print.
3124         (rust_language_defn): Use rust_value_print_inner.
3125
3126 2020-03-13  Tom Tromey  <tom@tromey.com>
3127
3128         * ada-valprint.c (ada_value_print_inner): New function.
3129         * ada-lang.h (ada_value_print_inner): Declare.
3130         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
3131
3132 2020-03-13  Tom Tromey  <tom@tromey.com>
3133
3134         * f-valprint.c (f_value_print_innner): New function.
3135         * f-lang.h (f_value_print_innner): Declare.
3136         * f-lang.c (f_language_defn): Use f_value_print_innner.
3137
3138 2020-03-13  Tom Tromey  <tom@tromey.com>
3139
3140         * p-valprint.c (pascal_value_print_inner): New function.
3141         * p-lang.h (pascal_value_print_inner): Declare.
3142         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
3143
3144 2020-03-13  Tom Tromey  <tom@tromey.com>
3145
3146         * m2-valprint.c (m2_value_print_inner): New function.
3147         * m2-lang.h (m2_value_print_inner): Declare.
3148         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
3149
3150 2020-03-13  Tom Tromey  <tom@tromey.com>
3151
3152         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
3153         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
3154         * c-valprint.c (c_value_print_inner): New function.
3155         * c-lang.h (c_value_print_inner): Declare.
3156         * c-lang.c (c_language_defn, cplus_language_defn)
3157         (asm_language_defn, minimal_language_defn): Use
3158         c_value_print_inner.
3159
3160 2020-03-13  Tom Tromey  <tom@tromey.com>
3161
3162         * p-valprint.c (pascal_object_print_value_fields): Now static.
3163         * p-lang.h (pascal_object_print_value_fields): Don't declare.
3164
3165 2020-03-13  Tom Tromey  <tom@tromey.com>
3166
3167         * c-valprint.c (c_val_print_array): Simplify.
3168
3169 2020-03-13  Tom Tromey  <tom@tromey.com>
3170
3171         * valprint.c (value_print_array_elements): New function.
3172         * valprint.h (value_print_array_elements): Declare.
3173
3174 2020-03-13  Tom Tromey  <tom@tromey.com>
3175
3176         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
3177         * mips-tdep.c (mips_print_register): Use
3178         value_print_scalar_formatted.
3179
3180 2020-03-13  Tom Tromey  <tom@tromey.com>
3181
3182         * valprint.h (value_print_scalar_formatted): Declare.
3183         * valprint.c (value_print_scalar_formatted): New function.
3184
3185 2020-03-13  Tom Tromey  <tom@tromey.com>
3186
3187         * valprint.h (generic_value_print): Declare.
3188         * valprint.c (generic_value_print): New function.
3189
3190 2020-03-13  Tom Tromey  <tom@tromey.com>
3191
3192         * valprint.c (do_val_print): Call la_value_print_inner, if
3193         available.
3194         * rust-lang.c (rust_language_defn): Update.
3195         * p-lang.c (pascal_language_defn): Update.
3196         * opencl-lang.c (opencl_language_defn): Update.
3197         * objc-lang.c (objc_language_defn): Update.
3198         * m2-lang.c (m2_language_defn): Update.
3199         * language.h (struct language_defn) <la_value_print_inner>: New
3200         member.
3201         * language.c (unknown_language_defn, auto_language_defn): Update.
3202         * go-lang.c (go_language_defn): Update.
3203         * f-lang.c (f_language_defn): Update.
3204         * d-lang.c (d_language_defn): Update.
3205         * c-lang.c (c_language_defn, cplus_language_defn)
3206         (asm_language_defn, minimal_language_defn): Update.
3207         * ada-lang.c (ada_language_defn): Update.
3208
3209 2020-03-13  Tom Tromey  <tom@tromey.com>
3210
3211         * c-valprint.c (c_value_print): Use common_val_print.
3212
3213 2020-03-13  Tom Tromey  <tom@tromey.com>
3214
3215         * cp-valprint.c (cp_print_static_field): Use common_val_print.
3216
3217 2020-03-13  Tom Tromey  <tom@tromey.com>
3218
3219         * f-valprint.c (f77_print_array_1, f_val_print): Use
3220         common_val_print.
3221
3222 2020-03-13  Tom Tromey  <tom@tromey.com>
3223
3224         * riscv-tdep.c (riscv_print_one_register_info): Use
3225         common_val_print.
3226
3227 2020-03-13  Tom Tromey  <tom@tromey.com>
3228
3229         * mi/mi-main.c (output_register): Use common_val_print.
3230
3231 2020-03-13  Tom Tromey  <tom@tromey.com>
3232
3233         * infcmd.c (default_print_one_register_info): Use
3234         common_val_print.
3235
3236 2020-03-13  Tom Tromey  <tom@tromey.com>
3237
3238         * valprint.h (common_val_print_checked): Declare.
3239         * valprint.c (common_val_print_checked): New function.
3240         * stack.c (print_frame_arg): Use common_val_print_checked.
3241
3242 2020-03-13  Tom Tromey  <tom@tromey.com>
3243
3244         * valprint.c (do_val_print): New function, from val_print.
3245         (val_print): Use do_val_print.
3246         (common_val_print): Use do_val_print.
3247
3248 2020-03-13  Tom Tromey  <tom@tromey.com>
3249
3250         * valprint.c (value_print): Use scoped_value_mark.
3251
3252 2020-03-13  Tom de Vries  <tdevries@suse.de>
3253
3254         PR symtab/25646
3255         * psymtab.c (partial_symtab::partial_symtab): Don't set
3256         globals_offset and statics_offset.  Push element onto
3257         current_global_psymbols and current_static_psymbols stacks.
3258         (concat): New function.
3259         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
3260         element from current_global_psymbols and current_static_psymbols
3261         stacks.  Concat popped elements to global_psymbols and
3262         static_symbols.
3263         (add_psymbol_to_list): Use current_global_psymbols and
3264         current_static_psymbols stacks.
3265         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
3266         current_static_psymbols fields.
3267
3268 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
3269
3270         * corelow.c (sniff_core_bfd): Remove.
3271         (class core_target) <m_core_vec>: Remove.
3272         (core_target::core_target): Update.
3273         (core_file_fns): Remove.
3274         (deprecated_add_core_fns): Remove.
3275         (default_core_sniffer): Remove.
3276         (sniff_core_bfd): Remove.
3277         (default_check_format): Remove.
3278         (gdb_check_format): Remove.
3279         (core_target_open): Update.
3280         (core_target::get_core_register_section): Update.
3281         (get_core_registers_cb): Update.
3282         (core_target::fetch_registers): Update.
3283         * gdbcore.h (struct core_fns): Remove.
3284         (deprecated_add_core_fns): Remove.
3285         (default_core_sniffer): Remove.
3286         (default_check_format): Remove.
3287
3288 2020-03-12  Tom Tromey  <tom@tromey.com>
3289
3290         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
3291         CORE_ADDR.
3292         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
3293
3294 2020-03-12  Tom Tromey  <tom@tromey.com>
3295
3296         * remote.c (remote_target::download_tracepoint)
3297         (remote_target::enable_tracepoint)
3298         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
3299         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
3300         sprintf_vma.
3301
3302 2020-03-12  Tom Tromey  <tom@tromey.com>
3303
3304         * symfile-mem.c: Update CORE_ADDR size assert.
3305
3306 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3307
3308         * selftest.m4: Move to gdbsupport/.
3309         * acinclude.m4: Update path to selftest.m4.
3310
3311 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3312
3313         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
3314         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
3315         gdbarch-selfselftests.c and selftest-arch.c.
3316         (SUBDIR_UNITTESTS_OBS): Rename to...
3317         (SELFTESTS_OBS): ... this.
3318         (COMMON_SFILES): Remove disasm-selftests.c and
3319         gdbarch-selftests.c.
3320         * configure.ac: Don't add selftest-arch.{c,o} to
3321         CONFIG_{SRCS,OBS}.
3322         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
3323         preprocessor conditions.
3324
3325 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3326
3327         * configure.ac: Don't source bfd/development.sh.
3328         * selftest.m4: Modify comment.
3329         * configure: Re-generate.
3330
3331 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3332
3333         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
3334         not "true" or "false".
3335         * configure: Re-generate.
3336
3337 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
3338
3339         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
3340         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
3341         renamed to arm_nbsd_supply_gregset.
3342         (fetch_register): Update to call arm_nbsd_supply_gregset.
3343         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
3344         (arm_netbsd_nat_target::fetch_registers): Update.
3345         (fetch_elfcore_registers): Removed.
3346         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
3347         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
3348         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
3349         not require NetBSD system headers.
3350         (arm_nbsd_regset): New struct.
3351         (arm_nbsd_iterate_over_regset_sections): New function.
3352         (arm_netbsd_init_abi_common): Updated to call
3353         set_gdbarch_iterate_over_regset_sections.
3354         * arm-nbsd-tdep.h: New file.
3355
3356 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
3357
3358         * symtab.c (find_pc_sect_line): Add check which prevents infinite
3359         recursion.
3360
3361 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
3362
3363         * configure: Re-generate.
3364
3365 2020-03-11  Tom Tromey  <tromey@adacore.com>
3366
3367         * ada-typeprint.c (print_choices): Fix comment.
3368
3369 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3370
3371         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
3372         previous item in the list, when the list has no items.
3373
3374 2020-03-11  Tom de Vries  <tdevries@suse.de>
3375
3376         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
3377         PROP_LOCLIST handling code.
3378
3379 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3380
3381         * buildsym-legacy.c (record_line): Pass extra parameter to
3382         record_line.
3383         * buildsym.c (buildsym_compunit::record_line): Take an extra
3384         parameter, reduce duplication in the line table, and record the
3385         is_stmt flag in the line table.
3386         * buildsym.h (buildsym_compunit::record_line): Add extra
3387         parameter.
3388         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
3389         non-statement lines.
3390         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
3391         this to the symtab builder.
3392         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
3393         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
3394         through to dwarf_record_line_1.
3395         * infrun.c (process_event_stop_test): When stepping, don't stop at
3396         a non-statement instruction, and only refresh the step info when
3397         we land in the middle of a line's range.  Also add an extra
3398         comment.
3399         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
3400         field.
3401         * record-btrace.c (btrace_find_line_range): Only record lines
3402         marked as is-statement.
3403         * stack.c (frame_show_address): Show the frame address if we are
3404         in a non-statement sal.
3405         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
3406         (maintenance_print_one_line_table): Print a header for the is_stmt
3407         column, and include is_stmt information in the output.
3408         * symtab.c (find_pc_sect_line): Find lines marked as statements in
3409         preference to non-statements.
3410         (find_pcs_for_symtab_line): Prefer is-statement entries.
3411         (find_line_common): Likewise.
3412         * symtab.h (struct linetable_entry): Add is_stmt field.
3413         (struct symtab_and_line): Likewise.
3414         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
3415         arranging the line table.
3416
3417 2020-03-07  Tom de Vries  <tdevries@suse.de>
3418
3419         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
3420         DIE.
3421
3422 2020-03-07  Tom Tromey  <tom@tromey.com>
3423
3424         * valops.c (value_literal_complex): Remove obsolete comment.
3425         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
3426         comment.
3427
3428 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
3429
3430         * infrun.h: Forward-declare thread_info.
3431         (set_step_info): Add thread_info parameter, add doc.
3432         * infrun.c (set_step_info): Add thread_info parameter, move doc
3433         to header.
3434         * infrun.c (process_event_stop_test): Pass thread to
3435         set_step_info call.
3436         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
3437         set_step_info.
3438         (prepare_one_step): Add thread_info parameter, pass it to
3439         set_step_frame and prepare_one_step (recursive) call.
3440         (step_1): Pass thread to prepare_one_step call.
3441         (step_command_fsm::should_stop): Pass thread to
3442         prepare_one_step.
3443         (until_next_fsm): Pass thread to set_step_frame call.
3444         (finish_command): Pass thread to set_step_info call.
3445
3446 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
3447
3448         * windows-tdep.c (windows_solib_create_inferior_hook):
3449         Check if inferior is running.
3450
3451 2020-03-06  Tom de Vries  <tdevries@suse.de>
3452
3453         * NEWS: Fix "the the".
3454         * ctfread.c: Same.
3455
3456 2020-03-06  Tom de Vries  <tdevries@suse.de>
3457
3458         * psymtab.c (psymtab_to_symtab): Don't print "done.".
3459
3460 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3461
3462         * .dir-locals.el: Add a comment referencing the other copies of
3463         this file.
3464
3465 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
3466
3467         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
3468         psargs.
3469
3470 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3471
3472         * .gitattributes: New file.
3473
3474 2020-03-04  Tom Tromey  <tom@tromey.com>
3475
3476         * symmisc.c (print_symbol_bcache_statistics)
3477         (print_objfile_statistics): Update.
3478         * symfile.c (allocate_symtab): Use intern.
3479         * psymtab.c (partial_symtab::partial_symtab): Use intern.
3480         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3481         macro_cache>: Remove.
3482         <string_cache>: New member.
3483         (struct objfile) <intern>: New methods.
3484         * elfread.c (elf_symtab_read): Use intern.
3485         * dwarf2/read.c (fixup_go_packaging): Intern package name.
3486         (dwarf2_compute_name, dwarf2_physname)
3487         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
3488         names.
3489         (guess_partial_die_structure_name): Update.
3490         (partial_die_info::fixup): Intern name.
3491         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
3492         name.
3493         (dwarf2_name): Intern name.  Update.
3494         * buildsym.c (buildsym_compunit::get_macro_table): Use
3495         string_cache.
3496
3497 2020-03-04  Tom Tromey  <tom@tromey.com>
3498
3499         * jit.c (bfd_open_from_target_memory): Make "target" const.
3500         * corefile.c (gnutarget): Now const.
3501         * gdbcore.h (gnutarget): Now const.
3502
3503 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
3504
3505         * NEWS: Mention support for WOW64 processes.
3506         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
3507         (amd64_windows_segment_register_p): Remove static.
3508         (_initialize_amd64_windows_nat): Update.
3509         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
3510         * i386-windows-nat.c (context_offset): Update.
3511         (i386_mappings): Rename and remove static.
3512         (i386_windows_segment_register_p): Remove static.
3513         (_initialize_i386_windows_nat): Update.
3514         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
3515         (STATUS_WX86_SINGLE_STEP): New macro.
3516         (EnumProcessModulesEx): New macro.
3517         (Wow64SuspendThread): New macro.
3518         (Wow64GetThreadContext): New macro.
3519         (Wow64SetThreadContext): New macro.
3520         (Wow64GetThreadSelectorEntry): New macro.
3521         (windows_set_context_register_offsets): Add static.
3522         (windows_set_segment_register_p): Likewise.
3523         (windows_add_thread): Adapt for WOW64 processes.
3524         (windows_fetch_one_register): Likewise.
3525         (windows_nat_target::fetch_registers): Likewise.
3526         (windows_store_one_register): Likewise.
3527         (display_selector): Likewise.
3528         (display_selectors): Likewise.
3529         (handle_exception): Likewise.
3530         (windows_continue): Likewise.
3531         (windows_nat_target::resume): Likewise.
3532         (windows_add_all_dlls): Likewise.
3533         (do_initial_windows_stuff): Likewise.
3534         (windows_nat_target::attach): Likewise.
3535         (windows_get_exec_module_filename): Likewise.
3536         (windows_nat_target::create_inferior): Likewise.
3537         (windows_xfer_siginfo): Likewise.
3538         (_initialize_loadable): Initialize Wow64SuspendThread,
3539         Wow64GetThreadContext, Wow64SetThreadContext,
3540         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
3541         * windows-nat.h (windows_set_context_register_offsets):
3542         Remove declaration.
3543         (windows_set_segment_register_p): Likewise.
3544         (i386_windows_segment_register_p): Add declaration.
3545         (amd64_windows_segment_register_p): Likewise.
3546
3547 2020-03-04  Luis Machado  <luis.machado@linaro.org>
3548
3549         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
3550         in "info registers" for AArch64/ARM.
3551
3552         The change caused "info registers" to not print GPR's.
3553
3554         gdb/ChangeLog:
3555
3556         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
3557
3558         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
3559         when reg->group is empty and reggroup is not.
3560
3561 2020-03-03  Tom Tromey  <tromey@adacore.com>
3562
3563         * dwarf2/frame.c (struct dwarf2_frame_cache)
3564         <checked_tailcall_bottom, entry_cfa_sp_offset,
3565         entry_cfa_sp_offset_p>: Remove members.
3566         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
3567         (dwarf2_frame_prev_register): Don't call
3568         dwarf2_tailcall_sniffer_first.
3569         (dwarf2_append_unwinders): Don't append tailcall unwinder.
3570         * frame-unwind.c (add_unwinder): New fuction.
3571         (frame_unwind_init): Use it.  Add tailcall unwinder.
3572
3573 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3574             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
3575
3576         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
3577         value should be printed as true.
3578
3579 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
3580
3581         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
3582         (windows_init_abi): Set and use windows_so_ops.
3583
3584 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
3585
3586         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
3587         when verifying if dealing with a convenience variable.
3588
3589 2020-03-03  Luis Machado  <luis.machado@linaro.org>
3590
3591         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
3592
3593 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
3594
3595         * infrun.c (gdbarch_supports_displaced_stepping): New.
3596         (use_displaced_stepping): Break up conditions in smaller pieces.
3597         Use gdbarch_supports_displaced_stepping.
3598         (displaced_step_prepare_throw): Use
3599         gdbarch_supports_displaced_stepping.
3600
3601 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3602
3603         * NEWS: Mention new behaviour of the history filename.
3604         * top.c (write_history_p): Add comment.
3605         (show_write_history_p): Add header comment, give a different
3606         message when history writing is on, but the history filename is
3607         empty.
3608         (history_filename): Add comment.
3609         (history_filename_empty): New function.
3610         (show_history_filename): Add header comment, give a different
3611         message when the filename is empty.
3612         (init_history): Compare history_filename against nullptr, and only
3613         read history if the filename is not empty.
3614         (set_history_filename): Add header comment, and only make
3615         non-empty filenames absolute.
3616         (init_main): Make the filename argument to 'set history filename'
3617         optional.
3618
3619 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
3620
3621         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
3622         (arm_supply_vfpregset): ...this, and update to use VFP registers.
3623         (fetch_fp_register): Update.
3624         (fetch_fp_regs): Update.
3625         (store_fp_register): Update.
3626         (store_fp_regs): Update.
3627         (arm_netbsd_nat_target::read_description): New function.
3628         (fetch_elfcore_registers): Update.
3629
3630 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3631
3632         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
3633         general_thread if the stop reply is missing a thread-id.
3634         (remote_target::process_stop_reply): Use the first non-exited
3635         thread if the target didn't pass a thread-id.
3636         * infrun.c (do_target_wait): Move call to
3637         switch_to_inferior_no_thread to ....
3638         (do_target_wait_1): ... here.
3639
3640 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
3641
3642         * debuginfod-support.c: Include defs.h first.
3643
3644 2020-02-28  Tom de Vries  <tdevries@suse.de>
3645
3646         * symfile.c (set_initial_language): Use default language for lookup.
3647
3648 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
3649
3650         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
3651         reader variable, pass `this` to read_cutu_die_from_dwo.
3652
3653 2020-02-27  Aaron Merey  <amerey@redhat.com>
3654
3655         * source.c (open_source_file): Check for nullptr when computing
3656         srcpath.
3657
3658 2020-02-27  Tom Tromey  <tromey@adacore.com>
3659
3660         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
3661         member.
3662         (dwarf2_add_field): Don't update nfields.
3663         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
3664
3665 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3666
3667         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
3668         abs.
3669
3670 2020-02-26  Tom Tromey  <tom@tromey.com>
3671
3672         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
3673         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
3674         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
3675         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
3676         per_cu_data.
3677
3678 2020-02-26  Tom Tromey  <tom@tromey.com>
3679
3680         * dwarf2/index-write.c (psym_index_map): Change type.
3681         (add_address_entry_worker, write_one_signatured_type)
3682         (recursively_count_psymbols, recursively_write_psymbols)
3683         (class debug_names, psyms_seen_size, write_gdbindex)
3684         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
3685
3686 2020-02-26  Aaron Merey  <amerey@redhat.com>
3687
3688         * Makefile.in: Handle optional debuginfod support.
3689         * NEWS: Update.
3690         * README: Add --with-debuginfod summary.
3691         * config.in: Regenerate.
3692         * configure: Regenerate.
3693         * configure.ac: Handle optional debuginfod support.
3694         * debuginfod-support.c: debuginfod helper functions.
3695         * debuginfod-support.h: Ditto.
3696         * doc/gdb.texinfo: Add --with-debuginfod to configure options
3697         summary.
3698         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
3699         when a dwz file cannot be found.
3700         * elfread.c (elf_symfile_read): Query debuginfod servers when a
3701         debuginfo file cannot be found.
3702         * source.c (open_source_file): Query debuginfod servers when a
3703         source file cannot be found.
3704         * top.c (print_gdb_configuration): Include
3705         --{with,without}-debuginfod in the output.
3706
3707 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
3708
3709         * thread.c (thr_try_catch_cmd): Print thread name.
3710
3711 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
3712
3713         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
3714         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3715         dwarf2_fetch_die_type_sect_off): Move to...
3716         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
3717         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3718         dwarf2_fetch_die_type_sect_off): ... here.
3719         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
3720         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3721         dwarf2_fetch_die_type_sect_off): Move doc to header file.
3722
3723 2020-02-26  Tom de Vries  <tdevries@suse.de>
3724
3725         PR gdb/25603
3726         * symfile.c (set_initial_language): Exit-early if
3727         language_mode == language_mode_manual.
3728
3729 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3730
3731         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
3732         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
3733         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
3734
3735 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
3736
3737         * gdbtypes.c (create_array_type_with_stride): Handle negative
3738         array strides.
3739         * valarith.c (value_subscripted_rvalue): Likewise.
3740
3741 2020-02-25  Luis Machado  <luis.machado@linaro.org>
3742
3743         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
3744
3745 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3746
3747         * loc.h (dwarf2_get_die_type): Move to...
3748         * read.h (dwarf2_get_die_type): ... here.
3749         * read.c (dwarf2_get_die_type): Move doc to header.
3750
3751 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
3752
3753         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
3754         'gnulib/Makefile.in' to the list.
3755
3756 2020-02-24  Tom Tromey  <tom@tromey.com>
3757
3758         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
3759         Remove.
3760         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
3761         XOBNEWVEC.
3762
3763 2020-02-24  Tom Tromey  <tom@tromey.com>
3764
3765         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
3766         New method.
3767         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
3768         (dw2_do_instantiate_symtab, dw2_get_file_names)
3769         (build_type_psymtab_dependencies, load_full_type_unit): Update.
3770
3771 2020-02-24  Tom Tromey  <tom@tromey.com>
3772
3773         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
3774         make_scoped_restore.
3775         (dwarf2_psymtab::read_symtab): Don't clear
3776         reading_partial_symbols.
3777
3778 2020-02-24  Tom de Vries  <tdevries@suse.de>
3779
3780         PR gdb/25592
3781         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
3782
3783 2020-02-24  Tom de Vries  <tdevries@suse.de>
3784
3785         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
3786         commands layout next/prev/regs.
3787
3788 2020-02-22  Tom Tromey  <tom@tromey.com>
3789
3790         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
3791         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
3792
3793 2020-02-22  Tom Tromey  <tom@tromey.com>
3794
3795         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
3796
3797 2020-02-22  Tom Tromey  <tom@tromey.com>
3798
3799         * tui/tui-win.c (_initialize_tui_win): Add usage text.
3800         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
3801         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
3802         * tui/tui.c (_initialize_tui): Add usage text.
3803
3804 2020-02-22  Tom Tromey  <tom@tromey.com>
3805
3806         * tui/tui-win.c (tui_set_focus_command)
3807         (tui_set_win_height_command): Use error_no_arg.
3808         (_initialize_tui_win): Update help text.
3809         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
3810
3811 2020-02-22  Tom Tromey  <tom@tromey.com>
3812
3813         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
3814         * tui/tui-disasm.h (struct tui_disasm_window)
3815         <display_start_addr>: Declare.
3816         * tui/tui-source.h (struct tui_source_window)
3817         <display_start_addr>: Declare.
3818         * tui/tui-winsource.h (struct tui_source_window_base)
3819         <show_source_line, display_start_addr>: New methods.
3820         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
3821         Rename and move to protected section.
3822         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
3823         (tui_source_window_base::do_erase_source_content): Update.
3824         (tui_source_window_base::show_source_line): Now a method.
3825         (tui_source_window_base::show_source_content)
3826         (tui_source_window_base::tui_source_window_base)
3827         (tui_source_window_base::rerender)
3828         (tui_source_window_base::refill)
3829         (tui_source_window_base::do_scroll_horizontal)
3830         (tui_source_window_base::set_is_exec_point_at)
3831         (tui_source_window_base::update_breakpoint_info)
3832         (tui_source_window_base::update_exec_info): Update.
3833         * tui/tui-source.c (tui_source_window::set_contents)
3834         (tui_source_window::showing_source_p)
3835         (tui_source_window::do_scroll_vertical)
3836         (tui_source_window::location_matches_p)
3837         (tui_source_window::line_is_displayed): Update.
3838         (tui_source_window::display_start_addr): New method.
3839         * tui/tui-disasm.c (tui_disasm_window::set_contents)
3840         (tui_disasm_window::do_scroll_vertical)
3841         (tui_disasm_window::location_matches_p): Update.
3842         (tui_disasm_window::display_start_addr): New method.
3843
3844 2020-02-22  Tom Tromey  <tom@tromey.com>
3845
3846         * NEWS: Add entry for gdb.register_window_type.
3847         * tui/tui-layout.h (window_factory): New typedef.
3848         (tui_register_window): Declare.
3849         * tui/tui-layout.c (saved_tui_windows): New global.
3850         (tui_apply_current_layout): Use it.
3851         (tui_register_window): New function.
3852         * python/python.c (do_start_initialization): Call
3853         gdbpy_initialize_tui.
3854         (python_GdbMethods): Add "register_window_type" function.
3855         * python/python-internal.h (gdbpy_register_tui_window)
3856         (gdbpy_initialize_tui): Declare.
3857         * python/py-tui.c: New file.
3858         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
3859
3860 2020-02-22  Tom Tromey  <tom@tromey.com>
3861
3862         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
3863
3864 2020-02-22  Tom Tromey  <tom@tromey.com>
3865
3866         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
3867         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
3868         * tui/tui-data.c (tui_set_win_with_focus): Remove.
3869         (tui_set_win_focus_to): Move from tui-win.c.
3870
3871 2020-02-22  Tom Tromey  <tom@tromey.com>
3872
3873         * tui/tui-layout.c (make_standard_window, get_locator_window): New
3874         functions.
3875         (known_window_types): New global.
3876         (tui_get_window_by_name): Reimplement.
3877         (initialize_known_windows): New function.
3878         (validate_window_name): Rewrite.
3879         (_initialize_tui_layout): Call initialize_known_windows.
3880
3881 2020-02-22  Tom Tromey  <tom@tromey.com>
3882
3883         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
3884         Remove constants.
3885         * tui/tui-winsource.h (struct tui_source_window_base)
3886         <tui_source_window_base>: Remove parameter.
3887         * tui/tui-winsource.c
3888         (tui_source_window_base::tui_source_window_base): Remove
3889         parameter.
3890         (tui_source_window_base::refill): Update.
3891         * tui/tui-stack.h (struct tui_locator_window)
3892         <tui_locator_window>: Update.
3893         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
3894         Default the constructor.
3895         * tui/tui-regs.h (struct tui_data_item_window)
3896         <tui_data_item_window>: Default the constructor.
3897         (struct tui_data_window) <tui_data_window>: Likewise.
3898         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
3899         Default the constructor.
3900         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
3901         Default the constructor.
3902         <type>: Remove.
3903         (struct tui_win_info) <tui_win_info>: Default the constructor.
3904         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
3905         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
3906         Default the constructor.
3907
3908 2020-02-22  Tom Tromey  <tom@tromey.com>
3909
3910         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
3911         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
3912         * tui/tui-win.c (tui_resize_all): Don't call
3913         tui_delete_invisible_windows.
3914         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
3915         done.
3916         (tui_set_layout): Update.
3917         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
3918         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
3919         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
3920
3921 2020-02-22  Tom Tromey  <tom@tromey.com>
3922
3923         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
3924         correctly.
3925
3926 2020-02-22  Tom Tromey  <tom@tromey.com>
3927
3928         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
3929
3930 2020-02-22  Tom Tromey  <tom@tromey.com>
3931
3932         * tui/tui-winsource.h (struct tui_source_window_iterator)
3933         <inner_iterator>: New etytypedef.
3934         <tui_source_window_iterator>: Take "end" parameter.
3935         <tui_source_window_iterator>: Take iterator.
3936         <operator*, advance>: Update.
3937         <m_iter>: Change type.
3938         <m_end>: New field.
3939         (struct tui_source_windows) <begin, end>: Update.
3940         * tui/tui-layout.c (tui_windows): New global.
3941         (tui_apply_current_layout): Clear tui_windows.
3942         (tui_layout_window::apply): Update tui_windows.
3943         * tui/tui-data.h (tui_windows): Declare.
3944         (all_tui_windows): Now inline function.
3945         (class tui_window_iterator, struct all_tui_windows): Remove.
3946
3947 2020-02-22  Tom Tromey  <tom@tromey.com>
3948
3949         PR tui/17850:
3950         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
3951         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
3952         "height" argument.
3953         (class tui_layout_window) <get_sizes>: Likewise.
3954         (class tui_layout_split) <tui_layout_split>: Add "vertical"
3955         argument.
3956         <get_sizes>: Add "height" argument.
3957         <m_vertical>: New field.
3958         * tui/tui-layout.c (tui_layout_split::clone): Update.
3959         (tui_layout_split::get_sizes): Add "height" argument.
3960         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
3961         (tui_new_layout_command): Parse "-horizontal".
3962         (_initialize_tui_layout): Update help string.
3963         (tui_layout_split::specification): Add "-horizontal" when needed.
3964         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
3965         argument.
3966         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
3967         New methods.
3968
3969 2020-02-22  Tom Tromey  <tom@tromey.com>
3970
3971         * tui/tui-layout.h (enum tui_adjust_result): New.
3972         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
3973         (class tui_layout_window) <adjust_size>: Return
3974         tui_adjust_result.  Rewrite.
3975         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
3976         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
3977
3978 2020-02-22  Tom Tromey  <tom@tromey.com>
3979
3980         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
3981         parameter and return types.
3982         (class tui_layout_base) <specification>: Add "depth".
3983         (class tui_layout_window) <specification>: Add "depth".
3984         (class tui_layout_split) <specification>: Add "depth".
3985         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
3986         and return types.
3987         (tui_new_layout_command): Parse sub-layouts.
3988         (_initialize_tui_layout): Update help string.
3989         (tui_layout_window::specification): Add "depth".
3990         (add_layout_command): Update.
3991
3992 2020-02-22  Tom Tromey  <tom@tromey.com>
3993
3994         * NEWS: Add "tui new-layout" item.
3995         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
3996         Add new-layout command to help text.
3997         (validate_window_name): New function.
3998         (tui_new_layout_command): New function.
3999         (_initialize_tui_layout): Register "new-layout".
4000         (tui_layout_window::specification): New method.
4001         (tui_layout_window::specification): New method.
4002         * tui/tui-layout.h (class tui_layout_base) <specification>: New
4003         method.
4004         (class tui_layout_window) <specification>: New method.
4005         (class tui_layout_split) <specification>: New method.
4006
4007 2020-02-22  Tom Tromey  <tom@tromey.com>
4008
4009         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
4010         * tui/tui-win.c (window_name_completer): Update comment.
4011         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
4012         Declare method.
4013         (class tui_layout_window) <replace_window>: Likewise.
4014         (class tui_layout_split) <replace_window>: Likewise.
4015         (tui_set_layout): Don't declare.
4016         (tui_set_initial_layout): Declare function.
4017         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
4018         (asm_regs_layout): New globals.
4019         (tui_current_layout, show_layout): Remove.
4020         (tui_set_layout, tui_add_win_to_layout): Rewrite.
4021         (find_layout, tui_apply_layout): New function.
4022         (layout_completer): Remove.
4023         (tui_next_layout): Reimplement.
4024         (tui_next_layout_command): New function.
4025         (tui_set_initial_layout, tui_prev_layout_command): New functions.
4026         (tui_regs_layout): Reimplement.
4027         (tui_regs_layout_command): New function.
4028         (extract_display_start_addr): Rewrite.
4029         (next_layout, prev_layout): Remove.
4030         (tui_layout_window::replace_window): New method.
4031         (tui_layout_split::replace_window): New method.
4032         (destroy_layout): New function.
4033         (layout_list): New global.
4034         (add_layout_command): New function.
4035         (initialize_layouts): Update.
4036         (tui_layout_command): New function.
4037         (_initialize_tui_layout): Install "layout" commands.
4038         * tui/tui-data.h (enum tui_layout_type): Remove.
4039         (tui_current_layout): Don't declare.
4040
4041 2020-02-22  Tom Tromey  <tom@tromey.com>
4042
4043         * tui/tui-regs.c (tui_reg_layout): Remove.
4044         (tui_reg_command): Use tui_regs_layout.
4045         * tui/tui-layout.h (tui_reg_command): Declare.
4046         * tui/tui-layout.c (tui_reg_command): New function.
4047
4048 2020-02-22  Tom Tromey  <tom@tromey.com>
4049
4050         * tui/tui.c (tui_rl_delete_other_windows): Call
4051         tui_remove_some_windows.
4052         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
4053         Declare method.
4054         (class tui_layout_window) <remove_windows>: New method.
4055         (class tui_layout_split) <remove_windows>: Declare.
4056         (tui_remove_some_windows): Declare.
4057         * tui/tui-layout.c (tui_remove_some_windows): New function.
4058         (tui_layout_split::remove_windows): New method.
4059
4060 2020-02-22  Tom Tromey  <tom@tromey.com>
4061
4062         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
4063         * tui/tui-layout.h (tui_next_layout): Declare.
4064         * tui/tui-layout.c (tui_next_layout): New function.
4065
4066 2020-02-22  Tom Tromey  <tom@tromey.com>
4067
4068         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
4069         correct coordinates.
4070
4071 2020-02-22  Tom Tromey  <tom@tromey.com>
4072
4073         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
4074         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
4075         DATA_WIN case.
4076
4077 2020-02-22  Tom Tromey  <tom@tromey.com>
4078
4079         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
4080         TUI_DISASM_WIN, not tui_win_list.
4081
4082 2020-02-22  Tom Tromey  <tom@tromey.com>
4083
4084         * valprint.c (generic_val_print_enum_1)
4085         (val_print_type_code_flags): Style member names.
4086         * rust-lang.c (val_print_struct, rust_print_enum)
4087         (rust_print_struct_def, rust_internal_print_type): Style member
4088         names.
4089         * p-valprint.c (pascal_object_print_value_fields): Style member
4090         names.  Only call fprintf_symbol_filtered for static members.
4091         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
4092         * f-valprint.c (f_val_print): Style member names.
4093         * f-typeprint.c (f_type_print_base): Style member names.
4094         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
4095         call fprintf_symbol_filtered for static members.
4096         (cp_print_class_member): Style member names.
4097         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
4098         member names.
4099         * ada-valprint.c (ada_print_scalar): Style enum names.
4100         (ada_val_print_enum): Likewise.
4101         * ada-typeprint.c (print_enum_type): Style enum names.
4102
4103 2020-02-21  Tom Tromey  <tom@tromey.com>
4104
4105         * psympriv.h (struct partial_symtab): Update comment.
4106
4107 2020-02-21  Tom Tromey  <tromey@adacore.com>
4108
4109         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
4110         type is CORE_ADDR.
4111
4112 2020-02-21  Tom de Vries  <tdevries@suse.de>
4113
4114         PR gdb/25534
4115         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
4116         if dependencies[i]->user != NULL.
4117
4118 2020-02-21  Ali Tamur  <tamur@google.com>
4119
4120         * dwarf2/read.c (dwarf2_name): Add null check.
4121
4122 2020-02-20  Tom Tromey  <tom@tromey.com>
4123
4124         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
4125         ">=", in binary search.
4126         (dwarf2_find_containing_comp_unit): New overload.
4127         (run_test): New self-test.
4128         (_initialize_dwarf2_read): Register new test.
4129
4130 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
4131
4132         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
4133         * riscv-tdep.h: Likewise.
4134         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
4135         rv32-only CSR.
4136         * features/riscv/64bit-csr.xml: Regenerated.
4137
4138 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
4139             Tom Tromey  <tom@tromey.com>
4140
4141         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
4142         of 'fputc_unfiltered'.
4143         (putchar_unfiltered): Call 'fputc_unfiltered'.
4144         (fputc_unfiltered): Call 'fputs_unfiltered'.
4145
4146 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
4147
4148         * config.in: Regenerate.
4149         * configure: Regenerate.
4150         * configure.ac: Add --with-python-libdir option.
4151         * main.c: Use WITH_PYTHON_LIBDIR.
4152
4153 2020-02-19  Tom Tromey  <tom@tromey.com>
4154
4155         * symtab.c (general_symbol_info::compute_and_set_names): Use
4156         obstack_strndup.  Simplify call to symbol_set_demangled_name.
4157
4158 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
4159
4160         * dwarf2/read.c (allocate_signatured_type_table,
4161         allocate_dwo_unit_table, allocate_type_unit_groups_table,
4162         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
4163         Remove objfile parameter, update all callers.
4164
4165 2020-02-19  Doug Evans  <dje@google.com>
4166
4167         PR rust/25535
4168         * rust-lang.c (rust_print_enum): Apply embedded_offset to
4169         rust_enum_variant calculation.
4170
4171 2020-02-19  Tom Tromey  <tromey@adacore.com>
4172
4173         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
4174
4175 2020-02-19  Tom Tromey  <tromey@adacore.com>
4176
4177         * ada-lang.c (cache_symbol): Use obstack_strdup.
4178
4179 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4180
4181         * configure: Regenerate.
4182
4183 2020-02-19  Tom Tromey  <tromey@adacore.com>
4184
4185         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
4186         NULL check.
4187
4188 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
4189
4190         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
4191
4192 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4193
4194         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
4195         if GDBSERVER is not defined.
4196         (riscv_tdesc_cache): Likewise, also store const target_desc.
4197         (STATIC_IN_GDB): Define.
4198         (riscv_create_target_description): Update declaration with
4199         STATIC_IN_GDB.
4200         (riscv_lookup_target_description): New function, only define if
4201         GDBSERVER is not defined.
4202         * arch/riscv.h (riscv_create_target_description): Declare only
4203         when GDBSERVER is defined.
4204         (riscv_lookup_target_description): New declaration when GDBSERVER
4205         is not defined.
4206         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
4207         (riscv_linux_read_features): ...this, and return
4208         riscv_gdbarch_features instead of target_desc.
4209         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
4210         (riscv_linux_read_description): Rename to...
4211         (riscv_linux_read_features): ...this.
4212         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
4213         Update to use riscv_gdbarch_features and
4214         riscv_lookup_target_description.
4215         * riscv-tdep.c (riscv_find_default_target_description): Use
4216         riscv_lookup_target_description instead of
4217         riscv_create_target_description.
4218
4219 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4220
4221         * valprint.c (generic_val_print_enum_1): When printing a flag
4222         enum with value 0 and there is no enumerator with value 0, print
4223         just "0" instead of "(unknown: 0x0)".
4224
4225 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4226
4227         * valprint.c (generic_val_print_enum_1): Print unknown part of
4228         flag enum in hex.
4229
4230 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4231
4232         * dwarf2/read.c (update_enumeration_type_from_children): Allow
4233         flag enums to contain duplicate enumerators.
4234         * valprint.c (generic_val_print_enum_1): Update comment.
4235
4236 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4237
4238         * dwarf2/read.c: Include "count-one-bits.h".
4239         (update_enumeration_type_from_children): If an enumerator has
4240         multiple bits set, don't treat the enumeration as a "flag enum".
4241         * valprint.c (generic_val_print_enum_1): Assert that enumerators
4242         of flag enums have 0 or 1 bit set.
4243
4244 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4245
4246         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
4247         conversion.
4248         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
4249         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
4250         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4251         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
4252         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4253
4254 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4255
4256         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
4257
4258 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4259
4260         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
4261         displaced_step_closure_up.
4262         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
4263         (struct displaced_step_closure_up):
4264         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
4265         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
4266         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
4267         Likewise.
4268         * gdbarch.sh (displaced_step_copy_insn): Likewise.
4269         * gdbarch.c, gdbarch.h: Re-generate.
4270         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
4271         displaced_step_closure_up.
4272         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4273         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
4274         * infrun.h (displaced_step_closure_up): New type alias.
4275         (struct displaced_step_inferior_state) <step_closure>: Change
4276         type to displaced_step_closure_up.
4277         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
4278         displaced_step_closure_up.
4279         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4280
4281 2020-02-14  Tom Tromey  <tom@tromey.com>
4282
4283         * minidebug.c (gnu_debug_key): New global.
4284         (find_separate_debug_file_in_section): Use it.
4285
4286 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4287
4288         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
4289         std::unique_ptr.
4290         * gdbarch.c: Re-generate.
4291         * gdbarch.h: Re-generate.
4292         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
4293         change.
4294         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
4295         type to std::unique_ptr.
4296         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
4297         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
4298         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
4299         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
4300         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
4301         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4302         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
4303         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
4304         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4305
4306 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4307
4308         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
4309         std::unique_ptr.
4310         (displaced_step_clear): Rename to...
4311         (displaced_step_reset): ... this.  Just call displaced->reset ().
4312         (displaced_step_clear_cleanup): Rename to...
4313         (displaced_step_reset_cleanup): ... this.
4314         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
4315         (displaced_step_fixup): Likewise.
4316         (resume_1): Likewise.
4317         (handle_inferior_event): Restore child's memory before calling
4318         displaced_step_fixup on the parent.
4319         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
4320         to std::unique_ptr.
4321         <step_closure>: Change type to std::unique_ptr.
4322
4323 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4324
4325         * arm-tdep.c: Include count-one-bits.h.
4326         (cleanup_block_store_pc): Use count_one_bits.
4327         (cleanup_block_load_pc): Use count_one_bits.
4328         (arm_copy_block_xfer): Use count_one_bits.
4329         (thumb2_copy_block_xfer): Use count_one_bits.
4330         (thumb_copy_pop_pc_16bit): Use count_one_bits.
4331         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
4332         (thumb_get_next_pcs_raw): Use count_one_bits.
4333         (arm_get_next_pcs_raw): Use count_one_bits_l.
4334         * arch/arm.c (bitcount): Remove.
4335         * arch/arm.h (bitcount): Remove.
4336
4337 2020-02-14  Tom Tromey  <tromey@adacore.com>
4338
4339         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
4340         Update.
4341         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
4342         * dwarf2/loc.c (call_site_find_chain_1): Return
4343         unique_xmalloc_ptr.
4344         (call_site_find_chain): Likewise.
4345
4346 2020-02-14  Richard Biener  <rguenther@suse.de>
4347
4348         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
4349         on expression with division operators.
4350
4351 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
4352
4353         * MAINTAINERS (Write After Approval): Adding myself.
4354
4355 2020-02-12  Tom Tromey  <tom@tromey.com>
4356
4357         * event-loop.c (event_data, gdb_event, event_handler_func):
4358         Remove.
4359
4360 2020-02-12  Tom Tromey  <tom@tromey.com>
4361
4362         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
4363         (dwarf2_frame_objfile_data): Add comment.
4364         (find_comp_unit, set_comp_unit): New functions.
4365         (dwarf2_frame_find_fde): Use find_comp_unit.
4366         (dwarf2_build_frame_info): Use set_comp_unit.
4367
4368 2020-02-12  Tom Tromey  <tom@tromey.com>
4369
4370         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
4371         (comp_unit): Don't initialize objfile.
4372         (execute_cfa_program): Add text_offset parameter.
4373         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
4374         (dwarf2_frame_cache): Update.
4375         (dwarf2_build_frame_info): Don't set "objfile" member.
4376
4377 2020-02-12  Tom Tromey  <tom@tromey.com>
4378
4379         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
4380         (decode_frame_entry): Likewise.
4381         (dwarf2_build_frame_info): Update.
4382
4383 2020-02-12  Tom Tromey  <tom@tromey.com>
4384
4385         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
4386         (decode_frame_entry_1): Use the comp_unit obstack.
4387
4388 2020-02-12  Tom Tromey  <tom@tromey.com>
4389
4390         * dwarf2/frame.c (struct comp_unit): Add initializers and
4391         constructor.
4392         (dwarf2_frame_objfile_data): Store a comp_unit.
4393         (dwarf2_frame_find_fde): Update.
4394         (dwarf2_build_frame_info): Use "new".
4395
4396 2020-02-12  Tom Tromey  <tom@tromey.com>
4397
4398         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
4399         (dwarf2_fde_table): Typedef for std::vector.
4400         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
4401         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
4402         (decode_frame_entry): Update.
4403         (dwarf2_build_frame_info): Use "new".
4404
4405 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
4406
4407         * arm-tdep.c (arm_gdbarch_init): Update.
4408         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
4409         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
4410         have_neon, is_m>: Change to bool.
4411
4412 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
4413
4414         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
4415
4416 2020-02-12  Tom Tromey  <tom@tromey.com>
4417
4418         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
4419
4420 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
4421
4422         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
4423         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
4424
4425 2020-02-11  Tom Tromey  <tom@tromey.com>
4426
4427         * psymtab.h: Update comment.
4428
4429 2020-02-11  Tom Tromey  <tom@tromey.com>
4430
4431         * gdb_obstack.h (struct auto_obstack): Use
4432         DISABLE_COPY_AND_ASSIGN.
4433
4434 2020-02-11  Tom Tromey  <tom@tromey.com>
4435
4436         * dwarf2/frame.h (struct objfile): Don't forward declare.
4437
4438 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4439
4440         * cris-tdep.c (cris_supply_gregset): Change signature to match
4441         what struct regset expects.
4442         (cris_regset): New struct.
4443         (fetch_core_registers): Remove.
4444         (cris_iterate_over_regset_sections): New function.
4445         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
4446         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
4447
4448 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4449
4450         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
4451         registers.
4452
4453 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4454
4455         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
4456
4457 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4458
4459         * configure: Re-generate.
4460
4461 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4462
4463         * configure: Re-generate.
4464
4465 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4466
4467         * acinclude: Update warning.m4 path.
4468         * warning.m4: Move to gdbsupport.
4469
4470 2020-02-11  Tom Tromey  <tromey@adacore.com>
4471
4472         * remote.c (remote_console_output): Update.
4473         * printcmd.c (printf_command): Update.
4474         * event-loop.c (gdb_wait_for_event): Update.
4475         * linux-nat.c (sigchld_handler): Update.
4476         * remote-sim.c (gdb_os_write_stdout): Update.
4477         (gdb_os_flush_stdout): Update.
4478         (gdb_os_flush_stderr): Update.
4479         (gdb_os_write_stderr): Update.
4480         * exceptions.c (print_exception): Update.
4481         * remote-fileio.c (remote_fileio_func_read): Update.
4482         (remote_fileio_func_write): Update.
4483         * tui/tui.c (tui_enable): Update.
4484         * tui/tui-interp.c (tui_interp::init): Update.
4485         * utils.c (init_page_info): Update.
4486         (putchar_unfiltered, fputc_unfiltered): Update.
4487         (gdb_flush): Update.
4488         (emit_style_escape): Update.
4489         (flush_wrap_buffer, fputs_maybe_filtered): Update.
4490         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
4491         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
4492         (stderr_file::write): Update.
4493         (stderr_file::puts): Update.
4494         * ui-file.h (ui_file_isatty, ui_file_write)
4495         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
4496         (ui_file_puts): Don't declare.
4497
4498 2020-02-10  Tom de Vries  <tdevries@suse.de>
4499
4500         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
4501         sentinel to char *.
4502
4503 2020-02-09  Tom de Vries  <tdevries@suse.de>
4504
4505         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
4506         filename if it matches "<artificial>".
4507
4508 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4509
4510         * windows-tdep.c (struct enum_value_name): New struct.
4511         (create_enum): New function.
4512         (windows_get_siginfo_type): Create and use enum types.
4513
4514 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4515
4516         * NEWS: Mention $_siginfo support for Windows.
4517         * windows-nat.c (handle_exception): Set siginfo_er.
4518         (windows_nat_target::mourn_inferior): Reset siginfo_er.
4519         (windows_xfer_siginfo): New function.
4520         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
4521         * windows-tdep.c (struct windows_gdbarch_data): New struct.
4522         (init_windows_gdbarch_data): New function.
4523         (get_windows_gdbarch_data): New function.
4524         (windows_get_siginfo_type): New function.
4525         (windows_init_abi): Register windows_get_siginfo_type.
4526         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
4527
4528 2020-02-08  Tom Tromey  <tom@tromey.com>
4529
4530         * dwarf2/read.c (class cutu_reader) <cutu_reader,
4531         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
4532         <keep>: Declare method.
4533         <m_keep>: Remove member.
4534         <~cutu_reader>: Remove.
4535         (cutu_reader::init_tu_and_read_dwo_dies): Update.
4536         (cutu_reader::cutu_reader): Update.
4537         (cutu_reader::keep): Rename from ~cutu_reader.
4538         (process_psymtab_comp_unit, build_type_psymtabs_1)
4539         (process_skeletonless_type_unit, load_partial_comp_unit)
4540         (load_full_comp_unit, dwarf2_read_addr_index)
4541         (read_signatured_type): Update.
4542
4543 2020-02-08  Tom Tromey  <tom@tromey.com>
4544
4545         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
4546         "want_partial_unit" parameter.
4547         (process_psymtab_comp_unit): Change want_partial_unit to bool.
4548         Inline check for DW_TAG_partial_unit.
4549         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
4550
4551 2020-02-08  Tom Tromey  <tom@tromey.com>
4552
4553         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
4554         read.c.
4555         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
4556         read.c.
4557
4558 2020-02-08  Tom Tromey  <tom@tromey.com>
4559
4560         * dwarf2/read.c (read_address): Move to comp-unit.c.
4561         (dwarf2_rnglists_process, dwarf2_ranges_process)
4562         (read_attribute_value, dwarf_decode_lines_1)
4563         (var_decode_location, decode_locdesc): Update.
4564         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
4565         read.c.  Remove "cu" parameter.
4566         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
4567         method.
4568
4569 2020-02-08  Tom Tromey  <tom@tromey.com>
4570
4571         * dwarf2/read.c (read_attribute_value, read_indirect_string)
4572         (read_indirect_line_string): Update.
4573         * dwarf2/comp-unit.c (read_offset): Remove.
4574         (read_comp_unit_head): Update.
4575         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
4576         method.
4577         (read_offset): Don't declare.
4578
4579 2020-02-08  Tom Tromey  <tom@tromey.com>
4580
4581         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
4582         * dwarf2/read.c (struct comp_unit_head): Move to
4583         dwarf2/comp-unit.h.
4584         (enum class rcuh_kind): Move to comp-unit.h.
4585         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
4586         (read_comp_unit_head, error_check_comp_unit_head)
4587         (read_and_check_comp_unit_head): Move to comp-unit.c.
4588         (read_offset, dwarf_unit_type_name): Likewise.
4589         (create_debug_type_hash_table, read_cutu_die_from_dwo)
4590         (cutu_reader::cutu_reader, read_call_site_scope)
4591         (find_partial_die, follow_die_offset): Update.
4592         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
4593
4594 2020-02-08  Tom Tromey  <tom@tromey.com>
4595
4596         * dwarf2/read.c (read_offset_1): Move to leb.c.
4597         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
4598         (dwarf_decode_macro_bytes): Update.
4599         * dwarf2/leb.c (read_offset): Rename; move from read.c.
4600         * dwarf2/leb.h (read_offset): Declare.
4601
4602 2020-02-08  Tom Tromey  <tom@tromey.com>
4603
4604         * dwarf2/read.c (dwarf2_section_size): Remove.
4605         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
4606         Update.
4607         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
4608
4609 2020-02-08  Tom Tromey  <tom@tromey.com>
4610
4611         * dwarf2/read.c (read_initial_length): Move to leb.c.
4612         * dwarf2/leb.h (read_initial_length): Declare.
4613         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
4614         handle_nonstd parameter.
4615         * dwarf2/frame.c (read_initial_length): Remove.
4616         (decode_frame_entry_1): Update.
4617
4618 2020-02-08  Tom Tromey  <tom@tromey.com>
4619
4620         * dwarf2/loc.c (dwarf2_find_location_expression)
4621         (dwarf_evaluate_loc_desc::get_tls_address)
4622         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
4623         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
4624         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
4625         (dwarf2_compile_property_to_c)
4626         (dwarf2_loc_desc_get_symbol_read_needs)
4627         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
4628         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
4629         (loclist_describe_location, loclist_tracepoint_var_ref)
4630         (loclist_generate_c_location): Update.
4631         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
4632         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
4633         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
4634         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
4635         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
4636         (dwarf2_per_cu_data::addr_size)
4637         (dwarf2_per_cu_data::ref_addr_size)
4638         (dwarf2_per_cu_data::text_offset)
4639         (dwarf2_per_cu_data::addr_type): Now methods.
4640         (per_cu_header_read_in): Make per_cu "const".
4641         (dwarf2_version): Remove.
4642         (dwarf2_per_cu_data::int_type): Now a method.
4643         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
4644         (set_die_type, read_array_type, read_subrange_index_type)
4645         (read_tag_string_type, read_subrange_type): Update.
4646         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
4647         offset_size, ref_addr_size, text_offset, addr_type, version,
4648         objfile, int_type, addr_sized_int_type>: Declare methods.
4649
4650 2020-02-08  Tom Tromey  <tom@tromey.com>
4651
4652         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
4653         Move earlier.
4654
4655 2020-02-08  Tom Tromey  <tom@tromey.com>
4656
4657         * dwarf2/read.h (dwarf_line_debug): Declare.
4658         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
4659         * dwarf2/read.c: Move line_header code to new files.
4660         (dwarf_line_debug): No longer static.
4661         * dwarf2/line-header.c: New file.
4662         * dwarf2/line-header.h: New file.
4663
4664 2020-02-08  Tom Tromey  <tom@tromey.com>
4665
4666         * dwarf2/read.c (struct line_header) <file_full_name,
4667         file_file_name>: Return unique_xmalloc_ptr.
4668         (line_header::file_file_name): Update.
4669         (line_header::file_full_name): Update.
4670         (dw2_get_file_names_reader): Update.
4671         (macro_start_file): Update.
4672
4673 2020-02-08  Tom Tromey  <tom@tromey.com>
4674
4675         * dwarf2/read.c (struct line_header) <file_full_name,
4676         file_file_name>: Declare methods.
4677         (dw2_get_file_names_reader): Update.
4678         (file_file_name): Now a method.
4679         (file_full_name): Likewise.
4680         (macro_start_file): Update.
4681
4682 2020-02-08  Tom Tromey  <tom@tromey.com>
4683
4684         * dwarf2/read.c (dwarf_always_disassemble)
4685         (show_dwarf_always_disassemble): Move to loc.c.
4686         (_initialize_dwarf2_read): Move "always-disassemble" registration
4687         to loc.c.
4688         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
4689         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
4690         static.
4691         (show_dwarf_always_disassemble): Move from read.c.
4692         (_initialize_dwarf2loc): Move always-disassemble from read.c.
4693
4694 2020-02-08  Tom Tromey  <tom@tromey.com>
4695
4696         * dwarf2/read.c (~dwarf2_per_objfile): Update.
4697         (create_quick_file_names_table): Return htab_up.
4698         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
4699         Update.
4700         * dwarf2/read.h (struct dwarf2_per_objfile)
4701         <quick_file_names_table>: Now htab_up.
4702
4703 2020-02-08  Tom Tromey  <tom@tromey.com>
4704
4705         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
4706
4707 2020-02-08  Tom Tromey  <tom@tromey.com>
4708
4709         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
4710         Rewrite.
4711         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
4712         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
4713         (abbrev_table::abbrev_table): No longer inline.
4714         (ABBREV_HASH_SIZE): Remove.
4715         (abbrev_table::m_abbrevs): Now an htab_up.
4716
4717 2020-02-08  Tom Tromey  <tom@tromey.com>
4718
4719         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
4720         (cutu_reader): Update.
4721         (build_type_psymtabs_1): Update.
4722         * dwarf2/abbrev.c (abbrev_table::read): Rename.
4723         (abbrev_table::alloc_abbrev): Update.
4724         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
4725         (abbrev_table::read): New static method, renamed from
4726         abbrev_table_read_table.
4727         (abbrev_table::alloc_abbrev)
4728         (abbrev_table::add_abbrev): Now private.
4729         (abbrev_table::abbrev_table): Now private.
4730         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
4731
4732 2020-02-08  Tom Tromey  <tom@tromey.com>
4733
4734         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
4735         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
4736         htab_up.
4737
4738 2020-02-08  Tom Tromey  <tom@tromey.com>
4739
4740         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
4741         htab_up.
4742         (lookup_dwo_unit_in_dwp): Update.
4743         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
4744         on obstack.
4745
4746 2020-02-08  Tom Tromey  <tom@tromey.com>
4747
4748         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
4749         obstack.
4750
4751 2020-02-08  Tom Tromey  <tom@tromey.com>
4752
4753         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
4754         line_header_hash.
4755         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
4756         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
4757         Change type to htab_up.
4758
4759 2020-02-08  Tom Tromey  <tom@tromey.com>
4760
4761         * dwarf2/read.c (allocate_type_unit_groups_table): Return
4762         htab_up.  Don't allocate on obstack.
4763         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
4764         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
4765         Change type to htab_up.
4766
4767 2020-02-08  Tom Tromey  <tom@tromey.com>
4768
4769         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
4770         Change type to htab_up.
4771         * dwarf2/read.c (create_signatured_type_table_from_index)
4772         (create_signatured_type_table_from_debug_names)
4773         (create_all_type_units, add_type_unit)
4774         (lookup_dwo_signatured_type, lookup_signatured_type)
4775         (process_skeletonless_type_unit): Update.
4776         (create_debug_type_hash_table, create_debug_types_hash_table):
4777         Change type of types_htab.
4778         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
4779         htab_up.  Don't allocate on obstack.
4780         (create_cus_hash_table): Change type of cus_htab parameter.
4781         (struct dwo_file) <cus, tus>: Now htab_up.
4782         (lookup_dwo_signatured_type, lookup_dwo_cutu)
4783         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
4784         (queue_and_load_all_dwo_tus): Update.
4785         * dwarf2/index-write.c (write_gdbindex): Update.
4786         (write_debug_names): Update.
4787
4788 2020-02-08  Tom Tromey  <tom@tromey.com>
4789
4790         * dwarf2/read.h (struct dwarf2_queue_item): Move from
4791         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
4792         destructor.
4793         (struct dwarf2_per_objfile) <queue>: New member.
4794         * dwarf2/read.c (struct dwarf2_queue_item): Move to
4795         dwarf2/read.h.
4796         (dwarf2_queue, dwarf2_queue_tail): Remove.
4797         (class dwarf2_queue_guard): Add parameter to constructor.  Use
4798         DISABLE_COPY_AND_ASSIGN.
4799         <m_per_objfile>: New member.
4800         <~dwarf2_queue_guard>: Rewrite.
4801         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
4802         Update.
4803         (~dwarf2_queue_item): New.
4804
4805 2020-02-08  Tom Tromey  <tom@tromey.com>
4806
4807         * dwarf2/read.c (struct die_info) <has_children>: New member.
4808         (dw2_get_file_names_reader): Remove has_children.
4809         (dw2_get_file_names): Update.
4810         (read_cutu_die_from_dwo): Remove has_children.
4811         (cutu_reader::init_tu_and_read_dwo_dies)
4812         (cutu_reader::cutu_reader): Update.
4813         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
4814         Remove has_children.
4815         (build_type_psymtabs_1, process_skeletonless_type_unit)
4816         (load_partial_comp_unit, load_full_comp_unit): Update.
4817         (create_dwo_cu_reader): Remove has_children.
4818         (create_cus_hash_table, read_die_and_children): Update.
4819         (read_full_die_1,read_full_die): Remove has_children.
4820         (read_signatured_type): Update.
4821         (class cutu_reader) <has_children>: Remove.
4822
4823 2020-02-08  Tom Tromey  <tom@tromey.com>
4824
4825         * dwarf2/expr.c: Rename from dwarf2expr.c.
4826         * dwarf2/expr.h: Rename from dwarf2expr.h.
4827         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
4828         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
4829         * dwarf2/frame.c: Rename from dwarf2-frame.c.
4830         * dwarf2/frame.h: Rename from dwarf2-frame.h.
4831         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
4832         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
4833         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
4834         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
4835         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
4836         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
4837         * dwarf2/loc.c: Rename from dwarf2loc.c.
4838         * dwarf2/loc.h: Rename from dwarf2loc.h.
4839         * dwarf2/read.c: Rename from dwarf2read.c.
4840         * dwarf2/read.h: Rename from dwarf2read.h.
4841         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
4842         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
4843         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
4844         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
4845         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
4846         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
4847         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
4848         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
4849         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
4850         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
4851         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
4852         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
4853         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
4854         Update.
4855         * Makefile.in (COMMON_SFILES): Update.
4856         (HFILES_NO_SRCDIR): Update.
4857
4858 2020-02-08  Tom Tromey  <tom@tromey.com>
4859
4860         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
4861         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
4862
4863 2020-02-08  Tom Tromey  <tom@tromey.com>
4864
4865         * dwarf2read.h (struct die_info): Don't declare.
4866
4867 2020-02-08  Tom Tromey  <tom@tromey.com>
4868
4869         * dwarf2read.h (die_info_ptr): Remove typedef.
4870
4871 2020-02-08  Tom Tromey  <tom@tromey.com>
4872
4873         * dwarf2read.c (read_call_site_scope)
4874         (handle_data_member_location, dwarf2_add_member_fn)
4875         (mark_common_block_symbol_computed, read_common_block)
4876         (attr_to_dynamic_prop, partial_die_info::read)
4877         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
4878         (dwarf2_symbol_mark_computed, set_die_type): Update.
4879         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
4880         method.
4881         (attr_form_is_block): Don't declare.
4882         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
4883
4884 2020-02-08  Tom Tromey  <tom@tromey.com>
4885
4886         * dwarf2read.c (dwarf2_find_base_address, )
4887         (read_call_site_scope, rust_containing_type)
4888         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
4889         (handle_data_member_location, dwarf2_add_member_fn)
4890         (get_alignment, read_structure_type, process_structure_scope)
4891         (mark_common_block_symbol_computed, read_common_block)
4892         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
4893         (partial_die_info::read, read_attribute_value, new_symbol)
4894         (lookup_die_type, dwarf2_get_ref_die_offset)
4895         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
4896         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
4897         (dwarf2_symbol_mark_computed): Update.
4898         * dwarf2/attribute.h (struct attribute) <value_as_address,
4899         form_is_section_offset, form_is_constant, form_is_ref>: Declare
4900         methods.
4901         (value_as_address, attr_form_is_section_offset)
4902         (attr_form_is_constant, attr_form_is_ref): Don't declare.
4903         * dwarf2/attribute.c (attribute::value_as_address)
4904         (attribute::form_is_section_offset, attribute::form_is_constant)
4905         (attribute::form_is_ref): Now methods.
4906
4907 2020-02-08  Tom Tromey  <tom@tromey.com>
4908
4909         * dwarf2read.c (struct attribute, DW_STRING)
4910         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
4911         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
4912         (attr_form_is_block, attr_form_is_section_offset)
4913         (attr_form_is_constant, attr_form_is_ref): Move.
4914         * dwarf2/attribute.h: New file.
4915         * dwarf2/attribute.c: New file, from dwarf2read.c.
4916         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
4917
4918 2020-02-08  Tom Tromey  <tom@tromey.com>
4919
4920         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
4921         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
4922         Move.
4923         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
4924         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
4925         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
4926         abbrev.c.
4927         * dwarf2/abbrev.h: New file.
4928         * dwarf2/abbrev.c: New file, from dwarf2read.c.
4929         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
4930
4931 2020-02-08  Tom Tromey  <tom@tromey.com>
4932
4933         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
4934         (dwarf2_section_size, dwarf2_get_section_info)
4935         (create_signatured_type_table_from_debug_names)
4936         (create_addrmap_from_aranges, read_debug_names_from_section)
4937         (get_gdb_index_contents_from_section, read_comp_unit_head)
4938         (error_check_comp_unit_head, read_abbrev_offset)
4939         (create_debug_type_hash_table, init_cu_die_reader)
4940         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
4941         (read_comp_units_from_section, create_cus_hash_table)
4942         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
4943         (create_dwp_v2_section, dwarf2_rnglists_process)
4944         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
4945         (abbrev_table_read_table, read_indirect_string_at_offset_from)
4946         (read_indirect_string_from_dwz, read_addr_index_1)
4947         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
4948         (dwarf_decode_macro_bytes, dwarf_decode_macros)
4949         (fill_in_loclist_baton): Update.
4950         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
4951         get_containing_section, get_bfd_owner, get_bfd_section,
4952         get_file_name, get_id, get_flags, empty, read>: Declare methods.
4953         (dwarf2_read_section, get_section_name, get_section_file_name)
4954         (get_containing_section, get_section_bfd_owner)
4955         (get_section_bfd_section, get_section_name, get_section_file_name)
4956         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
4957         declare.
4958         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
4959         (dwarf2_section_info::get_bfd_owner)
4960         (dwarf2_section_info::get_bfd_section)
4961         (dwarf2_section_info::get_name)
4962         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
4963         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
4964         (dwarf2_section_info::read): Now methods.
4965         * dwarf-index-write.c (class debug_names): Update.
4966
4967 2020-02-08  Tom Tromey  <tom@tromey.com>
4968
4969         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
4970         Move to dwarf2/section.h.
4971         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
4972         (get_section_bfd_section, get_section_name)
4973         (get_section_file_name, get_section_id, get_section_flags)
4974         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
4975         dwarf2/section.c.
4976         * dwarf2/section.h: New file.
4977         * dwarf2/section.c: New file, from dwarf2read.c.
4978         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
4979
4980 2020-02-08  Tom Tromey  <tom@tromey.com>
4981
4982         * dwarf2read.h (read_unsigned_leb128): Don't declare.
4983         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
4984         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
4985         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
4986         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
4987         * dwarf2/leb.h: New file, from dwarf2read.c.
4988         * dwarf2/leb.c: New file, from dwarf2read.c.
4989         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
4990         Remove.
4991         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
4992         (COMMON_SFILES): Add dwarf2/leb.c.
4993
4994 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
4995
4996         GDB 9.1 released.
4997
4998 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
4999
5000         PR gdb/25190:
5001         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
5002         * gdb/remote.c (remote_console_output): Update.
5003         * gdb/ui-file.c (fputs_unfiltered): Rename to...
5004         (ui_file_puts): ...this.
5005         * gdb/ui-file.h (ui_file_puts): Add declaration.
5006         * gdb/utils.c (emit_style_escape): Update.
5007         (flush_wrap_buffer): Update.
5008         (fputs_maybe_filtered): Update.
5009         (fputs_unfiltered): Add function.
5010
5011 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
5012
5013         * gdb/event-loop.c (gdb_wait_for_event): Update.
5014         * gdb/printcmd.c (printf_command): Update.
5015         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
5016         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
5017         (gdb_os_flush_stderr): Update.
5018         * gdb/remote.c (remote_console_output): Update.
5019         * gdb/ui-file.c (gdb_flush): Rename to...
5020         (ui_file_flush): ...this.
5021         (stderr_file::write): Update.
5022         (stderr_file::puts): Update.
5023         * gdb/ui-file.h (gdb_flush): Rename to...
5024         (ui_file_flush): ...this.
5025         * gdb/utils.c (gdb_flush): Add function.
5026         * gdb/utils.h (gdb_flush): Add declaration.
5027
5028 2020-02-07  Tom Tromey  <tromey@adacore.com>
5029
5030         PR breakpoints/24915:
5031         * source.c (find_and_open_source): Do not check basenames_may_differ.
5032
5033 2020-02-07  Tom Tromey  <tom@tromey.com>
5034
5035         * README: Update gdbserver documentation.
5036         * gdbserver: Move to top level.
5037         * configure.tgt (build_gdbserver): Remove.
5038         * configure.ac: Remove --enable-gdbserver.
5039         * configure: Rebuild.
5040         * Makefile.in (distclean): Don't mention gdbserver.
5041
5042 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
5043
5044         * source-cache.c (source_cache::ensure): Surround
5045         get_plain_source_lines with a try/catch.
5046         (source_cache::get_line_charpos): Get rid of try/catch
5047         and only check for the return value of "ensure".
5048         * tui/tui-source.c (tui_source_window::set_contents):
5049         Simplify "nlines" calculation.
5050
5051 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
5052
5053         * MAINTAINERS (Write After Approval): Add myself.
5054
5055 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
5056
5057         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
5058         function call.
5059
5060 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
5061
5062         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
5063
5064 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
5065
5066         * nat/riscv-linux-tdesc.h: New file.
5067         * nat/riscv-linux-tdesc.c: New file, taking code from...
5068         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
5069         ... here.
5070         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
5071         NATDEPFILES.
5072
5073 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
5074
5075         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
5076         we don't set the fake simulator ptid to the null_ptid.
5077
5078 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
5079
5080         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
5081         * gdbthread.h (class thread_info) <resumed>: Likewise.
5082         * infrun.c (resume_1): Likewise.
5083         (proceed): Likewise.
5084         (infrun_thread_stop_requested): Likewise.
5085         (stop_all_threads): Likewise.
5086         (handle_inferior_event): Likewise.
5087         (restart_threads): Likewise.
5088         (finish_step_over): Likewise.
5089         (keep_going_stepped_thread): Likewise.
5090         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
5091         (linux_handle_extended_wait): Likewise.
5092         * record-btrace.c (get_thread_current_frame_id): Likewise.
5093         * record-full.c (record_full_wait_1): Likewise.
5094         * remote.c (remote_target::process_initial_stop_replies): Likewise.
5095         * target.c (target_resume): Likewise.
5096         * thread.c (set_running_thread): Likewise.
5097
5098 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
5099
5100         * f-valprint.c (f77_print_array_1): Changed datatype of index
5101         variable to LONGEST from int to enable it to contain bound
5102         values correctly.
5103
5104 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
5105
5106         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
5107         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
5108         offsets according to FLEN determined.
5109         (riscv_linux_nat_target::read_description): Determine FLEN
5110         dynamically.
5111         (riscv_linux_nat_target::fetch_registers): Size regset buffer
5112         according to FLEN determined.
5113         (riscv_linux_nat_target::store_registers): Likewise.
5114
5115 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
5116
5117         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
5118         when reg->group is empty and reggroup is not.
5119
5120 2020-01-31  Tom Tromey  <tromey@adacore.com>
5121
5122         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
5123         Call beneath target's mourn_inferior after unpushing.
5124
5125 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
5126
5127         PR tui/9765
5128         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
5129         have enough lines to fill the screen, still return the lowest
5130         address we found.
5131
5132 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
5133
5134         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
5135         '-', '<', and '>' commands.
5136
5137 2020-01-29  Pedro Alves  <palves@redhat.com>
5138             Sergio Durigan Junior  <sergiodj@redhat.com>
5139
5140         * infcmd.c (construct_inferior_arguments): Assert that
5141         'argc' is greater than 0.
5142
5143 2020-01-29  Luis Machado  <luis.machado@linaro.org>
5144
5145         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
5146         (BRK_INSN_MASK): Define to 0xd4200000.
5147         (aarch64_program_breakpoint_here_p): New function.
5148         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
5149         * arch-utils.c (default_program_breakpoint_here_p): Moved from
5150         breakpoint.c.
5151         * arch-utils.h (default_program_breakpoint_here_p): Moved from
5152         breakpoint.h
5153         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
5154         call gdbarch_program_breakpoint_here_p.
5155         (program_breakpoint_here): Moved to arch-utils.c, renamed to
5156         default_program_breakpoint_here_p, changed return type to bool and
5157         simplified.
5158         * breakpoint.h (program_breakpoint_here): Moved prototype to
5159         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
5160         return type to bool.
5161         * gdbarch.c: Regenerate.
5162         * gdbarch.h: Regenerate.
5163         * gdbarch.sh (program_breakpoint_here_p): New method.
5164         * infrun.c (handle_signal_stop): Call
5165         gdbarch_program_breakpoint_here_p.
5166
5167 2020-01-26  Tom Tromey  <tom@tromey.com>
5168
5169         * ctfread.c (struct ctf_fp_info): Reindent.
5170         (_initialize_ctfread): Remove.
5171
5172 2020-01-26  Tom Tromey  <tom@tromey.com>
5173
5174         * psymtab.c (partial_map_expand_apply)
5175         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
5176         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
5177         (psym_print_stats, psym_expand_symtabs_for_function)
5178         (psym_map_symbol_filenames, psym_map_matching_symbols)
5179         (psym_expand_symtabs_matching)
5180         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
5181         (maintenance_check_psymtabs): Use new methods.
5182         * psympriv.h (struct partial_symtab) <readin_p,
5183         get_compunit_symtab>: New methods.
5184         <readin, compunit_symtab>: Remove members.
5185         (struct standard_psymtab): New.
5186         (struct legacy_psymtab): Derive from standard_psymtab.
5187         * dwarf2read.h (struct dwarf2_psymtab): Derive from
5188         standard_psymtab.
5189         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
5190
5191 2020-01-26  Tom Tromey  <tom@tromey.com>
5192
5193         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
5194         read_dependencies.  Add assert.
5195         * psymtab.c (partial_symtab::read_dependencies): New method.
5196         * psympriv.h (struct partial_symtab) <read_dependencies>: New
5197         method.
5198         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
5199         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
5200         read_dependencies.
5201         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
5202         Add assert.
5203
5204 2020-01-26  Tom Tromey  <tom@tromey.com>
5205
5206         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
5207         Call expand_psymtab.
5208         (xcoff_read_symtab): Call expand_psymtab.
5209         (xcoff_start_psymtab, xcoff_end_psymtab): Set
5210         legacy_expand_psymtab.
5211         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
5212         method.
5213         (struct legacy_psymtab) <expand_psymtab>: Implement.
5214         <legacy_expand_psymtab>: New member.
5215         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
5216         (parse_partial_symbols): Set legacy_expand_psymtab.
5217         (psymtab_to_symtab_1): Change argument order.  Call
5218         expand_psymtab.
5219         (new_psymtab): Set legacy_expand_psymtab.
5220         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
5221         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
5222         expand_psymtab.
5223         (dwarf2_psymtab::expand_psymtab): Rename from
5224         psymtab_to_symtab_1.  Call expand_psymtab.
5225         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
5226         (dbx_end_psymtab): Likewise.
5227         (dbx_psymtab_to_symtab_1): Change argument order. Call
5228         expand_psymtab.
5229         (dbx_read_symtab): Call expand_psymtab.
5230         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
5231         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
5232         (ctf_psymtab::read_symtab): Call expand_psymtab.
5233
5234 2020-01-26  Tom Tromey  <tom@tromey.com>
5235
5236         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
5237         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
5238         messages.
5239         * mdebugread.c (mdebug_read_symtab): Remove prints.
5240         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
5241         assert.
5242         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
5243
5244 2020-01-26  Tom Tromey  <tom@tromey.com>
5245
5246         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
5247         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
5248         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
5249         legacy_symtab.
5250         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
5251         * psymtab.c (psymtab_to_symtab): Call method.
5252         (dump_psymtab): Update.
5253         * psympriv.h (struct partial_symtab): Add virtual destructor.
5254         <read_symtab>: New method.
5255         (struct legacy_symtab): New.
5256         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
5257         (struct pst_map) <pst>: Now a legacy_psymtab.
5258         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
5259         (new_psymtab): Use legacy_psymtab.
5260         * dwarf2read.h (struct dwarf2_psymtab): New.
5261         (struct dwarf2_per_cu_data) <psymtab>: Use it.
5262         * dwarf2read.c (dwarf2_create_include_psymtab)
5263         (dwarf2_build_include_psymtabs, create_type_unit_group)
5264         (create_partial_symtab, process_psymtab_comp_unit_reader)
5265         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
5266         (set_partial_user): Use dwarf2_psymtab.
5267         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
5268         (psymtab_to_symtab_1, process_full_comp_unit)
5269         (process_full_type_unit, dwarf2_ranges_read)
5270         (dwarf2_get_pc_bounds, psymtab_include_file_name)
5271         (dwarf_decode_lines): Use dwarf2_psymtab.
5272         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
5273         (add_address_entry_worker, write_one_signatured_type)
5274         (recursively_count_psymbols, recursively_write_psymbols)
5275         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
5276         (write_debug_names): Likewise.
5277         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
5278         <pst>: Now a legacy_psymtab.
5279         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
5280         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
5281         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
5282         * ctfread.c (struct ctf_psymtab): New.
5283         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
5284         ctf_psymtab.
5285         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
5286         (create_partial_symtab): Return a ctf_psymtab.
5287         (scan_partial_symbols): Update.
5288
5289 2020-01-26  Tom Tromey  <tom@tromey.com>
5290
5291         * xcoffread.c (xcoff_start_psymtab): Use new.
5292         * psymtab.c (partial_symtab::partial_symtab): New constructor,
5293         renamed from start_psymtab_common.
5294         * psympriv.h (struct partial_symtab): Add new constructor.
5295         (start_psymtab_common): Don't declare.
5296         * mdebugread.c (parse_partial_symbols): Use new.
5297         * dwarf2read.c (create_partial_symtab): Use new.
5298         * dbxread.c (start_psymtab): Use new.
5299         * ctfread.c (create_partial_symtab): Use new.
5300
5301 2020-01-26  Tom Tromey  <tom@tromey.com>
5302
5303         * xcoffread.c (xcoff_end_psymtab): Use new.
5304         * psymtab.c (start_psymtab_common): Use new.
5305         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
5306         Update.
5307         * psympriv.h (struct partial_symtab): Add parameters to
5308         constructor.  Don't inline.
5309         (allocate_psymtab): Don't declare.
5310         * mdebugread.c (new_psymtab): Use new.
5311         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
5312         * dbxread.c (dbx_end_psymtab): Use new.
5313
5314 2020-01-26  Tom Tromey  <tom@tromey.com>
5315
5316         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
5317         allocate_psymtab.  Update documentation.
5318         * psymtab.c (psymtab_storage::install_psymtab): Rename from
5319         allocate_psymtab.  Do not use new.
5320         (allocate_psymtab): Use new.  Update.
5321
5322 2020-01-26  Tom Tromey  <tom@tromey.com>
5323
5324         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
5325         * psymtab.c (psym_print_stats): Update.
5326         * psympriv.h (struct partial_symtab) <readin,
5327         psymtabs_addrmap_supported, anonymous>: Now bool.
5328         * mdebugread.c (psymtab_to_symtab_1): Update.
5329         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
5330         (build_type_psymtabs_reader, psymtab_to_symtab_1)
5331         (process_full_comp_unit, process_full_type_unit): Update.
5332         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
5333         * ctfread.c (psymtab_to_symtab): Update.
5334
5335 2020-01-26  Tom Tromey  <tom@tromey.com>
5336
5337         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
5338         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
5339         * psymtab.c (psymtab_storage): Delete psymtabs.
5340         (psymtab_storage::allocate_psymtab): Use new.
5341         (psymtab_storage::discard_psymtab): Use delete.
5342         * psympriv.h (struct partial_symtab): Add constructor and
5343         initializers.
5344
5345 2020-01-26  Tom Tromey  <tom@tromey.com>
5346
5347         * machoread.c: Do not include psympriv.h.
5348
5349 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5350
5351         * NEWS: Mention the new option and the set/show commands.
5352
5353 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5354
5355         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
5356         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
5357         (validate_exec_file): New variables, enums, functions.
5358         (exec_file_locate_attach, print_section_info): Style the filenames.
5359         (_initialize_exec): Install show_exec_file_mismatch_command and
5360          set_exec_file_mismatch_command.
5361         * gdbcore.h (validate_exec_file): Declare.
5362         * infcmd.c (attach_command): Call validate_exec_file.
5363         * remote.c ( remote_target::remote_add_inferior): Likewise.
5364
5365 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5366
5367         * frame.c (find_frame_sal): Move call to get_next_frame into more
5368         inner scope.
5369         * inline-frame.c (inilne_state) <inline_state>: Update argument
5370         types.
5371         (inilne_state) <skipped_symbol>: Rename to...
5372         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
5373         (skip_inline_frames): Build vector of skipped symbols and use this
5374         to reate the inline_state.
5375         (inline_skipped_symbol): Add a comment and some assertions, fetch
5376         skipped symbol from the list.
5377
5378 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5379
5380         * buildsym.c (lte_is_less_than): Delete.
5381         (buildsym_compunit::end_symtab_with_blockvector): Create local
5382         lambda function to sort line table entries, and use
5383         std::stable_sort instead of std::sort.
5384         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
5385         markers when looking for a previous line.
5386
5387 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5388
5389         * dwarf2read.c (lnp_state_machine::record_line): Include
5390         end_sequence parameter in debug print out.  Record the line if we
5391         are at an end_sequence marker even if it's not the start of a
5392         statement.
5393         * symmisc.c (maintenance_print_one_line_table): Print end of
5394         sequence markers with 'END' not '0'.
5395
5396 2020-01-24  Pedro Alves  <palves@redhat.com>
5397
5398         PR gdb/25410
5399         * thread.c (scoped_restore_current_thread::restore): Use
5400         switch_to_inferior_no_thread.
5401         * exec.c: Include "progspace-and-thread.h".
5402         (add_target_sections, remove_target_sections):
5403         scoped_restore_current_pspace_and_thread instead of
5404         scoped_restore_current_thread.
5405         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
5406         and aspace to the inferior before calling clone_program_space.
5407         Remove stale comment.
5408
5409 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5410
5411         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
5412         (arm_netbsd_nat_target::fetch_registers): ...this.
5413         (arm_nbsd_nat_target::store_registers): Rename to...
5414         (arm_netbsd_nat_target::store_registers): ...this.
5415
5416 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5417
5418         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5419         register_t.
5420
5421 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5422
5423         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
5424         Update comment.
5425         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
5426         Likewise.
5427         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
5428         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
5429         the correct replacement (iterate_over_regset_sections).
5430         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
5431         Update comment.
5432
5433 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
5434
5435         PR gdb/23718
5436         * gdb/python/python.c (execute_gdb_command): Call
5437         async_enable_stdin in catch block.
5438
5439 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5440
5441         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
5442         SWITCH_THRU_ALL_UIS.
5443
5444 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5445
5446         PR tui/9765
5447         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
5448         comment, add extra parameter, and update to store previous symbol
5449         when appropriate.
5450         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
5451         add extra parameter.
5452         * tui/tui-disasm.c (tui_disassemble): Update header comment,
5453         remove unneeded parameter, add try/catch around gdb_print_insn,
5454         rewrite to add items to asm_lines vector.
5455         (tui_find_backward_disassembly_start_address): New function.
5456         (tui_find_disassembly_address): Updated throughout.
5457         (tui_disasm_window::set_contents): Update for changes to
5458         tui_disassemble.
5459         (tui_disasm_window::do_scroll_vertical): No need to adjust the
5460         number of lines to scroll.
5461
5462 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
5463
5464         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
5465         (SECT_OFF_DATA): Likewise.
5466         (SECT_OFF_RODATA): Likewise.
5467         (SECT_OFF_TEXT): Likewise.
5468         (SECT_OFF_BSS): Likewise.
5469         (struct objfile) <text_section_offset, data_section_offset>: New
5470         methods.
5471         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
5472         objfile::text_section_offset.
5473         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
5474         * coffread.c (coff_symtab_read): Likewise.
5475         (enter_linenos): Likewise.
5476         (process_coff_symbol): Likewise.
5477         * ctfread.c (get_objfile_text_range): Likewise.
5478         * dtrace-probe.c (dtrace_probe::get_relocated_address):
5479         Use objfile::data_section_offset.
5480         * dwarf2-frame.c (execute_cfa_program): Use
5481         objfile::text_section_offset.
5482         (dwarf2_frame_find_fde): Likewise.
5483         * dwarf2read.c (create_addrmap_from_index): Likewise.
5484         (create_addrmap_from_aranges): Likewise.
5485         (dw2_find_pc_sect_compunit_symtab): Likewise.
5486         (process_psymtab_comp_unit_reader): Likewise.
5487         (add_partial_symbol): Likewise.
5488         (add_partial_subprogram): Likewise.
5489         (process_full_comp_unit): Likewise.
5490         (read_file_scope): Likewise.
5491         (read_func_scope): Likewise.
5492         (read_lexical_block_scope): Likewise.
5493         (read_call_site_scope): Likewise.
5494         (dwarf2_rnglists_process): Likewise.
5495         (dwarf2_ranges_process): Likewise.
5496         (dwarf2_ranges_read): Likewise.
5497         (dwarf_decode_lines_1): Likewise.
5498         (new_symbol): Likewise.
5499         (dwarf2_fetch_die_loc_sect_off): Likewise.
5500         (dwarf2_per_cu_text_offset): Likewise.
5501         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
5502         * hppa-tdep.c (read_unwind_info): Likewise.
5503         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
5504         * psympriv.h (struct partial_symtab): Likewise.
5505         * psymtab.c (find_pc_sect_psymtab): Likewise.
5506         * solib-svr4.c (enable_break): Likewise.
5507         * stap-probe.c (relocate_address): Use
5508         objfile::data_section_offset.
5509         * xcoffread.c (enter_line_range): Use
5510         objfile::text_section_offset.
5511         (read_xcoff_symtab): Likewise.
5512
5513 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5514
5515         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
5516         declaration to narrower scopes.
5517
5518 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5519
5520         * darwin-nat.h (struct darwin_exception_msg, enum
5521         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
5522         Move up.
5523         (class darwin_nat_target) <wait_1, check_new_threads,
5524         decode_exception_message, decode_message, stop_inferior,
5525         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
5526         * darwin-nat.c (darwin_check_new_threads): Rename to...
5527         (darwin_nat_target::check_new_threads): ... this.
5528         (darwin_suspend_inferior_it): Remove.
5529         (darwin_decode_exception_message): Rename to...
5530         (darwin_nat_target::decode_exception_message): ... this.
5531         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
5532         (darwin_decode_message): Rename to...
5533         (darwin_nat_target::decode_message): ... this.
5534         (cancel_breakpoint): Rename to...
5535         (darwin_nat_target::cancel_breakpoint): ... this.
5536         (darwin_wait): Rename to...
5537         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
5538         instead of iterate_over_inferiors.
5539         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
5540         (darwin_stop_inferior): Rename to...
5541         (darwin_nat_target::stop_inferior): ... this.
5542         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
5543         (darwin_init_thread_list): Rename to...
5544         (darwin_nat_target::init_thread_list): ... this.
5545         (darwin_ptrace_him): Rename to...
5546         (darwin_nat_target::ptrace_him): ... this.
5547         (darwin_nat_target::create_inferior): Pass lambda function to
5548         fork_inferior.
5549         (darwin_nat_target::detach): Call stop_inferior instead of
5550         darwin_stop_inferior.
5551         * fork-inferior.h (fork_inferior): Change init_trace_fun
5552         parameter to gdb::function_view.
5553         * fork-inferior.c (fork_inferior): Likewise.
5554
5555 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
5556
5557         * i386-cygwin-tdep.c (core_process_module_section): Update.
5558         * windows-nat.c (struct lm_info_windows): Add text_offset.
5559         (windows_xfer_shared_libraries): Update.
5560         * windows-tdep.c (windows_xfer_shared_library):
5561         Add text_offset_cached argument.
5562         * windows-tdep.h (windows_xfer_shared_library): Update.
5563
5564 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5565
5566         * gdbarch.sh: Add declaration for _initialize_gdbarch.
5567
5568 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5569
5570         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
5571         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
5572         replace with range-based for.
5573         (gdbsim_interrupt_inferior): Remove.
5574         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
5575         with a range-based for.  Inline code from
5576         gdbsim_interrupt_inferior.
5577
5578 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5579
5580         * infrun.c (proceed): Fix indentation.
5581
5582 2020-01-21  Tom Tromey  <tromey@adacore.com>
5583
5584         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
5585         * python/python.c (python_extension_ops): Update.
5586         (gdbpy_colorize): New function.
5587         * python/lib/gdb/__init__.py (colorize): New function.
5588         * extension.h (ext_lang_colorize): Declare.
5589         * extension.c (ext_lang_colorize): New function.
5590         * extension-priv.h (struct extension_language_ops) <colorize>: New
5591         member.
5592         * cli/cli-style.c (_initialize_cli_style): Update help text.
5593
5594 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5595
5596         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
5597         <cond>: Change type to bool.
5598         (aarch64_displaced_step_b_cond): Update cond to use bool type.
5599         (aarch64_displaced_step_cb): Likewise.
5600         (aarch64_displaced_step_tb): Likewise.
5601
5602 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5603
5604         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
5605         output.
5606
5607 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5608
5609         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
5610         <pc_adjust>: Adjust the documentation.
5611         (aarch64_displaced_step_fixup): Check if PC really moved before
5612         adjusting it.
5613
5614 2020-01-19  Tom Tromey  <tom@tromey.com>
5615
5616         * disasm.c (~gdb_disassembler): New destructor.
5617         (gdb_buffered_insn_length): Call disassemble_free_target.
5618         * disasm.h (class gdb_disassembler): Declare destructor.  Use
5619         DISABLE_COPY_AND_ASSIGN.
5620
5621 2020-01-19  Tom Tromey  <tom@tromey.com>
5622
5623         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
5624         (die_reader_func_ftype): Remove.
5625         (cutu_reader): New class.
5626         (dw2_get_file_names_reader): Remove "data" parameter.
5627         (dw2_get_file_names): Use cutu_reader.
5628         (create_debug_type_hash_table): Update.
5629         (read_cutu_die_from_dwo): Update comment.
5630         (lookup_dwo_unit): Add dwo_name parameter.
5631         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
5632         die_reader_func_ftype and data parameters.
5633         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
5634         Remove die_reader_func_ftype and data parameters.
5635         (~cutu_reader): New; from init_cutu_and_read_dies.
5636         (cutu_reader::cutu_reader): Rename from
5637         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
5638         and data parameters.
5639         (init_cutu_and_read_dies_simple): Remove.
5640         (struct process_psymtab_comp_unit_data): Remove.
5641         (process_psymtab_comp_unit_reader): Remove data parameter; add
5642         want_partial_unit and pretend_language parameters.
5643         (process_psymtab_comp_unit): Use cutu_reader.
5644         (build_type_psymtabs_reader): Remove data parameter.
5645         (build_type_psymtabs_1): Use cutu_reader.
5646         (process_skeletonless_type_unit): Likewise.
5647         (load_partial_comp_unit_reader): Remove.
5648         (load_partial_comp_unit): Use cutu_reader.
5649         (load_full_comp_unit_reader): Remove.
5650         (load_full_comp_unit): Use cutu_reader.
5651         (struct create_dwo_cu_data): Remove.
5652         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
5653         dwo_unit parameters.
5654         (create_cus_hash_table): Use cutu_reader.
5655         (struct dwarf2_read_addr_index_data): Remove.
5656         (dwarf2_read_addr_index_reader): Remove.
5657         (dwarf2_read_addr_index): Use cutu_reader.
5658         (read_signatured_type_reader): Remove.
5659         (read_signatured_type): Use cutu_reader.
5660
5661 2020-01-19  Tom Tromey  <tom@tromey.com>
5662
5663         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
5664         * tui/tui-wingeneral.h (class tui_suppress_output): New.
5665         (tui_wrefresh): Declare.
5666         * tui/tui-wingeneral.c (suppress_output): New global.
5667         (tui_suppress_output, ~tui_suppress_output): New constructor and
5668         destructor.
5669         (tui_wrefresh): New function.
5670         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
5671         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
5672         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
5673         method.
5674         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
5675         tui_wrefresh.
5676         (tui_data_window::no_refresh): New method.
5677         (tui_data_item_window::refresh_window): Call tui_wrefresh.
5678         (tui_reg_command): Use tui_suppress_output
5679         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
5680         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
5681         method.
5682         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
5683
5684 2020-01-19  Tom Tromey  <tom@tromey.com>
5685
5686         * tui/tui-winsource.c (tui_update_source_windows_with_line):
5687         Handle case where symtab is null.
5688
5689 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
5690
5691         * linux-fork.c (one_fork_p): Simplify.
5692
5693 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5694
5695         * top.c (struct qt_args): Remove.
5696         (kill_or_detach): Change return type to void, replace `void *`
5697         parameter with a proper one.
5698         (print_inferior_quit_action):  Likewise.
5699         (quit_confirm): Use range-based for loop to iterate over inferiors.
5700         (quit_force): Likewise.
5701
5702 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5703
5704         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
5705         `void *` parameter with proper parameters.
5706         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
5707         (print_one_inferior): Change return type to void, replace `void *`
5708         parameter with proper parameters.
5709         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
5710         inferiors.
5711         (get_other_inferior): Remove.
5712         (mi_cmd_remove_inferior): Use range-based loop to iterate over
5713         inferiors.
5714
5715 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5716
5717         * mi/mi-interp.c (report_initial_inferior): Remove.
5718         (mi_interp::init): Use range-based for to iterate over inferiors.
5719
5720 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5721
5722         * python/py-inferior.c (build_inferior_list): Remove.
5723         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
5724
5725 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
5726
5727         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
5728         (btrace_stitch_trace): Likewise.
5729         * charset.c (intermediate_encoding): Likewise (vaild).
5730         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
5731         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
5732         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
5733
5734 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
5735
5736         * windows-tdep.c (windows_get_tlb_type):
5737         Add rtl_user_process_parameters type.
5738
5739 2020-01-16  Pedro Alves  <palves@redhat.com>
5740             Norbert Lange  <nolange79@gmail.com>
5741
5742         PR build/24805
5743         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
5744         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
5745         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
5746         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
5747         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
5748         (ps_plog): Redeclare exported functions with default visibility.
5749
5750 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
5751
5752         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
5753         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
5754
5755 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
5756
5757         * infcmd.c (post_create_inferior): Use get_thread_regcache
5758         instead of get_current_regcache.
5759
5760 2020-01-14  Tom Tromey  <tom@tromey.com>
5761
5762         PR symtab/12535:
5763         * python/python.c (gdbpy_decode_line): Treat empty string the same
5764         as no argument.
5765
5766 2020-01-14  Tom Tromey  <tom@tromey.com>
5767
5768         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
5769
5770 2020-01-14  Tom Tromey  <tom@tromey.com>
5771
5772         * nat/linux-btrace.c: Don't include <config.h>.
5773         * nat/linux-ptrace.c: Don't include <config.h>.
5774         * nat/x86-linux-dregs.c: Don't include <config.h>.
5775
5776 2020-01-14  Tom Tromey  <tom@tromey.com>
5777
5778         * configure: Rebuild.
5779         * configure.ac: Move many checks to ../gdbsupport/common.m4.
5780
5781 2020-01-14  Tom Tromey  <tom@tromey.com>
5782
5783         * nat/x86-linux-dregs.c: Include configh.h.
5784         * nat/linux-ptrace.c: Include configh.h.
5785         * nat/linux-btrace.c: Include configh.h.
5786         * defs.h: Include config.h, bfd.h.
5787         * configure.ac: Don't source common.host.
5788         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
5789         * configure: Rebuild.
5790         * acinclude.m4: Update path.
5791         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
5792         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
5793         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
5794         (CLIBS): Add LIBSUPPORT.
5795         (CDEPS): Likewise.
5796         (COMMON_SFILES): Remove gdbsupport files.
5797         (HFILES_NO_SRCDIR): Likewise.
5798         (stamp-version): Update path to create-version.sh.
5799         (ALLDEPFILES): Remove gdbsupport files.
5800
5801 2020-01-14  Tom Tromey  <tom@tromey.com>
5802
5803         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
5804         USE_WIN32API when needed.
5805         * configure.ac (USE_WIN32API): Don't define.
5806         (WIN32LIBS): Use WIN32APILIBS.
5807         * configure: Rebuild.
5808
5809 2020-01-14  Tom Tromey  <tom@tromey.com>
5810
5811         * configure: Rebuild.
5812         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
5813
5814 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5815
5816         * skip.c (skip_function_command): Make skip w/o arguments use the
5817         name of the inlined function if pc is inside any inlined function.
5818
5819 2020-01-14  Luis Machado  <luis.machado@linaro.org>
5820
5821         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
5822         * infrun.c (resume_1): Likewise.
5823         (handle_inferior_event): Remove stale comment.
5824         * linux-nat.c (linux_nat_target::resume): Update comments.
5825         (save_stop_reason): Likewise.
5826         (linux_nat_filter_event): Likewise.
5827         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
5828
5829 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5830
5831         * elfread.c (record_minimal_symbol): Set section index to 0 for
5832         non-allocatable sections.
5833
5834
5835 2020-01-13  Ali Tamur <tamur@google.com>
5836
5837         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
5838         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
5839         to gdb::optional.  Update comments.
5840         (dwo_file): Update comments.
5841         (read_attribute): Update API to take an additional out parameter,
5842         need_reprocess.  This is used to mark attributes that need other
5843         attributes (e.g. str_offsets_base) for correct computation which may not
5844         have been read yet.
5845         (read_attribute_reprocess): New function declaration.
5846         (read_addr_index): Likewise.
5847         (read_dwo_str_index): Likewise.
5848         (read_stub_str_index): Likewise.
5849         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
5850         (lookup_addr_base): New function definition.
5851         (lookup_ranges_base): Likewise.
5852         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
5853         lookup_ranges_base.
5854         (init_cutu_and_read_dies): Update comments.
5855         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
5856         unit.  This is used to inherit parent's str_offsets_base and addr_base.
5857         Update comments.
5858         (init_cutu_and_read_dies_simple): Reflect API changes.
5859         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
5860         (create_cus_hash_table): Change API to take parent compile unit.
5861         Reflect API changes.
5862         (open_and_init_dwo_file): Reflect API changes.
5863         (dwarf2_get_pc_bounds): Update comments.
5864         (dwarf2_record_block_ranges): Likewise.
5865         (read_full_die_1): Change implementation to reprocess attributes that
5866         need str_offsets_base and addr_base.
5867         (partial_die_info::read): Likewise.
5868         (read_attribute_reprocess): New function definition.
5869         (read_attribute_value): Change API to take an additional out parameter,
5870         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
5871         when a non-dwo compile unit has index based attributes.
5872         (read_attribute): Reflect API changes.
5873         (read_addr_index_1): Reflect API changes.  Update comments.
5874         (dwarf2_read_addr_index_data): Reflect API changes.
5875         (dwarf2_read_addr_index): Likewise.
5876         (read_str_index): Change API and implementation.  This becomes a helper
5877         to be used by the new string index related methods.  Update error
5878         message and comments.
5879         (read_dwo_str_index): New function definition.
5880         (read_stub_str_index): Likewise.
5881         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
5882         * symfile.h (dwarf2_debug_sections): Likewise.
5883         * xcoffread.c (dwarf2_debug_sections): Likewise.
5884
5885 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5886
5887         * gdbcore.h (struct core_fns) <core_read_registers>: Change
5888         core_reg_sect type to gdb_byte *.
5889         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
5890         * cris-tdep.c (fetch_core_registers): Likewise.
5891         * corelow.c (core_target::get_core_register_section): Change
5892         type of `contents` to gdb::byte_vector.
5893
5894 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5895
5896         * tui/tui-wingeneral.c (box_win): Position the title in the center
5897         of the border.
5898
5899 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
5900
5901         * corelow.c (core_target::get_core_register_section): Use
5902           std::vector instead of alloca.
5903
5904 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5905
5906         * warning.m4: Add -Wmissing-declarations to build_warnings.
5907         * configure: Re-generate.
5908
5909 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5910
5911         * python/python.c (init__gdb_module): Add declaration.
5912
5913 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5914
5915         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
5916         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
5917         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
5918         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
5919         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
5920         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
5921         * ada-exp.y (_initialize_ada_exp): Add declaration.
5922         * ada-lang.c (_initialize_ada_language): Add declaration.
5923         * ada-tasks.c (_initialize_tasks): Add declaration.
5924         * agent.c (_initialize_agent): Add declaration.
5925         * aix-thread.c (_initialize_aix_thread): Add declaration.
5926         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
5927         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
5928         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
5929         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
5930         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
5931         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
5932         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
5933         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
5934         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
5935         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
5936         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
5937         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
5938         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
5939         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
5940         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
5941         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
5942         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
5943         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
5944         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
5945         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
5946         * annotate.c (_initialize_annotate): Add declaration.
5947         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
5948         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
5949         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
5950         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
5951         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
5952         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
5953         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
5954         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
5955         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
5956         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
5957         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
5958         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
5959         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
5960         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
5961         * auto-load.c (_initialize_auto_load): Add declaration.
5962         * auxv.c (_initialize_auxv): Add declaration.
5963         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
5964         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
5965         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
5966         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
5967         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
5968         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
5969         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
5970         * breakpoint.c (_initialize_breakpoint): Add declaration.
5971         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
5972         * btrace.c (_initialize_btrace): Add declaration.
5973         * charset.c (_initialize_charset): Add declaration.
5974         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
5975         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
5976         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
5977         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
5978         * cli/cli-script.c (_initialize_cli_script): Add declaration.
5979         * cli/cli-style.c (_initialize_cli_style): Add declaration.
5980         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
5981         * coffread.c (_initialize_coffread): Add declaration.
5982         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
5983         * compile/compile.c (_initialize_compile): Add declaration.
5984         * complaints.c (_initialize_complaints): Add declaration.
5985         * completer.c (_initialize_completer): Add declaration.
5986         * copying.c (_initialize_copying): Add declaration.
5987         * corefile.c (_initialize_core): Add declaration.
5988         * corelow.c (_initialize_corelow): Add declaration.
5989         * cp-abi.c (_initialize_cp_abi): Add declaration.
5990         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
5991         * cp-support.c (_initialize_cp_support): Add declaration.
5992         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
5993         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
5994         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
5995         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
5996         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
5997         * ctfread.c (_initialize_ctfread): Add declaration.
5998         * d-lang.c (_initialize_d_language): Add declaration.
5999         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
6000         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
6001         * dbxread.c (_initialize_dbxread): Add declaration.
6002         * dcache.c (_initialize_dcache): Add declaration.
6003         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
6004         * disasm.c (_initialize_disasm): Add declaration.
6005         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
6006         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
6007         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
6008         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
6009         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
6010         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
6011         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
6012         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
6013         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
6014         * elfread.c (_initialize_elfread): Add declaration.
6015         * exec.c (_initialize_exec): Add declaration.
6016         * extension.c (_initialize_extension): Add declaration.
6017         * f-lang.c (_initialize_f_language): Add declaration.
6018         * f-valprint.c (_initialize_f_valprint): Add declaration.
6019         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
6020         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
6021         * filesystem.c (_initialize_filesystem): Add declaration.
6022         * findcmd.c (_initialize_mem_search): Add declaration.
6023         * findvar.c (_initialize_findvar): Add declaration.
6024         * fork-child.c (_initialize_fork_child): Add declaration.
6025         * frame-base.c (_initialize_frame_base): Add declaration.
6026         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
6027         * frame.c (_initialize_frame): Add declaration.
6028         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
6029         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
6030         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
6031         * gcore.c (_initialize_gcore): Add declaration.
6032         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
6033         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
6034         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
6035         * gdbarch.c (_initialize_gdbarch): Add declaration.
6036         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
6037         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
6038         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
6039         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
6040         * go-lang.c (_initialize_go_language): Add declaration.
6041         * go32-nat.c (_initialize_go32_nat): Add declaration.
6042         * guile/guile.c (_initialize_guile): Add declaration.
6043         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
6044         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
6045         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
6046         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
6047         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
6048         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
6049         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
6050         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
6051         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
6052         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
6053         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
6054         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
6055         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
6056         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
6057         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
6058         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
6059         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
6060         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
6061         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
6062         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
6063         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
6064         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
6065         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
6066         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
6067         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
6068         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
6069         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
6070         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
6071         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
6072         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
6073         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
6074         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
6075         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
6076         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
6077         * infcall.c (_initialize_infcall): Add declaration.
6078         * infcmd.c (_initialize_infcmd): Add declaration.
6079         * inflow.c (_initialize_inflow): Add declaration.
6080         * infrun.c (_initialize_infrun): Add declaration.
6081         * interps.c (_initialize_interpreter): Add declaration.
6082         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
6083         * jit.c (_initialize_jit): Add declaration.
6084         * language.c (_initialize_language): Add declaration.
6085         * linux-fork.c (_initialize_linux_fork): Add declaration.
6086         * linux-nat.c (_initialize_linux_nat): Add declaration.
6087         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
6088         * linux-thread-db.c (_initialize_thread_db): Add declaration.
6089         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
6090         * m2-lang.c (_initialize_m2_language): Add declaration.
6091         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
6092         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
6093         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
6094         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
6095         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
6096         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
6097         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
6098         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
6099         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
6100         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
6101         * machoread.c (_initialize_machoread): Add declaration.
6102         * macrocmd.c (_initialize_macrocmd): Add declaration.
6103         * macroscope.c (_initialize_macroscope): Add declaration.
6104         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
6105         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
6106         * maint.c (_initialize_maint_cmds): Add declaration.
6107         * mdebugread.c (_initialize_mdebugread): Add declaration.
6108         * memattr.c (_initialize_mem): Add declaration.
6109         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
6110         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
6111         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
6112         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
6113         * mi/mi-main.c (_initialize_mi_main): Add declaration.
6114         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
6115         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
6116         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
6117         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
6118         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
6119         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
6120         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
6121         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
6122         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
6123         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
6124         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
6125         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
6126         * mipsread.c (_initialize_mipsread): Add declaration.
6127         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
6128         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
6129         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
6130         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
6131         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
6132         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
6133         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
6134         * nto-procfs.c (_initialize_procfs): Add declaration.
6135         * objc-lang.c (_initialize_objc_language): Add declaration.
6136         * observable.c (_initialize_observer): Add declaration.
6137         * opencl-lang.c (_initialize_opencl_language): Add declaration.
6138         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
6139         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
6140         * osabi.c (_initialize_gdb_osabi): Add declaration.
6141         * osdata.c (_initialize_osdata): Add declaration.
6142         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
6143         * parse.c (_initialize_parse): Add declaration.
6144         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
6145         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
6146         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
6147         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
6148         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
6149         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
6150         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
6151         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
6152         * printcmd.c (_initialize_printcmd): Add declaration.
6153         * probe.c (_initialize_probe): Add declaration.
6154         * proc-api.c (_initialize_proc_api): Add declaration.
6155         * proc-events.c (_initialize_proc_events): Add declaration.
6156         * proc-service.c (_initialize_proc_service): Add declaration.
6157         * procfs.c (_initialize_procfs): Add declaration.
6158         * producer.c (_initialize_producer): Add declaration.
6159         * psymtab.c (_initialize_psymtab): Add declaration.
6160         * python/python.c (_initialize_python): Add declaration.
6161         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
6162         * record-btrace.c (_initialize_record_btrace): Add declaration.
6163         * record-full.c (_initialize_record_full): Add declaration.
6164         * record.c (_initialize_record): Add declaration.
6165         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
6166         * regcache.c (_initialize_regcache): Add declaration.
6167         * reggroups.c (_initialize_reggroup): Add declaration.
6168         * remote-notif.c (_initialize_notif): Add declaration.
6169         * remote-sim.c (_initialize_remote_sim): Add declaration.
6170         * remote.c (_initialize_remote): Add declaration.
6171         * reverse.c (_initialize_reverse): Add declaration.
6172         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
6173         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
6174         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
6175         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
6176         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
6177         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
6178         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
6179         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
6180         Add declaration.
6181         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
6182         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
6183         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
6184         * rust-exp.y (_initialize_rust_exp): Add declaration.
6185         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
6186         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
6187         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
6188         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
6189         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
6190         * score-tdep.c (_initialize_score_tdep): Add declaration.
6191         * ser-go32.c (_initialize_ser_dos): Add declaration.
6192         * ser-mingw.c (_initialize_ser_windows): Add declaration.
6193         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
6194         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
6195         * ser-uds.c (_initialize_ser_socket): Add declaration.
6196         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
6197         * serial.c (_initialize_serial): Add declaration.
6198         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
6199         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
6200         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
6201         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
6202         * skip.c (_initialize_step_skip): Add declaration.
6203         * sol-thread.c (_initialize_sol_thread): Add declaration.
6204         * solib-aix.c (_initialize_solib_aix): Add declaration.
6205         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
6206         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
6207         * solib-frv.c (_initialize_frv_solib): Add declaration.
6208         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
6209         * solib-target.c (_initialize_solib_target): Add declaration.
6210         * solib.c (_initialize_solib): Add declaration.
6211         * source-cache.c (_initialize_source_cache): Add declaration.
6212         * source.c (_initialize_source): Add declaration.
6213         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
6214         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
6215         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
6216         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
6217         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
6218         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
6219         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
6220         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
6221         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
6222         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
6223         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
6224         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
6225         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
6226         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
6227         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
6228         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
6229         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
6230         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
6231         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
6232         * stabsread.c (_initialize_stabsread): Add declaration.
6233         * stack.c (_initialize_stack): Add declaration.
6234         * stap-probe.c (_initialize_stap_probe): Add declaration.
6235         * std-regs.c (_initialize_frame_reg): Add declaration.
6236         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
6237         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
6238         * symfile.c (_initialize_symfile): Add declaration.
6239         * symmisc.c (_initialize_symmisc): Add declaration.
6240         * symtab.c (_initialize_symtab): Add declaration.
6241         * target.c (_initialize_target): Add declaration.
6242         * target-connection.c (_initialize_target_connection): Add
6243         declaration.
6244         * target-dcache.c (_initialize_target_dcache): Add declaration.
6245         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
6246         * thread.c (_initialize_thread): Add declaration.
6247         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
6248         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
6249         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
6250         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
6251         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
6252         * tracectf.c (_initialize_ctf): Add declaration.
6253         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
6254         * tracefile.c (_initialize_tracefile): Add declaration.
6255         * tracepoint.c (_initialize_tracepoint): Add declaration.
6256         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
6257         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
6258         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
6259         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
6260         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
6261         * tui/tui-win.c (_initialize_tui_win): Add declaration.
6262         * tui/tui.c (_initialize_tui): Add declaration.
6263         * typeprint.c (_initialize_typeprint): Add declaration.
6264         * ui-style.c (_initialize_ui_style): Add declaration.
6265         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
6266         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
6267         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
6268         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
6269         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
6270         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
6271         * unittests/filtered_iterator-selftests.c
6272         (_initialize_filtered_iterator_selftests): Add declaration.
6273         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
6274         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
6275         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
6276         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
6277         * unittests/main-thread-selftests.c
6278         (_initialize_main_thread_selftests): Add declaration.
6279         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
6280         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
6281         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
6282         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
6283         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
6284         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
6285         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
6286         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
6287         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
6288         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
6289         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
6290         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
6291         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
6292         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
6293         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
6294         declaration.
6295         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
6296         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
6297         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
6298         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
6299         * user-regs.c (_initialize_user_regs): Add declaration.
6300         * utils.c (_initialize_utils): Add declaration.
6301         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
6302         * valops.c (_initialize_valops): Add declaration.
6303         * valprint.c (_initialize_valprint): Add declaration.
6304         * value.c (_initialize_values): Add declaration.
6305         * varobj.c (_initialize_varobj): Add declaration.
6306         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
6307         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
6308         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
6309         * windows-nat.c (_initialize_windows_nat): Add declaration.
6310         (_initialize_check_for_gdb_ini): Add declaration.
6311         (_initialize_loadable): Add declaration.
6312         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
6313         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
6314         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
6315         * xcoffread.c (_initialize_xcoffread): Add declaration.
6316         * xml-support.c (_initialize_xml_support): Add declaration.
6317         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
6318         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
6319         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
6320         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
6321
6322 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6323
6324         * regformats/regdat.sh: Generate declaration for init function.
6325
6326 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6327
6328         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
6329         up.
6330         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
6331         close_one_inferior>: New methods.
6332         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
6333         pass down target to find_inferior_pid.
6334         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
6335         Pass down target to find_inferior_ptid.
6336         (gdbsim_target::create_inferior): Pass down target to
6337         add_thread_silent.
6338         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
6339         target down to find_inferior_ptid and switch_to_thread.
6340         (gdbsim_target::close): Update to call close_one_inferior.
6341         (struct resume_data): Remove.
6342         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
6343         directly, rather than through a void pointer.
6344         (gdbsim_target::resume): Update to call resume_one_inferior.
6345
6346 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
6347
6348         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
6349
6350 2020-01-12  Pedro Alves  <palves@redhat.com>
6351
6352         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
6353         directly for the current inferior instead of
6354         discard_all_inferiors.
6355         (discard_all_inferiors): Delete.
6356
6357 2020-01-11  Tom Tromey  <tom@tromey.com>
6358
6359         * tui/tui-wingeneral.c (box_win): Check cli_styling.
6360         * tui/tui-winsource.c (tui_source_window_base::refill): Use
6361         deprecated_safe_get_selected_frame.
6362
6363 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6364
6365         * inferior.c (print_inferior): Switch inferior before printing it.
6366
6367 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
6368             Pedro Alves  <palves@redhat.com>
6369
6370         * progspace-and-thread.c (switch_to_program_space_and_thread):
6371         Assert there's an inferior for PSPACE.  Use
6372         switch_to_inferior_no_thread to switch the inferior too.
6373         * progspace.c (program_space::~program_space): Call
6374         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
6375         (program_space::free_all_objfiles): Don't call clear_symtab_users
6376         here.
6377         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
6378
6379 2020-01-10  Pedro Alves  <palves@redhat.com>
6380
6381         * NEWS: Mention multi-target debugging, "info connections", and
6382         "add-inferior -no-connection".
6383
6384 2020-01-10  Pedro Alves  <palves@redhat.com>
6385
6386         * infrun.c: Include "target-connection.h".
6387         (check_multi_target_resumption): New.
6388         (proceed): Call it.
6389         * target-connection.c (make_target_connection_string): Make
6390         extern.
6391         * target-connection.h (make_target_connection_string): Declare.
6392
6393 2020-01-10  Pedro Alves  <palves@redhat.com>
6394
6395         * Makefile.in (COMMON_SFILES): Add target-connection.c.
6396         * inferior.c (uiout_field_connection): New function.
6397         (print_inferior): Add new "connection-id" column.
6398         (add_inferior_command): Show connection number/string of added
6399         inferior.
6400         * process-stratum-target.h
6401         (process_stratum_target::connection_string): New virtual method.
6402         (process_stratum_target::connection_number): New field.
6403         * remote.c (remote_target::connection_string): New override.
6404         * target-connection.c: New file.
6405         * target-connection.h: New file.
6406         * target.c (decref_target): Remove process_stratum targets from
6407         the connection list.
6408         (target_stack::push): Add process_stratum targets to the
6409         connection list.
6410
6411 2020-01-10  Pedro Alves  <palves@redhat.com>
6412
6413         Revert:
6414         2016-04-12  Pedro Alves  <palves@redhat.com>
6415         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
6416         Remove references to name.
6417         * serial.h (struct serial) <name>: Delete.
6418
6419 2020-01-10  Pedro Alves  <palves@redhat.com>
6420
6421         * gdbarch-selftests.c (register_to_value_test): Remove "target
6422         already pushed" check.
6423
6424 2020-01-10  Pedro Alves  <palves@redhat.com>
6425             John Baldwin  <jhb@FreeBSD.org>
6426
6427         * aarch64-linux-nat.c
6428         (aarch64_linux_nat_target::thread_architecture): Adjust.
6429         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
6430         (task_command_1): Likewise.
6431         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
6432         (aix_thread_target::wait, aix_thread_target::fetch_registers)
6433         (aix_thread_target::store_registers)
6434         (aix_thread_target::thread_alive): Adjust.
6435         * amd64-fbsd-tdep.c: Include "inferior.h".
6436         (amd64fbsd_get_thread_local_address): Pass down target.
6437         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
6438         thread's gdbarch instead of target_gdbarch.
6439         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
6440         get_last_target_status.
6441         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
6442         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
6443         inferiors.
6444         (update_inserted_breakpoint_locations): Skip if inferiors with no
6445         execution.
6446         (update_global_location_list): When handling moribund locations,
6447         find representative inferior for location's pspace, and use thread
6448         count of its process_stratum target.
6449         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
6450         * bsd-uthread.c (bsd_uthread_target::wait): Use
6451         as_process_stratum_target and adjust thread_change_ptid and
6452         add_thread calls.
6453         (bsd_uthread_target::update_thread_list): Use
6454         as_process_stratum_target and adjust find_thread_ptid,
6455         thread_change_ptid and add_thread calls.
6456         * btrace.c (maint_btrace_packet_history_cmd): Adjust
6457         find_thread_ptid call.
6458         * corelow.c (add_to_thread_list): Adjust add_thread call.
6459         (core_target_open): Adjust add_thread_silent and thread_count
6460         calls.
6461         (core_target::pid_to_str): Adjust find_inferior_ptid call.
6462         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
6463         * event-top.c (async_disconnect): Pop targets from all inferiors.
6464         * exec.c (add_target_sections): Push exec target on all inferiors
6465         sharing the program space.
6466         (remove_target_sections): Remove the exec target from all
6467         inferiors sharing the program space.
6468         (exec_on_vfork): New.
6469         * exec.h (exec_on_vfork): Declare.
6470         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
6471         Pass it down.
6472         (fbsd_nat_target::update_thread_list): Adjust.
6473         (fbsd_nat_target::resume): Adjust.
6474         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
6475         down.
6476         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
6477         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
6478         get_thread_arch_regcache call.
6479         * fork-child.c (gdb_startup_inferior): Pass target down to
6480         startup_inferior and set_executing.
6481         * gdbthread.h (struct process_stratum_target): Forward declare.
6482         (add_thread, add_thread_silent, add_thread_with_info)
6483         (in_thread_list): Add process_stratum_target parameter.
6484         (find_thread_ptid(inferior*, ptid_t)): New overload.
6485         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
6486         parameter.
6487         (all_threads()): Delete overload.
6488         (all_threads, all_non_exited_threads): Add process_stratum_target
6489         parameter.
6490         (all_threads_safe): Use brace initialization.
6491         (thread_count): Add process_stratum_target parameter.
6492         (set_resumed, set_running, set_stop_requested, set_executing)
6493         (threads_are_executing, finish_thread_state): Add
6494         process_stratum_target parameter.
6495         (switch_to_thread): Use is_current_thread.
6496         * i386-fbsd-tdep.c: Include "inferior.h".
6497         (i386fbsd_get_thread_local_address): Pass down target.
6498         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
6499         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
6500         have_inferiors check.
6501         * inf-ptrace.c (inf_ptrace_target::create_inferior)
6502         (inf_ptrace_target::attach): Adjust.
6503         * infcall.c (run_inferior_call): Adjust.
6504         * infcmd.c (run_command_1): Pass target to
6505         scoped_finish_thread_state.
6506         (proceed_thread_callback): Skip inferiors with no execution.
6507         (continue_command): Rename 'all_threads' local to avoid hiding
6508         'all_threads' function.  Adjust get_last_target_status call.
6509         (prepare_one_step): Adjust set_running call.
6510         (signal_command): Use user_visible_resume_target.  Compare thread
6511         pointers instead of inferior_ptid.
6512         (info_program_command): Adjust to pass down target.
6513         (attach_command): Mark target's 'thread_executing' flag.
6514         (stop_current_target_threads_ns): New, factored out from ...
6515         (interrupt_target_1): ... this.  Switch inferior before making
6516         target calls.
6517         * inferior-iter.h
6518         (struct all_inferiors_iterator, struct all_inferiors_range)
6519         (struct all_inferiors_safe_range)
6520         (struct all_non_exited_inferiors_range): Filter on
6521         process_stratum_target too.  Remove explicit.
6522         * inferior.c (inferior::inferior): Push dummy target on target
6523         stack.
6524         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
6525         Add process_stratum_target parameter, and pass it down.
6526         (have_live_inferiors): Adjust.
6527         (switch_to_inferior_and_push_target): New.
6528         (add_inferior_command, clone_inferior_command): Handle
6529         "-no-connection" parameter.  Use
6530         switch_to_inferior_and_push_target.
6531         (_initialize_inferior): Mention "-no-connection" option in
6532         the help of "add-inferior" and "clone-inferior" commands.
6533         * inferior.h: Include "process-stratum-target.h".
6534         (interrupt_target_1): Use bool.
6535         (struct inferior) <push_target, unpush_target, target_is_pushed,
6536         find_target_beneath, top_target, process_target, target_at,
6537         m_stack>: New.
6538         (discard_all_inferiors): Delete.
6539         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
6540         (all_inferiors, all_non_exited_inferiors): Add
6541         process_stratum_target parameter.
6542         * infrun.c: Include "gdb_select.h" and <unordered_map>.
6543         (target_last_proc_target): New global.
6544         (follow_fork_inferior): Push target on new inferior.  Pass target
6545         to add_thread_silent.  Call exec_on_vfork.  Handle target's
6546         reference count.
6547         (follow_fork): Adjust get_last_target_status call.  Also consider
6548         target.
6549         (follow_exec): Push target on new inferior.
6550         (struct execution_control_state) <target>: New field.
6551         (user_visible_resume_target): New.
6552         (do_target_resume): Call target_async.
6553         (resume_1): Set target's threads_executing flag.  Consider resume
6554         target.
6555         (commit_resume_all_targets): New.
6556         (proceed): Also consider resume target.  Skip threads of inferiors
6557         with no execution.  Commit resumtion in all targets.
6558         (start_remote): Pass current inferior to wait_for_inferior.
6559         (infrun_thread_stop_requested): Consider target as well.  Pass
6560         thread_info pointer to clear_inline_frame_state instead of ptid.
6561         (infrun_thread_thread_exit): Consider target as well.
6562         (random_pending_event_thread): New inferior parameter.  Use it.
6563         (do_target_wait): Rename to ...
6564         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
6565         down.
6566         (threads_are_resumed_pending_p, do_target_wait): New.
6567         (prepare_for_detach): Adjust calls.
6568         (wait_for_inferior): New inferior parameter.  Handle it.  Use
6569         do_target_wait_1 instead of do_target_wait.
6570         (fetch_inferior_event): Adjust.  Switch to representative
6571         inferior.  Pass target down.
6572         (set_last_target_status): Add process_stratum_target parameter.
6573         Save target in global.
6574         (get_last_target_status): Add process_stratum_target parameter and
6575         handle it.
6576         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
6577         (context_switch): Check inferior_ptid == null_ptid before calling
6578         inferior_thread().
6579         (get_inferior_stop_soon): Pass down target.
6580         (wait_one): Rename to ...
6581         (poll_one_curr_target): ... this.
6582         (struct wait_one_event): New.
6583         (wait_one): New.
6584         (stop_all_threads): Adjust.
6585         (handle_no_resumed, handle_inferior_event): Adjust to consider the
6586         event's target.
6587         (switch_back_to_stepped_thread): Also consider target.
6588         (print_stop_event): Update.
6589         (normal_stop): Update.  Also consider the resume target.
6590         * infrun.h (wait_for_inferior): Remove declaration.
6591         (user_visible_resume_target): New declaration.
6592         (get_last_target_status, set_last_target_status): New
6593         process_stratum_target parameter.
6594         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6595         process_stratum_target parameter, and use it.
6596         (clear_inline_frame_state (thread_info*)): New.
6597         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6598         process_stratum_target parameter.
6599         (clear_inline_frame_state (thread_info*)): Declare.
6600         * linux-fork.c (delete_checkpoint_command): Pass target down to
6601         find_thread_ptid.
6602         (checkpoint_command): Adjust.
6603         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
6604         instead of just tweaking inferior_ptid.
6605         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
6606         (exit_lwp): Pass target down to find_thread_ptid.
6607         (attach_proc_task_lwp_callback): Pass target down to
6608         add_thread/set_running/set_executing.
6609         (linux_nat_target::attach): Pass target down to
6610         thread_change_ptid.
6611         (get_detach_signal): Pass target down to find_thread_ptid.
6612         Consider last target status's target.
6613         (linux_resume_one_lwp_throw, resume_lwp)
6614         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
6615         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
6616         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
6617         (linux_nat_target::async_wait_fd): New.
6618         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
6619         target down.
6620         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
6621         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
6622         * linux-thread-db.c (struct thread_db_info::process_target): New
6623         field.
6624         (add_thread_db_info): Save target.
6625         (get_thread_db_info): New process_stratum_target parameter.  Also
6626         match target.
6627         (delete_thread_db_info): New process_stratum_target parameter.
6628         Also match target.
6629         (thread_from_lwp): Adjust to pass down target.
6630         (thread_db_notice_clone): Pass down target.
6631         (check_thread_db_callback): Pass down target.
6632         (try_thread_db_load_1): Always push the thread_db target.
6633         (try_thread_db_load, record_thread): Pass target down.
6634         (thread_db_target::detach): Pass target down.  Always unpush the
6635         thread_db target.
6636         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
6637         target down.  Always unpush the thread_db target.
6638         (find_new_threads_callback, thread_db_find_new_threads_2)
6639         (thread_db_target::update_thread_list): Pass target down.
6640         (thread_db_target::pid_to_str): Pass current inferior down.
6641         (thread_db_target::get_thread_local_address): Pass target down.
6642         (thread_db_target::resume, maintenance_check_libthread_db): Pass
6643         target down.
6644         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
6645         * procfs.c (procfs_target::procfs_init_inferior): Declare.
6646         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
6647         (procfs_init_inferior): Rename to ...
6648         (procfs_target::procfs_init_inferior): ... this and adjust.
6649         (procfs_target::create_inferior, procfs_notice_thread)
6650         (procfs_do_thread_registers): Adjust.
6651         * ppc-fbsd-tdep.c: Include "inferior.h".
6652         (ppcfbsd_get_thread_local_address): Pass down target.
6653         * proc-service.c (ps_xfer_memory): Switch current inferior and
6654         program space as well.
6655         (get_ps_regcache): Pass target down.
6656         * process-stratum-target.c
6657         (process_stratum_target::thread_address_space)
6658         (process_stratum_target::thread_architecture): Pass target down.
6659         * process-stratum-target.h
6660         (process_stratum_target::threads_executing): New field.
6661         (as_process_stratum_target): New.
6662         * ravenscar-thread.c
6663         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
6664         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
6665         down.
6666         * record-btrace.c (record_btrace_target::info_record): Adjust.
6667         (record_btrace_target::record_method)
6668         (record_btrace_target::record_is_replaying)
6669         (record_btrace_target::fetch_registers)
6670         (get_thread_current_frame_id, record_btrace_target::resume)
6671         (record_btrace_target::wait, record_btrace_target::stop): Pass
6672         target down.
6673         * record-full.c (record_full_wait_1): Switch to event thread.
6674         Pass target down.
6675         * regcache.c (regcache::regcache)
6676         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
6677         process_stratum_target parameter and handle it.
6678         (current_thread_target): New global.
6679         (get_thread_regcache): Add process_stratum_target parameter and
6680         handle it.  Switch inferior before calling target method.
6681         (get_thread_regcache): Pass target down.
6682         (get_thread_regcache_for_ptid): Pass target down.
6683         (registers_changed_ptid): Add process_stratum_target parameter and
6684         handle it.
6685         (registers_changed_thread, registers_changed): Pass target down.
6686         (test_get_thread_arch_aspace_regcache): New.
6687         (current_regcache_test): Define a couple local test_target_ops
6688         instances and use them for testing.
6689         (readwrite_regcache): Pass process_stratum_target parameter.
6690         (cooked_read_test, cooked_write_test): Pass mock_target down.
6691         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
6692         (get_thread_arch_aspace_regcache): Add process_stratum_target
6693         parameter.
6694         (regcache::target): New method.
6695         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
6696         (regcache::registers_changed_ptid): Add process_stratum_target
6697         parameter.
6698         (regcache::m_target): New field.
6699         (registers_changed_ptid): Add process_stratum_target parameter.
6700         * remote.c (remote_state::supports_vCont_probed): New field.
6701         (remote_target::async_wait_fd): New method.
6702         (remote_unpush_and_throw): Add remote_target parameter.
6703         (get_current_remote_target): Adjust.
6704         (remote_target::remote_add_inferior): Push target.
6705         (remote_target::remote_add_thread)
6706         (remote_target::remote_notice_new_inferior)
6707         (get_remote_thread_info): Pass target down.
6708         (remote_target::update_thread_list): Skip threads of inferiors
6709         bound to other targets.  (remote_target::close): Don't discard
6710         inferiors.  (remote_target::add_current_inferior_and_thread)
6711         (remote_target::process_initial_stop_replies)
6712         (remote_target::start_remote)
6713         (remote_target::remote_serial_quit_handler): Pass down target.
6714         (remote_target::remote_unpush_target): New remote_target
6715         parameter.  Unpush the target from all inferiors.
6716         (remote_target::remote_unpush_and_throw): New remote_target
6717         parameter.  Pass it down.
6718         (remote_target::open_1): Check whether the current inferior has
6719         execution instead of checking whether any inferior is live.  Pass
6720         target down.
6721         (remote_target::remote_detach_1): Pass down target.  Use
6722         remote_unpush_target.
6723         (extended_remote_target::attach): Pass down target.
6724         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
6725         (remote_target::append_resumption): Pass down target.
6726         (remote_target::append_pending_thread_resumptions)
6727         (remote_target::remote_resume_with_hc, remote_target::resume)
6728         (remote_target::commit_resume): Pass down target.
6729         (remote_target::remote_stop_ns): Check supports_vCont_probed.
6730         (remote_target::interrupt_query)
6731         (remote_target::remove_new_fork_children)
6732         (remote_target::check_pending_events_prevent_wildcard_vcont)
6733         (remote_target::remote_parse_stop_reply)
6734         (remote_target::process_stop_reply): Pass down target.
6735         (first_remote_resumed_thread): New remote_target parameter.  Pass
6736         it down.
6737         (remote_target::wait_as): Pass down target.
6738         (unpush_and_perror): New remote_target parameter.  Pass it down.
6739         (remote_target::readchar, remote_target::remote_serial_write)
6740         (remote_target::getpkt_or_notif_sane_1)
6741         (remote_target::kill_new_fork_children, remote_target::kill): Pass
6742         down target.
6743         (remote_target::mourn_inferior): Pass down target.  Use
6744         remote_unpush_target.
6745         (remote_target::core_of_thread)
6746         (remote_target::remote_btrace_maybe_reopen): Pass down target.
6747         (remote_target::pid_to_exec_file)
6748         (remote_target::thread_handle_to_thread_info): Pass down target.
6749         (remote_target::async_wait_fd): New.
6750         * riscv-fbsd-tdep.c: Include "inferior.h".
6751         (riscv_fbsd_get_thread_local_address): Pass down target.
6752         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
6753         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
6754         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
6755         Adjust.
6756         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
6757         * solib-svr4.c (enable_break): Pass down target.
6758         * spu-multiarch.c (parse_spufs_run): Pass down target.
6759         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
6760         * target-delegates.c: Regenerate.
6761         * target.c (g_target_stack): Delete.
6762         (current_top_target): Return the current inferior's top target.
6763         (target_has_execution_1): Refer to the passed-in inferior's top
6764         target.
6765         (target_supports_terminal_ours): Check whether the initial
6766         inferior was already created.
6767         (decref_target): New.
6768         (target_stack::push): Incref/decref the target.
6769         (push_target, push_target, unpush_target): Adjust.
6770         (target_stack::unpush): Defref target.
6771         (target_is_pushed): Return bool.  Adjust to refer to the current
6772         inferior's target stack.
6773         (dispose_inferior): Delete, and inline parts ...
6774         (target_preopen): ... here.  Only dispose of the current inferior.
6775         (target_detach): Hold strong target reference while detaching.
6776         Pass target down.
6777         (target_thread_name): Add assertion.
6778         (target_resume): Pass down target.
6779         (target_ops::beneath, find_target_at): Adjust to refer to the
6780         current inferior's target stack.
6781         (get_dummy_target): New.
6782         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
6783         has a thread running.
6784         (initialize_targets): Rename to ...
6785         (_initialize_target): ... this.
6786         * target.h: Include "gdbsupport/refcounted-object.h".
6787         (struct target_ops): Inherit refcounted_object.
6788         (target_ops::shortname, target_ops::longname): Make const.
6789         (target_ops::async_wait_fd): New method.
6790         (decref_target): Declare.
6791         (struct target_ops_ref_policy): New.
6792         (target_ops_ref): New typedef.
6793         (get_dummy_target): Declare function.
6794         (target_is_pushed): Return bool.
6795         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
6796         (all_matching_threads_iterator::all_matching_threads_iterator):
6797         Handle filter target.
6798         * thread-iter.h (struct all_matching_threads_iterator, struct
6799         all_matching_threads_range, class all_non_exited_threads_range):
6800         Filter by target too.  Remove explicit.
6801         * thread.c (threads_executing): Delete.
6802         (inferior_thread): Pass down current inferior.
6803         (clear_thread_inferior_resources): Pass down thread pointer
6804         instead of ptid_t.
6805         (add_thread_silent, add_thread_with_info, add_thread): Add
6806         process_stratum_target parameter.  Use it for thread and inferior
6807         searches.
6808         (is_current_thread): New.
6809         (thread_info::deletable): Use it.
6810         (find_thread_ptid, thread_count, in_thread_list)
6811         (thread_change_ptid, set_resumed, set_running): New
6812         process_stratum_target parameter.  Pass it down.
6813         (set_executing): New process_stratum_target parameter.  Pass it
6814         down.  Adjust reference to 'threads_executing'.
6815         (threads_are_executing): New process_stratum_target parameter.
6816         Adjust reference to 'threads_executing'.
6817         (set_stop_requested, finish_thread_state): New
6818         process_stratum_target parameter.  Pass it down.
6819         (switch_to_thread): Also match inferior.
6820         (switch_to_thread): New process_stratum_target parameter.  Pass it
6821         down.
6822         (update_threads_executing): Reimplement.
6823         * top.c (quit_force): Pop targets from all inferior.
6824         (gdb_init): Don't call initialize_targets.
6825         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
6826         Declare.
6827         (windows_add_thread, windows_delete_thread): Adjust.
6828         (get_windows_debug_event): Rename to ...
6829         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
6830         * tracefile-tfile.c (tfile_target_open): Pass down target.
6831         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
6832         Forward declare.
6833         (switch_to_thread): Add process_stratum_target parameter.
6834         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
6835         parameter.  Use it.
6836         (mi_on_resume): Pass target down.
6837         * nat/fork-inferior.c (startup_inferior): Add
6838         process_stratum_target parameter.  Pass it down.
6839         * nat/fork-inferior.h (startup_inferior): Add
6840         process_stratum_target parameter.
6841         * python/py-threadevent.c (py_get_event_thread): Pass target down.
6842
6843 2020-01-10  Pedro Alves  <palves@redhat.com>
6844
6845         * remote.c (remote_target::start_remote): Don't set inferior_ptid
6846         directly.  Instead find the first thread in the thread list and
6847         use switch_to_thread.
6848
6849 2020-01-10  Pedro Alves  <palves@redhat.com>
6850
6851         * remote.c (remote_target::remote_add_inferior): Don't bind a
6852         process to the current inferior if the current inferior is already
6853         bound to a process.
6854
6855 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6856             Pedro Alves  <palves@redhat.com>
6857
6858         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
6859         If no process is specified, return null_ptid instead of
6860         inferior_ptid.
6861         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
6862         TARGET_WAITKIND_SIGNALLED with no pid.
6863
6864 2020-01-10  Pedro Alves  <palves@redhat.com>
6865
6866         * remote.c (first_remote_resumed_thread): New.
6867         (remote_target::wait_as): Use it as default event_ptid instead of
6868         inferior_ptid.
6869
6870 2020-01-10  Pedro Alves  <palves@redhat.com>
6871
6872         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
6873
6874 2020-01-10  Pedro Alves  <palves@redhat.com>
6875
6876         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
6877         not -1.
6878
6879 2020-01-10  Pedro Alves  <palves@redhat.com>
6880
6881         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
6882         ptid to get_last_target_status.
6883         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
6884         ptid to get_last_target_status.
6885         * infcmd.c (continue_command): Don't pass a target_waitstatus to
6886         get_last_target_status.
6887         (info_program_command): Don't pass a target_waitstatus to
6888         get_last_target_status.
6889         * infrun.c (init_wait_for_inferior): Use
6890         nullify_last_target_wait_ptid.
6891         (get_last_target_status): Handle nullptr arguments.
6892         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
6893         (print_stop_event): Don't pass a ptid to get_last_target_status.
6894         (normal_stop): Don't pass a ptid to get_last_target_status.
6895         * infrun.h (get_last_target_status, set_last_target_status): Move
6896         comments here and update.
6897         (nullify_last_target_wait_ptid): Declare.
6898         * linux-fork.c (fork_load_infrun_state): Remove local extern
6899         declaration of nullify_last_target_wait_ptid.
6900         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
6901         to get_last_target_status.
6902
6903 2020-01-10  Pedro Alves  <palves@redhat.com>
6904
6905         * gdbthread.h (scoped_restore_current_thread)
6906         <dont_restore, restore, m_dont_restore>: Declare.
6907         * thread.c (thread_alive): Add assertion.  Return bool.
6908         (switch_to_thread_if_alive): New.
6909         (prune_threads): Switch inferior/thread.
6910         (print_thread_info_1): Switch thread before calling target methods.
6911         (scoped_restore_current_thread::restore): New, factored out from
6912         ...
6913         (scoped_restore_current_thread::~scoped_restore_current_thread):
6914         ... this.
6915         (scoped_restore_current_thread::scoped_restore_current_thread):
6916         Add assertion.
6917         (thread_apply_all_command, thread_select): Use
6918         switch_to_thread_if_alive.
6919         * infrun.c (proceed, restart_threads, handle_signal_stop)
6920         (switch_back_to_stepped_thread): Switch current thread before
6921         calling target methods.
6922
6923 2020-01-10  Pedro Alves <palves@redhat.com>
6924
6925         * inferior.c (switch_to_inferior_no_thread): New function,
6926         factored out from ...
6927         (inferior_command): ... here.
6928         * inferior.h (switch_to_inferior_no_thread): Declare.
6929         * mi/mi-main.c (run_one_inferior): Use
6930         switch_to_inferior_no_thread.
6931
6932 2020-01-10  Pedro Alves  <palves@redhat.com>
6933
6934         * infcmd.c (kill_command): Remove dead code.
6935
6936 2020-01-10  Pedro Alves  <palves@redhat.com>
6937
6938         * remote.c (remote_target::mourn_inferior): No longer check
6939         whether the target is running.
6940
6941 2020-01-10  Pedro Alves  <palves@redhat.com>
6942
6943         * corelow.c (core_target::has_execution): Change parameter type to
6944         inferior pointer.
6945         * inferior.c (number_of_live_inferiors): Use
6946         inferior::has_execution instead of target_has_execution_1.
6947         * inferior.h (inferior::has_execution): New.
6948         * linux-thread-db.c (thread_db_target::update_thread_list): Use
6949         inferior::has_execution instead of target_has_execution_1.
6950         * process-stratum-target.c
6951         (process_stratum_target::has_execution): Change parameter type to
6952         inferior pointer.  Check the inferior's PID instead of
6953         inferior_ptid.
6954         * process-stratum-target.h
6955         (process_stratum_target::has_execution): Change parameter type to
6956         inferior pointer.
6957         * record-full.c (record_full_core_target::has_execution): Change
6958         parameter type to inferior pointer.
6959         * target.c (target_has_execution_1): Change parameter type to
6960         inferior pointer.
6961         (target_has_execution_current): Adjust.
6962         * target.h (target_ops::has_execution): Change parameter type to
6963         inferior pointer.
6964         (target_has_execution_1): Change parameter type to inferior
6965         pointer.  Change return type to bool.
6966         * tracefile.h (tracefile_target::has_execution): Change parameter
6967         type to inferior pointer.
6968
6969 2020-01-10  Pedro Alves  <palves@redhat.com>
6970
6971         * exceptions.c (print_flush): Remove current_top_target() check.
6972
6973 2020-01-10  Pedro Alves  <palves@redhat.com>
6974
6975         * remote.c (show_remote_exec_file): Show the current inferior's
6976         exec-file instead of the command variable's value.
6977
6978 2020-01-10  Pedro Alves  <palves@redhat.com>
6979
6980         * record-full.c (record_full_resume_ptid): New global.
6981         (record_full_target::resume): Set it.
6982         (record_full_wait_1): Use record_full_resume_ptid instead of
6983         inferior_ptid.
6984
6985 2020-01-10  Pedro Alves  <palves@redhat.com>
6986
6987         * gdbthread.h (scoped_restore_current_thread)
6988         <dont_restore, restore, m_dont_restore>: Declare.
6989         * thread.c (thread_alive): Add assertion.  Return bool.
6990         (switch_to_thread_if_alive): New.
6991         (prune_threads): Switch inferior/thread.
6992         (print_thread_info_1): Switch thread before calling target methods.
6993         (scoped_restore_current_thread::restore): New, factored out from
6994         ...
6995         (scoped_restore_current_thread::~scoped_restore_current_thread):
6996         ... this.
6997         (scoped_restore_current_thread::scoped_restore_current_thread):
6998         Add assertion.
6999         (thread_apply_all_command, thread_select): Use
7000         switch_to_thread_if_alive.
7001
7002 2020-01-10  George Barrett  <bob@bob131.so>
7003
7004         * stap-probe.c (stap_modify_semaphore): Don't check for null
7005         semaphores.
7006         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
7007         for null semaphores.
7008
7009 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7010
7011         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
7012         all source windows, and maintain horizontal scroll status while
7013         doing so.
7014
7015 2020-01-09  Tom Tromey  <tom@tromey.com>
7016
7017         PR tui/18932:
7018         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
7019         update_source_window, not print_source_lines.
7020
7021 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7022
7023         * tui/tui.c (tui_enable): Register tui hooks after calling
7024         tui_display_main.
7025
7026 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
7027
7028         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
7029
7030 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
7031
7032         * thread.c (print_thread_info_1): Fix indentation.
7033
7034 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
7035
7036         * symtab.c (general_symbol_info::compute_and_set_names): Move the
7037         unique_xmalloc_ptr outside the if to always free the demangled name.
7038
7039 2020-01-08  Tom Tromey  <tromey@adacore.com>
7040
7041         * xcoffread.c (enter_line_range, read_xcoff_symtab)
7042         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
7043         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
7044         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
7045         Remove.
7046         (section_offsets): New typedef.
7047         * symtab.c (fixup_section, get_msymbol_address): Update.
7048         * symmisc.c (dump_msymbols): Update.
7049         * symfile.h (relative_addr_info_to_section_offsets)
7050         (symfile_map_offsets_to_segments): Update.
7051         * symfile.c (build_section_addr_info_from_objfile)
7052         (init_objfile_sect_indices): Update.
7053         (struct place_section_arg): Change type of "offsets".
7054         (place_section): Update.
7055         (relative_addr_info_to_section_offsets): Change type of
7056         "section_offsets".  Remove "num_sections" parameter.
7057         (default_symfile_offsets, syms_from_objfile_1)
7058         (set_objfile_default_section_offset): Update.
7059         (reread_symbols): No need to preserve section offsets by hand.
7060         (symfile_map_offsets_to_segments): Change type of "offsets".
7061         * stap-probe.c (relocate_address): Update.
7062         * stabsread.h (process_one_symbol): Update.
7063         * solib-target.c (struct lm_info_target) <offsets>: Change type.
7064         (solib_target_relocate_section_addresses): Update.
7065         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
7066         Update.
7067         * solib-frv.c (frv_relocate_main_executable): Update.
7068         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
7069         * solib-aix.c (solib_aix_get_section_offsets): Change return
7070         type.
7071         (solib_aix_solib_create_inferior_hook): Update.
7072         * remote.c (remote_target::get_offsets): Update.
7073         * psymtab.c (find_pc_sect_psymtab): Update.
7074         * psympriv.h (struct partial_symbol) <address, text_low,
7075         text_high>: Update.
7076         * objfiles.h (obj_section_offset): Update.
7077         (struct objfile) <section_offsets>: Change type.
7078         <num_sections>: Remove.
7079         (objfile_relocate): Update.
7080         * objfiles.c (entry_point_address_query): Update
7081         (relocate_one_symbol): Change type of "section_offsets".
7082         (objfile_relocate1, objfile_relocate1): Change type of
7083         "new_offsets".
7084         (objfile_rebase1): Update.
7085         * mipsread.c (mipscoff_symfile_read): Update.
7086         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
7087         parameter.
7088         * mdebugread.c (parse_symbol): Change type of "section_offsets".
7089         (parse_external, psymtab_to_symtab_1): Update.
7090         * machoread.c (macho_symfile_offsets): Update.
7091         * ia64-tdep.c (ia64_find_unwind_table): Update.
7092         * hppa-tdep.c (read_unwind_info): Update.
7093         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
7094         * dwarf2read.c (create_addrmap_from_index)
7095         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7096         (process_psymtab_comp_unit_reader, add_partial_symbol)
7097         (add_partial_subprogram, process_full_comp_unit)
7098         (read_file_scope, read_func_scope, read_lexical_block_scope)
7099         (read_call_site_scope, dwarf2_rnglists_process)
7100         (dwarf2_ranges_process, dwarf2_ranges_read)
7101         (dwarf_decode_lines_1, var_decode_location, new_symbol)
7102         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
7103         Update.
7104         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
7105         Update.
7106         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
7107         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
7108         (process_one_symbol): Change type of "section_offsets".
7109         * ctfread.c (get_objfile_text_range): Update.
7110         * coffread.c (coff_symtab_read, enter_linenos)
7111         (process_coff_symbol): Update.
7112         * coff-pe-read.c (add_pe_forwarded_sym): Update.
7113         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
7114
7115 2020-01-08  Tom Tromey  <tromey@adacore.com>
7116
7117         * dwarf2read.c (parse_macro_definition): Use std::string.
7118         (parse_macro_definition): Likewise.
7119
7120 2020-01-08  Tom Tromey  <tromey@adacore.com>
7121
7122         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
7123         (ATTR_ALLOC_CHUNK): Remove.
7124
7125 2020-01-08  Tom Tromey  <tromey@adacore.com>
7126
7127         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
7128
7129 2020-01-08  Tom Tromey  <tromey@adacore.com>
7130
7131         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
7132         (dwarf2_compute_name, open_dwo_file): Likewise.
7133         (process_enumeration_scope): Use std::vector.
7134         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
7135         (partial_die_info::fixup, dwarf2_start_subfile)
7136         (guess_full_die_structure_name, dwarf2_name): Likewise.
7137         (determine_prefix): Update.
7138         (guess_full_die_structure_name): Make return type const.
7139         (partial_die_full_name): Return unique_xmalloc_ptr.
7140         (DW_FIELD_ALLOC_CHUNK): Remove.
7141
7142 2020-01-07  Tom Tromey  <tromey@adacore.com>
7143
7144         PR build/24937:
7145         * stap-probe.c (class stap_static_probe_ops): Add constructor.
7146
7147 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
7148
7149         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
7150
7151 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7152
7153         * stack.c (print_frame_info): Move disassemble_next_line code
7154         inside source_print block.
7155
7156 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7157
7158         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
7159         gdb/signals.h, as we are now using native signal symbols.
7160
7161 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
7162
7163         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
7164         overflow by an early check of content vs threshold.
7165         * tui/tui-source.c (tui_source_window::line_is_displayed):
7166         Likewise.
7167
7168 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7169
7170         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
7171
7172 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
7173
7174         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
7175         export table if no section contains it's RVA.
7176
7177 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7178
7179         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
7180
7181 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
7182
7183         * source.c (print_source_lines_base): Set last_line_listed.
7184
7185 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
7186
7187         * tui/tui-disasm.c: Remove trailing spaces.
7188
7189 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7190             Pedro Alves  <palves@redhat.com>
7191
7192         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
7193         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
7194         (windows_gdb_signal_to_target): New function, uses the above
7195         enumeration to convert GDB internal signal codes to equivalent
7196         Windows codes.
7197         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
7198         * windows-nat.c: Include "gdb_wait.h".
7199         (get_windows_debug_event): Extract the fatal exception from the
7200         exit status and convert to the equivalent Posix signal number.
7201         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
7202         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
7203         * gdbsupport/gdb_wait.c: New file, implements
7204         windows_status_to_termsig.
7205         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
7206         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
7207
7208 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7209
7210         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
7211         show_layout.
7212
7213 2020-01-05  Luis Machado  <luis.machado@linaro.org>
7214
7215         * aarch64-linux-nat.c
7216         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
7217         and bfd_mach_aarch64.
7218
7219 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7220
7221         * ui-file.c (stdio_file::can_emit_style_escape)
7222         (tee_file::can_emit_style_escape): Ensure style is used also on
7223         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
7224         to gdb_stdout.
7225         * main.c (set_gdb_data_directory): Use file style to output the
7226         warning that the given pathname is not a directory.
7227         * top.c (show_history_filename, gdb_safe_append_history)
7228         (show_gdb_datadir): Use file style.
7229
7230 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
7231
7232         * solib-target.c (struct lm_info_target):
7233         Change offsets to be a unique_xmalloc_ptr.
7234         (solib_target_relocate_section_addresses): Update.
7235
7236 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
7237
7238         * windows-nat.c (windows_clear_solib): Free so_list linked list.
7239
7240 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
7241
7242         * MAINTAINERS (Write After Approval): Add myself.
7243
7244 2020-01-02  Luis Machado  <luis.machado@linaro.org>
7245
7246         * proc-service.c (get_ps_regcache): Remove reference to obsolete
7247         Cell BE architecture.
7248         * target.h (struct target_ops) <thread_architecture>: Likewise.
7249
7250 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
7251
7252         * Makefile.in: Use INSTALL_PROGRAM_ENV.
7253
7254 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
7255
7256         * MAINTAINERS (Write After Approval): Add myself.
7257
7258 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7259
7260         * gdbarch.sh: Update copyright year range of generated files.
7261
7262 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7263
7264         Update copyright year range in all GDB files.
7265
7266 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7267
7268         * copyright.py: Convert to Python 3.
7269
7270 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7271
7272         * copyright.py: Adapt after move of gnulib directory from gdb
7273         directory to toplevel directory.
7274
7275 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7276
7277         * copyright.py (main): Exit if run from the wrong directory.
7278
7279 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7280
7281         * top.c (print_gdb_version): Change copyright year to 2020.
7282
7283 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7284
7285         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
7286
7287 For older changes see ChangeLog-2019.
7288 \f
7289 Local Variables:
7290 mode: change-log
7291 left-margin: 8
7292 fill-column: 74
7293 version-control: never
7294 coding: utf-8
7295 End: