gdb/ChangeLog

   1 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * btrace.c (btrace_add_pc): Remove whitespace before the template
   4         parameter in 'std::vector <...>'.
   5         (parse_xml_btrace_block): Likewise.
   6         (btrace_maint_decode_pt): Likewise.
   7         (btrace_maint_update_packets): Likewise.
   8         (btrace_maint_print_packets): Likewise.
   9         * btrace.h (struct btrace_maint_info): Likewise.
  10         * dwarf2read.c (struct type_unit_group): Likewise.
  11         (build_type_psymtabs_reader): Likewise.
  12         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
  13         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
  14         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
  15
  16 2019-10-03  Tom de Vries  <tdevries@suse.de>
  17
  18         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
  19         the first line of the help text for set/show style metadata.
  20
  21 2019-10-02  Tom Tromey  <tromey@adacore.com>
  22
  23         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
  24         * gdbsupport/common-inferior.c: New file.
  25         * infcmd.c (startup_with_shell): Don't define.
  26         * nat/fork-inferior.h (startup_with_shell): Don't declare.
  27         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
  28         * inferior.h (startup_with_shell): Don't declare.
  29
  30 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
  31
  32         * gdbsupport/gdb_assert.h: Include errors.h.
  33         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
  34
  35 2019-10-02  Tom Tromey  <tromey@adacore.com>
  36
  37         * NEWS: Add $_ada_exception entry.
  38         * ada-lang.c (struct ada_catchpoint): Add constructor.
  39         <m_kind>: New member.
  40         (allocate_location_exception, re_set_exception): Remove
  41         "ex" parameter.
  42         (should_stop_exception): Compute $_ada_exception.
  43         (check_status_exception, print_it_exception)
  44         (print_one_exception, print_mention_exception): Remove
  45         "ex" parameter.
  46         (allocate_location_catch_exception, re_set_catch_exception)
  47         (check_status_exception, print_it_catch_exception)
  48         (print_one_catch_exception, print_mention_catch_exception)
  49         (print_recreate_catch_exception)
  50         (allocate_location_catch_exception_unhandled)
  51         (re_set_catch_exception_unhandled)
  52         (check_status_exception, print_it_catch_exception_unhandled)
  53         (print_one_catch_exception_unhandled)
  54         (print_mention_catch_exception_unhandled)
  55         (print_recreate_catch_exception_unhandled)
  56         (allocate_location_catch_assert, re_set_catch_assert)
  57         (check_status_assert, print_it_catch_assert)
  58         (print_one_catch_assert, print_mention_catch_assert)
  59         (print_recreate_catch_assert)
  60         (allocate_location_catch_handlers, re_set_catch_handlers)
  61         (check_status_handlers, print_it_catch_handlers)
  62         (print_one_catch_handlers, print_mention_catch_handlers)
  63         (print_recreate_catch_handlers): Remove.
  64         (create_ada_exception_catchpoint): Update.
  65         (initialize_ada_catchpoint_ops): Update.
  66
  67 2019-10-02  Tom Tromey  <tromey@adacore.com>
  68
  69         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
  70         (create_excep_cond_exprs): Simplify exception string computation.
  71         (ada_exception_catchpoint_cond_string): Likewise.
  72
  73 2019-10-02  Tom Tromey  <tromey@adacore.com>
  74
  75         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
  76         * ada-lang.c (lesseq_defined_than): Handle
  77         LOC_STATIC.
  78         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
  79         parameter.
  80         (dwarf2_has_info): Likewise.
  81         (new_symbol): Set maybe_copied on symbol when
  82         appropriate.
  83         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
  84         parameter.
  85         <can_copy>: New member.
  86         * elfread.c (record_minimal_symbol): Set maybe_copied
  87         on symbol when appropriate.
  88         (elf_symfile_read): Update call to dwarf2_has_info.
  89         * minsyms.c (lookup_minimal_symbol_linkage): New
  90         function.
  91         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
  92         * symtab.c (get_symbol_address, get_msymbol_address):
  93         New functions.
  94         * symtab.h (get_symbol_address, get_msymbol_address):
  95         Declare.
  96         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
  97         maybe_copied.
  98         (struct symbol, struct minimal_symbol) <maybe_copied>:
  99         New member.
 100
 101 2019-10-02  Tom Tromey  <tromey@adacore.com>
 102
 103         * source.c (struct current_source_location): New.
 104         (current_source_key): New global.
 105         (current_source_symtab, current_source_line)
 106         (current_source_pspace): Remove.
 107         (get_source_location): New function.
 108         (get_current_source_symtab_and_line)
 109         (set_default_source_symtab_and_line)
 110         (set_current_source_symtab_and_line)
 111         (clear_current_source_symtab_and_line, select_source_symtab)
 112         (info_source_command, print_source_lines_base)
 113         (info_line_command, search_command_helper, _initialize_source):
 114         Update.
 115
 116 2019-10-02  Tom Tromey  <tromey@adacore.com>
 117
 118         * source.c (select_source_symtab): Don't call
 119         decode_line_with_current_source.
 120
 121 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 122
 123         * symtab.c (lookup_global_symbol): Search global block.
 124
 125 2019-10-02  Tom Tromey  <tromey@adacore.com>
 126
 127         * coffread.c (process_coff_symbol): Update.
 128         * dwarf2read.c (var_decode_location, new_symbol): Update.
 129         * mdebugread.c (parse_symbol): Update.
 130         * objfiles.c (relocate_one_symbol): Update.
 131         * stabsread.c (define_symbol, fix_common_block)
 132         (scan_file_globals): Update.
 133         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 134         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 135         * xcoffread.c (process_xcoff_symbol): Update.
 136
 137 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 138
 139         * MAINTAINERS: Update my email address.
 140
 141 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 142
 143         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 144         std::vector.
 145         (build_type_psymtabs_reader): Update for std::vector.
 146         (build_type_psymtab_dependencies): Likewise.
 147         * dwarf2read.h: Remove use of DEF_VEC_P.
 148         (typedef sig_type_ptr): Delete.
 149
 150 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 151
 152         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 153         to std::vector.
 154         (btrace_maint_decode_pt): Likewise, and move allocation of the
 155         vector outside of the loop.
 156         (btrace_maint_update_packets): Update to handle change from VEC to
 157         std::vector.
 158         (btrace_maint_print_packets): Likewise.
 159         (maint_info_btrace_cmd): Likewise.
 160         * btrace.h: Remove use of DEF_VEC_O.
 161         (typedef btrace_pt_packet_s): Delete.
 162         (struct btrace_maint_info) <packets>: Change fromm VEC to
 163         std::vector.
 164         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 165
 166 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 167
 168         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 169         make accesses into the vector constant references.
 170         (btrace_add_pc): Update for std::vector.
 171         (btrace_stitch_bts): Likewise.
 172         (parse_xml_btrace_block): Likewise.
 173         (btrace_maint_update_packets): Likewise.
 174         (btrace_maint_print_packets): Likewise.
 175         (maint_info_btrace_cmd): Likewise.
 176         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 177         std::vector.
 178         (btrace_data::empty): Likewise.
 179         (btrace_data_append): Likewise.
 180         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 181         (typedef btrace_block_s): Delete.
 182         (struct btrace_block): Add constructor.
 183         (struct btrace_data_bts) <blocks>: Change to std::vector.
 184         * nat/linux-btrace.c (perf_event_read_bts): Update for
 185         std::vector.
 186         (linux_read_bts): Likewise.
 187
 188 2019-10-01  Tom Tromey  <tom@tromey.com>
 189
 190         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 191
 192 2019-10-01  Tom Tromey  <tom@tromey.com>
 193
 194         * stack.c (print_frame, info_frame_command_core): Use
 195         styled_string.
 196         * linux-thread-db.c (try_thread_db_load_1)
 197         (try_thread_db_load_from_pdir_1): Use styled_string.
 198         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 199         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 200         (maybe_print_unsupported_script_warning)
 201         (maybe_print_script_not_found_warning): Use styled_string.
 202         * ada-lang.c (user_select_syms): Use styled_string.
 203
 204 2019-10-01  Tom Tromey  <tom@tromey.com>
 205
 206         * p-lang.c (pascal_printstr): Use metadata style.
 207         * value.c (show_convenience): Use metadata style.
 208         * valprint.c (valprint_check_validity, val_print_optimized_out)
 209         (val_print_not_saved, val_print_unavailable)
 210         (val_print_invalid_address, generic_val_print, val_print)
 211         (value_check_printable, val_print_array_elements): Use metadata
 212         style.
 213         * ui-out.h (class ui_out) <field_fmt>: New overload.
 214         <do_field_fmt>: Add style parameter.
 215         * ui-out.c (ui_out::field_fmt): New overload.
 216         * typeprint.c (type_print_unknown_return_type)
 217         (val_print_not_allocated, val_print_not_associated): Use metadata
 218         style.
 219         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 220         parameter.
 221         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 222         * tracepoint.c (tvariables_info_1): Use metadata style.
 223         * stack.c (print_frame_arg, print_frame_info, print_frame)
 224         (info_frame_command_core): Use metadata style.
 225         * skip.c (info_skip_command): Use metadata style.
 226         * rust-lang.c (rust_print_enum): Use metadata style.
 227         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 228         metadata style.
 229         * python/py-framefilter.c (py_print_single_arg): Use metadata
 230         style.
 231         * printcmd.c (do_one_display, print_variable_and_value): Use
 232         metadata style.
 233         * p-valprint.c (pascal_val_print)
 234         (pascal_object_print_value_fields): Use metadata style.
 235         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 236         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 237         parameter.
 238         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 239         * m2-valprint.c (m2_print_long_set): Use metadata style.
 240         * m2-typeprint.c (m2_print_type): Use metadata style.
 241         * infcmd.c (print_return_value_1): Use metadata style.
 242         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 243         * f-valprint.c (info_common_command_for_block): Use metadata
 244         style.
 245         * f-typeprint.c (f_type_print_base): Use metadata style.
 246         * expprint.c (print_subexp_standard): Use metadata style.
 247         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 248         * cli/cli-style.h (class cli_style_option): Add constructor.
 249         (metadata_style): Declare.
 250         * cli/cli-style.c (metadata_style): New global.
 251         (_initialize_cli_style): Register metadata style.
 252         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 253         parameter.
 254         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 255         * c-typeprint.c (c_type_print_base_struct_union)
 256         (c_type_print_base_1): Use metadata style.
 257         * breakpoint.c (watchpoint_value_print)
 258         (print_one_breakpoint_location): Use metadata style.
 259         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 260         style.
 261         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 262         style.
 263         * ada-valprint.c (val_print_packed_array_elements, printstr)
 264         (print_field_values, ada_val_print_ref, ada_val_print): Use
 265         metadata style.
 266         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 267         style.
 268         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 269         style.
 270         * ada-lang.c (user_select_syms): Use metadata style.
 271
 272 2019-10-01  Tom Tromey  <tom@tromey.com>
 273
 274         * cli/cli-cmds.c (pwd_command): Style output.
 275
 276 2019-10-01  Pedro Alves  <palves@redhat.com>
 277             Tom Tromey  <tom@tromey.com>
 278
 279         * symtab.c (print_symbol_info): Use %ps.
 280         (print_msymbol_info): Use %ps.
 281         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 282         * printcmd.c (print_variable_and_value): Use %ps.
 283         * macrocmd.c (show_pp_source_pos): Use %ps.
 284         * infrun.c (print_exited_reason): Use ui_out::message.
 285         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 286         (describe_other_breakpoints): Use ui_out::message and new
 287         formats.
 288         (say_where): Use new formats.
 289         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 290         and new formats.
 291
 292 2019-10-01  Pedro Alves  <palves@redhat.com>
 293             Tom Tromey  <tom@tromey.com>
 294
 295         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 296         (test_gdb_formats): New function.
 297         (run_tests): Call it.
 298         (test_format_specifier): Update.
 299         * utils.h (fputs_filtered): Update comment.
 300         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 301         (fputs_styled_unfiltered): Declare.
 302         * utils.c (fputs_styled_unfiltered): New function.
 303         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 304         (vfprintf_filtered): Update.
 305         (vfprintf_unfiltered, vprintf_filtered): Update.
 306         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 307         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 308         disallow_ui_out_field>: New constants.
 309         (enum class field_kind): New.
 310         (struct base_field_s, struct signed_field_s): New.
 311         (signed_field): New function.
 312         (struct string_field_s): New.
 313         (string_field): New function.
 314         (struct styled_string_s): New.
 315         (styled_string): New function.
 316         (class ui_out) <message>: Add comment.
 317         <vmessage, call_do_message>: New methods.
 318         <do_message>: Add style parameter.
 319         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 320         methods.
 321         (ui_out::message): Rewrite.
 322         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 323         parameter.
 324         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 325         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 326         gdb_extensions parameter.
 327         (class format_piece): Add parameter to constructor.
 328         (n_int_args): New field.
 329         * gdbsupport/format.c (format_pieces::format_pieces): Add
 330         gdb_extensions parameter.  Handle '*'.
 331         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 332         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 333         vfprintf_styled_no_gdbfmt.
 334         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 335         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 336         unfiltered output.
 337         * ui-style.h (struct ui_file_style) <ptr>: New method.
 338
 339 2019-10-01  Tom Tromey  <tom@tromey.com>
 340
 341         * unittests/format_pieces-selftests.c: Update.  Add final format.
 342         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 343         empty literal pieces.
 344
 345 2019-10-01  Tom Tromey  <tom@tromey.com>
 346
 347         * ui-out.h (enum class ui_out_style_kind): Remove.
 348         (class ui_out) <field_string, field_stsream, do_field_string>:
 349         Change type of "style".
 350         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 351         (ui_out::field_string): Update.
 352         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 353         of "style".
 354         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 355         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 356         * stack.c (print_frame_arg, print_frame_info, print_frame):
 357         Update.
 358         * source.c (print_source_lines_base): Update.
 359         * solib.c (info_sharedlibrary_command): Update.
 360         * skip.c (info_skip_command): Update.
 361         * record-btrace.c (btrace_call_history_src_line)
 362         (btrace_call_history): Update.
 363         * python/py-framefilter.c (py_print_frame): Update.
 364         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 365         "style".
 366         * mi/mi-out.c (mi_ui_out::do_table_header)
 367         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 368         (mi_ui_out::do_field_string): Update.
 369         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 370         Update.
 371         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 372         "style".
 373         * cli-out.c (cli_ui_out::do_table_header)
 374         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 375         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 376         (cli_ui_out::do_field_fmt): Update.
 377         * breakpoint.c (print_breakpoint_location): Update.
 378         (update_static_tracepoint): Update.
 379
 380 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 381
 382         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 383         conversion of gdb_datadir.
 384         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 385         remove not needed c_str ().
 386
 387 2019-09-30  Ali Tamur <tamur@google.com>
 388
 389         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 390         (dwarf2_string_attr): Likewise.
 391
 392 2019-09-30  Ali Tamur <tamur@google.com>
 393
 394         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 395         (process_full_type_unit): Likewise.
 396         (dump_die_shallow): Likewise.
 397         (cu_debug_loc_section): Likewise.
 398
 399 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 400
 401         * minsyms.c (compare_minimal_symbols): Rename to...
 402         (minimal_symbol_is_less_than): ...this, and adjust to STL
 403         conventions (return bool, take arguments as references)
 404         (minimal_symbol_reader::install): Call std::sort instead
 405         of qsort.
 406
 407 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 408
 409         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 410         hash and why.
 411         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 412         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 413
 414 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 415
 416         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 417         * psympriv.h (add_psymbol_to_list): Move comment here and update
 418         it.
 419
 420 2019-09-29  Tom de Vries  <tdevries@suse.de>
 421
 422         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 423         Use $tmpdir/$(basename "$output_file").dwz instead of
 424         "${output_file}.dwz".
 425
 426 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 427
 428         PR gdb/25045
 429         * hppa-linux-nat.c: Include gdbarch.h.
 430
 431 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 432
 433         * blockframe.c (find_pc_partial_function): Change return type to bool.
 434         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 435         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 436         (stub_gnu_ifunc_resolve_name): Likewise.
 437         * symtab.c (compare_filenames_for_search): Likewise.
 438         (compare_glob_filenames_for_search): Likewise.
 439         (matching_obj_sections): Likewise.
 440         (symbol_matches_domain): Likewise.
 441         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 442         (find_line_pc): Change return type to bool.
 443         (find_line_pc_range): Likewise.
 444         (producer_is_realview): Likewise.
 445         * symtab.h (symbol_matches_domain): Likewise.
 446         (find_pc_partial_function): Likewise.
 447         (find_pc_line_pc_range): Likewise.
 448         (in_gnu_ifunc_stub): Likewise.
 449         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 450         (find_line_pc): Likewise.
 451         (find_line_pc_range): Likewise.
 452         (matching_obj_sections): Likewise.
 453         (find_line_symtab): Change out parameter to bool.
 454         (producer_is_realview): Change return type to bool.
 455         (compare_filenames_for_search): Likewise.
 456         (compare_glob_filenames_for_search): Likewise.
 457
 458 2019-09-26  Tom Tromey  <tom@tromey.com>
 459
 460         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 461         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 462         * gdb_usleep.h: Remove.
 463         * gdb_usleep.c: Remove.
 464         * utils.c: Don't include gdb_usleep.h.
 465
 466 2019-09-26  Tom Tromey  <tromey@adacore.com>
 467
 468         * python/py-type.c (type_to_type_object): Call check_typedef
 469         for stub types.
 470
 471 2019-09-26  Tom Tromey  <tom@tromey.com>
 472
 473         * utils.h (initialize_utils): Don't declare.
 474         * top.c (gdb_init): Don't call initialize_utils.
 475         * utils.c (initialize_utils): Remove.  Move contents...
 476         (_initialize_utils): ... here.
 477
 478 2019-09-25  Tom Tromey  <tom@tromey.com>
 479
 480         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 481         * utils.h (make_hex_string): Don't declare.
 482         * utils.c (make_hex_string): Remove.
 483
 484 2019-09-24  Tom de Vries  <tdevries@suse.de>
 485
 486         PR gdb/23815
 487         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 488         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 489
 490 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 491
 492         * NEWS: Mention new simulator port for PRU.
 493
 494 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 495
 496         * ada-exp.y (write_object_remaining): Update.
 497         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 498         and eliminate the static buffer.
 499         (ada_decode_symbol): Update.
 500         (ada_la_decode): Update.
 501         (ada_sniff_from_mangled_name): Update.
 502         (is_valid_name_for_wild_match): Update.
 503         (ada_lookup_name_info::matches): Update and simplify.
 504         (name_matches_regex): Update.
 505         (ada_add_global_exceptions): Update.
 506         * ada-lang.h (ada_decode): Update signature.
 507         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 508         * dwarf-index-write.c (debug_names::insert): Update.
 509
 510 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 511
 512         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 513         formatting.
 514
 515 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 516
 517         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 518         Change "nonzero" to "true" in documentation.
 519
 520 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 521
 522         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 523         (_initialize_darwin_solib): Don't set
 524         darwin_so_ops.lookup_lib_global_symbol.
 525         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 526         set_gdbarch_iterate_over_objfiles_in_search_order.
 527         (elf_lookup_lib_symbol): Rename to...
 528         (svr4_iterate_over_objfiles_in_search_order): this, and update
 529         to iterate semantics.
 530         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 531         * solib.c (solib_global_lookup): Remove.
 532         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 533         (solib_global_lookup): Remove.
 534         * symtab.c (lookup_global_or_static_symbol): Remove call to
 535         solib_global_lookup.
 536
 537 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 538
 539         * NEWS: Move entries about default MI version now being
 540         version 3, and about the GDB/MI fix for multi-location
 541         breakpoints to the "since GDB 8.3" section.
 542
 543 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 544
 545         GDB 8.3.1 released.
 546
 547 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 548
 549         * NEWS: Mention that Cell/B.E. debugging support was removed.
 550         * MAINTAINERS: Remove spu target.
 551
 552         * config/djgpp/fnchange.lst: Remove entries for removed files.
 553
 554         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 555         spu-multiarch.o, and spu-tdep.o.
 556         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 557         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 558         spu-multiarch.c, and spu-tdep.c.
 559         * spu-linux-nat.c: Remove file.
 560         * spu-multiarch.c: Remove file.
 561         * spu-tdep.c: Remove file.
 562         * spu-tdep.h: Remove file.
 563         * solib-spu.c: Remove file.
 564         * solib-spu.h: Remove file.
 565
 566         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 567         * configure.nat (spu-linux): Remove.
 568         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 569         solib-multiarch.o from gdb_target_obs.
 570         (spu*-*-*): Remove.
 571
 572         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 573         feature flag.
 574         (ppc_linux_no_features): Update.
 575         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 576         Cell/B.E. support.
 577         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 578         (tdesc_powerpc_cell64l): Likewise.
 579         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 580         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 581         Cell/B.E. support.
 582         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 583         Do not include "features/rs6000/powerpc-cell32l.c" or
 584         "features/rs6000/powerpc-cell64l.c".
 585         (ppc_linux_spu_section): Remove.
 586         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 587         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 588         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 589         (ppc_linux_spe_context_lookup): Remove.
 590         (ppc_linux_spe_context_inferior_created): Remove.
 591         (ppc_linux_spe_context_solib_loaded): Remove.
 592         (ppc_linux_spe_context_solib_unloaded): Remove.
 593         (ppc_linux_spe_context): Remove.
 594         (struct ppu2spu_cache): Remove.
 595         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 596         (struct ppu2spu_data): Remove.
 597         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 598         ppu2spu_unwind): Remove.
 599         (ppc_linux_init_abi): Remove Cell/B.E. support.
 600         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 601
 602         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 603         (rs6000/powerpc-cell64l-expedite): Likewise
 604         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 605         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 606         rs6000/powerpc-cell64l.xml.
 607         * features/rs6000/powerpc-cell32l.xml: Remove.
 608         * features/rs6000/powerpc-cell64l.xml: Likewise.
 609         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 610         * features/rs6000/powerpc-cell64l.c: Likewise.
 611         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 612         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 613         * regformats/reg-spu.dat: Remove.
 614
 615         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 616         * corelow.c (struct spuid_list): Remove.
 617         (add_to_spuid_list): Remove.
 618         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 619         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 620         (remote_protocol_features): Remove associated entries.
 621         (_initialize_remote): No longer initialize them.
 622         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 623         * linux-nat.c (SPUFS_MAGIC): Remove.
 624         (linux_proc_xfer_spu): Remove.
 625         (spu_enumerate_spu_ids): Remove.
 626         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 627         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 628         (linux_make_corefile_notes): No longer call it.
 629
 630         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 631         (cooked_write_test): Likewise.
 632
 633 2019-09-20  Tom Tromey  <tom@tromey.com>
 634
 635         * NEWS: Mention case-sensitivity of TUI commands.
 636         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 637         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 638         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 639
 640 2019-09-20  Tom Tromey  <tom@tromey.com>
 641
 642         * tui/tui-source.c (tui_source_window::set_contents): Use
 643         make_unique_xstrdup.
 644         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 645         make_unique_xstrdup.
 646
 647 2019-09-20  Tom Tromey  <tom@tromey.com>
 648
 649         * tui/tui-data.c: Remove separator comments.
 650         * tui/tui-layout.c: Remove separator comments.
 651         * tui/tui-win.c: Remove separator comments.
 652         * tui/tui-wingeneral.c: Remove separator comments.
 653
 654 2019-09-20  Tom Tromey  <tom@tromey.com>
 655
 656         * tui/tui.h (strcat_to_buf): Don't declare.
 657         * tui/tui.c (strcat_to_buf): Remove.
 658
 659 2019-09-20  Tom Tromey  <tom@tromey.com>
 660
 661         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 662         from "fullname".
 663         * tui/tui-source.c (tui_source_window::set_contents)
 664         (tui_source_window::location_matches_p)
 665         (tui_source_window::maybe_update): Update.
 666
 667 2019-09-20  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 670         Update.
 671         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 672         prefix.
 673         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 674         (tui_data_window::line_from_reg_element_no)
 675         (tui_data_window::first_reg_element_no_inline)
 676         (tui_data_window::show_registers)
 677         (tui_data_window::show_register_group)
 678         (tui_data_window::display_registers_from)
 679         (tui_data_window::display_registers_from_line)
 680         (tui_data_window::first_data_item_displayed)
 681         (tui_data_window::delete_data_content_windows)
 682         (tui_data_window::erase_data_content)
 683         (tui_data_window::do_scroll_vertical)
 684         (tui_data_window::refresh_window)
 685         (tui_data_window::check_register_values): Update.
 686
 687 2019-09-20  Tom Tromey  <tom@tromey.com>
 688
 689         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 690         (struct tui_locator_window) <full_name, proc_name>: Now
 691         std::string.
 692         * tui/tui-stack.c (tui_locator_window::make_status_line)
 693         (tui_locator_window::set_locator_fullname)
 694         (tui_locator_window::set_locator_info): Update.
 695         * tui/tui-source.c (tui_source_window::set_contents)
 696         (tui_source_window::showing_source_p): Update.
 697
 698 2019-09-20  Tom Tromey  <tom@tromey.com>
 699
 700         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 701         Don't call tui_locator_win_info_ptr.
 702
 703 2019-09-20  Tom Tromey  <tom@tromey.com>
 704
 705         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 706
 707 2019-09-20  Tom Tromey  <tom@tromey.com>
 708
 709         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 710         height for locator.
 711         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 712         * tui/tui-layout.c (show_source_disasm_command, show_data)
 713         (show_source_or_disasm_and_command): Use 1 as height for locator.
 714
 715 2019-09-20  Tom Tromey  <tom@tromey.com>
 716
 717         * tui/tui.c (tui_enable): Update.
 718         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 719         Update.
 720         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 721         Update.
 722         * tui/tui-data.c (win_resized): Now bool.
 723         (tui_win_resized): Return bool.
 724         (tui_set_win_resized_to): Accept a bool.
 725
 726 2019-09-20  Tom Tromey  <tom@tromey.com>
 727
 728         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 729         Change type of "refresh_values_only".
 730         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 731         type of "refresh_values_only".
 732
 733 2019-09-20  Tom Tromey  <tom@tromey.com>
 734
 735         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 736         std::string.
 737         (tui_disassemble): Add "pos" parameter.
 738         (tui_disasm_window::set_contents): Simplify.
 739
 740 2019-09-20  Tom Tromey  <tom@tromey.com>
 741
 742         * tui/tui-winsource.h (struct tui_source_window_base)
 743         <show_source_content>: Now private.
 744         * tui/tui-winsource.c
 745         (tui_source_window_base::show_source_content): Don't handle empty
 746         content case.
 747
 748 2019-09-20  Tom Tromey  <tom@tromey.com>
 749
 750         * tui/tui-layout.c (show_source_disasm_command)
 751         (show_source_or_disasm_and_command): Don't call
 752         show_source_content.
 753
 754 2019-09-20  Tom Tromey  <tom@tromey.com>
 755
 756         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 757         Declare.
 758         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 759         from tui_make_status_line.
 760         (tui_locator_window::rerender): Update.
 761
 762 2019-09-20  Tom Tromey  <tom@tromey.com>
 763
 764         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 765         (tui_locator_window::rerender): Update.
 766
 767 2019-09-20  Tom Tromey  <tom@tromey.com>
 768
 769         * tui/tui-winsource.h (struct tui_source_window_base)
 770         <~tui_source_window_base>: Don't declare.
 771         <fullname>: Remove.
 772         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 773         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 774         member.
 775         * tui/tui-source.c (tui_source_window::set_contents): Update.
 776         (tui_source_window::location_matches_p)
 777         (tui_source_window::maybe_update): Update.
 778
 779 2019-09-20  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-winsource.h (~tui_source_element): Remove.
 782         (tui_source_element): Update.
 783         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 784         * tui/tui-winsource.c (tui_show_source_line): Update.
 785         * tui/tui-source.c (tui_source_window::set_contents): Update.
 786         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 787
 788 2019-09-20  Tom Tromey  <tom@tromey.com>
 789
 790         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 791         declare.
 792         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 793         tui_clear_source_windows_detail.
 794         * tui/tui-winsource.h (struct tui_source_window_base)
 795         <clear_detail>: Don't declare.
 796         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 797         Remove.
 798         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 799
 800 2019-09-20  Tom Tromey  <tromey@adacore.com>
 801
 802         PR ada/24919:
 803         * block.c (contained_in): Fix final return value.
 804
 805 2019-09-20  Alan Modra  <amodra@gmail.com>
 806
 807         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 808         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 809         (read_indirect_string_from_dwz): Use bfd accessor.
 810         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 811         * machoread.c (macho_symfile_read_all_oso): Likewise.
 812         * solib.c (solib_bfd_open): Likewise.
 813
 814 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 815
 816         * eval.c: Move declaration of overload_resolution to...
 817         * value.h: ...here.
 818
 819 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 820
 821         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 822         * arm-linux-tdep.c: Likewise.
 823         * arm-nbsd-nat.c: Likewise.
 824         * arm-tdep.h: Declare arm_apcs_32.
 825         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 826
 827 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 828
 829         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 830         * dwarf2read.h: Declare dwarf_always_disassemble.
 831
 832 2019-09-19  Tom de Vries  <tdevries@suse.de>
 833
 834         PR gdb/25009
 835         * source-cache.c (source_cache::ensure): Catch exception thrown during
 836         construction of the highlighter.
 837
 838 2019-09-18  Alan Modra  <amodra@gmail.com>
 839
 840         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 841         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 842         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 843         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 844         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 845         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 846         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 847         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 848         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 849         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 850         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 851         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 852         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 853         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 854         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 855         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 856         * mi/mi-interp.c: Update throughout for bfd section macro and
 857         function changes.
 858         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 859         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 860
 861 2019-09-18  Tom Tromey  <tom@tromey.com>
 862
 863         * NEWS: Add entry.
 864         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 865         call rl_initialize.
 866         (tui_enable): Do not call rl_initialize.
 867
 868 2019-09-18  Christian Groessler  <chris@groessler.org>
 869
 870         * alpha-linux-nat.c: Include gdbarch.h.
 871
 872 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 873
 874         * ui-file.c: Include cli/cli-style.h.
 875         (term_cli_styling): Remove cli_styling declaration.
 876
 877 2019-09-18  Alan Modra  <amodra@gmail.com>
 878
 879         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 880         to bfd_asymbol_section.
 881
 882 2019-09-18  Alan Modra  <amodra@gmail.com>
 883
 884         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 885         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 886         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 887
 888 2019-09-18  Alan Modra  <amodra@gmail.com>
 889
 890         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 891         * spu-linux-nat.c (spu_bfd_open): Likewise.
 892
 893 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 894
 895         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 896         to bool to match definition in dwarf2read.c.
 897
 898 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 899
 900         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 901         (print_signatures): Likewise.
 902         (trust_pad_over_xvs): Likewise.
 903         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 904         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 905         * arm-linux-nat.c (arm_apcs_32): Likewise.
 906         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 907         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 908         * arm-tdep.c (arm_debug): Likewise.
 909         (arm_apcs_32): Likewise.
 910         * auto-load.c (debug_auto_load): Likewise.
 911         (auto_load_gdb_scripts): Likewise.
 912         (global_auto_load): Likewise.
 913         (auto_load_local_gdbinit): Likewise.
 914         (auto_load_local_gdbinit_loaded): Likewise.
 915         * auto-load.h (global_auto_load): Likewise.
 916         (auto_load_local_gdbinit): Likewise.
 917         (auto_load_local_gdbinit_loaded): Likewise.
 918         * breakpoint.c (disconnected_dprintf): Likewise.
 919         (breakpoint_proceeded): Likewise.
 920         (automatic_hardware_breakpoints): Likewise.
 921         (always_inserted_mode): Likewise.
 922         (target_exact_watchpoints): Likewise.
 923         (_initialize_breakpoint): Update.
 924         * breakpoint.h (target_exact_watchpoints): Change to bool.
 925         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 926         * cli/cli-cmds.c (trace_commands): Likewise.
 927         * cli/cli-cmds.h (trace_commands): Likewise.
 928         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 929         to bool*.
 930         * cli/cli-logging.c (logging_overwrite): Change to bool.
 931         (logging_redirect): Likewise.
 932         (debug_redirect): Likewise.
 933         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 934         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 935         to bool.
 936         <boolean_option_def>: Update.
 937         (struct flag_option_def): Change default type of Context to bool
 938         from int.
 939         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 940         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 941         (get_setshow_command_value_string): Likewise.
 942         * cli/cli-style.c (cli_styling): Change to bool.
 943         (source_styling): Likewise.
 944         * cli/cli-style.h (source_styling): Likewise.
 945         (cli_styling): Likewise.
 946         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 947         to bool.
 948         * command.h (var_types): Update comment.
 949         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 950         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 951         bool.
 952         (debug_compile_cplus_scopes): Likewise.
 953         * compile/compile-internal.h (compile_debug): Likewise.
 954         * compile/compile.c (compile_debug): Likewise.
 955         (struct compile_options) <raw>: Likewise.
 956         * cp-support.c (catch_demangler_crashes): Likewise.
 957         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 958         (usr_cmd_cris_dwarf2_cfi): Likewise.
 959         * csky-tdep.c (csky_debug): Likewise.
 960         * darwin-nat.c (enable_mach_exceptions): Likewise.
 961         * dcache.c (dcache_enabled_p): Likewise.
 962         * defs.h (info_verbose): Likewise.
 963         * demangle.c (demangle): Likewise.
 964         (asm_demangle): Likewise.
 965         * dwarf-index-cache.c (debug_index_cache): Likewise.
 966         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 967         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 968         * dwarf2read.c (check_physname): Likewise.
 969         (use_deprecated_index_sections): Likewise.
 970         (dwarf_always_disassemble): Likewise.
 971         * eval.c (overload_resolution): Likewise.
 972         * event-top.c (set_editing_cmd_var): Likewise.
 973         (exec_done_display_p): Likewise.
 974         * event-top.h (set_editing_cmd_var): Likewise.
 975         (exec_done_display_p): Likewise.
 976         * exec.c (write_files): Likewise.
 977         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 978         (debug_fbsd_nat): Likewise.
 979         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 980         Likewise.
 981         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 982         <backtrace_past_entry> Likewise.
 983         * gdb-demangle.h (demangle): Likewise.
 984         (asm_demangle): Likewise.
 985         * gdb_bfd.c (bfd_sharing): Likewise.
 986         * gdbcore.h (write_files): Likewise.
 987         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 988         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 989         * gdbthread.h (print_thread_events): Likewise.
 990         * gdbtypes.c (opaque_type_resolution): Likewise.
 991         (strict_type_checking): Likewise.
 992         * gnu-nat.c (gnu_debug_flag): Likewise.
 993         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 994         * guile/scm-param.c (pascm_variable): Add boolval.
 995         (add_setshow_generic): Update.
 996         (pascm_param_value): Update.
 997         (pascm_set_param_value_x): Update.
 998         * hppa-tdep.c (hppa_debug): Change to bool..
 999         * infcall.c (may_call_functions_p): Likewise.
1000         (coerce_float_to_double_p): Likewise.
1001         (unwind_on_signal_p): Likewise.
1002         (unwind_on_terminating_exception_p): Likewise.
1003         * infcmd.c (startup_with_shell): Likewise.
1004         * inferior.c (print_inferior_events): Likewise.
1005         * inferior.h (startup_with_shell): Likewise.
1006         (print_inferior_events): Likewise.
1007         * infrun.c (step_stop_if_no_debug): Likewise.
1008         (detach_fork): Likewise.
1009         (debug_displaced): Likewise.
1010         (disable_randomization): Likewise.
1011         (non_stop): Likewise.
1012         (non_stop_1): Likewise.
1013         (observer_mode): Likewise.
1014         (observer_mode_1): Likewise.
1015         (set_observer_mode): Update.
1016         (sched_multi): Change to bool.
1017         * infrun.h (debug_displaced): Likewise.
1018         (sched_multi): Likewise.
1019         (step_stop_if_no_debug): Likewise.
1020         (non_stop): Likewise.
1021         (disable_randomization): Likewise.
1022         * linux-tdep.c (use_coredump_filter): Likewise.
1023         (dump_excluded_mappings): Likewise.
1024         * linux-thread-db.c (auto_load_thread_db): Likewise.
1025         (check_thread_db_on_load): Likewise.
1026         * main.c (captured_main_1): Update.
1027         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1028         xx2_opt, boolean_opt>: Change to bool.
1029         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1030         * maint.c (maintenance_profile_p): Likewise.
1031         (per_command_time): Likewise.
1032         (per_command_space): Likewise.
1033         (per_command_symtab): Likewise.
1034         * memattr.c (inaccessible_by_default): Likewise.
1035         * mi/mi-main.c (mi_async): Likewise.
1036         (mi_async_1): Likewise.
1037         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1038         * nat/fork-inferior.h (startup_with_shell): Likewise.
1039         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1040         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1041         * nios2-tdep.c (nios2_debug): Likewise.
1042         * or1k-tdep.c (or1k_debug): Likewise.
1043         * parse.c (parser_debug): Likewise.
1044         * parser-defs.h (parser_debug): Likewise.
1045         * printcmd.c (print_symbol_filename): Likewise.
1046         * proc-api.c (procfs_trace): Likewise.
1047         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1048         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1049         (set_parameter_value): Update.
1050         (add_setshow_generic): Update.
1051         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1052         to bool*.
1053         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1054         int*.
1055         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1056         * record-btrace.c (record_btrace_target::store_registers): Update.
1057         * record-full.c (record_full_memory_query): Change to bool.
1058         (record_full_stop_at_limit): Likewise.
1059         * record-full.h (record_full_memory_query): Likewise.
1060         * remote-notif.c (notif_debug): Likewise.
1061         * remote-notif.h (notif_debug): Likewise.
1062         * remote.c (use_range_stepping): Likewise.
1063         (interrupt_on_connect): Likewise.
1064         (remote_break): Likewise.
1065         * ser-tcp.c (tcp_auto_retry): Likewise.
1066         * ser-unix.c (serial_hwflow): Likewise.
1067         * skip.c (debug_skip): Likewise.
1068         * solib-aix.c (solib_aix_debug): Likewise.
1069         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1070         (spu_auto_flush_cache_p): Likewise.
1071         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1072         Likewise.
1073         (struct info_print_options) <quiet>: Likewise.
1074         * symfile-debug.c (debug_symfile): Likewise.
1075         * symfile.c (auto_solib_add): Likewise.
1076         (separate_debug_file_debug): Likewise.
1077         * symfile.h (auto_solib_add): Likewise.
1078         (separate_debug_file_debug): Likewise.
1079         * symtab.c (basenames_may_differ): Likewise.
1080         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1081         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1082         (struct info_types_options) <quiet>: Likewise.
1083         * symtab.h (demangle): Likewise.
1084         (basenames_may_differ): Likewise.
1085         * target-dcache.c (stack_cache_enabled_1): Likewise.
1086         (code_cache_enabled_1): Likewise.
1087         * target.c (trust_readonly): Likewise.
1088         (may_write_registers): Likewise.
1089         (may_write_memory): Likewise.
1090         (may_insert_breakpoints): Likewise.
1091         (may_insert_tracepoints): Likewise.
1092         (may_insert_fast_tracepoints): Likewise.
1093         (may_stop): Likewise.
1094         (auto_connect_native_target): Likewise.
1095         (target_stop_and_wait): Update.
1096         (target_async_permitted): Change to bool.
1097         (target_async_permitted_1): Likewise.
1098         (may_write_registers_1): Likewise.
1099         (may_write_memory_1): Likewise.
1100         (may_insert_breakpoints_1): Likewise.
1101         (may_insert_tracepoints_1): Likewise.
1102         (may_insert_fast_tracepoints_1): Likewise.
1103         (may_stop_1): Likewise.
1104         * target.h (target_async_permitted): Likewise.
1105         (may_write_registers): Likewise.
1106         (may_write_memory): Likewise.
1107         (may_insert_breakpoints): Likewise.
1108         (may_insert_tracepoints): Likewise.
1109         (may_insert_fast_tracepoints): Likewise.
1110         (may_stop): Likewise.
1111         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1112         (make_thread_apply_all_options_def_group): Change argument from int*
1113         to bool*.
1114         (thread_apply_all_command): Update.
1115         (print_thread_events): Change to bool.
1116         * top.c (confirm): Likewise.
1117         (command_editing_p): Likewise.
1118         (history_expansion_p): Likewise.
1119         (write_history_p): Likewise.
1120         (info_verbose): Likewise.
1121         * top.h (confirm): Likewise.
1122         (history_expansion_p): Likewise.
1123         * tracepoint.c (disconnected_tracing): Likewise.
1124         (circular_trace_buffer): Likewise.
1125         * typeprint.c (print_methods): Likewise.
1126         (print_typedefs): Likewise.
1127         * utils.c (debug_timestamp): Likewise.
1128         (sevenbit_strings): Likewise.
1129         (pagination_enabled): Likewise.
1130         * utils.h (sevenbit_strings): Likewise.
1131         (pagination_enabled): Likewise.
1132         * valops.c (overload_resolution): Likewise.
1133         * valprint.h (struct value_print_options) <prettyformat_arrays,
1134         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1135         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1136         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1137         Likewise.
1138         * windows-nat.c (new_console): Likewise.
1139         (cygwin_exceptions): Likewise.
1140         (new_group): Likewise.
1141         (debug_exec): Likewise.
1142         (debug_events): Likewise.
1143         (debug_memory): Likewise.
1144         (debug_exceptions): Likewise.
1145         (useshell): Likewise.
1146         * windows-tdep.c (maint_display_all_tib): Likewise.
1147         * xml-support.c (debug_xml): Likewise.
1148
1149 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1150
1151         * source.c (prepare_path_for_appending): New function.
1152         (openp): Make use of new function.
1153         (find_and_open_source): Search for the compilation directory and
1154         source file as a relative path beneath the directory search path.
1155
1156 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1157
1158         * source-cache.c (source_cache::get_line_charpos): Catch
1159         exceptions and return false, this matches the behaviour documented
1160         in the header file.
1161
1162 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1163
1164         * ada-tasks.c (info_task): Remove quoting of the task's name.
1165
1166 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1167
1168         * symfile.c (auto_solib_add): Replace comment with a reference
1169         to the header file.
1170
1171 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1172
1173         * NEWS: Mention that gdb can now be compiled with Python 3
1174         on Windows.
1175
1176 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1177
1178         * maint.c (maint_print_section_data::maint_print_section_data):
1179         Force use of 'float log10 (float)' by casting the argument to
1180         float.
1181
1182 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1183
1184         * maint.c: Add 'cmath' include.
1185         (struct maint_print_section_data): New structure.
1186         (print_section_index): New function.
1187         (print_bfd_section_info): Add header comment, small whitespace
1188         cleanup, and update to call new print_section_index function.
1189         (print_objfile_section_info): Likewise.
1190         (maint_obj_section_from_bfd_section): New function.
1191         (print_bfd_section_info_maybe_relocated): New function.
1192         (maintenance_info_sections): Add header comment, always use
1193         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1194
1195 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1196
1197         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1198         inner scope, add check that the objfile has psymtabs before
1199         checking psymtabs_addrmap.
1200         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1201
1202 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1203
1204         * NEWS: Announce that Ada task names are now shown at more places,
1205         and between quotes (except in info task output).
1206         * gdb/ada-tasks.c (task_to_str): New function.
1207         (display_current_task_id): Call task_to_str.
1208         (task_command_1): Likewise.
1209         (print_ada_task_info): In non-mi mode, Properly align headers and data
1210         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1211
1212 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1213
1214         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1215         prstatus.pr_lwp.pr_info instead of making it up.
1216
1217 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1218
1219         * auto-load.c (auto_load_expand_dir_vars): Update.
1220         * defs.h (gdb_datadir): Change to std::string.
1221         (python_libdir): Likewise.
1222         (relocate_gdb_directory): Change return type to std::string.
1223         * guile/guile.c (gdbscm_data_directory): Update.
1224         (initialize_scheme_side): Update.
1225         * jit.c (jit_reader_dir): Change to std::string.
1226         (jit_reader_load_command): Update.
1227         * main.c (gdb_datadir): Change to std::string.
1228         (python_libdir): Likewise.
1229         (set_gdb_data_directory): Update.
1230         (relocate_path): Change to return std::string.
1231         (relocate_gdb_directory): Change to return std::string.
1232         (relocate_gdbinit_path_maybe_in_datadir): Update.
1233         (captured_main_1): Update.
1234         * python/python.c (do_start_initialization): Update.
1235         * top.c (show_gdb_datadir): Update.
1236         * xml-syscall.c (xml_init_syscalls_info): Update.
1237         (init_syscalls_info): Update.
1238
1239 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1240
1241         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1242         out of get_init_files.
1243         (get_init_files): Update.
1244
1245 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1246
1247         * main.c (get_init_files): Change to use std::string.
1248         (captured_main_1): Update.
1249         (print_gdb_help): Update.
1250
1251 2019-09-11  Ali Tamur  <tamur@google.com>
1252
1253         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1254         implementation.
1255
1256 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1257
1258         * dbxread.c (read_dbx_symtab): Update.
1259         * dwarf2read.c (load_partial_dies): Update.
1260         * mdebugread.c (parse_partial_symbols): Update.
1261         (handle_psymbol_enumerators): Update.
1262         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1263         * psymtab.c (add_psymbol_to_bcache): Likewise.
1264         (add_psymbol_to_list): Likewise.
1265         * symtab.c (symbol_set_names): Likewise.
1266         * symtab.h (symbol_set_names): Likewise.
1267         * xcoffread.c (scan_xcoff_symtab): Update.
1268
1269 2019-09-11  Tom Tromey  <tom@tromey.com>
1270
1271         * symfile-mem.c (symbol_file_add_from_memory): Use
1272         bfd_set_filename.
1273         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1274         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1275
1276 2019-09-10  Tom Tromey  <tromey@adacore.com>
1277
1278         * dwarf-index-write.c (write_psymbols): Extend error message.
1279         (debug_names::insert): Add Ada code.
1280         (debug_names::write_psymbols): Remove Ada check.
1281         (debug_names) <m_string_obstack>: New member.
1282         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1283         (gdb_index_symbol_name_matcher::matches): Remove.
1284         (mapped_index_base::find_name_components_bounds): Add "lang"
1285         parameter.
1286         (mapped_index_base::build_name_components): Also split names
1287         according to Ada syntax.
1288         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1289         type of "match_callback".
1290         (check_match, check_find_bounds_finds)
1291         (dw2_expand_symtabs_matching): Update.
1292         (dw2_debug_names_iterator): Add new constructor.
1293         (dw2_debug_names_map_matching_symbols): New function.
1294         (dw2_debug_names_expand_symtabs_matching): Update.
1295         (dwarf2_debug_names_functions): Use
1296         dw2_debug_names_map_matching_symbols.
1297
1298 2019-09-10  Tom Tromey  <tromey@adacore.com>
1299
1300         * dwarf2read.c (dw2_get_file_names_reader): Add the
1301         CU's file name to the results.
1302
1303 2019-09-10  Tom Tromey  <tromey@adacore.com>
1304
1305         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1306         map_matching_symbols.  Update.
1307         * dwarf2read.c (dw2_map_matching_symbols): Update.
1308         * psymtab.c (match_partial_symbol): Change type; update.
1309         (psym_map_matching_symbols): Likewise.
1310         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1311         type; update.
1312         * symfile.h (struct quick_symbol_functions)
1313         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1314         Remove "match".
1315
1316 2019-09-10  Tom Tromey  <tromey@adacore.com>
1317
1318         * psymtab.c (map_block): Remove.
1319         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1320         * symtab.c (iterate_over_symbols_terminated): New function.
1321         * symtab.c (iterate_over_symbols_terminated): Declare.
1322
1323 2019-09-10  Tom Tromey  <tromey@adacore.com>
1324
1325         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1326         * language.h (struct language_defn) <la_iterate_over_symbols>:
1327         Return bool.
1328         * symtab.c (iterate_over_symbols): Return bool.
1329         * symtab.h (iterate_over_symbols): Return bool.
1330
1331 2019-09-10  Tom Tromey  <tromey@adacore.com>
1332
1333         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1334         (add_nonlocal_symbols): Update.
1335         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1336         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1337         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1338         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1339         Change type of "callback".  Remove "data".
1340
1341
1342 2019-09-09  Ali Tamur  <tamur@google.com>
1343
1344         * dwarf2read.c (comp_unit_head): Update comment.
1345         (dwarf2_dwo_name): New function declaration.
1346         (dwarf_unit_type_name): New function declaration.
1347         (read_comp_unit_head): Add support for new compilation units,
1348         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1349         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1350         (currently named as "signature") in their header. Also clarify error
1351         messages.
1352         (lookup_dwo_id): New function. Returns the dwo id of the given
1353         compile unit.
1354         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1355         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1356         functions.
1357         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1358         (dwarf2_dwo_name): Get the dwo name if present.
1359         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1360         purposes.
1361
1362 2019-09-09  Tom Tromey  <tom@tromey.com>
1363
1364         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1365
1366 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1367
1368         * python/python.c (do_start_initialization): Make progname_copy static,
1369         to avoid a leak report.
1370
1371 2019-09-08  Tom Tromey  <tom@tromey.com>
1372
1373         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1374
1375 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1376
1377         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1378         Change type to gdb::optional<block_enum>.
1379         (dw2_symtab_iter_init): Change block_index parameter type
1380         to gdb::optional<block_enum>.
1381         (dw2_lookup_symbol): Change block_index parameter
1382         type to block_enum.c
1383         (dw2_debug_names_lookup_symbol): Likewise.
1384         * psymtab.c (psym_lookup_symbol): Likewise.
1385         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1386         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1387         Likewise.
1388
1389 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1390
1391         * defs.h (relocate_gdb_directory): Change int to bool in
1392         signature and rename flag to relocatable.
1393         * main.c (relocate_path): Likewise.
1394         (relocate_gdb_directory): Likewise.
1395
1396 2019-09-06  Alan Modra  <amodra@gmail.com>
1397
1398         * coffread.c (coff_symfile_read): Constify filename variable.
1399         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1400         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1401         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1402         * solib.c (reload_shared_libraries_1): Likewise.
1403         * symfile.c (reread_symbols): Likewise.
1404         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1405         * solib-darwin.c (darwin_bfd_open): Likewise.
1406         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1407
1408 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1409
1410         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1411         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1412
1413 2019-09-03  Tom Tromey  <tromey@adacore.com>
1414
1415         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1416         types.
1417         (has_negatives): Unbias a range type bound.
1418         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1419         * gdbtypes.c (operator==): Handle new field.
1420         (create_range_type): Add "bias" parameter.
1421         (create_static_range_type, resolve_dynamic_range): Update.
1422         * gdbtypes.h (struct range_bounds) <bias>: New member.
1423         (create_range_type): Add bias parameter.
1424         * printcmd.c (print_scalar_formatted): Unbias range types.
1425         * value.c (unpack_long): Unbias range types.
1426         (pack_long): Bias range types.
1427
1428 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1429
1430         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1431         probe arguments.
1432
1433 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1434
1435         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1436         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1437         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1438         (compile_probe_arg): Likewise.
1439         * probe.h (get_argument_count): Likewise.
1440         * solib-svr4.c (solib_event_probe_action): Likewise.
1441         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1442
1443 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1444
1445         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1446         code to here...
1447         (svr4_create_solib_event_breakpoints): ...from here.
1448
1449 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1450
1451         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1452         suffix from warning message.
1453
1454 2019-08-30  Tom Tromey  <tom@tromey.com>
1455
1456         * tui/tui-winsource.h (struct tui_source_window_base)
1457         <refresh_all>: Don't declare.
1458         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1459         Remove.
1460         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1461         tui_show_locator_content.
1462         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1463         declare.
1464         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1465         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1466         declare.
1467
1468 2019-08-30  Tom Tromey  <tom@tromey.com>
1469
1470         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1471
1472 2019-08-30  Tom Tromey  <tom@tromey.com>
1473
1474         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1475         Remove unnecessary forward declarations.
1476
1477 2019-08-30  Tom Tromey  <tom@tromey.com>
1478
1479         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1480         rerender.
1481         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1482         tui_show_locator_content.
1483
1484 2019-08-30  Tom Tromey  <tom@tromey.com>
1485
1486         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1487         (tui_locator_window::rerender): Rewrite using body of previous
1488         tui_show_locator_content.
1489
1490 2019-08-30  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1493         set_locator_fullname>: New methods.
1494         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1495         Rename from tui_set_locator_fullname.
1496         (tui_locator_window::set_locator_info): Rename from
1497         tui_set_locator_info.  Return bool.
1498         (tui_update_locator_fullname, tui_show_frame_info): Update.
1499
1500 2019-08-30  Tom Tromey  <tom@tromey.com>
1501
1502         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1503
1504 2019-08-30  Tom Tromey  <tom@tromey.com>
1505
1506         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1507         call touchwin.
1508
1509 2019-08-30  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-wingeneral.c (box_win): Assume win_info and
1512         win_info->handle cannot be NULL.
1513
1514 2019-08-30  Tom Tromey  <tom@tromey.com>
1515
1516         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1517         refresh_window>: Declare.
1518         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1519         resize.
1520         (tui_data_item_window::rerender): Rename from
1521         tui_display_register.
1522         (tui_data_item_window::refresh_window): New method.
1523         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1524         no-op.
1525
1526 2019-08-30  Tom Tromey  <tom@tromey.com>
1527
1528         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1529         regs_column_count, current_group>: Move later.  Now private.
1530         <get_current_group>: New method.
1531         * tui/tui-regs.c (tui_reg_command): Update.
1532         * tui/tui-layout.c (tui_set_layout): Update.
1533
1534 2019-08-30  Tom Tromey  <tom@tromey.com>
1535
1536         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1537         (tui_data_window::rerender): Don't call
1538         check_and_display_highlight_if_needed.
1539         (tui_data_window::refresh_all): Remove call to
1540         erase_data_content.
1541
1542 2019-08-30  Tom Tromey  <tom@tromey.com>
1543
1544         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1545         (tui_data_window::display_registers_from)
1546         (tui_data_window::display_reg_element_at_line)
1547         (tui_data_window::display_registers_from_line): Remove checks of
1548         "empty".
1549
1550 2019-08-30  Tom Tromey  <tom@tromey.com>
1551
1552         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1553         Don't declare.
1554         * tui/tui-regs.c (tui_data_window::show_registers): Call
1555         rerender.
1556         (tui_data_window::rerender): Rename from display_all_data.
1557         (tui_data_window::rerender): Remove old implementation.
1558
1559 2019-08-30  Tom Tromey  <tom@tromey.com>
1560
1561         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1562         text.
1563         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1564
1565 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1566             Sergio Durigan Junior  <sergiodj@redhat.com>
1567
1568         PR win32/24284
1569         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1570
1571 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1572
1573         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1574         when searching for types.
1575
1576 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1577
1578         * f-lang.c (f_language_defn): Use f_print_typedef.
1579         * f-lang.h (f_print_typedef): Declare.
1580         * f-typeprint.c (f_print_typedef): Define.
1581
1582 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1583
1584         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1585
1586 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1587
1588         * cli/cli-utils.c (info_print_options_defs): Delete.
1589         (make_info_print_options_def_group): Delete.
1590         (extract_info_print_options): Delete.
1591         (info_print_command_completer): Delete.
1592         (info_print_args_help): Add extra parameter, and optionally
1593         include text about -n flag.
1594         * cli/cli-utils.h (struct info_print_options): Delete.
1595         (extract_info_print_options): Delete declaration.
1596         (info_print_command_completer): Delete declaration.
1597         (info_print_args_help): Add extra parameter, extend header
1598         comment.
1599         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1600         search_symbols.
1601         * stack.c (struct info_print_options): New type.
1602         (info_print_options_defs): New file scoped variable.
1603         (make_info_print_options_def_group): New static function.
1604         (info_print_command_completer): New static function.
1605         (info_locals_command): Update to use new local functions.
1606         (info_args_command): Likewise.
1607         (_initialize_stack): Add extra parameter to calls to
1608         info_print_args_help.
1609         * symtab.c (search_symbols): Add extra parameter, use this to
1610         possibly excluse non-debug symbols.
1611         (symtab_symbol_info): Add extra parameter, which is passed on to
1612         search_symbols.
1613         (struct info_print_options): New type.
1614         (info_print_options_defs): New file scoped variable.
1615         (make_info_print_options_def_group): New static function.
1616         (info_print_command_completer): New static function.
1617         (info_variables_command): Update to use local functions, and pass
1618         extra parameter through to symtab_symbol_info.
1619         (info_functions_command): Likewise.
1620         (info_types_command): Pass additional argument through to
1621         symtab_symbol_info.
1622         (rbreak_command): Pass extra argument to search_symbols.
1623         (_initialize_symtab): Add extra arguments for calls to
1624         info_print_args_help, and update help text for 'info variables',
1625         'whereis', and 'info functions' commands.
1626         * symtab.h (search_symbols): Add extra argument to declaration.
1627         * NEWS: Mention new flags.
1628
1629 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1630
1631         * symtab.c (lookup_static_symbol): Call the new function (and move
1632         it down to be next to lookup_global_symbol).
1633         (struct global_sym_lookup_data): Add block_enum member and rename to...
1634         (struct global_or_static_sym_lookup_data): ...this.
1635         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1636         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1637         (lookup_symbol_global_or_static_iterator_cb): ...this.
1638         (lookup_global_or_static_symbol): New function.
1639         (lookup_global_symbol): Call new function.
1640
1641 2019-08-26  Tom de Vries  <tdevries@suse.de>
1642
1643         PR c++/24852
1644         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1645         when pc_probe.prob == NULL.
1646
1647 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1648
1649         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1650         variable symbol_linkage to symbol_linkage_.
1651
1652 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1653
1654         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1655         represent whether the symbol is static, dynamic, or we don't
1656         know.
1657
1658 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1659
1660         * gdb/rx-tdep.c (rx_register_names): New.
1661         (rx_register_name): Delete.
1662         (rx_psw_type): Delete.
1663         (rx_fpsw_type): Delete.
1664         (rx_register_type): Delete.
1665         (rx_gdbarch_init): Convert target-descriptions.
1666         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1667         * gdb/features/Makefile: Add rx.xml.
1668         * gdb/features/rx.xml: New.
1669         * gdb/features/rx.c: Generated.
1670         * gdb/NEWS: Mention target description support.
1671
1672 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1673
1674         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1675         *slot_ptr.
1676
1677 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1678
1679         * configure.ac: Don't check for 'dlfcn.h' (moved to
1680         gdbsupport/common.m4).
1681         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1682         'gdbsupport/'.
1683         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1684         * compile/compile-c-support.c: Include
1685         'gdbsupport/gdb-dlfcn.h'.
1686         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1687         * gdb-dlfcn.c: Move to...
1688         * gdbsupport/gdb-dlfcn.c: ... here.
1689         * gdb-dlfcn.h: Move to...
1690         * gdbsupport/gdb-dlfcn.h: ... here.
1691
1692 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1693
1694         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1695         the offset field signed.
1696
1697 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1698
1699         * python/lib/gdb/__init__.py (_execute_file): New function.
1700         * python/python.c (python_run_simple_file): Call gdb._execute_file
1701         on Windows.
1702
1703 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1704
1705         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1706         all uses as this was never set to anything but a zero value.
1707
1708 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1709
1710         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1711
1712 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1713
1714         * tui/tui-data.h (tui_gen_win_info): Add an =default
1715         move constructor, required by some GCC versions.
1716
1717 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1718
1719         * go32-nat.c (go32_sysinfo): Add hygon_p.
1720
1721 2019-08-20  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1724         line_from_reg_element_no, first_reg_element_no_inline,
1725         display_all_data, delete_data_content_windows,
1726         erase_data_content>: Now private.
1727
1728 2019-08-20  Tom Tromey  <tom@tromey.com>
1729
1730         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1731         (tui_unhighlight_win, tui_highlight_win)
1732         (tui_win_info::make_window): Update.
1733         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1734
1735 2019-08-20  Tom Tromey  <tom@tromey.com>
1736
1737         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1738         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1739         (MAX_PID_WIDTH): Move to tui-stack.c.
1740         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1741         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1742         (MAX_PID_WIDTH): Move from tui-data.h.
1743
1744 2019-08-20  Tom Tromey  <tom@tromey.com>
1745
1746         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1747         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1748         (box_win): Update.
1749         (tui_gen_win_info::make_window): Rename from tui_make_window.
1750         (tui_win_info::make_window): New method.
1751         (tui_gen_win_info::make_visible): Update.
1752         * tui/tui-source.c (tui_source_window::set_contents): Update.
1753         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1754         (tui_data_window::display_registers_from): Update.
1755         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1756         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1757         Declare.
1758         <can_box>: Remove.
1759         <title>: Remove.
1760         (struct tui_win_info) <make_window>: Declare.
1761         <can_box>: Now virtual.
1762         <title>: New member.
1763         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1764         * tui/tui-command.c (tui_cmd_window::resize): Update.
1765
1766 2019-08-20  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1769         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1770         (tui_data_window::check_register_values): Update.
1771
1772 2019-08-20  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui-regs.h (struct tui_data_window): Use
1775         DISABLE_COPY_AND_ASSIGN.
1776         <regs_content>: Change type, removing unique_ptr.
1777         <tui_data_window>: Add move constructor.
1778         * tui/tui-regs.c (tui_data_window::show_registers)
1779         (tui_data_window::show_register_group)
1780         (tui_data_window::display_registers_from)
1781         (tui_data_window::display_registers_from)
1782         (tui_data_window::first_data_item_displayed)
1783         (tui_data_window::delete_data_content_windows)
1784         (tui_data_window::rerender, tui_data_window::refresh_window)
1785         (tui_data_window::check_register_values): Update.
1786
1787 2019-08-20  Tom Tromey  <tom@tromey.com>
1788
1789         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1790         show_register_group>: Declare.
1791         (tui_show_register_group): Don't declare.
1792         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1793         tui_show_registers.
1794         (tui_data_window::show_register_group): Rename from
1795         tui_show_register_group.
1796         (tui_data_window::check_register_values, tui_reg_command):
1797         Update.
1798         * tui/tui-layout.c (tui_set_layout): Update.
1799
1800 2019-08-20  Tom Tromey  <tom@tromey.com>
1801
1802         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1803         Declare.
1804         (tui_check_register_values): Don't declare.
1805         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1806         from tui_check_register_values.
1807         * tui/tui-hooks.c (tui_register_changed): Update.
1808
1809 2019-08-20  Tom Tromey  <tom@tromey.com>
1810
1811         * tui/tui-regs.c (tui_reg_layout): Move later.
1812         (tui_show_registers): Don't enable TUI mode or change layout.
1813
1814 2019-08-20  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-regs.h (struct tui_data_item_window)
1817         <~tui_data_item_window>: Remove.
1818         <content>: Now a unique_xmalloc_ptr.
1819         * tui/tui-regs.c (tui_register_format): Return a
1820         unique_xmalloc_ptr.
1821         (tui_get_register): Update.
1822         (~tui_data_item_window): Remove.
1823         (tui_data_window::display_registers_from, tui_display_register):
1824         Update.
1825         * tui/tui-io.h (tui_expand_tabs): Update.
1826         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1827         Remove "col" parameter.
1828
1829 2019-08-20  Tom Tromey  <tom@tromey.com>
1830
1831         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1832         field.
1833         * tui/tui-regs.c (~tui_data_item_window): Update.
1834
1835 2019-08-20  Tom Tromey  <tom@tromey.com>
1836
1837         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1838         earlier.
1839
1840 2019-08-20  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1843
1844 2019-08-20  Tom Tromey  <tom@tromey.com>
1845
1846         * tui/tui-source.h (struct tui_source_window): Update.
1847         * tui/tui-regs.c (tui_show_registers): Update.
1848         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1849         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1850         (NO_REGS_STRING): Remove defines.
1851
1852 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1853
1854         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1855         unnecessary thread walk if remote doesn't support the packet.
1856
1857 2019-08-19  Tom Tromey  <tromey@adacore.com>
1858
1859         * python/py-value.c (value_has_field): Fix indentation.
1860
1861 2019-08-19  Tom Tromey  <tromey@adacore.com>
1862
1863         * printcmd.c (do_one_display, info_display_command): Update.
1864         * block.h (contained_in): Return bool.  Add allow_nested
1865         parameter.
1866         * block.c (contained_in): Return bool.  Add allow_nested
1867         parameter.
1868
1869 2019-08-19  Tom Tromey  <tom@tromey.com>
1870
1871         * configure: Rebuild.
1872         * configure.ac: Disallow the combination of -static-libstdc++ and
1873         source highlight.
1874         * source-cache.c (get_language_name): Handle rust.
1875         (source_cache::get_source_lines): Ignore highlighting exceptions.
1876
1877 2019-08-16  Tom Tromey  <tom@tromey.com>
1878
1879         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1880         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1881         (struct tui_source_window_base) <make_visible, refresh_window,
1882         resize>: Remove methods.
1883         <execution_info>: Remove field.
1884         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1885         (tui_show_source_line, tui_source_window_base)
1886         (~tui_source_window_base): Update.
1887         (tui_source_window_base::resize)
1888         (tui_source_window_base::make_visible)
1889         (tui_source_window_base::refresh_window): Remove.
1890         (tui_source_window_base::update_exec_info): Update.
1891         * tui/tui-source.c (tui_source_window::set_contents): Update.
1892         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1893
1894 2019-08-16  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1897         deprecated_query_hook.
1898
1899 2019-08-16  Tom Tromey  <tom@tromey.com>
1900
1901         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1902         (tui_update_source_windows_with_line): Update.
1903         * tui/tui-source.h (struct tui_source_window)
1904         <show_symtab_source>: Declare.
1905         (tui_show_symtab_source): Don't declare.
1906         * tui/tui-source.c (tui_show_symtab_source): Rename from
1907         tui_show_symtab_source.
1908
1909 2019-08-16  Tom Tromey  <tom@tromey.com>
1910
1911         * tui/tui-winsource.h (struct tui_source_window_base)
1912         <set_contents>: Declare.
1913         * tui/tui-winsource.c
1914         (tui_source_window_base::update_source_window_as_is): Update.
1915         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1916         Declare.
1917         (tui_set_source_content): Don't declare.
1918         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1919         tui_set_source_content.
1920         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1921         Declare.
1922         (tui_set_disassem_content): Don't declare.
1923         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1924         tui_set_disassem_content.
1925
1926 2019-08-16  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-winsource.h (struct tui_source_window_base)
1929         <update_breakpoint_info>: Declare.
1930         (tui_update_breakpoint_info): Don't declare.
1931         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1932         (tui_update_all_breakpoint_info): Update.
1933         (tui_source_window_base::update_breakpoint_info): Rename from
1934         tui_update_breakpoint_info.
1935         (tui_source_window_base::update_exec_info): Update.
1936
1937 2019-08-16  Tom Tromey  <tom@tromey.com>
1938
1939         * tui/tui-winsource.h (struct tui_source_window_base)
1940         <update_source_window>: Declare.
1941         (tui_update_source_window): Don't declare.
1942         * tui/tui-winsource.c
1943         (tui_source_window_base::update_source_window): Rename from
1944         tui_update_source_window.
1945         (tui_source_window_base::rerender): Update.
1946         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1947         * tui/tui-disasm.c (tui_show_disassem)
1948         (tui_show_disassem_and_update_source)
1949         (tui_disasm_window::maybe_update): Update.
1950
1951 2019-08-16  Tom Tromey  <tom@tromey.com>
1952
1953         * tui/tui-winsource.h (struct tui_source_window_base)
1954         <update_source_window_as_is>: Declare.
1955         (tui_update_source_window_as_is): Don't declare.
1956         * tui/tui-winsource.c (tui_update_source_window): Update
1957         (tui_source_window_base::update_source_window_as_is): Rename from
1958         tui_update_source_window_as_is.
1959         (tui_source_window_base::refill): Update.
1960         * tui/tui-source.c (tui_show_symtab_source): Update.
1961         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1962         Update.
1963
1964 2019-08-16  Tom Tromey  <tom@tromey.com>
1965
1966         * tui/tui-winsource.h (tui_update_source_window)
1967         (tui_update_source_window_as_is): Remove "noerror" parameter.
1968         * tui/tui-winsource.c (tui_update_source_window)
1969         (tui_update_source_window_as_is): Remove "noerror" parameter.
1970         (tui_update_source_windows_with_addr)
1971         (tui_update_source_windows_with_line)
1972         (tui_source_window_base::rerender)
1973         (tui_source_window_base::refill): Update.
1974         * tui/tui-source.h (tui_set_source_content)
1975         (tui_show_symtab_source): Remove "noerror" parameter.
1976         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1977         parameter.
1978         (tui_show_symtab_source): Likewise.
1979         (tui_source_window::maybe_update): Update.
1980         * tui/tui-disasm.c (tui_show_disassem)
1981         (tui_show_disassem_and_update_source)
1982         (tui_disasm_window::do_scroll_vertical)
1983         (tui_disasm_window::maybe_update): Update.
1984
1985 2019-08-16  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui.c (tui_is_window_visible): Update.
1988         * tui/tui-wingeneral.c (tui_make_window)
1989         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1990         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1991         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1992         (tui_set_win_height_command, parse_scrolling_args): Update.
1993         * tui/tui-source.c (tui_source_window::style_changed): Update.
1994         * tui/tui-regs.c (tui_show_registers)
1995         (tui_data_window::first_data_item_displayed)
1996         (tui_data_window::delete_data_content_windows)
1997         (tui_check_register_values, tui_reg_command): Update.
1998         * tui/tui-disasm.c (tui_show_disassem): Update.
1999         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2000         method.
2001         <is_visible>: Remove field.
2002         * tui/tui-data.c (tui_next_win, tui_prev_win)
2003         (tui_delete_invisible_windows): Update.
2004
2005 2019-08-16  Tom Tromey  <tom@tromey.com>
2006
2007         * tui/tui-winsource.h (struct tui_source_window_base)
2008         <m_has_locator>: Remove.
2009         * tui/tui-layout.c (show_source_disasm_command, show_data)
2010         (show_source_or_disasm_and_command): Update.
2011
2012 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2013
2014         * NEWS (Other MI changes): New subsection.
2015         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2016         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2017         * arch-utils.c (default_get_pc_address_flags): New function.
2018         * arch-utils.h (default_get_pc_address_flags): New declaration.
2019         * gdbarch.sh: Add get_pc_address_flags.
2020         * gdbarch.c: Regenerate.
2021         * gdbarch.h: Likewise.
2022         * stack.c (print_pc): New function.
2023         (print_frame_info) (print_frame): Call print_pc.
2024
2025 2019-08-16  Tom de Vries  <tdevries@suse.de>
2026
2027         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2028         print_objfile_section_info.
2029
2030 2019-08-15  Tom Tromey  <tom@tromey.com>
2031
2032         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2033         calling update_cmdwin_start_line.
2034         * tui/tui-winsource.h (struct tui_source_window_base)
2035         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2036         <rerender>: Declare.
2037         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2038         Call rerender.
2039         (tui_source_window_base::set_new_height): Remove.
2040         (tui_source_window_base::rerender): Rename from
2041         do_make_visible_with_new_height.
2042         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2043         resize method.
2044         (tui_win_info::make_invisible_and_set_new_height)
2045         (tui_win_info::make_visible_with_new_height): Remove.
2046         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2047         Declare.
2048         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2049         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2050         do_make_visible_with_new_height>: Don't declare.
2051         <rerender>: Declare.
2052         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2053         set_new_height.
2054         (tui_data_window::do_make_visible_with_new_height): Remove.
2055         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2056         call tui_show_locator_content.
2057         (tui_gen_win_info::resize): Call rerender.
2058         (show_source_or_disasm_and_command): Don't call
2059         tui_show_locator_content.
2060         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2061         method.
2062         (struct tui_win_info) <rerender>: Declare.
2063         <set_new_height, make_invisible_and_set_new_height,
2064         make_visible_with_new_height>: Don't declare.
2065         * tui/tui-data.c (tui_win_list::rerender): New method.
2066         * tui/tui-command.h (struct tui_cmd_window)
2067         <do_make_visible_with_new_height>: Don't declare.
2068         * tui/tui-command.c
2069         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2070
2071 2019-08-15  Tom Tromey  <tromey@adacore.com>
2072
2073         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2074         * ada-lang.c (ada_enum_name): Likewise.
2075
2076 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2077
2078         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2079         leading underscore.
2080         (GdbOutputErrorFile): Likewise.
2081         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2082         accordingly.
2083         (execute_unwinders): Rename to have a leading underscore.
2084         (auto_load_packages): Likewise.
2085         (global scope): Adjust call to auto_load_packages accordingly.
2086         (GdbSetPythonDirectory): Likewise.
2087         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2088         instead of execute_unwinders.
2089
2090 2019-08-15  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2093         (show_data): Don't change window visibility.
2094         (tui_gen_win_info::resize): Remove special case for command
2095         window.  Use wresize, when available.
2096         (show_source_or_disasm_and_command): Don't change window
2097         visibility.
2098         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2099         <make_visible>: New method.
2100         * tui/tui-command.c (tui_cmd_window::resize): New method.
2101
2102 2019-08-15  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2105         (struct tui_source_windows): New.
2106         * tui/tui-winsource.c (tui_display_main): Update.
2107         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2108         (new_height_ok, parse_scrolling_args): Update.
2109         * tui/tui-layout.c (show_layout, show_data): Update.
2110         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2111         (tui_add_to_source_windows): Don't declare.
2112         * tui/tui-data.c (source_windows, tui_source_windows)
2113         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2114
2115 2019-08-15  Tom Tromey  <tom@tromey.com>
2116
2117         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2118         Rename from reset.
2119         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2120         * tui/tui-layout.c (show_source_disasm_command, show_data):
2121         Update.
2122         (tui_gen_win_info::resize): Rename.
2123         (show_source_or_disasm_and_command): Update.
2124         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2125         reset.
2126
2127 2019-08-15  Tom Tromey  <tom@tromey.com>
2128
2129         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2130         * tui/tui-interp.c (tui_interp::init): Don't call
2131         tui_initialize_static_data.
2132         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2133
2134 2019-08-15  Tom Tromey  <tom@tromey.com>
2135
2136         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2137         examine tui_win_list.
2138
2139 2019-08-15  Tom Tromey  <tom@tromey.com>
2140
2141         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2142         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2143         tui_clear_source_content.
2144         (tui_clear_source_content): Remove.
2145         (tui_source_window_base::do_erase_source_content): Hoist call to
2146         content.clear().
2147         * tui/tui-stack.c (tui_show_frame_info): Don't call
2148         tui_clear_source_content.
2149
2150 2019-08-15  Tom Tromey  <tom@tromey.com>
2151
2152         * tui/tui-winsource.h (struct tui_source_window_base)
2153         <do_erase_source_content>: New method.
2154         <erase_source_content>: New method.
2155         (tui_erase_source_content): Don't declare.
2156         * tui/tui-winsource.c (tui_clear_source_content): Update.
2157         (tui_source_window_base::do_erase_source_content): Rename from
2158         tui_erase_source_content.
2159         (tui_source_window_base::show_source_content): Update.
2160         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2161         * tui/tui-source.h (struct tui_source_window)
2162         <erase_source_content>: New method.
2163         * tui/tui-disasm.h (struct tui_disasm_window)
2164         <erase_source_content>: New method.
2165
2166 2019-08-15  Tom Tromey  <tom@tromey.com>
2167
2168         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2169         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2170         constructor.
2171         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2172         * tui/tui-source.c (tui_set_source_content): Update.
2173         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2174
2175 2019-08-15  Tom Tromey  <tom@tromey.com>
2176
2177         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2178         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2179         tui-source.c.
2180         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2181         Declare.
2182         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2183         method.
2184         (tui_source_window::maybe_update): Update.
2185
2186 2019-08-15  Tom Tromey  <tom@tromey.com>
2187
2188         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2189         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2190         tui-disasm.c.
2191         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2192         Declare.
2193         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2194         method.
2195         (tui_disasm_window::maybe_update): Update.
2196
2197 2019-08-15  Tom Tromey  <tom@tromey.com>
2198
2199         * tui/tui-winsource.h (struct tui_source_window_base)
2200         <maybe_update>: Declare.
2201         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2202         method.
2203         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2204         Declare.
2205         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2206         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2207         Declare.
2208         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2209
2210 2019-08-15  Tom Tromey  <tom@tromey.com>
2211
2212         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2213
2214 2019-08-15  Tom Tromey  <tom@tromey.com>
2215
2216         * tui/tui-wingeneral.c: Include tui-stack.h.
2217         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2218         (struct tui_locator_window): Move from tui-data.h.
2219         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2220         (tui_initialize_static_data): Move from tui-data.c.
2221         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2222         (struct tui_locator_window): Move to tui-stack.c.
2223         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2224         (tui_initialize_static_data): Move to tui-stack.c.
2225
2226 2019-08-15  Tom Tromey  <tom@tromey.com>
2227
2228         * tui/tui-layout.c (show_source_disasm_command)
2229         (show_source_or_disasm_and_command): Use make_visible method, not
2230         tui_make_window.
2231         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2232         Remove.
2233
2234 2019-08-15  Tom Tromey  <tom@tromey.com>
2235
2236         * tui/tui-wingeneral.h (tui_make_window): Update.
2237         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2238         parameter.
2239         (tui_gen_win_info::make_visible): Update.
2240         * tui/tui-regs.c (tui_data_window::display_registers_from):
2241         Update.
2242         * tui/tui-layout.c (show_source_disasm_command)
2243         (show_source_or_disasm_and_command): Update.
2244         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2245         (enum tui_box): Remove.
2246         (struct tui_win_info) <can_box>: New method.
2247         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2248         method.
2249
2250 2019-08-15  Tom de Vries  <tdevries@suse.de>
2251
2252         * linux-nat-trad.c: Include gdbarch.h.
2253
2254 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2255
2256         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2257         register sizes.
2258
2259 2019-08-14  Tom Tromey  <tromey@adacore.com>
2260
2261         * darwin-nat.c: Include gdbarch.h.
2262         * darwin-nat-info.c: Include gdbarch.h.
2263
2264 2019-08-13  Tom Tromey  <tom@tromey.com>
2265
2266         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2267         Remove.
2268         * tui/tui-data.c (tui_initialize_static_data): Update.
2269
2270 2019-08-13  Tom Tromey  <tom@tromey.com>
2271
2272         * tui/tui-winsource.h (struct tui_exec_info_window)
2273         <~tui_exec_info_window, maybe_allocate_content, get_content,
2274         m_content>: Remove.
2275         (struct tui_source_window_base) <set_exec_info_content,
2276         show_exec_info_content>: Don't declare.
2277         * tui/tui-winsource.c
2278         (tui_exec_info_window::maybe_allocate_content): Remove.
2279         (tui_source_window_base::update_exec_info): Rename from
2280         set_exec_info_content.
2281         (tui_source_window_base::show_exec_info_content)
2282         (tui_source_window_base::update_exec_info): Remove.
2283
2284 2019-08-13  Tom Tromey  <tom@tromey.com>
2285
2286         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2287         declare.
2288         * tui/tui-winsource.c (tui_update_source_window_as_is)
2289         (tui_update_source_windows_with_addr, tui_erase_source_content):
2290         Update.
2291         (tui_clear_exec_info_content): Remove.
2292
2293 2019-08-13  Tom Tromey  <tom@tromey.com>
2294
2295         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2296         declare.
2297         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2298         call tui_erase_exec_info_content.
2299         (tui_clear_exec_info_content): Rename from
2300         tui_erase_exec_info_content.
2301         (tui_clear_exec_info_content): Delete.
2302
2303 2019-08-13  Tom Tromey  <tom@tromey.com>
2304
2305         * tui/tui-winsource.h (struct tui_source_window_base)
2306         <show_exec_info_content>: Declare.
2307         (tui_show_exec_info_content): Don't declare.
2308         * tui/tui-winsource.c
2309         (tui_source_window_base::show_exec_info_content): Rename from
2310         tui_show_exec_info_content.
2311         (tui_source_window_base::update_exec_info): Update.
2312
2313 2019-08-13  Tom Tromey  <tom@tromey.com>
2314
2315         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2316         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2317         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2318         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2319         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2320         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2321         ... here.
2322
2323 2019-08-13  Tom Tromey  <tom@tromey.com>
2324
2325         * tui/tui-winsource.h (struct tui_source_window_base)
2326         <update_exec_info>: Declare.
2327         (tui_update_exec_info): Don't declare.
2328         * tui/tui-winsource.c (tui_update_source_window_as_is)
2329         (tui_source_window_base::refresh_all)
2330         (tui_update_all_breakpoint_info): Update.
2331         (tui_source_window_base::update_exec_info): Rename from
2332         tui_update_exec_info.
2333         * tui/tui-stack.c (tui_show_frame_info): Update.
2334
2335 2019-08-13  Tom Tromey  <tom@tromey.com>
2336
2337         * tui/tui-winsource.h (struct tui_source_window_base)
2338         <set_exec_info_content>: Declare.
2339         (tui_set_exec_info_content): Don't declare.
2340         * tui/tui-winsource.c
2341         (tui_source_window_base::set_exec_info_content): Rename from
2342         tui_set_exec_info_content.
2343         (tui_update_exec_info): Update.
2344
2345 2019-08-13  Tom Tromey  <tom@tromey.com>
2346
2347         * tui/tui-winsource.h (struct tui_source_window_base)
2348         <show_source_content>: Declare.
2349         (tui_show_source_content): Don't declare.
2350         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2351         (tui_source_window_base::show_source_content): Rename from
2352         tui_show_source_content.
2353         (tui_source_window_base::refresh_all): Update.
2354         * tui/tui-layout.c (show_source_disasm_command)
2355         (show_source_or_disasm_and_command): Update.
2356
2357 2019-08-13  Tom Tromey  <tom@tromey.com>
2358
2359         * tui/tui-winsource.c (tui_erase_source_content)
2360         (tui_show_source_content, tui_source_window_base::refresh_all):
2361         Update.
2362         * tui/tui-wingeneral.h
2363         (tui_check_and_display_highlight_if_needed): Don't declare.
2364         * tui/tui-wingeneral.c
2365         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2366         check_and_display_highlight_if_needed.
2367         * tui/tui-win.c (tui_rehighlight_all)
2368         (tui_win_info::make_visible_with_new_height): Update.
2369         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2370         (tui_data_window::erase_data_content)
2371         (tui_data_window::display_all_data): Update.
2372         * tui/tui-data.h (struct tui_win_info)
2373         <check_and_display_highlight_if_needed>: Declare.
2374
2375 2019-08-13  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-win.c (tui_resize_all): Call
2378         tui_delete_invisible_windows.
2379         * tui/tui-layout.c (show_layout): Call
2380         tui_delete_invisible_windows.
2381         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2382         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2383
2384 2019-08-13  Tom Tromey  <tom@tromey.com>
2385
2386         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2387         tui_add_win_to_layout.
2388
2389 2019-08-13  Tom Tromey  <tom@tromey.com>
2390
2391         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2392         * tui/tui-layout.c (tui_default_win_height): Now static.
2393
2394 2019-08-13  Tom Tromey  <tom@tromey.com>
2395
2396         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2397         single switch.
2398         (show_source_disasm_command, show_source_or_disasm_and_command):
2399         Don't check current layout.
2400
2401 2019-08-13  Tom Tromey  <tom@tromey.com>
2402
2403         * tui/tui-wingeneral.c (make_all_visible): Remove.
2404         (tui_make_all_invisible): Simplify.
2405         * tui/tui-layout.c (tui_make_all_invisible): Move from
2406         tui-wingeneral.c; simplify.
2407         (show_layout): Hoist call to tui_make_all_invisible.
2408         (show_data): Don't call tui_make_all_invisible.
2409
2410 2019-08-13  Tom Tromey  <tom@tromey.com>
2411
2412         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2413         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2414
2415 2019-08-13  Tom Tromey  <tom@tromey.com>
2416
2417         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2418         tui-data.c.
2419         (show_source_disasm_command, show_data)
2420         (show_source_or_disasm_and_command): Don't use
2421         tui_set_current_layout_to.
2422         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2423         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2424         tui-layout.c.
2425         (tui_set_current_layout_to): Remove.
2426
2427 2019-08-13  Tom Tromey  <tom@tromey.com>
2428
2429         * tui/tui-layout.c (tui_set_layout): Update.
2430         * tui/tui-data.h (struct tui_layout_def): Remove.
2431         (tui_layout_def): Don't declare.
2432         * tui/tui-data.c (layout_def): Remove.
2433         (tui_layout_def): Remove.
2434
2435 2019-08-13  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-winsource.h (struct tui_source_window_base)
2438         <clear_detail>: No longer "override".
2439         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2440         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2441         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2442         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2443         Remove.
2444         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2445
2446 2019-08-13  Tom Tromey  <tromey@adacore.com>
2447
2448         * tracepoint.c: Don't include readline.h or history.h.
2449
2450 2019-08-12  Tom Tromey  <tom@tromey.com>
2451
2452         * configure: Rebuild.
2453         * configure.ac: Check for readline 7.
2454         * NEWS: Mention readline 7 requirement.
2455         * README: Update.
2456
2457 2019-08-12  Tom Tromey  <tom@tromey.com>
2458
2459         * mingw-hdep.c (gdb_select): Remove readline hack.
2460
2461 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2462
2463         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2464         when the function fails.
2465
2466 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2467
2468         * s390-tdep.c (s390_type_align): New function.
2469         (s390_gdbarch_init): Set it as type_align gdbarch method.
2470
2471 2019-08-09  Tom de Vries  <tdevries@suse.de>
2472
2473         PR gdb/24591
2474         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2475         pc_low with relocation offset.
2476
2477 2019-08-07  Tom Tromey  <tromey@adacore.com>
2478
2479         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2480         (print_frame_args): Update.
2481         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2482         Update.
2483         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2484         * frame.h (struct frame_arg): Add initializers.
2485         <error>: Now a unique_xmalloc_ptr.
2486
2487 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2488
2489         * NEWS: Expand the Pointer Authentication entry.
2490         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2491         (aarch64_frame_unmask_lr): ... to this.
2492         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2493         Call aarch64_frame_unmask_lr.
2494         * frame.c (struct frame_info): Add "masked" variable.
2495         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2496         (fprint_frame): Check for masked pc.
2497         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2498         declarations.
2499         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2500         * stack.c (print_frame): Check for masked pc.
2501
2502 2019-08-06  Tom Tromey  <tom@tromey.com>
2503
2504         * stabsread.c (patch_block_stabs, read_one_struct_field)
2505         (read_enum_type): Use obstack_strndup.
2506         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2507         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2508         * dwarf2read.c (guess_full_die_structure_name)
2509         (anonymous_struct_prefix): Use obstack_strndup.
2510         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2511         * c-exp.y (yylex): Use obstack_strndup.
2512         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2513         (write_var_or_type): Use obstack_strndup.
2514
2515 2019-08-06  Tom Tromey  <tom@tromey.com>
2516
2517         * symfile.c (reread_symbols): Use obstack_strdup.
2518         * stabsread.c (read_type): Use obstack_strdup.
2519         * gdb_obstack.h (obstack_strdup): New overload.
2520         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2521         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2522         (dwarf2_canonicalize_name): Use obstack_strdup.
2523         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2524         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2525         Use obstack_strdup.
2526
2527 2019-08-06  Tom Tromey  <tom@tromey.com>
2528
2529         * gdb_obstack.h (obstack_strdup): Define.
2530         * gdb_obstack.c (obstack_strdup): Don't define.
2531
2532 2019-08-06  Tom Tromey  <tom@tromey.com>
2533
2534         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2535         obstack_strdup.
2536         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2537         obstack_strdup.
2538         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2539         * stabsread.c (common_block_start): Use obstack_strdup.
2540         * objfiles.c (set_objfile_main_name, objfile): Use
2541         obstack_strdup.
2542         * namespace.c (add_using_directive): Use obstack_strdup.
2543         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2544         * jit.c (finalize_symtab): Use obstack_strdup.
2545         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2546         (guess_partial_die_structure_name, partial_die_info::fixup)
2547         (dwarf2_name): Use obstack_strdup.
2548         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2549         obstack_strdup.
2550         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2551         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2552         obstack_strdup.
2553         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2554
2555 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2556
2557         * unittests/help-doc-selftests.c: New file.
2558         * Makefile.in: Add the new file.
2559
2560 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2561
2562         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2563         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2564         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2565         the trailing '.' is not output, and the first character is uppercased.
2566         (print_help_for_command): Update call to print_doc_line.
2567         (print_doc_of_command): Likewise.
2568         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2569         * cli/cli-option.c (append_indented_doc): Do not append newline.
2570         (build_help_option): Append newline after first appended_indented_doc
2571         only if a second call is done.
2572         (build_help): Append 2 new lines before each option, except the first
2573         one.
2574         * compile/compile.c (_initialize_compile): Add new lines after
2575         %OPTIONS%, when not at the end of the help.
2576         Change help doc or code
2577         producing the help doc to respect the invariants.
2578         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2579         Also removed the new line after 'Options:', as all other commands
2580         do not put an empty line between 'Options:' and the first option.
2581         * printcmd.c (_initialize_printcmd): Likewise.
2582         * stack.c (_initialize_stack): Likewise.
2583         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2584         incorrectly telling COMMAND is optional.
2585         * ada-lang.c (_initialize_ada_language): Change help doc or code
2586         producing the help doc to respect the invariants.
2587         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2588         * breakpoint.c (_initialize_breakpoint): Likewise.
2589         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2590         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2591         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2592         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2593         _initialize_cli_style): Likewise.
2594         * corelow.c (core_target_info): Likewise.
2595         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2596         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2597         * filesystem.c (_initialize_filesystem): Likewise.
2598         * frame.c (_initialize_frame): Likewise.
2599         * gnu-nat.c (add_task_commands): Likewise.
2600         * infcall.c (_initialize_infcall): Likewise.
2601         * infcmd.c (_initialize_infcmd): Likewise.
2602         * interps.c (_initialize_interpreter): Likewise.
2603         * language.c (_initialize_language): Likewise.
2604         * linux-fork.c (_initialize_linux_fork): Likewise.
2605         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2606         * maint.c (_initialize_maint_cmds): Likewise.
2607         * memattr.c (_initialize_mem): Likewise.
2608         * printcmd.c (_initialize_printcmd): Likewise.
2609         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2610         _RegEx): Likewise.
2611         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2612         * record-btrace.c (_initialize_record_btrace): Likewise.
2613         * record-full.c (_initialize_record_full): Likewise.
2614         * record.c (_initialize_record): Likewise.
2615         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2616         * regcache.c (_initialize_regcache): Likewise.
2617         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2618         _initialize_remote): Likewise.
2619         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2620         * serial.c (_initialize_serial): Likewise.
2621         * skip.c (_initialize_step_skip): Likewise.
2622         * source.c (_initialize_source): Likewise.
2623         * stack.c (_initialize_stack): Likewise.
2624         * symfile.c (_initialize_symfile): Likewise.
2625         * symtab.c (_initialize_symtab): Likewise.
2626         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2627         * top.c (init_main): Likewise.
2628         * tracefile-tfile.c (tfile_target_info): Likewise.
2629         * tracepoint.c (_initialize_tracepoint): Likewise.
2630         * tui/tui-win.c (_initialize_tui_win): Likewise.
2631         * utils.c (add_internal_problem_command): Likewise.
2632         * valprint.c (value_print_option_defs): Likewise.
2633
2634 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2635
2636         PR build/24886
2637         * configure.ac: Drop enable-libmcheck support.
2638         * configure, config.in: Rebuild.
2639         * libmcheck.m4: Remove.
2640         * acinclude.m4: Don't include it.
2641         * Makefile.in: Don't distribute it.
2642         * top.c (print_gdb_configuration): Don't mention it.
2643
2644 2019-08-06  Tom Tromey  <tom@tromey.com>
2645
2646         * utils.c (set_output_style): Sometimes pass stream to
2647         emit_style_escape.
2648         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2649         * record-btrace.c (btrace_insn_history): Update.
2650         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2651         method.
2652         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2653         Update initializers.
2654         <m_uiout>: New field.
2655         <m_di>: Move lower.
2656         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2657         Remove "uiout" parameter.
2658         (dump_insns): Update.
2659         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2660         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2661
2662 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2663
2664         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2665         (error_in_psymtab_expansion): Likewise.
2666         (lookup_symbol_via_quick_fns): Likewise.
2667         (basic_lookup_transparent_type_quick): Likewise.
2668         (basic_lookup_transparent_type_1): Likewise.
2669
2670 2019-08-06  Tom Tromey  <tromey@adacore.com>
2671
2672         * source.c (last_source_error): Now bool.
2673         (print_source_lines_base): Make "noprint" bool.  Only open
2674         source file when last_source_visited changes.
2675
2676 2019-08-06  Tom Tromey  <tromey@adacore.com>
2677
2678         * annotate.c (annotate_source_line): Use g_source_cache.
2679         * source-cache.c (source_cache::get_plain_source_lines): Change
2680         parameters.  Populate m_offset_cache.
2681         (source_cache::ensure): New method.
2682         (source_cache::get_line_charpos): New method.
2683         (extract_lines): Move lower.  Change parameters.
2684         (source_cache::get_source_lines): Move lower.
2685         * source-cache.h (class source_cache): Update comment.
2686         <get_line_charpos>: New method.
2687         <get_source_lines>: Update comment.
2688         <clear>: Clear m_offset_cache.
2689         <get_plain_source_lines>: Change parameters.
2690         <ensure>: New method
2691         <m_offset_cache>: New member.
2692         * source.c (forget_cached_source_info_for_objfile): Update.
2693         (info_source_command): Use g_source_cache.
2694         (find_source_lines, open_source_file_with_line_charpos): Remove.
2695         (print_source_lines_base, search_command_helper): Use g_source_cache.
2696         * source.h (open_source_file_with_line_charpos): Don't declare.
2697         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2698         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2699         Use g_source_cache.
2700
2701 2019-08-06  Tom Tromey  <tromey@adacore.com>
2702
2703         * source-cache.c (source_cache::get_plain_source_lines):
2704         Remove "first_line" and "last_line" parameters.
2705         (source_cache::get_source_lines): Cache plain text.
2706         * source-cache.h (class source_cache)
2707         <get_plain_source_lines>: Update.
2708
2709 2019-08-06  Tom Tromey  <tromey@adacore.com>
2710
2711         * source-cache.c (extract_lines): No longer a method.
2712         Changed type of parameter.  Include final newline.
2713         (selftests::extract_lines_test): New function.
2714         (_initialize_source_cache): Likewise.
2715         * source-cache.h (class source_cache)
2716         <extract_lines>: Don't declare.
2717
2718 2019-08-06  Tom Tromey  <tromey@adacore.com>
2719
2720         * breakpoint.c (init_breakpoint_sal): Update.
2721         (breakpoint): Update.
2722         * breakpoint.h (struct breakpoint) <filter>: Now a
2723         unique_xmalloc_ptr.
2724
2725 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2726
2727         * NEWS: Mention dictionary access on blocks.
2728         * python/py-block.c (blpy_getitem): New function.
2729         (block_object_as_mapping): New struct.
2730         (block_object_type): Use new struct for tp_as_mapping field.
2731
2732 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2733
2734         * objfiles.h (objfile): Add a comment describing partial symbols.
2735
2736 2019-08-05  Tom Tromey  <tromey@adacore.com>
2737
2738         * compile/compile.c (_initialize_compile): Use _(), not N_().
2739         * thread.c (_initialize_thread): Use _(), not N_().
2740         * stack.c (_initialize_stack): Use _(), not N_().
2741         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2742
2743 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2744
2745         * dwarf2read.c (struct dw2_symtab_iterator):
2746         <want_specific_block>: Remove.
2747         <block_index>: Change type to gdb::optional.
2748         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2749         change type of BLOCK_INDEX parameter to gdb::optional.
2750         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2751         (dw2_lookup_symbol): Don't pass argument for
2752         WANT_SPECIFIC_BLOCK.
2753         (dw2_expand_symtabs_for_function): Don't pass argument for
2754         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2755         (class dw2_debug_names_iterator)
2756         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2757         parameter, change BLOCK_INDEX type to gdb::optional.
2758         <m_want_specific_block>: Remove.
2759         <m_block_index>: Change type to gdb::optional.
2760         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2761         gdb::optional.  Re-write in function of gdb::optional.
2762         (dw2_debug_names_lookup_symbol): Don't pass argument for
2763         WANT_SPECIFIC_BLOCK.
2764         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2765         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2766         BLOCK_INDEX.
2767
2768 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2769
2770         * NEWS: Mention changes to "info sources" command.
2771
2772 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2773
2774         * symtab.c (filename_partial_match_opts): New struct type.
2775         (struct output_source_filename_data): New members
2776         regexp, c_regexp, partial_match.
2777         (output_source_filename): Use new members to decide to print file.
2778         (info_sources_option_defs): New variable.
2779         (make_info_sources_options_def_group, print_info_sources_header,
2780         info_sources_command_completer):
2781         New functions.
2782         (info_sources_command): Read new optional arguments.
2783         (_initialize_symtab): Update info sources help.
2784
2785 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2786
2787         * ada-lang.c (exception_support_info_v0): Renamed from...
2788         (default_exception_support_info): ... this.  Create new
2789         definition for v1.
2790         (ada_has_this_exception_support): Look up catch_handlers_sym.
2791         (ada_exception_support_info_sniffer): Try v0 after default.
2792
2793 2019-08-01  Tom Tromey  <tromey@adacore.com>
2794
2795         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2796         gdbarch.h.
2797
2798 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2799
2800         * s12z-tdep.c: Fix include path for s12z-opc.h.
2801
2802 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2803
2804         * NEWS: Require GNU make 3.82.
2805
2806 2019-07-16  Tom Tromey  <tom@tromey.com>
2807
2808         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2809         declare.
2810
2811 2019-07-30  Tom Tromey  <tromey@adacore.com>
2812
2813         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2814
2815 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2816
2817         * printcmd.c (print_address_symbolic): Print negative offsets.
2818         (build_address_symbolic): Force signed arithmetic when computing
2819         offset.
2820
2821 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2822
2823         PR/24474: Add a function to lookup static variables.
2824         * NEWS: Mention this new function.
2825         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2826         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2827         * python/python.c (python_GdbMethods): Add new function.
2828
2829 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2830
2831         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2832         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2833         (objfpy_lookup_static_symbol): New function.
2834         (objfile_object_methods): Add new functions.
2835
2836 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2837
2838         * NEWS: Mention 'set|show print frame-info'.  Mention new
2839         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2840         backtrace argument.  Mention that python frame filtering code
2841         is now consistent with what 'backtrace' command prints.
2842
2843 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2844
2845         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2846         comments.
2847         (print_frame_info_auto, print_frame_info_source_line,
2848         print_frame_info_location, print_frame_info_source_and_location,
2849         print_frame_info_location_and_address, print_frame_info_short_location):
2850         New declarations.
2851         (struct frame_print_options): New member print_frame_info.
2852         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2853         * stack.h (get_user_print_what_frame_info): New declaration.
2854         (frame_show_address): New declaration.
2855         * stack.c (print_frame_arguments_choices): New value 'presence'.
2856         (print_frame_info_auto, print_frame_info_source_line,
2857         print_frame_info_location, print_frame_info_source_and_location,
2858         print_frame_info_location_and_address, print_frame_info_short_location,
2859         print_frame_info_choices, print_frame_info_print_what): New definitions.
2860         (print_frame_args): Only print dots for args if print frame-arguments
2861         is 'presence'.
2862         (frame_print_option_defs): New element for "frame-info".
2863         (get_user_print_what_frame_info): New function.
2864         (frame_show_address): Make non static.  Move comment to stack.h.
2865         (print_frame_info_to_print_what): New function.
2866         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2867         to decide what to print.
2868         (backtrace_command_1): Handle the new print_frame_arguments_presence
2869         value.
2870         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2871         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2872         (py_print_frame): In non-mi mode, use LOCATION as default for
2873         print_what, similarly to frame information printed directly by
2874         backtrace command. Handle frame-info user option in non MI mode.
2875
2876 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2877
2878         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2879         Add case for debugging 32-bit target on 64-bit host.  Revise
2880         comment.
2881
2882 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2883
2884         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2885         instead of find_function_entry_range_from_pc.
2886
2887 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2888
2889         * stack.c (find_frame_funname): Remove code which preferred
2890         minsym over symtab sym in "certain pathological cases".
2891
2892         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2893         parameter.  Change type of "do_demangle" to bool.
2894         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2895         Pass suitable "prefer_sym_over_minsym" flag to
2896         build_address_symbolic().  Don't output "+" for negative offsets.
2897         * printcmd.c (print_address_symbolic): Update invocation of
2898         build_address_symbolic to include a "prefer_sym_over_minsym"
2899         flag.
2900         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2901         Restrict cases in which use of minimal symbol is preferred to that
2902         of a found symbol.  Update comments.
2903
2904         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2905         for entry pc when entry pc is out of range for that FDE.
2906
2907 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2908
2909         PR gdb/24839:
2910         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2911         type.
2912
2913 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2914
2915         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2916         this function's Python signature.
2917
2918
2919 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2920
2921         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2922         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2923         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2924         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2925         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2926
2927
2928 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2929
2930         * h8300-tdep.c (h8300_register_name_common): New.
2931         h8300_register_name): Use h8300_register_name_common.
2932         (h8300s_register_name): Likewise.
2933         (h8300sx_register_name): Likewise.
2934         (h8300h_register_nam): New.
2935         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2936
2937
2938 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2939
2940         * arm-tdep.c (arm_skip_cmse_entry): New function.
2941         (arm_is_sgstubs_section): New function.
2942         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2943
2944 2019-07-22  Tom Tromey  <tom@tromey.com>
2945
2946         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2947         Don't self-assign.
2948
2949 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2950
2951         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2952         type_print.
2953
2954 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2955
2956         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2957         so that GDB doesn't match any msymbols when searching in the
2958         TYPES_DOMAIN.
2959         (print_symbol_info): Print using typedef_print or type_print based
2960         on the type of the symbol.  Add updated FIXME comment moved from...
2961         (_initialize_symtab): ... move and update FIXME comment to above.
2962
2963 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2964
2965         * NEWS: Mention adding -q option to "info types".
2966         * symtab.c (struct info_types_options): New struct.
2967         (info_types_options_defs): New variable.
2968         (make_info_types_options_def_group): New function.
2969         (info_types_command): Use gdb::option framework to parse options.
2970         (info_types_command_completer): New function.
2971         (_initialize_symtab): Extend the help text on "info types" and
2972         register command completer.
2973
2974 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2975
2976         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2977         (lookup_symbol_in_objfile): Change int to block_enum and add a
2978         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2979
2980 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2981
2982         * MAINTAINERS (Write After Approval): Add self.
2983
2984 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2985
2986         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2987         instruction to the dummy code region.
2988
2989 2019-07-19  Tom Tromey  <tromey@adacore.com>
2990
2991         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2992         (ARGSUSED, PARAMS, __func__): Remove rules.
2993
2994 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2995
2996         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2997         * features/arm/arm-with-iwmmxt.c: Remove.
2998         * features/arm/arm-with-iwmmxt.xml: Remove.
2999         * features/arm/arm-with-m-fpa-layout.c: Remove.
3000         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3001         * features/arm/arm-with-m-vfp-d16.c: Remove.
3002         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3003         * features/arm/arm-with-m.c: Remove.
3004         * features/arm/arm-with-m.xml: Remove.
3005         * features/arm/arm-with-neon.c: Remove.
3006         * features/arm/arm-with-neon.xml: Remove.
3007         * features/arm/arm-with-vfpv2.c: Remove.
3008         * features/arm/arm-with-vfpv2.xml: Remove.
3009         * features/arm/arm-with-vfpv3.c: Remove.
3010         * features/arm/arm-with-vfpv3.xml: Remove.
3011
3012 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3013
3014         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3015
3016 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3017
3018         * arch/aarch32.c (aarch32_create_target_description): Create
3019         target descriptions using features.
3020         * arch/arm.c (arm_create_target_description)
3021         (arm_create_mprofile_target_description): Likewise.
3022         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3023
3024 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3025
3026         * Makefile.in: Add new files.
3027         * aarch32-tdep.c: New file.
3028         * aarch32-tdep.h: New file.
3029         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3030         Call aarch32_read_description.
3031         * arch/aarch32.c: New file.
3032         * arch/aarch32.h: New file.
3033         * arch/arm.c (arm_create_target_description)
3034         (arm_create_mprofile_target_description): New function.
3035         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3036         (arm_create_target_description)
3037         (arm_create_mprofile_target_description): New declaration.
3038         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3039         read_description functions.
3040         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3041         Likewise.
3042         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3043         * arm-tdep.c (tdesc_arm_list): New variable.
3044         (arm_register_g_packet_guesses): Call create description functions.
3045         (arm_read_description) (arm_read_mprofile_description): New
3046         function.
3047         * arm-tdep.h (arm_read_description)
3048         (arm_read_mprofile_description): Add declaration.
3049         * configure.tgt: Add new files.
3050
3051 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3052
3053         * top.c (new_ui_command): Open specified terminal just once.
3054
3055 2019-07-18  Tom Tromey  <tromey@adacore.com>
3056
3057         * symtab.c (main_name): Constify return type.
3058         * symfile.c (set_initial_language): Update.
3059         * symtab.h (main_name): Constify return type.
3060
3061 2019-07-17  Tom Tromey  <tom@tromey.com>
3062
3063         * tui/tui-winsource.c (tui_update_source_window)
3064         (tui_update_source_window_as_is)
3065         (tui_update_source_windows_with_line): Remove return.
3066         * tui/tui-disasm.c (tui_show_disassem)
3067         (tui_show_disassem_and_update_source): Remove return.
3068         * tui/tui.c (tui_reset): Remove return.
3069         * tui/tui-wingeneral.c
3070         (tui_check_and_display_highlight_if_needed): Remove return.
3071
3072 2019-07-17  Tom Tromey  <tom@tromey.com>
3073
3074         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3075
3076 2019-07-17  Tom Tromey  <tom@tromey.com>
3077
3078         * tui/tui-winsource.h (struct tui_exec_info_window)
3079         (struct tui_source_window_base): Move from tui-data.h.
3080         * tui/tui-winsource.c: Move many method definitions from
3081         elsewhere.  Remove "structuring" comments.
3082         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3083         (tui_source_window_base::refresh_window): Move to
3084         tui-winsource.c.
3085         * tui/tui-win.c (tui_source_window_base::refresh_all)
3086         (tui_source_window_base::update_tab_width)
3087         (tui_source_window_base::set_new_height)
3088         (tui_source_window_base::do_make_visible_with_new_height): Move to
3089         tui-winsource.c.
3090         * tui/tui-source.h: Update.
3091         * tui/tui-source.c (tui_source_window_base::reset): Move to
3092         tui-winsource.c.
3093         * tui/tui-disasm.h: Update.
3094         * tui/tui-data.h (struct tui_exec_info_window): Move to
3095         tui-winsource.h.
3096         (struct tui_source_window_base): Likewise.
3097         * tui/tui-data.c (tui_source_window_base::clear_detail)
3098         (tui_source_window_base, ~tui_source_window_base): Move to
3099         tui-winsource.c.
3100
3101 2019-07-17  Tom Tromey  <tom@tromey.com>
3102
3103         * tui/tui-win.c (tui_resize_all)
3104         (tui_source_window_base::update_tab_width)
3105         (tui_adjust_win_heights): Update.
3106         (tui_win_info::make_invisible_and_set_new_height): Rename from
3107         make_invisible_and_set_new_height.
3108         * tui/tui-data.h (struct tui_win_info)
3109         <make_invisible_and_set_new_height>: New method.
3110
3111 2019-07-17  Tom Tromey  <tom@tromey.com>
3112
3113         * tui/tui.c: Update.
3114         * tui/tui-source.h (struct tui_source_window): Move from
3115         tui-data.h.
3116         * tui/tui-layout.c: Update.
3117         * tui/tui-disasm.c: Update.
3118         * tui/tui-data.h (struct tui_source_window): Move to
3119         tui-source.h.
3120
3121 2019-07-17  Tom Tromey  <tom@tromey.com>
3122
3123         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3124         tui-data.h.
3125         * tui/tui-data.h (struct tui_disasm_window): Move to
3126         tui-disasm.h.
3127
3128 2019-07-17  Tom Tromey  <tom@tromey.com>
3129
3130         * tui/tui-regs.h (struct tui_data_item_window): Move from
3131         tui-data.h.
3132         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3133         * tui/tui-data.h (struct tui_data_item_window): Move to
3134         tui-regs.h.
3135         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3136
3137 2019-07-17  Tom Tromey  <tom@tromey.com>
3138
3139         * tui/tui.c: Update.
3140         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3141         (tui_cmd_window::max_height): Move to tui-command.c.
3142         * tui/tui-layout.c: Update.
3143         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3144         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3145         tui-command.c.
3146         * tui/tui-command.h (struct tui_cmd_window): Move from
3147         tui-data.h.
3148         * tui/tui-command.c: Remove "structuring" comments.
3149         (tui_cmd_window::clear_detail)
3150         (tui_cmd_window::do_make_visible_with_new_height)
3151         (tui_cmd_window::max_height): Move from elsewhere.
3152
3153 2019-07-17  Tom Tromey  <tom@tromey.com>
3154
3155         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3156         Now static.
3157         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3158         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3159
3160 2019-07-17  Tom Tromey  <tom@tromey.com>
3161
3162         * tui/tui.c: Update.
3163         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3164         tui-regs.c.
3165         * tui/tui-windata.h: Remove file.
3166         * tui/tui-windata.c: Remove file.
3167         * tui/tui-win.c (tui_data_window::set_new_height)
3168         (tui_data_window::do_make_visible_with_new_height): Move to
3169         tui-regs.c.
3170         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3171         * tui/tui-regs.c: Remove "structuring" comments.
3172         (tui_data_window::first_data_item_displayed)
3173         (tui_data_window::delete_data_content_windows)
3174         (tui_data_window::erase_data_content)
3175         (tui_data_window::display_all_data)
3176         (tui_data_window::refresh_all)
3177         (tui_data_window::do_scroll_vertical)
3178         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3179         (tui_data_window::do_make_visible_with_new_height)
3180         (tui_data_window::refresh_window): Move from elsewhere.
3181         (_initialize_tui_regs): Move to end of file.
3182         * tui/tui-layout.c: Update.
3183         * tui/tui-hooks.c: Update.
3184         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3185         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3186         tui-regs.c.
3187         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3188
3189 2019-07-17  Tom Tromey  <tom@tromey.com>
3190
3191         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3192         seen.
3193
3194 2019-07-17  Tom Tromey  <tom@tromey.com>
3195
3196         * tui/tui-win.c (tui_source_window_base::set_new_height)
3197         (tui_source_window_base::do_make_visible_with_new_height): Use
3198         m_has_locator field directly.
3199         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3200         method.
3201         (struct tui_source_window_base) <has_locator>: Likewise.
3202
3203 2019-07-17  Tom Tromey  <tom@tromey.com>
3204
3205         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3206         Don't declare.
3207         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3208         Remove.
3209         * tui/tui-win.c (tui_source_window_base::set_new_height)
3210         (tui_source_window_base::set_new_height)
3211         (make_invisible_and_set_new_height)
3212         (tui_source_window_base::do_make_visible_with_new_height)
3213         (tui_source_window_base::do_make_visible_with_new_height):
3214         Update.
3215         * tui/tui-layout.c (show_source_disasm_command, show_data)
3216         (show_source_or_disasm_and_command): Update.
3217         * tui/tui-layout.c (show_layout): Update.
3218
3219 2019-07-17  Tom Tromey  <tom@tromey.com>
3220
3221         * tui/tui-layout.c (make_data_window): Remove.
3222         (show_data): Unify creation and re-initialization cases.
3223
3224 2019-07-17  Tom Tromey  <tom@tromey.com>
3225
3226         * tui/tui-layout.c (make_source_window, make_disasm_window):
3227         Remove.
3228         (show_data): Unify creation and re-initialization cases.
3229
3230 2019-07-17  Tom Tromey  <tom@tromey.com>
3231
3232         * tui/tui-layout.c (make_command_window): Remove.
3233         (show_source_disasm_command, show_source_or_disasm_and_command):
3234         Unify creation and re-initialization cases.
3235
3236 2019-07-17  Tom Tromey  <tom@tromey.com>
3237
3238         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3239         creation and re-initialization cases.
3240
3241 2019-07-17  Tom Tromey  <tom@tromey.com>
3242
3243         * tui/tui-regs.c (tui_get_register): Return void.
3244
3245 2019-07-17  Tom Tromey  <tom@tromey.com>
3246
3247         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3248         Simplify.
3249
3250 2019-07-17  Tom Tromey  <tom@tromey.com>
3251
3252         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3253         resetting.
3254
3255 2019-07-17  Tom Tromey  <tom@tromey.com>
3256
3257         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3258         * tui/tui-regs.c (tui_reg_layout): New function.
3259         (tui_show_registers, tui_reg_command): Use it.
3260         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3261         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3262         parameters.
3263         (tui_layout_command): Remove.
3264
3265 2019-07-17  Tom Tromey  <tom@tromey.com>
3266
3267         * tui/tui-layout.h (tui/tui-layout): Return void.
3268         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3269
3270 2019-07-17  Tom Tromey  <tom@tromey.com>
3271
3272         * tui/tui-layout.c (show_source_disasm_command, show_data):
3273         Update.
3274         (reset_locator): Remove.
3275         (show_source_or_disasm_and_command): Update.
3276
3277 2019-07-17  Tom Tromey  <tom@tromey.com>
3278
3279         * tui/tui-source.c (tui_source_window_base::reset): Remove
3280         win_type parameter.
3281         * tui/tui-layout.c (make_command_window, make_source_window)
3282         (make_disasm_window, make_data_window)
3283         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3284         (reset_locator, show_source_or_disasm_and_command): Update.
3285         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3286         win_type parameter.
3287         (struct tui_source_window_base) <reset>: Likewise.
3288
3289 2019-07-17  Tom Tromey  <tom@tromey.com>
3290
3291         * tui/tui-layout.c (show_source_disasm_command): Use
3292         reset_locator.
3293         (reset_locator): New function.
3294         (init_and_make_win): Remove.
3295         (show_source_or_disasm_and_command): Use reset_locator.
3296
3297 2019-07-17  Tom Tromey  <tom@tromey.com>
3298
3299         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3300         condition.
3301         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3302         Remove condition.
3303         * tui/tui-source.c (tui_source_window_base::reset): New method.
3304         * tui/tui-layout.c (make_command_window): Don't call
3305         init_and_make_win.
3306         (make_source_window, make_disasm_window): Don't call
3307         make_source_or_disasm_window.
3308         (make_data_window): Don't call init_and_make_win.  Change calling
3309         convention.
3310         (show_source_disasm_command, show_data): Simplify.
3311         (make_source_or_disasm_window): Remove.
3312         (show_source_or_disasm_and_command): Simplify.
3313         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3314         (struct tui_source_window_base) <reset>: Likewise.
3315         <execution_info>: Remove initializer.
3316         * tui/tui-data.c (tui_source_window_base): Initialize
3317         execution_info.
3318
3319 2019-07-17  Tom Tromey  <tom@tromey.com>
3320
3321         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3322         variable.
3323
3324 2019-07-17  Tom Tromey  <tom@tromey.com>
3325
3326         * tui/tui.c (tui_rl_other_window): Update.
3327         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3328         superclass method first.  Always iterate over regs_content.
3329         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3330         method.
3331         * tui/tui-win.c (tui_set_focus_command): Update.
3332
3333 2019-07-17  Tom Tromey  <tom@tromey.com>
3334
3335         * tui/tui-win.c (tui_set_focus_command): Rename from
3336         tui_set_focus.  Call tui_enable.
3337         (tui_set_focus_command): Remove.
3338
3339 2019-07-17  Tom Tromey  <tom@tromey.com>
3340
3341         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3342         refresh_window.
3343         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3344         touchwin.
3345         (tui_data_window::refresh_window): Call refresh_window on data
3346         items.  Always call superclass refresh_window.
3347         (tui_win_info::refresh): Remove.
3348         (tui_source_window_base::refresh_window): Update.
3349         (tui_refresh_all): Update.
3350         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3351         refresh_window.
3352         (show_source_or_disasm_and_command): Likewise.
3353         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3354         (struct tui_source_window_base) <refresh>: Likewise.
3355
3356 2019-07-17  Tom Tromey  <tom@tromey.com>
3357
3358         * tui/tui-winsource.c (tui_clear_source_content)
3359         (tui_show_source_content): Update.
3360         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3361         whether content is empty.
3362         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3363         Remove.
3364
3365 2019-07-17  Tom Tromey  <tom@tromey.com>
3366
3367         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3368         window's contents.
3369         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3370         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3371
3372 2019-07-17  Tom Tromey  <tom@tromey.com>
3373
3374         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3375         (struct tui_data_item_window): Update.
3376
3377 2019-07-17  Tom Tromey  <tom@tromey.com>
3378
3379         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3380         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3381         defines.
3382
3383 2019-07-17  Tom Tromey  <tom@tromey.com>
3384
3385         * tui/tui-winsource.h (tui_erase_source_content)
3386         (tui_clear_source_content): Remove "display_prompt" parameter.
3387         * tui/tui-winsource.c (tui_update_source_window_as_is)
3388         (tui_update_source_windows_with_addr): Update.
3389         (tui_clear_source_content): Remove "display_prompt" parameter.
3390         (tui_erase_source_content): Likewise.  Simplify.
3391         (tui_show_source_content): Update.
3392         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3393         * tui/tui-stack.c (tui_show_frame_info): Update.
3394         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3395         Remove defines.
3396
3397 2019-07-17  Tom Tromey  <tom@tromey.com>
3398
3399         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3400         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3401         parameter.
3402         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3403         parameter.
3404
3405 2019-07-17  Tom Tromey  <tom@tromey.com>
3406
3407         * tui/tui-winsource.c (tui_clear_source_content)
3408         (tui_show_source_content, tui_show_exec_info_content)
3409         (tui_clear_exec_info_content): Update.
3410         * tui/tui-stack.c (tui_show_locator_content): Update.
3411         (tui_show_frame_info): Update.
3412         * tui/tui-source.h (tui_source_window): Don't declare.
3413         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3414         from tui_source_is_displayed.
3415         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3416         Remove field.
3417         (struct tui_source_window_base) <content_in_use>: New field.  Now
3418         bool.
3419         (struct tui_source_window) <showing_source_p>: New method.
3420         (TUI_SRC_WIN): Change cast.
3421         * tui/tui-data.c (tui_initialize_static_data): Update.
3422
3423 2019-07-17  Tom Tromey  <tom@tromey.com>
3424
3425         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3426         location_matches_p.
3427         * tui/tui-source.c (tui_source_window::location_matches_p): New
3428         method.
3429         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3430         method.
3431         * tui/tui-data.h (struct tui_source_window_base)
3432         <location_matches_p>: New method.
3433         (struct tui_source_window, struct tui_disasm_window)
3434         <location_matches_p>: Likewise.
3435
3436 2019-07-17  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui-win.c (tui_set_win_height_command): Rename from
3439         tui_set_win_height.
3440         (tui_set_win_height_command): Remove.
3441
3442 2019-07-17  Tom Tromey  <tom@tromey.com>
3443
3444         * tui/tui-source.c (tui_source_window): New constructor.  Add
3445         observer.
3446         (~tui_source_window): New destructor.
3447         (tui_source_window::style_changed): New method.
3448         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3449         (tui_attach_detach_observers): Update.
3450         * tui/tui-data.h (struct tui_source_window): Make constructor not
3451         inline.  Add destructor.
3452         (struct tui_source_window) <style_changed>: New method.
3453         <m_observable>: New member.
3454
3455 2019-07-17  Tom Tromey  <tom@tromey.com>
3456
3457         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3458         * tui/tui-win.c (tui_resize_all): Fix typo.
3459
3460 2019-07-17  Tom Tromey  <tom@tromey.com>
3461
3462         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3463         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3464         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3465         * tui/tui-win.c (window_name_completer): Use foreach.
3466         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3467         (update_tab_width): Likewise.
3468         * tui/tui-layout.c (show_layout): Update.
3469         * tui/tui-data.h (class tui_window_iterator): New.
3470         (struct all_tui_windows): New.
3471         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3472
3473 2019-07-17  Tom Tromey  <tom@tromey.com>
3474
3475         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3476         parameter.  Don't reference globals.
3477         (tui_reg_command): Update.
3478
3479 2019-07-17  Tom Tromey  <tom@tromey.com>
3480
3481         * tui/tui-regs.c (tui_show_registers): Simplify.
3482
3483 2019-07-17  Tom Tromey  <tom@tromey.com>
3484
3485         * tui/tui-regs.c (tui_show_registers): Update.
3486         (tui_show_register_group): Add win_info parameter.
3487
3488 2019-07-17  Tom Tromey  <tom@tromey.com>
3489
3490         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3491         Rename from tui_display_reg_element_at_line.
3492         (tui_data_window::display_registers_from_line): Update.
3493         * tui/tui-data.h (struct tui_data_window)
3494         <display_reg_element_at_line>: New method.
3495
3496 2019-07-17  Tom Tromey  <tom@tromey.com>
3497
3498         * tui/tui-regs.h (tui_display_registers_from)
3499         (tui_display_registers_from_line): Don't declare.
3500         * tui/tui-windata.c (tui_data_window::display_all_data)
3501         (tui_data_window::refresh_all)
3502         (tui_data_window::do_scroll_vertical): Update.
3503         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3504         from tui_display_registers_from.
3505         (tui_display_reg_element_at_line): Update.
3506         (tui_data_window::display_registers_from_line): Rename from
3507         tui_display_registers_from_line.
3508         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3509         display_registers_from_line>: New methods.
3510
3511 2019-07-17  Tom Tromey  <tom@tromey.com>
3512
3513         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3514         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3515         from tui_erase_data_content.
3516         (tui_data_window::display_all_data)
3517         (tui_data_window::refresh_all)
3518         (tui_data_window::do_scroll_vertical): Update.
3519         * tui/tui-regs.c (tui_show_registers): Update.
3520         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3521         New method.
3522
3523 2019-07-17  Tom Tromey  <tom@tromey.com>
3524
3525         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3526         declare.
3527         * tui/tui-windata.c
3528         (tui_data_window::delete_data_content_windows): Rename from
3529         tui_delete_data_content_windows.
3530         (tui_data_window::display_all_data)
3531         (tui_data_window::do_scroll_vertical): Update.
3532         * tui/tui-data.h (struct tui_data_window)
3533         <delete_data_content_windows>: New method.
3534
3535 2019-07-17  Tom Tromey  <tom@tromey.com>
3536
3537         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3538         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3539
3540 2019-07-17  Tom Tromey  <tom@tromey.com>
3541
3542         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3543         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3544         from tui_display_all_data.
3545         * tui/tui-win.c
3546         (tui_data_window::do_make_visible_with_new_height): Update.
3547         * tui/tui-regs.c (tui_show_registers): Update.
3548         * tui/tui-layout.c (tui_set_layout): Update.
3549         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3550         method.
3551
3552 2019-07-17  Tom Tromey  <tom@tromey.com>
3553
3554         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3555         * tui/tui-windata.c (tui_display_data_from): Remove.
3556         (tui_data_window::refresh_all): Update.
3557
3558 2019-07-17  Tom Tromey  <tom@tromey.com>
3559
3560         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3561         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3562         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3563         tui_display_registers_from_line.
3564         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3565         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3566         "force_display" parameter.
3567
3568 2019-07-17  Tom Tromey  <tom@tromey.com>
3569
3570         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3571         declare.
3572         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3573         Rename from tui_first_reg_element_no_inline.
3574         (tui_display_reg_element_at_line)
3575         (tui_display_registers_from_line): Update.
3576         * tui/tui-data.h (struct tui_data_window)
3577         <first_reg_element_no_inline>: New method.
3578
3579 2019-07-17  Tom Tromey  <tom@tromey.com>
3580
3581         * tui/tui-windata.c (tui_display_data_from)
3582         (tui_data_window::do_scroll_vertical): Update.
3583         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3584         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3585         Rename from tui_line_from_reg_element_no.
3586         (tui_display_registers_from_line): Update.
3587         * tui/tui-data.h (struct tui_data_window)
3588         <line_from_reg_element_no>: New method.
3589
3590 2019-07-17  Tom Tromey  <tom@tromey.com>
3591
3592         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3593         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3594         tui_last_regs_line_no.
3595         (tui_display_reg_element_at_line)
3596         (tui_display_registers_from_line): Update.
3597         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3598         method.
3599
3600 2019-07-17  Tom Tromey  <tom@tromey.com>
3601
3602         PR tui/24722:
3603         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3604         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3605         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3606         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3607         (tui_update_breakpoint_info): Likewise.
3608         * tui/tui-hooks.c (tui_event_create_breakpoint)
3609         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3610         Update.
3611
3612 2019-07-17  Tom Tromey  <tom@tromey.com>
3613
3614         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3615
3616 2019-07-17  Tom Tromey  <tom@tromey.com>
3617
3618         * tui/tui-winsource.c (tui_update_source_window_as_is)
3619         (tui_update_source_windows_with_addr): Update.
3620         * tui/tui-source.h (tui_set_source_content)
3621         (tui_show_symtab_source): Add "win_info" parameter.
3622         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3623         parameter.
3624         (tui_show_symtab_source): Likewise.
3625
3626 2019-07-17  Tom Tromey  <tom@tromey.com>
3627
3628         * tui/tui-wingeneral.c
3629         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3630
3631 2019-07-17  Tom Tromey  <tom@tromey.com>
3632
3633         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3634         (struct tui_cmd_window) <can_scroll>: New method.
3635         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3636         method.
3637
3638 2019-07-17  Tom Tromey  <tromey@adacore.com>
3639
3640         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3641         do_field_signed>: Rename.  Change type of "value".
3642         * ui-out.c (ui_out::field_signed): Rename from field_int.
3643         Change type of "value".
3644         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3645         type of "value".
3646         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3647         do_field_int.  Change type of "value".
3648         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3649         do_field_int.  Change type of "value".
3650         * tracepoint.c (trace_status_mi, tfind_1)
3651         (print_one_static_tracepoint_marker): Update.
3652         * thread.c (print_thread_info_1, print_selected_thread_frame):
3653         Update.
3654         * stack.c (print_frame, print_frame_info): Update.
3655         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3656         Update.
3657         * source.c (print_source_lines_base): Update.
3658         * skip.c (info_skip_command): Update.
3659         * record-btrace.c (btrace_ui_out_decode_error)
3660         (btrace_call_history_src_line): Update.
3661         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3662         Update.
3663         * progspace.c (print_program_space): Update.
3664         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3665         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3666         do_field_int.  Change type of "value".
3667         * mi/mi-out.c (mi_ui_out::do_table_begin)
3668         (mi_ui_out::do_table_header): Update.
3669         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3670         type of "value".
3671         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3672         (mi_cmd_data_list_changed_registers, output_register)
3673         (mi_cmd_data_read_memory, mi_load_progress)
3674         (mi_cmd_trace_frame_collected): Update.
3675         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3676         Update.
3677         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3678         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3679         (mi_cmd_var_list_children, varobj_update_one): Update.
3680         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3681         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3682         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3683         * inferior.c (print_inferior): Update.
3684         * gdb_bfd.c (print_one_bfd): Update.
3685         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3686         Update.
3687         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3688         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3689         do_field_int.  Change type of "value".
3690         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3691         do_field_int.  Change type of "value".
3692         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3693         (print_one_breakpoint_location, print_it_catch_fork)
3694         (print_one_catch_fork, print_it_catch_vfork)
3695         (print_one_catch_vfork, print_it_catch_solib)
3696         (print_it_catch_exec, print_it_ranged_breakpoint)
3697         (print_mention_watchpoint, print_mention_masked_watchpoint)
3698         (bkpt_print_it, update_static_tracepoint): Update.
3699         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3700         * break-catch-syscall.c (print_it_catch_syscall): Update.
3701         * ada-tasks.c (print_ada_task_info): Update.
3702         * ada-lang.c (print_it_exception, print_mention_exception):
3703         Update.
3704
3705 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3706
3707         PR breakpoints/24541
3708         * gdbarch.c: Regenerate.
3709         * gdbarch.h: Regenerate.
3710         * gdbarch.sh: Adjust return type and parameter types for
3711         'stap_adjust_register'.
3712         (i386_stap_adjust_register): Adjust signature and return new
3713         register name.
3714         * stap-probe.c (stap_parse_register_operand): Adjust use of
3715         'gdbarch_stap_adjust_register'.
3716
3717 2019-07-17  Tom Tromey  <tromey@adacore.com>
3718
3719         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3720         declare VEC.
3721         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3722         std::vector.
3723         (struct s390_process_info): Add initializers.
3724         (s390_add_process): Use new.
3725         (s390_linux_nat_target::low_forget_process): Use delete.
3726         (s390_linux_nat_target::low_new_fork)
3727         (s390_linux_nat_target::stopped_by_watchpoint)
3728         (s390_linux_nat_target::low_prepare_to_resume)
3729         (s390_linux_nat_target::insert_watchpoint)
3730         (s390_linux_nat_target::insert_hw_breakpoint)
3731         (s390_linux_nat_target::remove_watchpoint)
3732         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3733
3734 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3735
3736         * aarch64-fbsd-nat.c: Include regcache.h.
3737         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3738         argument.
3739         (aarch64_fbsd_nat_target::fetch_registers)
3740         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3741         variable.
3742         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3743
3744 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3745
3746         * fbsd-nat.c: Include gdbarch.h.
3747
3748 2019-07-15  Tom Tromey  <tromey@adacore.com>
3749
3750         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3751
3752 2019-07-15  Tom Tromey  <tromey@adacore.com>
3753
3754         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3755         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3756         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3757         * cli-out.c (cli_ui_out::do_field_int): New method.
3758         * ui-out.c (ui_out::field_unsigned): New method.
3759         * symfile.c (generic_load): Use field_unsigned.
3760         (print_transfer_performance): Likewise.
3761         * record-btrace.c (ui_out_field_uint): Remove.
3762         (btrace_call_history_insn_range, btrace_call_history): Use
3763         field_unsigned.
3764         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3765         field_unsigned.
3766         * ui-out.h (class ui_out) <field_unsigned>: New method.
3767         <do_field_unsigned>: Likewise.
3768
3769 2019-07-15  Tom Tromey  <tromey@adacore.com>
3770
3771         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3772         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3773         * target.c (flash_erase_command): Use field_string.
3774         * infrun.c (print_signal_received_reason): Use field_string.
3775         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3776         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3777         field_string.
3778         * ada-tasks.c (print_ada_task_info): Use field_string.
3779
3780 2019-07-15  Tom Tromey  <tromey@adacore.com>
3781
3782         * target.c (flash_erase_command): Use field_core_addr.
3783         * symfile.c (generic_load): Use field_core_addr.
3784         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3785         Use field_core_addr.
3786         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3787         field_core_addr.
3788
3789 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3790
3791         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3792         value if its desired type is smaller than a CORE_ADDR and signed.
3793
3794 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3795
3796         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3797         of changes to field names, and use new is_reference field to
3798         decide if a property is a reference or not.
3799         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3800         field.
3801         (struct dwarf2_property_baton): Update header comment, rename
3802         'referenced_type' to 'property_type' and update comments.
3803         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3804         default property type, store in property baton, update to take
3805         accound of renamed field.
3806         (read_func_scope): Update call to attr_to_dynamic_prop.
3807         (read_array_type): Likewise.
3808         (dwarf2_per_cu_addr_sized_int_type): New function.
3809         (read_subrange_index_type): Move type finding code to
3810         dwarf2_per_cu_addr_sized_int_type.
3811         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3812         (dwarf2_per_cu_addr_type): New function.
3813         (set_die_type): Update calls to attr_to_dynamic_prop.
3814
3815 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3816
3817         * dwarf2read.c (read_subrange_index_type): New function.
3818         (read_subrange_type): Move code into new function and call it.
3819         * gdbtypes.c (create_range_type): Add some asserts.
3820
3821 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3822
3823         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3824         update return statements.
3825         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3826         declaration, and update comment to match.
3827         * gdbtypes.c (resolve_dynamic_array): Update call to
3828         dwarf2_evaluate_property to match new return type.
3829
3830 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * valarith.c (value_subscripted_rvalue): Change lowerbound
3833         parameter type from int to LONGEST.
3834         * value.h (value_subscripted_rvalue): Likewise in declaration.
3835
3836 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3837
3838         * cli/cli-utils.c (info_print_command_completer): New function.
3839         * cli/cli-utils.h: Add 'completer.h' include, and forward
3840         declaration for 'struct cmd_list_element'.
3841         (info_print_command_completer): Declare.
3842         * stack.c (_initialize_stack): Add completer for 'info locals' and
3843         'info args'.
3844         * symtab.c (_initialize_symtab): Add completer for 'info
3845         variables' and 'info functions'.
3846         * NEWS: Mention completion for additional info commands.
3847
3848 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3849
3850         * cli/cli-utils.c (extract_info_print_args): Delete.
3851         (extract_arg_maybe_quoted): Delete.
3852         (info_print_options_defs): New variable.
3853         (make_info_print_options_def_group): New function.
3854         (extract_info_print_options): Define new function.
3855         * cli/cli-utils.h (extract_info_print_args): Delete.
3856         (struct info_print_options): New structure.
3857         (extract_info_print_options): Declare new function.
3858         * stack.c (info_locals_command): Update to use new
3859         extract_info_print_options, also add a header comment.
3860         (info_args_command): Likewise.
3861         * symtab.c (info_variables_command): Likewise.
3862         (info_functions_command): Likewise.
3863
3864 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3865
3866         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3867         to extract string arguments.
3868         * common/common-utils.c (extract_string_maybe_quoted): New function.
3869         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3870
3871 2019-07-11  Tom Tromey  <tromey@adacore.com>
3872
3873         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3874         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3875         * top.h (gdbinit): Don't declare.
3876         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3877         into...
3878         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3879         * top.c (gdb_init): Don't call init_cli_cmds.
3880         (gdbinit): Remove.
3881         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3882
3883 2019-07-11  Tom Tromey  <tromey@adacore.com>
3884
3885         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3886         after it has been moved.
3887
3888 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3889
3890         * valops.c (value_must_coerce_to_target): Change return type to
3891         bool.
3892         * value.h (value_must_coerce_to_target): Likewise.
3893
3894 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3895
3896         * breakpoint.c (is_hardware_watchpoint): Remove
3897         forward-declaration.
3898         (is_masked_watchpoint): Change return type to bool.
3899         (is_tracepoint): Likewise.
3900         (is_breakpoint): Likewise.
3901         (is_hardware_watchpoint): Likewise.
3902         (is_watchpoint): Likewise.
3903         (is_no_memory_software_watchpoint): Likewise.
3904         (is_catchpoint): Likewise.
3905         (breakpoint_1): Make FILTER parameter's return type bool.
3906         is_masked_watchpoint): Change return type to bool.
3907         (save_breakpoints): Make FILTER parameter's return type bool.
3908         * breakpoint.h (is_breakpoint): Change return type to bool.
3909         (is_watchpoint): Likewise.
3910         (is_catchpoint): Likewise.
3911         (is_tracepoint): Likewise.
3912
3913 2019-07-10  Tom Tromey  <tom@tromey.com>
3914
3915         * defs.h: Don't include gdbarch.h.
3916         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3917         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3918         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3919         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3920         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3921         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3922         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3923         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3924         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3925         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3926         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3927         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3928         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3929         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3930         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3931         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3932         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3933         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3934         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3935         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3936         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3937         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3938         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3939         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3940         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3941         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3942         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3943
3944 2019-07-10  Tom Tromey  <tromey@adacore.com>
3945
3946         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3947         * breakpoint.c (init_ada_exception_breakpoint): Register as
3948         bp_catchpoint.
3949         (print_one_breakpoint_location, print_one_breakpoint): Use
3950         is_ada_exception_catchpoint.
3951         * ada-lang.c (class ada_catchpoint_location): Pass
3952         bp_loc_software_breakpoint to bp_location constructor.
3953         (is_ada_exception_catchpoint): New function.
3954
3955 2019-07-10  Tom Tromey  <tromey@adacore.com>
3956
3957         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3958         VEC.
3959         (struct arm_exidx_entry): New method operator<.
3960         (struct arm_exidx_data) <section_maps>: Change type.
3961         (arm_exidx_data_free): Remove.
3962         (arm_exidx_data_key): Change type.  Move lower.
3963         (arm_exidx_new_objfile): Update.
3964         (arm_compare_exidx_entries): Remove.
3965         (arm_find_exidx_entry, _initialize_arm_tdep)
3966
3967 2019-07-10  Tom Tromey  <tromey@adacore.com>
3968
3969         * solib-spu.c (ocl_program_data_key): Change type.
3970         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3971         Update.
3972
3973 2019-07-10  Tom Tromey  <tromey@adacore.com>
3974
3975         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3976         (struct solib_aix_inferior_data) <library_list>: Change type.
3977         (solib_aix_inferior_data_handle): Change type.
3978         (get_solib_aix_inferior_data): Update.
3979         (solib_aix_free_library_list): Remove.
3980         (library_list_start_library): Update.
3981         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3982         return type.
3983         (solib_aix_get_library_list)
3984         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3985         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3986
3987 2019-07-10  Tom Tromey  <tromey@adacore.com>
3988
3989         * solib-dsbt.c (struct dsbt_info): Add initializers.
3990         (solib_dsbt_pspace_data): Change type.
3991         (dsbt_pspace_data_cleanup): Remove.
3992         (get_dsbt_info, _initialize_dsbt_solib): Update.
3993
3994 2019-07-10  Tom Tromey  <tromey@adacore.com>
3995
3996         * spu-tdep.c (spu_overlay_data): Change type.
3997         (spu_get_overlay_table, spu_overlay_new_objfile)
3998         (_initialize_spu_tdep): Update.
3999
4000 2019-07-10  Tom Tromey  <tromey@adacore.com>
4001
4002         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4003         destructor.
4004         (dbx_objfile_data_key): Change type and declare later.
4005         (DBX_SYMFILE_INFO): Rewrite.
4006         * dbxread.c (dbx_objfile_data_key): Change type.
4007         (dbx_symfile_init): Update.
4008         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4009         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4010         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4011
4012 2019-07-10  Tom Tromey  <tromey@adacore.com>
4013
4014         * jit.c (jit_program_space_key): Change type.  Move lower.
4015         (get_jit_program_space_data): Update.
4016         (jit_program_space_data_cleanup): Remove.
4017         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4018         Update.
4019         (struct jit_program_space_data): Add initializers.
4020
4021 2019-07-10  Tom Tromey  <tromey@adacore.com>
4022
4023         * solib-darwin.c (struct darwin_info): Add initializers.
4024         (solib_darwin_pspace_data): Change type.
4025         (darwin_pspace_data_cleanup): Remove.
4026         (get_darwin_info, _initialize_darwin_solib): Update.
4027
4028 2019-07-10  Tom Tromey  <tromey@adacore.com>
4029
4030         * remote-sim.c (struct sim_inferior_data): Add initializers,
4031         constructor, and destructor.
4032         (sim_inferior_data_key): Change type.  Move lower.
4033         (check_for_duplicate_sim_descriptor): Update.
4034         (get_sim_inferior_data): Use new.  Update.
4035         (~sim_inferior_data_cleanup): Rename from
4036         sim_inferior_data_cleanup.  Simplify.
4037         (gdbsim_close_inferior, simulator_command)
4038         (sim_command_completer, _initialize_remote_sim): Update.
4039         (next_pid, INITIAL_PID): Move earlier.
4040
4041 2019-07-10  Tom Tromey  <tromey@adacore.com>
4042
4043         * python/python-internal.h (create_thread_object): Return
4044         gdbpy_ref.
4045         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4046         * python/py-inferior.c (struct threadlist_entry): Add
4047         constructor.
4048         <thread_obj>: Now a gdbpy_ref.
4049         (thread_to_thread_object): Update.
4050         (add_thread_object): Use new.
4051         (delete_thread_object): Use delete.
4052         (infpy_threads): Update.
4053         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4054         GIL.
4055
4056 2019-07-10  Tom Tromey  <tromey@adacore.com>
4057
4058         * valops.c (value_cast): Specialize error message for Ada.
4059
4060 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4061
4062         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4063
4064 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4065
4066         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4067         bpstat_should_step): Return bool, adjust comments.
4068         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4069         bpstat_should_step): Likewise.
4070
4071 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4072
4073         * features/Makefile: Use feature target descriptions for Arm.
4074         * features/arm/arm-core.c: Generate new file.
4075         * features/arm/arm-fpa.c: Likewise.
4076         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4077         * features/arm/arm-m-profile.c: Likewise.
4078         * features/arm/arm-vfpv2.c: Likewise.
4079         * features/arm/arm-vfpv3.c: Likewise.
4080         * features/arm/xscale-iwmmxt.c: Likewise.
4081         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4082
4083 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4084
4085         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4086         ptrace earlier.
4087
4088 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4089
4090         * features/aarch64-pauth.c: Regenerate.
4091
4092 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4093
4094         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4095         bool.
4096         (bpstat_what): Use false instead of 0.
4097
4098 2019-07-09  Pedro Alves  <palves@redhat.com>
4099
4100         * break-catch-throw.c (is_exception_catchpoint): New.
4101         * breakpoint.c (print_one_breakpoint_location): New parameter
4102         'raw_loc'.  Handle it.  Use
4103         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4104         looking at the breakpoint's type.
4105         (print_one_breakpoint): If handling "maint info breakpoints", also
4106         print locations of exception catchpoints.
4107         * breakpoint.h (is_exception_catchpoint): Declare.
4108
4109 2019-07-09  Pedro Alves  <palves@redhat.com>
4110
4111         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4112         "addr" field.
4113         (allocate_location_exception_catchpoint): New.
4114         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4115         (initialize_throw_catchpoint_ops): Install
4116         allocate_location_exception_catchpoint as allocate_location
4117         method.
4118         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4119         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4120         bp_loc_other.
4121         (breakpoint_address_is_meaningful): Delete.
4122         (bl_address_is_meaningful): New.
4123         (breakpoint_locations_match): Adjust comment.
4124         (bp_location_from_bp_type): New, factored out of...
4125         (bp_location::bp_location(breakpoint *)): ... this.
4126         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4127         factored out of...
4128         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4129         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4130         breakpoint_address_is_meaningful.
4131         (bp_locations_compare): Adjust comment.
4132         (update_global_location_list): Use bl_address_is_meaningful
4133         instead of breakpoint_address_is_meaningful.
4134         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4135         explicit.
4136         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4137         * python/py-breakpoint.c (bppy_get_location): No longer check
4138         whether location is null.
4139
4140 2019-07-09  Pedro Alves  <palves@redhat.com>
4141
4142         PR c++/15468
4143         * breakpoint.c (print_one_breakpoint_location): Remove
4144         single-location assert.
4145
4146 2019-07-09  Tom Tromey  <tom@tromey.com>
4147
4148         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4149         * configure: Rebuild.
4150         * configure.ac: Change common to gdbsupport.
4151         * gdbsupport: Rename from common.
4152         * acinclude.m4: Change common to gdbsupport.
4153         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4154         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4155         gdbsupport.
4156         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4157         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4158         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4159         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4160         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4161         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4162         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4163         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4164         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4165         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4166         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4167         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4168         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4169         coff-pe-read.c, command.h, compile/compile-c-support.c,
4170         compile/compile-c.h, compile/compile-cplus-symbols.c,
4171         compile/compile-cplus-types.c, compile/compile-cplus.h,
4172         compile/compile-loc2c.c, compile/compile.c, completer.c,
4173         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4174         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4175         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4176         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4177         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4178         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4179         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4180         features/aarch64-core.c, features/aarch64-fpu.c,
4181         features/aarch64-pauth.c, features/aarch64-sve.c,
4182         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4183         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4184         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4185         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4186         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4187         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4188         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4189         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4190         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4191         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4192         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4193         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4194         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4195         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4196         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4197         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4198         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4199         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4200         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4201         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4202         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4203         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4204         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4205         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4206         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4207         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4208         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4209         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4210         minsyms.c, mips-linux-tdep.c, namespace.h,
4211         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4212         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4213         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4214         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4215         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4216         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4217         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4218         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4219         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4220         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4221         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4222         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4223         procfs.c, producer.c, progspace.h, psymtab.h,
4224         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4225         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4226         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4227         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4228         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4229         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4230         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4231         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4232         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4233         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4234         target-memory.c, target.c, target.h, target/waitstatus.c,
4235         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4236         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4237         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4238         unittests/array-view-selftests.c,
4239         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4240         unittests/common-utils-selftests.c,
4241         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4242         unittests/format_pieces-selftests.c,
4243         unittests/function-view-selftests.c,
4244         unittests/lookup_name_info-selftests.c,
4245         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4246         unittests/mkdir-recursive-selftests.c,
4247         unittests/observable-selftests.c,
4248         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4249         unittests/parse-connection-spec-selftests.c,
4250         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4251         unittests/scoped_fd-selftests.c,
4252         unittests/scoped_mmap-selftests.c,
4253         unittests/scoped_restore-selftests.c,
4254         unittests/string_view-selftests.c, unittests/style-selftests.c,
4255         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4256         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4257         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4258         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4259         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4260         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4261
4262 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4263
4264         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4265         bool value.
4266         (decode_digits_ordinary): Set explicit_line field in sal.
4267         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4268         symtab_and_line that was set on an explicit line number in
4269         assembler code.  Do always update the recorded symtab and line if
4270         we do skip the prologue.
4271
4272 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4273
4274         * breakpoint.c (set_breakpoint_location_function): Remove
4275         explicit_loc parameter.
4276         (momentary_breakpoint_from_master): Update call to
4277         set_breakpoint_location_function.
4278         (add_location_to_breakpoint): Likewise.
4279
4280 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4281
4282         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4283         required features based on default bfd type when no specific bfd
4284         is present.
4285
4286 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4287
4288         * NEWS: Mention that GDB printf and eval commands can now print
4289         C-style and Ada-style convenience var strings without
4290         calling the inferior.
4291         * printcmd.c (printf_c_string): Locally print GDB internal var
4292         instead of transiting via the inferior.
4293         (printf_wide_c_string): Likewise.
4294
4295 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4296
4297         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4298
4299 2019-07-04  Tom Tromey  <tom@tromey.com>
4300
4301         PR tui/24724:
4302         * tui/tui-winsource.c (tui_clear_source_content): Update.
4303         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4304         (tui_update_breakpoint_info): Update.
4305         (tui_set_exec_info_content): Update.
4306         * tui/tui-source.c (tui_set_source_content_nil): Update.
4307         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4308         has_break.
4309         * tui/tui-data.h (enum tui_bp_flag): New.
4310         (tui_bp_flags): New enum flags type.
4311         (struct tui_source_element) <break_mode>: Change type.  Rename
4312         from has_break.
4313         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4314         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4315         constants.
4316         * tui/tui-winsource.h: Fix comment.
4317
4318 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4319
4320         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4321         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4322         (store_fpregs_to_thread)
4323         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4324         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4325         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4326         (IWMMXT_REGS_SIZE): Add define.
4327         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4328         (fetch_vfp_regs, store_vfp_regs)
4329         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4330         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4331
4332 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4333
4334         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4335         defines.
4336         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4337         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4338         (ARM_INT_REGISTER_SIZE): ...to this.
4339         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4340         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4341         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4342         (arm_linux_collect_gregset, supply_nwfpe_register)
4343         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4344         defines.
4345         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4346         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4347         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4348         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4349         (arm_return_in_memory, arm_store_return_value)
4350         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4351         (arm_record_ld_st_multiple): Likewise.
4352         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4353         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4354
4355 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4356
4357         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4358         AARCH64_DISPLACED_MODIFIED_INSNS.
4359         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4360         (aarch64_displaced_step_copy_insn): Likewise.
4361         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4362         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4363         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4364         ARM_DISPLACED_MODIFIED_INSNS.
4365         * arm-tdep.c (arm_gdbarch_init): Likewise.
4366         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4367         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4368         (struct arm_displaced_step_closure): Use
4369         ARM_DISPLACED_MODIFIED_INSNS.
4370
4371 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4372
4373         * features/Makefile: Remove unused xml files.
4374         * features/aarch64.xml: Remove.
4375         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4376         * features/i386/amd64-avx-avx512.xml: Remove.
4377         * features/i386/amd64-avx-linux.xml: Remove.
4378         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4379         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4380         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4381         * features/i386/amd64-avx-mpx.xml: Remove.
4382         * features/i386/amd64-avx.xml: Remove.
4383         * features/i386/amd64-linux.xml: Remove.
4384         * features/i386/amd64-mpx-linux.xml: Remove.
4385         * features/i386/amd64-mpx.xml: Remove.
4386         * features/i386/amd64.xml: Remove.
4387         * features/i386/i386-avx-avx512-linux.xml: Remove.
4388         * features/i386/i386-avx-avx512.xml: Remove.
4389         * features/i386/i386-avx-linux.xml: Remove.
4390         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4391         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4392         * features/i386/i386-avx-mpx-linux.xml: Remove.
4393         * features/i386/i386-avx-mpx.xml: Remove.
4394         * features/i386/i386-avx.xml: Remove.
4395         * features/i386/i386-linux.xml: Remove.
4396         * features/i386/i386-mmx-linux.xml: Remove.
4397         * features/i386/i386-mmx.xml: Remove.
4398         * features/i386/i386-mpx-linux.xml: Remove.
4399         * features/i386/i386-mpx.xml: Remove.
4400         * features/i386/i386.xml: Remove.
4401         * features/i386/x32-avx-avx512-linux.xml: Remove.
4402         * features/i386/x32-avx-linux.xml: Remove.
4403         * features/i386/x32-linux.xml: Remove.
4404
4405 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4406
4407         * regformats/aarch64.dat: Remove.
4408         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4409         * regformats/i386/amd64-avx-linux.dat: Remove.
4410         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4411         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4412         * regformats/i386/amd64-linux.dat: Remove.
4413         * regformats/i386/amd64-mpx-linux.dat: Remove.
4414         * regformats/i386/amd64.dat: Remove.
4415         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4416         * regformats/i386/i386-avx-linux.dat: Remove.
4417         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4418         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4419         * regformats/i386/i386-linux.dat: Remove.
4420         * regformats/i386/i386-mmx-linux.dat: Remove.
4421         * regformats/i386/i386-mpx-linux.dat: Remove.
4422         * regformats/i386/i386.dat: Remove.
4423         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4424         * regformats/i386/x32-avx-linux.dat: Remove.
4425         * regformats/i386/x32-linux.dat: Remove.
4426
4427 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4428
4429         * aarch64-tdep.c: Remove xml self tests.
4430         * amd64-linux-tdep.c: Likewise.
4431         * amd64-tdep.c: Likewise.
4432         * i386-linux-tdep.c: Likewise.
4433         * i386-tdep.c: Likewise.
4434
4435 2019-07-03  Pedro Alves  <palves@redhat.com>
4436
4437         PR cli/24732
4438         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4439         (pipe_cmd_option_defs): New.
4440         (make_pipe_cmd_options_def_group): New.
4441         (pipe_command): Use gdb::option::process_options.
4442         (pipe_command_completer): New function.
4443         (_initialize_cli_cmds): Install completer for "pipe" command.
4444
4445 2019-07-03  Pedro Alves  <palves@redhat.com>
4446
4447         * cli/cli-option.c (union option_value) <string>: New field.
4448         (struct option_def_and_value): Add ctor, move ctor, dtor and
4449         use DISABLE_COPY_AND_ASSIGN.
4450         (option_def_and_value::clear_value): New.
4451         (parse_option, save_option_value_in_ctx, get_val_type_str)
4452         (add_setshow_cmds_for_options): Handle var_string.
4453         * cli-option.h (union option_def::var_address) <string>: New
4454         field.
4455         (struct string_option_def): New.
4456         * maint-test-options.c (struct test_options_opts): Add default
4457         ctor and use DISABLE_COPY_AND_ASSIGN.
4458         <string_opt>: New field.
4459         (test_options_opts::~test_options_opts): New.
4460         (test_options_opts::dump): Also dump "-string".
4461         (test_options_option_defs): Install "string.
4462
4463 2019-07-03  Pedro Alves  <palves@redhat.com>
4464
4465         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4466         option_value with a null enumeration.
4467         (complete_options): Save the option values in the context.
4468         (save_option_value_in_ctx): New, factored out from ...
4469         (process_options): ... here.
4470         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4471         of the function.
4472         * maint-test-options.c (test_options_opts::dump): New, factored
4473         out from ...
4474         (maintenance_test_options_command_mode): ... here.
4475         (maintenance_test_options_command_completion_result): Delete.
4476         (maintenance_test_options_command_completion_text): Update
4477         comment.
4478         (maintenance_show_test_options_completion_result): Change
4479         prototype.  Just print
4480         maintenance_test_options_command_completion_text.
4481         (save_completion_result): New.
4482         (maintenance_test_options_completer_mode): Pass options context to
4483         complete_options, and then save a dump.
4484         (_initialize_maint_test_options): Use add_cmd to install "maint
4485         show test-options-completion-result".
4486
4487 2019-07-03  Pedro Alves  <palves@redhat.com>
4488
4489         * NEWS (New commands): Mention "with" and "maint with".
4490         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4491         (with_command, with_command_completer): New.
4492         (pipe_command): Adjust to new repeat_previous
4493         interface.
4494         (_initialize_cli_cmds): Install the "with" command and its "w"
4495         alias.
4496         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4497         declarations.
4498         * cli/cli-setshow.c (parse_cli_var_uinteger)
4499         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4500         argument strings for all var_types.
4501         (get_setshow_command_value_string): New, factored out from ...
4502         (do_show_command): ... this.
4503         * cli/cli-setshow.h: Include <string>.
4504         (get_setshow_command_value_string): Declare.
4505         * command.h (repeat_previous): Now returns const char *.  Adjust
4506         comment.
4507         * maint.c: Include "cli/cli-cmds.h".
4508         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4509         (_initialize_maint_cmds): Register the "maintenance with" command.
4510         * top.c (repeat_previous): Move bits from pipe_command here:
4511         Return the saved command line, if any; error out if there's no
4512         command to relaunch.
4513
4514 2019-07-03  Pedro Alves  <palves@redhat.com>
4515
4516         * NEWS (New commands): Mention "maint set/show test-settings"
4517         instead of "maint test-settings".
4518         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4519         (maintenance_test_settings_set_list): Rename to ...
4520         (maintenance_set_test_settings_list): ... this.
4521         (maintenance_test_settings_show_list): Rename to  ...
4522         (maintenance_show_test_settings_list): ... this.
4523         (maintenance_test_settings_cmd): Delete.
4524         (maintenance_test_settings_set_cmd): ...
4525         (maintenance_set_test_settings_cmd): ... this.
4526         (maintenance_test_settings_show_cmd): ...
4527         (maintenance_show_test_settings_cmd): ... this.
4528         (maintenance_test_settings_show_value_cmd):
4529         (maintenance_show_test_settings_value_cmd): ... this.
4530         (_initialize_maint_test_settings): No longer install the "maint
4531         test-settings" prefix command.  Rename "maint test-settings set"
4532         to "maint set test-settings", and "maint test-settings show" to
4533         "maint show test-settings".  Adjust all subcommands.
4534
4535 2019-07-03  Pedro Alves  <palves@redhat.com>
4536
4537         * maint-test-settings.c: Fix file's intro comment.  Replace all
4538         references to "test-options" with references to "test-settings",
4539         in comments.
4540
4541 2019-07-03  Pedro Alves  <palves@redhat.com>
4542
4543         * maint-test-settings.c (maintenance_test_settings_xxx)
4544         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4545         New.
4546         (maintenance_test_settings_enums): Use them.
4547         (maintenance_test_settings_enum): Default to
4548         maintenance_test_settings_xxx.
4549         (_initialize_maint_test_settings): Initialize
4550         MAINTENANCE_TEST_SETTINGS_FILENAME.
4551
4552 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4553
4554         * breakpoint.h (remove_breakpoints_inf): Change return type to
4555         void, move function documentation here.
4556         * breakpoint.c (remove_breakpoints_inf): Change return type to
4557         void, move function documentation to header.
4558
4559 2019-07-02  Pedro Alves  <palves@redhat.com>
4560
4561         * NEWS (Completion improvements): Mention "info threads".
4562         * thread.c (struct info_threads_opts, info_threads_option_defs)
4563         (make_info_threads_options_def_group): New.
4564         (info_threads_command): Use gdb::option::process_options.
4565         (info_threads_command_completer): New.
4566         (_initialize_thread): Use gdb::option::build_help to build the
4567         help text for "info threads".
4568
4569 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4570
4571         * defs.h (generic_load): Move from here...
4572         * symfile.h (generic_load): ... to here.  Rename name parameter
4573         to args.
4574         * symfile.c (generic_load): Add comment.
4575
4576 2019-07-01  Tom Tromey  <tromey@adacore.com>
4577
4578         * dwarf2read.c
4579         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4580         declaration of without_params.  Fix formatting.
4581
4582 2019-07-01  Tom Tromey  <tromey@adacore.com>
4583
4584         * ada-exp.y (find_primitive_type): Update.
4585         * ada-lang.h (ada_lookup_symbol): Update.
4586         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4587         parameter.
4588         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4589
4590 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4591
4592         PR breakpoints/24541
4593         * gdbarch.c: Regenerate.
4594         * gdbarch.h: Regenerate.
4595         * gdbarch.sh: Add 'stap_adjust_register'.
4596         * i386-tdep.c: Include '<unordered_set>'.
4597         (i386_stap_adjust_register): New function.
4598         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4599         * stap-probe.c (stap_parse_register_operand): Call
4600         'gdbarch_stap_adjust_register'.
4601
4602 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4603
4604         PR python/24742
4605         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4606         * python/python.c (do_start_initialization): Use 'xmalloc'
4607         instead of 'PyMem_Malloc'.
4608
4609 2019-06-28  Tom Tromey  <tromey@adacore.com>
4610
4611         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4612         for Ada.
4613
4614 2019-06-27  Tom Tromey  <tromey@adacore.com>
4615
4616         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4617         objfile_key.
4618         (arm_find_mapping_symbol, arm_record_special_symbol)
4619         (_initialize_arm_tdep): Update.
4620         (arm_objfile_data_free): Remove.
4621
4622 2019-06-27  Tom Tromey  <tromey@adacore.com>
4623
4624         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4625         to cp_print_static_field.
4626
4627 2019-06-26  Tom Tromey  <tromey@adacore.com>
4628
4629         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4630         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4631         declare.
4632
4633 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4634
4635         * features/aarch64-core.c (create_feature_aarch64_core):
4636         Regenerate.
4637         * features/aarch64-core.xml: Add cpsr flags.
4638
4639 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4640
4641         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4642         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4643
4644 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4645
4646         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4647         field.
4648         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4649         use.
4650         (arm_record_special_symbol): Don't insert new symbol in sorted
4651         position, push it at the end.
4652
4653 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4654
4655         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4656         (arm_mapping_symbol_s): Remove.
4657         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4658         (arm_mapping_symbol_vec): New typedef.
4659         (struct arm_per_objfile): Add constructor.
4660         <section_maps>: Change type to
4661         std::unique_ptr<arm_mapping_symbol_vec[]>.
4662         (arm_compare_mapping_symbols): Remove.
4663         (arm_find_mapping_symbol): Adjust to section_maps type change.
4664         (arm_objfile_data_free): Call delete on arm_per_objfile.
4665         (arm_record_special_symbol): Adjust to section_maps type change.
4666         Allocate arm_per_objfile with new.
4667
4668 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4669
4670         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4671         with the command prefix.
4672
4673 2019-06-25  Tom Tromey  <tom@tromey.com>
4674
4675         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4676         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4677
4678 2019-06-25  Tom Tromey  <tom@tromey.com>
4679
4680         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4681         type.
4682         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4683         protected.
4684
4685 2019-06-25  Tom Tromey  <tom@tromey.com>
4686
4687         * tui/tui-winsource.c
4688         (tui_source_window_base::set_is_exec_point_at): Add check against
4689         LOA_ADDRESS.
4690
4691 2019-06-25  Tom Tromey  <tom@tromey.com>
4692
4693         * tui/tui-source.c (tui_set_source_content): Don't check before
4694         xfree.
4695         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4696
4697 2019-06-25  Tom Tromey  <tom@tromey.com>
4698
4699         * tui/tui-winsource.h (tui_update_source_window_as_is)
4700         (tui_alloc_source_buffer, tui_line_is_displayed)
4701         (tui_addr_is_displayed): Change type of win_info.
4702         * tui/tui-winsource.c (tui_update_source_window_as_is)
4703         (tui_clear_source_content, tui_show_source_line)
4704         (tui_show_source_content, tui_source_window_base::refill)
4705         (tui_source_window_base::set_is_exec_point_at)
4706         (tui_source_window_base::set_is_exec_point_at)
4707         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4708         (tui_alloc_source_buffer, tui_line_is_displayed)
4709         (tui_addr_is_displayed): Change type of win_info.  Update.
4710         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4711         (tui_source_window_base::do_make_visible_with_new_height):
4712         Update.
4713         * tui/tui-source.c (tui_set_source_content)
4714         (tui_set_source_content_nil)
4715         (tui_source_window::do_scroll_vertical): Update.
4716         * tui/tui-layout.c (show_layout): Update.
4717         * tui/tui-disasm.c (tui_set_disassem_content)
4718         (tui_disasm_window::do_scroll_vertical): Update.
4719         * tui/tui-data.h (tui_win_content): Remove.
4720         (struct tui_gen_win_info) <content, content_size>: Remove.
4721         (struct tui_source_element): Add initializers and destructor.
4722         (union tui_which_element, struct tui_win_element): Remove.
4723         (struct tui_source_window_base) <content>: New field.
4724         (struct tui_data_window): Remove destructor.
4725         (tui_alloc_content, tui_free_win_content)
4726         (tui_free_all_source_wins_content): Don't declare.
4727         * tui/tui-data.c (tui_initialize_static_data): Update.
4728         (init_content_element, tui_alloc_content): Remove.
4729         (~tui_gen_win_info): Update.
4730         (~tui_data_window, tui_free_all_source_wins_content)
4731         (tui_free_win_content, free_content, free_content_elements):
4732         Remove.
4733
4734 2019-06-25  Tom Tromey  <tom@tromey.com>
4735
4736         * tui/tui-winsource.h (tui_clear_source_content)
4737         (tui_erase_source_content, tui_show_source_content): Change type
4738         of win_info.
4739         * tui/tui-winsource.c (tui_clear_source_content)
4740         (tui_erase_source_content, tui_show_source_content): Change type
4741         of win_info.
4742         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4743         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4744         win_info.
4745         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4746         win_info.
4747         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4748
4749 2019-06-25  Tom Tromey  <tom@tromey.com>
4750
4751         * tui/tui-winsource.c (tui_clear_source_content)
4752         (tui_source_window_base::set_is_exec_point_at): Update.
4753         * tui/tui-source.c (tui_set_source_content_nil): Update.
4754         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4755         a bool.
4756         * tui/tui-data.c (init_content_element): Update.
4757
4758 2019-06-25  Tom Tromey  <tom@tromey.com>
4759
4760         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4761         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4762         * tui/tui-layout.c (init_and_make_win): Update.
4763         * tui/tui.h (enum tui_win_type): Update.
4764         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4765         tui_win_is_auxillary.
4766         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4767         tui_win_is_auxillary.
4768
4769 2019-06-25  Tom Tromey  <tom@tromey.com>
4770
4771         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4772         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4773         (tui_delete_data_content_windows, tui_display_all_data)
4774         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4775         Update.
4776         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4777         * tui/tui-regs.c (tui_last_regs_line_no)
4778         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4779         (tui_show_registers): Update.
4780         (tui_show_register_group): Return void.  Update.
4781         (tui_display_registers_from, tui_display_reg_element_at_line)
4782         (tui_display_registers_from_line, tui_check_register_values):
4783         Update.
4784         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4785         member.
4786         (struct tui_data_window) <regs_content>: Now a std::vector.
4787         <regs_content_count>: Remove.
4788         (tui_add_content_elements, tui_free_data_content): Don't declare.
4789         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4790         (init_content_element): Remove DATA_WIN case.  Add assert.
4791         (tui_add_content_elements): Remove.
4792         (tui_data_window): Update.
4793         (tui_free_data_content): Remove.
4794         (free_content_elements): Remove DATA_WIN case.
4795
4796 2019-06-25  Tom Tromey  <tom@tromey.com>
4797
4798         * tui/tui-data.c (tui_data_item_window): Update.
4799         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4800         * tui/tui-windata.c (tui_display_all_data)
4801         (tui_display_data_from_line): Update.
4802         (tui_check_data_values): Remove.
4803         * tui/tui-regs.c (tui_show_register_group)
4804         (tui_display_reg_element_at_line): Update.
4805         * tui/tui-hooks.c (tui_register_changed)
4806         (tui_refresh_frame_and_register_information): Call
4807         tui_check_register_values.
4808         * tui/tui-data.h (struct tui_data_window) <data_content,
4809         data_content_count, data_type>: Remove.
4810         (enum tui_data_type): Remove.
4811
4812         * tui/tui-data.c (tui_data_window::clear_detail)
4813         (~tui_data_window): Update.
4814
4815 2019-06-25  Tom Tromey  <tom@tromey.com>
4816
4817         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4818         declare.
4819         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4820         Rename from tui_first_data_item_displayed.  Update.
4821         (tui_data_window::refresh_all)
4822         (tui_data_window::do_scroll_vertical): Update.
4823         * tui/tui-data.h (struct tui_data_window)
4824         <first_data_item_displayed>: Declare new method.
4825
4826 2019-06-25  Tom Tromey  <tom@tromey.com>
4827
4828         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4829         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4830         contents...
4831         (tui_initialize_static_data): ...here.
4832
4833 2019-06-25  Tom Tromey  <tom@tromey.com>
4834
4835         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4836         (tui_display_registers_from, tui_check_register_values): Update.
4837         (tui_display_register): Remove win_info parameter; update.
4838         (tui_get_register): Change type of parameters.
4839         * tui/tui-data.h (struct tui_data_element): Remove.
4840         (union tui_which_element) <data>: Remove.
4841         <data_window>: Change type.
4842         (struct tui_data_item_window): New.
4843         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4844         case.  Add assert.
4845         (~tui_data_item_window): New destructor.
4846         (free_content_elements): Remove DATA_ITEM_WIN case.
4847
4848 2019-06-25  Tom Tromey  <tom@tromey.com>
4849
4850         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4851         Remove.
4852
4853 2019-06-25  Tom Tromey  <tom@tromey.com>
4854
4855         * tui/tui-data.h (struct tui_command_element): Remove.
4856         (union tui_which_element) <command>: Remove.
4857         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4858         assert.
4859         (free_content_elements): Remove CMD_WIN case.
4860
4861 2019-06-25  Tom Tromey  <tom@tromey.com>
4862
4863         * tui/tui-layout.c (tui_set_layout): Update.
4864         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4865         * tui/tui-data.c (layout_def): Update.
4866
4867 2019-06-25  Tom Tromey  <tom@tromey.com>
4868
4869         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4870         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4871         (tui_source_window_base::set_new_height): Update.
4872         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4873         Update.
4874         (tui_set_locator_fullname, tui_set_locator_info)
4875         (tui_show_frame_info): Update.
4876         * tui/tui-source.c (tui_set_source_content)
4877         (tui_source_is_displayed): Update.
4878         * tui/tui-layout.c (show_source_disasm_command, show_data)
4879         (show_source_or_disasm_and_command): Update.
4880         * tui/tui-disasm.c (tui_set_disassem_content)
4881         (tui_get_begin_asm_address): Update.
4882         * tui/tui-data.h (struct tui_locator_element): Remove.
4883         (union tui_which_element) <locator>: Remove.
4884         (struct tui_locator_window): New.
4885         (tui_locator_win_info_ptr): Change return type.
4886         * tui/tui-data.c (_locator): Change type.
4887         (tui_locator_win_info_ptr): Change return type.
4888         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4889         (tui_alloc_content): Add assert.
4890
4891 2019-06-25  Tom Tromey  <tom@tromey.com>
4892
4893         * tui/tui-winsource.c
4894         (tui_exec_info_window::maybe_allocate_content): New method.
4895         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4896         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4897         (make_source_or_disasm_window): Add cast.
4898         * tui/tui-data.h (union tui_which_element) <simple_string>:
4899         Remove.
4900         (struct tui_source_info): New.
4901         (struct tui_source_window_base) <execution_info>: Change type.
4902         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4903         case, and add assert.
4904         (tui_alloc_content): Add assert.
4905
4906 2019-06-25  Tom Tromey  <tom@tromey.com>
4907
4908         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4909         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4910         * tui/tui-data.c (tui_alloc_win_info): Remove.
4911
4912 2019-06-25  Tom Tromey  <tom@tromey.com>
4913
4914         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4915         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4916         can_highlight.
4917
4918 2019-06-25  Tom Tromey  <tom@tromey.com>
4919
4920         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4921         make_visible_with_new_height method.
4922         (tui_win_info::make_visible_with_new_height): New method.
4923         (tui_source_window_base::do_make_visible_with_new_height)
4924         (tui_data_window::do_make_visible_with_new_height)
4925         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4926         (make_visible_with_new_height): Remove.
4927         (tui_resize_all, tui_adjust_win_heights): Use
4928         make_visible_with_new_height method.
4929         * tui/tui-data.h (struct tui_win_info)
4930         <do_make_visible_with_new_height, make_visible_with_new_height>:
4931         New methods.
4932         (struct tui_source_window_base, struct tui_data_window)
4933         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4934         methods.
4935
4936 2019-06-25  Tom Tromey  <tom@tromey.com>
4937
4938         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4939         method.
4940         (update_tab_width): Call update_tab_width method.
4941         * tui/tui-data.h (struct tui_win_info)
4942         (struct tui_source_window_base) <update_tab_width>: New methods.
4943
4944 2019-06-25  Tom Tromey  <tom@tromey.com>
4945
4946         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4947         parameter.
4948         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4949         parameter.
4950         (tui_gen_win_info::make_visible): Update.
4951         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4952         parameter.
4953         * tui/tui-data.h (enum tui_box): New enum.
4954         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4955
4956 2019-06-25  Tom Tromey  <tom@tromey.com>
4957
4958         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4959         init_and_make_win for EXEC_INFO_WIN.
4960         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4961         longer inline.
4962         (struct tui_win_info) <~tui_win_info>: Inline.
4963         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4964         Don't declare.
4965         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4966         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4967         Remove.
4968         (tui_initialize_static_data): Update.
4969         (~tui_gen_win_info): Handle more cleanup here.
4970         (~tui_source_window_base): Delete "execution_info".
4971         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4972
4973 2019-06-25  Tom Tromey  <tom@tromey.com>
4974
4975         * tui/tui-layout.c (make_command_window): Don't set
4976         can_highlight.
4977         (show_source_disasm_command): Call the reset method.
4978         (show_data): Don't set can_highlight.  Call the reset method.
4979         (tui_gen_win_info::reset): Rename from init_gen_win_info
4980         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4981         (show_source_or_disasm_and_command): Call the reset method.
4982         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4983         (struct tui_cmd_window): Set can_highlight.
4984
4985 2019-06-25  Tom Tromey  <tom@tromey.com>
4986
4987         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4988         from make_visible.
4989         (tui_make_visible, tui_make_invisible): Rewrite.
4990         (tui_win_info::make_visible): Remove.
4991         (tui_source_window_base::make_visible): Update.
4992         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4993         method.  Moved from...
4994         (struct tui_win_info) <make_visible>: ...here.
4995
4996 2019-06-25  Tom Tromey  <tom@tromey.com>
4997
4998         * tui/tui-winsource.c
4999         (tui_source_window_base::do_scroll_horizontal): Remove direction
5000         parameter.
5001         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5002         direction parameter.
5003         * tui/tui-win.c (tui_win_info::forward_scroll)
5004         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5005         (tui_win_info::right_scroll): Update.
5006         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5007         direction parameter.
5008         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5009         direction parameter.
5010         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5011         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5012         Remove direction parameter.
5013         (struct tui_source_window_base, struct tui_source_window)
5014         (struct tui_disasm_window, struct tui_data_window)
5015         (struct tui_cmd_window): Update.
5016
5017 2019-06-25  Tom Tromey  <tom@tromey.com>
5018
5019         * tui/tui-winsource.h (tui_set_exec_info_content)
5020         (tui_show_exec_info_content, tui_erase_exec_info_content)
5021         (tui_clear_exec_info_content, tui_update_exec_info): Change
5022         argument to tui_source_window_base.
5023         * tui/tui-winsource.c (tui_set_exec_info_content)
5024         (tui_show_exec_info_content, tui_erase_exec_info_content)
5025         (tui_clear_exec_info_content, tui_update_exec_info): Change
5026         argument to tui_source_window_base.
5027
5028 2019-06-25  Tom Tromey  <tom@tromey.com>
5029
5030         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5031         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5032
5033 2019-06-25  Tom Tromey  <tom@tromey.com>
5034
5035         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5036         check.
5037
5038 2019-06-25  Tom Tromey  <tom@tromey.com>
5039
5040         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5041         type to void.
5042         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5043         type to void.
5044         * tui/tui-source.c (tui_set_source_content): Update.
5045         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5046
5047 2019-06-25  Tom Tromey  <tom@tromey.com>
5048
5049         * tui/tui-win.c (window_name_completer, tui_set_focus)
5050         (tui_all_windows_info): Use name method.
5051         * tui/tui-data.h (struct tui_gen_win_info)
5052         (struct tui_source_window, struct tui_disasm_window)
5053         (struct tui_data_window, struct tui_cmd_window) <name>: New
5054         method.
5055         (tui_win_name): Don't declare.
5056         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5057         (tui_win_name): Remove.
5058
5059 2019-06-25  Tom Tromey  <tom@tromey.com>
5060
5061         * tui/tui-winsource.h (tui_update_source_window)
5062         (tui_update_source_window_as_is): Change parameter type.
5063         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5064         to be a tui_source_window_base.
5065         (tui_update_source_window_as_is): Likewise.
5066         * tui/tui-win.c (make_visible_with_new_height): Update.
5067
5068 2019-06-25  Tom Tromey  <tom@tromey.com>
5069
5070         * tui/tui-winsource.c (tui_erase_source_content)
5071         (tui_show_source_content, tui_show_exec_info_content)
5072         (tui_erase_exec_info_content): Use refresh_window method.
5073         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5074         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5075         from tui_refresh_win.
5076         (tui_data_window::refresh_window): New method.
5077         (tui_win_info::refresh, tui_source_window_base::refresh)
5078         (tui_refresh_all): Use refresh_window method.
5079         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5080         method.
5081         * tui/tui-regs.c (tui_display_register): Call refresh_window
5082         method.
5083         * tui/tui-layout.c (show_source_disasm_command)
5084         (show_source_or_disasm_and_command): Call refresh_window method.
5085         * tui/tui-data.h (struct tui_gen_win_info)
5086         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5087         New method.
5088
5089 2019-06-25  Tom Tromey  <tom@tromey.com>
5090
5091         * tui/tui.c (tui_rl_other_window, tui_enable)
5092         (tui_is_window_visible, tui_get_command_dimension): Update.
5093         * tui/tui-winsource.c (tui_update_source_window_as_is)
5094         (tui_clear_source_content, tui_erase_source_content)
5095         (tui_show_source_line, tui_source_window_base::refill)
5096         (tui_source_window_base::do_scroll_horizontal)
5097         (tui_source_window_base::set_is_exec_point_at)
5098         (tui_update_breakpoint_info, tui_set_exec_info_content)
5099         (tui_alloc_source_buffer, tui_line_is_displayed)
5100         (tui_addr_is_displayed): Update.
5101         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5102         (tui_check_and_display_highlight_if_needed)
5103         (tui_win_info::make_visible, tui_win_info::refresh)
5104         (tui_refresh_all): Update.
5105         * tui/tui-windata.c (tui_first_data_item_displayed)
5106         (tui_delete_data_content_windows, tui_erase_data_content)
5107         (tui_display_all_data, tui_data_window::refresh_all)
5108         (tui_check_data_values): Update.
5109         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5110         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5111         (tui_win_info::backward_scroll, tui_refresh_all_win)
5112         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5113         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5114         (tui_source_window_base::set_new_height)
5115         (tui_data_window::set_new_height)
5116         (make_invisible_and_set_new_height)
5117         (make_visible_with_new_height, new_height_ok)
5118         (parse_scrolling_args): Update.
5119         * tui/tui-stack.c (tui_show_frame_info): Update.
5120         * tui/tui-source.c (tui_set_source_content)
5121         (tui_set_source_content_nil, tui_source_is_displayed)
5122         (tui_source_window::do_scroll_vertical): Update.
5123         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5124         (tui_display_registers_from, tui_display_reg_element_at_line)
5125         (tui_check_register_values, tui_reg_command): Update.
5126         * tui/tui-layout.c (tui_default_win_height)
5127         (show_source_disasm_command, show_data, init_and_make_win)
5128         (show_source_or_disasm_and_command): Update.
5129         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5130         (tui_redisplay_readline, tui_mld_flush)
5131         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5132         (tui_getc): Update.
5133         * tui/tui-disasm.c (tui_set_disassem_content)
5134         (tui_disasm_window::do_scroll_vertical): Update.
5135         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5136         Now virtual.
5137         (struct tui_win_info): Derive from tui_gen_win_info.
5138         <~tui_win_info>: Mark as override.
5139         <generic>: Remove member.
5140         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5141         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5142         (~tui_data_window, ~tui_win_info)
5143         (tui_free_all_source_wins_content): Update.
5144         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5145
5146 2019-06-25  Tom Tromey  <tom@tromey.com>
5147
5148         * tui/tui-layout.c (init_and_make_win): Use new.
5149         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5150         destructor, initializers.
5151         (tui_alloc_generic_win_info): Don't declare.
5152         * tui/tui-data.c (_locator): Add argument to constructor.
5153         (source_win, disasm_win): New globals.
5154         (exec_info): Remove.
5155         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5156         Update.
5157         (tui_alloc_generic_win_info): Remove.
5158         (init_content_element): Use new.
5159         (tui_win_info::tui_win_info): Update.
5160         (free_content_elements) <case DATA_WIN>: Use delete.
5161
5162 2019-06-25  Tom Tromey  <tom@tromey.com>
5163
5164         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5165         * tui/tui-windata.c (tui_first_data_item_displayed)
5166         (tui_delete_data_content_windows): Update.
5167         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5168         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5169         (tui_display_registers_from, tui_check_register_values): Update.
5170         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5171         pointer.
5172         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5173         window.
5174         (tui_free_data_content): Update.
5175         (free_content_elements) <case DATA_WIN>: Free the window.
5176
5177 2019-06-25  Tom Tromey  <tom@tromey.com>
5178
5179         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5180         Update.
5181         * tui/tui-layout.c (make_command_window)
5182         (show_source_disasm_command, show_data, init_and_make_win)
5183         (show_source_or_disasm_and_command): Update.
5184         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5185         method.
5186         <can_highight, is_highlighted>: Now bool.
5187         (tui_set_win_highlight): Don't declare.
5188         * tui/tui-data.c (tui_set_win_highlight): Remove.
5189
5190 2019-06-25  Tom Tromey  <tom@tromey.com>
5191
5192         * tui/tui-wingeneral.c (make_visible): Remove check of window
5193         type.
5194
5195 2019-06-25  Tom Tromey  <tom@tromey.com>
5196
5197         * tui/tui-win.c (tui_win_info::max_height)
5198         (tui_cmd_window::max_height): New methods.
5199         (new_height_ok): Call max_height.
5200         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5201         <max_height>: New method.
5202
5203 2019-06-25  Tom Tromey  <tom@tromey.com>
5204
5205         * tui/tui-win.c (tui_source_window_base::set_new_height)
5206         (tui_data_window::set_new_height): New methods.
5207         (make_invisible_and_set_new_height): Call set_new_height method.
5208         * tui/tui-data.h (struct tui_win_info)
5209         (struct tui_source_window_base, struct tui_data_window)
5210         <set_new_height>: New method.
5211
5212 2019-06-25  Tom Tromey  <tom@tromey.com>
5213
5214         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5215         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5216         tui_refresh_data_win.
5217         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5218         method.
5219         (tui_refresh_all_win): Call the refresh_all method.
5220         (tui_set_focus): Likewise.
5221         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5222         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5223         Likewise.
5224
5225 2019-06-25  Tom Tromey  <tom@tromey.com>
5226
5227         * tui/tui-winsource.h (tui_refill_source_window)
5228         (tui_set_is_exec_point_at): Don't declare.
5229         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5230         (tui_source_window_base::refill): Rename from
5231         tui_refill_source_window.
5232         (tui_source_window_base::do_scroll_horizontal): Update.
5233         (tui_source_window_base::set_is_exec_point_at): Rename from
5234         tui_set_is_exec_point_at.
5235         (tui_update_all_breakpoint_info): Update.
5236         * tui/tui-stack.c (tui_show_frame_info): Update.
5237         * tui/tui-layout.c (show_data): Add cast.
5238         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5239         * tui/tui-data.h (struct tui_source_window_base) <refill,
5240         set_is_exec_point_at>: New methods.
5241         (tui_source_windows, tui_add_to_source_windows): Update types.
5242         (tui_add_to_source_windows): Remove redundant declaration.
5243         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5244         (tui_source_windows): Change return type.
5245         (tui_clear_source_windows_detail): Update.
5246         (tui_add_to_source_windows): Change type of parameter.
5247         (tui_free_all_source_wins_content): Update.
5248
5249 2019-06-25  Tom Tromey  <tom@tromey.com>
5250
5251         * tui/tui-wingeneral.c (tui_win_info::refresh)
5252         (tui_source_window_base::refresh): New methods.
5253         (tui_refresh_all): Call the refresh method.
5254         * tui/tui-data.h (struct tui_win_info)
5255         (struct tui_source_window_base) <refresh>: New method.
5256
5257 2019-06-25  Tom Tromey  <tom@tromey.com>
5258
5259         * tui/tui.h (tui_is_window_visible): Return bool.
5260         * tui/tui.c (tui_is_window_visible): Return bool.
5261         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5262         (tui_make_visible, tui_make_invisible)
5263         (tui_win_info::make_visible)
5264         (tui_source_window_base::make_visible, make_all_visible)
5265         (tui_make_all_visible, tui_make_all_invisible): Update.
5266         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5267         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5268         bool.
5269         (struct tui_win_info, struct tui_source_window_base)
5270         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5271         * tui/tui-data.c (tui_init_generic_part): Update.
5272
5273 2019-06-25  Tom Tromey  <tom@tromey.com>
5274
5275         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5276         (tui_source_window_base::make_visible): New methods.
5277         (make_all_visible): Make method call.
5278         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5279         (struct tui_source_window_base, struct tui_cmd_window): Override
5280         make_visible.
5281         (tui_win_is_source_type): Don't declare.
5282         * tui/tui-data.c (tui_win_is_source_type): Remove.
5283
5284 2019-06-25  Tom Tromey  <tom@tromey.com>
5285
5286         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5287         NULL check.
5288
5289 2019-06-25  Tom Tromey  <tom@tromey.com>
5290
5291         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5292         Inline constructor.  Add initializers for members.
5293         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5294         constructors; now inline in class.
5295
5296 2019-06-25  Tom Tromey  <tom@tromey.com>
5297
5298         * tui/tui-regs.c (tui_show_registers): Update.
5299         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5300         bool.
5301         * tui/tui-data.c (tui_data_window::clear_detail)
5302         (tui_data_window): Update.
5303
5304 2019-06-25  Tom Tromey  <tom@tromey.com>
5305
5306         * tui/tui-windata.c (tui_display_all_data)
5307         (tui_display_data_from_line, tui_display_data_from)
5308         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5309         Update.
5310         * tui/tui-regs.c (tui_last_regs_line_no)
5311         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5312         (tui_show_registers, tui_show_register_group)
5313         (tui_display_registers_from, tui_display_reg_element_at_line)
5314         (tui_display_registers_from_line, tui_check_register_values)
5315         (tui_reg_next, tui_reg_prev): Update.
5316         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5317         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5318         tui_data_window.
5319         (struct tui_win_info) <detail>: Remove.  Add new fields from
5320         tui_data_info.
5321         (TUI_DATA_WIN): Add cast.
5322         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5323         (~tui_data_window): Simplify.
5324
5325 2019-06-25  Tom Tromey  <tom@tromey.com>
5326
5327         * tui/tui-layout.c (show_source_disasm_command)
5328         (show_source_or_disasm_and_command): Update.
5329         * tui/tui-io.c (update_cmdwin_start_line)
5330         (tui_redisplay_readline): Update.
5331         * tui/tui-data.h (struct tui_command_info): Remove.
5332         (struct tui_win_info) <detail>: Remove command_info member.
5333         (struct tui_data_window) <start_line>: New member, from
5334         tui_command_info.
5335         (TUI_CMD_WIN): Add casts.
5336
5337 2019-06-25  Tom Tromey  <tom@tromey.com>
5338
5339         * tui/tui-winsource.c (tui_update_source_window)
5340         (tui_refill_source_window)
5341         (tui_source_window_base::do_scroll_horizontal)
5342         (tui_update_breakpoint_info, tui_set_exec_info_content)
5343         (tui_show_exec_info_content, tui_erase_exec_info_content)
5344         (tui_clear_exec_info_content): Update.
5345         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5346         Update.
5347         * tui/tui-win.c (make_invisible_and_set_new_height)
5348         (make_visible_with_new_height): Update.
5349         * tui/tui-source.c (tui_set_source_content)
5350         (tui_show_symtab_source): Update.
5351         * tui/tui-layout.c (extract_display_start_addr)
5352         (show_source_disasm_command, show_data)
5353         (make_source_or_disasm_window)
5354         (show_source_or_disasm_and_command): Update.
5355         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5356         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5357         "gdbarch".
5358         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5359         to tui_source_window_base.
5360         (struct tui_win_info) <detail>: Remove source_info member.
5361         (struct tui_source_window_base) <has_locator>: Inline.
5362         Move contents from tui_source_info; rename has_locator member to
5363         m_has_locator.
5364         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5365         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5366         header file.
5367         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5368         Simplify.
5369         (tui_free_all_source_wins_content): Cast to
5370         tui_source_window_base.
5371
5372 2019-06-25  Tom Tromey  <tom@tromey.com>
5373
5374         * tui/tui-win.c (make_invisible_and_set_new_height)
5375         (make_visible_with_new_height): Call has_locator method.
5376         * tui/tui-layout.c (show_source_disasm_command, show_data)
5377         (show_source_or_disasm_and_command): Update for bool change.
5378         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5379         (tui_win_info) <has_locator>: New method.
5380         (struct tui_source_window_base) <has_locator>: New method.
5381         (tui_win_has_locator): Don't declare.
5382         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5383         from tui_win_has_locator.
5384         (tui_source_window_base): Use false, not FALSE.
5385
5386 2019-06-25  Tom Tromey  <tom@tromey.com>
5387
5388         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5389         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5390         clear_detail method directly.
5391         (tui_clear_win_detail): Remove.
5392
5393 2019-06-25  Tom Tromey  <tom@tromey.com>
5394
5395         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5396         "this", not TUI_DISASM_WIN.
5397
5398 2019-06-25  Tom Tromey  <tom@tromey.com>
5399
5400         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5401         declare.
5402         * tui/tui-winsource.c
5403         (tui_source_window_base::do_scroll_horizontal): Rename from
5404         tui_horizontal_source_scroll.
5405         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5406         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5407         from tui_vertical_data_scroll.
5408         * tui/tui-win.h (tui_scroll): Don't declare.
5409         * tui/tui-win.c (tui_win_info::forward_scroll)
5410         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5411         (tui_win_info::right_scroll): Rename and update.
5412         (tui_scroll_forward_command, tui_scroll_backward_command)
5413         (tui_scroll_left_command, tui_scroll_right_command): Update.
5414         (tui_scroll): Remove.
5415         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5416         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5417         from tui_vertical_source_scroll.
5418         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5419         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5420         from tui_vertical_disassem_scroll.
5421         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5422         do_scroll_horizontal>: New methods.
5423         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5424         Likewise.
5425         (struct tui_source_window_base): Add do_scroll_horizontal.
5426         (struct tui_source_window, struct tui_disasm_window): Add
5427         do_scroll_vertical.
5428         (struct tui_data_window, struct tui_cmd_window): Add
5429         do_scroll_horizontal and do_scroll_vertical.
5430         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5431
5432 2019-06-25  Tom Tromey  <tom@tromey.com>
5433
5434         * tui/tui-data.h (struct tui_source_window_base): New struct.
5435         (struct tui_source_window): Derive from tui_source_window_base.
5436         (struct tui_disasm_window): New struct.
5437         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5438         from tui_source_window::clear_detail.
5439         (tui_source_window_base): Rename from tui_source_window.
5440         (~tui_source_window_base): Rename from ~tui_source_window.
5441         (tui_alloc_win_info): Create a tui_disasm_window.
5442
5443 2019-06-25  Tom Tromey  <tom@tromey.com>
5444
5445         * tui/tui-data.h (struct tui_source_window)
5446         (struct tui_data_window): Declare destructors.
5447         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5448         destructors.
5449         (tui_win_info): Simplify.
5450
5451 2019-06-25  Tom Tromey  <tom@tromey.com>
5452
5453         * tui/tui-winsource.c (tui_display_main)
5454         (tui_update_source_windows_with_addr)
5455         (tui_update_all_breakpoint_info): Update.
5456         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5457         (new_height_ok, parse_scrolling_args): Update.
5458         * tui/tui-stack.c (tui_show_frame_info): Update.
5459         * tui/tui-data.h (struct tui_list): Remove.
5460         (tui_source_windows): Return a reference to a std::vector.
5461         * tui/tui-data.c (source_windows): Now a std::vector.
5462         (tui_source_windows): Change return type.
5463         (tui_clear_source_windows): Rewrite.
5464         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5465         (tui_free_all_source_wins_content): Rewrite.
5466
5467 2019-06-25  Tom Tromey  <tom@tromey.com>
5468
5469         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5470         (struct tui_data_window, struct tui_cmd_window): Declare
5471         clear_detail method.
5472         * tui/tui-data.c (tui_source_window::clear_detail)
5473         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5474         methods.
5475         (tui_clear_win_detail): Simplify.
5476
5477 2019-06-25  Tom Tromey  <tom@tromey.com>
5478
5479         * tui/tui-layout.c (make_source_window, make_disasm_window)
5480         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5481         Return the new window.
5482         (show_source_disasm_command, show_data)
5483         (show_source_or_disasm_and_command): Update.
5484
5485 2019-06-25  Tom Tromey  <tom@tromey.com>
5486
5487         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5488         parameter.  Return the new window.
5489         (show_source_disasm_command): Update and remove NULL check.
5490         (show_source_or_disasm_and_command): Update.
5491
5492 2019-06-25  Tom Tromey  <tom@tromey.com>
5493
5494         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5495
5496 2019-06-25  Tom Tromey  <tom@tromey.com>
5497
5498         * tui/tui-data.h (struct tui_win_info): Make constructor
5499         protected.  Make destructor virtual.  Add initializers.
5500         (tui_source_window, tui_data_window, tui_cmd_window): New
5501         classes.
5502         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5503         constructor.  Add "type" parameter.
5504         (tui_source_window, tui_data_window, tui_cmd_window): New
5505         constructors.
5506         (tui_alloc_win_info): Instantiate the appropriate subclass.
5507
5508 2019-06-25  Tom Tromey  <tom@tromey.com>
5509
5510         * tui/tui-win.c (tui_resize_all): Use delete.
5511         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5512         destructor.
5513         (tui_free_window): Don't declare.
5514         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5515         Update.
5516
5517 2019-06-25  Tom Tromey  <tom@tromey.com>
5518
5519         * tui/tui-data.h (struct tui_win_info): Add constructor.
5520         * tui/tui-data.c (tui_alloc_win_info): Use new.
5521         (tui_free_window): Use delete.
5522
5523 2019-06-22  Tom Tromey  <tom@tromey.com>
5524
5525         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5526         declare.
5527         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5528
5529 2019-06-22  Tom Tromey  <tom@tromey.com>
5530
5531         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5532         declare.
5533         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5534
5535 2019-06-22  Tom de Vries  <tdevries@suse.de>
5536
5537         * dwarf2read.c (create_addrmap_from_aranges)
5538         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5539         instead of '%zu'.
5540
5541 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5542
5543         * dwarf2read.h (dwarf2_section_info_def): Remove.
5544         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5545         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5546         std::vector<dwarf2_section_info>.
5547         (struct dwo_file) <~dwo_file>: Remove.
5548         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5549         types field.
5550         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5551         (dwarf2_read_debug_names): Likewise.
5552         (create_debug_types_hash_table): Change parameter type to
5553         array_view, adjust code accordingly.
5554         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5555         (partial_die_info::fixup): Likewise.
5556         (determine_prefix): Likewise.
5557         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5558
5559 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5560
5561         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5562         gdb_bfd_ref_ptr.
5563         <~dwo_file>: Remove call to gdb_bfd_unref.
5564         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5565         gdb_bfd_ref_ptr::get.
5566
5567 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5568
5569         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5570         type to htab_up.
5571         * dwarf2read.c (struct dwo_file): Initialize fields.
5572         <~dwo_file>: New.
5573         (free_dwo_file): Remove, move content to ~dwo_file.
5574         (struct dwo_file_deleter): Remove.
5575         (dwo_file_up>: Remove custom deleter.
5576         (free_dwo_files): Remove.
5577         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5578         dwo_files.
5579         (process_skeletonless_type_units): Call unique_ptr::get.
5580         (allocate_dwo_file_hash_table): Add deleter to created hash
5581         table.  Change return type to htab_up.
5582         (lookup_dwo_file_slot): Don't memset dwo_file, call
5583         unique_ptr::get.
5584         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5585         (create_dwo_unit_in_dwp_v2): Likewise.
5586         (open_and_init_dwo_file): Likewise.
5587         (free_dwo_file_from_slot): Remove.
5588
5589 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5590
5591         * dwarf2read.h (struct dwarf2_section_info) <readin,
5592         is_virtual>: Change type to bool.
5593         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5594         true instead of 1.
5595
5596 2019-06-19  Tom Tromey  <tom@tromey.com>
5597
5598         * tui/tui-data.h (tui_init_content_element): Don't declare.
5599
5600 2019-06-19  Tom Tromey  <tom@tromey.com>
5601
5602         * tui/tui-data.h (tui_init_win_info): Don't declare.
5603
5604 2019-06-19  Tom de Vries  <tdevries@suse.de>
5605
5606         * dwarf2read.h (abstract_to_concrete): Change type to
5607         std::unordered_map<sect_offset, std::vector<sect_offset>,
5608         gdb::hash_enum<sect_offset>>.
5609
5610 2019-06-19  Tom Tromey  <tromey@adacore.com>
5611
5612         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5613         EVAL_AVOID_SIDE_EFFECTS specially.
5614
5615 2019-06-19  Tom Tromey  <tromey@adacore.com>
5616
5617         * source-cache.c (highlighter): New global.
5618         (source_cache::get_source_lines): Create a highlighter on demand.
5619
5620 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5621
5622         * defs.h (deprecated_interactive_hook): Delete declaration.
5623         * interps.c (clear_interpreter_hooks): Remove use of
5624         deprecated_interactive_hook.
5625         * top.c (deprecated_interactive_hook): Delete definition.
5626         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5627
5628 2019-06-18  Tom de Vries  <tdevries@suse.de>
5629
5630         PR gdb/24515
5631         * dwarf2read.h (abstract_to_concrete): Change type from
5632         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5633         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5634         * dwarf2read.c (read_variable): Update.
5635         (dwarf2_fetch_die_loc_sect_off): Update.
5636
5637 2019-06-17  Tom de Vries  <tdevries@suse.de>
5638
5639         PR gdb/24617
5640         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5641         accessing parent[parent_len - 1].
5642
5643 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5644
5645         PR gdb/24364
5646         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5647         call dtrace_process_dof with NULL dof.
5648
5649 2019-06-16  Tom de Vries  <tdevries@suse.de>
5650
5651         PR gdb/24445
5652         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5653
5654 2019-06-16  Tom Tromey  <tom@tromey.com>
5655
5656         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5657         (make_all_visible): Use address of member.
5658
5659 2019-06-16  Tom Tromey  <tom@tromey.com>
5660
5661         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5662         (tui_free_window, free_content, free_content_elements): Remove
5663         unnecessary cast.
5664         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5665         cast.
5666         * tui/tui-regs.c (tui_show_register_group)
5667         (tui_display_registers_from, tui_display_reg_element_at_line):
5668         Remove unnecessary cast.
5669
5670 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5671
5672         * linux-nat.c (normal_mask): Delete.
5673         (_initialize_linux_nat): Don't initialise normal_mask.
5674
5675 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5676
5677         PR gdb/24445
5678         * dwarf-index-write.h (write_psymtabs_to_index): Add
5679         dwz_basename parameter.
5680         * dwarf-index-write.c (write_gdbindex): Move file writing to
5681         write_gdbindex_1.  Change return type void.
5682         (assert_file_size): Move up, remove filename parameter.
5683         (write_gdbindex_1): New function.
5684         (write_debug_names): Change return type to void, call
5685         assert_file_size.
5686         (struct index_wip_file): New struct.
5687         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5688         file logic to index_wip_file.  Write index for dwz file if
5689         needed.
5690         (save_gdb_index_command): Pass basename of dwz file, if present.
5691         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5692         build-id of dwz file, if present.
5693         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5694         (dwarf2_get_dwz_file): Likewise.
5695         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5696         (dwarf2_get_dwz_file): Likewise.
5697
5698 2019-06-16  Tom Tromey  <tom@tromey.com>
5699
5700         * coffread.c (process_coff_symbol): Use xstrdup.
5701         * value.c (create_internalvar): Use xstrdup.
5702
5703 2019-06-16  Tom Tromey  <tom@tromey.com>
5704
5705         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5706         * breakpoint.c (stopin_command, stopat_command)
5707         (until_break_command, decode_location_default): Remove unnecessary
5708         cast.
5709         * utils.c (subset_compare): Remove unnecessary cast.
5710         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5711         cast.
5712         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5713         cast.
5714         * infcmd.c (path_command): Remove unnecessary cast.
5715         * coffread.c (decode_type): Remove unnecessary cast.
5716         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5717         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5718         * tui/tui-stack.c (tui_show_locator_content)
5719         (tui_show_frame_info): Remove unnecessary cast.
5720         * tui/tui-win.c (tui_scroll_forward_command)
5721         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5722         (parse_scrolling_args): Remove unnecessary cast.
5723         * tui/tui-data.c (init_win_info, tui_del_window)
5724         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5725         (free_content_elements): Remove unnecessary cast.
5726         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5727         unnecessary cast.
5728         * tui/tui-source.c (tui_set_source_content)
5729         (tui_vertical_source_scroll): Remove unnecessary cast.
5730         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5731         cast.
5732         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5733         * tui/tui-regs.c (tui_display_registers_from)
5734         (tui_display_register): Remove unnecessary cast.
5735         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5736         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5737         (make_visible): Remove unnecessary cast.
5738         * tui/tui-winsource.c (tui_erase_source_content)
5739         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5740         unnecessary cast.
5741         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5742         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5743         * stabsread.c (read_type, read_array_type, read_range_type):
5744         Remove unnecessary cast.
5745         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5746         (parse_symbol, parse_type, upgrade_type, parse_external)
5747         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5748         unnecessary cast.
5749         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5750
5751 2019-06-16  Tom Tromey  <tom@tromey.com>
5752
5753         * tui/tui-data.c (tui_alloc_generic_win_info)
5754         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5755         checks.
5756
5757 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5758             Andrew Burgess  <andrew.burgess@embecosm.com>
5759
5760         * f-typeprint.c (f_print_type): Don't return early for not
5761         associated or not allocated types.
5762         (f_type_print_varspec_suffix): Add print_rank parameter and print
5763         ranks of array types in case they dangling.
5764         (f_type_print_base): Add print_rank parameter.
5765
5766 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5767
5768         * NEWS: Mention new MI commands.
5769         * break-catch-throw.c (enum exception_event_kind): Move to
5770         breakpoint.h.
5771         (print_mention_exception_catchpoint): Output text as a single
5772         message.
5773         (catch_exception_command_1): Rename to...
5774         (catch_exception_event): ...this, make non-static, update header
5775         command, and change some parameter types.
5776         (catch_catch_command): Update for changes to
5777         catch_exception_command_1.
5778         (catch_throw_command): Likewise.
5779         (catch_rethrow_command): Likewise.
5780         * breakpoint.c (enum exception_event_kind): Delete.
5781         * breakpoint.h (enum exception_event_kind): Moved here from
5782         break-catch-throw.c.
5783         (catch_exception_event): Declare.
5784         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5785         (mi_cmd_catch_throw): New function.
5786         (mi_cmd_catch_rethrow): New function.
5787         (mi_cmd_catch_catch): New function.
5788         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5789         'catch-catch' entries.
5790         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5791         (mi_cmd_catch_rethrow): Declare.
5792         (mi_cmd_catch_catch): Declare.
5793
5794 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5795
5796         * annotate.c (annotate_source_line): Change return type to void,
5797         update implementation to match.
5798         * annotate.h (annotate_source_line): Change return type to void,
5799         update header comment.
5800         * stack.c (print_frame_info): Don't change what frame information
5801         is printed based on whether annotations are on or not.
5802
5803 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5804
5805         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5806         (annotate_source): Make static.
5807         (annotate_source_line): Moved from source.c and renamed from
5808         identify_source_line.  Update the return type.
5809         * annotate.h (annotate_source): Delete declaration.
5810         (annotate_source_line): Declaration moved from source.h, and
5811         renamed from identify_source_line.  Return type updated.
5812         * source.c (identify_source_line): Moved to annotate.c and renamed
5813         to annotate_source_line.
5814         (info_line_command): Remove check of annotation_level.
5815         * source.h (identify_source_line): Move declaration to annotate.h
5816         and rename to annotate_source_line.
5817         * stack.c: Add 'annotate.h' include.
5818         (print_frame_info): Remove check of annotation_level before
5819         calling annotate_source_line.
5820
5821 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5822
5823         * source-cache.c (source_cache::get_plain_source_lines): Use
5824         open_source_file_with_line_charpos instead of just
5825         open_source_file, remove call to find_source_lines.
5826         (source_cache::get_source_lines): Likewise.
5827         * source.c (find_source_lines): Make static.
5828         (get_filename_and_charpos): Renamed into...
5829         (open_source_file_with_line_charpos): ..this along with changes to
5830         return a scoped_fd, and some other minor clean ups.
5831         (identify_source_line): Use open_source_file_with_line_charpos.
5832         (search_command_helper): Use open_source_file_with_line_charpos
5833         instead of just open_source_file, remove call to
5834         find_source_lines.
5835         * source.h (open_source_file_with_line_charpos): Declare new
5836         function.
5837         (find_source_lines): Delete declaration.
5838
5839 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5840
5841         * source.c (get_filename_and_charpos): Remove fullname
5842         parameter.
5843         (identify_source_line): Update call to get_filename_and_charpos.
5844
5845 2019-06-14  Tom Tromey  <tromey@adacore.com>
5846
5847         PR gdb/24502:
5848         * ui-style.h (skip_ansi_escape): Update comment.
5849         * ui-file.h (class no_terminal_escape_file): New class.
5850         * ui-file.c (no_terminal_escape_file::write)
5851         (no_terminal_escape_file::puts): New methods.
5852         * cli/cli-logging.c (handle_redirections): Use
5853         no_terminal_escape_file.
5854
5855 2019-06-14  Tom Tromey  <tromey@adacore.com>
5856
5857         * NEWS: Move convenience variable news above Python news.
5858
5859 2019-06-14  Tom Tromey  <tom@tromey.com>
5860
5861         * gnulib: Move directory to top-level.
5862         * configure.ac: Don't configure gnulib.
5863         * configure: Rebuild.
5864         * common/common-defs.h: Use new path to gnulib.
5865         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5866         (GNULIB_H): Remove.
5867         (INCGNU): Look in new gnulib location.
5868         (HFILES_NO_SRCDIR): Remove gnulib files.
5869         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5870         (generated_files): Remove GNULIB_H.
5871         ($(LIBGNU), all-lib): Remove targets.
5872         (distclean): Don't mention GNULIB_BUILDDIR.
5873         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5874
5875 2019-06-14  Tom Tromey  <tromey@adacore.com>
5876
5877         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5878         Warn if symbol file does not provide any symbols.
5879
5880 2019-06-14  Tom Tromey  <tromey@adacore.com>
5881
5882         * source.c (find_and_open_source): Respect basenames_may_differ.
5883
5884 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5885
5886         * annotate.c (annotate_breakpoints_invalid): Make use of
5887         scoped_restore_terminal_state.
5888         (annotate_frames_invalid): Likewise.
5889
5890 2019-06-14  Tom Tromey  <tromey@adacore.com>
5891
5892         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5893         allow assignment to an internalvar.
5894
5895 2019-06-14  Tom Tromey  <tromey@adacore.com>
5896
5897         * ada-lex.l: Allow "_" in attribute names.
5898
5899 2019-06-14  Tom Tromey  <tromey@adacore.com>
5900
5901         PR gdb/24653:
5902         * regcache.c (registers_changed): Don't call alloca.
5903         * top.c (execute_command): Don't call alloca.
5904
5905 2019-06-13  Pedro Alves  <palves@redhat.com>
5906
5907         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5908         'expression'.  When parsing an expression, error out if there's
5909         junk after "unlimited".
5910         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5911         (do_set_command): Adjust calls to is_unlimited_literal.
5912
5913 2019-06-13  Pedro Alves  <palves@redhat.com>
5914
5915         * compile/compile.c (make_compile_options_def_group): Add braces
5916         around array_view initializer.
5917         * thread.c (make_thread_apply_all_options_def_group)
5918         (make_thread_apply_all_options_def_group): Likewise.
5919
5920 2019-06-13  Pedro Alves  <palves@redhat.com>
5921
5922         * NEWS (New commands): Mention "maint test-options
5923         require-delimiter", "maint test-options unknown-is-error", "maint
5924         test-options unknown-is-operand" and "maint show
5925         test-options-completion-result".
5926         (New command options, command completion): New section.
5927         (Completion improvements): New section.
5928         Mention that you can abbreviate "unlimited".
5929
5930 2019-06-13  Pedro Alves  <palves@redhat.com>
5931
5932         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5933         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5934         * unittests/cli-utils-selftests.c (test_parse_flags)
5935         (test_parse_flags_qcs): Delete.
5936         (test_cli_utils): Don't call deleted functions.
5937
5938 2019-06-13  Pedro Alves  <palves@redhat.com>
5939
5940         * thread.c: Include "cli/cli-option.h".
5941         (tp_array_compar_ascending): Global.
5942         (tp_array_compar): Delete function.
5943         (tp_array_compar_ascending, tp_array_compar_descending): New
5944         functions.
5945         (ascending_option_def, qcs_flag_option_def)
5946         (thr_qcs_flags_option_defs)
5947         (make_thread_apply_all_options_def_group)
5948         (make_thread_apply_options_def_group): New.
5949         (thread_apply_all_command): Use gdb::option::process_options.
5950         (thread_apply_command_completer)
5951         (thread_apply_all_command_completer): New.
5952         (thread_apply_command): Use gdb::option::process_options.
5953         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5954         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5955         to generate help text of "thread apply".  Adjust "taas"'s help.
5956         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5957         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5958
5959 2019-06-13  Pedro Alves  <palves@redhat.com>
5960
5961         * thread.c (thread_apply_command): Check for invalid TID with
5962         isdigit instead of !isalpha.
5963
5964 2019-06-13  Pedro Alves  <palves@redhat.com>
5965
5966         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5967         (validate_flags_qcs): New.
5968         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5969         (validate_flags_qcs): Declare.
5970         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5971         (make_frame_apply_options_def_group): New.
5972         (frame_apply_command_count): Process options with
5973         gdb::option::process_options.
5974         (frame_apply_completer): New.
5975         (frame_apply_level_completer, frame_apply_all_completer)
5976         (frame_apply_completer): New.
5977         (_initialize_stack): Update help of "frame apply", "frame apply
5978         level", "frame apply all" and "faas" to mention supported options
5979         and install command completers.
5980         * stack.h (frame_apply_all_completer): Declare.
5981         * thread.c: Include "stack.h".
5982         (tfaas_command): Add "--".
5983         (_initialize_thread): Update help "tfaas" to mention supported
5984         options and install command completer.
5985
5986 2019-06-13  Pedro Alves  <palves@redhat.com>
5987
5988         * completer.c (complete_nested_command_line): New.
5989         (gdb_completion_word_break_characters_throw): Add assertion.
5990         * completer.h (complete_nested_command_line): Declare.
5991
5992 2019-06-13  Pedro Alves  <palves@redhat.com>
5993
5994         * stack.c (parse_backtrace_qualifiers): New.
5995         (backtrace_command): Use it.
5996         (backtrace_command_completer): Complete on qualifiers.
5997
5998 2019-06-13  Pedro Alves  <palves@redhat.com>
5999
6000         * frame.c: Include "cli/cli-option.h.
6001         (user_set_backtrace_options): New.
6002         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6003         Delete.
6004         (get_prev_frame): Adjust.
6005         (boolean_option_def, uinteger_option_def)
6006         (set_backtrace_option_defs): New.
6007         (_initialize_frame): Adjust and use
6008         gdb::option::add_setshow_cmds_for_options to install "set
6009         backtrace past-main" and "set backtrace past-entry".
6010         * frame.h: Include "cli/cli-option.h".
6011         (struct frame_print_options): Forward declare.
6012         (print_frame_arguments_all, print_frame_arguments_scalars)
6013         (print_frame_arguments_none): Declare.
6014         (print_entry_values): Delete declaration.
6015         (struct frame_print_options, user_frame_print_options): New.
6016         (struct set_backtrace_options): New.
6017         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6018         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6019         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6020         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6021         (list_args_or_locals): Add frame_print_options parameter.
6022         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6023         * python/py-framefilter.c (enumerate_args): Pass down
6024         USER_FRAME_PRINT_OPTIONS.
6025         * stack.c: Include "cli/cli-option.h".
6026         (print_frame_arguments_all, print_frame_arguments_scalars)
6027         (print_frame_arguments_none): Declare.
6028         (print_raw_frame_arguments, print_entry_values): Delete.
6029         (user_frame_print_options): New.
6030         (boolean_option_def, enum_option_def, frame_print_option_defs):
6031         New.
6032         (struct backtrace_cmd_options): New.
6033         (bt_flag_option_def): New.
6034         (backtrace_command_option_defs): New.
6035         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6036         (print_frame_arg, read_frame_arg, print_frame_args)
6037         (print_frame_info, print_frame): Add frame_print_options parameter
6038         and use it.
6039         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6040         (backtrace_command_1): Add frame_print_options and
6041         backtrace_cmd_options parameters and use them.
6042         (make_backtrace_options_def_group): New.
6043         (backtrace_command): Process command options with
6044         gdb::option::process_options.
6045         (backtrace_command_completer): New.
6046         (_initialize_stack): Extend "backtrace"'s help to mention
6047         supported options.  Install completer for "backtrace".
6048         Install some settings commands with add_setshow_cmds_for_options.
6049
6050 2019-06-13  Pedro Alves  <palves@redhat.com>
6051
6052         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6053         and that "set/show print raw frame-arguments" are now deprecated.
6054
6055         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6056         command.
6057         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6058         * stack.c (_initialize_stack): Install "set/show print
6059         raw-frame-arguments", and deprecate "set/show print raw
6060         frame-arguments".
6061         * valprint.c (_initialize_valprint): Deprecate "set/show print
6062         raw".
6063
6064 2019-06-13  Pedro Alves  <palves@redhat.com>
6065
6066         * compile/compile.c (struct compile_options): New.
6067         (compile_flag_option_def, compile_command_option_defs)
6068         (make_compile_options_def_group): New.
6069         (compile_file_command): Handle options with
6070         gdb::option::process_options.
6071         (compile_file_command_completer): New function.
6072         (compile_code_command): Handle options with
6073         gdb::option::process_options.
6074         (compile_code_command_completer): New function.
6075         (_initialize_compiler): Install completers for "compile code" and
6076         "compile file".  Mention available options in "compile code" and
6077         "compile code"'s help.
6078         * completer.c (advance_to_completion_word): New, factored out from
6079         ...
6080         (advance_to_expression_complete_word_point): ... this.
6081         (advance_to_filename_complete_word_point): New.
6082         * completer.h (advance_to_filename_complete_word_point): New
6083         declaration.
6084
6085 2019-06-13  Pedro Alves  <palves@redhat.com>
6086
6087         * compile/compile.c: Include "cli/cli-option.h".
6088         (compile_print_value): Scope data pointer is now a
6089         value_print_options pointer; adjust.
6090         (compile_print_command): Process options.  Scope data pointer is
6091         now a value_print_options pointer; adjust.
6092         (_initialize_compile): Update "compile print"'s help to include
6093         supported options.  Install a completer for "compile print".
6094         * cp-valprint.c (show_vtblprint, show_objectprint)
6095         (show_static_field_print): Delete.
6096         (_initialize_cp_valprint): Don't install "set print
6097         static-members", "set print vtbl", "set print object" here.
6098         * printcmd.c: Include "cli/cli-option.h" and
6099         "common/gdb_optional.h".
6100         (print_command_parse_format): Rework to fill in a
6101         value_print_options instead of a format_data.
6102         (print_value): Change parameter type from format_data pointer to
6103         value_print_options reference.  Adjust.
6104         (print_command_1): Process options.  Adjust to pass down a
6105         value_print_options.
6106         (print_command_completer): New.
6107         (_initialize_printcmd): Install print_command_completer as
6108         handle_brkchars completer for the "print" command.  Update
6109         "print"'s help to include supported options.
6110         * valprint.c: Include "cli/cli-option.h".
6111         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6112         here from cp-valprint.c.
6113         (boolean_option_def, uinteger_option_def)
6114         (value_print_option_defs, make_value_print_options_def_group):
6115         New.  Use gdb::option::add_setshow_cmds_for_options to install
6116         "set print elements", "set print null-stop", "set print repeats",
6117         "set print pretty", "set print union", "set print array", "set
6118         print address", "set print symbol", "set print array-indexes".
6119         * valprint.h: Include <string> and "cli/cli-option.h".
6120         (make_value_print_options_def_group): Declare.
6121         (print_value): Change parameter type from format_data pointer to
6122         value_print_options reference.
6123         (print_command_completer): Declare.
6124
6125 2019-06-13  Pedro Alves  <palves@redhat.com>
6126
6127         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6128         (COMMON_SFILES): Add maint-test-settings.c.
6129         * cli/cli-decode.c (boolean_enums): New global, factored out from
6130         ...
6131         (add_setshow_boolean_cmd): ... here.
6132         * cli/cli-decode.h (boolean_enums): Declare.
6133         * cli/cli-option.c: New file.
6134         * cli/cli-option.h: New file.
6135         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6136         factored out from ...
6137         (parse_cli_boolean_value(const char *)): ... this.
6138         (is_unlimited_literal): Change parameter type to pointer to
6139         pointer.  Adjust and advance ARG pointer.
6140         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6141         (parse_cli_var_enum): New, factored out from ...
6142         (do_set_command): ... this.  Adjust.
6143         * cli/cli-setshow.h (parse_cli_boolean_value)
6144         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6145         (parse_cli_var_enum): Declare.
6146         * cli/cli-utils.c: Include "cli/cli-option.h".
6147         (get_ulongest): New.
6148         * cli/cli-utils.h (get_ulongest): Declare.
6149         (check_for_argument): New overloads.
6150         * maint-test-options.c: New file.
6151
6152 2019-06-13  Pedro Alves  <palves@redhat.com>
6153
6154         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6155         parse a range if "-" is at the end of the string.
6156
6157 2019-06-13  Pedro Alves  <palves@redhat.com>
6158
6159         * cli/cli-setshow.c (parse_auto_binary_operation)
6160         (parse_cli_boolean_value): Don't allow "o".
6161
6162 2019-06-13  Pedro Alves  <palves@redhat.com>
6163
6164         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6165         * NEWS: Mention maint test-settings KIND.
6166         * maint-test-settings.c: New file.
6167
6168 2019-06-13  Pedro Alves  <palves@redhat.com>
6169
6170         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6171         completer.
6172         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6173         "set" completers.
6174
6175 2019-06-13  Pedro Alves  <palves@redhat.com>
6176
6177         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6178         after item.
6179
6180 2019-06-13  Pedro Alves  <palves@redhat.com>
6181
6182         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6183
6184 2019-06-13  Pedro Alves <palves@redhat.com>
6185
6186         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6187         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6188         call.
6189         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6190         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6191         calls.
6192         (check_for_argument): Skip spaces after argument.
6193
6194 2019-06-13  Pedro Alves  <palves@redhat.com>
6195
6196         * thread.c (thread_apply_command): Adjust TID parsing.
6197         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6198         detected before end of string.
6199         (tid_is_in_list): Error out if LIST is invalid.
6200
6201 2019-06-13  Pedro Alves  <palves@redhat.com>
6202
6203         * completer.c (complete_line_internal_1): Rewind completion word
6204         point.
6205         (completion_tracker::advance_custom_word_point_by): Change
6206         parameter type to int.
6207         * completer.h (completion_tracker::advance_custom_word_point_by):
6208         Likewise.
6209
6210 2019-06-13  Pedro Alves  <palves@redhat.com>
6211
6212         * completer.c (advance_to_completion_word): Handle delimiters.
6213
6214 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6215
6216         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6217
6218 2019-06-11  Tom Tromey  <tom@tromey.com>
6219
6220         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6221         (xmalloc_failed): Move to alloc.c.
6222         * alloc.c: New file.
6223         * Makefile.in (COMMON_SFILES): Add alloc.c.
6224
6225 2019-06-11  Tom Tromey  <tom@tromey.com>
6226
6227         * nat/linux-waitpid.c: Don't include server.h.
6228         (linux_debug): Remove.
6229         (my_waitpid): Update.
6230
6231 2019-06-11  Tom Tromey  <tromey@adacore.com>
6232
6233         * infcall.c (_initialize_infcall): Remove trailing newline from
6234         help.
6235         * user-regs.c (_initialize_user_regs): Remove trailing newline
6236         from help.
6237         * typeprint.c (_initialize_typeprint): Remove trailing newline
6238         from help.
6239         * reverse.c (_initialize_reverse): Remove trailing newlines from
6240         help.
6241         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6242         from help.
6243         * language.c (add_set_language_command): Remove trailing newline
6244         from help.
6245         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6246         help.
6247         * disasm.c (_initialize_disasm): Remove trailing newline from
6248         help.
6249         * top.c (init_main): Remove trailing newline from help.
6250         * interps.c (_initialize_interpreter): Remove trailing newline
6251         from help.
6252         * btrace.c (_initialize_btrace): Remove trailing newlines from
6253         help.
6254         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6255         from help.
6256         * python/python.c (_initialize_python): Remove trailing newline
6257         from help.
6258         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6259         help.
6260         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6261         from help.  Reformat some text.
6262         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6263         from help.
6264         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6265         newline from help.
6266
6267 2019-06-11  Tom Tromey  <tromey@adacore.com>
6268
6269         * darwin-nat.c (darwin_decode_exception_message)
6270         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6271
6272 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6273
6274         * valops.c (value_slice): Check for not allocated or not
6275         associated values.
6276
6277 2019-06-10  Tom de Vries  <tdevries@suse.de>
6278
6279         PR gdb/24618
6280         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6281         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6282         invalid.
6283
6284 2019-06-10  Tom de Vries  <tdevries@suse.de>
6285
6286         PR gdb/24611
6287         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6288         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6289
6290 2019-06-10  Tom de Vries  <tdevries@suse.de>
6291
6292         PR symtab/24545
6293         * symtab.c (struct demangled_name_entry): Add language field.
6294         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6295         static minimal symbol".  Set and use language field.
6296
6297 2019-06-10  Tom Tromey  <tromey@adacore.com>
6298
6299         * ada-lang.c (_initialize_ada_language): Update help text.
6300
6301 2019-06-10  Tom Tromey  <tromey@adacore.com>
6302
6303         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6304         with a newline.
6305         * guile/guile.c (handle_boot_error): Don't end warning with a
6306         newline.
6307         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6308         warning with a newline.
6309         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6310         newline.
6311         (s12z_frame_cache): Likewise.
6312         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6313         a newline.
6314         * solib-svr4.c (disable_probes_interface): Don't end warning with
6315         a newline.
6316         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6317         newline.
6318         * python/python.c (do_finish_initialization): Don't end warning
6319         with a newline.
6320
6321 2019-06-10  Tom Tromey  <tom@tromey.com>
6322
6323         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6324         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6325         gdbpy_enter.
6326
6327 2019-06-10  Tom Tromey  <tromey@adacore.com>
6328
6329         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6330         data.
6331         (elf_new_init): Don't call stabsread_new_init.
6332         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6333         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6334         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6335
6336 2019-06-10  Tom de Vries  <tdevries@suse.de>
6337
6338         PR symtab/16264
6339         PR symtab/24517
6340         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6341
6342 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6343
6344         * source.c (find_and_open_source): Also rewrite relative file
6345         names.
6346
6347 2019-04-26  Amos Bird  <amosbird@gmail.com>
6348
6349         * annotate.c (annotate_thread_exited): Add "thread-exited"
6350         annotation.
6351
6352 2019-06-06  Tom Tromey  <tromey@adacore.com>
6353
6354         * maint.h (class scoped_command_stats): Use
6355         DISABLE_COPY_AND_ASSIGN.
6356         <print_time>: New method.
6357         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6358         print_time.
6359         (scoped_command_stats::print_time): New method.
6360
6361 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6362
6363         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6364         instructions of lengths 6 or 8 bytes.
6365
6366 2019-06-04  Pedro Alves  <palves@redhat.com>
6367
6368         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6369
6370         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6371         * breakpoint.c (condition_completer): Likewise.
6372         * cli/cli-dump.c (scan_expression): Likewise.
6373         * common/filestuff.c (mkdir_recursive): Likewise.
6374         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6375         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6376         (gdb_abspath): Likewise.
6377         * compile/compile-cplus-types.c
6378         (compile_cplus_instance::decl_name): Likewise.
6379         * completer.c (complete_explicit_location):
6380         (signal_completer, reg_or_group_completer_1): Likewise.
6381         * cp-support.c (cp_remove_params_if_any): Likewise.
6382         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6383         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6384         * infcmd.c (strip_bg_char): Likewise.
6385         * linespec.c (copy_token_string): Likewise.
6386         * mi/mi-main.c (output_cores): Likewise.
6387         * psymtab.c (psymtab_search_name):
6388         * symfile.c (test_set_ext_lang_command): Likewise.
6389         * target.c (target_fileio_read_stralloc): Likewise.
6390         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6391         * value.c (complete_internalvar): Likewise.
6392
6393 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6394
6395         Add objfile property to gdb.Type.
6396         * NEWS: Mention Python API addition.
6397         * python/py-type.c (typy_get_objfile): New method.
6398
6399 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6400
6401         * NEWS: Mention the new set|show style [title|highlight].
6402         Mention changes to "show style", "help" and "apropos".
6403
6404 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6405
6406         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6407         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6408         instead of print_help_for_command.
6409         (print_doc_of_command): New function.
6410         (help_list): Add 'apropos -v word' suggestion.
6411         (print_help_for_command): Style the command name using title style.
6412         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6413         (_initialize_cli_cmds): Describe -v in apropos_command help.
6414
6415 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6416
6417         * cli/cli-style.h (cli_style_option): Add name in constructor,
6418         add m_name class member, add constructor with intensity,
6419         add name class function.
6420         (cli_style_option::add_setshow_commands): Remove name argument.
6421         (highlight_style, title_style): New styles.
6422         * cli/cli-style.c (do_show): New function that shows a style
6423         characteristic styling the style name with itself.
6424         (set_style_name): New function.
6425         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6426         Update all callers according to the changes in cli/cli-style.h.
6427         * utils.h (fputs_highlighted): New function.
6428         * utils.c (fputs_highlighted): Likewise.
6429
6430 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6431
6432         * NEWS: Mention new pipe command and new convenience variables.
6433
6434 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6435
6436         * cli/cli-cmds.c (pipe_command): New function.
6437         (_initialize_cli_cmds): Call add_com for pipe_command.
6438         Define | as an alias for pipe.
6439         (exit_status_set_internal_vars): New function.
6440         (shell_escape): Call exit_status_set_internal_vars.
6441         cli/cli-decode.c (find_command_name_length): Recognize | as
6442         a single character command.
6443
6444 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6445
6446         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6447         top.c (execute_command_to_ui_file): New function, mostly a copy
6448         of execute_command_to_string.
6449         (execute_command_to_string): Implement by calling
6450         execute_command_to_ui_file.
6451
6452 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6453
6454         * top.h (saved_command_line): Remove declaration.
6455         * top.c (previous_saved_command_line, previous_repeat_arguments):
6456         New variables.
6457         (saved_command_line): Make static, define together with other
6458         'repeat variables'.
6459         (dont_repeat): Clear repeat_arguments.
6460         (repeat_previous, get_saved_command_line, save_command_line):
6461         New functions.
6462         (gdb_init): Initialize saved_command_line
6463         and previous_saved_command_line.
6464         * main.c (captured_main_1): Remove saved_command_line initialization.
6465         * event-top.c (handle_line_of_input): Update to use
6466         the new 'repeat' related functions instead of direct access to
6467         saved_command_line.
6468         * command.h (repeat_previous, get_saved_command_line,
6469         save_command_line): New declarations.
6470         (dont_repeat): Add comment.
6471
6472 2019-05-30  Tom Tromey  <tromey@adacore.com>
6473
6474         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6475         Fix comment.
6476         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6477
6478 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6479
6480         PR cli/24587
6481         * completer.c (complete): Initialize variable word.
6482
6483 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6484
6485         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6486         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6487         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6488         'body' is NULL to the outter 'if', protecting the '!is_define'
6489         situation as well.
6490
6491 2019-05-29  Tom Tromey  <tromey@adacore.com>
6492
6493         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6494         (dwarf_unknown): New function.
6495         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6496         (dwarf_type_encoding_name): Use dwarf_unknown.
6497
6498 2019-05-29  Tom Tromey  <tromey@adacore.com>
6499
6500         PR c++/20020:
6501         * cp-valprint.c (cp_print_value_fields): Call
6502         cp_print_static_field inside "try".
6503
6504 2019-05-29  Tom Tromey  <tromey@adacore.com>
6505
6506         * inflow.c (struct terminal_info): Add default operator=.
6507         * configure: Rebuild.
6508         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6509         -Wdeprecated-copy-dtor, -Wredundant-move.
6510
6511 2019-05-29  Tom Tromey  <tromey@adacore.com>
6512
6513         * NEWS: Add entry.
6514         * infcmd.c (print_return_value_1): Handle finish_print
6515         option.
6516         (show_print_finish): New function.
6517         (_initialize_infcmd): Add "set/show print finish" commands.
6518         * valprint.c (user_print_options): Initialize new member.
6519         * valprint.h (struct value_print_options) <finish_print>: New
6520         member.
6521
6522 2019-05-28  Tom Tromey  <tromey@adacore.com>
6523
6524         * ada-lang.c (ada_remove_Xbn_suffix)
6525         (find_old_style_renaming_symbol)
6526         (parse_old_style_renaming): Remove.
6527         (ada_find_renaming_symbol): Don't call
6528         find_old_style_renaming_symbol.
6529         (ada_is_renaming_symbol): Rename from
6530         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6531         bool.  Now static.
6532         (ada_read_var_value): Update and simplify.
6533         * ada-exp.y (write_var_or_type): Remove old code.
6534
6535 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6536
6537         * event-top.c: Remove include comment.
6538         * inflow.c (class scoped_ignore_sigttou): Move from here...
6539         * inflow.h (class scoped_ignore_sigttou): ...to here.
6540         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6541         * top.c:  Remove include comment.
6542
6543 2019-05-27  Tom Tromey  <tom@tromey.com>
6544
6545         * NEWS: Fix typo.
6546
6547 2019-05-22  Tom Tromey  <tromey@adacore.com>
6548
6549         * target.c (target_follow_exec): Constify parameter.
6550         * target-delegates.c: Rebuild.
6551         * remote.c (remote_target::follow_exec): Constify parameter.
6552         * infrun.c (follow_exec): Constify parameter.
6553         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6554         (target_follow_exec): Likewise.
6555
6556 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6557
6558         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6559         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6560
6561 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6562
6563         * NEWS: Add debugredirect and testsuite sections.
6564
6565 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6566
6567         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6568         target descriptions using exclusively floating point register name
6569         aliases.
6570
6571 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6572
6573         PR gdb/18644:
6574         * f-lang.c (build_fortran_types): Handle the case where
6575         gdbarch_floatformat_for_type returns a nullptr.
6576
6577 2019-05-21  Tom de Vries  <tdevries@suse.de>
6578
6579         PR cli/24587
6580         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6581
6582 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6583
6584         PR gdb/18644:
6585         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6586         16-byte floats.
6587         * i386-tdep.c (i386_floatformat_for_type): Use
6588         floatformats_ia64_quad for the 16-byte floating point component
6589         within a fortran 32-byte complex number.
6590
6591 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6592
6593         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6594         delete default constructor.
6595         (find_partial_die): Update to return const struct.
6596         (partial_die_parent_scope): Move variable declaration into scope
6597         of its use and change its type to auto.
6598         (guess_partial_die_structure_name): Likewise.
6599         (partial_die_info::fixup): Likewise.
6600
6601 2019-05-17  Tom Tromey  <tromey@adacore.com>
6602
6603         * source.c (find_and_open_source): Remove cast.
6604
6605 2019-05-17  Tom Tromey  <tromey@adacore.com>
6606
6607         * annotate.c (annotate_source): Make "filename" const.
6608         * annotate.h (annotate_source): Use const.
6609
6610 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6611
6612         * disasm.c (set_disassembler_options): Send errors to stderr.
6613
6614 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6615
6616         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6617         (cli_interp_base::set_logging): Check debug_redirect.
6618         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6619         * cli/cli-logging.c (debug_redirect): Add static variable.
6620         (pop_output_files): Add default param.
6621         (handle_redirections): Print debug setting.
6622         (show_logging_command): Likewise.
6623         (_initialize_cli_logging): Add debugredirect command.
6624         * interps.c (current_interp_set_logging): Add debug_redirect
6625         parameter.
6626         * interps.h (set_logging): Add debug_redirect parameter.
6627         (current_interp_set_logging): Likewise.
6628         * mi/mi-common.h: Likewise.
6629         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6630
6631 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6632             Tom Tromey  <tromey@adacore.com>
6633
6634         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6635         directly.
6636         * cli/cli-interp.h (make_logging_output): Remove declaration.
6637         * cli/cli-logging.c (make_logging_output): Remove function.
6638         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6639         directly.
6640         * ui-file.c (tee_file::tee_file): Remove bools.
6641         (tee_file::~tee_file): Remove deletes.
6642         * ui-file.h (tee_file): Remove bools.
6643
6644 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6645
6646         * mi/mi-cmds.h (mi_cmd_complete): New function.
6647         * mi/mi-main.c (mi_cmd_complete): Likewise.
6648         * mi/mi-cmds.c: Define new MI command -complete.
6649         * NEWS: Mention new -complete command.
6650
6651 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6652
6653         * completer.h (complete): New function.
6654         * completer.c (complete): Likewise.
6655         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6656         function defined in completer.h.
6657
6658 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6659
6660         * MAINTAINERS (Write After Approval): Add myself.
6661
6662 2019-05-17  Tom de Vries  <tdevries@suse.de>
6663
6664         PR gdb/24094
6665         * dwarf2read.c (struct cu_partial_die_info): New struct.
6666         (find_partial_die): Return cu_partial_die_info.
6667         (partial_die_parent_scope, guess_partial_die_structure_name)
6668         (partial_die_info::fixup): Handle new return type of find_partial_die.
6669
6670 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6671
6672         PR breakpoints/24541
6673         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6674         "std::string", simplifying the algorithm.
6675
6676 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6677
6678         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6679         (stap_static_probe_ops::get_probes): Likewise.
6680
6681 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6682
6683         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6684         '-')" and "else if".
6685         (stap_parse_single_operand): Join checks for
6686         "gdbarch_stap_parse_special_token_p" and
6687         "gdbarch_stap_parse_special_token" in the same "if" statement.
6688         Invert check when verifying for operation on register
6689         displacement.
6690
6691 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6692
6693         * stap-probe.c (stap_get_opcode): Update comment.
6694         (stap_get_expected_argument_type): Likewise.
6695         (handle_stap_probe): Likewise.
6696
6697 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6698
6699         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6700         return type to 'bool'.  Adjust comment.  Use 'bool' when
6701         appropriate.
6702         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6703         * stap-probe.c (stap_parse_argument_1): Likewise.
6704         (stap_is_operator): Likewise.
6705         (stap_is_generic_prefix): Likewise.
6706         (stap_is_register_prefix): Likewise.
6707         (stap_is_register_indirection_prefix): Likewise.
6708         (stap_is_integer_prefix): Likewise.
6709         (stap_generic_check_suffix): Likewise.
6710         (stap_check_integer_suffix): Likewise.
6711         (stap_check_register_suffix): Likewise.
6712         (stap_check_register_indirection_suffix): Likewise.
6713         (stap_parse_register_operand): Likewise.
6714         (stap_parse_single_operand): Likewise.
6715         (stap_parse_argument_1): Likewise.
6716         (stap_probe::get_argument_count): Likewise.
6717         (stap_is_operator): Likewise.
6718
6719 2019-05-16  Tom Tromey  <tromey@adacore.com>
6720
6721         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6722         keyword to foreach.
6723
6724 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6725
6726         * linux-thread-db.c (try_thread_db_load_1): Change return type
6727         to bool.
6728         (try_thread_db_load): Likewise.
6729         (try_thread_db_load_from_pdir_1): Likewise.
6730         (try_thread_db_load_from_pdir): Likewise.
6731         (try_thread_db_load_from_sdir): Likewise.
6732         (try_thread_db_load_from_dir): Likewise.
6733         (thread_db_load_search): Likewise.
6734         (has_libpthread): Likewise.
6735         (thread_db_load): Likewise.
6736
6737 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6738
6739         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6740         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6741         NULL, and complain/return if that's the case.
6742
6743 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6744
6745         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6746         (advance, posn, abstract_read_memory): New functions.
6747         [struct mem_read_abstraction]: New struct.
6748         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6749
6750 2019-05-14  Tom Tromey  <tromey@adacore.com>
6751
6752         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6753         value is not lval_memory.
6754
6755 2019-05-14  Tom Tromey  <tromey@adacore.com>
6756
6757         * solib.c (info_sharedlibrary_command): Style the file name.
6758
6759 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6760
6761         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6762         (aarch64_vnv_type): Likewise.
6763         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6764         * common/tdesc.c: Likewise.
6765         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6766         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6767         * features/aarch64-fpu.xml: Add ieee half view.
6768         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6769         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6770         * gdbtypes.h (struct builtin_type): Likewise.
6771         (struct objfile_type): Likewise.
6772
6773 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6774
6775         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6776         typo.
6777         * location.h (string_to_event_location): Likewise.
6778
6779 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6780
6781         GDB 8.3 released.
6782
6783 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6784
6785         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6786         New variable declaration.
6787         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6788         New variable.
6789         (print_one_breakpoint): Use ui_out::test_flags and new global
6790         variable to compute use_fixed_output.
6791         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6792         Remove.
6793         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6794         (mi_multi_location_breakpoint_output_fixed): Remove.
6795         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6796         new variable.
6797         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6798         fix_multi_location_breakpoint_output flag if version >= 3.
6799         * ui-out.h (enum ui_out_flag)
6800         <fix_multi_location_breakpoint_output>: New enumerator.
6801
6802 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6803
6804         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6805
6806 2019-05-10  Tom Tromey  <tromey@adacore.com>
6807
6808         * ada-lang.c (catch_ada_completer): New function.
6809         (_initialize_ada_language): Use it.
6810
6811 2019-05-10  Tom Tromey  <tromey@adacore.com>
6812
6813         * thread.c (print_thread_info): Make "requested_threads" const.
6814         * gdbthread.h (print_thread_info): Make "requested_threads"
6815         const.
6816         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6817         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6818
6819 2019-05-08  Tom Tromey  <tom@tromey.com>
6820
6821         * gdbtypes.c (objfile_type_data): Change type.
6822         (objfile_type, _initialize_gdbtypes): Update.
6823
6824 2019-05-08  Tom Tromey  <tom@tromey.com>
6825
6826         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6827         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6828         (_initialize_dwarf2_frame): Update.
6829
6830 2019-05-08  Tom Tromey  <tom@tromey.com>
6831
6832         * objc-lang.c (objc_objfile_data): Change type.
6833         (find_methods): Update.
6834         (_initialize_objc_lang): Remove.
6835
6836 2019-05-08  Tom Tromey  <tom@tromey.com>
6837
6838         * stabsread.c (rs6000_builtin_type_data): Change type.
6839         (rs6000_builtin_type, _initialize_stabsread): Update.
6840
6841 2019-05-08  Tom Tromey  <tom@tromey.com>
6842
6843         * mips-tdep.c (mips_pdr_data): Remove.
6844         (_initialize_mips_tdep): Update.
6845
6846 2019-05-08  Tom Tromey  <tom@tromey.com>
6847
6848         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6849         (hppa_init_objfile_priv_data, read_unwind_info)
6850         (find_unwind_entry, _initialize_hppa_tdep): Update.
6851
6852 2019-05-08  Tom Tromey  <tom@tromey.com>
6853
6854         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6855         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6856         on obstack.
6857         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6858
6859 2019-05-08  Tom Tromey  <tom@tromey.com>
6860
6861         * mdebugread.c (basic_type_data): Change type.
6862         (basic_type, _initialize_mdebugread): Update.
6863
6864 2019-05-08  Tom Tromey  <tom@tromey.com>
6865
6866         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6867
6868 2019-05-08  Tom Tromey  <tom@tromey.com>
6869
6870         * nto-tdep.c (nto_inferior_data_reg): Change type.
6871         (nto_inferior_data): Update.
6872         (nto_inferior_data_cleanup, nto_new_inferior_data)
6873         (_initialize_nto_tdep): Remove.
6874         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6875
6876 2019-05-08  Tom Tromey  <tom@tromey.com>
6877
6878         * ada-lang.c (struct ada_inferior_data): Add initializers.
6879         (ada_inferior_data): Change type.
6880         (ada_inferior_data_cleanup): Remove.
6881         (get_ada_inferior_data, ada_inferior_exit)
6882         (struct ada_pspace_data): Add initializers, destructor.
6883         (ada_pspace_data_handle): Change type.
6884         (get_ada_pspace_data): Update.
6885         (ada_pspace_data_cleanup): Remove.
6886
6887 2019-05-08  Tom Tromey  <tom@tromey.com>
6888
6889         * coffread.c (struct coff_symfile_info): Add initializers.
6890         (coff_objfile_data_key): Move lower.  Change type.
6891         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6892         Update.
6893         (coff_free_info): Remove.
6894
6895 2019-05-08  Tom Tromey  <tom@tromey.com>
6896
6897         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6898         (fbsd_pspace_data_handle): Move lower.  Change type.
6899         (get_fbsd_pspace_data): Update.
6900         (fbsd_pspace_data_cleanup): Remove.
6901         (_initialize_fbsd_tdep): Update.
6902
6903 2019-05-08  Tom Tromey  <tom@tromey.com>
6904
6905         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6906         (get_ada_tasks_pspace_data): Update.
6907         (ada_tasks_pspace_data_cleanup): Remove.
6908         (_initialize_tasks): Update.
6909         (ada_tasks_inferior_data_handle): Change type.
6910         (get_ada_tasks_inferior_data): Update.
6911         (ada_tasks_inferior_data_cleanup): Remove.
6912         (struct ada_tasks_pspace_data): Add initializers.
6913
6914 2019-05-08  Tom Tromey  <tom@tromey.com>
6915
6916         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6917         * symfile-debug.c (debug_sym_get_probes): Change type.
6918         * stap-probe.c (handle_stap_probe):
6919         (stap_static_probe_ops::get_probes): Change type.
6920         * probe.h (class static_probe_ops) <get_probes>: Change type.
6921         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6922         (parse_probes_in_pspace): Update.
6923         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6924         Update.
6925         (any_static_probe_ops::get_probes): Change type.
6926         * elfread.c (elfread_data): New typedef.
6927         (probe_key): Change type.
6928         (elf_get_probes): Likewise.  Update.
6929         (probe_key_free): Remove.
6930         (_initialize_elfread): Update.
6931         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6932         Change type.
6933         (dtrace_process_dof_probe, dtrace_process_dof)
6934         (dtrace_static_probe_ops::get_probe): Change type.
6935
6936 2019-05-08  Tom Tromey  <tom@tromey.com>
6937
6938         * xcoffread.c (struct xcoff_symfile_info): Rename from
6939         coff_symfile_info.  Add initializers.
6940         (xcoff_objfile_data_key): Move lower.  Change type.
6941         (XCOFF_DATA): Rewrite.
6942         (xcoff_free_info): Remove.
6943         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6944         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6945         (xcoff_initial_scan): Update.
6946
6947 2019-05-08  Tom Tromey  <tom@tromey.com>
6948
6949         * solib-svr4.c (struct svr4_info): Add initializers and
6950         destructor.
6951         <probes_table>: Now an htab_up.
6952         (solib_svr4_pspace_data): Change type.
6953         (free_probes_table): Simplify.
6954         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6955         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6956         (probes_table_remove_objfile_probes, register_solib_event_probe)
6957         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6958         (_initialize_svr4_solib): Update.
6959
6960 2019-05-08  Tom Tromey  <tom@tromey.com>
6961
6962         * remote.c (remote_pspace_data): Change type.
6963         (remote_pspace_data_cleanup): Remove.
6964         (get_remote_exec_file, set_pspace_remote_exec_file)
6965         (_initialize_remote): Update.
6966
6967 2019-05-08  Tom Tromey  <tom@tromey.com>
6968
6969         * breakpoint.c (breakpoint_objfile_key): Change type.
6970         (get_breakpoint_objfile_data): Update.
6971         (free_breakpoint_objfile_data): Remove.
6972         (_initialize_breakpoint): Update.
6973
6974 2019-05-08  Tom Tromey  <tom@tromey.com>
6975
6976         * linux-tdep.c (struct linux_info): Add initializers.
6977         (linux_inferior_data): Move.  Change type.
6978         (invalidate_linux_cache_inf): Update.
6979         (linux_inferior_data_cleanup): Remove.
6980         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6981
6982 2019-05-08  Tom Tromey  <tom@tromey.com>
6983
6984         * auxv.c (auxv_inferior_data): Move.  Change type.
6985         (auxv_inferior_data_cleanup): Remove.
6986         (invalidate_auxv_cache_inf): Rewrite.
6987         (get_auxv_inferior_data, _initialize_auxv): Update.
6988
6989 2019-05-08  Tom Tromey  <tom@tromey.com>
6990
6991         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6992         (symfile_debug_objfile_data_key): Change type.
6993         (symfile_debug_installed, debug_qf_has_symbols)
6994         (debug_qf_find_last_source_symtab)
6995         (debug_qf_forget_cached_source_info)
6996         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6997         (debug_qf_print_stats, debug_qf_dump)
6998         (debug_qf_expand_symtabs_for_function)
6999         (debug_qf_expand_all_symtabs)
7000         (debug_qf_expand_symtabs_with_fullname)
7001         (debug_qf_map_matching_symbols)
7002         (debug_qf_expand_symtabs_matching)
7003         (debug_qf_find_pc_sect_compunit_symtab)
7004         (debug_qf_map_symbol_filenames)
7005         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7006         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7007         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7008         (debug_sym_read_linetable, debug_sym_relocate): Update.
7009         (symfile_debug_free_objfile): Remove.
7010         (install_symfile_debug_logging, _initialize_symfile_debug):
7011         Update.
7012
7013 2019-05-08  Tom Tromey  <tom@tromey.com>
7014
7015         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7016         allocate_on_obstack.
7017         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7018         (get_dwarf2_per_objfile): Update.
7019         (set_dwarf2_per_objfile): Remove.
7020         (dwarf2_has_info, dwarf2_get_section_info): Update.
7021         (dwarf2_free_objfile): Remove.
7022         (_initialize_dwarf2_read): Update.
7023
7024 2019-05-08  Tom Tromey  <tom@tromey.com>
7025
7026         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7027         initializers.
7028         <unsupported_script_warning_printed,
7029         script_not_found_warning_printed>: Now bool.
7030         (auto_load_pspace_data): Change type.
7031         (~auto_load_pspace_info): Rename from
7032         auto_load_pspace_data_cleanup.
7033         (get_auto_load_pspace_data, init_loaded_scripts_info)
7034         (clear_section_scripts, maybe_print_unsupported_script_warning)
7035         (maybe_print_script_not_found_warning, _initialize_auto_load):
7036         Update.
7037
7038 2019-05-08  Tom Tromey  <tom@tromey.com>
7039
7040         * objfiles.c (objfile_pspace_info): Add destructor and
7041         initializers.
7042         (objfiles_pspace_data): Change type.
7043         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7044         (get_objfile_pspace_data): Update.
7045         (objfiles_bfd_data): Change type.
7046         (get_objfile_bfd_data): Update.
7047         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7048
7049 2019-05-08  Tom Tromey  <tom@tromey.com>
7050
7051         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7052         Change type.
7053         (get_catch_syscall_inferior_data): Update.
7054         (catch_syscall_inferior_data_cleanup): Remove.
7055         (_initialize_break_catch_syscall): Update.
7056
7057 2019-05-08  Tom Tromey  <tom@tromey.com>
7058
7059         * inflow.c (struct terminal_info): Add destructor and
7060         initializers.
7061         (inflow_inferior_data): Change type.
7062         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7063         (get_inflow_inferior_data, inflow_inferior_exit)
7064         (swap_terminal_info, _initialize_inflow): Update.
7065
7066 2019-05-08  Tom Tromey  <tom@tromey.com>
7067
7068         * target-dcache.c (target_dcache_cleanup): Remove.
7069         (target_dcache_aspace_key): Change type.
7070         (target_dcache_init_p, target_dcache_invalidate)
7071         (target_dcache_get, target_dcache_get_or_init)
7072         (_initialize_target_dcache): Update.
7073         * dcache.h (struct dcache_deleter): New.
7074
7075 2019-05-08  Tom Tromey  <tom@tromey.com>
7076
7077         * symtab.c (struct symbol_cache): Add destructor and
7078         initializers.
7079         (symbol_cache_key): Move.  Change type.
7080         (make_symbol_cache, free_symbol_cache): Remove.
7081         (get_symbol_cache): Update.
7082         (symbol_cache_cleanup): Remove.
7083         (ALL_PSPACES, symbol_cache_flush)
7084         (maintenance_print_symbol_cache)
7085         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7086         Update.
7087
7088 2019-05-08  Tom Tromey  <tom@tromey.com>
7089
7090         * symtab.c (struct main_info): Add destructor and initializers.
7091         (main_progspace_key): Move.  Change type.
7092         (get_main_info): Update.
7093         (main_info_cleanup): Remove.
7094         (_initialize_symtab): Update.
7095
7096 2019-05-08  Tom Tromey  <tom@tromey.com>
7097
7098         * registry.h (DECLARE_REGISTRY): Define the _key class.
7099
7100 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7101
7102         * NEWS: Merge two 'New commands' sections.
7103
7104 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7105
7106         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7107         parameter and use Ada language definition instead.
7108         (ada_val_print_ptr): Remove unused language parameter.
7109         (ada_val_print_num): Remove language parameter and use Ada language
7110         definition instead.
7111         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7112         parameter.
7113         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7114         parameter and use Ada language definition instead.
7115         (ada_val_print_1): Update all ada_val_print_xxx calls.
7116         Remove language parameter.
7117         (ada_val_print): Update ada_val_print_1 call.
7118
7119 2019-05-08  Tom Tromey  <tromey@adacore.com>
7120
7121         * remote.c (remote_hw_watchpoint_limit)
7122         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7123         Now static.
7124
7125 2019-05-08  Tom Tromey  <tromey@adacore.com>
7126
7127         * maint.c (_initialize_maint_cmds): Move initialization code to
7128         remote.c.
7129         (watchdog, show_watchdog): Move to remote.c.
7130         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7131         "watchdog" static.
7132         (_initialize_remote): Move initialization code from maint.c.
7133         * defs.h (watchdog): Don't declare.
7134
7135 2019-05-08  Tom Tromey  <tromey@adacore.com>
7136
7137         * tui/tui-interp.c: Include main.h.
7138         * interps.c: Include main.h.
7139         * main.h (interpreter_p): Declare.
7140         * defs.h (interpreter_p): Don't declare.
7141
7142 2019-05-08  Tom Tromey  <tromey@adacore.com>
7143
7144         * dwarf2loc.c: Include dwarf2read.h.
7145         * defs.h (read_unsigned_leb128): Don't declare.
7146         * dwarf2read.h (read_unsigned_leb128): Declare.
7147
7148 2019-05-08  Tom Tromey  <tromey@adacore.com>
7149
7150         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7151         method.
7152
7153 2019-05-08  Tom Tromey  <tromey@adacore.com>
7154
7155         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7156         when no wrap column is set.
7157
7158 2019-05-08  Tom Tromey  <tromey@adacore.com>
7159
7160         * c-lang.c (c_get_string): Handle non-C-style arrays.
7161
7162 2019-05-08  Tom Tromey  <tromey@adacore.com>
7163
7164         * typeprint.c (print_offset_data::update): Print the bit offset,
7165         not the number of bits remaining.
7166
7167 2019-05-08  Tom Tromey  <tromey@adacore.com>
7168
7169         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7170         padding at end of comment.
7171
7172 2019-05-08  Tom Tromey  <tromey@adacore.com>
7173
7174         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7175         Compare main types.
7176
7177 2019-05-06  Tom Tromey  <tom@tromey.com>
7178
7179         * common/scoped_mmap.c: Include common-defs.h.
7180         * common/scoped_mmap.h: Don't include config.h.
7181
7182 2019-05-04  Tom Tromey  <tom@tromey.com>
7183
7184         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7185         (struct aarch64_call_info): Add initializers.
7186         <si>: Now a std::vector.
7187         (pass_on_stack, aarch64_push_dummy_call): Update.
7188
7189 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7190             Tom Tromey  <tom@tromey.com>
7191
7192         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7193         (ppc_threads): Now a std::vector.  Now static.
7194         (hwdebug_find_thread_points_by_tid)
7195         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7196         Update.
7197
7198 2019-05-04  Tom Tromey  <tom@tromey.com>
7199
7200         * arc-tdep.c (arc_tdesc_init): Return bool.
7201
7202 2019-05-04  Tom Tromey  <tom@tromey.com>
7203
7204         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7205         Use gdb_assert_not_reached.
7206
7207 2019-05-04  Tom Tromey  <tom@tromey.com>
7208
7209         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7210         "false".
7211
7212 2019-05-04  Tom Tromey  <tom@tromey.com>
7213
7214         * arc-tdep.c (arc_tdesc_init): Use bool.
7215
7216 2019-05-04  Tom Tromey  <tom@tromey.com>
7217
7218         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7219
7220 2019-05-04  Tom Tromey  <tom@tromey.com>
7221
7222         * cli/cli-cmds.c (valid_command_p): Return bool.
7223
7224 2019-05-04  Tom Tromey  <tom@tromey.com>
7225
7226         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7227         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7228
7229 2019-05-04  Raul Tambre  <raul@tambre.ee>
7230
7231         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7232         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7233         operator for comparison.
7234
7235 2019-05-04  Tom Tromey  <tom@tromey.com>
7236
7237         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7238         (lookup_partial_symbol, print_partial_symbols)
7239         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7240         (psymbol_compare): Update.
7241         (add_psymbol_to_bcache): Clear the entire psymbol.
7242         (maintenance_check_psymtabs): Update.
7243         * psympriv.h (struct partial_symbol): Don't derive from
7244         general_symbol_info.
7245         <obj_section, unrelocated_address, address,
7246         set_unrelocated_address>: Update.
7247         <ginfo>: New member.
7248         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7249         (debug_names::write_psymbols): Update.
7250
7251 2019-05-04  Tom de Vries  <tdevries@suse.de>
7252
7253         * contrib/cc-with-tweaks.sh: Support -n arg.
7254
7255 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7256
7257         * corelow.c (core_target::detach): Ensure frame cache and
7258         register caches are cleared.
7259         inferior.c (exit_inferior_1): Likewise.
7260
7261 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7262             Tom Tromey  <tom@tromey.com>
7263
7264         * dictionary.c (collate_pending_symbols_by_language): Remove
7265         "struct" from foreach.
7266         * symtab.c (lookup_global_symbol_from_objfile)
7267         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7268         foreach.
7269         * ser-tcp.c (net_open): Remove "struct" from foreach.
7270         * objfiles.c (objfile_relocate, objfile_rebase)
7271         (objfile_has_symbols): Remove "struct" from foreach.
7272         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7273         from foreach.
7274         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7275         foreach.
7276         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7277         "struct" from foreach.
7278         * ada-lang.c (create_excep_cond_exprs)
7279         (ada_exception_catchpoint_cond_string): Remove "struct" from
7280         foreach.
7281
7282 2019-05-03  Tom Tromey  <tromey@adacore.com>
7283
7284         * ada-exp.y (convert_char_literal): Check suffix of each
7285         enumerator.
7286
7287 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7288
7289         PR ada/21406:
7290         * ada-exp.y (yywrap): Don't define.
7291         * ada-lex.l (%option): Add noyywrap
7292         (yywrap): Remove.
7293
7294 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7295
7296         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7297         _WIN32_WINNT to the XP level, unless already defined to a higher
7298         level.
7299
7300         * unittests/parse-connection-spec-selftests.c:
7301         * ser-tcp.c:
7302         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7303         override.
7304
7305         * symfile.c (find_separate_debug_file): Remove colon from the
7306         drive spec of DOS/Windows file names of the target, so that the
7307         file name produced from DEBUGDIR and the target's directory will
7308         be valid on DOS/Windows systems.
7309
7310 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7311
7312         * rust-lang.c (val_print_struct): Handle printing structures
7313         containing strings.
7314
7315 2019-05-02  Tom Tromey  <tromey@adacore.com>
7316
7317         * valarith.c (_initialize_valarith): Remove.
7318
7319 2019-05-01  Tom Tromey  <tromey@adacore.com>
7320
7321         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7322         bitfields.
7323
7324 2019-05-01  Tom Tromey  <tromey@adacore.com>
7325
7326         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7327         for big-endian copies.
7328
7329 2019-04-30  Ali Tamur  <tamur@google.com>
7330         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7331         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7332         (read_3_bytes): New function.
7333
7334 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7335
7336         * windows-nat.c (main_thread_id): Delete.
7337         (handle_output_debug_string): Replace main_thread_id by
7338         current_event.dwThreadId.
7339         (fake_create_process): Likewise.
7340         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7341         Do not set main_thread_id.
7342         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7343         current_event.dwThreadId.
7344         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7345
7346 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7347
7348         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7349         Use current_event.dwThreadId instead of main_thread_id.
7350
7351 2019-04-30  Tom Tromey  <tromey@adacore.com>
7352
7353         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7354         (create_excep_cond_exprs): Iterate over program spaces.
7355         (ada_exception_catchpoint_cond_string): Examine all minimal
7356         symbols for exception types.
7357
7358 2019-04-30  Tom Tromey  <tromey@adacore.com>
7359
7360         PR c++/24470:
7361         * dwarf2read.c (process_structure_scope): Handle case where type
7362         has template parameters but no symbol was created.
7363
7364 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7365             Chris January  <chris.january@arm.com>
7366
7367         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7368         qualifier.
7369         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7370
7371 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7372
7373         * f-typeprint.c (f_print_type): Update rules for printing
7374         whitespace.
7375         (f_type_print_varspec_suffix): Likewise.
7376
7377 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7378             Chris January  <chris.january@arm.com>
7379
7380         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7381         function arguments.
7382
7383 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7384
7385         * f-lang.c (build_fortran_types): Change name of void type to
7386         lower case.
7387         * f-typeprint.c (f_type_print_base): Print the name of the void
7388         type, rather than a fixed string.
7389         * f-valprint.c (f_decorations): Use lower case void string.
7390
7391 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7392             Chris January  <chris.january@arm.com>
7393
7394         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7395         types for Fortran.
7396
7397 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7398             Chris January  <chris.january@arm.com>
7399             David Lecomber  <david.lecomber@arm.com>
7400
7401         * f-exp.y (BINOP_INTRINSIC): New token.
7402         (exp): New parser rule handling BINOP_INTRINSIC.
7403         (f77_keywords): Add new builtin procedures.
7404         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7405         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7406         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7407         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7408         (print_unop_subexp_f): New function.
7409         (print_binop_subexp_f): New function.
7410         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7411         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7412         (dump_subexp_body_f): Likewise.
7413         (operator_check_f): Likewise.
7414         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7415         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7416
7417 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7418
7419         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7420         UNOP_KIND.
7421         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7422         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7423         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7424         (operator_length_f): New fuction.
7425         (print_subexp_f): New function.
7426         (op_name_f): New function.
7427         (dump_subexp_body_f): New function.
7428         (operator_check_f): New function.
7429         (exp_descriptor_f): Replace standard expression handling functions
7430         with new functions.
7431         * gdb/fortran-operator.def: New file.
7432         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7433         * gdb/std-operator.def: Remove UNOP_KIND.
7434
7435 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7436
7437         * std-operator.def: Remove unbalanced, stray double quote
7438         character.
7439
7440 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7441             Chris January  <chris.january@arm.com>
7442             Daniel Everett  <daniel.everett@arm.com>
7443             Nick Forrington  <nick.forrington@arm.com>
7444             Richard Bunt  <richard.bunt@arm.com>
7445
7446         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7447         of depth when printing anonymous structs or unions.
7448         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7449         Don't print either the top-level value, or the children if the
7450         max-depth is exceeded.
7451         (ppscm_print_children): When printing the key of a map, allow one
7452         extra level of depth.
7453         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7454         print either the top-level value, or the children if the max-depth
7455         is exceeded.
7456         (print_children): When printing the key of a map, allow one extra
7457         level of depth.
7458         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7459         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7460         (user_print_options): Initialise max_depth field.
7461         (val_print_scalar_or_string_type_p): New function.
7462         (val_print): Check to see if the max depth has been reached.
7463         (val_print_check_max_depth): Define new function.
7464         (show_print_max_depth): New function.
7465         (_initialize_valprint): Add 'print max-depth' option.
7466         * valprint.h (struct value_print_options) <max_depth>: New field.
7467         (val_print_check_max_depth): Declare new function.
7468         * NEWS: Document new feature.
7469
7470 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7471
7472         * ada-lang.c (ada_language_defn): Initialise new field.
7473         * c-lang.c (c_is_string_type_p): New function.
7474         (c_language_defn): Initialise new field.
7475         (cplus_language_defn): Initialise new field.
7476         (asm_language_defn): Initialise new field.
7477         (minimal_language_defn): Initialise new field.
7478         * c-lang.h (c_is_string_type_p): Declare new function.
7479         * d-lang.c (d_language_defn): Initialise new field.
7480         * f-lang.c (f_is_string_type_p): New function.
7481         (f_language_defn): Initialise new field.
7482         * go-lang.c (go_is_string_type_p): New function.
7483         (go_language_defn): Initialise new field.
7484         * language.c (default_is_string_type_p): New function.
7485         (unknown_language_defn): Initialise new field.
7486         (auto_language_defn): Initialise new field.
7487         * language.h (struct language_defn) <la_is_string_type_p>: New
7488         member variable.
7489         (default_is_string_type_p): Declare new function.
7490         * m2-lang.c (m2_language_defn): Initialise new field.
7491         * objc-lang.c (objc_language_defn): Initialise new field.
7492         * opencl-lang.c (opencl_language_defn): Initialise new field.
7493         * p-lang.c (pascal_is_string_type_p): New function.
7494         (pascal_language_defn): Initialise new field.
7495         * rust-lang.c (rust_is_string_type_p): New function.
7496         (rust_language_defn): Initialise new field.
7497
7498 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7499
7500         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7501         New field.
7502         * ada-lang.c (ada_language_defn): Initialise new field.
7503         * c-lang.c (c_language_defn): Likewise.
7504         (cplus_language_defn): Likewise.
7505         (asm_language_defn): Likewise.
7506         (minimal_language_defn): Likewise.
7507         * d-lang.c (d_language_defn): Likewise.
7508         * f-lang.c (f_language_defn): Likewise.
7509         * go-lang.c (go_language_defn): Likewise.
7510         * language.c (unknown_language_defn): Likewise.
7511         (auto_language_defn): Likewise.
7512         * m2-lang.c (m2_language_defn): Likewise.
7513         * objc-lang.c (objc_language_defn): Likewise.
7514         * opencl-lang.c (opencl_language_defn): Likewise.
7515         * p-lang.c (pascal_language_defn): Likewise.
7516         * rust-lang.c (rust_language_defn): Likewise.
7517
7518 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7519
7520         * ada-lang.c (ada_is_character_type): Change return type to bool.
7521         (ada_is_string_type): Likewise.
7522         * ada-lang.h (ada_is_character_type): Update declaration
7523         (ada_is_string_type): Likewise.
7524
7525 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7526
7527         Support style in 'frame|thread apply'
7528
7529         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7530         * record.c (record_start, record_stop): Update callers of
7531         execute_command_to_string with false.
7532         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7533         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7534         methods.
7535         (class string_file): New constructor with term_out parameter.
7536         Override methods term_out and can_emit_style_escape.  New member
7537         term_out.
7538         (class stdio_file): Override can_emit_style_escape.
7539         (class tee_file): Override term_out and can_emit_style_escape.
7540         * utils.h (can_emit_style_escape): Remove.
7541         * utils.c (can_emit_style_escape): Likewise.
7542         Update all callers of can_emit_style_escape (SOMESTREAM) to
7543         SOMESTREAM->can_emit_style_escape.
7544         * source-cache.c (source_cache::get_source_lines): Likewise.
7545         * stack.c (frame_apply_command_count): Call execute_command_to_string
7546         passing the term_out characteristic of the current gdb_stdout.
7547         * thread.c (thr_try_catch_cmd): Likewise.
7548         * top.c (execute_command_to_string): pass term_out parameter
7549         to construct the string_file for the command output.
7550         * ui-file.c (term_cli_styling): New function (most code moved
7551         from utils.c can_emit_style_escape).
7552         (string_file::string_file, string_file::can_emit_style_escape,
7553         stdio_file::can_emit_style_escape, tee_file::term_out,
7554         tee_file::can_emit_style_escape): New functions.
7555
7556 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7557
7558         * NEWS: Mention the new set|show may-call-functions.
7559         * infcall.c (may_call_functions_p): New variable.
7560         (show_may_call_functions_p): New function.
7561         (call_function_by_hand_dummy): Throws an error if not
7562         may-call-functions.
7563         (_initialize_infcall): Call add_setshow_boolean_cmd for
7564         may-call-functions.
7565
7566 2019-04-25  Keith Seitz  <keiths@redhat.com>
7567
7568         PR c++/24367
7569         * cp-support.c (inspect_type): Don't attempt substitutions
7570         of symbol with the same name.
7571
7572 2019-04-25  Tom Tromey  <tromey@adacore.com>
7573
7574         PR gdb/24475:
7575         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7576         static.
7577
7578 2019-04-25  Tom Tromey  <tromey@adacore.com>
7579
7580         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7581         rvalue reference.
7582         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7583         (gdb_xml_parser::parse): Use std::move.
7584         * python/python-internal.h (gdbpy_convert_exception): Take a const
7585         reference.
7586         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7587         std::move.
7588         * python/py-utils.c (gdbpy_convert_exception): Take a const
7589         reference.
7590         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7591         Use std::move.
7592         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7593         Use std::move.
7594         * mi/mi-main.c (mi_print_exception): Take a const reference.
7595         * main.c (handle_command_errors): Take a const reference.
7596         * linespec.c (parse_linespec): Use std::move.
7597         * infcall.c (run_inferior_call): Use std::move.
7598         (call_function_by_hand_dummy): Use std::move.
7599         * exec.c (try_open_exec_file): Use std::move.
7600         * exceptions.h (exception_print, exception_fprintf)
7601         (exception_print_same): Update.
7602         * exceptions.c (print_exception, exception_print)
7603         (exception_fprintf, exception_print_same): Change parameters to
7604         const reference.
7605         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7606         * common/new-op.c: Use std::move.
7607         * common/common-exceptions.h (struct gdb_exception): Add move
7608         constructor.
7609         (struct gdb_exception_error, struct gdb_exception_quit, struct
7610         gdb_quit_bad_alloc): Change constructor to move constructor.
7611         (throw_exception): Change parameter to rvalue reference.
7612         * common/common-exceptions.c (throw_exception): Take rvalue
7613         reference.
7614         * cli/cli-interp.c (safe_execute_command): Use std::move.
7615         * breakpoint.c (insert_bp_location, location_to_sals): Use
7616         std::move.
7617
7618 2019-04-25  Tom Tromey  <tromey@adacore.com>
7619
7620         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7621         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7622         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7623         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7624         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7625         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7626         guile/scm-value.c: Use unpack.
7627         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7628         gdbscm_gdb_exception.
7629         (gdbscm_throw_gdb_exception): Likewise.
7630         (struct gdbscm_gdb_exception): New.
7631         (unpack): New function.
7632         (gdbscm_wrap): Use unpack.
7633
7634 2019-04-25  Tom Tromey  <tromey@adacore.com>
7635
7636         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7637         (gdb_rl_callback_handler): Use std::move.
7638         * common/common-exceptions.h (struct gdb_exception): Add move
7639         assignment operator.
7640         (throw_exception_sjlj): Change "exception" to const reference.
7641         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7642         (throw_exception_sjlj): Change "exception" to const reference.
7643
7644 2019-04-25  Tom Tromey  <tromey@adacore.com>
7645
7646         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7647         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7648         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7649         Update.
7650         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7651         Update.
7652         * mi/mi-interp.c (mi_interp::exec): Update.
7653         * linespec.c (parse_linespec): Update.
7654         * infcall.c (run_inferior_call): Update.
7655         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7656         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7657         (gdbscm_lookup_global_symbol): Update.
7658         * guile/scm-param.c (gdbscm_parameter_value): Update.
7659         * guile/scm-frame.c (gdbscm_frame_read_register)
7660         (gdbscm_frame_read_var): Update.
7661         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7662         * exec.c (try_open_exec_file): Update.
7663         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7664         (gdb_rl_callback_handler): Update.
7665         * common/common-exceptions.h (exception_none): Don't declare.
7666         * common/common-exceptions.c (exception_none): Don't define.
7667         (struct catcher) <exception>: Update.
7668         * cli/cli-interp.c (safe_execute_command): Update.
7669         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7670
7671 2019-04-25  Ali Tamur  <tamur@google.com>
7672
7673         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7674         (read_attribute_value): Likewise.
7675         (dwarf2_read_addr_index): Update comment.
7676         (read_str_index): Add DW_FORM_strx.
7677         (dwarf2_string_attr): Likewise.
7678         (dwarf2_const_value_attr): Likewise.
7679         (dump_die_shallow): Likewise.
7680         (dwarf2_fetch_constant_bytes): Likewise.
7681         (skip_form_bytes): Likewise.
7682         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7683
7684 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7685
7686         PR corefiles/11608
7687         PR corefiles/18187
7688         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7689         OFFSET.  Verify if current mapping contains an ELF header.
7690         (linux_find_memory_regions_full): Adjust call to
7691         dump_mapping_p.
7692
7693 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7694             Kang Li <kanglictf@gmail.com>
7695
7696         PR gdb/21600
7697
7698         * dwarf2-frame.c (read_initial_length): Be consistent about using
7699         unsigned representation of length.
7700         (decode_frame_entry_1): Likewise.  Check for wraparound of
7701         end pointer as well as buffer overflow.
7702
7703 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7704
7705         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7706         "vq".
7707
7708 2019-04-24  Tom Tromey  <tromey@adacore.com>
7709
7710         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7711
7712 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7713
7714         * s12z-tdep.c (s12z_unwind_pc): Delete.
7715         (s12z_unwind_sp): Delete.
7716         (s12z_gdbarch_init): Don't register deleted functions with
7717         gdbarch.
7718
7719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7720
7721         * rl78-tdep.c (rl78_unwind_sp): Delete.
7722         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7723
7724 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7725
7726         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7727         (xstormy16_unwind_pc): Delete.
7728         (xstormy16_dummy_id): Delete.
7729         (xstormy16_gdbarch_init): Don't register deleted functions with
7730         gdbarch.
7731
7732 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7733
7734         * vax-tdep.c (vax_unwind_pc): Delete.
7735         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7736
7737 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7738
7739         * v850-tdep.c (v850_unwind_sp): Delete.
7740         (v850_unwind_pc): Delete.
7741         (v850_dummy_id): Delete.
7742         (v850_gdbarch_init): Don't register deleted functions with
7743         gdbarch.
7744
7745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7746
7747         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7748         (tilegx_unwind_pc): Delete.
7749         (tilegx_unwind_dummy_id): Delete.
7750         (tilegx_gdbarch_init): Don't register deleted functions with
7751         gdbarch.
7752
7753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7754
7755         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7756         (tic6x_dummy_id): Delete.
7757         (tic6x_gdbarch_init): Don't register deleted functions with
7758         gdbarch.
7759
7760 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7761
7762         * sparc-tdep.c (sparc_unwind_pc): Delete.
7763         (sparc32_gdbarch_init): Don't register deleted function with
7764         gdbarch.
7765
7766 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7767
7768         * sh-tdep.c (sh_unwind_sp): Delete.
7769         (sh_unwind_pc): Delete.
7770         (sh_dummy_id): Delete.
7771         (sh_gdbarch_init): Don't register deleted functions with
7772         gdbarch.
7773
7774 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7775
7776         * score-tdep.c (score_unwind_sp): Delete.
7777         (score_unwind_pc): Delete.
7778         (score_dummy_id): Delete.
7779         (score_gdbarch_init): Don't register deleted functions with
7780         gdbarch.
7781
7782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7783
7784         * rx-tdep.c (rx_unwind_pc): Delete.
7785         (rx_unwind_sp): Delete.
7786         (rx_dummy_id): Delete.
7787         (rx_gdbarch_init): Don't register deleted functions with
7788         gdbarch.  Update comment.
7789
7790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7791
7792         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7793         (rs6000_dummy_id): Delete.
7794         (rs6000_gdbarch_init): Don't register deleted functions with
7795         gdbarch.
7796
7797 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7798
7799         * or1k-tdep.c (or1k_dummy_id): Delete.
7800         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7801
7802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7803
7804         * nios2-tdep.c (nios2_dummy_id): Delete.
7805         (nios2_unwind_sp): Delete.
7806         (nios2_gdbarch_init): Don't register deleted functions with
7807         gdbarch.
7808
7809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7810
7811         * nds32-tdep.c (nds32_dummy_id): Delete.
7812         (nds32_unwind_pc): Delete.
7813         (nds32_unwind_sp): Delete.
7814         (nds32_gdbarch_init): Don't register deleted functions with
7815         gdbarch.
7816
7817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7818
7819         * msp430-tdep.c (msp430_unwind_pc): Delete.
7820         (msp430_unwind_sp): Delete.
7821         (msp430_dummy_id): Delete.
7822         (msp430_gdbarch_init): Don't register deleted functions with
7823         gdbarch.
7824
7825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7826
7827         * moxie-tdep.c (moxie_unwind_sp): Delete.
7828         (moxie_unwind_pc): Delete.
7829         (moxie_dummy_id): Delete.
7830         (moxie_gdbarch_init): Don't register deleted functions with
7831         gdbarch.
7832
7833 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7834
7835         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7836         (mn10300_unwind_pc): Delete.
7837         (mn10300_unwind_sp): Delete.
7838         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7839         mn10300_unwind_sp.
7840         (mn10300_frame_unwind_init): Don't register deleted functions with
7841         gdbarch.
7842
7843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7844
7845         * mep-tdep.c (mep_unwind_pc): Delete.
7846         (mep_unwind_sp): Delete.
7847         (mep_dummy_id): Delete.
7848         (mep_gdbarch_init): Don't register deleted functions with
7849         gdbarch.
7850
7851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7852
7853         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7854         (m68hc11_unwind_sp): Delete.
7855         (m68hc11_gdbarch_init): Don't register deleted functions with
7856         gdbarch.
7857
7858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7859
7860         * m32r-tdep.c (m32r_unwind_sp): Delete.
7861         (m32r_unwind_pc): Delete.
7862         (m32r_dummy_id): Delete.
7863         (m32r_gdbarch_init): Don't register deleted functions with
7864         gdbarch.
7865
7866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7867
7868         * m32c-tdep.c (m32c_unwind_pc): Delete.
7869         (m32c_unwind_sp): Delete.
7870         (m32c_dummy_id): Delete.
7871         (m32c_gdbarch_init): Don't register deleted functions with
7872         gdbarch.
7873
7874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7875
7876         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7877         (lm32_unwind_pc): Delete.
7878         (lm32_dummy_id): Delete.
7879         (lm32_gdbarch_init): Don't register deleted functions with
7880         gdbarch.
7881
7882 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7883
7884         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7885         (iq2000_unwind_pc): Delete.
7886         (iq2000_dummy_id): Delete.
7887         (iq2000_gdbarch_init): Don't register deleted functions with
7888         gdbarch.
7889
7890 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7891
7892         * nds32-tdep.c (nds32_type_align): Delete.
7893         (nds32_push_dummy_call): Use type_align instead.
7894
7895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7896
7897         * arm-tdep.c (arm_type_align): Only handle vector override case.
7898         (arm_push_dummy_call): Use type_align.
7899         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7900
7901 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7902
7903         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7904         case.
7905         (pass_on_stack): Use type_align.
7906         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7907         function.
7908
7909 2019-04-23  Tom Tromey  <tromey@adacore.com>
7910
7911         * dwarf2read.c (line_header::file_name_at): Remove unused
7912         overload.
7913
7914 2019-04-23  Tom de Vries  <tdevries@suse.de>
7915
7916         PR gdb/24438
7917         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7918         invocation.
7919
7920
7921 2019-03-27  Ali Tamur  <tamur@google.com>
7922
7923         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7924         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7925         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7926         (dwarf_expr_context::get_addr_index): Likewise
7927         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7928         (symbol_needs_eval_context::get_addr_index): Likewise
7929         (disassemble_dwarf_expression): Add DW_OP_addrx
7930         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7931         (read_cutu_die_from_dwo): Update comment
7932         (skip_one_die): Add DW_FORM_addrx
7933         (read_attribute_value): Likewise
7934         (var_decode_location): Add DW_OP_addrx
7935         (dwarf2_const_value_attr): Add DW_FORM_addrx
7936         (dump_die_shallow): Likewise
7937         (dwarf2_fetch_constant_bytes): Likewise
7938         (decode_locdesc): Add DW_OP_addrx
7939         (skip_form_bytes): Add DW_FORM_addrx
7940
7941 2019-04-22  Ali Tamur  <tamur@google.com>
7942
7943         * MAINTAINERS (Write After Approval): Add self.
7944
7945 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7946
7947         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7948         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7949         (open_symbol_file_object): Likewise.
7950         (svr4_default_sos): Add info parameter.
7951         (svr4_read_so_list): Likewise.
7952         (svr4_current_sos_direct): Adjust functions calls to pass down
7953         info.
7954         (svr4_current_sos_1): Add info parameter.
7955         (svr4_current_sos): Call get_svr4_info, pass info down to
7956         svr4_current_sos_1.
7957         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7958         get_svr4_info.
7959         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7960         get_svr4_info.
7961         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7962         to get_svr4_info.
7963         (probes_table_remove_objfile_probes): Likewise.
7964         (register_solib_event_probe): Add info parameter.
7965         (solist_update_incremental): Pass info parameter down to
7966         svr4_read_so_list.
7967         (disable_probes_interface): Add info parameter.
7968         (svr4_handle_solib_event): Pass current_program_space to
7969         get_svr4_info.  Adjust disable_probes_interface cleanup.
7970         (svr4_create_probe_breakpoints): Add info parameter, pass it
7971         down to register_solib_event_probe.
7972         (svr4_create_solib_event_breakpoints): Add info parameter,
7973         pass it down to svr4_create_probe_breakpoints.
7974         (enable_break): Pass info down to
7975         svr4_create_solib_event_breakpoints.
7976         (svr4_solib_create_inferior_hook): Pass current_program_space to
7977         get_svr4_info.
7978         (svr4_clear_solib): Likewise.
7979
7980 2019-04-22  Pedro Alves  <palves@redhat.com>
7981
7982         * solib-svr4.c (svr4_free_objfile_observer): New.
7983         (probe_and_action::objfile): New field.
7984         (probes_table_htab_remove_objfile_probes)
7985         (probes_table_remove_objfile_probes): New functions.
7986         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7987         in the new probe_and_action.  Don't store the probe in 'lookup'.
7988         (svr4_create_probe_breakpoints): Pass objfile to
7989         register_solib_event_probe.
7990         (_initialize_svr4_solib): Register a free_objfile observer.
7991
7992 2019-04-19  Tom Tromey  <tom@tromey.com>
7993
7994         * common/queue.h: Remove.
7995
7996 2019-04-19  Tom Tromey  <tom@tromey.com>
7997
7998         * event-loop.c: Don't include "common/queue.h".
7999
8000 2019-04-19  Tom Tromey  <tom@tromey.com>
8001
8002         * remote.c (remote_target): Use delete.
8003         * remote-notif.h: Include <list>, not "common/queue.h".
8004         (notif_client_p): Remove typedef.
8005         (remote_notif_state): Add constructor, destructor, initializer.
8006         <notif_queue>: Now a std::list.
8007         (remote_notif_state_xfree): Don't declare.
8008         * remote-notif.c (remote_notif_process, handle_notification)
8009         (remote_notif_state_allocate): Update.
8010         (~remote_notif_state): Rename from remote_notif_state_xfree.
8011
8012 2019-04-19  Tom Tromey  <tom@tromey.com>
8013
8014         * symfile.c (reread_symbols): Update.
8015         * objfiles.c (objfile_register_static_link)
8016         (objfile_lookup_static_link): Update
8017         (~objfile) Don't delete static_links.
8018         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8019
8020 2019-04-19  Tom Tromey  <tom@tromey.com>
8021
8022         * type-stack.h (struct type_stack) <insert>: Constify string.
8023         * type-stack.c (type_stack::insert): Constify string.
8024         * gdbtypes.h (lookup_template_type): Update.
8025         (address_space_name_to_int): Update.
8026         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8027         const.
8028         (lookup_template_type): Make name const.
8029         * c-exp.y: Update rules.
8030         (lex_one_token, classify_name, classify_inner_name)
8031         (c_print_token): Update.
8032         * p-exp.y: Update rules.
8033         (yylex): Update.
8034         * f-exp.y: Update rules.
8035         (yylex): Update.
8036         * d-exp.y: Update rules.
8037         (lex_one_token, classify_name, classify_inner_name): Update.
8038         * parse.c (write_dollar_variable, copy_name): Return std::string.
8039         * parser-defs.h (copy_name): Change return type.
8040         * m2-exp.y: Update rules.
8041         (yylex): Update.
8042         * go-exp.y (lex_one_token): Update.
8043         Update rules.
8044         (classify_unsafe_function, classify_packaged_name)
8045         (classify_name, yylex): Update.
8046
8047 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8048
8049         * configure.ac: add --enable-source-highlight switch.
8050         * configure: Regenerate.
8051         * top.c (print_gdb_version): plumb --enable-source-highlight
8052         status to "show configuration".
8053
8054 2019-04-19  Tom Tromey  <tromey@adacore.com>
8055
8056         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8057         Check ADA_TYPE_P.
8058         (empty_record, ada_template_to_fixed_record_type_1)
8059         (template_to_static_fixed_type)
8060         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8061         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8062         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8063         macros.
8064
8065 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8066
8067         PR symtab/24423:
8068         * source.c (print_source_lines_base): Advance "iter" when a
8069         control character is seen.
8070
8071 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8072
8073         * inferior.h (struct infcall_suspend_state_deleter):
8074         Catch exception in destructor to avoid crash.
8075
8076 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8077
8078         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8079         close to the add_com "shell".
8080
8081 2019-04-18  Tom Tromey  <tromey@adacore.com>
8082
8083         * process-stratum-target.h (class process_stratum_target)
8084         <stratum>: Add "final".
8085
8086 2019-04-17  Tom Tromey  <tromey@adacore.com>
8087
8088         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8089         against nullptr before use.
8090
8091 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8092
8093         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8094
8095 2019-04-17  Jim Wilson  <jimw@sifive.com>
8096             Andrew Burgess  <andrew.burgess@embecosm.com>
8097
8098         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8099         code read might fail, assume 4-byte breakpoint in that case.
8100
8101 2019-04-15  Leszek Swirski  <leszeks@google.com>
8102
8103         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8104         rather than a hand-rolled POD check when checking for forced MEMORY
8105         classification.
8106
8107 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8108
8109         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8110         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8111         function.
8112         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8113         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8114         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8115         declaration.
8116
8117 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8118
8119         * aarch64-linux-nat.c
8120         (aarch64_linux_nat_target::thread_architecture): Add override.
8121         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8122         each VQ.
8123
8124 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8125
8126         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8127
8128 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8129
8130         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8131         target types of size 96-bits, add some additional comments, and
8132         check that the builtin type we found was the correct size.
8133
8134 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8135
8136         * utils.c (prompt_for_continue): Don't restore the styling at the
8137         end, as applied_style has the wrong value.  This fixes styling in
8138         long lists of file names that are interrupted by the "Continue?"
8139         prompt.
8140
8141 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8142
8143         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8144         * c-lang.c (c_language_defn): Likewise.
8145         (cplus_language_defn): Likewise.
8146         (asm_language_defn): Likewise.
8147         (minimal_language_defn): Likewise.
8148         * d-lang.c (d_language_defn): Likewise.
8149         * f-lang.c (f_language_defn): Likewise.
8150         * go-lang.c (go_language_defn): Likewise.
8151         * language.c (unknown_language_defn): Likewise.
8152         (auto_language_defn): Likewise.
8153         * language.h (struct language_defn): Remove la_magic field.
8154         (LANG_MAGIC): Delete.
8155         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8156         * objc-lang.c (objc_language_defn): Likewise.
8157         * opencl-lang.c (opencl_language_defn): Likewise.
8158         * p-lang.c (pascal_language_defn): Likewise.
8159         * rust-lang.c (rust_language_defn): Likewise.
8160
8161 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8162
8163         * riscv-tdep.c (riscv_type_align): New function.
8164         (riscv_type_alignment): Delete.
8165         (riscv_arg_location): Use 'type_align'.
8166         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8167
8168 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8169
8170         * gdbtypes.c (type_align): A struct with no non-static fields also
8171         has alignment of 1.
8172
8173 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8174
8175         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8176         component to 0.
8177         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8178         member.
8179         (riscv_struct_info::analyse): New implementation using new
8180         analyse_inner member function.
8181         (riscv_struct_info::field_offset): New member function.
8182         (riscv_struct_info::m_offsets): New member variable.
8183         (riscv_struct_info::analyse_inner): New private member function,
8184         takes the old implementation of riscv_struct_info::analyse but
8185         extended to track field offsets.
8186         (riscv_call_arg_struct): Update the struct folding special cases
8187         to handle cases where empty C++ structs, which are non-zero
8188         length, are found.
8189         (riscv_arg_location): Initialise the length of each location, a
8190         non-zero length now indicates the location is in use.
8191         (riscv_push_dummy_call): Allow for the first location having a
8192         non-zero offset when setting up arguments.
8193         (riscv_return_value): Likewise, but for return values.
8194
8195 2019-04-11  Tom Tromey  <tromey@adacore.com>
8196
8197         * utils.c (internal_vproblem): Make "msg" const.
8198
8199 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8200
8201         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8202         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8203         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8204         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8205
8206 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8207
8208         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8209         function.
8210         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8211         of amd64_collect_native_gregset.
8212         (amd64_linux_nat_target::store_registers): Likewise.
8213
8214 2019-04-10  Tom Tromey  <tom@tromey.com>
8215
8216         * symtab.c (lookup_global_symbol_from_objfile)
8217         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8218         * objfiles.h (class separate_debug_iterator): New.
8219         (class separate_debug_range): New.
8220         (struct objfile) <separate_debug_objfiles>: New method.
8221         (objfile_separate_debug_iterate): Don't declare.
8222         * objfiles.c (separate_debug_iterator::operator++): Rename from
8223         objfile_separate_debug_iterate.
8224         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8225         iterator.
8226         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8227         iterator.
8228
8229 2019-04-10  Tom Tromey  <tom@tromey.com>
8230
8231         * symfile.c (reread_symbols): Remove old comment.
8232         * objfiles.c (free_all_objfiles): Fix a typo.
8233
8234 2019-04-10  Tom Tromey  <tom@tromey.com>
8235
8236         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8237         * minsyms.c (lookup_minimal_symbol): Use foreach.
8238         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8239         (lookup_minimal_symbol_solib_trampoline): Likewise.
8240         * symfile.c (reread_symbols): Use foreach.
8241
8242 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8243             Tom Tromey  <tromey@adacore.com>
8244
8245         PR rust/24414:
8246         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8247         (rust_lex_int_test): Change "value" to be LONGEST.
8248         (rust_lex_tests): Add test for long integer literal.
8249
8250 2019-04-09  Tom Tromey  <tromey@adacore.com>
8251
8252         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8253         to bool.
8254         (extended_remote_target::attach): Update.
8255         (remote_target::remote_notice_new_inferior): Update.
8256         (remote_target::add_current_inferior_and_thread): Update.
8257         * inferior.c (exit_inferior_1): Use "false".
8258         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8259
8260 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8261
8262         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8263         the "start" command.
8264
8265 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8266
8267         * python/py-inferior.c (infpy_thread_from_thread_handle):
8268         Adjust comments to reflect renaming of thread_from_thread_handle
8269         to thread_from_handle.  Adjust keywords.  Fix type error message.
8270         (inferior_object_methods): Add thread_from_handle.  Retain
8271         thread_from_thread_handle, but mark it as deprecated.
8272
8273 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8274
8275         * gdbthread.h (find_thread_by_handle): Revise declaration.
8276         * thread.c (find_thread_by_handle): Likewise.  Adjust
8277         implementation too.
8278         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8279         support for buffer objects as handles.
8280
8281 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8282
8283         * python/py-infthread.c (thpy_thread_handle): New function.
8284         (thread_object_methods): Register thpy_thread_handle.
8285
8286 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8287
8288         * gdbthread.h (thread_to_thread_handle): Declare.
8289         * thread.c (gdbtypes.h): Include.
8290         (thread_to_thread_handle): New function.
8291
8292         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8293         (target_thread_info_to_thread_handle): Declare.
8294         * target.c (target_thread_info_to_thread_handle): New function.
8295         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8296         * target-delegates.c: Regenerate.
8297
8298         * linux-thread-db.c (class thread_db_target): Add method
8299         thread_info_to_thread_handle.
8300         (thread_db_target::thread_info_to_thread_handle): Define.
8301         * remote.c (class remote_target): Add new method
8302         thread_info_to_thread_handle.
8303         (remote_target::thread_info_to_thread_handle): Define.
8304
8305 2019-04-08  Pedro Alves  <palves@redhat.com>
8306
8307         * common/common-exceptions.c (throw_exception): Don't create
8308         named object to throw; throw directly.
8309         (throw_it): Likewise.  Don't initialize gdb_exception::message
8310         here, with new; pass FMT and AP to the ctor instead.
8311         * common/common-exceptions.h: Include <string>.
8312         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8313         const char *, va_list)): New ctor.  Use std::make_shared.
8314         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8315         errors)): Delete.
8316         (gdb_exception_error::gdb_exception_error(enum errors, const char
8317         *, va_list)): New.
8318         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8319         Add assertion.
8320         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8321         errors)): Delete.
8322         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8323         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8324         Add assertion.
8325
8326 2019-04-08  Tom Tromey  <tom@tromey.com>
8327
8328         * valops.c (value_rtti_indirect_type): Replace throw_exception
8329         with throw.
8330         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8331         with throw.
8332         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8333         throw.
8334         * target.c (target_translate_tls_address): Replace throw_exception
8335         with throw.
8336         * stack.c (frame_apply_command_count): Replace throw_exception
8337         with throw.
8338         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8339         throw.
8340         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8341         with throw.
8342         * rs6000-tdep.c (rs6000_frame_cache)
8343         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8344         * remote.c: Replace throw_exception with throw.
8345         * record-full.c (record_full_message, record_full_wait_1)
8346         (record_full_restore): Replace throw_exception with throw.
8347         * record-btrace.c:
8348         (get_thread_current_frame_id, record_btrace_start_replaying)
8349         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8350         (cmd_record_btrace_start): Replace throw_exception with throw.
8351         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8352         throw.
8353         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8354         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8355         * linespec.c:
8356         (find_linespec_symbols): Replace throw_exception with throw.
8357         * infrun.c (displaced_step_prepare, resume): Replace
8358         throw_exception with throw.
8359         * infcmd.c (post_create_inferior): Replace throw_exception with
8360         throw.
8361         * inf-loop.c (inferior_event_handler): Replace throw_exception
8362         with throw.
8363         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8364         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8365         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8366         (get_prev_frame_always, get_frame_pc_if_available)
8367         (get_frame_address_in_block_if_available, get_frame_language):
8368         Replace throw_exception with throw.
8369         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8370         throw_exception with throw.
8371         * eval.c (fetch_subexp_value, evaluate_var_value)
8372         (evaluate_funcall, evaluate_subexp_standard): Replace
8373         throw_exception with throw.
8374         * dwarf2loc.c (call_site_find_chain)
8375         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8376         Replace throw_exception with throw.
8377         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8378         with throw.
8379         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8380         throw.
8381         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8382         * completer.c (complete_line_internal): Replace throw_exception
8383         with throw.
8384         * compile/compile-object-run.c (compile_object_run): Replace
8385         throw_exception with throw.
8386         * cli/cli-script.c (process_next_line): Replace throw_exception
8387         with throw.
8388         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8389         (btrace_enable, btrace_maint_update_pt_packets): Replace
8390         throw_exception with throw.
8391         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8392         throw_exception with throw.
8393         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8394         throw_exception with throw.
8395         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8396         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8397         * aarch64-tdep.c (aarch64_make_prologue_cache)
8398         (aarch64_make_stub_cache): Replace throw_exception with throw.
8399
8400 2019-04-08  Tom Tromey  <tom@tromey.com>
8401
8402         * common/common-exceptions.c (throw_exception): Rename from
8403         throw_exception_cxx.  Remove old copy.  Make argument const.
8404         (throw_it): Create and throw exception objects directly.
8405         * common/common-exceptions.h (throw_exception): Make argument
8406         const.
8407         (struct gdb_exception_error): Add constructor.
8408         (struct gdb_exception_quit): Add constructor.
8409
8410 2019-04-08  Tom Tromey  <tom@tromey.com>
8411
8412         * common/common-exceptions.h (exception_rethrow): Don't declare.
8413         (TRY_SJLJ): Update comment.
8414         (TRY, CATCH, END_CATCH): Remove.
8415         * common/common-exceptions.c (exception_rethrow): Remove.
8416
8417 2019-04-08  Tom Tromey  <tom@tromey.com>
8418
8419         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8420         Remove.
8421         (gdb_exception_error): Rename from
8422         gdb_exception_RETURN_MASK_ERROR.
8423         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8424         (gdb_quit_bad_alloc): Update.
8425         * aarch64-tdep.c: Update.
8426         * ada-lang.c: Update.
8427         * ada-typeprint.c: Update.
8428         * ada-valprint.c: Update.
8429         * amd64-tdep.c: Update.
8430         * arch-utils.c: Update.
8431         * break-catch-throw.c: Update.
8432         * breakpoint.c: Update.
8433         * btrace.c: Update.
8434         * c-varobj.c: Update.
8435         * cli/cli-cmds.c: Update.
8436         * cli/cli-interp.c: Update.
8437         * cli/cli-script.c: Update.
8438         * common/common-exceptions.c: Update.
8439         * common/new-op.c: Update.
8440         * common/selftest.c: Update.
8441         * compile/compile-c-symbols.c: Update.
8442         * compile/compile-cplus-symbols.c: Update.
8443         * compile/compile-object-load.c: Update.
8444         * compile/compile-object-run.c: Update.
8445         * completer.c: Update.
8446         * corelow.c: Update.
8447         * cp-abi.c: Update.
8448         * cp-support.c: Update.
8449         * cp-valprint.c: Update.
8450         * darwin-nat.c: Update.
8451         * disasm-selftests.c: Update.
8452         * dtrace-probe.c: Update.
8453         * dwarf-index-cache.c: Update.
8454         * dwarf-index-write.c: Update.
8455         * dwarf2-frame-tailcall.c: Update.
8456         * dwarf2-frame.c: Update.
8457         * dwarf2loc.c: Update.
8458         * dwarf2read.c: Update.
8459         * eval.c: Update.
8460         * event-loop.c: Update.
8461         * event-top.c: Update.
8462         * exec.c: Update.
8463         * f-valprint.c: Update.
8464         * fbsd-tdep.c: Update.
8465         * frame-unwind.c: Update.
8466         * frame.c: Update.
8467         * gdbtypes.c: Update.
8468         * gnu-v3-abi.c: Update.
8469         * guile/guile-internal.h: Update.
8470         * guile/scm-block.c: Update.
8471         * guile/scm-breakpoint.c: Update.
8472         * guile/scm-cmd.c: Update.
8473         * guile/scm-disasm.c: Update.
8474         * guile/scm-frame.c: Update.
8475         * guile/scm-lazy-string.c: Update.
8476         * guile/scm-math.c: Update.
8477         * guile/scm-param.c: Update.
8478         * guile/scm-ports.c: Update.
8479         * guile/scm-pretty-print.c: Update.
8480         * guile/scm-symbol.c: Update.
8481         * guile/scm-symtab.c: Update.
8482         * guile/scm-type.c: Update.
8483         * guile/scm-value.c: Update.
8484         * i386-linux-tdep.c: Update.
8485         * i386-tdep.c: Update.
8486         * inf-loop.c: Update.
8487         * infcall.c: Update.
8488         * infcmd.c: Update.
8489         * infrun.c: Update.
8490         * jit.c: Update.
8491         * language.c: Update.
8492         * linespec.c: Update.
8493         * linux-fork.c: Update.
8494         * linux-nat.c: Update.
8495         * linux-tdep.c: Update.
8496         * linux-thread-db.c: Update.
8497         * main.c: Update.
8498         * mi/mi-cmd-break.c: Update.
8499         * mi/mi-cmd-stack.c: Update.
8500         * mi/mi-interp.c: Update.
8501         * mi/mi-main.c: Update.
8502         * objc-lang.c: Update.
8503         * p-valprint.c: Update.
8504         * parse.c: Update.
8505         * ppc-linux-tdep.c: Update.
8506         * printcmd.c: Update.
8507         * python/py-arch.c: Update.
8508         * python/py-breakpoint.c: Update.
8509         * python/py-cmd.c: Update.
8510         * python/py-finishbreakpoint.c: Update.
8511         * python/py-frame.c: Update.
8512         * python/py-framefilter.c: Update.
8513         * python/py-gdb-readline.c: Update.
8514         * python/py-inferior.c: Update.
8515         * python/py-infthread.c: Update.
8516         * python/py-lazy-string.c: Update.
8517         * python/py-linetable.c: Update.
8518         * python/py-objfile.c: Update.
8519         * python/py-param.c: Update.
8520         * python/py-prettyprint.c: Update.
8521         * python/py-progspace.c: Update.
8522         * python/py-record-btrace.c: Update.
8523         * python/py-record.c: Update.
8524         * python/py-symbol.c: Update.
8525         * python/py-type.c: Update.
8526         * python/py-unwind.c: Update.
8527         * python/py-utils.c: Update.
8528         * python/py-value.c: Update.
8529         * python/python.c: Update.
8530         * record-btrace.c: Update.
8531         * record-full.c: Update.
8532         * remote-fileio.c: Update.
8533         * remote.c: Update.
8534         * riscv-tdep.c: Update.
8535         * rs6000-aix-tdep.c: Update.
8536         * rs6000-tdep.c: Update.
8537         * rust-exp.y: Update.
8538         * rust-lang.c: Update.
8539         * s390-tdep.c: Update.
8540         * selftest-arch.c: Update.
8541         * solib-dsbt.c: Update.
8542         * solib-frv.c: Update.
8543         * solib-spu.c: Update.
8544         * solib-svr4.c: Update.
8545         * solib.c: Update.
8546         * sparc64-linux-tdep.c: Update.
8547         * stack.c: Update.
8548         * symfile-mem.c: Update.
8549         * symmisc.c: Update.
8550         * target.c: Update.
8551         * thread.c: Update.
8552         * top.c: Update.
8553         * tracefile-tfile.c: Update.
8554         * tui/tui.c: Update.
8555         * typeprint.c: Update.
8556         * unittests/cli-utils-selftests.c: Update.
8557         * unittests/parse-connection-spec-selftests.c: Update.
8558         * valops.c: Update.
8559         * valprint.c: Update.
8560         * value.c: Update.
8561         * varobj.c: Update.
8562         * windows-nat.c: Update.
8563         * x86-linux-nat.c: Update.
8564         * xml-support.c: Update.
8565
8566 2019-04-08  Tom Tromey  <tom@tromey.com>
8567
8568         * xml-support.c: Use C++ exception handling.
8569         * x86-linux-nat.c: Use C++ exception handling.
8570         * windows-nat.c: Use C++ exception handling.
8571         * varobj.c: Use C++ exception handling.
8572         * value.c: Use C++ exception handling.
8573         * valprint.c: Use C++ exception handling.
8574         * valops.c: Use C++ exception handling.
8575         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8576         handling.
8577         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8578         * typeprint.c: Use C++ exception handling.
8579         * tui/tui.c: Use C++ exception handling.
8580         * tracefile-tfile.c: Use C++ exception handling.
8581         * top.c: Use C++ exception handling.
8582         * thread.c: Use C++ exception handling.
8583         * target.c: Use C++ exception handling.
8584         * symmisc.c: Use C++ exception handling.
8585         * symfile-mem.c: Use C++ exception handling.
8586         * stack.c: Use C++ exception handling.
8587         * sparc64-linux-tdep.c: Use C++ exception handling.
8588         * solib.c: Use C++ exception handling.
8589         * solib-svr4.c: Use C++ exception handling.
8590         * solib-spu.c: Use C++ exception handling.
8591         * solib-frv.c: Use C++ exception handling.
8592         * solib-dsbt.c: Use C++ exception handling.
8593         * selftest-arch.c: Use C++ exception handling.
8594         * s390-tdep.c: Use C++ exception handling.
8595         * rust-lang.c: Use C++ exception handling.
8596         * rust-exp.y: Use C++ exception handling.
8597         * rs6000-tdep.c: Use C++ exception handling.
8598         * rs6000-aix-tdep.c: Use C++ exception handling.
8599         * riscv-tdep.c: Use C++ exception handling.
8600         * remote.c: Use C++ exception handling.
8601         * remote-fileio.c: Use C++ exception handling.
8602         * record-full.c: Use C++ exception handling.
8603         * record-btrace.c: Use C++ exception handling.
8604         * python/python.c: Use C++ exception handling.
8605         * python/py-value.c: Use C++ exception handling.
8606         * python/py-utils.c: Use C++ exception handling.
8607         * python/py-unwind.c: Use C++ exception handling.
8608         * python/py-type.c: Use C++ exception handling.
8609         * python/py-symbol.c: Use C++ exception handling.
8610         * python/py-record.c: Use C++ exception handling.
8611         * python/py-record-btrace.c: Use C++ exception handling.
8612         * python/py-progspace.c: Use C++ exception handling.
8613         * python/py-prettyprint.c: Use C++ exception handling.
8614         * python/py-param.c: Use C++ exception handling.
8615         * python/py-objfile.c: Use C++ exception handling.
8616         * python/py-linetable.c: Use C++ exception handling.
8617         * python/py-lazy-string.c: Use C++ exception handling.
8618         * python/py-infthread.c: Use C++ exception handling.
8619         * python/py-inferior.c: Use C++ exception handling.
8620         * python/py-gdb-readline.c: Use C++ exception handling.
8621         * python/py-framefilter.c: Use C++ exception handling.
8622         * python/py-frame.c: Use C++ exception handling.
8623         * python/py-finishbreakpoint.c: Use C++ exception handling.
8624         * python/py-cmd.c: Use C++ exception handling.
8625         * python/py-breakpoint.c: Use C++ exception handling.
8626         * python/py-arch.c: Use C++ exception handling.
8627         * printcmd.c: Use C++ exception handling.
8628         * ppc-linux-tdep.c: Use C++ exception handling.
8629         * parse.c: Use C++ exception handling.
8630         * p-valprint.c: Use C++ exception handling.
8631         * objc-lang.c: Use C++ exception handling.
8632         * mi/mi-main.c: Use C++ exception handling.
8633         * mi/mi-interp.c: Use C++ exception handling.
8634         * mi/mi-cmd-stack.c: Use C++ exception handling.
8635         * mi/mi-cmd-break.c: Use C++ exception handling.
8636         * main.c: Use C++ exception handling.
8637         * linux-thread-db.c: Use C++ exception handling.
8638         * linux-tdep.c: Use C++ exception handling.
8639         * linux-nat.c: Use C++ exception handling.
8640         * linux-fork.c: Use C++ exception handling.
8641         * linespec.c: Use C++ exception handling.
8642         * language.c: Use C++ exception handling.
8643         * jit.c: Use C++ exception handling.
8644         * infrun.c: Use C++ exception handling.
8645         * infcmd.c: Use C++ exception handling.
8646         * infcall.c: Use C++ exception handling.
8647         * inf-loop.c: Use C++ exception handling.
8648         * i386-tdep.c: Use C++ exception handling.
8649         * i386-linux-tdep.c: Use C++ exception handling.
8650         * guile/scm-value.c: Use C++ exception handling.
8651         * guile/scm-type.c: Use C++ exception handling.
8652         * guile/scm-symtab.c: Use C++ exception handling.
8653         * guile/scm-symbol.c: Use C++ exception handling.
8654         * guile/scm-pretty-print.c: Use C++ exception handling.
8655         * guile/scm-ports.c: Use C++ exception handling.
8656         * guile/scm-param.c: Use C++ exception handling.
8657         * guile/scm-math.c: Use C++ exception handling.
8658         * guile/scm-lazy-string.c: Use C++ exception handling.
8659         * guile/scm-frame.c: Use C++ exception handling.
8660         * guile/scm-disasm.c: Use C++ exception handling.
8661         * guile/scm-cmd.c: Use C++ exception handling.
8662         * guile/scm-breakpoint.c: Use C++ exception handling.
8663         * guile/scm-block.c: Use C++ exception handling.
8664         * guile/guile-internal.h: Use C++ exception handling.
8665         * gnu-v3-abi.c: Use C++ exception handling.
8666         * gdbtypes.c: Use C++ exception handling.
8667         * frame.c: Use C++ exception handling.
8668         * frame-unwind.c: Use C++ exception handling.
8669         * fbsd-tdep.c: Use C++ exception handling.
8670         * f-valprint.c: Use C++ exception handling.
8671         * exec.c: Use C++ exception handling.
8672         * event-top.c: Use C++ exception handling.
8673         * event-loop.c: Use C++ exception handling.
8674         * eval.c: Use C++ exception handling.
8675         * dwarf2read.c: Use C++ exception handling.
8676         * dwarf2loc.c: Use C++ exception handling.
8677         * dwarf2-frame.c: Use C++ exception handling.
8678         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8679         * dwarf-index-write.c: Use C++ exception handling.
8680         * dwarf-index-cache.c: Use C++ exception handling.
8681         * dtrace-probe.c: Use C++ exception handling.
8682         * disasm-selftests.c: Use C++ exception handling.
8683         * darwin-nat.c: Use C++ exception handling.
8684         * cp-valprint.c: Use C++ exception handling.
8685         * cp-support.c: Use C++ exception handling.
8686         * cp-abi.c: Use C++ exception handling.
8687         * corelow.c: Use C++ exception handling.
8688         * completer.c: Use C++ exception handling.
8689         * compile/compile-object-run.c: Use C++ exception handling.
8690         * compile/compile-object-load.c: Use C++ exception handling.
8691         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8692         * compile/compile-c-symbols.c: Use C++ exception handling.
8693         * common/selftest.c: Use C++ exception handling.
8694         * common/new-op.c: Use C++ exception handling.
8695         * cli/cli-script.c: Use C++ exception handling.
8696         * cli/cli-interp.c: Use C++ exception handling.
8697         * cli/cli-cmds.c: Use C++ exception handling.
8698         * c-varobj.c: Use C++ exception handling.
8699         * btrace.c: Use C++ exception handling.
8700         * breakpoint.c: Use C++ exception handling.
8701         * break-catch-throw.c: Use C++ exception handling.
8702         * arch-utils.c: Use C++ exception handling.
8703         * amd64-tdep.c: Use C++ exception handling.
8704         * ada-valprint.c: Use C++ exception handling.
8705         * ada-typeprint.c: Use C++ exception handling.
8706         * ada-lang.c: Use C++ exception handling.
8707         * aarch64-tdep.c: Use C++ exception handling.
8708
8709 2019-04-08  Tom Tromey  <tom@tromey.com>
8710
8711         * xml-support.c (gdb_xml_parser::parse): Update.
8712         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8713         * value.c (show_convenience): Update.
8714         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8715         (test_parse_flags_qcs): Update.
8716         * thread.c (thr_try_catch_cmd): Update.
8717         * target.c (target_translate_tls_address): Update.
8718         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8719         (info_frame_command_core, frame_apply_command_count): Update.
8720         * rust-exp.y (rust_lex_exception_test): Update.
8721         * riscv-tdep.c (riscv_print_one_register_info): Update.
8722         * remote.c (remote_target::enable_btrace): Update.
8723         * record-btrace.c (record_btrace_enable_warn): Update.
8724         * python/py-utils.c (gdbpy_convert_exception): Update.
8725         * printcmd.c (do_one_display, print_variable_and_value): Update.
8726         * mi/mi-main.c (mi_print_exception): Update.
8727         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8728         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8729         * linux-nat.c (linux_nat_target::attach): Update.
8730         * linux-fork.c (class scoped_switch_fork_info): Update.
8731         * infrun.c (displaced_step_prepare): Update.
8732         * infcall.c (call_function_by_hand_dummy): Update.
8733         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8734         * gnu-v3-abi.c (print_one_vtable): Update.
8735         * frame.c (get_prev_frame_always): Update.
8736         * f-valprint.c (info_common_command_for_block): Update.
8737         * exec.c (try_open_exec_file): Update.
8738         * exceptions.c (print_exception, exception_print)
8739         (exception_fprintf, exception_print_same): Update.
8740         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8741         * dwarf-index-cache.c (index_cache::store)
8742         (index_cache::lookup_gdb_index): Update.
8743         * darwin-nat.c (maybe_cache_shell): Update.
8744         * cp-valprint.c (cp_print_value_fields): Update.
8745         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8746         (gcc_cplus_symbol_address): Update.
8747         * compile/compile-c-symbols.c (gcc_convert_symbol)
8748         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8749         * common/selftest.c: Update.
8750         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8751         a std::string.
8752         (exception_try_scope_entry, exception_try_scope_exit): Don't
8753         declare.
8754         (struct exception_try_scope): Remove.
8755         (TRY): Don't use exception_try_scope.
8756         (struct gdb_exception): Add constructor, operator=.
8757         <what>: New method.
8758         (struct gdb_exception_RETURN_MASK_ALL)
8759         (struct gdb_exception_RETURN_MASK_ERROR)
8760         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8761         (struct gdb_quit_bad_alloc): Update.
8762         * common/common-exceptions.c (exception_none): Change
8763         initializer.
8764         (struct catcher) <state, exception>: Initialize inline.
8765         <prev>: Remove member.
8766         (current_catcher): Remove.
8767         (catchers): New global.
8768         (exceptions_state_mc_init): Simplify.
8769         (catcher_pop): Remove.
8770         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8771         (try_scope_depth, exception_try_scope_entry)
8772         (exception_try_scope_exit): Remove.
8773         (throw_exception_sjlj): Update.
8774         (exception_messages, exception_messages_size): Remove.
8775         (throw_it): Simplify.
8776         (gdb_exception_sliced_copy): Remove.
8777         (throw_exception_cxx): Update.
8778         * cli/cli-script.c (script_from_file): Update.
8779         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8780         Update.
8781         * ada-valprint.c (ada_val_print): Update.
8782         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8783         (create_excep_cond_exprs): Update.
8784
8785 2019-04-08  Tom Tromey  <tom@tromey.com>
8786
8787         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8788         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8789         (TRY, CATCH, END_CATCH): Remove some definitions.
8790         * common/common-exceptions.c: Don't use GDB_XCPT.
8791         (catcher_list_size): Remove.
8792         (throw_exception, throw_it): Simplify.
8793
8794 2019-04-05  Tom Tromey  <tom@tromey.com>
8795
8796         Revert the header-sorting patch.
8797         * ft32-tdep.c: Revert.
8798         * frv-tdep.c: Revert.
8799         * frv-linux-tdep.c: Revert.
8800         * frame.c: Revert.
8801         * frame-unwind.c: Revert.
8802         * frame-base.c: Revert.
8803         * fork-child.c: Revert.
8804         * findvar.c: Revert.
8805         * findcmd.c: Revert.
8806         * filesystem.c: Revert.
8807         * filename-seen-cache.h: Revert.
8808         * filename-seen-cache.c: Revert.
8809         * fbsd-tdep.c: Revert.
8810         * fbsd-nat.h: Revert.
8811         * fbsd-nat.c: Revert.
8812         * f-valprint.c: Revert.
8813         * f-typeprint.c: Revert.
8814         * f-lang.c: Revert.
8815         * extension.h: Revert.
8816         * extension.c: Revert.
8817         * extension-priv.h: Revert.
8818         * expprint.c: Revert.
8819         * exec.h: Revert.
8820         * exec.c: Revert.
8821         * exceptions.c: Revert.
8822         * event-top.c: Revert.
8823         * event-loop.c: Revert.
8824         * eval.c: Revert.
8825         * elfread.c: Revert.
8826         * dwarf2read.h: Revert.
8827         * dwarf2read.c: Revert.
8828         * dwarf2loc.c: Revert.
8829         * dwarf2expr.h: Revert.
8830         * dwarf2expr.c: Revert.
8831         * dwarf2-frame.c: Revert.
8832         * dwarf2-frame-tailcall.c: Revert.
8833         * dwarf-index-write.h: Revert.
8834         * dwarf-index-write.c: Revert.
8835         * dwarf-index-common.c: Revert.
8836         * dwarf-index-cache.h: Revert.
8837         * dwarf-index-cache.c: Revert.
8838         * dummy-frame.c: Revert.
8839         * dtrace-probe.c: Revert.
8840         * disasm.h: Revert.
8841         * disasm.c: Revert.
8842         * disasm-selftests.c: Revert.
8843         * dictionary.c: Revert.
8844         * dicos-tdep.c: Revert.
8845         * demangle.c: Revert.
8846         * dcache.h: Revert.
8847         * dcache.c: Revert.
8848         * darwin-nat.h: Revert.
8849         * darwin-nat.c: Revert.
8850         * darwin-nat-info.c: Revert.
8851         * d-valprint.c: Revert.
8852         * d-namespace.c: Revert.
8853         * d-lang.c: Revert.
8854         * ctf.c: Revert.
8855         * csky-tdep.c: Revert.
8856         * csky-linux-tdep.c: Revert.
8857         * cris-tdep.c: Revert.
8858         * cris-linux-tdep.c: Revert.
8859         * cp-valprint.c: Revert.
8860         * cp-support.c: Revert.
8861         * cp-namespace.c: Revert.
8862         * cp-abi.c: Revert.
8863         * corelow.c: Revert.
8864         * corefile.c: Revert.
8865         * continuations.c: Revert.
8866         * completer.h: Revert.
8867         * completer.c: Revert.
8868         * complaints.c: Revert.
8869         * coffread.c: Revert.
8870         * coff-pe-read.c: Revert.
8871         * cli-out.h: Revert.
8872         * cli-out.c: Revert.
8873         * charset.c: Revert.
8874         * c-varobj.c: Revert.
8875         * c-valprint.c: Revert.
8876         * c-typeprint.c: Revert.
8877         * c-lang.c: Revert.
8878         * buildsym.c: Revert.
8879         * buildsym-legacy.c: Revert.
8880         * build-id.h: Revert.
8881         * build-id.c: Revert.
8882         * btrace.c: Revert.
8883         * bsd-uthread.c: Revert.
8884         * breakpoint.h: Revert.
8885         * breakpoint.c: Revert.
8886         * break-catch-throw.c: Revert.
8887         * break-catch-syscall.c: Revert.
8888         * break-catch-sig.c: Revert.
8889         * blockframe.c: Revert.
8890         * block.c: Revert.
8891         * bfin-tdep.c: Revert.
8892         * bfin-linux-tdep.c: Revert.
8893         * bfd-target.c: Revert.
8894         * bcache.c: Revert.
8895         * ax-general.c: Revert.
8896         * ax-gdb.h: Revert.
8897         * ax-gdb.c: Revert.
8898         * avr-tdep.c: Revert.
8899         * auxv.c: Revert.
8900         * auto-load.c: Revert.
8901         * arm-wince-tdep.c: Revert.
8902         * arm-tdep.c: Revert.
8903         * arm-symbian-tdep.c: Revert.
8904         * arm-pikeos-tdep.c: Revert.
8905         * arm-obsd-tdep.c: Revert.
8906         * arm-nbsd-tdep.c: Revert.
8907         * arm-nbsd-nat.c: Revert.
8908         * arm-linux-tdep.c: Revert.
8909         * arm-linux-nat.c: Revert.
8910         * arm-fbsd-tdep.c: Revert.
8911         * arm-fbsd-nat.c: Revert.
8912         * arm-bsd-tdep.c: Revert.
8913         * arch-utils.c: Revert.
8914         * arc-tdep.c: Revert.
8915         * arc-newlib-tdep.c: Revert.
8916         * annotate.h: Revert.
8917         * annotate.c: Revert.
8918         * amd64-windows-tdep.c: Revert.
8919         * amd64-windows-nat.c: Revert.
8920         * amd64-tdep.c: Revert.
8921         * amd64-sol2-tdep.c: Revert.
8922         * amd64-obsd-tdep.c: Revert.
8923         * amd64-obsd-nat.c: Revert.
8924         * amd64-nbsd-tdep.c: Revert.
8925         * amd64-nbsd-nat.c: Revert.
8926         * amd64-nat.c: Revert.
8927         * amd64-linux-tdep.c: Revert.
8928         * amd64-linux-nat.c: Revert.
8929         * amd64-fbsd-tdep.c: Revert.
8930         * amd64-fbsd-nat.c: Revert.
8931         * amd64-dicos-tdep.c: Revert.
8932         * amd64-darwin-tdep.c: Revert.
8933         * amd64-bsd-nat.c: Revert.
8934         * alpha-tdep.c: Revert.
8935         * alpha-obsd-tdep.c: Revert.
8936         * alpha-nbsd-tdep.c: Revert.
8937         * alpha-mdebug-tdep.c: Revert.
8938         * alpha-linux-tdep.c: Revert.
8939         * alpha-linux-nat.c: Revert.
8940         * alpha-bsd-tdep.c: Revert.
8941         * alpha-bsd-nat.c: Revert.
8942         * aix-thread.c: Revert.
8943         * agent.c: Revert.
8944         * addrmap.c: Revert.
8945         * ada-varobj.c: Revert.
8946         * ada-valprint.c: Revert.
8947         * ada-typeprint.c: Revert.
8948         * ada-tasks.c: Revert.
8949         * ada-lang.c: Revert.
8950         * aarch64-tdep.c: Revert.
8951         * aarch64-ravenscar-thread.c: Revert.
8952         * aarch64-newlib-tdep.c: Revert.
8953         * aarch64-linux-tdep.c: Revert.
8954         * aarch64-linux-nat.c: Revert.
8955         * aarch64-fbsd-tdep.c: Revert.
8956         * aarch64-fbsd-nat.c: Revert.
8957         * aarch32-linux-nat.c: Revert.
8958
8959 2019-04-05  Tom Tromey  <tom@tromey.com>
8960
8961         * ft32-tdep.c: Sort headers.
8962         * frv-tdep.c: Sort headers.
8963         * frv-linux-tdep.c: Sort headers.
8964         * frame.c: Sort headers.
8965         * frame-unwind.c: Sort headers.
8966         * frame-base.c: Sort headers.
8967         * fork-child.c: Sort headers.
8968         * findvar.c: Sort headers.
8969         * findcmd.c: Sort headers.
8970         * filesystem.c: Sort headers.
8971         * filename-seen-cache.h: Sort headers.
8972         * filename-seen-cache.c: Sort headers.
8973         * fbsd-tdep.c: Sort headers.
8974         * fbsd-nat.h: Sort headers.
8975         * fbsd-nat.c: Sort headers.
8976         * f-valprint.c: Sort headers.
8977         * f-typeprint.c: Sort headers.
8978         * f-lang.c: Sort headers.
8979         * extension.h: Sort headers.
8980         * extension.c: Sort headers.
8981         * extension-priv.h: Sort headers.
8982         * expprint.c: Sort headers.
8983         * exec.h: Sort headers.
8984         * exec.c: Sort headers.
8985         * exceptions.c: Sort headers.
8986         * event-top.c: Sort headers.
8987         * event-loop.c: Sort headers.
8988         * eval.c: Sort headers.
8989         * elfread.c: Sort headers.
8990         * dwarf2read.h: Sort headers.
8991         * dwarf2read.c: Sort headers.
8992         * dwarf2loc.c: Sort headers.
8993         * dwarf2expr.h: Sort headers.
8994         * dwarf2expr.c: Sort headers.
8995         * dwarf2-frame.c: Sort headers.
8996         * dwarf2-frame-tailcall.c: Sort headers.
8997         * dwarf-index-write.h: Sort headers.
8998         * dwarf-index-write.c: Sort headers.
8999         * dwarf-index-common.c: Sort headers.
9000         * dwarf-index-cache.h: Sort headers.
9001         * dwarf-index-cache.c: Sort headers.
9002         * dummy-frame.c: Sort headers.
9003         * dtrace-probe.c: Sort headers.
9004         * disasm.h: Sort headers.
9005         * disasm.c: Sort headers.
9006         * disasm-selftests.c: Sort headers.
9007         * dictionary.c: Sort headers.
9008         * dicos-tdep.c: Sort headers.
9009         * demangle.c: Sort headers.
9010         * dcache.h: Sort headers.
9011         * dcache.c: Sort headers.
9012         * darwin-nat.h: Sort headers.
9013         * darwin-nat.c: Sort headers.
9014         * darwin-nat-info.c: Sort headers.
9015         * d-valprint.c: Sort headers.
9016         * d-namespace.c: Sort headers.
9017         * d-lang.c: Sort headers.
9018         * ctf.c: Sort headers.
9019         * csky-tdep.c: Sort headers.
9020         * csky-linux-tdep.c: Sort headers.
9021         * cris-tdep.c: Sort headers.
9022         * cris-linux-tdep.c: Sort headers.
9023         * cp-valprint.c: Sort headers.
9024         * cp-support.c: Sort headers.
9025         * cp-namespace.c: Sort headers.
9026         * cp-abi.c: Sort headers.
9027         * corelow.c: Sort headers.
9028         * corefile.c: Sort headers.
9029         * continuations.c: Sort headers.
9030         * completer.h: Sort headers.
9031         * completer.c: Sort headers.
9032         * complaints.c: Sort headers.
9033         * coffread.c: Sort headers.
9034         * coff-pe-read.c: Sort headers.
9035         * cli-out.h: Sort headers.
9036         * cli-out.c: Sort headers.
9037         * charset.c: Sort headers.
9038         * c-varobj.c: Sort headers.
9039         * c-valprint.c: Sort headers.
9040         * c-typeprint.c: Sort headers.
9041         * c-lang.c: Sort headers.
9042         * buildsym.c: Sort headers.
9043         * buildsym-legacy.c: Sort headers.
9044         * build-id.h: Sort headers.
9045         * build-id.c: Sort headers.
9046         * btrace.c: Sort headers.
9047         * bsd-uthread.c: Sort headers.
9048         * breakpoint.h: Sort headers.
9049         * breakpoint.c: Sort headers.
9050         * break-catch-throw.c: Sort headers.
9051         * break-catch-syscall.c: Sort headers.
9052         * break-catch-sig.c: Sort headers.
9053         * blockframe.c: Sort headers.
9054         * block.c: Sort headers.
9055         * bfin-tdep.c: Sort headers.
9056         * bfin-linux-tdep.c: Sort headers.
9057         * bfd-target.c: Sort headers.
9058         * bcache.c: Sort headers.
9059         * ax-general.c: Sort headers.
9060         * ax-gdb.h: Sort headers.
9061         * ax-gdb.c: Sort headers.
9062         * avr-tdep.c: Sort headers.
9063         * auxv.c: Sort headers.
9064         * auto-load.c: Sort headers.
9065         * arm-wince-tdep.c: Sort headers.
9066         * arm-tdep.c: Sort headers.
9067         * arm-symbian-tdep.c: Sort headers.
9068         * arm-pikeos-tdep.c: Sort headers.
9069         * arm-obsd-tdep.c: Sort headers.
9070         * arm-nbsd-tdep.c: Sort headers.
9071         * arm-nbsd-nat.c: Sort headers.
9072         * arm-linux-tdep.c: Sort headers.
9073         * arm-linux-nat.c: Sort headers.
9074         * arm-fbsd-tdep.c: Sort headers.
9075         * arm-fbsd-nat.c: Sort headers.
9076         * arm-bsd-tdep.c: Sort headers.
9077         * arch-utils.c: Sort headers.
9078         * arc-tdep.c: Sort headers.
9079         * arc-newlib-tdep.c: Sort headers.
9080         * annotate.h: Sort headers.
9081         * annotate.c: Sort headers.
9082         * amd64-windows-tdep.c: Sort headers.
9083         * amd64-windows-nat.c: Sort headers.
9084         * amd64-tdep.c: Sort headers.
9085         * amd64-sol2-tdep.c: Sort headers.
9086         * amd64-obsd-tdep.c: Sort headers.
9087         * amd64-obsd-nat.c: Sort headers.
9088         * amd64-nbsd-tdep.c: Sort headers.
9089         * amd64-nbsd-nat.c: Sort headers.
9090         * amd64-nat.c: Sort headers.
9091         * amd64-linux-tdep.c: Sort headers.
9092         * amd64-linux-nat.c: Sort headers.
9093         * amd64-fbsd-tdep.c: Sort headers.
9094         * amd64-fbsd-nat.c: Sort headers.
9095         * amd64-dicos-tdep.c: Sort headers.
9096         * amd64-darwin-tdep.c: Sort headers.
9097         * amd64-bsd-nat.c: Sort headers.
9098         * alpha-tdep.c: Sort headers.
9099         * alpha-obsd-tdep.c: Sort headers.
9100         * alpha-nbsd-tdep.c: Sort headers.
9101         * alpha-mdebug-tdep.c: Sort headers.
9102         * alpha-linux-tdep.c: Sort headers.
9103         * alpha-linux-nat.c: Sort headers.
9104         * alpha-bsd-tdep.c: Sort headers.
9105         * alpha-bsd-nat.c: Sort headers.
9106         * aix-thread.c: Sort headers.
9107         * agent.c: Sort headers.
9108         * addrmap.c: Sort headers.
9109         * ada-varobj.c: Sort headers.
9110         * ada-valprint.c: Sort headers.
9111         * ada-typeprint.c: Sort headers.
9112         * ada-tasks.c: Sort headers.
9113         * ada-lang.c: Sort headers.
9114         * aarch64-tdep.c: Sort headers.
9115         * aarch64-ravenscar-thread.c: Sort headers.
9116         * aarch64-newlib-tdep.c: Sort headers.
9117         * aarch64-linux-tdep.c: Sort headers.
9118         * aarch64-linux-nat.c: Sort headers.
9119         * aarch64-fbsd-tdep.c: Sort headers.
9120         * aarch64-fbsd-nat.c: Sort headers.
9121         * aarch32-linux-nat.c: Sort headers.
9122
9123 2019-04-04  Tom Tromey  <tom@tromey.com>
9124
9125         * varobj.c (varobj_create): Update.
9126         * rust-exp.y (struct rust_parser) <update_innermost_block,
9127         lookup_symbol>: New methods.
9128         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9129         Rename.
9130         (rust_parser::rust_lookup_type)
9131         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9132         * printcmd.c (display_command, do_one_display): Update.
9133         * parser-defs.h (struct parser_state) <parser_state>: Add
9134         "tracker" parameter.
9135         (block_tracker): New member.
9136         (class innermost_block_tracker) <innermost_block_tracker>: Add
9137         "types" parameter.
9138         <reset>: Remove method.
9139         (innermost_block): Don't declare.
9140         (null_post_parser): Update.
9141         * parse.c (innermost_block): Remove global.
9142         (write_dollar_variable): Update.
9143         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9144         Remove "tracker_types" parameter.
9145         (parse_expression): Add "tracker" parameter.
9146         (parse_expression_for_completion): Update.
9147         (null_post_parser): Add "tracker" parameter.
9148         * p-exp.y: Update rules.
9149         * m2-exp.y: Update rules.
9150         * language.h (struct language_defn) <la_post_parser>: Add
9151         "tracker" parameter.
9152         * go-exp.y: Update rules.
9153         * f-exp.y: Update rules.
9154         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9155         parameter.
9156         * d-exp.y: Update rules.
9157         * c-exp.y: Update rules.
9158         * breakpoint.c (set_breakpoint_condition): Create an
9159         innermost_block_tracker.
9160         (watch_command_1): Likewise.
9161         * ada-lang.c (resolve): Add "tracker" parameter.
9162         (resolve_subexp): Likewise.
9163         * ada-exp.y (write_var_from_sym): Update.
9164
9165 2019-04-04  Tom Tromey  <tom@tromey.com>
9166
9167         * type-stack.h: New file.
9168         * type-stack.c: New file.
9169         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9170         type-stack.h.
9171         (insert_into_type_stack, insert_type, push_type, push_type_int)
9172         (insert_type_address_space, pop_type, pop_type_int)
9173         (pop_typelist, pop_type_stack, append_type_stack)
9174         (push_type_stack, get_type_stack, push_typelist)
9175         (follow_type_instance_flags, follow_types): Don't declare.
9176         * parse.c (type_stack): Remove global.
9177         (parse_exp_in_context): Update.
9178         (insert_into_type_stack, insert_type, push_type, push_type_int)
9179         (insert_type_address_space, pop_type, pop_type_int)
9180         (pop_typelist, pop_type_stack, append_type_stack)
9181         (push_type_stack, get_type_stack, push_typelist)
9182         (follow_type_instance_flags, follow_types): Remove (moved to
9183         type-stack.c).
9184         * f-exp.y (type_stack): New global.
9185         Update rules.
9186         (push_kind_type, f_parse): Update.
9187         * d-exp.y (type_stack): New global.
9188         Update rules.
9189         (d_parse): Update.
9190         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9191         Update rules.
9192         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9193         (HFILES_NO_SRCDIR): Add type-stack.h.
9194
9195 2019-04-04  Tom Tromey  <tom@tromey.com>
9196
9197         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9198         (rust_parser::convert_ast_to_expression, rust_parse)
9199         (rust_lex_test_completion, rust_lex_tests): Update.
9200         * parser-defs.h (struct expr_completion_state): New.
9201         (struct parser_state) <parser_state>: Add completion parameter.
9202         <mark_struct_expression, mark_completion_tag>: New methods.
9203         <parse_completion, m_completion_state>: New members.
9204         (prefixify_expression, null_post_parser): Update.
9205         (mark_struct_expression, mark_completion_tag): Don't declare.
9206         * parse.c (parse_completion, expout_last_struct)
9207         (expout_tag_completion_type, expout_completion_name): Remove
9208         globals.
9209         (parser_state::mark_struct_expression)
9210         (parser_state::mark_completion_tag): Now methods.
9211         (prefixify_expression): Add last_struct parameter.
9212         (prefixify_subexp): Likewise.
9213         (parse_exp_1): Update.
9214         (parse_exp_in_context): Add cstate parameter.  Update.
9215         (parse_expression_for_completion): Create an
9216         expr_completion_state.
9217         (null_post_parser): Add "completion" parameter.
9218         * p-exp.y: Update rules.
9219         (yylex): Update.
9220         * language.h (struct language_defn) <la_post_parser>: Add
9221         "completing" parameter.
9222         * go-exp.y: Update rules.
9223         (lex_one_token): Update.
9224         * expression.h (parse_completion): Don't declare.
9225         * d-exp.y: Update rules.
9226         (lex_one_token): Update rules.
9227         * c-exp.y: Update rules.
9228         (lex_one_token): Update.
9229         * ada-lang.c (resolve): Add "parse_completion" parameter.
9230         (resolve_subexp): Likewise.
9231         (ada_resolve_function): Likewise.
9232
9233 2019-04-04  Tom Tromey  <tom@tromey.com>
9234
9235         * parser-defs.h (struct parser_state) <start_arglist,
9236         end_arglist>: New methods.
9237         <arglist_len, m_funcall_chain>: New members.
9238         (arglist_len, start_arglist, end_arglist): Don't declare.
9239         * parse.c (arglist_len, funcall_chain): Remove global.
9240         (start_arglist, end_arglist): Remove functions.
9241         (parse_exp_in_context): Update.
9242         * p-exp.y: Update rules.
9243         * m2-exp.y: Update rules.
9244         * go-exp.y: Update rules.
9245         * f-exp.y: Update rules.
9246         * d-exp.y: Update rules.
9247         * c-exp.y: Update rules.
9248
9249 2019-04-04  Tom Tromey  <tom@tromey.com>
9250
9251         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9252         lex_operator, push_back>: New methods.
9253         Update all rules.
9254         (rust_parser::lex_hex, lex_escape): Rename and update.
9255         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9256         (rust_parser::lex_operator): Rename and update.
9257         (rust_parser::lex_number, rustyylex, rustyyerror)
9258         (rust_lex_test_init, rust_lex_test_sequence)
9259         (rust_lex_test_push_back, rust_lex_tests): Update.
9260         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9261         parameter.
9262         <lexptr, prev_lexptr>: New members.
9263         (lexptr, prev_lexptr): Don't declare.
9264         * parse.c (lexptr, prev_lexptr): Remove globals.
9265         (parse_exp_in_context): Update.
9266         * p-exp.y (yylex, yyerror): Update.
9267         * m2-exp.y (parse_number, yylex, yyerror): Update.
9268         * go-exp.y (lex_one_token, yyerror): Update.
9269         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9270         * d-exp.y (lex_one_token, yyerror): Update.
9271         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9272         (lex_one_token, yyerror): Update.
9273         * ada-lex.l (YY_INPUT): Update.
9274         (rewind_to_char): Update.
9275         * ada-exp.y (yyerror): Update.
9276
9277 2019-04-04  Tom Tromey  <tom@tromey.com>
9278
9279         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9280         * parser-defs.h (struct parser_state) <parser_state>: Add new
9281         parameter.
9282         <comma_terminates>: New member.
9283         (comma_terminates): Don't declare global.
9284         * parse.c (comma_terminates): Remove global.
9285         (parse_exp_in_context): Update.
9286         * p-exp.y (yylex): Update.
9287         * m2-exp.y (yylex): Update.
9288         * go-exp.y (lex_one_token): Update.
9289         * f-exp.y (yylex): Update.
9290         * d-exp.y (lex_one_token): Update.
9291         * c-exp.y (lex_one_token): Update.
9292         * ada-lex.l: Update.
9293
9294 2019-04-04  Tom Tromey  <tom@tromey.com>
9295
9296         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9297         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9298         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9299         * parser-defs.h (paren_depth): Don't declare.
9300         * parse.c (paren_depth): Remove global.
9301         (parse_exp_in_context): Update.
9302         * p-exp.y (paren_depth): New global.
9303         (pascal_parse): Initialize it.
9304         * m2-exp.y (paren_depth): New global.
9305         (m2_parse): Initialize it.
9306         * go-exp.y (paren_depth): New global.
9307         (go_parse): Initialize it.
9308         * f-exp.y (paren_depth): New global.
9309         (f_parse): Initialize it.
9310         * d-exp.y (paren_depth): New global.
9311         (d_parse): Initialize it.
9312         * c-exp.y (paren_depth): New global.
9313         (c_parse): Initialize it.
9314         * ada-lex.l (paren_depth): New global.
9315         (lexer_init): Initialize it.
9316
9317 2019-04-04  Tom Tromey  <tom@tromey.com>
9318
9319         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9320         (rust_parser::convert_ast_to_type)
9321         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9322         * parser-defs.h (struct parser_state) <parser_state>: Add
9323         parameters.  Initialize new members.
9324         <expression_context_block, expression_context_pc>: New members.
9325         * parse.c (expression_context_block, expression_context_pc):
9326         Remove globals.
9327         (parse_exp_in_context): Update.
9328         * p-exp.y: Update all rules.
9329         (yylex): Update.
9330         * m2-exp.y: Update all rules.
9331         (yylex): Update.
9332         * go-exp.y (yylex): Update.
9333         * f-exp.y (yylex): Update.
9334         * d-exp.y: Update all rules.
9335         (yylex): Update.
9336         * c-exp.y: Update all rules.
9337         (lex_one_token, classify_name, yylex, c_parse): Update.
9338         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9339
9340 2019-04-04  Tom Tromey  <tom@tromey.com>
9341
9342         * gdbarch.h, gdbarch.c: Rebuild.
9343         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9344         * stap-probe.h:
9345         (struct stap_parse_info): Replace "parser_state" with
9346         "expr_builder".
9347         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9348         (parser_state): New class.
9349         * parse.c (expr_builder): Rename.
9350         (expr_builder::release): Rename.
9351         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9352         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9353         (write_exp_elt_longcst, write_exp_elt_floatcst)
9354         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9355         (write_exp_string_vector, write_exp_bitstring)
9356         (write_exp_msymbol, mark_struct_expression)
9357         (write_dollar_variable)
9358         (insert_type_address_space, increase_expout_size): Replace
9359         "parser_state" with "expr_builder".
9360         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9361         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9362         "parser_state" with "expr_builder".
9363
9364 2019-04-04  Tom Tromey  <tom@tromey.com>
9365
9366         * rust-exp.y: Replace "parse_language" with method call.
9367         * p-exp.y:
9368         (yylex): Replace "parse_language" with method call.
9369         * m2-exp.y:
9370         (yylex): Replace "parse_language" with method call.
9371         * go-exp.y (classify_name): Replace "parse_language" with method
9372         call.
9373         * f-exp.y (yylex): Replace "parse_language" with method call.
9374         * d-exp.y (lex_one_token): Replace "parse_language" with method
9375         call.
9376         * c-exp.y:
9377         (lex_one_token, classify_name, yylex): Replace "parse_language"
9378         with method call.
9379         * ada-exp.y (find_primitive_type, type_char)
9380         (type_system_address): Replace "parse_language" with method call.
9381
9382 2019-04-04  Tom Tromey  <tom@tromey.com>
9383
9384         * rust-exp.y: Replace "parse_gdbarch" with method call.
9385         * parse.c (write_dollar_variable, insert_type_address_space):
9386         Replace "parse_gdbarch" with method call.
9387         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9388         call.
9389         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9390         call.
9391         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9392         "parse_gdbarch" with method call.
9393         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9394         with method call.
9395         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9396         "parse_gdbarch" with method call.
9397         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9398         "parse_gdbarch" with method call.
9399         * c-exp.y (parse_type, parse_number, classify_name): Replace
9400         "parse_gdbarch" with method call.
9401         * ada-lex.l: Replace "parse_gdbarch" with method call.
9402         * ada-exp.y (parse_type, find_primitive_type, type_char)
9403         (type_system_address): Replace "parse_gdbarch" with method call.
9404
9405 2019-04-04  Tom Tromey  <tom@tromey.com>
9406
9407         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9408         * stap-probe.c (stap_parse_argument): Update.
9409         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9410         initial_size parameter.
9411         * rust-exp.y (rust_lex_tests): Update.
9412         * parse.c (parser_state): Update.
9413         (parse_exp_in_context): Update.
9414         * parser-defs.h (struct parser_state) <parser_state>: Remove
9415         "initial_size" parameter.
9416
9417 2019-04-04  Tom Tromey  <tom@tromey.com>
9418
9419         * parser-defs.h (increase_expout_size): Don't declare.
9420         * parse.c (increase_expout_size): Now static.
9421
9422 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9423
9424         * gnu-nat.c (gnu_nat_target::wait): Fix
9425         target_waitstatus_to_string call.
9426
9427 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9428
9429         * eval.c (evaluate_subexp_standard): Handle internal functions
9430         during Fortran function call handling.
9431
9432 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9433
9434         * NEWS: Mention new internal functions.
9435         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9436         (read_base_type): Use dwarf2_init_complex_target_type.
9437         * value.c (creal_internal_fn): New function.
9438         (cimag_internal_fn): New function.
9439         (_initialize_values): Register new internal functions.
9440
9441 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9442
9443         * infrun.c (stop_all_threads): If debug_infrun, always
9444         trace the wait status after wait_one, using
9445         target_waitstatus_to_string and target_pid_to_str.
9446         (handle_inferior_event): Replace various trace of
9447         wait status kind by a single trace.
9448         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9449         wait status kind image by target_waitstatus_to_string.
9450         * target/waitstatus.c (target_waitstatus_to_string): Fix
9451         obsolete comment.
9452
9453 2019-04-01  Tom Tromey  <tromey@adacore.com>
9454
9455         PR symtab/23331:
9456         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9457
9458 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9459             Pedro Alves  <palves@redhat.com>
9460
9461         * top.c (quit_force): Call 'finalize_values'.
9462         * value.c (finalize_values): New function.
9463         * value.h (finalize_values): Declare.
9464
9465 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9466
9467         * NEWS: Announce $_gdb_major and $_gdb_minor.
9468
9469         * top.c (init_gdb_version_vars): New function.
9470         (gdb_init): Call init_gdb_version_vars.
9471
9472 2019-03-29  Tom Tromey  <tromey@adacore.com>
9473
9474         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9475         help text.  Remove dead code.
9476
9477 2019-03-29  Keith Seitz  <keiths@redhat.com>
9478
9479         From Siddhesh Poyarekar:
9480         * f-lang.h (f77_get_upperbound): Return LONGEST.
9481         (f77_get_lowerbound): Likewise.
9482         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9483         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9484         print them.
9485         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9486         plongest to format print it.
9487         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9488         (f77_get_upperbound): Likewise.
9489         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9490         LOWER_BOUND to LONGEST.
9491         (f77_create_arrayprint_offset_tbl): Likewise.
9492
9493 2019-03-29  Keith Seitz  <keiths@redhat.com>
9494
9495         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9496         %s/pulongest for TYPE_LENGTH instead of %d in format
9497         strings.
9498         * ada-typerint.c (ada_print_type): Likewise.
9499         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9500         * compile/compile-c-support.c (generate_register_struct): Likewise.
9501         * gdbtypes.c (recursive_dump_type): Likewise.
9502         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9503         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9504         instead of %d in format strings.
9505         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9506         to std::min to ULONGEST.
9507         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9508         instead of %d in format strings.
9509         * tracepoint.c (info_scope_command): Likewise.
9510         * typeprint.c (print_offset_data::update)
9511         (print_offset_data::finish): Likewise.
9512         * xtensa-tdep.c (xtensa_store_return_value)
9513         (xtensa_push_dummy_call): Likewise.
9514
9515 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9516
9517         * windows-nat.c (display_selector): Fixed format specifications
9518         for 64-bit Cygwin.
9519
9520 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9521
9522         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9523
9524 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9525
9526         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9527         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9528         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9529         (nios2_linux_init_abi): Install it.
9530
9531 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9532
9533         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9534
9535 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9536
9537         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9538
9539 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9540             Tom Tromey  <tromey@adacore.com>
9541
9542         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9543
9544 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9545
9546         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9547         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9548         method to compute the bounds of range types. Also print "[evaluated]"
9549         if the bounds' values come from a dynamic evaluation.
9550
9551 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9552
9553         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9554         whitespace when pretty printing is on.
9555
9556 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9557
9558         * ppc-linux-nat.c: Add include.
9559
9560 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9561
9562         * NEWS: Mention AArch64 Pointer Authentication.
9563
9564 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9565
9566         * arm-linux-nat.c: Add include.
9567
9568 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9569
9570         * source-cache.c (source_cache::get_source_lines): Re-read
9571         fullname after calling open_source_file.
9572
9573 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9574
9575         * NEWS: Mention TLS support for FreeBSD.
9576
9577 2019-03-25  Tom Tromey  <tromey@adacore.com>
9578
9579         * minsyms.c (BUNCH_SIZE): Update comment.
9580         (~minimal_symbol_reader): Remove old comment.
9581         (compact_minimal_symbols): Update comment.
9582         (minimal_symbol_reader::install): Remove old comment.  Update
9583         other comments.
9584
9585 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9586
9587         * s390-linux-nat.c: Add include.
9588
9589 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9590
9591         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9592         Call linux_get_hwcap.
9593         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9594         Likewise.
9595         (aarch64_linux_get_hwcap): Remove function.
9596         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9597         declaration.
9598         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9599         linux_get_hwcap.
9600         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9601         * linux-tdep.c (linux_get_hwcap): Add function.
9602         (linux_get_hwcap2): Likewise.
9603         * linux-tdep.h (linux_get_hwcap): Add declaration.
9604         (linux_get_hwcap2): Likewise.
9605         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9606         (ppc_linux_get_hwcap2): Likewise.
9607         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9608         linux_get_hwcap.
9609         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9610         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9611         (ppc_linux_nat_target::read_description): Likewise.
9612         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9613         * s390-linux-nat.c: Likewise.
9614         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9615
9616 2019-03-24  Tom Tromey  <tom@tromey.com>
9617
9618         * ada-lang.c (standard_lookup): Simplify initialization.
9619         (ada_lookup_symbol_nonlocal): Simplify return.
9620         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9621         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9622         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9623         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9624         initialization.
9625         * solib.c (solib_global_lookup): Simplify.
9626         * symtab.c (null_block_symbol): Remove.
9627         (symbol_cache_lookup): Simplify returns.
9628         (lookup_language_this): Simplify returns.
9629         (lookup_symbol_aux): Simplify return.
9630         (lookup_local_symbol): Simplify returns.
9631         (lookup_global_symbol_from_objfile): Simplify return.
9632         (lookup_symbol_in_objfile_symtabs)
9633         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9634         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9635         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9636         * cp-namespace.c (cp_lookup_bare_symbol)
9637         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9638         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9639         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9640         (cp_lookup_symbol_via_imports): Simplify initialization.
9641         (find_symbol_in_baseclass): Likewise.
9642         * symtab.h (null_block_symbol): Remove.
9643         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9644         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9645         (d_lookup_symbol_module): Likewise.
9646         (find_symbol_in_baseclass): Simplify initialization.
9647
9648 2019-03-24  Tom Tromey  <tom@tromey.com>
9649
9650         * expression.h: Don't include symtab.h.
9651         (struct block): Forward declare.
9652
9653 2019-03-24  Tom Tromey  <tom@tromey.com>
9654
9655         * c-exp.y (typebase): Remove casts.
9656         * gdbtypes.c (lookup_unsigned_typename, )
9657         (lookup_signed_typename): Remove cast.
9658         * eval.c (parse_to_comma_and_eval): Remove cast.
9659         * parse.c (write_dollar_variable): Remove cast.
9660         * block.h (struct block) <superblock>: Now const.
9661         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9662         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9663         (map_block): Make "block" const.
9664         * symfile.h (struct quick_symbol_functions)
9665         <map_matching_symbols>: Constify block argument to "callback".
9666         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9667         const.
9668         (find_pc_sect_compunit_symtab): Make "b" const.
9669         (find_symbol_at_address): Likewise.
9670         (search_symbols): Likewise.
9671         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9672         (dw2_debug_names_lookup_symbol): Likewise.
9673         (dw2_map_matching_symbols): Update.
9674         * p-valprint.c (pascal_val_print): Remove "block".
9675         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9676         (aux_add_nonlocal_symbols): Make "block" const.
9677         (resolve_subexp): Remove cast.
9678         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9679         const.
9680         (iterate_over_file_blocks): Likewise.
9681         * f-exp.y (%union) <bval>: Remove.
9682         * coffread.c (patch_opaque_types): Make "b" const.
9683         * spu-tdep.c (spu_catch_start): Make "block" const.
9684         * c-valprint.c (print_unpacked_pointer): Remove "block".
9685         * symmisc.c (dump_symtab_1): Make "b" const.
9686         (block_depth): Make "block" const.
9687         * d-exp.y (%union) <bval>: Remove.
9688         * cp-support.h (cp_lookup_rtti_type): Update.
9689         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9690         * psymtab.c (psym_lookup_symbol): Make "block" const.
9691         (maintenance_check_psymtabs): Make "b" const.
9692         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9693         (enumerate_locals, enumerate_args): Update.
9694         * python/py-symtab.c (stpy_global_block): Make "block" const.
9695         (stpy_static_block): Likewise.
9696         * inline-frame.c (block_starting_point_at): Make "new_block"
9697         const.
9698         * block.c (find_block_in_blockvector): Make return type const.
9699         (blockvector_for_pc_sect): Make "b" const.
9700         (find_block_in_blockvector): Make "b" const.
9701
9702 2019-03-23  Tom Tromey  <tom@tromey.com>
9703
9704         * varobj.c (varobj_create): Update.
9705         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9706         * printcmd.c (display_command, do_one_display): Don't reset
9707         innermost_block.
9708         * parser-defs.h (enum innermost_block_tracker_type): Move to
9709         expression.h.
9710         (innermost_block): Update comment.
9711         * parse.c (parse_exp_1): Add tracker_types parameter.
9712         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9713         tracker_types parameter.  Reset innermost_block.
9714         (parse_exp_in_context): Remove.
9715         (parse_expression_for_completion): Update.
9716         * objfiles.c (~objfile): Don't reset expression_context_block or
9717         innermost_block.
9718         * expression.h (enum innermost_block_tracker_type): Move from
9719         parser-defs.h.
9720         (parse_exp_1): Add tracker_types parameter.
9721         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9722         reset innermost_block.
9723
9724 2019-03-23  Tom Tromey  <tom@tromey.com>
9725
9726         * objfiles.h: Include bcache.h.
9727
9728 2019-03-23  Tom Tromey  <tom@tromey.com>
9729
9730         * linespec.c (get_current_search_block): Use
9731         scoped_restore_current_language.
9732         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9733
9734 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9735             Jiong Wang  <jiong.wang@arm.com>
9736
9737         * aarch64-linux-tdep.c
9738         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9739         section.
9740         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9741
9742 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9743             Jiong Wang  <jiong.wang@arm.com>
9744
9745         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9746         instructions.
9747         (aarch64_analyze_prologue_test): Add PACIASP test.
9748         (aarch64_prologue_prev_register): Unmask PC value.
9749
9750 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9751             Jiong Wang  <jiong.wang@arm.com>
9752
9753         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9754         (aarch64_dwarf2_prev_register): Unmask PC value.
9755         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9756         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9757         DW_CFA_AARCH64_negate_ra_state.
9758         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9759
9760 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9761             Jiong Wang  <jiong.wang@arm.com>
9762
9763         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9764         registers.
9765         (aarch64_pseudo_register_name): Likewise.
9766         (aarch64_pseudo_register_type): Likewise.
9767         (aarch64_pseudo_register_reggroup_p): Likewise.
9768         (aarch64_gdbarch_init): Add pauth registers.
9769         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9770         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9771         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9772         (struct gdbarch_tdep): Add regnum for ra_state.
9773
9774 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9775             Jiong Wang  <jiong.wang@arm.com>
9776
9777         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9778
9779 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9780             Jiong Wang  <jiong.wang@arm.com>
9781
9782         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9783         function.
9784         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9785         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9786         (aarch64_gdbarch_init): Add puth registers.
9787         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9788         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9789         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9790
9791 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9792             Jiong Wang  <jiong.wang@arm.com>
9793
9794         * aarch64-linux-nat.c
9795         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9796         * aarch64-linux-tdep.c
9797         (aarch64_linux_core_read_description): Likewise.
9798         (aarch64_linux_get_hwcap): New function.
9799         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9800         (aarch64_linux_get_hwcap): New declaration.
9801
9802 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9803             Jiong Wang  <jiong.wang@arm.com>
9804
9805         * aarch64-linux-nat.c
9806         (aarch64_linux_nat_target::read_description): Add pauth param.
9807         * aarch64-linux-tdep.c
9808         (aarch64_linux_core_read_description): Likewise.
9809         * aarch64-tdep.c (struct target_desc): Add in pauth.
9810         (aarch64_read_description): Add pauth param.
9811         (aarch64_gdbarch_init): Likewise.
9812         * aarch64-tdep.h (aarch64_read_description): Likewise.
9813         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9814         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9815         * features/Makefile: Add new files.
9816         * features/aarch64-pauth.c: New file.
9817         * features/aarch64-pauth.xml: New file.
9818
9819 2019-03-20  Tom Tromey  <tromey@adacore.com>
9820
9821         * infrun.c (handle_inferior_event): Rename from
9822         handle_inferior_event_1.  Create a scoped_value_mark.
9823         (handle_inferior_event): Remove.
9824
9825 2019-03-19  Tom Tromey  <tromey@adacore.com>
9826
9827         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9828         * infrun.h (print_stop_event): Add "displays" parameter.
9829         * infrun.c (print_stop_event): Add "displays" parameter.
9830
9831 2019-03-19  Pedro Alves  <palves@redhat.com>
9832
9833         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9834         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9835         to -1.  Fix TABs vs spaces.
9836         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9837         * tui/tui-out.h (tui_ui_out) Add intro comments.
9838         <m_line, m_start_of_line>: In-class initialize, and add describing
9839         comment.
9840
9841 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9842
9843         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9844         variable names.
9845         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9846
9847 2019-03-18  Pedro Alves  <palves@redhat.com>
9848             Eli Zaretskii <eliz@gnu.org>
9849
9850         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9851         m_line and m_start_of_line.
9852
9853 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9854
9855         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9856         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9857         it returns a newline.  This fixes a regression in TU mode, whereby
9858         the next line is output on the same screen line as the user input.
9859
9860 2019-03-18  Tom Tromey  <tromey@adacore.com>
9861
9862         * minsyms.c (minimal_symbol_reader::install): Remove call to
9863         obstack_blank.
9864
9865 2019-03-18  Pedro Alves  <palves@redhat.com>
9866
9867         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9868         New globals.
9869         (apply_style): New, factored out from ...
9870         (apply_ansi_escape): ... this.  Handle reverse video mode.
9871         (tui_set_reverse_mode): New function.
9872         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9873         * tui/tui-winsource.c (tui_show_source_line): Use
9874         tui_set_reverse_mode instead of setting A_STANDOUT.
9875         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9876         New setter methods.
9877
9878 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9879
9880         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9881         Handle tabs.
9882
9883 2019-03-18  Tom Tromey  <tromey@adacore.com>
9884
9885         * ada-lang.c (empty_array): Add "high" parameter.
9886         (ada_evaluate_subexp): Update.
9887
9888 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9889
9890         * unittests/string_view-selftests.c: Define
9891         _initialize_string_view_selftests unconditionally.
9892
9893 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9894
9895         PR gdb/24350
9896         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9897
9898 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9899
9900         PR gdb/24351
9901         * windows-nat.c (display_selector): Fix format specifiers.
9902
9903 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9904
9905         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9906         tui_refill_source_window instead of tui_refresh_win, to update the
9907         current execution line.  This fixes redisplay of the current line
9908         when stepping through the code with "next" or "step".
9909
9910 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9911
9912         * source-cache.c (source_cache::get_source_lines): Call
9913         find_source_lines to initialize s->nlines.  This fixes vertical
9914         scrolling of TUI source window when the DOWN arrow is pressed.
9915
9916 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9917
9918         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9919         linux-thread-db.c (_initialize_thread_db): Likewise.
9920
9921 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9922
9923         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9924         wclrtoeol in tui_show_source_line".  This reverts changes made in
9925         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9926
9927 2019-03-15  Tom Tromey  <tom@tromey.com>
9928
9929         * symtab.h (struct minimal_symbol): Derive from
9930         general_symbol_info.
9931         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9932         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9933         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9934         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9935         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9936         (MSYMBOL_SEARCH_NAME): Update.
9937         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9938         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9939         * minsyms.c (minimal_symbol_reader::record_full): Update.
9940
9941 2019-03-15  Tom Tromey  <tom@tromey.com>
9942
9943         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9944
9945 2019-03-15  Tom Tromey  <tom@tromey.com>
9946
9947         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9948         unique_xmalloc_ptr.
9949         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9950         Update.
9951         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9952         (build_minimal_symbol_hash_tables)
9953         (minimal_symbol_reader::install): Update.
9954
9955 2019-03-15  Tom Tromey  <tom@tromey.com>
9956
9957         * symtab.c (create_demangled_names_hash): Update.
9958         (symbol_set_names): Update.
9959         * objfiles.h (struct objfile_per_bfd_storage)
9960         <demangled_names_hash>: Now an htab_up.
9961         * objfiles.c (objfile_per_bfd_storage): Simplify.
9962
9963 2019-03-15  Tom Tromey  <tom@tromey.com>
9964
9965         * objfiles.h (struct objfile_per_bfd_storage): Declare
9966         destructor.
9967         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9968         New.
9969         (get_objfile_bfd_data): Use new.  Don't initialize
9970         language_of_main.
9971         (free_objfile_per_bfd_storage): Remove.
9972         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9973
9974 2019-03-15  Tom Tromey  <tom@tromey.com>
9975
9976         * symfile.c (reread_symbols): Update.
9977         * objfiles.c (objfile::objfile): Update.
9978         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9979         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9980         comment.
9981         (minimal_symbol_reader::install): Update.
9982         (terminate_minimal_symbol_table): Remove.
9983         * jit.c (jit_object_close_impl): Update.
9984
9985 2019-03-15  Tom Tromey  <tom@tromey.com>
9986
9987         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9988         initializations.
9989
9990 2019-03-15  Tom Tromey  <tom@tromey.com>
9991
9992         * objfiles.h (struct objfile_per_bfd_storage)
9993         <demangled_hash_languages>: Now a bitset.
9994         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9995         (lookup_minimal_symbol): Update.
9996
9997 2019-03-15  Tom Tromey  <tom@tromey.com>
9998
9999         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10000         Don't return the symbol.
10001         * coffread.c (record_minimal_symbol): Use record_full.
10002
10003 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10004
10005         The MS-Windows port of ncurses fails to switch to a color pair if
10006         one or both of the colors are the implicit default colors.  This
10007         change records the default colors when TUI is initialized, and
10008         then specifies them explicitly when a color pair uses the default
10009         colors.  This allows color styling in TUI mode on MS-Windows.
10010
10011         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10012         ncurses_norm_attr.
10013         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10014         colors in ncurses_norm_attr.
10015         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10016         "none", replace it with the default color recorded in
10017         ncurses_norm_attr.
10018
10019 2019-03-14  Tom Tromey  <tromey@adacore.com>
10020
10021         * source-cache.h (class source_cache) <get_source_lines>: Return
10022         std::string.
10023         * source-cache.c (source_cache::extract_lines): Handle case where
10024         first_pos==npos.  Return std::string.
10025         (source_cache::get_source_lines): Update.
10026
10027 2019-03-14  Tom Tromey  <tromey@adacore.com>
10028
10029         * NEWS: Add item for "style sources" commands.
10030         * source-cache.c (source_cache::get_source_lines): Check
10031         source_styling.
10032         * cli/cli-style.c (source_styling): New global.
10033         (_initialize_cli_style): Add "style sources" commands.
10034         (show_style_sources): New function.
10035         * cli/cli-style.h (source_styling): Declare.
10036
10037 2019-03-14  Pedro Alves  <palves@redhat.com>
10038             Tom Tromey  <tromey@adacore.com>
10039
10040         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10041         * tui/tui-winsource.c (tui_refill_source_window): New function,
10042         from...
10043         (tui_horizontal_source_scroll): ... here.  Move some logic.
10044         * cli/cli-style.c (set_style_enabled): Notify new observable.
10045         * tui/tui-hooks.c (tui_redisplay_source): New function.
10046         (tui_attach_detach_observers): Attach or detach
10047         tui_redisplay_source.
10048         * observable.h (source_styling_changed): New observable.
10049         * observable.c: Define source_styling_changed observable.
10050
10051 2019-03-13  Tom Tromey  <tromey@adacore.com>
10052
10053         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10054         (i386_gnu_nat_target::store_registers): Update.
10055         * target-debug.h (target_debug_print_std_string): New macro.
10056         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10057         * windows-tdep.c (display_one_tib): Update.
10058         * tui/tui-stack.c (tui_make_status_line): Update.
10059         * top.c (print_inferior_quit_action): Update.
10060         * thread.c (thr_try_catch_cmd): Update.
10061         (add_thread_with_info): Update.
10062         (thread_target_id_str): Update.
10063         (thr_try_catch_cmd): Update.
10064         (thread_command): Update.
10065         (thread_find_command): Update.
10066         * record-btrace.c (record_btrace_target::info_record)
10067         (record_btrace_resume_thread, record_btrace_target::resume)
10068         (record_btrace_cancel_resume, record_btrace_step_thread)
10069         (record_btrace_target::wait, record_btrace_target::wait)
10070         (record_btrace_target::wait, record_btrace_target::stop): Update.
10071         * progspace.c (print_program_space): Update.
10072         * process-stratum-target.c
10073         (process_stratum_target::thread_address_space): Update.
10074         * linux-fork.c (linux_fork_mourn_inferior)
10075         (detach_checkpoint_command, info_checkpoints_command)
10076         (linux_fork_context): Update.
10077         (linux_fork_detach): Update.
10078         (class scoped_switch_fork_info): Update.
10079         (delete_checkpoint_command): Update.
10080         * infrun.c (follow_fork_inferior): Update.
10081         (follow_fork_inferior): Update.
10082         (proceed_after_vfork_done): Update.
10083         (handle_vfork_child_exec_or_exit): Update.
10084         (follow_exec): Update.
10085         (displaced_step_prepare_throw): Update.
10086         (displaced_step_restore): Update.
10087         (start_step_over): Update.
10088         (resume_1): Update.
10089         (clear_proceed_status_thread): Update.
10090         (proceed): Update.
10091         (print_target_wait_results): Update.
10092         (do_target_wait): Update.
10093         (context_switch): Update.
10094         (stop_all_threads): Update.
10095         (restart_threads): Update.
10096         (finish_step_over): Update.
10097         (handle_signal_stop): Update.
10098         (switch_back_to_stepped_thread): Update.
10099         (keep_going_pass_signal): Update.
10100         (print_exited_reason): Update.
10101         (normal_stop): Update.
10102         * inferior.c (inferior_pid_to_str): Change return type.
10103         (print_selected_inferior): Update.
10104         (add_inferior): Update.
10105         (detach_inferior): Update.
10106         * dummy-frame.c (fprint_dummy_frames): Update.
10107         * dcache.c (dcache_info_1): Update.
10108         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10109         (btrace_fetch, btrace_clear): Update.
10110         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10111         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10112         type.
10113         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10114         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10115         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10116         * gdbarch.c, gdbarch.h: Rebuild.
10117         * gdbarch.sh (core_pid_to_str): Change return type.
10118         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10119         return type.
10120         (windows_nat_target::pid_to_str): Change return type.
10121         (windows_delete_thread): Update.
10122         (windows_nat_target::attach): Update.
10123         (windows_nat_target::files_info): Update.
10124         * target-delegates.c: Rebuild.
10125         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10126         return type.
10127         (sol_thread_target::pid_to_str): Change return type.
10128         * remote.c (class remote_target) <pid_to_str>: Change return
10129         type.
10130         (remote_target::pid_to_str): Change return type.
10131         (extended_remote_target::attach, remote_target::remote_stop_ns)
10132         (remote_target::remote_notif_remove_queued_reply)
10133         (remote_target::push_stop_reply, remote_target::disable_btrace):
10134         Update.
10135         (extended_remote_target::attach): Update.
10136         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10137         type.
10138         (gdbsim_target::pid_to_str): Change return type.
10139         * ravenscar-thread.c (struct ravenscar_thread_target)
10140         <pid_to_str>: Change return type.
10141         (ravenscar_thread_target::pid_to_str): Change return type.
10142         * procfs.c (class procfs_target) <pid_to_str>: Change return
10143         type.
10144         (procfs_target::pid_to_str): Change return type.
10145         (procfs_target::attach): Update.
10146         (procfs_target::detach): Update.
10147         (procfs_target::fetch_registers): Update.
10148         (procfs_target::store_registers): Update.
10149         (procfs_target::wait): Update.
10150         (procfs_target::files_info): Update.
10151         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10152         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10153         return type.
10154         (nto_procfs_target::pid_to_str): Change return type.
10155         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10156         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10157         return type.
10158         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10159         (exit_lwp): Update.
10160         (attach_proc_task_lwp_callback, get_detach_signal)
10161         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10162         (linux_nat_target::resume, wait_lwp, stop_callback)
10163         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10164         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10165         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10166         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10167         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10168         type.
10169         (inf_ptrace_target::attach): Update.
10170         (inf_ptrace_target::files_info): Update.
10171         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10172         type.
10173         (go32_nat_target::pid_to_str): Change return type.
10174         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10175         (gnu_nat_target::wait): Update.
10176         (gnu_nat_target::wait): Update.
10177         (gnu_nat_target::resume): Update.
10178         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10179         (fbsd_nat_target::wait): Update.
10180         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10181         type.
10182         (darwin_nat_target::attach): Update.
10183         * corelow.c (class core_target) <pid_to_str>: Change return type.
10184         (core_target::pid_to_str): Change return type.
10185         * target.c (normal_pid_to_str): Change return type.
10186         (default_pid_to_str): Likewise.
10187         (target_pid_to_str): Change return type.
10188         (target_translate_tls_address): Update.
10189         (target_announce_detach): Update.
10190         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10191         return type.
10192         (bsd_uthread_target::pid_to_str): Change return type.
10193         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10194         type.
10195         (bsd_kvm_target::pid_to_str): Change return type.
10196         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10197         return type.
10198         (aix_thread_target::pid_to_str): Change return type.
10199         * target.h (struct target_ops) <pid_to_str>: Change return type.
10200         (target_pid_to_str, normal_pid_to_str): Likewise.
10201         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10202         type.
10203         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10204         type.
10205         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10206         return type.
10207         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10208         type.
10209         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10210         type.
10211         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10212         return type.
10213
10214 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10215
10216         * NEWS: Mention that the new default MI version is 3.  Mention
10217         changes to the output of commands and events that deal with
10218         multi-location breakpoints.
10219         * breakpoint.c: Include "mi/mi-out.h".
10220         (print_one_breakpoint): Change output syntax if using MI version
10221         >= 3.
10222         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10223         New.
10224         (mi_multi_location_breakpoint_output_fixed): New.
10225         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10226         (mi_cmd_fix_multi_location_breakpoint_output): New.
10227         (mi_multi_location_breakpoint_output_fixed): New.
10228         * mi/mi-cmds.c (mi_cmds): Register command
10229         -fix-multi-location-breakpoint-output.
10230         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10231         interpreter "mi".
10232
10233 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10234
10235         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10236         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10237         instantiate mi_ui_out based on interpreter name.
10238         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10239         * mi/mi-main.c (mi_load_progress): Likewise.
10240
10241 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10242
10243         * NEWS: Combine separate "New targets" sections for 8.3.
10244
10245 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10246
10247         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10248         (ppcfbsd_init_abi): Install gdbarch
10249         "fetch_tls_load_module_address" and "get_thread_local_address"
10250         methods.
10251
10252 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10253
10254         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10255         (riscv_fbsd_init_abi): Install gdbarch
10256         "fetch_tls_load_module_address" and "get_thread_local_address"
10257         methods.
10258
10259 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10260
10261         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10262         (i386fbsd_init_abi): Install gdbarch
10263         "fetch_tls_load_module_address" and "get_thread_local_address"
10264         methods.
10265
10266 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10267
10268         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10269         (amd64fbsd_init_abi): Install gdbarch
10270         "fetch_tls_load_module_address" and "get_thread_local_address"
10271         methods.
10272
10273 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10274
10275         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10276         (struct fbsd_pspace_data): New type.
10277         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10278         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10279         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10280         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10281         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10282
10283 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10284
10285         * gdbtypes.c (lookup_struct_elt): New function.
10286         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10287         * gdbtypes.h (struct struct_elt): New type.
10288         (lookup_struct_elt): New prototype.
10289
10290 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10291
10292         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10293         remove disabled code block.
10294
10295 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10296
10297         * gdbarch.sh (get_thread_local_address): New method.
10298         * gdbarch.h, gdbarch.c: Regenerate.
10299         * target.c (target_translate_tls_address): Use
10300         gdbarch_get_thread_local_address if present instead of
10301         target::get_thread_local_address.
10302
10303 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10304
10305         * target.h (target::get_thread_local_address): Update comment.
10306
10307 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10308
10309         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10310         objfile->separate_debug_objfile_backlink if not NULL.
10311
10312 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10313
10314         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10315         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10316         (amd64bsd_store_inferior_registers): Likewise.
10317         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10318         Enable segment base registers.
10319         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10320         PT_GETFSBASE and PT_GETGSBASE.
10321         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10322         PT_SETGSBASE.
10323         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10324         segment base registers.
10325         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10326
10327 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10328
10329         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10330         Update calls to i386_target_description to add 'segments'
10331         parameter.
10332         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10333         add segment base registers.
10334         * arch/i386.c (i386_create_target_description): Add 'segments'
10335         parameter to enable segment base registers.
10336         * arch/i386.h (i386_create_target_description): Likewise.
10337         * features/i386/32bit-segments.xml: New file.
10338         * features/i386/32bit-segments.c: Generate.
10339         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10340         call to i386_target_description to add 'segments' parameter.
10341         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10342         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10343         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10344         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10345         if feature is present.
10346         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10347         Add 'segments' parameter to call to i386_target_description.
10348         (i386_target_description): Add 'segments' parameter to enable
10349         segment base registers.
10350         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10351         to call to i386_target_description.
10352         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10353         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10354         Define I386_NUM_REGS.
10355         (i386_target_description): Add 'segments' parameter to enable
10356         segment base registers.
10357
10358 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10359
10360         PR/24325
10361         * source-cache.c: #undef open and close, to avoid unresolved
10362         externals during linking.
10363
10364 2019-03-12  Tom Tromey  <tromey@adacore.com>
10365
10366         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10367         const.  Add initializers.
10368         (_initialize_remote): Don't initialize ptid globals.
10369
10370 2019-03-12  Pedro Alves  <palves@redhat.com>
10371
10372         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10373
10374 2019-03-12  Pedro Alves  <palves@redhat.com>
10375
10376         * cp-name-parser.y (main): Remove unused 'len' variable.
10377
10378 2019-03-12  Tom Tromey  <tromey@adacore.com>
10379
10380         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10381         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10382
10383 2019-03-12  Tom Tromey  <tromey@adacore.com>
10384
10385         * linux-nat.c (iterate_over_lwps): Update.
10386         (stop_callback): Remove parameter.
10387         (stop_wait_callback, detach_callback, resume_set_callback)
10388         (select_singlestep_lwp_callback, set_ignore_sigint)
10389         (status_callback, resumed_callback, resume_clear_callback)
10390         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10391         data parameter.
10392         (linux_nat_target::detach, linux_nat_target::resume)
10393         (linux_stop_and_wait_all_lwps, select_event_lwp)
10394         (linux_nat_filter_event, linux_nat_wait_1)
10395         (linux_nat_target::kill, linux_nat_target::stop)
10396         (linux_nat_target::stop): Update.
10397         (linux_nat_resume_callback): Change type.
10398         (resume_stopped_resumed_lwps, count_events_callback)
10399         (select_event_lwp_callback): Likewise.
10400         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10401         * arm-linux-nat.c (struct update_registers_data): Remove.
10402         (update_registers_callback): Change type.
10403         (arm_linux_insert_hw_breakpoint1): Update.
10404         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10405         parameter.
10406         (x86_linux_dr_set_addr): Update.
10407         (x86_linux_dr_set_control): Update.
10408         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10409         (iterate_over_lwps): Use gdb::function_view.
10410         * nat/aarch64-linux-hw-point.c (struct
10411         aarch64_dr_update_callback_param): Remove.
10412         (debug_reg_change_callback): Change type.
10413         (aarch64_notify_debug_reg_change): Update.
10414         * s390-linux-nat.c (s390_refresh_per_info): Update.
10415
10416 2019-03-11  Tom Tromey  <tromey@adacore.com>
10417
10418         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10419         redundant assignment to "this_cu".
10420
10421 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10422
10423         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10424
10425 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10426
10427         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10428         from...
10429         (rank_one_type): ... this.
10430
10431 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10432
10433         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10434         from...
10435         (rank_one_type): ... this.
10436
10437 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10438
10439         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10440         from...
10441         (rank_one_type): ... this.
10442
10443 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10444
10445         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10446         from...
10447         (rank_one_type): ... this.
10448
10449 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10450
10451         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10452         from...
10453         (rank_one_type): ... this.
10454
10455 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10456
10457         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10458         from...
10459         (rank_one_type): ... this.
10460
10461 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10462
10463         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10464         from...
10465         (rank_one_type): ... this.
10466
10467 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10468
10469         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10470         from...
10471         (rank_one_type): ... this.
10472
10473 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10474
10475         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10476         from...
10477         (rank_one_type): ... this.
10478
10479 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10480
10481         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10482         from...
10483         (rank_one_type): ... this.
10484
10485 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10486
10487         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10488         from...
10489         (rank_one_type): ... this.
10490
10491 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10492
10493         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10494         from...
10495         (rank_one_type): ... this.
10496
10497 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10498
10499         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10500         inferior-events' shows the example events.
10501
10502 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10503
10504         Support styling on native MS-Windows console
10505
10506         PR/24315
10507         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10508         on MS-Windows if $TERM is not defined.
10509
10510         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10511
10512         * posix-hdep.c (gdb_console_fputs):
10513         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10514         functions.
10515         * ui-file.h (gdb_console_fputs): Add prototype.
10516
10517         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10518         back to fputs only if the former returns zero.
10519
10520 2019-03-07  Tom Tromey  <tom@tromey.com>
10521
10522         * symmisc.c (print_symbol_bcache_statistics): Update.
10523         (print_objfile_statistics): Update.
10524         * symfile.c (allocate_symtab): Update.
10525         * stabsread.c: Don't include bcache.h.
10526         * psymtab.h (struct psymbol_bcache): Don't declare.
10527         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10528         (psymbol_bcache_init, psymbol_bcache_free)
10529         (psymbol_bcache_get_bcache): Don't declare.
10530         * psymtab.c (struct psymbol_bcache): Remove.
10531         (psymtab_storage::psymtab_storage): Update.
10532         (psymtab_storage::~psymtab_storage): Update.
10533         (psymbol_bcache_init, psymbol_bcache_free)
10534         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10535         (add_psymbol_to_bcache): Update.
10536         (allocate_psymtab): Update.
10537         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10538         macro_cache>: No longer pointers.
10539         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10540         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10541         * macrotab.c (macro_bcache): Update.
10542         * macroexp.c: Don't include bcache.h.
10543         * gdbtypes.c (check_types_worklist): Update.
10544         (types_deeply_equal): Remove TRY/CATCH.  Update.
10545         * elfread.c (elf_symtab_read): Update.
10546         * dwarf2read.c: Don't include bcache.h.
10547         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10548         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10549         (print_bcache_statistics, bcache_memory_used): Don't declare.
10550         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10551         methods.  Rename all data members.
10552         * bcache.c (struct bcache): Move to bcache.h.
10553         (bcache::expand_hash_table): Rename from expand_hash_table.
10554         (bcache): Remove.
10555         (bcache::insert): Rename from bcache_full.
10556         (bcache::compare): Rename from bcache_compare.
10557         (bcache_xmalloc): Remove.
10558         (bcache::~bcache): Rename from bcache_xfree.
10559         (bcache::print_statistics): Rename from print_bcache_statistics.
10560         (bcache::memory_used): Rename from bcache_memory_used.
10561
10562 2019-03-07  Pedro Alves  <palves@redhat.com>
10563
10564         * infrun.c (normal_stop): Also check for
10565         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10566
10567 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10568
10569         * f-lang.c (value_from_host_double): Moved to...
10570         * value.c (value_from_host_double): ...here.
10571         * value.h (value_from_host_double): Declare.
10572         * guile/scm-math.c (vlscm_convert_typed_number): Use
10573         value_from_host_double.
10574         (vlscm_convert_number): Likewise.
10575         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10576         * python/py-value.c (convert_value_from_python): Likewise.
10577
10578 2019-03-06  Tom Tromey  <tom@tromey.com>
10579
10580         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10581
10582 2019-03-06  Tom Tromey  <tom@tromey.com>
10583
10584         * utils.h (free_current_contents): Don't declare.
10585         * utils.c (free_current_contents): Remove.
10586
10587 2019-03-06  Tom Tromey  <tom@tromey.com>
10588
10589         * top.c (quit_force): Update.
10590         * main.c (captured_command_loop): Update.
10591         * common/new-op.c (operator new): Update.
10592         * common/common-exceptions.c (struct catcher)
10593         <save_cleanup_chain>: Remove member.
10594         (exceptions_state_mc_init): Update.
10595         (exception_try_scope_entry): Return nullptr.
10596         (exception_try_scope_exit, exception_rethrow)
10597         (throw_exception_sjlj, throw_exception_cxx): Update.
10598         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10599         (all_cleanups, do_cleanups, discard_cleanups)
10600         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10601         (restore_cleanups, restore_final_cleanups): Don't declare.
10602         (do_final_cleanups): Remove parameter.
10603         * common/cleanups.c (cleanup_chain, make_cleanup)
10604         (make_cleanup_dtor, all_cleanups, do_cleanups)
10605         (discard_my_cleanups, discard_cleanups)
10606         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10607         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10608         (null_cleanup): Remove.
10609         (do_final_cleanups): Remove parameter.
10610
10611 2019-03-06  Tom Tromey  <tom@tromey.com>
10612
10613         * remote.c (remote_target::remote_parse_stop_reply): Use
10614         unique_xmalloc_ptr.
10615
10616 2019-03-06  Tom Tromey  <tom@tromey.com>
10617
10618         * stabsread.c (struct stabs_field_info): Rename from field_info.
10619         <list, fnlist>: Add initializers.
10620         <obstack>: New member.
10621         (read_member_functions, read_struct_fields, read_baseclasses):
10622         Allocate on obstack.  Don't use cleanups.
10623         (read_one_struct_field, read_member_functions, read_struct_fields)
10624         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10625         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10626         (read_struct_type): Update.
10627
10628 2019-03-06  Tom Tromey  <tom@tromey.com>
10629
10630         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10631         * common/filestuff.h (make_cleanup_close): Don't declare.
10632         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10633         Remove.
10634
10635 2019-03-06  Tom Tromey  <tom@tromey.com>
10636
10637         * solib-aix.c: Use make_scope_exit.
10638
10639 2019-03-06  Tom Tromey  <tom@tromey.com>
10640
10641         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10642         Use make_scope_exit.
10643
10644 2019-03-06  Tom Tromey  <tom@tromey.com>
10645
10646         * solib-svr4.c (disable_probes_interface): Remove parameter.
10647         (svr4_handle_solib_event): Use make_scope_exit.
10648
10649 2019-03-06  Tom Tromey  <tom@tromey.com>
10650
10651         * remote.c (struct stop_reply_deleter): Remove.
10652         (stop_reply_up): Update.
10653         (struct stop_reply): Derive from notif_event.  Don't typedef.
10654         <regcache>: Now a std::vector.
10655         (stop_reply_xfree): Remove.
10656         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10657         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10658         (remote_target::discard_pending_stop_replies): Use delete.
10659         (remote_target::remote_parse_stop_reply): Update.
10660         (remote_target::process_stop_reply): Update.
10661         * remote-notif.h (struct notif_event): Add virtual destructor.
10662         Remove "dtr" member.
10663         (struct notif_client) <alloc_event>: Return a unique_ptr.
10664         (notif_event_xfree): Don't declare.
10665         (notif_event_up): New typedef.
10666         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10667         (notif_event_xfree, do_notif_event_xfree): Remove.
10668         (remote_notif_state_xfree): Update.
10669
10670 2019-03-06  Tom Tromey  <tom@tromey.com>
10671
10672         * infrun.c (displaced_step_clear_cleanup): Now a
10673         forward_scope_exit type.
10674         (displaced_step_prepare_throw): Update.
10675         (displaced_step_fixup): Update.
10676
10677 2019-03-06  Tom Tromey  <tom@tromey.com>
10678
10679         * inferior.h (class inferior): Update comment.
10680         * gdbthread.h (class thread_info): Update comment.
10681
10682 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10683             Tom Tromey  <tom@tromey.com>
10684
10685         * stabsread.h (struct stab_section_list): Remove.
10686         (coffstab_build_psymtabs): Update.
10687         * dbxread.c (symbuf_sections): Now a std::vector.
10688         (sect_idx): New global.
10689         (fill_symbuf): Update.
10690         (coffstab_build_psymtabs): Change type of stabsects parameter.
10691         Update.
10692         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10693         std::vector.
10694         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10695         (coff_locate_sections): Update.
10696         (coff_symfile_read): Remove cleanups.  Update.
10697         (init_stringtab): Add storage parameter.
10698         (free_stringtab, free_stringtab_cleanup): Remove.
10699         (init_lineno): Add storage parameter.
10700         (free_linetab, free_linetab_cleanup): Remove.
10701
10702 2019-03-06  Pedro Alves  <palves@redhat.com>
10703
10704         * linux-fork.c (fork_info::clobber_regs): Delete.
10705         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10706         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10707         comment.  Adjust.
10708         (scoped_switch_fork_info::scoped_switch_fork_info)
10709         (checkpoint_command, linux_fork_context): Adjust
10710         fork_save_infrun_state calls.
10711
10712 2019-03-06  Pedro Alves  <palves@redhat.com>
10713
10714         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10715         (inf_has_multiple_threads): Return 'bool' and rewrite using
10716         inferior_info::threads().
10717
10718 2019-03-06  Pedro Alves  <palves@redhat.com>
10719
10720         * linux-fork.c: Include <list>.
10721         (fork_list): Now a std::list instance.
10722         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10723         (forks_exist_p, find_last_fork): Adjust.
10724         (new_fork): Delete.
10725         (one_fork_p): New.
10726         (add_fork): Adjust.
10727         (free_fork): Delete, folded into fork_info::~fork_info().
10728         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10729         Adjust.
10730         (init_fork_list): Delete.
10731         (linux_fork_killall, linux_fork_mourn_inferior)
10732         (linux_fork_detach, info_checkpoints_command): Adjust.
10733         (_initialize_linux_fork): No longer call init_fork_list.
10734
10735 2019-03-06  Pedro Alves  <palves@redhat.com>
10736
10737         * linux-fork.c (new_fork): New, split out of ...
10738         (add_fork): ... this.  Return void.  Move "first fork" special
10739         case from here, to ...
10740         (checkpoint_command): ... here.
10741         * linux-linux.h (add_fork): Return void.
10742
10743 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10744
10745         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10746
10747 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10748             Chris January  <chris.january@arm.com>
10749             David Lecomber  <david.lecomber@arm.com>
10750
10751         * f-exp.y: New token, UNOP_INTRINSIC.
10752         (exp): New pattern using UNOP_INTRINSIC token.
10753         (f77_keywords): Add 'abs' keyword.
10754         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10755         (value_from_host_double): New function.
10756         (evaluate_subexp_f): Support UNOP_ABS.
10757
10758 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10759
10760         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10761         types.
10762
10763 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10764
10765         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10766         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10767         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10768
10769 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10770
10771         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10772
10773 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10774             Chris January  <chris.january@arm.com>
10775
10776         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10777         * f-exp.y: Define 'KIND' token.
10778         (exp): New pattern for KIND expressions.
10779         (ptype): Handle types with a kind extension.
10780         (direct_abs_decl): Extend to spot kind extensions.
10781         (f77_keywords): Add 'kind' to the list.
10782         (push_kind_type): New function.
10783         (convert_to_kind_type): New function.
10784         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10785         * parse.c (operator_length_standard): Likewise.
10786         * parser-defs.h (enum type_pieces): Add tp_kind.
10787         * std-operator.def: Add UNOP_KIND.
10788
10789 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10790
10791         * f-exp.y (f_parse): Set yydebug.
10792
10793 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10794
10795         * f-lang.c (evaluate_subexp_f): New function.
10796         (exp_descriptor_f): New global.
10797         (f_language_defn): Use exp_descriptor_f instead of
10798         exp_descriptor_standard.
10799
10800 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10801
10802         * f-exp.y (struct token): Add comments.
10803         (dot_ops): Remove uppercase versions and the end marker.
10804         (f77_keywords): Likewise.
10805         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10806         entries in the dot_ops array are case insensitive, and use
10807         strncasecmp to compare strings.  Also some whitespace cleanup in
10808         this area.  Similar for the f77_keywords array, except entries in
10809         this list might be case sensitive.
10810
10811 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10812
10813         * f-exp.y (struct f77_boolean_val): Add comments.
10814         (boolean_values): Remove uppercase versions, and end marker.
10815         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10816         and use strncasecmp to achieve case insensitivity.  Additionally,
10817         perform whitespace cleanup around this code.
10818
10819 2019-03-06  Tom Tromey  <tromey@adacore.com>
10820
10821         * remote-sim.c (gdbsim_target_open): Use result of
10822         gdb_argv::release.
10823
10824 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10825         Dirk Schubert  <dirk.schubert@arm.com>
10826         Chris January  <chris.january@arm.com>
10827
10828         * eval.c (evaluate_subexp_standard): Call Fortran argument
10829         wrapping logic.
10830         * f-lang.c (struct value): A value which can be passed into a
10831         Fortran function call.
10832         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10833         where appropriate.
10834         (struct type): Value ready for a Fortran function call.
10835         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10836         is needed.
10837         * f-lang.h (fortran_argument_convert): Declaration.
10838         (fortran_preserve_arg_pointer): Declaration.
10839         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10840
10841 2019-03-05  Tom Tromey  <tromey@adacore.com>
10842
10843         * python/py-prettyprint.c (print_string_repr): Remove #if.
10844         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10845
10846 2019-03-05  Tom Tromey  <tromey@adacore.com>
10847
10848         * target.c (the_dummy_target): Move later.  Change type to
10849         "dummy_target".
10850         (initialize_targets): Don't initialize the_dummy_target.
10851
10852 2019-03-05  Tom Tromey  <tromey@adacore.com>
10853
10854         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10855         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10856
10857 2019-03-05  Tom Tromey  <tromey@adacore.com>
10858
10859         * windows-nat.c (windows_nat_target::attach)
10860         (windows_nat_target::detach): Don't call gdb_flush.
10861         * valprint.c (generic_val_print, val_print, val_print_string):
10862         Don't call gdb_flush.
10863         * utils.c (defaulted_query): Don't call gdb_flush.
10864         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10865         * target.c (target_announce_detach): Don't call gdb_flush.
10866         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10867         * remote.c (extended_remote_target::attach): Don't call
10868         gdb_flush.
10869         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10870         * printcmd.c (do_examine): Don't call gdb_flush.
10871         (info_display_command): Don't call gdb_flush.
10872         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10873         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10874         * memattr.c (info_mem_command): Don't call gdb_flush.
10875         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10876         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10877         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10878         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10879         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10880         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10881         (gnu_nat_target::detach): Don't call gdb_flush.
10882         * f-valprint.c (f_val_print): Don't call gdb_flush.
10883         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10884         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10885         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10886         gdb_flush.
10887         * c-valprint.c (c_val_print): Don't call gdb_flush.
10888         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10889
10890 2019-03-05  Tom Tromey  <tromey@adacore.com>
10891
10892         * varobj.c (update_dynamic_varobj_children): Update.
10893         (install_default_visualizer): Use reset, not release.
10894         * value.c (set_internalvar): Update.
10895         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10896         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10897         ATTRIBUTE_UNUSED_RESULT.
10898
10899 2019-03-05  Tom Tromey  <tromey@adacore.com>
10900
10901         * remote.c (class scoped_remote_fd) <release>: Add
10902         ATTRIBUTE_UNUSED_RESULT.
10903
10904 2019-03-05  Tom Tromey  <tromey@adacore.com>
10905
10906         * macroexp.c (struct macro_buffer) <release>: Add
10907         ATTRIBUTE_UNUSED_RESULT.
10908
10909 2019-03-05  Tom Tromey  <tromey@adacore.com>
10910
10911         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10912         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10913         ATTRIBUTE_UNUSED_RESULT.
10914
10915 2019-03-05  Tom Tromey  <tromey@adacore.com>
10916
10917         * common/scoped_fd.h (class scoped_fd) <release>: Add
10918         ATTRIBUTE_UNUSED_RESULT.
10919
10920 2019-03-05  Tom Tromey  <tromey@adacore.com>
10921
10922         * parser-defs.h (struct parser_state) <release>: Add
10923         ATTRIBUTE_UNUSED_RESULT.
10924
10925 2019-03-05  Tom Tromey  <tromey@adacore.com>
10926
10927         * utils.h (class gdb_argv) <release>: Add
10928         ATTRIBUTE_UNUSED_RESULT.
10929         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10930
10931 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10932
10933         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10934         for-loop range, to avoid compiler warnings.
10935
10936         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10937         avoid compiler warnings about unused variables.
10938
10939         * NEWS: Mention end of support for native debugging on MS-Windows
10940         before XP.
10941
10942         PR gdb/24292
10943         * common/netstuff.c:
10944         * gdbserver/gdbreplay.c
10945         * gdbserver/remote-utils.c:
10946         * ser-tcp.c:
10947         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10948         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10949         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10950         'getaddrinfo' and 'freeaddrinfo' were not available before
10951         Windows XP, and mingw.org's MinGW headers by default define
10952         _WIN32_WINNT to 0x500.
10953
10954 2019-03-01  Gary Benson <gbenson@redhat.com>
10955
10956         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10957
10958 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10959             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10960
10961         PR gdb/8527
10962         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10963         set_sigint_trap, clear_sigint_trap.
10964
10965 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10966
10967         * target.c (target_detach): Clear the regcache and the
10968         frame cache.
10969
10970 2019-02-27  Pedro Alves  <palves@redhat.com>
10971
10972         * utils.c (set_screen_size): When we cap the height/width sizes,
10973         tweak the corresponding command variable to show "unlimited":
10974
10975 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10976             Pedro Alves  <palves@redhat.com>
10977
10978         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10979         before calling rl_set_screen_size.
10980
10981 2019-02-27  Tom Tromey  <tromey@adacore.com>
10982
10983         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10984         define.
10985         * python/py-value.c: Remove Python 2.4 workaround.
10986         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10987         workaround.
10988         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10989         Python 2.4 workaround.
10990         * python/python-internal.h: Remove Python 2.4 comment.
10991         (Py_ssize_t): Don't define.
10992         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10993         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10994         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10995         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10996         * python/python.c (do_start_initialization): Remove Python 2.4
10997         workaround.
10998         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10999         (print_children): Remove Python 2.4 workaround.
11000         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11001         workaround.
11002         (CHARBUFFERPROC_NAME): Remove.
11003         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11004         Python 2.4 workaround.
11005
11006 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11007
11008         * NEWS: Note minimum Python version.
11009
11010 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11011
11012         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11013         code from these functions.  Remove corresponding ifdefs.  Use
11014         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11015         Remove gotos and target of gotos.
11016         (infpy_search_memory): Likewise.
11017
11018 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11019
11020         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11021         (hppa_gdbarch_init): Don't register deleted functions with
11022         gdbarch.
11023
11024 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11025
11026         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11027         (h8300_unwind_sp): Delete.
11028         (h8300_dummy_id): Delete.
11029         (h8300_gdbarch_init): Don't register deleted functions with
11030         gdbarch.
11031
11032 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11033
11034         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11035         (ft32_unwind_pc): Delete.
11036         (ft32_unwind_sp): Delete.
11037         (ft32_gdbarch_init): Don't register deleted functions with
11038         gdbarch.
11039
11040 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11041
11042         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11043         (frv_unwind_pc): Delete.
11044         (frv_unwind_sp): Delete.
11045         (frv_gdbarch_init): Don't register deleted functions with
11046         gdbarch.
11047
11048 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11049
11050         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11051         (riscv_unwind_pc): Delete.
11052         (riscv_unwind_sp): Delete.
11053         (riscv_gdbarch_init): Don't register deleted functions with
11054         gdbarch.
11055
11056 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11057
11058         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11059         (csky_unwind_pc): Delete.
11060         (csky_unwind_sp): Delete.
11061         (csky_gdbarch_init): Don't register deleted functions with
11062         gdbarch.
11063
11064 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11065
11066         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11067         (cris_unwind_pc): Delete.
11068         (cris_unwind_sp): Delete.
11069         (cris_gdbarch_init): Don't register deleted functions with
11070         gdbarch.
11071
11072 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11073
11074         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11075         (bfin_unwind_pc): Delete.
11076         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11077
11078 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11079
11080         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11081         (arm_unwind_pc): Delete.
11082         (arm_unwind_sp): Delete.
11083         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11084
11085 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11086
11087         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11088         (arc_unwind_pc): Delete.
11089         (arc_unwind_sp): Delete.
11090         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11091
11092 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11093
11094         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11095         (alpha_unwind_pc): Delete.
11096         (alpha_gdbarch_init): Don't register deleted functions with
11097         gdbarch.
11098
11099 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11100
11101         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11102         (aarch64_unwind_pc): Delete.
11103         (aarch64_unwind_sp): Delete.
11104         (aarch64_gdbarch_init): Don't register deleted functions with
11105         gdbarch.
11106
11107 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11108
11109         * gdbtypes.c (type_align): Don't consider static members when
11110         computing structure alignment.
11111
11112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11113
11114         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11115         return 0 for other types.
11116         * arch-utils.c (default_type_align): Always return 0.
11117         * gdbarch.h: Regenerate.
11118         * gdbarch.sh (type_align): Extend comment.
11119         * gdbtypes.c (type_align): Add additional comments, always call
11120         gdbarch_type_align before applying the default rules.
11121         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11122         generic code will then apply a suitable default.
11123         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11124         types, return 0 for other types.
11125
11126 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11127
11128         * NEWS: Create a new section for the next release branch.
11129         Rename the section of the current branch, now that it has
11130         been cut.
11131
11132 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11133
11134         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11135         * version.in: Bump version to 8.3.50.DATE-git.
11136
11137 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11138
11139         * aix-thread.c (ptid_cmp): Remove unused variable.
11140         (get_signaled_thread): Likewise.
11141         (store_regs_user_thread): Likewise.
11142         (store_regs_kernel_thread): Likewise.
11143         (fetch_regs_kernel_thread): Remove shadowed variable.
11144
11145 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11146
11147         * features/riscv/32bit-cpu.xml: Add register numbers.
11148         * features/riscv/32bit-fpu.c: Regenerate.
11149         * features/riscv/32bit-fpu.xml: Add register numbers.
11150         * features/riscv/64bit-cpu.xml: Add register numbers.
11151         * features/riscv/64bit-fpu.c: Regenerate.
11152         * features/riscv/64bit-fpu.xml: Add register numbers.
11153
11154 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11155
11156         * NEWS: Mention two argument form of gdb.Value constructor.
11157         * python/py-value.c (convert_buffer_and_type_to_value): New
11158         function.
11159         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11160         Add support for handling an optional second argument.  Call
11161         convert_buffer_and_type_to_value as appropriate.
11162         * python/python-internal.h (Py_buffer_deleter): New struct.
11163         (Py_buffer_up): New typedef.
11164
11165 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11166
11167         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11168         instead of releasing ownership.
11169
11170 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11171
11172         * dwarf2read.c (open_and_init_dwp_file): Call
11173         elf_numsections instead of bfd_count_sections to initialize
11174         dwp_file->num_sections.
11175
11176 2019-02-25  Tom Tromey  <tromey@adacore.com>
11177
11178         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11179
11180 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11181
11182         * gcore.in: Add '--readnever' option when invoking GDB.
11183
11184 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11185
11186         * MAINTAINERS: Update my email address.
11187
11188 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11189
11190         * build-id.c (build_id_to_debug_bfd_1): New function.
11191         (build_id_to_debug_bfd): Look for separate debug file in
11192         sysroot.
11193
11194 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11195
11196         * gdbarch.sh: Update the copyright year range that is placed into
11197         generated files.
11198
11199 2019-02-22  Keith Seitz  <keiths@redhat.com>
11200
11201         PR symtab/23853
11202         * linespec.c (create_sals_line_offset): Search for the default
11203         symtab's filename instead of its fullname.
11204
11205 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11206
11207         * NEWS: Update style defaults.
11208
11209 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11210
11211         * main.c (captured_main_1): Disable styling in batch mode.
11212
11213 2019-02-20  Tom Tromey  <tom@tromey.com>
11214
11215         * symtab.c (symtab_symbol_info): Fix typos.
11216
11217 2019-02-20  Tom Tromey  <tromey@adacore.com>
11218
11219         * findcmd.c (_initialize_mem_search): Use upper case for
11220         metasyntactic variables.
11221
11222 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11223
11224         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11225         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11226
11227 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11228
11229         * top.h (source_file_name): Change to std::string.
11230         * top.c (source_file_name): Likewise.
11231         (command_line_input): Adjust.
11232         * cli/cli-script.c (script_from_file): Adjust.
11233
11234 2019-02-19  Tom Tromey  <tromey@adacore.com>
11235
11236         * ravenscar-thread.c
11237         (ravenscar_thread_target::update_thread_list): Don't call
11238         ada_build_task_list.
11239         * ada-lang.h (ada_build_task_list): Don't declare.
11240         * ada-tasks.c (struct ada_tasks_inferior_data)
11241         <task_list_valid_p>: Now bool.
11242         (read_known_tasks, ada_task_list_changed)
11243         (ada_tasks_invalidate_inferior_data): Update.
11244         (read_known_tasks_array): Return bool.
11245         (read_known_tasks_list): Likewise.
11246         (read_known_tasks): Return void.
11247         (ada_build_task_list): Now static.
11248
11249 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11250
11251         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11252         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11253
11254 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11255
11256         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11257         variant for ada_tasks_pspace_data_handle and
11258         ada_tasks_inferior_data_handle.
11259         (ada_tasks_pspace_data_cleanup): New function.
11260         (ada_tasks_inferior_data_cleanup): New function.
11261
11262 2019-02-17  Tom Tromey  <tom@tromey.com>
11263
11264         * macrotab.h (macro_source_fullname): Return a std::string.
11265         * macrotab.c (macro_include, check_for_redefinition)
11266         (macro_undef, macro_lookup_definition, foreach_macro)
11267         (foreach_macro_in_scope): Update.
11268         (macro_source_fullname): Return a std::string.
11269         * macrocmd.c (show_pp_source_pos): Update.
11270
11271 2019-02-17  Tom Tromey  <tom@tromey.com>
11272
11273         * macrocmd.c (show_pp_source_pos): Style the file names.
11274
11275 2019-02-17  Tom Tromey  <tom@tromey.com>
11276
11277         PR tui/24197:
11278         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11279
11280 2019-02-17  Tom Tromey  <tom@tromey.com>
11281
11282         * ada-lang.c (user_select_syms): Use filtered printing.
11283         * utils.c (wrap_style): New global.
11284         (desired_style): Remove.
11285         (emit_style_escape): Add stream parameter.
11286         (set_output_style, reset_terminal_style, prompt_for_continue):
11287         Update.
11288         (flush_wrap_buffer): Only flush gdb_stdout.
11289         (wrap_here): Set wrap_style.
11290         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11291         treat escape sequences as a character.  Change when wrap buffer is
11292         flushed.
11293         (fputs_styled): Do not set the output style when the default is
11294         requested.
11295         * ui-style.h (struct ui_file_style) <is_default>: New method.
11296         * source.c (print_source_lines_base): Emit escape sequences in one
11297         piece.
11298
11299 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11300
11301         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11302         integers and enumeration types.
11303
11304 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11305
11306         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11307         instead of lookup_symbol_in_language
11308         (do_exact_match): New function.
11309         (ada_get_symbol_name_matcher): Return do_exact_match when
11310         doing a verbatim match.
11311
11312 2019-02-15  Tom Tromey  <tromey@adacore.com>
11313
11314         * ravenscar-thread.c (ravenscar_thread_target::resume)
11315         (ravenscar_thread_target::wait): Special case wildcard requests.
11316
11317 2019-02-15  Tom Tromey  <tromey@adacore.com>
11318
11319         * ravenscar-thread.c (base_ptid): Remove.
11320         (struct ravenscar_thread_target) <close>: New method.
11321         <m_base_ptid>: New member.
11322         <update_inferior_ptid, active_task, task_is_currently_active,
11323         runtime_initialized>: Declare methods.
11324         <ravenscar_thread_target>: Add constructor.
11325         (ravenscar_thread_target::task_is_currently_active)
11326         (ravenscar_thread_target::update_inferior_ptid)
11327         (ravenscar_runtime_initialized): Rename.  Now methods.
11328         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11329         (ravenscar_thread_target::update_thread_list): Update.
11330         (ravenscar_thread_target::active_task): Now method.
11331         (ravenscar_thread_target::store_registers)
11332         (ravenscar_thread_target::prepare_to_store)
11333         (ravenscar_thread_target::prepare_to_store)
11334         (ravenscar_thread_target::mourn_inferior): Update.
11335         (ravenscar_inferior_created): Use "new" to create target.
11336         (ravenscar_thread_target::get_ada_task_ptid): Update.
11337         (_initialize_ravenscar): Don't initialize base_ptid.
11338         (ravenscar_ops): Remove global.
11339
11340 2019-02-15  Tom Tromey  <tromey@adacore.com>
11341
11342         * target.h (push_target): Declare new overload.
11343         * target.c (push_target): New overload, taking an rvalue reference.
11344         * remote.c (remote_target::open_1): Use push_target overload.
11345         * corelow.c (core_target_open): Use push_target overload.
11346
11347 2019-02-15  Tom Tromey  <tromey@adacore.com>
11348
11349         * ravenscar-thread.c (is_ravenscar_task)
11350         (ravenscar_task_is_currently_active): Return bool.
11351         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11352         (_initialize_ravenscar): Remove "(void)".
11353         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11354         Return bool.
11355
11356 2019-02-15  Tom Tromey  <tromey@adacore.com>
11357
11358         * ravenscar-thread.c (ravenscar_runtime_initializer)
11359         (has_ravenscar_runtime, get_running_thread_id)
11360         (ravenscar_thread_target::resume): Fix indentation.
11361
11362 2019-02-15  Tom Tromey  <tromey@adacore.com>
11363
11364         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11365         from ravenscar_arch_ops.
11366         (sparc_ravenscar_ops::fetch_registers)
11367         (sparc_ravenscar_ops::store_registers): Now methods.
11368         (sparc_ravenscar_prepare_to_store): Remove.
11369         (sparc_ravenscar_ops): Redefine.
11370         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11371         methods and destructor.  Remove members.
11372         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11373         (ravenscar_thread_target::store_registers)
11374         (ravenscar_thread_target::prepare_to_store): Update.
11375         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11376         Remove.
11377         (struct ppc_ravenscar_powerpc_ops): Derive from
11378         ravenscar_arch_ops.
11379         (ppc_ravenscar_powerpc_ops::fetch_registers)
11380         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11381         (ppc_ravenscar_powerpc_ops): Redefine.
11382         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11383         (ppc_ravenscar_e500_ops::fetch_registers)
11384         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11385         (ppc_ravenscar_e500_ops): Redefine.
11386         * aarch64-ravenscar-thread.c
11387         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11388         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11389         (aarch64_ravenscar_fetch_registers)
11390         (aarch64_ravenscar_store_registers): Now methods.
11391         (aarch64_ravenscar_ops): Redefine.
11392
11393 2019-02-15  Tom Tromey  <tromey@adacore.com>
11394
11395         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11396         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11397         (ravenscar_thread_target::stopped_by_watchpoint)
11398         (ravenscar_thread_target::stopped_data_address)
11399         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11400
11401 2019-02-15  Tom Tromey  <tromey@adacore.com>
11402
11403         * ravenscar-thread.c: Fix some typos.
11404
11405 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11406             Tom Tromey  <tromey@adacore.com>
11407
11408         * ada-lang.c (ada_exception_sal): Change addr_string to a
11409         std::string.
11410         (create_ada_exception_catchpoint): Update.
11411
11412 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11413             Tom Tromey  <tromey@adacore.com>
11414
11415         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11416         (bp_location_ops): Remove.
11417         (base_breakpoint_allocate_location): Update.
11418         (free_bp_location): Update.
11419         * ada-lang.c (class ada_catchpoint_location)
11420         <ada_catchpoint_location>: Remove ops parameter.
11421         (ada_catchpoint_location_dtor): Remove.
11422         (ada_catchpoint_location_ops): Remove.
11423         (allocate_location_exception): Update.
11424         * breakpoint.h (struct bp_location_ops): Remove.
11425         (class bp_location) <bp_location>: Remove bp_location_ops
11426         parameter.
11427         <~bp_location>: Add destructor.
11428         <ops>: Remove.
11429
11430 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11431             Pedro Alves  <palves@redhat.com>
11432
11433         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11434         'PATH_MAX'.
11435
11436 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11437             Samuel Thibault  <samuel.thibault@gnu.org>
11438             Thomas Schwinge  <thomas@codesourcery.com>
11439
11440         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11441         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11442
11443 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11444
11445         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11446         (check_empty): Use "const char *".
11447
11448         * gnu-nat.c (gnu_nat_target::detach): Instead of
11449         'detach_inferior (pid)' call
11450         'detach_inferior (find_inferior_pid (pid))'.
11451
11452         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11453         'nat/fork-inferior.o'.
11454         * gnu-nat.c: #include "nat/fork-inferior.h".
11455
11456         * gnu-nat.c (gnu_nat_target::detach): Instead of
11457         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11458         * gnu-nat.h: #include "inf-child.h".
11459         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11460         'i386_gnu_nat_target::fetch_registers'.
11461         (gnu_store_registers): Rename/move to
11462         'i386_gnu_nat_target::store_registers'.
11463
11464         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11465         * gnu-nat.h (mach_thread_info): New function.
11466         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11467
11468         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11469
11470 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11471
11472         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11473
11474 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11475
11476         * windows-nat.c (windows_add_thread): Add new parameter
11477         "main_thread_p" with default value set to false.  Update
11478         function documentation as well as all callers.
11479         (windows_delete_thread): Likewise.
11480         (fake_create_process): Update call to windows_add_thread.
11481         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11482         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11483         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11484         call to windows_delete_thread.
11485
11486 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11487
11488         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11489
11490 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11491
11492         * symfile.c (find_separate_debug_file): Use canonical path of
11493         sysroot with child_path instead of gdb_sysroot if it is valid.
11494
11495 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11496
11497         * symfile.c (find_separate_debug_file): Use child_path to
11498         determine if an object file is under a sysroot.
11499
11500 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11501
11502         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11503         unittests/child-path-selftests.c.
11504         * common/pathstuff.c (child_path): New function.
11505         * common/pathstuff.h (child_path): New prototype.
11506         * unittests/child-path-selftests.c: New file.
11507
11508 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11509
11510         * symfile.c (find_separate_debug_file): Look for separate debug
11511         files in debug directories under the sysroot.
11512
11513 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11514
11515         * symtab.h (struct minimal_symbol data_p): New const method.
11516         (struct minimal_symbol text_p): Likewise.
11517         * symtab.c (output_source_filename): Use file name style
11518         to print file name.
11519         (print_symbol_info): Likewise.
11520         (print_msymbol_info): Use address style to print addresses.
11521         Use function name style to print executable text symbols.
11522         (expand_symtab_containing_pc): Use data_p.
11523         (find_pc_sect_compunit_symtab): Likewise.
11524
11525 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11526
11527         * breakpoint.c (describe_other_breakpoints): Use address style
11528         to print addresses.
11529         (say_where): Likewise.
11530
11531 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11532
11533         * ada-typeprint.c (print_func_type): Print function name
11534         style to print function name.
11535         * c-typeprint.c (c_print_type_1): Likewise.
11536
11537 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11538
11539         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11540         for execve.
11541
11542 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11543
11544         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11545         type_stack.
11546
11547 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11548
11549         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11550         TYPE_CODE_REF types.
11551
11552 2019-02-08  Jim Wilson  <jimw@sifive.com>
11553
11554         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11555         (riscv_linux_fregset): New.
11556         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11557
11558 2019-02-07  Tom Tromey  <tom@tromey.com>
11559
11560         * thread.c (thread_cancel_execution_command): Update.
11561         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11562         methods.
11563         (struct thread_fsm_ops): Remove.
11564         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11565         (thread_fsm_should_stop, thread_fsm_return_value)
11566         (thread_fsm_set_finished, thread_fsm_finished_p)
11567         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11568         Don't declare.
11569         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11570         * infrun.c (clear_proceed_status_thread)
11571         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11572         (print_stop_event): Update.
11573         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11574         Add constructor.
11575         (step_command_fsm_ops): Remove.
11576         (new_step_command_fsm): Remove.
11577         (step_1): Update.
11578         (step_command_fsm::should_stop): Rename from
11579         step_command_fsm_should_stop.
11580         (step_command_fsm::clean_up): Rename from
11581         step_command_fsm_clean_up.
11582         (step_command_fsm::do_async_reply_reason): Rename from
11583         step_command_fsm_async_reply_reason.
11584         (struct until_next_fsm): Inherit from thread_fsm.  Add
11585         constructor.
11586         (until_next_fsm_ops): Remove.
11587         (new_until_next_fsm): Remove.
11588         (until_next_fsm::should_stop): Rename from
11589         until_next_fsm_should_stop.
11590         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11591         (until_next_fsm::do_async_reply_reason): Rename from
11592         until_next_fsm_async_reply_reason.
11593         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11594         constructor.  Change type of breakpoint.
11595         (finish_command_fsm_ops): Remove.
11596         (new_finish_command_fsm): Remove.
11597         (finish_command_fsm::should_stop): Rename from
11598         finish_command_fsm_should_stop.
11599         (finish_command_fsm::clean_up): Rename from
11600         finish_command_fsm_clean_up.
11601         (finish_command_fsm::return_value): Rename from
11602         finish_command_fsm_return_value.
11603         (finish_command_fsm::do_async_reply_reason): Rename from
11604         finish_command_fsm_async_reply_reason.
11605         (finish_command): Update.
11606         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11607         Add constructor.
11608         (call_thread_fsm_ops): Remove.
11609         (call_thread_fsm::call_thread_fsm): Rename from
11610         new_call_thread_fsm.
11611         (call_thread_fsm::should_stop): Rename from
11612         call_thread_fsm_should_stop.
11613         (call_thread_fsm::should_notify_stop): Rename from
11614         call_thread_fsm_should_notify_stop.
11615         (run_inferior_call, call_function_by_hand_dummy): Update.
11616         * cli/cli-interp.c (should_print_stop_to_console): Update.
11617         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11618         Add constructor.  Change type of location_breakpoint,
11619         caller_breakpoint.
11620         (until_break_fsm_ops): Remove.
11621         (new_until_break_fsm): Remove.
11622         (until_break_fsm::should_stop): Rename from
11623         until_break_fsm_should_stop.
11624         (until_break_fsm::clean_up): Rename from
11625         until_break_fsm_clean_up.
11626         (until_break_fsm::do_async_reply_reason): Rename from
11627         until_break_fsm_async_reply_reason.
11628         (until_break_command): Update.
11629         * thread-fsm.c: Remove.
11630         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11631
11632 2019-02-07  Tom Tromey  <tom@tromey.com>
11633
11634         * yy-remap.h: Add include guard.
11635         * xtensa-tdep.h: Add include guard.
11636         * xcoffread.h: Rename include guard.
11637         * varobj-iter.h: Add include guard.
11638         * tui/tui.h: Rename include guard.
11639         * tui/tui-winsource.h: Rename include guard.
11640         * tui/tui-wingeneral.h: Rename include guard.
11641         * tui/tui-windata.h: Rename include guard.
11642         * tui/tui-win.h: Rename include guard.
11643         * tui/tui-stack.h: Rename include guard.
11644         * tui/tui-source.h: Rename include guard.
11645         * tui/tui-regs.h: Rename include guard.
11646         * tui/tui-out.h: Rename include guard.
11647         * tui/tui-layout.h: Rename include guard.
11648         * tui/tui-io.h: Rename include guard.
11649         * tui/tui-hooks.h: Rename include guard.
11650         * tui/tui-file.h: Rename include guard.
11651         * tui/tui-disasm.h: Rename include guard.
11652         * tui/tui-data.h: Rename include guard.
11653         * tui/tui-command.h: Rename include guard.
11654         * tic6x-tdep.h: Add include guard.
11655         * target/waitstatus.h: Rename include guard.
11656         * target/wait.h: Rename include guard.
11657         * target/target.h: Rename include guard.
11658         * target/resume.h: Rename include guard.
11659         * target-float.h: Rename include guard.
11660         * stabsread.h: Add include guard.
11661         * rs6000-tdep.h: Add include guard.
11662         * riscv-fbsd-tdep.h: Add include guard.
11663         * regformats/regdef.h: Rename include guard.
11664         * record.h: Rename include guard.
11665         * python/python.h: Rename include guard.
11666         * python/python-internal.h: Rename include guard.
11667         * python/py-stopevent.h: Rename include guard.
11668         * python/py-ref.h: Rename include guard.
11669         * python/py-record.h: Rename include guard.
11670         * python/py-record-full.h: Rename include guard.
11671         * python/py-record-btrace.h: Rename include guard.
11672         * python/py-instruction.h: Rename include guard.
11673         * python/py-events.h: Rename include guard.
11674         * python/py-event.h: Rename include guard.
11675         * procfs.h: Add include guard.
11676         * proc-utils.h: Add include guard.
11677         * p-lang.h: Add include guard.
11678         * or1k-tdep.h: Rename include guard.
11679         * observable.h: Rename include guard.
11680         * nto-tdep.h: Rename include guard.
11681         * nat/x86-linux.h: Rename include guard.
11682         * nat/x86-linux-dregs.h: Rename include guard.
11683         * nat/x86-gcc-cpuid.h: Add include guard.
11684         * nat/x86-dregs.h: Rename include guard.
11685         * nat/x86-cpuid.h: Rename include guard.
11686         * nat/ppc-linux.h: Rename include guard.
11687         * nat/mips-linux-watch.h: Rename include guard.
11688         * nat/linux-waitpid.h: Rename include guard.
11689         * nat/linux-ptrace.h: Rename include guard.
11690         * nat/linux-procfs.h: Rename include guard.
11691         * nat/linux-osdata.h: Rename include guard.
11692         * nat/linux-nat.h: Rename include guard.
11693         * nat/linux-namespaces.h: Rename include guard.
11694         * nat/linux-btrace.h: Rename include guard.
11695         * nat/glibc_thread_db.h: Rename include guard.
11696         * nat/gdb_thread_db.h: Rename include guard.
11697         * nat/gdb_ptrace.h: Rename include guard.
11698         * nat/fork-inferior.h: Rename include guard.
11699         * nat/amd64-linux-siginfo.h: Rename include guard.
11700         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11701         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11702         * nat/aarch64-linux.h: Rename include guard.
11703         * nat/aarch64-linux-hw-point.h: Rename include guard.
11704         * mn10300-tdep.h: Add include guard.
11705         * mips-linux-tdep.h: Add include guard.
11706         * mi/mi-parse.h: Rename include guard.
11707         * mi/mi-out.h: Rename include guard.
11708         * mi/mi-main.h: Rename include guard.
11709         * mi/mi-interp.h: Rename include guard.
11710         * mi/mi-getopt.h: Rename include guard.
11711         * mi/mi-console.h: Rename include guard.
11712         * mi/mi-common.h: Rename include guard.
11713         * mi/mi-cmds.h: Rename include guard.
11714         * mi/mi-cmd-break.h: Rename include guard.
11715         * m2-lang.h: Add include guard.
11716         * location.h: Rename include guard.
11717         * linux-record.h: Rename include guard.
11718         * linux-nat.h: Add include guard.
11719         * linux-fork.h: Add include guard.
11720         * i386-darwin-tdep.h: Rename include guard.
11721         * hppa-linux-offsets.h: Add include guard.
11722         * guile/guile.h: Rename include guard.
11723         * guile/guile-internal.h: Rename include guard.
11724         * gnu-nat.h: Rename include guard.
11725         * gdb-stabs.h: Rename include guard.
11726         * frv-tdep.h: Add include guard.
11727         * f-lang.h: Add include guard.
11728         * event-loop.h: Add include guard.
11729         * darwin-nat.h: Rename include guard.
11730         * cp-abi.h: Rename include guard.
11731         * config/sparc/nm-sol2.h: Rename include guard.
11732         * config/nm-nto.h: Rename include guard.
11733         * config/nm-linux.h: Add include guard.
11734         * config/i386/nm-i386gnu.h: Rename include guard.
11735         * config/djgpp/nl_types.h: Rename include guard.
11736         * config/djgpp/langinfo.h: Rename include guard.
11737         * compile/gcc-cp-plugin.h: Add include guard.
11738         * compile/gcc-c-plugin.h: Add include guard.
11739         * compile/compile.h: Rename include guard.
11740         * compile/compile-object-run.h: Rename include guard.
11741         * compile/compile-object-load.h: Rename include guard.
11742         * compile/compile-internal.h: Rename include guard.
11743         * compile/compile-cplus.h: Rename include guard.
11744         * compile/compile-c.h: Rename include guard.
11745         * common/xml-utils.h: Rename include guard.
11746         * common/x86-xstate.h: Rename include guard.
11747         * common/version.h: Rename include guard.
11748         * common/vec.h: Rename include guard.
11749         * common/tdesc.h: Rename include guard.
11750         * common/selftest.h: Rename include guard.
11751         * common/scoped_restore.h: Rename include guard.
11752         * common/scoped_mmap.h: Rename include guard.
11753         * common/scoped_fd.h: Rename include guard.
11754         * common/safe-iterator.h: Rename include guard.
11755         * common/run-time-clock.h: Rename include guard.
11756         * common/refcounted-object.h: Rename include guard.
11757         * common/queue.h: Rename include guard.
11758         * common/ptid.h: Rename include guard.
11759         * common/print-utils.h: Rename include guard.
11760         * common/preprocessor.h: Rename include guard.
11761         * common/pathstuff.h: Rename include guard.
11762         * common/observable.h: Rename include guard.
11763         * common/netstuff.h: Rename include guard.
11764         * common/job-control.h: Rename include guard.
11765         * common/host-defs.h: Rename include guard.
11766         * common/gdb_wait.h: Rename include guard.
11767         * common/gdb_vecs.h: Rename include guard.
11768         * common/gdb_unlinker.h: Rename include guard.
11769         * common/gdb_unique_ptr.h: Rename include guard.
11770         * common/gdb_tilde_expand.h: Rename include guard.
11771         * common/gdb_sys_time.h: Rename include guard.
11772         * common/gdb_string_view.h: Rename include guard.
11773         * common/gdb_splay_tree.h: Rename include guard.
11774         * common/gdb_setjmp.h: Rename include guard.
11775         * common/gdb_ref_ptr.h: Rename include guard.
11776         * common/gdb_optional.h: Rename include guard.
11777         * common/gdb_locale.h: Rename include guard.
11778         * common/gdb_assert.h: Rename include guard.
11779         * common/filtered-iterator.h: Rename include guard.
11780         * common/filestuff.h: Rename include guard.
11781         * common/fileio.h: Rename include guard.
11782         * common/environ.h: Rename include guard.
11783         * common/common-utils.h: Rename include guard.
11784         * common/common-types.h: Rename include guard.
11785         * common/common-regcache.h: Rename include guard.
11786         * common/common-inferior.h: Rename include guard.
11787         * common/common-gdbthread.h: Rename include guard.
11788         * common/common-exceptions.h: Rename include guard.
11789         * common/common-defs.h: Rename include guard.
11790         * common/common-debug.h: Rename include guard.
11791         * common/cleanups.h: Rename include guard.
11792         * common/buffer.h: Rename include guard.
11793         * common/btrace-common.h: Rename include guard.
11794         * common/break-common.h: Rename include guard.
11795         * cli/cli-utils.h: Rename include guard.
11796         * cli/cli-style.h: Rename include guard.
11797         * cli/cli-setshow.h: Rename include guard.
11798         * cli/cli-script.h: Rename include guard.
11799         * cli/cli-interp.h: Rename include guard.
11800         * cli/cli-decode.h: Rename include guard.
11801         * cli/cli-cmds.h: Rename include guard.
11802         * charset-list.h: Add include guard.
11803         * buildsym-legacy.h: Rename include guard.
11804         * bfin-tdep.h: Add include guard.
11805         * ax.h: Rename include guard.
11806         * arm-linux-tdep.h: Add include guard.
11807         * arm-fbsd-tdep.h: Add include guard.
11808         * arch/xtensa.h: Rename include guard.
11809         * arch/tic6x.h: Add include guard.
11810         * arch/i386.h: Add include guard.
11811         * arch/arm.h: Rename include guard.
11812         * arch/arm-linux.h: Rename include guard.
11813         * arch/arm-get-next-pcs.h: Rename include guard.
11814         * arch/amd64.h: Add include guard.
11815         * arch/aarch64-insn.h: Rename include guard.
11816         * arch-utils.h: Rename include guard.
11817         * annotate.h: Add include guard.
11818         * amd64-darwin-tdep.h: Rename include guard.
11819         * aarch64-linux-tdep.h: Add include guard.
11820         * aarch64-fbsd-tdep.h: Add include guard.
11821         * aarch32-linux-nat.h: Add include guard.
11822
11823 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11824
11825         * macrotab.c (macro_define_internal): New function that
11826         factorizes macro_define_object_internal and macro_define_function
11827         code.
11828         (macro_define_object_internal): Use macro_define_internal.
11829         (macro_define_function): Likewise.
11830
11831 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11832
11833         * macrocmd.c (extract_identifier): Return
11834         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11835         callers.
11836
11837 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11838
11839         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11840
11841 2019-02-05  Tom Tromey  <tom@tromey.com>
11842
11843         * target.c (target_stack::unpush): Move assertion earlier.
11844
11845 2019-01-30  Tom Tromey  <tom@tromey.com>
11846
11847         PR python/23615:
11848         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11849         (gdbpy_parse_and_eval): Likewise.
11850         * python/python-internal.h (gdbpy_allow_threads): New class.
11851
11852 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11853
11854         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11855         (aarch64_fbsd_fpregmap): Move earlier.
11856         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11857         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11858         instead of individual calls to trad_frame_set_reg_addr.
11859         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11860         earlier.
11861         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11862         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11863         instead of individual calls to trad_frame_set_reg_addr.
11864
11865 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11866
11867         * CONTRIBUTE: Replace contribution list with wiki link.
11868
11869 2019-01-25  Tom Tromey  <tom@tromey.com>
11870
11871         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11872
11873 2019-01-25  Tom Tromey  <tom@tromey.com>
11874
11875         * xtensa-linux-nat.c: Fix common/ includes.
11876         * xml-support.h: Fix common/ includes.
11877         * xml-support.c: Fix common/ includes.
11878         * x86-linux-nat.c: Fix common/ includes.
11879         * windows-nat.c: Fix common/ includes.
11880         * varobj.h: Fix common/ includes.
11881         * varobj.c: Fix common/ includes.
11882         * value.c: Fix common/ includes.
11883         * valops.c: Fix common/ includes.
11884         * utils.c: Fix common/ includes.
11885         * unittests/xml-utils-selftests.c: Fix common/ includes.
11886         * unittests/utils-selftests.c: Fix common/ includes.
11887         * unittests/unpack-selftests.c: Fix common/ includes.
11888         * unittests/tracepoint-selftests.c: Fix common/ includes.
11889         * unittests/style-selftests.c: Fix common/ includes.
11890         * unittests/string_view-selftests.c: Fix common/ includes.
11891         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11892         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11893         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11894         * unittests/rsp-low-selftests.c: Fix common/ includes.
11895         * unittests/parse-connection-spec-selftests.c: Fix common/
11896         includes.
11897         * unittests/optional-selftests.c: Fix common/ includes.
11898         * unittests/offset-type-selftests.c: Fix common/ includes.
11899         * unittests/observable-selftests.c: Fix common/ includes.
11900         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11901         * unittests/memrange-selftests.c: Fix common/ includes.
11902         * unittests/memory-map-selftests.c: Fix common/ includes.
11903         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11904         * unittests/function-view-selftests.c: Fix common/ includes.
11905         * unittests/environ-selftests.c: Fix common/ includes.
11906         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11907         * unittests/common-utils-selftests.c: Fix common/ includes.
11908         * unittests/cli-utils-selftests.c: Fix common/ includes.
11909         * unittests/array-view-selftests.c: Fix common/ includes.
11910         * ui-file.c: Fix common/ includes.
11911         * tui/tui-io.c: Fix common/ includes.
11912         * tracepoint.h: Fix common/ includes.
11913         * tracepoint.c: Fix common/ includes.
11914         * tracefile-tfile.c: Fix common/ includes.
11915         * top.h: Fix common/ includes.
11916         * top.c: Fix common/ includes.
11917         * thread.c: Fix common/ includes.
11918         * target/waitstatus.h: Fix common/ includes.
11919         * target/waitstatus.c: Fix common/ includes.
11920         * target.h: Fix common/ includes.
11921         * target.c: Fix common/ includes.
11922         * target-memory.c: Fix common/ includes.
11923         * target-descriptions.c: Fix common/ includes.
11924         * symtab.h: Fix common/ includes.
11925         * symfile.c: Fix common/ includes.
11926         * stap-probe.c: Fix common/ includes.
11927         * spu-linux-nat.c: Fix common/ includes.
11928         * sparc-nat.c: Fix common/ includes.
11929         * source.c: Fix common/ includes.
11930         * solib.c: Fix common/ includes.
11931         * solib-target.c: Fix common/ includes.
11932         * ser-unix.c: Fix common/ includes.
11933         * ser-tcp.c: Fix common/ includes.
11934         * ser-pipe.c: Fix common/ includes.
11935         * ser-base.c: Fix common/ includes.
11936         * selftest-arch.c: Fix common/ includes.
11937         * s12z-tdep.c: Fix common/ includes.
11938         * rust-exp.y: Fix common/ includes.
11939         * rs6000-aix-tdep.c: Fix common/ includes.
11940         * riscv-tdep.c: Fix common/ includes.
11941         * remote.c: Fix common/ includes.
11942         * remote-notif.h: Fix common/ includes.
11943         * remote-fileio.h: Fix common/ includes.
11944         * remote-fileio.c: Fix common/ includes.
11945         * regcache.h: Fix common/ includes.
11946         * regcache.c: Fix common/ includes.
11947         * record-btrace.c: Fix common/ includes.
11948         * python/python.c: Fix common/ includes.
11949         * python/py-type.c: Fix common/ includes.
11950         * python/py-inferior.c: Fix common/ includes.
11951         * progspace.h: Fix common/ includes.
11952         * producer.c: Fix common/ includes.
11953         * procfs.c: Fix common/ includes.
11954         * proc-api.c: Fix common/ includes.
11955         * printcmd.c: Fix common/ includes.
11956         * ppc-linux-nat.c: Fix common/ includes.
11957         * parser-defs.h: Fix common/ includes.
11958         * osdata.c: Fix common/ includes.
11959         * obsd-nat.c: Fix common/ includes.
11960         * nat/x86-linux.c: Fix common/ includes.
11961         * nat/x86-linux-dregs.c: Fix common/ includes.
11962         * nat/x86-dregs.h: Fix common/ includes.
11963         * nat/x86-dregs.c: Fix common/ includes.
11964         * nat/ppc-linux.c: Fix common/ includes.
11965         * nat/mips-linux-watch.h: Fix common/ includes.
11966         * nat/mips-linux-watch.c: Fix common/ includes.
11967         * nat/linux-waitpid.c: Fix common/ includes.
11968         * nat/linux-ptrace.h: Fix common/ includes.
11969         * nat/linux-ptrace.c: Fix common/ includes.
11970         * nat/linux-procfs.c: Fix common/ includes.
11971         * nat/linux-personality.c: Fix common/ includes.
11972         * nat/linux-osdata.c: Fix common/ includes.
11973         * nat/linux-namespaces.c: Fix common/ includes.
11974         * nat/linux-btrace.h: Fix common/ includes.
11975         * nat/linux-btrace.c: Fix common/ includes.
11976         * nat/fork-inferior.c: Fix common/ includes.
11977         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11978         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11979         * nat/aarch64-linux.c: Fix common/ includes.
11980         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11981         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11982         * namespace.h: Fix common/ includes.
11983         * mips-linux-tdep.c: Fix common/ includes.
11984         * minsyms.c: Fix common/ includes.
11985         * mi/mi-parse.h: Fix common/ includes.
11986         * mi/mi-main.c: Fix common/ includes.
11987         * mi/mi-cmd-env.c: Fix common/ includes.
11988         * memrange.h: Fix common/ includes.
11989         * memattr.c: Fix common/ includes.
11990         * maint.h: Fix common/ includes.
11991         * maint.c: Fix common/ includes.
11992         * main.c: Fix common/ includes.
11993         * machoread.c: Fix common/ includes.
11994         * location.c: Fix common/ includes.
11995         * linux-thread-db.c: Fix common/ includes.
11996         * linux-nat.c: Fix common/ includes.
11997         * linux-fork.c: Fix common/ includes.
11998         * inline-frame.c: Fix common/ includes.
11999         * infrun.c: Fix common/ includes.
12000         * inflow.c: Fix common/ includes.
12001         * inferior.h: Fix common/ includes.
12002         * inferior.c: Fix common/ includes.
12003         * infcmd.c: Fix common/ includes.
12004         * inf-ptrace.c: Fix common/ includes.
12005         * inf-child.c: Fix common/ includes.
12006         * ia64-linux-nat.c: Fix common/ includes.
12007         * i387-tdep.c: Fix common/ includes.
12008         * i386-tdep.c: Fix common/ includes.
12009         * i386-linux-tdep.c: Fix common/ includes.
12010         * i386-linux-nat.c: Fix common/ includes.
12011         * i386-go32-tdep.c: Fix common/ includes.
12012         * i386-fbsd-tdep.c: Fix common/ includes.
12013         * i386-fbsd-nat.c: Fix common/ includes.
12014         * guile/scm-type.c: Fix common/ includes.
12015         * guile/guile.c: Fix common/ includes.
12016         * go32-nat.c: Fix common/ includes.
12017         * gnu-nat.c: Fix common/ includes.
12018         * gdbthread.h: Fix common/ includes.
12019         * gdbarch-selftests.c: Fix common/ includes.
12020         * gdb_usleep.c: Fix common/ includes.
12021         * gdb_select.h: Fix common/ includes.
12022         * gdb_bfd.c: Fix common/ includes.
12023         * gcore.c: Fix common/ includes.
12024         * fork-child.c: Fix common/ includes.
12025         * findvar.c: Fix common/ includes.
12026         * fbsd-nat.c: Fix common/ includes.
12027         * event-top.c: Fix common/ includes.
12028         * event-loop.c: Fix common/ includes.
12029         * dwarf2read.c: Fix common/ includes.
12030         * dwarf2loc.c: Fix common/ includes.
12031         * dwarf2-frame.c: Fix common/ includes.
12032         * dwarf-index-cache.c: Fix common/ includes.
12033         * dtrace-probe.c: Fix common/ includes.
12034         * disasm-selftests.c: Fix common/ includes.
12035         * defs.h: Fix common/ includes.
12036         * csky-tdep.c: Fix common/ includes.
12037         * cp-valprint.c: Fix common/ includes.
12038         * cp-support.h: Fix common/ includes.
12039         * cp-support.c: Fix common/ includes.
12040         * corelow.c: Fix common/ includes.
12041         * completer.h: Fix common/ includes.
12042         * completer.c: Fix common/ includes.
12043         * compile/compile.c: Fix common/ includes.
12044         * compile/compile-loc2c.c: Fix common/ includes.
12045         * compile/compile-cplus-types.c: Fix common/ includes.
12046         * compile/compile-cplus-symbols.c: Fix common/ includes.
12047         * command.h: Fix common/ includes.
12048         * cli/cli-dump.c: Fix common/ includes.
12049         * cli/cli-cmds.c: Fix common/ includes.
12050         * charset.c: Fix common/ includes.
12051         * build-id.c: Fix common/ includes.
12052         * btrace.h: Fix common/ includes.
12053         * btrace.c: Fix common/ includes.
12054         * breakpoint.h: Fix common/ includes.
12055         * breakpoint.c: Fix common/ includes.
12056         * ax.h:
12057         (enum agent_op): Fix common/ includes.
12058         * ax-general.c (struct aop_map): Fix common/ includes.
12059         * ax-gdb.c: Fix common/ includes.
12060         * auxv.c: Fix common/ includes.
12061         * auto-load.c: Fix common/ includes.
12062         * arm-tdep.c: Fix common/ includes.
12063         * arch/riscv.c: Fix common/ includes.
12064         * arch/ppc-linux-common.c: Fix common/ includes.
12065         * arch/i386.c: Fix common/ includes.
12066         * arch/arm.c: Fix common/ includes.
12067         * arch/arm-linux.c: Fix common/ includes.
12068         * arch/arm-get-next-pcs.c: Fix common/ includes.
12069         * arch/amd64.c: Fix common/ includes.
12070         * arch/aarch64.c: Fix common/ includes.
12071         * arch/aarch64-insn.c: Fix common/ includes.
12072         * arch-utils.c: Fix common/ includes.
12073         * amd64-windows-tdep.c: Fix common/ includes.
12074         * amd64-tdep.c: Fix common/ includes.
12075         * amd64-sol2-tdep.c: Fix common/ includes.
12076         * amd64-obsd-tdep.c: Fix common/ includes.
12077         * amd64-nbsd-tdep.c: Fix common/ includes.
12078         * amd64-linux-tdep.c: Fix common/ includes.
12079         * amd64-linux-nat.c: Fix common/ includes.
12080         * amd64-fbsd-tdep.c: Fix common/ includes.
12081         * amd64-fbsd-nat.c: Fix common/ includes.
12082         * amd64-dicos-tdep.c: Fix common/ includes.
12083         * amd64-darwin-tdep.c: Fix common/ includes.
12084         * agent.c: Fix common/ includes.
12085         * ada-lang.h: Fix common/ includes.
12086         * ada-lang.c: Fix common/ includes.
12087         * aarch64-tdep.c: Fix common/ includes.
12088
12089 2019-01-25  Tom Tromey  <tom@tromey.com>
12090
12091         * common/create-version.sh: Use common/version.h.
12092
12093 2019-01-24  Pedro Alves  <palves@redhat.com>
12094
12095         * infrun.c (signal_stop, signal_print, signal_program)
12096         (signal_catch, signal_pass): Now arrays instead of pointers.
12097         (update_signals_program_target, do_target_resume)
12098         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12099         * linux-nat.c (linux_nat_target::pass_signals)
12100         (linux_nat_target::create_inferior, linux_nat_target::attach):
12101         Adjust.
12102         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12103         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12104         * procfs.c (procfs_target::pass_signals): Adjust.
12105         * record-full.c (record_full_target::resume): Adjust.
12106         * remote.c (remote_target::pass_signals)
12107         (remote_target::program_signals): Adjust.
12108         * target-debug.h (target_debug_print_signals): Now takes a
12109         gdb::array_view as parameter.  Adjust.
12110         * target.h (target_ops) <pass_signals, program_signals>: Replace
12111         pointer and length parameters with gdb::array_view.
12112         (target_pass_signals, target_program_signals): Likewise.
12113         * target-delegates.c: Regenerate.
12114
12115 2019-01-24  Pedro Alves  <palves@redhat.com>
12116
12117         * common/forward-scope-exit.h
12118         (forward_scope_exit::forward_scope_exit): Pass arguments to
12119         m_bind_function directly, instead of creating a std::bind and
12120         copying that.
12121
12122 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12123
12124         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12125         for static members.
12126         (pass_in_v_vfp_candidate): Likewise.
12127
12128 2019-01-23  Tom Tromey  <tom@tromey.com>
12129             Pedro Alves  <palves@redhat.com>
12130
12131         * regcache.c (class regcache_invalidator): Remove.
12132         (regcache::raw_write): Use make_scope_exit.
12133
12134 2019-01-23  Tom Tromey  <tom@tromey.com>
12135
12136         * ui-out.h (class ui_out_emit_type): Update comment.
12137
12138 2019-01-23  Tom Tromey  <tom@tromey.com>
12139
12140         * infrun.c (fetch_inferior_event): Update comment.
12141
12142 2019-01-23  Tom Tromey  <tom@tromey.com>
12143             Pedro Alves  <palves@redhat.com>
12144
12145         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12146         parameter.
12147         (fetch_inferior_event): Use SCOPE_EXIT.
12148
12149
12150 2019-01-23  Tom Tromey  <tom@tromey.com>
12151             Pedro Alves  <palves@redhat.com>
12152
12153         * infrun.c (disable_thread_events): Delete.
12154         (stop_all_threads): Use SCOPE_EXIT.
12155
12156 2019-01-23  Tom Tromey  <tom@tromey.com>
12157             Pedro Alves  <palves@redhat.com>
12158
12159         * symfile.c: Include forward-scope-exit.h.
12160         (clear_symtab_users_cleanup): Replace forward declaration with
12161         a FORWARD_SCOPE_EXIT.
12162         (syms_from_objfile_1): Use the forward_scope_exit and
12163         gdb::optional instead of cleanup_function.
12164         (reread_symbols): Use the forward_scope_exit instead of
12165         cleanup_function.
12166         (clear_symtab_users_cleanup): Remove function.
12167
12168 2019-01-23  Tom Tromey  <tom@tromey.com>
12169             Pedro Alves  <palves@redhat.com>
12170
12171         * linux-nat.c: Include scope-exit.h.
12172         (cleanup_target_stop): Remove.
12173         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12174         SCOPE_EXIT.
12175
12176 2019-01-23  Tom Tromey  <tom@tromey.com>
12177             Pedro Alves  <palves@redhat.com>
12178
12179         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12180         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12181
12182 2019-01-23  Tom Tromey  <tom@tromey.com>
12183             Andrew Burgess  <andrew.burgess@embecosm.com>
12184             Pedro Alves  <palves@redhat.com>
12185
12186         * infrun.c (fetch_inferior_event): Use scope_exit.
12187         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12188         * top.c (execute_command): Use scope_exit.
12189         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12190         * utils.c (do_bpstat_clear_actions_cleanup)
12191         (make_bpstat_clear_actions_cleanup): Remove.
12192
12193 2019-01-23  Tom Tromey  <tom@tromey.com>
12194             Pedro Alves  <palves@redhat.com>
12195
12196         * infrun.c: Include "common/scope-exit.h"
12197         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12198         (wait_for_inferior): Use SCOPE_EXIT.
12199         (fetch_inferior_event): Use scope_exit.
12200
12201 2019-01-23  Tom Tromey  <tom@tromey.com>
12202             Pedro Alves  <palves@redhat.com>
12203
12204         * breakpoint.c (create_breakpoint): Remove cleanup.
12205
12206 2019-01-23  Tom Tromey  <tom@tromey.com>
12207             Andrew Burgess  <andrew.burgess@embecosm.com>
12208             Pedro Alves  <palves@redhat.com>
12209
12210 2019-01-23  Pedro Alves  <palves@redhat.com>
12211
12212         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12213
12214 2019-01-23  Pedro Alves  <palves@redhat.com>
12215             Andrew Burgess  <andrew.burgess@embecosm.com>
12216
12217         * gdbthread.h: Include "common/forward-scope-exit.h".
12218         (scoped_finish_thread_state): Redefine custom class in terms of
12219         forward_scope_exit.
12220
12221 2019-01-23  Pedro Alves  <palves@redhat.com>
12222             Andrew Burgess  <andrew.burgess@embecosm.com>
12223
12224         * common/forward-scope-exit.h: New file.
12225
12226 2019-01-23  Pedro Alves  <palves@redhat.com>
12227             Andrew Burgess  <andrew.burgess@embecosm.com>
12228             Tom Tromey  <tom@tromey.com>
12229
12230         * common/scope-exit.h: New file.
12231
12232 2019-01-23  Pedro Alves  <palves@redhat.com>
12233
12234         * common/preprocessor.h (ESC): Rename to ...
12235         (ESC_PARENS): ... this.
12236         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12237         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12238
12239 2019-01-23  Tom Tromey  <tom@tromey.com>
12240
12241         * language.h (class scoped_switch_to_sym_language_if_auto):
12242         Initialize m_lang in both cases.
12243
12244 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12245
12246         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12247         with XCNEW.
12248
12249 2019-01-22  Tom Tromey  <tom@tromey.com>
12250
12251         * corelow.c: Do not include sys/file.h.
12252
12253 2019-01-22  Tom Tromey  <tom@tromey.com>
12254
12255         * tui/tui-wingeneral.h: Include gdb_curses.h.
12256
12257 2019-01-22  Tom Tromey  <tom@tromey.com>
12258
12259         * source-cache.h (class source_cache) <get_source_lines,
12260         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12261
12262 2019-01-22  Tom Tromey  <tom@tromey.com>
12263
12264         * remote-fileio.h (struct remote_target): Declare.
12265
12266 2019-01-22  Tom Tromey  <tom@tromey.com>
12267
12268         * python/py-arch.c: Do not include py-ref.h.
12269         * python/py-bpevent.c: Do not include py-ref.h.
12270         * python/py-cmd.c: Do not include py-ref.h.
12271         * python/py-continueevent.c: Do not include py-ref.h.
12272         * python/py-event.h: Do not include py-ref.h.
12273         * python/py-evtregistry.c: Do not include py-ref.h.
12274         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12275         * python/py-frame.c: Do not include py-ref.h.
12276         * python/py-framefilter.c: Do not include py-ref.h.
12277         * python/py-function.c: Do not include py-ref.h.
12278         * python/py-infevents.c: Do not include py-ref.h.
12279         * python/py-linetable.c: Do not include py-ref.h.
12280         * python/py-objfile.c: Do not include py-ref.h.
12281         * python/py-param.c: Do not include py-ref.h.
12282         * python/py-prettyprint.c: Do not include py-ref.h.
12283         * python/py-progspace.c: Do not include py-ref.h.
12284         * python/py-symbol.c: Do not include py-ref.h.
12285         * python/py-symtab.c: Do not include py-ref.h.
12286         * python/py-type.c: Do not include py-ref.h.
12287         * python/py-unwind.c: Do not include py-ref.h.
12288         * python/py-utils.c: Do not include py-ref.h.
12289         * python/py-value.c: Do not include py-ref.h.
12290         * python/py-varobj.c: Do not include py-ref.h.
12291         * python/py-xmethods.c: Do not include py-ref.h.
12292         * python/python.c: Do not include py-ref.h.
12293         * varobj.c: Do not include py-ref.h.
12294
12295 2019-01-22  Tom Tromey  <tom@tromey.com>
12296
12297         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12298         keyword for bcache.
12299
12300 2019-01-22  Tom Tromey  <tom@tromey.com>
12301
12302         * compile/compile-cplus-types.c: Remove a comment by #include.
12303
12304 2019-01-22  Tom Tromey  <tom@tromey.com>
12305
12306         * compile/gcc-c-plugin.h: Include compile-internal.h.
12307
12308 2019-01-22  Tom Tromey  <tom@tromey.com>
12309
12310         * stabsread.c (EXTERN): Do not define.
12311         (symnum, next_symbol_text_func, processing_gcc_compilation)
12312         (within_function, global_sym_chain, global_stabs)
12313         (previous_stab_code, this_object_header_files)
12314         (n_this_object_header_files)
12315         (n_allocated_this_object_header_files): Define.
12316         * stabsread.h (EXTERN): Never define.  Use "extern".
12317
12318 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12319
12320         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12321         history_value.
12322
12323 2019-01-21  Tom Tromey  <tom@tromey.com>
12324
12325         * ui-out.c: Fix includes.
12326         * tui/tui-source.c: Fix includes.
12327         * target.c: Fix includes.
12328         * remote.c: Fix includes.
12329         * regcache.c: Fix includes.
12330         * python/py-block.c: Fix includes.
12331         * printcmd.c: Fix includes.
12332         * or1k-tdep.c: Fix includes.
12333         * mi/mi-main.c: Fix includes.
12334         * m32r-tdep.c: Fix includes.
12335         * csky-tdep.c: Fix includes.
12336         * compile/compile-cplus-types.c: Fix includes.
12337         * cli/cli-interp.c: Fix includes.
12338
12339 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12340
12341         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12342         for padding.
12343
12344 2019-01-16  Tom Tromey  <tom@tromey.com>
12345
12346         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12347         earlier.
12348         (struct objfile) <msymbols_range>: Move from top level.
12349         <msymbols>: New method.
12350         (class objfile_msymbols): Remove.
12351         * symtab.c (default_collect_symbol_completion_matches_break_on):
12352         Update.
12353         * symmisc.c (dump_msymbols): Update.
12354         * stabsread.c (scan_file_globals): Update.
12355         * objc-lang.c (info_selectors_command, info_classes_command)
12356         (find_methods): Update.
12357         * minsyms.c (find_solib_trampoline_target): Update.
12358         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12359         * coffread.c (coff_symfile_read): Update.
12360         * ada-lang.c (ada_lookup_simple_minsym)
12361         (ada_collect_symbol_completion_matches): Update.
12362
12363 2019-01-16  Tom Tromey  <tom@tromey.com>
12364
12365         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12366         type.  Remove no-argument constructor.
12367         <iterator::operator++>: Simplify.
12368         <begin>: Update.
12369         <end>: Use minimal_symbol_count.
12370
12371 2019-01-16  Tom Tromey  <tom@tromey.com>
12372
12373         * objfiles.h (struct objfile) <psymtabs>: New method.
12374         (class objfile_psymtabs): Remove.
12375         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12376         typedef.
12377         <range>: New method.
12378         (require_partial_symbols): Change return type.
12379         * psymtab.c (require_partial_symbols)
12380         (psym_expand_symtabs_matching): Update.
12381         * mdebugread.c (parse_partial_symbols): Update.
12382         * dbxread.c (dbx_end_psymtab): Update.
12383
12384 2019-01-15  Tom Tromey  <tom@tromey.com>
12385
12386         * symtab.c (lookup_objfile_from_block)
12387         (lookup_symbol_in_objfile_symtabs)
12388         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12389         (find_line_symtab, info_sources_command)
12390         (default_collect_symbol_completion_matches_break_on)
12391         (make_source_files_completion_list): Update.
12392         * symmisc.c (print_objfile_statistics, dump_objfile)
12393         (maintenance_print_symbols, maintenance_info_symtabs)
12394         (maintenance_check_symtabs, maintenance_info_line_tables):
12395         Update.
12396         * source.c (select_source_symtab)
12397         (forget_cached_source_info_for_objfile): Update.
12398         * objfiles.h (class objfile_compunits): Remove.
12399         (struct objfile) <compunits_range>: New typedef.
12400         (compunits): New method.
12401         * objfiles.c (objfile_relocate1): Update.
12402         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12403         * maint.c (count_symtabs_and_blocks): Update.
12404         * linespec.c (iterate_over_all_matching_symtabs): Update.
12405         * cp-support.c (add_symbol_overload_list_qualified): Update.
12406         * coffread.c (coff_symtab_read): Update.
12407         * ada-lang.c (add_nonlocal_symbols)
12408         (ada_collect_symbol_completion_matches)
12409         (ada_add_global_exceptions): Update.
12410
12411 2019-01-15  Tom Tromey  <tom@tromey.com>
12412
12413         * progspace.h (program_space) <objfiles_safe_range>: New
12414         typedef.
12415         <objfiles_safe>: New method.
12416         * objfiles.h (class all_objfiles_safe): Remove.
12417         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12418         * jit.c (jit_inferior_exit_hook): Update.
12419
12420 2019-01-17  Tom Tromey  <tom@tromey.com>
12421
12422         * progspace.h (program_space) <objfiles_range>: New typedef.
12423         <objfiles>: New method.
12424         <objfiles_head>: Rename from objfiles.
12425         (object_files): Update.
12426         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12427         * guile/scm-pretty-print.c
12428         (ppscm_find_pretty_printer_from_objfiles): Update.
12429         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12430         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12431         Update.
12432         * python/py-progspace.c (pspy_get_objfiles): Update.
12433         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12434         Update.
12435         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12436         (objfpy_lookup_objfile_by_build_id): Update.
12437         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12438         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12439         Update.
12440         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12441         (expand_symtab_containing_pc, lookup_objfile_from_block)
12442         (lookup_static_symbol, basic_lookup_transparent_type)
12443         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12444         (find_line_symtab, info_sources_command)
12445         (default_collect_symbol_completion_matches_break_on)
12446         (make_source_files_completion_list, find_main_name): Update.
12447         * symmisc.c (print_symbol_bcache_statistics)
12448         (print_objfile_statistics, maintenance_print_symbols)
12449         (maintenance_print_msymbols, maintenance_print_objfiles)
12450         (maintenance_info_symtabs, maintenance_check_symtabs)
12451         (maintenance_expand_symtabs, maintenance_info_line_tables):
12452         Update.
12453         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12454         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12455         (map_overlay_command, unmap_overlay_command)
12456         (simple_overlay_update, expand_symtabs_matching)
12457         (map_symbol_filenames): Update.
12458         * symfile-debug.c (set_debug_symfile): Update.
12459         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12460         Update.
12461         * source.c (select_source_symtab, forget_cached_source_info):
12462         Update.
12463         * solib.c (solib_read_symbols): Update.
12464         * solib-spu.c (append_ocl_sos): Update.
12465         * psymtab.c (maintenance_print_psymbols)
12466         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12467         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12468         * printcmd.c (info_symbol_command): Update.
12469         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12470         Update.
12471         * objfiles.h (class all_objfiles): Remove.
12472         * objfiles.c (have_partial_symbols, have_full_symbols)
12473         (have_minimal_symbols, qsort_cmp, update_section_map)
12474         (shared_objfile_contains_address_p)
12475         (default_iterate_over_objfiles_in_search_order): Update.
12476         * objc-lang.c (info_selectors_command, info_classes_command)
12477         (find_methods): Update.
12478         * minsyms.c (find_solib_trampoline_target): Update.
12479         * maint.c (maintenance_info_sections)
12480         (maintenance_translate_address, count_symtabs_and_blocks):
12481         Update.
12482         * main.c (captured_main_1): Update.
12483         * linux-thread-db.c (try_thread_db_load_from_pdir)
12484         (has_libpthread): Update.
12485         * linespec.c (iterate_over_all_matching_symtabs)
12486         (search_minsyms_for_name): Update.
12487         * jit.c (jit_find_objf_with_entry_addr): Update.
12488         * hppa-tdep.c (find_unwind_entry)
12489         (hppa_lookup_stub_minimal_symbol): Update.
12490         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12491         Update.
12492         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12493         (elf_gnu_ifunc_resolve_by_got): Update.
12494         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12495         * dwarf-index-write.c (save_gdb_index_command): Update.
12496         * cp-support.c (add_symbol_overload_list_qualified): Update.
12497         * breakpoint.c (create_overlay_event_breakpoint)
12498         (create_longjmp_master_breakpoint)
12499         (create_std_terminate_master_breakpoint)
12500         (create_exception_master_breakpoint): Update.
12501         * blockframe.c (find_pc_partial_function): Update.
12502         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12503         (ada_collect_symbol_completion_matches)
12504         (ada_add_global_exceptions): Update.
12505
12506 2019-01-17  Tom Tromey  <tom@tromey.com>
12507
12508         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12509         declare VEC.
12510         (solib_target_parse_libraries): Change return type.
12511         (library_list_start_segment, library_list_start_section)
12512         (library_list_end_library, library_list_start_library); Update.
12513         (solib_target_free_library_list): Remove.
12514         (solib_target_parse_libraries): Remove cleanup.  Change return
12515         type.
12516         (solib_target_current_sos): Update.
12517
12518 2019-01-17  Tom Tromey  <tromey@bapiya>
12519
12520         * valprint.c: Replace "the the" with "the".
12521         * symtab.c: Replace "the the" with "the".
12522         * solib.c: Replace "the the" with "the".
12523         * solib-dsbt.c: Replace "the the" with "the".
12524         * linespec.c: Replace "the the" with "the".
12525         * dwarf2loc.h: Replace "the the" with "the".
12526         * amd64-windows-tdep.c: Replace "the the" with "the".
12527         * aarch64-tdep.c: Replace "the the" with "the".
12528
12529 2019-01-16  Keith Seitz  <keiths@redhat.com>
12530
12531         PR gdb/23773
12532         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12533         <builder>: Rename to ..
12534         <m_builder>: ... this and make private.
12535         (dwarf2_cu::get_builder): New method.  Change all users of
12536         `builder' to use this method.
12537         (dwarf2_start_symtab): Move to ...
12538         (dwarf2_cu::start_symtab): ... here.  Update all callers
12539         (setup_type_unit_groups): Move to ...
12540         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12541         callers.
12542         (dwarf2_cu::reset_builder): New method.
12543         (process_full_compunit, process_full_type_unit): Use
12544         dwarf2_cu::reset_builder.
12545         (follow_die_offset): Record the ancestor CU if it is different
12546         from the followed DIE's CU.
12547         (follow_die_sig_1): Likewise.
12548
12549 2019-01-15  Tom Tromey  <tom@tromey.com>
12550
12551         * remote.c (class remote_state) <buf>: Now a char_vector.
12552         <buf_size>: Remove.
12553         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12554         parameter.
12555         (remote_target::getpkt_or_notif_sane_1)
12556         (remote_target::getpkt_sane)
12557         (remote_target::getpkt_or_notif_sane): Likewise.
12558         (class remote_target) <putpkt>: New overload.
12559         (remote_target::read_frame): Change type of "buf_p".  Remove
12560         sizeof_p parameter.
12561         (packet_ok): New overload.
12562         (packet_check_result): New overload.
12563         Update all uses.
12564
12565 2019-01-14  Tom Tromey  <tom@tromey.com>
12566
12567         * remote-notif.c (handle_notification, remote_notif_ack)
12568         (remote_notif_parse): Make "buf" const.
12569         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12570         const.
12571         (remote_notif_parse, remote_notif_ack, handle_notification):
12572         Likewise.
12573         * remote.c (remote_notif_stop_parse): Make "buf" const.
12574         (remote_target::remote_parse_stop_reply): Make "buf" const.
12575         (remote_notif_stop_ack): Make "buf" const.
12576
12577 2019-01-14  Tom Tromey  <tom@tromey.com>
12578
12579         * remote.c (remote_console_output): Make parameter const.
12580
12581 2019-01-14  Tom Tromey  <tom@tromey.com>
12582
12583         * target-debug.h (target_debug_print_signals): Constify.
12584         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12585         * procfs.c (procfs_target::pass_signals): Update.
12586         * linux-nat.c (linux_nat_target::pass_signals): Update.
12587         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12588         * target-delegates.c: Rebuild.
12589         * remote.c (remote_target::program_signals): Update.
12590         (remote_target::pass_signals): Update.
12591         * target.c (target_pass_signals): Constify argument.
12592         (target_program_signals): Likewise.
12593         * target.h (struct target_ops) <pass_signals, program_signals>:
12594         Constify argument.
12595         (target_pass_signals, target_program_signals): Constify argument.
12596
12597 2019-01-14  Tom Tromey  <tom@tromey.com>
12598
12599         PR tui/28819:
12600         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12601
12602 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12603
12604         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12605         field.
12606         * rs6000-tdep.c: Include reggroups.h.
12607         (IS_V_ALIAS_PSEUDOREG): Define.
12608         (rs6000_register_name): Return names for the "vX" aliases.
12609         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12610         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12611         aliases.  Call default_register_reggroup_p for all other
12612         pseudo-registers.
12613         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12614         New functions.
12615         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12616         Handle "vX" aliases.
12617         (v_alias_pseudo_register_collect): New function.
12618         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12619         (rs6000_gdbarch_init): Initialize "vX" aliases as
12620         pseudo-registers.  Restore registration of
12621         rs6000_pseudo_register_reggroup_p with
12622         set_tdesc_pseudo_register_reggroup_p.
12623
12624 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12625
12626         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12627         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12628         set_gdbarch_num_pseudo_regs.
12629
12630 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12631
12632         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12633         Remove arg prefixname, add do_set and do_show.
12634         Add member functions set_list and show_list.
12635         * cli/cli-style.c (class cli_style_option): Update accordingly.
12636         (style_set_list): Move to file scope.
12637         (style_show_list): Likewise.
12638         (set_style): Call help_list.
12639         (show_style): Call cmd_show_list.
12640         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12641         Update to use the new macro.
12642
12643 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12644
12645         * ada-lang.c (_initialize_ada_language): Expand the help text
12646         for the "catch exception" command.
12647
12648 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12649
12650         * symtab.c (matching_obj_sections): Initialize obj,
12651         declare it closer to its usage.
12652
12653 2019-01-10  Tom Tromey  <tom@tromey.com>
12654
12655         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12656         (basic_inf_threads_range): Remove.
12657         (inf_threads_range, inf_non_exited_threads_range)
12658         (safe_inf_threads_range): Use next_adapter.
12659
12660 2019-01-10  Keith Seitz  <keiths@redhat.com>
12661
12662         PR gdb/23712
12663         PR symtab/23010
12664         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12665         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12666
12667 2019-01-10  Keith Seitz  <keiths@redhat.com>
12668
12669         PR gdb/23712
12670         PR symtab/23010
12671         * dictionary.c (pending_to_vector): Remove.
12672         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12673         Remove _1 suffix, replacing functions of the same name.  Update
12674         all callers.
12675         (dict_create_hashed, dict_create_hashed_expandable)
12676         (dict_create_linear, dict_create_linear_expandable, dict_free)
12677         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12678         Make functions static.
12679
12680 2019-01-10  Keith Seitz  <keiths@redhat.com>
12681
12682         PR gdb/23712
12683         PR symtab/23010
12684         * dictionary.h (struct dictionary): Replace declaration with
12685         multidictionary.
12686         (dict_create_hashed, dict_create_hashed_expandable)
12687         (dict_create_linear, dict_create_linear_expandable)
12688         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12689         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12690         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12691         taking multidictionary argument.
12692         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12693         * block.h (struct block) <dict>: Change to multidictionary
12694         and rename `multidict'.
12695         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12696         symmisc.c: Update all dictionary references to multidictionary.
12697
12698 2019-01-10  Keith Seitz  <keiths@redhat.com>
12699
12700         PR gdb/23712
12701         PR symtab/23010
12702         * dictionary.c: Include unordered_map.
12703         (pending_to_vector): New function.
12704         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12705         Rewrite the non-"_1" functions to take vector instead
12706         of linked list.
12707         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12708         "new" _1 versions of the same name.
12709         (multidictionary): Define.
12710         (std::hash<enum language): New definition.
12711         (collate_pending_symbols_by_language, mdict_create_hashed)
12712         (mdict_create_hashed_expandable, mdict_create_linear)
12713         (mdict_create_linear_expandable, mdict_free)
12714         (find_language_dictionary, create_new_language_dictionary)
12715         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12716         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12717         (mdict_size, mdict_empty): New functions.
12718         * dictionary.h (mdict_iterator): Define.
12719
12720 2019-01-10  Pedro Alves  <palves@redhat.com>
12721
12722         * breakpoint.c (read_uploaded_action)
12723         (create_tracepoint_from_upload): Adjust to use
12724         gdb::unique_xmalloc_ptr.
12725         * ctf.c (ctf_write_uploaded_tp):
12726         (SET_ARRAY_FIELD): Use emplace_back.
12727         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12728         * tracefile-tfile.c (tfile_write_uploaded_tp):
12729         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12730         gdb::unique_xmalloc_ptr.
12731         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12732         at_string, cond_string, cmd_strings>: Replace char pointers
12733         with gdb::unique_xmalloc_ptr.
12734
12735 2019-01-10  Pedro Alves  <palves@redhat.com>
12736
12737         * solib-target.c (library_list_start_library): Don't xstrdup name.
12738
12739 2019-01-10  Pedro Alves  <palves@redhat.com>
12740
12741         * mdebugread.c (parse_partial_symbols): Use
12742         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12743
12744 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12745
12746         * linux-fork.c (scoped_switch_fork_info)
12747         <~scoped_switch_fork_info>: Fix incorrect variable name.
12748
12749 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12750
12751         * linux-fork.c (scoped_switch_fork_info)
12752         <scoped_switch_fork_info>: Make explicit.
12753         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12754
12755 2019-01-10  Tom Tromey  <tom@tromey.com>
12756
12757         * objfiles.h (objfile::reset_psymtabs): Update.
12758         * objfiles.c (objfile::objfile): Update.
12759         * psymtab.h (psymtab_storage::obstack): Update.
12760         (psymtab_storage::m_obstack): Use gdb::optional.
12761         (class psymtab_storage): Update comment.  Remove objfile
12762         parameter.
12763         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12764
12765 2019-01-10  Tom Tromey  <tom@tromey.com>
12766
12767         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12768         <free_psymtabs>: Now private.
12769         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12770         (allocate_psymtab): Use new method.
12771
12772 2019-01-10  Tom Tromey  <tom@tromey.com>
12773
12774         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12775         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12776         * mdebugread.c (parse_partial_symbols): Use
12777         allocate_dependencies.
12778         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12779         allocate_dependencies.
12780         (process_psymtab_comp_unit_reader)
12781         (build_type_psymtab_dependencies): Likewise.
12782         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12783
12784 2019-01-10  Tom Tromey  <tom@tromey.com>
12785
12786         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12787         PSYMBOL_SET_LANGUAGE.
12788         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12789
12790 2019-01-10  Tom Tromey  <tom@tromey.com>
12791
12792         * psymtab.h (psymtab_storage::obstack): New method.
12793         <m_obstack>: Rename from obstack; now private.
12794         * psymtab.c (psymtab_storage): Update.
12795         * dwarf2read.c (create_addrmap_from_index)
12796         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12797         Update.
12798
12799 2019-01-10  Tom Tromey  <tom@tromey.com>
12800
12801         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12802         * objfiles.h (objfile::reset_psymtabs): New method.
12803
12804 2019-01-10  Tom Tromey  <tom@tromey.com>
12805
12806         * symmisc.c (print_symbol_bcache_statistics): Update.
12807         (print_objfile_statistics): Update.
12808         * symfile.c (reread_symbols): Update.
12809         * psymtab.h (class psymtab_storage): New.
12810         * psymtab.c (psymtab_storage): New constructor.
12811         (~psymtab_storage): New destructor.
12812         (require_partial_symbols): Update.
12813         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12814         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12815         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12816         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12817         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12818         (start_psymtab_common, end_psymtab_common)
12819         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12820         (allocate_psymtab): Update.
12821         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12822         Update.
12823         (dump_psymtab_addrmap, maintenance_print_psymbols)
12824         (maintenance_check_psymtabs): Update.
12825         (class objfile_psymtabs): Move to objfiles.h.
12826         * psympriv.h (discard_psymtab): Now inline.
12827         (psymtab_discarder::psymtab_discarder): Update.
12828         (psymtab_discarder::~psymtab_discarder): Update.
12829         (ALL_OBJFILE_PSYMTABS): Rewrite.
12830         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12831         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12832         Remove fields.
12833         <partial_symtabs>: New field.
12834         (class objfile_psymtabs): Move from psymtab.h.  Update.
12835         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12836         psymbol_cache.
12837         (objfile::~objfile): Don't destroy psymbol_cache.
12838         * mdebugread.c (parse_partial_symbols): Update.
12839         * dwarf2read.c (create_addrmap_from_index)
12840         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12841         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12842         (add_partial_subprogram, dwarf2_ranges_read): Update.
12843         * dwarf-index-write.c (write_address_map)
12844         (write_one_signatured_type, recursively_write_psymbols)
12845         (class debug_names, class debug_names, write_psymtabs_to_index):
12846         Update.
12847
12848 2019-01-10  Tom Tromey  <tom@tromey.com>
12849
12850         * symtab.h (SYMBOL_SET_NAMES): Update.
12851         (symbol_set_names): Update.
12852         (MSYMBOL_SET_NAMES): Update.
12853         * symtab.c (symbol_set_names): Change argument to be an
12854         objfile_per_bfd_storage.
12855         * psymtab.c (add_psymbol_to_bcache): Update.
12856         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12857
12858 2019-01-10  Tom Tromey  <tom@tromey.com>
12859
12860         * symtab.c (create_demangled_names_hash): Change argument to be an
12861         objfile_per_bfd_storage.
12862         (symbol_set_names): Update.
12863
12864 2019-01-10  Tom Tromey  <tom@tromey.com>
12865
12866         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12867         init_psymbol_list.
12868         * psymtab.c (init_psymbol_list): Do nothing if already called.
12869         * psympriv.h (init_psymbol_list): Add comment.
12870         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12871         init_psymbol_list.
12872         * dbxread.c (dbx_symfile_read): Unconditionally call
12873         init_psymbol_list.
12874
12875 2019-01-10  Tom Tromey  <tom@tromey.com>
12876
12877         * xcoffread.c (scan_xcoff_symtab): Update.
12878         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12879         "where".
12880         * mdebugread.c (parse_partial_symbols)
12881         (handle_psymbol_enumerators): Update.
12882         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12883         * dbxread.c (read_dbx_symtab): Update.
12884         * psympriv.h (psymbol_placement): New enum.
12885         (add_psymbol_to_list): Update.
12886
12887 2019-01-10  Tom Tromey  <tom@tromey.com>
12888
12889         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12890         static_psymbols parameters.
12891         (scan_xcoff_symtab): Update.
12892         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12893         static_psymbols parameters.
12894         * psympriv.h (start_psymtab_common): Update.
12895         * mdebugread.c (parse_partial_symbols): Update.
12896         * dwarf2read.c (create_partial_symtab): Update.
12897         * dbxread.c (read_dbx_symtab): Update.
12898         (start_psymtab): Remove global_psymbols and static_psymbols
12899         parameters.
12900
12901 2019-01-10  Tom Tromey  <tom@tromey.com>
12902
12903         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12904         * psymtab.c (allocate_psymtab): Add comment.
12905         * psympriv.h (allocate_psymtab): Add comment.
12906         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12907         initializations.
12908         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12909
12910 2019-01-10  Tom Tromey  <tom@tromey.com>
12911
12912         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12913         Don't declare.
12914         * mipsread.c: Include mdebugread.h.
12915         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12916         Declare.
12917         * elfread.c: Include mdebugread.h.
12918
12919 2019-01-09  Tom Tromey  <tom@tromey.com>
12920
12921         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12922         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12923         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12924         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12925         (psym_lookup_symbol, psym_find_last_source_symtab)
12926         (psym_forget_cached_source_info, psym_print_stats)
12927         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12928         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12929         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12930         (psym_find_compunit_symtab_by_address)
12931         (maintenance_print_psymbols, maintenance_info_psymtabs)
12932         (maintenance_check_psymtabs): Use ranged for.
12933         * psymtab.h (class objfile_psymtabs): New.
12934         (require_partial_symbols): Return objfile_psymtabs.
12935         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12936
12937 2019-01-09  Tom Tromey  <tom@tromey.com>
12938
12939         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12940         (find_pc_mapped_section, list_overlays_command)
12941         (map_overlay_command, unmap_overlay_command)
12942         (simple_overlay_update): Use all_objfiles.
12943         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12944         * printcmd.c (info_symbol_command): Use all_objfiles.
12945         * objfiles.h (ALL_OBJSECTIONS): Remove.
12946         * maint.c (maintenance_translate_address): Use all_objfiles.
12947         * gcore.c (gcore_create_callback): Use all_objfiles.
12948         (objfile_find_memory_regions): Likewise.
12949
12950 2019-01-09  Tom Tromey  <tom@tromey.com>
12951
12952         * symtab.c (find_line_symtab, info_sources_command)
12953         (make_source_files_completion_list): Use objfile_compunits.
12954         * source.c (select_source_symtab): Use objfile_compunits.
12955         * objfiles.h (struct objfile): Update comment.
12956         (ALL_OBJFILES): Remove.
12957         (ALL_FILETABS): Remove.
12958         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12959         objfile_compunits.
12960
12961 2019-01-09  Tom Tromey  <tom@tromey.com>
12962
12963         * symmisc.c (print_objfile_statistics, dump_objfile)
12964         (maintenance_print_symbols): Use compunit_filetabs.
12965         * source.c (forget_cached_source_info_for_objfile): Use
12966         compunit_filetabs.
12967         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12968         (ALL_FILETABS): Use compunit_filetabs.
12969         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12970         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12971
12972 2019-01-09  Tom Tromey  <tom@tromey.com>
12973
12974         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12975         (compunit_filetabs): New.
12976         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12977         compunit_filetabs.
12978         (info_sources_command, make_source_files_completion_list): Remove
12979         declaration.
12980         * symmisc.c (print_objfile_statistics, dump_objfile)
12981         (maintenance_print_symbols): Remove declaration.
12982         (maintenance_info_symtabs): Use compunit_filetabs.
12983         (maintenance_info_line_tables): Likewise.
12984         * source.c (select_source_symtab): Change local variable name.
12985         (forget_cached_source_info_for_objfile): Remove declaration.
12986         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12987         * objfiles.c (objfile_relocate1): Remove declaration.
12988         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12989         declaration.
12990         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12991         * coffread.c (coff_symtab_read): Remove declaration.
12992         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12993         compunit_filetabs.
12994
12995 2019-01-09  Tom Tromey  <tom@tromey.com>
12996
12997         * symtab.c (lookup_objfile_from_block)
12998         (find_pc_sect_compunit_symtab, search_symbols)
12999         (default_collect_symbol_completion_matches_break_on): Use
13000         objfile_compunits.
13001         * objfiles.h (ALL_COMPUNITS): Remove.
13002         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13003         * cp-support.c (add_symbol_overload_list_qualified): Use
13004         objfile_compunits.
13005         * ada-lang.c (ada_collect_symbol_completion_matches)
13006         (ada_add_global_exceptions): Use objfile_compunits.
13007
13008 2019-01-09  Tom Tromey  <tom@tromey.com>
13009
13010         * source.c (select_source_symtab)
13011         (forget_cached_source_info_for_objfile): Remove declaration.
13012         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13013         declaration.
13014         * maint.c (count_symtabs_and_blocks): Remove declaration.
13015         * cp-support.c (add_symbol_overload_list_qualified): Remove
13016         declaration.
13017         * coffread.c (coff_symtab_read): Remove declaration.
13018         * symtab.c (lookup_symbol_in_objfile_symtabs)
13019         (basic_lookup_transparent_type_1): Use objfile_compunits.
13020         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13021         (info_sources_command, search_symbols)
13022         (default_collect_symbol_completion_matches_break_on)
13023         (make_source_files_completion_list): Remove declaration.
13024         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13025         (ada_collect_symbol_completion_matches)
13026         (ada_add_global_exceptions): Remove declaration.
13027         * linespec.c (iterate_over_all_matching_symtabs): Use
13028         objfile_compunits.
13029         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13030         (class objfile_compunits): New.
13031         (ALL_COMPUNITS): Use objfile_compunits.
13032         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13033         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13034         objfile_compunits.
13035         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13036
13037 2019-01-09  Tom Tromey  <tom@tromey.com>
13038
13039         * symtab.c (search_symbols)
13040         (default_collect_symbol_completion_matches_break_on): Use
13041         objfile_msymbols.
13042         * ada-lang.c (ada_lookup_simple_minsym)
13043         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13044         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13045         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13046         objfile_msymbols.
13047         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13048         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13049         * objc-lang.c (find_methods): Use objfile_msymbols.
13050         (info_selectors_command, info_classes_command): Likewise.
13051         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13052         * objfiles.h (class objfile_msymbols): New.
13053         (ALL_OBJFILE_MSYMBOLS): Remove.
13054         (ALL_MSYMBOLS): Remove.
13055
13056 2019-01-09  Tom Tromey  <tom@tromey.com>
13057
13058         * common/next-iterator.h (next_adapter): Add Iterator template
13059         parameter.
13060         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13061         (class all_objfiles_safe): New.
13062         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13063         * objfiles.c (put_objfile_before): Update comment.
13064         (add_separate_debug_objfile): Likewise.
13065         (free_all_objfiles): Use all_objfiles_safe.
13066         (objfile_purge_solibs): Likewise.
13067
13068 2019-01-09  Tom Tromey  <tom@tromey.com>
13069
13070         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13071         (expand_symtab_containing_pc, lookup_static_symbol)
13072         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13073         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13074         all_objfiles.
13075         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13076         * breakpoint.c (create_overlay_event_breakpoint)
13077         (create_longjmp_master_breakpoint)
13078         (create_std_terminate_master_breakpoint)
13079         (create_exception_master_breakpoint): Use all_objfiles.
13080         * linux-thread-db.c (try_thread_db_load_from_pdir)
13081         (has_libpthread): Use all_objfiles.
13082         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13083         * linespec.c (iterate_over_all_matching_symtabs)
13084         (search_minsyms_for_name): Use all_objfiles.
13085         * maint.c (maintenance_info_sections): Use all_objfiles.
13086         * main.c (captured_main_1): Use all_objfiles.
13087         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13088         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13089         * guile/scm-pretty-print.c
13090         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13091         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13092         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13093         (maintenance_print_msymbols): Use all_objfiles.
13094         * source.c (select_source_symtab): Use all_objfiles.
13095         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13096         * symfile.c (remove_symbol_file_command)
13097         (expand_symtabs_matching, map_symbol_filenames): Use
13098         all_objfiles.
13099         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13100         all_objfiles.
13101         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13102         * objc-lang.c (find_methods): Use all_objfiles.
13103         * objfiles.c (have_partial_symbols, have_full_symbols)
13104         (have_minimal_symbols, qsort_cmp)
13105         (default_iterate_over_objfiles_in_search_order): Use
13106         all_objfiles.
13107         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13108         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13109         (maintenance_check_psymtabs): Use all_objfiles.
13110         (ALL_PSYMTABS): Remove.
13111         * compile/compile-object-run.c (do_module_cleanup): Use
13112         all_objfiles.
13113         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13114         * cp-support.c (add_symbol_overload_list_qualified): Use
13115         all_objfiles.
13116         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13117         Use all_objfiles.
13118         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13119         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13120         all_objfiles.
13121         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13122         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13123         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13124         Uses all_objfiles.
13125         * solib.c (solib_read_symbols): Use all_objfiles
13126
13127 2019-01-09  Tom Tromey  <tom@tromey.com>
13128
13129         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13130         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13131         all_objfiles.
13132         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13133         * symmisc.c (print_symbol_bcache_statistics)
13134         (print_objfile_statistics, maintenance_print_objfiles)
13135         (maintenance_info_symtabs, maintenance_check_symtabs)
13136         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13137         all_objfiles.
13138         * source.c (forget_cached_source_info): Use all_objfiles.
13139         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13140         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13141         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13142         * objfiles.c (update_section_map): Use all_objfiles.
13143         (shared_objfile_contains_address_p): Likewise.
13144         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13145         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13146
13147 2019-01-09  Tom Tromey  <tom@tromey.com>
13148
13149         * common/next-iterator.h: New file.
13150         * objfiles.h (class all_objfiles): New.
13151         (struct objfile_iterator): New.
13152
13153 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13154
13155         * NEWS: Move the description of the changed "frame", "select-frame",
13156          and "info frame" commands to the Changed commands section.
13157
13158 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13159
13160         * gdbtypes.c (check_stub_method_group): Remove handling of old
13161         mangling schemes.
13162         * linespec.c (find_methods): Likewise.
13163         * stabsread.c (read_member_functions): Likewise.
13164         * valops.c (search_struct_method): Likewise.
13165         (value_struct_elt_for_reference): Likewise.
13166         * NEWS: Mention this change.
13167
13168 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13169
13170         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13171         print_source_lines.
13172         * source.c (print_source_lines_base): Update line number check.
13173         (print_source_lines): New function.
13174         (source_lines_range::source_lines_range): New function.
13175         * source.h (class source_lines_range): New class.
13176         (print_source_lines): New declaration.
13177
13178 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13179
13180         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13181
13182 2019-01-08  Tom Tromey  <tom@tromey.com>
13183             Simon Marchi  <simon.marchi@ericsson.com>
13184
13185         PR gdb/24060
13186         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13187         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13188         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13189         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13190         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13191         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13192
13193 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13194
13195         * source.c (select_source_symtab): Move header comment to
13196         declaration in source.h.
13197         (forget_cached_source_info_for_objfile): Likewise.
13198         (forget_cached_source_info): Likewise.
13199         (identify_source_line): Likewise.
13200         * source.h (identify_source_line): Move declaration from symtab.h
13201         and add comment from source.c
13202         (print_source_lines): Likewise.
13203         (forget_cached_source_info_for_objfile): Likewise.
13204         (forget_cached_source_info): Likewise.
13205         (select_source_symtab): Likewise.
13206         (enum print_source_lines_flag): Move definition from symtab.h.
13207         * symtab.h (identify_source_line): Move declaration to source.h.
13208         (print_source_lines): Likewise.
13209         (forget_cached_source_info_for_objfile): Likewise.
13210         (forget_cached_source_info): Likewise.
13211         (select_source_symtab): Likewise.
13212         (enum print_source_lines_flag): Move definition to source.h.
13213         * tui/tui-hooks.c: Add 'source.h' include.
13214
13215 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13216
13217         * source.c (print_source_lines_base): Handle requests to print
13218         reverse line number sequences, and guard against empty lines
13219         string.
13220
13221 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13222
13223         * source.c (print_source_lines_base): Fix skip of '\r' if next
13224         character is '\n'.
13225
13226 2019-01-06  Tom Tromey  <tom@tromey.com>
13227
13228         * c-exp.y (struct c_parse_state) <macro_original_text,
13229         expansion_obstack>: New member.
13230         (macro_original_text, expansion_obstack): Remove globals.
13231         (scan_macro_expansion, scanning_macro_expansion)
13232         (finished_macro_expansion): Update.
13233         (scan_macro_cleanup): Remove.
13234         (yylex, c_parse): Update.
13235
13236 2019-01-06  Tom Tromey  <tom@tromey.com>
13237
13238         * c-exp.y (struct c_parse_state) <strings>: New member.
13239         (operator_stoken): Update.
13240
13241 2019-01-06  Tom Tromey  <tom@tromey.com>
13242
13243         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13244         (union type_stack_elt) <typelist_val>: Now a pointer to
13245         std::vector.
13246         (type_stack_cleanup): Don't declare.
13247         (push_typelist): Update.
13248         * parse.c (pop_typelist): Return a std::vector.
13249         (push_typelist): Take a std::vector.
13250         (follow_types): Update.  Do not free args.
13251         (type_stack_cleanup): Remove.
13252         * c-exp.y (struct c_parse_state): New.
13253         (cpstate): New global.
13254         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13255         (nonempty_typelist): Update.
13256         (func_mod): Create a new vector.
13257         (c_parse): Create a c_parse_state.
13258         (check_parameter_typelist): Do not delete params.
13259         (function_method): Update.  Do not delete type_list.
13260
13261 2019-01-06  Tom Tromey  <tom@tromey.com>
13262
13263         PR gdb/28155:
13264         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13265         check_typedef.
13266         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13267         (print_return_value): Likewise.
13268
13269 2019-01-05  Tom Tromey  <tom@tromey.com>
13270
13271         * contrib/cleanup_check.py: Remove.
13272         * contrib/gcc-with-excheck: Remove.
13273         * contrib/exsummary.py: Remove.
13274         * contrib/excheck.py: Remove.
13275
13276 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13277
13278         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13279         NULL. Initialize tpprev to NULL instead of assigning it
13280         to NULL on the next statement.
13281         * windows-nat.c (windows_delete_thread): Remove check for
13282         main_thread_id before printing thread exit notifications.
13283         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13284         Remove thread ID check against main_thread_id.
13285         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13286         windows_delete_thread.
13287         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13288
13289 2019-01-04  Tom Tromey  <tom@tromey.com>
13290
13291         * compile/compile.c (_initialize_compile): Use upper case for
13292         metasyntactic variables.
13293         * symmisc.c (_initialize_symmisc): Use upper case for
13294         metasyntactic variables.
13295         * psymtab.c (_initialize_psymtab): Use upper case for
13296         metasyntactic variables.
13297         * demangle.c (demangle_command): Use upper case for metasyntactic
13298         variables.
13299         (_initialize_demangler): Likewise.
13300         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13301         variables.
13302
13303 2019-01-03  Tom Tromey  <tom@tromey.com>
13304
13305         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13306
13307 2019-01-03  Tom Tromey  <tom@tromey.com>
13308
13309         * python/py-symtab.c (salpy_str): Update.
13310         (struct salpy_sal_object) <symtab>: Now a PyObject.
13311         (salpy_dealloc): Update.
13312         (del_objfile_sal): Use gdbpy_ref.
13313
13314 2019-01-03  Tom Tromey  <tom@tromey.com>
13315
13316         * python/py-type.c (convert_field): Use new_reference.  Return
13317         gdbpy_ref.
13318         (make_fielditem): Return gdbpy_ref.
13319         (typy_fields): Update.
13320         (typy_getitem): Update.
13321         (field_name): Return gdbpy_ref.  Use new_reference.
13322         (typy_iterator_iternext): Update.
13323
13324 2019-01-03  Tom Tromey  <tom@tromey.com>
13325
13326         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13327
13328 2019-01-03  Tom Tromey  <tom@tromey.com>
13329
13330         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13331         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13332         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13333         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13334         (pspy_set_type_printers): Likewise.
13335         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13336         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13337         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13338         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13339         (objfpy_set_type_printers): Likewise.
13340
13341 2019-01-03  Tom Tromey  <tom@tromey.com>
13342
13343         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13344         (gdbpy_print_stack): Use gdbpy_err_fetch.
13345         * python/python-internal.h (class gdbpy_err_fetch): New class.
13346         (class gdbpy_enter) <m_error_type, m_error_value,
13347         m_error_traceback>: Remove.
13348         <m_error>: New member.
13349         (gdbpy_exception_to_string): Don't declare.
13350         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13351         * python/py-value.c (convert_value_from_python): Use
13352         gdbpy_err_fetch.
13353         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13354         gdbpy_exception_to_string.
13355         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13356         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13357         gdbpy_err_fetch.
13358
13359 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13360
13361         * linux-nat.c (delete_lwp_cleanup): Delete.
13362         (struct lwp_deleter): New struct.
13363         (lwp_info_up): New typedef.
13364         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13365         lwp_info_up.
13366
13367 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13368
13369         * linux-fork.c (class scoped_switch_fork_info): New class.
13370         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13371
13372 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13373
13374         * valops.c (find_overload_match): Remove use of null_cleanup, and
13375         calls to do_cleanups.
13376
13377 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13378
13379         * compile/compile-cplus-types.c
13380         (compile_cplus_instance::decl_name): Handle changes to
13381         cp_func_name.
13382         * cp-support.c (cp_func_name): Update header comment, update
13383         return type.
13384         * cp-support.h (cp_func_name): Update return type in declaration.
13385         * valops.c (find_overload_match): Move temp_func local to top
13386         level of function and change its type.  Use temp_func to hold and
13387         delete temporary string obtained from cp_func_name.
13388
13389 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13390
13391         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13392         gdb::char_vector, remove cleanup, and update uses of `msg`.
13393
13394 2019-01-03  Jim Wilson  <jimw@sifive.com>
13395
13396         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13397
13398 2019-01-02  Tom Tromey  <tom@tromey.com>
13399
13400         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13401         (tdesc_parse_xml): Remove cleanups.
13402         * target-descriptions.h (make_cleanup_free_target_description):
13403         Don't declare.
13404         (target_desc_deleter): New struct.
13405         (target_desc_up): New typedef.
13406         * target-descriptions.c (target_desc_deleter::operator()): Rename
13407         from free_target_description.
13408         (make_cleanup_free_target_description): Remove.
13409
13410 2019-01-02  Tom Tromey  <tom@tromey.com>
13411
13412         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13413         constructor, destructor.
13414         (linespec_parser): Remove typedef.
13415         (~linespec_parser): Rename from linespec_parser_delete.
13416         (linespec_lex_to_end, linespec_complete_label)
13417         (linespec_complete): Update.
13418         (decode_line_full): Remove cleanups.
13419         (decode_line_1): Update.
13420
13421 2019-01-02  Tom Tromey  <tom@tromey.com>
13422
13423         * python/python-internal.h (inferior_to_inferior_object): Change
13424         return type.
13425         * python/py-exitedevent.c (create_exited_event_object): Update.
13426         * python/py-inferior.c (inferior_to_inferior_object): Return
13427         gdbpy_ref.
13428         (python_new_inferior, python_inferior_deleted)
13429         (thread_to_thread_object, delete_thread_object)
13430         (build_inferior_list, gdbpy_selected_inferior): Update.
13431         * python/py-infthread.c (create_thread_object): Update.  Also fail
13432         if inferior_to_inferior_object fails.
13433
13434 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13435
13436         * inferior.h (class inferior) <displaced_step_state>: New field.
13437         * infrun.h (struct displaced_step_state): Move here from
13438         infrun.c.  Initialize fields, add constructor.
13439         <inf>: Remove field.
13440         <reset>: New method.
13441         * infrun.c (struct displaced_step_inferior_state): Move to
13442         infrun.h.
13443         (displaced_step_inferior_states): Remove.
13444         (get_displaced_stepping_state): Adust.
13445         (displaced_step_in_progress_any_inferior): Adjust.
13446         (displaced_step_in_progress_thread): Adjust.
13447         (displaced_step_in_progress): Adjust.
13448         (add_displaced_stepping_state): Remove.
13449         (get_displaced_step_closure_by_addr): Adjust.
13450         (remove_displaced_stepping_state): Remove.
13451         (infrun_inferior_exit): Call displaced_step_state.reset.
13452         (use_displaced_stepping): Don't check for NULL.
13453         (displaced_step_prepare_throw): Call
13454         get_displaced_stepping_state.
13455         (displaced_step_fixup): Don't check for NULL.
13456         (prepare_for_detach): Don't check for NULL.
13457
13458 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13459
13460         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13461          in case of call that did not complete.
13462
13463 2019-01-02  Andrey Utkin  <autkin@undo.io>
13464
13465         * symfile.c (find_separate_debug_file): Fix search of debug files for
13466         remote debuggee.
13467
13468 2019-01-02  Tom Tromey  <tom@tromey.com>
13469
13470         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13471         indentation.
13472         * python/py-frame.c (frapy_older): Remove cast.
13473         (frapy_newer): Likewise.
13474         * python/py-breakpoint.c (local_setattro): Remove cast.
13475         * python/py-arch.c (archpy_name): Remove local variable.
13476         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13477
13478 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13479
13480         * unittests/basic_string_view/element_access/char/empty.cc:
13481         Fix year range in copyright header.
13482
13483 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13484
13485         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13486         Delete.
13487         <operator==>: Update with for removed field.
13488         <hash>: Likewise.
13489         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13490         <isa_features>: ...this.
13491         <abi_features>: New field.
13492         (riscv_isa_flen): Update comment.
13493         (riscv_abi_xlen): New declaration.
13494         (riscv_abi_flen): New declaration.
13495         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13496         isa_features.
13497         (riscv_abi_xlen): New function.
13498         (riscv_isa_flen): Update to get answer from isa_features.
13499         (riscv_abi_flen): New function.
13500         (riscv_has_fp_abi): Update to get answer from abi_features.
13501         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13502         xlen and flen.
13503         (riscv_call_info) <xlen, flen>: Update comment.
13504         (riscv_call_arg_struct): Remove invalid assertions
13505         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13506         is removed.
13507         (riscv_gdbarch_init): Gather isa features and abi features
13508         separately, ensure both match on the gdbarch when reusing an old
13509         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13510         a target with 64-bit float hardware.
13511
13512 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13513
13514         * source.c (search_command_helper): Stop reverse search
13515         when line 1 has been searched.
13516
13517 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13518
13519         * record-full.c (record_full_base_target::close): Rewrite
13520         record_full_core_buf_list free logic.
13521
13522 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13523
13524         * break-catch-syscall.c (print_one_catch_syscall): xfree
13525         the last text.
13526
13527 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13528
13529         * top.c (print_gdb_version): Update Copyright year in version
13530         message.
13531
13532 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13533
13534         Update copyright year range in all GDB files.
13535
13536 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13537
13538         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13539
13540 For older changes see ChangeLog-2018.
13541 \f
13542 Local Variables:
13543 mode: change-log
13544 left-margin: 8
13545 fill-column: 74
13546 version-control: never
13547 coding: utf-8
13548 End:
13549