gdb/ChangeLog

   1 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
   4         instruction, skip it if it's there.
   5
   6 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
   7
   8         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
   9
  10 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
  11
  12         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
  13         * gdbtypes.c (recursive_dump_type): Remove use of
  14         TYPE_INCOMPLETE.
  15
  16 2020-05-03  Tom Tromey  <tom@tromey.com>
  17
  18         * breakpoint.c (catch_command, tcatch_command): Remove.
  19         (_initialize_breakpoint): Use add_basic_prefix_cmd,
  20         add_show_prefix_cmd.
  21         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
  22         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
  23         Remove.
  24         (add_internal_problem_command): Use add_basic_prefix_cmd,
  25         add_show_prefix_cmd.
  26         * mips-tdep.c (set_mipsfpu_command): Remove.
  27         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
  28         * dwarf2/index-cache.c (set_index_cache_command): Remove.
  29         (_initialize_index_cache): Use add_basic_prefix_cmd.
  30         * memattr.c (dummy_cmd): Remove.
  31         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
  32         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
  33         (_initialize_tui_win): Use add_basic_prefix_cmd,
  34         add_show_prefix_cmd.
  35         * cli/cli-logging.c (set_logging_command): Remove.
  36         (_initialize_cli_logging): Use add_basic_prefix_cmd,
  37         add_show_prefix_cmd.
  38         (show_logging_command): Remove.
  39         * target.c (target_command): Remove.
  40         (add_target): Use add_basic_prefix_cmd.
  41
  42 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
  43
  44         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
  45
  46 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  47
  48         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
  49         info_command.
  50
  51 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
  52
  53         * nbsd-nat.c (nbsd_enable_proc_events)
  54         (nbsd_nat_target::post_startup_inferior): Add.
  55         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
  56         (nbsd_nat_target::update_thread_list): Rewrite.
  57         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
  58         "PTRACE_LWP_CREATE".
  59         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
  60
  61 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  62
  63         * stack.c (_initialize_stack): Remove duplicated creation
  64         of "frame" command and "f" alias.
  65
  66 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
  67
  68         PR gdb/18706
  69         * gdbtypes.c (check_typedef): Calculate size of array of
  70         stubbed type.
  71
  72 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
  73
  74         PR gdb/15559
  75         * i386-tdep.c (i386_push_dummy_call): Call
  76         i386_thiscall_push_dummy_call.
  77         (i386_thiscall_push_dummy_call): New function.
  78         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
  79         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
  80         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
  81
  82 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
  83
  84         * gdbarch.sh (do_read): Add shellcheck disable directive for
  85         warning SC2162.
  86
  87 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
  88
  89         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
  90         "referenced but not assigned" warning.
  91
  92 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
  93
  94         * gdbarch.sh: Remove code that sets fallbackdefault.
  95
  96 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
  97
  98         * gdbarch.sh: Use shell operators && and || instead of
  99         -a and -o.
 100
 101 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 102
 103         * gdbarch.sh: Use $(...) instead of `...`.
 104
 105 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 106
 107         * gdbarch.sh: Use double quotes around variables.
 108
 109 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 110
 111         * gdbarch.sh: Use %s with printf, instead of variables in the
 112         format string.
 113
 114 2020-04-29  Tom Tromey  <tromey@adacore.com>
 115
 116         PR ada/25875:
 117         * dwarf2/read.c (update_enumeration_type_from_children): Compute
 118         type fields here.
 119         (read_enumeration_type): Call
 120         update_enumeration_type_from_children later.  Update comments.
 121         (process_enumeration_scope): Don't create type fields.
 122
 123 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
 124
 125         * nbsd-tdep.c: Include "xml-syscall.h".
 126         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
 127
 128 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
 129
 130         * nbsd-nat.c: Include "sys/wait.h".
 131         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
 132         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
 133         (nbsd_nat_target::remove_exec_catchpoint)
 134         (nbsd_nat_target::set_syscall_catchpoint): Add.
 135         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
 136         (nbsd_nat_target::insert_exec_catchpoint)
 137         (nbsd_nat_target::remove_exec_catchpoint)
 138         (nbsd_nat_target::set_syscall_catchpoint): Add.
 139         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
 140         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
 141         `nbsd_get_syscall_number'.
 142
 143 2020-04-29  Tom Tromey  <tom@tromey.com>
 144
 145         * stack.c (print_block_frame_labels): Remove.
 146
 147 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
 148
 149         PR gdb/17320
 150         * ada-valprint.c (val_print_packed_array_elements): Move array
 151         end bracket to new line.
 152         (ada_val_print_string): Remove extra spaces before first array
 153         element.
 154         * c-valprint.c (c_value_print_array): Likewise.
 155         * m2-valprint.c (m2_print_array_contents): Likewise.
 156         (m2_value_print_inner): Likewise.
 157         * p-valprint.c (pascal_value_print_inner): Likewise.
 158         * valprint.c (generic_val_print_array): Likewise.
 159         (value_print_array_elements): Move first array element and array
 160         end bracket to new line.
 161
 162 2020-04-29  Tom de Vries  <tdevries@suse.de>
 163
 164         PR symtab/25889
 165         * linespec.c (find_method): Fix ix calculation.
 166
 167 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
 168
 169         * syscalls/update-netbsd.sh: New file.
 170         * syscalls/netbsd.xml: Regenerate.
 171         * data-directory/Makefile.in: Register `netbsd.xml' in
 172         `SYSCALLS_FILES'.
 173
 174 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
 175
 176         * syscalls/update-freebsd.sh: Add double quotes.
 177
 178 2020-04-28  Tom Tromey  <tom@tromey.com>
 179
 180         * NEWS: Update.
 181         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
 182         (cmdpy_init): Allow class_tui.
 183
 184 2020-04-28 Mark Williams <mark@myosotissp.com>
 185
 186         PR gdb/24480
 187         * dwarf2read.c: Add missing assingments to list_in_scope when
 188         start_symtab was already called.
 189
 190 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
 191
 192         PR gdb/25881
 193         * dwarf2/read.c (offset_map_type): Use
 194         gdb:hash_enum<sect_offset> as hash function.
 195
 196 2020-04-28  Tom de Vries  <tdevries@suse.de>
 197
 198         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
 199         with DW_AT_signature.
 200
 201 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
 202
 203         * configure.ac: Remove check for fs_base/gs_base in
 204         user_regs_struct.
 205         * configure: Re-generate.
 206         * config.in: Re-generate.
 207         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
 208         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
 209         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
 210
 211 2020-04-27  Luis Machado  <luis.machado@linaro.org>
 212
 213         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
 214         problematic inline frame unwinding situation.
 215         * frame.c (frame_id_computed_p): New function.
 216         * frame.h (frame_id_computed_p): New prototype.
 217
 218 2020-04-26  Tom Tromey  <tom@tromey.com>
 219
 220         * command.h (enum command_class) <class_pseudo>: Remove.
 221
 222 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 223
 224         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
 225         and whitespace.
 226
 227 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
 228
 229        * inf-ptrace.c (inf_ptrace_target::wait): Remove
 230        `PT_GET_PROCESS_STATE' block.
 231
 232 2020-04-24  Tom Tromey  <tom@tromey.com>
 233
 234         * symtab.h (symbol_get_demangled_name): Don't declare.
 235         * symtab.c (symbol_get_demangled_name): Remove.
 236         (general_symbol_info::natural_name)
 237         (general_symbol_info::demangled_name): Update.
 238
 239 2020-04-24  Tom Tromey  <tom@tromey.com>
 240
 241         PR rust/25025:
 242         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
 243
 244 2020-04-24  Tom Tromey  <tom@tromey.com>
 245
 246         PR symtab/12707:
 247         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
 248         exists.
 249         (new_symbol): Likewise.
 250         * compile/compile-object-load.c (get_out_value_type): Use
 251         symbol_matches_search_name.
 252
 253 2020-04-24  Tom Tromey  <tom@tromey.com>
 254
 255         * dwarf2/read.c (add_partial_symbol): Do not call
 256         compute_and_set_names.
 257
 258 2020-04-24  Tom Tromey  <tom@tromey.com>
 259
 260         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
 261         overload.
 262
 263 2020-04-24  Tom Tromey  <tom@tromey.com>
 264
 265         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
 266         (add_psymbol_to_list): New overload.  Make old overload call new
 267         one.
 268         * psympriv.h (add_psymbol_to_list): New overload.
 269
 270 2020-04-24  Tom Tromey  <tom@tromey.com>
 271
 272         * dwarf2/read.c (partial_die_info::read) <case
 273         DW_AT_linkage_name>: Use value_as_string.
 274         (dwarf2_string_attr): Use value_as_string.
 275         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
 276         method.
 277         * dwarf2/attribute.c (attribute::value_as_string): New method.
 278
 279 2020-04-24  Tom Tromey  <tom@tromey.com>
 280
 281         * symtab.c (general_symbol_info::natural_name)
 282         (general_symbol_info::demangled_name): Check for language_rust.
 283
 284 2020-04-24  Tom Tromey  <tom@tromey.com>
 285
 286         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
 287         (dwarf2_physname): ... from here.
 288         (partial_die_info::read): Add Rust "{" hack.
 289
 290 2020-04-24  Tom Tromey  <tom@tromey.com>
 291
 292         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
 293         method.
 294         (symbol_set_demangled_name): Don't declare.
 295         * symtab.c (general_symbol_info::set_demangled_name): Rename from
 296         symbol_set_demangled_name.
 297         (general_symbol_info::set_language)
 298         (general_symbol_info::compute_and_set_names): Update.
 299         * minsyms.c (minimal_symbol_reader::install): Update.
 300         * dwarf2/read.c (new_symbol): Update.
 301
 302 2020-04-24  Tom Tromey  <tromey@adacore.com>
 303
 304         PR python/23662:
 305         * python/py-type.c (convert_field): Handle
 306         FIELD_LOC_KIND_DWARF_BLOCK.
 307         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
 308         (typy_get_dynamic): Nw function.
 309         (type_object_getset): Add "dynamic".
 310         * NEWS: Add entry.
 311
 312 2020-04-24  Tom Tromey  <tromey@adacore.com>
 313
 314         * ada-typeprint.c (print_choices, print_variant_part)
 315         (print_record_field_types_dynamic): New functions.
 316         (print_record_field_types): Use print_record_field_types_dynamic.
 317
 318 2020-04-24  Tom Tromey  <tromey@adacore.com>
 319
 320         * dwarf2/read.c (handle_data_member_location): New overload.
 321         (dwarf2_add_field): Use it.
 322         (decode_locdesc): Add "computed" parameter.  Update comment.
 323         * gdbtypes.c (is_dynamic_type_internal): Also look for
 324         FIELD_LOC_KIND_DWARF_BLOCK.
 325         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
 326         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
 327         virtual base classes.
 328         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
 329         FIELD_LOC_KIND_DWARF_BLOCK.
 330
 331 2020-04-24  Tom Tromey  <tromey@adacore.com>
 332
 333         * dwarf2/read.c (read_structure_type): Handle dynamic length.
 334         * gdbtypes.c (is_dynamic_type_internal): Check
 335         TYPE_HAS_DYNAMIC_LENGTH.
 336         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
 337         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
 338         New macros.
 339         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
 340         constant.
 341
 342 2020-04-24  Tom Tromey  <tromey@adacore.com>
 343
 344         * dwarf2/read.c (struct variant_field): Rewrite.
 345         (struct variant_part_builder): New.
 346         (struct nextfield): Remove "variant" field.  Add "offset".
 347         (struct field_info): Add "current_variant_part" and
 348         "variant_parts".
 349         (alloc_discriminant_info): Remove.
 350         (alloc_rust_variant): New function.
 351         (quirk_rust_enum): Update.
 352         (dwarf2_add_field): Set "offset" member.  Don't handle
 353         DW_TAG_variant_part.
 354         (offset_map_type): New typedef.
 355         (convert_variant_range, create_one_variant)
 356         (create_one_variant_part, create_variant_parts)
 357         (add_variant_property): New functions.
 358         (dwarf2_attach_fields_to_type): Call add_variant_property.
 359         (read_structure_type): Don't handle DW_TAG_variant_part.
 360         (handle_variant_part, handle_variant): New functions.
 361         (handle_struct_member_die): Use them.
 362         (process_structure_scope): Don't handle variant parts.
 363         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
 364         (struct discriminant_info): Remove.
 365         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
 366         (struct main_type) <flag_discriminated_union>: Remove.
 367         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
 368         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
 369         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
 370         Update.
 371         * valops.c (value_union_variant): Remove.
 372         * value.h (value_union_variant): Don't declare.
 373
 374 2020-04-24  Tom Tromey  <tromey@adacore.com>
 375
 376         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
 377         (ada_value_primitive_packed_val): Update.
 378         * ada-valprint.c (ada_value_print_1): Update.
 379         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
 380         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
 381         just an address.  Use evaluate_for_locexpr_baton.
 382         (dwarf2_evaluate_property): Update.
 383         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
 384         array_view.
 385         * findvar.c (default_read_var_value): Update.
 386         * gdbtypes.c (compute_variant_fields_inner)
 387         (resolve_dynamic_type_internal): Update.
 388         (resolve_dynamic_type): Change type of valaddr parameter.
 389         * gdbtypes.h (resolve_dynamic_type): Update.
 390         * valarith.c (value_subscripted_rvalue): Update.
 391         * value.c (value_from_contents_and_address): Update.
 392
 393 2020-04-24  Tom Tromey  <tromey@adacore.com>
 394
 395         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
 396         "push_initial_value" parameter.
 397         (dwarf2_evaluate_property): Likewise.
 398         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
 399
 400 2020-04-24  Tom Tromey  <tromey@adacore.com>
 401
 402         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
 403         (variant::matches, compute_variant_fields_recurse)
 404         (compute_variant_fields_inner, compute_variant_fields): New
 405         functions.
 406         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
 407         Use resolved_type after type is made.
 408         (operator==): Add new cases.
 409         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
 410         (struct discriminant_range, struct variant, struct variant_part):
 411         New.
 412         (union dynamic_prop_data) <variant_parts, original_type>: New
 413         members.
 414         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
 415         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
 416         constants.
 417         * value.c (unpack_bits_as_long): Now public.
 418         * value.h (unpack_bits_as_long): Declare.
 419
 420 2020-04-24  Tom Tromey  <tromey@adacore.com>
 421
 422         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
 423         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
 424
 425 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
 426
 427         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
 428
 429 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
 430
 431         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
 432         (remove_fork_catchpoint, post_startup_inferior)
 433         (post_attach): Move...
 434         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
 435         (remove_fork_catchpoint, post_startup_inferior)
 436         (post_attach): ...here.
 437         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
 438         (remove_fork_catchpoint, post_startup_inferior)
 439         (post_attach): Move...
 440         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
 441         (remove_fork_catchpoint, post_startup_inferior)
 442         (post_attach): ...here.
 443
 444 2020-04-24  Tom Tromey  <tromey@adacore.com>
 445
 446         * nat/windows-nat.h (struct windows_thread_info)
 447         <pc_adjusted>: New member.
 448         * windows-nat.c (windows_fetch_one_register): Check
 449         pc_adjusted.
 450         (windows_nat_target::get_windows_debug_event)
 451         (windows_nat_target::wait): Set pc_adjusted.
 452
 453 2020-04-24  Tom de Vries  <tdevries@suse.de>
 454
 455         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
 456         Run gdb-add-index inside temp dir.
 457
 458 2020-04-23  Tom Tromey  <tromey@adacore.com>
 459
 460         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
 461         in loop.
 462
 463 2020-04-23  Luis Machado  <luis.machado@linaro.org>
 464
 465         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
 466         get_frame_register instead of gdbarch_unwind_pc.
 467
 468 2020-04-23  Tom de Vries  <tdevries@suse.de>
 469
 470         * symtab.c (lookup_global_symbol): Prefer def over decl.
 471
 472 2020-04-23  Tom de Vries  <tdevries@suse.de>
 473
 474         PR symtab/25807
 475         * block.c (best_symbol, better_symbol): Promote to external.
 476         * block.h (best_symbol, better_symbol): Declare.
 477         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
 478         decl.
 479
 480 2020-04-23  Tom Tromey  <tromey@adacore.com>
 481
 482         PR ada/25837:
 483         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
 484         "const char *", not a "const std::string &".
 485         <name_and_matcher::operator==>: Update.
 486         * unittests/lookup_name_info-selftests.c: Change type of
 487         "result".
 488
 489 2020-04-23  Tom Tromey  <tom@tromey.com>
 490
 491         * inferior.h (iterate_over_inferiors): Don't declare.
 492         * inferior.c (iterate_over_inferiors): Remove.
 493         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
 494         Remove.
 495         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
 496         use iterate_over_inferiors.
 497         (darwin_resume_inferior_it)
 498         (struct resume_inferior_threads_param)
 499         (darwin_resume_inferior_threads_it): Remove.
 500         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
 501
 502 2020-04-23  Tom de Vries  <tdevries@suse.de>
 503
 504         * blockframe.c (find_pc_partial_function): Use
 505         find_pc_sect_compunit_symtab rather than
 506         objfile->sf->qf->find_pc_sect_compunit_symtab.
 507
 508 2020-04-22  Tom de Vries  <tdevries@suse.de>
 509
 510         PR symtab/25764
 511         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
 512         in psymtabs.
 513
 514 2020-04-22  Tom de Vries  <tdevries@suse.de>
 515
 516         PR symtab/25801
 517         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
 518         symtabs.
 519
 520 2020-04-22  Tom de Vries  <tdevries@suse.de>
 521
 522         PR symtab/25700
 523         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
 524         CU if already created.
 525
 526 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 527
 528         * infrun.c (displaced_step_fixup): Switch to the event_thread
 529         before calling displaced_step_restore, not after.
 530
 531 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 532
 533         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
 534         its inferior is not recorded by us.
 535         (record_btrace_target_open): Replace call to
 536         all_non_exited_threads () with call to current_inferior
 537         ()->non_exited_threads ().
 538         (record_btrace_target::stop_recording): Likewise.
 539         (record_btrace_target::close): Likewise.
 540         (record_btrace_target::wait): Likewise.
 541         (record_btrace_target::record_stop_replaying): Likewise.
 542
 543 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 544
 545         * btrace.c (btrace_enable): Throw an error on double enables and
 546         when enabling recording fails.
 547         (btrace_disable): Throw an error if the thread is not recorded.
 548
 549 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 550
 551         * record-btrace.c (record_btrace_target::fetch_registers): Forward
 552         request if we do not have a thread_info.
 553
 554 2020-04-21  Tom de Vries  <tdevries@suse.de>
 555
 556         PR gdb/25471
 557         * thread.c
 558         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
 559         exception in get_frame_id.
 560
 561 2020-04-20  Tom Tromey  <tromey@adacore.com>
 562
 563         * python/python.c (struct gdbpy_event): Mark move constructor as
 564         noexcept.
 565         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
 566         constructor as noexcept.
 567         * completer.h (struct completion_result): Mark move constructor as
 568         noexcept.
 569         * completer.c (completion_result::completion_result): Use
 570         initialization style.  Don't call reset_match_list.
 571
 572 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
 573
 574         * MAINTAINERS (Write After Approval): Add myself.
 575
 576 2020-04-18  Tom Tromey  <tom@tromey.com>
 577
 578         * windows-tdep.c (init_w32_command_list)
 579         (w32_prefix_command_valid): Restore.
 580         (_initialize_windows_tdep): Call init_w32_command_list.
 581
 582 2020-04-18  Tom Tromey  <tom@tromey.com>
 583
 584         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
 585         * value.c (value_fn_field): Update.
 586         * valops.c (find_function_in_inferior)
 587         (value_allocate_space_in_inferior): Update.
 588         * tui/tui-winsource.c (tui_update_source_windows_with_line):
 589         Update.
 590         * tui/tui-source.c (tui_source_window::set_contents): Update.
 591         * symtab.c (lookup_global_or_static_symbol)
 592         (find_function_start_sal_1, skip_prologue_sal)
 593         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
 594         * symmisc.c (dump_msymbols, dump_symtab_1)
 595         (maintenance_print_one_line_table): Update.
 596         * symfile.c (init_entry_point_info, section_is_mapped)
 597         (list_overlays_command, simple_read_overlay_table)
 598         (simple_overlay_update_1): Update.
 599         * stap-probe.c (handle_stap_probe): Update.
 600         * stabsread.c (dbx_init_float_type, define_symbol)
 601         (read_one_struct_field, read_enum_type, read_range_type): Update.
 602         * source.c (info_line_command): Update.
 603         * python/python.c (gdbpy_source_objfile_script)
 604         (gdbpy_execute_objfile_script): Update.
 605         * python/py-type.c (save_objfile_types): Update.
 606         * python/py-objfile.c (py_free_objfile): Update.
 607         * python/py-inferior.c (python_new_objfile): Update.
 608         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
 609         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
 610         (maintenance_check_psymtabs): Update.
 611         * printcmd.c (info_address_command): Update.
 612         * objfiles.h (struct objfile) <arch>: New method, from
 613         get_objfile_arch.
 614         (get_objfile_arch): Don't declare.
 615         * objfiles.c (get_objfile_arch): Remove.
 616         (filter_overlapping_sections): Update.
 617         * minsyms.c (msymbol_is_function): Update.
 618         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
 619         (output_nondebug_symbol): Update.
 620         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
 621         (mdebug_expand_psymtab): Update.
 622         * machoread.c (macho_add_oso_symfile): Update.
 623         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
 624         Update.
 625         * linux-fork.c (checkpoint_command): Update.
 626         * linespec.c (convert_linespec_to_sals): Update.
 627         * jit.c (finalize_symtab): Update.
 628         * infrun.c (insert_exception_resume_from_probe): Update.
 629         * ia64-tdep.c (ia64_find_unwind_table): Update.
 630         * hppa-tdep.c (internalize_unwinds): Update.
 631         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
 632         Update.
 633         * gcore.c (call_target_sbrk): Update.
 634         * elfread.c (record_minimal_symbol, elf_symtab_read)
 635         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
 636         (elf_gnu_ifunc_resolve_by_got): Update.
 637         * dwarf2/read.c (create_addrmap_from_index)
 638         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 639         (read_debug_names_from_section)
 640         (process_psymtab_comp_unit_reader, add_partial_symbol)
 641         (add_partial_subprogram, process_full_comp_unit)
 642         (read_file_scope, read_func_scope, read_lexical_block_scope)
 643         (read_call_site_scope, dwarf2_ranges_read)
 644         (dwarf2_record_block_ranges, dwarf2_add_field)
 645         (mark_common_block_symbol_computed, read_tag_pointer_type)
 646         (read_tag_string_type, dwarf2_init_float_type)
 647         (dwarf2_init_complex_target_type, read_base_type)
 648         (partial_die_info::read, partial_die_info::read)
 649         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
 650         (dwarf2_fetch_die_loc_sect_off): Update.
 651         * dwarf2/loc.c (dwarf2_find_location_expression)
 652         (class dwarf_evaluate_loc_desc, rw_pieced_value)
 653         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
 654         (dwarf2_loc_desc_get_symbol_read_needs)
 655         (locexpr_describe_location_piece, locexpr_describe_location_1)
 656         (loclist_describe_location): Update.
 657         * dwarf2/index-write.c (write_debug_names): Update.
 658         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
 659         * dtrace-probe.c (dtrace_process_dof): Update.
 660         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
 661         (process_one_symbol): Update.
 662         * ctfread.c (ctf_init_float_type, read_base_type): Update.
 663         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
 664         (coff_read_enum_type): Update.
 665         * cli/cli-cmds.c (edit_command, list_command): Update.
 666         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
 667         * breakpoint.c (create_overlay_event_breakpoint)
 668         (create_longjmp_master_breakpoint)
 669         (create_std_terminate_master_breakpoint)
 670         (create_exception_master_breakpoint, get_sal_arch): Update.
 671         * block.c (block_gdbarch): Update.
 672         * annotate.c (annotate_source_line): Update.
 673
 674 2020-04-17  Tom Tromey  <tromey@adacore.com>
 675
 676         * auto-load.c (show_auto_load_cmd): Remove.
 677         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
 678         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
 679         (maintenance_print_arc_command): Remove.
 680         * tui/tui-win.c (tui_command): Remove.
 681         (tui_get_cmd_list): Use add_basic_prefix_cmd.
 682         * tui/tui-layout.c (tui_layout_command): Remove.
 683         (_initialize_tui_layout): Use add_basic_prefix_cmd.
 684         * python/python.c (user_set_python, user_show_python): Remove.
 685         (_initialize_python): Use add_basic_prefix_cmd,
 686         add_show_prefix_cmd.
 687         * guile/guile.c (set_guile_command, show_guile_command): Remove.
 688         (install_gdb_commands): Use add_basic_prefix_cmd,
 689         add_show_prefix_cmd.
 690         (info_guile_command): Remove.
 691         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
 692         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
 693         add_show_prefix_cmd.
 694         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 695         Remove do_set and do_show parameters.
 696         * cli/cli-style.c (set_style, show_style): Remove.
 697         (_initialize_cli_style): Use add_basic_prefix_cmd,
 698         add_show_prefix_cmd.
 699         (cli_style_option::add_setshow_commands): Remove do_set and
 700         do_show parameters.
 701         (cli_style_option::add_setshow_commands): Use
 702         add_basic_prefix_cmd, add_show_prefix_cmd.
 703         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
 704         (set_style_name): Remove.
 705         * cli/cli-dump.c (dump_command, append_command): Remove.
 706         (srec_dump_command, ihex_dump_command, verilog_dump_command)
 707         (tekhex_dump_command, binary_dump_command)
 708         (binary_append_command): Remove.
 709         (_initialize_cli_dump): Use add_basic_prefix_cmd.
 710         * windows-tdep.c (w32_prefix_command_valid): Remove global.
 711         (init_w32_command_list): Remove; move into ...
 712         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
 713         * valprint.c (set_print, show_print, set_print_raw)
 714         (show_print_raw): Remove.
 715         (_initialize_valprint): Use add_basic_prefix_cmd,
 716         add_show_prefix_cmd.
 717         * typeprint.c (set_print_type, show_print_type): Remove.
 718         (_initialize_typeprint): Use add_basic_prefix_cmd,
 719         add_show_prefix_cmd.
 720         * record.c (set_record_command, show_record_command): Remove.
 721         (_initialize_record): Use add_basic_prefix_cmd,
 722         add_show_prefix_cmd.
 723         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
 724         add_show_prefix_cmd.
 725         (info_command, show_command, set_debug, show_debug): Remove.
 726         * top.h (set_history, show_history): Don't declare.
 727         * top.c (set_history, show_history): Remove.
 728         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
 729         (unset_tdesc_cmd): Remove.
 730         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
 731         add_show_prefix_cmd.
 732         * symtab.c (info_module_command): Remove.
 733         (_initialize_symtab): Use add_basic_prefix_cmd.
 734         * symfile.c (overlay_command): Remove.
 735         (_initialize_symfile): Use add_basic_prefix_cmd.
 736         * sparc64-tdep.c (info_adi_command): Remove.
 737         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
 738         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
 739         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
 740         add_show_prefix_cmd.
 741         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
 742         (_initialize_serial): Use add_basic_prefix_cmd,
 743         add_show_prefix_cmd.
 744         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
 745         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
 746         add_show_prefix_cmd.
 747         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
 748         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
 749         add_show_prefix_cmd.
 750         * riscv-tdep.c (show_riscv_command, set_riscv_command)
 751         (show_debug_riscv_command, set_debug_riscv_command): Remove.
 752         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
 753         add_show_prefix_cmd.
 754         * remote.c (remote_command, set_remote_cmd): Remove.
 755         (_initialize_remote): Use add_basic_prefix_cmd.
 756         * record-full.c (set_record_full_command)
 757         (show_record_full_command): Remove.
 758         (_initialize_record_full): Use add_basic_prefix_cmd,
 759         add_show_prefix_cmd.
 760         * record-btrace.c (cmd_set_record_btrace)
 761         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
 762         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
 763         (cmd_show_record_btrace_pt): Remove.
 764         (_initialize_record_btrace): Use add_basic_prefix_cmd,
 765         add_show_prefix_cmd.
 766         * ravenscar-thread.c (set_ravenscar_command)
 767         (show_ravenscar_command): Remove.
 768         (_initialize_ravenscar): Use add_basic_prefix_cmd,
 769         add_show_prefix_cmd.
 770         * mips-tdep.c (show_mips_command, set_mips_command)
 771         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
 772         add_show_prefix_cmd.
 773         * maint.c (maintenance_command, maintenance_info_command)
 774         (maintenance_check_command, maintenance_print_command)
 775         (maintenance_set_cmd, maintenance_show_cmd): Remove.
 776         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
 777         add_show_prefix_cmd.
 778         (show_per_command_cmd): Remove.
 779         * maint-test-settings.c (maintenance_set_test_settings_cmd):
 780         Remove.
 781         (maintenance_show_test_settings_cmd): Remove.
 782         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
 783         add_show_prefix_cmd.
 784         * maint-test-options.c (maintenance_test_options_command):
 785         Remove.
 786         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
 787         * macrocmd.c (macro_command): Remove
 788         (_initialize_macrocmd): Use add_basic_prefix_cmd.
 789         * language.c (set_check, show_check): Remove.
 790         (_initialize_language): Use add_basic_prefix_cmd,
 791         add_show_prefix_cmd.
 792         * infcmd.c (unset_command): Remove.
 793         (_initialize_infcmd): Use add_basic_prefix_cmd.
 794         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
 795         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
 796         add_show_prefix_cmd.
 797         * go32-nat.c (go32_info_dos_command): Remove.
 798         (_initialize_go32_nat): Use add_basic_prefix_cmd.
 799         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
 800         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
 801         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
 802         (_initialize_frame): Use add_basic_prefix_cmd,
 803         add_show_prefix_cmd.
 804         * dcache.c (set_dcache_command, show_dcache_command): Remove.
 805         (_initialize_dcache): Use add_basic_prefix_cmd,
 806         add_show_prefix_cmd.
 807         * cp-support.c (maint_cplus_command): Remove.
 808         (_initialize_cp_support): Use add_basic_prefix_cmd.
 809         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
 810         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
 811         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
 812         add_basic_prefix_cmd, add_show_prefix_cmd.
 813         * breakpoint.c (save_command): Remove.
 814         (_initialize_breakpoint): Use add_basic_prefix_cmd.
 815         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
 816         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
 817         add_show_prefix_cmd.
 818         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
 819         (set_ada_command, show_ada_command): Remove.
 820         (_initialize_ada_language): Use add_basic_prefix_cmd,
 821         add_show_prefix_cmd.
 822         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
 823
 824 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
 825
 826         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
 827         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
 828
 829 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
 830
 831         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
 832         warning messages.
 833
 834 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
 835
 836         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
 837         import table is not at beginning of .idata section.
 838
 839 2020-04-16  Pedro Alves  <palves@redhat.com>
 840
 841         * inferior.c (delete_inferior): Use delete operator directly
 842         instead of delete_program_space.
 843         * progspace.c (add_program_space): New, factored out from
 844         program_space::program_space.
 845         (remove_program_space): New, factored out from
 846         delete_program_space.
 847         (program_space::program_space): Remove intro comment.  Rewrite.
 848         (program_space::~program_space): Remove intro comment.  Call
 849         remove_program_space.
 850         (delete_program_space): Delete.
 851         * progspace.h (program_space::program_space): Make explicit.  Move
 852         intro comment here, adjusted.
 853         (program_space::~program_space): Move intro comment here,
 854         adjusted.
 855         (delete_program_space): Remove.
 856
 857 2020-04-16  Tom Tromey  <tromey@adacore.com>
 858
 859         * windows-nat.c (windows_nat::handle_access_violation): New
 860         function.
 861         * nat/windows-nat.h (handle_access_violation): Declare.
 862         * nat/windows-nat.c (handle_exception): Move Cygwin code to
 863         windows-nat.c.  Call handle_access_violation.
 864
 865 2020-04-16  Tom de Vries  <tdevries@suse.de>
 866
 867         PR symtab/25791
 868         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
 869         CUs without psymtab.
 870
 871 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
 872
 873         * python/python.c (do_start_initialization): Don't call
 874         PyEval_InitThreads for Python 3.9 and beyond.
 875
 876 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
 877
 878         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
 879         thread functions.
 880         (obsd_nat_target::wait): Likewise.
 881
 882 2020-04-15  Tom Tromey  <tromey@adacore.com>
 883
 884         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
 885         (DEBUG_EXCEPT): Use debug_printf.
 886
 887 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 888
 889         * completer.c (class completion_tracker::completion_hash_entry)
 890         <hash_name>: New member function.
 891         (completion_tracker::discard_completions): New callback to hash a
 892         completion_hash_entry, pass this to htab_create_alloc.
 893
 894 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
 895
 896         * windows-nat.c (windows_make_so): Warn rather than stopping with
 897         an error if realpath() fails.
 898
 899 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
 900
 901         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
 902         (nbsd_nat_target::info_proc): Add do_status.
 903
 904 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
 905             Tom de Vries  <tdevries@suse.de>
 906
 907         PR symtab/25718
 908         * psympriv.h (struct partial_symtab::read_symtab)
 909         (struct partial_symtab::expand_psymtab)
 910         (struct partial_symtab::read_dependencies): Update comments.
 911         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
 912         read_symtab for includer.
 913         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
 914         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
 915         (struct dwarf2_include_psymtab::m_readin): Remove.
 916         (struct dwarf2_include_psymtab::includer): New member function.
 917         (dwarf2_psymtab::expand_psymtab): Assert !readin.
 918
 919 2020-04-14  Tom de Vries  <tdevries@suse.de>
 920
 921         PR symtab/25720
 922         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
 923         with NULL symbol_matcher and lookup_name.
 924         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
 925         and lookup_name.
 926         * dwarf2/read.c (dw2_expand_symtabs_matching)
 927         (dw2_debug_names_expand_symtabs_matching): Same.
 928         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
 929         Make lookup_name a pointer.  Update comment.
 930         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
 931         lookup_name being a pointer.
 932         * symfile.c (expand_symtabs_matching): Same.
 933         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
 934         * linespec.c (iterate_over_all_matching_symtabs): Same.
 935
 936 2020-04-13  Tom Tromey  <tom@tromey.com>
 937
 938         * run-on-main-thread.c: Update include.
 939         * unittests/main-thread-selftests.c: Update include.
 940         * tui/tui-win.c: Update include.
 941         * tui/tui-io.c: Update include.
 942         * tui/tui-interp.c: Update include.
 943         * tui/tui-hooks.c: Update include.
 944         * top.h: Update include.
 945         * top.c: Update include.
 946         * ser-base.c: Update include.
 947         * remote.c: Update include.
 948         * remote-notif.c: Update include.
 949         * remote-fileio.c: Update include.
 950         * record-full.c: Update include.
 951         * record-btrace.c: Update include.
 952         * python/python.c: Update include.
 953         * posix-hdep.c: Update include.
 954         * mingw-hdep.c: Update include.
 955         * mi/mi-main.c: Update include.
 956         * mi/mi-interp.c: Update include.
 957         * main.c: Update include.
 958         * linux-nat.c: Update include.
 959         * interps.c: Update include.
 960         * infrun.c: Update include.
 961         * inf-loop.c: Update include.
 962         * event-top.c: Update include.
 963         * event-loop.c: Move to ../gdbsupport/.
 964         * event-loop.h: Move to ../gdbsupport/.
 965         * async-event.h: Update include.
 966         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
 967
 968 2020-04-13  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-win.c: Include async-event.h.
 971         * remote.c: Include async-event.h.
 972         * remote-notif.c: Include async-event.h.
 973         * record-full.c: Include async-event.h.
 974         * record-btrace.c: Include async-event.h.
 975         * infrun.c: Include async-event.h.
 976         * event-top.c: Include async-event.h.
 977         * event-loop.h: Move some declarations to async-event.h.
 978         * event-loop.c: Don't include ser-event.h or top.h.  Move some
 979         code to async-event.c.
 980         * async-event.h: New file.
 981         * async-event.c: New file.
 982         * Makefile.in (COMMON_SFILES): Add async-event.c.
 983         (HFILES_NO_SRCDIR): Add async-event.h.
 984
 985 2020-04-13  Tom Tromey  <tom@tromey.com>
 986
 987         * utils.c (flush_streams): New function.
 988         * event-loop.c (gdb_wait_for_event): Call flush_streams.
 989
 990 2020-04-13  Tom Tromey  <tom@tromey.com>
 991
 992         * event-loop.c (handle_file_event): Use warning, not
 993         printf_unfiltered.
 994
 995 2020-04-13  Tom Tromey  <tom@tromey.com>
 996
 997         * event-loop.c: Include <chrono>.
 998
 999 2020-04-13  Tom Tromey  <tom@tromey.com>
1000
1001         * gdb_select.h: Move to ../gdbsupport/.
1002         * event-loop.c: Update include path.
1003         * top.c: Update include path.
1004         * ser-base.c: Update include path.
1005         * ui-file.c: Update include path.
1006         * ser-tcp.c: Update include path.
1007         * guile/scm-ports.c: Update include path.
1008         * posix-hdep.c: Update include path.
1009         * ser-unix.c: Update include path.
1010         * gdb_usleep.c: Update include path.
1011         * mingw-hdep.c: Update include path.
1012         * inflow.c: Update include path.
1013         * infrun.c: Update include path.
1014         * event-top.c: Update include path.
1015
1016 2020-04-13  Tom Tromey  <tom@tromey.com>
1017
1018         * configure: Rebuild.
1019         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
1020
1021 2020-04-13  Tom Tromey  <tom@tromey.com>
1022
1023         * event-loop.h (start_event_loop): Don't declare.
1024         * event-loop.c (start_event_loop): Move...
1025         * main.c (start_event_loop): ...here.  Now static.
1026
1027 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
1028
1029         * MAINTAINERS: Update my email address.
1030
1031 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1032
1033         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
1034         IP_ALL.
1035
1036 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1037
1038         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
1039         (nbsd_nat_target::info_proc): Add do_cmdline.
1040
1041 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1042
1043         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
1044         (nbsd_nat_target::info_proc): Add do_cwd.
1045
1046 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1047
1048         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
1049
1050 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
1051
1052         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
1053         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
1054         (nbsd_nat_target::info_proc): New functions.
1055         * nbsd-nat.c (kinfo_get_vmmap): New function.
1056         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
1057         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
1058         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
1059         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
1060         functions.
1061         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
1062         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
1063         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
1064         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
1065         (KINFO_VME_FLAG_GROWS_DOWN): New.
1066
1067 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
1068
1069         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
1070         bit shift.
1071
1072 2020-04-10  Tom Tromey  <tromey@adacore.com>
1073
1074         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
1075
1076 2020-04-10  Tom Tromey  <tromey@adacore.com>
1077
1078         * symtab.c (get_symbol_address, get_msymbol_address): Skip
1079         separate debug files.
1080
1081 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
1082
1083         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
1084         Move to...
1085         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
1086         ... here.
1087         * windows-nat.c (windows_nat_target::get_windows_debug_event):
1088         Check for STATUS_WX86_BREAKPOINT.
1089         (windows_nat_target::wait): Same.
1090
1091 2020-04-10  Tom de Vries  <tdevries@suse.de>
1092
1093         PR cli/25808
1094         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
1095
1096 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
1097
1098         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
1099         (Write After Approval): Remove Tom de Vries.
1100
1101 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1102
1103         revert partially:
1104         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1105
1106         * buildsym.c (record_line): Fix undefined behavior and preserve
1107         lines at eof.
1108
1109 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
1110
1111         * auxv.h (svr4_auxv_parse): New.
1112         * auxv.c (default_auxv_parse): Split into default_auxv_parse
1113         and generic_auxv_parse.
1114         (svr4_auxv_parse): Add.
1115         * obsd-tdep.c: Include "auxv.h".
1116         (obsd_auxv_parse): Remove.
1117         (obsd_init_abi): Remove comment.
1118         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
1119         from `obsd_auxv_parse' to `svr4_auxv_parse'.
1120         * nbsd-tdep.c: Include "auxv.h".
1121         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
1122
1123 2020-04-08  Tom Tromey  <tromey@adacore.com>
1124
1125         * nat/windows-nat.h (last_wait_event): Don't declare.
1126         (wait_for_debug_event): Update comment.
1127         * nat/windows-nat.c (last_wait_event): Now static.
1128
1129 2020-04-08  Tom Tromey  <tromey@adacore.com>
1130
1131         * windows-nat.c (wait_for_debug_event): Move to
1132         nat/windows-nat.c.
1133         * nat/windows-nat.h (wait_for_debug_event): Declare.
1134         * nat/windows-nat.c (wait_for_debug_event): Move from
1135         windows-nat.c.  No longer static.
1136
1137 2020-04-08  Tom Tromey  <tromey@adacore.com>
1138
1139         * windows-nat.c (get_windows_debug_event): Use
1140         fetch_pending_stop.
1141         * nat/windows-nat.h (fetch_pending_stop): Declare.
1142         * nat/windows-nat.c (fetch_pending_stop): New function.
1143
1144 2020-04-08  Tom Tromey  <tromey@adacore.com>
1145
1146         * windows-nat.c (windows_continue): Use matching_pending_stop and
1147         continue_last_debug_event.
1148         * nat/windows-nat.h (matching_pending_stop)
1149         (continue_last_debug_event): Declare.
1150         * nat/windows-nat.c (DEBUG_EVENTS): New define.
1151         (matching_pending_stop, continue_last_debug_event): New
1152         functions.
1153
1154 2020-04-08  Tom Tromey  <tromey@adacore.com>
1155
1156         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
1157         (handle_exception_result): Move to nat/windows-nat.h.
1158         (DEBUG_EXCEPTION_SIMPLE): Remove.
1159         (windows_nat::handle_ms_vc_exception): New function.
1160         (handle_exception): Move to nat/windows-nat.c.
1161         (get_windows_debug_event): Update.
1162         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
1163         nat/windows-nat.c.
1164         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
1165         (handle_exception_result): Move from windows-nat.c.
1166         (handle_exception): Declare.
1167         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
1168         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
1169         windows-nat.c.
1170
1171 2020-04-08  Tom Tromey  <tromey@adacore.com>
1172
1173         * windows-nat.c (exception_count, event_count): Remove.
1174         (handle_exception, get_windows_debug_event)
1175         (do_initial_windows_stuff): Update.
1176
1177 2020-04-08  Tom Tromey  <tromey@adacore.com>
1178
1179         * windows-nat.c (windows_nat::handle_load_dll)
1180         (windows_nat::handle_unload_dll): Rename.  No longer static.
1181         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
1182         Declare.
1183
1184 2020-04-08  Tom Tromey  <tromey@adacore.com>
1185
1186         * complaints.h (stop_whining): Declare at top-level.
1187         (complaint): Don't declare stop_whining.
1188
1189 2020-04-08  Tom Tromey  <tromey@adacore.com>
1190
1191         * windows-nat.c (windows_nat::handle_output_debug_string):
1192         Rename.  No longer static.
1193         * nat/windows-nat.h (handle_output_debug_string): Declare.
1194
1195 2020-04-08  Tom Tromey  <tromey@adacore.com>
1196
1197         * windows-nat.c (current_process_handle, current_process_id)
1198         (main_thread_id, last_sig, current_event, last_wait_event)
1199         (current_windows_thread, desired_stop_thread_id, pending_stops)
1200         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
1201         (display_selectors, fake_create_process)
1202         (get_windows_debug_event): Update.
1203         * nat/windows-nat.h (current_process_handle, current_process_id)
1204         (main_thread_id, last_sig, current_event, last_wait_event)
1205         (current_windows_thread, desired_stop_thread_id, pending_stops)
1206         (struct pending_stop, siginfo_er): Move from windows-nat.c.
1207         * nat/windows-nat.c (current_process_handle, current_process_id)
1208         (main_thread_id, last_sig, current_event, last_wait_event)
1209         (current_windows_thread, desired_stop_thread_id, pending_stops)
1210         (siginfo_er): New globals.  Move from windows-nat.c.
1211
1212 2020-04-08  Tom Tromey  <tromey@adacore.com>
1213
1214         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
1215         (handle_load_dll): Update.
1216         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
1217
1218 2020-04-08  Tom Tromey  <tromey@adacore.com>
1219
1220         * windows-nat.c (enum thread_disposition_type): Move to
1221         nat/windows-nat.h.
1222         (windows_nat::thread_rec): Rename from thread_rec.  No longer
1223         static.
1224         (windows_add_thread, windows_nat_target::fetch_registers)
1225         (windows_nat_target::store_registers, handle_exception)
1226         (windows_nat_target::resume, get_windows_debug_event)
1227         (windows_nat_target::get_tib_address)
1228         (windows_nat_target::thread_name)
1229         (windows_nat_target::thread_alive): Update.
1230         * nat/windows-nat.h (enum thread_disposition_type): Move from
1231         windows-nat.c.
1232         (thread_rec): Declare.
1233
1234 2020-04-08  Tom Tromey  <tromey@adacore.com>
1235
1236         * windows-nat.c: Add "using namespace".
1237         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
1238         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
1239
1240 2020-04-08  Tom Tromey  <tromey@adacore.com>
1241
1242         * nat/windows-nat.h (struct windows_thread_info): Declare
1243         destructor.
1244         * nat/windows-nat.c (~windows_thread_info): New.
1245
1246 2020-04-08  Tom Tromey  <tromey@adacore.com>
1247
1248         PR gdb/22992
1249         * windows-nat.c (current_event): Update comment.
1250         (last_wait_event, desired_stop_thread_id): New globals.
1251         (struct pending_stop): New.
1252         (pending_stops): New global.
1253         (windows_nat_target) <stopped_by_sw_breakpoint>
1254         <supports_stopped_by_sw_breakpoint>: New methods.
1255         (windows_fetch_one_register): Add assertions.  Adjust PC.
1256         (windows_continue): Handle pending stops.  Suspend other threads
1257         when stepping.  Use last_wait_event
1258         (wait_for_debug_event): New function.
1259         (get_windows_debug_event): Use wait_for_debug_event.  Handle
1260         pending stops.  Queue spurious stops.
1261         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
1262         (windows_nat_target::kill): Use wait_for_debug_event.
1263         * nat/windows-nat.h (struct windows_thread_info)
1264         <stopped_at_software_breakpoint>: New field.
1265         * nat/windows-nat.c (windows_thread_info::resume): Clear
1266         stopped_at_software_breakpoint.
1267
1268 2020-04-08  Tom Tromey  <tromey@adacore.com>
1269
1270         * windows-nat.c (enum thread_disposition_type): New.
1271         (thread_rec): Replace "get_context" parameter with "disposition";
1272         change type.
1273         (windows_add_thread, windows_nat_target::fetch_registers)
1274         (windows_nat_target::store_registers, handle_exception)
1275         (windows_nat_target::resume, get_windows_debug_event)
1276         (windows_nat_target::get_tib_address)
1277         (windows_nat_target::thread_name)
1278         (windows_nat_target::thread_alive): Update.
1279
1280 2020-04-08  Tom Tromey  <tromey@adacore.com>
1281
1282         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
1283         (windows_continue): Use windows_continue::resume.
1284         * nat/windows-nat.h (struct windows_thread_info) <suspend,
1285         resume>: Declare new methods.
1286         * nat/windows-nat.c: New file.
1287         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
1288
1289 2020-04-08  Tom Tromey  <tromey@adacore.com>
1290
1291         * windows-nat.c (windows_add_thread, windows_delete_thread)
1292         (windows_nat_target::fetch_registers)
1293         (windows_nat_target::store_registers, fake_create_process)
1294         (windows_nat_target::resume, windows_nat_target::resume)
1295         (get_windows_debug_event, windows_nat_target::wait)
1296         (windows_nat_target::pid_to_str)
1297         (windows_nat_target::get_tib_address)
1298         (windows_nat_target::get_ada_task_ptid)
1299         (windows_nat_target::thread_name)
1300         (windows_nat_target::thread_alive): Use lwp, not tid.
1301
1302 2020-04-08  Tom Tromey  <tromey@adacore.com>
1303
1304         * windows-nat.c (handle_exception)
1305         (windows_nat_target::thread_name): Update.
1306         * nat/windows-nat.h (windows_thread_info): Remove destructor.
1307         <name>: Now unique_xmalloc_ptr.
1308
1309 2020-04-08  Tom Tromey  <tromey@adacore.com>
1310
1311         * windows-nat.c (thread_rec)
1312         (windows_nat_target::fetch_registers): Update.
1313         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
1314         Update comment.
1315         <debug_registers_changed, reload_context>: Now bool.
1316
1317 2020-04-08  Tom Tromey  <tromey@adacore.com>
1318
1319         * windows-nat.c (windows_add_thread): Use new.
1320         (windows_init_thread_list, windows_delete_thread): Use delete.
1321         (get_windows_debug_event): Update.
1322         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
1323         destructor, and initializers.
1324
1325 2020-04-08  Tom Tromey  <tromey@adacore.com>
1326
1327         * windows-nat.c (struct windows_thread_info): Remove.
1328         * nat/windows-nat.h: New file.
1329
1330 2020-04-08  Tom Tromey  <tromey@adacore.com>
1331
1332         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
1333         (thread_rec, windows_add_thread, windows_delete_thread)
1334         (windows_continue): Update.
1335
1336 2020-04-08  Tom Tromey  <tromey@adacore.com>
1337
1338         * windows-nat.c (struct windows_thread_info): Remove typedef.
1339         (thread_head): Remove.
1340         (thread_list): New global.
1341         (thread_rec, windows_add_thread, windows_init_thread_list)
1342         (windows_delete_thread, windows_continue): Update.
1343
1344 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1345
1346         * windows-tdep.h (windows_init_abi): Add comment.
1347         (cygwin_init_abi): New declaration.
1348         * windows-tdep.c: Split signal enumeration in two, one for
1349         Windows and one for Cygwin.
1350         (windows_gdb_signal_to_target): Only deal with signal of the
1351         Windows OS ABI.
1352         (cygwin_gdb_signal_to_target): New function.
1353         (windows_init_abi): Rename to windows_init_abi_common, don't set
1354         gdb_signal_to_target gdbarch method.  Add new new function with
1355         this name.
1356         (cygwin_init_abi): New function.
1357         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
1358         comment.  Don't call windows_init_abi.
1359         (amd64_windows_init_abi): Add comment, call windows_init_abi.
1360         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
1361         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
1362         i386_windows_init_abi_common, don't call windows_init_abi.  Add
1363         a new function of this name.
1364         (i386_cygwin_init_abi): New function.
1365         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
1366         OS ABI Cygwin.
1367
1368 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1369
1370         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
1371         parameter.c.
1372         (dwarf2_read_gdb_index): Update.
1373
1374 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
1375
1376         * nbsd-tdep.c: Include "objfiles.h".
1377         (nbsd_skip_solib_resolver): New.
1378         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
1379
1380 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1381
1382         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
1383         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
1384         with DW_LLE_base_addressx are being emitted in DWARFv5.
1385         Add the newly added kind DW_LOC_OFFSET_PAIR also.
1386         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
1387         unsigned integer.
1388
1389 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1390
1391         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
1392         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
1393         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
1394         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
1395         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
1396         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
1397         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
1398
1399
1400 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1401
1402         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
1403         (read_loclist_index): New function definition.
1404         (lookup_loclist_base): New function definition.
1405         (read_loclist_header): New function definition.
1406         (dwarf2_cu): Add loclist_base and loclist_header field.
1407         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
1408         (read_full_die_1): Read the value of DW_AT_loclists_base.
1409         (read_attribute_reprocess): Handle DW_FORM_loclistx.
1410         (read_attribute_value): Handle DW_FORM_loclistx.
1411         (skip_one_die): Handle DW_FORM_loclistx.
1412         (loclist_header): New structure declaration.
1413         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
1414
1415 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
1416
1417         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
1418         constructor.  Remove `addr` parameter from other constructor and
1419         add `per_cu` parameter.
1420         * dwarf2/read.c (create_partial_symtab): Update.
1421
1422 2020-04-07  Tom de Vries  <tdevries@suse.de>
1423
1424         PR symtab/25796
1425         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
1426         (partial_die_info::fixup): Inherit has_const_value.
1427
1428 2020-04-07  Tom de Vries  <tdevries@suse.de>
1429
1430         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
1431         symbols without address.
1432
1433 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1434
1435         * nbsd-nat.h (struct thread_info): Add forward declaration.
1436         (nbsd_nat_target::thread_alive): Add.
1437         (nbsd_nat_target::thread_name): Likewise.
1438         (nbsd_nat_target::update_thread_list): Likewise.
1439         (update_thread_list::post_attach): Likewise.
1440         (post_attach::pid_to_str): Likewise.
1441         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
1442         (nbsd_thread_lister): Add.
1443         (nbsd_nat_target::thread_alive): Likewise.
1444         (nbsd_nat_target::thread_name): Likewise.
1445         (nbsd_add_threads): Likewise.
1446         (update_thread_list::post_attach): Likewise.
1447         (nbsd_nat_target::update_thread_list): Likewise.
1448         (post_attach::pid_to_str): Likewise.
1449
1450 2020-04-06  Tom Tromey  <tromey@adacore.com>
1451
1452         * ada-valprint.c (print_variant_part): Extract the variant field.
1453         (print_field_values): Use the field as the outer value when
1454         recursing.
1455
1456 2020-04-06  Tom Tromey  <tromey@adacore.com>
1457
1458         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
1459         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
1460         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
1461         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
1462         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
1463
1464 2020-04-06  Tom Tromey  <tromey@adacore.com>
1465
1466         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
1467         TYPE_CODE_ERROR.
1468
1469 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1470
1471         * nbsd-tdep.c: Include "gdbarch.h".
1472         Define enum with NetBSD signal numbers.
1473         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
1474         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
1475         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
1476         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
1477         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
1478         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
1479         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
1480         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
1481         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
1482         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
1483         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
1484         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
1485
1486 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
1487
1488         PR gdb/25325
1489         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
1490
1491 2020-04-03  Tom Tromey  <tromey@adacore.com>
1492
1493         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
1494         Read constant block.
1495
1496 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
1497
1498         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
1499         (gdb_bfd_get_full_section_contents): New declaration.
1500         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
1501         * windows-tdep.c (is_linked_with_cygwin_dll): Use
1502         gdb_bfd_get_full_section_contents.
1503
1504 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
1505
1506         * exec.c (build_section_table): Replace internal_error with
1507         gdb_assert.
1508         (section_table_xfer_memory_partial): Likewise.
1509         * mdebugread.c (parse_partial_symbols): Likewise.
1510         * psymtab.c (lookup_partial_symbol): Likewise.
1511         * utils.c (wrap_here): Likewise.
1512
1513 2020-04-02  Tom Tromey  <tromey@adacore.com>
1514
1515         * f-lang.c (build_fortran_types): Use arch_type to initialize
1516         builtin_complex_s32 in the TYPE_CODE_ERROR case.
1517
1518 2020-04-02  Tom Tromey  <tromey@adacore.com>
1519
1520         * dwarf2/read.c (partial_die_info::read): Do not create a vector
1521         of attributes.
1522
1523 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1524             Bernd Edlinger <bernd.edlinger@hotmail.de>
1525             Tom Tromey  <tromey@adacore.com>
1526
1527         * buildsym.c (buildsym_compunit::record_line): Remove
1528         deduplication code.
1529
1530 2020-04-02  Tom de Vries  <tdevries@suse.de>
1531
1532         PR ada/24671
1533         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
1534
1535 2020-04-02  Tom de Vries  <tdevries@suse.de>
1536
1537         * dwarf2/read.c (dwarf2_gdb_index_functions,
1538         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
1539         NULL.
1540         * psymtab.c (psym_lookup_global_symbol_language): New function.
1541         (psym_functions): Init psym_lookup_global_symbol_language with
1542         psym_lookup_global_symbol_language.
1543         * symfile-debug.c (debug_sym_quick_functions): Init
1544         lookup_global_symbol_language with NULL.
1545         * symfile.c (set_initial_language): Remove fixme comment.
1546         * symfile.h (struct quick_symbol_functions): Add
1547         lookup_global_symbol_language.
1548         * symtab.c (find_quick_global_symbol_language): New function.
1549         (find_main_name): Use find_quick_global_symbol_language.
1550
1551 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
1552
1553         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
1554
1555 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1556
1557         * buildsym.c (record_line): Fix undefined behavior and preserve
1558         lines at eof.
1559
1560 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1561
1562         * buildsym.c (record_line): Fix the resizing condition.
1563
1564 2020-04-01  Tom Tromey  <tom@tromey.com>
1565
1566         * value.h (value_literal_complex): Add comment.
1567         * valops.c (value_literal_complex): Refer to value.h.
1568
1569 2020-04-01  Tom Tromey  <tom@tromey.com>
1570
1571         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
1572         (scalar_type): New rule, from typebase.
1573         (typebase): Use scalar_type.  Recognize complex types.
1574         (field_name): Handle FLOAT_KEYWORD.
1575         (ident_tokens): Add _Complex and __complex__.
1576
1577 2020-04-01  Tom Tromey  <tom@tromey.com>
1578
1579         PR exp/25299:
1580         * valarith.c (promotion_type, complex_binop): New functions.
1581         (scalar_binop): Handle complex numbers.  Use promotion_type.
1582         (value_pos, value_neg, value_complement): Handle complex numbers.
1583
1584 2020-04-01  Tom Tromey  <tom@tromey.com>
1585
1586         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
1587         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
1588         (parse_number): Handle complex numbers.
1589
1590 2020-04-01  Tom Tromey  <tom@tromey.com>
1591
1592         * c-valprint.c (c_decorations): Change complex suffix to "i".
1593
1594 2020-04-01  Tom Tromey  <tom@tromey.com>
1595
1596         * valprint.c (generic_value_print_complex): Use accessors.
1597         * value.h (value_real_part, value_imaginary_part): Declare.
1598         * valops.c (value_real_part, value_imaginary_part): New
1599         functions.
1600         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
1601
1602 2020-04-01  Tom Tromey  <tom@tromey.com>
1603
1604         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
1605         (read_range_type): Update.
1606         * mdebugread.c (basic_type): Update.
1607         * go-lang.c (build_go_types): Use init_complex_type.
1608         * gdbtypes.h (struct main_type) <complex_type>: New member.
1609         (init_complex_type): Update.
1610         (arch_complex_type): Don't declare.
1611         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
1612         Make name if none given.  Use alloc_type_copy.  Look for cached
1613         complex type.
1614         (arch_complex_type): Remove.
1615         (gdbtypes_post_init): Use init_complex_type.
1616         * f-lang.c (build_fortran_types): Use init_complex_type.
1617         * dwarf2/read.c (read_base_type): Update.
1618         * d-lang.c (build_d_types): Use init_complex_type.
1619         * ctfread.c (read_base_type): Update.
1620
1621 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1622
1623         * infrun.c (stop_all_threads): Update assertion, plus when
1624         stopping threads, take into account that we might be trying
1625         to stop an all-stop target.
1626         (stop_waiting): Call 'stop_all_threads' if there exists a
1627         non-stop target.
1628
1629 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1630
1631         * target.h (exists_non_stop_target): New function declaration.
1632         * target.c (exists_non_stop_target): New function.
1633
1634 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
1635
1636         PR gdb/24789
1637         * eval.c (is_integral_or_integral_reference): New function.
1638         (evaluate_subexp_standard): Allow integer references in
1639         pointer arithmetic.
1640
1641 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1642
1643         * remote.c (remote_target::remote_parse_stop_reply): Remove the
1644         check for no ptid in the stop reply when the target is non-stop.
1645
1646 2020-04-01  Tom Tromey  <tromey@adacore.com>
1647
1648         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
1649         "name" parameter to rvalue reference.  Initialize m_name_holder.
1650         <lookup_name_info>: New overloads.
1651         <name>: Return gdb::string_view.
1652         <c_str>: New method.
1653         <make_ignore_params>: Update.
1654         <search_name_hash>: Update.
1655         <language_lookup_name>: Return const char *.
1656         <m_name>: Change type.
1657         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
1658         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
1659         (lookup_name_info::match_any): Update.
1660         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
1661         Update.
1662         * minsyms.c (linkage_name_str): Update.
1663         * language.c (default_symbol_name_matcher): Update.
1664         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
1665         Update.
1666         * ada-lang.c (ada_fold_name): Change parameter to string_view.
1667         (ada_lookup_name_info::ada_lookup_name_info): Update.
1668         (literal_symbol_name_matcher): Update.
1669
1670 2020-04-01  Tom Tromey  <tromey@adacore.com>
1671
1672         * psymtab.c (psymtab_search_name): Remove function.
1673         (psym_lookup_symbol): Create search name and lookup name here.
1674         (lookup_partial_symbol): Remove "name" parameter; add
1675         lookup_name.
1676         (psym_expand_symtabs_for_function): Update.
1677
1678 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
1679
1680         PR tui/25597:
1681         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
1682
1683 2020-03-31  Tom Tromey  <tromey@adacore.com>
1684
1685         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
1686         memcpy.
1687
1688 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
1689
1690         * features/riscv/32bit-csr.xml: Regenerated.
1691         * features/riscv/64bit-csr.xml: Regenerated.
1692
1693 2020-03-30  Tom Tromey  <tromey@adacore.com>
1694
1695         * ada-valprint.c (print_variant_part): Update.
1696         * ada-lang.h (ada_which_variant_applies): Update.
1697         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
1698         outer_valaddr parameters; replace with "outer" value parameter.
1699         (to_fixed_variant_branch_type): Update.
1700
1701 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1702
1703         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
1704         <list>.  Remove inclusion of observable.h.
1705         (PPC_DEBUG_CURRENT_VERSION): Move up define.
1706         (struct arch_lwp_info): New struct.
1707         (class ppc_linux_dreg_interface): New class.
1708         (struct ppc_linux_process_info): New struct.
1709         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
1710         <low_new_clone, low_forget_process, low_prepare_to_resume>
1711         <copy_thread_dreg_state, mark_thread_stale>
1712         <mark_debug_registers_changed, register_hw_breakpoint>
1713         <clear_hw_breakpoint, register_wp, clear_wp>
1714         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
1715         <num_memory_accesses, get_trigger_type>
1716         <create_watchpoint_request, hwdebug_point_cmp>
1717         <init_arch_lwp_info, get_arch_lwp_info>
1718         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
1719         methods.
1720         <struct ptid_hash>: New inner struct.
1721         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
1722         members.
1723         (saved_dabr_value, hwdebug_info, max_slots_number)
1724         (struct hw_break_tuple, struct thread_points, ppc_threads)
1725         (have_ptrace_hwdebug_interface)
1726         (hwdebug_find_thread_points_by_tid)
1727         (hwdebug_insert_point, hwdebug_remove_point): Remove.
1728         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
1729         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
1730         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
1731         use m_dreg_interface.
1732         (hwdebug_point_cmp): Change to...
1733         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
1734         reference arguments instead of pointers.
1735         (ppc_linux_nat_target::ranged_break_num_registers): Use
1736         m_dreg_interface.
1737         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
1738         m_dreg_interface.  Call register_hw_breakpoint.
1739         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
1740         m_dreg_interface.  Call clear_hw_breakpoint.
1741         (get_trigger_type): Change to...
1742         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
1743         comment.
1744         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
1745         use m_dreg_interface.  Call register_hw_breakpoint.
1746         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
1747         use m_dreg_interface.  Call clear_hw_breakpoint.
1748         (can_use_watchpoint_cond_accel): Change to...
1749         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
1750         method.  Update comment, use m_dreg_interface and
1751         m_process_info.
1752         (calculate_dvc): Change to...
1753         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
1754         m_dreg_interface.
1755         (num_memory_accesses): Change to...
1756         (ppc_linux_nat_target::num_memory_accesses): ...this method.
1757         (check_condition): Change to...
1758         (ppc_linux_nat_target::check_condition): ...this method.
1759         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
1760         comment, use m_dreg_interface.
1761         (create_watchpoint_request): Change to...
1762         (ppc_linux_nat_target::create_watchpoint_request): ...this
1763         method.  Use m_dreg_interface.
1764         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
1765         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
1766         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
1767         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
1768         (ppc_linux_nat_target::low_forget_process)
1769         (ppc_linux_nat_target::low_new_fork)
1770         (ppc_linux_nat_target::low_new_clone)
1771         (ppc_linux_nat_target::low_delete_thread)
1772         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
1773         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
1774         only call mark_thread_stale.
1775         (ppc_linux_thread_exit): Remove.
1776         (ppc_linux_nat_target::stopped_data_address): Change to...
1777         (ppc_linux_nat_target::low_stopped_data_address): This. Add
1778         comment, use m_dreg_interface and m_thread_hw_breakpoints.
1779         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
1780         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
1781         comment.  Call low_stopped_data_address.
1782         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
1783         m_dreg_interface.
1784         (ppc_linux_nat_target::masked_watch_num_registers): Use
1785         m_dreg_interface.
1786         (ppc_linux_nat_target::copy_thread_dreg_state)
1787         (ppc_linux_nat_target::mark_thread_stale)
1788         (ppc_linux_nat_target::mark_debug_registers_changed)
1789         (ppc_linux_nat_target::register_hw_breakpoint)
1790         (ppc_linux_nat_target::clear_hw_breakpoint)
1791         (ppc_linux_nat_target::register_wp)
1792         (ppc_linux_nat_target::clear_wp)
1793         (ppc_linux_nat_target::init_arch_lwp_info)
1794         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
1795         (_initialize_ppc_linux_nat): Remove observer callback.
1796
1797 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1798
1799         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
1800         (ppc_linux_nat_target::auxv_parse)
1801         (ppc_linux_nat_target::read_description)
1802         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
1803         Move up.
1804
1805 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1806
1807         * linux-nat.h (low_new_clone): New method.
1808         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
1809
1810 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1811
1812         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
1813         (dbx_expand_psymtab): ... this.
1814         (start_psymtab): Update.
1815         * mdebugread.c (psymtab_to_symtab_1): Rename to...
1816         (mdebug_expand_psymtab): ... this.
1817         (parse_partial_symbols): Update.
1818         (new_psymtab): Update.
1819         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
1820         (xcoff_expand_psymtab): ... this.
1821         (xcoff_start_psymtab): Update.
1822
1823 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1824
1825         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
1826         <expand_dependencies>: ... this.
1827         * psymtab.c (partial_symtab::read_dependencies): Rename to...
1828         (partial_symtab::expand_dependencies): ... this.
1829         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
1830         Update.
1831         (dwarf2_psymtab::expand_psymtab): Update.
1832         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
1833         * mdebugread.c (psymtab_to_symtab_1): Update.
1834         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
1835
1836 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1837
1838         * psympriv.h (discard_psymtab): Remove.
1839         * dbxread.c (dbx_end_psymtab): Update.
1840         * xcoffread.c (xcoff_end_psymtab): Update.
1841
1842 2020-03-28  Tom Tromey  <tom@tromey.com>
1843
1844         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
1845         comment.
1846
1847 2020-03-28  Tom Tromey  <tom@tromey.com>
1848
1849         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
1850
1851 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
1852
1853         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
1854
1855 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
1856
1857         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
1858
1859 2020-03-26  Tom Tromey  <tom@tromey.com>
1860
1861         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
1862         (mark_common_block_symbol_computed, read_tag_string_type)
1863         (attr_to_dynamic_prop, read_subrange_type): Update.
1864         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
1865         to be methods on struct attribute.
1866         (skip_one_die, process_imported_unit_die, read_namespace_alias)
1867         (read_call_site_scope, partial_die_info::read)
1868         (partial_die_info::read, lookup_die_type, follow_die_ref):
1869         Update.
1870         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
1871         from dwarf2_get_ref_die_offset.
1872         (attribute::constant_value): New method, from
1873         dwarf2_get_attr_constant_value.
1874         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
1875         Declare method.
1876         <constant_value>: New method.
1877
1878 2020-03-26  Tom Tromey  <tom@tromey.com>
1879
1880         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
1881         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
1882         (dwarf_type_encoding_name): Move to stringify.c.
1883         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
1884         * dwarf2/stringify.c: New file.
1885         * dwarf2/stringify.h: New file.
1886
1887 2020-03-26  Tom Tromey  <tom@tromey.com>
1888
1889         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
1890         Rewrite.
1891
1892 2020-03-26  Tom Tromey  <tom@tromey.com>
1893
1894         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
1895         methods.
1896         * dwarf2/read.c (lookup_addr_base): Move to die.h.
1897         (lookup_ranges_base): Likewise.
1898         (read_cutu_die_from_dwo, read_full_die_1): Update.
1899
1900 2020-03-26  Tom Tromey  <tom@tromey.com>
1901
1902         * dwarf2/read.c (read_import_statement, read_file_scope)
1903         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
1904         (read_lexical_block_scope, read_call_site_scope)
1905         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
1906         (handle_struct_member_die, process_structure_scope)
1907         (update_enumeration_type_from_children)
1908         (process_enumeration_scope, read_array_type, read_common_block)
1909         (read_namespace, read_module, read_subroutine_type): Update.
1910         (sibling_die): Remove.
1911
1912 2020-03-26  Tom Tromey  <tom@tromey.com>
1913
1914         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
1915         (build_type_psymtabs_reader, read_structure_type)
1916         (read_enumeration_type, read_full_die_1): Update.
1917         (dwarf2_attr_no_follow): Move to die.h.
1918         * dwarf2/die.h (struct die_info) <attr>: New method.
1919
1920 2020-03-26  Tom Tromey  <tom@tromey.com>
1921
1922         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
1923         <base_address>: Now an optional.
1924         (dwarf2_find_base_address, dwarf2_rnglists_process)
1925         (dwarf2_ranges_process, fill_in_loclist_baton)
1926         (dwarf2_symbol_mark_computed): Update.
1927
1928 2020-03-26  Tom Tromey  <tom@tromey.com>
1929
1930         * dwarf2/read.c (struct die_info): Move to die.h.
1931         * dwarf2/die.h: New file.
1932
1933 2020-03-26  Tom Tromey  <tom@tromey.com>
1934
1935         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
1936         * dwarf2/read.c
1937         (dwarf2_statement_list_fits_in_line_number_section_complaint):
1938         Move to line-header.c.
1939         (read_checked_initial_length_and_offset, read_formatted_entries):
1940         Likewise.
1941         (dwarf_decode_line_header): Split into two.
1942         * dwarf2/line-header.c
1943         (dwarf2_statement_list_fits_in_line_number_section_complaint):
1944         Move from read.c.
1945         (read_checked_initial_length_and_offset, read_formatted_entries):
1946         Likewise.
1947         (dwarf_decode_line_header): New function, split from read.c.
1948
1949 2020-03-26  Tom Tromey  <tom@tromey.com>
1950
1951         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
1952         Declare method.
1953         * dwarf2/read.c (read_attribute_value): Update.
1954         (dwarf2_per_objfile::read_line_string): Rename from
1955         read_indirect_line_string.
1956         (read_formatted_entries): Update.
1957
1958 2020-03-26  Tom Tromey  <tom@tromey.com>
1959
1960         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
1961         variable.
1962
1963 2020-03-26  Tom Tromey  <tom@tromey.com>
1964
1965         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
1966         const.
1967         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
1968         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
1969         parameter const.
1970
1971 2020-03-26  Tom Tromey  <tom@tromey.com>
1972
1973         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
1974         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
1975         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
1976         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
1977
1978 2020-03-26  Tom Tromey  <tom@tromey.com>
1979
1980         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
1981         file_names_size, file_full_name, file_file_name>: Use const.
1982         <file_name_at, file_names>: Add const overload.
1983         * dwarf2/line-header.c (line_header::file_file_name)
1984         (line_header::file_full_name): Update.
1985
1986 2020-03-26  Tom Tromey  <tom@tromey.com>
1987
1988         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
1989         (macro_start_file, consume_improper_spaces)
1990         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
1991         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
1992         (dwarf_decode_macros): Move to macro.c.
1993         * dwarf2/macro.c: New file.
1994         * dwarf2/macro.h: New file.
1995         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
1996
1997 2020-03-26  Tom Tromey  <tom@tromey.com>
1998
1999         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
2000         method.
2001         * dwarf2/section.c: New method.  From
2002         read_indirect_string_at_offset_from.
2003         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
2004         (read_indirect_string_at_offset_from): Move to section.c.
2005         (read_indirect_string_at_offset): Rewrite.
2006         (read_indirect_line_string_at_offset): Remove.
2007         (read_indirect_string, read_indirect_line_string)
2008         (dwarf_decode_macro_bytes): Update.
2009
2010 2020-03-26  Tom Tromey  <tom@tromey.com>
2011
2012         * dwarf2/section.h (struct dwarf2_section_info)
2013         <overload_complaint>: Declare.
2014         (dwarf2_section_buffer_overflow_complaint): Don't declare.
2015         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
2016         Rename from dwarf2_section_buffer_overflow_complaint.
2017         * dwarf2/read.c (skip_one_die, partial_die_info::read)
2018         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
2019
2020 2020-03-26  Tom Tromey  <tom@tromey.com>
2021
2022         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
2023         Declare.
2024         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
2025         Move from read.c.
2026         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
2027         to section.c.
2028
2029 2020-03-26  Tom Tromey  <tom@tromey.com>
2030
2031         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
2032
2033 2020-03-26  Tom Tromey  <tom@tromey.com>
2034
2035         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
2036         "builder".
2037         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
2038         parameter.
2039         (dwarf_decode_macros): Update.
2040
2041 2020-03-26  Tom Tromey  <tom@tromey.com>
2042
2043         * dwarf2/read.c (read_attribute_value): Update.
2044         (read_indirect_string_from_dwz): Move to dwz.c; change into
2045         method.
2046         (dwarf_decode_macro_bytes): Update.
2047         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
2048         * dwarf2/dwz.c: New file.
2049         * Makefile.in (COMMON_SFILES): Add dwz.c.
2050
2051 2020-03-26  Tom Tromey  <tom@tromey.com>
2052
2053         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
2054         * dwarf2/read.c: Add include.
2055         * dwarf2/index-write.c: Add include.
2056         * dwarf2/index-cache.c: Add include.
2057         * dwarf2/dwz.h: New file.
2058
2059 2020-03-25  Tom Tromey  <tom@tromey.com>
2060
2061         * compile/compile-object-load.c (get_out_value_type): Mention
2062         correct symbol name in error message.
2063
2064 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
2065
2066         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
2067
2068 2020-03-25  Tom de Vries  <tdevries@suse.de>
2069
2070         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
2071         * symmisc.c (dump_symtab_1): Print user and includes fields.
2072         (maintenance_info_symtabs): Same.
2073
2074 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2075
2076         PR gdb/25534
2077         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
2078         (riscv_regcache_cooked_write): New function.
2079         (riscv_push_dummy_call): Use new function.
2080         (riscv_return_value): Likewise.
2081
2082 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
2083
2084         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
2085         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
2086         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
2087         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
2088         * infrun.c (follow_fork): Likewise.
2089         (follow_fork_inferior): Likewise.
2090         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
2091         * linux-nat.h (class linux_nat_target): Likewise.
2092         * remote.c (class remote_target) <follow_fork>: Likewise.
2093         (remote_target::follow_fork): Likewise.
2094         * target-delegates.c: Re-generate.
2095         * target.c (default_follow_fork): Likewise.
2096         (target_follow_fork): Likewise.
2097         * target.h (struct target_ops) <follow_fork>: Likewise.
2098         (target_follow_fork): Likewise.
2099
2100 2020-03-24  Tom de Vries  <tdevries@suse.de>
2101
2102         * psymtab.c (maintenance_info_psymtabs): Print user field.
2103
2104 2020-03-20  Tom Tromey  <tromey@adacore.com>
2105
2106         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
2107         const.
2108         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
2109         const.
2110
2111 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
2112
2113         * ptrace.m4: Don't check for ptrace declaration.
2114         * config.in: Re-generate.
2115         * configure: Re-generate.
2116         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
2117         not defined.
2118
2119 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2120
2121         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
2122         `PTRACE_TYPE_RET'.
2123         * i386-bsd-nat.c (gdb_ptrace): Likewise.
2124         * sparc-nat.c (gdb_ptrace): Likewise.
2125         * x86-bsd-nat.c (gdb_ptrace): Likewise.
2126
2127 2020-03-20  Tom Tromey  <tromey@adacore.com>
2128
2129         * c-exp.y (lex_one_token): Fix assert.
2130
2131 2020-03-20  Tom Tromey  <tromey@adacore.com>
2132
2133         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
2134         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
2135         strncpy call.
2136
2137 2020-03-20  Tom Tromey  <tromey@adacore.com>
2138
2139         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
2140
2141 2020-03-20  Tom Tromey  <tromey@adacore.com>
2142
2143         * ada-valprint.c (print_variant_part): Remove parameters; switch
2144         to value-based API.
2145         (print_field_values): Likewise.
2146         (ada_val_print_struct_union): Likewise.
2147         (ada_value_print_1): Update.
2148
2149 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2150
2151         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
2152         nbsd_nat_target instead of inf_ptrace_target.
2153         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2154         nbsd_nat_target.
2155
2156 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2157
2158         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
2159         it to the ptrace call.
2160         * (store_registers): Likewise.
2161
2162 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2163
2164         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
2165         it to the ptrace call.
2166         * (store_registers): Likewise.
2167
2168 2020-03-19  Luis Machado  <luis.machado@linaro.org>
2169
2170         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
2171         valid, fetch vg value from ptrace.
2172
2173 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2174         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
2175         * inf-ptrace.c: Likewise.
2176         * (gdb_ptrace): Add.
2177         * (inf_ptrace_target::resume): Update.
2178         * (inf_ptrace_target::xfer_partial): Likewise.
2179         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
2180         * (inf_ptrace_peek_poke): Update.
2181
2182 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2183
2184         * x86-bsd-nat.c (gdb_ptrace): New.
2185         * (x86bsd_dr_set): Add new argument `ptid'.
2186         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
2187         x86bsd_dr_set_addr): Update.
2188
2189 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2190
2191         * remote.c (remote_target::process_stop_reply): Handle events for
2192         all threads differently.
2193
2194 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2195
2196         * completer.c (completion_tracker::remove_completion): Define new
2197         function.
2198         * completer.h (completion_tracker::remove_completion): Declare new
2199         function.
2200         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
2201         when adding a C++ function symbol.
2202
2203 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2204
2205         * completer.c (completion_tracker::completion_hash_entry): Define
2206         new class.
2207         (advance_to_filename_complete_word_point): Call
2208         recompute_lowest_common_denominator.
2209         (completion_tracker::completion_tracker): Call discard_completions
2210         to setup the hash table.
2211         (completion_tracker::discard_completions): Allow for being called
2212         from the constructor, pass new equal function, and element deleter
2213         when constructing the hash table.  Initialise new class member
2214         variables.
2215         (completion_tracker::maybe_add_completion): Remove use of
2216         m_entries_vec, and store more information into m_entries_hash.
2217         (completion_tracker::recompute_lcd_visitor): New function, most
2218         content taken from...
2219         (completion_tracker::recompute_lowest_common_denominator):
2220         ...here, this now just visits each item in the hash calling the
2221         above visitor.
2222         (completion_tracker::build_completion_result): Remove use of
2223         m_entries_vec, call recompute_lowest_common_denominator.
2224         * completer.h (completion_tracker::have_completions): Remove use
2225         of m_entries_vec.
2226         (completion_tracker::completion_hash_entry): Declare new class.
2227         (completion_tracker::recompute_lowest_common_denominator): Change
2228         function signature.
2229         (completion_tracker::recompute_lcd_visitor): Declare new function.
2230         (completion_tracker::m_entries_vec): Delete.
2231         (completion_tracker::m_entries_hash): Initialize to NULL.
2232         (completion_tracker::m_lowest_common_denominator_valid): New
2233         member variable.
2234         (completion_tracker::m_lowest_common_denominator_max_length): New
2235         member variable.
2236
2237 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2238
2239         * regformats/regdef.h: Put reg in gdb namespace.
2240
2241 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2242
2243         * i386-bsd-nat.c (gdb_ptrace): New.
2244         * (i386bsd_fetch_inferior_registers,
2245         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2246         * (i386bsd_fetch_inferior_registers,
2247         i386bsd_store_inferior_registers) Use gdb_ptrace.
2248
2249 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2250
2251         * amd64-bsd-nat.c (gdb_ptrace): New.
2252         * (amd64bsd_fetch_inferior_registers,
2253         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2254         * (amd64bsd_fetch_inferior_registers,
2255         amd64bsd_store_inferior_registers) Use gdb_ptrace.
2256
2257 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2258
2259         * user-regs.c (user_reg::read): Rename to...
2260         (user_reg::xread): ...this.
2261         * (append_user_reg): Rename argument `read' to `xread'.
2262         * (user_reg_add_builtin): Likewise.
2263         * (user_reg_add): Likewise.
2264         * (value_of_user_reg): Likewise.
2265
2266 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2267
2268         * sparc-nat.c (gdb_ptrace): New.
2269         * sparc-nat.c (sparc_fetch_inferior_registers)
2270         (sparc_store_inferior_registers) Remove obsolete comment.
2271         * sparc-nat.c (sparc_fetch_inferior_registers)
2272         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
2273         * sparc-nat.c (sparc_fetch_inferior_registers)
2274         (sparc_store_inferior_registers) Use gdb_ptrace.
2275
2276 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2277
2278         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
2279         it to the ptrace call.
2280         * sh-nbsd-nat.c (store_registers): Likewise.
2281
2282 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2283
2284         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
2285         nbsd_nat_target instead of inf_ptrace_target.
2286         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2287         nbsd_nat_target.
2288
2289 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2290
2291         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
2292
2293 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2294
2295         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
2296         <sys/sysctl.h>.
2297         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
2298
2299 2020-03-17  Tom de Vries  <tdevries@suse.de>
2300
2301         PR gdb/23710
2302         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
2303         fields.
2304         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
2305         fields.
2306         (process_imported_unit_die): Skip import of c++ CUs.
2307
2308 2020-03-16  Tom Tromey  <tom@tromey.com>
2309
2310         * p-valprint.c (pascal_object_print_value): Initialize
2311         base_value.
2312
2313 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
2314             Shahab Vahedi  <shahab@synopsys.com>
2315
2316         * Makefile.in: Add arch/arc.o
2317         * configure.tgt: Likewise.
2318         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
2319         (_initialize_arc_tdep): Don't initialize old target descriptions.
2320         (arc_read_description): New function to cache target descriptions.
2321         * arc-tdep.h (arc_read_description): Add proto type.
2322         * arch/arc.c: New file.
2323         * arch/arc.h: Likewise.
2324         * features/Makefile: Replace old target descriptions with new.
2325         * features/arc-arcompact.c: Remove.
2326         * features/arc-arcompact.xml: Likewise.
2327         * features/arc-v2.c: Likewise
2328         * features/arc-v2.xml: Likewise
2329         * features/arc/aux-arcompact.xml: New file.
2330         * features/arc/aux-v2.xml: Likewise.
2331         * features/arc/core-arcompact.xml: Likewise.
2332         * features/arc/core-v2.xml: Likewise.
2333         * features/arc/aux-arcompact.c: Generate.
2334         * features/arc/aux-v2.c: Likewise.
2335         * features/arc/core-arcompact.c: Likewise.
2336         * features/arc/core-v2.c: Likewise.
2337         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
2338
2339 2020-03-16  Tom Tromey  <tromey@adacore.com>
2340
2341         PR gdb/25663:
2342         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
2343         putting value into bcache.
2344
2345 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2346
2347         PR gdb/21500
2348         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
2349         to...
2350         (amd64_windows_init_abi_common): ... this.  Don't set size of
2351         long type.
2352         (amd64_windows_init_abi): New function.
2353         (amd64_cygwin_init_abi): New function.
2354         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
2355         the Cygwin OS ABI.
2356         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
2357         comment.
2358
2359 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2360
2361         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
2362         * windows-tdep.c (CYGWIN_DLL_NAME): New.
2363         (pe_import_directory_entry): New struct type.
2364         (is_linked_with_cygwin_dll): New function.
2365         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
2366         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
2367         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
2368
2369 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2370
2371         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
2372         i386_cygwin_core_osabi_sniffer.
2373
2374 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2375
2376         * i386-cygwin-tdep.c: Rename to...
2377         * i386-windows-tdep.c: ... this.
2378         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
2379         i386-windows-tdep.c.
2380         * configure.tgt: Likewise.
2381
2382 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2383
2384         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
2385         * osabi.c (gdb_osabi_names): Add "Windows".
2386         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
2387         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
2388         (i386_cygwin_core_osabi_sniffer): New function, extracted from
2389         i386_cygwin_osabi_sniffer.
2390         (_initialize_i386_cygwin_tdep): Register OS ABI
2391         GDB_OSABI_WINDOWS for i386.
2392         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
2393         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
2394         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
2395         for x86-64.
2396         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
2397         when the target matches '*-*-mingw*'.
2398
2399 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2400
2401         * defs.h (enum gdb_osabi): Move to...
2402         * osabi.h (enum gdb_osabi): ... here.
2403         * gdbarch.sh: Include osabi.h in gdbarch.h.
2404         * gdbarch.h: Re-generate.
2405
2406 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2407
2408         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
2409         function.
2410         (_initialize_amd64_windows_tdep): Register osabi sniffer.
2411
2412 2020-03-14  Tom Tromey  <tom@tromey.com>
2413
2414         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
2415         for C++.
2416         (c_type_print_modifier): Likewise.  Add "language" parameter.
2417         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
2418         (c_type_print_base_1): Update.
2419         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
2420         constants.
2421         * type-stack.c (type_stack::insert): Handle tp_atomic and
2422         tp_restrict.
2423         (type_stack::follow_type_instance_flags): Likewise.
2424         (type_stack::follow_types): Likewise.  Merge type-following code.
2425         * c-exp.y (RESTRICT, ATOMIC): New tokens.
2426         (space_identifier, cv_with_space_id)
2427         (const_or_volatile_or_space_identifier_noopt)
2428         (const_or_volatile_or_space_identifier): Remove.
2429         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
2430         rules.
2431         (ptr_operator, typebase): Update.
2432         (enum token_flag) <FLAG_C>: New constant.
2433         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
2434         "_Atomic".
2435         (lex_one_token): Handle FLAG_C.
2436
2437 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2438
2439         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
2440         it to the ptrace call.
2441         * m68k-bsd-nat.c (store_registers): Likewise.
2442
2443 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2444
2445         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
2446         gdb_byte *.
2447         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
2448         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
2449         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
2450
2451 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2452
2453         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
2454         nbsd_nat_target instead of inf_ptrace_target.
2455         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2456         nbsd_nat_target.
2457
2458 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2459
2460         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
2461         register_t.
2462
2463 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2464
2465         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
2466         it to the ptrace call.
2467         * alpha-bsd-nat.c (store_registers): Likewise.
2468
2469 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2470
2471         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
2472         includes.
2473         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
2474         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
2475         fill_fpregset): Likewise.
2476
2477 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2478
2479         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
2480         nbsd_nat_target instead of inf_ptrace_target.
2481         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2482         nbsd_nat_target.
2483
2484 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2485
2486         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
2487         register_t.
2488
2489 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2490
2491         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
2492         it to the ptrace call.
2493         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
2494         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
2495         * arm-nbsd-nat.c (store_register): Likewise.
2496         * arm-nbsd-nat.c (store_regs): Likewise.
2497         * arm-nbsd-nat.c (store_fp_register): Likewise.
2498         * arm-nbsd-nat.c (store_fp_regs): Likewise.
2499
2500 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2501
2502         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
2503         nbsd_nat_target instead of inf_ptrace_target.
2504         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2505         nbsd_nat_target.
2506
2507 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2508
2509         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
2510         it to the ptrace call.
2511         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
2512
2513 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2514
2515         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
2516         it to the ptrace call.
2517         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
2518
2519 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2520
2521         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
2522         gdb_byte *.
2523         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
2524
2525 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2526
2527         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
2528         instead of inf_ptrace_target.
2529         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2530         nbsd_nat_target.
2531
2532 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2533
2534         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2535         register_t.
2536
2537 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2538
2539         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2540         register_t.
2541
2542 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2543
2544         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
2545         register_t.
2546
2547 2020-03-13  Tom Tromey  <tom@tromey.com>
2548
2549         * value.h (val_print): Don't declare.
2550         * valprint.h (val_print_array_elements)
2551         (val_print_scalar_formatted, generic_val_print): Don't declare.
2552         * valprint.c (generic_val_print_array): Take a struct value.
2553         (generic_val_print_ptr, generic_val_print_memberptr)
2554         (generic_val_print_bool, generic_val_print_int)
2555         (generic_val_print_char, generic_val_print_complex)
2556         (generic_val_print): Remove.
2557         (generic_value_print): Update.
2558         (do_val_print): Remove unused parameters.  Don't call
2559         la_val_print.
2560         (val_print): Remove.
2561         (common_val_print): Update.  Don't call value_check_printable.
2562         (val_print_scalar_formatted, val_print_array_elements): Remove.
2563         * rust-lang.c (rust_val_print): Remove.
2564         (rust_language_defn): Update.
2565         * p-valprint.c (pascal_val_print): Remove.
2566         (pascal_value_print_inner): Update.
2567         (pascal_object_print_val_fields, pascal_object_print_val):
2568         Remove.
2569         (pascal_object_print_static_field): Update.
2570         * p-lang.h (pascal_val_print): Don't declare.
2571         * p-lang.c (pascal_language_defn): Update.
2572         * opencl-lang.c (opencl_language_defn): Update.
2573         * objc-lang.c (objc_language_defn): Update.
2574         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
2575         * m2-lang.h (m2_val_print): Don't declare.
2576         * m2-lang.c (m2_language_defn): Update.
2577         * language.h (struct language_defn) <la_val_print>: Remove.
2578         * language.c (unk_lang_value_print_inner): Rename.  Change
2579         argument types.
2580         (unknown_language_defn, auto_language_defn): Update.
2581         * go-valprint.c (go_val_print): Remove.
2582         * go-lang.h (go_val_print): Don't declare.
2583         * go-lang.c (go_language_defn): Update.
2584         * f-valprint.c (f_val_print): Remove.
2585         * f-lang.h (f_value_print): Don't declare.
2586         * f-lang.c (f_language_defn): Update.
2587         * d-valprint.c (d_val_print): Remove.
2588         * d-lang.h (d_value_print): Don't declare.
2589         * d-lang.c (d_language_defn): Update.
2590         * cp-valprint.c (cp_print_value_fields)
2591         (cp_print_value_fields_rtti, cp_print_value): Remove.
2592         (cp_print_static_field): Update.
2593         * c-valprint.c (c_val_print_array, c_val_print_ptr)
2594         (c_val_print_struct, c_val_print_union, c_val_print_int)
2595         (c_val_print_memberptr, c_val_print): Remove.
2596         * c-lang.h (c_val_print_array, cp_print_value_fields)
2597         (cp_print_value_fields_rtti): Don't declare.
2598         * c-lang.c (c_language_defn, cplus_language_defn)
2599         (asm_language_defn, minimal_language_defn): Update.
2600         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
2601         (ada_val_print_enum): Take a struct value.
2602         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
2603         (ada_val_print): Remove.
2604         (ada_value_print_1): Update.
2605         (printable_val_type): Remove.
2606         * ada-lang.h (ada_val_print): Don't declare.
2607         * ada-lang.c (ada_language_defn): Update.
2608
2609 2020-03-13  Tom Tromey  <tom@tromey.com>
2610
2611         * valprint.c (do_val_print): Update.
2612         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
2613         a struct value.
2614         (value_to_value_object_no_release): Declare.
2615         * python/py-value.c (value_to_value_object_no_release): New
2616         function.
2617         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
2618         struct value.
2619         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
2620         function.
2621         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
2622         a struct value.
2623         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
2624         Declare.
2625         (gdbscm_apply_val_pretty_printer): Take a struct value.
2626         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
2627         value.
2628         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
2629         value.
2630         * extension-priv.h (struct extension_language_ops)
2631         <apply_val_pretty_printer>: Take a struct value.
2632         * cp-valprint.c (cp_print_value): Create a struct value.
2633         (cp_print_value): Update.
2634
2635 2020-03-13  Tom Tromey  <tom@tromey.com>
2636
2637         * ada-valprint.c (print_field_values): Call common_val_print.
2638
2639 2020-03-13  Tom Tromey  <tom@tromey.com>
2640
2641         * ada-valprint.c (val_print_packed_array_elements): Remove
2642         bitoffset and val parameters.  Call common_val_print.
2643         (ada_val_print_string): Remove offset, address, and original_value
2644         parameters.
2645         (ada_val_print_array): Update.
2646         (ada_value_print_array): New function.
2647         (ada_value_print_1): Call it.
2648
2649 2020-03-13  Tom Tromey  <tom@tromey.com>
2650
2651         * ada-valprint.c (ada_value_print): Use common_val_print.
2652
2653 2020-03-13  Tom Tromey  <tom@tromey.com>
2654
2655         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
2656
2657 2020-03-13  Tom Tromey  <tom@tromey.com>
2658
2659         * ada-valprint.c (ada_value_print_num): New function.
2660         (ada_value_print_1): Use it.
2661
2662 2020-03-13  Tom Tromey  <tom@tromey.com>
2663
2664         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
2665
2666 2020-03-13  Tom Tromey  <tom@tromey.com>
2667
2668         * ada-valprint.c (ada_value_print_ptr): New function.
2669         (ada_value_print_1): Use it.
2670
2671 2020-03-13  Tom Tromey  <tom@tromey.com>
2672
2673         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
2674         call common_val_print.
2675         (ada_val_print_1): Update.
2676         (ada_value_print_1): New function.
2677         (ada_value_print_inner): Rewrite.
2678
2679 2020-03-13  Tom Tromey  <tom@tromey.com>
2680
2681         * cp-valprint.c (cp_print_value_fields): Update.
2682         (cp_print_value): New function.
2683
2684 2020-03-13  Tom Tromey  <tom@tromey.com>
2685
2686         * m2-valprint.c (m2_value_print_inner): Use
2687         cp_print_value_fields.
2688         * cp-valprint.c (cp_print_value_fields): New function.
2689         * c-valprint.c (c_value_print_struct): New function.
2690         (c_value_print_inner): Use c_value_print_struct.
2691         * c-lang.h (cp_print_value_fields): Declare.
2692
2693 2020-03-13  Tom Tromey  <tom@tromey.com>
2694
2695         * c-valprint.c (c_value_print_array): New function.
2696         (c_value_print_inner): Use it.
2697
2698 2020-03-13  Tom Tromey  <tom@tromey.com>
2699
2700         * c-valprint.c (c_value_print_memberptr): New function.
2701         (c_value_print_inner): Use it.
2702
2703 2020-03-13  Tom Tromey  <tom@tromey.com>
2704
2705         * c-valprint.c (c_value_print_int): New function.
2706         (c_value_print_inner): Use it.
2707
2708 2020-03-13  Tom Tromey  <tom@tromey.com>
2709
2710         * c-valprint.c (c_value_print_ptr): New function.
2711         (c_value_print_inner): Use it.
2712
2713 2020-03-13  Tom Tromey  <tom@tromey.com>
2714
2715         * c-valprint.c (c_value_print_inner): Rewrite.
2716
2717 2020-03-13  Tom Tromey  <tom@tromey.com>
2718
2719         * valprint.c (generic_value_print_complex): New function.
2720         (generic_value_print): Use it.
2721
2722 2020-03-13  Tom Tromey  <tom@tromey.com>
2723
2724         * valprint.c (generic_val_print_float): Don't call
2725         val_print_scalar_formatted.
2726         (generic_val_print, generic_value_print): Update.
2727
2728 2020-03-13  Tom Tromey  <tom@tromey.com>
2729
2730         * valprint.c (generic_value_print_char): New function
2731         (generic_value_print): Use it.
2732
2733 2020-03-13  Tom Tromey  <tom@tromey.com>
2734
2735         * valprint.c (generic_value_print_int): New function.
2736         (generic_value_print): Use it.
2737
2738 2020-03-13  Tom Tromey  <tom@tromey.com>
2739
2740         * valprint.c (generic_value_print_bool): New function.
2741         (generic_value_print): Use it.
2742
2743 2020-03-13  Tom Tromey  <tom@tromey.com>
2744
2745         * valprint.c (generic_val_print_func): Simplify.
2746         (generic_val_print, generic_value_print): Update.
2747
2748 2020-03-13  Tom Tromey  <tom@tromey.com>
2749
2750         * valprint.c (generic_val_print_flags): Remove.
2751         (generic_val_print, generic_value_print): Update.
2752         (val_print_type_code_flags): Add original_value parameter.
2753
2754 2020-03-13  Tom Tromey  <tom@tromey.com>
2755
2756         * valprint.c (generic_val_print): Update.
2757         (generic_value_print): Update.
2758         * valprint.c (generic_val_print_enum): Don't call
2759         val_print_scalar_formatted.
2760
2761 2020-03-13  Tom Tromey  <tom@tromey.com>
2762
2763         * valprint.c (generic_value_print): Call generic_value_print_ptr.
2764         * valprint.c (generic_value_print_ptr): New function.
2765
2766 2020-03-13  Tom Tromey  <tom@tromey.com>
2767
2768         * valprint.c (generic_value_print): Rewrite.
2769
2770 2020-03-13  Tom Tromey  <tom@tromey.com>
2771
2772         * p-valprint.c (pascal_object_print_value_fields)
2773         (pascal_object_print_value): New functions.
2774
2775 2020-03-13  Tom Tromey  <tom@tromey.com>
2776
2777         * p-valprint.c (pascal_value_print_inner): Rewrite.
2778
2779 2020-03-13  Tom Tromey  <tom@tromey.com>
2780
2781         * f-valprint.c (f_value_print_innner): Rewrite.
2782
2783 2020-03-13  Tom Tromey  <tom@tromey.com>
2784
2785         * m2-valprint.c (m2_print_unbounded_array): New overload.
2786         (m2_print_unbounded_array): Update.
2787         (m2_print_array_contents): Take a struct value.
2788         (m2_value_print_inner): Rewrite.
2789
2790 2020-03-13  Tom Tromey  <tom@tromey.com>
2791
2792         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
2793         (d_value_print_inner): New function.
2794         * d-lang.h (d_value_print_inner): Declare.
2795         * d-lang.c (d_language_defn): Use d_value_print_inner.
2796
2797 2020-03-13  Tom Tromey  <tom@tromey.com>
2798
2799         * go-valprint.c (go_value_print_inner): New function.
2800         * go-lang.h (go_value_print_inner): Declare.
2801         * go-lang.c (go_language_defn): Use go_value_print_inner.
2802
2803 2020-03-13  Tom Tromey  <tom@tromey.com>
2804
2805         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
2806         API.
2807         (rust_val_print): Rewrite.
2808         (rust_value_print_inner): New function, from rust_val_print.
2809         (rust_language_defn): Use rust_value_print_inner.
2810
2811 2020-03-13  Tom Tromey  <tom@tromey.com>
2812
2813         * ada-valprint.c (ada_value_print_inner): New function.
2814         * ada-lang.h (ada_value_print_inner): Declare.
2815         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
2816
2817 2020-03-13  Tom Tromey  <tom@tromey.com>
2818
2819         * f-valprint.c (f_value_print_innner): New function.
2820         * f-lang.h (f_value_print_innner): Declare.
2821         * f-lang.c (f_language_defn): Use f_value_print_innner.
2822
2823 2020-03-13  Tom Tromey  <tom@tromey.com>
2824
2825         * p-valprint.c (pascal_value_print_inner): New function.
2826         * p-lang.h (pascal_value_print_inner): Declare.
2827         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
2828
2829 2020-03-13  Tom Tromey  <tom@tromey.com>
2830
2831         * m2-valprint.c (m2_value_print_inner): New function.
2832         * m2-lang.h (m2_value_print_inner): Declare.
2833         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
2834
2835 2020-03-13  Tom Tromey  <tom@tromey.com>
2836
2837         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
2838         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
2839         * c-valprint.c (c_value_print_inner): New function.
2840         * c-lang.h (c_value_print_inner): Declare.
2841         * c-lang.c (c_language_defn, cplus_language_defn)
2842         (asm_language_defn, minimal_language_defn): Use
2843         c_value_print_inner.
2844
2845 2020-03-13  Tom Tromey  <tom@tromey.com>
2846
2847         * p-valprint.c (pascal_object_print_value_fields): Now static.
2848         * p-lang.h (pascal_object_print_value_fields): Don't declare.
2849
2850 2020-03-13  Tom Tromey  <tom@tromey.com>
2851
2852         * c-valprint.c (c_val_print_array): Simplify.
2853
2854 2020-03-13  Tom Tromey  <tom@tromey.com>
2855
2856         * valprint.c (value_print_array_elements): New function.
2857         * valprint.h (value_print_array_elements): Declare.
2858
2859 2020-03-13  Tom Tromey  <tom@tromey.com>
2860
2861         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
2862         * mips-tdep.c (mips_print_register): Use
2863         value_print_scalar_formatted.
2864
2865 2020-03-13  Tom Tromey  <tom@tromey.com>
2866
2867         * valprint.h (value_print_scalar_formatted): Declare.
2868         * valprint.c (value_print_scalar_formatted): New function.
2869
2870 2020-03-13  Tom Tromey  <tom@tromey.com>
2871
2872         * valprint.h (generic_value_print): Declare.
2873         * valprint.c (generic_value_print): New function.
2874
2875 2020-03-13  Tom Tromey  <tom@tromey.com>
2876
2877         * valprint.c (do_val_print): Call la_value_print_inner, if
2878         available.
2879         * rust-lang.c (rust_language_defn): Update.
2880         * p-lang.c (pascal_language_defn): Update.
2881         * opencl-lang.c (opencl_language_defn): Update.
2882         * objc-lang.c (objc_language_defn): Update.
2883         * m2-lang.c (m2_language_defn): Update.
2884         * language.h (struct language_defn) <la_value_print_inner>: New
2885         member.
2886         * language.c (unknown_language_defn, auto_language_defn): Update.
2887         * go-lang.c (go_language_defn): Update.
2888         * f-lang.c (f_language_defn): Update.
2889         * d-lang.c (d_language_defn): Update.
2890         * c-lang.c (c_language_defn, cplus_language_defn)
2891         (asm_language_defn, minimal_language_defn): Update.
2892         * ada-lang.c (ada_language_defn): Update.
2893
2894 2020-03-13  Tom Tromey  <tom@tromey.com>
2895
2896         * c-valprint.c (c_value_print): Use common_val_print.
2897
2898 2020-03-13  Tom Tromey  <tom@tromey.com>
2899
2900         * cp-valprint.c (cp_print_static_field): Use common_val_print.
2901
2902 2020-03-13  Tom Tromey  <tom@tromey.com>
2903
2904         * f-valprint.c (f77_print_array_1, f_val_print): Use
2905         common_val_print.
2906
2907 2020-03-13  Tom Tromey  <tom@tromey.com>
2908
2909         * riscv-tdep.c (riscv_print_one_register_info): Use
2910         common_val_print.
2911
2912 2020-03-13  Tom Tromey  <tom@tromey.com>
2913
2914         * mi/mi-main.c (output_register): Use common_val_print.
2915
2916 2020-03-13  Tom Tromey  <tom@tromey.com>
2917
2918         * infcmd.c (default_print_one_register_info): Use
2919         common_val_print.
2920
2921 2020-03-13  Tom Tromey  <tom@tromey.com>
2922
2923         * valprint.h (common_val_print_checked): Declare.
2924         * valprint.c (common_val_print_checked): New function.
2925         * stack.c (print_frame_arg): Use common_val_print_checked.
2926
2927 2020-03-13  Tom Tromey  <tom@tromey.com>
2928
2929         * valprint.c (do_val_print): New function, from val_print.
2930         (val_print): Use do_val_print.
2931         (common_val_print): Use do_val_print.
2932
2933 2020-03-13  Tom Tromey  <tom@tromey.com>
2934
2935         * valprint.c (value_print): Use scoped_value_mark.
2936
2937 2020-03-13  Tom de Vries  <tdevries@suse.de>
2938
2939         PR symtab/25646
2940         * psymtab.c (partial_symtab::partial_symtab): Don't set
2941         globals_offset and statics_offset.  Push element onto
2942         current_global_psymbols and current_static_psymbols stacks.
2943         (concat): New function.
2944         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
2945         element from current_global_psymbols and current_static_psymbols
2946         stacks.  Concat popped elements to global_psymbols and
2947         static_symbols.
2948         (add_psymbol_to_list): Use current_global_psymbols and
2949         current_static_psymbols stacks.
2950         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
2951         current_static_psymbols fields.
2952
2953 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
2954
2955         * corelow.c (sniff_core_bfd): Remove.
2956         (class core_target) <m_core_vec>: Remove.
2957         (core_target::core_target): Update.
2958         (core_file_fns): Remove.
2959         (deprecated_add_core_fns): Remove.
2960         (default_core_sniffer): Remove.
2961         (sniff_core_bfd): Remove.
2962         (default_check_format): Remove.
2963         (gdb_check_format): Remove.
2964         (core_target_open): Update.
2965         (core_target::get_core_register_section): Update.
2966         (get_core_registers_cb): Update.
2967         (core_target::fetch_registers): Update.
2968         * gdbcore.h (struct core_fns): Remove.
2969         (deprecated_add_core_fns): Remove.
2970         (default_core_sniffer): Remove.
2971         (default_check_format): Remove.
2972
2973 2020-03-12  Tom Tromey  <tom@tromey.com>
2974
2975         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
2976         CORE_ADDR.
2977         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
2978
2979 2020-03-12  Tom Tromey  <tom@tromey.com>
2980
2981         * remote.c (remote_target::download_tracepoint)
2982         (remote_target::enable_tracepoint)
2983         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
2984         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
2985         sprintf_vma.
2986
2987 2020-03-12  Tom Tromey  <tom@tromey.com>
2988
2989         * symfile-mem.c: Update CORE_ADDR size assert.
2990
2991 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
2992
2993         * selftest.m4: Move to gdbsupport/.
2994         * acinclude.m4: Update path to selftest.m4.
2995
2996 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
2997
2998         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
2999         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
3000         gdbarch-selfselftests.c and selftest-arch.c.
3001         (SUBDIR_UNITTESTS_OBS): Rename to...
3002         (SELFTESTS_OBS): ... this.
3003         (COMMON_SFILES): Remove disasm-selftests.c and
3004         gdbarch-selftests.c.
3005         * configure.ac: Don't add selftest-arch.{c,o} to
3006         CONFIG_{SRCS,OBS}.
3007         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
3008         preprocessor conditions.
3009
3010 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3011
3012         * configure.ac: Don't source bfd/development.sh.
3013         * selftest.m4: Modify comment.
3014         * configure: Re-generate.
3015
3016 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3017
3018         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
3019         not "true" or "false".
3020         * configure: Re-generate.
3021
3022 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
3023
3024         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
3025         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
3026         renamed to arm_nbsd_supply_gregset.
3027         (fetch_register): Update to call arm_nbsd_supply_gregset.
3028         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
3029         (arm_netbsd_nat_target::fetch_registers): Update.
3030         (fetch_elfcore_registers): Removed.
3031         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
3032         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
3033         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
3034         not require NetBSD system headers.
3035         (arm_nbsd_regset): New struct.
3036         (arm_nbsd_iterate_over_regset_sections): New function.
3037         (arm_netbsd_init_abi_common): Updated to call
3038         set_gdbarch_iterate_over_regset_sections.
3039         * arm-nbsd-tdep.h: New file.
3040
3041 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
3042
3043         * symtab.c (find_pc_sect_line): Add check which prevents infinite
3044         recursion.
3045
3046 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
3047
3048         * configure: Re-generate.
3049
3050 2020-03-11  Tom Tromey  <tromey@adacore.com>
3051
3052         * ada-typeprint.c (print_choices): Fix comment.
3053
3054 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3055
3056         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
3057         previous item in the list, when the list has no items.
3058
3059 2020-03-11  Tom de Vries  <tdevries@suse.de>
3060
3061         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
3062         PROP_LOCLIST handling code.
3063
3064 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3065
3066         * buildsym-legacy.c (record_line): Pass extra parameter to
3067         record_line.
3068         * buildsym.c (buildsym_compunit::record_line): Take an extra
3069         parameter, reduce duplication in the line table, and record the
3070         is_stmt flag in the line table.
3071         * buildsym.h (buildsym_compunit::record_line): Add extra
3072         parameter.
3073         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
3074         non-statement lines.
3075         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
3076         this to the symtab builder.
3077         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
3078         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
3079         through to dwarf_record_line_1.
3080         * infrun.c (process_event_stop_test): When stepping, don't stop at
3081         a non-statement instruction, and only refresh the step info when
3082         we land in the middle of a line's range.  Also add an extra
3083         comment.
3084         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
3085         field.
3086         * record-btrace.c (btrace_find_line_range): Only record lines
3087         marked as is-statement.
3088         * stack.c (frame_show_address): Show the frame address if we are
3089         in a non-statement sal.
3090         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
3091         (maintenance_print_one_line_table): Print a header for the is_stmt
3092         column, and include is_stmt information in the output.
3093         * symtab.c (find_pc_sect_line): Find lines marked as statements in
3094         preference to non-statements.
3095         (find_pcs_for_symtab_line): Prefer is-statement entries.
3096         (find_line_common): Likewise.
3097         * symtab.h (struct linetable_entry): Add is_stmt field.
3098         (struct symtab_and_line): Likewise.
3099         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
3100         arranging the line table.
3101
3102 2020-03-07  Tom de Vries  <tdevries@suse.de>
3103
3104         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
3105         DIE.
3106
3107 2020-03-07  Tom Tromey  <tom@tromey.com>
3108
3109         * valops.c (value_literal_complex): Remove obsolete comment.
3110         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
3111         comment.
3112
3113 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
3114
3115         * infrun.h: Forward-declare thread_info.
3116         (set_step_info): Add thread_info parameter, add doc.
3117         * infrun.c (set_step_info): Add thread_info parameter, move doc
3118         to header.
3119         * infrun.c (process_event_stop_test): Pass thread to
3120         set_step_info call.
3121         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
3122         set_step_info.
3123         (prepare_one_step): Add thread_info parameter, pass it to
3124         set_step_frame and prepare_one_step (recursive) call.
3125         (step_1): Pass thread to prepare_one_step call.
3126         (step_command_fsm::should_stop): Pass thread to
3127         prepare_one_step.
3128         (until_next_fsm): Pass thread to set_step_frame call.
3129         (finish_command): Pass thread to set_step_info call.
3130
3131 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
3132
3133         * windows-tdep.c (windows_solib_create_inferior_hook):
3134         Check if inferior is running.
3135
3136 2020-03-06  Tom de Vries  <tdevries@suse.de>
3137
3138         * NEWS: Fix "the the".
3139         * ctfread.c: Same.
3140
3141 2020-03-06  Tom de Vries  <tdevries@suse.de>
3142
3143         * psymtab.c (psymtab_to_symtab): Don't print "done.".
3144
3145 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3146
3147         * .dir-locals.el: Add a comment referencing the other copies of
3148         this file.
3149
3150 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
3151
3152         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
3153         psargs.
3154
3155 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3156
3157         * .gitattributes: New file.
3158
3159 2020-03-04  Tom Tromey  <tom@tromey.com>
3160
3161         * symmisc.c (print_symbol_bcache_statistics)
3162         (print_objfile_statistics): Update.
3163         * symfile.c (allocate_symtab): Use intern.
3164         * psymtab.c (partial_symtab::partial_symtab): Use intern.
3165         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3166         macro_cache>: Remove.
3167         <string_cache>: New member.
3168         (struct objfile) <intern>: New methods.
3169         * elfread.c (elf_symtab_read): Use intern.
3170         * dwarf2/read.c (fixup_go_packaging): Intern package name.
3171         (dwarf2_compute_name, dwarf2_physname)
3172         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
3173         names.
3174         (guess_partial_die_structure_name): Update.
3175         (partial_die_info::fixup): Intern name.
3176         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
3177         name.
3178         (dwarf2_name): Intern name.  Update.
3179         * buildsym.c (buildsym_compunit::get_macro_table): Use
3180         string_cache.
3181
3182 2020-03-04  Tom Tromey  <tom@tromey.com>
3183
3184         * jit.c (bfd_open_from_target_memory): Make "target" const.
3185         * corefile.c (gnutarget): Now const.
3186         * gdbcore.h (gnutarget): Now const.
3187
3188 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
3189
3190         * NEWS: Mention support for WOW64 processes.
3191         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
3192         (amd64_windows_segment_register_p): Remove static.
3193         (_initialize_amd64_windows_nat): Update.
3194         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
3195         * i386-windows-nat.c (context_offset): Update.
3196         (i386_mappings): Rename and remove static.
3197         (i386_windows_segment_register_p): Remove static.
3198         (_initialize_i386_windows_nat): Update.
3199         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
3200         (STATUS_WX86_SINGLE_STEP): New macro.
3201         (EnumProcessModulesEx): New macro.
3202         (Wow64SuspendThread): New macro.
3203         (Wow64GetThreadContext): New macro.
3204         (Wow64SetThreadContext): New macro.
3205         (Wow64GetThreadSelectorEntry): New macro.
3206         (windows_set_context_register_offsets): Add static.
3207         (windows_set_segment_register_p): Likewise.
3208         (windows_add_thread): Adapt for WOW64 processes.
3209         (windows_fetch_one_register): Likewise.
3210         (windows_nat_target::fetch_registers): Likewise.
3211         (windows_store_one_register): Likewise.
3212         (display_selector): Likewise.
3213         (display_selectors): Likewise.
3214         (handle_exception): Likewise.
3215         (windows_continue): Likewise.
3216         (windows_nat_target::resume): Likewise.
3217         (windows_add_all_dlls): Likewise.
3218         (do_initial_windows_stuff): Likewise.
3219         (windows_nat_target::attach): Likewise.
3220         (windows_get_exec_module_filename): Likewise.
3221         (windows_nat_target::create_inferior): Likewise.
3222         (windows_xfer_siginfo): Likewise.
3223         (_initialize_loadable): Initialize Wow64SuspendThread,
3224         Wow64GetThreadContext, Wow64SetThreadContext,
3225         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
3226         * windows-nat.h (windows_set_context_register_offsets):
3227         Remove declaration.
3228         (windows_set_segment_register_p): Likewise.
3229         (i386_windows_segment_register_p): Add declaration.
3230         (amd64_windows_segment_register_p): Likewise.
3231
3232 2020-03-04  Luis Machado  <luis.machado@linaro.org>
3233
3234         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
3235         in "info registers" for AArch64/ARM.
3236
3237         The change caused "info registers" to not print GPR's.
3238
3239         gdb/ChangeLog:
3240
3241         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
3242
3243         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
3244         when reg->group is empty and reggroup is not.
3245
3246 2020-03-03  Tom Tromey  <tromey@adacore.com>
3247
3248         * dwarf2/frame.c (struct dwarf2_frame_cache)
3249         <checked_tailcall_bottom, entry_cfa_sp_offset,
3250         entry_cfa_sp_offset_p>: Remove members.
3251         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
3252         (dwarf2_frame_prev_register): Don't call
3253         dwarf2_tailcall_sniffer_first.
3254         (dwarf2_append_unwinders): Don't append tailcall unwinder.
3255         * frame-unwind.c (add_unwinder): New fuction.
3256         (frame_unwind_init): Use it.  Add tailcall unwinder.
3257
3258 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3259             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
3260
3261         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
3262         value should be printed as true.
3263
3264 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
3265
3266         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
3267         (windows_init_abi): Set and use windows_so_ops.
3268
3269 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
3270
3271         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
3272         when verifying if dealing with a convenience variable.
3273
3274 2020-03-03  Luis Machado  <luis.machado@linaro.org>
3275
3276         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
3277
3278 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
3279
3280         * infrun.c (gdbarch_supports_displaced_stepping): New.
3281         (use_displaced_stepping): Break up conditions in smaller pieces.
3282         Use gdbarch_supports_displaced_stepping.
3283         (displaced_step_prepare_throw): Use
3284         gdbarch_supports_displaced_stepping.
3285
3286 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3287
3288         * NEWS: Mention new behaviour of the history filename.
3289         * top.c (write_history_p): Add comment.
3290         (show_write_history_p): Add header comment, give a different
3291         message when history writing is on, but the history filename is
3292         empty.
3293         (history_filename): Add comment.
3294         (history_filename_empty): New function.
3295         (show_history_filename): Add header comment, give a different
3296         message when the filename is empty.
3297         (init_history): Compare history_filename against nullptr, and only
3298         read history if the filename is not empty.
3299         (set_history_filename): Add header comment, and only make
3300         non-empty filenames absolute.
3301         (init_main): Make the filename argument to 'set history filename'
3302         optional.
3303
3304 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
3305
3306         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
3307         (arm_supply_vfpregset): ...this, and update to use VFP registers.
3308         (fetch_fp_register): Update.
3309         (fetch_fp_regs): Update.
3310         (store_fp_register): Update.
3311         (store_fp_regs): Update.
3312         (arm_netbsd_nat_target::read_description): New function.
3313         (fetch_elfcore_registers): Update.
3314
3315 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3316
3317         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
3318         general_thread if the stop reply is missing a thread-id.
3319         (remote_target::process_stop_reply): Use the first non-exited
3320         thread if the target didn't pass a thread-id.
3321         * infrun.c (do_target_wait): Move call to
3322         switch_to_inferior_no_thread to ....
3323         (do_target_wait_1): ... here.
3324
3325 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
3326
3327         * debuginfod-support.c: Include defs.h first.
3328
3329 2020-02-28  Tom de Vries  <tdevries@suse.de>
3330
3331         * symfile.c (set_initial_language): Use default language for lookup.
3332
3333 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
3334
3335         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
3336         reader variable, pass `this` to read_cutu_die_from_dwo.
3337
3338 2020-02-27  Aaron Merey  <amerey@redhat.com>
3339
3340         * source.c (open_source_file): Check for nullptr when computing
3341         srcpath.
3342
3343 2020-02-27  Tom Tromey  <tromey@adacore.com>
3344
3345         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
3346         member.
3347         (dwarf2_add_field): Don't update nfields.
3348         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
3349
3350 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3351
3352         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
3353         abs.
3354
3355 2020-02-26  Tom Tromey  <tom@tromey.com>
3356
3357         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
3358         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
3359         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
3360         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
3361         per_cu_data.
3362
3363 2020-02-26  Tom Tromey  <tom@tromey.com>
3364
3365         * dwarf2/index-write.c (psym_index_map): Change type.
3366         (add_address_entry_worker, write_one_signatured_type)
3367         (recursively_count_psymbols, recursively_write_psymbols)
3368         (class debug_names, psyms_seen_size, write_gdbindex)
3369         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
3370
3371 2020-02-26  Aaron Merey  <amerey@redhat.com>
3372
3373         * Makefile.in: Handle optional debuginfod support.
3374         * NEWS: Update.
3375         * README: Add --with-debuginfod summary.
3376         * config.in: Regenerate.
3377         * configure: Regenerate.
3378         * configure.ac: Handle optional debuginfod support.
3379         * debuginfod-support.c: debuginfod helper functions.
3380         * debuginfod-support.h: Ditto.
3381         * doc/gdb.texinfo: Add --with-debuginfod to configure options
3382         summary.
3383         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
3384         when a dwz file cannot be found.
3385         * elfread.c (elf_symfile_read): Query debuginfod servers when a
3386         debuginfo file cannot be found.
3387         * source.c (open_source_file): Query debuginfod servers when a
3388         source file cannot be found.
3389         * top.c (print_gdb_configuration): Include
3390         --{with,without}-debuginfod in the output.
3391
3392 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
3393
3394         * thread.c (thr_try_catch_cmd): Print thread name.
3395
3396 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
3397
3398         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
3399         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3400         dwarf2_fetch_die_type_sect_off): Move to...
3401         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
3402         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3403         dwarf2_fetch_die_type_sect_off): ... here.
3404         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
3405         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3406         dwarf2_fetch_die_type_sect_off): Move doc to header file.
3407
3408 2020-02-26  Tom de Vries  <tdevries@suse.de>
3409
3410         PR gdb/25603
3411         * symfile.c (set_initial_language): Exit-early if
3412         language_mode == language_mode_manual.
3413
3414 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3415
3416         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
3417         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
3418         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
3419
3420 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
3421
3422         * gdbtypes.c (create_array_type_with_stride): Handle negative
3423         array strides.
3424         * valarith.c (value_subscripted_rvalue): Likewise.
3425
3426 2020-02-25  Luis Machado  <luis.machado@linaro.org>
3427
3428         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
3429
3430 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3431
3432         * loc.h (dwarf2_get_die_type): Move to...
3433         * read.h (dwarf2_get_die_type): ... here.
3434         * read.c (dwarf2_get_die_type): Move doc to header.
3435
3436 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
3437
3438         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
3439         'gnulib/Makefile.in' to the list.
3440
3441 2020-02-24  Tom Tromey  <tom@tromey.com>
3442
3443         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
3444         Remove.
3445         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
3446         XOBNEWVEC.
3447
3448 2020-02-24  Tom Tromey  <tom@tromey.com>
3449
3450         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
3451         New method.
3452         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
3453         (dw2_do_instantiate_symtab, dw2_get_file_names)
3454         (build_type_psymtab_dependencies, load_full_type_unit): Update.
3455
3456 2020-02-24  Tom Tromey  <tom@tromey.com>
3457
3458         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
3459         make_scoped_restore.
3460         (dwarf2_psymtab::read_symtab): Don't clear
3461         reading_partial_symbols.
3462
3463 2020-02-24  Tom de Vries  <tdevries@suse.de>
3464
3465         PR gdb/25592
3466         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
3467
3468 2020-02-24  Tom de Vries  <tdevries@suse.de>
3469
3470         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
3471         commands layout next/prev/regs.
3472
3473 2020-02-22  Tom Tromey  <tom@tromey.com>
3474
3475         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
3476         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
3477
3478 2020-02-22  Tom Tromey  <tom@tromey.com>
3479
3480         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
3481
3482 2020-02-22  Tom Tromey  <tom@tromey.com>
3483
3484         * tui/tui-win.c (_initialize_tui_win): Add usage text.
3485         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
3486         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
3487         * tui/tui.c (_initialize_tui): Add usage text.
3488
3489 2020-02-22  Tom Tromey  <tom@tromey.com>
3490
3491         * tui/tui-win.c (tui_set_focus_command)
3492         (tui_set_win_height_command): Use error_no_arg.
3493         (_initialize_tui_win): Update help text.
3494         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
3495
3496 2020-02-22  Tom Tromey  <tom@tromey.com>
3497
3498         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
3499         * tui/tui-disasm.h (struct tui_disasm_window)
3500         <display_start_addr>: Declare.
3501         * tui/tui-source.h (struct tui_source_window)
3502         <display_start_addr>: Declare.
3503         * tui/tui-winsource.h (struct tui_source_window_base)
3504         <show_source_line, display_start_addr>: New methods.
3505         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
3506         Rename and move to protected section.
3507         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
3508         (tui_source_window_base::do_erase_source_content): Update.
3509         (tui_source_window_base::show_source_line): Now a method.
3510         (tui_source_window_base::show_source_content)
3511         (tui_source_window_base::tui_source_window_base)
3512         (tui_source_window_base::rerender)
3513         (tui_source_window_base::refill)
3514         (tui_source_window_base::do_scroll_horizontal)
3515         (tui_source_window_base::set_is_exec_point_at)
3516         (tui_source_window_base::update_breakpoint_info)
3517         (tui_source_window_base::update_exec_info): Update.
3518         * tui/tui-source.c (tui_source_window::set_contents)
3519         (tui_source_window::showing_source_p)
3520         (tui_source_window::do_scroll_vertical)
3521         (tui_source_window::location_matches_p)
3522         (tui_source_window::line_is_displayed): Update.
3523         (tui_source_window::display_start_addr): New method.
3524         * tui/tui-disasm.c (tui_disasm_window::set_contents)
3525         (tui_disasm_window::do_scroll_vertical)
3526         (tui_disasm_window::location_matches_p): Update.
3527         (tui_disasm_window::display_start_addr): New method.
3528
3529 2020-02-22  Tom Tromey  <tom@tromey.com>
3530
3531         * NEWS: Add entry for gdb.register_window_type.
3532         * tui/tui-layout.h (window_factory): New typedef.
3533         (tui_register_window): Declare.
3534         * tui/tui-layout.c (saved_tui_windows): New global.
3535         (tui_apply_current_layout): Use it.
3536         (tui_register_window): New function.
3537         * python/python.c (do_start_initialization): Call
3538         gdbpy_initialize_tui.
3539         (python_GdbMethods): Add "register_window_type" function.
3540         * python/python-internal.h (gdbpy_register_tui_window)
3541         (gdbpy_initialize_tui): Declare.
3542         * python/py-tui.c: New file.
3543         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
3544
3545 2020-02-22  Tom Tromey  <tom@tromey.com>
3546
3547         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
3548
3549 2020-02-22  Tom Tromey  <tom@tromey.com>
3550
3551         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
3552         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
3553         * tui/tui-data.c (tui_set_win_with_focus): Remove.
3554         (tui_set_win_focus_to): Move from tui-win.c.
3555
3556 2020-02-22  Tom Tromey  <tom@tromey.com>
3557
3558         * tui/tui-layout.c (make_standard_window, get_locator_window): New
3559         functions.
3560         (known_window_types): New global.
3561         (tui_get_window_by_name): Reimplement.
3562         (initialize_known_windows): New function.
3563         (validate_window_name): Rewrite.
3564         (_initialize_tui_layout): Call initialize_known_windows.
3565
3566 2020-02-22  Tom Tromey  <tom@tromey.com>
3567
3568         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
3569         Remove constants.
3570         * tui/tui-winsource.h (struct tui_source_window_base)
3571         <tui_source_window_base>: Remove parameter.
3572         * tui/tui-winsource.c
3573         (tui_source_window_base::tui_source_window_base): Remove
3574         parameter.
3575         (tui_source_window_base::refill): Update.
3576         * tui/tui-stack.h (struct tui_locator_window)
3577         <tui_locator_window>: Update.
3578         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
3579         Default the constructor.
3580         * tui/tui-regs.h (struct tui_data_item_window)
3581         <tui_data_item_window>: Default the constructor.
3582         (struct tui_data_window) <tui_data_window>: Likewise.
3583         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
3584         Default the constructor.
3585         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
3586         Default the constructor.
3587         <type>: Remove.
3588         (struct tui_win_info) <tui_win_info>: Default the constructor.
3589         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
3590         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
3591         Default the constructor.
3592
3593 2020-02-22  Tom Tromey  <tom@tromey.com>
3594
3595         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
3596         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
3597         * tui/tui-win.c (tui_resize_all): Don't call
3598         tui_delete_invisible_windows.
3599         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
3600         done.
3601         (tui_set_layout): Update.
3602         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
3603         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
3604         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
3605
3606 2020-02-22  Tom Tromey  <tom@tromey.com>
3607
3608         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
3609         correctly.
3610
3611 2020-02-22  Tom Tromey  <tom@tromey.com>
3612
3613         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
3614
3615 2020-02-22  Tom Tromey  <tom@tromey.com>
3616
3617         * tui/tui-winsource.h (struct tui_source_window_iterator)
3618         <inner_iterator>: New etytypedef.
3619         <tui_source_window_iterator>: Take "end" parameter.
3620         <tui_source_window_iterator>: Take iterator.
3621         <operator*, advance>: Update.
3622         <m_iter>: Change type.
3623         <m_end>: New field.
3624         (struct tui_source_windows) <begin, end>: Update.
3625         * tui/tui-layout.c (tui_windows): New global.
3626         (tui_apply_current_layout): Clear tui_windows.
3627         (tui_layout_window::apply): Update tui_windows.
3628         * tui/tui-data.h (tui_windows): Declare.
3629         (all_tui_windows): Now inline function.
3630         (class tui_window_iterator, struct all_tui_windows): Remove.
3631
3632 2020-02-22  Tom Tromey  <tom@tromey.com>
3633
3634         PR tui/17850:
3635         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
3636         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
3637         "height" argument.
3638         (class tui_layout_window) <get_sizes>: Likewise.
3639         (class tui_layout_split) <tui_layout_split>: Add "vertical"
3640         argument.
3641         <get_sizes>: Add "height" argument.
3642         <m_vertical>: New field.
3643         * tui/tui-layout.c (tui_layout_split::clone): Update.
3644         (tui_layout_split::get_sizes): Add "height" argument.
3645         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
3646         (tui_new_layout_command): Parse "-horizontal".
3647         (_initialize_tui_layout): Update help string.
3648         (tui_layout_split::specification): Add "-horizontal" when needed.
3649         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
3650         argument.
3651         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
3652         New methods.
3653
3654 2020-02-22  Tom Tromey  <tom@tromey.com>
3655
3656         * tui/tui-layout.h (enum tui_adjust_result): New.
3657         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
3658         (class tui_layout_window) <adjust_size>: Return
3659         tui_adjust_result.  Rewrite.
3660         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
3661         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
3662
3663 2020-02-22  Tom Tromey  <tom@tromey.com>
3664
3665         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
3666         parameter and return types.
3667         (class tui_layout_base) <specification>: Add "depth".
3668         (class tui_layout_window) <specification>: Add "depth".
3669         (class tui_layout_split) <specification>: Add "depth".
3670         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
3671         and return types.
3672         (tui_new_layout_command): Parse sub-layouts.
3673         (_initialize_tui_layout): Update help string.
3674         (tui_layout_window::specification): Add "depth".
3675         (add_layout_command): Update.
3676
3677 2020-02-22  Tom Tromey  <tom@tromey.com>
3678
3679         * NEWS: Add "tui new-layout" item.
3680         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
3681         Add new-layout command to help text.
3682         (validate_window_name): New function.
3683         (tui_new_layout_command): New function.
3684         (_initialize_tui_layout): Register "new-layout".
3685         (tui_layout_window::specification): New method.
3686         (tui_layout_window::specification): New method.
3687         * tui/tui-layout.h (class tui_layout_base) <specification>: New
3688         method.
3689         (class tui_layout_window) <specification>: New method.
3690         (class tui_layout_split) <specification>: New method.
3691
3692 2020-02-22  Tom Tromey  <tom@tromey.com>
3693
3694         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
3695         * tui/tui-win.c (window_name_completer): Update comment.
3696         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
3697         Declare method.
3698         (class tui_layout_window) <replace_window>: Likewise.
3699         (class tui_layout_split) <replace_window>: Likewise.
3700         (tui_set_layout): Don't declare.
3701         (tui_set_initial_layout): Declare function.
3702         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
3703         (asm_regs_layout): New globals.
3704         (tui_current_layout, show_layout): Remove.
3705         (tui_set_layout, tui_add_win_to_layout): Rewrite.
3706         (find_layout, tui_apply_layout): New function.
3707         (layout_completer): Remove.
3708         (tui_next_layout): Reimplement.
3709         (tui_next_layout_command): New function.
3710         (tui_set_initial_layout, tui_prev_layout_command): New functions.
3711         (tui_regs_layout): Reimplement.
3712         (tui_regs_layout_command): New function.
3713         (extract_display_start_addr): Rewrite.
3714         (next_layout, prev_layout): Remove.
3715         (tui_layout_window::replace_window): New method.
3716         (tui_layout_split::replace_window): New method.
3717         (destroy_layout): New function.
3718         (layout_list): New global.
3719         (add_layout_command): New function.
3720         (initialize_layouts): Update.
3721         (tui_layout_command): New function.
3722         (_initialize_tui_layout): Install "layout" commands.
3723         * tui/tui-data.h (enum tui_layout_type): Remove.
3724         (tui_current_layout): Don't declare.
3725
3726 2020-02-22  Tom Tromey  <tom@tromey.com>
3727
3728         * tui/tui-regs.c (tui_reg_layout): Remove.
3729         (tui_reg_command): Use tui_regs_layout.
3730         * tui/tui-layout.h (tui_reg_command): Declare.
3731         * tui/tui-layout.c (tui_reg_command): New function.
3732
3733 2020-02-22  Tom Tromey  <tom@tromey.com>
3734
3735         * tui/tui.c (tui_rl_delete_other_windows): Call
3736         tui_remove_some_windows.
3737         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
3738         Declare method.
3739         (class tui_layout_window) <remove_windows>: New method.
3740         (class tui_layout_split) <remove_windows>: Declare.
3741         (tui_remove_some_windows): Declare.
3742         * tui/tui-layout.c (tui_remove_some_windows): New function.
3743         (tui_layout_split::remove_windows): New method.
3744
3745 2020-02-22  Tom Tromey  <tom@tromey.com>
3746
3747         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
3748         * tui/tui-layout.h (tui_next_layout): Declare.
3749         * tui/tui-layout.c (tui_next_layout): New function.
3750
3751 2020-02-22  Tom Tromey  <tom@tromey.com>
3752
3753         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
3754         correct coordinates.
3755
3756 2020-02-22  Tom Tromey  <tom@tromey.com>
3757
3758         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
3759         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
3760         DATA_WIN case.
3761
3762 2020-02-22  Tom Tromey  <tom@tromey.com>
3763
3764         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
3765         TUI_DISASM_WIN, not tui_win_list.
3766
3767 2020-02-22  Tom Tromey  <tom@tromey.com>
3768
3769         * valprint.c (generic_val_print_enum_1)
3770         (val_print_type_code_flags): Style member names.
3771         * rust-lang.c (val_print_struct, rust_print_enum)
3772         (rust_print_struct_def, rust_internal_print_type): Style member
3773         names.
3774         * p-valprint.c (pascal_object_print_value_fields): Style member
3775         names.  Only call fprintf_symbol_filtered for static members.
3776         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
3777         * f-valprint.c (f_val_print): Style member names.
3778         * f-typeprint.c (f_type_print_base): Style member names.
3779         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
3780         call fprintf_symbol_filtered for static members.
3781         (cp_print_class_member): Style member names.
3782         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
3783         member names.
3784         * ada-valprint.c (ada_print_scalar): Style enum names.
3785         (ada_val_print_enum): Likewise.
3786         * ada-typeprint.c (print_enum_type): Style enum names.
3787
3788 2020-02-21  Tom Tromey  <tom@tromey.com>
3789
3790         * psympriv.h (struct partial_symtab): Update comment.
3791
3792 2020-02-21  Tom Tromey  <tromey@adacore.com>
3793
3794         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
3795         type is CORE_ADDR.
3796
3797 2020-02-21  Tom de Vries  <tdevries@suse.de>
3798
3799         PR gdb/25534
3800         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
3801         if dependencies[i]->user != NULL.
3802
3803 2020-02-21  Ali Tamur  <tamur@google.com>
3804
3805         * dwarf2/read.c (dwarf2_name): Add null check.
3806
3807 2020-02-20  Tom Tromey  <tom@tromey.com>
3808
3809         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
3810         ">=", in binary search.
3811         (dwarf2_find_containing_comp_unit): New overload.
3812         (run_test): New self-test.
3813         (_initialize_dwarf2_read): Register new test.
3814
3815 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
3816
3817         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
3818         * riscv-tdep.h: Likewise.
3819         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
3820         rv32-only CSR.
3821         * features/riscv/64bit-csr.xml: Regenerated.
3822
3823 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
3824             Tom Tromey  <tom@tromey.com>
3825
3826         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
3827         of 'fputc_unfiltered'.
3828         (putchar_unfiltered): Call 'fputc_unfiltered'.
3829         (fputc_unfiltered): Call 'fputs_unfiltered'.
3830
3831 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
3832
3833         * config.in: Regenerate.
3834         * configure: Regenerate.
3835         * configure.ac: Add --with-python-libdir option.
3836         * main.c: Use WITH_PYTHON_LIBDIR.
3837
3838 2020-02-19  Tom Tromey  <tom@tromey.com>
3839
3840         * symtab.c (general_symbol_info::compute_and_set_names): Use
3841         obstack_strndup.  Simplify call to symbol_set_demangled_name.
3842
3843 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
3844
3845         * dwarf2/read.c (allocate_signatured_type_table,
3846         allocate_dwo_unit_table, allocate_type_unit_groups_table,
3847         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
3848         Remove objfile parameter, update all callers.
3849
3850 2020-02-19  Doug Evans  <dje@google.com>
3851
3852         PR rust/25535
3853         * rust-lang.c (rust_print_enum): Apply embedded_offset to
3854         rust_enum_variant calculation.
3855
3856 2020-02-19  Tom Tromey  <tromey@adacore.com>
3857
3858         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
3859
3860 2020-02-19  Tom Tromey  <tromey@adacore.com>
3861
3862         * ada-lang.c (cache_symbol): Use obstack_strdup.
3863
3864 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3865
3866         * configure: Regenerate.
3867
3868 2020-02-19  Tom Tromey  <tromey@adacore.com>
3869
3870         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
3871         NULL check.
3872
3873 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
3874
3875         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
3876
3877 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3878
3879         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
3880         if GDBSERVER is not defined.
3881         (riscv_tdesc_cache): Likewise, also store const target_desc.
3882         (STATIC_IN_GDB): Define.
3883         (riscv_create_target_description): Update declaration with
3884         STATIC_IN_GDB.
3885         (riscv_lookup_target_description): New function, only define if
3886         GDBSERVER is not defined.
3887         * arch/riscv.h (riscv_create_target_description): Declare only
3888         when GDBSERVER is defined.
3889         (riscv_lookup_target_description): New declaration when GDBSERVER
3890         is not defined.
3891         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
3892         (riscv_linux_read_features): ...this, and return
3893         riscv_gdbarch_features instead of target_desc.
3894         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
3895         (riscv_linux_read_description): Rename to...
3896         (riscv_linux_read_features): ...this.
3897         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
3898         Update to use riscv_gdbarch_features and
3899         riscv_lookup_target_description.
3900         * riscv-tdep.c (riscv_find_default_target_description): Use
3901         riscv_lookup_target_description instead of
3902         riscv_create_target_description.
3903
3904 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3905
3906         * valprint.c (generic_val_print_enum_1): When printing a flag
3907         enum with value 0 and there is no enumerator with value 0, print
3908         just "0" instead of "(unknown: 0x0)".
3909
3910 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3911
3912         * valprint.c (generic_val_print_enum_1): Print unknown part of
3913         flag enum in hex.
3914
3915 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3916
3917         * dwarf2/read.c (update_enumeration_type_from_children): Allow
3918         flag enums to contain duplicate enumerators.
3919         * valprint.c (generic_val_print_enum_1): Update comment.
3920
3921 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3922
3923         * dwarf2/read.c: Include "count-one-bits.h".
3924         (update_enumeration_type_from_children): If an enumerator has
3925         multiple bits set, don't treat the enumeration as a "flag enum".
3926         * valprint.c (generic_val_print_enum_1): Assert that enumerators
3927         of flag enums have 0 or 1 bit set.
3928
3929 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3930
3931         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
3932         conversion.
3933         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
3934         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
3935         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
3936         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
3937         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
3938
3939 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3940
3941         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
3942
3943 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
3944
3945         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
3946         displaced_step_closure_up.
3947         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
3948         (struct displaced_step_closure_up):
3949         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
3950         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
3951         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
3952         Likewise.
3953         * gdbarch.sh (displaced_step_copy_insn): Likewise.
3954         * gdbarch.c, gdbarch.h: Re-generate.
3955         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
3956         displaced_step_closure_up.
3957         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
3958         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
3959         * infrun.h (displaced_step_closure_up): New type alias.
3960         (struct displaced_step_inferior_state) <step_closure>: Change
3961         type to displaced_step_closure_up.
3962         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
3963         displaced_step_closure_up.
3964         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
3965
3966 2020-02-14  Tom Tromey  <tom@tromey.com>
3967
3968         * minidebug.c (gnu_debug_key): New global.
3969         (find_separate_debug_file_in_section): Use it.
3970
3971 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
3972
3973         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
3974         std::unique_ptr.
3975         * gdbarch.c: Re-generate.
3976         * gdbarch.h: Re-generate.
3977         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
3978         change.
3979         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
3980         type to std::unique_ptr.
3981         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
3982         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
3983         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
3984         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
3985         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
3986         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
3987         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
3988         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
3989         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
3990
3991 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
3992
3993         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
3994         std::unique_ptr.
3995         (displaced_step_clear): Rename to...
3996         (displaced_step_reset): ... this.  Just call displaced->reset ().
3997         (displaced_step_clear_cleanup): Rename to...
3998         (displaced_step_reset_cleanup): ... this.
3999         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
4000         (displaced_step_fixup): Likewise.
4001         (resume_1): Likewise.
4002         (handle_inferior_event): Restore child's memory before calling
4003         displaced_step_fixup on the parent.
4004         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
4005         to std::unique_ptr.
4006         <step_closure>: Change type to std::unique_ptr.
4007
4008 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4009
4010         * arm-tdep.c: Include count-one-bits.h.
4011         (cleanup_block_store_pc): Use count_one_bits.
4012         (cleanup_block_load_pc): Use count_one_bits.
4013         (arm_copy_block_xfer): Use count_one_bits.
4014         (thumb2_copy_block_xfer): Use count_one_bits.
4015         (thumb_copy_pop_pc_16bit): Use count_one_bits.
4016         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
4017         (thumb_get_next_pcs_raw): Use count_one_bits.
4018         (arm_get_next_pcs_raw): Use count_one_bits_l.
4019         * arch/arm.c (bitcount): Remove.
4020         * arch/arm.h (bitcount): Remove.
4021
4022 2020-02-14  Tom Tromey  <tromey@adacore.com>
4023
4024         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
4025         Update.
4026         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
4027         * dwarf2/loc.c (call_site_find_chain_1): Return
4028         unique_xmalloc_ptr.
4029         (call_site_find_chain): Likewise.
4030
4031 2020-02-14  Richard Biener  <rguenther@suse.de>
4032
4033         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
4034         on expression with division operators.
4035
4036 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
4037
4038         * MAINTAINERS (Write After Approval): Adding myself.
4039
4040 2020-02-12  Tom Tromey  <tom@tromey.com>
4041
4042         * event-loop.c (event_data, gdb_event, event_handler_func):
4043         Remove.
4044
4045 2020-02-12  Tom Tromey  <tom@tromey.com>
4046
4047         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
4048         (dwarf2_frame_objfile_data): Add comment.
4049         (find_comp_unit, set_comp_unit): New functions.
4050         (dwarf2_frame_find_fde): Use find_comp_unit.
4051         (dwarf2_build_frame_info): Use set_comp_unit.
4052
4053 2020-02-12  Tom Tromey  <tom@tromey.com>
4054
4055         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
4056         (comp_unit): Don't initialize objfile.
4057         (execute_cfa_program): Add text_offset parameter.
4058         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
4059         (dwarf2_frame_cache): Update.
4060         (dwarf2_build_frame_info): Don't set "objfile" member.
4061
4062 2020-02-12  Tom Tromey  <tom@tromey.com>
4063
4064         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
4065         (decode_frame_entry): Likewise.
4066         (dwarf2_build_frame_info): Update.
4067
4068 2020-02-12  Tom Tromey  <tom@tromey.com>
4069
4070         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
4071         (decode_frame_entry_1): Use the comp_unit obstack.
4072
4073 2020-02-12  Tom Tromey  <tom@tromey.com>
4074
4075         * dwarf2/frame.c (struct comp_unit): Add initializers and
4076         constructor.
4077         (dwarf2_frame_objfile_data): Store a comp_unit.
4078         (dwarf2_frame_find_fde): Update.
4079         (dwarf2_build_frame_info): Use "new".
4080
4081 2020-02-12  Tom Tromey  <tom@tromey.com>
4082
4083         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
4084         (dwarf2_fde_table): Typedef for std::vector.
4085         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
4086         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
4087         (decode_frame_entry): Update.
4088         (dwarf2_build_frame_info): Use "new".
4089
4090 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
4091
4092         * arm-tdep.c (arm_gdbarch_init): Update.
4093         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
4094         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
4095         have_neon, is_m>: Change to bool.
4096
4097 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
4098
4099         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
4100
4101 2020-02-12  Tom Tromey  <tom@tromey.com>
4102
4103         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
4104
4105 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
4106
4107         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
4108         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
4109
4110 2020-02-11  Tom Tromey  <tom@tromey.com>
4111
4112         * psymtab.h: Update comment.
4113
4114 2020-02-11  Tom Tromey  <tom@tromey.com>
4115
4116         * gdb_obstack.h (struct auto_obstack): Use
4117         DISABLE_COPY_AND_ASSIGN.
4118
4119 2020-02-11  Tom Tromey  <tom@tromey.com>
4120
4121         * dwarf2/frame.h (struct objfile): Don't forward declare.
4122
4123 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4124
4125         * cris-tdep.c (cris_supply_gregset): Change signature to match
4126         what struct regset expects.
4127         (cris_regset): New struct.
4128         (fetch_core_registers): Remove.
4129         (cris_iterate_over_regset_sections): New function.
4130         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
4131         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
4132
4133 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4134
4135         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
4136         registers.
4137
4138 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4139
4140         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
4141
4142 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4143
4144         * configure: Re-generate.
4145
4146 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4147
4148         * configure: Re-generate.
4149
4150 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4151
4152         * acinclude: Update warning.m4 path.
4153         * warning.m4: Move to gdbsupport.
4154
4155 2020-02-11  Tom Tromey  <tromey@adacore.com>
4156
4157         * remote.c (remote_console_output): Update.
4158         * printcmd.c (printf_command): Update.
4159         * event-loop.c (gdb_wait_for_event): Update.
4160         * linux-nat.c (sigchld_handler): Update.
4161         * remote-sim.c (gdb_os_write_stdout): Update.
4162         (gdb_os_flush_stdout): Update.
4163         (gdb_os_flush_stderr): Update.
4164         (gdb_os_write_stderr): Update.
4165         * exceptions.c (print_exception): Update.
4166         * remote-fileio.c (remote_fileio_func_read): Update.
4167         (remote_fileio_func_write): Update.
4168         * tui/tui.c (tui_enable): Update.
4169         * tui/tui-interp.c (tui_interp::init): Update.
4170         * utils.c (init_page_info): Update.
4171         (putchar_unfiltered, fputc_unfiltered): Update.
4172         (gdb_flush): Update.
4173         (emit_style_escape): Update.
4174         (flush_wrap_buffer, fputs_maybe_filtered): Update.
4175         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
4176         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
4177         (stderr_file::write): Update.
4178         (stderr_file::puts): Update.
4179         * ui-file.h (ui_file_isatty, ui_file_write)
4180         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
4181         (ui_file_puts): Don't declare.
4182
4183 2020-02-10  Tom de Vries  <tdevries@suse.de>
4184
4185         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
4186         sentinel to char *.
4187
4188 2020-02-09  Tom de Vries  <tdevries@suse.de>
4189
4190         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
4191         filename if it matches "<artificial>".
4192
4193 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4194
4195         * windows-tdep.c (struct enum_value_name): New struct.
4196         (create_enum): New function.
4197         (windows_get_siginfo_type): Create and use enum types.
4198
4199 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4200
4201         * NEWS: Mention $_siginfo support for Windows.
4202         * windows-nat.c (handle_exception): Set siginfo_er.
4203         (windows_nat_target::mourn_inferior): Reset siginfo_er.
4204         (windows_xfer_siginfo): New function.
4205         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
4206         * windows-tdep.c (struct windows_gdbarch_data): New struct.
4207         (init_windows_gdbarch_data): New function.
4208         (get_windows_gdbarch_data): New function.
4209         (windows_get_siginfo_type): New function.
4210         (windows_init_abi): Register windows_get_siginfo_type.
4211         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
4212
4213 2020-02-08  Tom Tromey  <tom@tromey.com>
4214
4215         * dwarf2/read.c (class cutu_reader) <cutu_reader,
4216         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
4217         <keep>: Declare method.
4218         <m_keep>: Remove member.
4219         <~cutu_reader>: Remove.
4220         (cutu_reader::init_tu_and_read_dwo_dies): Update.
4221         (cutu_reader::cutu_reader): Update.
4222         (cutu_reader::keep): Rename from ~cutu_reader.
4223         (process_psymtab_comp_unit, build_type_psymtabs_1)
4224         (process_skeletonless_type_unit, load_partial_comp_unit)
4225         (load_full_comp_unit, dwarf2_read_addr_index)
4226         (read_signatured_type): Update.
4227
4228 2020-02-08  Tom Tromey  <tom@tromey.com>
4229
4230         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
4231         "want_partial_unit" parameter.
4232         (process_psymtab_comp_unit): Change want_partial_unit to bool.
4233         Inline check for DW_TAG_partial_unit.
4234         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
4235
4236 2020-02-08  Tom Tromey  <tom@tromey.com>
4237
4238         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
4239         read.c.
4240         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
4241         read.c.
4242
4243 2020-02-08  Tom Tromey  <tom@tromey.com>
4244
4245         * dwarf2/read.c (read_address): Move to comp-unit.c.
4246         (dwarf2_rnglists_process, dwarf2_ranges_process)
4247         (read_attribute_value, dwarf_decode_lines_1)
4248         (var_decode_location, decode_locdesc): Update.
4249         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
4250         read.c.  Remove "cu" parameter.
4251         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
4252         method.
4253
4254 2020-02-08  Tom Tromey  <tom@tromey.com>
4255
4256         * dwarf2/read.c (read_attribute_value, read_indirect_string)
4257         (read_indirect_line_string): Update.
4258         * dwarf2/comp-unit.c (read_offset): Remove.
4259         (read_comp_unit_head): Update.
4260         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
4261         method.
4262         (read_offset): Don't declare.
4263
4264 2020-02-08  Tom Tromey  <tom@tromey.com>
4265
4266         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
4267         * dwarf2/read.c (struct comp_unit_head): Move to
4268         dwarf2/comp-unit.h.
4269         (enum class rcuh_kind): Move to comp-unit.h.
4270         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
4271         (read_comp_unit_head, error_check_comp_unit_head)
4272         (read_and_check_comp_unit_head): Move to comp-unit.c.
4273         (read_offset, dwarf_unit_type_name): Likewise.
4274         (create_debug_type_hash_table, read_cutu_die_from_dwo)
4275         (cutu_reader::cutu_reader, read_call_site_scope)
4276         (find_partial_die, follow_die_offset): Update.
4277         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
4278
4279 2020-02-08  Tom Tromey  <tom@tromey.com>
4280
4281         * dwarf2/read.c (read_offset_1): Move to leb.c.
4282         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
4283         (dwarf_decode_macro_bytes): Update.
4284         * dwarf2/leb.c (read_offset): Rename; move from read.c.
4285         * dwarf2/leb.h (read_offset): Declare.
4286
4287 2020-02-08  Tom Tromey  <tom@tromey.com>
4288
4289         * dwarf2/read.c (dwarf2_section_size): Remove.
4290         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
4291         Update.
4292         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
4293
4294 2020-02-08  Tom Tromey  <tom@tromey.com>
4295
4296         * dwarf2/read.c (read_initial_length): Move to leb.c.
4297         * dwarf2/leb.h (read_initial_length): Declare.
4298         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
4299         handle_nonstd parameter.
4300         * dwarf2/frame.c (read_initial_length): Remove.
4301         (decode_frame_entry_1): Update.
4302
4303 2020-02-08  Tom Tromey  <tom@tromey.com>
4304
4305         * dwarf2/loc.c (dwarf2_find_location_expression)
4306         (dwarf_evaluate_loc_desc::get_tls_address)
4307         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
4308         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
4309         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
4310         (dwarf2_compile_property_to_c)
4311         (dwarf2_loc_desc_get_symbol_read_needs)
4312         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
4313         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
4314         (loclist_describe_location, loclist_tracepoint_var_ref)
4315         (loclist_generate_c_location): Update.
4316         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
4317         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
4318         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
4319         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
4320         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
4321         (dwarf2_per_cu_data::addr_size)
4322         (dwarf2_per_cu_data::ref_addr_size)
4323         (dwarf2_per_cu_data::text_offset)
4324         (dwarf2_per_cu_data::addr_type): Now methods.
4325         (per_cu_header_read_in): Make per_cu "const".
4326         (dwarf2_version): Remove.
4327         (dwarf2_per_cu_data::int_type): Now a method.
4328         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
4329         (set_die_type, read_array_type, read_subrange_index_type)
4330         (read_tag_string_type, read_subrange_type): Update.
4331         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
4332         offset_size, ref_addr_size, text_offset, addr_type, version,
4333         objfile, int_type, addr_sized_int_type>: Declare methods.
4334
4335 2020-02-08  Tom Tromey  <tom@tromey.com>
4336
4337         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
4338         Move earlier.
4339
4340 2020-02-08  Tom Tromey  <tom@tromey.com>
4341
4342         * dwarf2/read.h (dwarf_line_debug): Declare.
4343         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
4344         * dwarf2/read.c: Move line_header code to new files.
4345         (dwarf_line_debug): No longer static.
4346         * dwarf2/line-header.c: New file.
4347         * dwarf2/line-header.h: New file.
4348
4349 2020-02-08  Tom Tromey  <tom@tromey.com>
4350
4351         * dwarf2/read.c (struct line_header) <file_full_name,
4352         file_file_name>: Return unique_xmalloc_ptr.
4353         (line_header::file_file_name): Update.
4354         (line_header::file_full_name): Update.
4355         (dw2_get_file_names_reader): Update.
4356         (macro_start_file): Update.
4357
4358 2020-02-08  Tom Tromey  <tom@tromey.com>
4359
4360         * dwarf2/read.c (struct line_header) <file_full_name,
4361         file_file_name>: Declare methods.
4362         (dw2_get_file_names_reader): Update.
4363         (file_file_name): Now a method.
4364         (file_full_name): Likewise.
4365         (macro_start_file): Update.
4366
4367 2020-02-08  Tom Tromey  <tom@tromey.com>
4368
4369         * dwarf2/read.c (dwarf_always_disassemble)
4370         (show_dwarf_always_disassemble): Move to loc.c.
4371         (_initialize_dwarf2_read): Move "always-disassemble" registration
4372         to loc.c.
4373         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
4374         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
4375         static.
4376         (show_dwarf_always_disassemble): Move from read.c.
4377         (_initialize_dwarf2loc): Move always-disassemble from read.c.
4378
4379 2020-02-08  Tom Tromey  <tom@tromey.com>
4380
4381         * dwarf2/read.c (~dwarf2_per_objfile): Update.
4382         (create_quick_file_names_table): Return htab_up.
4383         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
4384         Update.
4385         * dwarf2/read.h (struct dwarf2_per_objfile)
4386         <quick_file_names_table>: Now htab_up.
4387
4388 2020-02-08  Tom Tromey  <tom@tromey.com>
4389
4390         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
4391
4392 2020-02-08  Tom Tromey  <tom@tromey.com>
4393
4394         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
4395         Rewrite.
4396         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
4397         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
4398         (abbrev_table::abbrev_table): No longer inline.
4399         (ABBREV_HASH_SIZE): Remove.
4400         (abbrev_table::m_abbrevs): Now an htab_up.
4401
4402 2020-02-08  Tom Tromey  <tom@tromey.com>
4403
4404         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
4405         (cutu_reader): Update.
4406         (build_type_psymtabs_1): Update.
4407         * dwarf2/abbrev.c (abbrev_table::read): Rename.
4408         (abbrev_table::alloc_abbrev): Update.
4409         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
4410         (abbrev_table::read): New static method, renamed from
4411         abbrev_table_read_table.
4412         (abbrev_table::alloc_abbrev)
4413         (abbrev_table::add_abbrev): Now private.
4414         (abbrev_table::abbrev_table): Now private.
4415         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
4416
4417 2020-02-08  Tom Tromey  <tom@tromey.com>
4418
4419         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
4420         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
4421         htab_up.
4422
4423 2020-02-08  Tom Tromey  <tom@tromey.com>
4424
4425         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
4426         htab_up.
4427         (lookup_dwo_unit_in_dwp): Update.
4428         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
4429         on obstack.
4430
4431 2020-02-08  Tom Tromey  <tom@tromey.com>
4432
4433         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
4434         obstack.
4435
4436 2020-02-08  Tom Tromey  <tom@tromey.com>
4437
4438         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
4439         line_header_hash.
4440         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
4441         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
4442         Change type to htab_up.
4443
4444 2020-02-08  Tom Tromey  <tom@tromey.com>
4445
4446         * dwarf2/read.c (allocate_type_unit_groups_table): Return
4447         htab_up.  Don't allocate on obstack.
4448         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
4449         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
4450         Change type to htab_up.
4451
4452 2020-02-08  Tom Tromey  <tom@tromey.com>
4453
4454         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
4455         Change type to htab_up.
4456         * dwarf2/read.c (create_signatured_type_table_from_index)
4457         (create_signatured_type_table_from_debug_names)
4458         (create_all_type_units, add_type_unit)
4459         (lookup_dwo_signatured_type, lookup_signatured_type)
4460         (process_skeletonless_type_unit): Update.
4461         (create_debug_type_hash_table, create_debug_types_hash_table):
4462         Change type of types_htab.
4463         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
4464         htab_up.  Don't allocate on obstack.
4465         (create_cus_hash_table): Change type of cus_htab parameter.
4466         (struct dwo_file) <cus, tus>: Now htab_up.
4467         (lookup_dwo_signatured_type, lookup_dwo_cutu)
4468         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
4469         (queue_and_load_all_dwo_tus): Update.
4470         * dwarf2/index-write.c (write_gdbindex): Update.
4471         (write_debug_names): Update.
4472
4473 2020-02-08  Tom Tromey  <tom@tromey.com>
4474
4475         * dwarf2/read.h (struct dwarf2_queue_item): Move from
4476         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
4477         destructor.
4478         (struct dwarf2_per_objfile) <queue>: New member.
4479         * dwarf2/read.c (struct dwarf2_queue_item): Move to
4480         dwarf2/read.h.
4481         (dwarf2_queue, dwarf2_queue_tail): Remove.
4482         (class dwarf2_queue_guard): Add parameter to constructor.  Use
4483         DISABLE_COPY_AND_ASSIGN.
4484         <m_per_objfile>: New member.
4485         <~dwarf2_queue_guard>: Rewrite.
4486         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
4487         Update.
4488         (~dwarf2_queue_item): New.
4489
4490 2020-02-08  Tom Tromey  <tom@tromey.com>
4491
4492         * dwarf2/read.c (struct die_info) <has_children>: New member.
4493         (dw2_get_file_names_reader): Remove has_children.
4494         (dw2_get_file_names): Update.
4495         (read_cutu_die_from_dwo): Remove has_children.
4496         (cutu_reader::init_tu_and_read_dwo_dies)
4497         (cutu_reader::cutu_reader): Update.
4498         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
4499         Remove has_children.
4500         (build_type_psymtabs_1, process_skeletonless_type_unit)
4501         (load_partial_comp_unit, load_full_comp_unit): Update.
4502         (create_dwo_cu_reader): Remove has_children.
4503         (create_cus_hash_table, read_die_and_children): Update.
4504         (read_full_die_1,read_full_die): Remove has_children.
4505         (read_signatured_type): Update.
4506         (class cutu_reader) <has_children>: Remove.
4507
4508 2020-02-08  Tom Tromey  <tom@tromey.com>
4509
4510         * dwarf2/expr.c: Rename from dwarf2expr.c.
4511         * dwarf2/expr.h: Rename from dwarf2expr.h.
4512         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
4513         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
4514         * dwarf2/frame.c: Rename from dwarf2-frame.c.
4515         * dwarf2/frame.h: Rename from dwarf2-frame.h.
4516         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
4517         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
4518         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
4519         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
4520         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
4521         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
4522         * dwarf2/loc.c: Rename from dwarf2loc.c.
4523         * dwarf2/loc.h: Rename from dwarf2loc.h.
4524         * dwarf2/read.c: Rename from dwarf2read.c.
4525         * dwarf2/read.h: Rename from dwarf2read.h.
4526         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
4527         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
4528         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
4529         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
4530         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
4531         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
4532         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
4533         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
4534         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
4535         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
4536         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
4537         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
4538         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
4539         Update.
4540         * Makefile.in (COMMON_SFILES): Update.
4541         (HFILES_NO_SRCDIR): Update.
4542
4543 2020-02-08  Tom Tromey  <tom@tromey.com>
4544
4545         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
4546         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
4547
4548 2020-02-08  Tom Tromey  <tom@tromey.com>
4549
4550         * dwarf2read.h (struct die_info): Don't declare.
4551
4552 2020-02-08  Tom Tromey  <tom@tromey.com>
4553
4554         * dwarf2read.h (die_info_ptr): Remove typedef.
4555
4556 2020-02-08  Tom Tromey  <tom@tromey.com>
4557
4558         * dwarf2read.c (read_call_site_scope)
4559         (handle_data_member_location, dwarf2_add_member_fn)
4560         (mark_common_block_symbol_computed, read_common_block)
4561         (attr_to_dynamic_prop, partial_die_info::read)
4562         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
4563         (dwarf2_symbol_mark_computed, set_die_type): Update.
4564         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
4565         method.
4566         (attr_form_is_block): Don't declare.
4567         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
4568
4569 2020-02-08  Tom Tromey  <tom@tromey.com>
4570
4571         * dwarf2read.c (dwarf2_find_base_address, )
4572         (read_call_site_scope, rust_containing_type)
4573         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
4574         (handle_data_member_location, dwarf2_add_member_fn)
4575         (get_alignment, read_structure_type, process_structure_scope)
4576         (mark_common_block_symbol_computed, read_common_block)
4577         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
4578         (partial_die_info::read, read_attribute_value, new_symbol)
4579         (lookup_die_type, dwarf2_get_ref_die_offset)
4580         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
4581         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
4582         (dwarf2_symbol_mark_computed): Update.
4583         * dwarf2/attribute.h (struct attribute) <value_as_address,
4584         form_is_section_offset, form_is_constant, form_is_ref>: Declare
4585         methods.
4586         (value_as_address, attr_form_is_section_offset)
4587         (attr_form_is_constant, attr_form_is_ref): Don't declare.
4588         * dwarf2/attribute.c (attribute::value_as_address)
4589         (attribute::form_is_section_offset, attribute::form_is_constant)
4590         (attribute::form_is_ref): Now methods.
4591
4592 2020-02-08  Tom Tromey  <tom@tromey.com>
4593
4594         * dwarf2read.c (struct attribute, DW_STRING)
4595         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
4596         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
4597         (attr_form_is_block, attr_form_is_section_offset)
4598         (attr_form_is_constant, attr_form_is_ref): Move.
4599         * dwarf2/attribute.h: New file.
4600         * dwarf2/attribute.c: New file, from dwarf2read.c.
4601         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
4602
4603 2020-02-08  Tom Tromey  <tom@tromey.com>
4604
4605         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
4606         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
4607         Move.
4608         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
4609         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
4610         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
4611         abbrev.c.
4612         * dwarf2/abbrev.h: New file.
4613         * dwarf2/abbrev.c: New file, from dwarf2read.c.
4614         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
4615
4616 2020-02-08  Tom Tromey  <tom@tromey.com>
4617
4618         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
4619         (dwarf2_section_size, dwarf2_get_section_info)
4620         (create_signatured_type_table_from_debug_names)
4621         (create_addrmap_from_aranges, read_debug_names_from_section)
4622         (get_gdb_index_contents_from_section, read_comp_unit_head)
4623         (error_check_comp_unit_head, read_abbrev_offset)
4624         (create_debug_type_hash_table, init_cu_die_reader)
4625         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
4626         (read_comp_units_from_section, create_cus_hash_table)
4627         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
4628         (create_dwp_v2_section, dwarf2_rnglists_process)
4629         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
4630         (abbrev_table_read_table, read_indirect_string_at_offset_from)
4631         (read_indirect_string_from_dwz, read_addr_index_1)
4632         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
4633         (dwarf_decode_macro_bytes, dwarf_decode_macros)
4634         (fill_in_loclist_baton): Update.
4635         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
4636         get_containing_section, get_bfd_owner, get_bfd_section,
4637         get_file_name, get_id, get_flags, empty, read>: Declare methods.
4638         (dwarf2_read_section, get_section_name, get_section_file_name)
4639         (get_containing_section, get_section_bfd_owner)
4640         (get_section_bfd_section, get_section_name, get_section_file_name)
4641         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
4642         declare.
4643         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
4644         (dwarf2_section_info::get_bfd_owner)
4645         (dwarf2_section_info::get_bfd_section)
4646         (dwarf2_section_info::get_name)
4647         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
4648         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
4649         (dwarf2_section_info::read): Now methods.
4650         * dwarf-index-write.c (class debug_names): Update.
4651
4652 2020-02-08  Tom Tromey  <tom@tromey.com>
4653
4654         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
4655         Move to dwarf2/section.h.
4656         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
4657         (get_section_bfd_section, get_section_name)
4658         (get_section_file_name, get_section_id, get_section_flags)
4659         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
4660         dwarf2/section.c.
4661         * dwarf2/section.h: New file.
4662         * dwarf2/section.c: New file, from dwarf2read.c.
4663         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
4664
4665 2020-02-08  Tom Tromey  <tom@tromey.com>
4666
4667         * dwarf2read.h (read_unsigned_leb128): Don't declare.
4668         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
4669         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
4670         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
4671         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
4672         * dwarf2/leb.h: New file, from dwarf2read.c.
4673         * dwarf2/leb.c: New file, from dwarf2read.c.
4674         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
4675         Remove.
4676         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
4677         (COMMON_SFILES): Add dwarf2/leb.c.
4678
4679 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
4680
4681         GDB 9.1 released.
4682
4683 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
4684
4685         PR gdb/25190:
4686         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
4687         * gdb/remote.c (remote_console_output): Update.
4688         * gdb/ui-file.c (fputs_unfiltered): Rename to...
4689         (ui_file_puts): ...this.
4690         * gdb/ui-file.h (ui_file_puts): Add declaration.
4691         * gdb/utils.c (emit_style_escape): Update.
4692         (flush_wrap_buffer): Update.
4693         (fputs_maybe_filtered): Update.
4694         (fputs_unfiltered): Add function.
4695
4696 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
4697
4698         * gdb/event-loop.c (gdb_wait_for_event): Update.
4699         * gdb/printcmd.c (printf_command): Update.
4700         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
4701         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
4702         (gdb_os_flush_stderr): Update.
4703         * gdb/remote.c (remote_console_output): Update.
4704         * gdb/ui-file.c (gdb_flush): Rename to...
4705         (ui_file_flush): ...this.
4706         (stderr_file::write): Update.
4707         (stderr_file::puts): Update.
4708         * gdb/ui-file.h (gdb_flush): Rename to...
4709         (ui_file_flush): ...this.
4710         * gdb/utils.c (gdb_flush): Add function.
4711         * gdb/utils.h (gdb_flush): Add declaration.
4712
4713 2020-02-07  Tom Tromey  <tromey@adacore.com>
4714
4715         PR breakpoints/24915:
4716         * source.c (find_and_open_source): Do not check basenames_may_differ.
4717
4718 2020-02-07  Tom Tromey  <tom@tromey.com>
4719
4720         * README: Update gdbserver documentation.
4721         * gdbserver: Move to top level.
4722         * configure.tgt (build_gdbserver): Remove.
4723         * configure.ac: Remove --enable-gdbserver.
4724         * configure: Rebuild.
4725         * Makefile.in (distclean): Don't mention gdbserver.
4726
4727 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
4728
4729         * source-cache.c (source_cache::ensure): Surround
4730         get_plain_source_lines with a try/catch.
4731         (source_cache::get_line_charpos): Get rid of try/catch
4732         and only check for the return value of "ensure".
4733         * tui/tui-source.c (tui_source_window::set_contents):
4734         Simplify "nlines" calculation.
4735
4736 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
4737
4738         * MAINTAINERS (Write After Approval): Add myself.
4739
4740 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
4741
4742         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
4743         function call.
4744
4745 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
4746
4747         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
4748
4749 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
4750
4751         * nat/riscv-linux-tdesc.h: New file.
4752         * nat/riscv-linux-tdesc.c: New file, taking code from...
4753         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
4754         ... here.
4755         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
4756         NATDEPFILES.
4757
4758 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
4759
4760         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
4761         we don't set the fake simulator ptid to the null_ptid.
4762
4763 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
4764
4765         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
4766         * gdbthread.h (class thread_info) <resumed>: Likewise.
4767         * infrun.c (resume_1): Likewise.
4768         (proceed): Likewise.
4769         (infrun_thread_stop_requested): Likewise.
4770         (stop_all_threads): Likewise.
4771         (handle_inferior_event): Likewise.
4772         (restart_threads): Likewise.
4773         (finish_step_over): Likewise.
4774         (keep_going_stepped_thread): Likewise.
4775         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
4776         (linux_handle_extended_wait): Likewise.
4777         * record-btrace.c (get_thread_current_frame_id): Likewise.
4778         * record-full.c (record_full_wait_1): Likewise.
4779         * remote.c (remote_target::process_initial_stop_replies): Likewise.
4780         * target.c (target_resume): Likewise.
4781         * thread.c (set_running_thread): Likewise.
4782
4783 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
4784
4785         * f-valprint.c (f77_print_array_1): Changed datatype of index
4786         variable to LONGEST from int to enable it to contain bound
4787         values correctly.
4788
4789 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
4790
4791         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
4792         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
4793         offsets according to FLEN determined.
4794         (riscv_linux_nat_target::read_description): Determine FLEN
4795         dynamically.
4796         (riscv_linux_nat_target::fetch_registers): Size regset buffer
4797         according to FLEN determined.
4798         (riscv_linux_nat_target::store_registers): Likewise.
4799
4800 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
4801
4802         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
4803         when reg->group is empty and reggroup is not.
4804
4805 2020-01-31  Tom Tromey  <tromey@adacore.com>
4806
4807         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
4808         Call beneath target's mourn_inferior after unpushing.
4809
4810 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
4811
4812         PR tui/9765
4813         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
4814         have enough lines to fill the screen, still return the lowest
4815         address we found.
4816
4817 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
4818
4819         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
4820         '-', '<', and '>' commands.
4821
4822 2020-01-29  Pedro Alves  <palves@redhat.com>
4823             Sergio Durigan Junior  <sergiodj@redhat.com>
4824
4825         * infcmd.c (construct_inferior_arguments): Assert that
4826         'argc' is greater than 0.
4827
4828 2020-01-29  Luis Machado  <luis.machado@linaro.org>
4829
4830         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
4831         (BRK_INSN_MASK): Define to 0xd4200000.
4832         (aarch64_program_breakpoint_here_p): New function.
4833         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
4834         * arch-utils.c (default_program_breakpoint_here_p): Moved from
4835         breakpoint.c.
4836         * arch-utils.h (default_program_breakpoint_here_p): Moved from
4837         breakpoint.h
4838         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
4839         call gdbarch_program_breakpoint_here_p.
4840         (program_breakpoint_here): Moved to arch-utils.c, renamed to
4841         default_program_breakpoint_here_p, changed return type to bool and
4842         simplified.
4843         * breakpoint.h (program_breakpoint_here): Moved prototype to
4844         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
4845         return type to bool.
4846         * gdbarch.c: Regenerate.
4847         * gdbarch.h: Regenerate.
4848         * gdbarch.sh (program_breakpoint_here_p): New method.
4849         * infrun.c (handle_signal_stop): Call
4850         gdbarch_program_breakpoint_here_p.
4851
4852 2020-01-26  Tom Tromey  <tom@tromey.com>
4853
4854         * ctfread.c (struct ctf_fp_info): Reindent.
4855         (_initialize_ctfread): Remove.
4856
4857 2020-01-26  Tom Tromey  <tom@tromey.com>
4858
4859         * psymtab.c (partial_map_expand_apply)
4860         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
4861         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
4862         (psym_print_stats, psym_expand_symtabs_for_function)
4863         (psym_map_symbol_filenames, psym_map_matching_symbols)
4864         (psym_expand_symtabs_matching)
4865         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
4866         (maintenance_check_psymtabs): Use new methods.
4867         * psympriv.h (struct partial_symtab) <readin_p,
4868         get_compunit_symtab>: New methods.
4869         <readin, compunit_symtab>: Remove members.
4870         (struct standard_psymtab): New.
4871         (struct legacy_psymtab): Derive from standard_psymtab.
4872         * dwarf2read.h (struct dwarf2_psymtab): Derive from
4873         standard_psymtab.
4874         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
4875
4876 2020-01-26  Tom Tromey  <tom@tromey.com>
4877
4878         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
4879         read_dependencies.  Add assert.
4880         * psymtab.c (partial_symtab::read_dependencies): New method.
4881         * psympriv.h (struct partial_symtab) <read_dependencies>: New
4882         method.
4883         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
4884         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
4885         read_dependencies.
4886         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
4887         Add assert.
4888
4889 2020-01-26  Tom Tromey  <tom@tromey.com>
4890
4891         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
4892         Call expand_psymtab.
4893         (xcoff_read_symtab): Call expand_psymtab.
4894         (xcoff_start_psymtab, xcoff_end_psymtab): Set
4895         legacy_expand_psymtab.
4896         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
4897         method.
4898         (struct legacy_psymtab) <expand_psymtab>: Implement.
4899         <legacy_expand_psymtab>: New member.
4900         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
4901         (parse_partial_symbols): Set legacy_expand_psymtab.
4902         (psymtab_to_symtab_1): Change argument order.  Call
4903         expand_psymtab.
4904         (new_psymtab): Set legacy_expand_psymtab.
4905         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
4906         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
4907         expand_psymtab.
4908         (dwarf2_psymtab::expand_psymtab): Rename from
4909         psymtab_to_symtab_1.  Call expand_psymtab.
4910         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
4911         (dbx_end_psymtab): Likewise.
4912         (dbx_psymtab_to_symtab_1): Change argument order. Call
4913         expand_psymtab.
4914         (dbx_read_symtab): Call expand_psymtab.
4915         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
4916         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
4917         (ctf_psymtab::read_symtab): Call expand_psymtab.
4918
4919 2020-01-26  Tom Tromey  <tom@tromey.com>
4920
4921         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
4922         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
4923         messages.
4924         * mdebugread.c (mdebug_read_symtab): Remove prints.
4925         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
4926         assert.
4927         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
4928
4929 2020-01-26  Tom Tromey  <tom@tromey.com>
4930
4931         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
4932         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
4933         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
4934         legacy_symtab.
4935         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
4936         * psymtab.c (psymtab_to_symtab): Call method.
4937         (dump_psymtab): Update.
4938         * psympriv.h (struct partial_symtab): Add virtual destructor.
4939         <read_symtab>: New method.
4940         (struct legacy_symtab): New.
4941         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
4942         (struct pst_map) <pst>: Now a legacy_psymtab.
4943         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
4944         (new_psymtab): Use legacy_psymtab.
4945         * dwarf2read.h (struct dwarf2_psymtab): New.
4946         (struct dwarf2_per_cu_data) <psymtab>: Use it.
4947         * dwarf2read.c (dwarf2_create_include_psymtab)
4948         (dwarf2_build_include_psymtabs, create_type_unit_group)
4949         (create_partial_symtab, process_psymtab_comp_unit_reader)
4950         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
4951         (set_partial_user): Use dwarf2_psymtab.
4952         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
4953         (psymtab_to_symtab_1, process_full_comp_unit)
4954         (process_full_type_unit, dwarf2_ranges_read)
4955         (dwarf2_get_pc_bounds, psymtab_include_file_name)
4956         (dwarf_decode_lines): Use dwarf2_psymtab.
4957         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
4958         (add_address_entry_worker, write_one_signatured_type)
4959         (recursively_count_psymbols, recursively_write_psymbols)
4960         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
4961         (write_debug_names): Likewise.
4962         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
4963         <pst>: Now a legacy_psymtab.
4964         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
4965         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
4966         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
4967         * ctfread.c (struct ctf_psymtab): New.
4968         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
4969         ctf_psymtab.
4970         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
4971         (create_partial_symtab): Return a ctf_psymtab.
4972         (scan_partial_symbols): Update.
4973
4974 2020-01-26  Tom Tromey  <tom@tromey.com>
4975
4976         * xcoffread.c (xcoff_start_psymtab): Use new.
4977         * psymtab.c (partial_symtab::partial_symtab): New constructor,
4978         renamed from start_psymtab_common.
4979         * psympriv.h (struct partial_symtab): Add new constructor.
4980         (start_psymtab_common): Don't declare.
4981         * mdebugread.c (parse_partial_symbols): Use new.
4982         * dwarf2read.c (create_partial_symtab): Use new.
4983         * dbxread.c (start_psymtab): Use new.
4984         * ctfread.c (create_partial_symtab): Use new.
4985
4986 2020-01-26  Tom Tromey  <tom@tromey.com>
4987
4988         * xcoffread.c (xcoff_end_psymtab): Use new.
4989         * psymtab.c (start_psymtab_common): Use new.
4990         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
4991         Update.
4992         * psympriv.h (struct partial_symtab): Add parameters to
4993         constructor.  Don't inline.
4994         (allocate_psymtab): Don't declare.
4995         * mdebugread.c (new_psymtab): Use new.
4996         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
4997         * dbxread.c (dbx_end_psymtab): Use new.
4998
4999 2020-01-26  Tom Tromey  <tom@tromey.com>
5000
5001         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
5002         allocate_psymtab.  Update documentation.
5003         * psymtab.c (psymtab_storage::install_psymtab): Rename from
5004         allocate_psymtab.  Do not use new.
5005         (allocate_psymtab): Use new.  Update.
5006
5007 2020-01-26  Tom Tromey  <tom@tromey.com>
5008
5009         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
5010         * psymtab.c (psym_print_stats): Update.
5011         * psympriv.h (struct partial_symtab) <readin,
5012         psymtabs_addrmap_supported, anonymous>: Now bool.
5013         * mdebugread.c (psymtab_to_symtab_1): Update.
5014         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
5015         (build_type_psymtabs_reader, psymtab_to_symtab_1)
5016         (process_full_comp_unit, process_full_type_unit): Update.
5017         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
5018         * ctfread.c (psymtab_to_symtab): Update.
5019
5020 2020-01-26  Tom Tromey  <tom@tromey.com>
5021
5022         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
5023         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
5024         * psymtab.c (psymtab_storage): Delete psymtabs.
5025         (psymtab_storage::allocate_psymtab): Use new.
5026         (psymtab_storage::discard_psymtab): Use delete.
5027         * psympriv.h (struct partial_symtab): Add constructor and
5028         initializers.
5029
5030 2020-01-26  Tom Tromey  <tom@tromey.com>
5031
5032         * machoread.c: Do not include psympriv.h.
5033
5034 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5035
5036         * NEWS: Mention the new option and the set/show commands.
5037
5038 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5039
5040         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
5041         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
5042         (validate_exec_file): New variables, enums, functions.
5043         (exec_file_locate_attach, print_section_info): Style the filenames.
5044         (_initialize_exec): Install show_exec_file_mismatch_command and
5045          set_exec_file_mismatch_command.
5046         * gdbcore.h (validate_exec_file): Declare.
5047         * infcmd.c (attach_command): Call validate_exec_file.
5048         * remote.c ( remote_target::remote_add_inferior): Likewise.
5049
5050 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5051
5052         * frame.c (find_frame_sal): Move call to get_next_frame into more
5053         inner scope.
5054         * inline-frame.c (inilne_state) <inline_state>: Update argument
5055         types.
5056         (inilne_state) <skipped_symbol>: Rename to...
5057         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
5058         (skip_inline_frames): Build vector of skipped symbols and use this
5059         to reate the inline_state.
5060         (inline_skipped_symbol): Add a comment and some assertions, fetch
5061         skipped symbol from the list.
5062
5063 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5064
5065         * buildsym.c (lte_is_less_than): Delete.
5066         (buildsym_compunit::end_symtab_with_blockvector): Create local
5067         lambda function to sort line table entries, and use
5068         std::stable_sort instead of std::sort.
5069         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
5070         markers when looking for a previous line.
5071
5072 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5073
5074         * dwarf2read.c (lnp_state_machine::record_line): Include
5075         end_sequence parameter in debug print out.  Record the line if we
5076         are at an end_sequence marker even if it's not the start of a
5077         statement.
5078         * symmisc.c (maintenance_print_one_line_table): Print end of
5079         sequence markers with 'END' not '0'.
5080
5081 2020-01-24  Pedro Alves  <palves@redhat.com>
5082
5083         PR gdb/25410
5084         * thread.c (scoped_restore_current_thread::restore): Use
5085         switch_to_inferior_no_thread.
5086         * exec.c: Include "progspace-and-thread.h".
5087         (add_target_sections, remove_target_sections):
5088         scoped_restore_current_pspace_and_thread instead of
5089         scoped_restore_current_thread.
5090         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
5091         and aspace to the inferior before calling clone_program_space.
5092         Remove stale comment.
5093
5094 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5095
5096         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
5097         (arm_netbsd_nat_target::fetch_registers): ...this.
5098         (arm_nbsd_nat_target::store_registers): Rename to...
5099         (arm_netbsd_nat_target::store_registers): ...this.
5100
5101 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5102
5103         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5104         register_t.
5105
5106 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5107
5108         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
5109         Update comment.
5110         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
5111         Likewise.
5112         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
5113         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
5114         the correct replacement (iterate_over_regset_sections).
5115         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
5116         Update comment.
5117
5118 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
5119
5120         PR gdb/23718
5121         * gdb/python/python.c (execute_gdb_command): Call
5122         async_enable_stdin in catch block.
5123
5124 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5125
5126         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
5127         SWITCH_THRU_ALL_UIS.
5128
5129 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5130
5131         PR tui/9765
5132         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
5133         comment, add extra parameter, and update to store previous symbol
5134         when appropriate.
5135         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
5136         add extra parameter.
5137         * tui/tui-disasm.c (tui_disassemble): Update header comment,
5138         remove unneeded parameter, add try/catch around gdb_print_insn,
5139         rewrite to add items to asm_lines vector.
5140         (tui_find_backward_disassembly_start_address): New function.
5141         (tui_find_disassembly_address): Updated throughout.
5142         (tui_disasm_window::set_contents): Update for changes to
5143         tui_disassemble.
5144         (tui_disasm_window::do_scroll_vertical): No need to adjust the
5145         number of lines to scroll.
5146
5147 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
5148
5149         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
5150         (SECT_OFF_DATA): Likewise.
5151         (SECT_OFF_RODATA): Likewise.
5152         (SECT_OFF_TEXT): Likewise.
5153         (SECT_OFF_BSS): Likewise.
5154         (struct objfile) <text_section_offset, data_section_offset>: New
5155         methods.
5156         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
5157         objfile::text_section_offset.
5158         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
5159         * coffread.c (coff_symtab_read): Likewise.
5160         (enter_linenos): Likewise.
5161         (process_coff_symbol): Likewise.
5162         * ctfread.c (get_objfile_text_range): Likewise.
5163         * dtrace-probe.c (dtrace_probe::get_relocated_address):
5164         Use objfile::data_section_offset.
5165         * dwarf2-frame.c (execute_cfa_program): Use
5166         objfile::text_section_offset.
5167         (dwarf2_frame_find_fde): Likewise.
5168         * dwarf2read.c (create_addrmap_from_index): Likewise.
5169         (create_addrmap_from_aranges): Likewise.
5170         (dw2_find_pc_sect_compunit_symtab): Likewise.
5171         (process_psymtab_comp_unit_reader): Likewise.
5172         (add_partial_symbol): Likewise.
5173         (add_partial_subprogram): Likewise.
5174         (process_full_comp_unit): Likewise.
5175         (read_file_scope): Likewise.
5176         (read_func_scope): Likewise.
5177         (read_lexical_block_scope): Likewise.
5178         (read_call_site_scope): Likewise.
5179         (dwarf2_rnglists_process): Likewise.
5180         (dwarf2_ranges_process): Likewise.
5181         (dwarf2_ranges_read): Likewise.
5182         (dwarf_decode_lines_1): Likewise.
5183         (new_symbol): Likewise.
5184         (dwarf2_fetch_die_loc_sect_off): Likewise.
5185         (dwarf2_per_cu_text_offset): Likewise.
5186         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
5187         * hppa-tdep.c (read_unwind_info): Likewise.
5188         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
5189         * psympriv.h (struct partial_symtab): Likewise.
5190         * psymtab.c (find_pc_sect_psymtab): Likewise.
5191         * solib-svr4.c (enable_break): Likewise.
5192         * stap-probe.c (relocate_address): Use
5193         objfile::data_section_offset.
5194         * xcoffread.c (enter_line_range): Use
5195         objfile::text_section_offset.
5196         (read_xcoff_symtab): Likewise.
5197
5198 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5199
5200         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
5201         declaration to narrower scopes.
5202
5203 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5204
5205         * darwin-nat.h (struct darwin_exception_msg, enum
5206         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
5207         Move up.
5208         (class darwin_nat_target) <wait_1, check_new_threads,
5209         decode_exception_message, decode_message, stop_inferior,
5210         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
5211         * darwin-nat.c (darwin_check_new_threads): Rename to...
5212         (darwin_nat_target::check_new_threads): ... this.
5213         (darwin_suspend_inferior_it): Remove.
5214         (darwin_decode_exception_message): Rename to...
5215         (darwin_nat_target::decode_exception_message): ... this.
5216         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
5217         (darwin_decode_message): Rename to...
5218         (darwin_nat_target::decode_message): ... this.
5219         (cancel_breakpoint): Rename to...
5220         (darwin_nat_target::cancel_breakpoint): ... this.
5221         (darwin_wait): Rename to...
5222         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
5223         instead of iterate_over_inferiors.
5224         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
5225         (darwin_stop_inferior): Rename to...
5226         (darwin_nat_target::stop_inferior): ... this.
5227         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
5228         (darwin_init_thread_list): Rename to...
5229         (darwin_nat_target::init_thread_list): ... this.
5230         (darwin_ptrace_him): Rename to...
5231         (darwin_nat_target::ptrace_him): ... this.
5232         (darwin_nat_target::create_inferior): Pass lambda function to
5233         fork_inferior.
5234         (darwin_nat_target::detach): Call stop_inferior instead of
5235         darwin_stop_inferior.
5236         * fork-inferior.h (fork_inferior): Change init_trace_fun
5237         parameter to gdb::function_view.
5238         * fork-inferior.c (fork_inferior): Likewise.
5239
5240 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
5241
5242         * i386-cygwin-tdep.c (core_process_module_section): Update.
5243         * windows-nat.c (struct lm_info_windows): Add text_offset.
5244         (windows_xfer_shared_libraries): Update.
5245         * windows-tdep.c (windows_xfer_shared_library):
5246         Add text_offset_cached argument.
5247         * windows-tdep.h (windows_xfer_shared_library): Update.
5248
5249 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5250
5251         * gdbarch.sh: Add declaration for _initialize_gdbarch.
5252
5253 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5254
5255         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
5256         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
5257         replace with range-based for.
5258         (gdbsim_interrupt_inferior): Remove.
5259         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
5260         with a range-based for.  Inline code from
5261         gdbsim_interrupt_inferior.
5262
5263 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5264
5265         * infrun.c (proceed): Fix indentation.
5266
5267 2020-01-21  Tom Tromey  <tromey@adacore.com>
5268
5269         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
5270         * python/python.c (python_extension_ops): Update.
5271         (gdbpy_colorize): New function.
5272         * python/lib/gdb/__init__.py (colorize): New function.
5273         * extension.h (ext_lang_colorize): Declare.
5274         * extension.c (ext_lang_colorize): New function.
5275         * extension-priv.h (struct extension_language_ops) <colorize>: New
5276         member.
5277         * cli/cli-style.c (_initialize_cli_style): Update help text.
5278
5279 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5280
5281         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
5282         <cond>: Change type to bool.
5283         (aarch64_displaced_step_b_cond): Update cond to use bool type.
5284         (aarch64_displaced_step_cb): Likewise.
5285         (aarch64_displaced_step_tb): Likewise.
5286
5287 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5288
5289         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
5290         output.
5291
5292 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5293
5294         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
5295         <pc_adjust>: Adjust the documentation.
5296         (aarch64_displaced_step_fixup): Check if PC really moved before
5297         adjusting it.
5298
5299 2020-01-19  Tom Tromey  <tom@tromey.com>
5300
5301         * disasm.c (~gdb_disassembler): New destructor.
5302         (gdb_buffered_insn_length): Call disassemble_free_target.
5303         * disasm.h (class gdb_disassembler): Declare destructor.  Use
5304         DISABLE_COPY_AND_ASSIGN.
5305
5306 2020-01-19  Tom Tromey  <tom@tromey.com>
5307
5308         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
5309         (die_reader_func_ftype): Remove.
5310         (cutu_reader): New class.
5311         (dw2_get_file_names_reader): Remove "data" parameter.
5312         (dw2_get_file_names): Use cutu_reader.
5313         (create_debug_type_hash_table): Update.
5314         (read_cutu_die_from_dwo): Update comment.
5315         (lookup_dwo_unit): Add dwo_name parameter.
5316         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
5317         die_reader_func_ftype and data parameters.
5318         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
5319         Remove die_reader_func_ftype and data parameters.
5320         (~cutu_reader): New; from init_cutu_and_read_dies.
5321         (cutu_reader::cutu_reader): Rename from
5322         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
5323         and data parameters.
5324         (init_cutu_and_read_dies_simple): Remove.
5325         (struct process_psymtab_comp_unit_data): Remove.
5326         (process_psymtab_comp_unit_reader): Remove data parameter; add
5327         want_partial_unit and pretend_language parameters.
5328         (process_psymtab_comp_unit): Use cutu_reader.
5329         (build_type_psymtabs_reader): Remove data parameter.
5330         (build_type_psymtabs_1): Use cutu_reader.
5331         (process_skeletonless_type_unit): Likewise.
5332         (load_partial_comp_unit_reader): Remove.
5333         (load_partial_comp_unit): Use cutu_reader.
5334         (load_full_comp_unit_reader): Remove.
5335         (load_full_comp_unit): Use cutu_reader.
5336         (struct create_dwo_cu_data): Remove.
5337         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
5338         dwo_unit parameters.
5339         (create_cus_hash_table): Use cutu_reader.
5340         (struct dwarf2_read_addr_index_data): Remove.
5341         (dwarf2_read_addr_index_reader): Remove.
5342         (dwarf2_read_addr_index): Use cutu_reader.
5343         (read_signatured_type_reader): Remove.
5344         (read_signatured_type): Use cutu_reader.
5345
5346 2020-01-19  Tom Tromey  <tom@tromey.com>
5347
5348         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
5349         * tui/tui-wingeneral.h (class tui_suppress_output): New.
5350         (tui_wrefresh): Declare.
5351         * tui/tui-wingeneral.c (suppress_output): New global.
5352         (tui_suppress_output, ~tui_suppress_output): New constructor and
5353         destructor.
5354         (tui_wrefresh): New function.
5355         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
5356         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
5357         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
5358         method.
5359         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
5360         tui_wrefresh.
5361         (tui_data_window::no_refresh): New method.
5362         (tui_data_item_window::refresh_window): Call tui_wrefresh.
5363         (tui_reg_command): Use tui_suppress_output
5364         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
5365         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
5366         method.
5367         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
5368
5369 2020-01-19  Tom Tromey  <tom@tromey.com>
5370
5371         * tui/tui-winsource.c (tui_update_source_windows_with_line):
5372         Handle case where symtab is null.
5373
5374 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
5375
5376         * linux-fork.c (one_fork_p): Simplify.
5377
5378 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5379
5380         * top.c (struct qt_args): Remove.
5381         (kill_or_detach): Change return type to void, replace `void *`
5382         parameter with a proper one.
5383         (print_inferior_quit_action):  Likewise.
5384         (quit_confirm): Use range-based for loop to iterate over inferiors.
5385         (quit_force): Likewise.
5386
5387 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5388
5389         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
5390         `void *` parameter with proper parameters.
5391         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
5392         (print_one_inferior): Change return type to void, replace `void *`
5393         parameter with proper parameters.
5394         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
5395         inferiors.
5396         (get_other_inferior): Remove.
5397         (mi_cmd_remove_inferior): Use range-based loop to iterate over
5398         inferiors.
5399
5400 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5401
5402         * mi/mi-interp.c (report_initial_inferior): Remove.
5403         (mi_interp::init): Use range-based for to iterate over inferiors.
5404
5405 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5406
5407         * python/py-inferior.c (build_inferior_list): Remove.
5408         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
5409
5410 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
5411
5412         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
5413         (btrace_stitch_trace): Likewise.
5414         * charset.c (intermediate_encoding): Likewise (vaild).
5415         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
5416         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
5417         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
5418
5419 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
5420
5421         * windows-tdep.c (windows_get_tlb_type):
5422         Add rtl_user_process_parameters type.
5423
5424 2020-01-16  Pedro Alves  <palves@redhat.com>
5425             Norbert Lange  <nolange79@gmail.com>
5426
5427         PR build/24805
5428         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
5429         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
5430         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
5431         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
5432         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
5433         (ps_plog): Redeclare exported functions with default visibility.
5434
5435 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
5436
5437         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
5438         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
5439
5440 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
5441
5442         * infcmd.c (post_create_inferior): Use get_thread_regcache
5443         instead of get_current_regcache.
5444
5445 2020-01-14  Tom Tromey  <tom@tromey.com>
5446
5447         PR symtab/12535:
5448         * python/python.c (gdbpy_decode_line): Treat empty string the same
5449         as no argument.
5450
5451 2020-01-14  Tom Tromey  <tom@tromey.com>
5452
5453         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
5454
5455 2020-01-14  Tom Tromey  <tom@tromey.com>
5456
5457         * nat/linux-btrace.c: Don't include <config.h>.
5458         * nat/linux-ptrace.c: Don't include <config.h>.
5459         * nat/x86-linux-dregs.c: Don't include <config.h>.
5460
5461 2020-01-14  Tom Tromey  <tom@tromey.com>
5462
5463         * configure: Rebuild.
5464         * configure.ac: Move many checks to ../gdbsupport/common.m4.
5465
5466 2020-01-14  Tom Tromey  <tom@tromey.com>
5467
5468         * nat/x86-linux-dregs.c: Include configh.h.
5469         * nat/linux-ptrace.c: Include configh.h.
5470         * nat/linux-btrace.c: Include configh.h.
5471         * defs.h: Include config.h, bfd.h.
5472         * configure.ac: Don't source common.host.
5473         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
5474         * configure: Rebuild.
5475         * acinclude.m4: Update path.
5476         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
5477         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
5478         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
5479         (CLIBS): Add LIBSUPPORT.
5480         (CDEPS): Likewise.
5481         (COMMON_SFILES): Remove gdbsupport files.
5482         (HFILES_NO_SRCDIR): Likewise.
5483         (stamp-version): Update path to create-version.sh.
5484         (ALLDEPFILES): Remove gdbsupport files.
5485
5486 2020-01-14  Tom Tromey  <tom@tromey.com>
5487
5488         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
5489         USE_WIN32API when needed.
5490         * configure.ac (USE_WIN32API): Don't define.
5491         (WIN32LIBS): Use WIN32APILIBS.
5492         * configure: Rebuild.
5493
5494 2020-01-14  Tom Tromey  <tom@tromey.com>
5495
5496         * configure: Rebuild.
5497         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
5498
5499 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5500
5501         * skip.c (skip_function_command): Make skip w/o arguments use the
5502         name of the inlined function if pc is inside any inlined function.
5503
5504 2020-01-14  Luis Machado  <luis.machado@linaro.org>
5505
5506         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
5507         * infrun.c (resume_1): Likewise.
5508         (handle_inferior_event): Remove stale comment.
5509         * linux-nat.c (linux_nat_target::resume): Update comments.
5510         (save_stop_reason): Likewise.
5511         (linux_nat_filter_event): Likewise.
5512         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
5513
5514 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5515
5516         * elfread.c (record_minimal_symbol): Set section index to 0 for
5517         non-allocatable sections.
5518
5519
5520 2020-01-13  Ali Tamur <tamur@google.com>
5521
5522         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
5523         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
5524         to gdb::optional.  Update comments.
5525         (dwo_file): Update comments.
5526         (read_attribute): Update API to take an additional out parameter,
5527         need_reprocess.  This is used to mark attributes that need other
5528         attributes (e.g. str_offsets_base) for correct computation which may not
5529         have been read yet.
5530         (read_attribute_reprocess): New function declaration.
5531         (read_addr_index): Likewise.
5532         (read_dwo_str_index): Likewise.
5533         (read_stub_str_index): Likewise.
5534         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
5535         (lookup_addr_base): New function definition.
5536         (lookup_ranges_base): Likewise.
5537         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
5538         lookup_ranges_base.
5539         (init_cutu_and_read_dies): Update comments.
5540         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
5541         unit.  This is used to inherit parent's str_offsets_base and addr_base.
5542         Update comments.
5543         (init_cutu_and_read_dies_simple): Reflect API changes.
5544         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
5545         (create_cus_hash_table): Change API to take parent compile unit.
5546         Reflect API changes.
5547         (open_and_init_dwo_file): Reflect API changes.
5548         (dwarf2_get_pc_bounds): Update comments.
5549         (dwarf2_record_block_ranges): Likewise.
5550         (read_full_die_1): Change implementation to reprocess attributes that
5551         need str_offsets_base and addr_base.
5552         (partial_die_info::read): Likewise.
5553         (read_attribute_reprocess): New function definition.
5554         (read_attribute_value): Change API to take an additional out parameter,
5555         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
5556         when a non-dwo compile unit has index based attributes.
5557         (read_attribute): Reflect API changes.
5558         (read_addr_index_1): Reflect API changes.  Update comments.
5559         (dwarf2_read_addr_index_data): Reflect API changes.
5560         (dwarf2_read_addr_index): Likewise.
5561         (read_str_index): Change API and implementation.  This becomes a helper
5562         to be used by the new string index related methods.  Update error
5563         message and comments.
5564         (read_dwo_str_index): New function definition.
5565         (read_stub_str_index): Likewise.
5566         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
5567         * symfile.h (dwarf2_debug_sections): Likewise.
5568         * xcoffread.c (dwarf2_debug_sections): Likewise.
5569
5570 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5571
5572         * gdbcore.h (struct core_fns) <core_read_registers>: Change
5573         core_reg_sect type to gdb_byte *.
5574         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
5575         * cris-tdep.c (fetch_core_registers): Likewise.
5576         * corelow.c (core_target::get_core_register_section): Change
5577         type of `contents` to gdb::byte_vector.
5578
5579 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5580
5581         * tui/tui-wingeneral.c (box_win): Position the title in the center
5582         of the border.
5583
5584 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
5585
5586         * corelow.c (core_target::get_core_register_section): Use
5587           std::vector instead of alloca.
5588
5589 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5590
5591         * warning.m4: Add -Wmissing-declarations to build_warnings.
5592         * configure: Re-generate.
5593
5594 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5595
5596         * python/python.c (init__gdb_module): Add declaration.
5597
5598 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5599
5600         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
5601         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
5602         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
5603         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
5604         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
5605         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
5606         * ada-exp.y (_initialize_ada_exp): Add declaration.
5607         * ada-lang.c (_initialize_ada_language): Add declaration.
5608         * ada-tasks.c (_initialize_tasks): Add declaration.
5609         * agent.c (_initialize_agent): Add declaration.
5610         * aix-thread.c (_initialize_aix_thread): Add declaration.
5611         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
5612         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
5613         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
5614         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
5615         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
5616         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
5617         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
5618         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
5619         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
5620         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
5621         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
5622         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
5623         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
5624         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
5625         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
5626         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
5627         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
5628         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
5629         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
5630         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
5631         * annotate.c (_initialize_annotate): Add declaration.
5632         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
5633         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
5634         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
5635         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
5636         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
5637         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
5638         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
5639         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
5640         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
5641         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
5642         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
5643         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
5644         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
5645         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
5646         * auto-load.c (_initialize_auto_load): Add declaration.
5647         * auxv.c (_initialize_auxv): Add declaration.
5648         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
5649         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
5650         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
5651         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
5652         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
5653         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
5654         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
5655         * breakpoint.c (_initialize_breakpoint): Add declaration.
5656         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
5657         * btrace.c (_initialize_btrace): Add declaration.
5658         * charset.c (_initialize_charset): Add declaration.
5659         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
5660         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
5661         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
5662         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
5663         * cli/cli-script.c (_initialize_cli_script): Add declaration.
5664         * cli/cli-style.c (_initialize_cli_style): Add declaration.
5665         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
5666         * coffread.c (_initialize_coffread): Add declaration.
5667         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
5668         * compile/compile.c (_initialize_compile): Add declaration.
5669         * complaints.c (_initialize_complaints): Add declaration.
5670         * completer.c (_initialize_completer): Add declaration.
5671         * copying.c (_initialize_copying): Add declaration.
5672         * corefile.c (_initialize_core): Add declaration.
5673         * corelow.c (_initialize_corelow): Add declaration.
5674         * cp-abi.c (_initialize_cp_abi): Add declaration.
5675         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
5676         * cp-support.c (_initialize_cp_support): Add declaration.
5677         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
5678         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
5679         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
5680         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
5681         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
5682         * ctfread.c (_initialize_ctfread): Add declaration.
5683         * d-lang.c (_initialize_d_language): Add declaration.
5684         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
5685         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
5686         * dbxread.c (_initialize_dbxread): Add declaration.
5687         * dcache.c (_initialize_dcache): Add declaration.
5688         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
5689         * disasm.c (_initialize_disasm): Add declaration.
5690         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
5691         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
5692         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
5693         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
5694         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
5695         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
5696         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
5697         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
5698         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
5699         * elfread.c (_initialize_elfread): Add declaration.
5700         * exec.c (_initialize_exec): Add declaration.
5701         * extension.c (_initialize_extension): Add declaration.
5702         * f-lang.c (_initialize_f_language): Add declaration.
5703         * f-valprint.c (_initialize_f_valprint): Add declaration.
5704         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
5705         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
5706         * filesystem.c (_initialize_filesystem): Add declaration.
5707         * findcmd.c (_initialize_mem_search): Add declaration.
5708         * findvar.c (_initialize_findvar): Add declaration.
5709         * fork-child.c (_initialize_fork_child): Add declaration.
5710         * frame-base.c (_initialize_frame_base): Add declaration.
5711         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
5712         * frame.c (_initialize_frame): Add declaration.
5713         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
5714         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
5715         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
5716         * gcore.c (_initialize_gcore): Add declaration.
5717         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
5718         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
5719         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
5720         * gdbarch.c (_initialize_gdbarch): Add declaration.
5721         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
5722         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
5723         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
5724         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
5725         * go-lang.c (_initialize_go_language): Add declaration.
5726         * go32-nat.c (_initialize_go32_nat): Add declaration.
5727         * guile/guile.c (_initialize_guile): Add declaration.
5728         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
5729         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
5730         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
5731         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
5732         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
5733         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
5734         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
5735         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
5736         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
5737         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
5738         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
5739         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
5740         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
5741         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
5742         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
5743         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
5744         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
5745         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
5746         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
5747         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
5748         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
5749         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
5750         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
5751         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
5752         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
5753         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
5754         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
5755         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
5756         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
5757         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
5758         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
5759         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
5760         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
5761         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
5762         * infcall.c (_initialize_infcall): Add declaration.
5763         * infcmd.c (_initialize_infcmd): Add declaration.
5764         * inflow.c (_initialize_inflow): Add declaration.
5765         * infrun.c (_initialize_infrun): Add declaration.
5766         * interps.c (_initialize_interpreter): Add declaration.
5767         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
5768         * jit.c (_initialize_jit): Add declaration.
5769         * language.c (_initialize_language): Add declaration.
5770         * linux-fork.c (_initialize_linux_fork): Add declaration.
5771         * linux-nat.c (_initialize_linux_nat): Add declaration.
5772         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
5773         * linux-thread-db.c (_initialize_thread_db): Add declaration.
5774         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
5775         * m2-lang.c (_initialize_m2_language): Add declaration.
5776         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
5777         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
5778         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
5779         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
5780         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
5781         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
5782         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
5783         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
5784         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
5785         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
5786         * machoread.c (_initialize_machoread): Add declaration.
5787         * macrocmd.c (_initialize_macrocmd): Add declaration.
5788         * macroscope.c (_initialize_macroscope): Add declaration.
5789         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
5790         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
5791         * maint.c (_initialize_maint_cmds): Add declaration.
5792         * mdebugread.c (_initialize_mdebugread): Add declaration.
5793         * memattr.c (_initialize_mem): Add declaration.
5794         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
5795         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
5796         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
5797         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
5798         * mi/mi-main.c (_initialize_mi_main): Add declaration.
5799         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
5800         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
5801         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
5802         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
5803         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
5804         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
5805         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
5806         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
5807         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
5808         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
5809         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
5810         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
5811         * mipsread.c (_initialize_mipsread): Add declaration.
5812         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
5813         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
5814         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
5815         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
5816         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
5817         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
5818         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
5819         * nto-procfs.c (_initialize_procfs): Add declaration.
5820         * objc-lang.c (_initialize_objc_language): Add declaration.
5821         * observable.c (_initialize_observer): Add declaration.
5822         * opencl-lang.c (_initialize_opencl_language): Add declaration.
5823         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
5824         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
5825         * osabi.c (_initialize_gdb_osabi): Add declaration.
5826         * osdata.c (_initialize_osdata): Add declaration.
5827         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
5828         * parse.c (_initialize_parse): Add declaration.
5829         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
5830         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
5831         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
5832         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
5833         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
5834         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
5835         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
5836         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
5837         * printcmd.c (_initialize_printcmd): Add declaration.
5838         * probe.c (_initialize_probe): Add declaration.
5839         * proc-api.c (_initialize_proc_api): Add declaration.
5840         * proc-events.c (_initialize_proc_events): Add declaration.
5841         * proc-service.c (_initialize_proc_service): Add declaration.
5842         * procfs.c (_initialize_procfs): Add declaration.
5843         * producer.c (_initialize_producer): Add declaration.
5844         * psymtab.c (_initialize_psymtab): Add declaration.
5845         * python/python.c (_initialize_python): Add declaration.
5846         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
5847         * record-btrace.c (_initialize_record_btrace): Add declaration.
5848         * record-full.c (_initialize_record_full): Add declaration.
5849         * record.c (_initialize_record): Add declaration.
5850         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
5851         * regcache.c (_initialize_regcache): Add declaration.
5852         * reggroups.c (_initialize_reggroup): Add declaration.
5853         * remote-notif.c (_initialize_notif): Add declaration.
5854         * remote-sim.c (_initialize_remote_sim): Add declaration.
5855         * remote.c (_initialize_remote): Add declaration.
5856         * reverse.c (_initialize_reverse): Add declaration.
5857         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
5858         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
5859         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
5860         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
5861         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
5862         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
5863         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
5864         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
5865         Add declaration.
5866         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
5867         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
5868         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
5869         * rust-exp.y (_initialize_rust_exp): Add declaration.
5870         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
5871         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
5872         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
5873         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
5874         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
5875         * score-tdep.c (_initialize_score_tdep): Add declaration.
5876         * ser-go32.c (_initialize_ser_dos): Add declaration.
5877         * ser-mingw.c (_initialize_ser_windows): Add declaration.
5878         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
5879         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
5880         * ser-uds.c (_initialize_ser_socket): Add declaration.
5881         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
5882         * serial.c (_initialize_serial): Add declaration.
5883         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
5884         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
5885         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
5886         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
5887         * skip.c (_initialize_step_skip): Add declaration.
5888         * sol-thread.c (_initialize_sol_thread): Add declaration.
5889         * solib-aix.c (_initialize_solib_aix): Add declaration.
5890         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
5891         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
5892         * solib-frv.c (_initialize_frv_solib): Add declaration.
5893         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
5894         * solib-target.c (_initialize_solib_target): Add declaration.
5895         * solib.c (_initialize_solib): Add declaration.
5896         * source-cache.c (_initialize_source_cache): Add declaration.
5897         * source.c (_initialize_source): Add declaration.
5898         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
5899         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
5900         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
5901         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
5902         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
5903         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
5904         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
5905         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
5906         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
5907         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
5908         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
5909         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
5910         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
5911         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
5912         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
5913         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
5914         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
5915         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
5916         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
5917         * stabsread.c (_initialize_stabsread): Add declaration.
5918         * stack.c (_initialize_stack): Add declaration.
5919         * stap-probe.c (_initialize_stap_probe): Add declaration.
5920         * std-regs.c (_initialize_frame_reg): Add declaration.
5921         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
5922         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
5923         * symfile.c (_initialize_symfile): Add declaration.
5924         * symmisc.c (_initialize_symmisc): Add declaration.
5925         * symtab.c (_initialize_symtab): Add declaration.
5926         * target.c (_initialize_target): Add declaration.
5927         * target-connection.c (_initialize_target_connection): Add
5928         declaration.
5929         * target-dcache.c (_initialize_target_dcache): Add declaration.
5930         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
5931         * thread.c (_initialize_thread): Add declaration.
5932         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
5933         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
5934         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
5935         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
5936         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
5937         * tracectf.c (_initialize_ctf): Add declaration.
5938         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
5939         * tracefile.c (_initialize_tracefile): Add declaration.
5940         * tracepoint.c (_initialize_tracepoint): Add declaration.
5941         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
5942         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
5943         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
5944         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
5945         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
5946         * tui/tui-win.c (_initialize_tui_win): Add declaration.
5947         * tui/tui.c (_initialize_tui): Add declaration.
5948         * typeprint.c (_initialize_typeprint): Add declaration.
5949         * ui-style.c (_initialize_ui_style): Add declaration.
5950         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
5951         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
5952         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
5953         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
5954         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
5955         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
5956         * unittests/filtered_iterator-selftests.c
5957         (_initialize_filtered_iterator_selftests): Add declaration.
5958         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
5959         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
5960         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
5961         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
5962         * unittests/main-thread-selftests.c
5963         (_initialize_main_thread_selftests): Add declaration.
5964         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
5965         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
5966         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
5967         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
5968         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
5969         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
5970         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
5971         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
5972         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
5973         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
5974         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
5975         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
5976         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
5977         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
5978         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
5979         declaration.
5980         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
5981         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
5982         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
5983         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
5984         * user-regs.c (_initialize_user_regs): Add declaration.
5985         * utils.c (_initialize_utils): Add declaration.
5986         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
5987         * valops.c (_initialize_valops): Add declaration.
5988         * valprint.c (_initialize_valprint): Add declaration.
5989         * value.c (_initialize_values): Add declaration.
5990         * varobj.c (_initialize_varobj): Add declaration.
5991         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
5992         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
5993         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
5994         * windows-nat.c (_initialize_windows_nat): Add declaration.
5995         (_initialize_check_for_gdb_ini): Add declaration.
5996         (_initialize_loadable): Add declaration.
5997         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
5998         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
5999         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
6000         * xcoffread.c (_initialize_xcoffread): Add declaration.
6001         * xml-support.c (_initialize_xml_support): Add declaration.
6002         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
6003         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
6004         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
6005         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
6006
6007 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6008
6009         * regformats/regdat.sh: Generate declaration for init function.
6010
6011 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6012
6013         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
6014         up.
6015         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
6016         close_one_inferior>: New methods.
6017         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
6018         pass down target to find_inferior_pid.
6019         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
6020         Pass down target to find_inferior_ptid.
6021         (gdbsim_target::create_inferior): Pass down target to
6022         add_thread_silent.
6023         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
6024         target down to find_inferior_ptid and switch_to_thread.
6025         (gdbsim_target::close): Update to call close_one_inferior.
6026         (struct resume_data): Remove.
6027         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
6028         directly, rather than through a void pointer.
6029         (gdbsim_target::resume): Update to call resume_one_inferior.
6030
6031 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
6032
6033         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
6034
6035 2020-01-12  Pedro Alves  <palves@redhat.com>
6036
6037         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
6038         directly for the current inferior instead of
6039         discard_all_inferiors.
6040         (discard_all_inferiors): Delete.
6041
6042 2020-01-11  Tom Tromey  <tom@tromey.com>
6043
6044         * tui/tui-wingeneral.c (box_win): Check cli_styling.
6045         * tui/tui-winsource.c (tui_source_window_base::refill): Use
6046         deprecated_safe_get_selected_frame.
6047
6048 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6049
6050         * inferior.c (print_inferior): Switch inferior before printing it.
6051
6052 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
6053             Pedro Alves  <palves@redhat.com>
6054
6055         * progspace-and-thread.c (switch_to_program_space_and_thread):
6056         Assert there's an inferior for PSPACE.  Use
6057         switch_to_inferior_no_thread to switch the inferior too.
6058         * progspace.c (program_space::~program_space): Call
6059         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
6060         (program_space::free_all_objfiles): Don't call clear_symtab_users
6061         here.
6062         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
6063
6064 2020-01-10  Pedro Alves  <palves@redhat.com>
6065
6066         * NEWS: Mention multi-target debugging, "info connections", and
6067         "add-inferior -no-connection".
6068
6069 2020-01-10  Pedro Alves  <palves@redhat.com>
6070
6071         * infrun.c: Include "target-connection.h".
6072         (check_multi_target_resumption): New.
6073         (proceed): Call it.
6074         * target-connection.c (make_target_connection_string): Make
6075         extern.
6076         * target-connection.h (make_target_connection_string): Declare.
6077
6078 2020-01-10  Pedro Alves  <palves@redhat.com>
6079
6080         * Makefile.in (COMMON_SFILES): Add target-connection.c.
6081         * inferior.c (uiout_field_connection): New function.
6082         (print_inferior): Add new "connection-id" column.
6083         (add_inferior_command): Show connection number/string of added
6084         inferior.
6085         * process-stratum-target.h
6086         (process_stratum_target::connection_string): New virtual method.
6087         (process_stratum_target::connection_number): New field.
6088         * remote.c (remote_target::connection_string): New override.
6089         * target-connection.c: New file.
6090         * target-connection.h: New file.
6091         * target.c (decref_target): Remove process_stratum targets from
6092         the connection list.
6093         (target_stack::push): Add process_stratum targets to the
6094         connection list.
6095
6096 2020-01-10  Pedro Alves  <palves@redhat.com>
6097
6098         Revert:
6099         2016-04-12  Pedro Alves  <palves@redhat.com>
6100         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
6101         Remove references to name.
6102         * serial.h (struct serial) <name>: Delete.
6103
6104 2020-01-10  Pedro Alves  <palves@redhat.com>
6105
6106         * gdbarch-selftests.c (register_to_value_test): Remove "target
6107         already pushed" check.
6108
6109 2020-01-10  Pedro Alves  <palves@redhat.com>
6110             John Baldwin  <jhb@FreeBSD.org>
6111
6112         * aarch64-linux-nat.c
6113         (aarch64_linux_nat_target::thread_architecture): Adjust.
6114         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
6115         (task_command_1): Likewise.
6116         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
6117         (aix_thread_target::wait, aix_thread_target::fetch_registers)
6118         (aix_thread_target::store_registers)
6119         (aix_thread_target::thread_alive): Adjust.
6120         * amd64-fbsd-tdep.c: Include "inferior.h".
6121         (amd64fbsd_get_thread_local_address): Pass down target.
6122         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
6123         thread's gdbarch instead of target_gdbarch.
6124         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
6125         get_last_target_status.
6126         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
6127         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
6128         inferiors.
6129         (update_inserted_breakpoint_locations): Skip if inferiors with no
6130         execution.
6131         (update_global_location_list): When handling moribund locations,
6132         find representative inferior for location's pspace, and use thread
6133         count of its process_stratum target.
6134         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
6135         * bsd-uthread.c (bsd_uthread_target::wait): Use
6136         as_process_stratum_target and adjust thread_change_ptid and
6137         add_thread calls.
6138         (bsd_uthread_target::update_thread_list): Use
6139         as_process_stratum_target and adjust find_thread_ptid,
6140         thread_change_ptid and add_thread calls.
6141         * btrace.c (maint_btrace_packet_history_cmd): Adjust
6142         find_thread_ptid call.
6143         * corelow.c (add_to_thread_list): Adjust add_thread call.
6144         (core_target_open): Adjust add_thread_silent and thread_count
6145         calls.
6146         (core_target::pid_to_str): Adjust find_inferior_ptid call.
6147         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
6148         * event-top.c (async_disconnect): Pop targets from all inferiors.
6149         * exec.c (add_target_sections): Push exec target on all inferiors
6150         sharing the program space.
6151         (remove_target_sections): Remove the exec target from all
6152         inferiors sharing the program space.
6153         (exec_on_vfork): New.
6154         * exec.h (exec_on_vfork): Declare.
6155         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
6156         Pass it down.
6157         (fbsd_nat_target::update_thread_list): Adjust.
6158         (fbsd_nat_target::resume): Adjust.
6159         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
6160         down.
6161         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
6162         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
6163         get_thread_arch_regcache call.
6164         * fork-child.c (gdb_startup_inferior): Pass target down to
6165         startup_inferior and set_executing.
6166         * gdbthread.h (struct process_stratum_target): Forward declare.
6167         (add_thread, add_thread_silent, add_thread_with_info)
6168         (in_thread_list): Add process_stratum_target parameter.
6169         (find_thread_ptid(inferior*, ptid_t)): New overload.
6170         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
6171         parameter.
6172         (all_threads()): Delete overload.
6173         (all_threads, all_non_exited_threads): Add process_stratum_target
6174         parameter.
6175         (all_threads_safe): Use brace initialization.
6176         (thread_count): Add process_stratum_target parameter.
6177         (set_resumed, set_running, set_stop_requested, set_executing)
6178         (threads_are_executing, finish_thread_state): Add
6179         process_stratum_target parameter.
6180         (switch_to_thread): Use is_current_thread.
6181         * i386-fbsd-tdep.c: Include "inferior.h".
6182         (i386fbsd_get_thread_local_address): Pass down target.
6183         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
6184         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
6185         have_inferiors check.
6186         * inf-ptrace.c (inf_ptrace_target::create_inferior)
6187         (inf_ptrace_target::attach): Adjust.
6188         * infcall.c (run_inferior_call): Adjust.
6189         * infcmd.c (run_command_1): Pass target to
6190         scoped_finish_thread_state.
6191         (proceed_thread_callback): Skip inferiors with no execution.
6192         (continue_command): Rename 'all_threads' local to avoid hiding
6193         'all_threads' function.  Adjust get_last_target_status call.
6194         (prepare_one_step): Adjust set_running call.
6195         (signal_command): Use user_visible_resume_target.  Compare thread
6196         pointers instead of inferior_ptid.
6197         (info_program_command): Adjust to pass down target.
6198         (attach_command): Mark target's 'thread_executing' flag.
6199         (stop_current_target_threads_ns): New, factored out from ...
6200         (interrupt_target_1): ... this.  Switch inferior before making
6201         target calls.
6202         * inferior-iter.h
6203         (struct all_inferiors_iterator, struct all_inferiors_range)
6204         (struct all_inferiors_safe_range)
6205         (struct all_non_exited_inferiors_range): Filter on
6206         process_stratum_target too.  Remove explicit.
6207         * inferior.c (inferior::inferior): Push dummy target on target
6208         stack.
6209         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
6210         Add process_stratum_target parameter, and pass it down.
6211         (have_live_inferiors): Adjust.
6212         (switch_to_inferior_and_push_target): New.
6213         (add_inferior_command, clone_inferior_command): Handle
6214         "-no-connection" parameter.  Use
6215         switch_to_inferior_and_push_target.
6216         (_initialize_inferior): Mention "-no-connection" option in
6217         the help of "add-inferior" and "clone-inferior" commands.
6218         * inferior.h: Include "process-stratum-target.h".
6219         (interrupt_target_1): Use bool.
6220         (struct inferior) <push_target, unpush_target, target_is_pushed,
6221         find_target_beneath, top_target, process_target, target_at,
6222         m_stack>: New.
6223         (discard_all_inferiors): Delete.
6224         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
6225         (all_inferiors, all_non_exited_inferiors): Add
6226         process_stratum_target parameter.
6227         * infrun.c: Include "gdb_select.h" and <unordered_map>.
6228         (target_last_proc_target): New global.
6229         (follow_fork_inferior): Push target on new inferior.  Pass target
6230         to add_thread_silent.  Call exec_on_vfork.  Handle target's
6231         reference count.
6232         (follow_fork): Adjust get_last_target_status call.  Also consider
6233         target.
6234         (follow_exec): Push target on new inferior.
6235         (struct execution_control_state) <target>: New field.
6236         (user_visible_resume_target): New.
6237         (do_target_resume): Call target_async.
6238         (resume_1): Set target's threads_executing flag.  Consider resume
6239         target.
6240         (commit_resume_all_targets): New.
6241         (proceed): Also consider resume target.  Skip threads of inferiors
6242         with no execution.  Commit resumtion in all targets.
6243         (start_remote): Pass current inferior to wait_for_inferior.
6244         (infrun_thread_stop_requested): Consider target as well.  Pass
6245         thread_info pointer to clear_inline_frame_state instead of ptid.
6246         (infrun_thread_thread_exit): Consider target as well.
6247         (random_pending_event_thread): New inferior parameter.  Use it.
6248         (do_target_wait): Rename to ...
6249         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
6250         down.
6251         (threads_are_resumed_pending_p, do_target_wait): New.
6252         (prepare_for_detach): Adjust calls.
6253         (wait_for_inferior): New inferior parameter.  Handle it.  Use
6254         do_target_wait_1 instead of do_target_wait.
6255         (fetch_inferior_event): Adjust.  Switch to representative
6256         inferior.  Pass target down.
6257         (set_last_target_status): Add process_stratum_target parameter.
6258         Save target in global.
6259         (get_last_target_status): Add process_stratum_target parameter and
6260         handle it.
6261         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
6262         (context_switch): Check inferior_ptid == null_ptid before calling
6263         inferior_thread().
6264         (get_inferior_stop_soon): Pass down target.
6265         (wait_one): Rename to ...
6266         (poll_one_curr_target): ... this.
6267         (struct wait_one_event): New.
6268         (wait_one): New.
6269         (stop_all_threads): Adjust.
6270         (handle_no_resumed, handle_inferior_event): Adjust to consider the
6271         event's target.
6272         (switch_back_to_stepped_thread): Also consider target.
6273         (print_stop_event): Update.
6274         (normal_stop): Update.  Also consider the resume target.
6275         * infrun.h (wait_for_inferior): Remove declaration.
6276         (user_visible_resume_target): New declaration.
6277         (get_last_target_status, set_last_target_status): New
6278         process_stratum_target parameter.
6279         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6280         process_stratum_target parameter, and use it.
6281         (clear_inline_frame_state (thread_info*)): New.
6282         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6283         process_stratum_target parameter.
6284         (clear_inline_frame_state (thread_info*)): Declare.
6285         * linux-fork.c (delete_checkpoint_command): Pass target down to
6286         find_thread_ptid.
6287         (checkpoint_command): Adjust.
6288         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
6289         instead of just tweaking inferior_ptid.
6290         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
6291         (exit_lwp): Pass target down to find_thread_ptid.
6292         (attach_proc_task_lwp_callback): Pass target down to
6293         add_thread/set_running/set_executing.
6294         (linux_nat_target::attach): Pass target down to
6295         thread_change_ptid.
6296         (get_detach_signal): Pass target down to find_thread_ptid.
6297         Consider last target status's target.
6298         (linux_resume_one_lwp_throw, resume_lwp)
6299         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
6300         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
6301         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
6302         (linux_nat_target::async_wait_fd): New.
6303         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
6304         target down.
6305         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
6306         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
6307         * linux-thread-db.c (struct thread_db_info::process_target): New
6308         field.
6309         (add_thread_db_info): Save target.
6310         (get_thread_db_info): New process_stratum_target parameter.  Also
6311         match target.
6312         (delete_thread_db_info): New process_stratum_target parameter.
6313         Also match target.
6314         (thread_from_lwp): Adjust to pass down target.
6315         (thread_db_notice_clone): Pass down target.
6316         (check_thread_db_callback): Pass down target.
6317         (try_thread_db_load_1): Always push the thread_db target.
6318         (try_thread_db_load, record_thread): Pass target down.
6319         (thread_db_target::detach): Pass target down.  Always unpush the
6320         thread_db target.
6321         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
6322         target down.  Always unpush the thread_db target.
6323         (find_new_threads_callback, thread_db_find_new_threads_2)
6324         (thread_db_target::update_thread_list): Pass target down.
6325         (thread_db_target::pid_to_str): Pass current inferior down.
6326         (thread_db_target::get_thread_local_address): Pass target down.
6327         (thread_db_target::resume, maintenance_check_libthread_db): Pass
6328         target down.
6329         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
6330         * procfs.c (procfs_target::procfs_init_inferior): Declare.
6331         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
6332         (procfs_init_inferior): Rename to ...
6333         (procfs_target::procfs_init_inferior): ... this and adjust.
6334         (procfs_target::create_inferior, procfs_notice_thread)
6335         (procfs_do_thread_registers): Adjust.
6336         * ppc-fbsd-tdep.c: Include "inferior.h".
6337         (ppcfbsd_get_thread_local_address): Pass down target.
6338         * proc-service.c (ps_xfer_memory): Switch current inferior and
6339         program space as well.
6340         (get_ps_regcache): Pass target down.
6341         * process-stratum-target.c
6342         (process_stratum_target::thread_address_space)
6343         (process_stratum_target::thread_architecture): Pass target down.
6344         * process-stratum-target.h
6345         (process_stratum_target::threads_executing): New field.
6346         (as_process_stratum_target): New.
6347         * ravenscar-thread.c
6348         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
6349         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
6350         down.
6351         * record-btrace.c (record_btrace_target::info_record): Adjust.
6352         (record_btrace_target::record_method)
6353         (record_btrace_target::record_is_replaying)
6354         (record_btrace_target::fetch_registers)
6355         (get_thread_current_frame_id, record_btrace_target::resume)
6356         (record_btrace_target::wait, record_btrace_target::stop): Pass
6357         target down.
6358         * record-full.c (record_full_wait_1): Switch to event thread.
6359         Pass target down.
6360         * regcache.c (regcache::regcache)
6361         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
6362         process_stratum_target parameter and handle it.
6363         (current_thread_target): New global.
6364         (get_thread_regcache): Add process_stratum_target parameter and
6365         handle it.  Switch inferior before calling target method.
6366         (get_thread_regcache): Pass target down.
6367         (get_thread_regcache_for_ptid): Pass target down.
6368         (registers_changed_ptid): Add process_stratum_target parameter and
6369         handle it.
6370         (registers_changed_thread, registers_changed): Pass target down.
6371         (test_get_thread_arch_aspace_regcache): New.
6372         (current_regcache_test): Define a couple local test_target_ops
6373         instances and use them for testing.
6374         (readwrite_regcache): Pass process_stratum_target parameter.
6375         (cooked_read_test, cooked_write_test): Pass mock_target down.
6376         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
6377         (get_thread_arch_aspace_regcache): Add process_stratum_target
6378         parameter.
6379         (regcache::target): New method.
6380         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
6381         (regcache::registers_changed_ptid): Add process_stratum_target
6382         parameter.
6383         (regcache::m_target): New field.
6384         (registers_changed_ptid): Add process_stratum_target parameter.
6385         * remote.c (remote_state::supports_vCont_probed): New field.
6386         (remote_target::async_wait_fd): New method.
6387         (remote_unpush_and_throw): Add remote_target parameter.
6388         (get_current_remote_target): Adjust.
6389         (remote_target::remote_add_inferior): Push target.
6390         (remote_target::remote_add_thread)
6391         (remote_target::remote_notice_new_inferior)
6392         (get_remote_thread_info): Pass target down.
6393         (remote_target::update_thread_list): Skip threads of inferiors
6394         bound to other targets.  (remote_target::close): Don't discard
6395         inferiors.  (remote_target::add_current_inferior_and_thread)
6396         (remote_target::process_initial_stop_replies)
6397         (remote_target::start_remote)
6398         (remote_target::remote_serial_quit_handler): Pass down target.
6399         (remote_target::remote_unpush_target): New remote_target
6400         parameter.  Unpush the target from all inferiors.
6401         (remote_target::remote_unpush_and_throw): New remote_target
6402         parameter.  Pass it down.
6403         (remote_target::open_1): Check whether the current inferior has
6404         execution instead of checking whether any inferior is live.  Pass
6405         target down.
6406         (remote_target::remote_detach_1): Pass down target.  Use
6407         remote_unpush_target.
6408         (extended_remote_target::attach): Pass down target.
6409         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
6410         (remote_target::append_resumption): Pass down target.
6411         (remote_target::append_pending_thread_resumptions)
6412         (remote_target::remote_resume_with_hc, remote_target::resume)
6413         (remote_target::commit_resume): Pass down target.
6414         (remote_target::remote_stop_ns): Check supports_vCont_probed.
6415         (remote_target::interrupt_query)
6416         (remote_target::remove_new_fork_children)
6417         (remote_target::check_pending_events_prevent_wildcard_vcont)
6418         (remote_target::remote_parse_stop_reply)
6419         (remote_target::process_stop_reply): Pass down target.
6420         (first_remote_resumed_thread): New remote_target parameter.  Pass
6421         it down.
6422         (remote_target::wait_as): Pass down target.
6423         (unpush_and_perror): New remote_target parameter.  Pass it down.
6424         (remote_target::readchar, remote_target::remote_serial_write)
6425         (remote_target::getpkt_or_notif_sane_1)
6426         (remote_target::kill_new_fork_children, remote_target::kill): Pass
6427         down target.
6428         (remote_target::mourn_inferior): Pass down target.  Use
6429         remote_unpush_target.
6430         (remote_target::core_of_thread)
6431         (remote_target::remote_btrace_maybe_reopen): Pass down target.
6432         (remote_target::pid_to_exec_file)
6433         (remote_target::thread_handle_to_thread_info): Pass down target.
6434         (remote_target::async_wait_fd): New.
6435         * riscv-fbsd-tdep.c: Include "inferior.h".
6436         (riscv_fbsd_get_thread_local_address): Pass down target.
6437         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
6438         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
6439         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
6440         Adjust.
6441         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
6442         * solib-svr4.c (enable_break): Pass down target.
6443         * spu-multiarch.c (parse_spufs_run): Pass down target.
6444         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
6445         * target-delegates.c: Regenerate.
6446         * target.c (g_target_stack): Delete.
6447         (current_top_target): Return the current inferior's top target.
6448         (target_has_execution_1): Refer to the passed-in inferior's top
6449         target.
6450         (target_supports_terminal_ours): Check whether the initial
6451         inferior was already created.
6452         (decref_target): New.
6453         (target_stack::push): Incref/decref the target.
6454         (push_target, push_target, unpush_target): Adjust.
6455         (target_stack::unpush): Defref target.
6456         (target_is_pushed): Return bool.  Adjust to refer to the current
6457         inferior's target stack.
6458         (dispose_inferior): Delete, and inline parts ...
6459         (target_preopen): ... here.  Only dispose of the current inferior.
6460         (target_detach): Hold strong target reference while detaching.
6461         Pass target down.
6462         (target_thread_name): Add assertion.
6463         (target_resume): Pass down target.
6464         (target_ops::beneath, find_target_at): Adjust to refer to the
6465         current inferior's target stack.
6466         (get_dummy_target): New.
6467         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
6468         has a thread running.
6469         (initialize_targets): Rename to ...
6470         (_initialize_target): ... this.
6471         * target.h: Include "gdbsupport/refcounted-object.h".
6472         (struct target_ops): Inherit refcounted_object.
6473         (target_ops::shortname, target_ops::longname): Make const.
6474         (target_ops::async_wait_fd): New method.
6475         (decref_target): Declare.
6476         (struct target_ops_ref_policy): New.
6477         (target_ops_ref): New typedef.
6478         (get_dummy_target): Declare function.
6479         (target_is_pushed): Return bool.
6480         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
6481         (all_matching_threads_iterator::all_matching_threads_iterator):
6482         Handle filter target.
6483         * thread-iter.h (struct all_matching_threads_iterator, struct
6484         all_matching_threads_range, class all_non_exited_threads_range):
6485         Filter by target too.  Remove explicit.
6486         * thread.c (threads_executing): Delete.
6487         (inferior_thread): Pass down current inferior.
6488         (clear_thread_inferior_resources): Pass down thread pointer
6489         instead of ptid_t.
6490         (add_thread_silent, add_thread_with_info, add_thread): Add
6491         process_stratum_target parameter.  Use it for thread and inferior
6492         searches.
6493         (is_current_thread): New.
6494         (thread_info::deletable): Use it.
6495         (find_thread_ptid, thread_count, in_thread_list)
6496         (thread_change_ptid, set_resumed, set_running): New
6497         process_stratum_target parameter.  Pass it down.
6498         (set_executing): New process_stratum_target parameter.  Pass it
6499         down.  Adjust reference to 'threads_executing'.
6500         (threads_are_executing): New process_stratum_target parameter.
6501         Adjust reference to 'threads_executing'.
6502         (set_stop_requested, finish_thread_state): New
6503         process_stratum_target parameter.  Pass it down.
6504         (switch_to_thread): Also match inferior.
6505         (switch_to_thread): New process_stratum_target parameter.  Pass it
6506         down.
6507         (update_threads_executing): Reimplement.
6508         * top.c (quit_force): Pop targets from all inferior.
6509         (gdb_init): Don't call initialize_targets.
6510         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
6511         Declare.
6512         (windows_add_thread, windows_delete_thread): Adjust.
6513         (get_windows_debug_event): Rename to ...
6514         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
6515         * tracefile-tfile.c (tfile_target_open): Pass down target.
6516         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
6517         Forward declare.
6518         (switch_to_thread): Add process_stratum_target parameter.
6519         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
6520         parameter.  Use it.
6521         (mi_on_resume): Pass target down.
6522         * nat/fork-inferior.c (startup_inferior): Add
6523         process_stratum_target parameter.  Pass it down.
6524         * nat/fork-inferior.h (startup_inferior): Add
6525         process_stratum_target parameter.
6526         * python/py-threadevent.c (py_get_event_thread): Pass target down.
6527
6528 2020-01-10  Pedro Alves  <palves@redhat.com>
6529
6530         * remote.c (remote_target::start_remote): Don't set inferior_ptid
6531         directly.  Instead find the first thread in the thread list and
6532         use switch_to_thread.
6533
6534 2020-01-10  Pedro Alves  <palves@redhat.com>
6535
6536         * remote.c (remote_target::remote_add_inferior): Don't bind a
6537         process to the current inferior if the current inferior is already
6538         bound to a process.
6539
6540 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6541             Pedro Alves  <palves@redhat.com>
6542
6543         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
6544         If no process is specified, return null_ptid instead of
6545         inferior_ptid.
6546         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
6547         TARGET_WAITKIND_SIGNALLED with no pid.
6548
6549 2020-01-10  Pedro Alves  <palves@redhat.com>
6550
6551         * remote.c (first_remote_resumed_thread): New.
6552         (remote_target::wait_as): Use it as default event_ptid instead of
6553         inferior_ptid.
6554
6555 2020-01-10  Pedro Alves  <palves@redhat.com>
6556
6557         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
6558
6559 2020-01-10  Pedro Alves  <palves@redhat.com>
6560
6561         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
6562         not -1.
6563
6564 2020-01-10  Pedro Alves  <palves@redhat.com>
6565
6566         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
6567         ptid to get_last_target_status.
6568         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
6569         ptid to get_last_target_status.
6570         * infcmd.c (continue_command): Don't pass a target_waitstatus to
6571         get_last_target_status.
6572         (info_program_command): Don't pass a target_waitstatus to
6573         get_last_target_status.
6574         * infrun.c (init_wait_for_inferior): Use
6575         nullify_last_target_wait_ptid.
6576         (get_last_target_status): Handle nullptr arguments.
6577         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
6578         (print_stop_event): Don't pass a ptid to get_last_target_status.
6579         (normal_stop): Don't pass a ptid to get_last_target_status.
6580         * infrun.h (get_last_target_status, set_last_target_status): Move
6581         comments here and update.
6582         (nullify_last_target_wait_ptid): Declare.
6583         * linux-fork.c (fork_load_infrun_state): Remove local extern
6584         declaration of nullify_last_target_wait_ptid.
6585         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
6586         to get_last_target_status.
6587
6588 2020-01-10  Pedro Alves  <palves@redhat.com>
6589
6590         * gdbthread.h (scoped_restore_current_thread)
6591         <dont_restore, restore, m_dont_restore>: Declare.
6592         * thread.c (thread_alive): Add assertion.  Return bool.
6593         (switch_to_thread_if_alive): New.
6594         (prune_threads): Switch inferior/thread.
6595         (print_thread_info_1): Switch thread before calling target methods.
6596         (scoped_restore_current_thread::restore): New, factored out from
6597         ...
6598         (scoped_restore_current_thread::~scoped_restore_current_thread):
6599         ... this.
6600         (scoped_restore_current_thread::scoped_restore_current_thread):
6601         Add assertion.
6602         (thread_apply_all_command, thread_select): Use
6603         switch_to_thread_if_alive.
6604         * infrun.c (proceed, restart_threads, handle_signal_stop)
6605         (switch_back_to_stepped_thread): Switch current thread before
6606         calling target methods.
6607
6608 2020-01-10  Pedro Alves <palves@redhat.com>
6609
6610         * inferior.c (switch_to_inferior_no_thread): New function,
6611         factored out from ...
6612         (inferior_command): ... here.
6613         * inferior.h (switch_to_inferior_no_thread): Declare.
6614         * mi/mi-main.c (run_one_inferior): Use
6615         switch_to_inferior_no_thread.
6616
6617 2020-01-10  Pedro Alves  <palves@redhat.com>
6618
6619         * infcmd.c (kill_command): Remove dead code.
6620
6621 2020-01-10  Pedro Alves  <palves@redhat.com>
6622
6623         * remote.c (remote_target::mourn_inferior): No longer check
6624         whether the target is running.
6625
6626 2020-01-10  Pedro Alves  <palves@redhat.com>
6627
6628         * corelow.c (core_target::has_execution): Change parameter type to
6629         inferior pointer.
6630         * inferior.c (number_of_live_inferiors): Use
6631         inferior::has_execution instead of target_has_execution_1.
6632         * inferior.h (inferior::has_execution): New.
6633         * linux-thread-db.c (thread_db_target::update_thread_list): Use
6634         inferior::has_execution instead of target_has_execution_1.
6635         * process-stratum-target.c
6636         (process_stratum_target::has_execution): Change parameter type to
6637         inferior pointer.  Check the inferior's PID instead of
6638         inferior_ptid.
6639         * process-stratum-target.h
6640         (process_stratum_target::has_execution): Change parameter type to
6641         inferior pointer.
6642         * record-full.c (record_full_core_target::has_execution): Change
6643         parameter type to inferior pointer.
6644         * target.c (target_has_execution_1): Change parameter type to
6645         inferior pointer.
6646         (target_has_execution_current): Adjust.
6647         * target.h (target_ops::has_execution): Change parameter type to
6648         inferior pointer.
6649         (target_has_execution_1): Change parameter type to inferior
6650         pointer.  Change return type to bool.
6651         * tracefile.h (tracefile_target::has_execution): Change parameter
6652         type to inferior pointer.
6653
6654 2020-01-10  Pedro Alves  <palves@redhat.com>
6655
6656         * exceptions.c (print_flush): Remove current_top_target() check.
6657
6658 2020-01-10  Pedro Alves  <palves@redhat.com>
6659
6660         * remote.c (show_remote_exec_file): Show the current inferior's
6661         exec-file instead of the command variable's value.
6662
6663 2020-01-10  Pedro Alves  <palves@redhat.com>
6664
6665         * record-full.c (record_full_resume_ptid): New global.
6666         (record_full_target::resume): Set it.
6667         (record_full_wait_1): Use record_full_resume_ptid instead of
6668         inferior_ptid.
6669
6670 2020-01-10  Pedro Alves  <palves@redhat.com>
6671
6672         * gdbthread.h (scoped_restore_current_thread)
6673         <dont_restore, restore, m_dont_restore>: Declare.
6674         * thread.c (thread_alive): Add assertion.  Return bool.
6675         (switch_to_thread_if_alive): New.
6676         (prune_threads): Switch inferior/thread.
6677         (print_thread_info_1): Switch thread before calling target methods.
6678         (scoped_restore_current_thread::restore): New, factored out from
6679         ...
6680         (scoped_restore_current_thread::~scoped_restore_current_thread):
6681         ... this.
6682         (scoped_restore_current_thread::scoped_restore_current_thread):
6683         Add assertion.
6684         (thread_apply_all_command, thread_select): Use
6685         switch_to_thread_if_alive.
6686
6687 2020-01-10  George Barrett  <bob@bob131.so>
6688
6689         * stap-probe.c (stap_modify_semaphore): Don't check for null
6690         semaphores.
6691         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
6692         for null semaphores.
6693
6694 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6695
6696         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
6697         all source windows, and maintain horizontal scroll status while
6698         doing so.
6699
6700 2020-01-09  Tom Tromey  <tom@tromey.com>
6701
6702         PR tui/18932:
6703         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
6704         update_source_window, not print_source_lines.
6705
6706 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6707
6708         * tui/tui.c (tui_enable): Register tui hooks after calling
6709         tui_display_main.
6710
6711 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
6712
6713         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
6714
6715 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
6716
6717         * thread.c (print_thread_info_1): Fix indentation.
6718
6719 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
6720
6721         * symtab.c (general_symbol_info::compute_and_set_names): Move the
6722         unique_xmalloc_ptr outside the if to always free the demangled name.
6723
6724 2020-01-08  Tom Tromey  <tromey@adacore.com>
6725
6726         * xcoffread.c (enter_line_range, read_xcoff_symtab)
6727         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
6728         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
6729         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
6730         Remove.
6731         (section_offsets): New typedef.
6732         * symtab.c (fixup_section, get_msymbol_address): Update.
6733         * symmisc.c (dump_msymbols): Update.
6734         * symfile.h (relative_addr_info_to_section_offsets)
6735         (symfile_map_offsets_to_segments): Update.
6736         * symfile.c (build_section_addr_info_from_objfile)
6737         (init_objfile_sect_indices): Update.
6738         (struct place_section_arg): Change type of "offsets".
6739         (place_section): Update.
6740         (relative_addr_info_to_section_offsets): Change type of
6741         "section_offsets".  Remove "num_sections" parameter.
6742         (default_symfile_offsets, syms_from_objfile_1)
6743         (set_objfile_default_section_offset): Update.
6744         (reread_symbols): No need to preserve section offsets by hand.
6745         (symfile_map_offsets_to_segments): Change type of "offsets".
6746         * stap-probe.c (relocate_address): Update.
6747         * stabsread.h (process_one_symbol): Update.
6748         * solib-target.c (struct lm_info_target) <offsets>: Change type.
6749         (solib_target_relocate_section_addresses): Update.
6750         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
6751         Update.
6752         * solib-frv.c (frv_relocate_main_executable): Update.
6753         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
6754         * solib-aix.c (solib_aix_get_section_offsets): Change return
6755         type.
6756         (solib_aix_solib_create_inferior_hook): Update.
6757         * remote.c (remote_target::get_offsets): Update.
6758         * psymtab.c (find_pc_sect_psymtab): Update.
6759         * psympriv.h (struct partial_symbol) <address, text_low,
6760         text_high>: Update.
6761         * objfiles.h (obj_section_offset): Update.
6762         (struct objfile) <section_offsets>: Change type.
6763         <num_sections>: Remove.
6764         (objfile_relocate): Update.
6765         * objfiles.c (entry_point_address_query): Update
6766         (relocate_one_symbol): Change type of "section_offsets".
6767         (objfile_relocate1, objfile_relocate1): Change type of
6768         "new_offsets".
6769         (objfile_rebase1): Update.
6770         * mipsread.c (mipscoff_symfile_read): Update.
6771         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
6772         parameter.
6773         * mdebugread.c (parse_symbol): Change type of "section_offsets".
6774         (parse_external, psymtab_to_symtab_1): Update.
6775         * machoread.c (macho_symfile_offsets): Update.
6776         * ia64-tdep.c (ia64_find_unwind_table): Update.
6777         * hppa-tdep.c (read_unwind_info): Update.
6778         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
6779         * dwarf2read.c (create_addrmap_from_index)
6780         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6781         (process_psymtab_comp_unit_reader, add_partial_symbol)
6782         (add_partial_subprogram, process_full_comp_unit)
6783         (read_file_scope, read_func_scope, read_lexical_block_scope)
6784         (read_call_site_scope, dwarf2_rnglists_process)
6785         (dwarf2_ranges_process, dwarf2_ranges_read)
6786         (dwarf_decode_lines_1, var_decode_location, new_symbol)
6787         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
6788         Update.
6789         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
6790         Update.
6791         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
6792         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
6793         (process_one_symbol): Change type of "section_offsets".
6794         * ctfread.c (get_objfile_text_range): Update.
6795         * coffread.c (coff_symtab_read, enter_linenos)
6796         (process_coff_symbol): Update.
6797         * coff-pe-read.c (add_pe_forwarded_sym): Update.
6798         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
6799
6800 2020-01-08  Tom Tromey  <tromey@adacore.com>
6801
6802         * dwarf2read.c (parse_macro_definition): Use std::string.
6803         (parse_macro_definition): Likewise.
6804
6805 2020-01-08  Tom Tromey  <tromey@adacore.com>
6806
6807         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
6808         (ATTR_ALLOC_CHUNK): Remove.
6809
6810 2020-01-08  Tom Tromey  <tromey@adacore.com>
6811
6812         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
6813
6814 2020-01-08  Tom Tromey  <tromey@adacore.com>
6815
6816         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
6817         (dwarf2_compute_name, open_dwo_file): Likewise.
6818         (process_enumeration_scope): Use std::vector.
6819         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
6820         (partial_die_info::fixup, dwarf2_start_subfile)
6821         (guess_full_die_structure_name, dwarf2_name): Likewise.
6822         (determine_prefix): Update.
6823         (guess_full_die_structure_name): Make return type const.
6824         (partial_die_full_name): Return unique_xmalloc_ptr.
6825         (DW_FIELD_ALLOC_CHUNK): Remove.
6826
6827 2020-01-07  Tom Tromey  <tromey@adacore.com>
6828
6829         PR build/24937:
6830         * stap-probe.c (class stap_static_probe_ops): Add constructor.
6831
6832 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
6833
6834         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
6835
6836 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6837
6838         * stack.c (print_frame_info): Move disassemble_next_line code
6839         inside source_print block.
6840
6841 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6842
6843         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
6844         gdb/signals.h, as we are now using native signal symbols.
6845
6846 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
6847
6848         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
6849         overflow by an early check of content vs threshold.
6850         * tui/tui-source.c (tui_source_window::line_is_displayed):
6851         Likewise.
6852
6853 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6854
6855         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
6856
6857 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
6858
6859         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
6860         export table if no section contains it's RVA.
6861
6862 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6863
6864         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
6865
6866 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
6867
6868         * source.c (print_source_lines_base): Set last_line_listed.
6869
6870 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
6871
6872         * tui/tui-disasm.c: Remove trailing spaces.
6873
6874 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6875             Pedro Alves  <palves@redhat.com>
6876
6877         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
6878         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
6879         (windows_gdb_signal_to_target): New function, uses the above
6880         enumeration to convert GDB internal signal codes to equivalent
6881         Windows codes.
6882         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
6883         * windows-nat.c: Include "gdb_wait.h".
6884         (get_windows_debug_event): Extract the fatal exception from the
6885         exit status and convert to the equivalent Posix signal number.
6886         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
6887         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
6888         * gdbsupport/gdb_wait.c: New file, implements
6889         windows_status_to_termsig.
6890         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
6891         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
6892
6893 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6894
6895         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
6896         show_layout.
6897
6898 2020-01-05  Luis Machado  <luis.machado@linaro.org>
6899
6900         * aarch64-linux-nat.c
6901         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
6902         and bfd_mach_aarch64.
6903
6904 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6905
6906         * ui-file.c (stdio_file::can_emit_style_escape)
6907         (tee_file::can_emit_style_escape): Ensure style is used also on
6908         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
6909         to gdb_stdout.
6910         * main.c (set_gdb_data_directory): Use file style to output the
6911         warning that the given pathname is not a directory.
6912         * top.c (show_history_filename, gdb_safe_append_history)
6913         (show_gdb_datadir): Use file style.
6914
6915 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
6916
6917         * solib-target.c (struct lm_info_target):
6918         Change offsets to be a unique_xmalloc_ptr.
6919         (solib_target_relocate_section_addresses): Update.
6920
6921 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
6922
6923         * windows-nat.c (windows_clear_solib): Free so_list linked list.
6924
6925 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6926
6927         * MAINTAINERS (Write After Approval): Add myself.
6928
6929 2020-01-02  Luis Machado  <luis.machado@linaro.org>
6930
6931         * proc-service.c (get_ps_regcache): Remove reference to obsolete
6932         Cell BE architecture.
6933         * target.h (struct target_ops) <thread_architecture>: Likewise.
6934
6935 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
6936
6937         * Makefile.in: Use INSTALL_PROGRAM_ENV.
6938
6939 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
6940
6941         * MAINTAINERS (Write After Approval): Add myself.
6942
6943 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6944
6945         * gdbarch.sh: Update copyright year range of generated files.
6946
6947 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6948
6949         Update copyright year range in all GDB files.
6950
6951 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6952
6953         * copyright.py: Convert to Python 3.
6954
6955 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6956
6957         * copyright.py: Adapt after move of gnulib directory from gdb
6958         directory to toplevel directory.
6959
6960 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6961
6962         * copyright.py (main): Exit if run from the wrong directory.
6963
6964 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6965
6966         * top.c (print_gdb_version): Change copyright year to 2020.
6967
6968 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6969
6970         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
6971
6972 For older changes see ChangeLog-2019.
6973 \f
6974 Local Variables:
6975 mode: change-log
6976 left-margin: 8
6977 fill-column: 74
6978 version-control: never
6979 coding: utf-8
6980 End: