gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (tui_refill_source_window)
   4         (tui_set_is_exec_point_at): Don't declare.
   5         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
   6         (tui_source_window_base::refill): Rename from
   7         tui_refill_source_window.
   8         (tui_source_window_base::do_scroll_horizontal): Update.
   9         (tui_source_window_base::set_is_exec_point_at): Rename from
  10         tui_set_is_exec_point_at.
  11         (tui_update_all_breakpoint_info): Update.
  12         * tui/tui-stack.c (tui_show_frame_info): Update.
  13         * tui/tui-layout.c (show_data): Add cast.
  14         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
  15         * tui/tui-data.h (struct tui_source_window_base) <refill,
  16         set_is_exec_point_at>: New methods.
  17         (tui_source_windows, tui_add_to_source_windows): Update types.
  18         (tui_add_to_source_windows): Remove redundant declaration.
  19         * tui/tui-data.c (source_windows): Store tui_source_window_base.
  20         (tui_source_windows): Change return type.
  21         (tui_clear_source_windows_detail): Update.
  22         (tui_add_to_source_windows): Change type of parameter.
  23         (tui_free_all_source_wins_content): Update.
  24
  25 2019-06-25  Tom Tromey  <tom@tromey.com>
  26
  27         * tui/tui-wingeneral.c (tui_win_info::refresh)
  28         (tui_source_window_base::refresh): New methods.
  29         (tui_refresh_all): Call the refresh method.
  30         * tui/tui-data.h (struct tui_win_info)
  31         (struct tui_source_window_base) <refresh>: New method.
  32
  33 2019-06-25  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui.h (tui_is_window_visible): Return bool.
  36         * tui/tui.c (tui_is_window_visible): Return bool.
  37         * tui/tui-wingeneral.c (tui_make_window, make_visible)
  38         (tui_make_visible, tui_make_invisible)
  39         (tui_win_info::make_visible)
  40         (tui_source_window_base::make_visible, make_all_visible)
  41         (tui_make_all_visible, tui_make_all_invisible): Update.
  42         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
  43         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
  44         bool.
  45         (struct tui_win_info, struct tui_source_window_base)
  46         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
  47         * tui/tui-data.c (tui_init_generic_part): Update.
  48
  49 2019-06-25  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui-wingeneral.c (tui_win_info::make_visible)
  52         (tui_source_window_base::make_visible): New methods.
  53         (make_all_visible): Make method call.
  54         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
  55         (struct tui_source_window_base, struct tui_cmd_window): Override
  56         make_visible.
  57         (tui_win_is_source_type): Don't declare.
  58         * tui/tui-data.c (tui_win_is_source_type): Remove.
  59
  60 2019-06-25  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
  63         NULL check.
  64
  65 2019-06-25  Tom Tromey  <tom@tromey.com>
  66
  67         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
  68         Inline constructor.  Add initializers for members.
  69         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
  70         constructors; now inline in class.
  71
  72 2019-06-25  Tom Tromey  <tom@tromey.com>
  73
  74         * tui/tui-regs.c (tui_show_registers): Update.
  75         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
  76         bool.
  77         * tui/tui-data.c (tui_data_window::clear_detail)
  78         (tui_data_window): Update.
  79
  80 2019-06-25  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-windata.c (tui_display_all_data)
  83         (tui_display_data_from_line, tui_display_data_from)
  84         (tui_check_data_values, tui_data_window::do_scroll_vertical):
  85         Update.
  86         * tui/tui-regs.c (tui_last_regs_line_no)
  87         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
  88         (tui_show_registers, tui_show_register_group)
  89         (tui_display_registers_from, tui_display_reg_element_at_line)
  90         (tui_display_registers_from_line, tui_check_register_values)
  91         (tui_reg_next, tui_reg_prev): Update.
  92         * tui/tui-layout.c (tui_set_layout, show_data): Update.
  93         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
  94         tui_data_window.
  95         (struct tui_win_info) <detail>: Remove.  Add new fields from
  96         tui_data_info.
  97         (TUI_DATA_WIN): Add cast.
  98         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
  99         (~tui_data_window): Simplify.
 100
 101 2019-06-25  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-layout.c (show_source_disasm_command)
 104         (show_source_or_disasm_and_command): Update.
 105         * tui/tui-io.c (update_cmdwin_start_line)
 106         (tui_redisplay_readline): Update.
 107         * tui/tui-data.h (struct tui_command_info): Remove.
 108         (struct tui_win_info) <detail>: Remove command_info member.
 109         (struct tui_data_window) <start_line>: New member, from
 110         tui_command_info.
 111         (TUI_CMD_WIN): Add casts.
 112
 113 2019-06-25  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-winsource.c (tui_update_source_window)
 116         (tui_refill_source_window)
 117         (tui_source_window_base::do_scroll_horizontal)
 118         (tui_update_breakpoint_info, tui_set_exec_info_content)
 119         (tui_show_exec_info_content, tui_erase_exec_info_content)
 120         (tui_clear_exec_info_content): Update.
 121         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 122         Update.
 123         * tui/tui-win.c (make_invisible_and_set_new_height)
 124         (make_visible_with_new_height): Update.
 125         * tui/tui-source.c (tui_set_source_content)
 126         (tui_show_symtab_source): Update.
 127         * tui/tui-layout.c (extract_display_start_addr)
 128         (show_source_disasm_command, show_data)
 129         (make_source_or_disasm_window)
 130         (show_source_or_disasm_and_command): Update.
 131         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 132         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 133         "gdbarch".
 134         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 135         to tui_source_window_base.
 136         (struct tui_win_info) <detail>: Remove source_info member.
 137         (struct tui_source_window_base) <has_locator>: Inline.
 138         Move contents from tui_source_info; rename has_locator member to
 139         m_has_locator.
 140         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 141         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 142         header file.
 143         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 144         Simplify.
 145         (tui_free_all_source_wins_content): Cast to
 146         tui_source_window_base.
 147
 148 2019-06-25  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-win.c (make_invisible_and_set_new_height)
 151         (make_visible_with_new_height): Call has_locator method.
 152         * tui/tui-layout.c (show_source_disasm_command, show_data)
 153         (show_source_or_disasm_and_command): Update for bool change.
 154         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 155         (tui_win_info) <has_locator>: New method.
 156         (struct tui_source_window_base) <has_locator>: New method.
 157         (tui_win_has_locator): Don't declare.
 158         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 159         from tui_win_has_locator.
 160         (tui_source_window_base): Use false, not FALSE.
 161
 162 2019-06-25  Tom Tromey  <tom@tromey.com>
 163
 164         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 165         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 166         clear_detail method directly.
 167         (tui_clear_win_detail): Remove.
 168
 169 2019-06-25  Tom Tromey  <tom@tromey.com>
 170
 171         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 172         "this", not TUI_DISASM_WIN.
 173
 174 2019-06-25  Tom Tromey  <tom@tromey.com>
 175
 176         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 177         declare.
 178         * tui/tui-winsource.c
 179         (tui_source_window_base::do_scroll_horizontal): Rename from
 180         tui_horizontal_source_scroll.
 181         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 182         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 183         from tui_vertical_data_scroll.
 184         * tui/tui-win.h (tui_scroll): Don't declare.
 185         * tui/tui-win.c (tui_win_info::forward_scroll)
 186         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 187         (tui_win_info::right_scroll): Rename and update.
 188         (tui_scroll_forward_command, tui_scroll_backward_command)
 189         (tui_scroll_left_command, tui_scroll_right_command): Update.
 190         (tui_scroll): Remove.
 191         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 192         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 193         from tui_vertical_source_scroll.
 194         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 195         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 196         from tui_vertical_disassem_scroll.
 197         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 198         do_scroll_horizontal>: New methods.
 199         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 200         Likewise.
 201         (struct tui_source_window_base): Add do_scroll_horizontal.
 202         (struct tui_source_window, struct tui_disasm_window): Add
 203         do_scroll_vertical.
 204         (struct tui_data_window, struct tui_cmd_window): Add
 205         do_scroll_horizontal and do_scroll_vertical.
 206         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 207
 208 2019-06-25  Tom Tromey  <tom@tromey.com>
 209
 210         * tui/tui-data.h (struct tui_source_window_base): New struct.
 211         (struct tui_source_window): Derive from tui_source_window_base.
 212         (struct tui_disasm_window): New struct.
 213         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 214         from tui_source_window::clear_detail.
 215         (tui_source_window_base): Rename from tui_source_window.
 216         (~tui_source_window_base): Rename from ~tui_source_window.
 217         (tui_alloc_win_info): Create a tui_disasm_window.
 218
 219 2019-06-25  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-data.h (struct tui_source_window)
 222         (struct tui_data_window): Declare destructors.
 223         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 224         destructors.
 225         (tui_win_info): Simplify.
 226
 227 2019-06-25  Tom Tromey  <tom@tromey.com>
 228
 229         * tui/tui-winsource.c (tui_display_main)
 230         (tui_update_source_windows_with_addr)
 231         (tui_update_all_breakpoint_info): Update.
 232         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 233         (new_height_ok, parse_scrolling_args): Update.
 234         * tui/tui-stack.c (tui_show_frame_info): Update.
 235         * tui/tui-data.h (struct tui_list): Remove.
 236         (tui_source_windows): Return a reference to a std::vector.
 237         * tui/tui-data.c (source_windows): Now a std::vector.
 238         (tui_source_windows): Change return type.
 239         (tui_clear_source_windows): Rewrite.
 240         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 241         (tui_free_all_source_wins_content): Rewrite.
 242
 243 2019-06-25  Tom Tromey  <tom@tromey.com>
 244
 245         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 246         (struct tui_data_window, struct tui_cmd_window): Declare
 247         clear_detail method.
 248         * tui/tui-data.c (tui_source_window::clear_detail)
 249         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 250         methods.
 251         (tui_clear_win_detail): Simplify.
 252
 253 2019-06-25  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui-layout.c (make_source_window, make_disasm_window)
 256         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 257         Return the new window.
 258         (show_source_disasm_command, show_data)
 259         (show_source_or_disasm_and_command): Update.
 260
 261 2019-06-25  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 264         parameter.  Return the new window.
 265         (show_source_disasm_command): Update and remove NULL check.
 266         (show_source_or_disasm_and_command): Update.
 267
 268 2019-06-25  Tom Tromey  <tom@tromey.com>
 269
 270         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 271
 272 2019-06-25  Tom Tromey  <tom@tromey.com>
 273
 274         * tui/tui-data.h (struct tui_win_info): Make constructor
 275         protected.  Make destructor virtual.  Add initializers.
 276         (tui_source_window, tui_data_window, tui_cmd_window): New
 277         classes.
 278         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 279         constructor.  Add "type" parameter.
 280         (tui_source_window, tui_data_window, tui_cmd_window): New
 281         constructors.
 282         (tui_alloc_win_info): Instantiate the appropriate subclass.
 283
 284 2019-06-25  Tom Tromey  <tom@tromey.com>
 285
 286         * tui/tui-win.c (tui_resize_all): Use delete.
 287         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 288         destructor.
 289         (tui_free_window): Don't declare.
 290         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 291         Update.
 292
 293 2019-06-25  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-data.h (struct tui_win_info): Add constructor.
 296         * tui/tui-data.c (tui_alloc_win_info): Use new.
 297         (tui_free_window): Use delete.
 298
 299 2019-06-22  Tom Tromey  <tom@tromey.com>
 300
 301         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 302         declare.
 303         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 304
 305 2019-06-22  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 308         declare.
 309         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 310
 311 2019-06-22  Tom de Vries  <tdevries@suse.de>
 312
 313         * dwarf2read.c (create_addrmap_from_aranges)
 314         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 315         instead of '%zu'.
 316
 317 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 318
 319         * dwarf2read.h (dwarf2_section_info_def): Remove.
 320         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 321         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 322         std::vector<dwarf2_section_info>.
 323         (struct dwo_file) <~dwo_file>: Remove.
 324         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 325         types field.
 326         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 327         (dwarf2_read_debug_names): Likewise.
 328         (create_debug_types_hash_table): Change parameter type to
 329         array_view, adjust code accordingly.
 330         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 331         (partial_die_info::fixup): Likewise.
 332         (determine_prefix): Likewise.
 333         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 334
 335 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 336
 337         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 338         gdb_bfd_ref_ptr.
 339         <~dwo_file>: Remove call to gdb_bfd_unref.
 340         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 341         gdb_bfd_ref_ptr::get.
 342
 343 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 344
 345         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 346         type to htab_up.
 347         * dwarf2read.c (struct dwo_file): Initialize fields.
 348         <~dwo_file>: New.
 349         (free_dwo_file): Remove, move content to ~dwo_file.
 350         (struct dwo_file_deleter): Remove.
 351         (dwo_file_up>: Remove custom deleter.
 352         (free_dwo_files): Remove.
 353         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 354         dwo_files.
 355         (process_skeletonless_type_units): Call unique_ptr::get.
 356         (allocate_dwo_file_hash_table): Add deleter to created hash
 357         table.  Change return type to htab_up.
 358         (lookup_dwo_file_slot): Don't memset dwo_file, call
 359         unique_ptr::get.
 360         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 361         (create_dwo_unit_in_dwp_v2): Likewise.
 362         (open_and_init_dwo_file): Likewise.
 363         (free_dwo_file_from_slot): Remove.
 364
 365 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 366
 367         * dwarf2read.h (struct dwarf2_section_info) <readin,
 368         is_virtual>: Change type to bool.
 369         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 370         true instead of 1.
 371
 372 2019-06-19  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-data.h (tui_init_content_element): Don't declare.
 375
 376 2019-06-19  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-data.h (tui_init_win_info): Don't declare.
 379
 380 2019-06-19  Tom de Vries  <tdevries@suse.de>
 381
 382         * dwarf2read.h (abstract_to_concrete): Change type to
 383         std::unordered_map<sect_offset, std::vector<sect_offset>,
 384         gdb::hash_enum<sect_offset>>.
 385
 386 2019-06-19  Tom Tromey  <tromey@adacore.com>
 387
 388         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 389         EVAL_AVOID_SIDE_EFFECTS specially.
 390
 391 2019-06-19  Tom Tromey  <tromey@adacore.com>
 392
 393         * source-cache.c (highlighter): New global.
 394         (source_cache::get_source_lines): Create a highlighter on demand.
 395
 396 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 397
 398         * defs.h (deprecated_interactive_hook): Delete declaration.
 399         * interps.c (clear_interpreter_hooks): Remove use of
 400         deprecated_interactive_hook.
 401         * top.c (deprecated_interactive_hook): Delete definition.
 402         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 403
 404 2019-06-18  Tom de Vries  <tdevries@suse.de>
 405
 406         PR gdb/24515
 407         * dwarf2read.h (abstract_to_concrete): Change type from
 408         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 409         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 410         * dwarf2read.c (read_variable): Update.
 411         (dwarf2_fetch_die_loc_sect_off): Update.
 412
 413 2019-06-17  Tom de Vries  <tdevries@suse.de>
 414
 415         PR gdb/24617
 416         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 417         accessing parent[parent_len - 1].
 418
 419 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 420
 421         PR gdb/24364
 422         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 423         call dtrace_process_dof with NULL dof.
 424
 425 2019-06-16  Tom de Vries  <tdevries@suse.de>
 426
 427         PR gdb/24445
 428         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 429
 430 2019-06-16  Tom Tromey  <tom@tromey.com>
 431
 432         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 433         (make_all_visible): Use address of member.
 434
 435 2019-06-16  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 438         (tui_free_window, free_content, free_content_elements): Remove
 439         unnecessary cast.
 440         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 441         cast.
 442         * tui/tui-regs.c (tui_show_register_group)
 443         (tui_display_registers_from, tui_display_reg_element_at_line):
 444         Remove unnecessary cast.
 445
 446 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 447
 448         * linux-nat.c (normal_mask): Delete.
 449         (_initialize_linux_nat): Don't initialise normal_mask.
 450
 451 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 452
 453         PR gdb/24445
 454         * dwarf-index-write.h (write_psymtabs_to_index): Add
 455         dwz_basename parameter.
 456         * dwarf-index-write.c (write_gdbindex): Move file writing to
 457         write_gdbindex_1.  Change return type void.
 458         (assert_file_size): Move up, remove filename parameter.
 459         (write_gdbindex_1): New function.
 460         (write_debug_names): Change return type to void, call
 461         assert_file_size.
 462         (struct index_wip_file): New struct.
 463         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 464         file logic to index_wip_file.  Write index for dwz file if
 465         needed.
 466         (save_gdb_index_command): Pass basename of dwz file, if present.
 467         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 468         build-id of dwz file, if present.
 469         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 470         (dwarf2_get_dwz_file): Likewise.
 471         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 472         (dwarf2_get_dwz_file): Likewise.
 473
 474 2019-06-16  Tom Tromey  <tom@tromey.com>
 475
 476         * coffread.c (process_coff_symbol): Use xstrdup.
 477         * value.c (create_internalvar): Use xstrdup.
 478
 479 2019-06-16  Tom Tromey  <tom@tromey.com>
 480
 481         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 482         * breakpoint.c (stopin_command, stopat_command)
 483         (until_break_command, decode_location_default): Remove unnecessary
 484         cast.
 485         * utils.c (subset_compare): Remove unnecessary cast.
 486         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 487         cast.
 488         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 489         cast.
 490         * infcmd.c (path_command): Remove unnecessary cast.
 491         * coffread.c (decode_type): Remove unnecessary cast.
 492         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 493         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 494         * tui/tui-stack.c (tui_show_locator_content)
 495         (tui_show_frame_info): Remove unnecessary cast.
 496         * tui/tui-win.c (tui_scroll_forward_command)
 497         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 498         (parse_scrolling_args): Remove unnecessary cast.
 499         * tui/tui-data.c (init_win_info, tui_del_window)
 500         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 501         (free_content_elements): Remove unnecessary cast.
 502         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 503         unnecessary cast.
 504         * tui/tui-source.c (tui_set_source_content)
 505         (tui_vertical_source_scroll): Remove unnecessary cast.
 506         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 507         cast.
 508         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 509         * tui/tui-regs.c (tui_display_registers_from)
 510         (tui_display_register): Remove unnecessary cast.
 511         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 512         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 513         (make_visible): Remove unnecessary cast.
 514         * tui/tui-winsource.c (tui_erase_source_content)
 515         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 516         unnecessary cast.
 517         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 518         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 519         * stabsread.c (read_type, read_array_type, read_range_type):
 520         Remove unnecessary cast.
 521         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 522         (parse_symbol, parse_type, upgrade_type, parse_external)
 523         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 524         unnecessary cast.
 525         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 526
 527 2019-06-16  Tom Tromey  <tom@tromey.com>
 528
 529         * tui/tui-data.c (tui_alloc_generic_win_info)
 530         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 531         checks.
 532
 533 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 534             Andrew Burgess  <andrew.burgess@embecosm.com>
 535
 536         * f-typeprint.c (f_print_type): Don't return early for not
 537         associated or not allocated types.
 538         (f_type_print_varspec_suffix): Add print_rank parameter and print
 539         ranks of array types in case they dangling.
 540         (f_type_print_base): Add print_rank parameter.
 541
 542 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 543
 544         * NEWS: Mention new MI commands.
 545         * break-catch-throw.c (enum exception_event_kind): Move to
 546         breakpoint.h.
 547         (print_mention_exception_catchpoint): Output text as a single
 548         message.
 549         (catch_exception_command_1): Rename to...
 550         (catch_exception_event): ...this, make non-static, update header
 551         command, and change some parameter types.
 552         (catch_catch_command): Update for changes to
 553         catch_exception_command_1.
 554         (catch_throw_command): Likewise.
 555         (catch_rethrow_command): Likewise.
 556         * breakpoint.c (enum exception_event_kind): Delete.
 557         * breakpoint.h (enum exception_event_kind): Moved here from
 558         break-catch-throw.c.
 559         (catch_exception_event): Declare.
 560         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 561         (mi_cmd_catch_throw): New function.
 562         (mi_cmd_catch_rethrow): New function.
 563         (mi_cmd_catch_catch): New function.
 564         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 565         'catch-catch' entries.
 566         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 567         (mi_cmd_catch_rethrow): Declare.
 568         (mi_cmd_catch_catch): Declare.
 569
 570 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 571
 572         * annotate.c (annotate_source_line): Change return type to void,
 573         update implementation to match.
 574         * annotate.h (annotate_source_line): Change return type to void,
 575         update header comment.
 576         * stack.c (print_frame_info): Don't change what frame information
 577         is printed based on whether annotations are on or not.
 578
 579 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 580
 581         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 582         (annotate_source): Make static.
 583         (annotate_source_line): Moved from source.c and renamed from
 584         identify_source_line.  Update the return type.
 585         * annotate.h (annotate_source): Delete declaration.
 586         (annotate_source_line): Declaration moved from source.h, and
 587         renamed from identify_source_line.  Return type updated.
 588         * source.c (identify_source_line): Moved to annotate.c and renamed
 589         to annotate_source_line.
 590         (info_line_command): Remove check of annotation_level.
 591         * source.h (identify_source_line): Move declaration to annotate.h
 592         and rename to annotate_source_line.
 593         * stack.c: Add 'annotate.h' include.
 594         (print_frame_info): Remove check of annotation_level before
 595         calling annotate_source_line.
 596
 597 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 598
 599         * source-cache.c (source_cache::get_plain_source_lines): Use
 600         open_source_file_with_line_charpos instead of just
 601         open_source_file, remove call to find_source_lines.
 602         (source_cache::get_source_lines): Likewise.
 603         * source.c (find_source_lines): Make static.
 604         (get_filename_and_charpos): Renamed into...
 605         (open_source_file_with_line_charpos): ..this along with changes to
 606         return a scoped_fd, and some other minor clean ups.
 607         (identify_source_line): Use open_source_file_with_line_charpos.
 608         (search_command_helper): Use open_source_file_with_line_charpos
 609         instead of just open_source_file, remove call to
 610         find_source_lines.
 611         * source.h (open_source_file_with_line_charpos): Declare new
 612         function.
 613         (find_source_lines): Delete declaration.
 614
 615 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 616
 617         * source.c (get_filename_and_charpos): Remove fullname
 618         parameter.
 619         (identify_source_line): Update call to get_filename_and_charpos.
 620
 621 2019-06-14  Tom Tromey  <tromey@adacore.com>
 622
 623         PR gdb/24502:
 624         * ui-style.h (skip_ansi_escape): Update comment.
 625         * ui-file.h (class no_terminal_escape_file): New class.
 626         * ui-file.c (no_terminal_escape_file::write)
 627         (no_terminal_escape_file::puts): New methods.
 628         * cli/cli-logging.c (handle_redirections): Use
 629         no_terminal_escape_file.
 630
 631 2019-06-14  Tom Tromey  <tromey@adacore.com>
 632
 633         * NEWS: Move convenience variable news above Python news.
 634
 635 2019-06-14  Tom Tromey  <tom@tromey.com>
 636
 637         * gnulib: Move directory to top-level.
 638         * configure.ac: Don't configure gnulib.
 639         * configure: Rebuild.
 640         * common/common-defs.h: Use new path to gnulib.
 641         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 642         (GNULIB_H): Remove.
 643         (INCGNU): Look in new gnulib location.
 644         (HFILES_NO_SRCDIR): Remove gnulib files.
 645         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 646         (generated_files): Remove GNULIB_H.
 647         ($(LIBGNU), all-lib): Remove targets.
 648         (distclean): Don't mention GNULIB_BUILDDIR.
 649         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 650
 651 2019-06-14  Tom Tromey  <tromey@adacore.com>
 652
 653         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 654         Warn if symbol file does not provide any symbols.
 655
 656 2019-06-14  Tom Tromey  <tromey@adacore.com>
 657
 658         * source.c (find_and_open_source): Respect basenames_may_differ.
 659
 660 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 661
 662         * annotate.c (annotate_breakpoints_invalid): Make use of
 663         scoped_restore_terminal_state.
 664         (annotate_frames_invalid): Likewise.
 665
 666 2019-06-14  Tom Tromey  <tromey@adacore.com>
 667
 668         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 669         allow assignment to an internalvar.
 670
 671 2019-06-14  Tom Tromey  <tromey@adacore.com>
 672
 673         * ada-lex.l: Allow "_" in attribute names.
 674
 675 2019-06-14  Tom Tromey  <tromey@adacore.com>
 676
 677         PR gdb/24653:
 678         * regcache.c (registers_changed): Don't call alloca.
 679         * top.c (execute_command): Don't call alloca.
 680
 681 2019-06-13  Pedro Alves  <palves@redhat.com>
 682
 683         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 684         'expression'.  When parsing an expression, error out if there's
 685         junk after "unlimited".
 686         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 687         (do_set_command): Adjust calls to is_unlimited_literal.
 688
 689 2019-06-13  Pedro Alves  <palves@redhat.com>
 690
 691         * compile/compile.c (make_compile_options_def_group): Add braces
 692         around array_view initializer.
 693         * thread.c (make_thread_apply_all_options_def_group)
 694         (make_thread_apply_all_options_def_group): Likewise.
 695
 696 2019-06-13  Pedro Alves  <palves@redhat.com>
 697
 698         * NEWS (New commands): Mention "maint test-options
 699         require-delimiter", "maint test-options unknown-is-error", "maint
 700         test-options unknown-is-operand" and "maint show
 701         test-options-completion-result".
 702         (New command options, command completion): New section.
 703         (Completion improvements): New section.
 704         Mention that you can abbreviate "unlimited".
 705
 706 2019-06-13  Pedro Alves  <palves@redhat.com>
 707
 708         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 709         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 710         * unittests/cli-utils-selftests.c (test_parse_flags)
 711         (test_parse_flags_qcs): Delete.
 712         (test_cli_utils): Don't call deleted functions.
 713
 714 2019-06-13  Pedro Alves  <palves@redhat.com>
 715
 716         * thread.c: Include "cli/cli-option.h".
 717         (tp_array_compar_ascending): Global.
 718         (tp_array_compar): Delete function.
 719         (tp_array_compar_ascending, tp_array_compar_descending): New
 720         functions.
 721         (ascending_option_def, qcs_flag_option_def)
 722         (thr_qcs_flags_option_defs)
 723         (make_thread_apply_all_options_def_group)
 724         (make_thread_apply_options_def_group): New.
 725         (thread_apply_all_command): Use gdb::option::process_options.
 726         (thread_apply_command_completer)
 727         (thread_apply_all_command_completer): New.
 728         (thread_apply_command): Use gdb::option::process_options.
 729         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 730         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 731         to generate help text of "thread apply".  Adjust "taas"'s help.
 732         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 733         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 734
 735 2019-06-13  Pedro Alves  <palves@redhat.com>
 736
 737         * thread.c (thread_apply_command): Check for invalid TID with
 738         isdigit instead of !isalpha.
 739
 740 2019-06-13  Pedro Alves  <palves@redhat.com>
 741
 742         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 743         (validate_flags_qcs): New.
 744         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 745         (validate_flags_qcs): Declare.
 746         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 747         (make_frame_apply_options_def_group): New.
 748         (frame_apply_command_count): Process options with
 749         gdb::option::process_options.
 750         (frame_apply_completer): New.
 751         (frame_apply_level_completer, frame_apply_all_completer)
 752         (frame_apply_completer): New.
 753         (_initialize_stack): Update help of "frame apply", "frame apply
 754         level", "frame apply all" and "faas" to mention supported options
 755         and install command completers.
 756         * stack.h (frame_apply_all_completer): Declare.
 757         * thread.c: Include "stack.h".
 758         (tfaas_command): Add "--".
 759         (_initialize_thread): Update help "tfaas" to mention supported
 760         options and install command completer.
 761
 762 2019-06-13  Pedro Alves  <palves@redhat.com>
 763
 764         * completer.c (complete_nested_command_line): New.
 765         (gdb_completion_word_break_characters_throw): Add assertion.
 766         * completer.h (complete_nested_command_line): Declare.
 767
 768 2019-06-13  Pedro Alves  <palves@redhat.com>
 769
 770         * stack.c (parse_backtrace_qualifiers): New.
 771         (backtrace_command): Use it.
 772         (backtrace_command_completer): Complete on qualifiers.
 773
 774 2019-06-13  Pedro Alves  <palves@redhat.com>
 775
 776         * frame.c: Include "cli/cli-option.h.
 777         (user_set_backtrace_options): New.
 778         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 779         Delete.
 780         (get_prev_frame): Adjust.
 781         (boolean_option_def, uinteger_option_def)
 782         (set_backtrace_option_defs): New.
 783         (_initialize_frame): Adjust and use
 784         gdb::option::add_setshow_cmds_for_options to install "set
 785         backtrace past-main" and "set backtrace past-entry".
 786         * frame.h: Include "cli/cli-option.h".
 787         (struct frame_print_options): Forward declare.
 788         (print_frame_arguments_all, print_frame_arguments_scalars)
 789         (print_frame_arguments_none): Declare.
 790         (print_entry_values): Delete declaration.
 791         (struct frame_print_options, user_frame_print_options): New.
 792         (struct set_backtrace_options): New.
 793         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 794         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 795         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 796         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 797         (list_args_or_locals): Add frame_print_options parameter.
 798         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 799         * python/py-framefilter.c (enumerate_args): Pass down
 800         USER_FRAME_PRINT_OPTIONS.
 801         * stack.c: Include "cli/cli-option.h".
 802         (print_frame_arguments_all, print_frame_arguments_scalars)
 803         (print_frame_arguments_none): Declare.
 804         (print_raw_frame_arguments, print_entry_values): Delete.
 805         (user_frame_print_options): New.
 806         (boolean_option_def, enum_option_def, frame_print_option_defs):
 807         New.
 808         (struct backtrace_cmd_options): New.
 809         (bt_flag_option_def): New.
 810         (backtrace_command_option_defs): New.
 811         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 812         (print_frame_arg, read_frame_arg, print_frame_args)
 813         (print_frame_info, print_frame): Add frame_print_options parameter
 814         and use it.
 815         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 816         (backtrace_command_1): Add frame_print_options and
 817         backtrace_cmd_options parameters and use them.
 818         (make_backtrace_options_def_group): New.
 819         (backtrace_command): Process command options with
 820         gdb::option::process_options.
 821         (backtrace_command_completer): New.
 822         (_initialize_stack): Extend "backtrace"'s help to mention
 823         supported options.  Install completer for "backtrace".
 824         Install some settings commands with add_setshow_cmds_for_options.
 825
 826 2019-06-13  Pedro Alves  <palves@redhat.com>
 827
 828         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 829         and that "set/show print raw frame-arguments" are now deprecated.
 830
 831         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 832         command.
 833         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 834         * stack.c (_initialize_stack): Install "set/show print
 835         raw-frame-arguments", and deprecate "set/show print raw
 836         frame-arguments".
 837         * valprint.c (_initialize_valprint): Deprecate "set/show print
 838         raw".
 839
 840 2019-06-13  Pedro Alves  <palves@redhat.com>
 841
 842         * compile/compile.c (struct compile_options): New.
 843         (compile_flag_option_def, compile_command_option_defs)
 844         (make_compile_options_def_group): New.
 845         (compile_file_command): Handle options with
 846         gdb::option::process_options.
 847         (compile_file_command_completer): New function.
 848         (compile_code_command): Handle options with
 849         gdb::option::process_options.
 850         (compile_code_command_completer): New function.
 851         (_initialize_compiler): Install completers for "compile code" and
 852         "compile file".  Mention available options in "compile code" and
 853         "compile code"'s help.
 854         * completer.c (advance_to_completion_word): New, factored out from
 855         ...
 856         (advance_to_expression_complete_word_point): ... this.
 857         (advance_to_filename_complete_word_point): New.
 858         * completer.h (advance_to_filename_complete_word_point): New
 859         declaration.
 860
 861 2019-06-13  Pedro Alves  <palves@redhat.com>
 862
 863         * compile/compile.c: Include "cli/cli-option.h".
 864         (compile_print_value): Scope data pointer is now a
 865         value_print_options pointer; adjust.
 866         (compile_print_command): Process options.  Scope data pointer is
 867         now a value_print_options pointer; adjust.
 868         (_initialize_compile): Update "compile print"'s help to include
 869         supported options.  Install a completer for "compile print".
 870         * cp-valprint.c (show_vtblprint, show_objectprint)
 871         (show_static_field_print): Delete.
 872         (_initialize_cp_valprint): Don't install "set print
 873         static-members", "set print vtbl", "set print object" here.
 874         * printcmd.c: Include "cli/cli-option.h" and
 875         "common/gdb_optional.h".
 876         (print_command_parse_format): Rework to fill in a
 877         value_print_options instead of a format_data.
 878         (print_value): Change parameter type from format_data pointer to
 879         value_print_options reference.  Adjust.
 880         (print_command_1): Process options.  Adjust to pass down a
 881         value_print_options.
 882         (print_command_completer): New.
 883         (_initialize_printcmd): Install print_command_completer as
 884         handle_brkchars completer for the "print" command.  Update
 885         "print"'s help to include supported options.
 886         * valprint.c: Include "cli/cli-option.h".
 887         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 888         here from cp-valprint.c.
 889         (boolean_option_def, uinteger_option_def)
 890         (value_print_option_defs, make_value_print_options_def_group):
 891         New.  Use gdb::option::add_setshow_cmds_for_options to install
 892         "set print elements", "set print null-stop", "set print repeats",
 893         "set print pretty", "set print union", "set print array", "set
 894         print address", "set print symbol", "set print array-indexes".
 895         * valprint.h: Include <string> and "cli/cli-option.h".
 896         (make_value_print_options_def_group): Declare.
 897         (print_value): Change parameter type from format_data pointer to
 898         value_print_options reference.
 899         (print_command_completer): Declare.
 900
 901 2019-06-13  Pedro Alves  <palves@redhat.com>
 902
 903         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 904         (COMMON_SFILES): Add maint-test-settings.c.
 905         * cli/cli-decode.c (boolean_enums): New global, factored out from
 906         ...
 907         (add_setshow_boolean_cmd): ... here.
 908         * cli/cli-decode.h (boolean_enums): Declare.
 909         * cli/cli-option.c: New file.
 910         * cli/cli-option.h: New file.
 911         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 912         factored out from ...
 913         (parse_cli_boolean_value(const char *)): ... this.
 914         (is_unlimited_literal): Change parameter type to pointer to
 915         pointer.  Adjust and advance ARG pointer.
 916         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 917         (parse_cli_var_enum): New, factored out from ...
 918         (do_set_command): ... this.  Adjust.
 919         * cli/cli-setshow.h (parse_cli_boolean_value)
 920         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 921         (parse_cli_var_enum): Declare.
 922         * cli/cli-utils.c: Include "cli/cli-option.h".
 923         (get_ulongest): New.
 924         * cli/cli-utils.h (get_ulongest): Declare.
 925         (check_for_argument): New overloads.
 926         * maint-test-options.c: New file.
 927
 928 2019-06-13  Pedro Alves  <palves@redhat.com>
 929
 930         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 931         parse a range if "-" is at the end of the string.
 932
 933 2019-06-13  Pedro Alves  <palves@redhat.com>
 934
 935         * cli/cli-setshow.c (parse_auto_binary_operation)
 936         (parse_cli_boolean_value): Don't allow "o".
 937
 938 2019-06-13  Pedro Alves  <palves@redhat.com>
 939
 940         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 941         * NEWS: Mention maint test-settings KIND.
 942         * maint-test-settings.c: New file.
 943
 944 2019-06-13  Pedro Alves  <palves@redhat.com>
 945
 946         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 947         completer.
 948         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 949         "set" completers.
 950
 951 2019-06-13  Pedro Alves  <palves@redhat.com>
 952
 953         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 954         after item.
 955
 956 2019-06-13  Pedro Alves  <palves@redhat.com>
 957
 958         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 959
 960 2019-06-13  Pedro Alves <palves@redhat.com>
 961
 962         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 963         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 964         call.
 965         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 966         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 967         calls.
 968         (check_for_argument): Skip spaces after argument.
 969
 970 2019-06-13  Pedro Alves  <palves@redhat.com>
 971
 972         * thread.c (thread_apply_command): Adjust TID parsing.
 973         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 974         detected before end of string.
 975         (tid_is_in_list): Error out if LIST is invalid.
 976
 977 2019-06-13  Pedro Alves  <palves@redhat.com>
 978
 979         * completer.c (complete_line_internal_1): Rewind completion word
 980         point.
 981         (completion_tracker::advance_custom_word_point_by): Change
 982         parameter type to int.
 983         * completer.h (completion_tracker::advance_custom_word_point_by):
 984         Likewise.
 985
 986 2019-06-13  Pedro Alves  <palves@redhat.com>
 987
 988         * completer.c (advance_to_completion_word): Handle delimiters.
 989
 990 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 991
 992         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 993
 994 2019-06-11  Tom Tromey  <tom@tromey.com>
 995
 996         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 997         (xmalloc_failed): Move to alloc.c.
 998         * alloc.c: New file.
 999         * Makefile.in (COMMON_SFILES): Add alloc.c.
1000
1001 2019-06-11  Tom Tromey  <tom@tromey.com>
1002
1003         * nat/linux-waitpid.c: Don't include server.h.
1004         (linux_debug): Remove.
1005         (my_waitpid): Update.
1006
1007 2019-06-11  Tom Tromey  <tromey@adacore.com>
1008
1009         * infcall.c (_initialize_infcall): Remove trailing newline from
1010         help.
1011         * user-regs.c (_initialize_user_regs): Remove trailing newline
1012         from help.
1013         * typeprint.c (_initialize_typeprint): Remove trailing newline
1014         from help.
1015         * reverse.c (_initialize_reverse): Remove trailing newlines from
1016         help.
1017         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1018         from help.
1019         * language.c (add_set_language_command): Remove trailing newline
1020         from help.
1021         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1022         help.
1023         * disasm.c (_initialize_disasm): Remove trailing newline from
1024         help.
1025         * top.c (init_main): Remove trailing newline from help.
1026         * interps.c (_initialize_interpreter): Remove trailing newline
1027         from help.
1028         * btrace.c (_initialize_btrace): Remove trailing newlines from
1029         help.
1030         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1031         from help.
1032         * python/python.c (_initialize_python): Remove trailing newline
1033         from help.
1034         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1035         help.
1036         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1037         from help.  Reformat some text.
1038         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1039         from help.
1040         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1041         newline from help.
1042
1043 2019-06-11  Tom Tromey  <tromey@adacore.com>
1044
1045         * darwin-nat.c (darwin_decode_exception_message)
1046         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1047
1048 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1049
1050         * valops.c (value_slice): Check for not allocated or not
1051         associated values.
1052
1053 2019-06-10  Tom de Vries  <tdevries@suse.de>
1054
1055         PR gdb/24618
1056         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1057         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1058         invalid.
1059
1060 2019-06-10  Tom de Vries  <tdevries@suse.de>
1061
1062         PR gdb/24611
1063         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1064         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1065
1066 2019-06-10  Tom de Vries  <tdevries@suse.de>
1067
1068         PR symtab/24545
1069         * symtab.c (struct demangled_name_entry): Add language field.
1070         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1071         static minimal symbol".  Set and use language field.
1072
1073 2019-06-10  Tom Tromey  <tromey@adacore.com>
1074
1075         * ada-lang.c (_initialize_ada_language): Update help text.
1076
1077 2019-06-10  Tom Tromey  <tromey@adacore.com>
1078
1079         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1080         with a newline.
1081         * guile/guile.c (handle_boot_error): Don't end warning with a
1082         newline.
1083         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1084         warning with a newline.
1085         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1086         newline.
1087         (s12z_frame_cache): Likewise.
1088         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1089         a newline.
1090         * solib-svr4.c (disable_probes_interface): Don't end warning with
1091         a newline.
1092         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1093         newline.
1094         * python/python.c (do_finish_initialization): Don't end warning
1095         with a newline.
1096
1097 2019-06-10  Tom Tromey  <tom@tromey.com>
1098
1099         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1100         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1101         gdbpy_enter.
1102
1103 2019-06-10  Tom Tromey  <tromey@adacore.com>
1104
1105         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1106         data.
1107         (elf_new_init): Don't call stabsread_new_init.
1108         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1109         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1110         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1111
1112 2019-06-10  Tom de Vries  <tdevries@suse.de>
1113
1114         PR symtab/16264
1115         PR symtab/24517
1116         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1117
1118 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1119
1120         * source.c (find_and_open_source): Also rewrite relative file
1121         names.
1122
1123 2019-04-26  Amos Bird  <amosbird@gmail.com>
1124
1125         * annotate.c (annotate_thread_exited): Add "thread-exited"
1126         annotation.
1127
1128 2019-06-06  Tom Tromey  <tromey@adacore.com>
1129
1130         * maint.h (class scoped_command_stats): Use
1131         DISABLE_COPY_AND_ASSIGN.
1132         <print_time>: New method.
1133         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1134         print_time.
1135         (scoped_command_stats::print_time): New method.
1136
1137 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1138
1139         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1140         instructions of lengths 6 or 8 bytes.
1141
1142 2019-06-04  Pedro Alves  <palves@redhat.com>
1143
1144         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1145
1146         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1147         * breakpoint.c (condition_completer): Likewise.
1148         * cli/cli-dump.c (scan_expression): Likewise.
1149         * common/filestuff.c (mkdir_recursive): Likewise.
1150         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1151         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1152         (gdb_abspath): Likewise.
1153         * compile/compile-cplus-types.c
1154         (compile_cplus_instance::decl_name): Likewise.
1155         * completer.c (complete_explicit_location):
1156         (signal_completer, reg_or_group_completer_1): Likewise.
1157         * cp-support.c (cp_remove_params_if_any): Likewise.
1158         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1159         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1160         * infcmd.c (strip_bg_char): Likewise.
1161         * linespec.c (copy_token_string): Likewise.
1162         * mi/mi-main.c (output_cores): Likewise.
1163         * psymtab.c (psymtab_search_name):
1164         * symfile.c (test_set_ext_lang_command): Likewise.
1165         * target.c (target_fileio_read_stralloc): Likewise.
1166         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1167         * value.c (complete_internalvar): Likewise.
1168
1169 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1170
1171         Add objfile property to gdb.Type.
1172         * NEWS: Mention Python API addition.
1173         * python/py-type.c (typy_get_objfile): New method.
1174
1175 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1176
1177         * NEWS: Mention the new set|show style [title|highlight].
1178         Mention changes to "show style", "help" and "apropos".
1179
1180 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1181
1182         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1183         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1184         instead of print_help_for_command.
1185         (print_doc_of_command): New function.
1186         (help_list): Add 'apropos -v word' suggestion.
1187         (print_help_for_command): Style the command name using title style.
1188         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1189         (_initialize_cli_cmds): Describe -v in apropos_command help.
1190
1191 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1192
1193         * cli/cli-style.h (cli_style_option): Add name in constructor,
1194         add m_name class member, add constructor with intensity,
1195         add name class function.
1196         (cli_style_option::add_setshow_commands): Remove name argument.
1197         (highlight_style, title_style): New styles.
1198         * cli/cli-style.c (do_show): New function that shows a style
1199         characteristic styling the style name with itself.
1200         (set_style_name): New function.
1201         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1202         Update all callers according to the changes in cli/cli-style.h.
1203         * utils.h (fputs_highlighted): New function.
1204         * utils.c (fputs_highlighted): Likewise.
1205
1206 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1207
1208         * NEWS: Mention new pipe command and new convenience variables.
1209
1210 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1211
1212         * cli/cli-cmds.c (pipe_command): New function.
1213         (_initialize_cli_cmds): Call add_com for pipe_command.
1214         Define | as an alias for pipe.
1215         (exit_status_set_internal_vars): New function.
1216         (shell_escape): Call exit_status_set_internal_vars.
1217         cli/cli-decode.c (find_command_name_length): Recognize | as
1218         a single character command.
1219
1220 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1221
1222         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1223         top.c (execute_command_to_ui_file): New function, mostly a copy
1224         of execute_command_to_string.
1225         (execute_command_to_string): Implement by calling
1226         execute_command_to_ui_file.
1227
1228 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1229
1230         * top.h (saved_command_line): Remove declaration.
1231         * top.c (previous_saved_command_line, previous_repeat_arguments):
1232         New variables.
1233         (saved_command_line): Make static, define together with other
1234         'repeat variables'.
1235         (dont_repeat): Clear repeat_arguments.
1236         (repeat_previous, get_saved_command_line, save_command_line):
1237         New functions.
1238         (gdb_init): Initialize saved_command_line
1239         and previous_saved_command_line.
1240         * main.c (captured_main_1): Remove saved_command_line initialization.
1241         * event-top.c (handle_line_of_input): Update to use
1242         the new 'repeat' related functions instead of direct access to
1243         saved_command_line.
1244         * command.h (repeat_previous, get_saved_command_line,
1245         save_command_line): New declarations.
1246         (dont_repeat): Add comment.
1247
1248 2019-05-30  Tom Tromey  <tromey@adacore.com>
1249
1250         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1251         Fix comment.
1252         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1253
1254 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1255
1256         PR cli/24587
1257         * completer.c (complete): Initialize variable word.
1258
1259 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1260
1261         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1262         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1263         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1264         'body' is NULL to the outter 'if', protecting the '!is_define'
1265         situation as well.
1266
1267 2019-05-29  Tom Tromey  <tromey@adacore.com>
1268
1269         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1270         (dwarf_unknown): New function.
1271         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1272         (dwarf_type_encoding_name): Use dwarf_unknown.
1273
1274 2019-05-29  Tom Tromey  <tromey@adacore.com>
1275
1276         PR c++/20020:
1277         * cp-valprint.c (cp_print_value_fields): Call
1278         cp_print_static_field inside "try".
1279
1280 2019-05-29  Tom Tromey  <tromey@adacore.com>
1281
1282         * inflow.c (struct terminal_info): Add default operator=.
1283         * configure: Rebuild.
1284         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1285         -Wdeprecated-copy-dtor, -Wredundant-move.
1286
1287 2019-05-29  Tom Tromey  <tromey@adacore.com>
1288
1289         * NEWS: Add entry.
1290         * infcmd.c (print_return_value_1): Handle finish_print
1291         option.
1292         (show_print_finish): New function.
1293         (_initialize_infcmd): Add "set/show print finish" commands.
1294         * valprint.c (user_print_options): Initialize new member.
1295         * valprint.h (struct value_print_options) <finish_print>: New
1296         member.
1297
1298 2019-05-28  Tom Tromey  <tromey@adacore.com>
1299
1300         * ada-lang.c (ada_remove_Xbn_suffix)
1301         (find_old_style_renaming_symbol)
1302         (parse_old_style_renaming): Remove.
1303         (ada_find_renaming_symbol): Don't call
1304         find_old_style_renaming_symbol.
1305         (ada_is_renaming_symbol): Rename from
1306         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1307         bool.  Now static.
1308         (ada_read_var_value): Update and simplify.
1309         * ada-exp.y (write_var_or_type): Remove old code.
1310
1311 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1312
1313         * event-top.c: Remove include comment.
1314         * inflow.c (class scoped_ignore_sigttou): Move from here...
1315         * inflow.h (class scoped_ignore_sigttou): ...to here.
1316         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1317         * top.c:  Remove include comment.
1318
1319 2019-05-27  Tom Tromey  <tom@tromey.com>
1320
1321         * NEWS: Fix typo.
1322
1323 2019-05-22  Tom Tromey  <tromey@adacore.com>
1324
1325         * target.c (target_follow_exec): Constify parameter.
1326         * target-delegates.c: Rebuild.
1327         * remote.c (remote_target::follow_exec): Constify parameter.
1328         * infrun.c (follow_exec): Constify parameter.
1329         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1330         (target_follow_exec): Likewise.
1331
1332 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1333
1334         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1335         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1336
1337 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1338
1339         * NEWS: Add debugredirect and testsuite sections.
1340
1341 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1342
1343         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1344         target descriptions using exclusively floating point register name
1345         aliases.
1346
1347 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1348
1349         PR gdb/18644:
1350         * f-lang.c (build_fortran_types): Handle the case where
1351         gdbarch_floatformat_for_type returns a nullptr.
1352
1353 2019-05-21  Tom de Vries  <tdevries@suse.de>
1354
1355         PR cli/24587
1356         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1357
1358 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1359
1360         PR gdb/18644:
1361         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1362         16-byte floats.
1363         * i386-tdep.c (i386_floatformat_for_type): Use
1364         floatformats_ia64_quad for the 16-byte floating point component
1365         within a fortran 32-byte complex number.
1366
1367 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1368
1369         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1370         delete default constructor.
1371         (find_partial_die): Update to return const struct.
1372         (partial_die_parent_scope): Move variable declaration into scope
1373         of its use and change its type to auto.
1374         (guess_partial_die_structure_name): Likewise.
1375         (partial_die_info::fixup): Likewise.
1376
1377 2019-05-17  Tom Tromey  <tromey@adacore.com>
1378
1379         * source.c (find_and_open_source): Remove cast.
1380
1381 2019-05-17  Tom Tromey  <tromey@adacore.com>
1382
1383         * annotate.c (annotate_source): Make "filename" const.
1384         * annotate.h (annotate_source): Use const.
1385
1386 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1387
1388         * disasm.c (set_disassembler_options): Send errors to stderr.
1389
1390 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1391
1392         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1393         (cli_interp_base::set_logging): Check debug_redirect.
1394         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1395         * cli/cli-logging.c (debug_redirect): Add static variable.
1396         (pop_output_files): Add default param.
1397         (handle_redirections): Print debug setting.
1398         (show_logging_command): Likewise.
1399         (_initialize_cli_logging): Add debugredirect command.
1400         * interps.c (current_interp_set_logging): Add debug_redirect
1401         parameter.
1402         * interps.h (set_logging): Add debug_redirect parameter.
1403         (current_interp_set_logging): Likewise.
1404         * mi/mi-common.h: Likewise.
1405         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1406
1407 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1408             Tom Tromey  <tromey@adacore.com>
1409
1410         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1411         directly.
1412         * cli/cli-interp.h (make_logging_output): Remove declaration.
1413         * cli/cli-logging.c (make_logging_output): Remove function.
1414         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1415         directly.
1416         * ui-file.c (tee_file::tee_file): Remove bools.
1417         (tee_file::~tee_file): Remove deletes.
1418         * ui-file.h (tee_file): Remove bools.
1419
1420 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1421
1422         * mi/mi-cmds.h (mi_cmd_complete): New function.
1423         * mi/mi-main.c (mi_cmd_complete): Likewise.
1424         * mi/mi-cmds.c: Define new MI command -complete.
1425         * NEWS: Mention new -complete command.
1426
1427 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1428
1429         * completer.h (complete): New function.
1430         * completer.c (complete): Likewise.
1431         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1432         function defined in completer.h.
1433
1434 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1435
1436         * MAINTAINERS (Write After Approval): Add myself.
1437
1438 2019-05-17  Tom de Vries  <tdevries@suse.de>
1439
1440         PR gdb/24094
1441         * dwarf2read.c (struct cu_partial_die_info): New struct.
1442         (find_partial_die): Return cu_partial_die_info.
1443         (partial_die_parent_scope, guess_partial_die_structure_name)
1444         (partial_die_info::fixup): Handle new return type of find_partial_die.
1445
1446 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1447
1448         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1449         "std::string", simplifying the algorithm.
1450
1451 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1452
1453         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1454         (stap_static_probe_ops::get_probes): Likewise.
1455
1456 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1457
1458         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1459         '-')" and "else if".
1460         (stap_parse_single_operand): Join checks for
1461         "gdbarch_stap_parse_special_token_p" and
1462         "gdbarch_stap_parse_special_token" in the same "if" statement.
1463         Invert check when verifying for operation on register
1464         displacement.
1465
1466 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1467
1468         * stap-probe.c (stap_get_opcode): Update comment.
1469         (stap_get_expected_argument_type): Likewise.
1470         (handle_stap_probe): Likewise.
1471
1472 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1473
1474         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1475         return type to 'bool'.  Adjust comment.  Use 'bool' when
1476         appropriate.
1477         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1478         * stap-probe.c (stap_parse_argument_1): Likewise.
1479         (stap_is_operator): Likewise.
1480         (stap_is_generic_prefix): Likewise.
1481         (stap_is_register_prefix): Likewise.
1482         (stap_is_register_indirection_prefix): Likewise.
1483         (stap_is_integer_prefix): Likewise.
1484         (stap_generic_check_suffix): Likewise.
1485         (stap_check_integer_suffix): Likewise.
1486         (stap_check_register_suffix): Likewise.
1487         (stap_check_register_indirection_suffix): Likewise.
1488         (stap_parse_register_operand): Likewise.
1489         (stap_parse_single_operand): Likewise.
1490         (stap_parse_argument_1): Likewise.
1491         (stap_probe::get_argument_count): Likewise.
1492         (stap_is_operator): Likewise.
1493
1494 2019-05-16  Tom Tromey  <tromey@adacore.com>
1495
1496         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1497         keyword to foreach.
1498
1499 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1500
1501         * linux-thread-db.c (try_thread_db_load_1): Change return type
1502         to bool.
1503         (try_thread_db_load): Likewise.
1504         (try_thread_db_load_from_pdir_1): Likewise.
1505         (try_thread_db_load_from_pdir): Likewise.
1506         (try_thread_db_load_from_sdir): Likewise.
1507         (try_thread_db_load_from_dir): Likewise.
1508         (thread_db_load_search): Likewise.
1509         (has_libpthread): Likewise.
1510         (thread_db_load): Likewise.
1511
1512 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1513
1514         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1515         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1516         NULL, and complain/return if that's the case.
1517
1518 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1519
1520         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1521         (advance, posn, abstract_read_memory): New functions.
1522         [struct mem_read_abstraction]: New struct.
1523         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1524
1525 2019-05-14  Tom Tromey  <tromey@adacore.com>
1526
1527         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1528         value is not lval_memory.
1529
1530 2019-05-14  Tom Tromey  <tromey@adacore.com>
1531
1532         * solib.c (info_sharedlibrary_command): Style the file name.
1533
1534 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1535
1536         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1537         (aarch64_vnv_type): Likewise.
1538         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1539         * common/tdesc.c: Likewise.
1540         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1541         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1542         * features/aarch64-fpu.xml: Add ieee half view.
1543         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1544         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1545         * gdbtypes.h (struct builtin_type): Likewise.
1546         (struct objfile_type): Likewise.
1547
1548 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1549
1550         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1551         typo.
1552         * location.h (string_to_event_location): Likewise.
1553
1554 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1555
1556         GDB 8.3 released.
1557
1558 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1559
1560         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1561         New variable declaration.
1562         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1563         New variable.
1564         (print_one_breakpoint): Use ui_out::test_flags and new global
1565         variable to compute use_fixed_output.
1566         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1567         Remove.
1568         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1569         (mi_multi_location_breakpoint_output_fixed): Remove.
1570         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1571         new variable.
1572         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1573         fix_multi_location_breakpoint_output flag if version >= 3.
1574         * ui-out.h (enum ui_out_flag)
1575         <fix_multi_location_breakpoint_output>: New enumerator.
1576
1577 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1578
1579         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1580
1581 2019-05-10  Tom Tromey  <tromey@adacore.com>
1582
1583         * ada-lang.c (catch_ada_completer): New function.
1584         (_initialize_ada_language): Use it.
1585
1586 2019-05-10  Tom Tromey  <tromey@adacore.com>
1587
1588         * thread.c (print_thread_info): Make "requested_threads" const.
1589         * gdbthread.h (print_thread_info): Make "requested_threads"
1590         const.
1591         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1592         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1593
1594 2019-05-08  Tom Tromey  <tom@tromey.com>
1595
1596         * gdbtypes.c (objfile_type_data): Change type.
1597         (objfile_type, _initialize_gdbtypes): Update.
1598
1599 2019-05-08  Tom Tromey  <tom@tromey.com>
1600
1601         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1602         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1603         (_initialize_dwarf2_frame): Update.
1604
1605 2019-05-08  Tom Tromey  <tom@tromey.com>
1606
1607         * objc-lang.c (objc_objfile_data): Change type.
1608         (find_methods): Update.
1609         (_initialize_objc_lang): Remove.
1610
1611 2019-05-08  Tom Tromey  <tom@tromey.com>
1612
1613         * stabsread.c (rs6000_builtin_type_data): Change type.
1614         (rs6000_builtin_type, _initialize_stabsread): Update.
1615
1616 2019-05-08  Tom Tromey  <tom@tromey.com>
1617
1618         * mips-tdep.c (mips_pdr_data): Remove.
1619         (_initialize_mips_tdep): Update.
1620
1621 2019-05-08  Tom Tromey  <tom@tromey.com>
1622
1623         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1624         (hppa_init_objfile_priv_data, read_unwind_info)
1625         (find_unwind_entry, _initialize_hppa_tdep): Update.
1626
1627 2019-05-08  Tom Tromey  <tom@tromey.com>
1628
1629         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1630         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1631         on obstack.
1632         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1633
1634 2019-05-08  Tom Tromey  <tom@tromey.com>
1635
1636         * mdebugread.c (basic_type_data): Change type.
1637         (basic_type, _initialize_mdebugread): Update.
1638
1639 2019-05-08  Tom Tromey  <tom@tromey.com>
1640
1641         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1642
1643 2019-05-08  Tom Tromey  <tom@tromey.com>
1644
1645         * nto-tdep.c (nto_inferior_data_reg): Change type.
1646         (nto_inferior_data): Update.
1647         (nto_inferior_data_cleanup, nto_new_inferior_data)
1648         (_initialize_nto_tdep): Remove.
1649         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1650
1651 2019-05-08  Tom Tromey  <tom@tromey.com>
1652
1653         * ada-lang.c (struct ada_inferior_data): Add initializers.
1654         (ada_inferior_data): Change type.
1655         (ada_inferior_data_cleanup): Remove.
1656         (get_ada_inferior_data, ada_inferior_exit)
1657         (struct ada_pspace_data): Add initializers, destructor.
1658         (ada_pspace_data_handle): Change type.
1659         (get_ada_pspace_data): Update.
1660         (ada_pspace_data_cleanup): Remove.
1661
1662 2019-05-08  Tom Tromey  <tom@tromey.com>
1663
1664         * coffread.c (struct coff_symfile_info): Add initializers.
1665         (coff_objfile_data_key): Move lower.  Change type.
1666         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1667         Update.
1668         (coff_free_info): Remove.
1669
1670 2019-05-08  Tom Tromey  <tom@tromey.com>
1671
1672         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1673         (fbsd_pspace_data_handle): Move lower.  Change type.
1674         (get_fbsd_pspace_data): Update.
1675         (fbsd_pspace_data_cleanup): Remove.
1676         (_initialize_fbsd_tdep): Update.
1677
1678 2019-05-08  Tom Tromey  <tom@tromey.com>
1679
1680         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1681         (get_ada_tasks_pspace_data): Update.
1682         (ada_tasks_pspace_data_cleanup): Remove.
1683         (_initialize_tasks): Update.
1684         (ada_tasks_inferior_data_handle): Change type.
1685         (get_ada_tasks_inferior_data): Update.
1686         (ada_tasks_inferior_data_cleanup): Remove.
1687         (struct ada_tasks_pspace_data): Add initializers.
1688
1689 2019-05-08  Tom Tromey  <tom@tromey.com>
1690
1691         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1692         * symfile-debug.c (debug_sym_get_probes): Change type.
1693         * stap-probe.c (handle_stap_probe):
1694         (stap_static_probe_ops::get_probes): Change type.
1695         * probe.h (class static_probe_ops) <get_probes>: Change type.
1696         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1697         (parse_probes_in_pspace): Update.
1698         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1699         Update.
1700         (any_static_probe_ops::get_probes): Change type.
1701         * elfread.c (elfread_data): New typedef.
1702         (probe_key): Change type.
1703         (elf_get_probes): Likewise.  Update.
1704         (probe_key_free): Remove.
1705         (_initialize_elfread): Update.
1706         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1707         Change type.
1708         (dtrace_process_dof_probe, dtrace_process_dof)
1709         (dtrace_static_probe_ops::get_probe): Change type.
1710
1711 2019-05-08  Tom Tromey  <tom@tromey.com>
1712
1713         * xcoffread.c (struct xcoff_symfile_info): Rename from
1714         coff_symfile_info.  Add initializers.
1715         (xcoff_objfile_data_key): Move lower.  Change type.
1716         (XCOFF_DATA): Rewrite.
1717         (xcoff_free_info): Remove.
1718         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1719         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1720         (xcoff_initial_scan): Update.
1721
1722 2019-05-08  Tom Tromey  <tom@tromey.com>
1723
1724         * solib-svr4.c (struct svr4_info): Add initializers and
1725         destructor.
1726         <probes_table>: Now an htab_up.
1727         (solib_svr4_pspace_data): Change type.
1728         (free_probes_table): Simplify.
1729         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1730         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1731         (probes_table_remove_objfile_probes, register_solib_event_probe)
1732         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1733         (_initialize_svr4_solib): Update.
1734
1735 2019-05-08  Tom Tromey  <tom@tromey.com>
1736
1737         * remote.c (remote_pspace_data): Change type.
1738         (remote_pspace_data_cleanup): Remove.
1739         (get_remote_exec_file, set_pspace_remote_exec_file)
1740         (_initialize_remote): Update.
1741
1742 2019-05-08  Tom Tromey  <tom@tromey.com>
1743
1744         * breakpoint.c (breakpoint_objfile_key): Change type.
1745         (get_breakpoint_objfile_data): Update.
1746         (free_breakpoint_objfile_data): Remove.
1747         (_initialize_breakpoint): Update.
1748
1749 2019-05-08  Tom Tromey  <tom@tromey.com>
1750
1751         * linux-tdep.c (struct linux_info): Add initializers.
1752         (linux_inferior_data): Move.  Change type.
1753         (invalidate_linux_cache_inf): Update.
1754         (linux_inferior_data_cleanup): Remove.
1755         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1756
1757 2019-05-08  Tom Tromey  <tom@tromey.com>
1758
1759         * auxv.c (auxv_inferior_data): Move.  Change type.
1760         (auxv_inferior_data_cleanup): Remove.
1761         (invalidate_auxv_cache_inf): Rewrite.
1762         (get_auxv_inferior_data, _initialize_auxv): Update.
1763
1764 2019-05-08  Tom Tromey  <tom@tromey.com>
1765
1766         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1767         (symfile_debug_objfile_data_key): Change type.
1768         (symfile_debug_installed, debug_qf_has_symbols)
1769         (debug_qf_find_last_source_symtab)
1770         (debug_qf_forget_cached_source_info)
1771         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1772         (debug_qf_print_stats, debug_qf_dump)
1773         (debug_qf_expand_symtabs_for_function)
1774         (debug_qf_expand_all_symtabs)
1775         (debug_qf_expand_symtabs_with_fullname)
1776         (debug_qf_map_matching_symbols)
1777         (debug_qf_expand_symtabs_matching)
1778         (debug_qf_find_pc_sect_compunit_symtab)
1779         (debug_qf_map_symbol_filenames)
1780         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1781         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1782         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1783         (debug_sym_read_linetable, debug_sym_relocate): Update.
1784         (symfile_debug_free_objfile): Remove.
1785         (install_symfile_debug_logging, _initialize_symfile_debug):
1786         Update.
1787
1788 2019-05-08  Tom Tromey  <tom@tromey.com>
1789
1790         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1791         allocate_on_obstack.
1792         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1793         (get_dwarf2_per_objfile): Update.
1794         (set_dwarf2_per_objfile): Remove.
1795         (dwarf2_has_info, dwarf2_get_section_info): Update.
1796         (dwarf2_free_objfile): Remove.
1797         (_initialize_dwarf2_read): Update.
1798
1799 2019-05-08  Tom Tromey  <tom@tromey.com>
1800
1801         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1802         initializers.
1803         <unsupported_script_warning_printed,
1804         script_not_found_warning_printed>: Now bool.
1805         (auto_load_pspace_data): Change type.
1806         (~auto_load_pspace_info): Rename from
1807         auto_load_pspace_data_cleanup.
1808         (get_auto_load_pspace_data, init_loaded_scripts_info)
1809         (clear_section_scripts, maybe_print_unsupported_script_warning)
1810         (maybe_print_script_not_found_warning, _initialize_auto_load):
1811         Update.
1812
1813 2019-05-08  Tom Tromey  <tom@tromey.com>
1814
1815         * objfiles.c (objfile_pspace_info): Add destructor and
1816         initializers.
1817         (objfiles_pspace_data): Change type.
1818         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1819         (get_objfile_pspace_data): Update.
1820         (objfiles_bfd_data): Change type.
1821         (get_objfile_bfd_data): Update.
1822         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1823
1824 2019-05-08  Tom Tromey  <tom@tromey.com>
1825
1826         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1827         Change type.
1828         (get_catch_syscall_inferior_data): Update.
1829         (catch_syscall_inferior_data_cleanup): Remove.
1830         (_initialize_break_catch_syscall): Update.
1831
1832 2019-05-08  Tom Tromey  <tom@tromey.com>
1833
1834         * inflow.c (struct terminal_info): Add destructor and
1835         initializers.
1836         (inflow_inferior_data): Change type.
1837         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1838         (get_inflow_inferior_data, inflow_inferior_exit)
1839         (swap_terminal_info, _initialize_inflow): Update.
1840
1841 2019-05-08  Tom Tromey  <tom@tromey.com>
1842
1843         * target-dcache.c (target_dcache_cleanup): Remove.
1844         (target_dcache_aspace_key): Change type.
1845         (target_dcache_init_p, target_dcache_invalidate)
1846         (target_dcache_get, target_dcache_get_or_init)
1847         (_initialize_target_dcache): Update.
1848         * dcache.h (struct dcache_deleter): New.
1849
1850 2019-05-08  Tom Tromey  <tom@tromey.com>
1851
1852         * symtab.c (struct symbol_cache): Add destructor and
1853         initializers.
1854         (symbol_cache_key): Move.  Change type.
1855         (make_symbol_cache, free_symbol_cache): Remove.
1856         (get_symbol_cache): Update.
1857         (symbol_cache_cleanup): Remove.
1858         (ALL_PSPACES, symbol_cache_flush)
1859         (maintenance_print_symbol_cache)
1860         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1861         Update.
1862
1863 2019-05-08  Tom Tromey  <tom@tromey.com>
1864
1865         * symtab.c (struct main_info): Add destructor and initializers.
1866         (main_progspace_key): Move.  Change type.
1867         (get_main_info): Update.
1868         (main_info_cleanup): Remove.
1869         (_initialize_symtab): Update.
1870
1871 2019-05-08  Tom Tromey  <tom@tromey.com>
1872
1873         * registry.h (DECLARE_REGISTRY): Define the _key class.
1874
1875 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1876
1877         * NEWS: Merge two 'New commands' sections.
1878
1879 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1880
1881         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1882         parameter and use Ada language definition instead.
1883         (ada_val_print_ptr): Remove unused language parameter.
1884         (ada_val_print_num): Remove language parameter and use Ada language
1885         definition instead.
1886         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1887         parameter.
1888         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1889         parameter and use Ada language definition instead.
1890         (ada_val_print_1): Update all ada_val_print_xxx calls.
1891         Remove language parameter.
1892         (ada_val_print): Update ada_val_print_1 call.
1893
1894 2019-05-08  Tom Tromey  <tromey@adacore.com>
1895
1896         * remote.c (remote_hw_watchpoint_limit)
1897         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1898         Now static.
1899
1900 2019-05-08  Tom Tromey  <tromey@adacore.com>
1901
1902         * maint.c (_initialize_maint_cmds): Move initialization code to
1903         remote.c.
1904         (watchdog, show_watchdog): Move to remote.c.
1905         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1906         "watchdog" static.
1907         (_initialize_remote): Move initialization code from maint.c.
1908         * defs.h (watchdog): Don't declare.
1909
1910 2019-05-08  Tom Tromey  <tromey@adacore.com>
1911
1912         * tui/tui-interp.c: Include main.h.
1913         * interps.c: Include main.h.
1914         * main.h (interpreter_p): Declare.
1915         * defs.h (interpreter_p): Don't declare.
1916
1917 2019-05-08  Tom Tromey  <tromey@adacore.com>
1918
1919         * dwarf2loc.c: Include dwarf2read.h.
1920         * defs.h (read_unsigned_leb128): Don't declare.
1921         * dwarf2read.h (read_unsigned_leb128): Declare.
1922
1923 2019-05-08  Tom Tromey  <tromey@adacore.com>
1924
1925         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1926         method.
1927
1928 2019-05-08  Tom Tromey  <tromey@adacore.com>
1929
1930         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1931         when no wrap column is set.
1932
1933 2019-05-08  Tom Tromey  <tromey@adacore.com>
1934
1935         * c-lang.c (c_get_string): Handle non-C-style arrays.
1936
1937 2019-05-08  Tom Tromey  <tromey@adacore.com>
1938
1939         * typeprint.c (print_offset_data::update): Print the bit offset,
1940         not the number of bits remaining.
1941
1942 2019-05-08  Tom Tromey  <tromey@adacore.com>
1943
1944         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1945         padding at end of comment.
1946
1947 2019-05-08  Tom Tromey  <tromey@adacore.com>
1948
1949         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1950         Compare main types.
1951
1952 2019-05-06  Tom Tromey  <tom@tromey.com>
1953
1954         * common/scoped_mmap.c: Include common-defs.h.
1955         * common/scoped_mmap.h: Don't include config.h.
1956
1957 2019-05-04  Tom Tromey  <tom@tromey.com>
1958
1959         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1960         (struct aarch64_call_info): Add initializers.
1961         <si>: Now a std::vector.
1962         (pass_on_stack, aarch64_push_dummy_call): Update.
1963
1964 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1965             Tom Tromey  <tom@tromey.com>
1966
1967         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1968         (ppc_threads): Now a std::vector.  Now static.
1969         (hwdebug_find_thread_points_by_tid)
1970         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1971         Update.
1972
1973 2019-05-04  Tom Tromey  <tom@tromey.com>
1974
1975         * arc-tdep.c (arc_tdesc_init): Return bool.
1976
1977 2019-05-04  Tom Tromey  <tom@tromey.com>
1978
1979         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1980         Use gdb_assert_not_reached.
1981
1982 2019-05-04  Tom Tromey  <tom@tromey.com>
1983
1984         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1985         "false".
1986
1987 2019-05-04  Tom Tromey  <tom@tromey.com>
1988
1989         * arc-tdep.c (arc_tdesc_init): Use bool.
1990
1991 2019-05-04  Tom Tromey  <tom@tromey.com>
1992
1993         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1994
1995 2019-05-04  Tom Tromey  <tom@tromey.com>
1996
1997         * cli/cli-cmds.c (valid_command_p): Return bool.
1998
1999 2019-05-04  Tom Tromey  <tom@tromey.com>
2000
2001         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2002         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2003
2004 2019-05-04  Raul Tambre  <raul@tambre.ee>
2005
2006         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2007         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2008         operator for comparison.
2009
2010 2019-05-04  Tom Tromey  <tom@tromey.com>
2011
2012         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2013         (lookup_partial_symbol, print_partial_symbols)
2014         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2015         (psymbol_compare): Update.
2016         (add_psymbol_to_bcache): Clear the entire psymbol.
2017         (maintenance_check_psymtabs): Update.
2018         * psympriv.h (struct partial_symbol): Don't derive from
2019         general_symbol_info.
2020         <obj_section, unrelocated_address, address,
2021         set_unrelocated_address>: Update.
2022         <ginfo>: New member.
2023         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2024         (debug_names::write_psymbols): Update.
2025
2026 2019-05-04  Tom de Vries  <tdevries@suse.de>
2027
2028         * contrib/cc-with-tweaks.sh: Support -n arg.
2029
2030 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2031
2032         * corelow.c (core_target::detach): Ensure frame cache and
2033         register caches are cleared.
2034         inferior.c (exit_inferior_1): Likewise.
2035
2036 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2037             Tom Tromey  <tom@tromey.com>
2038
2039         * dictionary.c (collate_pending_symbols_by_language): Remove
2040         "struct" from foreach.
2041         * symtab.c (lookup_global_symbol_from_objfile)
2042         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2043         foreach.
2044         * ser-tcp.c (net_open): Remove "struct" from foreach.
2045         * objfiles.c (objfile_relocate, objfile_rebase)
2046         (objfile_has_symbols): Remove "struct" from foreach.
2047         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2048         from foreach.
2049         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2050         foreach.
2051         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2052         "struct" from foreach.
2053         * ada-lang.c (create_excep_cond_exprs)
2054         (ada_exception_catchpoint_cond_string): Remove "struct" from
2055         foreach.
2056
2057 2019-05-03  Tom Tromey  <tromey@adacore.com>
2058
2059         * ada-exp.y (convert_char_literal): Check suffix of each
2060         enumerator.
2061
2062 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2063
2064         PR ada/21406:
2065         * ada-exp.y (yywrap): Don't define.
2066         * ada-lex.l (%option): Add noyywrap
2067         (yywrap): Remove.
2068
2069 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2070
2071         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2072         _WIN32_WINNT to the XP level, unless already defined to a higher
2073         level.
2074
2075         * unittests/parse-connection-spec-selftests.c:
2076         * ser-tcp.c:
2077         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2078         override.
2079
2080         * symfile.c (find_separate_debug_file): Remove colon from the
2081         drive spec of DOS/Windows file names of the target, so that the
2082         file name produced from DEBUGDIR and the target's directory will
2083         be valid on DOS/Windows systems.
2084
2085 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2086
2087         * rust-lang.c (val_print_struct): Handle printing structures
2088         containing strings.
2089
2090 2019-05-02  Tom Tromey  <tromey@adacore.com>
2091
2092         * valarith.c (_initialize_valarith): Remove.
2093
2094 2019-05-01  Tom Tromey  <tromey@adacore.com>
2095
2096         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2097         bitfields.
2098
2099 2019-05-01  Tom Tromey  <tromey@adacore.com>
2100
2101         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2102         for big-endian copies.
2103
2104 2019-04-30  Ali Tamur  <tamur@google.com>
2105         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2106         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2107         (read_3_bytes): New function.
2108
2109 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2110
2111         * windows-nat.c (main_thread_id): Delete.
2112         (handle_output_debug_string): Replace main_thread_id by
2113         current_event.dwThreadId.
2114         (fake_create_process): Likewise.
2115         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2116         Do not set main_thread_id.
2117         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2118         current_event.dwThreadId.
2119         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2120
2121 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2122
2123         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2124         Use current_event.dwThreadId instead of main_thread_id.
2125
2126 2019-04-30  Tom Tromey  <tromey@adacore.com>
2127
2128         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2129         (create_excep_cond_exprs): Iterate over program spaces.
2130         (ada_exception_catchpoint_cond_string): Examine all minimal
2131         symbols for exception types.
2132
2133 2019-04-30  Tom Tromey  <tromey@adacore.com>
2134
2135         PR c++/24470:
2136         * dwarf2read.c (process_structure_scope): Handle case where type
2137         has template parameters but no symbol was created.
2138
2139 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2140             Chris January  <chris.january@arm.com>
2141
2142         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2143         qualifier.
2144         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2145
2146 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2147
2148         * f-typeprint.c (f_print_type): Update rules for printing
2149         whitespace.
2150         (f_type_print_varspec_suffix): Likewise.
2151
2152 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2153             Chris January  <chris.january@arm.com>
2154
2155         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2156         function arguments.
2157
2158 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2159
2160         * f-lang.c (build_fortran_types): Change name of void type to
2161         lower case.
2162         * f-typeprint.c (f_type_print_base): Print the name of the void
2163         type, rather than a fixed string.
2164         * f-valprint.c (f_decorations): Use lower case void string.
2165
2166 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2167             Chris January  <chris.january@arm.com>
2168
2169         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2170         types for Fortran.
2171
2172 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2173             Chris January  <chris.january@arm.com>
2174             David Lecomber  <david.lecomber@arm.com>
2175
2176         * f-exp.y (BINOP_INTRINSIC): New token.
2177         (exp): New parser rule handling BINOP_INTRINSIC.
2178         (f77_keywords): Add new builtin procedures.
2179         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2180         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2181         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2182         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2183         (print_unop_subexp_f): New function.
2184         (print_binop_subexp_f): New function.
2185         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2186         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2187         (dump_subexp_body_f): Likewise.
2188         (operator_check_f): Likewise.
2189         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2190         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2191
2192 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2193
2194         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2195         UNOP_KIND.
2196         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2197         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2198         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2199         (operator_length_f): New fuction.
2200         (print_subexp_f): New function.
2201         (op_name_f): New function.
2202         (dump_subexp_body_f): New function.
2203         (operator_check_f): New function.
2204         (exp_descriptor_f): Replace standard expression handling functions
2205         with new functions.
2206         * gdb/fortran-operator.def: New file.
2207         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2208         * gdb/std-operator.def: Remove UNOP_KIND.
2209
2210 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2211
2212         * std-operator.def: Remove unbalanced, stray double quote
2213         character.
2214
2215 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2216             Chris January  <chris.january@arm.com>
2217             Daniel Everett  <daniel.everett@arm.com>
2218             Nick Forrington  <nick.forrington@arm.com>
2219             Richard Bunt  <richard.bunt@arm.com>
2220
2221         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2222         of depth when printing anonymous structs or unions.
2223         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2224         Don't print either the top-level value, or the children if the
2225         max-depth is exceeded.
2226         (ppscm_print_children): When printing the key of a map, allow one
2227         extra level of depth.
2228         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2229         print either the top-level value, or the children if the max-depth
2230         is exceeded.
2231         (print_children): When printing the key of a map, allow one extra
2232         level of depth.
2233         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2234         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2235         (user_print_options): Initialise max_depth field.
2236         (val_print_scalar_or_string_type_p): New function.
2237         (val_print): Check to see if the max depth has been reached.
2238         (val_print_check_max_depth): Define new function.
2239         (show_print_max_depth): New function.
2240         (_initialize_valprint): Add 'print max-depth' option.
2241         * valprint.h (struct value_print_options) <max_depth>: New field.
2242         (val_print_check_max_depth): Declare new function.
2243         * NEWS: Document new feature.
2244
2245 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2246
2247         * ada-lang.c (ada_language_defn): Initialise new field.
2248         * c-lang.c (c_is_string_type_p): New function.
2249         (c_language_defn): Initialise new field.
2250         (cplus_language_defn): Initialise new field.
2251         (asm_language_defn): Initialise new field.
2252         (minimal_language_defn): Initialise new field.
2253         * c-lang.h (c_is_string_type_p): Declare new function.
2254         * d-lang.c (d_language_defn): Initialise new field.
2255         * f-lang.c (f_is_string_type_p): New function.
2256         (f_language_defn): Initialise new field.
2257         * go-lang.c (go_is_string_type_p): New function.
2258         (go_language_defn): Initialise new field.
2259         * language.c (default_is_string_type_p): New function.
2260         (unknown_language_defn): Initialise new field.
2261         (auto_language_defn): Initialise new field.
2262         * language.h (struct language_defn) <la_is_string_type_p>: New
2263         member variable.
2264         (default_is_string_type_p): Declare new function.
2265         * m2-lang.c (m2_language_defn): Initialise new field.
2266         * objc-lang.c (objc_language_defn): Initialise new field.
2267         * opencl-lang.c (opencl_language_defn): Initialise new field.
2268         * p-lang.c (pascal_is_string_type_p): New function.
2269         (pascal_language_defn): Initialise new field.
2270         * rust-lang.c (rust_is_string_type_p): New function.
2271         (rust_language_defn): Initialise new field.
2272
2273 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2274
2275         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2276         New field.
2277         * ada-lang.c (ada_language_defn): Initialise new field.
2278         * c-lang.c (c_language_defn): Likewise.
2279         (cplus_language_defn): Likewise.
2280         (asm_language_defn): Likewise.
2281         (minimal_language_defn): Likewise.
2282         * d-lang.c (d_language_defn): Likewise.
2283         * f-lang.c (f_language_defn): Likewise.
2284         * go-lang.c (go_language_defn): Likewise.
2285         * language.c (unknown_language_defn): Likewise.
2286         (auto_language_defn): Likewise.
2287         * m2-lang.c (m2_language_defn): Likewise.
2288         * objc-lang.c (objc_language_defn): Likewise.
2289         * opencl-lang.c (opencl_language_defn): Likewise.
2290         * p-lang.c (pascal_language_defn): Likewise.
2291         * rust-lang.c (rust_language_defn): Likewise.
2292
2293 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2294
2295         * ada-lang.c (ada_is_character_type): Change return type to bool.
2296         (ada_is_string_type): Likewise.
2297         * ada-lang.h (ada_is_character_type): Update declaration
2298         (ada_is_string_type): Likewise.
2299
2300 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2301
2302         Support style in 'frame|thread apply'
2303
2304         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2305         * record.c (record_start, record_stop): Update callers of
2306         execute_command_to_string with false.
2307         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2308         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2309         methods.
2310         (class string_file): New constructor with term_out parameter.
2311         Override methods term_out and can_emit_style_escape.  New member
2312         term_out.
2313         (class stdio_file): Override can_emit_style_escape.
2314         (class tee_file): Override term_out and can_emit_style_escape.
2315         * utils.h (can_emit_style_escape): Remove.
2316         * utils.c (can_emit_style_escape): Likewise.
2317         Update all callers of can_emit_style_escape (SOMESTREAM) to
2318         SOMESTREAM->can_emit_style_escape.
2319         * source-cache.c (source_cache::get_source_lines): Likewise.
2320         * stack.c (frame_apply_command_count): Call execute_command_to_string
2321         passing the term_out characteristic of the current gdb_stdout.
2322         * thread.c (thr_try_catch_cmd): Likewise.
2323         * top.c (execute_command_to_string): pass term_out parameter
2324         to construct the string_file for the command output.
2325         * ui-file.c (term_cli_styling): New function (most code moved
2326         from utils.c can_emit_style_escape).
2327         (string_file::string_file, string_file::can_emit_style_escape,
2328         stdio_file::can_emit_style_escape, tee_file::term_out,
2329         tee_file::can_emit_style_escape): New functions.
2330
2331 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2332
2333         * NEWS: Mention the new set|show may-call-functions.
2334         * infcall.c (may_call_functions_p): New variable.
2335         (show_may_call_functions_p): New function.
2336         (call_function_by_hand_dummy): Throws an error if not
2337         may-call-functions.
2338         (_initialize_infcall): Call add_setshow_boolean_cmd for
2339         may-call-functions.
2340
2341 2019-04-25  Keith Seitz  <keiths@redhat.com>
2342
2343         PR c++/24367
2344         * cp-support.c (inspect_type): Don't attempt substitutions
2345         of symbol with the same name.
2346
2347 2019-04-25  Tom Tromey  <tromey@adacore.com>
2348
2349         PR gdb/24475:
2350         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2351         static.
2352
2353 2019-04-25  Tom Tromey  <tromey@adacore.com>
2354
2355         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2356         rvalue reference.
2357         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2358         (gdb_xml_parser::parse): Use std::move.
2359         * python/python-internal.h (gdbpy_convert_exception): Take a const
2360         reference.
2361         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2362         std::move.
2363         * python/py-utils.c (gdbpy_convert_exception): Take a const
2364         reference.
2365         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2366         Use std::move.
2367         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2368         Use std::move.
2369         * mi/mi-main.c (mi_print_exception): Take a const reference.
2370         * main.c (handle_command_errors): Take a const reference.
2371         * linespec.c (parse_linespec): Use std::move.
2372         * infcall.c (run_inferior_call): Use std::move.
2373         (call_function_by_hand_dummy): Use std::move.
2374         * exec.c (try_open_exec_file): Use std::move.
2375         * exceptions.h (exception_print, exception_fprintf)
2376         (exception_print_same): Update.
2377         * exceptions.c (print_exception, exception_print)
2378         (exception_fprintf, exception_print_same): Change parameters to
2379         const reference.
2380         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2381         * common/new-op.c: Use std::move.
2382         * common/common-exceptions.h (struct gdb_exception): Add move
2383         constructor.
2384         (struct gdb_exception_error, struct gdb_exception_quit, struct
2385         gdb_quit_bad_alloc): Change constructor to move constructor.
2386         (throw_exception): Change parameter to rvalue reference.
2387         * common/common-exceptions.c (throw_exception): Take rvalue
2388         reference.
2389         * cli/cli-interp.c (safe_execute_command): Use std::move.
2390         * breakpoint.c (insert_bp_location, location_to_sals): Use
2391         std::move.
2392
2393 2019-04-25  Tom Tromey  <tromey@adacore.com>
2394
2395         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2396         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2397         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2398         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2399         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2400         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2401         guile/scm-value.c: Use unpack.
2402         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2403         gdbscm_gdb_exception.
2404         (gdbscm_throw_gdb_exception): Likewise.
2405         (struct gdbscm_gdb_exception): New.
2406         (unpack): New function.
2407         (gdbscm_wrap): Use unpack.
2408
2409 2019-04-25  Tom Tromey  <tromey@adacore.com>
2410
2411         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2412         (gdb_rl_callback_handler): Use std::move.
2413         * common/common-exceptions.h (struct gdb_exception): Add move
2414         assignment operator.
2415         (throw_exception_sjlj): Change "exception" to const reference.
2416         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2417         (throw_exception_sjlj): Change "exception" to const reference.
2418
2419 2019-04-25  Tom Tromey  <tromey@adacore.com>
2420
2421         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2422         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2423         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2424         Update.
2425         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2426         Update.
2427         * mi/mi-interp.c (mi_interp::exec): Update.
2428         * linespec.c (parse_linespec): Update.
2429         * infcall.c (run_inferior_call): Update.
2430         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2431         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2432         (gdbscm_lookup_global_symbol): Update.
2433         * guile/scm-param.c (gdbscm_parameter_value): Update.
2434         * guile/scm-frame.c (gdbscm_frame_read_register)
2435         (gdbscm_frame_read_var): Update.
2436         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2437         * exec.c (try_open_exec_file): Update.
2438         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2439         (gdb_rl_callback_handler): Update.
2440         * common/common-exceptions.h (exception_none): Don't declare.
2441         * common/common-exceptions.c (exception_none): Don't define.
2442         (struct catcher) <exception>: Update.
2443         * cli/cli-interp.c (safe_execute_command): Update.
2444         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2445
2446 2019-04-25  Ali Tamur  <tamur@google.com>
2447
2448         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2449         (read_attribute_value): Likewise.
2450         (dwarf2_read_addr_index): Update comment.
2451         (read_str_index): Add DW_FORM_strx.
2452         (dwarf2_string_attr): Likewise.
2453         (dwarf2_const_value_attr): Likewise.
2454         (dump_die_shallow): Likewise.
2455         (dwarf2_fetch_constant_bytes): Likewise.
2456         (skip_form_bytes): Likewise.
2457         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2458
2459 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2460
2461         PR corefiles/11608
2462         PR corefiles/18187
2463         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2464         OFFSET.  Verify if current mapping contains an ELF header.
2465         (linux_find_memory_regions_full): Adjust call to
2466         dump_mapping_p.
2467
2468 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2469             Kang Li <kanglictf@gmail.com>
2470
2471         PR gdb/21600
2472
2473         * dwarf2-frame.c (read_initial_length): Be consistent about using
2474         unsigned representation of length.
2475         (decode_frame_entry_1): Likewise.  Check for wraparound of
2476         end pointer as well as buffer overflow.
2477
2478 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2479
2480         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2481         "vq".
2482
2483 2019-04-24  Tom Tromey  <tromey@adacore.com>
2484
2485         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2486
2487 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2488
2489         * s12z-tdep.c (s12z_unwind_pc): Delete.
2490         (s12z_unwind_sp): Delete.
2491         (s12z_gdbarch_init): Don't register deleted functions with
2492         gdbarch.
2493
2494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2495
2496         * rl78-tdep.c (rl78_unwind_sp): Delete.
2497         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2498
2499 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2500
2501         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2502         (xstormy16_unwind_pc): Delete.
2503         (xstormy16_dummy_id): Delete.
2504         (xstormy16_gdbarch_init): Don't register deleted functions with
2505         gdbarch.
2506
2507 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2508
2509         * vax-tdep.c (vax_unwind_pc): Delete.
2510         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2511
2512 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2513
2514         * v850-tdep.c (v850_unwind_sp): Delete.
2515         (v850_unwind_pc): Delete.
2516         (v850_dummy_id): Delete.
2517         (v850_gdbarch_init): Don't register deleted functions with
2518         gdbarch.
2519
2520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2521
2522         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2523         (tilegx_unwind_pc): Delete.
2524         (tilegx_unwind_dummy_id): Delete.
2525         (tilegx_gdbarch_init): Don't register deleted functions with
2526         gdbarch.
2527
2528 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2529
2530         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2531         (tic6x_dummy_id): Delete.
2532         (tic6x_gdbarch_init): Don't register deleted functions with
2533         gdbarch.
2534
2535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2536
2537         * sparc-tdep.c (sparc_unwind_pc): Delete.
2538         (sparc32_gdbarch_init): Don't register deleted function with
2539         gdbarch.
2540
2541 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2542
2543         * sh-tdep.c (sh_unwind_sp): Delete.
2544         (sh_unwind_pc): Delete.
2545         (sh_dummy_id): Delete.
2546         (sh_gdbarch_init): Don't register deleted functions with
2547         gdbarch.
2548
2549 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2550
2551         * score-tdep.c (score_unwind_sp): Delete.
2552         (score_unwind_pc): Delete.
2553         (score_dummy_id): Delete.
2554         (score_gdbarch_init): Don't register deleted functions with
2555         gdbarch.
2556
2557 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2558
2559         * rx-tdep.c (rx_unwind_pc): Delete.
2560         (rx_unwind_sp): Delete.
2561         (rx_dummy_id): Delete.
2562         (rx_gdbarch_init): Don't register deleted functions with
2563         gdbarch.  Update comment.
2564
2565 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2566
2567         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2568         (rs6000_dummy_id): Delete.
2569         (rs6000_gdbarch_init): Don't register deleted functions with
2570         gdbarch.
2571
2572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2573
2574         * or1k-tdep.c (or1k_dummy_id): Delete.
2575         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2576
2577 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2578
2579         * nios2-tdep.c (nios2_dummy_id): Delete.
2580         (nios2_unwind_sp): Delete.
2581         (nios2_gdbarch_init): Don't register deleted functions with
2582         gdbarch.
2583
2584 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2585
2586         * nds32-tdep.c (nds32_dummy_id): Delete.
2587         (nds32_unwind_pc): Delete.
2588         (nds32_unwind_sp): Delete.
2589         (nds32_gdbarch_init): Don't register deleted functions with
2590         gdbarch.
2591
2592 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2593
2594         * msp430-tdep.c (msp430_unwind_pc): Delete.
2595         (msp430_unwind_sp): Delete.
2596         (msp430_dummy_id): Delete.
2597         (msp430_gdbarch_init): Don't register deleted functions with
2598         gdbarch.
2599
2600 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2601
2602         * moxie-tdep.c (moxie_unwind_sp): Delete.
2603         (moxie_unwind_pc): Delete.
2604         (moxie_dummy_id): Delete.
2605         (moxie_gdbarch_init): Don't register deleted functions with
2606         gdbarch.
2607
2608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2609
2610         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2611         (mn10300_unwind_pc): Delete.
2612         (mn10300_unwind_sp): Delete.
2613         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2614         mn10300_unwind_sp.
2615         (mn10300_frame_unwind_init): Don't register deleted functions with
2616         gdbarch.
2617
2618 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2619
2620         * mep-tdep.c (mep_unwind_pc): Delete.
2621         (mep_unwind_sp): Delete.
2622         (mep_dummy_id): Delete.
2623         (mep_gdbarch_init): Don't register deleted functions with
2624         gdbarch.
2625
2626 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2627
2628         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2629         (m68hc11_unwind_sp): Delete.
2630         (m68hc11_gdbarch_init): Don't register deleted functions with
2631         gdbarch.
2632
2633 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2634
2635         * m32r-tdep.c (m32r_unwind_sp): Delete.
2636         (m32r_unwind_pc): Delete.
2637         (m32r_dummy_id): Delete.
2638         (m32r_gdbarch_init): Don't register deleted functions with
2639         gdbarch.
2640
2641 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2642
2643         * m32c-tdep.c (m32c_unwind_pc): Delete.
2644         (m32c_unwind_sp): Delete.
2645         (m32c_dummy_id): Delete.
2646         (m32c_gdbarch_init): Don't register deleted functions with
2647         gdbarch.
2648
2649 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2650
2651         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2652         (lm32_unwind_pc): Delete.
2653         (lm32_dummy_id): Delete.
2654         (lm32_gdbarch_init): Don't register deleted functions with
2655         gdbarch.
2656
2657 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2658
2659         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2660         (iq2000_unwind_pc): Delete.
2661         (iq2000_dummy_id): Delete.
2662         (iq2000_gdbarch_init): Don't register deleted functions with
2663         gdbarch.
2664
2665 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2666
2667         * nds32-tdep.c (nds32_type_align): Delete.
2668         (nds32_push_dummy_call): Use type_align instead.
2669
2670 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2671
2672         * arm-tdep.c (arm_type_align): Only handle vector override case.
2673         (arm_push_dummy_call): Use type_align.
2674         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2675
2676 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2677
2678         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2679         case.
2680         (pass_on_stack): Use type_align.
2681         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2682         function.
2683
2684 2019-04-23  Tom Tromey  <tromey@adacore.com>
2685
2686         * dwarf2read.c (line_header::file_name_at): Remove unused
2687         overload.
2688
2689 2019-04-23  Tom de Vries  <tdevries@suse.de>
2690
2691         PR gdb/24438
2692         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2693         invocation.
2694
2695
2696 2019-03-27  Ali Tamur  <tamur@google.com>
2697
2698         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2699         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2700         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2701         (dwarf_expr_context::get_addr_index): Likewise
2702         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2703         (symbol_needs_eval_context::get_addr_index): Likewise
2704         (disassemble_dwarf_expression): Add DW_OP_addrx
2705         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2706         (read_cutu_die_from_dwo): Update comment
2707         (skip_one_die): Add DW_FORM_addrx
2708         (read_attribute_value): Likewise
2709         (var_decode_location): Add DW_OP_addrx
2710         (dwarf2_const_value_attr): Add DW_FORM_addrx
2711         (dump_die_shallow): Likewise
2712         (dwarf2_fetch_constant_bytes): Likewise
2713         (decode_locdesc): Add DW_OP_addrx
2714         (skip_form_bytes): Add DW_FORM_addrx
2715
2716 2019-04-22  Ali Tamur  <tamur@google.com>
2717
2718         * MAINTAINERS (Write After Approval): Add self.
2719
2720 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2721
2722         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2723         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2724         (open_symbol_file_object): Likewise.
2725         (svr4_default_sos): Add info parameter.
2726         (svr4_read_so_list): Likewise.
2727         (svr4_current_sos_direct): Adjust functions calls to pass down
2728         info.
2729         (svr4_current_sos_1): Add info parameter.
2730         (svr4_current_sos): Call get_svr4_info, pass info down to
2731         svr4_current_sos_1.
2732         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2733         get_svr4_info.
2734         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2735         get_svr4_info.
2736         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2737         to get_svr4_info.
2738         (probes_table_remove_objfile_probes): Likewise.
2739         (register_solib_event_probe): Add info parameter.
2740         (solist_update_incremental): Pass info parameter down to
2741         svr4_read_so_list.
2742         (disable_probes_interface): Add info parameter.
2743         (svr4_handle_solib_event): Pass current_program_space to
2744         get_svr4_info.  Adjust disable_probes_interface cleanup.
2745         (svr4_create_probe_breakpoints): Add info parameter, pass it
2746         down to register_solib_event_probe.
2747         (svr4_create_solib_event_breakpoints): Add info parameter,
2748         pass it down to svr4_create_probe_breakpoints.
2749         (enable_break): Pass info down to
2750         svr4_create_solib_event_breakpoints.
2751         (svr4_solib_create_inferior_hook): Pass current_program_space to
2752         get_svr4_info.
2753         (svr4_clear_solib): Likewise.
2754
2755 2019-04-22  Pedro Alves  <palves@redhat.com>
2756
2757         * solib-svr4.c (svr4_free_objfile_observer): New.
2758         (probe_and_action::objfile): New field.
2759         (probes_table_htab_remove_objfile_probes)
2760         (probes_table_remove_objfile_probes): New functions.
2761         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2762         in the new probe_and_action.  Don't store the probe in 'lookup'.
2763         (svr4_create_probe_breakpoints): Pass objfile to
2764         register_solib_event_probe.
2765         (_initialize_svr4_solib): Register a free_objfile observer.
2766
2767 2019-04-19  Tom Tromey  <tom@tromey.com>
2768
2769         * common/queue.h: Remove.
2770
2771 2019-04-19  Tom Tromey  <tom@tromey.com>
2772
2773         * event-loop.c: Don't include "common/queue.h".
2774
2775 2019-04-19  Tom Tromey  <tom@tromey.com>
2776
2777         * remote.c (remote_target): Use delete.
2778         * remote-notif.h: Include <list>, not "common/queue.h".
2779         (notif_client_p): Remove typedef.
2780         (remote_notif_state): Add constructor, destructor, initializer.
2781         <notif_queue>: Now a std::list.
2782         (remote_notif_state_xfree): Don't declare.
2783         * remote-notif.c (remote_notif_process, handle_notification)
2784         (remote_notif_state_allocate): Update.
2785         (~remote_notif_state): Rename from remote_notif_state_xfree.
2786
2787 2019-04-19  Tom Tromey  <tom@tromey.com>
2788
2789         * symfile.c (reread_symbols): Update.
2790         * objfiles.c (objfile_register_static_link)
2791         (objfile_lookup_static_link): Update
2792         (~objfile) Don't delete static_links.
2793         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2794
2795 2019-04-19  Tom Tromey  <tom@tromey.com>
2796
2797         * type-stack.h (struct type_stack) <insert>: Constify string.
2798         * type-stack.c (type_stack::insert): Constify string.
2799         * gdbtypes.h (lookup_template_type): Update.
2800         (address_space_name_to_int): Update.
2801         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2802         const.
2803         (lookup_template_type): Make name const.
2804         * c-exp.y: Update rules.
2805         (lex_one_token, classify_name, classify_inner_name)
2806         (c_print_token): Update.
2807         * p-exp.y: Update rules.
2808         (yylex): Update.
2809         * f-exp.y: Update rules.
2810         (yylex): Update.
2811         * d-exp.y: Update rules.
2812         (lex_one_token, classify_name, classify_inner_name): Update.
2813         * parse.c (write_dollar_variable, copy_name): Return std::string.
2814         * parser-defs.h (copy_name): Change return type.
2815         * m2-exp.y: Update rules.
2816         (yylex): Update.
2817         * go-exp.y (lex_one_token): Update.
2818         Update rules.
2819         (classify_unsafe_function, classify_packaged_name)
2820         (classify_name, yylex): Update.
2821
2822 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2823
2824         * configure.ac: add --enable-source-highlight switch.
2825         * configure: Regenerate.
2826         * top.c (print_gdb_version): plumb --enable-source-highlight
2827         status to "show configuration".
2828
2829 2019-04-19  Tom Tromey  <tromey@adacore.com>
2830
2831         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2832         Check ADA_TYPE_P.
2833         (empty_record, ada_template_to_fixed_record_type_1)
2834         (template_to_static_fixed_type)
2835         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2836         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2837         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2838         macros.
2839
2840 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2841
2842         PR symtab/24423:
2843         * source.c (print_source_lines_base): Advance "iter" when a
2844         control character is seen.
2845
2846 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2847
2848         * inferior.h (struct infcall_suspend_state_deleter):
2849         Catch exception in destructor to avoid crash.
2850
2851 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2852
2853         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2854         close to the add_com "shell".
2855
2856 2019-04-18  Tom Tromey  <tromey@adacore.com>
2857
2858         * process-stratum-target.h (class process_stratum_target)
2859         <stratum>: Add "final".
2860
2861 2019-04-17  Tom Tromey  <tromey@adacore.com>
2862
2863         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2864         against nullptr before use.
2865
2866 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2867
2868         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2869
2870 2019-04-17  Jim Wilson  <jimw@sifive.com>
2871             Andrew Burgess  <andrew.burgess@embecosm.com>
2872
2873         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2874         code read might fail, assume 4-byte breakpoint in that case.
2875
2876 2019-04-15  Leszek Swirski  <leszeks@google.com>
2877
2878         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2879         rather than a hand-rolled POD check when checking for forced MEMORY
2880         classification.
2881
2882 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2883
2884         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2885         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2886         function.
2887         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2888         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2889         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2890         declaration.
2891
2892 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2893
2894         * aarch64-linux-nat.c
2895         (aarch64_linux_nat_target::thread_architecture): Add override.
2896         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2897         each VQ.
2898
2899 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2900
2901         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2902
2903 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2904
2905         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2906         target types of size 96-bits, add some additional comments, and
2907         check that the builtin type we found was the correct size.
2908
2909 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2910
2911         * utils.c (prompt_for_continue): Don't restore the styling at the
2912         end, as applied_style has the wrong value.  This fixes styling in
2913         long lists of file names that are interrupted by the "Continue?"
2914         prompt.
2915
2916 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2917
2918         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2919         * c-lang.c (c_language_defn): Likewise.
2920         (cplus_language_defn): Likewise.
2921         (asm_language_defn): Likewise.
2922         (minimal_language_defn): Likewise.
2923         * d-lang.c (d_language_defn): Likewise.
2924         * f-lang.c (f_language_defn): Likewise.
2925         * go-lang.c (go_language_defn): Likewise.
2926         * language.c (unknown_language_defn): Likewise.
2927         (auto_language_defn): Likewise.
2928         * language.h (struct language_defn): Remove la_magic field.
2929         (LANG_MAGIC): Delete.
2930         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2931         * objc-lang.c (objc_language_defn): Likewise.
2932         * opencl-lang.c (opencl_language_defn): Likewise.
2933         * p-lang.c (pascal_language_defn): Likewise.
2934         * rust-lang.c (rust_language_defn): Likewise.
2935
2936 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2937
2938         * riscv-tdep.c (riscv_type_align): New function.
2939         (riscv_type_alignment): Delete.
2940         (riscv_arg_location): Use 'type_align'.
2941         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2942
2943 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2944
2945         * gdbtypes.c (type_align): A struct with no non-static fields also
2946         has alignment of 1.
2947
2948 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2949
2950         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2951         component to 0.
2952         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2953         member.
2954         (riscv_struct_info::analyse): New implementation using new
2955         analyse_inner member function.
2956         (riscv_struct_info::field_offset): New member function.
2957         (riscv_struct_info::m_offsets): New member variable.
2958         (riscv_struct_info::analyse_inner): New private member function,
2959         takes the old implementation of riscv_struct_info::analyse but
2960         extended to track field offsets.
2961         (riscv_call_arg_struct): Update the struct folding special cases
2962         to handle cases where empty C++ structs, which are non-zero
2963         length, are found.
2964         (riscv_arg_location): Initialise the length of each location, a
2965         non-zero length now indicates the location is in use.
2966         (riscv_push_dummy_call): Allow for the first location having a
2967         non-zero offset when setting up arguments.
2968         (riscv_return_value): Likewise, but for return values.
2969
2970 2019-04-11  Tom Tromey  <tromey@adacore.com>
2971
2972         * utils.c (internal_vproblem): Make "msg" const.
2973
2974 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2975
2976         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2977         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2978         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2979         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2980
2981 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2982
2983         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2984         function.
2985         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2986         of amd64_collect_native_gregset.
2987         (amd64_linux_nat_target::store_registers): Likewise.
2988
2989 2019-04-10  Tom Tromey  <tom@tromey.com>
2990
2991         * symtab.c (lookup_global_symbol_from_objfile)
2992         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2993         * objfiles.h (class separate_debug_iterator): New.
2994         (class separate_debug_range): New.
2995         (struct objfile) <separate_debug_objfiles>: New method.
2996         (objfile_separate_debug_iterate): Don't declare.
2997         * objfiles.c (separate_debug_iterator::operator++): Rename from
2998         objfile_separate_debug_iterate.
2999         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3000         iterator.
3001         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3002         iterator.
3003
3004 2019-04-10  Tom Tromey  <tom@tromey.com>
3005
3006         * symfile.c (reread_symbols): Remove old comment.
3007         * objfiles.c (free_all_objfiles): Fix a typo.
3008
3009 2019-04-10  Tom Tromey  <tom@tromey.com>
3010
3011         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3012         * minsyms.c (lookup_minimal_symbol): Use foreach.
3013         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3014         (lookup_minimal_symbol_solib_trampoline): Likewise.
3015         * symfile.c (reread_symbols): Use foreach.
3016
3017 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3018             Tom Tromey  <tromey@adacore.com>
3019
3020         PR rust/24414:
3021         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3022         (rust_lex_int_test): Change "value" to be LONGEST.
3023         (rust_lex_tests): Add test for long integer literal.
3024
3025 2019-04-09  Tom Tromey  <tromey@adacore.com>
3026
3027         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3028         to bool.
3029         (extended_remote_target::attach): Update.
3030         (remote_target::remote_notice_new_inferior): Update.
3031         (remote_target::add_current_inferior_and_thread): Update.
3032         * inferior.c (exit_inferior_1): Use "false".
3033         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3034
3035 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3036
3037         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3038         the "start" command.
3039
3040 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3041
3042         * python/py-inferior.c (infpy_thread_from_thread_handle):
3043         Adjust comments to reflect renaming of thread_from_thread_handle
3044         to thread_from_handle.  Adjust keywords.  Fix type error message.
3045         (inferior_object_methods): Add thread_from_handle.  Retain
3046         thread_from_thread_handle, but mark it as deprecated.
3047
3048 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3049
3050         * gdbthread.h (find_thread_by_handle): Revise declaration.
3051         * thread.c (find_thread_by_handle): Likewise.  Adjust
3052         implementation too.
3053         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3054         support for buffer objects as handles.
3055
3056 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3057
3058         * python/py-infthread.c (thpy_thread_handle): New function.
3059         (thread_object_methods): Register thpy_thread_handle.
3060
3061 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3062
3063         * gdbthread.h (thread_to_thread_handle): Declare.
3064         * thread.c (gdbtypes.h): Include.
3065         (thread_to_thread_handle): New function.
3066
3067         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3068         (target_thread_info_to_thread_handle): Declare.
3069         * target.c (target_thread_info_to_thread_handle): New function.
3070         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3071         * target-delegates.c: Regenerate.
3072
3073         * linux-thread-db.c (class thread_db_target): Add method
3074         thread_info_to_thread_handle.
3075         (thread_db_target::thread_info_to_thread_handle): Define.
3076         * remote.c (class remote_target): Add new method
3077         thread_info_to_thread_handle.
3078         (remote_target::thread_info_to_thread_handle): Define.
3079
3080 2019-04-08  Pedro Alves  <palves@redhat.com>
3081
3082         * common/common-exceptions.c (throw_exception): Don't create
3083         named object to throw; throw directly.
3084         (throw_it): Likewise.  Don't initialize gdb_exception::message
3085         here, with new; pass FMT and AP to the ctor instead.
3086         * common/common-exceptions.h: Include <string>.
3087         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3088         const char *, va_list)): New ctor.  Use std::make_shared.
3089         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3090         errors)): Delete.
3091         (gdb_exception_error::gdb_exception_error(enum errors, const char
3092         *, va_list)): New.
3093         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3094         Add assertion.
3095         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3096         errors)): Delete.
3097         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3098         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3099         Add assertion.
3100
3101 2019-04-08  Tom Tromey  <tom@tromey.com>
3102
3103         * valops.c (value_rtti_indirect_type): Replace throw_exception
3104         with throw.
3105         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3106         with throw.
3107         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3108         throw.
3109         * target.c (target_translate_tls_address): Replace throw_exception
3110         with throw.
3111         * stack.c (frame_apply_command_count): Replace throw_exception
3112         with throw.
3113         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3114         throw.
3115         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3116         with throw.
3117         * rs6000-tdep.c (rs6000_frame_cache)
3118         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3119         * remote.c: Replace throw_exception with throw.
3120         * record-full.c (record_full_message, record_full_wait_1)
3121         (record_full_restore): Replace throw_exception with throw.
3122         * record-btrace.c:
3123         (get_thread_current_frame_id, record_btrace_start_replaying)
3124         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3125         (cmd_record_btrace_start): Replace throw_exception with throw.
3126         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3127         throw.
3128         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3129         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3130         * linespec.c:
3131         (find_linespec_symbols): Replace throw_exception with throw.
3132         * infrun.c (displaced_step_prepare, resume): Replace
3133         throw_exception with throw.
3134         * infcmd.c (post_create_inferior): Replace throw_exception with
3135         throw.
3136         * inf-loop.c (inferior_event_handler): Replace throw_exception
3137         with throw.
3138         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3139         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3140         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3141         (get_prev_frame_always, get_frame_pc_if_available)
3142         (get_frame_address_in_block_if_available, get_frame_language):
3143         Replace throw_exception with throw.
3144         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3145         throw_exception with throw.
3146         * eval.c (fetch_subexp_value, evaluate_var_value)
3147         (evaluate_funcall, evaluate_subexp_standard): Replace
3148         throw_exception with throw.
3149         * dwarf2loc.c (call_site_find_chain)
3150         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3151         Replace throw_exception with throw.
3152         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3153         with throw.
3154         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3155         throw.
3156         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3157         * completer.c (complete_line_internal): Replace throw_exception
3158         with throw.
3159         * compile/compile-object-run.c (compile_object_run): Replace
3160         throw_exception with throw.
3161         * cli/cli-script.c (process_next_line): Replace throw_exception
3162         with throw.
3163         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3164         (btrace_enable, btrace_maint_update_pt_packets): Replace
3165         throw_exception with throw.
3166         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3167         throw_exception with throw.
3168         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3169         throw_exception with throw.
3170         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3171         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3172         * aarch64-tdep.c (aarch64_make_prologue_cache)
3173         (aarch64_make_stub_cache): Replace throw_exception with throw.
3174
3175 2019-04-08  Tom Tromey  <tom@tromey.com>
3176
3177         * common/common-exceptions.c (throw_exception): Rename from
3178         throw_exception_cxx.  Remove old copy.  Make argument const.
3179         (throw_it): Create and throw exception objects directly.
3180         * common/common-exceptions.h (throw_exception): Make argument
3181         const.
3182         (struct gdb_exception_error): Add constructor.
3183         (struct gdb_exception_quit): Add constructor.
3184
3185 2019-04-08  Tom Tromey  <tom@tromey.com>
3186
3187         * common/common-exceptions.h (exception_rethrow): Don't declare.
3188         (TRY_SJLJ): Update comment.
3189         (TRY, CATCH, END_CATCH): Remove.
3190         * common/common-exceptions.c (exception_rethrow): Remove.
3191
3192 2019-04-08  Tom Tromey  <tom@tromey.com>
3193
3194         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3195         Remove.
3196         (gdb_exception_error): Rename from
3197         gdb_exception_RETURN_MASK_ERROR.
3198         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3199         (gdb_quit_bad_alloc): Update.
3200         * aarch64-tdep.c: Update.
3201         * ada-lang.c: Update.
3202         * ada-typeprint.c: Update.
3203         * ada-valprint.c: Update.
3204         * amd64-tdep.c: Update.
3205         * arch-utils.c: Update.
3206         * break-catch-throw.c: Update.
3207         * breakpoint.c: Update.
3208         * btrace.c: Update.
3209         * c-varobj.c: Update.
3210         * cli/cli-cmds.c: Update.
3211         * cli/cli-interp.c: Update.
3212         * cli/cli-script.c: Update.
3213         * common/common-exceptions.c: Update.
3214         * common/new-op.c: Update.
3215         * common/selftest.c: Update.
3216         * compile/compile-c-symbols.c: Update.
3217         * compile/compile-cplus-symbols.c: Update.
3218         * compile/compile-object-load.c: Update.
3219         * compile/compile-object-run.c: Update.
3220         * completer.c: Update.
3221         * corelow.c: Update.
3222         * cp-abi.c: Update.
3223         * cp-support.c: Update.
3224         * cp-valprint.c: Update.
3225         * darwin-nat.c: Update.
3226         * disasm-selftests.c: Update.
3227         * dtrace-probe.c: Update.
3228         * dwarf-index-cache.c: Update.
3229         * dwarf-index-write.c: Update.
3230         * dwarf2-frame-tailcall.c: Update.
3231         * dwarf2-frame.c: Update.
3232         * dwarf2loc.c: Update.
3233         * dwarf2read.c: Update.
3234         * eval.c: Update.
3235         * event-loop.c: Update.
3236         * event-top.c: Update.
3237         * exec.c: Update.
3238         * f-valprint.c: Update.
3239         * fbsd-tdep.c: Update.
3240         * frame-unwind.c: Update.
3241         * frame.c: Update.
3242         * gdbtypes.c: Update.
3243         * gnu-v3-abi.c: Update.
3244         * guile/guile-internal.h: Update.
3245         * guile/scm-block.c: Update.
3246         * guile/scm-breakpoint.c: Update.
3247         * guile/scm-cmd.c: Update.
3248         * guile/scm-disasm.c: Update.
3249         * guile/scm-frame.c: Update.
3250         * guile/scm-lazy-string.c: Update.
3251         * guile/scm-math.c: Update.
3252         * guile/scm-param.c: Update.
3253         * guile/scm-ports.c: Update.
3254         * guile/scm-pretty-print.c: Update.
3255         * guile/scm-symbol.c: Update.
3256         * guile/scm-symtab.c: Update.
3257         * guile/scm-type.c: Update.
3258         * guile/scm-value.c: Update.
3259         * i386-linux-tdep.c: Update.
3260         * i386-tdep.c: Update.
3261         * inf-loop.c: Update.
3262         * infcall.c: Update.
3263         * infcmd.c: Update.
3264         * infrun.c: Update.
3265         * jit.c: Update.
3266         * language.c: Update.
3267         * linespec.c: Update.
3268         * linux-fork.c: Update.
3269         * linux-nat.c: Update.
3270         * linux-tdep.c: Update.
3271         * linux-thread-db.c: Update.
3272         * main.c: Update.
3273         * mi/mi-cmd-break.c: Update.
3274         * mi/mi-cmd-stack.c: Update.
3275         * mi/mi-interp.c: Update.
3276         * mi/mi-main.c: Update.
3277         * objc-lang.c: Update.
3278         * p-valprint.c: Update.
3279         * parse.c: Update.
3280         * ppc-linux-tdep.c: Update.
3281         * printcmd.c: Update.
3282         * python/py-arch.c: Update.
3283         * python/py-breakpoint.c: Update.
3284         * python/py-cmd.c: Update.
3285         * python/py-finishbreakpoint.c: Update.
3286         * python/py-frame.c: Update.
3287         * python/py-framefilter.c: Update.
3288         * python/py-gdb-readline.c: Update.
3289         * python/py-inferior.c: Update.
3290         * python/py-infthread.c: Update.
3291         * python/py-lazy-string.c: Update.
3292         * python/py-linetable.c: Update.
3293         * python/py-objfile.c: Update.
3294         * python/py-param.c: Update.
3295         * python/py-prettyprint.c: Update.
3296         * python/py-progspace.c: Update.
3297         * python/py-record-btrace.c: Update.
3298         * python/py-record.c: Update.
3299         * python/py-symbol.c: Update.
3300         * python/py-type.c: Update.
3301         * python/py-unwind.c: Update.
3302         * python/py-utils.c: Update.
3303         * python/py-value.c: Update.
3304         * python/python.c: Update.
3305         * record-btrace.c: Update.
3306         * record-full.c: Update.
3307         * remote-fileio.c: Update.
3308         * remote.c: Update.
3309         * riscv-tdep.c: Update.
3310         * rs6000-aix-tdep.c: Update.
3311         * rs6000-tdep.c: Update.
3312         * rust-exp.y: Update.
3313         * rust-lang.c: Update.
3314         * s390-tdep.c: Update.
3315         * selftest-arch.c: Update.
3316         * solib-dsbt.c: Update.
3317         * solib-frv.c: Update.
3318         * solib-spu.c: Update.
3319         * solib-svr4.c: Update.
3320         * solib.c: Update.
3321         * sparc64-linux-tdep.c: Update.
3322         * stack.c: Update.
3323         * symfile-mem.c: Update.
3324         * symmisc.c: Update.
3325         * target.c: Update.
3326         * thread.c: Update.
3327         * top.c: Update.
3328         * tracefile-tfile.c: Update.
3329         * tui/tui.c: Update.
3330         * typeprint.c: Update.
3331         * unittests/cli-utils-selftests.c: Update.
3332         * unittests/parse-connection-spec-selftests.c: Update.
3333         * valops.c: Update.
3334         * valprint.c: Update.
3335         * value.c: Update.
3336         * varobj.c: Update.
3337         * windows-nat.c: Update.
3338         * x86-linux-nat.c: Update.
3339         * xml-support.c: Update.
3340
3341 2019-04-08  Tom Tromey  <tom@tromey.com>
3342
3343         * xml-support.c: Use C++ exception handling.
3344         * x86-linux-nat.c: Use C++ exception handling.
3345         * windows-nat.c: Use C++ exception handling.
3346         * varobj.c: Use C++ exception handling.
3347         * value.c: Use C++ exception handling.
3348         * valprint.c: Use C++ exception handling.
3349         * valops.c: Use C++ exception handling.
3350         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3351         handling.
3352         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3353         * typeprint.c: Use C++ exception handling.
3354         * tui/tui.c: Use C++ exception handling.
3355         * tracefile-tfile.c: Use C++ exception handling.
3356         * top.c: Use C++ exception handling.
3357         * thread.c: Use C++ exception handling.
3358         * target.c: Use C++ exception handling.
3359         * symmisc.c: Use C++ exception handling.
3360         * symfile-mem.c: Use C++ exception handling.
3361         * stack.c: Use C++ exception handling.
3362         * sparc64-linux-tdep.c: Use C++ exception handling.
3363         * solib.c: Use C++ exception handling.
3364         * solib-svr4.c: Use C++ exception handling.
3365         * solib-spu.c: Use C++ exception handling.
3366         * solib-frv.c: Use C++ exception handling.
3367         * solib-dsbt.c: Use C++ exception handling.
3368         * selftest-arch.c: Use C++ exception handling.
3369         * s390-tdep.c: Use C++ exception handling.
3370         * rust-lang.c: Use C++ exception handling.
3371         * rust-exp.y: Use C++ exception handling.
3372         * rs6000-tdep.c: Use C++ exception handling.
3373         * rs6000-aix-tdep.c: Use C++ exception handling.
3374         * riscv-tdep.c: Use C++ exception handling.
3375         * remote.c: Use C++ exception handling.
3376         * remote-fileio.c: Use C++ exception handling.
3377         * record-full.c: Use C++ exception handling.
3378         * record-btrace.c: Use C++ exception handling.
3379         * python/python.c: Use C++ exception handling.
3380         * python/py-value.c: Use C++ exception handling.
3381         * python/py-utils.c: Use C++ exception handling.
3382         * python/py-unwind.c: Use C++ exception handling.
3383         * python/py-type.c: Use C++ exception handling.
3384         * python/py-symbol.c: Use C++ exception handling.
3385         * python/py-record.c: Use C++ exception handling.
3386         * python/py-record-btrace.c: Use C++ exception handling.
3387         * python/py-progspace.c: Use C++ exception handling.
3388         * python/py-prettyprint.c: Use C++ exception handling.
3389         * python/py-param.c: Use C++ exception handling.
3390         * python/py-objfile.c: Use C++ exception handling.
3391         * python/py-linetable.c: Use C++ exception handling.
3392         * python/py-lazy-string.c: Use C++ exception handling.
3393         * python/py-infthread.c: Use C++ exception handling.
3394         * python/py-inferior.c: Use C++ exception handling.
3395         * python/py-gdb-readline.c: Use C++ exception handling.
3396         * python/py-framefilter.c: Use C++ exception handling.
3397         * python/py-frame.c: Use C++ exception handling.
3398         * python/py-finishbreakpoint.c: Use C++ exception handling.
3399         * python/py-cmd.c: Use C++ exception handling.
3400         * python/py-breakpoint.c: Use C++ exception handling.
3401         * python/py-arch.c: Use C++ exception handling.
3402         * printcmd.c: Use C++ exception handling.
3403         * ppc-linux-tdep.c: Use C++ exception handling.
3404         * parse.c: Use C++ exception handling.
3405         * p-valprint.c: Use C++ exception handling.
3406         * objc-lang.c: Use C++ exception handling.
3407         * mi/mi-main.c: Use C++ exception handling.
3408         * mi/mi-interp.c: Use C++ exception handling.
3409         * mi/mi-cmd-stack.c: Use C++ exception handling.
3410         * mi/mi-cmd-break.c: Use C++ exception handling.
3411         * main.c: Use C++ exception handling.
3412         * linux-thread-db.c: Use C++ exception handling.
3413         * linux-tdep.c: Use C++ exception handling.
3414         * linux-nat.c: Use C++ exception handling.
3415         * linux-fork.c: Use C++ exception handling.
3416         * linespec.c: Use C++ exception handling.
3417         * language.c: Use C++ exception handling.
3418         * jit.c: Use C++ exception handling.
3419         * infrun.c: Use C++ exception handling.
3420         * infcmd.c: Use C++ exception handling.
3421         * infcall.c: Use C++ exception handling.
3422         * inf-loop.c: Use C++ exception handling.
3423         * i386-tdep.c: Use C++ exception handling.
3424         * i386-linux-tdep.c: Use C++ exception handling.
3425         * guile/scm-value.c: Use C++ exception handling.
3426         * guile/scm-type.c: Use C++ exception handling.
3427         * guile/scm-symtab.c: Use C++ exception handling.
3428         * guile/scm-symbol.c: Use C++ exception handling.
3429         * guile/scm-pretty-print.c: Use C++ exception handling.
3430         * guile/scm-ports.c: Use C++ exception handling.
3431         * guile/scm-param.c: Use C++ exception handling.
3432         * guile/scm-math.c: Use C++ exception handling.
3433         * guile/scm-lazy-string.c: Use C++ exception handling.
3434         * guile/scm-frame.c: Use C++ exception handling.
3435         * guile/scm-disasm.c: Use C++ exception handling.
3436         * guile/scm-cmd.c: Use C++ exception handling.
3437         * guile/scm-breakpoint.c: Use C++ exception handling.
3438         * guile/scm-block.c: Use C++ exception handling.
3439         * guile/guile-internal.h: Use C++ exception handling.
3440         * gnu-v3-abi.c: Use C++ exception handling.
3441         * gdbtypes.c: Use C++ exception handling.
3442         * frame.c: Use C++ exception handling.
3443         * frame-unwind.c: Use C++ exception handling.
3444         * fbsd-tdep.c: Use C++ exception handling.
3445         * f-valprint.c: Use C++ exception handling.
3446         * exec.c: Use C++ exception handling.
3447         * event-top.c: Use C++ exception handling.
3448         * event-loop.c: Use C++ exception handling.
3449         * eval.c: Use C++ exception handling.
3450         * dwarf2read.c: Use C++ exception handling.
3451         * dwarf2loc.c: Use C++ exception handling.
3452         * dwarf2-frame.c: Use C++ exception handling.
3453         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3454         * dwarf-index-write.c: Use C++ exception handling.
3455         * dwarf-index-cache.c: Use C++ exception handling.
3456         * dtrace-probe.c: Use C++ exception handling.
3457         * disasm-selftests.c: Use C++ exception handling.
3458         * darwin-nat.c: Use C++ exception handling.
3459         * cp-valprint.c: Use C++ exception handling.
3460         * cp-support.c: Use C++ exception handling.
3461         * cp-abi.c: Use C++ exception handling.
3462         * corelow.c: Use C++ exception handling.
3463         * completer.c: Use C++ exception handling.
3464         * compile/compile-object-run.c: Use C++ exception handling.
3465         * compile/compile-object-load.c: Use C++ exception handling.
3466         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3467         * compile/compile-c-symbols.c: Use C++ exception handling.
3468         * common/selftest.c: Use C++ exception handling.
3469         * common/new-op.c: Use C++ exception handling.
3470         * cli/cli-script.c: Use C++ exception handling.
3471         * cli/cli-interp.c: Use C++ exception handling.
3472         * cli/cli-cmds.c: Use C++ exception handling.
3473         * c-varobj.c: Use C++ exception handling.
3474         * btrace.c: Use C++ exception handling.
3475         * breakpoint.c: Use C++ exception handling.
3476         * break-catch-throw.c: Use C++ exception handling.
3477         * arch-utils.c: Use C++ exception handling.
3478         * amd64-tdep.c: Use C++ exception handling.
3479         * ada-valprint.c: Use C++ exception handling.
3480         * ada-typeprint.c: Use C++ exception handling.
3481         * ada-lang.c: Use C++ exception handling.
3482         * aarch64-tdep.c: Use C++ exception handling.
3483
3484 2019-04-08  Tom Tromey  <tom@tromey.com>
3485
3486         * xml-support.c (gdb_xml_parser::parse): Update.
3487         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3488         * value.c (show_convenience): Update.
3489         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3490         (test_parse_flags_qcs): Update.
3491         * thread.c (thr_try_catch_cmd): Update.
3492         * target.c (target_translate_tls_address): Update.
3493         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3494         (info_frame_command_core, frame_apply_command_count): Update.
3495         * rust-exp.y (rust_lex_exception_test): Update.
3496         * riscv-tdep.c (riscv_print_one_register_info): Update.
3497         * remote.c (remote_target::enable_btrace): Update.
3498         * record-btrace.c (record_btrace_enable_warn): Update.
3499         * python/py-utils.c (gdbpy_convert_exception): Update.
3500         * printcmd.c (do_one_display, print_variable_and_value): Update.
3501         * mi/mi-main.c (mi_print_exception): Update.
3502         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3503         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3504         * linux-nat.c (linux_nat_target::attach): Update.
3505         * linux-fork.c (class scoped_switch_fork_info): Update.
3506         * infrun.c (displaced_step_prepare): Update.
3507         * infcall.c (call_function_by_hand_dummy): Update.
3508         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3509         * gnu-v3-abi.c (print_one_vtable): Update.
3510         * frame.c (get_prev_frame_always): Update.
3511         * f-valprint.c (info_common_command_for_block): Update.
3512         * exec.c (try_open_exec_file): Update.
3513         * exceptions.c (print_exception, exception_print)
3514         (exception_fprintf, exception_print_same): Update.
3515         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3516         * dwarf-index-cache.c (index_cache::store)
3517         (index_cache::lookup_gdb_index): Update.
3518         * darwin-nat.c (maybe_cache_shell): Update.
3519         * cp-valprint.c (cp_print_value_fields): Update.
3520         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3521         (gcc_cplus_symbol_address): Update.
3522         * compile/compile-c-symbols.c (gcc_convert_symbol)
3523         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3524         * common/selftest.c: Update.
3525         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3526         a std::string.
3527         (exception_try_scope_entry, exception_try_scope_exit): Don't
3528         declare.
3529         (struct exception_try_scope): Remove.
3530         (TRY): Don't use exception_try_scope.
3531         (struct gdb_exception): Add constructor, operator=.
3532         <what>: New method.
3533         (struct gdb_exception_RETURN_MASK_ALL)
3534         (struct gdb_exception_RETURN_MASK_ERROR)
3535         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3536         (struct gdb_quit_bad_alloc): Update.
3537         * common/common-exceptions.c (exception_none): Change
3538         initializer.
3539         (struct catcher) <state, exception>: Initialize inline.
3540         <prev>: Remove member.
3541         (current_catcher): Remove.
3542         (catchers): New global.
3543         (exceptions_state_mc_init): Simplify.
3544         (catcher_pop): Remove.
3545         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3546         (try_scope_depth, exception_try_scope_entry)
3547         (exception_try_scope_exit): Remove.
3548         (throw_exception_sjlj): Update.
3549         (exception_messages, exception_messages_size): Remove.
3550         (throw_it): Simplify.
3551         (gdb_exception_sliced_copy): Remove.
3552         (throw_exception_cxx): Update.
3553         * cli/cli-script.c (script_from_file): Update.
3554         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3555         Update.
3556         * ada-valprint.c (ada_val_print): Update.
3557         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3558         (create_excep_cond_exprs): Update.
3559
3560 2019-04-08  Tom Tromey  <tom@tromey.com>
3561
3562         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3563         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3564         (TRY, CATCH, END_CATCH): Remove some definitions.
3565         * common/common-exceptions.c: Don't use GDB_XCPT.
3566         (catcher_list_size): Remove.
3567         (throw_exception, throw_it): Simplify.
3568
3569 2019-04-05  Tom Tromey  <tom@tromey.com>
3570
3571         Revert the header-sorting patch.
3572         * ft32-tdep.c: Revert.
3573         * frv-tdep.c: Revert.
3574         * frv-linux-tdep.c: Revert.
3575         * frame.c: Revert.
3576         * frame-unwind.c: Revert.
3577         * frame-base.c: Revert.
3578         * fork-child.c: Revert.
3579         * findvar.c: Revert.
3580         * findcmd.c: Revert.
3581         * filesystem.c: Revert.
3582         * filename-seen-cache.h: Revert.
3583         * filename-seen-cache.c: Revert.
3584         * fbsd-tdep.c: Revert.
3585         * fbsd-nat.h: Revert.
3586         * fbsd-nat.c: Revert.
3587         * f-valprint.c: Revert.
3588         * f-typeprint.c: Revert.
3589         * f-lang.c: Revert.
3590         * extension.h: Revert.
3591         * extension.c: Revert.
3592         * extension-priv.h: Revert.
3593         * expprint.c: Revert.
3594         * exec.h: Revert.
3595         * exec.c: Revert.
3596         * exceptions.c: Revert.
3597         * event-top.c: Revert.
3598         * event-loop.c: Revert.
3599         * eval.c: Revert.
3600         * elfread.c: Revert.
3601         * dwarf2read.h: Revert.
3602         * dwarf2read.c: Revert.
3603         * dwarf2loc.c: Revert.
3604         * dwarf2expr.h: Revert.
3605         * dwarf2expr.c: Revert.
3606         * dwarf2-frame.c: Revert.
3607         * dwarf2-frame-tailcall.c: Revert.
3608         * dwarf-index-write.h: Revert.
3609         * dwarf-index-write.c: Revert.
3610         * dwarf-index-common.c: Revert.
3611         * dwarf-index-cache.h: Revert.
3612         * dwarf-index-cache.c: Revert.
3613         * dummy-frame.c: Revert.
3614         * dtrace-probe.c: Revert.
3615         * disasm.h: Revert.
3616         * disasm.c: Revert.
3617         * disasm-selftests.c: Revert.
3618         * dictionary.c: Revert.
3619         * dicos-tdep.c: Revert.
3620         * demangle.c: Revert.
3621         * dcache.h: Revert.
3622         * dcache.c: Revert.
3623         * darwin-nat.h: Revert.
3624         * darwin-nat.c: Revert.
3625         * darwin-nat-info.c: Revert.
3626         * d-valprint.c: Revert.
3627         * d-namespace.c: Revert.
3628         * d-lang.c: Revert.
3629         * ctf.c: Revert.
3630         * csky-tdep.c: Revert.
3631         * csky-linux-tdep.c: Revert.
3632         * cris-tdep.c: Revert.
3633         * cris-linux-tdep.c: Revert.
3634         * cp-valprint.c: Revert.
3635         * cp-support.c: Revert.
3636         * cp-namespace.c: Revert.
3637         * cp-abi.c: Revert.
3638         * corelow.c: Revert.
3639         * corefile.c: Revert.
3640         * continuations.c: Revert.
3641         * completer.h: Revert.
3642         * completer.c: Revert.
3643         * complaints.c: Revert.
3644         * coffread.c: Revert.
3645         * coff-pe-read.c: Revert.
3646         * cli-out.h: Revert.
3647         * cli-out.c: Revert.
3648         * charset.c: Revert.
3649         * c-varobj.c: Revert.
3650         * c-valprint.c: Revert.
3651         * c-typeprint.c: Revert.
3652         * c-lang.c: Revert.
3653         * buildsym.c: Revert.
3654         * buildsym-legacy.c: Revert.
3655         * build-id.h: Revert.
3656         * build-id.c: Revert.
3657         * btrace.c: Revert.
3658         * bsd-uthread.c: Revert.
3659         * breakpoint.h: Revert.
3660         * breakpoint.c: Revert.
3661         * break-catch-throw.c: Revert.
3662         * break-catch-syscall.c: Revert.
3663         * break-catch-sig.c: Revert.
3664         * blockframe.c: Revert.
3665         * block.c: Revert.
3666         * bfin-tdep.c: Revert.
3667         * bfin-linux-tdep.c: Revert.
3668         * bfd-target.c: Revert.
3669         * bcache.c: Revert.
3670         * ax-general.c: Revert.
3671         * ax-gdb.h: Revert.
3672         * ax-gdb.c: Revert.
3673         * avr-tdep.c: Revert.
3674         * auxv.c: Revert.
3675         * auto-load.c: Revert.
3676         * arm-wince-tdep.c: Revert.
3677         * arm-tdep.c: Revert.
3678         * arm-symbian-tdep.c: Revert.
3679         * arm-pikeos-tdep.c: Revert.
3680         * arm-obsd-tdep.c: Revert.
3681         * arm-nbsd-tdep.c: Revert.
3682         * arm-nbsd-nat.c: Revert.
3683         * arm-linux-tdep.c: Revert.
3684         * arm-linux-nat.c: Revert.
3685         * arm-fbsd-tdep.c: Revert.
3686         * arm-fbsd-nat.c: Revert.
3687         * arm-bsd-tdep.c: Revert.
3688         * arch-utils.c: Revert.
3689         * arc-tdep.c: Revert.
3690         * arc-newlib-tdep.c: Revert.
3691         * annotate.h: Revert.
3692         * annotate.c: Revert.
3693         * amd64-windows-tdep.c: Revert.
3694         * amd64-windows-nat.c: Revert.
3695         * amd64-tdep.c: Revert.
3696         * amd64-sol2-tdep.c: Revert.
3697         * amd64-obsd-tdep.c: Revert.
3698         * amd64-obsd-nat.c: Revert.
3699         * amd64-nbsd-tdep.c: Revert.
3700         * amd64-nbsd-nat.c: Revert.
3701         * amd64-nat.c: Revert.
3702         * amd64-linux-tdep.c: Revert.
3703         * amd64-linux-nat.c: Revert.
3704         * amd64-fbsd-tdep.c: Revert.
3705         * amd64-fbsd-nat.c: Revert.
3706         * amd64-dicos-tdep.c: Revert.
3707         * amd64-darwin-tdep.c: Revert.
3708         * amd64-bsd-nat.c: Revert.
3709         * alpha-tdep.c: Revert.
3710         * alpha-obsd-tdep.c: Revert.
3711         * alpha-nbsd-tdep.c: Revert.
3712         * alpha-mdebug-tdep.c: Revert.
3713         * alpha-linux-tdep.c: Revert.
3714         * alpha-linux-nat.c: Revert.
3715         * alpha-bsd-tdep.c: Revert.
3716         * alpha-bsd-nat.c: Revert.
3717         * aix-thread.c: Revert.
3718         * agent.c: Revert.
3719         * addrmap.c: Revert.
3720         * ada-varobj.c: Revert.
3721         * ada-valprint.c: Revert.
3722         * ada-typeprint.c: Revert.
3723         * ada-tasks.c: Revert.
3724         * ada-lang.c: Revert.
3725         * aarch64-tdep.c: Revert.
3726         * aarch64-ravenscar-thread.c: Revert.
3727         * aarch64-newlib-tdep.c: Revert.
3728         * aarch64-linux-tdep.c: Revert.
3729         * aarch64-linux-nat.c: Revert.
3730         * aarch64-fbsd-tdep.c: Revert.
3731         * aarch64-fbsd-nat.c: Revert.
3732         * aarch32-linux-nat.c: Revert.
3733
3734 2019-04-05  Tom Tromey  <tom@tromey.com>
3735
3736         * ft32-tdep.c: Sort headers.
3737         * frv-tdep.c: Sort headers.
3738         * frv-linux-tdep.c: Sort headers.
3739         * frame.c: Sort headers.
3740         * frame-unwind.c: Sort headers.
3741         * frame-base.c: Sort headers.
3742         * fork-child.c: Sort headers.
3743         * findvar.c: Sort headers.
3744         * findcmd.c: Sort headers.
3745         * filesystem.c: Sort headers.
3746         * filename-seen-cache.h: Sort headers.
3747         * filename-seen-cache.c: Sort headers.
3748         * fbsd-tdep.c: Sort headers.
3749         * fbsd-nat.h: Sort headers.
3750         * fbsd-nat.c: Sort headers.
3751         * f-valprint.c: Sort headers.
3752         * f-typeprint.c: Sort headers.
3753         * f-lang.c: Sort headers.
3754         * extension.h: Sort headers.
3755         * extension.c: Sort headers.
3756         * extension-priv.h: Sort headers.
3757         * expprint.c: Sort headers.
3758         * exec.h: Sort headers.
3759         * exec.c: Sort headers.
3760         * exceptions.c: Sort headers.
3761         * event-top.c: Sort headers.
3762         * event-loop.c: Sort headers.
3763         * eval.c: Sort headers.
3764         * elfread.c: Sort headers.
3765         * dwarf2read.h: Sort headers.
3766         * dwarf2read.c: Sort headers.
3767         * dwarf2loc.c: Sort headers.
3768         * dwarf2expr.h: Sort headers.
3769         * dwarf2expr.c: Sort headers.
3770         * dwarf2-frame.c: Sort headers.
3771         * dwarf2-frame-tailcall.c: Sort headers.
3772         * dwarf-index-write.h: Sort headers.
3773         * dwarf-index-write.c: Sort headers.
3774         * dwarf-index-common.c: Sort headers.
3775         * dwarf-index-cache.h: Sort headers.
3776         * dwarf-index-cache.c: Sort headers.
3777         * dummy-frame.c: Sort headers.
3778         * dtrace-probe.c: Sort headers.
3779         * disasm.h: Sort headers.
3780         * disasm.c: Sort headers.
3781         * disasm-selftests.c: Sort headers.
3782         * dictionary.c: Sort headers.
3783         * dicos-tdep.c: Sort headers.
3784         * demangle.c: Sort headers.
3785         * dcache.h: Sort headers.
3786         * dcache.c: Sort headers.
3787         * darwin-nat.h: Sort headers.
3788         * darwin-nat.c: Sort headers.
3789         * darwin-nat-info.c: Sort headers.
3790         * d-valprint.c: Sort headers.
3791         * d-namespace.c: Sort headers.
3792         * d-lang.c: Sort headers.
3793         * ctf.c: Sort headers.
3794         * csky-tdep.c: Sort headers.
3795         * csky-linux-tdep.c: Sort headers.
3796         * cris-tdep.c: Sort headers.
3797         * cris-linux-tdep.c: Sort headers.
3798         * cp-valprint.c: Sort headers.
3799         * cp-support.c: Sort headers.
3800         * cp-namespace.c: Sort headers.
3801         * cp-abi.c: Sort headers.
3802         * corelow.c: Sort headers.
3803         * corefile.c: Sort headers.
3804         * continuations.c: Sort headers.
3805         * completer.h: Sort headers.
3806         * completer.c: Sort headers.
3807         * complaints.c: Sort headers.
3808         * coffread.c: Sort headers.
3809         * coff-pe-read.c: Sort headers.
3810         * cli-out.h: Sort headers.
3811         * cli-out.c: Sort headers.
3812         * charset.c: Sort headers.
3813         * c-varobj.c: Sort headers.
3814         * c-valprint.c: Sort headers.
3815         * c-typeprint.c: Sort headers.
3816         * c-lang.c: Sort headers.
3817         * buildsym.c: Sort headers.
3818         * buildsym-legacy.c: Sort headers.
3819         * build-id.h: Sort headers.
3820         * build-id.c: Sort headers.
3821         * btrace.c: Sort headers.
3822         * bsd-uthread.c: Sort headers.
3823         * breakpoint.h: Sort headers.
3824         * breakpoint.c: Sort headers.
3825         * break-catch-throw.c: Sort headers.
3826         * break-catch-syscall.c: Sort headers.
3827         * break-catch-sig.c: Sort headers.
3828         * blockframe.c: Sort headers.
3829         * block.c: Sort headers.
3830         * bfin-tdep.c: Sort headers.
3831         * bfin-linux-tdep.c: Sort headers.
3832         * bfd-target.c: Sort headers.
3833         * bcache.c: Sort headers.
3834         * ax-general.c: Sort headers.
3835         * ax-gdb.h: Sort headers.
3836         * ax-gdb.c: Sort headers.
3837         * avr-tdep.c: Sort headers.
3838         * auxv.c: Sort headers.
3839         * auto-load.c: Sort headers.
3840         * arm-wince-tdep.c: Sort headers.
3841         * arm-tdep.c: Sort headers.
3842         * arm-symbian-tdep.c: Sort headers.
3843         * arm-pikeos-tdep.c: Sort headers.
3844         * arm-obsd-tdep.c: Sort headers.
3845         * arm-nbsd-tdep.c: Sort headers.
3846         * arm-nbsd-nat.c: Sort headers.
3847         * arm-linux-tdep.c: Sort headers.
3848         * arm-linux-nat.c: Sort headers.
3849         * arm-fbsd-tdep.c: Sort headers.
3850         * arm-fbsd-nat.c: Sort headers.
3851         * arm-bsd-tdep.c: Sort headers.
3852         * arch-utils.c: Sort headers.
3853         * arc-tdep.c: Sort headers.
3854         * arc-newlib-tdep.c: Sort headers.
3855         * annotate.h: Sort headers.
3856         * annotate.c: Sort headers.
3857         * amd64-windows-tdep.c: Sort headers.
3858         * amd64-windows-nat.c: Sort headers.
3859         * amd64-tdep.c: Sort headers.
3860         * amd64-sol2-tdep.c: Sort headers.
3861         * amd64-obsd-tdep.c: Sort headers.
3862         * amd64-obsd-nat.c: Sort headers.
3863         * amd64-nbsd-tdep.c: Sort headers.
3864         * amd64-nbsd-nat.c: Sort headers.
3865         * amd64-nat.c: Sort headers.
3866         * amd64-linux-tdep.c: Sort headers.
3867         * amd64-linux-nat.c: Sort headers.
3868         * amd64-fbsd-tdep.c: Sort headers.
3869         * amd64-fbsd-nat.c: Sort headers.
3870         * amd64-dicos-tdep.c: Sort headers.
3871         * amd64-darwin-tdep.c: Sort headers.
3872         * amd64-bsd-nat.c: Sort headers.
3873         * alpha-tdep.c: Sort headers.
3874         * alpha-obsd-tdep.c: Sort headers.
3875         * alpha-nbsd-tdep.c: Sort headers.
3876         * alpha-mdebug-tdep.c: Sort headers.
3877         * alpha-linux-tdep.c: Sort headers.
3878         * alpha-linux-nat.c: Sort headers.
3879         * alpha-bsd-tdep.c: Sort headers.
3880         * alpha-bsd-nat.c: Sort headers.
3881         * aix-thread.c: Sort headers.
3882         * agent.c: Sort headers.
3883         * addrmap.c: Sort headers.
3884         * ada-varobj.c: Sort headers.
3885         * ada-valprint.c: Sort headers.
3886         * ada-typeprint.c: Sort headers.
3887         * ada-tasks.c: Sort headers.
3888         * ada-lang.c: Sort headers.
3889         * aarch64-tdep.c: Sort headers.
3890         * aarch64-ravenscar-thread.c: Sort headers.
3891         * aarch64-newlib-tdep.c: Sort headers.
3892         * aarch64-linux-tdep.c: Sort headers.
3893         * aarch64-linux-nat.c: Sort headers.
3894         * aarch64-fbsd-tdep.c: Sort headers.
3895         * aarch64-fbsd-nat.c: Sort headers.
3896         * aarch32-linux-nat.c: Sort headers.
3897
3898 2019-04-04  Tom Tromey  <tom@tromey.com>
3899
3900         * varobj.c (varobj_create): Update.
3901         * rust-exp.y (struct rust_parser) <update_innermost_block,
3902         lookup_symbol>: New methods.
3903         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3904         Rename.
3905         (rust_parser::rust_lookup_type)
3906         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3907         * printcmd.c (display_command, do_one_display): Update.
3908         * parser-defs.h (struct parser_state) <parser_state>: Add
3909         "tracker" parameter.
3910         (block_tracker): New member.
3911         (class innermost_block_tracker) <innermost_block_tracker>: Add
3912         "types" parameter.
3913         <reset>: Remove method.
3914         (innermost_block): Don't declare.
3915         (null_post_parser): Update.
3916         * parse.c (innermost_block): Remove global.
3917         (write_dollar_variable): Update.
3918         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3919         Remove "tracker_types" parameter.
3920         (parse_expression): Add "tracker" parameter.
3921         (parse_expression_for_completion): Update.
3922         (null_post_parser): Add "tracker" parameter.
3923         * p-exp.y: Update rules.
3924         * m2-exp.y: Update rules.
3925         * language.h (struct language_defn) <la_post_parser>: Add
3926         "tracker" parameter.
3927         * go-exp.y: Update rules.
3928         * f-exp.y: Update rules.
3929         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3930         parameter.
3931         * d-exp.y: Update rules.
3932         * c-exp.y: Update rules.
3933         * breakpoint.c (set_breakpoint_condition): Create an
3934         innermost_block_tracker.
3935         (watch_command_1): Likewise.
3936         * ada-lang.c (resolve): Add "tracker" parameter.
3937         (resolve_subexp): Likewise.
3938         * ada-exp.y (write_var_from_sym): Update.
3939
3940 2019-04-04  Tom Tromey  <tom@tromey.com>
3941
3942         * type-stack.h: New file.
3943         * type-stack.c: New file.
3944         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3945         type-stack.h.
3946         (insert_into_type_stack, insert_type, push_type, push_type_int)
3947         (insert_type_address_space, pop_type, pop_type_int)
3948         (pop_typelist, pop_type_stack, append_type_stack)
3949         (push_type_stack, get_type_stack, push_typelist)
3950         (follow_type_instance_flags, follow_types): Don't declare.
3951         * parse.c (type_stack): Remove global.
3952         (parse_exp_in_context): Update.
3953         (insert_into_type_stack, insert_type, push_type, push_type_int)
3954         (insert_type_address_space, pop_type, pop_type_int)
3955         (pop_typelist, pop_type_stack, append_type_stack)
3956         (push_type_stack, get_type_stack, push_typelist)
3957         (follow_type_instance_flags, follow_types): Remove (moved to
3958         type-stack.c).
3959         * f-exp.y (type_stack): New global.
3960         Update rules.
3961         (push_kind_type, f_parse): Update.
3962         * d-exp.y (type_stack): New global.
3963         Update rules.
3964         (d_parse): Update.
3965         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3966         Update rules.
3967         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3968         (HFILES_NO_SRCDIR): Add type-stack.h.
3969
3970 2019-04-04  Tom Tromey  <tom@tromey.com>
3971
3972         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3973         (rust_parser::convert_ast_to_expression, rust_parse)
3974         (rust_lex_test_completion, rust_lex_tests): Update.
3975         * parser-defs.h (struct expr_completion_state): New.
3976         (struct parser_state) <parser_state>: Add completion parameter.
3977         <mark_struct_expression, mark_completion_tag>: New methods.
3978         <parse_completion, m_completion_state>: New members.
3979         (prefixify_expression, null_post_parser): Update.
3980         (mark_struct_expression, mark_completion_tag): Don't declare.
3981         * parse.c (parse_completion, expout_last_struct)
3982         (expout_tag_completion_type, expout_completion_name): Remove
3983         globals.
3984         (parser_state::mark_struct_expression)
3985         (parser_state::mark_completion_tag): Now methods.
3986         (prefixify_expression): Add last_struct parameter.
3987         (prefixify_subexp): Likewise.
3988         (parse_exp_1): Update.
3989         (parse_exp_in_context): Add cstate parameter.  Update.
3990         (parse_expression_for_completion): Create an
3991         expr_completion_state.
3992         (null_post_parser): Add "completion" parameter.
3993         * p-exp.y: Update rules.
3994         (yylex): Update.
3995         * language.h (struct language_defn) <la_post_parser>: Add
3996         "completing" parameter.
3997         * go-exp.y: Update rules.
3998         (lex_one_token): Update.
3999         * expression.h (parse_completion): Don't declare.
4000         * d-exp.y: Update rules.
4001         (lex_one_token): Update rules.
4002         * c-exp.y: Update rules.
4003         (lex_one_token): Update.
4004         * ada-lang.c (resolve): Add "parse_completion" parameter.
4005         (resolve_subexp): Likewise.
4006         (ada_resolve_function): Likewise.
4007
4008 2019-04-04  Tom Tromey  <tom@tromey.com>
4009
4010         * parser-defs.h (struct parser_state) <start_arglist,
4011         end_arglist>: New methods.
4012         <arglist_len, m_funcall_chain>: New members.
4013         (arglist_len, start_arglist, end_arglist): Don't declare.
4014         * parse.c (arglist_len, funcall_chain): Remove global.
4015         (start_arglist, end_arglist): Remove functions.
4016         (parse_exp_in_context): Update.
4017         * p-exp.y: Update rules.
4018         * m2-exp.y: Update rules.
4019         * go-exp.y: Update rules.
4020         * f-exp.y: Update rules.
4021         * d-exp.y: Update rules.
4022         * c-exp.y: Update rules.
4023
4024 2019-04-04  Tom Tromey  <tom@tromey.com>
4025
4026         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4027         lex_operator, push_back>: New methods.
4028         Update all rules.
4029         (rust_parser::lex_hex, lex_escape): Rename and update.
4030         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4031         (rust_parser::lex_operator): Rename and update.
4032         (rust_parser::lex_number, rustyylex, rustyyerror)
4033         (rust_lex_test_init, rust_lex_test_sequence)
4034         (rust_lex_test_push_back, rust_lex_tests): Update.
4035         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4036         parameter.
4037         <lexptr, prev_lexptr>: New members.
4038         (lexptr, prev_lexptr): Don't declare.
4039         * parse.c (lexptr, prev_lexptr): Remove globals.
4040         (parse_exp_in_context): Update.
4041         * p-exp.y (yylex, yyerror): Update.
4042         * m2-exp.y (parse_number, yylex, yyerror): Update.
4043         * go-exp.y (lex_one_token, yyerror): Update.
4044         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4045         * d-exp.y (lex_one_token, yyerror): Update.
4046         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4047         (lex_one_token, yyerror): Update.
4048         * ada-lex.l (YY_INPUT): Update.
4049         (rewind_to_char): Update.
4050         * ada-exp.y (yyerror): Update.
4051
4052 2019-04-04  Tom Tromey  <tom@tromey.com>
4053
4054         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4055         * parser-defs.h (struct parser_state) <parser_state>: Add new
4056         parameter.
4057         <comma_terminates>: New member.
4058         (comma_terminates): Don't declare global.
4059         * parse.c (comma_terminates): Remove global.
4060         (parse_exp_in_context): Update.
4061         * p-exp.y (yylex): Update.
4062         * m2-exp.y (yylex): Update.
4063         * go-exp.y (lex_one_token): Update.
4064         * f-exp.y (yylex): Update.
4065         * d-exp.y (lex_one_token): Update.
4066         * c-exp.y (lex_one_token): Update.
4067         * ada-lex.l: Update.
4068
4069 2019-04-04  Tom Tromey  <tom@tromey.com>
4070
4071         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4072         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4073         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4074         * parser-defs.h (paren_depth): Don't declare.
4075         * parse.c (paren_depth): Remove global.
4076         (parse_exp_in_context): Update.
4077         * p-exp.y (paren_depth): New global.
4078         (pascal_parse): Initialize it.
4079         * m2-exp.y (paren_depth): New global.
4080         (m2_parse): Initialize it.
4081         * go-exp.y (paren_depth): New global.
4082         (go_parse): Initialize it.
4083         * f-exp.y (paren_depth): New global.
4084         (f_parse): Initialize it.
4085         * d-exp.y (paren_depth): New global.
4086         (d_parse): Initialize it.
4087         * c-exp.y (paren_depth): New global.
4088         (c_parse): Initialize it.
4089         * ada-lex.l (paren_depth): New global.
4090         (lexer_init): Initialize it.
4091
4092 2019-04-04  Tom Tromey  <tom@tromey.com>
4093
4094         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4095         (rust_parser::convert_ast_to_type)
4096         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4097         * parser-defs.h (struct parser_state) <parser_state>: Add
4098         parameters.  Initialize new members.
4099         <expression_context_block, expression_context_pc>: New members.
4100         * parse.c (expression_context_block, expression_context_pc):
4101         Remove globals.
4102         (parse_exp_in_context): Update.
4103         * p-exp.y: Update all rules.
4104         (yylex): Update.
4105         * m2-exp.y: Update all rules.
4106         (yylex): Update.
4107         * go-exp.y (yylex): Update.
4108         * f-exp.y (yylex): Update.
4109         * d-exp.y: Update all rules.
4110         (yylex): Update.
4111         * c-exp.y: Update all rules.
4112         (lex_one_token, classify_name, yylex, c_parse): Update.
4113         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4114
4115 2019-04-04  Tom Tromey  <tom@tromey.com>
4116
4117         * gdbarch.h, gdbarch.c: Rebuild.
4118         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4119         * stap-probe.h:
4120         (struct stap_parse_info): Replace "parser_state" with
4121         "expr_builder".
4122         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4123         (parser_state): New class.
4124         * parse.c (expr_builder): Rename.
4125         (expr_builder::release): Rename.
4126         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4127         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4128         (write_exp_elt_longcst, write_exp_elt_floatcst)
4129         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4130         (write_exp_string_vector, write_exp_bitstring)
4131         (write_exp_msymbol, mark_struct_expression)
4132         (write_dollar_variable)
4133         (insert_type_address_space, increase_expout_size): Replace
4134         "parser_state" with "expr_builder".
4135         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4136         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4137         "parser_state" with "expr_builder".
4138
4139 2019-04-04  Tom Tromey  <tom@tromey.com>
4140
4141         * rust-exp.y: Replace "parse_language" with method call.
4142         * p-exp.y:
4143         (yylex): Replace "parse_language" with method call.
4144         * m2-exp.y:
4145         (yylex): Replace "parse_language" with method call.
4146         * go-exp.y (classify_name): Replace "parse_language" with method
4147         call.
4148         * f-exp.y (yylex): Replace "parse_language" with method call.
4149         * d-exp.y (lex_one_token): Replace "parse_language" with method
4150         call.
4151         * c-exp.y:
4152         (lex_one_token, classify_name, yylex): Replace "parse_language"
4153         with method call.
4154         * ada-exp.y (find_primitive_type, type_char)
4155         (type_system_address): Replace "parse_language" with method call.
4156
4157 2019-04-04  Tom Tromey  <tom@tromey.com>
4158
4159         * rust-exp.y: Replace "parse_gdbarch" with method call.
4160         * parse.c (write_dollar_variable, insert_type_address_space):
4161         Replace "parse_gdbarch" with method call.
4162         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4163         call.
4164         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4165         call.
4166         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4167         "parse_gdbarch" with method call.
4168         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4169         with method call.
4170         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4171         "parse_gdbarch" with method call.
4172         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4173         "parse_gdbarch" with method call.
4174         * c-exp.y (parse_type, parse_number, classify_name): Replace
4175         "parse_gdbarch" with method call.
4176         * ada-lex.l: Replace "parse_gdbarch" with method call.
4177         * ada-exp.y (parse_type, find_primitive_type, type_char)
4178         (type_system_address): Replace "parse_gdbarch" with method call.
4179
4180 2019-04-04  Tom Tromey  <tom@tromey.com>
4181
4182         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4183         * stap-probe.c (stap_parse_argument): Update.
4184         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4185         initial_size parameter.
4186         * rust-exp.y (rust_lex_tests): Update.
4187         * parse.c (parser_state): Update.
4188         (parse_exp_in_context): Update.
4189         * parser-defs.h (struct parser_state) <parser_state>: Remove
4190         "initial_size" parameter.
4191
4192 2019-04-04  Tom Tromey  <tom@tromey.com>
4193
4194         * parser-defs.h (increase_expout_size): Don't declare.
4195         * parse.c (increase_expout_size): Now static.
4196
4197 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4198
4199         * gnu-nat.c (gnu_nat_target::wait): Fix
4200         target_waitstatus_to_string call.
4201
4202 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4203
4204         * eval.c (evaluate_subexp_standard): Handle internal functions
4205         during Fortran function call handling.
4206
4207 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4208
4209         * NEWS: Mention new internal functions.
4210         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4211         (read_base_type): Use dwarf2_init_complex_target_type.
4212         * value.c (creal_internal_fn): New function.
4213         (cimag_internal_fn): New function.
4214         (_initialize_values): Register new internal functions.
4215
4216 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4217
4218         * infrun.c (stop_all_threads): If debug_infrun, always
4219         trace the wait status after wait_one, using
4220         target_waitstatus_to_string and target_pid_to_str.
4221         (handle_inferior_event): Replace various trace of
4222         wait status kind by a single trace.
4223         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4224         wait status kind image by target_waitstatus_to_string.
4225         * target/waitstatus.c (target_waitstatus_to_string): Fix
4226         obsolete comment.
4227
4228 2019-04-01  Tom Tromey  <tromey@adacore.com>
4229
4230         PR symtab/23331:
4231         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4232
4233 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4234             Pedro Alves  <palves@redhat.com>
4235
4236         * top.c (quit_force): Call 'finalize_values'.
4237         * value.c (finalize_values): New function.
4238         * value.h (finalize_values): Declare.
4239
4240 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4241
4242         * NEWS: Announce $_gdb_major and $_gdb_minor.
4243
4244         * top.c (init_gdb_version_vars): New function.
4245         (gdb_init): Call init_gdb_version_vars.
4246
4247 2019-03-29  Tom Tromey  <tromey@adacore.com>
4248
4249         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4250         help text.  Remove dead code.
4251
4252 2019-03-29  Keith Seitz  <keiths@redhat.com>
4253
4254         From Siddhesh Poyarekar:
4255         * f-lang.h (f77_get_upperbound): Return LONGEST.
4256         (f77_get_lowerbound): Likewise.
4257         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4258         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4259         print them.
4260         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4261         plongest to format print it.
4262         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4263         (f77_get_upperbound): Likewise.
4264         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4265         LOWER_BOUND to LONGEST.
4266         (f77_create_arrayprint_offset_tbl): Likewise.
4267
4268 2019-03-29  Keith Seitz  <keiths@redhat.com>
4269
4270         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4271         %s/pulongest for TYPE_LENGTH instead of %d in format
4272         strings.
4273         * ada-typerint.c (ada_print_type): Likewise.
4274         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4275         * compile/compile-c-support.c (generate_register_struct): Likewise.
4276         * gdbtypes.c (recursive_dump_type): Likewise.
4277         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4278         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4279         instead of %d in format strings.
4280         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4281         to std::min to ULONGEST.
4282         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4283         instead of %d in format strings.
4284         * tracepoint.c (info_scope_command): Likewise.
4285         * typeprint.c (print_offset_data::update)
4286         (print_offset_data::finish): Likewise.
4287         * xtensa-tdep.c (xtensa_store_return_value)
4288         (xtensa_push_dummy_call): Likewise.
4289
4290 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4291
4292         * windows-nat.c (display_selector): Fixed format specifications
4293         for 64-bit Cygwin.
4294
4295 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4296
4297         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4298
4299 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4300
4301         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4302         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4303         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4304         (nios2_linux_init_abi): Install it.
4305
4306 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4307
4308         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4309
4310 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4311
4312         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4313
4314 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4315             Tom Tromey  <tromey@adacore.com>
4316
4317         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4318
4319 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4320
4321         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4322         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4323         method to compute the bounds of range types. Also print "[evaluated]"
4324         if the bounds' values come from a dynamic evaluation.
4325
4326 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4327
4328         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4329         whitespace when pretty printing is on.
4330
4331 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4332
4333         * ppc-linux-nat.c: Add include.
4334
4335 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4336
4337         * NEWS: Mention AArch64 Pointer Authentication.
4338
4339 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4340
4341         * arm-linux-nat.c: Add include.
4342
4343 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4344
4345         * source-cache.c (source_cache::get_source_lines): Re-read
4346         fullname after calling open_source_file.
4347
4348 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4349
4350         * NEWS: Mention TLS support for FreeBSD.
4351
4352 2019-03-25  Tom Tromey  <tromey@adacore.com>
4353
4354         * minsyms.c (BUNCH_SIZE): Update comment.
4355         (~minimal_symbol_reader): Remove old comment.
4356         (compact_minimal_symbols): Update comment.
4357         (minimal_symbol_reader::install): Remove old comment.  Update
4358         other comments.
4359
4360 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4361
4362         * s390-linux-nat.c: Add include.
4363
4364 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4365
4366         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4367         Call linux_get_hwcap.
4368         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4369         Likewise.
4370         (aarch64_linux_get_hwcap): Remove function.
4371         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4372         declaration.
4373         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4374         linux_get_hwcap.
4375         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4376         * linux-tdep.c (linux_get_hwcap): Add function.
4377         (linux_get_hwcap2): Likewise.
4378         * linux-tdep.h (linux_get_hwcap): Add declaration.
4379         (linux_get_hwcap2): Likewise.
4380         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4381         (ppc_linux_get_hwcap2): Likewise.
4382         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4383         linux_get_hwcap.
4384         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4385         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4386         (ppc_linux_nat_target::read_description): Likewise.
4387         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4388         * s390-linux-nat.c: Likewise.
4389         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4390
4391 2019-03-24  Tom Tromey  <tom@tromey.com>
4392
4393         * ada-lang.c (standard_lookup): Simplify initialization.
4394         (ada_lookup_symbol_nonlocal): Simplify return.
4395         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4396         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4397         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4398         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4399         initialization.
4400         * solib.c (solib_global_lookup): Simplify.
4401         * symtab.c (null_block_symbol): Remove.
4402         (symbol_cache_lookup): Simplify returns.
4403         (lookup_language_this): Simplify returns.
4404         (lookup_symbol_aux): Simplify return.
4405         (lookup_local_symbol): Simplify returns.
4406         (lookup_global_symbol_from_objfile): Simplify return.
4407         (lookup_symbol_in_objfile_symtabs)
4408         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4409         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4410         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4411         * cp-namespace.c (cp_lookup_bare_symbol)
4412         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4413         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4414         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4415         (cp_lookup_symbol_via_imports): Simplify initialization.
4416         (find_symbol_in_baseclass): Likewise.
4417         * symtab.h (null_block_symbol): Remove.
4418         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4419         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4420         (d_lookup_symbol_module): Likewise.
4421         (find_symbol_in_baseclass): Simplify initialization.
4422
4423 2019-03-24  Tom Tromey  <tom@tromey.com>
4424
4425         * expression.h: Don't include symtab.h.
4426         (struct block): Forward declare.
4427
4428 2019-03-24  Tom Tromey  <tom@tromey.com>
4429
4430         * c-exp.y (typebase): Remove casts.
4431         * gdbtypes.c (lookup_unsigned_typename, )
4432         (lookup_signed_typename): Remove cast.
4433         * eval.c (parse_to_comma_and_eval): Remove cast.
4434         * parse.c (write_dollar_variable): Remove cast.
4435         * block.h (struct block) <superblock>: Now const.
4436         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4437         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4438         (map_block): Make "block" const.
4439         * symfile.h (struct quick_symbol_functions)
4440         <map_matching_symbols>: Constify block argument to "callback".
4441         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4442         const.
4443         (find_pc_sect_compunit_symtab): Make "b" const.
4444         (find_symbol_at_address): Likewise.
4445         (search_symbols): Likewise.
4446         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4447         (dw2_debug_names_lookup_symbol): Likewise.
4448         (dw2_map_matching_symbols): Update.
4449         * p-valprint.c (pascal_val_print): Remove "block".
4450         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4451         (aux_add_nonlocal_symbols): Make "block" const.
4452         (resolve_subexp): Remove cast.
4453         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4454         const.
4455         (iterate_over_file_blocks): Likewise.
4456         * f-exp.y (%union) <bval>: Remove.
4457         * coffread.c (patch_opaque_types): Make "b" const.
4458         * spu-tdep.c (spu_catch_start): Make "block" const.
4459         * c-valprint.c (print_unpacked_pointer): Remove "block".
4460         * symmisc.c (dump_symtab_1): Make "b" const.
4461         (block_depth): Make "block" const.
4462         * d-exp.y (%union) <bval>: Remove.
4463         * cp-support.h (cp_lookup_rtti_type): Update.
4464         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4465         * psymtab.c (psym_lookup_symbol): Make "block" const.
4466         (maintenance_check_psymtabs): Make "b" const.
4467         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4468         (enumerate_locals, enumerate_args): Update.
4469         * python/py-symtab.c (stpy_global_block): Make "block" const.
4470         (stpy_static_block): Likewise.
4471         * inline-frame.c (block_starting_point_at): Make "new_block"
4472         const.
4473         * block.c (find_block_in_blockvector): Make return type const.
4474         (blockvector_for_pc_sect): Make "b" const.
4475         (find_block_in_blockvector): Make "b" const.
4476
4477 2019-03-23  Tom Tromey  <tom@tromey.com>
4478
4479         * varobj.c (varobj_create): Update.
4480         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4481         * printcmd.c (display_command, do_one_display): Don't reset
4482         innermost_block.
4483         * parser-defs.h (enum innermost_block_tracker_type): Move to
4484         expression.h.
4485         (innermost_block): Update comment.
4486         * parse.c (parse_exp_1): Add tracker_types parameter.
4487         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4488         tracker_types parameter.  Reset innermost_block.
4489         (parse_exp_in_context): Remove.
4490         (parse_expression_for_completion): Update.
4491         * objfiles.c (~objfile): Don't reset expression_context_block or
4492         innermost_block.
4493         * expression.h (enum innermost_block_tracker_type): Move from
4494         parser-defs.h.
4495         (parse_exp_1): Add tracker_types parameter.
4496         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4497         reset innermost_block.
4498
4499 2019-03-23  Tom Tromey  <tom@tromey.com>
4500
4501         * objfiles.h: Include bcache.h.
4502
4503 2019-03-23  Tom Tromey  <tom@tromey.com>
4504
4505         * linespec.c (get_current_search_block): Use
4506         scoped_restore_current_language.
4507         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4508
4509 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4510             Jiong Wang  <jiong.wang@arm.com>
4511
4512         * aarch64-linux-tdep.c
4513         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4514         section.
4515         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4516
4517 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4518             Jiong Wang  <jiong.wang@arm.com>
4519
4520         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4521         instructions.
4522         (aarch64_analyze_prologue_test): Add PACIASP test.
4523         (aarch64_prologue_prev_register): Unmask PC value.
4524
4525 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4526             Jiong Wang  <jiong.wang@arm.com>
4527
4528         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4529         (aarch64_dwarf2_prev_register): Unmask PC value.
4530         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4531         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4532         DW_CFA_AARCH64_negate_ra_state.
4533         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4534
4535 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4536             Jiong Wang  <jiong.wang@arm.com>
4537
4538         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4539         registers.
4540         (aarch64_pseudo_register_name): Likewise.
4541         (aarch64_pseudo_register_type): Likewise.
4542         (aarch64_pseudo_register_reggroup_p): Likewise.
4543         (aarch64_gdbarch_init): Add pauth registers.
4544         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4545         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4546         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4547         (struct gdbarch_tdep): Add regnum for ra_state.
4548
4549 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4550             Jiong Wang  <jiong.wang@arm.com>
4551
4552         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4553
4554 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4555             Jiong Wang  <jiong.wang@arm.com>
4556
4557         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4558         function.
4559         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4560         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4561         (aarch64_gdbarch_init): Add puth registers.
4562         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4563         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4564         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4565
4566 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4567             Jiong Wang  <jiong.wang@arm.com>
4568
4569         * aarch64-linux-nat.c
4570         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4571         * aarch64-linux-tdep.c
4572         (aarch64_linux_core_read_description): Likewise.
4573         (aarch64_linux_get_hwcap): New function.
4574         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4575         (aarch64_linux_get_hwcap): New declaration.
4576
4577 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4578             Jiong Wang  <jiong.wang@arm.com>
4579
4580         * aarch64-linux-nat.c
4581         (aarch64_linux_nat_target::read_description): Add pauth param.
4582         * aarch64-linux-tdep.c
4583         (aarch64_linux_core_read_description): Likewise.
4584         * aarch64-tdep.c (struct target_desc): Add in pauth.
4585         (aarch64_read_description): Add pauth param.
4586         (aarch64_gdbarch_init): Likewise.
4587         * aarch64-tdep.h (aarch64_read_description): Likewise.
4588         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4589         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4590         * features/Makefile: Add new files.
4591         * features/aarch64-pauth.c: New file.
4592         * features/aarch64-pauth.xml: New file.
4593
4594 2019-03-20  Tom Tromey  <tromey@adacore.com>
4595
4596         * infrun.c (handle_inferior_event): Rename from
4597         handle_inferior_event_1.  Create a scoped_value_mark.
4598         (handle_inferior_event): Remove.
4599
4600 2019-03-19  Tom Tromey  <tromey@adacore.com>
4601
4602         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4603         * infrun.h (print_stop_event): Add "displays" parameter.
4604         * infrun.c (print_stop_event): Add "displays" parameter.
4605
4606 2019-03-19  Pedro Alves  <palves@redhat.com>
4607
4608         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4609         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4610         to -1.  Fix TABs vs spaces.
4611         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4612         * tui/tui-out.h (tui_ui_out) Add intro comments.
4613         <m_line, m_start_of_line>: In-class initialize, and add describing
4614         comment.
4615
4616 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4617
4618         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4619         variable names.
4620         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4621
4622 2019-03-18  Pedro Alves  <palves@redhat.com>
4623             Eli Zaretskii <eliz@gnu.org>
4624
4625         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4626         m_line and m_start_of_line.
4627
4628 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4629
4630         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4631         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4632         it returns a newline.  This fixes a regression in TU mode, whereby
4633         the next line is output on the same screen line as the user input.
4634
4635 2019-03-18  Tom Tromey  <tromey@adacore.com>
4636
4637         * minsyms.c (minimal_symbol_reader::install): Remove call to
4638         obstack_blank.
4639
4640 2019-03-18  Pedro Alves  <palves@redhat.com>
4641
4642         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4643         New globals.
4644         (apply_style): New, factored out from ...
4645         (apply_ansi_escape): ... this.  Handle reverse video mode.
4646         (tui_set_reverse_mode): New function.
4647         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4648         * tui/tui-winsource.c (tui_show_source_line): Use
4649         tui_set_reverse_mode instead of setting A_STANDOUT.
4650         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4651         New setter methods.
4652
4653 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4654
4655         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4656         Handle tabs.
4657
4658 2019-03-18  Tom Tromey  <tromey@adacore.com>
4659
4660         * ada-lang.c (empty_array): Add "high" parameter.
4661         (ada_evaluate_subexp): Update.
4662
4663 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4664
4665         * unittests/string_view-selftests.c: Define
4666         _initialize_string_view_selftests unconditionally.
4667
4668 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4669
4670         PR gdb/24350
4671         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4672
4673 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4674
4675         PR gdb/24351
4676         * windows-nat.c (display_selector): Fix format specifiers.
4677
4678 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4679
4680         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4681         tui_refill_source_window instead of tui_refresh_win, to update the
4682         current execution line.  This fixes redisplay of the current line
4683         when stepping through the code with "next" or "step".
4684
4685 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4686
4687         * source-cache.c (source_cache::get_source_lines): Call
4688         find_source_lines to initialize s->nlines.  This fixes vertical
4689         scrolling of TUI source window when the DOWN arrow is pressed.
4690
4691 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4692
4693         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4694         linux-thread-db.c (_initialize_thread_db): Likewise.
4695
4696 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4697
4698         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4699         wclrtoeol in tui_show_source_line".  This reverts changes made in
4700         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4701
4702 2019-03-15  Tom Tromey  <tom@tromey.com>
4703
4704         * symtab.h (struct minimal_symbol): Derive from
4705         general_symbol_info.
4706         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4707         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4708         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4709         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4710         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4711         (MSYMBOL_SEARCH_NAME): Update.
4712         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4713         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4714         * minsyms.c (minimal_symbol_reader::record_full): Update.
4715
4716 2019-03-15  Tom Tromey  <tom@tromey.com>
4717
4718         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4719
4720 2019-03-15  Tom Tromey  <tom@tromey.com>
4721
4722         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4723         unique_xmalloc_ptr.
4724         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4725         Update.
4726         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4727         (build_minimal_symbol_hash_tables)
4728         (minimal_symbol_reader::install): Update.
4729
4730 2019-03-15  Tom Tromey  <tom@tromey.com>
4731
4732         * symtab.c (create_demangled_names_hash): Update.
4733         (symbol_set_names): Update.
4734         * objfiles.h (struct objfile_per_bfd_storage)
4735         <demangled_names_hash>: Now an htab_up.
4736         * objfiles.c (objfile_per_bfd_storage): Simplify.
4737
4738 2019-03-15  Tom Tromey  <tom@tromey.com>
4739
4740         * objfiles.h (struct objfile_per_bfd_storage): Declare
4741         destructor.
4742         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4743         New.
4744         (get_objfile_bfd_data): Use new.  Don't initialize
4745         language_of_main.
4746         (free_objfile_per_bfd_storage): Remove.
4747         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4748
4749 2019-03-15  Tom Tromey  <tom@tromey.com>
4750
4751         * symfile.c (reread_symbols): Update.
4752         * objfiles.c (objfile::objfile): Update.
4753         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4754         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4755         comment.
4756         (minimal_symbol_reader::install): Update.
4757         (terminate_minimal_symbol_table): Remove.
4758         * jit.c (jit_object_close_impl): Update.
4759
4760 2019-03-15  Tom Tromey  <tom@tromey.com>
4761
4762         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4763         initializations.
4764
4765 2019-03-15  Tom Tromey  <tom@tromey.com>
4766
4767         * objfiles.h (struct objfile_per_bfd_storage)
4768         <demangled_hash_languages>: Now a bitset.
4769         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4770         (lookup_minimal_symbol): Update.
4771
4772 2019-03-15  Tom Tromey  <tom@tromey.com>
4773
4774         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4775         Don't return the symbol.
4776         * coffread.c (record_minimal_symbol): Use record_full.
4777
4778 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4779
4780         The MS-Windows port of ncurses fails to switch to a color pair if
4781         one or both of the colors are the implicit default colors.  This
4782         change records the default colors when TUI is initialized, and
4783         then specifies them explicitly when a color pair uses the default
4784         colors.  This allows color styling in TUI mode on MS-Windows.
4785
4786         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4787         ncurses_norm_attr.
4788         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4789         colors in ncurses_norm_attr.
4790         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4791         "none", replace it with the default color recorded in
4792         ncurses_norm_attr.
4793
4794 2019-03-14  Tom Tromey  <tromey@adacore.com>
4795
4796         * source-cache.h (class source_cache) <get_source_lines>: Return
4797         std::string.
4798         * source-cache.c (source_cache::extract_lines): Handle case where
4799         first_pos==npos.  Return std::string.
4800         (source_cache::get_source_lines): Update.
4801
4802 2019-03-14  Tom Tromey  <tromey@adacore.com>
4803
4804         * NEWS: Add item for "style sources" commands.
4805         * source-cache.c (source_cache::get_source_lines): Check
4806         source_styling.
4807         * cli/cli-style.c (source_styling): New global.
4808         (_initialize_cli_style): Add "style sources" commands.
4809         (show_style_sources): New function.
4810         * cli/cli-style.h (source_styling): Declare.
4811
4812 2019-03-14  Pedro Alves  <palves@redhat.com>
4813             Tom Tromey  <tromey@adacore.com>
4814
4815         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4816         * tui/tui-winsource.c (tui_refill_source_window): New function,
4817         from...
4818         (tui_horizontal_source_scroll): ... here.  Move some logic.
4819         * cli/cli-style.c (set_style_enabled): Notify new observable.
4820         * tui/tui-hooks.c (tui_redisplay_source): New function.
4821         (tui_attach_detach_observers): Attach or detach
4822         tui_redisplay_source.
4823         * observable.h (source_styling_changed): New observable.
4824         * observable.c: Define source_styling_changed observable.
4825
4826 2019-03-13  Tom Tromey  <tromey@adacore.com>
4827
4828         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4829         (i386_gnu_nat_target::store_registers): Update.
4830         * target-debug.h (target_debug_print_std_string): New macro.
4831         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4832         * windows-tdep.c (display_one_tib): Update.
4833         * tui/tui-stack.c (tui_make_status_line): Update.
4834         * top.c (print_inferior_quit_action): Update.
4835         * thread.c (thr_try_catch_cmd): Update.
4836         (add_thread_with_info): Update.
4837         (thread_target_id_str): Update.
4838         (thr_try_catch_cmd): Update.
4839         (thread_command): Update.
4840         (thread_find_command): Update.
4841         * record-btrace.c (record_btrace_target::info_record)
4842         (record_btrace_resume_thread, record_btrace_target::resume)
4843         (record_btrace_cancel_resume, record_btrace_step_thread)
4844         (record_btrace_target::wait, record_btrace_target::wait)
4845         (record_btrace_target::wait, record_btrace_target::stop): Update.
4846         * progspace.c (print_program_space): Update.
4847         * process-stratum-target.c
4848         (process_stratum_target::thread_address_space): Update.
4849         * linux-fork.c (linux_fork_mourn_inferior)
4850         (detach_checkpoint_command, info_checkpoints_command)
4851         (linux_fork_context): Update.
4852         (linux_fork_detach): Update.
4853         (class scoped_switch_fork_info): Update.
4854         (delete_checkpoint_command): Update.
4855         * infrun.c (follow_fork_inferior): Update.
4856         (follow_fork_inferior): Update.
4857         (proceed_after_vfork_done): Update.
4858         (handle_vfork_child_exec_or_exit): Update.
4859         (follow_exec): Update.
4860         (displaced_step_prepare_throw): Update.
4861         (displaced_step_restore): Update.
4862         (start_step_over): Update.
4863         (resume_1): Update.
4864         (clear_proceed_status_thread): Update.
4865         (proceed): Update.
4866         (print_target_wait_results): Update.
4867         (do_target_wait): Update.
4868         (context_switch): Update.
4869         (stop_all_threads): Update.
4870         (restart_threads): Update.
4871         (finish_step_over): Update.
4872         (handle_signal_stop): Update.
4873         (switch_back_to_stepped_thread): Update.
4874         (keep_going_pass_signal): Update.
4875         (print_exited_reason): Update.
4876         (normal_stop): Update.
4877         * inferior.c (inferior_pid_to_str): Change return type.
4878         (print_selected_inferior): Update.
4879         (add_inferior): Update.
4880         (detach_inferior): Update.
4881         * dummy-frame.c (fprint_dummy_frames): Update.
4882         * dcache.c (dcache_info_1): Update.
4883         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4884         (btrace_fetch, btrace_clear): Update.
4885         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4886         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4887         type.
4888         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4889         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4890         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4891         * gdbarch.c, gdbarch.h: Rebuild.
4892         * gdbarch.sh (core_pid_to_str): Change return type.
4893         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4894         return type.
4895         (windows_nat_target::pid_to_str): Change return type.
4896         (windows_delete_thread): Update.
4897         (windows_nat_target::attach): Update.
4898         (windows_nat_target::files_info): Update.
4899         * target-delegates.c: Rebuild.
4900         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4901         return type.
4902         (sol_thread_target::pid_to_str): Change return type.
4903         * remote.c (class remote_target) <pid_to_str>: Change return
4904         type.
4905         (remote_target::pid_to_str): Change return type.
4906         (extended_remote_target::attach, remote_target::remote_stop_ns)
4907         (remote_target::remote_notif_remove_queued_reply)
4908         (remote_target::push_stop_reply, remote_target::disable_btrace):
4909         Update.
4910         (extended_remote_target::attach): Update.
4911         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4912         type.
4913         (gdbsim_target::pid_to_str): Change return type.
4914         * ravenscar-thread.c (struct ravenscar_thread_target)
4915         <pid_to_str>: Change return type.
4916         (ravenscar_thread_target::pid_to_str): Change return type.
4917         * procfs.c (class procfs_target) <pid_to_str>: Change return
4918         type.
4919         (procfs_target::pid_to_str): Change return type.
4920         (procfs_target::attach): Update.
4921         (procfs_target::detach): Update.
4922         (procfs_target::fetch_registers): Update.
4923         (procfs_target::store_registers): Update.
4924         (procfs_target::wait): Update.
4925         (procfs_target::files_info): Update.
4926         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4927         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4928         return type.
4929         (nto_procfs_target::pid_to_str): Change return type.
4930         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4931         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4932         return type.
4933         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4934         (exit_lwp): Update.
4935         (attach_proc_task_lwp_callback, get_detach_signal)
4936         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4937         (linux_nat_target::resume, wait_lwp, stop_callback)
4938         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4939         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4940         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4941         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4942         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4943         type.
4944         (inf_ptrace_target::attach): Update.
4945         (inf_ptrace_target::files_info): Update.
4946         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4947         type.
4948         (go32_nat_target::pid_to_str): Change return type.
4949         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4950         (gnu_nat_target::wait): Update.
4951         (gnu_nat_target::wait): Update.
4952         (gnu_nat_target::resume): Update.
4953         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4954         (fbsd_nat_target::wait): Update.
4955         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4956         type.
4957         (darwin_nat_target::attach): Update.
4958         * corelow.c (class core_target) <pid_to_str>: Change return type.
4959         (core_target::pid_to_str): Change return type.
4960         * target.c (normal_pid_to_str): Change return type.
4961         (default_pid_to_str): Likewise.
4962         (target_pid_to_str): Change return type.
4963         (target_translate_tls_address): Update.
4964         (target_announce_detach): Update.
4965         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4966         return type.
4967         (bsd_uthread_target::pid_to_str): Change return type.
4968         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4969         type.
4970         (bsd_kvm_target::pid_to_str): Change return type.
4971         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4972         return type.
4973         (aix_thread_target::pid_to_str): Change return type.
4974         * target.h (struct target_ops) <pid_to_str>: Change return type.
4975         (target_pid_to_str, normal_pid_to_str): Likewise.
4976         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4977         type.
4978         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4979         type.
4980         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4981         return type.
4982         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4983         type.
4984         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4985         type.
4986         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4987         return type.
4988
4989 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4990
4991         * NEWS: Mention that the new default MI version is 3.  Mention
4992         changes to the output of commands and events that deal with
4993         multi-location breakpoints.
4994         * breakpoint.c: Include "mi/mi-out.h".
4995         (print_one_breakpoint): Change output syntax if using MI version
4996         >= 3.
4997         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4998         New.
4999         (mi_multi_location_breakpoint_output_fixed): New.
5000         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5001         (mi_cmd_fix_multi_location_breakpoint_output): New.
5002         (mi_multi_location_breakpoint_output_fixed): New.
5003         * mi/mi-cmds.c (mi_cmds): Register command
5004         -fix-multi-location-breakpoint-output.
5005         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5006         interpreter "mi".
5007
5008 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5009
5010         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5011         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5012         instantiate mi_ui_out based on interpreter name.
5013         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5014         * mi/mi-main.c (mi_load_progress): Likewise.
5015
5016 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5017
5018         * NEWS: Combine separate "New targets" sections for 8.3.
5019
5020 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5021
5022         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5023         (ppcfbsd_init_abi): Install gdbarch
5024         "fetch_tls_load_module_address" and "get_thread_local_address"
5025         methods.
5026
5027 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5028
5029         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5030         (riscv_fbsd_init_abi): Install gdbarch
5031         "fetch_tls_load_module_address" and "get_thread_local_address"
5032         methods.
5033
5034 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5035
5036         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5037         (i386fbsd_init_abi): Install gdbarch
5038         "fetch_tls_load_module_address" and "get_thread_local_address"
5039         methods.
5040
5041 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5042
5043         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5044         (amd64fbsd_init_abi): Install gdbarch
5045         "fetch_tls_load_module_address" and "get_thread_local_address"
5046         methods.
5047
5048 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5049
5050         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5051         (struct fbsd_pspace_data): New type.
5052         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5053         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5054         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5055         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5056         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5057
5058 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5059
5060         * gdbtypes.c (lookup_struct_elt): New function.
5061         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5062         * gdbtypes.h (struct struct_elt): New type.
5063         (lookup_struct_elt): New prototype.
5064
5065 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5066
5067         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5068         remove disabled code block.
5069
5070 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5071
5072         * gdbarch.sh (get_thread_local_address): New method.
5073         * gdbarch.h, gdbarch.c: Regenerate.
5074         * target.c (target_translate_tls_address): Use
5075         gdbarch_get_thread_local_address if present instead of
5076         target::get_thread_local_address.
5077
5078 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5079
5080         * target.h (target::get_thread_local_address): Update comment.
5081
5082 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5083
5084         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5085         objfile->separate_debug_objfile_backlink if not NULL.
5086
5087 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5088
5089         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5090         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5091         (amd64bsd_store_inferior_registers): Likewise.
5092         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5093         Enable segment base registers.
5094         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5095         PT_GETFSBASE and PT_GETGSBASE.
5096         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5097         PT_SETGSBASE.
5098         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5099         segment base registers.
5100         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5101
5102 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5103
5104         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5105         Update calls to i386_target_description to add 'segments'
5106         parameter.
5107         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5108         add segment base registers.
5109         * arch/i386.c (i386_create_target_description): Add 'segments'
5110         parameter to enable segment base registers.
5111         * arch/i386.h (i386_create_target_description): Likewise.
5112         * features/i386/32bit-segments.xml: New file.
5113         * features/i386/32bit-segments.c: Generate.
5114         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5115         call to i386_target_description to add 'segments' parameter.
5116         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5117         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5118         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5119         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5120         if feature is present.
5121         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5122         Add 'segments' parameter to call to i386_target_description.
5123         (i386_target_description): Add 'segments' parameter to enable
5124         segment base registers.
5125         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5126         to call to i386_target_description.
5127         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5128         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5129         Define I386_NUM_REGS.
5130         (i386_target_description): Add 'segments' parameter to enable
5131         segment base registers.
5132
5133 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5134
5135         PR/24325
5136         * source-cache.c: #undef open and close, to avoid unresolved
5137         externals during linking.
5138
5139 2019-03-12  Tom Tromey  <tromey@adacore.com>
5140
5141         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5142         const.  Add initializers.
5143         (_initialize_remote): Don't initialize ptid globals.
5144
5145 2019-03-12  Pedro Alves  <palves@redhat.com>
5146
5147         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5148
5149 2019-03-12  Pedro Alves  <palves@redhat.com>
5150
5151         * cp-name-parser.y (main): Remove unused 'len' variable.
5152
5153 2019-03-12  Tom Tromey  <tromey@adacore.com>
5154
5155         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5156         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5157
5158 2019-03-12  Tom Tromey  <tromey@adacore.com>
5159
5160         * linux-nat.c (iterate_over_lwps): Update.
5161         (stop_callback): Remove parameter.
5162         (stop_wait_callback, detach_callback, resume_set_callback)
5163         (select_singlestep_lwp_callback, set_ignore_sigint)
5164         (status_callback, resumed_callback, resume_clear_callback)
5165         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5166         data parameter.
5167         (linux_nat_target::detach, linux_nat_target::resume)
5168         (linux_stop_and_wait_all_lwps, select_event_lwp)
5169         (linux_nat_filter_event, linux_nat_wait_1)
5170         (linux_nat_target::kill, linux_nat_target::stop)
5171         (linux_nat_target::stop): Update.
5172         (linux_nat_resume_callback): Change type.
5173         (resume_stopped_resumed_lwps, count_events_callback)
5174         (select_event_lwp_callback): Likewise.
5175         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5176         * arm-linux-nat.c (struct update_registers_data): Remove.
5177         (update_registers_callback): Change type.
5178         (arm_linux_insert_hw_breakpoint1): Update.
5179         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5180         parameter.
5181         (x86_linux_dr_set_addr): Update.
5182         (x86_linux_dr_set_control): Update.
5183         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5184         (iterate_over_lwps): Use gdb::function_view.
5185         * nat/aarch64-linux-hw-point.c (struct
5186         aarch64_dr_update_callback_param): Remove.
5187         (debug_reg_change_callback): Change type.
5188         (aarch64_notify_debug_reg_change): Update.
5189         * s390-linux-nat.c (s390_refresh_per_info): Update.
5190
5191 2019-03-11  Tom Tromey  <tromey@adacore.com>
5192
5193         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5194         redundant assignment to "this_cu".
5195
5196 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5197
5198         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5199
5200 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5201
5202         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5203         from...
5204         (rank_one_type): ... this.
5205
5206 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5207
5208         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5209         from...
5210         (rank_one_type): ... this.
5211
5212 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5213
5214         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5215         from...
5216         (rank_one_type): ... this.
5217
5218 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5219
5220         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5221         from...
5222         (rank_one_type): ... this.
5223
5224 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5225
5226         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5227         from...
5228         (rank_one_type): ... this.
5229
5230 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5231
5232         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5233         from...
5234         (rank_one_type): ... this.
5235
5236 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5237
5238         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5239         from...
5240         (rank_one_type): ... this.
5241
5242 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5243
5244         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5245         from...
5246         (rank_one_type): ... this.
5247
5248 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5249
5250         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5251         from...
5252         (rank_one_type): ... this.
5253
5254 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5255
5256         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5257         from...
5258         (rank_one_type): ... this.
5259
5260 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5261
5262         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5263         from...
5264         (rank_one_type): ... this.
5265
5266 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5267
5268         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5269         from...
5270         (rank_one_type): ... this.
5271
5272 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5273
5274         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5275         inferior-events' shows the example events.
5276
5277 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5278
5279         Support styling on native MS-Windows console
5280
5281         PR/24315
5282         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5283         on MS-Windows if $TERM is not defined.
5284
5285         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5286
5287         * posix-hdep.c (gdb_console_fputs):
5288         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5289         functions.
5290         * ui-file.h (gdb_console_fputs): Add prototype.
5291
5292         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5293         back to fputs only if the former returns zero.
5294
5295 2019-03-07  Tom Tromey  <tom@tromey.com>
5296
5297         * symmisc.c (print_symbol_bcache_statistics): Update.
5298         (print_objfile_statistics): Update.
5299         * symfile.c (allocate_symtab): Update.
5300         * stabsread.c: Don't include bcache.h.
5301         * psymtab.h (struct psymbol_bcache): Don't declare.
5302         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5303         (psymbol_bcache_init, psymbol_bcache_free)
5304         (psymbol_bcache_get_bcache): Don't declare.
5305         * psymtab.c (struct psymbol_bcache): Remove.
5306         (psymtab_storage::psymtab_storage): Update.
5307         (psymtab_storage::~psymtab_storage): Update.
5308         (psymbol_bcache_init, psymbol_bcache_free)
5309         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5310         (add_psymbol_to_bcache): Update.
5311         (allocate_psymtab): Update.
5312         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5313         macro_cache>: No longer pointers.
5314         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5315         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5316         * macrotab.c (macro_bcache): Update.
5317         * macroexp.c: Don't include bcache.h.
5318         * gdbtypes.c (check_types_worklist): Update.
5319         (types_deeply_equal): Remove TRY/CATCH.  Update.
5320         * elfread.c (elf_symtab_read): Update.
5321         * dwarf2read.c: Don't include bcache.h.
5322         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5323         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5324         (print_bcache_statistics, bcache_memory_used): Don't declare.
5325         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5326         methods.  Rename all data members.
5327         * bcache.c (struct bcache): Move to bcache.h.
5328         (bcache::expand_hash_table): Rename from expand_hash_table.
5329         (bcache): Remove.
5330         (bcache::insert): Rename from bcache_full.
5331         (bcache::compare): Rename from bcache_compare.
5332         (bcache_xmalloc): Remove.
5333         (bcache::~bcache): Rename from bcache_xfree.
5334         (bcache::print_statistics): Rename from print_bcache_statistics.
5335         (bcache::memory_used): Rename from bcache_memory_used.
5336
5337 2019-03-07  Pedro Alves  <palves@redhat.com>
5338
5339         * infrun.c (normal_stop): Also check for
5340         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5341
5342 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5343
5344         * f-lang.c (value_from_host_double): Moved to...
5345         * value.c (value_from_host_double): ...here.
5346         * value.h (value_from_host_double): Declare.
5347         * guile/scm-math.c (vlscm_convert_typed_number): Use
5348         value_from_host_double.
5349         (vlscm_convert_number): Likewise.
5350         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5351         * python/py-value.c (convert_value_from_python): Likewise.
5352
5353 2019-03-06  Tom Tromey  <tom@tromey.com>
5354
5355         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5356
5357 2019-03-06  Tom Tromey  <tom@tromey.com>
5358
5359         * utils.h (free_current_contents): Don't declare.
5360         * utils.c (free_current_contents): Remove.
5361
5362 2019-03-06  Tom Tromey  <tom@tromey.com>
5363
5364         * top.c (quit_force): Update.
5365         * main.c (captured_command_loop): Update.
5366         * common/new-op.c (operator new): Update.
5367         * common/common-exceptions.c (struct catcher)
5368         <save_cleanup_chain>: Remove member.
5369         (exceptions_state_mc_init): Update.
5370         (exception_try_scope_entry): Return nullptr.
5371         (exception_try_scope_exit, exception_rethrow)
5372         (throw_exception_sjlj, throw_exception_cxx): Update.
5373         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5374         (all_cleanups, do_cleanups, discard_cleanups)
5375         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5376         (restore_cleanups, restore_final_cleanups): Don't declare.
5377         (do_final_cleanups): Remove parameter.
5378         * common/cleanups.c (cleanup_chain, make_cleanup)
5379         (make_cleanup_dtor, all_cleanups, do_cleanups)
5380         (discard_my_cleanups, discard_cleanups)
5381         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5382         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5383         (null_cleanup): Remove.
5384         (do_final_cleanups): Remove parameter.
5385
5386 2019-03-06  Tom Tromey  <tom@tromey.com>
5387
5388         * remote.c (remote_target::remote_parse_stop_reply): Use
5389         unique_xmalloc_ptr.
5390
5391 2019-03-06  Tom Tromey  <tom@tromey.com>
5392
5393         * stabsread.c (struct stabs_field_info): Rename from field_info.
5394         <list, fnlist>: Add initializers.
5395         <obstack>: New member.
5396         (read_member_functions, read_struct_fields, read_baseclasses):
5397         Allocate on obstack.  Don't use cleanups.
5398         (read_one_struct_field, read_member_functions, read_struct_fields)
5399         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5400         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5401         (read_struct_type): Update.
5402
5403 2019-03-06  Tom Tromey  <tom@tromey.com>
5404
5405         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5406         * common/filestuff.h (make_cleanup_close): Don't declare.
5407         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5408         Remove.
5409
5410 2019-03-06  Tom Tromey  <tom@tromey.com>
5411
5412         * solib-aix.c: Use make_scope_exit.
5413
5414 2019-03-06  Tom Tromey  <tom@tromey.com>
5415
5416         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5417         Use make_scope_exit.
5418
5419 2019-03-06  Tom Tromey  <tom@tromey.com>
5420
5421         * solib-svr4.c (disable_probes_interface): Remove parameter.
5422         (svr4_handle_solib_event): Use make_scope_exit.
5423
5424 2019-03-06  Tom Tromey  <tom@tromey.com>
5425
5426         * remote.c (struct stop_reply_deleter): Remove.
5427         (stop_reply_up): Update.
5428         (struct stop_reply): Derive from notif_event.  Don't typedef.
5429         <regcache>: Now a std::vector.
5430         (stop_reply_xfree): Remove.
5431         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5432         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5433         (remote_target::discard_pending_stop_replies): Use delete.
5434         (remote_target::remote_parse_stop_reply): Update.
5435         (remote_target::process_stop_reply): Update.
5436         * remote-notif.h (struct notif_event): Add virtual destructor.
5437         Remove "dtr" member.
5438         (struct notif_client) <alloc_event>: Return a unique_ptr.
5439         (notif_event_xfree): Don't declare.
5440         (notif_event_up): New typedef.
5441         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5442         (notif_event_xfree, do_notif_event_xfree): Remove.
5443         (remote_notif_state_xfree): Update.
5444
5445 2019-03-06  Tom Tromey  <tom@tromey.com>
5446
5447         * infrun.c (displaced_step_clear_cleanup): Now a
5448         forward_scope_exit type.
5449         (displaced_step_prepare_throw): Update.
5450         (displaced_step_fixup): Update.
5451
5452 2019-03-06  Tom Tromey  <tom@tromey.com>
5453
5454         * inferior.h (class inferior): Update comment.
5455         * gdbthread.h (class thread_info): Update comment.
5456
5457 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5458             Tom Tromey  <tom@tromey.com>
5459
5460         * stabsread.h (struct stab_section_list): Remove.
5461         (coffstab_build_psymtabs): Update.
5462         * dbxread.c (symbuf_sections): Now a std::vector.
5463         (sect_idx): New global.
5464         (fill_symbuf): Update.
5465         (coffstab_build_psymtabs): Change type of stabsects parameter.
5466         Update.
5467         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5468         std::vector.
5469         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5470         (coff_locate_sections): Update.
5471         (coff_symfile_read): Remove cleanups.  Update.
5472         (init_stringtab): Add storage parameter.
5473         (free_stringtab, free_stringtab_cleanup): Remove.
5474         (init_lineno): Add storage parameter.
5475         (free_linetab, free_linetab_cleanup): Remove.
5476
5477 2019-03-06  Pedro Alves  <palves@redhat.com>
5478
5479         * linux-fork.c (fork_info::clobber_regs): Delete.
5480         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5481         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5482         comment.  Adjust.
5483         (scoped_switch_fork_info::scoped_switch_fork_info)
5484         (checkpoint_command, linux_fork_context): Adjust
5485         fork_save_infrun_state calls.
5486
5487 2019-03-06  Pedro Alves  <palves@redhat.com>
5488
5489         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5490         (inf_has_multiple_threads): Return 'bool' and rewrite using
5491         inferior_info::threads().
5492
5493 2019-03-06  Pedro Alves  <palves@redhat.com>
5494
5495         * linux-fork.c: Include <list>.
5496         (fork_list): Now a std::list instance.
5497         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5498         (forks_exist_p, find_last_fork): Adjust.
5499         (new_fork): Delete.
5500         (one_fork_p): New.
5501         (add_fork): Adjust.
5502         (free_fork): Delete, folded into fork_info::~fork_info().
5503         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5504         Adjust.
5505         (init_fork_list): Delete.
5506         (linux_fork_killall, linux_fork_mourn_inferior)
5507         (linux_fork_detach, info_checkpoints_command): Adjust.
5508         (_initialize_linux_fork): No longer call init_fork_list.
5509
5510 2019-03-06  Pedro Alves  <palves@redhat.com>
5511
5512         * linux-fork.c (new_fork): New, split out of ...
5513         (add_fork): ... this.  Return void.  Move "first fork" special
5514         case from here, to ...
5515         (checkpoint_command): ... here.
5516         * linux-linux.h (add_fork): Return void.
5517
5518 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5519
5520         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5521
5522 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5523             Chris January  <chris.january@arm.com>
5524             David Lecomber  <david.lecomber@arm.com>
5525
5526         * f-exp.y: New token, UNOP_INTRINSIC.
5527         (exp): New pattern using UNOP_INTRINSIC token.
5528         (f77_keywords): Add 'abs' keyword.
5529         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5530         (value_from_host_double): New function.
5531         (evaluate_subexp_f): Support UNOP_ABS.
5532
5533 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5534
5535         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5536         types.
5537
5538 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5539
5540         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5541         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5542         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5543
5544 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5545
5546         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5547
5548 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5549             Chris January  <chris.january@arm.com>
5550
5551         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5552         * f-exp.y: Define 'KIND' token.
5553         (exp): New pattern for KIND expressions.
5554         (ptype): Handle types with a kind extension.
5555         (direct_abs_decl): Extend to spot kind extensions.
5556         (f77_keywords): Add 'kind' to the list.
5557         (push_kind_type): New function.
5558         (convert_to_kind_type): New function.
5559         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5560         * parse.c (operator_length_standard): Likewise.
5561         * parser-defs.h (enum type_pieces): Add tp_kind.
5562         * std-operator.def: Add UNOP_KIND.
5563
5564 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5565
5566         * f-exp.y (f_parse): Set yydebug.
5567
5568 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5569
5570         * f-lang.c (evaluate_subexp_f): New function.
5571         (exp_descriptor_f): New global.
5572         (f_language_defn): Use exp_descriptor_f instead of
5573         exp_descriptor_standard.
5574
5575 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5576
5577         * f-exp.y (struct token): Add comments.
5578         (dot_ops): Remove uppercase versions and the end marker.
5579         (f77_keywords): Likewise.
5580         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5581         entries in the dot_ops array are case insensitive, and use
5582         strncasecmp to compare strings.  Also some whitespace cleanup in
5583         this area.  Similar for the f77_keywords array, except entries in
5584         this list might be case sensitive.
5585
5586 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5587
5588         * f-exp.y (struct f77_boolean_val): Add comments.
5589         (boolean_values): Remove uppercase versions, and end marker.
5590         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5591         and use strncasecmp to achieve case insensitivity.  Additionally,
5592         perform whitespace cleanup around this code.
5593
5594 2019-03-06  Tom Tromey  <tromey@adacore.com>
5595
5596         * remote-sim.c (gdbsim_target_open): Use result of
5597         gdb_argv::release.
5598
5599 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5600         Dirk Schubert  <dirk.schubert@arm.com>
5601         Chris January  <chris.january@arm.com>
5602
5603         * eval.c (evaluate_subexp_standard): Call Fortran argument
5604         wrapping logic.
5605         * f-lang.c (struct value): A value which can be passed into a
5606         Fortran function call.
5607         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5608         where appropriate.
5609         (struct type): Value ready for a Fortran function call.
5610         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5611         is needed.
5612         * f-lang.h (fortran_argument_convert): Declaration.
5613         (fortran_preserve_arg_pointer): Declaration.
5614         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5615
5616 2019-03-05  Tom Tromey  <tromey@adacore.com>
5617
5618         * python/py-prettyprint.c (print_string_repr): Remove #if.
5619         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5620
5621 2019-03-05  Tom Tromey  <tromey@adacore.com>
5622
5623         * target.c (the_dummy_target): Move later.  Change type to
5624         "dummy_target".
5625         (initialize_targets): Don't initialize the_dummy_target.
5626
5627 2019-03-05  Tom Tromey  <tromey@adacore.com>
5628
5629         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5630         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5631
5632 2019-03-05  Tom Tromey  <tromey@adacore.com>
5633
5634         * windows-nat.c (windows_nat_target::attach)
5635         (windows_nat_target::detach): Don't call gdb_flush.
5636         * valprint.c (generic_val_print, val_print, val_print_string):
5637         Don't call gdb_flush.
5638         * utils.c (defaulted_query): Don't call gdb_flush.
5639         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5640         * target.c (target_announce_detach): Don't call gdb_flush.
5641         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5642         * remote.c (extended_remote_target::attach): Don't call
5643         gdb_flush.
5644         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5645         * printcmd.c (do_examine): Don't call gdb_flush.
5646         (info_display_command): Don't call gdb_flush.
5647         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5648         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5649         * memattr.c (info_mem_command): Don't call gdb_flush.
5650         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5651         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5652         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5653         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5654         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5655         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5656         (gnu_nat_target::detach): Don't call gdb_flush.
5657         * f-valprint.c (f_val_print): Don't call gdb_flush.
5658         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5659         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5660         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5661         gdb_flush.
5662         * c-valprint.c (c_val_print): Don't call gdb_flush.
5663         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5664
5665 2019-03-05  Tom Tromey  <tromey@adacore.com>
5666
5667         * varobj.c (update_dynamic_varobj_children): Update.
5668         (install_default_visualizer): Use reset, not release.
5669         * value.c (set_internalvar): Update.
5670         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5671         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5672         ATTRIBUTE_UNUSED_RESULT.
5673
5674 2019-03-05  Tom Tromey  <tromey@adacore.com>
5675
5676         * remote.c (class scoped_remote_fd) <release>: Add
5677         ATTRIBUTE_UNUSED_RESULT.
5678
5679 2019-03-05  Tom Tromey  <tromey@adacore.com>
5680
5681         * macroexp.c (struct macro_buffer) <release>: Add
5682         ATTRIBUTE_UNUSED_RESULT.
5683
5684 2019-03-05  Tom Tromey  <tromey@adacore.com>
5685
5686         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5687         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5688         ATTRIBUTE_UNUSED_RESULT.
5689
5690 2019-03-05  Tom Tromey  <tromey@adacore.com>
5691
5692         * common/scoped_fd.h (class scoped_fd) <release>: Add
5693         ATTRIBUTE_UNUSED_RESULT.
5694
5695 2019-03-05  Tom Tromey  <tromey@adacore.com>
5696
5697         * parser-defs.h (struct parser_state) <release>: Add
5698         ATTRIBUTE_UNUSED_RESULT.
5699
5700 2019-03-05  Tom Tromey  <tromey@adacore.com>
5701
5702         * utils.h (class gdb_argv) <release>: Add
5703         ATTRIBUTE_UNUSED_RESULT.
5704         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5705
5706 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5707
5708         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5709         for-loop range, to avoid compiler warnings.
5710
5711         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5712         avoid compiler warnings about unused variables.
5713
5714         * NEWS: Mention end of support for native debugging on MS-Windows
5715         before XP.
5716
5717         PR gdb/24292
5718         * common/netstuff.c:
5719         * gdbserver/gdbreplay.c
5720         * gdbserver/remote-utils.c:
5721         * ser-tcp.c:
5722         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5723         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5724         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5725         'getaddrinfo' and 'freeaddrinfo' were not available before
5726         Windows XP, and mingw.org's MinGW headers by default define
5727         _WIN32_WINNT to 0x500.
5728
5729 2019-03-01  Gary Benson <gbenson@redhat.com>
5730
5731         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5732
5733 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5734             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5735
5736         PR gdb/8527
5737         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5738         set_sigint_trap, clear_sigint_trap.
5739
5740 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5741
5742         * target.c (target_detach): Clear the regcache and the
5743         frame cache.
5744
5745 2019-02-27  Pedro Alves  <palves@redhat.com>
5746
5747         * utils.c (set_screen_size): When we cap the height/width sizes,
5748         tweak the corresponding command variable to show "unlimited":
5749
5750 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5751             Pedro Alves  <palves@redhat.com>
5752
5753         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5754         before calling rl_set_screen_size.
5755
5756 2019-02-27  Tom Tromey  <tromey@adacore.com>
5757
5758         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5759         define.
5760         * python/py-value.c: Remove Python 2.4 workaround.
5761         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5762         workaround.
5763         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5764         Python 2.4 workaround.
5765         * python/python-internal.h: Remove Python 2.4 comment.
5766         (Py_ssize_t): Don't define.
5767         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5768         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5769         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5770         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5771         * python/python.c (do_start_initialization): Remove Python 2.4
5772         workaround.
5773         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5774         (print_children): Remove Python 2.4 workaround.
5775         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5776         workaround.
5777         (CHARBUFFERPROC_NAME): Remove.
5778         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5779         Python 2.4 workaround.
5780
5781 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5782
5783         * NEWS: Note minimum Python version.
5784
5785 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5786
5787         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5788         code from these functions.  Remove corresponding ifdefs.  Use
5789         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5790         Remove gotos and target of gotos.
5791         (infpy_search_memory): Likewise.
5792
5793 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5794
5795         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5796         (hppa_gdbarch_init): Don't register deleted functions with
5797         gdbarch.
5798
5799 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5800
5801         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5802         (h8300_unwind_sp): Delete.
5803         (h8300_dummy_id): Delete.
5804         (h8300_gdbarch_init): Don't register deleted functions with
5805         gdbarch.
5806
5807 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5808
5809         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5810         (ft32_unwind_pc): Delete.
5811         (ft32_unwind_sp): Delete.
5812         (ft32_gdbarch_init): Don't register deleted functions with
5813         gdbarch.
5814
5815 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5816
5817         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5818         (frv_unwind_pc): Delete.
5819         (frv_unwind_sp): Delete.
5820         (frv_gdbarch_init): Don't register deleted functions with
5821         gdbarch.
5822
5823 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5824
5825         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5826         (riscv_unwind_pc): Delete.
5827         (riscv_unwind_sp): Delete.
5828         (riscv_gdbarch_init): Don't register deleted functions with
5829         gdbarch.
5830
5831 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5832
5833         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5834         (csky_unwind_pc): Delete.
5835         (csky_unwind_sp): Delete.
5836         (csky_gdbarch_init): Don't register deleted functions with
5837         gdbarch.
5838
5839 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5840
5841         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5842         (cris_unwind_pc): Delete.
5843         (cris_unwind_sp): Delete.
5844         (cris_gdbarch_init): Don't register deleted functions with
5845         gdbarch.
5846
5847 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5848
5849         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5850         (bfin_unwind_pc): Delete.
5851         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5852
5853 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5854
5855         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5856         (arm_unwind_pc): Delete.
5857         (arm_unwind_sp): Delete.
5858         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5859
5860 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5861
5862         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5863         (arc_unwind_pc): Delete.
5864         (arc_unwind_sp): Delete.
5865         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5866
5867 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5868
5869         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5870         (alpha_unwind_pc): Delete.
5871         (alpha_gdbarch_init): Don't register deleted functions with
5872         gdbarch.
5873
5874 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5875
5876         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5877         (aarch64_unwind_pc): Delete.
5878         (aarch64_unwind_sp): Delete.
5879         (aarch64_gdbarch_init): Don't register deleted functions with
5880         gdbarch.
5881
5882 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5883
5884         * gdbtypes.c (type_align): Don't consider static members when
5885         computing structure alignment.
5886
5887 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5888
5889         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5890         return 0 for other types.
5891         * arch-utils.c (default_type_align): Always return 0.
5892         * gdbarch.h: Regenerate.
5893         * gdbarch.sh (type_align): Extend comment.
5894         * gdbtypes.c (type_align): Add additional comments, always call
5895         gdbarch_type_align before applying the default rules.
5896         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5897         generic code will then apply a suitable default.
5898         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5899         types, return 0 for other types.
5900
5901 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5902
5903         * NEWS: Create a new section for the next release branch.
5904         Rename the section of the current branch, now that it has
5905         been cut.
5906
5907 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5908
5909         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5910         * version.in: Bump version to 8.3.50.DATE-git.
5911
5912 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5913
5914         * aix-thread.c (ptid_cmp): Remove unused variable.
5915         (get_signaled_thread): Likewise.
5916         (store_regs_user_thread): Likewise.
5917         (store_regs_kernel_thread): Likewise.
5918         (fetch_regs_kernel_thread): Remove shadowed variable.
5919
5920 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5921
5922         * features/riscv/32bit-cpu.xml: Add register numbers.
5923         * features/riscv/32bit-fpu.c: Regenerate.
5924         * features/riscv/32bit-fpu.xml: Add register numbers.
5925         * features/riscv/64bit-cpu.xml: Add register numbers.
5926         * features/riscv/64bit-fpu.c: Regenerate.
5927         * features/riscv/64bit-fpu.xml: Add register numbers.
5928
5929 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5930
5931         * NEWS: Mention two argument form of gdb.Value constructor.
5932         * python/py-value.c (convert_buffer_and_type_to_value): New
5933         function.
5934         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5935         Add support for handling an optional second argument.  Call
5936         convert_buffer_and_type_to_value as appropriate.
5937         * python/python-internal.h (Py_buffer_deleter): New struct.
5938         (Py_buffer_up): New typedef.
5939
5940 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5941
5942         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5943         instead of releasing ownership.
5944
5945 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5946
5947         * dwarf2read.c (open_and_init_dwp_file): Call
5948         elf_numsections instead of bfd_count_sections to initialize
5949         dwp_file->num_sections.
5950
5951 2019-02-25  Tom Tromey  <tromey@adacore.com>
5952
5953         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5954
5955 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5956
5957         * gcore.in: Add '--readnever' option when invoking GDB.
5958
5959 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5960
5961         * MAINTAINERS: Update my email address.
5962
5963 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5964
5965         * build-id.c (build_id_to_debug_bfd_1): New function.
5966         (build_id_to_debug_bfd): Look for separate debug file in
5967         sysroot.
5968
5969 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5970
5971         * gdbarch.sh: Update the copyright year range that is placed into
5972         generated files.
5973
5974 2019-02-22  Keith Seitz  <keiths@redhat.com>
5975
5976         PR symtab/23853
5977         * linespec.c (create_sals_line_offset): Search for the default
5978         symtab's filename instead of its fullname.
5979
5980 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5981
5982         * NEWS: Update style defaults.
5983
5984 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5985
5986         * main.c (captured_main_1): Disable styling in batch mode.
5987
5988 2019-02-20  Tom Tromey  <tom@tromey.com>
5989
5990         * symtab.c (symtab_symbol_info): Fix typos.
5991
5992 2019-02-20  Tom Tromey  <tromey@adacore.com>
5993
5994         * findcmd.c (_initialize_mem_search): Use upper case for
5995         metasyntactic variables.
5996
5997 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5998
5999         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6000         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6001
6002 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6003
6004         * top.h (source_file_name): Change to std::string.
6005         * top.c (source_file_name): Likewise.
6006         (command_line_input): Adjust.
6007         * cli/cli-script.c (script_from_file): Adjust.
6008
6009 2019-02-19  Tom Tromey  <tromey@adacore.com>
6010
6011         * ravenscar-thread.c
6012         (ravenscar_thread_target::update_thread_list): Don't call
6013         ada_build_task_list.
6014         * ada-lang.h (ada_build_task_list): Don't declare.
6015         * ada-tasks.c (struct ada_tasks_inferior_data)
6016         <task_list_valid_p>: Now bool.
6017         (read_known_tasks, ada_task_list_changed)
6018         (ada_tasks_invalidate_inferior_data): Update.
6019         (read_known_tasks_array): Return bool.
6020         (read_known_tasks_list): Likewise.
6021         (read_known_tasks): Return void.
6022         (ada_build_task_list): Now static.
6023
6024 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6025
6026         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6027         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6028
6029 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6030
6031         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6032         variant for ada_tasks_pspace_data_handle and
6033         ada_tasks_inferior_data_handle.
6034         (ada_tasks_pspace_data_cleanup): New function.
6035         (ada_tasks_inferior_data_cleanup): New function.
6036
6037 2019-02-17  Tom Tromey  <tom@tromey.com>
6038
6039         * macrotab.h (macro_source_fullname): Return a std::string.
6040         * macrotab.c (macro_include, check_for_redefinition)
6041         (macro_undef, macro_lookup_definition, foreach_macro)
6042         (foreach_macro_in_scope): Update.
6043         (macro_source_fullname): Return a std::string.
6044         * macrocmd.c (show_pp_source_pos): Update.
6045
6046 2019-02-17  Tom Tromey  <tom@tromey.com>
6047
6048         * macrocmd.c (show_pp_source_pos): Style the file names.
6049
6050 2019-02-17  Tom Tromey  <tom@tromey.com>
6051
6052         PR tui/24197:
6053         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6054
6055 2019-02-17  Tom Tromey  <tom@tromey.com>
6056
6057         * ada-lang.c (user_select_syms): Use filtered printing.
6058         * utils.c (wrap_style): New global.
6059         (desired_style): Remove.
6060         (emit_style_escape): Add stream parameter.
6061         (set_output_style, reset_terminal_style, prompt_for_continue):
6062         Update.
6063         (flush_wrap_buffer): Only flush gdb_stdout.
6064         (wrap_here): Set wrap_style.
6065         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6066         treat escape sequences as a character.  Change when wrap buffer is
6067         flushed.
6068         (fputs_styled): Do not set the output style when the default is
6069         requested.
6070         * ui-style.h (struct ui_file_style) <is_default>: New method.
6071         * source.c (print_source_lines_base): Emit escape sequences in one
6072         piece.
6073
6074 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6075
6076         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6077         integers and enumeration types.
6078
6079 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6080
6081         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6082         instead of lookup_symbol_in_language
6083         (do_exact_match): New function.
6084         (ada_get_symbol_name_matcher): Return do_exact_match when
6085         doing a verbatim match.
6086
6087 2019-02-15  Tom Tromey  <tromey@adacore.com>
6088
6089         * ravenscar-thread.c (ravenscar_thread_target::resume)
6090         (ravenscar_thread_target::wait): Special case wildcard requests.
6091
6092 2019-02-15  Tom Tromey  <tromey@adacore.com>
6093
6094         * ravenscar-thread.c (base_ptid): Remove.
6095         (struct ravenscar_thread_target) <close>: New method.
6096         <m_base_ptid>: New member.
6097         <update_inferior_ptid, active_task, task_is_currently_active,
6098         runtime_initialized>: Declare methods.
6099         <ravenscar_thread_target>: Add constructor.
6100         (ravenscar_thread_target::task_is_currently_active)
6101         (ravenscar_thread_target::update_inferior_ptid)
6102         (ravenscar_runtime_initialized): Rename.  Now methods.
6103         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6104         (ravenscar_thread_target::update_thread_list): Update.
6105         (ravenscar_thread_target::active_task): Now method.
6106         (ravenscar_thread_target::store_registers)
6107         (ravenscar_thread_target::prepare_to_store)
6108         (ravenscar_thread_target::prepare_to_store)
6109         (ravenscar_thread_target::mourn_inferior): Update.
6110         (ravenscar_inferior_created): Use "new" to create target.
6111         (ravenscar_thread_target::get_ada_task_ptid): Update.
6112         (_initialize_ravenscar): Don't initialize base_ptid.
6113         (ravenscar_ops): Remove global.
6114
6115 2019-02-15  Tom Tromey  <tromey@adacore.com>
6116
6117         * target.h (push_target): Declare new overload.
6118         * target.c (push_target): New overload, taking an rvalue reference.
6119         * remote.c (remote_target::open_1): Use push_target overload.
6120         * corelow.c (core_target_open): Use push_target overload.
6121
6122 2019-02-15  Tom Tromey  <tromey@adacore.com>
6123
6124         * ravenscar-thread.c (is_ravenscar_task)
6125         (ravenscar_task_is_currently_active): Return bool.
6126         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6127         (_initialize_ravenscar): Remove "(void)".
6128         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6129         Return bool.
6130
6131 2019-02-15  Tom Tromey  <tromey@adacore.com>
6132
6133         * ravenscar-thread.c (ravenscar_runtime_initializer)
6134         (has_ravenscar_runtime, get_running_thread_id)
6135         (ravenscar_thread_target::resume): Fix indentation.
6136
6137 2019-02-15  Tom Tromey  <tromey@adacore.com>
6138
6139         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6140         from ravenscar_arch_ops.
6141         (sparc_ravenscar_ops::fetch_registers)
6142         (sparc_ravenscar_ops::store_registers): Now methods.
6143         (sparc_ravenscar_prepare_to_store): Remove.
6144         (sparc_ravenscar_ops): Redefine.
6145         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6146         methods and destructor.  Remove members.
6147         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6148         (ravenscar_thread_target::store_registers)
6149         (ravenscar_thread_target::prepare_to_store): Update.
6150         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6151         Remove.
6152         (struct ppc_ravenscar_powerpc_ops): Derive from
6153         ravenscar_arch_ops.
6154         (ppc_ravenscar_powerpc_ops::fetch_registers)
6155         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6156         (ppc_ravenscar_powerpc_ops): Redefine.
6157         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6158         (ppc_ravenscar_e500_ops::fetch_registers)
6159         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6160         (ppc_ravenscar_e500_ops): Redefine.
6161         * aarch64-ravenscar-thread.c
6162         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6163         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6164         (aarch64_ravenscar_fetch_registers)
6165         (aarch64_ravenscar_store_registers): Now methods.
6166         (aarch64_ravenscar_ops): Redefine.
6167
6168 2019-02-15  Tom Tromey  <tromey@adacore.com>
6169
6170         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6171         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6172         (ravenscar_thread_target::stopped_by_watchpoint)
6173         (ravenscar_thread_target::stopped_data_address)
6174         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6175
6176 2019-02-15  Tom Tromey  <tromey@adacore.com>
6177
6178         * ravenscar-thread.c: Fix some typos.
6179
6180 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6181             Tom Tromey  <tromey@adacore.com>
6182
6183         * ada-lang.c (ada_exception_sal): Change addr_string to a
6184         std::string.
6185         (create_ada_exception_catchpoint): Update.
6186
6187 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6188             Tom Tromey  <tromey@adacore.com>
6189
6190         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6191         (bp_location_ops): Remove.
6192         (base_breakpoint_allocate_location): Update.
6193         (free_bp_location): Update.
6194         * ada-lang.c (class ada_catchpoint_location)
6195         <ada_catchpoint_location>: Remove ops parameter.
6196         (ada_catchpoint_location_dtor): Remove.
6197         (ada_catchpoint_location_ops): Remove.
6198         (allocate_location_exception): Update.
6199         * breakpoint.h (struct bp_location_ops): Remove.
6200         (class bp_location) <bp_location>: Remove bp_location_ops
6201         parameter.
6202         <~bp_location>: Add destructor.
6203         <ops>: Remove.
6204
6205 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6206             Pedro Alves  <palves@redhat.com>
6207
6208         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6209         'PATH_MAX'.
6210
6211 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6212             Samuel Thibault  <samuel.thibault@gnu.org>
6213             Thomas Schwinge  <thomas@codesourcery.com>
6214
6215         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6216         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6217
6218 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6219
6220         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6221         (check_empty): Use "const char *".
6222
6223         * gnu-nat.c (gnu_nat_target::detach): Instead of
6224         'detach_inferior (pid)' call
6225         'detach_inferior (find_inferior_pid (pid))'.
6226
6227         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6228         'nat/fork-inferior.o'.
6229         * gnu-nat.c: #include "nat/fork-inferior.h".
6230
6231         * gnu-nat.c (gnu_nat_target::detach): Instead of
6232         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6233         * gnu-nat.h: #include "inf-child.h".
6234         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6235         'i386_gnu_nat_target::fetch_registers'.
6236         (gnu_store_registers): Rename/move to
6237         'i386_gnu_nat_target::store_registers'.
6238
6239         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6240         * gnu-nat.h (mach_thread_info): New function.
6241         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6242
6243         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6244
6245 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6246
6247         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6248
6249 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6250
6251         * windows-nat.c (windows_add_thread): Add new parameter
6252         "main_thread_p" with default value set to false.  Update
6253         function documentation as well as all callers.
6254         (windows_delete_thread): Likewise.
6255         (fake_create_process): Update call to windows_add_thread.
6256         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6257         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6258         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6259         call to windows_delete_thread.
6260
6261 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6262
6263         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6264
6265 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6266
6267         * symfile.c (find_separate_debug_file): Use canonical path of
6268         sysroot with child_path instead of gdb_sysroot if it is valid.
6269
6270 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6271
6272         * symfile.c (find_separate_debug_file): Use child_path to
6273         determine if an object file is under a sysroot.
6274
6275 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6276
6277         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6278         unittests/child-path-selftests.c.
6279         * common/pathstuff.c (child_path): New function.
6280         * common/pathstuff.h (child_path): New prototype.
6281         * unittests/child-path-selftests.c: New file.
6282
6283 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6284
6285         * symfile.c (find_separate_debug_file): Look for separate debug
6286         files in debug directories under the sysroot.
6287
6288 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6289
6290         * symtab.h (struct minimal_symbol data_p): New const method.
6291         (struct minimal_symbol text_p): Likewise.
6292         * symtab.c (output_source_filename): Use file name style
6293         to print file name.
6294         (print_symbol_info): Likewise.
6295         (print_msymbol_info): Use address style to print addresses.
6296         Use function name style to print executable text symbols.
6297         (expand_symtab_containing_pc): Use data_p.
6298         (find_pc_sect_compunit_symtab): Likewise.
6299
6300 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6301
6302         * breakpoint.c (describe_other_breakpoints): Use address style
6303         to print addresses.
6304         (say_where): Likewise.
6305
6306 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6307
6308         * ada-typeprint.c (print_func_type): Print function name
6309         style to print function name.
6310         * c-typeprint.c (c_print_type_1): Likewise.
6311
6312 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6313
6314         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6315         for execve.
6316
6317 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6318
6319         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6320         type_stack.
6321
6322 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6323
6324         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6325         TYPE_CODE_REF types.
6326
6327 2019-02-08  Jim Wilson  <jimw@sifive.com>
6328
6329         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6330         (riscv_linux_fregset): New.
6331         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6332
6333 2019-02-07  Tom Tromey  <tom@tromey.com>
6334
6335         * thread.c (thread_cancel_execution_command): Update.
6336         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6337         methods.
6338         (struct thread_fsm_ops): Remove.
6339         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6340         (thread_fsm_should_stop, thread_fsm_return_value)
6341         (thread_fsm_set_finished, thread_fsm_finished_p)
6342         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6343         Don't declare.
6344         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6345         * infrun.c (clear_proceed_status_thread)
6346         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6347         (print_stop_event): Update.
6348         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6349         Add constructor.
6350         (step_command_fsm_ops): Remove.
6351         (new_step_command_fsm): Remove.
6352         (step_1): Update.
6353         (step_command_fsm::should_stop): Rename from
6354         step_command_fsm_should_stop.
6355         (step_command_fsm::clean_up): Rename from
6356         step_command_fsm_clean_up.
6357         (step_command_fsm::do_async_reply_reason): Rename from
6358         step_command_fsm_async_reply_reason.
6359         (struct until_next_fsm): Inherit from thread_fsm.  Add
6360         constructor.
6361         (until_next_fsm_ops): Remove.
6362         (new_until_next_fsm): Remove.
6363         (until_next_fsm::should_stop): Rename from
6364         until_next_fsm_should_stop.
6365         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6366         (until_next_fsm::do_async_reply_reason): Rename from
6367         until_next_fsm_async_reply_reason.
6368         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6369         constructor.  Change type of breakpoint.
6370         (finish_command_fsm_ops): Remove.
6371         (new_finish_command_fsm): Remove.
6372         (finish_command_fsm::should_stop): Rename from
6373         finish_command_fsm_should_stop.
6374         (finish_command_fsm::clean_up): Rename from
6375         finish_command_fsm_clean_up.
6376         (finish_command_fsm::return_value): Rename from
6377         finish_command_fsm_return_value.
6378         (finish_command_fsm::do_async_reply_reason): Rename from
6379         finish_command_fsm_async_reply_reason.
6380         (finish_command): Update.
6381         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6382         Add constructor.
6383         (call_thread_fsm_ops): Remove.
6384         (call_thread_fsm::call_thread_fsm): Rename from
6385         new_call_thread_fsm.
6386         (call_thread_fsm::should_stop): Rename from
6387         call_thread_fsm_should_stop.
6388         (call_thread_fsm::should_notify_stop): Rename from
6389         call_thread_fsm_should_notify_stop.
6390         (run_inferior_call, call_function_by_hand_dummy): Update.
6391         * cli/cli-interp.c (should_print_stop_to_console): Update.
6392         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6393         Add constructor.  Change type of location_breakpoint,
6394         caller_breakpoint.
6395         (until_break_fsm_ops): Remove.
6396         (new_until_break_fsm): Remove.
6397         (until_break_fsm::should_stop): Rename from
6398         until_break_fsm_should_stop.
6399         (until_break_fsm::clean_up): Rename from
6400         until_break_fsm_clean_up.
6401         (until_break_fsm::do_async_reply_reason): Rename from
6402         until_break_fsm_async_reply_reason.
6403         (until_break_command): Update.
6404         * thread-fsm.c: Remove.
6405         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6406
6407 2019-02-07  Tom Tromey  <tom@tromey.com>
6408
6409         * yy-remap.h: Add include guard.
6410         * xtensa-tdep.h: Add include guard.
6411         * xcoffread.h: Rename include guard.
6412         * varobj-iter.h: Add include guard.
6413         * tui/tui.h: Rename include guard.
6414         * tui/tui-winsource.h: Rename include guard.
6415         * tui/tui-wingeneral.h: Rename include guard.
6416         * tui/tui-windata.h: Rename include guard.
6417         * tui/tui-win.h: Rename include guard.
6418         * tui/tui-stack.h: Rename include guard.
6419         * tui/tui-source.h: Rename include guard.
6420         * tui/tui-regs.h: Rename include guard.
6421         * tui/tui-out.h: Rename include guard.
6422         * tui/tui-layout.h: Rename include guard.
6423         * tui/tui-io.h: Rename include guard.
6424         * tui/tui-hooks.h: Rename include guard.
6425         * tui/tui-file.h: Rename include guard.
6426         * tui/tui-disasm.h: Rename include guard.
6427         * tui/tui-data.h: Rename include guard.
6428         * tui/tui-command.h: Rename include guard.
6429         * tic6x-tdep.h: Add include guard.
6430         * target/waitstatus.h: Rename include guard.
6431         * target/wait.h: Rename include guard.
6432         * target/target.h: Rename include guard.
6433         * target/resume.h: Rename include guard.
6434         * target-float.h: Rename include guard.
6435         * stabsread.h: Add include guard.
6436         * rs6000-tdep.h: Add include guard.
6437         * riscv-fbsd-tdep.h: Add include guard.
6438         * regformats/regdef.h: Rename include guard.
6439         * record.h: Rename include guard.
6440         * python/python.h: Rename include guard.
6441         * python/python-internal.h: Rename include guard.
6442         * python/py-stopevent.h: Rename include guard.
6443         * python/py-ref.h: Rename include guard.
6444         * python/py-record.h: Rename include guard.
6445         * python/py-record-full.h: Rename include guard.
6446         * python/py-record-btrace.h: Rename include guard.
6447         * python/py-instruction.h: Rename include guard.
6448         * python/py-events.h: Rename include guard.
6449         * python/py-event.h: Rename include guard.
6450         * procfs.h: Add include guard.
6451         * proc-utils.h: Add include guard.
6452         * p-lang.h: Add include guard.
6453         * or1k-tdep.h: Rename include guard.
6454         * observable.h: Rename include guard.
6455         * nto-tdep.h: Rename include guard.
6456         * nat/x86-linux.h: Rename include guard.
6457         * nat/x86-linux-dregs.h: Rename include guard.
6458         * nat/x86-gcc-cpuid.h: Add include guard.
6459         * nat/x86-dregs.h: Rename include guard.
6460         * nat/x86-cpuid.h: Rename include guard.
6461         * nat/ppc-linux.h: Rename include guard.
6462         * nat/mips-linux-watch.h: Rename include guard.
6463         * nat/linux-waitpid.h: Rename include guard.
6464         * nat/linux-ptrace.h: Rename include guard.
6465         * nat/linux-procfs.h: Rename include guard.
6466         * nat/linux-osdata.h: Rename include guard.
6467         * nat/linux-nat.h: Rename include guard.
6468         * nat/linux-namespaces.h: Rename include guard.
6469         * nat/linux-btrace.h: Rename include guard.
6470         * nat/glibc_thread_db.h: Rename include guard.
6471         * nat/gdb_thread_db.h: Rename include guard.
6472         * nat/gdb_ptrace.h: Rename include guard.
6473         * nat/fork-inferior.h: Rename include guard.
6474         * nat/amd64-linux-siginfo.h: Rename include guard.
6475         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6476         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6477         * nat/aarch64-linux.h: Rename include guard.
6478         * nat/aarch64-linux-hw-point.h: Rename include guard.
6479         * mn10300-tdep.h: Add include guard.
6480         * mips-linux-tdep.h: Add include guard.
6481         * mi/mi-parse.h: Rename include guard.
6482         * mi/mi-out.h: Rename include guard.
6483         * mi/mi-main.h: Rename include guard.
6484         * mi/mi-interp.h: Rename include guard.
6485         * mi/mi-getopt.h: Rename include guard.
6486         * mi/mi-console.h: Rename include guard.
6487         * mi/mi-common.h: Rename include guard.
6488         * mi/mi-cmds.h: Rename include guard.
6489         * mi/mi-cmd-break.h: Rename include guard.
6490         * m2-lang.h: Add include guard.
6491         * location.h: Rename include guard.
6492         * linux-record.h: Rename include guard.
6493         * linux-nat.h: Add include guard.
6494         * linux-fork.h: Add include guard.
6495         * i386-darwin-tdep.h: Rename include guard.
6496         * hppa-linux-offsets.h: Add include guard.
6497         * guile/guile.h: Rename include guard.
6498         * guile/guile-internal.h: Rename include guard.
6499         * gnu-nat.h: Rename include guard.
6500         * gdb-stabs.h: Rename include guard.
6501         * frv-tdep.h: Add include guard.
6502         * f-lang.h: Add include guard.
6503         * event-loop.h: Add include guard.
6504         * darwin-nat.h: Rename include guard.
6505         * cp-abi.h: Rename include guard.
6506         * config/sparc/nm-sol2.h: Rename include guard.
6507         * config/nm-nto.h: Rename include guard.
6508         * config/nm-linux.h: Add include guard.
6509         * config/i386/nm-i386gnu.h: Rename include guard.
6510         * config/djgpp/nl_types.h: Rename include guard.
6511         * config/djgpp/langinfo.h: Rename include guard.
6512         * compile/gcc-cp-plugin.h: Add include guard.
6513         * compile/gcc-c-plugin.h: Add include guard.
6514         * compile/compile.h: Rename include guard.
6515         * compile/compile-object-run.h: Rename include guard.
6516         * compile/compile-object-load.h: Rename include guard.
6517         * compile/compile-internal.h: Rename include guard.
6518         * compile/compile-cplus.h: Rename include guard.
6519         * compile/compile-c.h: Rename include guard.
6520         * common/xml-utils.h: Rename include guard.
6521         * common/x86-xstate.h: Rename include guard.
6522         * common/version.h: Rename include guard.
6523         * common/vec.h: Rename include guard.
6524         * common/tdesc.h: Rename include guard.
6525         * common/selftest.h: Rename include guard.
6526         * common/scoped_restore.h: Rename include guard.
6527         * common/scoped_mmap.h: Rename include guard.
6528         * common/scoped_fd.h: Rename include guard.
6529         * common/safe-iterator.h: Rename include guard.
6530         * common/run-time-clock.h: Rename include guard.
6531         * common/refcounted-object.h: Rename include guard.
6532         * common/queue.h: Rename include guard.
6533         * common/ptid.h: Rename include guard.
6534         * common/print-utils.h: Rename include guard.
6535         * common/preprocessor.h: Rename include guard.
6536         * common/pathstuff.h: Rename include guard.
6537         * common/observable.h: Rename include guard.
6538         * common/netstuff.h: Rename include guard.
6539         * common/job-control.h: Rename include guard.
6540         * common/host-defs.h: Rename include guard.
6541         * common/gdb_wait.h: Rename include guard.
6542         * common/gdb_vecs.h: Rename include guard.
6543         * common/gdb_unlinker.h: Rename include guard.
6544         * common/gdb_unique_ptr.h: Rename include guard.
6545         * common/gdb_tilde_expand.h: Rename include guard.
6546         * common/gdb_sys_time.h: Rename include guard.
6547         * common/gdb_string_view.h: Rename include guard.
6548         * common/gdb_splay_tree.h: Rename include guard.
6549         * common/gdb_setjmp.h: Rename include guard.
6550         * common/gdb_ref_ptr.h: Rename include guard.
6551         * common/gdb_optional.h: Rename include guard.
6552         * common/gdb_locale.h: Rename include guard.
6553         * common/gdb_assert.h: Rename include guard.
6554         * common/filtered-iterator.h: Rename include guard.
6555         * common/filestuff.h: Rename include guard.
6556         * common/fileio.h: Rename include guard.
6557         * common/environ.h: Rename include guard.
6558         * common/common-utils.h: Rename include guard.
6559         * common/common-types.h: Rename include guard.
6560         * common/common-regcache.h: Rename include guard.
6561         * common/common-inferior.h: Rename include guard.
6562         * common/common-gdbthread.h: Rename include guard.
6563         * common/common-exceptions.h: Rename include guard.
6564         * common/common-defs.h: Rename include guard.
6565         * common/common-debug.h: Rename include guard.
6566         * common/cleanups.h: Rename include guard.
6567         * common/buffer.h: Rename include guard.
6568         * common/btrace-common.h: Rename include guard.
6569         * common/break-common.h: Rename include guard.
6570         * cli/cli-utils.h: Rename include guard.
6571         * cli/cli-style.h: Rename include guard.
6572         * cli/cli-setshow.h: Rename include guard.
6573         * cli/cli-script.h: Rename include guard.
6574         * cli/cli-interp.h: Rename include guard.
6575         * cli/cli-decode.h: Rename include guard.
6576         * cli/cli-cmds.h: Rename include guard.
6577         * charset-list.h: Add include guard.
6578         * buildsym-legacy.h: Rename include guard.
6579         * bfin-tdep.h: Add include guard.
6580         * ax.h: Rename include guard.
6581         * arm-linux-tdep.h: Add include guard.
6582         * arm-fbsd-tdep.h: Add include guard.
6583         * arch/xtensa.h: Rename include guard.
6584         * arch/tic6x.h: Add include guard.
6585         * arch/i386.h: Add include guard.
6586         * arch/arm.h: Rename include guard.
6587         * arch/arm-linux.h: Rename include guard.
6588         * arch/arm-get-next-pcs.h: Rename include guard.
6589         * arch/amd64.h: Add include guard.
6590         * arch/aarch64-insn.h: Rename include guard.
6591         * arch-utils.h: Rename include guard.
6592         * annotate.h: Add include guard.
6593         * amd64-darwin-tdep.h: Rename include guard.
6594         * aarch64-linux-tdep.h: Add include guard.
6595         * aarch64-fbsd-tdep.h: Add include guard.
6596         * aarch32-linux-nat.h: Add include guard.
6597
6598 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6599
6600         * macrotab.c (macro_define_internal): New function that
6601         factorizes macro_define_object_internal and macro_define_function
6602         code.
6603         (macro_define_object_internal): Use macro_define_internal.
6604         (macro_define_function): Likewise.
6605
6606 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6607
6608         * macrocmd.c (extract_identifier): Return
6609         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6610         callers.
6611
6612 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6613
6614         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6615
6616 2019-02-05  Tom Tromey  <tom@tromey.com>
6617
6618         * target.c (target_stack::unpush): Move assertion earlier.
6619
6620 2019-01-30  Tom Tromey  <tom@tromey.com>
6621
6622         PR python/23615:
6623         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6624         (gdbpy_parse_and_eval): Likewise.
6625         * python/python-internal.h (gdbpy_allow_threads): New class.
6626
6627 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6628
6629         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6630         (aarch64_fbsd_fpregmap): Move earlier.
6631         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6632         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6633         instead of individual calls to trad_frame_set_reg_addr.
6634         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6635         earlier.
6636         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6637         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6638         instead of individual calls to trad_frame_set_reg_addr.
6639
6640 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6641
6642         * CONTRIBUTE: Replace contribution list with wiki link.
6643
6644 2019-01-25  Tom Tromey  <tom@tromey.com>
6645
6646         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6647
6648 2019-01-25  Tom Tromey  <tom@tromey.com>
6649
6650         * xtensa-linux-nat.c: Fix common/ includes.
6651         * xml-support.h: Fix common/ includes.
6652         * xml-support.c: Fix common/ includes.
6653         * x86-linux-nat.c: Fix common/ includes.
6654         * windows-nat.c: Fix common/ includes.
6655         * varobj.h: Fix common/ includes.
6656         * varobj.c: Fix common/ includes.
6657         * value.c: Fix common/ includes.
6658         * valops.c: Fix common/ includes.
6659         * utils.c: Fix common/ includes.
6660         * unittests/xml-utils-selftests.c: Fix common/ includes.
6661         * unittests/utils-selftests.c: Fix common/ includes.
6662         * unittests/unpack-selftests.c: Fix common/ includes.
6663         * unittests/tracepoint-selftests.c: Fix common/ includes.
6664         * unittests/style-selftests.c: Fix common/ includes.
6665         * unittests/string_view-selftests.c: Fix common/ includes.
6666         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6667         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6668         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6669         * unittests/rsp-low-selftests.c: Fix common/ includes.
6670         * unittests/parse-connection-spec-selftests.c: Fix common/
6671         includes.
6672         * unittests/optional-selftests.c: Fix common/ includes.
6673         * unittests/offset-type-selftests.c: Fix common/ includes.
6674         * unittests/observable-selftests.c: Fix common/ includes.
6675         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6676         * unittests/memrange-selftests.c: Fix common/ includes.
6677         * unittests/memory-map-selftests.c: Fix common/ includes.
6678         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6679         * unittests/function-view-selftests.c: Fix common/ includes.
6680         * unittests/environ-selftests.c: Fix common/ includes.
6681         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6682         * unittests/common-utils-selftests.c: Fix common/ includes.
6683         * unittests/cli-utils-selftests.c: Fix common/ includes.
6684         * unittests/array-view-selftests.c: Fix common/ includes.
6685         * ui-file.c: Fix common/ includes.
6686         * tui/tui-io.c: Fix common/ includes.
6687         * tracepoint.h: Fix common/ includes.
6688         * tracepoint.c: Fix common/ includes.
6689         * tracefile-tfile.c: Fix common/ includes.
6690         * top.h: Fix common/ includes.
6691         * top.c: Fix common/ includes.
6692         * thread.c: Fix common/ includes.
6693         * target/waitstatus.h: Fix common/ includes.
6694         * target/waitstatus.c: Fix common/ includes.
6695         * target.h: Fix common/ includes.
6696         * target.c: Fix common/ includes.
6697         * target-memory.c: Fix common/ includes.
6698         * target-descriptions.c: Fix common/ includes.
6699         * symtab.h: Fix common/ includes.
6700         * symfile.c: Fix common/ includes.
6701         * stap-probe.c: Fix common/ includes.
6702         * spu-linux-nat.c: Fix common/ includes.
6703         * sparc-nat.c: Fix common/ includes.
6704         * source.c: Fix common/ includes.
6705         * solib.c: Fix common/ includes.
6706         * solib-target.c: Fix common/ includes.
6707         * ser-unix.c: Fix common/ includes.
6708         * ser-tcp.c: Fix common/ includes.
6709         * ser-pipe.c: Fix common/ includes.
6710         * ser-base.c: Fix common/ includes.
6711         * selftest-arch.c: Fix common/ includes.
6712         * s12z-tdep.c: Fix common/ includes.
6713         * rust-exp.y: Fix common/ includes.
6714         * rs6000-aix-tdep.c: Fix common/ includes.
6715         * riscv-tdep.c: Fix common/ includes.
6716         * remote.c: Fix common/ includes.
6717         * remote-notif.h: Fix common/ includes.
6718         * remote-fileio.h: Fix common/ includes.
6719         * remote-fileio.c: Fix common/ includes.
6720         * regcache.h: Fix common/ includes.
6721         * regcache.c: Fix common/ includes.
6722         * record-btrace.c: Fix common/ includes.
6723         * python/python.c: Fix common/ includes.
6724         * python/py-type.c: Fix common/ includes.
6725         * python/py-inferior.c: Fix common/ includes.
6726         * progspace.h: Fix common/ includes.
6727         * producer.c: Fix common/ includes.
6728         * procfs.c: Fix common/ includes.
6729         * proc-api.c: Fix common/ includes.
6730         * printcmd.c: Fix common/ includes.
6731         * ppc-linux-nat.c: Fix common/ includes.
6732         * parser-defs.h: Fix common/ includes.
6733         * osdata.c: Fix common/ includes.
6734         * obsd-nat.c: Fix common/ includes.
6735         * nat/x86-linux.c: Fix common/ includes.
6736         * nat/x86-linux-dregs.c: Fix common/ includes.
6737         * nat/x86-dregs.h: Fix common/ includes.
6738         * nat/x86-dregs.c: Fix common/ includes.
6739         * nat/ppc-linux.c: Fix common/ includes.
6740         * nat/mips-linux-watch.h: Fix common/ includes.
6741         * nat/mips-linux-watch.c: Fix common/ includes.
6742         * nat/linux-waitpid.c: Fix common/ includes.
6743         * nat/linux-ptrace.h: Fix common/ includes.
6744         * nat/linux-ptrace.c: Fix common/ includes.
6745         * nat/linux-procfs.c: Fix common/ includes.
6746         * nat/linux-personality.c: Fix common/ includes.
6747         * nat/linux-osdata.c: Fix common/ includes.
6748         * nat/linux-namespaces.c: Fix common/ includes.
6749         * nat/linux-btrace.h: Fix common/ includes.
6750         * nat/linux-btrace.c: Fix common/ includes.
6751         * nat/fork-inferior.c: Fix common/ includes.
6752         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6753         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6754         * nat/aarch64-linux.c: Fix common/ includes.
6755         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6756         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6757         * namespace.h: Fix common/ includes.
6758         * mips-linux-tdep.c: Fix common/ includes.
6759         * minsyms.c: Fix common/ includes.
6760         * mi/mi-parse.h: Fix common/ includes.
6761         * mi/mi-main.c: Fix common/ includes.
6762         * mi/mi-cmd-env.c: Fix common/ includes.
6763         * memrange.h: Fix common/ includes.
6764         * memattr.c: Fix common/ includes.
6765         * maint.h: Fix common/ includes.
6766         * maint.c: Fix common/ includes.
6767         * main.c: Fix common/ includes.
6768         * machoread.c: Fix common/ includes.
6769         * location.c: Fix common/ includes.
6770         * linux-thread-db.c: Fix common/ includes.
6771         * linux-nat.c: Fix common/ includes.
6772         * linux-fork.c: Fix common/ includes.
6773         * inline-frame.c: Fix common/ includes.
6774         * infrun.c: Fix common/ includes.
6775         * inflow.c: Fix common/ includes.
6776         * inferior.h: Fix common/ includes.
6777         * inferior.c: Fix common/ includes.
6778         * infcmd.c: Fix common/ includes.
6779         * inf-ptrace.c: Fix common/ includes.
6780         * inf-child.c: Fix common/ includes.
6781         * ia64-linux-nat.c: Fix common/ includes.
6782         * i387-tdep.c: Fix common/ includes.
6783         * i386-tdep.c: Fix common/ includes.
6784         * i386-linux-tdep.c: Fix common/ includes.
6785         * i386-linux-nat.c: Fix common/ includes.
6786         * i386-go32-tdep.c: Fix common/ includes.
6787         * i386-fbsd-tdep.c: Fix common/ includes.
6788         * i386-fbsd-nat.c: Fix common/ includes.
6789         * guile/scm-type.c: Fix common/ includes.
6790         * guile/guile.c: Fix common/ includes.
6791         * go32-nat.c: Fix common/ includes.
6792         * gnu-nat.c: Fix common/ includes.
6793         * gdbthread.h: Fix common/ includes.
6794         * gdbarch-selftests.c: Fix common/ includes.
6795         * gdb_usleep.c: Fix common/ includes.
6796         * gdb_select.h: Fix common/ includes.
6797         * gdb_bfd.c: Fix common/ includes.
6798         * gcore.c: Fix common/ includes.
6799         * fork-child.c: Fix common/ includes.
6800         * findvar.c: Fix common/ includes.
6801         * fbsd-nat.c: Fix common/ includes.
6802         * event-top.c: Fix common/ includes.
6803         * event-loop.c: Fix common/ includes.
6804         * dwarf2read.c: Fix common/ includes.
6805         * dwarf2loc.c: Fix common/ includes.
6806         * dwarf2-frame.c: Fix common/ includes.
6807         * dwarf-index-cache.c: Fix common/ includes.
6808         * dtrace-probe.c: Fix common/ includes.
6809         * disasm-selftests.c: Fix common/ includes.
6810         * defs.h: Fix common/ includes.
6811         * csky-tdep.c: Fix common/ includes.
6812         * cp-valprint.c: Fix common/ includes.
6813         * cp-support.h: Fix common/ includes.
6814         * cp-support.c: Fix common/ includes.
6815         * corelow.c: Fix common/ includes.
6816         * completer.h: Fix common/ includes.
6817         * completer.c: Fix common/ includes.
6818         * compile/compile.c: Fix common/ includes.
6819         * compile/compile-loc2c.c: Fix common/ includes.
6820         * compile/compile-cplus-types.c: Fix common/ includes.
6821         * compile/compile-cplus-symbols.c: Fix common/ includes.
6822         * command.h: Fix common/ includes.
6823         * cli/cli-dump.c: Fix common/ includes.
6824         * cli/cli-cmds.c: Fix common/ includes.
6825         * charset.c: Fix common/ includes.
6826         * build-id.c: Fix common/ includes.
6827         * btrace.h: Fix common/ includes.
6828         * btrace.c: Fix common/ includes.
6829         * breakpoint.h: Fix common/ includes.
6830         * breakpoint.c: Fix common/ includes.
6831         * ax.h:
6832         (enum agent_op): Fix common/ includes.
6833         * ax-general.c (struct aop_map): Fix common/ includes.
6834         * ax-gdb.c: Fix common/ includes.
6835         * auxv.c: Fix common/ includes.
6836         * auto-load.c: Fix common/ includes.
6837         * arm-tdep.c: Fix common/ includes.
6838         * arch/riscv.c: Fix common/ includes.
6839         * arch/ppc-linux-common.c: Fix common/ includes.
6840         * arch/i386.c: Fix common/ includes.
6841         * arch/arm.c: Fix common/ includes.
6842         * arch/arm-linux.c: Fix common/ includes.
6843         * arch/arm-get-next-pcs.c: Fix common/ includes.
6844         * arch/amd64.c: Fix common/ includes.
6845         * arch/aarch64.c: Fix common/ includes.
6846         * arch/aarch64-insn.c: Fix common/ includes.
6847         * arch-utils.c: Fix common/ includes.
6848         * amd64-windows-tdep.c: Fix common/ includes.
6849         * amd64-tdep.c: Fix common/ includes.
6850         * amd64-sol2-tdep.c: Fix common/ includes.
6851         * amd64-obsd-tdep.c: Fix common/ includes.
6852         * amd64-nbsd-tdep.c: Fix common/ includes.
6853         * amd64-linux-tdep.c: Fix common/ includes.
6854         * amd64-linux-nat.c: Fix common/ includes.
6855         * amd64-fbsd-tdep.c: Fix common/ includes.
6856         * amd64-fbsd-nat.c: Fix common/ includes.
6857         * amd64-dicos-tdep.c: Fix common/ includes.
6858         * amd64-darwin-tdep.c: Fix common/ includes.
6859         * agent.c: Fix common/ includes.
6860         * ada-lang.h: Fix common/ includes.
6861         * ada-lang.c: Fix common/ includes.
6862         * aarch64-tdep.c: Fix common/ includes.
6863
6864 2019-01-25  Tom Tromey  <tom@tromey.com>
6865
6866         * common/create-version.sh: Use common/version.h.
6867
6868 2019-01-24  Pedro Alves  <palves@redhat.com>
6869
6870         * infrun.c (signal_stop, signal_print, signal_program)
6871         (signal_catch, signal_pass): Now arrays instead of pointers.
6872         (update_signals_program_target, do_target_resume)
6873         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6874         * linux-nat.c (linux_nat_target::pass_signals)
6875         (linux_nat_target::create_inferior, linux_nat_target::attach):
6876         Adjust.
6877         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6878         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6879         * procfs.c (procfs_target::pass_signals): Adjust.
6880         * record-full.c (record_full_target::resume): Adjust.
6881         * remote.c (remote_target::pass_signals)
6882         (remote_target::program_signals): Adjust.
6883         * target-debug.h (target_debug_print_signals): Now takes a
6884         gdb::array_view as parameter.  Adjust.
6885         * target.h (target_ops) <pass_signals, program_signals>: Replace
6886         pointer and length parameters with gdb::array_view.
6887         (target_pass_signals, target_program_signals): Likewise.
6888         * target-delegates.c: Regenerate.
6889
6890 2019-01-24  Pedro Alves  <palves@redhat.com>
6891
6892         * common/forward-scope-exit.h
6893         (forward_scope_exit::forward_scope_exit): Pass arguments to
6894         m_bind_function directly, instead of creating a std::bind and
6895         copying that.
6896
6897 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6898
6899         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6900         for static members.
6901         (pass_in_v_vfp_candidate): Likewise.
6902
6903 2019-01-23  Tom Tromey  <tom@tromey.com>
6904             Pedro Alves  <palves@redhat.com>
6905
6906         * regcache.c (class regcache_invalidator): Remove.
6907         (regcache::raw_write): Use make_scope_exit.
6908
6909 2019-01-23  Tom Tromey  <tom@tromey.com>
6910
6911         * ui-out.h (class ui_out_emit_type): Update comment.
6912
6913 2019-01-23  Tom Tromey  <tom@tromey.com>
6914
6915         * infrun.c (fetch_inferior_event): Update comment.
6916
6917 2019-01-23  Tom Tromey  <tom@tromey.com>
6918             Pedro Alves  <palves@redhat.com>
6919
6920         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6921         parameter.
6922         (fetch_inferior_event): Use SCOPE_EXIT.
6923
6924
6925 2019-01-23  Tom Tromey  <tom@tromey.com>
6926             Pedro Alves  <palves@redhat.com>
6927
6928         * infrun.c (disable_thread_events): Delete.
6929         (stop_all_threads): Use SCOPE_EXIT.
6930
6931 2019-01-23  Tom Tromey  <tom@tromey.com>
6932             Pedro Alves  <palves@redhat.com>
6933
6934         * symfile.c: Include forward-scope-exit.h.
6935         (clear_symtab_users_cleanup): Replace forward declaration with
6936         a FORWARD_SCOPE_EXIT.
6937         (syms_from_objfile_1): Use the forward_scope_exit and
6938         gdb::optional instead of cleanup_function.
6939         (reread_symbols): Use the forward_scope_exit instead of
6940         cleanup_function.
6941         (clear_symtab_users_cleanup): Remove function.
6942
6943 2019-01-23  Tom Tromey  <tom@tromey.com>
6944             Pedro Alves  <palves@redhat.com>
6945
6946         * linux-nat.c: Include scope-exit.h.
6947         (cleanup_target_stop): Remove.
6948         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6949         SCOPE_EXIT.
6950
6951 2019-01-23  Tom Tromey  <tom@tromey.com>
6952             Pedro Alves  <palves@redhat.com>
6953
6954         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6955         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6956
6957 2019-01-23  Tom Tromey  <tom@tromey.com>
6958             Andrew Burgess  <andrew.burgess@embecosm.com>
6959             Pedro Alves  <palves@redhat.com>
6960
6961         * infrun.c (fetch_inferior_event): Use scope_exit.
6962         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6963         * top.c (execute_command): Use scope_exit.
6964         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6965         * utils.c (do_bpstat_clear_actions_cleanup)
6966         (make_bpstat_clear_actions_cleanup): Remove.
6967
6968 2019-01-23  Tom Tromey  <tom@tromey.com>
6969             Pedro Alves  <palves@redhat.com>
6970
6971         * infrun.c: Include "common/scope-exit.h"
6972         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6973         (wait_for_inferior): Use SCOPE_EXIT.
6974         (fetch_inferior_event): Use scope_exit.
6975
6976 2019-01-23  Tom Tromey  <tom@tromey.com>
6977             Pedro Alves  <palves@redhat.com>
6978
6979         * breakpoint.c (create_breakpoint): Remove cleanup.
6980
6981 2019-01-23  Tom Tromey  <tom@tromey.com>
6982             Andrew Burgess  <andrew.burgess@embecosm.com>
6983             Pedro Alves  <palves@redhat.com>
6984
6985 2019-01-23  Pedro Alves  <palves@redhat.com>
6986
6987         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6988
6989 2019-01-23  Pedro Alves  <palves@redhat.com>
6990             Andrew Burgess  <andrew.burgess@embecosm.com>
6991
6992         * gdbthread.h: Include "common/forward-scope-exit.h".
6993         (scoped_finish_thread_state): Redefine custom class in terms of
6994         forward_scope_exit.
6995
6996 2019-01-23  Pedro Alves  <palves@redhat.com>
6997             Andrew Burgess  <andrew.burgess@embecosm.com>
6998
6999         * common/forward-scope-exit.h: New file.
7000
7001 2019-01-23  Pedro Alves  <palves@redhat.com>
7002             Andrew Burgess  <andrew.burgess@embecosm.com>
7003             Tom Tromey  <tom@tromey.com>
7004
7005         * common/scope-exit.h: New file.
7006
7007 2019-01-23  Pedro Alves  <palves@redhat.com>
7008
7009         * common/preprocessor.h (ESC): Rename to ...
7010         (ESC_PARENS): ... this.
7011         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7012         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7013
7014 2019-01-23  Tom Tromey  <tom@tromey.com>
7015
7016         * language.h (class scoped_switch_to_sym_language_if_auto):
7017         Initialize m_lang in both cases.
7018
7019 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7020
7021         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7022         with XCNEW.
7023
7024 2019-01-22  Tom Tromey  <tom@tromey.com>
7025
7026         * corelow.c: Do not include sys/file.h.
7027
7028 2019-01-22  Tom Tromey  <tom@tromey.com>
7029
7030         * tui/tui-wingeneral.h: Include gdb_curses.h.
7031
7032 2019-01-22  Tom Tromey  <tom@tromey.com>
7033
7034         * source-cache.h (class source_cache) <get_source_lines,
7035         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7036
7037 2019-01-22  Tom Tromey  <tom@tromey.com>
7038
7039         * remote-fileio.h (struct remote_target): Declare.
7040
7041 2019-01-22  Tom Tromey  <tom@tromey.com>
7042
7043         * python/py-arch.c: Do not include py-ref.h.
7044         * python/py-bpevent.c: Do not include py-ref.h.
7045         * python/py-cmd.c: Do not include py-ref.h.
7046         * python/py-continueevent.c: Do not include py-ref.h.
7047         * python/py-event.h: Do not include py-ref.h.
7048         * python/py-evtregistry.c: Do not include py-ref.h.
7049         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7050         * python/py-frame.c: Do not include py-ref.h.
7051         * python/py-framefilter.c: Do not include py-ref.h.
7052         * python/py-function.c: Do not include py-ref.h.
7053         * python/py-infevents.c: Do not include py-ref.h.
7054         * python/py-linetable.c: Do not include py-ref.h.
7055         * python/py-objfile.c: Do not include py-ref.h.
7056         * python/py-param.c: Do not include py-ref.h.
7057         * python/py-prettyprint.c: Do not include py-ref.h.
7058         * python/py-progspace.c: Do not include py-ref.h.
7059         * python/py-symbol.c: Do not include py-ref.h.
7060         * python/py-symtab.c: Do not include py-ref.h.
7061         * python/py-type.c: Do not include py-ref.h.
7062         * python/py-unwind.c: Do not include py-ref.h.
7063         * python/py-utils.c: Do not include py-ref.h.
7064         * python/py-value.c: Do not include py-ref.h.
7065         * python/py-varobj.c: Do not include py-ref.h.
7066         * python/py-xmethods.c: Do not include py-ref.h.
7067         * python/python.c: Do not include py-ref.h.
7068         * varobj.c: Do not include py-ref.h.
7069
7070 2019-01-22  Tom Tromey  <tom@tromey.com>
7071
7072         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7073         keyword for bcache.
7074
7075 2019-01-22  Tom Tromey  <tom@tromey.com>
7076
7077         * compile/compile-cplus-types.c: Remove a comment by #include.
7078
7079 2019-01-22  Tom Tromey  <tom@tromey.com>
7080
7081         * compile/gcc-c-plugin.h: Include compile-internal.h.
7082
7083 2019-01-22  Tom Tromey  <tom@tromey.com>
7084
7085         * stabsread.c (EXTERN): Do not define.
7086         (symnum, next_symbol_text_func, processing_gcc_compilation)
7087         (within_function, global_sym_chain, global_stabs)
7088         (previous_stab_code, this_object_header_files)
7089         (n_this_object_header_files)
7090         (n_allocated_this_object_header_files): Define.
7091         * stabsread.h (EXTERN): Never define.  Use "extern".
7092
7093 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7094
7095         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7096         history_value.
7097
7098 2019-01-21  Tom Tromey  <tom@tromey.com>
7099
7100         * ui-out.c: Fix includes.
7101         * tui/tui-source.c: Fix includes.
7102         * target.c: Fix includes.
7103         * remote.c: Fix includes.
7104         * regcache.c: Fix includes.
7105         * python/py-block.c: Fix includes.
7106         * printcmd.c: Fix includes.
7107         * or1k-tdep.c: Fix includes.
7108         * mi/mi-main.c: Fix includes.
7109         * m32r-tdep.c: Fix includes.
7110         * csky-tdep.c: Fix includes.
7111         * compile/compile-cplus-types.c: Fix includes.
7112         * cli/cli-interp.c: Fix includes.
7113
7114 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7115
7116         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7117         for padding.
7118
7119 2019-01-16  Tom Tromey  <tom@tromey.com>
7120
7121         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7122         earlier.
7123         (struct objfile) <msymbols_range>: Move from top level.
7124         <msymbols>: New method.
7125         (class objfile_msymbols): Remove.
7126         * symtab.c (default_collect_symbol_completion_matches_break_on):
7127         Update.
7128         * symmisc.c (dump_msymbols): Update.
7129         * stabsread.c (scan_file_globals): Update.
7130         * objc-lang.c (info_selectors_command, info_classes_command)
7131         (find_methods): Update.
7132         * minsyms.c (find_solib_trampoline_target): Update.
7133         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7134         * coffread.c (coff_symfile_read): Update.
7135         * ada-lang.c (ada_lookup_simple_minsym)
7136         (ada_collect_symbol_completion_matches): Update.
7137
7138 2019-01-16  Tom Tromey  <tom@tromey.com>
7139
7140         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7141         type.  Remove no-argument constructor.
7142         <iterator::operator++>: Simplify.
7143         <begin>: Update.
7144         <end>: Use minimal_symbol_count.
7145
7146 2019-01-16  Tom Tromey  <tom@tromey.com>
7147
7148         * objfiles.h (struct objfile) <psymtabs>: New method.
7149         (class objfile_psymtabs): Remove.
7150         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7151         typedef.
7152         <range>: New method.
7153         (require_partial_symbols): Change return type.
7154         * psymtab.c (require_partial_symbols)
7155         (psym_expand_symtabs_matching): Update.
7156         * mdebugread.c (parse_partial_symbols): Update.
7157         * dbxread.c (dbx_end_psymtab): Update.
7158
7159 2019-01-15  Tom Tromey  <tom@tromey.com>
7160
7161         * symtab.c (lookup_objfile_from_block)
7162         (lookup_symbol_in_objfile_symtabs)
7163         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7164         (find_line_symtab, info_sources_command)
7165         (default_collect_symbol_completion_matches_break_on)
7166         (make_source_files_completion_list): Update.
7167         * symmisc.c (print_objfile_statistics, dump_objfile)
7168         (maintenance_print_symbols, maintenance_info_symtabs)
7169         (maintenance_check_symtabs, maintenance_info_line_tables):
7170         Update.
7171         * source.c (select_source_symtab)
7172         (forget_cached_source_info_for_objfile): Update.
7173         * objfiles.h (class objfile_compunits): Remove.
7174         (struct objfile) <compunits_range>: New typedef.
7175         (compunits): New method.
7176         * objfiles.c (objfile_relocate1): Update.
7177         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7178         * maint.c (count_symtabs_and_blocks): Update.
7179         * linespec.c (iterate_over_all_matching_symtabs): Update.
7180         * cp-support.c (add_symbol_overload_list_qualified): Update.
7181         * coffread.c (coff_symtab_read): Update.
7182         * ada-lang.c (add_nonlocal_symbols)
7183         (ada_collect_symbol_completion_matches)
7184         (ada_add_global_exceptions): Update.
7185
7186 2019-01-15  Tom Tromey  <tom@tromey.com>
7187
7188         * progspace.h (program_space) <objfiles_safe_range>: New
7189         typedef.
7190         <objfiles_safe>: New method.
7191         * objfiles.h (class all_objfiles_safe): Remove.
7192         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7193         * jit.c (jit_inferior_exit_hook): Update.
7194
7195 2019-01-17  Tom Tromey  <tom@tromey.com>
7196
7197         * progspace.h (program_space) <objfiles_range>: New typedef.
7198         <objfiles>: New method.
7199         <objfiles_head>: Rename from objfiles.
7200         (object_files): Update.
7201         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7202         * guile/scm-pretty-print.c
7203         (ppscm_find_pretty_printer_from_objfiles): Update.
7204         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7205         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7206         Update.
7207         * python/py-progspace.c (pspy_get_objfiles): Update.
7208         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7209         Update.
7210         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7211         (objfpy_lookup_objfile_by_build_id): Update.
7212         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7213         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7214         Update.
7215         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7216         (expand_symtab_containing_pc, lookup_objfile_from_block)
7217         (lookup_static_symbol, basic_lookup_transparent_type)
7218         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7219         (find_line_symtab, info_sources_command)
7220         (default_collect_symbol_completion_matches_break_on)
7221         (make_source_files_completion_list, find_main_name): Update.
7222         * symmisc.c (print_symbol_bcache_statistics)
7223         (print_objfile_statistics, maintenance_print_symbols)
7224         (maintenance_print_msymbols, maintenance_print_objfiles)
7225         (maintenance_info_symtabs, maintenance_check_symtabs)
7226         (maintenance_expand_symtabs, maintenance_info_line_tables):
7227         Update.
7228         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7229         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7230         (map_overlay_command, unmap_overlay_command)
7231         (simple_overlay_update, expand_symtabs_matching)
7232         (map_symbol_filenames): Update.
7233         * symfile-debug.c (set_debug_symfile): Update.
7234         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7235         Update.
7236         * source.c (select_source_symtab, forget_cached_source_info):
7237         Update.
7238         * solib.c (solib_read_symbols): Update.
7239         * solib-spu.c (append_ocl_sos): Update.
7240         * psymtab.c (maintenance_print_psymbols)
7241         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7242         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7243         * printcmd.c (info_symbol_command): Update.
7244         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7245         Update.
7246         * objfiles.h (class all_objfiles): Remove.
7247         * objfiles.c (have_partial_symbols, have_full_symbols)
7248         (have_minimal_symbols, qsort_cmp, update_section_map)
7249         (shared_objfile_contains_address_p)
7250         (default_iterate_over_objfiles_in_search_order): Update.
7251         * objc-lang.c (info_selectors_command, info_classes_command)
7252         (find_methods): Update.
7253         * minsyms.c (find_solib_trampoline_target): Update.
7254         * maint.c (maintenance_info_sections)
7255         (maintenance_translate_address, count_symtabs_and_blocks):
7256         Update.
7257         * main.c (captured_main_1): Update.
7258         * linux-thread-db.c (try_thread_db_load_from_pdir)
7259         (has_libpthread): Update.
7260         * linespec.c (iterate_over_all_matching_symtabs)
7261         (search_minsyms_for_name): Update.
7262         * jit.c (jit_find_objf_with_entry_addr): Update.
7263         * hppa-tdep.c (find_unwind_entry)
7264         (hppa_lookup_stub_minimal_symbol): Update.
7265         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7266         Update.
7267         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7268         (elf_gnu_ifunc_resolve_by_got): Update.
7269         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7270         * dwarf-index-write.c (save_gdb_index_command): Update.
7271         * cp-support.c (add_symbol_overload_list_qualified): Update.
7272         * breakpoint.c (create_overlay_event_breakpoint)
7273         (create_longjmp_master_breakpoint)
7274         (create_std_terminate_master_breakpoint)
7275         (create_exception_master_breakpoint): Update.
7276         * blockframe.c (find_pc_partial_function): Update.
7277         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7278         (ada_collect_symbol_completion_matches)
7279         (ada_add_global_exceptions): Update.
7280
7281 2019-01-17  Tom Tromey  <tom@tromey.com>
7282
7283         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7284         declare VEC.
7285         (solib_target_parse_libraries): Change return type.
7286         (library_list_start_segment, library_list_start_section)
7287         (library_list_end_library, library_list_start_library); Update.
7288         (solib_target_free_library_list): Remove.
7289         (solib_target_parse_libraries): Remove cleanup.  Change return
7290         type.
7291         (solib_target_current_sos): Update.
7292
7293 2019-01-17  Tom Tromey  <tromey@bapiya>
7294
7295         * valprint.c: Replace "the the" with "the".
7296         * symtab.c: Replace "the the" with "the".
7297         * solib.c: Replace "the the" with "the".
7298         * solib-dsbt.c: Replace "the the" with "the".
7299         * linespec.c: Replace "the the" with "the".
7300         * dwarf2loc.h: Replace "the the" with "the".
7301         * amd64-windows-tdep.c: Replace "the the" with "the".
7302         * aarch64-tdep.c: Replace "the the" with "the".
7303
7304 2019-01-16  Keith Seitz  <keiths@redhat.com>
7305
7306         PR gdb/23773
7307         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7308         <builder>: Rename to ..
7309         <m_builder>: ... this and make private.
7310         (dwarf2_cu::get_builder): New method.  Change all users of
7311         `builder' to use this method.
7312         (dwarf2_start_symtab): Move to ...
7313         (dwarf2_cu::start_symtab): ... here.  Update all callers
7314         (setup_type_unit_groups): Move to ...
7315         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7316         callers.
7317         (dwarf2_cu::reset_builder): New method.
7318         (process_full_compunit, process_full_type_unit): Use
7319         dwarf2_cu::reset_builder.
7320         (follow_die_offset): Record the ancestor CU if it is different
7321         from the followed DIE's CU.
7322         (follow_die_sig_1): Likewise.
7323
7324 2019-01-15  Tom Tromey  <tom@tromey.com>
7325
7326         * remote.c (class remote_state) <buf>: Now a char_vector.
7327         <buf_size>: Remove.
7328         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7329         parameter.
7330         (remote_target::getpkt_or_notif_sane_1)
7331         (remote_target::getpkt_sane)
7332         (remote_target::getpkt_or_notif_sane): Likewise.
7333         (class remote_target) <putpkt>: New overload.
7334         (remote_target::read_frame): Change type of "buf_p".  Remove
7335         sizeof_p parameter.
7336         (packet_ok): New overload.
7337         (packet_check_result): New overload.
7338         Update all uses.
7339
7340 2019-01-14  Tom Tromey  <tom@tromey.com>
7341
7342         * remote-notif.c (handle_notification, remote_notif_ack)
7343         (remote_notif_parse): Make "buf" const.
7344         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7345         const.
7346         (remote_notif_parse, remote_notif_ack, handle_notification):
7347         Likewise.
7348         * remote.c (remote_notif_stop_parse): Make "buf" const.
7349         (remote_target::remote_parse_stop_reply): Make "buf" const.
7350         (remote_notif_stop_ack): Make "buf" const.
7351
7352 2019-01-14  Tom Tromey  <tom@tromey.com>
7353
7354         * remote.c (remote_console_output): Make parameter const.
7355
7356 2019-01-14  Tom Tromey  <tom@tromey.com>
7357
7358         * target-debug.h (target_debug_print_signals): Constify.
7359         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7360         * procfs.c (procfs_target::pass_signals): Update.
7361         * linux-nat.c (linux_nat_target::pass_signals): Update.
7362         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7363         * target-delegates.c: Rebuild.
7364         * remote.c (remote_target::program_signals): Update.
7365         (remote_target::pass_signals): Update.
7366         * target.c (target_pass_signals): Constify argument.
7367         (target_program_signals): Likewise.
7368         * target.h (struct target_ops) <pass_signals, program_signals>:
7369         Constify argument.
7370         (target_pass_signals, target_program_signals): Constify argument.
7371
7372 2019-01-14  Tom Tromey  <tom@tromey.com>
7373
7374         PR tui/28819:
7375         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7376
7377 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7378
7379         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7380         field.
7381         * rs6000-tdep.c: Include reggroups.h.
7382         (IS_V_ALIAS_PSEUDOREG): Define.
7383         (rs6000_register_name): Return names for the "vX" aliases.
7384         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7385         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7386         aliases.  Call default_register_reggroup_p for all other
7387         pseudo-registers.
7388         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7389         New functions.
7390         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7391         Handle "vX" aliases.
7392         (v_alias_pseudo_register_collect): New function.
7393         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7394         (rs6000_gdbarch_init): Initialize "vX" aliases as
7395         pseudo-registers.  Restore registration of
7396         rs6000_pseudo_register_reggroup_p with
7397         set_tdesc_pseudo_register_reggroup_p.
7398
7399 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7400
7401         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7402         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7403         set_gdbarch_num_pseudo_regs.
7404
7405 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7406
7407         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7408         Remove arg prefixname, add do_set and do_show.
7409         Add member functions set_list and show_list.
7410         * cli/cli-style.c (class cli_style_option): Update accordingly.
7411         (style_set_list): Move to file scope.
7412         (style_show_list): Likewise.
7413         (set_style): Call help_list.
7414         (show_style): Call cmd_show_list.
7415         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7416         Update to use the new macro.
7417
7418 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7419
7420         * ada-lang.c (_initialize_ada_language): Expand the help text
7421         for the "catch exception" command.
7422
7423 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7424
7425         * symtab.c (matching_obj_sections): Initialize obj,
7426         declare it closer to its usage.
7427
7428 2019-01-10  Tom Tromey  <tom@tromey.com>
7429
7430         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7431         (basic_inf_threads_range): Remove.
7432         (inf_threads_range, inf_non_exited_threads_range)
7433         (safe_inf_threads_range): Use next_adapter.
7434
7435 2019-01-10  Keith Seitz  <keiths@redhat.com>
7436
7437         PR gdb/23712
7438         PR symtab/23010
7439         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7440         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7441
7442 2019-01-10  Keith Seitz  <keiths@redhat.com>
7443
7444         PR gdb/23712
7445         PR symtab/23010
7446         * dictionary.c (pending_to_vector): Remove.
7447         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7448         Remove _1 suffix, replacing functions of the same name.  Update
7449         all callers.
7450         (dict_create_hashed, dict_create_hashed_expandable)
7451         (dict_create_linear, dict_create_linear_expandable, dict_free)
7452         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7453         Make functions static.
7454
7455 2019-01-10  Keith Seitz  <keiths@redhat.com>
7456
7457         PR gdb/23712
7458         PR symtab/23010
7459         * dictionary.h (struct dictionary): Replace declaration with
7460         multidictionary.
7461         (dict_create_hashed, dict_create_hashed_expandable)
7462         (dict_create_linear, dict_create_linear_expandable)
7463         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7464         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7465         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7466         taking multidictionary argument.
7467         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7468         * block.h (struct block) <dict>: Change to multidictionary
7469         and rename `multidict'.
7470         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7471         symmisc.c: Update all dictionary references to multidictionary.
7472
7473 2019-01-10  Keith Seitz  <keiths@redhat.com>
7474
7475         PR gdb/23712
7476         PR symtab/23010
7477         * dictionary.c: Include unordered_map.
7478         (pending_to_vector): New function.
7479         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7480         Rewrite the non-"_1" functions to take vector instead
7481         of linked list.
7482         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7483         "new" _1 versions of the same name.
7484         (multidictionary): Define.
7485         (std::hash<enum language): New definition.
7486         (collate_pending_symbols_by_language, mdict_create_hashed)
7487         (mdict_create_hashed_expandable, mdict_create_linear)
7488         (mdict_create_linear_expandable, mdict_free)
7489         (find_language_dictionary, create_new_language_dictionary)
7490         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7491         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7492         (mdict_size, mdict_empty): New functions.
7493         * dictionary.h (mdict_iterator): Define.
7494
7495 2019-01-10  Pedro Alves  <palves@redhat.com>
7496
7497         * breakpoint.c (read_uploaded_action)
7498         (create_tracepoint_from_upload): Adjust to use
7499         gdb::unique_xmalloc_ptr.
7500         * ctf.c (ctf_write_uploaded_tp):
7501         (SET_ARRAY_FIELD): Use emplace_back.
7502         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7503         * tracefile-tfile.c (tfile_write_uploaded_tp):
7504         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7505         gdb::unique_xmalloc_ptr.
7506         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7507         at_string, cond_string, cmd_strings>: Replace char pointers
7508         with gdb::unique_xmalloc_ptr.
7509
7510 2019-01-10  Pedro Alves  <palves@redhat.com>
7511
7512         * solib-target.c (library_list_start_library): Don't xstrdup name.
7513
7514 2019-01-10  Pedro Alves  <palves@redhat.com>
7515
7516         * mdebugread.c (parse_partial_symbols): Use
7517         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7518
7519 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7520
7521         * linux-fork.c (scoped_switch_fork_info)
7522         <~scoped_switch_fork_info>: Fix incorrect variable name.
7523
7524 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7525
7526         * linux-fork.c (scoped_switch_fork_info)
7527         <scoped_switch_fork_info>: Make explicit.
7528         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7529
7530 2019-01-10  Tom Tromey  <tom@tromey.com>
7531
7532         * objfiles.h (objfile::reset_psymtabs): Update.
7533         * objfiles.c (objfile::objfile): Update.
7534         * psymtab.h (psymtab_storage::obstack): Update.
7535         (psymtab_storage::m_obstack): Use gdb::optional.
7536         (class psymtab_storage): Update comment.  Remove objfile
7537         parameter.
7538         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7539
7540 2019-01-10  Tom Tromey  <tom@tromey.com>
7541
7542         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7543         <free_psymtabs>: Now private.
7544         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7545         (allocate_psymtab): Use new method.
7546
7547 2019-01-10  Tom Tromey  <tom@tromey.com>
7548
7549         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7550         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7551         * mdebugread.c (parse_partial_symbols): Use
7552         allocate_dependencies.
7553         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7554         allocate_dependencies.
7555         (process_psymtab_comp_unit_reader)
7556         (build_type_psymtab_dependencies): Likewise.
7557         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7558
7559 2019-01-10  Tom Tromey  <tom@tromey.com>
7560
7561         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7562         PSYMBOL_SET_LANGUAGE.
7563         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7564
7565 2019-01-10  Tom Tromey  <tom@tromey.com>
7566
7567         * psymtab.h (psymtab_storage::obstack): New method.
7568         <m_obstack>: Rename from obstack; now private.
7569         * psymtab.c (psymtab_storage): Update.
7570         * dwarf2read.c (create_addrmap_from_index)
7571         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7572         Update.
7573
7574 2019-01-10  Tom Tromey  <tom@tromey.com>
7575
7576         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7577         * objfiles.h (objfile::reset_psymtabs): New method.
7578
7579 2019-01-10  Tom Tromey  <tom@tromey.com>
7580
7581         * symmisc.c (print_symbol_bcache_statistics): Update.
7582         (print_objfile_statistics): Update.
7583         * symfile.c (reread_symbols): Update.
7584         * psymtab.h (class psymtab_storage): New.
7585         * psymtab.c (psymtab_storage): New constructor.
7586         (~psymtab_storage): New destructor.
7587         (require_partial_symbols): Update.
7588         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7589         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7590         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7591         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7592         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7593         (start_psymtab_common, end_psymtab_common)
7594         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7595         (allocate_psymtab): Update.
7596         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7597         Update.
7598         (dump_psymtab_addrmap, maintenance_print_psymbols)
7599         (maintenance_check_psymtabs): Update.
7600         (class objfile_psymtabs): Move to objfiles.h.
7601         * psympriv.h (discard_psymtab): Now inline.
7602         (psymtab_discarder::psymtab_discarder): Update.
7603         (psymtab_discarder::~psymtab_discarder): Update.
7604         (ALL_OBJFILE_PSYMTABS): Rewrite.
7605         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7606         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7607         Remove fields.
7608         <partial_symtabs>: New field.
7609         (class objfile_psymtabs): Move from psymtab.h.  Update.
7610         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7611         psymbol_cache.
7612         (objfile::~objfile): Don't destroy psymbol_cache.
7613         * mdebugread.c (parse_partial_symbols): Update.
7614         * dwarf2read.c (create_addrmap_from_index)
7615         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7616         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7617         (add_partial_subprogram, dwarf2_ranges_read): Update.
7618         * dwarf-index-write.c (write_address_map)
7619         (write_one_signatured_type, recursively_write_psymbols)
7620         (class debug_names, class debug_names, write_psymtabs_to_index):
7621         Update.
7622
7623 2019-01-10  Tom Tromey  <tom@tromey.com>
7624
7625         * symtab.h (SYMBOL_SET_NAMES): Update.
7626         (symbol_set_names): Update.
7627         (MSYMBOL_SET_NAMES): Update.
7628         * symtab.c (symbol_set_names): Change argument to be an
7629         objfile_per_bfd_storage.
7630         * psymtab.c (add_psymbol_to_bcache): Update.
7631         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7632
7633 2019-01-10  Tom Tromey  <tom@tromey.com>
7634
7635         * symtab.c (create_demangled_names_hash): Change argument to be an
7636         objfile_per_bfd_storage.
7637         (symbol_set_names): Update.
7638
7639 2019-01-10  Tom Tromey  <tom@tromey.com>
7640
7641         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7642         init_psymbol_list.
7643         * psymtab.c (init_psymbol_list): Do nothing if already called.
7644         * psympriv.h (init_psymbol_list): Add comment.
7645         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7646         init_psymbol_list.
7647         * dbxread.c (dbx_symfile_read): Unconditionally call
7648         init_psymbol_list.
7649
7650 2019-01-10  Tom Tromey  <tom@tromey.com>
7651
7652         * xcoffread.c (scan_xcoff_symtab): Update.
7653         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7654         "where".
7655         * mdebugread.c (parse_partial_symbols)
7656         (handle_psymbol_enumerators): Update.
7657         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7658         * dbxread.c (read_dbx_symtab): Update.
7659         * psympriv.h (psymbol_placement): New enum.
7660         (add_psymbol_to_list): Update.
7661
7662 2019-01-10  Tom Tromey  <tom@tromey.com>
7663
7664         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7665         static_psymbols parameters.
7666         (scan_xcoff_symtab): Update.
7667         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7668         static_psymbols parameters.
7669         * psympriv.h (start_psymtab_common): Update.
7670         * mdebugread.c (parse_partial_symbols): Update.
7671         * dwarf2read.c (create_partial_symtab): Update.
7672         * dbxread.c (read_dbx_symtab): Update.
7673         (start_psymtab): Remove global_psymbols and static_psymbols
7674         parameters.
7675
7676 2019-01-10  Tom Tromey  <tom@tromey.com>
7677
7678         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7679         * psymtab.c (allocate_psymtab): Add comment.
7680         * psympriv.h (allocate_psymtab): Add comment.
7681         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7682         initializations.
7683         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7684
7685 2019-01-10  Tom Tromey  <tom@tromey.com>
7686
7687         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7688         Don't declare.
7689         * mipsread.c: Include mdebugread.h.
7690         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7691         Declare.
7692         * elfread.c: Include mdebugread.h.
7693
7694 2019-01-09  Tom Tromey  <tom@tromey.com>
7695
7696         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7697         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7698         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7699         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7700         (psym_lookup_symbol, psym_find_last_source_symtab)
7701         (psym_forget_cached_source_info, psym_print_stats)
7702         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7703         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7704         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7705         (psym_find_compunit_symtab_by_address)
7706         (maintenance_print_psymbols, maintenance_info_psymtabs)
7707         (maintenance_check_psymtabs): Use ranged for.
7708         * psymtab.h (class objfile_psymtabs): New.
7709         (require_partial_symbols): Return objfile_psymtabs.
7710         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7711
7712 2019-01-09  Tom Tromey  <tom@tromey.com>
7713
7714         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7715         (find_pc_mapped_section, list_overlays_command)
7716         (map_overlay_command, unmap_overlay_command)
7717         (simple_overlay_update): Use all_objfiles.
7718         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7719         * printcmd.c (info_symbol_command): Use all_objfiles.
7720         * objfiles.h (ALL_OBJSECTIONS): Remove.
7721         * maint.c (maintenance_translate_address): Use all_objfiles.
7722         * gcore.c (gcore_create_callback): Use all_objfiles.
7723         (objfile_find_memory_regions): Likewise.
7724
7725 2019-01-09  Tom Tromey  <tom@tromey.com>
7726
7727         * symtab.c (find_line_symtab, info_sources_command)
7728         (make_source_files_completion_list): Use objfile_compunits.
7729         * source.c (select_source_symtab): Use objfile_compunits.
7730         * objfiles.h (struct objfile): Update comment.
7731         (ALL_OBJFILES): Remove.
7732         (ALL_FILETABS): Remove.
7733         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7734         objfile_compunits.
7735
7736 2019-01-09  Tom Tromey  <tom@tromey.com>
7737
7738         * symmisc.c (print_objfile_statistics, dump_objfile)
7739         (maintenance_print_symbols): Use compunit_filetabs.
7740         * source.c (forget_cached_source_info_for_objfile): Use
7741         compunit_filetabs.
7742         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7743         (ALL_FILETABS): Use compunit_filetabs.
7744         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7745         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7746
7747 2019-01-09  Tom Tromey  <tom@tromey.com>
7748
7749         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7750         (compunit_filetabs): New.
7751         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7752         compunit_filetabs.
7753         (info_sources_command, make_source_files_completion_list): Remove
7754         declaration.
7755         * symmisc.c (print_objfile_statistics, dump_objfile)
7756         (maintenance_print_symbols): Remove declaration.
7757         (maintenance_info_symtabs): Use compunit_filetabs.
7758         (maintenance_info_line_tables): Likewise.
7759         * source.c (select_source_symtab): Change local variable name.
7760         (forget_cached_source_info_for_objfile): Remove declaration.
7761         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7762         * objfiles.c (objfile_relocate1): Remove declaration.
7763         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7764         declaration.
7765         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7766         * coffread.c (coff_symtab_read): Remove declaration.
7767         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7768         compunit_filetabs.
7769
7770 2019-01-09  Tom Tromey  <tom@tromey.com>
7771
7772         * symtab.c (lookup_objfile_from_block)
7773         (find_pc_sect_compunit_symtab, search_symbols)
7774         (default_collect_symbol_completion_matches_break_on): Use
7775         objfile_compunits.
7776         * objfiles.h (ALL_COMPUNITS): Remove.
7777         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7778         * cp-support.c (add_symbol_overload_list_qualified): Use
7779         objfile_compunits.
7780         * ada-lang.c (ada_collect_symbol_completion_matches)
7781         (ada_add_global_exceptions): Use objfile_compunits.
7782
7783 2019-01-09  Tom Tromey  <tom@tromey.com>
7784
7785         * source.c (select_source_symtab)
7786         (forget_cached_source_info_for_objfile): Remove declaration.
7787         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7788         declaration.
7789         * maint.c (count_symtabs_and_blocks): Remove declaration.
7790         * cp-support.c (add_symbol_overload_list_qualified): Remove
7791         declaration.
7792         * coffread.c (coff_symtab_read): Remove declaration.
7793         * symtab.c (lookup_symbol_in_objfile_symtabs)
7794         (basic_lookup_transparent_type_1): Use objfile_compunits.
7795         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7796         (info_sources_command, search_symbols)
7797         (default_collect_symbol_completion_matches_break_on)
7798         (make_source_files_completion_list): Remove declaration.
7799         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7800         (ada_collect_symbol_completion_matches)
7801         (ada_add_global_exceptions): Remove declaration.
7802         * linespec.c (iterate_over_all_matching_symtabs): Use
7803         objfile_compunits.
7804         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7805         (class objfile_compunits): New.
7806         (ALL_COMPUNITS): Use objfile_compunits.
7807         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7808         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7809         objfile_compunits.
7810         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7811
7812 2019-01-09  Tom Tromey  <tom@tromey.com>
7813
7814         * symtab.c (search_symbols)
7815         (default_collect_symbol_completion_matches_break_on): Use
7816         objfile_msymbols.
7817         * ada-lang.c (ada_lookup_simple_minsym)
7818         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7819         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7820         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7821         objfile_msymbols.
7822         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7823         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7824         * objc-lang.c (find_methods): Use objfile_msymbols.
7825         (info_selectors_command, info_classes_command): Likewise.
7826         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7827         * objfiles.h (class objfile_msymbols): New.
7828         (ALL_OBJFILE_MSYMBOLS): Remove.
7829         (ALL_MSYMBOLS): Remove.
7830
7831 2019-01-09  Tom Tromey  <tom@tromey.com>
7832
7833         * common/next-iterator.h (next_adapter): Add Iterator template
7834         parameter.
7835         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7836         (class all_objfiles_safe): New.
7837         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7838         * objfiles.c (put_objfile_before): Update comment.
7839         (add_separate_debug_objfile): Likewise.
7840         (free_all_objfiles): Use all_objfiles_safe.
7841         (objfile_purge_solibs): Likewise.
7842
7843 2019-01-09  Tom Tromey  <tom@tromey.com>
7844
7845         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7846         (expand_symtab_containing_pc, lookup_static_symbol)
7847         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7848         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7849         all_objfiles.
7850         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7851         * breakpoint.c (create_overlay_event_breakpoint)
7852         (create_longjmp_master_breakpoint)
7853         (create_std_terminate_master_breakpoint)
7854         (create_exception_master_breakpoint): Use all_objfiles.
7855         * linux-thread-db.c (try_thread_db_load_from_pdir)
7856         (has_libpthread): Use all_objfiles.
7857         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7858         * linespec.c (iterate_over_all_matching_symtabs)
7859         (search_minsyms_for_name): Use all_objfiles.
7860         * maint.c (maintenance_info_sections): Use all_objfiles.
7861         * main.c (captured_main_1): Use all_objfiles.
7862         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7863         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7864         * guile/scm-pretty-print.c
7865         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7866         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7867         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7868         (maintenance_print_msymbols): Use all_objfiles.
7869         * source.c (select_source_symtab): Use all_objfiles.
7870         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7871         * symfile.c (remove_symbol_file_command)
7872         (expand_symtabs_matching, map_symbol_filenames): Use
7873         all_objfiles.
7874         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7875         all_objfiles.
7876         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7877         * objc-lang.c (find_methods): Use all_objfiles.
7878         * objfiles.c (have_partial_symbols, have_full_symbols)
7879         (have_minimal_symbols, qsort_cmp)
7880         (default_iterate_over_objfiles_in_search_order): Use
7881         all_objfiles.
7882         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7883         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7884         (maintenance_check_psymtabs): Use all_objfiles.
7885         (ALL_PSYMTABS): Remove.
7886         * compile/compile-object-run.c (do_module_cleanup): Use
7887         all_objfiles.
7888         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7889         * cp-support.c (add_symbol_overload_list_qualified): Use
7890         all_objfiles.
7891         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7892         Use all_objfiles.
7893         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7894         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7895         all_objfiles.
7896         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7897         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7898         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7899         Uses all_objfiles.
7900         * solib.c (solib_read_symbols): Use all_objfiles
7901
7902 2019-01-09  Tom Tromey  <tom@tromey.com>
7903
7904         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7905         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7906         all_objfiles.
7907         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7908         * symmisc.c (print_symbol_bcache_statistics)
7909         (print_objfile_statistics, maintenance_print_objfiles)
7910         (maintenance_info_symtabs, maintenance_check_symtabs)
7911         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7912         all_objfiles.
7913         * source.c (forget_cached_source_info): Use all_objfiles.
7914         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7915         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7916         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7917         * objfiles.c (update_section_map): Use all_objfiles.
7918         (shared_objfile_contains_address_p): Likewise.
7919         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7920         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7921
7922 2019-01-09  Tom Tromey  <tom@tromey.com>
7923
7924         * common/next-iterator.h: New file.
7925         * objfiles.h (class all_objfiles): New.
7926         (struct objfile_iterator): New.
7927
7928 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7929
7930         * NEWS: Move the description of the changed "frame", "select-frame",
7931          and "info frame" commands to the Changed commands section.
7932
7933 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7934
7935         * gdbtypes.c (check_stub_method_group): Remove handling of old
7936         mangling schemes.
7937         * linespec.c (find_methods): Likewise.
7938         * stabsread.c (read_member_functions): Likewise.
7939         * valops.c (search_struct_method): Likewise.
7940         (value_struct_elt_for_reference): Likewise.
7941         * NEWS: Mention this change.
7942
7943 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7944
7945         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7946         print_source_lines.
7947         * source.c (print_source_lines_base): Update line number check.
7948         (print_source_lines): New function.
7949         (source_lines_range::source_lines_range): New function.
7950         * source.h (class source_lines_range): New class.
7951         (print_source_lines): New declaration.
7952
7953 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7954
7955         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7956
7957 2019-01-08  Tom Tromey  <tom@tromey.com>
7958             Simon Marchi  <simon.marchi@ericsson.com>
7959
7960         PR gdb/24060
7961         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7962         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7963         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7964         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7965         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7966         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7967
7968 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7969
7970         * source.c (select_source_symtab): Move header comment to
7971         declaration in source.h.
7972         (forget_cached_source_info_for_objfile): Likewise.
7973         (forget_cached_source_info): Likewise.
7974         (identify_source_line): Likewise.
7975         * source.h (identify_source_line): Move declaration from symtab.h
7976         and add comment from source.c
7977         (print_source_lines): Likewise.
7978         (forget_cached_source_info_for_objfile): Likewise.
7979         (forget_cached_source_info): Likewise.
7980         (select_source_symtab): Likewise.
7981         (enum print_source_lines_flag): Move definition from symtab.h.
7982         * symtab.h (identify_source_line): Move declaration to source.h.
7983         (print_source_lines): Likewise.
7984         (forget_cached_source_info_for_objfile): Likewise.
7985         (forget_cached_source_info): Likewise.
7986         (select_source_symtab): Likewise.
7987         (enum print_source_lines_flag): Move definition to source.h.
7988         * tui/tui-hooks.c: Add 'source.h' include.
7989
7990 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7991
7992         * source.c (print_source_lines_base): Handle requests to print
7993         reverse line number sequences, and guard against empty lines
7994         string.
7995
7996 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7997
7998         * source.c (print_source_lines_base): Fix skip of '\r' if next
7999         character is '\n'.
8000
8001 2019-01-06  Tom Tromey  <tom@tromey.com>
8002
8003         * c-exp.y (struct c_parse_state) <macro_original_text,
8004         expansion_obstack>: New member.
8005         (macro_original_text, expansion_obstack): Remove globals.
8006         (scan_macro_expansion, scanning_macro_expansion)
8007         (finished_macro_expansion): Update.
8008         (scan_macro_cleanup): Remove.
8009         (yylex, c_parse): Update.
8010
8011 2019-01-06  Tom Tromey  <tom@tromey.com>
8012
8013         * c-exp.y (struct c_parse_state) <strings>: New member.
8014         (operator_stoken): Update.
8015
8016 2019-01-06  Tom Tromey  <tom@tromey.com>
8017
8018         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8019         (union type_stack_elt) <typelist_val>: Now a pointer to
8020         std::vector.
8021         (type_stack_cleanup): Don't declare.
8022         (push_typelist): Update.
8023         * parse.c (pop_typelist): Return a std::vector.
8024         (push_typelist): Take a std::vector.
8025         (follow_types): Update.  Do not free args.
8026         (type_stack_cleanup): Remove.
8027         * c-exp.y (struct c_parse_state): New.
8028         (cpstate): New global.
8029         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8030         (nonempty_typelist): Update.
8031         (func_mod): Create a new vector.
8032         (c_parse): Create a c_parse_state.
8033         (check_parameter_typelist): Do not delete params.
8034         (function_method): Update.  Do not delete type_list.
8035
8036 2019-01-06  Tom Tromey  <tom@tromey.com>
8037
8038         PR gdb/28155:
8039         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8040         check_typedef.
8041         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8042         (print_return_value): Likewise.
8043
8044 2019-01-05  Tom Tromey  <tom@tromey.com>
8045
8046         * contrib/cleanup_check.py: Remove.
8047         * contrib/gcc-with-excheck: Remove.
8048         * contrib/exsummary.py: Remove.
8049         * contrib/excheck.py: Remove.
8050
8051 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8052
8053         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8054         NULL. Initialize tpprev to NULL instead of assigning it
8055         to NULL on the next statement.
8056         * windows-nat.c (windows_delete_thread): Remove check for
8057         main_thread_id before printing thread exit notifications.
8058         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8059         Remove thread ID check against main_thread_id.
8060         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8061         windows_delete_thread.
8062         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8063
8064 2019-01-04  Tom Tromey  <tom@tromey.com>
8065
8066         * compile/compile.c (_initialize_compile): Use upper case for
8067         metasyntactic variables.
8068         * symmisc.c (_initialize_symmisc): Use upper case for
8069         metasyntactic variables.
8070         * psymtab.c (_initialize_psymtab): Use upper case for
8071         metasyntactic variables.
8072         * demangle.c (demangle_command): Use upper case for metasyntactic
8073         variables.
8074         (_initialize_demangler): Likewise.
8075         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8076         variables.
8077
8078 2019-01-03  Tom Tromey  <tom@tromey.com>
8079
8080         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8081
8082 2019-01-03  Tom Tromey  <tom@tromey.com>
8083
8084         * python/py-symtab.c (salpy_str): Update.
8085         (struct salpy_sal_object) <symtab>: Now a PyObject.
8086         (salpy_dealloc): Update.
8087         (del_objfile_sal): Use gdbpy_ref.
8088
8089 2019-01-03  Tom Tromey  <tom@tromey.com>
8090
8091         * python/py-type.c (convert_field): Use new_reference.  Return
8092         gdbpy_ref.
8093         (make_fielditem): Return gdbpy_ref.
8094         (typy_fields): Update.
8095         (typy_getitem): Update.
8096         (field_name): Return gdbpy_ref.  Use new_reference.
8097         (typy_iterator_iternext): Update.
8098
8099 2019-01-03  Tom Tromey  <tom@tromey.com>
8100
8101         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8102
8103 2019-01-03  Tom Tromey  <tom@tromey.com>
8104
8105         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8106         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8107         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8108         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8109         (pspy_set_type_printers): Likewise.
8110         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8111         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8112         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8113         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8114         (objfpy_set_type_printers): Likewise.
8115
8116 2019-01-03  Tom Tromey  <tom@tromey.com>
8117
8118         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8119         (gdbpy_print_stack): Use gdbpy_err_fetch.
8120         * python/python-internal.h (class gdbpy_err_fetch): New class.
8121         (class gdbpy_enter) <m_error_type, m_error_value,
8122         m_error_traceback>: Remove.
8123         <m_error>: New member.
8124         (gdbpy_exception_to_string): Don't declare.
8125         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8126         * python/py-value.c (convert_value_from_python): Use
8127         gdbpy_err_fetch.
8128         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8129         gdbpy_exception_to_string.
8130         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8131         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8132         gdbpy_err_fetch.
8133
8134 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8135
8136         * linux-nat.c (delete_lwp_cleanup): Delete.
8137         (struct lwp_deleter): New struct.
8138         (lwp_info_up): New typedef.
8139         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8140         lwp_info_up.
8141
8142 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8143
8144         * linux-fork.c (class scoped_switch_fork_info): New class.
8145         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8146
8147 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8148
8149         * valops.c (find_overload_match): Remove use of null_cleanup, and
8150         calls to do_cleanups.
8151
8152 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8153
8154         * compile/compile-cplus-types.c
8155         (compile_cplus_instance::decl_name): Handle changes to
8156         cp_func_name.
8157         * cp-support.c (cp_func_name): Update header comment, update
8158         return type.
8159         * cp-support.h (cp_func_name): Update return type in declaration.
8160         * valops.c (find_overload_match): Move temp_func local to top
8161         level of function and change its type.  Use temp_func to hold and
8162         delete temporary string obtained from cp_func_name.
8163
8164 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8165
8166         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8167         gdb::char_vector, remove cleanup, and update uses of `msg`.
8168
8169 2019-01-03  Jim Wilson  <jimw@sifive.com>
8170
8171         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8172
8173 2019-01-02  Tom Tromey  <tom@tromey.com>
8174
8175         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8176         (tdesc_parse_xml): Remove cleanups.
8177         * target-descriptions.h (make_cleanup_free_target_description):
8178         Don't declare.
8179         (target_desc_deleter): New struct.
8180         (target_desc_up): New typedef.
8181         * target-descriptions.c (target_desc_deleter::operator()): Rename
8182         from free_target_description.
8183         (make_cleanup_free_target_description): Remove.
8184
8185 2019-01-02  Tom Tromey  <tom@tromey.com>
8186
8187         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8188         constructor, destructor.
8189         (linespec_parser): Remove typedef.
8190         (~linespec_parser): Rename from linespec_parser_delete.
8191         (linespec_lex_to_end, linespec_complete_label)
8192         (linespec_complete): Update.
8193         (decode_line_full): Remove cleanups.
8194         (decode_line_1): Update.
8195
8196 2019-01-02  Tom Tromey  <tom@tromey.com>
8197
8198         * python/python-internal.h (inferior_to_inferior_object): Change
8199         return type.
8200         * python/py-exitedevent.c (create_exited_event_object): Update.
8201         * python/py-inferior.c (inferior_to_inferior_object): Return
8202         gdbpy_ref.
8203         (python_new_inferior, python_inferior_deleted)
8204         (thread_to_thread_object, delete_thread_object)
8205         (build_inferior_list, gdbpy_selected_inferior): Update.
8206         * python/py-infthread.c (create_thread_object): Update.  Also fail
8207         if inferior_to_inferior_object fails.
8208
8209 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8210
8211         * inferior.h (class inferior) <displaced_step_state>: New field.
8212         * infrun.h (struct displaced_step_state): Move here from
8213         infrun.c.  Initialize fields, add constructor.
8214         <inf>: Remove field.
8215         <reset>: New method.
8216         * infrun.c (struct displaced_step_inferior_state): Move to
8217         infrun.h.
8218         (displaced_step_inferior_states): Remove.
8219         (get_displaced_stepping_state): Adust.
8220         (displaced_step_in_progress_any_inferior): Adjust.
8221         (displaced_step_in_progress_thread): Adjust.
8222         (displaced_step_in_progress): Adjust.
8223         (add_displaced_stepping_state): Remove.
8224         (get_displaced_step_closure_by_addr): Adjust.
8225         (remove_displaced_stepping_state): Remove.
8226         (infrun_inferior_exit): Call displaced_step_state.reset.
8227         (use_displaced_stepping): Don't check for NULL.
8228         (displaced_step_prepare_throw): Call
8229         get_displaced_stepping_state.
8230         (displaced_step_fixup): Don't check for NULL.
8231         (prepare_for_detach): Don't check for NULL.
8232
8233 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8234
8235         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8236          in case of call that did not complete.
8237
8238 2019-01-02  Andrey Utkin  <autkin@undo.io>
8239
8240         * symfile.c (find_separate_debug_file): Fix search of debug files for
8241         remote debuggee.
8242
8243 2019-01-02  Tom Tromey  <tom@tromey.com>
8244
8245         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8246         indentation.
8247         * python/py-frame.c (frapy_older): Remove cast.
8248         (frapy_newer): Likewise.
8249         * python/py-breakpoint.c (local_setattro): Remove cast.
8250         * python/py-arch.c (archpy_name): Remove local variable.
8251         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8252
8253 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8254
8255         * unittests/basic_string_view/element_access/char/empty.cc:
8256         Fix year range in copyright header.
8257
8258 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8259
8260         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8261         Delete.
8262         <operator==>: Update with for removed field.
8263         <hash>: Likewise.
8264         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8265         <isa_features>: ...this.
8266         <abi_features>: New field.
8267         (riscv_isa_flen): Update comment.
8268         (riscv_abi_xlen): New declaration.
8269         (riscv_abi_flen): New declaration.
8270         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8271         isa_features.
8272         (riscv_abi_xlen): New function.
8273         (riscv_isa_flen): Update to get answer from isa_features.
8274         (riscv_abi_flen): New function.
8275         (riscv_has_fp_abi): Update to get answer from abi_features.
8276         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8277         xlen and flen.
8278         (riscv_call_info) <xlen, flen>: Update comment.
8279         (riscv_call_arg_struct): Remove invalid assertions
8280         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8281         is removed.
8282         (riscv_gdbarch_init): Gather isa features and abi features
8283         separately, ensure both match on the gdbarch when reusing an old
8284         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8285         a target with 64-bit float hardware.
8286
8287 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8288
8289         * source.c (search_command_helper): Stop reverse search
8290         when line 1 has been searched.
8291
8292 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8293
8294         * record-full.c (record_full_base_target::close): Rewrite
8295         record_full_core_buf_list free logic.
8296
8297 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8298
8299         * break-catch-syscall.c (print_one_catch_syscall): xfree
8300         the last text.
8301
8302 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8303
8304         * top.c (print_gdb_version): Update Copyright year in version
8305         message.
8306
8307 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8308
8309         Update copyright year range in all GDB files.
8310
8311 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8312
8313         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8314
8315 For older changes see ChangeLog-2018.
8316 \f
8317 Local Variables:
8318 mode: change-log
8319 left-margin: 8
8320 fill-column: 74
8321 version-control: never
8322 coding: utf-8
8323 End:
8324