1 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
4 * hppa-linux-nat.c: Include gdbarch.h.
6 2019-09-26 Christian Biesinger <cbiesinger@google.com>
8 * blockframe.c (find_pc_partial_function): Change return type to bool.
9 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
10 * minsyms.c (in_gnu_ifunc_stub): Likewise.
11 (stub_gnu_ifunc_resolve_name): Likewise.
12 * symtab.c (compare_filenames_for_search): Likewise.
13 (compare_glob_filenames_for_search): Likewise.
14 (matching_obj_sections): Likewise.
15 (symbol_matches_domain): Likewise.
16 (find_line_symtab): Change out param EXACT_MATCH to bool *.
17 (find_line_pc): Change return type to bool.
18 (find_line_pc_range): Likewise.
19 (producer_is_realview): Likewise.
20 * symtab.h (symbol_matches_domain): Likewise.
21 (find_pc_partial_function): Likewise.
22 (find_pc_line_pc_range): Likewise.
23 (in_gnu_ifunc_stub): Likewise.
24 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
25 (find_line_pc): Likewise.
26 (find_line_pc_range): Likewise.
27 (matching_obj_sections): Likewise.
28 (find_line_symtab): Change out parameter to bool.
29 (producer_is_realview): Change return type to bool.
30 (compare_filenames_for_search): Likewise.
31 (compare_glob_filenames_for_search): Likewise.
33 2019-09-26 Tom Tromey <tom@tromey.com>
35 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
36 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
37 * gdb_usleep.h: Remove.
38 * gdb_usleep.c: Remove.
39 * utils.c: Don't include gdb_usleep.h.
41 2019-09-26 Tom Tromey <tromey@adacore.com>
43 * python/py-type.c (type_to_type_object): Call check_typedef
46 2019-09-26 Tom Tromey <tom@tromey.com>
48 * utils.h (initialize_utils): Don't declare.
49 * top.c (gdb_init): Don't call initialize_utils.
50 * utils.c (initialize_utils): Remove. Move contents...
51 (_initialize_utils): ... here.
53 2019-09-25 Tom Tromey <tom@tromey.com>
55 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
56 * utils.h (make_hex_string): Don't declare.
57 * utils.c (make_hex_string): Remove.
59 2019-09-24 Tom de Vries <tdevries@suse.de>
62 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
63 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
65 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
67 * NEWS: Mention new simulator port for PRU.
69 2019-09-23 Christian Biesinger <cbiesinger@google.com>
71 * ada-exp.y (write_object_remaining): Update.
72 * ada-lang.c (ada_decode): Return a std::string instead of a char*
73 and eliminate the static buffer.
74 (ada_decode_symbol): Update.
75 (ada_la_decode): Update.
76 (ada_sniff_from_mangled_name): Update.
77 (is_valid_name_for_wild_match): Update.
78 (ada_lookup_name_info::matches): Update and simplify.
79 (name_matches_regex): Update.
80 (ada_add_global_exceptions): Update.
81 * ada-lang.h (ada_decode): Update signature.
82 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
83 * dwarf-index-write.c (debug_names::insert): Update.
85 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
87 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
90 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
92 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
93 Change "nonzero" to "true" in documentation.
95 2019-09-20 Christian Biesinger <cbiesinger@google.com>
97 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
98 (_initialize_darwin_solib): Don't set
99 darwin_so_ops.lookup_lib_global_symbol.
100 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
101 set_gdbarch_iterate_over_objfiles_in_search_order.
102 (elf_lookup_lib_symbol): Rename to...
103 (svr4_iterate_over_objfiles_in_search_order): this, and update
104 to iterate semantics.
105 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
106 * solib.c (solib_global_lookup): Remove.
107 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
108 (solib_global_lookup): Remove.
109 * symtab.c (lookup_global_or_static_symbol): Remove call to
112 2019-09-20 Joel Brobecker <brobecker@adacore.com>
114 * NEWS: Move entries about default MI version now being
115 version 3, and about the GDB/MI fix for multi-location
116 breakpoints to the "since GDB 8.3" section.
118 2019-09-20 Joel Brobecker <brobecker@adacore.com>
122 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
124 * NEWS: Mention that Cell/B.E. debugging support was removed.
125 * MAINTAINERS: Remove spu target.
127 * config/djgpp/fnchange.lst: Remove entries for removed files.
129 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
130 spu-multiarch.o, and spu-tdep.o.
131 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
132 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
133 spu-multiarch.c, and spu-tdep.c.
134 * spu-linux-nat.c: Remove file.
135 * spu-multiarch.c: Remove file.
136 * spu-tdep.c: Remove file.
137 * spu-tdep.h: Remove file.
138 * solib-spu.c: Remove file.
139 * solib-spu.h: Remove file.
141 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
142 * configure.nat (spu-linux): Remove.
143 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
144 solib-multiarch.o from gdb_target_obs.
147 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
149 (ppc_linux_no_features): Update.
150 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
152 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
153 (tdesc_powerpc_cell64l): Likewise.
154 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
155 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
157 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
158 Do not include "features/rs6000/powerpc-cell32l.c" or
159 "features/rs6000/powerpc-cell64l.c".
160 (ppc_linux_spu_section): Remove.
161 (ppc_linux_core_read_description): Remove Cell/B.E. support.
162 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
163 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
164 (ppc_linux_spe_context_lookup): Remove.
165 (ppc_linux_spe_context_inferior_created): Remove.
166 (ppc_linux_spe_context_solib_loaded): Remove.
167 (ppc_linux_spe_context_solib_unloaded): Remove.
168 (ppc_linux_spe_context): Remove.
169 (struct ppu2spu_cache): Remove.
170 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
171 (struct ppu2spu_data): Remove.
172 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
173 ppu2spu_unwind): Remove.
174 (ppc_linux_init_abi): Remove Cell/B.E. support.
175 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
177 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
178 (rs6000/powerpc-cell64l-expedite): Likewise
179 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
180 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
181 rs6000/powerpc-cell64l.xml.
182 * features/rs6000/powerpc-cell32l.xml: Remove.
183 * features/rs6000/powerpc-cell64l.xml: Likewise.
184 * features/rs6000/powerpc-cell32l.c: Remove generated file.
185 * features/rs6000/powerpc-cell64l.c: Likewise.
186 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
187 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
188 * regformats/reg-spu.dat: Remove.
190 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
191 * corelow.c (struct spuid_list): Remove.
192 (add_to_spuid_list): Remove.
193 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
194 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
195 (remote_protocol_features): Remove associated entries.
196 (_initialize_remote): No longer initialize them.
197 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
198 * linux-nat.c (SPUFS_MAGIC): Remove.
199 (linux_proc_xfer_spu): Remove.
200 (spu_enumerate_spu_ids): Remove.
201 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
202 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
203 (linux_make_corefile_notes): No longer call it.
205 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
206 (cooked_write_test): Likewise.
208 2019-09-20 Tom Tromey <tom@tromey.com>
210 * NEWS: Mention case-sensitivity of TUI commands.
211 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
212 (tui_set_win_height_command, parse_scrolling_args): Likewise.
213 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
215 2019-09-20 Tom Tromey <tom@tromey.com>
217 * tui/tui-source.c (tui_source_window::set_contents): Use
219 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
222 2019-09-20 Tom Tromey <tom@tromey.com>
224 * tui/tui-data.c: Remove separator comments.
225 * tui/tui-layout.c: Remove separator comments.
226 * tui/tui-win.c: Remove separator comments.
227 * tui/tui-wingeneral.c: Remove separator comments.
229 2019-09-20 Tom Tromey <tom@tromey.com>
231 * tui/tui.h (strcat_to_buf): Don't declare.
232 * tui/tui.c (strcat_to_buf): Remove.
234 2019-09-20 Tom Tromey <tom@tromey.com>
236 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
238 * tui/tui-source.c (tui_source_window::set_contents)
239 (tui_source_window::location_matches_p)
240 (tui_source_window::maybe_update): Update.
242 2019-09-20 Tom Tromey <tom@tromey.com>
244 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
246 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
248 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
249 (tui_data_window::line_from_reg_element_no)
250 (tui_data_window::first_reg_element_no_inline)
251 (tui_data_window::show_registers)
252 (tui_data_window::show_register_group)
253 (tui_data_window::display_registers_from)
254 (tui_data_window::display_registers_from_line)
255 (tui_data_window::first_data_item_displayed)
256 (tui_data_window::delete_data_content_windows)
257 (tui_data_window::erase_data_content)
258 (tui_data_window::do_scroll_vertical)
259 (tui_data_window::refresh_window)
260 (tui_data_window::check_register_values): Update.
262 2019-09-20 Tom Tromey <tom@tromey.com>
264 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
265 (struct tui_locator_window) <full_name, proc_name>: Now
267 * tui/tui-stack.c (tui_locator_window::make_status_line)
268 (tui_locator_window::set_locator_fullname)
269 (tui_locator_window::set_locator_info): Update.
270 * tui/tui-source.c (tui_source_window::set_contents)
271 (tui_source_window::showing_source_p): Update.
273 2019-09-20 Tom Tromey <tom@tromey.com>
275 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
276 Don't call tui_locator_win_info_ptr.
278 2019-09-20 Tom Tromey <tom@tromey.com>
280 * tui/tui-win.c (tui_resize_all): Don't call refresh.
282 2019-09-20 Tom Tromey <tom@tromey.com>
284 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
286 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
287 * tui/tui-layout.c (show_source_disasm_command, show_data)
288 (show_source_or_disasm_and_command): Use 1 as height for locator.
290 2019-09-20 Tom Tromey <tom@tromey.com>
292 * tui/tui.c (tui_enable): Update.
293 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
295 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
297 * tui/tui-data.c (win_resized): Now bool.
298 (tui_win_resized): Return bool.
299 (tui_set_win_resized_to): Accept a bool.
301 2019-09-20 Tom Tromey <tom@tromey.com>
303 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
304 Change type of "refresh_values_only".
305 * tui/tui-regs.c (tui_data_window::show_register_group): Change
306 type of "refresh_values_only".
308 2019-09-20 Tom Tromey <tom@tromey.com>
310 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
312 (tui_disassemble): Add "pos" parameter.
313 (tui_disasm_window::set_contents): Simplify.
315 2019-09-20 Tom Tromey <tom@tromey.com>
317 * tui/tui-winsource.h (struct tui_source_window_base)
318 <show_source_content>: Now private.
319 * tui/tui-winsource.c
320 (tui_source_window_base::show_source_content): Don't handle empty
323 2019-09-20 Tom Tromey <tom@tromey.com>
325 * tui/tui-layout.c (show_source_disasm_command)
326 (show_source_or_disasm_and_command): Don't call
329 2019-09-20 Tom Tromey <tom@tromey.com>
331 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
333 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
334 from tui_make_status_line.
335 (tui_locator_window::rerender): Update.
337 2019-09-20 Tom Tromey <tom@tromey.com>
339 * tui/tui-stack.c (tui_make_status_line): Return std::string.
340 (tui_locator_window::rerender): Update.
342 2019-09-20 Tom Tromey <tom@tromey.com>
344 * tui/tui-winsource.h (struct tui_source_window_base)
345 <~tui_source_window_base>: Don't declare.
347 * tui/tui-winsource.c (~tui_source_window_base): Remove.
348 * tui/tui-source.h (struct tui_source_window) <fullname>: New
350 * tui/tui-source.c (tui_source_window::set_contents): Update.
351 (tui_source_window::location_matches_p)
352 (tui_source_window::maybe_update): Update.
354 2019-09-20 Tom Tromey <tom@tromey.com>
356 * tui/tui-winsource.h (~tui_source_element): Remove.
357 (tui_source_element): Update.
358 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
359 * tui/tui-winsource.c (tui_show_source_line): Update.
360 * tui/tui-source.c (tui_source_window::set_contents): Update.
361 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
363 2019-09-20 Tom Tromey <tom@tromey.com>
365 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
367 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
368 tui_clear_source_windows_detail.
369 * tui/tui-winsource.h (struct tui_source_window_base)
370 <clear_detail>: Don't declare.
371 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
373 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
375 2019-09-20 Tom Tromey <tromey@adacore.com>
378 * block.c (contained_in): Fix final return value.
380 2019-09-20 Alan Modra <amodra@gmail.com>
382 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
383 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
384 (read_indirect_string_from_dwz): Use bfd accessor.
385 * dwarf2read.h (struct dwz_file <filename>): Likewise.
386 * machoread.c (macho_symfile_read_all_oso): Likewise.
387 * solib.c (solib_bfd_open): Likewise.
389 2019-09-19 Christian Biesinger <cbiesinger@google.com>
391 * eval.c: Move declaration of overload_resolution to...
394 2019-09-19 Christian Biesinger <cbiesinger@google.com>
396 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
397 * arm-linux-tdep.c: Likewise.
398 * arm-nbsd-nat.c: Likewise.
399 * arm-tdep.h: Declare arm_apcs_32.
400 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
402 2019-09-19 Christian Biesinger <cbiesinger@google.com>
404 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
405 * dwarf2read.h: Declare dwarf_always_disassemble.
407 2019-09-19 Tom de Vries <tdevries@suse.de>
410 * source-cache.c (source_cache::ensure): Catch exception thrown during
411 construction of the highlighter.
413 2019-09-18 Alan Modra <amodra@gmail.com>
415 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
416 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
417 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
418 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
419 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
420 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
421 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
422 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
423 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
424 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
425 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
426 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
427 * solib-spu.c, * solib-svr4.c, * solib-target.c,
428 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
429 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
430 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
431 * mi/mi-interp.c: Update throughout for bfd section macro and
433 * gcore (gcore_create_callback): Use bfd_set_section_lma.
434 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
436 2019-09-18 Tom Tromey <tom@tromey.com>
439 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
441 (tui_enable): Do not call rl_initialize.
443 2019-09-18 Christian Groessler <chris@groessler.org>
445 * alpha-linux-nat.c: Include gdbarch.h.
447 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
449 * ui-file.c: Include cli/cli-style.h.
450 (term_cli_styling): Remove cli_styling declaration.
452 2019-09-18 Alan Modra <amodra@gmail.com>
454 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
455 to bfd_asymbol_section.
457 2019-09-18 Alan Modra <amodra@gmail.com>
459 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
460 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
461 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
463 2019-09-18 Alan Modra <amodra@gmail.com>
465 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
466 * spu-linux-nat.c (spu_bfd_open): Likewise.
468 2019-09-18 Christian Biesinger <cbiesinger@google.com>
470 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
471 to bool to match definition in dwarf2read.c.
473 2019-09-17 Christian Biesinger <cbiesinger@google.com>
475 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
476 (print_signatures): Likewise.
477 (trust_pad_over_xvs): Likewise.
478 * arch/aarch64-insn.c (aarch64_debug): Likewise.
479 * arch/aarch64-insn.h (aarch64_debug): Likewise.
480 * arm-linux-nat.c (arm_apcs_32): Likewise.
481 * arm-linux-tdep.c (arm_apcs_32): Likewise.
482 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
483 * arm-tdep.c (arm_debug): Likewise.
484 (arm_apcs_32): Likewise.
485 * auto-load.c (debug_auto_load): Likewise.
486 (auto_load_gdb_scripts): Likewise.
487 (global_auto_load): Likewise.
488 (auto_load_local_gdbinit): Likewise.
489 (auto_load_local_gdbinit_loaded): Likewise.
490 * auto-load.h (global_auto_load): Likewise.
491 (auto_load_local_gdbinit): Likewise.
492 (auto_load_local_gdbinit_loaded): Likewise.
493 * breakpoint.c (disconnected_dprintf): Likewise.
494 (breakpoint_proceeded): Likewise.
495 (automatic_hardware_breakpoints): Likewise.
496 (always_inserted_mode): Likewise.
497 (target_exact_watchpoints): Likewise.
498 (_initialize_breakpoint): Update.
499 * breakpoint.h (target_exact_watchpoints): Change to bool.
500 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
501 * cli/cli-cmds.c (trace_commands): Likewise.
502 * cli/cli-cmds.h (trace_commands): Likewise.
503 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
505 * cli/cli-logging.c (logging_overwrite): Change to bool.
506 (logging_redirect): Likewise.
507 (debug_redirect): Likewise.
508 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
509 (struct boolean_option_def) <get_var_address_cb_>: Change return type
511 <boolean_option_def>: Update.
512 (struct flag_option_def): Change default type of Context to bool
514 <flag_option_def>: Change return type of var_address_cb_ to bool*.
515 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
516 (get_setshow_command_value_string): Likewise.
517 * cli/cli-style.c (cli_styling): Change to bool.
518 (source_styling): Likewise.
519 * cli/cli-style.h (source_styling): Likewise.
520 (cli_styling): Likewise.
521 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
523 * command.h (var_types): Update comment.
524 (add_setshow_boolean_cmd): Change int* var argument to bool*.
525 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
527 (debug_compile_cplus_scopes): Likewise.
528 * compile/compile-internal.h (compile_debug): Likewise.
529 * compile/compile.c (compile_debug): Likewise.
530 (struct compile_options) <raw>: Likewise.
531 * cp-support.c (catch_demangler_crashes): Likewise.
532 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
533 (usr_cmd_cris_dwarf2_cfi): Likewise.
534 * csky-tdep.c (csky_debug): Likewise.
535 * darwin-nat.c (enable_mach_exceptions): Likewise.
536 * dcache.c (dcache_enabled_p): Likewise.
537 * defs.h (info_verbose): Likewise.
538 * demangle.c (demangle): Likewise.
539 (asm_demangle): Likewise.
540 * dwarf-index-cache.c (debug_index_cache): Likewise.
541 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
542 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
543 * dwarf2read.c (check_physname): Likewise.
544 (use_deprecated_index_sections): Likewise.
545 (dwarf_always_disassemble): Likewise.
546 * eval.c (overload_resolution): Likewise.
547 * event-top.c (set_editing_cmd_var): Likewise.
548 (exec_done_display_p): Likewise.
549 * event-top.h (set_editing_cmd_var): Likewise.
550 (exec_done_display_p): Likewise.
551 * exec.c (write_files): Likewise.
552 * fbsd-nat.c (debug_fbsd_lwp): Likewise
553 (debug_fbsd_nat): Likewise.
554 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
556 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
557 <backtrace_past_entry> Likewise.
558 * gdb-demangle.h (demangle): Likewise.
559 (asm_demangle): Likewise.
560 * gdb_bfd.c (bfd_sharing): Likewise.
561 * gdbcore.h (write_files): Likewise.
562 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
563 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
564 * gdbthread.h (print_thread_events): Likewise.
565 * gdbtypes.c (opaque_type_resolution): Likewise.
566 (strict_type_checking): Likewise.
567 * gnu-nat.c (gnu_debug_flag): Likewise.
568 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
569 * guile/scm-param.c (pascm_variable): Add boolval.
570 (add_setshow_generic): Update.
571 (pascm_param_value): Update.
572 (pascm_set_param_value_x): Update.
573 * hppa-tdep.c (hppa_debug): Change to bool..
574 * infcall.c (may_call_functions_p): Likewise.
575 (coerce_float_to_double_p): Likewise.
576 (unwind_on_signal_p): Likewise.
577 (unwind_on_terminating_exception_p): Likewise.
578 * infcmd.c (startup_with_shell): Likewise.
579 * inferior.c (print_inferior_events): Likewise.
580 * inferior.h (startup_with_shell): Likewise.
581 (print_inferior_events): Likewise.
582 * infrun.c (step_stop_if_no_debug): Likewise.
583 (detach_fork): Likewise.
584 (debug_displaced): Likewise.
585 (disable_randomization): Likewise.
586 (non_stop): Likewise.
587 (non_stop_1): Likewise.
588 (observer_mode): Likewise.
589 (observer_mode_1): Likewise.
590 (set_observer_mode): Update.
591 (sched_multi): Change to bool.
592 * infrun.h (debug_displaced): Likewise.
593 (sched_multi): Likewise.
594 (step_stop_if_no_debug): Likewise.
595 (non_stop): Likewise.
596 (disable_randomization): Likewise.
597 * linux-tdep.c (use_coredump_filter): Likewise.
598 (dump_excluded_mappings): Likewise.
599 * linux-thread-db.c (auto_load_thread_db): Likewise.
600 (check_thread_db_on_load): Likewise.
601 * main.c (captured_main_1): Update.
602 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
603 xx2_opt, boolean_opt>: Change to bool.
604 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
605 * maint.c (maintenance_profile_p): Likewise.
606 (per_command_time): Likewise.
607 (per_command_space): Likewise.
608 (per_command_symtab): Likewise.
609 * memattr.c (inaccessible_by_default): Likewise.
610 * mi/mi-main.c (mi_async): Likewise.
611 (mi_async_1): Likewise.
612 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
613 * nat/fork-inferior.h (startup_with_shell): Likewise.
614 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
615 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
616 * nios2-tdep.c (nios2_debug): Likewise.
617 * or1k-tdep.c (or1k_debug): Likewise.
618 * parse.c (parser_debug): Likewise.
619 * parser-defs.h (parser_debug): Likewise.
620 * printcmd.c (print_symbol_filename): Likewise.
621 * proc-api.c (procfs_trace): Likewise.
622 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
623 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
624 (set_parameter_value): Update.
625 (add_setshow_generic): Update.
626 * python/py-value.c (copy_py_bool_obj): Change argument from int*
628 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
630 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
631 * record-btrace.c (record_btrace_target::store_registers): Update.
632 * record-full.c (record_full_memory_query): Change to bool.
633 (record_full_stop_at_limit): Likewise.
634 * record-full.h (record_full_memory_query): Likewise.
635 * remote-notif.c (notif_debug): Likewise.
636 * remote-notif.h (notif_debug): Likewise.
637 * remote.c (use_range_stepping): Likewise.
638 (interrupt_on_connect): Likewise.
639 (remote_break): Likewise.
640 * ser-tcp.c (tcp_auto_retry): Likewise.
641 * ser-unix.c (serial_hwflow): Likewise.
642 * skip.c (debug_skip): Likewise.
643 * solib-aix.c (solib_aix_debug): Likewise.
644 * spu-tdep.c (spu_stop_on_load_p): Likewise.
645 (spu_auto_flush_cache_p): Likewise.
646 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
648 (struct info_print_options) <quiet>: Likewise.
649 * symfile-debug.c (debug_symfile): Likewise.
650 * symfile.c (auto_solib_add): Likewise.
651 (separate_debug_file_debug): Likewise.
652 * symfile.h (auto_solib_add): Likewise.
653 (separate_debug_file_debug): Likewise.
654 * symtab.c (basenames_may_differ): Likewise.
655 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
656 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
657 (struct info_types_options) <quiet>: Likewise.
658 * symtab.h (demangle): Likewise.
659 (basenames_may_differ): Likewise.
660 * target-dcache.c (stack_cache_enabled_1): Likewise.
661 (code_cache_enabled_1): Likewise.
662 * target.c (trust_readonly): Likewise.
663 (may_write_registers): Likewise.
664 (may_write_memory): Likewise.
665 (may_insert_breakpoints): Likewise.
666 (may_insert_tracepoints): Likewise.
667 (may_insert_fast_tracepoints): Likewise.
668 (may_stop): Likewise.
669 (auto_connect_native_target): Likewise.
670 (target_stop_and_wait): Update.
671 (target_async_permitted): Change to bool.
672 (target_async_permitted_1): Likewise.
673 (may_write_registers_1): Likewise.
674 (may_write_memory_1): Likewise.
675 (may_insert_breakpoints_1): Likewise.
676 (may_insert_tracepoints_1): Likewise.
677 (may_insert_fast_tracepoints_1): Likewise.
678 (may_stop_1): Likewise.
679 * target.h (target_async_permitted): Likewise.
680 (may_write_registers): Likewise.
681 (may_write_memory): Likewise.
682 (may_insert_breakpoints): Likewise.
683 (may_insert_tracepoints): Likewise.
684 (may_insert_fast_tracepoints): Likewise.
685 (may_stop): Likewise.
686 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
687 (make_thread_apply_all_options_def_group): Change argument from int*
689 (thread_apply_all_command): Update.
690 (print_thread_events): Change to bool.
691 * top.c (confirm): Likewise.
692 (command_editing_p): Likewise.
693 (history_expansion_p): Likewise.
694 (write_history_p): Likewise.
695 (info_verbose): Likewise.
696 * top.h (confirm): Likewise.
697 (history_expansion_p): Likewise.
698 * tracepoint.c (disconnected_tracing): Likewise.
699 (circular_trace_buffer): Likewise.
700 * typeprint.c (print_methods): Likewise.
701 (print_typedefs): Likewise.
702 * utils.c (debug_timestamp): Likewise.
703 (sevenbit_strings): Likewise.
704 (pagination_enabled): Likewise.
705 * utils.h (sevenbit_strings): Likewise.
706 (pagination_enabled): Likewise.
707 * valops.c (overload_resolution): Likewise.
708 * valprint.h (struct value_print_options) <prettyformat_arrays,
709 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
710 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
711 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
713 * windows-nat.c (new_console): Likewise.
714 (cygwin_exceptions): Likewise.
715 (new_group): Likewise.
716 (debug_exec): Likewise.
717 (debug_events): Likewise.
718 (debug_memory): Likewise.
719 (debug_exceptions): Likewise.
720 (useshell): Likewise.
721 * windows-tdep.c (maint_display_all_tib): Likewise.
722 * xml-support.c (debug_xml): Likewise.
724 2019-09-17 Mike Gulick <mgulick@mathworks.com>
726 * source.c (prepare_path_for_appending): New function.
727 (openp): Make use of new function.
728 (find_and_open_source): Search for the compilation directory and
729 source file as a relative path beneath the directory search path.
731 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
733 * source-cache.c (source_cache::get_line_charpos): Catch
734 exceptions and return false, this matches the behaviour documented
737 2019-09-17 Joel Brobecker <brobecker@adacore.com>
739 * ada-tasks.c (info_task): Remove quoting of the task's name.
741 2019-09-16 Christian Biesinger <cbiesinger@google.com>
743 * symfile.c (auto_solib_add): Replace comment with a reference
746 2019-09-14 Christian Biesinger <cbiesinger@google.com>
748 * NEWS: Mention that gdb can now be compiled with Python 3
751 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
753 * maint.c (maint_print_section_data::maint_print_section_data):
754 Force use of 'float log10 (float)' by casting the argument to
757 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
759 * maint.c: Add 'cmath' include.
760 (struct maint_print_section_data): New structure.
761 (print_section_index): New function.
762 (print_bfd_section_info): Add header comment, small whitespace
763 cleanup, and update to call new print_section_index function.
764 (print_objfile_section_info): Likewise.
765 (maint_obj_section_from_bfd_section): New function.
766 (print_bfd_section_info_maybe_relocated): New function.
767 (maintenance_info_sections): Add header comment, always use
768 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
770 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
772 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
773 inner scope, add check that the objfile has psymtabs before
774 checking psymtabs_addrmap.
775 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
777 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
779 * NEWS: Announce that Ada task names are now shown at more places,
780 and between quotes (except in info task output).
781 * gdb/ada-tasks.c (task_to_str): New function.
782 (display_current_task_id): Call task_to_str.
783 (task_command_1): Likewise.
784 (print_ada_task_info): In non-mi mode, Properly align headers and data
785 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
787 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
789 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
790 prstatus.pr_lwp.pr_info instead of making it up.
792 2019-09-11 Christian Biesinger <cbiesinger@google.com>
794 * auto-load.c (auto_load_expand_dir_vars): Update.
795 * defs.h (gdb_datadir): Change to std::string.
796 (python_libdir): Likewise.
797 (relocate_gdb_directory): Change return type to std::string.
798 * guile/guile.c (gdbscm_data_directory): Update.
799 (initialize_scheme_side): Update.
800 * jit.c (jit_reader_dir): Change to std::string.
801 (jit_reader_load_command): Update.
802 * main.c (gdb_datadir): Change to std::string.
803 (python_libdir): Likewise.
804 (set_gdb_data_directory): Update.
805 (relocate_path): Change to return std::string.
806 (relocate_gdb_directory): Change to return std::string.
807 (relocate_gdbinit_path_maybe_in_datadir): Update.
808 (captured_main_1): Update.
809 * python/python.c (do_start_initialization): Update.
810 * top.c (show_gdb_datadir): Update.
811 * xml-syscall.c (xml_init_syscalls_info): Update.
812 (init_syscalls_info): Update.
814 2019-09-11 Christian Biesinger <cbiesinger@google.com>
816 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
817 out of get_init_files.
818 (get_init_files): Update.
820 2019-09-11 Christian Biesinger <cbiesinger@google.com>
822 * main.c (get_init_files): Change to use std::string.
823 (captured_main_1): Update.
824 (print_gdb_help): Update.
826 2019-09-11 Ali Tamur <tamur@google.com>
828 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
831 2019-09-11 Christian Biesinger <cbiesinger@google.com>
833 * dbxread.c (read_dbx_symtab): Update.
834 * dwarf2read.c (load_partial_dies): Update.
835 * mdebugread.c (parse_partial_symbols): Update.
836 (handle_psymbol_enumerators): Update.
837 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
838 * psymtab.c (add_psymbol_to_bcache): Likewise.
839 (add_psymbol_to_list): Likewise.
840 * symtab.c (symbol_set_names): Likewise.
841 * symtab.h (symbol_set_names): Likewise.
842 * xcoffread.c (scan_xcoff_symtab): Update.
844 2019-09-11 Tom Tromey <tom@tromey.com>
846 * symfile-mem.c (symbol_file_add_from_memory): Use
848 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
849 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
851 2019-09-10 Tom Tromey <tromey@adacore.com>
853 * dwarf-index-write.c (write_psymbols): Extend error message.
854 (debug_names::insert): Add Ada code.
855 (debug_names::write_psymbols): Remove Ada check.
856 (debug_names) <m_string_obstack>: New member.
857 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
858 (gdb_index_symbol_name_matcher::matches): Remove.
859 (mapped_index_base::find_name_components_bounds): Add "lang"
861 (mapped_index_base::build_name_components): Also split names
862 according to Ada syntax.
863 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
864 type of "match_callback".
865 (check_match, check_find_bounds_finds)
866 (dw2_expand_symtabs_matching): Update.
867 (dw2_debug_names_iterator): Add new constructor.
868 (dw2_debug_names_map_matching_symbols): New function.
869 (dw2_debug_names_expand_symtabs_matching): Update.
870 (dwarf2_debug_names_functions): Use
871 dw2_debug_names_map_matching_symbols.
873 2019-09-10 Tom Tromey <tromey@adacore.com>
875 * dwarf2read.c (dw2_get_file_names_reader): Add the
876 CU's file name to the results.
878 2019-09-10 Tom Tromey <tromey@adacore.com>
880 * ada-lang.c (add_nonlocal_symbols): Combine calls to
881 map_matching_symbols. Update.
882 * dwarf2read.c (dw2_map_matching_symbols): Update.
883 * psymtab.c (match_partial_symbol): Change type; update.
884 (psym_map_matching_symbols): Likewise.
885 * symfile-debug.c (debug_qf_map_matching_symbols): Change
887 * symfile.h (struct quick_symbol_functions)
888 <map_matching_symbols>: Change "name" to be a lookup_name_info.
891 2019-09-10 Tom Tromey <tromey@adacore.com>
893 * psymtab.c (map_block): Remove.
894 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
895 * symtab.c (iterate_over_symbols_terminated): New function.
896 * symtab.c (iterate_over_symbols_terminated): Declare.
898 2019-09-10 Tom Tromey <tromey@adacore.com>
900 * ada-lang.c (ada_iterate_over_symbols): Return bool.
901 * language.h (struct language_defn) <la_iterate_over_symbols>:
903 * symtab.c (iterate_over_symbols): Return bool.
904 * symtab.h (iterate_over_symbols): Return bool.
906 2019-09-10 Tom Tromey <tromey@adacore.com>
908 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
909 (add_nonlocal_symbols): Update.
910 * dwarf2read.c (dw2_map_matching_symbols): Change type.
911 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
912 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
913 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
914 Change type of "callback". Remove "data".
917 2019-09-09 Ali Tamur <tamur@google.com>
919 * dwarf2read.c (comp_unit_head): Update comment.
920 (dwarf2_dwo_name): New function declaration.
921 (dwarf_unit_type_name): New function declaration.
922 (read_comp_unit_head): Add support for new compilation units,
923 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
924 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
925 (currently named as "signature") in their header. Also clarify error
927 (lookup_dwo_id): New function. Returns the dwo id of the given
929 (lookup_dwo_unit): Use the new lookup_dwo_id function.
930 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
932 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
933 (dwarf2_dwo_name): Get the dwo name if present.
934 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
937 2019-09-09 Tom Tromey <tom@tromey.com>
939 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
941 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
943 * python/python.c (do_start_initialization): Make progname_copy static,
944 to avoid a leak report.
946 2019-09-08 Tom Tromey <tom@tromey.com>
948 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
950 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
952 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
953 Change type to gdb::optional<block_enum>.
954 (dw2_symtab_iter_init): Change block_index parameter type
955 to gdb::optional<block_enum>.
956 (dw2_lookup_symbol): Change block_index parameter
958 (dw2_debug_names_lookup_symbol): Likewise.
959 * psymtab.c (psym_lookup_symbol): Likewise.
960 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
961 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
964 2019-09-06 Christian Biesinger <cbiesinger@google.com>
966 * defs.h (relocate_gdb_directory): Change int to bool in
967 signature and rename flag to relocatable.
968 * main.c (relocate_path): Likewise.
969 (relocate_gdb_directory): Likewise.
971 2019-09-06 Alan Modra <amodra@gmail.com>
973 * coffread.c (coff_symfile_read): Constify filename variable.
974 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
975 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
976 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
977 * solib.c (reload_shared_libraries_1): Likewise.
978 * symfile.c (reread_symbols): Likewise.
979 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
980 * solib-darwin.c (darwin_bfd_open): Likewise.
981 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
983 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
985 * psymtab.c (print_partial_symbols): Handle missing domain_enum
986 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
988 2019-09-03 Tom Tromey <tromey@adacore.com>
990 * ada-valprint.c (ada_val_print_num): Don't recurse for range
992 (has_negatives): Unbias a range type bound.
993 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
994 * gdbtypes.c (operator==): Handle new field.
995 (create_range_type): Add "bias" parameter.
996 (create_static_range_type, resolve_dynamic_range): Update.
997 * gdbtypes.h (struct range_bounds) <bias>: New member.
998 (create_range_type): Add bias parameter.
999 * printcmd.c (print_scalar_formatted): Unbias range types.
1000 * value.c (unpack_long): Unbias range types.
1001 (pack_long): Bias range types.
1003 2019-09-02 Alan Hayward <alan.hayward@arm.com>
1005 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1008 2019-09-02 Alan Hayward <alan.hayward@arm.com>
1010 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1011 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1012 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1013 (compile_probe_arg): Likewise.
1014 * probe.h (get_argument_count): Likewise.
1015 * solib-svr4.c (solib_event_probe_action): Likewise.
1016 * stap-probe.c (stap_probe::get_argument_count): Likewise.
1018 2019-09-02 Alan Hayward <alan.hayward@arm.com>
1020 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1022 (svr4_create_solib_event_breakpoints): ...from here.
1024 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
1026 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1027 suffix from warning message.
1029 2019-08-30 Tom Tromey <tom@tromey.com>
1031 * tui/tui-winsource.h (struct tui_source_window_base)
1032 <refresh_all>: Don't declare.
1033 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1035 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1036 tui_show_locator_content.
1037 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1039 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1040 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1043 2019-08-30 Tom Tromey <tom@tromey.com>
1045 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1047 2019-08-30 Tom Tromey <tom@tromey.com>
1049 * tui/tui-stack.c (_initialize_tui_stack): Move later.
1050 Remove unnecessary forward declarations.
1052 2019-08-30 Tom Tromey <tom@tromey.com>
1054 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1056 (tui_update_locator_fullname, tui_show_frame_info): Don't call
1057 tui_show_locator_content.
1059 2019-08-30 Tom Tromey <tom@tromey.com>
1061 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
1062 (tui_locator_window::rerender): Rewrite using body of previous
1063 tui_show_locator_content.
1065 2019-08-30 Tom Tromey <tom@tromey.com>
1067 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1068 set_locator_fullname>: New methods.
1069 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1070 Rename from tui_set_locator_fullname.
1071 (tui_locator_window::set_locator_info): Rename from
1072 tui_set_locator_info. Return bool.
1073 (tui_update_locator_fullname, tui_show_frame_info): Update.
1075 2019-08-30 Tom Tromey <tom@tromey.com>
1077 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1079 2019-08-30 Tom Tromey <tom@tromey.com>
1081 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1084 2019-08-30 Tom Tromey <tom@tromey.com>
1086 * tui/tui-wingeneral.c (box_win): Assume win_info and
1087 win_info->handle cannot be NULL.
1089 2019-08-30 Tom Tromey <tom@tromey.com>
1091 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1092 refresh_window>: Declare.
1093 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1095 (tui_data_item_window::rerender): Rename from
1096 tui_display_register.
1097 (tui_data_item_window::refresh_window): New method.
1098 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1101 2019-08-30 Tom Tromey <tom@tromey.com>
1103 * tui/tui-regs.h (struct tui_data_window) <regs_content,
1104 regs_column_count, current_group>: Move later. Now private.
1105 <get_current_group>: New method.
1106 * tui/tui-regs.c (tui_reg_command): Update.
1107 * tui/tui-layout.c (tui_set_layout): Update.
1109 2019-08-30 Tom Tromey <tom@tromey.com>
1111 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1112 (tui_data_window::rerender): Don't call
1113 check_and_display_highlight_if_needed.
1114 (tui_data_window::refresh_all): Remove call to
1117 2019-08-30 Tom Tromey <tom@tromey.com>
1119 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1120 (tui_data_window::display_registers_from)
1121 (tui_data_window::display_reg_element_at_line)
1122 (tui_data_window::display_registers_from_line): Remove checks of
1125 2019-08-30 Tom Tromey <tom@tromey.com>
1127 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1129 * tui/tui-regs.c (tui_data_window::show_registers): Call
1131 (tui_data_window::rerender): Rename from display_all_data.
1132 (tui_data_window::rerender): Remove old implementation.
1134 2019-08-30 Tom Tromey <tom@tromey.com>
1136 * tui/tui-regs.c (tui_data_window::display_all_data): Change
1138 * tui/tui-data.h (NO_DATA_STRING): Remove define.
1140 2019-08-29 Bernhard Wodok <barto@gmx.net>
1141 Sergio Durigan Junior <sergiodj@redhat.com>
1144 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1146 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
1148 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1149 when searching for types.
1151 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
1153 * f-lang.c (f_language_defn): Use f_print_typedef.
1154 * f-lang.h (f_print_typedef): Declare.
1155 * f-typeprint.c (f_print_typedef): Define.
1157 2019-08-27 Christian Biesinger <cbiesinger@google.com>
1159 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1161 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
1163 * cli/cli-utils.c (info_print_options_defs): Delete.
1164 (make_info_print_options_def_group): Delete.
1165 (extract_info_print_options): Delete.
1166 (info_print_command_completer): Delete.
1167 (info_print_args_help): Add extra parameter, and optionally
1168 include text about -n flag.
1169 * cli/cli-utils.h (struct info_print_options): Delete.
1170 (extract_info_print_options): Delete declaration.
1171 (info_print_command_completer): Delete declaration.
1172 (info_print_args_help): Add extra parameter, extend header
1174 * python/python.c (gdbpy_rbreak): Pass additional parameter to
1176 * stack.c (struct info_print_options): New type.
1177 (info_print_options_defs): New file scoped variable.
1178 (make_info_print_options_def_group): New static function.
1179 (info_print_command_completer): New static function.
1180 (info_locals_command): Update to use new local functions.
1181 (info_args_command): Likewise.
1182 (_initialize_stack): Add extra parameter to calls to
1183 info_print_args_help.
1184 * symtab.c (search_symbols): Add extra parameter, use this to
1185 possibly excluse non-debug symbols.
1186 (symtab_symbol_info): Add extra parameter, which is passed on to
1188 (struct info_print_options): New type.
1189 (info_print_options_defs): New file scoped variable.
1190 (make_info_print_options_def_group): New static function.
1191 (info_print_command_completer): New static function.
1192 (info_variables_command): Update to use local functions, and pass
1193 extra parameter through to symtab_symbol_info.
1194 (info_functions_command): Likewise.
1195 (info_types_command): Pass additional argument through to
1197 (rbreak_command): Pass extra argument to search_symbols.
1198 (_initialize_symtab): Add extra arguments for calls to
1199 info_print_args_help, and update help text for 'info variables',
1200 'whereis', and 'info functions' commands.
1201 * symtab.h (search_symbols): Add extra argument to declaration.
1202 * NEWS: Mention new flags.
1204 2019-08-26 Christian Biesinger <cbiesinger@google.com>
1206 * symtab.c (lookup_static_symbol): Call the new function (and move
1207 it down to be next to lookup_global_symbol).
1208 (struct global_sym_lookup_data): Add block_enum member and rename to...
1209 (struct global_or_static_sym_lookup_data): ...this.
1210 (lookup_symbol_global_iterator_cb): Pass block_index instead of
1211 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1212 (lookup_symbol_global_or_static_iterator_cb): ...this.
1213 (lookup_global_or_static_symbol): New function.
1214 (lookup_global_symbol): Call new function.
1216 2019-08-26 Tom de Vries <tdevries@suse.de>
1219 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1220 when pc_probe.prob == NULL.
1222 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
1224 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1225 variable symbol_linkage to symbol_linkage_.
1227 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
1229 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1230 represent whether the symbol is static, dynamic, or we don't
1233 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
1235 * gdb/rx-tdep.c (rx_register_names): New.
1236 (rx_register_name): Delete.
1237 (rx_psw_type): Delete.
1238 (rx_fpsw_type): Delete.
1239 (rx_register_type): Delete.
1240 (rx_gdbarch_init): Convert target-descriptions.
1241 (_initialize_rx_tdep): Add initialize_tdesc_rx.
1242 * gdb/features/Makefile: Add rx.xml.
1243 * gdb/features/rx.xml: New.
1244 * gdb/features/rx.c: Generated.
1245 * gdb/NEWS: Mention target description support.
1247 2019-08-22 Christian Biesinger <cbiesinger@google.com>
1249 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1252 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
1254 * configure.ac: Don't check for 'dlfcn.h' (moved to
1255 gdbsupport/common.m4).
1256 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1258 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1259 * compile/compile-c-support.c: Include
1260 'gdbsupport/gdb-dlfcn.h'.
1261 * gdbsupport/common.m4: Check for 'dlfcn.h'.
1262 * gdb-dlfcn.c: Move to...
1263 * gdbsupport/gdb-dlfcn.c: ... here.
1264 * gdb-dlfcn.h: Move to...
1265 * gdbsupport/gdb-dlfcn.h: ... here.
1267 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
1269 * nios2-tdep.c (struct reg_value): Improve comments. Make
1270 the offset field signed.
1272 2019-08-22 Christian Biesinger <cbiesinger@google.com>
1274 * python/lib/gdb/__init__.py (_execute_file): New function.
1275 * python/python.c (python_run_simple_file): Call gdb._execute_file
1278 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
1280 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1281 all uses as this was never set to anything but a zero value.
1283 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
1285 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1287 2019-08-21 Christian Biesinger <cbiesinger@google.com>
1289 * tui/tui-data.h (tui_gen_win_info): Add an =default
1290 move constructor, required by some GCC versions.
1292 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
1294 * go32-nat.c (go32_sysinfo): Add hygon_p.
1296 2019-08-20 Tom Tromey <tom@tromey.com>
1298 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1299 line_from_reg_element_no, first_reg_element_no_inline,
1300 display_all_data, delete_data_content_windows,
1301 erase_data_content>: Now private.
1303 2019-08-20 Tom Tromey <tom@tromey.com>
1305 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1306 (tui_unhighlight_win, tui_highlight_win)
1307 (tui_win_info::make_window): Update.
1308 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1310 2019-08-20 Tom Tromey <tom@tromey.com>
1312 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1313 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1314 (MAX_PID_WIDTH): Move to tui-stack.c.
1315 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1316 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1317 (MAX_PID_WIDTH): Move from tui-data.h.
1319 2019-08-20 Tom Tromey <tom@tromey.com>
1321 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1322 * tui/tui-wingeneral.c (box_win): Change type of win_info.
1324 (tui_gen_win_info::make_window): Rename from tui_make_window.
1325 (tui_win_info::make_window): New method.
1326 (tui_gen_win_info::make_visible): Update.
1327 * tui/tui-source.c (tui_source_window::set_contents): Update.
1328 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1329 (tui_data_window::display_registers_from): Update.
1330 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1331 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1335 (struct tui_win_info) <make_window>: Declare.
1336 <can_box>: Now virtual.
1337 <title>: New member.
1338 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1339 * tui/tui-command.c (tui_cmd_window::resize): Update.
1341 2019-08-20 Tom Tromey <tom@tromey.com>
1343 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1344 * tui/tui-regs.c (tui_data_window::show_registers): Update.
1345 (tui_data_window::check_register_values): Update.
1347 2019-08-20 Tom Tromey <tom@tromey.com>
1349 * tui/tui-regs.h (struct tui_data_window): Use
1350 DISABLE_COPY_AND_ASSIGN.
1351 <regs_content>: Change type, removing unique_ptr.
1352 <tui_data_window>: Add move constructor.
1353 * tui/tui-regs.c (tui_data_window::show_registers)
1354 (tui_data_window::show_register_group)
1355 (tui_data_window::display_registers_from)
1356 (tui_data_window::display_registers_from)
1357 (tui_data_window::first_data_item_displayed)
1358 (tui_data_window::delete_data_content_windows)
1359 (tui_data_window::rerender, tui_data_window::refresh_window)
1360 (tui_data_window::check_register_values): Update.
1362 2019-08-20 Tom Tromey <tom@tromey.com>
1364 * tui/tui-regs.h (struct tui_data_window) <show_registers,
1365 show_register_group>: Declare.
1366 (tui_show_register_group): Don't declare.
1367 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1369 (tui_data_window::show_register_group): Rename from
1370 tui_show_register_group.
1371 (tui_data_window::check_register_values, tui_reg_command):
1373 * tui/tui-layout.c (tui_set_layout): Update.
1375 2019-08-20 Tom Tromey <tom@tromey.com>
1377 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1379 (tui_check_register_values): Don't declare.
1380 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1381 from tui_check_register_values.
1382 * tui/tui-hooks.c (tui_register_changed): Update.
1384 2019-08-20 Tom Tromey <tom@tromey.com>
1386 * tui/tui-regs.c (tui_reg_layout): Move later.
1387 (tui_show_registers): Don't enable TUI mode or change layout.
1389 2019-08-20 Tom Tromey <tom@tromey.com>
1391 * tui/tui-regs.h (struct tui_data_item_window)
1392 <~tui_data_item_window>: Remove.
1393 <content>: Now a unique_xmalloc_ptr.
1394 * tui/tui-regs.c (tui_register_format): Return a
1396 (tui_get_register): Update.
1397 (~tui_data_item_window): Remove.
1398 (tui_data_window::display_registers_from, tui_display_register):
1400 * tui/tui-io.h (tui_expand_tabs): Update.
1401 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1402 Remove "col" parameter.
1404 2019-08-20 Tom Tromey <tom@tromey.com>
1406 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1408 * tui/tui-regs.c (~tui_data_item_window): Update.
1410 2019-08-20 Tom Tromey <tom@tromey.com>
1412 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1415 2019-08-20 Tom Tromey <tom@tromey.com>
1417 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1419 2019-08-20 Tom Tromey <tom@tromey.com>
1421 * tui/tui-source.h (struct tui_source_window): Update.
1422 * tui/tui-regs.c (tui_show_registers): Update.
1423 * tui/tui-disasm.h (struct tui_disasm_window): Update.
1424 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1425 (NO_REGS_STRING): Remove defines.
1427 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
1429 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1430 unnecessary thread walk if remote doesn't support the packet.
1432 2019-08-19 Tom Tromey <tromey@adacore.com>
1434 * python/py-value.c (value_has_field): Fix indentation.
1436 2019-08-19 Tom Tromey <tromey@adacore.com>
1438 * printcmd.c (do_one_display, info_display_command): Update.
1439 * block.h (contained_in): Return bool. Add allow_nested
1441 * block.c (contained_in): Return bool. Add allow_nested
1444 2019-08-19 Tom Tromey <tom@tromey.com>
1446 * configure: Rebuild.
1447 * configure.ac: Disallow the combination of -static-libstdc++ and
1449 * source-cache.c (get_language_name): Handle rust.
1450 (source_cache::get_source_lines): Ignore highlighting exceptions.
1452 2019-08-16 Tom Tromey <tom@tromey.com>
1454 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1455 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1456 (struct tui_source_window_base) <make_visible, refresh_window,
1457 resize>: Remove methods.
1458 <execution_info>: Remove field.
1459 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1460 (tui_show_source_line, tui_source_window_base)
1461 (~tui_source_window_base): Update.
1462 (tui_source_window_base::resize)
1463 (tui_source_window_base::make_visible)
1464 (tui_source_window_base::refresh_window): Remove.
1465 (tui_source_window_base::update_exec_info): Update.
1466 * tui/tui-source.c (tui_source_window::set_contents): Update.
1467 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1469 2019-08-16 Tom Tromey <tom@tromey.com>
1471 * tui/tui-hooks.c (tui_remove_hooks): Don't set
1472 deprecated_query_hook.
1474 2019-08-16 Tom Tromey <tom@tromey.com>
1476 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1477 (tui_update_source_windows_with_line): Update.
1478 * tui/tui-source.h (struct tui_source_window)
1479 <show_symtab_source>: Declare.
1480 (tui_show_symtab_source): Don't declare.
1481 * tui/tui-source.c (tui_show_symtab_source): Rename from
1482 tui_show_symtab_source.
1484 2019-08-16 Tom Tromey <tom@tromey.com>
1486 * tui/tui-winsource.h (struct tui_source_window_base)
1487 <set_contents>: Declare.
1488 * tui/tui-winsource.c
1489 (tui_source_window_base::update_source_window_as_is): Update.
1490 * tui/tui-source.h (struct tui_source_window) <set_contents>:
1492 (tui_set_source_content): Don't declare.
1493 * tui/tui-source.c (tui_source_window::set_contents): Rename from
1494 tui_set_source_content.
1495 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1497 (tui_set_disassem_content): Don't declare.
1498 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1499 tui_set_disassem_content.
1501 2019-08-16 Tom Tromey <tom@tromey.com>
1503 * tui/tui-winsource.h (struct tui_source_window_base)
1504 <update_breakpoint_info>: Declare.
1505 (tui_update_breakpoint_info): Don't declare.
1506 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1507 (tui_update_all_breakpoint_info): Update.
1508 (tui_source_window_base::update_breakpoint_info): Rename from
1509 tui_update_breakpoint_info.
1510 (tui_source_window_base::update_exec_info): Update.
1512 2019-08-16 Tom Tromey <tom@tromey.com>
1514 * tui/tui-winsource.h (struct tui_source_window_base)
1515 <update_source_window>: Declare.
1516 (tui_update_source_window): Don't declare.
1517 * tui/tui-winsource.c
1518 (tui_source_window_base::update_source_window): Rename from
1519 tui_update_source_window.
1520 (tui_source_window_base::rerender): Update.
1521 * tui/tui-source.c (tui_source_window::maybe_update): Update.
1522 * tui/tui-disasm.c (tui_show_disassem)
1523 (tui_show_disassem_and_update_source)
1524 (tui_disasm_window::maybe_update): Update.
1526 2019-08-16 Tom Tromey <tom@tromey.com>
1528 * tui/tui-winsource.h (struct tui_source_window_base)
1529 <update_source_window_as_is>: Declare.
1530 (tui_update_source_window_as_is): Don't declare.
1531 * tui/tui-winsource.c (tui_update_source_window): Update
1532 (tui_source_window_base::update_source_window_as_is): Rename from
1533 tui_update_source_window_as_is.
1534 (tui_source_window_base::refill): Update.
1535 * tui/tui-source.c (tui_show_symtab_source): Update.
1536 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1539 2019-08-16 Tom Tromey <tom@tromey.com>
1541 * tui/tui-winsource.h (tui_update_source_window)
1542 (tui_update_source_window_as_is): Remove "noerror" parameter.
1543 * tui/tui-winsource.c (tui_update_source_window)
1544 (tui_update_source_window_as_is): Remove "noerror" parameter.
1545 (tui_update_source_windows_with_addr)
1546 (tui_update_source_windows_with_line)
1547 (tui_source_window_base::rerender)
1548 (tui_source_window_base::refill): Update.
1549 * tui/tui-source.h (tui_set_source_content)
1550 (tui_show_symtab_source): Remove "noerror" parameter.
1551 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1553 (tui_show_symtab_source): Likewise.
1554 (tui_source_window::maybe_update): Update.
1555 * tui/tui-disasm.c (tui_show_disassem)
1556 (tui_show_disassem_and_update_source)
1557 (tui_disasm_window::do_scroll_vertical)
1558 (tui_disasm_window::maybe_update): Update.
1560 2019-08-16 Tom Tromey <tom@tromey.com>
1562 * tui/tui.c (tui_is_window_visible): Update.
1563 * tui/tui-wingeneral.c (tui_make_window)
1564 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1565 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1566 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1567 (tui_set_win_height_command, parse_scrolling_args): Update.
1568 * tui/tui-source.c (tui_source_window::style_changed): Update.
1569 * tui/tui-regs.c (tui_show_registers)
1570 (tui_data_window::first_data_item_displayed)
1571 (tui_data_window::delete_data_content_windows)
1572 (tui_check_register_values, tui_reg_command): Update.
1573 * tui/tui-disasm.c (tui_show_disassem): Update.
1574 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1576 <is_visible>: Remove field.
1577 * tui/tui-data.c (tui_next_win, tui_prev_win)
1578 (tui_delete_invisible_windows): Update.
1580 2019-08-16 Tom Tromey <tom@tromey.com>
1582 * tui/tui-winsource.h (struct tui_source_window_base)
1583 <m_has_locator>: Remove.
1584 * tui/tui-layout.c (show_source_disasm_command, show_data)
1585 (show_source_or_disasm_and_command): Update.
1587 2019-08-16 Alan Hayward <alan.hayward@arm.com>
1589 * NEWS (Other MI changes): New subsection.
1590 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1591 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1592 * arch-utils.c (default_get_pc_address_flags): New function.
1593 * arch-utils.h (default_get_pc_address_flags): New declaration.
1594 * gdbarch.sh: Add get_pc_address_flags.
1595 * gdbarch.c: Regenerate.
1596 * gdbarch.h: Likewise.
1597 * stack.c (print_pc): New function.
1598 (print_frame_info) (print_frame): Call print_pc.
1600 2019-08-16 Tom de Vries <tdevries@suse.de>
1602 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1603 print_objfile_section_info.
1605 2019-08-15 Tom Tromey <tom@tromey.com>
1607 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1608 calling update_cmdwin_start_line.
1609 * tui/tui-winsource.h (struct tui_source_window_base)
1610 <do_make_visible_with_new_height, set_new_height>: Don't declare.
1611 <rerender>: Declare.
1612 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1614 (tui_source_window_base::set_new_height): Remove.
1615 (tui_source_window_base::rerender): Rename from
1616 do_make_visible_with_new_height.
1617 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1619 (tui_win_info::make_invisible_and_set_new_height)
1620 (tui_win_info::make_visible_with_new_height): Remove.
1621 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1623 * tui/tui-stack.c (tui_locator_window::rerender): New method.
1624 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1625 do_make_visible_with_new_height>: Don't declare.
1626 <rerender>: Declare.
1627 * tui/tui-regs.c (tui_data_window::rerender): Rename from
1629 (tui_data_window::do_make_visible_with_new_height): Remove.
1630 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1631 call tui_show_locator_content.
1632 (tui_gen_win_info::resize): Call rerender.
1633 (show_source_or_disasm_and_command): Don't call
1634 tui_show_locator_content.
1635 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1637 (struct tui_win_info) <rerender>: Declare.
1638 <set_new_height, make_invisible_and_set_new_height,
1639 make_visible_with_new_height>: Don't declare.
1640 * tui/tui-data.c (tui_win_list::rerender): New method.
1641 * tui/tui-command.h (struct tui_cmd_window)
1642 <do_make_visible_with_new_height>: Don't declare.
1644 (tui_cmd_window::do_make_visible_with_new_height): Remove.
1646 2019-08-15 Tom Tromey <tromey@adacore.com>
1648 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1649 * ada-lang.c (ada_enum_name): Likewise.
1651 2019-08-15 Christian Biesinger <cbiesinger@google.com>
1653 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1655 (GdbOutputErrorFile): Likewise.
1656 (global scope): Adjust constructor calls to GdbOutput{,Error}File
1658 (execute_unwinders): Rename to have a leading underscore.
1659 (auto_load_packages): Likewise.
1660 (global scope): Adjust call to auto_load_packages accordingly.
1661 (GdbSetPythonDirectory): Likewise.
1662 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1663 instead of execute_unwinders.
1665 2019-08-15 Tom Tromey <tom@tromey.com>
1667 * tui/tui-layout.c (show_layout, show_source_disasm_command)
1668 (show_data): Don't change window visibility.
1669 (tui_gen_win_info::resize): Remove special case for command
1670 window. Use wresize, when available.
1671 (show_source_or_disasm_and_command): Don't change window
1673 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1674 <make_visible>: New method.
1675 * tui/tui-command.c (tui_cmd_window::resize): New method.
1677 2019-08-15 Tom Tromey <tom@tromey.com>
1679 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1680 (struct tui_source_windows): New.
1681 * tui/tui-winsource.c (tui_display_main): Update.
1682 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1683 (new_height_ok, parse_scrolling_args): Update.
1684 * tui/tui-layout.c (show_layout, show_data): Update.
1685 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1686 (tui_add_to_source_windows): Don't declare.
1687 * tui/tui-data.c (source_windows, tui_source_windows)
1688 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1690 2019-08-15 Tom Tromey <tom@tromey.com>
1692 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1694 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1695 * tui/tui-layout.c (show_source_disasm_command, show_data):
1697 (tui_gen_win_info::resize): Rename.
1698 (show_source_or_disasm_and_command): Update.
1699 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1702 2019-08-15 Tom Tromey <tom@tromey.com>
1704 * tui/tui-stack.c (tui_initialize_static_data): Remove.
1705 * tui/tui-interp.c (tui_interp::init): Don't call
1706 tui_initialize_static_data.
1707 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1709 2019-08-15 Tom Tromey <tom@tromey.com>
1711 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1712 examine tui_win_list.
1714 2019-08-15 Tom Tromey <tom@tromey.com>
1716 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1717 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1718 tui_clear_source_content.
1719 (tui_clear_source_content): Remove.
1720 (tui_source_window_base::do_erase_source_content): Hoist call to
1722 * tui/tui-stack.c (tui_show_frame_info): Don't call
1723 tui_clear_source_content.
1725 2019-08-15 Tom Tromey <tom@tromey.com>
1727 * tui/tui-winsource.h (struct tui_source_window_base)
1728 <do_erase_source_content>: New method.
1729 <erase_source_content>: New method.
1730 (tui_erase_source_content): Don't declare.
1731 * tui/tui-winsource.c (tui_clear_source_content): Update.
1732 (tui_source_window_base::do_erase_source_content): Rename from
1733 tui_erase_source_content.
1734 (tui_source_window_base::show_source_content): Update.
1735 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1736 * tui/tui-source.h (struct tui_source_window)
1737 <erase_source_content>: New method.
1738 * tui/tui-disasm.h (struct tui_disasm_window)
1739 <erase_source_content>: New method.
1741 2019-08-15 Tom Tromey <tom@tromey.com>
1743 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1744 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1746 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1747 * tui/tui-source.c (tui_set_source_content): Update.
1748 * tui/tui-disasm.c (tui_set_disassem_content): Update.
1750 2019-08-15 Tom Tromey <tom@tromey.com>
1752 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1753 * tui/tui-winsource.c (tui_line_is_displayed): Move to
1755 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1757 * tui/tui-source.c (tui_source_window::line_is_displayed): New
1759 (tui_source_window::maybe_update): Update.
1761 2019-08-15 Tom Tromey <tom@tromey.com>
1763 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1764 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1766 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1768 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1770 (tui_disasm_window::maybe_update): Update.
1772 2019-08-15 Tom Tromey <tom@tromey.com>
1774 * tui/tui-winsource.h (struct tui_source_window_base)
1775 <maybe_update>: Declare.
1776 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1778 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1780 * tui/tui-source.c (tui_source_window::maybe_update): New method.
1781 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1783 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1785 2019-08-15 Tom Tromey <tom@tromey.com>
1787 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1789 2019-08-15 Tom Tromey <tom@tromey.com>
1791 * tui/tui-wingeneral.c: Include tui-stack.h.
1792 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1793 (struct tui_locator_window): Move from tui-data.h.
1794 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1795 (tui_initialize_static_data): Move from tui-data.c.
1796 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1797 (struct tui_locator_window): Move to tui-stack.c.
1798 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1799 (tui_initialize_static_data): Move to tui-stack.c.
1801 2019-08-15 Tom Tromey <tom@tromey.com>
1803 * tui/tui-layout.c (show_source_disasm_command)
1804 (show_source_or_disasm_and_command): Use make_visible method, not
1806 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1809 2019-08-15 Tom Tromey <tom@tromey.com>
1811 * tui/tui-wingeneral.h (tui_make_window): Update.
1812 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1814 (tui_gen_win_info::make_visible): Update.
1815 * tui/tui-regs.c (tui_data_window::display_registers_from):
1817 * tui/tui-layout.c (show_source_disasm_command)
1818 (show_source_or_disasm_and_command): Update.
1819 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1820 (enum tui_box): Remove.
1821 (struct tui_win_info) <can_box>: New method.
1822 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1825 2019-08-15 Tom de Vries <tdevries@suse.de>
1827 * linux-nat-trad.c: Include gdbarch.h.
1829 2019-08-14 Alan Hayward <alan.hayward@arm.com>
1831 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1834 2019-08-14 Tom Tromey <tromey@adacore.com>
1836 * darwin-nat.c: Include gdbarch.h.
1837 * darwin-nat-info.c: Include gdbarch.h.
1839 2019-08-13 Tom Tromey <tom@tromey.com>
1841 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1843 * tui/tui-data.c (tui_initialize_static_data): Update.
1845 2019-08-13 Tom Tromey <tom@tromey.com>
1847 * tui/tui-winsource.h (struct tui_exec_info_window)
1848 <~tui_exec_info_window, maybe_allocate_content, get_content,
1850 (struct tui_source_window_base) <set_exec_info_content,
1851 show_exec_info_content>: Don't declare.
1852 * tui/tui-winsource.c
1853 (tui_exec_info_window::maybe_allocate_content): Remove.
1854 (tui_source_window_base::update_exec_info): Rename from
1855 set_exec_info_content.
1856 (tui_source_window_base::show_exec_info_content)
1857 (tui_source_window_base::update_exec_info): Remove.
1859 2019-08-13 Tom Tromey <tom@tromey.com>
1861 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1863 * tui/tui-winsource.c (tui_update_source_window_as_is)
1864 (tui_update_source_windows_with_addr, tui_erase_source_content):
1866 (tui_clear_exec_info_content): Remove.
1868 2019-08-13 Tom Tromey <tom@tromey.com>
1870 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1872 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1873 call tui_erase_exec_info_content.
1874 (tui_clear_exec_info_content): Rename from
1875 tui_erase_exec_info_content.
1876 (tui_clear_exec_info_content): Delete.
1878 2019-08-13 Tom Tromey <tom@tromey.com>
1880 * tui/tui-winsource.h (struct tui_source_window_base)
1881 <show_exec_info_content>: Declare.
1882 (tui_show_exec_info_content): Don't declare.
1883 * tui/tui-winsource.c
1884 (tui_source_window_base::show_exec_info_content): Rename from
1885 tui_show_exec_info_content.
1886 (tui_source_window_base::update_exec_info): Update.
1888 2019-08-13 Tom Tromey <tom@tromey.com>
1890 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1891 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1892 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1893 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1894 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1895 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1898 2019-08-13 Tom Tromey <tom@tromey.com>
1900 * tui/tui-winsource.h (struct tui_source_window_base)
1901 <update_exec_info>: Declare.
1902 (tui_update_exec_info): Don't declare.
1903 * tui/tui-winsource.c (tui_update_source_window_as_is)
1904 (tui_source_window_base::refresh_all)
1905 (tui_update_all_breakpoint_info): Update.
1906 (tui_source_window_base::update_exec_info): Rename from
1907 tui_update_exec_info.
1908 * tui/tui-stack.c (tui_show_frame_info): Update.
1910 2019-08-13 Tom Tromey <tom@tromey.com>
1912 * tui/tui-winsource.h (struct tui_source_window_base)
1913 <set_exec_info_content>: Declare.
1914 (tui_set_exec_info_content): Don't declare.
1915 * tui/tui-winsource.c
1916 (tui_source_window_base::set_exec_info_content): Rename from
1917 tui_set_exec_info_content.
1918 (tui_update_exec_info): Update.
1920 2019-08-13 Tom Tromey <tom@tromey.com>
1922 * tui/tui-winsource.h (struct tui_source_window_base)
1923 <show_source_content>: Declare.
1924 (tui_show_source_content): Don't declare.
1925 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1926 (tui_source_window_base::show_source_content): Rename from
1927 tui_show_source_content.
1928 (tui_source_window_base::refresh_all): Update.
1929 * tui/tui-layout.c (show_source_disasm_command)
1930 (show_source_or_disasm_and_command): Update.
1932 2019-08-13 Tom Tromey <tom@tromey.com>
1934 * tui/tui-winsource.c (tui_erase_source_content)
1935 (tui_show_source_content, tui_source_window_base::refresh_all):
1937 * tui/tui-wingeneral.h
1938 (tui_check_and_display_highlight_if_needed): Don't declare.
1939 * tui/tui-wingeneral.c
1940 (tui_win_info::check_and_display_highlight_if_needed): Rename from
1941 check_and_display_highlight_if_needed.
1942 * tui/tui-win.c (tui_rehighlight_all)
1943 (tui_win_info::make_visible_with_new_height): Update.
1944 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1945 (tui_data_window::erase_data_content)
1946 (tui_data_window::display_all_data): Update.
1947 * tui/tui-data.h (struct tui_win_info)
1948 <check_and_display_highlight_if_needed>: Declare.
1950 2019-08-13 Tom Tromey <tom@tromey.com>
1952 * tui/tui-win.c (tui_resize_all): Call
1953 tui_delete_invisible_windows.
1954 * tui/tui-layout.c (show_layout): Call
1955 tui_delete_invisible_windows.
1956 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1957 * tui/tui-data.c (tui_delete_invisible_windows): New function.
1959 2019-08-13 Tom Tromey <tom@tromey.com>
1961 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
1962 tui_add_win_to_layout.
1964 2019-08-13 Tom Tromey <tom@tromey.com>
1966 * tui/tui-layout.h (tui_default_win_height): Don't declare.
1967 * tui/tui-layout.c (tui_default_win_height): Now static.
1969 2019-08-13 Tom Tromey <tom@tromey.com>
1971 * tui/tui-layout.c (show_layout): Unify all layout cases into a
1973 (show_source_disasm_command, show_source_or_disasm_and_command):
1974 Don't check current layout.
1976 2019-08-13 Tom Tromey <tom@tromey.com>
1978 * tui/tui-wingeneral.c (make_all_visible): Remove.
1979 (tui_make_all_invisible): Simplify.
1980 * tui/tui-layout.c (tui_make_all_invisible): Move from
1981 tui-wingeneral.c; simplify.
1982 (show_layout): Hoist call to tui_make_all_invisible.
1983 (show_data): Don't call tui_make_all_invisible.
1985 2019-08-13 Tom Tromey <tom@tromey.com>
1987 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1988 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1990 2019-08-13 Tom Tromey <tom@tromey.com>
1992 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1994 (show_source_disasm_command, show_data)
1995 (show_source_or_disasm_and_command): Don't use
1996 tui_set_current_layout_to.
1997 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1998 * tui/tui-data.c (current_layout, tui_current_layout): Move to
2000 (tui_set_current_layout_to): Remove.
2002 2019-08-13 Tom Tromey <tom@tromey.com>
2004 * tui/tui-layout.c (tui_set_layout): Update.
2005 * tui/tui-data.h (struct tui_layout_def): Remove.
2006 (tui_layout_def): Don't declare.
2007 * tui/tui-data.c (layout_def): Remove.
2008 (tui_layout_def): Remove.
2010 2019-08-13 Tom Tromey <tom@tromey.com>
2012 * tui/tui-winsource.h (struct tui_source_window_base)
2013 <clear_detail>: No longer "override".
2014 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2015 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2016 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2017 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2019 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2021 2019-08-13 Tom Tromey <tromey@adacore.com>
2023 * tracepoint.c: Don't include readline.h or history.h.
2025 2019-08-12 Tom Tromey <tom@tromey.com>
2027 * configure: Rebuild.
2028 * configure.ac: Check for readline 7.
2029 * NEWS: Mention readline 7 requirement.
2032 2019-08-12 Tom Tromey <tom@tromey.com>
2034 * mingw-hdep.c (gdb_select): Remove readline hack.
2036 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
2038 * blockframe.c (find_pc_partial_function): Set *block to nullptr
2039 when the function fails.
2041 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
2043 * s390-tdep.c (s390_type_align): New function.
2044 (s390_gdbarch_init): Set it as type_align gdbarch method.
2046 2019-08-09 Tom de Vries <tdevries@suse.de>
2049 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2050 pc_low with relocation offset.
2052 2019-08-07 Tom Tromey <tromey@adacore.com>
2054 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2055 (print_frame_args): Update.
2056 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2058 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2059 * frame.h (struct frame_arg): Add initializers.
2060 <error>: Now a unique_xmalloc_ptr.
2062 2019-08-07 Alan Hayward <alan.hayward@arm.com>
2064 * NEWS: Expand the Pointer Authentication entry.
2065 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2066 (aarch64_frame_unmask_lr): ... to this.
2067 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2068 Call aarch64_frame_unmask_lr.
2069 * frame.c (struct frame_info): Add "masked" variable.
2070 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2071 (fprint_frame): Check for masked pc.
2072 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2074 * python/py-framefilter.c (py_print_frame): Check for masked pc.
2075 * stack.c (print_frame): Check for masked pc.
2077 2019-08-06 Tom Tromey <tom@tromey.com>
2079 * stabsread.c (patch_block_stabs, read_one_struct_field)
2080 (read_enum_type): Use obstack_strndup.
2081 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2082 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2083 * dwarf2read.c (guess_full_die_structure_name)
2084 (anonymous_struct_prefix): Use obstack_strndup.
2085 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2086 * c-exp.y (yylex): Use obstack_strndup.
2087 * ada-exp.y (write_object_renaming, write_ambiguous_var)
2088 (write_var_or_type): Use obstack_strndup.
2090 2019-08-06 Tom Tromey <tom@tromey.com>
2092 * symfile.c (reread_symbols): Use obstack_strdup.
2093 * stabsread.c (read_type): Use obstack_strdup.
2094 * gdb_obstack.h (obstack_strdup): New overload.
2095 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2096 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2097 (dwarf2_canonicalize_name): Use obstack_strdup.
2098 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2099 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2102 2019-08-06 Tom Tromey <tom@tromey.com>
2104 * gdb_obstack.h (obstack_strdup): Define.
2105 * gdb_obstack.c (obstack_strdup): Don't define.
2107 2019-08-06 Tom Tromey <tom@tromey.com>
2109 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2111 * typeprint.c (typedef_hash_table::find_global_typedef): Use
2113 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2114 * stabsread.c (common_block_start): Use obstack_strdup.
2115 * objfiles.c (set_objfile_main_name, objfile): Use
2117 * namespace.c (add_using_directive): Use obstack_strdup.
2118 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2119 * jit.c (finalize_symtab): Use obstack_strdup.
2120 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2121 (guess_partial_die_structure_name, partial_die_info::fixup)
2122 (dwarf2_name): Use obstack_strdup.
2123 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2125 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2126 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2128 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2130 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2132 * unittests/help-doc-selftests.c: New file.
2133 * Makefile.in: Add the new file.
2135 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2137 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2138 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
2139 the full first line, except when FOR_VALUE_PREFIX. In this case,
2140 the trailing '.' is not output, and the first character is uppercased.
2141 (print_help_for_command): Update call to print_doc_line.
2142 (print_doc_of_command): Likewise.
2143 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2144 * cli/cli-option.c (append_indented_doc): Do not append newline.
2145 (build_help_option): Append newline after first appended_indented_doc
2146 only if a second call is done.
2147 (build_help): Append 2 new lines before each option, except the first
2149 * compile/compile.c (_initialize_compile): Add new lines after
2150 %OPTIONS%, when not at the end of the help.
2151 Change help doc or code
2152 producing the help doc to respect the invariants.
2153 * maint-test-options.c (_initialize_maint_test_options): Likewise.
2154 Also removed the new line after 'Options:', as all other commands
2155 do not put an empty line between 'Options:' and the first option.
2156 * printcmd.c (_initialize_printcmd): Likewise.
2157 * stack.c (_initialize_stack): Likewise.
2158 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2159 incorrectly telling COMMAND is optional.
2160 * ada-lang.c (_initialize_ada_language): Change help doc or code
2161 producing the help doc to respect the invariants.
2162 * ada-tasks.c (_initialize_ada_tasks): Likewise.
2163 * breakpoint.c (_initialize_breakpoint): Likewise.
2164 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2165 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2166 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2167 * cli/cli-style.c (cli_style_option::add_setshow_commands,
2168 _initialize_cli_style): Likewise.
2169 * corelow.c (core_target_info): Likewise.
2170 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2171 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2172 * filesystem.c (_initialize_filesystem): Likewise.
2173 * frame.c (_initialize_frame): Likewise.
2174 * gnu-nat.c (add_task_commands): Likewise.
2175 * infcall.c (_initialize_infcall): Likewise.
2176 * infcmd.c (_initialize_infcmd): Likewise.
2177 * interps.c (_initialize_interpreter): Likewise.
2178 * language.c (_initialize_language): Likewise.
2179 * linux-fork.c (_initialize_linux_fork): Likewise.
2180 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2181 * maint.c (_initialize_maint_cmds): Likewise.
2182 * memattr.c (_initialize_mem): Likewise.
2183 * printcmd.c (_initialize_printcmd): Likewise.
2184 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2186 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2187 * record-btrace.c (_initialize_record_btrace): Likewise.
2188 * record-full.c (_initialize_record_full): Likewise.
2189 * record.c (_initialize_record): Likewise.
2190 * regcache-dump.c (_initialize_regcache_dump): Likewise.
2191 * regcache.c (_initialize_regcache): Likewise.
2192 * remote.c (add_packet_config_cmd, init_remote_threadtests,
2193 _initialize_remote): Likewise.
2194 * ser-tcp.c (_initialize_ser_tcp): Likewise.
2195 * serial.c (_initialize_serial): Likewise.
2196 * skip.c (_initialize_step_skip): Likewise.
2197 * source.c (_initialize_source): Likewise.
2198 * stack.c (_initialize_stack): Likewise.
2199 * symfile.c (_initialize_symfile): Likewise.
2200 * symtab.c (_initialize_symtab): Likewise.
2201 * target-descriptions.c (_initialize_target_descriptions): Likewise.
2202 * top.c (init_main): Likewise.
2203 * tracefile-tfile.c (tfile_target_info): Likewise.
2204 * tracepoint.c (_initialize_tracepoint): Likewise.
2205 * tui/tui-win.c (_initialize_tui_win): Likewise.
2206 * utils.c (add_internal_problem_command): Likewise.
2207 * valprint.c (value_print_option_defs): Likewise.
2209 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
2212 * configure.ac: Drop enable-libmcheck support.
2213 * configure, config.in: Rebuild.
2214 * libmcheck.m4: Remove.
2215 * acinclude.m4: Don't include it.
2216 * Makefile.in: Don't distribute it.
2217 * top.c (print_gdb_configuration): Don't mention it.
2219 2019-08-06 Tom Tromey <tom@tromey.com>
2221 * utils.c (set_output_style): Sometimes pass stream to
2223 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2224 * record-btrace.c (btrace_insn_history): Update.
2225 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2227 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2228 Update initializers.
2229 <m_uiout>: New field.
2231 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2232 Remove "uiout" parameter.
2233 (dump_insns): Update.
2234 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2235 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2237 2019-08-06 Christian Biesinger <cbiesinger@google.com>
2239 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2240 (error_in_psymtab_expansion): Likewise.
2241 (lookup_symbol_via_quick_fns): Likewise.
2242 (basic_lookup_transparent_type_quick): Likewise.
2243 (basic_lookup_transparent_type_1): Likewise.
2245 2019-08-06 Tom Tromey <tromey@adacore.com>
2247 * source.c (last_source_error): Now bool.
2248 (print_source_lines_base): Make "noprint" bool. Only open
2249 source file when last_source_visited changes.
2251 2019-08-06 Tom Tromey <tromey@adacore.com>
2253 * annotate.c (annotate_source_line): Use g_source_cache.
2254 * source-cache.c (source_cache::get_plain_source_lines): Change
2255 parameters. Populate m_offset_cache.
2256 (source_cache::ensure): New method.
2257 (source_cache::get_line_charpos): New method.
2258 (extract_lines): Move lower. Change parameters.
2259 (source_cache::get_source_lines): Move lower.
2260 * source-cache.h (class source_cache): Update comment.
2261 <get_line_charpos>: New method.
2262 <get_source_lines>: Update comment.
2263 <clear>: Clear m_offset_cache.
2264 <get_plain_source_lines>: Change parameters.
2265 <ensure>: New method
2266 <m_offset_cache>: New member.
2267 * source.c (forget_cached_source_info_for_objfile): Update.
2268 (info_source_command): Use g_source_cache.
2269 (find_source_lines, open_source_file_with_line_charpos): Remove.
2270 (print_source_lines_base, search_command_helper): Use g_source_cache.
2271 * source.h (open_source_file_with_line_charpos): Don't declare.
2272 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2273 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2276 2019-08-06 Tom Tromey <tromey@adacore.com>
2278 * source-cache.c (source_cache::get_plain_source_lines):
2279 Remove "first_line" and "last_line" parameters.
2280 (source_cache::get_source_lines): Cache plain text.
2281 * source-cache.h (class source_cache)
2282 <get_plain_source_lines>: Update.
2284 2019-08-06 Tom Tromey <tromey@adacore.com>
2286 * source-cache.c (extract_lines): No longer a method.
2287 Changed type of parameter. Include final newline.
2288 (selftests::extract_lines_test): New function.
2289 (_initialize_source_cache): Likewise.
2290 * source-cache.h (class source_cache)
2291 <extract_lines>: Don't declare.
2293 2019-08-06 Tom Tromey <tromey@adacore.com>
2295 * breakpoint.c (init_breakpoint_sal): Update.
2296 (breakpoint): Update.
2297 * breakpoint.h (struct breakpoint) <filter>: Now a
2300 2019-08-05 Christian Biesinger <cbiesinger@google.com>
2302 * NEWS: Mention dictionary access on blocks.
2303 * python/py-block.c (blpy_getitem): New function.
2304 (block_object_as_mapping): New struct.
2305 (block_object_type): Use new struct for tp_as_mapping field.
2307 2019-08-05 Christian Biesinger <cbiesinger@google.com>
2309 * objfiles.h (objfile): Add a comment describing partial symbols.
2311 2019-08-05 Tom Tromey <tromey@adacore.com>
2313 * compile/compile.c (_initialize_compile): Use _(), not N_().
2314 * thread.c (_initialize_thread): Use _(), not N_().
2315 * stack.c (_initialize_stack): Use _(), not N_().
2316 * printcmd.c (_initialize_printcmd): Use _(), not N_().
2318 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
2320 * dwarf2read.c (struct dw2_symtab_iterator):
2321 <want_specific_block>: Remove.
2322 <block_index>: Change type to gdb::optional.
2323 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2324 change type of BLOCK_INDEX parameter to gdb::optional.
2325 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2326 (dw2_lookup_symbol): Don't pass argument for
2327 WANT_SPECIFIC_BLOCK.
2328 (dw2_expand_symtabs_for_function): Don't pass argument for
2329 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2330 (class dw2_debug_names_iterator)
2331 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2332 parameter, change BLOCK_INDEX type to gdb::optional.
2333 <m_want_specific_block>: Remove.
2334 <m_block_index>: Change type to gdb::optional.
2335 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2336 gdb::optional. Re-write in function of gdb::optional.
2337 (dw2_debug_names_lookup_symbol): Don't pass argument for
2338 WANT_SPECIFIC_BLOCK.
2339 (dw2_debug_names_expand_symtabs_for_function): Don't pass
2340 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2343 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2345 * NEWS: Mention changes to "info sources" command.
2347 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2349 * symtab.c (filename_partial_match_opts): New struct type.
2350 (struct output_source_filename_data): New members
2351 regexp, c_regexp, partial_match.
2352 (output_source_filename): Use new members to decide to print file.
2353 (info_sources_option_defs): New variable.
2354 (make_info_sources_options_def_group, print_info_sources_header,
2355 info_sources_command_completer):
2357 (info_sources_command): Read new optional arguments.
2358 (_initialize_symtab): Update info sources help.
2360 2019-08-02 Alexandre Oliva <oliva@adacore.com>
2362 * ada-lang.c (exception_support_info_v0): Renamed from...
2363 (default_exception_support_info): ... this. Create new
2365 (ada_has_this_exception_support): Look up catch_handlers_sym.
2366 (ada_exception_support_info_sniffer): Try v0 after default.
2368 2019-08-01 Tom Tromey <tromey@adacore.com>
2370 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2373 2019-08-01 Christian Biesinger <cbiesinger@google.com>
2375 * s12z-tdep.c: Fix include path for s12z-opc.h.
2377 2019-08-01 Alan Hayward <alan.hayward@arm.com>
2379 * NEWS: Require GNU make 3.82.
2381 2019-07-16 Tom Tromey <tom@tromey.com>
2383 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2386 2019-07-30 Tom Tromey <tromey@adacore.com>
2388 * block.c (contained_in): Remove BLOCK_FUNCTION check.
2390 2019-07-30 Kevin Buettner <kevinb@redhat.com>
2392 * printcmd.c (print_address_symbolic): Print negative offsets.
2393 (build_address_symbolic): Force signed arithmetic when computing
2396 2019-07-30 Christian Biesinger <cbiesinger@google.com>
2398 PR/24474: Add a function to lookup static variables.
2399 * NEWS: Mention this new function.
2400 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2401 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2402 * python/python.c (python_GdbMethods): Add new function.
2404 2019-07-29 Christian Biesinger <cbiesinger@google.com>
2406 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2407 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2408 (objfpy_lookup_static_symbol): New function.
2409 (objfile_object_methods): Add new functions.
2411 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2413 * NEWS: Mention 'set|show print frame-info'. Mention new
2414 'presence' value for 'frame-arguments'. Mention new '-frame-info'
2415 backtrace argument. Mention that python frame filtering code
2416 is now consistent with what 'backtrace' command prints.
2418 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2420 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2422 (print_frame_info_auto, print_frame_info_source_line,
2423 print_frame_info_location, print_frame_info_source_and_location,
2424 print_frame_info_location_and_address, print_frame_info_short_location):
2426 (struct frame_print_options): New member print_frame_info.
2427 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2428 * stack.h (get_user_print_what_frame_info): New declaration.
2429 (frame_show_address): New declaration.
2430 * stack.c (print_frame_arguments_choices): New value 'presence'.
2431 (print_frame_info_auto, print_frame_info_source_line,
2432 print_frame_info_location, print_frame_info_source_and_location,
2433 print_frame_info_location_and_address, print_frame_info_short_location,
2434 print_frame_info_choices, print_frame_info_print_what): New definitions.
2435 (print_frame_args): Only print dots for args if print frame-arguments
2437 (frame_print_option_defs): New element for "frame-info".
2438 (get_user_print_what_frame_info): New function.
2439 (frame_show_address): Make non static. Move comment to stack.h.
2440 (print_frame_info_to_print_what): New function.
2441 (print_frame_info): Update comment. Use fp_opts.print_frame_info
2442 to decide what to print.
2443 (backtrace_command_1): Handle the new print_frame_arguments_presence
2445 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2446 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2447 (py_print_frame): In non-mi mode, use LOCATION as default for
2448 print_what, similarly to frame information printed directly by
2449 backtrace command. Handle frame-info user option in non MI mode.
2451 2019-07-27 Kevin Buettner <kevinb@redhat.com>
2453 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2454 Add case for debugging 32-bit target on 64-bit host. Revise
2457 2019-07-27 Kevin Buettner <kevinb@redhat.com>
2459 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2460 instead of find_function_entry_range_from_pc.
2462 2019-07-27 Kevin Buettner <kevinb@redhat.com>
2464 * stack.c (find_frame_funname): Remove code which preferred
2465 minsym over symtab sym in "certain pathological cases".
2467 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2468 parameter. Change type of "do_demangle" to bool.
2469 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2470 Pass suitable "prefer_sym_over_minsym" flag to
2471 build_address_symbolic(). Don't output "+" for negative offsets.
2472 * printcmd.c (print_address_symbolic): Update invocation of
2473 build_address_symbolic to include a "prefer_sym_over_minsym"
2475 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2476 Restrict cases in which use of minimal symbol is preferred to that
2477 of a found symbol. Update comments.
2479 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2480 for entry pc when entry pc is out of range for that FDE.
2482 2019-07-26 Brian Callahan <bcallah@openbsd.org>
2485 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2488 2019-07-25 Christian Biesinger <cbiesinger@google.com>
2490 * python/py-objfile.c (add_separate_debug_file): Fix comment about
2491 this function's Python signature.
2494 2019-07-24 Christian Biesinger <cbiesinger@google.com>
2496 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2497 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2498 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2499 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2500 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2503 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
2505 * h8300-tdep.c (h8300_register_name_common): New.
2506 h8300_register_name): Use h8300_register_name_common.
2507 (h8300s_register_name): Likewise.
2508 (h8300sx_register_name): Likewise.
2509 (h8300h_register_nam): New.
2510 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2513 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
2515 * arm-tdep.c (arm_skip_cmse_entry): New function.
2516 (arm_is_sgstubs_section): New function.
2517 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2519 2019-07-22 Tom Tromey <tom@tromey.com>
2521 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2524 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2526 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2529 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2531 * symtab.c (search_symbols): Adjust msymbol matching type arrays
2532 so that GDB doesn't match any msymbols when searching in the
2534 (print_symbol_info): Print using typedef_print or type_print based
2535 on the type of the symbol. Add updated FIXME comment moved from...
2536 (_initialize_symtab): ... move and update FIXME comment to above.
2538 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2540 * NEWS: Mention adding -q option to "info types".
2541 * symtab.c (struct info_types_options): New struct.
2542 (info_types_options_defs): New variable.
2543 (make_info_types_options_def_group): New function.
2544 (info_types_command): Use gdb::option framework to parse options.
2545 (info_types_command_completer): New function.
2546 (_initialize_symtab): Extend the help text on "info types" and
2547 register command completer.
2549 2019-07-21 Christian Biesinger <cbiesinger@google.com>
2551 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2552 (lookup_symbol_in_objfile): Change int to block_enum and add a
2553 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2555 2019-07-20 Christian Biesinger <cbiesinger@google.com>
2557 * MAINTAINERS (Write After Approval): Add self.
2559 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
2561 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2562 instruction to the dummy code region.
2564 2019-07-19 Tom Tromey <tromey@adacore.com>
2566 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2567 (ARGSUSED, PARAMS, __func__): Remove rules.
2569 2019-07-19 Alan Hayward <alan.hayward@arm.com>
2571 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2572 * features/arm/arm-with-iwmmxt.c: Remove.
2573 * features/arm/arm-with-iwmmxt.xml: Remove.
2574 * features/arm/arm-with-m-fpa-layout.c: Remove.
2575 * features/arm/arm-with-m-fpa-layout.xml: Remove.
2576 * features/arm/arm-with-m-vfp-d16.c: Remove.
2577 * features/arm/arm-with-m-vfp-d16.xml: Remove.
2578 * features/arm/arm-with-m.c: Remove.
2579 * features/arm/arm-with-m.xml: Remove.
2580 * features/arm/arm-with-neon.c: Remove.
2581 * features/arm/arm-with-neon.xml: Remove.
2582 * features/arm/arm-with-vfpv2.c: Remove.
2583 * features/arm/arm-with-vfpv2.xml: Remove.
2584 * features/arm/arm-with-vfpv3.c: Remove.
2585 * features/arm/arm-with-vfpv3.xml: Remove.
2587 2019-07-19 Alan Hayward <alan.hayward@arm.com>
2589 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2591 2019-07-19 Alan Hayward <alan.hayward@arm.com>
2593 * arch/aarch32.c (aarch32_create_target_description): Create
2594 target descriptions using features.
2595 * arch/arm.c (arm_create_target_description)
2596 (arm_create_mprofile_target_description): Likewise.
2597 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2599 2019-07-19 Alan Hayward <alan.hayward@arm.com>
2601 * Makefile.in: Add new files.
2602 * aarch32-tdep.c: New file.
2603 * aarch32-tdep.h: New file.
2604 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2605 Call aarch32_read_description.
2606 * arch/aarch32.c: New file.
2607 * arch/aarch32.h: New file.
2608 * arch/arm.c (arm_create_target_description)
2609 (arm_create_mprofile_target_description): New function.
2610 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2611 (arm_create_target_description)
2612 (arm_create_mprofile_target_description): New declaration.
2613 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2614 read_description functions.
2615 * arm-linux-nat.c (arm_linux_nat_target::read_description):
2617 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2618 * arm-tdep.c (tdesc_arm_list): New variable.
2619 (arm_register_g_packet_guesses): Call create description functions.
2620 (arm_read_description) (arm_read_mprofile_description): New
2622 * arm-tdep.h (arm_read_description)
2623 (arm_read_mprofile_description): Add declaration.
2624 * configure.tgt: Add new files.
2626 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
2628 * top.c (new_ui_command): Open specified terminal just once.
2630 2019-07-18 Tom Tromey <tromey@adacore.com>
2632 * symtab.c (main_name): Constify return type.
2633 * symfile.c (set_initial_language): Update.
2634 * symtab.h (main_name): Constify return type.
2636 2019-07-17 Tom Tromey <tom@tromey.com>
2638 * tui/tui-winsource.c (tui_update_source_window)
2639 (tui_update_source_window_as_is)
2640 (tui_update_source_windows_with_line): Remove return.
2641 * tui/tui-disasm.c (tui_show_disassem)
2642 (tui_show_disassem_and_update_source): Remove return.
2643 * tui/tui.c (tui_reset): Remove return.
2644 * tui/tui-wingeneral.c
2645 (tui_check_and_display_highlight_if_needed): Remove return.
2647 2019-07-17 Tom Tromey <tom@tromey.com>
2649 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2651 2019-07-17 Tom Tromey <tom@tromey.com>
2653 * tui/tui-winsource.h (struct tui_exec_info_window)
2654 (struct tui_source_window_base): Move from tui-data.h.
2655 * tui/tui-winsource.c: Move many method definitions from
2656 elsewhere. Remove "structuring" comments.
2657 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2658 (tui_source_window_base::refresh_window): Move to
2660 * tui/tui-win.c (tui_source_window_base::refresh_all)
2661 (tui_source_window_base::update_tab_width)
2662 (tui_source_window_base::set_new_height)
2663 (tui_source_window_base::do_make_visible_with_new_height): Move to
2665 * tui/tui-source.h: Update.
2666 * tui/tui-source.c (tui_source_window_base::reset): Move to
2668 * tui/tui-disasm.h: Update.
2669 * tui/tui-data.h (struct tui_exec_info_window): Move to
2671 (struct tui_source_window_base): Likewise.
2672 * tui/tui-data.c (tui_source_window_base::clear_detail)
2673 (tui_source_window_base, ~tui_source_window_base): Move to
2676 2019-07-17 Tom Tromey <tom@tromey.com>
2678 * tui/tui-win.c (tui_resize_all)
2679 (tui_source_window_base::update_tab_width)
2680 (tui_adjust_win_heights): Update.
2681 (tui_win_info::make_invisible_and_set_new_height): Rename from
2682 make_invisible_and_set_new_height.
2683 * tui/tui-data.h (struct tui_win_info)
2684 <make_invisible_and_set_new_height>: New method.
2686 2019-07-17 Tom Tromey <tom@tromey.com>
2688 * tui/tui.c: Update.
2689 * tui/tui-source.h (struct tui_source_window): Move from
2691 * tui/tui-layout.c: Update.
2692 * tui/tui-disasm.c: Update.
2693 * tui/tui-data.h (struct tui_source_window): Move to
2696 2019-07-17 Tom Tromey <tom@tromey.com>
2698 * tui/tui-disasm.h (struct tui_disasm_window): Move from
2700 * tui/tui-data.h (struct tui_disasm_window): Move to
2703 2019-07-17 Tom Tromey <tom@tromey.com>
2705 * tui/tui-regs.h (struct tui_data_item_window): Move from
2707 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2708 * tui/tui-data.h (struct tui_data_item_window): Move to
2710 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2712 2019-07-17 Tom Tromey <tom@tromey.com>
2714 * tui/tui.c: Update.
2715 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2716 (tui_cmd_window::max_height): Move to tui-command.c.
2717 * tui/tui-layout.c: Update.
2718 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2719 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2721 * tui/tui-command.h (struct tui_cmd_window): Move from
2723 * tui/tui-command.c: Remove "structuring" comments.
2724 (tui_cmd_window::clear_detail)
2725 (tui_cmd_window::do_make_visible_with_new_height)
2726 (tui_cmd_window::max_height): Move from elsewhere.
2728 2019-07-17 Tom Tromey <tom@tromey.com>
2730 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2732 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2733 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2735 2019-07-17 Tom Tromey <tom@tromey.com>
2737 * tui/tui.c: Update.
2738 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2740 * tui/tui-windata.h: Remove file.
2741 * tui/tui-windata.c: Remove file.
2742 * tui/tui-win.c (tui_data_window::set_new_height)
2743 (tui_data_window::do_make_visible_with_new_height): Move to
2745 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2746 * tui/tui-regs.c: Remove "structuring" comments.
2747 (tui_data_window::first_data_item_displayed)
2748 (tui_data_window::delete_data_content_windows)
2749 (tui_data_window::erase_data_content)
2750 (tui_data_window::display_all_data)
2751 (tui_data_window::refresh_all)
2752 (tui_data_window::do_scroll_vertical)
2753 (tui_data_window::clear_detail, tui_data_window::set_new_height)
2754 (tui_data_window::do_make_visible_with_new_height)
2755 (tui_data_window::refresh_window): Move from elsewhere.
2756 (_initialize_tui_regs): Move to end of file.
2757 * tui/tui-layout.c: Update.
2758 * tui/tui-hooks.c: Update.
2759 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2760 * tui/tui-data.c (tui_data_window::clear_detail): Move to
2762 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2764 2019-07-17 Tom Tromey <tom@tromey.com>
2766 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2769 2019-07-17 Tom Tromey <tom@tromey.com>
2771 * tui/tui-win.c (tui_source_window_base::set_new_height)
2772 (tui_source_window_base::do_make_visible_with_new_height): Use
2773 m_has_locator field directly.
2774 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2776 (struct tui_source_window_base) <has_locator>: Likewise.
2778 2019-07-17 Tom Tromey <tom@tromey.com>
2780 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2782 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2784 * tui/tui-win.c (tui_source_window_base::set_new_height)
2785 (tui_source_window_base::set_new_height)
2786 (make_invisible_and_set_new_height)
2787 (tui_source_window_base::do_make_visible_with_new_height)
2788 (tui_source_window_base::do_make_visible_with_new_height):
2790 * tui/tui-layout.c (show_source_disasm_command, show_data)
2791 (show_source_or_disasm_and_command): Update.
2792 * tui/tui-layout.c (show_layout): Update.
2794 2019-07-17 Tom Tromey <tom@tromey.com>
2796 * tui/tui-layout.c (make_data_window): Remove.
2797 (show_data): Unify creation and re-initialization cases.
2799 2019-07-17 Tom Tromey <tom@tromey.com>
2801 * tui/tui-layout.c (make_source_window, make_disasm_window):
2803 (show_data): Unify creation and re-initialization cases.
2805 2019-07-17 Tom Tromey <tom@tromey.com>
2807 * tui/tui-layout.c (make_command_window): Remove.
2808 (show_source_disasm_command, show_source_or_disasm_and_command):
2809 Unify creation and re-initialization cases.
2811 2019-07-17 Tom Tromey <tom@tromey.com>
2813 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2814 creation and re-initialization cases.
2816 2019-07-17 Tom Tromey <tom@tromey.com>
2818 * tui/tui-regs.c (tui_get_register): Return void.
2820 2019-07-17 Tom Tromey <tom@tromey.com>
2822 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2825 2019-07-17 Tom Tromey <tom@tromey.com>
2827 * tui/tui-layout.c (show_source_disasm_command): Simplify window
2830 2019-07-17 Tom Tromey <tom@tromey.com>
2832 * tui/tui.h (tui_set_layout_by_name): Don't declare.
2833 * tui/tui-regs.c (tui_reg_layout): New function.
2834 (tui_show_registers, tui_reg_command): Use it.
2835 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2836 (tui_layout_command): Rename from tui_set_layout_by_name. Change
2838 (tui_layout_command): Remove.
2840 2019-07-17 Tom Tromey <tom@tromey.com>
2842 * tui/tui-layout.h (tui/tui-layout): Return void.
2843 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
2845 2019-07-17 Tom Tromey <tom@tromey.com>
2847 * tui/tui-layout.c (show_source_disasm_command, show_data):
2849 (reset_locator): Remove.
2850 (show_source_or_disasm_and_command): Update.
2852 2019-07-17 Tom Tromey <tom@tromey.com>
2854 * tui/tui-source.c (tui_source_window_base::reset): Remove
2856 * tui/tui-layout.c (make_command_window, make_source_window)
2857 (make_disasm_window, make_data_window)
2858 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2859 (reset_locator, show_source_or_disasm_and_command): Update.
2860 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2862 (struct tui_source_window_base) <reset>: Likewise.
2864 2019-07-17 Tom Tromey <tom@tromey.com>
2866 * tui/tui-layout.c (show_source_disasm_command): Use
2868 (reset_locator): New function.
2869 (init_and_make_win): Remove.
2870 (show_source_or_disasm_and_command): Use reset_locator.
2872 2019-07-17 Tom Tromey <tom@tromey.com>
2874 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2876 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2878 * tui/tui-source.c (tui_source_window_base::reset): New method.
2879 * tui/tui-layout.c (make_command_window): Don't call
2881 (make_source_window, make_disasm_window): Don't call
2882 make_source_or_disasm_window.
2883 (make_data_window): Don't call init_and_make_win. Change calling
2885 (show_source_disasm_command, show_data): Simplify.
2886 (make_source_or_disasm_window): Remove.
2887 (show_source_or_disasm_and_command): Simplify.
2888 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2889 (struct tui_source_window_base) <reset>: Likewise.
2890 <execution_info>: Remove initializer.
2891 * tui/tui-data.c (tui_source_window_base): Initialize
2894 2019-07-17 Tom Tromey <tom@tromey.com>
2896 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2899 2019-07-17 Tom Tromey <tom@tromey.com>
2901 * tui/tui.c (tui_rl_other_window): Update.
2902 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2903 superclass method first. Always iterate over regs_content.
2904 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2906 * tui/tui-win.c (tui_set_focus_command): Update.
2908 2019-07-17 Tom Tromey <tom@tromey.com>
2910 * tui/tui-win.c (tui_set_focus_command): Rename from
2911 tui_set_focus. Call tui_enable.
2912 (tui_set_focus_command): Remove.
2914 2019-07-17 Tom Tromey <tom@tromey.com>
2916 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2918 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2920 (tui_data_window::refresh_window): Call refresh_window on data
2921 items. Always call superclass refresh_window.
2922 (tui_win_info::refresh): Remove.
2923 (tui_source_window_base::refresh_window): Update.
2924 (tui_refresh_all): Update.
2925 * tui/tui-layout.c (show_source_disasm_command): Remove call to
2927 (show_source_or_disasm_and_command): Likewise.
2928 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2929 (struct tui_source_window_base) <refresh>: Likewise.
2931 2019-07-17 Tom Tromey <tom@tromey.com>
2933 * tui/tui-winsource.c (tui_clear_source_content)
2934 (tui_show_source_content): Update.
2935 * tui/tui-source.c (tui_source_window::showing_source_p): Check
2936 whether content is empty.
2937 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2940 2019-07-17 Tom Tromey <tom@tromey.com>
2942 * tui/tui-winsource.c (tui_erase_source_content): Clear the
2944 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2945 * tui/tui-source.c (tui_set_source_content_nil): Remove.
2947 2019-07-17 Tom Tromey <tom@tromey.com>
2949 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2950 (struct tui_data_item_window): Update.
2952 2019-07-17 Tom Tromey <tom@tromey.com>
2954 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2955 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2958 2019-07-17 Tom Tromey <tom@tromey.com>
2960 * tui/tui-winsource.h (tui_erase_source_content)
2961 (tui_clear_source_content): Remove "display_prompt" parameter.
2962 * tui/tui-winsource.c (tui_update_source_window_as_is)
2963 (tui_update_source_windows_with_addr): Update.
2964 (tui_clear_source_content): Remove "display_prompt" parameter.
2965 (tui_erase_source_content): Likewise. Simplify.
2966 (tui_show_source_content): Update.
2967 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2968 * tui/tui-stack.c (tui_show_frame_info): Update.
2969 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2972 2019-07-17 Tom Tromey <tom@tromey.com>
2974 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2975 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2977 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2980 2019-07-17 Tom Tromey <tom@tromey.com>
2982 * tui/tui-winsource.c (tui_clear_source_content)
2983 (tui_show_source_content, tui_show_exec_info_content)
2984 (tui_clear_exec_info_content): Update.
2985 * tui/tui-stack.c (tui_show_locator_content): Update.
2986 (tui_show_frame_info): Update.
2987 * tui/tui-source.h (tui_source_window): Don't declare.
2988 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2989 from tui_source_is_displayed.
2990 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2992 (struct tui_source_window_base) <content_in_use>: New field. Now
2994 (struct tui_source_window) <showing_source_p>: New method.
2995 (TUI_SRC_WIN): Change cast.
2996 * tui/tui-data.c (tui_initialize_static_data): Update.
2998 2019-07-17 Tom Tromey <tom@tromey.com>
3000 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3002 * tui/tui-source.c (tui_source_window::location_matches_p): New
3004 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3006 * tui/tui-data.h (struct tui_source_window_base)
3007 <location_matches_p>: New method.
3008 (struct tui_source_window, struct tui_disasm_window)
3009 <location_matches_p>: Likewise.
3011 2019-07-17 Tom Tromey <tom@tromey.com>
3013 * tui/tui-win.c (tui_set_win_height_command): Rename from
3015 (tui_set_win_height_command): Remove.
3017 2019-07-17 Tom Tromey <tom@tromey.com>
3019 * tui/tui-source.c (tui_source_window): New constructor. Add
3021 (~tui_source_window): New destructor.
3022 (tui_source_window::style_changed): New method.
3023 * tui/tui-hooks.c (tui_redisplay_source): Remove.
3024 (tui_attach_detach_observers): Update.
3025 * tui/tui-data.h (struct tui_source_window): Make constructor not
3026 inline. Add destructor.
3027 (struct tui_source_window) <style_changed>: New method.
3028 <m_observable>: New member.
3030 2019-07-17 Tom Tromey <tom@tromey.com>
3032 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3033 * tui/tui-win.c (tui_resize_all): Fix typo.
3035 2019-07-17 Tom Tromey <tom@tromey.com>
3037 * tui/tui-wingeneral.h (tui_refresh_all): Update.
3038 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3039 (tui_refresh_all): Remove "list" parameter. Use foreach.
3040 * tui/tui-win.c (window_name_completer): Use foreach.
3041 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3042 (update_tab_width): Likewise.
3043 * tui/tui-layout.c (show_layout): Update.
3044 * tui/tui-data.h (class tui_window_iterator): New.
3045 (struct all_tui_windows): New.
3046 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3048 2019-07-17 Tom Tromey <tom@tromey.com>
3050 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3051 parameter. Don't reference globals.
3052 (tui_reg_command): Update.
3054 2019-07-17 Tom Tromey <tom@tromey.com>
3056 * tui/tui-regs.c (tui_show_registers): Simplify.
3058 2019-07-17 Tom Tromey <tom@tromey.com>
3060 * tui/tui-regs.c (tui_show_registers): Update.
3061 (tui_show_register_group): Add win_info parameter.
3063 2019-07-17 Tom Tromey <tom@tromey.com>
3065 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3066 Rename from tui_display_reg_element_at_line.
3067 (tui_data_window::display_registers_from_line): Update.
3068 * tui/tui-data.h (struct tui_data_window)
3069 <display_reg_element_at_line>: New method.
3071 2019-07-17 Tom Tromey <tom@tromey.com>
3073 * tui/tui-regs.h (tui_display_registers_from)
3074 (tui_display_registers_from_line): Don't declare.
3075 * tui/tui-windata.c (tui_data_window::display_all_data)
3076 (tui_data_window::refresh_all)
3077 (tui_data_window::do_scroll_vertical): Update.
3078 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3079 from tui_display_registers_from.
3080 (tui_display_reg_element_at_line): Update.
3081 (tui_data_window::display_registers_from_line): Rename from
3082 tui_display_registers_from_line.
3083 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3084 display_registers_from_line>: New methods.
3086 2019-07-17 Tom Tromey <tom@tromey.com>
3088 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3089 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3090 from tui_erase_data_content.
3091 (tui_data_window::display_all_data)
3092 (tui_data_window::refresh_all)
3093 (tui_data_window::do_scroll_vertical): Update.
3094 * tui/tui-regs.c (tui_show_registers): Update.
3095 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3098 2019-07-17 Tom Tromey <tom@tromey.com>
3100 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3103 (tui_data_window::delete_data_content_windows): Rename from
3104 tui_delete_data_content_windows.
3105 (tui_data_window::display_all_data)
3106 (tui_data_window::do_scroll_vertical): Update.
3107 * tui/tui-data.h (struct tui_data_window)
3108 <delete_data_content_windows>: New method.
3110 2019-07-17 Tom Tromey <tom@tromey.com>
3112 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3113 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3115 2019-07-17 Tom Tromey <tom@tromey.com>
3117 * tui/tui-windata.h (tui_display_all_data): Don't declare.
3118 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3119 from tui_display_all_data.
3121 (tui_data_window::do_make_visible_with_new_height): Update.
3122 * tui/tui-regs.c (tui_show_registers): Update.
3123 * tui/tui-layout.c (tui_set_layout): Update.
3124 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3127 2019-07-17 Tom Tromey <tom@tromey.com>
3129 * tui/tui-windata.h (tui_display_data_from): Don't declare.
3130 * tui/tui-windata.c (tui_display_data_from): Remove.
3131 (tui_data_window::refresh_all): Update.
3133 2019-07-17 Tom Tromey <tom@tromey.com>
3135 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3136 * tui/tui-windata.c (tui_display_data_from_line): Remove.
3137 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3138 tui_display_registers_from_line.
3139 * tui/tui-regs.h (tui_display_registers_from_line): Update.
3140 * tui/tui-regs.c (tui_display_registers_from_line): Remove
3141 "force_display" parameter.
3143 2019-07-17 Tom Tromey <tom@tromey.com>
3145 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3147 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3148 Rename from tui_first_reg_element_no_inline.
3149 (tui_display_reg_element_at_line)
3150 (tui_display_registers_from_line): Update.
3151 * tui/tui-data.h (struct tui_data_window)
3152 <first_reg_element_no_inline>: New method.
3154 2019-07-17 Tom Tromey <tom@tromey.com>
3156 * tui/tui-windata.c (tui_display_data_from)
3157 (tui_data_window::do_scroll_vertical): Update.
3158 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3159 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3160 Rename from tui_line_from_reg_element_no.
3161 (tui_display_registers_from_line): Update.
3162 * tui/tui-data.h (struct tui_data_window)
3163 <line_from_reg_element_no>: New method.
3165 2019-07-17 Tom Tromey <tom@tromey.com>
3167 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3168 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3169 tui_last_regs_line_no.
3170 (tui_display_reg_element_at_line)
3171 (tui_display_registers_from_line): Update.
3172 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3175 2019-07-17 Tom Tromey <tom@tromey.com>
3178 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3179 (tui_update_breakpoint_info): Add "being_deleted" parameter.
3180 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3181 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3182 (tui_update_breakpoint_info): Likewise.
3183 * tui/tui-hooks.c (tui_event_create_breakpoint)
3184 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3187 2019-07-17 Tom Tromey <tom@tromey.com>
3189 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3191 2019-07-17 Tom Tromey <tom@tromey.com>
3193 * tui/tui-winsource.c (tui_update_source_window_as_is)
3194 (tui_update_source_windows_with_addr): Update.
3195 * tui/tui-source.h (tui_set_source_content)
3196 (tui_show_symtab_source): Add "win_info" parameter.
3197 * tui/tui-source.c (tui_set_source_content): Add "win_info"
3199 (tui_show_symtab_source): Likewise.
3201 2019-07-17 Tom Tromey <tom@tromey.com>
3203 * tui/tui-wingeneral.c
3204 (tui_check_and_display_highlight_if_needed): Check can_highlight.
3206 2019-07-17 Tom Tromey <tom@tromey.com>
3208 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3209 (struct tui_cmd_window) <can_scroll>: New method.
3210 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3213 2019-07-17 Tom Tromey <tromey@adacore.com>
3215 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3216 do_field_signed>: Rename. Change type of "value".
3217 * ui-out.c (ui_out::field_signed): Rename from field_int.
3218 Change type of "value".
3219 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
3221 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3222 do_field_int. Change type of "value".
3223 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3224 do_field_int. Change type of "value".
3225 * tracepoint.c (trace_status_mi, tfind_1)
3226 (print_one_static_tracepoint_marker): Update.
3227 * thread.c (print_thread_info_1, print_selected_thread_frame):
3229 * stack.c (print_frame, print_frame_info): Update.
3230 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3232 * source.c (print_source_lines_base): Update.
3233 * skip.c (info_skip_command): Update.
3234 * record-btrace.c (btrace_ui_out_decode_error)
3235 (btrace_call_history_src_line): Update.
3236 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3238 * progspace.c (print_program_space): Update.
3239 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3240 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3241 do_field_int. Change type of "value".
3242 * mi/mi-out.c (mi_ui_out::do_table_begin)
3243 (mi_ui_out::do_table_header): Update.
3244 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
3246 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3247 (mi_cmd_data_list_changed_registers, output_register)
3248 (mi_cmd_data_read_memory, mi_load_progress)
3249 (mi_cmd_trace_frame_collected): Update.
3250 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3252 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3253 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3254 (mi_cmd_var_list_children, varobj_update_one): Update.
3255 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3256 (mi_cmd_stack_list_args, list_arg_or_local): Update.
3257 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3258 * inferior.c (print_inferior): Update.
3259 * gdb_bfd.c (print_one_bfd): Update.
3260 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3262 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3263 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3264 do_field_int. Change type of "value".
3265 * cli-out.c (cli_ui_out::do_field_signed): Rename from
3266 do_field_int. Change type of "value".
3267 * breakpoint.c (watchpoint_check, print_breakpoint_location)
3268 (print_one_breakpoint_location, print_it_catch_fork)
3269 (print_one_catch_fork, print_it_catch_vfork)
3270 (print_one_catch_vfork, print_it_catch_solib)
3271 (print_it_catch_exec, print_it_ranged_breakpoint)
3272 (print_mention_watchpoint, print_mention_masked_watchpoint)
3273 (bkpt_print_it, update_static_tracepoint): Update.
3274 * break-catch-throw.c (print_it_exception_catchpoint): Update.
3275 * break-catch-syscall.c (print_it_catch_syscall): Update.
3276 * ada-tasks.c (print_ada_task_info): Update.
3277 * ada-lang.c (print_it_exception, print_mention_exception):
3280 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
3282 PR breakpoints/24541
3283 * gdbarch.c: Regenerate.
3284 * gdbarch.h: Regenerate.
3285 * gdbarch.sh: Adjust return type and parameter types for
3286 'stap_adjust_register'.
3287 (i386_stap_adjust_register): Adjust signature and return new
3289 * stap-probe.c (stap_parse_register_operand): Adjust use of
3290 'gdbarch_stap_adjust_register'.
3292 2019-07-17 Tom Tromey <tromey@adacore.com>
3294 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
3296 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3298 (struct s390_process_info): Add initializers.
3299 (s390_add_process): Use new.
3300 (s390_linux_nat_target::low_forget_process): Use delete.
3301 (s390_linux_nat_target::low_new_fork)
3302 (s390_linux_nat_target::stopped_by_watchpoint)
3303 (s390_linux_nat_target::low_prepare_to_resume)
3304 (s390_linux_nat_target::insert_watchpoint)
3305 (s390_linux_nat_target::insert_hw_breakpoint)
3306 (s390_linux_nat_target::remove_watchpoint)
3307 (s390_linux_nat_target::remove_hw_breakpoint): Update.
3309 2019-07-16 John Baldwin <jhb@FreeBSD.org>
3311 * aarch64-fbsd-nat.c: Include regcache.h.
3312 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3314 (aarch64_fbsd_nat_target::fetch_registers)
3315 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3317 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3319 2019-07-16 John Baldwin <jhb@FreeBSD.org>
3321 * fbsd-nat.c: Include gdbarch.h.
3323 2019-07-15 Tom Tromey <tromey@adacore.com>
3325 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3327 2019-07-15 Tom Tromey <tromey@adacore.com>
3329 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3330 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3331 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3332 * cli-out.c (cli_ui_out::do_field_int): New method.
3333 * ui-out.c (ui_out::field_unsigned): New method.
3334 * symfile.c (generic_load): Use field_unsigned.
3335 (print_transfer_performance): Likewise.
3336 * record-btrace.c (ui_out_field_uint): Remove.
3337 (btrace_call_history_insn_range, btrace_call_history): Use
3339 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3341 * ui-out.h (class ui_out) <field_unsigned>: New method.
3342 <do_field_unsigned>: Likewise.
3344 2019-07-15 Tom Tromey <tromey@adacore.com>
3346 * mi/mi-main.c (list_available_thread_groups): Use field_string.
3347 * mi/mi-interp.c (mi_memory_changed): Use field_string.
3348 * target.c (flash_erase_command): Use field_string.
3349 * infrun.c (print_signal_received_reason): Use field_string.
3350 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3351 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3353 * ada-tasks.c (print_ada_task_info): Use field_string.
3355 2019-07-15 Tom Tromey <tromey@adacore.com>
3357 * target.c (flash_erase_command): Use field_core_addr.
3358 * symfile.c (generic_load): Use field_core_addr.
3359 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3360 Use field_core_addr.
3361 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3364 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3366 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3367 value if its desired type is smaller than a CORE_ADDR and signed.
3369 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3371 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3372 of changes to field names, and use new is_reference field to
3373 decide if a property is a reference or not.
3374 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3376 (struct dwarf2_property_baton): Update header comment, rename
3377 'referenced_type' to 'property_type' and update comments.
3378 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3379 default property type, store in property baton, update to take
3380 accound of renamed field.
3381 (read_func_scope): Update call to attr_to_dynamic_prop.
3382 (read_array_type): Likewise.
3383 (dwarf2_per_cu_addr_sized_int_type): New function.
3384 (read_subrange_index_type): Move type finding code to
3385 dwarf2_per_cu_addr_sized_int_type.
3386 (read_subrange_type): Update calls to attr_to_dynamic_prop.
3387 (dwarf2_per_cu_addr_type): New function.
3388 (set_die_type): Update calls to attr_to_dynamic_prop.
3390 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3392 * dwarf2read.c (read_subrange_index_type): New function.
3393 (read_subrange_type): Move code into new function and call it.
3394 * gdbtypes.c (create_range_type): Add some asserts.
3396 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3398 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3399 update return statements.
3400 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3401 declaration, and update comment to match.
3402 * gdbtypes.c (resolve_dynamic_array): Update call to
3403 dwarf2_evaluate_property to match new return type.
3405 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3407 * valarith.c (value_subscripted_rvalue): Change lowerbound
3408 parameter type from int to LONGEST.
3409 * value.h (value_subscripted_rvalue): Likewise in declaration.
3411 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3413 * cli/cli-utils.c (info_print_command_completer): New function.
3414 * cli/cli-utils.h: Add 'completer.h' include, and forward
3415 declaration for 'struct cmd_list_element'.
3416 (info_print_command_completer): Declare.
3417 * stack.c (_initialize_stack): Add completer for 'info locals' and
3419 * symtab.c (_initialize_symtab): Add completer for 'info
3420 variables' and 'info functions'.
3421 * NEWS: Mention completion for additional info commands.
3423 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3425 * cli/cli-utils.c (extract_info_print_args): Delete.
3426 (extract_arg_maybe_quoted): Delete.
3427 (info_print_options_defs): New variable.
3428 (make_info_print_options_def_group): New function.
3429 (extract_info_print_options): Define new function.
3430 * cli/cli-utils.h (extract_info_print_args): Delete.
3431 (struct info_print_options): New structure.
3432 (extract_info_print_options): Declare new function.
3433 * stack.c (info_locals_command): Update to use new
3434 extract_info_print_options, also add a header comment.
3435 (info_args_command): Likewise.
3436 * symtab.c (info_variables_command): Likewise.
3437 (info_functions_command): Likewise.
3439 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3441 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3442 to extract string arguments.
3443 * common/common-utils.c (extract_string_maybe_quoted): New function.
3444 * common/common-utils.h (extract_string_maybe_quoted): Declare.
3446 2019-07-11 Tom Tromey <tromey@adacore.com>
3448 * main.c (get_init_files): Use GDBINIT, not gdbinit.
3449 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3450 * top.h (gdbinit): Don't declare.
3451 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3453 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
3454 * top.c (gdb_init): Don't call init_cli_cmds.
3456 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3458 2019-07-11 Tom Tromey <tromey@adacore.com>
3460 * python/py-inferior.c (add_thread_object): Don't use thread_obj
3461 after it has been moved.
3463 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3465 * valops.c (value_must_coerce_to_target): Change return type to
3467 * value.h (value_must_coerce_to_target): Likewise.
3469 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
3471 * breakpoint.c (is_hardware_watchpoint): Remove
3472 forward-declaration.
3473 (is_masked_watchpoint): Change return type to bool.
3474 (is_tracepoint): Likewise.
3475 (is_breakpoint): Likewise.
3476 (is_hardware_watchpoint): Likewise.
3477 (is_watchpoint): Likewise.
3478 (is_no_memory_software_watchpoint): Likewise.
3479 (is_catchpoint): Likewise.
3480 (breakpoint_1): Make FILTER parameter's return type bool.
3481 is_masked_watchpoint): Change return type to bool.
3482 (save_breakpoints): Make FILTER parameter's return type bool.
3483 * breakpoint.h (is_breakpoint): Change return type to bool.
3484 (is_watchpoint): Likewise.
3485 (is_catchpoint): Likewise.
3486 (is_tracepoint): Likewise.
3488 2019-07-10 Tom Tromey <tom@tromey.com>
3490 * defs.h: Don't include gdbarch.h.
3491 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3492 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3493 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3494 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3495 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3496 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3497 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3498 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3499 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3500 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3501 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3502 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3503 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3504 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3505 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3506 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3507 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3508 record-btrace.c, record.h, regcache-dump.c, regcache.h,
3509 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3510 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3511 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3512 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3513 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3514 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3515 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3516 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3517 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3519 2019-07-10 Tom Tromey <tromey@adacore.com>
3521 * ada-lang.h (is_ada_exception_catchpoint): Declare.
3522 * breakpoint.c (init_ada_exception_breakpoint): Register as
3524 (print_one_breakpoint_location, print_one_breakpoint): Use
3525 is_ada_exception_catchpoint.
3526 * ada-lang.c (class ada_catchpoint_location): Pass
3527 bp_loc_software_breakpoint to bp_location constructor.
3528 (is_ada_exception_catchpoint): New function.
3530 2019-07-10 Tom Tromey <tromey@adacore.com>
3532 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
3534 (struct arm_exidx_entry): New method operator<.
3535 (struct arm_exidx_data) <section_maps>: Change type.
3536 (arm_exidx_data_free): Remove.
3537 (arm_exidx_data_key): Change type. Move lower.
3538 (arm_exidx_new_objfile): Update.
3539 (arm_compare_exidx_entries): Remove.
3540 (arm_find_exidx_entry, _initialize_arm_tdep)
3542 2019-07-10 Tom Tromey <tromey@adacore.com>
3544 * solib-spu.c (ocl_program_data_key): Change type.
3545 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3548 2019-07-10 Tom Tromey <tromey@adacore.com>
3550 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
3551 (struct solib_aix_inferior_data) <library_list>: Change type.
3552 (solib_aix_inferior_data_handle): Change type.
3553 (get_solib_aix_inferior_data): Update.
3554 (solib_aix_free_library_list): Remove.
3555 (library_list_start_library): Update.
3556 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3558 (solib_aix_get_library_list)
3559 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3560 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3562 2019-07-10 Tom Tromey <tromey@adacore.com>
3564 * solib-dsbt.c (struct dsbt_info): Add initializers.
3565 (solib_dsbt_pspace_data): Change type.
3566 (dsbt_pspace_data_cleanup): Remove.
3567 (get_dsbt_info, _initialize_dsbt_solib): Update.
3569 2019-07-10 Tom Tromey <tromey@adacore.com>
3571 * spu-tdep.c (spu_overlay_data): Change type.
3572 (spu_get_overlay_table, spu_overlay_new_objfile)
3573 (_initialize_spu_tdep): Update.
3575 2019-07-10 Tom Tromey <tromey@adacore.com>
3577 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3579 (dbx_objfile_data_key): Change type and declare later.
3580 (DBX_SYMFILE_INFO): Rewrite.
3581 * dbxread.c (dbx_objfile_data_key): Change type.
3582 (dbx_symfile_init): Update.
3583 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
3584 (coffstab_build_psymtabs, elfstab_build_psymtabs)
3585 (stabsect_build_psymtabs, _initialize_dbxread): Update.
3587 2019-07-10 Tom Tromey <tromey@adacore.com>
3589 * jit.c (jit_program_space_key): Change type. Move lower.
3590 (get_jit_program_space_data): Update.
3591 (jit_program_space_data_cleanup): Remove.
3592 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3594 (struct jit_program_space_data): Add initializers.
3596 2019-07-10 Tom Tromey <tromey@adacore.com>
3598 * solib-darwin.c (struct darwin_info): Add initializers.
3599 (solib_darwin_pspace_data): Change type.
3600 (darwin_pspace_data_cleanup): Remove.
3601 (get_darwin_info, _initialize_darwin_solib): Update.
3603 2019-07-10 Tom Tromey <tromey@adacore.com>
3605 * remote-sim.c (struct sim_inferior_data): Add initializers,
3606 constructor, and destructor.
3607 (sim_inferior_data_key): Change type. Move lower.
3608 (check_for_duplicate_sim_descriptor): Update.
3609 (get_sim_inferior_data): Use new. Update.
3610 (~sim_inferior_data_cleanup): Rename from
3611 sim_inferior_data_cleanup. Simplify.
3612 (gdbsim_close_inferior, simulator_command)
3613 (sim_command_completer, _initialize_remote_sim): Update.
3614 (next_pid, INITIAL_PID): Move earlier.
3616 2019-07-10 Tom Tromey <tromey@adacore.com>
3618 * python/python-internal.h (create_thread_object): Return
3620 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3621 * python/py-inferior.c (struct threadlist_entry): Add
3623 <thread_obj>: Now a gdbpy_ref.
3624 (thread_to_thread_object): Update.
3625 (add_thread_object): Use new.
3626 (delete_thread_object): Use delete.
3627 (infpy_threads): Update.
3628 (py_free_inferior): Update. Construct "inf_obj" after acquiring
3631 2019-07-10 Tom Tromey <tromey@adacore.com>
3633 * valops.c (value_cast): Specialize error message for Ada.
3635 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3637 * breakpoint.c (breakpoint_1): Update doc and parameter names.
3639 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3641 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3642 bpstat_should_step): Return bool, adjust comments.
3643 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3644 bpstat_should_step): Likewise.
3646 2019-07-10 Alan Hayward <alan.hayward@arm.com>
3648 * features/Makefile: Use feature target descriptions for Arm.
3649 * features/arm/arm-core.c: Generate new file.
3650 * features/arm/arm-fpa.c: Likewise.
3651 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3652 * features/arm/arm-m-profile.c: Likewise.
3653 * features/arm/arm-vfpv2.c: Likewise.
3654 * features/arm/arm-vfpv3.c: Likewise.
3655 * features/arm/xscale-iwmmxt.c: Likewise.
3656 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3658 2019-07-10 Alan Hayward <alan.hayward@arm.com>
3660 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3663 2019-07-10 Alan Hayward <alan.hayward@arm.com>
3665 * features/aarch64-pauth.c: Regenerate.
3667 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
3669 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3671 (bpstat_what): Use false instead of 0.
3673 2019-07-09 Pedro Alves <palves@redhat.com>
3675 * break-catch-throw.c (is_exception_catchpoint): New.
3676 * breakpoint.c (print_one_breakpoint_location): New parameter
3677 'raw_loc'. Handle it. Use
3678 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3679 looking at the breakpoint's type.
3680 (print_one_breakpoint): If handling "maint info breakpoints", also
3681 print locations of exception catchpoints.
3682 * breakpoint.h (is_exception_catchpoint): Declare.
3684 2019-07-09 Pedro Alves <palves@redhat.com>
3686 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3688 (allocate_location_exception_catchpoint): New.
3689 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3690 (initialize_throw_catchpoint_ops): Install
3691 allocate_location_exception_catchpoint as allocate_location
3693 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3694 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3696 (breakpoint_address_is_meaningful): Delete.
3697 (bl_address_is_meaningful): New.
3698 (breakpoint_locations_match): Adjust comment.
3699 (bp_location_from_bp_type): New, factored out of...
3700 (bp_location::bp_location(breakpoint *)): ... this.
3701 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3703 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
3704 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3705 breakpoint_address_is_meaningful.
3706 (bp_locations_compare): Adjust comment.
3707 (update_global_location_list): Use bl_address_is_meaningful
3708 instead of breakpoint_address_is_meaningful.
3709 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3711 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3712 * python/py-breakpoint.c (bppy_get_location): No longer check
3713 whether location is null.
3715 2019-07-09 Pedro Alves <palves@redhat.com>
3718 * breakpoint.c (print_one_breakpoint_location): Remove
3719 single-location assert.
3721 2019-07-09 Tom Tromey <tom@tromey.com>
3723 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3724 * configure: Rebuild.
3725 * configure.ac: Change common to gdbsupport.
3726 * gdbsupport: Rename from common.
3727 * acinclude.m4: Change common to gdbsupport.
3728 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3729 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3731 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3732 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3733 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3734 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3735 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3736 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3737 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3738 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3739 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3740 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3741 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3742 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3743 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3744 coff-pe-read.c, command.h, compile/compile-c-support.c,
3745 compile/compile-c.h, compile/compile-cplus-symbols.c,
3746 compile/compile-cplus-types.c, compile/compile-cplus.h,
3747 compile/compile-loc2c.c, compile/compile.c, completer.c,
3748 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3749 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3750 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3751 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3752 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3753 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3754 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3755 features/aarch64-core.c, features/aarch64-fpu.c,
3756 features/aarch64-pauth.c, features/aarch64-sve.c,
3757 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3758 features/i386/32bit-core.c, features/i386/32bit-linux.c,
3759 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3760 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3761 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3762 features/i386/64bit-core.c, features/i386/64bit-linux.c,
3763 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3764 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3765 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3766 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3767 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3768 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3769 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3770 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3771 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3772 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3773 go32-nat.c, guile/guile.c, guile/scm-ports.c,
3774 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3775 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3776 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3777 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3778 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3779 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3780 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3781 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3782 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3783 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3784 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3785 minsyms.c, mips-linux-tdep.c, namespace.h,
3786 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3787 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3788 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3789 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3790 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3791 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3792 nat/linux-waitpid.c, nat/mips-linux-watch.c,
3793 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3794 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3795 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3796 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3797 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3798 procfs.c, producer.c, progspace.h, psymtab.h,
3799 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3800 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3801 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3802 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3803 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3804 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3805 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3806 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3807 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3808 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3809 target-memory.c, target.c, target.h, target/waitstatus.c,
3810 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3811 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3812 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3813 unittests/array-view-selftests.c,
3814 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3815 unittests/common-utils-selftests.c,
3816 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3817 unittests/format_pieces-selftests.c,
3818 unittests/function-view-selftests.c,
3819 unittests/lookup_name_info-selftests.c,
3820 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3821 unittests/mkdir-recursive-selftests.c,
3822 unittests/observable-selftests.c,
3823 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3824 unittests/parse-connection-spec-selftests.c,
3825 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3826 unittests/scoped_fd-selftests.c,
3827 unittests/scoped_mmap-selftests.c,
3828 unittests/scoped_restore-selftests.c,
3829 unittests/string_view-selftests.c, unittests/style-selftests.c,
3830 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3831 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3832 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3833 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3834 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3835 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3837 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3839 * linespec.c (decode_digits_list_mode): Set explicit_line to a
3841 (decode_digits_ordinary): Set explicit_line field in sal.
3842 * symtab.c (skip_prologue_sal): Don't skip prologue for a
3843 symtab_and_line that was set on an explicit line number in
3844 assembler code. Do always update the recorded symtab and line if
3845 we do skip the prologue.
3847 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3849 * breakpoint.c (set_breakpoint_location_function): Remove
3850 explicit_loc parameter.
3851 (momentary_breakpoint_from_master): Update call to
3852 set_breakpoint_location_function.
3853 (add_location_to_breakpoint): Likewise.
3855 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3857 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3858 required features based on default bfd type when no specific bfd
3861 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3863 * NEWS: Mention that GDB printf and eval commands can now print
3864 C-style and Ada-style convenience var strings without
3865 calling the inferior.
3866 * printcmd.c (printf_c_string): Locally print GDB internal var
3867 instead of transiting via the inferior.
3868 (printf_wide_c_string): Likewise.
3870 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3872 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3874 2019-07-04 Tom Tromey <tom@tromey.com>
3877 * tui/tui-winsource.c (tui_clear_source_content): Update.
3878 (tui_source_window_base::set_is_exec_point_at): Fix comment.
3879 (tui_update_breakpoint_info): Update.
3880 (tui_set_exec_info_content): Update.
3881 * tui/tui-source.c (tui_set_source_content_nil): Update.
3882 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3884 * tui/tui-data.h (enum tui_bp_flag): New.
3885 (tui_bp_flags): New enum flags type.
3886 (struct tui_source_element) <break_mode>: Change type. Rename
3888 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3889 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
3891 * tui/tui-winsource.h: Fix comment.
3893 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3895 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3896 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3897 (store_fpregs_to_thread)
3898 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3899 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3900 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3901 (IWMMXT_REGS_SIZE): Add define.
3902 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3903 (fetch_vfp_regs, store_vfp_regs)
3904 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3905 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3907 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3909 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3911 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3912 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3913 (ARM_INT_REGISTER_SIZE): ...to this.
3914 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3915 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3916 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3917 (arm_linux_collect_gregset, supply_nwfpe_register)
3918 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3920 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3921 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3922 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3923 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3924 (arm_return_in_memory, arm_store_return_value)
3925 (arm_get_longjmp_target, arm_register_g_packet_guesses)
3926 (arm_record_ld_st_multiple): Likewise.
3927 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3928 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3930 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3932 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3933 AARCH64_DISPLACED_MODIFIED_INSNS.
3934 * aarch64-tdep.c (struct aarch64_displaced_step_data)
3935 (aarch64_displaced_step_copy_insn): Likewise.
3936 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3937 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3938 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3939 ARM_DISPLACED_MODIFIED_INSNS.
3940 * arm-tdep.c (arm_gdbarch_init): Likewise.
3941 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3942 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3943 (struct arm_displaced_step_closure): Use
3944 ARM_DISPLACED_MODIFIED_INSNS.
3946 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3948 * features/Makefile: Remove unused xml files.
3949 * features/aarch64.xml: Remove.
3950 * features/i386/amd64-avx-avx512-linux.xml: Remove.
3951 * features/i386/amd64-avx-avx512.xml: Remove.
3952 * features/i386/amd64-avx-linux.xml: Remove.
3953 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3954 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3955 * features/i386/amd64-avx-mpx-linux.xml: Remove.
3956 * features/i386/amd64-avx-mpx.xml: Remove.
3957 * features/i386/amd64-avx.xml: Remove.
3958 * features/i386/amd64-linux.xml: Remove.
3959 * features/i386/amd64-mpx-linux.xml: Remove.
3960 * features/i386/amd64-mpx.xml: Remove.
3961 * features/i386/amd64.xml: Remove.
3962 * features/i386/i386-avx-avx512-linux.xml: Remove.
3963 * features/i386/i386-avx-avx512.xml: Remove.
3964 * features/i386/i386-avx-linux.xml: Remove.
3965 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3966 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3967 * features/i386/i386-avx-mpx-linux.xml: Remove.
3968 * features/i386/i386-avx-mpx.xml: Remove.
3969 * features/i386/i386-avx.xml: Remove.
3970 * features/i386/i386-linux.xml: Remove.
3971 * features/i386/i386-mmx-linux.xml: Remove.
3972 * features/i386/i386-mmx.xml: Remove.
3973 * features/i386/i386-mpx-linux.xml: Remove.
3974 * features/i386/i386-mpx.xml: Remove.
3975 * features/i386/i386.xml: Remove.
3976 * features/i386/x32-avx-avx512-linux.xml: Remove.
3977 * features/i386/x32-avx-linux.xml: Remove.
3978 * features/i386/x32-linux.xml: Remove.
3980 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3982 * regformats/aarch64.dat: Remove.
3983 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3984 * regformats/i386/amd64-avx-linux.dat: Remove.
3985 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3986 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3987 * regformats/i386/amd64-linux.dat: Remove.
3988 * regformats/i386/amd64-mpx-linux.dat: Remove.
3989 * regformats/i386/amd64.dat: Remove.
3990 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3991 * regformats/i386/i386-avx-linux.dat: Remove.
3992 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3993 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3994 * regformats/i386/i386-linux.dat: Remove.
3995 * regformats/i386/i386-mmx-linux.dat: Remove.
3996 * regformats/i386/i386-mpx-linux.dat: Remove.
3997 * regformats/i386/i386.dat: Remove.
3998 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3999 * regformats/i386/x32-avx-linux.dat: Remove.
4000 * regformats/i386/x32-linux.dat: Remove.
4002 2019-07-04 Alan Hayward <alan.hayward@arm.com>
4004 * aarch64-tdep.c: Remove xml self tests.
4005 * amd64-linux-tdep.c: Likewise.
4006 * amd64-tdep.c: Likewise.
4007 * i386-linux-tdep.c: Likewise.
4008 * i386-tdep.c: Likewise.
4010 2019-07-03 Pedro Alves <palves@redhat.com>
4013 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4014 (pipe_cmd_option_defs): New.
4015 (make_pipe_cmd_options_def_group): New.
4016 (pipe_command): Use gdb::option::process_options.
4017 (pipe_command_completer): New function.
4018 (_initialize_cli_cmds): Install completer for "pipe" command.
4020 2019-07-03 Pedro Alves <palves@redhat.com>
4022 * cli/cli-option.c (union option_value) <string>: New field.
4023 (struct option_def_and_value): Add ctor, move ctor, dtor and
4024 use DISABLE_COPY_AND_ASSIGN.
4025 (option_def_and_value::clear_value): New.
4026 (parse_option, save_option_value_in_ctx, get_val_type_str)
4027 (add_setshow_cmds_for_options): Handle var_string.
4028 * cli-option.h (union option_def::var_address) <string>: New
4030 (struct string_option_def): New.
4031 * maint-test-options.c (struct test_options_opts): Add default
4032 ctor and use DISABLE_COPY_AND_ASSIGN.
4033 <string_opt>: New field.
4034 (test_options_opts::~test_options_opts): New.
4035 (test_options_opts::dump): Also dump "-string".
4036 (test_options_option_defs): Install "string.
4038 2019-07-03 Pedro Alves <palves@redhat.com>
4040 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4041 option_value with a null enumeration.
4042 (complete_options): Save the option values in the context.
4043 (save_option_value_in_ctx): New, factored out from ...
4044 (process_options): ... here.
4045 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4047 * maint-test-options.c (test_options_opts::dump): New, factored
4049 (maintenance_test_options_command_mode): ... here.
4050 (maintenance_test_options_command_completion_result): Delete.
4051 (maintenance_test_options_command_completion_text): Update
4053 (maintenance_show_test_options_completion_result): Change
4054 prototype. Just print
4055 maintenance_test_options_command_completion_text.
4056 (save_completion_result): New.
4057 (maintenance_test_options_completer_mode): Pass options context to
4058 complete_options, and then save a dump.
4059 (_initialize_maint_test_options): Use add_cmd to install "maint
4060 show test-options-completion-result".
4062 2019-07-03 Pedro Alves <palves@redhat.com>
4064 * NEWS (New commands): Mention "with" and "maint with".
4065 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4066 (with_command, with_command_completer): New.
4067 (pipe_command): Adjust to new repeat_previous
4069 (_initialize_cli_cmds): Install the "with" command and its "w"
4071 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4073 * cli/cli-setshow.c (parse_cli_var_uinteger)
4074 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4075 argument strings for all var_types.
4076 (get_setshow_command_value_string): New, factored out from ...
4077 (do_show_command): ... this.
4078 * cli/cli-setshow.h: Include <string>.
4079 (get_setshow_command_value_string): Declare.
4080 * command.h (repeat_previous): Now returns const char *. Adjust
4082 * maint.c: Include "cli/cli-cmds.h".
4083 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4084 (_initialize_maint_cmds): Register the "maintenance with" command.
4085 * top.c (repeat_previous): Move bits from pipe_command here:
4086 Return the saved command line, if any; error out if there's no
4087 command to relaunch.
4089 2019-07-03 Pedro Alves <palves@redhat.com>
4091 * NEWS (New commands): Mention "maint set/show test-settings"
4092 instead of "maint test-settings".
4093 * maint-test-settings.c (maintenance_test_settings_list): Delete.
4094 (maintenance_test_settings_set_list): Rename to ...
4095 (maintenance_set_test_settings_list): ... this.
4096 (maintenance_test_settings_show_list): Rename to ...
4097 (maintenance_show_test_settings_list): ... this.
4098 (maintenance_test_settings_cmd): Delete.
4099 (maintenance_test_settings_set_cmd): ...
4100 (maintenance_set_test_settings_cmd): ... this.
4101 (maintenance_test_settings_show_cmd): ...
4102 (maintenance_show_test_settings_cmd): ... this.
4103 (maintenance_test_settings_show_value_cmd):
4104 (maintenance_show_test_settings_value_cmd): ... this.
4105 (_initialize_maint_test_settings): No longer install the "maint
4106 test-settings" prefix command. Rename "maint test-settings set"
4107 to "maint set test-settings", and "maint test-settings show" to
4108 "maint show test-settings". Adjust all subcommands.
4110 2019-07-03 Pedro Alves <palves@redhat.com>
4112 * maint-test-settings.c: Fix file's intro comment. Replace all
4113 references to "test-options" with references to "test-settings",
4116 2019-07-03 Pedro Alves <palves@redhat.com>
4118 * maint-test-settings.c (maintenance_test_settings_xxx)
4119 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4121 (maintenance_test_settings_enums): Use them.
4122 (maintenance_test_settings_enum): Default to
4123 maintenance_test_settings_xxx.
4124 (_initialize_maint_test_settings): Initialize
4125 MAINTENANCE_TEST_SETTINGS_FILENAME.
4127 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
4129 * breakpoint.h (remove_breakpoints_inf): Change return type to
4130 void, move function documentation here.
4131 * breakpoint.c (remove_breakpoints_inf): Change return type to
4132 void, move function documentation to header.
4134 2019-07-02 Pedro Alves <palves@redhat.com>
4136 * NEWS (Completion improvements): Mention "info threads".
4137 * thread.c (struct info_threads_opts, info_threads_option_defs)
4138 (make_info_threads_options_def_group): New.
4139 (info_threads_command): Use gdb::option::process_options.
4140 (info_threads_command_completer): New.
4141 (_initialize_thread): Use gdb::option::build_help to build the
4142 help text for "info threads".
4144 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
4146 * defs.h (generic_load): Move from here...
4147 * symfile.h (generic_load): ... to here. Rename name parameter
4149 * symfile.c (generic_load): Add comment.
4151 2019-07-01 Tom Tromey <tromey@adacore.com>
4154 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4155 declaration of without_params. Fix formatting.
4157 2019-07-01 Tom Tromey <tromey@adacore.com>
4159 * ada-exp.y (find_primitive_type): Update.
4160 * ada-lang.h (ada_lookup_symbol): Update.
4161 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4163 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4165 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
4167 PR breakpoints/24541
4168 * gdbarch.c: Regenerate.
4169 * gdbarch.h: Regenerate.
4170 * gdbarch.sh: Add 'stap_adjust_register'.
4171 * i386-tdep.c: Include '<unordered_set>'.
4172 (i386_stap_adjust_register): New function.
4173 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4174 * stap-probe.c (stap_parse_register_operand): Call
4175 'gdbarch_stap_adjust_register'.
4177 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
4180 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4181 * python/python.c (do_start_initialization): Use 'xmalloc'
4182 instead of 'PyMem_Malloc'.
4184 2019-06-28 Tom Tromey <tromey@adacore.com>
4186 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4189 2019-06-27 Tom Tromey <tromey@adacore.com>
4191 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
4193 (arm_find_mapping_symbol, arm_record_special_symbol)
4194 (_initialize_arm_tdep): Update.
4195 (arm_objfile_data_free): Remove.
4197 2019-06-27 Tom Tromey <tromey@adacore.com>
4199 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4200 to cp_print_static_field.
4202 2019-06-26 Tom Tromey <tromey@adacore.com>
4204 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4205 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4208 2019-06-26 Alan Hayward <alan.hayward@arm.com>
4210 * features/aarch64-core.c (create_feature_aarch64_core):
4212 * features/aarch64-core.xml: Add cpsr flags.
4214 2019-06-26 Alan Hayward <alan.hayward@arm.com>
4216 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4217 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4219 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4221 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4223 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4225 (arm_record_special_symbol): Don't insert new symbol in sorted
4226 position, push it at the end.
4228 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4230 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4231 (arm_mapping_symbol_s): Remove.
4232 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4233 (arm_mapping_symbol_vec): New typedef.
4234 (struct arm_per_objfile): Add constructor.
4235 <section_maps>: Change type to
4236 std::unique_ptr<arm_mapping_symbol_vec[]>.
4237 (arm_compare_mapping_symbols): Remove.
4238 (arm_find_mapping_symbol): Adjust to section_maps type change.
4239 (arm_objfile_data_free): Call delete on arm_per_objfile.
4240 (arm_record_special_symbol): Adjust to section_maps type change.
4241 Allocate arm_per_objfile with new.
4243 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4245 * cli/cli-cmds.c (alias_command): Compare the alias prefix
4246 with the command prefix.
4248 2019-06-25 Tom Tromey <tom@tromey.com>
4250 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4251 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4253 2019-06-25 Tom Tromey <tom@tromey.com>
4255 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4257 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4260 2019-06-25 Tom Tromey <tom@tromey.com>
4262 * tui/tui-winsource.c
4263 (tui_source_window_base::set_is_exec_point_at): Add check against
4266 2019-06-25 Tom Tromey <tom@tromey.com>
4268 * tui/tui-source.c (tui_set_source_content): Don't check before
4270 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4272 2019-06-25 Tom Tromey <tom@tromey.com>
4274 * tui/tui-winsource.h (tui_update_source_window_as_is)
4275 (tui_alloc_source_buffer, tui_line_is_displayed)
4276 (tui_addr_is_displayed): Change type of win_info.
4277 * tui/tui-winsource.c (tui_update_source_window_as_is)
4278 (tui_clear_source_content, tui_show_source_line)
4279 (tui_show_source_content, tui_source_window_base::refill)
4280 (tui_source_window_base::set_is_exec_point_at)
4281 (tui_source_window_base::set_is_exec_point_at)
4282 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4283 (tui_alloc_source_buffer, tui_line_is_displayed)
4284 (tui_addr_is_displayed): Change type of win_info. Update.
4285 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4286 (tui_source_window_base::do_make_visible_with_new_height):
4288 * tui/tui-source.c (tui_set_source_content)
4289 (tui_set_source_content_nil)
4290 (tui_source_window::do_scroll_vertical): Update.
4291 * tui/tui-layout.c (show_layout): Update.
4292 * tui/tui-disasm.c (tui_set_disassem_content)
4293 (tui_disasm_window::do_scroll_vertical): Update.
4294 * tui/tui-data.h (tui_win_content): Remove.
4295 (struct tui_gen_win_info) <content, content_size>: Remove.
4296 (struct tui_source_element): Add initializers and destructor.
4297 (union tui_which_element, struct tui_win_element): Remove.
4298 (struct tui_source_window_base) <content>: New field.
4299 (struct tui_data_window): Remove destructor.
4300 (tui_alloc_content, tui_free_win_content)
4301 (tui_free_all_source_wins_content): Don't declare.
4302 * tui/tui-data.c (tui_initialize_static_data): Update.
4303 (init_content_element, tui_alloc_content): Remove.
4304 (~tui_gen_win_info): Update.
4305 (~tui_data_window, tui_free_all_source_wins_content)
4306 (tui_free_win_content, free_content, free_content_elements):
4309 2019-06-25 Tom Tromey <tom@tromey.com>
4311 * tui/tui-winsource.h (tui_clear_source_content)
4312 (tui_erase_source_content, tui_show_source_content): Change type
4314 * tui/tui-winsource.c (tui_clear_source_content)
4315 (tui_erase_source_content, tui_show_source_content): Change type
4317 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4318 * tui/tui-source.h (tui_set_source_content_nil): Change type of
4320 * tui/tui-source.c (tui_set_source_content_nil): Change type of
4322 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4324 2019-06-25 Tom Tromey <tom@tromey.com>
4326 * tui/tui-winsource.c (tui_clear_source_content)
4327 (tui_source_window_base::set_is_exec_point_at): Update.
4328 * tui/tui-source.c (tui_set_source_content_nil): Update.
4329 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4331 * tui/tui-data.c (init_content_element): Update.
4333 2019-06-25 Tom Tromey <tom@tromey.com>
4335 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4336 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4337 * tui/tui-layout.c (init_and_make_win): Update.
4338 * tui/tui.h (enum tui_win_type): Update.
4339 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4340 tui_win_is_auxillary.
4341 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4342 tui_win_is_auxillary.
4344 2019-06-25 Tom Tromey <tom@tromey.com>
4346 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4347 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4348 (tui_delete_data_content_windows, tui_display_all_data)
4349 (tui_data_window::do_scroll_vertical, tui_display_data_from):
4351 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4352 * tui/tui-regs.c (tui_last_regs_line_no)
4353 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4354 (tui_show_registers): Update.
4355 (tui_show_register_group): Return void. Update.
4356 (tui_display_registers_from, tui_display_reg_element_at_line)
4357 (tui_display_registers_from_line, tui_check_register_values):
4359 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4361 (struct tui_data_window) <regs_content>: Now a std::vector.
4362 <regs_content_count>: Remove.
4363 (tui_add_content_elements, tui_free_data_content): Don't declare.
4364 * tui/tui-data.c (tui_data_window::clear_detail): Update.
4365 (init_content_element): Remove DATA_WIN case. Add assert.
4366 (tui_add_content_elements): Remove.
4367 (tui_data_window): Update.
4368 (tui_free_data_content): Remove.
4369 (free_content_elements): Remove DATA_WIN case.
4371 2019-06-25 Tom Tromey <tom@tromey.com>
4373 * tui/tui-data.c (tui_data_item_window): Update.
4374 * tui/tui-windata.h (tui_check_data_values): Don't declare.
4375 * tui/tui-windata.c (tui_display_all_data)
4376 (tui_display_data_from_line): Update.
4377 (tui_check_data_values): Remove.
4378 * tui/tui-regs.c (tui_show_register_group)
4379 (tui_display_reg_element_at_line): Update.
4380 * tui/tui-hooks.c (tui_register_changed)
4381 (tui_refresh_frame_and_register_information): Call
4382 tui_check_register_values.
4383 * tui/tui-data.h (struct tui_data_window) <data_content,
4384 data_content_count, data_type>: Remove.
4385 (enum tui_data_type): Remove.
4387 * tui/tui-data.c (tui_data_window::clear_detail)
4388 (~tui_data_window): Update.
4390 2019-06-25 Tom Tromey <tom@tromey.com>
4392 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4394 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4395 Rename from tui_first_data_item_displayed. Update.
4396 (tui_data_window::refresh_all)
4397 (tui_data_window::do_scroll_vertical): Update.
4398 * tui/tui-data.h (struct tui_data_window)
4399 <first_data_item_displayed>: Declare new method.
4401 2019-06-25 Tom Tromey <tom@tromey.com>
4403 * tui/tui-data.h (tui_init_generic_part): Don't declare.
4404 * tui/tui-data.c (tui_init_generic_part): Remove, moving
4406 (tui_initialize_static_data): ...here.
4408 2019-06-25 Tom Tromey <tom@tromey.com>
4410 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4411 (tui_display_registers_from, tui_check_register_values): Update.
4412 (tui_display_register): Remove win_info parameter; update.
4413 (tui_get_register): Change type of parameters.
4414 * tui/tui-data.h (struct tui_data_element): Remove.
4415 (union tui_which_element) <data>: Remove.
4416 <data_window>: Change type.
4417 (struct tui_data_item_window): New.
4418 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4420 (~tui_data_item_window): New destructor.
4421 (free_content_elements): Remove DATA_ITEM_WIN case.
4423 2019-06-25 Tom Tromey <tom@tromey.com>
4425 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4428 2019-06-25 Tom Tromey <tom@tromey.com>
4430 * tui/tui-data.h (struct tui_command_element): Remove.
4431 (union tui_which_element) <command>: Remove.
4432 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
4434 (free_content_elements): Remove CMD_WIN case.
4436 2019-06-25 Tom Tromey <tom@tromey.com>
4438 * tui/tui-layout.c (tui_set_layout): Update.
4439 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4440 * tui/tui-data.c (layout_def): Update.
4442 2019-06-25 Tom Tromey <tom@tromey.com>
4444 * tui/tui-wingeneral.c (tui_refresh_all): Update.
4445 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4446 (tui_source_window_base::set_new_height): Update.
4447 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4449 (tui_set_locator_fullname, tui_set_locator_info)
4450 (tui_show_frame_info): Update.
4451 * tui/tui-source.c (tui_set_source_content)
4452 (tui_source_is_displayed): Update.
4453 * tui/tui-layout.c (show_source_disasm_command, show_data)
4454 (show_source_or_disasm_and_command): Update.
4455 * tui/tui-disasm.c (tui_set_disassem_content)
4456 (tui_get_begin_asm_address): Update.
4457 * tui/tui-data.h (struct tui_locator_element): Remove.
4458 (union tui_which_element) <locator>: Remove.
4459 (struct tui_locator_window): New.
4460 (tui_locator_win_info_ptr): Change return type.
4461 * tui/tui-data.c (_locator): Change type.
4462 (tui_locator_win_info_ptr): Change return type.
4463 (init_content_element): Remove LOCATOR_WIN case. Add assert.
4464 (tui_alloc_content): Add assert.
4466 2019-06-25 Tom Tromey <tom@tromey.com>
4468 * tui/tui-winsource.c
4469 (tui_exec_info_window::maybe_allocate_content): New method.
4470 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4471 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4472 (make_source_or_disasm_window): Add cast.
4473 * tui/tui-data.h (union tui_which_element) <simple_string>:
4475 (struct tui_source_info): New.
4476 (struct tui_source_window_base) <execution_info>: Change type.
4477 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4478 case, and add assert.
4479 (tui_alloc_content): Add assert.
4481 2019-06-25 Tom Tromey <tom@tromey.com>
4483 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4484 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4485 * tui/tui-data.c (tui_alloc_win_info): Remove.
4487 2019-06-25 Tom Tromey <tom@tromey.com>
4489 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4490 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4493 2019-06-25 Tom Tromey <tom@tromey.com>
4495 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4496 make_visible_with_new_height method.
4497 (tui_win_info::make_visible_with_new_height): New method.
4498 (tui_source_window_base::do_make_visible_with_new_height)
4499 (tui_data_window::do_make_visible_with_new_height)
4500 (tui_cmd_window::do_make_visible_with_new_height): New methods.
4501 (make_visible_with_new_height): Remove.
4502 (tui_resize_all, tui_adjust_win_heights): Use
4503 make_visible_with_new_height method.
4504 * tui/tui-data.h (struct tui_win_info)
4505 <do_make_visible_with_new_height, make_visible_with_new_height>:
4507 (struct tui_source_window_base, struct tui_data_window)
4508 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4511 2019-06-25 Tom Tromey <tom@tromey.com>
4513 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4515 (update_tab_width): Call update_tab_width method.
4516 * tui/tui-data.h (struct tui_win_info)
4517 (struct tui_source_window_base) <update_tab_width>: New methods.
4519 2019-06-25 Tom Tromey <tom@tromey.com>
4521 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4523 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4525 (tui_gen_win_info::make_visible): Update.
4526 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4528 * tui/tui-data.h (enum tui_box): New enum.
4529 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4531 2019-06-25 Tom Tromey <tom@tromey.com>
4533 * tui/tui-layout.c (make_source_or_disasm_window): Always use
4534 init_and_make_win for EXEC_INFO_WIN.
4535 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4537 (struct tui_win_info) <~tui_win_info>: Inline.
4538 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4540 * tui/tui-data.c (source_win, disasm_win): Remove globals.
4541 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4543 (tui_initialize_static_data): Update.
4544 (~tui_gen_win_info): Handle more cleanup here.
4545 (~tui_source_window_base): Delete "execution_info".
4546 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4548 2019-06-25 Tom Tromey <tom@tromey.com>
4550 * tui/tui-layout.c (make_command_window): Don't set
4552 (show_source_disasm_command): Call the reset method.
4553 (show_data): Don't set can_highlight. Call the reset method.
4554 (tui_gen_win_info::reset): Rename from init_gen_win_info
4555 (init_and_make_win): Simplify. Return tui_gen_win_info.
4556 (show_source_or_disasm_and_command): Call the reset method.
4557 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4558 (struct tui_cmd_window): Set can_highlight.
4560 2019-06-25 Tom Tromey <tom@tromey.com>
4562 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4564 (tui_make_visible, tui_make_invisible): Rewrite.
4565 (tui_win_info::make_visible): Remove.
4566 (tui_source_window_base::make_visible): Update.
4567 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4568 method. Moved from...
4569 (struct tui_win_info) <make_visible>: ...here.
4571 2019-06-25 Tom Tromey <tom@tromey.com>
4573 * tui/tui-winsource.c
4574 (tui_source_window_base::do_scroll_horizontal): Remove direction
4576 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4577 direction parameter.
4578 * tui/tui-win.c (tui_win_info::forward_scroll)
4579 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4580 (tui_win_info::right_scroll): Update.
4581 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4582 direction parameter.
4583 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4584 direction parameter.
4585 * tui/tui-data.h (enum tui_scroll_direction): Remove.
4586 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4587 Remove direction parameter.
4588 (struct tui_source_window_base, struct tui_source_window)
4589 (struct tui_disasm_window, struct tui_data_window)
4590 (struct tui_cmd_window): Update.
4592 2019-06-25 Tom Tromey <tom@tromey.com>
4594 * tui/tui-winsource.h (tui_set_exec_info_content)
4595 (tui_show_exec_info_content, tui_erase_exec_info_content)
4596 (tui_clear_exec_info_content, tui_update_exec_info): Change
4597 argument to tui_source_window_base.
4598 * tui/tui-winsource.c (tui_set_exec_info_content)
4599 (tui_show_exec_info_content, tui_erase_exec_info_content)
4600 (tui_clear_exec_info_content, tui_update_exec_info): Change
4601 argument to tui_source_window_base.
4603 2019-06-25 Tom Tromey <tom@tromey.com>
4605 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4606 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4608 2019-06-25 Tom Tromey <tom@tromey.com>
4610 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4613 2019-06-25 Tom Tromey <tom@tromey.com>
4615 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4617 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4619 * tui/tui-source.c (tui_set_source_content): Update.
4620 * tui/tui-disasm.c (tui_set_disassem_content): Update.
4622 2019-06-25 Tom Tromey <tom@tromey.com>
4624 * tui/tui-win.c (window_name_completer, tui_set_focus)
4625 (tui_all_windows_info): Use name method.
4626 * tui/tui-data.h (struct tui_gen_win_info)
4627 (struct tui_source_window, struct tui_disasm_window)
4628 (struct tui_data_window, struct tui_cmd_window) <name>: New
4630 (tui_win_name): Don't declare.
4631 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4632 (tui_win_name): Remove.
4634 2019-06-25 Tom Tromey <tom@tromey.com>
4636 * tui/tui-winsource.h (tui_update_source_window)
4637 (tui_update_source_window_as_is): Change parameter type.
4638 * tui/tui-winsource.c (tui_update_source_window): Change win_info
4639 to be a tui_source_window_base.
4640 (tui_update_source_window_as_is): Likewise.
4641 * tui/tui-win.c (make_visible_with_new_height): Update.
4643 2019-06-25 Tom Tromey <tom@tromey.com>
4645 * tui/tui-winsource.c (tui_erase_source_content)
4646 (tui_show_source_content, tui_show_exec_info_content)
4647 (tui_erase_exec_info_content): Use refresh_window method.
4648 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4649 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4650 from tui_refresh_win.
4651 (tui_data_window::refresh_window): New method.
4652 (tui_win_info::refresh, tui_source_window_base::refresh)
4653 (tui_refresh_all): Use refresh_window method.
4654 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4656 * tui/tui-regs.c (tui_display_register): Call refresh_window
4658 * tui/tui-layout.c (show_source_disasm_command)
4659 (show_source_or_disasm_and_command): Call refresh_window method.
4660 * tui/tui-data.h (struct tui_gen_win_info)
4661 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4664 2019-06-25 Tom Tromey <tom@tromey.com>
4666 * tui/tui.c (tui_rl_other_window, tui_enable)
4667 (tui_is_window_visible, tui_get_command_dimension): Update.
4668 * tui/tui-winsource.c (tui_update_source_window_as_is)
4669 (tui_clear_source_content, tui_erase_source_content)
4670 (tui_show_source_line, tui_source_window_base::refill)
4671 (tui_source_window_base::do_scroll_horizontal)
4672 (tui_source_window_base::set_is_exec_point_at)
4673 (tui_update_breakpoint_info, tui_set_exec_info_content)
4674 (tui_alloc_source_buffer, tui_line_is_displayed)
4675 (tui_addr_is_displayed): Update.
4676 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4677 (tui_check_and_display_highlight_if_needed)
4678 (tui_win_info::make_visible, tui_win_info::refresh)
4679 (tui_refresh_all): Update.
4680 * tui/tui-windata.c (tui_first_data_item_displayed)
4681 (tui_delete_data_content_windows, tui_erase_data_content)
4682 (tui_display_all_data, tui_data_window::refresh_all)
4683 (tui_check_data_values): Update.
4684 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4685 (tui_set_win_focus_to, tui_win_info::forward_scroll)
4686 (tui_win_info::backward_scroll, tui_refresh_all_win)
4687 (tui_resize_all, tui_set_focus, tui_all_windows_info)
4688 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4689 (tui_source_window_base::set_new_height)
4690 (tui_data_window::set_new_height)
4691 (make_invisible_and_set_new_height)
4692 (make_visible_with_new_height, new_height_ok)
4693 (parse_scrolling_args): Update.
4694 * tui/tui-stack.c (tui_show_frame_info): Update.
4695 * tui/tui-source.c (tui_set_source_content)
4696 (tui_set_source_content_nil, tui_source_is_displayed)
4697 (tui_source_window::do_scroll_vertical): Update.
4698 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4699 (tui_display_registers_from, tui_display_reg_element_at_line)
4700 (tui_check_register_values, tui_reg_command): Update.
4701 * tui/tui-layout.c (tui_default_win_height)
4702 (show_source_disasm_command, show_data, init_and_make_win)
4703 (show_source_or_disasm_and_command): Update.
4704 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4705 (tui_redisplay_readline, tui_mld_flush)
4706 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4708 * tui/tui-disasm.c (tui_set_disassem_content)
4709 (tui_disasm_window::do_scroll_vertical): Update.
4710 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4712 (struct tui_win_info): Derive from tui_gen_win_info.
4713 <~tui_win_info>: Mark as override.
4714 <generic>: Remove member.
4715 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4716 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4717 (~tui_data_window, ~tui_win_info)
4718 (tui_free_all_source_wins_content): Update.
4719 * tui/tui-command.c (tui_refresh_cmd_win): Update.
4721 2019-06-25 Tom Tromey <tom@tromey.com>
4723 * tui/tui-layout.c (init_and_make_win): Use new.
4724 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4725 destructor, initializers.
4726 (tui_alloc_generic_win_info): Don't declare.
4727 * tui/tui-data.c (_locator): Add argument to constructor.
4728 (source_win, disasm_win): New globals.
4729 (exec_info): Remove.
4730 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4732 (tui_alloc_generic_win_info): Remove.
4733 (init_content_element): Use new.
4734 (tui_win_info::tui_win_info): Update.
4735 (free_content_elements) <case DATA_WIN>: Use delete.
4737 2019-06-25 Tom Tromey <tom@tromey.com>
4739 * tui/tui-wingeneral.c (tui_refresh_win): Update.
4740 * tui/tui-windata.c (tui_first_data_item_displayed)
4741 (tui_delete_data_content_windows): Update.
4742 * tui/tui-win.c (tui_data_window::set_new_height): Update.
4743 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4744 (tui_display_registers_from, tui_check_register_values): Update.
4745 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4747 * tui/tui-data.c (init_content_element): Update. Allocate the new
4749 (tui_free_data_content): Update.
4750 (free_content_elements) <case DATA_WIN>: Free the window.
4752 2019-06-25 Tom Tromey <tom@tromey.com>
4754 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4756 * tui/tui-layout.c (make_command_window)
4757 (show_source_disasm_command, show_data, init_and_make_win)
4758 (show_source_or_disasm_and_command): Update.
4759 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4761 <can_highight, is_highlighted>: Now bool.
4762 (tui_set_win_highlight): Don't declare.
4763 * tui/tui-data.c (tui_set_win_highlight): Remove.
4765 2019-06-25 Tom Tromey <tom@tromey.com>
4767 * tui/tui-wingeneral.c (make_visible): Remove check of window
4770 2019-06-25 Tom Tromey <tom@tromey.com>
4772 * tui/tui-win.c (tui_win_info::max_height)
4773 (tui_cmd_window::max_height): New methods.
4774 (new_height_ok): Call max_height.
4775 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4776 <max_height>: New method.
4778 2019-06-25 Tom Tromey <tom@tromey.com>
4780 * tui/tui-win.c (tui_source_window_base::set_new_height)
4781 (tui_data_window::set_new_height): New methods.
4782 (make_invisible_and_set_new_height): Call set_new_height method.
4783 * tui/tui-data.h (struct tui_win_info)
4784 (struct tui_source_window_base, struct tui_data_window)
4785 <set_new_height>: New method.
4787 2019-06-25 Tom Tromey <tom@tromey.com>
4789 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4790 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4791 tui_refresh_data_win.
4792 * tui/tui-win.c (tui_source_window_base::refresh_all): New
4794 (tui_refresh_all_win): Call the refresh_all method.
4795 (tui_set_focus): Likewise.
4796 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4797 (struct tui_source_window_base, struct tui_data_window) <refresh>:
4800 2019-06-25 Tom Tromey <tom@tromey.com>
4802 * tui/tui-winsource.h (tui_refill_source_window)
4803 (tui_set_is_exec_point_at): Don't declare.
4804 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4805 (tui_source_window_base::refill): Rename from
4806 tui_refill_source_window.
4807 (tui_source_window_base::do_scroll_horizontal): Update.
4808 (tui_source_window_base::set_is_exec_point_at): Rename from
4809 tui_set_is_exec_point_at.
4810 (tui_update_all_breakpoint_info): Update.
4811 * tui/tui-stack.c (tui_show_frame_info): Update.
4812 * tui/tui-layout.c (show_data): Add cast.
4813 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4814 * tui/tui-data.h (struct tui_source_window_base) <refill,
4815 set_is_exec_point_at>: New methods.
4816 (tui_source_windows, tui_add_to_source_windows): Update types.
4817 (tui_add_to_source_windows): Remove redundant declaration.
4818 * tui/tui-data.c (source_windows): Store tui_source_window_base.
4819 (tui_source_windows): Change return type.
4820 (tui_clear_source_windows_detail): Update.
4821 (tui_add_to_source_windows): Change type of parameter.
4822 (tui_free_all_source_wins_content): Update.
4824 2019-06-25 Tom Tromey <tom@tromey.com>
4826 * tui/tui-wingeneral.c (tui_win_info::refresh)
4827 (tui_source_window_base::refresh): New methods.
4828 (tui_refresh_all): Call the refresh method.
4829 * tui/tui-data.h (struct tui_win_info)
4830 (struct tui_source_window_base) <refresh>: New method.
4832 2019-06-25 Tom Tromey <tom@tromey.com>
4834 * tui/tui.h (tui_is_window_visible): Return bool.
4835 * tui/tui.c (tui_is_window_visible): Return bool.
4836 * tui/tui-wingeneral.c (tui_make_window, make_visible)
4837 (tui_make_visible, tui_make_invisible)
4838 (tui_win_info::make_visible)
4839 (tui_source_window_base::make_visible, make_all_visible)
4840 (tui_make_all_visible, tui_make_all_invisible): Update.
4841 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4842 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4844 (struct tui_win_info, struct tui_source_window_base)
4845 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4846 * tui/tui-data.c (tui_init_generic_part): Update.
4848 2019-06-25 Tom Tromey <tom@tromey.com>
4850 * tui/tui-wingeneral.c (tui_win_info::make_visible)
4851 (tui_source_window_base::make_visible): New methods.
4852 (make_all_visible): Make method call.
4853 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4854 (struct tui_source_window_base, struct tui_cmd_window): Override
4856 (tui_win_is_source_type): Don't declare.
4857 * tui/tui-data.c (tui_win_is_source_type): Remove.
4859 2019-06-25 Tom Tromey <tom@tromey.com>
4861 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4864 2019-06-25 Tom Tromey <tom@tromey.com>
4866 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4867 Inline constructor. Add initializers for members.
4868 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4869 constructors; now inline in class.
4871 2019-06-25 Tom Tromey <tom@tromey.com>
4873 * tui/tui-regs.c (tui_show_registers): Update.
4874 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4876 * tui/tui-data.c (tui_data_window::clear_detail)
4877 (tui_data_window): Update.
4879 2019-06-25 Tom Tromey <tom@tromey.com>
4881 * tui/tui-windata.c (tui_display_all_data)
4882 (tui_display_data_from_line, tui_display_data_from)
4883 (tui_check_data_values, tui_data_window::do_scroll_vertical):
4885 * tui/tui-regs.c (tui_last_regs_line_no)
4886 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4887 (tui_show_registers, tui_show_register_group)
4888 (tui_display_registers_from, tui_display_reg_element_at_line)
4889 (tui_display_registers_from_line, tui_check_register_values)
4890 (tui_reg_next, tui_reg_prev): Update.
4891 * tui/tui-layout.c (tui_set_layout, show_data): Update.
4892 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
4894 (struct tui_win_info) <detail>: Remove. Add new fields from
4896 (TUI_DATA_WIN): Add cast.
4897 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4898 (~tui_data_window): Simplify.
4900 2019-06-25 Tom Tromey <tom@tromey.com>
4902 * tui/tui-layout.c (show_source_disasm_command)
4903 (show_source_or_disasm_and_command): Update.
4904 * tui/tui-io.c (update_cmdwin_start_line)
4905 (tui_redisplay_readline): Update.
4906 * tui/tui-data.h (struct tui_command_info): Remove.
4907 (struct tui_win_info) <detail>: Remove command_info member.
4908 (struct tui_data_window) <start_line>: New member, from
4910 (TUI_CMD_WIN): Add casts.
4912 2019-06-25 Tom Tromey <tom@tromey.com>
4914 * tui/tui-winsource.c (tui_update_source_window)
4915 (tui_refill_source_window)
4916 (tui_source_window_base::do_scroll_horizontal)
4917 (tui_update_breakpoint_info, tui_set_exec_info_content)
4918 (tui_show_exec_info_content, tui_erase_exec_info_content)
4919 (tui_clear_exec_info_content): Update.
4920 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4922 * tui/tui-win.c (make_invisible_and_set_new_height)
4923 (make_visible_with_new_height): Update.
4924 * tui/tui-source.c (tui_set_source_content)
4925 (tui_show_symtab_source): Update.
4926 * tui/tui-layout.c (extract_display_start_addr)
4927 (show_source_disasm_command, show_data)
4928 (make_source_or_disasm_window)
4929 (show_source_or_disasm_and_command): Update.
4930 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4931 (tui_disasm_window::do_scroll_vertical): Remove shadowing
4933 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
4934 to tui_source_window_base.
4935 (struct tui_win_info) <detail>: Remove source_info member.
4936 (struct tui_source_window_base) <has_locator>: Inline.
4937 Move contents from tui_source_info; rename has_locator member to
4939 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4940 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4942 (tui_source_window_base::clear_detail, ~tui_source_window_base):
4944 (tui_free_all_source_wins_content): Cast to
4945 tui_source_window_base.
4947 2019-06-25 Tom Tromey <tom@tromey.com>
4949 * tui/tui-win.c (make_invisible_and_set_new_height)
4950 (make_visible_with_new_height): Call has_locator method.
4951 * tui/tui-layout.c (show_source_disasm_command, show_data)
4952 (show_source_or_disasm_and_command): Update for bool change.
4953 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4954 (tui_win_info) <has_locator>: New method.
4955 (struct tui_source_window_base) <has_locator>: New method.
4956 (tui_win_has_locator): Don't declare.
4957 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4958 from tui_win_has_locator.
4959 (tui_source_window_base): Use false, not FALSE.
4961 2019-06-25 Tom Tromey <tom@tromey.com>
4963 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4964 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4965 clear_detail method directly.
4966 (tui_clear_win_detail): Remove.
4968 2019-06-25 Tom Tromey <tom@tromey.com>
4970 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4971 "this", not TUI_DISASM_WIN.
4973 2019-06-25 Tom Tromey <tom@tromey.com>
4975 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
4977 * tui/tui-winsource.c
4978 (tui_source_window_base::do_scroll_horizontal): Rename from
4979 tui_horizontal_source_scroll.
4980 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4981 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4982 from tui_vertical_data_scroll.
4983 * tui/tui-win.h (tui_scroll): Don't declare.
4984 * tui/tui-win.c (tui_win_info::forward_scroll)
4985 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4986 (tui_win_info::right_scroll): Rename and update.
4987 (tui_scroll_forward_command, tui_scroll_backward_command)
4988 (tui_scroll_left_command, tui_scroll_right_command): Update.
4989 (tui_scroll): Remove.
4990 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4991 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4992 from tui_vertical_source_scroll.
4993 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4994 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4995 from tui_vertical_disassem_scroll.
4996 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4997 do_scroll_horizontal>: New methods.
4998 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5000 (struct tui_source_window_base): Add do_scroll_horizontal.
5001 (struct tui_source_window, struct tui_disasm_window): Add
5003 (struct tui_data_window, struct tui_cmd_window): Add
5004 do_scroll_horizontal and do_scroll_vertical.
5005 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5007 2019-06-25 Tom Tromey <tom@tromey.com>
5009 * tui/tui-data.h (struct tui_source_window_base): New struct.
5010 (struct tui_source_window): Derive from tui_source_window_base.
5011 (struct tui_disasm_window): New struct.
5012 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5013 from tui_source_window::clear_detail.
5014 (tui_source_window_base): Rename from tui_source_window.
5015 (~tui_source_window_base): Rename from ~tui_source_window.
5016 (tui_alloc_win_info): Create a tui_disasm_window.
5018 2019-06-25 Tom Tromey <tom@tromey.com>
5020 * tui/tui-data.h (struct tui_source_window)
5021 (struct tui_data_window): Declare destructors.
5022 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5024 (tui_win_info): Simplify.
5026 2019-06-25 Tom Tromey <tom@tromey.com>
5028 * tui/tui-winsource.c (tui_display_main)
5029 (tui_update_source_windows_with_addr)
5030 (tui_update_all_breakpoint_info): Update.
5031 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5032 (new_height_ok, parse_scrolling_args): Update.
5033 * tui/tui-stack.c (tui_show_frame_info): Update.
5034 * tui/tui-data.h (struct tui_list): Remove.
5035 (tui_source_windows): Return a reference to a std::vector.
5036 * tui/tui-data.c (source_windows): Now a std::vector.
5037 (tui_source_windows): Change return type.
5038 (tui_clear_source_windows): Rewrite.
5039 (tui_clear_source_windows_detail, tui_add_to_source_windows)
5040 (tui_free_all_source_wins_content): Rewrite.
5042 2019-06-25 Tom Tromey <tom@tromey.com>
5044 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5045 (struct tui_data_window, struct tui_cmd_window): Declare
5046 clear_detail method.
5047 * tui/tui-data.c (tui_source_window::clear_detail)
5048 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5050 (tui_clear_win_detail): Simplify.
5052 2019-06-25 Tom Tromey <tom@tromey.com>
5054 * tui/tui-layout.c (make_source_window, make_disasm_window)
5055 (make_source_or_disasm_window): Remove win_info_ptr parameter.
5056 Return the new window.
5057 (show_source_disasm_command, show_data)
5058 (show_source_or_disasm_and_command): Update.
5060 2019-06-25 Tom Tromey <tom@tromey.com>
5062 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5063 parameter. Return the new window.
5064 (show_source_disasm_command): Update and remove NULL check.
5065 (show_source_or_disasm_and_command): Update.
5067 2019-06-25 Tom Tromey <tom@tromey.com>
5069 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5071 2019-06-25 Tom Tromey <tom@tromey.com>
5073 * tui/tui-data.h (struct tui_win_info): Make constructor
5074 protected. Make destructor virtual. Add initializers.
5075 (tui_source_window, tui_data_window, tui_cmd_window): New
5077 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
5078 constructor. Add "type" parameter.
5079 (tui_source_window, tui_data_window, tui_cmd_window): New
5081 (tui_alloc_win_info): Instantiate the appropriate subclass.
5083 2019-06-25 Tom Tromey <tom@tromey.com>
5085 * tui/tui-win.c (tui_resize_all): Use delete.
5086 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5088 (tui_free_window): Don't declare.
5089 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5092 2019-06-25 Tom Tromey <tom@tromey.com>
5094 * tui/tui-data.h (struct tui_win_info): Add constructor.
5095 * tui/tui-data.c (tui_alloc_win_info): Use new.
5096 (tui_free_window): Use delete.
5098 2019-06-22 Tom Tromey <tom@tromey.com>
5100 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5102 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5104 2019-06-22 Tom Tromey <tom@tromey.com>
5106 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5108 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5110 2019-06-22 Tom de Vries <tdevries@suse.de>
5112 * dwarf2read.c (create_addrmap_from_aranges)
5113 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5116 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
5118 * dwarf2read.h (dwarf2_section_info_def): Remove.
5119 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5120 * dwarf2read.c (struct dwo_sections) <types>: Change type to
5121 std::vector<dwarf2_section_info>.
5122 (struct dwo_file) <~dwo_file>: Remove.
5123 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5125 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5126 (dwarf2_read_debug_names): Likewise.
5127 (create_debug_types_hash_table): Change parameter type to
5128 array_view, adjust code accordingly.
5129 (dwarf2_locate_dwo_sections): Adjust to std::vector.
5130 (partial_die_info::fixup): Likewise.
5131 (determine_prefix): Likewise.
5132 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5134 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5136 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5138 <~dwo_file>: Remove call to gdb_bfd_unref.
5139 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5140 gdb_bfd_ref_ptr::get.
5142 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5144 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5146 * dwarf2read.c (struct dwo_file): Initialize fields.
5148 (free_dwo_file): Remove, move content to ~dwo_file.
5149 (struct dwo_file_deleter): Remove.
5150 (dwo_file_up>: Remove custom deleter.
5151 (free_dwo_files): Remove.
5152 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5154 (process_skeletonless_type_units): Call unique_ptr::get.
5155 (allocate_dwo_file_hash_table): Add deleter to created hash
5156 table. Change return type to htab_up.
5157 (lookup_dwo_file_slot): Don't memset dwo_file, call
5159 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5160 (create_dwo_unit_in_dwp_v2): Likewise.
5161 (open_and_init_dwo_file): Likewise.
5162 (free_dwo_file_from_slot): Remove.
5164 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5166 * dwarf2read.h (struct dwarf2_section_info) <readin,
5167 is_virtual>: Change type to bool.
5168 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5171 2019-06-19 Tom Tromey <tom@tromey.com>
5173 * tui/tui-data.h (tui_init_content_element): Don't declare.
5175 2019-06-19 Tom Tromey <tom@tromey.com>
5177 * tui/tui-data.h (tui_init_win_info): Don't declare.
5179 2019-06-19 Tom de Vries <tdevries@suse.de>
5181 * dwarf2read.h (abstract_to_concrete): Change type to
5182 std::unordered_map<sect_offset, std::vector<sect_offset>,
5183 gdb::hash_enum<sect_offset>>.
5185 2019-06-19 Tom Tromey <tromey@adacore.com>
5187 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5188 EVAL_AVOID_SIDE_EFFECTS specially.
5190 2019-06-19 Tom Tromey <tromey@adacore.com>
5192 * source-cache.c (highlighter): New global.
5193 (source_cache::get_source_lines): Create a highlighter on demand.
5195 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
5197 * defs.h (deprecated_interactive_hook): Delete declaration.
5198 * interps.c (clear_interpreter_hooks): Remove use of
5199 deprecated_interactive_hook.
5200 * top.c (deprecated_interactive_hook): Delete definition.
5201 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5203 2019-06-18 Tom de Vries <tdevries@suse.de>
5206 * dwarf2read.h (abstract_to_concrete): Change type from
5207 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5208 std::unordered_map<sect_offset, std::vector<sect_offset>>.
5209 * dwarf2read.c (read_variable): Update.
5210 (dwarf2_fetch_die_loc_sect_off): Update.
5212 2019-06-17 Tom de Vries <tdevries@suse.de>
5215 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5216 accessing parent[parent_len - 1].
5218 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
5221 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5222 call dtrace_process_dof with NULL dof.
5224 2019-06-16 Tom de Vries <tdevries@suse.de>
5227 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5229 2019-06-16 Tom Tromey <tom@tromey.com>
5231 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5232 (make_all_visible): Use address of member.
5234 2019-06-16 Tom Tromey <tom@tromey.com>
5236 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5237 (tui_free_window, free_content, free_content_elements): Remove
5239 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5241 * tui/tui-regs.c (tui_show_register_group)
5242 (tui_display_registers_from, tui_display_reg_element_at_line):
5243 Remove unnecessary cast.
5245 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
5247 * linux-nat.c (normal_mask): Delete.
5248 (_initialize_linux_nat): Don't initialise normal_mask.
5250 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
5253 * dwarf-index-write.h (write_psymtabs_to_index): Add
5254 dwz_basename parameter.
5255 * dwarf-index-write.c (write_gdbindex): Move file writing to
5256 write_gdbindex_1. Change return type void.
5257 (assert_file_size): Move up, remove filename parameter.
5258 (write_gdbindex_1): New function.
5259 (write_debug_names): Change return type to void, call
5261 (struct index_wip_file): New struct.
5262 (write_psymtabs_to_index): Add dwz_basename parameter. Move
5263 file logic to index_wip_file. Write index for dwz file if
5265 (save_gdb_index_command): Pass basename of dwz file, if present.
5266 * dwarf-index-cache.c (index_cache::store): Obtain and pass
5267 build-id of dwz file, if present.
5268 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5269 (dwarf2_get_dwz_file): Likewise.
5270 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5271 (dwarf2_get_dwz_file): Likewise.
5273 2019-06-16 Tom Tromey <tom@tromey.com>
5275 * coffread.c (process_coff_symbol): Use xstrdup.
5276 * value.c (create_internalvar): Use xstrdup.
5278 2019-06-16 Tom Tromey <tom@tromey.com>
5280 * valops.c (value_cast, value_slice): Remove unnecessary cast.
5281 * breakpoint.c (stopin_command, stopat_command)
5282 (until_break_command, decode_location_default): Remove unnecessary
5284 * utils.c (subset_compare): Remove unnecessary cast.
5285 * ada-lang.c (ada_update_initial_language): Remove unnecessary
5287 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5289 * infcmd.c (path_command): Remove unnecessary cast.
5290 * coffread.c (decode_type): Remove unnecessary cast.
5291 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5292 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5293 * tui/tui-stack.c (tui_show_locator_content)
5294 (tui_show_frame_info): Remove unnecessary cast.
5295 * tui/tui-win.c (tui_scroll_forward_command)
5296 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5297 (parse_scrolling_args): Remove unnecessary cast.
5298 * tui/tui-data.c (init_win_info, tui_del_window)
5299 (tui_free_window, tui_del_data_windows, tui_free_data_content)
5300 (free_content_elements): Remove unnecessary cast.
5301 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5303 * tui/tui-source.c (tui_set_source_content)
5304 (tui_vertical_source_scroll): Remove unnecessary cast.
5305 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5307 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5308 * tui/tui-regs.c (tui_display_registers_from)
5309 (tui_display_register): Remove unnecessary cast.
5310 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5311 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5312 (make_visible): Remove unnecessary cast.
5313 * tui/tui-winsource.c (tui_erase_source_content)
5314 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5316 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5317 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5318 * stabsread.c (read_type, read_array_type, read_range_type):
5319 Remove unnecessary cast.
5320 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5321 (parse_symbol, parse_type, upgrade_type, parse_external)
5322 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5324 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5326 2019-06-16 Tom Tromey <tom@tromey.com>
5328 * tui/tui-data.c (tui_alloc_generic_win_info)
5329 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5332 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
5333 Andrew Burgess <andrew.burgess@embecosm.com>
5335 * f-typeprint.c (f_print_type): Don't return early for not
5336 associated or not allocated types.
5337 (f_type_print_varspec_suffix): Add print_rank parameter and print
5338 ranks of array types in case they dangling.
5339 (f_type_print_base): Add print_rank parameter.
5341 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5343 * NEWS: Mention new MI commands.
5344 * break-catch-throw.c (enum exception_event_kind): Move to
5346 (print_mention_exception_catchpoint): Output text as a single
5348 (catch_exception_command_1): Rename to...
5349 (catch_exception_event): ...this, make non-static, update header
5350 command, and change some parameter types.
5351 (catch_catch_command): Update for changes to
5352 catch_exception_command_1.
5353 (catch_throw_command): Likewise.
5354 (catch_rethrow_command): Likewise.
5355 * breakpoint.c (enum exception_event_kind): Delete.
5356 * breakpoint.h (enum exception_event_kind): Moved here from
5357 break-catch-throw.c.
5358 (catch_exception_event): Declare.
5359 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5360 (mi_cmd_catch_throw): New function.
5361 (mi_cmd_catch_rethrow): New function.
5362 (mi_cmd_catch_catch): New function.
5363 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5364 'catch-catch' entries.
5365 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5366 (mi_cmd_catch_rethrow): Declare.
5367 (mi_cmd_catch_catch): Declare.
5369 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5371 * annotate.c (annotate_source_line): Change return type to void,
5372 update implementation to match.
5373 * annotate.h (annotate_source_line): Change return type to void,
5374 update header comment.
5375 * stack.c (print_frame_info): Don't change what frame information
5376 is printed based on whether annotations are on or not.
5378 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5380 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5381 (annotate_source): Make static.
5382 (annotate_source_line): Moved from source.c and renamed from
5383 identify_source_line. Update the return type.
5384 * annotate.h (annotate_source): Delete declaration.
5385 (annotate_source_line): Declaration moved from source.h, and
5386 renamed from identify_source_line. Return type updated.
5387 * source.c (identify_source_line): Moved to annotate.c and renamed
5388 to annotate_source_line.
5389 (info_line_command): Remove check of annotation_level.
5390 * source.h (identify_source_line): Move declaration to annotate.h
5391 and rename to annotate_source_line.
5392 * stack.c: Add 'annotate.h' include.
5393 (print_frame_info): Remove check of annotation_level before
5394 calling annotate_source_line.
5396 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5398 * source-cache.c (source_cache::get_plain_source_lines): Use
5399 open_source_file_with_line_charpos instead of just
5400 open_source_file, remove call to find_source_lines.
5401 (source_cache::get_source_lines): Likewise.
5402 * source.c (find_source_lines): Make static.
5403 (get_filename_and_charpos): Renamed into...
5404 (open_source_file_with_line_charpos): ..this along with changes to
5405 return a scoped_fd, and some other minor clean ups.
5406 (identify_source_line): Use open_source_file_with_line_charpos.
5407 (search_command_helper): Use open_source_file_with_line_charpos
5408 instead of just open_source_file, remove call to
5410 * source.h (open_source_file_with_line_charpos): Declare new
5412 (find_source_lines): Delete declaration.
5414 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5416 * source.c (get_filename_and_charpos): Remove fullname
5418 (identify_source_line): Update call to get_filename_and_charpos.
5420 2019-06-14 Tom Tromey <tromey@adacore.com>
5423 * ui-style.h (skip_ansi_escape): Update comment.
5424 * ui-file.h (class no_terminal_escape_file): New class.
5425 * ui-file.c (no_terminal_escape_file::write)
5426 (no_terminal_escape_file::puts): New methods.
5427 * cli/cli-logging.c (handle_redirections): Use
5428 no_terminal_escape_file.
5430 2019-06-14 Tom Tromey <tromey@adacore.com>
5432 * NEWS: Move convenience variable news above Python news.
5434 2019-06-14 Tom Tromey <tom@tromey.com>
5436 * gnulib: Move directory to top-level.
5437 * configure.ac: Don't configure gnulib.
5438 * configure: Rebuild.
5439 * common/common-defs.h: Use new path to gnulib.
5440 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5442 (INCGNU): Look in new gnulib location.
5443 (HFILES_NO_SRCDIR): Remove gnulib files.
5444 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5445 (generated_files): Remove GNULIB_H.
5446 ($(LIBGNU), all-lib): Remove targets.
5447 (distclean): Don't mention GNULIB_BUILDDIR.
5448 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5450 2019-06-14 Tom Tromey <tromey@adacore.com>
5452 * symfile.c (add_symbol_file_command): Remove obsolete comment.
5453 Warn if symbol file does not provide any symbols.
5455 2019-06-14 Tom Tromey <tromey@adacore.com>
5457 * source.c (find_and_open_source): Respect basenames_may_differ.
5459 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
5461 * annotate.c (annotate_breakpoints_invalid): Make use of
5462 scoped_restore_terminal_state.
5463 (annotate_frames_invalid): Likewise.
5465 2019-06-14 Tom Tromey <tromey@adacore.com>
5467 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5468 allow assignment to an internalvar.
5470 2019-06-14 Tom Tromey <tromey@adacore.com>
5472 * ada-lex.l: Allow "_" in attribute names.
5474 2019-06-14 Tom Tromey <tromey@adacore.com>
5477 * regcache.c (registers_changed): Don't call alloca.
5478 * top.c (execute_command): Don't call alloca.
5480 2019-06-13 Pedro Alves <palves@redhat.com>
5482 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5483 'expression'. When parsing an expression, error out if there's
5484 junk after "unlimited".
5485 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5486 (do_set_command): Adjust calls to is_unlimited_literal.
5488 2019-06-13 Pedro Alves <palves@redhat.com>
5490 * compile/compile.c (make_compile_options_def_group): Add braces
5491 around array_view initializer.
5492 * thread.c (make_thread_apply_all_options_def_group)
5493 (make_thread_apply_all_options_def_group): Likewise.
5495 2019-06-13 Pedro Alves <palves@redhat.com>
5497 * NEWS (New commands): Mention "maint test-options
5498 require-delimiter", "maint test-options unknown-is-error", "maint
5499 test-options unknown-is-operand" and "maint show
5500 test-options-completion-result".
5501 (New command options, command completion): New section.
5502 (Completion improvements): New section.
5503 Mention that you can abbreviate "unlimited".
5505 2019-06-13 Pedro Alves <palves@redhat.com>
5507 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5508 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5509 * unittests/cli-utils-selftests.c (test_parse_flags)
5510 (test_parse_flags_qcs): Delete.
5511 (test_cli_utils): Don't call deleted functions.
5513 2019-06-13 Pedro Alves <palves@redhat.com>
5515 * thread.c: Include "cli/cli-option.h".
5516 (tp_array_compar_ascending): Global.
5517 (tp_array_compar): Delete function.
5518 (tp_array_compar_ascending, tp_array_compar_descending): New
5520 (ascending_option_def, qcs_flag_option_def)
5521 (thr_qcs_flags_option_defs)
5522 (make_thread_apply_all_options_def_group)
5523 (make_thread_apply_options_def_group): New.
5524 (thread_apply_all_command): Use gdb::option::process_options.
5525 (thread_apply_command_completer)
5526 (thread_apply_all_command_completer): New.
5527 (thread_apply_command): Use gdb::option::process_options.
5528 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5529 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
5530 to generate help text of "thread apply". Adjust "taas"'s help.
5531 * tid-parse.c (tid_range_parser::in_thread_range): New method.
5532 * tid-parse.h (tid_range_parser::in_thread_range): New method.
5534 2019-06-13 Pedro Alves <palves@redhat.com>
5536 * thread.c (thread_apply_command): Check for invalid TID with
5537 isdigit instead of !isalpha.
5539 2019-06-13 Pedro Alves <palves@redhat.com>
5541 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5542 (validate_flags_qcs): New.
5543 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5544 (validate_flags_qcs): Declare.
5545 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5546 (make_frame_apply_options_def_group): New.
5547 (frame_apply_command_count): Process options with
5548 gdb::option::process_options.
5549 (frame_apply_completer): New.
5550 (frame_apply_level_completer, frame_apply_all_completer)
5551 (frame_apply_completer): New.
5552 (_initialize_stack): Update help of "frame apply", "frame apply
5553 level", "frame apply all" and "faas" to mention supported options
5554 and install command completers.
5555 * stack.h (frame_apply_all_completer): Declare.
5556 * thread.c: Include "stack.h".
5557 (tfaas_command): Add "--".
5558 (_initialize_thread): Update help "tfaas" to mention supported
5559 options and install command completer.
5561 2019-06-13 Pedro Alves <palves@redhat.com>
5563 * completer.c (complete_nested_command_line): New.
5564 (gdb_completion_word_break_characters_throw): Add assertion.
5565 * completer.h (complete_nested_command_line): Declare.
5567 2019-06-13 Pedro Alves <palves@redhat.com>
5569 * stack.c (parse_backtrace_qualifiers): New.
5570 (backtrace_command): Use it.
5571 (backtrace_command_completer): Complete on qualifiers.
5573 2019-06-13 Pedro Alves <palves@redhat.com>
5575 * frame.c: Include "cli/cli-option.h.
5576 (user_set_backtrace_options): New.
5577 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5579 (get_prev_frame): Adjust.
5580 (boolean_option_def, uinteger_option_def)
5581 (set_backtrace_option_defs): New.
5582 (_initialize_frame): Adjust and use
5583 gdb::option::add_setshow_cmds_for_options to install "set
5584 backtrace past-main" and "set backtrace past-entry".
5585 * frame.h: Include "cli/cli-option.h".
5586 (struct frame_print_options): Forward declare.
5587 (print_frame_arguments_all, print_frame_arguments_scalars)
5588 (print_frame_arguments_none): Declare.
5589 (print_entry_values): Delete declaration.
5590 (struct frame_print_options, user_frame_print_options): New.
5591 (struct set_backtrace_options): New.
5592 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5593 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5594 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5595 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5596 (list_args_or_locals): Add frame_print_options parameter.
5597 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5598 * python/py-framefilter.c (enumerate_args): Pass down
5599 USER_FRAME_PRINT_OPTIONS.
5600 * stack.c: Include "cli/cli-option.h".
5601 (print_frame_arguments_all, print_frame_arguments_scalars)
5602 (print_frame_arguments_none): Declare.
5603 (print_raw_frame_arguments, print_entry_values): Delete.
5604 (user_frame_print_options): New.
5605 (boolean_option_def, enum_option_def, frame_print_option_defs):
5607 (struct backtrace_cmd_options): New.
5608 (bt_flag_option_def): New.
5609 (backtrace_command_option_defs): New.
5610 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5611 (print_frame_arg, read_frame_arg, print_frame_args)
5612 (print_frame_info, print_frame): Add frame_print_options parameter
5614 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5615 (backtrace_command_1): Add frame_print_options and
5616 backtrace_cmd_options parameters and use them.
5617 (make_backtrace_options_def_group): New.
5618 (backtrace_command): Process command options with
5619 gdb::option::process_options.
5620 (backtrace_command_completer): New.
5621 (_initialize_stack): Extend "backtrace"'s help to mention
5622 supported options. Install completer for "backtrace".
5623 Install some settings commands with add_setshow_cmds_for_options.
5625 2019-06-13 Pedro Alves <palves@redhat.com>
5627 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5628 and that "set/show print raw frame-arguments" are now deprecated.
5630 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5632 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5633 * stack.c (_initialize_stack): Install "set/show print
5634 raw-frame-arguments", and deprecate "set/show print raw
5636 * valprint.c (_initialize_valprint): Deprecate "set/show print
5639 2019-06-13 Pedro Alves <palves@redhat.com>
5641 * compile/compile.c (struct compile_options): New.
5642 (compile_flag_option_def, compile_command_option_defs)
5643 (make_compile_options_def_group): New.
5644 (compile_file_command): Handle options with
5645 gdb::option::process_options.
5646 (compile_file_command_completer): New function.
5647 (compile_code_command): Handle options with
5648 gdb::option::process_options.
5649 (compile_code_command_completer): New function.
5650 (_initialize_compiler): Install completers for "compile code" and
5651 "compile file". Mention available options in "compile code" and
5652 "compile code"'s help.
5653 * completer.c (advance_to_completion_word): New, factored out from
5655 (advance_to_expression_complete_word_point): ... this.
5656 (advance_to_filename_complete_word_point): New.
5657 * completer.h (advance_to_filename_complete_word_point): New
5660 2019-06-13 Pedro Alves <palves@redhat.com>
5662 * compile/compile.c: Include "cli/cli-option.h".
5663 (compile_print_value): Scope data pointer is now a
5664 value_print_options pointer; adjust.
5665 (compile_print_command): Process options. Scope data pointer is
5666 now a value_print_options pointer; adjust.
5667 (_initialize_compile): Update "compile print"'s help to include
5668 supported options. Install a completer for "compile print".
5669 * cp-valprint.c (show_vtblprint, show_objectprint)
5670 (show_static_field_print): Delete.
5671 (_initialize_cp_valprint): Don't install "set print
5672 static-members", "set print vtbl", "set print object" here.
5673 * printcmd.c: Include "cli/cli-option.h" and
5674 "common/gdb_optional.h".
5675 (print_command_parse_format): Rework to fill in a
5676 value_print_options instead of a format_data.
5677 (print_value): Change parameter type from format_data pointer to
5678 value_print_options reference. Adjust.
5679 (print_command_1): Process options. Adjust to pass down a
5680 value_print_options.
5681 (print_command_completer): New.
5682 (_initialize_printcmd): Install print_command_completer as
5683 handle_brkchars completer for the "print" command. Update
5684 "print"'s help to include supported options.
5685 * valprint.c: Include "cli/cli-option.h".
5686 (show_vtblprint, show_objectprint, show_static_field_print): Moved
5687 here from cp-valprint.c.
5688 (boolean_option_def, uinteger_option_def)
5689 (value_print_option_defs, make_value_print_options_def_group):
5690 New. Use gdb::option::add_setshow_cmds_for_options to install
5691 "set print elements", "set print null-stop", "set print repeats",
5692 "set print pretty", "set print union", "set print array", "set
5693 print address", "set print symbol", "set print array-indexes".
5694 * valprint.h: Include <string> and "cli/cli-option.h".
5695 (make_value_print_options_def_group): Declare.
5696 (print_value): Change parameter type from format_data pointer to
5697 value_print_options reference.
5698 (print_command_completer): Declare.
5700 2019-06-13 Pedro Alves <palves@redhat.com>
5702 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5703 (COMMON_SFILES): Add maint-test-settings.c.
5704 * cli/cli-decode.c (boolean_enums): New global, factored out from
5706 (add_setshow_boolean_cmd): ... here.
5707 * cli/cli-decode.h (boolean_enums): Declare.
5708 * cli/cli-option.c: New file.
5709 * cli/cli-option.h: New file.
5710 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5711 factored out from ...
5712 (parse_cli_boolean_value(const char *)): ... this.
5713 (is_unlimited_literal): Change parameter type to pointer to
5714 pointer. Adjust and advance ARG pointer.
5715 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5716 (parse_cli_var_enum): New, factored out from ...
5717 (do_set_command): ... this. Adjust.
5718 * cli/cli-setshow.h (parse_cli_boolean_value)
5719 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5720 (parse_cli_var_enum): Declare.
5721 * cli/cli-utils.c: Include "cli/cli-option.h".
5722 (get_ulongest): New.
5723 * cli/cli-utils.h (get_ulongest): Declare.
5724 (check_for_argument): New overloads.
5725 * maint-test-options.c: New file.
5727 2019-06-13 Pedro Alves <palves@redhat.com>
5729 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5730 parse a range if "-" is at the end of the string.
5732 2019-06-13 Pedro Alves <palves@redhat.com>
5734 * cli/cli-setshow.c (parse_auto_binary_operation)
5735 (parse_cli_boolean_value): Don't allow "o".
5737 2019-06-13 Pedro Alves <palves@redhat.com>
5739 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5740 * NEWS: Mention maint test-settings KIND.
5741 * maint-test-settings.c: New file.
5743 2019-06-13 Pedro Alves <palves@redhat.com>
5745 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5747 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5750 2019-06-13 Pedro Alves <palves@redhat.com>
5752 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5755 2019-06-13 Pedro Alves <palves@redhat.com>
5757 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5759 2019-06-13 Pedro Alves <palves@redhat.com>
5761 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5762 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5764 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5765 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5767 (check_for_argument): Skip spaces after argument.
5769 2019-06-13 Pedro Alves <palves@redhat.com>
5771 * thread.c (thread_apply_command): Adjust TID parsing.
5772 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5773 detected before end of string.
5774 (tid_is_in_list): Error out if LIST is invalid.
5776 2019-06-13 Pedro Alves <palves@redhat.com>
5778 * completer.c (complete_line_internal_1): Rewind completion word
5780 (completion_tracker::advance_custom_word_point_by): Change
5781 parameter type to int.
5782 * completer.h (completion_tracker::advance_custom_word_point_by):
5785 2019-06-13 Pedro Alves <palves@redhat.com>
5787 * completer.c (advance_to_completion_word): Handle delimiters.
5789 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
5791 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5793 2019-06-11 Tom Tromey <tom@tromey.com>
5795 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5796 (xmalloc_failed): Move to alloc.c.
5797 * alloc.c: New file.
5798 * Makefile.in (COMMON_SFILES): Add alloc.c.
5800 2019-06-11 Tom Tromey <tom@tromey.com>
5802 * nat/linux-waitpid.c: Don't include server.h.
5803 (linux_debug): Remove.
5804 (my_waitpid): Update.
5806 2019-06-11 Tom Tromey <tromey@adacore.com>
5808 * infcall.c (_initialize_infcall): Remove trailing newline from
5810 * user-regs.c (_initialize_user_regs): Remove trailing newline
5812 * typeprint.c (_initialize_typeprint): Remove trailing newline
5814 * reverse.c (_initialize_reverse): Remove trailing newlines from
5816 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5818 * language.c (add_set_language_command): Remove trailing newline
5820 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5822 * disasm.c (_initialize_disasm): Remove trailing newline from
5824 * top.c (init_main): Remove trailing newline from help.
5825 * interps.c (_initialize_interpreter): Remove trailing newline
5827 * btrace.c (_initialize_btrace): Remove trailing newlines from
5829 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5831 * python/python.c (_initialize_python): Remove trailing newline
5833 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5835 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5836 from help. Reformat some text.
5837 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5839 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5842 2019-06-11 Tom Tromey <tromey@adacore.com>
5844 * darwin-nat.c (darwin_decode_exception_message)
5845 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5847 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
5849 * valops.c (value_slice): Check for not allocated or not
5852 2019-06-10 Tom de Vries <tdevries@suse.de>
5855 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5856 sure an empty slot (defined by a 32-bit zero pair) is recognized as
5859 2019-06-10 Tom de Vries <tdevries@suse.de>
5862 * linespec.c (linespec_lexer_lex_string): Remove incorrect
5863 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
5865 2019-06-10 Tom de Vries <tdevries@suse.de>
5868 * symtab.c (struct demangled_name_entry): Add language field.
5869 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
5870 static minimal symbol". Set and use language field.
5872 2019-06-10 Tom Tromey <tromey@adacore.com>
5874 * ada-lang.c (_initialize_ada_language): Update help text.
5876 2019-06-10 Tom Tromey <tromey@adacore.com>
5878 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5880 * guile/guile.c (handle_boot_error): Don't end warning with a
5882 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5883 warning with a newline.
5884 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5886 (s12z_frame_cache): Likewise.
5887 * dwarf-index-cache.c (index_cache::store): Don't end warning with
5889 * solib-svr4.c (disable_probes_interface): Don't end warning with
5891 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5893 * python/python.c (do_finish_initialization): Don't end warning
5896 2019-06-10 Tom Tromey <tom@tromey.com>
5898 * python/py-breakpoint.c (gdbpy_breakpoint_created)
5899 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5902 2019-06-10 Tom Tromey <tromey@adacore.com>
5904 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5906 (elf_new_init): Don't call stabsread_new_init.
5907 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5908 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
5909 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5911 2019-06-10 Tom de Vries <tdevries@suse.de>
5915 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5917 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
5919 * source.c (find_and_open_source): Also rewrite relative file
5922 2019-04-26 Amos Bird <amosbird@gmail.com>
5924 * annotate.c (annotate_thread_exited): Add "thread-exited"
5927 2019-06-06 Tom Tromey <tromey@adacore.com>
5929 * maint.h (class scoped_command_stats): Use
5930 DISABLE_COPY_AND_ASSIGN.
5931 <print_time>: New method.
5932 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5934 (scoped_command_stats::print_time): New method.
5936 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
5938 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5939 instructions of lengths 6 or 8 bytes.
5941 2019-06-04 Pedro Alves <palves@redhat.com>
5943 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5945 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5946 * breakpoint.c (condition_completer): Likewise.
5947 * cli/cli-dump.c (scan_expression): Likewise.
5948 * common/filestuff.c (mkdir_recursive): Likewise.
5949 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5950 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5951 (gdb_abspath): Likewise.
5952 * compile/compile-cplus-types.c
5953 (compile_cplus_instance::decl_name): Likewise.
5954 * completer.c (complete_explicit_location):
5955 (signal_completer, reg_or_group_completer_1): Likewise.
5956 * cp-support.c (cp_remove_params_if_any): Likewise.
5957 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5958 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5959 * infcmd.c (strip_bg_char): Likewise.
5960 * linespec.c (copy_token_string): Likewise.
5961 * mi/mi-main.c (output_cores): Likewise.
5962 * psymtab.c (psymtab_search_name):
5963 * symfile.c (test_set_ext_lang_command): Likewise.
5964 * target.c (target_fileio_read_stralloc): Likewise.
5965 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5966 * value.c (complete_internalvar): Likewise.
5968 2019-06-04 Christian Biesinger <cbiesinger@google.com>
5970 Add objfile property to gdb.Type.
5971 * NEWS: Mention Python API addition.
5972 * python/py-type.c (typy_get_objfile): New method.
5974 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5976 * NEWS: Mention the new set|show style [title|highlight].
5977 Mention changes to "show style", "help" and "apropos".
5979 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5981 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5982 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
5983 instead of print_help_for_command.
5984 (print_doc_of_command): New function.
5985 (help_list): Add 'apropos -v word' suggestion.
5986 (print_help_for_command): Style the command name using title style.
5987 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5988 (_initialize_cli_cmds): Describe -v in apropos_command help.
5990 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5992 * cli/cli-style.h (cli_style_option): Add name in constructor,
5993 add m_name class member, add constructor with intensity,
5994 add name class function.
5995 (cli_style_option::add_setshow_commands): Remove name argument.
5996 (highlight_style, title_style): New styles.
5997 * cli/cli-style.c (do_show): New function that shows a style
5998 characteristic styling the style name with itself.
5999 (set_style_name): New function.
6000 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6001 Update all callers according to the changes in cli/cli-style.h.
6002 * utils.h (fputs_highlighted): New function.
6003 * utils.c (fputs_highlighted): Likewise.
6005 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6007 * NEWS: Mention new pipe command and new convenience variables.
6009 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6011 * cli/cli-cmds.c (pipe_command): New function.
6012 (_initialize_cli_cmds): Call add_com for pipe_command.
6013 Define | as an alias for pipe.
6014 (exit_status_set_internal_vars): New function.
6015 (shell_escape): Call exit_status_set_internal_vars.
6016 cli/cli-decode.c (find_command_name_length): Recognize | as
6017 a single character command.
6019 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6021 * gdbcmd.h (execute_command_to_ui_file): New declaration.
6022 top.c (execute_command_to_ui_file): New function, mostly a copy
6023 of execute_command_to_string.
6024 (execute_command_to_string): Implement by calling
6025 execute_command_to_ui_file.
6027 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6029 * top.h (saved_command_line): Remove declaration.
6030 * top.c (previous_saved_command_line, previous_repeat_arguments):
6032 (saved_command_line): Make static, define together with other
6034 (dont_repeat): Clear repeat_arguments.
6035 (repeat_previous, get_saved_command_line, save_command_line):
6037 (gdb_init): Initialize saved_command_line
6038 and previous_saved_command_line.
6039 * main.c (captured_main_1): Remove saved_command_line initialization.
6040 * event-top.c (handle_line_of_input): Update to use
6041 the new 'repeat' related functions instead of direct access to
6043 * command.h (repeat_previous, get_saved_command_line,
6044 save_command_line): New declarations.
6045 (dont_repeat): Add comment.
6047 2019-05-30 Tom Tromey <tromey@adacore.com>
6049 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6051 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6053 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
6056 * completer.c (complete): Initialize variable word.
6058 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
6060 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6061 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6062 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6063 'body' is NULL to the outter 'if', protecting the '!is_define'
6066 2019-05-29 Tom Tromey <tromey@adacore.com>
6068 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6069 (dwarf_unknown): New function.
6070 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6071 (dwarf_type_encoding_name): Use dwarf_unknown.
6073 2019-05-29 Tom Tromey <tromey@adacore.com>
6076 * cp-valprint.c (cp_print_value_fields): Call
6077 cp_print_static_field inside "try".
6079 2019-05-29 Tom Tromey <tromey@adacore.com>
6081 * inflow.c (struct terminal_info): Add default operator=.
6082 * configure: Rebuild.
6083 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6084 -Wdeprecated-copy-dtor, -Wredundant-move.
6086 2019-05-29 Tom Tromey <tromey@adacore.com>
6089 * infcmd.c (print_return_value_1): Handle finish_print
6091 (show_print_finish): New function.
6092 (_initialize_infcmd): Add "set/show print finish" commands.
6093 * valprint.c (user_print_options): Initialize new member.
6094 * valprint.h (struct value_print_options) <finish_print>: New
6097 2019-05-28 Tom Tromey <tromey@adacore.com>
6099 * ada-lang.c (ada_remove_Xbn_suffix)
6100 (find_old_style_renaming_symbol)
6101 (parse_old_style_renaming): Remove.
6102 (ada_find_renaming_symbol): Don't call
6103 find_old_style_renaming_symbol.
6104 (ada_is_renaming_symbol): Rename from
6105 ada_find_renaming_symbol. Remove "block" parameter. Return
6107 (ada_read_var_value): Update and simplify.
6108 * ada-exp.y (write_var_or_type): Remove old code.
6110 2019-05-28 Alan Hayward <alan.hayward@arm.com>
6112 * event-top.c: Remove include comment.
6113 * inflow.c (class scoped_ignore_sigttou): Move from here...
6114 * inflow.h (class scoped_ignore_sigttou): ...to here.
6115 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6116 * top.c: Remove include comment.
6118 2019-05-27 Tom Tromey <tom@tromey.com>
6122 2019-05-22 Tom Tromey <tromey@adacore.com>
6124 * target.c (target_follow_exec): Constify parameter.
6125 * target-delegates.c: Rebuild.
6126 * remote.c (remote_target::follow_exec): Constify parameter.
6127 * infrun.c (follow_exec): Constify parameter.
6128 * target.h (struct target_ops) <follow_exec>: Constify parameter.
6129 (target_follow_exec): Likewise.
6131 2019-05-22 Alan Hayward <alan.hayward@arm.com>
6133 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6134 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6136 2019-05-22 Alan Hayward <alan.hayward@arm.com>
6138 * NEWS: Add debugredirect and testsuite sections.
6140 2019-05-22 Simon Cook <simon.cook@embecosm.com>
6142 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6143 target descriptions using exclusively floating point register name
6146 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
6149 * f-lang.c (build_fortran_types): Handle the case where
6150 gdbarch_floatformat_for_type returns a nullptr.
6152 2019-05-21 Tom de Vries <tdevries@suse.de>
6155 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6157 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
6160 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6162 * i386-tdep.c (i386_floatformat_for_type): Use
6163 floatformats_ia64_quad for the 16-byte floating point component
6164 within a fortran 32-byte complex number.
6166 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
6168 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6169 delete default constructor.
6170 (find_partial_die): Update to return const struct.
6171 (partial_die_parent_scope): Move variable declaration into scope
6172 of its use and change its type to auto.
6173 (guess_partial_die_structure_name): Likewise.
6174 (partial_die_info::fixup): Likewise.
6176 2019-05-17 Tom Tromey <tromey@adacore.com>
6178 * source.c (find_and_open_source): Remove cast.
6180 2019-05-17 Tom Tromey <tromey@adacore.com>
6182 * annotate.c (annotate_source): Make "filename" const.
6183 * annotate.h (annotate_source): Use const.
6185 2019-05-17 Alan Hayward <alan.hayward@arm.com>
6187 * disasm.c (set_disassembler_options): Send errors to stderr.
6189 2019-05-17 Alan Hayward <alan.hayward@arm.com>
6191 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6192 (cli_interp_base::set_logging): Check debug_redirect.
6193 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6194 * cli/cli-logging.c (debug_redirect): Add static variable.
6195 (pop_output_files): Add default param.
6196 (handle_redirections): Print debug setting.
6197 (show_logging_command): Likewise.
6198 (_initialize_cli_logging): Add debugredirect command.
6199 * interps.c (current_interp_set_logging): Add debug_redirect
6201 * interps.h (set_logging): Add debug_redirect parameter.
6202 (current_interp_set_logging): Likewise.
6203 * mi/mi-common.h: Likewise.
6204 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6206 2019-05-17 Alan Hayward <alan.hayward@arm.com>
6207 Tom Tromey <tromey@adacore.com>
6209 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6211 * cli/cli-interp.h (make_logging_output): Remove declaration.
6212 * cli/cli-logging.c (make_logging_output): Remove function.
6213 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6215 * ui-file.c (tee_file::tee_file): Remove bools.
6216 (tee_file::~tee_file): Remove deletes.
6217 * ui-file.h (tee_file): Remove bools.
6219 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
6221 * mi/mi-cmds.h (mi_cmd_complete): New function.
6222 * mi/mi-main.c (mi_cmd_complete): Likewise.
6223 * mi/mi-cmds.c: Define new MI command -complete.
6224 * NEWS: Mention new -complete command.
6226 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
6228 * completer.h (complete): New function.
6229 * completer.c (complete): Likewise.
6230 * cli/cli-cmds.c: (complete_command): Update to use new complete()
6231 function defined in completer.h.
6233 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
6235 * MAINTAINERS (Write After Approval): Add myself.
6237 2019-05-17 Tom de Vries <tdevries@suse.de>
6240 * dwarf2read.c (struct cu_partial_die_info): New struct.
6241 (find_partial_die): Return cu_partial_die_info.
6242 (partial_die_parent_scope, guess_partial_die_structure_name)
6243 (partial_die_info::fixup): Handle new return type of find_partial_die.
6245 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6247 PR breakpoints/24541
6248 * stap-probe.c (stap_parse_register_operand): Make "regname" an
6249 "std::string", simplifying the algorithm.
6251 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6253 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6254 (stap_static_probe_ops::get_probes): Likewise.
6256 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6258 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6259 '-')" and "else if".
6260 (stap_parse_single_operand): Join checks for
6261 "gdbarch_stap_parse_special_token_p" and
6262 "gdbarch_stap_parse_special_token" in the same "if" statement.
6263 Invert check when verifying for operation on register
6266 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6268 * stap-probe.c (stap_get_opcode): Update comment.
6269 (stap_get_expected_argument_type): Likewise.
6270 (handle_stap_probe): Likewise.
6272 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6274 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6275 return type to 'bool'. Adjust comment. Use 'bool' when
6277 (i386_stap_parse_special_token_three_arg_disp): Likewise.
6278 * stap-probe.c (stap_parse_argument_1): Likewise.
6279 (stap_is_operator): Likewise.
6280 (stap_is_generic_prefix): Likewise.
6281 (stap_is_register_prefix): Likewise.
6282 (stap_is_register_indirection_prefix): Likewise.
6283 (stap_is_integer_prefix): Likewise.
6284 (stap_generic_check_suffix): Likewise.
6285 (stap_check_integer_suffix): Likewise.
6286 (stap_check_register_suffix): Likewise.
6287 (stap_check_register_indirection_suffix): Likewise.
6288 (stap_parse_register_operand): Likewise.
6289 (stap_parse_single_operand): Likewise.
6290 (stap_parse_argument_1): Likewise.
6291 (stap_probe::get_argument_count): Likewise.
6292 (stap_is_operator): Likewise.
6294 2019-05-16 Tom Tromey <tromey@adacore.com>
6296 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6299 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
6301 * linux-thread-db.c (try_thread_db_load_1): Change return type
6303 (try_thread_db_load): Likewise.
6304 (try_thread_db_load_from_pdir_1): Likewise.
6305 (try_thread_db_load_from_pdir): Likewise.
6306 (try_thread_db_load_from_sdir): Likewise.
6307 (try_thread_db_load_from_dir): Likewise.
6308 (thread_db_load_search): Likewise.
6309 (has_libpthread): Likewise.
6310 (thread_db_load): Likewise.
6312 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
6314 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6315 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6316 NULL, and complain/return if that's the case.
6318 2019-05-15 John Darrington <john@darrington.wattle.id.au>
6320 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6321 (advance, posn, abstract_read_memory): New functions.
6322 [struct mem_read_abstraction]: New struct.
6323 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6325 2019-05-14 Tom Tromey <tromey@adacore.com>
6327 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6328 value is not lval_memory.
6330 2019-05-14 Tom Tromey <tromey@adacore.com>
6332 * solib.c (info_sharedlibrary_command): Style the file name.
6334 2019-05-14 Alan Hayward <alan.hayward@arm.com>
6336 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6337 (aarch64_vnv_type): Likewise.
6338 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6339 * common/tdesc.c: Likewise.
6340 * common/tdesc.h (enum tdesc_type_kind): Likewise.
6341 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6342 * features/aarch64-fpu.xml: Add ieee half view.
6343 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6344 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6345 * gdbtypes.h (struct builtin_type): Likewise.
6346 (struct objfile_type): Likewise.
6348 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
6350 * language.c (language_sniff_from_mangled_name): Fix "langauge"
6352 * location.h (string_to_event_location): Likewise.
6354 2019-05-11 Joel Brobecker <brobecker@adacore.com>
6358 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
6360 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6361 New variable declaration.
6362 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6364 (print_one_breakpoint): Use ui_out::test_flags and new global
6365 variable to compute use_fixed_output.
6366 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6368 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6369 (mi_multi_location_breakpoint_output_fixed): Remove.
6370 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6372 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6373 fix_multi_location_breakpoint_output flag if version >= 3.
6374 * ui-out.h (enum ui_out_flag)
6375 <fix_multi_location_breakpoint_output>: New enumerator.
6377 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
6379 * contrib/cc-with-tweaks.sh: Validate dwz's work.
6381 2019-05-10 Tom Tromey <tromey@adacore.com>
6383 * ada-lang.c (catch_ada_completer): New function.
6384 (_initialize_ada_language): Use it.
6386 2019-05-10 Tom Tromey <tromey@adacore.com>
6388 * thread.c (print_thread_info): Make "requested_threads" const.
6389 * gdbthread.h (print_thread_info): Make "requested_threads"
6391 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6392 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6394 2019-05-08 Tom Tromey <tom@tromey.com>
6396 * gdbtypes.c (objfile_type_data): Change type.
6397 (objfile_type, _initialize_gdbtypes): Update.
6399 2019-05-08 Tom Tromey <tom@tromey.com>
6401 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6402 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6403 (_initialize_dwarf2_frame): Update.
6405 2019-05-08 Tom Tromey <tom@tromey.com>
6407 * objc-lang.c (objc_objfile_data): Change type.
6408 (find_methods): Update.
6409 (_initialize_objc_lang): Remove.
6411 2019-05-08 Tom Tromey <tom@tromey.com>
6413 * stabsread.c (rs6000_builtin_type_data): Change type.
6414 (rs6000_builtin_type, _initialize_stabsread): Update.
6416 2019-05-08 Tom Tromey <tom@tromey.com>
6418 * mips-tdep.c (mips_pdr_data): Remove.
6419 (_initialize_mips_tdep): Update.
6421 2019-05-08 Tom Tromey <tom@tromey.com>
6423 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6424 (hppa_init_objfile_priv_data, read_unwind_info)
6425 (find_unwind_entry, _initialize_hppa_tdep): Update.
6427 2019-05-08 Tom Tromey <tom@tromey.com>
6429 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6430 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
6432 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6434 2019-05-08 Tom Tromey <tom@tromey.com>
6436 * mdebugread.c (basic_type_data): Change type.
6437 (basic_type, _initialize_mdebugread): Update.
6439 2019-05-08 Tom Tromey <tom@tromey.com>
6441 * common/gdb_unique_ptr.h (struct noop_deleter): New.
6443 2019-05-08 Tom Tromey <tom@tromey.com>
6445 * nto-tdep.c (nto_inferior_data_reg): Change type.
6446 (nto_inferior_data): Update.
6447 (nto_inferior_data_cleanup, nto_new_inferior_data)
6448 (_initialize_nto_tdep): Remove.
6449 * nto-tdep.h (struct nto_inferior_data): Add initializers.
6451 2019-05-08 Tom Tromey <tom@tromey.com>
6453 * ada-lang.c (struct ada_inferior_data): Add initializers.
6454 (ada_inferior_data): Change type.
6455 (ada_inferior_data_cleanup): Remove.
6456 (get_ada_inferior_data, ada_inferior_exit)
6457 (struct ada_pspace_data): Add initializers, destructor.
6458 (ada_pspace_data_handle): Change type.
6459 (get_ada_pspace_data): Update.
6460 (ada_pspace_data_cleanup): Remove.
6462 2019-05-08 Tom Tromey <tom@tromey.com>
6464 * coffread.c (struct coff_symfile_info): Add initializers.
6465 (coff_objfile_data_key): Move lower. Change type.
6466 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6468 (coff_free_info): Remove.
6470 2019-05-08 Tom Tromey <tom@tromey.com>
6472 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6473 (fbsd_pspace_data_handle): Move lower. Change type.
6474 (get_fbsd_pspace_data): Update.
6475 (fbsd_pspace_data_cleanup): Remove.
6476 (_initialize_fbsd_tdep): Update.
6478 2019-05-08 Tom Tromey <tom@tromey.com>
6480 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6481 (get_ada_tasks_pspace_data): Update.
6482 (ada_tasks_pspace_data_cleanup): Remove.
6483 (_initialize_tasks): Update.
6484 (ada_tasks_inferior_data_handle): Change type.
6485 (get_ada_tasks_inferior_data): Update.
6486 (ada_tasks_inferior_data_cleanup): Remove.
6487 (struct ada_tasks_pspace_data): Add initializers.
6489 2019-05-08 Tom Tromey <tom@tromey.com>
6491 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6492 * symfile-debug.c (debug_sym_get_probes): Change type.
6493 * stap-probe.c (handle_stap_probe):
6494 (stap_static_probe_ops::get_probes): Change type.
6495 * probe.h (class static_probe_ops) <get_probes>: Change type.
6496 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6497 (parse_probes_in_pspace): Update.
6498 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6500 (any_static_probe_ops::get_probes): Change type.
6501 * elfread.c (elfread_data): New typedef.
6502 (probe_key): Change type.
6503 (elf_get_probes): Likewise. Update.
6504 (probe_key_free): Remove.
6505 (_initialize_elfread): Update.
6506 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6508 (dtrace_process_dof_probe, dtrace_process_dof)
6509 (dtrace_static_probe_ops::get_probe): Change type.
6511 2019-05-08 Tom Tromey <tom@tromey.com>
6513 * xcoffread.c (struct xcoff_symfile_info): Rename from
6514 coff_symfile_info. Add initializers.
6515 (xcoff_objfile_data_key): Move lower. Change type.
6516 (XCOFF_DATA): Rewrite.
6517 (xcoff_free_info): Remove.
6518 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6519 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6520 (xcoff_initial_scan): Update.
6522 2019-05-08 Tom Tromey <tom@tromey.com>
6524 * solib-svr4.c (struct svr4_info): Add initializers and
6526 <probes_table>: Now an htab_up.
6527 (solib_svr4_pspace_data): Change type.
6528 (free_probes_table): Simplify.
6529 (~svr4_info): Rename from svr4_pspace_data_cleanup.
6530 (get_svr4_info, probes_table_htab_remove_objfile_probes)
6531 (probes_table_remove_objfile_probes, register_solib_event_probe)
6532 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6533 (_initialize_svr4_solib): Update.
6535 2019-05-08 Tom Tromey <tom@tromey.com>
6537 * remote.c (remote_pspace_data): Change type.
6538 (remote_pspace_data_cleanup): Remove.
6539 (get_remote_exec_file, set_pspace_remote_exec_file)
6540 (_initialize_remote): Update.
6542 2019-05-08 Tom Tromey <tom@tromey.com>
6544 * breakpoint.c (breakpoint_objfile_key): Change type.
6545 (get_breakpoint_objfile_data): Update.
6546 (free_breakpoint_objfile_data): Remove.
6547 (_initialize_breakpoint): Update.
6549 2019-05-08 Tom Tromey <tom@tromey.com>
6551 * linux-tdep.c (struct linux_info): Add initializers.
6552 (linux_inferior_data): Move. Change type.
6553 (invalidate_linux_cache_inf): Update.
6554 (linux_inferior_data_cleanup): Remove.
6555 (get_linux_inferior_data, _initialize_linux_tdep): Update.
6557 2019-05-08 Tom Tromey <tom@tromey.com>
6559 * auxv.c (auxv_inferior_data): Move. Change type.
6560 (auxv_inferior_data_cleanup): Remove.
6561 (invalidate_auxv_cache_inf): Rewrite.
6562 (get_auxv_inferior_data, _initialize_auxv): Update.
6564 2019-05-08 Tom Tromey <tom@tromey.com>
6566 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6567 (symfile_debug_objfile_data_key): Change type.
6568 (symfile_debug_installed, debug_qf_has_symbols)
6569 (debug_qf_find_last_source_symtab)
6570 (debug_qf_forget_cached_source_info)
6571 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6572 (debug_qf_print_stats, debug_qf_dump)
6573 (debug_qf_expand_symtabs_for_function)
6574 (debug_qf_expand_all_symtabs)
6575 (debug_qf_expand_symtabs_with_fullname)
6576 (debug_qf_map_matching_symbols)
6577 (debug_qf_expand_symtabs_matching)
6578 (debug_qf_find_pc_sect_compunit_symtab)
6579 (debug_qf_map_symbol_filenames)
6580 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6581 (debug_sym_new_init, debug_sym_init, debug_sym_read)
6582 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6583 (debug_sym_read_linetable, debug_sym_relocate): Update.
6584 (symfile_debug_free_objfile): Remove.
6585 (install_symfile_debug_logging, _initialize_symfile_debug):
6588 2019-05-08 Tom Tromey <tom@tromey.com>
6590 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6591 allocate_on_obstack.
6592 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6593 (get_dwarf2_per_objfile): Update.
6594 (set_dwarf2_per_objfile): Remove.
6595 (dwarf2_has_info, dwarf2_get_section_info): Update.
6596 (dwarf2_free_objfile): Remove.
6597 (_initialize_dwarf2_read): Update.
6599 2019-05-08 Tom Tromey <tom@tromey.com>
6601 * auto-load.c (struct auto_load_pspace_info): Add destructor and
6603 <unsupported_script_warning_printed,
6604 script_not_found_warning_printed>: Now bool.
6605 (auto_load_pspace_data): Change type.
6606 (~auto_load_pspace_info): Rename from
6607 auto_load_pspace_data_cleanup.
6608 (get_auto_load_pspace_data, init_loaded_scripts_info)
6609 (clear_section_scripts, maybe_print_unsupported_script_warning)
6610 (maybe_print_script_not_found_warning, _initialize_auto_load):
6613 2019-05-08 Tom Tromey <tom@tromey.com>
6615 * objfiles.c (objfile_pspace_info): Add destructor and
6617 (objfiles_pspace_data): Change type.
6618 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6619 (get_objfile_pspace_data): Update.
6620 (objfiles_bfd_data): Change type.
6621 (get_objfile_bfd_data): Update.
6622 (objfile_bfd_data_free, _initialize_objfiles): Remove.
6624 2019-05-08 Tom Tromey <tom@tromey.com>
6626 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6628 (get_catch_syscall_inferior_data): Update.
6629 (catch_syscall_inferior_data_cleanup): Remove.
6630 (_initialize_break_catch_syscall): Update.
6632 2019-05-08 Tom Tromey <tom@tromey.com>
6634 * inflow.c (struct terminal_info): Add destructor and
6636 (inflow_inferior_data): Change type.
6637 (~terminal_info): Rename from inflow_inferior_data_cleanup.
6638 (get_inflow_inferior_data, inflow_inferior_exit)
6639 (swap_terminal_info, _initialize_inflow): Update.
6641 2019-05-08 Tom Tromey <tom@tromey.com>
6643 * target-dcache.c (target_dcache_cleanup): Remove.
6644 (target_dcache_aspace_key): Change type.
6645 (target_dcache_init_p, target_dcache_invalidate)
6646 (target_dcache_get, target_dcache_get_or_init)
6647 (_initialize_target_dcache): Update.
6648 * dcache.h (struct dcache_deleter): New.
6650 2019-05-08 Tom Tromey <tom@tromey.com>
6652 * symtab.c (struct symbol_cache): Add destructor and
6654 (symbol_cache_key): Move. Change type.
6655 (make_symbol_cache, free_symbol_cache): Remove.
6656 (get_symbol_cache): Update.
6657 (symbol_cache_cleanup): Remove.
6658 (ALL_PSPACES, symbol_cache_flush)
6659 (maintenance_print_symbol_cache)
6660 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6663 2019-05-08 Tom Tromey <tom@tromey.com>
6665 * symtab.c (struct main_info): Add destructor and initializers.
6666 (main_progspace_key): Move. Change type.
6667 (get_main_info): Update.
6668 (main_info_cleanup): Remove.
6669 (_initialize_symtab): Update.
6671 2019-05-08 Tom Tromey <tom@tromey.com>
6673 * registry.h (DECLARE_REGISTRY): Define the _key class.
6675 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
6677 * NEWS: Merge two 'New commands' sections.
6679 2019-05-08 Joel Brobecker <brobecker@adacore.com>
6681 * ada-valprint.c (ada_val_print_gnat_array): Remove language
6682 parameter and use Ada language definition instead.
6683 (ada_val_print_ptr): Remove unused language parameter.
6684 (ada_val_print_num): Remove language parameter and use Ada language
6686 (ada_val_print_enum, ada_val_print_flt): Remove unused language
6688 (ada_val_print_struct_union, ada_val_print_ref): Remove language
6689 parameter and use Ada language definition instead.
6690 (ada_val_print_1): Update all ada_val_print_xxx calls.
6691 Remove language parameter.
6692 (ada_val_print): Update ada_val_print_1 call.
6694 2019-05-08 Tom Tromey <tromey@adacore.com>
6696 * remote.c (remote_hw_watchpoint_limit)
6697 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6700 2019-05-08 Tom Tromey <tromey@adacore.com>
6702 * maint.c (_initialize_maint_cmds): Move initialization code to
6704 (watchdog, show_watchdog): Move to remote.c.
6705 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
6707 (_initialize_remote): Move initialization code from maint.c.
6708 * defs.h (watchdog): Don't declare.
6710 2019-05-08 Tom Tromey <tromey@adacore.com>
6712 * tui/tui-interp.c: Include main.h.
6713 * interps.c: Include main.h.
6714 * main.h (interpreter_p): Declare.
6715 * defs.h (interpreter_p): Don't declare.
6717 2019-05-08 Tom Tromey <tromey@adacore.com>
6719 * dwarf2loc.c: Include dwarf2read.h.
6720 * defs.h (read_unsigned_leb128): Don't declare.
6721 * dwarf2read.h (read_unsigned_leb128): Declare.
6723 2019-05-08 Tom Tromey <tromey@adacore.com>
6725 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6728 2019-05-08 Tom Tromey <tromey@adacore.com>
6730 * utils.c (fputs_maybe_filtered): Reset style after paging, even
6731 when no wrap column is set.
6733 2019-05-08 Tom Tromey <tromey@adacore.com>
6735 * c-lang.c (c_get_string): Handle non-C-style arrays.
6737 2019-05-08 Tom Tromey <tromey@adacore.com>
6739 * typeprint.c (print_offset_data::update): Print the bit offset,
6740 not the number of bits remaining.
6742 2019-05-08 Tom Tromey <tromey@adacore.com>
6744 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6745 padding at end of comment.
6747 2019-05-08 Tom Tromey <tromey@adacore.com>
6749 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6752 2019-05-06 Tom Tromey <tom@tromey.com>
6754 * common/scoped_mmap.c: Include common-defs.h.
6755 * common/scoped_mmap.h: Don't include config.h.
6757 2019-05-04 Tom Tromey <tom@tromey.com>
6759 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6760 (struct aarch64_call_info): Add initializers.
6761 <si>: Now a std::vector.
6762 (pass_on_stack, aarch64_push_dummy_call): Update.
6764 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
6765 Tom Tromey <tom@tromey.com>
6767 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6768 (ppc_threads): Now a std::vector. Now static.
6769 (hwdebug_find_thread_points_by_tid)
6770 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6773 2019-05-04 Tom Tromey <tom@tromey.com>
6775 * arc-tdep.c (arc_tdesc_init): Return bool.
6777 2019-05-04 Tom Tromey <tom@tromey.com>
6779 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6780 Use gdb_assert_not_reached.
6782 2019-05-04 Tom Tromey <tom@tromey.com>
6784 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6787 2019-05-04 Tom Tromey <tom@tromey.com>
6789 * arc-tdep.c (arc_tdesc_init): Use bool.
6791 2019-05-04 Tom Tromey <tom@tromey.com>
6793 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6795 2019-05-04 Tom Tromey <tom@tromey.com>
6797 * cli/cli-cmds.c (valid_command_p): Return bool.
6799 2019-05-04 Tom Tromey <tom@tromey.com>
6801 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6802 * command.h (valid_user_defined_cmd_name_p): Channge return type.
6804 2019-05-04 Raul Tambre <raul@tambre.ee>
6806 * python/lib/gdb/prompt.py (_ExtendedPrompt)
6807 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6808 operator for comparison.
6810 2019-05-04 Tom Tromey <tom@tromey.com>
6812 * psymtab.c (psymbol_name_matches, match_partial_symbol)
6813 (lookup_partial_symbol, print_partial_symbols)
6814 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6815 (psymbol_compare): Update.
6816 (add_psymbol_to_bcache): Clear the entire psymbol.
6817 (maintenance_check_psymtabs): Update.
6818 * psympriv.h (struct partial_symbol): Don't derive from
6819 general_symbol_info.
6820 <obj_section, unrelocated_address, address,
6821 set_unrelocated_address>: Update.
6822 <ginfo>: New member.
6823 * dwarf-index-write.c (write_psymbols, debug_names::insert)
6824 (debug_names::write_psymbols): Update.
6826 2019-05-04 Tom de Vries <tdevries@suse.de>
6828 * contrib/cc-with-tweaks.sh: Support -n arg.
6830 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6832 * corelow.c (core_target::detach): Ensure frame cache and
6833 register caches are cleared.
6834 inferior.c (exit_inferior_1): Likewise.
6836 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
6837 Tom Tromey <tom@tromey.com>
6839 * dictionary.c (collate_pending_symbols_by_language): Remove
6840 "struct" from foreach.
6841 * symtab.c (lookup_global_symbol_from_objfile)
6842 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6844 * ser-tcp.c (net_open): Remove "struct" from foreach.
6845 * objfiles.c (objfile_relocate, objfile_rebase)
6846 (objfile_has_symbols): Remove "struct" from foreach.
6847 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6849 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6851 * darwin-nat.c (thread_info_from_private_thread_info): Remove
6852 "struct" from foreach.
6853 * ada-lang.c (create_excep_cond_exprs)
6854 (ada_exception_catchpoint_cond_string): Remove "struct" from
6857 2019-05-03 Tom Tromey <tromey@adacore.com>
6859 * ada-exp.y (convert_char_literal): Check suffix of each
6862 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
6865 * ada-exp.y (yywrap): Don't define.
6866 * ada-lex.l (%option): Add noyywrap
6869 2019-05-03 Eli Zaretskii <eliz@gnu.org>
6871 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6872 _WIN32_WINNT to the XP level, unless already defined to a higher
6875 * unittests/parse-connection-spec-selftests.c:
6877 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
6880 * symfile.c (find_separate_debug_file): Remove colon from the
6881 drive spec of DOS/Windows file names of the target, so that the
6882 file name produced from DEBUGDIR and the target's directory will
6883 be valid on DOS/Windows systems.
6885 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
6887 * rust-lang.c (val_print_struct): Handle printing structures
6890 2019-05-02 Tom Tromey <tromey@adacore.com>
6892 * valarith.c (_initialize_valarith): Remove.
6894 2019-05-01 Tom Tromey <tromey@adacore.com>
6896 * ada-lang.c (ada_value_primitive_field): Treat more fields as
6899 2019-05-01 Tom Tromey <tromey@adacore.com>
6901 * ada-lang.c (ada_value_assign): Correctly compute starting offset
6902 for big-endian copies.
6904 2019-04-30 Ali Tamur <tamur@google.com>
6905 * gdb/dwarf2read.c (read_3_bytes): New declaration.
6906 (read_attribute_value): Added DW_FORM_strx1-4 cases.
6907 (read_3_bytes): New function.
6909 2019-04-30 Joel Brobecker <brobecker@adacore.com>
6911 * windows-nat.c (main_thread_id): Delete.
6912 (handle_output_debug_string): Replace main_thread_id by
6913 current_event.dwThreadId.
6914 (fake_create_process): Likewise.
6915 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6916 Do not set main_thread_id.
6917 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6918 current_event.dwThreadId.
6919 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6921 2019-04-30 Joel Brobecker <brobecker@adacore.com>
6923 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6924 Use current_event.dwThreadId instead of main_thread_id.
6926 2019-04-30 Tom Tromey <tromey@adacore.com>
6928 * ada-lang.c (ada_lookup_simple_minsyms): New function.
6929 (create_excep_cond_exprs): Iterate over program spaces.
6930 (ada_exception_catchpoint_cond_string): Examine all minimal
6931 symbols for exception types.
6933 2019-04-30 Tom Tromey <tromey@adacore.com>
6936 * dwarf2read.c (process_structure_scope): Handle case where type
6937 has template parameters but no symbol was created.
6939 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6940 Chris January <chris.january@arm.com>
6942 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6944 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6946 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6948 * f-typeprint.c (f_print_type): Update rules for printing
6950 (f_type_print_varspec_suffix): Likewise.
6952 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6953 Chris January <chris.january@arm.com>
6955 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6958 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6960 * f-lang.c (build_fortran_types): Change name of void type to
6962 * f-typeprint.c (f_type_print_base): Print the name of the void
6963 type, rather than a fixed string.
6964 * f-valprint.c (f_decorations): Use lower case void string.
6966 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6967 Chris January <chris.january@arm.com>
6969 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6972 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6973 Chris January <chris.january@arm.com>
6974 David Lecomber <david.lecomber@arm.com>
6976 * f-exp.y (BINOP_INTRINSIC): New token.
6977 (exp): New parser rule handling BINOP_INTRINSIC.
6978 (f77_keywords): Add new builtin procedures.
6979 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6980 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6981 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6982 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6983 (print_unop_subexp_f): New function.
6984 (print_binop_subexp_f): New function.
6985 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6986 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6987 (dump_subexp_body_f): Likewise.
6988 (operator_check_f): Likewise.
6989 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6990 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6992 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6994 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6996 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6997 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6998 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6999 (operator_length_f): New fuction.
7000 (print_subexp_f): New function.
7001 (op_name_f): New function.
7002 (dump_subexp_body_f): New function.
7003 (operator_check_f): New function.
7004 (exp_descriptor_f): Replace standard expression handling functions
7006 * gdb/fortran-operator.def: New file.
7007 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7008 * gdb/std-operator.def: Remove UNOP_KIND.
7010 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7012 * std-operator.def: Remove unbalanced, stray double quote
7015 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7016 Chris January <chris.january@arm.com>
7017 Daniel Everett <daniel.everett@arm.com>
7018 Nick Forrington <nick.forrington@arm.com>
7019 Richard Bunt <richard.bunt@arm.com>
7021 * cp-valprint.c (cp_print_value_fields): Allow an additional level
7022 of depth when printing anonymous structs or unions.
7023 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7024 Don't print either the top-level value, or the children if the
7025 max-depth is exceeded.
7026 (ppscm_print_children): When printing the key of a map, allow one
7027 extra level of depth.
7028 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7029 print either the top-level value, or the children if the max-depth
7031 (print_children): When printing the key of a map, allow one extra
7033 * python/py-value.c (valpy_format_string): Add max_depth keyword.
7034 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7035 (user_print_options): Initialise max_depth field.
7036 (val_print_scalar_or_string_type_p): New function.
7037 (val_print): Check to see if the max depth has been reached.
7038 (val_print_check_max_depth): Define new function.
7039 (show_print_max_depth): New function.
7040 (_initialize_valprint): Add 'print max-depth' option.
7041 * valprint.h (struct value_print_options) <max_depth>: New field.
7042 (val_print_check_max_depth): Declare new function.
7043 * NEWS: Document new feature.
7045 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7047 * ada-lang.c (ada_language_defn): Initialise new field.
7048 * c-lang.c (c_is_string_type_p): New function.
7049 (c_language_defn): Initialise new field.
7050 (cplus_language_defn): Initialise new field.
7051 (asm_language_defn): Initialise new field.
7052 (minimal_language_defn): Initialise new field.
7053 * c-lang.h (c_is_string_type_p): Declare new function.
7054 * d-lang.c (d_language_defn): Initialise new field.
7055 * f-lang.c (f_is_string_type_p): New function.
7056 (f_language_defn): Initialise new field.
7057 * go-lang.c (go_is_string_type_p): New function.
7058 (go_language_defn): Initialise new field.
7059 * language.c (default_is_string_type_p): New function.
7060 (unknown_language_defn): Initialise new field.
7061 (auto_language_defn): Initialise new field.
7062 * language.h (struct language_defn) <la_is_string_type_p>: New
7064 (default_is_string_type_p): Declare new function.
7065 * m2-lang.c (m2_language_defn): Initialise new field.
7066 * objc-lang.c (objc_language_defn): Initialise new field.
7067 * opencl-lang.c (opencl_language_defn): Initialise new field.
7068 * p-lang.c (pascal_is_string_type_p): New function.
7069 (pascal_language_defn): Initialise new field.
7070 * rust-lang.c (rust_is_string_type_p): New function.
7071 (rust_language_defn): Initialise new field.
7073 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7075 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7077 * ada-lang.c (ada_language_defn): Initialise new field.
7078 * c-lang.c (c_language_defn): Likewise.
7079 (cplus_language_defn): Likewise.
7080 (asm_language_defn): Likewise.
7081 (minimal_language_defn): Likewise.
7082 * d-lang.c (d_language_defn): Likewise.
7083 * f-lang.c (f_language_defn): Likewise.
7084 * go-lang.c (go_language_defn): Likewise.
7085 * language.c (unknown_language_defn): Likewise.
7086 (auto_language_defn): Likewise.
7087 * m2-lang.c (m2_language_defn): Likewise.
7088 * objc-lang.c (objc_language_defn): Likewise.
7089 * opencl-lang.c (opencl_language_defn): Likewise.
7090 * p-lang.c (pascal_language_defn): Likewise.
7091 * rust-lang.c (rust_language_defn): Likewise.
7093 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7095 * ada-lang.c (ada_is_character_type): Change return type to bool.
7096 (ada_is_string_type): Likewise.
7097 * ada-lang.h (ada_is_character_type): Update declaration
7098 (ada_is_string_type): Likewise.
7100 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7102 Support style in 'frame|thread apply'
7104 * gdbcmd.h (execute_command_to_string): New term_out parameter.
7105 * record.c (record_start, record_stop): Update callers of
7106 execute_command_to_string with false.
7107 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7108 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7110 (class string_file): New constructor with term_out parameter.
7111 Override methods term_out and can_emit_style_escape. New member
7113 (class stdio_file): Override can_emit_style_escape.
7114 (class tee_file): Override term_out and can_emit_style_escape.
7115 * utils.h (can_emit_style_escape): Remove.
7116 * utils.c (can_emit_style_escape): Likewise.
7117 Update all callers of can_emit_style_escape (SOMESTREAM) to
7118 SOMESTREAM->can_emit_style_escape.
7119 * source-cache.c (source_cache::get_source_lines): Likewise.
7120 * stack.c (frame_apply_command_count): Call execute_command_to_string
7121 passing the term_out characteristic of the current gdb_stdout.
7122 * thread.c (thr_try_catch_cmd): Likewise.
7123 * top.c (execute_command_to_string): pass term_out parameter
7124 to construct the string_file for the command output.
7125 * ui-file.c (term_cli_styling): New function (most code moved
7126 from utils.c can_emit_style_escape).
7127 (string_file::string_file, string_file::can_emit_style_escape,
7128 stdio_file::can_emit_style_escape, tee_file::term_out,
7129 tee_file::can_emit_style_escape): New functions.
7131 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7133 * NEWS: Mention the new set|show may-call-functions.
7134 * infcall.c (may_call_functions_p): New variable.
7135 (show_may_call_functions_p): New function.
7136 (call_function_by_hand_dummy): Throws an error if not
7138 (_initialize_infcall): Call add_setshow_boolean_cmd for
7141 2019-04-25 Keith Seitz <keiths@redhat.com>
7144 * cp-support.c (inspect_type): Don't attempt substitutions
7145 of symbol with the same name.
7147 2019-04-25 Tom Tromey <tromey@adacore.com>
7150 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7153 2019-04-25 Tom Tromey <tromey@adacore.com>
7155 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7157 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7158 (gdb_xml_parser::parse): Use std::move.
7159 * python/python-internal.h (gdbpy_convert_exception): Take a const
7161 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7163 * python/py-utils.c (gdbpy_convert_exception): Take a const
7165 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7167 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7169 * mi/mi-main.c (mi_print_exception): Take a const reference.
7170 * main.c (handle_command_errors): Take a const reference.
7171 * linespec.c (parse_linespec): Use std::move.
7172 * infcall.c (run_inferior_call): Use std::move.
7173 (call_function_by_hand_dummy): Use std::move.
7174 * exec.c (try_open_exec_file): Use std::move.
7175 * exceptions.h (exception_print, exception_fprintf)
7176 (exception_print_same): Update.
7177 * exceptions.c (print_exception, exception_print)
7178 (exception_fprintf, exception_print_same): Change parameters to
7180 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7181 * common/new-op.c: Use std::move.
7182 * common/common-exceptions.h (struct gdb_exception): Add move
7184 (struct gdb_exception_error, struct gdb_exception_quit, struct
7185 gdb_quit_bad_alloc): Change constructor to move constructor.
7186 (throw_exception): Change parameter to rvalue reference.
7187 * common/common-exceptions.c (throw_exception): Take rvalue
7189 * cli/cli-interp.c (safe_execute_command): Use std::move.
7190 * breakpoint.c (insert_bp_location, location_to_sals): Use
7193 2019-04-25 Tom Tromey <tromey@adacore.com>
7195 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7196 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7197 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7198 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7199 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7200 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7201 guile/scm-value.c: Use unpack.
7202 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7203 gdbscm_gdb_exception.
7204 (gdbscm_throw_gdb_exception): Likewise.
7205 (struct gdbscm_gdb_exception): New.
7206 (unpack): New function.
7207 (gdbscm_wrap): Use unpack.
7209 2019-04-25 Tom Tromey <tromey@adacore.com>
7211 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7212 (gdb_rl_callback_handler): Use std::move.
7213 * common/common-exceptions.h (struct gdb_exception): Add move
7214 assignment operator.
7215 (throw_exception_sjlj): Change "exception" to const reference.
7216 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7217 (throw_exception_sjlj): Change "exception" to const reference.
7219 2019-04-25 Tom Tromey <tromey@adacore.com>
7221 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7222 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7223 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7225 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7227 * mi/mi-interp.c (mi_interp::exec): Update.
7228 * linespec.c (parse_linespec): Update.
7229 * infcall.c (run_inferior_call): Update.
7230 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7231 * guile/scm-symbol.c (gdbscm_lookup_symbol)
7232 (gdbscm_lookup_global_symbol): Update.
7233 * guile/scm-param.c (gdbscm_parameter_value): Update.
7234 * guile/scm-frame.c (gdbscm_frame_read_register)
7235 (gdbscm_frame_read_var): Update.
7236 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7237 * exec.c (try_open_exec_file): Update.
7238 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7239 (gdb_rl_callback_handler): Update.
7240 * common/common-exceptions.h (exception_none): Don't declare.
7241 * common/common-exceptions.c (exception_none): Don't define.
7242 (struct catcher) <exception>: Update.
7243 * cli/cli-interp.c (safe_execute_command): Update.
7244 * breakpoint.c (insert_bp_location, location_to_sals): Update.
7246 2019-04-25 Ali Tamur <tamur@google.com>
7248 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7249 (read_attribute_value): Likewise.
7250 (dwarf2_read_addr_index): Update comment.
7251 (read_str_index): Add DW_FORM_strx.
7252 (dwarf2_string_attr): Likewise.
7253 (dwarf2_const_value_attr): Likewise.
7254 (dump_die_shallow): Likewise.
7255 (dwarf2_fetch_constant_bytes): Likewise.
7256 (skip_form_bytes): Likewise.
7257 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7259 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
7263 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7264 OFFSET. Verify if current mapping contains an ELF header.
7265 (linux_find_memory_regions_full): Adjust call to
7268 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
7269 Kang Li <kanglictf@gmail.com>
7273 * dwarf2-frame.c (read_initial_length): Be consistent about using
7274 unsigned representation of length.
7275 (decode_frame_entry_1): Likewise. Check for wraparound of
7276 end pointer as well as buffer overflow.
7278 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
7280 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7283 2019-04-24 Tom Tromey <tromey@adacore.com>
7285 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7287 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7289 * s12z-tdep.c (s12z_unwind_pc): Delete.
7290 (s12z_unwind_sp): Delete.
7291 (s12z_gdbarch_init): Don't register deleted functions with
7294 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7296 * rl78-tdep.c (rl78_unwind_sp): Delete.
7297 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7299 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7301 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7302 (xstormy16_unwind_pc): Delete.
7303 (xstormy16_dummy_id): Delete.
7304 (xstormy16_gdbarch_init): Don't register deleted functions with
7307 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7309 * vax-tdep.c (vax_unwind_pc): Delete.
7310 (vax_gdbarch_init): Don't register deleted function with gdbarch.
7312 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7314 * v850-tdep.c (v850_unwind_sp): Delete.
7315 (v850_unwind_pc): Delete.
7316 (v850_dummy_id): Delete.
7317 (v850_gdbarch_init): Don't register deleted functions with
7320 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7322 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7323 (tilegx_unwind_pc): Delete.
7324 (tilegx_unwind_dummy_id): Delete.
7325 (tilegx_gdbarch_init): Don't register deleted functions with
7328 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7330 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7331 (tic6x_dummy_id): Delete.
7332 (tic6x_gdbarch_init): Don't register deleted functions with
7335 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7337 * sparc-tdep.c (sparc_unwind_pc): Delete.
7338 (sparc32_gdbarch_init): Don't register deleted function with
7341 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7343 * sh-tdep.c (sh_unwind_sp): Delete.
7344 (sh_unwind_pc): Delete.
7345 (sh_dummy_id): Delete.
7346 (sh_gdbarch_init): Don't register deleted functions with
7349 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7351 * score-tdep.c (score_unwind_sp): Delete.
7352 (score_unwind_pc): Delete.
7353 (score_dummy_id): Delete.
7354 (score_gdbarch_init): Don't register deleted functions with
7357 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7359 * rx-tdep.c (rx_unwind_pc): Delete.
7360 (rx_unwind_sp): Delete.
7361 (rx_dummy_id): Delete.
7362 (rx_gdbarch_init): Don't register deleted functions with
7363 gdbarch. Update comment.
7365 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7367 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7368 (rs6000_dummy_id): Delete.
7369 (rs6000_gdbarch_init): Don't register deleted functions with
7372 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7374 * or1k-tdep.c (or1k_dummy_id): Delete.
7375 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7377 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7379 * nios2-tdep.c (nios2_dummy_id): Delete.
7380 (nios2_unwind_sp): Delete.
7381 (nios2_gdbarch_init): Don't register deleted functions with
7384 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7386 * nds32-tdep.c (nds32_dummy_id): Delete.
7387 (nds32_unwind_pc): Delete.
7388 (nds32_unwind_sp): Delete.
7389 (nds32_gdbarch_init): Don't register deleted functions with
7392 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7394 * msp430-tdep.c (msp430_unwind_pc): Delete.
7395 (msp430_unwind_sp): Delete.
7396 (msp430_dummy_id): Delete.
7397 (msp430_gdbarch_init): Don't register deleted functions with
7400 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7402 * moxie-tdep.c (moxie_unwind_sp): Delete.
7403 (moxie_unwind_pc): Delete.
7404 (moxie_dummy_id): Delete.
7405 (moxie_gdbarch_init): Don't register deleted functions with
7408 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7410 * mn10300-tdep.c (mn10300_dummy_id): Delete.
7411 (mn10300_unwind_pc): Delete.
7412 (mn10300_unwind_sp): Delete.
7413 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7415 (mn10300_frame_unwind_init): Don't register deleted functions with
7418 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7420 * mep-tdep.c (mep_unwind_pc): Delete.
7421 (mep_unwind_sp): Delete.
7422 (mep_dummy_id): Delete.
7423 (mep_gdbarch_init): Don't register deleted functions with
7426 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7428 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7429 (m68hc11_unwind_sp): Delete.
7430 (m68hc11_gdbarch_init): Don't register deleted functions with
7433 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7435 * m32r-tdep.c (m32r_unwind_sp): Delete.
7436 (m32r_unwind_pc): Delete.
7437 (m32r_dummy_id): Delete.
7438 (m32r_gdbarch_init): Don't register deleted functions with
7441 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7443 * m32c-tdep.c (m32c_unwind_pc): Delete.
7444 (m32c_unwind_sp): Delete.
7445 (m32c_dummy_id): Delete.
7446 (m32c_gdbarch_init): Don't register deleted functions with
7449 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7451 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7452 (lm32_unwind_pc): Delete.
7453 (lm32_dummy_id): Delete.
7454 (lm32_gdbarch_init): Don't register deleted functions with
7457 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7459 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7460 (iq2000_unwind_pc): Delete.
7461 (iq2000_dummy_id): Delete.
7462 (iq2000_gdbarch_init): Don't register deleted functions with
7465 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7467 * nds32-tdep.c (nds32_type_align): Delete.
7468 (nds32_push_dummy_call): Use type_align instead.
7470 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7472 * arm-tdep.c (arm_type_align): Only handle vector override case.
7473 (arm_push_dummy_call): Use type_align.
7474 (arm_gdbarch_init): Register arm_type_align gdbarch function.
7476 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7478 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7480 (pass_on_stack): Use type_align.
7481 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7484 2019-04-23 Tom Tromey <tromey@adacore.com>
7486 * dwarf2read.c (line_header::file_name_at): Remove unused
7489 2019-04-23 Tom de Vries <tdevries@suse.de>
7492 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7496 2019-03-27 Ali Tamur <tamur@google.com>
7498 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7499 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7500 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7501 (dwarf_expr_context::get_addr_index): Likewise
7502 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7503 (symbol_needs_eval_context::get_addr_index): Likewise
7504 (disassemble_dwarf_expression): Add DW_OP_addrx
7505 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7506 (read_cutu_die_from_dwo): Update comment
7507 (skip_one_die): Add DW_FORM_addrx
7508 (read_attribute_value): Likewise
7509 (var_decode_location): Add DW_OP_addrx
7510 (dwarf2_const_value_attr): Add DW_FORM_addrx
7511 (dump_die_shallow): Likewise
7512 (dwarf2_fetch_constant_bytes): Likewise
7513 (decode_locdesc): Add DW_OP_addrx
7514 (skip_form_bytes): Add DW_FORM_addrx
7516 2019-04-22 Ali Tamur <tamur@google.com>
7518 * MAINTAINERS (Write After Approval): Add self.
7520 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
7522 * solib-svr4.c (get_svr4_info): Add pspace parameter.
7523 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7524 (open_symbol_file_object): Likewise.
7525 (svr4_default_sos): Add info parameter.
7526 (svr4_read_so_list): Likewise.
7527 (svr4_current_sos_direct): Adjust functions calls to pass down
7529 (svr4_current_sos_1): Add info parameter.
7530 (svr4_current_sos): Call get_svr4_info, pass info down to
7532 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7534 (svr4_in_dynsym_resolve_code): Pass current_program_space to
7536 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7538 (probes_table_remove_objfile_probes): Likewise.
7539 (register_solib_event_probe): Add info parameter.
7540 (solist_update_incremental): Pass info parameter down to
7542 (disable_probes_interface): Add info parameter.
7543 (svr4_handle_solib_event): Pass current_program_space to
7544 get_svr4_info. Adjust disable_probes_interface cleanup.
7545 (svr4_create_probe_breakpoints): Add info parameter, pass it
7546 down to register_solib_event_probe.
7547 (svr4_create_solib_event_breakpoints): Add info parameter,
7548 pass it down to svr4_create_probe_breakpoints.
7549 (enable_break): Pass info down to
7550 svr4_create_solib_event_breakpoints.
7551 (svr4_solib_create_inferior_hook): Pass current_program_space to
7553 (svr4_clear_solib): Likewise.
7555 2019-04-22 Pedro Alves <palves@redhat.com>
7557 * solib-svr4.c (svr4_free_objfile_observer): New.
7558 (probe_and_action::objfile): New field.
7559 (probes_table_htab_remove_objfile_probes)
7560 (probes_table_remove_objfile_probes): New functions.
7561 (register_solib_event_probe): Add 'objfile' parameter. Store it
7562 in the new probe_and_action. Don't store the probe in 'lookup'.
7563 (svr4_create_probe_breakpoints): Pass objfile to
7564 register_solib_event_probe.
7565 (_initialize_svr4_solib): Register a free_objfile observer.
7567 2019-04-19 Tom Tromey <tom@tromey.com>
7569 * common/queue.h: Remove.
7571 2019-04-19 Tom Tromey <tom@tromey.com>
7573 * event-loop.c: Don't include "common/queue.h".
7575 2019-04-19 Tom Tromey <tom@tromey.com>
7577 * remote.c (remote_target): Use delete.
7578 * remote-notif.h: Include <list>, not "common/queue.h".
7579 (notif_client_p): Remove typedef.
7580 (remote_notif_state): Add constructor, destructor, initializer.
7581 <notif_queue>: Now a std::list.
7582 (remote_notif_state_xfree): Don't declare.
7583 * remote-notif.c (remote_notif_process, handle_notification)
7584 (remote_notif_state_allocate): Update.
7585 (~remote_notif_state): Rename from remote_notif_state_xfree.
7587 2019-04-19 Tom Tromey <tom@tromey.com>
7589 * symfile.c (reread_symbols): Update.
7590 * objfiles.c (objfile_register_static_link)
7591 (objfile_lookup_static_link): Update
7592 (~objfile) Don't delete static_links.
7593 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7595 2019-04-19 Tom Tromey <tom@tromey.com>
7597 * type-stack.h (struct type_stack) <insert>: Constify string.
7598 * type-stack.c (type_stack::insert): Constify string.
7599 * gdbtypes.h (lookup_template_type): Update.
7600 (address_space_name_to_int): Update.
7601 * gdbtypes.c (address_space_name_to_int): Make space_identifier
7603 (lookup_template_type): Make name const.
7604 * c-exp.y: Update rules.
7605 (lex_one_token, classify_name, classify_inner_name)
7606 (c_print_token): Update.
7607 * p-exp.y: Update rules.
7609 * f-exp.y: Update rules.
7611 * d-exp.y: Update rules.
7612 (lex_one_token, classify_name, classify_inner_name): Update.
7613 * parse.c (write_dollar_variable, copy_name): Return std::string.
7614 * parser-defs.h (copy_name): Change return type.
7615 * m2-exp.y: Update rules.
7617 * go-exp.y (lex_one_token): Update.
7619 (classify_unsafe_function, classify_packaged_name)
7620 (classify_name, yylex): Update.
7622 2019-04-19 Sergei Trofimovich <siarheit@google.com>
7624 * configure.ac: add --enable-source-highlight switch.
7625 * configure: Regenerate.
7626 * top.c (print_gdb_version): plumb --enable-source-highlight
7627 status to "show configuration".
7629 2019-04-19 Tom Tromey <tromey@adacore.com>
7631 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7633 (empty_record, ada_template_to_fixed_record_type_1)
7634 (template_to_static_fixed_type)
7635 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7636 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7637 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7640 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
7643 * source.c (print_source_lines_base): Advance "iter" when a
7644 control character is seen.
7646 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7648 * inferior.h (struct infcall_suspend_state_deleter):
7649 Catch exception in destructor to avoid crash.
7651 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7653 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7654 close to the add_com "shell".
7656 2019-04-18 Tom Tromey <tromey@adacore.com>
7658 * process-stratum-target.h (class process_stratum_target)
7659 <stratum>: Add "final".
7661 2019-04-17 Tom Tromey <tromey@adacore.com>
7663 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7664 against nullptr before use.
7666 2019-04-17 Alan Hayward <alan.hayward@arm.com>
7668 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7670 2019-04-17 Jim Wilson <jimw@sifive.com>
7671 Andrew Burgess <andrew.burgess@embecosm.com>
7673 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7674 code read might fail, assume 4-byte breakpoint in that case.
7676 2019-04-15 Leszek Swirski <leszeks@google.com>
7678 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7679 rather than a hand-rolled POD check when checking for forced MEMORY
7682 2019-04-15 Alan Hayward <alan.hayward@arm.com>
7684 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7685 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7687 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7688 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7689 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7692 2019-04-15 Alan Hayward <alan.hayward@arm.com>
7694 * aarch64-linux-nat.c
7695 (aarch64_linux_nat_target::thread_architecture): Add override.
7696 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7699 2019-04-15 Alan Hayward <alan.hayward@arm.com>
7701 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7703 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
7705 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7706 target types of size 96-bits, add some additional comments, and
7707 check that the builtin type we found was the correct size.
7709 2019-04-12 Eli Zaretskii <eliz@gnu.org>
7711 * utils.c (prompt_for_continue): Don't restore the styling at the
7712 end, as applied_style has the wrong value. This fixes styling in
7713 long lists of file names that are interrupted by the "Continue?"
7716 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
7718 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7719 * c-lang.c (c_language_defn): Likewise.
7720 (cplus_language_defn): Likewise.
7721 (asm_language_defn): Likewise.
7722 (minimal_language_defn): Likewise.
7723 * d-lang.c (d_language_defn): Likewise.
7724 * f-lang.c (f_language_defn): Likewise.
7725 * go-lang.c (go_language_defn): Likewise.
7726 * language.c (unknown_language_defn): Likewise.
7727 (auto_language_defn): Likewise.
7728 * language.h (struct language_defn): Remove la_magic field.
7729 (LANG_MAGIC): Delete.
7730 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7731 * objc-lang.c (objc_language_defn): Likewise.
7732 * opencl-lang.c (opencl_language_defn): Likewise.
7733 * p-lang.c (pascal_language_defn): Likewise.
7734 * rust-lang.c (rust_language_defn): Likewise.
7736 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7738 * riscv-tdep.c (riscv_type_align): New function.
7739 (riscv_type_alignment): Delete.
7740 (riscv_arg_location): Use 'type_align'.
7741 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7743 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7745 * gdbtypes.c (type_align): A struct with no non-static fields also
7748 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7750 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7752 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7754 (riscv_struct_info::analyse): New implementation using new
7755 analyse_inner member function.
7756 (riscv_struct_info::field_offset): New member function.
7757 (riscv_struct_info::m_offsets): New member variable.
7758 (riscv_struct_info::analyse_inner): New private member function,
7759 takes the old implementation of riscv_struct_info::analyse but
7760 extended to track field offsets.
7761 (riscv_call_arg_struct): Update the struct folding special cases
7762 to handle cases where empty C++ structs, which are non-zero
7764 (riscv_arg_location): Initialise the length of each location, a
7765 non-zero length now indicates the location is in use.
7766 (riscv_push_dummy_call): Allow for the first location having a
7767 non-zero offset when setting up arguments.
7768 (riscv_return_value): Likewise, but for return values.
7770 2019-04-11 Tom Tromey <tromey@adacore.com>
7772 * utils.c (internal_vproblem): Make "msg" const.
7774 2019-04-11 Alan Hayward <alan.hayward@arm.com>
7776 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7777 * trad-frame.c (trad_frame_reset_saved_regs): New function.
7778 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7779 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7781 2019-04-10 Kevin Buettner <kevinb@redhat.com>
7783 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7785 (fill_gregset): Call amd64_linux_collect_native_gregset instead
7786 of amd64_collect_native_gregset.
7787 (amd64_linux_nat_target::store_registers): Likewise.
7789 2019-04-10 Tom Tromey <tom@tromey.com>
7791 * symtab.c (lookup_global_symbol_from_objfile)
7792 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7793 * objfiles.h (class separate_debug_iterator): New.
7794 (class separate_debug_range): New.
7795 (struct objfile) <separate_debug_objfiles>: New method.
7796 (objfile_separate_debug_iterate): Don't declare.
7797 * objfiles.c (separate_debug_iterator::operator++): Rename from
7798 objfile_separate_debug_iterate.
7799 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7801 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7804 2019-04-10 Tom Tromey <tom@tromey.com>
7806 * symfile.c (reread_symbols): Remove old comment.
7807 * objfiles.c (free_all_objfiles): Fix a typo.
7809 2019-04-10 Tom Tromey <tom@tromey.com>
7811 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7812 * minsyms.c (lookup_minimal_symbol): Use foreach.
7813 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7814 (lookup_minimal_symbol_solib_trampoline): Likewise.
7815 * symfile.c (reread_symbols): Use foreach.
7817 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
7818 Tom Tromey <tromey@adacore.com>
7821 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7822 (rust_lex_int_test): Change "value" to be LONGEST.
7823 (rust_lex_tests): Add test for long integer literal.
7825 2019-04-09 Tom Tromey <tromey@adacore.com>
7827 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7829 (extended_remote_target::attach): Update.
7830 (remote_target::remote_notice_new_inferior): Update.
7831 (remote_target::add_current_inferior_and_thread): Update.
7832 * inferior.c (exit_inferior_1): Use "false".
7833 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7835 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
7837 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7838 the "start" command.
7840 2019-04-08 Kevin Buettner <kevinb@redhat.com>
7842 * python/py-inferior.c (infpy_thread_from_thread_handle):
7843 Adjust comments to reflect renaming of thread_from_thread_handle
7844 to thread_from_handle. Adjust keywords. Fix type error message.
7845 (inferior_object_methods): Add thread_from_handle. Retain
7846 thread_from_thread_handle, but mark it as deprecated.
7848 2019-04-08 Kevin Buettner <kevinb@redhat.com>
7850 * gdbthread.h (find_thread_by_handle): Revise declaration.
7851 * thread.c (find_thread_by_handle): Likewise. Adjust
7853 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7854 support for buffer objects as handles.
7856 2019-04-08 Kevin Buettner <kevinb@redhat.com>
7858 * python/py-infthread.c (thpy_thread_handle): New function.
7859 (thread_object_methods): Register thpy_thread_handle.
7861 2019-04-08 Kevin Buettner <kevinb@redhat.com>
7863 * gdbthread.h (thread_to_thread_handle): Declare.
7864 * thread.c (gdbtypes.h): Include.
7865 (thread_to_thread_handle): New function.
7867 * target.h (struct target_ops): Add thread_info_to_thread_handle.
7868 (target_thread_info_to_thread_handle): Declare.
7869 * target.c (target_thread_info_to_thread_handle): New function.
7870 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7871 * target-delegates.c: Regenerate.
7873 * linux-thread-db.c (class thread_db_target): Add method
7874 thread_info_to_thread_handle.
7875 (thread_db_target::thread_info_to_thread_handle): Define.
7876 * remote.c (class remote_target): Add new method
7877 thread_info_to_thread_handle.
7878 (remote_target::thread_info_to_thread_handle): Define.
7880 2019-04-08 Pedro Alves <palves@redhat.com>
7882 * common/common-exceptions.c (throw_exception): Don't create
7883 named object to throw; throw directly.
7884 (throw_it): Likewise. Don't initialize gdb_exception::message
7885 here, with new; pass FMT and AP to the ctor instead.
7886 * common/common-exceptions.h: Include <string>.
7887 (gdb_exception::gdb_exception(enum return_reason, enum errors,
7888 const char *, va_list)): New ctor. Use std::make_shared.
7889 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7891 (gdb_exception_error::gdb_exception_error(enum errors, const char
7893 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7895 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7897 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7898 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7901 2019-04-08 Tom Tromey <tom@tromey.com>
7903 * valops.c (value_rtti_indirect_type): Replace throw_exception
7905 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7907 * thread.c (thr_try_catch_cmd): Replace throw_exception with
7909 * target.c (target_translate_tls_address): Replace throw_exception
7911 * stack.c (frame_apply_command_count): Replace throw_exception
7913 * solib-spu.c (append_ocl_sos): Replace throw_exception with
7915 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7917 * rs6000-tdep.c (rs6000_frame_cache)
7918 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7919 * remote.c: Replace throw_exception with throw.
7920 * record-full.c (record_full_message, record_full_wait_1)
7921 (record_full_restore): Replace throw_exception with throw.
7923 (get_thread_current_frame_id, record_btrace_start_replaying)
7924 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7925 (cmd_record_btrace_start): Replace throw_exception with throw.
7926 * parse.c (parse_exp_in_context_1): Replace throw_exception with
7928 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7929 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7931 (find_linespec_symbols): Replace throw_exception with throw.
7932 * infrun.c (displaced_step_prepare, resume): Replace
7933 throw_exception with throw.
7934 * infcmd.c (post_create_inferior): Replace throw_exception with
7936 * inf-loop.c (inferior_event_handler): Replace throw_exception
7938 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7939 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7940 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7941 (get_prev_frame_always, get_frame_pc_if_available)
7942 (get_frame_address_in_block_if_available, get_frame_language):
7943 Replace throw_exception with throw.
7944 * frame-unwind.c (frame_unwind_try_unwinder): Replace
7945 throw_exception with throw.
7946 * eval.c (fetch_subexp_value, evaluate_var_value)
7947 (evaluate_funcall, evaluate_subexp_standard): Replace
7948 throw_exception with throw.
7949 * dwarf2loc.c (call_site_find_chain)
7950 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7951 Replace throw_exception with throw.
7952 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7954 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7956 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7957 * completer.c (complete_line_internal): Replace throw_exception
7959 * compile/compile-object-run.c (compile_object_run): Replace
7960 throw_exception with throw.
7961 * cli/cli-script.c (process_next_line): Replace throw_exception
7963 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7964 (btrace_enable, btrace_maint_update_pt_packets): Replace
7965 throw_exception with throw.
7966 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7967 throw_exception with throw.
7968 * break-catch-throw.c (re_set_exception_catchpoint): Replace
7969 throw_exception with throw.
7970 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7971 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7972 * aarch64-tdep.c (aarch64_make_prologue_cache)
7973 (aarch64_make_stub_cache): Replace throw_exception with throw.
7975 2019-04-08 Tom Tromey <tom@tromey.com>
7977 * common/common-exceptions.c (throw_exception): Rename from
7978 throw_exception_cxx. Remove old copy. Make argument const.
7979 (throw_it): Create and throw exception objects directly.
7980 * common/common-exceptions.h (throw_exception): Make argument
7982 (struct gdb_exception_error): Add constructor.
7983 (struct gdb_exception_quit): Add constructor.
7985 2019-04-08 Tom Tromey <tom@tromey.com>
7987 * common/common-exceptions.h (exception_rethrow): Don't declare.
7988 (TRY_SJLJ): Update comment.
7989 (TRY, CATCH, END_CATCH): Remove.
7990 * common/common-exceptions.c (exception_rethrow): Remove.
7992 2019-04-08 Tom Tromey <tom@tromey.com>
7994 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7996 (gdb_exception_error): Rename from
7997 gdb_exception_RETURN_MASK_ERROR.
7998 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7999 (gdb_quit_bad_alloc): Update.
8000 * aarch64-tdep.c: Update.
8001 * ada-lang.c: Update.
8002 * ada-typeprint.c: Update.
8003 * ada-valprint.c: Update.
8004 * amd64-tdep.c: Update.
8005 * arch-utils.c: Update.
8006 * break-catch-throw.c: Update.
8007 * breakpoint.c: Update.
8009 * c-varobj.c: Update.
8010 * cli/cli-cmds.c: Update.
8011 * cli/cli-interp.c: Update.
8012 * cli/cli-script.c: Update.
8013 * common/common-exceptions.c: Update.
8014 * common/new-op.c: Update.
8015 * common/selftest.c: Update.
8016 * compile/compile-c-symbols.c: Update.
8017 * compile/compile-cplus-symbols.c: Update.
8018 * compile/compile-object-load.c: Update.
8019 * compile/compile-object-run.c: Update.
8020 * completer.c: Update.
8021 * corelow.c: Update.
8023 * cp-support.c: Update.
8024 * cp-valprint.c: Update.
8025 * darwin-nat.c: Update.
8026 * disasm-selftests.c: Update.
8027 * dtrace-probe.c: Update.
8028 * dwarf-index-cache.c: Update.
8029 * dwarf-index-write.c: Update.
8030 * dwarf2-frame-tailcall.c: Update.
8031 * dwarf2-frame.c: Update.
8032 * dwarf2loc.c: Update.
8033 * dwarf2read.c: Update.
8035 * event-loop.c: Update.
8036 * event-top.c: Update.
8038 * f-valprint.c: Update.
8039 * fbsd-tdep.c: Update.
8040 * frame-unwind.c: Update.
8042 * gdbtypes.c: Update.
8043 * gnu-v3-abi.c: Update.
8044 * guile/guile-internal.h: Update.
8045 * guile/scm-block.c: Update.
8046 * guile/scm-breakpoint.c: Update.
8047 * guile/scm-cmd.c: Update.
8048 * guile/scm-disasm.c: Update.
8049 * guile/scm-frame.c: Update.
8050 * guile/scm-lazy-string.c: Update.
8051 * guile/scm-math.c: Update.
8052 * guile/scm-param.c: Update.
8053 * guile/scm-ports.c: Update.
8054 * guile/scm-pretty-print.c: Update.
8055 * guile/scm-symbol.c: Update.
8056 * guile/scm-symtab.c: Update.
8057 * guile/scm-type.c: Update.
8058 * guile/scm-value.c: Update.
8059 * i386-linux-tdep.c: Update.
8060 * i386-tdep.c: Update.
8061 * inf-loop.c: Update.
8062 * infcall.c: Update.
8066 * language.c: Update.
8067 * linespec.c: Update.
8068 * linux-fork.c: Update.
8069 * linux-nat.c: Update.
8070 * linux-tdep.c: Update.
8071 * linux-thread-db.c: Update.
8073 * mi/mi-cmd-break.c: Update.
8074 * mi/mi-cmd-stack.c: Update.
8075 * mi/mi-interp.c: Update.
8076 * mi/mi-main.c: Update.
8077 * objc-lang.c: Update.
8078 * p-valprint.c: Update.
8080 * ppc-linux-tdep.c: Update.
8081 * printcmd.c: Update.
8082 * python/py-arch.c: Update.
8083 * python/py-breakpoint.c: Update.
8084 * python/py-cmd.c: Update.
8085 * python/py-finishbreakpoint.c: Update.
8086 * python/py-frame.c: Update.
8087 * python/py-framefilter.c: Update.
8088 * python/py-gdb-readline.c: Update.
8089 * python/py-inferior.c: Update.
8090 * python/py-infthread.c: Update.
8091 * python/py-lazy-string.c: Update.
8092 * python/py-linetable.c: Update.
8093 * python/py-objfile.c: Update.
8094 * python/py-param.c: Update.
8095 * python/py-prettyprint.c: Update.
8096 * python/py-progspace.c: Update.
8097 * python/py-record-btrace.c: Update.
8098 * python/py-record.c: Update.
8099 * python/py-symbol.c: Update.
8100 * python/py-type.c: Update.
8101 * python/py-unwind.c: Update.
8102 * python/py-utils.c: Update.
8103 * python/py-value.c: Update.
8104 * python/python.c: Update.
8105 * record-btrace.c: Update.
8106 * record-full.c: Update.
8107 * remote-fileio.c: Update.
8109 * riscv-tdep.c: Update.
8110 * rs6000-aix-tdep.c: Update.
8111 * rs6000-tdep.c: Update.
8112 * rust-exp.y: Update.
8113 * rust-lang.c: Update.
8114 * s390-tdep.c: Update.
8115 * selftest-arch.c: Update.
8116 * solib-dsbt.c: Update.
8117 * solib-frv.c: Update.
8118 * solib-spu.c: Update.
8119 * solib-svr4.c: Update.
8121 * sparc64-linux-tdep.c: Update.
8123 * symfile-mem.c: Update.
8124 * symmisc.c: Update.
8128 * tracefile-tfile.c: Update.
8129 * tui/tui.c: Update.
8130 * typeprint.c: Update.
8131 * unittests/cli-utils-selftests.c: Update.
8132 * unittests/parse-connection-spec-selftests.c: Update.
8134 * valprint.c: Update.
8137 * windows-nat.c: Update.
8138 * x86-linux-nat.c: Update.
8139 * xml-support.c: Update.
8141 2019-04-08 Tom Tromey <tom@tromey.com>
8143 * xml-support.c: Use C++ exception handling.
8144 * x86-linux-nat.c: Use C++ exception handling.
8145 * windows-nat.c: Use C++ exception handling.
8146 * varobj.c: Use C++ exception handling.
8147 * value.c: Use C++ exception handling.
8148 * valprint.c: Use C++ exception handling.
8149 * valops.c: Use C++ exception handling.
8150 * unittests/parse-connection-spec-selftests.c: Use C++ exception
8152 * unittests/cli-utils-selftests.c: Use C++ exception handling.
8153 * typeprint.c: Use C++ exception handling.
8154 * tui/tui.c: Use C++ exception handling.
8155 * tracefile-tfile.c: Use C++ exception handling.
8156 * top.c: Use C++ exception handling.
8157 * thread.c: Use C++ exception handling.
8158 * target.c: Use C++ exception handling.
8159 * symmisc.c: Use C++ exception handling.
8160 * symfile-mem.c: Use C++ exception handling.
8161 * stack.c: Use C++ exception handling.
8162 * sparc64-linux-tdep.c: Use C++ exception handling.
8163 * solib.c: Use C++ exception handling.
8164 * solib-svr4.c: Use C++ exception handling.
8165 * solib-spu.c: Use C++ exception handling.
8166 * solib-frv.c: Use C++ exception handling.
8167 * solib-dsbt.c: Use C++ exception handling.
8168 * selftest-arch.c: Use C++ exception handling.
8169 * s390-tdep.c: Use C++ exception handling.
8170 * rust-lang.c: Use C++ exception handling.
8171 * rust-exp.y: Use C++ exception handling.
8172 * rs6000-tdep.c: Use C++ exception handling.
8173 * rs6000-aix-tdep.c: Use C++ exception handling.
8174 * riscv-tdep.c: Use C++ exception handling.
8175 * remote.c: Use C++ exception handling.
8176 * remote-fileio.c: Use C++ exception handling.
8177 * record-full.c: Use C++ exception handling.
8178 * record-btrace.c: Use C++ exception handling.
8179 * python/python.c: Use C++ exception handling.
8180 * python/py-value.c: Use C++ exception handling.
8181 * python/py-utils.c: Use C++ exception handling.
8182 * python/py-unwind.c: Use C++ exception handling.
8183 * python/py-type.c: Use C++ exception handling.
8184 * python/py-symbol.c: Use C++ exception handling.
8185 * python/py-record.c: Use C++ exception handling.
8186 * python/py-record-btrace.c: Use C++ exception handling.
8187 * python/py-progspace.c: Use C++ exception handling.
8188 * python/py-prettyprint.c: Use C++ exception handling.
8189 * python/py-param.c: Use C++ exception handling.
8190 * python/py-objfile.c: Use C++ exception handling.
8191 * python/py-linetable.c: Use C++ exception handling.
8192 * python/py-lazy-string.c: Use C++ exception handling.
8193 * python/py-infthread.c: Use C++ exception handling.
8194 * python/py-inferior.c: Use C++ exception handling.
8195 * python/py-gdb-readline.c: Use C++ exception handling.
8196 * python/py-framefilter.c: Use C++ exception handling.
8197 * python/py-frame.c: Use C++ exception handling.
8198 * python/py-finishbreakpoint.c: Use C++ exception handling.
8199 * python/py-cmd.c: Use C++ exception handling.
8200 * python/py-breakpoint.c: Use C++ exception handling.
8201 * python/py-arch.c: Use C++ exception handling.
8202 * printcmd.c: Use C++ exception handling.
8203 * ppc-linux-tdep.c: Use C++ exception handling.
8204 * parse.c: Use C++ exception handling.
8205 * p-valprint.c: Use C++ exception handling.
8206 * objc-lang.c: Use C++ exception handling.
8207 * mi/mi-main.c: Use C++ exception handling.
8208 * mi/mi-interp.c: Use C++ exception handling.
8209 * mi/mi-cmd-stack.c: Use C++ exception handling.
8210 * mi/mi-cmd-break.c: Use C++ exception handling.
8211 * main.c: Use C++ exception handling.
8212 * linux-thread-db.c: Use C++ exception handling.
8213 * linux-tdep.c: Use C++ exception handling.
8214 * linux-nat.c: Use C++ exception handling.
8215 * linux-fork.c: Use C++ exception handling.
8216 * linespec.c: Use C++ exception handling.
8217 * language.c: Use C++ exception handling.
8218 * jit.c: Use C++ exception handling.
8219 * infrun.c: Use C++ exception handling.
8220 * infcmd.c: Use C++ exception handling.
8221 * infcall.c: Use C++ exception handling.
8222 * inf-loop.c: Use C++ exception handling.
8223 * i386-tdep.c: Use C++ exception handling.
8224 * i386-linux-tdep.c: Use C++ exception handling.
8225 * guile/scm-value.c: Use C++ exception handling.
8226 * guile/scm-type.c: Use C++ exception handling.
8227 * guile/scm-symtab.c: Use C++ exception handling.
8228 * guile/scm-symbol.c: Use C++ exception handling.
8229 * guile/scm-pretty-print.c: Use C++ exception handling.
8230 * guile/scm-ports.c: Use C++ exception handling.
8231 * guile/scm-param.c: Use C++ exception handling.
8232 * guile/scm-math.c: Use C++ exception handling.
8233 * guile/scm-lazy-string.c: Use C++ exception handling.
8234 * guile/scm-frame.c: Use C++ exception handling.
8235 * guile/scm-disasm.c: Use C++ exception handling.
8236 * guile/scm-cmd.c: Use C++ exception handling.
8237 * guile/scm-breakpoint.c: Use C++ exception handling.
8238 * guile/scm-block.c: Use C++ exception handling.
8239 * guile/guile-internal.h: Use C++ exception handling.
8240 * gnu-v3-abi.c: Use C++ exception handling.
8241 * gdbtypes.c: Use C++ exception handling.
8242 * frame.c: Use C++ exception handling.
8243 * frame-unwind.c: Use C++ exception handling.
8244 * fbsd-tdep.c: Use C++ exception handling.
8245 * f-valprint.c: Use C++ exception handling.
8246 * exec.c: Use C++ exception handling.
8247 * event-top.c: Use C++ exception handling.
8248 * event-loop.c: Use C++ exception handling.
8249 * eval.c: Use C++ exception handling.
8250 * dwarf2read.c: Use C++ exception handling.
8251 * dwarf2loc.c: Use C++ exception handling.
8252 * dwarf2-frame.c: Use C++ exception handling.
8253 * dwarf2-frame-tailcall.c: Use C++ exception handling.
8254 * dwarf-index-write.c: Use C++ exception handling.
8255 * dwarf-index-cache.c: Use C++ exception handling.
8256 * dtrace-probe.c: Use C++ exception handling.
8257 * disasm-selftests.c: Use C++ exception handling.
8258 * darwin-nat.c: Use C++ exception handling.
8259 * cp-valprint.c: Use C++ exception handling.
8260 * cp-support.c: Use C++ exception handling.
8261 * cp-abi.c: Use C++ exception handling.
8262 * corelow.c: Use C++ exception handling.
8263 * completer.c: Use C++ exception handling.
8264 * compile/compile-object-run.c: Use C++ exception handling.
8265 * compile/compile-object-load.c: Use C++ exception handling.
8266 * compile/compile-cplus-symbols.c: Use C++ exception handling.
8267 * compile/compile-c-symbols.c: Use C++ exception handling.
8268 * common/selftest.c: Use C++ exception handling.
8269 * common/new-op.c: Use C++ exception handling.
8270 * cli/cli-script.c: Use C++ exception handling.
8271 * cli/cli-interp.c: Use C++ exception handling.
8272 * cli/cli-cmds.c: Use C++ exception handling.
8273 * c-varobj.c: Use C++ exception handling.
8274 * btrace.c: Use C++ exception handling.
8275 * breakpoint.c: Use C++ exception handling.
8276 * break-catch-throw.c: Use C++ exception handling.
8277 * arch-utils.c: Use C++ exception handling.
8278 * amd64-tdep.c: Use C++ exception handling.
8279 * ada-valprint.c: Use C++ exception handling.
8280 * ada-typeprint.c: Use C++ exception handling.
8281 * ada-lang.c: Use C++ exception handling.
8282 * aarch64-tdep.c: Use C++ exception handling.
8284 2019-04-08 Tom Tromey <tom@tromey.com>
8286 * xml-support.c (gdb_xml_parser::parse): Update.
8287 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8288 * value.c (show_convenience): Update.
8289 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8290 (test_parse_flags_qcs): Update.
8291 * thread.c (thr_try_catch_cmd): Update.
8292 * target.c (target_translate_tls_address): Update.
8293 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8294 (info_frame_command_core, frame_apply_command_count): Update.
8295 * rust-exp.y (rust_lex_exception_test): Update.
8296 * riscv-tdep.c (riscv_print_one_register_info): Update.
8297 * remote.c (remote_target::enable_btrace): Update.
8298 * record-btrace.c (record_btrace_enable_warn): Update.
8299 * python/py-utils.c (gdbpy_convert_exception): Update.
8300 * printcmd.c (do_one_display, print_variable_and_value): Update.
8301 * mi/mi-main.c (mi_print_exception): Update.
8302 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8303 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8304 * linux-nat.c (linux_nat_target::attach): Update.
8305 * linux-fork.c (class scoped_switch_fork_info): Update.
8306 * infrun.c (displaced_step_prepare): Update.
8307 * infcall.c (call_function_by_hand_dummy): Update.
8308 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8309 * gnu-v3-abi.c (print_one_vtable): Update.
8310 * frame.c (get_prev_frame_always): Update.
8311 * f-valprint.c (info_common_command_for_block): Update.
8312 * exec.c (try_open_exec_file): Update.
8313 * exceptions.c (print_exception, exception_print)
8314 (exception_fprintf, exception_print_same): Update.
8315 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8316 * dwarf-index-cache.c (index_cache::store)
8317 (index_cache::lookup_gdb_index): Update.
8318 * darwin-nat.c (maybe_cache_shell): Update.
8319 * cp-valprint.c (cp_print_value_fields): Update.
8320 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8321 (gcc_cplus_symbol_address): Update.
8322 * compile/compile-c-symbols.c (gcc_convert_symbol)
8323 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8324 * common/selftest.c: Update.
8325 * common/common-exceptions.h (struct gdb_exception) <message>: Now
8327 (exception_try_scope_entry, exception_try_scope_exit): Don't
8329 (struct exception_try_scope): Remove.
8330 (TRY): Don't use exception_try_scope.
8331 (struct gdb_exception): Add constructor, operator=.
8333 (struct gdb_exception_RETURN_MASK_ALL)
8334 (struct gdb_exception_RETURN_MASK_ERROR)
8335 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8336 (struct gdb_quit_bad_alloc): Update.
8337 * common/common-exceptions.c (exception_none): Change
8339 (struct catcher) <state, exception>: Initialize inline.
8340 <prev>: Remove member.
8341 (current_catcher): Remove.
8342 (catchers): New global.
8343 (exceptions_state_mc_init): Simplify.
8344 (catcher_pop): Remove.
8345 (exceptions_state_mc, exceptions_state_mc_catch): Update.
8346 (try_scope_depth, exception_try_scope_entry)
8347 (exception_try_scope_exit): Remove.
8348 (throw_exception_sjlj): Update.
8349 (exception_messages, exception_messages_size): Remove.
8350 (throw_it): Simplify.
8351 (gdb_exception_sliced_copy): Remove.
8352 (throw_exception_cxx): Update.
8353 * cli/cli-script.c (script_from_file): Update.
8354 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8356 * ada-valprint.c (ada_val_print): Update.
8357 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8358 (create_excep_cond_exprs): Update.
8360 2019-04-08 Tom Tromey <tom@tromey.com>
8362 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8363 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8364 (TRY, CATCH, END_CATCH): Remove some definitions.
8365 * common/common-exceptions.c: Don't use GDB_XCPT.
8366 (catcher_list_size): Remove.
8367 (throw_exception, throw_it): Simplify.
8369 2019-04-05 Tom Tromey <tom@tromey.com>
8371 Revert the header-sorting patch.
8372 * ft32-tdep.c: Revert.
8373 * frv-tdep.c: Revert.
8374 * frv-linux-tdep.c: Revert.
8376 * frame-unwind.c: Revert.
8377 * frame-base.c: Revert.
8378 * fork-child.c: Revert.
8379 * findvar.c: Revert.
8380 * findcmd.c: Revert.
8381 * filesystem.c: Revert.
8382 * filename-seen-cache.h: Revert.
8383 * filename-seen-cache.c: Revert.
8384 * fbsd-tdep.c: Revert.
8385 * fbsd-nat.h: Revert.
8386 * fbsd-nat.c: Revert.
8387 * f-valprint.c: Revert.
8388 * f-typeprint.c: Revert.
8390 * extension.h: Revert.
8391 * extension.c: Revert.
8392 * extension-priv.h: Revert.
8393 * expprint.c: Revert.
8396 * exceptions.c: Revert.
8397 * event-top.c: Revert.
8398 * event-loop.c: Revert.
8400 * elfread.c: Revert.
8401 * dwarf2read.h: Revert.
8402 * dwarf2read.c: Revert.
8403 * dwarf2loc.c: Revert.
8404 * dwarf2expr.h: Revert.
8405 * dwarf2expr.c: Revert.
8406 * dwarf2-frame.c: Revert.
8407 * dwarf2-frame-tailcall.c: Revert.
8408 * dwarf-index-write.h: Revert.
8409 * dwarf-index-write.c: Revert.
8410 * dwarf-index-common.c: Revert.
8411 * dwarf-index-cache.h: Revert.
8412 * dwarf-index-cache.c: Revert.
8413 * dummy-frame.c: Revert.
8414 * dtrace-probe.c: Revert.
8417 * disasm-selftests.c: Revert.
8418 * dictionary.c: Revert.
8419 * dicos-tdep.c: Revert.
8420 * demangle.c: Revert.
8423 * darwin-nat.h: Revert.
8424 * darwin-nat.c: Revert.
8425 * darwin-nat-info.c: Revert.
8426 * d-valprint.c: Revert.
8427 * d-namespace.c: Revert.
8430 * csky-tdep.c: Revert.
8431 * csky-linux-tdep.c: Revert.
8432 * cris-tdep.c: Revert.
8433 * cris-linux-tdep.c: Revert.
8434 * cp-valprint.c: Revert.
8435 * cp-support.c: Revert.
8436 * cp-namespace.c: Revert.
8438 * corelow.c: Revert.
8439 * corefile.c: Revert.
8440 * continuations.c: Revert.
8441 * completer.h: Revert.
8442 * completer.c: Revert.
8443 * complaints.c: Revert.
8444 * coffread.c: Revert.
8445 * coff-pe-read.c: Revert.
8446 * cli-out.h: Revert.
8447 * cli-out.c: Revert.
8448 * charset.c: Revert.
8449 * c-varobj.c: Revert.
8450 * c-valprint.c: Revert.
8451 * c-typeprint.c: Revert.
8453 * buildsym.c: Revert.
8454 * buildsym-legacy.c: Revert.
8455 * build-id.h: Revert.
8456 * build-id.c: Revert.
8458 * bsd-uthread.c: Revert.
8459 * breakpoint.h: Revert.
8460 * breakpoint.c: Revert.
8461 * break-catch-throw.c: Revert.
8462 * break-catch-syscall.c: Revert.
8463 * break-catch-sig.c: Revert.
8464 * blockframe.c: Revert.
8466 * bfin-tdep.c: Revert.
8467 * bfin-linux-tdep.c: Revert.
8468 * bfd-target.c: Revert.
8470 * ax-general.c: Revert.
8473 * avr-tdep.c: Revert.
8475 * auto-load.c: Revert.
8476 * arm-wince-tdep.c: Revert.
8477 * arm-tdep.c: Revert.
8478 * arm-symbian-tdep.c: Revert.
8479 * arm-pikeos-tdep.c: Revert.
8480 * arm-obsd-tdep.c: Revert.
8481 * arm-nbsd-tdep.c: Revert.
8482 * arm-nbsd-nat.c: Revert.
8483 * arm-linux-tdep.c: Revert.
8484 * arm-linux-nat.c: Revert.
8485 * arm-fbsd-tdep.c: Revert.
8486 * arm-fbsd-nat.c: Revert.
8487 * arm-bsd-tdep.c: Revert.
8488 * arch-utils.c: Revert.
8489 * arc-tdep.c: Revert.
8490 * arc-newlib-tdep.c: Revert.
8491 * annotate.h: Revert.
8492 * annotate.c: Revert.
8493 * amd64-windows-tdep.c: Revert.
8494 * amd64-windows-nat.c: Revert.
8495 * amd64-tdep.c: Revert.
8496 * amd64-sol2-tdep.c: Revert.
8497 * amd64-obsd-tdep.c: Revert.
8498 * amd64-obsd-nat.c: Revert.
8499 * amd64-nbsd-tdep.c: Revert.
8500 * amd64-nbsd-nat.c: Revert.
8501 * amd64-nat.c: Revert.
8502 * amd64-linux-tdep.c: Revert.
8503 * amd64-linux-nat.c: Revert.
8504 * amd64-fbsd-tdep.c: Revert.
8505 * amd64-fbsd-nat.c: Revert.
8506 * amd64-dicos-tdep.c: Revert.
8507 * amd64-darwin-tdep.c: Revert.
8508 * amd64-bsd-nat.c: Revert.
8509 * alpha-tdep.c: Revert.
8510 * alpha-obsd-tdep.c: Revert.
8511 * alpha-nbsd-tdep.c: Revert.
8512 * alpha-mdebug-tdep.c: Revert.
8513 * alpha-linux-tdep.c: Revert.
8514 * alpha-linux-nat.c: Revert.
8515 * alpha-bsd-tdep.c: Revert.
8516 * alpha-bsd-nat.c: Revert.
8517 * aix-thread.c: Revert.
8519 * addrmap.c: Revert.
8520 * ada-varobj.c: Revert.
8521 * ada-valprint.c: Revert.
8522 * ada-typeprint.c: Revert.
8523 * ada-tasks.c: Revert.
8524 * ada-lang.c: Revert.
8525 * aarch64-tdep.c: Revert.
8526 * aarch64-ravenscar-thread.c: Revert.
8527 * aarch64-newlib-tdep.c: Revert.
8528 * aarch64-linux-tdep.c: Revert.
8529 * aarch64-linux-nat.c: Revert.
8530 * aarch64-fbsd-tdep.c: Revert.
8531 * aarch64-fbsd-nat.c: Revert.
8532 * aarch32-linux-nat.c: Revert.
8534 2019-04-05 Tom Tromey <tom@tromey.com>
8536 * ft32-tdep.c: Sort headers.
8537 * frv-tdep.c: Sort headers.
8538 * frv-linux-tdep.c: Sort headers.
8539 * frame.c: Sort headers.
8540 * frame-unwind.c: Sort headers.
8541 * frame-base.c: Sort headers.
8542 * fork-child.c: Sort headers.
8543 * findvar.c: Sort headers.
8544 * findcmd.c: Sort headers.
8545 * filesystem.c: Sort headers.
8546 * filename-seen-cache.h: Sort headers.
8547 * filename-seen-cache.c: Sort headers.
8548 * fbsd-tdep.c: Sort headers.
8549 * fbsd-nat.h: Sort headers.
8550 * fbsd-nat.c: Sort headers.
8551 * f-valprint.c: Sort headers.
8552 * f-typeprint.c: Sort headers.
8553 * f-lang.c: Sort headers.
8554 * extension.h: Sort headers.
8555 * extension.c: Sort headers.
8556 * extension-priv.h: Sort headers.
8557 * expprint.c: Sort headers.
8558 * exec.h: Sort headers.
8559 * exec.c: Sort headers.
8560 * exceptions.c: Sort headers.
8561 * event-top.c: Sort headers.
8562 * event-loop.c: Sort headers.
8563 * eval.c: Sort headers.
8564 * elfread.c: Sort headers.
8565 * dwarf2read.h: Sort headers.
8566 * dwarf2read.c: Sort headers.
8567 * dwarf2loc.c: Sort headers.
8568 * dwarf2expr.h: Sort headers.
8569 * dwarf2expr.c: Sort headers.
8570 * dwarf2-frame.c: Sort headers.
8571 * dwarf2-frame-tailcall.c: Sort headers.
8572 * dwarf-index-write.h: Sort headers.
8573 * dwarf-index-write.c: Sort headers.
8574 * dwarf-index-common.c: Sort headers.
8575 * dwarf-index-cache.h: Sort headers.
8576 * dwarf-index-cache.c: Sort headers.
8577 * dummy-frame.c: Sort headers.
8578 * dtrace-probe.c: Sort headers.
8579 * disasm.h: Sort headers.
8580 * disasm.c: Sort headers.
8581 * disasm-selftests.c: Sort headers.
8582 * dictionary.c: Sort headers.
8583 * dicos-tdep.c: Sort headers.
8584 * demangle.c: Sort headers.
8585 * dcache.h: Sort headers.
8586 * dcache.c: Sort headers.
8587 * darwin-nat.h: Sort headers.
8588 * darwin-nat.c: Sort headers.
8589 * darwin-nat-info.c: Sort headers.
8590 * d-valprint.c: Sort headers.
8591 * d-namespace.c: Sort headers.
8592 * d-lang.c: Sort headers.
8593 * ctf.c: Sort headers.
8594 * csky-tdep.c: Sort headers.
8595 * csky-linux-tdep.c: Sort headers.
8596 * cris-tdep.c: Sort headers.
8597 * cris-linux-tdep.c: Sort headers.
8598 * cp-valprint.c: Sort headers.
8599 * cp-support.c: Sort headers.
8600 * cp-namespace.c: Sort headers.
8601 * cp-abi.c: Sort headers.
8602 * corelow.c: Sort headers.
8603 * corefile.c: Sort headers.
8604 * continuations.c: Sort headers.
8605 * completer.h: Sort headers.
8606 * completer.c: Sort headers.
8607 * complaints.c: Sort headers.
8608 * coffread.c: Sort headers.
8609 * coff-pe-read.c: Sort headers.
8610 * cli-out.h: Sort headers.
8611 * cli-out.c: Sort headers.
8612 * charset.c: Sort headers.
8613 * c-varobj.c: Sort headers.
8614 * c-valprint.c: Sort headers.
8615 * c-typeprint.c: Sort headers.
8616 * c-lang.c: Sort headers.
8617 * buildsym.c: Sort headers.
8618 * buildsym-legacy.c: Sort headers.
8619 * build-id.h: Sort headers.
8620 * build-id.c: Sort headers.
8621 * btrace.c: Sort headers.
8622 * bsd-uthread.c: Sort headers.
8623 * breakpoint.h: Sort headers.
8624 * breakpoint.c: Sort headers.
8625 * break-catch-throw.c: Sort headers.
8626 * break-catch-syscall.c: Sort headers.
8627 * break-catch-sig.c: Sort headers.
8628 * blockframe.c: Sort headers.
8629 * block.c: Sort headers.
8630 * bfin-tdep.c: Sort headers.
8631 * bfin-linux-tdep.c: Sort headers.
8632 * bfd-target.c: Sort headers.
8633 * bcache.c: Sort headers.
8634 * ax-general.c: Sort headers.
8635 * ax-gdb.h: Sort headers.
8636 * ax-gdb.c: Sort headers.
8637 * avr-tdep.c: Sort headers.
8638 * auxv.c: Sort headers.
8639 * auto-load.c: Sort headers.
8640 * arm-wince-tdep.c: Sort headers.
8641 * arm-tdep.c: Sort headers.
8642 * arm-symbian-tdep.c: Sort headers.
8643 * arm-pikeos-tdep.c: Sort headers.
8644 * arm-obsd-tdep.c: Sort headers.
8645 * arm-nbsd-tdep.c: Sort headers.
8646 * arm-nbsd-nat.c: Sort headers.
8647 * arm-linux-tdep.c: Sort headers.
8648 * arm-linux-nat.c: Sort headers.
8649 * arm-fbsd-tdep.c: Sort headers.
8650 * arm-fbsd-nat.c: Sort headers.
8651 * arm-bsd-tdep.c: Sort headers.
8652 * arch-utils.c: Sort headers.
8653 * arc-tdep.c: Sort headers.
8654 * arc-newlib-tdep.c: Sort headers.
8655 * annotate.h: Sort headers.
8656 * annotate.c: Sort headers.
8657 * amd64-windows-tdep.c: Sort headers.
8658 * amd64-windows-nat.c: Sort headers.
8659 * amd64-tdep.c: Sort headers.
8660 * amd64-sol2-tdep.c: Sort headers.
8661 * amd64-obsd-tdep.c: Sort headers.
8662 * amd64-obsd-nat.c: Sort headers.
8663 * amd64-nbsd-tdep.c: Sort headers.
8664 * amd64-nbsd-nat.c: Sort headers.
8665 * amd64-nat.c: Sort headers.
8666 * amd64-linux-tdep.c: Sort headers.
8667 * amd64-linux-nat.c: Sort headers.
8668 * amd64-fbsd-tdep.c: Sort headers.
8669 * amd64-fbsd-nat.c: Sort headers.
8670 * amd64-dicos-tdep.c: Sort headers.
8671 * amd64-darwin-tdep.c: Sort headers.
8672 * amd64-bsd-nat.c: Sort headers.
8673 * alpha-tdep.c: Sort headers.
8674 * alpha-obsd-tdep.c: Sort headers.
8675 * alpha-nbsd-tdep.c: Sort headers.
8676 * alpha-mdebug-tdep.c: Sort headers.
8677 * alpha-linux-tdep.c: Sort headers.
8678 * alpha-linux-nat.c: Sort headers.
8679 * alpha-bsd-tdep.c: Sort headers.
8680 * alpha-bsd-nat.c: Sort headers.
8681 * aix-thread.c: Sort headers.
8682 * agent.c: Sort headers.
8683 * addrmap.c: Sort headers.
8684 * ada-varobj.c: Sort headers.
8685 * ada-valprint.c: Sort headers.
8686 * ada-typeprint.c: Sort headers.
8687 * ada-tasks.c: Sort headers.
8688 * ada-lang.c: Sort headers.
8689 * aarch64-tdep.c: Sort headers.
8690 * aarch64-ravenscar-thread.c: Sort headers.
8691 * aarch64-newlib-tdep.c: Sort headers.
8692 * aarch64-linux-tdep.c: Sort headers.
8693 * aarch64-linux-nat.c: Sort headers.
8694 * aarch64-fbsd-tdep.c: Sort headers.
8695 * aarch64-fbsd-nat.c: Sort headers.
8696 * aarch32-linux-nat.c: Sort headers.
8698 2019-04-04 Tom Tromey <tom@tromey.com>
8700 * varobj.c (varobj_create): Update.
8701 * rust-exp.y (struct rust_parser) <update_innermost_block,
8702 lookup_symbol>: New methods.
8703 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8705 (rust_parser::rust_lookup_type)
8706 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8707 * printcmd.c (display_command, do_one_display): Update.
8708 * parser-defs.h (struct parser_state) <parser_state>: Add
8709 "tracker" parameter.
8710 (block_tracker): New member.
8711 (class innermost_block_tracker) <innermost_block_tracker>: Add
8713 <reset>: Remove method.
8714 (innermost_block): Don't declare.
8715 (null_post_parser): Update.
8716 * parse.c (innermost_block): Remove global.
8717 (write_dollar_variable): Update.
8718 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8719 Remove "tracker_types" parameter.
8720 (parse_expression): Add "tracker" parameter.
8721 (parse_expression_for_completion): Update.
8722 (null_post_parser): Add "tracker" parameter.
8723 * p-exp.y: Update rules.
8724 * m2-exp.y: Update rules.
8725 * language.h (struct language_defn) <la_post_parser>: Add
8726 "tracker" parameter.
8727 * go-exp.y: Update rules.
8728 * f-exp.y: Update rules.
8729 * expression.h (parse_expression, parse_exp_1): Add "tracker"
8731 * d-exp.y: Update rules.
8732 * c-exp.y: Update rules.
8733 * breakpoint.c (set_breakpoint_condition): Create an
8734 innermost_block_tracker.
8735 (watch_command_1): Likewise.
8736 * ada-lang.c (resolve): Add "tracker" parameter.
8737 (resolve_subexp): Likewise.
8738 * ada-exp.y (write_var_from_sym): Update.
8740 2019-04-04 Tom Tromey <tom@tromey.com>
8742 * type-stack.h: New file.
8743 * type-stack.c: New file.
8744 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8746 (insert_into_type_stack, insert_type, push_type, push_type_int)
8747 (insert_type_address_space, pop_type, pop_type_int)
8748 (pop_typelist, pop_type_stack, append_type_stack)
8749 (push_type_stack, get_type_stack, push_typelist)
8750 (follow_type_instance_flags, follow_types): Don't declare.
8751 * parse.c (type_stack): Remove global.
8752 (parse_exp_in_context): Update.
8753 (insert_into_type_stack, insert_type, push_type, push_type_int)
8754 (insert_type_address_space, pop_type, pop_type_int)
8755 (pop_typelist, pop_type_stack, append_type_stack)
8756 (push_type_stack, get_type_stack, push_typelist)
8757 (follow_type_instance_flags, follow_types): Remove (moved to
8759 * f-exp.y (type_stack): New global.
8761 (push_kind_type, f_parse): Update.
8762 * d-exp.y (type_stack): New global.
8765 * c-exp.y (struct c_parse_state) <type_stack>: New member.
8767 * Makefile.in (COMMON_SFILES): Add type-stack.c.
8768 (HFILES_NO_SRCDIR): Add type-stack.h.
8770 2019-04-04 Tom Tromey <tom@tromey.com>
8772 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8773 (rust_parser::convert_ast_to_expression, rust_parse)
8774 (rust_lex_test_completion, rust_lex_tests): Update.
8775 * parser-defs.h (struct expr_completion_state): New.
8776 (struct parser_state) <parser_state>: Add completion parameter.
8777 <mark_struct_expression, mark_completion_tag>: New methods.
8778 <parse_completion, m_completion_state>: New members.
8779 (prefixify_expression, null_post_parser): Update.
8780 (mark_struct_expression, mark_completion_tag): Don't declare.
8781 * parse.c (parse_completion, expout_last_struct)
8782 (expout_tag_completion_type, expout_completion_name): Remove
8784 (parser_state::mark_struct_expression)
8785 (parser_state::mark_completion_tag): Now methods.
8786 (prefixify_expression): Add last_struct parameter.
8787 (prefixify_subexp): Likewise.
8788 (parse_exp_1): Update.
8789 (parse_exp_in_context): Add cstate parameter. Update.
8790 (parse_expression_for_completion): Create an
8791 expr_completion_state.
8792 (null_post_parser): Add "completion" parameter.
8793 * p-exp.y: Update rules.
8795 * language.h (struct language_defn) <la_post_parser>: Add
8796 "completing" parameter.
8797 * go-exp.y: Update rules.
8798 (lex_one_token): Update.
8799 * expression.h (parse_completion): Don't declare.
8800 * d-exp.y: Update rules.
8801 (lex_one_token): Update rules.
8802 * c-exp.y: Update rules.
8803 (lex_one_token): Update.
8804 * ada-lang.c (resolve): Add "parse_completion" parameter.
8805 (resolve_subexp): Likewise.
8806 (ada_resolve_function): Likewise.
8808 2019-04-04 Tom Tromey <tom@tromey.com>
8810 * parser-defs.h (struct parser_state) <start_arglist,
8811 end_arglist>: New methods.
8812 <arglist_len, m_funcall_chain>: New members.
8813 (arglist_len, start_arglist, end_arglist): Don't declare.
8814 * parse.c (arglist_len, funcall_chain): Remove global.
8815 (start_arglist, end_arglist): Remove functions.
8816 (parse_exp_in_context): Update.
8817 * p-exp.y: Update rules.
8818 * m2-exp.y: Update rules.
8819 * go-exp.y: Update rules.
8820 * f-exp.y: Update rules.
8821 * d-exp.y: Update rules.
8822 * c-exp.y: Update rules.
8824 2019-04-04 Tom Tromey <tom@tromey.com>
8826 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8827 lex_operator, push_back>: New methods.
8829 (rust_parser::lex_hex, lex_escape): Rename and update.
8830 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8831 (rust_parser::lex_operator): Rename and update.
8832 (rust_parser::lex_number, rustyylex, rustyyerror)
8833 (rust_lex_test_init, rust_lex_test_sequence)
8834 (rust_lex_test_push_back, rust_lex_tests): Update.
8835 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8837 <lexptr, prev_lexptr>: New members.
8838 (lexptr, prev_lexptr): Don't declare.
8839 * parse.c (lexptr, prev_lexptr): Remove globals.
8840 (parse_exp_in_context): Update.
8841 * p-exp.y (yylex, yyerror): Update.
8842 * m2-exp.y (parse_number, yylex, yyerror): Update.
8843 * go-exp.y (lex_one_token, yyerror): Update.
8844 * f-exp.y (match_string_literal, yylex, yyerror): Update.
8845 * d-exp.y (lex_one_token, yyerror): Update.
8846 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8847 (lex_one_token, yyerror): Update.
8848 * ada-lex.l (YY_INPUT): Update.
8849 (rewind_to_char): Update.
8850 * ada-exp.y (yyerror): Update.
8852 2019-04-04 Tom Tromey <tom@tromey.com>
8854 * rust-exp.y (rustyylex, rust_lex_tests): Update.
8855 * parser-defs.h (struct parser_state) <parser_state>: Add new
8857 <comma_terminates>: New member.
8858 (comma_terminates): Don't declare global.
8859 * parse.c (comma_terminates): Remove global.
8860 (parse_exp_in_context): Update.
8861 * p-exp.y (yylex): Update.
8862 * m2-exp.y (yylex): Update.
8863 * go-exp.y (lex_one_token): Update.
8864 * f-exp.y (yylex): Update.
8865 * d-exp.y (lex_one_token): Update.
8866 * c-exp.y (lex_one_token): Update.
8867 * ada-lex.l: Update.
8869 2019-04-04 Tom Tromey <tom@tromey.com>
8871 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8872 (rustyylex, rust_lex_test_init, rust_lex_test_one)
8873 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8874 * parser-defs.h (paren_depth): Don't declare.
8875 * parse.c (paren_depth): Remove global.
8876 (parse_exp_in_context): Update.
8877 * p-exp.y (paren_depth): New global.
8878 (pascal_parse): Initialize it.
8879 * m2-exp.y (paren_depth): New global.
8880 (m2_parse): Initialize it.
8881 * go-exp.y (paren_depth): New global.
8882 (go_parse): Initialize it.
8883 * f-exp.y (paren_depth): New global.
8884 (f_parse): Initialize it.
8885 * d-exp.y (paren_depth): New global.
8886 (d_parse): Initialize it.
8887 * c-exp.y (paren_depth): New global.
8888 (c_parse): Initialize it.
8889 * ada-lex.l (paren_depth): New global.
8890 (lexer_init): Initialize it.
8892 2019-04-04 Tom Tromey <tom@tromey.com>
8894 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8895 (rust_parser::convert_ast_to_type)
8896 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8897 * parser-defs.h (struct parser_state) <parser_state>: Add
8898 parameters. Initialize new members.
8899 <expression_context_block, expression_context_pc>: New members.
8900 * parse.c (expression_context_block, expression_context_pc):
8902 (parse_exp_in_context): Update.
8903 * p-exp.y: Update all rules.
8905 * m2-exp.y: Update all rules.
8907 * go-exp.y (yylex): Update.
8908 * f-exp.y (yylex): Update.
8909 * d-exp.y: Update all rules.
8911 * c-exp.y: Update all rules.
8912 (lex_one_token, classify_name, yylex, c_parse): Update.
8913 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8915 2019-04-04 Tom Tromey <tom@tromey.com>
8917 * gdbarch.h, gdbarch.c: Rebuild.
8918 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8920 (struct stap_parse_info): Replace "parser_state" with
8922 * parser-defs.h (struct expr_builder): Rename from "parser_state".
8923 (parser_state): New class.
8924 * parse.c (expr_builder): Rename.
8925 (expr_builder::release): Rename.
8926 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8927 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8928 (write_exp_elt_longcst, write_exp_elt_floatcst)
8929 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8930 (write_exp_string_vector, write_exp_bitstring)
8931 (write_exp_msymbol, mark_struct_expression)
8932 (write_dollar_variable)
8933 (insert_type_address_space, increase_expout_size): Replace
8934 "parser_state" with "expr_builder".
8935 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8936 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8937 "parser_state" with "expr_builder".
8939 2019-04-04 Tom Tromey <tom@tromey.com>
8941 * rust-exp.y: Replace "parse_language" with method call.
8943 (yylex): Replace "parse_language" with method call.
8945 (yylex): Replace "parse_language" with method call.
8946 * go-exp.y (classify_name): Replace "parse_language" with method
8948 * f-exp.y (yylex): Replace "parse_language" with method call.
8949 * d-exp.y (lex_one_token): Replace "parse_language" with method
8952 (lex_one_token, classify_name, yylex): Replace "parse_language"
8954 * ada-exp.y (find_primitive_type, type_char)
8955 (type_system_address): Replace "parse_language" with method call.
8957 2019-04-04 Tom Tromey <tom@tromey.com>
8959 * rust-exp.y: Replace "parse_gdbarch" with method call.
8960 * parse.c (write_dollar_variable, insert_type_address_space):
8961 Replace "parse_gdbarch" with method call.
8962 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8964 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8966 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8967 "parse_gdbarch" with method call.
8968 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8970 * f-exp.y (parse_type, parse_f_type, yylex): Replace
8971 "parse_gdbarch" with method call.
8972 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8973 "parse_gdbarch" with method call.
8974 * c-exp.y (parse_type, parse_number, classify_name): Replace
8975 "parse_gdbarch" with method call.
8976 * ada-lex.l: Replace "parse_gdbarch" with method call.
8977 * ada-exp.y (parse_type, find_primitive_type, type_char)
8978 (type_system_address): Replace "parse_gdbarch" with method call.
8980 2019-04-04 Tom Tromey <tom@tromey.com>
8982 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8983 * stap-probe.c (stap_parse_argument): Update.
8984 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8985 initial_size parameter.
8986 * rust-exp.y (rust_lex_tests): Update.
8987 * parse.c (parser_state): Update.
8988 (parse_exp_in_context): Update.
8989 * parser-defs.h (struct parser_state) <parser_state>: Remove
8990 "initial_size" parameter.
8992 2019-04-04 Tom Tromey <tom@tromey.com>
8994 * parser-defs.h (increase_expout_size): Don't declare.
8995 * parse.c (increase_expout_size): Now static.
8997 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
8999 * gnu-nat.c (gnu_nat_target::wait): Fix
9000 target_waitstatus_to_string call.
9002 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
9004 * eval.c (evaluate_subexp_standard): Handle internal functions
9005 during Fortran function call handling.
9007 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
9009 * NEWS: Mention new internal functions.
9010 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9011 (read_base_type): Use dwarf2_init_complex_target_type.
9012 * value.c (creal_internal_fn): New function.
9013 (cimag_internal_fn): New function.
9014 (_initialize_values): Register new internal functions.
9016 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9018 * infrun.c (stop_all_threads): If debug_infrun, always
9019 trace the wait status after wait_one, using
9020 target_waitstatus_to_string and target_pid_to_str.
9021 (handle_inferior_event): Replace various trace of
9022 wait status kind by a single trace.
9023 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9024 wait status kind image by target_waitstatus_to_string.
9025 * target/waitstatus.c (target_waitstatus_to_string): Fix
9028 2019-04-01 Tom Tromey <tromey@adacore.com>
9031 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9033 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
9034 Pedro Alves <palves@redhat.com>
9036 * top.c (quit_force): Call 'finalize_values'.
9037 * value.c (finalize_values): New function.
9038 * value.h (finalize_values): Declare.
9040 2019-03-30 Eli Zaretskii <eliz@gnu.org>
9042 * NEWS: Announce $_gdb_major and $_gdb_minor.
9044 * top.c (init_gdb_version_vars): New function.
9045 (gdb_init): Call init_gdb_version_vars.
9047 2019-03-29 Tom Tromey <tromey@adacore.com>
9049 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
9050 help text. Remove dead code.
9052 2019-03-29 Keith Seitz <keiths@redhat.com>
9054 From Siddhesh Poyarekar:
9055 * f-lang.h (f77_get_upperbound): Return LONGEST.
9056 (f77_get_lowerbound): Likewise.
9057 * f-typeprint.c (f_type_print_varspec_suffix): Expand
9058 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
9060 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
9061 plongest to format print it.
9062 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9063 (f77_get_upperbound): Likewise.
9064 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9065 LOWER_BOUND to LONGEST.
9066 (f77_create_arrayprint_offset_tbl): Likewise.
9068 2019-03-29 Keith Seitz <keiths@redhat.com>
9070 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9071 %s/pulongest for TYPE_LENGTH instead of %d in format
9073 * ada-typerint.c (ada_print_type): Likewise.
9074 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9075 * compile/compile-c-support.c (generate_register_struct): Likewise.
9076 * gdbtypes.c (recursive_dump_type): Likewise.
9077 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9078 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
9079 instead of %d in format strings.
9080 * riscv-tdep.c (riscv_type_alignment): Cast second argument
9081 to std::min to ULONGEST.
9082 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9083 instead of %d in format strings.
9084 * tracepoint.c (info_scope_command): Likewise.
9085 * typeprint.c (print_offset_data::update)
9086 (print_offset_data::finish): Likewise.
9087 * xtensa-tdep.c (xtensa_store_return_value)
9088 (xtensa_push_dummy_call): Likewise.
9090 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
9092 * windows-nat.c (display_selector): Fixed format specifications
9095 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9097 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9099 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
9101 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9102 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9103 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9104 (nios2_linux_init_abi): Install it.
9106 2019-03-28 Alan Hayward <alan.hayward@arm.com>
9108 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9110 2019-03-28 Alan Hayward <alan.hayward@arm.com>
9112 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9114 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9115 Tom Tromey <tromey@adacore.com>
9117 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9119 2019-03-26 Joel Brobecker <brobecker@adacore.com>
9121 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9122 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9123 method to compute the bounds of range types. Also print "[evaluated]"
9124 if the bounds' values come from a dynamic evaluation.
9126 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
9128 * cp-valprint.c (cp_print_value_fields): Don't print trailing
9129 whitespace when pretty printing is on.
9131 2019-03-26 Alan Hayward <alan.hayward@arm.com>
9133 * ppc-linux-nat.c: Add include.
9135 2019-03-26 Alan Hayward <alan.hayward@arm.com>
9137 * NEWS: Mention AArch64 Pointer Authentication.
9139 2019-03-26 Alan Hayward <alan.hayward@arm.com>
9141 * arm-linux-nat.c: Add include.
9143 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
9145 * source-cache.c (source_cache::get_source_lines): Re-read
9146 fullname after calling open_source_file.
9148 2019-03-25 John Baldwin <jhb@FreeBSD.org>
9150 * NEWS: Mention TLS support for FreeBSD.
9152 2019-03-25 Tom Tromey <tromey@adacore.com>
9154 * minsyms.c (BUNCH_SIZE): Update comment.
9155 (~minimal_symbol_reader): Remove old comment.
9156 (compact_minimal_symbols): Update comment.
9157 (minimal_symbol_reader::install): Remove old comment. Update
9160 2019-03-25 Alan Hayward <alan.hayward@arm.com>
9162 * s390-linux-nat.c: Add include.
9164 2019-03-25 Alan Hayward <alan.hayward@arm.com>
9166 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9167 Call linux_get_hwcap.
9168 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9170 (aarch64_linux_get_hwcap): Remove function.
9171 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9173 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9175 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9176 * linux-tdep.c (linux_get_hwcap): Add function.
9177 (linux_get_hwcap2): Likewise.
9178 * linux-tdep.h (linux_get_hwcap): Add declaration.
9179 (linux_get_hwcap2): Likewise.
9180 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9181 (ppc_linux_get_hwcap2): Likewise.
9182 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9184 (ppc_linux_nat_target::insert_watchpoint): Likewise.
9185 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9186 (ppc_linux_nat_target::read_description): Likewise.
9187 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9188 * s390-linux-nat.c: Likewise.
9189 * s390-linux-tdep.c (s390_core_read_description): Likewise.
9191 2019-03-24 Tom Tromey <tom@tromey.com>
9193 * ada-lang.c (standard_lookup): Simplify initialization.
9194 (ada_lookup_symbol_nonlocal): Simplify return.
9195 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9196 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9197 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9198 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9200 * solib.c (solib_global_lookup): Simplify.
9201 * symtab.c (null_block_symbol): Remove.
9202 (symbol_cache_lookup): Simplify returns.
9203 (lookup_language_this): Simplify returns.
9204 (lookup_symbol_aux): Simplify return.
9205 (lookup_local_symbol): Simplify returns.
9206 (lookup_global_symbol_from_objfile): Simplify return.
9207 (lookup_symbol_in_objfile_symtabs)
9208 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9209 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9210 (lookup_static_symbol, lookup_global_symbol): Simplify return.
9211 * cp-namespace.c (cp_lookup_bare_symbol)
9212 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9213 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9214 (cp_lookup_nested_symbol): Don't use null_block_symbol.
9215 (cp_lookup_symbol_via_imports): Simplify initialization.
9216 (find_symbol_in_baseclass): Likewise.
9217 * symtab.h (null_block_symbol): Remove.
9218 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9219 (d_lookup_nested_symbol, d_lookup_symbol_imports)
9220 (d_lookup_symbol_module): Likewise.
9221 (find_symbol_in_baseclass): Simplify initialization.
9223 2019-03-24 Tom Tromey <tom@tromey.com>
9225 * expression.h: Don't include symtab.h.
9226 (struct block): Forward declare.
9228 2019-03-24 Tom Tromey <tom@tromey.com>
9230 * c-exp.y (typebase): Remove casts.
9231 * gdbtypes.c (lookup_unsigned_typename, )
9232 (lookup_signed_typename): Remove cast.
9233 * eval.c (parse_to_comma_and_eval): Remove cast.
9234 * parse.c (write_dollar_variable): Remove cast.
9235 * block.h (struct block) <superblock>: Now const.
9236 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9237 * psymtab.c (psym_map_matching_symbols): Make "block" const.
9238 (map_block): Make "block" const.
9239 * symfile.h (struct quick_symbol_functions)
9240 <map_matching_symbols>: Constify block argument to "callback".
9241 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9243 (find_pc_sect_compunit_symtab): Make "b" const.
9244 (find_symbol_at_address): Likewise.
9245 (search_symbols): Likewise.
9246 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9247 (dw2_debug_names_lookup_symbol): Likewise.
9248 (dw2_map_matching_symbols): Update.
9249 * p-valprint.c (pascal_val_print): Remove "block".
9250 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9251 (aux_add_nonlocal_symbols): Make "block" const.
9252 (resolve_subexp): Remove cast.
9253 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9255 (iterate_over_file_blocks): Likewise.
9256 * f-exp.y (%union) <bval>: Remove.
9257 * coffread.c (patch_opaque_types): Make "b" const.
9258 * spu-tdep.c (spu_catch_start): Make "block" const.
9259 * c-valprint.c (print_unpacked_pointer): Remove "block".
9260 * symmisc.c (dump_symtab_1): Make "b" const.
9261 (block_depth): Make "block" const.
9262 * d-exp.y (%union) <bval>: Remove.
9263 * cp-support.h (cp_lookup_rtti_type): Update.
9264 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9265 * psymtab.c (psym_lookup_symbol): Make "block" const.
9266 (maintenance_check_psymtabs): Make "b" const.
9267 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9268 (enumerate_locals, enumerate_args): Update.
9269 * python/py-symtab.c (stpy_global_block): Make "block" const.
9270 (stpy_static_block): Likewise.
9271 * inline-frame.c (block_starting_point_at): Make "new_block"
9273 * block.c (find_block_in_blockvector): Make return type const.
9274 (blockvector_for_pc_sect): Make "b" const.
9275 (find_block_in_blockvector): Make "b" const.
9277 2019-03-23 Tom Tromey <tom@tromey.com>
9279 * varobj.c (varobj_create): Update.
9280 * symfile.c (clear_symtab_users): Don't reset innermost_block.
9281 * printcmd.c (display_command, do_one_display): Don't reset
9283 * parser-defs.h (enum innermost_block_tracker_type): Move to
9285 (innermost_block): Update comment.
9286 * parse.c (parse_exp_1): Add tracker_types parameter.
9287 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
9288 tracker_types parameter. Reset innermost_block.
9289 (parse_exp_in_context): Remove.
9290 (parse_expression_for_completion): Update.
9291 * objfiles.c (~objfile): Don't reset expression_context_block or
9293 * expression.h (enum innermost_block_tracker_type): Move from
9295 (parse_exp_1): Add tracker_types parameter.
9296 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9297 reset innermost_block.
9299 2019-03-23 Tom Tromey <tom@tromey.com>
9301 * objfiles.h: Include bcache.h.
9303 2019-03-23 Tom Tromey <tom@tromey.com>
9305 * linespec.c (get_current_search_block): Use
9306 scoped_restore_current_language.
9307 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9309 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9310 Jiong Wang <jiong.wang@arm.com>
9312 * aarch64-linux-tdep.c
9313 (aarch64_linux_iterate_over_regset_sections): Check for pauth
9315 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9317 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9318 Jiong Wang <jiong.wang@arm.com>
9320 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9322 (aarch64_analyze_prologue_test): Add PACIASP test.
9323 (aarch64_prologue_prev_register): Unmask PC value.
9325 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9326 Jiong Wang <jiong.wang@arm.com>
9328 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9329 (aarch64_dwarf2_prev_register): Unmask PC value.
9330 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9331 (aarch64_execute_dwarf_cfa_vendor_op): Check for
9332 DW_CFA_AARCH64_negate_ra_state.
9333 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9335 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9336 Jiong Wang <jiong.wang@arm.com>
9338 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9340 (aarch64_pseudo_register_name): Likewise.
9341 (aarch64_pseudo_register_type): Likewise.
9342 (aarch64_pseudo_register_reggroup_p): Likewise.
9343 (aarch64_gdbarch_init): Add pauth registers.
9344 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9345 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9346 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9347 (struct gdbarch_tdep): Add regnum for ra_state.
9349 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9350 Jiong Wang <jiong.wang@arm.com>
9352 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9354 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9355 Jiong Wang <jiong.wang@arm.com>
9357 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9359 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9360 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9361 (aarch64_gdbarch_init): Add puth registers.
9362 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9363 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9364 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9366 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9367 Jiong Wang <jiong.wang@arm.com>
9369 * aarch64-linux-nat.c
9370 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9371 * aarch64-linux-tdep.c
9372 (aarch64_linux_core_read_description): Likewise.
9373 (aarch64_linux_get_hwcap): New function.
9374 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9375 (aarch64_linux_get_hwcap): New declaration.
9377 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9378 Jiong Wang <jiong.wang@arm.com>
9380 * aarch64-linux-nat.c
9381 (aarch64_linux_nat_target::read_description): Add pauth param.
9382 * aarch64-linux-tdep.c
9383 (aarch64_linux_core_read_description): Likewise.
9384 * aarch64-tdep.c (struct target_desc): Add in pauth.
9385 (aarch64_read_description): Add pauth param.
9386 (aarch64_gdbarch_init): Likewise.
9387 * aarch64-tdep.h (aarch64_read_description): Likewise.
9388 * arch/aarch64.c (aarch64_create_target_description): Likewise.
9389 * arch/aarch64.h (aarch64_create_target_description): Likewise.
9390 * features/Makefile: Add new files.
9391 * features/aarch64-pauth.c: New file.
9392 * features/aarch64-pauth.xml: New file.
9394 2019-03-20 Tom Tromey <tromey@adacore.com>
9396 * infrun.c (handle_inferior_event): Rename from
9397 handle_inferior_event_1. Create a scoped_value_mark.
9398 (handle_inferior_event): Remove.
9400 2019-03-19 Tom Tromey <tromey@adacore.com>
9402 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9403 * infrun.h (print_stop_event): Add "displays" parameter.
9404 * infrun.c (print_stop_event): Add "displays" parameter.
9406 2019-03-19 Pedro Alves <palves@redhat.com>
9408 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9409 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
9410 to -1. Fix TABs vs spaces.
9411 (tui_ui_out::tui_ui_out): Don't initialize fields here.
9412 * tui/tui-out.h (tui_ui_out) Add intro comments.
9413 <m_line, m_start_of_line>: In-class initialize, and add describing
9416 2019-03-18 Alan Hayward <alan.hayward@arm.com>
9418 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9420 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9422 2019-03-18 Pedro Alves <palves@redhat.com>
9423 Eli Zaretskii <eliz@gnu.org>
9425 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9426 m_line and m_start_of_line.
9428 2019-03-18 Eli Zaretskii <eliz@gnu.org>
9430 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9431 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9432 it returns a newline. This fixes a regression in TU mode, whereby
9433 the next line is output on the same screen line as the user input.
9435 2019-03-18 Tom Tromey <tromey@adacore.com>
9437 * minsyms.c (minimal_symbol_reader::install): Remove call to
9440 2019-03-18 Pedro Alves <palves@redhat.com>
9442 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9444 (apply_style): New, factored out from ...
9445 (apply_ansi_escape): ... this. Handle reverse video mode.
9446 (tui_set_reverse_mode): New function.
9447 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9448 * tui/tui-winsource.c (tui_show_source_line): Use
9449 tui_set_reverse_mode instead of setting A_STANDOUT.
9450 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9453 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
9455 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9458 2019-03-18 Tom Tromey <tromey@adacore.com>
9460 * ada-lang.c (empty_array): Add "high" parameter.
9461 (ada_evaluate_subexp): Update.
9463 2019-03-17 Sergei Trofimovich <siarheit@google.com>
9465 * unittests/string_view-selftests.c: Define
9466 _initialize_string_view_selftests unconditionally.
9468 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
9471 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9473 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
9476 * windows-nat.c (display_selector): Fix format specifiers.
9478 2019-03-17 Eli Zaretskii <eliz@gnu.org>
9480 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9481 tui_refill_source_window instead of tui_refresh_win, to update the
9482 current execution line. This fixes redisplay of the current line
9483 when stepping through the code with "next" or "step".
9485 2019-03-16 Eli Zaretskii <eliz@gnu.org>
9487 * source-cache.c (source_cache::get_source_lines): Call
9488 find_source_lines to initialize s->nlines. This fixes vertical
9489 scrolling of TUI source window when the DOWN arrow is pressed.
9491 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9493 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9494 linux-thread-db.c (_initialize_thread_db): Likewise.
9496 2019-03-16 Eli Zaretskii <eliz@gnu.org>
9498 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9499 wclrtoeol in tui_show_source_line". This reverts changes made in
9500 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9502 2019-03-15 Tom Tromey <tom@tromey.com>
9504 * symtab.h (struct minimal_symbol): Derive from
9505 general_symbol_info.
9506 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9507 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9508 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9509 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9510 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9511 (MSYMBOL_SEARCH_NAME): Update.
9512 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9513 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9514 * minsyms.c (minimal_symbol_reader::record_full): Update.
9516 2019-03-15 Tom Tromey <tom@tromey.com>
9518 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9520 2019-03-15 Tom Tromey <tom@tromey.com>
9522 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9524 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9526 * minsyms.c (lookup_minimal_symbol_by_pc_section)
9527 (build_minimal_symbol_hash_tables)
9528 (minimal_symbol_reader::install): Update.
9530 2019-03-15 Tom Tromey <tom@tromey.com>
9532 * symtab.c (create_demangled_names_hash): Update.
9533 (symbol_set_names): Update.
9534 * objfiles.h (struct objfile_per_bfd_storage)
9535 <demangled_names_hash>: Now an htab_up.
9536 * objfiles.c (objfile_per_bfd_storage): Simplify.
9538 2019-03-15 Tom Tromey <tom@tromey.com>
9540 * objfiles.h (struct objfile_per_bfd_storage): Declare
9542 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9544 (get_objfile_bfd_data): Use new. Don't initialize
9546 (free_objfile_per_bfd_storage): Remove.
9547 (objfile_bfd_data_free, objfile::~objfile): Use delete.
9549 2019-03-15 Tom Tromey <tom@tromey.com>
9551 * symfile.c (reread_symbols): Update.
9552 * objfiles.c (objfile::objfile): Update.
9553 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9554 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9556 (minimal_symbol_reader::install): Update.
9557 (terminate_minimal_symbol_table): Remove.
9558 * jit.c (jit_object_close_impl): Update.
9560 2019-03-15 Tom Tromey <tom@tromey.com>
9562 * minsyms.c (minimal_symbol_reader::record_full): Remove some
9565 2019-03-15 Tom Tromey <tom@tromey.com>
9567 * objfiles.h (struct objfile_per_bfd_storage)
9568 <demangled_hash_languages>: Now a bitset.
9569 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9570 (lookup_minimal_symbol): Update.
9572 2019-03-15 Tom Tromey <tom@tromey.com>
9574 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9575 Don't return the symbol.
9576 * coffread.c (record_minimal_symbol): Use record_full.
9578 2019-03-14 Eli Zaretskii <eliz@gnu.org>
9580 The MS-Windows port of ncurses fails to switch to a color pair if
9581 one or both of the colors are the implicit default colors. This
9582 change records the default colors when TUI is initialized, and
9583 then specifies them explicitly when a color pair uses the default
9584 colors. This allows color styling in TUI mode on MS-Windows.
9586 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
9588 (tui_initialize_io) [__MINGW32__]: Record the default terminal
9589 colors in ncurses_norm_attr.
9590 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9591 "none", replace it with the default color recorded in
9594 2019-03-14 Tom Tromey <tromey@adacore.com>
9596 * source-cache.h (class source_cache) <get_source_lines>: Return
9598 * source-cache.c (source_cache::extract_lines): Handle case where
9599 first_pos==npos. Return std::string.
9600 (source_cache::get_source_lines): Update.
9602 2019-03-14 Tom Tromey <tromey@adacore.com>
9604 * NEWS: Add item for "style sources" commands.
9605 * source-cache.c (source_cache::get_source_lines): Check
9607 * cli/cli-style.c (source_styling): New global.
9608 (_initialize_cli_style): Add "style sources" commands.
9609 (show_style_sources): New function.
9610 * cli/cli-style.h (source_styling): Declare.
9612 2019-03-14 Pedro Alves <palves@redhat.com>
9613 Tom Tromey <tromey@adacore.com>
9615 * tui/tui-winsource.h (tui_refill_source_window): Declare.
9616 * tui/tui-winsource.c (tui_refill_source_window): New function,
9618 (tui_horizontal_source_scroll): ... here. Move some logic.
9619 * cli/cli-style.c (set_style_enabled): Notify new observable.
9620 * tui/tui-hooks.c (tui_redisplay_source): New function.
9621 (tui_attach_detach_observers): Attach or detach
9622 tui_redisplay_source.
9623 * observable.h (source_styling_changed): New observable.
9624 * observable.c: Define source_styling_changed observable.
9626 2019-03-13 Tom Tromey <tromey@adacore.com>
9628 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9629 (i386_gnu_nat_target::store_registers): Update.
9630 * target-debug.h (target_debug_print_std_string): New macro.
9631 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9632 * windows-tdep.c (display_one_tib): Update.
9633 * tui/tui-stack.c (tui_make_status_line): Update.
9634 * top.c (print_inferior_quit_action): Update.
9635 * thread.c (thr_try_catch_cmd): Update.
9636 (add_thread_with_info): Update.
9637 (thread_target_id_str): Update.
9638 (thr_try_catch_cmd): Update.
9639 (thread_command): Update.
9640 (thread_find_command): Update.
9641 * record-btrace.c (record_btrace_target::info_record)
9642 (record_btrace_resume_thread, record_btrace_target::resume)
9643 (record_btrace_cancel_resume, record_btrace_step_thread)
9644 (record_btrace_target::wait, record_btrace_target::wait)
9645 (record_btrace_target::wait, record_btrace_target::stop): Update.
9646 * progspace.c (print_program_space): Update.
9647 * process-stratum-target.c
9648 (process_stratum_target::thread_address_space): Update.
9649 * linux-fork.c (linux_fork_mourn_inferior)
9650 (detach_checkpoint_command, info_checkpoints_command)
9651 (linux_fork_context): Update.
9652 (linux_fork_detach): Update.
9653 (class scoped_switch_fork_info): Update.
9654 (delete_checkpoint_command): Update.
9655 * infrun.c (follow_fork_inferior): Update.
9656 (follow_fork_inferior): Update.
9657 (proceed_after_vfork_done): Update.
9658 (handle_vfork_child_exec_or_exit): Update.
9659 (follow_exec): Update.
9660 (displaced_step_prepare_throw): Update.
9661 (displaced_step_restore): Update.
9662 (start_step_over): Update.
9664 (clear_proceed_status_thread): Update.
9666 (print_target_wait_results): Update.
9667 (do_target_wait): Update.
9668 (context_switch): Update.
9669 (stop_all_threads): Update.
9670 (restart_threads): Update.
9671 (finish_step_over): Update.
9672 (handle_signal_stop): Update.
9673 (switch_back_to_stepped_thread): Update.
9674 (keep_going_pass_signal): Update.
9675 (print_exited_reason): Update.
9676 (normal_stop): Update.
9677 * inferior.c (inferior_pid_to_str): Change return type.
9678 (print_selected_inferior): Update.
9679 (add_inferior): Update.
9680 (detach_inferior): Update.
9681 * dummy-frame.c (fprint_dummy_frames): Update.
9682 * dcache.c (dcache_info_1): Update.
9683 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9684 (btrace_fetch, btrace_clear): Update.
9685 * linux-tdep.c (linux_core_pid_to_str): Change return type.
9686 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9688 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9689 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9690 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9691 * gdbarch.c, gdbarch.h: Rebuild.
9692 * gdbarch.sh (core_pid_to_str): Change return type.
9693 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9695 (windows_nat_target::pid_to_str): Change return type.
9696 (windows_delete_thread): Update.
9697 (windows_nat_target::attach): Update.
9698 (windows_nat_target::files_info): Update.
9699 * target-delegates.c: Rebuild.
9700 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9702 (sol_thread_target::pid_to_str): Change return type.
9703 * remote.c (class remote_target) <pid_to_str>: Change return
9705 (remote_target::pid_to_str): Change return type.
9706 (extended_remote_target::attach, remote_target::remote_stop_ns)
9707 (remote_target::remote_notif_remove_queued_reply)
9708 (remote_target::push_stop_reply, remote_target::disable_btrace):
9710 (extended_remote_target::attach): Update.
9711 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9713 (gdbsim_target::pid_to_str): Change return type.
9714 * ravenscar-thread.c (struct ravenscar_thread_target)
9715 <pid_to_str>: Change return type.
9716 (ravenscar_thread_target::pid_to_str): Change return type.
9717 * procfs.c (class procfs_target) <pid_to_str>: Change return
9719 (procfs_target::pid_to_str): Change return type.
9720 (procfs_target::attach): Update.
9721 (procfs_target::detach): Update.
9722 (procfs_target::fetch_registers): Update.
9723 (procfs_target::store_registers): Update.
9724 (procfs_target::wait): Update.
9725 (procfs_target::files_info): Update.
9726 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9727 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9729 (nto_procfs_target::pid_to_str): Change return type.
9730 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9731 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9733 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9735 (attach_proc_task_lwp_callback, get_detach_signal)
9736 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9737 (linux_nat_target::resume, wait_lwp, stop_callback)
9738 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9739 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9740 (linux_nat_wait_1, resume_stopped_resumed_lwps)
9741 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9742 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9744 (inf_ptrace_target::attach): Update.
9745 (inf_ptrace_target::files_info): Update.
9746 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9748 (go32_nat_target::pid_to_str): Change return type.
9749 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9750 (gnu_nat_target::wait): Update.
9751 (gnu_nat_target::wait): Update.
9752 (gnu_nat_target::resume): Update.
9753 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9754 (fbsd_nat_target::wait): Update.
9755 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9757 (darwin_nat_target::attach): Update.
9758 * corelow.c (class core_target) <pid_to_str>: Change return type.
9759 (core_target::pid_to_str): Change return type.
9760 * target.c (normal_pid_to_str): Change return type.
9761 (default_pid_to_str): Likewise.
9762 (target_pid_to_str): Change return type.
9763 (target_translate_tls_address): Update.
9764 (target_announce_detach): Update.
9765 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9767 (bsd_uthread_target::pid_to_str): Change return type.
9768 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9770 (bsd_kvm_target::pid_to_str): Change return type.
9771 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9773 (aix_thread_target::pid_to_str): Change return type.
9774 * target.h (struct target_ops) <pid_to_str>: Change return type.
9775 (target_pid_to_str, normal_pid_to_str): Likewise.
9776 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9778 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9780 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9782 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9784 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9786 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9789 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
9791 * NEWS: Mention that the new default MI version is 3. Mention
9792 changes to the output of commands and events that deal with
9793 multi-location breakpoints.
9794 * breakpoint.c: Include "mi/mi-out.h".
9795 (print_one_breakpoint): Change output syntax if using MI version
9797 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9799 (mi_multi_location_breakpoint_output_fixed): New.
9800 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9801 (mi_cmd_fix_multi_location_breakpoint_output): New.
9802 (mi_multi_location_breakpoint_output_fixed): New.
9803 * mi/mi-cmds.c (mi_cmds): Register command
9804 -fix-multi-location-breakpoint-output.
9805 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9808 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
9810 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9811 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9812 instantiate mi_ui_out based on interpreter name.
9813 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9814 * mi/mi-main.c (mi_load_progress): Likewise.
9816 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9818 * NEWS: Combine separate "New targets" sections for 8.3.
9820 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9822 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9823 (ppcfbsd_init_abi): Install gdbarch
9824 "fetch_tls_load_module_address" and "get_thread_local_address"
9827 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9829 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9830 (riscv_fbsd_init_abi): Install gdbarch
9831 "fetch_tls_load_module_address" and "get_thread_local_address"
9834 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9836 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9837 (i386fbsd_init_abi): Install gdbarch
9838 "fetch_tls_load_module_address" and "get_thread_local_address"
9841 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9843 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9844 (amd64fbsd_init_abi): Install gdbarch
9845 "fetch_tls_load_module_address" and "get_thread_local_address"
9848 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9850 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9851 (struct fbsd_pspace_data): New type.
9852 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9853 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9854 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9855 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9856 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9858 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9860 * gdbtypes.c (lookup_struct_elt): New function.
9861 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9862 * gdbtypes.h (struct struct_elt): New type.
9863 (lookup_struct_elt): New prototype.
9865 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9867 * gdbtypes.c (lookup_struct_elt_type): Update comment and
9868 remove disabled code block.
9870 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9872 * gdbarch.sh (get_thread_local_address): New method.
9873 * gdbarch.h, gdbarch.c: Regenerate.
9874 * target.c (target_translate_tls_address): Use
9875 gdbarch_get_thread_local_address if present instead of
9876 target::get_thread_local_address.
9878 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9880 * target.h (target::get_thread_local_address): Update comment.
9882 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9884 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9885 objfile->separate_debug_objfile_backlink if not NULL.
9887 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9889 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9890 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9891 (amd64bsd_store_inferior_registers): Likewise.
9892 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9893 Enable segment base registers.
9894 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9895 PT_GETFSBASE and PT_GETGSBASE.
9896 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9898 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9899 segment base registers.
9900 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9902 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9904 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9905 Update calls to i386_target_description to add 'segments'
9907 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
9908 add segment base registers.
9909 * arch/i386.c (i386_create_target_description): Add 'segments'
9910 parameter to enable segment base registers.
9911 * arch/i386.h (i386_create_target_description): Likewise.
9912 * features/i386/32bit-segments.xml: New file.
9913 * features/i386/32bit-segments.c: Generate.
9914 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9915 call to i386_target_description to add 'segments' parameter.
9916 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9917 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9918 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9919 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9920 if feature is present.
9921 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9922 Add 'segments' parameter to call to i386_target_description.
9923 (i386_target_description): Add 'segments' parameter to enable
9924 segment base registers.
9925 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9926 to call to i386_target_description.
9927 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9928 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9929 Define I386_NUM_REGS.
9930 (i386_target_description): Add 'segments' parameter to enable
9931 segment base registers.
9933 2019-03-12 Eli Zaretskii <eliz@gnu.org>
9936 * source-cache.c: #undef open and close, to avoid unresolved
9937 externals during linking.
9939 2019-03-12 Tom Tromey <tromey@adacore.com>
9941 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9942 const. Add initializers.
9943 (_initialize_remote): Don't initialize ptid globals.
9945 2019-03-12 Pedro Alves <palves@redhat.com>
9947 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9949 2019-03-12 Pedro Alves <palves@redhat.com>
9951 * cp-name-parser.y (main): Remove unused 'len' variable.
9953 2019-03-12 Tom Tromey <tromey@adacore.com>
9955 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9956 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9958 2019-03-12 Tom Tromey <tromey@adacore.com>
9960 * linux-nat.c (iterate_over_lwps): Update.
9961 (stop_callback): Remove parameter.
9962 (stop_wait_callback, detach_callback, resume_set_callback)
9963 (select_singlestep_lwp_callback, set_ignore_sigint)
9964 (status_callback, resumed_callback, resume_clear_callback)
9965 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9967 (linux_nat_target::detach, linux_nat_target::resume)
9968 (linux_stop_and_wait_all_lwps, select_event_lwp)
9969 (linux_nat_filter_event, linux_nat_wait_1)
9970 (linux_nat_target::kill, linux_nat_target::stop)
9971 (linux_nat_target::stop): Update.
9972 (linux_nat_resume_callback): Change type.
9973 (resume_stopped_resumed_lwps, count_events_callback)
9974 (select_event_lwp_callback): Likewise.
9975 (linux_stop_lwp, linux_nat_stop_lwp): Update.
9976 * arm-linux-nat.c (struct update_registers_data): Remove.
9977 (update_registers_callback): Change type.
9978 (arm_linux_insert_hw_breakpoint1): Update.
9979 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9981 (x86_linux_dr_set_addr): Update.
9982 (x86_linux_dr_set_control): Update.
9983 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9984 (iterate_over_lwps): Use gdb::function_view.
9985 * nat/aarch64-linux-hw-point.c (struct
9986 aarch64_dr_update_callback_param): Remove.
9987 (debug_reg_change_callback): Change type.
9988 (aarch64_notify_debug_reg_change): Update.
9989 * s390-linux-nat.c (s390_refresh_per_info): Update.
9991 2019-03-11 Tom Tromey <tromey@adacore.com>
9993 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9994 redundant assignment to "this_cu".
9996 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9998 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10000 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10002 * gdbtypes.c (rank_one_type_parm_set): New function extracted
10004 (rank_one_type): ... this.
10006 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10008 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10010 (rank_one_type): ... this.
10012 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10014 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10016 (rank_one_type): ... this.
10018 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10020 * gdbtypes.c (rank_one_type_parm_float): New function extracted
10022 (rank_one_type): ... this.
10024 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10026 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10028 (rank_one_type): ... this.
10030 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10032 * gdbtypes.c (rank_one_type_parm_range): New function extracted
10034 (rank_one_type): ... this.
10036 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10038 * gdbtypes.c (rank_one_type_parm_char): New function extracted
10040 (rank_one_type): ... this.
10042 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10044 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10046 (rank_one_type): ... this.
10048 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10050 * gdbtypes.c (rank_one_type_parm_int): New function extracted
10052 (rank_one_type): ... this.
10054 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10056 * gdbtypes.c (rank_one_type_parm_func): New function extracted
10058 (rank_one_type): ... this.
10060 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10062 * gdbtypes.c (rank_one_type_parm_array): New function extracted
10064 (rank_one_type): ... this.
10066 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10068 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10070 (rank_one_type): ... this.
10072 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10074 * inferior.c (initialize_inferiors): Ensure 'help set/show print
10075 inferior-events' shows the example events.
10077 2019-03-08 Eli Zaretskii <eliz@gnu.org>
10079 Support styling on native MS-Windows console
10082 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10083 on MS-Windows if $TERM is not defined.
10085 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10087 * posix-hdep.c (gdb_console_fputs):
10088 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10090 * ui-file.h (gdb_console_fputs): Add prototype.
10092 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10093 back to fputs only if the former returns zero.
10095 2019-03-07 Tom Tromey <tom@tromey.com>
10097 * symmisc.c (print_symbol_bcache_statistics): Update.
10098 (print_objfile_statistics): Update.
10099 * symfile.c (allocate_symtab): Update.
10100 * stabsread.c: Don't include bcache.h.
10101 * psymtab.h (struct psymbol_bcache): Don't declare.
10102 (class psymtab_storage) <psymbol_cache>: Now a bcache.
10103 (psymbol_bcache_init, psymbol_bcache_free)
10104 (psymbol_bcache_get_bcache): Don't declare.
10105 * psymtab.c (struct psymbol_bcache): Remove.
10106 (psymtab_storage::psymtab_storage): Update.
10107 (psymtab_storage::~psymtab_storage): Update.
10108 (psymbol_bcache_init, psymbol_bcache_free)
10109 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10110 (add_psymbol_to_bcache): Update.
10111 (allocate_psymtab): Update.
10112 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10113 macro_cache>: No longer pointers.
10114 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10115 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10116 * macrotab.c (macro_bcache): Update.
10117 * macroexp.c: Don't include bcache.h.
10118 * gdbtypes.c (check_types_worklist): Update.
10119 (types_deeply_equal): Remove TRY/CATCH. Update.
10120 * elfread.c (elf_symtab_read): Update.
10121 * dwarf2read.c: Don't include bcache.h.
10122 * buildsym.c (buildsym_compunit::get_macro_table): Update.
10123 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10124 (print_bcache_statistics, bcache_memory_used): Don't declare.
10125 (struct bcache): Move from bcache.c. Add constructor, destructor,
10126 methods. Rename all data members.
10127 * bcache.c (struct bcache): Move to bcache.h.
10128 (bcache::expand_hash_table): Rename from expand_hash_table.
10130 (bcache::insert): Rename from bcache_full.
10131 (bcache::compare): Rename from bcache_compare.
10132 (bcache_xmalloc): Remove.
10133 (bcache::~bcache): Rename from bcache_xfree.
10134 (bcache::print_statistics): Rename from print_bcache_statistics.
10135 (bcache::memory_used): Rename from bcache_memory_used.
10137 2019-03-07 Pedro Alves <palves@redhat.com>
10139 * infrun.c (normal_stop): Also check for
10140 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10142 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
10144 * f-lang.c (value_from_host_double): Moved to...
10145 * value.c (value_from_host_double): ...here.
10146 * value.h (value_from_host_double): Declare.
10147 * guile/scm-math.c (vlscm_convert_typed_number): Use
10148 value_from_host_double.
10149 (vlscm_convert_number): Likewise.
10150 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10151 * python/py-value.c (convert_value_from_python): Likewise.
10153 2019-03-06 Tom Tromey <tom@tromey.com>
10155 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10157 2019-03-06 Tom Tromey <tom@tromey.com>
10159 * utils.h (free_current_contents): Don't declare.
10160 * utils.c (free_current_contents): Remove.
10162 2019-03-06 Tom Tromey <tom@tromey.com>
10164 * top.c (quit_force): Update.
10165 * main.c (captured_command_loop): Update.
10166 * common/new-op.c (operator new): Update.
10167 * common/common-exceptions.c (struct catcher)
10168 <save_cleanup_chain>: Remove member.
10169 (exceptions_state_mc_init): Update.
10170 (exception_try_scope_entry): Return nullptr.
10171 (exception_try_scope_exit, exception_rethrow)
10172 (throw_exception_sjlj, throw_exception_cxx): Update.
10173 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10174 (all_cleanups, do_cleanups, discard_cleanups)
10175 (discard_final_cleanups, save_cleanups, save_final_cleanups)
10176 (restore_cleanups, restore_final_cleanups): Don't declare.
10177 (do_final_cleanups): Remove parameter.
10178 * common/cleanups.c (cleanup_chain, make_cleanup)
10179 (make_cleanup_dtor, all_cleanups, do_cleanups)
10180 (discard_my_cleanups, discard_cleanups)
10181 (discard_final_cleanups, save_my_cleanups, save_cleanups)
10182 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10183 (null_cleanup): Remove.
10184 (do_final_cleanups): Remove parameter.
10186 2019-03-06 Tom Tromey <tom@tromey.com>
10188 * remote.c (remote_target::remote_parse_stop_reply): Use
10189 unique_xmalloc_ptr.
10191 2019-03-06 Tom Tromey <tom@tromey.com>
10193 * stabsread.c (struct stabs_field_info): Rename from field_info.
10194 <list, fnlist>: Add initializers.
10195 <obstack>: New member.
10196 (read_member_functions, read_struct_fields, read_baseclasses):
10197 Allocate on obstack. Don't use cleanups.
10198 (read_one_struct_field, read_member_functions, read_struct_fields)
10199 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10200 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10201 (read_struct_type): Update.
10203 2019-03-06 Tom Tromey <tom@tromey.com>
10205 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10206 * common/filestuff.h (make_cleanup_close): Don't declare.
10207 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10210 2019-03-06 Tom Tromey <tom@tromey.com>
10212 * solib-aix.c: Use make_scope_exit.
10214 2019-03-06 Tom Tromey <tom@tromey.com>
10216 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10217 Use make_scope_exit.
10219 2019-03-06 Tom Tromey <tom@tromey.com>
10221 * solib-svr4.c (disable_probes_interface): Remove parameter.
10222 (svr4_handle_solib_event): Use make_scope_exit.
10224 2019-03-06 Tom Tromey <tom@tromey.com>
10226 * remote.c (struct stop_reply_deleter): Remove.
10227 (stop_reply_up): Update.
10228 (struct stop_reply): Derive from notif_event. Don't typedef.
10229 <regcache>: Now a std::vector.
10230 (stop_reply_xfree): Remove.
10231 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10232 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
10233 (remote_target::discard_pending_stop_replies): Use delete.
10234 (remote_target::remote_parse_stop_reply): Update.
10235 (remote_target::process_stop_reply): Update.
10236 * remote-notif.h (struct notif_event): Add virtual destructor.
10237 Remove "dtr" member.
10238 (struct notif_client) <alloc_event>: Return a unique_ptr.
10239 (notif_event_xfree): Don't declare.
10240 (notif_event_up): New typedef.
10241 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10242 (notif_event_xfree, do_notif_event_xfree): Remove.
10243 (remote_notif_state_xfree): Update.
10245 2019-03-06 Tom Tromey <tom@tromey.com>
10247 * infrun.c (displaced_step_clear_cleanup): Now a
10248 forward_scope_exit type.
10249 (displaced_step_prepare_throw): Update.
10250 (displaced_step_fixup): Update.
10252 2019-03-06 Tom Tromey <tom@tromey.com>
10254 * inferior.h (class inferior): Update comment.
10255 * gdbthread.h (class thread_info): Update comment.
10257 2019-03-06 Joel Brobecker <brobecker@adacore.com>
10258 Tom Tromey <tom@tromey.com>
10260 * stabsread.h (struct stab_section_list): Remove.
10261 (coffstab_build_psymtabs): Update.
10262 * dbxread.c (symbuf_sections): Now a std::vector.
10263 (sect_idx): New global.
10264 (fill_symbuf): Update.
10265 (coffstab_build_psymtabs): Change type of stabsects parameter.
10267 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10269 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10270 (coff_locate_sections): Update.
10271 (coff_symfile_read): Remove cleanups. Update.
10272 (init_stringtab): Add storage parameter.
10273 (free_stringtab, free_stringtab_cleanup): Remove.
10274 (init_lineno): Add storage parameter.
10275 (free_linetab, free_linetab_cleanup): Remove.
10277 2019-03-06 Pedro Alves <palves@redhat.com>
10279 * linux-fork.c (fork_info::clobber_regs): Delete.
10280 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10281 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
10283 (scoped_switch_fork_info::scoped_switch_fork_info)
10284 (checkpoint_command, linux_fork_context): Adjust
10285 fork_save_infrun_state calls.
10287 2019-03-06 Pedro Alves <palves@redhat.com>
10289 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10290 (inf_has_multiple_threads): Return 'bool' and rewrite using
10291 inferior_info::threads().
10293 2019-03-06 Pedro Alves <palves@redhat.com>
10295 * linux-fork.c: Include <list>.
10296 (fork_list): Now a std::list instance.
10297 (fork_info): Add ctor, dtor, and in-class initialize all fields.
10298 (forks_exist_p, find_last_fork): Adjust.
10299 (new_fork): Delete.
10301 (add_fork): Adjust.
10302 (free_fork): Delete, folded into fork_info::~fork_info().
10303 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10305 (init_fork_list): Delete.
10306 (linux_fork_killall, linux_fork_mourn_inferior)
10307 (linux_fork_detach, info_checkpoints_command): Adjust.
10308 (_initialize_linux_fork): No longer call init_fork_list.
10310 2019-03-06 Pedro Alves <palves@redhat.com>
10312 * linux-fork.c (new_fork): New, split out of ...
10313 (add_fork): ... this. Return void. Move "first fork" special
10314 case from here, to ...
10315 (checkpoint_command): ... here.
10316 * linux-linux.h (add_fork): Return void.
10318 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10320 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10322 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10323 Chris January <chris.january@arm.com>
10324 David Lecomber <david.lecomber@arm.com>
10326 * f-exp.y: New token, UNOP_INTRINSIC.
10327 (exp): New pattern using UNOP_INTRINSIC token.
10328 (f77_keywords): Add 'abs' keyword.
10329 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10330 (value_from_host_double): New function.
10331 (evaluate_subexp_f): Support UNOP_ABS.
10333 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10335 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10338 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10340 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10341 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10342 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10344 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10346 * f-exp.y (convert_to_kind_type): Handle more type kinds.
10348 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10349 Chris January <chris.january@arm.com>
10351 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10352 * f-exp.y: Define 'KIND' token.
10353 (exp): New pattern for KIND expressions.
10354 (ptype): Handle types with a kind extension.
10355 (direct_abs_decl): Extend to spot kind extensions.
10356 (f77_keywords): Add 'kind' to the list.
10357 (push_kind_type): New function.
10358 (convert_to_kind_type): New function.
10359 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10360 * parse.c (operator_length_standard): Likewise.
10361 * parser-defs.h (enum type_pieces): Add tp_kind.
10362 * std-operator.def: Add UNOP_KIND.
10364 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10366 * f-exp.y (f_parse): Set yydebug.
10368 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10370 * f-lang.c (evaluate_subexp_f): New function.
10371 (exp_descriptor_f): New global.
10372 (f_language_defn): Use exp_descriptor_f instead of
10373 exp_descriptor_standard.
10375 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10377 * f-exp.y (struct token): Add comments.
10378 (dot_ops): Remove uppercase versions and the end marker.
10379 (f77_keywords): Likewise.
10380 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10381 entries in the dot_ops array are case insensitive, and use
10382 strncasecmp to compare strings. Also some whitespace cleanup in
10383 this area. Similar for the f77_keywords array, except entries in
10384 this list might be case sensitive.
10386 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10388 * f-exp.y (struct f77_boolean_val): Add comments.
10389 (boolean_values): Remove uppercase versions, and end marker.
10390 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10391 and use strncasecmp to achieve case insensitivity. Additionally,
10392 perform whitespace cleanup around this code.
10394 2019-03-06 Tom Tromey <tromey@adacore.com>
10396 * remote-sim.c (gdbsim_target_open): Use result of
10399 2019-03-06 Richard Bunt <richard.bunt@arm.com>
10400 Dirk Schubert <dirk.schubert@arm.com>
10401 Chris January <chris.january@arm.com>
10403 * eval.c (evaluate_subexp_standard): Call Fortran argument
10405 * f-lang.c (struct value): A value which can be passed into a
10406 Fortran function call.
10407 (fortran_argument_convert): Wrap Fortran arguments in a pointer
10409 (struct type): Value ready for a Fortran function call.
10410 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10412 * f-lang.h (fortran_argument_convert): Declaration.
10413 (fortran_preserve_arg_pointer): Declaration.
10414 * infcall.c (value_arg_coerce): Call Fortran argument logic.
10416 2019-03-05 Tom Tromey <tromey@adacore.com>
10418 * python/py-prettyprint.c (print_string_repr): Remove #if.
10419 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10421 2019-03-05 Tom Tromey <tromey@adacore.com>
10423 * target.c (the_dummy_target): Move later. Change type to
10425 (initialize_targets): Don't initialize the_dummy_target.
10427 2019-03-05 Tom Tromey <tromey@adacore.com>
10429 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10430 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10432 2019-03-05 Tom Tromey <tromey@adacore.com>
10434 * windows-nat.c (windows_nat_target::attach)
10435 (windows_nat_target::detach): Don't call gdb_flush.
10436 * valprint.c (generic_val_print, val_print, val_print_string):
10437 Don't call gdb_flush.
10438 * utils.c (defaulted_query): Don't call gdb_flush.
10439 * typeprint.c (print_type_scalar): Don't call gdb_flush.
10440 * target.c (target_announce_detach): Don't call gdb_flush.
10441 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10442 * remote.c (extended_remote_target::attach): Don't call
10444 * procfs.c (procfs_target::detach): Don't call gdb_flush.
10445 * printcmd.c (do_examine): Don't call gdb_flush.
10446 (info_display_command): Don't call gdb_flush.
10447 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10448 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10449 * memattr.c (info_mem_command): Don't call gdb_flush.
10450 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10451 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10452 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10453 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10454 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10455 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10456 (gnu_nat_target::detach): Don't call gdb_flush.
10457 * f-valprint.c (f_val_print): Don't call gdb_flush.
10458 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10459 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10460 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10462 * c-valprint.c (c_val_print): Don't call gdb_flush.
10463 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10465 2019-03-05 Tom Tromey <tromey@adacore.com>
10467 * varobj.c (update_dynamic_varobj_children): Update.
10468 (install_default_visualizer): Use reset, not release.
10469 * value.c (set_internalvar): Update.
10470 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10471 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10472 ATTRIBUTE_UNUSED_RESULT.
10474 2019-03-05 Tom Tromey <tromey@adacore.com>
10476 * remote.c (class scoped_remote_fd) <release>: Add
10477 ATTRIBUTE_UNUSED_RESULT.
10479 2019-03-05 Tom Tromey <tromey@adacore.com>
10481 * macroexp.c (struct macro_buffer) <release>: Add
10482 ATTRIBUTE_UNUSED_RESULT.
10484 2019-03-05 Tom Tromey <tromey@adacore.com>
10486 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10487 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10488 ATTRIBUTE_UNUSED_RESULT.
10490 2019-03-05 Tom Tromey <tromey@adacore.com>
10492 * common/scoped_fd.h (class scoped_fd) <release>: Add
10493 ATTRIBUTE_UNUSED_RESULT.
10495 2019-03-05 Tom Tromey <tromey@adacore.com>
10497 * parser-defs.h (struct parser_state) <release>: Add
10498 ATTRIBUTE_UNUSED_RESULT.
10500 2019-03-05 Tom Tromey <tromey@adacore.com>
10502 * utils.h (class gdb_argv) <release>: Add
10503 ATTRIBUTE_UNUSED_RESULT.
10504 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10506 2019-03-02 Eli Zaretskii <eliz@gnu.org>
10508 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10509 for-loop range, to avoid compiler warnings.
10511 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10512 avoid compiler warnings about unused variables.
10514 * NEWS: Mention end of support for native debugging on MS-Windows
10518 * common/netstuff.c:
10519 * gdbserver/gdbreplay.c
10520 * gdbserver/remote-utils.c:
10522 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10523 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
10524 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10525 'getaddrinfo' and 'freeaddrinfo' were not available before
10526 Windows XP, and mingw.org's MinGW headers by default define
10527 _WIN32_WINNT to 0x500.
10529 2019-03-01 Gary Benson <gbenson@redhat.com>
10531 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10533 2019-02-28 Brian Vandenberg <phantall@gmail.com>
10534 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
10537 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10538 set_sigint_trap, clear_sigint_trap.
10540 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10542 * target.c (target_detach): Clear the regcache and the
10545 2019-02-27 Pedro Alves <palves@redhat.com>
10547 * utils.c (set_screen_size): When we cap the height/width sizes,
10548 tweak the corresponding command variable to show "unlimited":
10550 2019-02-27 Saagar Jha <saagar@saagarjha.com>
10551 Pedro Alves <palves@redhat.com>
10553 * utils.c (set_screen_size): Reduce "infinite" rows and columns
10554 before calling rl_set_screen_size.
10556 2019-02-27 Tom Tromey <tromey@adacore.com>
10558 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10560 * python/py-value.c: Remove Python 2.4 workaround.
10561 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10563 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10564 Python 2.4 workaround.
10565 * python/python-internal.h: Remove Python 2.4 comment.
10566 (Py_ssize_t): Don't define.
10567 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10568 (gdb_Py_DECREF): Remove Python 2.4 workaround.
10569 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10570 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10571 * python/python.c (do_start_initialization): Remove Python 2.4
10573 * python/py-prettyprint.c (class dummy_python_frame): Remove.
10574 (print_children): Remove Python 2.4 workaround.
10575 * python/py-inferior.c (buffer_procs): Remove Python 2.4
10577 (CHARBUFFERPROC_NAME): Remove.
10578 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10579 Python 2.4 workaround.
10581 2019-02-27 Kevin Buettner <kevinb@redhat.com>
10583 * NEWS: Note minimum Python version.
10585 2019-02-27 Kevin Buettner <kevinb@redhat.com>
10587 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10588 code from these functions. Remove corresponding ifdefs. Use
10589 Py_buffer_up instead of explicit calls to PyBuffer_Release.
10590 Remove gotos and target of gotos.
10591 (infpy_search_memory): Likewise.
10593 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10595 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10596 (hppa_gdbarch_init): Don't register deleted functions with
10599 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10601 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10602 (h8300_unwind_sp): Delete.
10603 (h8300_dummy_id): Delete.
10604 (h8300_gdbarch_init): Don't register deleted functions with
10607 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10609 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10610 (ft32_unwind_pc): Delete.
10611 (ft32_unwind_sp): Delete.
10612 (ft32_gdbarch_init): Don't register deleted functions with
10615 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10617 * gdb/frv-tdep.c (frv_dummy_id): Delete.
10618 (frv_unwind_pc): Delete.
10619 (frv_unwind_sp): Delete.
10620 (frv_gdbarch_init): Don't register deleted functions with
10623 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10625 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10626 (riscv_unwind_pc): Delete.
10627 (riscv_unwind_sp): Delete.
10628 (riscv_gdbarch_init): Don't register deleted functions with
10631 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10633 * gdb/csky-tdep.c (csky_dummy_id): Delete.
10634 (csky_unwind_pc): Delete.
10635 (csky_unwind_sp): Delete.
10636 (csky_gdbarch_init): Don't register deleted functions with
10639 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10641 * gdb/cris-tdep.c (cris_dummy_id): Delete.
10642 (cris_unwind_pc): Delete.
10643 (cris_unwind_sp): Delete.
10644 (cris_gdbarch_init): Don't register deleted functions with
10647 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10649 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10650 (bfin_unwind_pc): Delete.
10651 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10653 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10655 * gdb/arm-tdep.c (arm_dummy_id): Delete.
10656 (arm_unwind_pc): Delete.
10657 (arm_unwind_sp): Delete.
10658 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10660 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10662 * gdb/arc-tdep.c (arc_dummy_id): Delete.
10663 (arc_unwind_pc): Delete.
10664 (arc_unwind_sp): Delete.
10665 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10667 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10669 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10670 (alpha_unwind_pc): Delete.
10671 (alpha_gdbarch_init): Don't register deleted functions with
10674 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10676 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10677 (aarch64_unwind_pc): Delete.
10678 (aarch64_unwind_sp): Delete.
10679 (aarch64_gdbarch_init): Don't register deleted functions with
10682 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10684 * gdbtypes.c (type_align): Don't consider static members when
10685 computing structure alignment.
10687 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10689 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10690 return 0 for other types.
10691 * arch-utils.c (default_type_align): Always return 0.
10692 * gdbarch.h: Regenerate.
10693 * gdbarch.sh (type_align): Extend comment.
10694 * gdbtypes.c (type_align): Add additional comments, always call
10695 gdbarch_type_align before applying the default rules.
10696 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10697 generic code will then apply a suitable default.
10698 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10699 types, return 0 for other types.
10701 2019-02-27 Joel Brobecker <brobecker@adacore.com>
10703 * NEWS: Create a new section for the next release branch.
10704 Rename the section of the current branch, now that it has
10707 2019-02-27 Joel Brobecker <brobecker@adacore.com>
10709 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10710 * version.in: Bump version to 8.3.50.DATE-git.
10712 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
10714 * aix-thread.c (ptid_cmp): Remove unused variable.
10715 (get_signaled_thread): Likewise.
10716 (store_regs_user_thread): Likewise.
10717 (store_regs_kernel_thread): Likewise.
10718 (fetch_regs_kernel_thread): Remove shadowed variable.
10720 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
10722 * features/riscv/32bit-cpu.xml: Add register numbers.
10723 * features/riscv/32bit-fpu.c: Regenerate.
10724 * features/riscv/32bit-fpu.xml: Add register numbers.
10725 * features/riscv/64bit-cpu.xml: Add register numbers.
10726 * features/riscv/64bit-fpu.c: Regenerate.
10727 * features/riscv/64bit-fpu.xml: Add register numbers.
10729 2019-02-26 Kevin Buettner <kevinb@redhat.com>
10731 * NEWS: Mention two argument form of gdb.Value constructor.
10732 * python/py-value.c (convert_buffer_and_type_to_value): New
10734 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10735 Add support for handling an optional second argument. Call
10736 convert_buffer_and_type_to_value as appropriate.
10737 * python/python-internal.h (Py_buffer_deleter): New struct.
10738 (Py_buffer_up): New typedef.
10740 2019-02-25 John Baldwin <jhb@FreeBSD.org>
10742 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10743 instead of releasing ownership.
10745 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
10747 * dwarf2read.c (open_and_init_dwp_file): Call
10748 elf_numsections instead of bfd_count_sections to initialize
10749 dwp_file->num_sections.
10751 2019-02-25 Tom Tromey <tromey@adacore.com>
10753 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10755 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
10757 * gcore.in: Add '--readnever' option when invoking GDB.
10759 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
10761 * MAINTAINERS: Update my email address.
10763 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
10765 * build-id.c (build_id_to_debug_bfd_1): New function.
10766 (build_id_to_debug_bfd): Look for separate debug file in
10769 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
10771 * gdbarch.sh: Update the copyright year range that is placed into
10774 2019-02-22 Keith Seitz <keiths@redhat.com>
10777 * linespec.c (create_sals_line_offset): Search for the default
10778 symtab's filename instead of its fullname.
10780 2019-02-21 Alan Hayward <alan.hayward@arm.com>
10782 * NEWS: Update style defaults.
10784 2019-02-21 Alan Hayward <alan.hayward@arm.com>
10786 * main.c (captured_main_1): Disable styling in batch mode.
10788 2019-02-20 Tom Tromey <tom@tromey.com>
10790 * symtab.c (symtab_symbol_info): Fix typos.
10792 2019-02-20 Tom Tromey <tromey@adacore.com>
10794 * findcmd.c (_initialize_mem_search): Use upper case for
10795 metasyntactic variables.
10797 2019-02-20 Alan Hayward <alan.hayward@arm.com>
10799 * aarch64-tdep.c (aarch64_add_reggroups): New function.
10800 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10802 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
10804 * top.h (source_file_name): Change to std::string.
10805 * top.c (source_file_name): Likewise.
10806 (command_line_input): Adjust.
10807 * cli/cli-script.c (script_from_file): Adjust.
10809 2019-02-19 Tom Tromey <tromey@adacore.com>
10811 * ravenscar-thread.c
10812 (ravenscar_thread_target::update_thread_list): Don't call
10813 ada_build_task_list.
10814 * ada-lang.h (ada_build_task_list): Don't declare.
10815 * ada-tasks.c (struct ada_tasks_inferior_data)
10816 <task_list_valid_p>: Now bool.
10817 (read_known_tasks, ada_task_list_changed)
10818 (ada_tasks_invalidate_inferior_data): Update.
10819 (read_known_tasks_array): Return bool.
10820 (read_known_tasks_list): Likewise.
10821 (read_known_tasks): Return void.
10822 (ada_build_task_list): Now static.
10824 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
10826 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10827 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10829 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10831 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10832 variant for ada_tasks_pspace_data_handle and
10833 ada_tasks_inferior_data_handle.
10834 (ada_tasks_pspace_data_cleanup): New function.
10835 (ada_tasks_inferior_data_cleanup): New function.
10837 2019-02-17 Tom Tromey <tom@tromey.com>
10839 * macrotab.h (macro_source_fullname): Return a std::string.
10840 * macrotab.c (macro_include, check_for_redefinition)
10841 (macro_undef, macro_lookup_definition, foreach_macro)
10842 (foreach_macro_in_scope): Update.
10843 (macro_source_fullname): Return a std::string.
10844 * macrocmd.c (show_pp_source_pos): Update.
10846 2019-02-17 Tom Tromey <tom@tromey.com>
10848 * macrocmd.c (show_pp_source_pos): Style the file names.
10850 2019-02-17 Tom Tromey <tom@tromey.com>
10853 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10855 2019-02-17 Tom Tromey <tom@tromey.com>
10857 * ada-lang.c (user_select_syms): Use filtered printing.
10858 * utils.c (wrap_style): New global.
10859 (desired_style): Remove.
10860 (emit_style_escape): Add stream parameter.
10861 (set_output_style, reset_terminal_style, prompt_for_continue):
10863 (flush_wrap_buffer): Only flush gdb_stdout.
10864 (wrap_here): Set wrap_style.
10865 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
10866 treat escape sequences as a character. Change when wrap buffer is
10868 (fputs_styled): Do not set the output style when the default is
10870 * ui-style.h (struct ui_file_style) <is_default>: New method.
10871 * source.c (print_source_lines_base): Emit escape sequences in one
10874 2019-02-17 Joel Brobecker <brobecker@adacore.com>
10876 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10877 integers and enumeration types.
10879 2019-02-17 Joel Brobecker <brobecker@adacore.com>
10881 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10882 instead of lookup_symbol_in_language
10883 (do_exact_match): New function.
10884 (ada_get_symbol_name_matcher): Return do_exact_match when
10885 doing a verbatim match.
10887 2019-02-15 Tom Tromey <tromey@adacore.com>
10889 * ravenscar-thread.c (ravenscar_thread_target::resume)
10890 (ravenscar_thread_target::wait): Special case wildcard requests.
10892 2019-02-15 Tom Tromey <tromey@adacore.com>
10894 * ravenscar-thread.c (base_ptid): Remove.
10895 (struct ravenscar_thread_target) <close>: New method.
10896 <m_base_ptid>: New member.
10897 <update_inferior_ptid, active_task, task_is_currently_active,
10898 runtime_initialized>: Declare methods.
10899 <ravenscar_thread_target>: Add constructor.
10900 (ravenscar_thread_target::task_is_currently_active)
10901 (ravenscar_thread_target::update_inferior_ptid)
10902 (ravenscar_runtime_initialized): Rename. Now methods.
10903 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10904 (ravenscar_thread_target::update_thread_list): Update.
10905 (ravenscar_thread_target::active_task): Now method.
10906 (ravenscar_thread_target::store_registers)
10907 (ravenscar_thread_target::prepare_to_store)
10908 (ravenscar_thread_target::prepare_to_store)
10909 (ravenscar_thread_target::mourn_inferior): Update.
10910 (ravenscar_inferior_created): Use "new" to create target.
10911 (ravenscar_thread_target::get_ada_task_ptid): Update.
10912 (_initialize_ravenscar): Don't initialize base_ptid.
10913 (ravenscar_ops): Remove global.
10915 2019-02-15 Tom Tromey <tromey@adacore.com>
10917 * target.h (push_target): Declare new overload.
10918 * target.c (push_target): New overload, taking an rvalue reference.
10919 * remote.c (remote_target::open_1): Use push_target overload.
10920 * corelow.c (core_target_open): Use push_target overload.
10922 2019-02-15 Tom Tromey <tromey@adacore.com>
10924 * ravenscar-thread.c (is_ravenscar_task)
10925 (ravenscar_task_is_currently_active): Return bool.
10926 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10927 (_initialize_ravenscar): Remove "(void)".
10928 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10931 2019-02-15 Tom Tromey <tromey@adacore.com>
10933 * ravenscar-thread.c (ravenscar_runtime_initializer)
10934 (has_ravenscar_runtime, get_running_thread_id)
10935 (ravenscar_thread_target::resume): Fix indentation.
10937 2019-02-15 Tom Tromey <tromey@adacore.com>
10939 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10940 from ravenscar_arch_ops.
10941 (sparc_ravenscar_ops::fetch_registers)
10942 (sparc_ravenscar_ops::store_registers): Now methods.
10943 (sparc_ravenscar_prepare_to_store): Remove.
10944 (sparc_ravenscar_ops): Redefine.
10945 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10946 methods and destructor. Remove members.
10947 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10948 (ravenscar_thread_target::store_registers)
10949 (ravenscar_thread_target::prepare_to_store): Update.
10950 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10952 (struct ppc_ravenscar_powerpc_ops): Derive from
10953 ravenscar_arch_ops.
10954 (ppc_ravenscar_powerpc_ops::fetch_registers)
10955 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10956 (ppc_ravenscar_powerpc_ops): Redefine.
10957 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10958 (ppc_ravenscar_e500_ops::fetch_registers)
10959 (ppc_ravenscar_e500_ops::store_registers): Now methods.
10960 (ppc_ravenscar_e500_ops): Redefine.
10961 * aarch64-ravenscar-thread.c
10962 (aarch64_ravenscar_generic_prepare_to_store): Remove.
10963 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10964 (aarch64_ravenscar_fetch_registers)
10965 (aarch64_ravenscar_store_registers): Now methods.
10966 (aarch64_ravenscar_ops): Redefine.
10968 2019-02-15 Tom Tromey <tromey@adacore.com>
10970 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10971 (ravenscar_thread_target::stopped_by_hw_breakpoint)
10972 (ravenscar_thread_target::stopped_by_watchpoint)
10973 (ravenscar_thread_target::stopped_data_address)
10974 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10976 2019-02-15 Tom Tromey <tromey@adacore.com>
10978 * ravenscar-thread.c: Fix some typos.
10980 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10981 Tom Tromey <tromey@adacore.com>
10983 * ada-lang.c (ada_exception_sal): Change addr_string to a
10985 (create_ada_exception_catchpoint): Update.
10987 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10988 Tom Tromey <tromey@adacore.com>
10990 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10991 (bp_location_ops): Remove.
10992 (base_breakpoint_allocate_location): Update.
10993 (free_bp_location): Update.
10994 * ada-lang.c (class ada_catchpoint_location)
10995 <ada_catchpoint_location>: Remove ops parameter.
10996 (ada_catchpoint_location_dtor): Remove.
10997 (ada_catchpoint_location_ops): Remove.
10998 (allocate_location_exception): Update.
10999 * breakpoint.h (struct bp_location_ops): Remove.
11000 (class bp_location) <bp_location>: Remove bp_location_ops
11002 <~bp_location>: Add destructor.
11005 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
11006 Pedro Alves <palves@redhat.com>
11008 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11011 2019-02-14 David Michael <fedora.dm0@gmail.com>
11012 Samuel Thibault <samuel.thibault@gnu.org>
11013 Thomas Schwinge <thomas@codesourcery.com>
11015 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11016 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11018 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
11020 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11021 (check_empty): Use "const char *".
11023 * gnu-nat.c (gnu_nat_target::detach): Instead of
11024 'detach_inferior (pid)' call
11025 'detach_inferior (find_inferior_pid (pid))'.
11027 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11028 'nat/fork-inferior.o'.
11029 * gnu-nat.c: #include "nat/fork-inferior.h".
11031 * gnu-nat.c (gnu_nat_target::detach): Instead of
11032 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11033 * gnu-nat.h: #include "inf-child.h".
11034 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11035 'i386_gnu_nat_target::fetch_registers'.
11036 (gnu_store_registers): Rename/move to
11037 'i386_gnu_nat_target::store_registers'.
11039 * config/i386/nm-i386gnu.h: Don't "#include" any files.
11040 * gnu-nat.h (mach_thread_info): New function.
11041 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11043 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11045 2019-02-14 Frederic Konrad <konrad@adacore.com>
11047 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11049 2019-02-14 Joel Brobecker <brobecker@adacore.com>
11051 * windows-nat.c (windows_add_thread): Add new parameter
11052 "main_thread_p" with default value set to false. Update
11053 function documentation as well as all callers.
11054 (windows_delete_thread): Likewise.
11055 (fake_create_process): Update call to windows_add_thread.
11056 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11057 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11058 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11059 call to windows_delete_thread.
11061 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
11063 * MAINTAINERS: Add Andrew Burgess as global maintainer.
11065 2019-02-12 John Baldwin <jhb@FreeBSD.org>
11067 * symfile.c (find_separate_debug_file): Use canonical path of
11068 sysroot with child_path instead of gdb_sysroot if it is valid.
11070 2019-02-12 John Baldwin <jhb@FreeBSD.org>
11072 * symfile.c (find_separate_debug_file): Use child_path to
11073 determine if an object file is under a sysroot.
11075 2019-02-12 John Baldwin <jhb@FreeBSD.org>
11077 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11078 unittests/child-path-selftests.c.
11079 * common/pathstuff.c (child_path): New function.
11080 * common/pathstuff.h (child_path): New prototype.
11081 * unittests/child-path-selftests.c: New file.
11083 2019-02-12 John Baldwin <jhb@FreeBSD.org>
11085 * symfile.c (find_separate_debug_file): Look for separate debug
11086 files in debug directories under the sysroot.
11088 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11090 * symtab.h (struct minimal_symbol data_p): New const method.
11091 (struct minimal_symbol text_p): Likewise.
11092 * symtab.c (output_source_filename): Use file name style
11093 to print file name.
11094 (print_symbol_info): Likewise.
11095 (print_msymbol_info): Use address style to print addresses.
11096 Use function name style to print executable text symbols.
11097 (expand_symtab_containing_pc): Use data_p.
11098 (find_pc_sect_compunit_symtab): Likewise.
11100 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11102 * breakpoint.c (describe_other_breakpoints): Use address style
11103 to print addresses.
11104 (say_where): Likewise.
11106 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11108 * ada-typeprint.c (print_func_type): Print function name
11109 style to print function name.
11110 * c-typeprint.c (c_print_type_1): Likewise.
11112 2019-02-11 Alan Hayward <alan.hayward@arm.com>
11114 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11117 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11119 * c-exp.y (direct_abs_decl): Use emplace_back to record the
11122 2019-02-10 Joel Brobecker <brobecker@adacore.com>
11124 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11125 TYPE_CODE_REF types.
11127 2019-02-08 Jim Wilson <jimw@sifive.com>
11129 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11130 (riscv_linux_fregset): New.
11131 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11133 2019-02-07 Tom Tromey <tom@tromey.com>
11135 * thread.c (thread_cancel_execution_command): Update.
11136 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11138 (struct thread_fsm_ops): Remove.
11139 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11140 (thread_fsm_should_stop, thread_fsm_return_value)
11141 (thread_fsm_set_finished, thread_fsm_finished_p)
11142 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11144 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11145 * infrun.c (clear_proceed_status_thread)
11146 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11147 (print_stop_event): Update.
11148 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11150 (step_command_fsm_ops): Remove.
11151 (new_step_command_fsm): Remove.
11153 (step_command_fsm::should_stop): Rename from
11154 step_command_fsm_should_stop.
11155 (step_command_fsm::clean_up): Rename from
11156 step_command_fsm_clean_up.
11157 (step_command_fsm::do_async_reply_reason): Rename from
11158 step_command_fsm_async_reply_reason.
11159 (struct until_next_fsm): Inherit from thread_fsm. Add
11161 (until_next_fsm_ops): Remove.
11162 (new_until_next_fsm): Remove.
11163 (until_next_fsm::should_stop): Rename from
11164 until_next_fsm_should_stop.
11165 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11166 (until_next_fsm::do_async_reply_reason): Rename from
11167 until_next_fsm_async_reply_reason.
11168 (struct finish_command_fsm): Inherit from thread_fsm. Add
11169 constructor. Change type of breakpoint.
11170 (finish_command_fsm_ops): Remove.
11171 (new_finish_command_fsm): Remove.
11172 (finish_command_fsm::should_stop): Rename from
11173 finish_command_fsm_should_stop.
11174 (finish_command_fsm::clean_up): Rename from
11175 finish_command_fsm_clean_up.
11176 (finish_command_fsm::return_value): Rename from
11177 finish_command_fsm_return_value.
11178 (finish_command_fsm::do_async_reply_reason): Rename from
11179 finish_command_fsm_async_reply_reason.
11180 (finish_command): Update.
11181 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11183 (call_thread_fsm_ops): Remove.
11184 (call_thread_fsm::call_thread_fsm): Rename from
11185 new_call_thread_fsm.
11186 (call_thread_fsm::should_stop): Rename from
11187 call_thread_fsm_should_stop.
11188 (call_thread_fsm::should_notify_stop): Rename from
11189 call_thread_fsm_should_notify_stop.
11190 (run_inferior_call, call_function_by_hand_dummy): Update.
11191 * cli/cli-interp.c (should_print_stop_to_console): Update.
11192 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11193 Add constructor. Change type of location_breakpoint,
11195 (until_break_fsm_ops): Remove.
11196 (new_until_break_fsm): Remove.
11197 (until_break_fsm::should_stop): Rename from
11198 until_break_fsm_should_stop.
11199 (until_break_fsm::clean_up): Rename from
11200 until_break_fsm_clean_up.
11201 (until_break_fsm::do_async_reply_reason): Rename from
11202 until_break_fsm_async_reply_reason.
11203 (until_break_command): Update.
11204 * thread-fsm.c: Remove.
11205 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11207 2019-02-07 Tom Tromey <tom@tromey.com>
11209 * yy-remap.h: Add include guard.
11210 * xtensa-tdep.h: Add include guard.
11211 * xcoffread.h: Rename include guard.
11212 * varobj-iter.h: Add include guard.
11213 * tui/tui.h: Rename include guard.
11214 * tui/tui-winsource.h: Rename include guard.
11215 * tui/tui-wingeneral.h: Rename include guard.
11216 * tui/tui-windata.h: Rename include guard.
11217 * tui/tui-win.h: Rename include guard.
11218 * tui/tui-stack.h: Rename include guard.
11219 * tui/tui-source.h: Rename include guard.
11220 * tui/tui-regs.h: Rename include guard.
11221 * tui/tui-out.h: Rename include guard.
11222 * tui/tui-layout.h: Rename include guard.
11223 * tui/tui-io.h: Rename include guard.
11224 * tui/tui-hooks.h: Rename include guard.
11225 * tui/tui-file.h: Rename include guard.
11226 * tui/tui-disasm.h: Rename include guard.
11227 * tui/tui-data.h: Rename include guard.
11228 * tui/tui-command.h: Rename include guard.
11229 * tic6x-tdep.h: Add include guard.
11230 * target/waitstatus.h: Rename include guard.
11231 * target/wait.h: Rename include guard.
11232 * target/target.h: Rename include guard.
11233 * target/resume.h: Rename include guard.
11234 * target-float.h: Rename include guard.
11235 * stabsread.h: Add include guard.
11236 * rs6000-tdep.h: Add include guard.
11237 * riscv-fbsd-tdep.h: Add include guard.
11238 * regformats/regdef.h: Rename include guard.
11239 * record.h: Rename include guard.
11240 * python/python.h: Rename include guard.
11241 * python/python-internal.h: Rename include guard.
11242 * python/py-stopevent.h: Rename include guard.
11243 * python/py-ref.h: Rename include guard.
11244 * python/py-record.h: Rename include guard.
11245 * python/py-record-full.h: Rename include guard.
11246 * python/py-record-btrace.h: Rename include guard.
11247 * python/py-instruction.h: Rename include guard.
11248 * python/py-events.h: Rename include guard.
11249 * python/py-event.h: Rename include guard.
11250 * procfs.h: Add include guard.
11251 * proc-utils.h: Add include guard.
11252 * p-lang.h: Add include guard.
11253 * or1k-tdep.h: Rename include guard.
11254 * observable.h: Rename include guard.
11255 * nto-tdep.h: Rename include guard.
11256 * nat/x86-linux.h: Rename include guard.
11257 * nat/x86-linux-dregs.h: Rename include guard.
11258 * nat/x86-gcc-cpuid.h: Add include guard.
11259 * nat/x86-dregs.h: Rename include guard.
11260 * nat/x86-cpuid.h: Rename include guard.
11261 * nat/ppc-linux.h: Rename include guard.
11262 * nat/mips-linux-watch.h: Rename include guard.
11263 * nat/linux-waitpid.h: Rename include guard.
11264 * nat/linux-ptrace.h: Rename include guard.
11265 * nat/linux-procfs.h: Rename include guard.
11266 * nat/linux-osdata.h: Rename include guard.
11267 * nat/linux-nat.h: Rename include guard.
11268 * nat/linux-namespaces.h: Rename include guard.
11269 * nat/linux-btrace.h: Rename include guard.
11270 * nat/glibc_thread_db.h: Rename include guard.
11271 * nat/gdb_thread_db.h: Rename include guard.
11272 * nat/gdb_ptrace.h: Rename include guard.
11273 * nat/fork-inferior.h: Rename include guard.
11274 * nat/amd64-linux-siginfo.h: Rename include guard.
11275 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11276 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11277 * nat/aarch64-linux.h: Rename include guard.
11278 * nat/aarch64-linux-hw-point.h: Rename include guard.
11279 * mn10300-tdep.h: Add include guard.
11280 * mips-linux-tdep.h: Add include guard.
11281 * mi/mi-parse.h: Rename include guard.
11282 * mi/mi-out.h: Rename include guard.
11283 * mi/mi-main.h: Rename include guard.
11284 * mi/mi-interp.h: Rename include guard.
11285 * mi/mi-getopt.h: Rename include guard.
11286 * mi/mi-console.h: Rename include guard.
11287 * mi/mi-common.h: Rename include guard.
11288 * mi/mi-cmds.h: Rename include guard.
11289 * mi/mi-cmd-break.h: Rename include guard.
11290 * m2-lang.h: Add include guard.
11291 * location.h: Rename include guard.
11292 * linux-record.h: Rename include guard.
11293 * linux-nat.h: Add include guard.
11294 * linux-fork.h: Add include guard.
11295 * i386-darwin-tdep.h: Rename include guard.
11296 * hppa-linux-offsets.h: Add include guard.
11297 * guile/guile.h: Rename include guard.
11298 * guile/guile-internal.h: Rename include guard.
11299 * gnu-nat.h: Rename include guard.
11300 * gdb-stabs.h: Rename include guard.
11301 * frv-tdep.h: Add include guard.
11302 * f-lang.h: Add include guard.
11303 * event-loop.h: Add include guard.
11304 * darwin-nat.h: Rename include guard.
11305 * cp-abi.h: Rename include guard.
11306 * config/sparc/nm-sol2.h: Rename include guard.
11307 * config/nm-nto.h: Rename include guard.
11308 * config/nm-linux.h: Add include guard.
11309 * config/i386/nm-i386gnu.h: Rename include guard.
11310 * config/djgpp/nl_types.h: Rename include guard.
11311 * config/djgpp/langinfo.h: Rename include guard.
11312 * compile/gcc-cp-plugin.h: Add include guard.
11313 * compile/gcc-c-plugin.h: Add include guard.
11314 * compile/compile.h: Rename include guard.
11315 * compile/compile-object-run.h: Rename include guard.
11316 * compile/compile-object-load.h: Rename include guard.
11317 * compile/compile-internal.h: Rename include guard.
11318 * compile/compile-cplus.h: Rename include guard.
11319 * compile/compile-c.h: Rename include guard.
11320 * common/xml-utils.h: Rename include guard.
11321 * common/x86-xstate.h: Rename include guard.
11322 * common/version.h: Rename include guard.
11323 * common/vec.h: Rename include guard.
11324 * common/tdesc.h: Rename include guard.
11325 * common/selftest.h: Rename include guard.
11326 * common/scoped_restore.h: Rename include guard.
11327 * common/scoped_mmap.h: Rename include guard.
11328 * common/scoped_fd.h: Rename include guard.
11329 * common/safe-iterator.h: Rename include guard.
11330 * common/run-time-clock.h: Rename include guard.
11331 * common/refcounted-object.h: Rename include guard.
11332 * common/queue.h: Rename include guard.
11333 * common/ptid.h: Rename include guard.
11334 * common/print-utils.h: Rename include guard.
11335 * common/preprocessor.h: Rename include guard.
11336 * common/pathstuff.h: Rename include guard.
11337 * common/observable.h: Rename include guard.
11338 * common/netstuff.h: Rename include guard.
11339 * common/job-control.h: Rename include guard.
11340 * common/host-defs.h: Rename include guard.
11341 * common/gdb_wait.h: Rename include guard.
11342 * common/gdb_vecs.h: Rename include guard.
11343 * common/gdb_unlinker.h: Rename include guard.
11344 * common/gdb_unique_ptr.h: Rename include guard.
11345 * common/gdb_tilde_expand.h: Rename include guard.
11346 * common/gdb_sys_time.h: Rename include guard.
11347 * common/gdb_string_view.h: Rename include guard.
11348 * common/gdb_splay_tree.h: Rename include guard.
11349 * common/gdb_setjmp.h: Rename include guard.
11350 * common/gdb_ref_ptr.h: Rename include guard.
11351 * common/gdb_optional.h: Rename include guard.
11352 * common/gdb_locale.h: Rename include guard.
11353 * common/gdb_assert.h: Rename include guard.
11354 * common/filtered-iterator.h: Rename include guard.
11355 * common/filestuff.h: Rename include guard.
11356 * common/fileio.h: Rename include guard.
11357 * common/environ.h: Rename include guard.
11358 * common/common-utils.h: Rename include guard.
11359 * common/common-types.h: Rename include guard.
11360 * common/common-regcache.h: Rename include guard.
11361 * common/common-inferior.h: Rename include guard.
11362 * common/common-gdbthread.h: Rename include guard.
11363 * common/common-exceptions.h: Rename include guard.
11364 * common/common-defs.h: Rename include guard.
11365 * common/common-debug.h: Rename include guard.
11366 * common/cleanups.h: Rename include guard.
11367 * common/buffer.h: Rename include guard.
11368 * common/btrace-common.h: Rename include guard.
11369 * common/break-common.h: Rename include guard.
11370 * cli/cli-utils.h: Rename include guard.
11371 * cli/cli-style.h: Rename include guard.
11372 * cli/cli-setshow.h: Rename include guard.
11373 * cli/cli-script.h: Rename include guard.
11374 * cli/cli-interp.h: Rename include guard.
11375 * cli/cli-decode.h: Rename include guard.
11376 * cli/cli-cmds.h: Rename include guard.
11377 * charset-list.h: Add include guard.
11378 * buildsym-legacy.h: Rename include guard.
11379 * bfin-tdep.h: Add include guard.
11380 * ax.h: Rename include guard.
11381 * arm-linux-tdep.h: Add include guard.
11382 * arm-fbsd-tdep.h: Add include guard.
11383 * arch/xtensa.h: Rename include guard.
11384 * arch/tic6x.h: Add include guard.
11385 * arch/i386.h: Add include guard.
11386 * arch/arm.h: Rename include guard.
11387 * arch/arm-linux.h: Rename include guard.
11388 * arch/arm-get-next-pcs.h: Rename include guard.
11389 * arch/amd64.h: Add include guard.
11390 * arch/aarch64-insn.h: Rename include guard.
11391 * arch-utils.h: Rename include guard.
11392 * annotate.h: Add include guard.
11393 * amd64-darwin-tdep.h: Rename include guard.
11394 * aarch64-linux-tdep.h: Add include guard.
11395 * aarch64-fbsd-tdep.h: Add include guard.
11396 * aarch32-linux-nat.h: Add include guard.
11398 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11400 * macrotab.c (macro_define_internal): New function that
11401 factorizes macro_define_object_internal and macro_define_function
11403 (macro_define_object_internal): Use macro_define_internal.
11404 (macro_define_function): Likewise.
11406 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11408 * macrocmd.c (extract_identifier): Return
11409 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11412 2019-02-06 John Baldwin <jhb@FreeBSD.org>
11414 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11416 2019-02-05 Tom Tromey <tom@tromey.com>
11418 * target.c (target_stack::unpush): Move assertion earlier.
11420 2019-01-30 Tom Tromey <tom@tromey.com>
11423 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11424 (gdbpy_parse_and_eval): Likewise.
11425 * python/python-internal.h (gdbpy_allow_threads): New class.
11427 2019-01-28 John Baldwin <jhb@FreeBSD.org>
11429 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11430 (aarch64_fbsd_fpregmap): Move earlier.
11431 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11432 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11433 instead of individual calls to trad_frame_set_reg_addr.
11434 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11436 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11437 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11438 instead of individual calls to trad_frame_set_reg_addr.
11440 2019-01-28 Alan Hayward <alan.hayward@arm.com>
11442 * CONTRIBUTE: Replace contribution list with wiki link.
11444 2019-01-25 Tom Tromey <tom@tromey.com>
11446 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11448 2019-01-25 Tom Tromey <tom@tromey.com>
11450 * xtensa-linux-nat.c: Fix common/ includes.
11451 * xml-support.h: Fix common/ includes.
11452 * xml-support.c: Fix common/ includes.
11453 * x86-linux-nat.c: Fix common/ includes.
11454 * windows-nat.c: Fix common/ includes.
11455 * varobj.h: Fix common/ includes.
11456 * varobj.c: Fix common/ includes.
11457 * value.c: Fix common/ includes.
11458 * valops.c: Fix common/ includes.
11459 * utils.c: Fix common/ includes.
11460 * unittests/xml-utils-selftests.c: Fix common/ includes.
11461 * unittests/utils-selftests.c: Fix common/ includes.
11462 * unittests/unpack-selftests.c: Fix common/ includes.
11463 * unittests/tracepoint-selftests.c: Fix common/ includes.
11464 * unittests/style-selftests.c: Fix common/ includes.
11465 * unittests/string_view-selftests.c: Fix common/ includes.
11466 * unittests/scoped_restore-selftests.c: Fix common/ includes.
11467 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11468 * unittests/scoped_fd-selftests.c: Fix common/ includes.
11469 * unittests/rsp-low-selftests.c: Fix common/ includes.
11470 * unittests/parse-connection-spec-selftests.c: Fix common/
11472 * unittests/optional-selftests.c: Fix common/ includes.
11473 * unittests/offset-type-selftests.c: Fix common/ includes.
11474 * unittests/observable-selftests.c: Fix common/ includes.
11475 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11476 * unittests/memrange-selftests.c: Fix common/ includes.
11477 * unittests/memory-map-selftests.c: Fix common/ includes.
11478 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11479 * unittests/function-view-selftests.c: Fix common/ includes.
11480 * unittests/environ-selftests.c: Fix common/ includes.
11481 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11482 * unittests/common-utils-selftests.c: Fix common/ includes.
11483 * unittests/cli-utils-selftests.c: Fix common/ includes.
11484 * unittests/array-view-selftests.c: Fix common/ includes.
11485 * ui-file.c: Fix common/ includes.
11486 * tui/tui-io.c: Fix common/ includes.
11487 * tracepoint.h: Fix common/ includes.
11488 * tracepoint.c: Fix common/ includes.
11489 * tracefile-tfile.c: Fix common/ includes.
11490 * top.h: Fix common/ includes.
11491 * top.c: Fix common/ includes.
11492 * thread.c: Fix common/ includes.
11493 * target/waitstatus.h: Fix common/ includes.
11494 * target/waitstatus.c: Fix common/ includes.
11495 * target.h: Fix common/ includes.
11496 * target.c: Fix common/ includes.
11497 * target-memory.c: Fix common/ includes.
11498 * target-descriptions.c: Fix common/ includes.
11499 * symtab.h: Fix common/ includes.
11500 * symfile.c: Fix common/ includes.
11501 * stap-probe.c: Fix common/ includes.
11502 * spu-linux-nat.c: Fix common/ includes.
11503 * sparc-nat.c: Fix common/ includes.
11504 * source.c: Fix common/ includes.
11505 * solib.c: Fix common/ includes.
11506 * solib-target.c: Fix common/ includes.
11507 * ser-unix.c: Fix common/ includes.
11508 * ser-tcp.c: Fix common/ includes.
11509 * ser-pipe.c: Fix common/ includes.
11510 * ser-base.c: Fix common/ includes.
11511 * selftest-arch.c: Fix common/ includes.
11512 * s12z-tdep.c: Fix common/ includes.
11513 * rust-exp.y: Fix common/ includes.
11514 * rs6000-aix-tdep.c: Fix common/ includes.
11515 * riscv-tdep.c: Fix common/ includes.
11516 * remote.c: Fix common/ includes.
11517 * remote-notif.h: Fix common/ includes.
11518 * remote-fileio.h: Fix common/ includes.
11519 * remote-fileio.c: Fix common/ includes.
11520 * regcache.h: Fix common/ includes.
11521 * regcache.c: Fix common/ includes.
11522 * record-btrace.c: Fix common/ includes.
11523 * python/python.c: Fix common/ includes.
11524 * python/py-type.c: Fix common/ includes.
11525 * python/py-inferior.c: Fix common/ includes.
11526 * progspace.h: Fix common/ includes.
11527 * producer.c: Fix common/ includes.
11528 * procfs.c: Fix common/ includes.
11529 * proc-api.c: Fix common/ includes.
11530 * printcmd.c: Fix common/ includes.
11531 * ppc-linux-nat.c: Fix common/ includes.
11532 * parser-defs.h: Fix common/ includes.
11533 * osdata.c: Fix common/ includes.
11534 * obsd-nat.c: Fix common/ includes.
11535 * nat/x86-linux.c: Fix common/ includes.
11536 * nat/x86-linux-dregs.c: Fix common/ includes.
11537 * nat/x86-dregs.h: Fix common/ includes.
11538 * nat/x86-dregs.c: Fix common/ includes.
11539 * nat/ppc-linux.c: Fix common/ includes.
11540 * nat/mips-linux-watch.h: Fix common/ includes.
11541 * nat/mips-linux-watch.c: Fix common/ includes.
11542 * nat/linux-waitpid.c: Fix common/ includes.
11543 * nat/linux-ptrace.h: Fix common/ includes.
11544 * nat/linux-ptrace.c: Fix common/ includes.
11545 * nat/linux-procfs.c: Fix common/ includes.
11546 * nat/linux-personality.c: Fix common/ includes.
11547 * nat/linux-osdata.c: Fix common/ includes.
11548 * nat/linux-namespaces.c: Fix common/ includes.
11549 * nat/linux-btrace.h: Fix common/ includes.
11550 * nat/linux-btrace.c: Fix common/ includes.
11551 * nat/fork-inferior.c: Fix common/ includes.
11552 * nat/amd64-linux-siginfo.c: Fix common/ includes.
11553 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11554 * nat/aarch64-linux.c: Fix common/ includes.
11555 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11556 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11557 * namespace.h: Fix common/ includes.
11558 * mips-linux-tdep.c: Fix common/ includes.
11559 * minsyms.c: Fix common/ includes.
11560 * mi/mi-parse.h: Fix common/ includes.
11561 * mi/mi-main.c: Fix common/ includes.
11562 * mi/mi-cmd-env.c: Fix common/ includes.
11563 * memrange.h: Fix common/ includes.
11564 * memattr.c: Fix common/ includes.
11565 * maint.h: Fix common/ includes.
11566 * maint.c: Fix common/ includes.
11567 * main.c: Fix common/ includes.
11568 * machoread.c: Fix common/ includes.
11569 * location.c: Fix common/ includes.
11570 * linux-thread-db.c: Fix common/ includes.
11571 * linux-nat.c: Fix common/ includes.
11572 * linux-fork.c: Fix common/ includes.
11573 * inline-frame.c: Fix common/ includes.
11574 * infrun.c: Fix common/ includes.
11575 * inflow.c: Fix common/ includes.
11576 * inferior.h: Fix common/ includes.
11577 * inferior.c: Fix common/ includes.
11578 * infcmd.c: Fix common/ includes.
11579 * inf-ptrace.c: Fix common/ includes.
11580 * inf-child.c: Fix common/ includes.
11581 * ia64-linux-nat.c: Fix common/ includes.
11582 * i387-tdep.c: Fix common/ includes.
11583 * i386-tdep.c: Fix common/ includes.
11584 * i386-linux-tdep.c: Fix common/ includes.
11585 * i386-linux-nat.c: Fix common/ includes.
11586 * i386-go32-tdep.c: Fix common/ includes.
11587 * i386-fbsd-tdep.c: Fix common/ includes.
11588 * i386-fbsd-nat.c: Fix common/ includes.
11589 * guile/scm-type.c: Fix common/ includes.
11590 * guile/guile.c: Fix common/ includes.
11591 * go32-nat.c: Fix common/ includes.
11592 * gnu-nat.c: Fix common/ includes.
11593 * gdbthread.h: Fix common/ includes.
11594 * gdbarch-selftests.c: Fix common/ includes.
11595 * gdb_usleep.c: Fix common/ includes.
11596 * gdb_select.h: Fix common/ includes.
11597 * gdb_bfd.c: Fix common/ includes.
11598 * gcore.c: Fix common/ includes.
11599 * fork-child.c: Fix common/ includes.
11600 * findvar.c: Fix common/ includes.
11601 * fbsd-nat.c: Fix common/ includes.
11602 * event-top.c: Fix common/ includes.
11603 * event-loop.c: Fix common/ includes.
11604 * dwarf2read.c: Fix common/ includes.
11605 * dwarf2loc.c: Fix common/ includes.
11606 * dwarf2-frame.c: Fix common/ includes.
11607 * dwarf-index-cache.c: Fix common/ includes.
11608 * dtrace-probe.c: Fix common/ includes.
11609 * disasm-selftests.c: Fix common/ includes.
11610 * defs.h: Fix common/ includes.
11611 * csky-tdep.c: Fix common/ includes.
11612 * cp-valprint.c: Fix common/ includes.
11613 * cp-support.h: Fix common/ includes.
11614 * cp-support.c: Fix common/ includes.
11615 * corelow.c: Fix common/ includes.
11616 * completer.h: Fix common/ includes.
11617 * completer.c: Fix common/ includes.
11618 * compile/compile.c: Fix common/ includes.
11619 * compile/compile-loc2c.c: Fix common/ includes.
11620 * compile/compile-cplus-types.c: Fix common/ includes.
11621 * compile/compile-cplus-symbols.c: Fix common/ includes.
11622 * command.h: Fix common/ includes.
11623 * cli/cli-dump.c: Fix common/ includes.
11624 * cli/cli-cmds.c: Fix common/ includes.
11625 * charset.c: Fix common/ includes.
11626 * build-id.c: Fix common/ includes.
11627 * btrace.h: Fix common/ includes.
11628 * btrace.c: Fix common/ includes.
11629 * breakpoint.h: Fix common/ includes.
11630 * breakpoint.c: Fix common/ includes.
11632 (enum agent_op): Fix common/ includes.
11633 * ax-general.c (struct aop_map): Fix common/ includes.
11634 * ax-gdb.c: Fix common/ includes.
11635 * auxv.c: Fix common/ includes.
11636 * auto-load.c: Fix common/ includes.
11637 * arm-tdep.c: Fix common/ includes.
11638 * arch/riscv.c: Fix common/ includes.
11639 * arch/ppc-linux-common.c: Fix common/ includes.
11640 * arch/i386.c: Fix common/ includes.
11641 * arch/arm.c: Fix common/ includes.
11642 * arch/arm-linux.c: Fix common/ includes.
11643 * arch/arm-get-next-pcs.c: Fix common/ includes.
11644 * arch/amd64.c: Fix common/ includes.
11645 * arch/aarch64.c: Fix common/ includes.
11646 * arch/aarch64-insn.c: Fix common/ includes.
11647 * arch-utils.c: Fix common/ includes.
11648 * amd64-windows-tdep.c: Fix common/ includes.
11649 * amd64-tdep.c: Fix common/ includes.
11650 * amd64-sol2-tdep.c: Fix common/ includes.
11651 * amd64-obsd-tdep.c: Fix common/ includes.
11652 * amd64-nbsd-tdep.c: Fix common/ includes.
11653 * amd64-linux-tdep.c: Fix common/ includes.
11654 * amd64-linux-nat.c: Fix common/ includes.
11655 * amd64-fbsd-tdep.c: Fix common/ includes.
11656 * amd64-fbsd-nat.c: Fix common/ includes.
11657 * amd64-dicos-tdep.c: Fix common/ includes.
11658 * amd64-darwin-tdep.c: Fix common/ includes.
11659 * agent.c: Fix common/ includes.
11660 * ada-lang.h: Fix common/ includes.
11661 * ada-lang.c: Fix common/ includes.
11662 * aarch64-tdep.c: Fix common/ includes.
11664 2019-01-25 Tom Tromey <tom@tromey.com>
11666 * common/create-version.sh: Use common/version.h.
11668 2019-01-24 Pedro Alves <palves@redhat.com>
11670 * infrun.c (signal_stop, signal_print, signal_program)
11671 (signal_catch, signal_pass): Now arrays instead of pointers.
11672 (update_signals_program_target, do_target_resume)
11673 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11674 * linux-nat.c (linux_nat_target::pass_signals)
11675 (linux_nat_target::create_inferior, linux_nat_target::attach):
11677 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11678 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11679 * procfs.c (procfs_target::pass_signals): Adjust.
11680 * record-full.c (record_full_target::resume): Adjust.
11681 * remote.c (remote_target::pass_signals)
11682 (remote_target::program_signals): Adjust.
11683 * target-debug.h (target_debug_print_signals): Now takes a
11684 gdb::array_view as parameter. Adjust.
11685 * target.h (target_ops) <pass_signals, program_signals>: Replace
11686 pointer and length parameters with gdb::array_view.
11687 (target_pass_signals, target_program_signals): Likewise.
11688 * target-delegates.c: Regenerate.
11690 2019-01-24 Pedro Alves <palves@redhat.com>
11692 * common/forward-scope-exit.h
11693 (forward_scope_exit::forward_scope_exit): Pass arguments to
11694 m_bind_function directly, instead of creating a std::bind and
11697 2019-01-24 Alan Hayward <alan.hayward@arm.com>
11699 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11700 for static members.
11701 (pass_in_v_vfp_candidate): Likewise.
11703 2019-01-23 Tom Tromey <tom@tromey.com>
11704 Pedro Alves <palves@redhat.com>
11706 * regcache.c (class regcache_invalidator): Remove.
11707 (regcache::raw_write): Use make_scope_exit.
11709 2019-01-23 Tom Tromey <tom@tromey.com>
11711 * ui-out.h (class ui_out_emit_type): Update comment.
11713 2019-01-23 Tom Tromey <tom@tromey.com>
11715 * infrun.c (fetch_inferior_event): Update comment.
11717 2019-01-23 Tom Tromey <tom@tromey.com>
11718 Pedro Alves <palves@redhat.com>
11720 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11722 (fetch_inferior_event): Use SCOPE_EXIT.
11725 2019-01-23 Tom Tromey <tom@tromey.com>
11726 Pedro Alves <palves@redhat.com>
11728 * infrun.c (disable_thread_events): Delete.
11729 (stop_all_threads): Use SCOPE_EXIT.
11731 2019-01-23 Tom Tromey <tom@tromey.com>
11732 Pedro Alves <palves@redhat.com>
11734 * symfile.c: Include forward-scope-exit.h.
11735 (clear_symtab_users_cleanup): Replace forward declaration with
11736 a FORWARD_SCOPE_EXIT.
11737 (syms_from_objfile_1): Use the forward_scope_exit and
11738 gdb::optional instead of cleanup_function.
11739 (reread_symbols): Use the forward_scope_exit instead of
11741 (clear_symtab_users_cleanup): Remove function.
11743 2019-01-23 Tom Tromey <tom@tromey.com>
11744 Pedro Alves <palves@redhat.com>
11746 * linux-nat.c: Include scope-exit.h.
11747 (cleanup_target_stop): Remove.
11748 (linux_nat_target::static_tracepoint_markers_by_strid): Use
11751 2019-01-23 Tom Tromey <tom@tromey.com>
11752 Pedro Alves <palves@redhat.com>
11754 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11755 (call_function_by_hand_dummy): Use SCOPE_EXIT.
11757 2019-01-23 Tom Tromey <tom@tromey.com>
11758 Andrew Burgess <andrew.burgess@embecosm.com>
11759 Pedro Alves <palves@redhat.com>
11761 * infrun.c (fetch_inferior_event): Use scope_exit.
11762 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11763 * top.c (execute_command): Use scope_exit.
11764 * breakpoint.c (bpstat_do_actions): Use scope_exit.
11765 * utils.c (do_bpstat_clear_actions_cleanup)
11766 (make_bpstat_clear_actions_cleanup): Remove.
11768 2019-01-23 Tom Tromey <tom@tromey.com>
11769 Pedro Alves <palves@redhat.com>
11771 * infrun.c: Include "common/scope-exit.h"
11772 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11773 (wait_for_inferior): Use SCOPE_EXIT.
11774 (fetch_inferior_event): Use scope_exit.
11776 2019-01-23 Tom Tromey <tom@tromey.com>
11777 Pedro Alves <palves@redhat.com>
11779 * breakpoint.c (create_breakpoint): Remove cleanup.
11781 2019-01-23 Tom Tromey <tom@tromey.com>
11782 Andrew Burgess <andrew.burgess@embecosm.com>
11783 Pedro Alves <palves@redhat.com>
11785 2019-01-23 Pedro Alves <palves@redhat.com>
11787 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11789 2019-01-23 Pedro Alves <palves@redhat.com>
11790 Andrew Burgess <andrew.burgess@embecosm.com>
11792 * gdbthread.h: Include "common/forward-scope-exit.h".
11793 (scoped_finish_thread_state): Redefine custom class in terms of
11794 forward_scope_exit.
11796 2019-01-23 Pedro Alves <palves@redhat.com>
11797 Andrew Burgess <andrew.burgess@embecosm.com>
11799 * common/forward-scope-exit.h: New file.
11801 2019-01-23 Pedro Alves <palves@redhat.com>
11802 Andrew Burgess <andrew.burgess@embecosm.com>
11803 Tom Tromey <tom@tromey.com>
11805 * common/scope-exit.h: New file.
11807 2019-01-23 Pedro Alves <palves@redhat.com>
11809 * common/preprocessor.h (ESC): Rename to ...
11810 (ESC_PARENS): ... this.
11811 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11812 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11814 2019-01-23 Tom Tromey <tom@tromey.com>
11816 * language.h (class scoped_switch_to_sym_language_if_auto):
11817 Initialize m_lang in both cases.
11819 2019-01-23 Alan Hayward <alan.hayward@arm.com>
11821 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11824 2019-01-22 Tom Tromey <tom@tromey.com>
11826 * corelow.c: Do not include sys/file.h.
11828 2019-01-22 Tom Tromey <tom@tromey.com>
11830 * tui/tui-wingeneral.h: Include gdb_curses.h.
11832 2019-01-22 Tom Tromey <tom@tromey.com>
11834 * source-cache.h (class source_cache) <get_source_lines,
11835 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11837 2019-01-22 Tom Tromey <tom@tromey.com>
11839 * remote-fileio.h (struct remote_target): Declare.
11841 2019-01-22 Tom Tromey <tom@tromey.com>
11843 * python/py-arch.c: Do not include py-ref.h.
11844 * python/py-bpevent.c: Do not include py-ref.h.
11845 * python/py-cmd.c: Do not include py-ref.h.
11846 * python/py-continueevent.c: Do not include py-ref.h.
11847 * python/py-event.h: Do not include py-ref.h.
11848 * python/py-evtregistry.c: Do not include py-ref.h.
11849 * python/py-finishbreakpoint.c: Do not include py-ref.h.
11850 * python/py-frame.c: Do not include py-ref.h.
11851 * python/py-framefilter.c: Do not include py-ref.h.
11852 * python/py-function.c: Do not include py-ref.h.
11853 * python/py-infevents.c: Do not include py-ref.h.
11854 * python/py-linetable.c: Do not include py-ref.h.
11855 * python/py-objfile.c: Do not include py-ref.h.
11856 * python/py-param.c: Do not include py-ref.h.
11857 * python/py-prettyprint.c: Do not include py-ref.h.
11858 * python/py-progspace.c: Do not include py-ref.h.
11859 * python/py-symbol.c: Do not include py-ref.h.
11860 * python/py-symtab.c: Do not include py-ref.h.
11861 * python/py-type.c: Do not include py-ref.h.
11862 * python/py-unwind.c: Do not include py-ref.h.
11863 * python/py-utils.c: Do not include py-ref.h.
11864 * python/py-value.c: Do not include py-ref.h.
11865 * python/py-varobj.c: Do not include py-ref.h.
11866 * python/py-xmethods.c: Do not include py-ref.h.
11867 * python/python.c: Do not include py-ref.h.
11868 * varobj.c: Do not include py-ref.h.
11870 2019-01-22 Tom Tromey <tom@tromey.com>
11872 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11873 keyword for bcache.
11875 2019-01-22 Tom Tromey <tom@tromey.com>
11877 * compile/compile-cplus-types.c: Remove a comment by #include.
11879 2019-01-22 Tom Tromey <tom@tromey.com>
11881 * compile/gcc-c-plugin.h: Include compile-internal.h.
11883 2019-01-22 Tom Tromey <tom@tromey.com>
11885 * stabsread.c (EXTERN): Do not define.
11886 (symnum, next_symbol_text_func, processing_gcc_compilation)
11887 (within_function, global_sym_chain, global_stabs)
11888 (previous_stab_code, this_object_header_files)
11889 (n_this_object_header_files)
11890 (n_allocated_this_object_header_files): Define.
11891 * stabsread.h (EXTERN): Never define. Use "extern".
11893 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11895 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11898 2019-01-21 Tom Tromey <tom@tromey.com>
11900 * ui-out.c: Fix includes.
11901 * tui/tui-source.c: Fix includes.
11902 * target.c: Fix includes.
11903 * remote.c: Fix includes.
11904 * regcache.c: Fix includes.
11905 * python/py-block.c: Fix includes.
11906 * printcmd.c: Fix includes.
11907 * or1k-tdep.c: Fix includes.
11908 * mi/mi-main.c: Fix includes.
11909 * m32r-tdep.c: Fix includes.
11910 * csky-tdep.c: Fix includes.
11911 * compile/compile-cplus-types.c: Fix includes.
11912 * cli/cli-interp.c: Fix includes.
11914 2019-01-21 Alan Hayward <alan.hayward@arm.com>
11916 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11919 2019-01-16 Tom Tromey <tom@tromey.com>
11921 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
11923 (struct objfile) <msymbols_range>: Move from top level.
11924 <msymbols>: New method.
11925 (class objfile_msymbols): Remove.
11926 * symtab.c (default_collect_symbol_completion_matches_break_on):
11928 * symmisc.c (dump_msymbols): Update.
11929 * stabsread.c (scan_file_globals): Update.
11930 * objc-lang.c (info_selectors_command, info_classes_command)
11931 (find_methods): Update.
11932 * minsyms.c (find_solib_trampoline_target): Update.
11933 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11934 * coffread.c (coff_symfile_read): Update.
11935 * ada-lang.c (ada_lookup_simple_minsym)
11936 (ada_collect_symbol_completion_matches): Update.
11938 2019-01-16 Tom Tromey <tom@tromey.com>
11940 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11941 type. Remove no-argument constructor.
11942 <iterator::operator++>: Simplify.
11944 <end>: Use minimal_symbol_count.
11946 2019-01-16 Tom Tromey <tom@tromey.com>
11948 * objfiles.h (struct objfile) <psymtabs>: New method.
11949 (class objfile_psymtabs): Remove.
11950 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11952 <range>: New method.
11953 (require_partial_symbols): Change return type.
11954 * psymtab.c (require_partial_symbols)
11955 (psym_expand_symtabs_matching): Update.
11956 * mdebugread.c (parse_partial_symbols): Update.
11957 * dbxread.c (dbx_end_psymtab): Update.
11959 2019-01-15 Tom Tromey <tom@tromey.com>
11961 * symtab.c (lookup_objfile_from_block)
11962 (lookup_symbol_in_objfile_symtabs)
11963 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11964 (find_line_symtab, info_sources_command)
11965 (default_collect_symbol_completion_matches_break_on)
11966 (make_source_files_completion_list): Update.
11967 * symmisc.c (print_objfile_statistics, dump_objfile)
11968 (maintenance_print_symbols, maintenance_info_symtabs)
11969 (maintenance_check_symtabs, maintenance_info_line_tables):
11971 * source.c (select_source_symtab)
11972 (forget_cached_source_info_for_objfile): Update.
11973 * objfiles.h (class objfile_compunits): Remove.
11974 (struct objfile) <compunits_range>: New typedef.
11975 (compunits): New method.
11976 * objfiles.c (objfile_relocate1): Update.
11977 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11978 * maint.c (count_symtabs_and_blocks): Update.
11979 * linespec.c (iterate_over_all_matching_symtabs): Update.
11980 * cp-support.c (add_symbol_overload_list_qualified): Update.
11981 * coffread.c (coff_symtab_read): Update.
11982 * ada-lang.c (add_nonlocal_symbols)
11983 (ada_collect_symbol_completion_matches)
11984 (ada_add_global_exceptions): Update.
11986 2019-01-15 Tom Tromey <tom@tromey.com>
11988 * progspace.h (program_space) <objfiles_safe_range>: New
11990 <objfiles_safe>: New method.
11991 * objfiles.h (class all_objfiles_safe): Remove.
11992 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11993 * jit.c (jit_inferior_exit_hook): Update.
11995 2019-01-17 Tom Tromey <tom@tromey.com>
11997 * progspace.h (program_space) <objfiles_range>: New typedef.
11998 <objfiles>: New method.
11999 <objfiles_head>: Rename from objfiles.
12000 (object_files): Update.
12001 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12002 * guile/scm-pretty-print.c
12003 (ppscm_find_pretty_printer_from_objfiles): Update.
12004 * guile/scm-objfile.c (gdbscm_objfiles): Update.
12005 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12007 * python/py-progspace.c (pspy_get_objfiles): Update.
12008 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12010 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12011 (objfpy_lookup_objfile_by_build_id): Update.
12012 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12013 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12015 * symtab.c (iterate_over_symtabs, matching_obj_sections)
12016 (expand_symtab_containing_pc, lookup_objfile_from_block)
12017 (lookup_static_symbol, basic_lookup_transparent_type)
12018 (find_pc_sect_compunit_symtab, find_symbol_at_address)
12019 (find_line_symtab, info_sources_command)
12020 (default_collect_symbol_completion_matches_break_on)
12021 (make_source_files_completion_list, find_main_name): Update.
12022 * symmisc.c (print_symbol_bcache_statistics)
12023 (print_objfile_statistics, maintenance_print_symbols)
12024 (maintenance_print_msymbols, maintenance_print_objfiles)
12025 (maintenance_info_symtabs, maintenance_check_symtabs)
12026 (maintenance_expand_symtabs, maintenance_info_line_tables):
12028 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12029 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12030 (map_overlay_command, unmap_overlay_command)
12031 (simple_overlay_update, expand_symtabs_matching)
12032 (map_symbol_filenames): Update.
12033 * symfile-debug.c (set_debug_symfile): Update.
12034 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12036 * source.c (select_source_symtab, forget_cached_source_info):
12038 * solib.c (solib_read_symbols): Update.
12039 * solib-spu.c (append_ocl_sos): Update.
12040 * psymtab.c (maintenance_print_psymbols)
12041 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12042 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12043 * printcmd.c (info_symbol_command): Update.
12044 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12046 * objfiles.h (class all_objfiles): Remove.
12047 * objfiles.c (have_partial_symbols, have_full_symbols)
12048 (have_minimal_symbols, qsort_cmp, update_section_map)
12049 (shared_objfile_contains_address_p)
12050 (default_iterate_over_objfiles_in_search_order): Update.
12051 * objc-lang.c (info_selectors_command, info_classes_command)
12052 (find_methods): Update.
12053 * minsyms.c (find_solib_trampoline_target): Update.
12054 * maint.c (maintenance_info_sections)
12055 (maintenance_translate_address, count_symtabs_and_blocks):
12057 * main.c (captured_main_1): Update.
12058 * linux-thread-db.c (try_thread_db_load_from_pdir)
12059 (has_libpthread): Update.
12060 * linespec.c (iterate_over_all_matching_symtabs)
12061 (search_minsyms_for_name): Update.
12062 * jit.c (jit_find_objf_with_entry_addr): Update.
12063 * hppa-tdep.c (find_unwind_entry)
12064 (hppa_lookup_stub_minimal_symbol): Update.
12065 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12067 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12068 (elf_gnu_ifunc_resolve_by_got): Update.
12069 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12070 * dwarf-index-write.c (save_gdb_index_command): Update.
12071 * cp-support.c (add_symbol_overload_list_qualified): Update.
12072 * breakpoint.c (create_overlay_event_breakpoint)
12073 (create_longjmp_master_breakpoint)
12074 (create_std_terminate_master_breakpoint)
12075 (create_exception_master_breakpoint): Update.
12076 * blockframe.c (find_pc_partial_function): Update.
12077 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12078 (ada_collect_symbol_completion_matches)
12079 (ada_add_global_exceptions): Update.
12081 2019-01-17 Tom Tromey <tom@tromey.com>
12083 * solib-target.c (lm_info_target_p): Remove typedef. Don't
12085 (solib_target_parse_libraries): Change return type.
12086 (library_list_start_segment, library_list_start_section)
12087 (library_list_end_library, library_list_start_library); Update.
12088 (solib_target_free_library_list): Remove.
12089 (solib_target_parse_libraries): Remove cleanup. Change return
12091 (solib_target_current_sos): Update.
12093 2019-01-17 Tom Tromey <tromey@bapiya>
12095 * valprint.c: Replace "the the" with "the".
12096 * symtab.c: Replace "the the" with "the".
12097 * solib.c: Replace "the the" with "the".
12098 * solib-dsbt.c: Replace "the the" with "the".
12099 * linespec.c: Replace "the the" with "the".
12100 * dwarf2loc.h: Replace "the the" with "the".
12101 * amd64-windows-tdep.c: Replace "the the" with "the".
12102 * aarch64-tdep.c: Replace "the the" with "the".
12104 2019-01-16 Keith Seitz <keiths@redhat.com>
12107 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12108 <builder>: Rename to ..
12109 <m_builder>: ... this and make private.
12110 (dwarf2_cu::get_builder): New method. Change all users of
12111 `builder' to use this method.
12112 (dwarf2_start_symtab): Move to ...
12113 (dwarf2_cu::start_symtab): ... here. Update all callers
12114 (setup_type_unit_groups): Move to ...
12115 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
12117 (dwarf2_cu::reset_builder): New method.
12118 (process_full_compunit, process_full_type_unit): Use
12119 dwarf2_cu::reset_builder.
12120 (follow_die_offset): Record the ancestor CU if it is different
12121 from the followed DIE's CU.
12122 (follow_die_sig_1): Likewise.
12124 2019-01-15 Tom Tromey <tom@tromey.com>
12126 * remote.c (class remote_state) <buf>: Now a char_vector.
12127 <buf_size>: Remove.
12128 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
12130 (remote_target::getpkt_or_notif_sane_1)
12131 (remote_target::getpkt_sane)
12132 (remote_target::getpkt_or_notif_sane): Likewise.
12133 (class remote_target) <putpkt>: New overload.
12134 (remote_target::read_frame): Change type of "buf_p". Remove
12135 sizeof_p parameter.
12136 (packet_ok): New overload.
12137 (packet_check_result): New overload.
12140 2019-01-14 Tom Tromey <tom@tromey.com>
12142 * remote-notif.c (handle_notification, remote_notif_ack)
12143 (remote_notif_parse): Make "buf" const.
12144 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12146 (remote_notif_parse, remote_notif_ack, handle_notification):
12148 * remote.c (remote_notif_stop_parse): Make "buf" const.
12149 (remote_target::remote_parse_stop_reply): Make "buf" const.
12150 (remote_notif_stop_ack): Make "buf" const.
12152 2019-01-14 Tom Tromey <tom@tromey.com>
12154 * remote.c (remote_console_output): Make parameter const.
12156 2019-01-14 Tom Tromey <tom@tromey.com>
12158 * target-debug.h (target_debug_print_signals): Constify.
12159 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12160 * procfs.c (procfs_target::pass_signals): Update.
12161 * linux-nat.c (linux_nat_target::pass_signals): Update.
12162 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12163 * target-delegates.c: Rebuild.
12164 * remote.c (remote_target::program_signals): Update.
12165 (remote_target::pass_signals): Update.
12166 * target.c (target_pass_signals): Constify argument.
12167 (target_program_signals): Likewise.
12168 * target.h (struct target_ops) <pass_signals, program_signals>:
12170 (target_pass_signals, target_program_signals): Constify argument.
12172 2019-01-14 Tom Tromey <tom@tromey.com>
12175 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12177 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
12179 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12181 * rs6000-tdep.c: Include reggroups.h.
12182 (IS_V_ALIAS_PSEUDOREG): Define.
12183 (rs6000_register_name): Return names for the "vX" aliases.
12184 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12185 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
12186 aliases. Call default_register_reggroup_p for all other
12188 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12190 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12191 Handle "vX" aliases.
12192 (v_alias_pseudo_register_collect): New function.
12193 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12194 (rs6000_gdbarch_init): Initialize "vX" aliases as
12195 pseudo-registers. Restore registration of
12196 rs6000_pseudo_register_reggroup_p with
12197 set_tdesc_pseudo_register_reggroup_p.
12199 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
12201 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12202 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12203 set_gdbarch_num_pseudo_regs.
12205 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12207 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12208 Remove arg prefixname, add do_set and do_show.
12209 Add member functions set_list and show_list.
12210 * cli/cli-style.c (class cli_style_option): Update accordingly.
12211 (style_set_list): Move to file scope.
12212 (style_show_list): Likewise.
12213 (set_style): Call help_list.
12214 (show_style): Call cmd_show_list.
12215 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12216 Update to use the new macro.
12218 2019-10-12 Joel Brobecker <brobecker@adacore.com>
12220 * ada-lang.c (_initialize_ada_language): Expand the help text
12221 for the "catch exception" command.
12223 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12225 * symtab.c (matching_obj_sections): Initialize obj,
12226 declare it closer to its usage.
12228 2019-01-10 Tom Tromey <tom@tromey.com>
12230 * thread-iter.h (inf_threads_iterator): Use next_iterator.
12231 (basic_inf_threads_range): Remove.
12232 (inf_threads_range, inf_non_exited_threads_range)
12233 (safe_inf_threads_range): Use next_adapter.
12235 2019-01-10 Keith Seitz <keiths@redhat.com>
12239 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12240 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12242 2019-01-10 Keith Seitz <keiths@redhat.com>
12246 * dictionary.c (pending_to_vector): Remove.
12247 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12248 Remove _1 suffix, replacing functions of the same name. Update
12250 (dict_create_hashed, dict_create_hashed_expandable)
12251 (dict_create_linear, dict_create_linear_expandable, dict_free)
12252 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12253 Make functions static.
12255 2019-01-10 Keith Seitz <keiths@redhat.com>
12259 * dictionary.h (struct dictionary): Replace declaration with
12261 (dict_create_hashed, dict_create_hashed_expandable)
12262 (dict_create_linear, dict_create_linear_expandable)
12263 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12264 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12265 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12266 taking multidictionary argument.
12267 [ALL_DICT_SYMBOLS]: Update for multidictionary.
12268 * block.h (struct block) <dict>: Change to multidictionary
12269 and rename `multidict'.
12270 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12271 symmisc.c: Update all dictionary references to multidictionary.
12273 2019-01-10 Keith Seitz <keiths@redhat.com>
12277 * dictionary.c: Include unordered_map.
12278 (pending_to_vector): New function.
12279 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12280 Rewrite the non-"_1" functions to take vector instead
12282 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12283 "new" _1 versions of the same name.
12284 (multidictionary): Define.
12285 (std::hash<enum language): New definition.
12286 (collate_pending_symbols_by_language, mdict_create_hashed)
12287 (mdict_create_hashed_expandable, mdict_create_linear)
12288 (mdict_create_linear_expandable, mdict_free)
12289 (find_language_dictionary, create_new_language_dictionary)
12290 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12291 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12292 (mdict_size, mdict_empty): New functions.
12293 * dictionary.h (mdict_iterator): Define.
12295 2019-01-10 Pedro Alves <palves@redhat.com>
12297 * breakpoint.c (read_uploaded_action)
12298 (create_tracepoint_from_upload): Adjust to use
12299 gdb::unique_xmalloc_ptr.
12300 * ctf.c (ctf_write_uploaded_tp):
12301 (SET_ARRAY_FIELD): Use emplace_back.
12302 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12303 * tracefile-tfile.c (tfile_write_uploaded_tp):
12304 * tracepoint.c (parse_tracepoint_definition): Adjust to use
12305 gdb::unique_xmalloc_ptr.
12306 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12307 at_string, cond_string, cmd_strings>: Replace char pointers
12308 with gdb::unique_xmalloc_ptr.
12310 2019-01-10 Pedro Alves <palves@redhat.com>
12312 * solib-target.c (library_list_start_library): Don't xstrdup name.
12314 2019-01-10 Pedro Alves <palves@redhat.com>
12316 * mdebugread.c (parse_partial_symbols): Use
12317 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12319 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12321 * linux-fork.c (scoped_switch_fork_info)
12322 <~scoped_switch_fork_info>: Fix incorrect variable name.
12324 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12326 * linux-fork.c (scoped_switch_fork_info)
12327 <scoped_switch_fork_info>: Make explicit.
12328 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12330 2019-01-10 Tom Tromey <tom@tromey.com>
12332 * objfiles.h (objfile::reset_psymtabs): Update.
12333 * objfiles.c (objfile::objfile): Update.
12334 * psymtab.h (psymtab_storage::obstack): Update.
12335 (psymtab_storage::m_obstack): Use gdb::optional.
12336 (class psymtab_storage): Update comment. Remove objfile
12338 * psymtab.c (psymtab_storage::psymtab_storage): Update.
12340 2019-01-10 Tom Tromey <tom@tromey.com>
12342 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12343 <free_psymtabs>: Now private.
12344 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12345 (allocate_psymtab): Use new method.
12347 2019-01-10 Tom Tromey <tom@tromey.com>
12349 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12350 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12351 * mdebugread.c (parse_partial_symbols): Use
12352 allocate_dependencies.
12353 * dwarf2read.c (dwarf2_create_include_psymtab): Use
12354 allocate_dependencies.
12355 (process_psymtab_comp_unit_reader)
12356 (build_type_psymtab_dependencies): Likewise.
12357 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12359 2019-01-10 Tom Tromey <tom@tromey.com>
12361 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12362 PSYMBOL_SET_LANGUAGE.
12363 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12365 2019-01-10 Tom Tromey <tom@tromey.com>
12367 * psymtab.h (psymtab_storage::obstack): New method.
12368 <m_obstack>: Rename from obstack; now private.
12369 * psymtab.c (psymtab_storage): Update.
12370 * dwarf2read.c (create_addrmap_from_index)
12371 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12374 2019-01-10 Tom Tromey <tom@tromey.com>
12376 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12377 * objfiles.h (objfile::reset_psymtabs): New method.
12379 2019-01-10 Tom Tromey <tom@tromey.com>
12381 * symmisc.c (print_symbol_bcache_statistics): Update.
12382 (print_objfile_statistics): Update.
12383 * symfile.c (reread_symbols): Update.
12384 * psymtab.h (class psymtab_storage): New.
12385 * psymtab.c (psymtab_storage): New constructor.
12386 (~psymtab_storage): New destructor.
12387 (require_partial_symbols): Update.
12388 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12389 (find_pc_sect_psymtab, find_pc_sect_psymbol)
12390 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12391 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12392 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12393 (start_psymtab_common, end_psymtab_common)
12394 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12395 (allocate_psymtab): Update.
12396 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12398 (dump_psymtab_addrmap, maintenance_print_psymbols)
12399 (maintenance_check_psymtabs): Update.
12400 (class objfile_psymtabs): Move to objfiles.h.
12401 * psympriv.h (discard_psymtab): Now inline.
12402 (psymtab_discarder::psymtab_discarder): Update.
12403 (psymtab_discarder::~psymtab_discarder): Update.
12404 (ALL_OBJFILE_PSYMTABS): Rewrite.
12405 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12406 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12408 <partial_symtabs>: New field.
12409 (class objfile_psymtabs): Move from psymtab.h. Update.
12410 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12412 (objfile::~objfile): Don't destroy psymbol_cache.
12413 * mdebugread.c (parse_partial_symbols): Update.
12414 * dwarf2read.c (create_addrmap_from_index)
12415 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12416 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12417 (add_partial_subprogram, dwarf2_ranges_read): Update.
12418 * dwarf-index-write.c (write_address_map)
12419 (write_one_signatured_type, recursively_write_psymbols)
12420 (class debug_names, class debug_names, write_psymtabs_to_index):
12423 2019-01-10 Tom Tromey <tom@tromey.com>
12425 * symtab.h (SYMBOL_SET_NAMES): Update.
12426 (symbol_set_names): Update.
12427 (MSYMBOL_SET_NAMES): Update.
12428 * symtab.c (symbol_set_names): Change argument to be an
12429 objfile_per_bfd_storage.
12430 * psymtab.c (add_psymbol_to_bcache): Update.
12431 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12433 2019-01-10 Tom Tromey <tom@tromey.com>
12435 * symtab.c (create_demangled_names_hash): Change argument to be an
12436 objfile_per_bfd_storage.
12437 (symbol_set_names): Update.
12439 2019-01-10 Tom Tromey <tom@tromey.com>
12441 * xcoffread.c (xcoff_initial_scan): Unconditionally call
12443 * psymtab.c (init_psymbol_list): Do nothing if already called.
12444 * psympriv.h (init_psymbol_list): Add comment.
12445 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12447 * dbxread.c (dbx_symfile_read): Unconditionally call
12450 2019-01-10 Tom Tromey <tom@tromey.com>
12452 * xcoffread.c (scan_xcoff_symtab): Update.
12453 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12455 * mdebugread.c (parse_partial_symbols)
12456 (handle_psymbol_enumerators): Update.
12457 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12458 * dbxread.c (read_dbx_symtab): Update.
12459 * psympriv.h (psymbol_placement): New enum.
12460 (add_psymbol_to_list): Update.
12462 2019-01-10 Tom Tromey <tom@tromey.com>
12464 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12465 static_psymbols parameters.
12466 (scan_xcoff_symtab): Update.
12467 * psymtab.c (start_psymtab_common): Remove global_psymbols and
12468 static_psymbols parameters.
12469 * psympriv.h (start_psymtab_common): Update.
12470 * mdebugread.c (parse_partial_symbols): Update.
12471 * dwarf2read.c (create_partial_symtab): Update.
12472 * dbxread.c (read_dbx_symtab): Update.
12473 (start_psymtab): Remove global_psymbols and static_psymbols
12476 2019-01-10 Tom Tromey <tom@tromey.com>
12478 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12479 * psymtab.c (allocate_psymtab): Add comment.
12480 * psympriv.h (allocate_psymtab): Add comment.
12481 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12483 * dbxread.c (dbx_end_psymtab): Remove some initializations.
12485 2019-01-10 Tom Tromey <tom@tromey.com>
12487 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12489 * mipsread.c: Include mdebugread.h.
12490 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12492 * elfread.c: Include mdebugread.h.
12494 2019-01-09 Tom Tromey <tom@tromey.com>
12496 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12497 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12498 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12499 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12500 (psym_lookup_symbol, psym_find_last_source_symtab)
12501 (psym_forget_cached_source_info, psym_print_stats)
12502 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12503 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12504 (psym_map_matching_symbols, psym_expand_symtabs_matching)
12505 (psym_find_compunit_symtab_by_address)
12506 (maintenance_print_psymbols, maintenance_info_psymtabs)
12507 (maintenance_check_psymtabs): Use ranged for.
12508 * psymtab.h (class objfile_psymtabs): New.
12509 (require_partial_symbols): Return objfile_psymtabs.
12510 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12512 2019-01-09 Tom Tromey <tom@tromey.com>
12514 * symfile.c (overlay_invalidate_all, find_pc_overlay)
12515 (find_pc_mapped_section, list_overlays_command)
12516 (map_overlay_command, unmap_overlay_command)
12517 (simple_overlay_update): Use all_objfiles.
12518 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12519 * printcmd.c (info_symbol_command): Use all_objfiles.
12520 * objfiles.h (ALL_OBJSECTIONS): Remove.
12521 * maint.c (maintenance_translate_address): Use all_objfiles.
12522 * gcore.c (gcore_create_callback): Use all_objfiles.
12523 (objfile_find_memory_regions): Likewise.
12525 2019-01-09 Tom Tromey <tom@tromey.com>
12527 * symtab.c (find_line_symtab, info_sources_command)
12528 (make_source_files_completion_list): Use objfile_compunits.
12529 * source.c (select_source_symtab): Use objfile_compunits.
12530 * objfiles.h (struct objfile): Update comment.
12531 (ALL_OBJFILES): Remove.
12532 (ALL_FILETABS): Remove.
12533 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12536 2019-01-09 Tom Tromey <tom@tromey.com>
12538 * symmisc.c (print_objfile_statistics, dump_objfile)
12539 (maintenance_print_symbols): Use compunit_filetabs.
12540 * source.c (forget_cached_source_info_for_objfile): Use
12542 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12543 (ALL_FILETABS): Use compunit_filetabs.
12544 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12545 * coffread.c (coff_symtab_read): Use compunit_filetabs.
12547 2019-01-09 Tom Tromey <tom@tromey.com>
12549 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12550 (compunit_filetabs): New.
12551 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12553 (info_sources_command, make_source_files_completion_list): Remove
12555 * symmisc.c (print_objfile_statistics, dump_objfile)
12556 (maintenance_print_symbols): Remove declaration.
12557 (maintenance_info_symtabs): Use compunit_filetabs.
12558 (maintenance_info_line_tables): Likewise.
12559 * source.c (select_source_symtab): Change local variable name.
12560 (forget_cached_source_info_for_objfile): Remove declaration.
12561 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12562 * objfiles.c (objfile_relocate1): Remove declaration.
12563 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12565 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12566 * coffread.c (coff_symtab_read): Remove declaration.
12567 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12570 2019-01-09 Tom Tromey <tom@tromey.com>
12572 * symtab.c (lookup_objfile_from_block)
12573 (find_pc_sect_compunit_symtab, search_symbols)
12574 (default_collect_symbol_completion_matches_break_on): Use
12576 * objfiles.h (ALL_COMPUNITS): Remove.
12577 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12578 * cp-support.c (add_symbol_overload_list_qualified): Use
12580 * ada-lang.c (ada_collect_symbol_completion_matches)
12581 (ada_add_global_exceptions): Use objfile_compunits.
12583 2019-01-09 Tom Tromey <tom@tromey.com>
12585 * source.c (select_source_symtab)
12586 (forget_cached_source_info_for_objfile): Remove declaration.
12587 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12589 * maint.c (count_symtabs_and_blocks): Remove declaration.
12590 * cp-support.c (add_symbol_overload_list_qualified): Remove
12592 * coffread.c (coff_symtab_read): Remove declaration.
12593 * symtab.c (lookup_symbol_in_objfile_symtabs)
12594 (basic_lookup_transparent_type_1): Use objfile_compunits.
12595 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12596 (info_sources_command, search_symbols)
12597 (default_collect_symbol_completion_matches_break_on)
12598 (make_source_files_completion_list): Remove declaration.
12599 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12600 (ada_collect_symbol_completion_matches)
12601 (ada_add_global_exceptions): Remove declaration.
12602 * linespec.c (iterate_over_all_matching_symtabs): Use
12604 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12605 (class objfile_compunits): New.
12606 (ALL_COMPUNITS): Use objfile_compunits.
12607 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12608 (maintenance_check_symtabs, maintenance_info_line_tables): Use
12610 * objfiles.c (objfile_relocate1): Use objfile_compunits.
12612 2019-01-09 Tom Tromey <tom@tromey.com>
12614 * symtab.c (search_symbols)
12615 (default_collect_symbol_completion_matches_break_on): Use
12617 * ada-lang.c (ada_lookup_simple_minsym)
12618 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12619 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12620 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12622 * coffread.c (coff_symfile_read): Use objfile_msymbols.
12623 * symmisc.c (dump_msymbols): Use objfile_msymbols.
12624 * objc-lang.c (find_methods): Use objfile_msymbols.
12625 (info_selectors_command, info_classes_command): Likewise.
12626 * stabsread.c (scan_file_globals): Use objfile_msymbols.
12627 * objfiles.h (class objfile_msymbols): New.
12628 (ALL_OBJFILE_MSYMBOLS): Remove.
12629 (ALL_MSYMBOLS): Remove.
12631 2019-01-09 Tom Tromey <tom@tromey.com>
12633 * common/next-iterator.h (next_adapter): Add Iterator template
12635 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12636 (class all_objfiles_safe): New.
12637 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12638 * objfiles.c (put_objfile_before): Update comment.
12639 (add_separate_debug_objfile): Likewise.
12640 (free_all_objfiles): Use all_objfiles_safe.
12641 (objfile_purge_solibs): Likewise.
12643 2019-01-09 Tom Tromey <tom@tromey.com>
12645 * symtab.c (iterate_over_symtabs, matching_obj_sections)
12646 (expand_symtab_containing_pc, lookup_static_symbol)
12647 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12648 (find_symbol_at_address, find_line_symtab, find_main_name): Use
12650 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12651 * breakpoint.c (create_overlay_event_breakpoint)
12652 (create_longjmp_master_breakpoint)
12653 (create_std_terminate_master_breakpoint)
12654 (create_exception_master_breakpoint): Use all_objfiles.
12655 * linux-thread-db.c (try_thread_db_load_from_pdir)
12656 (has_libpthread): Use all_objfiles.
12657 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12658 * linespec.c (iterate_over_all_matching_symtabs)
12659 (search_minsyms_for_name): Use all_objfiles.
12660 * maint.c (maintenance_info_sections): Use all_objfiles.
12661 * main.c (captured_main_1): Use all_objfiles.
12662 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12663 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12664 * guile/scm-pretty-print.c
12665 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12666 * solib-spu.c (append_ocl_sos): Use all_objfiles.
12667 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12668 (maintenance_print_msymbols): Use all_objfiles.
12669 * source.c (select_source_symtab): Use all_objfiles.
12670 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12671 * symfile.c (remove_symbol_file_command)
12672 (expand_symtabs_matching, map_symbol_filenames): Use
12674 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12676 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12677 * objc-lang.c (find_methods): Use all_objfiles.
12678 * objfiles.c (have_partial_symbols, have_full_symbols)
12679 (have_minimal_symbols, qsort_cmp)
12680 (default_iterate_over_objfiles_in_search_order): Use
12682 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12683 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12684 (maintenance_check_psymtabs): Use all_objfiles.
12685 (ALL_PSYMTABS): Remove.
12686 * compile/compile-object-run.c (do_module_cleanup): Use
12688 * blockframe.c (find_pc_partial_function): Use all_objfiles.
12689 * cp-support.c (add_symbol_overload_list_qualified): Use
12691 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12693 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12694 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12696 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12697 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12698 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12700 * solib.c (solib_read_symbols): Use all_objfiles
12702 2019-01-09 Tom Tromey <tom@tromey.com>
12704 * probe.c (parse_probes_in_pspace): Use all_objfiles.
12705 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12707 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12708 * symmisc.c (print_symbol_bcache_statistics)
12709 (print_objfile_statistics, maintenance_print_objfiles)
12710 (maintenance_info_symtabs, maintenance_check_symtabs)
12711 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12713 * source.c (forget_cached_source_info): Use all_objfiles.
12714 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12715 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12716 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12717 * objfiles.c (update_section_map): Use all_objfiles.
12718 (shared_objfile_contains_address_p): Likewise.
12719 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12720 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12722 2019-01-09 Tom Tromey <tom@tromey.com>
12724 * common/next-iterator.h: New file.
12725 * objfiles.h (class all_objfiles): New.
12726 (struct objfile_iterator): New.
12728 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12730 * NEWS: Move the description of the changed "frame", "select-frame",
12731 and "info frame" commands to the Changed commands section.
12733 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
12735 * gdbtypes.c (check_stub_method_group): Remove handling of old
12737 * linespec.c (find_methods): Likewise.
12738 * stabsread.c (read_member_functions): Likewise.
12739 * valops.c (search_struct_method): Likewise.
12740 (value_struct_elt_for_reference): Likewise.
12741 * NEWS: Mention this change.
12743 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
12745 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12746 print_source_lines.
12747 * source.c (print_source_lines_base): Update line number check.
12748 (print_source_lines): New function.
12749 (source_lines_range::source_lines_range): New function.
12750 * source.h (class source_lines_range): New class.
12751 (print_source_lines): New declaration.
12753 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12755 * linespec.c (linespec_state_destructor): Free self->canonical_names.
12757 2019-01-08 Tom Tromey <tom@tromey.com>
12758 Simon Marchi <simon.marchi@ericsson.com>
12761 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12762 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12763 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12764 * f-exp.y (DOLLAR_VARIABLE): Likewise.
12765 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12766 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12768 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12770 * source.c (select_source_symtab): Move header comment to
12771 declaration in source.h.
12772 (forget_cached_source_info_for_objfile): Likewise.
12773 (forget_cached_source_info): Likewise.
12774 (identify_source_line): Likewise.
12775 * source.h (identify_source_line): Move declaration from symtab.h
12776 and add comment from source.c
12777 (print_source_lines): Likewise.
12778 (forget_cached_source_info_for_objfile): Likewise.
12779 (forget_cached_source_info): Likewise.
12780 (select_source_symtab): Likewise.
12781 (enum print_source_lines_flag): Move definition from symtab.h.
12782 * symtab.h (identify_source_line): Move declaration to source.h.
12783 (print_source_lines): Likewise.
12784 (forget_cached_source_info_for_objfile): Likewise.
12785 (forget_cached_source_info): Likewise.
12786 (select_source_symtab): Likewise.
12787 (enum print_source_lines_flag): Move definition to source.h.
12788 * tui/tui-hooks.c: Add 'source.h' include.
12790 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12792 * source.c (print_source_lines_base): Handle requests to print
12793 reverse line number sequences, and guard against empty lines
12796 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12798 * source.c (print_source_lines_base): Fix skip of '\r' if next
12801 2019-01-06 Tom Tromey <tom@tromey.com>
12803 * c-exp.y (struct c_parse_state) <macro_original_text,
12804 expansion_obstack>: New member.
12805 (macro_original_text, expansion_obstack): Remove globals.
12806 (scan_macro_expansion, scanning_macro_expansion)
12807 (finished_macro_expansion): Update.
12808 (scan_macro_cleanup): Remove.
12809 (yylex, c_parse): Update.
12811 2019-01-06 Tom Tromey <tom@tromey.com>
12813 * c-exp.y (struct c_parse_state) <strings>: New member.
12814 (operator_stoken): Update.
12816 2019-01-06 Tom Tromey <tom@tromey.com>
12818 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
12819 (union type_stack_elt) <typelist_val>: Now a pointer to
12821 (type_stack_cleanup): Don't declare.
12822 (push_typelist): Update.
12823 * parse.c (pop_typelist): Return a std::vector.
12824 (push_typelist): Take a std::vector.
12825 (follow_types): Update. Do not free args.
12826 (type_stack_cleanup): Remove.
12827 * c-exp.y (struct c_parse_state): New.
12828 (cpstate): New global.
12829 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12830 (nonempty_typelist): Update.
12831 (func_mod): Create a new vector.
12832 (c_parse): Create a c_parse_state.
12833 (check_parameter_typelist): Do not delete params.
12834 (function_method): Update. Do not delete type_list.
12836 2019-01-06 Tom Tromey <tom@tromey.com>
12839 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12841 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12842 (print_return_value): Likewise.
12844 2019-01-05 Tom Tromey <tom@tromey.com>
12846 * contrib/cleanup_check.py: Remove.
12847 * contrib/gcc-with-excheck: Remove.
12848 * contrib/exsummary.py: Remove.
12849 * contrib/excheck.py: Remove.
12851 2019-01-05 Joel Brobecker <brobecker@adacore.com>
12853 * thread.c (delete_thread_1): Add gdb_assert that THR is not
12854 NULL. Initialize tpprev to NULL instead of assigning it
12855 to NULL on the next statement.
12856 * windows-nat.c (windows_delete_thread): Remove check for
12857 main_thread_id before printing thread exit notifications.
12858 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12859 Remove thread ID check against main_thread_id.
12860 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12861 windows_delete_thread.
12862 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12864 2019-01-04 Tom Tromey <tom@tromey.com>
12866 * compile/compile.c (_initialize_compile): Use upper case for
12867 metasyntactic variables.
12868 * symmisc.c (_initialize_symmisc): Use upper case for
12869 metasyntactic variables.
12870 * psymtab.c (_initialize_psymtab): Use upper case for
12871 metasyntactic variables.
12872 * demangle.c (demangle_command): Use upper case for metasyntactic
12874 (_initialize_demangler): Likewise.
12875 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12878 2019-01-03 Tom Tromey <tom@tromey.com>
12880 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12882 2019-01-03 Tom Tromey <tom@tromey.com>
12884 * python/py-symtab.c (salpy_str): Update.
12885 (struct salpy_sal_object) <symtab>: Now a PyObject.
12886 (salpy_dealloc): Update.
12887 (del_objfile_sal): Use gdbpy_ref.
12889 2019-01-03 Tom Tromey <tom@tromey.com>
12891 * python/py-type.c (convert_field): Use new_reference. Return
12893 (make_fielditem): Return gdbpy_ref.
12894 (typy_fields): Update.
12895 (typy_getitem): Update.
12896 (field_name): Return gdbpy_ref. Use new_reference.
12897 (typy_iterator_iternext): Update.
12899 2019-01-03 Tom Tromey <tom@tromey.com>
12901 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12903 2019-01-03 Tom Tromey <tom@tromey.com>
12905 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12906 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12907 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12908 (pspy_set_frame_filters, pspy_set_frame_unwinders)
12909 (pspy_set_type_printers): Likewise.
12910 * python/py-function.c (fnpy_init): Use gdbpy_ref.
12911 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12912 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12913 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12914 (objfpy_set_type_printers): Likewise.
12916 2019-01-03 Tom Tromey <tom@tromey.com>
12918 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12919 (gdbpy_print_stack): Use gdbpy_err_fetch.
12920 * python/python-internal.h (class gdbpy_err_fetch): New class.
12921 (class gdbpy_enter) <m_error_type, m_error_value,
12922 m_error_traceback>: Remove.
12923 <m_error>: New member.
12924 (gdbpy_exception_to_string): Don't declare.
12925 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12926 * python/py-value.c (convert_value_from_python): Use
12928 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12929 gdbpy_exception_to_string.
12930 (gdbpy_handle_exception): Use gdbpy_err_fetch.
12931 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12934 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12936 * linux-nat.c (delete_lwp_cleanup): Delete.
12937 (struct lwp_deleter): New struct.
12938 (lwp_info_up): New typedef.
12939 (linux_nat_target::follow_fork): Delete cleanup, and make use of
12942 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12944 * linux-fork.c (class scoped_switch_fork_info): New class.
12945 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12947 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12949 * valops.c (find_overload_match): Remove use of null_cleanup, and
12950 calls to do_cleanups.
12952 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12954 * compile/compile-cplus-types.c
12955 (compile_cplus_instance::decl_name): Handle changes to
12957 * cp-support.c (cp_func_name): Update header comment, update
12959 * cp-support.h (cp_func_name): Update return type in declaration.
12960 * valops.c (find_overload_match): Move temp_func local to top
12961 level of function and change its type. Use temp_func to hold and
12962 delete temporary string obtained from cp_func_name.
12964 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12966 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12967 gdb::char_vector, remove cleanup, and update uses of `msg`.
12969 2019-01-03 Jim Wilson <jimw@sifive.com>
12971 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12973 2019-01-02 Tom Tromey <tom@tromey.com>
12975 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12976 (tdesc_parse_xml): Remove cleanups.
12977 * target-descriptions.h (make_cleanup_free_target_description):
12979 (target_desc_deleter): New struct.
12980 (target_desc_up): New typedef.
12981 * target-descriptions.c (target_desc_deleter::operator()): Rename
12982 from free_target_description.
12983 (make_cleanup_free_target_description): Remove.
12985 2019-01-02 Tom Tromey <tom@tromey.com>
12987 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
12988 constructor, destructor.
12989 (linespec_parser): Remove typedef.
12990 (~linespec_parser): Rename from linespec_parser_delete.
12991 (linespec_lex_to_end, linespec_complete_label)
12992 (linespec_complete): Update.
12993 (decode_line_full): Remove cleanups.
12994 (decode_line_1): Update.
12996 2019-01-02 Tom Tromey <tom@tromey.com>
12998 * python/python-internal.h (inferior_to_inferior_object): Change
13000 * python/py-exitedevent.c (create_exited_event_object): Update.
13001 * python/py-inferior.c (inferior_to_inferior_object): Return
13003 (python_new_inferior, python_inferior_deleted)
13004 (thread_to_thread_object, delete_thread_object)
13005 (build_inferior_list, gdbpy_selected_inferior): Update.
13006 * python/py-infthread.c (create_thread_object): Update. Also fail
13007 if inferior_to_inferior_object fails.
13009 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
13011 * inferior.h (class inferior) <displaced_step_state>: New field.
13012 * infrun.h (struct displaced_step_state): Move here from
13013 infrun.c. Initialize fields, add constructor.
13014 <inf>: Remove field.
13015 <reset>: New method.
13016 * infrun.c (struct displaced_step_inferior_state): Move to
13018 (displaced_step_inferior_states): Remove.
13019 (get_displaced_stepping_state): Adust.
13020 (displaced_step_in_progress_any_inferior): Adjust.
13021 (displaced_step_in_progress_thread): Adjust.
13022 (displaced_step_in_progress): Adjust.
13023 (add_displaced_stepping_state): Remove.
13024 (get_displaced_step_closure_by_addr): Adjust.
13025 (remove_displaced_stepping_state): Remove.
13026 (infrun_inferior_exit): Call displaced_step_state.reset.
13027 (use_displaced_stepping): Don't check for NULL.
13028 (displaced_step_prepare_throw): Call
13029 get_displaced_stepping_state.
13030 (displaced_step_fixup): Don't check for NULL.
13031 (prepare_for_detach): Don't check for NULL.
13033 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13035 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13036 in case of call that did not complete.
13038 2019-01-02 Andrey Utkin <autkin@undo.io>
13040 * symfile.c (find_separate_debug_file): Fix search of debug files for
13043 2019-01-02 Tom Tromey <tom@tromey.com>
13045 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13047 * python/py-frame.c (frapy_older): Remove cast.
13048 (frapy_newer): Likewise.
13049 * python/py-breakpoint.c (local_setattro): Remove cast.
13050 * python/py-arch.c (archpy_name): Remove local variable.
13051 * python/py-type.c (gdbpy_lookup_type): Remove cast.
13053 2019-01-02 Joel Brobecker <brobecker@adacore.com>
13055 * unittests/basic_string_view/element_access/char/empty.cc:
13056 Fix year range in copyright header.
13058 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
13060 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13062 <operator==>: Update with for removed field.
13064 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13065 <isa_features>: ...this.
13066 <abi_features>: New field.
13067 (riscv_isa_flen): Update comment.
13068 (riscv_abi_xlen): New declaration.
13069 (riscv_abi_flen): New declaration.
13070 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13072 (riscv_abi_xlen): New function.
13073 (riscv_isa_flen): Update to get answer from isa_features.
13074 (riscv_abi_flen): New function.
13075 (riscv_has_fp_abi): Update to get answer from abi_features.
13076 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13078 (riscv_call_info) <xlen, flen>: Update comment.
13079 (riscv_call_arg_struct): Remove invalid assertions
13080 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13082 (riscv_gdbarch_init): Gather isa features and abi features
13083 separately, ensure both match on the gdbarch when reusing an old
13084 gdbarch. Relax an error check to allow 32-bit abi float to run on
13085 a target with 64-bit float hardware.
13087 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13089 * source.c (search_command_helper): Stop reverse search
13090 when line 1 has been searched.
13092 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13094 * record-full.c (record_full_base_target::close): Rewrite
13095 record_full_core_buf_list free logic.
13097 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13099 * break-catch-syscall.c (print_one_catch_syscall): xfree
13102 2019-01-01 Joel Brobecker <brobecker@adacore.com>
13104 * top.c (print_gdb_version): Update Copyright year in version
13107 2019-01-01 Joel Brobecker <brobecker@adacore.com>
13109 Update copyright year range in all GDB files.
13111 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
13113 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13115 For older changes see ChangeLog-2018.
13121 version-control: never