gdb/ChangeLog

   1 2019-03-17  Sergei Trofimovich <siarheit@google.com>
   2
   3         * unittests/string_view-selftests.c: Define
   4         _initialize_string_view_selftests unconditionally.
   5
   6 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
   7
   8         PR gdb/24350
   9         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
  10
  11 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
  12
  13         PR gdb/24351
  14         * windows-nat.c (display_selector): Fix format specifiers.
  15
  16 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
  17
  18         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
  19         tui_refill_source_window instead of tui_refresh_win, to update the
  20         current execution line.  This fixes redisplay of the current line
  21         when stepping through the code with "next" or "step".
  22
  23 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  24
  25         * source-cache.c (source_cache::get_source_lines): Call
  26         find_source_lines to initialize s->nlines.  This fixes vertical
  27         scrolling of TUI source window when the DOWN arrow is pressed.
  28
  29 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  30
  31         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
  32         linux-thread-db.c (_initialize_thread_db): Likewise.
  33
  34 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  35
  36         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
  37         wclrtoeol in tui_show_source_line".  This reverts changes made in
  38         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
  39
  40 2019-03-15  Tom Tromey  <tom@tromey.com>
  41
  42         * symtab.h (struct minimal_symbol): Derive from
  43         general_symbol_info.
  44         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
  45         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
  46         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
  47         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
  48         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
  49         (MSYMBOL_SEARCH_NAME): Update.
  50         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
  51         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
  52         * minsyms.c (minimal_symbol_reader::record_full): Update.
  53
  54 2019-03-15  Tom Tromey  <tom@tromey.com>
  55
  56         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
  57
  58 2019-03-15  Tom Tromey  <tom@tromey.com>
  59
  60         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
  61         unique_xmalloc_ptr.
  62         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
  63         Update.
  64         * minsyms.c (lookup_minimal_symbol_by_pc_section)
  65         (build_minimal_symbol_hash_tables)
  66         (minimal_symbol_reader::install): Update.
  67
  68 2019-03-15  Tom Tromey  <tom@tromey.com>
  69
  70         * symtab.c (create_demangled_names_hash): Update.
  71         (symbol_set_names): Update.
  72         * objfiles.h (struct objfile_per_bfd_storage)
  73         <demangled_names_hash>: Now an htab_up.
  74         * objfiles.c (objfile_per_bfd_storage): Simplify.
  75
  76 2019-03-15  Tom Tromey  <tom@tromey.com>
  77
  78         * objfiles.h (struct objfile_per_bfd_storage): Declare
  79         destructor.
  80         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
  81         New.
  82         (get_objfile_bfd_data): Use new.  Don't initialize
  83         language_of_main.
  84         (free_objfile_per_bfd_storage): Remove.
  85         (objfile_bfd_data_free, objfile::~objfile): Use delete.
  86
  87 2019-03-15  Tom Tromey  <tom@tromey.com>
  88
  89         * symfile.c (reread_symbols): Update.
  90         * objfiles.c (objfile::objfile): Update.
  91         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
  92         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
  93         comment.
  94         (minimal_symbol_reader::install): Update.
  95         (terminate_minimal_symbol_table): Remove.
  96         * jit.c (jit_object_close_impl): Update.
  97
  98 2019-03-15  Tom Tromey  <tom@tromey.com>
  99
 100         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 101         initializations.
 102
 103 2019-03-15  Tom Tromey  <tom@tromey.com>
 104
 105         * objfiles.h (struct objfile_per_bfd_storage)
 106         <demangled_hash_languages>: Now a bitset.
 107         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 108         (lookup_minimal_symbol): Update.
 109
 110 2019-03-15  Tom Tromey  <tom@tromey.com>
 111
 112         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 113         Don't return the symbol.
 114         * coffread.c (record_minimal_symbol): Use record_full.
 115
 116 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 117
 118         The MS-Windows port of ncurses fails to switch to a color pair if
 119         one or both of the colors are the implicit default colors.  This
 120         change records the default colors when TUI is initialized, and
 121         then specifies them explicitly when a color pair uses the default
 122         colors.  This allows color styling in TUI mode on MS-Windows.
 123
 124         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 125         ncurses_norm_attr.
 126         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 127         colors in ncurses_norm_attr.
 128         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 129         "none", replace it with the default color recorded in
 130         ncurses_norm_attr.
 131
 132 2019-03-14  Tom Tromey  <tromey@adacore.com>
 133
 134         * source-cache.h (class source_cache) <get_source_lines>: Return
 135         std::string.
 136         * source-cache.c (source_cache::extract_lines): Handle case where
 137         first_pos==npos.  Return std::string.
 138         (source_cache::get_source_lines): Update.
 139
 140 2019-03-14  Tom Tromey  <tromey@adacore.com>
 141
 142         * NEWS: Add item for "style sources" commands.
 143         * source-cache.c (source_cache::get_source_lines): Check
 144         source_styling.
 145         * cli/cli-style.c (source_styling): New global.
 146         (_initialize_cli_style): Add "style sources" commands.
 147         (show_style_sources): New function.
 148         * cli/cli-style.h (source_styling): Declare.
 149
 150 2019-03-14  Pedro Alves  <palves@redhat.com>
 151             Tom Tromey  <tromey@adacore.com>
 152
 153         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 154         * tui/tui-winsource.c (tui_refill_source_window): New function,
 155         from...
 156         (tui_horizontal_source_scroll): ... here.  Move some logic.
 157         * cli/cli-style.c (set_style_enabled): Notify new observable.
 158         * tui/tui-hooks.c (tui_redisplay_source): New function.
 159         (tui_attach_detach_observers): Attach or detach
 160         tui_redisplay_source.
 161         * observable.h (source_styling_changed): New observable.
 162         * observable.c: Define source_styling_changed observable.
 163
 164 2019-03-13  Tom Tromey  <tromey@adacore.com>
 165
 166         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 167         (i386_gnu_nat_target::store_registers): Update.
 168         * target-debug.h (target_debug_print_std_string): New macro.
 169         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 170         * windows-tdep.c (display_one_tib): Update.
 171         * tui/tui-stack.c (tui_make_status_line): Update.
 172         * top.c (print_inferior_quit_action): Update.
 173         * thread.c (thr_try_catch_cmd): Update.
 174         (add_thread_with_info): Update.
 175         (thread_target_id_str): Update.
 176         (thr_try_catch_cmd): Update.
 177         (thread_command): Update.
 178         (thread_find_command): Update.
 179         * record-btrace.c (record_btrace_target::info_record)
 180         (record_btrace_resume_thread, record_btrace_target::resume)
 181         (record_btrace_cancel_resume, record_btrace_step_thread)
 182         (record_btrace_target::wait, record_btrace_target::wait)
 183         (record_btrace_target::wait, record_btrace_target::stop): Update.
 184         * progspace.c (print_program_space): Update.
 185         * process-stratum-target.c
 186         (process_stratum_target::thread_address_space): Update.
 187         * linux-fork.c (linux_fork_mourn_inferior)
 188         (detach_checkpoint_command, info_checkpoints_command)
 189         (linux_fork_context): Update.
 190         (linux_fork_detach): Update.
 191         (class scoped_switch_fork_info): Update.
 192         (delete_checkpoint_command): Update.
 193         * infrun.c (follow_fork_inferior): Update.
 194         (follow_fork_inferior): Update.
 195         (proceed_after_vfork_done): Update.
 196         (handle_vfork_child_exec_or_exit): Update.
 197         (follow_exec): Update.
 198         (displaced_step_prepare_throw): Update.
 199         (displaced_step_restore): Update.
 200         (start_step_over): Update.
 201         (resume_1): Update.
 202         (clear_proceed_status_thread): Update.
 203         (proceed): Update.
 204         (print_target_wait_results): Update.
 205         (do_target_wait): Update.
 206         (context_switch): Update.
 207         (stop_all_threads): Update.
 208         (restart_threads): Update.
 209         (finish_step_over): Update.
 210         (handle_signal_stop): Update.
 211         (switch_back_to_stepped_thread): Update.
 212         (keep_going_pass_signal): Update.
 213         (print_exited_reason): Update.
 214         (normal_stop): Update.
 215         * inferior.c (inferior_pid_to_str): Change return type.
 216         (print_selected_inferior): Update.
 217         (add_inferior): Update.
 218         (detach_inferior): Update.
 219         * dummy-frame.c (fprint_dummy_frames): Update.
 220         * dcache.c (dcache_info_1): Update.
 221         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 222         (btrace_fetch, btrace_clear): Update.
 223         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 224         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 225         type.
 226         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 227         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 228         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 229         * gdbarch.c, gdbarch.h: Rebuild.
 230         * gdbarch.sh (core_pid_to_str): Change return type.
 231         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 232         return type.
 233         (windows_nat_target::pid_to_str): Change return type.
 234         (windows_delete_thread): Update.
 235         (windows_nat_target::attach): Update.
 236         (windows_nat_target::files_info): Update.
 237         * target-delegates.c: Rebuild.
 238         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 239         return type.
 240         (sol_thread_target::pid_to_str): Change return type.
 241         * remote.c (class remote_target) <pid_to_str>: Change return
 242         type.
 243         (remote_target::pid_to_str): Change return type.
 244         (extended_remote_target::attach, remote_target::remote_stop_ns)
 245         (remote_target::remote_notif_remove_queued_reply)
 246         (remote_target::push_stop_reply, remote_target::disable_btrace):
 247         Update.
 248         (extended_remote_target::attach): Update.
 249         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 250         type.
 251         (gdbsim_target::pid_to_str): Change return type.
 252         * ravenscar-thread.c (struct ravenscar_thread_target)
 253         <pid_to_str>: Change return type.
 254         (ravenscar_thread_target::pid_to_str): Change return type.
 255         * procfs.c (class procfs_target) <pid_to_str>: Change return
 256         type.
 257         (procfs_target::pid_to_str): Change return type.
 258         (procfs_target::attach): Update.
 259         (procfs_target::detach): Update.
 260         (procfs_target::fetch_registers): Update.
 261         (procfs_target::store_registers): Update.
 262         (procfs_target::wait): Update.
 263         (procfs_target::files_info): Update.
 264         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 265         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 266         return type.
 267         (nto_procfs_target::pid_to_str): Change return type.
 268         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 269         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 270         return type.
 271         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 272         (exit_lwp): Update.
 273         (attach_proc_task_lwp_callback, get_detach_signal)
 274         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 275         (linux_nat_target::resume, wait_lwp, stop_callback)
 276         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 277         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 278         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 279         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 280         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 281         type.
 282         (inf_ptrace_target::attach): Update.
 283         (inf_ptrace_target::files_info): Update.
 284         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 285         type.
 286         (go32_nat_target::pid_to_str): Change return type.
 287         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 288         (gnu_nat_target::wait): Update.
 289         (gnu_nat_target::wait): Update.
 290         (gnu_nat_target::resume): Update.
 291         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 292         (fbsd_nat_target::wait): Update.
 293         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 294         type.
 295         (darwin_nat_target::attach): Update.
 296         * corelow.c (class core_target) <pid_to_str>: Change return type.
 297         (core_target::pid_to_str): Change return type.
 298         * target.c (normal_pid_to_str): Change return type.
 299         (default_pid_to_str): Likewise.
 300         (target_pid_to_str): Change return type.
 301         (target_translate_tls_address): Update.
 302         (target_announce_detach): Update.
 303         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 304         return type.
 305         (bsd_uthread_target::pid_to_str): Change return type.
 306         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 307         type.
 308         (bsd_kvm_target::pid_to_str): Change return type.
 309         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 310         return type.
 311         (aix_thread_target::pid_to_str): Change return type.
 312         * target.h (struct target_ops) <pid_to_str>: Change return type.
 313         (target_pid_to_str, normal_pid_to_str): Likewise.
 314         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 315         type.
 316         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 317         type.
 318         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 319         return type.
 320         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 321         type.
 322         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 323         type.
 324         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 325         return type.
 326
 327 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 328
 329         * NEWS: Mention that the new default MI version is 3.  Mention
 330         changes to the output of commands and events that deal with
 331         multi-location breakpoints.
 332         * breakpoint.c: Include "mi/mi-out.h".
 333         (print_one_breakpoint): Change output syntax if using MI version
 334         >= 3.
 335         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 336         New.
 337         (mi_multi_location_breakpoint_output_fixed): New.
 338         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 339         (mi_cmd_fix_multi_location_breakpoint_output): New.
 340         (mi_multi_location_breakpoint_output_fixed): New.
 341         * mi/mi-cmds.c (mi_cmds): Register command
 342         -fix-multi-location-breakpoint-output.
 343         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 344         interpreter "mi".
 345
 346 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 347
 348         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 349         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 350         instantiate mi_ui_out based on interpreter name.
 351         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 352         * mi/mi-main.c (mi_load_progress): Likewise.
 353
 354 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 355
 356         * NEWS: Combine separate "New targets" sections for 8.3.
 357
 358 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 359
 360         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 361         (ppcfbsd_init_abi): Install gdbarch
 362         "fetch_tls_load_module_address" and "get_thread_local_address"
 363         methods.
 364
 365 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 366
 367         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 368         (riscv_fbsd_init_abi): Install gdbarch
 369         "fetch_tls_load_module_address" and "get_thread_local_address"
 370         methods.
 371
 372 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 373
 374         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 375         (i386fbsd_init_abi): Install gdbarch
 376         "fetch_tls_load_module_address" and "get_thread_local_address"
 377         methods.
 378
 379 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 380
 381         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 382         (amd64fbsd_init_abi): Install gdbarch
 383         "fetch_tls_load_module_address" and "get_thread_local_address"
 384         methods.
 385
 386 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 387
 388         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 389         (struct fbsd_pspace_data): New type.
 390         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 391         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 392         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 393         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 394         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 395
 396 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 397
 398         * gdbtypes.c (lookup_struct_elt): New function.
 399         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 400         * gdbtypes.h (struct struct_elt): New type.
 401         (lookup_struct_elt): New prototype.
 402
 403 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 404
 405         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 406         remove disabled code block.
 407
 408 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 409
 410         * gdbarch.sh (get_thread_local_address): New method.
 411         * gdbarch.h, gdbarch.c: Regenerate.
 412         * target.c (target_translate_tls_address): Use
 413         gdbarch_get_thread_local_address if present instead of
 414         target::get_thread_local_address.
 415
 416 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 417
 418         * target.h (target::get_thread_local_address): Update comment.
 419
 420 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 421
 422         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 423         objfile->separate_debug_objfile_backlink if not NULL.
 424
 425 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 426
 427         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 428         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 429         (amd64bsd_store_inferior_registers): Likewise.
 430         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 431         Enable segment base registers.
 432         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 433         PT_GETFSBASE and PT_GETGSBASE.
 434         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 435         PT_SETGSBASE.
 436         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 437         segment base registers.
 438         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 439
 440 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 441
 442         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 443         Update calls to i386_target_description to add 'segments'
 444         parameter.
 445         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 446         add segment base registers.
 447         * arch/i386.c (i386_create_target_description): Add 'segments'
 448         parameter to enable segment base registers.
 449         * arch/i386.h (i386_create_target_description): Likewise.
 450         * features/i386/32bit-segments.xml: New file.
 451         * features/i386/32bit-segments.c: Generate.
 452         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 453         call to i386_target_description to add 'segments' parameter.
 454         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 455         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 456         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 457         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 458         if feature is present.
 459         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 460         Add 'segments' parameter to call to i386_target_description.
 461         (i386_target_description): Add 'segments' parameter to enable
 462         segment base registers.
 463         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 464         to call to i386_target_description.
 465         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 466         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 467         Define I386_NUM_REGS.
 468         (i386_target_description): Add 'segments' parameter to enable
 469         segment base registers.
 470
 471 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 472
 473         PR/24325
 474         * source-cache.c: #undef open and close, to avoid unresolved
 475         externals during linking.
 476
 477 2019-03-12  Tom Tromey  <tromey@adacore.com>
 478
 479         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 480         const.  Add initializers.
 481         (_initialize_remote): Don't initialize ptid globals.
 482
 483 2019-03-12  Pedro Alves  <palves@redhat.com>
 484
 485         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 486
 487 2019-03-12  Pedro Alves  <palves@redhat.com>
 488
 489         * cp-name-parser.y (main): Remove unused 'len' variable.
 490
 491 2019-03-12  Tom Tromey  <tromey@adacore.com>
 492
 493         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 494         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 495
 496 2019-03-12  Tom Tromey  <tromey@adacore.com>
 497
 498         * linux-nat.c (iterate_over_lwps): Update.
 499         (stop_callback): Remove parameter.
 500         (stop_wait_callback, detach_callback, resume_set_callback)
 501         (select_singlestep_lwp_callback, set_ignore_sigint)
 502         (status_callback, resumed_callback, resume_clear_callback)
 503         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 504         data parameter.
 505         (linux_nat_target::detach, linux_nat_target::resume)
 506         (linux_stop_and_wait_all_lwps, select_event_lwp)
 507         (linux_nat_filter_event, linux_nat_wait_1)
 508         (linux_nat_target::kill, linux_nat_target::stop)
 509         (linux_nat_target::stop): Update.
 510         (linux_nat_resume_callback): Change type.
 511         (resume_stopped_resumed_lwps, count_events_callback)
 512         (select_event_lwp_callback): Likewise.
 513         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 514         * arm-linux-nat.c (struct update_registers_data): Remove.
 515         (update_registers_callback): Change type.
 516         (arm_linux_insert_hw_breakpoint1): Update.
 517         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 518         parameter.
 519         (x86_linux_dr_set_addr): Update.
 520         (x86_linux_dr_set_control): Update.
 521         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 522         (iterate_over_lwps): Use gdb::function_view.
 523         * nat/aarch64-linux-hw-point.c (struct
 524         aarch64_dr_update_callback_param): Remove.
 525         (debug_reg_change_callback): Change type.
 526         (aarch64_notify_debug_reg_change): Update.
 527         * s390-linux-nat.c (s390_refresh_per_info): Update.
 528
 529 2019-03-11  Tom Tromey  <tromey@adacore.com>
 530
 531         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 532         redundant assignment to "this_cu".
 533
 534 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 535
 536         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 537
 538 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 539
 540         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 541         from...
 542         (rank_one_type): ... this.
 543
 544 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 545
 546         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 547         from...
 548         (rank_one_type): ... this.
 549
 550 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 551
 552         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 553         from...
 554         (rank_one_type): ... this.
 555
 556 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 557
 558         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 559         from...
 560         (rank_one_type): ... this.
 561
 562 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 563
 564         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 565         from...
 566         (rank_one_type): ... this.
 567
 568 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 569
 570         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 571         from...
 572         (rank_one_type): ... this.
 573
 574 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 575
 576         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 577         from...
 578         (rank_one_type): ... this.
 579
 580 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 581
 582         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 583         from...
 584         (rank_one_type): ... this.
 585
 586 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 587
 588         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 589         from...
 590         (rank_one_type): ... this.
 591
 592 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 593
 594         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 595         from...
 596         (rank_one_type): ... this.
 597
 598 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 599
 600         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 601         from...
 602         (rank_one_type): ... this.
 603
 604 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 605
 606         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 607         from...
 608         (rank_one_type): ... this.
 609
 610 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 611
 612         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 613         inferior-events' shows the example events.
 614
 615 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 616
 617         Support styling on native MS-Windows console
 618
 619         PR/24315
 620         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 621         on MS-Windows if $TERM is not defined.
 622
 623         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 624
 625         * posix-hdep.c (gdb_console_fputs):
 626         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 627         functions.
 628         * ui-file.h (gdb_console_fputs): Add prototype.
 629
 630         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 631         back to fputs only if the former returns zero.
 632
 633 2019-03-07  Tom Tromey  <tom@tromey.com>
 634
 635         * symmisc.c (print_symbol_bcache_statistics): Update.
 636         (print_objfile_statistics): Update.
 637         * symfile.c (allocate_symtab): Update.
 638         * stabsread.c: Don't include bcache.h.
 639         * psymtab.h (struct psymbol_bcache): Don't declare.
 640         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 641         (psymbol_bcache_init, psymbol_bcache_free)
 642         (psymbol_bcache_get_bcache): Don't declare.
 643         * psymtab.c (struct psymbol_bcache): Remove.
 644         (psymtab_storage::psymtab_storage): Update.
 645         (psymtab_storage::~psymtab_storage): Update.
 646         (psymbol_bcache_init, psymbol_bcache_free)
 647         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 648         (add_psymbol_to_bcache): Update.
 649         (allocate_psymtab): Update.
 650         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 651         macro_cache>: No longer pointers.
 652         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 653         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 654         * macrotab.c (macro_bcache): Update.
 655         * macroexp.c: Don't include bcache.h.
 656         * gdbtypes.c (check_types_worklist): Update.
 657         (types_deeply_equal): Remove TRY/CATCH.  Update.
 658         * elfread.c (elf_symtab_read): Update.
 659         * dwarf2read.c: Don't include bcache.h.
 660         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 661         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 662         (print_bcache_statistics, bcache_memory_used): Don't declare.
 663         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 664         methods.  Rename all data members.
 665         * bcache.c (struct bcache): Move to bcache.h.
 666         (bcache::expand_hash_table): Rename from expand_hash_table.
 667         (bcache): Remove.
 668         (bcache::insert): Rename from bcache_full.
 669         (bcache::compare): Rename from bcache_compare.
 670         (bcache_xmalloc): Remove.
 671         (bcache::~bcache): Rename from bcache_xfree.
 672         (bcache::print_statistics): Rename from print_bcache_statistics.
 673         (bcache::memory_used): Rename from bcache_memory_used.
 674
 675 2019-03-07  Pedro Alves  <palves@redhat.com>
 676
 677         * infrun.c (normal_stop): Also check for
 678         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 679
 680 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 681
 682         * f-lang.c (value_from_host_double): Moved to...
 683         * value.c (value_from_host_double): ...here.
 684         * value.h (value_from_host_double): Declare.
 685         * guile/scm-math.c (vlscm_convert_typed_number): Use
 686         value_from_host_double.
 687         (vlscm_convert_number): Likewise.
 688         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 689         * python/py-value.c (convert_value_from_python): Likewise.
 690
 691 2019-03-06  Tom Tromey  <tom@tromey.com>
 692
 693         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 694
 695 2019-03-06  Tom Tromey  <tom@tromey.com>
 696
 697         * utils.h (free_current_contents): Don't declare.
 698         * utils.c (free_current_contents): Remove.
 699
 700 2019-03-06  Tom Tromey  <tom@tromey.com>
 701
 702         * top.c (quit_force): Update.
 703         * main.c (captured_command_loop): Update.
 704         * common/new-op.c (operator new): Update.
 705         * common/common-exceptions.c (struct catcher)
 706         <save_cleanup_chain>: Remove member.
 707         (exceptions_state_mc_init): Update.
 708         (exception_try_scope_entry): Return nullptr.
 709         (exception_try_scope_exit, exception_rethrow)
 710         (throw_exception_sjlj, throw_exception_cxx): Update.
 711         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 712         (all_cleanups, do_cleanups, discard_cleanups)
 713         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 714         (restore_cleanups, restore_final_cleanups): Don't declare.
 715         (do_final_cleanups): Remove parameter.
 716         * common/cleanups.c (cleanup_chain, make_cleanup)
 717         (make_cleanup_dtor, all_cleanups, do_cleanups)
 718         (discard_my_cleanups, discard_cleanups)
 719         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 720         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 721         (null_cleanup): Remove.
 722         (do_final_cleanups): Remove parameter.
 723
 724 2019-03-06  Tom Tromey  <tom@tromey.com>
 725
 726         * remote.c (remote_target::remote_parse_stop_reply): Use
 727         unique_xmalloc_ptr.
 728
 729 2019-03-06  Tom Tromey  <tom@tromey.com>
 730
 731         * stabsread.c (struct stabs_field_info): Rename from field_info.
 732         <list, fnlist>: Add initializers.
 733         <obstack>: New member.
 734         (read_member_functions, read_struct_fields, read_baseclasses):
 735         Allocate on obstack.  Don't use cleanups.
 736         (read_one_struct_field, read_member_functions, read_struct_fields)
 737         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 738         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 739         (read_struct_type): Update.
 740
 741 2019-03-06  Tom Tromey  <tom@tromey.com>
 742
 743         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 744         * common/filestuff.h (make_cleanup_close): Don't declare.
 745         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 746         Remove.
 747
 748 2019-03-06  Tom Tromey  <tom@tromey.com>
 749
 750         * solib-aix.c: Use make_scope_exit.
 751
 752 2019-03-06  Tom Tromey  <tom@tromey.com>
 753
 754         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 755         Use make_scope_exit.
 756
 757 2019-03-06  Tom Tromey  <tom@tromey.com>
 758
 759         * solib-svr4.c (disable_probes_interface): Remove parameter.
 760         (svr4_handle_solib_event): Use make_scope_exit.
 761
 762 2019-03-06  Tom Tromey  <tom@tromey.com>
 763
 764         * remote.c (struct stop_reply_deleter): Remove.
 765         (stop_reply_up): Update.
 766         (struct stop_reply): Derive from notif_event.  Don't typedef.
 767         <regcache>: Now a std::vector.
 768         (stop_reply_xfree): Remove.
 769         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 770         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 771         (remote_target::discard_pending_stop_replies): Use delete.
 772         (remote_target::remote_parse_stop_reply): Update.
 773         (remote_target::process_stop_reply): Update.
 774         * remote-notif.h (struct notif_event): Add virtual destructor.
 775         Remove "dtr" member.
 776         (struct notif_client) <alloc_event>: Return a unique_ptr.
 777         (notif_event_xfree): Don't declare.
 778         (notif_event_up): New typedef.
 779         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 780         (notif_event_xfree, do_notif_event_xfree): Remove.
 781         (remote_notif_state_xfree): Update.
 782
 783 2019-03-06  Tom Tromey  <tom@tromey.com>
 784
 785         * infrun.c (displaced_step_clear_cleanup): Now a
 786         forward_scope_exit type.
 787         (displaced_step_prepare_throw): Update.
 788         (displaced_step_fixup): Update.
 789
 790 2019-03-06  Tom Tromey  <tom@tromey.com>
 791
 792         * inferior.h (class inferior): Update comment.
 793         * gdbthread.h (class thread_info): Update comment.
 794
 795 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 796             Tom Tromey  <tom@tromey.com>
 797
 798         * stabsread.h (struct stab_section_list): Remove.
 799         (coffstab_build_psymtabs): Update.
 800         * dbxread.c (symbuf_sections): Now a std::vector.
 801         (sect_idx): New global.
 802         (fill_symbuf): Update.
 803         (coffstab_build_psymtabs): Change type of stabsects parameter.
 804         Update.
 805         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 806         std::vector.
 807         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 808         (coff_locate_sections): Update.
 809         (coff_symfile_read): Remove cleanups.  Update.
 810         (init_stringtab): Add storage parameter.
 811         (free_stringtab, free_stringtab_cleanup): Remove.
 812         (init_lineno): Add storage parameter.
 813         (free_linetab, free_linetab_cleanup): Remove.
 814
 815 2019-03-06  Pedro Alves  <palves@redhat.com>
 816
 817         * linux-fork.c (fork_info::clobber_regs): Delete.
 818         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 819         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 820         comment.  Adjust.
 821         (scoped_switch_fork_info::scoped_switch_fork_info)
 822         (checkpoint_command, linux_fork_context): Adjust
 823         fork_save_infrun_state calls.
 824
 825 2019-03-06  Pedro Alves  <palves@redhat.com>
 826
 827         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 828         (inf_has_multiple_threads): Return 'bool' and rewrite using
 829         inferior_info::threads().
 830
 831 2019-03-06  Pedro Alves  <palves@redhat.com>
 832
 833         * linux-fork.c: Include <list>.
 834         (fork_list): Now a std::list instance.
 835         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 836         (forks_exist_p, find_last_fork): Adjust.
 837         (new_fork): Delete.
 838         (one_fork_p): New.
 839         (add_fork): Adjust.
 840         (free_fork): Delete, folded into fork_info::~fork_info().
 841         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 842         Adjust.
 843         (init_fork_list): Delete.
 844         (linux_fork_killall, linux_fork_mourn_inferior)
 845         (linux_fork_detach, info_checkpoints_command): Adjust.
 846         (_initialize_linux_fork): No longer call init_fork_list.
 847
 848 2019-03-06  Pedro Alves  <palves@redhat.com>
 849
 850         * linux-fork.c (new_fork): New, split out of ...
 851         (add_fork): ... this.  Return void.  Move "first fork" special
 852         case from here, to ...
 853         (checkpoint_command): ... here.
 854         * linux-linux.h (add_fork): Return void.
 855
 856 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 857
 858         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 859
 860 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 861             Chris January  <chris.january@arm.com>
 862             David Lecomber  <david.lecomber@arm.com>
 863
 864         * f-exp.y: New token, UNOP_INTRINSIC.
 865         (exp): New pattern using UNOP_INTRINSIC token.
 866         (f77_keywords): Add 'abs' keyword.
 867         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 868         (value_from_host_double): New function.
 869         (evaluate_subexp_f): Support UNOP_ABS.
 870
 871 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 872
 873         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 874         types.
 875
 876 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 877
 878         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 879         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 880         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 881
 882 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 883
 884         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 885
 886 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 887             Chris January  <chris.january@arm.com>
 888
 889         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 890         * f-exp.y: Define 'KIND' token.
 891         (exp): New pattern for KIND expressions.
 892         (ptype): Handle types with a kind extension.
 893         (direct_abs_decl): Extend to spot kind extensions.
 894         (f77_keywords): Add 'kind' to the list.
 895         (push_kind_type): New function.
 896         (convert_to_kind_type): New function.
 897         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 898         * parse.c (operator_length_standard): Likewise.
 899         * parser-defs.h (enum type_pieces): Add tp_kind.
 900         * std-operator.def: Add UNOP_KIND.
 901
 902 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 903
 904         * f-exp.y (f_parse): Set yydebug.
 905
 906 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 907
 908         * f-lang.c (evaluate_subexp_f): New function.
 909         (exp_descriptor_f): New global.
 910         (f_language_defn): Use exp_descriptor_f instead of
 911         exp_descriptor_standard.
 912
 913 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 914
 915         * f-exp.y (struct token): Add comments.
 916         (dot_ops): Remove uppercase versions and the end marker.
 917         (f77_keywords): Likewise.
 918         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 919         entries in the dot_ops array are case insensitive, and use
 920         strncasecmp to compare strings.  Also some whitespace cleanup in
 921         this area.  Similar for the f77_keywords array, except entries in
 922         this list might be case sensitive.
 923
 924 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 925
 926         * f-exp.y (struct f77_boolean_val): Add comments.
 927         (boolean_values): Remove uppercase versions, and end marker.
 928         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 929         and use strncasecmp to achieve case insensitivity.  Additionally,
 930         perform whitespace cleanup around this code.
 931
 932 2019-03-06  Tom Tromey  <tromey@adacore.com>
 933
 934         * remote-sim.c (gdbsim_target_open): Use result of
 935         gdb_argv::release.
 936
 937 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 938         Dirk Schubert  <dirk.schubert@arm.com>
 939         Chris January  <chris.january@arm.com>
 940
 941         * eval.c (evaluate_subexp_standard): Call Fortran argument
 942         wrapping logic.
 943         * f-lang.c (struct value): A value which can be passed into a
 944         Fortran function call.
 945         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 946         where appropriate.
 947         (struct type): Value ready for a Fortran function call.
 948         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 949         is needed.
 950         * f-lang.h (fortran_argument_convert): Declaration.
 951         (fortran_preserve_arg_pointer): Declaration.
 952         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 953
 954 2019-03-05  Tom Tromey  <tromey@adacore.com>
 955
 956         * python/py-prettyprint.c (print_string_repr): Remove #if.
 957         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 958
 959 2019-03-05  Tom Tromey  <tromey@adacore.com>
 960
 961         * target.c (the_dummy_target): Move later.  Change type to
 962         "dummy_target".
 963         (initialize_targets): Don't initialize the_dummy_target.
 964
 965 2019-03-05  Tom Tromey  <tromey@adacore.com>
 966
 967         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 968         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 969
 970 2019-03-05  Tom Tromey  <tromey@adacore.com>
 971
 972         * windows-nat.c (windows_nat_target::attach)
 973         (windows_nat_target::detach): Don't call gdb_flush.
 974         * valprint.c (generic_val_print, val_print, val_print_string):
 975         Don't call gdb_flush.
 976         * utils.c (defaulted_query): Don't call gdb_flush.
 977         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 978         * target.c (target_announce_detach): Don't call gdb_flush.
 979         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 980         * remote.c (extended_remote_target::attach): Don't call
 981         gdb_flush.
 982         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 983         * printcmd.c (do_examine): Don't call gdb_flush.
 984         (info_display_command): Don't call gdb_flush.
 985         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 986         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 987         * memattr.c (info_mem_command): Don't call gdb_flush.
 988         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 989         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 990         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 991         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 992         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 993         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 994         (gnu_nat_target::detach): Don't call gdb_flush.
 995         * f-valprint.c (f_val_print): Don't call gdb_flush.
 996         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 997         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 998         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 999         gdb_flush.
1000         * c-valprint.c (c_val_print): Don't call gdb_flush.
1001         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1002
1003 2019-03-05  Tom Tromey  <tromey@adacore.com>
1004
1005         * varobj.c (update_dynamic_varobj_children): Update.
1006         (install_default_visualizer): Use reset, not release.
1007         * value.c (set_internalvar): Update.
1008         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1009         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1010         ATTRIBUTE_UNUSED_RESULT.
1011
1012 2019-03-05  Tom Tromey  <tromey@adacore.com>
1013
1014         * remote.c (class scoped_remote_fd) <release>: Add
1015         ATTRIBUTE_UNUSED_RESULT.
1016
1017 2019-03-05  Tom Tromey  <tromey@adacore.com>
1018
1019         * macroexp.c (struct macro_buffer) <release>: Add
1020         ATTRIBUTE_UNUSED_RESULT.
1021
1022 2019-03-05  Tom Tromey  <tromey@adacore.com>
1023
1024         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1025         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1026         ATTRIBUTE_UNUSED_RESULT.
1027
1028 2019-03-05  Tom Tromey  <tromey@adacore.com>
1029
1030         * common/scoped_fd.h (class scoped_fd) <release>: Add
1031         ATTRIBUTE_UNUSED_RESULT.
1032
1033 2019-03-05  Tom Tromey  <tromey@adacore.com>
1034
1035         * parser-defs.h (struct parser_state) <release>: Add
1036         ATTRIBUTE_UNUSED_RESULT.
1037
1038 2019-03-05  Tom Tromey  <tromey@adacore.com>
1039
1040         * utils.h (class gdb_argv) <release>: Add
1041         ATTRIBUTE_UNUSED_RESULT.
1042         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1043
1044 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1045
1046         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1047         for-loop range, to avoid compiler warnings.
1048
1049         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1050         avoid compiler warnings about unused variables.
1051
1052         * NEWS: Mention end of support for native debugging on MS-Windows
1053         before XP.
1054
1055         PR gdb/24292
1056         * common/netstuff.c:
1057         * gdbserver/gdbreplay.c
1058         * gdbserver/remote-utils.c:
1059         * ser-tcp.c:
1060         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1061         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1062         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1063         'getaddrinfo' and 'freeaddrinfo' were not available before
1064         Windows XP, and mingw.org's MinGW headers by default define
1065         _WIN32_WINNT to 0x500.
1066
1067 2019-03-01  Gary Benson <gbenson@redhat.com>
1068
1069         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1070
1071 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1072             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1073
1074         PR gdb/8527
1075         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1076         set_sigint_trap, clear_sigint_trap.
1077
1078 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1079
1080         * target.c (target_detach): Clear the regcache and the
1081         frame cache.
1082
1083 2019-02-27  Pedro Alves  <palves@redhat.com>
1084
1085         * utils.c (set_screen_size): When we cap the height/width sizes,
1086         tweak the corresponding command variable to show "unlimited":
1087
1088 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1089             Pedro Alves  <palves@redhat.com>
1090
1091         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1092         before calling rl_set_screen_size.
1093
1094 2019-02-27  Tom Tromey  <tromey@adacore.com>
1095
1096         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1097         define.
1098         * python/py-value.c: Remove Python 2.4 workaround.
1099         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1100         workaround.
1101         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1102         Python 2.4 workaround.
1103         * python/python-internal.h: Remove Python 2.4 comment.
1104         (Py_ssize_t): Don't define.
1105         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1106         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1107         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1108         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1109         * python/python.c (do_start_initialization): Remove Python 2.4
1110         workaround.
1111         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1112         (print_children): Remove Python 2.4 workaround.
1113         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1114         workaround.
1115         (CHARBUFFERPROC_NAME): Remove.
1116         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1117         Python 2.4 workaround.
1118
1119 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1120
1121         * NEWS: Note minimum Python version.
1122
1123 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1124
1125         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1126         code from these functions.  Remove corresponding ifdefs.  Use
1127         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1128         Remove gotos and target of gotos.
1129         (infpy_search_memory): Likewise.
1130
1131 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1132
1133         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1134         (hppa_gdbarch_init): Don't register deleted functions with
1135         gdbarch.
1136
1137 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1138
1139         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1140         (h8300_unwind_sp): Delete.
1141         (h8300_dummy_id): Delete.
1142         (h8300_gdbarch_init): Don't register deleted functions with
1143         gdbarch.
1144
1145 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1146
1147         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1148         (ft32_unwind_pc): Delete.
1149         (ft32_unwind_sp): Delete.
1150         (ft32_gdbarch_init): Don't register deleted functions with
1151         gdbarch.
1152
1153 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1154
1155         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1156         (frv_unwind_pc): Delete.
1157         (frv_unwind_sp): Delete.
1158         (frv_gdbarch_init): Don't register deleted functions with
1159         gdbarch.
1160
1161 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1162
1163         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1164         (riscv_unwind_pc): Delete.
1165         (riscv_unwind_sp): Delete.
1166         (riscv_gdbarch_init): Don't register deleted functions with
1167         gdbarch.
1168
1169 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1170
1171         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1172         (csky_unwind_pc): Delete.
1173         (csky_unwind_sp): Delete.
1174         (csky_gdbarch_init): Don't register deleted functions with
1175         gdbarch.
1176
1177 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1178
1179         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1180         (cris_unwind_pc): Delete.
1181         (cris_unwind_sp): Delete.
1182         (cris_gdbarch_init): Don't register deleted functions with
1183         gdbarch.
1184
1185 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1186
1187         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1188         (bfin_unwind_pc): Delete.
1189         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1190
1191 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1192
1193         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1194         (arm_unwind_pc): Delete.
1195         (arm_unwind_sp): Delete.
1196         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1197
1198 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1199
1200         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1201         (arc_unwind_pc): Delete.
1202         (arc_unwind_sp): Delete.
1203         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1204
1205 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1206
1207         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1208         (alpha_unwind_pc): Delete.
1209         (alpha_gdbarch_init): Don't register deleted functions with
1210         gdbarch.
1211
1212 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1213
1214         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1215         (aarch64_unwind_pc): Delete.
1216         (aarch64_unwind_sp): Delete.
1217         (aarch64_gdbarch_init): Don't register deleted functions with
1218         gdbarch.
1219
1220 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1221
1222         * gdbtypes.c (type_align): Don't consider static members when
1223         computing structure alignment.
1224
1225 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1226
1227         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1228         return 0 for other types.
1229         * arch-utils.c (default_type_align): Always return 0.
1230         * gdbarch.h: Regenerate.
1231         * gdbarch.sh (type_align): Extend comment.
1232         * gdbtypes.c (type_align): Add additional comments, always call
1233         gdbarch_type_align before applying the default rules.
1234         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1235         generic code will then apply a suitable default.
1236         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1237         types, return 0 for other types.
1238
1239 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1240
1241         * NEWS: Create a new section for the next release branch.
1242         Rename the section of the current branch, now that it has
1243         been cut.
1244
1245 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1246
1247         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1248         * version.in: Bump version to 8.3.50.DATE-git.
1249
1250 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1251
1252         * aix-thread.c (ptid_cmp): Remove unused variable.
1253         (get_signaled_thread): Likewise.
1254         (store_regs_user_thread): Likewise.
1255         (store_regs_kernel_thread): Likewise.
1256         (fetch_regs_kernel_thread): Remove shadowed variable.
1257
1258 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1259
1260         * features/riscv/32bit-cpu.xml: Add register numbers.
1261         * features/riscv/32bit-fpu.c: Regenerate.
1262         * features/riscv/32bit-fpu.xml: Add register numbers.
1263         * features/riscv/64bit-cpu.xml: Add register numbers.
1264         * features/riscv/64bit-fpu.c: Regenerate.
1265         * features/riscv/64bit-fpu.xml: Add register numbers.
1266
1267 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1268
1269         * NEWS: Mention two argument form of gdb.Value constructor.
1270         * python/py-value.c (convert_buffer_and_type_to_value): New
1271         function.
1272         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1273         Add support for handling an optional second argument.  Call
1274         convert_buffer_and_type_to_value as appropriate.
1275         * python/python-internal.h (Py_buffer_deleter): New struct.
1276         (Py_buffer_up): New typedef.
1277
1278 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1279
1280         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1281         instead of releasing ownership.
1282
1283 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1284
1285         * dwarf2read.c (open_and_init_dwp_file): Call
1286         elf_numsections instead of bfd_count_sections to initialize
1287         dwp_file->num_sections.
1288
1289 2019-02-25  Tom Tromey  <tromey@adacore.com>
1290
1291         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1292
1293 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1294
1295         * gcore.in: Add '--readnever' option when invoking GDB.
1296
1297 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1298
1299         * MAINTAINERS: Update my email address.
1300
1301 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1302
1303         * build-id.c (build_id_to_debug_bfd_1): New function.
1304         (build_id_to_debug_bfd): Look for separate debug file in
1305         sysroot.
1306
1307 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1308
1309         * gdbarch.sh: Update the copyright year range that is placed into
1310         generated files.
1311
1312 2019-02-22  Keith Seitz  <keiths@redhat.com>
1313
1314         PR symtab/23853
1315         * linespec.c (create_sals_line_offset): Search for the default
1316         symtab's filename instead of its fullname.
1317
1318 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1319
1320         * NEWS: Update style defaults.
1321
1322 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1323
1324         * main.c (captured_main_1): Disable styling in batch mode.
1325
1326 2019-02-20  Tom Tromey  <tom@tromey.com>
1327
1328         * symtab.c (symtab_symbol_info): Fix typos.
1329
1330 2019-02-20  Tom Tromey  <tromey@adacore.com>
1331
1332         * findcmd.c (_initialize_mem_search): Use upper case for
1333         metasyntactic variables.
1334
1335 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1336
1337         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1338         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1339
1340 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1341
1342         * top.h (source_file_name): Change to std::string.
1343         * top.c (source_file_name): Likewise.
1344         (command_line_input): Adjust.
1345         * cli/cli-script.c (script_from_file): Adjust.
1346
1347 2019-02-19  Tom Tromey  <tromey@adacore.com>
1348
1349         * ravenscar-thread.c
1350         (ravenscar_thread_target::update_thread_list): Don't call
1351         ada_build_task_list.
1352         * ada-lang.h (ada_build_task_list): Don't declare.
1353         * ada-tasks.c (struct ada_tasks_inferior_data)
1354         <task_list_valid_p>: Now bool.
1355         (read_known_tasks, ada_task_list_changed)
1356         (ada_tasks_invalidate_inferior_data): Update.
1357         (read_known_tasks_array): Return bool.
1358         (read_known_tasks_list): Likewise.
1359         (read_known_tasks): Return void.
1360         (ada_build_task_list): Now static.
1361
1362 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1363
1364         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1365         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1366
1367 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1368
1369         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1370         variant for ada_tasks_pspace_data_handle and
1371         ada_tasks_inferior_data_handle.
1372         (ada_tasks_pspace_data_cleanup): New function.
1373         (ada_tasks_inferior_data_cleanup): New function.
1374
1375 2019-02-17  Tom Tromey  <tom@tromey.com>
1376
1377         * macrotab.h (macro_source_fullname): Return a std::string.
1378         * macrotab.c (macro_include, check_for_redefinition)
1379         (macro_undef, macro_lookup_definition, foreach_macro)
1380         (foreach_macro_in_scope): Update.
1381         (macro_source_fullname): Return a std::string.
1382         * macrocmd.c (show_pp_source_pos): Update.
1383
1384 2019-02-17  Tom Tromey  <tom@tromey.com>
1385
1386         * macrocmd.c (show_pp_source_pos): Style the file names.
1387
1388 2019-02-17  Tom Tromey  <tom@tromey.com>
1389
1390         PR tui/24197:
1391         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1392
1393 2019-02-17  Tom Tromey  <tom@tromey.com>
1394
1395         * ada-lang.c (user_select_syms): Use filtered printing.
1396         * utils.c (wrap_style): New global.
1397         (desired_style): Remove.
1398         (emit_style_escape): Add stream parameter.
1399         (set_output_style, reset_terminal_style, prompt_for_continue):
1400         Update.
1401         (flush_wrap_buffer): Only flush gdb_stdout.
1402         (wrap_here): Set wrap_style.
1403         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1404         treat escape sequences as a character.  Change when wrap buffer is
1405         flushed.
1406         (fputs_styled): Do not set the output style when the default is
1407         requested.
1408         * ui-style.h (struct ui_file_style) <is_default>: New method.
1409         * source.c (print_source_lines_base): Emit escape sequences in one
1410         piece.
1411
1412 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1413
1414         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1415         integers and enumeration types.
1416
1417 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1418
1419         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1420         instead of lookup_symbol_in_language
1421         (do_exact_match): New function.
1422         (ada_get_symbol_name_matcher): Return do_exact_match when
1423         doing a verbatim match.
1424
1425 2019-02-15  Tom Tromey  <tromey@adacore.com>
1426
1427         * ravenscar-thread.c (ravenscar_thread_target::resume)
1428         (ravenscar_thread_target::wait): Special case wildcard requests.
1429
1430 2019-02-15  Tom Tromey  <tromey@adacore.com>
1431
1432         * ravenscar-thread.c (base_ptid): Remove.
1433         (struct ravenscar_thread_target) <close>: New method.
1434         <m_base_ptid>: New member.
1435         <update_inferior_ptid, active_task, task_is_currently_active,
1436         runtime_initialized>: Declare methods.
1437         <ravenscar_thread_target>: Add constructor.
1438         (ravenscar_thread_target::task_is_currently_active)
1439         (ravenscar_thread_target::update_inferior_ptid)
1440         (ravenscar_runtime_initialized): Rename.  Now methods.
1441         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1442         (ravenscar_thread_target::update_thread_list): Update.
1443         (ravenscar_thread_target::active_task): Now method.
1444         (ravenscar_thread_target::store_registers)
1445         (ravenscar_thread_target::prepare_to_store)
1446         (ravenscar_thread_target::prepare_to_store)
1447         (ravenscar_thread_target::mourn_inferior): Update.
1448         (ravenscar_inferior_created): Use "new" to create target.
1449         (ravenscar_thread_target::get_ada_task_ptid): Update.
1450         (_initialize_ravenscar): Don't initialize base_ptid.
1451         (ravenscar_ops): Remove global.
1452
1453 2019-02-15  Tom Tromey  <tromey@adacore.com>
1454
1455         * target.h (push_target): Declare new overload.
1456         * target.c (push_target): New overload, taking an rvalue reference.
1457         * remote.c (remote_target::open_1): Use push_target overload.
1458         * corelow.c (core_target_open): Use push_target overload.
1459
1460 2019-02-15  Tom Tromey  <tromey@adacore.com>
1461
1462         * ravenscar-thread.c (is_ravenscar_task)
1463         (ravenscar_task_is_currently_active): Return bool.
1464         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1465         (_initialize_ravenscar): Remove "(void)".
1466         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1467         Return bool.
1468
1469 2019-02-15  Tom Tromey  <tromey@adacore.com>
1470
1471         * ravenscar-thread.c (ravenscar_runtime_initializer)
1472         (has_ravenscar_runtime, get_running_thread_id)
1473         (ravenscar_thread_target::resume): Fix indentation.
1474
1475 2019-02-15  Tom Tromey  <tromey@adacore.com>
1476
1477         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1478         from ravenscar_arch_ops.
1479         (sparc_ravenscar_ops::fetch_registers)
1480         (sparc_ravenscar_ops::store_registers): Now methods.
1481         (sparc_ravenscar_prepare_to_store): Remove.
1482         (sparc_ravenscar_ops): Redefine.
1483         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1484         methods and destructor.  Remove members.
1485         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1486         (ravenscar_thread_target::store_registers)
1487         (ravenscar_thread_target::prepare_to_store): Update.
1488         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1489         Remove.
1490         (struct ppc_ravenscar_powerpc_ops): Derive from
1491         ravenscar_arch_ops.
1492         (ppc_ravenscar_powerpc_ops::fetch_registers)
1493         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1494         (ppc_ravenscar_powerpc_ops): Redefine.
1495         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1496         (ppc_ravenscar_e500_ops::fetch_registers)
1497         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1498         (ppc_ravenscar_e500_ops): Redefine.
1499         * aarch64-ravenscar-thread.c
1500         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1501         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1502         (aarch64_ravenscar_fetch_registers)
1503         (aarch64_ravenscar_store_registers): Now methods.
1504         (aarch64_ravenscar_ops): Redefine.
1505
1506 2019-02-15  Tom Tromey  <tromey@adacore.com>
1507
1508         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1509         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1510         (ravenscar_thread_target::stopped_by_watchpoint)
1511         (ravenscar_thread_target::stopped_data_address)
1512         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1513
1514 2019-02-15  Tom Tromey  <tromey@adacore.com>
1515
1516         * ravenscar-thread.c: Fix some typos.
1517
1518 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1519             Tom Tromey  <tromey@adacore.com>
1520
1521         * ada-lang.c (ada_exception_sal): Change addr_string to a
1522         std::string.
1523         (create_ada_exception_catchpoint): Update.
1524
1525 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1526             Tom Tromey  <tromey@adacore.com>
1527
1528         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1529         (bp_location_ops): Remove.
1530         (base_breakpoint_allocate_location): Update.
1531         (free_bp_location): Update.
1532         * ada-lang.c (class ada_catchpoint_location)
1533         <ada_catchpoint_location>: Remove ops parameter.
1534         (ada_catchpoint_location_dtor): Remove.
1535         (ada_catchpoint_location_ops): Remove.
1536         (allocate_location_exception): Update.
1537         * breakpoint.h (struct bp_location_ops): Remove.
1538         (class bp_location) <bp_location>: Remove bp_location_ops
1539         parameter.
1540         <~bp_location>: Add destructor.
1541         <ops>: Remove.
1542
1543 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1544             Pedro Alves  <palves@redhat.com>
1545
1546         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1547         'PATH_MAX'.
1548
1549 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1550             Samuel Thibault  <samuel.thibault@gnu.org>
1551             Thomas Schwinge  <thomas@codesourcery.com>
1552
1553         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1554         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1555
1556 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1557
1558         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1559         (check_empty): Use "const char *".
1560
1561         * gnu-nat.c (gnu_nat_target::detach): Instead of
1562         'detach_inferior (pid)' call
1563         'detach_inferior (find_inferior_pid (pid))'.
1564
1565         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1566         'nat/fork-inferior.o'.
1567         * gnu-nat.c: #include "nat/fork-inferior.h".
1568
1569         * gnu-nat.c (gnu_nat_target::detach): Instead of
1570         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1571         * gnu-nat.h: #include "inf-child.h".
1572         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1573         'i386_gnu_nat_target::fetch_registers'.
1574         (gnu_store_registers): Rename/move to
1575         'i386_gnu_nat_target::store_registers'.
1576
1577         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1578         * gnu-nat.h (mach_thread_info): New function.
1579         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1580
1581         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1582
1583 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1584
1585         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1586
1587 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1588
1589         * windows-nat.c (windows_add_thread): Add new parameter
1590         "main_thread_p" with default value set to false.  Update
1591         function documentation as well as all callers.
1592         (windows_delete_thread): Likewise.
1593         (fake_create_process): Update call to windows_add_thread.
1594         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1595         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1596         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1597         call to windows_delete_thread.
1598
1599 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1600
1601         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1602
1603 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1604
1605         * symfile.c (find_separate_debug_file): Use canonical path of
1606         sysroot with child_path instead of gdb_sysroot if it is valid.
1607
1608 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1609
1610         * symfile.c (find_separate_debug_file): Use child_path to
1611         determine if an object file is under a sysroot.
1612
1613 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1614
1615         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1616         unittests/child-path-selftests.c.
1617         * common/pathstuff.c (child_path): New function.
1618         * common/pathstuff.h (child_path): New prototype.
1619         * unittests/child-path-selftests.c: New file.
1620
1621 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1622
1623         * symfile.c (find_separate_debug_file): Look for separate debug
1624         files in debug directories under the sysroot.
1625
1626 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1627
1628         * symtab.h (struct minimal_symbol data_p): New const method.
1629         (struct minimal_symbol text_p): Likewise.
1630         * symtab.c (output_source_filename): Use file name style
1631         to print file name.
1632         (print_symbol_info): Likewise.
1633         (print_msymbol_info): Use address style to print addresses.
1634         Use function name style to print executable text symbols.
1635         (expand_symtab_containing_pc): Use data_p.
1636         (find_pc_sect_compunit_symtab): Likewise.
1637
1638 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1639
1640         * breakpoint.c (describe_other_breakpoints): Use address style
1641         to print addresses.
1642         (say_where): Likewise.
1643
1644 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1645
1646         * ada-typeprint.c (print_func_type): Print function name
1647         style to print function name.
1648         * c-typeprint.c (c_print_type_1): Likewise.
1649
1650 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1651
1652         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1653         for execve.
1654
1655 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1656
1657         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1658         type_stack.
1659
1660 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1661
1662         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1663         TYPE_CODE_REF types.
1664
1665 2019-02-08  Jim Wilson  <jimw@sifive.com>
1666
1667         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1668         (riscv_linux_fregset): New.
1669         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1670
1671 2019-02-07  Tom Tromey  <tom@tromey.com>
1672
1673         * thread.c (thread_cancel_execution_command): Update.
1674         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1675         methods.
1676         (struct thread_fsm_ops): Remove.
1677         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1678         (thread_fsm_should_stop, thread_fsm_return_value)
1679         (thread_fsm_set_finished, thread_fsm_finished_p)
1680         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1681         Don't declare.
1682         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1683         * infrun.c (clear_proceed_status_thread)
1684         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1685         (print_stop_event): Update.
1686         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1687         Add constructor.
1688         (step_command_fsm_ops): Remove.
1689         (new_step_command_fsm): Remove.
1690         (step_1): Update.
1691         (step_command_fsm::should_stop): Rename from
1692         step_command_fsm_should_stop.
1693         (step_command_fsm::clean_up): Rename from
1694         step_command_fsm_clean_up.
1695         (step_command_fsm::do_async_reply_reason): Rename from
1696         step_command_fsm_async_reply_reason.
1697         (struct until_next_fsm): Inherit from thread_fsm.  Add
1698         constructor.
1699         (until_next_fsm_ops): Remove.
1700         (new_until_next_fsm): Remove.
1701         (until_next_fsm::should_stop): Rename from
1702         until_next_fsm_should_stop.
1703         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1704         (until_next_fsm::do_async_reply_reason): Rename from
1705         until_next_fsm_async_reply_reason.
1706         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1707         constructor.  Change type of breakpoint.
1708         (finish_command_fsm_ops): Remove.
1709         (new_finish_command_fsm): Remove.
1710         (finish_command_fsm::should_stop): Rename from
1711         finish_command_fsm_should_stop.
1712         (finish_command_fsm::clean_up): Rename from
1713         finish_command_fsm_clean_up.
1714         (finish_command_fsm::return_value): Rename from
1715         finish_command_fsm_return_value.
1716         (finish_command_fsm::do_async_reply_reason): Rename from
1717         finish_command_fsm_async_reply_reason.
1718         (finish_command): Update.
1719         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1720         Add constructor.
1721         (call_thread_fsm_ops): Remove.
1722         (call_thread_fsm::call_thread_fsm): Rename from
1723         new_call_thread_fsm.
1724         (call_thread_fsm::should_stop): Rename from
1725         call_thread_fsm_should_stop.
1726         (call_thread_fsm::should_notify_stop): Rename from
1727         call_thread_fsm_should_notify_stop.
1728         (run_inferior_call, call_function_by_hand_dummy): Update.
1729         * cli/cli-interp.c (should_print_stop_to_console): Update.
1730         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1731         Add constructor.  Change type of location_breakpoint,
1732         caller_breakpoint.
1733         (until_break_fsm_ops): Remove.
1734         (new_until_break_fsm): Remove.
1735         (until_break_fsm::should_stop): Rename from
1736         until_break_fsm_should_stop.
1737         (until_break_fsm::clean_up): Rename from
1738         until_break_fsm_clean_up.
1739         (until_break_fsm::do_async_reply_reason): Rename from
1740         until_break_fsm_async_reply_reason.
1741         (until_break_command): Update.
1742         * thread-fsm.c: Remove.
1743         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1744
1745 2019-02-07  Tom Tromey  <tom@tromey.com>
1746
1747         * yy-remap.h: Add include guard.
1748         * xtensa-tdep.h: Add include guard.
1749         * xcoffread.h: Rename include guard.
1750         * varobj-iter.h: Add include guard.
1751         * tui/tui.h: Rename include guard.
1752         * tui/tui-winsource.h: Rename include guard.
1753         * tui/tui-wingeneral.h: Rename include guard.
1754         * tui/tui-windata.h: Rename include guard.
1755         * tui/tui-win.h: Rename include guard.
1756         * tui/tui-stack.h: Rename include guard.
1757         * tui/tui-source.h: Rename include guard.
1758         * tui/tui-regs.h: Rename include guard.
1759         * tui/tui-out.h: Rename include guard.
1760         * tui/tui-layout.h: Rename include guard.
1761         * tui/tui-io.h: Rename include guard.
1762         * tui/tui-hooks.h: Rename include guard.
1763         * tui/tui-file.h: Rename include guard.
1764         * tui/tui-disasm.h: Rename include guard.
1765         * tui/tui-data.h: Rename include guard.
1766         * tui/tui-command.h: Rename include guard.
1767         * tic6x-tdep.h: Add include guard.
1768         * target/waitstatus.h: Rename include guard.
1769         * target/wait.h: Rename include guard.
1770         * target/target.h: Rename include guard.
1771         * target/resume.h: Rename include guard.
1772         * target-float.h: Rename include guard.
1773         * stabsread.h: Add include guard.
1774         * rs6000-tdep.h: Add include guard.
1775         * riscv-fbsd-tdep.h: Add include guard.
1776         * regformats/regdef.h: Rename include guard.
1777         * record.h: Rename include guard.
1778         * python/python.h: Rename include guard.
1779         * python/python-internal.h: Rename include guard.
1780         * python/py-stopevent.h: Rename include guard.
1781         * python/py-ref.h: Rename include guard.
1782         * python/py-record.h: Rename include guard.
1783         * python/py-record-full.h: Rename include guard.
1784         * python/py-record-btrace.h: Rename include guard.
1785         * python/py-instruction.h: Rename include guard.
1786         * python/py-events.h: Rename include guard.
1787         * python/py-event.h: Rename include guard.
1788         * procfs.h: Add include guard.
1789         * proc-utils.h: Add include guard.
1790         * p-lang.h: Add include guard.
1791         * or1k-tdep.h: Rename include guard.
1792         * observable.h: Rename include guard.
1793         * nto-tdep.h: Rename include guard.
1794         * nat/x86-linux.h: Rename include guard.
1795         * nat/x86-linux-dregs.h: Rename include guard.
1796         * nat/x86-gcc-cpuid.h: Add include guard.
1797         * nat/x86-dregs.h: Rename include guard.
1798         * nat/x86-cpuid.h: Rename include guard.
1799         * nat/ppc-linux.h: Rename include guard.
1800         * nat/mips-linux-watch.h: Rename include guard.
1801         * nat/linux-waitpid.h: Rename include guard.
1802         * nat/linux-ptrace.h: Rename include guard.
1803         * nat/linux-procfs.h: Rename include guard.
1804         * nat/linux-osdata.h: Rename include guard.
1805         * nat/linux-nat.h: Rename include guard.
1806         * nat/linux-namespaces.h: Rename include guard.
1807         * nat/linux-btrace.h: Rename include guard.
1808         * nat/glibc_thread_db.h: Rename include guard.
1809         * nat/gdb_thread_db.h: Rename include guard.
1810         * nat/gdb_ptrace.h: Rename include guard.
1811         * nat/fork-inferior.h: Rename include guard.
1812         * nat/amd64-linux-siginfo.h: Rename include guard.
1813         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1814         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1815         * nat/aarch64-linux.h: Rename include guard.
1816         * nat/aarch64-linux-hw-point.h: Rename include guard.
1817         * mn10300-tdep.h: Add include guard.
1818         * mips-linux-tdep.h: Add include guard.
1819         * mi/mi-parse.h: Rename include guard.
1820         * mi/mi-out.h: Rename include guard.
1821         * mi/mi-main.h: Rename include guard.
1822         * mi/mi-interp.h: Rename include guard.
1823         * mi/mi-getopt.h: Rename include guard.
1824         * mi/mi-console.h: Rename include guard.
1825         * mi/mi-common.h: Rename include guard.
1826         * mi/mi-cmds.h: Rename include guard.
1827         * mi/mi-cmd-break.h: Rename include guard.
1828         * m2-lang.h: Add include guard.
1829         * location.h: Rename include guard.
1830         * linux-record.h: Rename include guard.
1831         * linux-nat.h: Add include guard.
1832         * linux-fork.h: Add include guard.
1833         * i386-darwin-tdep.h: Rename include guard.
1834         * hppa-linux-offsets.h: Add include guard.
1835         * guile/guile.h: Rename include guard.
1836         * guile/guile-internal.h: Rename include guard.
1837         * gnu-nat.h: Rename include guard.
1838         * gdb-stabs.h: Rename include guard.
1839         * frv-tdep.h: Add include guard.
1840         * f-lang.h: Add include guard.
1841         * event-loop.h: Add include guard.
1842         * darwin-nat.h: Rename include guard.
1843         * cp-abi.h: Rename include guard.
1844         * config/sparc/nm-sol2.h: Rename include guard.
1845         * config/nm-nto.h: Rename include guard.
1846         * config/nm-linux.h: Add include guard.
1847         * config/i386/nm-i386gnu.h: Rename include guard.
1848         * config/djgpp/nl_types.h: Rename include guard.
1849         * config/djgpp/langinfo.h: Rename include guard.
1850         * compile/gcc-cp-plugin.h: Add include guard.
1851         * compile/gcc-c-plugin.h: Add include guard.
1852         * compile/compile.h: Rename include guard.
1853         * compile/compile-object-run.h: Rename include guard.
1854         * compile/compile-object-load.h: Rename include guard.
1855         * compile/compile-internal.h: Rename include guard.
1856         * compile/compile-cplus.h: Rename include guard.
1857         * compile/compile-c.h: Rename include guard.
1858         * common/xml-utils.h: Rename include guard.
1859         * common/x86-xstate.h: Rename include guard.
1860         * common/version.h: Rename include guard.
1861         * common/vec.h: Rename include guard.
1862         * common/tdesc.h: Rename include guard.
1863         * common/selftest.h: Rename include guard.
1864         * common/scoped_restore.h: Rename include guard.
1865         * common/scoped_mmap.h: Rename include guard.
1866         * common/scoped_fd.h: Rename include guard.
1867         * common/safe-iterator.h: Rename include guard.
1868         * common/run-time-clock.h: Rename include guard.
1869         * common/refcounted-object.h: Rename include guard.
1870         * common/queue.h: Rename include guard.
1871         * common/ptid.h: Rename include guard.
1872         * common/print-utils.h: Rename include guard.
1873         * common/preprocessor.h: Rename include guard.
1874         * common/pathstuff.h: Rename include guard.
1875         * common/observable.h: Rename include guard.
1876         * common/netstuff.h: Rename include guard.
1877         * common/job-control.h: Rename include guard.
1878         * common/host-defs.h: Rename include guard.
1879         * common/gdb_wait.h: Rename include guard.
1880         * common/gdb_vecs.h: Rename include guard.
1881         * common/gdb_unlinker.h: Rename include guard.
1882         * common/gdb_unique_ptr.h: Rename include guard.
1883         * common/gdb_tilde_expand.h: Rename include guard.
1884         * common/gdb_sys_time.h: Rename include guard.
1885         * common/gdb_string_view.h: Rename include guard.
1886         * common/gdb_splay_tree.h: Rename include guard.
1887         * common/gdb_setjmp.h: Rename include guard.
1888         * common/gdb_ref_ptr.h: Rename include guard.
1889         * common/gdb_optional.h: Rename include guard.
1890         * common/gdb_locale.h: Rename include guard.
1891         * common/gdb_assert.h: Rename include guard.
1892         * common/filtered-iterator.h: Rename include guard.
1893         * common/filestuff.h: Rename include guard.
1894         * common/fileio.h: Rename include guard.
1895         * common/environ.h: Rename include guard.
1896         * common/common-utils.h: Rename include guard.
1897         * common/common-types.h: Rename include guard.
1898         * common/common-regcache.h: Rename include guard.
1899         * common/common-inferior.h: Rename include guard.
1900         * common/common-gdbthread.h: Rename include guard.
1901         * common/common-exceptions.h: Rename include guard.
1902         * common/common-defs.h: Rename include guard.
1903         * common/common-debug.h: Rename include guard.
1904         * common/cleanups.h: Rename include guard.
1905         * common/buffer.h: Rename include guard.
1906         * common/btrace-common.h: Rename include guard.
1907         * common/break-common.h: Rename include guard.
1908         * cli/cli-utils.h: Rename include guard.
1909         * cli/cli-style.h: Rename include guard.
1910         * cli/cli-setshow.h: Rename include guard.
1911         * cli/cli-script.h: Rename include guard.
1912         * cli/cli-interp.h: Rename include guard.
1913         * cli/cli-decode.h: Rename include guard.
1914         * cli/cli-cmds.h: Rename include guard.
1915         * charset-list.h: Add include guard.
1916         * buildsym-legacy.h: Rename include guard.
1917         * bfin-tdep.h: Add include guard.
1918         * ax.h: Rename include guard.
1919         * arm-linux-tdep.h: Add include guard.
1920         * arm-fbsd-tdep.h: Add include guard.
1921         * arch/xtensa.h: Rename include guard.
1922         * arch/tic6x.h: Add include guard.
1923         * arch/i386.h: Add include guard.
1924         * arch/arm.h: Rename include guard.
1925         * arch/arm-linux.h: Rename include guard.
1926         * arch/arm-get-next-pcs.h: Rename include guard.
1927         * arch/amd64.h: Add include guard.
1928         * arch/aarch64-insn.h: Rename include guard.
1929         * arch-utils.h: Rename include guard.
1930         * annotate.h: Add include guard.
1931         * amd64-darwin-tdep.h: Rename include guard.
1932         * aarch64-linux-tdep.h: Add include guard.
1933         * aarch64-fbsd-tdep.h: Add include guard.
1934         * aarch32-linux-nat.h: Add include guard.
1935
1936 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1937
1938         * macrotab.c (macro_define_internal): New function that
1939         factorizes macro_define_object_internal and macro_define_function
1940         code.
1941         (macro_define_object_internal): Use macro_define_internal.
1942         (macro_define_function): Likewise.
1943
1944 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1945
1946         * macrocmd.c (extract_identifier): Return
1947         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1948         callers.
1949
1950 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1951
1952         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1953
1954 2019-02-05  Tom Tromey  <tom@tromey.com>
1955
1956         * target.c (target_stack::unpush): Move assertion earlier.
1957
1958 2019-01-30  Tom Tromey  <tom@tromey.com>
1959
1960         PR python/23615:
1961         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1962         (gdbpy_parse_and_eval): Likewise.
1963         * python/python-internal.h (gdbpy_allow_threads): New class.
1964
1965 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1966
1967         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1968         (aarch64_fbsd_fpregmap): Move earlier.
1969         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1970         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1971         instead of individual calls to trad_frame_set_reg_addr.
1972         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1973         earlier.
1974         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1975         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1976         instead of individual calls to trad_frame_set_reg_addr.
1977
1978 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1979
1980         * CONTRIBUTE: Replace contribution list with wiki link.
1981
1982 2019-01-25  Tom Tromey  <tom@tromey.com>
1983
1984         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1985
1986 2019-01-25  Tom Tromey  <tom@tromey.com>
1987
1988         * xtensa-linux-nat.c: Fix common/ includes.
1989         * xml-support.h: Fix common/ includes.
1990         * xml-support.c: Fix common/ includes.
1991         * x86-linux-nat.c: Fix common/ includes.
1992         * windows-nat.c: Fix common/ includes.
1993         * varobj.h: Fix common/ includes.
1994         * varobj.c: Fix common/ includes.
1995         * value.c: Fix common/ includes.
1996         * valops.c: Fix common/ includes.
1997         * utils.c: Fix common/ includes.
1998         * unittests/xml-utils-selftests.c: Fix common/ includes.
1999         * unittests/utils-selftests.c: Fix common/ includes.
2000         * unittests/unpack-selftests.c: Fix common/ includes.
2001         * unittests/tracepoint-selftests.c: Fix common/ includes.
2002         * unittests/style-selftests.c: Fix common/ includes.
2003         * unittests/string_view-selftests.c: Fix common/ includes.
2004         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2005         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2006         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2007         * unittests/rsp-low-selftests.c: Fix common/ includes.
2008         * unittests/parse-connection-spec-selftests.c: Fix common/
2009         includes.
2010         * unittests/optional-selftests.c: Fix common/ includes.
2011         * unittests/offset-type-selftests.c: Fix common/ includes.
2012         * unittests/observable-selftests.c: Fix common/ includes.
2013         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2014         * unittests/memrange-selftests.c: Fix common/ includes.
2015         * unittests/memory-map-selftests.c: Fix common/ includes.
2016         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2017         * unittests/function-view-selftests.c: Fix common/ includes.
2018         * unittests/environ-selftests.c: Fix common/ includes.
2019         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2020         * unittests/common-utils-selftests.c: Fix common/ includes.
2021         * unittests/cli-utils-selftests.c: Fix common/ includes.
2022         * unittests/array-view-selftests.c: Fix common/ includes.
2023         * ui-file.c: Fix common/ includes.
2024         * tui/tui-io.c: Fix common/ includes.
2025         * tracepoint.h: Fix common/ includes.
2026         * tracepoint.c: Fix common/ includes.
2027         * tracefile-tfile.c: Fix common/ includes.
2028         * top.h: Fix common/ includes.
2029         * top.c: Fix common/ includes.
2030         * thread.c: Fix common/ includes.
2031         * target/waitstatus.h: Fix common/ includes.
2032         * target/waitstatus.c: Fix common/ includes.
2033         * target.h: Fix common/ includes.
2034         * target.c: Fix common/ includes.
2035         * target-memory.c: Fix common/ includes.
2036         * target-descriptions.c: Fix common/ includes.
2037         * symtab.h: Fix common/ includes.
2038         * symfile.c: Fix common/ includes.
2039         * stap-probe.c: Fix common/ includes.
2040         * spu-linux-nat.c: Fix common/ includes.
2041         * sparc-nat.c: Fix common/ includes.
2042         * source.c: Fix common/ includes.
2043         * solib.c: Fix common/ includes.
2044         * solib-target.c: Fix common/ includes.
2045         * ser-unix.c: Fix common/ includes.
2046         * ser-tcp.c: Fix common/ includes.
2047         * ser-pipe.c: Fix common/ includes.
2048         * ser-base.c: Fix common/ includes.
2049         * selftest-arch.c: Fix common/ includes.
2050         * s12z-tdep.c: Fix common/ includes.
2051         * rust-exp.y: Fix common/ includes.
2052         * rs6000-aix-tdep.c: Fix common/ includes.
2053         * riscv-tdep.c: Fix common/ includes.
2054         * remote.c: Fix common/ includes.
2055         * remote-notif.h: Fix common/ includes.
2056         * remote-fileio.h: Fix common/ includes.
2057         * remote-fileio.c: Fix common/ includes.
2058         * regcache.h: Fix common/ includes.
2059         * regcache.c: Fix common/ includes.
2060         * record-btrace.c: Fix common/ includes.
2061         * python/python.c: Fix common/ includes.
2062         * python/py-type.c: Fix common/ includes.
2063         * python/py-inferior.c: Fix common/ includes.
2064         * progspace.h: Fix common/ includes.
2065         * producer.c: Fix common/ includes.
2066         * procfs.c: Fix common/ includes.
2067         * proc-api.c: Fix common/ includes.
2068         * printcmd.c: Fix common/ includes.
2069         * ppc-linux-nat.c: Fix common/ includes.
2070         * parser-defs.h: Fix common/ includes.
2071         * osdata.c: Fix common/ includes.
2072         * obsd-nat.c: Fix common/ includes.
2073         * nat/x86-linux.c: Fix common/ includes.
2074         * nat/x86-linux-dregs.c: Fix common/ includes.
2075         * nat/x86-dregs.h: Fix common/ includes.
2076         * nat/x86-dregs.c: Fix common/ includes.
2077         * nat/ppc-linux.c: Fix common/ includes.
2078         * nat/mips-linux-watch.h: Fix common/ includes.
2079         * nat/mips-linux-watch.c: Fix common/ includes.
2080         * nat/linux-waitpid.c: Fix common/ includes.
2081         * nat/linux-ptrace.h: Fix common/ includes.
2082         * nat/linux-ptrace.c: Fix common/ includes.
2083         * nat/linux-procfs.c: Fix common/ includes.
2084         * nat/linux-personality.c: Fix common/ includes.
2085         * nat/linux-osdata.c: Fix common/ includes.
2086         * nat/linux-namespaces.c: Fix common/ includes.
2087         * nat/linux-btrace.h: Fix common/ includes.
2088         * nat/linux-btrace.c: Fix common/ includes.
2089         * nat/fork-inferior.c: Fix common/ includes.
2090         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2091         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2092         * nat/aarch64-linux.c: Fix common/ includes.
2093         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2094         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2095         * namespace.h: Fix common/ includes.
2096         * mips-linux-tdep.c: Fix common/ includes.
2097         * minsyms.c: Fix common/ includes.
2098         * mi/mi-parse.h: Fix common/ includes.
2099         * mi/mi-main.c: Fix common/ includes.
2100         * mi/mi-cmd-env.c: Fix common/ includes.
2101         * memrange.h: Fix common/ includes.
2102         * memattr.c: Fix common/ includes.
2103         * maint.h: Fix common/ includes.
2104         * maint.c: Fix common/ includes.
2105         * main.c: Fix common/ includes.
2106         * machoread.c: Fix common/ includes.
2107         * location.c: Fix common/ includes.
2108         * linux-thread-db.c: Fix common/ includes.
2109         * linux-nat.c: Fix common/ includes.
2110         * linux-fork.c: Fix common/ includes.
2111         * inline-frame.c: Fix common/ includes.
2112         * infrun.c: Fix common/ includes.
2113         * inflow.c: Fix common/ includes.
2114         * inferior.h: Fix common/ includes.
2115         * inferior.c: Fix common/ includes.
2116         * infcmd.c: Fix common/ includes.
2117         * inf-ptrace.c: Fix common/ includes.
2118         * inf-child.c: Fix common/ includes.
2119         * ia64-linux-nat.c: Fix common/ includes.
2120         * i387-tdep.c: Fix common/ includes.
2121         * i386-tdep.c: Fix common/ includes.
2122         * i386-linux-tdep.c: Fix common/ includes.
2123         * i386-linux-nat.c: Fix common/ includes.
2124         * i386-go32-tdep.c: Fix common/ includes.
2125         * i386-fbsd-tdep.c: Fix common/ includes.
2126         * i386-fbsd-nat.c: Fix common/ includes.
2127         * guile/scm-type.c: Fix common/ includes.
2128         * guile/guile.c: Fix common/ includes.
2129         * go32-nat.c: Fix common/ includes.
2130         * gnu-nat.c: Fix common/ includes.
2131         * gdbthread.h: Fix common/ includes.
2132         * gdbarch-selftests.c: Fix common/ includes.
2133         * gdb_usleep.c: Fix common/ includes.
2134         * gdb_select.h: Fix common/ includes.
2135         * gdb_bfd.c: Fix common/ includes.
2136         * gcore.c: Fix common/ includes.
2137         * fork-child.c: Fix common/ includes.
2138         * findvar.c: Fix common/ includes.
2139         * fbsd-nat.c: Fix common/ includes.
2140         * event-top.c: Fix common/ includes.
2141         * event-loop.c: Fix common/ includes.
2142         * dwarf2read.c: Fix common/ includes.
2143         * dwarf2loc.c: Fix common/ includes.
2144         * dwarf2-frame.c: Fix common/ includes.
2145         * dwarf-index-cache.c: Fix common/ includes.
2146         * dtrace-probe.c: Fix common/ includes.
2147         * disasm-selftests.c: Fix common/ includes.
2148         * defs.h: Fix common/ includes.
2149         * csky-tdep.c: Fix common/ includes.
2150         * cp-valprint.c: Fix common/ includes.
2151         * cp-support.h: Fix common/ includes.
2152         * cp-support.c: Fix common/ includes.
2153         * corelow.c: Fix common/ includes.
2154         * completer.h: Fix common/ includes.
2155         * completer.c: Fix common/ includes.
2156         * compile/compile.c: Fix common/ includes.
2157         * compile/compile-loc2c.c: Fix common/ includes.
2158         * compile/compile-cplus-types.c: Fix common/ includes.
2159         * compile/compile-cplus-symbols.c: Fix common/ includes.
2160         * command.h: Fix common/ includes.
2161         * cli/cli-dump.c: Fix common/ includes.
2162         * cli/cli-cmds.c: Fix common/ includes.
2163         * charset.c: Fix common/ includes.
2164         * build-id.c: Fix common/ includes.
2165         * btrace.h: Fix common/ includes.
2166         * btrace.c: Fix common/ includes.
2167         * breakpoint.h: Fix common/ includes.
2168         * breakpoint.c: Fix common/ includes.
2169         * ax.h:
2170         (enum agent_op): Fix common/ includes.
2171         * ax-general.c (struct aop_map): Fix common/ includes.
2172         * ax-gdb.c: Fix common/ includes.
2173         * auxv.c: Fix common/ includes.
2174         * auto-load.c: Fix common/ includes.
2175         * arm-tdep.c: Fix common/ includes.
2176         * arch/riscv.c: Fix common/ includes.
2177         * arch/ppc-linux-common.c: Fix common/ includes.
2178         * arch/i386.c: Fix common/ includes.
2179         * arch/arm.c: Fix common/ includes.
2180         * arch/arm-linux.c: Fix common/ includes.
2181         * arch/arm-get-next-pcs.c: Fix common/ includes.
2182         * arch/amd64.c: Fix common/ includes.
2183         * arch/aarch64.c: Fix common/ includes.
2184         * arch/aarch64-insn.c: Fix common/ includes.
2185         * arch-utils.c: Fix common/ includes.
2186         * amd64-windows-tdep.c: Fix common/ includes.
2187         * amd64-tdep.c: Fix common/ includes.
2188         * amd64-sol2-tdep.c: Fix common/ includes.
2189         * amd64-obsd-tdep.c: Fix common/ includes.
2190         * amd64-nbsd-tdep.c: Fix common/ includes.
2191         * amd64-linux-tdep.c: Fix common/ includes.
2192         * amd64-linux-nat.c: Fix common/ includes.
2193         * amd64-fbsd-tdep.c: Fix common/ includes.
2194         * amd64-fbsd-nat.c: Fix common/ includes.
2195         * amd64-dicos-tdep.c: Fix common/ includes.
2196         * amd64-darwin-tdep.c: Fix common/ includes.
2197         * agent.c: Fix common/ includes.
2198         * ada-lang.h: Fix common/ includes.
2199         * ada-lang.c: Fix common/ includes.
2200         * aarch64-tdep.c: Fix common/ includes.
2201
2202 2019-01-25  Tom Tromey  <tom@tromey.com>
2203
2204         * common/create-version.sh: Use common/version.h.
2205
2206 2019-01-24  Pedro Alves  <palves@redhat.com>
2207
2208         * infrun.c (signal_stop, signal_print, signal_program)
2209         (signal_catch, signal_pass): Now arrays instead of pointers.
2210         (update_signals_program_target, do_target_resume)
2211         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2212         * linux-nat.c (linux_nat_target::pass_signals)
2213         (linux_nat_target::create_inferior, linux_nat_target::attach):
2214         Adjust.
2215         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2216         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2217         * procfs.c (procfs_target::pass_signals): Adjust.
2218         * record-full.c (record_full_target::resume): Adjust.
2219         * remote.c (remote_target::pass_signals)
2220         (remote_target::program_signals): Adjust.
2221         * target-debug.h (target_debug_print_signals): Now takes a
2222         gdb::array_view as parameter.  Adjust.
2223         * target.h (target_ops) <pass_signals, program_signals>: Replace
2224         pointer and length parameters with gdb::array_view.
2225         (target_pass_signals, target_program_signals): Likewise.
2226         * target-delegates.c: Regenerate.
2227
2228 2019-01-24  Pedro Alves  <palves@redhat.com>
2229
2230         * common/forward-scope-exit.h
2231         (forward_scope_exit::forward_scope_exit): Pass arguments to
2232         m_bind_function directly, instead of creating a std::bind and
2233         copying that.
2234
2235 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2236
2237         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2238         for static members.
2239         (pass_in_v_vfp_candidate): Likewise.
2240
2241 2019-01-23  Tom Tromey  <tom@tromey.com>
2242             Pedro Alves  <palves@redhat.com>
2243
2244         * regcache.c (class regcache_invalidator): Remove.
2245         (regcache::raw_write): Use make_scope_exit.
2246
2247 2019-01-23  Tom Tromey  <tom@tromey.com>
2248
2249         * ui-out.h (class ui_out_emit_type): Update comment.
2250
2251 2019-01-23  Tom Tromey  <tom@tromey.com>
2252
2253         * infrun.c (fetch_inferior_event): Update comment.
2254
2255 2019-01-23  Tom Tromey  <tom@tromey.com>
2256             Pedro Alves  <palves@redhat.com>
2257
2258         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2259         parameter.
2260         (fetch_inferior_event): Use SCOPE_EXIT.
2261
2262
2263 2019-01-23  Tom Tromey  <tom@tromey.com>
2264             Pedro Alves  <palves@redhat.com>
2265
2266         * infrun.c (disable_thread_events): Delete.
2267         (stop_all_threads): Use SCOPE_EXIT.
2268
2269 2019-01-23  Tom Tromey  <tom@tromey.com>
2270             Pedro Alves  <palves@redhat.com>
2271
2272         * symfile.c: Include forward-scope-exit.h.
2273         (clear_symtab_users_cleanup): Replace forward declaration with
2274         a FORWARD_SCOPE_EXIT.
2275         (syms_from_objfile_1): Use the forward_scope_exit and
2276         gdb::optional instead of cleanup_function.
2277         (reread_symbols): Use the forward_scope_exit instead of
2278         cleanup_function.
2279         (clear_symtab_users_cleanup): Remove function.
2280
2281 2019-01-23  Tom Tromey  <tom@tromey.com>
2282             Pedro Alves  <palves@redhat.com>
2283
2284         * linux-nat.c: Include scope-exit.h.
2285         (cleanup_target_stop): Remove.
2286         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2287         SCOPE_EXIT.
2288
2289 2019-01-23  Tom Tromey  <tom@tromey.com>
2290             Pedro Alves  <palves@redhat.com>
2291
2292         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2293         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2294
2295 2019-01-23  Tom Tromey  <tom@tromey.com>
2296             Andrew Burgess  <andrew.burgess@embecosm.com>
2297             Pedro Alves  <palves@redhat.com>
2298
2299         * infrun.c (fetch_inferior_event): Use scope_exit.
2300         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2301         * top.c (execute_command): Use scope_exit.
2302         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2303         * utils.c (do_bpstat_clear_actions_cleanup)
2304         (make_bpstat_clear_actions_cleanup): Remove.
2305
2306 2019-01-23  Tom Tromey  <tom@tromey.com>
2307             Pedro Alves  <palves@redhat.com>
2308
2309         * infrun.c: Include "common/scope-exit.h"
2310         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2311         (wait_for_inferior): Use SCOPE_EXIT.
2312         (fetch_inferior_event): Use scope_exit.
2313
2314 2019-01-23  Tom Tromey  <tom@tromey.com>
2315             Pedro Alves  <palves@redhat.com>
2316
2317         * breakpoint.c (create_breakpoint): Remove cleanup.
2318
2319 2019-01-23  Tom Tromey  <tom@tromey.com>
2320             Andrew Burgess  <andrew.burgess@embecosm.com>
2321             Pedro Alves  <palves@redhat.com>
2322
2323 2019-01-23  Pedro Alves  <palves@redhat.com>
2324
2325         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2326
2327 2019-01-23  Pedro Alves  <palves@redhat.com>
2328             Andrew Burgess  <andrew.burgess@embecosm.com>
2329
2330         * gdbthread.h: Include "common/forward-scope-exit.h".
2331         (scoped_finish_thread_state): Redefine custom class in terms of
2332         forward_scope_exit.
2333
2334 2019-01-23  Pedro Alves  <palves@redhat.com>
2335             Andrew Burgess  <andrew.burgess@embecosm.com>
2336
2337         * common/forward-scope-exit.h: New file.
2338
2339 2019-01-23  Pedro Alves  <palves@redhat.com>
2340             Andrew Burgess  <andrew.burgess@embecosm.com>
2341             Tom Tromey  <tom@tromey.com>
2342
2343         * common/scope-exit.h: New file.
2344
2345 2019-01-23  Pedro Alves  <palves@redhat.com>
2346
2347         * common/preprocessor.h (ESC): Rename to ...
2348         (ESC_PARENS): ... this.
2349         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2350         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2351
2352 2019-01-23  Tom Tromey  <tom@tromey.com>
2353
2354         * language.h (class scoped_switch_to_sym_language_if_auto):
2355         Initialize m_lang in both cases.
2356
2357 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2358
2359         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2360         with XCNEW.
2361
2362 2019-01-22  Tom Tromey  <tom@tromey.com>
2363
2364         * corelow.c: Do not include sys/file.h.
2365
2366 2019-01-22  Tom Tromey  <tom@tromey.com>
2367
2368         * tui/tui-wingeneral.h: Include gdb_curses.h.
2369
2370 2019-01-22  Tom Tromey  <tom@tromey.com>
2371
2372         * source-cache.h (class source_cache) <get_source_lines,
2373         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2374
2375 2019-01-22  Tom Tromey  <tom@tromey.com>
2376
2377         * remote-fileio.h (struct remote_target): Declare.
2378
2379 2019-01-22  Tom Tromey  <tom@tromey.com>
2380
2381         * python/py-arch.c: Do not include py-ref.h.
2382         * python/py-bpevent.c: Do not include py-ref.h.
2383         * python/py-cmd.c: Do not include py-ref.h.
2384         * python/py-continueevent.c: Do not include py-ref.h.
2385         * python/py-event.h: Do not include py-ref.h.
2386         * python/py-evtregistry.c: Do not include py-ref.h.
2387         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2388         * python/py-frame.c: Do not include py-ref.h.
2389         * python/py-framefilter.c: Do not include py-ref.h.
2390         * python/py-function.c: Do not include py-ref.h.
2391         * python/py-infevents.c: Do not include py-ref.h.
2392         * python/py-linetable.c: Do not include py-ref.h.
2393         * python/py-objfile.c: Do not include py-ref.h.
2394         * python/py-param.c: Do not include py-ref.h.
2395         * python/py-prettyprint.c: Do not include py-ref.h.
2396         * python/py-progspace.c: Do not include py-ref.h.
2397         * python/py-symbol.c: Do not include py-ref.h.
2398         * python/py-symtab.c: Do not include py-ref.h.
2399         * python/py-type.c: Do not include py-ref.h.
2400         * python/py-unwind.c: Do not include py-ref.h.
2401         * python/py-utils.c: Do not include py-ref.h.
2402         * python/py-value.c: Do not include py-ref.h.
2403         * python/py-varobj.c: Do not include py-ref.h.
2404         * python/py-xmethods.c: Do not include py-ref.h.
2405         * python/python.c: Do not include py-ref.h.
2406         * varobj.c: Do not include py-ref.h.
2407
2408 2019-01-22  Tom Tromey  <tom@tromey.com>
2409
2410         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2411         keyword for bcache.
2412
2413 2019-01-22  Tom Tromey  <tom@tromey.com>
2414
2415         * compile/compile-cplus-types.c: Remove a comment by #include.
2416
2417 2019-01-22  Tom Tromey  <tom@tromey.com>
2418
2419         * compile/gcc-c-plugin.h: Include compile-internal.h.
2420
2421 2019-01-22  Tom Tromey  <tom@tromey.com>
2422
2423         * stabsread.c (EXTERN): Do not define.
2424         (symnum, next_symbol_text_func, processing_gcc_compilation)
2425         (within_function, global_sym_chain, global_stabs)
2426         (previous_stab_code, this_object_header_files)
2427         (n_this_object_header_files)
2428         (n_allocated_this_object_header_files): Define.
2429         * stabsread.h (EXTERN): Never define.  Use "extern".
2430
2431 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2432
2433         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2434         history_value.
2435
2436 2019-01-21  Tom Tromey  <tom@tromey.com>
2437
2438         * ui-out.c: Fix includes.
2439         * tui/tui-source.c: Fix includes.
2440         * target.c: Fix includes.
2441         * remote.c: Fix includes.
2442         * regcache.c: Fix includes.
2443         * python/py-block.c: Fix includes.
2444         * printcmd.c: Fix includes.
2445         * or1k-tdep.c: Fix includes.
2446         * mi/mi-main.c: Fix includes.
2447         * m32r-tdep.c: Fix includes.
2448         * csky-tdep.c: Fix includes.
2449         * compile/compile-cplus-types.c: Fix includes.
2450         * cli/cli-interp.c: Fix includes.
2451
2452 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2453
2454         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2455         for padding.
2456
2457 2019-01-16  Tom Tromey  <tom@tromey.com>
2458
2459         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2460         earlier.
2461         (struct objfile) <msymbols_range>: Move from top level.
2462         <msymbols>: New method.
2463         (class objfile_msymbols): Remove.
2464         * symtab.c (default_collect_symbol_completion_matches_break_on):
2465         Update.
2466         * symmisc.c (dump_msymbols): Update.
2467         * stabsread.c (scan_file_globals): Update.
2468         * objc-lang.c (info_selectors_command, info_classes_command)
2469         (find_methods): Update.
2470         * minsyms.c (find_solib_trampoline_target): Update.
2471         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2472         * coffread.c (coff_symfile_read): Update.
2473         * ada-lang.c (ada_lookup_simple_minsym)
2474         (ada_collect_symbol_completion_matches): Update.
2475
2476 2019-01-16  Tom Tromey  <tom@tromey.com>
2477
2478         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2479         type.  Remove no-argument constructor.
2480         <iterator::operator++>: Simplify.
2481         <begin>: Update.
2482         <end>: Use minimal_symbol_count.
2483
2484 2019-01-16  Tom Tromey  <tom@tromey.com>
2485
2486         * objfiles.h (struct objfile) <psymtabs>: New method.
2487         (class objfile_psymtabs): Remove.
2488         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2489         typedef.
2490         <range>: New method.
2491         (require_partial_symbols): Change return type.
2492         * psymtab.c (require_partial_symbols)
2493         (psym_expand_symtabs_matching): Update.
2494         * mdebugread.c (parse_partial_symbols): Update.
2495         * dbxread.c (dbx_end_psymtab): Update.
2496
2497 2019-01-15  Tom Tromey  <tom@tromey.com>
2498
2499         * symtab.c (lookup_objfile_from_block)
2500         (lookup_symbol_in_objfile_symtabs)
2501         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2502         (find_line_symtab, info_sources_command)
2503         (default_collect_symbol_completion_matches_break_on)
2504         (make_source_files_completion_list): Update.
2505         * symmisc.c (print_objfile_statistics, dump_objfile)
2506         (maintenance_print_symbols, maintenance_info_symtabs)
2507         (maintenance_check_symtabs, maintenance_info_line_tables):
2508         Update.
2509         * source.c (select_source_symtab)
2510         (forget_cached_source_info_for_objfile): Update.
2511         * objfiles.h (class objfile_compunits): Remove.
2512         (struct objfile) <compunits_range>: New typedef.
2513         (compunits): New method.
2514         * objfiles.c (objfile_relocate1): Update.
2515         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2516         * maint.c (count_symtabs_and_blocks): Update.
2517         * linespec.c (iterate_over_all_matching_symtabs): Update.
2518         * cp-support.c (add_symbol_overload_list_qualified): Update.
2519         * coffread.c (coff_symtab_read): Update.
2520         * ada-lang.c (add_nonlocal_symbols)
2521         (ada_collect_symbol_completion_matches)
2522         (ada_add_global_exceptions): Update.
2523
2524 2019-01-15  Tom Tromey  <tom@tromey.com>
2525
2526         * progspace.h (program_space) <objfiles_safe_range>: New
2527         typedef.
2528         <objfiles_safe>: New method.
2529         * objfiles.h (class all_objfiles_safe): Remove.
2530         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2531         * jit.c (jit_inferior_exit_hook): Update.
2532
2533 2019-01-17  Tom Tromey  <tom@tromey.com>
2534
2535         * progspace.h (program_space) <objfiles_range>: New typedef.
2536         <objfiles>: New method.
2537         <objfiles_head>: Rename from objfiles.
2538         (object_files): Update.
2539         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2540         * guile/scm-pretty-print.c
2541         (ppscm_find_pretty_printer_from_objfiles): Update.
2542         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2543         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2544         Update.
2545         * python/py-progspace.c (pspy_get_objfiles): Update.
2546         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2547         Update.
2548         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2549         (objfpy_lookup_objfile_by_build_id): Update.
2550         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2551         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2552         Update.
2553         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2554         (expand_symtab_containing_pc, lookup_objfile_from_block)
2555         (lookup_static_symbol, basic_lookup_transparent_type)
2556         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2557         (find_line_symtab, info_sources_command)
2558         (default_collect_symbol_completion_matches_break_on)
2559         (make_source_files_completion_list, find_main_name): Update.
2560         * symmisc.c (print_symbol_bcache_statistics)
2561         (print_objfile_statistics, maintenance_print_symbols)
2562         (maintenance_print_msymbols, maintenance_print_objfiles)
2563         (maintenance_info_symtabs, maintenance_check_symtabs)
2564         (maintenance_expand_symtabs, maintenance_info_line_tables):
2565         Update.
2566         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2567         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2568         (map_overlay_command, unmap_overlay_command)
2569         (simple_overlay_update, expand_symtabs_matching)
2570         (map_symbol_filenames): Update.
2571         * symfile-debug.c (set_debug_symfile): Update.
2572         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2573         Update.
2574         * source.c (select_source_symtab, forget_cached_source_info):
2575         Update.
2576         * solib.c (solib_read_symbols): Update.
2577         * solib-spu.c (append_ocl_sos): Update.
2578         * psymtab.c (maintenance_print_psymbols)
2579         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2580         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2581         * printcmd.c (info_symbol_command): Update.
2582         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2583         Update.
2584         * objfiles.h (class all_objfiles): Remove.
2585         * objfiles.c (have_partial_symbols, have_full_symbols)
2586         (have_minimal_symbols, qsort_cmp, update_section_map)
2587         (shared_objfile_contains_address_p)
2588         (default_iterate_over_objfiles_in_search_order): Update.
2589         * objc-lang.c (info_selectors_command, info_classes_command)
2590         (find_methods): Update.
2591         * minsyms.c (find_solib_trampoline_target): Update.
2592         * maint.c (maintenance_info_sections)
2593         (maintenance_translate_address, count_symtabs_and_blocks):
2594         Update.
2595         * main.c (captured_main_1): Update.
2596         * linux-thread-db.c (try_thread_db_load_from_pdir)
2597         (has_libpthread): Update.
2598         * linespec.c (iterate_over_all_matching_symtabs)
2599         (search_minsyms_for_name): Update.
2600         * jit.c (jit_find_objf_with_entry_addr): Update.
2601         * hppa-tdep.c (find_unwind_entry)
2602         (hppa_lookup_stub_minimal_symbol): Update.
2603         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2604         Update.
2605         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2606         (elf_gnu_ifunc_resolve_by_got): Update.
2607         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2608         * dwarf-index-write.c (save_gdb_index_command): Update.
2609         * cp-support.c (add_symbol_overload_list_qualified): Update.
2610         * breakpoint.c (create_overlay_event_breakpoint)
2611         (create_longjmp_master_breakpoint)
2612         (create_std_terminate_master_breakpoint)
2613         (create_exception_master_breakpoint): Update.
2614         * blockframe.c (find_pc_partial_function): Update.
2615         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2616         (ada_collect_symbol_completion_matches)
2617         (ada_add_global_exceptions): Update.
2618
2619 2019-01-17  Tom Tromey  <tom@tromey.com>
2620
2621         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2622         declare VEC.
2623         (solib_target_parse_libraries): Change return type.
2624         (library_list_start_segment, library_list_start_section)
2625         (library_list_end_library, library_list_start_library); Update.
2626         (solib_target_free_library_list): Remove.
2627         (solib_target_parse_libraries): Remove cleanup.  Change return
2628         type.
2629         (solib_target_current_sos): Update.
2630
2631 2019-01-17  Tom Tromey  <tromey@bapiya>
2632
2633         * valprint.c: Replace "the the" with "the".
2634         * symtab.c: Replace "the the" with "the".
2635         * solib.c: Replace "the the" with "the".
2636         * solib-dsbt.c: Replace "the the" with "the".
2637         * linespec.c: Replace "the the" with "the".
2638         * dwarf2loc.h: Replace "the the" with "the".
2639         * amd64-windows-tdep.c: Replace "the the" with "the".
2640         * aarch64-tdep.c: Replace "the the" with "the".
2641
2642 2019-01-16  Keith Seitz  <keiths@redhat.com>
2643
2644         PR gdb/23773
2645         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2646         <builder>: Rename to ..
2647         <m_builder>: ... this and make private.
2648         (dwarf2_cu::get_builder): New method.  Change all users of
2649         `builder' to use this method.
2650         (dwarf2_start_symtab): Move to ...
2651         (dwarf2_cu::start_symtab): ... here.  Update all callers
2652         (setup_type_unit_groups): Move to ...
2653         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2654         callers.
2655         (dwarf2_cu::reset_builder): New method.
2656         (process_full_compunit, process_full_type_unit): Use
2657         dwarf2_cu::reset_builder.
2658         (follow_die_offset): Record the ancestor CU if it is different
2659         from the followed DIE's CU.
2660         (follow_die_sig_1): Likewise.
2661
2662 2019-01-15  Tom Tromey  <tom@tromey.com>
2663
2664         * remote.c (class remote_state) <buf>: Now a char_vector.
2665         <buf_size>: Remove.
2666         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2667         parameter.
2668         (remote_target::getpkt_or_notif_sane_1)
2669         (remote_target::getpkt_sane)
2670         (remote_target::getpkt_or_notif_sane): Likewise.
2671         (class remote_target) <putpkt>: New overload.
2672         (remote_target::read_frame): Change type of "buf_p".  Remove
2673         sizeof_p parameter.
2674         (packet_ok): New overload.
2675         (packet_check_result): New overload.
2676         Update all uses.
2677
2678 2019-01-14  Tom Tromey  <tom@tromey.com>
2679
2680         * remote-notif.c (handle_notification, remote_notif_ack)
2681         (remote_notif_parse): Make "buf" const.
2682         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2683         const.
2684         (remote_notif_parse, remote_notif_ack, handle_notification):
2685         Likewise.
2686         * remote.c (remote_notif_stop_parse): Make "buf" const.
2687         (remote_target::remote_parse_stop_reply): Make "buf" const.
2688         (remote_notif_stop_ack): Make "buf" const.
2689
2690 2019-01-14  Tom Tromey  <tom@tromey.com>
2691
2692         * remote.c (remote_console_output): Make parameter const.
2693
2694 2019-01-14  Tom Tromey  <tom@tromey.com>
2695
2696         * target-debug.h (target_debug_print_signals): Constify.
2697         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2698         * procfs.c (procfs_target::pass_signals): Update.
2699         * linux-nat.c (linux_nat_target::pass_signals): Update.
2700         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2701         * target-delegates.c: Rebuild.
2702         * remote.c (remote_target::program_signals): Update.
2703         (remote_target::pass_signals): Update.
2704         * target.c (target_pass_signals): Constify argument.
2705         (target_program_signals): Likewise.
2706         * target.h (struct target_ops) <pass_signals, program_signals>:
2707         Constify argument.
2708         (target_pass_signals, target_program_signals): Constify argument.
2709
2710 2019-01-14  Tom Tromey  <tom@tromey.com>
2711
2712         PR tui/28819:
2713         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2714
2715 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2716
2717         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2718         field.
2719         * rs6000-tdep.c: Include reggroups.h.
2720         (IS_V_ALIAS_PSEUDOREG): Define.
2721         (rs6000_register_name): Return names for the "vX" aliases.
2722         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2723         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2724         aliases.  Call default_register_reggroup_p for all other
2725         pseudo-registers.
2726         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2727         New functions.
2728         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2729         Handle "vX" aliases.
2730         (v_alias_pseudo_register_collect): New function.
2731         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2732         (rs6000_gdbarch_init): Initialize "vX" aliases as
2733         pseudo-registers.  Restore registration of
2734         rs6000_pseudo_register_reggroup_p with
2735         set_tdesc_pseudo_register_reggroup_p.
2736
2737 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2738
2739         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2740         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2741         set_gdbarch_num_pseudo_regs.
2742
2743 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2744
2745         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2746         Remove arg prefixname, add do_set and do_show.
2747         Add member functions set_list and show_list.
2748         * cli/cli-style.c (class cli_style_option): Update accordingly.
2749         (style_set_list): Move to file scope.
2750         (style_show_list): Likewise.
2751         (set_style): Call help_list.
2752         (show_style): Call cmd_show_list.
2753         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2754         Update to use the new macro.
2755
2756 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2757
2758         * ada-lang.c (_initialize_ada_language): Expand the help text
2759         for the "catch exception" command.
2760
2761 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2762
2763         * symtab.c (matching_obj_sections): Initialize obj,
2764         declare it closer to its usage.
2765
2766 2019-01-10  Tom Tromey  <tom@tromey.com>
2767
2768         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2769         (basic_inf_threads_range): Remove.
2770         (inf_threads_range, inf_non_exited_threads_range)
2771         (safe_inf_threads_range): Use next_adapter.
2772
2773 2019-01-10  Keith Seitz  <keiths@redhat.com>
2774
2775         PR gdb/23712
2776         PR symtab/23010
2777         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2778         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2779
2780 2019-01-10  Keith Seitz  <keiths@redhat.com>
2781
2782         PR gdb/23712
2783         PR symtab/23010
2784         * dictionary.c (pending_to_vector): Remove.
2785         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2786         Remove _1 suffix, replacing functions of the same name.  Update
2787         all callers.
2788         (dict_create_hashed, dict_create_hashed_expandable)
2789         (dict_create_linear, dict_create_linear_expandable, dict_free)
2790         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2791         Make functions static.
2792
2793 2019-01-10  Keith Seitz  <keiths@redhat.com>
2794
2795         PR gdb/23712
2796         PR symtab/23010
2797         * dictionary.h (struct dictionary): Replace declaration with
2798         multidictionary.
2799         (dict_create_hashed, dict_create_hashed_expandable)
2800         (dict_create_linear, dict_create_linear_expandable)
2801         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2802         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2803         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2804         taking multidictionary argument.
2805         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2806         * block.h (struct block) <dict>: Change to multidictionary
2807         and rename `multidict'.
2808         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2809         symmisc.c: Update all dictionary references to multidictionary.
2810
2811 2019-01-10  Keith Seitz  <keiths@redhat.com>
2812
2813         PR gdb/23712
2814         PR symtab/23010
2815         * dictionary.c: Include unordered_map.
2816         (pending_to_vector): New function.
2817         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2818         Rewrite the non-"_1" functions to take vector instead
2819         of linked list.
2820         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2821         "new" _1 versions of the same name.
2822         (multidictionary): Define.
2823         (std::hash<enum language): New definition.
2824         (collate_pending_symbols_by_language, mdict_create_hashed)
2825         (mdict_create_hashed_expandable, mdict_create_linear)
2826         (mdict_create_linear_expandable, mdict_free)
2827         (find_language_dictionary, create_new_language_dictionary)
2828         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2829         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2830         (mdict_size, mdict_empty): New functions.
2831         * dictionary.h (mdict_iterator): Define.
2832
2833 2019-01-10  Pedro Alves  <palves@redhat.com>
2834
2835         * breakpoint.c (read_uploaded_action)
2836         (create_tracepoint_from_upload): Adjust to use
2837         gdb::unique_xmalloc_ptr.
2838         * ctf.c (ctf_write_uploaded_tp):
2839         (SET_ARRAY_FIELD): Use emplace_back.
2840         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2841         * tracefile-tfile.c (tfile_write_uploaded_tp):
2842         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2843         gdb::unique_xmalloc_ptr.
2844         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2845         at_string, cond_string, cmd_strings>: Replace char pointers
2846         with gdb::unique_xmalloc_ptr.
2847
2848 2019-01-10  Pedro Alves  <palves@redhat.com>
2849
2850         * solib-target.c (library_list_start_library): Don't xstrdup name.
2851
2852 2019-01-10  Pedro Alves  <palves@redhat.com>
2853
2854         * mdebugread.c (parse_partial_symbols): Use
2855         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2856
2857 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2858
2859         * linux-fork.c (scoped_switch_fork_info)
2860         <~scoped_switch_fork_info>: Fix incorrect variable name.
2861
2862 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2863
2864         * linux-fork.c (scoped_switch_fork_info)
2865         <scoped_switch_fork_info>: Make explicit.
2866         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2867
2868 2019-01-10  Tom Tromey  <tom@tromey.com>
2869
2870         * objfiles.h (objfile::reset_psymtabs): Update.
2871         * objfiles.c (objfile::objfile): Update.
2872         * psymtab.h (psymtab_storage::obstack): Update.
2873         (psymtab_storage::m_obstack): Use gdb::optional.
2874         (class psymtab_storage): Update comment.  Remove objfile
2875         parameter.
2876         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2877
2878 2019-01-10  Tom Tromey  <tom@tromey.com>
2879
2880         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2881         <free_psymtabs>: Now private.
2882         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2883         (allocate_psymtab): Use new method.
2884
2885 2019-01-10  Tom Tromey  <tom@tromey.com>
2886
2887         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2888         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2889         * mdebugread.c (parse_partial_symbols): Use
2890         allocate_dependencies.
2891         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2892         allocate_dependencies.
2893         (process_psymtab_comp_unit_reader)
2894         (build_type_psymtab_dependencies): Likewise.
2895         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2896
2897 2019-01-10  Tom Tromey  <tom@tromey.com>
2898
2899         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2900         PSYMBOL_SET_LANGUAGE.
2901         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2902
2903 2019-01-10  Tom Tromey  <tom@tromey.com>
2904
2905         * psymtab.h (psymtab_storage::obstack): New method.
2906         <m_obstack>: Rename from obstack; now private.
2907         * psymtab.c (psymtab_storage): Update.
2908         * dwarf2read.c (create_addrmap_from_index)
2909         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2910         Update.
2911
2912 2019-01-10  Tom Tromey  <tom@tromey.com>
2913
2914         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2915         * objfiles.h (objfile::reset_psymtabs): New method.
2916
2917 2019-01-10  Tom Tromey  <tom@tromey.com>
2918
2919         * symmisc.c (print_symbol_bcache_statistics): Update.
2920         (print_objfile_statistics): Update.
2921         * symfile.c (reread_symbols): Update.
2922         * psymtab.h (class psymtab_storage): New.
2923         * psymtab.c (psymtab_storage): New constructor.
2924         (~psymtab_storage): New destructor.
2925         (require_partial_symbols): Update.
2926         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2927         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2928         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2929         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2930         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2931         (start_psymtab_common, end_psymtab_common)
2932         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2933         (allocate_psymtab): Update.
2934         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2935         Update.
2936         (dump_psymtab_addrmap, maintenance_print_psymbols)
2937         (maintenance_check_psymtabs): Update.
2938         (class objfile_psymtabs): Move to objfiles.h.
2939         * psympriv.h (discard_psymtab): Now inline.
2940         (psymtab_discarder::psymtab_discarder): Update.
2941         (psymtab_discarder::~psymtab_discarder): Update.
2942         (ALL_OBJFILE_PSYMTABS): Rewrite.
2943         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2944         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2945         Remove fields.
2946         <partial_symtabs>: New field.
2947         (class objfile_psymtabs): Move from psymtab.h.  Update.
2948         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2949         psymbol_cache.
2950         (objfile::~objfile): Don't destroy psymbol_cache.
2951         * mdebugread.c (parse_partial_symbols): Update.
2952         * dwarf2read.c (create_addrmap_from_index)
2953         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2954         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2955         (add_partial_subprogram, dwarf2_ranges_read): Update.
2956         * dwarf-index-write.c (write_address_map)
2957         (write_one_signatured_type, recursively_write_psymbols)
2958         (class debug_names, class debug_names, write_psymtabs_to_index):
2959         Update.
2960
2961 2019-01-10  Tom Tromey  <tom@tromey.com>
2962
2963         * symtab.h (SYMBOL_SET_NAMES): Update.
2964         (symbol_set_names): Update.
2965         (MSYMBOL_SET_NAMES): Update.
2966         * symtab.c (symbol_set_names): Change argument to be an
2967         objfile_per_bfd_storage.
2968         * psymtab.c (add_psymbol_to_bcache): Update.
2969         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2970
2971 2019-01-10  Tom Tromey  <tom@tromey.com>
2972
2973         * symtab.c (create_demangled_names_hash): Change argument to be an
2974         objfile_per_bfd_storage.
2975         (symbol_set_names): Update.
2976
2977 2019-01-10  Tom Tromey  <tom@tromey.com>
2978
2979         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2980         init_psymbol_list.
2981         * psymtab.c (init_psymbol_list): Do nothing if already called.
2982         * psympriv.h (init_psymbol_list): Add comment.
2983         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2984         init_psymbol_list.
2985         * dbxread.c (dbx_symfile_read): Unconditionally call
2986         init_psymbol_list.
2987
2988 2019-01-10  Tom Tromey  <tom@tromey.com>
2989
2990         * xcoffread.c (scan_xcoff_symtab): Update.
2991         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2992         "where".
2993         * mdebugread.c (parse_partial_symbols)
2994         (handle_psymbol_enumerators): Update.
2995         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2996         * dbxread.c (read_dbx_symtab): Update.
2997         * psympriv.h (psymbol_placement): New enum.
2998         (add_psymbol_to_list): Update.
2999
3000 2019-01-10  Tom Tromey  <tom@tromey.com>
3001
3002         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3003         static_psymbols parameters.
3004         (scan_xcoff_symtab): Update.
3005         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3006         static_psymbols parameters.
3007         * psympriv.h (start_psymtab_common): Update.
3008         * mdebugread.c (parse_partial_symbols): Update.
3009         * dwarf2read.c (create_partial_symtab): Update.
3010         * dbxread.c (read_dbx_symtab): Update.
3011         (start_psymtab): Remove global_psymbols and static_psymbols
3012         parameters.
3013
3014 2019-01-10  Tom Tromey  <tom@tromey.com>
3015
3016         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3017         * psymtab.c (allocate_psymtab): Add comment.
3018         * psympriv.h (allocate_psymtab): Add comment.
3019         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3020         initializations.
3021         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3022
3023 2019-01-10  Tom Tromey  <tom@tromey.com>
3024
3025         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3026         Don't declare.
3027         * mipsread.c: Include mdebugread.h.
3028         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3029         Declare.
3030         * elfread.c: Include mdebugread.h.
3031
3032 2019-01-09  Tom Tromey  <tom@tromey.com>
3033
3034         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3035         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3036         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3037         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3038         (psym_lookup_symbol, psym_find_last_source_symtab)
3039         (psym_forget_cached_source_info, psym_print_stats)
3040         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3041         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3042         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3043         (psym_find_compunit_symtab_by_address)
3044         (maintenance_print_psymbols, maintenance_info_psymtabs)
3045         (maintenance_check_psymtabs): Use ranged for.
3046         * psymtab.h (class objfile_psymtabs): New.
3047         (require_partial_symbols): Return objfile_psymtabs.
3048         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3049
3050 2019-01-09  Tom Tromey  <tom@tromey.com>
3051
3052         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3053         (find_pc_mapped_section, list_overlays_command)
3054         (map_overlay_command, unmap_overlay_command)
3055         (simple_overlay_update): Use all_objfiles.
3056         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3057         * printcmd.c (info_symbol_command): Use all_objfiles.
3058         * objfiles.h (ALL_OBJSECTIONS): Remove.
3059         * maint.c (maintenance_translate_address): Use all_objfiles.
3060         * gcore.c (gcore_create_callback): Use all_objfiles.
3061         (objfile_find_memory_regions): Likewise.
3062
3063 2019-01-09  Tom Tromey  <tom@tromey.com>
3064
3065         * symtab.c (find_line_symtab, info_sources_command)
3066         (make_source_files_completion_list): Use objfile_compunits.
3067         * source.c (select_source_symtab): Use objfile_compunits.
3068         * objfiles.h (struct objfile): Update comment.
3069         (ALL_OBJFILES): Remove.
3070         (ALL_FILETABS): Remove.
3071         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3072         objfile_compunits.
3073
3074 2019-01-09  Tom Tromey  <tom@tromey.com>
3075
3076         * symmisc.c (print_objfile_statistics, dump_objfile)
3077         (maintenance_print_symbols): Use compunit_filetabs.
3078         * source.c (forget_cached_source_info_for_objfile): Use
3079         compunit_filetabs.
3080         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3081         (ALL_FILETABS): Use compunit_filetabs.
3082         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3083         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3084
3085 2019-01-09  Tom Tromey  <tom@tromey.com>
3086
3087         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3088         (compunit_filetabs): New.
3089         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3090         compunit_filetabs.
3091         (info_sources_command, make_source_files_completion_list): Remove
3092         declaration.
3093         * symmisc.c (print_objfile_statistics, dump_objfile)
3094         (maintenance_print_symbols): Remove declaration.
3095         (maintenance_info_symtabs): Use compunit_filetabs.
3096         (maintenance_info_line_tables): Likewise.
3097         * source.c (select_source_symtab): Change local variable name.
3098         (forget_cached_source_info_for_objfile): Remove declaration.
3099         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3100         * objfiles.c (objfile_relocate1): Remove declaration.
3101         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3102         declaration.
3103         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3104         * coffread.c (coff_symtab_read): Remove declaration.
3105         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3106         compunit_filetabs.
3107
3108 2019-01-09  Tom Tromey  <tom@tromey.com>
3109
3110         * symtab.c (lookup_objfile_from_block)
3111         (find_pc_sect_compunit_symtab, search_symbols)
3112         (default_collect_symbol_completion_matches_break_on): Use
3113         objfile_compunits.
3114         * objfiles.h (ALL_COMPUNITS): Remove.
3115         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3116         * cp-support.c (add_symbol_overload_list_qualified): Use
3117         objfile_compunits.
3118         * ada-lang.c (ada_collect_symbol_completion_matches)
3119         (ada_add_global_exceptions): Use objfile_compunits.
3120
3121 2019-01-09  Tom Tromey  <tom@tromey.com>
3122
3123         * source.c (select_source_symtab)
3124         (forget_cached_source_info_for_objfile): Remove declaration.
3125         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3126         declaration.
3127         * maint.c (count_symtabs_and_blocks): Remove declaration.
3128         * cp-support.c (add_symbol_overload_list_qualified): Remove
3129         declaration.
3130         * coffread.c (coff_symtab_read): Remove declaration.
3131         * symtab.c (lookup_symbol_in_objfile_symtabs)
3132         (basic_lookup_transparent_type_1): Use objfile_compunits.
3133         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3134         (info_sources_command, search_symbols)
3135         (default_collect_symbol_completion_matches_break_on)
3136         (make_source_files_completion_list): Remove declaration.
3137         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3138         (ada_collect_symbol_completion_matches)
3139         (ada_add_global_exceptions): Remove declaration.
3140         * linespec.c (iterate_over_all_matching_symtabs): Use
3141         objfile_compunits.
3142         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3143         (class objfile_compunits): New.
3144         (ALL_COMPUNITS): Use objfile_compunits.
3145         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3146         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3147         objfile_compunits.
3148         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3149
3150 2019-01-09  Tom Tromey  <tom@tromey.com>
3151
3152         * symtab.c (search_symbols)
3153         (default_collect_symbol_completion_matches_break_on): Use
3154         objfile_msymbols.
3155         * ada-lang.c (ada_lookup_simple_minsym)
3156         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3157         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3158         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3159         objfile_msymbols.
3160         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3161         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3162         * objc-lang.c (find_methods): Use objfile_msymbols.
3163         (info_selectors_command, info_classes_command): Likewise.
3164         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3165         * objfiles.h (class objfile_msymbols): New.
3166         (ALL_OBJFILE_MSYMBOLS): Remove.
3167         (ALL_MSYMBOLS): Remove.
3168
3169 2019-01-09  Tom Tromey  <tom@tromey.com>
3170
3171         * common/next-iterator.h (next_adapter): Add Iterator template
3172         parameter.
3173         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3174         (class all_objfiles_safe): New.
3175         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3176         * objfiles.c (put_objfile_before): Update comment.
3177         (add_separate_debug_objfile): Likewise.
3178         (free_all_objfiles): Use all_objfiles_safe.
3179         (objfile_purge_solibs): Likewise.
3180
3181 2019-01-09  Tom Tromey  <tom@tromey.com>
3182
3183         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3184         (expand_symtab_containing_pc, lookup_static_symbol)
3185         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3186         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3187         all_objfiles.
3188         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3189         * breakpoint.c (create_overlay_event_breakpoint)
3190         (create_longjmp_master_breakpoint)
3191         (create_std_terminate_master_breakpoint)
3192         (create_exception_master_breakpoint): Use all_objfiles.
3193         * linux-thread-db.c (try_thread_db_load_from_pdir)
3194         (has_libpthread): Use all_objfiles.
3195         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3196         * linespec.c (iterate_over_all_matching_symtabs)
3197         (search_minsyms_for_name): Use all_objfiles.
3198         * maint.c (maintenance_info_sections): Use all_objfiles.
3199         * main.c (captured_main_1): Use all_objfiles.
3200         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3201         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3202         * guile/scm-pretty-print.c
3203         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3204         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3205         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3206         (maintenance_print_msymbols): Use all_objfiles.
3207         * source.c (select_source_symtab): Use all_objfiles.
3208         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3209         * symfile.c (remove_symbol_file_command)
3210         (expand_symtabs_matching, map_symbol_filenames): Use
3211         all_objfiles.
3212         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3213         all_objfiles.
3214         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3215         * objc-lang.c (find_methods): Use all_objfiles.
3216         * objfiles.c (have_partial_symbols, have_full_symbols)
3217         (have_minimal_symbols, qsort_cmp)
3218         (default_iterate_over_objfiles_in_search_order): Use
3219         all_objfiles.
3220         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3221         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3222         (maintenance_check_psymtabs): Use all_objfiles.
3223         (ALL_PSYMTABS): Remove.
3224         * compile/compile-object-run.c (do_module_cleanup): Use
3225         all_objfiles.
3226         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3227         * cp-support.c (add_symbol_overload_list_qualified): Use
3228         all_objfiles.
3229         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3230         Use all_objfiles.
3231         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3232         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3233         all_objfiles.
3234         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3235         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3236         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3237         Uses all_objfiles.
3238         * solib.c (solib_read_symbols): Use all_objfiles
3239
3240 2019-01-09  Tom Tromey  <tom@tromey.com>
3241
3242         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3243         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3244         all_objfiles.
3245         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3246         * symmisc.c (print_symbol_bcache_statistics)
3247         (print_objfile_statistics, maintenance_print_objfiles)
3248         (maintenance_info_symtabs, maintenance_check_symtabs)
3249         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3250         all_objfiles.
3251         * source.c (forget_cached_source_info): Use all_objfiles.
3252         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3253         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3254         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3255         * objfiles.c (update_section_map): Use all_objfiles.
3256         (shared_objfile_contains_address_p): Likewise.
3257         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3258         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3259
3260 2019-01-09  Tom Tromey  <tom@tromey.com>
3261
3262         * common/next-iterator.h: New file.
3263         * objfiles.h (class all_objfiles): New.
3264         (struct objfile_iterator): New.
3265
3266 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3267
3268         * NEWS: Move the description of the changed "frame", "select-frame",
3269          and "info frame" commands to the Changed commands section.
3270
3271 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3272
3273         * gdbtypes.c (check_stub_method_group): Remove handling of old
3274         mangling schemes.
3275         * linespec.c (find_methods): Likewise.
3276         * stabsread.c (read_member_functions): Likewise.
3277         * valops.c (search_struct_method): Likewise.
3278         (value_struct_elt_for_reference): Likewise.
3279         * NEWS: Mention this change.
3280
3281 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3282
3283         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3284         print_source_lines.
3285         * source.c (print_source_lines_base): Update line number check.
3286         (print_source_lines): New function.
3287         (source_lines_range::source_lines_range): New function.
3288         * source.h (class source_lines_range): New class.
3289         (print_source_lines): New declaration.
3290
3291 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3292
3293         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3294
3295 2019-01-08  Tom Tromey  <tom@tromey.com>
3296             Simon Marchi  <simon.marchi@ericsson.com>
3297
3298         PR gdb/24060
3299         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3300         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3301         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3302         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3303         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3304         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3305
3306 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3307
3308         * source.c (select_source_symtab): Move header comment to
3309         declaration in source.h.
3310         (forget_cached_source_info_for_objfile): Likewise.
3311         (forget_cached_source_info): Likewise.
3312         (identify_source_line): Likewise.
3313         * source.h (identify_source_line): Move declaration from symtab.h
3314         and add comment from source.c
3315         (print_source_lines): Likewise.
3316         (forget_cached_source_info_for_objfile): Likewise.
3317         (forget_cached_source_info): Likewise.
3318         (select_source_symtab): Likewise.
3319         (enum print_source_lines_flag): Move definition from symtab.h.
3320         * symtab.h (identify_source_line): Move declaration to source.h.
3321         (print_source_lines): Likewise.
3322         (forget_cached_source_info_for_objfile): Likewise.
3323         (forget_cached_source_info): Likewise.
3324         (select_source_symtab): Likewise.
3325         (enum print_source_lines_flag): Move definition to source.h.
3326         * tui/tui-hooks.c: Add 'source.h' include.
3327
3328 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3329
3330         * source.c (print_source_lines_base): Handle requests to print
3331         reverse line number sequences, and guard against empty lines
3332         string.
3333
3334 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3335
3336         * source.c (print_source_lines_base): Fix skip of '\r' if next
3337         character is '\n'.
3338
3339 2019-01-06  Tom Tromey  <tom@tromey.com>
3340
3341         * c-exp.y (struct c_parse_state) <macro_original_text,
3342         expansion_obstack>: New member.
3343         (macro_original_text, expansion_obstack): Remove globals.
3344         (scan_macro_expansion, scanning_macro_expansion)
3345         (finished_macro_expansion): Update.
3346         (scan_macro_cleanup): Remove.
3347         (yylex, c_parse): Update.
3348
3349 2019-01-06  Tom Tromey  <tom@tromey.com>
3350
3351         * c-exp.y (struct c_parse_state) <strings>: New member.
3352         (operator_stoken): Update.
3353
3354 2019-01-06  Tom Tromey  <tom@tromey.com>
3355
3356         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3357         (union type_stack_elt) <typelist_val>: Now a pointer to
3358         std::vector.
3359         (type_stack_cleanup): Don't declare.
3360         (push_typelist): Update.
3361         * parse.c (pop_typelist): Return a std::vector.
3362         (push_typelist): Take a std::vector.
3363         (follow_types): Update.  Do not free args.
3364         (type_stack_cleanup): Remove.
3365         * c-exp.y (struct c_parse_state): New.
3366         (cpstate): New global.
3367         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3368         (nonempty_typelist): Update.
3369         (func_mod): Create a new vector.
3370         (c_parse): Create a c_parse_state.
3371         (check_parameter_typelist): Do not delete params.
3372         (function_method): Update.  Do not delete type_list.
3373
3374 2019-01-06  Tom Tromey  <tom@tromey.com>
3375
3376         PR gdb/28155:
3377         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3378         check_typedef.
3379         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3380         (print_return_value): Likewise.
3381
3382 2019-01-05  Tom Tromey  <tom@tromey.com>
3383
3384         * contrib/cleanup_check.py: Remove.
3385         * contrib/gcc-with-excheck: Remove.
3386         * contrib/exsummary.py: Remove.
3387         * contrib/excheck.py: Remove.
3388
3389 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3390
3391         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3392         NULL. Initialize tpprev to NULL instead of assigning it
3393         to NULL on the next statement.
3394         * windows-nat.c (windows_delete_thread): Remove check for
3395         main_thread_id before printing thread exit notifications.
3396         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3397         Remove thread ID check against main_thread_id.
3398         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3399         windows_delete_thread.
3400         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3401
3402 2019-01-04  Tom Tromey  <tom@tromey.com>
3403
3404         * compile/compile.c (_initialize_compile): Use upper case for
3405         metasyntactic variables.
3406         * symmisc.c (_initialize_symmisc): Use upper case for
3407         metasyntactic variables.
3408         * psymtab.c (_initialize_psymtab): Use upper case for
3409         metasyntactic variables.
3410         * demangle.c (demangle_command): Use upper case for metasyntactic
3411         variables.
3412         (_initialize_demangler): Likewise.
3413         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3414         variables.
3415
3416 2019-01-03  Tom Tromey  <tom@tromey.com>
3417
3418         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3419
3420 2019-01-03  Tom Tromey  <tom@tromey.com>
3421
3422         * python/py-symtab.c (salpy_str): Update.
3423         (struct salpy_sal_object) <symtab>: Now a PyObject.
3424         (salpy_dealloc): Update.
3425         (del_objfile_sal): Use gdbpy_ref.
3426
3427 2019-01-03  Tom Tromey  <tom@tromey.com>
3428
3429         * python/py-type.c (convert_field): Use new_reference.  Return
3430         gdbpy_ref.
3431         (make_fielditem): Return gdbpy_ref.
3432         (typy_fields): Update.
3433         (typy_getitem): Update.
3434         (field_name): Return gdbpy_ref.  Use new_reference.
3435         (typy_iterator_iternext): Update.
3436
3437 2019-01-03  Tom Tromey  <tom@tromey.com>
3438
3439         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3440
3441 2019-01-03  Tom Tromey  <tom@tromey.com>
3442
3443         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3444         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3445         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3446         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3447         (pspy_set_type_printers): Likewise.
3448         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3449         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3450         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3451         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3452         (objfpy_set_type_printers): Likewise.
3453
3454 2019-01-03  Tom Tromey  <tom@tromey.com>
3455
3456         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3457         (gdbpy_print_stack): Use gdbpy_err_fetch.
3458         * python/python-internal.h (class gdbpy_err_fetch): New class.
3459         (class gdbpy_enter) <m_error_type, m_error_value,
3460         m_error_traceback>: Remove.
3461         <m_error>: New member.
3462         (gdbpy_exception_to_string): Don't declare.
3463         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3464         * python/py-value.c (convert_value_from_python): Use
3465         gdbpy_err_fetch.
3466         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3467         gdbpy_exception_to_string.
3468         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3469         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3470         gdbpy_err_fetch.
3471
3472 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3473
3474         * linux-nat.c (delete_lwp_cleanup): Delete.
3475         (struct lwp_deleter): New struct.
3476         (lwp_info_up): New typedef.
3477         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3478         lwp_info_up.
3479
3480 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3481
3482         * linux-fork.c (class scoped_switch_fork_info): New class.
3483         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3484
3485 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3486
3487         * valops.c (find_overload_match): Remove use of null_cleanup, and
3488         calls to do_cleanups.
3489
3490 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3491
3492         * compile/compile-cplus-types.c
3493         (compile_cplus_instance::decl_name): Handle changes to
3494         cp_func_name.
3495         * cp-support.c (cp_func_name): Update header comment, update
3496         return type.
3497         * cp-support.h (cp_func_name): Update return type in declaration.
3498         * valops.c (find_overload_match): Move temp_func local to top
3499         level of function and change its type.  Use temp_func to hold and
3500         delete temporary string obtained from cp_func_name.
3501
3502 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3503
3504         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3505         gdb::char_vector, remove cleanup, and update uses of `msg`.
3506
3507 2019-01-03  Jim Wilson  <jimw@sifive.com>
3508
3509         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3510
3511 2019-01-02  Tom Tromey  <tom@tromey.com>
3512
3513         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3514         (tdesc_parse_xml): Remove cleanups.
3515         * target-descriptions.h (make_cleanup_free_target_description):
3516         Don't declare.
3517         (target_desc_deleter): New struct.
3518         (target_desc_up): New typedef.
3519         * target-descriptions.c (target_desc_deleter::operator()): Rename
3520         from free_target_description.
3521         (make_cleanup_free_target_description): Remove.
3522
3523 2019-01-02  Tom Tromey  <tom@tromey.com>
3524
3525         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3526         constructor, destructor.
3527         (linespec_parser): Remove typedef.
3528         (~linespec_parser): Rename from linespec_parser_delete.
3529         (linespec_lex_to_end, linespec_complete_label)
3530         (linespec_complete): Update.
3531         (decode_line_full): Remove cleanups.
3532         (decode_line_1): Update.
3533
3534 2019-01-02  Tom Tromey  <tom@tromey.com>
3535
3536         * python/python-internal.h (inferior_to_inferior_object): Change
3537         return type.
3538         * python/py-exitedevent.c (create_exited_event_object): Update.
3539         * python/py-inferior.c (inferior_to_inferior_object): Return
3540         gdbpy_ref.
3541         (python_new_inferior, python_inferior_deleted)
3542         (thread_to_thread_object, delete_thread_object)
3543         (build_inferior_list, gdbpy_selected_inferior): Update.
3544         * python/py-infthread.c (create_thread_object): Update.  Also fail
3545         if inferior_to_inferior_object fails.
3546
3547 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3548
3549         * inferior.h (class inferior) <displaced_step_state>: New field.
3550         * infrun.h (struct displaced_step_state): Move here from
3551         infrun.c.  Initialize fields, add constructor.
3552         <inf>: Remove field.
3553         <reset>: New method.
3554         * infrun.c (struct displaced_step_inferior_state): Move to
3555         infrun.h.
3556         (displaced_step_inferior_states): Remove.
3557         (get_displaced_stepping_state): Adust.
3558         (displaced_step_in_progress_any_inferior): Adjust.
3559         (displaced_step_in_progress_thread): Adjust.
3560         (displaced_step_in_progress): Adjust.
3561         (add_displaced_stepping_state): Remove.
3562         (get_displaced_step_closure_by_addr): Adjust.
3563         (remove_displaced_stepping_state): Remove.
3564         (infrun_inferior_exit): Call displaced_step_state.reset.
3565         (use_displaced_stepping): Don't check for NULL.
3566         (displaced_step_prepare_throw): Call
3567         get_displaced_stepping_state.
3568         (displaced_step_fixup): Don't check for NULL.
3569         (prepare_for_detach): Don't check for NULL.
3570
3571 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3572
3573         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3574          in case of call that did not complete.
3575
3576 2019-01-02  Andrey Utkin  <autkin@undo.io>
3577
3578         * symfile.c (find_separate_debug_file): Fix search of debug files for
3579         remote debuggee.
3580
3581 2019-01-02  Tom Tromey  <tom@tromey.com>
3582
3583         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3584         indentation.
3585         * python/py-frame.c (frapy_older): Remove cast.
3586         (frapy_newer): Likewise.
3587         * python/py-breakpoint.c (local_setattro): Remove cast.
3588         * python/py-arch.c (archpy_name): Remove local variable.
3589         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3590
3591 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3592
3593         * unittests/basic_string_view/element_access/char/empty.cc:
3594         Fix year range in copyright header.
3595
3596 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3597
3598         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3599         Delete.
3600         <operator==>: Update with for removed field.
3601         <hash>: Likewise.
3602         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3603         <isa_features>: ...this.
3604         <abi_features>: New field.
3605         (riscv_isa_flen): Update comment.
3606         (riscv_abi_xlen): New declaration.
3607         (riscv_abi_flen): New declaration.
3608         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3609         isa_features.
3610         (riscv_abi_xlen): New function.
3611         (riscv_isa_flen): Update to get answer from isa_features.
3612         (riscv_abi_flen): New function.
3613         (riscv_has_fp_abi): Update to get answer from abi_features.
3614         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3615         xlen and flen.
3616         (riscv_call_info) <xlen, flen>: Update comment.
3617         (riscv_call_arg_struct): Remove invalid assertions
3618         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3619         is removed.
3620         (riscv_gdbarch_init): Gather isa features and abi features
3621         separately, ensure both match on the gdbarch when reusing an old
3622         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3623         a target with 64-bit float hardware.
3624
3625 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3626
3627         * source.c (search_command_helper): Stop reverse search
3628         when line 1 has been searched.
3629
3630 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3631
3632         * record-full.c (record_full_base_target::close): Rewrite
3633         record_full_core_buf_list free logic.
3634
3635 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3636
3637         * break-catch-syscall.c (print_one_catch_syscall): xfree
3638         the last text.
3639
3640 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3641
3642         * top.c (print_gdb_version): Update Copyright year in version
3643         message.
3644
3645 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3646
3647         Update copyright year range in all GDB files.
3648
3649 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3650
3651         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3652
3653 For older changes see ChangeLog-2018.
3654 \f
3655 Local Variables:
3656 mode: change-log
3657 left-margin: 8
3658 fill-column: 74
3659 version-control: never
3660 coding: utf-8
3661 End:
3662