gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.c (tui_display_main)
   4         (tui_update_source_windows_with_addr)
   5         (tui_update_all_breakpoint_info): Update.
   6         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
   7         (new_height_ok, parse_scrolling_args): Update.
   8         * tui/tui-stack.c (tui_show_frame_info): Update.
   9         * tui/tui-data.h (struct tui_list): Remove.
  10         (tui_source_windows): Return a reference to a std::vector.
  11         * tui/tui-data.c (source_windows): Now a std::vector.
  12         (tui_source_windows): Change return type.
  13         (tui_clear_source_windows): Rewrite.
  14         (tui_clear_source_windows_detail, tui_add_to_source_windows)
  15         (tui_free_all_source_wins_content): Rewrite.
  16
  17 2019-06-25  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
  20         (struct tui_data_window, struct tui_cmd_window): Declare
  21         clear_detail method.
  22         * tui/tui-data.c (tui_source_window::clear_detail)
  23         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
  24         methods.
  25         (tui_clear_win_detail): Simplify.
  26
  27 2019-06-25  Tom Tromey  <tom@tromey.com>
  28
  29         * tui/tui-layout.c (make_source_window, make_disasm_window)
  30         (make_source_or_disasm_window): Remove win_info_ptr parameter.
  31         Return the new window.
  32         (show_source_disasm_command, show_data)
  33         (show_source_or_disasm_and_command): Update.
  34
  35 2019-06-25  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
  38         parameter.  Return the new window.
  39         (show_source_disasm_command): Update and remove NULL check.
  40         (show_source_or_disasm_and_command): Update.
  41
  42 2019-06-25  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
  45
  46 2019-06-25  Tom Tromey  <tom@tromey.com>
  47
  48         * tui/tui-data.h (struct tui_win_info): Make constructor
  49         protected.  Make destructor virtual.  Add initializers.
  50         (tui_source_window, tui_data_window, tui_cmd_window): New
  51         classes.
  52         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
  53         constructor.  Add "type" parameter.
  54         (tui_source_window, tui_data_window, tui_cmd_window): New
  55         constructors.
  56         (tui_alloc_win_info): Instantiate the appropriate subclass.
  57
  58 2019-06-25  Tom Tromey  <tom@tromey.com>
  59
  60         * tui/tui-win.c (tui_resize_all): Use delete.
  61         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
  62         destructor.
  63         (tui_free_window): Don't declare.
  64         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
  65         Update.
  66
  67 2019-06-25  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui-data.h (struct tui_win_info): Add constructor.
  70         * tui/tui-data.c (tui_alloc_win_info): Use new.
  71         (tui_free_window): Use delete.
  72
  73 2019-06-22  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
  76         declare.
  77         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
  78
  79 2019-06-22  Tom Tromey  <tom@tromey.com>
  80
  81         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
  82         declare.
  83         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
  84
  85 2019-06-22  Tom de Vries  <tdevries@suse.de>
  86
  87         * dwarf2read.c (create_addrmap_from_aranges)
  88         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
  89         instead of '%zu'.
  90
  91 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
  92
  93         * dwarf2read.h (dwarf2_section_info_def): Remove.
  94         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
  95         * dwarf2read.c (struct dwo_sections) <types>: Change type to
  96         std::vector<dwarf2_section_info>.
  97         (struct dwo_file) <~dwo_file>: Remove.
  98         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
  99         types field.
 100         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 101         (dwarf2_read_debug_names): Likewise.
 102         (create_debug_types_hash_table): Change parameter type to
 103         array_view, adjust code accordingly.
 104         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 105         (partial_die_info::fixup): Likewise.
 106         (determine_prefix): Likewise.
 107         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 108
 109 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 110
 111         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 112         gdb_bfd_ref_ptr.
 113         <~dwo_file>: Remove call to gdb_bfd_unref.
 114         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 115         gdb_bfd_ref_ptr::get.
 116
 117 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 118
 119         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 120         type to htab_up.
 121         * dwarf2read.c (struct dwo_file): Initialize fields.
 122         <~dwo_file>: New.
 123         (free_dwo_file): Remove, move content to ~dwo_file.
 124         (struct dwo_file_deleter): Remove.
 125         (dwo_file_up>: Remove custom deleter.
 126         (free_dwo_files): Remove.
 127         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 128         dwo_files.
 129         (process_skeletonless_type_units): Call unique_ptr::get.
 130         (allocate_dwo_file_hash_table): Add deleter to created hash
 131         table.  Change return type to htab_up.
 132         (lookup_dwo_file_slot): Don't memset dwo_file, call
 133         unique_ptr::get.
 134         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 135         (create_dwo_unit_in_dwp_v2): Likewise.
 136         (open_and_init_dwo_file): Likewise.
 137         (free_dwo_file_from_slot): Remove.
 138
 139 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 140
 141         * dwarf2read.h (struct dwarf2_section_info) <readin,
 142         is_virtual>: Change type to bool.
 143         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 144         true instead of 1.
 145
 146 2019-06-19  Tom Tromey  <tom@tromey.com>
 147
 148         * tui/tui-data.h (tui_init_content_element): Don't declare.
 149
 150 2019-06-19  Tom Tromey  <tom@tromey.com>
 151
 152         * tui/tui-data.h (tui_init_win_info): Don't declare.
 153
 154 2019-06-19  Tom de Vries  <tdevries@suse.de>
 155
 156         * dwarf2read.h (abstract_to_concrete): Change type to
 157         std::unordered_map<sect_offset, std::vector<sect_offset>,
 158         gdb::hash_enum<sect_offset>>.
 159
 160 2019-06-19  Tom Tromey  <tromey@adacore.com>
 161
 162         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 163         EVAL_AVOID_SIDE_EFFECTS specially.
 164
 165 2019-06-19  Tom Tromey  <tromey@adacore.com>
 166
 167         * source-cache.c (highlighter): New global.
 168         (source_cache::get_source_lines): Create a highlighter on demand.
 169
 170 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 171
 172         * defs.h (deprecated_interactive_hook): Delete declaration.
 173         * interps.c (clear_interpreter_hooks): Remove use of
 174         deprecated_interactive_hook.
 175         * top.c (deprecated_interactive_hook): Delete definition.
 176         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 177
 178 2019-06-18  Tom de Vries  <tdevries@suse.de>
 179
 180         PR gdb/24515
 181         * dwarf2read.h (abstract_to_concrete): Change type from
 182         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 183         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 184         * dwarf2read.c (read_variable): Update.
 185         (dwarf2_fetch_die_loc_sect_off): Update.
 186
 187 2019-06-17  Tom de Vries  <tdevries@suse.de>
 188
 189         PR gdb/24617
 190         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 191         accessing parent[parent_len - 1].
 192
 193 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 194
 195         PR gdb/24364
 196         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 197         call dtrace_process_dof with NULL dof.
 198
 199 2019-06-16  Tom de Vries  <tdevries@suse.de>
 200
 201         PR gdb/24445
 202         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 203
 204 2019-06-16  Tom Tromey  <tom@tromey.com>
 205
 206         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 207         (make_all_visible): Use address of member.
 208
 209 2019-06-16  Tom Tromey  <tom@tromey.com>
 210
 211         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 212         (tui_free_window, free_content, free_content_elements): Remove
 213         unnecessary cast.
 214         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 215         cast.
 216         * tui/tui-regs.c (tui_show_register_group)
 217         (tui_display_registers_from, tui_display_reg_element_at_line):
 218         Remove unnecessary cast.
 219
 220 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 221
 222         * linux-nat.c (normal_mask): Delete.
 223         (_initialize_linux_nat): Don't initialise normal_mask.
 224
 225 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 226
 227         PR gdb/24445
 228         * dwarf-index-write.h (write_psymtabs_to_index): Add
 229         dwz_basename parameter.
 230         * dwarf-index-write.c (write_gdbindex): Move file writing to
 231         write_gdbindex_1.  Change return type void.
 232         (assert_file_size): Move up, remove filename parameter.
 233         (write_gdbindex_1): New function.
 234         (write_debug_names): Change return type to void, call
 235         assert_file_size.
 236         (struct index_wip_file): New struct.
 237         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 238         file logic to index_wip_file.  Write index for dwz file if
 239         needed.
 240         (save_gdb_index_command): Pass basename of dwz file, if present.
 241         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 242         build-id of dwz file, if present.
 243         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 244         (dwarf2_get_dwz_file): Likewise.
 245         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 246         (dwarf2_get_dwz_file): Likewise.
 247
 248 2019-06-16  Tom Tromey  <tom@tromey.com>
 249
 250         * coffread.c (process_coff_symbol): Use xstrdup.
 251         * value.c (create_internalvar): Use xstrdup.
 252
 253 2019-06-16  Tom Tromey  <tom@tromey.com>
 254
 255         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 256         * breakpoint.c (stopin_command, stopat_command)
 257         (until_break_command, decode_location_default): Remove unnecessary
 258         cast.
 259         * utils.c (subset_compare): Remove unnecessary cast.
 260         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 261         cast.
 262         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 263         cast.
 264         * infcmd.c (path_command): Remove unnecessary cast.
 265         * coffread.c (decode_type): Remove unnecessary cast.
 266         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 267         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 268         * tui/tui-stack.c (tui_show_locator_content)
 269         (tui_show_frame_info): Remove unnecessary cast.
 270         * tui/tui-win.c (tui_scroll_forward_command)
 271         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 272         (parse_scrolling_args): Remove unnecessary cast.
 273         * tui/tui-data.c (init_win_info, tui_del_window)
 274         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 275         (free_content_elements): Remove unnecessary cast.
 276         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 277         unnecessary cast.
 278         * tui/tui-source.c (tui_set_source_content)
 279         (tui_vertical_source_scroll): Remove unnecessary cast.
 280         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 281         cast.
 282         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 283         * tui/tui-regs.c (tui_display_registers_from)
 284         (tui_display_register): Remove unnecessary cast.
 285         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 286         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 287         (make_visible): Remove unnecessary cast.
 288         * tui/tui-winsource.c (tui_erase_source_content)
 289         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 290         unnecessary cast.
 291         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 292         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 293         * stabsread.c (read_type, read_array_type, read_range_type):
 294         Remove unnecessary cast.
 295         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 296         (parse_symbol, parse_type, upgrade_type, parse_external)
 297         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 298         unnecessary cast.
 299         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 300
 301 2019-06-16  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-data.c (tui_alloc_generic_win_info)
 304         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 305         checks.
 306
 307 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 308             Andrew Burgess  <andrew.burgess@embecosm.com>
 309
 310         * f-typeprint.c (f_print_type): Don't return early for not
 311         associated or not allocated types.
 312         (f_type_print_varspec_suffix): Add print_rank parameter and print
 313         ranks of array types in case they dangling.
 314         (f_type_print_base): Add print_rank parameter.
 315
 316 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 317
 318         * NEWS: Mention new MI commands.
 319         * break-catch-throw.c (enum exception_event_kind): Move to
 320         breakpoint.h.
 321         (print_mention_exception_catchpoint): Output text as a single
 322         message.
 323         (catch_exception_command_1): Rename to...
 324         (catch_exception_event): ...this, make non-static, update header
 325         command, and change some parameter types.
 326         (catch_catch_command): Update for changes to
 327         catch_exception_command_1.
 328         (catch_throw_command): Likewise.
 329         (catch_rethrow_command): Likewise.
 330         * breakpoint.c (enum exception_event_kind): Delete.
 331         * breakpoint.h (enum exception_event_kind): Moved here from
 332         break-catch-throw.c.
 333         (catch_exception_event): Declare.
 334         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 335         (mi_cmd_catch_throw): New function.
 336         (mi_cmd_catch_rethrow): New function.
 337         (mi_cmd_catch_catch): New function.
 338         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 339         'catch-catch' entries.
 340         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 341         (mi_cmd_catch_rethrow): Declare.
 342         (mi_cmd_catch_catch): Declare.
 343
 344 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 345
 346         * annotate.c (annotate_source_line): Change return type to void,
 347         update implementation to match.
 348         * annotate.h (annotate_source_line): Change return type to void,
 349         update header comment.
 350         * stack.c (print_frame_info): Don't change what frame information
 351         is printed based on whether annotations are on or not.
 352
 353 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 354
 355         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 356         (annotate_source): Make static.
 357         (annotate_source_line): Moved from source.c and renamed from
 358         identify_source_line.  Update the return type.
 359         * annotate.h (annotate_source): Delete declaration.
 360         (annotate_source_line): Declaration moved from source.h, and
 361         renamed from identify_source_line.  Return type updated.
 362         * source.c (identify_source_line): Moved to annotate.c and renamed
 363         to annotate_source_line.
 364         (info_line_command): Remove check of annotation_level.
 365         * source.h (identify_source_line): Move declaration to annotate.h
 366         and rename to annotate_source_line.
 367         * stack.c: Add 'annotate.h' include.
 368         (print_frame_info): Remove check of annotation_level before
 369         calling annotate_source_line.
 370
 371 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 372
 373         * source-cache.c (source_cache::get_plain_source_lines): Use
 374         open_source_file_with_line_charpos instead of just
 375         open_source_file, remove call to find_source_lines.
 376         (source_cache::get_source_lines): Likewise.
 377         * source.c (find_source_lines): Make static.
 378         (get_filename_and_charpos): Renamed into...
 379         (open_source_file_with_line_charpos): ..this along with changes to
 380         return a scoped_fd, and some other minor clean ups.
 381         (identify_source_line): Use open_source_file_with_line_charpos.
 382         (search_command_helper): Use open_source_file_with_line_charpos
 383         instead of just open_source_file, remove call to
 384         find_source_lines.
 385         * source.h (open_source_file_with_line_charpos): Declare new
 386         function.
 387         (find_source_lines): Delete declaration.
 388
 389 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 390
 391         * source.c (get_filename_and_charpos): Remove fullname
 392         parameter.
 393         (identify_source_line): Update call to get_filename_and_charpos.
 394
 395 2019-06-14  Tom Tromey  <tromey@adacore.com>
 396
 397         PR gdb/24502:
 398         * ui-style.h (skip_ansi_escape): Update comment.
 399         * ui-file.h (class no_terminal_escape_file): New class.
 400         * ui-file.c (no_terminal_escape_file::write)
 401         (no_terminal_escape_file::puts): New methods.
 402         * cli/cli-logging.c (handle_redirections): Use
 403         no_terminal_escape_file.
 404
 405 2019-06-14  Tom Tromey  <tromey@adacore.com>
 406
 407         * NEWS: Move convenience variable news above Python news.
 408
 409 2019-06-14  Tom Tromey  <tom@tromey.com>
 410
 411         * gnulib: Move directory to top-level.
 412         * configure.ac: Don't configure gnulib.
 413         * configure: Rebuild.
 414         * common/common-defs.h: Use new path to gnulib.
 415         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 416         (GNULIB_H): Remove.
 417         (INCGNU): Look in new gnulib location.
 418         (HFILES_NO_SRCDIR): Remove gnulib files.
 419         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 420         (generated_files): Remove GNULIB_H.
 421         ($(LIBGNU), all-lib): Remove targets.
 422         (distclean): Don't mention GNULIB_BUILDDIR.
 423         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 424
 425 2019-06-14  Tom Tromey  <tromey@adacore.com>
 426
 427         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 428         Warn if symbol file does not provide any symbols.
 429
 430 2019-06-14  Tom Tromey  <tromey@adacore.com>
 431
 432         * source.c (find_and_open_source): Respect basenames_may_differ.
 433
 434 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 435
 436         * annotate.c (annotate_breakpoints_invalid): Make use of
 437         scoped_restore_terminal_state.
 438         (annotate_frames_invalid): Likewise.
 439
 440 2019-06-14  Tom Tromey  <tromey@adacore.com>
 441
 442         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 443         allow assignment to an internalvar.
 444
 445 2019-06-14  Tom Tromey  <tromey@adacore.com>
 446
 447         * ada-lex.l: Allow "_" in attribute names.
 448
 449 2019-06-14  Tom Tromey  <tromey@adacore.com>
 450
 451         PR gdb/24653:
 452         * regcache.c (registers_changed): Don't call alloca.
 453         * top.c (execute_command): Don't call alloca.
 454
 455 2019-06-13  Pedro Alves  <palves@redhat.com>
 456
 457         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 458         'expression'.  When parsing an expression, error out if there's
 459         junk after "unlimited".
 460         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 461         (do_set_command): Adjust calls to is_unlimited_literal.
 462
 463 2019-06-13  Pedro Alves  <palves@redhat.com>
 464
 465         * compile/compile.c (make_compile_options_def_group): Add braces
 466         around array_view initializer.
 467         * thread.c (make_thread_apply_all_options_def_group)
 468         (make_thread_apply_all_options_def_group): Likewise.
 469
 470 2019-06-13  Pedro Alves  <palves@redhat.com>
 471
 472         * NEWS (New commands): Mention "maint test-options
 473         require-delimiter", "maint test-options unknown-is-error", "maint
 474         test-options unknown-is-operand" and "maint show
 475         test-options-completion-result".
 476         (New command options, command completion): New section.
 477         (Completion improvements): New section.
 478         Mention that you can abbreviate "unlimited".
 479
 480 2019-06-13  Pedro Alves  <palves@redhat.com>
 481
 482         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 483         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 484         * unittests/cli-utils-selftests.c (test_parse_flags)
 485         (test_parse_flags_qcs): Delete.
 486         (test_cli_utils): Don't call deleted functions.
 487
 488 2019-06-13  Pedro Alves  <palves@redhat.com>
 489
 490         * thread.c: Include "cli/cli-option.h".
 491         (tp_array_compar_ascending): Global.
 492         (tp_array_compar): Delete function.
 493         (tp_array_compar_ascending, tp_array_compar_descending): New
 494         functions.
 495         (ascending_option_def, qcs_flag_option_def)
 496         (thr_qcs_flags_option_defs)
 497         (make_thread_apply_all_options_def_group)
 498         (make_thread_apply_options_def_group): New.
 499         (thread_apply_all_command): Use gdb::option::process_options.
 500         (thread_apply_command_completer)
 501         (thread_apply_all_command_completer): New.
 502         (thread_apply_command): Use gdb::option::process_options.
 503         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 504         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 505         to generate help text of "thread apply".  Adjust "taas"'s help.
 506         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 507         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 508
 509 2019-06-13  Pedro Alves  <palves@redhat.com>
 510
 511         * thread.c (thread_apply_command): Check for invalid TID with
 512         isdigit instead of !isalpha.
 513
 514 2019-06-13  Pedro Alves  <palves@redhat.com>
 515
 516         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 517         (validate_flags_qcs): New.
 518         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 519         (validate_flags_qcs): Declare.
 520         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 521         (make_frame_apply_options_def_group): New.
 522         (frame_apply_command_count): Process options with
 523         gdb::option::process_options.
 524         (frame_apply_completer): New.
 525         (frame_apply_level_completer, frame_apply_all_completer)
 526         (frame_apply_completer): New.
 527         (_initialize_stack): Update help of "frame apply", "frame apply
 528         level", "frame apply all" and "faas" to mention supported options
 529         and install command completers.
 530         * stack.h (frame_apply_all_completer): Declare.
 531         * thread.c: Include "stack.h".
 532         (tfaas_command): Add "--".
 533         (_initialize_thread): Update help "tfaas" to mention supported
 534         options and install command completer.
 535
 536 2019-06-13  Pedro Alves  <palves@redhat.com>
 537
 538         * completer.c (complete_nested_command_line): New.
 539         (gdb_completion_word_break_characters_throw): Add assertion.
 540         * completer.h (complete_nested_command_line): Declare.
 541
 542 2019-06-13  Pedro Alves  <palves@redhat.com>
 543
 544         * stack.c (parse_backtrace_qualifiers): New.
 545         (backtrace_command): Use it.
 546         (backtrace_command_completer): Complete on qualifiers.
 547
 548 2019-06-13  Pedro Alves  <palves@redhat.com>
 549
 550         * frame.c: Include "cli/cli-option.h.
 551         (user_set_backtrace_options): New.
 552         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 553         Delete.
 554         (get_prev_frame): Adjust.
 555         (boolean_option_def, uinteger_option_def)
 556         (set_backtrace_option_defs): New.
 557         (_initialize_frame): Adjust and use
 558         gdb::option::add_setshow_cmds_for_options to install "set
 559         backtrace past-main" and "set backtrace past-entry".
 560         * frame.h: Include "cli/cli-option.h".
 561         (struct frame_print_options): Forward declare.
 562         (print_frame_arguments_all, print_frame_arguments_scalars)
 563         (print_frame_arguments_none): Declare.
 564         (print_entry_values): Delete declaration.
 565         (struct frame_print_options, user_frame_print_options): New.
 566         (struct set_backtrace_options): New.
 567         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 568         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 569         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 570         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 571         (list_args_or_locals): Add frame_print_options parameter.
 572         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 573         * python/py-framefilter.c (enumerate_args): Pass down
 574         USER_FRAME_PRINT_OPTIONS.
 575         * stack.c: Include "cli/cli-option.h".
 576         (print_frame_arguments_all, print_frame_arguments_scalars)
 577         (print_frame_arguments_none): Declare.
 578         (print_raw_frame_arguments, print_entry_values): Delete.
 579         (user_frame_print_options): New.
 580         (boolean_option_def, enum_option_def, frame_print_option_defs):
 581         New.
 582         (struct backtrace_cmd_options): New.
 583         (bt_flag_option_def): New.
 584         (backtrace_command_option_defs): New.
 585         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 586         (print_frame_arg, read_frame_arg, print_frame_args)
 587         (print_frame_info, print_frame): Add frame_print_options parameter
 588         and use it.
 589         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 590         (backtrace_command_1): Add frame_print_options and
 591         backtrace_cmd_options parameters and use them.
 592         (make_backtrace_options_def_group): New.
 593         (backtrace_command): Process command options with
 594         gdb::option::process_options.
 595         (backtrace_command_completer): New.
 596         (_initialize_stack): Extend "backtrace"'s help to mention
 597         supported options.  Install completer for "backtrace".
 598         Install some settings commands with add_setshow_cmds_for_options.
 599
 600 2019-06-13  Pedro Alves  <palves@redhat.com>
 601
 602         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 603         and that "set/show print raw frame-arguments" are now deprecated.
 604
 605         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 606         command.
 607         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 608         * stack.c (_initialize_stack): Install "set/show print
 609         raw-frame-arguments", and deprecate "set/show print raw
 610         frame-arguments".
 611         * valprint.c (_initialize_valprint): Deprecate "set/show print
 612         raw".
 613
 614 2019-06-13  Pedro Alves  <palves@redhat.com>
 615
 616         * compile/compile.c (struct compile_options): New.
 617         (compile_flag_option_def, compile_command_option_defs)
 618         (make_compile_options_def_group): New.
 619         (compile_file_command): Handle options with
 620         gdb::option::process_options.
 621         (compile_file_command_completer): New function.
 622         (compile_code_command): Handle options with
 623         gdb::option::process_options.
 624         (compile_code_command_completer): New function.
 625         (_initialize_compiler): Install completers for "compile code" and
 626         "compile file".  Mention available options in "compile code" and
 627         "compile code"'s help.
 628         * completer.c (advance_to_completion_word): New, factored out from
 629         ...
 630         (advance_to_expression_complete_word_point): ... this.
 631         (advance_to_filename_complete_word_point): New.
 632         * completer.h (advance_to_filename_complete_word_point): New
 633         declaration.
 634
 635 2019-06-13  Pedro Alves  <palves@redhat.com>
 636
 637         * compile/compile.c: Include "cli/cli-option.h".
 638         (compile_print_value): Scope data pointer is now a
 639         value_print_options pointer; adjust.
 640         (compile_print_command): Process options.  Scope data pointer is
 641         now a value_print_options pointer; adjust.
 642         (_initialize_compile): Update "compile print"'s help to include
 643         supported options.  Install a completer for "compile print".
 644         * cp-valprint.c (show_vtblprint, show_objectprint)
 645         (show_static_field_print): Delete.
 646         (_initialize_cp_valprint): Don't install "set print
 647         static-members", "set print vtbl", "set print object" here.
 648         * printcmd.c: Include "cli/cli-option.h" and
 649         "common/gdb_optional.h".
 650         (print_command_parse_format): Rework to fill in a
 651         value_print_options instead of a format_data.
 652         (print_value): Change parameter type from format_data pointer to
 653         value_print_options reference.  Adjust.
 654         (print_command_1): Process options.  Adjust to pass down a
 655         value_print_options.
 656         (print_command_completer): New.
 657         (_initialize_printcmd): Install print_command_completer as
 658         handle_brkchars completer for the "print" command.  Update
 659         "print"'s help to include supported options.
 660         * valprint.c: Include "cli/cli-option.h".
 661         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 662         here from cp-valprint.c.
 663         (boolean_option_def, uinteger_option_def)
 664         (value_print_option_defs, make_value_print_options_def_group):
 665         New.  Use gdb::option::add_setshow_cmds_for_options to install
 666         "set print elements", "set print null-stop", "set print repeats",
 667         "set print pretty", "set print union", "set print array", "set
 668         print address", "set print symbol", "set print array-indexes".
 669         * valprint.h: Include <string> and "cli/cli-option.h".
 670         (make_value_print_options_def_group): Declare.
 671         (print_value): Change parameter type from format_data pointer to
 672         value_print_options reference.
 673         (print_command_completer): Declare.
 674
 675 2019-06-13  Pedro Alves  <palves@redhat.com>
 676
 677         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 678         (COMMON_SFILES): Add maint-test-settings.c.
 679         * cli/cli-decode.c (boolean_enums): New global, factored out from
 680         ...
 681         (add_setshow_boolean_cmd): ... here.
 682         * cli/cli-decode.h (boolean_enums): Declare.
 683         * cli/cli-option.c: New file.
 684         * cli/cli-option.h: New file.
 685         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 686         factored out from ...
 687         (parse_cli_boolean_value(const char *)): ... this.
 688         (is_unlimited_literal): Change parameter type to pointer to
 689         pointer.  Adjust and advance ARG pointer.
 690         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 691         (parse_cli_var_enum): New, factored out from ...
 692         (do_set_command): ... this.  Adjust.
 693         * cli/cli-setshow.h (parse_cli_boolean_value)
 694         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 695         (parse_cli_var_enum): Declare.
 696         * cli/cli-utils.c: Include "cli/cli-option.h".
 697         (get_ulongest): New.
 698         * cli/cli-utils.h (get_ulongest): Declare.
 699         (check_for_argument): New overloads.
 700         * maint-test-options.c: New file.
 701
 702 2019-06-13  Pedro Alves  <palves@redhat.com>
 703
 704         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 705         parse a range if "-" is at the end of the string.
 706
 707 2019-06-13  Pedro Alves  <palves@redhat.com>
 708
 709         * cli/cli-setshow.c (parse_auto_binary_operation)
 710         (parse_cli_boolean_value): Don't allow "o".
 711
 712 2019-06-13  Pedro Alves  <palves@redhat.com>
 713
 714         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 715         * NEWS: Mention maint test-settings KIND.
 716         * maint-test-settings.c: New file.
 717
 718 2019-06-13  Pedro Alves  <palves@redhat.com>
 719
 720         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 721         completer.
 722         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 723         "set" completers.
 724
 725 2019-06-13  Pedro Alves  <palves@redhat.com>
 726
 727         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 728         after item.
 729
 730 2019-06-13  Pedro Alves  <palves@redhat.com>
 731
 732         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 733
 734 2019-06-13  Pedro Alves <palves@redhat.com>
 735
 736         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 737         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 738         call.
 739         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 740         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 741         calls.
 742         (check_for_argument): Skip spaces after argument.
 743
 744 2019-06-13  Pedro Alves  <palves@redhat.com>
 745
 746         * thread.c (thread_apply_command): Adjust TID parsing.
 747         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 748         detected before end of string.
 749         (tid_is_in_list): Error out if LIST is invalid.
 750
 751 2019-06-13  Pedro Alves  <palves@redhat.com>
 752
 753         * completer.c (complete_line_internal_1): Rewind completion word
 754         point.
 755         (completion_tracker::advance_custom_word_point_by): Change
 756         parameter type to int.
 757         * completer.h (completion_tracker::advance_custom_word_point_by):
 758         Likewise.
 759
 760 2019-06-13  Pedro Alves  <palves@redhat.com>
 761
 762         * completer.c (advance_to_completion_word): Handle delimiters.
 763
 764 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 765
 766         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 767
 768 2019-06-11  Tom Tromey  <tom@tromey.com>
 769
 770         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 771         (xmalloc_failed): Move to alloc.c.
 772         * alloc.c: New file.
 773         * Makefile.in (COMMON_SFILES): Add alloc.c.
 774
 775 2019-06-11  Tom Tromey  <tom@tromey.com>
 776
 777         * nat/linux-waitpid.c: Don't include server.h.
 778         (linux_debug): Remove.
 779         (my_waitpid): Update.
 780
 781 2019-06-11  Tom Tromey  <tromey@adacore.com>
 782
 783         * infcall.c (_initialize_infcall): Remove trailing newline from
 784         help.
 785         * user-regs.c (_initialize_user_regs): Remove trailing newline
 786         from help.
 787         * typeprint.c (_initialize_typeprint): Remove trailing newline
 788         from help.
 789         * reverse.c (_initialize_reverse): Remove trailing newlines from
 790         help.
 791         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 792         from help.
 793         * language.c (add_set_language_command): Remove trailing newline
 794         from help.
 795         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 796         help.
 797         * disasm.c (_initialize_disasm): Remove trailing newline from
 798         help.
 799         * top.c (init_main): Remove trailing newline from help.
 800         * interps.c (_initialize_interpreter): Remove trailing newline
 801         from help.
 802         * btrace.c (_initialize_btrace): Remove trailing newlines from
 803         help.
 804         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 805         from help.
 806         * python/python.c (_initialize_python): Remove trailing newline
 807         from help.
 808         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 809         help.
 810         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 811         from help.  Reformat some text.
 812         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 813         from help.
 814         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 815         newline from help.
 816
 817 2019-06-11  Tom Tromey  <tromey@adacore.com>
 818
 819         * darwin-nat.c (darwin_decode_exception_message)
 820         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 821
 822 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 823
 824         * valops.c (value_slice): Check for not allocated or not
 825         associated values.
 826
 827 2019-06-10  Tom de Vries  <tdevries@suse.de>
 828
 829         PR gdb/24618
 830         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 831         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 832         invalid.
 833
 834 2019-06-10  Tom de Vries  <tdevries@suse.de>
 835
 836         PR gdb/24611
 837         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 838         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 839
 840 2019-06-10  Tom de Vries  <tdevries@suse.de>
 841
 842         PR symtab/24545
 843         * symtab.c (struct demangled_name_entry): Add language field.
 844         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 845         static minimal symbol".  Set and use language field.
 846
 847 2019-06-10  Tom Tromey  <tromey@adacore.com>
 848
 849         * ada-lang.c (_initialize_ada_language): Update help text.
 850
 851 2019-06-10  Tom Tromey  <tromey@adacore.com>
 852
 853         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 854         with a newline.
 855         * guile/guile.c (handle_boot_error): Don't end warning with a
 856         newline.
 857         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 858         warning with a newline.
 859         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 860         newline.
 861         (s12z_frame_cache): Likewise.
 862         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 863         a newline.
 864         * solib-svr4.c (disable_probes_interface): Don't end warning with
 865         a newline.
 866         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 867         newline.
 868         * python/python.c (do_finish_initialization): Don't end warning
 869         with a newline.
 870
 871 2019-06-10  Tom Tromey  <tom@tromey.com>
 872
 873         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 874         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 875         gdbpy_enter.
 876
 877 2019-06-10  Tom Tromey  <tromey@adacore.com>
 878
 879         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 880         data.
 881         (elf_new_init): Don't call stabsread_new_init.
 882         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 883         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 884         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 885
 886 2019-06-10  Tom de Vries  <tdevries@suse.de>
 887
 888         PR symtab/16264
 889         PR symtab/24517
 890         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 891
 892 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 893
 894         * source.c (find_and_open_source): Also rewrite relative file
 895         names.
 896
 897 2019-04-26  Amos Bird  <amosbird@gmail.com>
 898
 899         * annotate.c (annotate_thread_exited): Add "thread-exited"
 900         annotation.
 901
 902 2019-06-06  Tom Tromey  <tromey@adacore.com>
 903
 904         * maint.h (class scoped_command_stats): Use
 905         DISABLE_COPY_AND_ASSIGN.
 906         <print_time>: New method.
 907         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 908         print_time.
 909         (scoped_command_stats::print_time): New method.
 910
 911 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 912
 913         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 914         instructions of lengths 6 or 8 bytes.
 915
 916 2019-06-04  Pedro Alves  <palves@redhat.com>
 917
 918         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 919
 920         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 921         * breakpoint.c (condition_completer): Likewise.
 922         * cli/cli-dump.c (scan_expression): Likewise.
 923         * common/filestuff.c (mkdir_recursive): Likewise.
 924         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 925         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 926         (gdb_abspath): Likewise.
 927         * compile/compile-cplus-types.c
 928         (compile_cplus_instance::decl_name): Likewise.
 929         * completer.c (complete_explicit_location):
 930         (signal_completer, reg_or_group_completer_1): Likewise.
 931         * cp-support.c (cp_remove_params_if_any): Likewise.
 932         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 933         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 934         * infcmd.c (strip_bg_char): Likewise.
 935         * linespec.c (copy_token_string): Likewise.
 936         * mi/mi-main.c (output_cores): Likewise.
 937         * psymtab.c (psymtab_search_name):
 938         * symfile.c (test_set_ext_lang_command): Likewise.
 939         * target.c (target_fileio_read_stralloc): Likewise.
 940         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 941         * value.c (complete_internalvar): Likewise.
 942
 943 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 944
 945         Add objfile property to gdb.Type.
 946         * NEWS: Mention Python API addition.
 947         * python/py-type.c (typy_get_objfile): New method.
 948
 949 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 950
 951         * NEWS: Mention the new set|show style [title|highlight].
 952         Mention changes to "show style", "help" and "apropos".
 953
 954 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 955
 956         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 957         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 958         instead of print_help_for_command.
 959         (print_doc_of_command): New function.
 960         (help_list): Add 'apropos -v word' suggestion.
 961         (print_help_for_command): Style the command name using title style.
 962         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 963         (_initialize_cli_cmds): Describe -v in apropos_command help.
 964
 965 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 966
 967         * cli/cli-style.h (cli_style_option): Add name in constructor,
 968         add m_name class member, add constructor with intensity,
 969         add name class function.
 970         (cli_style_option::add_setshow_commands): Remove name argument.
 971         (highlight_style, title_style): New styles.
 972         * cli/cli-style.c (do_show): New function that shows a style
 973         characteristic styling the style name with itself.
 974         (set_style_name): New function.
 975         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 976         Update all callers according to the changes in cli/cli-style.h.
 977         * utils.h (fputs_highlighted): New function.
 978         * utils.c (fputs_highlighted): Likewise.
 979
 980 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 981
 982         * NEWS: Mention new pipe command and new convenience variables.
 983
 984 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 985
 986         * cli/cli-cmds.c (pipe_command): New function.
 987         (_initialize_cli_cmds): Call add_com for pipe_command.
 988         Define | as an alias for pipe.
 989         (exit_status_set_internal_vars): New function.
 990         (shell_escape): Call exit_status_set_internal_vars.
 991         cli/cli-decode.c (find_command_name_length): Recognize | as
 992         a single character command.
 993
 994 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 995
 996         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 997         top.c (execute_command_to_ui_file): New function, mostly a copy
 998         of execute_command_to_string.
 999         (execute_command_to_string): Implement by calling
1000         execute_command_to_ui_file.
1001
1002 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1003
1004         * top.h (saved_command_line): Remove declaration.
1005         * top.c (previous_saved_command_line, previous_repeat_arguments):
1006         New variables.
1007         (saved_command_line): Make static, define together with other
1008         'repeat variables'.
1009         (dont_repeat): Clear repeat_arguments.
1010         (repeat_previous, get_saved_command_line, save_command_line):
1011         New functions.
1012         (gdb_init): Initialize saved_command_line
1013         and previous_saved_command_line.
1014         * main.c (captured_main_1): Remove saved_command_line initialization.
1015         * event-top.c (handle_line_of_input): Update to use
1016         the new 'repeat' related functions instead of direct access to
1017         saved_command_line.
1018         * command.h (repeat_previous, get_saved_command_line,
1019         save_command_line): New declarations.
1020         (dont_repeat): Add comment.
1021
1022 2019-05-30  Tom Tromey  <tromey@adacore.com>
1023
1024         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1025         Fix comment.
1026         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1027
1028 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1029
1030         PR cli/24587
1031         * completer.c (complete): Initialize variable word.
1032
1033 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1034
1035         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1036         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1037         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1038         'body' is NULL to the outter 'if', protecting the '!is_define'
1039         situation as well.
1040
1041 2019-05-29  Tom Tromey  <tromey@adacore.com>
1042
1043         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1044         (dwarf_unknown): New function.
1045         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1046         (dwarf_type_encoding_name): Use dwarf_unknown.
1047
1048 2019-05-29  Tom Tromey  <tromey@adacore.com>
1049
1050         PR c++/20020:
1051         * cp-valprint.c (cp_print_value_fields): Call
1052         cp_print_static_field inside "try".
1053
1054 2019-05-29  Tom Tromey  <tromey@adacore.com>
1055
1056         * inflow.c (struct terminal_info): Add default operator=.
1057         * configure: Rebuild.
1058         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1059         -Wdeprecated-copy-dtor, -Wredundant-move.
1060
1061 2019-05-29  Tom Tromey  <tromey@adacore.com>
1062
1063         * NEWS: Add entry.
1064         * infcmd.c (print_return_value_1): Handle finish_print
1065         option.
1066         (show_print_finish): New function.
1067         (_initialize_infcmd): Add "set/show print finish" commands.
1068         * valprint.c (user_print_options): Initialize new member.
1069         * valprint.h (struct value_print_options) <finish_print>: New
1070         member.
1071
1072 2019-05-28  Tom Tromey  <tromey@adacore.com>
1073
1074         * ada-lang.c (ada_remove_Xbn_suffix)
1075         (find_old_style_renaming_symbol)
1076         (parse_old_style_renaming): Remove.
1077         (ada_find_renaming_symbol): Don't call
1078         find_old_style_renaming_symbol.
1079         (ada_is_renaming_symbol): Rename from
1080         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1081         bool.  Now static.
1082         (ada_read_var_value): Update and simplify.
1083         * ada-exp.y (write_var_or_type): Remove old code.
1084
1085 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1086
1087         * event-top.c: Remove include comment.
1088         * inflow.c (class scoped_ignore_sigttou): Move from here...
1089         * inflow.h (class scoped_ignore_sigttou): ...to here.
1090         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1091         * top.c:  Remove include comment.
1092
1093 2019-05-27  Tom Tromey  <tom@tromey.com>
1094
1095         * NEWS: Fix typo.
1096
1097 2019-05-22  Tom Tromey  <tromey@adacore.com>
1098
1099         * target.c (target_follow_exec): Constify parameter.
1100         * target-delegates.c: Rebuild.
1101         * remote.c (remote_target::follow_exec): Constify parameter.
1102         * infrun.c (follow_exec): Constify parameter.
1103         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1104         (target_follow_exec): Likewise.
1105
1106 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1107
1108         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1109         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1110
1111 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1112
1113         * NEWS: Add debugredirect and testsuite sections.
1114
1115 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1116
1117         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1118         target descriptions using exclusively floating point register name
1119         aliases.
1120
1121 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1122
1123         PR gdb/18644:
1124         * f-lang.c (build_fortran_types): Handle the case where
1125         gdbarch_floatformat_for_type returns a nullptr.
1126
1127 2019-05-21  Tom de Vries  <tdevries@suse.de>
1128
1129         PR cli/24587
1130         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1131
1132 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1133
1134         PR gdb/18644:
1135         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1136         16-byte floats.
1137         * i386-tdep.c (i386_floatformat_for_type): Use
1138         floatformats_ia64_quad for the 16-byte floating point component
1139         within a fortran 32-byte complex number.
1140
1141 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1142
1143         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1144         delete default constructor.
1145         (find_partial_die): Update to return const struct.
1146         (partial_die_parent_scope): Move variable declaration into scope
1147         of its use and change its type to auto.
1148         (guess_partial_die_structure_name): Likewise.
1149         (partial_die_info::fixup): Likewise.
1150
1151 2019-05-17  Tom Tromey  <tromey@adacore.com>
1152
1153         * source.c (find_and_open_source): Remove cast.
1154
1155 2019-05-17  Tom Tromey  <tromey@adacore.com>
1156
1157         * annotate.c (annotate_source): Make "filename" const.
1158         * annotate.h (annotate_source): Use const.
1159
1160 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1161
1162         * disasm.c (set_disassembler_options): Send errors to stderr.
1163
1164 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1165
1166         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1167         (cli_interp_base::set_logging): Check debug_redirect.
1168         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1169         * cli/cli-logging.c (debug_redirect): Add static variable.
1170         (pop_output_files): Add default param.
1171         (handle_redirections): Print debug setting.
1172         (show_logging_command): Likewise.
1173         (_initialize_cli_logging): Add debugredirect command.
1174         * interps.c (current_interp_set_logging): Add debug_redirect
1175         parameter.
1176         * interps.h (set_logging): Add debug_redirect parameter.
1177         (current_interp_set_logging): Likewise.
1178         * mi/mi-common.h: Likewise.
1179         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1180
1181 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1182             Tom Tromey  <tromey@adacore.com>
1183
1184         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1185         directly.
1186         * cli/cli-interp.h (make_logging_output): Remove declaration.
1187         * cli/cli-logging.c (make_logging_output): Remove function.
1188         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1189         directly.
1190         * ui-file.c (tee_file::tee_file): Remove bools.
1191         (tee_file::~tee_file): Remove deletes.
1192         * ui-file.h (tee_file): Remove bools.
1193
1194 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1195
1196         * mi/mi-cmds.h (mi_cmd_complete): New function.
1197         * mi/mi-main.c (mi_cmd_complete): Likewise.
1198         * mi/mi-cmds.c: Define new MI command -complete.
1199         * NEWS: Mention new -complete command.
1200
1201 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1202
1203         * completer.h (complete): New function.
1204         * completer.c (complete): Likewise.
1205         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1206         function defined in completer.h.
1207
1208 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1209
1210         * MAINTAINERS (Write After Approval): Add myself.
1211
1212 2019-05-17  Tom de Vries  <tdevries@suse.de>
1213
1214         PR gdb/24094
1215         * dwarf2read.c (struct cu_partial_die_info): New struct.
1216         (find_partial_die): Return cu_partial_die_info.
1217         (partial_die_parent_scope, guess_partial_die_structure_name)
1218         (partial_die_info::fixup): Handle new return type of find_partial_die.
1219
1220 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1221
1222         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1223         "std::string", simplifying the algorithm.
1224
1225 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1226
1227         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1228         (stap_static_probe_ops::get_probes): Likewise.
1229
1230 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1231
1232         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1233         '-')" and "else if".
1234         (stap_parse_single_operand): Join checks for
1235         "gdbarch_stap_parse_special_token_p" and
1236         "gdbarch_stap_parse_special_token" in the same "if" statement.
1237         Invert check when verifying for operation on register
1238         displacement.
1239
1240 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1241
1242         * stap-probe.c (stap_get_opcode): Update comment.
1243         (stap_get_expected_argument_type): Likewise.
1244         (handle_stap_probe): Likewise.
1245
1246 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1247
1248         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1249         return type to 'bool'.  Adjust comment.  Use 'bool' when
1250         appropriate.
1251         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1252         * stap-probe.c (stap_parse_argument_1): Likewise.
1253         (stap_is_operator): Likewise.
1254         (stap_is_generic_prefix): Likewise.
1255         (stap_is_register_prefix): Likewise.
1256         (stap_is_register_indirection_prefix): Likewise.
1257         (stap_is_integer_prefix): Likewise.
1258         (stap_generic_check_suffix): Likewise.
1259         (stap_check_integer_suffix): Likewise.
1260         (stap_check_register_suffix): Likewise.
1261         (stap_check_register_indirection_suffix): Likewise.
1262         (stap_parse_register_operand): Likewise.
1263         (stap_parse_single_operand): Likewise.
1264         (stap_parse_argument_1): Likewise.
1265         (stap_probe::get_argument_count): Likewise.
1266         (stap_is_operator): Likewise.
1267
1268 2019-05-16  Tom Tromey  <tromey@adacore.com>
1269
1270         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1271         keyword to foreach.
1272
1273 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1274
1275         * linux-thread-db.c (try_thread_db_load_1): Change return type
1276         to bool.
1277         (try_thread_db_load): Likewise.
1278         (try_thread_db_load_from_pdir_1): Likewise.
1279         (try_thread_db_load_from_pdir): Likewise.
1280         (try_thread_db_load_from_sdir): Likewise.
1281         (try_thread_db_load_from_dir): Likewise.
1282         (thread_db_load_search): Likewise.
1283         (has_libpthread): Likewise.
1284         (thread_db_load): Likewise.
1285
1286 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1287
1288         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1289         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1290         NULL, and complain/return if that's the case.
1291
1292 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1293
1294         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1295         (advance, posn, abstract_read_memory): New functions.
1296         [struct mem_read_abstraction]: New struct.
1297         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1298
1299 2019-05-14  Tom Tromey  <tromey@adacore.com>
1300
1301         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1302         value is not lval_memory.
1303
1304 2019-05-14  Tom Tromey  <tromey@adacore.com>
1305
1306         * solib.c (info_sharedlibrary_command): Style the file name.
1307
1308 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1309
1310         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1311         (aarch64_vnv_type): Likewise.
1312         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1313         * common/tdesc.c: Likewise.
1314         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1315         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1316         * features/aarch64-fpu.xml: Add ieee half view.
1317         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1318         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1319         * gdbtypes.h (struct builtin_type): Likewise.
1320         (struct objfile_type): Likewise.
1321
1322 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1323
1324         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1325         typo.
1326         * location.h (string_to_event_location): Likewise.
1327
1328 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1329
1330         GDB 8.3 released.
1331
1332 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1333
1334         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1335         New variable declaration.
1336         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1337         New variable.
1338         (print_one_breakpoint): Use ui_out::test_flags and new global
1339         variable to compute use_fixed_output.
1340         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1341         Remove.
1342         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1343         (mi_multi_location_breakpoint_output_fixed): Remove.
1344         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1345         new variable.
1346         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1347         fix_multi_location_breakpoint_output flag if version >= 3.
1348         * ui-out.h (enum ui_out_flag)
1349         <fix_multi_location_breakpoint_output>: New enumerator.
1350
1351 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1352
1353         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1354
1355 2019-05-10  Tom Tromey  <tromey@adacore.com>
1356
1357         * ada-lang.c (catch_ada_completer): New function.
1358         (_initialize_ada_language): Use it.
1359
1360 2019-05-10  Tom Tromey  <tromey@adacore.com>
1361
1362         * thread.c (print_thread_info): Make "requested_threads" const.
1363         * gdbthread.h (print_thread_info): Make "requested_threads"
1364         const.
1365         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1366         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1367
1368 2019-05-08  Tom Tromey  <tom@tromey.com>
1369
1370         * gdbtypes.c (objfile_type_data): Change type.
1371         (objfile_type, _initialize_gdbtypes): Update.
1372
1373 2019-05-08  Tom Tromey  <tom@tromey.com>
1374
1375         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1376         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1377         (_initialize_dwarf2_frame): Update.
1378
1379 2019-05-08  Tom Tromey  <tom@tromey.com>
1380
1381         * objc-lang.c (objc_objfile_data): Change type.
1382         (find_methods): Update.
1383         (_initialize_objc_lang): Remove.
1384
1385 2019-05-08  Tom Tromey  <tom@tromey.com>
1386
1387         * stabsread.c (rs6000_builtin_type_data): Change type.
1388         (rs6000_builtin_type, _initialize_stabsread): Update.
1389
1390 2019-05-08  Tom Tromey  <tom@tromey.com>
1391
1392         * mips-tdep.c (mips_pdr_data): Remove.
1393         (_initialize_mips_tdep): Update.
1394
1395 2019-05-08  Tom Tromey  <tom@tromey.com>
1396
1397         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1398         (hppa_init_objfile_priv_data, read_unwind_info)
1399         (find_unwind_entry, _initialize_hppa_tdep): Update.
1400
1401 2019-05-08  Tom Tromey  <tom@tromey.com>
1402
1403         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1404         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1405         on obstack.
1406         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1407
1408 2019-05-08  Tom Tromey  <tom@tromey.com>
1409
1410         * mdebugread.c (basic_type_data): Change type.
1411         (basic_type, _initialize_mdebugread): Update.
1412
1413 2019-05-08  Tom Tromey  <tom@tromey.com>
1414
1415         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1416
1417 2019-05-08  Tom Tromey  <tom@tromey.com>
1418
1419         * nto-tdep.c (nto_inferior_data_reg): Change type.
1420         (nto_inferior_data): Update.
1421         (nto_inferior_data_cleanup, nto_new_inferior_data)
1422         (_initialize_nto_tdep): Remove.
1423         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1424
1425 2019-05-08  Tom Tromey  <tom@tromey.com>
1426
1427         * ada-lang.c (struct ada_inferior_data): Add initializers.
1428         (ada_inferior_data): Change type.
1429         (ada_inferior_data_cleanup): Remove.
1430         (get_ada_inferior_data, ada_inferior_exit)
1431         (struct ada_pspace_data): Add initializers, destructor.
1432         (ada_pspace_data_handle): Change type.
1433         (get_ada_pspace_data): Update.
1434         (ada_pspace_data_cleanup): Remove.
1435
1436 2019-05-08  Tom Tromey  <tom@tromey.com>
1437
1438         * coffread.c (struct coff_symfile_info): Add initializers.
1439         (coff_objfile_data_key): Move lower.  Change type.
1440         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1441         Update.
1442         (coff_free_info): Remove.
1443
1444 2019-05-08  Tom Tromey  <tom@tromey.com>
1445
1446         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1447         (fbsd_pspace_data_handle): Move lower.  Change type.
1448         (get_fbsd_pspace_data): Update.
1449         (fbsd_pspace_data_cleanup): Remove.
1450         (_initialize_fbsd_tdep): Update.
1451
1452 2019-05-08  Tom Tromey  <tom@tromey.com>
1453
1454         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1455         (get_ada_tasks_pspace_data): Update.
1456         (ada_tasks_pspace_data_cleanup): Remove.
1457         (_initialize_tasks): Update.
1458         (ada_tasks_inferior_data_handle): Change type.
1459         (get_ada_tasks_inferior_data): Update.
1460         (ada_tasks_inferior_data_cleanup): Remove.
1461         (struct ada_tasks_pspace_data): Add initializers.
1462
1463 2019-05-08  Tom Tromey  <tom@tromey.com>
1464
1465         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1466         * symfile-debug.c (debug_sym_get_probes): Change type.
1467         * stap-probe.c (handle_stap_probe):
1468         (stap_static_probe_ops::get_probes): Change type.
1469         * probe.h (class static_probe_ops) <get_probes>: Change type.
1470         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1471         (parse_probes_in_pspace): Update.
1472         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1473         Update.
1474         (any_static_probe_ops::get_probes): Change type.
1475         * elfread.c (elfread_data): New typedef.
1476         (probe_key): Change type.
1477         (elf_get_probes): Likewise.  Update.
1478         (probe_key_free): Remove.
1479         (_initialize_elfread): Update.
1480         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1481         Change type.
1482         (dtrace_process_dof_probe, dtrace_process_dof)
1483         (dtrace_static_probe_ops::get_probe): Change type.
1484
1485 2019-05-08  Tom Tromey  <tom@tromey.com>
1486
1487         * xcoffread.c (struct xcoff_symfile_info): Rename from
1488         coff_symfile_info.  Add initializers.
1489         (xcoff_objfile_data_key): Move lower.  Change type.
1490         (XCOFF_DATA): Rewrite.
1491         (xcoff_free_info): Remove.
1492         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1493         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1494         (xcoff_initial_scan): Update.
1495
1496 2019-05-08  Tom Tromey  <tom@tromey.com>
1497
1498         * solib-svr4.c (struct svr4_info): Add initializers and
1499         destructor.
1500         <probes_table>: Now an htab_up.
1501         (solib_svr4_pspace_data): Change type.
1502         (free_probes_table): Simplify.
1503         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1504         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1505         (probes_table_remove_objfile_probes, register_solib_event_probe)
1506         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1507         (_initialize_svr4_solib): Update.
1508
1509 2019-05-08  Tom Tromey  <tom@tromey.com>
1510
1511         * remote.c (remote_pspace_data): Change type.
1512         (remote_pspace_data_cleanup): Remove.
1513         (get_remote_exec_file, set_pspace_remote_exec_file)
1514         (_initialize_remote): Update.
1515
1516 2019-05-08  Tom Tromey  <tom@tromey.com>
1517
1518         * breakpoint.c (breakpoint_objfile_key): Change type.
1519         (get_breakpoint_objfile_data): Update.
1520         (free_breakpoint_objfile_data): Remove.
1521         (_initialize_breakpoint): Update.
1522
1523 2019-05-08  Tom Tromey  <tom@tromey.com>
1524
1525         * linux-tdep.c (struct linux_info): Add initializers.
1526         (linux_inferior_data): Move.  Change type.
1527         (invalidate_linux_cache_inf): Update.
1528         (linux_inferior_data_cleanup): Remove.
1529         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1530
1531 2019-05-08  Tom Tromey  <tom@tromey.com>
1532
1533         * auxv.c (auxv_inferior_data): Move.  Change type.
1534         (auxv_inferior_data_cleanup): Remove.
1535         (invalidate_auxv_cache_inf): Rewrite.
1536         (get_auxv_inferior_data, _initialize_auxv): Update.
1537
1538 2019-05-08  Tom Tromey  <tom@tromey.com>
1539
1540         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1541         (symfile_debug_objfile_data_key): Change type.
1542         (symfile_debug_installed, debug_qf_has_symbols)
1543         (debug_qf_find_last_source_symtab)
1544         (debug_qf_forget_cached_source_info)
1545         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1546         (debug_qf_print_stats, debug_qf_dump)
1547         (debug_qf_expand_symtabs_for_function)
1548         (debug_qf_expand_all_symtabs)
1549         (debug_qf_expand_symtabs_with_fullname)
1550         (debug_qf_map_matching_symbols)
1551         (debug_qf_expand_symtabs_matching)
1552         (debug_qf_find_pc_sect_compunit_symtab)
1553         (debug_qf_map_symbol_filenames)
1554         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1555         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1556         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1557         (debug_sym_read_linetable, debug_sym_relocate): Update.
1558         (symfile_debug_free_objfile): Remove.
1559         (install_symfile_debug_logging, _initialize_symfile_debug):
1560         Update.
1561
1562 2019-05-08  Tom Tromey  <tom@tromey.com>
1563
1564         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1565         allocate_on_obstack.
1566         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1567         (get_dwarf2_per_objfile): Update.
1568         (set_dwarf2_per_objfile): Remove.
1569         (dwarf2_has_info, dwarf2_get_section_info): Update.
1570         (dwarf2_free_objfile): Remove.
1571         (_initialize_dwarf2_read): Update.
1572
1573 2019-05-08  Tom Tromey  <tom@tromey.com>
1574
1575         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1576         initializers.
1577         <unsupported_script_warning_printed,
1578         script_not_found_warning_printed>: Now bool.
1579         (auto_load_pspace_data): Change type.
1580         (~auto_load_pspace_info): Rename from
1581         auto_load_pspace_data_cleanup.
1582         (get_auto_load_pspace_data, init_loaded_scripts_info)
1583         (clear_section_scripts, maybe_print_unsupported_script_warning)
1584         (maybe_print_script_not_found_warning, _initialize_auto_load):
1585         Update.
1586
1587 2019-05-08  Tom Tromey  <tom@tromey.com>
1588
1589         * objfiles.c (objfile_pspace_info): Add destructor and
1590         initializers.
1591         (objfiles_pspace_data): Change type.
1592         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1593         (get_objfile_pspace_data): Update.
1594         (objfiles_bfd_data): Change type.
1595         (get_objfile_bfd_data): Update.
1596         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1597
1598 2019-05-08  Tom Tromey  <tom@tromey.com>
1599
1600         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1601         Change type.
1602         (get_catch_syscall_inferior_data): Update.
1603         (catch_syscall_inferior_data_cleanup): Remove.
1604         (_initialize_break_catch_syscall): Update.
1605
1606 2019-05-08  Tom Tromey  <tom@tromey.com>
1607
1608         * inflow.c (struct terminal_info): Add destructor and
1609         initializers.
1610         (inflow_inferior_data): Change type.
1611         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1612         (get_inflow_inferior_data, inflow_inferior_exit)
1613         (swap_terminal_info, _initialize_inflow): Update.
1614
1615 2019-05-08  Tom Tromey  <tom@tromey.com>
1616
1617         * target-dcache.c (target_dcache_cleanup): Remove.
1618         (target_dcache_aspace_key): Change type.
1619         (target_dcache_init_p, target_dcache_invalidate)
1620         (target_dcache_get, target_dcache_get_or_init)
1621         (_initialize_target_dcache): Update.
1622         * dcache.h (struct dcache_deleter): New.
1623
1624 2019-05-08  Tom Tromey  <tom@tromey.com>
1625
1626         * symtab.c (struct symbol_cache): Add destructor and
1627         initializers.
1628         (symbol_cache_key): Move.  Change type.
1629         (make_symbol_cache, free_symbol_cache): Remove.
1630         (get_symbol_cache): Update.
1631         (symbol_cache_cleanup): Remove.
1632         (ALL_PSPACES, symbol_cache_flush)
1633         (maintenance_print_symbol_cache)
1634         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1635         Update.
1636
1637 2019-05-08  Tom Tromey  <tom@tromey.com>
1638
1639         * symtab.c (struct main_info): Add destructor and initializers.
1640         (main_progspace_key): Move.  Change type.
1641         (get_main_info): Update.
1642         (main_info_cleanup): Remove.
1643         (_initialize_symtab): Update.
1644
1645 2019-05-08  Tom Tromey  <tom@tromey.com>
1646
1647         * registry.h (DECLARE_REGISTRY): Define the _key class.
1648
1649 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1650
1651         * NEWS: Merge two 'New commands' sections.
1652
1653 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1654
1655         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1656         parameter and use Ada language definition instead.
1657         (ada_val_print_ptr): Remove unused language parameter.
1658         (ada_val_print_num): Remove language parameter and use Ada language
1659         definition instead.
1660         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1661         parameter.
1662         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1663         parameter and use Ada language definition instead.
1664         (ada_val_print_1): Update all ada_val_print_xxx calls.
1665         Remove language parameter.
1666         (ada_val_print): Update ada_val_print_1 call.
1667
1668 2019-05-08  Tom Tromey  <tromey@adacore.com>
1669
1670         * remote.c (remote_hw_watchpoint_limit)
1671         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1672         Now static.
1673
1674 2019-05-08  Tom Tromey  <tromey@adacore.com>
1675
1676         * maint.c (_initialize_maint_cmds): Move initialization code to
1677         remote.c.
1678         (watchdog, show_watchdog): Move to remote.c.
1679         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1680         "watchdog" static.
1681         (_initialize_remote): Move initialization code from maint.c.
1682         * defs.h (watchdog): Don't declare.
1683
1684 2019-05-08  Tom Tromey  <tromey@adacore.com>
1685
1686         * tui/tui-interp.c: Include main.h.
1687         * interps.c: Include main.h.
1688         * main.h (interpreter_p): Declare.
1689         * defs.h (interpreter_p): Don't declare.
1690
1691 2019-05-08  Tom Tromey  <tromey@adacore.com>
1692
1693         * dwarf2loc.c: Include dwarf2read.h.
1694         * defs.h (read_unsigned_leb128): Don't declare.
1695         * dwarf2read.h (read_unsigned_leb128): Declare.
1696
1697 2019-05-08  Tom Tromey  <tromey@adacore.com>
1698
1699         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1700         method.
1701
1702 2019-05-08  Tom Tromey  <tromey@adacore.com>
1703
1704         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1705         when no wrap column is set.
1706
1707 2019-05-08  Tom Tromey  <tromey@adacore.com>
1708
1709         * c-lang.c (c_get_string): Handle non-C-style arrays.
1710
1711 2019-05-08  Tom Tromey  <tromey@adacore.com>
1712
1713         * typeprint.c (print_offset_data::update): Print the bit offset,
1714         not the number of bits remaining.
1715
1716 2019-05-08  Tom Tromey  <tromey@adacore.com>
1717
1718         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1719         padding at end of comment.
1720
1721 2019-05-08  Tom Tromey  <tromey@adacore.com>
1722
1723         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1724         Compare main types.
1725
1726 2019-05-06  Tom Tromey  <tom@tromey.com>
1727
1728         * common/scoped_mmap.c: Include common-defs.h.
1729         * common/scoped_mmap.h: Don't include config.h.
1730
1731 2019-05-04  Tom Tromey  <tom@tromey.com>
1732
1733         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1734         (struct aarch64_call_info): Add initializers.
1735         <si>: Now a std::vector.
1736         (pass_on_stack, aarch64_push_dummy_call): Update.
1737
1738 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1739             Tom Tromey  <tom@tromey.com>
1740
1741         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1742         (ppc_threads): Now a std::vector.  Now static.
1743         (hwdebug_find_thread_points_by_tid)
1744         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1745         Update.
1746
1747 2019-05-04  Tom Tromey  <tom@tromey.com>
1748
1749         * arc-tdep.c (arc_tdesc_init): Return bool.
1750
1751 2019-05-04  Tom Tromey  <tom@tromey.com>
1752
1753         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1754         Use gdb_assert_not_reached.
1755
1756 2019-05-04  Tom Tromey  <tom@tromey.com>
1757
1758         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1759         "false".
1760
1761 2019-05-04  Tom Tromey  <tom@tromey.com>
1762
1763         * arc-tdep.c (arc_tdesc_init): Use bool.
1764
1765 2019-05-04  Tom Tromey  <tom@tromey.com>
1766
1767         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1768
1769 2019-05-04  Tom Tromey  <tom@tromey.com>
1770
1771         * cli/cli-cmds.c (valid_command_p): Return bool.
1772
1773 2019-05-04  Tom Tromey  <tom@tromey.com>
1774
1775         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1776         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1777
1778 2019-05-04  Raul Tambre  <raul@tambre.ee>
1779
1780         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1781         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1782         operator for comparison.
1783
1784 2019-05-04  Tom Tromey  <tom@tromey.com>
1785
1786         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1787         (lookup_partial_symbol, print_partial_symbols)
1788         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1789         (psymbol_compare): Update.
1790         (add_psymbol_to_bcache): Clear the entire psymbol.
1791         (maintenance_check_psymtabs): Update.
1792         * psympriv.h (struct partial_symbol): Don't derive from
1793         general_symbol_info.
1794         <obj_section, unrelocated_address, address,
1795         set_unrelocated_address>: Update.
1796         <ginfo>: New member.
1797         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1798         (debug_names::write_psymbols): Update.
1799
1800 2019-05-04  Tom de Vries  <tdevries@suse.de>
1801
1802         * contrib/cc-with-tweaks.sh: Support -n arg.
1803
1804 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1805
1806         * corelow.c (core_target::detach): Ensure frame cache and
1807         register caches are cleared.
1808         inferior.c (exit_inferior_1): Likewise.
1809
1810 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1811             Tom Tromey  <tom@tromey.com>
1812
1813         * dictionary.c (collate_pending_symbols_by_language): Remove
1814         "struct" from foreach.
1815         * symtab.c (lookup_global_symbol_from_objfile)
1816         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1817         foreach.
1818         * ser-tcp.c (net_open): Remove "struct" from foreach.
1819         * objfiles.c (objfile_relocate, objfile_rebase)
1820         (objfile_has_symbols): Remove "struct" from foreach.
1821         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1822         from foreach.
1823         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1824         foreach.
1825         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1826         "struct" from foreach.
1827         * ada-lang.c (create_excep_cond_exprs)
1828         (ada_exception_catchpoint_cond_string): Remove "struct" from
1829         foreach.
1830
1831 2019-05-03  Tom Tromey  <tromey@adacore.com>
1832
1833         * ada-exp.y (convert_char_literal): Check suffix of each
1834         enumerator.
1835
1836 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1837
1838         PR ada/21406:
1839         * ada-exp.y (yywrap): Don't define.
1840         * ada-lex.l (%option): Add noyywrap
1841         (yywrap): Remove.
1842
1843 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1844
1845         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1846         _WIN32_WINNT to the XP level, unless already defined to a higher
1847         level.
1848
1849         * unittests/parse-connection-spec-selftests.c:
1850         * ser-tcp.c:
1851         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1852         override.
1853
1854         * symfile.c (find_separate_debug_file): Remove colon from the
1855         drive spec of DOS/Windows file names of the target, so that the
1856         file name produced from DEBUGDIR and the target's directory will
1857         be valid on DOS/Windows systems.
1858
1859 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1860
1861         * rust-lang.c (val_print_struct): Handle printing structures
1862         containing strings.
1863
1864 2019-05-02  Tom Tromey  <tromey@adacore.com>
1865
1866         * valarith.c (_initialize_valarith): Remove.
1867
1868 2019-05-01  Tom Tromey  <tromey@adacore.com>
1869
1870         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1871         bitfields.
1872
1873 2019-05-01  Tom Tromey  <tromey@adacore.com>
1874
1875         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1876         for big-endian copies.
1877
1878 2019-04-30  Ali Tamur  <tamur@google.com>
1879         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1880         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1881         (read_3_bytes): New function.
1882
1883 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1884
1885         * windows-nat.c (main_thread_id): Delete.
1886         (handle_output_debug_string): Replace main_thread_id by
1887         current_event.dwThreadId.
1888         (fake_create_process): Likewise.
1889         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1890         Do not set main_thread_id.
1891         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1892         current_event.dwThreadId.
1893         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1894
1895 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1896
1897         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1898         Use current_event.dwThreadId instead of main_thread_id.
1899
1900 2019-04-30  Tom Tromey  <tromey@adacore.com>
1901
1902         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1903         (create_excep_cond_exprs): Iterate over program spaces.
1904         (ada_exception_catchpoint_cond_string): Examine all minimal
1905         symbols for exception types.
1906
1907 2019-04-30  Tom Tromey  <tromey@adacore.com>
1908
1909         PR c++/24470:
1910         * dwarf2read.c (process_structure_scope): Handle case where type
1911         has template parameters but no symbol was created.
1912
1913 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1914             Chris January  <chris.january@arm.com>
1915
1916         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1917         qualifier.
1918         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1919
1920 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1921
1922         * f-typeprint.c (f_print_type): Update rules for printing
1923         whitespace.
1924         (f_type_print_varspec_suffix): Likewise.
1925
1926 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1927             Chris January  <chris.january@arm.com>
1928
1929         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1930         function arguments.
1931
1932 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1933
1934         * f-lang.c (build_fortran_types): Change name of void type to
1935         lower case.
1936         * f-typeprint.c (f_type_print_base): Print the name of the void
1937         type, rather than a fixed string.
1938         * f-valprint.c (f_decorations): Use lower case void string.
1939
1940 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1941             Chris January  <chris.january@arm.com>
1942
1943         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1944         types for Fortran.
1945
1946 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1947             Chris January  <chris.january@arm.com>
1948             David Lecomber  <david.lecomber@arm.com>
1949
1950         * f-exp.y (BINOP_INTRINSIC): New token.
1951         (exp): New parser rule handling BINOP_INTRINSIC.
1952         (f77_keywords): Add new builtin procedures.
1953         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1954         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1955         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1956         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1957         (print_unop_subexp_f): New function.
1958         (print_binop_subexp_f): New function.
1959         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1960         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1961         (dump_subexp_body_f): Likewise.
1962         (operator_check_f): Likewise.
1963         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1964         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1965
1966 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1967
1968         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1969         UNOP_KIND.
1970         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1971         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1972         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1973         (operator_length_f): New fuction.
1974         (print_subexp_f): New function.
1975         (op_name_f): New function.
1976         (dump_subexp_body_f): New function.
1977         (operator_check_f): New function.
1978         (exp_descriptor_f): Replace standard expression handling functions
1979         with new functions.
1980         * gdb/fortran-operator.def: New file.
1981         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1982         * gdb/std-operator.def: Remove UNOP_KIND.
1983
1984 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1985
1986         * std-operator.def: Remove unbalanced, stray double quote
1987         character.
1988
1989 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1990             Chris January  <chris.january@arm.com>
1991             Daniel Everett  <daniel.everett@arm.com>
1992             Nick Forrington  <nick.forrington@arm.com>
1993             Richard Bunt  <richard.bunt@arm.com>
1994
1995         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1996         of depth when printing anonymous structs or unions.
1997         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1998         Don't print either the top-level value, or the children if the
1999         max-depth is exceeded.
2000         (ppscm_print_children): When printing the key of a map, allow one
2001         extra level of depth.
2002         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2003         print either the top-level value, or the children if the max-depth
2004         is exceeded.
2005         (print_children): When printing the key of a map, allow one extra
2006         level of depth.
2007         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2008         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2009         (user_print_options): Initialise max_depth field.
2010         (val_print_scalar_or_string_type_p): New function.
2011         (val_print): Check to see if the max depth has been reached.
2012         (val_print_check_max_depth): Define new function.
2013         (show_print_max_depth): New function.
2014         (_initialize_valprint): Add 'print max-depth' option.
2015         * valprint.h (struct value_print_options) <max_depth>: New field.
2016         (val_print_check_max_depth): Declare new function.
2017         * NEWS: Document new feature.
2018
2019 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2020
2021         * ada-lang.c (ada_language_defn): Initialise new field.
2022         * c-lang.c (c_is_string_type_p): New function.
2023         (c_language_defn): Initialise new field.
2024         (cplus_language_defn): Initialise new field.
2025         (asm_language_defn): Initialise new field.
2026         (minimal_language_defn): Initialise new field.
2027         * c-lang.h (c_is_string_type_p): Declare new function.
2028         * d-lang.c (d_language_defn): Initialise new field.
2029         * f-lang.c (f_is_string_type_p): New function.
2030         (f_language_defn): Initialise new field.
2031         * go-lang.c (go_is_string_type_p): New function.
2032         (go_language_defn): Initialise new field.
2033         * language.c (default_is_string_type_p): New function.
2034         (unknown_language_defn): Initialise new field.
2035         (auto_language_defn): Initialise new field.
2036         * language.h (struct language_defn) <la_is_string_type_p>: New
2037         member variable.
2038         (default_is_string_type_p): Declare new function.
2039         * m2-lang.c (m2_language_defn): Initialise new field.
2040         * objc-lang.c (objc_language_defn): Initialise new field.
2041         * opencl-lang.c (opencl_language_defn): Initialise new field.
2042         * p-lang.c (pascal_is_string_type_p): New function.
2043         (pascal_language_defn): Initialise new field.
2044         * rust-lang.c (rust_is_string_type_p): New function.
2045         (rust_language_defn): Initialise new field.
2046
2047 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2048
2049         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2050         New field.
2051         * ada-lang.c (ada_language_defn): Initialise new field.
2052         * c-lang.c (c_language_defn): Likewise.
2053         (cplus_language_defn): Likewise.
2054         (asm_language_defn): Likewise.
2055         (minimal_language_defn): Likewise.
2056         * d-lang.c (d_language_defn): Likewise.
2057         * f-lang.c (f_language_defn): Likewise.
2058         * go-lang.c (go_language_defn): Likewise.
2059         * language.c (unknown_language_defn): Likewise.
2060         (auto_language_defn): Likewise.
2061         * m2-lang.c (m2_language_defn): Likewise.
2062         * objc-lang.c (objc_language_defn): Likewise.
2063         * opencl-lang.c (opencl_language_defn): Likewise.
2064         * p-lang.c (pascal_language_defn): Likewise.
2065         * rust-lang.c (rust_language_defn): Likewise.
2066
2067 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2068
2069         * ada-lang.c (ada_is_character_type): Change return type to bool.
2070         (ada_is_string_type): Likewise.
2071         * ada-lang.h (ada_is_character_type): Update declaration
2072         (ada_is_string_type): Likewise.
2073
2074 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2075
2076         Support style in 'frame|thread apply'
2077
2078         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2079         * record.c (record_start, record_stop): Update callers of
2080         execute_command_to_string with false.
2081         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2082         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2083         methods.
2084         (class string_file): New constructor with term_out parameter.
2085         Override methods term_out and can_emit_style_escape.  New member
2086         term_out.
2087         (class stdio_file): Override can_emit_style_escape.
2088         (class tee_file): Override term_out and can_emit_style_escape.
2089         * utils.h (can_emit_style_escape): Remove.
2090         * utils.c (can_emit_style_escape): Likewise.
2091         Update all callers of can_emit_style_escape (SOMESTREAM) to
2092         SOMESTREAM->can_emit_style_escape.
2093         * source-cache.c (source_cache::get_source_lines): Likewise.
2094         * stack.c (frame_apply_command_count): Call execute_command_to_string
2095         passing the term_out characteristic of the current gdb_stdout.
2096         * thread.c (thr_try_catch_cmd): Likewise.
2097         * top.c (execute_command_to_string): pass term_out parameter
2098         to construct the string_file for the command output.
2099         * ui-file.c (term_cli_styling): New function (most code moved
2100         from utils.c can_emit_style_escape).
2101         (string_file::string_file, string_file::can_emit_style_escape,
2102         stdio_file::can_emit_style_escape, tee_file::term_out,
2103         tee_file::can_emit_style_escape): New functions.
2104
2105 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2106
2107         * NEWS: Mention the new set|show may-call-functions.
2108         * infcall.c (may_call_functions_p): New variable.
2109         (show_may_call_functions_p): New function.
2110         (call_function_by_hand_dummy): Throws an error if not
2111         may-call-functions.
2112         (_initialize_infcall): Call add_setshow_boolean_cmd for
2113         may-call-functions.
2114
2115 2019-04-25  Keith Seitz  <keiths@redhat.com>
2116
2117         PR c++/24367
2118         * cp-support.c (inspect_type): Don't attempt substitutions
2119         of symbol with the same name.
2120
2121 2019-04-25  Tom Tromey  <tromey@adacore.com>
2122
2123         PR gdb/24475:
2124         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2125         static.
2126
2127 2019-04-25  Tom Tromey  <tromey@adacore.com>
2128
2129         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2130         rvalue reference.
2131         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2132         (gdb_xml_parser::parse): Use std::move.
2133         * python/python-internal.h (gdbpy_convert_exception): Take a const
2134         reference.
2135         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2136         std::move.
2137         * python/py-utils.c (gdbpy_convert_exception): Take a const
2138         reference.
2139         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2140         Use std::move.
2141         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2142         Use std::move.
2143         * mi/mi-main.c (mi_print_exception): Take a const reference.
2144         * main.c (handle_command_errors): Take a const reference.
2145         * linespec.c (parse_linespec): Use std::move.
2146         * infcall.c (run_inferior_call): Use std::move.
2147         (call_function_by_hand_dummy): Use std::move.
2148         * exec.c (try_open_exec_file): Use std::move.
2149         * exceptions.h (exception_print, exception_fprintf)
2150         (exception_print_same): Update.
2151         * exceptions.c (print_exception, exception_print)
2152         (exception_fprintf, exception_print_same): Change parameters to
2153         const reference.
2154         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2155         * common/new-op.c: Use std::move.
2156         * common/common-exceptions.h (struct gdb_exception): Add move
2157         constructor.
2158         (struct gdb_exception_error, struct gdb_exception_quit, struct
2159         gdb_quit_bad_alloc): Change constructor to move constructor.
2160         (throw_exception): Change parameter to rvalue reference.
2161         * common/common-exceptions.c (throw_exception): Take rvalue
2162         reference.
2163         * cli/cli-interp.c (safe_execute_command): Use std::move.
2164         * breakpoint.c (insert_bp_location, location_to_sals): Use
2165         std::move.
2166
2167 2019-04-25  Tom Tromey  <tromey@adacore.com>
2168
2169         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2170         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2171         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2172         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2173         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2174         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2175         guile/scm-value.c: Use unpack.
2176         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2177         gdbscm_gdb_exception.
2178         (gdbscm_throw_gdb_exception): Likewise.
2179         (struct gdbscm_gdb_exception): New.
2180         (unpack): New function.
2181         (gdbscm_wrap): Use unpack.
2182
2183 2019-04-25  Tom Tromey  <tromey@adacore.com>
2184
2185         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2186         (gdb_rl_callback_handler): Use std::move.
2187         * common/common-exceptions.h (struct gdb_exception): Add move
2188         assignment operator.
2189         (throw_exception_sjlj): Change "exception" to const reference.
2190         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2191         (throw_exception_sjlj): Change "exception" to const reference.
2192
2193 2019-04-25  Tom Tromey  <tromey@adacore.com>
2194
2195         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2196         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2197         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2198         Update.
2199         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2200         Update.
2201         * mi/mi-interp.c (mi_interp::exec): Update.
2202         * linespec.c (parse_linespec): Update.
2203         * infcall.c (run_inferior_call): Update.
2204         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2205         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2206         (gdbscm_lookup_global_symbol): Update.
2207         * guile/scm-param.c (gdbscm_parameter_value): Update.
2208         * guile/scm-frame.c (gdbscm_frame_read_register)
2209         (gdbscm_frame_read_var): Update.
2210         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2211         * exec.c (try_open_exec_file): Update.
2212         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2213         (gdb_rl_callback_handler): Update.
2214         * common/common-exceptions.h (exception_none): Don't declare.
2215         * common/common-exceptions.c (exception_none): Don't define.
2216         (struct catcher) <exception>: Update.
2217         * cli/cli-interp.c (safe_execute_command): Update.
2218         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2219
2220 2019-04-25  Ali Tamur  <tamur@google.com>
2221
2222         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2223         (read_attribute_value): Likewise.
2224         (dwarf2_read_addr_index): Update comment.
2225         (read_str_index): Add DW_FORM_strx.
2226         (dwarf2_string_attr): Likewise.
2227         (dwarf2_const_value_attr): Likewise.
2228         (dump_die_shallow): Likewise.
2229         (dwarf2_fetch_constant_bytes): Likewise.
2230         (skip_form_bytes): Likewise.
2231         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2232
2233 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2234
2235         PR corefiles/11608
2236         PR corefiles/18187
2237         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2238         OFFSET.  Verify if current mapping contains an ELF header.
2239         (linux_find_memory_regions_full): Adjust call to
2240         dump_mapping_p.
2241
2242 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2243             Kang Li <kanglictf@gmail.com>
2244
2245         PR gdb/21600
2246
2247         * dwarf2-frame.c (read_initial_length): Be consistent about using
2248         unsigned representation of length.
2249         (decode_frame_entry_1): Likewise.  Check for wraparound of
2250         end pointer as well as buffer overflow.
2251
2252 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2253
2254         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2255         "vq".
2256
2257 2019-04-24  Tom Tromey  <tromey@adacore.com>
2258
2259         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2260
2261 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2262
2263         * s12z-tdep.c (s12z_unwind_pc): Delete.
2264         (s12z_unwind_sp): Delete.
2265         (s12z_gdbarch_init): Don't register deleted functions with
2266         gdbarch.
2267
2268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2269
2270         * rl78-tdep.c (rl78_unwind_sp): Delete.
2271         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2272
2273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2274
2275         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2276         (xstormy16_unwind_pc): Delete.
2277         (xstormy16_dummy_id): Delete.
2278         (xstormy16_gdbarch_init): Don't register deleted functions with
2279         gdbarch.
2280
2281 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2282
2283         * vax-tdep.c (vax_unwind_pc): Delete.
2284         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2285
2286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2287
2288         * v850-tdep.c (v850_unwind_sp): Delete.
2289         (v850_unwind_pc): Delete.
2290         (v850_dummy_id): Delete.
2291         (v850_gdbarch_init): Don't register deleted functions with
2292         gdbarch.
2293
2294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2295
2296         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2297         (tilegx_unwind_pc): Delete.
2298         (tilegx_unwind_dummy_id): Delete.
2299         (tilegx_gdbarch_init): Don't register deleted functions with
2300         gdbarch.
2301
2302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2303
2304         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2305         (tic6x_dummy_id): Delete.
2306         (tic6x_gdbarch_init): Don't register deleted functions with
2307         gdbarch.
2308
2309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2310
2311         * sparc-tdep.c (sparc_unwind_pc): Delete.
2312         (sparc32_gdbarch_init): Don't register deleted function with
2313         gdbarch.
2314
2315 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2316
2317         * sh-tdep.c (sh_unwind_sp): Delete.
2318         (sh_unwind_pc): Delete.
2319         (sh_dummy_id): Delete.
2320         (sh_gdbarch_init): Don't register deleted functions with
2321         gdbarch.
2322
2323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2324
2325         * score-tdep.c (score_unwind_sp): Delete.
2326         (score_unwind_pc): Delete.
2327         (score_dummy_id): Delete.
2328         (score_gdbarch_init): Don't register deleted functions with
2329         gdbarch.
2330
2331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2332
2333         * rx-tdep.c (rx_unwind_pc): Delete.
2334         (rx_unwind_sp): Delete.
2335         (rx_dummy_id): Delete.
2336         (rx_gdbarch_init): Don't register deleted functions with
2337         gdbarch.  Update comment.
2338
2339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2340
2341         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2342         (rs6000_dummy_id): Delete.
2343         (rs6000_gdbarch_init): Don't register deleted functions with
2344         gdbarch.
2345
2346 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2347
2348         * or1k-tdep.c (or1k_dummy_id): Delete.
2349         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2350
2351 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2352
2353         * nios2-tdep.c (nios2_dummy_id): Delete.
2354         (nios2_unwind_sp): Delete.
2355         (nios2_gdbarch_init): Don't register deleted functions with
2356         gdbarch.
2357
2358 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2359
2360         * nds32-tdep.c (nds32_dummy_id): Delete.
2361         (nds32_unwind_pc): Delete.
2362         (nds32_unwind_sp): Delete.
2363         (nds32_gdbarch_init): Don't register deleted functions with
2364         gdbarch.
2365
2366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2367
2368         * msp430-tdep.c (msp430_unwind_pc): Delete.
2369         (msp430_unwind_sp): Delete.
2370         (msp430_dummy_id): Delete.
2371         (msp430_gdbarch_init): Don't register deleted functions with
2372         gdbarch.
2373
2374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2375
2376         * moxie-tdep.c (moxie_unwind_sp): Delete.
2377         (moxie_unwind_pc): Delete.
2378         (moxie_dummy_id): Delete.
2379         (moxie_gdbarch_init): Don't register deleted functions with
2380         gdbarch.
2381
2382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2383
2384         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2385         (mn10300_unwind_pc): Delete.
2386         (mn10300_unwind_sp): Delete.
2387         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2388         mn10300_unwind_sp.
2389         (mn10300_frame_unwind_init): Don't register deleted functions with
2390         gdbarch.
2391
2392 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2393
2394         * mep-tdep.c (mep_unwind_pc): Delete.
2395         (mep_unwind_sp): Delete.
2396         (mep_dummy_id): Delete.
2397         (mep_gdbarch_init): Don't register deleted functions with
2398         gdbarch.
2399
2400 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2401
2402         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2403         (m68hc11_unwind_sp): Delete.
2404         (m68hc11_gdbarch_init): Don't register deleted functions with
2405         gdbarch.
2406
2407 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2408
2409         * m32r-tdep.c (m32r_unwind_sp): Delete.
2410         (m32r_unwind_pc): Delete.
2411         (m32r_dummy_id): Delete.
2412         (m32r_gdbarch_init): Don't register deleted functions with
2413         gdbarch.
2414
2415 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2416
2417         * m32c-tdep.c (m32c_unwind_pc): Delete.
2418         (m32c_unwind_sp): Delete.
2419         (m32c_dummy_id): Delete.
2420         (m32c_gdbarch_init): Don't register deleted functions with
2421         gdbarch.
2422
2423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2424
2425         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2426         (lm32_unwind_pc): Delete.
2427         (lm32_dummy_id): Delete.
2428         (lm32_gdbarch_init): Don't register deleted functions with
2429         gdbarch.
2430
2431 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2432
2433         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2434         (iq2000_unwind_pc): Delete.
2435         (iq2000_dummy_id): Delete.
2436         (iq2000_gdbarch_init): Don't register deleted functions with
2437         gdbarch.
2438
2439 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2440
2441         * nds32-tdep.c (nds32_type_align): Delete.
2442         (nds32_push_dummy_call): Use type_align instead.
2443
2444 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2445
2446         * arm-tdep.c (arm_type_align): Only handle vector override case.
2447         (arm_push_dummy_call): Use type_align.
2448         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2449
2450 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2451
2452         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2453         case.
2454         (pass_on_stack): Use type_align.
2455         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2456         function.
2457
2458 2019-04-23  Tom Tromey  <tromey@adacore.com>
2459
2460         * dwarf2read.c (line_header::file_name_at): Remove unused
2461         overload.
2462
2463 2019-04-23  Tom de Vries  <tdevries@suse.de>
2464
2465         PR gdb/24438
2466         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2467         invocation.
2468
2469
2470 2019-03-27  Ali Tamur  <tamur@google.com>
2471
2472         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2473         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2474         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2475         (dwarf_expr_context::get_addr_index): Likewise
2476         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2477         (symbol_needs_eval_context::get_addr_index): Likewise
2478         (disassemble_dwarf_expression): Add DW_OP_addrx
2479         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2480         (read_cutu_die_from_dwo): Update comment
2481         (skip_one_die): Add DW_FORM_addrx
2482         (read_attribute_value): Likewise
2483         (var_decode_location): Add DW_OP_addrx
2484         (dwarf2_const_value_attr): Add DW_FORM_addrx
2485         (dump_die_shallow): Likewise
2486         (dwarf2_fetch_constant_bytes): Likewise
2487         (decode_locdesc): Add DW_OP_addrx
2488         (skip_form_bytes): Add DW_FORM_addrx
2489
2490 2019-04-22  Ali Tamur  <tamur@google.com>
2491
2492         * MAINTAINERS (Write After Approval): Add self.
2493
2494 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2495
2496         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2497         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2498         (open_symbol_file_object): Likewise.
2499         (svr4_default_sos): Add info parameter.
2500         (svr4_read_so_list): Likewise.
2501         (svr4_current_sos_direct): Adjust functions calls to pass down
2502         info.
2503         (svr4_current_sos_1): Add info parameter.
2504         (svr4_current_sos): Call get_svr4_info, pass info down to
2505         svr4_current_sos_1.
2506         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2507         get_svr4_info.
2508         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2509         get_svr4_info.
2510         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2511         to get_svr4_info.
2512         (probes_table_remove_objfile_probes): Likewise.
2513         (register_solib_event_probe): Add info parameter.
2514         (solist_update_incremental): Pass info parameter down to
2515         svr4_read_so_list.
2516         (disable_probes_interface): Add info parameter.
2517         (svr4_handle_solib_event): Pass current_program_space to
2518         get_svr4_info.  Adjust disable_probes_interface cleanup.
2519         (svr4_create_probe_breakpoints): Add info parameter, pass it
2520         down to register_solib_event_probe.
2521         (svr4_create_solib_event_breakpoints): Add info parameter,
2522         pass it down to svr4_create_probe_breakpoints.
2523         (enable_break): Pass info down to
2524         svr4_create_solib_event_breakpoints.
2525         (svr4_solib_create_inferior_hook): Pass current_program_space to
2526         get_svr4_info.
2527         (svr4_clear_solib): Likewise.
2528
2529 2019-04-22  Pedro Alves  <palves@redhat.com>
2530
2531         * solib-svr4.c (svr4_free_objfile_observer): New.
2532         (probe_and_action::objfile): New field.
2533         (probes_table_htab_remove_objfile_probes)
2534         (probes_table_remove_objfile_probes): New functions.
2535         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2536         in the new probe_and_action.  Don't store the probe in 'lookup'.
2537         (svr4_create_probe_breakpoints): Pass objfile to
2538         register_solib_event_probe.
2539         (_initialize_svr4_solib): Register a free_objfile observer.
2540
2541 2019-04-19  Tom Tromey  <tom@tromey.com>
2542
2543         * common/queue.h: Remove.
2544
2545 2019-04-19  Tom Tromey  <tom@tromey.com>
2546
2547         * event-loop.c: Don't include "common/queue.h".
2548
2549 2019-04-19  Tom Tromey  <tom@tromey.com>
2550
2551         * remote.c (remote_target): Use delete.
2552         * remote-notif.h: Include <list>, not "common/queue.h".
2553         (notif_client_p): Remove typedef.
2554         (remote_notif_state): Add constructor, destructor, initializer.
2555         <notif_queue>: Now a std::list.
2556         (remote_notif_state_xfree): Don't declare.
2557         * remote-notif.c (remote_notif_process, handle_notification)
2558         (remote_notif_state_allocate): Update.
2559         (~remote_notif_state): Rename from remote_notif_state_xfree.
2560
2561 2019-04-19  Tom Tromey  <tom@tromey.com>
2562
2563         * symfile.c (reread_symbols): Update.
2564         * objfiles.c (objfile_register_static_link)
2565         (objfile_lookup_static_link): Update
2566         (~objfile) Don't delete static_links.
2567         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2568
2569 2019-04-19  Tom Tromey  <tom@tromey.com>
2570
2571         * type-stack.h (struct type_stack) <insert>: Constify string.
2572         * type-stack.c (type_stack::insert): Constify string.
2573         * gdbtypes.h (lookup_template_type): Update.
2574         (address_space_name_to_int): Update.
2575         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2576         const.
2577         (lookup_template_type): Make name const.
2578         * c-exp.y: Update rules.
2579         (lex_one_token, classify_name, classify_inner_name)
2580         (c_print_token): Update.
2581         * p-exp.y: Update rules.
2582         (yylex): Update.
2583         * f-exp.y: Update rules.
2584         (yylex): Update.
2585         * d-exp.y: Update rules.
2586         (lex_one_token, classify_name, classify_inner_name): Update.
2587         * parse.c (write_dollar_variable, copy_name): Return std::string.
2588         * parser-defs.h (copy_name): Change return type.
2589         * m2-exp.y: Update rules.
2590         (yylex): Update.
2591         * go-exp.y (lex_one_token): Update.
2592         Update rules.
2593         (classify_unsafe_function, classify_packaged_name)
2594         (classify_name, yylex): Update.
2595
2596 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2597
2598         * configure.ac: add --enable-source-highlight switch.
2599         * configure: Regenerate.
2600         * top.c (print_gdb_version): plumb --enable-source-highlight
2601         status to "show configuration".
2602
2603 2019-04-19  Tom Tromey  <tromey@adacore.com>
2604
2605         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2606         Check ADA_TYPE_P.
2607         (empty_record, ada_template_to_fixed_record_type_1)
2608         (template_to_static_fixed_type)
2609         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2610         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2611         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2612         macros.
2613
2614 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2615
2616         PR symtab/24423:
2617         * source.c (print_source_lines_base): Advance "iter" when a
2618         control character is seen.
2619
2620 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2621
2622         * inferior.h (struct infcall_suspend_state_deleter):
2623         Catch exception in destructor to avoid crash.
2624
2625 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2626
2627         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2628         close to the add_com "shell".
2629
2630 2019-04-18  Tom Tromey  <tromey@adacore.com>
2631
2632         * process-stratum-target.h (class process_stratum_target)
2633         <stratum>: Add "final".
2634
2635 2019-04-17  Tom Tromey  <tromey@adacore.com>
2636
2637         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2638         against nullptr before use.
2639
2640 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2641
2642         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2643
2644 2019-04-17  Jim Wilson  <jimw@sifive.com>
2645             Andrew Burgess  <andrew.burgess@embecosm.com>
2646
2647         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2648         code read might fail, assume 4-byte breakpoint in that case.
2649
2650 2019-04-15  Leszek Swirski  <leszeks@google.com>
2651
2652         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2653         rather than a hand-rolled POD check when checking for forced MEMORY
2654         classification.
2655
2656 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2657
2658         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2659         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2660         function.
2661         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2662         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2663         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2664         declaration.
2665
2666 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2667
2668         * aarch64-linux-nat.c
2669         (aarch64_linux_nat_target::thread_architecture): Add override.
2670         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2671         each VQ.
2672
2673 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2674
2675         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2676
2677 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2678
2679         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2680         target types of size 96-bits, add some additional comments, and
2681         check that the builtin type we found was the correct size.
2682
2683 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2684
2685         * utils.c (prompt_for_continue): Don't restore the styling at the
2686         end, as applied_style has the wrong value.  This fixes styling in
2687         long lists of file names that are interrupted by the "Continue?"
2688         prompt.
2689
2690 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2691
2692         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2693         * c-lang.c (c_language_defn): Likewise.
2694         (cplus_language_defn): Likewise.
2695         (asm_language_defn): Likewise.
2696         (minimal_language_defn): Likewise.
2697         * d-lang.c (d_language_defn): Likewise.
2698         * f-lang.c (f_language_defn): Likewise.
2699         * go-lang.c (go_language_defn): Likewise.
2700         * language.c (unknown_language_defn): Likewise.
2701         (auto_language_defn): Likewise.
2702         * language.h (struct language_defn): Remove la_magic field.
2703         (LANG_MAGIC): Delete.
2704         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2705         * objc-lang.c (objc_language_defn): Likewise.
2706         * opencl-lang.c (opencl_language_defn): Likewise.
2707         * p-lang.c (pascal_language_defn): Likewise.
2708         * rust-lang.c (rust_language_defn): Likewise.
2709
2710 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2711
2712         * riscv-tdep.c (riscv_type_align): New function.
2713         (riscv_type_alignment): Delete.
2714         (riscv_arg_location): Use 'type_align'.
2715         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2716
2717 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2718
2719         * gdbtypes.c (type_align): A struct with no non-static fields also
2720         has alignment of 1.
2721
2722 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2723
2724         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2725         component to 0.
2726         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2727         member.
2728         (riscv_struct_info::analyse): New implementation using new
2729         analyse_inner member function.
2730         (riscv_struct_info::field_offset): New member function.
2731         (riscv_struct_info::m_offsets): New member variable.
2732         (riscv_struct_info::analyse_inner): New private member function,
2733         takes the old implementation of riscv_struct_info::analyse but
2734         extended to track field offsets.
2735         (riscv_call_arg_struct): Update the struct folding special cases
2736         to handle cases where empty C++ structs, which are non-zero
2737         length, are found.
2738         (riscv_arg_location): Initialise the length of each location, a
2739         non-zero length now indicates the location is in use.
2740         (riscv_push_dummy_call): Allow for the first location having a
2741         non-zero offset when setting up arguments.
2742         (riscv_return_value): Likewise, but for return values.
2743
2744 2019-04-11  Tom Tromey  <tromey@adacore.com>
2745
2746         * utils.c (internal_vproblem): Make "msg" const.
2747
2748 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2749
2750         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2751         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2752         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2753         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2754
2755 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2756
2757         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2758         function.
2759         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2760         of amd64_collect_native_gregset.
2761         (amd64_linux_nat_target::store_registers): Likewise.
2762
2763 2019-04-10  Tom Tromey  <tom@tromey.com>
2764
2765         * symtab.c (lookup_global_symbol_from_objfile)
2766         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2767         * objfiles.h (class separate_debug_iterator): New.
2768         (class separate_debug_range): New.
2769         (struct objfile) <separate_debug_objfiles>: New method.
2770         (objfile_separate_debug_iterate): Don't declare.
2771         * objfiles.c (separate_debug_iterator::operator++): Rename from
2772         objfile_separate_debug_iterate.
2773         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2774         iterator.
2775         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2776         iterator.
2777
2778 2019-04-10  Tom Tromey  <tom@tromey.com>
2779
2780         * symfile.c (reread_symbols): Remove old comment.
2781         * objfiles.c (free_all_objfiles): Fix a typo.
2782
2783 2019-04-10  Tom Tromey  <tom@tromey.com>
2784
2785         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2786         * minsyms.c (lookup_minimal_symbol): Use foreach.
2787         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2788         (lookup_minimal_symbol_solib_trampoline): Likewise.
2789         * symfile.c (reread_symbols): Use foreach.
2790
2791 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2792             Tom Tromey  <tromey@adacore.com>
2793
2794         PR rust/24414:
2795         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2796         (rust_lex_int_test): Change "value" to be LONGEST.
2797         (rust_lex_tests): Add test for long integer literal.
2798
2799 2019-04-09  Tom Tromey  <tromey@adacore.com>
2800
2801         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2802         to bool.
2803         (extended_remote_target::attach): Update.
2804         (remote_target::remote_notice_new_inferior): Update.
2805         (remote_target::add_current_inferior_and_thread): Update.
2806         * inferior.c (exit_inferior_1): Use "false".
2807         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2808
2809 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2810
2811         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2812         the "start" command.
2813
2814 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2815
2816         * python/py-inferior.c (infpy_thread_from_thread_handle):
2817         Adjust comments to reflect renaming of thread_from_thread_handle
2818         to thread_from_handle.  Adjust keywords.  Fix type error message.
2819         (inferior_object_methods): Add thread_from_handle.  Retain
2820         thread_from_thread_handle, but mark it as deprecated.
2821
2822 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2823
2824         * gdbthread.h (find_thread_by_handle): Revise declaration.
2825         * thread.c (find_thread_by_handle): Likewise.  Adjust
2826         implementation too.
2827         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2828         support for buffer objects as handles.
2829
2830 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2831
2832         * python/py-infthread.c (thpy_thread_handle): New function.
2833         (thread_object_methods): Register thpy_thread_handle.
2834
2835 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2836
2837         * gdbthread.h (thread_to_thread_handle): Declare.
2838         * thread.c (gdbtypes.h): Include.
2839         (thread_to_thread_handle): New function.
2840
2841         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2842         (target_thread_info_to_thread_handle): Declare.
2843         * target.c (target_thread_info_to_thread_handle): New function.
2844         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2845         * target-delegates.c: Regenerate.
2846
2847         * linux-thread-db.c (class thread_db_target): Add method
2848         thread_info_to_thread_handle.
2849         (thread_db_target::thread_info_to_thread_handle): Define.
2850         * remote.c (class remote_target): Add new method
2851         thread_info_to_thread_handle.
2852         (remote_target::thread_info_to_thread_handle): Define.
2853
2854 2019-04-08  Pedro Alves  <palves@redhat.com>
2855
2856         * common/common-exceptions.c (throw_exception): Don't create
2857         named object to throw; throw directly.
2858         (throw_it): Likewise.  Don't initialize gdb_exception::message
2859         here, with new; pass FMT and AP to the ctor instead.
2860         * common/common-exceptions.h: Include <string>.
2861         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2862         const char *, va_list)): New ctor.  Use std::make_shared.
2863         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2864         errors)): Delete.
2865         (gdb_exception_error::gdb_exception_error(enum errors, const char
2866         *, va_list)): New.
2867         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2868         Add assertion.
2869         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2870         errors)): Delete.
2871         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2872         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2873         Add assertion.
2874
2875 2019-04-08  Tom Tromey  <tom@tromey.com>
2876
2877         * valops.c (value_rtti_indirect_type): Replace throw_exception
2878         with throw.
2879         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2880         with throw.
2881         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2882         throw.
2883         * target.c (target_translate_tls_address): Replace throw_exception
2884         with throw.
2885         * stack.c (frame_apply_command_count): Replace throw_exception
2886         with throw.
2887         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2888         throw.
2889         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2890         with throw.
2891         * rs6000-tdep.c (rs6000_frame_cache)
2892         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2893         * remote.c: Replace throw_exception with throw.
2894         * record-full.c (record_full_message, record_full_wait_1)
2895         (record_full_restore): Replace throw_exception with throw.
2896         * record-btrace.c:
2897         (get_thread_current_frame_id, record_btrace_start_replaying)
2898         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2899         (cmd_record_btrace_start): Replace throw_exception with throw.
2900         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2901         throw.
2902         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2903         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2904         * linespec.c:
2905         (find_linespec_symbols): Replace throw_exception with throw.
2906         * infrun.c (displaced_step_prepare, resume): Replace
2907         throw_exception with throw.
2908         * infcmd.c (post_create_inferior): Replace throw_exception with
2909         throw.
2910         * inf-loop.c (inferior_event_handler): Replace throw_exception
2911         with throw.
2912         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2913         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2914         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2915         (get_prev_frame_always, get_frame_pc_if_available)
2916         (get_frame_address_in_block_if_available, get_frame_language):
2917         Replace throw_exception with throw.
2918         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2919         throw_exception with throw.
2920         * eval.c (fetch_subexp_value, evaluate_var_value)
2921         (evaluate_funcall, evaluate_subexp_standard): Replace
2922         throw_exception with throw.
2923         * dwarf2loc.c (call_site_find_chain)
2924         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2925         Replace throw_exception with throw.
2926         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2927         with throw.
2928         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2929         throw.
2930         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2931         * completer.c (complete_line_internal): Replace throw_exception
2932         with throw.
2933         * compile/compile-object-run.c (compile_object_run): Replace
2934         throw_exception with throw.
2935         * cli/cli-script.c (process_next_line): Replace throw_exception
2936         with throw.
2937         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2938         (btrace_enable, btrace_maint_update_pt_packets): Replace
2939         throw_exception with throw.
2940         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2941         throw_exception with throw.
2942         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2943         throw_exception with throw.
2944         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2945         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2946         * aarch64-tdep.c (aarch64_make_prologue_cache)
2947         (aarch64_make_stub_cache): Replace throw_exception with throw.
2948
2949 2019-04-08  Tom Tromey  <tom@tromey.com>
2950
2951         * common/common-exceptions.c (throw_exception): Rename from
2952         throw_exception_cxx.  Remove old copy.  Make argument const.
2953         (throw_it): Create and throw exception objects directly.
2954         * common/common-exceptions.h (throw_exception): Make argument
2955         const.
2956         (struct gdb_exception_error): Add constructor.
2957         (struct gdb_exception_quit): Add constructor.
2958
2959 2019-04-08  Tom Tromey  <tom@tromey.com>
2960
2961         * common/common-exceptions.h (exception_rethrow): Don't declare.
2962         (TRY_SJLJ): Update comment.
2963         (TRY, CATCH, END_CATCH): Remove.
2964         * common/common-exceptions.c (exception_rethrow): Remove.
2965
2966 2019-04-08  Tom Tromey  <tom@tromey.com>
2967
2968         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2969         Remove.
2970         (gdb_exception_error): Rename from
2971         gdb_exception_RETURN_MASK_ERROR.
2972         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2973         (gdb_quit_bad_alloc): Update.
2974         * aarch64-tdep.c: Update.
2975         * ada-lang.c: Update.
2976         * ada-typeprint.c: Update.
2977         * ada-valprint.c: Update.
2978         * amd64-tdep.c: Update.
2979         * arch-utils.c: Update.
2980         * break-catch-throw.c: Update.
2981         * breakpoint.c: Update.
2982         * btrace.c: Update.
2983         * c-varobj.c: Update.
2984         * cli/cli-cmds.c: Update.
2985         * cli/cli-interp.c: Update.
2986         * cli/cli-script.c: Update.
2987         * common/common-exceptions.c: Update.
2988         * common/new-op.c: Update.
2989         * common/selftest.c: Update.
2990         * compile/compile-c-symbols.c: Update.
2991         * compile/compile-cplus-symbols.c: Update.
2992         * compile/compile-object-load.c: Update.
2993         * compile/compile-object-run.c: Update.
2994         * completer.c: Update.
2995         * corelow.c: Update.
2996         * cp-abi.c: Update.
2997         * cp-support.c: Update.
2998         * cp-valprint.c: Update.
2999         * darwin-nat.c: Update.
3000         * disasm-selftests.c: Update.
3001         * dtrace-probe.c: Update.
3002         * dwarf-index-cache.c: Update.
3003         * dwarf-index-write.c: Update.
3004         * dwarf2-frame-tailcall.c: Update.
3005         * dwarf2-frame.c: Update.
3006         * dwarf2loc.c: Update.
3007         * dwarf2read.c: Update.
3008         * eval.c: Update.
3009         * event-loop.c: Update.
3010         * event-top.c: Update.
3011         * exec.c: Update.
3012         * f-valprint.c: Update.
3013         * fbsd-tdep.c: Update.
3014         * frame-unwind.c: Update.
3015         * frame.c: Update.
3016         * gdbtypes.c: Update.
3017         * gnu-v3-abi.c: Update.
3018         * guile/guile-internal.h: Update.
3019         * guile/scm-block.c: Update.
3020         * guile/scm-breakpoint.c: Update.
3021         * guile/scm-cmd.c: Update.
3022         * guile/scm-disasm.c: Update.
3023         * guile/scm-frame.c: Update.
3024         * guile/scm-lazy-string.c: Update.
3025         * guile/scm-math.c: Update.
3026         * guile/scm-param.c: Update.
3027         * guile/scm-ports.c: Update.
3028         * guile/scm-pretty-print.c: Update.
3029         * guile/scm-symbol.c: Update.
3030         * guile/scm-symtab.c: Update.
3031         * guile/scm-type.c: Update.
3032         * guile/scm-value.c: Update.
3033         * i386-linux-tdep.c: Update.
3034         * i386-tdep.c: Update.
3035         * inf-loop.c: Update.
3036         * infcall.c: Update.
3037         * infcmd.c: Update.
3038         * infrun.c: Update.
3039         * jit.c: Update.
3040         * language.c: Update.
3041         * linespec.c: Update.
3042         * linux-fork.c: Update.
3043         * linux-nat.c: Update.
3044         * linux-tdep.c: Update.
3045         * linux-thread-db.c: Update.
3046         * main.c: Update.
3047         * mi/mi-cmd-break.c: Update.
3048         * mi/mi-cmd-stack.c: Update.
3049         * mi/mi-interp.c: Update.
3050         * mi/mi-main.c: Update.
3051         * objc-lang.c: Update.
3052         * p-valprint.c: Update.
3053         * parse.c: Update.
3054         * ppc-linux-tdep.c: Update.
3055         * printcmd.c: Update.
3056         * python/py-arch.c: Update.
3057         * python/py-breakpoint.c: Update.
3058         * python/py-cmd.c: Update.
3059         * python/py-finishbreakpoint.c: Update.
3060         * python/py-frame.c: Update.
3061         * python/py-framefilter.c: Update.
3062         * python/py-gdb-readline.c: Update.
3063         * python/py-inferior.c: Update.
3064         * python/py-infthread.c: Update.
3065         * python/py-lazy-string.c: Update.
3066         * python/py-linetable.c: Update.
3067         * python/py-objfile.c: Update.
3068         * python/py-param.c: Update.
3069         * python/py-prettyprint.c: Update.
3070         * python/py-progspace.c: Update.
3071         * python/py-record-btrace.c: Update.
3072         * python/py-record.c: Update.
3073         * python/py-symbol.c: Update.
3074         * python/py-type.c: Update.
3075         * python/py-unwind.c: Update.
3076         * python/py-utils.c: Update.
3077         * python/py-value.c: Update.
3078         * python/python.c: Update.
3079         * record-btrace.c: Update.
3080         * record-full.c: Update.
3081         * remote-fileio.c: Update.
3082         * remote.c: Update.
3083         * riscv-tdep.c: Update.
3084         * rs6000-aix-tdep.c: Update.
3085         * rs6000-tdep.c: Update.
3086         * rust-exp.y: Update.
3087         * rust-lang.c: Update.
3088         * s390-tdep.c: Update.
3089         * selftest-arch.c: Update.
3090         * solib-dsbt.c: Update.
3091         * solib-frv.c: Update.
3092         * solib-spu.c: Update.
3093         * solib-svr4.c: Update.
3094         * solib.c: Update.
3095         * sparc64-linux-tdep.c: Update.
3096         * stack.c: Update.
3097         * symfile-mem.c: Update.
3098         * symmisc.c: Update.
3099         * target.c: Update.
3100         * thread.c: Update.
3101         * top.c: Update.
3102         * tracefile-tfile.c: Update.
3103         * tui/tui.c: Update.
3104         * typeprint.c: Update.
3105         * unittests/cli-utils-selftests.c: Update.
3106         * unittests/parse-connection-spec-selftests.c: Update.
3107         * valops.c: Update.
3108         * valprint.c: Update.
3109         * value.c: Update.
3110         * varobj.c: Update.
3111         * windows-nat.c: Update.
3112         * x86-linux-nat.c: Update.
3113         * xml-support.c: Update.
3114
3115 2019-04-08  Tom Tromey  <tom@tromey.com>
3116
3117         * xml-support.c: Use C++ exception handling.
3118         * x86-linux-nat.c: Use C++ exception handling.
3119         * windows-nat.c: Use C++ exception handling.
3120         * varobj.c: Use C++ exception handling.
3121         * value.c: Use C++ exception handling.
3122         * valprint.c: Use C++ exception handling.
3123         * valops.c: Use C++ exception handling.
3124         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3125         handling.
3126         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3127         * typeprint.c: Use C++ exception handling.
3128         * tui/tui.c: Use C++ exception handling.
3129         * tracefile-tfile.c: Use C++ exception handling.
3130         * top.c: Use C++ exception handling.
3131         * thread.c: Use C++ exception handling.
3132         * target.c: Use C++ exception handling.
3133         * symmisc.c: Use C++ exception handling.
3134         * symfile-mem.c: Use C++ exception handling.
3135         * stack.c: Use C++ exception handling.
3136         * sparc64-linux-tdep.c: Use C++ exception handling.
3137         * solib.c: Use C++ exception handling.
3138         * solib-svr4.c: Use C++ exception handling.
3139         * solib-spu.c: Use C++ exception handling.
3140         * solib-frv.c: Use C++ exception handling.
3141         * solib-dsbt.c: Use C++ exception handling.
3142         * selftest-arch.c: Use C++ exception handling.
3143         * s390-tdep.c: Use C++ exception handling.
3144         * rust-lang.c: Use C++ exception handling.
3145         * rust-exp.y: Use C++ exception handling.
3146         * rs6000-tdep.c: Use C++ exception handling.
3147         * rs6000-aix-tdep.c: Use C++ exception handling.
3148         * riscv-tdep.c: Use C++ exception handling.
3149         * remote.c: Use C++ exception handling.
3150         * remote-fileio.c: Use C++ exception handling.
3151         * record-full.c: Use C++ exception handling.
3152         * record-btrace.c: Use C++ exception handling.
3153         * python/python.c: Use C++ exception handling.
3154         * python/py-value.c: Use C++ exception handling.
3155         * python/py-utils.c: Use C++ exception handling.
3156         * python/py-unwind.c: Use C++ exception handling.
3157         * python/py-type.c: Use C++ exception handling.
3158         * python/py-symbol.c: Use C++ exception handling.
3159         * python/py-record.c: Use C++ exception handling.
3160         * python/py-record-btrace.c: Use C++ exception handling.
3161         * python/py-progspace.c: Use C++ exception handling.
3162         * python/py-prettyprint.c: Use C++ exception handling.
3163         * python/py-param.c: Use C++ exception handling.
3164         * python/py-objfile.c: Use C++ exception handling.
3165         * python/py-linetable.c: Use C++ exception handling.
3166         * python/py-lazy-string.c: Use C++ exception handling.
3167         * python/py-infthread.c: Use C++ exception handling.
3168         * python/py-inferior.c: Use C++ exception handling.
3169         * python/py-gdb-readline.c: Use C++ exception handling.
3170         * python/py-framefilter.c: Use C++ exception handling.
3171         * python/py-frame.c: Use C++ exception handling.
3172         * python/py-finishbreakpoint.c: Use C++ exception handling.
3173         * python/py-cmd.c: Use C++ exception handling.
3174         * python/py-breakpoint.c: Use C++ exception handling.
3175         * python/py-arch.c: Use C++ exception handling.
3176         * printcmd.c: Use C++ exception handling.
3177         * ppc-linux-tdep.c: Use C++ exception handling.
3178         * parse.c: Use C++ exception handling.
3179         * p-valprint.c: Use C++ exception handling.
3180         * objc-lang.c: Use C++ exception handling.
3181         * mi/mi-main.c: Use C++ exception handling.
3182         * mi/mi-interp.c: Use C++ exception handling.
3183         * mi/mi-cmd-stack.c: Use C++ exception handling.
3184         * mi/mi-cmd-break.c: Use C++ exception handling.
3185         * main.c: Use C++ exception handling.
3186         * linux-thread-db.c: Use C++ exception handling.
3187         * linux-tdep.c: Use C++ exception handling.
3188         * linux-nat.c: Use C++ exception handling.
3189         * linux-fork.c: Use C++ exception handling.
3190         * linespec.c: Use C++ exception handling.
3191         * language.c: Use C++ exception handling.
3192         * jit.c: Use C++ exception handling.
3193         * infrun.c: Use C++ exception handling.
3194         * infcmd.c: Use C++ exception handling.
3195         * infcall.c: Use C++ exception handling.
3196         * inf-loop.c: Use C++ exception handling.
3197         * i386-tdep.c: Use C++ exception handling.
3198         * i386-linux-tdep.c: Use C++ exception handling.
3199         * guile/scm-value.c: Use C++ exception handling.
3200         * guile/scm-type.c: Use C++ exception handling.
3201         * guile/scm-symtab.c: Use C++ exception handling.
3202         * guile/scm-symbol.c: Use C++ exception handling.
3203         * guile/scm-pretty-print.c: Use C++ exception handling.
3204         * guile/scm-ports.c: Use C++ exception handling.
3205         * guile/scm-param.c: Use C++ exception handling.
3206         * guile/scm-math.c: Use C++ exception handling.
3207         * guile/scm-lazy-string.c: Use C++ exception handling.
3208         * guile/scm-frame.c: Use C++ exception handling.
3209         * guile/scm-disasm.c: Use C++ exception handling.
3210         * guile/scm-cmd.c: Use C++ exception handling.
3211         * guile/scm-breakpoint.c: Use C++ exception handling.
3212         * guile/scm-block.c: Use C++ exception handling.
3213         * guile/guile-internal.h: Use C++ exception handling.
3214         * gnu-v3-abi.c: Use C++ exception handling.
3215         * gdbtypes.c: Use C++ exception handling.
3216         * frame.c: Use C++ exception handling.
3217         * frame-unwind.c: Use C++ exception handling.
3218         * fbsd-tdep.c: Use C++ exception handling.
3219         * f-valprint.c: Use C++ exception handling.
3220         * exec.c: Use C++ exception handling.
3221         * event-top.c: Use C++ exception handling.
3222         * event-loop.c: Use C++ exception handling.
3223         * eval.c: Use C++ exception handling.
3224         * dwarf2read.c: Use C++ exception handling.
3225         * dwarf2loc.c: Use C++ exception handling.
3226         * dwarf2-frame.c: Use C++ exception handling.
3227         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3228         * dwarf-index-write.c: Use C++ exception handling.
3229         * dwarf-index-cache.c: Use C++ exception handling.
3230         * dtrace-probe.c: Use C++ exception handling.
3231         * disasm-selftests.c: Use C++ exception handling.
3232         * darwin-nat.c: Use C++ exception handling.
3233         * cp-valprint.c: Use C++ exception handling.
3234         * cp-support.c: Use C++ exception handling.
3235         * cp-abi.c: Use C++ exception handling.
3236         * corelow.c: Use C++ exception handling.
3237         * completer.c: Use C++ exception handling.
3238         * compile/compile-object-run.c: Use C++ exception handling.
3239         * compile/compile-object-load.c: Use C++ exception handling.
3240         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3241         * compile/compile-c-symbols.c: Use C++ exception handling.
3242         * common/selftest.c: Use C++ exception handling.
3243         * common/new-op.c: Use C++ exception handling.
3244         * cli/cli-script.c: Use C++ exception handling.
3245         * cli/cli-interp.c: Use C++ exception handling.
3246         * cli/cli-cmds.c: Use C++ exception handling.
3247         * c-varobj.c: Use C++ exception handling.
3248         * btrace.c: Use C++ exception handling.
3249         * breakpoint.c: Use C++ exception handling.
3250         * break-catch-throw.c: Use C++ exception handling.
3251         * arch-utils.c: Use C++ exception handling.
3252         * amd64-tdep.c: Use C++ exception handling.
3253         * ada-valprint.c: Use C++ exception handling.
3254         * ada-typeprint.c: Use C++ exception handling.
3255         * ada-lang.c: Use C++ exception handling.
3256         * aarch64-tdep.c: Use C++ exception handling.
3257
3258 2019-04-08  Tom Tromey  <tom@tromey.com>
3259
3260         * xml-support.c (gdb_xml_parser::parse): Update.
3261         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3262         * value.c (show_convenience): Update.
3263         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3264         (test_parse_flags_qcs): Update.
3265         * thread.c (thr_try_catch_cmd): Update.
3266         * target.c (target_translate_tls_address): Update.
3267         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3268         (info_frame_command_core, frame_apply_command_count): Update.
3269         * rust-exp.y (rust_lex_exception_test): Update.
3270         * riscv-tdep.c (riscv_print_one_register_info): Update.
3271         * remote.c (remote_target::enable_btrace): Update.
3272         * record-btrace.c (record_btrace_enable_warn): Update.
3273         * python/py-utils.c (gdbpy_convert_exception): Update.
3274         * printcmd.c (do_one_display, print_variable_and_value): Update.
3275         * mi/mi-main.c (mi_print_exception): Update.
3276         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3277         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3278         * linux-nat.c (linux_nat_target::attach): Update.
3279         * linux-fork.c (class scoped_switch_fork_info): Update.
3280         * infrun.c (displaced_step_prepare): Update.
3281         * infcall.c (call_function_by_hand_dummy): Update.
3282         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3283         * gnu-v3-abi.c (print_one_vtable): Update.
3284         * frame.c (get_prev_frame_always): Update.
3285         * f-valprint.c (info_common_command_for_block): Update.
3286         * exec.c (try_open_exec_file): Update.
3287         * exceptions.c (print_exception, exception_print)
3288         (exception_fprintf, exception_print_same): Update.
3289         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3290         * dwarf-index-cache.c (index_cache::store)
3291         (index_cache::lookup_gdb_index): Update.
3292         * darwin-nat.c (maybe_cache_shell): Update.
3293         * cp-valprint.c (cp_print_value_fields): Update.
3294         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3295         (gcc_cplus_symbol_address): Update.
3296         * compile/compile-c-symbols.c (gcc_convert_symbol)
3297         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3298         * common/selftest.c: Update.
3299         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3300         a std::string.
3301         (exception_try_scope_entry, exception_try_scope_exit): Don't
3302         declare.
3303         (struct exception_try_scope): Remove.
3304         (TRY): Don't use exception_try_scope.
3305         (struct gdb_exception): Add constructor, operator=.
3306         <what>: New method.
3307         (struct gdb_exception_RETURN_MASK_ALL)
3308         (struct gdb_exception_RETURN_MASK_ERROR)
3309         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3310         (struct gdb_quit_bad_alloc): Update.
3311         * common/common-exceptions.c (exception_none): Change
3312         initializer.
3313         (struct catcher) <state, exception>: Initialize inline.
3314         <prev>: Remove member.
3315         (current_catcher): Remove.
3316         (catchers): New global.
3317         (exceptions_state_mc_init): Simplify.
3318         (catcher_pop): Remove.
3319         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3320         (try_scope_depth, exception_try_scope_entry)
3321         (exception_try_scope_exit): Remove.
3322         (throw_exception_sjlj): Update.
3323         (exception_messages, exception_messages_size): Remove.
3324         (throw_it): Simplify.
3325         (gdb_exception_sliced_copy): Remove.
3326         (throw_exception_cxx): Update.
3327         * cli/cli-script.c (script_from_file): Update.
3328         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3329         Update.
3330         * ada-valprint.c (ada_val_print): Update.
3331         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3332         (create_excep_cond_exprs): Update.
3333
3334 2019-04-08  Tom Tromey  <tom@tromey.com>
3335
3336         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3337         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3338         (TRY, CATCH, END_CATCH): Remove some definitions.
3339         * common/common-exceptions.c: Don't use GDB_XCPT.
3340         (catcher_list_size): Remove.
3341         (throw_exception, throw_it): Simplify.
3342
3343 2019-04-05  Tom Tromey  <tom@tromey.com>
3344
3345         Revert the header-sorting patch.
3346         * ft32-tdep.c: Revert.
3347         * frv-tdep.c: Revert.
3348         * frv-linux-tdep.c: Revert.
3349         * frame.c: Revert.
3350         * frame-unwind.c: Revert.
3351         * frame-base.c: Revert.
3352         * fork-child.c: Revert.
3353         * findvar.c: Revert.
3354         * findcmd.c: Revert.
3355         * filesystem.c: Revert.
3356         * filename-seen-cache.h: Revert.
3357         * filename-seen-cache.c: Revert.
3358         * fbsd-tdep.c: Revert.
3359         * fbsd-nat.h: Revert.
3360         * fbsd-nat.c: Revert.
3361         * f-valprint.c: Revert.
3362         * f-typeprint.c: Revert.
3363         * f-lang.c: Revert.
3364         * extension.h: Revert.
3365         * extension.c: Revert.
3366         * extension-priv.h: Revert.
3367         * expprint.c: Revert.
3368         * exec.h: Revert.
3369         * exec.c: Revert.
3370         * exceptions.c: Revert.
3371         * event-top.c: Revert.
3372         * event-loop.c: Revert.
3373         * eval.c: Revert.
3374         * elfread.c: Revert.
3375         * dwarf2read.h: Revert.
3376         * dwarf2read.c: Revert.
3377         * dwarf2loc.c: Revert.
3378         * dwarf2expr.h: Revert.
3379         * dwarf2expr.c: Revert.
3380         * dwarf2-frame.c: Revert.
3381         * dwarf2-frame-tailcall.c: Revert.
3382         * dwarf-index-write.h: Revert.
3383         * dwarf-index-write.c: Revert.
3384         * dwarf-index-common.c: Revert.
3385         * dwarf-index-cache.h: Revert.
3386         * dwarf-index-cache.c: Revert.
3387         * dummy-frame.c: Revert.
3388         * dtrace-probe.c: Revert.
3389         * disasm.h: Revert.
3390         * disasm.c: Revert.
3391         * disasm-selftests.c: Revert.
3392         * dictionary.c: Revert.
3393         * dicos-tdep.c: Revert.
3394         * demangle.c: Revert.
3395         * dcache.h: Revert.
3396         * dcache.c: Revert.
3397         * darwin-nat.h: Revert.
3398         * darwin-nat.c: Revert.
3399         * darwin-nat-info.c: Revert.
3400         * d-valprint.c: Revert.
3401         * d-namespace.c: Revert.
3402         * d-lang.c: Revert.
3403         * ctf.c: Revert.
3404         * csky-tdep.c: Revert.
3405         * csky-linux-tdep.c: Revert.
3406         * cris-tdep.c: Revert.
3407         * cris-linux-tdep.c: Revert.
3408         * cp-valprint.c: Revert.
3409         * cp-support.c: Revert.
3410         * cp-namespace.c: Revert.
3411         * cp-abi.c: Revert.
3412         * corelow.c: Revert.
3413         * corefile.c: Revert.
3414         * continuations.c: Revert.
3415         * completer.h: Revert.
3416         * completer.c: Revert.
3417         * complaints.c: Revert.
3418         * coffread.c: Revert.
3419         * coff-pe-read.c: Revert.
3420         * cli-out.h: Revert.
3421         * cli-out.c: Revert.
3422         * charset.c: Revert.
3423         * c-varobj.c: Revert.
3424         * c-valprint.c: Revert.
3425         * c-typeprint.c: Revert.
3426         * c-lang.c: Revert.
3427         * buildsym.c: Revert.
3428         * buildsym-legacy.c: Revert.
3429         * build-id.h: Revert.
3430         * build-id.c: Revert.
3431         * btrace.c: Revert.
3432         * bsd-uthread.c: Revert.
3433         * breakpoint.h: Revert.
3434         * breakpoint.c: Revert.
3435         * break-catch-throw.c: Revert.
3436         * break-catch-syscall.c: Revert.
3437         * break-catch-sig.c: Revert.
3438         * blockframe.c: Revert.
3439         * block.c: Revert.
3440         * bfin-tdep.c: Revert.
3441         * bfin-linux-tdep.c: Revert.
3442         * bfd-target.c: Revert.
3443         * bcache.c: Revert.
3444         * ax-general.c: Revert.
3445         * ax-gdb.h: Revert.
3446         * ax-gdb.c: Revert.
3447         * avr-tdep.c: Revert.
3448         * auxv.c: Revert.
3449         * auto-load.c: Revert.
3450         * arm-wince-tdep.c: Revert.
3451         * arm-tdep.c: Revert.
3452         * arm-symbian-tdep.c: Revert.
3453         * arm-pikeos-tdep.c: Revert.
3454         * arm-obsd-tdep.c: Revert.
3455         * arm-nbsd-tdep.c: Revert.
3456         * arm-nbsd-nat.c: Revert.
3457         * arm-linux-tdep.c: Revert.
3458         * arm-linux-nat.c: Revert.
3459         * arm-fbsd-tdep.c: Revert.
3460         * arm-fbsd-nat.c: Revert.
3461         * arm-bsd-tdep.c: Revert.
3462         * arch-utils.c: Revert.
3463         * arc-tdep.c: Revert.
3464         * arc-newlib-tdep.c: Revert.
3465         * annotate.h: Revert.
3466         * annotate.c: Revert.
3467         * amd64-windows-tdep.c: Revert.
3468         * amd64-windows-nat.c: Revert.
3469         * amd64-tdep.c: Revert.
3470         * amd64-sol2-tdep.c: Revert.
3471         * amd64-obsd-tdep.c: Revert.
3472         * amd64-obsd-nat.c: Revert.
3473         * amd64-nbsd-tdep.c: Revert.
3474         * amd64-nbsd-nat.c: Revert.
3475         * amd64-nat.c: Revert.
3476         * amd64-linux-tdep.c: Revert.
3477         * amd64-linux-nat.c: Revert.
3478         * amd64-fbsd-tdep.c: Revert.
3479         * amd64-fbsd-nat.c: Revert.
3480         * amd64-dicos-tdep.c: Revert.
3481         * amd64-darwin-tdep.c: Revert.
3482         * amd64-bsd-nat.c: Revert.
3483         * alpha-tdep.c: Revert.
3484         * alpha-obsd-tdep.c: Revert.
3485         * alpha-nbsd-tdep.c: Revert.
3486         * alpha-mdebug-tdep.c: Revert.
3487         * alpha-linux-tdep.c: Revert.
3488         * alpha-linux-nat.c: Revert.
3489         * alpha-bsd-tdep.c: Revert.
3490         * alpha-bsd-nat.c: Revert.
3491         * aix-thread.c: Revert.
3492         * agent.c: Revert.
3493         * addrmap.c: Revert.
3494         * ada-varobj.c: Revert.
3495         * ada-valprint.c: Revert.
3496         * ada-typeprint.c: Revert.
3497         * ada-tasks.c: Revert.
3498         * ada-lang.c: Revert.
3499         * aarch64-tdep.c: Revert.
3500         * aarch64-ravenscar-thread.c: Revert.
3501         * aarch64-newlib-tdep.c: Revert.
3502         * aarch64-linux-tdep.c: Revert.
3503         * aarch64-linux-nat.c: Revert.
3504         * aarch64-fbsd-tdep.c: Revert.
3505         * aarch64-fbsd-nat.c: Revert.
3506         * aarch32-linux-nat.c: Revert.
3507
3508 2019-04-05  Tom Tromey  <tom@tromey.com>
3509
3510         * ft32-tdep.c: Sort headers.
3511         * frv-tdep.c: Sort headers.
3512         * frv-linux-tdep.c: Sort headers.
3513         * frame.c: Sort headers.
3514         * frame-unwind.c: Sort headers.
3515         * frame-base.c: Sort headers.
3516         * fork-child.c: Sort headers.
3517         * findvar.c: Sort headers.
3518         * findcmd.c: Sort headers.
3519         * filesystem.c: Sort headers.
3520         * filename-seen-cache.h: Sort headers.
3521         * filename-seen-cache.c: Sort headers.
3522         * fbsd-tdep.c: Sort headers.
3523         * fbsd-nat.h: Sort headers.
3524         * fbsd-nat.c: Sort headers.
3525         * f-valprint.c: Sort headers.
3526         * f-typeprint.c: Sort headers.
3527         * f-lang.c: Sort headers.
3528         * extension.h: Sort headers.
3529         * extension.c: Sort headers.
3530         * extension-priv.h: Sort headers.
3531         * expprint.c: Sort headers.
3532         * exec.h: Sort headers.
3533         * exec.c: Sort headers.
3534         * exceptions.c: Sort headers.
3535         * event-top.c: Sort headers.
3536         * event-loop.c: Sort headers.
3537         * eval.c: Sort headers.
3538         * elfread.c: Sort headers.
3539         * dwarf2read.h: Sort headers.
3540         * dwarf2read.c: Sort headers.
3541         * dwarf2loc.c: Sort headers.
3542         * dwarf2expr.h: Sort headers.
3543         * dwarf2expr.c: Sort headers.
3544         * dwarf2-frame.c: Sort headers.
3545         * dwarf2-frame-tailcall.c: Sort headers.
3546         * dwarf-index-write.h: Sort headers.
3547         * dwarf-index-write.c: Sort headers.
3548         * dwarf-index-common.c: Sort headers.
3549         * dwarf-index-cache.h: Sort headers.
3550         * dwarf-index-cache.c: Sort headers.
3551         * dummy-frame.c: Sort headers.
3552         * dtrace-probe.c: Sort headers.
3553         * disasm.h: Sort headers.
3554         * disasm.c: Sort headers.
3555         * disasm-selftests.c: Sort headers.
3556         * dictionary.c: Sort headers.
3557         * dicos-tdep.c: Sort headers.
3558         * demangle.c: Sort headers.
3559         * dcache.h: Sort headers.
3560         * dcache.c: Sort headers.
3561         * darwin-nat.h: Sort headers.
3562         * darwin-nat.c: Sort headers.
3563         * darwin-nat-info.c: Sort headers.
3564         * d-valprint.c: Sort headers.
3565         * d-namespace.c: Sort headers.
3566         * d-lang.c: Sort headers.
3567         * ctf.c: Sort headers.
3568         * csky-tdep.c: Sort headers.
3569         * csky-linux-tdep.c: Sort headers.
3570         * cris-tdep.c: Sort headers.
3571         * cris-linux-tdep.c: Sort headers.
3572         * cp-valprint.c: Sort headers.
3573         * cp-support.c: Sort headers.
3574         * cp-namespace.c: Sort headers.
3575         * cp-abi.c: Sort headers.
3576         * corelow.c: Sort headers.
3577         * corefile.c: Sort headers.
3578         * continuations.c: Sort headers.
3579         * completer.h: Sort headers.
3580         * completer.c: Sort headers.
3581         * complaints.c: Sort headers.
3582         * coffread.c: Sort headers.
3583         * coff-pe-read.c: Sort headers.
3584         * cli-out.h: Sort headers.
3585         * cli-out.c: Sort headers.
3586         * charset.c: Sort headers.
3587         * c-varobj.c: Sort headers.
3588         * c-valprint.c: Sort headers.
3589         * c-typeprint.c: Sort headers.
3590         * c-lang.c: Sort headers.
3591         * buildsym.c: Sort headers.
3592         * buildsym-legacy.c: Sort headers.
3593         * build-id.h: Sort headers.
3594         * build-id.c: Sort headers.
3595         * btrace.c: Sort headers.
3596         * bsd-uthread.c: Sort headers.
3597         * breakpoint.h: Sort headers.
3598         * breakpoint.c: Sort headers.
3599         * break-catch-throw.c: Sort headers.
3600         * break-catch-syscall.c: Sort headers.
3601         * break-catch-sig.c: Sort headers.
3602         * blockframe.c: Sort headers.
3603         * block.c: Sort headers.
3604         * bfin-tdep.c: Sort headers.
3605         * bfin-linux-tdep.c: Sort headers.
3606         * bfd-target.c: Sort headers.
3607         * bcache.c: Sort headers.
3608         * ax-general.c: Sort headers.
3609         * ax-gdb.h: Sort headers.
3610         * ax-gdb.c: Sort headers.
3611         * avr-tdep.c: Sort headers.
3612         * auxv.c: Sort headers.
3613         * auto-load.c: Sort headers.
3614         * arm-wince-tdep.c: Sort headers.
3615         * arm-tdep.c: Sort headers.
3616         * arm-symbian-tdep.c: Sort headers.
3617         * arm-pikeos-tdep.c: Sort headers.
3618         * arm-obsd-tdep.c: Sort headers.
3619         * arm-nbsd-tdep.c: Sort headers.
3620         * arm-nbsd-nat.c: Sort headers.
3621         * arm-linux-tdep.c: Sort headers.
3622         * arm-linux-nat.c: Sort headers.
3623         * arm-fbsd-tdep.c: Sort headers.
3624         * arm-fbsd-nat.c: Sort headers.
3625         * arm-bsd-tdep.c: Sort headers.
3626         * arch-utils.c: Sort headers.
3627         * arc-tdep.c: Sort headers.
3628         * arc-newlib-tdep.c: Sort headers.
3629         * annotate.h: Sort headers.
3630         * annotate.c: Sort headers.
3631         * amd64-windows-tdep.c: Sort headers.
3632         * amd64-windows-nat.c: Sort headers.
3633         * amd64-tdep.c: Sort headers.
3634         * amd64-sol2-tdep.c: Sort headers.
3635         * amd64-obsd-tdep.c: Sort headers.
3636         * amd64-obsd-nat.c: Sort headers.
3637         * amd64-nbsd-tdep.c: Sort headers.
3638         * amd64-nbsd-nat.c: Sort headers.
3639         * amd64-nat.c: Sort headers.
3640         * amd64-linux-tdep.c: Sort headers.
3641         * amd64-linux-nat.c: Sort headers.
3642         * amd64-fbsd-tdep.c: Sort headers.
3643         * amd64-fbsd-nat.c: Sort headers.
3644         * amd64-dicos-tdep.c: Sort headers.
3645         * amd64-darwin-tdep.c: Sort headers.
3646         * amd64-bsd-nat.c: Sort headers.
3647         * alpha-tdep.c: Sort headers.
3648         * alpha-obsd-tdep.c: Sort headers.
3649         * alpha-nbsd-tdep.c: Sort headers.
3650         * alpha-mdebug-tdep.c: Sort headers.
3651         * alpha-linux-tdep.c: Sort headers.
3652         * alpha-linux-nat.c: Sort headers.
3653         * alpha-bsd-tdep.c: Sort headers.
3654         * alpha-bsd-nat.c: Sort headers.
3655         * aix-thread.c: Sort headers.
3656         * agent.c: Sort headers.
3657         * addrmap.c: Sort headers.
3658         * ada-varobj.c: Sort headers.
3659         * ada-valprint.c: Sort headers.
3660         * ada-typeprint.c: Sort headers.
3661         * ada-tasks.c: Sort headers.
3662         * ada-lang.c: Sort headers.
3663         * aarch64-tdep.c: Sort headers.
3664         * aarch64-ravenscar-thread.c: Sort headers.
3665         * aarch64-newlib-tdep.c: Sort headers.
3666         * aarch64-linux-tdep.c: Sort headers.
3667         * aarch64-linux-nat.c: Sort headers.
3668         * aarch64-fbsd-tdep.c: Sort headers.
3669         * aarch64-fbsd-nat.c: Sort headers.
3670         * aarch32-linux-nat.c: Sort headers.
3671
3672 2019-04-04  Tom Tromey  <tom@tromey.com>
3673
3674         * varobj.c (varobj_create): Update.
3675         * rust-exp.y (struct rust_parser) <update_innermost_block,
3676         lookup_symbol>: New methods.
3677         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3678         Rename.
3679         (rust_parser::rust_lookup_type)
3680         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3681         * printcmd.c (display_command, do_one_display): Update.
3682         * parser-defs.h (struct parser_state) <parser_state>: Add
3683         "tracker" parameter.
3684         (block_tracker): New member.
3685         (class innermost_block_tracker) <innermost_block_tracker>: Add
3686         "types" parameter.
3687         <reset>: Remove method.
3688         (innermost_block): Don't declare.
3689         (null_post_parser): Update.
3690         * parse.c (innermost_block): Remove global.
3691         (write_dollar_variable): Update.
3692         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3693         Remove "tracker_types" parameter.
3694         (parse_expression): Add "tracker" parameter.
3695         (parse_expression_for_completion): Update.
3696         (null_post_parser): Add "tracker" parameter.
3697         * p-exp.y: Update rules.
3698         * m2-exp.y: Update rules.
3699         * language.h (struct language_defn) <la_post_parser>: Add
3700         "tracker" parameter.
3701         * go-exp.y: Update rules.
3702         * f-exp.y: Update rules.
3703         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3704         parameter.
3705         * d-exp.y: Update rules.
3706         * c-exp.y: Update rules.
3707         * breakpoint.c (set_breakpoint_condition): Create an
3708         innermost_block_tracker.
3709         (watch_command_1): Likewise.
3710         * ada-lang.c (resolve): Add "tracker" parameter.
3711         (resolve_subexp): Likewise.
3712         * ada-exp.y (write_var_from_sym): Update.
3713
3714 2019-04-04  Tom Tromey  <tom@tromey.com>
3715
3716         * type-stack.h: New file.
3717         * type-stack.c: New file.
3718         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3719         type-stack.h.
3720         (insert_into_type_stack, insert_type, push_type, push_type_int)
3721         (insert_type_address_space, pop_type, pop_type_int)
3722         (pop_typelist, pop_type_stack, append_type_stack)
3723         (push_type_stack, get_type_stack, push_typelist)
3724         (follow_type_instance_flags, follow_types): Don't declare.
3725         * parse.c (type_stack): Remove global.
3726         (parse_exp_in_context): Update.
3727         (insert_into_type_stack, insert_type, push_type, push_type_int)
3728         (insert_type_address_space, pop_type, pop_type_int)
3729         (pop_typelist, pop_type_stack, append_type_stack)
3730         (push_type_stack, get_type_stack, push_typelist)
3731         (follow_type_instance_flags, follow_types): Remove (moved to
3732         type-stack.c).
3733         * f-exp.y (type_stack): New global.
3734         Update rules.
3735         (push_kind_type, f_parse): Update.
3736         * d-exp.y (type_stack): New global.
3737         Update rules.
3738         (d_parse): Update.
3739         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3740         Update rules.
3741         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3742         (HFILES_NO_SRCDIR): Add type-stack.h.
3743
3744 2019-04-04  Tom Tromey  <tom@tromey.com>
3745
3746         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3747         (rust_parser::convert_ast_to_expression, rust_parse)
3748         (rust_lex_test_completion, rust_lex_tests): Update.
3749         * parser-defs.h (struct expr_completion_state): New.
3750         (struct parser_state) <parser_state>: Add completion parameter.
3751         <mark_struct_expression, mark_completion_tag>: New methods.
3752         <parse_completion, m_completion_state>: New members.
3753         (prefixify_expression, null_post_parser): Update.
3754         (mark_struct_expression, mark_completion_tag): Don't declare.
3755         * parse.c (parse_completion, expout_last_struct)
3756         (expout_tag_completion_type, expout_completion_name): Remove
3757         globals.
3758         (parser_state::mark_struct_expression)
3759         (parser_state::mark_completion_tag): Now methods.
3760         (prefixify_expression): Add last_struct parameter.
3761         (prefixify_subexp): Likewise.
3762         (parse_exp_1): Update.
3763         (parse_exp_in_context): Add cstate parameter.  Update.
3764         (parse_expression_for_completion): Create an
3765         expr_completion_state.
3766         (null_post_parser): Add "completion" parameter.
3767         * p-exp.y: Update rules.
3768         (yylex): Update.
3769         * language.h (struct language_defn) <la_post_parser>: Add
3770         "completing" parameter.
3771         * go-exp.y: Update rules.
3772         (lex_one_token): Update.
3773         * expression.h (parse_completion): Don't declare.
3774         * d-exp.y: Update rules.
3775         (lex_one_token): Update rules.
3776         * c-exp.y: Update rules.
3777         (lex_one_token): Update.
3778         * ada-lang.c (resolve): Add "parse_completion" parameter.
3779         (resolve_subexp): Likewise.
3780         (ada_resolve_function): Likewise.
3781
3782 2019-04-04  Tom Tromey  <tom@tromey.com>
3783
3784         * parser-defs.h (struct parser_state) <start_arglist,
3785         end_arglist>: New methods.
3786         <arglist_len, m_funcall_chain>: New members.
3787         (arglist_len, start_arglist, end_arglist): Don't declare.
3788         * parse.c (arglist_len, funcall_chain): Remove global.
3789         (start_arglist, end_arglist): Remove functions.
3790         (parse_exp_in_context): Update.
3791         * p-exp.y: Update rules.
3792         * m2-exp.y: Update rules.
3793         * go-exp.y: Update rules.
3794         * f-exp.y: Update rules.
3795         * d-exp.y: Update rules.
3796         * c-exp.y: Update rules.
3797
3798 2019-04-04  Tom Tromey  <tom@tromey.com>
3799
3800         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3801         lex_operator, push_back>: New methods.
3802         Update all rules.
3803         (rust_parser::lex_hex, lex_escape): Rename and update.
3804         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3805         (rust_parser::lex_operator): Rename and update.
3806         (rust_parser::lex_number, rustyylex, rustyyerror)
3807         (rust_lex_test_init, rust_lex_test_sequence)
3808         (rust_lex_test_push_back, rust_lex_tests): Update.
3809         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3810         parameter.
3811         <lexptr, prev_lexptr>: New members.
3812         (lexptr, prev_lexptr): Don't declare.
3813         * parse.c (lexptr, prev_lexptr): Remove globals.
3814         (parse_exp_in_context): Update.
3815         * p-exp.y (yylex, yyerror): Update.
3816         * m2-exp.y (parse_number, yylex, yyerror): Update.
3817         * go-exp.y (lex_one_token, yyerror): Update.
3818         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3819         * d-exp.y (lex_one_token, yyerror): Update.
3820         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3821         (lex_one_token, yyerror): Update.
3822         * ada-lex.l (YY_INPUT): Update.
3823         (rewind_to_char): Update.
3824         * ada-exp.y (yyerror): Update.
3825
3826 2019-04-04  Tom Tromey  <tom@tromey.com>
3827
3828         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3829         * parser-defs.h (struct parser_state) <parser_state>: Add new
3830         parameter.
3831         <comma_terminates>: New member.
3832         (comma_terminates): Don't declare global.
3833         * parse.c (comma_terminates): Remove global.
3834         (parse_exp_in_context): Update.
3835         * p-exp.y (yylex): Update.
3836         * m2-exp.y (yylex): Update.
3837         * go-exp.y (lex_one_token): Update.
3838         * f-exp.y (yylex): Update.
3839         * d-exp.y (lex_one_token): Update.
3840         * c-exp.y (lex_one_token): Update.
3841         * ada-lex.l: Update.
3842
3843 2019-04-04  Tom Tromey  <tom@tromey.com>
3844
3845         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3846         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3847         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3848         * parser-defs.h (paren_depth): Don't declare.
3849         * parse.c (paren_depth): Remove global.
3850         (parse_exp_in_context): Update.
3851         * p-exp.y (paren_depth): New global.
3852         (pascal_parse): Initialize it.
3853         * m2-exp.y (paren_depth): New global.
3854         (m2_parse): Initialize it.
3855         * go-exp.y (paren_depth): New global.
3856         (go_parse): Initialize it.
3857         * f-exp.y (paren_depth): New global.
3858         (f_parse): Initialize it.
3859         * d-exp.y (paren_depth): New global.
3860         (d_parse): Initialize it.
3861         * c-exp.y (paren_depth): New global.
3862         (c_parse): Initialize it.
3863         * ada-lex.l (paren_depth): New global.
3864         (lexer_init): Initialize it.
3865
3866 2019-04-04  Tom Tromey  <tom@tromey.com>
3867
3868         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3869         (rust_parser::convert_ast_to_type)
3870         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3871         * parser-defs.h (struct parser_state) <parser_state>: Add
3872         parameters.  Initialize new members.
3873         <expression_context_block, expression_context_pc>: New members.
3874         * parse.c (expression_context_block, expression_context_pc):
3875         Remove globals.
3876         (parse_exp_in_context): Update.
3877         * p-exp.y: Update all rules.
3878         (yylex): Update.
3879         * m2-exp.y: Update all rules.
3880         (yylex): Update.
3881         * go-exp.y (yylex): Update.
3882         * f-exp.y (yylex): Update.
3883         * d-exp.y: Update all rules.
3884         (yylex): Update.
3885         * c-exp.y: Update all rules.
3886         (lex_one_token, classify_name, yylex, c_parse): Update.
3887         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3888
3889 2019-04-04  Tom Tromey  <tom@tromey.com>
3890
3891         * gdbarch.h, gdbarch.c: Rebuild.
3892         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3893         * stap-probe.h:
3894         (struct stap_parse_info): Replace "parser_state" with
3895         "expr_builder".
3896         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3897         (parser_state): New class.
3898         * parse.c (expr_builder): Rename.
3899         (expr_builder::release): Rename.
3900         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3901         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3902         (write_exp_elt_longcst, write_exp_elt_floatcst)
3903         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3904         (write_exp_string_vector, write_exp_bitstring)
3905         (write_exp_msymbol, mark_struct_expression)
3906         (write_dollar_variable)
3907         (insert_type_address_space, increase_expout_size): Replace
3908         "parser_state" with "expr_builder".
3909         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3910         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3911         "parser_state" with "expr_builder".
3912
3913 2019-04-04  Tom Tromey  <tom@tromey.com>
3914
3915         * rust-exp.y: Replace "parse_language" with method call.
3916         * p-exp.y:
3917         (yylex): Replace "parse_language" with method call.
3918         * m2-exp.y:
3919         (yylex): Replace "parse_language" with method call.
3920         * go-exp.y (classify_name): Replace "parse_language" with method
3921         call.
3922         * f-exp.y (yylex): Replace "parse_language" with method call.
3923         * d-exp.y (lex_one_token): Replace "parse_language" with method
3924         call.
3925         * c-exp.y:
3926         (lex_one_token, classify_name, yylex): Replace "parse_language"
3927         with method call.
3928         * ada-exp.y (find_primitive_type, type_char)
3929         (type_system_address): Replace "parse_language" with method call.
3930
3931 2019-04-04  Tom Tromey  <tom@tromey.com>
3932
3933         * rust-exp.y: Replace "parse_gdbarch" with method call.
3934         * parse.c (write_dollar_variable, insert_type_address_space):
3935         Replace "parse_gdbarch" with method call.
3936         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3937         call.
3938         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3939         call.
3940         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3941         "parse_gdbarch" with method call.
3942         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3943         with method call.
3944         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3945         "parse_gdbarch" with method call.
3946         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3947         "parse_gdbarch" with method call.
3948         * c-exp.y (parse_type, parse_number, classify_name): Replace
3949         "parse_gdbarch" with method call.
3950         * ada-lex.l: Replace "parse_gdbarch" with method call.
3951         * ada-exp.y (parse_type, find_primitive_type, type_char)
3952         (type_system_address): Replace "parse_gdbarch" with method call.
3953
3954 2019-04-04  Tom Tromey  <tom@tromey.com>
3955
3956         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3957         * stap-probe.c (stap_parse_argument): Update.
3958         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3959         initial_size parameter.
3960         * rust-exp.y (rust_lex_tests): Update.
3961         * parse.c (parser_state): Update.
3962         (parse_exp_in_context): Update.
3963         * parser-defs.h (struct parser_state) <parser_state>: Remove
3964         "initial_size" parameter.
3965
3966 2019-04-04  Tom Tromey  <tom@tromey.com>
3967
3968         * parser-defs.h (increase_expout_size): Don't declare.
3969         * parse.c (increase_expout_size): Now static.
3970
3971 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3972
3973         * gnu-nat.c (gnu_nat_target::wait): Fix
3974         target_waitstatus_to_string call.
3975
3976 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3977
3978         * eval.c (evaluate_subexp_standard): Handle internal functions
3979         during Fortran function call handling.
3980
3981 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3982
3983         * NEWS: Mention new internal functions.
3984         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3985         (read_base_type): Use dwarf2_init_complex_target_type.
3986         * value.c (creal_internal_fn): New function.
3987         (cimag_internal_fn): New function.
3988         (_initialize_values): Register new internal functions.
3989
3990 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3991
3992         * infrun.c (stop_all_threads): If debug_infrun, always
3993         trace the wait status after wait_one, using
3994         target_waitstatus_to_string and target_pid_to_str.
3995         (handle_inferior_event): Replace various trace of
3996         wait status kind by a single trace.
3997         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3998         wait status kind image by target_waitstatus_to_string.
3999         * target/waitstatus.c (target_waitstatus_to_string): Fix
4000         obsolete comment.
4001
4002 2019-04-01  Tom Tromey  <tromey@adacore.com>
4003
4004         PR symtab/23331:
4005         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4006
4007 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4008             Pedro Alves  <palves@redhat.com>
4009
4010         * top.c (quit_force): Call 'finalize_values'.
4011         * value.c (finalize_values): New function.
4012         * value.h (finalize_values): Declare.
4013
4014 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4015
4016         * NEWS: Announce $_gdb_major and $_gdb_minor.
4017
4018         * top.c (init_gdb_version_vars): New function.
4019         (gdb_init): Call init_gdb_version_vars.
4020
4021 2019-03-29  Tom Tromey  <tromey@adacore.com>
4022
4023         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4024         help text.  Remove dead code.
4025
4026 2019-03-29  Keith Seitz  <keiths@redhat.com>
4027
4028         From Siddhesh Poyarekar:
4029         * f-lang.h (f77_get_upperbound): Return LONGEST.
4030         (f77_get_lowerbound): Likewise.
4031         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4032         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4033         print them.
4034         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4035         plongest to format print it.
4036         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4037         (f77_get_upperbound): Likewise.
4038         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4039         LOWER_BOUND to LONGEST.
4040         (f77_create_arrayprint_offset_tbl): Likewise.
4041
4042 2019-03-29  Keith Seitz  <keiths@redhat.com>
4043
4044         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4045         %s/pulongest for TYPE_LENGTH instead of %d in format
4046         strings.
4047         * ada-typerint.c (ada_print_type): Likewise.
4048         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4049         * compile/compile-c-support.c (generate_register_struct): Likewise.
4050         * gdbtypes.c (recursive_dump_type): Likewise.
4051         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4052         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4053         instead of %d in format strings.
4054         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4055         to std::min to ULONGEST.
4056         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4057         instead of %d in format strings.
4058         * tracepoint.c (info_scope_command): Likewise.
4059         * typeprint.c (print_offset_data::update)
4060         (print_offset_data::finish): Likewise.
4061         * xtensa-tdep.c (xtensa_store_return_value)
4062         (xtensa_push_dummy_call): Likewise.
4063
4064 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4065
4066         * windows-nat.c (display_selector): Fixed format specifications
4067         for 64-bit Cygwin.
4068
4069 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4070
4071         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4072
4073 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4074
4075         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4076         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4077         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4078         (nios2_linux_init_abi): Install it.
4079
4080 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4081
4082         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4083
4084 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4085
4086         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4087
4088 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4089             Tom Tromey  <tromey@adacore.com>
4090
4091         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4092
4093 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4094
4095         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4096         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4097         method to compute the bounds of range types. Also print "[evaluated]"
4098         if the bounds' values come from a dynamic evaluation.
4099
4100 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4101
4102         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4103         whitespace when pretty printing is on.
4104
4105 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4106
4107         * ppc-linux-nat.c: Add include.
4108
4109 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4110
4111         * NEWS: Mention AArch64 Pointer Authentication.
4112
4113 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4114
4115         * arm-linux-nat.c: Add include.
4116
4117 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4118
4119         * source-cache.c (source_cache::get_source_lines): Re-read
4120         fullname after calling open_source_file.
4121
4122 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4123
4124         * NEWS: Mention TLS support for FreeBSD.
4125
4126 2019-03-25  Tom Tromey  <tromey@adacore.com>
4127
4128         * minsyms.c (BUNCH_SIZE): Update comment.
4129         (~minimal_symbol_reader): Remove old comment.
4130         (compact_minimal_symbols): Update comment.
4131         (minimal_symbol_reader::install): Remove old comment.  Update
4132         other comments.
4133
4134 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4135
4136         * s390-linux-nat.c: Add include.
4137
4138 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4139
4140         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4141         Call linux_get_hwcap.
4142         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4143         Likewise.
4144         (aarch64_linux_get_hwcap): Remove function.
4145         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4146         declaration.
4147         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4148         linux_get_hwcap.
4149         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4150         * linux-tdep.c (linux_get_hwcap): Add function.
4151         (linux_get_hwcap2): Likewise.
4152         * linux-tdep.h (linux_get_hwcap): Add declaration.
4153         (linux_get_hwcap2): Likewise.
4154         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4155         (ppc_linux_get_hwcap2): Likewise.
4156         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4157         linux_get_hwcap.
4158         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4159         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4160         (ppc_linux_nat_target::read_description): Likewise.
4161         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4162         * s390-linux-nat.c: Likewise.
4163         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4164
4165 2019-03-24  Tom Tromey  <tom@tromey.com>
4166
4167         * ada-lang.c (standard_lookup): Simplify initialization.
4168         (ada_lookup_symbol_nonlocal): Simplify return.
4169         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4170         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4171         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4172         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4173         initialization.
4174         * solib.c (solib_global_lookup): Simplify.
4175         * symtab.c (null_block_symbol): Remove.
4176         (symbol_cache_lookup): Simplify returns.
4177         (lookup_language_this): Simplify returns.
4178         (lookup_symbol_aux): Simplify return.
4179         (lookup_local_symbol): Simplify returns.
4180         (lookup_global_symbol_from_objfile): Simplify return.
4181         (lookup_symbol_in_objfile_symtabs)
4182         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4183         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4184         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4185         * cp-namespace.c (cp_lookup_bare_symbol)
4186         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4187         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4188         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4189         (cp_lookup_symbol_via_imports): Simplify initialization.
4190         (find_symbol_in_baseclass): Likewise.
4191         * symtab.h (null_block_symbol): Remove.
4192         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4193         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4194         (d_lookup_symbol_module): Likewise.
4195         (find_symbol_in_baseclass): Simplify initialization.
4196
4197 2019-03-24  Tom Tromey  <tom@tromey.com>
4198
4199         * expression.h: Don't include symtab.h.
4200         (struct block): Forward declare.
4201
4202 2019-03-24  Tom Tromey  <tom@tromey.com>
4203
4204         * c-exp.y (typebase): Remove casts.
4205         * gdbtypes.c (lookup_unsigned_typename, )
4206         (lookup_signed_typename): Remove cast.
4207         * eval.c (parse_to_comma_and_eval): Remove cast.
4208         * parse.c (write_dollar_variable): Remove cast.
4209         * block.h (struct block) <superblock>: Now const.
4210         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4211         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4212         (map_block): Make "block" const.
4213         * symfile.h (struct quick_symbol_functions)
4214         <map_matching_symbols>: Constify block argument to "callback".
4215         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4216         const.
4217         (find_pc_sect_compunit_symtab): Make "b" const.
4218         (find_symbol_at_address): Likewise.
4219         (search_symbols): Likewise.
4220         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4221         (dw2_debug_names_lookup_symbol): Likewise.
4222         (dw2_map_matching_symbols): Update.
4223         * p-valprint.c (pascal_val_print): Remove "block".
4224         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4225         (aux_add_nonlocal_symbols): Make "block" const.
4226         (resolve_subexp): Remove cast.
4227         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4228         const.
4229         (iterate_over_file_blocks): Likewise.
4230         * f-exp.y (%union) <bval>: Remove.
4231         * coffread.c (patch_opaque_types): Make "b" const.
4232         * spu-tdep.c (spu_catch_start): Make "block" const.
4233         * c-valprint.c (print_unpacked_pointer): Remove "block".
4234         * symmisc.c (dump_symtab_1): Make "b" const.
4235         (block_depth): Make "block" const.
4236         * d-exp.y (%union) <bval>: Remove.
4237         * cp-support.h (cp_lookup_rtti_type): Update.
4238         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4239         * psymtab.c (psym_lookup_symbol): Make "block" const.
4240         (maintenance_check_psymtabs): Make "b" const.
4241         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4242         (enumerate_locals, enumerate_args): Update.
4243         * python/py-symtab.c (stpy_global_block): Make "block" const.
4244         (stpy_static_block): Likewise.
4245         * inline-frame.c (block_starting_point_at): Make "new_block"
4246         const.
4247         * block.c (find_block_in_blockvector): Make return type const.
4248         (blockvector_for_pc_sect): Make "b" const.
4249         (find_block_in_blockvector): Make "b" const.
4250
4251 2019-03-23  Tom Tromey  <tom@tromey.com>
4252
4253         * varobj.c (varobj_create): Update.
4254         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4255         * printcmd.c (display_command, do_one_display): Don't reset
4256         innermost_block.
4257         * parser-defs.h (enum innermost_block_tracker_type): Move to
4258         expression.h.
4259         (innermost_block): Update comment.
4260         * parse.c (parse_exp_1): Add tracker_types parameter.
4261         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4262         tracker_types parameter.  Reset innermost_block.
4263         (parse_exp_in_context): Remove.
4264         (parse_expression_for_completion): Update.
4265         * objfiles.c (~objfile): Don't reset expression_context_block or
4266         innermost_block.
4267         * expression.h (enum innermost_block_tracker_type): Move from
4268         parser-defs.h.
4269         (parse_exp_1): Add tracker_types parameter.
4270         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4271         reset innermost_block.
4272
4273 2019-03-23  Tom Tromey  <tom@tromey.com>
4274
4275         * objfiles.h: Include bcache.h.
4276
4277 2019-03-23  Tom Tromey  <tom@tromey.com>
4278
4279         * linespec.c (get_current_search_block): Use
4280         scoped_restore_current_language.
4281         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4282
4283 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4284             Jiong Wang  <jiong.wang@arm.com>
4285
4286         * aarch64-linux-tdep.c
4287         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4288         section.
4289         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4290
4291 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4292             Jiong Wang  <jiong.wang@arm.com>
4293
4294         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4295         instructions.
4296         (aarch64_analyze_prologue_test): Add PACIASP test.
4297         (aarch64_prologue_prev_register): Unmask PC value.
4298
4299 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4300             Jiong Wang  <jiong.wang@arm.com>
4301
4302         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4303         (aarch64_dwarf2_prev_register): Unmask PC value.
4304         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4305         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4306         DW_CFA_AARCH64_negate_ra_state.
4307         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4308
4309 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4310             Jiong Wang  <jiong.wang@arm.com>
4311
4312         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4313         registers.
4314         (aarch64_pseudo_register_name): Likewise.
4315         (aarch64_pseudo_register_type): Likewise.
4316         (aarch64_pseudo_register_reggroup_p): Likewise.
4317         (aarch64_gdbarch_init): Add pauth registers.
4318         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4319         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4320         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4321         (struct gdbarch_tdep): Add regnum for ra_state.
4322
4323 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4324             Jiong Wang  <jiong.wang@arm.com>
4325
4326         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4327
4328 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4329             Jiong Wang  <jiong.wang@arm.com>
4330
4331         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4332         function.
4333         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4334         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4335         (aarch64_gdbarch_init): Add puth registers.
4336         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4337         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4338         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4339
4340 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4341             Jiong Wang  <jiong.wang@arm.com>
4342
4343         * aarch64-linux-nat.c
4344         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4345         * aarch64-linux-tdep.c
4346         (aarch64_linux_core_read_description): Likewise.
4347         (aarch64_linux_get_hwcap): New function.
4348         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4349         (aarch64_linux_get_hwcap): New declaration.
4350
4351 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4352             Jiong Wang  <jiong.wang@arm.com>
4353
4354         * aarch64-linux-nat.c
4355         (aarch64_linux_nat_target::read_description): Add pauth param.
4356         * aarch64-linux-tdep.c
4357         (aarch64_linux_core_read_description): Likewise.
4358         * aarch64-tdep.c (struct target_desc): Add in pauth.
4359         (aarch64_read_description): Add pauth param.
4360         (aarch64_gdbarch_init): Likewise.
4361         * aarch64-tdep.h (aarch64_read_description): Likewise.
4362         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4363         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4364         * features/Makefile: Add new files.
4365         * features/aarch64-pauth.c: New file.
4366         * features/aarch64-pauth.xml: New file.
4367
4368 2019-03-20  Tom Tromey  <tromey@adacore.com>
4369
4370         * infrun.c (handle_inferior_event): Rename from
4371         handle_inferior_event_1.  Create a scoped_value_mark.
4372         (handle_inferior_event): Remove.
4373
4374 2019-03-19  Tom Tromey  <tromey@adacore.com>
4375
4376         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4377         * infrun.h (print_stop_event): Add "displays" parameter.
4378         * infrun.c (print_stop_event): Add "displays" parameter.
4379
4380 2019-03-19  Pedro Alves  <palves@redhat.com>
4381
4382         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4383         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4384         to -1.  Fix TABs vs spaces.
4385         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4386         * tui/tui-out.h (tui_ui_out) Add intro comments.
4387         <m_line, m_start_of_line>: In-class initialize, and add describing
4388         comment.
4389
4390 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4391
4392         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4393         variable names.
4394         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4395
4396 2019-03-18  Pedro Alves  <palves@redhat.com>
4397             Eli Zaretskii <eliz@gnu.org>
4398
4399         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4400         m_line and m_start_of_line.
4401
4402 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4403
4404         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4405         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4406         it returns a newline.  This fixes a regression in TU mode, whereby
4407         the next line is output on the same screen line as the user input.
4408
4409 2019-03-18  Tom Tromey  <tromey@adacore.com>
4410
4411         * minsyms.c (minimal_symbol_reader::install): Remove call to
4412         obstack_blank.
4413
4414 2019-03-18  Pedro Alves  <palves@redhat.com>
4415
4416         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4417         New globals.
4418         (apply_style): New, factored out from ...
4419         (apply_ansi_escape): ... this.  Handle reverse video mode.
4420         (tui_set_reverse_mode): New function.
4421         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4422         * tui/tui-winsource.c (tui_show_source_line): Use
4423         tui_set_reverse_mode instead of setting A_STANDOUT.
4424         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4425         New setter methods.
4426
4427 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4428
4429         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4430         Handle tabs.
4431
4432 2019-03-18  Tom Tromey  <tromey@adacore.com>
4433
4434         * ada-lang.c (empty_array): Add "high" parameter.
4435         (ada_evaluate_subexp): Update.
4436
4437 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4438
4439         * unittests/string_view-selftests.c: Define
4440         _initialize_string_view_selftests unconditionally.
4441
4442 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4443
4444         PR gdb/24350
4445         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4446
4447 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4448
4449         PR gdb/24351
4450         * windows-nat.c (display_selector): Fix format specifiers.
4451
4452 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4453
4454         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4455         tui_refill_source_window instead of tui_refresh_win, to update the
4456         current execution line.  This fixes redisplay of the current line
4457         when stepping through the code with "next" or "step".
4458
4459 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4460
4461         * source-cache.c (source_cache::get_source_lines): Call
4462         find_source_lines to initialize s->nlines.  This fixes vertical
4463         scrolling of TUI source window when the DOWN arrow is pressed.
4464
4465 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4466
4467         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4468         linux-thread-db.c (_initialize_thread_db): Likewise.
4469
4470 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4471
4472         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4473         wclrtoeol in tui_show_source_line".  This reverts changes made in
4474         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4475
4476 2019-03-15  Tom Tromey  <tom@tromey.com>
4477
4478         * symtab.h (struct minimal_symbol): Derive from
4479         general_symbol_info.
4480         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4481         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4482         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4483         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4484         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4485         (MSYMBOL_SEARCH_NAME): Update.
4486         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4487         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4488         * minsyms.c (minimal_symbol_reader::record_full): Update.
4489
4490 2019-03-15  Tom Tromey  <tom@tromey.com>
4491
4492         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4493
4494 2019-03-15  Tom Tromey  <tom@tromey.com>
4495
4496         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4497         unique_xmalloc_ptr.
4498         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4499         Update.
4500         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4501         (build_minimal_symbol_hash_tables)
4502         (minimal_symbol_reader::install): Update.
4503
4504 2019-03-15  Tom Tromey  <tom@tromey.com>
4505
4506         * symtab.c (create_demangled_names_hash): Update.
4507         (symbol_set_names): Update.
4508         * objfiles.h (struct objfile_per_bfd_storage)
4509         <demangled_names_hash>: Now an htab_up.
4510         * objfiles.c (objfile_per_bfd_storage): Simplify.
4511
4512 2019-03-15  Tom Tromey  <tom@tromey.com>
4513
4514         * objfiles.h (struct objfile_per_bfd_storage): Declare
4515         destructor.
4516         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4517         New.
4518         (get_objfile_bfd_data): Use new.  Don't initialize
4519         language_of_main.
4520         (free_objfile_per_bfd_storage): Remove.
4521         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4522
4523 2019-03-15  Tom Tromey  <tom@tromey.com>
4524
4525         * symfile.c (reread_symbols): Update.
4526         * objfiles.c (objfile::objfile): Update.
4527         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4528         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4529         comment.
4530         (minimal_symbol_reader::install): Update.
4531         (terminate_minimal_symbol_table): Remove.
4532         * jit.c (jit_object_close_impl): Update.
4533
4534 2019-03-15  Tom Tromey  <tom@tromey.com>
4535
4536         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4537         initializations.
4538
4539 2019-03-15  Tom Tromey  <tom@tromey.com>
4540
4541         * objfiles.h (struct objfile_per_bfd_storage)
4542         <demangled_hash_languages>: Now a bitset.
4543         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4544         (lookup_minimal_symbol): Update.
4545
4546 2019-03-15  Tom Tromey  <tom@tromey.com>
4547
4548         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4549         Don't return the symbol.
4550         * coffread.c (record_minimal_symbol): Use record_full.
4551
4552 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4553
4554         The MS-Windows port of ncurses fails to switch to a color pair if
4555         one or both of the colors are the implicit default colors.  This
4556         change records the default colors when TUI is initialized, and
4557         then specifies them explicitly when a color pair uses the default
4558         colors.  This allows color styling in TUI mode on MS-Windows.
4559
4560         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4561         ncurses_norm_attr.
4562         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4563         colors in ncurses_norm_attr.
4564         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4565         "none", replace it with the default color recorded in
4566         ncurses_norm_attr.
4567
4568 2019-03-14  Tom Tromey  <tromey@adacore.com>
4569
4570         * source-cache.h (class source_cache) <get_source_lines>: Return
4571         std::string.
4572         * source-cache.c (source_cache::extract_lines): Handle case where
4573         first_pos==npos.  Return std::string.
4574         (source_cache::get_source_lines): Update.
4575
4576 2019-03-14  Tom Tromey  <tromey@adacore.com>
4577
4578         * NEWS: Add item for "style sources" commands.
4579         * source-cache.c (source_cache::get_source_lines): Check
4580         source_styling.
4581         * cli/cli-style.c (source_styling): New global.
4582         (_initialize_cli_style): Add "style sources" commands.
4583         (show_style_sources): New function.
4584         * cli/cli-style.h (source_styling): Declare.
4585
4586 2019-03-14  Pedro Alves  <palves@redhat.com>
4587             Tom Tromey  <tromey@adacore.com>
4588
4589         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4590         * tui/tui-winsource.c (tui_refill_source_window): New function,
4591         from...
4592         (tui_horizontal_source_scroll): ... here.  Move some logic.
4593         * cli/cli-style.c (set_style_enabled): Notify new observable.
4594         * tui/tui-hooks.c (tui_redisplay_source): New function.
4595         (tui_attach_detach_observers): Attach or detach
4596         tui_redisplay_source.
4597         * observable.h (source_styling_changed): New observable.
4598         * observable.c: Define source_styling_changed observable.
4599
4600 2019-03-13  Tom Tromey  <tromey@adacore.com>
4601
4602         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4603         (i386_gnu_nat_target::store_registers): Update.
4604         * target-debug.h (target_debug_print_std_string): New macro.
4605         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4606         * windows-tdep.c (display_one_tib): Update.
4607         * tui/tui-stack.c (tui_make_status_line): Update.
4608         * top.c (print_inferior_quit_action): Update.
4609         * thread.c (thr_try_catch_cmd): Update.
4610         (add_thread_with_info): Update.
4611         (thread_target_id_str): Update.
4612         (thr_try_catch_cmd): Update.
4613         (thread_command): Update.
4614         (thread_find_command): Update.
4615         * record-btrace.c (record_btrace_target::info_record)
4616         (record_btrace_resume_thread, record_btrace_target::resume)
4617         (record_btrace_cancel_resume, record_btrace_step_thread)
4618         (record_btrace_target::wait, record_btrace_target::wait)
4619         (record_btrace_target::wait, record_btrace_target::stop): Update.
4620         * progspace.c (print_program_space): Update.
4621         * process-stratum-target.c
4622         (process_stratum_target::thread_address_space): Update.
4623         * linux-fork.c (linux_fork_mourn_inferior)
4624         (detach_checkpoint_command, info_checkpoints_command)
4625         (linux_fork_context): Update.
4626         (linux_fork_detach): Update.
4627         (class scoped_switch_fork_info): Update.
4628         (delete_checkpoint_command): Update.
4629         * infrun.c (follow_fork_inferior): Update.
4630         (follow_fork_inferior): Update.
4631         (proceed_after_vfork_done): Update.
4632         (handle_vfork_child_exec_or_exit): Update.
4633         (follow_exec): Update.
4634         (displaced_step_prepare_throw): Update.
4635         (displaced_step_restore): Update.
4636         (start_step_over): Update.
4637         (resume_1): Update.
4638         (clear_proceed_status_thread): Update.
4639         (proceed): Update.
4640         (print_target_wait_results): Update.
4641         (do_target_wait): Update.
4642         (context_switch): Update.
4643         (stop_all_threads): Update.
4644         (restart_threads): Update.
4645         (finish_step_over): Update.
4646         (handle_signal_stop): Update.
4647         (switch_back_to_stepped_thread): Update.
4648         (keep_going_pass_signal): Update.
4649         (print_exited_reason): Update.
4650         (normal_stop): Update.
4651         * inferior.c (inferior_pid_to_str): Change return type.
4652         (print_selected_inferior): Update.
4653         (add_inferior): Update.
4654         (detach_inferior): Update.
4655         * dummy-frame.c (fprint_dummy_frames): Update.
4656         * dcache.c (dcache_info_1): Update.
4657         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4658         (btrace_fetch, btrace_clear): Update.
4659         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4660         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4661         type.
4662         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4663         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4664         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4665         * gdbarch.c, gdbarch.h: Rebuild.
4666         * gdbarch.sh (core_pid_to_str): Change return type.
4667         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4668         return type.
4669         (windows_nat_target::pid_to_str): Change return type.
4670         (windows_delete_thread): Update.
4671         (windows_nat_target::attach): Update.
4672         (windows_nat_target::files_info): Update.
4673         * target-delegates.c: Rebuild.
4674         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4675         return type.
4676         (sol_thread_target::pid_to_str): Change return type.
4677         * remote.c (class remote_target) <pid_to_str>: Change return
4678         type.
4679         (remote_target::pid_to_str): Change return type.
4680         (extended_remote_target::attach, remote_target::remote_stop_ns)
4681         (remote_target::remote_notif_remove_queued_reply)
4682         (remote_target::push_stop_reply, remote_target::disable_btrace):
4683         Update.
4684         (extended_remote_target::attach): Update.
4685         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4686         type.
4687         (gdbsim_target::pid_to_str): Change return type.
4688         * ravenscar-thread.c (struct ravenscar_thread_target)
4689         <pid_to_str>: Change return type.
4690         (ravenscar_thread_target::pid_to_str): Change return type.
4691         * procfs.c (class procfs_target) <pid_to_str>: Change return
4692         type.
4693         (procfs_target::pid_to_str): Change return type.
4694         (procfs_target::attach): Update.
4695         (procfs_target::detach): Update.
4696         (procfs_target::fetch_registers): Update.
4697         (procfs_target::store_registers): Update.
4698         (procfs_target::wait): Update.
4699         (procfs_target::files_info): Update.
4700         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4701         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4702         return type.
4703         (nto_procfs_target::pid_to_str): Change return type.
4704         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4705         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4706         return type.
4707         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4708         (exit_lwp): Update.
4709         (attach_proc_task_lwp_callback, get_detach_signal)
4710         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4711         (linux_nat_target::resume, wait_lwp, stop_callback)
4712         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4713         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4714         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4715         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4716         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4717         type.
4718         (inf_ptrace_target::attach): Update.
4719         (inf_ptrace_target::files_info): Update.
4720         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4721         type.
4722         (go32_nat_target::pid_to_str): Change return type.
4723         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4724         (gnu_nat_target::wait): Update.
4725         (gnu_nat_target::wait): Update.
4726         (gnu_nat_target::resume): Update.
4727         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4728         (fbsd_nat_target::wait): Update.
4729         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4730         type.
4731         (darwin_nat_target::attach): Update.
4732         * corelow.c (class core_target) <pid_to_str>: Change return type.
4733         (core_target::pid_to_str): Change return type.
4734         * target.c (normal_pid_to_str): Change return type.
4735         (default_pid_to_str): Likewise.
4736         (target_pid_to_str): Change return type.
4737         (target_translate_tls_address): Update.
4738         (target_announce_detach): Update.
4739         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4740         return type.
4741         (bsd_uthread_target::pid_to_str): Change return type.
4742         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4743         type.
4744         (bsd_kvm_target::pid_to_str): Change return type.
4745         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4746         return type.
4747         (aix_thread_target::pid_to_str): Change return type.
4748         * target.h (struct target_ops) <pid_to_str>: Change return type.
4749         (target_pid_to_str, normal_pid_to_str): Likewise.
4750         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4751         type.
4752         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4753         type.
4754         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4755         return type.
4756         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4757         type.
4758         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4759         type.
4760         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4761         return type.
4762
4763 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4764
4765         * NEWS: Mention that the new default MI version is 3.  Mention
4766         changes to the output of commands and events that deal with
4767         multi-location breakpoints.
4768         * breakpoint.c: Include "mi/mi-out.h".
4769         (print_one_breakpoint): Change output syntax if using MI version
4770         >= 3.
4771         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4772         New.
4773         (mi_multi_location_breakpoint_output_fixed): New.
4774         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4775         (mi_cmd_fix_multi_location_breakpoint_output): New.
4776         (mi_multi_location_breakpoint_output_fixed): New.
4777         * mi/mi-cmds.c (mi_cmds): Register command
4778         -fix-multi-location-breakpoint-output.
4779         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4780         interpreter "mi".
4781
4782 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4783
4784         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4785         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4786         instantiate mi_ui_out based on interpreter name.
4787         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4788         * mi/mi-main.c (mi_load_progress): Likewise.
4789
4790 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4791
4792         * NEWS: Combine separate "New targets" sections for 8.3.
4793
4794 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4795
4796         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4797         (ppcfbsd_init_abi): Install gdbarch
4798         "fetch_tls_load_module_address" and "get_thread_local_address"
4799         methods.
4800
4801 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4802
4803         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4804         (riscv_fbsd_init_abi): Install gdbarch
4805         "fetch_tls_load_module_address" and "get_thread_local_address"
4806         methods.
4807
4808 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4809
4810         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4811         (i386fbsd_init_abi): Install gdbarch
4812         "fetch_tls_load_module_address" and "get_thread_local_address"
4813         methods.
4814
4815 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4816
4817         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4818         (amd64fbsd_init_abi): Install gdbarch
4819         "fetch_tls_load_module_address" and "get_thread_local_address"
4820         methods.
4821
4822 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4823
4824         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4825         (struct fbsd_pspace_data): New type.
4826         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4827         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4828         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4829         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4830         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4831
4832 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4833
4834         * gdbtypes.c (lookup_struct_elt): New function.
4835         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4836         * gdbtypes.h (struct struct_elt): New type.
4837         (lookup_struct_elt): New prototype.
4838
4839 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4840
4841         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4842         remove disabled code block.
4843
4844 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4845
4846         * gdbarch.sh (get_thread_local_address): New method.
4847         * gdbarch.h, gdbarch.c: Regenerate.
4848         * target.c (target_translate_tls_address): Use
4849         gdbarch_get_thread_local_address if present instead of
4850         target::get_thread_local_address.
4851
4852 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4853
4854         * target.h (target::get_thread_local_address): Update comment.
4855
4856 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4857
4858         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4859         objfile->separate_debug_objfile_backlink if not NULL.
4860
4861 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4862
4863         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4864         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4865         (amd64bsd_store_inferior_registers): Likewise.
4866         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4867         Enable segment base registers.
4868         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4869         PT_GETFSBASE and PT_GETGSBASE.
4870         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4871         PT_SETGSBASE.
4872         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4873         segment base registers.
4874         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4875
4876 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4877
4878         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4879         Update calls to i386_target_description to add 'segments'
4880         parameter.
4881         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4882         add segment base registers.
4883         * arch/i386.c (i386_create_target_description): Add 'segments'
4884         parameter to enable segment base registers.
4885         * arch/i386.h (i386_create_target_description): Likewise.
4886         * features/i386/32bit-segments.xml: New file.
4887         * features/i386/32bit-segments.c: Generate.
4888         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4889         call to i386_target_description to add 'segments' parameter.
4890         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4891         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4892         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4893         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4894         if feature is present.
4895         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4896         Add 'segments' parameter to call to i386_target_description.
4897         (i386_target_description): Add 'segments' parameter to enable
4898         segment base registers.
4899         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4900         to call to i386_target_description.
4901         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4902         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4903         Define I386_NUM_REGS.
4904         (i386_target_description): Add 'segments' parameter to enable
4905         segment base registers.
4906
4907 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4908
4909         PR/24325
4910         * source-cache.c: #undef open and close, to avoid unresolved
4911         externals during linking.
4912
4913 2019-03-12  Tom Tromey  <tromey@adacore.com>
4914
4915         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4916         const.  Add initializers.
4917         (_initialize_remote): Don't initialize ptid globals.
4918
4919 2019-03-12  Pedro Alves  <palves@redhat.com>
4920
4921         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4922
4923 2019-03-12  Pedro Alves  <palves@redhat.com>
4924
4925         * cp-name-parser.y (main): Remove unused 'len' variable.
4926
4927 2019-03-12  Tom Tromey  <tromey@adacore.com>
4928
4929         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4930         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4931
4932 2019-03-12  Tom Tromey  <tromey@adacore.com>
4933
4934         * linux-nat.c (iterate_over_lwps): Update.
4935         (stop_callback): Remove parameter.
4936         (stop_wait_callback, detach_callback, resume_set_callback)
4937         (select_singlestep_lwp_callback, set_ignore_sigint)
4938         (status_callback, resumed_callback, resume_clear_callback)
4939         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4940         data parameter.
4941         (linux_nat_target::detach, linux_nat_target::resume)
4942         (linux_stop_and_wait_all_lwps, select_event_lwp)
4943         (linux_nat_filter_event, linux_nat_wait_1)
4944         (linux_nat_target::kill, linux_nat_target::stop)
4945         (linux_nat_target::stop): Update.
4946         (linux_nat_resume_callback): Change type.
4947         (resume_stopped_resumed_lwps, count_events_callback)
4948         (select_event_lwp_callback): Likewise.
4949         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4950         * arm-linux-nat.c (struct update_registers_data): Remove.
4951         (update_registers_callback): Change type.
4952         (arm_linux_insert_hw_breakpoint1): Update.
4953         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4954         parameter.
4955         (x86_linux_dr_set_addr): Update.
4956         (x86_linux_dr_set_control): Update.
4957         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4958         (iterate_over_lwps): Use gdb::function_view.
4959         * nat/aarch64-linux-hw-point.c (struct
4960         aarch64_dr_update_callback_param): Remove.
4961         (debug_reg_change_callback): Change type.
4962         (aarch64_notify_debug_reg_change): Update.
4963         * s390-linux-nat.c (s390_refresh_per_info): Update.
4964
4965 2019-03-11  Tom Tromey  <tromey@adacore.com>
4966
4967         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4968         redundant assignment to "this_cu".
4969
4970 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4971
4972         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4973
4974 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4975
4976         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4977         from...
4978         (rank_one_type): ... this.
4979
4980 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4981
4982         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4983         from...
4984         (rank_one_type): ... this.
4985
4986 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4987
4988         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4989         from...
4990         (rank_one_type): ... this.
4991
4992 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4993
4994         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4995         from...
4996         (rank_one_type): ... this.
4997
4998 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4999
5000         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5001         from...
5002         (rank_one_type): ... this.
5003
5004 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5005
5006         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5007         from...
5008         (rank_one_type): ... this.
5009
5010 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5011
5012         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5013         from...
5014         (rank_one_type): ... this.
5015
5016 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5017
5018         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5019         from...
5020         (rank_one_type): ... this.
5021
5022 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5023
5024         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5025         from...
5026         (rank_one_type): ... this.
5027
5028 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5029
5030         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5031         from...
5032         (rank_one_type): ... this.
5033
5034 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5035
5036         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5037         from...
5038         (rank_one_type): ... this.
5039
5040 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5041
5042         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5043         from...
5044         (rank_one_type): ... this.
5045
5046 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5047
5048         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5049         inferior-events' shows the example events.
5050
5051 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5052
5053         Support styling on native MS-Windows console
5054
5055         PR/24315
5056         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5057         on MS-Windows if $TERM is not defined.
5058
5059         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5060
5061         * posix-hdep.c (gdb_console_fputs):
5062         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5063         functions.
5064         * ui-file.h (gdb_console_fputs): Add prototype.
5065
5066         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5067         back to fputs only if the former returns zero.
5068
5069 2019-03-07  Tom Tromey  <tom@tromey.com>
5070
5071         * symmisc.c (print_symbol_bcache_statistics): Update.
5072         (print_objfile_statistics): Update.
5073         * symfile.c (allocate_symtab): Update.
5074         * stabsread.c: Don't include bcache.h.
5075         * psymtab.h (struct psymbol_bcache): Don't declare.
5076         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5077         (psymbol_bcache_init, psymbol_bcache_free)
5078         (psymbol_bcache_get_bcache): Don't declare.
5079         * psymtab.c (struct psymbol_bcache): Remove.
5080         (psymtab_storage::psymtab_storage): Update.
5081         (psymtab_storage::~psymtab_storage): Update.
5082         (psymbol_bcache_init, psymbol_bcache_free)
5083         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5084         (add_psymbol_to_bcache): Update.
5085         (allocate_psymtab): Update.
5086         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5087         macro_cache>: No longer pointers.
5088         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5089         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5090         * macrotab.c (macro_bcache): Update.
5091         * macroexp.c: Don't include bcache.h.
5092         * gdbtypes.c (check_types_worklist): Update.
5093         (types_deeply_equal): Remove TRY/CATCH.  Update.
5094         * elfread.c (elf_symtab_read): Update.
5095         * dwarf2read.c: Don't include bcache.h.
5096         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5097         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5098         (print_bcache_statistics, bcache_memory_used): Don't declare.
5099         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5100         methods.  Rename all data members.
5101         * bcache.c (struct bcache): Move to bcache.h.
5102         (bcache::expand_hash_table): Rename from expand_hash_table.
5103         (bcache): Remove.
5104         (bcache::insert): Rename from bcache_full.
5105         (bcache::compare): Rename from bcache_compare.
5106         (bcache_xmalloc): Remove.
5107         (bcache::~bcache): Rename from bcache_xfree.
5108         (bcache::print_statistics): Rename from print_bcache_statistics.
5109         (bcache::memory_used): Rename from bcache_memory_used.
5110
5111 2019-03-07  Pedro Alves  <palves@redhat.com>
5112
5113         * infrun.c (normal_stop): Also check for
5114         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5115
5116 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5117
5118         * f-lang.c (value_from_host_double): Moved to...
5119         * value.c (value_from_host_double): ...here.
5120         * value.h (value_from_host_double): Declare.
5121         * guile/scm-math.c (vlscm_convert_typed_number): Use
5122         value_from_host_double.
5123         (vlscm_convert_number): Likewise.
5124         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5125         * python/py-value.c (convert_value_from_python): Likewise.
5126
5127 2019-03-06  Tom Tromey  <tom@tromey.com>
5128
5129         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5130
5131 2019-03-06  Tom Tromey  <tom@tromey.com>
5132
5133         * utils.h (free_current_contents): Don't declare.
5134         * utils.c (free_current_contents): Remove.
5135
5136 2019-03-06  Tom Tromey  <tom@tromey.com>
5137
5138         * top.c (quit_force): Update.
5139         * main.c (captured_command_loop): Update.
5140         * common/new-op.c (operator new): Update.
5141         * common/common-exceptions.c (struct catcher)
5142         <save_cleanup_chain>: Remove member.
5143         (exceptions_state_mc_init): Update.
5144         (exception_try_scope_entry): Return nullptr.
5145         (exception_try_scope_exit, exception_rethrow)
5146         (throw_exception_sjlj, throw_exception_cxx): Update.
5147         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5148         (all_cleanups, do_cleanups, discard_cleanups)
5149         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5150         (restore_cleanups, restore_final_cleanups): Don't declare.
5151         (do_final_cleanups): Remove parameter.
5152         * common/cleanups.c (cleanup_chain, make_cleanup)
5153         (make_cleanup_dtor, all_cleanups, do_cleanups)
5154         (discard_my_cleanups, discard_cleanups)
5155         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5156         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5157         (null_cleanup): Remove.
5158         (do_final_cleanups): Remove parameter.
5159
5160 2019-03-06  Tom Tromey  <tom@tromey.com>
5161
5162         * remote.c (remote_target::remote_parse_stop_reply): Use
5163         unique_xmalloc_ptr.
5164
5165 2019-03-06  Tom Tromey  <tom@tromey.com>
5166
5167         * stabsread.c (struct stabs_field_info): Rename from field_info.
5168         <list, fnlist>: Add initializers.
5169         <obstack>: New member.
5170         (read_member_functions, read_struct_fields, read_baseclasses):
5171         Allocate on obstack.  Don't use cleanups.
5172         (read_one_struct_field, read_member_functions, read_struct_fields)
5173         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5174         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5175         (read_struct_type): Update.
5176
5177 2019-03-06  Tom Tromey  <tom@tromey.com>
5178
5179         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5180         * common/filestuff.h (make_cleanup_close): Don't declare.
5181         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5182         Remove.
5183
5184 2019-03-06  Tom Tromey  <tom@tromey.com>
5185
5186         * solib-aix.c: Use make_scope_exit.
5187
5188 2019-03-06  Tom Tromey  <tom@tromey.com>
5189
5190         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5191         Use make_scope_exit.
5192
5193 2019-03-06  Tom Tromey  <tom@tromey.com>
5194
5195         * solib-svr4.c (disable_probes_interface): Remove parameter.
5196         (svr4_handle_solib_event): Use make_scope_exit.
5197
5198 2019-03-06  Tom Tromey  <tom@tromey.com>
5199
5200         * remote.c (struct stop_reply_deleter): Remove.
5201         (stop_reply_up): Update.
5202         (struct stop_reply): Derive from notif_event.  Don't typedef.
5203         <regcache>: Now a std::vector.
5204         (stop_reply_xfree): Remove.
5205         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5206         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5207         (remote_target::discard_pending_stop_replies): Use delete.
5208         (remote_target::remote_parse_stop_reply): Update.
5209         (remote_target::process_stop_reply): Update.
5210         * remote-notif.h (struct notif_event): Add virtual destructor.
5211         Remove "dtr" member.
5212         (struct notif_client) <alloc_event>: Return a unique_ptr.
5213         (notif_event_xfree): Don't declare.
5214         (notif_event_up): New typedef.
5215         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5216         (notif_event_xfree, do_notif_event_xfree): Remove.
5217         (remote_notif_state_xfree): Update.
5218
5219 2019-03-06  Tom Tromey  <tom@tromey.com>
5220
5221         * infrun.c (displaced_step_clear_cleanup): Now a
5222         forward_scope_exit type.
5223         (displaced_step_prepare_throw): Update.
5224         (displaced_step_fixup): Update.
5225
5226 2019-03-06  Tom Tromey  <tom@tromey.com>
5227
5228         * inferior.h (class inferior): Update comment.
5229         * gdbthread.h (class thread_info): Update comment.
5230
5231 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5232             Tom Tromey  <tom@tromey.com>
5233
5234         * stabsread.h (struct stab_section_list): Remove.
5235         (coffstab_build_psymtabs): Update.
5236         * dbxread.c (symbuf_sections): Now a std::vector.
5237         (sect_idx): New global.
5238         (fill_symbuf): Update.
5239         (coffstab_build_psymtabs): Change type of stabsects parameter.
5240         Update.
5241         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5242         std::vector.
5243         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5244         (coff_locate_sections): Update.
5245         (coff_symfile_read): Remove cleanups.  Update.
5246         (init_stringtab): Add storage parameter.
5247         (free_stringtab, free_stringtab_cleanup): Remove.
5248         (init_lineno): Add storage parameter.
5249         (free_linetab, free_linetab_cleanup): Remove.
5250
5251 2019-03-06  Pedro Alves  <palves@redhat.com>
5252
5253         * linux-fork.c (fork_info::clobber_regs): Delete.
5254         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5255         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5256         comment.  Adjust.
5257         (scoped_switch_fork_info::scoped_switch_fork_info)
5258         (checkpoint_command, linux_fork_context): Adjust
5259         fork_save_infrun_state calls.
5260
5261 2019-03-06  Pedro Alves  <palves@redhat.com>
5262
5263         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5264         (inf_has_multiple_threads): Return 'bool' and rewrite using
5265         inferior_info::threads().
5266
5267 2019-03-06  Pedro Alves  <palves@redhat.com>
5268
5269         * linux-fork.c: Include <list>.
5270         (fork_list): Now a std::list instance.
5271         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5272         (forks_exist_p, find_last_fork): Adjust.
5273         (new_fork): Delete.
5274         (one_fork_p): New.
5275         (add_fork): Adjust.
5276         (free_fork): Delete, folded into fork_info::~fork_info().
5277         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5278         Adjust.
5279         (init_fork_list): Delete.
5280         (linux_fork_killall, linux_fork_mourn_inferior)
5281         (linux_fork_detach, info_checkpoints_command): Adjust.
5282         (_initialize_linux_fork): No longer call init_fork_list.
5283
5284 2019-03-06  Pedro Alves  <palves@redhat.com>
5285
5286         * linux-fork.c (new_fork): New, split out of ...
5287         (add_fork): ... this.  Return void.  Move "first fork" special
5288         case from here, to ...
5289         (checkpoint_command): ... here.
5290         * linux-linux.h (add_fork): Return void.
5291
5292 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5293
5294         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5295
5296 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5297             Chris January  <chris.january@arm.com>
5298             David Lecomber  <david.lecomber@arm.com>
5299
5300         * f-exp.y: New token, UNOP_INTRINSIC.
5301         (exp): New pattern using UNOP_INTRINSIC token.
5302         (f77_keywords): Add 'abs' keyword.
5303         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5304         (value_from_host_double): New function.
5305         (evaluate_subexp_f): Support UNOP_ABS.
5306
5307 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5308
5309         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5310         types.
5311
5312 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5313
5314         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5315         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5316         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5317
5318 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5319
5320         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5321
5322 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5323             Chris January  <chris.january@arm.com>
5324
5325         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5326         * f-exp.y: Define 'KIND' token.
5327         (exp): New pattern for KIND expressions.
5328         (ptype): Handle types with a kind extension.
5329         (direct_abs_decl): Extend to spot kind extensions.
5330         (f77_keywords): Add 'kind' to the list.
5331         (push_kind_type): New function.
5332         (convert_to_kind_type): New function.
5333         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5334         * parse.c (operator_length_standard): Likewise.
5335         * parser-defs.h (enum type_pieces): Add tp_kind.
5336         * std-operator.def: Add UNOP_KIND.
5337
5338 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5339
5340         * f-exp.y (f_parse): Set yydebug.
5341
5342 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5343
5344         * f-lang.c (evaluate_subexp_f): New function.
5345         (exp_descriptor_f): New global.
5346         (f_language_defn): Use exp_descriptor_f instead of
5347         exp_descriptor_standard.
5348
5349 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5350
5351         * f-exp.y (struct token): Add comments.
5352         (dot_ops): Remove uppercase versions and the end marker.
5353         (f77_keywords): Likewise.
5354         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5355         entries in the dot_ops array are case insensitive, and use
5356         strncasecmp to compare strings.  Also some whitespace cleanup in
5357         this area.  Similar for the f77_keywords array, except entries in
5358         this list might be case sensitive.
5359
5360 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5361
5362         * f-exp.y (struct f77_boolean_val): Add comments.
5363         (boolean_values): Remove uppercase versions, and end marker.
5364         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5365         and use strncasecmp to achieve case insensitivity.  Additionally,
5366         perform whitespace cleanup around this code.
5367
5368 2019-03-06  Tom Tromey  <tromey@adacore.com>
5369
5370         * remote-sim.c (gdbsim_target_open): Use result of
5371         gdb_argv::release.
5372
5373 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5374         Dirk Schubert  <dirk.schubert@arm.com>
5375         Chris January  <chris.january@arm.com>
5376
5377         * eval.c (evaluate_subexp_standard): Call Fortran argument
5378         wrapping logic.
5379         * f-lang.c (struct value): A value which can be passed into a
5380         Fortran function call.
5381         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5382         where appropriate.
5383         (struct type): Value ready for a Fortran function call.
5384         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5385         is needed.
5386         * f-lang.h (fortran_argument_convert): Declaration.
5387         (fortran_preserve_arg_pointer): Declaration.
5388         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5389
5390 2019-03-05  Tom Tromey  <tromey@adacore.com>
5391
5392         * python/py-prettyprint.c (print_string_repr): Remove #if.
5393         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5394
5395 2019-03-05  Tom Tromey  <tromey@adacore.com>
5396
5397         * target.c (the_dummy_target): Move later.  Change type to
5398         "dummy_target".
5399         (initialize_targets): Don't initialize the_dummy_target.
5400
5401 2019-03-05  Tom Tromey  <tromey@adacore.com>
5402
5403         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5404         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5405
5406 2019-03-05  Tom Tromey  <tromey@adacore.com>
5407
5408         * windows-nat.c (windows_nat_target::attach)
5409         (windows_nat_target::detach): Don't call gdb_flush.
5410         * valprint.c (generic_val_print, val_print, val_print_string):
5411         Don't call gdb_flush.
5412         * utils.c (defaulted_query): Don't call gdb_flush.
5413         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5414         * target.c (target_announce_detach): Don't call gdb_flush.
5415         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5416         * remote.c (extended_remote_target::attach): Don't call
5417         gdb_flush.
5418         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5419         * printcmd.c (do_examine): Don't call gdb_flush.
5420         (info_display_command): Don't call gdb_flush.
5421         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5422         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5423         * memattr.c (info_mem_command): Don't call gdb_flush.
5424         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5425         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5426         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5427         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5428         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5429         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5430         (gnu_nat_target::detach): Don't call gdb_flush.
5431         * f-valprint.c (f_val_print): Don't call gdb_flush.
5432         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5433         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5434         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5435         gdb_flush.
5436         * c-valprint.c (c_val_print): Don't call gdb_flush.
5437         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5438
5439 2019-03-05  Tom Tromey  <tromey@adacore.com>
5440
5441         * varobj.c (update_dynamic_varobj_children): Update.
5442         (install_default_visualizer): Use reset, not release.
5443         * value.c (set_internalvar): Update.
5444         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5445         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5446         ATTRIBUTE_UNUSED_RESULT.
5447
5448 2019-03-05  Tom Tromey  <tromey@adacore.com>
5449
5450         * remote.c (class scoped_remote_fd) <release>: Add
5451         ATTRIBUTE_UNUSED_RESULT.
5452
5453 2019-03-05  Tom Tromey  <tromey@adacore.com>
5454
5455         * macroexp.c (struct macro_buffer) <release>: Add
5456         ATTRIBUTE_UNUSED_RESULT.
5457
5458 2019-03-05  Tom Tromey  <tromey@adacore.com>
5459
5460         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5461         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5462         ATTRIBUTE_UNUSED_RESULT.
5463
5464 2019-03-05  Tom Tromey  <tromey@adacore.com>
5465
5466         * common/scoped_fd.h (class scoped_fd) <release>: Add
5467         ATTRIBUTE_UNUSED_RESULT.
5468
5469 2019-03-05  Tom Tromey  <tromey@adacore.com>
5470
5471         * parser-defs.h (struct parser_state) <release>: Add
5472         ATTRIBUTE_UNUSED_RESULT.
5473
5474 2019-03-05  Tom Tromey  <tromey@adacore.com>
5475
5476         * utils.h (class gdb_argv) <release>: Add
5477         ATTRIBUTE_UNUSED_RESULT.
5478         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5479
5480 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5481
5482         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5483         for-loop range, to avoid compiler warnings.
5484
5485         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5486         avoid compiler warnings about unused variables.
5487
5488         * NEWS: Mention end of support for native debugging on MS-Windows
5489         before XP.
5490
5491         PR gdb/24292
5492         * common/netstuff.c:
5493         * gdbserver/gdbreplay.c
5494         * gdbserver/remote-utils.c:
5495         * ser-tcp.c:
5496         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5497         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5498         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5499         'getaddrinfo' and 'freeaddrinfo' were not available before
5500         Windows XP, and mingw.org's MinGW headers by default define
5501         _WIN32_WINNT to 0x500.
5502
5503 2019-03-01  Gary Benson <gbenson@redhat.com>
5504
5505         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5506
5507 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5508             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5509
5510         PR gdb/8527
5511         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5512         set_sigint_trap, clear_sigint_trap.
5513
5514 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5515
5516         * target.c (target_detach): Clear the regcache and the
5517         frame cache.
5518
5519 2019-02-27  Pedro Alves  <palves@redhat.com>
5520
5521         * utils.c (set_screen_size): When we cap the height/width sizes,
5522         tweak the corresponding command variable to show "unlimited":
5523
5524 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5525             Pedro Alves  <palves@redhat.com>
5526
5527         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5528         before calling rl_set_screen_size.
5529
5530 2019-02-27  Tom Tromey  <tromey@adacore.com>
5531
5532         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5533         define.
5534         * python/py-value.c: Remove Python 2.4 workaround.
5535         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5536         workaround.
5537         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5538         Python 2.4 workaround.
5539         * python/python-internal.h: Remove Python 2.4 comment.
5540         (Py_ssize_t): Don't define.
5541         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5542         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5543         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5544         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5545         * python/python.c (do_start_initialization): Remove Python 2.4
5546         workaround.
5547         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5548         (print_children): Remove Python 2.4 workaround.
5549         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5550         workaround.
5551         (CHARBUFFERPROC_NAME): Remove.
5552         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5553         Python 2.4 workaround.
5554
5555 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5556
5557         * NEWS: Note minimum Python version.
5558
5559 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5560
5561         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5562         code from these functions.  Remove corresponding ifdefs.  Use
5563         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5564         Remove gotos and target of gotos.
5565         (infpy_search_memory): Likewise.
5566
5567 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5568
5569         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5570         (hppa_gdbarch_init): Don't register deleted functions with
5571         gdbarch.
5572
5573 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5574
5575         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5576         (h8300_unwind_sp): Delete.
5577         (h8300_dummy_id): Delete.
5578         (h8300_gdbarch_init): Don't register deleted functions with
5579         gdbarch.
5580
5581 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5582
5583         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5584         (ft32_unwind_pc): Delete.
5585         (ft32_unwind_sp): Delete.
5586         (ft32_gdbarch_init): Don't register deleted functions with
5587         gdbarch.
5588
5589 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5590
5591         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5592         (frv_unwind_pc): Delete.
5593         (frv_unwind_sp): Delete.
5594         (frv_gdbarch_init): Don't register deleted functions with
5595         gdbarch.
5596
5597 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5598
5599         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5600         (riscv_unwind_pc): Delete.
5601         (riscv_unwind_sp): Delete.
5602         (riscv_gdbarch_init): Don't register deleted functions with
5603         gdbarch.
5604
5605 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5606
5607         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5608         (csky_unwind_pc): Delete.
5609         (csky_unwind_sp): Delete.
5610         (csky_gdbarch_init): Don't register deleted functions with
5611         gdbarch.
5612
5613 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5614
5615         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5616         (cris_unwind_pc): Delete.
5617         (cris_unwind_sp): Delete.
5618         (cris_gdbarch_init): Don't register deleted functions with
5619         gdbarch.
5620
5621 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5622
5623         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5624         (bfin_unwind_pc): Delete.
5625         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5626
5627 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5628
5629         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5630         (arm_unwind_pc): Delete.
5631         (arm_unwind_sp): Delete.
5632         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5633
5634 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5635
5636         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5637         (arc_unwind_pc): Delete.
5638         (arc_unwind_sp): Delete.
5639         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5640
5641 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5642
5643         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5644         (alpha_unwind_pc): Delete.
5645         (alpha_gdbarch_init): Don't register deleted functions with
5646         gdbarch.
5647
5648 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5649
5650         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5651         (aarch64_unwind_pc): Delete.
5652         (aarch64_unwind_sp): Delete.
5653         (aarch64_gdbarch_init): Don't register deleted functions with
5654         gdbarch.
5655
5656 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5657
5658         * gdbtypes.c (type_align): Don't consider static members when
5659         computing structure alignment.
5660
5661 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5662
5663         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5664         return 0 for other types.
5665         * arch-utils.c (default_type_align): Always return 0.
5666         * gdbarch.h: Regenerate.
5667         * gdbarch.sh (type_align): Extend comment.
5668         * gdbtypes.c (type_align): Add additional comments, always call
5669         gdbarch_type_align before applying the default rules.
5670         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5671         generic code will then apply a suitable default.
5672         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5673         types, return 0 for other types.
5674
5675 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5676
5677         * NEWS: Create a new section for the next release branch.
5678         Rename the section of the current branch, now that it has
5679         been cut.
5680
5681 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5682
5683         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5684         * version.in: Bump version to 8.3.50.DATE-git.
5685
5686 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5687
5688         * aix-thread.c (ptid_cmp): Remove unused variable.
5689         (get_signaled_thread): Likewise.
5690         (store_regs_user_thread): Likewise.
5691         (store_regs_kernel_thread): Likewise.
5692         (fetch_regs_kernel_thread): Remove shadowed variable.
5693
5694 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5695
5696         * features/riscv/32bit-cpu.xml: Add register numbers.
5697         * features/riscv/32bit-fpu.c: Regenerate.
5698         * features/riscv/32bit-fpu.xml: Add register numbers.
5699         * features/riscv/64bit-cpu.xml: Add register numbers.
5700         * features/riscv/64bit-fpu.c: Regenerate.
5701         * features/riscv/64bit-fpu.xml: Add register numbers.
5702
5703 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5704
5705         * NEWS: Mention two argument form of gdb.Value constructor.
5706         * python/py-value.c (convert_buffer_and_type_to_value): New
5707         function.
5708         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5709         Add support for handling an optional second argument.  Call
5710         convert_buffer_and_type_to_value as appropriate.
5711         * python/python-internal.h (Py_buffer_deleter): New struct.
5712         (Py_buffer_up): New typedef.
5713
5714 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5715
5716         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5717         instead of releasing ownership.
5718
5719 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5720
5721         * dwarf2read.c (open_and_init_dwp_file): Call
5722         elf_numsections instead of bfd_count_sections to initialize
5723         dwp_file->num_sections.
5724
5725 2019-02-25  Tom Tromey  <tromey@adacore.com>
5726
5727         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5728
5729 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5730
5731         * gcore.in: Add '--readnever' option when invoking GDB.
5732
5733 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5734
5735         * MAINTAINERS: Update my email address.
5736
5737 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5738
5739         * build-id.c (build_id_to_debug_bfd_1): New function.
5740         (build_id_to_debug_bfd): Look for separate debug file in
5741         sysroot.
5742
5743 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5744
5745         * gdbarch.sh: Update the copyright year range that is placed into
5746         generated files.
5747
5748 2019-02-22  Keith Seitz  <keiths@redhat.com>
5749
5750         PR symtab/23853
5751         * linespec.c (create_sals_line_offset): Search for the default
5752         symtab's filename instead of its fullname.
5753
5754 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5755
5756         * NEWS: Update style defaults.
5757
5758 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5759
5760         * main.c (captured_main_1): Disable styling in batch mode.
5761
5762 2019-02-20  Tom Tromey  <tom@tromey.com>
5763
5764         * symtab.c (symtab_symbol_info): Fix typos.
5765
5766 2019-02-20  Tom Tromey  <tromey@adacore.com>
5767
5768         * findcmd.c (_initialize_mem_search): Use upper case for
5769         metasyntactic variables.
5770
5771 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5772
5773         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5774         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5775
5776 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5777
5778         * top.h (source_file_name): Change to std::string.
5779         * top.c (source_file_name): Likewise.
5780         (command_line_input): Adjust.
5781         * cli/cli-script.c (script_from_file): Adjust.
5782
5783 2019-02-19  Tom Tromey  <tromey@adacore.com>
5784
5785         * ravenscar-thread.c
5786         (ravenscar_thread_target::update_thread_list): Don't call
5787         ada_build_task_list.
5788         * ada-lang.h (ada_build_task_list): Don't declare.
5789         * ada-tasks.c (struct ada_tasks_inferior_data)
5790         <task_list_valid_p>: Now bool.
5791         (read_known_tasks, ada_task_list_changed)
5792         (ada_tasks_invalidate_inferior_data): Update.
5793         (read_known_tasks_array): Return bool.
5794         (read_known_tasks_list): Likewise.
5795         (read_known_tasks): Return void.
5796         (ada_build_task_list): Now static.
5797
5798 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5799
5800         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5801         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5802
5803 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5804
5805         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5806         variant for ada_tasks_pspace_data_handle and
5807         ada_tasks_inferior_data_handle.
5808         (ada_tasks_pspace_data_cleanup): New function.
5809         (ada_tasks_inferior_data_cleanup): New function.
5810
5811 2019-02-17  Tom Tromey  <tom@tromey.com>
5812
5813         * macrotab.h (macro_source_fullname): Return a std::string.
5814         * macrotab.c (macro_include, check_for_redefinition)
5815         (macro_undef, macro_lookup_definition, foreach_macro)
5816         (foreach_macro_in_scope): Update.
5817         (macro_source_fullname): Return a std::string.
5818         * macrocmd.c (show_pp_source_pos): Update.
5819
5820 2019-02-17  Tom Tromey  <tom@tromey.com>
5821
5822         * macrocmd.c (show_pp_source_pos): Style the file names.
5823
5824 2019-02-17  Tom Tromey  <tom@tromey.com>
5825
5826         PR tui/24197:
5827         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5828
5829 2019-02-17  Tom Tromey  <tom@tromey.com>
5830
5831         * ada-lang.c (user_select_syms): Use filtered printing.
5832         * utils.c (wrap_style): New global.
5833         (desired_style): Remove.
5834         (emit_style_escape): Add stream parameter.
5835         (set_output_style, reset_terminal_style, prompt_for_continue):
5836         Update.
5837         (flush_wrap_buffer): Only flush gdb_stdout.
5838         (wrap_here): Set wrap_style.
5839         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5840         treat escape sequences as a character.  Change when wrap buffer is
5841         flushed.
5842         (fputs_styled): Do not set the output style when the default is
5843         requested.
5844         * ui-style.h (struct ui_file_style) <is_default>: New method.
5845         * source.c (print_source_lines_base): Emit escape sequences in one
5846         piece.
5847
5848 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5849
5850         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5851         integers and enumeration types.
5852
5853 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5854
5855         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5856         instead of lookup_symbol_in_language
5857         (do_exact_match): New function.
5858         (ada_get_symbol_name_matcher): Return do_exact_match when
5859         doing a verbatim match.
5860
5861 2019-02-15  Tom Tromey  <tromey@adacore.com>
5862
5863         * ravenscar-thread.c (ravenscar_thread_target::resume)
5864         (ravenscar_thread_target::wait): Special case wildcard requests.
5865
5866 2019-02-15  Tom Tromey  <tromey@adacore.com>
5867
5868         * ravenscar-thread.c (base_ptid): Remove.
5869         (struct ravenscar_thread_target) <close>: New method.
5870         <m_base_ptid>: New member.
5871         <update_inferior_ptid, active_task, task_is_currently_active,
5872         runtime_initialized>: Declare methods.
5873         <ravenscar_thread_target>: Add constructor.
5874         (ravenscar_thread_target::task_is_currently_active)
5875         (ravenscar_thread_target::update_inferior_ptid)
5876         (ravenscar_runtime_initialized): Rename.  Now methods.
5877         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5878         (ravenscar_thread_target::update_thread_list): Update.
5879         (ravenscar_thread_target::active_task): Now method.
5880         (ravenscar_thread_target::store_registers)
5881         (ravenscar_thread_target::prepare_to_store)
5882         (ravenscar_thread_target::prepare_to_store)
5883         (ravenscar_thread_target::mourn_inferior): Update.
5884         (ravenscar_inferior_created): Use "new" to create target.
5885         (ravenscar_thread_target::get_ada_task_ptid): Update.
5886         (_initialize_ravenscar): Don't initialize base_ptid.
5887         (ravenscar_ops): Remove global.
5888
5889 2019-02-15  Tom Tromey  <tromey@adacore.com>
5890
5891         * target.h (push_target): Declare new overload.
5892         * target.c (push_target): New overload, taking an rvalue reference.
5893         * remote.c (remote_target::open_1): Use push_target overload.
5894         * corelow.c (core_target_open): Use push_target overload.
5895
5896 2019-02-15  Tom Tromey  <tromey@adacore.com>
5897
5898         * ravenscar-thread.c (is_ravenscar_task)
5899         (ravenscar_task_is_currently_active): Return bool.
5900         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5901         (_initialize_ravenscar): Remove "(void)".
5902         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5903         Return bool.
5904
5905 2019-02-15  Tom Tromey  <tromey@adacore.com>
5906
5907         * ravenscar-thread.c (ravenscar_runtime_initializer)
5908         (has_ravenscar_runtime, get_running_thread_id)
5909         (ravenscar_thread_target::resume): Fix indentation.
5910
5911 2019-02-15  Tom Tromey  <tromey@adacore.com>
5912
5913         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5914         from ravenscar_arch_ops.
5915         (sparc_ravenscar_ops::fetch_registers)
5916         (sparc_ravenscar_ops::store_registers): Now methods.
5917         (sparc_ravenscar_prepare_to_store): Remove.
5918         (sparc_ravenscar_ops): Redefine.
5919         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5920         methods and destructor.  Remove members.
5921         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5922         (ravenscar_thread_target::store_registers)
5923         (ravenscar_thread_target::prepare_to_store): Update.
5924         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5925         Remove.
5926         (struct ppc_ravenscar_powerpc_ops): Derive from
5927         ravenscar_arch_ops.
5928         (ppc_ravenscar_powerpc_ops::fetch_registers)
5929         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5930         (ppc_ravenscar_powerpc_ops): Redefine.
5931         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5932         (ppc_ravenscar_e500_ops::fetch_registers)
5933         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5934         (ppc_ravenscar_e500_ops): Redefine.
5935         * aarch64-ravenscar-thread.c
5936         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5937         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5938         (aarch64_ravenscar_fetch_registers)
5939         (aarch64_ravenscar_store_registers): Now methods.
5940         (aarch64_ravenscar_ops): Redefine.
5941
5942 2019-02-15  Tom Tromey  <tromey@adacore.com>
5943
5944         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5945         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5946         (ravenscar_thread_target::stopped_by_watchpoint)
5947         (ravenscar_thread_target::stopped_data_address)
5948         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5949
5950 2019-02-15  Tom Tromey  <tromey@adacore.com>
5951
5952         * ravenscar-thread.c: Fix some typos.
5953
5954 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5955             Tom Tromey  <tromey@adacore.com>
5956
5957         * ada-lang.c (ada_exception_sal): Change addr_string to a
5958         std::string.
5959         (create_ada_exception_catchpoint): Update.
5960
5961 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5962             Tom Tromey  <tromey@adacore.com>
5963
5964         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5965         (bp_location_ops): Remove.
5966         (base_breakpoint_allocate_location): Update.
5967         (free_bp_location): Update.
5968         * ada-lang.c (class ada_catchpoint_location)
5969         <ada_catchpoint_location>: Remove ops parameter.
5970         (ada_catchpoint_location_dtor): Remove.
5971         (ada_catchpoint_location_ops): Remove.
5972         (allocate_location_exception): Update.
5973         * breakpoint.h (struct bp_location_ops): Remove.
5974         (class bp_location) <bp_location>: Remove bp_location_ops
5975         parameter.
5976         <~bp_location>: Add destructor.
5977         <ops>: Remove.
5978
5979 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5980             Pedro Alves  <palves@redhat.com>
5981
5982         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5983         'PATH_MAX'.
5984
5985 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5986             Samuel Thibault  <samuel.thibault@gnu.org>
5987             Thomas Schwinge  <thomas@codesourcery.com>
5988
5989         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5990         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5991
5992 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5993
5994         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5995         (check_empty): Use "const char *".
5996
5997         * gnu-nat.c (gnu_nat_target::detach): Instead of
5998         'detach_inferior (pid)' call
5999         'detach_inferior (find_inferior_pid (pid))'.
6000
6001         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6002         'nat/fork-inferior.o'.
6003         * gnu-nat.c: #include "nat/fork-inferior.h".
6004
6005         * gnu-nat.c (gnu_nat_target::detach): Instead of
6006         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6007         * gnu-nat.h: #include "inf-child.h".
6008         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6009         'i386_gnu_nat_target::fetch_registers'.
6010         (gnu_store_registers): Rename/move to
6011         'i386_gnu_nat_target::store_registers'.
6012
6013         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6014         * gnu-nat.h (mach_thread_info): New function.
6015         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6016
6017         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6018
6019 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6020
6021         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6022
6023 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6024
6025         * windows-nat.c (windows_add_thread): Add new parameter
6026         "main_thread_p" with default value set to false.  Update
6027         function documentation as well as all callers.
6028         (windows_delete_thread): Likewise.
6029         (fake_create_process): Update call to windows_add_thread.
6030         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6031         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6032         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6033         call to windows_delete_thread.
6034
6035 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6036
6037         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6038
6039 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6040
6041         * symfile.c (find_separate_debug_file): Use canonical path of
6042         sysroot with child_path instead of gdb_sysroot if it is valid.
6043
6044 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6045
6046         * symfile.c (find_separate_debug_file): Use child_path to
6047         determine if an object file is under a sysroot.
6048
6049 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6050
6051         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6052         unittests/child-path-selftests.c.
6053         * common/pathstuff.c (child_path): New function.
6054         * common/pathstuff.h (child_path): New prototype.
6055         * unittests/child-path-selftests.c: New file.
6056
6057 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6058
6059         * symfile.c (find_separate_debug_file): Look for separate debug
6060         files in debug directories under the sysroot.
6061
6062 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6063
6064         * symtab.h (struct minimal_symbol data_p): New const method.
6065         (struct minimal_symbol text_p): Likewise.
6066         * symtab.c (output_source_filename): Use file name style
6067         to print file name.
6068         (print_symbol_info): Likewise.
6069         (print_msymbol_info): Use address style to print addresses.
6070         Use function name style to print executable text symbols.
6071         (expand_symtab_containing_pc): Use data_p.
6072         (find_pc_sect_compunit_symtab): Likewise.
6073
6074 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6075
6076         * breakpoint.c (describe_other_breakpoints): Use address style
6077         to print addresses.
6078         (say_where): Likewise.
6079
6080 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6081
6082         * ada-typeprint.c (print_func_type): Print function name
6083         style to print function name.
6084         * c-typeprint.c (c_print_type_1): Likewise.
6085
6086 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6087
6088         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6089         for execve.
6090
6091 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6092
6093         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6094         type_stack.
6095
6096 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6097
6098         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6099         TYPE_CODE_REF types.
6100
6101 2019-02-08  Jim Wilson  <jimw@sifive.com>
6102
6103         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6104         (riscv_linux_fregset): New.
6105         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6106
6107 2019-02-07  Tom Tromey  <tom@tromey.com>
6108
6109         * thread.c (thread_cancel_execution_command): Update.
6110         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6111         methods.
6112         (struct thread_fsm_ops): Remove.
6113         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6114         (thread_fsm_should_stop, thread_fsm_return_value)
6115         (thread_fsm_set_finished, thread_fsm_finished_p)
6116         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6117         Don't declare.
6118         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6119         * infrun.c (clear_proceed_status_thread)
6120         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6121         (print_stop_event): Update.
6122         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6123         Add constructor.
6124         (step_command_fsm_ops): Remove.
6125         (new_step_command_fsm): Remove.
6126         (step_1): Update.
6127         (step_command_fsm::should_stop): Rename from
6128         step_command_fsm_should_stop.
6129         (step_command_fsm::clean_up): Rename from
6130         step_command_fsm_clean_up.
6131         (step_command_fsm::do_async_reply_reason): Rename from
6132         step_command_fsm_async_reply_reason.
6133         (struct until_next_fsm): Inherit from thread_fsm.  Add
6134         constructor.
6135         (until_next_fsm_ops): Remove.
6136         (new_until_next_fsm): Remove.
6137         (until_next_fsm::should_stop): Rename from
6138         until_next_fsm_should_stop.
6139         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6140         (until_next_fsm::do_async_reply_reason): Rename from
6141         until_next_fsm_async_reply_reason.
6142         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6143         constructor.  Change type of breakpoint.
6144         (finish_command_fsm_ops): Remove.
6145         (new_finish_command_fsm): Remove.
6146         (finish_command_fsm::should_stop): Rename from
6147         finish_command_fsm_should_stop.
6148         (finish_command_fsm::clean_up): Rename from
6149         finish_command_fsm_clean_up.
6150         (finish_command_fsm::return_value): Rename from
6151         finish_command_fsm_return_value.
6152         (finish_command_fsm::do_async_reply_reason): Rename from
6153         finish_command_fsm_async_reply_reason.
6154         (finish_command): Update.
6155         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6156         Add constructor.
6157         (call_thread_fsm_ops): Remove.
6158         (call_thread_fsm::call_thread_fsm): Rename from
6159         new_call_thread_fsm.
6160         (call_thread_fsm::should_stop): Rename from
6161         call_thread_fsm_should_stop.
6162         (call_thread_fsm::should_notify_stop): Rename from
6163         call_thread_fsm_should_notify_stop.
6164         (run_inferior_call, call_function_by_hand_dummy): Update.
6165         * cli/cli-interp.c (should_print_stop_to_console): Update.
6166         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6167         Add constructor.  Change type of location_breakpoint,
6168         caller_breakpoint.
6169         (until_break_fsm_ops): Remove.
6170         (new_until_break_fsm): Remove.
6171         (until_break_fsm::should_stop): Rename from
6172         until_break_fsm_should_stop.
6173         (until_break_fsm::clean_up): Rename from
6174         until_break_fsm_clean_up.
6175         (until_break_fsm::do_async_reply_reason): Rename from
6176         until_break_fsm_async_reply_reason.
6177         (until_break_command): Update.
6178         * thread-fsm.c: Remove.
6179         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6180
6181 2019-02-07  Tom Tromey  <tom@tromey.com>
6182
6183         * yy-remap.h: Add include guard.
6184         * xtensa-tdep.h: Add include guard.
6185         * xcoffread.h: Rename include guard.
6186         * varobj-iter.h: Add include guard.
6187         * tui/tui.h: Rename include guard.
6188         * tui/tui-winsource.h: Rename include guard.
6189         * tui/tui-wingeneral.h: Rename include guard.
6190         * tui/tui-windata.h: Rename include guard.
6191         * tui/tui-win.h: Rename include guard.
6192         * tui/tui-stack.h: Rename include guard.
6193         * tui/tui-source.h: Rename include guard.
6194         * tui/tui-regs.h: Rename include guard.
6195         * tui/tui-out.h: Rename include guard.
6196         * tui/tui-layout.h: Rename include guard.
6197         * tui/tui-io.h: Rename include guard.
6198         * tui/tui-hooks.h: Rename include guard.
6199         * tui/tui-file.h: Rename include guard.
6200         * tui/tui-disasm.h: Rename include guard.
6201         * tui/tui-data.h: Rename include guard.
6202         * tui/tui-command.h: Rename include guard.
6203         * tic6x-tdep.h: Add include guard.
6204         * target/waitstatus.h: Rename include guard.
6205         * target/wait.h: Rename include guard.
6206         * target/target.h: Rename include guard.
6207         * target/resume.h: Rename include guard.
6208         * target-float.h: Rename include guard.
6209         * stabsread.h: Add include guard.
6210         * rs6000-tdep.h: Add include guard.
6211         * riscv-fbsd-tdep.h: Add include guard.
6212         * regformats/regdef.h: Rename include guard.
6213         * record.h: Rename include guard.
6214         * python/python.h: Rename include guard.
6215         * python/python-internal.h: Rename include guard.
6216         * python/py-stopevent.h: Rename include guard.
6217         * python/py-ref.h: Rename include guard.
6218         * python/py-record.h: Rename include guard.
6219         * python/py-record-full.h: Rename include guard.
6220         * python/py-record-btrace.h: Rename include guard.
6221         * python/py-instruction.h: Rename include guard.
6222         * python/py-events.h: Rename include guard.
6223         * python/py-event.h: Rename include guard.
6224         * procfs.h: Add include guard.
6225         * proc-utils.h: Add include guard.
6226         * p-lang.h: Add include guard.
6227         * or1k-tdep.h: Rename include guard.
6228         * observable.h: Rename include guard.
6229         * nto-tdep.h: Rename include guard.
6230         * nat/x86-linux.h: Rename include guard.
6231         * nat/x86-linux-dregs.h: Rename include guard.
6232         * nat/x86-gcc-cpuid.h: Add include guard.
6233         * nat/x86-dregs.h: Rename include guard.
6234         * nat/x86-cpuid.h: Rename include guard.
6235         * nat/ppc-linux.h: Rename include guard.
6236         * nat/mips-linux-watch.h: Rename include guard.
6237         * nat/linux-waitpid.h: Rename include guard.
6238         * nat/linux-ptrace.h: Rename include guard.
6239         * nat/linux-procfs.h: Rename include guard.
6240         * nat/linux-osdata.h: Rename include guard.
6241         * nat/linux-nat.h: Rename include guard.
6242         * nat/linux-namespaces.h: Rename include guard.
6243         * nat/linux-btrace.h: Rename include guard.
6244         * nat/glibc_thread_db.h: Rename include guard.
6245         * nat/gdb_thread_db.h: Rename include guard.
6246         * nat/gdb_ptrace.h: Rename include guard.
6247         * nat/fork-inferior.h: Rename include guard.
6248         * nat/amd64-linux-siginfo.h: Rename include guard.
6249         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6250         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6251         * nat/aarch64-linux.h: Rename include guard.
6252         * nat/aarch64-linux-hw-point.h: Rename include guard.
6253         * mn10300-tdep.h: Add include guard.
6254         * mips-linux-tdep.h: Add include guard.
6255         * mi/mi-parse.h: Rename include guard.
6256         * mi/mi-out.h: Rename include guard.
6257         * mi/mi-main.h: Rename include guard.
6258         * mi/mi-interp.h: Rename include guard.
6259         * mi/mi-getopt.h: Rename include guard.
6260         * mi/mi-console.h: Rename include guard.
6261         * mi/mi-common.h: Rename include guard.
6262         * mi/mi-cmds.h: Rename include guard.
6263         * mi/mi-cmd-break.h: Rename include guard.
6264         * m2-lang.h: Add include guard.
6265         * location.h: Rename include guard.
6266         * linux-record.h: Rename include guard.
6267         * linux-nat.h: Add include guard.
6268         * linux-fork.h: Add include guard.
6269         * i386-darwin-tdep.h: Rename include guard.
6270         * hppa-linux-offsets.h: Add include guard.
6271         * guile/guile.h: Rename include guard.
6272         * guile/guile-internal.h: Rename include guard.
6273         * gnu-nat.h: Rename include guard.
6274         * gdb-stabs.h: Rename include guard.
6275         * frv-tdep.h: Add include guard.
6276         * f-lang.h: Add include guard.
6277         * event-loop.h: Add include guard.
6278         * darwin-nat.h: Rename include guard.
6279         * cp-abi.h: Rename include guard.
6280         * config/sparc/nm-sol2.h: Rename include guard.
6281         * config/nm-nto.h: Rename include guard.
6282         * config/nm-linux.h: Add include guard.
6283         * config/i386/nm-i386gnu.h: Rename include guard.
6284         * config/djgpp/nl_types.h: Rename include guard.
6285         * config/djgpp/langinfo.h: Rename include guard.
6286         * compile/gcc-cp-plugin.h: Add include guard.
6287         * compile/gcc-c-plugin.h: Add include guard.
6288         * compile/compile.h: Rename include guard.
6289         * compile/compile-object-run.h: Rename include guard.
6290         * compile/compile-object-load.h: Rename include guard.
6291         * compile/compile-internal.h: Rename include guard.
6292         * compile/compile-cplus.h: Rename include guard.
6293         * compile/compile-c.h: Rename include guard.
6294         * common/xml-utils.h: Rename include guard.
6295         * common/x86-xstate.h: Rename include guard.
6296         * common/version.h: Rename include guard.
6297         * common/vec.h: Rename include guard.
6298         * common/tdesc.h: Rename include guard.
6299         * common/selftest.h: Rename include guard.
6300         * common/scoped_restore.h: Rename include guard.
6301         * common/scoped_mmap.h: Rename include guard.
6302         * common/scoped_fd.h: Rename include guard.
6303         * common/safe-iterator.h: Rename include guard.
6304         * common/run-time-clock.h: Rename include guard.
6305         * common/refcounted-object.h: Rename include guard.
6306         * common/queue.h: Rename include guard.
6307         * common/ptid.h: Rename include guard.
6308         * common/print-utils.h: Rename include guard.
6309         * common/preprocessor.h: Rename include guard.
6310         * common/pathstuff.h: Rename include guard.
6311         * common/observable.h: Rename include guard.
6312         * common/netstuff.h: Rename include guard.
6313         * common/job-control.h: Rename include guard.
6314         * common/host-defs.h: Rename include guard.
6315         * common/gdb_wait.h: Rename include guard.
6316         * common/gdb_vecs.h: Rename include guard.
6317         * common/gdb_unlinker.h: Rename include guard.
6318         * common/gdb_unique_ptr.h: Rename include guard.
6319         * common/gdb_tilde_expand.h: Rename include guard.
6320         * common/gdb_sys_time.h: Rename include guard.
6321         * common/gdb_string_view.h: Rename include guard.
6322         * common/gdb_splay_tree.h: Rename include guard.
6323         * common/gdb_setjmp.h: Rename include guard.
6324         * common/gdb_ref_ptr.h: Rename include guard.
6325         * common/gdb_optional.h: Rename include guard.
6326         * common/gdb_locale.h: Rename include guard.
6327         * common/gdb_assert.h: Rename include guard.
6328         * common/filtered-iterator.h: Rename include guard.
6329         * common/filestuff.h: Rename include guard.
6330         * common/fileio.h: Rename include guard.
6331         * common/environ.h: Rename include guard.
6332         * common/common-utils.h: Rename include guard.
6333         * common/common-types.h: Rename include guard.
6334         * common/common-regcache.h: Rename include guard.
6335         * common/common-inferior.h: Rename include guard.
6336         * common/common-gdbthread.h: Rename include guard.
6337         * common/common-exceptions.h: Rename include guard.
6338         * common/common-defs.h: Rename include guard.
6339         * common/common-debug.h: Rename include guard.
6340         * common/cleanups.h: Rename include guard.
6341         * common/buffer.h: Rename include guard.
6342         * common/btrace-common.h: Rename include guard.
6343         * common/break-common.h: Rename include guard.
6344         * cli/cli-utils.h: Rename include guard.
6345         * cli/cli-style.h: Rename include guard.
6346         * cli/cli-setshow.h: Rename include guard.
6347         * cli/cli-script.h: Rename include guard.
6348         * cli/cli-interp.h: Rename include guard.
6349         * cli/cli-decode.h: Rename include guard.
6350         * cli/cli-cmds.h: Rename include guard.
6351         * charset-list.h: Add include guard.
6352         * buildsym-legacy.h: Rename include guard.
6353         * bfin-tdep.h: Add include guard.
6354         * ax.h: Rename include guard.
6355         * arm-linux-tdep.h: Add include guard.
6356         * arm-fbsd-tdep.h: Add include guard.
6357         * arch/xtensa.h: Rename include guard.
6358         * arch/tic6x.h: Add include guard.
6359         * arch/i386.h: Add include guard.
6360         * arch/arm.h: Rename include guard.
6361         * arch/arm-linux.h: Rename include guard.
6362         * arch/arm-get-next-pcs.h: Rename include guard.
6363         * arch/amd64.h: Add include guard.
6364         * arch/aarch64-insn.h: Rename include guard.
6365         * arch-utils.h: Rename include guard.
6366         * annotate.h: Add include guard.
6367         * amd64-darwin-tdep.h: Rename include guard.
6368         * aarch64-linux-tdep.h: Add include guard.
6369         * aarch64-fbsd-tdep.h: Add include guard.
6370         * aarch32-linux-nat.h: Add include guard.
6371
6372 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6373
6374         * macrotab.c (macro_define_internal): New function that
6375         factorizes macro_define_object_internal and macro_define_function
6376         code.
6377         (macro_define_object_internal): Use macro_define_internal.
6378         (macro_define_function): Likewise.
6379
6380 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6381
6382         * macrocmd.c (extract_identifier): Return
6383         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6384         callers.
6385
6386 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6387
6388         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6389
6390 2019-02-05  Tom Tromey  <tom@tromey.com>
6391
6392         * target.c (target_stack::unpush): Move assertion earlier.
6393
6394 2019-01-30  Tom Tromey  <tom@tromey.com>
6395
6396         PR python/23615:
6397         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6398         (gdbpy_parse_and_eval): Likewise.
6399         * python/python-internal.h (gdbpy_allow_threads): New class.
6400
6401 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6402
6403         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6404         (aarch64_fbsd_fpregmap): Move earlier.
6405         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6406         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6407         instead of individual calls to trad_frame_set_reg_addr.
6408         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6409         earlier.
6410         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6411         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6412         instead of individual calls to trad_frame_set_reg_addr.
6413
6414 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6415
6416         * CONTRIBUTE: Replace contribution list with wiki link.
6417
6418 2019-01-25  Tom Tromey  <tom@tromey.com>
6419
6420         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6421
6422 2019-01-25  Tom Tromey  <tom@tromey.com>
6423
6424         * xtensa-linux-nat.c: Fix common/ includes.
6425         * xml-support.h: Fix common/ includes.
6426         * xml-support.c: Fix common/ includes.
6427         * x86-linux-nat.c: Fix common/ includes.
6428         * windows-nat.c: Fix common/ includes.
6429         * varobj.h: Fix common/ includes.
6430         * varobj.c: Fix common/ includes.
6431         * value.c: Fix common/ includes.
6432         * valops.c: Fix common/ includes.
6433         * utils.c: Fix common/ includes.
6434         * unittests/xml-utils-selftests.c: Fix common/ includes.
6435         * unittests/utils-selftests.c: Fix common/ includes.
6436         * unittests/unpack-selftests.c: Fix common/ includes.
6437         * unittests/tracepoint-selftests.c: Fix common/ includes.
6438         * unittests/style-selftests.c: Fix common/ includes.
6439         * unittests/string_view-selftests.c: Fix common/ includes.
6440         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6441         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6442         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6443         * unittests/rsp-low-selftests.c: Fix common/ includes.
6444         * unittests/parse-connection-spec-selftests.c: Fix common/
6445         includes.
6446         * unittests/optional-selftests.c: Fix common/ includes.
6447         * unittests/offset-type-selftests.c: Fix common/ includes.
6448         * unittests/observable-selftests.c: Fix common/ includes.
6449         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6450         * unittests/memrange-selftests.c: Fix common/ includes.
6451         * unittests/memory-map-selftests.c: Fix common/ includes.
6452         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6453         * unittests/function-view-selftests.c: Fix common/ includes.
6454         * unittests/environ-selftests.c: Fix common/ includes.
6455         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6456         * unittests/common-utils-selftests.c: Fix common/ includes.
6457         * unittests/cli-utils-selftests.c: Fix common/ includes.
6458         * unittests/array-view-selftests.c: Fix common/ includes.
6459         * ui-file.c: Fix common/ includes.
6460         * tui/tui-io.c: Fix common/ includes.
6461         * tracepoint.h: Fix common/ includes.
6462         * tracepoint.c: Fix common/ includes.
6463         * tracefile-tfile.c: Fix common/ includes.
6464         * top.h: Fix common/ includes.
6465         * top.c: Fix common/ includes.
6466         * thread.c: Fix common/ includes.
6467         * target/waitstatus.h: Fix common/ includes.
6468         * target/waitstatus.c: Fix common/ includes.
6469         * target.h: Fix common/ includes.
6470         * target.c: Fix common/ includes.
6471         * target-memory.c: Fix common/ includes.
6472         * target-descriptions.c: Fix common/ includes.
6473         * symtab.h: Fix common/ includes.
6474         * symfile.c: Fix common/ includes.
6475         * stap-probe.c: Fix common/ includes.
6476         * spu-linux-nat.c: Fix common/ includes.
6477         * sparc-nat.c: Fix common/ includes.
6478         * source.c: Fix common/ includes.
6479         * solib.c: Fix common/ includes.
6480         * solib-target.c: Fix common/ includes.
6481         * ser-unix.c: Fix common/ includes.
6482         * ser-tcp.c: Fix common/ includes.
6483         * ser-pipe.c: Fix common/ includes.
6484         * ser-base.c: Fix common/ includes.
6485         * selftest-arch.c: Fix common/ includes.
6486         * s12z-tdep.c: Fix common/ includes.
6487         * rust-exp.y: Fix common/ includes.
6488         * rs6000-aix-tdep.c: Fix common/ includes.
6489         * riscv-tdep.c: Fix common/ includes.
6490         * remote.c: Fix common/ includes.
6491         * remote-notif.h: Fix common/ includes.
6492         * remote-fileio.h: Fix common/ includes.
6493         * remote-fileio.c: Fix common/ includes.
6494         * regcache.h: Fix common/ includes.
6495         * regcache.c: Fix common/ includes.
6496         * record-btrace.c: Fix common/ includes.
6497         * python/python.c: Fix common/ includes.
6498         * python/py-type.c: Fix common/ includes.
6499         * python/py-inferior.c: Fix common/ includes.
6500         * progspace.h: Fix common/ includes.
6501         * producer.c: Fix common/ includes.
6502         * procfs.c: Fix common/ includes.
6503         * proc-api.c: Fix common/ includes.
6504         * printcmd.c: Fix common/ includes.
6505         * ppc-linux-nat.c: Fix common/ includes.
6506         * parser-defs.h: Fix common/ includes.
6507         * osdata.c: Fix common/ includes.
6508         * obsd-nat.c: Fix common/ includes.
6509         * nat/x86-linux.c: Fix common/ includes.
6510         * nat/x86-linux-dregs.c: Fix common/ includes.
6511         * nat/x86-dregs.h: Fix common/ includes.
6512         * nat/x86-dregs.c: Fix common/ includes.
6513         * nat/ppc-linux.c: Fix common/ includes.
6514         * nat/mips-linux-watch.h: Fix common/ includes.
6515         * nat/mips-linux-watch.c: Fix common/ includes.
6516         * nat/linux-waitpid.c: Fix common/ includes.
6517         * nat/linux-ptrace.h: Fix common/ includes.
6518         * nat/linux-ptrace.c: Fix common/ includes.
6519         * nat/linux-procfs.c: Fix common/ includes.
6520         * nat/linux-personality.c: Fix common/ includes.
6521         * nat/linux-osdata.c: Fix common/ includes.
6522         * nat/linux-namespaces.c: Fix common/ includes.
6523         * nat/linux-btrace.h: Fix common/ includes.
6524         * nat/linux-btrace.c: Fix common/ includes.
6525         * nat/fork-inferior.c: Fix common/ includes.
6526         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6527         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6528         * nat/aarch64-linux.c: Fix common/ includes.
6529         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6530         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6531         * namespace.h: Fix common/ includes.
6532         * mips-linux-tdep.c: Fix common/ includes.
6533         * minsyms.c: Fix common/ includes.
6534         * mi/mi-parse.h: Fix common/ includes.
6535         * mi/mi-main.c: Fix common/ includes.
6536         * mi/mi-cmd-env.c: Fix common/ includes.
6537         * memrange.h: Fix common/ includes.
6538         * memattr.c: Fix common/ includes.
6539         * maint.h: Fix common/ includes.
6540         * maint.c: Fix common/ includes.
6541         * main.c: Fix common/ includes.
6542         * machoread.c: Fix common/ includes.
6543         * location.c: Fix common/ includes.
6544         * linux-thread-db.c: Fix common/ includes.
6545         * linux-nat.c: Fix common/ includes.
6546         * linux-fork.c: Fix common/ includes.
6547         * inline-frame.c: Fix common/ includes.
6548         * infrun.c: Fix common/ includes.
6549         * inflow.c: Fix common/ includes.
6550         * inferior.h: Fix common/ includes.
6551         * inferior.c: Fix common/ includes.
6552         * infcmd.c: Fix common/ includes.
6553         * inf-ptrace.c: Fix common/ includes.
6554         * inf-child.c: Fix common/ includes.
6555         * ia64-linux-nat.c: Fix common/ includes.
6556         * i387-tdep.c: Fix common/ includes.
6557         * i386-tdep.c: Fix common/ includes.
6558         * i386-linux-tdep.c: Fix common/ includes.
6559         * i386-linux-nat.c: Fix common/ includes.
6560         * i386-go32-tdep.c: Fix common/ includes.
6561         * i386-fbsd-tdep.c: Fix common/ includes.
6562         * i386-fbsd-nat.c: Fix common/ includes.
6563         * guile/scm-type.c: Fix common/ includes.
6564         * guile/guile.c: Fix common/ includes.
6565         * go32-nat.c: Fix common/ includes.
6566         * gnu-nat.c: Fix common/ includes.
6567         * gdbthread.h: Fix common/ includes.
6568         * gdbarch-selftests.c: Fix common/ includes.
6569         * gdb_usleep.c: Fix common/ includes.
6570         * gdb_select.h: Fix common/ includes.
6571         * gdb_bfd.c: Fix common/ includes.
6572         * gcore.c: Fix common/ includes.
6573         * fork-child.c: Fix common/ includes.
6574         * findvar.c: Fix common/ includes.
6575         * fbsd-nat.c: Fix common/ includes.
6576         * event-top.c: Fix common/ includes.
6577         * event-loop.c: Fix common/ includes.
6578         * dwarf2read.c: Fix common/ includes.
6579         * dwarf2loc.c: Fix common/ includes.
6580         * dwarf2-frame.c: Fix common/ includes.
6581         * dwarf-index-cache.c: Fix common/ includes.
6582         * dtrace-probe.c: Fix common/ includes.
6583         * disasm-selftests.c: Fix common/ includes.
6584         * defs.h: Fix common/ includes.
6585         * csky-tdep.c: Fix common/ includes.
6586         * cp-valprint.c: Fix common/ includes.
6587         * cp-support.h: Fix common/ includes.
6588         * cp-support.c: Fix common/ includes.
6589         * corelow.c: Fix common/ includes.
6590         * completer.h: Fix common/ includes.
6591         * completer.c: Fix common/ includes.
6592         * compile/compile.c: Fix common/ includes.
6593         * compile/compile-loc2c.c: Fix common/ includes.
6594         * compile/compile-cplus-types.c: Fix common/ includes.
6595         * compile/compile-cplus-symbols.c: Fix common/ includes.
6596         * command.h: Fix common/ includes.
6597         * cli/cli-dump.c: Fix common/ includes.
6598         * cli/cli-cmds.c: Fix common/ includes.
6599         * charset.c: Fix common/ includes.
6600         * build-id.c: Fix common/ includes.
6601         * btrace.h: Fix common/ includes.
6602         * btrace.c: Fix common/ includes.
6603         * breakpoint.h: Fix common/ includes.
6604         * breakpoint.c: Fix common/ includes.
6605         * ax.h:
6606         (enum agent_op): Fix common/ includes.
6607         * ax-general.c (struct aop_map): Fix common/ includes.
6608         * ax-gdb.c: Fix common/ includes.
6609         * auxv.c: Fix common/ includes.
6610         * auto-load.c: Fix common/ includes.
6611         * arm-tdep.c: Fix common/ includes.
6612         * arch/riscv.c: Fix common/ includes.
6613         * arch/ppc-linux-common.c: Fix common/ includes.
6614         * arch/i386.c: Fix common/ includes.
6615         * arch/arm.c: Fix common/ includes.
6616         * arch/arm-linux.c: Fix common/ includes.
6617         * arch/arm-get-next-pcs.c: Fix common/ includes.
6618         * arch/amd64.c: Fix common/ includes.
6619         * arch/aarch64.c: Fix common/ includes.
6620         * arch/aarch64-insn.c: Fix common/ includes.
6621         * arch-utils.c: Fix common/ includes.
6622         * amd64-windows-tdep.c: Fix common/ includes.
6623         * amd64-tdep.c: Fix common/ includes.
6624         * amd64-sol2-tdep.c: Fix common/ includes.
6625         * amd64-obsd-tdep.c: Fix common/ includes.
6626         * amd64-nbsd-tdep.c: Fix common/ includes.
6627         * amd64-linux-tdep.c: Fix common/ includes.
6628         * amd64-linux-nat.c: Fix common/ includes.
6629         * amd64-fbsd-tdep.c: Fix common/ includes.
6630         * amd64-fbsd-nat.c: Fix common/ includes.
6631         * amd64-dicos-tdep.c: Fix common/ includes.
6632         * amd64-darwin-tdep.c: Fix common/ includes.
6633         * agent.c: Fix common/ includes.
6634         * ada-lang.h: Fix common/ includes.
6635         * ada-lang.c: Fix common/ includes.
6636         * aarch64-tdep.c: Fix common/ includes.
6637
6638 2019-01-25  Tom Tromey  <tom@tromey.com>
6639
6640         * common/create-version.sh: Use common/version.h.
6641
6642 2019-01-24  Pedro Alves  <palves@redhat.com>
6643
6644         * infrun.c (signal_stop, signal_print, signal_program)
6645         (signal_catch, signal_pass): Now arrays instead of pointers.
6646         (update_signals_program_target, do_target_resume)
6647         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6648         * linux-nat.c (linux_nat_target::pass_signals)
6649         (linux_nat_target::create_inferior, linux_nat_target::attach):
6650         Adjust.
6651         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6652         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6653         * procfs.c (procfs_target::pass_signals): Adjust.
6654         * record-full.c (record_full_target::resume): Adjust.
6655         * remote.c (remote_target::pass_signals)
6656         (remote_target::program_signals): Adjust.
6657         * target-debug.h (target_debug_print_signals): Now takes a
6658         gdb::array_view as parameter.  Adjust.
6659         * target.h (target_ops) <pass_signals, program_signals>: Replace
6660         pointer and length parameters with gdb::array_view.
6661         (target_pass_signals, target_program_signals): Likewise.
6662         * target-delegates.c: Regenerate.
6663
6664 2019-01-24  Pedro Alves  <palves@redhat.com>
6665
6666         * common/forward-scope-exit.h
6667         (forward_scope_exit::forward_scope_exit): Pass arguments to
6668         m_bind_function directly, instead of creating a std::bind and
6669         copying that.
6670
6671 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6672
6673         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6674         for static members.
6675         (pass_in_v_vfp_candidate): Likewise.
6676
6677 2019-01-23  Tom Tromey  <tom@tromey.com>
6678             Pedro Alves  <palves@redhat.com>
6679
6680         * regcache.c (class regcache_invalidator): Remove.
6681         (regcache::raw_write): Use make_scope_exit.
6682
6683 2019-01-23  Tom Tromey  <tom@tromey.com>
6684
6685         * ui-out.h (class ui_out_emit_type): Update comment.
6686
6687 2019-01-23  Tom Tromey  <tom@tromey.com>
6688
6689         * infrun.c (fetch_inferior_event): Update comment.
6690
6691 2019-01-23  Tom Tromey  <tom@tromey.com>
6692             Pedro Alves  <palves@redhat.com>
6693
6694         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6695         parameter.
6696         (fetch_inferior_event): Use SCOPE_EXIT.
6697
6698
6699 2019-01-23  Tom Tromey  <tom@tromey.com>
6700             Pedro Alves  <palves@redhat.com>
6701
6702         * infrun.c (disable_thread_events): Delete.
6703         (stop_all_threads): Use SCOPE_EXIT.
6704
6705 2019-01-23  Tom Tromey  <tom@tromey.com>
6706             Pedro Alves  <palves@redhat.com>
6707
6708         * symfile.c: Include forward-scope-exit.h.
6709         (clear_symtab_users_cleanup): Replace forward declaration with
6710         a FORWARD_SCOPE_EXIT.
6711         (syms_from_objfile_1): Use the forward_scope_exit and
6712         gdb::optional instead of cleanup_function.
6713         (reread_symbols): Use the forward_scope_exit instead of
6714         cleanup_function.
6715         (clear_symtab_users_cleanup): Remove function.
6716
6717 2019-01-23  Tom Tromey  <tom@tromey.com>
6718             Pedro Alves  <palves@redhat.com>
6719
6720         * linux-nat.c: Include scope-exit.h.
6721         (cleanup_target_stop): Remove.
6722         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6723         SCOPE_EXIT.
6724
6725 2019-01-23  Tom Tromey  <tom@tromey.com>
6726             Pedro Alves  <palves@redhat.com>
6727
6728         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6729         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6730
6731 2019-01-23  Tom Tromey  <tom@tromey.com>
6732             Andrew Burgess  <andrew.burgess@embecosm.com>
6733             Pedro Alves  <palves@redhat.com>
6734
6735         * infrun.c (fetch_inferior_event): Use scope_exit.
6736         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6737         * top.c (execute_command): Use scope_exit.
6738         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6739         * utils.c (do_bpstat_clear_actions_cleanup)
6740         (make_bpstat_clear_actions_cleanup): Remove.
6741
6742 2019-01-23  Tom Tromey  <tom@tromey.com>
6743             Pedro Alves  <palves@redhat.com>
6744
6745         * infrun.c: Include "common/scope-exit.h"
6746         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6747         (wait_for_inferior): Use SCOPE_EXIT.
6748         (fetch_inferior_event): Use scope_exit.
6749
6750 2019-01-23  Tom Tromey  <tom@tromey.com>
6751             Pedro Alves  <palves@redhat.com>
6752
6753         * breakpoint.c (create_breakpoint): Remove cleanup.
6754
6755 2019-01-23  Tom Tromey  <tom@tromey.com>
6756             Andrew Burgess  <andrew.burgess@embecosm.com>
6757             Pedro Alves  <palves@redhat.com>
6758
6759 2019-01-23  Pedro Alves  <palves@redhat.com>
6760
6761         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6762
6763 2019-01-23  Pedro Alves  <palves@redhat.com>
6764             Andrew Burgess  <andrew.burgess@embecosm.com>
6765
6766         * gdbthread.h: Include "common/forward-scope-exit.h".
6767         (scoped_finish_thread_state): Redefine custom class in terms of
6768         forward_scope_exit.
6769
6770 2019-01-23  Pedro Alves  <palves@redhat.com>
6771             Andrew Burgess  <andrew.burgess@embecosm.com>
6772
6773         * common/forward-scope-exit.h: New file.
6774
6775 2019-01-23  Pedro Alves  <palves@redhat.com>
6776             Andrew Burgess  <andrew.burgess@embecosm.com>
6777             Tom Tromey  <tom@tromey.com>
6778
6779         * common/scope-exit.h: New file.
6780
6781 2019-01-23  Pedro Alves  <palves@redhat.com>
6782
6783         * common/preprocessor.h (ESC): Rename to ...
6784         (ESC_PARENS): ... this.
6785         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6786         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6787
6788 2019-01-23  Tom Tromey  <tom@tromey.com>
6789
6790         * language.h (class scoped_switch_to_sym_language_if_auto):
6791         Initialize m_lang in both cases.
6792
6793 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6794
6795         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6796         with XCNEW.
6797
6798 2019-01-22  Tom Tromey  <tom@tromey.com>
6799
6800         * corelow.c: Do not include sys/file.h.
6801
6802 2019-01-22  Tom Tromey  <tom@tromey.com>
6803
6804         * tui/tui-wingeneral.h: Include gdb_curses.h.
6805
6806 2019-01-22  Tom Tromey  <tom@tromey.com>
6807
6808         * source-cache.h (class source_cache) <get_source_lines,
6809         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6810
6811 2019-01-22  Tom Tromey  <tom@tromey.com>
6812
6813         * remote-fileio.h (struct remote_target): Declare.
6814
6815 2019-01-22  Tom Tromey  <tom@tromey.com>
6816
6817         * python/py-arch.c: Do not include py-ref.h.
6818         * python/py-bpevent.c: Do not include py-ref.h.
6819         * python/py-cmd.c: Do not include py-ref.h.
6820         * python/py-continueevent.c: Do not include py-ref.h.
6821         * python/py-event.h: Do not include py-ref.h.
6822         * python/py-evtregistry.c: Do not include py-ref.h.
6823         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6824         * python/py-frame.c: Do not include py-ref.h.
6825         * python/py-framefilter.c: Do not include py-ref.h.
6826         * python/py-function.c: Do not include py-ref.h.
6827         * python/py-infevents.c: Do not include py-ref.h.
6828         * python/py-linetable.c: Do not include py-ref.h.
6829         * python/py-objfile.c: Do not include py-ref.h.
6830         * python/py-param.c: Do not include py-ref.h.
6831         * python/py-prettyprint.c: Do not include py-ref.h.
6832         * python/py-progspace.c: Do not include py-ref.h.
6833         * python/py-symbol.c: Do not include py-ref.h.
6834         * python/py-symtab.c: Do not include py-ref.h.
6835         * python/py-type.c: Do not include py-ref.h.
6836         * python/py-unwind.c: Do not include py-ref.h.
6837         * python/py-utils.c: Do not include py-ref.h.
6838         * python/py-value.c: Do not include py-ref.h.
6839         * python/py-varobj.c: Do not include py-ref.h.
6840         * python/py-xmethods.c: Do not include py-ref.h.
6841         * python/python.c: Do not include py-ref.h.
6842         * varobj.c: Do not include py-ref.h.
6843
6844 2019-01-22  Tom Tromey  <tom@tromey.com>
6845
6846         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6847         keyword for bcache.
6848
6849 2019-01-22  Tom Tromey  <tom@tromey.com>
6850
6851         * compile/compile-cplus-types.c: Remove a comment by #include.
6852
6853 2019-01-22  Tom Tromey  <tom@tromey.com>
6854
6855         * compile/gcc-c-plugin.h: Include compile-internal.h.
6856
6857 2019-01-22  Tom Tromey  <tom@tromey.com>
6858
6859         * stabsread.c (EXTERN): Do not define.
6860         (symnum, next_symbol_text_func, processing_gcc_compilation)
6861         (within_function, global_sym_chain, global_stabs)
6862         (previous_stab_code, this_object_header_files)
6863         (n_this_object_header_files)
6864         (n_allocated_this_object_header_files): Define.
6865         * stabsread.h (EXTERN): Never define.  Use "extern".
6866
6867 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6868
6869         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6870         history_value.
6871
6872 2019-01-21  Tom Tromey  <tom@tromey.com>
6873
6874         * ui-out.c: Fix includes.
6875         * tui/tui-source.c: Fix includes.
6876         * target.c: Fix includes.
6877         * remote.c: Fix includes.
6878         * regcache.c: Fix includes.
6879         * python/py-block.c: Fix includes.
6880         * printcmd.c: Fix includes.
6881         * or1k-tdep.c: Fix includes.
6882         * mi/mi-main.c: Fix includes.
6883         * m32r-tdep.c: Fix includes.
6884         * csky-tdep.c: Fix includes.
6885         * compile/compile-cplus-types.c: Fix includes.
6886         * cli/cli-interp.c: Fix includes.
6887
6888 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6889
6890         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6891         for padding.
6892
6893 2019-01-16  Tom Tromey  <tom@tromey.com>
6894
6895         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6896         earlier.
6897         (struct objfile) <msymbols_range>: Move from top level.
6898         <msymbols>: New method.
6899         (class objfile_msymbols): Remove.
6900         * symtab.c (default_collect_symbol_completion_matches_break_on):
6901         Update.
6902         * symmisc.c (dump_msymbols): Update.
6903         * stabsread.c (scan_file_globals): Update.
6904         * objc-lang.c (info_selectors_command, info_classes_command)
6905         (find_methods): Update.
6906         * minsyms.c (find_solib_trampoline_target): Update.
6907         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6908         * coffread.c (coff_symfile_read): Update.
6909         * ada-lang.c (ada_lookup_simple_minsym)
6910         (ada_collect_symbol_completion_matches): Update.
6911
6912 2019-01-16  Tom Tromey  <tom@tromey.com>
6913
6914         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6915         type.  Remove no-argument constructor.
6916         <iterator::operator++>: Simplify.
6917         <begin>: Update.
6918         <end>: Use minimal_symbol_count.
6919
6920 2019-01-16  Tom Tromey  <tom@tromey.com>
6921
6922         * objfiles.h (struct objfile) <psymtabs>: New method.
6923         (class objfile_psymtabs): Remove.
6924         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6925         typedef.
6926         <range>: New method.
6927         (require_partial_symbols): Change return type.
6928         * psymtab.c (require_partial_symbols)
6929         (psym_expand_symtabs_matching): Update.
6930         * mdebugread.c (parse_partial_symbols): Update.
6931         * dbxread.c (dbx_end_psymtab): Update.
6932
6933 2019-01-15  Tom Tromey  <tom@tromey.com>
6934
6935         * symtab.c (lookup_objfile_from_block)
6936         (lookup_symbol_in_objfile_symtabs)
6937         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6938         (find_line_symtab, info_sources_command)
6939         (default_collect_symbol_completion_matches_break_on)
6940         (make_source_files_completion_list): Update.
6941         * symmisc.c (print_objfile_statistics, dump_objfile)
6942         (maintenance_print_symbols, maintenance_info_symtabs)
6943         (maintenance_check_symtabs, maintenance_info_line_tables):
6944         Update.
6945         * source.c (select_source_symtab)
6946         (forget_cached_source_info_for_objfile): Update.
6947         * objfiles.h (class objfile_compunits): Remove.
6948         (struct objfile) <compunits_range>: New typedef.
6949         (compunits): New method.
6950         * objfiles.c (objfile_relocate1): Update.
6951         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6952         * maint.c (count_symtabs_and_blocks): Update.
6953         * linespec.c (iterate_over_all_matching_symtabs): Update.
6954         * cp-support.c (add_symbol_overload_list_qualified): Update.
6955         * coffread.c (coff_symtab_read): Update.
6956         * ada-lang.c (add_nonlocal_symbols)
6957         (ada_collect_symbol_completion_matches)
6958         (ada_add_global_exceptions): Update.
6959
6960 2019-01-15  Tom Tromey  <tom@tromey.com>
6961
6962         * progspace.h (program_space) <objfiles_safe_range>: New
6963         typedef.
6964         <objfiles_safe>: New method.
6965         * objfiles.h (class all_objfiles_safe): Remove.
6966         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6967         * jit.c (jit_inferior_exit_hook): Update.
6968
6969 2019-01-17  Tom Tromey  <tom@tromey.com>
6970
6971         * progspace.h (program_space) <objfiles_range>: New typedef.
6972         <objfiles>: New method.
6973         <objfiles_head>: Rename from objfiles.
6974         (object_files): Update.
6975         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6976         * guile/scm-pretty-print.c
6977         (ppscm_find_pretty_printer_from_objfiles): Update.
6978         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6979         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6980         Update.
6981         * python/py-progspace.c (pspy_get_objfiles): Update.
6982         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6983         Update.
6984         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6985         (objfpy_lookup_objfile_by_build_id): Update.
6986         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6987         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6988         Update.
6989         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6990         (expand_symtab_containing_pc, lookup_objfile_from_block)
6991         (lookup_static_symbol, basic_lookup_transparent_type)
6992         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6993         (find_line_symtab, info_sources_command)
6994         (default_collect_symbol_completion_matches_break_on)
6995         (make_source_files_completion_list, find_main_name): Update.
6996         * symmisc.c (print_symbol_bcache_statistics)
6997         (print_objfile_statistics, maintenance_print_symbols)
6998         (maintenance_print_msymbols, maintenance_print_objfiles)
6999         (maintenance_info_symtabs, maintenance_check_symtabs)
7000         (maintenance_expand_symtabs, maintenance_info_line_tables):
7001         Update.
7002         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7003         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7004         (map_overlay_command, unmap_overlay_command)
7005         (simple_overlay_update, expand_symtabs_matching)
7006         (map_symbol_filenames): Update.
7007         * symfile-debug.c (set_debug_symfile): Update.
7008         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7009         Update.
7010         * source.c (select_source_symtab, forget_cached_source_info):
7011         Update.
7012         * solib.c (solib_read_symbols): Update.
7013         * solib-spu.c (append_ocl_sos): Update.
7014         * psymtab.c (maintenance_print_psymbols)
7015         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7016         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7017         * printcmd.c (info_symbol_command): Update.
7018         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7019         Update.
7020         * objfiles.h (class all_objfiles): Remove.
7021         * objfiles.c (have_partial_symbols, have_full_symbols)
7022         (have_minimal_symbols, qsort_cmp, update_section_map)
7023         (shared_objfile_contains_address_p)
7024         (default_iterate_over_objfiles_in_search_order): Update.
7025         * objc-lang.c (info_selectors_command, info_classes_command)
7026         (find_methods): Update.
7027         * minsyms.c (find_solib_trampoline_target): Update.
7028         * maint.c (maintenance_info_sections)
7029         (maintenance_translate_address, count_symtabs_and_blocks):
7030         Update.
7031         * main.c (captured_main_1): Update.
7032         * linux-thread-db.c (try_thread_db_load_from_pdir)
7033         (has_libpthread): Update.
7034         * linespec.c (iterate_over_all_matching_symtabs)
7035         (search_minsyms_for_name): Update.
7036         * jit.c (jit_find_objf_with_entry_addr): Update.
7037         * hppa-tdep.c (find_unwind_entry)
7038         (hppa_lookup_stub_minimal_symbol): Update.
7039         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7040         Update.
7041         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7042         (elf_gnu_ifunc_resolve_by_got): Update.
7043         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7044         * dwarf-index-write.c (save_gdb_index_command): Update.
7045         * cp-support.c (add_symbol_overload_list_qualified): Update.
7046         * breakpoint.c (create_overlay_event_breakpoint)
7047         (create_longjmp_master_breakpoint)
7048         (create_std_terminate_master_breakpoint)
7049         (create_exception_master_breakpoint): Update.
7050         * blockframe.c (find_pc_partial_function): Update.
7051         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7052         (ada_collect_symbol_completion_matches)
7053         (ada_add_global_exceptions): Update.
7054
7055 2019-01-17  Tom Tromey  <tom@tromey.com>
7056
7057         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7058         declare VEC.
7059         (solib_target_parse_libraries): Change return type.
7060         (library_list_start_segment, library_list_start_section)
7061         (library_list_end_library, library_list_start_library); Update.
7062         (solib_target_free_library_list): Remove.
7063         (solib_target_parse_libraries): Remove cleanup.  Change return
7064         type.
7065         (solib_target_current_sos): Update.
7066
7067 2019-01-17  Tom Tromey  <tromey@bapiya>
7068
7069         * valprint.c: Replace "the the" with "the".
7070         * symtab.c: Replace "the the" with "the".
7071         * solib.c: Replace "the the" with "the".
7072         * solib-dsbt.c: Replace "the the" with "the".
7073         * linespec.c: Replace "the the" with "the".
7074         * dwarf2loc.h: Replace "the the" with "the".
7075         * amd64-windows-tdep.c: Replace "the the" with "the".
7076         * aarch64-tdep.c: Replace "the the" with "the".
7077
7078 2019-01-16  Keith Seitz  <keiths@redhat.com>
7079
7080         PR gdb/23773
7081         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7082         <builder>: Rename to ..
7083         <m_builder>: ... this and make private.
7084         (dwarf2_cu::get_builder): New method.  Change all users of
7085         `builder' to use this method.
7086         (dwarf2_start_symtab): Move to ...
7087         (dwarf2_cu::start_symtab): ... here.  Update all callers
7088         (setup_type_unit_groups): Move to ...
7089         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7090         callers.
7091         (dwarf2_cu::reset_builder): New method.
7092         (process_full_compunit, process_full_type_unit): Use
7093         dwarf2_cu::reset_builder.
7094         (follow_die_offset): Record the ancestor CU if it is different
7095         from the followed DIE's CU.
7096         (follow_die_sig_1): Likewise.
7097
7098 2019-01-15  Tom Tromey  <tom@tromey.com>
7099
7100         * remote.c (class remote_state) <buf>: Now a char_vector.
7101         <buf_size>: Remove.
7102         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7103         parameter.
7104         (remote_target::getpkt_or_notif_sane_1)
7105         (remote_target::getpkt_sane)
7106         (remote_target::getpkt_or_notif_sane): Likewise.
7107         (class remote_target) <putpkt>: New overload.
7108         (remote_target::read_frame): Change type of "buf_p".  Remove
7109         sizeof_p parameter.
7110         (packet_ok): New overload.
7111         (packet_check_result): New overload.
7112         Update all uses.
7113
7114 2019-01-14  Tom Tromey  <tom@tromey.com>
7115
7116         * remote-notif.c (handle_notification, remote_notif_ack)
7117         (remote_notif_parse): Make "buf" const.
7118         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7119         const.
7120         (remote_notif_parse, remote_notif_ack, handle_notification):
7121         Likewise.
7122         * remote.c (remote_notif_stop_parse): Make "buf" const.
7123         (remote_target::remote_parse_stop_reply): Make "buf" const.
7124         (remote_notif_stop_ack): Make "buf" const.
7125
7126 2019-01-14  Tom Tromey  <tom@tromey.com>
7127
7128         * remote.c (remote_console_output): Make parameter const.
7129
7130 2019-01-14  Tom Tromey  <tom@tromey.com>
7131
7132         * target-debug.h (target_debug_print_signals): Constify.
7133         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7134         * procfs.c (procfs_target::pass_signals): Update.
7135         * linux-nat.c (linux_nat_target::pass_signals): Update.
7136         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7137         * target-delegates.c: Rebuild.
7138         * remote.c (remote_target::program_signals): Update.
7139         (remote_target::pass_signals): Update.
7140         * target.c (target_pass_signals): Constify argument.
7141         (target_program_signals): Likewise.
7142         * target.h (struct target_ops) <pass_signals, program_signals>:
7143         Constify argument.
7144         (target_pass_signals, target_program_signals): Constify argument.
7145
7146 2019-01-14  Tom Tromey  <tom@tromey.com>
7147
7148         PR tui/28819:
7149         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7150
7151 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7152
7153         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7154         field.
7155         * rs6000-tdep.c: Include reggroups.h.
7156         (IS_V_ALIAS_PSEUDOREG): Define.
7157         (rs6000_register_name): Return names for the "vX" aliases.
7158         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7159         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7160         aliases.  Call default_register_reggroup_p for all other
7161         pseudo-registers.
7162         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7163         New functions.
7164         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7165         Handle "vX" aliases.
7166         (v_alias_pseudo_register_collect): New function.
7167         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7168         (rs6000_gdbarch_init): Initialize "vX" aliases as
7169         pseudo-registers.  Restore registration of
7170         rs6000_pseudo_register_reggroup_p with
7171         set_tdesc_pseudo_register_reggroup_p.
7172
7173 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7174
7175         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7176         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7177         set_gdbarch_num_pseudo_regs.
7178
7179 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7180
7181         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7182         Remove arg prefixname, add do_set and do_show.
7183         Add member functions set_list and show_list.
7184         * cli/cli-style.c (class cli_style_option): Update accordingly.
7185         (style_set_list): Move to file scope.
7186         (style_show_list): Likewise.
7187         (set_style): Call help_list.
7188         (show_style): Call cmd_show_list.
7189         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7190         Update to use the new macro.
7191
7192 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7193
7194         * ada-lang.c (_initialize_ada_language): Expand the help text
7195         for the "catch exception" command.
7196
7197 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7198
7199         * symtab.c (matching_obj_sections): Initialize obj,
7200         declare it closer to its usage.
7201
7202 2019-01-10  Tom Tromey  <tom@tromey.com>
7203
7204         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7205         (basic_inf_threads_range): Remove.
7206         (inf_threads_range, inf_non_exited_threads_range)
7207         (safe_inf_threads_range): Use next_adapter.
7208
7209 2019-01-10  Keith Seitz  <keiths@redhat.com>
7210
7211         PR gdb/23712
7212         PR symtab/23010
7213         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7214         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7215
7216 2019-01-10  Keith Seitz  <keiths@redhat.com>
7217
7218         PR gdb/23712
7219         PR symtab/23010
7220         * dictionary.c (pending_to_vector): Remove.
7221         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7222         Remove _1 suffix, replacing functions of the same name.  Update
7223         all callers.
7224         (dict_create_hashed, dict_create_hashed_expandable)
7225         (dict_create_linear, dict_create_linear_expandable, dict_free)
7226         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7227         Make functions static.
7228
7229 2019-01-10  Keith Seitz  <keiths@redhat.com>
7230
7231         PR gdb/23712
7232         PR symtab/23010
7233         * dictionary.h (struct dictionary): Replace declaration with
7234         multidictionary.
7235         (dict_create_hashed, dict_create_hashed_expandable)
7236         (dict_create_linear, dict_create_linear_expandable)
7237         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7238         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7239         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7240         taking multidictionary argument.
7241         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7242         * block.h (struct block) <dict>: Change to multidictionary
7243         and rename `multidict'.
7244         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7245         symmisc.c: Update all dictionary references to multidictionary.
7246
7247 2019-01-10  Keith Seitz  <keiths@redhat.com>
7248
7249         PR gdb/23712
7250         PR symtab/23010
7251         * dictionary.c: Include unordered_map.
7252         (pending_to_vector): New function.
7253         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7254         Rewrite the non-"_1" functions to take vector instead
7255         of linked list.
7256         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7257         "new" _1 versions of the same name.
7258         (multidictionary): Define.
7259         (std::hash<enum language): New definition.
7260         (collate_pending_symbols_by_language, mdict_create_hashed)
7261         (mdict_create_hashed_expandable, mdict_create_linear)
7262         (mdict_create_linear_expandable, mdict_free)
7263         (find_language_dictionary, create_new_language_dictionary)
7264         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7265         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7266         (mdict_size, mdict_empty): New functions.
7267         * dictionary.h (mdict_iterator): Define.
7268
7269 2019-01-10  Pedro Alves  <palves@redhat.com>
7270
7271         * breakpoint.c (read_uploaded_action)
7272         (create_tracepoint_from_upload): Adjust to use
7273         gdb::unique_xmalloc_ptr.
7274         * ctf.c (ctf_write_uploaded_tp):
7275         (SET_ARRAY_FIELD): Use emplace_back.
7276         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7277         * tracefile-tfile.c (tfile_write_uploaded_tp):
7278         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7279         gdb::unique_xmalloc_ptr.
7280         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7281         at_string, cond_string, cmd_strings>: Replace char pointers
7282         with gdb::unique_xmalloc_ptr.
7283
7284 2019-01-10  Pedro Alves  <palves@redhat.com>
7285
7286         * solib-target.c (library_list_start_library): Don't xstrdup name.
7287
7288 2019-01-10  Pedro Alves  <palves@redhat.com>
7289
7290         * mdebugread.c (parse_partial_symbols): Use
7291         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7292
7293 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7294
7295         * linux-fork.c (scoped_switch_fork_info)
7296         <~scoped_switch_fork_info>: Fix incorrect variable name.
7297
7298 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7299
7300         * linux-fork.c (scoped_switch_fork_info)
7301         <scoped_switch_fork_info>: Make explicit.
7302         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7303
7304 2019-01-10  Tom Tromey  <tom@tromey.com>
7305
7306         * objfiles.h (objfile::reset_psymtabs): Update.
7307         * objfiles.c (objfile::objfile): Update.
7308         * psymtab.h (psymtab_storage::obstack): Update.
7309         (psymtab_storage::m_obstack): Use gdb::optional.
7310         (class psymtab_storage): Update comment.  Remove objfile
7311         parameter.
7312         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7313
7314 2019-01-10  Tom Tromey  <tom@tromey.com>
7315
7316         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7317         <free_psymtabs>: Now private.
7318         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7319         (allocate_psymtab): Use new method.
7320
7321 2019-01-10  Tom Tromey  <tom@tromey.com>
7322
7323         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7324         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7325         * mdebugread.c (parse_partial_symbols): Use
7326         allocate_dependencies.
7327         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7328         allocate_dependencies.
7329         (process_psymtab_comp_unit_reader)
7330         (build_type_psymtab_dependencies): Likewise.
7331         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7332
7333 2019-01-10  Tom Tromey  <tom@tromey.com>
7334
7335         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7336         PSYMBOL_SET_LANGUAGE.
7337         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7338
7339 2019-01-10  Tom Tromey  <tom@tromey.com>
7340
7341         * psymtab.h (psymtab_storage::obstack): New method.
7342         <m_obstack>: Rename from obstack; now private.
7343         * psymtab.c (psymtab_storage): Update.
7344         * dwarf2read.c (create_addrmap_from_index)
7345         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7346         Update.
7347
7348 2019-01-10  Tom Tromey  <tom@tromey.com>
7349
7350         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7351         * objfiles.h (objfile::reset_psymtabs): New method.
7352
7353 2019-01-10  Tom Tromey  <tom@tromey.com>
7354
7355         * symmisc.c (print_symbol_bcache_statistics): Update.
7356         (print_objfile_statistics): Update.
7357         * symfile.c (reread_symbols): Update.
7358         * psymtab.h (class psymtab_storage): New.
7359         * psymtab.c (psymtab_storage): New constructor.
7360         (~psymtab_storage): New destructor.
7361         (require_partial_symbols): Update.
7362         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7363         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7364         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7365         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7366         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7367         (start_psymtab_common, end_psymtab_common)
7368         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7369         (allocate_psymtab): Update.
7370         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7371         Update.
7372         (dump_psymtab_addrmap, maintenance_print_psymbols)
7373         (maintenance_check_psymtabs): Update.
7374         (class objfile_psymtabs): Move to objfiles.h.
7375         * psympriv.h (discard_psymtab): Now inline.
7376         (psymtab_discarder::psymtab_discarder): Update.
7377         (psymtab_discarder::~psymtab_discarder): Update.
7378         (ALL_OBJFILE_PSYMTABS): Rewrite.
7379         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7380         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7381         Remove fields.
7382         <partial_symtabs>: New field.
7383         (class objfile_psymtabs): Move from psymtab.h.  Update.
7384         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7385         psymbol_cache.
7386         (objfile::~objfile): Don't destroy psymbol_cache.
7387         * mdebugread.c (parse_partial_symbols): Update.
7388         * dwarf2read.c (create_addrmap_from_index)
7389         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7390         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7391         (add_partial_subprogram, dwarf2_ranges_read): Update.
7392         * dwarf-index-write.c (write_address_map)
7393         (write_one_signatured_type, recursively_write_psymbols)
7394         (class debug_names, class debug_names, write_psymtabs_to_index):
7395         Update.
7396
7397 2019-01-10  Tom Tromey  <tom@tromey.com>
7398
7399         * symtab.h (SYMBOL_SET_NAMES): Update.
7400         (symbol_set_names): Update.
7401         (MSYMBOL_SET_NAMES): Update.
7402         * symtab.c (symbol_set_names): Change argument to be an
7403         objfile_per_bfd_storage.
7404         * psymtab.c (add_psymbol_to_bcache): Update.
7405         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7406
7407 2019-01-10  Tom Tromey  <tom@tromey.com>
7408
7409         * symtab.c (create_demangled_names_hash): Change argument to be an
7410         objfile_per_bfd_storage.
7411         (symbol_set_names): Update.
7412
7413 2019-01-10  Tom Tromey  <tom@tromey.com>
7414
7415         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7416         init_psymbol_list.
7417         * psymtab.c (init_psymbol_list): Do nothing if already called.
7418         * psympriv.h (init_psymbol_list): Add comment.
7419         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7420         init_psymbol_list.
7421         * dbxread.c (dbx_symfile_read): Unconditionally call
7422         init_psymbol_list.
7423
7424 2019-01-10  Tom Tromey  <tom@tromey.com>
7425
7426         * xcoffread.c (scan_xcoff_symtab): Update.
7427         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7428         "where".
7429         * mdebugread.c (parse_partial_symbols)
7430         (handle_psymbol_enumerators): Update.
7431         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7432         * dbxread.c (read_dbx_symtab): Update.
7433         * psympriv.h (psymbol_placement): New enum.
7434         (add_psymbol_to_list): Update.
7435
7436 2019-01-10  Tom Tromey  <tom@tromey.com>
7437
7438         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7439         static_psymbols parameters.
7440         (scan_xcoff_symtab): Update.
7441         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7442         static_psymbols parameters.
7443         * psympriv.h (start_psymtab_common): Update.
7444         * mdebugread.c (parse_partial_symbols): Update.
7445         * dwarf2read.c (create_partial_symtab): Update.
7446         * dbxread.c (read_dbx_symtab): Update.
7447         (start_psymtab): Remove global_psymbols and static_psymbols
7448         parameters.
7449
7450 2019-01-10  Tom Tromey  <tom@tromey.com>
7451
7452         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7453         * psymtab.c (allocate_psymtab): Add comment.
7454         * psympriv.h (allocate_psymtab): Add comment.
7455         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7456         initializations.
7457         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7458
7459 2019-01-10  Tom Tromey  <tom@tromey.com>
7460
7461         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7462         Don't declare.
7463         * mipsread.c: Include mdebugread.h.
7464         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7465         Declare.
7466         * elfread.c: Include mdebugread.h.
7467
7468 2019-01-09  Tom Tromey  <tom@tromey.com>
7469
7470         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7471         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7472         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7473         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7474         (psym_lookup_symbol, psym_find_last_source_symtab)
7475         (psym_forget_cached_source_info, psym_print_stats)
7476         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7477         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7478         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7479         (psym_find_compunit_symtab_by_address)
7480         (maintenance_print_psymbols, maintenance_info_psymtabs)
7481         (maintenance_check_psymtabs): Use ranged for.
7482         * psymtab.h (class objfile_psymtabs): New.
7483         (require_partial_symbols): Return objfile_psymtabs.
7484         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7485
7486 2019-01-09  Tom Tromey  <tom@tromey.com>
7487
7488         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7489         (find_pc_mapped_section, list_overlays_command)
7490         (map_overlay_command, unmap_overlay_command)
7491         (simple_overlay_update): Use all_objfiles.
7492         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7493         * printcmd.c (info_symbol_command): Use all_objfiles.
7494         * objfiles.h (ALL_OBJSECTIONS): Remove.
7495         * maint.c (maintenance_translate_address): Use all_objfiles.
7496         * gcore.c (gcore_create_callback): Use all_objfiles.
7497         (objfile_find_memory_regions): Likewise.
7498
7499 2019-01-09  Tom Tromey  <tom@tromey.com>
7500
7501         * symtab.c (find_line_symtab, info_sources_command)
7502         (make_source_files_completion_list): Use objfile_compunits.
7503         * source.c (select_source_symtab): Use objfile_compunits.
7504         * objfiles.h (struct objfile): Update comment.
7505         (ALL_OBJFILES): Remove.
7506         (ALL_FILETABS): Remove.
7507         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7508         objfile_compunits.
7509
7510 2019-01-09  Tom Tromey  <tom@tromey.com>
7511
7512         * symmisc.c (print_objfile_statistics, dump_objfile)
7513         (maintenance_print_symbols): Use compunit_filetabs.
7514         * source.c (forget_cached_source_info_for_objfile): Use
7515         compunit_filetabs.
7516         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7517         (ALL_FILETABS): Use compunit_filetabs.
7518         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7519         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7520
7521 2019-01-09  Tom Tromey  <tom@tromey.com>
7522
7523         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7524         (compunit_filetabs): New.
7525         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7526         compunit_filetabs.
7527         (info_sources_command, make_source_files_completion_list): Remove
7528         declaration.
7529         * symmisc.c (print_objfile_statistics, dump_objfile)
7530         (maintenance_print_symbols): Remove declaration.
7531         (maintenance_info_symtabs): Use compunit_filetabs.
7532         (maintenance_info_line_tables): Likewise.
7533         * source.c (select_source_symtab): Change local variable name.
7534         (forget_cached_source_info_for_objfile): Remove declaration.
7535         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7536         * objfiles.c (objfile_relocate1): Remove declaration.
7537         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7538         declaration.
7539         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7540         * coffread.c (coff_symtab_read): Remove declaration.
7541         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7542         compunit_filetabs.
7543
7544 2019-01-09  Tom Tromey  <tom@tromey.com>
7545
7546         * symtab.c (lookup_objfile_from_block)
7547         (find_pc_sect_compunit_symtab, search_symbols)
7548         (default_collect_symbol_completion_matches_break_on): Use
7549         objfile_compunits.
7550         * objfiles.h (ALL_COMPUNITS): Remove.
7551         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7552         * cp-support.c (add_symbol_overload_list_qualified): Use
7553         objfile_compunits.
7554         * ada-lang.c (ada_collect_symbol_completion_matches)
7555         (ada_add_global_exceptions): Use objfile_compunits.
7556
7557 2019-01-09  Tom Tromey  <tom@tromey.com>
7558
7559         * source.c (select_source_symtab)
7560         (forget_cached_source_info_for_objfile): Remove declaration.
7561         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7562         declaration.
7563         * maint.c (count_symtabs_and_blocks): Remove declaration.
7564         * cp-support.c (add_symbol_overload_list_qualified): Remove
7565         declaration.
7566         * coffread.c (coff_symtab_read): Remove declaration.
7567         * symtab.c (lookup_symbol_in_objfile_symtabs)
7568         (basic_lookup_transparent_type_1): Use objfile_compunits.
7569         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7570         (info_sources_command, search_symbols)
7571         (default_collect_symbol_completion_matches_break_on)
7572         (make_source_files_completion_list): Remove declaration.
7573         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7574         (ada_collect_symbol_completion_matches)
7575         (ada_add_global_exceptions): Remove declaration.
7576         * linespec.c (iterate_over_all_matching_symtabs): Use
7577         objfile_compunits.
7578         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7579         (class objfile_compunits): New.
7580         (ALL_COMPUNITS): Use objfile_compunits.
7581         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7582         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7583         objfile_compunits.
7584         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7585
7586 2019-01-09  Tom Tromey  <tom@tromey.com>
7587
7588         * symtab.c (search_symbols)
7589         (default_collect_symbol_completion_matches_break_on): Use
7590         objfile_msymbols.
7591         * ada-lang.c (ada_lookup_simple_minsym)
7592         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7593         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7594         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7595         objfile_msymbols.
7596         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7597         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7598         * objc-lang.c (find_methods): Use objfile_msymbols.
7599         (info_selectors_command, info_classes_command): Likewise.
7600         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7601         * objfiles.h (class objfile_msymbols): New.
7602         (ALL_OBJFILE_MSYMBOLS): Remove.
7603         (ALL_MSYMBOLS): Remove.
7604
7605 2019-01-09  Tom Tromey  <tom@tromey.com>
7606
7607         * common/next-iterator.h (next_adapter): Add Iterator template
7608         parameter.
7609         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7610         (class all_objfiles_safe): New.
7611         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7612         * objfiles.c (put_objfile_before): Update comment.
7613         (add_separate_debug_objfile): Likewise.
7614         (free_all_objfiles): Use all_objfiles_safe.
7615         (objfile_purge_solibs): Likewise.
7616
7617 2019-01-09  Tom Tromey  <tom@tromey.com>
7618
7619         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7620         (expand_symtab_containing_pc, lookup_static_symbol)
7621         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7622         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7623         all_objfiles.
7624         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7625         * breakpoint.c (create_overlay_event_breakpoint)
7626         (create_longjmp_master_breakpoint)
7627         (create_std_terminate_master_breakpoint)
7628         (create_exception_master_breakpoint): Use all_objfiles.
7629         * linux-thread-db.c (try_thread_db_load_from_pdir)
7630         (has_libpthread): Use all_objfiles.
7631         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7632         * linespec.c (iterate_over_all_matching_symtabs)
7633         (search_minsyms_for_name): Use all_objfiles.
7634         * maint.c (maintenance_info_sections): Use all_objfiles.
7635         * main.c (captured_main_1): Use all_objfiles.
7636         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7637         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7638         * guile/scm-pretty-print.c
7639         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7640         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7641         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7642         (maintenance_print_msymbols): Use all_objfiles.
7643         * source.c (select_source_symtab): Use all_objfiles.
7644         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7645         * symfile.c (remove_symbol_file_command)
7646         (expand_symtabs_matching, map_symbol_filenames): Use
7647         all_objfiles.
7648         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7649         all_objfiles.
7650         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7651         * objc-lang.c (find_methods): Use all_objfiles.
7652         * objfiles.c (have_partial_symbols, have_full_symbols)
7653         (have_minimal_symbols, qsort_cmp)
7654         (default_iterate_over_objfiles_in_search_order): Use
7655         all_objfiles.
7656         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7657         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7658         (maintenance_check_psymtabs): Use all_objfiles.
7659         (ALL_PSYMTABS): Remove.
7660         * compile/compile-object-run.c (do_module_cleanup): Use
7661         all_objfiles.
7662         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7663         * cp-support.c (add_symbol_overload_list_qualified): Use
7664         all_objfiles.
7665         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7666         Use all_objfiles.
7667         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7668         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7669         all_objfiles.
7670         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7671         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7672         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7673         Uses all_objfiles.
7674         * solib.c (solib_read_symbols): Use all_objfiles
7675
7676 2019-01-09  Tom Tromey  <tom@tromey.com>
7677
7678         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7679         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7680         all_objfiles.
7681         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7682         * symmisc.c (print_symbol_bcache_statistics)
7683         (print_objfile_statistics, maintenance_print_objfiles)
7684         (maintenance_info_symtabs, maintenance_check_symtabs)
7685         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7686         all_objfiles.
7687         * source.c (forget_cached_source_info): Use all_objfiles.
7688         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7689         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7690         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7691         * objfiles.c (update_section_map): Use all_objfiles.
7692         (shared_objfile_contains_address_p): Likewise.
7693         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7694         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7695
7696 2019-01-09  Tom Tromey  <tom@tromey.com>
7697
7698         * common/next-iterator.h: New file.
7699         * objfiles.h (class all_objfiles): New.
7700         (struct objfile_iterator): New.
7701
7702 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7703
7704         * NEWS: Move the description of the changed "frame", "select-frame",
7705          and "info frame" commands to the Changed commands section.
7706
7707 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7708
7709         * gdbtypes.c (check_stub_method_group): Remove handling of old
7710         mangling schemes.
7711         * linespec.c (find_methods): Likewise.
7712         * stabsread.c (read_member_functions): Likewise.
7713         * valops.c (search_struct_method): Likewise.
7714         (value_struct_elt_for_reference): Likewise.
7715         * NEWS: Mention this change.
7716
7717 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7718
7719         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7720         print_source_lines.
7721         * source.c (print_source_lines_base): Update line number check.
7722         (print_source_lines): New function.
7723         (source_lines_range::source_lines_range): New function.
7724         * source.h (class source_lines_range): New class.
7725         (print_source_lines): New declaration.
7726
7727 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7728
7729         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7730
7731 2019-01-08  Tom Tromey  <tom@tromey.com>
7732             Simon Marchi  <simon.marchi@ericsson.com>
7733
7734         PR gdb/24060
7735         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7736         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7737         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7738         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7739         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7740         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7741
7742 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7743
7744         * source.c (select_source_symtab): Move header comment to
7745         declaration in source.h.
7746         (forget_cached_source_info_for_objfile): Likewise.
7747         (forget_cached_source_info): Likewise.
7748         (identify_source_line): Likewise.
7749         * source.h (identify_source_line): Move declaration from symtab.h
7750         and add comment from source.c
7751         (print_source_lines): Likewise.
7752         (forget_cached_source_info_for_objfile): Likewise.
7753         (forget_cached_source_info): Likewise.
7754         (select_source_symtab): Likewise.
7755         (enum print_source_lines_flag): Move definition from symtab.h.
7756         * symtab.h (identify_source_line): Move declaration to source.h.
7757         (print_source_lines): Likewise.
7758         (forget_cached_source_info_for_objfile): Likewise.
7759         (forget_cached_source_info): Likewise.
7760         (select_source_symtab): Likewise.
7761         (enum print_source_lines_flag): Move definition to source.h.
7762         * tui/tui-hooks.c: Add 'source.h' include.
7763
7764 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7765
7766         * source.c (print_source_lines_base): Handle requests to print
7767         reverse line number sequences, and guard against empty lines
7768         string.
7769
7770 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7771
7772         * source.c (print_source_lines_base): Fix skip of '\r' if next
7773         character is '\n'.
7774
7775 2019-01-06  Tom Tromey  <tom@tromey.com>
7776
7777         * c-exp.y (struct c_parse_state) <macro_original_text,
7778         expansion_obstack>: New member.
7779         (macro_original_text, expansion_obstack): Remove globals.
7780         (scan_macro_expansion, scanning_macro_expansion)
7781         (finished_macro_expansion): Update.
7782         (scan_macro_cleanup): Remove.
7783         (yylex, c_parse): Update.
7784
7785 2019-01-06  Tom Tromey  <tom@tromey.com>
7786
7787         * c-exp.y (struct c_parse_state) <strings>: New member.
7788         (operator_stoken): Update.
7789
7790 2019-01-06  Tom Tromey  <tom@tromey.com>
7791
7792         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7793         (union type_stack_elt) <typelist_val>: Now a pointer to
7794         std::vector.
7795         (type_stack_cleanup): Don't declare.
7796         (push_typelist): Update.
7797         * parse.c (pop_typelist): Return a std::vector.
7798         (push_typelist): Take a std::vector.
7799         (follow_types): Update.  Do not free args.
7800         (type_stack_cleanup): Remove.
7801         * c-exp.y (struct c_parse_state): New.
7802         (cpstate): New global.
7803         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7804         (nonempty_typelist): Update.
7805         (func_mod): Create a new vector.
7806         (c_parse): Create a c_parse_state.
7807         (check_parameter_typelist): Do not delete params.
7808         (function_method): Update.  Do not delete type_list.
7809
7810 2019-01-06  Tom Tromey  <tom@tromey.com>
7811
7812         PR gdb/28155:
7813         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7814         check_typedef.
7815         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7816         (print_return_value): Likewise.
7817
7818 2019-01-05  Tom Tromey  <tom@tromey.com>
7819
7820         * contrib/cleanup_check.py: Remove.
7821         * contrib/gcc-with-excheck: Remove.
7822         * contrib/exsummary.py: Remove.
7823         * contrib/excheck.py: Remove.
7824
7825 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7826
7827         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7828         NULL. Initialize tpprev to NULL instead of assigning it
7829         to NULL on the next statement.
7830         * windows-nat.c (windows_delete_thread): Remove check for
7831         main_thread_id before printing thread exit notifications.
7832         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7833         Remove thread ID check against main_thread_id.
7834         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7835         windows_delete_thread.
7836         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7837
7838 2019-01-04  Tom Tromey  <tom@tromey.com>
7839
7840         * compile/compile.c (_initialize_compile): Use upper case for
7841         metasyntactic variables.
7842         * symmisc.c (_initialize_symmisc): Use upper case for
7843         metasyntactic variables.
7844         * psymtab.c (_initialize_psymtab): Use upper case for
7845         metasyntactic variables.
7846         * demangle.c (demangle_command): Use upper case for metasyntactic
7847         variables.
7848         (_initialize_demangler): Likewise.
7849         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7850         variables.
7851
7852 2019-01-03  Tom Tromey  <tom@tromey.com>
7853
7854         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7855
7856 2019-01-03  Tom Tromey  <tom@tromey.com>
7857
7858         * python/py-symtab.c (salpy_str): Update.
7859         (struct salpy_sal_object) <symtab>: Now a PyObject.
7860         (salpy_dealloc): Update.
7861         (del_objfile_sal): Use gdbpy_ref.
7862
7863 2019-01-03  Tom Tromey  <tom@tromey.com>
7864
7865         * python/py-type.c (convert_field): Use new_reference.  Return
7866         gdbpy_ref.
7867         (make_fielditem): Return gdbpy_ref.
7868         (typy_fields): Update.
7869         (typy_getitem): Update.
7870         (field_name): Return gdbpy_ref.  Use new_reference.
7871         (typy_iterator_iternext): Update.
7872
7873 2019-01-03  Tom Tromey  <tom@tromey.com>
7874
7875         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7876
7877 2019-01-03  Tom Tromey  <tom@tromey.com>
7878
7879         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7880         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7881         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7882         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7883         (pspy_set_type_printers): Likewise.
7884         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7885         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7886         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7887         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7888         (objfpy_set_type_printers): Likewise.
7889
7890 2019-01-03  Tom Tromey  <tom@tromey.com>
7891
7892         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7893         (gdbpy_print_stack): Use gdbpy_err_fetch.
7894         * python/python-internal.h (class gdbpy_err_fetch): New class.
7895         (class gdbpy_enter) <m_error_type, m_error_value,
7896         m_error_traceback>: Remove.
7897         <m_error>: New member.
7898         (gdbpy_exception_to_string): Don't declare.
7899         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7900         * python/py-value.c (convert_value_from_python): Use
7901         gdbpy_err_fetch.
7902         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7903         gdbpy_exception_to_string.
7904         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7905         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7906         gdbpy_err_fetch.
7907
7908 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7909
7910         * linux-nat.c (delete_lwp_cleanup): Delete.
7911         (struct lwp_deleter): New struct.
7912         (lwp_info_up): New typedef.
7913         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7914         lwp_info_up.
7915
7916 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7917
7918         * linux-fork.c (class scoped_switch_fork_info): New class.
7919         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7920
7921 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7922
7923         * valops.c (find_overload_match): Remove use of null_cleanup, and
7924         calls to do_cleanups.
7925
7926 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7927
7928         * compile/compile-cplus-types.c
7929         (compile_cplus_instance::decl_name): Handle changes to
7930         cp_func_name.
7931         * cp-support.c (cp_func_name): Update header comment, update
7932         return type.
7933         * cp-support.h (cp_func_name): Update return type in declaration.
7934         * valops.c (find_overload_match): Move temp_func local to top
7935         level of function and change its type.  Use temp_func to hold and
7936         delete temporary string obtained from cp_func_name.
7937
7938 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7939
7940         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7941         gdb::char_vector, remove cleanup, and update uses of `msg`.
7942
7943 2019-01-03  Jim Wilson  <jimw@sifive.com>
7944
7945         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7946
7947 2019-01-02  Tom Tromey  <tom@tromey.com>
7948
7949         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7950         (tdesc_parse_xml): Remove cleanups.
7951         * target-descriptions.h (make_cleanup_free_target_description):
7952         Don't declare.
7953         (target_desc_deleter): New struct.
7954         (target_desc_up): New typedef.
7955         * target-descriptions.c (target_desc_deleter::operator()): Rename
7956         from free_target_description.
7957         (make_cleanup_free_target_description): Remove.
7958
7959 2019-01-02  Tom Tromey  <tom@tromey.com>
7960
7961         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7962         constructor, destructor.
7963         (linespec_parser): Remove typedef.
7964         (~linespec_parser): Rename from linespec_parser_delete.
7965         (linespec_lex_to_end, linespec_complete_label)
7966         (linespec_complete): Update.
7967         (decode_line_full): Remove cleanups.
7968         (decode_line_1): Update.
7969
7970 2019-01-02  Tom Tromey  <tom@tromey.com>
7971
7972         * python/python-internal.h (inferior_to_inferior_object): Change
7973         return type.
7974         * python/py-exitedevent.c (create_exited_event_object): Update.
7975         * python/py-inferior.c (inferior_to_inferior_object): Return
7976         gdbpy_ref.
7977         (python_new_inferior, python_inferior_deleted)
7978         (thread_to_thread_object, delete_thread_object)
7979         (build_inferior_list, gdbpy_selected_inferior): Update.
7980         * python/py-infthread.c (create_thread_object): Update.  Also fail
7981         if inferior_to_inferior_object fails.
7982
7983 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7984
7985         * inferior.h (class inferior) <displaced_step_state>: New field.
7986         * infrun.h (struct displaced_step_state): Move here from
7987         infrun.c.  Initialize fields, add constructor.
7988         <inf>: Remove field.
7989         <reset>: New method.
7990         * infrun.c (struct displaced_step_inferior_state): Move to
7991         infrun.h.
7992         (displaced_step_inferior_states): Remove.
7993         (get_displaced_stepping_state): Adust.
7994         (displaced_step_in_progress_any_inferior): Adjust.
7995         (displaced_step_in_progress_thread): Adjust.
7996         (displaced_step_in_progress): Adjust.
7997         (add_displaced_stepping_state): Remove.
7998         (get_displaced_step_closure_by_addr): Adjust.
7999         (remove_displaced_stepping_state): Remove.
8000         (infrun_inferior_exit): Call displaced_step_state.reset.
8001         (use_displaced_stepping): Don't check for NULL.
8002         (displaced_step_prepare_throw): Call
8003         get_displaced_stepping_state.
8004         (displaced_step_fixup): Don't check for NULL.
8005         (prepare_for_detach): Don't check for NULL.
8006
8007 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8008
8009         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8010          in case of call that did not complete.
8011
8012 2019-01-02  Andrey Utkin  <autkin@undo.io>
8013
8014         * symfile.c (find_separate_debug_file): Fix search of debug files for
8015         remote debuggee.
8016
8017 2019-01-02  Tom Tromey  <tom@tromey.com>
8018
8019         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8020         indentation.
8021         * python/py-frame.c (frapy_older): Remove cast.
8022         (frapy_newer): Likewise.
8023         * python/py-breakpoint.c (local_setattro): Remove cast.
8024         * python/py-arch.c (archpy_name): Remove local variable.
8025         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8026
8027 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8028
8029         * unittests/basic_string_view/element_access/char/empty.cc:
8030         Fix year range in copyright header.
8031
8032 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8033
8034         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8035         Delete.
8036         <operator==>: Update with for removed field.
8037         <hash>: Likewise.
8038         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8039         <isa_features>: ...this.
8040         <abi_features>: New field.
8041         (riscv_isa_flen): Update comment.
8042         (riscv_abi_xlen): New declaration.
8043         (riscv_abi_flen): New declaration.
8044         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8045         isa_features.
8046         (riscv_abi_xlen): New function.
8047         (riscv_isa_flen): Update to get answer from isa_features.
8048         (riscv_abi_flen): New function.
8049         (riscv_has_fp_abi): Update to get answer from abi_features.
8050         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8051         xlen and flen.
8052         (riscv_call_info) <xlen, flen>: Update comment.
8053         (riscv_call_arg_struct): Remove invalid assertions
8054         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8055         is removed.
8056         (riscv_gdbarch_init): Gather isa features and abi features
8057         separately, ensure both match on the gdbarch when reusing an old
8058         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8059         a target with 64-bit float hardware.
8060
8061 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8062
8063         * source.c (search_command_helper): Stop reverse search
8064         when line 1 has been searched.
8065
8066 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8067
8068         * record-full.c (record_full_base_target::close): Rewrite
8069         record_full_core_buf_list free logic.
8070
8071 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8072
8073         * break-catch-syscall.c (print_one_catch_syscall): xfree
8074         the last text.
8075
8076 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8077
8078         * top.c (print_gdb_version): Update Copyright year in version
8079         message.
8080
8081 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8082
8083         Update copyright year range in all GDB files.
8084
8085 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8086
8087         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8088
8089 For older changes see ChangeLog-2018.
8090 \f
8091 Local Variables:
8092 mode: change-log
8093 left-margin: 8
8094 fill-column: 74
8095 version-control: never
8096 coding: utf-8
8097 End:
8098