gdb/ChangeLog

   1 2019-01-15  Tom Tromey  <tom@tromey.com>
   2
   3         * symtab.c (lookup_objfile_from_block)
   4         (lookup_symbol_in_objfile_symtabs)
   5         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
   6         (find_line_symtab, info_sources_command)
   7         (default_collect_symbol_completion_matches_break_on)
   8         (make_source_files_completion_list): Update.
   9         * symmisc.c (print_objfile_statistics, dump_objfile)
  10         (maintenance_print_symbols, maintenance_info_symtabs)
  11         (maintenance_check_symtabs, maintenance_info_line_tables):
  12         Update.
  13         * source.c (select_source_symtab)
  14         (forget_cached_source_info_for_objfile): Update.
  15         * objfiles.h (class objfile_compunits): Remove.
  16         (struct objfile) <compunits_range>: New typedef.
  17         (compunits): New method.
  18         * objfiles.c (objfile_relocate1): Update.
  19         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
  20         * maint.c (count_symtabs_and_blocks): Update.
  21         * linespec.c (iterate_over_all_matching_symtabs): Update.
  22         * cp-support.c (add_symbol_overload_list_qualified): Update.
  23         * coffread.c (coff_symtab_read): Update.
  24         * ada-lang.c (add_nonlocal_symbols)
  25         (ada_collect_symbol_completion_matches)
  26         (ada_add_global_exceptions): Update.
  27
  28 2019-01-15  Tom Tromey  <tom@tromey.com>
  29
  30         * progspace.h (program_space) <objfiles_safe_range>: New
  31         typedef.
  32         <objfiles_safe>: New method.
  33         * objfiles.h (class all_objfiles_safe): Remove.
  34         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
  35         * jit.c (jit_inferior_exit_hook): Update.
  36
  37 2019-01-17  Tom Tromey  <tom@tromey.com>
  38
  39         * progspace.h (program_space) <objfiles_range>: New typedef.
  40         <objfiles>: New method.
  41         <objfiles_head>: Rename from objfiles.
  42         (object_files): Update.
  43         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
  44         * guile/scm-pretty-print.c
  45         (ppscm_find_pretty_printer_from_objfiles): Update.
  46         * guile/scm-objfile.c (gdbscm_objfiles): Update.
  47         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
  48         Update.
  49         * python/py-progspace.c (pspy_get_objfiles): Update.
  50         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
  51         Update.
  52         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
  53         (objfpy_lookup_objfile_by_build_id): Update.
  54         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
  55         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
  56         Update.
  57         * symtab.c (iterate_over_symtabs, matching_obj_sections)
  58         (expand_symtab_containing_pc, lookup_objfile_from_block)
  59         (lookup_static_symbol, basic_lookup_transparent_type)
  60         (find_pc_sect_compunit_symtab, find_symbol_at_address)
  61         (find_line_symtab, info_sources_command)
  62         (default_collect_symbol_completion_matches_break_on)
  63         (make_source_files_completion_list, find_main_name): Update.
  64         * symmisc.c (print_symbol_bcache_statistics)
  65         (print_objfile_statistics, maintenance_print_symbols)
  66         (maintenance_print_msymbols, maintenance_print_objfiles)
  67         (maintenance_info_symtabs, maintenance_check_symtabs)
  68         (maintenance_expand_symtabs, maintenance_info_line_tables):
  69         Update.
  70         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
  71         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
  72         (map_overlay_command, unmap_overlay_command)
  73         (simple_overlay_update, expand_symtabs_matching)
  74         (map_symbol_filenames): Update.
  75         * symfile-debug.c (set_debug_symfile): Update.
  76         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
  77         Update.
  78         * source.c (select_source_symtab, forget_cached_source_info):
  79         Update.
  80         * solib.c (solib_read_symbols): Update.
  81         * solib-spu.c (append_ocl_sos): Update.
  82         * psymtab.c (maintenance_print_psymbols)
  83         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
  84         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
  85         * printcmd.c (info_symbol_command): Update.
  86         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
  87         Update.
  88         * objfiles.h (class all_objfiles): Remove.
  89         * objfiles.c (have_partial_symbols, have_full_symbols)
  90         (have_minimal_symbols, qsort_cmp, update_section_map)
  91         (shared_objfile_contains_address_p)
  92         (default_iterate_over_objfiles_in_search_order): Update.
  93         * objc-lang.c (info_selectors_command, info_classes_command)
  94         (find_methods): Update.
  95         * minsyms.c (find_solib_trampoline_target): Update.
  96         * maint.c (maintenance_info_sections)
  97         (maintenance_translate_address, count_symtabs_and_blocks):
  98         Update.
  99         * main.c (captured_main_1): Update.
 100         * linux-thread-db.c (try_thread_db_load_from_pdir)
 101         (has_libpthread): Update.
 102         * linespec.c (iterate_over_all_matching_symtabs)
 103         (search_minsyms_for_name): Update.
 104         * jit.c (jit_find_objf_with_entry_addr): Update.
 105         * hppa-tdep.c (find_unwind_entry)
 106         (hppa_lookup_stub_minimal_symbol): Update.
 107         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 108         Update.
 109         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 110         (elf_gnu_ifunc_resolve_by_got): Update.
 111         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 112         * dwarf-index-write.c (save_gdb_index_command): Update.
 113         * cp-support.c (add_symbol_overload_list_qualified): Update.
 114         * breakpoint.c (create_overlay_event_breakpoint)
 115         (create_longjmp_master_breakpoint)
 116         (create_std_terminate_master_breakpoint)
 117         (create_exception_master_breakpoint): Update.
 118         * blockframe.c (find_pc_partial_function): Update.
 119         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 120         (ada_collect_symbol_completion_matches)
 121         (ada_add_global_exceptions): Update.
 122
 123 2019-01-17  Tom Tromey  <tom@tromey.com>
 124
 125         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 126         declare VEC.
 127         (solib_target_parse_libraries): Change return type.
 128         (library_list_start_segment, library_list_start_section)
 129         (library_list_end_library, library_list_start_library); Update.
 130         (solib_target_free_library_list): Remove.
 131         (solib_target_parse_libraries): Remove cleanup.  Change return
 132         type.
 133         (solib_target_current_sos): Update.
 134
 135 2019-01-17  Tom Tromey  <tromey@bapiya>
 136
 137         * valprint.c: Replace "the the" with "the".
 138         * symtab.c: Replace "the the" with "the".
 139         * solib.c: Replace "the the" with "the".
 140         * solib-dsbt.c: Replace "the the" with "the".
 141         * linespec.c: Replace "the the" with "the".
 142         * dwarf2loc.h: Replace "the the" with "the".
 143         * amd64-windows-tdep.c: Replace "the the" with "the".
 144         * aarch64-tdep.c: Replace "the the" with "the".
 145
 146 2019-01-16  Keith Seitz  <keiths@redhat.com>
 147
 148         PR gdb/23773
 149         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 150         <builder>: Rename to ..
 151         <m_builder>: ... this and make private.
 152         (dwarf2_cu::get_builder): New method.  Change all users of
 153         `builder' to use this method.
 154         (dwarf2_start_symtab): Move to ...
 155         (dwarf2_cu::start_symtab): ... here.  Update all callers
 156         (setup_type_unit_groups): Move to ...
 157         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 158         callers.
 159         (dwarf2_cu::reset_builder): New method.
 160         (process_full_compunit, process_full_type_unit): Use
 161         dwarf2_cu::reset_builder.
 162         (follow_die_offset): Record the ancestor CU if it is different
 163         from the followed DIE's CU.
 164         (follow_die_sig_1): Likewise.
 165
 166 2019-01-15  Tom Tromey  <tom@tromey.com>
 167
 168         * remote.c (class remote_state) <buf>: Now a char_vector.
 169         <buf_size>: Remove.
 170         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 171         parameter.
 172         (remote_target::getpkt_or_notif_sane_1)
 173         (remote_target::getpkt_sane)
 174         (remote_target::getpkt_or_notif_sane): Likewise.
 175         (class remote_target) <putpkt>: New overload.
 176         (remote_target::read_frame): Change type of "buf_p".  Remove
 177         sizeof_p parameter.
 178         (packet_ok): New overload.
 179         (packet_check_result): New overload.
 180         Update all uses.
 181
 182 2019-01-14  Tom Tromey  <tom@tromey.com>
 183
 184         * remote-notif.c (handle_notification, remote_notif_ack)
 185         (remote_notif_parse): Make "buf" const.
 186         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 187         const.
 188         (remote_notif_parse, remote_notif_ack, handle_notification):
 189         Likewise.
 190         * remote.c (remote_notif_stop_parse): Make "buf" const.
 191         (remote_target::remote_parse_stop_reply): Make "buf" const.
 192         (remote_notif_stop_ack): Make "buf" const.
 193
 194 2019-01-14  Tom Tromey  <tom@tromey.com>
 195
 196         * remote.c (remote_console_output): Make parameter const.
 197
 198 2019-01-14  Tom Tromey  <tom@tromey.com>
 199
 200         * target-debug.h (target_debug_print_signals): Constify.
 201         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 202         * procfs.c (procfs_target::pass_signals): Update.
 203         * linux-nat.c (linux_nat_target::pass_signals): Update.
 204         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 205         * target-delegates.c: Rebuild.
 206         * remote.c (remote_target::program_signals): Update.
 207         (remote_target::pass_signals): Update.
 208         * target.c (target_pass_signals): Constify argument.
 209         (target_program_signals): Likewise.
 210         * target.h (struct target_ops) <pass_signals, program_signals>:
 211         Constify argument.
 212         (target_pass_signals, target_program_signals): Constify argument.
 213
 214 2019-01-14  Tom Tromey  <tom@tromey.com>
 215
 216         PR tui/28819:
 217         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 218
 219 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 220
 221         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 222         field.
 223         * rs6000-tdep.c: Include reggroups.h.
 224         (IS_V_ALIAS_PSEUDOREG): Define.
 225         (rs6000_register_name): Return names for the "vX" aliases.
 226         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 227         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 228         aliases.  Call default_register_reggroup_p for all other
 229         pseudo-registers.
 230         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 231         New functions.
 232         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 233         Handle "vX" aliases.
 234         (v_alias_pseudo_register_collect): New function.
 235         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 236         (rs6000_gdbarch_init): Initialize "vX" aliases as
 237         pseudo-registers.  Restore registration of
 238         rs6000_pseudo_register_reggroup_p with
 239         set_tdesc_pseudo_register_reggroup_p.
 240
 241 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 242
 243         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 244         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 245         set_gdbarch_num_pseudo_regs.
 246
 247 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 248
 249         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 250         Remove arg prefixname, add do_set and do_show.
 251         Add member functions set_list and show_list.
 252         * cli/cli-style.c (class cli_style_option): Update accordingly.
 253         (style_set_list): Move to file scope.
 254         (style_show_list): Likewise.
 255         (set_style): Call help_list.
 256         (show_style): Call cmd_show_list.
 257         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 258         Update to use the new macro.
 259
 260 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 261
 262         * ada-lang.c (_initialize_ada_language): Expand the help text
 263         for the "catch exception" command.
 264
 265 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 266
 267         * symtab.c (matching_obj_sections): Initialize obj,
 268         declare it closer to its usage.
 269
 270 2019-01-10  Tom Tromey  <tom@tromey.com>
 271
 272         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 273         (basic_inf_threads_range): Remove.
 274         (inf_threads_range, inf_non_exited_threads_range)
 275         (safe_inf_threads_range): Use next_adapter.
 276
 277 2019-01-10  Keith Seitz  <keiths@redhat.com>
 278
 279         PR gdb/23712
 280         PR symtab/23010
 281         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 282         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 283
 284 2019-01-10  Keith Seitz  <keiths@redhat.com>
 285
 286         PR gdb/23712
 287         PR symtab/23010
 288         * dictionary.c (pending_to_vector): Remove.
 289         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 290         Remove _1 suffix, replacing functions of the same name.  Update
 291         all callers.
 292         (dict_create_hashed, dict_create_hashed_expandable)
 293         (dict_create_linear, dict_create_linear_expandable, dict_free)
 294         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 295         Make functions static.
 296
 297 2019-01-10  Keith Seitz  <keiths@redhat.com>
 298
 299         PR gdb/23712
 300         PR symtab/23010
 301         * dictionary.h (struct dictionary): Replace declaration with
 302         multidictionary.
 303         (dict_create_hashed, dict_create_hashed_expandable)
 304         (dict_create_linear, dict_create_linear_expandable)
 305         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 306         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 307         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 308         taking multidictionary argument.
 309         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 310         * block.h (struct block) <dict>: Change to multidictionary
 311         and rename `multidict'.
 312         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 313         symmisc.c: Update all dictionary references to multidictionary.
 314
 315 2019-01-10  Keith Seitz  <keiths@redhat.com>
 316
 317         PR gdb/23712
 318         PR symtab/23010
 319         * dictionary.c: Include unordered_map.
 320         (pending_to_vector): New function.
 321         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 322         Rewrite the non-"_1" functions to take vector instead
 323         of linked list.
 324         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 325         "new" _1 versions of the same name.
 326         (multidictionary): Define.
 327         (std::hash<enum language): New definition.
 328         (collate_pending_symbols_by_language, mdict_create_hashed)
 329         (mdict_create_hashed_expandable, mdict_create_linear)
 330         (mdict_create_linear_expandable, mdict_free)
 331         (find_language_dictionary, create_new_language_dictionary)
 332         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 333         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 334         (mdict_size, mdict_empty): New functions.
 335         * dictionary.h (mdict_iterator): Define.
 336
 337 2019-01-10  Pedro Alves  <palves@redhat.com>
 338
 339         * breakpoint.c (read_uploaded_action)
 340         (create_tracepoint_from_upload): Adjust to use
 341         gdb::unique_xmalloc_ptr.
 342         * ctf.c (ctf_write_uploaded_tp):
 343         (SET_ARRAY_FIELD): Use emplace_back.
 344         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 345         * tracefile-tfile.c (tfile_write_uploaded_tp):
 346         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 347         gdb::unique_xmalloc_ptr.
 348         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 349         at_string, cond_string, cmd_strings>: Replace char pointers
 350         with gdb::unique_xmalloc_ptr.
 351
 352 2019-01-10  Pedro Alves  <palves@redhat.com>
 353
 354         * solib-target.c (library_list_start_library): Don't xstrdup name.
 355
 356 2019-01-10  Pedro Alves  <palves@redhat.com>
 357
 358         * mdebugread.c (parse_partial_symbols): Use
 359         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 360
 361 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 362
 363         * linux-fork.c (scoped_switch_fork_info)
 364         <~scoped_switch_fork_info>: Fix incorrect variable name.
 365
 366 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 367
 368         * linux-fork.c (scoped_switch_fork_info)
 369         <scoped_switch_fork_info>: Make explicit.
 370         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 371
 372 2019-01-10  Tom Tromey  <tom@tromey.com>
 373
 374         * objfiles.h (objfile::reset_psymtabs): Update.
 375         * objfiles.c (objfile::objfile): Update.
 376         * psymtab.h (psymtab_storage::obstack): Update.
 377         (psymtab_storage::m_obstack): Use gdb::optional.
 378         (class psymtab_storage): Update comment.  Remove objfile
 379         parameter.
 380         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 381
 382 2019-01-10  Tom Tromey  <tom@tromey.com>
 383
 384         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 385         <free_psymtabs>: Now private.
 386         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 387         (allocate_psymtab): Use new method.
 388
 389 2019-01-10  Tom Tromey  <tom@tromey.com>
 390
 391         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 392         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 393         * mdebugread.c (parse_partial_symbols): Use
 394         allocate_dependencies.
 395         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 396         allocate_dependencies.
 397         (process_psymtab_comp_unit_reader)
 398         (build_type_psymtab_dependencies): Likewise.
 399         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 400
 401 2019-01-10  Tom Tromey  <tom@tromey.com>
 402
 403         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 404         PSYMBOL_SET_LANGUAGE.
 405         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 406
 407 2019-01-10  Tom Tromey  <tom@tromey.com>
 408
 409         * psymtab.h (psymtab_storage::obstack): New method.
 410         <m_obstack>: Rename from obstack; now private.
 411         * psymtab.c (psymtab_storage): Update.
 412         * dwarf2read.c (create_addrmap_from_index)
 413         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 414         Update.
 415
 416 2019-01-10  Tom Tromey  <tom@tromey.com>
 417
 418         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 419         * objfiles.h (objfile::reset_psymtabs): New method.
 420
 421 2019-01-10  Tom Tromey  <tom@tromey.com>
 422
 423         * symmisc.c (print_symbol_bcache_statistics): Update.
 424         (print_objfile_statistics): Update.
 425         * symfile.c (reread_symbols): Update.
 426         * psymtab.h (class psymtab_storage): New.
 427         * psymtab.c (psymtab_storage): New constructor.
 428         (~psymtab_storage): New destructor.
 429         (require_partial_symbols): Update.
 430         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 431         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 432         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 433         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 434         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 435         (start_psymtab_common, end_psymtab_common)
 436         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 437         (allocate_psymtab): Update.
 438         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 439         Update.
 440         (dump_psymtab_addrmap, maintenance_print_psymbols)
 441         (maintenance_check_psymtabs): Update.
 442         (class objfile_psymtabs): Move to objfiles.h.
 443         * psympriv.h (discard_psymtab): Now inline.
 444         (psymtab_discarder::psymtab_discarder): Update.
 445         (psymtab_discarder::~psymtab_discarder): Update.
 446         (ALL_OBJFILE_PSYMTABS): Rewrite.
 447         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 448         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 449         Remove fields.
 450         <partial_symtabs>: New field.
 451         (class objfile_psymtabs): Move from psymtab.h.  Update.
 452         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 453         psymbol_cache.
 454         (objfile::~objfile): Don't destroy psymbol_cache.
 455         * mdebugread.c (parse_partial_symbols): Update.
 456         * dwarf2read.c (create_addrmap_from_index)
 457         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 458         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 459         (add_partial_subprogram, dwarf2_ranges_read): Update.
 460         * dwarf-index-write.c (write_address_map)
 461         (write_one_signatured_type, recursively_write_psymbols)
 462         (class debug_names, class debug_names, write_psymtabs_to_index):
 463         Update.
 464
 465 2019-01-10  Tom Tromey  <tom@tromey.com>
 466
 467         * symtab.h (SYMBOL_SET_NAMES): Update.
 468         (symbol_set_names): Update.
 469         (MSYMBOL_SET_NAMES): Update.
 470         * symtab.c (symbol_set_names): Change argument to be an
 471         objfile_per_bfd_storage.
 472         * psymtab.c (add_psymbol_to_bcache): Update.
 473         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 474
 475 2019-01-10  Tom Tromey  <tom@tromey.com>
 476
 477         * symtab.c (create_demangled_names_hash): Change argument to be an
 478         objfile_per_bfd_storage.
 479         (symbol_set_names): Update.
 480
 481 2019-01-10  Tom Tromey  <tom@tromey.com>
 482
 483         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 484         init_psymbol_list.
 485         * psymtab.c (init_psymbol_list): Do nothing if already called.
 486         * psympriv.h (init_psymbol_list): Add comment.
 487         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 488         init_psymbol_list.
 489         * dbxread.c (dbx_symfile_read): Unconditionally call
 490         init_psymbol_list.
 491
 492 2019-01-10  Tom Tromey  <tom@tromey.com>
 493
 494         * xcoffread.c (scan_xcoff_symtab): Update.
 495         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 496         "where".
 497         * mdebugread.c (parse_partial_symbols)
 498         (handle_psymbol_enumerators): Update.
 499         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 500         * dbxread.c (read_dbx_symtab): Update.
 501         * psympriv.h (psymbol_placement): New enum.
 502         (add_psymbol_to_list): Update.
 503
 504 2019-01-10  Tom Tromey  <tom@tromey.com>
 505
 506         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 507         static_psymbols parameters.
 508         (scan_xcoff_symtab): Update.
 509         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 510         static_psymbols parameters.
 511         * psympriv.h (start_psymtab_common): Update.
 512         * mdebugread.c (parse_partial_symbols): Update.
 513         * dwarf2read.c (create_partial_symtab): Update.
 514         * dbxread.c (read_dbx_symtab): Update.
 515         (start_psymtab): Remove global_psymbols and static_psymbols
 516         parameters.
 517
 518 2019-01-10  Tom Tromey  <tom@tromey.com>
 519
 520         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 521         * psymtab.c (allocate_psymtab): Add comment.
 522         * psympriv.h (allocate_psymtab): Add comment.
 523         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 524         initializations.
 525         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 526
 527 2019-01-10  Tom Tromey  <tom@tromey.com>
 528
 529         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 530         Don't declare.
 531         * mipsread.c: Include mdebugread.h.
 532         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 533         Declare.
 534         * elfread.c: Include mdebugread.h.
 535
 536 2019-01-09  Tom Tromey  <tom@tromey.com>
 537
 538         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 539         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 540         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 541         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 542         (psym_lookup_symbol, psym_find_last_source_symtab)
 543         (psym_forget_cached_source_info, psym_print_stats)
 544         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 545         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 546         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 547         (psym_find_compunit_symtab_by_address)
 548         (maintenance_print_psymbols, maintenance_info_psymtabs)
 549         (maintenance_check_psymtabs): Use ranged for.
 550         * psymtab.h (class objfile_psymtabs): New.
 551         (require_partial_symbols): Return objfile_psymtabs.
 552         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 553
 554 2019-01-09  Tom Tromey  <tom@tromey.com>
 555
 556         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 557         (find_pc_mapped_section, list_overlays_command)
 558         (map_overlay_command, unmap_overlay_command)
 559         (simple_overlay_update): Use all_objfiles.
 560         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 561         * printcmd.c (info_symbol_command): Use all_objfiles.
 562         * objfiles.h (ALL_OBJSECTIONS): Remove.
 563         * maint.c (maintenance_translate_address): Use all_objfiles.
 564         * gcore.c (gcore_create_callback): Use all_objfiles.
 565         (objfile_find_memory_regions): Likewise.
 566
 567 2019-01-09  Tom Tromey  <tom@tromey.com>
 568
 569         * symtab.c (find_line_symtab, info_sources_command)
 570         (make_source_files_completion_list): Use objfile_compunits.
 571         * source.c (select_source_symtab): Use objfile_compunits.
 572         * objfiles.h (struct objfile): Update comment.
 573         (ALL_OBJFILES): Remove.
 574         (ALL_FILETABS): Remove.
 575         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 576         objfile_compunits.
 577
 578 2019-01-09  Tom Tromey  <tom@tromey.com>
 579
 580         * symmisc.c (print_objfile_statistics, dump_objfile)
 581         (maintenance_print_symbols): Use compunit_filetabs.
 582         * source.c (forget_cached_source_info_for_objfile): Use
 583         compunit_filetabs.
 584         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 585         (ALL_FILETABS): Use compunit_filetabs.
 586         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 587         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 588
 589 2019-01-09  Tom Tromey  <tom@tromey.com>
 590
 591         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 592         (compunit_filetabs): New.
 593         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 594         compunit_filetabs.
 595         (info_sources_command, make_source_files_completion_list): Remove
 596         declaration.
 597         * symmisc.c (print_objfile_statistics, dump_objfile)
 598         (maintenance_print_symbols): Remove declaration.
 599         (maintenance_info_symtabs): Use compunit_filetabs.
 600         (maintenance_info_line_tables): Likewise.
 601         * source.c (select_source_symtab): Change local variable name.
 602         (forget_cached_source_info_for_objfile): Remove declaration.
 603         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 604         * objfiles.c (objfile_relocate1): Remove declaration.
 605         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 606         declaration.
 607         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 608         * coffread.c (coff_symtab_read): Remove declaration.
 609         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 610         compunit_filetabs.
 611
 612 2019-01-09  Tom Tromey  <tom@tromey.com>
 613
 614         * symtab.c (lookup_objfile_from_block)
 615         (find_pc_sect_compunit_symtab, search_symbols)
 616         (default_collect_symbol_completion_matches_break_on): Use
 617         objfile_compunits.
 618         * objfiles.h (ALL_COMPUNITS): Remove.
 619         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 620         * cp-support.c (add_symbol_overload_list_qualified): Use
 621         objfile_compunits.
 622         * ada-lang.c (ada_collect_symbol_completion_matches)
 623         (ada_add_global_exceptions): Use objfile_compunits.
 624
 625 2019-01-09  Tom Tromey  <tom@tromey.com>
 626
 627         * source.c (select_source_symtab)
 628         (forget_cached_source_info_for_objfile): Remove declaration.
 629         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 630         declaration.
 631         * maint.c (count_symtabs_and_blocks): Remove declaration.
 632         * cp-support.c (add_symbol_overload_list_qualified): Remove
 633         declaration.
 634         * coffread.c (coff_symtab_read): Remove declaration.
 635         * symtab.c (lookup_symbol_in_objfile_symtabs)
 636         (basic_lookup_transparent_type_1): Use objfile_compunits.
 637         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 638         (info_sources_command, search_symbols)
 639         (default_collect_symbol_completion_matches_break_on)
 640         (make_source_files_completion_list): Remove declaration.
 641         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 642         (ada_collect_symbol_completion_matches)
 643         (ada_add_global_exceptions): Remove declaration.
 644         * linespec.c (iterate_over_all_matching_symtabs): Use
 645         objfile_compunits.
 646         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 647         (class objfile_compunits): New.
 648         (ALL_COMPUNITS): Use objfile_compunits.
 649         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 650         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 651         objfile_compunits.
 652         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 653
 654 2019-01-09  Tom Tromey  <tom@tromey.com>
 655
 656         * symtab.c (search_symbols)
 657         (default_collect_symbol_completion_matches_break_on): Use
 658         objfile_msymbols.
 659         * ada-lang.c (ada_lookup_simple_minsym)
 660         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 661         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 662         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 663         objfile_msymbols.
 664         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 665         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 666         * objc-lang.c (find_methods): Use objfile_msymbols.
 667         (info_selectors_command, info_classes_command): Likewise.
 668         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 669         * objfiles.h (class objfile_msymbols): New.
 670         (ALL_OBJFILE_MSYMBOLS): Remove.
 671         (ALL_MSYMBOLS): Remove.
 672
 673 2019-01-09  Tom Tromey  <tom@tromey.com>
 674
 675         * common/next-iterator.h (next_adapter): Add Iterator template
 676         parameter.
 677         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 678         (class all_objfiles_safe): New.
 679         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 680         * objfiles.c (put_objfile_before): Update comment.
 681         (add_separate_debug_objfile): Likewise.
 682         (free_all_objfiles): Use all_objfiles_safe.
 683         (objfile_purge_solibs): Likewise.
 684
 685 2019-01-09  Tom Tromey  <tom@tromey.com>
 686
 687         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 688         (expand_symtab_containing_pc, lookup_static_symbol)
 689         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 690         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 691         all_objfiles.
 692         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 693         * breakpoint.c (create_overlay_event_breakpoint)
 694         (create_longjmp_master_breakpoint)
 695         (create_std_terminate_master_breakpoint)
 696         (create_exception_master_breakpoint): Use all_objfiles.
 697         * linux-thread-db.c (try_thread_db_load_from_pdir)
 698         (has_libpthread): Use all_objfiles.
 699         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 700         * linespec.c (iterate_over_all_matching_symtabs)
 701         (search_minsyms_for_name): Use all_objfiles.
 702         * maint.c (maintenance_info_sections): Use all_objfiles.
 703         * main.c (captured_main_1): Use all_objfiles.
 704         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 705         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 706         * guile/scm-pretty-print.c
 707         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 708         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 709         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 710         (maintenance_print_msymbols): Use all_objfiles.
 711         * source.c (select_source_symtab): Use all_objfiles.
 712         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 713         * symfile.c (remove_symbol_file_command)
 714         (expand_symtabs_matching, map_symbol_filenames): Use
 715         all_objfiles.
 716         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 717         all_objfiles.
 718         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 719         * objc-lang.c (find_methods): Use all_objfiles.
 720         * objfiles.c (have_partial_symbols, have_full_symbols)
 721         (have_minimal_symbols, qsort_cmp)
 722         (default_iterate_over_objfiles_in_search_order): Use
 723         all_objfiles.
 724         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 725         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 726         (maintenance_check_psymtabs): Use all_objfiles.
 727         (ALL_PSYMTABS): Remove.
 728         * compile/compile-object-run.c (do_module_cleanup): Use
 729         all_objfiles.
 730         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 731         * cp-support.c (add_symbol_overload_list_qualified): Use
 732         all_objfiles.
 733         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 734         Use all_objfiles.
 735         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 736         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 737         all_objfiles.
 738         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 739         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 740         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 741         Uses all_objfiles.
 742         * solib.c (solib_read_symbols): Use all_objfiles
 743
 744 2019-01-09  Tom Tromey  <tom@tromey.com>
 745
 746         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 747         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 748         all_objfiles.
 749         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 750         * symmisc.c (print_symbol_bcache_statistics)
 751         (print_objfile_statistics, maintenance_print_objfiles)
 752         (maintenance_info_symtabs, maintenance_check_symtabs)
 753         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 754         all_objfiles.
 755         * source.c (forget_cached_source_info): Use all_objfiles.
 756         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 757         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 758         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 759         * objfiles.c (update_section_map): Use all_objfiles.
 760         (shared_objfile_contains_address_p): Likewise.
 761         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 762         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 763
 764 2019-01-09  Tom Tromey  <tom@tromey.com>
 765
 766         * common/next-iterator.h: New file.
 767         * objfiles.h (class all_objfiles): New.
 768         (struct objfile_iterator): New.
 769
 770 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 771
 772         * NEWS: Move the description of the changed "frame", "select-frame",
 773          and "info frame" commands to the Changed commands section.
 774
 775 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 776
 777         * gdbtypes.c (check_stub_method_group): Remove handling of old
 778         mangling schemes.
 779         * linespec.c (find_methods): Likewise.
 780         * stabsread.c (read_member_functions): Likewise.
 781         * valops.c (search_struct_method): Likewise.
 782         (value_struct_elt_for_reference): Likewise.
 783         * NEWS: Mention this change.
 784
 785 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 786
 787         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 788         print_source_lines.
 789         * source.c (print_source_lines_base): Update line number check.
 790         (print_source_lines): New function.
 791         (source_lines_range::source_lines_range): New function.
 792         * source.h (class source_lines_range): New class.
 793         (print_source_lines): New declaration.
 794
 795 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 796
 797         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 798
 799 2019-01-08  Tom Tromey  <tom@tromey.com>
 800             Simon Marchi  <simon.marchi@ericsson.com>
 801
 802         PR gdb/24060
 803         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 804         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 805         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 806         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 807         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 808         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 809
 810 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 811
 812         * source.c (select_source_symtab): Move header comment to
 813         declaration in source.h.
 814         (forget_cached_source_info_for_objfile): Likewise.
 815         (forget_cached_source_info): Likewise.
 816         (identify_source_line): Likewise.
 817         * source.h (identify_source_line): Move declaration from symtab.h
 818         and add comment from source.c
 819         (print_source_lines): Likewise.
 820         (forget_cached_source_info_for_objfile): Likewise.
 821         (forget_cached_source_info): Likewise.
 822         (select_source_symtab): Likewise.
 823         (enum print_source_lines_flag): Move definition from symtab.h.
 824         * symtab.h (identify_source_line): Move declaration to source.h.
 825         (print_source_lines): Likewise.
 826         (forget_cached_source_info_for_objfile): Likewise.
 827         (forget_cached_source_info): Likewise.
 828         (select_source_symtab): Likewise.
 829         (enum print_source_lines_flag): Move definition to source.h.
 830         * tui/tui-hooks.c: Add 'source.h' include.
 831
 832 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 833
 834         * source.c (print_source_lines_base): Handle requests to print
 835         reverse line number sequences, and guard against empty lines
 836         string.
 837
 838 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 839
 840         * source.c (print_source_lines_base): Fix skip of '\r' if next
 841         character is '\n'.
 842
 843 2019-01-06  Tom Tromey  <tom@tromey.com>
 844
 845         * c-exp.y (struct c_parse_state) <macro_original_text,
 846         expansion_obstack>: New member.
 847         (macro_original_text, expansion_obstack): Remove globals.
 848         (scan_macro_expansion, scanning_macro_expansion)
 849         (finished_macro_expansion): Update.
 850         (scan_macro_cleanup): Remove.
 851         (yylex, c_parse): Update.
 852
 853 2019-01-06  Tom Tromey  <tom@tromey.com>
 854
 855         * c-exp.y (struct c_parse_state) <strings>: New member.
 856         (operator_stoken): Update.
 857
 858 2019-01-06  Tom Tromey  <tom@tromey.com>
 859
 860         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 861         (union type_stack_elt) <typelist_val>: Now a pointer to
 862         std::vector.
 863         (type_stack_cleanup): Don't declare.
 864         (push_typelist): Update.
 865         * parse.c (pop_typelist): Return a std::vector.
 866         (push_typelist): Take a std::vector.
 867         (follow_types): Update.  Do not free args.
 868         (type_stack_cleanup): Remove.
 869         * c-exp.y (struct c_parse_state): New.
 870         (cpstate): New global.
 871         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 872         (nonempty_typelist): Update.
 873         (func_mod): Create a new vector.
 874         (c_parse): Create a c_parse_state.
 875         (check_parameter_typelist): Do not delete params.
 876         (function_method): Update.  Do not delete type_list.
 877
 878 2019-01-06  Tom Tromey  <tom@tromey.com>
 879
 880         PR gdb/28155:
 881         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 882         check_typedef.
 883         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 884         (print_return_value): Likewise.
 885
 886 2019-01-05  Tom Tromey  <tom@tromey.com>
 887
 888         * contrib/cleanup_check.py: Remove.
 889         * contrib/gcc-with-excheck: Remove.
 890         * contrib/exsummary.py: Remove.
 891         * contrib/excheck.py: Remove.
 892
 893 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 894
 895         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 896         NULL. Initialize tpprev to NULL instead of assigning it
 897         to NULL on the next statement.
 898         * windows-nat.c (windows_delete_thread): Remove check for
 899         main_thread_id before printing thread exit notifications.
 900         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 901         Remove thread ID check against main_thread_id.
 902         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 903         windows_delete_thread.
 904         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 905
 906 2019-01-04  Tom Tromey  <tom@tromey.com>
 907
 908         * compile/compile.c (_initialize_compile): Use upper case for
 909         metasyntactic variables.
 910         * symmisc.c (_initialize_symmisc): Use upper case for
 911         metasyntactic variables.
 912         * psymtab.c (_initialize_psymtab): Use upper case for
 913         metasyntactic variables.
 914         * demangle.c (demangle_command): Use upper case for metasyntactic
 915         variables.
 916         (_initialize_demangler): Likewise.
 917         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 918         variables.
 919
 920 2019-01-03  Tom Tromey  <tom@tromey.com>
 921
 922         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
 923
 924 2019-01-03  Tom Tromey  <tom@tromey.com>
 925
 926         * python/py-symtab.c (salpy_str): Update.
 927         (struct salpy_sal_object) <symtab>: Now a PyObject.
 928         (salpy_dealloc): Update.
 929         (del_objfile_sal): Use gdbpy_ref.
 930
 931 2019-01-03  Tom Tromey  <tom@tromey.com>
 932
 933         * python/py-type.c (convert_field): Use new_reference.  Return
 934         gdbpy_ref.
 935         (make_fielditem): Return gdbpy_ref.
 936         (typy_fields): Update.
 937         (typy_getitem): Update.
 938         (field_name): Return gdbpy_ref.  Use new_reference.
 939         (typy_iterator_iternext): Update.
 940
 941 2019-01-03  Tom Tromey  <tom@tromey.com>
 942
 943         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
 944
 945 2019-01-03  Tom Tromey  <tom@tromey.com>
 946
 947         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
 948         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
 949         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
 950         (pspy_set_frame_filters, pspy_set_frame_unwinders)
 951         (pspy_set_type_printers): Likewise.
 952         * python/py-function.c (fnpy_init): Use gdbpy_ref.
 953         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
 954         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
 955         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
 956         (objfpy_set_type_printers): Likewise.
 957
 958 2019-01-03  Tom Tromey  <tom@tromey.com>
 959
 960         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
 961         (gdbpy_print_stack): Use gdbpy_err_fetch.
 962         * python/python-internal.h (class gdbpy_err_fetch): New class.
 963         (class gdbpy_enter) <m_error_type, m_error_value,
 964         m_error_traceback>: Remove.
 965         <m_error>: New member.
 966         (gdbpy_exception_to_string): Don't declare.
 967         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
 968         * python/py-value.c (convert_value_from_python): Use
 969         gdbpy_err_fetch.
 970         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
 971         gdbpy_exception_to_string.
 972         (gdbpy_handle_exception): Use gdbpy_err_fetch.
 973         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 974         gdbpy_err_fetch.
 975
 976 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 977
 978         * linux-nat.c (delete_lwp_cleanup): Delete.
 979         (struct lwp_deleter): New struct.
 980         (lwp_info_up): New typedef.
 981         (linux_nat_target::follow_fork): Delete cleanup, and make use of
 982         lwp_info_up.
 983
 984 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 985
 986         * linux-fork.c (class scoped_switch_fork_info): New class.
 987         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
 988
 989 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 990
 991         * valops.c (find_overload_match): Remove use of null_cleanup, and
 992         calls to do_cleanups.
 993
 994 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 995
 996         * compile/compile-cplus-types.c
 997         (compile_cplus_instance::decl_name): Handle changes to
 998         cp_func_name.
 999         * cp-support.c (cp_func_name): Update header comment, update
1000         return type.
1001         * cp-support.h (cp_func_name): Update return type in declaration.
1002         * valops.c (find_overload_match): Move temp_func local to top
1003         level of function and change its type.  Use temp_func to hold and
1004         delete temporary string obtained from cp_func_name.
1005
1006 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1007
1008         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1009         gdb::char_vector, remove cleanup, and update uses of `msg`.
1010
1011 2019-01-03  Jim Wilson  <jimw@sifive.com>
1012
1013         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1014
1015 2019-01-02  Tom Tromey  <tom@tromey.com>
1016
1017         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1018         (tdesc_parse_xml): Remove cleanups.
1019         * target-descriptions.h (make_cleanup_free_target_description):
1020         Don't declare.
1021         (target_desc_deleter): New struct.
1022         (target_desc_up): New typedef.
1023         * target-descriptions.c (target_desc_deleter::operator()): Rename
1024         from free_target_description.
1025         (make_cleanup_free_target_description): Remove.
1026
1027 2019-01-02  Tom Tromey  <tom@tromey.com>
1028
1029         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1030         constructor, destructor.
1031         (linespec_parser): Remove typedef.
1032         (~linespec_parser): Rename from linespec_parser_delete.
1033         (linespec_lex_to_end, linespec_complete_label)
1034         (linespec_complete): Update.
1035         (decode_line_full): Remove cleanups.
1036         (decode_line_1): Update.
1037
1038 2019-01-02  Tom Tromey  <tom@tromey.com>
1039
1040         * python/python-internal.h (inferior_to_inferior_object): Change
1041         return type.
1042         * python/py-exitedevent.c (create_exited_event_object): Update.
1043         * python/py-inferior.c (inferior_to_inferior_object): Return
1044         gdbpy_ref.
1045         (python_new_inferior, python_inferior_deleted)
1046         (thread_to_thread_object, delete_thread_object)
1047         (build_inferior_list, gdbpy_selected_inferior): Update.
1048         * python/py-infthread.c (create_thread_object): Update.  Also fail
1049         if inferior_to_inferior_object fails.
1050
1051 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1052
1053         * inferior.h (class inferior) <displaced_step_state>: New field.
1054         * infrun.h (struct displaced_step_state): Move here from
1055         infrun.c.  Initialize fields, add constructor.
1056         <inf>: Remove field.
1057         <reset>: New method.
1058         * infrun.c (struct displaced_step_inferior_state): Move to
1059         infrun.h.
1060         (displaced_step_inferior_states): Remove.
1061         (get_displaced_stepping_state): Adust.
1062         (displaced_step_in_progress_any_inferior): Adjust.
1063         (displaced_step_in_progress_thread): Adjust.
1064         (displaced_step_in_progress): Adjust.
1065         (add_displaced_stepping_state): Remove.
1066         (get_displaced_step_closure_by_addr): Adjust.
1067         (remove_displaced_stepping_state): Remove.
1068         (infrun_inferior_exit): Call displaced_step_state.reset.
1069         (use_displaced_stepping): Don't check for NULL.
1070         (displaced_step_prepare_throw): Call
1071         get_displaced_stepping_state.
1072         (displaced_step_fixup): Don't check for NULL.
1073         (prepare_for_detach): Don't check for NULL.
1074
1075 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1076
1077         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1078          in case of call that did not complete.
1079
1080 2019-01-02  Andrey Utkin  <autkin@undo.io>
1081
1082         * symfile.c (find_separate_debug_file): Fix search of debug files for
1083         remote debuggee.
1084
1085 2019-01-02  Tom Tromey  <tom@tromey.com>
1086
1087         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1088         indentation.
1089         * python/py-frame.c (frapy_older): Remove cast.
1090         (frapy_newer): Likewise.
1091         * python/py-breakpoint.c (local_setattro): Remove cast.
1092         * python/py-arch.c (archpy_name): Remove local variable.
1093         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1094
1095 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1096
1097         * unittests/basic_string_view/element_access/char/empty.cc:
1098         Fix year range in copyright header.
1099
1100 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1101
1102         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1103         Delete.
1104         <operator==>: Update with for removed field.
1105         <hash>: Likewise.
1106         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1107         <isa_features>: ...this.
1108         <abi_features>: New field.
1109         (riscv_isa_flen): Update comment.
1110         (riscv_abi_xlen): New declaration.
1111         (riscv_abi_flen): New declaration.
1112         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1113         isa_features.
1114         (riscv_abi_xlen): New function.
1115         (riscv_isa_flen): Update to get answer from isa_features.
1116         (riscv_abi_flen): New function.
1117         (riscv_has_fp_abi): Update to get answer from abi_features.
1118         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1119         xlen and flen.
1120         (riscv_call_info) <xlen, flen>: Update comment.
1121         (riscv_call_arg_struct): Remove invalid assertions
1122         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1123         is removed.
1124         (riscv_gdbarch_init): Gather isa features and abi features
1125         separately, ensure both match on the gdbarch when reusing an old
1126         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1127         a target with 64-bit float hardware.
1128
1129 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1130
1131         * source.c (search_command_helper): Stop reverse search
1132         when line 1 has been searched.
1133
1134 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1135
1136         * record-full.c (record_full_base_target::close): Rewrite
1137         record_full_core_buf_list free logic.
1138
1139 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1140
1141         * break-catch-syscall.c (print_one_catch_syscall): xfree
1142         the last text.
1143
1144 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1145
1146         * top.c (print_gdb_version): Update Copyright year in version
1147         message.
1148
1149 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1150
1151         Update copyright year range in all GDB files.
1152
1153 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1154
1155         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1156
1157 For older changes see ChangeLog-2018.
1158 \f
1159 Local Variables:
1160 mode: change-log
1161 left-margin: 8
1162 fill-column: 74
1163 version-control: never
1164 coding: utf-8
1165 End:
1166