gdb/ChangeLog

   1 2019-01-14  Tom Tromey  <tom@tromey.com>
   2
   3         PR tui/28819:
   4         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
   5
   6 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
   7
   8         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
   9         field.
  10         * rs6000-tdep.c: Include reggroups.h.
  11         (IS_V_ALIAS_PSEUDOREG): Define.
  12         (rs6000_register_name): Return names for the "vX" aliases.
  13         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
  14         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
  15         aliases.  Call default_register_reggroup_p for all other
  16         pseudo-registers.
  17         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
  18         New functions.
  19         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
  20         Handle "vX" aliases.
  21         (v_alias_pseudo_register_collect): New function.
  22         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
  23         (rs6000_gdbarch_init): Initialize "vX" aliases as
  24         pseudo-registers.  Restore registration of
  25         rs6000_pseudo_register_reggroup_p with
  26         set_tdesc_pseudo_register_reggroup_p.
  27
  28 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
  29
  30         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
  31         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
  32         set_gdbarch_num_pseudo_regs.
  33
  34 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  35
  36         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
  37         Remove arg prefixname, add do_set and do_show.
  38         Add member functions set_list and show_list.
  39         * cli/cli-style.c (class cli_style_option): Update accordingly.
  40         (style_set_list): Move to file scope.
  41         (style_show_list): Likewise.
  42         (set_style): Call help_list.
  43         (show_style): Call cmd_show_list.
  44         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
  45         Update to use the new macro.
  46
  47 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
  48
  49         * ada-lang.c (_initialize_ada_language): Expand the help text
  50         for the "catch exception" command.
  51
  52 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  53
  54         * symtab.c (matching_obj_sections): Initialize obj,
  55         declare it closer to its usage.
  56
  57 2019-01-10  Tom Tromey  <tom@tromey.com>
  58
  59         * thread-iter.h (inf_threads_iterator): Use next_iterator.
  60         (basic_inf_threads_range): Remove.
  61         (inf_threads_range, inf_non_exited_threads_range)
  62         (safe_inf_threads_range): Use next_adapter.
  63
  64 2019-01-10  Keith Seitz  <keiths@redhat.com>
  65
  66         PR gdb/23712
  67         PR symtab/23010
  68         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
  69         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
  70
  71 2019-01-10  Keith Seitz  <keiths@redhat.com>
  72
  73         PR gdb/23712
  74         PR symtab/23010
  75         * dictionary.c (pending_to_vector): Remove.
  76         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
  77         Remove _1 suffix, replacing functions of the same name.  Update
  78         all callers.
  79         (dict_create_hashed, dict_create_hashed_expandable)
  80         (dict_create_linear, dict_create_linear_expandable, dict_free)
  81         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
  82         Make functions static.
  83
  84 2019-01-10  Keith Seitz  <keiths@redhat.com>
  85
  86         PR gdb/23712
  87         PR symtab/23010
  88         * dictionary.h (struct dictionary): Replace declaration with
  89         multidictionary.
  90         (dict_create_hashed, dict_create_hashed_expandable)
  91         (dict_create_linear, dict_create_linear_expandable)
  92         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
  93         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
  94         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
  95         taking multidictionary argument.
  96         [ALL_DICT_SYMBOLS]: Update for multidictionary.
  97         * block.h (struct block) <dict>: Change to multidictionary
  98         and rename `multidict'.
  99         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 100         symmisc.c: Update all dictionary references to multidictionary.
 101
 102 2019-01-10  Keith Seitz  <keiths@redhat.com>
 103
 104         PR gdb/23712
 105         PR symtab/23010
 106         * dictionary.c: Include unordered_map.
 107         (pending_to_vector): New function.
 108         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 109         Rewrite the non-"_1" functions to take vector instead
 110         of linked list.
 111         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 112         "new" _1 versions of the same name.
 113         (multidictionary): Define.
 114         (std::hash<enum language): New definition.
 115         (collate_pending_symbols_by_language, mdict_create_hashed)
 116         (mdict_create_hashed_expandable, mdict_create_linear)
 117         (mdict_create_linear_expandable, mdict_free)
 118         (find_language_dictionary, create_new_language_dictionary)
 119         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 120         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 121         (mdict_size, mdict_empty): New functions.
 122         * dictionary.h (mdict_iterator): Define.
 123
 124 2019-01-10  Pedro Alves  <palves@redhat.com>
 125
 126         * breakpoint.c (read_uploaded_action)
 127         (create_tracepoint_from_upload): Adjust to use
 128         gdb::unique_xmalloc_ptr.
 129         * ctf.c (ctf_write_uploaded_tp):
 130         (SET_ARRAY_FIELD): Use emplace_back.
 131         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 132         * tracefile-tfile.c (tfile_write_uploaded_tp):
 133         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 134         gdb::unique_xmalloc_ptr.
 135         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 136         at_string, cond_string, cmd_strings>: Replace char pointers
 137         with gdb::unique_xmalloc_ptr.
 138
 139 2019-01-10  Pedro Alves  <palves@redhat.com>
 140
 141         * solib-target.c (library_list_start_library): Don't xstrdup name.
 142
 143 2019-01-10  Pedro Alves  <palves@redhat.com>
 144
 145         * mdebugread.c (parse_partial_symbols): Use
 146         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 147
 148 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 149
 150         * linux-fork.c (scoped_switch_fork_info)
 151         <~scoped_switch_fork_info>: Fix incorrect variable name.
 152
 153 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 154
 155         * linux-fork.c (scoped_switch_fork_info)
 156         <scoped_switch_fork_info>: Make explicit.
 157         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 158
 159 2019-01-10  Tom Tromey  <tom@tromey.com>
 160
 161         * objfiles.h (objfile::reset_psymtabs): Update.
 162         * objfiles.c (objfile::objfile): Update.
 163         * psymtab.h (psymtab_storage::obstack): Update.
 164         (psymtab_storage::m_obstack): Use gdb::optional.
 165         (class psymtab_storage): Update comment.  Remove objfile
 166         parameter.
 167         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 168
 169 2019-01-10  Tom Tromey  <tom@tromey.com>
 170
 171         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 172         <free_psymtabs>: Now private.
 173         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 174         (allocate_psymtab): Use new method.
 175
 176 2019-01-10  Tom Tromey  <tom@tromey.com>
 177
 178         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 179         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 180         * mdebugread.c (parse_partial_symbols): Use
 181         allocate_dependencies.
 182         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 183         allocate_dependencies.
 184         (process_psymtab_comp_unit_reader)
 185         (build_type_psymtab_dependencies): Likewise.
 186         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 187
 188 2019-01-10  Tom Tromey  <tom@tromey.com>
 189
 190         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 191         PSYMBOL_SET_LANGUAGE.
 192         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 193
 194 2019-01-10  Tom Tromey  <tom@tromey.com>
 195
 196         * psymtab.h (psymtab_storage::obstack): New method.
 197         <m_obstack>: Rename from obstack; now private.
 198         * psymtab.c (psymtab_storage): Update.
 199         * dwarf2read.c (create_addrmap_from_index)
 200         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 201         Update.
 202
 203 2019-01-10  Tom Tromey  <tom@tromey.com>
 204
 205         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 206         * objfiles.h (objfile::reset_psymtabs): New method.
 207
 208 2019-01-10  Tom Tromey  <tom@tromey.com>
 209
 210         * symmisc.c (print_symbol_bcache_statistics): Update.
 211         (print_objfile_statistics): Update.
 212         * symfile.c (reread_symbols): Update.
 213         * psymtab.h (class psymtab_storage): New.
 214         * psymtab.c (psymtab_storage): New constructor.
 215         (~psymtab_storage): New destructor.
 216         (require_partial_symbols): Update.
 217         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 218         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 219         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 220         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 221         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 222         (start_psymtab_common, end_psymtab_common)
 223         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 224         (allocate_psymtab): Update.
 225         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 226         Update.
 227         (dump_psymtab_addrmap, maintenance_print_psymbols)
 228         (maintenance_check_psymtabs): Update.
 229         (class objfile_psymtabs): Move to objfiles.h.
 230         * psympriv.h (discard_psymtab): Now inline.
 231         (psymtab_discarder::psymtab_discarder): Update.
 232         (psymtab_discarder::~psymtab_discarder): Update.
 233         (ALL_OBJFILE_PSYMTABS): Rewrite.
 234         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 235         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 236         Remove fields.
 237         <partial_symtabs>: New field.
 238         (class objfile_psymtabs): Move from psymtab.h.  Update.
 239         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 240         psymbol_cache.
 241         (objfile::~objfile): Don't destroy psymbol_cache.
 242         * mdebugread.c (parse_partial_symbols): Update.
 243         * dwarf2read.c (create_addrmap_from_index)
 244         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 245         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 246         (add_partial_subprogram, dwarf2_ranges_read): Update.
 247         * dwarf-index-write.c (write_address_map)
 248         (write_one_signatured_type, recursively_write_psymbols)
 249         (class debug_names, class debug_names, write_psymtabs_to_index):
 250         Update.
 251
 252 2019-01-10  Tom Tromey  <tom@tromey.com>
 253
 254         * symtab.h (SYMBOL_SET_NAMES): Update.
 255         (symbol_set_names): Update.
 256         (MSYMBOL_SET_NAMES): Update.
 257         * symtab.c (symbol_set_names): Change argument to be an
 258         objfile_per_bfd_storage.
 259         * psymtab.c (add_psymbol_to_bcache): Update.
 260         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 261
 262 2019-01-10  Tom Tromey  <tom@tromey.com>
 263
 264         * symtab.c (create_demangled_names_hash): Change argument to be an
 265         objfile_per_bfd_storage.
 266         (symbol_set_names): Update.
 267
 268 2019-01-10  Tom Tromey  <tom@tromey.com>
 269
 270         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 271         init_psymbol_list.
 272         * psymtab.c (init_psymbol_list): Do nothing if already called.
 273         * psympriv.h (init_psymbol_list): Add comment.
 274         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 275         init_psymbol_list.
 276         * dbxread.c (dbx_symfile_read): Unconditionally call
 277         init_psymbol_list.
 278
 279 2019-01-10  Tom Tromey  <tom@tromey.com>
 280
 281         * xcoffread.c (scan_xcoff_symtab): Update.
 282         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 283         "where".
 284         * mdebugread.c (parse_partial_symbols)
 285         (handle_psymbol_enumerators): Update.
 286         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 287         * dbxread.c (read_dbx_symtab): Update.
 288         * psympriv.h (psymbol_placement): New enum.
 289         (add_psymbol_to_list): Update.
 290
 291 2019-01-10  Tom Tromey  <tom@tromey.com>
 292
 293         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 294         static_psymbols parameters.
 295         (scan_xcoff_symtab): Update.
 296         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 297         static_psymbols parameters.
 298         * psympriv.h (start_psymtab_common): Update.
 299         * mdebugread.c (parse_partial_symbols): Update.
 300         * dwarf2read.c (create_partial_symtab): Update.
 301         * dbxread.c (read_dbx_symtab): Update.
 302         (start_psymtab): Remove global_psymbols and static_psymbols
 303         parameters.
 304
 305 2019-01-10  Tom Tromey  <tom@tromey.com>
 306
 307         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 308         * psymtab.c (allocate_psymtab): Add comment.
 309         * psympriv.h (allocate_psymtab): Add comment.
 310         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 311         initializations.
 312         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 313
 314 2019-01-10  Tom Tromey  <tom@tromey.com>
 315
 316         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 317         Don't declare.
 318         * mipsread.c: Include mdebugread.h.
 319         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 320         Declare.
 321         * elfread.c: Include mdebugread.h.
 322
 323 2019-01-09  Tom Tromey  <tom@tromey.com>
 324
 325         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 326         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 327         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 328         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 329         (psym_lookup_symbol, psym_find_last_source_symtab)
 330         (psym_forget_cached_source_info, psym_print_stats)
 331         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 332         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 333         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 334         (psym_find_compunit_symtab_by_address)
 335         (maintenance_print_psymbols, maintenance_info_psymtabs)
 336         (maintenance_check_psymtabs): Use ranged for.
 337         * psymtab.h (class objfile_psymtabs): New.
 338         (require_partial_symbols): Return objfile_psymtabs.
 339         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 340
 341 2019-01-09  Tom Tromey  <tom@tromey.com>
 342
 343         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 344         (find_pc_mapped_section, list_overlays_command)
 345         (map_overlay_command, unmap_overlay_command)
 346         (simple_overlay_update): Use all_objfiles.
 347         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 348         * printcmd.c (info_symbol_command): Use all_objfiles.
 349         * objfiles.h (ALL_OBJSECTIONS): Remove.
 350         * maint.c (maintenance_translate_address): Use all_objfiles.
 351         * gcore.c (gcore_create_callback): Use all_objfiles.
 352         (objfile_find_memory_regions): Likewise.
 353
 354 2019-01-09  Tom Tromey  <tom@tromey.com>
 355
 356         * symtab.c (find_line_symtab, info_sources_command)
 357         (make_source_files_completion_list): Use objfile_compunits.
 358         * source.c (select_source_symtab): Use objfile_compunits.
 359         * objfiles.h (struct objfile): Update comment.
 360         (ALL_OBJFILES): Remove.
 361         (ALL_FILETABS): Remove.
 362         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 363         objfile_compunits.
 364
 365 2019-01-09  Tom Tromey  <tom@tromey.com>
 366
 367         * symmisc.c (print_objfile_statistics, dump_objfile)
 368         (maintenance_print_symbols): Use compunit_filetabs.
 369         * source.c (forget_cached_source_info_for_objfile): Use
 370         compunit_filetabs.
 371         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 372         (ALL_FILETABS): Use compunit_filetabs.
 373         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 374         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 375
 376 2019-01-09  Tom Tromey  <tom@tromey.com>
 377
 378         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 379         (compunit_filetabs): New.
 380         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 381         compunit_filetabs.
 382         (info_sources_command, make_source_files_completion_list): Remove
 383         declaration.
 384         * symmisc.c (print_objfile_statistics, dump_objfile)
 385         (maintenance_print_symbols): Remove declaration.
 386         (maintenance_info_symtabs): Use compunit_filetabs.
 387         (maintenance_info_line_tables): Likewise.
 388         * source.c (select_source_symtab): Change local variable name.
 389         (forget_cached_source_info_for_objfile): Remove declaration.
 390         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 391         * objfiles.c (objfile_relocate1): Remove declaration.
 392         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 393         declaration.
 394         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 395         * coffread.c (coff_symtab_read): Remove declaration.
 396         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 397         compunit_filetabs.
 398
 399 2019-01-09  Tom Tromey  <tom@tromey.com>
 400
 401         * symtab.c (lookup_objfile_from_block)
 402         (find_pc_sect_compunit_symtab, search_symbols)
 403         (default_collect_symbol_completion_matches_break_on): Use
 404         objfile_compunits.
 405         * objfiles.h (ALL_COMPUNITS): Remove.
 406         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 407         * cp-support.c (add_symbol_overload_list_qualified): Use
 408         objfile_compunits.
 409         * ada-lang.c (ada_collect_symbol_completion_matches)
 410         (ada_add_global_exceptions): Use objfile_compunits.
 411
 412 2019-01-09  Tom Tromey  <tom@tromey.com>
 413
 414         * source.c (select_source_symtab)
 415         (forget_cached_source_info_for_objfile): Remove declaration.
 416         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 417         declaration.
 418         * maint.c (count_symtabs_and_blocks): Remove declaration.
 419         * cp-support.c (add_symbol_overload_list_qualified): Remove
 420         declaration.
 421         * coffread.c (coff_symtab_read): Remove declaration.
 422         * symtab.c (lookup_symbol_in_objfile_symtabs)
 423         (basic_lookup_transparent_type_1): Use objfile_compunits.
 424         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 425         (info_sources_command, search_symbols)
 426         (default_collect_symbol_completion_matches_break_on)
 427         (make_source_files_completion_list): Remove declaration.
 428         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 429         (ada_collect_symbol_completion_matches)
 430         (ada_add_global_exceptions): Remove declaration.
 431         * linespec.c (iterate_over_all_matching_symtabs): Use
 432         objfile_compunits.
 433         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 434         (class objfile_compunits): New.
 435         (ALL_COMPUNITS): Use objfile_compunits.
 436         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 437         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 438         objfile_compunits.
 439         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 440
 441 2019-01-09  Tom Tromey  <tom@tromey.com>
 442
 443         * symtab.c (search_symbols)
 444         (default_collect_symbol_completion_matches_break_on): Use
 445         objfile_msymbols.
 446         * ada-lang.c (ada_lookup_simple_minsym)
 447         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 448         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 449         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 450         objfile_msymbols.
 451         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 452         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 453         * objc-lang.c (find_methods): Use objfile_msymbols.
 454         (info_selectors_command, info_classes_command): Likewise.
 455         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 456         * objfiles.h (class objfile_msymbols): New.
 457         (ALL_OBJFILE_MSYMBOLS): Remove.
 458         (ALL_MSYMBOLS): Remove.
 459
 460 2019-01-09  Tom Tromey  <tom@tromey.com>
 461
 462         * common/next-iterator.h (next_adapter): Add Iterator template
 463         parameter.
 464         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 465         (class all_objfiles_safe): New.
 466         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 467         * objfiles.c (put_objfile_before): Update comment.
 468         (add_separate_debug_objfile): Likewise.
 469         (free_all_objfiles): Use all_objfiles_safe.
 470         (objfile_purge_solibs): Likewise.
 471
 472 2019-01-09  Tom Tromey  <tom@tromey.com>
 473
 474         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 475         (expand_symtab_containing_pc, lookup_static_symbol)
 476         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 477         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 478         all_objfiles.
 479         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 480         * breakpoint.c (create_overlay_event_breakpoint)
 481         (create_longjmp_master_breakpoint)
 482         (create_std_terminate_master_breakpoint)
 483         (create_exception_master_breakpoint): Use all_objfiles.
 484         * linux-thread-db.c (try_thread_db_load_from_pdir)
 485         (has_libpthread): Use all_objfiles.
 486         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 487         * linespec.c (iterate_over_all_matching_symtabs)
 488         (search_minsyms_for_name): Use all_objfiles.
 489         * maint.c (maintenance_info_sections): Use all_objfiles.
 490         * main.c (captured_main_1): Use all_objfiles.
 491         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 492         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 493         * guile/scm-pretty-print.c
 494         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 495         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 496         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 497         (maintenance_print_msymbols): Use all_objfiles.
 498         * source.c (select_source_symtab): Use all_objfiles.
 499         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 500         * symfile.c (remove_symbol_file_command)
 501         (expand_symtabs_matching, map_symbol_filenames): Use
 502         all_objfiles.
 503         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 504         all_objfiles.
 505         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 506         * objc-lang.c (find_methods): Use all_objfiles.
 507         * objfiles.c (have_partial_symbols, have_full_symbols)
 508         (have_minimal_symbols, qsort_cmp)
 509         (default_iterate_over_objfiles_in_search_order): Use
 510         all_objfiles.
 511         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 512         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 513         (maintenance_check_psymtabs): Use all_objfiles.
 514         (ALL_PSYMTABS): Remove.
 515         * compile/compile-object-run.c (do_module_cleanup): Use
 516         all_objfiles.
 517         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 518         * cp-support.c (add_symbol_overload_list_qualified): Use
 519         all_objfiles.
 520         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 521         Use all_objfiles.
 522         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 523         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 524         all_objfiles.
 525         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 526         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 527         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 528         Uses all_objfiles.
 529         * solib.c (solib_read_symbols): Use all_objfiles
 530
 531 2019-01-09  Tom Tromey  <tom@tromey.com>
 532
 533         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 534         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 535         all_objfiles.
 536         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 537         * symmisc.c (print_symbol_bcache_statistics)
 538         (print_objfile_statistics, maintenance_print_objfiles)
 539         (maintenance_info_symtabs, maintenance_check_symtabs)
 540         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 541         all_objfiles.
 542         * source.c (forget_cached_source_info): Use all_objfiles.
 543         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 544         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 545         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 546         * objfiles.c (update_section_map): Use all_objfiles.
 547         (shared_objfile_contains_address_p): Likewise.
 548         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 549         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 550
 551 2019-01-09  Tom Tromey  <tom@tromey.com>
 552
 553         * common/next-iterator.h: New file.
 554         * objfiles.h (class all_objfiles): New.
 555         (struct objfile_iterator): New.
 556
 557 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 558
 559         * NEWS: Move the description of the changed "frame", "select-frame",
 560          and "info frame" commands to the Changed commands section.
 561
 562 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 563
 564         * gdbtypes.c (check_stub_method_group): Remove handling of old
 565         mangling schemes.
 566         * linespec.c (find_methods): Likewise.
 567         * stabsread.c (read_member_functions): Likewise.
 568         * valops.c (search_struct_method): Likewise.
 569         (value_struct_elt_for_reference): Likewise.
 570         * NEWS: Mention this change.
 571
 572 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 573
 574         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 575         print_source_lines.
 576         * source.c (print_source_lines_base): Update line number check.
 577         (print_source_lines): New function.
 578         (source_lines_range::source_lines_range): New function.
 579         * source.h (class source_lines_range): New class.
 580         (print_source_lines): New declaration.
 581
 582 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 583
 584         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 585
 586 2019-01-08  Tom Tromey  <tom@tromey.com>
 587             Simon Marchi  <simon.marchi@ericsson.com>
 588
 589         PR gdb/24060
 590         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 591         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 592         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 593         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 594         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 595         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 596
 597 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 598
 599         * source.c (select_source_symtab): Move header comment to
 600         declaration in source.h.
 601         (forget_cached_source_info_for_objfile): Likewise.
 602         (forget_cached_source_info): Likewise.
 603         (identify_source_line): Likewise.
 604         * source.h (identify_source_line): Move declaration from symtab.h
 605         and add comment from source.c
 606         (print_source_lines): Likewise.
 607         (forget_cached_source_info_for_objfile): Likewise.
 608         (forget_cached_source_info): Likewise.
 609         (select_source_symtab): Likewise.
 610         (enum print_source_lines_flag): Move definition from symtab.h.
 611         * symtab.h (identify_source_line): Move declaration to source.h.
 612         (print_source_lines): Likewise.
 613         (forget_cached_source_info_for_objfile): Likewise.
 614         (forget_cached_source_info): Likewise.
 615         (select_source_symtab): Likewise.
 616         (enum print_source_lines_flag): Move definition to source.h.
 617         * tui/tui-hooks.c: Add 'source.h' include.
 618
 619 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 620
 621         * source.c (print_source_lines_base): Handle requests to print
 622         reverse line number sequences, and guard against empty lines
 623         string.
 624
 625 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 626
 627         * source.c (print_source_lines_base): Fix skip of '\r' if next
 628         character is '\n'.
 629
 630 2019-01-06  Tom Tromey  <tom@tromey.com>
 631
 632         * c-exp.y (struct c_parse_state) <macro_original_text,
 633         expansion_obstack>: New member.
 634         (macro_original_text, expansion_obstack): Remove globals.
 635         (scan_macro_expansion, scanning_macro_expansion)
 636         (finished_macro_expansion): Update.
 637         (scan_macro_cleanup): Remove.
 638         (yylex, c_parse): Update.
 639
 640 2019-01-06  Tom Tromey  <tom@tromey.com>
 641
 642         * c-exp.y (struct c_parse_state) <strings>: New member.
 643         (operator_stoken): Update.
 644
 645 2019-01-06  Tom Tromey  <tom@tromey.com>
 646
 647         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 648         (union type_stack_elt) <typelist_val>: Now a pointer to
 649         std::vector.
 650         (type_stack_cleanup): Don't declare.
 651         (push_typelist): Update.
 652         * parse.c (pop_typelist): Return a std::vector.
 653         (push_typelist): Take a std::vector.
 654         (follow_types): Update.  Do not free args.
 655         (type_stack_cleanup): Remove.
 656         * c-exp.y (struct c_parse_state): New.
 657         (cpstate): New global.
 658         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 659         (nonempty_typelist): Update.
 660         (func_mod): Create a new vector.
 661         (c_parse): Create a c_parse_state.
 662         (check_parameter_typelist): Do not delete params.
 663         (function_method): Update.  Do not delete type_list.
 664
 665 2019-01-06  Tom Tromey  <tom@tromey.com>
 666
 667         PR gdb/28155:
 668         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 669         check_typedef.
 670         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 671         (print_return_value): Likewise.
 672
 673 2019-01-05  Tom Tromey  <tom@tromey.com>
 674
 675         * contrib/cleanup_check.py: Remove.
 676         * contrib/gcc-with-excheck: Remove.
 677         * contrib/exsummary.py: Remove.
 678         * contrib/excheck.py: Remove.
 679
 680 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 681
 682         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 683         NULL. Initialize tpprev to NULL instead of assigning it
 684         to NULL on the next statement.
 685         * windows-nat.c (windows_delete_thread): Remove check for
 686         main_thread_id before printing thread exit notifications.
 687         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 688         Remove thread ID check against main_thread_id.
 689         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 690         windows_delete_thread.
 691         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 692
 693 2019-01-04  Tom Tromey  <tom@tromey.com>
 694
 695         * compile/compile.c (_initialize_compile): Use upper case for
 696         metasyntactic variables.
 697         * symmisc.c (_initialize_symmisc): Use upper case for
 698         metasyntactic variables.
 699         * psymtab.c (_initialize_psymtab): Use upper case for
 700         metasyntactic variables.
 701         * demangle.c (demangle_command): Use upper case for metasyntactic
 702         variables.
 703         (_initialize_demangler): Likewise.
 704         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 705         variables.
 706
 707 2019-01-03  Tom Tromey  <tom@tromey.com>
 708
 709         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
 710
 711 2019-01-03  Tom Tromey  <tom@tromey.com>
 712
 713         * python/py-symtab.c (salpy_str): Update.
 714         (struct salpy_sal_object) <symtab>: Now a PyObject.
 715         (salpy_dealloc): Update.
 716         (del_objfile_sal): Use gdbpy_ref.
 717
 718 2019-01-03  Tom Tromey  <tom@tromey.com>
 719
 720         * python/py-type.c (convert_field): Use new_reference.  Return
 721         gdbpy_ref.
 722         (make_fielditem): Return gdbpy_ref.
 723         (typy_fields): Update.
 724         (typy_getitem): Update.
 725         (field_name): Return gdbpy_ref.  Use new_reference.
 726         (typy_iterator_iternext): Update.
 727
 728 2019-01-03  Tom Tromey  <tom@tromey.com>
 729
 730         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
 731
 732 2019-01-03  Tom Tromey  <tom@tromey.com>
 733
 734         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
 735         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
 736         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
 737         (pspy_set_frame_filters, pspy_set_frame_unwinders)
 738         (pspy_set_type_printers): Likewise.
 739         * python/py-function.c (fnpy_init): Use gdbpy_ref.
 740         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
 741         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
 742         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
 743         (objfpy_set_type_printers): Likewise.
 744
 745 2019-01-03  Tom Tromey  <tom@tromey.com>
 746
 747         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
 748         (gdbpy_print_stack): Use gdbpy_err_fetch.
 749         * python/python-internal.h (class gdbpy_err_fetch): New class.
 750         (class gdbpy_enter) <m_error_type, m_error_value,
 751         m_error_traceback>: Remove.
 752         <m_error>: New member.
 753         (gdbpy_exception_to_string): Don't declare.
 754         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
 755         * python/py-value.c (convert_value_from_python): Use
 756         gdbpy_err_fetch.
 757         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
 758         gdbpy_exception_to_string.
 759         (gdbpy_handle_exception): Use gdbpy_err_fetch.
 760         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 761         gdbpy_err_fetch.
 762
 763 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 764
 765         * linux-nat.c (delete_lwp_cleanup): Delete.
 766         (struct lwp_deleter): New struct.
 767         (lwp_info_up): New typedef.
 768         (linux_nat_target::follow_fork): Delete cleanup, and make use of
 769         lwp_info_up.
 770
 771 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 772
 773         * linux-fork.c (class scoped_switch_fork_info): New class.
 774         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
 775
 776 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 777
 778         * valops.c (find_overload_match): Remove use of null_cleanup, and
 779         calls to do_cleanups.
 780
 781 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 782
 783         * compile/compile-cplus-types.c
 784         (compile_cplus_instance::decl_name): Handle changes to
 785         cp_func_name.
 786         * cp-support.c (cp_func_name): Update header comment, update
 787         return type.
 788         * cp-support.h (cp_func_name): Update return type in declaration.
 789         * valops.c (find_overload_match): Move temp_func local to top
 790         level of function and change its type.  Use temp_func to hold and
 791         delete temporary string obtained from cp_func_name.
 792
 793 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 794
 795         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
 796         gdb::char_vector, remove cleanup, and update uses of `msg`.
 797
 798 2019-01-03  Jim Wilson  <jimw@sifive.com>
 799
 800         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
 801
 802 2019-01-02  Tom Tromey  <tom@tromey.com>
 803
 804         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
 805         (tdesc_parse_xml): Remove cleanups.
 806         * target-descriptions.h (make_cleanup_free_target_description):
 807         Don't declare.
 808         (target_desc_deleter): New struct.
 809         (target_desc_up): New typedef.
 810         * target-descriptions.c (target_desc_deleter::operator()): Rename
 811         from free_target_description.
 812         (make_cleanup_free_target_description): Remove.
 813
 814 2019-01-02  Tom Tromey  <tom@tromey.com>
 815
 816         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
 817         constructor, destructor.
 818         (linespec_parser): Remove typedef.
 819         (~linespec_parser): Rename from linespec_parser_delete.
 820         (linespec_lex_to_end, linespec_complete_label)
 821         (linespec_complete): Update.
 822         (decode_line_full): Remove cleanups.
 823         (decode_line_1): Update.
 824
 825 2019-01-02  Tom Tromey  <tom@tromey.com>
 826
 827         * python/python-internal.h (inferior_to_inferior_object): Change
 828         return type.
 829         * python/py-exitedevent.c (create_exited_event_object): Update.
 830         * python/py-inferior.c (inferior_to_inferior_object): Return
 831         gdbpy_ref.
 832         (python_new_inferior, python_inferior_deleted)
 833         (thread_to_thread_object, delete_thread_object)
 834         (build_inferior_list, gdbpy_selected_inferior): Update.
 835         * python/py-infthread.c (create_thread_object): Update.  Also fail
 836         if inferior_to_inferior_object fails.
 837
 838 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
 839
 840         * inferior.h (class inferior) <displaced_step_state>: New field.
 841         * infrun.h (struct displaced_step_state): Move here from
 842         infrun.c.  Initialize fields, add constructor.
 843         <inf>: Remove field.
 844         <reset>: New method.
 845         * infrun.c (struct displaced_step_inferior_state): Move to
 846         infrun.h.
 847         (displaced_step_inferior_states): Remove.
 848         (get_displaced_stepping_state): Adust.
 849         (displaced_step_in_progress_any_inferior): Adjust.
 850         (displaced_step_in_progress_thread): Adjust.
 851         (displaced_step_in_progress): Adjust.
 852         (add_displaced_stepping_state): Remove.
 853         (get_displaced_step_closure_by_addr): Adjust.
 854         (remove_displaced_stepping_state): Remove.
 855         (infrun_inferior_exit): Call displaced_step_state.reset.
 856         (use_displaced_stepping): Don't check for NULL.
 857         (displaced_step_prepare_throw): Call
 858         get_displaced_stepping_state.
 859         (displaced_step_fixup): Don't check for NULL.
 860         (prepare_for_detach): Don't check for NULL.
 861
 862 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 863
 864         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
 865          in case of call that did not complete.
 866
 867 2019-01-02  Andrey Utkin  <autkin@undo.io>
 868
 869         * symfile.c (find_separate_debug_file): Fix search of debug files for
 870         remote debuggee.
 871
 872 2019-01-02  Tom Tromey  <tom@tromey.com>
 873
 874         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
 875         indentation.
 876         * python/py-frame.c (frapy_older): Remove cast.
 877         (frapy_newer): Likewise.
 878         * python/py-breakpoint.c (local_setattro): Remove cast.
 879         * python/py-arch.c (archpy_name): Remove local variable.
 880         * python/py-type.c (gdbpy_lookup_type): Remove cast.
 881
 882 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
 883
 884         * unittests/basic_string_view/element_access/char/empty.cc:
 885         Fix year range in copyright header.
 886
 887 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 888
 889         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
 890         Delete.
 891         <operator==>: Update with for removed field.
 892         <hash>: Likewise.
 893         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
 894         <isa_features>: ...this.
 895         <abi_features>: New field.
 896         (riscv_isa_flen): Update comment.
 897         (riscv_abi_xlen): New declaration.
 898         (riscv_abi_flen): New declaration.
 899         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
 900         isa_features.
 901         (riscv_abi_xlen): New function.
 902         (riscv_isa_flen): Update to get answer from isa_features.
 903         (riscv_abi_flen): New function.
 904         (riscv_has_fp_abi): Update to get answer from abi_features.
 905         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
 906         xlen and flen.
 907         (riscv_call_info) <xlen, flen>: Update comment.
 908         (riscv_call_arg_struct): Remove invalid assertions
 909         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
 910         is removed.
 911         (riscv_gdbarch_init): Gather isa features and abi features
 912         separately, ensure both match on the gdbarch when reusing an old
 913         gdbarch.  Relax an error check to allow 32-bit abi float to run on
 914         a target with 64-bit float hardware.
 915
 916 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 917
 918         * source.c (search_command_helper): Stop reverse search
 919         when line 1 has been searched.
 920
 921 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 922
 923         * record-full.c (record_full_base_target::close): Rewrite
 924         record_full_core_buf_list free logic.
 925
 926 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 927
 928         * break-catch-syscall.c (print_one_catch_syscall): xfree
 929         the last text.
 930
 931 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 932
 933         * top.c (print_gdb_version): Update Copyright year in version
 934         message.
 935
 936 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 937
 938         Update copyright year range in all GDB files.
 939
 940 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 941
 942         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
 943
 944 For older changes see ChangeLog-2018.
 945 \f
 946 Local Variables:
 947 mode: change-log
 948 left-margin: 8
 949 fill-column: 74
 950 version-control: never
 951 coding: utf-8
 952 End:
 953